Timeline
Nov 1, 2018:
- 11:35 PM Changeset in webkit [237721] by
-
- 11 edits1 delete in trunk/Source
Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>
Reviewed by Brent Fulgham.
Source/bmalloc:
- bmalloc/CryptoRandom.cpp:
(bmalloc::ARC4RandomNumberGenerator::stir):
Source/WebCore:
The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.
No change of behaviors.
- crypto/CommonCryptoUtilities.h:
- crypto/mac/CryptoKeyMac.cpp:
(WebCore::CryptoKey::randomData):
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):
- page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/RandomDevice.cpp:
(WTF::RandomDevice::cryptographicallyRandomValues):
- wtf/spi/darwin/CommonCryptoSPI.h: Removed.
- 9:11 PM Changeset in webkit [237720] by
-
- 5 edits in trunk
Web Inspector: View: introduce a didLayoutSubtree
https://bugs.webkit.org/show_bug.cgi?id=191176
Reviewed by Matt Baker.
Source/WebInspectorUI:
Introduce logic to allow subclasses of
WI.Viewto perform logic after everyWI.Viewin
their subtree has finishedlayout.
- UserInterface/Views/View.js:
(WI.View.prototype.didLayoutSubtree): Added.
(WI.View.prototype._layoutSubtree):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype.didLayoutSubtree): Added.
LayoutTests:
- inspector/view/resources/test-view.js:
(TestPage.registerInitializer.WI.TestView.prototype.layout):
(TestPage.registerInitializer.WI.TestView.prototype.didLayoutSubtree): Added.
- 8:50 PM Changeset in webkit [237719] by
-
- 7 edits in tags/Safari-607.1.12.1/Source
Versioning.
- 8:48 PM Changeset in webkit [237718] by
-
- 1 copy in tags/Safari-607.1.12.1
Tag Safari-607.1.12.1.
- 8:35 PM Changeset in webkit [237717] by
-
- 34 edits in trunk/Source/WebCore
[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
https://bugs.webkit.org/show_bug.cgi?id=191162
Reviewed by Alex Christensen.
Rename CallWith=ScriptState to CallWith=ExecState in our Web IDL as ScriptState is no longer a thing
in modern WebKit. The implementation is actually passed an ExecState nowadays.
- Modules/applepay/ApplePaySession.idl:
- Modules/encryptedmedia/MediaKeyStatusMap.idl:
- Modules/fetch/FetchBody.idl:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- animation/Animatable.idl:
- animation/KeyframeEffect.idl:
- animation/KeyframeEffectReadOnly.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
(GenerateConstructorDefinition):
- bindings/scripts/IDLAttributes.json:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithExecStateAttributeGetter):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttributeSetter):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpacesBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces):
(WebCore::jsTestObjWithScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpacesBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): Deleted.
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestPromiseRejectionEvent.idl:
- crypto/SubtleCrypto.idl:
- dom/Element.idl:
- dom/ErrorEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLFrameElement.idl:
- html/OffscreenCanvas.idl:
- html/track/DataCue.idl:
- inspector/CommandLineAPIHost.idl:
- page/DOMWindow.idl:
- page/RemoteDOMWindow.idl:
- page/WindowOrWorkerGlobalScope.idl:
- testing/Internals.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/Worker.idl:
- 7:04 PM Changeset in webkit [237716] by
-
- 2 edits in trunk/Tools
build-jsc --wincairo should update WinCairo libraries
https://bugs.webkit.org/show_bug.cgi?id=191170
Reviewed by Fujii Hironori.
- Scripts/build-jsc:
- 6:24 PM Changeset in webkit [237715] by
-
- 1 copy in tags/Safari-606.3.4.0.1
Tag Safari-606.3.4.0.1.
- 6:13 PM Changeset in webkit [237714] by
-
- 18 edits2 moves in trunk/Source
Rename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid conflicting with ICU's unicode/utf8.h
https://bugs.webkit.org/show_bug.cgi?id=189693
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- API/JSClassRef.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
- API/JSStringRef.cpp: Ditto.
- runtime/JSGlobalObjectFunctions.cpp: Ditto.
- wasm/WasmParser.h: Ditto.
Source/WebCore:
No new tests because there's no behaviro changes.
- platform/SharedBuffer.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
- xml/XSLTProcessorLibxslt.cpp: Ditto.
- xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.
Source/WebKit:
- Shared/API/APIString.h: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Replaced unicode/UTF8.{cpp,h} with unicode/UTF8Conversion.{cpp,h}.
- wtf/CMakeLists.txt: Ditto.
- wtf/text/AtomicStringImpl.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
- wtf/text/StringImpl.cpp: Ditto.
- wtf/text/StringView.cpp: Ditto.
- wtf/text/WTFString.cpp: Ditto.
- wtf/unicode/UTF8Conversion.cpp: Renamed from Source/WTF/wtf/unicode/UTF8.cpp.
- wtf/unicode/UTF8Conversion.h: Renamed from Source/WTF/wtf/unicode/UTF8.h.
- 5:58 PM Changeset in webkit [237713] by
-
- 2 edits in tags/Safari-607.1.10.8/Source/JavaScriptCore
Revert r237582. rdar://problem/45747609
- 5:58 PM Changeset in webkit [237712] by
-
- 3 edits1 delete in tags/Safari-607.1.10.8/Source/JavaScriptCore
Revert r237583. rdar://problem/45747609
- 5:51 PM Changeset in webkit [237711] by
-
- 4 edits1 add in trunk
In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>
Reviewed by Chris Dumez.
Source/WebCore:
New API test added.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
Tools:
This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
(-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
(-[KeyboardEventListener handleEvent:]):
(TestWebKitAPI::TEST):
- 5:46 PM Changeset in webkit [237710] by
-
- 7 edits in tags/Safari-607.1.10.8/Source
Versioning.
- 5:44 PM Changeset in webkit [237709] by
-
- 1 copy in tags/Safari-607.1.10.8
New tag.
- 5:27 PM Changeset in webkit [237708] by
-
- 7 edits in trunk/Source
Web Inspector: Network: remove unnecessary media event tracking
https://bugs.webkit.org/show_bug.cgi?id=191174
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, as this simply removes some event listeners for the WebInspector frontend.
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::addEventListenersToNode):
Source/WebInspectorUI:
Renames "Group by Node" to "Group Media Requests" for clarity.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.showRepresentedObject):
(WI.NetworkTableContentView.prototype.networkDetailViewClose):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._entryForDOMNode):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
(WI.NetworkTableContentView.prototype._restoreSelectedRow):
(WI.NetworkTableContentView.prototype._handleResourceEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleNodeEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
- UserInterface/Views/NetworkTableContentView.css:
(.network-table .data-container .cell.name .range): Added.
(.network-table .data-container .cell.name .range::before): Added.
(.network-table:focus .data-container li.selected .cell.name .range): Added.
(@media (prefers-dark-interface) .network-table .data-container .cell.name .range): Added.
Always display the "Byte Range" title as a "subtitle", regardless of the media requests
setting being toggled.
Drive-by: update the position of the waterfall popover whenever the time range changes.
Drive-by: close the details view if a node is selected and the media requests setting is
turned off.
- UserInterface/Views/Popover.js:
(WI.Popover.prototype.resize): Added.
(WI.Popover.prototype.handleEvent):
- Localizations/en.lproj/localizedStrings.js:
- 5:02 PM Changeset in webkit [237707] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.
- Configurations/JavaScriptCore.xcconfig:
- 4:49 PM Changeset in webkit [237706] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
https://bugs.webkit.org/show_bug.cgi?id=191020
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TimelineRuler.js:
(WI.TimelineRuler):
Sinceundefinedis not a number, it isn't less than0, which caused us to divide by
undefined(equivalent to dividing by0), resulting inNaN.
- 4:24 PM Changeset in webkit [237705] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173
Reviewed by Devin Rousso.
WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
- 4:22 PM Changeset in webkit [237704] by
-
- 2 edits in trunk/Source/WebKit
Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=191124
Reviewed by Tim Horton.
Remove the platform guard around the call to -_setUpSQLiteDatabaseTrackerClient as the
implementation of that message is already guarded.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- 4:19 PM Changeset in webkit [237703] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, attempt to fix the build with recent SDKs.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- 2:40 PM Changeset in webkit [237702] by
-
- 13 edits in trunk
Location object sans browsing context
https://bugs.webkit.org/show_bug.cgi?id=191060
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
- web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt:
Rebase WPT test now that all checks are passing.
- web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js:
Fix bug in WPT test (https://github.com/web-platform-tests/wpt/pull/13854)
- web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:
Source/WebCore:
As per https://github.com/whatwg/html/pull/4076, a Location object's URL should be "about:blank" when
it does not have a browsing context (Frame), not "".
No new tests, rebaselined existing tests.
- page/Location.cpp:
(WebCore::Location::url const):
(WebCore::Location::href const):
(WebCore::Location::protocol const):
(WebCore::Location::host const):
(WebCore::Location::hostname const):
(WebCore::Location::port const):
(WebCore::Location::pathname const):
(WebCore::Location::search const):
(WebCore::Location::origin const):
(WebCore::Location::hash const):
LayoutTests:
Update existing tests to reflect behavior change.
- http/tests/dom/same-origin-detached-window-properties-expected.txt:
- http/tests/dom/same-origin-detached-window-properties.html:
- http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
- http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
- http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
- http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:
- 2:19 PM Changeset in webkit [237701] by
-
- 3 edits in trunk/LayoutTests
[WinCairo] Unreviewed layout test gardening.
(Also remove one outdated global test failure.)
- TestExpectations:
- platform/wincairo/TestExpectations:
- 2:11 PM Changeset in webkit [237700] by
-
- 48 edits3 adds in trunk
Add a storage limit for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=190598
<rdar://problem/44654715>
Reviewed by Chris Dumez.
Source/WebCore:
Set a storage limit in IndexedDB for each pair of mainFrameOrigin and openingOrigin.
IndexedDB will return a QuotaExceededError if limit is reached.
If the size of free disk space is over 1 GB, the default limit is 500 MB; otherwise it is
half the free disk space.
Test: storage/indexeddb/storage-limit.html
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::setPerOriginQuota):
- Modules/indexeddb/server/IDBServer.h:
(WebCore::IDBServer::IDBServer::perOriginQuota const):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::quotaForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::maximumSize const):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::setQuota):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
Source/WebKit:
Add SPI for testing.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::setIDBPerOriginQuota):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetIDBPerOriginQuota):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setIDBPerOriginQuota):
- UIProcess/WebProcessPool.h:
Source/WebKitLegacy:
- Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::idbConnectionToServerForSession):
(WebDatabaseProvider::setIDBPerOriginQuota):
- Storage/WebDatabaseProvider.h:
Source/WebKitLegacy/mac:
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager setIDBPerOriginQuota:]):
- Storage/WebDatabaseManagerPrivate.h:
Source/WebKitLegacy/win:
- Interfaces/IWebDatabaseManager.idl:
- WebDatabaseManager.cpp:
(WebDatabaseManager::setIDBPerOriginQuota):
- WebDatabaseManager.h:
Tools:
Add API for testing.
- DumpRenderTree/TestRunner.cpp:
(setIDBPerOriginQuotaCallback):
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setIDBPerOriginQuota):
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setIDBPerOriginQuota):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setIDBPerOriginQuota):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::setIDBPerOriginQuota):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
LayoutTests:
Some tests will fail after adding storage limit to IndexedDB, so we need to reduce their
size and rebase their expectations.
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/key-type-array-private-expected.txt:
- storage/indexeddb/modern/idbkey-array-equality-expected.txt:
- storage/indexeddb/modern/idbkey-array-equality-private-expected.txt:
- storage/indexeddb/modern/resources/idbkey-array-equality.js:
(request.onsuccess):
(request.onerror):
(doAdd):
- storage/indexeddb/prefetch-invalidation-expected.txt:
- storage/indexeddb/prefetch-invalidation-private-expected.txt:
- storage/indexeddb/resources/key-type-array.js:
(testValidArrayKeys.getreq.onsuccess):
(testValidArrayKeys.putreq.onsuccess):
(testValidArrayKeys.testArrayPutGet):
- storage/indexeddb/resources/prefetch-invalidation.js:
(cursorRequest.onsuccess):
(continue50Times):
(continue100Times): Deleted.
- storage/indexeddb/resources/storage-limit.js: Added.
(prepareDatabase):
(onOpenSuccess.request.onerror):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
- storage/indexeddb/storage-limit-expected.txt: Added.
- storage/indexeddb/storage-limit.html: Added.
- 1:53 PM Changeset in webkit [237699] by
-
- 6 edits in trunk
[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191076
Reviewed by Geoffrey Garen.
Source/WebKit:
WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping.
The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading
the wrong URL.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):
- UIProcess/WebProcessPool.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate init]):
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
- 1:46 PM Changeset in webkit [237698] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.
- platform/mac-wk1/TestExpectations:
- 1:35 PM Changeset in webkit [237697] by
-
- 34 edits6 adds in trunk
CSS Custom Properties API Should Support syntax="*" and "<length>", and handle cycles properly
https://bugs.webkit.org/show_bug.cgi?id=191042
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
- web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
- web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt:
- web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt:
- web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles-expected.txt:
- web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:
Source/WebCore:
Refactor code so that:
- All properties applied in StyleResolver::applyMatchedProperties are only applied once.
- Custom properties are only resolved once, in StyleResolver, when they are applied to the RenderStyle. They were previously resolved every time they were referenced, and again in RenderStyle.
- The font-size property is applied after its variable references, but before custom properties that depend on it.
- Cycles are detected at the same time as resolution.
- MutableStyleProperties' custom properties cannot be set from Javascript or WebKitLegacy if they do not parse for the property's type. If they contain var(--...) references, however, then they can be set because we cannot check if the references are valid from setProperty. This behaviour matches chrome, but is not documented in the spec.
- Custom property values have more explicit resolved/unresolved state.
- RenderStyle only ever holds resolved custom properties, and StyleResolver::CascadedProperties only holds unresolved properties.
Tests: css-custom-properties-api/crash.html
css-custom-properties-api/cycles.html
css-custom-properties-api/inline.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):
- css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::equals const):
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
(WebCore::CSSCustomPropertyValue::checkVariablesForCycles const): Deleted.
(WebCore::CSSCustomPropertyValue::resolveVariableReferences const): Deleted.
(WebCore::CSSCustomPropertyValue::setResolvedTypedValue): Deleted.
- css/CSSCustomPropertyValue.h:
- css/CSSRegisteredCustomProperty.cpp:
(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty):
- css/CSSRegisteredCustomProperty.h:
- css/CSSVariableData.cpp:
(WebCore::CSSVariableData::CSSVariableData):
(WebCore::CSSVariableData::consumeAndUpdateTokens): Deleted.
(WebCore::CSSVariableData::checkVariablesForCycles const): Deleted.
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const): Deleted.
(WebCore::CSSVariableData::resolveVariableFallback const): Deleted.
(WebCore::CSSVariableData::resolveVariableReference const): Deleted.
(WebCore::CSSVariableData::resolveVariableReferences const): Deleted.
(WebCore::CSSVariableData::resolveTokenRange const): Deleted.
- css/CSSVariableData.h:
(WebCore::CSSVariableData::create):
(WebCore::CSSVariableData::createResolved): Deleted.
(WebCore::CSSVariableData::needsVariableResolution const): Deleted.
(WebCore::CSSVariableData::CSSVariableData): Deleted.
- css/CSSVariableReferenceValue.cpp:
(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):
(WebCore::CSSVariableReferenceValue::checkVariablesForCycles const): Deleted.
- css/CSSVariableReferenceValue.h:
(WebCore::CSSVariableReferenceValue::create):
(WebCore::CSSVariableReferenceValue::equals const):
(WebCore::CSSVariableReferenceValue::variableDataValue const): Deleted.
- css/DOMCSSRegisterCustomProperty.cpp:
(WebCore::DOMCSSRegisterCustomProperty::registerProperty):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialCustomProperty):
(WebCore::StyleBuilderCustom::applyValueCustomProperty):
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setCustomProperty):
- css/StyleProperties.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedCustomProperty):
(WebCore::StyleResolver::applyCascadedProperties):
- css/StyleResolver.h:
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences):
- css/parser/CSSParser.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::CSSPropertyParser):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::parseSingleValue):
- css/parser/CSSPropertyParser.h:
- css/parser/CSSVariableParser.cpp:
(WebCore::CSSVariableParser::parseDeclarationValue):
- dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::checkVariablesInCustomProperties): Deleted.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):
- rendering/style/StyleCustomPropertyData.h:
(WebCore::StyleCustomPropertyData::operator== const):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
(): Deleted.
LayoutTests:
- css-custom-properties-api/crash-expected.txt: Added.
- css-custom-properties-api/crash.html: Added.
- css-custom-properties-api/cycles-expected.txt: Added.
- css-custom-properties-api/cycles.html: Added.
- css-custom-properties-api/inline-expected.txt: Added.
- css-custom-properties-api/inline.html: Added.
- 12:49 PM Changeset in webkit [237696] by
-
- 28 edits in trunk
Skip tests on arm/mips that time out now we're running on CLoop
Unreviewed gardening.
Since the JIT is temporarily disabled on 32-bit platforms, these tests
time out on the bots and need to be disabled. There's more tests
disabled on arm because the timeout is longer on the mips bot (as the
device is slower to start with), so many of the tests don't time out
there.
JSTests:
- microbenchmarks/getter-richards.js: disable on arm and mips.
- stress/op_add.js: disable on arm.
- stress/op_bitand.js: disable on arm.
- stress/op_bitor.js: disable on arm.
- stress/op_bitxor.js: disable on arm.
- stress/op_lshift-ConstVar.js: disable on arm.
- stress/op_lshift-VarConst.js: disable on arm.
- stress/op_lshift-VarVar.js: disable on arm.
- stress/op_mod-ConstVar.js: disable on arm.
- stress/op_mod-VarConst.js: disable on arm.
- stress/op_mod-VarVar.js: disable on arm.
- stress/op_mul-ConstVar.js: disable on arm.
- stress/op_mul-VarConst.js: disable on arm.
- stress/op_mul-VarVar.js: disable on arm.
- stress/op_rshift-ConstVar.js: disable on arm.
- stress/op_rshift-VarConst.js: disable on arm.
- stress/op_rshift-VarVar.js: disable on arm.
- stress/op_sub-ConstVar.js: disable on arm.
- stress/op_sub-VarConst.js: disable on arm.
- stress/op_sub-VarVar.js: disable on arm.
- stress/op_urshift-ConstVar.js: disable on arm.
- stress/op_urshift-VarConst.js: disable on arm.
- stress/op_urshift-VarVar.js: disable on arm.
- stress/spread-forward-call-varargs-stack-overflow.js: disable on arm.
- stress/value-to-boolean.js: disable on arm and mips.
LayoutTests:
- js/script-tests/regress-139548.js: disable on arm and mips.
- 12:13 PM Changeset in webkit [237695] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r237652): Web Inspector: dumpInspectorProtocolMessages is always enabled
https://bugs.webkit.org/show_bug.cgi?id=191161
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):
- 12:12 PM Changeset in webkit [237694] by
-
- 4 edits in trunk/LayoutTests
Web Inspector: fix debug WK1 test failures for WI.ObjectStore
https://bugs.webkit.org/show_bug.cgi?id=191158
Reviewed by Joseph Pecoraro.
- inspector/unit-tests/objectStore/delete.html:
- inspector/unit-tests/objectStore/deleteObject.html:
- inspector/unit-tests/objectStore/resources/objectStore-utilities.js:
(TestPage.registerInitializer):
- 11:58 AM Changeset in webkit [237693] by
-
- 5 edits18 adds3 deletes in trunk/LayoutTests
Resync html/browsers/history/the-location-interface web platform tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=191139
Reviewed by Alex Christensen.
Resync html/browsers/history/the-location-interface web platform tests from upstream 8295368c82.
- web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_assign-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_assign.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Added.
(test):
(bcLessLocation):
(forEach.testSetup.testSetup.values.forEach.value.test):
(string_appeared_here.forEach.method.string_appeared_here.forEach.value.test):
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/w3c-import.log:
- web-platform-tests/html/browsers/history/the-location-interface/per-global.window-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/per-global.window.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-1.html: Removed.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-expected.txt: Removed.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html: Removed.
- web-platform-tests/html/browsers/history/the-location-interface/resources/reload_post_1-1.py: Added.
(main):
- web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log:
- web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:
- 11:57 AM Changeset in webkit [237692] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: Toggle selected properties by pressing Space or Command+/
https://bugs.webkit.org/show_bug.cgi?id=181145
<rdar://problem/36203388>
Reviewed by Brian Burg.
Pressing Space key or Command-/ toggles (comments out or uncomments) selected properties.
This patch only works with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get selectionRange):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.update): Renamed from _update.
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.applyFilter):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
Makeupdatemethod public. No other changes were made.
- 11:49 AM Changeset in webkit [237691] by
-
- 6 edits in trunk
[CG] Adopt CG SPI for non-even cornered rounded rects
https://bugs.webkit.org/show_bug.cgi?id=190155
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-01
Reviewed by Simon Fraser.
Source/WebCore:
Instead of creating bezier curves for the non-even corners of the rounded
rects, we should use the optimized SPI provided by CG.
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
Source/WebCore/PAL:
- pal/spi/cg/CoreGraphicsSPI.h:
LayoutTests:
This test fails on iOS simulator because of just one pixel difference
between drawing a shadow of the element and drawing a copy of the element.
This failure happens on iOS and does not happen on macOS because we don't
use accelerated drawing for macOS testing but we use it for iOS testing.
- platform/ios/TestExpectations:
- 11:33 AM WebKitGTK/2.22.x edited by
- (diff)
- 11:32 AM Changeset in webkit [237690] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Tools
Merged r237680 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>
Unreviewed build fix.
This adds the missing compilation guards in the WPE MiniBrowser.
- MiniBrowser/wpe/main.cpp:
(main): Condition GST includes and calls.
- 11:32 AM Changeset in webkit [237689] by
-
- 8 edits in releases/WebKitGTK/webkit-2.22
Merged r237677 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
Reviewed by Philippe Normand.
Source/WebCore:
Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.
- Modules/mediasource/VideoPlaybackQuality.cpp:
- Modules/mediasource/VideoPlaybackQuality.h:
- Modules/mediasource/VideoPlaybackQuality.idl:
- dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
- inspector/agents/InspectorDOMAgent.h:
- rendering/RenderThemeGtk.cpp:
Tools:
- MiniBrowser/gtk/main.c:
(main): Condition GST includes and calls
- 11:18 AM Changeset in webkit [237688] by
-
- 4 edits in trunk
RTCTrackEvent.streams should be SameObject
https://bugs.webkit.org/show_bug.cgi?id=191130
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:
Source/WebCore:
Mimick SameObject using CachedAttribute.
Covered by rebased test.
- Modules/mediastream/RTCTrackEvent.idl:
- 11:02 AM Changeset in webkit [237687] by
-
- 2 edits in trunk/Websites/webkit.org
Prevent homepage animation for users that prefer reduced motion
https://bugs.webkit.org/show_bug.cgi?id=188211
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/front-header.php:
- 10:35 AM Changeset in webkit [237686] by
-
- 7 edits in branches/safari-606.3.4.2-branch/Source
Versioning.
- 10:33 AM Changeset in webkit [237685] by
-
- 7 edits in branches/safari-606.3.4.1-branch/Source
Versioning.
- 10:30 AM Changeset in webkit [237684] by
-
- 7 edits in branches/safari-606.3.4.0-branch/Source
Versioning.
- 10:09 AM Changeset in webkit [237683] by
-
- 5 edits3 adds in trunk
[PSON] Unable to submit a file in FormData cross-site
https://bugs.webkit.org/show_bug.cgi?id=191138
Reviewed by Alex Christensen.
Source/WebKit:
When PSON is enabled, we are unable to submit a file in FormData cross-site. Although we encode the
request body over IPC since r237639, we're missing the right sandbox extensions for its to work for
files.
Update FormDataReference encoder to pass along the necessary sandbox extensions for files in the
FormData, and have its decoder consume those extensions so that the recipient has access to those
files. Also update LoadParameters's IPC encoder / decoder to encoder an IPC::FormDataReference
(which encodes both FormData and sandbox extensions) instead of a FormData.
- Platform/IPC/FormDataReference.h:
(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):
- Shared/LoadParameters.cpp:
(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):
LayoutTests:
Add layout test coverage.
- http/tests/misc/form-submit-file-cross-site-expected.txt:
- http/tests/misc/form-submit-file-cross-site.html:
- 9:40 AM Changeset in webkit [237682] by
-
- 2 edits in trunk/Source/WebKit
ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
https://bugs.webkit.org/show_bug.cgi?id=191152
Reviewed by Chris Dumez.
The statistics file is not created unconditionally, so
make sure it exists before logging an error.
- UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.
- 9:11 AM Changeset in webkit [237681] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test fix after r237670.
- inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
- inspector/canvas/setRecordingAutoCaptureFrameCount.html:
- 8:21 AM WebKitGTK/2.22.x edited by
- (diff)
- 8:19 AM Changeset in webkit [237680] by
-
- 2 edits in trunk/Tools
Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>
Unreviewed build fix.
This adds the missing compilation guards in the WPE MiniBrowser.
- MiniBrowser/wpe/main.cpp:
(main): Condition GST includes and calls.
- 7:20 AM Changeset in webkit [237679] by
-
- 12 edits2 adds in trunk
[LFC][IFC] Add support for inline-block elements.
https://bugs.webkit.org/show_bug.cgi?id=191143
Reviewed by Antti Koivisto.
Source/WebCore:
This patch add support for laying out non-shrink-to-width inline-block elements.
Test: fast/inline/simple-inline-block.html
- layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):
- layout/layouttree/LayoutInlineContainer.cpp:
(WebCore::Layout::InlineContainer::establishesInlineFormattingContext const):
- layout/layouttree/LayoutInlineContainer.h:
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createSubTree):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/inline/simple-inline-block-expected.txt: Added.
- fast/inline/simple-inline-block.html: Added.
- platform/ios/TestExpectations:
- 6:35 AM Changeset in webkit [237678] by
-
- 2 edits1 add in trunk/Tools
[WPE] Add missing libsoup patch to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=191149
Reviewed by Žan Doberšek.
- wpe/jhbuild.modules:
- wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
- 5:14 AM WebKitGTK/2.22.x edited by
- (diff)
- 4:29 AM WebKitGTK/2.22.x edited by
- (diff)
- 4:27 AM Changeset in webkit [237677] by
-
- 10 edits in trunk
Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
Reviewed by Philippe Normand.
Source/WebCore:
Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.
- Modules/mediasource/VideoPlaybackQuality.cpp:
- Modules/mediasource/VideoPlaybackQuality.h:
- Modules/mediasource/VideoPlaybackQuality.idl:
- dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
- inspector/agents/InspectorDOMAgent.h:
- rendering/RenderThemeGtk.cpp:
Tools:
- MiniBrowser/gtk/main.c:
(main): Condition GST includes and calls
- 3:03 AM Changeset in webkit [237676] by
-
- 2 edits in trunk/Source/WebKit
[GLIB] Silent a build warning when not using Wayland
Unreviewed.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
- 2:27 AM Changeset in webkit [237675] by
-
- 2 edits in trunk/LayoutTests
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>
Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-11-01
Reviewed by Youenn Fablet.
Remove share FileReader object between three asynchronous tests which might cause flaky failure.
We will need to fix all the falky failures in this test after we implement timeslice.
- http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
- 1:51 AM Changeset in webkit [237674] by
-
- 2 edits in trunk/Source/WebKit
[WebAuthN] Make AuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=189279
Unreviewed build fix.
Patch by Frederic Wang <fwang@igalia.com> on 2018-11-01
- UIProcess/WebAuthentication/Cocoa/LocalConnection.h: Add missing headers.
Oct 31, 2018:
- 9:30 PM Changeset in webkit [237673] by
-
- 1 copy in branches/safari-606.3.4.2-branch
New branch.
- 9:30 PM Changeset in webkit [237672] by
-
- 1 copy in branches/safari-606.3.4.1-branch
New branch.
- 9:18 PM Changeset in webkit [237671] by
-
- 1 copy in branches/safari-606.3.4.0-branch
New branch.
- 9:13 PM Changeset in webkit [237670] by
-
- 25 edits2 adds in trunk
Web Inspector: Canvas: create a setting for auto-recording newly created contexts
https://bugs.webkit.org/show_bug.cgi?id=190856
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/Canvas.json:
Add
setRecordingAutoCaptureFrameCountcommand for setting the number of frames to record
immediately after a context is created.
- inspector/protocol/Recording.json:
Add
creationvalue forInitiatorenum.
Source/WebCore:
Test: inspector/canvas/setRecordingAutoCaptureFrameCount.html
- inspector/agents/InspectorCanvasAgent.h:
(WebCore::InspectorCanvasAgent::RecordingOptions): Added.
- inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::setRecordingAutoCaptureFrameCount): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):
(WebCore::InspectorCanvasAgent::startRecording): Added.
Unify the different functions that are able to start a recording to use a single path.
- inspector/InspectorCanvas.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::setFrameCount): Added.
(WebCore::InspectorCanvas::overFrameCount const): Added.
Source/WebInspectorUI:
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.supportsRecordingAutoCapture): Added.
(WI.CanvasManager.prototype.setRecordingAutoCaptureFrameCount): Added.
- UserInterface/Models/Canvas.js:
(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingStarted):
(WI.Canvas.prototype.recordingFinished):
- UserInterface/Models/Recording.js:
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.get navigationItems):
(WI.CanvasOverviewContentView.prototype.initialLayout): Added.
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount): Added.
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureEnabledChanged): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged): Added.
- UserInterface/Views/CanvasOverviewContentView.css:
(.navigation-bar > .item.canvas-recording-auto-capture > label): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Added.
(.popover-content > .tree-outline .item.recording > .icon): Deleted.
(.popover-content > .tree-outline .item.recording:hover): Deleted.
(.popover-content > .tree-outline .item.recording:hover > .icon): Deleted.
Drive-by: removed unused CSS rules.
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._updateProgressView):
(WI.CanvasContentView.prototype._updateViewRelatedItems):
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype._recordingImportedOrStopped):
- UserInterface/Views/CheckboxNavigationItem.js:
(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype._handleLabelClick): Added.
- UserInterface/Base/Setting.js:
- Localizations/en.lproj/localizedStrings.js:
LayoutTests:
- inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer.window.startRecording):
(TestPage.registerInitializer.handleRecordingProgress):
- inspector/canvas/recording-2d.html:
- inspector/canvas/recording-bitmaprenderer.html:
- inspector/canvas/recording-webgl-snapshots.html:
- inspector/canvas/recording-webgl.html:
- inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt: Added.
- inspector/canvas/setRecordingAutoCaptureFrameCount.html: Added.
- 9:12 PM Changeset in webkit [237669] by
-
- 15 edits in trunk/Source
Web Inspector: display low-power enter/exit events in Timelines and Network node waterfalls
https://bugs.webkit.org/show_bug.cgi?id=190641
<rdar://problem/45319049>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Add
videoLowPowerChangedevent that is fired whenInspectorDOMAgentis able to determine
whether a video element's low power state has changed.
Source/WebCore:
No new tests, as low power mode is indeterminate. Should not affect functionality.
- inspector/agents/InspectorDOMAgent.h:
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::addEventListenersToNode):
(WebCore::InspectorDOMAgent::mediaMetricsTimerFired): Added.
Source/WebInspectorUI:
- UserInterface/Protocol/DOMObserver.js:
(WI.DOMObserver.prototype.videoLowPowerChanged): Added.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.videoLowPowerChanged): Added.
- UserInterface/Models/DOMNode.js:
(WI.DOMNode):
(WI.DOMNode.prototype.get lowPowerRanges): Added.
(WI.DOMNode.prototype.videoLowPowerChanged): Added.
(WI.DOMNode.prototype.canEnterLowPowerMode): Added.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateDomainCell):
(WI.NetworkTableContentView.prototype._tryLinkResourceToDOMNode):
(WI.NetworkTableContentView.prototype._handleNodeLowPowerChanged): Added.
- UserInterface/Views/NetworkTableContentView.css:
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area):
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.low-power): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-fullscreen): Deleted.
- UserInterface/Views/DOMNodeEventsContentView.js:
(WI.DOMNodeEventsContentView):
(WI.DOMNodeEventsContentView.prototype.initialLayout):
(WI.DOMNodeEventsContentView.prototype.closed): Deleted.
(WI.DOMNodeEventsContentView.prototype._handleDOMNodeDidFireEvent): Deleted.
- UserInterface/Views/DOMEventsBreakdownView.js:
(WI.DOMEventsBreakdownView):
(WI.DOMEventsBreakdownView.prototype.initialLayout):
(WI.DOMEventsBreakdownView.prototype.layout): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeDidFireEvent): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeLowPowerChanged): Added.
(WI.DOMEventsBreakdownView.prototype.addEvent): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable.percentOfTotalTime): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable): Deleted.
- UserInterface/Views/DOMEventsBreakdownView.css:
(.dom-events-breakdown .graph > .area): Added.
(.dom-events-breakdown .graph > .area.fullscreen):
(.dom-events-breakdown .graph > .area.low-power): Added.
- Localizations/en.lproj/localizedStrings.js:
- 9:08 PM Changeset in webkit [237668] by
-
- 2 edits in trunk/Tools
Add Justin Michaud to the list of WebKit Committers
https://bugs.webkit.org/show_bug.cgi?id=191142
- Scripts/webkitpy/common/config/contributors.json:
- 7:11 PM Changeset in webkit [237667] by
-
- 2 edits in trunk/Source/WebKit
API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>
Reviewed by Dean Jackson.
Followup to r237648: also make sure that we insecurely unarchive NSFileWrapper on platforms that don't support
secure archiving of file wrappers.
- UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::updateFromSerializedRepresentation):
- 6:18 PM Changeset in webkit [237666] by
-
- 2 edits in trunk/Source/WebKitLegacy/win
[Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=191105
Reviewed by Brent Fulgham.
- DOMHTMLClasses.h:
(DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
instead of own setNodeValue.
- 6:18 PM Changeset in webkit [237665] by
-
- 8 edits14 adds in trunk
Web Inspector: Audit: save imported audits across WebInspector sessions
https://bugs.webkit.org/show_bug.cgi?id=190858
<rdar://problem/45527625>
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Base/ObjectStore.js: Added.
(WI.ObjectStore):
(WI.ObjectStore.supported):
(WI.ObjectStore._open):
(WI.ObjectStore.get _databaseName):
(WI.ObjectStore.prototype.associateObject):
(WI.ObjectStore.prototype.async getAll):
(WI.ObjectStore.prototype.async add):
(WI.ObjectStore.prototype.async addObject):
(WI.ObjectStore.prototype.async delete):
(WI.ObjectStore.prototype.async deleteObject):
(WI.ObjectStore.prototype._resolveKeyPath):
(WI.ObjectStore.prototype.async _operation.listener):
(WI.ObjectStore.prototype.async _operation):
Wrapper for a globalIndexedDBinstance for all of WebInspector (per level). Instances of
WI.ObjectStoreare able to control a givenIDBObjectStoreusing a promise-based API.
*NOTE*: due to the constraint that
IDBObjectStores are only able to be created when the
ownerIndexedDBis "upgrade"d, allWI.ObjectStoremust be declared before the database
is opened for the first time. Additionally, any time a newWI.ObjectStoreis added, the
versionneeds to be incremented to ensure that the "upgrade" event fires.
To use any of the
*Objectfunctions, one must implement atoJSONon the object provided.
This is so thatWI.ObjectStoreis able to add the resulting identifier value to the owner
object while storing itstoJSONvalue in the IndexedDB (e.g. for objects that have cycles).
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.import):
(WI.AuditManager.prototype.loadStoredTests): Added.
(WI.AuditManager.prototype.removeTest): Added.
(WI.AuditManager.prototype._addTest):
- UserInterface/Views/AuditTabContentView.js:
(WI.AuditTabContentView.prototype.initialLayout): Added.
Attempt to load stored audits when the Audit tab is first shown (lazy-load).
- UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved): Added.
- UserInterface/Views/AuditTreeElement.js:
(WI.AuditTreeElement.prototype.ondelete):
Only allow top-level audits to be deleted, as that is what matches theWI.ObjectStore.
- UserInterface/Main.html:
- UserInterface/Test.html:
LayoutTests:
- inspector/unit-tests/objectStore/add-expected.txt: Added.
- inspector/unit-tests/objectStore/add.html: Added.
- inspector/unit-tests/objectStore/addObject-expected.txt: Added.
- inspector/unit-tests/objectStore/addObject.html: Added.
- inspector/unit-tests/objectStore/basic-expected.txt: Added.
- inspector/unit-tests/objectStore/basic.html: Added.
- inspector/unit-tests/objectStore/delete-expected.txt: Added.
- inspector/unit-tests/objectStore/delete.html: Added.
- inspector/unit-tests/objectStore/deleteObject-expected.txt: Added.
- inspector/unit-tests/objectStore/deleteObject.html: Added.
- inspector/unit-tests/objectStore/resources/objectStore-utilities.js: Added.
(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject.prototype.toJSON):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createSuite):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createObjectStore):
(TestPage.registerInitializer.InspectorTest.ObjectStore.add):
(TestPage.registerInitializer.InspectorTest.ObjectStore.addObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.delete):
(TestPage.registerInitializer.InspectorTest.ObjectStore.deleteObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.logValues):
(TestPage.registerInitializer.InspectorTest.ObjectStore.wrapTest):
- 6:03 PM Changeset in webkit [237664] by
-
- 2 edits in trunk/Source/WebKit
Forward original fragment identifier into System Preview
https://bugs.webkit.org/show_bug.cgi?id=191141
<rdar://problem/45717542>
Reviewed by Wenson Hsieh.
If the URL used by the page includes a fragment identifier, use
it when telling QuickLook to open a local file.
- UIProcess/Cocoa/DownloadClient.mm:
(WebKit::DownloadClient::didFinish): Append original fragment identifier
to the destination URL.
- 5:39 PM Changeset in webkit [237663] by
-
- 1 copy in tags/Safari-607.1.12
Tag Safari-607.1.12.
- 5:39 PM Changeset in webkit [237662] by
-
- 7 edits in trunk/Source
Versioning.
- 5:37 PM Changeset in webkit [237661] by
-
- 16 edits in trunk/Source/WebInspectorUI
Web Inspector: Move a few remaining global WI settings to WI.settings
https://bugs.webkit.org/show_bug.cgi?id=191137
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-31
Reviewed by Brian Burg.
Move and better name some of the WI.settings created in Main.js
to WI.settings, alongside other global settings.
- UserInterface/Base/Main.js:
(WI.loaded):
Move settings, and register for settings changes in contentLoaded.
- UserInterface/Base/Setting.js:
New settings, and sort values.
- UserInterface/Test/Test.js:
(WI.loaded):
Update setting values for tests.
- UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.initializeTarget):
- UserInterface/Controllers/RuntimeManager.js:
(WI.RuntimeManager.prototype.initializeTarget):
- UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.get children):
(WI.DOMNode.prototype.get nextSibling):
(WI.DOMNode.prototype.get previousSibling):
(WI.DOMNode.prototype.get childNodeCount):
- UserInterface/Protocol/Target.js:
(WI.Target.prototype.initialize):
- UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype._togglePaintFlashing):
(WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
(WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged):
(WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting):
- UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.close):
(WI.DOMTreeOutline.prototype._revealAndSelectNode):
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout):
(WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers):
- UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.closed):
(WI.Layers3DContentView.prototype._showPaintRectsSettingChanged):
(WI.Layers3DContentView.prototype._togglePaintFlashing):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.closed):
(WI.NetworkTableContentView.prototype._resourceCachingDisabledSettingChanged):
(WI.NetworkTableContentView.prototype._toggleDisableResourceCache):
- UserInterface/Views/ScriptContentView.js:
(WI.ScriptContentView):
(WI.ScriptContentView.prototype.closed):
(WI.ScriptContentView.prototype._contentDidPopulate):
(WI.ScriptContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype.shown):
(WI.SourceCodeTextEditor.prototype._proceedPopulateWithContent):
(WI.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
(WI.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled):
- UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView):
(WI.TextResourceContentView.prototype.closed):
(WI.TextResourceContentView.prototype._contentDidPopulate):
(WI.TextResourceContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
Renamed setting.
- 4:57 PM Changeset in webkit [237660] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: missing contextmenu items for links
https://bugs.webkit.org/show_bug.cgi?id=191021
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._handleLinkContextMenu): Added.
If the token is subtype of "link", add contextmenu items to the wrapper element.
- UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForURL.showResourceWithOptions):
(WI.appendContextMenuItemsForURL):
Drive-by: don't assume thatoptionswill be provided.
- Localizations/en.lproj/localizedStrings.js:
- 3:52 PM Changeset in webkit [237659] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: implement copying and deletion of multiple properties
https://bugs.webkit.org/show_bug.cgi?id=191037
<rdar://problem/45650078>
Reviewed by Brian Burg.
This patch should only work with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.
Mousedown on a property (1) and moving the mouse cursor to another property (2) should select properties 1, 2, and
all properties between them until mouseup is fired.
Once selected:
- Pressing Command-C should copy the selected properties.
- Pressing Delete should remove the properties.
- UserInterface/Models/CSSProperty.js:
(WI.CSSProperty.prototype.get formattedText):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property):
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus):
(@media (prefers-dark-interface)):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.deselectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._hasSelectedProperties):
Property selection is defined as two numbers: anchorIndex and focusIndex.
The property with focusIndex is actually focused. The focus outline is replaced by a more subtle left blue border.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration.selecting,):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowMouseUp):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty):
Implement copying the same way it's done for DataGrid: by adding copyHandler property to the focused element.
AddtabIndex=-1so the property element can be focused.
(WI.SpreadsheetStyleProperty.prototype.get property):
(WI.SpreadsheetStyleProperty.prototype.get selected):
(WI.SpreadsheetStyleProperty.prototype.set selected):
(WI.SpreadsheetStyleProperty.prototype.remove):
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
(WI.SpreadsheetStyleProperty.prototype._handleNamePaste):
- 3:44 PM Changeset in webkit [237658] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Do not paint tap highlight unless it is above a certain threshold
https://bugs.webkit.org/show_bug.cgi?id=191134
<rdar://problem/43615142>
Flashing a large portion of the screen on every tap looks unpleasant.
This patch impoves the existing heuristic by adding area check and a % threshold.
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
(highlightedQuadsAreSmallerThanRect): Deleted.
- 3:05 PM Changeset in webkit [237657] by
-
- 3 edits2 adds in trunk
[MSE] Use tolerance when growing the coded frame group
https://bugs.webkit.org/show_bug.cgi?id=190085
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-append-acb-tolerance.html
This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.
This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).
This fixes a stall when seeking back and forth in YouTube with WebM
video.
A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
LayoutTests:
A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.
- media/media-source/media-source-append-acb-tolerance.html: Added.
- 3:00 PM Changeset in webkit [237656] by
-
- 11 edits in trunk
Web Inspector: Audit: attempt to re-link DOM nodes for imported results
https://bugs.webkit.org/show_bug.cgi?id=191044
<rdar://problem/45687364>
Reviewed by Brian Burg.
Source/WebInspectorUI:
When importing a
WI.AuditTestCaseResult, attempt toquerySelectorfor each item in
data.domNodes. If a node is found, replace it with that node and show a tree instead.
- UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.async fromPayload): Added.
(WI.AuditTestCase.fromPayload): Deleted.
- UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup.async fromPayload): Added.
(WI.AuditTestGroup.fromPayload): Deleted.
- UserInterface/Models/AuditTestCaseResult.js:
(WI.AuditTestCaseResult.async fromPayload): Added.
(WI.AuditTestCaseResult.fromPayload): Deleted.
- UserInterface/Models/AuditTestGroupResult.js:
(WI.AuditTestGroupResult.async fromPayload): Added.
(WI.AuditTestGroupResult.fromPayload): Deleted.
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.import):
LayoutTests:
- inspector/model/auditTestCase.html:
- inspector/model/auditTestCaseResult.html:
- inspector/model/auditTestGroup.html:
- inspector/model/auditTestGroupResult.html:
- 2:52 PM Changeset in webkit [237655] by
-
- 3 edits2 adds in trunk
MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
https://bugs.webkit.org/show_bug.cgi?id=191129
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-istypesupported-case-sensitive.html
According to RFC 2045: "All media type values, subtype values, and parameter names as
defined are case-insensitive. However, parameter values are case-sensitive unless otherwise
specified for the specific parameter." So rather than fold the entire ContentType into lower-
case, leave the original string intact and require clients to enforce case-insensitivity.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported):
LayoutTests:
- media/media-source/media-source-istypesupported-case-sensitive-expected.txt: Added.
- media/media-source/media-source-istypesupported-case-sensitive.html: Added.
- 2:51 PM Changeset in webkit [237654] by
-
- 2 edits in trunk/Source/WebCore
Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
access of m_cdmInstance.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):
- 2:48 PM Changeset in webkit [237653] by
-
- 2 edits in trunk/Source/WebInspectorUI
Follow-up review comment to r237652.
Reviewed by Brian Burg.
- UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager):
- 2:19 PM Changeset in webkit [237652] by
-
- 24 edits in trunk/Source/WebInspectorUI
Web Inspector: Separate target initialization from frontend initialization
https://bugs.webkit.org/show_bug.cgi?id=191052
<rdar://problem/45658384>
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
Create the targets after the rest of frontend initialization. This is a step
toward a frontend opening and being told about multiple targets instead of
knowing in advance a single target it is connected to. All backend
messages during frontend initialization now happen with an explicit target.
- UserInterface/Controllers/ApplicationCacheManager.js:
(WI.ApplicationCacheManager):
(WI.ApplicationCacheManager.prototype.initializeTarget):
(WI.ApplicationCacheManager.prototype.initialize):
- UserInterface/Controllers/CSSManager.js:
(WI.CSSManager):
(WI.CSSManager.prototype.initializeTarget):
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager):
(WI.CanvasManager.prototype.initializeTarget):
- UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager):
(WI.ConsoleManager.prototype.initializeLogChannels):
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager):
(WI.DOMManager.prototype.initializeTarget):
- UserInterface/Controllers/DOMStorageManager.js:
(WI.DOMStorageManager):
(WI.DOMStorageManager.prototype.initializeTarget):
- UserInterface/Controllers/DatabaseManager.js:
(WI.DatabaseManager):
(WI.DatabaseManager.prototype.initializeTarget):
- UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager):
(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.restoreBreakpointsSoon): Deleted.
- UserInterface/Controllers/HeapManager.js:
(WI.HeapManager.prototype.initializeTarget):
- UserInterface/Controllers/IndexedDBManager.js:
(WI.IndexedDBManager):
(WI.IndexedDBManager.prototype.initializeTarget):
- UserInterface/Controllers/LayerTreeManager.js:
(WI.LayerTreeManager.prototype.initializeTarget):
- UserInterface/Controllers/MemoryManager.js:
(WI.MemoryManager.prototype.initializeTarget):
- UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager):
(WI.NetworkManager.prototype.initializeTarget):
- UserInterface/Controllers/RuntimeManager.js:
(WI.RuntimeManager):
(WI.RuntimeManager.prototype.initializeTarget):
- UserInterface/Controllers/TargetManager.js:
(WI.TargetManager):
(WI.TargetManager.prototype.initializeTargetsWithMainTarget):
- UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager):
(WI.TimelineManager.prototype.initializeTarget):
(WI.TimelineManager.prototype.set enabledTimelineTypes):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
- UserInterface/Controllers/WorkerManager.js:
(WI.WorkerManager):
(WI.WorkerManager.prototype.initializeTarget):
Move Target initialization out of the constructor into a top level
initializeTargetfunction. This will be expected to be called
by any target that the frontend connects to.
(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Drive-by fix. Update all targets if the setting changes.
(WI.WorkerManager.prototype.workerCreated):
Call initialize on the new target.
- UserInterface/Models/CSSCompletions.js:
(WI.CSSCompletions.initializeCSSCompletions):
(WI.CSSCompletions.requestCSSCompletions): Deleted.
Rename requestCSSCompletions to initializeCSSCompletions to try
and standardize on "initialize" being used for most frontend one
time initialization tasks. This being one such operation that
only needs to be performed once on a target that supports it.
- UserInterface/Protocol/Target.js:
(WI.Target):
(WI.Target.prototype.initialize):
Perform explicit target initialization, such as initializing
the state of all backend domains / agents. This is done by asking
each of the managers to do initialization work for this target.
(WI.Target.prototype.get ApplicationCacheAgent):
(WI.Target.prototype.get CSSAgent):
(WI.Target.prototype.get CanvasAgent):
(WI.Target.prototype.get ConsoleAgent):
(WI.Target.prototype.get DOMAgent):
(WI.Target.prototype.get DOMDebuggerAgent):
(WI.Target.prototype.get DOMStorageAgent):
(WI.Target.prototype.get DatabaseAgent):
(WI.Target.prototype.get DebuggerAgent):
(WI.Target.prototype.get HeapAgent):
(WI.Target.prototype.get IndexedDBAgent):
(WI.Target.prototype.get InspectorAgent):
(WI.Target.prototype.get LayerTreeAgent):
(WI.Target.prototype.get MemoryAgent):
(WI.Target.prototype.get NetworkAgent):
(WI.Target.prototype.get PageAgent):
(WI.Target.prototype.get RecordingAgent):
(WI.Target.prototype.get RuntimeAgent):
(WI.Target.prototype.get ScriptProfilerAgent):
(WI.Target.prototype.get ServiceWorkerAgent):
(WI.Target.prototype.get TargetAgent):
(WI.Target.prototype.get TimelineAgent):
(WI.Target.prototype.get WorkerAgent):
Accessors for all of the agents on a Target.
- UserInterface/Protocol/WorkerTarget.js:
(WI.WorkerTarget):
This is now automatically done in the base class.
- UserInterface/Test/Test.js:
(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
New necessary top level hooks, and initialize more like Main.js.
- 2:04 PM Changeset in webkit [237651] by
-
- 45 edits in trunk/LayoutTests
[MSE] WebKit tests: Use fixed point in makeASample()
https://bugs.webkit.org/show_bug.cgi?id=191128
Reviewed by Jer Noble.
This patch modifies the utility function makeASample() so as to accept
time values in arbitrary time scales.
Previously makeASample() accepted optionally a time scale, but still
required to receive all time values as seconds, therefore requiring a
division at call time in order to use the function, which could cause
rounding errors (see https://bugs.webkit.org/show_bug.cgi?id=190085#c20).
- media/media-source/media-source-append-acb-no-frame-lost-expected.txt:
- media/media-source/media-source-append-acb-no-frame-lost.html:
- media/media-source/media-source-append-buffer-with-append-window.html:
- media/media-source/media-source-append-media-segment-without-init.html:
- media/media-source/media-source-append-nonsync-sample-after-abort.html:
- media/media-source/media-source-append-out-of-order.html:
- media/media-source/media-source-append-overlapping-dts-expected.txt:
- media/media-source/media-source-append-overlapping-dts.html:
- media/media-source/media-source-canplaythrough.html:
- media/media-source/media-source-duplicate-seeked.html:
- media/media-source/media-source-duration-after-append.html:
- media/media-source/media-source-end-of-stream-buffered.html:
- media/media-source/media-source-end-of-stream-readyState.html:
- media/media-source/media-source-fastseek.html:
- media/media-source/media-source-fudge-factor.html:
- media/media-source/media-source-monitor-source-buffers.html:
- media/media-source/media-source-overlapping-append-buffered.html:
- media/media-source/media-source-overlapping-append-expected.txt:
- media/media-source/media-source-overlapping-append.html:
- media/media-source/media-source-overlapping-decodetime-expected.txt:
- media/media-source/media-source-overlapping-decodetime.html:
- media/media-source/media-source-play.html:
- media/media-source/media-source-range-end-frame-not-removed-expected.txt:
- media/media-source/media-source-range-end-frame-not-removed.html:
- media/media-source/media-source-range-start-frame-replaced-expected.txt:
- media/media-source/media-source-range-start-frame-replaced.html:
- media/media-source/media-source-remove-decodeorder-crash.html:
- media/media-source/media-source-remove-too-much.html:
- media/media-source/media-source-remove.html:
- media/media-source/media-source-restrictions.html:
- media/media-source/media-source-sample-wrong-track-id.html:
- media/media-source/media-source-seek-back-expected.txt:
- media/media-source/media-source-seek-back.html:
- media/media-source/media-source-seek-complete.html:
- media/media-source/media-source-sequence-timestamps-expected.txt:
- media/media-source/media-source-sequence-timestamps.html:
- media/media-source/media-source-small-gap.html:
- media/media-source/media-source-timeoffset-expected.txt:
- media/media-source/media-source-timeoffset.html:
- media/media-source/media-source-timestampoffset-rounding-error.html:
- media/media-source/media-source-timestampoffset-then-zero-expected.txt:
- media/media-source/media-source-timestampoffset-then-zero.html:
- media/media-source/media-source-video-playback-quality.html:
- media/media-source/mock-media-source.js:
(makeASample):
- 1:26 PM Changeset in webkit [237650] by
-
- 5 edits in trunk
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>
Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.
Source/WebCore:
Add a include to fix the unified build error.
No tests since no new functionality.
- Modules/webgpu/WebGPUDevice.cpp:
LayoutTests:
Increase the timer of recording to 2 seconds until we support timeslice in order to reduce flakiness.
- http/wpt/mediarecorder/MediaRecorder-dataavailable.html:
- http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
- 1:23 PM Changeset in webkit [237649] by
-
- 14 edits in trunk/Source/WebCore
[EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE
https://bugs.webkit.org/show_bug.cgi?id=190946
Reviewed by Eric Carlson.
Use separate AVContentKeySessions per CDMInstanceSession (rather than one AVContentKeySession per
CDMInstance).
- Add a mechanism for sending a message out from platform/CDMInstance to MediaKeySession without requiring MediaKeySession to send a callback first.
- Move all the AVContentKeySession delegate methods from CDMInstanceFairPlayStreamingAVFObjC to CDMInstanceSessionFairPlayStreamingAVFObjC.
- Add a mechanism for requesting the correct CDMInstanceSession for a given KeyID.
- Support key renewal through a "renew" message.
- Remember the keyID in SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID() and ask for the correct CDMInstanceSession for that keyID in attemptToDecrypt().
- Pass the CDMInstance down from MediaPlayerPrivateMediaSourceAVFObjC -> SourceBufferPrivateAVFObjC.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::sendMessage):
- Modules/encryptedmedia/MediaKeySession.h:
- platform/encryptedmedia/CDMInstanceSession.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(-[WebCoreFPSContentKeySessionDelegate initWithParent:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::createSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::~CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::keyIDsForRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyIDs):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::nextRequest):
(WebCore::requestStatusToCDMStatus):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitingForKey const):
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceAttached):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceDetached):
(WebCore::MediaSourcePrivateAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaSourcePrivateAVFObjC::waitingForKey const):
(WebCore::MediaSourcePrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
(WebCore::SourceBufferPrivateAVFObjC::attemptToDecrypt):
(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
- 1:16 PM Changeset in webkit [237648] by
-
- 2 edits in trunk/Source/WebKit
API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>
Reviewed by Dean Jackson.
On macOS 10.12, we don't attempt secure archival at all because SECURE_ARCHIVER_API is turned off, and on macOS
10.14, NSFileWrapper supports secure coding. However, on macOS 10.13, SECURE_ARCHIVER_API is on despite
NSFileWrapper not being securely codable, so we're unable to serialize attachment data.
To fix this, we only use the secure archiver on ≥ macOS 10.14 and ≥ iOS 12.
- UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::createSerializedRepresentation const):
- 1:08 PM Changeset in webkit [237647] by
-
- 18 edits6 adds in trunk
Add credit card autofill button
https://bugs.webkit.org/show_bug.cgi?id=191051
<rdar://problem/45657011>
Patch by Zach Li <zacharyli323@gmail.com> on 2018-10-31
Reviewed by Wenson Hsieh.
Source/WebCore:
Test: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- css/html.css:
(input::-webkit-credit-card-auto-fill-button):
Add credit card autofill button.
(input::-webkit-credit-card-auto-fill-button:hover):
(input::-webkit-credit-card-auto-fill-button:active):
- html/HTMLTextFormControlElement.h:
- html/TextFieldInputType.cpp:
(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
- platform/LocalizedStrings.cpp:
(WebCore::AXAutoFillCreditCardLabel):
- platform/LocalizedStrings.h:
- testing/Internals.cpp:
(WebCore::toAutoFillButtonType):
(WebCore::toInternalsAutoFillButtonType):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(toAutoFillButtonType):
(toWKAutoFillButtonType):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
Introduce a new button type for credit card autofill.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(toAutoFillButtonType):
(toWKAutoFillButtonType):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
LayoutTests:
- fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
- fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html: Added.
- fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
- fast/forms/auto-fill-button/last-auto-fill-button-type.html:
- platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
- platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png: Added.
- platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
- 1:05 PM Changeset in webkit [237646] by
-
- 8 edits6 adds in trunk/LayoutTests/imported/w3c
Resync XHR Web Platform Tests from upstream 44dd29fb0d
https://bugs.webkit.org/show_bug.cgi?id=191116
Reviewed by Youenn Fablet.
- web-platform-tests/xhr/getallresponseheaders-expected.txt:
- web-platform-tests/xhr/getallresponseheaders.htm:
- web-platform-tests/xhr/getresponseheader.any-expected.txt:
- web-platform-tests/xhr/getresponseheader.any.js:
(forEach.testValues.async_test.t.client.onload.t.step_func_done):
(async_test.t.client.onload.t.step_func_done): Deleted.
- web-platform-tests/xhr/getresponseheader.any.worker-expected.txt:
- web-platform-tests/xhr/resources/header-content-length-twice.asis: Added.
- web-platform-tests/xhr/resources/headers-double-empty.asis: Added.
- web-platform-tests/xhr/resources/headers-some-are-empty.asis: Added.
- web-platform-tests/xhr/resources/w3c-import.log:
- web-platform-tests/xhr/setrequestheader-combining.window-expected.txt: Added.
- web-platform-tests/xhr/setrequestheader-combining.window.html: Added.
- web-platform-tests/xhr/setrequestheader-combining.window.js: Added.
(test):
- web-platform-tests/xhr/w3c-import.log:
- 11:44 AM Changeset in webkit [237645] by
-
- 2 edits in trunk/Source/JavaScriptCore
Adjust inlining threshold for new bytecode format
https://bugs.webkit.org/show_bug.cgi?id=191115
Reviewed by Saam Barati.
The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.
- runtime/Options.h:
- 11:25 AM Changeset in webkit [237644] by
-
- 15 edits in trunk
Web Inspector: Audit: show metadata for results
https://bugs.webkit.org/show_bug.cgi?id=190853
<rdar://problem/45527623>
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.prototype.async run):
Capture timestamps around theRunetimeAgent.evaluatecall, as well as the URL of the page.
- UserInterface/Models/AuditTestCaseResult.js:
(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get metadata): Added.
(WI.AuditTestCaseResult.prototype.toJSON):
- UserInterface/Views/AuditTestCaseContentView.js:
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
- UserInterface/Views/AuditTestCaseContentView.css:
(.content-view.audit-test-case > header h1): Added.
(.content-view.audit-test-case > header h1 > img): Added.
(.content-view.audit-test-case > header > .metadata): Added.
(.content-view.audit-test-case > header > .metadata > .source > time): Added.
(.content-view.audit-test-case > header > .metadata > .source > a): Added.
(.content-view.audit-test-case > header > .metadata > .duration): Added.
(.content-view.audit-test-case > header > h1): Deleted.
(.content-view.audit-test-case > header > h1 > img): Deleted.
Display any metadata information where theWI.ScopeBaris forWI.AuditTestGroupContentViews.
- UserInterface/Views/AuditTestContentView.css:
(.content-view.audit-test > header):
(.content-view.audit-test > header > .information): Added.
- UserInterface/Views/AuditTestGroupContentView.css:
(.content-view.audit-test-group > header):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .information): Deleted.
Move common CSS rules to common parent class.
- UserInterface/Base/Utilities.js:
LayoutTests:
- inspector/model/auditTestCaseResult-expected.txt:
- inspector/model/auditTestCaseResult.html:
- inspector/model/auditTestGroupResult-expected.txt:
- inspector/model/auditTestGroupResult.html:
- inspector/unit-tests/string-utilities-expected.txt:
- inspector/unit-tests/string-utilities.html:
- 10:26 AM Changeset in webkit [237643] by
-
- 7 edits in trunk
[MediaStream] Don't reveal device IDs until the user has granted permission to capture
https://bugs.webkit.org/show_bug.cgi?id=191112
<rdar://problem/45699932>
Reviewed by Youenn Fablet.
Source/WebCore:
No new tests, existing tests updated.
- Modules/mediastream/MediaDevicesRequest.cpp:
(WebCore::MediaDevicesRequest::start): Don't reveal device ID or group ID until the user
has granted permssion to capture.
LayoutTests:
- TestExpectations: Skip http/tests/media/media-stream/enumerate-devices-source-id-persistent.html
and http/tests/media/media-stream/enumerate-devices-source-id.html for now, they don't make sense
with these changes and will be updated to pass in a future patch.
- fast/mediastream/MediaStreamTrack-getCapabilities.html:
- fast/mediastream/get-user-media-device-id-expected.txt:
- fast/mediastream/get-user-media-device-id.html:
- 10:19 AM Changeset in webkit [237642] by
-
- 17 edits4 copies10 adds in trunk
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- web-platform-tests/mediacapture-record/BlobEvent-constructor-expected.txt:
- web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution-expected.txt: Added.
- web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html: Added.
- web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
- web-platform-tests/mediacapture-record/MediaRecorder-stop.html:
- web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html: Added.
Source/WebCore:
Implement JavaScript dispatch event dataavailable and JavaScript exposed method stop().
Implement a mock string as the output buffer of MediaRecorder.
Remove the declaration of timecode in BlobEvent since it has not been implemented in MediaRecorder and MediaRecorderPrivate.
Tests: http/wpt/mediarecorder/MediaRecorder-dataavailable.html
http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html
imported/w3c/web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html
- CMakeLists.txt:
- Modules/mediarecorder/BlobEvent.cpp: Added.
(WebCore::BlobEvent::create):
(WebCore::BlobEvent::BlobEvent):
(WebCore::BlobEvent::eventInterface const):
- Modules/mediarecorder/BlobEvent.h:
- Modules/mediarecorder/BlobEvent.idl:
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::stop):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::stopRecordingInternal):
(WebCore::MediaRecorder::didAddOrRemoveTrack):
(WebCore::MediaRecorder::trackEnded):
(WebCore::MediaRecorder::sampleBufferUpdated):
(WebCore::MediaRecorder::audioSamplesAvailable):
(WebCore::MediaRecorder::scheduleDeferredTask):
- Modules/mediarecorder/MediaRecorder.h:
- Modules/mediarecorder/MediaRecorder.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventNames.in:
- platform/mediarecorder/MediaRecorderPrivate.h: Added.
- platform/mediarecorder/MediaRecorderPrivateMock.cpp: Added.
(WebCore::MediaRecorderPrivateMock::sampleBufferUpdated):
(WebCore::MediaRecorderPrivateMock::audioSamplesAvailable):
(WebCore::MediaRecorderPrivateMock::generateMockString):
(WebCore::MediaRecorderPrivateMock::fetchData):
- platform/mediarecorder/MediaRecorderPrivateMock.h: Added.
LayoutTests:
These tests are used to check if MediaRecorder can generate both video and audio buffers through mock source.
- http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-dataavailable.html: Added.
- http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html: Added.
- platform/win/TestExpectations:
- 9:39 AM Changeset in webkit [237641] by
-
- 3 edits1 add in trunk
REGRESSION(r237547): Exception handlers should be aware of wide opcodes
https://bugs.webkit.org/show_bug.cgi?id=191108
<rdar://problem/45690700>
Reviewed by Saam Barati.
JSTests:
- stress/wide-op_catch.js: Added.
(catch):
Source/JavaScriptCore:
When linking the handler, we need to check whether the target op_catch is
wide or narrow in order to chose the right code pointer for the handler.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
- 9:33 AM Changeset in webkit [237640] by
-
- 2 edits in trunk/Tools
Don't run JIT tests on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=191074
Reviewed by Michael Catanzaro.
- Scripts/run-jsc-stress-tests:
- 9:23 AM Changeset in webkit [237639] by
-
- 8 edits2 adds in trunk
[PSON] When process-swapping for a POST request the HTTP body gets dropped
https://bugs.webkit.org/show_bug.cgi?id=191046
<rdar://problem/45229732>
Reviewed by Alex Christensen.
Source/WebKit:
For performance reasons, the ResourceRequest IPC encoder does not encode the request's HTTP body (aka form data).
When we decide to process-swap for a POST request in WebPageProxy::decidePolicyForNavigationAction(), the request
we pass the new WebProcess thus no longer has a HTTP body and the load will likely fail in the new process.
To address the issue, we now pass the request body along with the request when sending the DecidePolicyForNavigationActionAsync
/ DecidePolicyForNavigationActionSync IPC from the WebProcess to the UIProcess. No action is needed for the
LoadRequest IPC to the new WebProcess since the LoadParameters' IPC encoder takes care of encoding the request's
body already.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
LayoutTests:
Add layout test coverage.
- http/tests/misc/form-post-textplain-cross-site-expected.txt: Added.
- http/tests/misc/form-post-textplain-cross-site.html: Added.
- 9:09 AM Changeset in webkit [237638] by
-
- 6 edits in trunk/Source/JavaScriptCore
Align entries in metadata table
https://bugs.webkit.org/show_bug.cgi?id=191062
Reviewed by Filip Pizlo.
Entries in the metadata table need to be aligned on some 32-bit
architectures.
- bytecode/MetadataTable.h:
(JSC::MetadataTable::forEach):
- bytecode/Opcode.cpp:
(JSC::metadataAlignment):
- bytecode/Opcode.h:
- bytecode/UnlinkedMetadataTableInlines.h:
(JSC::UnlinkedMetadataTable::finalize):
- generator/Section.rb:
- 8:19 AM Changeset in webkit [237637] by
-
- 2 edits in trunk/Source/WebCore
[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
https://bugs.webkit.org/show_bug.cgi?id=191110
Reviewed by Michael Catanzaro.
Covered by existing tests.
Turns out that this method is expected to reject domains that
are not registrable. Also sync with the Mac implementation in
that given domains that are not all ASCII should be returned
back as is. This fixes the remaining Public Suffix API tests.
- platform/soup/PublicSuffixSoup.cpp:
(WebCore::topPrivatelyControlledDomain):
- 8:08 AM Changeset in webkit [237636] by
-
- 11 edits4 deletes in trunk/Source
Remove LayerFlushScheduler
https://bugs.webkit.org/show_bug.cgi?id=191103
Reviewed by Anders Carlsson.
Source/WebCore:
It is only used in WK1.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/ca/LayerFlushScheduler.cpp: Removed.
- platform/graphics/ca/LayerFlushScheduler.h: Removed.
- platform/graphics/ca/LayerFlushSchedulerClient.h: Removed.
- platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Removed.
Source/WebKitLegacy/mac:
Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
all the virtual cruft.
- WebView/WebViewData.h:
(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
(): Deleted.
- WebView/WebViewData.mm:
(currentRunLoop):
(WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::schedule):
(WebViewLayerFlushScheduler::invalidate):
(WebViewLayerFlushScheduler::layerFlushCallback):
- 7:21 AM Changeset in webkit [237635] by
-
- 2 edits in trunk/Source/WebCore
Missing from r237634
- layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::formattingContext):
- 6:51 AM Changeset in webkit [237634] by
-
- 9 edits in trunk/Source/WebCore
[LFC] Do not pass LayoutState& to compute* and layout* functions
https://bugs.webkit.org/show_bug.cgi?id=191100
Reviewed by Antti Koivisto.
Reduce noise by removing LayoutState& parameter where possible.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
- layout/LayoutFormattingState.cpp:
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeFloatPosition const):
(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
- layout/inlineformatting/InlineFormattingContext.h:
- 6:50 AM Changeset in webkit [237633] by
-
- 14 edits in trunk/Source/WebCore
[LFC] FormattingContext class should take FormattingState&
https://bugs.webkit.org/show_bug.cgi?id=191099
Reviewed by Antti Koivisto.
This is in preparation for not passing LayoutState& into every layout functions.
FormattingContext has FormattingState now and LayoutState can be acquired through FormattingState.
LayoutState <- FormattingState <- FormattingContext
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::formattingState const):
(WebCore::Layout::FormattingContext::layoutState const):
- layout/FormattingContext.h:
- layout/FormattingState.cpp:
(WebCore::Layout::FormattingState::FormattingState):
- layout/FormattingState.h:
(WebCore::Layout::FormattingState::layoutState const):
- layout/LayoutFormattingState.h:
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::BlockFormattingContext):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingState.cpp:
(WebCore::Layout::BlockFormattingState::BlockFormattingState):
(WebCore::Layout::BlockFormattingState::formattingContext):
(WebCore::Layout::BlockFormattingState::formattingContext const): Deleted.
- layout/blockformatting/BlockFormattingState.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::InlineFormattingState):
(WebCore::Layout::InlineFormattingState::formattingContext):
(WebCore::Layout::InlineFormattingState::formattingContext const): Deleted.
- layout/inlineformatting/InlineFormattingState.h:
- 6:43 AM Changeset in webkit [237632] by
-
- 11 edits in trunk/Source/WebCore
[LFC] The *FormattingState class should provide the *FormattingContext.
https://bugs.webkit.org/show_bug.cgi?id=191089
Reviewed by Antti Koivisto.
BlockFormattingState provides the BlockFormattingContext object, while InlineFormattingState provides the InlineFormattingContext.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
- layout/FormattingState.h:
- layout/LayoutFormattingState.cpp:
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::formattingContext const): Deleted.
- layout/LayoutFormattingState.h:
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):
- layout/blockformatting/BlockFormattingState.cpp:
(WebCore::Layout::BlockFormattingState::formattingContext const):
- layout/blockformatting/BlockFormattingState.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
- layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::formattingContext const):
- layout/inlineformatting/InlineFormattingState.h:
- 6:37 AM Changeset in webkit [237631] by
-
- 38 edits2 moves in trunk/Source/WebCore
[LFC] Rename LayoutContext to LayoutState
https://bugs.webkit.org/show_bug.cgi?id=191080
Reviewed by Antti Koivisto.
LayoutContext naming was a bit misleading since none of the other *FormattingContext classes (BlockFormattingContext etc) hold states.
(LayoutContext.cpp -> LayoutFormattingState.cpp because LayoutState.cpp name is already taken.)
Now the current state is as follows:
LayoutState has
- Layout tree
- State content for each formatting subtrees
- Display tree
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::mapBoxToAncestor):
(WebCore::Layout::FormattingContext::mapTopLeftToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
- layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
- layout/FormattingState.cpp:
(WebCore::Layout::FormattingState::FormattingState):
- layout/FormattingState.h:
(WebCore::Layout::FormattingState::setInstrinsicWidthConstraints):
(WebCore::Layout::FormattingState::instrinsicWidthConstraints const):
- layout/LayoutFormattingState.cpp: Renamed from Source/WebCore/layout/LayoutContext.cpp.
(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot):
(WebCore::Layout::LayoutState::updateLayout):
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):
(WebCore::Layout::LayoutState::styleChanged):
(WebCore::Layout::LayoutState::markNeedsUpdate):
(WebCore::Layout::LayoutState::formattingStateForBox const):
(WebCore::Layout::LayoutState::establishedFormattingState const):
(WebCore::Layout::LayoutState::createFormattingStateForFormattingRootIfNeeded):
(WebCore::Layout::LayoutState::formattingContext const):
- layout/LayoutFormattingState.h: Renamed from Source/WebCore/layout/LayoutContext.h.
(WebCore::Layout::LayoutState::setInQuirksMode):
(WebCore::Layout::LayoutState::hasDisplayBox const):
(WebCore::Layout::LayoutState::inQuirksMode const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const): Deleted.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::hasPrecomputedMarginTop):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):
- layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::isStretchedToInitialContainingBlock):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginTop):
- layout/blockformatting/BlockFormattingState.cpp:
(WebCore::Layout::BlockFormattingState::BlockFormattingState):
- layout/blockformatting/BlockFormattingState.h:
- layout/blockformatting/BlockInvalidation.cpp:
(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):
- layout/blockformatting/BlockInvalidation.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBottom):
- layout/displaytree/DisplayBox.h:
- layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::FloatAvoider):
- layout/floats/FloatAvoider.h:
- layout/floats/FloatBox.cpp:
(WebCore::Layout::FloatBox::FloatBox):
- layout/floats/FloatBox.h:
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFloatAvoiding const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
- layout/floats/FloatingContext.h:
(WebCore::Layout::FloatingContext::layoutState const):
(WebCore::Layout::FloatingContext::layoutContext const): Deleted.
- layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::FloatingState):
(WebCore::Layout::FloatingState::constraints const):
- layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::create):
(WebCore::Layout::FloatingState::layoutState const):
(WebCore::Layout::FloatingState::layoutContext const): Deleted.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeFloatPosition const):
(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):
- layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::InlineFormattingState):
- layout/inlineformatting/InlineFormattingState.h:
- layout/inlineformatting/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::invalidate):
- layout/inlineformatting/InlineInvalidation.h:
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::InlineLineBreaker::InlineLineBreaker):
(WebCore::Layout::InlineLineBreaker::runWidth const):
- layout/inlineformatting/InlineLineBreaker.h:
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):
- layout/layouttree/LayoutTreeBuilder.h:
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
- 3:10 AM Changeset in webkit [237630] by
-
- 2 edits in trunk/Source/JavaScriptCore
Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=191063
Patch by Jim Mason <jmason@ibinx.com> on 2018-10-31
Reviewed by Yusuke Suzuki.
- wasm/WasmFaultSignalHandler.cpp:
- 2:56 AM Changeset in webkit [237629] by
-
- 3 edits in trunk/Source/WebKit
Stop using LayerFlushScheduler in WK2
https://bugs.webkit.org/show_bug.cgi?id=191065
Reviewed by Tim Horton.
Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver
directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback):
(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver):
- 12:29 AM Changeset in webkit [237628] by
-
- 4 edits in trunk/Source/WebKit
[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
https://bugs.webkit.org/show_bug.cgi?id=190956
Reviewed by Youenn Fablet.
Similarly to what was done for the IPC coders, serialize
the entire certificate chain in the cache coder. Bump
the cache version due to the caching format changes.
- NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr<GByteArray> coders.
- NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
(WTF::Persistence::certificatesDataListFromCertificateInfo):
(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::encode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::decode):
- NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.
Oct 30, 2018:
- 11:14 PM Changeset in webkit [237627] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC][LLInt] Compact LLInt ASM code by removing unnecessary instructions
https://bugs.webkit.org/show_bug.cgi?id=191092
Reviewed by Saam Barati.
Looking through LLIntAssembly.h, we can find several inefficiencies. This patch fixes the
following things to tighten LLInt ASM code.
- Remove unnecessary load instructions. Use jmp with BaseIndex directly.
- Introduce strength reduction for mul instructions in offlineasm layer. This is now critical
since mul instruction is executed in
metadataoperation in LLInt. If the given immediate is
a power of two, we convert it to lshift instruction.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm64.rb:
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 10:45 PM Changeset in webkit [237626] by
-
- 7 edits in tags/Safari-607.1.10.7/Source
Versioning.
- 10:41 PM Changeset in webkit [237625] by
-
- 1 copy in tags/Safari-607.1.10.7
New tag.
- 10:29 PM Changeset in webkit [237624] by
-
- 25 edits1 copy in trunk
[Cocoa] Attachment dropped from one web view to another is missing its file wrapper
https://bugs.webkit.org/show_bug.cgi?id=190530
<rdar://problem/45232149>
Reviewed by Tim Horton.
Source/WebCore:
Add support for copying and pasting attachment elements across web views by encoding and adding file wrapper
data as subresources in the web archive when writing selected web content to the pasteboard, and then decoding
and creating NSFileWrappers upon reading web content.
Test: WKAttachmentTests.CopyAndPasteBetweenWebViews
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::Editor::registerAttachments):
- editing/Editor.h:
Add registerAttachments(), which registers _WKAttachments in the UI process given a list of
SerializedAttachmentData. This behaves similarly to registerAttachmentIdentifiers(), but differs in that (1) it
sends serialized file wrapper data, and (2) it sends a list of serialized attachments, rather than information
about just a single attachment.
- editing/SerializedAttachmentData.h:
Introduce SerializedAttachmentData, a struct containing information needed to serialize and deserialize an
attachment. These are used both when writing attachment data to the pasteboard, and when consuming attachment
data upon paste.
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::replaceRichContentWithAttachments):
Add a step when pasting rich content with attachments, to collect and send serialized attachments to the client.
Also, drive-by fix: don't WTFMove() the Ref here if it's still going to be used below.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::archiveResourceURL):
- html/HTMLAttachmentElement.h:
Add a static helper function to compute a URL that represents the data for the given attachment identifier, for
use in a web archive resource.
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::addSubresourcesForAttachmentElementsIfNecessary):
Add a helper function to create and append ArchiveResources representing attachment element data when writing
attachments to the pasteboard via web archive data.
(WebCore::LegacyWebArchive::create):
- page/EditorClient.h:
(WebCore::EditorClient::registerAttachments):
(WebCore::EditorClient::serializedAttachmentDataForIdentifiers):
Source/WebKit:
See WebCore ChangeLog for more details.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<SerializedAttachmentData>::encode):
(IPC::ArgumentCoder<SerializedAttachmentData>::decode):
- Shared/WebCoreArgumentCoders.h:
Add IPC encoding/decoding support for SerializedAttachmentData.
- UIProcess/API/APIAttachment.cpp:
(API::Attachment::createSerializedRepresentation const):
(API::Attachment::updateFromSerializedRepresentation):
- UIProcess/API/APIAttachment.h:
- UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::createSerializedRepresentation const):
Add a method to serialize and return attachment info as a blob of data.
(API::Attachment::updateFromSerializedRepresentation):
Add a method to update the attachment, given a serialized blob of data. On Cocoa platforms, this fails
gracefully if the serialized data cannot be decoded.
- UIProcess/Cocoa/PageClientImplCocoa.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::allocFileWrapperInstance const):
(WebKit::PageClientImplCocoa::serializableFileWrapperClasses const):
(WebKit::PageClientImplCocoa::allocFileWrapperInstance): Deleted.
Add an additional hook to return the list of NSFileWrapper subclasses suitable for deserialization. This
array contains (at minimum) NSFileWrapper, but may additionally include a custom NSFileWrapper subclass, if
configured.
- UIProcess/PageClient.h:
(WebKit::PageClient::allocFileWrapperInstance const):
(WebKit::PageClient::serializableFileWrapperClasses const):
(WebKit::PageClient::allocFileWrapperInstance): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerAttachmentsFromSerializedData):
Registers the given serialized attachment data, creating new _WKAttachment instances if necessary. Currently,
this does not update the file wrappers of existing _WKAttachments; we should revisit this in the future to see
if we can additionally update file wrappers for existing attachments, without breaking the case where the user
copies and pastes or drags and drops attachments within a single web view and the client expects _WKAttachment
instances to be reused.
(WebKit::WebPageProxy::serializedAttachmentDataForIdentifiers):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerAttachments):
(WebKit::WebEditorClient::serializedAttachmentDataForIdentifiers):
Implement a new IPC hook to fetch an array of serialized attachment data blobs, given a list of attachment
identifiers.
- WebProcess/WebCoreSupport/WebEditorClient.h:
Tools:
Add a test to verify that copying different types of attachments and pasting in a new web view inserts
attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
is equivalent to the original file wrappers used to insert attachments in the first web view.
Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
is still backed by the same NSFileWrapper instance.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
- 10:05 PM Changeset in webkit [237623] by
-
- 2 edits in trunk/Tools
[Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=190949
Reviewed by Alex Christensen.
Visual Studio 2017 Community is the alternative.
- Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
(setupCygwinEnv): Remove obsolete code for Visual Studio Express.
(buildVisualStudioProject): Ditto.
(dieIfWindowsPlatformSDKNotInstalled): Deleted.
(usingVisualStudioExpress): Deleted.
- 9:48 PM Changeset in webkit [237622] by
-
- 2 edits in trunk/Tools
[Win][Direct2D] Support building DumpRenderTree for Direct2D
https://bugs.webkit.org/show_bug.cgi?id=191093
<rdar://problem/45685706>
Unreviewed build fix.
error C2065: 'renderTarget': undeclared identifier
- DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Restored the previous implementation.
- 9:00 PM Changeset in webkit [237621] by
-
- 9 edits5 adds in trunk
[PlayStation] Enable JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=191072
Reviewed by Brent Fulgham.
.:
Add support for building the PlayStation port through JavaScriptCore.
- CMakeLists.txt:
- Source/cmake/OptionsPlayStation.cmake: Added.
Source/JavaScriptCore:
Add platform files for the PlayStation port.
- PlatformPlayStation.cmake: Added.
Source/ThirdParty:
Add platform files for the PlayStation port.
- gtest/PlatformPlayStation.cmake: Added.
Source/WTF:
Add platform files for the PlayStation port.
- wtf/PlatformPlayStation.cmake: Added.
Tools:
Add platform scripts for building the PlayStation port.
perl Tools/Scripts/build-webkit --playstation
- Scripts/build-webkit:
- Scripts/build-webkittestrunner:
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(determineConfigurationProductDir):
(isPlayStation): Added.
(getMSBuildPlatformArgument): Added.
(buildVisualStudioProject):
(wrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
- TestWebKitAPI/PlatformPlayStation.cmake: Added.
- 8:36 PM Changeset in webkit [237620] by
-
- 7 edits2 adds in trunk
XSLTProcessor should limit max transform depth
<https://webkit.org/b/191075>
<rdar://problem/45531453>
Reviewed by Alex Christensen.
Source/WebCore:
Test: fast/xsl/xslt-max-depth.html
- xml/SoftLinkLibxslt.cpp: Add macro for
xsltMaxDepthglobal. - xml/SoftLinkLibxslt.h: Ditto.
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::transformToString): Set
xsltMaxDepth
to 1000. Default in libxslt.dylib is 3000.
Source/WTF:
- wtf/cocoa/SoftLinking.h:
(SOFT_LINK_VARIABLE_FOR_HEADER):
(SOFT_LINK_VARIABLE_FOR_SOURCE):
- Add macros for non-constant global variables.
LayoutTests:
- fast/xsl/xslt-max-depth-expected.txt: Added.
- fast/xsl/xslt-max-depth.html: Added.
- 8:31 PM Changeset in webkit [237619] by
-
- 1 edit in trunk/Tools/DumpRenderTree/PlatformWin.cmake
Unreviewed build fix
- 7:30 PM Changeset in webkit [237618] by
-
- 44 edits14 adds in trunk/LayoutTests/imported/w3c
Resync XHR Web Platform Tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=191085
Reviewed by Alex Christensen.
Resync XHR Web Platform Tests from upstream 75b0f336c5.
- web-platform-tests/xhr/abort-after-stop.htm:
- web-platform-tests/xhr/getallresponseheaders-expected.txt:
- web-platform-tests/xhr/getallresponseheaders.htm:
- web-platform-tests/xhr/getresponseheader.any-expected.txt: Added.
- web-platform-tests/xhr/getresponseheader.any.html: Added.
- web-platform-tests/xhr/getresponseheader.any.js: Added.
(async_test.t.client.onload.t.step_func_done):
- web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Added.
- web-platform-tests/xhr/getresponseheader.any.worker.html: Added.
- web-platform-tests/xhr/headers-normalize-response-expected.txt:
- web-platform-tests/xhr/headers-normalize-response.htm:
- web-platform-tests/xhr/open-after-abort.htm:
- web-platform-tests/xhr/open-after-stop.window-expected.txt: Added.
- web-platform-tests/xhr/open-after-stop.window.html: Added.
- web-platform-tests/xhr/open-after-stop.window.js: Added.
(onload):
- web-platform-tests/xhr/overridemimetype-edge-cases.window-expected.txt:
- web-platform-tests/xhr/overridemimetype-edge-cases.window.js:
(async_test.t.client.onload.t.step_func_done):
(async_test.t.client.onload.t.step_func):
- web-platform-tests/xhr/resources/headers-www-authenticate.asis: Added.
- web-platform-tests/xhr/resources/inspect-headers.py:
(get_response):
- web-platform-tests/xhr/resources/responseXML-unavailable-in-worker.js:
(test):
- web-platform-tests/xhr/resources/w3c-import.log:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-aborted.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-abortedonmain.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-overrides.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-overridesexpires.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-simple.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-synconmain.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-synconworker.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout-twice.js:
- web-platform-tests/xhr/resources/xmlhttprequest-timeout.js:
(AbortedRequest):
(SyncRequestSettingTimeoutAfterOpen.this.startXHR):
(SyncRequestSettingTimeoutAfterOpen):
(SyncRequestSettingTimeoutBeforeOpen.this.startXHR):
(SyncRequestSettingTimeoutBeforeOpen):
(runTestRequests):
- web-platform-tests/xhr/send-content-type-charset-expected.txt:
- web-platform-tests/xhr/send-content-type-charset.htm:
- web-platform-tests/xhr/send-data-readablestream.any-expected.txt: Added.
- web-platform-tests/xhr/send-data-readablestream.any.html: Added.
- web-platform-tests/xhr/send-data-readablestream.any.js: Added.
(assert_xhr):
(test):
(promise_test.async):
- web-platform-tests/xhr/send-data-readablestream.any.worker-expected.txt: Added.
- web-platform-tests/xhr/send-data-readablestream.any.worker.html: Added.
- web-platform-tests/xhr/setrequestheader-allow-empty-value-expected.txt:
- web-platform-tests/xhr/setrequestheader-allow-whitespace-in-value-expected.txt:
- web-platform-tests/xhr/setrequestheader-header-allowed-expected.txt:
- web-platform-tests/xhr/setrequestheader-header-allowed.htm:
- web-platform-tests/xhr/timeout-multiple-fetches.html:
- web-platform-tests/xhr/w3c-import.log:
- web-platform-tests/xhr/xmlhttprequest-timeout-aborted.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-abortedonmain.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-overrides.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-overridesexpires.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-simple.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-synconmain-expected.txt:
- web-platform-tests/xhr/xmlhttprequest-timeout-synconmain.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-twice.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-aborted.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-overrides.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-overridesexpires.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-simple.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-synconworker.html:
- web-platform-tests/xhr/xmlhttprequest-timeout-worker-twice.html:
- 7:29 PM Changeset in webkit [237617] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
https://bugs.webkit.org/show_bug.cgi?id=191067
Patch by Jim Mason <jmason@ibinx.com> on 2018-10-30
Reviewed by Michael Catanzaro.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::handleMousePressEvent):
- 7:29 PM Changeset in webkit [237616] by
-
- 5 edits2 adds in trunk/Tools
[Win][Direct2D] Support building DumpRenderTree for Direct2D
https://bugs.webkit.org/show_bug.cgi?id=191093
<rdar://problem/45685706>
Reviewed by Alex Christensen.
- DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
- DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
- DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
(pixelDumpSystemFactory): Added.
(printPNG): Create stub.
(computeMD5HashStringForBitmapContext): Ditto.
(dumpBitmap): Ditto.
- DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
(BitmapContext::createByAdoptingBitmapAndContext):
(BitmapContext::~BitmapContext):
(BitmapContext::platformContext const):
(BitmapContext::BitmapContext):
- DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Update to support Direct2D.
- MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
logo is no longer available at this location. Switch to the new logo.
- 7:27 PM Changeset in webkit [237615] by
-
- 4 edits in trunk/Source/WebKit
[PSON] View gesture snapshot gets taken down early when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191083
<rdar://problem/45058738>
Reviewed by Alex Christensen.
When process-swapping, we would call WebViewImpl::processDidExit(), which would destroy
the ViewGestureController and thus take down the swipe navigation snapshot before it
should. We now call WebViewImpl::processDidSwap() instead, which does the same thing,
except for destroying the ViewGestureController. As a result, the view snapshot stays
visible as long as it is needed, even in case of process swap.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::handleProcessSwapOrExit):
(WebKit::WebViewImpl::processWillSwap):
(WebKit::WebViewImpl::processDidExit):
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::processWillSwap):
- 7:27 PM Changeset in webkit [237614] by
-
- 2 edits in trunk/Source/WebKit
[PSON] WebView renders with incorrect dimensions after back or forward
https://bugs.webkit.org/show_bug.cgi?id=191071
<rdar://problem/45058950>
Reviewed by Alex Christensen.
Make sure WebPage::reinitializeWebPage() updates the page's dimensions if needed using the
WebPageCreationParameters it is provided.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
- 6:11 PM Changeset in webkit [237613] by
-
- 19 edits2 moves46 adds10 deletes in trunk
Web Inspector: Audit: create Audit Tab
https://bugs.webkit.org/show_bug.cgi?id=190754
Reviewed by Matt Baker.
Source/WebInspectorUI:
Create an Audit tab for running audits on the inspected page. Leverage
Runtime.evaluate
for running the audit tests (arbitrary JavaScript), and use the returned value to generate
a preview UI of the results. All tests/results can be exported/imported to formatted JSON:
AuditTestCaseJSON:
{
"type": "test-case",
"name": <string>,
<optional> "description": <string>,
"test": <stringified JavaScript function>,
}
AuditTestGroupJSON:
{
"type": "test-group",
"name": <string>,
<optional> "description": <string>,
"tests": [...<AuditTestCase, AuditTestGroup>],
}
AuditTestCaseResultJSON:
{
"type": "test-case-result",
"name": <string>,
<optional> "description": <string>,
"level": <"pass", "warn", "fail", "error", "unsupported">,
"data": {
"domNodes": [...<stringified CSS path>],
"domAttributes": [...<string>],
"errors": [...<string>],
},
}
AuditTestGroupResultJSON:
{
"type": "test-group-result",
"name": <string>,
<optional> "description": <string>,
"results": [...<AuditTestCaseResult, AuditTestGroupResult>],
}
More keys may be added in the future (especially for
AuditTestCaseResult.data).
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager):
(WI.AuditManager.synthesizeError): Added.
(WI.AuditManager.prototype.get tests): Added.
(WI.AuditManager.prototype.get results): Added.
(WI.AuditManager.prototype.get runningState): Added.
(WI.AuditManager.prototype.start): Added.
(WI.AuditManager.prototype.stop): Added.
(WI.AuditManager.prototype.import): Added.
(WI.AuditManager.prototype.export): Added.
(WI.AuditManager.prototype._addTest): Added.
(WI.AuditManager.prototype._addResult): Added.
(WI.AuditManager.prototype.get testSuites): Deleted.
(WI.AuditManager.prototype.get reports): Deleted.
(WI.AuditManager.prototype.async runAuditTestByRepresentedObject): Deleted.
(WI.AuditManager.prototype.reportForId): Deleted.
(WI.AuditManager.prototype.removeAllReports): Deleted.
(WI.AuditManager.prototype.async _runTestCase): Deleted.
- UserInterface/Models/AuditTestBase.js: Added.
(WI.AuditTestBases):
(WI.AuditTestBases.prototype.get name):
(WI.AuditTestBases.prototype.get description):
(WI.AuditTestBases.prototype.get runningState):
(WI.AuditTestBases.prototype.get result):
(WI.AuditTestBases.prototype.async start):
(WI.AuditTestBases.prototype.stop):
(WI.AuditTestBases.prototype.clearResult):
(WI.AuditTestBases.prototype.saveIdentityToCookie):
(WI.AuditTestBases.prototype.toJSON):
(WI.AuditTestBases.prototype.async run):
- UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase):
(WI.AuditTestCase.fromPayload): Added.
(WI.AuditTestCase.prototype.toJSON): Added.
(WI.AuditTestCase.prototype.async run): Added.
(WI.AuditTestCase.prototype.async run.setLevel): Added.
(WI.AuditTestCase.prototype.async run.addError): Added.
(WI.AuditTestCase.prototype.async run.checkResultProperty.addErrorForValueType): Added.
(WI.AuditTestCase.prototype.async run.checkResultProperty): Added.
(WI.AuditTestCase.prototype.async run.async resultArrayForEach): Added.
(WI.AuditTestCase.prototype.get id): Deleted.
(WI.AuditTestCase.prototype.get name): Deleted.
(WI.AuditTestCase.prototype.get suite): Deleted.
(WI.AuditTestCase.prototype.get setup): Deleted.
(WI.AuditTestCase.prototype.get tearDown): Deleted.
(WI.AuditTestCase.prototype.get errorDetails): Deleted.
- UserInterface/Models/AuditTestGroup.js: Added.
(WI.AuditTestGroup):
(WI.AuditTestGroup.fromPayload):
(WI.AuditTestGroup.prototype.get tests):
(WI.AuditTestGroup.prototype.stop):
(WI.AuditTestGroup.prototype.clearResult):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype.toJSON):
(WI.AuditTestGroup.prototype._updateResult):
(WI.AuditTestGroup.prototype._handleTestCompleted):
(WI.AuditTestGroup.prototype._handleTestProgress):
- UserInterface/Models/AuditTestResultBase.js: Added.
(WI.AuditTestResultBase):
(WI.AuditTestResultBase.prototype.get name):
(WI.AuditTestResultBase.prototype.get description):
(WI.AuditTestResultBase.prototype.get result):
(WI.AuditTestResultBase.prototype.get didPass):
(WI.AuditTestResultBase.prototype.get didWarn):
(WI.AuditTestResultBase.prototype.get didFail):
(WI.AuditTestResultBase.prototype.get didError):
(WI.AuditTestResultBase.prototype.get unsupported):
(WI.AuditTestResultBase.prototype.saveIdentityToCookie):
(WI.AuditTestResultBase.prototype.toJSON):
- UserInterface/Models/AuditTestCaseResult.js: Added.
(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload.checkArray):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get level):
(WI.AuditTestCaseResult.prototype.get data):
(WI.AuditTestCaseResult.prototype.get didPass):
(WI.AuditTestCaseResult.prototype.get didWarn):
(WI.AuditTestCaseResult.prototype.get didFail):
(WI.AuditTestCaseResult.prototype.get didError):
(WI.AuditTestCaseResult.prototype.get unsupported):
(WI.AuditTestCaseResult.prototype.toJSON):
- UserInterface/Models/AuditTestGroupResult.js: Added.
(WI.AuditTestGroupResult):
(WI.AuditTestGroupResult.fromPayload):
(WI.AuditTestGroupResult.prototype.get results):
(WI.AuditTestGroupResult.prototype.get levelCounts):
(WI.AuditTestGroupResult.prototype.get didPass):
(WI.AuditTestGroupResult.prototype.get didWarn):
(WI.AuditTestGroupResult.prototype.get didFail):
(WI.AuditTestGroupResult.prototype.get didError):
(WI.AuditTestGroupResult.prototype.get unsupported):
(WI.AuditTestGroupResult.prototype.toJSON):
- UserInterface/Views/AuditTabContentView.js: Added.
(WI.AuditTabContentView):
(WI.AuditTabContentView.tabInfo):
(WI.AuditTabContentView.isTabAllowed):
(WI.AuditTabContentView.prototype.get type):
(WI.AuditTabContentView.prototype.get supportsSplitContentBrowser):
(WI.AuditTabContentView.prototype.canShowRepresentedObject):
(WI.AuditTabContentView.prototype.shown):
(WI.AuditTabContentView.prototype.hidden):
(WI.AuditTabContentView.prototype._handleSpace):
- UserInterface/Views/AuditNavigationSidebarPanel.js: Added.
(WI.AuditNavigationSidebarPanel):
(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.closed):
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestAdded):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestCompleted):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleStartStopButtonNavigationItemClicked):
(WI.AuditNavigationSidebarPanel.prototype._handleImportButtonNavigationItemClicked):
- UserInterface/Views/AuditNavigationSidebarPanel.css: Added.
(.sidebar > .panel.navigation.audit > .content):
- UserInterface/Views/AuditTreeElement.js: Added.
(WI.AuditTreeElement):
(WI.AuditTreeElement.prototype.get result):
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.ondetach):
(WI.AuditTreeElement.prototype.onpopulate):
(WI.AuditTreeElement.prototype.populateContextMenu):
(WI.AuditTreeElement.prototype._start):
(WI.AuditTreeElement.prototype._updateLevel):
(WI.AuditTreeElement.prototype._showRunningSpinner):
(WI.AuditTreeElement.prototype._showRunningProgress):
(WI.AuditTreeElement.prototype._handleTestCaseCompleted):
(WI.AuditTreeElement.prototype._handleTestResultCleared):
(WI.AuditTreeElement.prototype._handleTestCaseScheduled):
(WI.AuditTreeElement.prototype._handleTestGroupCompleted):
(WI.AuditTreeElement.prototype._handleTestGroupProgress):
(WI.AuditTreeElement.prototype._handleTestGroupScheduled):
(WI.AuditTreeElement.prototype._handleStatusClick):
- UserInterface/Views/AuditTreeElement.css: Added.
(.tree-outline .item.audit > .status):
(.tree-outline .item.audit > .status > img):
(.tree-outline .item.audit:matches(.test-case, .test-group) > .status:hover > img):
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:not(:hover)):
(.tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status):
(.tree-outline .item.audit > .status > img.pass):
(.tree-outline .item.audit > .status > img.warn):
(.tree-outline .item.audit > .status > img.fail):
(.tree-outline .item.audit > .status > img.error):
(.tree-outline .item.audit > .status > img.unsupported):
(.audit.test-case .icon):
(.audit.test-group .icon):
(.audit.test-case-result .icon):
(.audit.test-group-result .icon):
- UserInterface/Views/AuditTestContentView.js: Added.
(WI.AuditTestContentView):
(WI.AuditTestContentView.prototype.get navigationItems):
(WI.AuditTestContentView.prototype.get headerView):
(WI.AuditTestContentView.prototype.get contentView):
(WI.AuditTestContentView.prototype.get supportsSave):
(WI.AuditTestContentView.prototype.get saveData):
(WI.AuditTestContentView.prototype.initialLayout):
(WI.AuditTestContentView.prototype.layout):
(WI.AuditTestContentView.prototype.shown):
(WI.AuditTestContentView.prototype.hidden):
(WI.AuditTestContentView.prototype.get placeholderElement):
(WI.AuditTestContentView.prototype.set placeholderElement):
(WI.AuditTestContentView.prototype.showRunningPlaceholder):
(WI.AuditTestContentView.prototype.showStoppingPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
(WI.AuditTestContentView.prototype.showFilteredPlaceholder):
(WI.AuditTestContentView.prototype.hidePlaceholder):
(WI.AuditTestContentView.prototype.applyFilter):
(WI.AuditTestContentView.prototype.resetFilter):
(WI.AuditTestContentView.prototype._exportAudit):
(WI.AuditTestContentView.prototype._updateExportButtonNavigationItemState):
(WI.AuditTestContentView.prototype._showPlaceholder):
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleTestChanged):
- UserInterface/Views/AuditTestContentView.css: Added.
(.content-view-container > .content-view.audit-test):
(.content-view-container > .content-view.audit-test > header):
(.content-view-container > .content-view.audit-test > header h1):
(.content-view-container > .content-view.audit-test > header p):
(.content-view.audit-test):
(.content-view.audit-test h1):
(.content-view.audit-test > header):
(.content-view.audit-test > header p):
(.content-view.audit-test .audit-test.filtered, .content-view.audit-test .audit-test .message-text-view):
(.content-view.audit-test > section):
(.content-view.audit-test > section > .message-text-view):
(.content-view.audit-test.showing-placeholder):
(.content-view.audit-test.showing-placeholder > section):
(.content-view.audit-test.showing-placeholder > section > :not(.message-text-view)):
(@media (prefers-dark-interface) .content-view.audit-test):
- UserInterface/Views/AuditTestCaseContentView.js: Added.
(WI.AuditTestCaseContentView):
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
(WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):
- UserInterface/Views/AuditTestCaseContentView.css: Added.
(.content-view-container > .content-view.audit-test-case > header):
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view):first-child):
(.content-view.audit-test-case > header > h1):
(.content-view.audit-test-case > header > h1 > img):
(.content-view.audit-test-case > section > :not(.message-text-view)):
(.content-view.audit-test-case > section > :not(.message-text-view):last-child):
(.content-view.audit-test-case > section > :not(.message-text-view) + :not(.message-text-view)):
(.content-view.audit-test-case > section h1):
(.content-view.audit-test-case > section table):
(.content-view.audit-test-case > section table > tr + tr > td):
(.content-view.audit-test-case > section table > tr > td > :not(.tree-outline)):
(.content-view.audit-test-case > section table > tr > td:first-child):
(.content-view.audit-test-case > section > .dom-nodes > table > tr > td:first-child):
(.content-view.audit-test-case > section code):
(.content-view.audit-test-case > section mark):
- UserInterface/Views/AuditTestGroupContentView.js: Added.
(WI.AuditTestGroupContentView):
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
(WI.AuditTestGroupContentView.prototype.shown):
(WI.AuditTestGroupContentView.prototype.hidden):
(WI.AuditTestGroupContentView.prototype.applyFilter):
(WI.AuditTestGroupContentView.prototype.resetFilter):
(WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
(WI.AuditTestGroupContentView.prototype._subobjects):
(WI.AuditTestGroupContentView.prototype._updateLevelScopeBar):
(WI.AuditTestGroupContentView.prototype._handleTestGroupCompleted):
(WI.AuditTestGroupContentView.prototype._handleTestGroupProgress):
(WI.AuditTestGroupContentView.prototype._handleTestGroupScheduled):
(WI.AuditTestGroupContentView.prototype._handleLevelScopeBarSelectionChanged):
- UserInterface/Views/AuditTestGroupContentView.css: Added.
(.content-view-container > .content-view.audit-test-group > header):
(.content-view.audit-test-group > header):
(.content-view.audit-test-group.no-matches + .audit-test-group > header):
(.content-view.audit-test-group > header, .content-view.audit-test-group:not(.filtered):last-child > header):
(.content-view.audit-test-group.contains-test-case > header):
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case):
(.content-view.audit-test-group.contains-test-case:not(.contains-test-group) > section, .content-view.audit-test-group.contains-test-case.contains-test-group > section > .audit-test-case):
(.content-view.audit-test-group > header > .information):
(.content-view.audit-test-group > header > .information > p):
(.content-view.audit-test-group > header > nav):
(.content-view.audit-test-group > header > nav:empty):
(.content-view.audit-test-group > header > nav:not(:empty):before):
(.content-view.audit-test-group > header > nav > .scope-bar > li):
(.content-view.audit-test-group > header > nav > .scope-bar > li:not(:hover, .selected)):
(.content-view.audit-test-group > header > nav > .scope-bar > li:last-child):
(.content-view.audit-test-group > header > nav > .scope-bar > li::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.pass::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.warn::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.fail::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.error::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.unsupported::before):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after):
(.content-view.audit-test-group > section > .audit-test-case:first-child, .content-view.audit-test-group > section > .audit-test-group + .audit-test-case, .content-view.audit-test-group > section > .audit-test-case + .audit-test-group):
(.content-view.audit-test-group > section > .audit-test-case:last-child):
- UserInterface/Views/ScopeBarItem.js:
(WI.ScopeBarItem):
(WI.ScopeBarItem.prototype.set selected):
- UserInterface/Views/MultipleScopeBarItem.js:
(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
Add anindependentoption that prevents selection changes from deselecting other
WI.ScopeBarItems in the sameWI.ScopeBar(exclusivetakes precedence).
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement):
(WI.DOMTreeElement.prototype.highlightAttribute):
(WI.DOMTreeElement.prototype._buildAttributeDOM):
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li .highlight):
- UserInterface/Views/ToggleButtonNavigationItem.js:
(WI.ToggleButtonNavigationItem.prototype.set toggled):
Also change thelabelif theButtonStylehas text.
- UserInterface/Base/Setting.js:
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- UserInterface/Views/DividerNavigationItem.css:
(.navigation-bar .item.divider):
- UserInterface/Base/Utilities.js:
(Promise.chain): Added.
- UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):
- UserInterface/Main.html:
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
- UserInterface/Test.html:
- UserInterface/Base/Test.js:
(WI.loaded):
- UserInterface/Images/Audit.svg: Added.
- UserInterface/Images/AuditStart.svg: Added.
- UserInterface/Images/AuditStop.svg: Added.
- UserInterface/Images/AuditTestCase.svg: Added.
- UserInterface/Images/AuditTestCaseResult.svg: Added.
- UserInterface/Images/AuditTestError.svg: Added.
- UserInterface/Images/AuditTestFail.svg: Added.
- UserInterface/Images/AuditTestGroup.svg: Added.
- UserInterface/Images/AuditTestGroupResult.svg: Added.
- UserInterface/Images/AuditTestNoResult.svg: Added.
- UserInterface/Images/AuditTestPass.svg: Added.
- UserInterface/Images/AuditTestUnsupported.svg: Added.
- UserInterface/Images/AuditTestWarn.svg: Added.
- Localizations/en.lproj/localizedStrings.js:
LayoutTests:
- inspector/audit/resources/audit-utilities.js: Added.
- inspector/audit/basic-expected.txt: Added.
- inspector/audit/basic.html: Added.
- inspector/audit/data-domAttributes-expected.txt: Added.
- inspector/audit/data-domAttributes.html: Added.
- inspector/audit/data-domNodes-expected.txt: Added.
- inspector/audit/data-domNodes.html: Added.
- inspector/audit/data-errors-expected.txt: Added.
- inspector/audit/data-errors.html: Added.
- inspector/model/auditTestCase-expected.txt: Added.
- inspector/model/auditTestCase.html: Added.
- inspector/model/auditTestCaseResult-expected.txt: Added.
- inspector/model/auditTestCaseResult.html: Added.
- inspector/model/auditTestGroup-expected.txt: Added.
- inspector/model/auditTestGroup.html: Added.
- inspector/model/auditTestGroupResult-expected.txt: Added.
- inspector/model/auditTestGroupResult.html: Added.
- inspector/unit-tests/promise-utilities-expected.txt: Added.
- inspector/unit-tests/promise-utilities.html: Added.
- inspector/audit/audit-manager-expected.txt: Removed.
- inspector/audit/audit-manager.html: Removed.
- inspector/audit/audit-report-expected.txt: Removed.
- inspector/audit/audit-report.html: Removed.
- inspector/audit/audit-test-case-expected.txt: Removed.
- inspector/audit/audit-test-case.html: Removed.
- inspector/audit/audit-test-suite-expected.txt: Removed.
- inspector/audit/audit-test-suite.html: Removed.
- inspector/audit/resources/audit-test-fixtures.js: Removed.
- 5:44 PM Changeset in webkit [237612] by
-
- 3 edits in trunk/Tools
webkitpy: Support alternate simctl list outputs
https://bugs.webkit.org/show_bug.cgi?id=191090
<rdar://problem/45684255>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._create_runtimes): Support alternative availability format.
(SimulatedDeviceManager._create_device_with_runtime): Ditto.
- Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_available_devices): Add iOS 12 with alternative availability format.
- 5:38 PM Changeset in webkit [237611] by
-
- 2 edits in trunk/Source/WebKit
Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.
https://bugs.webkit.org/show_bug.cgi?id=191049
Reviewed by Dean Jackson.
Move the feature flag to experimental feature section.
- Shared/WebPreferences.yaml:
- 5:15 PM Changeset in webkit [237610] by
-
- 9 edits1 add in trunk/Source
Enable InstallAPI for iOS unconditionally
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423
Reviewed by Dan Bernstein.
Source/WebKit:
- Configurations/Base.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
excluded header - WebKit doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj: Added NSURLDownloadSPI.h.
Source/WebKitLegacy/mac:
- Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.
- MigrateHeaders.make: Removed an obsolete workaround.
- Misc/NSURLDownloadSPI.h: Added.
- Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
- 4:45 PM Changeset in webkit [237609] by
-
- 2 edits in trunk/LayoutTests
WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance
https://bugs.webkit.org/show_bug.cgi?id=189641
Unreviewed.
Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-30
- platform/ios-wk2/TestExpectations: Mark test as [ Slow ]
- 4:06 PM Changeset in webkit [237608] by
-
- 4 edits in trunk
Web Inspector: provide options to WI.cssPath for more verbosity
https://bugs.webkit.org/show_bug.cgi?id=190987
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Base/DOMUtilities.js:
(WI.cssPath):
(WI.cssPathComponent):
When the optionfullis true, print every attribute along with every node in the hierarchy
until the root is reached. This partially duplicates the effect of an XPath, but instead
uses CSS selectors, making it much more human readable and recognizable.
LayoutTests:
- inspector/dom/domutilities-csspath.html:
- 3:45 PM Changeset in webkit [237607] by
-
- 32 edits1 delete in trunk
Clean up some obsolete MAX_ALLOWED macros
https://bugs.webkit.org/show_bug.cgi?id=190916
Reviewed by Tim Horton.
Source/JavaScriptCore:
- API/JSManagedValue.mm:
- API/JSVirtualMachine.mm:
- API/JSWrapperMap.mm:
Source/ThirdParty/libwebrtc:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
Source/WebCore:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::exernalDeviceDisplayNameForPlayer):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
Source/WebCore/PAL:
- pal/cf/CoreMediaSoftLink.cpp:
- pal/cf/CoreMediaSoftLink.h:
Behavior change here. The check didn't really make sense, pretty sure we would
just crash when hitting this code path on iOS.
- pal/spi/cf/CFNetworkSPI.h:
- pal/spi/cocoa/PassKitSPI.h:
- pal/spi/mac/AVFoundationSPI.h:
Source/WebKit:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):
- Platform/spi/Cocoa/DeviceIdentitySPI.h:
- Platform/spi/ios/UIKitSPI.h:
- Shared/WebPreferencesDefaultValues.cpp:
(defaultCustomPasteboardDataEnabled):
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKPaymentRequest):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]): Deleted.
Source/WebKitLegacy/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView pressureChangeWithEvent:]):
- WebView/WebPDFView.h:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/PlatformMac.cmake:
- wtf/spi/cocoa/NSMapTableSPI.h: Removed. This was only needed for old SDKs.
Tools:
- TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
- 3:35 PM Changeset in webkit [237606] by
-
- 9 edits1 delete in trunk/Source
Unreviewed, rolling out r237600 and r237604.
https://bugs.webkit.org/show_bug.cgi?id=191086
Breaks internal iOS builds (Requested by ryanhadd_ on
#webkit).
Reverted changesets:
"Enable InstallAPI for iOS unconditionally"
https://bugs.webkit.org/show_bug.cgi?id=191043
https://trac.webkit.org/changeset/237600
"Build fix attempt after enabling InstallAPI for iOS."
https://bugs.webkit.org/show_bug.cgi?id=191043
https://trac.webkit.org/changeset/237604
- 3:15 PM Changeset in webkit [237605] by
-
- 6 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: change WI.ColorWheel to use conic-gradient()
https://bugs.webkit.org/show_bug.cgi?id=189485
Reviewed by Brian Burg.
Use the ("new") HSL
WI.ColorPickerifconic-gradientis supported. Otherwise, use the
("old") RGBWI.LegacyColorPicker.
- UserInterface/Views/ColorWheel.js:
(WI.ColorWheel):
(WI.ColorWheel.prototype.set dimension):
(WI.ColorWheel.prototype.set brightness):
(WI.ColorWheel.prototype.get tintedColor):
(WI.ColorWheel.prototype.set tintedColor):
(WI.ColorWheel.prototype.get rawColor):
(WI.ColorWheel.prototype.get _hue): Added.
(WI.ColorWheel.prototype.get _saturation): Added.
(WI.ColorWheel.prototype._updateColorForMouseEvent):
(WI.ColorWheel.prototype._setCrosshairPosition):
(WI.ColorWheel.prototype._updateGradient): Added.
(WI.ColorWheel.prototype._pointInCircleForEvent.distance): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent.angleFromCenterToPoint): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent.pointOnCircumference): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent): Deleted.
(WI.ColorWheel.prototype._tintedColorToPointAndBrightness): Deleted.
(WI.ColorWheel.prototype._drawRawCanvas): Deleted.
(WI.ColorWheel.prototype._colorAtPointWithBrightness): Deleted.
(WI.ColorWheel.prototype._drawTintedCanvas): Deleted.
(WI.ColorWheel.prototype._draw): Deleted.
- UserInterface/Views/ColorWheel.css:
(.color-wheel > .gradient): Added.
(.color-wheel > .crosshair): Added.
- UserInterface/Views/LegacyColorWheel.js: Copied from Source/WebInspectorUI/UserInterface/Views/ColorWheel.js.
- UserInterface/Views/ColorPicker.js:
(WI.ColorPicker):
(WI.ColorPicker.supportsConicGradient): Added.
(WI.ColorPicker.prototype._updateSliders):
- UserInterface/Models/Geometry.js:
(WI.Point.prototype.distance):
- UserInterface/Main.html:
- 3:10 PM Changeset in webkit [237604] by
-
- 2 edits in trunk/Source/WebKit
Build fix attempt after enabling InstallAPI for iOS.
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423
- Configurations/WebKit.xcconfig: Skip NSURLDownloadSPI.h here too.
- 2:49 PM Changeset in webkit [237603] by
-
- 7 copies1 add in releases/Apple/watchOS 5.1
Added a tag for watchOS 5.1.
- 2:49 PM Changeset in webkit [237602] by
-
- 8 copies1 add in releases/Apple/iOS 12.1
Added a tag for iOS 12.1.
- 2:49 PM Changeset in webkit [237601] by
-
- 9 copies1 add in releases/Apple/Safari 12.0.1
Added a tag for Safari 12.0.1.
- 1:41 PM Changeset in webkit [237600] by
-
- 8 edits1 add in trunk/Source
Enable InstallAPI for iOS unconditionally
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423
Reviewed by Dan Bernstein.
Source/WebKit:
- Configurations/Base.xcconfig: Enabled it.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj: Added NSURLDownloadSPI.h.
Source/WebKitLegacy/mac:
- Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.
- MigrateHeaders.make: Removed an obsolete workaround.
- Misc/NSURLDownloadSPI.h: Added.
- Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
- 1:23 PM Changeset in webkit [237599] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: make the layers sidebar in the Elements tab always visible
https://bugs.webkit.org/show_bug.cgi?id=190158
Reviewed by Brian Burg.
- UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
- UserInterface/Views/SearchTabContentView.js:
(WI.SearchTabContentView):
- 12:58 PM Changeset in webkit [237598] by
-
- 3 edits2 adds in trunk
Calling window.open("", "_self") allows working around restrictions on window.close()
https://bugs.webkit.org/show_bug.cgi?id=191073
Reviewed by Chris Dumez.
Source/WebCore:
Do not treat a re-used frame in DOMWindow::createWindow as having been opened by DOM.
Test: fast/dom/Window/window-open-self-disallow-close.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
LayoutTests:
- fast/dom/Window/window-open-self-disallow-close-expected.txt: Added.
- fast/dom/Window/window-open-self-disallow-close.html: Added.
- 12:07 PM Changeset in webkit [237597] by
-
- 24 edits4 adds in trunk
[Payment Request] Implement PaymentResponse.retry()
https://bugs.webkit.org/show_bug.cgi?id=190985
Source/WebCore:
Reviewed by Daniel Bates.
Implemented the retry() method on PaymentResponse as specified in the Payment Request API
W3C Editor's Draft of 24 October 2018.
See https://w3c.github.io/payment-request/#retry-method for details.
Tests: http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html
http/tests/paymentrequest/payment-response-retry-method.https.html
- Modules/applepay/PaymentCoordinator.h:
(WebCore::PaymentCoordinator::client): Added. Returns m_client.
- Modules/applepay/PaymentCoordinatorClient.h:
(WebCore::PaymentCoordinatorClient::isMockPaymentCoordinator const): Added. Used to downcast
a PaymentCoordinatorClient to a MockPaymentCoordinator.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::computeTotalAndLineItems const): Made const.
(WebCore::ApplePayPaymentHandler::computeErrors const): Broke this function into
computeAddressErrors, computePayerErrors, and computePaymentMethodErrors, then modified this
function to call those functions. Exceptions thrown by computePaymentMethodErrors are ignored.
(WebCore::ApplePayPaymentHandler::computeAddressErrors const): Added.
(WebCore::ApplePayPaymentHandler::computePayerErrors const): Added.
(WebCore::ApplePayPaymentHandler::computePaymentMethodErrors const): Added.
(WebCore::ApplePayPaymentHandler::complete): Added ASSERTs to verify whether result is a
final result.
(WebCore::ApplePayPaymentHandler::retry): Computed PaymentErrors from PaymentValidationErrors,
ensured the PaymentAuthorizationResult was non-final by adding an unknown error if necessary,
and called PaymentCoordinator::completePaymentSession.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::show): Changed to call settleShowPromise.
(WebCore::PaymentRequest::abortWithException): Changed to abort PaymentResponse's retry
promise, if present, instead of PaymentResponse's show promise.
(WebCore::PaymentRequest::settleShowPromise): Added. Settles m_showPromise then sets it to
std::nullopt.
(WebCore::PaymentRequest::closeActivePaymentHandler): Added. Hides the active payment
handler then sets it to std::nullopt.
(WebCore::PaymentRequest::stop): Stopped calling abortWithException, since that function
might settle PaymentResponse's retry promise. PaymentResponse is now an ActiveDOMObject and
will settle its own promise in its implementation of stop.
(WebCore::PaymentRequest::abort): Changed to throw an InvalidStateError if there is a
pending retry promise and to call abortWithException instead of stop.
(WebCore::PaymentRequest::completeMerchantValidation): Changed to call abortWithException
instead of stop.
(WebCore::PaymentRequest::settleDetailsPromise): Ditto.
(WebCore::PaymentRequest::accept): Updated the existing PaymentResponse, if present, rather
than creating a new one. Settled the existing PaymentResponse's retry promise, if present,
rather than the show promise.
(WebCore::PaymentRequest::complete): Changed to throw an AbortError if there is no longer an
active payment handler.
(WebCore::PaymentRequest::retry): Changed to throw an AbortError if there is no longer an
active payment handler, and to call PaymentHandler::retry if there is.
(WebCore::PaymentRequest::cancel): Changed to call abortWithException instead of stop.
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentRequest.idl:
- Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::finishConstruction): Pending activities create strong references
to |this|, so they cannot be created in constructors without relaxing adoption requirements.
Added this function so that the pending activity can be created after the PaymentResponse is
created and adopted.
(WebCore::PaymentResponse::~PaymentResponse):
(WebCore::PaymentResponse::complete): Updated to throw an AbortError or InvalidStateError
when necessary.
(WebCore::PaymentResponse::retry): Implemented. Throws an AbortError or InvalidStateError
when necessary, otherwise calls PaymentRequest::retry and stores the retry promise in
m_retryPromise.
(WebCore::PaymentResponse::abortWithException): Added. Rejects the retry promise with
|exception|, clears the pending activity, and sets m_state to Completed.
(WebCore::PaymentResponse::settleRetryPromise): Added. Settles the retry promise and sets it
to std::nullopt.
(WebCore::PaymentResponse::canSuspendForDocumentSuspension const): Added. Returns true if
there is no pending activity.
(WebCore::PaymentResponse::stop): Added. Rejects the retry promise with AbortError, clears
the pending activity, and sets m_state to Stopped.
- Modules/paymentrequest/PaymentResponse.h: Changed create to call finishConstruction and
made PaymentResponse an ActiveDOMObject instead of a ContextDestructionObserver.
- testing/Internals.cpp:
(WebCore::Internals::Internals): Changed to only create a MockPaymentCoordinator for main frames.
(WebCore::Internals::mockPaymentCoordinator): Changed to get the MockPaymentCoordinator by
downcasting the page's payment coordinator client.
- testing/Internals.h:
- testing/Internals.idl:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::completePaymentSession): Changed to only increment
hideCount for final results.
- testing/MockPaymentCoordinator.h:
(isType): Added so that PaymentCoordinatorClients can be downcasted to MockPaymentCoordinators.
LayoutTests:
Reviewed by Daniel Bates
- http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
- http/tests/paymentrequest/payment-response-complete-method.https.html:
- http/tests/paymentrequest/payment-response-methodName-attribute.https.html:
- http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html:
- http/tests/paymentrequest/payment-response-payerName-attribute.https.html:
- http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html:
- http/tests/paymentrequest/payment-response-rejects-if-not-active.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html: Copied from
imported/w3c/web-platform-tests/payment-request/payment-response/rejects_if_not_active-manual.https.html
and automated using internals.mockPaymentCoordinator.
- http/tests/paymentrequest/payment-response-retry-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-retry-method.https.html: Copied from
imported/w3c/web-platform-tests/payment-request/payment-response/retry-method-manual.https.html
and automated using internals.mockPaymentCoordinator.
- http/tests/paymentrequest/resources/helpers.js:
(setUpAndSmokeTest):
- 11:33 AM Changeset in webkit [237596] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Use the mainframe view size to compute window.outerWidth/height.
https://bugs.webkit.org/show_bug.cgi?id=191070
<rdar://problem/42368377>
Reviewed by Tim Horton.
Use a more reasonable value for window.outerWidth and height.
(WKWebView's frame rect -> drawing area sizing -> WebPage's view size -> FrameView size)
- page/DOMWindow.cpp:
(WebCore::DOMWindow::outerHeight const):
(WebCore::DOMWindow::outerWidth const):
- 11:32 AM Changeset in webkit [237595] by
-
- 3 edits in trunk/Source/JavaScriptCore
useProbeOSRExit causes failures for Win64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=190656
Reviewed by Keith Miller.
- assembler/ProbeContext.cpp:
(JSC::Probe::executeProbe):
If lowWatermark is expected to equal lowWatermarkFromVisitingDirtyPages *regardless* of the input param,
then let's just call lowWatermarkFromVisitingDirtyPages instead.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
The result of VariableEventStream::reconstruct appears to be inappropriate for direct use as a stack pointer offset;
mimic the non-probe case and use requiredRegisterCountForExit from DFGCommonData instead.
(Also, stop redundantly setting the stack pointer twice in a row.)
- 11:12 AM Changeset in webkit [237594] by
-
- 8 edits in trunk
[Apple Pay] PaymentRequest.canMakePayment() should resolve to true whenever Apple Pay is available
https://bugs.webkit.org/show_bug.cgi?id=191039
Reviewed by Megan Gardner.
Source/WebCore:
During a recent Web Payments WG F2F, we decided that canMakePayment() should return true
whenever the user agent supports one or more of the specified payment methods, even if those
payment methods do not have active instruments.
Change WebKit's implementation of canMakePayment() for Apple Pay to resolve with the value
of ApplePaySession.canMakePayments() rather than ApplePaySession.canMakePaymentsWithActiveCard().
Added a test case to http/tests/paymentrequest/payment-request-canmakepayment-method.https.html.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::canMakePayment):
(WebCore::shouldDiscloseApplePayCapability): Deleted.
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::canMakePayments):
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl:
LayoutTests:
- http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
- http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
- 10:48 AM Changeset in webkit [237593] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: refactor WI.ScopeBarItem for better extensibility
https://bugs.webkit.org/show_bug.cgi?id=190986
Reviewed by Brian Burg.
Renames
withModifiertoextendSelectionfor clarity of usage, and to allow the changes
in <https://webkit.org/b/190754> (adding an option to allowWI.ScopeBarItems to be
selected without deselcting any otherWI.ScopeBarItems) to use the same variable.
- UserInterface/Views/ScopeBarItem.js:
(WI.ScopeBarItem):
(WI.ScopeBarItem.prototype.set selected):
(WI.ScopeBarItem.prototype._handleMouseDown):
(WI.ScopeBarItem.prototype.setSelected): Deleted.
- UserInterface/Views/ScopeBar.js:
(WI.ScopeBar):
(WI.ScopeBar.prototype._populate):
(WI.ScopeBar.prototype._itemSelectionDidChange):
- UserInterface/Views/MultipleScopeBarItem.js:
(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
- UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
- UserInterface/Views/LogContentView.js:
(WI.LogContentView):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
- UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
- 10:45 AM Changeset in webkit [237592] by
-
- 2 edits in trunk/LayoutTests
[ Mojave Debug ] Layout Test http/tests/workers/service/self_registration.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190828
Unreviewed.
Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-30
- platform/mac-wk2/TestExpectations: Mark test as flay.
- 10:32 AM Changeset in webkit [237591] by
-
- 54 edits in trunk
Add a deprecation warning to console for Web SQL
https://bugs.webkit.org/show_bug.cgi?id=190936
Reviewed by Ryosuke Niwa.
Source/WebCore:
No new tests. Just adding a console message.
- Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
LayoutTests:
Rebaseline the tests that are affected by the added console message.
- fast/dom/MutationObserver/database-callback-delivery-expected.txt:
- fast/frames/sandboxed-iframe-storage-expected.txt:
- fast/history/page-cache-webdatabase-no-transaction-db-expected.txt:
- http/tests/security/cross-origin-websql-allowed-expected.txt:
- http/tests/security/cross-origin-websql-expected.txt:
- http/tests/security/same-origin-websql-blocked-expected.txt:
- http/tests/security/storage-blocking-loosened-websql-expected.txt:
- http/tests/security/storage-blocking-strengthened-websql-expected.txt:
- http/tests/storage/callbacks-are-called-in-correct-context-expected.txt:
- inspector/runtime/CommandLineAPI-inspect-expected.txt:
- js/dom/callback-function-with-handle-event-expected.txt:
- js/dom/exceptions-thrown-in-callbacks-expected.txt:
- storage/websql/alter-to-info-table-expected.txt:
- storage/websql/change-version-expected.txt:
- storage/websql/change-version-handle-reuse-expected.txt:
- storage/websql/change-version-no-crash-on-preflight-failure-expected.txt:
- storage/websql/close-during-stress-test-expected.txt:
- storage/websql/database-lock-after-reload-expected.txt:
- storage/websql/empty-statement-expected.txt:
- storage/websql/execute-sql-args-expected.txt:
- storage/websql/execute-sql-rowsAffected-expected.txt:
- storage/websql/executesql-accepts-only-one-statement-expected.txt:
- storage/websql/hash-change-with-xhr-expected.txt:
- storage/websql/multiple-databases-garbage-collection-expected.txt:
- storage/websql/multiple-transactions-expected.txt:
- storage/websql/multiple-transactions-on-different-handles-expected.txt:
- storage/websql/null-callbacks-expected.txt:
- storage/websql/open-database-creation-callback-expected.txt:
- storage/websql/open-database-creation-callback-isolated-world-expected.txt:
- storage/websql/open-database-empty-version-expected.txt:
- storage/websql/open-database-expand-quota-expected.txt:
- storage/websql/open-database-over-quota-expected.txt:
- storage/websql/open-database-set-empty-version-expected.txt:
- storage/websql/open-database-while-transaction-in-progress-expected.txt:
- storage/websql/private-browsing-noread-nowrite-expected.txt:
- storage/websql/read-and-write-transactions-dont-run-together-expected.txt:
- storage/websql/read-transactions-running-concurrently-expected.txt:
- storage/websql/sql-data-types-expected.txt:
- storage/websql/statement-error-callback-expected.txt:
- storage/websql/statement-error-callback-isolated-world-expected.txt:
- storage/websql/statement-success-callback-isolated-world-expected.txt:
- storage/websql/success-callback-expected.txt:
- storage/websql/success-callback-when-page-defers-loading-expected.txt:
- storage/websql/test-authorizer-expected.txt:
- storage/websql/transaction-callback-exception-crash-expected.txt:
- storage/websql/transaction-callback-isolated-world-expected.txt:
- storage/websql/transaction-database-expand-quota-expected.txt:
- storage/websql/transaction-error-callback-expected.txt:
- storage/websql/transaction-error-callback-isolated-world-expected.txt:
- storage/websql/transaction-prototype-expected.txt:
- storage/websql/transaction-success-callback-isolated-world-expected.txt:
- 10:11 AM Changeset in webkit [237590] by
-
- 6 edits3 adds in trunk
IndexedDB: iteration of cursors skip records if updated or deleted
https://bugs.webkit.org/show_bug.cgi?id=190917
<rdar://problem/35250410>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Rebaseline the expectation for test that passes.
- web-platform-tests/IndexedDB/idbcursor-iterating-update-expected.txt:
Source/WebCore:
When object store has changes, we cleared cached records and reset the SQLite statement,
updating the boundary to the next key in cursor's direction. Therefore, the cursor could
jump to the next key after update or deletion.
We should cache those records before changing the statement.
Test: storage/indexeddb/cursor-update-while-iterating.html
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::fetch):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
LayoutTests:
- storage/indexeddb/cursor-update-while-iterating-expected.txt: Added.
- storage/indexeddb/cursor-update-while-iterating.html: Added.
- storage/indexeddb/resources/cursor-update-while-iterating.js: Added.
(prepareDatabase):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
- 7:54 AM Changeset in webkit [237589] by
-
- 2 edits in trunk/Source/WebKit
[CoordGraphics] CoordinatedLayerTreeHost::flushLayersAndForceRepaint() should schedule the flush
https://bugs.webkit.org/show_bug.cgi?id=191066
Reviewed by Michael Catanzaro.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushLayersAndForceRepaint):
Only schedule the layer flush in this call, don't perform it on the
spot. This avoids re-entry of the layer flushing process in cases when
the associated display refresh monitor is requested a callback during
the layout phase that's executed under the initial layer flush.
- 7:29 AM Changeset in webkit [237588] by
-
- 5 edits1 add in trunk/Source/WebCore
[LFC][IFC] Introduce InlineFormattingContextGeometry class
https://bugs.webkit.org/show_bug.cgi?id=191054
Reviewed by Antti Koivisto.
This is in preparation for inline-block support.
Move float and inline-block elements layout to layoutFormattingContextRoot().
computeWidthAndHeightForInlineBox takes care of replaced elements.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeight const): Deleted.
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp: Added.
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):
- 3:23 AM WebKitGTK edited by
- Update link to WebKitGTK/StableRelease (diff)
- 2:30 AM Changeset in webkit [237587] by
-
- 23 edits in trunk
[Web Animations] Implement the update animations and send events procedure
https://bugs.webkit.org/show_bug.cgi?id=191013
<rdar://problem/45620495>
Reviewed by Dean Jackson.
LayoutTests/imported/mozilla:
Progression in a couple of getAnimations() tests for CSS Animations.
- css-animations/test_document-get-animations-expected.txt:
LayoutTests/imported/w3c:
Progressions in a couple of Web Animations Web Platform Tests.
- web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
- web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
Source/WebCore:
While we implemented the various parts of what the Web Animations specification refers to as the "update animations and send events"
procedure, we did not implement it as one function and in the correct order, specifically updating animations and sending events in
two separate tasks. We now have a single method on DocumentTimeline which runs as the DisplayRefreshMonitor fires to update each
"relevant" animation with the current time, perform a microtask checkpoint and dispatch events.
Implementing this procedure allowed us to make several enhancements:
- We introduce the concept of a "relevant" animation, which is essentially an animation that is either pending or playing. All animations
in a different state are no longer owned by the DocumentTimeline and can thus be destroyed if the developer doesn't hold references in JS.
Maintaining such a list guarantees that we're only updating animations that would have changed state since the last time the "update animations
and send events" procedure was run. Note that DeclarativeAnimation instances are also considered to be relevant if they have queued DOM events
to dispatch as they could otherwise be destroyed before they can fully dispatch them.
- We no longer conflate the timing model and effects. Until now the way we would update animations was to go through all elements for which
we had a registered animation, invalidate their style and finally forcing a style update on the document. We had a separate data structure where
we help animations without targets so we update these as well in a separate pass, in order to make sure that promises and events would fire for
them as expected. We now let the "update animations and send events" procedure update the timing of all relevant animations and let individual
animation effects invalidate their style as needed, the document style invalidation happening naturally without DocumentTimeline forcing it.
- We use a single step to schedule the update of animations, which is to register for a display refresh monitor update provided a "relevant"
animation is known since the previous update. Until now we first had an "timing model invalidation" task scheduled upon any change of an animation's
timing model, which would then create a timer to the earliest moment any listed animation would require an update, finally registering a display
refresh monitor update, which used at least GenericTaskQueue<Timer> and potentially two, whereas we use none right now.
- We allow for a display refresh monitor update to be canceled should the number of "relevant" animations since the last update goes back to 0.
To facilitate all of this, we have changed the m_animations ListHashSet to contain only the "relevant" animations, and no longer every animation created
that has this DocumentTimeline set as their "timeline" property. To keep this list current, every single change that changes a given animation's timing
ends up calling AnimationTimeline::animationTimingDidChange() passing the animation as the sole parameter and adding this animation to m_animations. We
immediately schedule a display refresh monitor update if one wasn't already scheduled. Then, when running the "update animations and send events"
procedure, we call a new WebAnimation::tick() method on each of those animations, which updates this animation's effect and relevance, using the newly
computed relevance to identify whether this animation should be kept in the m_animations ListHashSet.
This is only the first step towards a more efficient update and ownership model of animations by the document timeline since animations created as CSS
Animations and CSS Transitions are committed through CSS have dedicated data structures that are not updated in this particular patch, but this will be
addressed in a followup to keep this already significant patch smaller. Another issue that will be addressed later is the ability to not schedule display
refresh monitor udpates when only accelerated animations are running.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationTimingDidChange): Called by animations when any aspect of their timing model changes. The provided animation is then
added to the m_animations list unless its timeline is no longer this timeline.
(WebCore::AnimationTimeline::removeAnimation): Remove the provided animation from m_animations and remove any animation registered on the element-specific
animation lists if this animation has an effect with a target.
(WebCore::AnimationTimeline::animationWasAddedToElement): We no longer need to worry about the m_animationsWithoutTarget data structure since we removed it.
(WebCore::removeCSSTransitionFromMap): Fix a bug where we would remove any CSSTransition in the provided map that had a matching transition-property instead
of checking the CSSTransition registered for this transition-property was indeed the provided CSSTransition. The other code changes in this patch made this
code now cause regressions in the Web Platform Tests.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Stop updating m_animationsWithoutTarget since it no longer exists.
(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Fix a small error that caused a regression in the Web Platform Tests where we could attempt to
call setBackingAnimation() on a nullptr instead of a valid CSSAnimation.
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation):
(WebCore::AnimationTimeline::addAnimation): Deleted.
- animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::hasElementAnimations const): Deleted.
(WebCore::AnimationTimeline:: const): Deleted.
(WebCore::AnimationTimeline::elementToAnimationsMap): Deleted.
(WebCore::AnimationTimeline::elementToCSSAnimationsMap): Deleted.
(WebCore::AnimationTimeline::elementToCSSTransitionsMap): Deleted.
- animation/CSSTransition.cpp:
(WebCore::CSSTransition::canBeListed const): Deleted.
- animation/CSSTransition.h:
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::tick): Call the superclass's method and queue any necessary DOM events reflecting the timing model changes.
(WebCore::DeclarativeAnimation::needsTick const): Call the superclass's method and return true also if we have pending events since otherwise this animation
could be removed from m_animations on its AnimationTimeline and potentially destroyed before the GenericEventQueue had a chance to dispatch all events.
(WebCore::DeclarativeAnimation::startTime const): We removed the custom binding for this IDL property and renamed the method from bindingsStartTime to startTime.
(WebCore::DeclarativeAnimation::setStartTime): We removed the custom binding for this IDL property and renamed the method from setBindingsStartTime to setStartTime.
(WebCore::DeclarativeAnimation::bindingsStartTime const): Deleted.
(WebCore::DeclarativeAnimation::setBindingsStartTime): Deleted.
- animation/DeclarativeAnimation.h:
- animation/DocumentAnimationScheduler.cpp:
(WebCore::DocumentAnimationScheduler::unscheduleWebAnimationsResolution): Add a method to mark that we no longer need a display refresh monitor update for this
document's animation timeline. This is called when m_animations becomes empty.
- animation/DocumentAnimationScheduler.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Stop clearing two task queues and a timer that no longer exist and instead only clear the task queue to clear
the cached current time, which we queue any time we generate a new one (see DocumentTimeline::currentTime).
(WebCore::DocumentTimeline::getAnimations const): Use isRelevant() instead of canBeListed().
(WebCore::DocumentTimeline::updateThrottlingState):
(WebCore::DocumentTimeline::suspendAnimations):
(WebCore::DocumentTimeline::resumeAnimations):
(WebCore::DocumentTimeline::numberOfActiveAnimationsForTesting const):
(WebCore::DocumentTimeline::currentTime): Queue a task in the new m_currentTimeClearingTaskQueue task queue to clear the current time that we've generated and cached
in the next run loop (provided all pending JS execution has also completed).
(WebCore::DocumentTimeline::maybeClearCachedCurrentTime):
(WebCore::DocumentTimeline::scheduleAnimationResolutionIfNeeded): Schedule a display refresh monitor update if we are not suspended and have "relevant" animations.
(WebCore::DocumentTimeline::animationTimingDidChange): Call scheduleAnimationResolutionIfNeeded() after calling the superclass's implementation.
(WebCore::DocumentTimeline::removeAnimation): Call unscheduleAnimationResolution() if the list of "relevant" animations is now empty.
(WebCore::DocumentTimeline::unscheduleAnimationResolution): Unschedule a pending display refresh monitor update.
(WebCore::DocumentTimeline::animationResolutionTimerFired):
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Implement the "update animations and send events" procedure as specified by the Web Animations spec.
During this procedure, we call tick() on all animations listed in m_animations and create a list of animations to remove from that list if this animation is no
longer relevant following the call to tick().
(WebCore::DocumentTimeline::enqueueAnimationPlaybackEvent):
(WebCore::DocumentTimeline::timingModelDidChange): Deleted.
(WebCore::DocumentTimeline::scheduleInvalidationTaskIfNeeded): Deleted.
(WebCore::DocumentTimeline::performInvalidationTask): Deleted.
(WebCore::DocumentTimeline::updateAnimationSchedule): Deleted.
(WebCore::DocumentTimeline::animationScheduleTimerFired): Deleted.
(WebCore::DocumentTimeline::updateAnimations): Deleted.
(WebCore::compareAnimationPlaybackEvents): Deleted.
(WebCore::DocumentTimeline::performEventDispatchTask): Deleted.
- animation/DocumentTimeline.h:
- animation/WebAnimation.cpp: The majority of the changes to this class is that we call the new timingDidChange() method when any code that modifies the timing model
is run. We also remove methods to set the pending play and pause tasks as well as the animation's start time and hold time since any time we're changing these instance
variables, we later already have a call to update the timing model and we were doing more work than needed. As a result we no longer need an internal method to set the
start time and can stop requiring a custom IDL binding for the "startTime" property.
(WebCore::WebAnimation::effectTimingPropertiesDidChange):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::startTime const):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::silentlySetCurrentTime):
(WebCore::WebAnimation::setCurrentTime):
(WebCore::WebAnimation::setPlaybackRate):
(WebCore::WebAnimation::cancel):
(WebCore::WebAnimation::resetPendingTasks):
(WebCore::WebAnimation::finish):
(WebCore::WebAnimation::timingDidChange): New method called any time a timing property changed where we run the "update the finished state" procedure and notify the
animation's timeline that its timing changed so that it can be considered the next time the "update animations and send events" procedure runs.
(WebCore::WebAnimation::invalidateEffect):
(WebCore::WebAnimation::updateFinishedState): Update the animation's relevance after running the procedure as specified.
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::pause):
(WebCore::WebAnimation::runPendingPauseTask):
(WebCore::WebAnimation::needsTick const):
(WebCore::WebAnimation::tick): New method called during the "update animations and send events" procedure where we run the "update the finished state" procedure and run
the pending play and pause tasks.
(WebCore::WebAnimation::resolve):
(WebCore::WebAnimation::updateRelevance):
(WebCore::WebAnimation::computeRelevance):
(WebCore::WebAnimation::timingModelDidChange): Deleted.
(WebCore::WebAnimation::setHoldTime): Deleted.
(WebCore::WebAnimation::bindingsStartTime const): Deleted.
(WebCore::WebAnimation::setBindingsStartTime): Deleted.
(WebCore::WebAnimation::setTimeToRunPendingPlayTask): Deleted.
(WebCore::WebAnimation::setTimeToRunPendingPauseTask): Deleted.
(WebCore::WebAnimation::updatePendingTasks): Deleted.
(WebCore::WebAnimation::timeToNextRequiredTick const): Deleted.
(WebCore::WebAnimation::runPendingTasks): Deleted.
(WebCore::WebAnimation::canBeListed const): Deleted.
- animation/WebAnimation.h:
(WebCore::WebAnimation::isRelevant const):
(WebCore::WebAnimation::hasPendingPlayTask const):
(WebCore::WebAnimation::isEffectInvalidationSuspended):
- animation/WebAnimation.idl:
- dom/Element.cpp:
(WebCore::Element::getAnimations): Use isRelevant() instead of canBeListed().
LayoutTests:
Several tests that broke when turning Web Animations CSS Integration on by default are now passing. In the case of one test, we had to ensure
that the final animation frame had been committed before terminating the test or there would be a tiny image reference issue.
- TestExpectations:
- fast/layers/no-clipping-overflow-hidden-added-after-transform.html:
- 2:00 AM Changeset in webkit [237586] by
-
- 3 edits in trunk/Source/JavaScriptCore
"Unreviewed, partial rolling in r237254"
https://bugs.webkit.org/show_bug.cgi?id=190340
This only adds Parser.{cpp,h}. And it is not used in this patch.
It examines that the regression is related to exact Parser changes.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
- parser/Parser.h:
(JSC::Parser<LexerType>::parse):
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):
- 1:59 AM Changeset in webkit [237585] by
-
- 5 edits in trunk
LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
https://bugs.webkit.org/show_bug.cgi?id=191026
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated test.
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
(WebCore::LibWebRTCRtpReceiverBackend::getSynchronizationSources const):
LayoutTests:
- webrtc/video-addTransceiver-expected.txt:
- webrtc/video-addTransceiver.html:
- 1:26 AM Changeset in webkit [237584] by
-
- 4 edits in trunk
[GTK][WPE] Fixes to the PublicSuffix implementation
https://bugs.webkit.org/show_bug.cgi?id=191031
Reviewed by Michael Catanzaro.
Source/WebCore:
Covered by existing tests.
Downcase hostnames before passing it on to the underlying
libsoup API. Special case localhost and fix a mixed-up
libsoup GError checks. This fixes most of the failures.
- platform/soup/PublicSuffixSoup.cpp:
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):
Tools:
- TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
(TestWebKitAPI::TEST_F): Remove a test for a domain
that is not registrable and shouldn't be tested there.
Oct 29, 2018:
- 10:52 PM Changeset in webkit [237583] by
-
- 3 edits1 add in tags/Safari-607.1.10.6/Source/JavaScriptCore
Cherry-pick r237575. rdar://problem/45169447
JSC should explicitly list its modulemap file
https://bugs.webkit.org/show_bug.cgi?id=191032
Reviewed by Saam Barati.
The automagically generated module map file for JSC will
include headers where they may not work out of the box.
This patch makes it so we now export the same modulemap
that used to be provided via the legacy system.
- Configurations/JavaScriptCore.xcconfig:
- JavaScriptCore.modulemap: Added.
- JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:52 PM Changeset in webkit [237582] by
-
- 2 edits in tags/Safari-607.1.10.6/Source/JavaScriptCore
Cherry-pick r237462. rdar://problem/45169447
JSC xcconfig should set DEFINES_MODULE
https://bugs.webkit.org/show_bug.cgi?id=190952
Reviewed by Mark Lam.
This should mean that the JavaScriptCore.framework will have a module map.
- Configurations/JavaScriptCore.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:10 PM Changeset in webkit [237581] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed, change my status to be a WebKit reviewer.
- Scripts/webkitpy/common/config/contributors.json:
- 9:00 PM Changeset in webkit [237580] by
-
- 2 edits in trunk/Source/WebCore
Missing from r237549
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::hasPrecomputedMarginTop):
- 8:35 PM Changeset in webkit [237579] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative build fix for AppleWin after r237559.
- PlatformAppleWin.cmake:
- 8:26 PM Changeset in webkit [237578] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Flash views with red outline on initial layout
https://bugs.webkit.org/show_bug.cgi?id=191048
Reviewed by Devin Rousso.
- UserInterface/Views/View.js:
(WI.View.prototype._layoutSubtree):
(WI.View.prototype._drawLayoutFlashingOutline):
- 7:58 PM Changeset in webkit [237577] by
-
- 21 edits1 add in trunk
Correctly detect string overflow when using the 'Function' constructor.
https://bugs.webkit.org/show_bug.cgi?id=184883
<rdar://problem/36320331>
Reviewed by Saam Barati.
JSTests:
I've verified that this passes on 32-bit as well.
- slowMicrobenchmarks/function-constructor-with-huge-strings.js: Added.
Source/bmalloc:
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::reallocate):
(bmalloc::Allocator::tryReallocate):
(bmalloc::Allocator::reallocateImpl):
- bmalloc/Allocator.h:
- bmalloc/Cache.h:
(bmalloc::Cache::tryReallocate):
- bmalloc/DebugHeap.cpp:
(bmalloc::DebugHeap::realloc):
- bmalloc/DebugHeap.h:
- bmalloc/bmalloc.h:
(bmalloc::api::tryRealloc):
Source/JavaScriptCore:
Added StringBuilder::hasOverflowed() checks, and throwing OutOfMemoryErrors if
we detect an overflow.
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
- runtime/JSONObject.cpp:
(JSC::Stringifier::stringify):
(JSC::Stringifier::appendStringifiedValue):
Source/WTF:
- Enhanced StringBuilder so that it supports 2 modes of behavior:
- StringBuilder::OverflowHandler::CrashOnOverflow.
- StringBuilder::OverflowHandler::RecordOverflow.
CrashOnOverflow will crash the moment an overflow or failure to allocate
memory is detected.
RecordOverflow will make StringBuilder::hasOverflowed() return true when an
overflow or failure to allocate memory is detected. However, if the user
invokes toString(), toStringPreserveCapacity(), toAtomicString(), length(),
capacity(), isEmpty(), characters8(), or characters16(), then the StringBuilder
will crash regardless because these methods can only meaningfully do their
work and return a result if and only if the builder has not overflowed.
By default, the StringBuilder crashes on overflow (the old behavior) unless it
is explicitly constructed with the StringBuilder::OverflowHandler::RecordOverflow
enum.
Design note:
The StringBuilder can only be put in 1 of the 2 modes at the time of
construction. This means that we could have implemented it as a template
that is parameterized on an OverflowHandler class (like CheckedArithmetic)
instead of using a runtime check in the ConditionalCrashOnOverflow handler.
However, I was not able to get clang to export the explicitly instantiated
instances (despite the methods having being decorated with WTF_EXPORT_PRIVATE).
Since the StringBuilder is a transient object (not stored for a long time on
the heap), and the runtime check of the boolean is not that costly compared
to other work that StringBuilder routinely does (e.g. memcpy), using the
new ConditionalCrashOnOverflow (which does a runtime check to determine to
crash or not on overflow) is fine.
When clang is able to export explicitly instantiated template methods, we can
templatize StringBuilder and do away with ConditionalCrashOnOverflow.
See https://bugs.webkit.org/show_bug.cgi?id=191050.
To support the above, we also did:
- Enhanced all StringBuilder append and buffer allocation methods to be able to fail without crashing. This also meant that ...
- Added tryReallocate() support to StringImpl. tryRealloc() was added to FastMalloc, and bmalloc (and related peers) to enable this.
- Added ConditionalCrashOnOverflow, which can choose at runtime whether to behave like CrashOnOverflow or RecordOverflow.
- wtf/CheckedArithmetic.h:
(WTF::ConditionalCrashOnOverflow::overflowed):
(WTF::ConditionalCrashOnOverflow::shouldCrashOnOverflow const):
(WTF::ConditionalCrashOnOverflow::setShouldCrashOnOverflow):
(WTF::ConditionalCrashOnOverflow::hasOverflowed const):
(WTF::ConditionalCrashOnOverflow::clearOverflow):
(WTF::ConditionalCrashOnOverflow::crash):
(WTF::RecordOverflow::overflowed):
(WTF::Checked::unsafeGet const):
- wtf/FastMalloc.cpp:
(WTF::tryFastRealloc):
- wtf/FastMalloc.h:
- wtf/text/StringBuilder.cpp:
(WTF::expandedCapacity):
(WTF::StringBuilder::reifyString const):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::StringBuilder::reallocateBuffer<LChar>):
(WTF::StringBuilder::reallocateBuffer<UChar>):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::canShrink const):
(WTF::StringBuilder::shrinkToFit):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::didOverflow):
(WTF::StringBuilder::hasOverflowed const):
(WTF::StringBuilder::crashesOnOverflow const):
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity const):
(WTF::StringBuilder::toAtomicString const):
(WTF::StringBuilder::length const):
(WTF::StringBuilder::capacity const):
(WTF::StringBuilder::operator[] const):
(WTF::StringBuilder::swap):
(WTF::StringBuilder::getBufferCharacters<UChar>):
- wtf/text/StringBuilderJSON.cpp:
(WTF::StringBuilder::appendQuotedJSONString):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::tryReallocate):
- wtf/text/StringImpl.h:
- 7:51 PM Changeset in webkit [237576] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix JSC on arm64e after r237547
https://bugs.webkit.org/show_bug.cgi?id=187373
Unreviewed.
Remove unused move guarded by POINTER_PROFILING that was trashing the
metadata on arm64e.
- llint/LowLevelInterpreter64.asm:
- 5:14 PM Changeset in webkit [237575] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
JSC should explicitly list its modulemap file
https://bugs.webkit.org/show_bug.cgi?id=191032
Reviewed by Saam Barati.
The automagically generated module map file for JSC will
include headers where they may not work out of the box.
This patch makes it so we now export the same modulemap
that used to be provided via the legacy system.
- Configurations/JavaScriptCore.xcconfig:
- JavaScriptCore.modulemap: Added.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 5:10 PM Changeset in webkit [237574] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas: show warning when path moves offscreen
https://bugs.webkit.org/show_bug.cgi?id=191016
Reviewed by Joseph Pecoraro.
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction):
(WI.RecordingAction.deriveCurrentState):
(WI.RecordingAction.prototype.get isVisual):
(WI.RecordingAction.prototype.get warning): Added.
(WI.RecordingAction.prototype.process.checkInvalidCurrentAxisPoint): Added.
(WI.RecordingAction.prototype.process):
(WI.RecordingAction.prototype.get hasVisibleEffect): Deleted.
ReplacehasVisibleEffectwith a more generalwarningvalue, so that it can be used for
more types of warnings.
- UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement.prototype.onattach):
- UserInterface/Views/RecordingActionTreeElement.css:
(.item.action.visual.warning:not(.invalid) > .status > .warning): Added.
(.item.action.visual.no-visible-effect:not(.invalid) > .status > .warning): Deleted.
- Localizations/en.lproj/localizedStrings.js:
- 4:49 PM Changeset in webkit [237573] by
-
- 2 edits in trunk/Source/WebKit
Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.
https://bugs.webkit.org/show_bug.cgi?id=191049
Patch by Dewei Zhu <Dewei Zhu> on 2018-10-29
Reviewed by Chris Dumez.
Move 'ProcessSwapOnCrossSiteNavigationEnabled' from 'internal' to 'experimental' category.
- Shared/WebPreferences.yaml:
- 4:29 PM Changeset in webkit [237572] by
-
- 1 copy in tags/Safari-606.3.4
Tag Safari-606.3.4.
- 4:29 PM Changeset in webkit [237571] by
-
- 14 edits in trunk
Web Inspector: refactor code for getting properties via WI.RemoteObject
https://bugs.webkit.org/show_bug.cgi?id=190989
Reviewed by Matt Baker.
Source/WebInspectorUI:
- UserInterface/Protocol/RemoteObject.js:
(WI.RemoteObject.prototype.getPropertyDescriptors): Added.
(WI.RemoteObject.prototype.getPropertyDescriptorsAsObject): Added.
(WI.RemoteObject.prototype.getOwnPropertyDescriptors): Deleted.
(WI.RemoteObject.prototype.getAllPropertyDescriptors): Deleted.
(WI.RemoteObject.prototype._getPropertyDescriptors): Deleted.
(WI.RemoteObject.prototype.getOwnPropertyDescriptorsAsObject): Deleted.
- UserInterface/Views/ErrorObjectView.js:
(WI.ErrorObjectView.prototype.update):
- UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WI.ObjectTreePropertyTreeElement.prototype._updateChildren):
- UserInterface/Views/ObjectTreeView.js:
(WI.ObjectTreeView.prototype.update):
LayoutTests:
- http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html:
- inspector/debugger/breakpoint-scope.html:
- inspector/debugger/paused-scopes.html:
- inspector/debugger/tail-deleted-frames-from-vm-entry.html:
- inspector/debugger/tail-deleted-frames.html:
- inspector/debugger/tail-recursion.html:
- inspector/model/remote-object-fake-object.html:
- inspector/model/remote-object-get-properties.html:
- 2:48 PM Changeset in webkit [237570] by
-
- 34 edits6 deletes in trunk
Revert r237347 registered custom properties... https://bugs.webkit.org/show_bug.cgi?id=190039
https://bugs.webkit.org/show_bug.cgi?id=190919
Patch by Justin Michaud <Justin Michaud> on 2018-10-29
Reviewed by Michael Saboff.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
- web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
- web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt:
- web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt:
- web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles-expected.txt:
- web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):
- css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
(WebCore::CSSCustomPropertyValue::checkVariablesForCycles const):
(WebCore::CSSCustomPropertyValue::resolveVariableReferences const):
(WebCore::CSSCustomPropertyValue::setResolvedTypedValue):
(WebCore::CSSCustomPropertyValue::equals const): Deleted.
- css/CSSCustomPropertyValue.h:
- css/CSSRegisteredCustomProperty.cpp:
(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty):
- css/CSSRegisteredCustomProperty.h:
- css/CSSVariableData.cpp:
(WebCore::CSSVariableData::consumeAndUpdateTokens):
(WebCore::CSSVariableData::CSSVariableData):
(WebCore::CSSVariableData::checkVariablesForCycles const):
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const):
(WebCore::CSSVariableData::resolveVariableFallback const):
(WebCore::CSSVariableData::resolveVariableReference const):
(WebCore::CSSVariableData::resolveVariableReferences const):
(WebCore::CSSVariableData::resolveTokenRange const):
- css/CSSVariableData.h:
(WebCore::CSSVariableData::create):
(WebCore::CSSVariableData::createResolved):
(WebCore::CSSVariableData::needsVariableResolution const):
(WebCore::CSSVariableData::CSSVariableData):
- css/CSSVariableReferenceValue.cpp:
(WebCore::CSSVariableReferenceValue::checkVariablesForCycles const):
(WebCore::resolveVariableFallback): Deleted.
(WebCore::resolveVariableReference): Deleted.
(WebCore::resolveTokenRange): Deleted.
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const): Deleted.
- css/CSSVariableReferenceValue.h:
(WebCore::CSSVariableReferenceValue::create):
(WebCore::CSSVariableReferenceValue::variableDataValue const):
(WebCore::CSSVariableReferenceValue::equals const):
- css/DOMCSSRegisterCustomProperty.cpp:
(WebCore::DOMCSSRegisterCustomProperty::registerProperty):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialCustomProperty):
(WebCore::StyleBuilderCustom::applyValueCustomProperty):
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setCustomProperty):
- css/StyleProperties.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedProperties):
(WebCore::StyleResolver::applyCascadedCustomProperty): Deleted.
- css/StyleResolver.h:
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences):
- css/parser/CSSParser.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::CSSPropertyParser):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue): Deleted.
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): Deleted.
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies): Deleted.
- css/parser/CSSPropertyParser.h:
- css/parser/CSSVariableParser.cpp:
(WebCore::CSSVariableParser::parseDeclarationValue):
- dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::checkVariablesInCustomProperties):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):
- rendering/style/StyleCustomPropertyData.h:
(WebCore::StyleCustomPropertyData::operator== const):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
LayoutTests:
- css-custom-properties-api/crash-expected.txt: Removed.
- css-custom-properties-api/crash.html: Removed.
- css-custom-properties-api/cycles-expected.txt: Removed.
- css-custom-properties-api/cycles.html: Removed.
- css-custom-properties-api/inline-expected.txt: Removed.
- css-custom-properties-api/inline.html: Removed.
- 2:41 PM Changeset in webkit [237569] by
-
- 2 edits in trunk/LayoutTests
Marked http/tests/misc/large-js-program.php as a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=190724
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:31 PM Changeset in webkit [237568] by
-
- 23 edits in trunk
Handle MDNS resolution of candidates through libwebrtc directly
https://bugs.webkit.org/show_bug.cgi?id=190681
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
Source/WebCore:
Remove the previous MDNS resolution mechanism.
Instead, add support for the AsyncResolver mechanism added to libwebrtc.
Covered by current mdns webrtc test that is unflaked.
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::addIceCandidate):
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::createPeerConnection):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):
- testing/MockLibWebRTCPeerConnection.h:
Source/WebKit:
Add support for AsyncResolver to resolve MDNS.
This basically reuse the code path used to resolve STUN server addresses.
Removed MDNS specific resolution.
Use existing CFHost resolution mechanism to do the actual resolution.
Make sure that a resolver is kept alive while iterating through its clients when signaling done.
Some of its clients may indeed call Destroy() on the resolver during that iteration.
- NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):
- NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
- WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCResolver::Destroy):
(WebKit::LibWebRTCResolver::doDestroy):
(WebKit::LibWebRTCResolver::setResolvedAddress):
(WebKit::LibWebRTCResolver::setError):
(WebKit::LibWebRTCProvider::createPeerConnection):
- WebProcess/Network/webrtc/LibWebRTCProvider.h:
- WebProcess/Network/webrtc/LibWebRTCSocketFactory.h:
- WebProcess/Network/webrtc/WebMDNSRegister.cpp:
- WebProcess/Network/webrtc/WebMDNSRegister.h:
- WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
LayoutTests:
Test should no longer be flaky as we no longer enforce a timer for resolving MDNS candidates.
- 2:27 PM Changeset in webkit [237567] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: increase size limits for NetworkResourceData
https://bugs.webkit.org/show_bug.cgi?id=191034
<rdar://problem/45529852>
Reviewed by Joseph Pecoraro.
No tests since no new functionality.
- inspector/NetworkResourcesData.cpp:
All resources: 100MB => 200MB
Each resource: 10MB => 50MB
- 2:22 PM Changeset in webkit [237566] by
-
- 30 edits5 copies6 adds4 deletes in trunk
Modernize WebKit nibs and lprojs for localization's sake
https://bugs.webkit.org/show_bug.cgi?id=190911
<rdar://problem/45349466>
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
English->en
Source/WebCore:
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- PlatformWin.cmake:
- WebCore.xcodeproj/project.pbxproj:
- en.lproj/Localizable.strings: Renamed from Source/WebCore/English.lproj/Localizable.strings.
- en.lproj/Localizable.stringsdict: Renamed from Source/WebCore/English.lproj/Localizable.stringsdict.
- en.lproj/mediaControlsLocalizedStrings.js: Renamed from Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js.
- en.lproj/modern-media-controls-localized-strings.js: Renamed from Source/WebCore/English.lproj/modern-media-controls-localized-strings.js.
English->en
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
English->en
Source/WebInspectorUI:
- WebInspectorUI.xcodeproj/project.pbxproj:
English->en
Source/WebKit:
- Resources/WebContentProcess.xib:
- WebKit.xcodeproj/project.pbxproj:
- en.lproj/InfoPlist.strings: Renamed from Source/WebKit/English.lproj/InfoPlist.strings.
English->en
Source/WebKitLegacy:
- English.lproj/WebJavaScriptTextInputPanel.nib/designable.nib: Removed.
- English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib: Removed.
- WebKitLegacy.xcodeproj/project.pbxproj:
- en.lproj/WebJavaScriptTextInputPanel.xib: Added.
NIB->XIB, English->en
Source/WebKitLegacy/mac:
- Misc/WebNSControlExtras.m:
(-[NSControl sizeToFitAndAdjustWindowHeight]):
NSWindow and its contents are both in the same scale space these days; avoid
double-applying the scale factor, or you can't see the prompt.
- Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
- Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
- Panels/en.lproj/WebAuthenticationPanel.xib: Added.
NIB->XIB
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
English->en
Tools:
- Scripts/check-inspector-strings:
- Scripts/update-webkit-localizable-strings:
- gtk/manifest.txt.in:
- wpe/manifest.txt.in:
English->en
LayoutTests:
- media/modern-media-controls/localized-strings/replaced-string.html:
English->en
- 2:21 PM Changeset in webkit [237565] by
-
- 6 edits in trunk/Source
Make FindOptionsShowOverlay work on iOS
https://bugs.webkit.org/show_bug.cgi?id=190551
Reviewed by Andy Estes.
Source/WebCore:
- platform/graphics/GraphicsContext.h:
Export some more GraphicsContext methods.
Source/WebKit:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
Update the find indicator after installing the page overlay for the find holes.
This ensures that if the find indicator mechanism also uses page overlays,
as it does on iOS, that they are installed in the correct order (because
order of installation directly affects z-order).
(WebKit::FindController::findIndicatorRadius const):
(WebKit::FindController::shouldHideFindIndicatorOnScroll const):
Add two getters for design differences between find-in-page on iOS vs. other platforms.
(WebKit::FindController::rectsForTextMatchesInRect):
Return FloatRects instead of IntRects for ease of use in the caller.
Don't clip rects for matches that intersect the current tile. We still
drop ones that don't intersect at all, but if they do intersect, we
provide the full rect (which may overlap a different tile), so that
e.g. border drawing will work correctly.
(WebKit::FindController::drawRect):
Adopt shrink-wrapping for find holes. This has minimal impact on macOS,
where the holes don't have rounded corners, but on iOS this makes
overlapping or adjacent holes look great. We already do this for the indicator,
so it only makes sense to do the same for the holes.
In order to support shrink-wrapping here, switch to using a Clear operator
with a path-fill instead of clearRect to clear out the holes.
Avoid hiding the find indicator on scroll if the platform says not to.
- WebProcess/WebPage/FindController.h:
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::findIndicatorRadius const):
(WebKit::FindController::shouldHideFindIndicatorOnScroll const):
Slightly adjust the find indicator's parameters to be compatible with having holes.
Reduce the horizontal margin by half a point so that it fits precisely in the hole.
Drop the "TightlyFitContent" text indicator parameter, because we want
rects that match the holes, and they do not tightly fit the content's height.
This matches macOS's behavior.
- 1:57 PM Changeset in webkit [237564] by
-
- 4 edits in trunk/Tools
[lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
https://bugs.webkit.org/show_bug.cgi?id=191036
Reviewed by Andy Estes.
Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
by an enum that contains two or more enumerators with the same value. For example, suppose
you have the following enum:
enum Flag {
A = 1 << 0,
AAlias = A,
};
Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
tend to be used in bounds checks as opposed to code that adds to a set.
- lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
- lldb/lldb_webkit.py:
(WTFOptionSetProvider.update):
- lldb/lldb_webkit_unittest.py:
(TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
(TestSummaryProviders):
(TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
- 1:55 PM Changeset in webkit [237563] by
-
- 2 edits in trunk/Tools
[llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=191033
Reviewed by Andy Estes.
For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
We display the same details in the summary for a Frame because its Document tends to be the most
interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
and whether the origin has universal access.
- lldb/lldb_webkit.py:
(lldb_init_module):
Register new summary providers.
(WebCoreSecurityOrigin_SummaryProvider):
(WebCoreFrame_SummaryProvider):
(WebCoreDocument_SummaryProvider):
Add new summary providers.
(StdOptionalWrapper):
(StdOptionalWrapper.init):
(StdOptionalWrapper.has_value):
(StdOptionalWrapper.value):
Convenience data type that provides access to the fields of a std::optional<>.
(WebCoreSecurityOriginProvider):
(WebCoreSecurityOriginProvider.init):
(WebCoreSecurityOriginProvider.is_unique):
(WebCoreSecurityOriginProvider.scheme):
(WebCoreSecurityOriginProvider.host):
(WebCoreSecurityOriginProvider.port):
(WebCoreSecurityOriginProvider.domain):
(WebCoreSecurityOriginProvider.has_universal_access):
(WebCoreSecurityOriginProvider.to_string):
(WebCoreFrameProvider):
(WebCoreFrameProvider.init):
(WebCoreFrameProvider.is_main_frame):
(WebCoreFrameProvider.document):
(WebCoreDocumentProvider):
(WebCoreDocumentProvider.init):
(WebCoreDocumentProvider.url):
(WebCoreDocumentProvider.origin):
(WebCoreDocumentProvider.page_cache_state):
(WebCoreDocumentProvider.frame):
- 1:34 PM Changeset in webkit [237562] by
-
- 15 edits in branches/safari-606-branch/Source
Apply patch. rdar://problem/45363479
- 1:10 PM Changeset in webkit [237561] by
-
- 6 edits in trunk
Invalid ssrc value in the stats of type 'inbound-rtp'
https://bugs.webkit.org/show_bug.cgi?id=190826
<rdar://problem/45487435>
Reviewed by Eric Carlson.
Source/WebCore:
Value was not initialized in WebCore if missing from libwebrtc.
Change value to an optional so that it will not appear if libwebrtc does not expose it.
Move integer/boolean values from being initialized to be optional so
that we do not expose them to JS if not exposed by libwebrtc.
Covered by updated tests.
- Modules/mediastream/RTCStatsReport.h:
LayoutTests:
- webrtc/video-mediastreamtrack-stats.html:
- webrtc/video-stats-expected.txt:
- webrtc/video-stats.html:
- 12:13 PM Changeset in webkit [237560] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: prevent Canvas tab from listening for "space" when not visibile
https://bugs.webkit.org/show_bug.cgi?id=190988
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.shown):
(WI.CanvasTabContentView.prototype.hidden): Added.
- 12:08 PM Changeset in webkit [237559] by
-
- 8 edits2 adds in trunk/Source
CRASH in CoreGraphics: ERROR_CGDataProvider_BufferIsNotBigEnough
https://bugs.webkit.org/show_bug.cgi?id=190954
Reviewed by Simon Fraser.
Source/WebCore:
Crash analyitics show that WebProcess will crash in ERROR_CGDataProvider_BufferIsNotBigEnough,
which attempts to fetch the last byte in the image buffer in order to verify that the entire
buffer is readable. Unfortunately, the stack trace generated by this crash does not identify
what CGDataProvider is responsible for the not-big-enough buffer. In order to identify which
CGDataProvider created by WebKit is responsible (if any), we will add our own version of
ERROR_CGDataProvider_BufferIsNotBigEnough, called at CGDataProvider creation time, which should
generate a crash within the responsible stack frame.
(This assumes that the issue is the wrong sized buffer at CGDataProvider creation time, and not
that the buffer itself is reclaimed between creation time and access.)
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::toCFData const):
(WebCore::cfData):
- platform/graphics/cocoa/WebGLLayer.mm:
(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
- platform/graphics/cv/PixelBufferConformerCV.cpp:
(WebCore::CVPixelBufferGetBytePointerCallback):
(WebCore::PixelBufferConformerCV::createImageFromPixelBuffer):
- platform/graphics/cg/ImageUtilitiesCG.h: Added.
(WebCore::verifyImageBufferIsBigEnough):
Source/WebKit:
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::makeCGImage):
- 11:40 AM Changeset in webkit [237558] by
-
- 9 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r237492.
https://bugs.webkit.org/show_bug.cgi?id=191035
"It regresses JetStream 2 by 5% on some iOS devices"
(Requested by saamyjoon on #webkit).
Reverted changeset:
"Unreviewed, partial rolling in r237254"
https://bugs.webkit.org/show_bug.cgi?id=190340
https://trac.webkit.org/changeset/237492
- 10:53 AM Changeset in webkit [237557] by
-
- 2 edits in trunk/Source/WebCore
Fix clang static analyzer warning in StyleBuilderConverter.h
<https://webkit.org/b/190907>
Reviewed by Antti Koivisto.
Fix the following clang static warning in StyleBuilderConverter.h:
Value stored to 'autoFlow' during its initialization is never read
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertGridAutoFlow): Move
assignment of RenderStyle::initialGridAutoFlow() todefault
case. MakeCSSValueDenseconsistent with other cases by
assigning value toautoFlowinstead of returning early.
- 10:09 AM Changeset in webkit [237556] by
-
- 4 edits in trunk/LayoutTests
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=191002
Make expectations for IntersectionObserver WPTs more specific.
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 9:26 AM Changeset in webkit [237555] by
-
- 5 edits in trunk/Source
Guard H264 simulcast with a runtime flag
https://bugs.webkit.org/show_bug.cgi?id=191025
Reviewed by Eric Carlson.
Source/WebCore:
Add a runtime flag for H264 simulcast and enable libwebrtc field trial based on it.
Covered by existing test.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webRTCH264SimulcastEnabled const):
(WebCore::RuntimeEnabledFeatures::setWebRTCH264SimulcastEnabled):
Source/WebKit:
- Shared/WebPreferences.yaml:
- 8:48 AM Changeset in webkit [237554] by
-
- 4 edits in trunk
[PSON] When Safari restores session state after launching, going back and forward does not swap processes
https://bugs.webkit.org/show_bug.cgi?id=190975
<rdar://problem/45059256>
Reviewed by Antti Koivisto.
Source/WebKit:
When deciding to process-swap or not on a history navigation, we normally check the BackForwardListItems'
process identifiers do check if they come from different WebProcesses or not. However, the check was invalid
in the case where the BackForwardListItems were restored by the client. After a session restore, the
items' process identifier is the UIProcess one. Therefore, we need to disable the BackForwardListItems'
process identifiers check if if the process identifier is the one of the UIProcess.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 8:46 AM Changeset in webkit [237553] by
-
- 3 edits1 add in trunk
Add support for GetStack FlushedDouble
https://bugs.webkit.org/show_bug.cgi?id=191012
<rdar://problem/45265141>
Reviewed by Saam Barati.
JSTests:
- stress/get-stack-double.js: Added.
(bar):
(noInline):
Source/JavaScriptCore:
LowerDFGToB3::compileGetStack assumed that we would not emit GetStack
for doubles, but it turns out it may arise from the PutStack sinking
phase: if we sink a PutStack into a successor block, other predecessors
will emit a GetStack followed by a Upsilon.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):
- 7:53 AM Changeset in webkit [237552] by
-
- 6 edits2 adds in trunk
[LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
https://bugs.webkit.org/show_bug.cgi?id=191018
Reviewed by Antti Koivisto.
Source/WebCore:
<div><img style="float: left"></div>
This inline formatting context (root -> div) inherits the floating context from the parent block formatting context.
Floats are added to the floating context relative to the floating context's root. In order to position this float properly we
need to precompute the ancestor's margin top (stop at the block formatting root boundary).
Test: fast/inline/simple-intruding-floats3.html
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/inline/simple-intruding-floats3-expected.txt: Added.
- fast/inline/simple-intruding-floats3.html: Added.
- platform/ios/TestExpectations:
- 7:48 AM Changeset in webkit [237551] by
-
- 8 edits2 adds in trunk
[LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
https://bugs.webkit.org/show_bug.cgi?id=191011
Reviewed by Antti Koivisto.
Source/WebCore:
10.6.3 Block-level non-replaced elements in normal flow when 'overflow' computes to 'visible'
Height is the bottom edge of the last line box, if the box establishes a inline formatting context with one or more lines
This is temporary until after inline runs transition to the display tree.
Test: fast/inline/simple-intruding-floats2.html
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/inlineformatting/InlineRun.h:
(WebCore::Layout::InlineRun::logicalLeft const):
(WebCore::Layout::InlineRun::logicalRight const):
(WebCore::Layout::InlineRun::logicalTop const):
(WebCore::Layout::InlineRun::logicalBottom const):
(WebCore::Layout::InlineRun::width const):
(WebCore::Layout::InlineRun::height const):
(WebCore::Layout::InlineRun::setWidth):
(WebCore::Layout::InlineRun::setLogicalLeft):
(WebCore::Layout::InlineRun::setLogicalRight):
(WebCore::Layout::InlineRun::moveHorizontally):
(WebCore::Layout::InlineRun::InlineRun):
- layout/inlineformatting/Line.cpp:
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/inline/simple-intruding-floats2-expected.txt: Added.
- fast/inline/simple-intruding-floats2.html: Added.
- platform/ios/TestExpectations:
- 7:44 AM Changeset in webkit [237550] by
-
- 4 edits in trunk
Missing from r237549
Reviewed by Antti Koivisto.
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- platform/ios/TestExpectations:
- 7:35 AM Changeset in webkit [237549] by
-
- 6 edits2 adds in trunk
[LFC][IFC] Add support for simple intruding floats.
https://bugs.webkit.org/show_bug.cgi?id=190998
Reviewed by Antti Koivisto.
Source/WebCore:
In order to be able to figure out whether a float is intruding on a line, we need to provide the line's final vertical position.
This vertical position must be in the same coordinate system as the float's position is. In case of intruding float,
it is the parent block formatting root's coordinate system (that's where the float lives.)
Test: fast/inline/simple-intruding-float1.html
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::constraints const):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/inline/simple-intruding-float1-expected.txt: Added.
- fast/inline/simple-intruding-float1.html: Added.
- platform/ios/TestExpectations:
- 7:19 AM Changeset in webkit [237548] by
-
- 7 edits2 adds in trunk
[LFC][IFC] Inline layout produces separate runs when float is present.
https://bugs.webkit.org/show_bug.cgi?id=190980
Reviewed by Antti Koivisto.
Source/WebCore:
<div>foo<img src="foobar.jpg" style="float: left">bar</div> produces 2 inline boxes (foo) and (bar) -> current inline code
while it is really just one continuous run (foobar) -> LFC
Adjust verification code to check for such runs.
- layout/Verification.cpp:
(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
- layout/inlineformatting/InlineRun.h:
(WebCore::Layout::InlineRun::textContext const):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
- fast/block/basic/inline-content-with-floating-images2.html: Added.
- platform/ios/TestExpectations:
- 6:16 AM Changeset in webkit [237547] by
-
- 125 edits9 copies21 adds4 deletes in trunk
New bytecode format for JSC
https://bugs.webkit.org/show_bug.cgi?id=187373
<rdar://problem/44186758>
Reviewed by Filip Pizlo.
.:
Disable JIT by default on 32-bit platforms
- Source/cmake/WebKitFeatures.cmake:
JSTests:
Add tests to ensure that the inferred inline capacity for a narrow op_new_object will be capped at 255.
- stress/maximum-inline-capacity.js: Added.
(test1):
(test3.Foo):
(test3):
Source/JavaScriptCore:
Replace unlinked and linked bytecode with a new immutable bytecode that does not embed
any addresses. Instructions can be encoded as narrow (1-byte operands) or wide (4-byte
operands) and might contain an extra operand, the metadataID. The metadataID is used to
access the instruction's mutable data in a side table in the CodeBlock (the MetadataTable).
Bytecodes now must be structs declared in the new BytecodeList.rb. All bytecodes give names
and types to all its operands. Additionally, reading a bytecode from the instruction stream
requires decoding the whole bytecode, i.e. it's no longer possible to access arbitrary
operands directly from the stream.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- assembler/MacroAssemblerCodeRef.h:
(JSC::ReturnAddressPtr::ReturnAddressPtr):
(JSC::ReturnAddressPtr::value const):
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
- bytecode/ArithProfile.h:
(JSC::ArithProfile::ArithProfile):
- bytecode/ArrayAllocationProfile.h:
(JSC::ArrayAllocationProfile::ArrayAllocationProfile):
- bytecode/ArrayProfile.h:
- bytecode/BytecodeBasicBlock.cpp:
(JSC::isJumpTarget):
(JSC::BytecodeBasicBlock::computeImpl):
(JSC::BytecodeBasicBlock::compute):
- bytecode/BytecodeBasicBlock.h:
(JSC::BytecodeBasicBlock::leaderOffset const):
(JSC::BytecodeBasicBlock::totalLength const):
(JSC::BytecodeBasicBlock::offsets const):
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addLength):
- bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::printLocationAndOp):
(JSC::BytecodeDumper<Block>::dumpBytecode):
(JSC::BytecodeDumper<Block>::dumpIdentifiers):
(JSC::BytecodeDumper<Block>::dumpConstants):
(JSC::BytecodeDumper<Block>::dumpExceptionHandlers):
(JSC::BytecodeDumper<Block>::dumpSwitchJumpTables):
(JSC::BytecodeDumper<Block>::dumpStringSwitchJumpTables):
(JSC::BytecodeDumper<Block>::dumpBlock):
- bytecode/BytecodeDumper.h:
(JSC::BytecodeDumper::dumpOperand):
(JSC::BytecodeDumper::dumpValue):
(JSC::BytecodeDumper::BytecodeDumper):
(JSC::BytecodeDumper::block const):
- bytecode/BytecodeGeneratorification.cpp:
(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::BytecodeGeneratorification::enterPoint const):
(JSC::BytecodeGeneratorification::instructions const):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):
(JSC::performGeneratorification):
- bytecode/BytecodeGeneratorification.h:
- bytecode/BytecodeGraph.h:
(JSC::BytecodeGraph::blockContainsBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockForBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockWithLeaderOffset):
(JSC::BytecodeGraph::BytecodeGraph):
- bytecode/BytecodeKills.h:
- bytecode/BytecodeList.json: Removed.
- bytecode/BytecodeList.rb: Added.
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::BytecodeLivenessAnalysis::dumpResults):
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/BytecodeLivenessAnalysisInlines.h:
(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessPropagation::stepOverInstruction):
- bytecode/BytecodeRewriter.cpp:
(JSC::BytecodeRewriter::applyModification):
(JSC::BytecodeRewriter::execute):
(JSC::BytecodeRewriter::adjustJumpTargetsInFragment):
(JSC::BytecodeRewriter::insertImpl):
(JSC::BytecodeRewriter::adjustJumpTarget):
(JSC::BytecodeRewriter::adjustJumpTargets):
- bytecode/BytecodeRewriter.h:
(JSC::BytecodeRewriter::InsertionPoint::InsertionPoint):
(JSC::BytecodeRewriter::Fragment::Fragment):
(JSC::BytecodeRewriter::Fragment::appendInstruction):
(JSC::BytecodeRewriter::BytecodeRewriter):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):
(JSC::BytecodeRewriter::removeBytecode):
(JSC::BytecodeRewriter::adjustAbsoluteOffset):
(JSC::BytecodeRewriter::adjustJumpTarget):
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::estimatedSize):
(JSC::CodeBlock::visitChildren):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
(JSC::CodeBlock::addJITAddIC):
(JSC::CodeBlock::addJITMulIC):
(JSC::CodeBlock::addJITSubIC):
(JSC::CodeBlock::addJITNegIC):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeOffset):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeOffsetSlow):
(JSC::CodeBlock::hasOpDebugForLineAndColumn):
(JSC::CodeBlock::getArrayProfile):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::predictedMachineCodeSize):
(JSC::CodeBlock::tryGetValueProfileForBytecodeOffset):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::validate):
(JSC::CodeBlock::outOfLineJumpOffset):
(JSC::CodeBlock::outOfLineJumpTarget):
(JSC::CodeBlock::arithProfileForBytecodeOffset):
(JSC::CodeBlock::arithProfileForPC):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addMathIC):
(JSC::CodeBlock::outOfLineJumpOffset):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::instructions const):
(JSC::CodeBlock::instructionCount const):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::metadata):
(JSC::CodeBlock::metadataSizeInBytes):
(JSC::CodeBlock::numberOfNonArgumentValueProfiles):
(JSC::CodeBlock::totalNumberOfValueProfiles):
- bytecode/CodeBlockInlines.h: Added.
(JSC::CodeBlock::forEachValueProfile):
(JSC::CodeBlock::forEachArrayProfile):
(JSC::CodeBlock::forEachArrayAllocationProfile):
(JSC::CodeBlock::forEachObjectAllocationProfile):
(JSC::CodeBlock::forEachLLIntCallLinkInfo):
- bytecode/Fits.h: Added.
- bytecode/GetByIdMetadata.h: Copied from Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
(JSC::Instruction::Impl::opcodeID const):
(JSC::Instruction::opcodeID const):
(JSC::Instruction::name const):
(JSC::Instruction::isWide const):
(JSC::Instruction::size const):
(JSC::Instruction::is const):
(JSC::Instruction::as const):
(JSC::Instruction::cast):
(JSC::Instruction::cast const):
(JSC::Instruction::narrow const):
(JSC::Instruction::wide const):
- bytecode/InstructionStream.cpp: Copied from Source/JavaScriptCore/bytecode/SpecialPointer.cpp.
(JSC::InstructionStream::InstructionStream):
(JSC::InstructionStream::sizeInBytes const):
- bytecode/InstructionStream.h: Added.
(JSC::InstructionStream::BaseRef::BaseRef):
(JSC::InstructionStream::BaseRef::operator=):
(JSC::InstructionStream::BaseRef::operator-> const):
(JSC::InstructionStream::BaseRef::ptr const):
(JSC::InstructionStream::BaseRef::operator!= const):
(JSC::InstructionStream::BaseRef::next const):
(JSC::InstructionStream::BaseRef::offset const):
(JSC::InstructionStream::BaseRef::isValid const):
(JSC::InstructionStream::BaseRef::unwrap const):
(JSC::InstructionStream::MutableRef::freeze const):
(JSC::InstructionStream::MutableRef::operator->):
(JSC::InstructionStream::MutableRef::ptr):
(JSC::InstructionStream::MutableRef::operator Ref):
(JSC::InstructionStream::MutableRef::unwrap):
(JSC::InstructionStream::iterator::operator*):
(JSC::InstructionStream::iterator::operator++):
(JSC::InstructionStream::begin const):
(JSC::InstructionStream::end const):
(JSC::InstructionStream::at const):
(JSC::InstructionStream::size const):
(JSC::InstructionStreamWriter::InstructionStreamWriter):
(JSC::InstructionStreamWriter::ref):
(JSC::InstructionStreamWriter::seek):
(JSC::InstructionStreamWriter::position):
(JSC::InstructionStreamWriter::write):
(JSC::InstructionStreamWriter::rewind):
(JSC::InstructionStreamWriter::finalize):
(JSC::InstructionStreamWriter::swap):
(JSC::InstructionStreamWriter::iterator::operator*):
(JSC::InstructionStreamWriter::iterator::operator++):
(JSC::InstructionStreamWriter::begin):
(JSC::InstructionStreamWriter::end):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::clearLLIntGetByIdCache):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
- bytecode/MetadataTable.cpp: Copied from Source/JavaScriptCore/bytecode/SpecialPointer.cpp.
(JSC::MetadataTable::MetadataTable):
(JSC::DeallocTable::withOpcodeType):
(JSC::MetadataTable::~MetadataTable):
(JSC::MetadataTable::sizeInBytes):
- bytecode/MetadataTable.h: Copied from Source/JavaScriptCore/runtime/Watchdog.h.
(JSC::MetadataTable::get):
(JSC::MetadataTable::forEach):
(JSC::MetadataTable::getImpl):
- bytecode/Opcode.cpp:
(JSC::metadataSize):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/OpcodeInlines.h:
(JSC::isOpcodeShape):
(JSC::getOpcodeType):
- bytecode/OpcodeSize.h: Copied from Source/JavaScriptCore/bytecode/SpecialPointer.cpp.
- bytecode/PreciseJumpTargets.cpp:
(JSC::getJumpTargetsForInstruction):
(JSC::computePreciseJumpTargetsInternal):
(JSC::computePreciseJumpTargets):
(JSC::recomputePreciseJumpTargets):
(JSC::findJumpTargetsForInstruction):
- bytecode/PreciseJumpTargets.h:
- bytecode/PreciseJumpTargetsInlines.h:
(JSC::jumpTargetForInstruction):
(JSC::extractStoredJumpTargetsForInstruction):
(JSC::updateStoredJumpTargetsForInstruction):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
- bytecode/SpecialPointer.cpp:
(WTF::printInternal):
- bytecode/SpecialPointer.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::visitChildren):
(JSC::UnlinkedCodeBlock::estimatedSize):
(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset const):
(JSC::UnlinkedCodeBlock::setInstructions):
(JSC::UnlinkedCodeBlock::instructions const):
(JSC::UnlinkedCodeBlock::applyModification):
(JSC::UnlinkedCodeBlock::addOutOfLineJumpTarget):
(JSC::UnlinkedCodeBlock::outOfLineJumpOffset):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction):
(JSC::UnlinkedCodeBlock::propertyAccessInstructions const):
(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset):
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets const):
(JSC::UnlinkedCodeBlock::metadata):
(JSC::UnlinkedCodeBlock::metadataSizeInBytes):
(JSC::UnlinkedCodeBlock::outOfLineJumpOffset):
(JSC::UnlinkedCodeBlock::replaceOutOfLineJumpTargets):
- bytecode/UnlinkedInstructionStream.cpp: Removed.
- bytecode/UnlinkedInstructionStream.h: Removed.
- bytecode/UnlinkedMetadataTable.h: Copied from Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h.
- bytecode/UnlinkedMetadataTableInlines.h: Added.
(JSC::UnlinkedMetadataTable::UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::addEntry):
(JSC::UnlinkedMetadataTable::sizeInBytes):
(JSC::UnlinkedMetadataTable::finalize):
(JSC::UnlinkedMetadataTable::link):
(JSC::UnlinkedMetadataTable::unlink):
- bytecode/VirtualRegister.cpp:
(JSC::VirtualRegister::VirtualRegister):
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::Label::setLocation):
(JSC::Label::bind):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
(JSC::BytecodeGenerator::emitEnter):
(JSC::BytecodeGenerator::emitLoopHint):
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitCheckTraps):
(JSC::BytecodeGenerator::rewind):
(JSC::BytecodeGenerator::fuseCompareAndJump):
(JSC::BytecodeGenerator::fuseTestAndJmp):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
(JSC::BytecodeGenerator::moveLinkTimeConstant):
(JSC::BytecodeGenerator::moveEmptyValue):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitBinaryOp):
(JSC::BytecodeGenerator::emitToObject):
(JSC::BytecodeGenerator::emitToNumber):
(JSC::BytecodeGenerator::emitToString):
(JSC::BytecodeGenerator::emitTypeOf):
(JSC::BytecodeGenerator::emitInc):
(JSC::BytecodeGenerator::emitDec):
(JSC::BytecodeGenerator::emitEqualityOp):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitProfileControlFlow):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::emitResolveScopeForHoistingFuncDeclInEval):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::emitOverridesHasInstance):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitInstanceOf):
(JSC::BytecodeGenerator::emitInstanceOfCustom):
(JSC::BytecodeGenerator::emitInByVal):
(JSC::BytecodeGenerator::emitInById):
(JSC::BytecodeGenerator::emitTryGetById):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitDirectGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitPutGetterById):
(JSC::BytecodeGenerator::emitPutSetterById):
(JSC::BytecodeGenerator::emitPutGetterSetter):
(JSC::BytecodeGenerator::emitPutGetterByVal):
(JSC::BytecodeGenerator::emitPutSetterByVal):
(JSC::BytecodeGenerator::emitDeleteById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitPutByVal):
(JSC::BytecodeGenerator::emitDirectPutByVal):
(JSC::BytecodeGenerator::emitDeleteByVal):
(JSC::BytecodeGenerator::emitSuperSamplerBegin):
(JSC::BytecodeGenerator::emitSuperSamplerEnd):
(JSC::BytecodeGenerator::emitIdWithProfile):
(JSC::BytecodeGenerator::emitUnreachable):
(JSC::BytecodeGenerator::emitGetArgument):
(JSC::BytecodeGenerator::emitCreateThis):
(JSC::BytecodeGenerator::emitTDZCheck):
(JSC::BytecodeGenerator::emitNewObject):
(JSC::BytecodeGenerator::emitNewArrayBuffer):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitNewArrayWithSpread):
(JSC::BytecodeGenerator::emitNewArrayWithSize):
(JSC::BytecodeGenerator::emitNewRegExp):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewDefaultConstructor):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitSetFunctionNameIfNeeded):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallInTailPosition):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitCallForwardArgumentsInTailPosition):
(JSC::BytecodeGenerator::emitLogShadowChickenPrologueIfNecessary):
(JSC::BytecodeGenerator::emitLogShadowChickenTailIfNecessary):
(JSC::BytecodeGenerator::emitCallDefineProperty):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitEnd):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitStrcat):
(JSC::BytecodeGenerator::emitToPrimitive):
(JSC::BytecodeGenerator::emitGetScope):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitGetParentScope):
(JSC::BytecodeGenerator::emitDebugHook):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitThrow):
(JSC::BytecodeGenerator::emitArgumentCount):
(JSC::BytecodeGenerator::emitThrowStaticError):
(JSC::BytecodeGenerator::beginSwitch):
(JSC::prepareJumpTableForSwitch):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::endSwitch):
(JSC::BytecodeGenerator::emitGetEnumerableLength):
(JSC::BytecodeGenerator::emitHasGenericProperty):
(JSC::BytecodeGenerator::emitHasIndexedProperty):
(JSC::BytecodeGenerator::emitHasStructureProperty):
(JSC::BytecodeGenerator::emitGetPropertyEnumerator):
(JSC::BytecodeGenerator::emitEnumeratorStructurePropertyName):
(JSC::BytecodeGenerator::emitEnumeratorGenericPropertyName):
(JSC::BytecodeGenerator::emitToIndexString):
(JSC::BytecodeGenerator::emitIsCellWithType):
(JSC::BytecodeGenerator::emitIsObject):
(JSC::BytecodeGenerator::emitIsNumber):
(JSC::BytecodeGenerator::emitIsUndefined):
(JSC::BytecodeGenerator::emitIsEmpty):
(JSC::BytecodeGenerator::emitRestParameter):
(JSC::BytecodeGenerator::emitRequireObjectCoercible):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitGetAsyncIterator):
(JSC::BytecodeGenerator::emitDelegateYield):
(JSC::BytecodeGenerator::emitFinallyCompletion):
(JSC::BytecodeGenerator::emitJumpIf):
(JSC::ForInContext::finalize):
(JSC::StructureForInContext::finalize):
(JSC::IndexedForInContext::finalize):
(JSC::StaticPropertyAnalysis::record):
(JSC::BytecodeGenerator::emitToThis):
- bytecompiler/BytecodeGenerator.h:
(JSC::StructureForInContext::addGetInst):
(JSC::BytecodeGenerator::recordOpcode):
(JSC::BytecodeGenerator::addMetadataFor):
(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::kill):
(JSC::BytecodeGenerator::instructions const):
(JSC::BytecodeGenerator::write):
(JSC::BytecodeGenerator::withWriter):
- bytecompiler/Label.h:
(JSC::Label::Label):
(JSC::Label::bind):
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_argumentCount):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::BitwiseNotNode::emitBytecode):
(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
(JSC::StrictEqualNode::emitBytecode):
(JSC::emitReadModifyAssignment):
(JSC::ForInNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::FunctionNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):
- bytecompiler/ProfileTypeBytecodeFlag.cpp: Copied from Source/JavaScriptCore/bytecode/VirtualRegister.cpp.
(WTF::printInternal):
- bytecompiler/ProfileTypeBytecodeFlag.h: Copied from Source/JavaScriptCore/bytecode/SpecialPointer.cpp.
- bytecompiler/RegisterID.h:
- bytecompiler/StaticPropertyAnalysis.h:
(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
- bytecompiler/StaticPropertyAnalyzer.h:
(JSC::StaticPropertyAnalyzer::createThis):
(JSC::StaticPropertyAnalyzer::newObject):
(JSC::StaticPropertyAnalyzer::putById):
(JSC::StaticPropertyAnalyzer::mov):
(JSC::StaticPropertyAnalyzer::kill):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::handleCallVariant):
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleDOMJITCall):
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleModuleNamespaceLoad):
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):
(JSC::DFG::ByteCodeParser::handlePutAccessorById):
(JSC::DFG::ByteCodeParser::handlePutAccessorByVal):
(JSC::DFG::ByteCodeParser::handleNewFunc):
(JSC::DFG::ByteCodeParser::handleNewFuncExp):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGCapabilities.h:
(JSC::DFG::capabilityLevel):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareCatchOSREntry):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileArithMul):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- generate-bytecode-files: Removed.
- generator/Argument.rb: Added.
- generator/Assertion.rb: Added.
- generator/DSL.rb: Added.
- generator/Fits.rb: Added.
- generator/GeneratedFile.rb: Added.
- generator/Metadata.rb: Added.
- generator/Opcode.rb: Added.
- generator/OpcodeGroup.rb: Added.
- generator/Options.rb: Added.
- generator/Section.rb: Added.
- generator/Template.rb: Added.
- generator/Type.rb: Added.
- generator/main.rb: Added.
- interpreter/AbstractPC.h:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::currentVPC const):
(JSC::CallFrame::setCurrentVPC):
- interpreter/CallFrame.h:
(JSC::CallSiteIndex::CallSiteIndex):
(JSC::ExecState::setReturnPC):
- interpreter/Interpreter.cpp:
(WTF::printInternal):
- interpreter/Interpreter.h:
- interpreter/InterpreterInlines.h:
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::dump const):
- interpreter/VMEntryRecord.h:
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::emitSlowCaseCall):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_jless):
(JSC::JIT::emit_op_jlesseq):
(JSC::JIT::emit_op_jgreater):
(JSC::JIT::emit_op_jgreatereq):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emit_op_jngreater):
(JSC::JIT::emit_op_jngreatereq):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_op_below):
(JSC::JIT::emit_op_beloweq):
(JSC::JIT::emit_op_jbelow):
(JSC::JIT::emit_op_jbeloweq):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitBitBinaryOpFastPath):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShiftFastPath):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::getOperandTypes):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
- jit/JITCall.cpp:
(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileTailCall):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_forward_arguments):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emitSlow_op_construct):
- jit/JITDisassembler.cpp:
(JSC::JITDisassembler::JITDisassembler):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITInlines.h:
(JSC::JIT::emitDoubleGetByVal):
(JSC::JIT::emitLoadForArrayMode):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::sampleInstruction):
(JSC::JIT::emitValueProfilingSiteIfProfiledOpcode):
(JSC::JIT::emitValueProfilingSite):
(JSC::JIT::jumpTarget):
(JSC::JIT::copiedGetPutInfo):
(JSC::JIT::copiedArithProfile):
- jit/JITMathIC.h:
(JSC::isProfileEmpty):
(JSC::JITBinaryMathIC::JITBinaryMathIC):
(JSC::JITUnaryMathIC::JITUnaryMathIC):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_instanceof_custom):
(JSC::JIT::emit_op_is_empty):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_cell_with_type):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_set_function_name):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_stricteq):
(JSC::JIT::emit_op_nstricteq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emit_op_jstricteq):
(JSC::JIT::emit_op_jnstricteq):
(JSC::JIT::emitSlow_op_jstricteq):
(JSC::JIT::emitSlow_op_jnstricteq):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_to_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_identity_with_profile):
(JSC::JIT::emit_op_get_parent_scope):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_get_scope):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_check_tdz):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_jeq):
(JSC::JIT::emitSlow_op_jneq):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_check_traps):
(JSC::JIT::emit_op_nop):
(JSC::JIT::emit_op_super_sampler_begin):
(JSC::JIT::emit_op_super_sampler_end):
(JSC::JIT::emitSlow_op_check_traps):
(JSC::JIT::emit_op_new_regexp):
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_generator_func):
(JSC::JIT::emit_op_new_async_generator_func):
(JSC::JIT::emit_op_new_async_func):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_new_generator_func_exp):
(JSC::JIT::emit_op_new_async_func_exp):
(JSC::JIT::emit_op_new_async_generator_func_exp):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::privateCompileHasIndexedProperty):
(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emit_op_enumerator_structure_pname):
(JSC::JIT::emit_op_enumerator_generic_pname):
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
(JSC::JIT::emit_op_profile_control_flow):
(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_get_rest_length):
(JSC::JIT::emit_op_get_argument):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_to_this):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val_direct):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::emit_op_get_from_arguments):
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompileGetByValWithCachedId):
(JSC::JIT::privateCompilePutByVal):
(JSC::JIT::privateCompilePutByValWithCachedId):
(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitDirectArgumentsGetByVal):
(JSC::JIT::emitScopedArgumentsGetByVal):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::JITSlowPathCall):
- llint/LLIntData.cpp:
(JSC::LLInt::initialize):
(JSC::LLInt::Data::performAssertions):
- llint/LLIntData.h:
(JSC::LLInt::exceptionInstructions):
(JSC::LLInt::opcodeMap):
(JSC::LLInt::opcodeMapWide):
(JSC::LLInt::getOpcode):
(JSC::LLInt::getOpcodeWide):
(JSC::LLInt::getWideCodePtr):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::entryOSR):
(JSC::LLInt::setupGetByIdPrototypeCache):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):
(JSC::LLInt::varargsSetup):
(JSC::LLInt::commonCallEval):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoopRegister::operator const Instruction*):
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm64.rb:
- offlineasm/asm.rb:
- offlineasm/ast.rb:
- offlineasm/cloop.rb:
- offlineasm/generate_offset_extractor.rb:
- offlineasm/instructions.rb:
- offlineasm/offsets.rb:
- offlineasm/parser.rb:
- offlineasm/transform.rb:
- offlineasm/x86.rb:
- parser/ResultType.h:
(JSC::ResultType::dump const):
(JSC::OperandTypes::first const):
(JSC::OperandTypes::second const):
(JSC::OperandTypes::dump const):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
(JSC::updateArithProfileForUnaryArithOp):
(JSC::updateArithProfileForBinaryArithOp):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
- runtime/ExceptionFuzz.cpp:
(JSC::doExceptionFuzzing):
- runtime/ExceptionFuzz.h:
(JSC::doExceptionFuzzingIfEnabled):
- runtime/GetPutInfo.cpp: Copied from Source/JavaScriptCore/bytecode/SpecialPointer.cpp.
(JSC::GetPutInfo::dump const):
(WTF::printInternal):
- runtime/GetPutInfo.h:
(JSC::GetPutInfo::operand const):
- runtime/JSCPoison.h:
- runtime/JSType.cpp: Added.
(WTF::printInternal):
- runtime/JSType.h:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
- runtime/SlowPathReturnType.h:
(JSC::encodeResult):
(JSC::decodeResult):
- runtime/VM.h:
- runtime/Watchdog.h:
- tools/HeapVerifier.cpp:
Source/WTF:
- wtf/Forward.h: Fix WTF_LAZY_FOR_EACH_TERM on MSVC and add WTF_LAZY_HAS_REST to check whether
a macro was passed multiple arguments
- wtf/Platform.h: Force ENABLE_JIT=false on all 32-bit platforms
- wtf/Vector.h:
(WTF::minCapacity>::insertVector): Allow vectors with different overflow handlers to be passed to insertVector
Tools:
Do not force ENABLE_JIT=true when $forceCLoop is false.
- Scripts/build-jsc:
LayoutTests:
Don't use recursion on
equalto avoid premature stack overflows when testing deep arrays.
- fast/dom/Window/resources/postmessage-test.js:
- 3:47 AM Changeset in webkit [237546] by
-
- 4 edits in trunk/Source
[WebRTC] Enable VP8 by default
https://bugs.webkit.org/show_bug.cgi?id=190672
Source/WebCore:
<rdar://problem/43663785>
Reviewed by Eric Carlson.
No change of behavior.
- page/RuntimeEnabledFeatures.h: Set default value to true.
Source/WebKit:
Reviewed by Eric Carlson.
- Shared/WebPreferences.yaml:
- 3:42 AM Changeset in webkit [237545] by
-
- 1 copy in releases/WPE WebKit/webkit-2.22.3
WebKitGTK+ 2.22.3
- 3:41 AM Changeset in webkit [237544] by
-
- 4 edits in releases/WebKitGTK/webkit-2.22
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.22.3.
- 3:05 AM WebKitGTK/Releasing edited by
- The user-agent is not updated anymore, remove mention (diff)
- 3:04 AM WebKitGTK/Releasing edited by
- Update to make note of SET_PROJECT_VERSION() usage (diff)
- 2:45 AM Changeset in webkit [237543] by
-
- 2 edits in trunk/Tools
[GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
Unreviewed build fix
The build fails because of some array-bound check related
to strcmp() macro optimizations. Disabling selective Werrors
when building xserver-xorg might get past this.
- gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
configuration.
- 1:22 AM Changeset in webkit [237542] by
-
- 2 edits in trunk/Tools
[GTK] Update API test expectations after r237383
https://bugs.webkit.org/show_bug.cgi?id=186913
Unreviewed gardening.
- TestWebKitAPI/glib/TestExpectations.json: Remove
passing TestSSL tests.
Oct 28, 2018:
- 11:48 PM Changeset in webkit [237541] by
-
- 8 edits2 adds1 delete in trunk
[WPE] Add the WebKitVersion.h header
https://bugs.webkit.org/show_bug.cgi?id=191015
Reviewed by Michael Catanzaro.
Source/WebKit:
Add the WebKitVersion.h API header for the WPE port. As with other
headers providing the GLib API, we have to provide a WPE-specific
version, but the implementation file can be shared with the GTK port,
and is moved under the UIProcess/API/glib/ directory accordingly.
- PlatformWPE.cmake:
- SourcesWPE.txt:
- UIProcess/API/glib/WebKitVersion.cpp: Renamed from Source/WebKit/UIProcess/API/gtk/WebKitVersion.cpp.
- UIProcess/API/wpe/WebKitVersion.h.in: Added.
- UIProcess/API/wpe/webkit.h:
Tools:
- MiniBrowser/wpe/main.cpp:
(automationStartedCallback): Remove the FIXME and finally enable the
webkit_application_info_set_version() call.
- TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
- 10:58 PM Changeset in webkit [237540] by
-
- 8 edits in tags/Safari-607.1.10.6/Source
Cherry-pick r237421. rdar://problem/45562620
[Web Animations] Turn Web Animations CSS Integration off by default
https://bugs.webkit.org/show_bug.cgi?id=190901
Reviewed by Dean Jackson.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm: (+[WebPreferences initialize]):
Source/WebKitLegacy/win:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:56 PM Changeset in webkit [237539] by
-
- 7 edits in tags/Safari-607.1.10.6/Source
Versioning.
- 10:52 PM Changeset in webkit [237538] by
-
- 1 copy in tags/Safari-607.1.10.6
New tag.
- 10:33 PM Changeset in webkit [237537] by
-
- 7 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r237466. rdar://problem/45562436
Use dark appearance scrollbar when page background is dark or document supports dark mode.
https://bugs.webkit.org/show_bug.cgi?id=190937
rdar://problem/41225839
Reviewed by Beth Dakin.
Source/WebCore:
- page/FrameView.cpp: (WebCore::FrameView::useDarkAppearance const): Added. Ask the document. (WebCore::FrameView::paintScrollCorner): Set LocalDefaultSystemAppearance based on the scrollbar overlay style too.
- page/FrameView.h:
- platform/ScrollableArea.h: (WebCore::ScrollableArea::useDarkAppearance const): Added. Default to false.
- platform/mac/ScrollAnimatorMac.mm: (-[WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]): Added. Ask the ScrollableArea if a dark appearance is desired.
Source/WebCore/PAL:
- pal/spi/mac/NSScrollerImpSPI.h: Added effectiveAppearanceForScrollerImp:.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:01 PM Changeset in webkit [237536] by
-
- 3 edits in trunk/Tools
[Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
https://bugs.webkit.org/show_bug.cgi?id=190948
Reviewed by Brent Fulgham.
vcxproj files have been removed in Bug 154388.
- Scripts/build-api-tests: Removed obsolete code to build vcproj.
- Scripts/build-jsc:
(buildMyProject): Ditto. Removed a condition of buiding bmalloc
which is not used because Windows ports are using CMake.
- 5:03 PM Changeset in webkit [237535] by
-
- 13 edits in branches/safari-606-branch
Cherry-pick r237060. rdar://problem/45435468
IOS 12 - Service worker cache not shared when added to homescreen
https://bugs.webkit.org/show_bug.cgi?id=190269
<rdar://problem/45009961>
Reviewed by Alex Christensen.
Source/WebCore:
Expose Cache Storage API when Service Worker API is exposed.
This is used for API tests.
- dom/ScriptExecutionContext.h: Make hasServiceWorkerScheme available outside SERVICE_WORKER compilation flag since used by DOMWindowCaches.
- dom/ScriptExecutionContext.cpp: Ditto.
- Modules/cache/DOMWindowCaches.idl:
Source/WebKit:
NetworkProcessProxy does not always have all its stores in its hash map.
Make sure to check for the default web process pool store when grabbing cache storage parameters from a given session ID.
Add a way to remove the default website data for testing.
This is used in the new API test.
- UIProcess/API/APIWebsiteDataStore.cpp: (API::WebsiteDataStore::deleteDefaultDataStoreForTesting):
- UIProcess/API/APIWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (+[WKWebsiteDataStore _deleteDefaultDataStoreForTesting]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Add test to ensure that CacheStorage use the default website data store parameters.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:01 PM Changeset in webkit [237534] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r235908 - Unreviewed, attempt to fix Apple builds after r235903
https://bugs.webkit.org/show_bug.cgi?id=188872
If it really needs to be inlined, it will need to move to the header....
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageClient const):
- 4:01 PM Changeset in webkit [237533] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r235907 - Unreviewed, fix build after r235903
https://bugs.webkit.org/show_bug.cgi?id=188872
This broke all ports except GTK. Need to add a missing header.
- UIProcess/PageClient.h:
- 4:01 PM Changeset in webkit [237532] by
-
- 11 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r235903 - WebPageProxy should hold a WeakPtr to its PageClient
https://bugs.webkit.org/show_bug.cgi?id=188872
Reviewed by Ryosuke Niwa.
This ensures the PageClient reference is always valid when used.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::setDragCaretRect):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::PageClientProtector::PageClientProtector):
(WebKit::PageClientProtector::~PageClientProtector):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::m_resetRecentCrashCountTimer):
(WebKit::WebPageProxy::pageClient const):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::shouldKeepCurrentBackForwardListItemInList):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::requestScroll):
(WebKit::WebPageProxy::viewScrollPosition const):
(WebKit::WebPageProxy::updateActivityState):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::viewDidEnterWindow):
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::layerHostingModeDidChange):
(WebKit::WebPageProxy::viewSize const):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::didPerformDragOperation):
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::didDestroyNavigation):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::willPerformClientRedirectForFrame):
(WebKit::WebPageProxy::didCancelClientRedirectForFrame):
(WebKit::WebPageProxy::didChangeProvisionalURLForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didReachLayoutMilestone):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::frameDidBecomeFrameSet):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::didUpdateHistoryTitle):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::getWindowFrameWithCallback):
(WebKit::WebPageProxy::screenToRootView):
(WebKit::WebPageProxy::rootViewToScreen):
(WebKit::WebPageProxy::syncRootViewToScreen):
(WebKit::WebPageProxy::accessibilityScreenToRootView):
(WebKit::WebPageProxy::rootViewToAccessibilityScreen):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::showShareSheet):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::showDataListSuggestions):
(WebKit::WebPageProxy::compositionWasCanceled):
(WebKit::WebPageProxy::registerInsertionUndoGrouping):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setTextIndicator):
(WebKit::WebPageProxy::clearTextIndicator):
(WebKit::WebPageProxy::setTextIndicatorAnimationProgress):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::canUndo):
(WebKit::WebPageProxy::canRedo):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):
(WebKit::WebPageProxy::didFinishLoadingDataForCustomContentProvider):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):
(WebKit::WebPageProxy::setEditableElementIsFocused):
(WebKit::WebPageProxy::takeViewSnapshot):
(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):
(WebKit::WebPageProxy::signedPublicKeyAndChallengeString):
(WebKit::WebPageProxy::navigationGestureDidBegin):
(WebKit::WebPageProxy::navigationGestureWillEnd):
(WebKit::WebPageProxy::navigationGestureDidEnd):
(WebKit::WebPageProxy::willRecordNavigationSnapshot):
(WebKit::WebPageProxy::navigationGestureSnapshotWasRemoved):
(WebKit::WebPageProxy::isPlayingMediaDidChange):
(WebKit::WebPageProxy::videoControlsManagerDidChange):
(WebKit::WebPageProxy::handleControlledElementIDResponse const):
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
(WebKit::WebPageProxy::immediateActionAnimationControllerForHitTestResult):
(WebKit::WebPageProxy::didHandleAcceptedCandidate):
(WebKit::WebPageProxy::addPlaybackTargetPickerClient):
(WebKit::WebPageProxy::removePlaybackTargetPickerClient):
(WebKit::WebPageProxy::showPlaybackTargetPicker):
(WebKit::WebPageProxy::playbackTargetPickerClientStateDidChange):
(WebKit::WebPageProxy::setMockMediaPlaybackTargetPickerEnabled):
(WebKit::WebPageProxy::setMockMediaPlaybackTargetPickerState):
(WebKit::WebPageProxy::didChangeBackgroundColor):
(WebKit::WebPageProxy::didRestoreScrollPosition):
(WebKit::WebPageProxy::userInterfaceLayoutDirection):
(WebKit::WebPageProxy::didInsertAttachment):
(WebKit::WebPageProxy::didRemoveAttachment):
- UIProcess/WebPageProxy.h:
- UIProcess/gstreamer/WebPageProxyGStreamer.cpp:
(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::viewWidget):
(WebKit::WebPageProxy::editorStateChanged):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::computeCustomFixedPositionRect const):
(WebKit::WebPageProxy::overflowScrollViewWillStartPanGesture):
(WebKit::WebPageProxy::overflowScrollViewDidScroll):
(WebKit::WebPageProxy::overflowScrollWillStartScroll):
(WebKit::WebPageProxy::overflowScrollDidEndScroll):
(WebKit::WebPageProxy::didCommitLayerTree):
(WebKit::WebPageProxy::layerTreeCommitComplete):
(WebKit::WebPageProxy::didReceivePositionInformation):
(WebKit::WebPageProxy::saveImageToLibrary):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::couldNotRestorePageState):
(WebKit::WebPageProxy::restorePageState):
(WebKit::WebPageProxy::restorePageCenterAndScale):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::showInspectorHighlight):
(WebKit::WebPageProxy::hideInspectorHighlight):
(WebKit::WebPageProxy::showInspectorIndication):
(WebKit::WebPageProxy::hideInspectorIndication):
(WebKit::WebPageProxy::enableInspectorNodeSearch):
(WebKit::WebPageProxy::disableInspectorNodeSearch):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
(WebKit::WebPageProxy::showPlaybackTargetPicker):
(WebKit::WebPageProxy::commitPotentialTapFailed):
(WebKit::WebPageProxy::didNotHandleTapAsClick):
(WebKit::WebPageProxy::didCompleteSyntheticClick):
(WebKit::WebPageProxy::disableDoubleTapGesturesDuringTapIfNecessary):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showValidationMessage):
(WebKit::WebPageProxy::didHandleStartDataInteractionRequest):
(WebKit::WebPageProxy::didHandleAdditionalDragItemsRequest):
(WebKit::WebPageProxy::didConcludeEditDataInteraction):
(WebKit::WebPageProxy::didRequestPasswordForQuickLookDocumentInMainFrame):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedTextAsync):
(WebKit::WebPageProxy::setPromisedDataForImage):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::assistiveTechnologyMakeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
(WebKit::WebPageProxy::acceleratedCompositingRootLayer const):
(WebKit::WebPageProxy::showPDFContextMenu):
(WebKit::WebPageProxy::showTelephoneNumberMenu):
(WebKit::WebPageProxy::boundsOfLayerInLayerBackedWindowCoordinates const):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::startWindowDrag):
(WebKit::WebPageProxy::platformWindow):
(WebKit::WebPageProxy::rootViewToWindow):
(WebKit::WebPageProxy::showValidationMessage):
(WebKit::WebPageProxy::inspectorAttachmentView):
(WebKit::WebPageProxy::remoteObjectRegistry):
- UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::viewWidget):
- UIProcess/wpe/WebPageProxyWPE.cpp:
(WebKit::WebPageProxy::viewBackend):
- 1:40 PM Changeset in webkit [237531] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, one more GTK expectations fix
- platform/gtk/inspector/canvas/recording-bitmaprenderer-expected.txt:
- 1:38 PM Changeset in webkit [237530] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix a few more expectations from yesterday
These should be timeouts!
- platform/gtk/TestExpectations:
- 1:28 PM WebKitGTK/2.22.x edited by
- (diff)
- 1:28 PM WebKitGTK/2.22.x edited by
- (diff)
- 1:01 PM Changeset in webkit [237529] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, attempt to fix missing trailing whitespace in new expectations
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
- 12:38 PM Changeset in webkit [237528] by
-
- 4 edits in branches/safari-606-branch/Source
Apply patch. rdar://problem/45523764
- 12:12 PM Changeset in webkit [237527] by
-
- 5 edits5 adds in branches/safari-606-branch
Cherry-pick r237395. rdar://problem/45574503
Only report resource timing to parent frame for the first iframe load
https://bugs.webkit.org/show_bug.cgi?id=190498
<rdar://problem/44347398>
Reviewed by Youenn Fablet.
Source/WebCore:
Only the first iframe navigation or the first iframe navigation after about:blank should be reported.
https://www.w3.org/TR/resource-timing-2/#resources-included-in-the-performanceresourcetiming-interface
Test: http/tests/misc/resource-timing-navigation-in-restored-iframe.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader):
- loader/FrameLoader.h: (WebCore::FrameLoader::shouldReportResourceTimingToParentFrame): (WebCore::FrameLoader::setShouldReportResourceTimingToParentFrame): Deleted.
- loader/ResourceTimingInformation.cpp: (WebCore::ResourceTimingInformation::addResourceTiming):
LayoutTests:
The layout test is from Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/1186215.
- http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt: Added.
- http/tests/misc/resource-timing-navigation-in-restored-iframe.html: Added.
- http/tests/misc/resources/alert-then-back.html: Added.
- http/tests/misc/resources/navigate-on-message.html: Added.
- http/tests/misc/resources/post-message-to-parent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:12 PM Changeset in webkit [237526] by
-
- 1 edit1 add in branches/safari-606-branch/JSTests
Cherry-pick r237326. rdar://problem/45363533
DFGAbstractValue::m_arrayModes expects IndexingMode values, not IndexingType.
https://bugs.webkit.org/show_bug.cgi?id=190515
<rdar://problem/45222379>
Rubber-stamped by Saam Barati.
Adding another test.
- stress/regress-190515-2.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:12 PM Changeset in webkit [237525] by
-
- 7 edits1 add in branches/safari-606-branch
Cherry-pick r237325. rdar://problem/45363533
DFGAbstractValue::m_arrayModes expects IndexingMode values, not IndexingType.
https://bugs.webkit.org/show_bug.cgi?id=190515
<rdar://problem/45222379>
Reviewed by Saam Barati.
JSTests:
- stress/regress-190515.js: Added.
Source/JavaScriptCore:
- Fixes calls to asArrayModes() to take a structure's IndexingMode instead of IndexingType.
- DFG's compileNewArrayBuffer()'s HaveABadTime case was previously using the node's indexingType (instead of indexingMode) to choose the array structure to use for creating an array buffer with. This turns out to not be an issue because when the VM is in having a bad time, all the arrayStructureForIndexingTypeDuringAllocation structure pointers will point to the SlowPutArrayStorage structure anyway. However, to be strictly correct, we'll fix it to use the structure for the node's indexingMode.
- dfg/DFGAbstractValue.cpp: (JSC::DFG::AbstractValue::set): (JSC::DFG::AbstractValue::mergeOSREntryValue):
- dfg/DFGAbstractValue.h: (JSC::DFG::AbstractValue::validate const):
- dfg/DFGOSRExit.cpp: (JSC::DFG::OSRExit::executeOSRExit):
- dfg/DFGRegisteredStructureSet.cpp: (JSC::DFG::RegisteredStructureSet::arrayModesFromStructures const):
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileNewArrayBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:12 PM Changeset in webkit [237524] by
-
- 12 edits2 adds in branches/safari-606-branch
Cherry-pick r237135. rdar://problem/45562440
[iOS] Can't select text after dismissing the keyboard when changing focus
https://bugs.webkit.org/show_bug.cgi?id=190563
<rdar://problem/44613559>
Reviewed by Tim Horton.
Source/WebKit:
In r230686, we switched from using UIWKSelectionAssistant to UIWKTextInteractionAssistant for handling selection
in non-editable content on iOS; as such, when an editable element loses focus, instead of switching from the
text interaction assistant to the web selection assistant as we've previously done, we now reset our text
interaction assistant by calling-[UIWKTextInteractionAssistant setGestureRecognizers], which removes all of
the current text selection gesture recognizers from WKContentView and regenerates them by building up a tree of
UITextInteractions and adding them to the assistant (see `-[UITextInteractionAssistant
addGestureRecognizersToView:]). In particular,_UITextSelectionForceGesture` is the gesture recognizer used to
trigger text selection when long pressing.
After dismissing the keyboard by tapping the "Done" button, the UITextInteractions and gesture recognizers on
the interaction assistant include:
<UITextInteraction>
…
<UITextIndirectNonEditableInteraction>
<_UIKeyboardBasedNonEditableTextSelectionInteraction>
↳ "_UIKeyboardTextSelectionGestureForcePress" → <_UITextSelectionForceGesture>
However, after the keyboard dismisses due to an editable element losing focus, the UITextInteractions on the
interaction assistant look like this:
<UITextInteraction>
…
<UITextIndirectNonEditableInteraction>
Subsequently, the lack of a
_UIKeyboardBasedNonEditableTextSelectionInteractionmakes text selection by long
pressing impossible, since the_UITextSelectionForceGestureis never introduced toWKContentView. In UIKit,
UITextIndirectNonEditableInteractiononly adds_UIKeyboardBasedNonEditableTextSelectionInteractionas a
child if the text input view — in our case, WKContentView — is missing an input delegate (see-initWithView:).
In the case where the Done button is used to dismiss the keyboard, WKContentView loses first responder, and the
input delegate of WKContentView is cleared out early on, before we call-stopAssistingKeyboard:
-[WKContentView(WKInteraction) setInputDelegate:]
-[UIKeyboardImpl setDelegate:force:]
-[UIPeripheralHost(UIKitInternal) _reloadInputViewsForResponder:]
-[UIResponder _finishResignFirstResponder]
-[UIResponder resignFirstResponder]
-[WKContentView(WKInteraction) resignFirstResponderForWebView]
-[UIKeyboardImpl dismissKeyboard]
However, in the case where the focused element is blurred, we end up clearing out the delegate in
-_stopAssistingNode, *after* we've already called-setGestureRecognizerson the interaction assistant. This
means UIKit will skip adding_UIKeyboardBasedNonEditableTextSelectionInteractionto the text interaction
assistant.
-[WKContentView(WKInteraction) setInputDelegate:]
-[UIKeyboardImpl setDelegate:force:]
-[UIPeripheralHost(UIKitInternal) _reloadInputViewsForResponder:]
-[UIResponder(UIResponderInputViewAdditions) reloadInputViews]
-[WKContentView(WKInteraction) _stopAssistingNode]
To fix this, we simply reset our
inputDelegateearlier in_stopAssistingKeyboardinstead of waiting until
we reload input views. This ensures that UIKit sets up the text interaction assistant's gestures when changing
focus in the same way as we would when the keyboard is dismissed via-resignFirstResponder(e.g. when pressing
the Done button).
Test: editing/selection/ios/select-text-after-changing-focus.html
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]): (-[WKContentView setUpTextSelectionAssistant]): (-[WKContentView _startAssistingKeyboard]): (-[WKContentView _stopAssistingKeyboard]): (-[WKContentView useSelectionAssistantWithGranularity:]): Deleted.
Additionally rename this to -setUpTextSelectionAssistant and remove the selection granularity argument. This was
previously used to switch between web and text interaction assistants.
Tools:
- DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::isShowingKeyboard const):
Add a new UIScriptController method that returns whether the keyboard is shown. See
ui-helper.jsfor more
details.
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::isShowingKeyboard const):
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
Also rename the
isShowingKeyboardObjective-C property to the more canonicalshowingKeyboard, with
isShowingKeyboardas the getter method.
(-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
(-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::isShowingKeyboard const):
LayoutTests:
Add a new layout test to check that the user can make a selection by long pressing after the keyboard is
dismissed due to changing the focused element.
- editing/selection/ios/select-text-after-changing-focus-expected.txt: Added.
- editing/selection/ios/select-text-after-changing-focus.html: Added.
- resources/ui-helper.js:
Also tweak the behavior of
UIHelper.waitForKeyboardToHide(), so that it resolves immediately if the keyboard
is not shown. This allows us to ensure that tests which useUIHelper.waitForKeyboardToHide()are robust in the
case where they wait for another action to complete (e.g. a simulated tap) prior to registering a keyboard
hiding callback.
(window.UIHelper.waitForKeyboardToHide.return.new.Promise):
(window.UIHelper.waitForKeyboardToHide):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:25 AM Changeset in webkit [237523] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 11:18 AM Changeset in webkit [237522] by
-
- 4 edits in trunk
HashMap should support selecting a random entry
https://bugs.webkit.org/show_bug.cgi?id=190814
Reviewed by Ryosuke Niwa.
Source/WTF:
- wtf/HashTable.h:
(WTF::HashTable::random):
(WTF::HashTable::random const): Merge the empty and deleted checks, and
use more idiomatic addressing.
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
IsEvenlyDistributed to reflect the fact that we're only testing the
distribution. Added a test case that covers more table densities and
the remove() operation.
- 7:44 AM WebKitGTK/2.22.x edited by
- (diff)
- 7:34 AM Changeset in webkit [237521] by
-
- 8 edits in trunk
[Payment Request] Implement MerchantValidationEvent.methodName
https://bugs.webkit.org/show_bug.cgi?id=190058
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/payment-request/MerchantValidationEvent/constructor.https-expected.txt:
Source/WebCore:
Implemented MerchantValidationEvent's methodName attribute and MerchantValidationEventInit's
methodName property as specified in the Payment Request API W3C Editor's Draft of
27 September 2018.
Covered by web-platform-tests/payment-request/MerchantValidationEvent/constructor.https.html.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::validateMerchant): Passed the payment method identifier
(as a string) to MerchantValidationEvent::create()
- Modules/paymentrequest/MerchantValidationEvent.cpp:
(WebCore::MerchantValidationEvent::create): Validated the methodName before constructing the
event, throwing a RangeError on failure.
(WebCore::MerchantValidationEvent::MerchantValidationEvent):
- Modules/paymentrequest/MerchantValidationEvent.h:
- Modules/paymentrequest/MerchantValidationEvent.idl:
- 6:44 AM Changeset in webkit [237520] by
-
- 9 edits1 add in releases/WebKitGTK/webkit-2.22
Merged r237469 - Fix missing edge cases with JSGlobalObjects having a bad time.
https://bugs.webkit.org/show_bug.cgi?id=189028
<rdar://problem/45204939>
Reviewed by Saam Barati.
JSTests:
- stress/regress-189028.js: Added.
Source/JavaScriptCore:
Consider the following scenario:
let object O1 (of global G1) have an indexing type that is not SlowPut.
let global G2 have a bad time.
let object O2 (of global G2) be set as the prototype of O1.
let object O3 (of global G2) have indexed accessors.
In the existing code, if we set O3 as O2's prototype, we'll have a bug where
O1 will not be made aware that that there are indexed accessors in its prototype
chain.
In this patch, we solve this issue by introducing a new invariant:
A prototype chain is considered to possibly have indexed accessors if any
object in the chain belongs to a global object that is having a bad time.
We apply this invariant as follows:
- Enhance JSGlobalObject::haveABadTime() to also check if other global objects are affected by it having a bad time. If so, it also ensures that those affected global objects have a bad time.
The original code for JSGlobalObject::haveABadTime() uses a ObjectsWithBrokenIndexingFinder
to find all objects affected by the global object having a bad time. We enhance
ObjectsWithBrokenIndexingFinder to also check for the possibility that any global
objects may be affected by other global objects having a bad time i.e.
let g1 = global1
let g2 = global2
let o1 = an object in g1
let o2 = an object in g2
let g1 have a bad time
g2 is affected if
o1 is in the prototype chain of o2,
and o2 may be a prototype.
If the ObjectsWithBrokenIndexingFinder does find the possibility of other global
objects being affected, it will abort its heap scan and let haveABadTime() take
a slow path to do a more complete multi global object scan.
The slow path works as follows:
- Iterate the heap and record the graph of all global object dependencies.
For each global object, record the list of other global objects that are
affected by it.
- Compute a list of global objects that need to have a bad time using the current global object dependency graph.
- For each global object in the list of affected global objects, fire their HaveABadTime watchpoint and convert all their array structures to the SlowPut alternatives.
- Re-run ObjectsWithBrokenIndexingFinder to find all objects that are affected by any of the globals in the list from (2).
- Enhance Structure::mayInterceptIndexedAccesses() to also return true if the structure's global object is having a bad time.
Note: there are 3 scenarios that we need to consider:
let g1 = global1
let g2 = global2
let o1 = an object in g1
let o2 = an object in g2
Scenario 1: o2 is a prototype, and
g1 has a bad time after o1 is inserted into the o2's prototype chain.
Scenario 2: o2 is a prototype, and
o1 is inserted into the o2's prototype chain after g1 has a bad time.
Scenario 3: o2 is NOT a prototype, and
o1 is inserted into the o2's prototype chain after g1 has a bad time.
For scenario 1, when g1 has a bad time, we need to also make sure g2 has
a bad time. This is handled by enhancement 1 above.
For scenario 2, when o1 is inserted into o2's prototype chain, we need to check
if o1's global object has a bad time. If so, then we need to make sure o2's
global also has a bad time (because o2 is a prototype) and convert o2's
storage type to SlowPut. This is handled by enhancement 2 above in conjunction
with JSObject::setPrototypeDirect().
For scenario 3, when o1 is inserted into o2's prototype chain, we need to check
if o1's global object has a bad time. If so, then we only need to convert o2's
storage type to SlowPut (because o2 is NOT a prototype). This is handled by
enhancement 2 above.
- Also add $vm.isHavingABadTime(), $vm.createGlobalObject() to enable us to write some tests for this issue.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut):
(JSC::JSGlobalObject::haveABadTime):
- runtime/JSGlobalObject.h:
- runtime/JSObject.h:
(JSC::JSObject::mayInterceptIndexedAccesses): Deleted.
- runtime/JSObjectInlines.h:
(JSC::JSObject::mayInterceptIndexedAccesses):
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::mayInterceptIndexedAccesses const):
- tools/JSDollarVM.cpp:
(JSC::functionHaveABadTime):
(JSC::functionIsHavingABadTime):
(JSC::functionCreateGlobalObject):
(JSC::JSDollarVM::finishCreation):
- 6:44 AM Changeset in webkit [237519] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.22
Merged r237450 - [MSE][WTF][Media] Invalid MediaTime should be falsy
https://bugs.webkit.org/show_bug.cgi?id=190893
Reviewed by Jer Noble.
Source/WTF:
This patch modifies the definition of MediaTime so that invalid times
are evaluated to false in the context of a boolean expression.
- wtf/MediaTime.cpp:
(WTF::MediaTime::operator! const):
(WTF::MediaTime::operator bool const):
Tools:
This patch adds additional API tests for the conversions from
MediaTime to boolean.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
LayoutTests:
A test is added that replicates a bug fixed by this patch.
- media/media-source/media-source-timestampoffset-then-zero-expected.txt: Added.
- media/media-source/media-source-timestampoffset-then-zero.html: Added.
- 6:44 AM Changeset in webkit [237518] by
-
- 13 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r237410 - [GTK][AC] Resizing the window doesn't always update the visible rect
https://bugs.webkit.org/show_bug.cgi?id=189743
Reviewed by Michael Catanzaro.
Disassociate resizing that can be done on an AcceleratedSurface object
between "host resizes" and "client resizes".
The former is done from ThreadedCoordinatedLayerTreeHost directly, and
is currently used only for GTK on X11, where a new pixmap object is
created on each resize, which affects the context ID that is based on
that pixmap object's address.
The latter is done from the composition thread. It's used for GTK on
Wayland and WPE. In both cases, the underlying window object does not
change on each resize, but it's necessary to perform the actual resize
on the composition thread.
So far it hasn't been performed there, which ended up pushing sizes of
the WebKit view and the underlying window object out of sync during
resizing, leaving parts of window unrendered.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::renderLayerTree):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- WebProcess/WebPage/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::hostResize):
(WebKit::AcceleratedSurface::resize): Deleted.
- WebProcess/WebPage/AcceleratedSurface.h:
(WebKit::AcceleratedSurface::clientResize):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:
(WebKit::AcceleratedSurfaceWayland::clientResize):
(WebKit::AcceleratedSurfaceWayland::resize): Deleted.
- WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:
- WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:
(WebKit::AcceleratedSurfaceX11::hostResize):
(WebKit::AcceleratedSurfaceX11::resize): Deleted.
- WebProcess/WebPage/gtk/AcceleratedSurfaceX11.h:
- WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:
(WebKit::AcceleratedSurfaceWPE::clientResize):
(WebKit::AcceleratedSurfaceWPE::resize): Deleted.
- WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.h:
- 6:43 AM Changeset in webkit [237517] by
-
- 5 edits5 adds in releases/WebKitGTK/webkit-2.22
Merged r237395 - Only report resource timing to parent frame for the first iframe load
https://bugs.webkit.org/show_bug.cgi?id=190498
<rdar://problem/44347398>
Reviewed by Youenn Fablet.
Source/WebCore:
Only the first iframe navigation or the first iframe navigation after about:blank should be reported.
https://www.w3.org/TR/resource-timing-2/#resources-included-in-the-performanceresourcetiming-interface
Test: http/tests/misc/resource-timing-navigation-in-restored-iframe.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):
- loader/FrameLoader.h:
(WebCore::FrameLoader::shouldReportResourceTimingToParentFrame):
(WebCore::FrameLoader::setShouldReportResourceTimingToParentFrame): Deleted.
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
LayoutTests:
The layout test is from Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/1186215.
- http/tests/misc/resource-timing-navigation-in-restored-iframe-expected.txt: Added.
- http/tests/misc/resource-timing-navigation-in-restored-iframe.html: Added.
- http/tests/misc/resources/alert-then-back.html: Added.
- http/tests/misc/resources/navigate-on-message.html: Added.
- http/tests/misc/resources/post-message-to-parent.html: Added.
- 6:43 AM Changeset in webkit [237516] by
-
- 7 edits1 add in releases/WebKitGTK/webkit-2.22
Merged r237325 - DFGAbstractValue::m_arrayModes expects IndexingMode values, not IndexingType.
https://bugs.webkit.org/show_bug.cgi?id=190515
<rdar://problem/45222379>
Reviewed by Saam Barati.
JSTests:
- stress/regress-190515.js: Added.
Source/JavaScriptCore:
- Fixes calls to asArrayModes() to take a structure's IndexingMode instead of IndexingType.
- DFG's compileNewArrayBuffer()'s HaveABadTime case was previously using the node's indexingType (instead of indexingMode) to choose the array structure to use for creating an array buffer with. This turns out to not be an issue because when the VM is in having a bad time, all the arrayStructureForIndexingTypeDuringAllocation structure pointers will point to the SlowPutArrayStorage structure anyway. However, to be strictly correct, we'll fix it to use the structure for the node's indexingMode.
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::mergeOSREntryValue):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::validate const):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::executeOSRExit):
- dfg/DFGRegisteredStructureSet.cpp:
(JSC::DFG::RegisteredStructureSet::arrayModesFromStructures const):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewArrayBuffer):
- 6:43 AM Changeset in webkit [237515] by
-
- 4 edits in releases/WebKitGTK/webkit-2.22
Merged r237278 - [Media] Use nanoseconds as MaximumTimeScale
https://bugs.webkit.org/show_bug.cgi?id=190631
Source/WTF:
1e9 is a much more useful timescale than the previous one 231-1.
Unlike 231-1, which is a prime number, nanosecond scale is pretty
common among some formats like WebM and frameworks like GStreamer
where base 10 timescale is common... and it's those big timescales the
ones that are usually scaled up to MaximumTimeScale.
Reviewed by Jer Noble.
- wtf/MediaTime.cpp:
Tools:
Rebased MediaTime tests covering timescales over the maximum.
Reviewed by Jer Noble.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 6:43 AM Changeset in webkit [237514] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.22
Merged r237274 - [MSE] timestampOffset can introduce floating-point rounding errors to incoming samples
https://bugs.webkit.org/show_bug.cgi?id=190590
<rdar://problem/45275626>
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-timestampoffset-rounding-error.html
SourceBuffer.timestampOffset is a double property, which, when added to a MediaTime will
result in a double-backed MediaTime as PTS & DTS. This can introduce rounding errors when
these samples are appended as overlapping existing samples. Rather than converting a MediaTime
to double-backed when adding the timestampOffset, convert the offset to a multiple of the
sample's timeBase.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::setTimestampOffset):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
LayoutTests:
- media/media-source/media-source-sequence-timestamps-expected.txt:
- media/media-source/media-source-timestampoffset-rounding-error-expected.txt: Added.
- media/media-source/media-source-timestampoffset-rounding-error.html: Added.
- media/media-source/mock-media-source.js:
(makeASample):
- 6:43 AM Changeset in webkit [237513] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore
Merged r237215 - GetIndexedPropertyStorage can GC.
https://bugs.webkit.org/show_bug.cgi?id=190625
<rdar://problem/45309366>
Reviewed by Saam Barati.
This is because if the ArrayMode type is String, the DFG and FTL will be emitting
a call to operationResolveRope, and operationResolveRope can GC. This patch
updates doesGC() to reflect this.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- 6:43 AM Changeset in webkit [237512] by
-
- 4 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r237191 - [GLib] Build error with RemoteInspector disabled
https://bugs.webkit.org/show_bug.cgi?id=190623
Reviewed by Michael Catanzaro.
Compilation guards added to ensure the build still works when the
Remote WebInspector has been disabled.
- UIProcess/API/glib/WebKitAutomationSession.cpp:
- UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
- UIProcess/RemoteWebInspectorProxy.cpp:
- 6:43 AM Changeset in webkit [237511] by
-
- 4 edits1 add in releases/WebKitGTK/webkit-2.22
Merged r237129 - JSArray::shiftCountWithArrayStorage is wrong when an array has holes
https://bugs.webkit.org/show_bug.cgi?id=190262
<rdar://problem/44986241>
Reviewed by Mark Lam.
JSTests:
- stress/array-prototype-concat-of-long-spliced-arrays.js:
(test):
- stress/slice-array-storage-with-holes.js: Added.
(main):
Source/JavaScriptCore:
We would take the fast path for shiftCountWithArrayStorage when the array
hasHoles(). However, the code for this was wrong. It'd incorrectly update
ArrayStorage::m_numValuesInVector. Since the hasHoles() for ArrayStorage
path is never taken in JetStream 2, this patch just removes that from
the fast path. Instead, we just fallback to the slow path when hasHoles().
If we find evidence that this matters for real use cases, we can
figure out a way to make the fast path work.
- runtime/JSArray.cpp:
(JSC::JSArray::shiftCountWithArrayStorage):
- 6:42 AM Changeset in webkit [237510] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.22
Merged r237119 - [Cairo] Incorrect rendering for 135-deg skews
https://bugs.webkit.org/show_bug.cgi?id=190513
Source/WebCore:
Compensation value to zero the the translation components
of the transformation matrix is incorrect if the matrix
has a shear factor.
Reviewed by Žan Doberšek.
Tests: fast/transforms/skew-x-135deg-with-gradient.html
fast/transforms/skew-y-135deg-with-gradient.html
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext):
LayoutTests:
Reviewed by Žan Doberšek.
- fast/transforms/skew-x-135deg-with-gradient-expected.html: Added.
- fast/transforms/skew-x-135deg-with-gradient.html: Added.
- fast/transforms/skew-y-135deg-with-gradient-expected.html: Added.
- fast/transforms/skew-y-135deg-with-gradient.html: Added.
- 6:42 AM Changeset in webkit [237509] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.22
Merged r236991 - REGRESSION(r234620): SVGLangSpace::svgAttributeChanged() should invalidate the renderer of the SVGGeometryElement descendant only
https://bugs.webkit.org/show_bug.cgi?id=190411
Reviewed by Simon Fraser.
Source/WebCore:
Test: svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr.html
When changing the attributes of the SVGLangSpace, we should invalidate
the renderer of the SVGGeometryElement descendant only. Renderer of other
elements, like SVGStopElement, should not be invalidated because they do
not have geometry and they can be used as resources for drawing another
SVGGeometryElement.
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGGeometryElement const):
- svg/SVGGeometryElement.h:
(isType):
- svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::svgAttributeChanged):
LayoutTests:
- svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr-expected.txt: Added.
- svg/dynamic-updates/SVGStopElement-dom-xml-lang-attrr.html: Added.
- 6:42 AM Changeset in webkit [237508] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore
Merged r236985 - [WPE][GTK] Complex text crashes with harfbuzz 1.8.8
https://bugs.webkit.org/show_bug.cgi?id=190409
Reviewed by Žan Doberšek.
We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of
hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually
expecting (transfer none), so it's not immediately clear to me why it's crashing now, but
doesn't matter as Behdad recommends removing this line of code because it hasn't been
been needed for many years.
This should be covered by all our complex text tests if the bots were upgraded to the newer
harfbuzz.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- 6:42 AM Changeset in webkit [237507] by
-
- 4 edits in releases/WebKitGTK/webkit-2.22/Source
Mergeg r236975 - [WPE] Explicitly link against gmodule where used
https://bugs.webkit.org/show_bug.cgi?id=190398
Reviewed by Michael Catanzaro.
- PlatformWPE.cmake:
- 6:42 AM Changeset in webkit [237506] by
-
- 7 edits in releases/WebKitGTK/webkit-2.22
Merged r236961 - [GStreamer] Stealing cross-origin video pixel with HLS
https://bugs.webkit.org/show_bug.cgi?id=190003
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Report the SecurityOrigin of downloaded adaptivedemux (HLS, DASH,
SmoothStreaming) fragments as tainted if their origin differs from
the manifest SecurityOrigin. SecurityOrigins are stored in the
CachedResourceStreamingClient implemented in the internal
GStreamer HTTP(S) source element.
The implementation is not ideal yet because the fragments download
is performed by the WebProcess, until bug 189967 is fixed. When
this bug is fixed, the m_hasTaintedOrigin member variable should
be removed and all checks be done unconditionally to the
webkithttpsrc element which will manage the download of the
manifests and fragments.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::loadFull): Reset the m_hasTaintedOrigin value.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Get the
fragment URL from the adaptivedemux stats message and check if its
origin is tainted.
(WebCore::MediaPlayerPrivateGStreamer::wouldTaintOrigin const):
Initial implementation by checking the m_hasTaintedOrigin member
variable value.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::responseReceived): Store the
resource origin internally so it can be checked later on by
webKitSrtcWouldTaintOrigin().
(webKitSrcWouldTaintOrigin): Check given origin against cached
origins. This implementation is similar to Cocoa's
WebCoreNSURLSession implementation.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
LayoutTests:
- platform/gtk/TestExpectations: Unflag now-passing test.
- 6:42 AM Changeset in webkit [237505] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebKit
Merged r236928 - Validation in Connection::readBytesFromSocket() is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=190281
Reviewed by Michael Catanzaro.
Since r217206 Connection::readBytesFromSocket() validates size of
control message. However, it compares cmsg_len with attachmentMaxAmount,
while Connection::sendOutgoingMessage() computes it as
CMSG_LEN(sizeof(int) * attachmentFDBufferLength) where
attachmentFDBufferLength <= attachmentMaxAmount. This mismatch between
sender and receiver leads to possibility of assertion failure with large
number of attachments, e.g. here 62 attachments have cmsg_length == 264.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket):
- 6:42 AM Changeset in webkit [237504] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore
Merged r236789 - Ref<FetchResponse> use-after-move in DOMCache::put()
https://bugs.webkit.org/show_bug.cgi?id=190239
Reviewed by Youenn Fablet.
Retrieve reference from the Ref<FetchResponse> object before it's
move-captured in the lambda that's passed to the
FetchResponse::consumeBodyReceivedByChunk() method that is invoked on
that very same object. This is a classic use-after-move bug that pops
up on compilers with different C++ calling convention.
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::put):
- 6:42 AM Changeset in webkit [237503] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.22
Merged r236288 - Release assert under RenderView::pageOrViewLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=189798
<rdar://problem/43659749>
Reviewed by Simon Fraser.
Source/WebCore:
Only the mainframe's render view is sized to the page while printing.
Use the matching check (see RenderView::layout) when accessing m_pageLogicalSize.
Test: printing/crash-while-formatting-subframe-for-printing.html
- rendering/RenderView.cpp:
(WebCore::RenderView::pageOrViewLogicalHeight const):
LayoutTests:
- printing/crash-while-formatting-subframe-for-printing-expected.txt: Added.
- printing/crash-while-formatting-subframe-for-printing.html: Added.
- 6:41 AM Changeset in webkit [237502] by
-
- 6 edits1 add in releases/WebKitGTK/webkit-2.22
Merged r236161 - Ensure that ForInContexts are invalidated if their loop local is over-written. https://bugs.webkit.org/show_bug.cgi?id=189571 <rdar://problem/44402277>
Reviewed by Saam Barati.
JSTests:
- stress/regress-189571.js: Added.
Source/JavaScriptCore:
Instead of hunting down every place in the BytecodeGenerator that potentially
needs to invalidate an enclosing ForInContext (if one exists), we simply iterate
the bytecode range of the loop body when the ForInContext is popped, and
invalidate the context if we ever find the loop temp variable over-written.
This has 2 benefits:
- It ensures that every type of opcode that can write to the loop temp will be handled appropriately, not just the op_mov that we've hunted down.
- It avoids us having to check the BytecodeGenerator's m_forInContextStack every time we emit an op_mov (or other opcodes that can write to a local) even when we're not inside a for-in loop.
JSC benchmarks show that that this change is performance neutral.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::popIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):
(JSC::BytecodeGenerator::popStructureForInScope):
(JSC::ForInContext::finalize):
(JSC::StructureForInContext::finalize):
(JSC::IndexedForInContext::finalize):
(JSC::BytecodeGenerator::invalidateForInContextForLocal): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::ForInContext::ForInContext):
(JSC::ForInContext::bodyBytecodeStartOffset const):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::EmptyLetExpression::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::bindValue const):
(JSC::AssignmentElementNode::bindValue const):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- 6:41 AM Changeset in webkit [237501] by
-
- 3 edits in releases/WebKitGTK/webkit-2.22
Merged r235956 - imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html hits assertion
https://bugs.webkit.org/show_bug.cgi?id=189493
Reviewed by Alex Christensen.
Source/WebCore:
The debug assertion was caused by RefPtr in FormAssociatedElement::formOwnerRemovedFromTree introduced
by r224390 and r223644 ref'ing ShadowRoot while calling removeDetachedChildren inside ~ShadowRoot.
When a form (or any other) element has more than one ref inside removeDetachedChildren,
addChildNodesToDeletionQueue calls notifyChildNodeRemoved in the tree oreder.
However, when a form associated element of this form element appears later in the tree order,
FormAssociatedElement::formOwnerRemovedFromTree can traverse up ancestors including the ShadowRoot.
Fixed the bug by using raw pointers instead. Luckily, there is no DOM mutations or other non-trivial
operations happening in this function so this should be safe.
Test: imported/w3c/web-platform-tests/shadow-dom/form-control-form-attribute.html
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formOwnerRemovedFromTree): Fixed the bug.
LayoutTests:
Unskip the test now that it doesn't hit a debug assertion.
- 5:48 AM WebKitGTK/2.22.x edited by
- (diff)
- 3:47 AM WebKitGTK/2.22.x edited by
- (diff)
- 12:54 AM Changeset in webkit [237500] by
-
- 3 edits in trunk/Source/WebCore
[Web Animations] Remove WebAnimation::description()
https://bugs.webkit.org/show_bug.cgi?id=190995
Reviewed by Dean Jackson.
This method is never used.
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::description): Deleted.
- animation/WebAnimation.h:
- 12:53 AM Changeset in webkit [237499] by
-
- 4 edits in trunk/Source/WebCore
[Web Animations] Move the logic of Document::getAnimations() to DocumentTimeline
https://bugs.webkit.org/show_bug.cgi?id=190994
Reviewed by Dean Jackson.
It would be cleaner to have the logic of document.getAnimations() on the DocumentTimeline instead of the Document, keep more
animation-related code compartmentalized in the animation directory. No change in behavior, so no test update.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::getAnimations const):
- animation/DocumentTimeline.h:
- dom/Document.cpp:
(WebCore::Document::getAnimations):
- 12:51 AM Changeset in webkit [237498] by
-
- 5 edits in trunk/Source/WebCore
[Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation
https://bugs.webkit.org/show_bug.cgi?id=190996
Reviewed by Dean Jackson.
Moving all of the IDL bindings methods that require flushing style from CSSAnimation to its superclass
DeclarativeAnimation so we follow the same route in CSSTransition. Note that there was code in
CSSAnimation::bindingsCurrentTime() that was not moved as it proved to not be necessary.
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):
(WebCore::CSSAnimation::bindingsStartTime const): Deleted.
(WebCore::CSSAnimation::setBindingsStartTime): Deleted.
(WebCore::CSSAnimation::bindingsCurrentTime const): Deleted.
(WebCore::CSSAnimation::setBindingsCurrentTime): Deleted.
(WebCore::CSSAnimation::bindingsPlayState const): Deleted.
(WebCore::CSSAnimation::bindingsPending const): Deleted.
(WebCore::CSSAnimation::bindingsReady): Deleted.
(WebCore::CSSAnimation::bindingsFinished): Deleted.
(WebCore::CSSAnimation::flushPendingStyleChanges const): Deleted.
- animation/CSSAnimation.h:
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::bindingsStartTime const):
(WebCore::DeclarativeAnimation::setBindingsStartTime):
(WebCore::DeclarativeAnimation::bindingsCurrentTime const):
(WebCore::DeclarativeAnimation::setBindingsCurrentTime):
(WebCore::DeclarativeAnimation::bindingsPlayState const):
(WebCore::DeclarativeAnimation::bindingsPending const):
(WebCore::DeclarativeAnimation::bindingsReady):
(WebCore::DeclarativeAnimation::bindingsFinished):
(WebCore::DeclarativeAnimation::bindingsPlay):
(WebCore::DeclarativeAnimation::bindingsPause):
(WebCore::DeclarativeAnimation::flushPendingStyleChanges const):
- animation/DeclarativeAnimation.h:
