Timeline



Nov 5, 2018:

11:11 PM Changeset in webkit [237848] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[WPE] Remove BackingStore, BackingStoreCairo implementation files from build
https://bugs.webkit.org/show_bug.cgi?id=191269

Reviewed by Michael Catanzaro.

  • SourcesWPE.txt: Drop the BackingStore.cpp and BackingStoreCairo.cpp

files from the WPE build. These are not used at all in WPE configuration
as they are only used by the GTK+ port for non-AC functionality.

11:09 PM Changeset in webkit [237847] by zandobersek@gmail.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Place Fontconfig-specific RefPtr specializations in RefPtrFontconfig.h
https://bugs.webkit.org/show_bug.cgi?id=191267

Reviewed by Michael Catanzaro.

Move the Fontconfig-specific RefPtr specialization declarations from
RefPtrCairo.h to RefPtrFontconfig.h, with definitions moved to the new
RefPtrFontconfig.cpp implementation file. These specializations are
not tied to Cairo in any way.

  • platform/FreeType.cmake:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cairo/RefPtrCairo.cpp:
  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:
  • platform/graphics/freetype/RefPtrFontconfig.cpp: Added.

(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/graphics/freetype/RefPtrFontconfig.h: Copied from Source/WebCore/platform/graphics/cairo/RefPtrCairo.h.
11:01 PM Changeset in webkit [237846] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

[CMake] Fix WebCore/Modules includes
https://bugs.webkit.org/show_bug.cgi?id=191287

Reviewed by Fujii Hironori.

No new tests. No change in behavior.

Add in applicationmanifest to the list of includes and sort the
modules directory.

  • CMakeLists.txt:
8:35 PM Changeset in webkit [237845] by mmaxfield@apple.com
  • 17 edits in trunk

Cache glyph paths and share underline skipping code between all the ports
https://bugs.webkit.org/show_bug.cgi?id=191239

Reviewed by Alex Christensen.

PerformanceTests:

Measures the performance of drawing a whole lot of underlines

  • Layout/underline.html: Added.

Source/WebCore:

I was hoping that caching the glyph paths was going to be a performance progression,
but it turns out that the additional overhead of WebCore::Path compensated for it.
In total, the performance is the same (my testing says that this patch is a 1%
progression, but that's within the noise).

Because the ink skipping logic is now shared among all ports, Windows now gets it for
free.

Test: PerformanceTests/Layout/underline.html

  • platform/graphics/Font.cpp:

(WebCore::Font::pathForGlyph const):

  • platform/graphics/Font.h:
  • platform/graphics/FontCascade.cpp:

(WebCore::computeUnderlineType):
(WebCore::GlyphIterationState::GlyphIterationState):
(WebCore::findIntersectionPoint):
(WebCore::updateX):
(WebCore::findPathIntersections):
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
(WebCore::GlyphToPathTranslator::containsMorePaths):
(WebCore::GlyphToPathTranslator::path):
(WebCore::GlyphToPathTranslator::extents):
(WebCore::GlyphToPathTranslator::underlineType):
(WebCore::GlyphToPathTranslator::advance):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap::existingMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::existingMetricsForGlyph const):
(WebCore::GlyphMetricsMap<std::optional<Path>>::unknownMetrics):

  • platform/graphics/TextRun.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformPathForGlyph const):
(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::CairoGlyphToPathTranslator::path): Deleted.
(WebCore::CairoGlyphToPathTranslator::extents): Deleted.
(WebCore::CairoGlyphToPathTranslator::underlineType): Deleted.
(WebCore::CairoGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::GlyphIterationState::GlyphIterationState): Deleted.
(WebCore::findIntersectionPoint): Deleted.
(WebCore::updateX): Deleted.
(WebCore::findPathIntersections): Deleted.
(): Deleted.
(WebCore::MacGlyphToPathTranslator::path): Deleted.
(WebCore::MacGlyphToPathTranslator::extents): Deleted.
(WebCore::MacGlyphToPathTranslator::underlineType): Deleted.
(WebCore::MacGlyphToPathTranslator::advance): Deleted.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Deleted.

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformPathForGlyph const):

  • rendering/TextDecorationPainter.cpp:

(WebCore::drawSkipInkUnderline):
(WebCore::TextDecorationPainter::paintTextDecoration):

Source/WTF:

Remove CSS3_TEXT_DECORATION_SKIP_INK. It's now interoperable and part of the Web Platform.

  • wtf/Platform.h:
8:32 PM Changeset in webkit [237844] by mmaxfield@apple.com
  • 23 edits in trunk/Source/WebCore

Clean up text decoration drawing code
https://bugs.webkit.org/show_bug.cgi?id=191245

Reviewed by Zalan Bujtas.

This is some general clean up of the text decorations code. There is no behavior change.

This patch modifies GraphicsContext::drawLineForText() & friends to accept a FloatRect instead of a FloatPoint + float width.
This is helpful because it allows for easier bounding box calculations.
This patch also removes some redundant computations that the skip:ink codepath was performing.
This patch also refactors the wavy decoration parameters to not use out params.

No new tests because there is no behavior change.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::computeUnderlineBoundsForText):
(WebCore::GraphicsContext::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextImpl.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawLinesForText::apply const):
(WebCore::DisplayList::DrawLinesForText::localBounds const):
(WebCore::DisplayList::operator<<):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawLinesForText::create):
(WebCore::DisplayList::DrawLinesForText::thickness const):
(WebCore::DisplayList::DrawLinesForText::DrawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawLinesForText):

  • platform/graphics/displaylists/DisplayListRecorder.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintMarkedTextDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline const):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

  • rendering/TextDecorationPainter.cpp:

(WebCore::strokeWavyTextDecoration):
(WebCore::translateIntersectionPointsToSkipInkBoundaries):
(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::drawSkipInkUnderline): Deleted.

  • rendering/TextDecorationPainter.h:

(WebCore::TextDecorationPainter::setInlineTextBox):
(WebCore::TextDecorationPainter::setWidth):
(WebCore::TextDecorationPainter::setFont): Deleted.
(WebCore::TextDecorationPainter::setBaseline): Deleted.

  • style/InlineTextBoxStyle.cpp:

(WebCore::getWavyStrokeParameters):
(WebCore::visualOverflowForDecorations):

  • style/InlineTextBoxStyle.h:
8:30 PM Changeset in webkit [237843] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after r237835
https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

  • rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness::operator== const):

8:07 PM Changeset in webkit [237842] by Wenson Hsieh
  • 10 edits
    2 adds in trunk

[iOS] Swatch appears squished and off-center in inputs of type color
https://bugs.webkit.org/show_bug.cgi?id=191279
<rdar://problem/45816319>

Reviewed by Tim Horton.

Source/WebCore:

This patch makes some small adjustments to color inputs on iOS to bring them closer to the intended design.
See comments below for more details.

Tests: fast/forms/color/color-input-uses-color-well-appearance.html

fast/forms/color/input-appearance-color.html

  • css/html.css:

Adjust the UA stylesheet for color inputs on iOS.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintDecorations):

When painting decorations for ColorWellPart, treat it as a standard button instead of the square button
appearance.

(WebCore::RenderTheme::colorInputStyleSheet const):

Add -webkit-appearance: color-well; to the stylesheet for color inputs. Previously, this was special-cased on
iOS, where color input elements had appearances of textfield; however, this patch makes some adjustments to
RenderThemeIOS, allowing us to use color-well on iOS.

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::platformUsesColorWellAppearance const): Deleted.

Remove this from RenderTheme. This is no longer necessary, since all platforms now use
-webkit-appearance: color-well;.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustButtonStyle const):

When painting buttons for color inputs, don't add rounded corners that are present by default for regular
buttons.

LayoutTests:

  • fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html: Added.
  • fast/forms/color/color-input-uses-color-well-appearance.html: Added.

Add a test to verify that setting -webkit-appearance: textfield; on a color input causes the color input to
render differently from a color input with a default appearance.

  • platform/ios-wk1/TestExpectations:
  • platform/ios/TestExpectations:

In the WebKit2 port of iOS, enable a handful of color input tests that are currently disabled.

  • platform/ios/fast/forms/color/input-appearance-color-expected.txt:

Rebaseline an existing test on iOS.

6:30 PM Changeset in webkit [237841] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.1.1

Tag Safari-606.3.4.1.1.

5:59 PM Changeset in webkit [237840] by Alan Coon
  • 1 edit in branches/safari-606.3.4.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

Apply patch. rdar://problem/45523764.

5:03 PM Changeset in webkit [237839] by bshafiei@apple.com
  • 8 edits
    2 adds in branches/safari-606.3.4.0-branch

Cherry-pick r237837. rdar://problem/45811371

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::setInterruptedForTesting):
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::beginInterruption): (WebCore::CoreAudioCaptureSource::endInterruption):
  • testing/Internals.cpp: (WebCore::Internals::setMediaStreamSourceInterrupted):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [237838] by bshafiei@apple.com
  • 7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

4:45 PM Changeset in webkit [237837] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setInterruptedForTesting):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::beginInterruption):
(WebCore::CoreAudioCaptureSource::endInterruption):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaStreamSourceInterrupted):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.
4:21 PM Changeset in webkit [237836] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Generalize trailing SDK specifier (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo):
(TestPlatformInfo.test_available_sdks):

4:11 PM Changeset in webkit [237835] by mmaxfield@apple.com
  • 18 edits
    6 adds in trunk

Parsing support for text-underline-offset and text-decoration-thickness
https://bugs.webkit.org/show_bug.cgi?id=191242

Reviewed by Simon Fraser.

Source/WebCore:

Before we can implement the properties properly, we have to parse them.

https://github.com/w3c/csswg-drafts/issues/3118#issuecomment-432297480 describes the grammar:

text-underline-position: auto | [ [ under | from-font]
[ left | right ] ]

text-underline-offset: auto | <length>
text-decoration-thickness: auto | from-font | <length>

This patch also takes the opportunity to update the grammar of text-underline-position to match the spec,
and to add an alias to the unprefixed version.

We still don't support the left and right values on text-underline-position. We should add those eventually.

Tests: fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html

fast/css3-text/css3-text-decoration/text-underline-offset-parse.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::textUnderlineOffsetToCSSValue):
(WebCore::textDecorationThicknessToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition const):
(WebCore::CSSPrimitiveValue::operator OptionSet<TextUnderlinePosition> const): Deleted.

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):
(WebCore::StyleBuilderConverter::convertTextUnderlineOffset):
(WebCore::StyleBuilderConverter::convertTextDecorationThickness):

  • css/StyleResolver.cpp:

(WebCore::shouldApplyPropertyInParseOrder):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTextUnderlineOffset):
(WebCore::consumeTextDecorationThickness):
(WebCore::CSSPropertyParser::parseSingleValue):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textUnderlinePosition const):
(WebCore::RenderStyle::textUnderlineOffset const):
(WebCore::RenderStyle::textDecorationThickness const):
(WebCore::RenderStyle::setTextUnderlinePosition):
(WebCore::RenderStyle::setTextUnderlineOffset):
(WebCore::RenderStyle::setTextDecorationThickness):
(WebCore::RenderStyle::initialTextUnderlinePosition):
(WebCore::RenderStyle::initialTextUnderlineOffset):
(WebCore::RenderStyle::initialTextDecorationThickness):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/TextDecorationThickness.h: Added.

(WebCore::TextDecorationThickness::createWithAuto):
(WebCore::TextDecorationThickness::createFromFont):
(WebCore::TextDecorationThickness::createWithLength):
(WebCore::TextDecorationThickness::isAuto const):
(WebCore::TextDecorationThickness::isFromFont const):
(WebCore::TextDecorationThickness::isLength const):
(WebCore::TextDecorationThickness::setLengthValue):
(WebCore::TextDecorationThickness::lengthValue const):
(WebCore::TextDecorationThickness::operator== const):
(WebCore::TextDecorationThickness::operator!= const):
(WebCore::TextDecorationThickness::TextDecorationThickness):
(WebCore::operator<<):

  • rendering/style/TextUnderlineOffset.h: Added.

(WebCore::TextUnderlineOffset::createWithAuto):
(WebCore::TextUnderlineOffset::createWithLength):
(WebCore::TextUnderlineOffset::isAuto const):
(WebCore::TextUnderlineOffset::isLength const):
(WebCore::TextUnderlineOffset::setLengthValue):
(WebCore::TextUnderlineOffset::lengthValue const):
(WebCore::TextUnderlineOffset::lengthOr const):
(WebCore::TextUnderlineOffset::operator== const):
(WebCore::TextUnderlineOffset::operator!= const):
(WebCore::TextUnderlineOffset::TextUnderlineOffset):
(WebCore::operator<<):

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

  • style/InlineTextBoxStyle.h:

LayoutTests:

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html: Update the

test for the new grammar of text-underline-position

  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-thickness-parse.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-offset-parse.html: Added.
4:09 PM Changeset in webkit [237834] by mmaxfield@apple.com
  • 20 edits
    9 adds in trunk

Spelling dots are drawn in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=190764

Reviewed by Dean Jackson.

Source/WebCore:

  • Dots should not be clipped.
  • Dots should be horizontally centered.
  • Dots should be drawn behind the text.
  • Distance from the baseline to the top of the dot should be 11.035% of font size.
  • Dot diameter should be 13.247% of the font size.
  • Distance between the dots (right side of the left dot to left side of the right dot) should be 9.457% of the font size.
  • The "font size" used in these calculations should be clamped so it's 10px <= font size <= 40px.

Tests: editing/spelling/spelling-dots-position-2.html

editing/spelling/spelling-dots-position-3.html
editing/spelling/spelling-dots-position.html
editing/spelling/spelling-dots-repaint.html

  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle): Align iOS and macOS implementations.
(WebCore::GraphicsContext::drawDotsForDocumentMarker): Place the dots correctly.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine): The KnownToHaveNoOverflow flag should be cleared if the element has spelling dots,

because there is no guarantee the spelling dots will lie inside the layout rect of the element.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Update the repaint rects to include splling dot positions.

  • rendering/InlineFlowBox.h: Comments should explain why, not say what.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Draw the dots behind the text.
(WebCore::InlineTextBox::hasMarkers const): Convenience.
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Refactor bounds information into a helper function.
(WebCore::InlineTextBox::calculateUnionOfAllDocumentMarkerBounds const): Use for repaint rect calculation.
(WebCore::InlineTextBox::calculateDocumentMarkerBounds const): Place the dots correctly.
(WebCore::InlineTextBox::paintPlatformDocumentMarker): Call the helper method.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers const):
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Deleted.

  • rendering/InlineTextBox.h: Declare the helper methods.
  • rendering/SimpleLineLayout.cpp: Simple line layout doesn't know how to paint spelling dots, so make the presence of

spelling dots opt us out of SLL.

(WebCore::SimpleLineLayout::canUseForWithReason):

  • rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::printReason):

  • rendering/SimpleLineLayoutCoverage.h: Add a new opt-out reason.

Tools:

Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
dots to be drawn.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

  • editing/spelling/resources/VerySmallDescentAhem.ttf: Added. In order to test repaint rects,

this is a version of Ahem with a very small descent, so that the dots don't intersect
with the text itself.

  • editing/spelling/spelling-dots-position-2-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-2.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-3-expected-mismatch.html: Added.
  • editing/spelling/spelling-dots-position-3.html: Added. Make sure dots are painted in the

correct vertical place.

  • editing/spelling/spelling-dots-position-expected.html: Added.
  • editing/spelling/spelling-dots-position.html: Added. Make sure dots are not painted in

the wrong place.

  • editing/spelling/spelling-dots-repaint-expected.html: Added.
  • editing/spelling/spelling-dots-repaint.html: Added. Test repaint by drawing an element

with spelling dots, and then deleting the element from the document. The spelling
dots should be removed too.

  • fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
  • fast/writing-mode/english-bt-text-with-spelling-marker.html: Update the test to compensate

for new spelling dot positions.

3:59 PM Changeset in webkit [237833] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:
3:11 PM Changeset in webkit [237832] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191278

Unreviewed test gardening.

2:03 PM Changeset in webkit [237831] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: turn off Start button when all tests are removed
https://bugs.webkit.org/show_bug.cgi?id=191235

Reviewed by Matt Baker.

  • UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved):

1:38 PM Changeset in webkit [237830] by Chris Dumez
  • 7 edits in trunk

Use same limit for page cache and suspended pages
https://bugs.webkit.org/show_bug.cgi?id=191266

Reviewed by Geoffrey Garen.

Source/WebKit:

Use same limit for page cache and suspended pages as they serve the same purpose.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _maximumSuspendedPageCount]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateMaxSuspendedPageCount):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::addSuspendedPageProxy):

  • UIProcess/WebProcessPool.h:

Tools:

Update API tests accordingly.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
12:43 PM Changeset in webkit [237829] by ajuma@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests/imported/w3c

[IntersectionObserver] Update WPTs to the latest upstream version
https://bugs.webkit.org/show_bug.cgi?id=191274

Reviewed by Simon Fraser.

  • web-platform-tests/intersection-observer/bounding-box-expected.txt:
  • web-platform-tests/intersection-observer/bounding-box.html:
  • web-platform-tests/intersection-observer/target-in-different-window-expected.txt: Added.
  • web-platform-tests/intersection-observer/target-in-different-window.html: Added.
  • web-platform-tests/intersection-observer/w3c-import.log:
12:36 PM Changeset in webkit [237828] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/dom/messageports/MessagePortChannelRegistry.cpp

Another attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:26 PM Changeset in webkit [237827] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Attempted build fix.

  • dom/messageports/MessagePortChannelRegistry.cpp:
12:03 PM Changeset in webkit [237826] by Basuke Suzuki
  • 2 edits in trunk/Tools

[style] Exclude style check for auto generated files.
https://bugs.webkit.org/show_bug.cgi?id=191118

Reviewed by Eric Carlson.

Some files checked in to the repository are generated by other tools. In this patch,
"MiniBrowserLibResource.h" is the file generated and managed by resource editor of
VisualStudio.

There's no need to check these files because it's not practical to fix the style errors
or it's hard to maintain those fixes.

  • Scripts/webkitpy/style/checkers/cpp.py:

(is_generated_file):
(CppChecker.check):

11:58 AM Changeset in webkit [237825] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash under DOMWindow::postMessageTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=191217
<rdar://problem/40888466>

Reviewed by Geoffrey Garen.

Source/WebCore:

Protect the frame in DOMWindow::postMessageTimerFired() before calling dispatchEvent() as dispatching the
event may cause JS to run and this JS may cause the frame to be destroyed, in which case we will crash
when trying to use the frame on the next line.

Test: fast/dom/Window/remove-frame-in-message-event-handler.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/remove-frame-in-message-event-handler-expected.txt: Added.
  • fast/dom/Window/remove-frame-in-message-event-handler.html: Added.
11:38 AM Changeset in webkit [237824] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
https://bugs.webkit.org/show_bug.cgi?id=190680

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

  • flatpak/org.webkit.WebKit.yaml:
11:35 AM Changeset in webkit [237823] by don.olmstead@sony.com
  • 6 edits in trunk/Source/JavaScriptCore

Fix typos in closing ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=191273

Reviewed by Keith Miller.

  • ftl/FTLForOSREntryJITCode.h:
  • ftl/FTLJITCode.h:
  • jsc.cpp:
  • wasm/WasmMemoryInformation.h:
  • wasm/WasmPageCount.h:
11:35 AM Changeset in webkit [237822] by dbates@webkit.org
  • 2 edits in trunk/Tools

[lldb-webkit] Fix formatting nits in Document and Frame summary strings
https://bugs.webkit.org/show_bug.cgi?id=191094

Reviewed by Andy Estes.

Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
Document summary and add closing brace '}' to both Frame and Document summary strings to make
them look pretty.

  • lldb/lldb_webkit.py:

(WebCoreFrame_SummaryProvider):
(WebCoreDocument_SummaryProvider):

11:21 AM Changeset in webkit [237821] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make static_asserts in APICast into bitwise_cast
https://bugs.webkit.org/show_bug.cgi?id=191272

Reviewed by Filip Pizlo.

  • API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

11:18 AM Changeset in webkit [237820] by Wenson Hsieh
  • 6 edits in trunk

[iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
https://bugs.webkit.org/show_bug.cgi?id=191240
<rdar://problem/44872806>

Reviewed by Tim Horton.

Source/WebKit:

Allow WKWebView clients to override WKContentView's default input assistant item by plumbing the call to
-inputAssistantItem through -[WKWebView inputAssistantItem], such that if a client asks WKWebView for its
input assistant item and changes its leading or trailing bar button groups, the changes will be reflected by
WKContentView; additionally, this allows clients to achieve the same effect by overriding -inputAssistantItem
on WKWebView.

Test: KeyboardInputTests.ModifyInputAssistantItemBarButtonGroups

KeyboardInputTests.OverrideInputAssistantItemBarButtonGroups

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView inputAssistantItem]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputAssistantItem]):

Route the call to [super inputAssistantItem] through -[WKWebView inputAssistantItem], so that the input
assistant item may be overridden via WKWebView.

(-[WKContentView inputAssistantItemForWebView]):

Tools:

Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
overriding -[WKWebView inputAssistantItem].

  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
(-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
(+[InputAssistantItemTestingWebView barButtonIcon]):
(+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
(+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
(-[InputAssistantItemTestingWebView inputAssistantItem]):
(TestWebKitAPI::TEST):

11:15 AM Changeset in webkit [237819] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects
https://bugs.webkit.org/show_bug.cgi?id=190035

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

We can't rely on GStreamer timestamps to pass to EncodedImages after encoding
because libWebRTC doesn't use the timestamp we fed it but does
some computation on the input timestamp in the images we pass in before it passes
them back to the encoder. Then internally LibWebRTC relies on those exact timestamps
passed into the encoder to do checks and compute RTP timestamps so we need to carefully
pass the exact timestamps to LibWebRTC (in practice we still use GStreamer timestamps in
all the GStreamer processing pipelines as the WebRTC object basically wraps the "same"
GstSample all around, but we are not synced on the clock anyway).

  • platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:

(WebCore::LibWebRTCVideoFrameFromGStreamerSample):

  • platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h:
  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::newSampleCallback):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::newSampleCallback):

11:12 AM Changeset in webkit [237818] by Wenson Hsieh
  • 6 edits
    2 adds in trunk

[iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
https://bugs.webkit.org/show_bug.cgi?id=191226
<rdar://problem/45781765>

Reviewed by Tim Horton.

Source/WebCore:

When _setViewScale: SPI is used to adjust the layout scale factor of the page, we multiply minimum, initial
and maximum scales by the given layout scale factor to adjust for a larger or smaller minimum layout size.
However, in the case where the layout size scale factor is greater than 1 and we're also forcing the viewport to
be scalable, we override the default minimum scale with 1 (i.e. forceAlwaysUserScalableMinimumScale). This
means that the might be off by a small margin due to rounding error when computing the content width and view
width (see: r237743).

This means that in the case where (1) the viewport is forced to be user-scalable, and (2) we're ignoring meta
viewport parameters, and (3) _viewScale exceeds 1, we may end up computing a slightly different minimum scale
than the default minimum scale multiplied by the layout size scale factor; subsequently, the page scale factor
will be slightly different from initial scale, such that we'll no longer zoom to the new initial scale when
changing view scale.

This patch adjusts forceAlwaysUserScalableMinimumScale and forceAlwaysUserScalableMaximumScale to take the
current layout scale factor into account when computing min and max scales when the viewport is forced to be
always scalable.

Test: fast/viewport/ios/minimum-scale-after-changing-view-scale.html

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::minimumScale const):

  • page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::maximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMaximumScale const):
(WebCore::ViewportConfiguration::forceAlwaysUserScalableMinimumScale const):

Turn these from constant values to const functions on ViewportConfiguration, which factor in the current
viewport layout size scale factor.

Tools:

Add a missing check for shouldIgnoreMetaViewport when comparing TestOptions, to ensure that "ignore meta
viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Add a new layout test that sets the view scale to several values greater than or equal to 1 and verifies that
the minimum scale and resulting scroll view scale are exactly the same as the view scale, when (1) the "ignores
meta viewport" preference is enabled, and (2) the viewport is forced to be always scalable.

  • fast/viewport/ios/minimum-scale-after-changing-view-scale-expected.txt: Added.
  • fast/viewport/ios/minimum-scale-after-changing-view-scale.html: Added.
11:01 AM Changeset in webkit [237817] by Matt Baker
  • 5 edits in trunk

Web Inspector: Table selection should not require that rows be in the cache
https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

  • inspector/table/table-selection-expected.txt:
  • inspector/table/table-selection.html:
10:37 AM Changeset in webkit [237816] by dino@apple.com
  • 6 edits
    1 add in trunk/Source/WebCore

Expose a constructor for PointerEvent from PlatformTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=191238
<rdar://problem/45795682>

Reviewed by Antoine Quint.

Implement a constructor that takes a PlatformTouchEvent to
create a PointerEvent. At the moment the code to call this
constructor will live in WebKitAdditions, so no new tests
yet.

  • SourcesCocoa.txt: Add PointerEventIOS.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/EventNames.h: Add macros for pointerdown, pointermove,

pointerup, pointercancel.

  • dom/PointerEvent.cpp: Remove JSC namespace.
  • dom/PointerEvent.h: Add create and constructor that takes

a PlatformTouchEvent.

  • dom/ios/PointerEventIOS.cpp: Added.
10:09 AM Changeset in webkit [237815] by Alan Coon
  • 9 edits
    2 adds in tags/Safari-607.1.12.2

Cherry-pick r237774. rdar://problem/45377609

Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
  • Configurations/NetworkService.xcconfig: Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process, except with the corresponoding network process entitlements file.
  • UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _networkProcessHasEntitlementForTesting:]):
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):
  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj: Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added. (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [237814] by Alan Coon
  • 4 edits
    1 add in tags/Safari-607.1.12.2

Cherry-pick r237711. rdar://problem/44176965

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

  • loader/ResourceLoadObserver.cpp: (WebCore::ResourceLoadObserver::logSubresourceLoading): (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added. (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]): (-[KeyboardEventListener handleEvent:]): (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:07 AM Changeset in webkit [237813] by Ryan Haddad
  • 17 edits in trunk/Source

Unreviewed, rolling out r237785.

Introduced layout test and API test failures on macOS and iOS.

Reverted changeset:

"[iOS] Issue initial paint soon after the visuallyNonEmpty
milestone is fired."
https://bugs.webkit.org/show_bug.cgi?id=191078
https://trac.webkit.org/changeset/237785

10:03 AM Changeset in webkit [237812] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r237784 and r237788.
https://bugs.webkit.org/show_bug.cgi?id=191270

Caused mediastream layout test failures (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237784

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237788

9:54 AM Changeset in webkit [237811] by Chris Dumez
  • 10 edits
    4 adds in trunk/LayoutTests

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests
https://bugs.webkit.org/show_bug.cgi?id=191214

Reviewed by Geoff Garen.

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests from
upstream c583bcd7eb.

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html: Added.
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.js: Added.

(test.frame.contentWindow.onpagehide):
(test.frame.contentDocument.onvisibilitychange):
(test.frame.contentWindow.onbeforeunload):
(test.frame.contentWindow.onunload):
(test):
(async_test):

  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:
9:47 AM Changeset in webkit [237810] by Lucas Forschler
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

9:43 AM Changeset in webkit [237809] by msaboff@apple.com
  • 2 edits in trunk/JSTests

Unreviewed build fix for linux.

  • stress/regexp-compile-oom.js: Disabled for non-darwin OSes.
9:34 AM Changeset in webkit [237808] by Devin Rousso
  • 12 edits
    1 add in trunk

Web Inspector: show save/restore stack for recorded 2D Canvases
https://bugs.webkit.org/show_bug.cgi?id=175283
<rdar://problem/34040756>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Instead of using plain objects for holding the WI.Recording's state, use a model object
so that more data can be passed around. When visualizing the state, show any previously
saved states in a WI.DetailsSection underneath the current state. If there are no saved
states (meaning there is only the current state), don't use a WI.DetailsSection.

  • UserInterface/Models/RecordingState.js: Added.

(WI.RecordingState):
(WI.RecordingState.fromContext):
(WI.RecordingState.async swizzleInitialState):
(WI.RecordingState.prototype.get source):
(WI.RecordingState.prototype.has):
(WI.RecordingState.prototype.get return):
(WI.RecordingState.prototype.toJSON):
(WI.RecordingState.prototype.[Symbol.iterator]):

  • UserInterface/Models/Recording.js:

(WI.Recording.prototype.async _process):
(WI.Recording.prototype.async _swizzleState): Deleted.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):
(WI.RecordingAction.deriveCurrentState): Deleted.

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement):
(WI.RecordingStateDetailsSidebarPanel.prototype.sizeDidChange): Added.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.isColorProperty): Deleted.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.createInlineSwatch): Deleted.

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.css:

(.sidebar > .panel.details.recording-state > .content .details-section > .header .source): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr.modified): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected).non-standard .name-column): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected) .unavailable): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid .inline-swatch): Added.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected).non-standard): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected) .unavailable): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid .inline-swatch): Deleted.

  • UserInterface/Main.html:
  • UserInterface/Test.html:
  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • inspector/canvas/recording-2d.html:
  • inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.log):
(TestPage.registerInitializer.async logRecording):

9:33 AM Changeset in webkit [237807] by Alan Coon
  • 7 edits in tags/Safari-607.1.12.2/Source

Versioning.

9:27 AM Changeset in webkit [237806] by Alan Coon
  • 1 copy in tags/Safari-607.1.12.2

New tag.

8:45 AM Changeset in webkit [237805] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test runner fails to respect default build type
https://bugs.webkit.org/show_bug.cgi?id=190247

Reviewed by Carlos Garcia Campos.

Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.

  • glib/api_test_runner.py:

(TestRunner.init):

8:16 AM WebKitGTK/2.22.x edited by Michael Catanzaro
(diff)
8:08 AM Changeset in webkit [237804] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer][WebRTC] Error out when simulcast is activated
https://bugs.webkit.org/show_bug.cgi?id=190678

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Implementing it is not for now yet.
Source/WebCore:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::InitEncode):

LayoutTests:

Tests for simulcast have been disabled as they now fail (instead of crashing).

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
8:07 AM Changeset in webkit [237803] by dinfuehr@igalia.com
  • 12 edits in trunk

Enable LLInt on ARMv7/Linux
https://bugs.webkit.org/show_bug.cgi?id=191190

Reviewed by Yusuke Suzuki.

After enabling the new bytecode format in r237547, C_LOOP was
forced on all 32-bit platforms. Now enable LLInt again on
.:

ARMv7-Thumb2/Linux by default.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

ARMv7-Thumb2/Linux.

This adds a callee-saved register in ARMv7/Linux for the metadataTable and
stores/restores it on LLInt function calls. It also introduces the globaladdr-
instruction for the ARM-offlineasm to access the opcode-table.

  • jit/GPRInfo.h:
  • jit/RegisterSet.cpp:

(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • offlineasm/arm.rb:
  • offlineasm/asm.rb:
  • offlineasm/instructions.rb:

Source/WTF:

ARMv7-Thumb2/Linux by default.

  • wtf/Platform.h:
7:32 AM Changeset in webkit [237802] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
https://bugs.webkit.org/show_bug.cgi?id=191241

Reviewed by Eric Carlson.

Moving the logic to observe the audio source to the point where the
RealtimeOutgoingAudioSource subclass is fully initialized.
Covered by existing tests.

  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::observeSource):

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::RealtimeOutgoingAudioSourceLibWebRTC):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):

7:09 AM Changeset in webkit [237801] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
https://bugs.webkit.org/show_bug.cgi?id=190674

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
it can use to implement encoding for different formats exposing a trimmed down unified API.

It also adds proper handling of H264 profiles.

The added files follow GStreamer coding style as we aim at upstreaming the element
in the future.

Source/WebCore:

This is a refactoring so current tests already cover it.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: Added.

(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_bitrate):
(gst_webrtc_video_encoder_set_format):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(setup_x264enc):
(setup_vp8enc):
(setup_openh264enc):
(set_bitrate_kbit_per_sec):
(set_bitrate_bit_per_sec):
(gst_webrtc_video_encoder_class_init):
(gst_webrtc_video_encoder_init):

  • platform/mediastream/libwebrtc/GStreamerVideoEncoder.h: Added.
  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::ImplementationName const):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):

Tools:

Reviewed by Philippe Normand.

  • Scripts/webkitpy/style/checker.py:
7:05 AM Changeset in webkit [237800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
https://bugs.webkit.org/show_bug.cgi?id=190676

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Avoiding to have h264parse make assumption (which might be wrong at some
point).

  • platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:

(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

6:50 AM Changeset in webkit [237799] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Do not sync libwerbtc stream on the clock
https://bugs.webkit.org/show_bug.cgi?id=190677

The approach here is basically to let libwebrtc do all the
synchronisation for us, and the same way as it is done in apple ports,
we basically try to display what libwebrtc outputs as fast as possible.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Manually tested

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::setSyncOnSink):
(WebCore::MediaPlayerPrivateGStreamer::syncOnClock):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
6:47 AM Changeset in webkit [237798] by ajuma@chromium.org
  • 4 edits in trunk

[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

  • web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

  • dom/Document.cpp:

(WebCore::Document::updateIntersectionObservations):

5:55 AM Changeset in webkit [237797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove some virtual methods in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

  • loader/cache/CachedRawResource.h:
4:19 AM Changeset in webkit [237796] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

2:46 AM Changeset in webkit [237795] by Michael Catanzaro
  • 2 edits in trunk/Tools

REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191225

Reviewed by Alejandro G. Castro.

Fix a memory leak causing this test to fail.

  • TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):

2:00 AM Changeset in webkit [237794] by Philippe Normand
  • 7 edits in trunk/Source/WebCore

[GStreamer] Move elements registration to GStreamerCommon
https://bugs.webkit.org/show_bug.cgi?id=191189

Reviewed by Xabier Rodriguez-Calvar.

It was a bit odd to have this in the base player class and to have
sub-classes calling a static function of the super-class.

Covered by existing tests.

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamerAndRegisterWebKitElements):

  • platform/graphics/gstreamer/GStreamerCommon.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

1:34 AM Changeset in webkit [237793] by Fujii Hironori
  • 2 edits in trunk/Source/JavaScriptCore

[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

  • jit/JIT.h: Changed is64BitType from a template class method to a

template inner class.

1:08 AM Changeset in webkit [237792] by zandobersek@gmail.com
  • 10 edits
    14 adds in trunk/LayoutTests

Unreviewed WPE gardening. Updating or adding various baselines. Also
adding new failure expectations for tests that need a closer look.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • platform/wpe/fast/block/basic/height-percentage-simple-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-image-expected.txt: Added.
  • platform/wpe/fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
  • platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • platform/wpe/fast/history: Added.
  • platform/wpe/fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Added.
  • platform/wpe/fast/inline-block/14498-positionForCoordinates-expected.txt:
  • platform/wpe/fast/inline/simple-inline-block-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-float1-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats2-expected.txt: Added.
  • platform/wpe/fast/inline/simple-intruding-floats3-expected.txt: Added.
  • platform/wpe/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/context/context-hidden-alpha-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/get-extension-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-image-data-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:
12:03 AM Changeset in webkit [237791] by Michael Catanzaro
  • 2 edits in trunk

[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

  • Source/cmake/GStreamerDefinitions.cmake:

Nov 4, 2018:

10:50 PM Changeset in webkit [237790] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[webkitpy] Support WPE in the run-web-platform-tests script
https://bugs.webkit.org/show_bug.cgi?id=191183

Reviewed by Alex Christensen.

  • Scripts/webkitpy/w3c/wpt_runner.py:

(parse_args): Support --wpe as an argument that specifies WPE as the
target port. Additionally, the --display-server flag now accepts
headless as a valid value, enabling the WPE WebDriver to run in
headless mode.

8:38 PM Changeset in webkit [237789] by Fujii Hironori
  • 6 edits in trunk

[Win] Use C++14, not C++17
https://bugs.webkit.org/show_bug.cgi?id=191101

Reviewed by Alex Christensen.

.:

Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
<https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>

  • Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.

Source/WTF:

  • wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version

instead of _MSC_FULL_VER.

Tools:

std::basic_string::data() returns a read-only const buffer in
C++14.

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.

8:29 PM Changeset in webkit [237788] by Fujii Hironori
  • 3 edits in trunk/Source/WebKit

[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
  • UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.
6:15 PM Changeset in webkit [237787] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::applyAll): Deleted.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

1:19 PM Changeset in webkit [237786] by Wenson Hsieh
  • 6 edits in trunk/Tools

[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=191231

Reviewed by Simon Fraser.

Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
it can be shared between iOS-family and macOS platforms. See below for more details.

No change in behavior.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::overridePreference):

Add a method stub for DumpRenderTree.

  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:
  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):

Unify these method implementations.

(WTR::UIScriptController::removeViewFromWindow):
(WTR::UIScriptController::addViewToWindow):

Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.

(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::findString):
(WTR::UIScriptController::contentsOfUserInterfaceItem const):

Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::overridePreference): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.

8:38 AM Changeset in webkit [237785] by Alan Bujtas
  • 17 edits in trunk/Source

[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

  1. Improve visuallyNonEmpty milestone confidence level.

Ignore whitespace and non visible text content.
Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
Check if the html/body is actually visible.

  1. Issue initial paint soon after the milestone fires.

Use a 0ms timer to flush the initial paint.
Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling)

  1. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint.
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.

  • platform/graphics/FontCascade.h:
  • rendering/RenderText.cpp: Check whether the text is actually visible at this point.

(WebCore::RenderText::RenderText):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):

  • WebProcess/WebPage/AcceleratedDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

8:04 AM Changeset in webkit [237784] by eric.carlson@apple.com
  • 5 edits in trunk

[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

7:46 AM Changeset in webkit [237783] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][BFC] Add support for percentage height in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=191232

Reviewed by Antti Koivisto.

Source/WebCore:

In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.

Test: fast/block/basic/quirk-mode-percent-height.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):

  • layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
  • fast/block/basic/quirk-mode-percent-height.html: Added.
  • platform/ios/TestExpectations:
7:44 AM Changeset in webkit [237782] by Alan Bujtas
  • 8 edits
    2 adds in trunk

[LFC][BCF] Add support for block level non-replaced inflow height percentage
https://bugs.webkit.org/show_bug.cgi?id=191229

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/basic/child-block-level-box-with-height-percent.html

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
  • fast/block/basic/child-block-level-box-with-height-percent.html: Added.
  • platform/ios/TestExpectations:
7:30 AM Changeset in webkit [237781] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource should use DestructionThread::Main
https://bugs.webkit.org/show_bug.cgi?id=191230

Reviewed by Eric Carlson.

Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
7:05 AM Changeset in webkit [237780] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore

[GTK] Cannot make debug builds of JSC using release 2.22.3
https://bugs.webkit.org/show_bug.cgi?id=191233

Unreviewed build fix.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
Use context.asStructureForInContext() instead of explicit cast and
remove the unneeded assertion, which is already done in the helper
function.

2:28 AM Changeset in webkit [237779] by youenn@apple.com
  • 10 edits
    3 adds in trunk

IDB should allow storing RTCCertificate
https://bugs.webkit.org/show_bug.cgi?id=191077

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added.
  • web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added.

Source/WebCore:

Add support for serialization/deserialization of RTCCertificate.
Store the origin in RTCCertificate and make sure that a certificate
with a different origin cannot be used to create a RTCPeerConnection.

Test: imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::generateCertificate):

  • Modules/mediastream/RTCCertificate.cpp:

(WebCore::RTCCertificate::create):
(WebCore::RTCCertificate::RTCCertificate):

  • Modules/mediastream/RTCCertificate.h:

(WebCore::RTCCertificate::origin const):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::certificatesFromConfiguration):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:

(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):

  • Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::CachedString::takeString):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

12:55 AM Changeset in webkit [237778] by youenn@apple.com
  • 11 edits
    1 add in trunk

Add support for RTCMuxPolicy
https://bugs.webkit.org/show_bug.cgi?id=191188

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt:
  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/WebCore:

Add support for RTCMuxPolicy dictionary option for both constructor and setConfiguration.
Make sure setConfiguration throws if trying to change this policy.
Pipe this parameter up to libwebrtc.
Covered by rebased test.

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::rtcpMuxPolicyfromConfiguration):
(WebCore::configurationFromMediaEndpointConfiguration):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mediastream/RTCPMuxPolicy.h: Added.

Nov 3, 2018:

4:24 PM Changeset in webkit [237777] by Devin Rousso
  • 19 edits in trunk

Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context
https://bugs.webkit.org/show_bug.cgi?id=190854

Reviewed by Matt Baker.

Source/WebCore:

Updated existing tests: inspector/canvas/recording-2d.html

inspector/canvas/recording-bitmaprenderer.html
inspector/canvas/recording-webgl.html

  • html/HTMLCanvasElement.idl:

Apply CallTracingCallback=recordCanvasAction to the width and height attributes so
that they are recorded through the same path as CanvasRenderingContext.

  • html/CanvasBase.h:
  • html/CanvasBase.cpp:

(WebCore::CanvasBase::callTracingActive const): Added.

  • bindings/js/CallTracer.h:
  • bindings/js/CallTracer.cpp:

(WebCore::CallTracer::recordCanvasAction):

Source/WebInspectorUI:

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction.prototype.get contextReplacer): Added.
(WI.RecordingAction.prototype.async.swizzle):
(WI.RecordingAction.prototype.apply):
Create a constant list of actions for each recording type that need to replace the context
with a different value before being applied (e.g. width should be applied to the
context's canvas instead of directly to the context).

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D.actionModifiesPath): Added.
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView._actionModifiesPath): Deleted.
Generate the path context after the actions are applied to the preview context so that the
final width/height are known and can be used. This is needed because changing the
width/height causes the content to be erased.

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._classNameForAction):

  • UserInterface/Views/RecordingActionTreeElement.css:

(.tree-outline:focus .item.action.selected:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.item.action > .titles .context-replacer::after): Added.
(.item.action.has-context-replacer > .icon): Added.
(@media (prefers-dark-interface) .item.action:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.tree-outline:focus .item.action.selected:not(.initial-state, .invalid) > .icon): Deleted.
(@media (prefers-dark-interface) .item.action:not(.initial-state) > .icon): Deleted.
(@media (prefers-dark-interface) .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon): Deleted.
Add the context replacer text to the beginning of the action's name if it exists.

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._refreshPixelSize):
(WI.CanvasContentView.prototype._updatePixelSize): Deleted.
Update preview image when the canvas' size changes.

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:
  • inspector/canvas/recording-bitmaprenderer-expected.txt:
  • inspector/canvas/recording-bitmaprenderer.html:
  • inspector/canvas/recording-webgl-expected.txt:
  • inspector/canvas/recording-webgl.html:
11:45 AM Changeset in webkit [237776] by aestes@apple.com
  • 5 edits in trunk

[Payment Request] PaymentResponse.retry()'s errorFields should be optional
https://bugs.webkit.org/show_bug.cgi?id=191212

Reviewed by Youenn Fablet.

Source/WebCore:

Per WebIDL, the errorFields argument to PaymentResponse.retry() should be optional. See
<https://github.com/w3c/payment-request/issues/804> for details.

Added test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

  • Modules/paymentrequest/PaymentResponse.idl:

LayoutTests:

  • http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
  • http/tests/paymentrequest/payment-response-retry-method.https.html:
10:57 AM Changeset in webkit [237775] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][BFC] Resolve percentage height values.
https://bugs.webkit.org/show_bug.cgi?id=191224

Reviewed by Antti Koivisto.

Source/WebCore:

10.5 Content height: the 'height' property
The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height),
and this element is not absolutely positioned, the used height is calculated as if 'auto' was specified.

https://www.w3.org/TR/CSS22/visudet.html#propdef-height

Test: fast/block/basic/height-percentage-simple.html

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::isHeightAuto):
(WebCore::Layout::computedHeightValue):
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/block/basic/height-percentage-simple-expected.txt: Added.
  • fast/block/basic/height-percentage-simple.html: Added.
  • platform/ios/TestExpectations:
8:22 AM Changeset in webkit [237774] by achristensen@apple.com
  • 9 edits
    2 adds in trunk

Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
  • Configurations/NetworkService.xcconfig:

Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):

  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj:

Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.

(TEST):

7:57 AM Changeset in webkit [237773] by youenn@apple.com
  • 88 edits
    2 copies
    4 moves
    43 adds
    3 deletes in trunk/LayoutTests

Refresh WPT webrtc tests
https://bugs.webkit.org/show_bug.cgi?id=191133

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/: Refreshed.
  • web-platform-tests/webrtc/w3c-import.log:

LayoutTests:

7:29 AM Changeset in webkit [237772] by Philippe Normand
  • 2 edits in trunk/Source/WebKit

[WPE] Add the WebKitVersion.h header
https://bugs.webkit.org/show_bug.cgi?id=191015
<rdar://problem/45647211>

Reviewed by Michael Catanzaro.

  • PlatformWPE.cmake: Install the generated header as well.
7:04 AM Changeset in webkit [237771] by Michael Catanzaro
  • 2 edits in trunk/WebDriverTests

Unreviewed, fix WebDriver expectations syntax after previous commit

6:30 AM Changeset in webkit [237770] by eric.carlson@apple.com
  • 9 edits
    3 adds in trunk

[MediaStream] enumerateDevices should not expose devices that are not available to getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=191177
<rdar://problem/45747873>

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html

  • Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start): Only expose devices that are available to gUM.

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::isSecure): Moved from UserMediaRequest.cpp.
(WebCore::isAllowedToUse): Ditto.
(WebCore::UserMediaController::canCallGetUserMedia): Modified from UserMediaRequest.cpp.
(WebCore::UserMediaController::logGetUserMediaDenial): Log reason for denial.

  • Modules/mediastream/UserMediaController.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start): Use UserMediaController::canCallGetUserMedia.
(WebCore::isSecure): Deleted.
(WebCore::isAllowedToUse): Deleted.
(WebCore::canCallGetUserMedia): Deleted.

LayoutTests:

  • http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt: Added.
  • http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html: Added.
  • http/tests/media/media-stream/resources/enumerate-devices-iframe.html: Added.
  • http/tests/ssl/media-stream/get-user-media-different-host-expected.txt: Rebased for updated logging.
  • http/tests/ssl/media-stream/get-user-media-nested-expected.txt: Ditto.

Nov 2, 2018:

11:25 PM Changeset in webkit [237769] by achristensen@apple.com
  • 8 edits
    1 delete in trunk

Unreviewed, rolling out r237761.

Makes most API tests timeout and WK2 tests crash

Reverted changeset:

"Mac production builds should sign the network process xpc
service with entitlements"
https://bugs.webkit.org/show_bug.cgi?id=191209
https://trac.webkit.org/changeset/237761

10:53 PM Changeset in webkit [237768] by Michael Catanzaro
  • 2 edits in trunk/WebDriverTests

Unreviewed WebDriver expectations gardening

There are still a few more flaky tests, but this should improve things significantly.

10:27 PM Changeset in webkit [237767] by Michael Catanzaro
  • 2 edits in trunk/Tools

Unreviewed API test gardening

  • TestWebKitAPI/glib/TestExpectations.json:
9:01 PM Changeset in webkit [237766] by Justin Michaud
  • 30 edits
    5 copies
    3 moves
    15 adds
    2 deletes in trunk

Add new global object and preliminary Worklets support for CSS painting api
https://bugs.webkit.org/show_bug.cgi?id=190979

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/css-custom-paint/worklet.html

Add a new ScriptExecutionContext and global object to run worklets in. This is mostly copy+paste
from Workers, but without any of the threading. Worklet.addModule does not yet support loading scripts
or doing cross origin checking. There are quite a few parts of the ScriptExecutionContext api that are
left as ASSERT_NOT_REACHED().

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::scriptExecutionContext const):

  • bindings/js/JSPaintWorkletGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSCSSPaintWorkletGlobalScopeCustom.cpp.

(WebCore::JSPaintWorkletGlobalScope::visitAdditionalChildren):
(WebCore::JSPaintWorkletGlobalScope::registerPaint):

  • bindings/js/JSWorkletGlobalScopeBase.cpp: Added.

(WebCore::JSWorkletGlobalScopeBase::JSWorkletGlobalScopeBase):
(WebCore::JSWorkletGlobalScopeBase::finishCreation):
(WebCore::JSWorkletGlobalScopeBase::clearDOMGuardedObjects):
(WebCore::JSWorkletGlobalScopeBase::visitChildren):
(WebCore::JSWorkletGlobalScopeBase::destroy):
(WebCore::JSWorkletGlobalScopeBase::scriptExecutionContext const):
(WebCore::JSWorkletGlobalScopeBase::supportsRichSourceInfo):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScript):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSWorkletGlobalScopeBase::javaScriptRuntimeFlags):
(WebCore::toJS):
(WebCore::toJSWorkletGlobalScope):

  • bindings/js/JSWorkletGlobalScopeBase.h: Added.

(WebCore::JSWorkletGlobalScopeBase::wrapped const):
(WebCore::JSWorkletGlobalScopeBase::proxy const):
(WebCore::JSWorkletGlobalScopeBase::createStructure):
(WebCore::toJS):

  • bindings/js/ScriptState.cpp:

(WebCore::execStateFromWorkerGlobalScope):
(WebCore::execStateFromWorkletGlobalScope):

  • bindings/js/ScriptState.h:
  • bindings/js/WebCoreBuiltinNames.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(IsDOMGlobalObject):
(ShouldUseGlobalObjectPrototype):
(GenerateHeader):
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateImplementation):

  • bindings/scripts/preprocess-idls.pl:
  • css/CSSPaintImageValue.cpp:

(WebCore::CSSPaintImageValue::image):

  • css/DOMCSSPaintWorklet.cpp:

(WebCore::DOMCSSPaintWorklet::ensurePaintWorklet):
(WebCore::DOMCSSPaintWorklet::ensurePaintWorkletGlobalScope): Deleted.

  • css/DOMCSSPaintWorklet.h:
  • css/DOMCSSPaintWorklet.idl:
  • dom/Document.cpp:

(WebCore::Document::ensureCSSPaintWorklet):
(WebCore::Document::setCSSPaintWorkletGlobalScope):
(WebCore::Document::ensureCSSPaintWorkletGlobalScope): Deleted.

  • dom/Document.h:

(WebCore::Document::getCSSPaintWorkletGlobalScope):

  • dom/EventTargetFactory.in:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::vm):
(WebCore::ScriptExecutionContext::execState):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isWorkletGlobalScope const):

  • inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

  • inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

  • platform/graphics/CustomPaintImage.cpp:

(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):

  • platform/graphics/CustomPaintImage.h:
  • worklets/PaintWorkletGlobalScope.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.

(WebCore::PaintWorkletGlobalScope::create):
(WebCore::PaintWorkletGlobalScope::PaintWorkletGlobalScope):
(WebCore::PaintWorkletGlobalScope::devicePixelRatio):
(WebCore::PaintWorkletGlobalScope::addRegisteredPaint):

  • worklets/PaintWorkletGlobalScope.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.h.
  • worklets/PaintWorkletGlobalScope.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
  • worklets/Worklet.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.

(WebCore::Worklet::create):
(WebCore::Worklet::Worklet):
(WebCore::Worklet::addModule):

  • worklets/Worklet.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.
  • worklets/Worklet.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
  • worklets/WorkletConsoleClient.cpp: Copied from Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp.

(WebCore::WorkletConsoleClient::WorkletConsoleClient):
(WebCore::WorkletConsoleClient::messageWithTypeAndLevel):
(WebCore::WorkletConsoleClient::count):
(WebCore::WorkletConsoleClient::time):
(WebCore::WorkletConsoleClient::timeEnd):
(WebCore::WorkletConsoleClient::profile):
(WebCore::WorkletConsoleClient::profileEnd):
(WebCore::WorkletConsoleClient::takeHeapSnapshot):
(WebCore::WorkletConsoleClient::timeStamp):
(WebCore::WorkletConsoleClient::record):
(WebCore::WorkletConsoleClient::recordEnd):

  • worklets/WorkletConsoleClient.h: Added.
  • worklets/WorkletGlobalScope.cpp: Added.

(WebCore::WorkletGlobalScope::WorkletGlobalScope):
(WebCore::WorkletGlobalScope::~WorkletGlobalScope):
(WebCore::WorkletGlobalScope::evaluate):
(WebCore::WorkletGlobalScope::isJSExecutionForbidden const):
(WebCore::WorkletGlobalScope::disableEval):
(WebCore::WorkletGlobalScope::disableWebAssembly):
(WebCore::WorkletGlobalScope::completeURL const):
(WebCore::WorkletGlobalScope::logExceptionToConsole):
(WebCore::WorkletGlobalScope::addConsoleMessage):
(WebCore::WorkletGlobalScope::addMessage):

  • worklets/WorkletGlobalScope.h: Added.

(WebCore::WorkletGlobalScope::isPaintWorkletGlobalScope const):
(WebCore::WorkletGlobalScope::identifier const):
(WebCore::WorkletGlobalScope::script):
(WebCore::WorkletGlobalScope::jsRuntimeFlags const):
(isType):

  • worklets/WorkletGlobalScope.idl: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
  • worklets/WorkletScriptController.cpp: Added.

(WebCore::WorkletScriptController::WorkletScriptController):
(WebCore::WorkletScriptController::~WorkletScriptController):
(WebCore::WorkletScriptController::forbidExecution):
(WebCore::WorkletScriptController::isExecutionForbidden const):
(WebCore::WorkletScriptController::disableEval):
(WebCore::WorkletScriptController::disableWebAssembly):
(WebCore::WorkletScriptController::initScriptWithSubclass):
(WebCore::WorkletScriptController::initScript):
(WebCore::WorkletScriptController::evaluate):
(WebCore::WorkletScriptController::setException):

  • worklets/WorkletScriptController.h: Added.

(WebCore::WorkletScriptController::workletGlobalScopeWrapper):
(WebCore::WorkletScriptController::vm):
(WebCore::WorkletScriptController::initScriptIfNeeded):

Tools:

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

LayoutTests:

Add a new test harness for worklet tests, since they do not have access to the dom.

  • fast/css-custom-paint/basic-expected.txt:
  • fast/css-custom-paint/basic.html:
  • fast/css-custom-paint/registerPaintBindings-expected.html: Added.
  • fast/css-custom-paint/registerPaintBindings-expected.txt: Removed.
  • fast/css-custom-paint/registerPaintBindings.html:
  • fast/css-custom-paint/resources/testharness-worklet.js: Added.

(format_value):

  • fast/css-custom-paint/resources/testharness.js: Added.

(async.importWorklet):

  • fast/css-custom-paint/worklet-expected.html: Added.
  • fast/css-custom-paint/worklet.html: Added.
7:36 PM Changeset in webkit [237765] by mmaxfield@apple.com
  • 27 edits in trunk/Source/WebCore

Clean up drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=191215

Reviewed by Zalan Bujtas.

In preparation for https://bugs.webkit.org/show_bug.cgi?id=190764, I need to do a little bit of refactoring.
This patch has no behavior change; it just does the following:

  1. Renames drawLineForDocumentMarker() to drawDotsForDocumentMarker(), because 2 of the 3 implementations draw dots
  2. Moves our implementation back into GraphicsContext, because it's simpler and GraphicsContext is already platform-

specific.

  1. The signature used to accept a location and a width, but without a height, it's difficult to know what the bounding

box is. In particular, knowing the bounding box must be possible without a GraphicsContext. So, I've modified
the signature to accept a rectangle instead. The GraphicsContext draws only within this rectangle.

No new tests because there is no behavior change.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextImpl.h:
  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawDotsForDocumentMarker):
(WebCore::Cairo::drawLineForDocumentMarker): Deleted.

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

  • platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawDotsForDocumentMarker):
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker): Deleted.

  • platform/graphics/cairo/GraphicsContextImplCairo.h:
  • platform/graphics/cocoa/FontCascadeCocoa.mm:
  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle):
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::DrawDotsForDocumentMarker::apply const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::localBounds const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawLineForDocumentMarker::apply const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::localBounds const): Deleted.

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawDotsForDocumentMarker::create):
(WebCore::DisplayList::DrawDotsForDocumentMarker::rect const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::DrawDotsForDocumentMarker):
(WebCore::DisplayList::DrawLineForDocumentMarker::create): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::point const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::width const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::DrawLineForDocumentMarker): Deleted.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawDotsForDocumentMarker):
(WebCore::DisplayList::Recorder::drawLineForDocumentMarker): Deleted.

  • platform/graphics/displaylists/DisplayListRecorder.h:
  • platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawDotsForDocumentMarker):
(Nicosia::CairoOperationRecorder::drawLineForDocumentMarker): Deleted.

  • platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintPlatformDocumentMarker):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::drawLineForDocumentMarker): Deleted.

  • rendering/RenderTheme.h:
  • rendering/RenderThemeCocoa.h:
  • rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::drawLineForDocumentMarker): Deleted.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::colorForMarkerLineStyle): Deleted.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::colorForMarkerLineStyle): Deleted.

6:52 PM Changeset in webkit [237764] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Assert JSValues can fit into a pointer when API casting
https://bugs.webkit.org/show_bug.cgi?id=191220

Reviewed by Michael Saboff.

  • API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

6:27 PM Changeset in webkit [237763] by msaboff@apple.com
  • 7 edits
    1 add in trunk

Rolling in r237753 with unreviewed build fix.

Fixed issues with DECLARE_THROW_SCOPE placement.

5:49 PM Changeset in webkit [237762] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, attempt to fix the build with recent SDKs.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceExit):

5:33 PM Changeset in webkit [237761] by achristensen@apple.com
  • 8 edits
    1 add in trunk

Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

  • Configurations/NetworkService.xcconfig:

Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):

  • UIProcess/WebProcessPool.h:

Add infrastructure to test that the network process actually has an entitlement.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.

(TEST):

5:06 PM Changeset in webkit [237760] by Chris Dumez
  • 3 edits in trunk/LayoutTests

REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=191199

Reviewed by Dewei Zhu.

Navigate the subframe instead of the main frame, to make sure that the console message is consistently logged.

  • http/tests/security/anchor-download-block-crossorigin-expected.txt:
  • http/tests/security/anchor-download-block-crossorigin.html:
4:33 PM Changeset in webkit [237759] by Kocsen Chung
  • 24 edits in tags/Safari-607.1.12.1

Apply patch. rdar://problem/45749094
https://bugs.webkit.org/show_bug.cgi?id=191201

4:20 PM Changeset in webkit [237758] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Follow-up fix for the webkit.org blog index page
https://bugs.webkit.org/show_bug.cgi?id=191216

Reviewed by Timothy Hatcher.

  • wp-content/themes/webkit/index.php:
3:47 PM Changeset in webkit [237757] by Ryan Haddad
  • 7 edits
    1 delete in trunk

Unreviewed, rolling out r237753.

Introduced JSC test failures

Reverted changeset:

"Running out of stack space not properly handled in
RegExp::compile() and its callers"
https://bugs.webkit.org/show_bug.cgi?id=191206
https://trac.webkit.org/changeset/237753

3:46 PM Changeset in webkit [237756] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

  • platform/win/TestExpectations:
3:35 PM Changeset in webkit [237755] by Lucas Forschler
  • 2 edits in trunk/Tools

Add Windows 10 archive bots
https://bugs.webkit.org/show_bug.cgi?id=190964

This Change updates the Apple Windows Buildbot configuration.

  • Add Windows 10 specific builders and testers for release and debug.
  • Refactor Windows -> Windows 7.
  • Remove Windows 7 Debug.

Reviewed by Aakash Jain.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:07 PM Changeset in webkit [237754] by ajuma@chromium.org
  • 3 edits in trunk/Source/WebCore

requestAnimationFrame causes bad location of position:fixed inside overflow:auto and iframe
https://bugs.webkit.org/show_bug.cgi?id=176243

Reviewed by Simon Fraser.

When a new layer tree is committed to the UIProcess, the positions of layers for fixed
or sticky nodes in the newly-committed tree can be stale, because of scrolling that has
happened in the UIProcess since the tree was updated in the WebProcess. To handle this,
RemoteLayerTreeDrawingAreaProxy::commitLayerTree updates the positions of these layers
by calling RemoteScrollingCoordinatorProxy::viewportChangedViaDelegatedScrolling, which
leads to a recursive traversal of the ScrollingTree to update each such layer. However,
since ScrollingTreeFrameScrollingNodeIOS didn't implement updateLayersAfterAncestorChange,
this traversal never descended into scrolling nodes within an iframe, so the layers for
these nodes were left with stale positions.

Implement ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange so that
fixed and sticky layers within an iframe do get their positions updated when a new layer
tree is committed.

  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange):

3:05 PM Changeset in webkit [237753] by msaboff@apple.com
  • 7 edits
    1 add in trunk

Running out of stack space not properly handled in RegExp::compile() and its callers
https://bugs.webkit.org/show_bug.cgi?id=191206

Reviewed by Filip Pizlo.

JSTests:

New regression test.

  • stress/regexp-compile-oom.js: Added.

(recurseAndTest):

Source/JavaScriptCore:

Eliminated two RELEASE_ASSERT_NOT_REACHED() for errors returned by Yarr parsing code. Bubbled those errors
up to where they are turned into the appropriate exceptions in matchInline(). If the errors are not due
to syntax, we reset the RegExp state in case the parsing is tried with a smaller stack.

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

  • runtime/RegExp.h:
  • runtime/RegExpInlines.h:

(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::matchInline):
(JSC::RegExp::compileIfNecessaryMatchOnly):

  • runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::execInline):

  • yarr/YarrErrorCode.h:

(JSC::Yarr::hasHardError):

2:43 PM Changeset in webkit [237752] by Jon Davis
  • 9 edits in trunk/Websites/webkit.org

Improved the SVG icons to use SVG symbols
https://bugs.webkit.org/show_bug.cgi?id=191205

Reviewed by Timothy Hatcher.

This change makes it far easier to add new SVG icons to the
icons.svg sprite and provides better positioning control
over the icons within the blog post tile frame.

  • wp-content/themes/webkit/front-page.php:
  • wp-content/themes/webkit/functions.php:
  • wp-content/themes/webkit/header.php:
  • wp-content/themes/webkit/images/icons.svg:
  • wp-content/themes/webkit/index.php:
  • wp-content/themes/webkit/loop.php:
  • wp-content/themes/webkit/style.css:

(@supports ( -webkit-backdrop-filter: blur(10px) )):
(footer):
(#icons):
(.tile .background-image):
(.tile .background-image svg):
(.tile.category-web-inspector svg):
(.tile.category-performance svg):
(.tile.category-javascript svg):
(.tile.category-css svg):
(.tile.category-standards svg):
(.tile.category-contributing svg):
(.tile.category-storage svg):
(.tile.category-layout svg):
(.tile.category-safari-technology-preview svg):
(.tile.category-accessibility svg):
(.tile.category-security svg):
(.tile.category-privacy svg):
(header .menu-item-has-children .label-toggle::after):
(@media only screen and (max-width: 920px)):
(.main-menu.label-toggle):
(header .menu):
(@media only screen and (max-width: 690px)):
(@media only screen and (max-width: 415px)):
(@media only screen and (max-height: 415px)):
(.tile.category-web-inspector .background-image): Deleted.
(.tile.category-performance .background-image): Deleted.
(.tile.category-javascript .background-image): Deleted.
(.tile.category-css .background-image): Deleted.
(.tile.category-standards .background-image): Deleted.
(.tile.category-contributing .background-image): Deleted.
(.tile.category-storage .background-image): Deleted.
(.tile.category-layout .background-image): Deleted.
(.tile.category-safari-technology-preview .background-image): Deleted.
(.tile.category-accessibility .background-image): Deleted.
(.tile.tag-console .background-image,): Deleted.
(.tile.tag-console .background-image): Deleted.
(.tile.tag-debugger .background-image): Deleted.
(.tile.tag-shortcuts .background-image): Deleted.
(.tile.tag-timeline .background-image): Deleted.

  • wp-content/themes/webkit/widgets/post.php:
1:38 PM Changeset in webkit [237751] by bshafiei@apple.com
  • 2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Cherry-pick r237745. rdar://problem/45765887

API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203

Reviewed by Filip Pizlo.

  • API/APICast.h: (toJS): (toJSForGC): (toRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:33 PM Changeset in webkit [237750] by bshafiei@apple.com
  • 125 edits
    4 adds
    29 deletes in tags/Safari-607.1.12.1

Revert r237547. rdar://problem/45767917

1:33 PM Changeset in webkit [237749] by bshafiei@apple.com
  • 3 edits
    1 delete in tags/Safari-607.1.12.1

Revert r237553. rdar://problem/45768563

1:33 PM Changeset in webkit [237748] by bshafiei@apple.com
  • 2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Revert r237576. rdar://problem/45767917

1:33 PM Changeset in webkit [237747] by bshafiei@apple.com
  • 6 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Revert r237627. rdar://problem/45771226

12:39 PM Changeset in webkit [237746] by Matt Baker
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: support multiple selection/deletion of cookie records
https://bugs.webkit.org/show_bug.cgi?id=66381
<rdar://problem/19281525>

Reviewed by Devin Rousso.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CookieStorageContentView.js:

(WI.CookieStorageContentView):
(WI.CookieStorageContentView.prototype.get scrollableElements):
(WI.CookieStorageContentView.prototype.tableNumberOfRows):
(WI.CookieStorageContentView.prototype.tableSortChanged):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
(WI.CookieStorageContentView.prototype.tableDidRemoveRows):
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype.initialLayout):
(WI.CookieStorageContentView.prototype._generateSortComparator):
(WI.CookieStorageContentView.prototype._refreshButtonClicked):
(WI.CookieStorageContentView.prototype._reloadCookies):
(WI.CookieStorageContentView.prototype._updateSort):
(WI.CookieStorageContentView.prototype._handleTableKeyDown):
(WI.CookieStorageContentView.prototype.update): Deleted.
(WI.CookieStorageContentView.prototype._rebuildTable): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.localeCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.numberCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.expiresCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid): Deleted.
(WI.CookieStorageContentView.prototype._deleteCallback): Deleted.
Replace DataGrid with Table. The content view serves as the table
delegate and data source, and handles delete and backspace key events
to allow deleting the selected cookies. Cookies may also be deleted from
the table context menu and a new button in the navigation bar.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.isRowSelected):
(WI.Table.prototype.selectRow):
(WI.Table.prototype.deselectRow):
(WI.Table.prototype.removeRow):
(WI.Table.prototype._getOrCreateRow):
(WI.Table.prototype._handleMouseDown):
(WI.Table.prototype._removeRows):
(WI.Table.prototype._isRowSelected): Deleted.
Make isSelectedRow public. It is more convenient and efficient than
calling Table.prototype.selectedRows.includes(rowIndex).

12:03 PM Changeset in webkit [237745] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203

Reviewed by Filip Pizlo.

  • API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

11:31 AM Changeset in webkit [237744] by Alan Coon
  • 11 edits
    1 delete in tags/Safari-607.1.12.1/Source

Cherry-pick r237721. rdar://problem/45722391

Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

  • bmalloc/CryptoRandom.cpp: (bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

  • crypto/CommonCryptoUtilities.h:
  • crypto/mac/CryptoKeyMac.cpp: (WebCore::CryptoKey::randomData):
  • crypto/mac/SerializedCryptoKeyWrapMac.mm: (WebCore::createAndStoreMasterKey): (WebCore::wrapSerializedCryptoKey):
  • page/Crypto.cpp: (WebCore::Crypto::getRandomValues):

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/RandomDevice.cpp: (WTF::RandomDevice::cryptographicallyRandomValues):
  • wtf/spi/darwin/CommonCryptoSPI.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:10 AM Changeset in webkit [237743] by Wenson Hsieh
  • 7 edits
    2 adds in trunk

[iOS] Changing view scale sometimes does not zoom the page to the new initial scale, when the page is at initial scale
https://bugs.webkit.org/show_bug.cgi?id=191180
<rdar://problem/45744786>

Reviewed by Simon Fraser.

Source/WebCore:

When computing the minimum scale in ViewportConfiguration::minimumScale, if our content width or height is
shorter than the view width or height, then we recompute the minimum scale such that the content dimensions will
fill the bounds of the view by setting the minimum scale to the view width or height divided by the content
width or height.

Suppose the minimum scale is equal to some value s; additionally, let w_c denote the content width and w_v
denote the view width (as integers). If w_v / s is not an integral value, the computed content width w_c may
be rounded, such that w_v / w_c is not precisely equal to s. In the case that w_v / w_c is ever so
slightly larger than s, we will end up overriding the minimum scale s with w_v / w_c.

As a result, specifying a viewport with a decimal minimum-scale will sometimes cause the computed minimum
scale of the viewport (and platform view) to be very slightly different from the minimum scale. The new layout
test below exercises this scenario, specifying a viewport with minimum and initial scales of 0.94 that results
in ViewportConfiguration::minimumScale returning 0.94158.

With the WebPage::setViewportConfigurationViewLayoutSize check added in r237127, this means setting
_viewScale: when the page is at initial scale sometimes doesn't zoom the page to the new initial scale when it
should, since the page scale factor and the initial scale are different enough such that
areEssentiallyEqualAsFloat returns false.

This patch addresses these issues by snapping to the minimum scale if the computed scale that fits content
dimensions to view dimensions results in a minimum scale that is close enough to the configuration's minimum
scale, such that the difference can be attributed to rounding error when computing content or view dimensions.

Test: fast/viewport/ios/viewport-minimum-and-initial-scale.html

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::minimumScale const):

LayoutTests:

Add a layout test, and make some adjustments to UIHelper.

  • fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html:
  • fast/viewport/ios/device-width-viewport-after-changing-view-scale.html:
  • fast/viewport/ios/viewport-minimum-and-initial-scale-expected.txt: Added.
  • fast/viewport/ios/viewport-minimum-and-initial-scale.html: Added.

Add a new layout test that contains a viewport meta tag with minimum and initial scales set to 0.94, and checks
that the resulting minimum and initial scales are 0.94 instead of 0.94158.

  • fast/viewport/watchos/viewport-disable-extra-zoom-adaptations.html:
  • resources/ui-helper.js:

Make UIHelper.zoomScale return a number rather than a string, and adjust a few call sites.

(window.UIHelper.zoomScale):
(window.UIHelper.minimumZoomScale):
(window.UIHelper):

10:45 AM Changeset in webkit [237742] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Unreviewed, another --no-video --no-web-audio build fix following r237677

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::addEventListenersToNode):

10:42 AM Changeset in webkit [237741] by Philippe Normand
  • 3 edits in trunk/Tools

[GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through

Rubber-stamped by Michael Catanzaro.

This variable is useful to get rid of shell color escapes in tests stderr files.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

  • Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server):

10:35 AM Changeset in webkit [237740] by aakash_jain@apple.com
  • 1 edit
    20 adds in trunk/Tools

Add Basic Django web app for OpenSource EWS
https://bugs.webkit.org/show_bug.cgi?id=191091

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/EWS_app/init.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/ews/init.py: Added.
  • BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/ews/migrations/init.py: Added.
  • BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
  • BuildSlaveSupport/EWS_app/ews/models/init.py: Added.
  • BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
  • BuildSlaveSupport/EWS_app/ews/views/init.py: Added.
  • BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
10:20 AM Changeset in webkit [237739] by dbates@webkit.org
  • 4 edits in trunk/Source/WebCore

[iOS] Normalize character string based on key code
https://bugs.webkit.org/show_bug.cgi?id=191120

Reviewed by Tim Horton.

Source/WebCore:

Following r236417 (https://bugs.webkit.org/show_bug.cgi?id=189604) we always have a valid key code
for a special key (e.g. page up) and can simplify the character string normalization code.

No functionality changed. So, no new tests.

  • platform/ios/WebEvent.mm:

(normalizedStringWithAppKitCompatibilityMapping): Modified to take a key code and wrote algorithm
in terms of it.

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Pass the key code for the event to normalizedStringWithAppKitCompatibilityMapping().

Source/WebCore/PAL:

Remove forward declarations that are no longer needed now that we check key code.

  • pal/spi/ios/UIKitSPI.h:
10:17 AM Changeset in webkit [237738] by dbates@webkit.org
  • 16 edits in trunk

[iOS] WebKit should dispatch DOM events when a modifier key is pressed
https://bugs.webkit.org/show_bug.cgi?id=190487

Reviewed by Tim Horton.

Source/WebCore:

Add support for modifier flags change events.

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::modifiersForEvent): Modifier keys do not have an associated character and do not
participate in key repeat.
(WebCore::keyIdentifierForKeyEvent): Identify modifier keys, returning "Unidentified" if
the modifier key is unidentified. This matches the behavior on Mac.
(WebCore::keyForKeyEvent): Identify modifier keys, returning the empty string if the modifier
key is unidentified. This matches the behavior on Mac.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Modifier keys do not have an associated character and do not participate in key repeat.

(-[WebEvent _eventDescription]): Modified to print a description for a keydown or keyup event
that represents a modifier flags change.
(-[WebEvent characters]): Modifier keys do not have an associated character. Assert this
invariant as it is a programming error. On Mac, the same operation would result in a
NSInternalInconsistencyException exception being raised.
(-[WebEvent charactersIgnoringModifiers]): Ditto.

Source/WebKit:

Add support for modifier flags change events dispatched by UIKit.

  • Shared/ios/WebIOSEventFactory.mm:

(modifiersForEvent): Update for renamed enumerations.
(WebIOSEventFactory::createWebKeyboardEvent): Modifier keys do not have an associated
character and do not participate in key repeat.

  • UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Update for renamed enumerations.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]): Return NO if the event represents a
modifier flags change to allow the default handling.

  • UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]): Update for renamed enumerations.

Source/WebKitLegacy/mac:

Having Legacy WebKit return NO if the editing event represents a modifier flags change to
allow the default handling.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

Tools:

Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
match my observations when using the simulator to simulate iOS 12 and add support for testing
right-hand side modifiers.

  • DumpRenderTree/mac/EventSendingController.mm:

(modifierFlags):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
(-[EventSendingController setTouchModifier:value:]):

  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(hidUsageCodeForCharacter):

LayoutTests:

Update expected results of an existing test now that we identify modifier keys.

  • fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt:
9:55 AM Changeset in webkit [237737] by ajuma@chromium.org
  • 17 edits
    2 copies
    7 adds in trunk

Allow cross-document intersection observing
https://bugs.webkit.org/show_bug.cgi?id=165746

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectations for tests that now pass.

  • web-platform-tests/intersection-observer/client-rect-expected.txt:
  • web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt:
  • web-platform-tests/intersection-observer/iframe-no-root-expected.txt:
  • web-platform-tests/intersection-observer/timestamp-expected.txt:

Source/WebCore:

Add logic to compute the intersection between the viewport and an element in a
subframe.

Add a FloatRect version of ScrollView::rootViewToContents, and FloatRect versions
of the methods it calls.

Test: http/tests/intersection-observer/intermediate-frame-changes.html
Also covered by rebased tests in imported/w3c/web-platform-tests/intersection-observer.

  • dom/Document.cpp:

(WebCore::computeClippedRectInRootContentsSpace):
(WebCore::computeIntersectionState):
(WebCore::Document::updateIntersectionObservations):

  • page/FrameView.cpp:

(WebCore::FrameView::viewportContentsChanged):
(WebCore::FrameView::convertFromContainingViewToRenderer const):
(WebCore::FrameView::convertFromContainingView const):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::viewToContents const):
(WebCore::ScrollView::contentsToView const):
(WebCore::ScrollView::rootViewToContents const):

  • platform/ScrollView.h:
  • platform/Widget.cpp:

(WebCore::Widget::convertFromRootView const):
(WebCore::Widget::convertFromContainingView const):

  • platform/Widget.h:

LayoutTests:

Add a test that cross-document intersection observations are triggered when an intermediate frame
scrolls. Skip the test on WK1 platforms where IntersectionObserver is not supported.

Add platform-specific baselines for tests involving iframe scrolling, which isn't supported on iOS.

  • http/tests/intersection-observer/intermediate-frame-changes-expected.txt: Added.
  • http/tests/intersection-observer/intermediate-frame-changes.html: Added.
  • http/tests/intersection-observer/resources/intermediate-frame.html: Added.
  • http/tests/intersection-observer/resources/nested-frame.html: Added.
  • platform/ios/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:49 AM Changeset in webkit [237736] by Kocsen Chung
  • 2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Cherry-pick r237707. rdar://problem/45749094

Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

  • Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:59 AM Changeset in webkit [237735] by Chris Dumez
  • 6 edits in trunk

[PSON] Reuse SuspendedPages' process when possible, for performance
https://bugs.webkit.org/show_bug.cgi?id=191166

Reviewed by Geoffrey Garen.

Source/WebKit:

When process-swapping check if there is an existing SuspendedPage for the domain we're going to.
If there is, use this SuspendedPage's process for the navigation instead of a fresh new process.
This change should be beneficial for performance as it:

  • Avoids spinning up a new process (CPU & memory cost)
  • Likely better leverages caches since this process already loaded this domain in the past

Due to current limitations, using a SuspendedPage's proxy may consume the SuspendedPage, which
means that it can no longer be used for PageCache on history navigations. We need to do this when
the SuspendedPageProxy in question was created for the current WebPageProxy because:

  • This SuspendedPageProxy's process already has a suspended WebPage with this WebPageProxy's pageID

and

  • We do not currently support having more than one WebPage with a given pageID within a single WebProcess.
  • UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):

  • UIProcess/SuspendedPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
8:46 AM Changeset in webkit [237734] by Tadeu Zagallo
  • 4 edits in trunk/Source/JavaScriptCore

Metadata should not be copyable
https://bugs.webkit.org/show_bug.cgi?id=191193

Reviewed by Keith Miller.

We should only ever hold references to the entry in the metadata table.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeLLIntInlineCaches):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • generator/Metadata.rb:
8:41 AM Changeset in webkit [237733] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:39 AM Changeset in webkit [237732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-02
Reviewed by Yusuke Suzuki.

No new tests since no change in functionality.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::hasResult const):
(WebCore::FilterEffect::applyAll):
(WebCore::FilterEffect::openCLImage): Deleted.
(WebCore::FilterEffect::setOpenCLImage): Deleted.

7:23 AM Changeset in webkit [237731] by Alan Bujtas
  • 7 edits
    2 adds in trunk

[LFC][IFC] Add support for intrinsic width calculation
https://bugs.webkit.org/show_bug.cgi?id=191144

Reviewed by Antti Koivisto.

Source/WebCore:

This is the inline formatting version of the shrink-to-fit computation. It generates inline runs
and uses InlineLineBreaker to compute min/max width. This is very similar to ::layout.

Test: fast/inline/simple-shrink-to-fit-inline-block.html

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):
(WebCore::Layout::InlineFormattingContext::collectInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
  • fast/inline/simple-shrink-to-fit-inline-block.html: Added.
  • platform/ios/TestExpectations:
7:21 AM Changeset in webkit [237730] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][BFC] BlockFormattingContext::instrinsicWidthConstraints logic should look similar to ::layout
https://bugs.webkit.org/show_bug.cgi?id=191181

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

6:41 AM Changeset in webkit [237729] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC] Align shrink-to-fit width computation with the layout implementation.
https://bugs.webkit.org/show_bug.cgi?id=191179

Reviewed by Antti Koivisto.

There are many similarities between layout and shrink-to-fit.
They both operate on formatting roots only (shrink-to-fit -> float, out-of-flow, inline-block) and in both cases
the algoritm depends on what type of formatting context the element establishes.

This patch is in preparation for transforming the "shrink-to-fit" width computation to make it behave more like layout.
With this change the instrinsicWidthConstraints() computation happens in the formatting context that the element establishes (similar to layout).

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):

  • layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

  • layout/inlineformatting/InlineFormattingContext.h:
  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):

3:46 AM Changeset in webkit [237728] by Tadeu Zagallo
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r237547): Exception handlers should be aware of wide opcodes when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=191175

Reviewed by Keith Miller.

https://bugs.webkit.org/show_bug.cgi?id=191108 did not handle the case where JIT is not enabled

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • llint/LLIntData.h:

(JSC::LLInt::getWideCodePtr):

3:04 AM Changeset in webkit [237727] by Philippe Normand
  • 5 edits in trunk

[Apache] Self-signed SSL certificate RSA key is considered too weak
https://bugs.webkit.org/show_bug.cgi?id=191156

Reviewed by Michael Catanzaro.

Tools:

  • Scripts/webkitpy/common/system/pemfile.py:

LayoutTests:

Regenerate the self-signed SSL certificate with a 2048 bits RSA key.

  • http/conf/webkit-httpd.pem:
12:54 AM Changeset in webkit [237726] by graouts@webkit.org
  • 17 edits in trunk

[Web Animations] Make document.getAnimations() return declarative animations in the correct order
https://bugs.webkit.org/show_bug.cgi?id=191153

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions for the document.getAnimations() tests covering CSS Animations and CSS Transitions.
These tests are now in WPT and will be updated as part of a general WPT update for all of Web Animations
shortly. We will upstream the minor changes made at that point. Those changes were necessary because we
don't support the PseudoElement interface and instead we check which animation names and CSS properties
are applied to pseudo-elements rather than the pseudo-element's type.

  • css-animations/test_document-get-animations-expected.txt:
  • css-animations/test_document-get-animations.html:
  • css-animations/test_event-dispatch.html: Remove a comment that was added by mistake in a previous patch.
  • css-transitions/test_document-get-animations-expected.txt:
  • css-transitions/test_document-get-animations.html:

Source/WebCore:

The Web Animations spec has the notion of "composite order" which determines the order in which animations should
be returned when document.getAnimations() is called. The CSS Transitions and CSS Animations specifications also
determine the composite order of their respective animation classes, as well as the notion of "owning element",
the element that was the animation target when specified through style, prior to any manipulation via the Web
Animations API. We implement these two notions so that we can pass the document.getAnimations() tests for
declarative animations.

It is important that we have the notion of an "owning element" since when a CSS Transition or CSS Animation is
modified via the Web Animations API in a way that an animation created through CSS we must consider no longer
as a declarative animation but as a regular Web Animation. In this patch, we remove the DeclarativeAnimation's
target(), which returned a reference, to owningElement(), which returns a pointer and return nullptr once the
declarative animation has been modified.

In order to also keep a correct count of declarative animations applied to elements, we correctly add transitions
that have completed to a list of completed transitions, as specified by the CSS Transitions spec. We have had this
list declared in AnimationTimeline.h for a while but never actually did the work to add items to it. Thanks to that,
AnimationTimeline::updateCSSTransitionsForElement() now correctly accounts for completed transitions so that they
may be canceled if overridden with a new animation, correctly removing their "owning element".

Finally, now that we have saner lists of animations per classes, we can apply the right sorting routines to match
the composite order for CSS Transitions, CSS Animations and Web Animations, keeping a list of all animations created
in order as the final criterion for sorting.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationTimingDidChange): Make sure this animation is tracked on the list of all animations
created for this timeline in the order in which they were created, which is needed to sort animations correctly when
document.getAnimations() is called.
(WebCore::AnimationTimeline::animationWasAddedToElement): We've removed the relevantMapForAnimation() method which we used
to determine which map we should add an animation to based on its class and instead have code that accounts for not just
the animation's class, but also whether it has an owning element since a valid owning element is required to qualify as
a CSS Transition or CSS Animation, regardless of the animation's original class.
(WebCore::removeAnimationFromMapForElement): Adding this helper to remove an animation from the provided animation map so
that animationWasRemovedFromElement() can call this with all of the various animation maps.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Check all of the various animation maps to see which may
contain the animation we're trying to remove as the owning element might have been cleared by the time this function is
called and looking at the animation's class would not be sufficient to determine which animation map the animation was in.
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement): New function in which the logic from
animationWasRemovedFromElement() that dealt with removing animations from the list of running CSS Animations/Transitions as
well as completed CSS Transitions was factored out. This allowed us to also call this function from
DeclarativeAnimation::disassociateFromOwningElement().
(WebCore::AnimationTimeline::elementWasRemoved): We no longer need to remove an animation as canceling it will remove it
correctly when DocumentTimeline::updateAnimationsAndSendEvents() is called.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Animation should be canceled.
(WebCore::AnimationTimeline::ensureRunningTransitionsByProperty): Now that we correctly remove transitions from the list
of running transitions once they've completed or have been canceled, we need a helper to always get a valid map of running
transitions for a given element as that map can be cleared while updateCSSTransitionsForElement() is running.
(WebCore::AnimationTimeline::updateCSSTransitionsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Transition should be canceled. Additionally we always get the list of running
transitions for a given element as it can be cleared by a prior cancelation.
(WebCore::AnimationTimeline::cancelDeclarativeAnimation): New function replacing cancelOrRemoveDeclarativeAnimation() in which
we call the new DeclarativeAnimation::cancelFromStyle() function on the provided animation and then remove the animation from
all known lists, including the new list of all animations. We do this final part so that the animation gets re-added as if it
were a new animation since canceling a declarative animation via a style change removes its declarative-ness. This guarantees
that a declarative animation that is canceled through style but then resumed through the Web Animations API sorts after any
declarative animation with an owning element.
(WebCore::AnimationTimeline::relevantMapForAnimation): Deleted.
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation): Deleted.

  • animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::timingModelDidChange): Deleted. This was left over in the patch where we implemented the "update
animations and send events" procedure.
(WebCore::AnimationTimeline::animations const): Deleted.

  • animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.

  • animation/CSSTransition.cpp:

(WebCore::CSSTransition::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.

  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::tick): Make sure we disassociate from the animation's owning element once we transition from a
relevant state to an idle state. This will catch any changes made via the Web Animations API to a declarative animation when the
"update animations and send events" procedure is run.
(WebCore::DeclarativeAnimation::disassociateFromOwningElement): Remove this animation from the list of declarative animations on
the associated timeline and make owningElement() nullptr so that document.getAnimations() will know to sort this animation with other
Web Animations created via the Web Animations API.
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::cancelFromStyle): New method called from AnimationTimeline::cancelDeclarativeAnimation() which
cancels the animation but also disassociates it from its owning element.
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):

  • animation/DeclarativeAnimation.h:

(WebCore::DeclarativeAnimation::owningElement const):
(WebCore::DeclarativeAnimation::target const): Deleted.

  • animation/DocumentTimeline.cpp:

(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder): Adding a new utility used when sorting both
CSS Transitions and CSS Animations by tree order when their owning element differ, with special logic for pseudo-elements.
(WebCore::DocumentTimeline::getAnimations const): Filter and sort animations according to their composite order.
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Compile a list of transitions that move to a finished state to
the list of completed transitions so that they may be canceled correctly in AnimationTimeline::updateCSSTransitionsForElement().
(WebCore::DocumentTimeline::transitionDidComplete):

  • animation/DocumentTimeline.h:

LayoutTests:

Mark that the two document.getAnimations() tests for declarative animations are no longer flaky.

12:15 AM Changeset in webkit [237725] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

PNGImageDecoder: report no repetition for non-animated images
https://bugs.webkit.org/show_bug.cgi?id=191068

Reviewed by Michael Catanzaro.

When building with APNG support enabled, the
PNGImageDecoder::repetitionCount() method until now reported infinite
repetition count for all PNG images, even the ones that were not
animated. This is now changed so that no repetition is reported for
non-animated images.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::repetitionCount const):

12:11 AM Changeset in webkit [237724] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebDriver

[WPE] WebDriver: support validating and parsing the 'certificates' capability
https://bugs.webkit.org/show_bug.cgi?id=191014

Reviewed by Michael Catanzaro.

Adopt the same approach as in the GTK's WebDriverService implementation
for validating and parsing the 'certificates' WebDriver capability.

  • wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

12:09 AM Changeset in webkit [237723] by Justin Fan
  • 21 edits
    9 copies
    2 moves
    5 adds in trunk

[WebGPU] Experimental prototype for MSL shaders
https://bugs.webkit.org/show_bug.cgi?id=191084

Reviewed by Dean Jackson.

Source/WebCore:

Begin implementation for WebGPUDevice and WebGPUShaderModule and associated descriptor objects.

Test: webgpu/webgpu-basics.html
Test: webgpu/shader-modules.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/webgpu/GPUDevice.cpp:

(WebCore::GPUDevice::createShaderModule const):

  • Modules/webgpu/GPUDevice.h:

(WebCore::GPUDevice::platformDevice const):

  • Modules/webgpu/GPUShaderModule.h:

(WebCore::GPUShaderModule::platformShaderModule const):

  • Modules/webgpu/GPUShaderModuleDescriptor.h:
  • Modules/webgpu/WebGPU.cpp:

(WebCore::WebGPU::requestAdapter const):

  • Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::create):
(WebCore::WebGPUAdapter::createDevice):

  • Modules/webgpu/WebGPUAdapter.h:
  • Modules/webgpu/WebGPUAdapter.idl:
  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::WebGPUDevice::createShaderModule const):

  • Modules/webgpu/WebGPUDevice.h:
  • Modules/webgpu/WebGPUDevice.idl:
  • Modules/webgpu/WebGPUShaderModule.cpp:

(WebCore::WebGPUShaderModule::create):
(WebCore::WebGPUShaderModule::WebGPUShaderModule):

  • Modules/webgpu/WebGPUShaderModule.h:
  • Modules/webgpu/WebGPUShaderModule.idl:
  • Modules/webgpu/WebGPUShaderModuleDescriptor.h:
  • Modules/webgpu/WebGPUShaderModuleDescriptor.idl:
  • Modules/webgpu/WebGPUSwapChain.cpp:

(WebCore::WebGPUSwapChain::configure):

  • Modules/webgpu/WebGPUSwapChain.h:
  • Modules/webgpu/WebGPUSwapChain.idl:
  • Modules/webgpu/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):

  • Modules/webgpu/cocoa/GPUShaderModuleMetal.mm:

(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::GPUShaderModule):

  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • platform/Logging.h:

Source/WTF:

Disabling WebGPU on non-Cocoa platforms and iOS Simulator.

  • wtf/Platform.h:

LayoutTests:

  • webgpu/shader-modules.html: Added.
  • webgpu/shader-modules-expected.html: Added.
  • webgpu/webgpu-basics.html: Added.
  • webgpu/webgpu-basics-expected.html: Added.
12:04 AM Changeset in webkit [237722] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed follow-up to r237678.

  • wpe/jhbuild.modules: The patch element apparently has to be a child

of the branch in order for Jhbuild to properly detect and apply the
patch file.

Nov 1, 2018:

11:35 PM Changeset in webkit [237721] by jiewen_tan@apple.com
  • 11 edits
    1 delete in trunk/Source

Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

  • bmalloc/CryptoRandom.cpp:

(bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

  • crypto/CommonCryptoUtilities.h:
  • crypto/mac/CryptoKeyMac.cpp:

(WebCore::CryptoKey::randomData):

  • crypto/mac/SerializedCryptoKeyWrapMac.mm:

(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/RandomDevice.cpp:

(WTF::RandomDevice::cryptographicallyRandomValues):

  • wtf/spi/darwin/CommonCryptoSPI.h: Removed.
9:11 PM Changeset in webkit [237720] by Devin Rousso
  • 5 edits in trunk

Web Inspector: View: introduce a didLayoutSubtree
https://bugs.webkit.org/show_bug.cgi?id=191176

Reviewed by Matt Baker.

Source/WebInspectorUI:

Introduce logic to allow subclasses of WI.View to perform logic after every WI.View in
their subtree has finished layout.

  • UserInterface/Views/View.js:

(WI.View.prototype.didLayoutSubtree): Added.
(WI.View.prototype._layoutSubtree):

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype.didLayoutSubtree): Added.

LayoutTests:

  • inspector/view/resources/test-view.js:

(TestPage.registerInitializer.WI.TestView.prototype.layout):
(TestPage.registerInitializer.WI.TestView.prototype.didLayoutSubtree): Added.

8:50 PM Changeset in webkit [237719] by bshafiei@apple.com
  • 7 edits in tags/Safari-607.1.12.1/Source

Versioning.

8:48 PM Changeset in webkit [237718] by bshafiei@apple.com
  • 1 copy in tags/Safari-607.1.12.1

Tag Safari-607.1.12.1.

8:35 PM Changeset in webkit [237717] by Chris Dumez
  • 34 edits in trunk/Source/WebCore

[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
https://bugs.webkit.org/show_bug.cgi?id=191162

Reviewed by Alex Christensen.

Rename CallWith=ScriptState to CallWith=ExecState in our Web IDL as ScriptState is no longer a thing
in modern WebKit. The implementation is actually passed an ExecState nowadays.

  • Modules/applepay/ApplePaySession.idl:
  • Modules/encryptedmedia/MediaKeyStatusMap.idl:
  • Modules/fetch/FetchBody.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • animation/Animatable.idl:
  • animation/KeyframeEffect.idl:
  • animation/KeyframeEffectReadOnly.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):
(GenerateConstructorDefinition):

  • bindings/scripts/IDLAttributes.json:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjWithExecStateAttributeGetter):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttributeSetter):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpacesBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces):
(WebCore::jsTestObjWithScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpacesBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): Deleted.

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestPromiseRejectionEvent.idl:
  • crypto/SubtleCrypto.idl:
  • dom/Element.idl:
  • dom/ErrorEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLFrameElement.idl:
  • html/OffscreenCanvas.idl:
  • html/track/DataCue.idl:
  • inspector/CommandLineAPIHost.idl:
  • page/DOMWindow.idl:
  • page/RemoteDOMWindow.idl:
  • page/WindowOrWorkerGlobalScope.idl:
  • testing/Internals.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/Worker.idl:
7:04 PM Changeset in webkit [237716] by Ross Kirsling
  • 2 edits in trunk/Tools

build-jsc --wincairo should update WinCairo libraries
https://bugs.webkit.org/show_bug.cgi?id=191170

Reviewed by Fujii Hironori.

  • Scripts/build-jsc:
6:24 PM Changeset in webkit [237715] by Alan Coon
  • 1 copy in tags/Safari-606.3.4.0.1

Tag Safari-606.3.4.0.1.

6:13 PM Changeset in webkit [237714] by Fujii Hironori
  • 18 edits
    2 moves in trunk/Source

Rename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid conflicting with ICU's unicode/utf8.h
https://bugs.webkit.org/show_bug.cgi?id=189693

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • API/JSClassRef.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
  • API/JSStringRef.cpp: Ditto.
  • runtime/JSGlobalObjectFunctions.cpp: Ditto.
  • wasm/WasmParser.h: Ditto.

Source/WebCore:

No new tests because there's no behaviro changes.

  • platform/SharedBuffer.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
  • xml/XSLTProcessorLibxslt.cpp: Ditto.
  • xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.

Source/WebKit:

  • Shared/API/APIString.h: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj: Replaced unicode/UTF8.{cpp,h} with unicode/UTF8Conversion.{cpp,h}.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/text/AtomicStringImpl.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringView.cpp: Ditto.
  • wtf/text/WTFString.cpp: Ditto.
  • wtf/unicode/UTF8Conversion.cpp: Renamed from Source/WTF/wtf/unicode/UTF8.cpp.
  • wtf/unicode/UTF8Conversion.h: Renamed from Source/WTF/wtf/unicode/UTF8.h.
5:58 PM Changeset in webkit [237713] by Alan Coon
  • 2 edits in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237582. rdar://problem/45747609

5:58 PM Changeset in webkit [237712] by Alan Coon
  • 3 edits
    1 delete in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237583. rdar://problem/45747609

5:51 PM Changeset in webkit [237711] by wilander@apple.com
  • 4 edits
    1 add in trunk

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.

(-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
(-[KeyboardEventListener handleEvent:]):
(TestWebKitAPI::TEST):

5:46 PM Changeset in webkit [237710] by Alan Coon
  • 7 edits in tags/Safari-607.1.10.8/Source

Versioning.

5:44 PM Changeset in webkit [237709] by Alan Coon
  • 1 copy in tags/Safari-607.1.10.8

New tag.

5:27 PM Changeset in webkit [237708] by Devin Rousso
  • 7 edits in trunk/Source

Web Inspector: Network: remove unnecessary media event tracking
https://bugs.webkit.org/show_bug.cgi?id=191174

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, as this simply removes some event listeners for the WebInspector frontend.

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::addEventListenersToNode):

Source/WebInspectorUI:

Renames "Group by Node" to "Group Media Requests" for clarity.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.showRepresentedObject):
(WI.NetworkTableContentView.prototype.networkDetailViewClose):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._entryForDOMNode):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
(WI.NetworkTableContentView.prototype._restoreSelectedRow):
(WI.NetworkTableContentView.prototype._handleResourceEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleNodeEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):

  • UserInterface/Views/NetworkTableContentView.css:

(.network-table .data-container .cell.name .range): Added.
(.network-table .data-container .cell.name .range::before): Added.
(.network-table:focus .data-container li.selected .cell.name .range): Added.
(@media (prefers-dark-interface) .network-table .data-container .cell.name .range): Added.
Always display the "Byte Range" title as a "subtitle", regardless of the media requests
setting being toggled.
Drive-by: update the position of the waterfall popover whenever the time range changes.
Drive-by: close the details view if a node is selected and the media requests setting is
turned off.

  • UserInterface/Views/Popover.js:

(WI.Popover.prototype.resize): Added.
(WI.Popover.prototype.handleEvent):

  • Localizations/en.lproj/localizedStrings.js:
5:02 PM Changeset in webkit [237707] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

  • Configurations/JavaScriptCore.xcconfig:
4:49 PM Changeset in webkit [237706] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
https://bugs.webkit.org/show_bug.cgi?id=191020

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler):
Since undefined is not a number, it isn't less than 0, which caused us to divide by
undefined (equivalent to dividing by 0), resulting in NaN.

4:24 PM Changeset in webkit [237705] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173

Reviewed by Devin Rousso.

WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.

  • UserInterface/Base/Main.js:

(WI.loaded):
(WI.contentLoaded):

4:22 PM Changeset in webkit [237704] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=191124

Reviewed by Tim Horton.

Remove the platform guard around the call to -_setUpSQLiteDatabaseTrackerClient as the
implementation of that message is already guarded.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

4:19 PM Changeset in webkit [237703] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, attempt to fix the build with recent SDKs.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

2:40 PM Changeset in webkit [237702] by Chris Dumez
  • 13 edits in trunk

Location object sans browsing context
https://bugs.webkit.org/show_bug.cgi?id=191060

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

  • web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt:

Rebase WPT test now that all checks are passing.

  • web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js:

Fix bug in WPT test (https://github.com/web-platform-tests/wpt/pull/13854)

  • web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:

Source/WebCore:

As per https://github.com/whatwg/html/pull/4076, a Location object's URL should be "about:blank" when
it does not have a browsing context (Frame), not "".

No new tests, rebaselined existing tests.

  • page/Location.cpp:

(WebCore::Location::url const):
(WebCore::Location::href const):
(WebCore::Location::protocol const):
(WebCore::Location::host const):
(WebCore::Location::hostname const):
(WebCore::Location::port const):
(WebCore::Location::pathname const):
(WebCore::Location::search const):
(WebCore::Location::origin const):
(WebCore::Location::hash const):

LayoutTests:

Update existing tests to reflect behavior change.

  • http/tests/dom/same-origin-detached-window-properties-expected.txt:
  • http/tests/dom/same-origin-detached-window-properties.html:
  • http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
  • http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
  • http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
  • http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:
2:19 PM Changeset in webkit [237701] by Ross Kirsling
  • 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

(Also remove one outdated global test failure.)

2:11 PM Changeset in webkit [237700] by sihui_liu@apple.com
  • 48 edits
    3 adds in trunk

Add a storage limit for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=190598
<rdar://problem/44654715>

Reviewed by Chris Dumez.

Source/WebCore:

Set a storage limit in IndexedDB for each pair of mainFrameOrigin and openingOrigin.
IndexedDB will return a QuotaExceededError if limit is reached.

If the size of free disk space is over 1 GB, the default limit is 500 MB; otherwise it is
half the free disk space.

Test: storage/indexeddb/storage-limit.html

  • Modules/indexeddb/server/IDBBackingStore.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::setPerOriginQuota):

  • Modules/indexeddb/server/IDBServer.h:

(WebCore::IDBServer::IDBServer::perOriginQuota const):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::quotaForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::maximumSize const):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::setQuota):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit:

Add SPI for testing.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::setIDBPerOriginQuota):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetIDBPerOriginQuota):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setIDBPerOriginQuota):

  • UIProcess/WebProcessPool.h:

Source/WebKitLegacy:

  • Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):
(WebDatabaseProvider::setIDBPerOriginQuota):

  • Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

  • Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager setIDBPerOriginQuota:]):

  • Storage/WebDatabaseManagerPrivate.h:

Source/WebKitLegacy/win:

  • Interfaces/IWebDatabaseManager.idl:
  • WebDatabaseManager.cpp:

(WebDatabaseManager::setIDBPerOriginQuota):

  • WebDatabaseManager.h:

Tools:

Add API for testing.

  • DumpRenderTree/TestRunner.cpp:

(setIDBPerOriginQuotaCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setIDBPerOriginQuota):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setIDBPerOriginQuota):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setIDBPerOriginQuota):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setIDBPerOriginQuota):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Some tests will fail after adding storage limit to IndexedDB, so we need to reduce their
size and rebase their expectations.

  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/key-type-array-private-expected.txt:
  • storage/indexeddb/modern/idbkey-array-equality-expected.txt:
  • storage/indexeddb/modern/idbkey-array-equality-private-expected.txt:
  • storage/indexeddb/modern/resources/idbkey-array-equality.js:

(request.onsuccess):
(request.onerror):
(doAdd):

  • storage/indexeddb/prefetch-invalidation-expected.txt:
  • storage/indexeddb/prefetch-invalidation-private-expected.txt:
  • storage/indexeddb/resources/key-type-array.js:

(testValidArrayKeys.getreq.onsuccess):
(testValidArrayKeys.putreq.onsuccess):
(testValidArrayKeys.testArrayPutGet):

  • storage/indexeddb/resources/prefetch-invalidation.js:

(cursorRequest.onsuccess):
(continue50Times):
(continue100Times): Deleted.

  • storage/indexeddb/resources/storage-limit.js: Added.

(prepareDatabase):
(onOpenSuccess.request.onerror):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):

  • storage/indexeddb/storage-limit-expected.txt: Added.
  • storage/indexeddb/storage-limit.html: Added.
1:53 PM Changeset in webkit [237699] by Chris Dumez
  • 6 edits in trunk

[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191076

Reviewed by Geoffrey Garen.

Source/WebKit:

WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping.
The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading
the wrong URL.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):

  • UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONNavigationDelegate init]):
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

1:46 PM Changeset in webkit [237698] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.

  • platform/mac-wk1/TestExpectations:
1:35 PM Changeset in webkit [237697] by Justin Michaud
  • 34 edits
    6 adds in trunk

CSS Custom Properties API Should Support syntax="*" and "<length>", and handle cycles properly
https://bugs.webkit.org/show_bug.cgi?id=191042

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
  • web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
  • web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt:
  • web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt:
  • web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles-expected.txt:
  • web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:

Source/WebCore:

Refactor code so that:

  • All properties applied in StyleResolver::applyMatchedProperties are only applied once.
  • Custom properties are only resolved once, in StyleResolver, when they are applied to the RenderStyle. They were previously resolved every time they were referenced, and again in RenderStyle.
  • The font-size property is applied after its variable references, but before custom properties that depend on it.
  • Cycles are detected at the same time as resolution.
  • MutableStyleProperties' custom properties cannot be set from Javascript or WebKitLegacy if they do not parse for the property's type. If they contain var(--...) references, however, then they can be set because we cannot check if the references are valid from setProperty. This behaviour matches chrome, but is not documented in the spec.
  • Custom property values have more explicit resolved/unresolved state.
  • RenderStyle only ever holds resolved custom properties, and StyleResolver::CascadedProperties only holds unresolved properties.

Tests: css-custom-properties-api/crash.html

css-custom-properties-api/cycles.html
css-custom-properties-api/inline.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):

  • css/CSSCustomPropertyValue.cpp:

(WebCore::CSSCustomPropertyValue::equals const):
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
(WebCore::CSSCustomPropertyValue::checkVariablesForCycles const): Deleted.
(WebCore::CSSCustomPropertyValue::resolveVariableReferences const): Deleted.
(WebCore::CSSCustomPropertyValue::setResolvedTypedValue): Deleted.

  • css/CSSCustomPropertyValue.h:
  • css/CSSRegisteredCustomProperty.cpp:

(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty):

  • css/CSSRegisteredCustomProperty.h:
  • css/CSSVariableData.cpp:

(WebCore::CSSVariableData::CSSVariableData):
(WebCore::CSSVariableData::consumeAndUpdateTokens): Deleted.
(WebCore::CSSVariableData::checkVariablesForCycles const): Deleted.
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const): Deleted.
(WebCore::CSSVariableData::resolveVariableFallback const): Deleted.
(WebCore::CSSVariableData::resolveVariableReference const): Deleted.
(WebCore::CSSVariableData::resolveVariableReferences const): Deleted.
(WebCore::CSSVariableData::resolveTokenRange const): Deleted.

  • css/CSSVariableData.h:

(WebCore::CSSVariableData::create):
(WebCore::CSSVariableData::createResolved): Deleted.
(WebCore::CSSVariableData::needsVariableResolution const): Deleted.
(WebCore::CSSVariableData::CSSVariableData): Deleted.

  • css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):
(WebCore::CSSVariableReferenceValue::checkVariablesForCycles const): Deleted.

  • css/CSSVariableReferenceValue.h:

(WebCore::CSSVariableReferenceValue::create):
(WebCore::CSSVariableReferenceValue::equals const):
(WebCore::CSSVariableReferenceValue::variableDataValue const): Deleted.

  • css/DOMCSSRegisterCustomProperty.cpp:

(WebCore::DOMCSSRegisterCustomProperty::registerProperty):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialCustomProperty):
(WebCore::StyleBuilderCustom::applyValueCustomProperty):

  • css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setCustomProperty):

  • css/StyleProperties.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedCustomProperty):
(WebCore::StyleResolver::applyCascadedProperties):

  • css/StyleResolver.h:
  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

  • css/parser/CSSParser.h:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::CSSPropertyParser):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::parseSingleValue):

  • css/parser/CSSPropertyParser.h:
  • css/parser/CSSVariableParser.cpp:

(WebCore::CSSVariableParser::parseDeclarationValue):

  • dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::checkVariablesInCustomProperties): Deleted.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

  • rendering/style/StyleCustomPropertyData.h:

(WebCore::StyleCustomPropertyData::operator== const):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
(): Deleted.

LayoutTests:

  • css-custom-properties-api/crash-expected.txt: Added.
  • css-custom-properties-api/crash.html: Added.
  • css-custom-properties-api/cycles-expected.txt: Added.
  • css-custom-properties-api/cycles.html: Added.
  • css-custom-properties-api/inline-expected.txt: Added.
  • css-custom-properties-api/inline.html: Added.
12:49 PM Changeset in webkit [237696] by guijemont@igalia.com
  • 28 edits in trunk

Skip tests on arm/mips that time out now we're running on CLoop

Unreviewed gardening.

Since the JIT is temporarily disabled on 32-bit platforms, these tests
time out on the bots and need to be disabled. There's more tests
disabled on arm because the timeout is longer on the mips bot (as the
device is slower to start with), so many of the tests don't time out
there.

JSTests:

  • microbenchmarks/getter-richards.js: disable on arm and mips.
  • stress/op_add.js: disable on arm.
  • stress/op_bitand.js: disable on arm.
  • stress/op_bitor.js: disable on arm.
  • stress/op_bitxor.js: disable on arm.
  • stress/op_lshift-ConstVar.js: disable on arm.
  • stress/op_lshift-VarConst.js: disable on arm.
  • stress/op_lshift-VarVar.js: disable on arm.
  • stress/op_mod-ConstVar.js: disable on arm.
  • stress/op_mod-VarConst.js: disable on arm.
  • stress/op_mod-VarVar.js: disable on arm.
  • stress/op_mul-ConstVar.js: disable on arm.
  • stress/op_mul-VarConst.js: disable on arm.
  • stress/op_mul-VarVar.js: disable on arm.
  • stress/op_rshift-ConstVar.js: disable on arm.
  • stress/op_rshift-VarConst.js: disable on arm.
  • stress/op_rshift-VarVar.js: disable on arm.
  • stress/op_sub-ConstVar.js: disable on arm.
  • stress/op_sub-VarConst.js: disable on arm.
  • stress/op_sub-VarVar.js: disable on arm.
  • stress/op_urshift-ConstVar.js: disable on arm.
  • stress/op_urshift-VarConst.js: disable on arm.
  • stress/op_urshift-VarVar.js: disable on arm.
  • stress/spread-forward-call-varargs-stack-overflow.js: disable on arm.
  • stress/value-to-boolean.js: disable on arm and mips.

LayoutTests:

  • js/script-tests/regress-139548.js: disable on arm and mips.
12:13 PM Changeset in webkit [237695] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r237652): Web Inspector: dumpInspectorProtocolMessages is always enabled
https://bugs.webkit.org/show_bug.cgi?id=191161

Reviewed by Joseph Pecoraro.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):

12:12 PM Changeset in webkit [237694] by Devin Rousso
  • 4 edits in trunk/LayoutTests

Web Inspector: fix debug WK1 test failures for WI.ObjectStore
https://bugs.webkit.org/show_bug.cgi?id=191158

Reviewed by Joseph Pecoraro.

  • inspector/unit-tests/objectStore/delete.html:
  • inspector/unit-tests/objectStore/deleteObject.html:
  • inspector/unit-tests/objectStore/resources/objectStore-utilities.js:

(TestPage.registerInitializer):

11:58 AM Changeset in webkit [237693] by Chris Dumez
  • 5 edits
    18 adds
    3 deletes in trunk/LayoutTests

Resync html/browsers/history/the-location-interface web platform tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=191139

Reviewed by Alex Christensen.

Resync html/browsers/history/the-location-interface web platform tests from upstream 8295368c82.

  • web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location_assign-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location_assign.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Added.

(test):
(bcLessLocation):
(forEach.testSetup.testSetup.values.forEach.value.test):
(string_appeared_here.forEach.method.string_appeared_here.forEach.value.test):

  • web-platform-tests/html/browsers/history/the-location-interface/non-automated/w3c-import.log:
  • web-platform-tests/html/browsers/history/the-location-interface/per-global.window-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/per-global.window.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-1.html: Removed.
  • web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-expected.txt: Removed.
  • web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html: Removed.
  • web-platform-tests/html/browsers/history/the-location-interface/resources/reload_post_1-1.py: Added.

(main):

  • web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log:
  • web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:
11:57 AM Changeset in webkit [237692] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Toggle selected properties by pressing Space or Command+/
https://bugs.webkit.org/show_bug.cgi?id=181145
<rdar://problem/36203388>

Reviewed by Brian Burg.

Pressing Space key or Command-/ toggles (comments out or uncomments) selected properties.

This patch only works with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get selectionRange):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.update): Renamed from _update.
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.applyFilter):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
Make update method public. No other changes were made.

11:49 AM Changeset in webkit [237691] by commit-queue@webkit.org
  • 6 edits in trunk

[CG] Adopt CG SPI for non-even cornered rounded rects
https://bugs.webkit.org/show_bug.cgi?id=190155

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-01
Reviewed by Simon Fraser.

Source/WebCore:

Instead of creating bezier curves for the non-even corners of the rounded
rects, we should use the optimized SPI provided by CG.

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

Source/WebCore/PAL:

  • pal/spi/cg/CoreGraphicsSPI.h:

LayoutTests:

This test fails on iOS simulator because of just one pixel difference
between drawing a shadow of the element and drawing a copy of the element.
This failure happens on iOS and does not happen on macOS because we don't
use accelerated drawing for macOS testing but we use it for iOS testing.

  • platform/ios/TestExpectations:
11:33 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro
(diff)
11:32 AM Changeset in webkit [237690] by Adrian Perez de Castro
  • 2 edits in releases/WebKitGTK/webkit-2.22/Tools

Merged r237680 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

  • MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

11:32 AM Changeset in webkit [237689] by Adrian Perez de Castro
  • 8 edits in releases/WebKitGTK/webkit-2.22

Merged r237677 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

  • Modules/mediasource/VideoPlaybackQuality.cpp:
  • Modules/mediasource/VideoPlaybackQuality.h:
  • Modules/mediasource/VideoPlaybackQuality.idl:
  • dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

  • inspector/agents/InspectorDOMAgent.h:
  • rendering/RenderThemeGtk.cpp:

Tools:

  • MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

11:18 AM Changeset in webkit [237688] by youenn@apple.com
  • 4 edits in trunk

RTCTrackEvent.streams should be SameObject
https://bugs.webkit.org/show_bug.cgi?id=191130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:

Source/WebCore:

Mimick SameObject using CachedAttribute.
Covered by rebased test.

  • Modules/mediastream/RTCTrackEvent.idl:
11:02 AM Changeset in webkit [237687] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Prevent homepage animation for users that prefer reduced motion
https://bugs.webkit.org/show_bug.cgi?id=188211

Reviewed by Timothy Hatcher.

  • wp-content/themes/webkit/front-header.php:
10:35 AM Changeset in webkit [237686] by Alan Coon
  • 7 edits in branches/safari-606.3.4.2-branch/Source

Versioning.

10:33 AM Changeset in webkit [237685] by Alan Coon
  • 7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

10:30 AM Changeset in webkit [237684] by Alan Coon
  • 7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

10:09 AM Changeset in webkit [237683] by Chris Dumez
  • 5 edits
    3 adds in trunk

[PSON] Unable to submit a file in FormData cross-site
https://bugs.webkit.org/show_bug.cgi?id=191138

Reviewed by Alex Christensen.

Source/WebKit:

When PSON is enabled, we are unable to submit a file in FormData cross-site. Although we encode the
request body over IPC since r237639, we're missing the right sandbox extensions for its to work for
files.

Update FormDataReference encoder to pass along the necessary sandbox extensions for files in the
FormData, and have its decoder consume those extensions so that the recipient has access to those
files. Also update LoadParameters's IPC encoder / decoder to encoder an IPC::FormDataReference
(which encodes both FormData and sandbox extensions) instead of a FormData.

  • Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):

  • Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

LayoutTests:

Add layout test coverage.

  • http/tests/misc/form-submit-file-cross-site-expected.txt:
  • http/tests/misc/form-submit-file-cross-site.html:
9:40 AM Changeset in webkit [237682] by Claudio Saavedra
  • 2 edits in trunk/Source/WebKit

ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
https://bugs.webkit.org/show_bug.cgi?id=191152

Reviewed by Chris Dumez.

The statistics file is not created unconditionally, so
make sure it exists before logging an error.

  • UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.

9:11 AM Changeset in webkit [237681] by Devin Rousso
  • 3 edits in trunk/LayoutTests

Unreviewed test fix after r237670.

  • inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
  • inspector/canvas/setRecordingAutoCaptureFrameCount.html:
8:21 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro
(diff)
8:19 AM Changeset in webkit [237680] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

  • MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

7:20 AM Changeset in webkit [237679] by Alan Bujtas
  • 12 edits
    2 adds in trunk

[LFC][IFC] Add support for inline-block elements.
https://bugs.webkit.org/show_bug.cgi?id=191143

Reviewed by Antti Koivisto.

Source/WebCore:

This patch add support for laying out non-shrink-to-width inline-block elements.

Test: fast/inline/simple-inline-block.html

  • layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

  • layout/layouttree/LayoutInlineContainer.cpp:

(WebCore::Layout::InlineContainer::establishesInlineFormattingContext const):

  • layout/layouttree/LayoutInlineContainer.h:
  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

Tools:

  • LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

  • fast/inline/simple-inline-block-expected.txt: Added.
  • fast/inline/simple-inline-block.html: Added.
  • platform/ios/TestExpectations:
6:35 AM Changeset in webkit [237678] by Claudio Saavedra
  • 2 edits
    1 add in trunk/Tools

[WPE] Add missing libsoup patch to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=191149

Reviewed by Žan Doberšek.

  • wpe/jhbuild.modules:
  • wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
5:14 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro
(diff)
4:29 AM WebKitGTK/2.22.x edited by Claudio Saavedra
(diff)
4:27 AM Changeset in webkit [237677] by Claudio Saavedra
  • 10 edits in trunk

Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

  • Modules/mediasource/VideoPlaybackQuality.cpp:
  • Modules/mediasource/VideoPlaybackQuality.h:
  • Modules/mediasource/VideoPlaybackQuality.idl:
  • dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

  • inspector/agents/InspectorDOMAgent.h:
  • rendering/RenderThemeGtk.cpp:

Tools:

  • MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

3:03 AM Changeset in webkit [237676] by Claudio Saavedra
  • 2 edits in trunk/Source/WebKit

[GLIB] Silent a build warning when not using Wayland

Unreviewed.

  • UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
2:27 AM Changeset in webkit [237675] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>

Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-11-01
Reviewed by Youenn Fablet.

Remove share FileReader object between three asynchronous tests which might cause flaky failure.
We will need to fix all the falky failures in this test after we implement timeslice.

  • http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
1:51 AM Changeset in webkit [237674] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebKit

[WebAuthN] Make AuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=189279

Unreviewed build fix.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-01

  • UIProcess/WebAuthentication/Cocoa/LocalConnection.h: Add missing headers.
Note: See TracTimeline for information about the timeline view.