Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 11, 2018:

6:00 PM Changeset in webkit [238081] by Fujii Hironori

• 2 edits in trunk/Tools

run-bindings-tests is timing out in some WinCairo bots
​https://bugs.webkit.org/show_bug.cgi?id=191348

Reviewed by Alex Christensen.

BuildBot kills run-bindings-tests if it outputs nothing for 20
minutes. run-bindings-tests runs very slowly in WinCairo Docker,
and it takes more than 30 minutes to finish. And, Windows Python
buffers the progress output.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.detect_changes): Call sys.stdout.flush() after the
test case result is output.

5:39 PM Changeset in webkit [238080] by Wenson Hsieh

• 18 edits
  5 adds in trunk

Implement a new edit command to change the enclosing list type
​https://bugs.webkit.org/show_bug.cgi?id=191487
<rdar://problem/45955922>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for a new edit command that changes the type of the enclosing list element around the selection from
unordered to ordered list and vice versa. This new edit command is exposed only to internal WebKit2 clients, via
SPI on WKWebView (-_changeListType:).

This is currently intended for use in Mail compose, but may also be adopted by legacy Notes in the future. As
such, the behavior of this editing command mostly matches shipping behavior in Mail compose (which is currently
implemented entirely by Mail). See below for more details.

Test: editing/execCommand/change-list-type.html

WKWebViewEditActions.ChangeListType

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/ChangeListTypeCommand.cpp: Added.

(WebCore::listConversionTypeForSelection):
(WebCore::ChangeListTypeCommand::listConversionType):

Helper that returns a potential list conversion command that may be executed at the given document's selection,
if any exists. We also use existing logic from Mail here to determine which list to change, by walking up the
DOM from the lowest common ancestor container of the current selection until we hit the first list element.

(WebCore::ChangeListTypeCommand::createNewList):

Helper method to create a new list element to replace the given list, and then clone element data from the given
list to the new list. This addresses an existing bug in Mail, wherein changing list type for an enclosing list
which contains inline style properties drops the inline styles, because existing logic in Mail that implements
this editing command only copies the class attribute of the old list to the new list.

(WebCore::ChangeListTypeCommand::doApply):

Apply the edit command by running the following steps:

• Find the enclosing list element, if any (see above).
• Create a new list element of the opposite type as the enclosing list, and clone over element data from the

list element being replaced.

• Insert the new list next to the original list.
• Move all children of the original list to the new list.
• Remove the original list.
• Set the selection to the end of the new list.

• editing/ChangeListTypeCommand.h: Added.
• editing/EditAction.h:

Add a pair of new edit actions for conversion from unordered list to ordered list and vice versa.

• editing/Editor.cpp:

(WebCore::Editor::changeSelectionListType):

Implement this by creating and applying a new ChangeListTypeCommand.

(WebCore::Editor::canChangeSelectionListType): Deleted.

Remove this for now, since there's no need for it until full support for edit command validation is implemented.

• editing/Editor.h:
• testing/Internals.cpp:

(WebCore::Internals::changeSelectionListType):

• testing/Internals.h:
• testing/Internals.idl:

Add internal hooks to change list type from layout tests.

Source/WebKit:

• UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Remove preflight checks for these list editing commands. These are not necessary because these commands fall
back to being noops if these checks return false. This avoids an extraneous ancestor walk to determine the
enclosing list element when changing list type.

Source/WebKitLegacy/mac:

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

• WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Tools:

Add a new API test to verify that -[WKWebView _changeListType:] is hooked up to the corresponding editing
command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(-[TestWKWebView setPosition:offset:]):
(-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
(TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.

LayoutTests:

Add a new layout test to verify that the list change type editing command can be used to swap between enclosing
ordered and unordered lists. Also exercises undo, redo, changing list types under pre and table elements,
and handling selection within nested list elements.

• editing/execCommand/change-list-type-expected.txt: Added.
• editing/execCommand/change-list-type.html: Added.

2:22 PM Changeset in webkit [238079] by jfernandez@igalia.com

• 29 edits
  73 adds
  3 deletes in trunk/LayoutTests

[css-grid] Import additional grid layout test from the WPT suite
​https://bugs.webkit.org/show_bug.cgi?id=191369

Reviewed by Manuel Rego Casasnovas.

New Grid Layout tests from the WPT suite.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/css/css-grid/META.yml: Added.
• web-platform-tests/css/css-grid/OWNERS: Removed.
• web-platform-tests/css/css-grid/abspos/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008.html: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/support/style-change.js:

(evaluateStyleChangeMultiple):

• web-platform-tests/css/css-grid/alignment/support/w3c-import.log:
• web-platform-tests/css/css-grid/alignment/test-expected.txt: Added.
• web-platform-tests/css/css-grid/alignment/w3c-import.log:
• web-platform-tests/css/css-grid/grid-definition/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-definition/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001.html: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Added.
• web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html: Added.
• web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width-expected.html: Added.
• web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width.html: Added.
• web-platform-tests/css/css-grid/grid-items/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-items/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width-expected.html: Added.
• web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width.html: Added.
• web-platform-tests/css/css-grid/grid-items/w3c-import.log:
• web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002-expected.html: Added.
• web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html: Added.
• web-platform-tests/css/css-grid/grid-model/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/css-grid/grid-model/support/w3c-import.log:
• web-platform-tests/css/css-grid/grid-model/w3c-import.log:
• web-platform-tests/css/css-grid/implicit-grids/w3c-import.log:
• web-platform-tests/css/css-grid/inheritance-expected.txt: Added.
• web-platform-tests/css/css-grid/inheritance.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001-expected.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html: Added.
• web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
• web-platform-tests/css/css-grid/parsing/grid-area-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-area-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid.html: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-valid-expected.txt: Added.
• web-platform-tests/css/css-grid/parsing/grid-template-areas-valid.html: Added.
• web-platform-tests/css/css-grid/parsing/w3c-import.log: Added.
• web-platform-tests/css/css-grid/placement/w3c-import.log:
• web-platform-tests/css/css-grid/test-plan/w3c-import.log:
• web-platform-tests/css/css-grid/w3c-import.log:
• web-platform-tests/css/support/META.yml: Added.
• web-platform-tests/css/support/OWNERS: Removed.
• web-platform-tests/css/support/computed-testcommon.js: Added.

(test_computed_value):

• web-platform-tests/css/support/grid.css:

(.thirdRowThirdColumn):

• web-platform-tests/css/support/inheritance-testcommon.js: Added.

(assert_initial):

• web-platform-tests/css/support/parsing-testcommon.js: Added.

(test_valid_value):

• web-platform-tests/css/support/support/w3c-import.log:
• web-platform-tests/css/support/w3c-import.log:

LayoutTests:

• TestExpectations: Added bugs and ImageOnlyFailure for 3 tests that are failing.

1:32 PM Changeset in webkit [238078] by dbates@webkit.org

• 38 edits in trunk

[iOS] Draw caps lock indicator in password fields
​https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Source/WebCore:

Reviewed by Dean Jackson.

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac.

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

• WebCore.xcodeproj/project.pbxproj:
• page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().

• page/EventHandler.h:
• platform/cocoa/KeyEventCocoa.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.

• platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.

• platform/ios/WebEvent.h:
• platform/ios/WebEvent.mm:

(+[WebEvent modifierFlags]): Added.

• platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.

• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Reviewed by Dean Jackson.

Forward declare some more SPI.

• pal/spi/ios/GraphicsServicesSPI.h:
• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Reviewed by Dean Jackson.

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Reviewed by Dean Jackson.

Update the caps lock state when a hardware keyboard is attached or detached.

• WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Reviewed by Dean Jackson.

Expose some more symbols.

• WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

LayoutTests:

Unreviewed.

Update expected results now that iOS supports showing the caps lock indictor.

• platform/ios/fast/css/text-overflow-input-expected.txt:
• platform/ios/fast/forms/basic-inputs-expected.txt:
• platform/ios/fast/forms/input-appearance-height-expected.txt:
• platform/ios/fast/forms/input-value-expected.txt:
• platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
• platform/ios/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

1:29 PM Changeset in webkit [238077] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][BFC] In-flow positioned logic is really formatting context dependent.
​https://bugs.webkit.org/show_bug.cgi?id=191512

Reviewed by Simon Fraser.

Move block formatting context specific code from FormattingContext to BlockFormattingContext.

• layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.

• layout/FormattingContext.h:
• layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):

• layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.

• layout/blockformatting/BlockFormattingContext.h:
• layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.

• layout/inlineformatting/InlineFormattingContext.h:

12:00 PM Changeset in webkit [238076] by mitz@apple.com

• 4 edits
  1 add in trunk

ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=191514

Reviewed by Geoffrey Garen.

Source/WebKit:

Test: WebKitCocoa/WKProcessPoolConfiguration.mm

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.

(TEST):

9:13 AM Changeset in webkit [238075] by mmaxfield@apple.com

• 6 edits in trunk

Address post-review comments after r237955
​https://bugs.webkit.org/show_bug.cgi?id=191496

Reviewed by Darin Adler.

Source/WebCore:

• rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

• style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

• style/InlineTextBoxStyle.h:

LayoutTests:

• fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:

12:27 AM Changeset in webkit [238074] by benjamin@webkit.org

• 34 edits
  1 move in trunk

Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
​https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename file.

• API/JSValue.mm:

Source/WebCore:

Rename file.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
• page/mac/EventHandlerMac.mm:
• platform/mac/URLMac.mm:
• platform/mac/WebCoreNSURLExtras.mm:
• platform/mac/WebCoreObjCExtras.mm:
• rendering/RenderThemeMac.mm:

Source/WebKit:

• Platform/mac/StringUtilities.mm:
• UIProcess/ApplicationStateTracker.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

• Carbon/HIWebView.mm:
• Misc/WebNSFileManagerExtras.mm:
• Misc/WebNSURLExtras.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:
• Plugins/WebPluginContainerCheck.mm:
• WebCoreSupport/WebCachedFramePlatformData.h:
• WebCoreSupport/WebDeviceOrientationClient.mm:
• WebView/WebDelegateImplementationCaching.mm:
• WebView/WebHTMLView.mm:
• WebView/WebPDFRepresentation.mm:
• WebView/WebPolicyDelegate.mm:
• WebView/WebView.mm:

Tools:

Update file name.

• DumpRenderTree/mac/DumpRenderTree.mm:
• WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
• WebKitTestRunner/mac/TestControllerMac.mm:

Nov 10, 2018:

10:16 PM Changeset in webkit [238073] by benjamin@webkit.org

• 35 edits
  1 move in trunk

Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
​https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

• API/JSValue.mm:

Source/WebCore:

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
• page/mac/EventHandlerMac.mm:
• platform/mac/URLMac.mm:
• platform/mac/WebCoreNSURLExtras.mm:
• platform/mac/WebCoreObjCExtras.mm:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const):

Source/WebKit:

• Platform/mac/StringUtilities.mm:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::applicationDidEnterBackground):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):
(WebKit::ApplicationStateTracker::applicationWillEnterForeground):

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

• Carbon/HIWebView.mm:

(UpdateCommandStatus):

• Misc/WebNSFileManagerExtras.mm:
• Misc/WebNSURLExtras.mm:
• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:
• Plugins/WebPluginContainerCheck.mm:

(-[WebPluginContainerCheck _continueWithPolicy:]):

• WebCoreSupport/WebCachedFramePlatformData.h:

(WebCachedFramePlatformData::clear):

• WebCoreSupport/WebDeviceOrientationClient.mm:

(WebDeviceOrientationClient::getProvider const):

• WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallDelegateReturningBoolean):
(CallResourceLoadDelegateReturningBoolean):
(CallFormDelegate):
(CallFormDelegateReturningBoolean):

• WebView/WebHTMLView.mm:
• WebView/WebPDFRepresentation.mm:
• WebView/WebPolicyDelegate.mm:

(-[WebPolicyDecisionListener _usePolicy:]):

• WebView/WebView.mm:

Source/WTF:

Because renaming ObjcRuntimeExtras.h to ObjCRuntimeExtras.h only changes
the cases, some systems have issues with applying this patch.

To work around the problem, the change is made is two patches, first rename to
WTFObjCRuntimeExtras.h, then back to ObjCRuntimeExtras.h.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/WTFObjCRuntimeExtras.h: Renamed from Source/WTF/wtf/ObjcRuntimeExtras.h.

(wtfObjCMsgSend):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:
• WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
• WebKitTestRunner/mac/TestControllerMac.mm:

10:13 PM Changeset in webkit [238072] by Megan Gardner

• 2 edits in trunk/Source/WebCore

Fix build for 32bit Mac
​https://bugs.webkit.org/show_bug.cgi?id=191511

Unreviewed Build Fix.

Build fix, not tests needed.

Make the apporiate delecrations for 32-bit mac support.

• editing/mac/DictionaryLookup.mm:

4:26 PM Changeset in webkit [238071] by Simon Fraser

• 36 edits
  128 deletes in trunk

Remove support for -webkit-svg-shadow
​https://bugs.webkit.org/show_bug.cgi?id=187429
Source/WebCore:

<rdar://problem/41920735>

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSProperties.json:
• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::svgPropertyValue):

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitSvgShadow): Deleted.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::didAttachChild):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

• rendering/svg/RenderSVGImage.h:
• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::RenderSVGModelObject):

• rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::hasSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Deleted.

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::updateCachedBoundaries):

• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateRepaintBoundingBox):

• rendering/svg/RenderSVGShape.h:
• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::styleChanged):
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Deleted.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Deleted.
(WebCore::SVGRenderSupport::childAdded): Deleted.

• rendering/svg/SVGRenderSupport.h:

LayoutTests:

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

• css3/blending/svg-blend-layer-shadow.html: Removed.
• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• fast/css/getComputedStyle/resources/property-names.js:
• fast/repaint/moving-shadow-on-container-expected.png: Removed.
• fast/repaint/moving-shadow-on-container.html: Removed.
• fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• fast/repaint/moving-shadow-on-path.html: Removed.
• legacy-animation-engine/fast/css/getComputedStyle/resources/property-names.js:
• platform/gtk/TestExpectations:
• platform/gtk/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
• platform/gtk/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
• platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
• platform/gtk/fast/repaint/moving-shadow-on-path-expected.png: Removed.
• platform/gtk/svg/css/arrow-with-shadow-expected.png: Removed.
• platform/gtk/svg/css/composite-shadow-example-expected.png: Removed.
• platform/gtk/svg/css/composite-shadow-example-expected.txt: Removed.
• platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
• platform/gtk/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/gtk/svg/css/composite-shadow-with-opacity-expected.png: Removed.
• platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
• platform/gtk/svg/css/group-with-shadow-expected.png: Removed.
• platform/gtk/svg/css/shadow-changes-expected.png: Removed.
• platform/gtk/svg/css/shadow-changes-expected.txt: Removed.
• platform/gtk/svg/css/stars-with-shadow-expected.png: Removed.
• platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
• platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
• platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
• platform/gtk/svg/filters/shadow-on-filter-expected.png: Removed.
• platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
• platform/gtk/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
• platform/ios/TestExpectations:
• platform/ios/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
• platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/ios/svg/css/composite-shadow-example-expected.txt: Removed.
• platform/ios/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/ios/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
• platform/ios/svg/css/getComputedStyle-basic-expected.txt:
• platform/ios/svg/css/group-with-shadow-expected.txt: Removed.
• platform/ios/svg/css/shadow-changes-expected.txt: Removed.
• platform/ios/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/ios/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
• platform/mac-sierra/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/mac-sierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/mac-sierra/svg/css/getComputedStyle-basic-expected.txt:
• platform/mac/TestExpectations:
• platform/mac/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
• platform/mac/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
• platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
• platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
• platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
• platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• platform/mac/svg/css/arrow-with-shadow-expected.png: Removed.
• platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
• platform/mac/svg/css/clippath-with-shadow-expected.png: Removed.
• platform/mac/svg/css/composite-shadow-example-expected.png: Removed.
• platform/mac/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Removed.
• platform/mac/svg/css/getComputedStyle-basic-expected.txt:
• platform/mac/svg/css/group-with-shadow-expected.png: Removed.
• platform/mac/svg/css/group-with-shadow-expected.txt: Removed.
• platform/mac/svg/css/mask-with-shadow-expected.png: Removed.
• platform/mac/svg/css/path-with-shadow-expected.png: Removed.
• platform/mac/svg/css/shadow-and-opacity-expected.png: Removed.
• platform/mac/svg/css/shadow-changes-expected.png: Removed.
• platform/mac/svg/css/shadow-changes-expected.txt: Removed.
• platform/mac/svg/css/shadow-with-large-radius-expected.png: Removed.
• platform/mac/svg/css/shadow-with-negative-offset-expected.png: Removed.
• platform/mac/svg/css/stars-with-shadow-expected.png: Removed.
• platform/mac/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
• platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
• platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
• platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
• platform/mac/svg/filters/shadow-on-filter-expected.png: Removed.
• platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
• platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
• platform/win/TestExpectations:
• platform/win/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
• platform/win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
• platform/win/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
• platform/win/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/win/svg/css/group-with-shadow-expected.txt: Removed.
• platform/win/svg/css/shadow-changes-expected.txt: Removed.
• platform/win/svg/custom/simple-text-double-shadow-expected.txt: Removed.
• platform/wincairo/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
• platform/wincairo/fast/repaint/moving-shadow-on-path-expected.png: Removed.
• platform/wincairo/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/wincairo/svg/css/shadow-changes-expected.txt: Removed.
• platform/wincairo/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
• platform/wpe/svg/css/composite-shadow-text-expected.txt: Removed.
• platform/wpe/svg/css/shadow-changes-expected.txt: Removed.
• platform/wpe/svg/css/stars-with-shadow-expected.txt: Removed.
• platform/wpe/svg/custom/simple-text-double-shadow-expected.txt: Removed.
• platform/wpe/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
• svg/css/arrow-with-shadow-expected.txt: Removed.
• svg/css/arrow-with-shadow.svg: Removed.
• svg/css/circle-in-mask-with-shadow-expected.png: Removed.
• svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
• svg/css/circle-in-mask-with-shadow.svg: Removed.
• svg/css/clippath-with-shadow-expected.png: Removed.
• svg/css/clippath-with-shadow-expected.txt: Removed.
• svg/css/clippath-with-shadow.svg: Removed.
• svg/css/composite-shadow-example-expected.txt: Removed.
• svg/css/composite-shadow-example.html: Removed.
• svg/css/composite-shadow-text-expected.png: Removed.
• svg/css/composite-shadow-text.svg: Removed.
• svg/css/composite-shadow-with-opacity-expected.txt: Removed.
• svg/css/composite-shadow-with-opacity.html: Removed.
• svg/css/getComputedStyle-basic-expected.txt:
• svg/css/group-with-shadow-expected.txt: Removed.
• svg/css/group-with-shadow.svg: Removed.
• svg/css/mask-with-shadow-expected.txt: Removed.
• svg/css/mask-with-shadow.svg: Removed.
• svg/css/parent-shadow-offscreen-expected.svg: Removed.
• svg/css/parent-shadow-offscreen.svg: Removed.
• svg/css/path-with-shadow-expected.png: Removed.
• svg/css/path-with-shadow-expected.txt: Removed.
• svg/css/path-with-shadow.svg: Removed.
• svg/css/root-shadow-offscreen-expected.svg: Removed.
• svg/css/root-shadow-offscreen.svg: Removed.
• svg/css/shadow-and-opacity-expected.txt: Removed.
• svg/css/shadow-and-opacity.svg: Removed.
• svg/css/shadow-changes.svg: Removed.
• svg/css/shadow-with-large-radius-expected.png: Removed.
• svg/css/shadow-with-large-radius-expected.txt: Removed.
• svg/css/shadow-with-large-radius.svg: Removed.
• svg/css/shadow-with-negative-offset-expected.png: Removed.
• svg/css/shadow-with-negative-offset-expected.txt: Removed.
• svg/css/shadow-with-negative-offset.svg: Removed.
• svg/css/stars-with-shadow-expected.txt: Removed.
• svg/css/stars-with-shadow.html: Removed.
• svg/custom/simple-text-double-shadow-expected.png: Removed.
• svg/custom/simple-text-double-shadow-expected.txt: Removed.
• svg/custom/simple-text-double-shadow.svg: Removed.
• svg/custom/transform-with-shadow-and-gradient.svg: Removed.
• svg/filters/shadow-on-filter-expected.txt: Removed.
• svg/filters/shadow-on-filter.svg: Removed.
• svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
• svg/filters/shadow-on-rect-with-filter.svg: Removed.
• svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Removed.
• svg/repaint/repaint-webkit-svg-shadow-container.html: Removed.
• svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
• svg/repaint/repaint-webkit-svg-shadow.svg: Removed.

1:01 PM Changeset in webkit [238070] by Ryan Haddad

• 50 edits
  7 deletes in trunk

Unreviewed, rolling out r238065.

Breaks internal builds.

Reverted changeset:

"Make it possible to edit images inline"
​https://bugs.webkit.org/show_bug.cgi?id=191352
​https://trac.webkit.org/changeset/238065

12:12 PM Changeset in webkit [238069] by Michael Catanzaro

• 2 edits in trunk/Tools

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191221

Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
that it is disabled, but we're testing that it is enabled, because I failed to update this
line.

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

11:52 AM Changeset in webkit [238068] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, fix typo in r238066.

• accessibility/ios-simulator/form-control-validation-message.html:

11:27 AM Changeset in webkit [238067] by Michael Catanzaro

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, silence -Wunused-variable warning

• bytecode/Opcode.h:

(JSC::padOpcodeName):

9:43 AM Changeset in webkit [238066] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed attempt to deflake accessibility/ios-simulator/form-control-validation-message.html

• accessibility/ios-simulator/form-control-validation-message.html:

1:58 AM Changeset in webkit [238065] by timothy_horton@apple.com

• 50 edits
  11 adds in trunk

Make it possible to edit images inline
​https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html

editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

• page/Settings.yaml:

Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

• html/HTMLImageElement.h:

Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

• rendering/RenderImage.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):

• rendering/RenderLayerCompositor.h:

Make editable images require compositing implicitly.

Source/WebKit:

• Platform/spi/ios/PencilKitSPI.h: Added.
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

• Shared/WebPreferences.yaml:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a preference to enable editable images.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.

(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

• UIProcess/ios/WKDrawingView.h: Added.
• UIProcess/ios/WKDrawingView.mm: Added.

(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

• WebKit.xcodeproj/project.pbxproj:
• SourcesCocoa.txt:

Add the new files.

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

• DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

• TestRunnerShared/UIScriptContext/UIScriptController.h:
• TestRunnerShared/spi/PencilKitTestSPI.h: Added.
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

• TestExpectations:
• editing/images/basic-editable-image-expected.txt: Added.
• editing/images/basic-editable-image.html: Added.
• editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
• editing/images/reparent-editable-image-maintains-strokes.html: Added.
• platform/ios-wk2/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

Nov 9, 2018:

10:39 PM Changeset in webkit [238064] by Alan Bujtas

• 17 edits in trunk/Source

[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
​https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

1. Improve visuallyNonEmpty milestone confidence level.

Ignore whitespace and non visible text content.
Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
Check if the html/body is actually visible.

2. Issue initial paint soon after the milestone fires.

Use a 0ms timer to flush the initial paint.
Throttle additional flushes for 500ms and 1.5s (original behaviour).

3. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint.

• dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

• page/ChromeClient.h:
• page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

• page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.

• platform/graphics/FontCascade.h:
• rendering/RenderText.cpp: Check whether the text is actually visible at this point.

(WebCore::RenderText::RenderText):

Source/WebKit:

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):

• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

8:50 PM Changeset in webkit [238063] by wilander@apple.com

• 18 edits in trunk/Source

Add ability to configure document.cookie lifetime cap through user defaults
​https://bugs.webkit.org/show_bug.cgi?id=191480
<rdar://problem/45240871>

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. Existing test makes sure we don't regress.

This change makes the capped lifetime in seconds configurable through
user defaults.

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
(WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::filterCookies):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):

Source/WebKit:

This change makes the capped lifetime in seconds configurable through
user defaults.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAgeCapForClientSideCookies):
(WebKit::NetworkProcess::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm:

(WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::setAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::didSetAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

(WebKit::NetworkProcessProxy::didSetShouldCapLifetimeForClientSideCookies): Deleted.

Renamed didSetAgeCapForClientSideCookies().

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::setAgeCapForClientSideCookies):
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):
(WebKit::ResourceLoadStatisticsMemoryStore::didCreateNetworkProcess):

New function that handles all the things that need to be done when a network
process has been created.

• UIProcess/ResourceLoadStatisticsMemoryStore.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess):

Now just calls the corresponding function on its memory store where all the
configuration parameters are available.

• UIProcess/WebResourceLoadStatisticsStore.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setAgeCapForClientSideCookies):
(WebKit::WebsiteDataStore::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

• UIProcess/WebsiteData/WebsiteDataStore.h:

5:40 PM Changeset in webkit [238062] by Ryan Haddad

• 31 edits in trunk

Unreviewed, rolling out r238047.

Introduced layout test failures on iOS simulator.

Reverted changeset:

"[iOS] Draw caps lock indicator in password fields"
​https://bugs.webkit.org/show_bug.cgi?id=190565
​https://trac.webkit.org/changeset/238047

4:24 PM Changeset in webkit [238061] by Chris Dumez

• 11 edits in trunk

Suspended page persists even after back/forward list item is gone
​https://bugs.webkit.org/show_bug.cgi?id=191488
<rdar://problem/45953006>

Reviewed by Geoffrey Garen.

Source/WebKit:

Currently, the WebProcessPool owns the SuspendedPageProxy objects and makes sure we cap how
many we can have. The WebBackForwardListItem merely has a WeakPtr to its associated
SuspendedPageProxy. However, there is no point in having the WebProcessPool keeping a
SuspendedPageProxy object alive if there is no longer any WebBackForwardListItem pointing
to it.

To address the issue, WebBackForwardListItem nows tells the WebProcessPool to destroy
its SuspendedPageProxy when necessary. WebBackForwardList also takes care of nulling
out the WebBackForwardListItem's SuspendedPageProxy after the item has been removed
from the list (in case somebody keeps the item alive).

• Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setSuspendedPage):
(WebKit::WebBackForwardListItem::suspendedPageIsNoLongerNeeded):

• Shared/WebBackForwardListItem.h:
• UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::removeSuspendedPageProxy):

• UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

3:10 PM Changeset in webkit [238060] by Megan Gardner

• 1 edit
  1 copy
  1 add
  1 delete in trunk/LayoutTests

Fix Test Expectations for Reveal Test
​https://bugs.webkit.org/show_bug.cgi?id=191476

Unreviewed test gardening.

Put the test expectation in the correct location to deal with
the different behaviour old platforms.

• platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt.

3:04 PM Changeset in webkit [238059] by Ross Kirsling

• 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed Windows build fix for r238049.

• WebView.cpp:

(WebView::initWithFrame):

2:57 PM Changeset in webkit [238058] by timothy_horton@apple.com

• 3 edits
  2 adds in trunk

Normal-flow-only flex items don't correctly respect z-index
​https://bugs.webkit.org/show_bug.cgi?id=191486

Reviewed by Simon Fraser.

Source/WebCore:

Test: css3/flexbox/z-index-with-normal-flow-only.html

• rendering/RenderLayer.cpp:

(WebCore::canCreateStackingContext):
r125693 did not ensure that flex items which would otherwise be
normal-flow-only would be put into the z-order tree when necessary.
Fix by respecting the same trigger we use to make layers for flex items;
namely, not having auto z-index.

LayoutTests:

• css3/flexbox/z-index-with-normal-flow-only-expected.html: Added.
• css3/flexbox/z-index-with-normal-flow-only.html: Added.

Add a test that a <canvas> with z-index 50 correctly stacks below
a <canvas> that is a flex-item with z-index 100.

2:50 PM Changeset in webkit [238057] by Wenson Hsieh

• 7 edits in trunk

[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
​https://bugs.webkit.org/show_bug.cgi?id=191471
<rdar://problem/45952472>

Reviewed by Tim Horton.

Source/WebCore:

Add new method stubs for changing the list type for the current selection (to be implemented in a future patch).

• editing/Editor.cpp:

(WebCore::Editor::canChangeSelectionListType):
(WebCore::Editor::changeSelectionListType):

• editing/Editor.h:

Source/WebKit:

Implement these method stubs by calling into Editor.

Test: WKWebViewEditActions.ModifyListLevel

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Tools:

Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.

• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

2:34 PM Changeset in webkit [238056] by Jon Davis

• 15 edits in trunk/Websites/webkit.org

Clean-up stray whitespace in theme files
​https://bugs.webkit.org/show_bug.cgi?id=191430

Reviewed by Dean Jackson.

• wp-content/themes/webkit/css-status.php:
• wp-content/themes/webkit/footer.php:
• wp-content/themes/webkit/front-page.php:
• wp-content/themes/webkit/includes.php:
• wp-content/themes/webkit/nightly-start.php:
• wp-content/themes/webkit/nightly-survey.php:
• wp-content/themes/webkit/page.php:
• wp-content/themes/webkit/scripts/global.js:
• wp-content/themes/webkit/scripts/searchbuilds.js:

(initsearch):
(initsearch.displayError):

• wp-content/themes/webkit/single.php:
• wp-content/themes/webkit/sitemap.php:
• wp-content/themes/webkit/team.php:
• wp-content/themes/webkit/widgets/icon.php:
• wp-content/themes/webkit/widgets/page.php:

2:32 PM Changeset in webkit [238055] by Keith Rollin

• 6 edits in trunk/Source

Unreviewed build fix after ​https://bugs.webkit.org/show_bug.cgi?id=191324

Remove the use of .xcfilelists until their side-effects are better
understood.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

1:59 PM Changeset in webkit [238054] by jer.noble@apple.com

• 6 edits
  2 adds in trunk

SourceBuffer throws an error when appending a second init segment after changeType().
​https://bugs.webkit.org/show_bug.cgi?id=191474

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-changetype-second-init.html

When encountering an initialization segment after changeType(), add the parsed codec types
to the list of allowed codecs.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::validateInitializationSegment):

• platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::supportsType):

• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::canSwitchToType):

• platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

• media/media-source/media-source-changetype-second-init-expected.txt: Added.
• media/media-source/media-source-changetype-second-init.html: Added.

1:26 PM Changeset in webkit [238053] by eric.carlson@apple.com

• 4 edits in trunk/Source/WebCore

[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
​https://bugs.webkit.org/show_bug.cgi?id=191479
<rdar://problem/45952201>

Reviewed by Jer Noble.

No new tests, tested manually.

• platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::standardVideoSizes): Drive-by fix: add a few more standard
video frame sizes, correct a typo.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate): Drive-by fix: don't consider
rescaled sized when we already have an exact or aspect ratio match because it won't be used.

• platform/mediastream/mac/AVVideoCaptureSource.h:

(WebCore::AVVideoCaptureSource::width const): Deleted.
(WebCore::AVVideoCaptureSource::height const): Deleted.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset): Delete m_requestedSize.
(WebCore::AVVideoCaptureSource::shutdownCaptureSession): Delete m_width and m_height.
(WebCore::AVVideoCaptureSource::processNewFrame): Don't call setSize with captured size,
the frame may be resized before deliver.

1:10 PM Changeset in webkit [238052] by Ross Kirsling

• 6 edits in trunk/Source

Unreviewed MSVC build fix after r238039 (and r238046).

Source/WebCore:

• bindings/js/JSWorkerGlobalScopeBase.cpp:
• bindings/js/JSWorkerGlobalScopeBase.h:

Source/WebKitLegacy/win:

• WebDocumentLoader.h:
• WebView.cpp:

(WebView::setShouldApplyMacFontAscentHack):

12:43 PM Changeset in webkit [238051] by basuke.suzuki@sony.com

• 28 edits
  3 copies
  3 adds in trunk

[Curl][WebKit] Implement Proxy configuration API.
​https://bugs.webkit.org/show_bug.cgi?id=189053

Reviewed by Youenn Fablet.

Source/WebCore:

Added API to set proxy from the app.

No new tests because there's no behaviour change in WebCore.

• platform/network/NetworkStorageSession.h:
• platform/network/curl/CurlContext.h:

(WebCore::CurlContext::setProxySettings):

• platform/network/curl/CurlProxySettings.h:
• platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setProxySettings const):

Source/WebKit:

Added proxy configuration API to WebsiteDataStore. Three API were added in WKWebsiteDataStoreRefCurl.h:

• WKWebsiteDataStoreEnableDefaultNetworkProxySettings(WKWebsiteDataStoreRef)
• WKWebsiteDataStoreEnableCustomNetworkProxySettings(WKWebsiteDataStoreRef, WKURLRef, WKStringRef ignoreHosts)
• WKWebsiteDataStoreDisableNetworkProxySettings(WKWebsiteDataStoreRef)

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSessionCreationParameters.h:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

• NetworkProcess/curl/NetworkProcessCurl.cpp:

(WebKit::NetworkProcess::setNetworkProxySettings):

• NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

• NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

• PlatformWin.cmake:
• Shared/WebCoreArgumentCoders.h:
• Shared/curl/WebCoreArgumentCodersCurl.cpp:

(IPC::ArgumentCoder<CurlProxySettings>::encode):
(IPC::ArgumentCoder<CurlProxySettings>::decode):

• UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.

(WKWebsiteDataStoreEnableDefaultNetworkProxySettings):
(WKWebsiteDataStoreEnableCustomNetworkProxySettings):
(WKWebsiteDataStoreDisableNetworkProxySettings):

• UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.h: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::networkProxySettings const):

• UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.

(WebKit::WebsiteDataStore::platformSetParameters):
(WebKit::WebsiteDataStore::setNetworkProxySettings):

Tools:

Added Proxy Settings dialog to call newly added API.

• MiniBrowser/win/BrowserWindow.h:
• MiniBrowser/win/Common.cpp:

(askProxySettings):
(askCredential):
(authDialogProc): Deleted.

• MiniBrowser/win/Common.h:
• MiniBrowser/win/DialogHelper.h: Added.

(Dialog::run):
(Dialog::doalogProc):
(Dialog::handle):
(Dialog::setup):
(Dialog::update):
(Dialog::validate):
(Dialog::updateOkButton):
(Dialog::command):
(Dialog::ok):
(Dialog::cancel):
(Dialog::close):
(Dialog::hDlg):
(Dialog::item):
(Dialog::setEnabled):
(Dialog::setText):
(Dialog::getText):
(Dialog::getTextLength):
(Dialog::RadioGroup::RadioGroup):
(Dialog::RadioGroup::set):
(Dialog::RadioGroup::get):
(Dialog::radioGroup):

• MiniBrowser/win/MainWindow.cpp:

(MainWindow::WndProc):

• MiniBrowser/win/MiniBrowserLib.rc:
• MiniBrowser/win/MiniBrowserLibResource.h:
• MiniBrowser/win/WebKitBrowserWindow.cpp:

(createWKURL):
(WebKitBrowserWindow::WebKitBrowserWindow):
(WebKitBrowserWindow::updateProxySettings):
(WebKitBrowserWindow::loadURL):
(WebKitBrowserWindow::loadHTMLString):
(WebKitBrowserWindow::openProxySettings):

• MiniBrowser/win/WebKitBrowserWindow.h:
• MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(WebKitLegacyBrowserWindow::openProxySettings):

• MiniBrowser/win/WebKitLegacyBrowserWindow.h:

12:16 PM Changeset in webkit [238050] by Wenson Hsieh

• 12 edits
  1 move in trunk

[Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
​https://bugs.webkit.org/show_bug.cgi?id=191410
<rdar://problem/45898610>

Reviewed by Dean Jackson.

Source/WebKit:

Prefixes a few iOS-only SPI methods declared on WKWebView in r236867 with underscores, and also exposes some
more cross-platform Cocoa editing SPI. Once the unprefixed SPI methods are no longer used by internal clients,
these will need to be removed (see followup bug: webkit.org/b/191450). See below for more details.

Covered by new and existing API tests in WKWebViewEditActions.

• UIProcess/API/Cocoa/WKWebView.mm:

Hoist the definition (and undefinition) of FORWARD_ACTION_TO_WKCONTENTVIEW to encompass both the WKWebView
implementation and the WKWebView (WKPrivate) implementation. This allows us to use this macro when implementing
SPI methods in the WKPrivate category, as well as methods that are part of the main WKWebView implementation.

(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):

Add forwarding for the new editing commands in -canPerformAction: and -targetForAction:.

(-[WKWebView _toggleStrikeThrough:]):
(-[WKWebView _increaseListLevel:]):
(-[WKWebView _decreaseListLevel:]):
(-[WKWebView _changeListType:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):

Add definitions for the new editing methods on WKWebView, using macros (WEBCORE_PRIVATE_COMMAND on macOS and
FORWARD_ACTION_TO_WKCONTENTVIEW on iOS) to help reduce the code duplication.

(-[WKWebView _pasteAsQuotation:]): Deleted.

Remove this method definition, which is now replaced by macros on iOS and macOS.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Introduce the new SPI to WKWebView (WKPrivate), and add FIXMEs to remove old, unprefixed variants of the SPI.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::increaseListLevel):
(WebKit::WebPageProxy::decreaseListLevel):
(WebKit::WebPageProxy::changeListType):

Add plumbing for these list editing commands.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _increaseListLevelForWebView:]):
(-[WKContentView _decreaseListLevelForWebView:]):
(-[WKContentView _changeListTypeForWebView:]):
(-[WKContentView _toggleStrikeThroughForWebView:]):
(-[WKContentView _setFontForWebView:sender:]):
(-[WKContentView _setFontSizeForWebView:sender:]):
(-[WKContentView _setTextColorForWebView:sender:]):
(-[WKContentView toggleStrikeThroughForWebView:]):
(-[WKContentView setFontForWebView:sender:]):
(-[WKContentView setFontSizeForWebView:sender:]):
(-[WKContentView setTextColorForWebView:sender:]):
(-[WKContentView canPerformActionForWebView:withSender:]):

Check for the new action selectors here, and additionally add validation for _pasteAsQuotation:. Let the
unprefixed versions of these methods simply call the prefixed versions (these method implementations will be
removed in a followup once doing so would not affect any clients of WebKit).

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Add stubs for several list editing commands that are yet to be hooked up to WebCore. These will be implemented
in a future patch.

Tools:

Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
Additionally, add new API tests to verify that -_pasteAsQuotation: and -_insertNested(Un)OrderedList: are
hooked up to their respective editing commands.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.

(-[TestWKWebView querySelectorExists:]):
(-[TestWKWebView insertString:]):

Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
invoking the WKWebView directly on macOS and calling on the content view on iOS.

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

11:47 AM Changeset in webkit [238049] by Antti Koivisto

• 48 edits
  1 move in trunk/Source

Use OptionSet for layout milestones
​https://bugs.webkit.org/show_bug.cgi?id=191470

Reviewed by Dean Jackson.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyFrameLoaderClient.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didReachLayoutMilestone):

• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::addPaintPendingMilestones):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::firePaintRelatedMilestonesIfNeeded):

• page/FrameView.h:
• page/LayoutMilestone.h: Copied from Source/WebCore/page/LayoutMilestones.h.

Renamed to appease WK2 IPC code generation.

• page/LayoutMilestones.h: Removed.
• page/Page.cpp:

(WebCore::Page::addLayoutMilestones):
(WebCore::Page::removeLayoutMilestones):
(WebCore::Page::isCountingRelevantRepaintedObjects const):

• page/Page.h:

(WebCore::Page::requestedLayoutMilestones const):

Source/WebKit:

• Shared/API/Cocoa/_WKRenderingProgressEventsInternal.h:

(renderingProgressEvents):

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones const):
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones):

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didReachLayoutMilestone):

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::renderingProgressDidChange):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient):

• UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:

(pageRenderingProgressEvents):

• UIProcess/API/Cocoa/WKWebView.mm:

(layoutMilestones):

• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::renderingProgressDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::listenForLayoutMilestones):
(WebKit::WebPageProxy::didLayoutForCustomContentProvider):
(WebKit::WebPageProxy::didReachLayoutMilestone):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

• WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::didReachLayoutMilestone):
(API::InjectedBundle::PageLoaderClient::layoutMilestones const):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone):
(WebKit::InjectedBundlePageLoaderClient::layoutMilestones const):

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::dispatchDidReachLayoutMilestone):

• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
(WebKit::WebPage::listenForLayoutMilestones):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedLayoutMilestones):
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

• WebView/WebView.mm:

(coreLayoutMilestones):
(kitLayoutMilestones):
(-[WebView _cacheFrameLoadDelegateImplementations]):

• WebView/WebViewInternal.h:

Source/WebKitLegacy/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

• WebCoreSupport/WebFrameLoaderClient.h:

11:23 AM Changeset in webkit [238048] by Joseph Pecoraro

• 25 edits in trunk/Source/WebInspectorUI

Web Inspector: Start moving toward better multi-target support
​https://bugs.webkit.org/show_bug.cgi?id=191345

Reviewed by Devin Rousso.

This change continues the move toward better multi-target support
by explicitly using explicit target agents in more places, and
converting generalized feature checks into target agnostic versions
that use the new InspectorBackend.domains, which does not vary based
on the connected targets / debuggable type.

I also audited uses of RuntimeAgent, ConsoleAgent, and DebuggerAgent
for better multi-target support since these agents should already
have complete multi-target support.

• UserInterface/Protocol/Target.js:

(WI.Target.prototype.initialize):
Move explicitly to target.Agent feature checks with a known target.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Move explicitly to target.DebuggerAgent for feature checks with a known target.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.initializeTarget):
Move explicitly to target.NetworkAgent for feature checks with a known target.

• UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager.prototype.initializeTarget):
(WI.RuntimeManager.prototype.saveResult):

• UserInterface/Protocol/RemoteObject.js:

(WI.RemoteObject.prototype.updatePreview):
(WI.RemoteObject.prototype.getDisplayablePropertyDescriptors):
(WI.RemoteObject.prototype.deprecatedGetDisplayableProperties):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
(WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
Move explicitly to target.RuntimeAgent for feature checks with a known target.

• UserInterface/Models/CSSCompletions.js:

(WI.CSSCompletions.initializeCSSCompletions):
Move explicitly to target.CSSAgent for feature checks with a known target.

• UserInterface/Views/ContextMenuUtilities.js:

Use the DebuggerAgent from the target associated with the DOMNode's
remote object instead of assuming the main target.

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Update the ConsoleAgent setting on all targets that support it.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView):
All backends support BreakpointActionType, the assertion can go away.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.get navigationItems):

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get navigationItems):
Include additional window.FooAgent checks for these since they will need
to be revisited in the future.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.get domains):
(InspectorBackendClass.prototype.activateDomain):
Expose InspectorBackend.domains.<Domain> for feature checking.

• UserInterface/Controllers/BreakpointPopoverController.js:

(WI.BreakpointPopoverController.prototype._createPopoverContent):

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager):
(WI.CSSManager.prototype._mainResourceDidChange):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._attemptAutoCapturingForFrame):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
(WI.TimelineManager):

• UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingFinished):

• UserInterface/Models/ScriptSyntaxTree.js:

(WI.ScriptSyntaxTree.functionReturnDivot):

• UserInterface/Protocol/DebuggerObserver.js:

(WI.DebuggerObserver):

• UserInterface/Protocol/NetworkObserver.js:

(WI.NetworkObserver.prototype.requestWillBeSent):

• UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointClicked):

• UserInterface/Views/NetworkTimelineView.js:

(WI.NetworkTimelineView):

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):

• UserInterface/Views/WebSocketContentView.js:

(WI.WebSocketContentView):
(WI.NetworkManager.prototype.webSocketWillSendHandshakeRequest):
(WI.DebuggerManager.prototype.debuggerDidResume):
Feature check in a target agnostic way.

11:10 AM Changeset in webkit [238047] by dbates@webkit.org

• 31 edits in trunk

[iOS] Draw caps lock indicator in password fields
​https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Reviewed by Dean Jackson.

Source/WebCore:

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac. For now, we only draw the
indicator when caps locks is enabled via the hardware keyboard. We will look to support the software
keyboard in a subsequent commit (see <​https://bugs.webkit.org/show_bug.cgi?id=191475>).

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

• WebCore.xcodeproj/project.pbxproj:
• page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().

• page/EventHandler.h:
• platform/cocoa/KeyEventCocoa.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.

• platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.

• platform/ios/WebEvent.h:
• platform/ios/WebEvent.mm:

(+[WebEvent modifierFlags]): Added.

• platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.

• rendering/RenderThemeCocoa.h:
• rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.

• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Forward declare some more SPI.

• pal/spi/ios/GraphicsServicesSPI.h:
• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Update the caps lock state when a hardware keyboard is attached or detached.

• WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Expose some more symbols.

• WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

11:04 AM Changeset in webkit [238046] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix WinCairo build after r238039.

• bindings/js/JSWorkerGlobalScopeBase.h:

10:58 AM Changeset in webkit [238045] by timothy_horton@apple.com

• 4 edits in trunk/Source/WebKit

Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
​https://bugs.webkit.org/show_bug.cgi?id=191449
<rdar://problem/45884977>

Reviewed by Eric Carlson.

UIRemoteView has some nice process assertion management that it would
be nice to not duplicate. So, we can just use it instead of CALayerHost!

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::page const):

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKUIRemoteView hitTest:withEvent:]):
(-[WKUIRemoteView description]):
(createRemoteView):
(WebKit::RemoteLayerTreeHost::createLayer):

10:42 AM Changeset in webkit [238044] by Fujii Hironori

• 3 edits in trunk/Source/WebCore

Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191451

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

• platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback): Deleted unused method.

• platform/graphics/opengl/Extensions3DOpenGLES.h: Marked 'override'.

10:35 AM Changeset in webkit [238043] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit

[MediaStream] Make screen capture an experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=191472
<rdar://problem/45946499>

Reviewed by Jer Noble.

• Shared/WebPreferences.yaml: Make ScreenCaptureEnabled an experimental feature.

10:27 AM Changeset in webkit [238042] by aestes@apple.com

• 10 edits
  1 add in trunk

[Payment Request] canMakePayment() should not consider serialized payment method data
​https://bugs.webkit.org/show_bug.cgi?id=191432

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

• web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.

Source/WebCore:

In ​https://github.com/w3c/payment-request/pull/806, we're changing the specification of
canMakePayment() to not consider serialized payment method data when deciding if a payment
method is supported. For Apple Pay, this means we resolve to true for
"​https://apple.com/apple-pay", even if an ApplePayRequest is omitted or is missing required
fields.

Added test cases to
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html and
http/tests/paymentrequest/payment-request-show-method.https.html.

• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

• http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
• http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Updated with

changes from imported/w3c/web-platform-tests/payment-request/. Modified two tests to use
user_activation_test() rather than test_driver.bless().

• http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
• http/tests/paymentrequest/payment-request-show-method.https.html: Now that canMakePayment

does not convert payment method data, added a test that ensures show() rejects with a
TypeError when Apple Pay's payment method data is invalid.

• platform/ios-wk2/TestExpectations: Un-skipped payment-request-canmakepayment-method.https.html.
• platform/mac-wk2/TestExpectations: Ditto.

10:22 AM Changeset in webkit [238041] by aestes@apple.com

• 7 edits in trunk

Source/WebCore:
[Payment Request] PaymentResponse.details should be updated when the user accepts a retried payment
​https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

PaymentResponse.details was being initialized in the PaymentResponse constructor and never
updated when the user accepts a retried payment. We need to update it.

Added a test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::accept):

• Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::setDetailsFunction):

• Modules/paymentrequest/PaymentResponse.h:

LayoutTests:
[Payment Request] PaymentResponse.details should be updated when the user accepts a rpayment retry
​https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

• http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
• http/tests/paymentrequest/payment-response-retry-method.https.html:

10:19 AM Changeset in webkit [238040] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191453

Reviewed by Per Arne Vollan.

No new tests because there is no behavior change.

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: Marked with 'override' and removed 'virtual'.

9:48 AM Changeset in webkit [238039] by Chris Dumez

• 5 edits in trunk/Source/WebCore

Unreviewed attempt to fix internal build on macOS.

'Export' is defined in several headers.

• bindings/js/JSDOMGlobalObject.cpp:
• bindings/js/JSDOMGlobalObject.h:
• bridge/jsc/BridgeJSC.cpp:
• bridge/jsc/BridgeJSC.h:

9:37 AM Changeset in webkit [238038] by Chris Dumez

• 29 edits
  3 moves
  3 adds in trunk

HTML form validation bubble disappears
​https://bugs.webkit.org/show_bug.cgi?id=191418

Reviewed by Simon Fraser.

Source/WebCore:

If we validate a form and find an invalid form control, we'll scroll it into view and show
the validation bubble. However, scrolling the element into view may be an asynchronous
operation, in which case it would discard the validation bubble prematurely because scrolling
hides the validation bubble. To address the issue, we now show the validation message
asynchronously after focusing the element (and potentially scrolling it into view).

Test: fast/forms/scroll-into-view-and-show-validation-message.html

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::focusAndShowValidationMessage):

LayoutTests:

Add API test coverage and update existing tests to use form-validation.js and
avoid code duplication.

• fast/forms/form-validation.js: Added.

(getValidationBubbleContents):
(getValidationBubble.return.new.Promise.):
(getValidationBubble):

• fast/forms/ios/validation-bubble-dismiss-on-tap-expected.txt:
• fast/forms/ios/validation-bubble-dismiss-on-tap.html:
• fast/forms/navigation-dismisses-validation-bubbles-expected.txt: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt.
• fast/forms/navigation-dismisses-validation-bubbles.html: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html.
• fast/forms/resources/check-validation-bubble-not-visible.html: Renamed from LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html.
• fast/forms/scroll-into-view-and-show-validation-message-expected.txt: Added.
• fast/forms/scroll-into-view-and-show-validation-message.html: Added.
• fast/forms/validation-bubble-disappears-when-input-detached-expected.txt:
• fast/forms/validation-bubble-disappears-when-input-detached.html:
• fast/forms/validation-bubble-disappears-when-input-moved-expected.txt:
• fast/forms/validation-bubble-disappears-when-input-moved.html:
• fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt:
• fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html:
• fast/forms/validation-bubble-escape-key-dismiss-expected.txt:
• fast/forms/validation-bubble-escape-key-dismiss.html:
• fast/forms/validation-custom-message-expected.txt:
• fast/forms/validation-custom-message.html:
• fast/forms/validation-message-detached-iframe-expected.txt:
• fast/forms/validation-message-detached-iframe.html:
• fast/forms/validation-message-detached-iframe2-expected.txt:
• fast/forms/validation-message-detached-iframe2.html:
• fast/forms/validation-message-minimum-font-size-expected.txt:
• fast/forms/validation-message-minimum-font-size.html:
• fast/forms/validation-messages-expected.txt:
• fast/forms/validation-messages.html:
• platform/gtk/TestExpectations:
• platform/ios-wk1/TestExpectations:
• platform/win/TestExpectations:

9:32 AM Changeset in webkit [238037] by Brent Fulgham

• 4 edits in trunk/Source/WebCore

[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
​https://bugs.webkit.org/show_bug.cgi?id=191452
<rdar://problem/45933964>

Reviewed by Zalan Bujtas.

Do a better job of balancing the BeginFigure/EndFigure calls in
the PathDirect2D implementation. Failure to do so puts the Geometry sink
into an error state that prevents it from producing drawing output.

• platform/graphics/Path.h:
• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPath): Flush is needed here.
(WebCore::GraphicsContext::fillPath): Ditto.
(WebCore::GraphicsContext::strokePath): Ditto.

• platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::drawDidComplete):
(WebCore::Path::closeAnyOpenGeometries):
(WebCore::Path::transform):
(WebCore::Path::openFigureAtCurrentPointIfNecessary):
(WebCore::Path::moveTo):
(WebCore::Path::closeSubpath):

9:27 AM Changeset in webkit [238036] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKitLegacy

Remove legacy storage tracker database file after r237330
​https://bugs.webkit.org/show_bug.cgi?id=191423

Reviewed by Geoffrey Garen.

r237330 changed the file name of storage tracker database, but it did not remove the old
file before using the new one.

• Storage/StorageTracker.cpp:

(WebKit::StorageTracker::internalInitialize):

9:24 AM Changeset in webkit [238035] by jer.noble@apple.com

• 6 edits
  1 copy
  3 adds in trunk

[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
​https://bugs.webkit.org/show_bug.cgi?id=191396

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Modify the changetype test suite to include a HEVC version.

• web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4: Added.
• web-platform-tests/media-source/mediasource-changetype-util.js:

(findSupportedChangeTypeTestTypes):

Source/WebCore:

When changeType() is called, exempt video and text tracks (in addition to just audio tracks)
from "same codec" requirements.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::validateInitializationSegment):

LayoutTests:

• platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
• platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:

9:16 AM Changeset in webkit [238034] by Ryan Haddad

• 1 edit
  2 adds in trunk/LayoutTests

Clean up test expectations after r237942
​https://bugs.webkit.org/show_bug.cgi?id=191448

Unreviewed test gardening.

Add test expectation files for Sierra WK1.

• platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added.
• platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added.

9:06 AM Changeset in webkit [238033] by dbates@webkit.org

• 5 edits
  2 adds in trunk

[iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
action when forward delete is pressed outside a text field
​https://bugs.webkit.org/show_bug.cgi?id=190566
<rdar://problem/45262367>

Reviewed by Wenson Hsieh.

Source/WebKit:

Override -_deleteForwardAndNotify to perform a forward deletion and remove the dead code that
expected UIKit to send us a character string with 0xF728 for the forward delete key. UIKit
ceased doing this many years ago. We may revist this decision once <rdar://problem/45772078>
is fixed.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView _deleteForwardAndNotify:]):

Source/WebKitLegacy/mac:

Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.

• WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

LayoutTests:

Add a test to ensure that pressing the forward delete key deletes the next character.

• fast/events/ios/forward-delete-in-editable-expected.txt: Added.
• fast/events/ios/forward-delete-in-editable.html: Added.

8:42 AM Changeset in webkit [238032] by Fujii Hironori

• 2 edits in trunk/Source/WebKitLegacy/win

WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191455

Reviewed by Brent Fulgham.

• WebHistory.h: Marked with 'override' and removed 'virtual'.

8:40 AM Changeset in webkit [238031] by keith_miller@apple.com

• 6 edits in trunk/Source

LLInt VectorSizeOffset should be based on offset extraction
​https://bugs.webkit.org/show_bug.cgi?id=191468

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This patch also adds some usings to LLIntOffsetsExtractor that
make it possible to use the bare names of Vector/RefCountedArray
in offsets extraction.

• llint/LLIntOffsetsExtractor.cpp:
• llint/LowLevelInterpreter.asm:

Source/WTF:

Make things friends with LLIntOffsetsExtractor.

• wtf/RefCountedArray.h:
• wtf/Vector.h:

8:15 AM Changeset in webkit [238030] by Carlos Garcia Campos

• 4 edits in trunk

REGRESSION(r236365): [GTK] Many form-related tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=189993

Reviewed by Michael Catanzaro.

Source/WebCore:

Only the first form data element is added to the message body due to a return added by mistake in r236365.

• platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.

LayoutTests:

Remove expectations for tests that are passing now.

• platform/gtk/TestExpectations:

7:30 AM Changeset in webkit [238029] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[WTF] Changes in bug 188867 break non-Linux Unix builds
​https://bugs.webkit.org/show_bug.cgi?id=191380

The intention of 188867 was to split out platform-specific
heap query/release code. Any unsupported platform
would use a generic, no-op stub. However, wtf/PlatformGTK.cmake
ended up sending all non-Linux platforms through the Linux
implementation, which breaks the build for those platforms.
This includes any user of the GTK target which is not Linux,
such as the *BSDs, Solaris, etc.

Patch by Jim Mason <​jmason@ibinx.com> on 2018-11-09
Reviewed by Yusuke Suzuki.

• wtf/PlatformGTK.cmake: Updated to include Linux-specific

code only for Linux; all other platforms use the generic stub.

7:28 AM Changeset in webkit [238028] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry
​https://bugs.webkit.org/show_bug.cgi?id=191445

Reviewed by Antti Koivisto.

The idea here is that Line should not have to deal with all the post processig tasks like the runs final aligments.
(The line class would eventually turn into a collection of random things).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):

• layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Line::contentLogicalLeft const):
(WebCore::Layout::InlineFormattingContext::Line::lastRunType const):

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::adjustedLineLogicalLeft):
(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):
(WebCore::Layout::InlineFormattingContext::Geometry::computeExpansionOpportunities):

• layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::Line):
(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight const):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):
(WebCore::Layout::adjustedLineLogicalLeft): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::computeExpansionOpportunities): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::justifyRuns): Deleted.

7:05 AM Changeset in webkit [238027] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, GStreamer build warning fix

• platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::newSampleCallback): Timesamp()
returns a uint32_t, fix format string accordingly.

3:32 AM Changeset in webkit [238026] by yusukesuzuki@slowstart.org

• 9 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling in CodeCache in r237254
​https://bugs.webkit.org/show_bug.cgi?id=190340

Land the CodeCache part, which uses DefaultHash<>::Hash instead of computeHash.

• bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

• bytecode/UnlinkedFunctionExecutable.h:
• parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):

• runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

• runtime/CodeCache.h:
• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::fromGlobalCode):

• runtime/FunctionExecutable.h:

2:53 AM Changeset in webkit [238025] by Philippe Normand

• 5 edits
  2 adds in trunk/Tools

[Flatpak] Refactoring and drive-by fixes
​https://bugs.webkit.org/show_bug.cgi?id=191421

Reviewed by Michael Catanzaro.

• Scripts/webkitdirs.pm:

(inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
the sandbox, so rely on this.

• flatpak/flatpakutils.py:

(expand_manifest): Pass explicit keywords to load_manifest() and
remove unused local variable.
(WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
(WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
(WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
build_type handling a bit.

• flatpak/org.webkit.CommonModules.yaml: Added.
• flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
• flatpak/org.webkit.WebKit.yaml: Move common dependencies

declaration to CommonModules, so it can be reused later when we
add support for building extra libraries depending on WPE.

1:22 AM Changeset in webkit [238024] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

put_by_val opcodes need to add the number tag as a 64-bit register
​https://bugs.webkit.org/show_bug.cgi?id=191456

Reviewed by Saam Barati.

Previously the LLInt would add it as a pointer sized value. That is
wrong if pointer size is less 64-bits.

• llint/LowLevelInterpreter64.asm:

Nov 8, 2018:

11:13 PM Changeset in webkit [238023] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: ResourceQueryController should early return when query is longer than search string
​https://bugs.webkit.org/show_bug.cgi?id=191436

Reviewed by Devin Rousso.

• UserInterface/Controllers/ResourceQueryController.js:

• UserInterface/Models/ResourceQueryMatch.js:

(WI.ResourceQueryMatch):
Drive-by fixes.

10:52 PM Changeset in webkit [238022] by bshafiei@apple.com

• 2 edits in tags/Safari-607.1.13.1/Source/JavaScriptCore

Cherry-pick r238012. rdar://problem/45930711

Options::useRegExpJIT() should use jitEnabledByDefault() just like useJIT()
​https://bugs.webkit.org/show_bug.cgi?id=191444

Reviewed by Saam Barati.

• runtime/Options.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:52 PM Changeset in webkit [238021] by bshafiei@apple.com

• 2 edits in tags/Safari-607.1.13.1/Source/JavaScriptCore

Cherry-pick r238000. rdar://problem/45922187

jitEnabledByDefault() should be on useJIT not useBaselineJIT
​https://bugs.webkit.org/show_bug.cgi?id=191434

Reviewed by Saam Barati.

• runtime/Options.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:49 PM Changeset in webkit [238020] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Unreviewed, try to fix the 32-bit macOS build

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showDefinitionForAttributedString):

10:48 PM Changeset in webkit [238019] by bshafiei@apple.com

• 7 edits in tags/Safari-607.1.13.1/Source

Versioning.

10:47 PM Changeset in webkit [238018] by bshafiei@apple.com

• 1 copy in tags/Safari-607.1.13.1

New tag.

10:07 PM Changeset in webkit [238017] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: undefined is not an object (evaluating 'treeElement.parent.removeChild')
​https://bugs.webkit.org/show_bug.cgi?id=191454

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-08
Reviewed by Matt Baker.

• UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._scriptsCleared):
This was intending to iterate the Map's values, which are tree elements.

9:30 PM Changeset in webkit [238016] by Ross Kirsling

• 3 edits in trunk/Source/JavaScriptCore

[JSC] isStrWhiteSpace seems redundant with Lexer<UChar>::isWhiteSpace
​https://bugs.webkit.org/show_bug.cgi?id=191439

Reviewed by Saam Barati.

• CMakeLists.txt:
• runtime/ParseInt.h:

(JSC::isStrWhiteSpace):
Define isStrWhiteSpace in terms of isWhiteSpace and isLineTerminator.

7:23 PM Changeset in webkit [238015] by commit-queue@webkit.org

• 23 edits
  3 adds in trunk

Source/WebCore:
Add an SPI to allow WebView clients to add additional supported image formats
​https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

Add an SPI to allow additional supported image formats in WebView. These
additional formats can be set in the WKWebViewConfiguration as an NSArray
of NStrings. Each string represents an image source type aka UTI.

The ImageSourceType in the functions' names will be replaced by ImageType.
ImageType in this context is the image UTI (Uniform Type Identifier).

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::supportedImageMIMETypes):
(WebCore::MIMETypeRegistry::additionalSupportedImageMIMETypes):
(WebCore::supportedImageMIMETypesForEncoding):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):

• platform/MIMETypeRegistry.h:
• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::filenameExtension const):
(WebCore::ImageDecoderCG::encodedDataStatus const):

• platform/graphics/cg/ImageSourceCG.h:
• platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::MIMETypeForImageType):
(WebCore::preferredExtensionForImageType):
(WebCore::MIMETypeForImageSourceType): Deleted.
(WebCore::preferredExtensionForImageSourceType): Deleted.

• platform/graphics/cg/ImageSourceCGWin.cpp:

(WebCore::MIMETypeForImageType):
(WebCore::preferredExtensionForImageType):
(WebCore::MIMETypeForImageSourceType): Deleted.
(WebCore::preferredExtensionForImageSourceType): Deleted.

• platform/graphics/cg/UTIRegistry.cpp:

(WebCore::defaultSupportedImageTypes):
(WebCore::additionalSupportedImageTypes):
(WebCore::setAdditionalSupportedImageTypes):
(WebCore::isSupportedImageType):
(WebCore::supportedDefaultImageSourceTypes): Deleted.
(WebCore::isSupportImageSourceType): Deleted.

• platform/graphics/cg/UTIRegistry.h:

Source/WebKit:
Add an SPI to allow WebView clients to add additional supported image formats
​https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

• Platform/mac/StringUtilities.h:
• Platform/mac/StringUtilities.mm:

(WebKit::webCoreStringVectorFromNSStringArray):
A helper function which converts an NSArray of NSStrings to a Vector of
WTFString.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:

Handle encoding and decoding the AdditionalSupportedImageTypes which will
allow transferring it from the UI process to the web process.

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::additionalSupportedImageTypes const):
(API::PageConfiguration::setAdditionalSupportedImageTypes):
Store the AdditionalSupportedImageTypes in the APIPageConfiguration
which is used when creating the WebPageProxy in the UIPorcess.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _additionalSupportedImageTypes]):
(-[WKWebViewConfiguration _setAdditionalSupportedImageTypes:]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Setter/Getter for the AdditionalSupportedImageTypes.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
Copy the AdditionalSupportedImageTypes from APIPageConfiguration to
WebPageCreationParameters.

• UIProcess/WebPageProxy.h:

Delete unimplemented function.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
Copy the AdditionalSupportedImageTypes from WebPageCreationParameters to
WebCore.

Tools:
onal supported image formats
​https://bugs.webkit.org/show_bug.cgi?id=190454

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2018-11-08
Reviewed by Simon Fraser.

Test opening a TGA image in WebView which is not allowed by default. The
TGA format will be allowed through WKWebViewConfiguration.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
• TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
• TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.

(runTest):
(TEST):

5:59 PM Changeset in webkit [238014] by Megan Gardner

• 18 edits
  2 copies
  3 adds in trunk

Adopt Reveal Framework to replace Lookup
​https://bugs.webkit.org/show_bug.cgi?id=191097
Source/WebCore:

Reviewed by Tim Horton.

Reveal is not currently testable.

The Reveal framework does the same job as Lookup and DataDectors.
In this patch we switch from using Lookup to determine what text
to select and define to using Reveal and RVItems. Since this
code needs to work on older systems, and Reveal is newer, we also need
to keep around the old code for old systems so that they can also
continue to work. Eventually we will remove this code and also likly switch
to passing RVItems across from the web process rather than making them
on each side.

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/mac/DictionaryLookup.h:
• editing/mac/DictionaryLookup.mm:

Create a delegate to respond to Reveal and help draw the string or highlight.

(-[WebRevealHighlight initWithHighlightRect:useDefaultHighlight:attributedString:]):
(-[WebRevealHighlight setClearTextIndicator:]):
(-[WebRevealHighlight revealContext:rectsForItem:]):
(-[WebRevealHighlight revealContext:drawRectsForItem:]):
(-[WebRevealHighlight revealContext:shouldUseDefaultHighlightForItem:]):
(-[WebRevealHighlight revealContext:stopHighlightingItem:]):
(WebCore::showPopupOrCreateAnimationController):

Unify the code paths and utalize the Reveal framework to create and/or display the popovers.

(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Pipe the new callback through.

(WebCore::tokenRange): Deleted.

Only used with Lookup

(WebCore::selectionContainsPosition): Deleted.

Only used with Lookup.

• editing/mac/DictionaryLookupLegacy.mm: Copied from Source/WebCore/editing/mac/DictionaryLookup.mm.

Keep a copy of the previous implementation of DictionaryLookup, because Reveal not available on older
system.

(WebCore::tokenRange):
(WebCore::selectionContainsPosition):
(WebCore::expandSelectionByCharacters):
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::showPopup):
(WebCore::DictionaryLookup::hidePopup):
(WebCore::DictionaryLookup::animationControllerForPopup):

Source/WebCore/PAL:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Add in reveal SPI so WebKit will continue to build without the internal SDK.

• PAL.xcodeproj/project.pbxproj:
• pal/spi/mac/RevealSPI.h: Added.

Source/WebKit:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Pass in what it needed to clear the textIndicators. This is better than
the current notification structure.

• UIProcess/Cocoa/WebViewImpl.mm:

(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver startObservingLookupDismissalIfNeeded]):

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):

• UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _animationControllerForText]):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showDefinitionForAttributedString):

Generate and pass in the text indicator information, as this is needed now.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin):

Source/WebKitLegacy/mac:

<rdar://problem/45924508>

Reviewed by Tim Horton.

Pass in what it needed to clear the textIndicators. This is better than
the current notification structure.

• WebView/WebView.mm:

(-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
(-[WebView _prepareForDictionaryLookup]):

LayoutTests:

Reviewed by Tim Horton.

Reveal selects spaces instead of adjacent words, no matter how interesting they are.
Update the tests to show this, and change the expections for previous platforms.

• editing/mac/selection/context-menu-select-editability-expected.txt:
• editing/mac/selection/context-menu-select-editability.html:
• platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt: Copied from LayoutTests/editing/mac/selection/context-menu-select-editability-expected.txt.

5:51 PM Changeset in webkit [238013] by Ryan Haddad

• 3 edits
  1 copy
  5 adds in trunk/LayoutTests

Clean up test expectations after r237942
​https://bugs.webkit.org/show_bug.cgi?id=191448

Unreviewed test gardening.

Add High Sierra specific expectation files for three tests, rebaseline one for Mojave, and remove failure expectations.

• platform/mac-highsierra-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt: Copied from LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt.
• platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added.
• platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added.
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt:

5:34 PM Changeset in webkit [238012] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Options::useRegExpJIT() should use jitEnabledByDefault() just like useJIT()
​https://bugs.webkit.org/show_bug.cgi?id=191444

Reviewed by Saam Barati.

• runtime/Options.h:

5:29 PM Changeset in webkit [238011] by Fujii Hironori

• 2 edits in trunk/Source/JavaScriptCore

[Win] UDis86Disassembler.cpp: warning: format specifies type 'unsigned long' but the argument has type 'uintptr_t' (aka 'unsigned long long')
​https://bugs.webkit.org/show_bug.cgi?id=191416

Reviewed by Saam Barati.

• disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassembleWithUDis86): Use PRIxPTR for uintptr_t.

4:23 PM Changeset in webkit [238010] by jiewen_tan@apple.com

• 2 edits
  2 moves in trunk/Tools

Unreviewed, a proper build fix for r237983

Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.

(TestWebKitAPI::getTestCorruptedSignResponse):
(TestWebKitAPI::getTestCredentialRawIdBytes):
(TestWebKitAPI::convertToVector):
(TestWebKitAPI::TEST):

4:22 PM Changeset in webkit [238009] by Ryan Haddad

• 3 edits in trunk/LayoutTests

[Mojave WK1] Layout test fast/events/detect-caps-lock.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=191424

Unreviewed test gardening.

Update expectations since this test is only expected to run on WK2.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:13 PM Changeset in webkit [238008] by Keith Rollin

• 12 edits
  9 adds in trunk

Create .xcfilelist files
​https://bugs.webkit.org/show_bug.cgi?id=191324
<rdar://problem/45852819>

Reviewed by Alex Christensen.

As part of preparing for enabling XCBuild, create and use .xcfilelist
files. These files are using during Run Script build phases in an
Xcode project. If a Run Script build phase produces new files that are
used later as inputs to subsequent build phases, XCBuild needs to know
about these files. These files can be either specified in an "output
files" section of the Run Script phase editor, or in .xcfilelist files
that are associated with the Run Script build phase.

This patch takes the second approach. It consists of three sets of changes:

• Modify the DerivedSources.make files to have a 'print_all_generated_files" target that produces a list of the files they create.

• Create a shell script that produces .xcfilelist files from the output of the previous step, as well as for the files created in the Generate Unified Sources build steps.

• Add the new .xcfilelist files to the associated projects.

Note that, with these changes, the Xcode workspace and projects can no
longer be fully loaded into Xcode 9. Xcode will attempt to load the
projects that have .xcfilelist files associated with them, but will
fail and display a placeholder for those projects instead. It's
expected that all developers are using Xcode 10 by now and that not
being able to load into Xcode 9 is not a practical issue. Keep in mind
that this is strictly an IDE issue, and that the projects can still be
built with xcodebuild.

Also note that the shell script that creates the .xcfilelist files can
also be used to verify that the set of files that's currently checked
in is up-to-date. This checking can be used as part of a check-in hook
or part of check-webkit-style to sooner catch cases where the
.xcfilelist files need to be regenerated.

Source/JavaScriptCore:

• DerivedSources.make:
• DerivedSources.xcfilelist: Added.
• JavaScriptCore.xcodeproj/project.pbxproj:
• UnifiedSources.xcfilelist: Added.

Source/WebCore:

No new tests -- no changed functionality.

• DerivedSources.make:
• DerivedSources.xcfilelist: Added.
• UnifiedSources.xcfilelist: Added.
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

• DerivedSources.make:
• DerivedSources.xcfilelist: Added.
• UnifiedSources.xcfilelist: Added.
• WebKit.xcodeproj/project.pbxproj:

Tools:

• DumpRenderTree/DerivedSources.make:
• DumpRenderTree/DerivedSources.xcfilelist: Added.
• Scripts/generate-xcfilelists: Added.
• WebKitTestRunner/DerivedSources.make:
• WebKitTestRunner/DerivedSources.xcfilelist: Added.

4:07 PM Changeset in webkit [238007] by Ryan Haddad

• 3 edits in branches/safari-606-branch/LayoutTests

Unreviewed test gardening for rdar://problem/44568702.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

3:58 PM Changeset in webkit [238006] by don.olmstead@sony.com

• 5 edits
  1 add
  2 deletes in trunk/Source/WebCore

Provide generic implementation of SSLKeyGenerator functions
​https://bugs.webkit.org/show_bug.cgi?id=191428

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Both SSLKeyGeneratorGLib and SSLKeyGeneratorIOS were stub
implementations. Since <keygen> is deprecated it looks unlikely that
an implementation is actually needed, however an implementation is
needed until support is reomved.

• Sources.txt:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/SSLKeyGenerator.cpp: Added.

(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):

• platform/SourcesGLib.txt:
• platform/glib/SSLKeyGeneratorGLib.cpp: Removed.
• platform/ios/SSLKeyGeneratorIOS.cpp: Removed.

3:44 PM Changeset in webkit [238005] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Potential for watch expressions to never show results
​https://bugs.webkit.org/show_bug.cgi?id=191438

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-08
Reviewed by Matt Baker.

• UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel.prototype._generateWatchExpressionsSection):
If there was no object don't bail, continue and resolve the Promise.
In this case we can fallback to show undefined. This code might not be
reachable right now, but is wrong as is.

3:40 PM Changeset in webkit [238004] by Ross Kirsling

• 31 edits in trunk

U+180E is no longer a whitespace character
​https://bugs.webkit.org/show_bug.cgi?id=191415

Reviewed by Saam Barati.

JSTests:

• ChakraCore/test/es5/regexSpace.baseline:
• ChakraCore/test/es6/unicode_whitespace.js:

Update tests to latest version.
(See ​https://github.com/Microsoft/ChakraCore/commit/7c097b698de1e400286f9b957597b2a81fc6f80b.)

• test262.yaml:
• test262/config.yaml:
• test262/expectations.yaml:

Update expectations.

Source/JavaScriptCore:

Mongolian Vowel Separator stopped being a valid whitespace character as of ES2016.
(​https://github.com/tc39/ecma262/pull/300)

• parser/Lexer.h:

(JSC::Lexer<UChar>::isWhiteSpace):

• runtime/ParseInt.h:

(JSC::isStrWhiteSpace):

• yarr/create_regex_tables:

LayoutTests:

• js/ToNumber-expected.txt:
• js/parseFloat-expected.txt:
• js/script-tests/ToNumber.js:
• js/script-tests/parseFloat.js:

Update tests and expectations.

• sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A2-expected.txt:
• sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T1-expected.txt:
• sputnik/Conformance/09_Type_Conversion/9.3_ToNumber/9.3.1_ToNumber_from_String/S9.3.1_A3_T2-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A1_T1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A2_T1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.2_parseInt/S15.1.2.2_A2_T10-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.3_parseFloat/S15.1.2.3_A2_T10-expected.txt:
• sputnik/Unicode/Unicode_410/S15.10.2.12_A1_T6-expected.txt:
• sputnik/Unicode/Unicode_410/S15.10.2.12_A2_T6-expected.txt:
• sputnik/Unicode/Unicode_410/S7.2_A1.6_T1-expected.txt:
• sputnik/Unicode/Unicode_500/S15.10.2.12_A1_T6-expected.txt:
• sputnik/Unicode/Unicode_500/S15.10.2.12_A2_T6-expected.txt:
• sputnik/Unicode/Unicode_500/S7.2_A1.6_T1-expected.txt:
• sputnik/Unicode/Unicode_510/S15.10.2.12_A1_T6-expected.txt:
• sputnik/Unicode/Unicode_510/S15.10.2.12_A2_T6-expected.txt:
• sputnik/Unicode/Unicode_510/S7.2_A1.6_T1-expected.txt:

Let outdated sputnik checks fail.

2:43 PM Changeset in webkit [238003] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger Popover does not work when paused in Worker
​https://bugs.webkit.org/show_bug.cgi?id=191342

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-08
Reviewed by Devin Rousso.

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression.populate):
(WI.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
When receiving the result of the popover evaluation associate the RemoteObject with
the target we used to evaluate (such as the Debugger call frame), not the target
associated with the editor.

2:18 PM Changeset in webkit [238002] by mmaxfield@apple.com

• 15 edits
  2 adds in trunk

Unprefix text-decoration CSS3 properties
​https://bugs.webkit.org/show_bug.cgi?id=127193

Reviewed by Dean Jackson.

Source/WebCore:

The properties are stable, and there is interop.

Test: fast/css3-text/css3-text-decoration/unprefix.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSProperties.json:
• css/StyleResolver.cpp:

(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::isValidVisitedLinkProperty):

• css/parser/CSSParserFastPaths.cpp:

(WebCore::isColorPropertyID):
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

• rendering/TextDecorationPainter.cpp:

(WebCore::decorationColor):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback const):
(WebCore::RenderStyle::visitedDependentColor const):

LayoutTests:

• fast/css3-text/css3-text-decoration/unprefix-expected.html: Added.
• fast/css3-text/css3-text-decoration/unprefix.html: Added.

1:57 PM Changeset in webkit [238001] by timothy@apple.com

• 40 edits
  5 adds in trunk

Add experimental support for a supported-color-schemes CSS property.
​https://bugs.webkit.org/show_bug.cgi?id=191319
rdar://problem/45852261

Reviewed by Dean Jackson.

Source/WebCore:

Tests: css-dark-mode/parse-supported-color-schemes.html

css-dark-mode/supported-color-schemes-css.html

• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::updateSupportedColorSchemes):
(WebCore::StyleBuilderConverter::convertSupportedColorSchemes):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::colorFromPrimitiveValue const):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeSupportedColorSchemes):
(WebCore::CSSPropertyParser::parseSingleValue):

• dom/Document.cpp:

(WebCore::Document::resetLinkColor):
(WebCore::Document::resetVisitedLinkColor):
(WebCore::Document::resetActiveLinkColor):
(WebCore::Document::processSupportedColorSchemes):
(WebCore::Document::useDarkAppearance const):
(WebCore::Document::styleColorOptions const):

• dom/Document.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragment):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal):

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint):

• page/FrameView.cpp:

(WebCore::FrameView::useDarkAppearance const):
(WebCore::FrameView::paintScrollCorner):

• platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink):

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintPlatformDocumentMarker):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):
(WebCore::RenderBox::paintBackground):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::selectionColor const):
(WebCore::RenderElement::selectionBackgroundColor const):
(WebCore::RenderElement::paintFocusRing):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::useDarkAppearance const):
(WebCore::RenderObject::styleColorOptions const):

• rendering/RenderObject.h:
• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::usingDarkAppearance const): Deleted.

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor const):
(WebCore::RenderThemeMac::adjustMenuListStyle const):
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::usingDarkAppearance const): Deleted.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::supportedColorSchemes const):
(WebCore::RenderStyle::setSupportedColorSchemes):
(WebCore::RenderStyle::initialSupportedColorSchemes):

• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

• rendering/style/StyleRareInheritedData.h:
• rendering/style/StyleSupportedColorSchemes.h: Added.

(WebCore::StyleSupportedColorSchemes::StyleSupportedColorSchemes):
(WebCore::StyleSupportedColorSchemes::operator== const):
(WebCore::StyleSupportedColorSchemes::operator!= const):
(WebCore::StyleSupportedColorSchemes::isAuto const):
(WebCore::StyleSupportedColorSchemes::isOnly const):
(WebCore::StyleSupportedColorSchemes::colorSchemes const):
(WebCore::StyleSupportedColorSchemes::add):
(WebCore::StyleSupportedColorSchemes::contains const):
(WebCore::StyleSupportedColorSchemes::setAllowsTransformations):
(WebCore::StyleSupportedColorSchemes::allowsTransformations const):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

Source/WebKit:

• WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRect):

LayoutTests:

• css-dark-mode/parse-supported-color-schemes-expected.txt: Added.
• css-dark-mode/parse-supported-color-schemes.html: Added.
• css-dark-mode/supported-color-schemes-css-expected.txt: Added.
• css-dark-mode/supported-color-schemes-css.html: Added.

1:46 PM Changeset in webkit [238000] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

jitEnabledByDefault() should be on useJIT not useBaselineJIT
​https://bugs.webkit.org/show_bug.cgi?id=191434

Reviewed by Saam Barati.

• runtime/Options.h:

1:15 PM Changeset in webkit [237999] by Kocsen Chung

• 4 edits in tags/Safari-607.1.13/Source

Cherry-pick r237952. rdar://problem/45894288

Unreviewed, fix iOS build with recent SDKs.

Source/WebCore:

• platform/network/cocoa/ResourceResponseCocoa.mm: (WebCore::ResourceResponse::platformCertificateInfo const):

Source/WebKit:

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController _EVOrganizationName]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:15 PM Changeset in webkit [237998] by Kocsen Chung

• 2 edits in tags/Safari-607.1.13/Source/WebCore

Cherry-pick r237951. rdar://problem/45894288

Unreviewed, fix iOS build with recent SDKs.

• platform/network/cocoa/ResourceResponseCocoa.mm: (WebCore::ResourceResponse::platformCertificateInfo const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:27 PM Changeset in webkit [237997] by Joseph Pecoraro

• 35 edits
  1 copy
  2 deletes in trunk/Source

Web Inspector: Restrict domains at the target level instead of only at the window level
​https://bugs.webkit.org/show_bug.cgi?id=191344

Reviewed by Devin Rousso.

Source/JavaScriptCore:

• inspector/protocol/Console.json:
• inspector/protocol/Debugger.json:
• inspector/protocol/Heap.json:
• inspector/protocol/Runtime.json:

Remove workerSupported as it is now no longer necessary. It is implied
by availability being empty (meaning it is supported everywhere).

• inspector/protocol/Inspector.json:
• inspector/protocol/ScriptProfiler.json:

Restrict to "javascript" and "web" debuggables, not available in workers.

• inspector/protocol/Worker.json:

Cleanup, remove empty types list.

• inspector/protocol/Recording.json:

Cleanup, only expose this in the "web" domain for now.

• inspector/scripts/codegen/generate_js_backend_commands.py:

(JSBackendCommandsGenerator.generate_domain):

• inspector/scripts/codegen/models.py:

(Protocol.parse_domain):
Allow a list of debuggable types. Add "worker" even though it is unused
since that is a type we would want to allow or consider.

(Domain.init):
(Domains):
Remove now unnecessary workerSupported code.
Allow availability on a domain with only types.

• inspector/scripts/tests/generic/expected/worker-supported-domains.json-result: Removed.
• inspector/scripts/tests/generic/worker-supported-domains.json: Removed.

Source/WebCore:

• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
Remove Inspector domain from workers. It was unused anyways.

Source/WebInspectorUI:

With this change the list of agents available on the target should accurately
reflect the domains that target supports. We should start moving in the direction
that if we are checking for, or using, a feature, we should ideally be using
code that looks like target.FooAgent.method and not window.FooAgent or
an unprefixed FooAgent. More changes to follow.

• UserInterface/Controllers/AppControllerBase.js:
• UserInterface/Base/DebuggableType.js: Added.

Extract debuggable type enum out into its own file loaded early on.

• UserInterface/Main.html:
• UserInterface/Test.html:

Load DebuggableType.js.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.initializeTarget):
With these changes target.ServiceWorker is only exposed on a ServiceWorker target.

• UserInterface/Protocol/Connection.js:

(InspectorBackend.WorkerConnection):
With these changes Target.js restricts the domains exposed on the Target so just
clone all of the agents (we don't need to do anything special).

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.activateDomain):
Update supported domains per-type. If there is no explicit availability
then the domain is supported on all types.

(InspectorBackendClass.prototype.supportedDomainsForDebuggableType):
Get supported domains per-type.

(InspectorBackendClass.prototype.get workerSupportedDomains): Deleted.
(InspectorBackendClass.prototype.workerSupportedDomain): Deleted.
workerSupportedDomains is now unnecessary.

• UserInterface/Protocol/Target.js:

(WI.Target.prototype._supportedDomainsForTargetType):
Restrict supported domains for this target based on its type.

• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
• Versions/Inspector-iOS-10.3.json:
• Versions/Inspector-iOS-11.0.json:
• Versions/Inspector-iOS-11.3.json:
• Versions/Inspector-iOS-12.0.json:

Regenerate protocol files now that workerSupportedDomains is unnecessary
and explicit availability has been added to other domains.

12:08 PM Changeset in webkit [237996] by pvollan@apple.com

• 3 edits in trunk/LayoutTests

[Sierra Release WK2] Layout Test media/track/track-cue-css.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=191200

Unreviewed, speculative fix for test flakiness.

• media/track/track-cue-css-expected.html:
• media/track/track-cue-css.html:

11:53 AM Changeset in webkit [237995] by aestes@apple.com

• 10 edits
  2 adds in trunk/LayoutTests/imported/w3c

[Payment Request] Update web platform tests
​https://bugs.webkit.org/show_bug.cgi?id=191426

Updated web-platform-tests/payment-request/ to match wpt as of commit 577284e.

Reviewed by Jiewen Tan.

• resources/import-expectations.json:
• web-platform-tests/payment-request/META.yml:
• web-platform-tests/payment-request/payment-request-abort-method.https.html:
• web-platform-tests/payment-request/payment-request-canmakepayment-method-protection.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-canmakepayment-method-protection.https.html: Added.
• web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html:
• web-platform-tests/payment-request/payment-request-constructor.https.html:
• web-platform-tests/payment-request/payment-request-id-attribute.https.html:
• web-platform-tests/payment-request/payment-response/retry-method-manual.https.html:
• web-platform-tests/payment-request/rejects_if_not_active.https.html:
• web-platform-tests/payment-request/w3c-import.log:

11:49 AM Changeset in webkit [237994] by ggaren@apple.com

• 2 edits
  2 deletes in trunk/Source/WTF

Removed mbmalloc target from WTF
​https://bugs.webkit.org/show_bug.cgi?id=191313

Reviewed by Saam Barati.

For benchmarking, WTF::fastMalloc is no longer meaningfully different
from bmalloc. (And bmalloc has its own mbmalloc target.)

• Configurations/mbmalloc.xcconfig: Removed.
• WTF.xcodeproj/project.pbxproj:
• wtf/mbmalloc.cpp: Removed.

11:41 AM Changeset in webkit [237993] by jiewen_tan@apple.com

• 2 edits
  2 moves in trunk/Tools

Unreviewed, a quick build fix for r237983

Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
• TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.

(TestWebKitAPI::getTestCorruptedSignResponse):
(TestWebKitAPI::getTestCredentialRawIdBytes):
(TestWebKitAPI::convertToVector):
(TestWebKitAPI::TEST):

11:40 AM Changeset in webkit [237992] by ap@apple.com

• 2 edits in trunk/Source/WTF

Re-add PLATFORM(IOS), now with the strict meaning
​https://bugs.webkit.org/show_bug.cgi?id=191281

Reviewed by Tim Horton.

• wtf/Platform.h: No change in behavior. Some of the macros look a bit weird

when expanded, it might be that the values are incorrect for some flavors of iOS family.

11:25 AM Changeset in webkit [237991] by Ryan Haddad

• 2 edits in trunk/Tools

Fix steps_unittest.py failures related to recent Win10/Win7 changes
​https://bugs.webkit.org/show_bug.cgi?id=191290

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.

10:51 AM Changeset in webkit [237990] by dino@apple.com

• 20 edits in trunk

Add a String literal that returns a String
​https://bugs.webkit.org/show_bug.cgi?id=191425
<rdar://problem/45914556>

Reviewed by Sam Weinig.

Source/WebCore:

Use _str where possible.

API Test in WPT.

• Modules/fetch/FetchRequest.cpp:

(WebCore::computeReferrer):

• Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::loggingString):

• Modules/webdatabase/OriginLock.cpp:

(WebCore::OriginLock::lockFileNameForPath):

• css/CSSBasicShapes.cpp:

(WebCore::updateCornerRadiusWidthAndHeight):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getParameter):

• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getParameter):

• loader/LinkHeader.cpp:

(WebCore::parseParameterValue):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• page/NavigatorBase.cpp:

(WebCore::NavigatorBase::platform):

• platform/DateComponents.cpp:

(WebCore::DateComponents::toString const):

• platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyIdentifierForKeyEvent):

• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::suffix const):

• rendering/RenderMenuList.cpp:

(RenderMenuList::setText):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::userInterfaceDirectionPolicy):
(WebCore::InternalSettings::systemLayoutDirection):

• testing/Internals.cpp:

(WebCore::Internals::shadowRootType const):
(WebCore::Internals::getCurrentCursorInfo):

Source/WTF:

Add a new String literal, _str, that will return a String type.
This is useful when ""_s won't work, such as for things that
don't take an ASCIILiteral directly e.g. ExceptionOr<String>
or Variants.

• wtf/text/WTFString.h:

(WTF::StringLiterals::operator _str): Added.

Tools:

Test _str.

• TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

8:16 AM Changeset in webkit [237989] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Generalize trailing SDK specifier (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=191275
<rdar://problem/45703660>

Rubber-stamped by Aakash Jain.

Re-landing this change, configuration issues have been resolved.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort): Use normalized SDK.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Use normalized SDK.
(IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.

7:53 AM Changeset in webkit [237988] by eric.carlson@apple.com

• 16 edits
  2 deletes in trunk

[MediaStream] Use DeviceIdHashSaltStorage to generate device ID hash salt
​https://bugs.webkit.org/show_bug.cgi?id=190825
<rdar://problem/45486085>

Source/WebKit:

Reviewed by Youenn Fablet.

• UIProcess/API/C/WKUserMediaPermissionCheck.cpp:

(WKUserMediaPermissionCheckSetUserMediaAccessInfo):

• UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp:

(webkitDeviceInfoPermissionRequestAllow):
(webkitDeviceInfoPermissionRequestDeny):

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):

• UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::regenerateDeviceIdHashSaltForOrigin):
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigin):

• UIProcess/DeviceIdHashSaltStorage.h:
• UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo):

• UIProcess/UserMediaPermissionCheckProxy.h:
• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::createPermissionRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo):
(WebKit::UserMediaPermissionRequestManagerProxy::updateDeviceIDHashSalt):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy):

• UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::deviceIdentifierHashSalt const): Deleted.

LayoutTests:

Update enumerate-devices-source-id to expect the same device to have the same ID in all
iframes, remove enumerate-devices-source-id-persistent because the logic was faulty.

Reviewed by Youenn Fablet.

• TestExpectations: Unskip http/tests/media/media-stream/enumerate-devices-source-id.html
• http/tests/media/media-stream/enumerate-devices-source-id-expected.txt:
• http/tests/media/media-stream/enumerate-devices-source-id-persistent-expected.txt: Removed.
• http/tests/media/media-stream/enumerate-devices-source-id-persistent.html: Removed.
• http/tests/media/media-stream/enumerate-devices-source-id.html:

7:42 AM Changeset in webkit [237987] by yusukesuzuki@slowstart.org

• 10 edits in trunk/Source/JavaScriptCore

Consider removing double load for accessing the MetadataTable from LLInt
​https://bugs.webkit.org/show_bug.cgi?id=190933

Reviewed by Keith Miller.

This patch removes double load for accesses to MetadataTable from LLInt.
MetadataTable is now specially RefCounted class, which has interesting memory layout.
When refcount becomes 0, MetadataTable asks UnlinkedMetadataTable to destroy itself.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::estimatedSize):
(JSC::CodeBlock::visitChildren):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::metadata):

• bytecode/CodeBlockInlines.h:

(JSC::CodeBlock::forEachValueProfile):
(JSC::CodeBlock::forEachArrayProfile):
(JSC::CodeBlock::forEachArrayAllocationProfile):
(JSC::CodeBlock::forEachObjectAllocationProfile):
(JSC::CodeBlock::forEachLLIntCallLinkInfo):

• bytecode/MetadataTable.cpp:

(JSC::MetadataTable::MetadataTable):
(JSC::MetadataTable::~MetadataTable):
(JSC::MetadataTable::sizeInBytes):

• bytecode/MetadataTable.h:

(JSC::MetadataTable::get):
(JSC::MetadataTable::forEach):
(JSC::MetadataTable::ref const):
(JSC::MetadataTable::deref const):
(JSC::MetadataTable::refCount const):
(JSC::MetadataTable::hasOneRef const):
(JSC::MetadataTable::buffer):
(JSC::MetadataTable::linkingData const):
(JSC::MetadataTable::getImpl):

• bytecode/UnlinkedMetadataTable.h:

(JSC::UnlinkedMetadataTable::buffer const):

• bytecode/UnlinkedMetadataTableInlines.h:

(JSC::UnlinkedMetadataTable::UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::addEntry):
(JSC::UnlinkedMetadataTable::sizeInBytes):
(JSC::UnlinkedMetadataTable::finalize):
(JSC::UnlinkedMetadataTable::link):
(JSC::UnlinkedMetadataTable::unlink):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:

7:36 AM Changeset in webkit [237986] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

Plain text drag in contenteditable is always DragOperationCopy, never DragOperationMove
​https://bugs.webkit.org/show_bug.cgi?id=191228
<rdar://problem/45786830>

Patch by Jonathan Hammer <​jonathan@e3software.com> on 2018-11-08
Reviewed by Wenson Hsieh.

Source/WebCore:

DragController::beginDrag should not call cleanupAfterSystemDrag because
the drag is still in progress even after the call to m_client.beginDrag()
returns. This is in contrast to DragController::doSystemDrag, where the
call to cleanupAfterSystemDrag is appropriate because the drag has
concluded by the time m_client.startDrag() returns.

Test: fast/events/drag-and-drop-move-not-copy.html

• page/DragController.cpp:

(WebCore::DragController::beginDrag):

LayoutTests:

A test that checks that dragging plain text in a contenteditable element results
in the text being moved and not copied. Only applies to WK1. Test skipped on
WK2 because WK2 EventSender does not support drag events. Test also skipped on
AppleWin because drag and drop doesn't work correctly in DRT (according to the
TestExpectations file).

• fast/events/drag-and-drop-move-not-copy-expected.txt: Added.
• fast/events/drag-and-drop-move-not-copy.html: Added.
• platform/win/TestExpectations:
• platform/wk2/TestExpectations:

7:20 AM Changeset in webkit [237985] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[BFC][IFC] InlineFormattingContext::Line::alignRuns() should take care of all the alignments.
​https://bugs.webkit.org/show_bug.cgi?id=191414

Reviewed by Antti Koivisto.

• layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::close):

3:21 AM Changeset in webkit [237984] by aboya@igalia.com

• 2 edits
  5 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=191404

• platform/gtk/TestExpectations:
• platform/gtk/fast/block/basic/height-percentage-simple-expected.txt: Added.
• platform/gtk/fast/inline/simple-inline-block-expected.txt: Added.
• platform/gtk/fast/inline/simple-intruding-float1-expected.txt: Added.
• platform/gtk/fast/inline/simple-intruding-floats2-expected.txt: Added.
• platform/gtk/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.

2:29 AM Changeset in webkit [237983] by jiewen_tan@apple.com

• 16 edits
  4 copies
  9 adds in trunk

[WebAuthN] Import CTAP device request/response converters from Chromium
​https://bugs.webkit.org/show_bug.cgi?id=190784
<rdar://problem/45460333>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch imports Chromium's CTAP device request/response converters:
​https://fidoalliance.org/specs/fido-v2.0-ps-20170927/fido-client-to-authenticator-protocol-v2.0-ps-20170927.html#message-encoding

1. It directly imports the following files and suit them to WebKit's coding style:

​https://cs.chromium.org/chromium/src/device/fido/device_response_converter.cc?l=20&rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/device_response_converter.h?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/authenticator_get_info_response.cc?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/authenticator_get_info_response.h?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/authenticator_supported_options.cc?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/authenticator_supported_options.h?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/ctap_request_unittest.cc?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/ctap_response_unittest.cc?rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45
​https://cs.chromium.org/chromium/src/device/fido/fido_test_data.h?l=1&rcl=098dfd90850ffa84c27a884ab75edd2d99c4ec45

2. It gathers the following methods into DeviceRequestConverter:

CtapGetAssertionRequest::EncodeAsCBOR()
CtapMakeCredentialRequest::EncodeAsCBOR()
PublicKeyCredentialDescriptor::ConvertToCBOR()
PublicKeyCredentialParams::ConvertToCBOR()
PublicKeyCredentialRpEntity::ConvertToCBOR()
PublicKeyCredentialUserEntity::ConvertToCBOR()

3. It also apply a patch from Chromium to CBORValue:

​https://chromium.googlesource.com/chromium/src/+/7b6fbff35cd8e4d508f08e1cd93b4aa0a0dc402c%5E%21/

Besides importing things from Chromium, it also implements UserVerificationRequirement for both
PublicKeyCredentialCreationOptions and PublicKeyCredentialRequestOptions such that both options
can specify more dimensions of a desired authenticator.

Covered by API tests.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/webauthn/PublicKeyCredentialCreationOptions.h:

(WebCore::PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::encode const):
(WebCore::PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::decode):

• Modules/webauthn/PublicKeyCredentialCreationOptions.idl:
• Modules/webauthn/PublicKeyCredentialRequestOptions.h:

(WebCore::PublicKeyCredentialRequestOptions::encode const):
(WebCore::PublicKeyCredentialRequestOptions::decode):

• Modules/webauthn/PublicKeyCredentialRequestOptions.idl:
• Modules/webauthn/UserVerificationRequirement.h: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.idl.
• Modules/webauthn/UserVerificationRequirement.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredentialRequestOptions.idl.
• Modules/webauthn/cbor/CBORValue.cpp:

(cbor::CBORValue::CBORValue):
(cbor::CBORValue::getBool const):

• Modules/webauthn/cbor/CBORValue.h:
• Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp: Added.

(fido::toArrayValue):
(fido::AuthenticatorGetInfoResponse::AuthenticatorGetInfoResponse):
(fido::AuthenticatorGetInfoResponse::setMaxMsgSize):
(fido::AuthenticatorGetInfoResponse::setPinProtocols):
(fido::AuthenticatorGetInfoResponse::setExtensions):
(fido::AuthenticatorGetInfoResponse::setOptions):
(fido::encodeAsCBOR):

• Modules/webauthn/fido/AuthenticatorGetInfoResponse.h: Added.
• Modules/webauthn/fido/AuthenticatorSupportedOptions.cpp: Added.

(fido::AuthenticatorSupportedOptions::setSupportsResidentKey):
(fido::AuthenticatorSupportedOptions::setUserVerificationAvailability):
(fido::AuthenticatorSupportedOptions::setUserPresenceRequired):
(fido::AuthenticatorSupportedOptions::setClientPinAvailability):
(fido::AuthenticatorSupportedOptions::setIsPlatformDevice):
(fido::convertToCBOR):

• Modules/webauthn/fido/AuthenticatorSupportedOptions.h: Added.
• Modules/webauthn/fido/DeviceRequestConverter.cpp: Added.

(fido::convertRpEntityToCBOR):
(fido::convertUserEntityToCBOR):
(fido::convertParametersToCBOR):
(fido::convertDescriptorToCBOR):
(fido::encodeMakeCredenitalRequestAsCBOR):
(fido::encodeGetAssertionRequestAsCBOR):
(fido::encodeEmptyAuthenticatorRequest):

• Modules/webauthn/fido/DeviceRequestConverter.h: Copied from Source/WebCore/Modules/webauthn/fido/FidoConstants.h.
• Modules/webauthn/fido/DeviceResponseConverter.cpp: Added.

(fido::convertStringToProtocolVersion):
(fido::getResponseCode):
(fido::getCredentialId):
(fido::readCTAPMakeCredentialResponse):
(fido::readCTAPGetAssertionResponse):
(fido::readCTAPGetInfoResponse):

• Modules/webauthn/fido/DeviceResponseConverter.h: Copied from Source/WebCore/Modules/webauthn/fido/FidoConstants.cpp.
• Modules/webauthn/fido/FidoConstants.cpp:

(fido::isCtapDeviceResponseCode):
(fido::publicKeyCredentialTypeToString):

• Modules/webauthn/fido/FidoConstants.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.

(TestWebKitAPI::getTestCorruptedSignResponse):
(TestWebKitAPI::getTestCredentialRawIdBytes):
(TestWebKitAPI::convertToVector):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.

12:28 AM Changeset in webkit [237982] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK] Crash when running with sandbox enabled
​https://bugs.webkit.org/show_bug.cgi?id=191353

Reviewed by Michael Catanzaro.

g_key_file_set_string_list() expects a null-terminated array as parameter.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::createFlatpakInfo): Append nullptr to sharedPermissions array.

Nov 7, 2018:

9:29 PM Changeset in webkit [237981] by Justin Michaud

• 17 edits
  13 copies
  3 adds in trunk

CSS Painting API should pass size, arguments and input properties to paint callback
​https://bugs.webkit.org/show_bug.cgi?id=191309

Reviewed by Chris Dumez.

Source/WebCore:

Call paint() callback with input properties and arguments. This patch adds a stub for
the CSS Typed OM StylePropertyMapReadOnly, and passes all the arguments as strings without
any syntax checking to the paint callback.

Test: fast/css-custom-paint/properties.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSStyleValueCustom.cpp: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

• bindings/js/WebCoreBuiltinNames.h:
• css/CSSPaintCallback.h:
• css/CSSPaintCallback.idl:
• css/CSSPaintImageValue.cpp:

(WebCore::CSSPaintImageValue::image):

• css/CSSPaintImageValue.h:
• css/CSSPaintSize.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::CSSPaintSize::create):
(WebCore::CSSPaintSize::width const):
(WebCore::CSSPaintSize::height const):
(WebCore::CSSPaintSize::CSSPaintSize):

• css/CSSPaintSize.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeCustomPaint):

• css/typedom/CSSNumericValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
• css/typedom/CSSNumericValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• css/typedom/CSSStyleValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::CSSStyleValue::isUnitValue):
(WebCore::CSSStyleValue::isUnparsedValue):

• css/typedom/CSSStyleValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• css/typedom/CSSUnitValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
• css/typedom/CSSUnitValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• css/typedom/CSSUnparsedValue.h: Copied from Source/WebCore/css/CSSPaintCallback.h.
• css/typedom/CSSUnparsedValue.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• css/typedom/StylePropertyMapReadOnly.h: Copied from Source/WebCore/css/CSSPaintCallback.h.

(WebCore::StylePropertyMapReadOnly::create):
(WebCore::StylePropertyMapReadOnly::get):
(WebCore::StylePropertyMapReadOnly::StylePropertyMapReadOnly):

• css/typedom/StylePropertyMapReadOnly.idl: Copied from Source/WebCore/css/CSSPaintCallback.idl.
• platform/graphics/CustomPaintImage.cpp:

(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):

• platform/graphics/CustomPaintImage.h:

LayoutTests:

• fast/css-custom-paint/properties-expected.html: Added.
• fast/css-custom-paint/properties.html: Added.
• fast/css-custom-paint/worklet.html:

9:15 PM Changeset in webkit [237980] by Brent Fulgham

• 5 edits in trunk/Source/WebCore

Provide better Font fallbacks for DirectX backend
​https://bugs.webkit.org/show_bug.cgi?id=191412
<rdar://problem/45899207>

Reviewed by Zalan Bujtas.

Registration of custom fonts through GDI are not always visible
through the DirectWrite/GDI bridging layer. If a font is not located,
locate the closest matching avialable font rather than failing.

• platform/graphics/FontPlatformData.h:
• platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Use new font
fallback logic.

• platform/graphics/win/FontPlatformDataDirect2D.cpp:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformIsEqual const):
(WebCore::FontPlatformData::createFallbackFont): Added.

8:18 PM Changeset in webkit [237979] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 69

Added a tag for Safari Technology Preview release 69.

7:33 PM Changeset in webkit [237978] by Alan Bujtas

• 3 edits
  4 adds in trunk

Click and touch event listeners on the body don't work
​https://bugs.webkit.org/show_bug.cgi?id=191392
<rdar://problem/5844416>

Reviewed by Simon Fraser.

Source/WebCore:

Remove the old quirk of ignoring onclick handlers on the body and beyond.

Test: fast/events/click-handler-on-body-simple.html

• page/ios/FrameIOS.mm:

(WebCore::Frame::nodeRespondingToClickEvents):

LayoutTests:

• fast/events/click-handler-on-body-simple-expected.txt: Added.
• fast/events/click-handler-on-body-simple.html: Added.
• fast/events/touch/touch-handler-on-body-simple-expected.txt: Added.
• fast/events/touch/touch-handler-on-body-simple.html: Added.

7:30 PM Changeset in webkit [237977] by Brent Fulgham

• 14 edits in trunk/Source/WebCore

[Windows][DirectX] Update canvas code to pass more tests
​https://bugs.webkit.org/show_bug.cgi?id=191337
<rdar://problem/45878801>

Reviewed by Dean Jackson.

Update the Direct2D code paths to comply with our canvas tests, improving the
the test results scores to 579/770.

PathDirect2D was updated with an implementation of 'addArcTo' based on work by
Dirk Schulze <​vbs85@gmx.de> (see ​https://hg.mozilla.org/mozilla-central/rev/b116b49459f8).

Tests: canvas/philip/tests

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer): Direct2D needs access to the graphics
context to create the buffer.

• platform/graphics/ImageBuffer.h:
• platform/graphics/Path.h:
• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPattern): Flush needed.
(WebCore::GraphicsContext::drawRect): Ditto.
(WebCore::GraphicsContextPlatformPrivate::setMiterLimit): Correct for Direct2D definition of miter limit.
(WebCore::GraphicsContextPlatformPrivate::strokeStyleProperties const): Added helper function.
(WebCore::GraphicsContextPlatformPrivate::recomputeStrokeStyle): Update for new helper.
(WebCore::GraphicsContext::drawLine): Ditto.
(WebCore::drawWithShadowHelper): Ditto.
(WebCore::GraphicsContext::fillRect): Add flush.
(WebCore::GraphicsContext::platformFillRoundedRect): Update for helper.
(WebCore::GraphicsContext::clipPath): Add flush.
(WebCore::GraphicsContext::strokeRect): Ditto.
(WebCore::GraphicsContext::drawLineForText): Update for upstream changes.
(WebCore::GraphicsContext::drawLinesForText): Ditto.

• platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
• platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::createCroppedImageIfNecessary): Add missing implementations.
(WebCore::createBitmapImageAfterScalingIfNeeded): Ditto.
(WebCore::ImageBuffer::copyImage const): Ditto.
(WebCore::ImageBuffer::sinkIntoImage): Ditto.
(WebCore::ImageBuffer::fastCopyImageMode): Ditto.
(WebCore::ImageBuffer::sinkIntoNativeImage): Ditto.
(WebCore::ImageBuffer::copyNativeImage const): Ditto.

• platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::operator=):
(WebCore::Path::drawDidComplete): This should never have been const.
It manipulates the path!
(WebCore::Path::transform): Properly transform existing geometries.
(WebCore::Path::openFigureAtCurrentPointIfNecessary): Added.
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo): Make sure figure starts at a valid point.
(WebCore::Path::addQuadCurveTo): Ditto.
(WebCore::Path::addBezierCurveTo): Ditto.
(WebCore::Path::addArcTo): Add implementation.
(WebCore::Path::closeSubpath):
(WebCore::drawArcSection):
(WebCore::Path::addArc): Update to build large arcs out of small arc segments. If the
arc is effectively a complete circle, use the ellipse drawing routines.
(WebCore::Path::addRect): Make sure we start at a valid starting point.
(WebCore::Path::addEllipse): Correct for definition of D2D ellipse.
(WebCore::Path::drawDidComplete const): Deleted.

• platform/graphics/win/SimpleFontDataDirect2D.cpp:

(WebCore::Font::platformWidthForGlyph const):

• rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

• rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):

• rendering/svg/SVGRenderingContext.h:

7:14 PM Changeset in webkit [237976] by Wenson Hsieh

• 11 edits
  8 adds in trunk

Add an editing command for creating and inserting child lists
​https://bugs.webkit.org/show_bug.cgi?id=191335
<rdar://problem/45814050>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, insertOrderedList and insertUnorderedList only toggle or change list state (i.e. if the selection is
in an ordered or unordered list, reinserting the same list type removes the current list, and inserting a
different list type changes the enclosing list).

However, for certain internal clients (e.g. Mail), if the start of the selection is enclosed by a list item, we
instead create a new list item and insert it after the enclosing list item, and then create a new list within
that list item. Currently, this logic is implemented in Mail for legacy-WebKit-based Mail compose. This patch
brings this logic into WebKit in the form of a new editing command.

Tests: editing/execCommand/insert-nested-lists-in-table.html

editing/execCommand/insert-nested-lists-with-pre.html
editing/execCommand/insert-nested-lists.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/Editor.cpp:

(WebCore::Editor::insertOrderedList):
(WebCore::Editor::insertUnorderedList):

• editing/EditorCommand.cpp:

(WebCore::executeInsertOrderedList):
(WebCore::executeInsertUnorderedList):
(WebCore::executeInsertNestedUnorderedList):
(WebCore::executeInsertNestedOrderedList):
(WebCore::createCommandMap):

• editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

• editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply):
(WebCore::InsertListCommand::editingAction const):

• editing/InsertListCommand.h:

Change a couple of enums into enum classes.

• editing/InsertNestedListCommand.cpp: Added.

(WebCore::InsertNestedListCommand::insertUnorderedList):
(WebCore::InsertNestedListCommand::insertOrderedList):
(WebCore::InsertNestedListCommand::doApply):

• editing/InsertNestedListCommand.h: Added.

Add a new edit command to insert a new list (as a child of any containing list). If the start of the selection
is in a list item, we create a new list item, move the selection into the list item, and increment its list
level; otherwise, simply fall back to inserting a list.

• editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

• editing/ModifySelectionListLevel.h:

Expose this constructor, allowing other edit commands to change selection list level as a composite edit
command. Also, change an enum into an enum class.

(WebCore::IncreaseSelectionListLevelCommand::create):

LayoutTests:

Add a new layout tests that exercise the "InsertNested(Un)orderedList" editing commands in several scenarios
including undo, redo, executing the edit command with a ranged selection, outdenting to decrease list level,
inserting lists in and around tables and table cells, and inserting lists in and around pre elements.

• editing/execCommand/insert-nested-lists-expected.txt: Added.
• editing/execCommand/insert-nested-lists-in-table-expected.txt: Added.
• editing/execCommand/insert-nested-lists-in-table.html: Added.
• editing/execCommand/insert-nested-lists-with-pre-expected.txt: Added.
• editing/execCommand/insert-nested-lists-with-pre.html: Added.
• editing/execCommand/insert-nested-lists.html: Added.

7:11 PM Changeset in webkit [237975] by Chris Dumez

• 3 edits
  2 adds in trunk

ASSERT(renderer()) under HTMLTextAreaElement::updateValue()
​https://bugs.webkit.org/show_bug.cgi?id=191391
<rdar://problem/34219633>

Reviewed by Geoffrey Garen.

Source/WebCore:

Update HTMLTextFormControlElement::didEditInnerTextValue() to not call subtreeHasChanged()
if the element has no renderer, similarly to what is already done in
HTMLTextFormControlElement::setRangeText() and HTMLInputElement::setEditingValue().

Test: editing/inserting/inset-html-textarea-without-renderer.html

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):

LayoutTests:

Add layout test coverage. I have verified that this test passes in Firefox and Chrome.
It used to crash before this change in debug.

• editing/inserting/inset-html-textarea-without-renderer-expected.txt: Added.
• editing/inserting/inset-html-textarea-without-renderer.html: Added.

6:12 PM Changeset in webkit [237974] by youenn@apple.com

• 8 edits in trunk

Allow setting RTCRtpTransceiver.direction
​https://bugs.webkit.org/show_bug.cgi?id=191346

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-remote-track-mute.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Remove readonly from the direction attribute.
Keep setDirection for now as it is in use, with an intent to remove it.
Driven-by fix as in some cases, the rtc source track might be changed
and current implementation is not expecting that.
In such a case, stop observing the old track (which should no longer call us)
before observing the new one.

Covered by rebased tests.

• Modules/mediastream/RTCRtpTransceiver.idl:
• platform/mediastream/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::setSourceTrack):

• platform/mediastream/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::setSourceTrack):

6:00 PM Changeset in webkit [237973] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r236705): Web Inspector: wrong text color for selected DataGrid row
​https://bugs.webkit.org/show_bug.cgi?id=191405
<rdar://problem/45893283>

Reviewed by Matt Baker.

Selection background color for both Dark Mode mode and Light Mode is dark blue.
The text color for both cases should be white.

• UserInterface/Views/DataGrid.css:

(body:not(.window-inactive, .window-docked-inactive) .data-grid:focus tr.editable.selected .cell-content > input):

5:47 PM Changeset in webkit [237972] by Caio Lima

• 19 edits
  7 adds in trunk

[BigInt] Add support to BigInt into ValueAdd
​https://bugs.webkit.org/show_bug.cgi?id=186177

Reviewed by Keith Miller.

JSTests:

• stress/big-int-negate-jit.js:
• stress/value-add-big-int-and-string.js: Added.
• stress/value-add-big-int-prediction-propagation.js: Added.
• stress/value-add-big-int-untyped.js: Added.

PerformanceTests:

The idea of BigIntBench is to provide a set of microbenchmarks and
benchmarks to evaluate how fast BigInt computations are happening on
JSC implementation.

Now, we are adding microbenchmarks in this set,
but the plan is to move these tests to "JSTest/microbenchmarks" when
BigInt is enabled by default. After that, the focus of Bigint bench is
to provide a set of tests that represents real use cases of BigInt in
JS programs.

• BigIntBench/big-int-add-prediction-propagation.js: Added.
• BigIntBench/big-int-simple-add.js: Added.
• BigIntBench/big-int-simple-sub.js: Added.

Source/JavaScriptCore:

We are adding a very primitive specialization case of BigInts into ValueAdd.
When compiling a speculated version of this node to BigInt, we are currently
calling 'operationAddBigInt', a function that expects only BigInts as
parameter and effectly add numbers using JSBigInt::add. To properly
speculate BigInt operands, we changed ArithProfile to observe when
its result is a BigInt. With this new observation, we are able to identify
when ValueAdd results into a String or BigInt.

Here are some numbers for this specialization running
microbenchmarks:

big-int-simple-add 21.5411+-1.1096 ^{15.3502+-0.7027} definitely 1.4033x faster
big-int-add-prediction-propagation 13.7762+-0.5578 ^{10.8117+-0.5330} definitely 1.2742x faster

• bytecode/ArithProfile.cpp:

(JSC::ArithProfile::emitObserveResult):
(JSC::ArithProfile::shouldEmitSetNonNumeric const):
(JSC::ArithProfile::shouldEmitSetBigInt const):
(JSC::ArithProfile::emitSetNonNumeric const):
(JSC::ArithProfile::emitSetBigInt const):
(WTF::printInternal):
(JSC::ArithProfile::shouldEmitSetNonNumber const): Deleted.
(JSC::ArithProfile::emitSetNonNumber const): Deleted.

• bytecode/ArithProfile.h:

(JSC::ArithProfile::observedUnaryInt):
(JSC::ArithProfile::observedUnaryNumber):
(JSC::ArithProfile::observedBinaryIntInt):
(JSC::ArithProfile::observedBinaryNumberInt):
(JSC::ArithProfile::observedBinaryIntNumber):
(JSC::ArithProfile::observedBinaryNumberNumber):
(JSC::ArithProfile::didObserveNonInt32 const):
(JSC::ArithProfile::didObserveNonNumeric const):
(JSC::ArithProfile::didObserveBigInt const):
(JSC::ArithProfile::setObservedNonNumeric):
(JSC::ArithProfile::setObservedBigInt):
(JSC::ArithProfile::observeResult):
(JSC::ArithProfile::didObserveNonNumber const): Deleted.
(JSC::ArithProfile::setObservedNonNumber): Deleted.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::mayHaveNonNumericResult):
(JSC::DFG::Node::mayHaveBigIntResult):
(JSC::DFG::Node::mayHaveNonNumberResult): Deleted.

• dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

• dfg/DFGNodeFlags.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):

• runtime/CommonSlowPaths.cpp:

(JSC::updateArithProfileForUnaryArithOp):
(JSC::updateArithProfileForBinaryArithOp):

Tools:

• Scripts/run-jsc-benchmarks:

5:43 PM Changeset in webkit [237971] by Alan Coon

• 4 edits in branches/safari-606.3.4.1-branch/Source

Apply patch. rdar://problem/45837753

5:34 PM Changeset in webkit [237970] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

webrtc/datachannel/basic-tcp.html will crash with an invalid crash
​https://bugs.webkit.org/show_bug.cgi?id=178285
<rdar://problem/34985374>

Reviewed by Eric Carlson.

Reintroduce change made to libwebrtc and erroneously removed when refreshing libwebrtc.

• Source/webrtc/rtc_base/physicalsocketserver.cc:

5:31 PM Changeset in webkit [237969] by sihui_liu@apple.com

• 7 edits
  2 adds in trunk

RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
​https://bugs.webkit.org/show_bug.cgi?id=191326
<rdar://problem/45769269>

Reviewed by Geoffrey Garen.

Source/WebCore:

UniqueIDBDatabase should ignore incoming requests or operations when it is already marked as
hardClosedForUserDelete.

Test: IndexedDB.IndexedDBUserDelete.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::didPerformActivateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

• Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::deleteTransaction):

• Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
• Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::commit):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.

(-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):

5:30 PM Changeset in webkit [237968] by Alan Coon

• 125 edits
  4 adds
  29 deletes in tags/Safari-607.1.13

Revert r237547. rdar://problem/45895377

5:29 PM Changeset in webkit [237967] by Alan Coon

• 3 edits
  1 delete in tags/Safari-607.1.13

Revert r237553. rdar://problem/45895377

5:29 PM Changeset in webkit [237966] by Alan Coon

• 2 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237576. rdar://problem/45895377

5:29 PM Changeset in webkit [237965] by Alan Coon

• 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237627. rdar://problem/45895377

5:29 PM Changeset in webkit [237964] by Alan Coon

• 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237638. rdar://problem/45895377

5:29 PM Changeset in webkit [237963] by Alan Coon

• 3 edits
  1 delete in tags/Safari-607.1.13

Revert r237641. rdar://problem/45895377

5:29 PM Changeset in webkit [237962] by Alan Coon

• 2 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237645. rdar://problem/45895377

5:29 PM Changeset in webkit [237961] by Alan Coon

• 3 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237728. rdar://problem/45895377

5:29 PM Changeset in webkit [237960] by Alan Coon

• 4 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237734. rdar://problem/45895377

5:29 PM Changeset in webkit [237959] by Alan Coon

• 12 edits in tags/Safari-607.1.13

Revert r237803. rdar://problem/45895377

5:29 PM Changeset in webkit [237958] by Alan Coon

• 6 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237823. rdar://problem/45895377

5:29 PM Changeset in webkit [237957] by Alan Coon

• 142 edits
  1 add
  25 deletes in tags/Safari-607.1.13

Revert r237919. rdar://problem/45895377

5:28 PM Changeset in webkit [237956] by Alan Coon

• 12 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Revert r237933. rdar://problem/45895377

5:08 PM Changeset in webkit [237955] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

Positioned text underline can look like a strike-through
​https://bugs.webkit.org/show_bug.cgi?id=191341

Reviewed by Simon Fraser.

Source/WebCore:

We should just clamp the value so it can't go above the baseline.

We shouldn't do this at parse time because it's totally reasonable for text-underline-position: under to want
a negative text-underline-offset. Instead, we just do it at used value time.

Test: fast/css3-text/css3-text-decoration/text-underline-negative.html

• style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

LayoutTests:

• fast/css3-text/css3-text-decoration/text-underline-negative-expected.html: Added.
• fast/css3-text/css3-text-decoration/text-underline-negative.html: Added.

4:46 PM Changeset in webkit [237954] by Kocsen Chung

• 4 edits in branches/safari-606-branch/Source

Revert "Apply patch. rdar://problem/45523764"

4:39 PM Changeset in webkit [237953] by Dewei Zhu

• 3 edits in trunk/Websites/perf.webkit.org

"/api/report" does not check commit time correctly.
​https://bugs.webkit.org/show_bug.cgi?id=191351

Reviewed by Ryosuke Niwa.

Test result report API does not convert formated time string to timestamp correctly
which result in not checking commit time correctly.

• public/include/report-processor.php: Use 'strtotime' instead of 'floatval'.

Accepts the time delta within 1 seconds.

• server-tests/api-report-tests.js: Added unit tests.

(reportWitMismatchingCommitTime):
(reportWithOneSecondCommitTimeDifference):

4:36 PM Changeset in webkit [237952] by Chris Dumez

• 4 edits in trunk/Source

Unreviewed, fix iOS build with recent SDKs.

Source/WebCore:

• platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

Source/WebKit:

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController _EVOrganizationName]):

4:32 PM Changeset in webkit [237951] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, fix iOS build with recent SDKs.

• platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

4:30 PM Changeset in webkit [237950] by Dewei Zhu

• 3 edits in trunk/Websites/perf.webkit.org

Custom test group form should use commit set map before customization as the behavior of radio buttons.
​https://bugs.webkit.org/show_bug.cgi?id=191347

Reviewed by Ryosuke Niwa.

The radio button behavior should always set the same revision while editing the revision input.
That means we should not use the intermediate commit set map but use the commit set map before
"Customize" link is clicked.

• browser-tests/customizable-test-group-form-tests.js: Added a unit test for this bug.
• public/v3/components/customizable-test-group-form.js: Pass uncustomized commit set so that the radio button

behavoir preserves.
(CustomizableTestGroupForm):
(CustomizableTestGroupForm.prototype.setCommitSetMap):
(CustomizableTestGroupForm.prototype.didConstructShadowTree):
(CustomizableTestGroupForm.prototype.render):
(CustomizableTestGroupForm.prototype._renderCustomRevisionTable):
(CustomizableTestGroupForm.prototype._constructTableBodyList):
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithoutOwner):
(CustomizableTestGroupForm.prototype._constructTableRowForCommitsWithOwner):
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons):

4:15 PM Changeset in webkit [237949] by wilander@apple.com

• 4 edits in trunk/Source/WebKit

Resource Load Statistics: Enable cap on partitioned cache max age
​https://bugs.webkit.org/show_bug.cgi?id=191395
<rdar://problem/45885977>

Reviewed by Chris Dumez.

This change does not bump the network cache revision number.
It's not needed since it was done just a week ago.

• UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::setCacheMaxAgeCap):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCacheMaxAgeCap):

• UIProcess/ResourceLoadStatisticsMemoryStore.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess):

4:10 PM Changeset in webkit [237948] by mmaxfield@apple.com

• 5 edits
  2 adds in trunk

Dotted underlines that skip descenders are invisible
​https://bugs.webkit.org/show_bug.cgi?id=191403

Reviewed by Simon Fraser.

Source/WebCore:

Turns out our underline bounding boxes had negative width. When drawing the full
underline that was fine because it was handled by the 2D graphics engine, but when
we try to split up the box into dots, our "for" loop was taking 0 iterations (because
the end was before the start).

Test: fast/css3-text/css3-text-decoration/text-underline-style.html

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):

• platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawLineForText):

LayoutTests:

• fast/css3-text/css3-text-decoration/text-underline-style-expected.html: Added.
• fast/css3-text/css3-text-decoration/text-underline-style.html: Added.

3:49 PM Changeset in webkit [237947] by aestes@apple.com

• 5 edits in trunk

Crash in WebCore::PaymentRequest::canMakePayment when Apple Pay payment method data is missing
​https://bugs.webkit.org/show_bug.cgi?id=191331

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Apple Pay requires merchants specify an ApplePayRequest (which contains several required
fields) as payment method data when constructing a new PaymentRequest. If the
ApplePayRequest is missing required fields, or is missing entirely, canMakePayment() should
resolve to false.

We would properly resolve to false when an ApplePayRequest was specified with missing
required fields, but we would crash when the ApplePayRequest was missing entirely.

This patch fixes the crash by checking for an empty JSValue before trying to convert it to
an ApplePayRequest struct. Because we stringify ApplePayRequests in the PaymentRequest
constructor then parse them again in canMakePayments, an undefined or null payment method
data stringifies to a null String, which then parses to an empty JSValue.

Added test case to http/tests/paymentrequest/payment-request-canmakepayment-method.https.html.

• Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::convertData):

• Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

• http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:

3:02 PM Changeset in webkit [237946] by Simon Fraser

• 3 edits
  2 deletes in trunk

Revert 237849: it breaks MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=191398

Reviewed by Simon Fraser.

Source/WebCore:

This change broke painting while the test is running.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):

LayoutTests:

• fast/scrolling/ios/update-scroll-coordinated-status-expected.txt: Removed.
• fast/scrolling/ios/update-scroll-coordinated-status.html: Removed.

2:14 PM Changeset in webkit [237945] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit

[iOS] Support deleting to the start of the line and to the end of the line
​https://bugs.webkit.org/show_bug.cgi?id=191389
<rdar://problem/45883972>

Reviewed by Wenson Hsieh.

Add support for the key commands Command + Delete and Control + K to delete to the start
of the line and to delete to the end of the line, respectively.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deleteToStartOfLine]): Added.
(-[WKContentView _deleteToEndOfLine]): Added.

2:12 PM Changeset in webkit [237944] by don.olmstead@sony.com

• 4 edits in trunk/Source/WebCore

Simplify macros in platform
​https://bugs.webkit.org/show_bug.cgi?id=191378

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Modifies a few cases where a platform macro could be simplified.

• page/EventHandler.cpp:
• platform/network/DNS.h:
• platform/network/NetworkStateNotifier.h:

2:11 PM Changeset in webkit [237943] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit

[iOS] Option + Delete should delete previous word
​https://bugs.webkit.org/show_bug.cgi?id=191381
<rdar://problem/23681351>

Reviewed by Wenson Hsieh.

Implement support for pressing Option + Delete to delete the previous word. This makes text editing
in WebKit more closely match the platform conventions.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deleteByWord]):

1:46 PM Changeset in webkit [237942] by Simon Fraser

• 6 edits
  1 add in trunk

Some WK1 repaint tests are flakey
​https://bugs.webkit.org/show_bug.cgi?id=190627

Reviewed by Zalan Bujtas.
Source/WebCore:

Repaint tracking in GraphicsLayerCA was sensitive to whether there were already dirty
rects on the layer, since tracking happened after checks against existing dirty rects.
This caused some WK1 repaint tests to be flakey, since there's no guarantee that
no repaints happen between the last layer flush and a test calling startTrackingRepaints().

Fix by moving the repaint tracking to before the checks against existing dirty rects.
This is more similar to how repaint tracking on FrameView works.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):

LayoutTests:

New baseline.

• compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:

1:23 PM Changeset in webkit [237941] by Ross Kirsling

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

• platform/wincairo/TestExpectations:

1:12 PM Changeset in webkit [237940] by dino@apple.com

• 4 edits
  2 adds in trunk

[iOS] WebGL leaks exact GPU type
​https://bugs.webkit.org/show_bug.cgi?id=191393
Source/WebCore:

Reviewed by Tim Horton.

The fully exposed renderer info shouldn't be necessary
on iOS, where the GPUs and drivers are consistent
enough that people shouldn't need to write code specifically
for them. Reduce the ability to fingerprint by simply
returning "Apple GPU".

The other option would have been to disable the extension,
but I think it might still be useful to know you're on
an iOS device.

Test: fast/canvas/webgl/hide-some-renderer-info.html

• html/canvas/WebGL2RenderingContext.cpp: Return "Apple GPU"

on iOS.
(WebCore::WebGL2RenderingContext::getParameter):

• html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getParameter):

LayoutTests:

<rdar://problem/45788297>

Reviewed by Tim Horton.

A test that checks that when the GPU vendor is Apple we're
returning a generic renderer name.

• fast/canvas/webgl/hide-some-renderer-info-expected.txt: Added.
• fast/canvas/webgl/hide-some-renderer-info.html: Added.

1:00 PM Changeset in webkit [237939] by ajuma@chromium.org

• 3 edits in trunk/LayoutTests

IntersectionObserver GC-dependent tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=191387

Reviewed by Chris Dumez.

Make these tests more robust by triggering GC repeatedly inside a setInterval(). Having only a single call to
GC is potentially flaky, since that call will early-out and return immediately if a GC is already underway.

• intersection-observer/root-element-deleted.html:
• intersection-observer/target-deleted.html:

12:59 PM Changeset in webkit [237938] by Kocsen Chung

• 7 edits in trunk/Source

Versioning.

12:55 PM Changeset in webkit [237937] by Alan Coon

• 12 edits in tags/Safari-607.1.13/Source/JavaScriptCore

Cherry-pick r237933. rdar://problem/45739094

Align wide opcodes in the instruction stream
​https://bugs.webkit.org/show_bug.cgi?id=191254

Reviewed by Keith Miller.

Pad the bytecode with nops to ensure that wide opcodes are 4-byte
aligned on platforms that don't like unaligned memory access.

For that, add a new type to represent jump targets, BoundLabel, which
delays computing the offset in case we need to emit nops for padding.
Extra padding is also emitted before op_yield and at the of each
BytecodeWriter fragment, to ensure that the bytecode remains aligned
after the rewriting.

As a side effect, we can longer guarantee that the point immediately
before emitting an opcode is the start of that opcode, since nops
might be emitted in between if the opcode needs to be wide. To fix
that, we only take the offset of opcodes after they have been emitted,
using m_lastInstruction.offset().

• bytecode/BytecodeDumper.h: (JSC::BytecodeDumper::dumpValue):
• bytecode/BytecodeGeneratorification.cpp: (JSC::BytecodeGeneratorification::run):
• bytecode/BytecodeList.rb:
• bytecode/BytecodeRewriter.h: (JSC::BytecodeRewriter::Fragment::align): (JSC::BytecodeRewriter::insertFragmentBefore): (JSC::BytecodeRewriter::insertFragmentAfter):
• bytecode/Fits.h:
• bytecode/InstructionStream.h: (JSC::InstructionStreamWriter::ref):
• bytecode/PreciseJumpTargetsInlines.h: (JSC::updateStoredJumpTargetsForInstruction):
• bytecompiler/BytecodeGenerator.cpp: (JSC::Label::setLocation): (JSC::BoundLabel::target): (JSC::BoundLabel::saveTarget): (JSC::BoundLabel::commitTarget): (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::recordOpcode): (JSC::BytecodeGenerator::alignWideOpcode): (JSC::BytecodeGenerator::emitProfileControlFlow): (JSC::BytecodeGenerator::emitResolveScope): (JSC::BytecodeGenerator::emitGetFromScope): (JSC::BytecodeGenerator::emitPutToScope): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitDirectGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitDirectPutById): (JSC::BytecodeGenerator::emitGetByVal): (JSC::BytecodeGenerator::emitCreateThis): (JSC::BytecodeGenerator::beginSwitch): (JSC::BytecodeGenerator::endSwitch): (JSC::BytecodeGenerator::emitRequireObjectCoercible): (JSC::BytecodeGenerator::emitYieldPoint): (JSC::BytecodeGenerator::emitToThis): (JSC::Label::bind): Deleted.
• bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::recordOpcode): Deleted.
• bytecompiler/Label.h: (JSC::BoundLabel::BoundLabel): (JSC::BoundLabel::operator int): (JSC::Label::bind):
• generator/Opcode.rb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:50 PM Changeset in webkit [237936] by Alan Coon

• 1 copy in tags/Safari-607.1.13

Tag Safari-607.1.13.

12:12 PM Changeset in webkit [237935] by dbates@webkit.org

• 12 edits in trunk

Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=190141

Reviewed by Darin Adler.

Source/WebCore:

Remove the runtime application check for WebKitTestRunner as we no longer need this
now that WebKitTestRunner and DumpRenderTree override +[UIKeyboard isInHardwareKeyboardMode].

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isWebKitTestRunner): Deleted.

Source/WebKit:

Directly use +[UIKeyboard isInHardwareKeyboardMode]. We will override this class method
in DumpRenderTree and WebKitTestRunner to always return NO so as to make test runs
deterministic regardless of whether a hardware keyboard is attached.

• Shared/NativeWebKeyboardEvent.h:
• Shared/ios/NativeWebKeyboardEventIOS.mm:

(WebKit::isInHardwareKeyboardMode): Deleted.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Tools:

Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
runs deterministic regardless of whether a hardware keyboard is attached.

• DumpRenderTree/mac/DumpRenderTree.mm:

(overrideIsInHardwareKeyboardMode): Added.
(prepareConsistentTestingEnvironment):

• TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
• WebKitTestRunner/ios/TestControllerIOS.mm:

(overrideIsInHardwareKeyboardMode): Added.
(WTR::TestController::platformInitialize):

11:48 AM Changeset in webkit [237934] by commit-queue@webkit.org

• 16 edits in trunk/Source

Web Inspector: Fix "Javascript" => "JavaScript" enum in protocol generated objects
​https://bugs.webkit.org/show_bug.cgi?id=191340

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-11-07
Reviewed by Devin Rousso.

Source/JavaScriptCore:

• inspector/ConsoleMessage.cpp:

(Inspector::messageSourceValue):
Use new enum name.

• inspector/scripts/codegen/generator.py:

Correct the casing of "JavaScript".

Source/WebCore:

• inspector/agents/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):
Use new enum name.

Source/WebInspectorUI:

• UserInterface/Models/Canvas.js:

(WI.Canvas.fromPayload):
Insert a missing break statement for the WebGPU case.

• UserInterface/Models/MemoryTimelineRecord.js:

(WI.MemoryTimelineRecord.memoryCategoriesFromProtocol):
Use new enum name.

• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

Update enums with new generator.

11:38 AM Changeset in webkit [237933] by Tadeu Zagallo

• 12 edits in trunk/Source/JavaScriptCore

Align wide opcodes in the instruction stream
​https://bugs.webkit.org/show_bug.cgi?id=191254

Reviewed by Keith Miller.

Pad the bytecode with nops to ensure that wide opcodes are 4-byte
aligned on platforms that don't like unaligned memory access.

For that, add a new type to represent jump targets, BoundLabel, which
delays computing the offset in case we need to emit nops for padding.
Extra padding is also emitted before op_yield and at the of each
BytecodeWriter fragment, to ensure that the bytecode remains aligned
after the rewriting.

As a side effect, we can longer guarantee that the point immediately
before emitting an opcode is the start of that opcode, since nops
might be emitted in between if the opcode needs to be wide. To fix
that, we only take the offset of opcodes after they have been emitted,
using m_lastInstruction.offset().

• bytecode/BytecodeDumper.h:

(JSC::BytecodeDumper::dumpValue):

• bytecode/BytecodeGeneratorification.cpp:

(JSC::BytecodeGeneratorification::run):

• bytecode/BytecodeList.rb:
• bytecode/BytecodeRewriter.h:

(JSC::BytecodeRewriter::Fragment::align):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):

• bytecode/Fits.h:
• bytecode/InstructionStream.h:

(JSC::InstructionStreamWriter::ref):

• bytecode/PreciseJumpTargetsInlines.h:

(JSC::updateStoredJumpTargetsForInstruction):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC::BoundLabel::target):
(JSC::BoundLabel::saveTarget):
(JSC::BoundLabel::commitTarget):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::recordOpcode):
(JSC::BytecodeGenerator::alignWideOpcode):
(JSC::BytecodeGenerator::emitProfileControlFlow):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitDirectGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::emitCreateThis):
(JSC::BytecodeGenerator::beginSwitch):
(JSC::BytecodeGenerator::endSwitch):
(JSC::BytecodeGenerator::emitRequireObjectCoercible):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitToThis):
(JSC::Label::bind): Deleted.

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::recordOpcode): Deleted.

• bytecompiler/Label.h:

(JSC::BoundLabel::BoundLabel):
(JSC::BoundLabel::operator int):
(JSC::Label::bind):

• generator/Opcode.rb:

11:33 AM Changeset in webkit [237932] by mitz@apple.com

• 12 edits
  2 adds in trunk

Add a pseudoclass that matches img elements that are backed by an attachment
​https://bugs.webkit.org/show_bug.cgi?id=191286
<rdar://problem/45823554>

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css/has-attachment.html

Added a :has-attachment pseudoclass, enabled only when the attachment element is enabled at
runtime, that matches elements (currently only img elements qualify) that have an attachment
element in their shadow DOM.

• css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const): Handle the new PseudoClassHasAttachment value.

• css/CSSSelector.h: Added a new value to the PseudoClassType enum.

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const): Check the new PseudoClassHasAttachment value

using the new hasAttachment test function.

• css/SelectorCheckerTestFunctions.h:

(WebCore::hasAttachment): Added. Tests if the element is an img element that has an

attachment.

• css/SelectorPseudoClassAndCompatibilityElementMap.in: Added has-attachment.

• css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::CSSParserContext): Initialize new attachmentEnabled member based

on RuntimeEnabledFeatures.

(WebCore::operator==): Compare new attachmentEnabled member.

• css/parser/CSSParserContext.h:

(WebCore::CSSParserContextHash::hash): Include new attachmentEnabled member.

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo): Reject :has-attachment if the attachment

element is not enabled.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType): Handle PseudoClassHasAttachment.

LayoutTests:

• fast/css/has-attachment-expected.txt: Added.
• fast/css/has-attachment.html: Added.
• platform/win/TestExpectations:

11:25 AM Changeset in webkit [237931] by Jonathan Bedard

• 3 edits in trunk/Tools

Unreviewed, rolling out r237913.

Breaks running tests on Mac without iOS SDK installed

Reverted changeset:

"webkitpy: Generalize trailing SDK specifier (Part 2)"
​https://bugs.webkit.org/show_bug.cgi?id=191275
​https://trac.webkit.org/changeset/237913

10:49 AM Changeset in webkit [237930] by don.olmstead@sony.com

• 4 edits
  1 delete in trunk/Source/WebCore

Make generic MainThreadSharedTimer implementation
​https://bugs.webkit.org/show_bug.cgi?id=191327

Reviewed by Michael Catanzaro.

No new tests. No change in behavior.

Moves generic implementation for MainThreadSharedTimerGlib.cpp into
MainThreadSharedTimer.cpp.

• platform/MainThreadSharedTimer.cpp:

(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::invalidate):

• platform/MainThreadSharedTimer.h:
• platform/SourcesGLib.txt:
• platform/glib/MainThreadSharedTimerGLib.cpp: Removed.

10:30 AM Changeset in webkit [237929] by ajuma@chromium.org

• 5 edits
  2 adds in trunk

IntersectionObserverEntry doesn't keep JS wrappers of rects alive
​https://bugs.webkit.org/show_bug.cgi?id=191330

Reviewed by Chris Dumez.

Source/WebCore:

Retain wrappers of each rect in an IntersectionObserverEntry as long as the entry's wrapper
is alive, by adding these wrappers as opaque roots.

Test: intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive.html

• bindings/js/JSIntersectionObserverEntryCustom.cpp:

(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren):

• dom/DOMRectReadOnly.idl:
• page/IntersectionObserverEntry.h:

(WebCore::IntersectionObserverEntry::rootBounds const): Make this return a raw pointer instead of a RefPtr so that it
can be called in JSIntersectionObserverEntry::visitAdditionalChildren, which can be called from non-main threads.
(WebCore::IntersectionObserverEntry::boundingClientRect const): Ditto.
(WebCore::IntersectionObserverEntry::intersectionRect const): Ditto.

LayoutTests:

Add test coverage.

• intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive-expected.txt: Added.
• intersection-observer/intersection-observer-entry-keeps-js-wrappers-of-rects-alive.html: Added.

9:30 AM Changeset in webkit [237928] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Unreviewed, update test expectations for fast/events/pointer.

• TestExpectations: Skip this directory.
• platform/ios/TestExpectations: Remove skip since it is now skipped globally.

9:04 AM Changeset in webkit [237927] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Layout Test fast/text/international/khmer-selection.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=191368

Unreviewed test gardening.

• platform/win/TestExpectations:

8:57 AM Changeset in webkit [237926] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Layout Test fast/block/basic/quirk-mode-percent-height.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=191366

Unreviewed test gardening.

• platform/win/TestExpectations:

7:21 AM Changeset in webkit [237925] by Simon Fraser

• 4 edits in trunk/Source/WebCore

TileController::tileSize() should not have side effects
​https://bugs.webkit.org/show_bug.cgi?id=191349

Reviewed by Zalan Bujtas.

Calling TileController::tileSize() would recompute a new tile size and set m_tileSizeLocked,
which caused test failures if logging was enabled when running tests.

• platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileSize const):
(WebCore::TileController::computeTileSize):

• platform/graphics/ca/TileController.h:
• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::revalidateTiles):

6:57 AM Changeset in webkit [237924] by commit-queue@webkit.org

• 16 edits
  2 adds in trunk

Source/WebKit:
Force a gregorian calendar to show for credit card expiration date inputs
(autocomplete='cc-exp'*) regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Added some plumbing code to expose the calendar identifier of the calendar used by a
presented date picker. Added shouldPresentGregorianCalendar:, to be used for
determining what property values a date input control must present a Gregorian
calendar for.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView formInputPeripheral]):

• UIProcess/ios/forms/WKFormInputControl.mm:

Tools:
Force a gregorian calendar to show for credit card expiration date inputs
(autocomplete='cc-exp'*) regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Implemented simulateForeignDefaultCalendar and calendarType to be used
for changing the default calendar returned by the system (ie. [NSCalendar
currentCalendar]) and getting the calendar type identifier of a presented date
picker.

• DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isShowingDataListSuggestions const):
(WTR::UIScriptController::calendarType const):
(WTR::UIScriptController::setDefaultCalendarType):

• DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::calendarType const):
(WTR::UIScriptController::setDefaultCalendarType):

• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::calendarType const): Deleted.

• WebKitTestRunner/TestController.cpp:
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::calendarType const):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::swizzledCalendar):
(WTR::TestController::getOverriddenCalendarIdentifier const):
(WTR::TestController::setDefaultCalendarType):
(WTR::TestController::cocoaResetStateToConsistentValues):

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::calendarType const): Deleted.

LayoutTests:
Created a layout test to ensure that date controls marked as credit card expiry
fields present a Gregorian calendar regardless of default system settings.
​https://bugs.webkit.org/show_bug.cgi?id=191096
rdar://problem/42640256

Patch by Zamiul Haque <​zhaque@apple.com> on 2018-11-07
Reviewed by Tim Horton.

Added two new methods to UIHelper, helping to facilitate this. calendarType
returns the calendar identifier of the NSCalendar instance used by the presented
date picker and setDefaultCalendarType accepts a calendar identifier as an
argument for changing the default system settings.

• fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html:
• platform/win/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.calendarType):
(window.UIHelper.setDefaultCalendarType):

6:49 AM Changeset in webkit [237923] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK/WPE build when memfd is not available after r237922.

• Platform/unix/SharedMemoryUnix.cpp:

(WebKit::createSharedMemory):

6:24 AM Changeset in webkit [237922] by Carlos Garcia Campos

• 4 edits in trunk

[Linux] Use memfd_create when available in SharedMemory implementation
​https://bugs.webkit.org/show_bug.cgi?id=189741

Reviewed by Michael Catanzaro.

.:

Add include check for linux/memfd.h header.

• Source/cmake/OptionsCommon.cmake:

Source/WebKit:

If memfd is available, use it instead of shm_open.

• Platform/unix/SharedMemoryUnix.cpp:

(WebKit::createSharedMemory): Helper to create the shared memory, trying first with memfd and falling back to
shm if it's not available.
(WebKit::SharedMemory::create): Use createSharedMemory() helper.

3:50 AM Changeset in webkit [237921] by cturner@igalia.com

• 5 edits in trunk/Source/WebCore

[EME][GStreamer] Ensure key id buffers are present and simplify lifetime management of ClearKey class.
​https://bugs.webkit.org/show_bug.cgi?id=191157

Reviewed by Xabier Rodriguez-Calvar.

This is in preparation for moving the clearkey decryptor behind a
new decrypt API in CDMInstance, which will be sent into the
pipeline to handle key management and decryption. This is for a
later patch.

Covered by existing clear key tests in media/encrypted-media.

• platform/graphics/gstreamer/GStreamerCommon.h:

(WebCore::GstMappedBuffer::data const): Add a const data accessor,
since we are now providing operator=='s on const objects of this
class that need const access to the data pointer.
(WebCore::GstMappedBuffer::operator==): Add a swap of the new
equality operator so you don't have to remember to have the
GstBuffer on the RHS of the equality all the time.
(WebCore::operator==): Define an equality operator between Gst
buffers and WebCore's mapped buffers. Gst creates a ref and a
separate read view under the covers in the memcmp call, so we do
not need to map the buffer ourselves.

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init): Remove setup/release
bindings.
(webkit_media_clear_key_decrypt_init): Initialize gcrypt cipher
here once instead of for every buffer to be decrypted.
(webKitMediaClearKeyDecryptorFinalize): And destroy the cipher
context when the decryptor is destroyed.
(webKitMediaClearKeyDecryptorFindAndSetKey): Factor out the key
retrieval and context setting in this method, call it for each
sample.
(webKitMediaClearKeyDecryptorDecrypt): Base key id buffer into
this function, and remove cipher creation / destroy methods.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init): Remove
setup/release bindings.
(webkitMediaCommonEncryptionDecryptTransformInPlace): Ensure a key
id is present and pass it to the decrypt class method.
(webKitMediaCommonEncryptionDecryptDefaultSetupCipher): Deleted.
(webKitMediaCommonEncryptionDecryptDefaultReleaseCipher): Deleted.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:

3:29 AM Changeset in webkit [237920] by fred.wang@free.fr

• 2 edits in trunk/Source/WebCore

[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
​https://bugs.webkit.org/show_bug.cgi?id=179610

Unreviewed build fix.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-07

• platform/graphics/cairo/GraphicsContextCairo.cpp: Add missing include.

1:05 AM Changeset in webkit [237919] by Tadeu Zagallo

• 69 edits in trunk

REGRESSION(r237547): Test failures on 32-bit JSC since the JIT was disabled
​https://bugs.webkit.org/show_bug.cgi?id=191184

Reviewed by Saam Barati.

JSTests:

Most tests were failing due to timeouts, since they are too slow to
run on CLoop. The exceptions are:

proxy-get-set-correct-receiver.js: Had to reduce the recursion depth not to overflow on CLoop
dont-crash-on-stack-overflow-when-parsing-builtin.js and
dont-crash-on-stack-overflow-when-parsing-default-constructor.js: had
to change the stack size since CLoop requires it to be page aligned.

• microbenchmarks/array-push-1.js:
• microbenchmarks/array-push-2.js:
• microbenchmarks/elidable-new-object-dag.js:
• microbenchmarks/elidable-new-object-roflcopter.js:
• microbenchmarks/elidable-new-object-tree.js:
• microbenchmarks/getter-richards.js:
• microbenchmarks/sinkable-new-object-dag.js:
• microbenchmarks/string-concat-long-convert.js:
• microbenchmarks/typed-array-get-set-by-val-profiling.js:
• slowMicrobenchmarks/array-push-3.js:
• slowMicrobenchmarks/large-map-iteration-with-additions.js:
• slowMicrobenchmarks/spread-small-array.js:
• slowMicrobenchmarks/undefined-property-access.js:
• stress/activation-sink-default-value-tdz-error.js:
• stress/activation-sink-default-value.js:
• stress/activation-sink-osrexit-default-value-tdz-error.js:
• stress/activation-sink-osrexit-default-value.js:
• stress/activation-sink-osrexit.js:
• stress/activation-sink.js:
• stress/allow-math-ic-b3-code-duplication.js:
• stress/array-push-multiple-int32.js:
• stress/arrowfunction-activation-sink-osrexit-default-value-tdz-error.js:
• stress/arrowfunction-lexical-this-activation-sink-osrexit.js:
• stress/arrowfunction-lexical-this-activation-sink.js:
• stress/dont-crash-on-stack-overflow-when-parsing-builtin.js:
• stress/dont-crash-on-stack-overflow-when-parsing-default-constructor.js:
• stress/elide-new-object-dag-then-exit.js:
• stress/materialize-regexp-cyclic.js:
• stress/new-regex-inline.js:
• stress/op_add.js:
• stress/op_bitand.js:
• stress/op_bitor.js:
• stress/op_bitxor.js:
• stress/op_div-ConstVar.js:
• stress/op_div-VarConst.js:
• stress/op_div-VarVar.js:
• stress/op_lshift-ConstVar.js:
• stress/op_lshift-VarConst.js:
• stress/op_lshift-VarVar.js:
• stress/op_mod-ConstVar.js:
• stress/op_mod-VarConst.js:
• stress/op_mod-VarVar.js:
• stress/op_mul-ConstVar.js:
• stress/op_mul-VarConst.js:
• stress/op_mul-VarVar.js:
• stress/op_rshift-ConstVar.js:
• stress/op_rshift-VarConst.js:
• stress/op_rshift-VarVar.js:
• stress/op_sub-ConstVar.js:
• stress/op_sub-VarConst.js:
• stress/op_sub-VarVar.js:
• stress/op_urshift-ConstVar.js:
• stress/op_urshift-VarConst.js:
• stress/op_urshift-VarVar.js:
• stress/proxy-get-set-correct-receiver.js:
• stress/regress-179562.js:
• stress/rest-parameter-many-arguments.js:
• stress/sampling-profiler-richards.js:
• stress/splay-flash-access-1ms.js:
• stress/tailCallForwardArguments.js:
• stress/typed-array-get-by-val-profiling.js:
• typeProfiler/getter-richards.js:

PerformanceTests:

Skip test when the JIT is disabled, it takes too long to run on CLoop.

• JetStream/cdjs/main.js:

Source/JavaScriptCore:

Fix API test on CLoop: we can only disable the LLInt when the JIT is enabled.

• API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

LayoutTests:

Skip test when the JIT is disabled since it's too slow to run on CLoop.

• js/script-tests/regress-139548.js: