Timeline



Nov 13, 2018:

11:36 PM Changeset in webkit [238167] by Dewei Zhu
  • 7 edits in trunk/Websites/perf.webkit.org

Add cache for CommitLog objects to avoid refetching same commit.
​https://bugs.webkit.org/show_bug.cgi?id=191621

Reviewed by Ryosuke Niwa.

Added a cache for fully fetched commit log objects to avoid refetching.

  • public/v3/models/commit-log.js:

(CommitLog): Added assertion for id.
Removed unused 'remoteId' as it has been removed since r198479.
(CommitLog.async.fetchBetweenRevisions): Turned it into async function.
(CommitLog.async.fetchForSingleRevision): Added the logic to check cache before fetching.
(CommitLog._constructFromRawData): Added logic to add entries to cache.

  • public/v3/models/commit-set.js: Fixed measurement set not passing commit id while constructing a

commit log object.

  • public/v3/models/repository.js: Added the ability to track fetched commit for certain repository.

(Repository.commitForRevision): Returns a commit for given revision.
(Repository.setCommitForRevision): Sets commit for a given revision.

  • unit-tests/commit-log-tests.js: Added unit tests for this change.

Fixed existing tests.

  • unit-tests/commit-set-range-bisector-tests.js: Fixed unit tests.
  • unit-tests/commit-set-tests.js: Fixed unit tests.
10:54 PM Changeset in webkit [238166] by jiewen_tan@apple.com
  • 31 edits
    5 copies
    1 move
    24 adds in trunk

[WebAuthN] Support CTAP HID authenticators on macOS
​https://bugs.webkit.org/show_bug.cgi?id=188623
<rdar://problem/43353777>

Reviewed by Brent Fulgham and Chris Dumez.

Source/WebCore:

This patch removes AuthenticatorCoordinatorClient::~AuthenticatorCoordinatorClient to ignore
any incompleted CompletionHandlers as calling them in destructors could cause unexpected cyclic
dependency. Also, it adds a hack to temporarily deal with nullable userhandle.

Tests: http/wpt/webauthn/ctap-hid-failure.https.html

http/wpt/webauthn/ctap-hid-success.https.html
http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html
http/wpt/webauthn/public-key-credential-create-failure-hid.https.html
http/wpt/webauthn/public-key-credential-create-success-hid.https.html
http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html
http/wpt/webauthn/public-key-credential-get-failure-hid.https.html
http/wpt/webauthn/public-key-credential-get-success-hid.https.html

  • Modules/webauthn/AuthenticatorCoordinatorClient.cpp:

(WebCore::AuthenticatorCoordinatorClient::~AuthenticatorCoordinatorClient): Deleted.

  • Modules/webauthn/AuthenticatorCoordinatorClient.h:
  • Modules/webauthn/PublicKeyCredentialCreationOptions.h:
  • Modules/webauthn/fido/DeviceResponseConverter.cpp:

(fido::readCTAPGetAssertionResponse):

  • Modules/webauthn/fido/FidoConstants.h:

Source/WebKit:

This patch introduces a primitive support of CTAP HID authenticators for WebAuthN in macOS.
It involves low level HID device management&communication, high level CTAP HID authenticator
management&communication, and mock testing. The above three aspects will be covered in details:
1) Low level HID device management&communication: HidService&HidConnection
It relies on IOHIDManager to discover appropriate hid devices by passing a matching dictionary:
{ PrimaryUsagePage: 0xf1d0, PrimaryUsage: 0x01}. For communication, it utilizes HID reports.
To send a report, it calls IOHIDDeviceSetReport since the async version is not implemented.
To recieve a report, it calls IOHIDDeviceRegisterInputReportCallback to asynchronously wait
for incoming reports.
Here is the corresponding reference:
​https://developer.apple.com/library/archive/documentation/DeviceDrivers/Conceptual/HID/new_api_10_5/tn2187.html#//apple_ref/doc/uid/TP40000970-CH214-SW2
2) High level CTAP HID authenticator management&communication: HidService&CtapHidDriver
Whenever an appropriate hid device is discovered by IOHIDManager, an AuthenticatorGetInfo command
is sent to the device to determine properties of the authenticator, says, which version of protocol
it supports, i.e. CTAP or U2F. So far, we only support CTAP authenticators. Once the authenticator
is determined to support CTAP, we then instantiate CtapHidAuthenticator which will then take care
of even higher level WebAuthN requests&responses.
Binaries are constructed and packaged according to the CTAP HID porotocol. CtapHidDriver takes care
of concurrency and channels, i.e. allocating channel and establishing the actual request/response
transaction. At the meantime, CtapHidDriver::Worker is then responsible for each single transaction.
Here is the corresponding reference:
​https://fidoalliance.org/specs/fido-v2.0-ps-20170927/fido-client-to-authenticator-protocol-v2.0-ps-20170927.html#usb.
3) Mock Testing: MockHidService & MockHidConnection
A CTAP hid authenticator is simulated within MockHidConnection with options of specifying specific
error scenarios and of course could take care of successful cases. Four stages are presented in the
simulated authenticator to reflect: a) allocating channel for AuthenticatorGetInfo, b) sending
AuthenticatorGetInfo, c) allocating channel for actual request, and d) sending the actual request.

Besides implementing the above, it also does a few other things:
1) Make AuthenticatorManager::clearState asynchronous to avoid cyclic dependency:
Authenticator::returnResponse => AuthenticatorManager::respondReceived => AuthenticatorManager::clearState
=> Authenticator::~Authenticator.
2) Reorganize unified build sources to make it clear that which files are .mm and which are .cpp.
3) Import LocalAuthentication.framework in LocalAuthenticationSoftLink instead of being scattered.

  • Sources.txt:
  • SourcesCocoa.txt:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetWebAuthenticationMockConfiguration):

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManagerInternal::collectTransports):
(WebKit::AuthenticatorManager::clearStateAsync):
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::initTimeOutTimer):

  • UIProcess/WebAuthentication/AuthenticatorManager.h:
  • UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:

(WebKit::AuthenticatorTransportService::create):
(WebKit::AuthenticatorTransportService::createMock):
(WebKit::AuthenticatorTransportService::startDiscovery):
(WebKit::AuthenticatorTransportService::startDiscovery const): Deleted.

  • UIProcess/WebAuthentication/AuthenticatorTransportService.h:
  • UIProcess/WebAuthentication/Cocoa/HidConnection.h: Copied from Source/WebKit/UIProcess/WebAuthentication/AuthenticatorTransportService.h.
  • UIProcess/WebAuthentication/Cocoa/HidConnection.mm: Added.

(WebKit::reportReceived):
(WebKit::HidConnection::HidConnection):
(WebKit::HidConnection::~HidConnection):
(WebKit::HidConnection::initialize):
(WebKit::HidConnection::terminate):
(WebKit::HidConnection::send):
(WebKit::HidConnection::registerDataReceivedCallback):
(WebKit::HidConnection::unregisterDataReceivedCallback):
(WebKit::HidConnection::receiveReport):
(WebKit::HidConnection::consumeReports):
(WebKit::HidConnection::registerDataReceivedCallbackInternal):

  • UIProcess/WebAuthentication/Cocoa/HidService.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.h.
  • UIProcess/WebAuthentication/Cocoa/HidService.mm: Added.

(WebKit::deviceAddedCallback):
(WebKit::deviceRemovedCallback):
(WebKit::HidService::HidService):
(WebKit::HidService::~HidService):
(WebKit::HidService::startDiscoveryInternal):
(WebKit::HidService::platformStartDiscovery):
(WebKit::HidService::createHidConnection const):
(WebKit::HidService::deviceAdded):
(WebKit::HidService::continueAddDeviceAfterGetInfo):

  • UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.h:
  • UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
  • UIProcess/WebAuthentication/Cocoa/LocalService.h:
  • UIProcess/WebAuthentication/Cocoa/LocalService.mm:

(WebKit::LocalService::startDiscoveryInternal):
(WebKit::LocalService::startDiscoveryInternal const): Deleted.

  • UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::respondReceivedInternal):

  • UIProcess/WebAuthentication/Mock/MockHidConnection.cpp: Added.

(WebKit::MockHidConnection::MockHidConnection):
(WebKit::MockHidConnection::initialize):
(WebKit::MockHidConnection::terminate):
(WebKit::MockHidConnection::send):
(WebKit::MockHidConnection::registerDataReceivedCallbackInternal):
(WebKit::MockHidConnection::assembleRequest):
(WebKit::MockHidConnection::parseRequest):
(WebKit::MockHidConnection::feedReports):
(WebKit::MockHidConnection::stagesMatch const):
(WebKit::MockHidConnection::shouldContinueFeedReports):
(WebKit::MockHidConnection::continueFeedReports):

  • UIProcess/WebAuthentication/Mock/MockHidConnection.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h.
  • UIProcess/WebAuthentication/Mock/MockHidService.cpp: Copied from Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalService.cpp.

(WebKit::MockHidService::MockHidService):
(WebKit::MockHidService::platformStartDiscovery):
(WebKit::MockHidService::createHidConnection const):

  • UIProcess/WebAuthentication/Mock/MockHidService.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h.
  • UIProcess/WebAuthentication/Mock/MockLocalConnection.h:
  • UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:
  • UIProcess/WebAuthentication/Mock/MockLocalService.mm: Renamed from Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalService.cpp.

(WebKit::MockLocalService::MockLocalService):
(WebKit::MockLocalService::platformStartDiscovery const):
(WebKit::MockLocalService::createLocalConnection const):

  • UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h:
  • UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp: Added.

(WebKit::CtapHidAuthenticator::CtapHidAuthenticator):
(WebKit::CtapHidAuthenticator::makeCredential):
(WebKit::CtapHidAuthenticator::continueMakeCredentialAfterResponseReceived const):
(WebKit::CtapHidAuthenticator::getAssertion):
(WebKit::CtapHidAuthenticator::continueGetAssertionAfterResponseReceived const):

  • UIProcess/WebAuthentication/fido/CtapHidAuthenticator.h: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.h.
  • UIProcess/WebAuthentication/fido/CtapHidDriver.cpp: Added.

(WebKit::CtapHidDriver::Worker::Worker):
(WebKit::CtapHidDriver::Worker::~Worker):
(WebKit::CtapHidDriver::Worker::transact):
(WebKit::CtapHidDriver::Worker::write):
(WebKit::CtapHidDriver::Worker::read):
(WebKit::CtapHidDriver::Worker::returnMessage):
(WebKit::CtapHidDriver::CtapHidDriver):
(WebKit::CtapHidDriver::transact):
(WebKit::CtapHidDriver::continueAfterChannelAllocated):
(WebKit::CtapHidDriver::continueAfterResponseReceived):
(WebKit::CtapHidDriver::returnResponse):

  • UIProcess/WebAuthentication/fido/CtapHidDriver.h: Added.
  • UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
  • WebKit.xcodeproj/project.pbxproj:

Tools:

This patch adds support for the mock testing and entitlements to allow minibrowser to talk
to hid devices.

  • MiniBrowser/MiniBrowser.entitlements:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebAuthenticationMockConfiguration):

LayoutTests:

  • http/wpt/webauthn/ctap-hid-failure.https-expected.txt: Added.
  • http/wpt/webauthn/ctap-hid-failure.https.html: Added.
  • http/wpt/webauthn/ctap-hid-success.https-expected.txt: Added.
  • http/wpt/webauthn/ctap-hid-success.https.html: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https.html: Added.
  • http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https.html: Added.
  • http/wpt/webauthn/public-key-credential-get-success-hid.https-expected.txt: Added.
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html: Added.
  • http/wpt/webauthn/resources/util.js:
  • platform/ios-wk2/TestExpectations:
10:14 PM Changeset in webkit [238165] by rniwa@webkit.org
  • 3 edits in trunk/Tools

WebKit.GeolocationTransitionToLowAccuracy API crashes when enabling PSON
​https://bugs.webkit.org/show_bug.cgi?id=191616

Reviewed by Chris Dumez.

The crash was caused by WKView in autorelease pool invoking stopUpdatingCallback after
GeolocationTransitionToLowAccuracyStateTracker in the stack had been destroyed,
resulting in the use-after-free.

Made the tests more robust by clearing geolocation provider before exiting each test
since we can't really prevent WKView from entering an autorelease pool.

Also made WebKit.GeolocationTransitionToLowAccuracy wait for the success callback
instead of simply the end of the navigation so that the test would continue to work
even if a web content process was created for the second web view (lowAccuracyWebView)

  • TestWebKitAPI/Tests/WebKit/Geolocation.cpp:

(TestWebKitAPI::setupGeolocationProvider): Moved "*" to match the WebKit coding style guideline.
(TestWebKitAPI::clearGeolocationProvider): Added.
(TestWebKitAPI::runJavaScriptAlert): Added.
(TestWebKitAPI::didFinishNavigation): Deleted.

  • TestWebKitAPI/Tests/WebKit/geolocationWatchPosition.html:
9:31 PM Changeset in webkit [238164] by Dewei Zhu
  • 4 edits in trunk/Websites/perf.webkit.org

commit time returned by '/api/measurement-set' should match the one returned by '/api/commits'.
​https://bugs.webkit.org/show_bug.cgi?id=191457

Reviewed by Dean Jackson and Ryosuke Niwa.

Commit time returned by '/api/measurement-set' sometimes is calculated by 'epoch from ..'.
This function will return a floating number with 5 or 6 decimal digits due to double precision limitations.
However, some commits may be reported with 6 decimal decimal.
So the commit time for those commits will be rounded to 5 decimal digits.
In order to avoid front end assertion failure in CommitLog, Database::to_js_time need to
match this behavior.

  • public/include/db.php: Change the behavior to match that of postgres.

Added logic to avoid losing precision in php.

  • server-tests/api-measurement-set-tests.js: Added unit tests for this bug.

(queryPlatformAndMetric): Fix a bug that arguments are not used at all.

8:58 PM Changeset in webkit [238163] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ProxyObject should check for VMInquiry and return early before throwing a stack overflow exception
​https://bugs.webkit.org/show_bug.cgi?id=191601

Reviewed by Mark Lam.

This doesn't fix any bugs today, but it may reduce future bugs. It was
always weird that ProxyObject::getOwnPropertySlot with VMInquiry might
throw a stack overflow error instead of just returning false like it
normally does when VMInquiry is passed in.

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::getOwnPropertySlotCommon):

8:57 PM Changeset in webkit [238162] by sbarati@apple.com
  • 13 edits
    1 add in trunk

TypeProfileLog::processLogEntries should stash away any pending exceptions and re-apply them to the VM
​https://bugs.webkit.org/show_bug.cgi?id=191600

Reviewed by Mark Lam.

JSTests:

  • stress/type-profiler-log-should-defer-pending-exceptions.js: Added.

(foo):
(test):
(bar):

Source/JavaScriptCore:

processLogEntries will call into calculatedClassName, which will clear
any exceptions it encounters (it assumes that they're stack overflow exceptions).
However, this code may be called when an exception is already pending on the
VM (e.g, when we throw an exception in the DFG, we compile an OSR exit
offramp, which may compile a baseline codeblock, which will process
the type profiler log). To get around this, processLogEntires should stash
away and re-apply any pending exceptions.

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGOperations.cpp:
  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • jit/JIT.cpp:

(JSC::JIT::doMainThreadPreparationBeforeCompile):

  • jit/JITOperations.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):

  • runtime/TypeProfilerLog.h:
  • runtime/VM.cpp:

(JSC::VM::dumpTypeProfilerData):

  • runtime/VM.h:

(JSC::VM::DeferExceptionScope::DeferExceptionScope):

  • tools/JSDollarVM.cpp:

(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):

8:52 PM Changeset in webkit [238161] by Ross Kirsling
  • 2 edits in trunk/Source/WebKit

Unreviewed correction to previous build fix to avoid any internal/downstream repercussions.

  • WebProcess/Network/webrtc/LibWebRTCProvider.h:
8:22 PM Changeset in webkit [238160] by Ross Kirsling
  • 2 edits in trunk/Source/WebKit

Unreviewed GTK/WPE build fix for r238159.

  • WebProcess/Network/webrtc/LibWebRTCProvider.h:
7:57 PM Changeset in webkit [238159] by Ross Kirsling
  • 6 edits
    2 moves
    1 delete in trunk/Source/WebCore

[WebRTC] Provide default implementation of LibWebRTCProvider
​https://bugs.webkit.org/show_bug.cgi?id=191611

Reviewed by Michael Catanzaro.

Refactor LibWebRTCProvider such that platform-specific implementations need not worry about specifying defaults.

  • PlatformWin.cmake:
  • platform/GStreamer.cmake:
  • platform/SourcesGLib.txt:
  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
  • platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
  • platform/mediastream/libwebrtc/LibWebRTCProviderGStreamer.cpp: Renamed from Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp.
  • platform/mediastream/libwebrtc/LibWebRTCProviderGStreamer.h: Renamed from Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderGlib.h.
  • platform/mediastream/libwebrtc/LibWebRTCProviderWin.cpp: Removed.
7:48 PM Changeset in webkit [238158] by Chris Dumez
  • 2 edits in trunk/Tools

WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
​https://bugs.webkit.org/show_bug.cgi?id=191618

Reviewed by Ryosuke Niwa.

Update API test to explicitly disable automatic process prewarning since it is testing
manual prewarming.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:

(TEST):

7:42 PM Changeset in webkit [238157] by Chris Dumez
  • 2 edits in trunk/Tools

Several Service Worker API tests are failing when enabling PSON
​https://bugs.webkit.org/show_bug.cgi?id=191619

Reviewed by Youenn Fablet.

Update tests to use _webProcessCountIgnoringPrewarmed instead of _webProcessCount so that they are
not impacted by process prewarming.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
5:47 PM Changeset in webkit [238156] by Ryan Haddad
  • 9 edits
    1 delete in trunk

Unreviewed, rolling out r238132.

The test added with this change is timing out on Debug JSC
bots.

Reverted changeset:

"[BigInt] JSBigInt::createWithLength should throw when length
is greater than JSBigInt::maxLength"
​https://bugs.webkit.org/show_bug.cgi?id=190836
​https://trac.webkit.org/changeset/238132

5:15 PM Changeset in webkit [238155] by timothy@apple.com
  • 17 edits
    2 adds in trunk

Use a light scrollbar for transparent web views in dark mode.
​https://bugs.webkit.org/show_bug.cgi?id=191559
rdar://problem/46000489

Reviewed by Dean Jackson.

Source/WebCore:

Test: css-dark-mode/supported-color-schemes-scrollbar.html

  • css/CSSProperties.json: Marked supported-color-schemes as a custom Value.
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes):

  • editing/cocoa/WebContentReaderCocoa.mm: Use FrameView's useDarkAppearance().

(WebCore::createFragment):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint): Use FrameView's useDarkAppearance().

  • page/FrameView.cpp:

(WebCore::FrameView::recalculateScrollbarOverlayStyle): Use a light scrollbar for
transparent web views in dark mode.
(WebCore::FrameView::rendererForSupportedColorSchemes const): Added.
Return the body for document element renderer.
(WebCore::FrameView::useDarkAppearance const): Use rendererForSupportedColorSchemes.
(WebCore::FrameView::styleColorOptions const): Added. Ditto.

  • page/FrameView.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::rareInheritedDataChangeRequiresRepaint): Drive-by fix. Added supportedColorSchemes.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Added.
(WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Added.
(WebCore::RenderStyle::NonInheritedFlags::operator== const): Added supportedColorSchemes.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw): Use FrameView's useDarkAppearance().

  • testing/Internals.cpp:

(WebCore::Internals::setViewIsTransparent): Added.
(WebCore::Internals::scrollbarOverlayStyle const): Added.

  • testing/Internals.h:
  • testing/Internals.idl: Added setViewIsTransparent and scrollbarOverlayStyle.

Source/WebKit:

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage): Use FrameView's useDarkAppaearance().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRect): Ditto.

LayoutTests:

  • css-dark-mode/supported-color-schemes-scrollbar-expected.txt: Added.
  • css-dark-mode/supported-color-schemes-scrollbar.html: Added.
3:42 PM Changeset in webkit [238154] by Kocsen Chung
  • 1 copy in tags/Safari-606.3.4.1.4

Tag Safari-606.3.4.1.4.

3:30 PM Changeset in webkit [238153] by Kocsen Chung
  • 4 edits in branches/safari-606.3.4.1-branch/Source

Revert r237971. rdar://problem/46043804

3:28 PM Changeset in webkit [238152] by Ross Kirsling
  • 3 edits in trunk/Source/WebCore

[AppleWin] Unreviewed build fix after r238108.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printLayer):
(PlatformCALayerWin::embeddedViewID const):

  • platform/graphics/ca/win/PlatformCALayerWin.h:
3:23 PM Changeset in webkit [238151] by Kocsen Chung
  • 7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

3:22 PM Changeset in webkit [238150] by youenn@apple.com
  • 10 edits in trunk

RTCPeerConnection.getTransceivers is not always exposing all transceivers
​https://bugs.webkit.org/show_bug.cgi?id=191589

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Implement the collect transceiver algorithm using libwebrtc backend.
Call this algorithm everytime transceivers are retrieved from JS.
For Plan B, make this a no-op as this is not supported.
Introduce senders/receivers/transceivers getters where we just look at already created transceivers.

Covered by existing and rebased tests.

  • Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::collectTransceivers):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getSenders const):
(WebCore::RTCPeerConnection::getReceivers const):
(WebCore::RTCPeerConnection::getTransceivers const):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::collectTransceivers):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::existingTransceiver):
(WebCore::LibWebRTCPeerConnectionBackend::collectTransceivers):
(WebCore::LibWebRTCPeerConnectionBackend::applyRotationForOutgoingVideoSources):
(WebCore::LibWebRTCPeerConnectionBackend::shouldOfferAllowToReceive const):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
2:46 PM Changeset in webkit [238149] by Alan Coon
  • 4 edits in branches/safari-606-branch/Source

Apply patch. rdar://problem/45996792

2:46 PM Changeset in webkit [238148] by Alan Coon
  • 8 edits
    2 adds in branches/safari-606-branch

Cherry-pick r237837. rdar://problem/45996796

[MediaStream] An audio track should be muted when capture is interrupted by the OS.
Source/WebCore:

​https://bugs.webkit.org/show_bug.cgi?id= 191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

Test: fast/mediastream/media-stream-track-interrupted.html

  • platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::setInterruptedForTesting):
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::beginInterruption): (WebCore::CoreAudioCaptureSource::endInterruption):
  • testing/Internals.cpp: (WebCore::Internals::setMediaStreamSourceInterrupted):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

​https://bugs.webkit.org/show_bug.cgi?id=191283

<rdar://problem/45773103>

Patch by Eric Carlson <​eric.carlson@apple.com> on 2018-11-05
Reviewed by Jon Lee.

  • fast/mediastream/media-stream-track-interrupted-expected.txt: Added.
  • fast/mediastream/media-stream-track-interrupted.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@237837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:35 PM Changeset in webkit [238147] by Ross Kirsling
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

  • platform/wincairo/TestExpectations:
2:30 PM Changeset in webkit [238146] by Wenson Hsieh
  • 19 edits
    10 adds in trunk

[iOS] Do not show selection UI for editable elements with opacity near zero
​https://bugs.webkit.org/show_bug.cgi?id=191442
<rdar://problem/45958625>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: editing/selection/ios/do-not-zoom-to-focused-hidden-contenteditable.html

editing/selection/ios/hide-selection-after-hiding-contenteditable.html
editing/selection/ios/hide-selection-in-contenteditable-nested-transparency.html
editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html
editing/selection/ios/hide-selection-in-hidden-contenteditable.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isTransparentRespectingParentFrames const):

Add a helper function to determine whether a RenderObject is contained within a transparent layer, taking parent
frames into account. A layer is considered transparent if its opacity is less than a small threshold (i.e. 0.01).
Opacity on ancestor elements is applied multiplicatively.

  • rendering/RenderObject.h:

Source/WebKit:

Add support for suppressing native selection UI (for instance, selection highlight views, selection handles, and
selection-related gestures) when the selection is inside a transparent editable element. This helps maintain
compatibility with text editors that work by capturing key events and input events hidden contenteditable
elements, and reflect these changes in different document or different part of the document.

Since selection UI is rendered in the UI process on iOS using element geometry propagated from the web process,
selection rendering is entirely decoupled from the process of painting in the web process. This means that if
the editable root has an opacity of 0, we would correctly hide the caret and selection on macOS, but draw over
the transparent element on iOS. When these hidden editable elements are focused, this often results in unwanted
behaviors, such as double caret painting, native and custom selection UI from the page being drawn on top of one
another, and the ability to change selection via tap and loupe gestures within hidden text.

To fix this, we compute whether the focused element is transparent when an element is focused, or when the
selection changes, and send this information over to the UI process via AssistedNodeInformation and
EditorState. In the UI process, we then respect this information by suppressing the selection assistant if the
focused element is transparent; this disables showing and laying out selection views, as well as gestures
associated with selection overlays. However, this still allows for contextual autocorrection and spell checking.

  • Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode const):
(WebKit::AssistedNodeInformation::decode):

  • Shared/AssistedNodeInformation.h:
  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):

  • Shared/EditorState.h:

Add elementIsTransparent flags, and also add boilerplate IPC code.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):

Prevent zooming to the focused element if the focused element is hidden.

(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

Don't allow these text interaction gestures to begin while suppressing the selection assistant.

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

When an element is focused, begin suppressing the selection assistant if the element is fully transparent.

(-[WKContentView _stopAssistingNode]):

When the focused element is blurred, reset state by ending selection assistant suppression (additionally
reactivating the selection assistant if needed). This ensures that selection in non-editable text isn't broken
after focusing a hidden editable element.

(-[WKContentView _updateChangedSelection:]):

If needed, suppress or un-suppress the selection assistant when the selection changes. On certain rich text
editors, a combination of custom selection UI and native selection UI is used. For instance, on Microsoft Office
365, caret selections are rendered using the native caret view, but as soon as the selection becomes ranged, the
editable root becomes fully transparent, and Office's selection UI takes over.

(-[WKContentView _shouldSuppressSelectionCommands]):

Override this UIKit SPI hook to suppress selection commands (e.g. the callout bar) when suppressing the
selection assistant.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::getAssistedNodeInformation):

Compute and set elementIsTransparent using the assisted node.

Tools:

Add a couple of new testing helpers to UIScriptController.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::textSelectionRangeRects const):
(WTR::UIScriptController::selectionCaretViewRect const):
(WTR::UIScriptController::selectionRangeViewRects const):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::textSelectionRangeRects const):

Rename selectionRangeViewRects to textSelectionRangeRects. This allows us to draw a distinction between
textSelectionRangeRects/textSelectionCaretRect, which retrieve information about selection rects known
to the text interaction assistant, and selectionCaretViewRect/selectionRangeViewRects, which retrieve the
actual frames of the selection views used to draw overlaid selection UI. This difference is important in the
new layout tests added in this patch, which only suppress caret rendering (i.e. selection views remain hidden).

Also, drive-by fix a leaked NSMutableArray.

(WTR::UIScriptController::selectionStartGrabberViewRect const):
(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::selectionCaretViewRect const):
(WTR::UIScriptController::selectionRangeViewRects const):

Testing helpers to grab the frames of caret and selection views, in WKContentView's coordinate space. These
rects are also clamped to WKContentView bounds.

LayoutTests:

Add 5 new layout tests. See below for more details.

  • editing/selection/character-granularity-rect.html:

Adjust for a renamed UIScriptController function.

  • editing/selection/ios/do-not-zoom-to-focused-hidden-contenteditable-expected.txt: Added.
  • editing/selection/ios/do-not-zoom-to-focused-hidden-contenteditable.html: Added.

Add a test to verify that we don't zoom to fit the focused element, if the focused element is completely
transparent.

  • editing/selection/ios/hide-selection-after-hiding-contenteditable-expected.txt: Added.
  • editing/selection/ios/hide-selection-after-hiding-contenteditable.html: Added.

Add a test to verify that selection UI is hidden after making an editable root transparent, and shown again when
the editable root becomes opaque.

  • editing/selection/ios/hide-selection-in-contenteditable-nested-transparency-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-contenteditable-nested-transparency.html: Added.

Add a test to verify that transparency applied on an editable root via nested transparent containers causes
selection UI to be suppressed.

  • editing/selection/ios/hide-selection-in-hidden-contenteditable-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-hidden-contenteditable-frame-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-hidden-contenteditable-frame.html: Added.

Add a test to verify that selection UI is suppressed when an editable element inside a subframe is focused. This
test checks that the caret, selection rects and selection handle views are not shown, and additionally verifies
that the selection in a hidden contenteditable area cannot be changed via tap gesture.

  • editing/selection/ios/hide-selection-in-hidden-contenteditable.html: Added.

Same test as above, but in a regular editable element in the main document instead of a subframe.

  • resources/ui-helper.js:

(window.UIHelper.getUISelectionRects.return.new.Promise.):
(window.UIHelper.getUISelectionRects.return.new.Promise):
(window.UIHelper.getUISelectionRects):
(window.UIHelper.getUICaretViewRect.return.new.Promise.):
(window.UIHelper.getUICaretViewRect.return.new.Promise):
(window.UIHelper.getUICaretViewRect):

Add new UIHelper wrapper methods. See Tools/ChangeLog for more detail.

2:21 PM Changeset in webkit [238145] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[MediaStream] Observer AVCaptureDevice "suspended" property
​https://bugs.webkit.org/show_bug.cgi?id=191587
<rdar://problem/46030598>

Reviewed by Youenn Fablet.

No new tests, AVCapture can only be tested manually.

  • platform/mediastream/mac/AVCaptureDeviceManager.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::captureDevicesInternal): Don't notify of devices "changes"
the first time the device list is scanned.
(WebCore::deviceIsAvailable): Don't check for "isInUseByAnotherApplication", it doesn't
change device availability.
(WebCore::AVCaptureDeviceManager::beginObservingDevices): New, observe "suspended" on all
devices and add them to the cached list.
(WebCore::AVCaptureDeviceManager::stopObservingDevices): New, opposite of above.
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices): Watch for changes in the list of
devices.
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager): Stop observing all cached devices.
(WebCore::AVCaptureDeviceManager::registerForDeviceNotifications):
(-[WebCoreAVCaptureDeviceManagerObserver disconnect]):
(-[WebCoreAVCaptureDeviceManagerObserver deviceConnectedDidChange:]):
(-[WebCoreAVCaptureDeviceManagerObserver observeValueForKeyPath:ofObject:change:context:]):
(WebCore::AVCaptureDeviceManager::refreshAVCaptureDevicesOfType): Deleted.
(WebCore::AVCaptureDeviceManager::deviceConnected): Deleted.
(WebCore::AVCaptureDeviceManager::deviceDisconnected): Deleted.
(-[WebCoreAVCaptureDeviceManagerObserver deviceDisconnected:]): Deleted.
(-[WebCoreAVCaptureDeviceManagerObserver deviceConnected:]): Deleted.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource): Stop observing "running" (not "rate")
and "suspended".
(WebCore::AVVideoCaptureSource::setupSession): Observe "running" (not "rate"), and "suspended".
(WebCore::AVVideoCaptureSource::captureDeviceSuspendedDidChange):
(-[WebCoreAVVideoCaptureSourceObserver observeValueForKeyPath:ofObject:change:context:]):

2:06 PM Changeset in webkit [238144] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION(r238122): fetching the CertificateInfo triggers an ASSERT in workers
​https://bugs.webkit.org/show_bug.cgi?id=191597

Reviewed by Joseph Pecoraro.

When WebInspector is open, the CertificateInfo for every ResourceResponse is now fetched,
meaning that we may try to fetch in situations previously unexpected.

  • platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

1:33 PM Changeset in webkit [238143] by mark.lam@apple.com
  • 8 edits
    1 add in trunk

Add OOM detection to StringPrototype's substituteBackreferences().
​https://bugs.webkit.org/show_bug.cgi?id=191563
<rdar://problem/45720428>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-191563.js: Added.

Source/JavaScriptCore:

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferencesInline):
(JSC::substituteBackreferences):
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):

  • runtime/StringPrototype.h:

Source/WTF:

Enhanced StringBuilder::toString() to skip the shrinkToFit(), reifyString(), and
the hasOverflowed() check if m_string is not null. When m_string is not null,
the StringBuilder either only has a single String in m_string (with m_buffer being
null), or reifyString() has already been called (resulting in a non-null m_string
with a possibly non-null m_buffer).

We can skip the overflow check because:

  1. if the StringBuilder only has a single String, then there cannot be an overflow.
  2. if reifyString() has already been called, then the hasOverflowed() checked has already been done because every code path that calls reifyString() first does the hasOverflowed() check.

We can skip shrinkToFit() because it only applies to m_buffer.

  1. if the StringBuilder only has a single String, then there's no m_buffer to shrink.
  2. if reifyString() has already been called, then we either came down
    1. the toString() path with a null m_string previously, where we would have already called shrinkToFit() before reifyString(), or
    2. the toStringPreserveCapacity() path where we don't want to shrinkToFit().

We can skip reifyString() because:

  1. if the StringBuilder only has a single String, then the string is already reified.
  2. if reifyString() has been already called, then the string is already reified.

Note that if m_string is the null string and m_buffer is null, reifyString() will
replace it with the empty string. For this reason, we cannot solely check for
!m_buffer because we need to reify the null string into the empty string.

Note also that if m_string is null and m_buffer is non-null, reifyString() will
create a String and set m_string to it. However, m_buffer remains non-null.
For this reason, we cannot assert !m_buffer alone when m_string is non-null.
We add a m_isReified flag (only when assertions are enabled) to track the reified
case where both m_buffer and m_string are non-null.

  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reifyString const):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::toString):

1:04 PM Changeset in webkit [238142] by Ryan Haddad
  • 3 edits in trunk/Source/WebKit

Unreviewed, rolling out r238137.

Introduced API test failures on macOS.

Reverted changeset:

"Enable process swap on cross-site navigation by default on
macOS"
​https://bugs.webkit.org/show_bug.cgi?id=191572
​https://trac.webkit.org/changeset/238137

12:48 PM Changeset in webkit [238141] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

LLIntSlowPath's llint_loop_osr and llint_replace should set the topCallFrame.
​https://bugs.webkit.org/show_bug.cgi?id=191579
<rdar://problem/45942472>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-191579.js: Added.

Source/JavaScriptCore:

Both of these functions do a lot of work. It would be good for the topCallFrame
to be correct should we need to throw an exception.

For example, we've observed the following crash trace:

  • frame #0: WTFCrash() at Assertions.cpp:253 frame #1: ... frame #2: JSC::StructureIDTable::get(this=0x00006040000162f0, structureID=1874583248) at StructureIDTable.h:129 frame #3: JSC::VM::getStructure(this=0x0000604000016210, id=4022066896) at VM.h:705 frame #4: JSC::JSCell::structure(this=0x00007ffeefbbde30, vm=0x0000604000016210) const at JSCellInlines.h:125 frame #5: JSC::JSCell::classInfo(this=0x00007ffeefbbde30, vm=0x0000604000016210) const at JSCellInlines.h:335 frame #6: JSC::JSCell::inherits(this=0x00007ffeefbbde30, vm=0x0000604000016210, info=0x0000000105eaf020) const at JSCellInlines.h:302 frame #7: JSC::JSObject* JSC::jsCast<JSC::JSObject*, JSC::JSCell>(from=0x00007ffeefbbde30) at JSCast.h:36 frame #8: JSC::asObject(cell=0x00007ffeefbbde30) at JSObject.h:1299 frame #9: JSC::asObject(value=JSValue @ 0x00007ffeefbba380) at JSObject.h:1304 frame #10: JSC::Register::object(this=0x00007ffeefbbdd58) const at JSObject.h:1514 frame #11: JSC::ExecState::jsCallee(this=0x00007ffeefbbdd40) const at CallFrame.h:107 frame #12: JSC::ExecState::isStackOverflowFrame(this=0x00007ffeefbbdd40) const at CallFrameInlines.h:36 frame #13: JSC::StackVisitor::StackVisitor(this=0x00007ffeefbba860, startFrame=0x00007ffeefbbdd40, vm=0x0000631000000800) at StackVisitor.cpp:52 frame #14: JSC::StackVisitor::StackVisitor(this=0x00007ffeefbba860, startFrame=0x00007ffeefbbdd40, vm=0x0000631000000800) at StackVisitor.cpp:41 frame #15: void JSC::StackVisitor::visit<(JSC::StackVisitor::EmptyEntryFrameAction)0, JSC::Interpreter::getStackTrace(JSC::JSCell*, WTF::Vector<JSC::StackFrame, 0ul, WTF::CrashOnOverflow, 16ul>&, unsigned long, unsigned long)::$_3>(startFrame=0x00007ffeefbbdd40, vm=0x0000631000000800, functor=0x00007ffeefbbaa60)::$_3 const&) at StackVisitor.h:147 frame #16: JSC::Interpreter::getStackTrace(this=0x0000602000005db0, owner=0x000062d00020cbe0, results=0x00006020000249d0, framesToSkip=0, maxStackSize=1) at Interpreter.cpp:437 frame #17: JSC::getStackTrace(exec=0x000062d00002c048, vm=0x0000631000000800, obj=0x000062d00020cbe0, useCurrentFrame=true) at Error.cpp:170 frame #18: JSC::ErrorInstance::finishCreation(this=0x000062d00020cbe0, exec=0x000062d00002c048, vm=0x0000631000000800, message=0x00007ffeefbbb800, useCurrentFrame=true) at ErrorInstance.cpp:119 frame #19: JSC::ErrorInstance::create(exec=0x000062d00002c048, vm=0x0000631000000800, structure=0x000062d0000f5730, message=0x00007ffeefbbb800, appender=0x0000000000000000, type=TypeNothing, useCurrentFrame=true)(WTF::String const&, WTF::String const&, JSC::RuntimeType, JSC::ErrorInstance::SourceTextWhereErrorOccurred), JSC::RuntimeType, bool) at ErrorInstance.h:49 frame #20: JSC::createRangeError(exec=0x000062d00002c048, globalObject=0x000062d00002c000, message=0x00007ffeefbbb800, appender=0x0000000000000000)(WTF::String const&, WTF::String const&, JSC::RuntimeType, JSC::ErrorInstance::SourceTextWhereErrorOccurred)) at Error.cpp:68 frame #21: JSC::createRangeError(exec=0x000062d00002c048, globalObject=0x000062d00002c000, message=0x00007ffeefbbb800) at Error.cpp:316 frame #22: JSC::createStackOverflowError(exec=0x000062d00002c048, globalObject=0x000062d00002c000) at ExceptionHelpers.cpp:77 frame #23: JSC::createStackOverflowError(exec=0x000062d00002c048) at ExceptionHelpers.cpp:72 frame #24: JSC::throwStackOverflowError(exec=0x000062d00002c048, scope=0x00007ffeefbbbaa0) at ExceptionHelpers.cpp:335 frame #25: JSC::ProxyObject::getOwnPropertySlotCommon(this=0x000062d000200e40, exec=0x000062d00002c048, propertyName=PropertyName @ 0x00007ffeefbbba80, slot=0x00007ffeefbbc720) at ProxyObject.cpp:372 frame #26: JSC::ProxyObject::getOwnPropertySlot(object=0x000062d000200e40, exec=0x000062d00002c048, propertyName=PropertyName @ 0x00007ffeefbbbd40, slot=0x00007ffeefbbc720) at ProxyObject.cpp:395 frame #27: JSC::JSObject::getNonIndexPropertySlot(this=0x000062d000200e40, exec=0x000062d00002c048, propertyName=PropertyName @ 0x00007ffeefbbbea0, slot=0x00007ffeefbbc720) at JSObjectInlines.h:150 frame #28: bool JSC::JSObject::getPropertySlot<false>(this=0x000062d000200e40, exec=0x000062d00002c048, propertyName=PropertyName @ 0x00007ffeefbbc320, slot=0x00007ffeefbbc720) at JSObject.h:1424 frame #29: JSC::JSObject::calculatedClassName(object=0x000062d000200e40) at JSObject.cpp:535 frame #30: JSC::Structure::toStructureShape(this=0x000062d000007410, value=JSValue @ 0x00007ffeefbbcae0, sawPolyProtoStructure=0x00007ffeefbbcf60) at Structure.cpp:1142 frame #31: JSC::TypeProfilerLog::processLogEntries(this=0x000060400000a950, reason=0x00007ffeefbbd5c0) at TypeProfilerLog.cpp:89 frame #32: JSC::JIT::doMainThreadPreparationBeforeCompile(this=0x0000619000034da0) at JIT.cpp:951 frame #33: JSC::JITWorklist::Plan::Plan(this=0x0000619000034d80, codeBlock=0x000062d0001d88c0, loopOSREntryBytecodeOffset=0) at JITWorklist.cpp:43 frame #34: JSC::JITWorklist::Plan::Plan(this=0x0000619000034d80, codeBlock=0x000062d0001d88c0, loopOSREntryBytecodeOffset=0) at JITWorklist.cpp:42 frame #35: JSC::JITWorklist::compileLater(this=0x0000616000001b80, codeBlock=0x000062d0001d88c0, loopOSREntryBytecodeOffset=0) at JITWorklist.cpp:256 frame #36: JSC::LLInt::jitCompileAndSetHeuristics(codeBlock=0x000062d0001d88c0, exec=0x00007ffeefbbde30, loopOSREntryBytecodeOffset=0) at LLIntSlowPaths.cpp:391 frame #37: llint_replace(exec=0x00007ffeefbbde30, pc=0x00006040000161ba) at LLIntSlowPaths.cpp:516 frame #38: llint_entry at LowLevelInterpreter64.asm:98 frame #39: vmEntryToJavaScript at LowLevelInterpreter64.asm:296 ...

This crash occurred because StackVisitor was seeing an invalid topCallFrame while
trying to capture the Error stack while throwing a StackOverflowError below
llint_replace. While in this specific example, it is questionable whether we
should be executing JS code below TypeProfilerLog::processLogEntries(), it is
correct to have set the topCallFrame in llint_replace. We do this by calling
LLINT_BEGIN_NO_SET_PC() at the top of llint_replace.

We also do the same for llint_osr.

Note: both of these LLInt slow path functions are called with a fully initialized
CallFrame. Hence, there's no issue with setting topCallFrame to their CallFrames
for these functions.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

12:44 PM Changeset in webkit [238140] by Matt Baker
  • 5 edits in trunk

Web Inspector: Table should support select all (Cmd-A)
​https://bugs.webkit.org/show_bug.cgi?id=190299
<rdar://problem/45029170>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

  • UserInterface/Views/Table.js:

(WI.Table.prototype.selectAll):
(WI.Table.prototype._handleKeyDown):

LayoutTests:

  • inspector/table/table-selection-expected.txt:
  • inspector/table/table-selection.html:

Add tests that selectAll works when multiple selection is enabled,
and does nothing when multiple selection is disabled.

11:41 AM Changeset in webkit [238139] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Table with no selection should select the first/last row on down/up arrow key
​https://bugs.webkit.org/show_bug.cgi?id=190100
<rdar://problem/44879243>

Reviewed by Devin Rousso.

Pressing the up or down arrow key when nothing is selected should select
the last or first row, respectively. After selecting the row make sure
it is visible by calling the new Table method revealRow.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.revealRow):
(WI.Table.prototype._handleKeyDown):
(WI.Table.prototype._selectRowsFromArrowKey):

10:44 AM Changeset in webkit [238138] by timothy@apple.com
  • 4 edits
    2 adds in trunk

Treat supported-color-schemes as the second highest priority property.
​https://bugs.webkit.org/show_bug.cgi?id=191556
rdar://problem/46000076

Reviewed by Dean Jackson.

Source/WebCore:

Test: css-dark-mode/supported-color-schemes-priority.html

  • css/CSSProperties.json: Make supported-color-schemes high-priority and add a comment.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyMatchedProperties): Manually handle supported-color-schemes
after -webkit-ruby-position, before other properties, so it can affect resolved colors.

LayoutTests:

  • css-dark-mode/supported-color-schemes-priority-expected.txt: Added.
  • css-dark-mode/supported-color-schemes-priority.html: Added.
10:43 AM Changeset in webkit [238137] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit

Enable process swap on cross-site navigation by default on macOS
​https://bugs.webkit.org/show_bug.cgi?id=191572

Reviewed by Chris Dumez.

Enabled the feature by default on macOS.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
10:43 AM Changeset in webkit [238136] by youenn@apple.com
  • 58 edits
    1 copy
    1 move
    5 adds
    29 deletes in trunk/LayoutTests

Refresh WPT webrtc tests to ToT
​https://bugs.webkit.org/show_bug.cgi?id=191564

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Also remove QUIC specific tests that are not related to webrtc-pc.

  • resources/import-expectations.json:
  • web-platform-tests/webrtc: refreshed.

LayoutTests:

Refresh webrtc tests

  • tests-options.json:
10:40 AM Changeset in webkit [238135] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Command-A should select all properties
​https://bugs.webkit.org/show_bug.cgi?id=191435
<rdar://problem/45921373>

Reviewed by Devin Rousso.

When focused on a style property, Command-A on Mac (Control-A on other platforms)
should select all properties of the style rule.

  • UserInterface/Base/Utilities.js:
  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

9:35 AM Changeset in webkit [238134] by dbates@webkit.org
  • 15 edits
    1 delete in trunk

Consolidate WebKit UIKitSPI.h and UIKitTestSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=173341
<rdar://problem/32752890>

Reviewed by Simon Fraser.

Source/WebKit:

  • Platform/spi/ios/UIKitSPI.h:

Tools:

There is little value to making a distinction between forward declarations
of UIKit SPI needed in the WebKit layer and just for testing. Moreover,
the contents of these two headers can conflict with each other following
r218275 as DumpRenderTree includes both headers. Instead we should remove
UIKitTestSPI.h and have WebKitTestRunner include the WebKit variant, UIKitSPI.h.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • TestRunnerShared/spi/UIKitTestSPI.h: Removed.
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  • WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.mm:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • WebKitTestRunner/ios/TestControllerIOS.mm:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:
  • WebKitTestRunner/ios/mainIOS.mm:
9:16 AM Changeset in webkit [238133] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix internal builds after r238115
​https://bugs.webkit.org/show_bug.cgi?id=191441

  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingTextView intrinsicContentSize]):
Some iOS-like operating systems don't have safe browsing. Don't use symbols that don't exist on those systems.

7:46 AM Changeset in webkit [238132] by Caio Lima
  • 9 edits
    1 add in trunk

[BigInt] JSBigInt::createWithLength should throw when length is greater than JSBigInt::maxLength
​https://bugs.webkit.org/show_bug.cgi?id=190836

Reviewed by Saam Barati.

JSTests:

  • stress/big-int-out-of-memory-tests.js: Added.

Source/JavaScriptCore:

In this patch we are creating a new method called JSBigInt::createWithLengthUnchecked
where we allocate a BigInt trusting the length received as argument.
With this additional method, we now check if length passed to
JSBigInt::createWithLength is not greater than JSBigInt::maxLength.
When the length is greater than maxLength, we then throw OOM
exception.
This required change the interface of some JSBigInt operations to
receive ExecState* instead of VM&. We changed only operations that
can throw because of OOM.
We beleive that this approach of throwing instead of finishing the
execution abruptly is better because JS programs can catch such
exception and handle this issue properly.

  • dfg/DFGOperations.cpp:
  • jit/JITOperations.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::createZero):
(JSC::JSBigInt::tryCreateWithLength):
(JSC::JSBigInt::createWithLengthUnchecked):
(JSC::JSBigInt::createFrom):
(JSC::JSBigInt::multiply):
(JSC::JSBigInt::divide):
(JSC::JSBigInt::copy):
(JSC::JSBigInt::unaryMinus):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::add):
(JSC::JSBigInt::sub):
(JSC::JSBigInt::bitwiseAnd):
(JSC::JSBigInt::bitwiseOr):
(JSC::JSBigInt::bitwiseXor):
(JSC::JSBigInt::absoluteAdd):
(JSC::JSBigInt::absoluteSub):
(JSC::JSBigInt::absoluteDivWithDigitDivisor):
(JSC::JSBigInt::absoluteDivWithBigIntDivisor):
(JSC::JSBigInt::absoluteLeftShiftAlwaysCopy):
(JSC::JSBigInt::absoluteBitwiseOp):
(JSC::JSBigInt::absoluteAddOne):
(JSC::JSBigInt::absoluteSubOne):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::rightTrim):
(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::createWithLength): Deleted.

  • runtime/JSBigInt.h:
  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):

6:45 AM Changeset in webkit [238131] by cturner@igalia.com
  • 7 edits in trunk/Source/WebCore

[EME][GStreamer] Make CDMInstance's available in decryptors, and factor out some EME utility classes.
​https://bugs.webkit.org/show_bug.cgi?id=191316

Reviewed by Xabier Rodriguez-Calvar.

Another preparation in patch getting ready to move the decryption
logic behind the CDMInstance and out of the GStreamer decryptors
themselves. The first step taken here is to arrange for the
instances to always be available in the decryptors when they need
to decrypt content.

In doing so, there were a number of hairy bits of code that could
use some abstraction, so the opportunity was taken to do that as
well.

Covered by tests in media/encrypted-media and
imported/w3c/web-platform-tests/encrypted-media.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Remove
drm-key-needed since it was not being used anywhere.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Factor out the parsing of decryption system information from
GStreamer, since it was not clear what that code was doing unless
you squinted pretty hard. Also remove the duplicated
initialization-data-encountered posting.
(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
Refactored to make it a more general method and usable in more
situations. It now has an optional to stop it from eliding init
datas for a different key system. This is required the first time
we post them, since if a CDM instance has already been set, and if
the stream init datas are for different systems, we ended up never
posting an encrypted event.
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithLocalInstance):
Actually send a CDMInstance now when in regular playback mode.
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchDecryptionKey):
Remove m_needToSendCredentials, it was not being used.
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):
Refactored to use the new initializationDataEncountered.
(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey):
Log the waiting state, since it was currently not clear what that
logging message was even telling you!
(WebCore::extractEventsAndSystemsFromMessage): Deleted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData): New class that encapsulates both
single instantiation and streaming instantiation.
(WebCore::InitData::append): Used for the streaming mode, when you
are concatenating init datas together.
(WebCore::InitData::payload const):
(WebCore::InitData::systemId const):
(WebCore::InitData::payloadContainerType const):
(WebCore::InitData::isFromDifferentContainer):
(WebCore::ProtectionSystemEvents::ProtectionSystemEvents):
(WebCore::ProtectionSystemEvents::events const):
(WebCore::ProtectionSystemEvents::availableSystems const):

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptTransformInPlace): If you post
waiting-for-key after requesting a CDM instance, it will flap back
to not waiting for a key almost immediately, didn't make sense
positing after requesting an instance. Also post key-received when
we receive the key.
(webkitMediaCommonEncryptionDecryptSinkEventHandler): It has now
been arranged that a CDMInstance will always be present in an OOB
message, so parse it out here.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):
As above, make sure when posting the OOB that a CDMInstance is present.

6:35 AM Changeset in webkit [238130] by cturner@igalia.com
  • 4 edits in trunk/Source/WebCore

Various compiler warnings/errors fixes.
​https://bugs.webkit.org/show_bug.cgi?id=191583

Reviewed by Frédéric Wang.

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::clearObjectStore):
ASSERT is only compiled in DEBUG mode, so guarding with
!LOG_DISABLED is wrong.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
showPaintOrderTree is only compiled in ENABLE(TREE_DEBUGGING)
mode, so guarding with !LOG_DISABLED was wrong.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Ditto, this time with member .depth.
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree): Ditto.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::styleChanged): Add another unused
parameter.

5:07 AM Changeset in webkit [238129] by ajuma@chromium.org
  • 2 edits in trunk/Source/WebKit

Turn Intersection Observer on by default
​https://bugs.webkit.org/show_bug.cgi?id=191569

Reviewed by Simon Fraser.

  • Shared/WebPreferences.yaml:
4:28 AM WebKitGTK/2.22.x edited by cadubentzen@gmail.com
(diff)
4:27 AM WebKitGTK/2.22.x edited by cadubentzen@gmail.com
(diff)
2:22 AM Changeset in webkit [238128] by graouts@webkit.org
  • 10 edits
    2 adds in trunk

[Web Animations] Don't schedule animation frames or update style while an accelerated animation is running
​https://bugs.webkit.org/show_bug.cgi?id=191542
<rdar://problem/45356027>

Reviewed by Simon Fraser.

Source/WebCore:

Test: animations/no-style-recalc-during-accelerated-animation.html

In order to be more power-efficient, we stop scheduling calls to updateAnimationsAndSendEvents() when running only accelerated
animations. To do that, we prevent scheduling further animation resolution if we're in the process of updating animations, and
when we are done, call the new DocumentTimeline::scheduleNextTick() method that will check whether we have only accelerated
animations running, and in that case check which of those animations needs an update the soonest and starts a timer scheduled
for that time when we'll schedule animation resolution.

By default, animations compute the time until their natural completion but in the case of CSS Animations, we want to make sure
we also update animations in-flight to dispatch "animationiteration" events.

  • animation/AnimationEffect.h: Make the simpleIterationProgress() public so it can be called by WebAnimation::timeToNextTick().
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline): Create the m_tickScheduleTimer and set it up to call scheduleAnimationResolutionIfNeeded().
(WebCore::DocumentTimeline::suspendAnimations): If we don't already have a cached current time, cache the current time.
(WebCore::DocumentTimeline::resumeAnimations): Reset the cached current time to ensure we'll get a fresh one when updating animations next.
(WebCore::DocumentTimeline::liveCurrentTime const): Factor the code to compute the current time out of currentTime() so that we can
cache the current time in suspendAnimations() without also automatically clearing the current time.
(WebCore::DocumentTimeline::currentTime): Use liveCurrentTime() and cacheCurrentTime() since much of the code from this function has been
factored out into those. Additionally, we were failing to clear the current time if called inside an animation frame, which we now do correctly
by virtue of using cacheCurrentTime(). This fixes some flakiness.
(WebCore::DocumentTimeline::cacheCurrentTime): Factor the code to cache the current time out of currentTime().
(WebCore::DocumentTimeline::maybeClearCachedCurrentTime): No need to clear the current time if we get suspended.
(WebCore::DocumentTimeline::scheduleAnimationResolutionIfNeeded): Prevent scheduling an animation update if we're in the middle of one already,
scheduleNextTick() will be called after animations are updated to see if we should schedule an animation update instead.
(WebCore::DocumentTimeline::unscheduleAnimationResolution): Cancel the m_tickScheduleTimer if we need to unschedule animation resolution.
(WebCore::DocumentTimeline::animationResolutionTimerFired): Factor the call to applyPendingAcceleratedAnimations() out of updateAnimationsAndSendEvents()
and call scheduleNextTick().
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Set the new m_isUpdatingAnimations member variable to true while this function is running.
(WebCore::DocumentTimeline::scheduleNextTick): Schedule an animation update immediately if we have any relevant animation that is not accelerated.
Otherwise, iterate through all animations to figure out the earliest moment at which we need to update animations.
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement): Use the new WebAnimation::isRunningAccelerated() function.

  • animation/DocumentTimeline.h:
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::isRunningAccelerated const): Since we end up checking if an animation is running with an accelerated effect, we introduce a new
function to get that information directly through the WebAnimation object without bothering about its effect.
(WebCore::WebAnimation::resolve): We should only call updateFinishedState() here since timingDidChange() would also notify the timeline about a potential
change in relevance, which is not necessary and which would schedule an animation frame even for animations that are accelerated.
(WebCore::WebAnimation::timeToNextTick const): Compute the time until our animation completion or, in the case of CSS animations, the next iteration.

  • animation/WebAnimation.h:

LayoutTests:

Add a test that checks that we make only minimal style updates and still dispatch events while an accelerated animation is running.

  • animations/no-style-recalc-during-accelerated-animation-expected.txt: Added.
  • animations/no-style-recalc-during-accelerated-animation.html: Added.
  • fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html:
  • fast/layers/no-clipping-overflow-hidden-added-after-transform.html: Change the colors to avoid a tiny ImageOnlyFailure.
  • platform/win/TestExpectations: Mark some regressions tracked by webkit.org/b/191584.
2:05 AM Changeset in webkit [238127] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove WebKitTestRunnerLib's build warnings.
​https://bugs.webkit.org/show_bug.cgi?id=191580

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2018-11-13
Reviewed by Fujii Hironori.

Include cmakeconfig.h in precompiled header.

  • WebKitTestRunner/WebKitTestRunnerPrefix.h:
12:58 AM Changeset in webkit [238126] by magomez@igalia.com
  • 3 edits in trunk/Source/WebCore

[GTK][WPE] Incorrect tile coverage when resizing a layer out of the visible area
​https://bugs.webkit.org/show_bug.cgi?id=191545

Reviewed by Žan Doberšek.

Keep track of layer size changes even if they happen when the layer is not in the visible
area, so we can update edge tiles when the layer gets visible.

  • platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/texmap/coordinated/TiledBackingStore.h:

Nov 12, 2018:

11:41 PM Changeset in webkit [238125] by commit-queue@webkit.org
  • 9 edits in trunk

Implement Cache API support for WPE/GTK
​https://bugs.webkit.org/show_bug.cgi?id=178316

Patch by Darshan Kadu <​darsh7807@gmail.com> on 2018-11-12
Reviewed by Michael Catanzaro.

Source/WebKit:

Added a new API function WKWebsiteDataStoreSetCacheStoragePerOriginQuota which sets the
cache limit per origin.

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetCacheStoragePerOriginQuota):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Called WKWebsiteDataStoreSetCacheStoragePerOriginQuota function to set the cache limit to 400 * 1200
on all the platforms in TestController.cpp. Also, removed the setCacheStoragePerOriginQuota call from TestControllerCocoa.mm

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

LayoutTests:

Removed the http/wpt/cache-storage/cache-quota.any.html from the TestExpectations which
were marked faliure.

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
11:35 PM Changeset in webkit [238124] by commit-queue@webkit.org
  • 9 edits in trunk

Content-Type parameter values should allow empty quoted strings
​https://bugs.webkit.org/show_bug.cgi?id=191388

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-12
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Include improved expected test result and updated mime-type test:
​https://github.com/whatwg/mimesniff/pull/79

  • web-platform-tests/mimesniff/mime-types/charset-parameter.window-expected.txt:
  • web-platform-tests/mimesniff/mime-types/parsing.any-expected.txt:
  • web-platform-tests/mimesniff/mime-types/parsing.any.worker-expected.txt:
  • web-platform-tests/mimesniff/mime-types/resources/mime-types.json:
  • web-platform-tests/xhr/overridemimetype-blob-expected.txt:

Source/WebCore:

According to RFC 2045 and ​https://mimesniff.spec.whatwg.org/#parsing-a-mime-type empty
quoted strings are acceptable for Content-Type parameter values. They
are accepted by Firefox and Chrome implementations as well.

Test: web-platform-tests/xhr/overridemimetype-blob.html

  • platform/network/ParsedContentType.cpp:

(WebCore::parseToken):
(WebCore::parseQuotedString):
(WebCore::parseContentType):

  • platform/network/ParsedContentType.h:
11:21 PM Changeset in webkit [238123] by chris.reid@sony.com
  • 7 edits in trunk

[Curl] Reject entire cookie if the domain fails a tailmatch.
​https://bugs.webkit.org/show_bug.cgi?id=191406

Reviewed by Youenn Fablet.

Source/WebCore:

Currently we don't put domain attribute of cookie when it fails a tailmatch. As Firefox
and Chrome do, we are going to reject the entire cookie if the domain fails a tailmatch instead.
Also cleanup Cookie database implementation to make them testable better.

Tests: TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp

  • platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::canAcceptCookie): Added.
(WebCore::CookieJarDB::setCookie):

  • platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieAttributes):
(WebCore::CookieUtil::parseCookieHeader):

  • platform/network/curl/CookieUtil.h:

Tools:

Added unittests for Curl cookie implementation.

  • TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:

(TestWebKitAPI::Curl::CurlCookies::RejectTailmatchFailureDomain):

11:07 PM Changeset in webkit [238122] by Devin Rousso
  • 36 edits
    3 copies
    3 moves
    4 adds in trunk

Web Inspector: Network: show secure certificate details per-request
​https://bugs.webkit.org/show_bug.cgi?id=191447
<rdar://problem/30019476>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add Security domain to hold security related protocol types.

  • CMakeLists.txt:
  • DerivedSources.make:
  • inspector/protocol/Network.json:
  • inspector/protocol/Security.json: Added.
  • inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator):

Source/WebCore:

Test: http/tests/inspector/network/resource-response-security.html

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::shouldIncludeCertificateInfo const):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::shouldIncludeCertificateInfo const): Added.
Always save certificate information when WebInspector is open.

  • platform/network/CertificateInfoBase.h: Added.

(WebCore::CertificateInfoBase::containsNonRootSHA1SignedCertificate const):
(WebCore::CertificateInfoBase::summaryInfo const):
(WebCore::CertificateInfoBase::isEmpty const):

  • platform/network/cf/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.

  • platform/network/cf/CertificateInfoCFNet.cpp: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):
(WebCore::CertificateInfo::summaryInfo const): Added.

  • platform/network/curl/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.
(WebCore::CertificateInfo::isEmpty const): Added.

  • platform/network/soup/CertificateInfo.h:

(WebCore::CertificateInfo::summaryInfo const): Added.
(WebCore::CertificateInfo::isEmpty const): Added.
Create base class for CertificateInfo so that InspectorNetworkAgent doesn't need to have
platform-specific code in its implementation.

  • platform/network/cocoa/CertificateInfoCocoa.mm: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.
  • platform/network/curl/CertificateInfoCFNet.cpp: Renamed from Source/WebCore/platform/network/curl/CertificateInfo.cpp.
  • platform/network/soup/CertificateInfoSoup.cpp: Renamed from Source/WebCore/platform/network/soup/CertificateInfo.cpp.
  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::certificateInfo const): Added.
(WebCore::NetworkResourcesData::ResourceData::setCertificateInfo): Added.

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):

  • PlatformAppleWin.cmake:
  • PlatformMac.cmake:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Curl.cmake:
  • platform/SourcesSoup.txt:

Source/WebInspectorUI:

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.resourceRequestWasServedFromMemoryCache):
(WI.NetworkManager.prototype.resourceRequestDidReceiveResponse):

  • UserInterface/Models/Resource.js:

(WI.Resource.prototype.get responseSecurity): Added.
(WI.Resource.prototype.get loadedSecurely): Added.
(WI.Resource.prototype.updateForResponse):

  • UserInterface/Views/NetworkResourceDetailView.js:

(WI.NetworkResourceDetailView):
(WI.NetworkResourceDetailView.prototype.initialLayout):
(WI.NetworkResourceDetailView.prototype.showContentViewForIdentifier):

  • UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details .go-to-arrow): Added.
(.content-view.resource-details.showing-find-banner .search-highlight): Added.

  • UserInterface/Views/ResourceSecurityContentView.js: Added.

(WI.ResourceSecurityContentView):
(WI.ResourceSecurityContentView.prototype.initialLayout):
(WI.ResourceSecurityContentView.prototype.layout):
(WI.ResourceSecurityContentView.prototype.closed):
(WI.ResourceSecurityContentView.prototype.get supportsSearch):
(WI.ResourceSecurityContentView.prototype.get numberOfSearchResults):
(WI.ResourceSecurityContentView.prototype.get hasPerformedSearch):
(WI.ResourceSecurityContentView.prototype.set automaticallyRevealFirstSearchResult):
(WI.ResourceSecurityContentView.prototype.performSearch):
(WI.ResourceSecurityContentView.prototype.searchCleared):
(WI.ResourceSecurityContentView.prototype.revealPreviousSearchResult):
(WI.ResourceSecurityContentView.prototype.revealNextSearchResult):
(WI.ResourceSecurityContentView.prototype._refreshCetificateSection):
(WI.ResourceSecurityContentView.prototype._perfomSearchOnKeyValuePairs):
(WI.ResourceSecurityContentView.prototype._revealSearchResult):
(WI.ResourceSecurityContentView.prototype._handleResourceResponseReceived):

  • UserInterface/Views/ResourceSecurityContentView.css: Added.

(body[dir] .resource-security > section.certificate > .details):
(.resource-security .details .key):
(.resource-security .dns-name + .dns-name > .key,):
(.resource-security .show-more):
(@media (prefers-dark-interface) body[dir] .resource-security > section.certificate > .details):
(@media (prefers-dark-interface) .resource-security .details .key):

  • UserInterface/Views/ResourceCookiesContentView.js:

(WI.ResourceCookiesContentView.prototype._refreshRequestCookiesSection):
(WI.ResourceCookiesContentView.prototype._refreshResponseCookiesSection):
(WI.ResourceCookiesContentView.prototype._markIncompleteSectionWithMessage): Deleted.
(WI.ResourceCookiesContentView.prototype._markIncompleteSectionWithLoadingIndicator): Deleted.

  • UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
(WI.ResourceHeadersContentView.prototype._refreshRedirectHeadersSections):
(WI.ResourceHeadersContentView.prototype._refreshRequestHeadersSection):
(WI.ResourceHeadersContentView.prototype._refreshResponseHeadersSection):
(WI.ResourceHeadersContentView.prototype._refreshQueryStringSection):
(WI.ResourceHeadersContentView.prototype._refreshRequestDataSection):
(WI.ResourceHeadersContentView.prototype._markIncompleteSectionWithMessage): Deleted.
(WI.ResourceHeadersContentView.prototype._markIncompleteSectionWithLoadingIndicator): Deleted.
(WI.ResourceHeadersContentView.prototype._appendKeyValuePair): Deleted.

  • UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers .h1-status > .key,):
(body[dir] .resource-headers > section.error > .details): Deleted.
(.resource-headers > section.error .key): Deleted.
(.resource-headers .details): Deleted.
(.resource-headers .details .pair): Deleted.
(body[dir=rtl] .resource-headers .details .pair): Deleted.
(.resource-headers .details .key): Deleted.
(.resource-headers .value): Deleted.
(.resource-headers .go-to-arrow): Deleted.
(.resource-headers.showing-find-banner .search-highlight): Deleted.

  • UserInterface/Views/ResourceDetailsSection.js:

(WI.ResourceDetailsSection.prototype.markIncompleteSectionWithMessage): Added.
(WI.ResourceDetailsSection.prototype.markIncompleteSectionWithLoadingIndicator): Added.
(WI.ResourceDetailsSection.prototype.appendKeyValuePair): Added.

  • UserInterface/Views/ResourceDetailsSection.css:

(.resource-details > section > .details): Added.
(.resource-details > section > .details > .pair): Added.
(body[dir=rtl] .resource-details > section > .details > .pair): Added.
(.resource-details > section > .details > .pair > .key): Added.
(.resource-details > section > .details > .pair > .value): Added.
(body[dir] .resource-details > section.error > .details): Added.
(.resource-details > section.error > .details > .pair > .key): Added.
Move commonly used functions/styles from container classes onto this object.

  • UserInterface/Main.html:
  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • http/tests/inspector/network/resource-response-security-expected.txt: Added.
  • http/tests/inspector/network/resource-response-security.html: Added.
  • platform/gtk/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wpe/TestExpectations:
9:13 PM Changeset in webkit [238121] by Matt Baker
  • 6 edits in trunk

Web Inspector: Table should support shift-extending the row selection
​https://bugs.webkit.org/show_bug.cgi?id=189718
<rdar://problem/44577942>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Allow the table selection to be extended by shift-clicking a row, or by
holding shift and pressing either the up or down arrow key. If both command
and shift are pressed, shift is ignored. The selection behavior is modeled
after AppKit's NSTableView.

  • UserInterface/Base/IndexSet.js:

(WI.IndexSet.prototype.addRange):
(WI.IndexSet.prototype.deleteRange):
(WI.IndexSet.prototype.equals):
(WI.IndexSet.prototype.difference):

  • UserInterface/Views/Table.js:

(WI.Table):
(WI.Table.prototype.set allowsMultipleSelection):
(WI.Table.prototype.reloadData):
(WI.Table.prototype.selectRow):
(WI.Table.prototype.deselectRow):
(WI.Table.prototype._handleKeyDown):
Holding shift and pressing either the up or down arrow key extends the
selection to the next unselected row adjacent to the anchor row, or causes
the anchor row to be deselected, decreasing the selection. The table chooses
the action to take based on the direction of movement (up or down), and
the currently selected rows.

(WI.Table.prototype._selectRowsFromArrowKey):
(WI.Table.prototype._handleMouseDown.normalizeRange):
(WI.Table.prototype._handleMouseDown):
Clicking a row while holding down shift extends the selection to include
the rows between the anchor row (exclusive) and clicked row (inclusive).
The anchor row is equal to the value of _selectedRowIndex prior to
clicking a new row.

(WI.Table.prototype._deselectAllAndSelect):
(WI.Table.prototype._removeRows):
(WI.Table.prototype._toggleSelectedRowStyle):
(WI.Table.prototype._updateSelectedRows):
Helper method for updating the selection to the specified rows, and updating
DOM styles for rows that are added to or removed from the selection.

LayoutTests:

  • inspector/unit-tests/index-set-expected.txt:
  • inspector/unit-tests/index-set.html:

Add tests for new IndexSet methods addRange, deleteRange, equals, and difference.

8:43 PM Changeset in webkit [238120] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: inline swatches don't work when Multiple Properties Selection is enabled
​https://bugs.webkit.org/show_bug.cgi?id=191165
<rdar://problem/45737972>

Reviewed by Devin Rousso.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
click is fired after mouseup and inline swatches are activated by click event.
Changing this to click allows swatches to activate before editing starts.

(WI.SpreadsheetTextField.prototype._handleMouseDown):
Clicking on the field that is being edited should't restart editing. It should move the text caret.

6:38 PM Changeset in webkit [238119] by Alan Bujtas
  • 7 edits
    2 adds in trunk

Do not collapse the soon-to-be-parent anon block when we shuffle around the marker item renderer.
​https://bugs.webkit.org/show_bug.cgi?id=191554
<rdar://problem/45825265>

Reviewed by Antti Koivisto.

Source/WebCore:

While moving the marker item renderer to its correct subtree, we accidentally remove the soon-to-be parent anonymous block.
Moving a renderer is a 2 step process:

  1. Detach the renderer from its current parent
  2. Attach it to its new parent.

During step #1, we check if there is a chance to collapse anonymous blocks. In this case the soon-to-be-parent is a sibling anonymous block which, after detaching the marker sibling
is not needed anymore (except we use it as the new parent).

Test: fast/inline/marker-list-item-move-should-not-crash.html

  • rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::detach):

  • rendering/updating/RenderTreeBuilder.h:
  • rendering/updating/RenderTreeBuilderBlock.cpp:

(WebCore::RenderTreeBuilder::Block::detach):

  • rendering/updating/RenderTreeBuilderBlock.h:
  • rendering/updating/RenderTreeBuilderList.cpp:

(WebCore::RenderTreeBuilder::List::updateItemMarker):

LayoutTests:

  • fast/inline/marker-list-item-move-should-not-crash-expected.txt: Added.
  • fast/inline/marker-list-item-move-should-not-crash.html: Added.
6:32 PM Changeset in webkit [238118] by ap@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix another ChangeLog typo for testing. Thanks for making so many!

6:25 PM Changeset in webkit [238117] by Kocsen Chung
  • 1 copy in tags/Safari-606.3.4.1.3

Tag Safari-606.3.4.1.3.

6:12 PM Changeset in webkit [238116] by ap@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix a random typo in ChangeLog to test post-commit hook.

5:08 PM Changeset in webkit [238115] by achristensen@apple.com
  • 14 edits in trunk

[iOS] Implement safe browsing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=191441

Reviewed by Tim Horton.

Source/WebKit:

In r237863 I implemented this for Mac. This refines the UI and implements it for iOS.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextHandlesSafeBrowsing):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):
(-[WKWebView _clearSafeBrowsingWarning]):
(-[WKWebView layoutSubviews]):
(-[WKWebView setFrameSize:]):
(+[WKWebView _handlesSafeBrowsing]):
(-[WKWebView _safeBrowsingWarningForTesting]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/PageClientImplCocoa.h:
  • UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::allocFileWrapperInstance const):
(WebKit::PageClientImplCocoa::serializableFileWrapperClasses const):

  • UIProcess/Cocoa/WKSafeBrowsingWarning.h:
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(confirmMalwareSentinel):
(visitUnsafeWebsiteSentinel):
(colorForItem):
(addLinkAndReplace):
(-[WKSafeBrowsingExclamationPoint drawRect:]):
(makeButton):
(makeTitleLabel):
(setBackground):
(-[WKSafeBrowsingWarning initWithFrame:safeBrowsingResult:completionHandler:]):
(-[WKSafeBrowsingWarning addContent]):
(-[WKSafeBrowsingWarning showDetailsClicked]):
(-[WKSafeBrowsingWarning layoutText]):
(-[WKSafeBrowsingWarning textView:clickedOnLink:atIndex:]):
(-[WKSafeBrowsingWarning layout]):
(-[WKSafeBrowsingWarning layoutSubviews]):
(-[WKSafeBrowsingWarning textView:shouldInteractWithURL:inRange:interaction:]):
(-[WKSafeBrowsingWarning didMoveToWindow]):
(-[WKSafeBrowsingWarning clickedOnLink:]):
(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
(-[WKSafeBrowsingTextView intrinsicContentSize]):
(colorNamed): Deleted.
(+[WKSafeBrowsingTextView viewWithAttributedString:linkTarget:]): Deleted.
(+[WKSafeBrowsingTextView viewWithString:]): Deleted.
(-[WKSafeBrowsingTextView clickedOnLink:atIndex:]): Deleted.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::showSafeBrowsingWarning):
(WebKit::PageClientImpl::clearSafeBrowsingWarning):
(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):
(WebKit::PageClientImpl::requestPasswordForQuickLookDocument):

  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::showShareSheet):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::navigationGestureWillEnd):
(WebKit::PageClientImpl::navigationGestureDidEnd):
(WebKit::PageClientImpl::willRecordNavigationSnapshot):
(WebKit::PageClientImpl::didRemoveNavigationGestureSnapshot):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(checkTitleAndClick):
(TEST):

4:31 PM Changeset in webkit [238114] by jfernandez@igalia.com
  • 7 edits in trunk/Source/WebCore

[css-grid] Refactoring to make more explicit the orthogonal items' pre-layout logic
​https://bugs.webkit.org/show_bug.cgi?id=191358

Reviewed by Manuel Rego Casasnovas.

These changes are just a refactoring to ease the integration of the new Baseline Alignment
logic in a follow up patch.

We need to properly estimate the grid area size of orthogonal items so that we can perform
an accurate pre-layout. This is important because orthogonal items will synthesize their baseline
if they participate in any baseline alignment context.

No new tests, since no behavior change has been introduced in this patch.

  • rendering/Grid.cpp:

(WebCore::Grid::setNeedsItemsPlacement):

  • rendering/Grid.h:
  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::isRelativeGridLengthAsAuto const):
(WebCore::GridTrackSizingAlgorithm::isRelativeSizedTrackAsAuto const):
(WebCore::GridTrackSizingAlgorithm::gridTrackSize const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::run):
(WebCore::GridTrackSizingAlgorithm::reset):

  • rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrackSizingAlgorithmStrategy::gridTrackSize const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::repeatTracksSizingIfNeeded):
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::computeTrackSizesForIndefiniteSize const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::overrideSizeChanged):
(WebCore::hasRelativeBlockAxisSize):
(WebCore::RenderGrid::updateGridAreaLogicalSize const):
(WebCore::RenderGrid::layoutGridItems):

  • rendering/RenderGrid.h:
3:42 PM Changeset in webkit [238113] by rniwa@webkit.org
  • 2 edits in trunk

Add HTTPS git remote to ReadMe.md
​https://bugs.webkit.org/show_bug.cgi?id=191561

Reviewed by Zalan Bujtas.

  • ReadMe.md:
3:34 PM Changeset in webkit [238112] by sihui_liu@apple.com
  • 6 edits in trunk

imported/w3c/web-platform-tests/IndexedDB/keygenerator-explicit.html crashing on iOS device
​https://bugs.webkit.org/show_bug.cgi?id=191500

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

  • web-platform-tests/IndexedDB/keygenerator-explicit-expected.txt:

Source/WebCore:

When double value is bigger than maximum unsigned int, converting double to unsigned int has
different behaviors on macOS and iOS. On macOS, the result would be 0 while on iOS it would be
maximum unsigned int.

Covered by existing test.

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):

LayoutTests:

The test should not crash now.

  • platform/ios-device/TestExpectations:
3:18 PM Changeset in webkit [238111] by basuke.suzuki@sony.com
  • 10 edits
    2 adds in trunk

[Curl] Add API Test for Curl cookie backend.
​https://bugs.webkit.org/show_bug.cgi?id=191493

Reviewed by Youenn Fablet.

Source/WebCore:

Refactoring for cookie backend interface.

Tests: TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp

  • platform/FileSystem.h:
  • platform/network/curl/CookieJarCurlDatabase.cpp:

(WebCore::cookiesForSession):
(WebCore::CookieJarCurlDatabase::setCookiesFromDOM const):
(WebCore::CookieJarCurlDatabase::setCookiesFromHTTPResponse const):
(WebCore::CookieJarCurlDatabase::getRawCookies const):

  • platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::openDatabase):
(WebCore::CookieJarDB::checkSQLiteReturnCode):
(WebCore::CookieJarDB::isEnabled const):
(WebCore::CookieJarDB::searchCookies):
(WebCore::CookieJarDB::setCookie):
(WebCore::CookieJarDB::deleteCookie):
(WebCore::CookieJarDB::deleteCookieInternal):
(WebCore::CookieJarDB::deleteCookies):
(WebCore::CookieJarDB::deleteAllCookies):
(WebCore::CookieJarDB::executeSimpleSql):
(WebCore::CookieJarDB::isEnabled): Deleted.

  • platform/network/curl/CookieJarDB.h:
  • platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieHeader):

  • platform/network/curl/CookieUtil.h:
  • platform/win/FileSystemWin.cpp:

(WebCore::FileSystem::generateTemporaryPath):
(WebCore::FileSystem::openTemporaryFile):
(WebCore::FileSystem::createTemporaryDirectory):
(WebCore::FileSystem::deleteNonEmptyDirectory):

Tools:

Add unit test to TestWebCore.

  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp: Added.
2:44 PM Changeset in webkit [238110] by bshafiei@apple.com
  • 7 edits in branches/safari-606-branch/Source

Versioning.

2:10 PM Changeset in webkit [238109] by sbarati@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed. Rollout 238026: It caused ~8% JetStream 2 regressions on some iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=191555

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

  • bytecode/UnlinkedFunctionExecutable.h:
  • parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

  • runtime/CodeCache.h:
  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/FunctionExecutable.h:
2:04 PM Changeset in webkit [238108] by timothy_horton@apple.com
  • 50 edits
    11 adds in trunk

Make it possible to edit images inline
​https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html

editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

  • page/Settings.yaml:

Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

  • html/HTMLImageElement.h:

Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):

  • rendering/RenderLayerCompositor.h:

Make editable images require compositing implicitly.

Source/WebKit:

  • Platform/spi/ios/PencilKitSPI.h: Added.
  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

  • WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):

  • WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a preference to enable editable images.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.

(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

  • UIProcess/ios/WKDrawingView.h: Added.
  • UIProcess/ios/WKDrawingView.mm: Added.

(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

  • WebKit.xcodeproj/project.pbxproj:
  • SourcesCocoa.txt:

Add the new files.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • TestRunnerShared/spi/PencilKitTestSPI.h: Added.
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

  • TestExpectations:
  • editing/images/basic-editable-image-expected.txt: Added.
  • editing/images/basic-editable-image.html: Added.
  • editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
  • editing/images/reparent-editable-image-maintains-strokes.html: Added.
  • platform/ios-wk2/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

1:42 PM Changeset in webkit [238107] by Ryan Haddad
  • 2 edits in trunk/Tools

[MediaStream] Screen capture should be an experimental feature on OSX only
​https://bugs.webkit.org/show_bug.cgi?id=191552

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm: Only run these tests on macOS.
1:41 PM Changeset in webkit [238106] by don.olmstead@sony.com
  • 199 edits in trunk

Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
​https://bugs.webkit.org/show_bug.cgi?id=189230
<rdar://problem/44050379>

Reviewed by Joseph Pecoraro.

Runs all png images through zopflipng. This results in a smaller file
size and takes care of this issue as a byproduct.

Source/WebCore:

Source/WebInspectorUI:

  • UserInterface/Images/ApplicationCache.png:
  • UserInterface/Images/ApplicationCache@2x.png:
  • UserInterface/Images/ApplicationCacheManifest.png:
  • UserInterface/Images/ApplicationCacheManifest@2x.png:
  • UserInterface/Images/Breakpoint.png:
  • UserInterface/Images/Breakpoint@2x.png:
  • UserInterface/Images/BreakpointInactive.png:
  • UserInterface/Images/BreakpointInactive@2x.png:
  • UserInterface/Images/ClippingCSS.png:
  • UserInterface/Images/​ClippingCSS@2x.png:
  • UserInterface/Images/ClippingCSSLarge.png:
  • UserInterface/Images/​ClippingCSSLarge@2x.png:
  • UserInterface/Images/ClippingGeneric.png:
  • UserInterface/Images/ClippingGeneric@2x.png:
  • UserInterface/Images/ClippingGenericLarge.png:
  • UserInterface/Images/ClippingGenericLarge@2x.png:
  • UserInterface/Images/ClippingJS.png:
  • UserInterface/Images/​ClippingJS@2x.png:
  • UserInterface/Images/ClippingJSLarge.png:
  • UserInterface/Images/​ClippingJSLarge@2x.png:
  • UserInterface/Images/ColorIcon.png:
  • UserInterface/Images/ColorIcon@2x.png:
  • UserInterface/Images/Cookie.png:
  • UserInterface/Images/Cookie@2x.png:
  • UserInterface/Images/Database.png:
  • UserInterface/Images/Database@2x.png:
  • UserInterface/Images/DatabaseTable.png:
  • UserInterface/Images/DatabaseTable@2x.png:
  • UserInterface/Images/DocumentCSS.png:
  • UserInterface/Images/​DocumentCSS@2x.png:
  • UserInterface/Images/DocumentCSSLarge.png:
  • UserInterface/Images/​DocumentCSSLarge@2x.png:
  • UserInterface/Images/DocumentFont.png:
  • UserInterface/Images/DocumentFont@2x.png:
  • UserInterface/Images/DocumentFontLarge.png:
  • UserInterface/Images/DocumentFontLarge@2x.png:
  • UserInterface/Images/DocumentGL.png:
  • UserInterface/Images/​DocumentGL@2x.png:
  • UserInterface/Images/DocumentGeneric.png:
  • UserInterface/Images/DocumentGeneric@2x.png:
  • UserInterface/Images/DocumentGenericLarge.png:
  • UserInterface/Images/DocumentGenericLarge@2x.png:
  • UserInterface/Images/DocumentImage.png:
  • UserInterface/Images/DocumentImage@2x.png:
  • UserInterface/Images/DocumentImageLarge.png:
  • UserInterface/Images/DocumentImageLarge@2x.png:
  • UserInterface/Images/DocumentJS.png:
  • UserInterface/Images/​DocumentJS@2x.png:
  • UserInterface/Images/DocumentJSLarge.png:
  • UserInterface/Images/​DocumentJSLarge@2x.png:
  • UserInterface/Images/DocumentMarkup.png:
  • UserInterface/Images/DocumentMarkup@2x.png:
  • UserInterface/Images/DocumentMarkupLarge.png:
  • UserInterface/Images/DocumentMarkupLarge@2x.png:
  • UserInterface/Images/FolderGeneric.png:
  • UserInterface/Images/FolderGeneric@2x.png:
  • UserInterface/Images/GradientStop.png:
  • UserInterface/Images/GradientStop@2x.png:
  • UserInterface/Images/GradientStopSelected.png:
  • UserInterface/Images/GradientStopSelected@2x.png:
  • UserInterface/Images/HoverMenuButton.png:
  • UserInterface/Images/HoverMenuButton@2x.png:
  • UserInterface/Images/InstructionPointer.png:
  • UserInterface/Images/InstructionPointer@2x.png:
  • UserInterface/Images/LocalStorage.png:
  • UserInterface/Images/LocalStorage@2x.png:
  • UserInterface/Images/SessionStorage.png:
  • UserInterface/Images/SessionStorage@2x.png:
  • UserInterface/Images/SliderThumb.png:
  • UserInterface/Images/SliderThumb@2x.png:
  • UserInterface/Images/SliderThumbPressed.png:
  • UserInterface/Images/SliderThumbPressed@2x.png:
  • UserInterface/Images/WebSocket.png:
  • UserInterface/Images/WebSocket@2x.png:
  • UserInterface/Images/WebSocketLarge.png:
  • UserInterface/Images/WebSocketLarge@2x.png:
  • UserInterface/Images/WorkerScript.png:
  • UserInterface/Images/WorkerScript@2x.png:
  • UserInterface/Images/WorkerScriptLarge.png:
  • UserInterface/Images/WorkerScriptLarge@2x.png:

Source/WebKit:

Source/WebKitLegacy/win:

  • WebKit.resources/deleteButton.png:
  • WebKit.resources/deleteButtonPressed.png:
  • WebKit.resources/fsVideoAudioVolumeHigh.png:
  • WebKit.resources/fsVideoAudioVolumeLow.png:
  • WebKit.resources/fsVideoExitFullscreen.png:
  • WebKit.resources/fsVideoPause.png:
  • WebKit.resources/fsVideoPlay.png:
  • WebKit.resources/missingImage.png:
  • WebKit.resources/nullplugin.png:
  • WebKit.resources/panEastCursor.png:
  • WebKit.resources/panIcon.png:
  • WebKit.resources/panNorthCursor.png:
  • WebKit.resources/panNorthEastCursor.png:
  • WebKit.resources/panNorthWestCursor.png:
  • WebKit.resources/panSouthCursor.png:
  • WebKit.resources/panSouthEastCursor.png:
  • WebKit.resources/panSouthWestCursor.png:
  • WebKit.resources/panWestCursor.png:
  • WebKit.resources/searchCancel.png:
  • WebKit.resources/searchCancelPressed.png:
  • WebKit.resources/searchMagnifier.png:
  • WebKit.resources/searchMagnifierResults.png:
  • WebKit.resources/textAreaResizeCorner.png:
  • WebKit.resources/verticalTextCursor.png:
  • WebKit.resources/zoomInCursor.png:
  • WebKit.resources/zoomOutCursor.png:

Tools:

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​ElCapitan@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​GTK@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​HighSierra@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS10@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS10Simulator.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS10Simulator@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS11@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS11Simulator@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS12@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS12Simulator@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS9@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOS9Simulator@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOSDevice@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSSimulator.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​IOSSimulator@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Mavericks@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Mojave@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​MountainLion@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​PlatformRing@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Sierra@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​WPE@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows10.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows10@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows7@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Windows8@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​WindowsXP@2x.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/​Yosemite@2x.png:
1:25 PM Changeset in webkit [238105] by jfernandez@igalia.com
  • 9 edits
    143 adds in trunk/LayoutTests

[css-grid] Import additional grid layout tests and update TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=191515

Reviewed by Dean Jackson.

Imported several tests from Blink and update TextExpectaions.

  • TestExpectations: Adding specific bugs for the expected failures.
  • fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash-expected.txt: Added.
  • fast/css-grid-layout/changing-content-property-on-nested-grid-should-not-crash.html: Added.
  • fast/css-grid-layout/column-property-should-not-apply-on-grid-container-expected.html: Added.
  • fast/css-grid-layout/column-property-should-not-apply-on-grid-container.html: Added.
  • fast/css-grid-layout/crash-large-positions-expected.txt: Added.
  • fast/css-grid-layout/crash-large-positions.html: Added.
  • fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid-expected.txt: Added.
  • fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html: Added.
  • fast/css-grid-layout/floating-not-effect-on-grid-items-expected.txt: Added.
  • fast/css-grid-layout/floating-not-effect-on-grid-items.html: Added.
  • fast/css-grid-layout/grid-align-baseline-expected.txt: Added.
  • fast/css-grid-layout/grid-align-baseline-vertical-expected.txt: Added.
  • fast/css-grid-layout/grid-align-baseline-vertical.html: Added.
  • fast/css-grid-layout/grid-align-baseline.html: Added.
  • fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-repeat-inherit-initial-crash.html: Added.
  • fast/css-grid-layout/grid-auto-repeat-positioned-container-expected.html: Added.
  • fast/css-grid-layout/grid-auto-repeat-positioned-container.html: Added.
  • fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio-expected.txt: Added.
  • fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html: Added.
  • fast/css-grid-layout/grid-container-percentage-columns-expected.txt:
  • fast/css-grid-layout/grid-container-percentage-columns.html:
  • fast/css-grid-layout/grid-container-percentage-rows-expected.txt: Added.
  • fast/css-grid-layout/grid-container-percentage-rows.html: Added.
  • fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin-expected.html: Added.
  • fast/css-grid-layout/grid-container-scroll-accounts-for-auto-margin.html: Added.
  • fast/css-grid-layout/grid-container-scroll-accounts-for-sizing-expected.html:
  • fast/css-grid-layout/grid-container-scroll-accounts-for-sizing.html:
  • fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width-expected.txt: Added.
  • fast/css-grid-layout/grid-container-width-should-include-scroll-bar-width.html: Added.
  • fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content-expected.txt: Added.
  • fast/css-grid-layout/grid-crash-huge-margins-and-min-height-max-content.html: Added.
  • fast/css-grid-layout/grid-crash-out-of-flow-positioned-element-expected.txt: Added.
  • fast/css-grid-layout/grid-crash-out-of-flow-positioned-element.html: Added.
  • fast/css-grid-layout/grid-crash-remove-positioned-item-expected.txt:
  • fast/css-grid-layout/grid-crash-remove-positioned-item.html:
  • fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Added.
  • fast/css-grid-layout/grid-item-border-overflow-paint-expected.html: Added.
  • fast/css-grid-layout/grid-item-border-overflow-paint.html: Added.
  • fast/css-grid-layout/grid-item-change-alignment-from-stretch-expected.txt: Added.
  • fast/css-grid-layout/grid-item-change-alignment-from-stretch.html: Added.
  • fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html: Added.
  • fast/css-grid-layout/grid-item-grid-container-percentage-rows.html: Added.
  • fast/css-grid-layout/grid-item-overflow-expected.html: Added.
  • fast/css-grid-layout/grid-item-overflow-paint-expected.html: Added.
  • fast/css-grid-layout/grid-item-overflow-paint.html: Added.
  • fast/css-grid-layout/grid-item-overflow.html: Added.
  • fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Added.
  • fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Added.
  • fast/css-grid-layout/grid-item-scroll-position-expected.txt: Added.
  • fast/css-grid-layout/grid-item-scroll-position.html: Added.
  • fast/css-grid-layout/grid-margins-not-collapse-expected.html: Added.
  • fast/css-grid-layout/grid-margins-not-collapse.html: Added.
  • fast/css-grid-layout/grid-painting-item-overflow-expected.html: Added.
  • fast/css-grid-layout/grid-painting-item-overflow.html: Added.
  • fast/css-grid-layout/grid-painting-items-only-once-expected.html: Added.
  • fast/css-grid-layout/grid-painting-items-only-once.html: Added.
  • fast/css-grid-layout/grid-painting-respect-dom-order-expected.html: Added.
  • fast/css-grid-layout/grid-painting-respect-dom-order.html: Added.
  • fast/css-grid-layout/grid-painting-rtl-expected.html: Added.
  • fast/css-grid-layout/grid-painting-rtl.html: Added.
  • fast/css-grid-layout/grid-self-baseline-01-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-01.html: Added.
  • fast/css-grid-layout/grid-self-baseline-02-b-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-02-b.html: Added.
  • fast/css-grid-layout/grid-self-baseline-02-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-02.html: Added.
  • fast/css-grid-layout/grid-self-baseline-03-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-03.html: Added.
  • fast/css-grid-layout/grid-self-baseline-04-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-04.html: Added.
  • fast/css-grid-layout/grid-self-baseline-05-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-05.html: Added.
  • fast/css-grid-layout/grid-self-baseline-06-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-06.html: Added.
  • fast/css-grid-layout/grid-self-baseline-07-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-07.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-01-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-01.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-02-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-02.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-03-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-03.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-04-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-04.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-05-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-05.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-06.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-horiz-07.html: Added.
  • fast/css-grid-layout/grid-self-baseline-two-dimensional-expected.txt: Added.
  • fast/css-grid-layout/grid-self-baseline-two-dimensional.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-01-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-01.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-02-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-02.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-03-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-03.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-04-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-04.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-05-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-05.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-06-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-06.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-07-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-lr-07.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-01-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-01.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-02-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-02.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-03-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-03.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-04-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-04.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-05-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-05.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-06-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-06.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-07-expected.html: Added.
  • fast/css-grid-layout/grid-self-baseline-vertical-rl-07.html: Added.
  • fast/css-grid-layout/grid-shorthands-style-format-expected.txt: Added.
  • fast/css-grid-layout/grid-shorthands-style-format.html: Added.
  • fast/css-grid-layout/grid-strict-ordering-crash-2-expected.txt: Added.
  • fast/css-grid-layout/grid-strict-ordering-crash-2.html: Added.
  • fast/css-grid-layout/named-grid-areas-dynamic-with-media-query-expected.html: Added.
  • fast/css-grid-layout/named-grid-areas-dynamic-with-media-query.html: Added.
  • fast/css-grid-layout/negative-growth-share-as-infinity-crash-expected.txt: Added.
  • fast/css-grid-layout/negative-growth-share-as-infinity-crash.html: Added.
  • fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area-expected.html: Added.
  • fast/css-grid-layout/painting-item-marginbox-overflowing-grid-area.html: Added.
  • fast/css-grid-layout/positioned-grid-container-item-percentage-size-expected.html: Added.
  • fast/css-grid-layout/positioned-grid-container-item-percentage-size.html: Added.
  • fast/css-grid-layout/positioned-grid-container-percentage-tracks-expected.txt: Added.
  • fast/css-grid-layout/positioned-grid-container-percentage-tracks.html: Added.
  • fast/css-grid-layout/preferred-width-computed-after-layout-expected.txt: Added.
  • fast/css-grid-layout/preferred-width-computed-after-layout.html: Added.
  • fast/css-grid-layout/quirks-mode-percent-resolution-grid-item-expected.txt: Added.
  • fast/css-grid-layout/quirks-mode-percent-resolution-grid-item.html: Added.
  • fast/css-grid-layout/resources/blue-100x50.png: Added.
  • fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridPositionDefinitionsValues):

  • fast/css-grid-layout/scrolled-grid-painting-expected.html: Added.
  • fast/css-grid-layout/scrolled-grid-painting-overflow-expected.html: Added.
  • fast/css-grid-layout/scrolled-grid-painting-overflow.html: Added.
  • fast/css-grid-layout/scrolled-grid-painting.html: Added.
  • fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash-expected.txt: Added.
  • fast/css-grid-layout/setting-node-properties-to-null-during-layout-should-not-crash.html: Added.
  • fast/css-grid-layout/stale-grid-layout-2-expected.txt: Added.
  • fast/css-grid-layout/stale-grid-layout-expected.txt: Added.
  • fast/css-grid-layout/vertical-align-do-not-effect-grid-items-expected.html: Added.
  • fast/css-grid-layout/vertical-align-do-not-effect-grid-items.html: Added.
1:19 PM Changeset in webkit [238104] by timothy_horton@apple.com
  • 13 edits in trunk/Tools

Modernize WebKit Tools Xcode projects for localization's sake
​https://bugs.webkit.org/show_bug.cgi?id=191495

Reviewed by Alexey Proskuryakov.

  • ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
  • FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
  • ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:

These are less important because they're not localized, but since
I made the style checker complain, it now complains any time anyone
touches any of these projects... so upgrade them.

11:59 AM Changeset in webkit [238103] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Check for specific process instead of using data migrator
​https://bugs.webkit.org/show_bug.cgi?id=191551
<rdar://problem/45993156>

Rubber-stamped by Aakash Jain.

It's possible for the data migrator process to be stuck, but for a simulator to be
usable. Use device-specific processes to detect when a device is usable.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._wait_until_device_is_usable):
(SimulatedDeviceManager):
(SimulatedDeviceManager.initialize_devices): Explicitly wait until a device is usable
since this implies that a device is booted.
(SimulatedDeviceManager.swap): Ditto.
(SimulatedDevice.is_usable): Check that a device is booted and that a device-specific
process indicating the device is usable can be found.
(SimulatedDeviceManager.wait_until_data_migration_is_done): Deleted.

  • Scripts/webkitpy/xcode/simulated_device_unittest.py: Update simctl_json so that

it triggers the logic in is_usable()

11:49 AM Changeset in webkit [238102] by youenn@apple.com
  • 12 edits in trunk

RealtimeOutgoing A/V sources should observe their sources only if having a sink
​https://bugs.webkit.org/show_bug.cgi?id=191490

Reviewed by Eric Carlson.

Source/WebCore:

Observe the source that generates media based on the sinks:

  • Do not observe at creation time
  • For first sink, start observing
  • When no more sink, stop observing

Apply this principle for both outgoing audio and video sources.
Add locks for the sinks to ensure thread-safety.
Make sinks HashSet which is more robust.

Do some refactoring to better isolate generic outgoing sources from Cocoa/GTK implementations.

Covered by existing tests and updated webrtc/remove-track.html.

  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::~RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::stop):
(WebCore::RealtimeOutgoingAudioSource::AddSink):
(WebCore::RealtimeOutgoingAudioSource::RemoveSink):
(WebCore::RealtimeOutgoingAudioSource::sendAudioFrames):

  • platform/mediastream/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::~RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::observeSource):
(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::stop):
(WebCore::RealtimeOutgoingVideoSource::AddOrUpdateSink):
(WebCore::RealtimeOutgoingVideoSource::RemoveSink):

  • platform/mediastream/RealtimeOutgoingVideoSource.h:

(WebCore::RealtimeOutgoingVideoSource::isSilenced const):

  • platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:

(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::pullAudioData):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:

(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):
(WebCore::RealtimeOutgoingAudioSourceCocoa::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSourceCocoa::pullAudioData):

  • platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

(WebCore::RealtimeOutgoingVideoSourceCocoa::sampleBufferUpdated):

LayoutTests:

  • webrtc/remove-track-expected.txt:
  • webrtc/remove-track.html:

Add tests and fixed some flakiness issues on existing tests in the file.

11:23 AM Changeset in webkit [238101] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit

[MediaStream] Screen capture should be an experimental feature on OSX only
​https://bugs.webkit.org/show_bug.cgi?id=191552
<rdar://problem/45994142>

Reviewed by Youenn Fablet.

  • Shared/WebPreferences.yaml: Make ScreenCaptureEnabled.condition ENABLE(MEDIA_STREAM) && PLATFORM(MAC).
11:12 AM Changeset in webkit [238100] by youenn@apple.com
  • 9 edits in trunk

Support setting stream ids when adding a transceiver
​https://bugs.webkit.org/show_bug.cgi?id=191307

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-transceivers.https-expected.txt:
  • web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:

Source/WebCore:

Add support for streams in RTCTransceiverInit.
Add plumbing down to libwebrtc.
Covered by rebased tests.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::fromRtpTransceiverInit):

LayoutTests:

11:07 AM Changeset in webkit [238099] by Alan Coon
  • 6 edits in tags/Safari-607.1.13.2/Source

Cherry-pick r238031. rdar://problem/45848446

LLInt VectorSizeOffset should be based on offset extraction
​https://bugs.webkit.org/show_bug.cgi?id=191468

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This patch also adds some usings to LLIntOffsetsExtractor that
make it possible to use the bare names of Vector/RefCountedArray
in offsets extraction.

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:

Source/WTF:

Make things friends with LLIntOffsetsExtractor.

  • wtf/RefCountedArray.h:
  • wtf/Vector.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@238031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:58 AM Changeset in webkit [238098] by commit-queue@webkit.org
  • 20 edits
    5 copies
    10 adds in trunk

Resurrect WebKitTestRunner for Windows port
​https://bugs.webkit.org/show_bug.cgi?id=189257

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2018-11-12
Reviewed by Fujii Hironori.

.:

  • Source/cmake/OptionsWin.cmake:

Source/WebKit:

  • PlatformWin.cmake:

Tools:

Implement WebKitTestRunner for WinCairo.

  • PlatformWin.cmake:
  • Scripts/build-webkittestrunner:
  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::rangeToStr):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp: Added.

(WTR::AccessibilityController::resetToConsistentState):
(WTR::AccessibilityController::accessibleElementById):
(WTR::AccessibilityController::platformName):
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):

  • WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp: Added.

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex const):
(WTR::AccessibilityUIElement::selectedChildrenCount const):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::uiElementAttributeValue const):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::computedRoleString):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation const):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue const):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isPressActionSupported):
(WTR::AccessibilityUIElement::isIncrementActionSupported):
(WTR::AccessibilityUIElement::isDecrementActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired const):
(WTR::AccessibilityUIElement::isFocused const):
(WTR::AccessibilityUIElement::isSelected const):
(WTR::AccessibilityUIElement::isSelectedOptionActive const):
(WTR::AccessibilityUIElement::isExpanded const):
(WTR::AccessibilityUIElement::isChecked const):
(WTR::AccessibilityUIElement::isIndeterminate const):
(WTR::AccessibilityUIElement::hierarchicalLevel const):
(WTR::AccessibilityUIElement::speakAs):
(WTR::AccessibilityUIElement::ariaIsGrabbed const):
(WTR::AccessibilityUIElement::ariaDropEffects const):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild const):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
(WTR::AccessibilityUIElement::removeSelectionAtIndex const):
(WTR::AccessibilityUIElement::clearSelectedChildren const):
(WTR::AccessibilityUIElement::accessibilityValue const):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable const):
(WTR::AccessibilityUIElement::isSelectable const):
(WTR::AccessibilityUIElement::isMultiSelectable const):
(WTR::AccessibilityUIElement::isVisible const):
(WTR::AccessibilityUIElement::isOffScreen const):
(WTR::AccessibilityUIElement::isCollapsed const):
(WTR::AccessibilityUIElement::isIgnored const):
(WTR::AccessibilityUIElement::isSingleLine const):
(WTR::AccessibilityUIElement::isMultiLine const):
(WTR::AccessibilityUIElement::hasPopup const):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::scrollToGlobalPoint):
(WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(WTR::AccessibilityUIElement::supportedActions const):
(WTR::AccessibilityUIElement::pathDescription const):
(WTR::AccessibilityUIElement::mathPostscriptsDescription const):
(WTR::AccessibilityUIElement::mathPrescriptsDescription const):
(WTR::AccessibilityUIElement::classList const):
(WTR::AccessibilityUIElement::characterAtOffset):
(WTR::AccessibilityUIElement::wordAtOffset):
(WTR::AccessibilityUIElement::lineAtOffset):
(WTR::AccessibilityUIElement::sentenceAtOffset):

  • WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::activateFonts):
(WTR::installFakeHelvetica):
(WTR::uninstallFakeHelvetica):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Added.
  • WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.
  • WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(WTR::TestRunner::pathToLocalResource):
(WTR::TestRunner::inspectorTestStubURL):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::TestRunner::installFakeHelvetica):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/PlatformWin.cmake: Added.
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::createTestURL):

  • WebKitTestRunner/TestInvocation.cpp:
  • WebKitTestRunner/WebKitTestRunnerPrefix.h:
  • WebKitTestRunner/win/EventSenderProxyWin.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):

  • WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.

(WTR::registerWindowClass):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::didInitializeClients):
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::makeWebViewFirstResponder):
(WTR::generateCairoSurfaceFromBitmap):
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::changeWindowScaleIfNeeded):
(WTR::PlatformWebView::setNavigationGesturesEnabled):
(WTR::PlatformWebView::forceWindowFramesChanged):
(WTR::PlatformWebView::drawsBackground const):
(WTR::PlatformWebView::setDrawsBackground):

  • WebKitTestRunner/win/TestControllerWin.cpp: Added.

(WTR::exceptionFilter):
(WTR::runRunLoopUntil):
(WTR::TestController::notifyDone):
(WTR::TestController::setHidden):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformPreferences):
(WTR::TestController::platformDestroy):
(WTR::toWK):
(WTR::TestController::platformInitializeContext):
(WTR::TestController::platformRunUntil):
(WTR::TestController::platformDidCommitLoadForFrame):
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
(WTR::TestController::runModal):
(WTR::TestController::platformContext):
(WTR::TestController::platformLibraryPathForTesting):
(WTR::TestController::platformConfigureViewForTest):
(WTR::TestController::platformResetPreferencesToConsistentValues):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest const):

  • WebKitTestRunner/win/WebKitTestRunnerPrefix.cpp: Added.
  • WebKitTestRunner/win/main.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp.

(dllLauncherEntryPoint):

10:55 AM Changeset in webkit [238097] by Antti Koivisto
  • 9 edits
    2 adds in trunk

Support dynamic pseudo-classes on elements with display: contents
​https://bugs.webkit.org/show_bug.cgi?id=181640
<rdar://problem/36605415>

Reviewed by Dean Jackson.

Source/WebCore:

The code for :hover and :active style invalidation assumes that only elements with renderer need invalidation.

This patch fixes '.display-content-element:hover span' case but not '.display-content-element:hover' case but
includes tests for both. The latter is not super useful anyway (as it only affects rendering with inherited
text properties).

Test: fast/css/display-contents-hover-active.html

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

Traverse up in composed tree instead of render tree when invalidating. This has the same order as render tree
but also includes display:content elements. This also allows removing the special display:none case.

  • dom/Element.cpp:

(WebCore::Element::setActive):
(WebCore::Element::setHovered):

Also look into display:contents style for invalidation checks.

(WebCore::Element::renderOrDisplayContentsStyle const):

Make this helper an Element member.

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::Node::parentElementInComposedTree const):

Support starting from a PseudoElement. This is consistent with ComposedTreeAncestorIterator.

  • rendering/updating/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::nextSiblingRenderer const):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::shouldResolveElement):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::renderOrDisplayContentsStyle): Deleted.

Use the Element::renderOrDisplayContentsStyle() instead.

LayoutTests:

  • fast/css/display-contents-hover-active-expected.txt: Added.
  • fast/css/display-contents-hover-active.html: Added.
10:09 AM Changeset in webkit [238096] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Pressing Tab or Enter should start editing focused property
​https://bugs.webkit.org/show_bug.cgi?id=191510
<rdar://problem/45970897>

Reviewed by Dean Jackson.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

10:00 AM Changeset in webkit [238095] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Web Animations] Turn Web Animations experimental
​https://bugs.webkit.org/show_bug.cgi?id=191543

Patch by Antoine Quint <Antoine Quint> on 2018-11-12
Reviewed by Dean Jackson.

Source/WebCore:

  • page/RuntimeEnabledFeatures.h:

Source/WebKit:

  • Shared/WebPreferences.yaml:
9:58 AM Changeset in webkit [238094] by Simon Fraser
  • 5 edits
    2 adds in trunk

feFlood with alpha color doesn't work correctly
​https://bugs.webkit.org/show_bug.cgi?id=163666

Reviewed by Zalan Bujtas.
Source/WebCore:

FEFlood::platformApplySoftware() erroneously used colorWithOverrideAlpha()
rather than multiplying the flood color with the flood opacity as other browsers do.

Test: svg/filters/feFlood-with-alpha-color.html

  • platform/graphics/Color.cpp:

(WebCore::Color::colorWithAlpha const): I tried using colorWithAlphaMultipliedBy() elsewhere,
and it triggered a behavior change, so add a comment.

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

  • svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::stopColorIncludingOpacity const):

LayoutTests:

  • svg/filters/feFlood-with-alpha-color-expected.html: Added.
  • svg/filters/feFlood-with-alpha-color.html: Added.
9:42 AM Changeset in webkit [238093] by Alan Coon
  • 7 edits in tags/Safari-607.1.13.2/Source

Versioning.

9:26 AM Changeset in webkit [238092] by Alan Coon
  • 1 copy in tags/Safari-607.1.13.2

New tag.

9:18 AM Changeset in webkit [238091] by eric.carlson@apple.com
  • 11 edits
    3 adds in trunk

Require <iframe allow="display"> for an iframe to use getDisplayMedia
​https://bugs.webkit.org/show_bug.cgi?id=191505
<rdar://problem/45968811>

Reviewed by Jer Noble.

LayoutTests/imported/w3c:

  • web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt:

Source/WebCore:

Test: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html

  • Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start):

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::isAllowedToUse):
(WebCore::UserMediaController::canCallGetUserMedia):
(WebCore::UserMediaController::logGetUserMediaDenial):

  • Modules/mediastream/UserMediaController.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

LayoutTests:

  • http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
  • http/tests/media/media-stream/get-display-media-iframe-allow-attribute-expected.txt: Added.
  • http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html: Added.
  • http/tests/media/media-stream/resources/get-display-media-devices-iframe.html: Added.
  • http/tests/ssl/media-stream/get-user-media-different-host-expected.txt:
  • http/tests/ssl/media-stream/get-user-media-nested-expected.txt:
9:14 AM Changeset in webkit [238090] by Simon Fraser
  • 22 edits
    1 move
    7 adds in trunk

Make compositing updates incremental
​https://bugs.webkit.org/show_bug.cgi?id=90342

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, updating compositing layers required two full RenderLayer tree traversals,
and all the work was done for every RenderLayer on each composting update. This could be expensive
on pages with lots of RenderLayers.

These changes make compositing updates more incremental. Compositing updates still require
two tree traversals. The first determines which RenderLayers need to be composited (of those which
weren't already made composited at style-change time), because of reasons that can only be determined
post-layout, and indirect reasons including overlap. The second traversal updates the configuration, geometry
and GraphicsLayer tree for the composited layers. Dependencies on both descendant and ancestor state make
it hard to fold these two traversals together.

In order to minimize the work done during these traversals, dirty bits are stored on RenderLayers,
and propagated to ancestor layers in paint order. There are two sets of bits: those related to the first
"compositing requirements" traversal, and those related to the second "update backing and hierarchy" traversal.
When a RenderLayer gets a dirty bit set, bits are propagated to ancestors to indicate that children need
to be visited.

Sadly entire subtrees can't be skipped during the "compositing requirements" traversal becaue we still have
to accumulate overlap rects, but RenderLayerCompositor::traverseUnchangedSubtree() is used to minimize
work in that case. Subtrees can be skipped in the "update backing and hierarchy" traveral. Entire traversals can
be skipped if no change has triggered the need for that traversal.

These changes fix a correctness issue where transform changes now trigger overlap re-evaluation, which causes
more layer geometry updates than before. This regressed the MotionMark "Focus" test, when geometry updates
triggered layer resizes as the filter blur radius changed, which then triggered repaints. This is fixed by
excluding composited filters from the composited bounds (but still taking them into account for overlap).

Care is taken to avoid triggering traversals in non-composited documents (tested by no-updates-in-non-composited-iframe.html).

Code to set the dirty bits is added in various places that change properties that compositing depends on.

These changes also subsume the patch in 176196; we now never consult properties that rely on layout from the
style change code path, and the only call stack for geometry updates is from the "update backing and hierarchy"
traversal, which is always a pre-order traversal.

Tests: compositing/geometry/stacking-context-change-layer-reparent.html

compositing/layer-creation/change-to-overlap.html
compositing/updates/no-updates-in-non-composited-iframe.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChanged): Need to differentiate between a canvas becoming composited
for the first time, and its pixels changing with a new 'CanvasPixelsChanged' value.

  • page/FrameView.cpp:

(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateBackdropFilters): If we just made a layer for backdrops, we need to update sublayers.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::shouldBeStackingContext const):
(WebCore::RenderLayer::stackingContext const):
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::setAncestorsHaveCompositingDirtyFlag):
(WebCore::RenderLayer::contentChanged):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::enclosingCompositingLayer const):
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint const):
(WebCore::RenderLayer::clippingRootForPainting const):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):
(WebCore::compositingContainer): Deleted.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::clearZOrderLists):
(WebCore::RenderLayer::paintOrderParent const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::setRequiresBackgroundLayer):
(WebCore::RenderLayerBacking::updateMaskingLayer):
(WebCore::RenderLayerBacking::paintsContent const):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):
(WebCore::RenderLayerBacking::startTransition):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::setCompositedBounds):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::CompositingState::CompositingState):
(WebCore::RenderLayerCompositor::enableCompositingMode):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlagsAfterLayout):
(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::clippingChanged):
(WebCore::styleAffectsLayerGeometry):
(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::RenderLayerCompositor::needsCompositingUpdateForStyleChangeOnNonCompositedLayer const):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
(WebCore::RenderLayerCompositor::layerWasAdded):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer const):
(WebCore::RenderLayerCompositor::computeExtent const):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::rootLayerConfigurationChanged):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::needsToBeComposited const):
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::clippedByAncestor const):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform const):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo const):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters const):
(WebCore::RenderLayerCompositor::requiresCompositingForWillChange const):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin const):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame const):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
(WebCore::RenderLayerCompositor::styleChangeMayAffectIndirectCompositingReasons):
(WebCore::RenderLayerCompositor::fixedLayerIntersectsViewport const):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::rootOrBodyStyleChanged):
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
(WebCore::operator<<):
(WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): Deleted.
(WebCore::checkIfDescendantClippingContextNeedsUpdate): Deleted.
(WebCore::isScrollableOverflow): Deleted.
(WebCore::styleHasTouchScrolling): Deleted.
(WebCore::styleChangeRequiresLayerRebuild): Deleted.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Deleted.
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged): Deleted.
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Deleted.
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): Deleted.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

Source/WebKitLegacy/mac:

Fix spelling error.

  • WebView/WebView.mm:

(-[WebView _setMediaLayer:forPluginView:]):

LayoutTests:

Add some new tests for issues discovered during development.

Filter tests get new results because composited layer bounds are no longer affected
by pixel-moving filters.

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
  • compositing/geometry/stacking-context-change-layer-reparent-expected.html: Added.
  • compositing/geometry/stacking-context-change-layer-reparent.html: Added.
  • compositing/layer-creation/change-to-overlap-expected.txt: Added.
  • compositing/layer-creation/change-to-overlap.html: Added.
  • compositing/updates/no-updates-in-non-composited-iframe-expected.txt: Added.
  • compositing/updates/no-updates-in-non-composited-iframe.html: Added.
  • compositing/updates/resources/non-composited.html: Added.
  • compositing/video/video-clip-change-src.html: This test was timing-sensitive; the behavior differed bases on whether we

happened to do a compositing flush between the first and second video load.

  • platform/mac-wk1/TestExpectations: Mark compositing/layer-creation/fixed-overlap-extent.html as flakey; it depends on the

timing of various AppKit-related things that aren't consistent.

8:49 AM Changeset in webkit [238089] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CSSCalcOperation constructor wastes 6KB of Vector capacity on cnn.com
​https://bugs.webkit.org/show_bug.cgi?id=190839

Patch by Rob Buis <​rbuis@igalia.com> on 2018-11-12
Reviewed by Frédéric Wang.

The CSSCalcOperation ctor that takes a leftSide and rightSide parameter
wastes memory since it will always have size 2 but claims the
default Vector size. So make sure to reserve an initial capacity of 2.

  • css/CSSCalculationValue.cpp:
8:48 AM Changeset in webkit [238088] by yusukesuzuki@slowstart.org
  • 5 edits in trunk/Source/WebCore

WTFMove(xxx) is used in arguments while other arguments touch xxx
​https://bugs.webkit.org/show_bug.cgi?id=191544

Reviewed by Alex Christensen.

The order of the evaluation of C++ arguments is undefined. If we use WTFMove(xxx),
xxx should not be touched in the other arguments. This patch fixes such uses in
IDB code.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::scheduleOperation):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::registerObjectStore):

  • Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::registerIndex):

8:18 AM Changeset in webkit [238087] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC][IFC] Construct dedicated runs when the inline element requires it.
​https://bugs.webkit.org/show_bug.cgi?id=191509

Reviewed by Antti Koivisto.

In certain cases, a run can overlap multiple inline elements like this:

<span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span>

The content above generates one long run <normal text contentbut this one needs dedicated runend of text> <- input to line breaking.
However, since the middle run is positioned, it needs to be moved independently from the rest of the content, hence it needs a dedicated inline run.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::contentRequiresSeparateRun):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::postProcessInlineRuns const):
(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

  • layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::inlineFormattingState const):

  • layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::nextRun): mid-word breaking is not implemented yet.

  • layout/inlineformatting/InlineRun.h:

(WebCore::Layout::InlineRun::overlapsMultipleInlineItems const):

  • layout/inlineformatting/InlineRunProvider.cpp:

(WebCore::Layout::InlineRunProvider::processInlineTextItem):

  • layout/inlineformatting/InlineRunProvider.h:

(WebCore::Layout::InlineRunProvider::Run::TextContext::expand):
(WebCore::Layout::InlineRunProvider::Run::textContext):
(WebCore::Layout::InlineRunProvider::Run::TextContext::setStart): Deleted.
(WebCore::Layout::InlineRunProvider::Run::TextContext::setLength): Deleted.

7:12 AM Changeset in webkit [238086] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

[MSE] Frame re-ordering can cause iframes to never be enqueued
​https://bugs.webkit.org/show_bug.cgi?id=191485

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-dropped-iframe.html

Some frame re-ordering techniques result in files where the first frame has a
decode timestamp < 0, but a presentation timestamp >= 0. When appending these
samples to existing content, we can fail to enqueue the first frame because its
DTS overlaps an existing sample, but the presentation timestamp does not.
Rather than try to only enqueue samples whose decode timestamps are > than the
greatest decode end timestamp (minus some fudge factor), allow all frames to be
added to the decode queue if they are strictly ordered greater than the last
enqueued frame.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::provideMediaData):
(WebCore::SourceBuffer::reenqueueMediaForTime):

LayoutTests:

  • media/media-source/media-source-dropped-iframe-expected.txt: Added.
  • media/media-source/media-source-dropped-iframe.html: Added.
6:55 AM Changeset in webkit [238085] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/WebCore

IDBTransaction does not use "RefPtr<IDBTransaction> self"
​https://bugs.webkit.org/show_bug.cgi?id=190436

Reviewed by Alex Christensen.

It seems that RefPtr<IDBTransaction> self; is not effective since it does not capture anything.
Use protectedThis = makeRef(*this) instead.

No behavior change.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):

6:40 AM Changeset in webkit [238084] by aboya@igalia.com
  • 7 edits
    2 adds in trunk

[MSE][GStreamer] Introduce AbortableTaskQueue
​https://bugs.webkit.org/show_bug.cgi?id=190902

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

A new synchronization primitive is introduced: AbortableTaskQueue,
which allows to send work to the main thread from a background thread
with the option to perform two-phase cancellation (startAborting() and
finishAborting()).

This new primitive has been used to overhaul GstBus messaging in
AppendPipeline. A lot of code made redundant has been deleted in the
process and lots of internal functions were now able to be made
private. As part of the refactor all glib signals in AppendPipeline
now use lambdas. All usages of WTF::isMainThread() in AppendPipeline
have been replaced by isMainThread() for consistency with the rest of
WebKit.

Two-phase cancellation is still not used in AppendPipeline as of this
patch, but it will be used in a future patch that makes use of
GStreamer flushes to implement correct MSE abort semantics. There are
unit tests to ensure it works correctly, even if it's still not used.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/AbortableTaskQueue.h: Added.
  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::dumpAppendState):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe):
(WebCore::AppendPipeline::handleAppsinkNewSampleFromAnyThread):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::sourceBufferPrivate):
(WebCore::AppendPipeline::appsinkCaps):
(WebCore::AppendPipeline::track):
(WebCore::AppendPipeline::demuxerSrcPadCaps):
(WebCore::AppendPipeline::playerPrivate):

Tools:

Tests for AbortableTaskQueue are included.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::FancyResponse::FancyResponse):
(TestWebKitAPI::FancyResponse::operator=):
(TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
(TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):

4:40 AM Changeset in webkit [238083] by calvaris@igalia.com
  • 6 edits in trunk/Source/WebCore

[GStreamer][EME] waitingforkey event should consider decryptors' waiting status
​https://bugs.webkit.org/show_bug.cgi?id=191459

Reviewed by Carlos Garcia Campos.

The new cross platform architecture to report waitingforkey and
recover from it requires a more accurate knowledge of what is
going on with the decryptors because events are reported only once
(per key exchange run) and crossplatform only continues if we are
actually ready to continue, meaning that no decryptors are
waiting.

  • platform/graphics/gstreamer/GUniquePtrGStreamer.h: Added

GstIterator deleter.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::setWaitingForKey): Bail
out if we are requested to not wait anymore but there are still
waiting decryptors.
(WebCore::MediaPlayerPrivateGStreamerBase::waitingForKey const):
Query the pipeline, just a query after pipeline is built and
manual inspection during build. The query is optimal but sometimes
we can get this request when the pipeline is under construction so
queries do not arrive at the decryptors and we have to deliver it
by ourselves.
(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(WebCore::MediaPlayerPrivateGStreamerBase::reportWaitingForKey:
Deleted because it is now inlined.

  • platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webKitMediaClearKeyDecryptorDecrypt): Fixed small compiler warning.

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init): Override
query method.
(webkitMediaCommonEncryptionDecryptTransformInPlace): When the
decryptor is going to block to wait, report before. When the
decryptor receives the key, report it got it.
(webkitMediaCommonEncryptionDecryptSinkEventHandler): Do not
handle waitingforkey here.
(webkitMediaCommonEncryptionDecryptorQueryHandler): Report if the
decryptor is waiting.

1:05 AM Changeset in webkit [238082] by Michael Catanzaro
  • 4 edits in trunk/Source/WebCore

[GTK] Silence ATK_XY_PARENT warnings
​https://bugs.webkit.org/show_bug.cgi?id=191504

Reviewed by Carlos Garcia Campos.

  • accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:

(atkToContents):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(textExtents):

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(contentsRelativeToAtkCoordinateType):

Nov 11, 2018:

6:00 PM Changeset in webkit [238081] by Fujii Hironori
  • 2 edits in trunk/Tools

run-bindings-tests is timing out in some WinCairo bots
​https://bugs.webkit.org/show_bug.cgi?id=191348

Reviewed by Alex Christensen.

BuildBot kills run-bindings-tests if it outputs nothing for 20
minutes. run-bindings-tests runs very slowly in WinCairo Docker,
and it takes more than 30 minutes to finish. And, Windows Python
buffers the progress output.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.detect_changes): Call sys.stdout.flush() after the
test case result is output.

5:39 PM Changeset in webkit [238080] by Wenson Hsieh
  • 18 edits
    5 adds in trunk

Implement a new edit command to change the enclosing list type
​https://bugs.webkit.org/show_bug.cgi?id=191487
<rdar://problem/45955922>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for a new edit command that changes the type of the enclosing list element around the selection from
unordered to ordered list and vice versa. This new edit command is exposed only to internal WebKit2 clients, via
SPI on WKWebView (-_changeListType:).

This is currently intended for use in Mail compose, but may also be adopted by legacy Notes in the future. As
such, the behavior of this editing command mostly matches shipping behavior in Mail compose (which is currently
implemented entirely by Mail). See below for more details.

Test: editing/execCommand/change-list-type.html

WKWebViewEditActions.ChangeListType

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/ChangeListTypeCommand.cpp: Added.

(WebCore::listConversionTypeForSelection):
(WebCore::ChangeListTypeCommand::listConversionType):

Helper that returns a potential list conversion command that may be executed at the given document's selection,
if any exists. We also use existing logic from Mail here to determine which list to change, by walking up the
DOM from the lowest common ancestor container of the current selection until we hit the first list element.

(WebCore::ChangeListTypeCommand::createNewList):

Helper method to create a new list element to replace the given list, and then clone element data from the given
list to the new list. This addresses an existing bug in Mail, wherein changing list type for an enclosing list
which contains inline style properties drops the inline styles, because existing logic in Mail that implements
this editing command only copies the class attribute of the old list to the new list.

(WebCore::ChangeListTypeCommand::doApply):

Apply the edit command by running the following steps:

  • Find the enclosing list element, if any (see above).
  • Create a new list element of the opposite type as the enclosing list, and clone over element data from the

list element being replaced.

  • Insert the new list next to the original list.
  • Move all children of the original list to the new list.
  • Remove the original list.
  • Set the selection to the end of the new list.
  • editing/ChangeListTypeCommand.h: Added.
  • editing/EditAction.h:

Add a pair of new edit actions for conversion from unordered list to ordered list and vice versa.

  • editing/Editor.cpp:

(WebCore::Editor::changeSelectionListType):

Implement this by creating and applying a new ChangeListTypeCommand.

(WebCore::Editor::canChangeSelectionListType): Deleted.

Remove this for now, since there's no need for it until full support for edit command validation is implemented.

  • editing/Editor.h:
  • testing/Internals.cpp:

(WebCore::Internals::changeSelectionListType):

  • testing/Internals.h:
  • testing/Internals.idl:

Add internal hooks to change list type from layout tests.

Source/WebKit:

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Remove preflight checks for these list editing commands. These are not necessary because these commands fall
back to being noops if these checks return false. This avoids an extraneous ancestor walk to determine the
enclosing list element when changing list type.

Source/WebKitLegacy/mac:

Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.

  • WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Tools:

Add a new API test to verify that -[WKWebView _changeListType:] is hooked up to the corresponding editing
command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(-[TestWKWebView setPosition:offset:]):
(-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
(TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.

LayoutTests:

Add a new layout test to verify that the list change type editing command can be used to swap between enclosing
ordered and unordered lists. Also exercises undo, redo, changing list types under pre and table elements,
and handling selection within nested list elements.

  • editing/execCommand/change-list-type-expected.txt: Added.
  • editing/execCommand/change-list-type.html: Added.
2:22 PM Changeset in webkit [238079] by jfernandez@igalia.com
  • 29 edits
    73 adds
    3 deletes in trunk/LayoutTests

[css-grid] Import additional grid layout test from the WPT suite
​https://bugs.webkit.org/show_bug.cgi?id=191369

Reviewed by Manuel Rego Casasnovas.

New Grid Layout tests from the WPT suite.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/css/css-grid/META.yml: Added.
  • web-platform-tests/css/css-grid/OWNERS: Removed.
  • web-platform-tests/css/css-grid/abspos/support/grid.css:

(.thirdRowThirdColumn):

  • web-platform-tests/css/css-grid/abspos/support/w3c-import.log:
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008.html: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003.html: Added.
  • web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:
  • web-platform-tests/css/css-grid/alignment/support/style-change.js:

(evaluateStyleChangeMultiple):

  • web-platform-tests/css/css-grid/alignment/support/w3c-import.log:
  • web-platform-tests/css/css-grid/alignment/test-expected.txt: Added.
  • web-platform-tests/css/css-grid/alignment/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-definition/support/grid.css:

(.thirdRowThirdColumn):

  • web-platform-tests/css/css-grid/grid-definition/support/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-items/anonymous-grid-item-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html: Added.
  • web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/item-with-table-with-infinite-max-intrinsic-width.html: Added.
  • web-platform-tests/css/css-grid/grid-items/support/grid.css:

(.thirdRowThirdColumn):

  • web-platform-tests/css/css-grid/grid-items/support/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-items/table-with-infinite-max-intrinsic-width.html: Added.
  • web-platform-tests/css/css-grid/grid-items/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002-expected.html: Added.
  • web-platform-tests/css/css-grid/grid-model/grid-container-ignores-first-letter-002.html: Added.
  • web-platform-tests/css/css-grid/grid-model/support/grid.css:

(.thirdRowThirdColumn):

  • web-platform-tests/css/css-grid/grid-model/support/w3c-import.log:
  • web-platform-tests/css/css-grid/grid-model/w3c-import.log:
  • web-platform-tests/css/css-grid/implicit-grids/w3c-import.log:
  • web-platform-tests/css/css-grid/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-grid/inheritance.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-filled-shrinkwrap-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-cols-spanned-shrinkwrap-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-filled-shrinkwrap-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001-expected.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/grid-percent-rows-spanned-shrinkwrap-001.html: Added.
  • web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
  • web-platform-tests/css/css-grid/parsing/grid-area-invalid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-area-invalid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-area-valid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-area-valid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-columns-invalid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-columns-valid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-flow-invalid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-flow-valid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-rows-invalid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-auto-rows-valid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid.html: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-areas-valid-expected.txt: Added.
  • web-platform-tests/css/css-grid/parsing/grid-template-areas-valid.html: Added.
  • web-platform-tests/css/css-grid/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-grid/placement/w3c-import.log:
  • web-platform-tests/css/css-grid/test-plan/w3c-import.log:
  • web-platform-tests/css/css-grid/w3c-import.log:
  • web-platform-tests/css/support/META.yml: Added.
  • web-platform-tests/css/support/OWNERS: Removed.
  • web-platform-tests/css/support/computed-testcommon.js: Added.

(test_computed_value):

  • web-platform-tests/css/support/grid.css:

(.thirdRowThirdColumn):

  • web-platform-tests/css/support/inheritance-testcommon.js: Added.

(assert_initial):

  • web-platform-tests/css/support/parsing-testcommon.js: Added.

(test_valid_value):

  • web-platform-tests/css/support/support/w3c-import.log:
  • web-platform-tests/css/support/w3c-import.log:

LayoutTests:

  • TestExpectations: Added bugs and ImageOnlyFailure for 3 tests that are failing.
1:32 PM Changeset in webkit [238078] by dbates@webkit.org
  • 38 edits in trunk

[iOS] Draw caps lock indicator in password fields
​https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Source/WebCore:

Reviewed by Dean Jackson.

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac.

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

  • WebCore.xcodeproj/project.pbxproj:
  • page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().

  • page/EventHandler.h:
  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.

  • platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:

(+[WebEvent modifierFlags]): Added.

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.

  • rendering/RenderThemeCocoa.h:
  • rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Reviewed by Dean Jackson.

Forward declare some more SPI.

  • pal/spi/ios/GraphicsServicesSPI.h:
  • pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Reviewed by Dean Jackson.

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Reviewed by Dean Jackson.

Update the caps lock state when a hardware keyboard is attached or detached.

  • WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Reviewed by Dean Jackson.

Expose some more symbols.

  • WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:

LayoutTests:

Unreviewed.

Update expected results now that iOS supports showing the caps lock indictor.

  • platform/ios/fast/css/text-overflow-input-expected.txt:
  • platform/ios/fast/forms/basic-inputs-expected.txt:
  • platform/ios/fast/forms/input-appearance-height-expected.txt:
  • platform/ios/fast/forms/input-value-expected.txt:
  • platform/ios/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/ios/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
1:29 PM Changeset in webkit [238077] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC][BFC] In-flow positioned logic is really formatting context dependent.
​https://bugs.webkit.org/show_bug.cgi?id=191512

Reviewed by Simon Fraser.

Move block formatting context specific code from FormattingContext to BlockFormattingContext.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
12:00 PM Changeset in webkit [238076] by mitz@apple.com
  • 4 edits
    1 add in trunk

ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=191514

Reviewed by Geoffrey Garen.

Source/WebKit:

Test: WebKitCocoa/WKProcessPoolConfiguration.mm

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.

(TEST):

9:13 AM Changeset in webkit [238075] by mmaxfield@apple.com
  • 6 edits in trunk

Address post-review comments after r237955
​https://bugs.webkit.org/show_bug.cgi?id=191496

Reviewed by Darin Adler.

Source/WebCore:

  • rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

  • style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):

  • style/InlineTextBoxStyle.h:

LayoutTests:

  • fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:
12:27 AM Changeset in webkit [238074] by benjamin@webkit.org
  • 34 edits
    1 move in trunk

Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
​https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename file.

  • API/JSValue.mm:

Source/WebCore:

Rename file.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/URLMac.mm:
  • platform/mac/WebCoreNSURLExtras.mm:
  • platform/mac/WebCoreObjCExtras.mm:
  • rendering/RenderThemeMac.mm:

Source/WebKit:

  • Platform/mac/StringUtilities.mm:
  • UIProcess/ApplicationStateTracker.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

  • Carbon/HIWebView.mm:
  • Misc/WebNSFileManagerExtras.mm:
  • Misc/WebNSURLExtras.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebCachedFramePlatformData.h:
  • WebCoreSupport/WebDeviceOrientationClient.mm:
  • WebView/WebDelegateImplementationCaching.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebPDFRepresentation.mm:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebView.mm:

Tools:

Update file name.

  • DumpRenderTree/mac/DumpRenderTree.mm:
  • WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
  • WebKitTestRunner/mac/TestControllerMac.mm:

Nov 10, 2018:

10:16 PM Changeset in webkit [238073] by benjamin@webkit.org
  • 35 edits
    1 move in trunk

Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
​https://bugs.webkit.org/show_bug.cgi?id=191492

Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • API/JSValue.mm:

Source/WebCore:

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/URLMac.mm:
  • platform/mac/WebCoreNSURLExtras.mm:
  • platform/mac/WebCoreObjCExtras.mm:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const):

Source/WebKit:

  • Platform/mac/StringUtilities.mm:
  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::applicationDidEnterBackground):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):
(WebKit::ApplicationStateTracker::applicationWillEnterForeground):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

Source/WebKitLegacy/mac:

  • Carbon/HIWebView.mm:

(UpdateCommandStatus):

  • Misc/WebNSFileManagerExtras.mm:
  • Misc/WebNSURLExtras.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebPluginContainerCheck.mm:

(-[WebPluginContainerCheck _continueWithPolicy:]):

  • WebCoreSupport/WebCachedFramePlatformData.h:

(WebCachedFramePlatformData::clear):

  • WebCoreSupport/WebDeviceOrientationClient.mm:

(WebDeviceOrientationClient::getProvider const):

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallDelegateReturningBoolean):
(CallResourceLoadDelegateReturningBoolean):
(CallFormDelegate):
(CallFormDelegateReturningBoolean):

  • WebView/WebHTMLView.mm:
  • WebView/WebPDFRepresentation.mm:
  • WebView/WebPolicyDelegate.mm:

(-[WebPolicyDecisionListener _usePolicy:]):

  • WebView/WebView.mm:

Source/WTF:

Because renaming ObjcRuntimeExtras.h to ObjCRuntimeExtras.h only changes
the cases, some systems have issues with applying this patch.

To work around the problem, the change is made is two patches, first rename to
WTFObjCRuntimeExtras.h, then back to ObjCRuntimeExtras.h.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/WTFObjCRuntimeExtras.h: Renamed from Source/WTF/wtf/ObjcRuntimeExtras.h.

(wtfObjCMsgSend):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:
  • WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
  • WebKitTestRunner/mac/TestControllerMac.mm:
10:13 PM Changeset in webkit [238072] by Megan Gardner
  • 2 edits in trunk/Source/WebCore

Fix build for 32bit Mac
​https://bugs.webkit.org/show_bug.cgi?id=191511

Unreviewed Build Fix.

Build fix, not tests needed.

Make the apporiate delecrations for 32-bit mac support.

  • editing/mac/DictionaryLookup.mm:
4:26 PM Changeset in webkit [238071] by Simon Fraser
  • 36 edits
    128 deletes in trunk

Remove support for -webkit-svg-shadow
​https://bugs.webkit.org/show_bug.cgi?id=187429
Source/WebCore:

<rdar://problem/41920735>

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSProperties.json:
  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::svgPropertyValue):

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitSvgShadow): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitSvgShadow): Deleted.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::didAttachChild):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::RenderSVGModelObject):

  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::hasSVGShadow const): Deleted.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Deleted.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::updateCachedBoundaries):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateRepaintBoundingBox):

  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::styleChanged):
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Deleted.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Deleted.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Deleted.
(WebCore::SVGRenderSupport::childAdded): Deleted.

  • rendering/svg/SVGRenderSupport.h:

LayoutTests:

Reviewed by Dean Jackson.

-webkit-svg-shadow was a non-standard hack for online iWork, and they no longer use it,
so remove it. No other browser supports it, and chromestatus say it's used on less than
0.000001% of pages.

  • css3/blending/svg-blend-layer-shadow.html: Removed.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/repaint/moving-shadow-on-container-expected.png: Removed.
  • fast/repaint/moving-shadow-on-container.html: Removed.
  • fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • fast/repaint/moving-shadow-on-path.html: Removed.
  • legacy-animation-engine/fast/css/getComputedStyle/resources/property-names.js:
  • platform/gtk/TestExpectations:
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/gtk/svg/css/arrow-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/composite-shadow-example-expected.png: Removed.
  • platform/gtk/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
  • platform/gtk/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.png: Removed.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/gtk/svg/css/group-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/shadow-changes-expected.png: Removed.
  • platform/gtk/svg/css/shadow-changes-expected.txt: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.png: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
  • platform/gtk/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/gtk/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
  • platform/gtk/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
  • platform/ios/TestExpectations:
  • platform/ios/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
  • platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/ios/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/ios/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/ios/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • platform/ios/svg/css/getComputedStyle-basic-expected.txt:
  • platform/ios/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/ios/svg/css/shadow-changes-expected.txt: Removed.
  • platform/ios/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/ios/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
  • platform/mac-sierra/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac-sierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac-sierra/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/css3/blending/svg-blend-layer-shadow-expected.png: Removed.
  • platform/mac/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/mac/svg/css/arrow-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/clippath-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/composite-shadow-example-expected.png: Removed.
  • platform/mac/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Removed.
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/svg/css/group-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/mac/svg/css/mask-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/path-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/shadow-and-opacity-expected.png: Removed.
  • platform/mac/svg/css/shadow-changes-expected.png: Removed.
  • platform/mac/svg/css/shadow-changes-expected.txt: Removed.
  • platform/mac/svg/css/shadow-with-large-radius-expected.png: Removed.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png: Removed.
  • platform/mac/svg/css/stars-with-shadow-expected.png: Removed.
  • platform/mac/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
  • platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
  • platform/mac/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
  • platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Removed.
  • platform/win/TestExpectations:
  • platform/win/css3/blending/svg-blend-layer-shadow-expected.txt: Removed.
  • platform/win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/win/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/win/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/win/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/win/svg/css/shadow-changes-expected.txt: Removed.
  • platform/win/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/wincairo/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/wincairo/fast/repaint/moving-shadow-on-path-expected.png: Removed.
  • platform/wincairo/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/wincairo/svg/css/shadow-changes-expected.txt: Removed.
  • platform/wincairo/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
  • platform/wpe/svg/css/composite-shadow-text-expected.txt: Removed.
  • platform/wpe/svg/css/shadow-changes-expected.txt: Removed.
  • platform/wpe/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/wpe/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/wpe/svg/custom/transform-with-shadow-and-gradient-expected.txt: Removed.
  • svg/css/arrow-with-shadow-expected.txt: Removed.
  • svg/css/arrow-with-shadow.svg: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow.svg: Removed.
  • svg/css/clippath-with-shadow-expected.png: Removed.
  • svg/css/clippath-with-shadow-expected.txt: Removed.
  • svg/css/clippath-with-shadow.svg: Removed.
  • svg/css/composite-shadow-example-expected.txt: Removed.
  • svg/css/composite-shadow-example.html: Removed.
  • svg/css/composite-shadow-text-expected.png: Removed.
  • svg/css/composite-shadow-text.svg: Removed.
  • svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/css/composite-shadow-with-opacity.html: Removed.
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow-expected.txt: Removed.
  • svg/css/group-with-shadow.svg: Removed.
  • svg/css/mask-with-shadow-expected.txt: Removed.
  • svg/css/mask-with-shadow.svg: Removed.
  • svg/css/parent-shadow-offscreen-expected.svg: Removed.
  • svg/css/parent-shadow-offscreen.svg: Removed.
  • svg/css/path-with-shadow-expected.png: Removed.
  • svg/css/path-with-shadow-expected.txt: Removed.
  • svg/css/path-with-shadow.svg: Removed.
  • svg/css/root-shadow-offscreen-expected.svg: Removed.
  • svg/css/root-shadow-offscreen.svg: Removed.
  • svg/css/shadow-and-opacity-expected.txt: Removed.
  • svg/css/shadow-and-opacity.svg: Removed.
  • svg/css/shadow-changes.svg: Removed.
  • svg/css/shadow-with-large-radius-expected.png: Removed.
  • svg/css/shadow-with-large-radius-expected.txt: Removed.
  • svg/css/shadow-with-large-radius.svg: Removed.
  • svg/css/shadow-with-negative-offset-expected.png: Removed.
  • svg/css/shadow-with-negative-offset-expected.txt: Removed.
  • svg/css/shadow-with-negative-offset.svg: Removed.
  • svg/css/stars-with-shadow-expected.txt: Removed.
  • svg/css/stars-with-shadow.html: Removed.
  • svg/custom/simple-text-double-shadow-expected.png: Removed.
  • svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • svg/custom/simple-text-double-shadow.svg: Removed.
  • svg/custom/transform-with-shadow-and-gradient.svg: Removed.
  • svg/filters/shadow-on-filter-expected.txt: Removed.
  • svg/filters/shadow-on-filter.svg: Removed.
  • svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
  • svg/filters/shadow-on-rect-with-filter.svg: Removed.
  • svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Removed.
  • svg/repaint/repaint-webkit-svg-shadow-container.html: Removed.
  • svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
  • svg/repaint/repaint-webkit-svg-shadow.svg: Removed.
1:01 PM Changeset in webkit [238070] by Ryan Haddad
  • 50 edits
    7 deletes in trunk

Unreviewed, rolling out r238065.

Breaks internal builds.

Reverted changeset:

"Make it possible to edit images inline"
​https://bugs.webkit.org/show_bug.cgi?id=191352
​https://trac.webkit.org/changeset/238065

12:12 PM Changeset in webkit [238069] by Michael Catanzaro
  • 2 edits in trunk/Tools

[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
​https://bugs.webkit.org/show_bug.cgi?id=191221

Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
that it is disabled, but we're testing that it is enabled, because I failed to update this
line.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

11:52 AM Changeset in webkit [238068] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, fix typo in r238066.

  • accessibility/ios-simulator/form-control-validation-message.html:
11:27 AM Changeset in webkit [238067] by Michael Catanzaro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, silence -Wunused-variable warning

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

9:43 AM Changeset in webkit [238066] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed attempt to deflake accessibility/ios-simulator/form-control-validation-message.html

  • accessibility/ios-simulator/form-control-validation-message.html:
1:58 AM Changeset in webkit [238065] by timothy_horton@apple.com
  • 50 edits
    11 adds in trunk

Make it possible to edit images inline
​https://bugs.webkit.org/show_bug.cgi?id=191352
<rdar://problem/30107985>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: editing/images/basic-editable-image.html

editing/images/reparent-editable-image-maintains-strokes.html

Add the beginnings of a mechanism to replace images with a special attribute
with a native drawing view in the UI process.

  • page/Settings.yaml:

Add a setting to control whether images become natively editable when they
have the x-apple-editable-image attribute.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::editableImageViewID const):
Lazily generate an EmbeddedViewID and persist it on the <img> element.

  • html/HTMLImageElement.h:

Rearrange the service controls methods to sit before the members.
Add m_editableImageViewID and editableImageViewID().

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToEmbeddedView):
Add a new ContentsLayerPurpose, EmbeddedView, which is only supported
on Cocoa platforms and when using RemoteLayerTree.
Add ContentsLayerEmbeddedViewType, which currently only has the EditableImage type.
Add setContentsToEmbeddedView, which takes a ContentsLayerEmbeddedViewType
and an EmbeddedViewID to uniquely identify and communicate about the
embedded view (which may move between layers, since it is tied to an element).

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView):
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView):
When setting GraphicsLayer's contents to an embedded view, we use
a special PlatformCALayer factory that takes the EmbeddedViewID and type.
GraphicsLayerCARemote will override this and make a correctly-initialized
PlatformCALayerRemote that keeps track of the EmbeddedViewID.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const):
Add stubs and logging for EmbeddedViewID on PlatformCALayer.
These will be overridden by PlatformCALayerRemote to do more interesting things.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const):
Add a getter that return true if the setting is enabled and
x-apple-editable-image is empty or true.

(WebCore::RenderImage::requiresLayer const):
RenderImage requires a layer either if RenderReplaced does, or we are an
editable image.

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
Push the EmbeddedViewID and type down to GraphicsLayer for editable images.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const):

  • rendering/RenderLayerCompositor.h:

Make editable images require compositing implicitly.

Source/WebKit:

  • Platform/spi/ios/PencilKitSPI.h: Added.
  • Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

  • WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView):

  • WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView):
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
(WebKit::PlatformCALayerRemote::embeddedViewID const):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Propagate EmbeddedViewID through the PlatformCALayer constructor and
through the layer creation parameters to the UI process.

  • Shared/WebPreferences.yaml:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]):
(-[WKWebViewConfiguration _editableImagesEnabled]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a preference to enable editable images.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::createLayer):
Keep track of "embedded views" in two maps: embeddedViewID->UIView,
and layerID->embeddedViewID. Clean them up when layers go away.
If a embedded view is reparented, currently it must be added to a new
layer in the same commit as it is removed from the previous layer
in order to persist the view's state (otherwise the view will be
destroyed and recreated). This will be less of a problem after future
patches introduce serialization of image data and whatnot.

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
Move the various remote layer tree UIView subclasses out into a separate file.

Add createEmbeddedView, which is used for LayerTypeEditableImageLayer,
and creates a WKDrawingView and sticks it in the maps.

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: Added.
  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: Added.

(-[UIView _web_recursiveFindDescendantInteractibleViewAtPoint:withEvent:]):
(-[UIView _web_findDescendantViewAtPoint:withEvent:]):
(-[WKCompositingView hitTest:withEvent:]):
(-[WKCompositingView description]):
(+[WKTransformView layerClass]):
(+[WKSimpleBackdropView layerClass]):
(+[WKShapeView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(-[WKBackdropView hitTest:withEvent:]):
(-[WKBackdropView description]):
(-[WKChildScrollView initWithFrame:]):
Move various remote layer tree UIView subclasses here, to their own file.
Make our UIView hit testing override test for views that conform to the
protocol "WKNativelyInteractible", which switches to normal UIView hit
testing. WKDrawingView will be the one such view.

Add WKChildScrollView and pull the one thing we customize out into it,
to make RemoteLayerTreeHost::createLayer less logic-ful.

  • UIProcess/ios/WKDrawingView.h: Added.
  • UIProcess/ios/WKDrawingView.mm: Added.

(-[WKDrawingView init]):
(-[WKDrawingView layoutSubviews]):
Add a very simple WKDrawingView, which uses PKCanvasView to edit the image.

  • WebKit.xcodeproj/project.pbxproj:
  • SourcesCocoa.txt:

Add the new files.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):
Add a test option to enable editable images.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • TestRunnerShared/spi/PencilKitTestSPI.h: Added.
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::findEditableImageCanvas):
(WTR::UIScriptController::drawSquareInEditableImage):
(WTR::UIScriptController::numberOfStrokesInEditableImage):
Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
and also to retrieve the number of strokes currently on the PKCanvasView.
Currently this just takes the first canvas; we might need to make it
take an identifier or something in the future if we need tests with multiple
canvases. The indirect testing mechanism is required because PKCanvasView
can currently not actually paint its strokes in the Simulator.

LayoutTests:

  • TestExpectations:
  • editing/images/basic-editable-image-expected.txt: Added.
  • editing/images/basic-editable-image.html: Added.
  • editing/images/reparent-editable-image-maintains-strokes-expected.txt: Added.
  • editing/images/reparent-editable-image-maintains-strokes.html: Added.
  • platform/ios-wk2/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage):
(window.UIHelper.numberOfStrokesInEditableImage):
(window.UIHelper):
Add tests that we can find and draw in editable images, and that if
the element is moved around in the DOM, it persists its strokes.

Nov 9, 2018:

10:39 PM Changeset in webkit [238064] by Alan Bujtas
  • 17 edits in trunk/Source

[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
​https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

  1. Improve visuallyNonEmpty milestone confidence level.

Ignore whitespace and non visible text content.
Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
Check if the html/body is actually visible.

  1. Issue initial paint soon after the milestone fires.

Use a 0ms timer to flush the initial paint.
Throttle additional flushes for 500ms and 1.5s (original behaviour).

  1. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint.
  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):

  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):

  • page/FrameView.h:

(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.

  • platform/graphics/FontCascade.h:
  • rendering/RenderText.cpp: Check whether the text is actually visible at this point.

(WebCore::RenderText::RenderText):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):

  • WebProcess/WebPage/AcceleratedDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

8:50 PM Changeset in webkit [238063] by wilander@apple.com
  • 18 edits in trunk/Source

Add ability to configure document.cookie lifetime cap through user defaults
​https://bugs.webkit.org/show_bug.cgi?id=191480
<rdar://problem/45240871>

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. Existing test makes sure we don't regress.

This change makes the capped lifetime in seconds configurable through
user defaults.

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
(WebCore::NetworkStorageSession::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::filterCookies):
(WebCore::NetworkStorageSession::setCookiesFromDOM const):

Source/WebKit:

This change makes the capped lifetime in seconds configurable through
user defaults.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAgeCapForClientSideCookies):
(WebKit::NetworkProcess::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm:

(WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::setAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::didSetAgeCapForClientSideCookies):
(WebKit::NetworkProcessProxy::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

(WebKit::NetworkProcessProxy::didSetShouldCapLifetimeForClientSideCookies): Deleted.

Renamed didSetAgeCapForClientSideCookies().

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::setAgeCapForClientSideCookies):
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):
(WebKit::ResourceLoadStatisticsMemoryStore::didCreateNetworkProcess):

New function that handles all the things that need to be done when a network
process has been created.

  • UIProcess/ResourceLoadStatisticsMemoryStore.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::didCreateNetworkProcess):

Now just calls the corresponding function on its memory store where all the
configuration parameters are available.

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setAgeCapForClientSideCookies):
(WebKit::WebsiteDataStore::setShouldCapLifetimeForClientSideCookies): Deleted.

Renamed setAgeCapForClientSideCookies().

  • UIProcess/WebsiteData/WebsiteDataStore.h:
5:40 PM Changeset in webkit [238062] by Ryan Haddad
  • 31 edits in trunk

Unreviewed, rolling out r238047.

Introduced layout test failures on iOS simulator.

Reverted changeset:

"[iOS] Draw caps lock indicator in password fields"
​https://bugs.webkit.org/show_bug.cgi?id=190565
​https://trac.webkit.org/changeset/238047

4:24 PM Changeset in webkit [238061] by Chris Dumez
  • 11 edits in trunk

Suspended page persists even after back/forward list item is gone
​https://bugs.webkit.org/show_bug.cgi?id=191488
<rdar://problem/45953006>

Reviewed by Geoffrey Garen.

Source/WebKit:

Currently, the WebProcessPool owns the SuspendedPageProxy objects and makes sure we cap how
many we can have. The WebBackForwardListItem merely has a WeakPtr to its associated
SuspendedPageProxy. However, there is no point in having the WebProcessPool keeping a
SuspendedPageProxy object alive if there is no longer any WebBackForwardListItem pointing
to it.

To address the issue, WebBackForwardListItem nows tells the WebProcessPool to destroy
its SuspendedPageProxy when necessary. WebBackForwardList also takes care of nulling
out the WebBackForwardListItem's SuspendedPageProxy after the item has been removed
from the list (in case somebody keeps the item alive).

  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setSuspendedPage):
(WebKit::WebBackForwardListItem::suspendedPageIsNoLongerNeeded):

  • Shared/WebBackForwardListItem.h:
  • UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::removeSuspendedPageProxy):

  • UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3:10 PM Changeset in webkit [238060] by Megan Gardner
  • 1 edit
    1 copy
    1 add
    1 delete in trunk/LayoutTests

Fix Test Expectations for Reveal Test
​https://bugs.webkit.org/show_bug.cgi?id=191476

Unreviewed test gardening.

Put the test expectation in the correct location to deal with
the different behaviour old platforms.

  • platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac-highsierra/editing/mac/selection/context-menu-select-editability-expected.txt.
3:04 PM Changeset in webkit [238059] by Ross Kirsling
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed Windows build fix for r238049.

  • WebView.cpp:

(WebView::initWithFrame):

2:57 PM Changeset in webkit [238058] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

Normal-flow-only flex items don't correctly respect z-index
​https://bugs.webkit.org/show_bug.cgi?id=191486

Reviewed by Simon Fraser.

Source/WebCore:

Test: css3/flexbox/z-index-with-normal-flow-only.html

  • rendering/RenderLayer.cpp:

(WebCore::canCreateStackingContext):
r125693 did not ensure that flex items which would otherwise be
normal-flow-only would be put into the z-order tree when necessary.
Fix by respecting the same trigger we use to make layers for flex items;
namely, not having auto z-index.

LayoutTests:

  • css3/flexbox/z-index-with-normal-flow-only-expected.html: Added.
  • css3/flexbox/z-index-with-normal-flow-only.html: Added.

Add a test that a <canvas> with z-index 50 correctly stacks below
a <canvas> that is a flex-item with z-index 100.

2:50 PM Changeset in webkit [238057] by Wenson Hsieh
  • 7 edits in trunk

[Cocoa] Implement SPI on WKWebView to increase and decrease list levels
​https://bugs.webkit.org/show_bug.cgi?id=191471
<rdar://problem/45952472>

Reviewed by Tim Horton.

Source/WebCore:

Add new method stubs for changing the list type for the current selection (to be implemented in a future patch).

  • editing/Editor.cpp:

(WebCore::Editor::canChangeSelectionListType):
(WebCore::Editor::changeSelectionListType):

  • editing/Editor.h:

Source/WebKit:

Implement these method stubs by calling into Editor.

Test: WKWebViewEditActions.ModifyListLevel

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

Tools:

Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

2:34 PM Changeset in webkit [238056] by Jon Davis
  • 15 edits in trunk/Websites/webkit.org

Clean-up stray whitespace in theme files
​https://bugs.webkit.org/show_bug.cgi?id=191430

Reviewed by Dean Jackson.

  • wp-content/themes/webkit/css-status.php:
  • wp-content/themes/webkit/footer.php:
  • wp-content/themes/webkit/front-page.php:
  • wp-content/themes/webkit/includes.php:
  • wp-content/themes/webkit/nightly-start.php:
  • wp-content/themes/webkit/nightly-survey.php:
  • wp-content/themes/webkit/page.php:
  • wp-content/themes/webkit/scripts/global.js:
  • wp-content/themes/webkit/scripts/searchbuilds.js:

(initsearch):
(initsearch.displayError):

  • wp-content/themes/webkit/single.php:
  • wp-content/themes/webkit/sitemap.php:
  • wp-content/themes/webkit/team.php:
  • wp-content/themes/webkit/widgets/icon.php:
  • wp-content/themes/webkit/widgets/page.php:
2:32 PM Changeset in webkit [238055] by Keith Rollin
  • 6 edits in trunk/Source

Unreviewed build fix after ​https://bugs.webkit.org/show_bug.cgi?id=191324

Remove the use of .xcfilelists until their side-effects are better
understood.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
1:59 PM Changeset in webkit [238054] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk

SourceBuffer throws an error when appending a second init segment after changeType().
​https://bugs.webkit.org/show_bug.cgi?id=191474

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-changetype-second-init.html

When encountering an initialization segment after changeType(), add the parsed codec types
to the list of allowed codecs.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::validateInitializationSegment):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::supportsType):

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::canSwitchToType):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

  • media/media-source/media-source-changetype-second-init-expected.txt: Added.
  • media/media-source/media-source-changetype-second-init.html: Added.
1:26 PM Changeset in webkit [238053] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[MediaStream] AVVideoCaptureSource reports incorrect size when frames are scaled
​https://bugs.webkit.org/show_bug.cgi?id=191479
<rdar://problem/45952201>

Reviewed by Jer Noble.

No new tests, tested manually.

  • platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::standardVideoSizes): Drive-by fix: add a few more standard
video frame sizes, correct a typo.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate): Drive-by fix: don't consider
rescaled sized when we already have an exact or aspect ratio match because it won't be used.

  • platform/mediastream/mac/AVVideoCaptureSource.h:

(WebCore::AVVideoCaptureSource::width const): Deleted.
(WebCore::AVVideoCaptureSource::height const): Deleted.

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset): Delete m_requestedSize.
(WebCore::AVVideoCaptureSource::shutdownCaptureSession): Delete m_width and m_height.
(WebCore::AVVideoCaptureSource::processNewFrame): Don't call setSize with captured size,
the frame may be resized before deliver.

1:10 PM Changeset in webkit [238052] by Ross Kirsling
  • 6 edits in trunk/Source

Unreviewed MSVC build fix after r238039 (and r238046).

Source/WebCore:

  • bindings/js/JSWorkerGlobalScopeBase.cpp:
  • bindings/js/JSWorkerGlobalScopeBase.h:

Source/WebKitLegacy/win:

  • WebDocumentLoader.h:
  • WebView.cpp:

(WebView::setShouldApplyMacFontAscentHack):

12:43 PM Changeset in webkit [238051] by basuke.suzuki@sony.com
  • 28 edits
    3 copies
    3 adds in trunk

[Curl][WebKit] Implement Proxy configuration API.
​https://bugs.webkit.org/show_bug.cgi?id=189053

Reviewed by Youenn Fablet.

Source/WebCore:

Added API to set proxy from the app.

No new tests because there's no behaviour change in WebCore.

  • platform/network/NetworkStorageSession.h:
  • platform/network/curl/CurlContext.h:

(WebCore::CurlContext::setProxySettings):

  • platform/network/curl/CurlProxySettings.h:
  • platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setProxySettings const):

Source/WebKit:

Added proxy configuration API to WebsiteDataStore. Three API were added in WKWebsiteDataStoreRefCurl.h:

  • WKWebsiteDataStoreEnableDefaultNetworkProxySettings(WKWebsiteDataStoreRef)
  • WKWebsiteDataStoreEnableCustomNetworkProxySettings(WKWebsiteDataStoreRef, WKURLRef, WKStringRef ignoreHosts)
  • WKWebsiteDataStoreDisableNetworkProxySettings(WKWebsiteDataStoreRef)
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSessionCreationParameters.h:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

  • NetworkProcess/curl/NetworkProcessCurl.cpp:

(WebKit::NetworkProcess::setNetworkProxySettings):

  • NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

  • NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • PlatformWin.cmake:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/curl/WebCoreArgumentCodersCurl.cpp:

(IPC::ArgumentCoder<CurlProxySettings>::encode):
(IPC::ArgumentCoder<CurlProxySettings>::decode):

  • UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.

(WKWebsiteDataStoreEnableDefaultNetworkProxySettings):
(WKWebsiteDataStoreEnableCustomNetworkProxySettings):
(WKWebsiteDataStoreDisableNetworkProxySettings):

  • UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.h: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::networkProxySettings const):

  • UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp: Copied from Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp.

(WebKit::WebsiteDataStore::platformSetParameters):
(WebKit::WebsiteDataStore::setNetworkProxySettings):

Tools:

Added Proxy Settings dialog to call newly added API.

  • MiniBrowser/win/BrowserWindow.h:
  • MiniBrowser/win/Common.cpp:

(askProxySettings):
(askCredential):
(authDialogProc): Deleted.

  • MiniBrowser/win/Common.h:
  • MiniBrowser/win/DialogHelper.h: Added.

(Dialog::run):
(Dialog::doalogProc):
(Dialog::handle):
(Dialog::setup):
(Dialog::update):
(Dialog::validate):
(Dialog::updateOkButton):
(Dialog::command):
(Dialog::ok):
(Dialog::cancel):
(Dialog::close):
(Dialog::hDlg):
(Dialog::item):
(Dialog::setEnabled):
(Dialog::setText):
(Dialog::getText):
(Dialog::getTextLength):
(Dialog::RadioGroup::RadioGroup):
(Dialog::RadioGroup::set):
(Dialog::RadioGroup::get):
(Dialog::radioGroup):

  • MiniBrowser/win/MainWindow.cpp:

(MainWindow::WndProc):

  • MiniBrowser/win/MiniBrowserLib.rc:
  • MiniBrowser/win/MiniBrowserLibResource.h:
  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(createWKURL):
(WebKitBrowserWindow::WebKitBrowserWindow):
(WebKitBrowserWindow::updateProxySettings):
(WebKitBrowserWindow::loadURL):
(WebKitBrowserWindow::loadHTMLString):
(WebKitBrowserWindow::openProxySettings):

  • MiniBrowser/win/WebKitBrowserWindow.h:
  • MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:

(WebKitLegacyBrowserWindow::openProxySettings):

  • MiniBrowser/win/WebKitLegacyBrowserWindow.h:
12:16 PM Changeset in webkit [238050] by Wenson Hsieh
  • 12 edits
    1 move in trunk

[Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
​https://bugs.webkit.org/show_bug.cgi?id=191410
<rdar://problem/45898610>

Reviewed by Dean Jackson.

Source/WebKit:

Prefixes a few iOS-only SPI methods declared on WKWebView in r236867 with underscores, and also exposes some
more cross-platform Cocoa editing SPI. Once the unprefixed SPI methods are no longer used by internal clients,
these will need to be removed (see followup bug: webkit.org/b/191450). See below for more details.

Covered by new and existing API tests in WKWebViewEditActions.

  • UIProcess/API/Cocoa/WKWebView.mm:

Hoist the definition (and undefinition) of FORWARD_ACTION_TO_WKCONTENTVIEW to encompass both the WKWebView
implementation and the WKWebView (WKPrivate) implementation. This allows us to use this macro when implementing
SPI methods in the WKPrivate category, as well as methods that are part of the main WKWebView implementation.

(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):

Add forwarding for the new editing commands in -canPerformAction: and -targetForAction:.

(-[WKWebView _toggleStrikeThrough:]):
(-[WKWebView _increaseListLevel:]):
(-[WKWebView _decreaseListLevel:]):
(-[WKWebView _changeListType:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):

Add definitions for the new editing methods on WKWebView, using macros (WEBCORE_PRIVATE_COMMAND on macOS and
FORWARD_ACTION_TO_WKCONTENTVIEW on iOS) to help reduce the code duplication.

(-[WKWebView _pasteAsQuotation:]): Deleted.

Remove this method definition, which is now replaced by macros on iOS and macOS.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Introduce the new SPI to WKWebView (WKPrivate), and add FIXMEs to remove old, unprefixed variants of the SPI.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::increaseListLevel):
(WebKit::WebPageProxy::decreaseListLevel):
(WebKit::WebPageProxy::changeListType):

Add plumbing for these list editing commands.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _increaseListLevelForWebView:]):
(-[WKContentView _decreaseListLevelForWebView:]):
(-[WKContentView _changeListTypeForWebView:]):
(-[WKContentView _toggleStrikeThroughForWebView:]):
(-[WKContentView _setFontForWebView:sender:]):
(-[WKContentView _setFontSizeForWebView:sender:]):
(-[WKContentView _setTextColorForWebView:sender:]):
(-[WKContentView toggleStrikeThroughForWebView:]):
(-[WKContentView setFontForWebView:sender:]):
(-[WKContentView setFontSizeForWebView:sender:]):
(-[WKContentView setTextColorForWebView:sender:]):
(-[WKContentView canPerformActionForWebView:withSender:]):

Check for the new action selectors here, and additionally add validation for _pasteAsQuotation:. Let the
unprefixed versions of these methods simply call the prefixed versions (these method implementations will be
removed in a followup once doing so would not affect any clients of WebKit).

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add stubs for several list editing commands that are yet to be hooked up to WebCore. These will be implemented
in a future patch.

Tools:

Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
Additionally, add new API tests to verify that -_pasteAsQuotation: and -_insertNested(Un)OrderedList: are
hooked up to their respective editing commands.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.

(-[TestWKWebView querySelectorExists:]):
(-[TestWKWebView insertString:]):

Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
invoking the WKWebView directly on macOS and calling on the content view on iOS.

(TestWebKitAPI::webViewForEditActionTesting):
(TestWebKitAPI::TEST):

11:47 AM Changeset in webkit [238049] by Antti Koivisto
  • 48 edits
    1 move in trunk/Source

Use OptionSet for layout milestones
​https://bugs.webkit.org/show_bug.cgi?id=191470

Reviewed by Dean Jackson.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyFrameLoaderClient.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didReachLayoutMilestone):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::addPaintPendingMilestones):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::firePaintRelatedMilestonesIfNeeded):

  • page/FrameView.h:
  • page/LayoutMilestone.h: Copied from Source/WebCore/page/LayoutMilestones.h.

Renamed to appease WK2 IPC code generation.

  • page/LayoutMilestones.h: Removed.
  • page/Page.cpp:

(WebCore::Page::addLayoutMilestones):
(WebCore::Page::removeLayoutMilestones):
(WebCore::Page::isCountingRelevantRepaintedObjects const):

  • page/Page.h:

(WebCore::Page::requestedLayoutMilestones const):

Source/WebKit:

  • Shared/API/Cocoa/_WKRenderingProgressEventsInternal.h:

(renderingProgressEvents):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones const):
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didReachLayoutMilestone):

  • UIProcess/API/APINavigationClient.h:

(API::NavigationClient::renderingProgressDidChange):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient):

  • UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:

(pageRenderingProgressEvents):

  • UIProcess/API/Cocoa/WKWebView.mm:

(layoutMilestones):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::renderingProgressDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::listenForLayoutMilestones):
(WebKit::WebPageProxy::didLayoutForCustomContentProvider):
(WebKit::WebPageProxy::didReachLayoutMilestone):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

  • WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::didReachLayoutMilestone):
(API::InjectedBundle::PageLoaderClient::layoutMilestones const):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone):
(WebKit::InjectedBundlePageLoaderClient::layoutMilestones const):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
(WebKit::WebPage::listenForLayoutMilestones):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::sendPendingNewlyReachedLayoutMilestones):
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

  • WebView/WebView.mm:

(coreLayoutMilestones):
(kitLayoutMilestones):
(-[WebView _cacheFrameLoadDelegateImplementations]):

  • WebView/WebViewInternal.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

  • WebCoreSupport/WebFrameLoaderClient.h:
11:23 AM Changeset in webkit [238048] by Joseph Pecoraro
  • 25 edits in trunk/Source/WebInspectorUI

Web Inspector: Start moving toward better multi-target support
​https://bugs.webkit.org/show_bug.cgi?id=191345

Reviewed by Devin Rousso.

This change continues the move toward better multi-target support
by explicitly using explicit target agents in more places, and
converting generalized feature checks into target agnostic versions
that use the new InspectorBackend.domains, which does not vary based
on the connected targets / debuggable type.

I also audited uses of RuntimeAgent, ConsoleAgent, and DebuggerAgent
for better multi-target support since these agents should already
have complete multi-target support.

  • UserInterface/Protocol/Target.js:

(WI.Target.prototype.initialize):
Move explicitly to target.Agent feature checks with a known target.

  • UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Move explicitly to target.DebuggerAgent for feature checks with a known target.

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.initializeTarget):
Move explicitly to target.NetworkAgent for feature checks with a known target.

  • UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager.prototype.initializeTarget):
(WI.RuntimeManager.prototype.saveResult):

  • UserInterface/Protocol/RemoteObject.js:

(WI.RemoteObject.prototype.updatePreview):
(WI.RemoteObject.prototype.getDisplayablePropertyDescriptors):
(WI.RemoteObject.prototype.deprecatedGetDisplayableProperties):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype._createTypeTokenAnnotator):
(WI.SourceCodeTextEditor.prototype._createBasicBlockAnnotator):
Move explicitly to target.RuntimeAgent for feature checks with a known target.

  • UserInterface/Models/CSSCompletions.js:

(WI.CSSCompletions.initializeCSSCompletions):
Move explicitly to target.CSSAgent for feature checks with a known target.

  • UserInterface/Views/ContextMenuUtilities.js:

Use the DebuggerAgent from the target associated with the DOMNode's
remote object instead of assuming the main target.

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Update the ConsoleAgent setting on all targets that support it.

  • UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView):
All backends support BreakpointActionType, the assertion can go away.

  • UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.get navigationItems):

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get navigationItems):
Include additional window.FooAgent checks for these since they will need
to be revisited in the future.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.get domains):
(InspectorBackendClass.prototype.activateDomain):
Expose InspectorBackend.domains.<Domain> for feature checking.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WI.BreakpointPopoverController.prototype._createPopoverContent):

  • UserInterface/Controllers/CSSManager.js:

(WI.CSSManager):
(WI.CSSManager.prototype._mainResourceDidChange):

  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._attemptAutoCapturingForFrame):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
(WI.TimelineManager):

  • UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingFinished):

  • UserInterface/Models/ScriptSyntaxTree.js:

(WI.ScriptSyntaxTree.functionReturnDivot):

  • UserInterface/Protocol/DebuggerObserver.js:

(WI.DebuggerObserver):

  • UserInterface/Protocol/NetworkObserver.js:

(WI.NetworkObserver.prototype.requestWillBeSent):

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel):
(WI.DebuggerSidebarPanel.prototype._handleCreateBreakpointClicked):

  • UserInterface/Views/NetworkTimelineView.js:

(WI.NetworkTimelineView):

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):

  • UserInterface/Views/WebSocketContentView.js:

(WI.WebSocketContentView):
(WI.NetworkManager.prototype.webSocketWillSendHandshakeRequest):
(WI.DebuggerManager.prototype.debuggerDidResume):
Feature check in a target agnostic way.

11:10 AM Changeset in webkit [238047] by dbates@webkit.org
  • 31 edits in trunk

[iOS] Draw caps lock indicator in password fields
​https://bugs.webkit.org/show_bug.cgi?id=190565
<rdar://problem/45262343>

Reviewed by Dean Jackson.

Source/WebCore:

Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password
fields on iOS more closely match the behavior of password fields on Mac. For now, we only draw the
indicator when caps locks is enabled via the hardware keyboard. We will look to support the software
keyboard in a subsequent commit (see <​https://bugs.webkit.org/show_bug.cgi?id=191475>).

The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS.
In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In
Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the
WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult
the store in the WebProcess. A smaller part of this patch is having both the legacy and modern
web views listen for keyboard availability changes so as to update the the caps lock state when
a hardware keyboard is detached or attached.

  • WebCore.xcodeproj/project.pbxproj:
  • page/EventHandler.cpp:

(WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent()
so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code.
(WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged().

  • page/EventHandler.h:
  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm.

  • platform/ios/KeyEventIOS.mm:

(WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state.
(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation.

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:

(+[WebEvent modifierFlags]): Added.

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.
(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared
by both Mac and iOS.

  • rendering/RenderThemeCocoa.h:
  • rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm.

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be
shared by both Mac and iOS.

Source/WebCore/PAL:

Forward declare some more SPI.

  • pal/spi/ios/GraphicsServicesSPI.h:
  • pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Notify the WebContent process with the current modifer state on window activation changes. Notify
the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached).

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications.
(-[WKWebView dealloc]): Unregister from hardware availability changed notifications.
(hardwareKeyboardAvailabilityChangedCallback): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware
keyboard flags changed event.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::hardwareKeyboardAvailabilityChanged):
Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have
one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged
so that we toggle visibility of the caps lock indicator.

Source/WebKitLegacy/mac:

Update the caps lock state when a hardware keyboard is attached or detached.

  • WebView/WebHTMLView.mm:

(hardwareKeyboardAvailabilityChangedCallback): Added.
(-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
(-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.

WebKitLibraries:

Expose some more symbols.

  • WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd:
11:04 AM Changeset in webkit [238046] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix WinCairo build after r238039.

  • bindings/js/JSWorkerGlobalScopeBase.h:
10:58 AM Changeset in webkit [238045] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit

Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
​https://bugs.webkit.org/show_bug.cgi?id=191449
<rdar://problem/45884977>

Reviewed by Eric Carlson.

UIRemoteView has some nice process assertion management that it would
be nice to not duplicate. So, we can just use it instead of CALayerHost!

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::page const):

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKUIRemoteView hitTest:withEvent:]):
(-[WKUIRemoteView description]):
(createRemoteView):
(WebKit::RemoteLayerTreeHost::createLayer):

10:42 AM Changeset in webkit [238044] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore

Extensions3DOpenGLES.h: warning: 'blitFramebuffer' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191451

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::setEXTContextLostCallback): Deleted unused method.

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Marked 'override'.
10:35 AM Changeset in webkit [238043] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit

[MediaStream] Make screen capture an experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=191472
<rdar://problem/45946499>

Reviewed by Jer Noble.

  • Shared/WebPreferences.yaml: Make ScreenCaptureEnabled an experimental feature.
10:27 AM Changeset in webkit [238042] by aestes@apple.com
  • 10 edits
    1 add in trunk

[Payment Request] canMakePayment() should not consider serialized payment method data
​https://bugs.webkit.org/show_bug.cgi?id=191432

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Added.

Source/WebCore:

In ​https://github.com/w3c/payment-request/pull/806, we're changing the specification of
canMakePayment() to not consider serialized payment method data when deciding if a payment
method is supported. For Apple Pay, this means we resolve to true for
"​https://apple.com/apple-pay", even if an ApplePayRequest is omitted or is missing required
fields.

Added test cases to
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html and
http/tests/paymentrequest/payment-request-show-method.https.html.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

  • http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
  • http/tests/paymentrequest/payment-request-canmakepayment-method.https.html: Updated with

changes from imported/w3c/web-platform-tests/payment-request/. Modified two tests to use
user_activation_test() rather than test_driver.bless().

  • http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
  • http/tests/paymentrequest/payment-request-show-method.https.html: Now that canMakePayment

does not convert payment method data, added a test that ensures show() rejects with a
TypeError when Apple Pay's payment method data is invalid.

  • platform/ios-wk2/TestExpectations: Un-skipped payment-request-canmakepayment-method.https.html.
  • platform/mac-wk2/TestExpectations: Ditto.
10:22 AM Changeset in webkit [238041] by aestes@apple.com
  • 7 edits in trunk

Source/WebCore:
[Payment Request] PaymentResponse.details should be updated when the user accepts a retried payment
​https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

PaymentResponse.details was being initialized in the PaymentResponse constructor and never
updated when the user accepts a retried payment. We need to update it.

Added a test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::accept):

  • Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::setDetailsFunction):

  • Modules/paymentrequest/PaymentResponse.h:

LayoutTests:
[Payment Request] PaymentResponse.details should be updated when the user accepts a rpayment retry
​https://bugs.webkit.org/show_bug.cgi?id=191440

Reviewed by Dean Jackson.

  • http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
  • http/tests/paymentrequest/payment-response-retry-method.https.html:
10:19 AM Changeset in webkit [238040] by Fujii Hironori
  • 2 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaFoundation.h: warning: 'GetService' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191453

Reviewed by Per Arne Vollan.

No new tests because there is no behavior change.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: Marked with 'override' and removed 'virtual'.
9:48 AM Changeset in webkit [238039] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Unreviewed attempt to fix internal build on macOS.

'Export' is defined in several headers.

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • bridge/jsc/BridgeJSC.cpp:
  • bridge/jsc/BridgeJSC.h:
9:37 AM Changeset in webkit [238038] by Chris Dumez
  • 29 edits
    3 moves
    3 adds in trunk

HTML form validation bubble disappears
​https://bugs.webkit.org/show_bug.cgi?id=191418

Reviewed by Simon Fraser.

Source/WebCore:

If we validate a form and find an invalid form control, we'll scroll it into view and show
the validation bubble. However, scrolling the element into view may be an asynchronous
operation, in which case it would discard the validation bubble prematurely because scrolling
hides the validation bubble. To address the issue, we now show the validation message
asynchronously after focusing the element (and potentially scrolling it into view).

Test: fast/forms/scroll-into-view-and-show-validation-message.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::focusAndShowValidationMessage):

LayoutTests:

Add API test coverage and update existing tests to use form-validation.js and
avoid code duplication.

  • fast/forms/form-validation.js: Added.

(getValidationBubbleContents):
(getValidationBubble.return.new.Promise.):
(getValidationBubble):

  • fast/forms/ios/validation-bubble-dismiss-on-tap-expected.txt:
  • fast/forms/ios/validation-bubble-dismiss-on-tap.html:
  • fast/forms/navigation-dismisses-validation-bubbles-expected.txt: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt.
  • fast/forms/navigation-dismisses-validation-bubbles.html: Renamed from LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html.
  • fast/forms/resources/check-validation-bubble-not-visible.html: Renamed from LayoutTests/http/tests/navigation/resources/check-validation-bubble-not-visible.html.
  • fast/forms/scroll-into-view-and-show-validation-message-expected.txt: Added.
  • fast/forms/scroll-into-view-and-show-validation-message.html: Added.
  • fast/forms/validation-bubble-disappears-when-input-detached-expected.txt:
  • fast/forms/validation-bubble-disappears-when-input-detached.html:
  • fast/forms/validation-bubble-disappears-when-input-moved-expected.txt:
  • fast/forms/validation-bubble-disappears-when-input-moved.html:
  • fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt:
  • fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html:
  • fast/forms/validation-bubble-escape-key-dismiss-expected.txt:
  • fast/forms/validation-bubble-escape-key-dismiss.html:
  • fast/forms/validation-custom-message-expected.txt:
  • fast/forms/validation-custom-message.html:
  • fast/forms/validation-message-detached-iframe-expected.txt:
  • fast/forms/validation-message-detached-iframe.html:
  • fast/forms/validation-message-detached-iframe2-expected.txt:
  • fast/forms/validation-message-detached-iframe2.html:
  • fast/forms/validation-message-minimum-font-size-expected.txt:
  • fast/forms/validation-message-minimum-font-size.html:
  • fast/forms/validation-messages-expected.txt:
  • fast/forms/validation-messages.html:
  • platform/gtk/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/win/TestExpectations:
9:32 AM Changeset in webkit [238037] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows][DirectX] Be more rigors about BeginFigure/EndFigure and Close operations.
​https://bugs.webkit.org/show_bug.cgi?id=191452
<rdar://problem/45933964>

Reviewed by Zalan Bujtas.

Do a better job of balancing the BeginFigure/EndFigure calls in
the PathDirect2D implementation. Failure to do so puts the Geometry sink
into an error state that prevents it from producing drawing output.

  • platform/graphics/Path.h:
  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPath): Flush is needed here.
(WebCore::GraphicsContext::fillPath): Ditto.
(WebCore::GraphicsContext::strokePath): Ditto.

  • platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::drawDidComplete):
(WebCore::Path::closeAnyOpenGeometries):
(WebCore::Path::transform):
(WebCore::Path::openFigureAtCurrentPointIfNecessary):
(WebCore::Path::moveTo):
(WebCore::Path::closeSubpath):

9:27 AM Changeset in webkit [238036] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebKitLegacy

Remove legacy storage tracker database file after r237330
​https://bugs.webkit.org/show_bug.cgi?id=191423

Reviewed by Geoffrey Garen.

r237330 changed the file name of storage tracker database, but it did not remove the old
file before using the new one.

  • Storage/StorageTracker.cpp:

(WebKit::StorageTracker::internalInitialize):

9:24 AM Changeset in webkit [238035] by jer.noble@apple.com
  • 6 edits
    1 copy
    3 adds in trunk

[Cocoa] Fix failing imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html test
​https://bugs.webkit.org/show_bug.cgi?id=191396

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Modify the changetype test suite to include a HEVC version.

  • web-platform-tests/media-source/hevc/test-v-128k-320x240-24fps-8kfr.mp4: Added.
  • web-platform-tests/media-source/mediasource-changetype-util.js:

(findSupportedChangeTypeTestTypes):

Source/WebCore:

When changeType() is called, exempt video and text tracks (in addition to just audio tracks)
from "same codec" requirements.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::validateInitializationSegment):

LayoutTests:

  • platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
  • platform/mac-sierra/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-expected.txt:
9:16 AM Changeset in webkit [238034] by Ryan Haddad
  • 1 edit
    2 adds in trunk/LayoutTests

Clean up test expectations after r237942
​https://bugs.webkit.org/show_bug.cgi?id=191448

Unreviewed test gardening.

Add test expectation files for Sierra WK1.

  • platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: Added.
  • platform/mac-sierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Added.
9:06 AM Changeset in webkit [238033] by dbates@webkit.org
  • 5 edits
    2 adds in trunk

[iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
action when forward delete is pressed outside a text field
​https://bugs.webkit.org/show_bug.cgi?id=190566
<rdar://problem/45262367>

Reviewed by Wenson Hsieh.

Source/WebKit:

Override -_deleteForwardAndNotify to perform a forward deletion and remove the dead code that
expected UIKit to send us a character string with 0xF728 for the forward delete key. UIKit
ceased doing this many years ago. We may revist this decision once <rdar://problem/45772078>
is fixed.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView _deleteForwardAndNotify:]):

Source/WebKitLegacy/mac:

Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

LayoutTests:

Add a test to ensure that pressing the forward delete key deletes the next character.

  • fast/events/ios/forward-delete-in-editable-expected.txt: Added.
  • fast/events/ios/forward-delete-in-editable.html: Added.
8:42 AM Changeset in webkit [238032] by Fujii Hironori
  • 2 edits in trunk/Source/WebKitLegacy/win

WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
​https://bugs.webkit.org/show_bug.cgi?id=191455

Reviewed by Brent Fulgham.

  • WebHistory.h: Marked with 'override' and removed 'virtual'.
8:40 AM Changeset in webkit [238031] by keith_miller@apple.com
  • 6 edits in trunk/Source

LLInt VectorSizeOffset should be based on offset extraction
​https://bugs.webkit.org/show_bug.cgi?id=191468

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This patch also adds some usings to LLIntOffsetsExtractor that
make it possible to use the bare names of Vector/RefCountedArray
in offsets extraction.

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:

Source/WTF:

Make things friends with LLIntOffsetsExtractor.

  • wtf/RefCountedArray.h:
  • wtf/Vector.h:
8:15 AM Changeset in webkit [238030] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION(r236365): [GTK] Many form-related tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=189993

Reviewed by Michael Catanzaro.

Source/WebCore:

Only the first form data element is added to the message body due to a return added by mistake in r236365.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageBody const): Remove return.

LayoutTests:

Remove expectations for tests that are passing now.

  • platform/gtk/TestExpectations:
7:30 AM Changeset in webkit [238029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[WTF] Changes in bug 188867 break non-Linux Unix builds
​https://bugs.webkit.org/show_bug.cgi?id=191380

The intention of 188867 was to split out platform-specific
heap query/release code. Any unsupported platform
would use a generic, no-op stub. However, wtf/PlatformGTK.cmake
ended up sending all non-Linux platforms through the Linux
implementation, which breaks the build for those platforms.
This includes any user of the GTK target which is not Linux,
such as the *BSDs, Solaris, etc.

Patch by Jim Mason <​jmason@ibinx.com> on 2018-11-09
Reviewed by Yusuke Suzuki.

  • wtf/PlatformGTK.cmake: Updated to include Linux-specific

code only for Linux; all other platforms use the generic stub.

7:28 AM Changeset in webkit [238028] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] Move some code from InlineFormattingContext::Line to InlineFormattingContext/Geometry
​https://bugs.webkit.org/show_bug.cgi?id=191445

Reviewed by Antti Koivisto.

The idea here is that Line should not have to deal with all the post processig tasks like the runs final aligments.
(The line class would eventually turn into a collection of random things).

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::closeLine const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):

  • layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Line::contentLogicalLeft const):
(WebCore::Layout::InlineFormattingContext::Line::lastRunType const):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::adjustedLineLogicalLeft):
(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):
(WebCore::Layout::InlineFormattingContext::Geometry::computeExpansionOpportunities):

  • layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::Line):
(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight const):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):
(WebCore::Layout::adjustedLineLogicalLeft): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::contentLogicalRight): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::computeExpansionOpportunities): Deleted.
(WebCore::Layout::InlineFormattingContext::Line::justifyRuns): Deleted.

7:05 AM Changeset in webkit [238027] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GStreamer build warning fix

  • platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoder::newSampleCallback): Timesamp()
returns a uint32_t, fix format string accordingly.

3:32 AM Changeset in webkit [238026] by yusukesuzuki@slowstart.org
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling in CodeCache in r237254
​https://bugs.webkit.org/show_bug.cgi?id=190340

Land the CodeCache part, which uses DefaultHash<>::Hash instead of computeHash.

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::fromGlobalCode):

  • bytecode/UnlinkedFunctionExecutable.h:
  • parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::operator== const):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedGlobalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):

  • runtime/CodeCache.h:
  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::fromGlobalCode):

  • runtime/FunctionExecutable.h:
2:53 AM Changeset in webkit [238025] by Philippe Normand
  • 5 edits
    2 adds in trunk/Tools

[Flatpak] Refactoring and drive-by fixes
​https://bugs.webkit.org/show_bug.cgi?id=191421

Reviewed by Michael Catanzaro.

  • Scripts/webkitdirs.pm:

(inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
the sandbox, so rely on this.

  • flatpak/flatpakutils.py:

(expand_manifest): Pass explicit keywords to load_manifest() and
remove unused local variable.
(WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
(WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
(WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
build_type handling a bit.

  • flatpak/org.webkit.CommonModules.yaml: Added.
  • flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
  • flatpak/org.webkit.WebKit.yaml: Move common dependencies

declaration to CommonModules, so it can be reused later when we
add support for building extra libraries depending on WPE.

1:22 AM Changeset in webkit [238024] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

put_by_val opcodes need to add the number tag as a 64-bit register
​https://bugs.webkit.org/show_bug.cgi?id=191456

Reviewed by Saam Barati.

Previously the LLInt would add it as a pointer sized value. That is
wrong if pointer size is less 64-bits.

  • llint/LowLevelInterpreter64.asm:
Note: See TracTimeline for information about the timeline view.