Timeline

Nov 23, 2018:

11:17 PM Changeset in webkit [238468] by Antti Koivisto

• 27 edits
  2 moves in trunk/Source/WebKit

Replace LayerOrView typedef with a class
​https://bugs.webkit.org/show_bug.cgi?id=191927

Reviewed by Tim Horton.

This typedef restricts remote layer representation to be either a CA layer or a view. We might want
have more flexibility, for example tiles don't really need to be UIViews. It will also make it easier
to unify Mac and iOS code, and hopefully make it less confusing too.

This patch introduces RemoteLayerTreeNode class that replaces most uses of LayerOrView typedef
(the rest are converted to pure CALayer). It also does a bunch of related cleanup.

• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
• Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView):
(WebKit::applyPropertiesToLayer): Deleted.

• SourcesCocoa.txt:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _propertiesOfLayerWithID:]):

• UIProcess/Cocoa/LayerRepresentation.h: Removed.
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):

• UIProcess/PageClient.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::layerWithIDForTesting const):

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:

(WebKit::RemoteLayerTreeHost::rootNode const):
(WebKit::RemoteLayerTreeHost::rootLayer const): Deleted.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::nodeForID const):
(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::animationDidStart):
(WebKit::RemoteLayerTreeHost::animationDidEnd):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::layerWithIDForTesting const):
(WebKit::RemoteLayerTreeHost::layerForID const):
(WebKit::RemoteLayerTreeHost::rootLayer const):
(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::detachRootLayer):
(WebKit::RemoteLayerTreeHost::mapAllIOSurfaceBackingStore):
(WebKit::RemoteLayerTreeHost::getLayer const): Deleted.

• UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: Added.

(WebKit::RemoteLayerTreeNode::layer const):
(WebKit::RemoteLayerTreeNode::uiView const):

• UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: Added.

(WebKit::RemoteLayerTreeNode::RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::detachFromParent):

• UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm:

(WebKit::RemoteLayerTreeScrollingPerformanceData::blankPixelCount const):

• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

• UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
(WebKit::layerRepresentationFromLayerOrView): Deleted.

• UIProcess/WebAuthentication/Cocoa/HidService.h:
• UIProcess/WebAuthentication/Cocoa/HidService.mm:
• UIProcess/WebPageProxy.h:
• UIProcess/ios/LayerRepresentation.mm: Removed.
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setRemoteLayerTreeRootNode):
(WebKit::PageClientImpl::acceleratedCompositingRootLayer const):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer): Deleted.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setRemoteLayerTreeRootNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer): Deleted.

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setRemoteLayerTreeRootNode):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer): Deleted.

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setRemoteLayerTreeRootNode):
(WebKit::WebPageProxy::acceleratedCompositingRootLayer const):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer): Deleted.

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

10:08 PM Changeset in webkit [238467] by commit-queue@webkit.org

• 5 edits in trunk

Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
​https://bugs.webkit.org/show_bug.cgi?id=191936

Patch by Sam Weinig <​sam@webkit.org> on 2018-11-23
Reviewed by Zalan Bujtas.

Source/WTF:

Adds overloads for find, contains, insertBefore and remove that take raw pointers
when the value type V of a ListHashSet is true for the predicate IsSmartPtr<V>::value.
This brings the interface to ListHashSet closer inline with HashSet, HashMap and HashCountedSet
which already have this functionality. Like in the other collections, this is especially
useful when using std::unique_ptr<> as the value, since there would be no way to pass it
to these functions. One difference between this set of overloads is the inclusion of insertBefore,
which is unique to ListHashSet. As would be expected, this specialization only changes the first
parameter, the one that needs to be found, to support a raw pointer.

• wtf/ListHashSet.h:

(WTF::U>::find):
(WTF::U>::find const):
(WTF::U>::contains const):
(WTF::U>::insertBefore):
(WTF::U>::remove):

Tools:

Adds tests for raw pointer overloads in ListHashSet.

• TestWebKitAPI/Tests/WTF/HashSet.cpp:
• TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

7:51 PM Changeset in webkit [238466] by jiewen_tan@apple.com

• 4 edits in trunk/Source

[WebAuthN] Enable Web Authentication as an experimental feature for macOS
​https://bugs.webkit.org/show_bug.cgi?id=191932
rdar://problem/46225210

Reviewed by Brent Fulgham.

Source/WebCore:

Add myself to the contact of Web Authentication.

• features.json:

Source/WebKit:

• Shared/WebPreferences.yaml:

6:17 PM Changeset in webkit [238465] by rniwa@webkit.org

• 3 edits
  3 adds in trunk

REGRESSION (r236785): Nullptr crash in StyledMarkupAccumulator::traverseNodesForSerialization
​https://bugs.webkit.org/show_bug.cgi?id=191921

Reviewed by Dean Jackson.

Source/WebCore:

The bug was caused by traverseNodesForSerialization not being able to traverse past the end of shadow root
when skipping children of a node for which enterNode returns false because it was using NodeTraversal's
nextSkippingChildren instead of a member function which supports traversing the composed tree.

Fixed the crash by using variant of nextSkippingChildren which knows how to traverse past the last node
in a shadow tree. Also added more assertions to help debug issues like this in the future.

Test: editing/pasteboard/copy-paste-across-shadow-boundaries-5.html

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

LayoutTests:

Added a regression test.

• editing/pasteboard/copy-paste-across-shadow-boundaries-5-expected.txt: Added.
• editing/pasteboard/copy-paste-across-shadow-boundaries-5.html: Added.
• platform/ios/editing/pasteboard/copy-paste-across-shadow-boundaries-5-expected.txt: Added.

2:06 PM Changeset in webkit [238464] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Updating href on textPath doesn't update its rendering
​https://bugs.webkit.org/show_bug.cgi?id=191920

Reviewed by Dean Jackson.

Source/WebCore:

Fixed the bug by invalidating the RenderSVGResource in SVGTextPathElement::svgAttributeChanged
in addition to updating the pending resources.

Test: svg/text/textpath-reference-update.html

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::svgAttributeChanged):

LayoutTests:

Added a ref test.

• svg/text/textpath-reference-update-expected.html: Added.
• svg/text/textpath-reference-update.html: Added.

12:47 PM Changeset in webkit [238463] by Ross Kirsling

• 78 edits in trunk/Source/WebCore

Introduce user-defined literal for LayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=191915

Reviewed by Dean Jackson.

• platform/LayoutUnit.h:

Introduce a user-defined literal for LayoutUnit, _lu, replacing the existing "fromPixel" factory function.

• layout/FormattingContextGeometry.cpp:
• layout/inlineformatting/InlineFormattingContextGeometry.cpp:
• layout/inlineformatting/InlineLineBreaker.cpp:
• page/FrameView.cpp:
• page/FrameViewLayoutContext.h:
• page/Page.cpp:
• page/SpatialNavigation.h:
• platform/ScrollableArea.cpp:
• rendering/EllipsisBox.cpp:
• rendering/FlexibleBoxAlgorithm.cpp:
• rendering/FloatingObjects.cpp:
• rendering/GridLayoutFunctions.cpp:
• rendering/GridTrackSizingAlgorithm.cpp:
• rendering/InlineFlowBox.cpp:
• rendering/InlineTextBox.cpp:
• rendering/LayoutState.h:
• rendering/LogicalSelectionOffsetCaches.h:
• rendering/RenderBlock.cpp:
• rendering/RenderBlock.h:
• rendering/RenderBlockFlow.cpp:
• rendering/RenderBlockFlow.h:
• rendering/RenderBlockLineLayout.cpp:
• rendering/RenderBox.cpp:
• rendering/RenderBoxModelObject.cpp:
• rendering/RenderDeprecatedFlexibleBox.cpp:
• rendering/RenderDeprecatedFlexibleBox.h:
• rendering/RenderElement.cpp:
• rendering/RenderFlexibleBox.cpp:
• rendering/RenderFlexibleBox.h:
• rendering/RenderFragmentContainer.cpp:
• rendering/RenderFragmentedFlow.cpp:
• rendering/RenderGrid.cpp:
• rendering/RenderGrid.h:
• rendering/RenderImage.cpp:
• rendering/RenderLayer.cpp:
• rendering/RenderListMarker.cpp:
• rendering/RenderMultiColumnFlow.cpp:
• rendering/RenderMultiColumnSet.cpp:
• rendering/RenderReplaced.cpp:
• rendering/RenderReplaced.h:
• rendering/RenderRubyRun.h:
• rendering/RenderTable.cpp:
• rendering/RenderTable.h:
• rendering/RenderTableSection.cpp:
• rendering/RenderTheme.cpp:
• rendering/RenderTreeAsText.cpp:
• rendering/RenderView.cpp:
• rendering/RootInlineBox.h:
• rendering/SimpleLineLayout.cpp:
• rendering/SimpleLineLayoutPagination.cpp:
• rendering/TableLayout.h:
• rendering/line/BreakingContext.h:
• rendering/line/LineLayoutState.h:
• rendering/line/LineWidth.h:
• rendering/mathml/MathOperator.cpp:
• rendering/mathml/MathOperator.h:
• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLFraction.cpp:
• rendering/mathml/RenderMathMLFraction.h:
• rendering/mathml/RenderMathMLMath.cpp:
• rendering/mathml/RenderMathMLMath.h:
• rendering/mathml/RenderMathMLMenclose.h:
• rendering/mathml/RenderMathMLOperator.cpp:
• rendering/mathml/RenderMathMLOperator.h:
• rendering/mathml/RenderMathMLPadded.h:
• rendering/mathml/RenderMathMLRoot.cpp:
• rendering/mathml/RenderMathMLRoot.h:
• rendering/mathml/RenderMathMLRow.h:
• rendering/mathml/RenderMathMLScripts.cpp:
• rendering/mathml/RenderMathMLScripts.h:
• rendering/mathml/RenderMathMLSpace.h:
• rendering/mathml/RenderMathMLToken.cpp:
• rendering/mathml/RenderMathMLToken.h:
• rendering/mathml/RenderMathMLUnderOver.h:
• rendering/shapes/ShapeOutsideInfo.cpp:
• rendering/style/CollapsedBorderValue.h:

Update all instances of LayoutUnit(), LayoutUnit(0), LayoutUnit { 0 }, etc. and add any other
literal conversions that will be needed when making non-int LayoutUnit constructors explicit.
For good measure, also mark all default values for LayoutUnit parameters.

11:45 AM Changeset in webkit [238462] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
​https://bugs.webkit.org/show_bug.cgi?id=191067

Updated code per the style guide, removed unreachable break (non-semantic change)

Patch by Jim Mason <​jmason@ibinx.com> on 2018-11-23
Reviewed by Michael Catanzaro.

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::handleMousePressEvent):

10:18 AM Changeset in webkit [238461] by Wenson Hsieh

• 16 edits in trunk

Enable drag and drop support for iOSMac
​https://bugs.webkit.org/show_bug.cgi?id=191818
<rdar://problem/43907454>

Reviewed by Dean Jackson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enables drag and drop by default on iOSMac by switching on ENABLE_DATA_INTERACTION and ENABLE_DRAG_SUPPORT. This
enables support for dragging links, text selections, and images, though many advanced features (e.g. custom
pasteboard data) will require additional support from the platform.

• Configurations/FeatureDefines.xcconfig:
• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

• platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderLoadResult canBeRepresentedAsFileUpload]):
(-[WebItemProviderPasteboard numberOfFiles]):

Disable codepaths which attempt to access or set teamData or preferredPresentationStyle on NSItemProvider
in iOSMac, since these are currently unimplemented.

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferencesDefaultValues.cpp:

(defaultCustomPasteboardDataEnabled):

Enable custom pasteboard data by default on iOSMac. While writing and reading custom pasteboard data is
currently broken in iOSMac due to the lack of teamData and preferredPresentationStyle, opting into custom
pasteboard data at least allows us to avoid writing unsanitized data types to the pasteboard.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Fix a regression from <​https://trac.webkit.org/r236619> wherein the web process crashes when attempting to edit
a text field. This happens because the call to -[UIKeyboard isInHardwareKeyboardMode] on the iOSMac platform
attempts to initialize a UHASWorkspace from the web process, which then attempts to connect to the UIKit host
application. Instead, we can skip this call altogether on iOSMac, where the platform never considers a hardware
keyboard to be "connected", even when typing.

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:05 AM Changeset in webkit [238460] by Alan Bujtas

• 11 edits
  2 adds in trunk

[LFC][IFC] Add support for variable height runs.
​https://bugs.webkit.org/show_bug.cgi?id=191925

Reviewed by Antti Koivisto.

Source/WebCore:

​https://www.w3.org/TR/CSS22/visudet.html#inline-box-height

10.8 Line height calculations: the 'line-height' and 'vertical-align' properties

The height of each inline-level box in the line box is calculated. For replaced elements, inline-block elements,
and inline-table elements, this is the height of their margin box; for inline boxes, this is their 'line-height'.

The line box height is the distance between the uppermost box top and the lowermost box bottom.

The minimum height consists of a minimum height above the baseline and a minimum depth below it,
exactly as if each line box starts with a zero-width inline box with the element's font and line height properties.
We call that imaginary box a "strut." (The name is inspired by TeX.).

Test: fast/inline/inline-content-with-image-simple.html

• layout/Verification.cpp:

(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::createFinalRuns const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):

• layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Line::logicalHeight const):

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):

• layout/inlineformatting/InlineRun.h:

(WebCore::Layout::InlineRun::logicalWidth const):
(WebCore::Layout::InlineRun::logicalHeight const):
(WebCore::Layout::InlineRun::setLogicalWidth):
(WebCore::Layout::InlineRun::width const): Deleted.
(WebCore::Layout::InlineRun::height const): Deleted.
(WebCore::Layout::InlineRun::setWidth): Deleted.

• layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):

• layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/inline/inline-content-with-image-simple-expected.txt: Added.
• fast/inline/inline-content-with-image-simple.html: Added.

7:07 AM Changeset in webkit [238459] by Antti Koivisto

• 5 edits in trunk/Source

UI side compositing doesn't paint on Mac
​https://bugs.webkit.org/show_bug.cgi?id=191908

Reviewed by Tim Horton.

Source/WebCore:

For clarity put RGB10 and RGB10A8 formats behind PLATFORM(IOS_FAMILY). They are not supported on Mac.

• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::IOSurface):
(WebCore::IOSurface::ensurePlatformContext):
(WebCore::IOSurface::format const):
(WebCore::operator<<):

Source/WebKit:

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::bytesPerPixel const):
(WebKit::RemoteLayerBackingStore::surfaceBufferFormat const):

These deep color formats are not supported on Mac.

5:36 AM Changeset in webkit [238458] by berto@igalia.com

• 3 edits in trunk/Tools

[GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
​https://bugs.webkit.org/show_bug.cgi?id=191923

Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
respective tarballs.

Reviewed by Carlos Garcia Campos.

• gtk/manifest.txt.in:
• wpe/manifest.txt.in:

3:04 AM Changeset in webkit [238457] by jfernandez@igalia.com

• 60 edits
  14 adds in trunk

[css-grid] Implement Baseline Alignment for grid items
​https://bugs.webkit.org/show_bug.cgi?id=145566

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Updated test expectations of severla tests, that are now passing with the new code.

• resources/import-expectations.json:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-004-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
• web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-007.html:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-009.html:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-010.html:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html:
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-012.html:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002-expected.txt:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002-expected.txt:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002-expected.txt:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-002-expected.txt:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
• web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:

Source/WebCore:

This patch impements the Baseline Self-Alignment feature for grid items according to
the CSS Box Alignment specification [1].

This new layout logic is handled by the Self-Alignment (justify-self and align-self)
and Default-Alignment (justify-items and align-items) CSS properties.

This feature allows users to align the grid items sharing a Baseline Alignment Context,
either row or column contexts, based on their respective baselines.

[1] ​https://drafts.csswg.org/css-align-3/#baseline-align-self

Tests: fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash.html

fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash.html
fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash.html
fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash.html
fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash.html
fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash.html

• Sources.txt:
• rendering/GridBaselineAlignment.cpp: Added.

(WebCore::GridBaselineAlignment::marginOverForChild const):
(WebCore::GridBaselineAlignment::marginUnderForChild const):
(WebCore::GridBaselineAlignment::logicalAscentForChild const):
(WebCore::GridBaselineAlignment::ascentForChild const):
(WebCore::GridBaselineAlignment::descentForChild const):
(WebCore::GridBaselineAlignment::isDescentBaselineForChild const):
(WebCore::GridBaselineAlignment::isHorizontalBaselineAxis const):
(WebCore::GridBaselineAlignment::isOrthogonalChildForBaseline const):
(WebCore::GridBaselineAlignment::isParallelToBaselineAxisForChild const):
(WebCore::GridBaselineAlignment::baselineGroupForChild const):
(WebCore::GridBaselineAlignment::updateBaselineAlignmentContext):
(WebCore::GridBaselineAlignment::baselineOffsetForChild const):
(WebCore::GridBaselineAlignment::clear):
(WebCore::BaselineGroup::BaselineGroup):
(WebCore::BaselineGroup::update):
(WebCore::BaselineGroup::isOppositeBlockFlow const):
(WebCore::BaselineGroup::isOrthogonalBlockFlow const):
(WebCore::BaselineGroup::isCompatible const):
(WebCore::BaselineContext::BaselineContext):
(WebCore::BaselineContext::sharedGroup const):
(WebCore::BaselineContext::updateSharedGroup):
(WebCore::BaselineContext::findCompatibleSharedGroup):

• rendering/GridBaselineAlignment.h: Added.

(WebCore::BaselineGroup::maxAscent const):
(WebCore::BaselineGroup::maxDescent const):
(WebCore::BaselineGroup::size const):
(WebCore::isBaselinePosition):
(WebCore::GridBaselineAlignment::setBlockFlow):

• rendering/GridLayoutFunctions.h:
• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::gridAxisForDirection):
(WebCore::gridDirectionForAxis):
(WebCore::GridTrackSizingAlgorithm::availableSpace const):
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::canParticipateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::participateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::updateBaselineAlignmentContext):
(WebCore::GridTrackSizingAlgorithm::baselineOffsetForChild const):
(WebCore::GridTrackSizingAlgorithm::clearBaselineItemsCache):
(WebCore::GridTrackSizingAlgorithm::cacheBaselineAlignedItem):
(WebCore::GridTrackSizingAlgorithm::copyBaselineItemsCache):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):

• rendering/GridTrackSizingAlgorithm.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::firstLineBaseline const):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::synthesizedBaselineFromMarginBox):
(WebCore::RenderGrid::isBaselineAlignmentForChild const):
(WebCore::RenderGrid::baselinePosition const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::inlineBlockBaseline const):
(WebCore::RenderGrid::columnAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::rowAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):

• rendering/RenderGrid.h:

LayoutTests:

Most of the baseline realated tests pass now; just a few still fail because of unrelated bugs.

• TestExpectations: Removed several entries, related to the baseline tests that are now passing.
• fast/css-grid-layout/grid-align-baseline-expected.txt:
• fast/css-grid-layout/grid-align-baseline-vertical-expected.txt:
• fast/css-grid-layout/grid-baseline-expected.html:
• fast/css-grid-layout/grid-baseline-margins-expected.html:
• fast/css-grid-layout/grid-baseline-margins.html:
• fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt:
• fast/css-grid-layout/grid-baseline-must-respect-grid-order.html:
• fast/css-grid-layout/grid-baseline.html:
• fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash-expected.txt: Added.
• fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash.html: Added.
• fast/css-grid-layout/grid-self-baseline-two-dimensional-expected.txt:
• fast/css-grid-layout/grid-self-baseline-two-dimensional.html:

Nov 22, 2018:

8:36 PM Changeset in webkit [238456] by Chris Dumez

• 4 edits in trunk

Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
​https://bugs.webkit.org/show_bug.cgi?id=191914

Reviewed by Ryosuke Niwa.

Source/WebKit:

When process-swapping on a cross-site server-side redirect, we end up doing a decidePolicyForNavigationResponse
policy check for the about:blank suspension load. This policy decision is ignored by the UIProcess because
SuspendedPageProxy does not handle this particular IPC message. To handle the issue, make sure the WebProcess
never sends a DecidePolicyForNavigationResponse IPC to the UIProcess for about:blank suspension loads and let
the load proceed.

The issue was already there before r238353 but it was made obvious by r238353 which caused a hang when trying
to reuse a Suspended page which is hanging while trying to suspend.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

8:00 PM Changeset in webkit [238455] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

[Cocoa] clang emits a warning when building WebKit after r238293
​https://bugs.webkit.org/show_bug.cgi?id=191917

Reviewed by Dan Bernstein.

Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
WKPreferences to fix the warning.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences setSafeBrowsingEnabled:]):
(-[WKPreferences isSafeBrowsingEnabled]):

7:10 PM Changeset in webkit [238454] by Wenson Hsieh

• 21 edits in trunk/Source

Address post-review feedback after r238438
​https://bugs.webkit.org/show_bug.cgi?id=191913

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace bool arguments to FrameSelection::setSelectedRange, Editor::replaceSelectionWithText, and
Editor::replaceSelectionWithFragment with enum classes instead. In particular, introduce the following:

FrameSelection::ShouldCloseTyping { No, Yes }
Editor::SelectReplacement { No, Yes }
Editor::SmartReplace { No, Yes }
Editor::MatchStyle { No, Yes }

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectText):

• editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::replaceSelectionWithText):
(WebCore::Editor::setComposition):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):
(WebCore::Editor::insertAttachment):

At various call sites, replace boolean arguments with named enums.

• editing/Editor.h:
• editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity):
(WebCore::executeDeleteToMark):
(WebCore::executeSelectToMark):

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectedRange):

• editing/FrameSelection.h:
• page/Page.cpp:

(WebCore::replaceRanges):

Avoid a bit of ref-count churn, and adjust a few functions to take const Vector&s instead of Vector&&s.

(WebCore::Page::replaceRangesWithText):
(WebCore::Page::replaceSelectionWithText):

• page/Page.h:

Source/WebKit:

Replace boolean arguments to setSelectedRange, replaceSelectionWithText and replaceSelectionWithFragment with
enum flags, and tweak a couple of functions to take const Vector& instead of Vector&&.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageReplaceStringMatches):

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches):

• WebProcess/WebPage/FindController.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::replaceStringMatchesFromInjectedBundle):
(WebKit::WebPage::replaceMatches):
(WebKit::WebPage::replaceSelectionWithText):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::WebPage::selectWithTwoTouches):
(WebKit::WebPage::extendSelection):
(WebKit::WebPage::selectWordBackward):
(WebKit::WebPage::moveSelectionByOffset):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::updateSelectionWithExtentPoint):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):
(WebKit::WebPage::syncApplyAutocorrection):

Source/WebKitLegacy/mac:

• WebView/WebFrame.mm:

(-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

• WebView/WebView.mm:

(-[WebView setSelectedDOMRange:affinity:]):

Source/WebKitLegacy/win:

• AccessibleTextImpl.cpp:

(AccessibleText::replaceText):

5:33 PM Changeset in webkit [238453] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make the jsc shell's dumpException() more robust against long exception strings.
​https://bugs.webkit.org/show_bug.cgi?id=191910
<rdar://problem/46212980>

Reviewed by Michael Saboff.

This only affects the dumping of the exception string in the jsc shell due to
unhandled exceptions or exceptions at shell boot time before any JS code is
running.

• jsc.cpp:

(dumpException):

3:47 PM Changeset in webkit [238452] by rniwa@webkit.org

• 17 edits in trunk/Source/WebCore

Modernize SVGURIReference::targetElementFromIRIString
​https://bugs.webkit.org/show_bug.cgi?id=191898

Reviewed by Daniel Bates.

Made targetElementFromIRIString return an element and the fragment identifier,
and merged urlFromIRIStringWithFragmentIdentifier into it.

Also replaced the code computing the full URL using the base URL after removing
the fragment identifier and rejoining it later with a single call to completeURL.

No new tests since there should be no observable behavior change.

• accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::targetForUseElement const):

• css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::updateCursorElement):

• rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::layoutPath const):

• svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements const):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::buildPendingResource):

• svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::hasValidGlyphElement const):

• svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

• svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::pathElement):

• svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

• svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::targetElementFromIRIString):
(WebCore::urlFromIRIStringWithFragmentIdentifier): Deleted.

• svg/SVGURIReference.h:
• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::findTarget const):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

• svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::referencedRenderer const):

1:17 PM Changeset in webkit [238451] by dino@apple.com

• 13 edits
  3 copies
  2 adds in trunk

Implement WebGPUQueue and device.getQueue()
​https://bugs.webkit.org/show_bug.cgi?id=191911
<rdar://problem/46214871>

Reviewed by Antoine Quint.

Source/WebCore:

Implement WebGPUDevice::getQueue(), which creates a WebGPUQueue
instance if necessary. Also link WebGPUQueue to the existing
GPUQueue object, and expose the label IDL property.

This patch is based on some work from Justin Fan.

Test: webgpu/queue-creation.html

• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

New files.

• Modules/webgpu/WebGPUCommandBuffer.h:

(WebCore::WebGPUCommandBuffer::commandBuffer const):

Expose a GPUCommandBuffer getter, used when submitting (even though
the actual GPU submission isn't implemented yet).

• Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::getQueue):

• Modules/webgpu/WebGPUDevice.h:
• Modules/webgpu/WebGPUDevice.idl:

Implement getQueue().

• Modules/webgpu/WebGPUQueue.cpp:

(WebCore::WebGPUQueue::create):
(WebCore::WebGPUQueue::WebGPUQueue):
(WebCore::WebGPUQueue::submit):

• Modules/webgpu/WebGPUQueue.h:

(WebCore::WebGPUQueue::label const):
(WebCore::WebGPUQueue::setLabel):

• Modules/webgpu/WebGPUQueue.idl:

New class. Mostly sends stuff onto GPUQueue.

• bindings/js/WebCoreBuiltinNames.h:

Add WebGPUQueue.

• platform/graphics/gpu/GPUQueue.h:
• platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::create):
(WebCore::GPUQueue::submit):
(WebCore::GPUQueue::label const):
(WebCore::GPUQueue::setLabel const):

"label" getter/setter that uses
the underlying MTLCommandQueue label property, but prefixes
it with a WebKit identifier, so it can be correctly
identified in system crash logs as coming from WebGPU.

LayoutTests:

WPT-style test for queue creation.

• webgpu/queue-creation-expected.txt: Added.
• webgpu/queue-creation.html: Added.

12:32 PM Changeset in webkit [238450] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Improve fast/scrolling/scrolling-tree-includes-frame.html
​https://bugs.webkit.org/show_bug.cgi?id=191912

These are small improvements to scrolling-tree-includes-frame.html:

• Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
• Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
• Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)

with no extra margin/padding/border.

• Remove unnecessary id="frame"

The test expectation is not changed.

Patch by Frederic Wang <​fwang@igalia.com> on 2018-11-22
Reviewed by Antonio Gomes.

• fast/scrolling/scrolling-tree-includes-frame.html:

10:56 AM Changeset in webkit [238449] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][IFC] Merge addNonBreakableStart/NonBreakableEnd calls.
​https://bugs.webkit.org/show_bug.cgi?id=191903

Reviewed by Antti Koivisto.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

10:51 AM Changeset in webkit [238448] by Alan Bujtas

• 5 edits
  2 adds in trunk

[LFC][IFC] Offset formatting context root runs with horizontal margins.
​https://bugs.webkit.org/show_bug.cgi?id=191900

Reviewed by Antti Koivisto.

Source/WebCore:

Inline runs generated by formatting roots (inline-block) need to be adjusted with the horizontal margins.
(The test case has padding and border as well, but they are _inside_ the formatting context.)

Test: fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right.html

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

• LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

• fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right-expected.txt: Added.
• fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right.html: Added.

10:11 AM Changeset in webkit [238447] by Simon Fraser

• 3 edits
  2 adds in trunk

Extremely small monospace text size when SVG is included as an img
​https://bugs.webkit.org/show_bug.cgi?id=191834

Reviewed by Myles C. Maxfield.
Source/WebCore:

Give defaultFixedFontSize a reasonable default value in Settings, so that clients
who omit to set it (like SVGImages) don't get broken rendering.

Test: svg/text/monospace-text-size-in-img.html

• page/Settings.yaml:

LayoutTests:

The test has an x offset in the text transform to work around a different bug
with text position (webkit.org/b/191871).

• svg/text/monospace-text-size-in-img-expected.html: Added.
• svg/text/monospace-text-size-in-img.html: Added.

9:33 AM Changeset in webkit [238446] by mark.lam@apple.com

• 3 edits in trunk/Source/WebKit

Rollout r238432: Breaks internal Mac builds.
​https://bugs.webkit.org/show_bug.cgi?id=191909
<rdar://problem/46214163>

Unreviewed. Rolling out r238432: Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp

• Sources.txt:
• WebKit.xcodeproj/project.pbxproj:

6:18 AM Changeset in webkit [238445] by Philippe Normand

• 4 edits in trunk/Tools

[GTK] Remove unmaintained bots
​https://bugs.webkit.org/show_bug.cgi?id=191467

Reviewed by Alex Christensen.

The Linux 32-bits and ARM build-slaves are no longer maintained
and have been failing for months, so get rid of them.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

4:53 AM Changeset in webkit [238444] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak] Do not disable signals when running "usual" commands
​https://bugs.webkit.org/show_bug.cgi?id=190679

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-11-22
Reviewed by Philippe Normand.

Otherwise <ctr>c doesn't work while compiling. It is not the best fix
as there are cases we want to let only children receive signals, but
it is not clear how to determine when (when running gdb, we still
disable those).

• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

1:59 AM Changeset in webkit [238443] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.23.1

WebKitGTK+ 2.23.1

1:38 AM Changeset in webkit [238442] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.1 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.23.1.

12:45 AM Changeset in webkit [238441] by jfernandez@igalia.com

• 7 edits
  4 adds in trunk

Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
​https://bugs.webkit.org/show_bug.cgi?id=191881

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

We should use the font's descent value when wriring-mode flips line flow (vertical-lr).

This change also fixes bug 170175, since Flexbox use the same code to determine the first
line baseline of a flex item.

Test: fast/writing-mode/vertical-align-table-baseline-latin.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::firstLineBaseline const):

LayoutTests:

Tests to verify that columns of a vertical-lr table vertically aligned by baseline work like
in the case of horizontal tables.
Also added tests to verify flexbox baseline alignment works as expected in vertical-lr mode.

The vertical-align-table-baseline.html test has been rebaselined due to the new behavior.

• fast/writing-mode/vertical-align-table-baseline-latin-expected.html: Added.
• fast/writing-mode/vertical-align-table-baseline-latin.html: Added.
• fast/writing-mode/vertical-align-flex-baseline-expected.html: Added.
• fast/writing-mode/vertical-align-flex-baseline-html: Added.
• platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
• platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
• platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
• platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.