Context Navigation

Add a new timeline to Timelines for media related events (e.g. event/fullscreen/low-power).
Mimics what is visible by using the same instrumentation points as the Network tab when
"Group Media Requests" is enabled.

UserInterface/Models/MediaInstrument.js: Added.

(WI.MediaInstrument):
(WI.MediaInstrument.supported):
(WI.MediaInstrument.prototype.get timelineRecordType):
(WI.MediaInstrument.prototype.startInstrumentation):
(WI.MediaInstrument.prototype.stopInstrumentation):

UserInterface/Models/MediaTimelineRecord.js: Added.

(WI.MediaTimelineRecord):
(WI.MediaTimelineRecord.prototype.get eventType):
(WI.MediaTimelineRecord.prototype.get domNode):
(WI.MediaTimelineRecord.prototype.get domEvent):
(WI.MediaTimelineRecord.prototype.get isLowPower):
(WI.MediaTimelineRecord.prototype.get displayName):
(WI.MediaTimelineRecord.prototype.saveIdentityToCookie):

UserInterface/Views/MediaTimelineDataGridNode.js: Added.

(WI.MediaTimelineDataGridNode):
(WI.MediaTimelineDataGridNode.prototype.get records):
(WI.MediaTimelineDataGridNode.prototype.get data):
(WI.MediaTimelineDataGridNode.prototype.createCellContent):
(WI.MediaTimelineDataGridNode.prototype.iconClassNames):
(WI.MediaTimelineDataGridNode.prototype.filterableDataForColumn):

UserInterface/Views/MediaTimelineOverviewGraph.js: Added.

(WI.MediaTimelineOverviewGraph):
(WI.MediaTimelineOverviewGraph.prototype.reset):
(WI.MediaTimelineOverviewGraph.prototype.shown):
(WI.MediaTimelineOverviewGraph.prototype.hidden):
(WI.MediaTimelineOverviewGraph.prototype.layout):
(WI.MediaTimelineOverviewGraph.prototype.updateSelectedRecord):
(WI.MediaTimelineOverviewGraph.prototype._handleRecordAdded):

UserInterface/Views/MediaTimelineOverviewGraph.css: Added.

(.timeline-overview-graph.media > .timeline-record-bar):
(.timeline-overview-graph.media > .timeline-record-bar > .segment):

UserInterface/Views/MediaTimelineView.js: Added.

(WI.MediaTimelineView):
(WI.MediaTimelineView.prototype.get secondsPerPixel):
(WI.MediaTimelineView.prototype.get selectionPathComponents):
(WI.MediaTimelineView.prototype.closed):
(WI.MediaTimelineView.prototype.reset):
(WI.MediaTimelineView.prototype.dataGridSortComparator.compareDOMNodes):
(WI.MediaTimelineView.prototype.dataGridSortComparator.):
(WI.MediaTimelineView.prototype.dataGridSortComparator):
(WI.MediaTimelineView.prototype.layout):
(WI.MediaTimelineView.prototype._processPendingRecords):
(WI.MediaTimelineView.prototype._handleRecordAdded):
(WI.MediaTimelineView.prototype._handleSelectionPathComponentSiblingSelected):

UserInterface/Views/MediaTimelineView.css: Added.

(.timeline-view.media > .data-grid):

UserInterface/Views/DOMEventsBreakdownView.js:

(WI.DOMEventsBreakdownView.prototype.layout):

UserInterface/Views/DOMNodeEventsContentView.js:

(WI.DOMNodeEventsContentView.prototype.initialLayout):

UserInterface/Views/NetworkDOMNodeDetailView.js:

(WI.NetworkDOMNodeDetailView):
(WI.NetworkDOMNodeDetailView.prototype.showContentViewForIdentifier):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get filterNavigationItems):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype._showDetailView):
(WI.NetworkTableContentView.prototype._waterfallPopoverContentForNodeEntry):
Remove passing of startTimestamp to WI.DOMEventsBreakdownView, as we should be showing
absolute timestamps for each event, not relative to the start of the recording.

UserInterface/Views/TimelineIcons.css:

(.media-icon .icon): Added.
(.dom-event-record .icon): Added.
(.dom-event-record.fullscreen .icon): Added.
(.low-power-record .icon): Added.

UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.availableTimelineTypes):
(WI.TimelineManager.prototype.capturingStarted):
(WI.TimelineManager.prototype.capturingStopped):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
(WI.TimelineManager.prototype._handleDOMNodeDidFireEvent): Added.
(WI.TimelineManager.prototype._handleDOMNodeLowPowerChanged): Added.

UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler.prototype.clearMarkers):
(WI.TimelineRuler.prototype._handleClick):

UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._timelineRulerMouseClicked):

UserInterface/Models/TimelineRecording.js:

(WI.TimelineRecording.prototype.reset):
(WI.TimelineRecording.prototype.addEventMarker):
(WI.TimelineRecording.prototype.addRecord):
(WI.TimelineRecording.prototype._keyForRecord):
Drive-by: rework the logic for "click" event pass-through to the graph underneath.

UserInterface/Models/Instrument.js:

(WI.Instrument.createForTimelineType):

UserInterface/Models/TimelineRecord.js:

UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.displayNameForTimelineType):
(WI.TimelineTabContentView.iconClassNameForTimelineType):
(WI.TimelineTabContentView.genericClassNameForTimelineType):
(WI.TimelineTabContentView.iconClassNameForRecord):
(WI.TimelineTabContentView.displayNameForRecord):

UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-media > .segment): Added.

UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):

UserInterface/Views/TimelineOverviewGraph.js:

(WI.TimelineOverviewGraph.createForTimeline):

UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

UserInterface/Main.html:
UserInterface/Test.html:
Localizations/en.lproj/localizedStrings.js:
UserInterface/Images/DOMEvent.svg: Added.
UserInterface/Images/DOMEventFullscreen.svg: Added.
UserInterface/Images/LowPower.svg: Added.
UserInterface/Images/MediaInstrument.svg: Added.

1:44 PM Changeset in webkit [238483] by Matt Baker

14 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove parameters from TreeOutline SelectionDidChange event
https://bugs.webkit.org/show_bug.cgi?id=191770

Reviewed by Devin Rousso.

UserInterface/Controllers/CallFrameTreeController.js:

(WI.CallFrameTreeController.prototype._treeSelectionDidChange):

UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):

UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel):
(WI.CanvasSidebarPanel.prototype._treeSelectionDidChange):
(WI.CanvasSidebarPanel.prototype._treeOutlineSelectionDidChange): Deleted.

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype._canvasTreeOutlineSelectionDidChange):

UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype._treeSelectionDidChange):

UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._treeSelectionDidChange):

UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):

UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype._treeSelectionDidChange):

UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel._treeSelectionDidChange):

UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid.prototype._popoverCallStackTreeSelectionDidChange):
(WI.TimelineDataGrid):

UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.prototype._recordingsTreeSelectionDidChange):
Use event.target.selectedTreeElement instead of event.data.selectedElement.

UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange):
(WI.TimelineOverview.prototype._timelinesTreeSelectionDidChange.updateGraphSelectedState): Deleted.
Refactor away the single place event.data.deselectedElement was used.

UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype.select):
(WI.TreeElement.prototype.deselect):
Remove selectedElement and deselectedElement from event data.

1:35 PM Changeset in webkit [238482] by Alan Bujtas

10 edits in trunk/Source/WebCore

[LFC] Remove PointInContainingBlock and PositionInContainingBlock
https://bugs.webkit.org/show_bug.cgi?id=191954

Reviewed by Antti Koivisto.

Use Point and Position instead. Points and positions are by default in the containing block's coordinate system.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):

layout/LayoutUnits.h:

(WebCore::Layout::Position::operator LayoutUnit const):
(WebCore::Layout::operator<):
(WebCore::Layout::operator==):

layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
(WebCore::Layout::FloatAvoider::horizontalPositionCandidate):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):

layout/floats/FloatBox.cpp:

(WebCore::Layout::FloatBox::horizontalPositionCandidate):
(WebCore::Layout::FloatBox::verticalPositionCandidate):
(WebCore::Layout::FloatBox::initialVerticalPosition const):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFloatAvoiding const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingPair::horizontalConstraints const):
(WebCore::Layout::FloatingPair::bottom const):

layout/floats/FloatingContext.h:
layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):
(WebCore::Layout::FloatingState::bottom const):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::FloatItem::bottom const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::initializeNewLine const):

1:32 PM Changeset in webkit [238481] by Alan Bujtas

7 edits in trunk/Source/WebCore

[LFC] Rename Layout::Position to Layout::Point
https://bugs.webkit.org/show_bug.cgi?id=191950

Reviewed by Antti Koivisto.

It actually represents a point.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::mapTopLeftToAncestor):
(WebCore::Layout::FormattingContext::mapCoordinateToAncestor):

layout/FormattingContext.h:
layout/LayoutUnits.h:

(WebCore::Layout::Point::Point):
(WebCore::Layout::Point::moveBy):
(WebCore::Layout::Position::operator LayoutPoint const): Deleted.
(WebCore::Layout::Position::Position): Deleted.
(WebCore::Layout::Position::moveBy): Deleted.

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):

1:30 PM Changeset in webkit [238480] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Floating code should use typed positions (PositionInContextRoot).
https://bugs.webkit.org/show_bug.cgi?id=191949

Reviewed by Antti Koivisto.

Use PositionInContextRoot instead of LayoutUnit.

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::constraints const):
(WebCore::Layout::FloatingState::bottom const):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::leftBottom const):
(WebCore::Layout::FloatingState::rightBottom const):
(WebCore::Layout::FloatingState::bottom const):

1:28 PM Changeset in webkit [238479] by Alan Bujtas

4 edits in trunk/Source/WebCore

Fix build after r238472.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::runWidth):

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::textWidth const):

10:22 AM Changeset in webkit [238478] by Michael Catanzaro

2 edits in trunk/Source/WTF

CRASH() should call abort() except on Darwin and in developer builds
https://bugs.webkit.org/show_bug.cgi?id=184408

Reviewed by Daniel Bates.

CRASH() should call abort() except on Darwin and in developer builds, as discussed on
webkit-dev. This should be slightly nicer than dereferencing 0xbadbeef.

On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we
can't do that.

Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it
is reportedly useful in nightmare scenarios where core dumps are unavailable.

We also have to define CRASH_UNDER_CONSTEXPR_CONTEXT(). It's a bit odd that it's possible to
use a non-constexpr function here, but it works. Currently this macro uses WTFCrash(), which
is also non-constexpr.

wtf/Assertions.h:

8:22 AM Changeset in webkit [238477] by Michael Catanzaro

2 edits in trunk/Source/WTF

Unreviewed, rolling out r238469.

Broke the build

Reverted changeset:

"CRASH() should call abort() except on Darwin and in developer
builds"
https://bugs.webkit.org/show_bug.cgi?id=184408
https://trac.webkit.org/changeset/238469

4:19 AM Changeset in webkit [238476] by Antti Koivisto

8 edits in trunk/Source/WebKit

RemoteLayerTreeNode construction cleanups
https://bugs.webkit.org/show_bug.cgi?id=191951

Reviewed by Tim Horton.

UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):

Drop unused LayerProperties argument.

(WebKit::RemoteLayerTreeHost::createLayer):

Split the actual construction out to makeNode.
Map updating is shared between platforms.
Move setting of layerID and clearing default actions to RemoteLayerTreeNode.

(WebKit::RemoteLayerTreeHost::makeNode):

Returns RemoteLayerTreeNode.

(WebKit::RemoteLayerTreeHost::setLayerID): Deleted.
(WebKit::RemoteLayerTreeHost::layerID): Deleted.

Move to RemoteLayerTreeNode.

UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:

(WebKit::RemoteLayerTreeNode::RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::setLayerID):
(WebKit::RemoteLayerTreeNode::layerID):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::makeNode):
(WebKit::RemoteLayerTreeHost::createEmbeddedView):
(WebKit::RemoteLayerTreeHost::createLayer): Deleted.

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(-[WKCompositingView description]):
(-[WKUIRemoteView description]):
(-[WKBackdropView description]):

WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::addAnimationToLayer):

4:11 AM Changeset in webkit [238475] by timothy_horton@apple.com

25 edits
1 copy
7 adds in trunk

Make it possible to insert editable images with a gesture
https://bugs.webkit.org/show_bug.cgi?id=191937

Reviewed by Wenson Hsieh.

Source/WebCore:

Tests:

editing/images/redo-insert-editable-image-maintains-strokes.html,
editing/images/undo-insert-editable-image.html,
editing/images/basic-editable-image-from-execCommand.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
Source/WebCore/editing/EditorCommand.cpp:
Source/WebCore/en.lproj/Localizable.strings:
editing/EditAction.h:
editing/Editor.cpp:

(WebCore::Editor::insertEditableImage):

editing/Editor.h:
editing/InsertEditableImageCommand.cpp: Added.

(WebCore::InsertEditableImageCommand::InsertEditableImageCommand):
(WebCore::InsertEditableImageCommand::doApply):

editing/InsertEditableImageCommand.h: Added.

(WebCore::InsertEditableImageCommand::create):

editing/VisibleSelection.cpp:

Add an editor command that inserts an editable image.
It will likely get a bit more complicated, but for now it just inserts
a 100% by 300px editable image.

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _stylusTapGestureShouldCreateEditableImage]):

UIProcess/API/Cocoa/WKWebViewInternal.h:

Add a internal getter for a WKWebViewConfiguration property.

UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):
Add a undo name.

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
Add a single-stylus-tap gesture recognizer.

(-[WKContentView _stylusSingleTapRecognized:]):
If allowed, request to insert an editable image when a stylus tap occurs.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleStylusSingleTapAtPoint):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleStylusSingleTapAtPoint):
Do a hit test, select the hit position, insert an editable image, and
then de-assist any assisted node (to make the keyboard go away).
For now, we'll only insert if we hit non-replaced elements,
though this heuristic will need to be enhanced significantly once we
decide on a design.

Source/WebKitLegacy/mac:

WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):
Add a undo name.

Tools:

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::drawSquareInEditableImage):
If the canvas already has a drawing, draw a new stroke on top of it
instead of removing the existing stroke.

LayoutTests:

editing/images/basic-editable-image-from-execCommand-expected.txt: Added.
editing/images/basic-editable-image-from-execCommand.html: Added.

Add a test that ensures that editable images also work when
inserted via the editor command.

editing/images/redo-insert-editable-image-maintains-strokes-expected.txt: Added.
editing/images/redo-insert-editable-image-maintains-strokes.html: Added.

Add a test that ensures that strokes are maintained when re-doing an
un-done editable image insertion.

editing/images/undo-insert-editable-image-expected.txt: Added.
editing/images/undo-insert-editable-image.html: Added.

Add a test that ensures that the selection stays in a sensible place
when undoing and redoing editable image insertion.

4:05 AM Changeset in webkit [238474] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit

Scrolling and drawing compete for incoming gestures
https://bugs.webkit.org/show_bug.cgi?id=191940

Reviewed by Wenson Hsieh.

Platform/spi/ios/PencilKitSPI.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
Make scrolling and drawing mutually exclusive if editable images
are enabled.

Nov 24, 2018:

5:45 PM Changeset in webkit [238473] by Wenson Hsieh

6 edits in trunk/Source

[Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
https://bugs.webkit.org/show_bug.cgi?id=191945

Reviewed by Anders Carlsson.

Source/WebCore:

Run update-webkit-localizable-strings.

en.lproj/Localizable.strings:

Source/WebKit:

Replace some a couple of command undo action name descriptions with "Undo action name", to match all other
edit commands.

UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

Source/WebKitLegacy/mac:

WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

4:37 PM Changeset in webkit [238472] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Remove now unnecessary specialized ListHashSet from InlineItem.h
https://bugs.webkit.org/show_bug.cgi?id=191946

Patch by Sam Weinig <sam@webkit.org> on 2018-11-24
Reviewed by Zalan Bujtas.

Now that ListHashSet supports raw pointer overloads for smart pointers,
we can fix the FIXME in InlineItem.h and remove the specialized ListHashSet
and ListHashSet::find calls.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::runWidth):

layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItemHashFunctions::hash): Deleted.
(WebCore::Layout::InlineItemHashFunctions::equal): Deleted.
(WebCore::Layout::InlineItemHashTranslator::hash): Deleted.
(WebCore::Layout::InlineItemHashTranslator::equal): Deleted.

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::textWidth const):

1:06 PM Changeset in webkit [238471] by Wenson Hsieh

19 edits
1 copy
1 add in trunk

[Cocoa] Add WKWebView SPI to trigger and remove data detection
https://bugs.webkit.org/show_bug.cgi?id=191918
<rdar://problem/36185051>

Reviewed by Tim Horton.

Source/WebCore:

Add a helper method on DataDetection to remove all data detected links in the given document. See WebKit changes
for more detail.

editing/cocoa/DataDetection.h:
editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::removeDataDetectedLinksInDocument):

Source/WebKit:

Adds support for two new WKWebView SPI methods, -_detectDataWithTypes:completionHandler: and
-_removeAllDataDetectedLinks:, to allow internal WebKit clients to run data detection and add links to data
detected content, or remove all data detected links from the document.

Test: WebKit.AddAndRemoveDataDetectors

Shared/Cocoa/DataDetectionResult.h:
Shared/Cocoa/DataDetectionResult.mm:

(WebKit::DataDetectionResult::decode):

Modernize DataDetectionResult's IPC decoding, so that it can be used with reply-based async IPC.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _removeDataDetectedLinks:]):
(-[WKWebView _detectDataWithTypes:completionHandler:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::detectDataInAllFrames):
(WebKit::WebPageProxy::removeDataDetectedLinks):

Add or remove data detected links from each frame in the page, and then propagate the new data detector
results of the main frame to the UI process (this matches current behavior, where the results of -[WKWebView
_dataDetectionResults] only reflects data detection results in the main frame of the page).

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::removeDataDetectedLinks):
(WebKit::WebPage::detectDataInAllFrames):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Add an API test to exercise the new WebKit SPI.

TestWebKitAPI/DataDetectorsCoreSPI.h: Added.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:

(-[WKWebView synchronouslyDetectDataWithTypes:]):
(-[WKWebView synchronouslyRemoveDataDetectedLinks]):
(TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):
(-[TestWKWebView tagsInBody]): Deleted.
(-[TestWKWebView expectElementTagsInOrder:]): Deleted.
(-[TestWKWebView expectElementCount:tagName:]): Deleted.
(-[TestWKWebView expectElementTag:toComeBefore:]): Deleted.

Rename this from -expectElementCount:tagName: to -expectElementCount:querySelector:.

TestWebKitAPI/Tests/WebKitCocoa/data-detectors.html: Added.

Add a new test page containing some content that can be data detected.

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[WKWebView tagsInBody]):
(-[WKWebView expectElementTagsInOrder:]):
(-[WKWebView expectElementCount:querySelector:]):
(-[WKWebView expectElementTag:toComeBefore:]):

Move some testing helper functions from WKAttachmentTests to a testing category on WKWebView. This allows us to
use -expectElementCount:querySelector: in tests outside of WKAttachmentTests.

(-[WKWebView objectByEvaluatingJavaScript:]):
(-[WKWebView objectByEvaluatingJavaScriptWithUserGesture:]):
(-[WKWebView stringByEvaluatingJavaScript:]):

Move some common helper functions from TestWKWebView to a testing category on WKWebView.

(-[TestWKWebView objectByEvaluatingJavaScript:]): Deleted.
(-[TestWKWebView objectByEvaluatingJavaScriptWithUserGesture:]): Deleted.
(-[TestWKWebView stringByEvaluatingJavaScript:]): Deleted.

10:37 AM Changeset in webkit [238470] by aestes@apple.com

16 edits in trunk/Source

[Cocoa] SOFT_LINK_CLASS_FOR_{HEADER,SOURCE} should generate a more concise getter function
https://bugs.webkit.org/show_bug.cgi?id=191899

Reviewed by Dean Jackson.

Source/WebCore:

editing/cocoa/DataDetection.mm:
editing/cocoa/FontAttributesCocoa.mm:
editing/cocoa/FontShadowCocoa.mm:
platform/cocoa/DataDetectorsCoreSoftLink.h:
platform/graphics/cocoa/ColorCocoa.mm:
platform/ios/PlatformScreenIOS.mm:

Source/WebCore/PAL:

pal/cocoa/PassKitSoftLink.h:
pal/ios/UIKitSoftLink.h:

Source/WebKit:

Shared/cocoa/WebCoreArgumentCodersCocoa.mm:
UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

Source/WTF:

Currently, SOFT_LINK_CLASS_FOR_HEADER declares a class getter function that includes the
framework name. For example, NSView would have a class getter named
namespace::get_AppKit_NSViewClass().

Including the framework name in the getter is unnecessary. Objective-C classes already exist
in a global namespace, so there is no need to disambiguate class names by framework. This
patch elides the framework name from the getter function. For example, NSView would now have
a getter named namespace::getNSViewClass().

wtf/cocoa/SoftLinking.h:

7:13 AM Changeset in webkit [238469] by Michael Catanzaro

2 edits in trunk/Source/WTF

CRASH() should call abort() except on Darwin and in developer builds
https://bugs.webkit.org/show_bug.cgi?id=184408

Reviewed by Daniel Bates.

CRASH() should call abort() except on Darwin and in developer builds, as discussed on
webkit-dev. This should be slightly nicer than dereferencing 0xbadbeef.

On Darwin, CRASH() uses a breakpoint trap, which seems to corrupt the stack on Linux, so we
can't do that.

Continue to call WTFCrash() in developer mode, and make no changes to WTFCrash(), since it
is reportedly useful in nightmare scenarios where core dumps are unavailable.

wtf/Assertions.h:

Nov 23, 2018:

11:17 PM Changeset in webkit [238468] by Antti Koivisto

27 edits
2 moves in trunk/Source/WebKit

Replace LayerOrView typedef with a class
https://bugs.webkit.org/show_bug.cgi?id=191927

Reviewed by Tim Horton.

This typedef restricts remote layer representation to be either a CA layer or a view. We might want
have more flexibility, for example tiles don't really need to be UIViews. It will also make it easier
to unify Mac and iOS code, and hopefully make it less confusing too.

This patch introduces RemoteLayerTreeNode class that replaces most uses of LayerOrView typedef
(the rest are converted to pure CALayer). It also does a bunch of related cleanup.

Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.h:
Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView):
(WebKit::applyPropertiesToLayer): Deleted.

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _propertiesOfLayerWithID:]):

UIProcess/Cocoa/LayerRepresentation.h: Removed.
UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):

UIProcess/PageClient.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::layerWithIDForTesting const):

UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:

(WebKit::RemoteLayerTreeHost::rootNode const):
(WebKit::RemoteLayerTreeHost::rootLayer const): Deleted.

UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::nodeForID const):
(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::animationDidStart):
(WebKit::RemoteLayerTreeHost::animationDidEnd):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::layerWithIDForTesting const):
(WebKit::RemoteLayerTreeHost::layerForID const):
(WebKit::RemoteLayerTreeHost::rootLayer const):
(WebKit::RemoteLayerTreeHost::createLayer):
(WebKit::RemoteLayerTreeHost::detachRootLayer):
(WebKit::RemoteLayerTreeHost::mapAllIOSurfaceBackingStore):
(WebKit::RemoteLayerTreeHost::getLayer const): Deleted.

UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: Added.

(WebKit::RemoteLayerTreeNode::layer const):
(WebKit::RemoteLayerTreeNode::uiView const):

UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: Added.

(WebKit::RemoteLayerTreeNode::RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::detachFromParent):

UIProcess/RemoteLayerTree/RemoteLayerTreeScrollingPerformanceData.mm:

(WebKit::RemoteLayerTreeScrollingPerformanceData::blankPixelCount const):

UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
(WebKit::layerRepresentationFromLayerOrView): Deleted.

UIProcess/WebAuthentication/Cocoa/HidService.h:
UIProcess/WebAuthentication/Cocoa/HidService.mm:
UIProcess/WebPageProxy.h:
UIProcess/ios/LayerRepresentation.mm: Removed.
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setRemoteLayerTreeRootNode):
(WebKit::PageClientImpl::acceleratedCompositingRootLayer const):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setRemoteLayerTreeRootNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer): Deleted.

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setRemoteLayerTreeRootNode):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer): Deleted.

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setRemoteLayerTreeRootNode):
(WebKit::WebPageProxy::acceleratedCompositingRootLayer const):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer): Deleted.

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):

10:08 PM Changeset in webkit [238467] by commit-queue@webkit.org

5 edits in trunk

Add raw pointer overloads to ListHashSet via SmartPtr specialized functions
https://bugs.webkit.org/show_bug.cgi?id=191936

Patch by Sam Weinig <sam@webkit.org> on 2018-11-23
Reviewed by Zalan Bujtas.

Source/WTF:

Adds overloads for find, contains, insertBefore and remove that take raw pointers
when the value type V of a ListHashSet is true for the predicate IsSmartPtr<V>::value.
This brings the interface to ListHashSet closer inline with HashSet, HashMap and HashCountedSet
which already have this functionality. Like in the other collections, this is especially
useful when using std::unique_ptr<> as the value, since there would be no way to pass it
to these functions. One difference between this set of overloads is the inclusion of insertBefore,
which is unique to ListHashSet. As would be expected, this specialization only changes the first
parameter, the one that needs to be found, to support a raw pointer.

wtf/ListHashSet.h:

(WTF::U>::find):
(WTF::U>::find const):
(WTF::U>::contains const):
(WTF::U>::insertBefore):
(WTF::U>::remove):

Tools:

Adds tests for raw pointer overloads in ListHashSet.

TestWebKitAPI/Tests/WTF/HashSet.cpp:
TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

7:51 PM Changeset in webkit [238466] by jiewen_tan@apple.com

4 edits in trunk/Source

[WebAuthN] Enable Web Authentication as an experimental feature for macOS
https://bugs.webkit.org/show_bug.cgi?id=191932
rdar://problem/46225210

Reviewed by Brent Fulgham.

Source/WebCore:

Add myself to the contact of Web Authentication.

features.json:

Source/WebKit:

Shared/WebPreferences.yaml:

6:17 PM Changeset in webkit [238465] by rniwa@webkit.org

3 edits
3 adds in trunk

REGRESSION (r236785): Nullptr crash in StyledMarkupAccumulator::traverseNodesForSerialization
https://bugs.webkit.org/show_bug.cgi?id=191921

Reviewed by Dean Jackson.

Source/WebCore:

The bug was caused by traverseNodesForSerialization not being able to traverse past the end of shadow root
when skipping children of a node for which enterNode returns false because it was using NodeTraversal's
nextSkippingChildren instead of a member function which supports traversing the composed tree.

Fixed the crash by using variant of nextSkippingChildren which knows how to traverse past the last node
in a shadow tree. Also added more assertions to help debug issues like this in the future.

Test: editing/pasteboard/copy-paste-across-shadow-boundaries-5.html

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

LayoutTests:

Added a regression test.

editing/pasteboard/copy-paste-across-shadow-boundaries-5-expected.txt: Added.
editing/pasteboard/copy-paste-across-shadow-boundaries-5.html: Added.
platform/ios/editing/pasteboard/copy-paste-across-shadow-boundaries-5-expected.txt: Added.

2:06 PM Changeset in webkit [238464] by rniwa@webkit.org

3 edits
2 adds in trunk

Updating href on textPath doesn't update its rendering
https://bugs.webkit.org/show_bug.cgi?id=191920

Reviewed by Dean Jackson.

Source/WebCore:

Fixed the bug by invalidating the RenderSVGResource in SVGTextPathElement::svgAttributeChanged
in addition to updating the pending resources.

Test: svg/text/textpath-reference-update.html

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::svgAttributeChanged):

LayoutTests:

Added a ref test.

svg/text/textpath-reference-update-expected.html: Added.
svg/text/textpath-reference-update.html: Added.

12:47 PM Changeset in webkit [238463] by Ross Kirsling

78 edits in trunk/Source/WebCore

Introduce user-defined literal for LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=191915

Reviewed by Dean Jackson.

platform/LayoutUnit.h:

Introduce a user-defined literal for LayoutUnit, _lu, replacing the existing "fromPixel" factory function.

layout/FormattingContextGeometry.cpp:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:
layout/inlineformatting/InlineLineBreaker.cpp:
page/FrameView.cpp:
page/FrameViewLayoutContext.h:
page/Page.cpp:
page/SpatialNavigation.h:
platform/ScrollableArea.cpp:
rendering/EllipsisBox.cpp:
rendering/FlexibleBoxAlgorithm.cpp:
rendering/FloatingObjects.cpp:
rendering/GridLayoutFunctions.cpp:
rendering/GridTrackSizingAlgorithm.cpp:
rendering/InlineFlowBox.cpp:
rendering/InlineTextBox.cpp:
rendering/LayoutState.h:
rendering/LogicalSelectionOffsetCaches.h:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:
rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:
rendering/RenderBox.cpp:
rendering/RenderBoxModelObject.cpp:
rendering/RenderDeprecatedFlexibleBox.cpp:
rendering/RenderDeprecatedFlexibleBox.h:
rendering/RenderElement.cpp:
rendering/RenderFlexibleBox.cpp:
rendering/RenderFlexibleBox.h:
rendering/RenderFragmentContainer.cpp:
rendering/RenderFragmentedFlow.cpp:
rendering/RenderGrid.cpp:
rendering/RenderGrid.h:
rendering/RenderImage.cpp:
rendering/RenderLayer.cpp:
rendering/RenderListMarker.cpp:
rendering/RenderMultiColumnFlow.cpp:
rendering/RenderMultiColumnSet.cpp:
rendering/RenderReplaced.cpp:
rendering/RenderReplaced.h:
rendering/RenderRubyRun.h:
rendering/RenderTable.cpp:
rendering/RenderTable.h:
rendering/RenderTableSection.cpp:
rendering/RenderTheme.cpp:
rendering/RenderTreeAsText.cpp:
rendering/RenderView.cpp:
rendering/RootInlineBox.h:
rendering/SimpleLineLayout.cpp:
rendering/SimpleLineLayoutPagination.cpp:
rendering/TableLayout.h:
rendering/line/BreakingContext.h:
rendering/line/LineLayoutState.h:
rendering/line/LineWidth.h:
rendering/mathml/MathOperator.cpp:
rendering/mathml/MathOperator.h:
rendering/mathml/RenderMathMLBlock.h:
rendering/mathml/RenderMathMLFraction.cpp:
rendering/mathml/RenderMathMLFraction.h:
rendering/mathml/RenderMathMLMath.cpp:
rendering/mathml/RenderMathMLMath.h:
rendering/mathml/RenderMathMLMenclose.h:
rendering/mathml/RenderMathMLOperator.cpp:
rendering/mathml/RenderMathMLOperator.h:
rendering/mathml/RenderMathMLPadded.h:
rendering/mathml/RenderMathMLRoot.cpp:
rendering/mathml/RenderMathMLRoot.h:
rendering/mathml/RenderMathMLRow.h:
rendering/mathml/RenderMathMLScripts.cpp:
rendering/mathml/RenderMathMLScripts.h:
rendering/mathml/RenderMathMLSpace.h:
rendering/mathml/RenderMathMLToken.cpp:
rendering/mathml/RenderMathMLToken.h:
rendering/mathml/RenderMathMLUnderOver.h:
rendering/shapes/ShapeOutsideInfo.cpp:
rendering/style/CollapsedBorderValue.h:

Update all instances of LayoutUnit(), LayoutUnit(0), LayoutUnit { 0 }, etc. and add any other
literal conversions that will be needed when making non-int LayoutUnit constructors explicit.
For good measure, also mark all default values for LayoutUnit parameters.

11:45 AM Changeset in webkit [238462] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
https://bugs.webkit.org/show_bug.cgi?id=191067

Updated code per the style guide, removed unreachable break (non-semantic change)

Patch by Jim Mason <jmason@ibinx.com> on 2018-11-23
Reviewed by Michael Catanzaro.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::handleMousePressEvent):

10:18 AM Changeset in webkit [238461] by Wenson Hsieh

16 edits in trunk

Enable drag and drop support for iOSMac
https://bugs.webkit.org/show_bug.cgi?id=191818
<rdar://problem/43907454>

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enables drag and drop by default on iOSMac by switching on ENABLE_DATA_INTERACTION and ENABLE_DRAG_SUPPORT. This
enables support for dragging links, text selections, and images, though many advanced features (e.g. custom
pasteboard data) will require additional support from the platform.

Configurations/FeatureDefines.xcconfig:
platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::informationForItemAtIndex):
(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderLoadResult canBeRepresentedAsFileUpload]):
(-[WebItemProviderPasteboard numberOfFiles]):

Disable codepaths which attempt to access or set teamData or preferredPresentationStyle on NSItemProvider
in iOSMac, since these are currently unimplemented.

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:
Shared/WebPreferencesDefaultValues.cpp:

(defaultCustomPasteboardDataEnabled):

Enable custom pasteboard data by default on iOSMac. While writing and reading custom pasteboard data is
currently broken in iOSMac due to the lack of teamData and preferredPresentationStyle, opting into custom
pasteboard data at least allows us to avoid writing unsanitized data types to the pasteboard.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Fix a regression from <https://trac.webkit.org/r236619> wherein the web process crashes when attempting to edit
a text field. This happens because the call to -[UIKeyboard isInHardwareKeyboardMode] on the iOSMac platform
attempts to initialize a UHASWorkspace from the web process, which then attempts to connect to the UIKit host
application. Instead, we can skip this call altogether on iOSMac, where the platform never considers a hardware
keyboard to be "connected", even when typing.

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:05 AM Changeset in webkit [238460] by Alan Bujtas

11 edits
2 adds in trunk

[LFC][IFC] Add support for variable height runs.
https://bugs.webkit.org/show_bug.cgi?id=191925

Reviewed by Antti Koivisto.

Source/WebCore:

https://www.w3.org/TR/CSS22/visudet.html#inline-box-height

10.8 Line height calculations: the 'line-height' and 'vertical-align' properties

The height of each inline-level box in the line box is calculated. For replaced elements, inline-block elements,
and inline-table elements, this is the height of their margin box; for inline boxes, this is their 'line-height'.

The line box height is the distance between the uppermost box top and the lowermost box bottom.

The minimum height consists of a minimum height above the baseline and a minimum depth below it,
exactly as if each line box starts with a zero-width inline box with the element's font and line height properties.
We call that imaginary box a "strut." (The name is inspired by TeX.).

Test: fast/inline/inline-content-with-image-simple.html

layout/Verification.cpp:

(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
(WebCore::Layout::InlineFormattingContext::createFinalRuns const):
(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):

layout/inlineformatting/InlineFormattingContext.h:

(WebCore::Layout::InlineFormattingContext::Line::logicalHeight const):

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::justifyRuns):

layout/inlineformatting/InlineRun.h:

(WebCore::Layout::InlineRun::logicalWidth const):
(WebCore::Layout::InlineRun::logicalHeight const):
(WebCore::Layout::InlineRun::setLogicalWidth):
(WebCore::Layout::InlineRun::width const): Deleted.
(WebCore::Layout::InlineRun::height const): Deleted.
(WebCore::Layout::InlineRun::setWidth): Deleted.

layout/inlineformatting/Line.cpp:

(WebCore::Layout::InlineFormattingContext::Line::init):
(WebCore::Layout::InlineFormattingContext::Line::appendContent):
(WebCore::Layout::InlineFormattingContext::Line::close):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-image-simple-expected.txt: Added.
fast/inline/inline-content-with-image-simple.html: Added.

7:07 AM Changeset in webkit [238459] by Antti Koivisto

5 edits in trunk/Source

UI side compositing doesn't paint on Mac
https://bugs.webkit.org/show_bug.cgi?id=191908

Reviewed by Tim Horton.

Source/WebCore:

For clarity put RGB10 and RGB10A8 formats behind PLATFORM(IOS_FAMILY). They are not supported on Mac.

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::IOSurface):
(WebCore::IOSurface::ensurePlatformContext):
(WebCore::IOSurface::format const):
(WebCore::operator<<):

Source/WebKit:

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::bytesPerPixel const):
(WebKit::RemoteLayerBackingStore::surfaceBufferFormat const):

These deep color formats are not supported on Mac.

5:36 AM Changeset in webkit [238458] by berto@igalia.com

3 edits in trunk/Tools

[GTK] [WPE] Tools/Platform{GTK,WPE}.cmake files missing from the tarballs
https://bugs.webkit.org/show_bug.cgi?id=191923

Add Tools/PlatformGTK.cmake and Tools/PlatformWPE.cmake to their
respective tarballs.

Reviewed by Carlos Garcia Campos.

gtk/manifest.txt.in:
wpe/manifest.txt.in:

3:04 AM Changeset in webkit [238457] by jfernandez@igalia.com

60 edits
14 adds in trunk

[css-grid] Implement Baseline Alignment for grid items
https://bugs.webkit.org/show_bug.cgi?id=145566

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Updated test expectations of severla tests, that are now passing with the new code.

resources/import-expectations.json:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-001-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-002-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-003-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-004-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-005-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-006-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-007-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-alignment-style-changes-008-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-001-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-002-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-003-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-column-axis-self-baseline-synthesized-004-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-001-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-002-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-003-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-row-axis-self-baseline-synthesized-004-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-001-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-002-expected.txt:
web-platform-tests/css/css-grid/alignment/grid-self-baseline-not-applied-if-sizing-cyclic-dependency-003-expected.txt:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-007.html:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-009.html:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-010.html:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html:
web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-012.html:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002-expected.txt:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002-expected.txt:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002-expected.txt:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-002-expected.txt:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:

Source/WebCore:

This patch impements the Baseline Self-Alignment feature for grid items according to
the CSS Box Alignment specification [1].

This new layout logic is handled by the Self-Alignment (justify-self and align-self)
and Default-Alignment (justify-items and align-items) CSS properties.

This feature allows users to align the grid items sharing a Baseline Alignment Context,
either row or column contexts, based on their respective baselines.

[1] https://drafts.csswg.org/css-align-3/#baseline-align-self

Tests: fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash.html

fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash.html
fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash.html
fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash.html
fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash.html
fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash.html

Sources.txt:
rendering/GridBaselineAlignment.cpp: Added.

(WebCore::GridBaselineAlignment::marginOverForChild const):
(WebCore::GridBaselineAlignment::marginUnderForChild const):
(WebCore::GridBaselineAlignment::logicalAscentForChild const):
(WebCore::GridBaselineAlignment::ascentForChild const):
(WebCore::GridBaselineAlignment::descentForChild const):
(WebCore::GridBaselineAlignment::isDescentBaselineForChild const):
(WebCore::GridBaselineAlignment::isHorizontalBaselineAxis const):
(WebCore::GridBaselineAlignment::isOrthogonalChildForBaseline const):
(WebCore::GridBaselineAlignment::isParallelToBaselineAxisForChild const):
(WebCore::GridBaselineAlignment::baselineGroupForChild const):
(WebCore::GridBaselineAlignment::updateBaselineAlignmentContext):
(WebCore::GridBaselineAlignment::baselineOffsetForChild const):
(WebCore::GridBaselineAlignment::clear):
(WebCore::BaselineGroup::BaselineGroup):
(WebCore::BaselineGroup::update):
(WebCore::BaselineGroup::isOppositeBlockFlow const):
(WebCore::BaselineGroup::isOrthogonalBlockFlow const):
(WebCore::BaselineGroup::isCompatible const):
(WebCore::BaselineContext::BaselineContext):
(WebCore::BaselineContext::sharedGroup const):
(WebCore::BaselineContext::updateSharedGroup):
(WebCore::BaselineContext::findCompatibleSharedGroup):

rendering/GridBaselineAlignment.h: Added.

(WebCore::BaselineGroup::maxAscent const):
(WebCore::BaselineGroup::maxDescent const):
(WebCore::BaselineGroup::size const):
(WebCore::isBaselinePosition):
(WebCore::GridBaselineAlignment::setBlockFlow):

rendering/GridLayoutFunctions.h:
rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::gridAxisForDirection):
(WebCore::gridDirectionForAxis):
(WebCore::GridTrackSizingAlgorithm::availableSpace const):
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::canParticipateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::participateInBaselineAlignment const):
(WebCore::GridTrackSizingAlgorithm::updateBaselineAlignmentContext):
(WebCore::GridTrackSizingAlgorithm::baselineOffsetForChild const):
(WebCore::GridTrackSizingAlgorithm::clearBaselineItemsCache):
(WebCore::GridTrackSizingAlgorithm::cacheBaselineAlignedItem):
(WebCore::GridTrackSizingAlgorithm::copyBaselineItemsCache):
(WebCore::GridTrackSizingAlgorithm::setup):
(WebCore::GridTrackSizingAlgorithm::computeBaselineAlignmentContext):

rendering/GridTrackSizingAlgorithm.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::firstLineBaseline const):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::performGridItemsPreLayout const):
(WebCore::synthesizedBaselineFromMarginBox):
(WebCore::RenderGrid::isBaselineAlignmentForChild const):
(WebCore::RenderGrid::baselinePosition const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::inlineBlockBaseline const):
(WebCore::RenderGrid::columnAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::rowAxisBaselineOffsetForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):

rendering/RenderGrid.h:

LayoutTests:

Most of the baseline realated tests pass now; just a few still fail because of unrelated bugs.

TestExpectations: Removed several entries, related to the baseline tests that are now passing.
fast/css-grid-layout/grid-align-baseline-expected.txt:
fast/css-grid-layout/grid-align-baseline-vertical-expected.txt:
fast/css-grid-layout/grid-baseline-expected.html:
fast/css-grid-layout/grid-baseline-margins-expected.html:
fast/css-grid-layout/grid-baseline-margins.html:
fast/css-grid-layout/grid-baseline-must-respect-grid-order-expected.txt:
fast/css-grid-layout/grid-baseline-must-respect-grid-order.html:
fast/css-grid-layout/grid-baseline.html:
fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-and-flex-tracks-with-indefinite-container-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-and-flexible-tracks-should-not-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-and-item-relayout-should-not-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-and-relative-sized-items-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-and-relative-sized-tracks-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash-expected.txt: Added.
fast/css-grid-layout/grid-self-baseline-followed-by-item-style-change-should-not-crash.html: Added.
fast/css-grid-layout/grid-self-baseline-two-dimensional-expected.txt:
fast/css-grid-layout/grid-self-baseline-two-dimensional.html:

Nov 22, 2018:

8:36 PM Changeset in webkit [238456] by Chris Dumez

4 edits in trunk

Regression(r238353) Load sometimes hangs when navigating back after a cross-site navigation
https://bugs.webkit.org/show_bug.cgi?id=191914

Reviewed by Ryosuke Niwa.

Source/WebKit:

When process-swapping on a cross-site server-side redirect, we end up doing a decidePolicyForNavigationResponse
policy check for the about:blank suspension load. This policy decision is ignored by the UIProcess because
SuspendedPageProxy does not handle this particular IPC message. To handle the issue, make sure the WebProcess
never sends a DecidePolicyForNavigationResponse IPC to the UIProcess for about:blank suspension loads and let
the load proceed.

The issue was already there before r238353 but it was made obvious by r238353 which caused a hang when trying
to reuse a Suspended page which is hanging while trying to suspend.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

8:00 PM Changeset in webkit [238455] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[Cocoa] clang emits a warning when building WebKit after r238293
https://bugs.webkit.org/show_bug.cgi?id=191917

Reviewed by Dan Bernstein.

Move the implementations of -setSafeBrowsingEnabled: and -isSafeBrowsingEnabled to the main implementation of
WKPreferences to fix the warning.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences setSafeBrowsingEnabled:]):
(-[WKPreferences isSafeBrowsingEnabled]):

7:10 PM Changeset in webkit [238454] by Wenson Hsieh

21 edits in trunk/Source

Address post-review feedback after r238438
https://bugs.webkit.org/show_bug.cgi?id=191913

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace bool arguments to FrameSelection::setSelectedRange, Editor::replaceSelectionWithText, and
Editor::replaceSelectionWithFragment with enum classes instead. In particular, introduce the following:

FrameSelection::ShouldCloseTyping { No, Yes }
Editor::SelectReplacement { No, Yes }
Editor::SmartReplace { No, Yes }
Editor::MatchStyle { No, Yes }

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectText):

editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::replaceSelectionWithText):
(WebCore::Editor::setComposition):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):
(WebCore::Editor::insertAttachment):

At various call sites, replace boolean arguments with named enums.

editing/Editor.h:
editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity):
(WebCore::executeDeleteToMark):
(WebCore::executeSelectToMark):

editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectedRange):

editing/FrameSelection.h:
page/Page.cpp:

(WebCore::replaceRanges):

Avoid a bit of ref-count churn, and adjust a few functions to take const Vector&s instead of Vector&&s.

(WebCore::Page::replaceRangesWithText):
(WebCore::Page::replaceSelectionWithText):

page/Page.h:

Source/WebKit:

Replace boolean arguments to setSelectedRange, replaceSelectionWithText and replaceSelectionWithFragment with
enum flags, and tweak a couple of functions to take const Vector& instead of Vector&&.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageReplaceStringMatches):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches):

WebProcess/WebPage/FindController.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::replaceStringMatchesFromInjectedBundle):
(WebKit::WebPage::replaceMatches):
(WebKit::WebPage::replaceSelectionWithText):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::updateSelectionWithTouches):
(WebKit::WebPage::selectWithTwoTouches):
(WebKit::WebPage::extendSelection):
(WebKit::WebPage::selectWordBackward):
(WebKit::WebPage::moveSelectionByOffset):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::updateSelectionWithExtentPoint):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):
(WebKit::WebPage::syncApplyAutocorrection):

Source/WebKitLegacy/mac:

WebView/WebFrame.mm:

(-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

WebView/WebView.mm:

(-[WebView setSelectedDOMRange:affinity:]):

Source/WebKitLegacy/win:

AccessibleTextImpl.cpp:

(AccessibleText::replaceText):

5:33 PM Changeset in webkit [238453] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Make the jsc shell's dumpException() more robust against long exception strings.
https://bugs.webkit.org/show_bug.cgi?id=191910
<rdar://problem/46212980>

Reviewed by Michael Saboff.

This only affects the dumping of the exception string in the jsc shell due to
unhandled exceptions or exceptions at shell boot time before any JS code is
running.

jsc.cpp:

(dumpException):

3:47 PM Changeset in webkit [238452] by rniwa@webkit.org

17 edits in trunk/Source/WebCore

Modernize SVGURIReference::targetElementFromIRIString
https://bugs.webkit.org/show_bug.cgi?id=191898

Reviewed by Daniel Bates.

Made targetElementFromIRIString return an element and the fragment identifier,
and merged urlFromIRIStringWithFragmentIdentifier into it.

Also replaced the code computing the full URL using the base URL after removing
the fragment identifier and rejoining it later with a single call to completeURL.

No new tests since there should be no observable behavior change.

accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::targetForUseElement const):

css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::updateCursorElement):

rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::layoutPath const):

svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements const):

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::buildPendingResource):

svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::hasValidGlyphElement const):

svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::pathElement):

svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::targetElementFromIRIString):
(WebCore::urlFromIRIStringWithFragmentIdentifier): Deleted.

svg/SVGURIReference.h:
svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::findTarget const):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::referencedRenderer const):

1:17 PM Changeset in webkit [238451] by dino@apple.com

13 edits
3 copies
2 adds in trunk

Implement WebGPUQueue and device.getQueue()
https://bugs.webkit.org/show_bug.cgi?id=191911
<rdar://problem/46214871>

Reviewed by Antoine Quint.

Source/WebCore:

Implement WebGPUDevice::getQueue(), which creates a WebGPUQueue
instance if necessary. Also link WebGPUQueue to the existing
GPUQueue object, and expose the label IDL property.

This patch is based on some work from Justin Fan.

Test: webgpu/queue-creation.html

DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

New files.

Modules/webgpu/WebGPUCommandBuffer.h:

(WebCore::WebGPUCommandBuffer::commandBuffer const):

Expose a GPUCommandBuffer getter, used when submitting (even though
the actual GPU submission isn't implemented yet).

Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::getQueue):

Modules/webgpu/WebGPUDevice.h:
Modules/webgpu/WebGPUDevice.idl:

Implement getQueue().

Modules/webgpu/WebGPUQueue.cpp:

(WebCore::WebGPUQueue::create):
(WebCore::WebGPUQueue::WebGPUQueue):
(WebCore::WebGPUQueue::submit):

Modules/webgpu/WebGPUQueue.h:

(WebCore::WebGPUQueue::label const):
(WebCore::WebGPUQueue::setLabel):

Modules/webgpu/WebGPUQueue.idl:

New class. Mostly sends stuff onto GPUQueue.

bindings/js/WebCoreBuiltinNames.h:

Add WebGPUQueue.

platform/graphics/gpu/GPUQueue.h:
platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::create):
(WebCore::GPUQueue::submit):
(WebCore::GPUQueue::label const):
(WebCore::GPUQueue::setLabel const):

"label" getter/setter that uses
the underlying MTLCommandQueue label property, but prefixes
it with a WebKit identifier, so it can be correctly
identified in system crash logs as coming from WebGPU.

LayoutTests:

WPT-style test for queue creation.

webgpu/queue-creation-expected.txt: Added.
webgpu/queue-creation.html: Added.

12:32 PM Changeset in webkit [238450] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Improve fast/scrolling/scrolling-tree-includes-frame.html
https://bugs.webkit.org/show_bug.cgi?id=191912

These are small improvements to scrolling-tree-includes-frame.html:

Run doTest() after the iframe is loaded and use waitUntilDone/notifyDone for more reliable timing.
Use iframe@srcdoc instead of iframe@src and put the content of the iframe document in its own line.
Move the iframe style in a separate <style> tag and ensure the iframe is really positioned at (0,0)

with no extra margin/padding/border.

Remove unnecessary id="frame"

The test expectation is not changed.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-22
Reviewed by Antonio Gomes.

fast/scrolling/scrolling-tree-includes-frame.html:

10:56 AM Changeset in webkit [238449] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Merge addNonBreakableStart/NonBreakableEnd calls.
https://bugs.webkit.org/show_bug.cgi?id=191903

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

10:51 AM Changeset in webkit [238448] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][IFC] Offset formatting context root runs with horizontal margins.
https://bugs.webkit.org/show_bug.cgi?id=191900

Reviewed by Antti Koivisto.

Source/WebCore:

Inline runs generated by formatting roots (inline-block) need to be adjusted with the horizontal margins.
(The test case has padding and border as well, but they are _inside_ the formatting context.)

Test: fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right-expected.txt: Added.
fast/inline/inline-content-and-nested-formatting-root-with-margin-left-right.html: Added.

10:11 AM Changeset in webkit [238447] by Simon Fraser

3 edits
2 adds in trunk

Extremely small monospace text size when SVG is included as an img
https://bugs.webkit.org/show_bug.cgi?id=191834

Reviewed by Myles C. Maxfield.
Source/WebCore:

Give defaultFixedFontSize a reasonable default value in Settings, so that clients
who omit to set it (like SVGImages) don't get broken rendering.

Test: svg/text/monospace-text-size-in-img.html

page/Settings.yaml:

LayoutTests:

The test has an x offset in the text transform to work around a different bug
with text position (webkit.org/b/191871).

svg/text/monospace-text-size-in-img-expected.html: Added.
svg/text/monospace-text-size-in-img.html: Added.

9:33 AM Changeset in webkit [238446] by mark.lam@apple.com

3 edits in trunk/Source/WebKit

Rollout r238432: Breaks internal Mac builds.
https://bugs.webkit.org/show_bug.cgi?id=191909
<rdar://problem/46214163>

Unreviewed. Rolling out r238432: Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp

Sources.txt:
WebKit.xcodeproj/project.pbxproj:

6:18 AM Changeset in webkit [238445] by Philippe Normand

4 edits in trunk/Tools

[GTK] Remove unmaintained bots
https://bugs.webkit.org/show_bug.cgi?id=191467

Reviewed by Alex Christensen.

The Linux 32-bits and ARM build-slaves are no longer maintained
and have been failing for months, so get rid of them.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

4:53 AM Changeset in webkit [238444] by commit-queue@webkit.org

2 edits in trunk/Tools

[Flatpak] Do not disable signals when running "usual" commands
https://bugs.webkit.org/show_bug.cgi?id=190679

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-22
Reviewed by Philippe Normand.

Otherwise <ctr>c doesn't work while compiling. It is not the best fix
as there are cases we want to let only children receive signals, but
it is not clear how to determine when (when running gdb, we still
disable those).

flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

1:59 AM Changeset in webkit [238443] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.23.1

WebKitGTK+ 2.23.1

1:38 AM Changeset in webkit [238442] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.23.1 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.23.1.

12:45 AM Changeset in webkit [238441] by jfernandez@igalia.com

7 edits
4 adds in trunk

Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
https://bugs.webkit.org/show_bug.cgi?id=191881

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

We should use the font's descent value when wriring-mode flips line flow (vertical-lr).

This change also fixes bug 170175, since Flexbox use the same code to determine the first
line baseline of a flex item.

Test: fast/writing-mode/vertical-align-table-baseline-latin.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::firstLineBaseline const):

LayoutTests:

Tests to verify that columns of a vertical-lr table vertically aligned by baseline work like
in the case of horizontal tables.
Also added tests to verify flexbox baseline alignment works as expected in vertical-lr mode.

The vertical-align-table-baseline.html test has been rebaselined due to the new behavior.

fast/writing-mode/vertical-align-table-baseline-latin-expected.html: Added.
fast/writing-mode/vertical-align-table-baseline-latin.html: Added.
fast/writing-mode/vertical-align-flex-baseline-expected.html: Added.
fast/writing-mode/vertical-align-flex-baseline-html: Added.
platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.
platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt: Rebaseline.
platform/win/fast/writing-mode/vertical-align-table-baseline-expected.png: Rebaseline.

Nov 21, 2018:

10:39 PM Changeset in webkit [238440] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

Phantom focus/blur events fire on clicking between text input fields when listening with addEventListener
https://bugs.webkit.org/show_bug.cgi?id=179990

Reviewed by Tim Horton.

The bug was caused by TemporarySelectionChange which is used by TextIndicator::createWithRange
to set and restore the selection putting the focus on the newly mouse-down'ed input element
and restoring the focus back to the input element which originally had the focus immediately.

Fixed the bug by avoiding to set the focus since only selection highlights need to be updated here.
Also made TemporarySelectionOption an enum class.

Unfortunately, no new tests since force click testing is broken :( See <rdar://problem/31301721>.

editing/Editor.cpp:

(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
(WebCore::TemporarySelectionChange::setSelection): Extracted. Fixed the bug by adding
FrameSelection::DoNotSetFocus to the option when TemporarySelectionOption::DoNotSetFocus is set.

editing/Editor.h:
page/DragController.cpp:

(WebCore::DragController::performDragOperation):

page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange): Set TemporarySelectionOption::DoNotSetFocus.

9:47 PM Changeset in webkit [238439] by yusukesuzuki@slowstart.org

31 edits
4 deletes in trunk/Source

[JSC] Drop ARM_TRADITIONAL support in LLInt, baseline JIT, and DFG
https://bugs.webkit.org/show_bug.cgi?id=191675

Reviewed by Mark Lam.

Source/JavaScriptCore:

We no longer maintain ARM_TRADITIONAL LLInt and JIT in JSC. This architecture will use
CLoop instead. This patch removes ARM_TRADITIONAL support in LLInt and JIT.

Discussed in https://lists.webkit.org/pipermail/webkit-dev/2018-October/030220.html.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
assembler/ARMAssembler.cpp: Removed.
assembler/ARMAssembler.h: Removed.
assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpCode):

assembler/MacroAssembler.h:

(JSC::MacroAssembler::patchableBranch32):

assembler/MacroAssemblerARM.cpp: Removed.
assembler/MacroAssemblerARM.h: Removed.
assembler/PerfLog.cpp:
assembler/PerfLog.h:
assembler/ProbeContext.h:

(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):

assembler/testmasm.cpp:

(JSC::isPC):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):

bytecode/InlineAccess.h:

(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):

dfg/DFGSpeculativeJIT.h:
disassembler/CapstoneDisassembler.cpp:

(JSC::tryToDisassemble):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall):

jit/AssemblyHelpers.h:
jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsImpl):
(JSC::CCallHelpers::prepareForTailCallSlow):

jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareForTailCall):

jit/HostCallReturnValue.cpp:
jit/JITMathIC.h:

(JSC::isProfileEmpty):

jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):

jit/Repatch.cpp:

(JSC::forceICFailure):

jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
offlineasm/arm.rb:
offlineasm/backends.rb:
yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):

Source/WTF:

wtf/InlineASM.h:
wtf/Platform.h:

9:03 PM Changeset in webkit [238438] by Wenson Hsieh

27 edits
15 adds in trunk

[Cocoa] [WebKit2] Add support for replacing find-in-page text matches
https://bugs.webkit.org/show_bug.cgi?id=191786
<rdar://problem/45813871>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for replacing Find-in-Page matches. See below for details. Covered by new layout tests as well as a
new API test.

Tests: editing/find/find-and-replace-adjacent-words.html

editing/find/find-and-replace-at-editing-boundary.html
editing/find/find-and-replace-basic.html
editing/find/find-and-replace-in-subframes.html
editing/find/find-and-replace-no-matches.html
editing/find/find-and-replace-noneditable-matches.html
editing/find/find-and-replace-replacement-text-input-events.html

API test: WebKit.FindAndReplace

page/Page.cpp:

(WebCore::replaceRanges):
(WebCore::Page::replaceRangesWithText):

Add a helper that, given a list of Ranges, replaces each range with the given text. To do this, we first map
each Range to editing offsets within the topmost editable root for each Range. This results in a map of editable
root to list of editing offsets we need to replace. To apply the replacements, for each editable root in the
map, we iterate over each replacement range (i.e. an offset and length), set the current selection to contain
that replacement range, and use Editor::replaceSelectionWithText. To prevent prior text replacements from
clobbering the offsets of latter text replacement ranges, we also iterate backwards through text replacement
ranges when performing each replacement.

Likewise, we also apply text replacement to each editing container in backwards order: for nodes in the same
frame, we compare their position in the document, and for nodes in different frames, we instead compare their
frames in frame tree traversal order.

We map Ranges to editing offsets and back when performing text replacement because each text replacement may
split or merge text nodes, which causes adjacent Ranges to shrink or extend while replacing text. In an earlier
attempt to implement this, I simply iterated over each Range to replace and carried out text replacement for
each Range. This led to incorrect behavior in some cases, such as replacing adjacent matches. Thus, by computing
the set of text replacement offsets prior to replacing any text, we're able to target the correct ranges for
replacement.

(WebCore::Page::replaceSelectionWithText):

Add a helper method on Page to replace the current selection with some text. This simply calls out to
Editor::replaceSelectionWithText.

page/Page.h:

Source/WebCore/PAL:

Add -replaceMatches:withString:inSelectionOnly:resultCollector:.

pal/spi/mac/NSTextFinderSPI.h:

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView replaceMatches:withString:inSelectionOnly:resultCollector:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::replaceMatches):

UIProcess/WebPageProxy.h:
UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient replaceMatches:withString:inSelectionOnly:resultCollector:]):

Implement this method to opt in to "Replace…" UI on macOS in the find bar. In this API, we're given a list of
matches to replace. We propagate the indices of each match to the web process, where FindController maps them to
corresponding replacement ranges. Currently, the given list of matches is only ever a list containing the first
match, or a list containing all matches.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageFindStringMatches):
(WKBundlePageReplaceStringMatches):

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches):

Map match indices to Ranges, and then call into WebCore::Page to do the heavy lifting (see WebCore ChangeLog for
more details). Additionally add a hard find-and-replace limit here to prevent the web process from spinning
indefinitely if there are an enormous number of find matches.

WebProcess/WebPage/FindController.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findStringMatchesFromInjectedBundle):
(WebKit::WebPage::replaceStringMatchesFromInjectedBundle):

Add helpers to exercise find and replace in WebKit2.

(WebKit::WebPage::replaceMatches):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController setFindBarView:]):

Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
the "Replace" option.

TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

Add an API test to exercise find-and-replace API using WKWebView.

(replaceMatches):
(TEST):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::findOptionsFromArray):
(WTR::TestRunner::findString):
(WTR::TestRunner::findStringMatchesInPage):
(WTR::TestRunner::replaceFindMatchesAtIndices):

Add TestRunner hooks to simulate find-in-page and replace.

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Introduce a LayoutTests/editing/find directory to contain tests around FindController, and add 7 new layout
tests. These are currently enabled only for WebKit2 on macOS and iOS.

TestExpectations:
editing/find/find-and-replace-adjacent-words-expected.txt: Added.
editing/find/find-and-replace-adjacent-words.html: Added.

Test find-and-replace with adjacent words.

editing/find/find-and-replace-at-editing-boundary-expected.txt: Added.
editing/find/find-and-replace-at-editing-boundary.html: Added.

Test find-and-replace when one of the find matches straddles an editing boundary. In this case, we verify that
the replacement does not occur, since only part of the word would be replaced.

editing/find/find-and-replace-basic-expected.txt: Added.
editing/find/find-and-replace-basic.html: Added.

Add a basic test that exercises a single text replacement, and "replace all".

editing/find/find-and-replace-in-subframes-expected.txt: Added.
editing/find/find-and-replace-in-subframes.html: Added.

Test find-and-replace when some of the matches are in editable content in subframes. This test additionally
contains matches in shadow content (in this case, text fields) within both the main document and the subframe,
and verifies that text replacement reaches these elements as well.

editing/find/find-and-replace-no-matches-expected.txt: Added.
editing/find/find-and-replace-no-matches.html: Added.

Test find-and-replace when no replacement matches are specified. In this case, we fall back to inserting the
replacement text at the current selection.

editing/find/find-and-replace-noneditable-matches-expected.txt: Added.
editing/find/find-and-replace-noneditable-matches.html: Added.

Test find-and-replace when some of the matches to replace are noneditable, others are editable, and others are
editable but are nested within noneditable elements (i.e. contenteditable=false). In this case, "replace all"
should still replace all fully editable matches.

editing/find/find-and-replace-replacement-text-input-events-expected.txt: Added.
editing/find/find-and-replace-replacement-text-input-events.html: Added.

Tests that find-and-replace emits input events of inputType "insertReplacementText", except when inserting
replacement text at a caret selection.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

7:43 PM Changeset in webkit [238437] by sbarati@apple.com

3 edits
1 add in trunk

DFGSpeculativeJIT should not &= exitOK with mayExit(node)
https://bugs.webkit.org/show_bug.cgi?id=191897
<rdar://problem/45871998>

Reviewed by Mark Lam.

JSTests:

stress/exitok-is-not-the-same-as-mayExit.js: Added.

(bar):
(foo):

Source/JavaScriptCore:

exitOK is a statement about it being legal to exit. mayExit() is about being
conservative and returning false only if an OSR exit *could never* happen.
mayExit() tries to be as smart as possible to see if it can return false.
It can't return false if a runtime exit *could* happen. However, there is
code in the compiler where mayExit() returns false (because it uses data
generated from AI about type checks being proved), but the code we emit in the
compiler backend unconditionally generates an OSR exit, even if that exit may
never execute. For example, let's say we have this IR:

SomeNode(Boolean:@input)

And we always emit code like this as a way of emitting a boolean type check:

jump L1 if input == true
jump L1 if input == false
emit an OSR exit

In such a program, when we generate the above OSR exit, in a validationEnabled()
build, and if @input is proved to be a boolean, we'll end up crashing because we
have the bogus assertion saying !exitOK. This is one reason why things are cleaner
if we don't conflate mayExit() with exitOK.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

7:39 PM Changeset in webkit [238436] by sbarati@apple.com

4 edits
1 add in trunk

Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
https://bugs.webkit.org/show_bug.cgi?id=191895
<rdar://problem/46167406>

Reviewed by Mark Lam.

JSTests:

stress/known-cell-use-needs-type-check-assertion.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

We were asserting that the input edge should have type SpecCell but it should
really be SpecCellCheck since the type filter for KnownCellUse is SpecCellCheck.

This patch cleans up that assertion code by joining a bunch of cases into a
single function call which grabs the type filter for the edge UseKind and
asserts that the incoming edge meets the type filter criteria.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculate):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::speculate):

6:57 PM Changeset in webkit [238435] by yusukesuzuki@slowstart.org

4 edits in trunk/Source/JavaScriptCore

[JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number 4
https://bugs.webkit.org/show_bug.cgi?id=191877

Reviewed by Sam Weinig.

Instead of hard-coding 4 into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.

interpreter/ProtoCallFrame.h:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

6:12 PM Changeset in webkit [238434] by aestes@apple.com

22 edits
2 adds in trunk/Source

[Cocoa] Create a soft-linking file for PassKit
https://bugs.webkit.org/show_bug.cgi?id=191875
<rdar://problem/46203215>

Reviewed by Myles Maxfield.

Source/WebCore:

Modules/applepay/cocoa/PaymentContactCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm: Ditto.
SourcesCocoa.txt: Removed @no-unify from PaymentMerchantSessionCocoa.mm.
WebCore.xcodeproj/project.pbxproj: Removed PaymentMerchantSessionCocoa.mm from the WebCore target.
rendering/RenderThemeCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:
pal/cocoa/PassKitSoftLink.h: Added.
pal/cocoa/PassKitSoftLink.mm: Added. Used _WITH_EXPORT soft-linking macros in order to

make the PAL soft-linking symbols visible to WebKit.

pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
SourcesCocoa.txt: Removed @no-unify from WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm.
UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Ditto.
UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: Ditto.
UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: Included NSAttributedStringSPI.h.
UIProcess/mac/WebProcessProxyMac.mm: Included ProcessPrivilege.h.
WebKit.xcodeproj/project.pbxproj: Removed WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm from the WebKit target.

Source/WTF:

wtf/Platform.h: Defined USE_PASSKIT.
wtf/cocoa/SoftLinking.h: Added _WITH_EXPORT variants of SOFT_LINK_FRAMEWORK_FOR_SOURCE,

SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE, SOFT_LINK_CLASS_FOR_SOURCE,
SOFT_LINK_FUNCTION_FOR_SOURCE, and SOFT_LINK_CONSTANT_FOR_SOURCE.

5:51 PM Changeset in webkit [238433] by mark.lam@apple.com

7 edits
2 adds in trunk

Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.
https://bugs.webkit.org/show_bug.cgi?id=191776
<rdar://problem/46152851>

Reviewed by Saam Barati.

JSTests:

stress/big-wasm-memory-grow-no-max.js:
stress/big-wasm-memory-grow.js:
stress/big-wasm-memory.js:
updated these to expect an OutOfMemoryError.

wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js: Added.

(Binary.prototype.emit_u8):
(Binary.prototype.emit_u32v):
(Binary.prototype.emit_header):
(Binary.prototype.emit_section):
(Binary):
(WasmModuleBuilder):
(WasmModuleBuilder.prototype.addMemory):
(WasmModuleBuilder.prototype.toArray):
(WasmModuleBuilder.prototype.toBuffer):
(WasmModuleBuilder.prototype.instantiate):
(catch):

wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE.js: Added.

(catch):

Source/JavaScriptCore:

wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::tryCreate):

return nullptr if the requested bytes exceed MAX_ARRAY_BUFFER_SIZE. The clients will already do a null check and throw an OutOfMemoryError if needed.

(JSC::Wasm::Memory::grow):

throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.
wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):

throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.

5:27 PM Changeset in webkit [238432] by Fujii Hironori

3 edits in trunk/Source/WebKit

Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp

and InjectedBundleNodeHandle.cpp

WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership

not to be compiled by XCode.

3:25 PM Changeset in webkit [238431] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] LayoutState should always be initialized with the initial containing block.
https://bugs.webkit.org/show_bug.cgi?id=191896

Reviewed by Antti Koivisto.

There should always be only one LayoutState per layout tree (it does not mean that layout always starts at the ICB).
The ICB is a special formatting context root because it does not have a parent formatting context. All the other formatting contexts
first need to be laid out (partially at least e.g margin) in their parent formatting context.
Having a non-null parent formatting context as root could lead to undefined behaviour.

layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot): Deleted.

layout/LayoutFormattingState.h:
layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

3:13 PM Changeset in webkit [238430] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][IFC] Horizontal margins should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191894

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding and border, horizontal margins also force run breaks and offset them.

Test: fast/inline/inline-content-with-margin-left-right.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-margin-left-right-expected.txt: Added.
fast/inline/inline-content-with-margin-left-right.html: Added.

1:33 PM Changeset in webkit [238429] by rniwa@webkit.org

3 edits
2 adds in trunk

Mutation observers doesn't get notified of character data mutation made by the parser
https://bugs.webkit.org/show_bug.cgi?id=191874

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.

Test: fast/dom/MutationObserver/observe-parser-character-data-change.html

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

LayoutTests:

Added a regression test.

fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.

11:10 AM Changeset in webkit [238428] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.22.2

WPE WebKit release 2.22.2

11:09 AM Changeset in webkit [238427] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.2 release.

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.22.2.

10:58 AM Changeset in webkit [238426] by Claudio Saavedra

2 edits in trunk/Source/WebCore

[SOUP] Follow-up robustness improvements to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=191892

Reviewed by Michael Catanzaro.

If at any point the certificate fails to be constructed from
the DER data, bail out. Likewise, if the certificate returned
is NULL, return false from the decoder to notify the failure
to decode it.

platform/network/soup/CertificateInfo.h:

(WTF::Persistence::certificateFromCertificatesDataList):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):

10:38 AM Changeset in webkit [238425] by Caio Lima

9 edits
1 add in trunk

[BigInt] JSBigInt::createWithLength should throw when length is greater than JSBigInt::maxLength
https://bugs.webkit.org/show_bug.cgi?id=190836

Reviewed by Saam Barati and Yusuke Suzuki.

JSTests:

stress/big-int-out-of-memory-tests.js: Added.

Source/JavaScriptCore:

In this patch we are creating a new method called JSBigInt::createWithLengthUnchecked
where we allocate a BigInt trusting the length received as argument.
With this additional method, we now check if length passed to
JSBigInt::tryCreateWithLength is not greater than JSBigInt::maxLength.
When the length is greater than JSBigInt::maxLength, we then throw OOM
exception.
This required us to change the interface of some JSBigInt operations to
receive ExecState* instead of VM&. We changed only operations that
can throw because of OOM.
We beleive that this approach of throwing instead of finishing the
execution abruptly is better because JS programs can catch such
exception and handle this issue properly.

dfg/DFGOperations.cpp:
jit/JITOperations.cpp:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/JSBigInt.cpp:

(JSC::JSBigInt::createZero):
(JSC::JSBigInt::tryCreateWithLength):
(JSC::JSBigInt::createWithLengthUnchecked):
(JSC::JSBigInt::createFrom):
(JSC::JSBigInt::multiply):
(JSC::JSBigInt::divide):
(JSC::JSBigInt::copy):
(JSC::JSBigInt::unaryMinus):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::add):
(JSC::JSBigInt::sub):
(JSC::JSBigInt::bitwiseAnd):
(JSC::JSBigInt::bitwiseOr):
(JSC::JSBigInt::bitwiseXor):
(JSC::JSBigInt::absoluteAdd):
(JSC::JSBigInt::absoluteSub):
(JSC::JSBigInt::absoluteDivWithDigitDivisor):
(JSC::JSBigInt::absoluteDivWithBigIntDivisor):
(JSC::JSBigInt::absoluteLeftShiftAlwaysCopy):
(JSC::JSBigInt::absoluteBitwiseOp):
(JSC::JSBigInt::absoluteAddOne):
(JSC::JSBigInt::absoluteSubOne):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::rightTrim):
(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::createWithLength): Deleted.

runtime/JSBigInt.h:
runtime/Operations.cpp:

(JSC::jsAddSlowCase):

runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):

10:10 AM Changeset in webkit [238424] by Adrian Perez de Castro

1 copy in releases/WebKitGTK/webkit-2.22.4

WebKitGTK release 2.22.4

10:08 AM Changeset in webkit [238423] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.22.4.

9:38 AM Changeset in webkit [238422] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][IFC] Border should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191891

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding, border also forces run breaks and offsets them.

Test: fast/inline/inline-content-with-border-left-right.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-border-left-right-expected.txt: Added.
fast/inline/inline-content-with-border-left-right.html: Added.

9:37 AM Changeset in webkit [238421] by mark.lam@apple.com

4 edits
1 add in trunk

Remove invalid assertion in VMTraps::SignalSender's SignalAction.
https://bugs.webkit.org/show_bug.cgi?id=191856
<rdar://problem/46089992>

Reviewed by Yusuke Suzuki.

JSTests:

stress/regress-191856.js: Added.
this test is skipped for now until we have a fix for webkit.org/b/191855.

Source/JavaScriptCore:

The ASSERT(vm.traps().needTrapHandling()) assertion in SignalSender's SigAction
function is invalid because we can't be sure that the trap has been handled yet
by the time the trap fires. This is because the main thread may also check traps
(in LLInt, baseline JIT and VM runtime code). There's a race to handle the trap.
Hence, the SigAction cannot assume that the trap still needs handling by the time
it is executed. This patch removed the invalid assertion.

Also renamed m_trapSet to m_condition because it is a AutomaticThreadCondition,
and all the ways it is used is as a condvar. The m_trapSet name doesn't seem
appropriate nor meaningful.

runtime/VMTraps.cpp:

(JSC::VMTraps::tryInstallTrapBreakpoints):

Added a !needTrapHandling() check as an optimization: there's no need to install VMTrap breakpoints if someone already beat us to handling the trap (remember, the main thread is racing against the VMTraps signalling thread to handle the trap too). We only need to install the VMTraps breakpoints if we need DFG/FTL compiled code to deopt so that they can check and handle pending traps. If the trap has already been handled, it's better to not deopt any DFG/FTL functions.

(JSC::VMTraps::willDestroyVM):
(JSC::VMTraps::fireTrap):
(JSC::VMTraps::VMTraps):

runtime/VMTraps.h:

9:36 AM Changeset in webkit [238420] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Use contains and containsAll in InlineFormattingContext::splitInlineRunIfNeeded consistently
https://bugs.webkit.org/show_bug.cgi?id=191890

Rearrange the comment numbers to match the logic below.

Reviewed by Antti Koivisto.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

9:24 AM Changeset in webkit [238419] by dino@apple.com

4 edits
85 moves
3 adds in trunk/Source/WebCore

Move WebGPU platform code to platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=191867
<rdar://problem/46190993>

Reviewed by Antoine Quint.

The underlying implementation of WebGPU doesn't need to live in
Modules, since it technically could be used by other parts of the system. It
makes more sense for it to be in platform/graphics/gpu.

Move...

Modules/webgpu/GPU* -> platform/graphics/gpu
Modules/webgpu/cocoa -> platform/graphics/gpu/cocoa
platform/graphics/gpu/GPULegacy* -> platform/graphics/gpu/legacy/
platform/graphics/gpu/cocoa/GPULegacy* -> platform/graphics/gpu/legacy/cocoa

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/gpu/GPUCommandBuffer.h: Renamed from Source/WebCore/Modules/webgpu/GPUCommandBuffer.h.
platform/graphics/gpu/GPUDevice.cpp: Renamed from Source/WebCore/Modules/webgpu/GPUDevice.cpp.

(WebCore::GPUDevice::createShaderModule const):
(WebCore::GPUDevice::createRenderPipeline const):
(WebCore::GPUDevice::createCommandBuffer):
(WebCore::GPUDevice::getQueue):

platform/graphics/gpu/GPUDevice.h: Renamed from Source/WebCore/Modules/webgpu/GPUDevice.h.

(WebCore::GPUDevice::platformDevice const):

platform/graphics/gpu/GPUPipelineDescriptorBase.h: Renamed from Source/WebCore/Modules/webgpu/GPUPipelineDescriptorBase.h.
platform/graphics/gpu/GPUPipelineStageDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h.
platform/graphics/gpu/GPUQueue.h: Renamed from Source/WebCore/Modules/webgpu/GPUQueue.h.

(WebCore::GPUQueue::platformQueue const):

platform/graphics/gpu/GPURenderPipeline.h: Renamed from Source/WebCore/Modules/webgpu/GPURenderPipeline.h.

(WebCore::GPURenderPipeline::platformRenderPipeline const):

platform/graphics/gpu/GPURenderPipelineDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPURenderPipelineDescriptor.h.
platform/graphics/gpu/GPUShaderModule.h: Renamed from Source/WebCore/Modules/webgpu/GPUShaderModule.h.

(WebCore::GPUShaderModule::platformShaderModule const):

platform/graphics/gpu/GPUShaderModuleDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/GPUShaderModuleDescriptor.h.
platform/graphics/gpu/GPUSwapChain.h: Renamed from Source/WebCore/Modules/webgpu/GPUSwapChain.h.

(WebCore::GPUSwapChain::platformLayer const):

platform/graphics/gpu/GPUTexture.h: Renamed from Source/WebCore/Modules/webgpu/GPUTexture.h.
platform/graphics/gpu/GPUTextureFormatEnum.h: Renamed from Source/WebCore/Modules/webgpu/GPUTextureFormatEnum.h.
platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUCommandBufferMetal.mm.

(WebCore::GPUCommandBuffer::create):
(WebCore::GPUCommandBuffer::GPUCommandBuffer):

platform/graphics/gpu/cocoa/GPUDeviceMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUDeviceMetal.mm.

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):

platform/graphics/gpu/cocoa/GPUQueueMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUQueueMetal.mm.

(WebCore::GPUQueue::create):
(WebCore::GPUQueue::GPUQueue):

platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPURenderPipelineMetal.mm.

(WebCore::setFunctionsForPipelineDescriptor):
(WebCore::GPURenderPipeline::create):
(WebCore::GPURenderPipeline::GPURenderPipeline):

platform/graphics/gpu/cocoa/GPUShaderModuleMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUShaderModuleMetal.mm.

(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::GPUShaderModule):

platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUSwapChainMetal.mm.

(WebCore::GPUSwapChain::create):
(WebCore::GPUSwapChain::GPUSwapChain):
(WebCore::GPUSwapChain::setDevice):
(WebCore::platformTextureFormatForGPUTextureFormat):
(WebCore::GPUSwapChain::setFormat):
(WebCore::GPUSwapChain::reshape):
(WebCore::GPUSwapChain::getNextTexture):
(WebCore::GPUSwapChain::present):

platform/graphics/gpu/cocoa/GPUTextureMetal.mm: Renamed from Source/WebCore/Modules/webgpu/cocoa/GPUTextureMetal.mm.

(WebCore::GPUTexture::create):
(WebCore::GPUTexture::GPUTexture):
(WebCore::GPUTexture::createDefaultTextureView):

platform/graphics/gpu/legacy/GPULegacyBuffer.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyBuffer.cpp.

(WebCore::GPULegacyBuffer::~GPULegacyBuffer):
(WebCore::GPULegacyBuffer::length const):

platform/graphics/gpu/legacy/GPULegacyBuffer.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyBuffer.h.

(WebCore::GPULegacyBuffer::contents const):
(WebCore::GPULegacyBuffer::metal const):

platform/graphics/gpu/legacy/GPULegacyCommandBuffer.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandBuffer.cpp.

(WebCore::GPULegacyCommandBuffer::~GPULegacyCommandBuffer):

platform/graphics/gpu/legacy/GPULegacyCommandBuffer.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandBuffer.h.

(WebCore::GPULegacyCommandBuffer::metal const):

platform/graphics/gpu/legacy/GPULegacyCommandQueue.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandQueue.cpp.

(WebCore::GPULegacyCommandQueue::~GPULegacyCommandQueue):

platform/graphics/gpu/legacy/GPULegacyCommandQueue.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyCommandQueue.h.

(WebCore::GPULegacyCommandQueue::metal const):

platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputeCommandEncoder.cpp.

(WebCore::GPULegacyComputeCommandEncoder::~GPULegacyComputeCommandEncoder):

platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputeCommandEncoder.h.
platform/graphics/gpu/legacy/GPULegacyComputePipelineState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputePipelineState.cpp.

(WebCore::GPULegacyComputePipelineState::~GPULegacyComputePipelineState):

platform/graphics/gpu/legacy/GPULegacyComputePipelineState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyComputePipelineState.h.

(WebCore::GPULegacyComputePipelineState::metal const):

platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilDescriptor.cpp.

(WebCore::GPULegacyDepthStencilDescriptor::~GPULegacyDepthStencilDescriptor):

platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilDescriptor.h.

(WebCore::GPULegacyDepthStencilDescriptor::metal const):

platform/graphics/gpu/legacy/GPULegacyDepthStencilState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilState.cpp.

(WebCore::GPULegacyDepthStencilState::~GPULegacyDepthStencilState):

platform/graphics/gpu/legacy/GPULegacyDepthStencilState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDepthStencilState.h.

(WebCore::GPULegacyDepthStencilState::metal const):

platform/graphics/gpu/legacy/GPULegacyDevice.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDevice.cpp.

(WebCore::GPULegacyDevice::~GPULegacyDevice):

platform/graphics/gpu/legacy/GPULegacyDevice.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDevice.h.

(WebCore::GPULegacyDevice::layer const):
(WebCore::GPULegacyDevice::metal const):
(WebCore::GPULegacyDevice::markLayerComposited const):

platform/graphics/gpu/legacy/GPULegacyDrawable.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDrawable.cpp.

(WebCore::GPULegacyDrawable::~GPULegacyDrawable):

platform/graphics/gpu/legacy/GPULegacyDrawable.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyDrawable.h.
platform/graphics/gpu/legacy/GPULegacyEnums.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyEnums.h.
platform/graphics/gpu/legacy/GPULegacyFunction.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyFunction.cpp.

(WebCore::GPULegacyFunction::~GPULegacyFunction):

platform/graphics/gpu/legacy/GPULegacyFunction.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyFunction.h.

(WebCore::GPULegacyFunction::metal const):

platform/graphics/gpu/legacy/GPULegacyLibrary.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyLibrary.cpp.

(WebCore::GPULegacyLibrary::~GPULegacyLibrary):

platform/graphics/gpu/legacy/GPULegacyLibrary.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyLibrary.h.

(WebCore::GPULegacyLibrary::metal const):

platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderCommandEncoder.cpp.

(WebCore::GPULegacyRenderCommandEncoder::~GPULegacyRenderCommandEncoder):

platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderCommandEncoder.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassAttachmentDescriptor::~GPULegacyRenderPassAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassColorAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::~GPULegacyRenderPassColorAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassColorAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDepthAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::~GPULegacyRenderPassDepthAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDepthAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDescriptor.cpp.

(WebCore::GPULegacyRenderPassDescriptor::~GPULegacyRenderPassDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPassDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineColorAttachmentDescriptor.cpp.

(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::~GPULegacyRenderPipelineColorAttachmentDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineColorAttachmentDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineDescriptor.cpp.

(WebCore::GPULegacyRenderPipelineDescriptor::~GPULegacyRenderPipelineDescriptor):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineDescriptor.h.
platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineState.cpp.

(WebCore::GPULegacyRenderPipelineState::~GPULegacyRenderPipelineState):

platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyRenderPipelineState.h.
platform/graphics/gpu/legacy/GPULegacySize.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacySize.h.
platform/graphics/gpu/legacy/GPULegacyTexture.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTexture.cpp.

(WebCore::GPULegacyTexture::~GPULegacyTexture):

platform/graphics/gpu/legacy/GPULegacyTexture.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTexture.h.
platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.cpp: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTextureDescriptor.cpp.

(WebCore::GPULegacyTextureDescriptor::~GPULegacyTextureDescriptor):

platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPULegacyTextureDescriptor.h.
platform/graphics/gpu/legacy/cocoa/GPULegacyBufferMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyBufferMetal.mm.

(WebCore::GPULegacyBuffer::GPULegacyBuffer):

platform/graphics/gpu/legacy/cocoa/GPULegacyCommandBufferMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyCommandBufferMetal.mm.

(WebCore::GPULegacyCommandBuffer::GPULegacyCommandBuffer):
(WebCore::GPULegacyCommandBuffer::presentDrawable const):
(WebCore::GPULegacyCommandBuffer::commit const):

platform/graphics/gpu/legacy/cocoa/GPULegacyCommandQueueMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyCommandQueueMetal.mm.

(WebCore::GPULegacyCommandQueue::GPULegacyCommandQueue):
(WebCore::GPULegacyCommandQueue::label const):
(WebCore::GPULegacyCommandQueue::setLabel const):

platform/graphics/gpu/legacy/cocoa/GPULegacyComputeCommandEncoderMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyComputeCommandEncoderMetal.mm.

(WebCore::MTLSizeMake):
(WebCore::GPULegacyComputeCommandEncoder::GPULegacyComputeCommandEncoder):
(WebCore::GPULegacyComputeCommandEncoder::setComputePipelineState const):
(WebCore::GPULegacyComputeCommandEncoder::setBuffer const):
(WebCore::GPULegacyComputeCommandEncoder::dispatch const):
(WebCore::GPULegacyComputeCommandEncoder::endEncoding const):

platform/graphics/gpu/legacy/cocoa/GPULegacyComputePipelineStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyComputePipelineStateMetal.mm.

(WebCore::GPULegacyComputePipelineState::GPULegacyComputePipelineState):

platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilDescriptorMetal.mm.

(WebCore::GPULegacyDepthStencilDescriptor::GPULegacyDepthStencilDescriptor):
(WebCore::GPULegacyDepthStencilDescriptor::depthWriteEnabled const):
(WebCore::GPULegacyDepthStencilDescriptor::setDepthWriteEnabled const):
(WebCore::GPULegacyDepthStencilDescriptor::depthCompareFunction const):
(WebCore::GPULegacyDepthStencilDescriptor::setDepthCompareFunction const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilStateMetal.mm.

(WebCore::GPULegacyDepthStencilState::GPULegacyDepthStencilState):
(WebCore::GPULegacyDepthStencilState::label const):
(WebCore::GPULegacyDepthStencilState::setLabel const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDeviceMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDeviceMetal.mm.

(WebCore::GPULegacyDevice::GPULegacyDevice):
(WebCore::GPULegacyDevice::disconnect):
(WebCore::GPULegacyDevice::reshape const):
(WebCore::GPULegacyDevice::platformLayer const):
(WebCore::GPULegacyDevice::operator! const):

platform/graphics/gpu/legacy/cocoa/GPULegacyDrawableMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyDrawableMetal.mm.

(WebCore::GPULegacyDrawable::GPULegacyDrawable):
(WebCore::GPULegacyDrawable::release):
(WebCore::GPULegacyDrawable::metal const):
(WebCore::GPULegacyDrawable::texture const):

platform/graphics/gpu/legacy/cocoa/GPULegacyFunctionMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyFunctionMetal.mm.

(WebCore::GPULegacyFunction::GPULegacyFunction):
(WebCore::GPULegacyFunction::name const):
(WebCore::GPULegacyFunction::operator! const):

platform/graphics/gpu/legacy/cocoa/GPULegacyLibraryMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyLibraryMetal.mm.

(WebCore::GPULegacyLibrary::GPULegacyLibrary):
(WebCore::GPULegacyLibrary::label const):
(WebCore::GPULegacyLibrary::setLabel const):
(WebCore::GPULegacyLibrary::functionNames const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderCommandEncoderMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderCommandEncoderMetal.mm.

(WebCore::GPULegacyRenderCommandEncoder::GPULegacyRenderCommandEncoder):
(WebCore::GPULegacyRenderCommandEncoder::setRenderPipelineState const):
(WebCore::GPULegacyRenderCommandEncoder::setDepthStencilState const):
(WebCore::GPULegacyRenderCommandEncoder::setVertexBuffer const):
(WebCore::GPULegacyRenderCommandEncoder::setFragmentBuffer const):
(WebCore::GPULegacyRenderCommandEncoder::drawPrimitives const):
(WebCore::GPULegacyRenderCommandEncoder::endEncoding const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassAttachmentDescriptor::GPULegacyRenderPassAttachmentDescriptor):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::loadAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setLoadAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::storeAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setStoreAction const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::setTexture const):
(WebCore::GPULegacyRenderPassAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassColorAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassColorAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::GPULegacyRenderPassColorAttachmentDescriptor):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::clearColor const):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::setClearColor const):
(WebCore::GPULegacyRenderPassColorAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDepthAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassDepthAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::GPULegacyRenderPassDepthAttachmentDescriptor):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::clearDepth const):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::setClearDepth const):
(WebCore::GPULegacyRenderPassDepthAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPassDescriptorMetal.mm.

(WebCore::GPULegacyRenderPassDescriptor::GPULegacyRenderPassDescriptor):
(WebCore::GPULegacyRenderPassDescriptor::colorAttachments const):
(WebCore::GPULegacyRenderPassDescriptor::depthAttachment const):
(WebCore::GPULegacyRenderPassDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineColorAttachmentDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineColorAttachmentDescriptorMetal.mm.

(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::GPULegacyRenderPipelineColorAttachmentDescriptor):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::pixelFormat const):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::setPixelFormat const):
(WebCore::GPULegacyRenderPipelineColorAttachmentDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineDescriptorMetal.mm.

(WebCore::GPULegacyRenderPipelineDescriptor::GPULegacyRenderPipelineDescriptor):
(WebCore::GPULegacyRenderPipelineDescriptor::depthAttachmentPixelFormat const):
(WebCore::GPULegacyRenderPipelineDescriptor::setDepthAttachmentPixelFormat const):
(WebCore::GPULegacyRenderPipelineDescriptor::setVertexFunction const):
(WebCore::GPULegacyRenderPipelineDescriptor::setFragmentFunction const):
(WebCore::GPULegacyRenderPipelineDescriptor::colorAttachments const):
(WebCore::GPULegacyRenderPipelineDescriptor::reset const):
(WebCore::GPULegacyRenderPipelineDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineStateMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineStateMetal.mm.

(WebCore::GPULegacyRenderPipelineState::GPULegacyRenderPipelineState):
(WebCore::GPULegacyRenderPipelineState::label const):
(WebCore::GPULegacyRenderPipelineState::setLabel const):
(WebCore::GPULegacyRenderPipelineState::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyTextureDescriptorMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm.

(WebCore::GPULegacyTextureDescriptor::GPULegacyTextureDescriptor):
(WebCore::GPULegacyTextureDescriptor::width const):
(WebCore::GPULegacyTextureDescriptor::setWidth const):
(WebCore::GPULegacyTextureDescriptor::height const):
(WebCore::GPULegacyTextureDescriptor::setHeight const):
(WebCore::GPULegacyTextureDescriptor::sampleCount const):
(WebCore::GPULegacyTextureDescriptor::setSampleCount const):
(WebCore::GPULegacyTextureDescriptor::textureType const):
(WebCore::GPULegacyTextureDescriptor::setTextureType const):
(WebCore::GPULegacyTextureDescriptor::storageMode const):
(WebCore::GPULegacyTextureDescriptor::setStorageMode const):
(WebCore::GPULegacyTextureDescriptor::usage const):
(WebCore::GPULegacyTextureDescriptor::setUsage const):
(WebCore::GPULegacyTextureDescriptor::metal const):

platform/graphics/gpu/legacy/cocoa/GPULegacyTextureMetal.mm: Renamed from Source/WebCore/platform/graphics/metal/GPULegacyTextureMetal.mm.

(WebCore::GPULegacyTexture::GPULegacyTexture):
(WebCore::GPULegacyTexture::width const):
(WebCore::GPULegacyTexture::height const):
(WebCore::GPULegacyTexture::metal const):

8:52 AM Changeset in webkit [238418] by Michael Catanzaro

2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore

[FreeType] Problem under WebCore::FontPlatformData::FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=191595

Unofficially reviewed stable branch commit.

Blacklist cairo 1.15 and 1.16.0 when setting FreeType memory allocation functions. These
broken versions of cairo free memory allocated by FreeType with system free. We can avoid
trouble by using the system allocator instead of bmalloc.

platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::initializeFreeTypeLibrary):

8:37 AM Changeset in webkit [238417] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore

[SOUP] Certificate decoder always returns GByteArray with zero size
https://bugs.webkit.org/show_bug.cgi?id=191888

Reviewed by Žan Doberšek.

No new tests needed.

platform/network/soup/CertificateInfo.h:

(WTF::Persistence::Coder<GRefPtr<GByteArray>>::decode): Add missing
call to g_byte_array_set_size() to make sure byteArray->len has the
correct value.

7:59 AM WikiStart edited by cadubentzen@gmail.com

list remote inspector for WebKitGTK+ and WPE (diff)

7:58 AM RemoteInspectorGTKandWPE created by cadubentzen@gmail.com

Add Remote Inspector page for WebKitGTK+ and WPE

7:53 AM Changeset in webkit [238416] by aboya@igalia.com

2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=191887

platform/gtk/TestExpectations:

7:41 AM Changeset in webkit [238415] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Take nonBreakableStart/End into use.
https://bugs.webkit.org/show_bug.cgi?id=191873

Reviewed by Antti Koivisto.

Source/WebCore:

Offset the final inline runs with the nonBreakableStart/End values.
(This patch also fixes relative positioned run verification.)

Test: fast/inline/inline-content-with-padding-left-right.html

layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/inline-content-with-padding-left-right-expected.txt: Added.
fast/inline/inline-content-with-padding-left-right.html: Added.

3:03 AM Changeset in webkit [238414] by dinfuehr@igalia.com

31 edits in trunk

Enable JIT on ARM/Linux
https://bugs.webkit.org/show_bug.cgi?id=191548

Reviewed by Yusuke Suzuki.

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

Source/cmake/WebKitFeatures.cmake:

JSTests:

Disable test on system with limited memory. Program was killed by
the OS before the exception was thrown.

slowMicrobenchmarks/function-constructor-with-huge-strings.js:

Source/bmalloc:

bmalloc/IsoPageInlines.h:

(bmalloc::IsoPage<Config>::startAllocating):

Source/JavaScriptCore:

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getICStatusMap):

bytecode/CodeBlock.h:

(JSC::CodeBlock::metadata):

bytecode/InByIdStatus.cpp:

(JSC::InByIdStatus::computeFor):

bytecode/Instruction.h:

(JSC::Instruction::cast):

bytecode/MetadataTable.h:

(JSC::MetadataTable::forEach):

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::hasExitSite): Deleted.

bytecode/PutByIdStatus.h:
dfg/DFGOSRExit.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

generator/Argument.rb:
generator/Opcode.rb:
jit/GPRInfo.h:
jit/JIT.h:
jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_tail_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_varargs):
(JSC::JIT::emitSlow_op_tail_call_forward_arguments):
(JSC::JIT::emitSlow_op_construct_varargs):
(JSC::JIT::emitSlow_op_construct):
(JSC::JIT::emit_op_call):
(JSC::JIT::emit_op_tail_call):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_tail_call_varargs):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::emit_op_construct_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileSetupVarargsFrame): Deleted.

jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):
(JSC::JIT::emitSlow_op_loop_hint):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_instanceof_custom):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emit_op_is_empty):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_cell_with_type):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_set_function_name):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::emitSlow_op_jeq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::emitSlow_op_jneq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_stricteq):
(JSC::JIT::emit_op_nstricteq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emit_op_jstricteq):
(JSC::JIT::emit_op_jnstricteq):
(JSC::JIT::emitSlow_op_jstricteq):
(JSC::JIT::emitSlow_op_jnstricteq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_to_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_identity_with_profile):
(JSC::JIT::emit_op_get_parent_scope):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_get_scope):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_check_tdz):
(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::privateCompileHasIndexedProperty):
(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emit_op_enumerator_structure_pname):
(JSC::JIT::emit_op_enumerator_generic_pname):
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val_direct):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
(JSC::JIT::emit_op_get_from_arguments):
(JSC::JIT::emit_op_put_to_arguments):

jit/RegisterSet.cpp:

(JSC::RegisterSet::vmCalleeSaveRegisters):

llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

llint/LowLevelInterpreter.asm:
runtime/SamplingProfiler.cpp:

(JSC::tryGetBytecodeIndex):

Source/WTF:

Enable JIT by default on ARMv7/Linux after it was disabled with
recent bytcode format change.

wtf/Platform.h:

1:11 AM Changeset in webkit [238413] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
https://bugs.webkit.org/show_bug.cgi?id=191630

Reviewed by Michael Catanzaro.

Only flip Y in GlyphToPathTranslator for ports using CG.

platform/graphics/FontCascade.cpp:

(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

12:49 AM Changeset in webkit [238412] by aboya@igalia.com

5 edits in trunk/Source/WebCore

[MSE][GStreamer] Refactor AppendPipeline deinitialization
https://bugs.webkit.org/show_bug.cgi?id=191759

Reviewed by Xabier Rodriguez-Calvar.

AppendPipeline currently has a method, clearPlayerPrivate(), that the
client code uses to deinitialize most of the AppendPipeline... just
before actually destructing it in the next line of code.

Since at that point there should not be alive RefPtr's pointing to the
AppendPipeline there is no need for this kind of pre-deinitialization
in this usage pattern. Instead, we can just rely on C++ destructors,
cleaning the code a bit and removing the potential for the question
"what if clearPlayerPrivate() has been called before?": it has not.

Assertions have been added to ensure that there is only one alive
RefPtr pointing to AppendPipeline, therefore guaranteeing its immediate
destruction.

platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::deinitialize):
(WebCore::AppendPipeline::clearPlayerPrivate): Deleted.

platform/graphics/gstreamer/mse/AppendPipeline.h:
platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):

platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::removedFromMediaSource):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed