Timeline
Jan 29, 2019:
- 11:58 PM Changeset in webkit [240706] by
-
- 10 edits in trunk
Align with Fetch on data: URLs
https://bugs.webkit.org/show_bug.cgi?id=182325
Patch by Rob Buis <rbuis@igalia.com> on 2019-01-29
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Update improved test expectations.
- web-platform-tests/fetch/data-urls/processing.any-expected.txt:
- web-platform-tests/fetch/data-urls/processing.any.worker-expected.txt:
- web-platform-tests/xhr/overridemimetype-blob-expected.txt:
Source/WebCore:
Implement most remaining steps for data: URL processing [1].
Serialization is still to be implemented.
To make the code in DataURLDecoder::parseMediaType more efficient,
refactor ParsedContentType so that validation and parsing is done
in one pass.
Test: web-platform-tests/fetch/data-urls/processing.any.js
[1] https://fetch.spec.whatwg.org/#data-urls
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::getSupportedCapabilitiesForAudioVideoType):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::parseMediaType):
(WebCore::DataURLDecoder::DecodeTask::process):
- platform/network/MIMEHeader.cpp:
(WebCore::MIMEHeader::parseHeader):
- platform/network/ParsedContentType.cpp:
(WebCore::containsNewline):
(WebCore::ParsedContentType::parseContentType):
(WebCore::ParsedContentType::create):
(WebCore::isValidContentType):
(WebCore::ParsedContentType::ParsedContentType):
(WebCore::DummyParsedContentType::setContentType const): Deleted.
(WebCore::DummyParsedContentType::setContentTypeParameter const): Deleted.
(WebCore::parseContentType): Deleted.
- platform/network/ParsedContentType.h:
- 11:41 PM Changeset in webkit [240705] by
-
- 6 edits in trunk/LayoutTests
Unreviewed WPE gardening. Adding some test failure expectations and
rebasing a few baselines.
- platform/wpe/TestExpectations:
- platform/wpe/css2.1/t1508-c527-font-06-b-expected.txt:
- platform/wpe/fast/borders/rtl-border-04-expected.txt:
- platform/wpe/fast/borders/rtl-border-05-expected.txt:
- platform/wpe/fast/dom/52776-expected.txt:
- 11:16 PM Changeset in webkit [240704] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WPE gardening.
- platform/wpe/TestExpectations: Skip the resourceLoadStatistics tests
since that feature is still not yet enabled for the port.
- 9:03 PM Changeset in webkit [240703] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove default constructor from LLIntPrototypeLoadAdaptiveStructureWatchpoint
https://bugs.webkit.org/show_bug.cgi?id=194000
<rdar://problem/47642894>
Reviewed by Mark Lam.
default constructor is unused and
LLIntPrototypeLoadAdaptiveStructureWatchpoint has a reference
data member which causes sadness.
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
- 6:55 PM Changeset in webkit [240702] by
-
- 2 edits in trunk/Source/WebKit
iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
https://bugs.webkit.org/show_bug.cgi?id=193996
Reviewed by Wenson Hsieh.
Added a missing nullptr check.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 6:03 PM Changeset in webkit [240701] by
-
- 2 edits in trunk/Source/WebCore
[MSE] add more source buffer logging
https://bugs.webkit.org/show_bug.cgi?id=193995
<rdar://problem/47650399>
Reviewed by Jon Lee.
No new tests, no functional change.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::resetParserState):
(WebCore::SourceBufferPrivateAVFObjC::setReadyState):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::willSeek):
(WebCore::SourceBufferPrivateAVFObjC::setDecompressionSession):
- 6:01 PM Changeset in webkit [240700] by
-
- 4 edits in trunk/Tools
[Mac] Update window scale API usage
https://bugs.webkit.org/show_bug.cgi?id=193991
rdar://problem/47614795
Reviewed by Tim Horton.
- DumpRenderTree/mac/DumpRenderTree.mm:
(changeWindowScaleIfNeeded):
- DumpRenderTree/mac/DumpRenderTreeWindow.h:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::changeWindowScaleIfNeeded):
- 5:57 PM Changeset in webkit [240699] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Enabled Changes panel in Elements tab by default
https://bugs.webkit.org/show_bug.cgi?id=193986
<rdar://problem/47647683>
Reviewed by Matt Baker.
- UserInterface/Base/Setting.js:
- UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- 5:55 PM Changeset in webkit [240698] by
-
- 15 edits6 adds in trunk
Add nodes to the scrolling tree in z-index order.
https://bugs.webkit.org/show_bug.cgi?id=192529
<rdar://problem/47402708>
Reviewed by Dean Jackson.
Source/WebCore:
We currently add nodes to the scrolling tree via RenderLayerBacking::updateGeometry() and some other places.
This is sub-optimal, because we don't readily know the scrolling ancestor at these times, so have to do RenderLayer
walks to find them.
With this change we update the scrolling tree during the RenderLayerCompositor::updateBackingAndHierarchy()
tree walk, storing state along the way so we always know our scrolling tree ancestor, and the sibling index
(which makes it so that the scrolling tree correctly reflects layer z-order).
The reattachSubframeScrollLayers() code path is removed, since we can now reliably parent frame nodes via FrameHosting
nodes in their parent document.
There is also some minor cleanup around RenderLayerBacking teardown; it used to be the case that cleanup in ~RenderLayerBacking
was hard because the backing was already disconnected from its owning RenderLayer, so I added RenderLayerBacking::willBeDestroyed()
to do work that requires that layer->backing() is still valid. This allows for fewer callsites for detachFromScrollingCoordinator().
updateScrollCoordinatedLayersAfterFlushIncludingSubframes() is now iOS-only because it's only relevant for iOS WK1,
and m_scrollCoordinatedLayers can be moved to LegacyWebKitScrollingLayerCoordinator.
Tests: scrollingcoordinator/scrolling-tree/overflow-in-fixed.html
scrollingcoordinator/scrolling-tree/scrolling-tree-is-z-order.html
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::insertNode):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::~ScrollingTreeNode):
- platform/Logging.cpp:
(WebCore::initializeLogChannelsIfNecessary):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setParent):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::willBeDestroyed):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateBackgroundLayer):
(WebCore::RenderLayerBacking::coordinatedScrollingRoles const):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
(WebCore::RenderLayerCompositor::didChangePlatformLayerForLayer):
(WebCore::frameHostingNodeForFrame):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):
(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayerWithRole):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForLayer):
(WebCore::RenderLayerCompositor::updateScrollingNodeForViewportConstrainedRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForFrameHostingRole):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):
(WebCore::LegacyWebKitScrollingLayerCoordinator::registerAllViewportConstrainedLayers):
(WebCore::LegacyWebKitScrollingLayerCoordinator::addScrollingLayer):
(WebCore::LegacyWebKitScrollingLayerCoordinator::removeScrollingLayer):
(WebCore::LegacyWebKitScrollingLayerCoordinator::removeLayer):
(WebCore::LegacyWebKitScrollingLayerCoordinator::addViewportConstrainedLayer):
(WebCore::LegacyWebKitScrollingLayerCoordinator::removeViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush): Deleted.
(WebCore::RenderLayerCompositor::setCompositingParent): Deleted. This was always called with a null parentLayer, so was a no-op.
(WebCore::RenderLayerCompositor::removeCompositedChildren): Deleted.
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged): Deleted. The work happens via didChangePlatformLayerForLayer() now.
(WebCore::canCoordinateScrollingForLayer): Deleted.
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus): Deleted.
(WebCore::enclosingScrollingNodeID): Deleted.
(WebCore::scrollCoordinatedAncestorInParentOfFrame): Deleted.
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers): Deleted.
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame): Deleted.
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): Deleted.
- rendering/RenderLayerCompositor.h:
Source/WebKit:
FrameHosting nodes have layers, so need to update them.
- Platform/Logging.cpp:
(WebKit::initializeLogChannelsIfNecessary):
- UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):
LayoutTests:
New testcases for z-order of sibling fixed layers, and the correct nesting of scrolling tree nodes
for a position:fixed which is also overflow:scroll.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt: Added.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/scrolling-tree-is-z-order-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
- scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/overflow-in-fixed.html: Added.
- scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
- scrollingcoordinator/scrolling-tree/scrolling-tree-is-z-order-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/scrolling-tree-is-z-order.html: Added.
- 5:42 PM Changeset in webkit [240697] by
-
- 2 edits in trunk/Source/WebCore
Make sure we have a frame before trying to access its loader
https://bugs.webkit.org/show_bug.cgi?id=193985
<rdar://problem/47618239>
Reviewed by Ryosuke Niwa.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
- 5:42 PM Changeset in webkit [240696] by
-
- 6 edits in trunk/Source/WebKit
Change NetworkConnectionToWebProcess* to NetworkConnectionToWebProcess& where possible
https://bugs.webkit.org/show_bug.cgi?id=193974
Reviewed by Tim Horton.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerFileBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::registerBlobURLOptionallyFileBacked):
(WebKit::NetworkBlobRegistry::registerBlobURLForSlice):
(WebKit::NetworkBlobRegistry::unregisterBlobURL):
(WebKit::NetworkBlobRegistry::blobSize):
(WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerFileBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):
(WebKit::NetworkConnectionToWebProcess::registerBlobURLForSlice):
(WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
(WebKit::NetworkConnectionToWebProcess::blobSize):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::removeNetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.h:
- 5:16 PM Changeset in webkit [240695] by
-
- 2 edits in trunk/Tools
REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=193977
<rdar://problem/47643716>
Reviewed by Geoff Garen.
Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
to the previous provisional committing *before* we make the last load.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 5:11 PM Changeset in webkit [240694] by
-
- 3 edits in trunk/LayoutTests
Updating expectations for two compositing/repaint/iframes/ tests
https://bugs.webkit.org/show_bug.cgi?id=193907
Unreviewed test gardening.
- platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
- platform/mac-highsierra-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
- 5:02 PM Changeset in webkit [240693] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 4:43 PM Changeset in webkit [240692] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the watchOS build.
- dom/Element.cpp:
- 4:37 PM Changeset in webkit [240691] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: enable computed style cascades by default
https://bugs.webkit.org/show_bug.cgi?id=193983
<rdar://problem/47645821>
Reviewed by Matt Baker.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Setting.js:
- UserInterface/Views/ComputedStyleDetailsPanel.css:
(.computed-style-properties):
(.computed-style-properties .property .go-to-arrow):
(.details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)):
(.details-section.computed-style-properties > .content):
(@media (prefers-color-scheme: dark)):
(.computed-with-traces .computed-style-properties): Deleted.
(.computed-with-traces .details-section.computed-style-properties:not(.collapsed) > :matches(.header, .content)): Deleted.
(.computed-with-traces .details-section.computed-style-properties > .content): Deleted.
(.computed-with-traces .computed-style-properties .property .go-to-arrow): Deleted.
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.refresh):
(WI.ComputedStyleDetailsPanel.prototype.initialLayout):
- UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
(WI.ComputedStyleDetailsSidebarPanel):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- 4:26 PM Changeset in webkit [240690] by
-
- 1 copy in tags/Safari-607.1.30
Tag Safari-607.1.30.
- 4:16 PM Changeset in webkit [240689] by
-
- 14 edits2 adds in trunk
Adopt new SPI to evaluate server certificate trust
https://bugs.webkit.org/show_bug.cgi?id=193355
Reviewed by Alex Christensen.
Source/WebKit:
Use new SPI provided in NSURLSession to evaluate server certificates.
If successful, let loading proceed as usual.
Otherwise, go to the UIProcess to ask for a decision on continuing the load or not.
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(canNSURLSessionTrustEvaluate):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):
Tools:
Add infrastructure to handle HTTPS server trust evaluation testing.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
(WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
(WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::TestController::didReceiveAuthenticationChallenge):
(WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
- WebKitTestRunner/TestController.h:
(WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
LayoutTests:
- http/tests/ssl/certificate-validation-expected.txt: Added.
- http/tests/ssl/certificate-validation.html: Added.
- 4:14 PM Changeset in webkit [240688] by
-
- 4 edits in trunk/Source/WebKit
Fix the build
- UIProcess/ios/WKDrawingCoordinator.h:
- UIProcess/ios/WKDrawingCoordinator.mm:
- UIProcess/ios/WKDrawingView.mm:
- 4:02 PM Changeset in webkit [240687] by
-
- 10 edits in trunk/Source/WebKit
Remove unused NetworkProcessProxy::writeBlobToFilePath
https://bugs.webkit.org/show_bug.cgi?id=193990
Reviewed by Wenson Hsieh.
This code was only used in code that was introduced in r235202
but that has since been refactored to not use blobs. Its tests still pass.
This removes the only UIProcess-controlled code that uses NetworkBlobRegistry::singleton.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::writeBlobToFilePath): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::writeToURLForFilePromiseProvider):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::writeBlobToFilePath): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::writeBlobToFilePath): Deleted.
- UIProcess/WebPageProxy.h:
- 3:10 PM Changeset in webkit [240686] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove FIXME for Annex B.3.5's "for-of var" subcase.
Rubber-stamped by Yusuke Suzuki.
This subcase is removed from the spec in https://github.com/tc39/ecma262/pull/1393.
- parser/Parser.h:
(JSC::Parser::declareHoistedVariable):
- 2:40 PM Changeset in webkit [240685] by
-
- 9 edits2 moves in trunk/Source/WebKit
Web Inspector: expose a way of determining if a detached frontend is for a remote target
https://bugs.webkit.org/show_bug.cgi?id=193951
<rdar://problem/47621366>
Reviewed by Joseph Pecoraro.
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::InspectionTargetType): Added.
(WebKit::WebInspectorProxy::createFrontendWindow):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createFrontendWindow):
(WebKit::WebInspectorProxy::platformCreateFrontendWindow):
- UIProcess/mac/RemoteWebInspectorProxyMac.mm:
(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
- UIProcess/API/Cocoa/_WKInspectorWindow.h: Moved from UIProcess/mac/WKInspectorWindow.h.
- UIProcess/API/Cocoa/_WKInspectorWindow.mm: Moved from UIProcess/mac/WKInspectorWindow.mm.
(-[WKInspectorWindow isRemote]): Added.
- Shared/API/Cocoa/_WKNSWindowExtras.mm:
(-[NSWindow _web_isWebInspectorWindow]):
- PlatformMac.cmake:
- SourcesCocoa.txt:
- UnifiedSources-input.xcfilelist:
- WebKit.xcodeproj/project.pbxproj:
- 2:25 PM Changeset in webkit [240684] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unneeded CPU(BIG_ENDIAN) handling in LLInt after new bytecode format.
https://bugs.webkit.org/show_bug.cgi?id=132333
Reviewed by Yusuke Suzuki.
- bytecode/InstructionStream.h:
(JSC::InstructionStreamWriter::write):
- The 32-bit write() function need not invert the order of the bytes written to the bytecode stream for CPU(BUG_ENDIAN) because the incoming uint32_t value to be written is already in big endian order for CPU(BUG_ENDIAN) platforms.
- llint/LLIntOfflineAsmConfig.h:
- OFFLINE_ASM_BIG_ENDIAN is no longer needed nor used after the new bytecode format.
- 2:12 PM Changeset in webkit [240683] by
-
- 59 edits12 moves in trunk/Source/WebKit
Rename ChildProcess to AuxiliaryProcess
https://bugs.webkit.org/show_bug.cgi?id=193943
Reviewed by Andy Estes.
"Child" implies that there is a parent, but I'm about to introduce a type of NetworkProcess that
doesn't always have a parent, and may have many UIProcesses that it is the auxiliary for.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- NetworkProcess/Cookies/WebCookieManager.cpp:
- NetworkProcess/Cookies/soup/WebCookieManagerSoup.cpp:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(WebKit::initializeAuxiliaryProcess<NetworkProcess>):
(WebKit::initializeChildProcess<NetworkProcess>): Deleted.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::callExitSoon):
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::initializeConnection):
(WebKit::NetworkProcess::terminate):
(WebKit::NetworkProcess::initializeProcess):
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessSupplement.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::initializeProcess):
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcess):
(WebKit::NetworkProcess::initializeProcessName):
(WebKit::NetworkProcess::initializeSandbox):
- NetworkProcess/soup/NetworkProcessMainSoup.cpp:
(WebKit::initializeAuxiliaryProcess<NetworkProcess>):
(WebKit::NetworkProcessMainUnix):
(WebKit::initializeChildProcess<NetworkProcess>): Deleted.
- NetworkProcess/watchos/NetworkProximityManager.h:
- NetworkProcess/watchos/NetworkProximityManager.mm:
(WebKit::NetworkProximityManager::NetworkProximityManager):
- NetworkProcess/win/NetworkProcessMainWin.cpp:
(WebKit::initializeAuxiliaryProcess<NetworkProcess>):
(WebKit::NetworkProcessMainWin):
(WebKit::initializeChildProcess<NetworkProcess>): Deleted.
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWin.cmake:
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::initializeConnection):
(WebKit::PluginProcess::didReceiveMessage):
(WebKit::PluginProcess::initializeProcessName):
(WebKit::PluginProcess::initializeSandbox):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess):
(WebKit::PluginProcess::initializeProcessName):
(WebKit::PluginProcess::initializeSandbox):
(WebKit::PluginProcess::stopRunLoop):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- PluginProcess/unix/PluginProcessUnix.cpp:
(WebKit::PluginProcess::platformInitializeProcess):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
- Shared/Authentication/AuthenticationManager.h:
- Shared/AuxiliaryProcess.cpp: Copied from Source/WebKit/Shared/ChildProcess.cpp.
(WebKit::AuxiliaryProcess::AuxiliaryProcess):
(WebKit::AuxiliaryProcess::~AuxiliaryProcess):
(WebKit::AuxiliaryProcess::didClose):
(WebKit::AuxiliaryProcess::initialize):
(WebKit::AuxiliaryProcess::setProcessSuppressionEnabled):
(WebKit::AuxiliaryProcess::initializeProcess):
(WebKit::AuxiliaryProcess::initializeProcessName):
(WebKit::AuxiliaryProcess::initializeConnection):
(WebKit::AuxiliaryProcess::addMessageReceiver):
(WebKit::AuxiliaryProcess::removeMessageReceiver):
(WebKit::AuxiliaryProcess::disableTermination):
(WebKit::AuxiliaryProcess::enableTermination):
(WebKit::AuxiliaryProcess::messageSenderConnection):
(WebKit::AuxiliaryProcess::messageSenderDestinationID):
(WebKit::AuxiliaryProcess::terminationTimerFired):
(WebKit::AuxiliaryProcess::stopRunLoop):
(WebKit::AuxiliaryProcess::platformStopRunLoop):
(WebKit::AuxiliaryProcess::terminate):
(WebKit::AuxiliaryProcess::shutDown):
(WebKit::AuxiliaryProcess::registerURLSchemeServiceWorkersCanHandle const):
(WebKit::AuxiliaryProcess::platformInitialize):
(WebKit::AuxiliaryProcess::initializeSandbox):
(WebKit::AuxiliaryProcess::didReceiveInvalidMessage):
(WebKit::AuxiliaryProcess::didReceiveMemoryPressureEvent):
(WebKit::ChildProcess::ChildProcess): Deleted.
(WebKit::ChildProcess::~ChildProcess): Deleted.
(WebKit::ChildProcess::didClose): Deleted.
(WebKit::ChildProcess::initialize): Deleted.
(WebKit::ChildProcess::setProcessSuppressionEnabled): Deleted.
(WebKit::ChildProcess::initializeProcess): Deleted.
(WebKit::ChildProcess::initializeProcessName): Deleted.
(WebKit::ChildProcess::initializeConnection): Deleted.
(WebKit::ChildProcess::addMessageReceiver): Deleted.
(WebKit::ChildProcess::removeMessageReceiver): Deleted.
(WebKit::ChildProcess::disableTermination): Deleted.
(WebKit::ChildProcess::enableTermination): Deleted.
(WebKit::ChildProcess::messageSenderConnection): Deleted.
(WebKit::ChildProcess::messageSenderDestinationID): Deleted.
(WebKit::ChildProcess::terminationTimerFired): Deleted.
(WebKit::ChildProcess::stopRunLoop): Deleted.
(WebKit::ChildProcess::platformStopRunLoop): Deleted.
(WebKit::ChildProcess::terminate): Deleted.
(WebKit::ChildProcess::shutDown): Deleted.
(WebKit::ChildProcess::registerURLSchemeServiceWorkersCanHandle const): Deleted.
(WebKit::ChildProcess::platformInitialize): Deleted.
(WebKit::ChildProcess::initializeSandbox): Deleted.
(WebKit::ChildProcess::didReceiveInvalidMessage): Deleted.
(WebKit::ChildProcess::didReceiveMemoryPressureEvent): Deleted.
- Shared/AuxiliaryProcess.h: Copied from Source/WebKit/Shared/ChildProcess.h.
(WebKit::ChildProcess::parentProcessConnection const): Deleted.
(WebKit::ChildProcess::messageReceiverMap): Deleted.
(WebKit::ChildProcess::setTerminationTimeout): Deleted.
(WebKit::ChildProcess::shouldOverrideQuarantine): Deleted.
- Shared/AuxiliaryProcess.messages.in: Copied from Source/WebKit/Shared/ChildProcess.messages.in.
- Shared/AuxiliaryProcessSupplement.h: Copied from Source/WebKit/Shared/ChildProcessSupplement.h.
(WebKit::AuxiliaryProcessSupplement::~AuxiliaryProcessSupplement):
(WebKit::ChildProcessSupplement::~ChildProcessSupplement): Deleted.
(WebKit::ChildProcessSupplement::initializeConnection): Deleted.
- Shared/ChildProcess.cpp: Removed.
- Shared/ChildProcess.h: Removed.
- Shared/ChildProcess.messages.in: Removed.
- Shared/ChildProcessSupplement.h: Removed.
- Shared/Cocoa/AuxiliaryProcessCocoa.mm: Copied from Source/WebKit/Shared/Cocoa/ChildProcessCocoa.mm.
(WebKit::AuxiliaryProcess::didReceiveInvalidMessage):
(WebKit::ChildProcess::didReceiveInvalidMessage): Deleted.
- Shared/Cocoa/ChildProcessCocoa.mm: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::initializeAuxiliaryProcess):
(WebKit::XPCServiceInitializer):
(WebKit::initializeChildProcess): Deleted.
- Shared/WebSQLiteDatabaseTracker.cpp:
(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):
(WebKit::WebSQLiteDatabaseTracker::hysteresisUpdated):
(WebKit::m_childProcessType): Deleted.
- Shared/WebSQLiteDatabaseTracker.h:
- Shared/ios/AuxiliaryProcessIOS.mm: Copied from Source/WebKit/Shared/ios/ChildProcessIOS.mm.
(WebKit::AuxiliaryProcess::platformInitialize):
(WebKit::AuxiliaryProcess::initializeSandbox):
(WebKit::AuxiliaryProcess::setQOS):
(WebKit::AuxiliaryProcess::platformStopRunLoop):
(WebKit::ChildProcess::platformInitialize): Deleted.
(WebKit::ChildProcess::initializeSandbox): Deleted.
(WebKit::ChildProcess::setQOS): Deleted.
(WebKit::ChildProcess::platformStopRunLoop): Deleted.
- Shared/ios/ChildProcessIOS.mm: Removed.
- Shared/mac/AuxiliaryProcessMac.mm: Copied from Source/WebKit/Shared/mac/ChildProcessMac.mm.
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::AuxiliaryProcess::launchServicesCheckIn):
(WebKit::AuxiliaryProcess::platformInitialize):
(WebKit::processStorageClass):
(WebKit::sandboxDirectory):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::AuxiliaryProcess::initializeSandbox):
(WebKit::AuxiliaryProcess::stopNSAppRunLoop):
(WebKit::AuxiliaryProcess::stopNSRunLoop):
(WebKit::AuxiliaryProcess::platformStopRunLoop):
(WebKit::AuxiliaryProcess::setQOS):
(WebKit::AuxiliaryProcess::isSystemWebKit):
(WebKit::ChildProcess::launchServicesCheckIn): Deleted.
(WebKit::ChildProcess::platformInitialize): Deleted.
(WebKit::ChildProcess::initializeSandbox): Deleted.
(WebKit::ChildProcess::stopNSAppRunLoop): Deleted.
(WebKit::ChildProcess::stopNSRunLoop): Deleted.
(WebKit::ChildProcess::platformStopRunLoop): Deleted.
(WebKit::ChildProcess::setQOS): Deleted.
(WebKit::ChildProcess::isSystemWebKit): Deleted.
- Shared/mac/ChildProcessMac.mm: Removed.
- Shared/mac/SecItemShim.cpp:
(WebKit::globalNetworkProcess):
(WebKit::sendSecItemRequest):
(WebKit::initializeSecItemShim):
- Shared/mac/SecItemShim.h:
- Shared/unix/AuxiliaryProcessMain.cpp: Copied from Source/WebKit/Shared/unix/ChildProcessMain.cpp.
(WebKit::AuxiliaryProcessMainBase::parseCommandLine):
(WebKit::ChildProcessMainBase::parseCommandLine): Deleted.
- Shared/unix/AuxiliaryProcessMain.h: Copied from Source/WebKit/Shared/unix/ChildProcessMain.h.
(WebKit::AuxiliaryProcessMainBase::takeInitializationParameters):
(WebKit::initializeAuxiliaryProcess):
(WebKit::AuxiliaryProcessMain):
(WebKit::ChildProcessMainBase::platformInitialize): Deleted.
(WebKit::ChildProcessMainBase::platformFinalize): Deleted.
(WebKit::ChildProcessMainBase::takeInitializationParameters): Deleted.
(WebKit::initializeChildProcess): Deleted.
(WebKit::ChildProcessMain): Deleted.
- Shared/unix/ChildProcessMain.cpp: Removed.
- Shared/unix/ChildProcessMain.h: Removed.
- Shared/win/AuxiliaryProcessMainWin.cpp: Copied from Source/WebKit/Shared/win/ChildProcessMainWin.cpp.
(WebKit::AuxiliaryProcessMainBase::parseCommandLine):
(WebKit::ChildProcessMainBase::parseCommandLine): Deleted.
- Shared/win/ChildProcessMainWin.cpp: Removed.
- Sources.txt:
- SourcesCocoa.txt:
- SourcesGTK.txt:
- SourcesWPE.txt:
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
- UIProcess/AuxiliaryProcessProxy.cpp: Copied from Source/WebKit/UIProcess/ChildProcessProxy.cpp.
(WebKit::AuxiliaryProcessProxy::AuxiliaryProcessProxy):
(WebKit::AuxiliaryProcessProxy::~AuxiliaryProcessProxy):
(WebKit::AuxiliaryProcessProxy::getLaunchOptions):
(WebKit::AuxiliaryProcessProxy::connect):
(WebKit::AuxiliaryProcessProxy::terminate):
(WebKit::AuxiliaryProcessProxy::state const):
(WebKit::AuxiliaryProcessProxy::sendMessage):
(WebKit::AuxiliaryProcessProxy::addMessageReceiver):
(WebKit::AuxiliaryProcessProxy::removeMessageReceiver):
(WebKit::AuxiliaryProcessProxy::dispatchMessage):
(WebKit::AuxiliaryProcessProxy::dispatchSyncMessage):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
(WebKit::AuxiliaryProcessProxy::shutDownProcess):
(WebKit::AuxiliaryProcessProxy::setProcessSuppressionEnabled):
(WebKit::AuxiliaryProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::ChildProcessProxy): Deleted.
(WebKit::ChildProcessProxy::~ChildProcessProxy): Deleted.
(WebKit::ChildProcessProxy::getLaunchOptions): Deleted.
(WebKit::ChildProcessProxy::connect): Deleted.
(WebKit::ChildProcessProxy::terminate): Deleted.
(WebKit::ChildProcessProxy::state const): Deleted.
(WebKit::ChildProcessProxy::sendMessage): Deleted.
(WebKit::ChildProcessProxy::addMessageReceiver): Deleted.
(WebKit::ChildProcessProxy::removeMessageReceiver): Deleted.
(WebKit::ChildProcessProxy::dispatchMessage): Deleted.
(WebKit::ChildProcessProxy::dispatchSyncMessage): Deleted.
(WebKit::ChildProcessProxy::didFinishLaunching): Deleted.
(WebKit::ChildProcessProxy::shutDownProcess): Deleted.
(WebKit::ChildProcessProxy::setProcessSuppressionEnabled): Deleted.
(WebKit::ChildProcessProxy::connectionWillOpen): Deleted.
- UIProcess/AuxiliaryProcessProxy.h: Copied from Source/WebKit/UIProcess/ChildProcessProxy.h.
(WebKit::AuxiliaryProcessProxy::send):
(WebKit::AuxiliaryProcessProxy::sendSync):
(WebKit::AuxiliaryProcessProxy::sendWithAsyncReply):
(WebKit::ChildProcessProxy::send): Deleted.
(WebKit::ChildProcessProxy::sendSync): Deleted.
(WebKit::ChildProcessProxy::connection const): Deleted.
(WebKit::ChildProcessProxy::hasConnection const): Deleted.
(WebKit::ChildProcessProxy::processIdentifier const): Deleted.
(WebKit::ChildProcessProxy::canSendMessage const): Deleted.
(WebKit::ChildProcessProxy::coreProcessIdentifier const): Deleted.
(WebKit::ChildProcessProxy::platformGetLaunchOptions): Deleted.
(WebKit::ChildProcessProxy::sendWithAsyncReply): Deleted.
- UIProcess/ChildProcessProxy.cpp: Removed.
- UIProcess/ChildProcessProxy.h: Removed.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::DownloadProxyMap):
- UIProcess/Downloads/DownloadProxyMap.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::didFinishLaunching):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::getLaunchOptions):
(WebKit::PluginProcessProxy::sendMemoryPressureEvent):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/ServiceWorkerProcessProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::finishAttachingToWebProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::sendMemoryPressureEvent):
(WebKit::WebProcessPool::registerURLSchemeServiceWorkersCanHandle):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::getLaunchOptions):
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::maybeShutDown):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):
(WebKit::WebProcessProxy::shouldTerminate):
(WebKit::WebProcessProxy::requestTermination):
(WebKit::WebProcessProxy::canTerminateChildProcess): Deleted.
- UIProcess/WebProcessProxy.h:
- UnifiedSources-input.xcfilelist:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::initializeSandbox):
(WebKit::WebProcess::platformInitializeProcess):
- WebProcess/WebProcess.h:
- WebProcess/WebProcessSupplement.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::stopRunLoop):
(WebKit::WebProcess::initializeSandbox):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainUnix):
- WebProcess/win/WebProcessMainWin.cpp:
(WebKit::WebProcessMainWin):
- WebProcess/wpe/WebProcessMainWPE.cpp:
(WebKit::WebProcessMainUnix):
- 2:11 PM Changeset in webkit [240682] by
-
- 2 edits in trunk/LayoutTests
[ Mac WK2 ] Layout Test http/tests/cache-storage/cache-clearing-origin.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=193976
Unreviewed test gardening.
Patch by Shawn Roberts <Shawn Roberts> on 2019-01-29
- platform/mac-wk2/TestExpectations:
- 2:04 PM Changeset in webkit [240681] by
-
- 3 edits1 add in trunk
ValueRecovery::recover() should purify NaN values it recovers.
https://bugs.webkit.org/show_bug.cgi?id=193978
<rdar://problem/47625488>
Reviewed by Saam Barati.
JSTests:
- stress/value-recovery-of-double-displaced-in-jsstack-should-be-purified.js: Added.
Source/JavaScriptCore:
According to DFG::OSRExit::executeOSRExit() and DFG::OSRExit::compileExit(),
recovered DoubleDisplacedInJSStack values need to be purified.
ValueRecovery::recover() should do the same.
- bytecode/ValueRecovery.cpp:
(JSC::ValueRecovery::recover const):
- 1:56 PM Changeset in webkit [240680] by
-
- 3 edits in trunk/Tools
[ews-build] Add build step to print bot Configuration
https://bugs.webkit.org/show_bug.cgi?id=193887
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(PrintConfiguration): Build step to print configuration.
- BuildSlaveSupport/ews-build/factories.py:
- 1:55 PM Changeset in webkit [240679] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] FTL should handle LocalAllocator*
https://bugs.webkit.org/show_bug.cgi?id=193980
Reviewed by Saam Barati.
At some point, Allocator holds LocalAllocator* instead of 32bit integer. In FTL allocation path, we fail to use this constant LocalAllocator*
because the FTL still use the incoming value as 32bit integer there.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
- 1:38 PM Changeset in webkit [240678] by
-
- 73 edits2 adds in tags/Safari-608.1.3
Cherry-pick r240677. rdar://problem/47604080
REGRESSION(r240553): [iOS] Crash in ScrollingTree::updateTreeFromStateNode when attempting to log in to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=193907
Source/WebCore:
rdar://problem/47604080
Reviewed by Frédéric Wang.
Recent scrolling tree changes can trigger unparenting and reparenting of subtrees in the
state tree. If a subframe's state tree nodes are unparented, a scrolling tree commit would
show these as nodes being destroyed, which destroyed the tree nodes. When re-parented, the
commit would re-create the tree node, but the state node would only have a subset of the
change flags set, so the new tree node would fail to get all of the state (for example, it
would be missing layers and scrolling geometry).
Fix by ensuring that when we reparent state node subtrees, we set all the change flags
so that the full set of data is sent to the scrolling tree (the UI process, in the case of iOS WK2).
Annoyingly, virtual setAllPropertiesChanged() functions are needed so each state node subclass can
set the right change flags.
This patch also gets rid of m_nodesRemovedSinceLastCommit in the state tree. We can gain the same
information by using copying all of the nodeIDs in m_nodeMap into a HashSet, and removing nodes
as we encounter them in the tree walk.
Rename m_latchedNode to m_latchedNodeID in ScrollingTree, since it's a nodeID, not a node pointer.
Test: compositing/geometry/composited-frame-contents.html
- page/scrolling/ScrollingStateFixedNode.cpp: (WebCore::ScrollingStateFixedNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingStateNode.cpp: (WebCore::ScrollingStateNode::setPropertyChanged): (WebCore::ScrollingStateNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateNode.h: (WebCore::ScrollingStateNode::setPropertyChangedBit):
- page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp: (WebCore::ScrollingStateStickyNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::insertNode): Add a RELEASE_ASSERT on the type of the node created if parentID == 0, since mistakes here can associate a ScrollingNodeType::MainFrame node with some other nodeID which can result in type confusion later. (WebCore::ScrollingStateTree::nodeWasReattachedRecursive): (WebCore::ScrollingStateTree::commit): (WebCore::ScrollingStateTree::willRemoveNode): (WebCore::ScrollingStateTree::setRemovedNodes): Deleted.
- page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::removedNodes const): Deleted.
- page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): (WebCore::ScrollingTree::commitTreeState): (WebCore::ScrollingTree::updateTreeFromStateNode): (WebCore::ScrollingTree::latchedNode): (WebCore::ScrollingTree::setLatchedNode): (WebCore::ScrollingTree::clearLatchedNode): (WebCore::ScrollingTree::scrollingTreeAsText): (WebCore::ScrollingTree::removeDestroyedNodes): Deleted.
- page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::hasLatchedNode const):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootLayer): The scroll layer needs a 0,0,0 anchor point so that setting its position doesn't offset it relative to the center.
Source/WebKit:
Reviewed by Frédéric Wang.
Remove encode/decode of removedNodes.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (WebKit::RemoteScrollingCoordinatorTransaction::encode const): (WebKit::RemoteScrollingCoordinatorTransaction::decode): (WebKit::dump):
LayoutTests:
rdar://problem/47604080
Reviewed by Frédéric Wang.
New ref test for layer positions in composited frames.
New baselines with anchor point on the scroll layer.
- compositing/geometry/composited-frame-contents-expected.html: Added.
- compositing/geometry/composited-frame-contents.html: Added.
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/iframe-size-from-zero-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- compositing/iframes/resize-from-zero-size-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
- compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
- compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt:
- platform/ios-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/ios-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/ios-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/ios-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:
- platform/ios-wk2/compositing/visible-rect/iframe-and-layers-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- platform/ios/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/ios/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/ios/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/ios/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/ios/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- platform/ios/compositing/iframes/resizer-expected.txt:
- platform/ios/compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt:
- platform/mac-wk1/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
- platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
- platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:
- platform/mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt:
- scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:29 PM Changeset in webkit [240677] by
-
- 73 edits2 adds in trunk
REGRESSION(r240553): [iOS] Crash in ScrollingTree::updateTreeFromStateNode when attempting to log in to icloud.com
https://bugs.webkit.org/show_bug.cgi?id=193907
Source/WebCore:
rdar://problem/47604080
Reviewed by Frédéric Wang.
Recent scrolling tree changes can trigger unparenting and reparenting of subtrees in the
state tree. If a subframe's state tree nodes are unparented, a scrolling tree commit would
show these as nodes being destroyed, which destroyed the tree nodes. When re-parented, the
commit would re-create the tree node, but the state node would only have a subset of the
change flags set, so the new tree node would fail to get all of the state (for example, it
would be missing layers and scrolling geometry).
Fix by ensuring that when we reparent state node subtrees, we set all the change flags
so that the full set of data is sent to the scrolling tree (the UI process, in the case of iOS WK2).
Annoyingly, virtual setAllPropertiesChanged() functions are needed so each state node subclass can
set the right change flags.
This patch also gets rid of m_nodesRemovedSinceLastCommit in the state tree. We can gain the same
information by using copying all of the nodeIDs in m_nodeMap into a HashSet, and removing nodes
as we encounter them in the tree walk.
Rename m_latchedNode to m_latchedNodeID in ScrollingTree, since it's a nodeID, not a node pointer.
Test: compositing/geometry/composited-frame-contents.html
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateFixedNode.h:
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::setPropertyChanged):
(WebCore::ScrollingStateNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::setPropertyChangedBit):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::setAllPropertiesChanged):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::insertNode): Add a RELEASE_ASSERT on the type of the node created
if parentID == 0, since mistakes here can associate a ScrollingNodeType::MainFrame node with some
other nodeID which can result in type confusion later.
(WebCore::ScrollingStateTree::nodeWasReattachedRecursive):
(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::setRemovedNodes): Deleted.
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::removedNodes const): Deleted.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitTreeState):
(WebCore::ScrollingTree::updateTreeFromStateNode):
(WebCore::ScrollingTree::latchedNode):
(WebCore::ScrollingTree::setLatchedNode):
(WebCore::ScrollingTree::clearLatchedNode):
(WebCore::ScrollingTree::scrollingTreeAsText):
(WebCore::ScrollingTree::removeDestroyedNodes): Deleted.
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::hasLatchedNode const):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer): The scroll layer needs a 0,0,0 anchor point so that
setting its position doesn't offset it relative to the center.
Source/WebKit:
Reviewed by Frédéric Wang.
Remove encode/decode of removedNodes.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::encode const):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::dump):
LayoutTests:
rdar://problem/47604080
Reviewed by Frédéric Wang.
New ref test for layer positions in composited frames.
New baselines with anchor point on the scroll layer.
- compositing/geometry/composited-frame-contents-expected.html: Added.
- compositing/geometry/composited-frame-contents.html: Added.
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/iframe-size-from-zero-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- compositing/iframes/resize-from-zero-size-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
- compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
- compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt:
- platform/ios-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/ios-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/ios-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/ios-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/ios-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/ios-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/ios-wk2/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:
- platform/ios-wk2/compositing/visible-rect/iframe-and-layers-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- platform/ios/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/ios/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/ios/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/ios/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/ios/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- platform/ios/compositing/iframes/resizer-expected.txt:
- platform/ios/compositing/visible-rect/iframe-with-layers-outside-viewport-expected.txt:
- platform/mac-wk1/compositing/iframes/remove-reinsert-webview-with-iframe-expected.txt:
- platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
- platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
- platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt:
- platform/mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt:
- scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- tiled-drawing/tile-coverage-iframe-to-zero-coverage-expected.txt:
- 1:27 PM Changeset in webkit [240676] by
-
- 17 edits in trunk/Source/WebKit
StorageAccess API calls should be direct to the Network Process
https://bugs.webkit.org/show_bug.cgi?id=193924
<rdar://problem/47611249>
Reviewed by Alex Christensen.
Now that the ResourceLoadStatistics data lives in the Network Process, calls to Storage Access
API should happen directly between the WebContent and Network processes.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessGranted):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::removeStorageAccessForFrame):
(WebKit::NetworkConnectionToWebProcess::removeStorageAccessForAllFramesOnPage):
(WebKit::NetworkConnectionToWebProcess::logUserInteraction):
(WebKit::NetworkConnectionToWebProcess::logWebSocketLoading):
(WebKit::NetworkConnectionToWebProcess::logSubresourceLoading):
(WebKit::NetworkConnectionToWebProcess::logSubresourceRedirect):
(WebKit::NetworkConnectionToWebProcess::requestResourceLoadStatisticsUpdate):
(WebKit::NetworkConnectionToWebProcess::hasStorageAccess):
(WebKit::NetworkConnectionToWebProcess::requestStorageAccess):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::requestStorageAccess):
(WebKit::NetworkProcess::requestStorageAccessGranted):
- NetworkProcess/NetworkProcess.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::requestStorageAccessConfirm):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestStorageAccessConfirm):
(WebKit::WebPageProxy::hasStorageAccess): Deleted.
(WebKit::WebPageProxy::requestStorageAccess): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hasStorageAccess):
(WebKit::WebPage::requestStorageAccess):
(WebKit::nextRequestStorageAccessContextId): Deleted.
(WebKit::WebPage::storageAccessResponse): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 12:59 PM Changeset in webkit [240675] by
-
- 5 edits in trunk
Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
https://bugs.webkit.org/show_bug.cgi?id=193967
<rdar://problem/47635348>
Reviewed by Alex Christensen.
Source/WebKit:
Update WebPageProxy::receivedPolicyDecision() to no longer clear the pending URL when we send PolicyAction::Ignore to
the old process when the load is continuing in a new process due to PSON.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
- UIProcess/WebPageProxy.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
- 12:55 PM Changeset in webkit [240674] by
-
- 2 edits in trunk/Tools
[ews-app] Handle incoming results data
https://bugs.webkit.org/show_bug.cgi?id=193973
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/views/results.py:
- 12:53 PM Changeset in webkit [240673] by
-
- 2 edits in trunk/Tools
[ews-app] Make the results url generic
https://bugs.webkit.org/show_bug.cgi?id=193928
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/urls.py:
- 12:50 PM Changeset in webkit [240672] by
-
- 6 edits in trunk
[WebGPU] Fix and add validation to WebGPURenderPipeline and MTLVertexDescriptor
https://bugs.webkit.org/show_bug.cgi?id=193926
<rdar://problem/47327648>
Reviewed by Myles C. Maxfield.
Source/WebCore:
Update vertex input to properly utilize inputSlot and shaderLocation fields, and add some validation.
Test: webgpu/vertex-buffer-triangle-strip.html
- Modules/webgpu/WebGPUVertexInputDescriptor.idl:
- platform/graphics/gpu/GPUVertexInputDescriptor.h:
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::setInputStateForPipelineDescriptor): Properly retain Metal types.
(WebCore::GPURenderPipeline::create): Provide error logging for MTLRenderPipelineState creation.
LayoutTests:
Updated test for new vertex input logic. Now provides color as a vertex attribute.
- webgpu/vertex-buffer-triangle-strip.html:
- 12:37 PM Changeset in webkit [240671] by
-
- 2 edits1 add in trunk/Tools
[ews-build] Configure buildbot to send events to ews-app
https://bugs.webkit.org/show_bug.cgi?id=193968
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/events.py: Added.
- BuildSlaveSupport/ews-build/master.cfg:
- 12:36 PM Changeset in webkit [240670] by
-
- 4 edits in branches/safari-607-branch/Source/WebKit
Cherry-pick r240659. rdar://problem/47639406
Regression(r240046) VoiceOver is no longer working after a process swap
https://bugs.webkit.org/show_bug.cgi?id=193953
<rdar://problem/47612398>
Reviewed by Alex Christensen.
ProvisionalPageProxy used to forward the RegisterWebProcessAccessibilityToken IPC from
the provisional WebProcess to the WebPageProxy right away. This in turn would notify
the PageClient whose logic would rely on WebPageProxy::process(), which returns the
committed process instead of the provisional one.
To address the issue, the ProvisionalPageProxy now stores the token sent by the
provisional WebProcess and we only call registerWebProcessAccessibilityToken()
on the WebPageProxy *after* we've swapped to the provisional process.
- UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::registerWebProcessAccessibilityToken): (WebKit::ProvisionalPageProxy::didReceiveMessage):
- UIProcess/ProvisionalPageProxy.h: (WebKit::ProvisionalPageProxy::takeAccessibilityToken):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::commitProvisionalPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [240669] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 12:05 PM Changeset in webkit [240668] by
-
- 13 edits in trunk
Add .xcfilelists to Run Script build phases
https://bugs.webkit.org/show_bug.cgi?id=193792
<rdar://problem/47201785>
Reviewed by Alex Christensen.
As part of supporting XCBuild, update the necessary Run Script build
phases in their Xcode projects to refer to their associated
.xcfilelist files.
Note that the addition of these files bumps the Xcode project version
number to something that's Xcode 10 compatible. This change means that
older versions of the Xcode IDE can't read these projects. Nor can it
fully load workspaces that refer to these projects (the updated
projects are shown as non-expandable placeholders).xcodebuildcan
still build these projects; it's just that the IDE can't open them.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
Make special accommodations for incorporating .xcfilelists from
WebKitAdditions.
No new tests since there should be no observable behavior difference.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
Make special accommodations for incorporating .xcfilelists from
WebKitAdditions.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- WebKit.xcodeproj/project.pbxproj:
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [240667] by
-
- 6 edits3 adds in trunk
Add data abstraction and validation for Ad Click Attribution
https://bugs.webkit.org/show_bug.cgi?id=193916
<rdar://problem/47603481>
Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
Source/WebCore:
New API tests added.
Ad click attribution has two steps. First, the storage of an ad
campaign ID for a click that takes the user to a destination
site. Second, a conversion on the destination site that can be
attributed to the ad click.
This patch adds a class that represents a request for ad click
attribution. Validation makes sure that the bits of entropy
reported through this mechanism is limited.
This feature is experimental and off by default.
- Sources.txt:
Added loader/AdClickAttribution.cpp.
- WebCore.xcodeproj/project.pbxproj:
- loader/AdClickAttribution.cpp: Added.
(WebCore::AdClickAttribution::isValid const):
(WebCore::AdClickAttribution::setConversion):
(WebCore::AdClickAttribution::url const):
(WebCore::AdClickAttribution::referrer const):
- loader/AdClickAttribution.h: Added.
(WebCore::AdClickAttribution::Campaign::Campaign):
(WebCore::AdClickAttribution::Campaign::isValid const):
(WebCore::AdClickAttribution::Source::Source):
(WebCore::AdClickAttribution::Destination::Destination):
(WebCore::AdClickAttribution::Priority::Priority):
(WebCore::AdClickAttribution::Conversion::Conversion):
(WebCore::AdClickAttribution::Conversion::isValid const):
(WebCore::AdClickAttribution::AdClickAttribution):
(WebCore::AdClickAttribution::earliestTimeToSend const):
- loader/DocumentLoader.cpp:
Added missing #include "RuntimeEnabledFeatures.h".
Tools:
Ad click attribution has two steps. First, the storage of an ad
campaign ID for a click that takes the user to a destination
site. Second, a conversion on the destination site that can be
attributed to the ad click.
This patch adds a class that represents a request for ad click
attribution. Validation makes sure that the bits of entropy
reported through this mechanism is limited.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
(TestWebKitAPI::TEST):
- 11:39 AM Changeset in webkit [240666] by
-
- 6 edits in trunk/Source/WebCore
[MathML] Move enum class ScriptType to MathMLScriptsElement.
https://bugs.webkit.org/show_bug.cgi?id=193969
Reviewed by Antti Koivisto.
- mathml/MathMLScriptsElement.cpp:
(WebCore::scriptTypeOf):
- mathml/MathMLScriptsElement.h:
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::scriptType const):
(WebCore::RenderMathMLScripts::validateAndGetReferenceChildren):
(WebCore::RenderMathMLScripts::computePreferredLogicalWidths):
(WebCore::RenderMathMLScripts::verticalMetrics):
(WebCore::RenderMathMLScripts::layoutBlock):
- rendering/mathml/RenderMathMLScripts.h:
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::isValid const):
(WebCore::RenderMathMLUnderOver::under const):
(WebCore::RenderMathMLUnderOver::over const):
(WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths):
(WebCore::RenderMathMLUnderOver::hasAccent const):
(WebCore::RenderMathMLUnderOver::layoutBlock):
- 11:13 AM Changeset in webkit [240665] by
-
- 6 edits in trunk/Source/ThirdParty/libwebrtc
Adopt new VCP SPI
https://bugs.webkit.org/show_bug.cgi?id=193357
<rdar://problem/43656651>
Reviewed by Eric Carlson.
Enable VCP through VTB API with specific encoder id.
If encoder id is not supported, fallback to VCP.
A specific routine is added to check for encoder id presence.
- Source/webrtc/sdk/WebKit/EncoderUtilities.h:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::setApplicationStatus):
- Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
- 10:39 AM Changeset in webkit [240664] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: provide a way to edit page WebRTC settings on a remote target
https://bugs.webkit.org/show_bug.cgi?id=193863
Unreviewed, skip test from r240644 on WK1 since Media Streams aren't supported.
- platform/mac-wk1/TestExpectations:
- 10:18 AM Changeset in webkit [240663] by
-
- 6 edits in trunk/Source/WebKit
REGRESSION (PSON): Flash on link navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=193961
<rdar://problem/47482507>
Reviewed by Chris Dumez.
The target page sends EnterAcceleratedCompositingMode message too early, before we have a valid layer tree.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::attach): Deleted.
Not needed anymore.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::didCompletePageTransition):
(WebKit::m_shouldAttachDrawingAreaOnPageTransition): Deleted.
Move message sending logic fully to TiledCoreAnimationDrawingArea.
Unfreezing the layer tree is sufficient to trigger the message.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
There is no need to treat process swap case differently.
(WebKit::TiledCoreAnimationDrawingArea::sendEnterAcceleratedCompositingModeIfNeeded):
Send this after the first successful layer flush with the root layer set.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::attach): Deleted.
- 10:15 AM Changeset in webkit [240662] by
-
- 5 edits in trunk/Source/WebKit
Add back some includes that got removed at some point.
https://bugs.webkit.org/show_bug.cgi?id=193942
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
- 9:50 AM Changeset in webkit [240661] by
-
- 24 edits1 copy in trunk/Source
Make sure WTF::generateObjectIdentifier() internal counter does not get duplicated
https://bugs.webkit.org/show_bug.cgi?id=193848
Reviewed by Youenn Fablet.
Source/WebCore:
- dom/Document.cpp:
- dom/MessageChannel.cpp:
(WebCore::MessageChannel::MessageChannel):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::contextIdentifier const):
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::registerTemporaryServiceWorkerClient):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
- platform/Process.cpp:
(WebCore::Process::identifier):
- workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::importRecords):
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::updateWorker):
- workers/service/server/SWServerRegistration.cpp:
(WebCore::generateServiceWorkerRegistrationIdentifier):
- workers/service/server/SWServerToContextConnection.cpp:
(WebCore::generateServerToContextConnectionIdentifier):
Source/WebKit:
- Platform/IPC/Connection.cpp:
(IPC::Connection::Connection):
- UIProcess/ChildProcessProxy.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebProcessPool.cpp:
- WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::addDeviceChangeObserver):
Source/WTF:
Move WTF::generateObjectIdentifier()'s internal counter out-of-line so make sure it never gets
duplicated at each call site. This has caused some hard-to-debug issues with duplicate
identifiers such as Bug 193761.
Also move it to ObjectIdentifier and rename it to generate() as this make call sites nicer
when they have a typedef for the ObjectIdentifier<T> type.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/ObjectIdentifier.cpp: Copied from Source/WebCore/platform/Process.cpp.
(WTF::ObjectIdentifierBase::generateIdentifierInternal):
(WTF::ObjectIdentifierBase::generateThreadSafeIdentifierInternal):
- wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifier::generate):
(WTF::ObjectIdentifier::generateThreadSafe):
- 9:19 AM Changeset in webkit [240660] by
-
- 4 edits in trunk
REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
https://bugs.webkit.org/show_bug.cgi?id=193932
<rdar://problem/47598947>
Reviewed by Brady Eidson.
Source/WebKit:
When doing a client side redirect from origin A to origin B, we would swap process and
create a SuspendedPageProxy and save it on the source BackForwardListItem. The issue is
that the BackForwardList is locked for such redirect so we end up updating the current
BackForwardListItem with origin B's URL while origin A's suspended page remained on
the item. When going to another URL in the same origin A, we would not create a suspended
page since no process-swap would occur. When pressing the back button, we would go back
to the previous BackForwardListItem and use its SuspendedPageProxy, which is for the
wrong URL (The pre-client redirect one).
To address the issue, we no longer create a SuspendedPageProxy for cross-site client side
redirects. There will be no way no go back to this suspended page anyway since the
back/forward list item will be updated with the redirection URL.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 9:16 AM Changeset in webkit [240659] by
-
- 4 edits in trunk/Source/WebKit
Regression(r240046) VoiceOver is no longer working after a process swap
https://bugs.webkit.org/show_bug.cgi?id=193953
<rdar://problem/47612398>
Reviewed by Alex Christensen.
ProvisionalPageProxy used to forward the RegisterWebProcessAccessibilityToken IPC from
the provisional WebProcess to the WebPageProxy right away. This in turn would notify
the PageClient whose logic would rely on WebPageProxy::process(), which returns the
committed process instead of the provisional one.
To address the issue, the ProvisionalPageProxy now stores the token sent by the
provisional WebProcess and we only call registerWebProcessAccessibilityToken()
on the WebPageProxy *after* we've swapped to the provisional process.
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::registerWebProcessAccessibilityToken):
(WebKit::ProvisionalPageProxy::didReceiveMessage):
- UIProcess/ProvisionalPageProxy.h:
(WebKit::ProvisionalPageProxy::takeAccessibilityToken):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
- 8:39 AM Changeset in webkit [240658] by
-
- 5 edits in trunk/Source/WebCore
Use lambdas instead of member pointer functions for TransactionOperationImpl
https://bugs.webkit.org/show_bug.cgi?id=193933
Reviewed by Tim Horton.
No change in behavior. This just makes it easier to add new parameters to these functions in a straightforward manner.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::putOrAdd):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::internalAbort):
(WebCore::IDBTransaction::commit):
(WebCore::IDBTransaction::createObjectStore):
(WebCore::IDBTransaction::renameObjectStore):
(WebCore::IDBTransaction::createIndex):
(WebCore::IDBTransaction::renameIndex):
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::iterateCursor):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::requestCount):
(WebCore::IDBTransaction::requestDeleteRecord):
(WebCore::IDBTransaction::requestClearObjectStore):
(WebCore::IDBTransaction::requestPutOrAdd):
(WebCore::IDBTransaction::deleteObjectStore):
(WebCore::IDBTransaction::deleteIndex):
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::doComplete):
(WebCore::IDBClient::createTransactionOperation): Deleted.
- 8:16 AM Changeset in webkit [240657] by
-
- 2 edits in trunk/Tools
Adding new passing LFC tests.
Unreviewed test gardening.
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 7:53 AM Changeset in webkit [240656] by
-
- 5 edits in trunk
[LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
https://bugs.webkit.org/show_bug.cgi?id=193964
Reviewed by Antti Koivisto.
Source/WebCore:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 6:58 AM Changeset in webkit [240655] by
-
- 2 edits18 adds in trunk/LayoutTests/imported/w3c
Import Resize Observer test cases from WPTs
https://bugs.webkit.org/show_bug.cgi?id=193821
Patch by cathie chen <cathiechen> on 2019-01-29
Reviewed by Frédéric Wang.
- resources/import-expectations.json:
- web-platform-tests/resize-observer/META.yml: Added.
- web-platform-tests/resize-observer/eventloop-expected.txt: Added.
- web-platform-tests/resize-observer/eventloop.html: Added.
- web-platform-tests/resize-observer/idlharness.window-expected.txt: Added.
- web-platform-tests/resize-observer/idlharness.window.html: Added.
- web-platform-tests/resize-observer/idlharness.window.js: Added.
- web-platform-tests/resize-observer/notify-expected.txt: Added.
- web-platform-tests/resize-observer/notify.html: Added.
- web-platform-tests/resize-observer/observe-expected.txt: Added.
- web-platform-tests/resize-observer/observe.html: Added.
- web-platform-tests/resize-observer/resources/iframe.html: Added.
- web-platform-tests/resize-observer/resources/resizeTestHelper.js: Added.
(ResizeTestHelper):
(ResizeTestHelper.prototype.get _currentStep):
(ResizeTestHelper.prototype._nextStep):
(ResizeTestHelper.prototype._handleNotification):
(ResizeTestHelper.prototype._handleTimeout):
(ResizeTestHelper.prototype._done):
(ResizeTestHelper.prototype.start):
(ResizeTestHelper.prototype.get rafCount):
(ResizeTestHelper.prototype._incrementRaf):
(ResizeTestHelper.prototype.startCountingRaf):
- web-platform-tests/resize-observer/resources/w3c-import.log: Added.
- web-platform-tests/resize-observer/svg-expected.txt: Added.
- web-platform-tests/resize-observer/svg.html: Added.
- web-platform-tests/resize-observer/w3c-import.log: Added.
- 6:55 AM Changeset in webkit [240654] by
-
- 6 edits in trunk
[LFC][BFC] Do not ignore next sibling box while laying out BFC.
https://bugs.webkit.org/show_bug.cgi?id=193954
Reviewed by Antti Koivisto.
Source/WebCore:
When a block box has no child (<img style="display: block">), we should not ignore the next sibling (move the container check to the function to keep layout logic simple)
Also inFlowNonReplacedWidthAndMargin() is called through inFlowReplacedWidthAndMargin() to compute margins.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 6:53 AM Changeset in webkit [240653] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] Remove quirk from MarginCollapse::marginsCollapseThrough
https://bugs.webkit.org/show_bug.cgi?id=193948
Reviewed by Antti Koivisto.
This is now implemented in BlockFormattingContext::Quirks::stretchedInFlowHeight().
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough):
- 6:50 AM Changeset in webkit [240652] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] Anonymous block container's margin before does not collapse with previous inflow sibling margin after.
https://bugs.webkit.org/show_bug.cgi?id=193952
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
- 3:00 AM Changeset in webkit [240651] by
-
- 2 edits in trunk/Source/WebCore
Allow scrolling tree nodes to exist in a detached state
https://bugs.webkit.org/show_bug.cgi?id=193754
Unreviewed build warning fix.
Patch by Frederic Wang <fwang@igalia.com> on 2019-01-29
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode): Remove
unused variable.
- 2:41 AM Changeset in webkit [240650] by
-
- 3 edits in trunk/Source/JavaScriptCore
[ARM] Check for negative zero instead of just zero
https://bugs.webkit.org/show_bug.cgi?id=193689
Reviewed by Mark Lam.
ARM now performs a negative zero check in branchConvertDoubleToInt32 instead
of just bailing out for zero.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):
- 2:38 AM Changeset in webkit [240649] by
-
- 5 edits in trunk/Tools
WebDriver: add support for running subtests
https://bugs.webkit.org/show_bug.cgi?id=193904
Reviewed by Michael Catanzaro.
pytest already supports it by passing test.py::subtest, so we can do the same.
- Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(get_item_name): Made this global.
(CollectRecorder.init): Receive the parameter to ignore.
(CollectRecorder.pytest_collectreport): Collect also the subtests.
(TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
(collect): Add parameter to ignore.
- Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
(WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
- Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
(WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
(WebDriverTestRunnerSelenium.run): Ditto.
- Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
(WebDriverTestRunnerW3C.collect_tests): Ditto.
(WebDriverTestRunnerW3C.run): Ditto.
- 2:37 AM Changeset in webkit [240648] by
-
- 2 edits in trunk/Source/WebDriver
WebDriver: POST commands require a valid parameters object
https://bugs.webkit.org/show_bug.cgi?id=193906
Reviewed by Michael Catanzaro.
We are not failing when http body is empty.
Fixes tests: imported/w3c/webdriver/tests/set_window_rect/set.py::test_null_parameter_value
imported/w3c/webdriver/tests/set_timeouts/set.py::test_null_parameter_value
- WebDriverService.cpp:
(WebDriver::WebDriverService::handleRequest):
Jan 28, 2019:
- 11:55 PM Changeset in webkit [240647] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unnecessary promise rejection handlers now that we use the global onunhandledrejection handler
https://bugs.webkit.org/show_bug.cgi?id=193921
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-28
Reviewed by Devin Rousso.
- UserInterface/Base/Utilities.js:
- UserInterface/Debug/UncaughtExceptionReporter.js:
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._exportHAR):
- UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype.updateFormattedState):
- 11:15 PM Changeset in webkit [240646] by
-
- 12 edits in trunk
User agent string override for navigator.userAgent should be site specific quirks
https://bugs.webkit.org/show_bug.cgi?id=193950
Reviewed by Brent Fulgham.
Source/WebCore:
In order to make it possible to toggle the UA string override just for navigator.userAgent via Web Inspector,
we need to put this override behind the site specific quirks. Because WebInspector overrides Page's setting
without updating WKPreferences, there is no way for WKWebView client's to know whether the site specific quirks
had been disabled or not.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setCustomJavaScriptUserAgentAsSiteSpecificQuirks):
(WebCore::DocumentLoader::customJavaScriptUserAgentAsSiteSpecificQuirks const):
(WebCore::DocumentLoader::setCustomJavaScriptUserAgent): Deleted.
(WebCore::DocumentLoader::customJavaScriptUserAgent const): Deleted.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgentForJavaScript const):
Source/WebKit:
Renamed the various member variables, functions, properties and selectors.
- Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
- Shared/WebsitePoliciesData.h:
- UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::data):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setCustomJavaScriptUserAgentAsSiteSpecificQuirks:]): Renamed from setCustomJavaScriptUserAgent.
(-[_WKWebsitePolicies customJavaScriptUserAgentAsSiteSpecificQuirks]): Renamed from customJavaScriptUserAgent.
Tools:
Updated per the _WKWebsitePolicies rename.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
- 10:59 PM Changeset in webkit [240645] by
-
- 5 edits in trunk/Source/WebKit
Unreviewed, rolling out r240630.
https://bugs.webkit.org/show_bug.cgi?id=193958
Broke Apple internal builds (Requested by rniwa on #webkit).
Reverted changeset:
"Add back some includes that got removed at some point."
https://bugs.webkit.org/show_bug.cgi?id=193942
https://trac.webkit.org/changeset/240630
- 10:20 PM Changeset in webkit [240644] by
-
- 26 edits4 adds in trunk
Web Inspector: provide a way to edit page WebRTC settings on a remote target
https://bugs.webkit.org/show_bug.cgi?id=193863
<rdar://problem/47572764>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/Page.json:
Add more values to the
Settingenum type:
ICECandidateFilteringEnabledMediaCaptureRequiresSecureConnectionMockCaptureDevicesEnabled
Source/WebCore:
Test: inspector/page/overrideSetting-ICECandidateFilteringEnabled.html
inspector/page/overrideSetting-MockCaptureDevicesEnabled.html
- inspector/agents/InspectorPageAgent.cpp:
- page/Settings.yaml:
- page/SettingsBase.h:
- page/SettingsBase.cpp:
(SettingsBase::iceCandidateFilteringEnabledChanged): Added.
(SettingsBase::mockCaptureDevicesEnabledChanged): Added.
- Scripts/GenerateSettings.rb:
- Scripts/SettingsTemplates/Settings.cpp.erb:
Add page-level settings for WebRTC preferences.
- Modules/mediastream/UserMediaController.cpp:
(WebCore::UserMediaController::canCallGetUserMedia):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMediaCaptureRequiresSecureConnection):
- testing/Internals.h:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setMockMediaCaptureDevicesEnabled):
(WebCore::Internals::setMediaCaptureRequiresSecureConnection): Added.
- page/DeprecatedGlobalSettings.h:
- page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::mockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setMockCaptureDevicesEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::mediaCaptureRequiresSecureConnection): Deleted.
(WebCore::DeprecatedGlobalSettings::setMediaCaptureRequiresSecureConnection): Deleted.
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.initializeTarget):
(WI._handleDeviceSettingsToolbarButtonClicked):
(WI._handleDeviceSettingsToolbarButtonClicked.createCheckbox):
(WI._handleDeviceSettingsToolbarButtonClicked.createColumns): Deleted.
- UserInterface/Views/Main.css:
(.device-settings-content .container): Added.
- Localizations/en.lproj/localizedStrings.js:
Source/WebKit:
- Shared/WebPreferences.yaml:
Add page-level settings for WebRTC preferences.
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Add page-level settings for WebRTC preferences.
LayoutTests:
- inspector/page/overrideSetting-ICECandidateFilteringEnabled.html: Added.
- inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt: Added.
- inspector/page/overrideSetting-MockCaptureDevicesEnabled.html: Added.
- inspector/page/overrideSetting-MockCaptureDevicesEnabled-expected.txt: Added.
- platform/mac/TestExpectations:
- 10:11 PM Changeset in webkit [240643] by
-
- 3 edits in trunk/Source/WebCore
webkitcurrentplaybacktargetiswirelesschanged and webkitCurrentPlaybackIsWireless are non-deterministic.
https://bugs.webkit.org/show_bug.cgi?id=193923
<rdar://problem/45956595>
Reviewed by Eric Carlson.
The value of webkitCurrentPlaybackTargetIsWireless can change in between when the event is scheduled
and when it's actually dispatched. To make this more deterministic, use a GenericTaskQueue to enqueue
setting m_isPlayingToWirelessTarget and dispatch the changed event in the same run-loop.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):
(WebCore::HTMLMediaElement::setIsPlayingToWirelessTarget):
(WebCore::HTMLMediaElement::dispatchEvent):
- html/HTMLMediaElement.h:
- 10:01 PM Changeset in webkit [240642] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r240553): Crash in WebCore::ScrollingTree::updateTreeFromStateNode
https://bugs.webkit.org/show_bug.cgi?id=193955
Unreviewed test gardening.
- platform/ios/TestExpectations: Skip crashing test to unblock EWS.
- 10:00 PM Changeset in webkit [240641] by
-
- 77 edits in trunk
Remove unnecessary
using namespace WTFs (or at least restrict their scope).
https://bugs.webkit.org/show_bug.cgi?id=193941
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- API/JSWeakObjectMapRefPrivate.cpp:
- bytecompiler/NodesCodegen.cpp:
- heap/MachineStackMarker.cpp:
- jit/ExecutableAllocator.cpp:
- jsc.cpp:
- parser/Nodes.cpp:
- runtime/DateConstructor.cpp:
- runtime/DateConversion.cpp:
- runtime/DateInstance.cpp:
- runtime/DatePrototype.cpp:
- runtime/InitializeThreading.cpp:
- runtime/IteratorOperations.cpp:
- runtime/JSDateMath.cpp:
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/StringPrototype.cpp:
- runtime/VM.cpp:
- testRegExp.cpp:
- tools/JSDollarVM.cpp:
- yarr/YarrInterpreter.cpp:
- yarr/YarrJIT.cpp:
- yarr/YarrPattern.cpp:
- yarr/YarrUnicodeProperties.cpp:
Source/WebCore:
- css/CSSBasicShapes.cpp:
- css/CSSPrimitiveValue.cpp:
- css/parser/CSSParser.cpp:
- css/parser/CSSParserSelector.cpp:
- css/parser/CSSPropertyParser.cpp:
- dom/Document.cpp:
- dom/EventListenerMap.cpp:
- dom/EventTarget.cpp:
- editing/Editor.cpp:
- html/HTMLElement.cpp:
- html/HTMLFontElement.cpp:
- html/parser/HTMLTokenizer.cpp:
- html/track/TrackBase.cpp:
- loader/FTPDirectoryParser.cpp:
- loader/TextResourceDecoder.cpp:
- loader/cache/CachedResource.cpp:
- page/ContextMenuController.cpp:
- page/Navigator.cpp:
- platform/Length.cpp:
- platform/cocoa/KeyEventCocoa.mm:
- platform/graphics/FontCascade.cpp:
- platform/graphics/WidthIterator.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/ios/KeyEventIOS.mm:
- platform/mac/KeyEventMac.mm:
- platform/network/HTTPParsers.cpp:
- platform/text/TextCodecUTF8.cpp:
- platform/text/TextEncodingRegistry.cpp:
- platform/win/KeyEventWin.cpp:
- rendering/BidiRun.cpp:
- rendering/FloatingObjects.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderText.cpp:
Source/WebKit:
- Shared/linux/WebMemorySamplerLinux.cpp:
Source/WebKitLegacy/win:
- Plugins/PluginMessageThrottlerWin.cpp:
- Plugins/PluginView.cpp:
- Plugins/PluginViewWin.cpp:
Tools:
- TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
- TestWebKitAPI/Tests/WTF/Condition.cpp:
- TestWebKitAPI/Tests/WTF/Lock.cpp:
- TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
- TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
- TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
- TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
- TestWebKitAPI/Tests/WTF/Time.cpp:
- TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
- TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
- TestWebKitAPI/Tests/WebCore/Logging.cpp:
- WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
- 9:58 PM Changeset in webkit [240640] by
-
- 19 edits2 moves in trunk/Source
[Win] WebCore/platform/Process.h is conflicting with process.h
https://bugs.webkit.org/show_bug.cgi?id=193944
Reviewed by Ross Kirsling.
Source/WebCore:
Windows has process.h. Rename Process.h to ProcessIdentifier.h.
No new tests because there is no behavior change.
- Sources.txt:
- UnifiedSources-input.xcfilelist:
- WebCore.xcodeproj/project.pbxproj:
- dom/MessagePortIdentifier.h:
- dom/messageports/MessagePortChannel.h:
- dom/messageports/MessagePortChannelProvider.h:
- dom/messageports/MessagePortChannelRegistry.h:
- history/BackForwardItemIdentifier.h:
- page/GlobalWindowIdentifier.h:
- platform/ProcessIdentifier.cpp: Renamed from Source/WebCore/platform/Process.cpp.
(WebCore::Process::setIdentifier):
(WebCore::Process::identifier):
- platform/ProcessIdentifier.h: Renamed from Source/WebCore/platform/Process.h.
Source/WebKit:
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
- Shared/unix/ChildProcessMain.cpp:
- UIProcess/API/APINavigation.h:
- UIProcess/ChildProcessProxy.h:
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/WebProcessPool.cpp:
- UIProcess/WebProcessProxy.h:
- 9:21 PM Changeset in webkit [240639] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements tab should toggle visibility for all selected nodes
https://bugs.webkit.org/show_bug.cgi?id=193089
<rdar://problem/47009256>
Reviewed by Devin Rousso.
Update "Toggle Visibility" command in DOM tree for multiple selection.
When both visible and hidden elements are selected in the DOM tree,
the toggle command behaves contextually. If one or more elements are
visible, they are hidden, otherwise they are shown. The context menu
shows "Hide Elements" or "Show Elements", respectively.
When only one element is selected, or the context menu target element
is not selected, the command continues to be "Toggle Visibility".
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.get isNodeHidden): Added.
(WI.DOMTreeElement.prototype.toggleElementVisibility.inspectedPage_node_injectStyleAndToggleClass):
(WI.DOMTreeElement.prototype.toggleElementVisibility):
(WI.DOMTreeElement.prototype._populateTagContextMenu):
- UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.toggleSelectedElementsVisibility): Added.
Provide a public method for toggling the visibility of selected DOM nodes.
Used by the "H" keyboard shortcut and DOMTreeElement context menu.
(WI.DOMTreeOutline.prototype._hideElements):
(WI.DOMTreeOutline.prototype._hideElement): Deleted.
Rename for multiple selection.
- 8:49 PM Changeset in webkit [240638] by
-
- 2 edits in trunk/Tools
Unreviewed, reorder my emails to fix autocomplete in bugzilla
- Scripts/webkitpy/common/config/contributors.json:
- 8:33 PM Changeset in webkit [240637] by
-
- 15 edits in trunk/Source/JavaScriptCore
[JSC] Reduce size of memory used for ShadowChicken
https://bugs.webkit.org/show_bug.cgi?id=193546
Reviewed by Mark Lam.
This patch lazily instantiate ShadowChicken. We do not need this until we start logging ShadowChicken packets.
The removal of ShadowChicken saves 55KB memory.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::create):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):
- heap/Heap.cpp:
(JSC::Heap::stopThePeriphery):
(JSC::Heap::addCoreConstraints):
- jit/CCallHelpers.cpp:
(JSC::CCallHelpers::ensureShadowChickenPacket):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::setDebugger):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::setDebugger): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::ensureShadowChicken):
- runtime/VM.h:
(JSC::VM::shadowChicken):
- tools/JSDollarVM.cpp:
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::changeDebuggerModeWhenIdle):
- 8:00 PM Changeset in webkit [240636] by
-
- 9 edits9 moves in trunk/Source/WTF
Move platform-specific files out of WTF root directory.
https://bugs.webkit.org/show_bug.cgi?id=193929
Reviewed by Alex Christensen.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/PlatformGTK.cmake:
- wtf/PlatformJSCOnly.cmake:
- wtf/PlatformMac.cmake:
- wtf/PlatformPlayStation.cmake:
- wtf/PlatformWPE.cmake:
- wtf/PlatformWin.cmake:
- wtf/cf/RunLoopTimerCF.cpp: Renamed from Source/WTF/wtf/RunLoopTimerCF.cpp.
- wtf/cf/SchedulePairCF.cpp: Renamed from Source/WTF/wtf/SchedulePairCF.cpp.
- wtf/mac/SchedulePairMac.mm: Renamed from Source/WTF/wtf/SchedulePairMac.mm.
- wtf/posix/OSAllocatorPOSIX.cpp: Renamed from Source/WTF/wtf/OSAllocatorPosix.cpp.
- wtf/posix/ThreadingPOSIX.cpp: Renamed from Source/WTF/wtf/ThreadingPthreads.cpp.
- wtf/win/CONTRIBUTORS.pthreads-win32: Renamed from Source/WTF/wtf/CONTRIBUTORS.pthreads-win32.
- wtf/win/OSAllocatorWin.cpp: Renamed from Source/WTF/wtf/OSAllocatorWin.cpp.
- wtf/win/ThreadSpecificWin.cpp: Renamed from Source/WTF/wtf/ThreadSpecificWin.cpp.
- wtf/win/ThreadingWin.cpp: Renamed from Source/WTF/wtf/ThreadingWin.cpp.
- 7:36 PM Changeset in webkit [240635] by
-
- 2 edits in trunk/Source/WebKit
Update Screen Capture preference
https://bugs.webkit.org/show_bug.cgi?id=193947
rdar://problem/47620199
Reviewed by Youenn Fablet.
- Shared/WebPreferences.yaml:
- 7:15 PM Changeset in webkit [240634] by
-
- 13 edits12 adds in trunk
Implement capture for Pointer Events on iOS
https://bugs.webkit.org/show_bug.cgi?id=193917
<rdar://problem/47605689>
Reviewed by Dean Jackson.
Source/WebCore:
We add a new PointerCaptureController object which gets notified upon dispatch of pointer events
to implement implicit pointer capture, dispatch the gotpointercapture and lostpointercaptiure events,
and implement the Element APIs for pointer capture: hasPointerCapture(), setPointerCapture() and
releasePointerCapture().
Tests: pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down.html
pointerevents/ios/pointer-events-implicit-capture-release-exception.html
pointerevents/ios/pointer-events-implicit-capture-release.html
pointerevents/ios/pointer-events-implicit-capture.html
pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::setPointerCapture):
(WebCore::Element::releasePointerCapture):
(WebCore::Element::hasPointerCapture):
- dom/Element.h:
- dom/Element.idl:
- dom/EventNames.h:
- dom/PointerEvent.h:
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::pointerCaptureController const):
- page/PointerCaptureController.cpp: Added.
(WebCore::PointerCaptureController::PointerCaptureController):
(WebCore::PointerCaptureController::setPointerCapture):
(WebCore::PointerCaptureController::releasePointerCapture):
(WebCore::PointerCaptureController::hasPointerCapture):
(WebCore::PointerCaptureController::pointerLockWasApplied):
(WebCore::PointerCaptureController::touchEndedOrWasCancelledForIdentifier):
(WebCore::PointerCaptureController::pointerEventWillBeDispatched):
(WebCore::PointerCaptureController::pointerEventWasDispatched):
(WebCore::PointerCaptureController::processPendingPointerCapture):
- page/PointerCaptureController.h: Added.
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
- page/PointerLockController.h:
LayoutTests:
New tests for implicit pointer capture and the Element APIs related to pointer capture.
- pointerevents/ios/pointer-events-implicit-capture-expected.txt: Added.
- pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down-expected.txt: Added.
- pointerevents/ios/pointer-events-implicit-capture-has-pointer-capture-in-pointer-down.html: Added.
- pointerevents/ios/pointer-events-implicit-capture-release-exception-expected.txt: Added.
- pointerevents/ios/pointer-events-implicit-capture-release-exception.html: Added.
- pointerevents/ios/pointer-events-implicit-capture-release-expected.txt: Added.
- pointerevents/ios/pointer-events-implicit-capture-release.html: Added.
- pointerevents/ios/pointer-events-implicit-capture.html: Added.
- pointerevents/ios/pointer-events-set-pointer-capture-exceptions-expected.txt: Added.
- pointerevents/ios/pointer-events-set-pointer-capture-exceptions.html: Added.
- 7:06 PM Scrolling edited by
- (diff)
- 6:59 PM Changeset in webkit [240633] by
-
- 14 edits in trunk
[watchOS] Enable Parental Controls content filtering
https://bugs.webkit.org/show_bug.cgi?id=193939
<rdar://problem/46641912>
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 6:03 PM Changeset in webkit [240632] by
-
- 6 edits1 copy1 add in trunk
Produce "pen" Pointer Events if using a stylus (e.g. Apple Pencil)
https://bugs.webkit.org/show_bug.cgi?id=193945
<rdar://problem/47618922>
Reviewed by Antoine Quint.
Source/WebCore:
Calculate the pressure, tiltX and tiltY values for incoming
Pointer Events, which have values when the PlatformTouchEvent
originated from a stylus.
Test: pointerevents/ios/pointer-events-dispatch-on-stylus.html
- dom/PointerEvent.h: Default to "mouse".
- dom/ios/PointerEventIOS.cpp: Calculate the values.
LayoutTests:
Test for stylus -> "pen" Pointer Events.
- pointerevents/ios/pointer-events-dispatch-on-stylus-expected.txt: Added.
- pointerevents/ios/pointer-events-dispatch-on-stylus.html: Added.
- pointerevents/ios/pointer-events-dispatch-on-touch.html: Test for "touch" type.
- pointerevents/utils.js: Add a new helper for stylus event generation.
(prototype.assertMatchesEvents):
(const.ui.new.UIController.prototype.beginStylus):
- 5:58 PM Changeset in webkit [240631] by
-
- 7 edits1 copy in trunk
REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
<https://webkit.org/b/193884>
Reviewed by Jiewen Tan.
Source/WebKit:
- SourcesCocoa.txt:
- UnifiedSources-input.xcfilelist:
- WebKit.xcodeproj/project.pbxproj:
- Add LocalAuthenticationSoftLink.mm to the project.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.h:
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.mm: Copied from Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticationSoftLink.h.
- Move soft-linking implementation to LocalAuthenticationSoftLink.mm.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_language): Add LocalAuthentication to
frameworks_with_soft_links.
- 5:56 PM Changeset in webkit [240630] by
-
- 5 edits in trunk/Source/WebKit
Add back some includes that got removed at some point.
https://bugs.webkit.org/show_bug.cgi?id=193942
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
- 5:53 PM Changeset in webkit [240629] by
-
- 2 edits in trunk/JSTests
Unreviewed, fix the test after r240543 not to use @Error / Error in builtins
https://bugs.webkit.org/show_bug.cgi?id=193713
- stress/try-get-by-id-should-spill-registers-dfg.js:
(let.f.createBuiltin):
- 5:51 PM Changeset in webkit [240628] by
-
- 17 edits in trunk/Source
Make it easier for non-Apple ports to enable dark mode CSS support.
https://bugs.webkit.org/show_bug.cgi?id=193882
Reviewed by Megan Gardner.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::updateBackgroundRecursively): Limit use of system
background color to the Mac platform.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::purgeCaches): Purge m_darkColorCache.
(WebCore::RenderTheme::platformColorsDidChange): Reset m_darkColorCache.
(WebCore::RenderTheme::colorCache const): Added m_darkColorCache.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::colorCache const): Deleted.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::purgeCaches): Removed m_darkColorCache.
(WebCore::RenderThemeMac::platformColorsDidChange): Deleted.
(WebCore::RenderThemeMac::colorCache const): Deleted.
Source/WebKit:
Make modern WebKit code for dark mode usable by other ports, to match
the WebCore parts that have been cross-platform all along.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/PageClient.h:
(WebKit::PageClient::effectiveAppearanceIsDark const):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::effectiveAppearanceDidChange):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldAttachDrawingAreaOnPageTransition):
(WebKit::WebPage::setUseDarkAppearance):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
(-[WebView _effectiveAppearanceIsDark]): Ditto.
- 5:38 PM Changeset in webkit [240627] by
-
- 1 copy in tags/Safari-607.1.29
Tag Safari-607.1.29.
- 5:14 PM Changeset in webkit [240626] by
-
- 2 edits in tags/Safari-608.1.3/Source/WebKit
Cherry-pick r240620. rdar://problem/47614992
REGRESSION (r240348): Loading netflix home page panics device
https://bugs.webkit.org/show_bug.cgi?id=193936
Reviewed by Alexey Proskuryakov.
Temporarily enable permissive call filtering.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:14 PM Changeset in webkit [240625] by
-
- 4 edits in tags/Safari-608.1.3
Cherry-pick r240599. rdar://problem/47560907
Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>
Reviewed by Alex Christensen.
Source/WebKit:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving IPC after this or even worse, commit the provisional page.
(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:12 PM Changeset in webkit [240624] by
-
- 3 edits in trunk/Source/WebKit
[Cocoa] Add SPI to _WKUserContentExtensionStore to retrieve its underlying WKContentRuleListStore
https://bugs.webkit.org/show_bug.cgi?id=193927
Reviewed by Tim Horton.
This is useful for clients migrating from _WKUserContentExtensionStore to the modern
WKContentRuleList* APIs.
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(-[_WKUserContentExtensionStore _contentRuleListStore]):
- UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
- 5:07 PM Changeset in webkit [240623] by
-
- 7 edits in tags/Safari-608.1.3/Source
Versioning.
- 4:59 PM Changeset in webkit [240622] by
-
- 2 edits in trunk/Tools
[Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
https://bugs.webkit.org/show_bug.cgi?id=193891
Reviewed by Ross Kirsling.
There were three problems in window sizes of WebView and the host window.
- The sizes of pixel image output were incorrect.
- The host window is going to appear after window.resize was invoked.
- window.resize resized only the host window, not WebView.
This change solves them with a following approach.
- PlatformWebView::PlatformWebView creates the initial host window as zero size.
- Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP as well as DumpRenderTree in order to match the client area and the window area.
- PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
- PlatformWebView::setWindowFrame changes both window sizes.
- PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
- WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView): Create the host window
and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
(WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
(WTR::PlatformWebView::setWindowFrame): Change both window sizes.
- 4:58 PM Changeset in webkit [240621] by
-
- 3 edits in trunk/Source/WebKit
Move soft-linking of ManagedConfiguration.framework out of ManagedConfigurationSPI.h
<https://webkit.org/b/193868>
Reviewed by Daniel Bates.
- Platform/spi/ios/ManagedConfigurationSPI.h:
- Remove soft-linking code from header.
- Add PLATFORM(IOS_FAMILY) && !PLATFORM(IOSMAC) guard.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):
- Add soft-linking code formerly in ManagedConfigurationSPI.h.
- Change MCFeatureDefinitionLookupAllowed to use soft-link function getMCFeatureDefinitionLookupAllowed() to remove the #define.
- 4:55 PM Changeset in webkit [240620] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r240348): Loading netflix home page panics device
https://bugs.webkit.org/show_bug.cgi?id=193936
Reviewed by Alexey Proskuryakov.
Temporarily enable permissive call filtering.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:54 PM Changeset in webkit [240619] by
-
- 1 copy in tags/Safari-608.1.3
Tag Safari-608.1.3.
- 4:52 PM Changeset in webkit [240618] by
-
- 7 edits in trunk/Source
Versioning.
- 4:46 PM Changeset in webkit [240617] by
-
- 1 delete in tags/Safari-608.1.3
Delete tag.
- 4:41 PM Changeset in webkit [240616] by
-
- 3 edits3 adds in trunk
ToString node actually does GC.
https://bugs.webkit.org/show_bug.cgi?id=193920
<rdar://problem/46695900>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/dfg-to-string-on-int-does-gc.js: Added.
- stress/dfg-to-string-on-string-object-does-not-gc.js: Added.
- stress/dfg-to-string-on-string-or-string-object-does-not-gc.js: Added.
Source/JavaScriptCore:
Other than for StringObjectUse and StringOrStringObjectUse, ToString and
CallStringConstructor can allocate new JSStrings, and hence, can GC.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- 4:37 PM Changeset in webkit [240615] by
-
- 7 edits in tags/Safari-608.1.3/Source
Versioning.
- 4:24 PM Changeset in webkit [240614] by
-
- 1 delete in tags/Safari-608.1.3.1
Delete tag.
- 4:21 PM Changeset in webkit [240613] by
-
- 1 copy in tags/Safari-608.1.3.1
New tag.
- 4:21 PM Changeset in webkit [240612] by
-
- 1 copy in tags/Safari-608.1.3
Tag Safari-608.1.3.
- 4:19 PM Changeset in webkit [240611] by
-
- 1 delete in tags/Safari-608.1.3
Delete tag.
- 4:15 PM Changeset in webkit [240610] by
-
- 3 edits in trunk/Source/WebCore
svg/text/select-text-inside-non-static-position.html crashes under ScrollingStateTree::unparentChildrenAndDestroyNode()
https://bugs.webkit.org/show_bug.cgi?id=193930
Reviewed by Tim Horton.
ScrollingStateTree::unparentChildrenAndDestroyNode() should make a copy of the 'children' vector
before iterating, since iteration mutates the array.
Tested by ASan tests.
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::takeChildren):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
- 4:14 PM Changeset in webkit [240609] by
-
- 2 edits in trunk/Source/WebCore
css3/filters/blur-filter-page-scroll-self.html crashes under WebCore::ScrollingStateNode::ScrollingStateNode
https://bugs.webkit.org/show_bug.cgi?id=193925
Reviewed by Tim Horton.
Some css3/filters/ tests disable accelerated compositing (which is crazy). Make these
tests not crash by ensuring that unparentNode() and unparentChildrenAndDestroyNode() clears the root
node if it's the node being unparented or destroyed.
Tested by existing tests.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::unparentNode):
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
- 4:12 PM Changeset in webkit [240608] by
-
- 1 copy in tags/Safari-608.1.3
Tag Safari-608.1.3.
- 3:21 PM Changeset in webkit [240607] by
-
- 7 edits in trunk/Source
Versioning.
- 3:18 PM Changeset in webkit [240606] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Attempting to open a Keynote document to iCloud.com from iCloud Files causes crash
https://bugs.webkit.org/show_bug.cgi?id=193456
<rdar://problem/47275642>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-28
Reviewed by Brent Fulgham.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
Allow access to iconservices.
- 3:07 PM Changeset in webkit [240605] by
-
- 2 edits in trunk/Tools
[ews-app] Add method to save Step data to database
https://bugs.webkit.org/show_bug.cgi?id=193890
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/models/step.py:
(Step.save_step): Method to save step data.
(Step.update_step): Method to update step data.
(Step.get_existing_step): Method to fetch existing step from database.
(Step.is_valid_result): Method to validate valid step result.
- 3:00 PM Changeset in webkit [240604] by
-
- 6 edits4 adds in trunk
[iOS] Make Window virtual key code computation match Mac
https://bugs.webkit.org/show_bug.cgi?id=193452
Reviewed by Ryosuke Niwa.
Source/WebCore:
Use the same approach for computing the Windows virtual key code on iOS as we do on Mac for
web compatibility. On Mac, we prefer to compute the Windows virtual key code from the input
strings of the key event and use the key event's keycode as a last resort.
Test: fast/events/ios/key-events-meta-alt-combinations.html
- platform/ios/PlatformEventFactoryIOS.h:
- platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::isKeypadEvent): Added.
(WebCore::windowsKeyCodeForKeyEvent): Added.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder): Modified to call
WebCore::windowsKeyCodeForKeyEvent() to compute the Windows virtual key code.
Source/WebKit:
Compute the Windows virtual key code from the WebEvent.
- Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebKeyboardEvent):
LayoutTests:
Add a test that ensures we do not regress DOM key events dispatches for combinations
of Option and Command + Option key commands.
- fast/events/ios/key-events-meta-alt-combinations-expected.txt: Added.
- fast/events/ios/key-events-meta-alt-combinations.html: Added.
- fast/events/ios/resources/key-tester.js: Added.
(computeDifference):
(areArraysEqual):
(areKeyCommandsEqual):
(KeyCommand):
(KeyCommand.prototype.toString):
(keyCommandsHasCommand):
(computeSubsets.compareByModifierOrder):
(handleKeyUp):
(handleKeyPress):
(log):
(logKeyEvent):
(displayNameForTest):
(nextKeyPress):
(runTest):
(setUp):
- 3:00 PM Changeset in webkit [240603] by
-
- 3 edits in trunk/Tools
[ews-app] Add method to save Build data to database
https://bugs.webkit.org/show_bug.cgi?id=193735
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/models/build.py:
(Build.save_build): Method to save build information to database.
(Build.get_existing_build): Method to fetch existing build from database.
(Build.is_valid_result): Method to validate build result.
- BuildSlaveSupport/ews-app/ews/common/util.py:
(is_valid_int_id): Method to validate valid id.
- 2:34 PM Changeset in webkit [240602] by
-
- 4 edits in trunk/Source/WebKit
REGRESSION (r240498): Storage Access API prompts result is not remembered
https://bugs.webkit.org/show_bug.cgi?id=193922
<rdar://problem/47608767>
Reviewed by Chris Dumez.
The refactoring in r240498 bypassed bookkeeping in ResourceLoadStatisticsMemoryStore
that kept track of whether a successful user prompt had been encountered. This
patch corrects this codepath so the user is not prompted repeatedly after approving
use of the Storage Access API.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess): Switch from Move operator to
const reference to allow the method to be called by the NetworkProcess.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::grantStorageAccess): Request access through the WebResourceLoadStatistics
object, rather than jumping directly to the NetworkStorageSession.
- 2:12 PM Changeset in webkit [240601] by
-
- 4 edits in branches/safari-607-branch
Cherry-pick r240599. rdar://problem/47609799
Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>
Reviewed by Alex Christensen.
Source/WebKit:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving IPC after this or even worse, commit the provisional page.
(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:35 PM Changeset in webkit [240600] by
-
- 5 edits in trunk/Source/WTF
[JSCOnly][WTF] Expose FileSystem.
https://bugs.webkit.org/show_bug.cgi?id=193789
Reviewed by Don Olmstead.
- wtf/FileSystem.h:
- wtf/PlatformJSCOnly.cmake:
- wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::getVolumeFreeSpace):
- wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::fileSystemRepresentation):
- 1:19 PM Changeset in webkit [240599] by
-
- 4 edits in trunk
Regression(PSON) Crash under WebPageProxy::didStartProgress()
https://bugs.webkit.org/show_bug.cgi?id=193915
<rdar://problem/47560907>
Reviewed by Alex Christensen.
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
Make sure we destroy the ProvisionalPageProxy if the page gets closed as we do not want to keep receiving
IPC after this or even worse, commit the provisional page.
(WebKit::WebPageProxy::didStartProgress):
Add an assertion in didStartProgress() to make sure we do not receive this IPC after the page has been
closed.
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 12:21 PM Changeset in webkit [240598] by
-
- 2 edits in trunk/Source/WebInspectorUI
Unreviewed, rolling out r240351.
https://bugs.webkit.org/show_bug.cgi?id=193918
Causes overlapping Timeline records, as some record types
don't have an endTime (Requested by drousso on #webkit).
Reverted changeset:
"WebInspector: Confusingly nested events in the timeline for
Mutation Observers"
https://bugs.webkit.org/show_bug.cgi?id=192884
https://trac.webkit.org/changeset/240351
- 12:08 PM Changeset in webkit [240597] by
-
- 8 edits in trunk/Tools
[ews-app] Rename id variables
https://bugs.webkit.org/show_bug.cgi?id=193883
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/models/build.py:
- BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
- BuildSlaveSupport/ews-app/ews/models/step.py:
- BuildSlaveSupport/ews-app/ews/urls.py:
- BuildSlaveSupport/ews-app/ews/views/patch.py:
- BuildSlaveSupport/ews-app/ews/views/results.py:
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
- 11:58 AM Changeset in webkit [240596] by
-
- 2 edits in trunk/Source/WebCore
Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447
Unreviewed build fix.
- dom/Element.cpp:
(WebCore::parentCrossingFrameBoundaries):
- 11:54 AM Changeset in webkit [240595] by
-
- 3 edits in trunk/Tools
[ews-app] Allow certain fields to be empty
https://bugs.webkit.org/show_bug.cgi?id=193892
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/models/build.py:
- BuildSlaveSupport/ews-app/ews/models/step.py:
- 11:53 AM Changeset in webkit [240594] by
-
- 3 edits in trunk/Source/WebInspectorUI
REGRESSION(?): Web Inspector: Can have multiple Timelines selected after edit mode
https://bugs.webkit.org/show_bug.cgi?id=193808
<rdar://problem/47537734>
Reviewed by Devin Rousso.
- UserInterface/Controllers/SelectionController.js:
(WI.SelectionController.prototype.didRemoveItems):
- UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._indexesForSubtree):
Fix a bug where no IndexSet was returned when passed a TreeElement with
no children. This caused the Timelines tree selection to be corrupted when
entering and exiting edit mode, as TreeElements are inserted and removed.
- 11:52 AM Changeset in webkit [240593] by
-
- 25 edits3 adds in trunk/Source/JavaScriptCore
[JSC] RegExpConstructor should not have own IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=193801
Reviewed by Mark Lam.
This patch finally removes RegExpConstructor's cached data to JSGlobalObject and remove IsoSubspace for RegExpConstructor.
sizeof(RegExpConstructor) != sizeof(InternalFunction), so that we have 16KB memory just for RegExpConstructor. But cached
regexp matching data (e.g.RegExp.$1) is per-JSGlobalObject one, and we can move this data to JSGlobalObject and remove
it from RegExpConstructor members.
We introduce RegExpGlobalData, which holds the per-global RegExp matching data. And we perform
performMatchetc. with
JSGlobalObject instead of RegExpConstructor. This change requires small changes in DFG / FTL's RecordRegExpCachedResult
node since its 1st argument is changed from RegExpConstructor to JSGlobalObject.
We also move emptyRegExp from RegExpPrototype to VM's RegExpCache because it is more natural place to put it.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileRecordRegExpCachedResult):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileRecordRegExpCachedResult):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::regExpGlobalData):
(JSC::JSGlobalObject::regExpGlobalDataOffset):
(JSC::JSGlobalObject::regExpConstructor const): Deleted.
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::initialize):
- runtime/RegExpCache.h:
(JSC::RegExpCache::emptyRegExp const):
- runtime/RegExpCachedResult.cpp:
(JSC::RegExpCachedResult::visitAggregate):
(JSC::RegExpCachedResult::visitChildren): Deleted.
- runtime/RegExpCachedResult.h:
(JSC::RegExpCachedResult::RegExpCachedResult): Deleted.
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::regExpConstructorDollar):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):
(JSC::RegExpConstructor::destroy): Deleted.
(JSC::RegExpConstructor::visitChildren): Deleted.
(JSC::RegExpConstructor::getBackref): Deleted.
(JSC::RegExpConstructor::getLastParen): Deleted.
(JSC::RegExpConstructor::getLeftContext): Deleted.
(JSC::RegExpConstructor::getRightContext): Deleted.
- runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::performMatch): Deleted.
(JSC::RegExpConstructor::recordMatch): Deleted.
- runtime/RegExpGlobalData.cpp: Added.
(JSC::RegExpGlobalData::visitAggregate):
(JSC::RegExpGlobalData::getBackref):
(JSC::RegExpGlobalData::getLastParen):
(JSC::RegExpGlobalData::getLeftContext):
(JSC::RegExpGlobalData::getRightContext):
- runtime/RegExpGlobalData.h: Added.
(JSC::RegExpGlobalData::cachedResult):
(JSC::RegExpGlobalData::setMultiline):
(JSC::RegExpGlobalData::multiline const):
(JSC::RegExpGlobalData::input):
(JSC::RegExpGlobalData::offsetOfCachedResult):
- runtime/RegExpGlobalDataInlines.h: Added.
(JSC::RegExpGlobalData::setInput):
(JSC::RegExpGlobalData::performMatch):
(JSC::RegExpGlobalData::recordMatch):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::matchGlobal):
- runtime/RegExpObjectInlines.h:
(JSC::RegExpObject::execInline):
(JSC::RegExpObject::matchInline):
(JSC::collectMatches):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
(JSC::regExpProtoFuncSearchFast):
(JSC::RegExpPrototype::visitChildren): Deleted.
- runtime/RegExpPrototype.h:
- runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 11:19 AM Changeset in webkit [240592] by
-
- 15 edits in trunk/Source
AVStreamSession isn't always available, make a HAVE compile flag for it
https://bugs.webkit.org/show_bug.cgi?id=193889
<rdar://problem/47452863>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, no functional change.
- page/Settings.yaml:
- page/SettingsBase.cpp:
(WebCore::SettingsBase::platformDefaultMediaSourceEnabled):
- page/SettingsBase.h:
- page/cocoa/SettingsBaseCocoa.mm:
(WebCore::SettingsBase::platformDefaultMediaSourceEnabled):
- platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::createSession):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): Fix logging.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
Use a HashMap to associate CMSampleBuffer with SourceBufferPrivateAVFObjC.
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]): isEqualTo
-> isEqualToString.
(WebCore::sourceBufferMap):
(WebCore::nextMapID):
(WebCore::bufferWasConsumedCallback):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::willProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::layerDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::bufferWasConsumed):
(-[WebBufferConsumedContext initWithParent:]): Deleted.
(-[WebBufferConsumedContext parent]): Deleted.
Source/WTF:
- wtf/FeatureDefines.h:
- 11:11 AM Changeset in webkit [240591] by
-
- 6 edits in trunk
Update MIME type parser
https://bugs.webkit.org/show_bug.cgi?id=180526
Patch by Rob Buis <rbuis@igalia.com> on 2019-01-28
Reviewed by Frédéric Wang.
LayoutTests/imported/w3c:
Update improved test expectations.
- web-platform-tests/xhr/overridemimetype-blob-expected.txt:
Source/WebCore:
I overlooked step 11.9.3 [1], for Mimesniff we should not
bail out on missing subtype, but keep trying. Note
that Rfc2045 does require bailing out, as before.
Test: ParsedContentType unittest
[1] https://mimesniff.spec.whatwg.org/#parse-a-mime-type
- platform/network/ParsedContentType.cpp:
(WebCore::parseToken):
(WebCore::parseContentType):
Tools:
- TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
(TestWebKitAPI::TEST):
- 11:09 AM Changeset in webkit [240590] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow-up to r240557, restore a call to makeString
https://bugs.webkit.org/show_bug.cgi?id=192742
<rdar://problem/46757369>
It works if we add this #include that was missing. I got confused by the error messages and
missed that there were two similarly-named headers.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
- 10:35 AM Changeset in webkit [240589] by
-
- 2 edits in trunk/Source/WebKit
Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447
Unreviewed build fix.
- UIProcess/API/Cocoa/WKWebView.mm:
- 9:44 AM Changeset in webkit [240588] by
-
- 4 edits21 adds in trunk
[css-logical] Reject unitless length quirk in 'inset' shorthand
https://bugs.webkit.org/show_bug.cgi?id=193773
Patch by Oriol Brufau <Oriol Brufau> on 2019-01-28
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Import WPT tests that check that the unitless length quirk is not
allowed in the 'inset' shorthand.
- resources/import-expectations.json:
- web-platform-tests/quirks/support/test-ref-iframe.js: Added.
(setupIframe):
- web-platform-tests/quirks/support/w3c-import.log: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-001.html: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-002.html: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-003-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/excluded-properties-003.html: Added.
- web-platform-tests/quirks/unitless-length/limited-quirks-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/limited-quirks.html: Added.
- web-platform-tests/quirks/unitless-length/no-quirks-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/no-quirks.html: Added.
- web-platform-tests/quirks/unitless-length/quirks-expected.txt: Added.
- web-platform-tests/quirks/unitless-length/quirks.html: Added.
- web-platform-tests/quirks/unitless-length/support/common.js: Added.
(onload):
- web-platform-tests/quirks/unitless-length/support/w3c-import.log: Added.
- web-platform-tests/quirks/unitless-length/w3c-import.log: Added.
Source/WebCore:
Even though its longhands ('top', 'right', 'bottom', 'left') accept the
unitless length quirk, the 'inset' shorthand is a new CSS property and
should reject it. This was resolved by the CSS WG in
https://github.com/w3c/csswg-drafts/issues/3525#issuecomment-456902648
Tests: imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001.html
imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002.html
imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-003.html
imported/w3c/web-platform-tests/quirks/unitless-length/limited-quirks.html
imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html
imported/w3c/web-platform-tests/quirks/unitless-length/quirks.html
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
- 9:33 AM Changeset in webkit [240587] by
-
- 2 edits in trunk/Source/WebKit
Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447
Unreviewed build fix.
- UIProcess/ios/WKContentViewInteraction.mm:
- 9:29 AM Changeset in webkit [240586] by
-
- 8 edits in trunk/Source/WebKit
Remove the UIProcess components of the ResourceLoadStatistics code
https://bugs.webkit.org/show_bug.cgi?id=193303
<rdar://problem/47160073>
Reviewed by Chris Dumez.
Now that the ResourceLoadStatistics code is running in the NetworkProcess, we can get rid
of the UIProcess copies of these routines.
Tested by existing ResourceLoadStatistics and StorageAccess tests.
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler):
(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler):
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler):
(WebKit::WebResourceLoadStatisticsStore::logTestingEvent):
(WebKit::WebResourceLoadStatisticsStore::notifyResourceLoadStatisticsProcessed):
(WebKit::WebResourceLoadStatisticsStore::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebResourceLoadStatisticsStore::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::sendDiagnosticMessageWithValue const):
(WebKit::WebResourceLoadStatisticsStore::notifyPageStatisticsTelemetryFinished const):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores): Deleted.
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData): Deleted.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebsiteDataStore::hasStorageAccess):
(WebKit::WebsiteDataStore::requestStorageAccess):
(WebKit::WebsiteDataStore::grantStorageAccess):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::webProcessWillOpenConnection):
(WebKit::WebsiteDataStore::webProcessDidCloseConnection):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::didCreateNetworkProcess):
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData): Deleted.
(WebKit::WebsiteDataStore::removeDataForTopPrivatelyControlledDomains): Deleted.
(WebKit::WebsiteDataStore::setCacheMaxAgeCap): Deleted.
(WebKit::WebsiteDataStore::updatePrevalentDomainsToBlockCookiesFor): Deleted.
(WebKit::WebsiteDataStore::setAgeCapForClientSideCookies): Deleted.
(WebKit::WebsiteDataStore::hasStorageAccessForFrameHandler): Deleted.
(WebKit::WebsiteDataStore::grantStorageAccessHandler): Deleted.
(WebKit::WebsiteDataStore::removeAllStorageAccessHandler): Deleted.
(WebKit::WebsiteDataStore::removePrevalentDomains): Deleted.
(WebKit::WebsiteDataStore::isGrandfathered): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 9:23 AM WebKitGTK/2.22.x edited by
- (diff)
- 9:23 AM Changeset in webkit [240585] by
-
- 3 edits in releases/WebKitGTK/webkit-2.22
Merge r238928: REGRESSION(r231043): [GTK] Undefined references to WebCore::LayerRepresentation::* with -DENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=191997
Patch by Carlos Eduardo Ramalho <cadubentzen@gmail.com> on 2018-12-06
Reviewed by Philippe Normand.
.:
Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF
- Source/cmake/OptionsGTK.cmake: make ENABLE_ASYNC_SCROLLING depend on ENABLE_OPENGL
Source/WebCore:
Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.
No new tests required. Only fixing build.
- platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)
Source/WebKit:
Fix build with -DENABLE_OPENGL=OFF and -DENABLE_VIDEO=OFF.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent): add required #if ENABLE(ASYNC_SCROLLING)
- 9:19 AM Changeset in webkit [240584] by
-
- 2 edits in releases/WebKitGTK/webkit-2.22/Source/WebCore
Merge r239869 - [GTK] Garbled rendering on Youtube while scrolling under X11.
https://bugs.webkit.org/show_bug.cgi?id=192982
Reviewed by Carlos Garcia Campos.
When creating a GLX window context, try to get a GLXFBConfig that has depth and stencil buffers for
the default framebuffer.
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::compatibleVisuals):
(WebCore::GLContextGLX::createWindowContext):
- 8:20 AM Changeset in webkit [240583] by
-
- 7 edits in trunk
[LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
https://bugs.webkit.org/show_bug.cgi?id=193896
Reviewed by Antti Koivisto.
Source/WebCore:
This patch implements quirk margin value collapsing. There are a few "quirk" rules when it comes to margin collapsing.
- Collapsed quirk margin values are ignored on quirk containers
<body>
<p> p elements have 1em vertical (top/bottom) quirk margin
</body>
In quirk mode, <p> and <body> (quirk container) collapses their vertical margins but <p>'s quirk values(1qem -> 16px) are ignored.
Used vertical margin values on the <body> are top: 8px bottom: 8px.
- Quirk margin values are turned into non-quirk values when collapsed with non-zero, non-quirk margins.
<body>
<div style="margin-top: 1px">
<p> p elements have 1em vertical (top/bottom) quirk margin
</div>
</body>
When <p>'s vertical margin collapses with the parent <div>,
- the collapsed before value becomes 16px (max(1qem, 1px)) and this collapsed value is now considered as a non-quirk value
- the collapsed after value stays 1qem quirk value.
When <div> collapses with <body>
- the collapsed before value becomes 16px (max(16px, 8px))
- the <div>'s quirk after value gets ignored and the collapsed after value stays 8px. Used vertical margin values on the <body> are top: 16px (1em) bottom: 8px.
- layout/MarginTypes.h:
(WebCore::Layout::PositiveAndNegativeVerticalMargin::Values::isNonZero const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreCollapsedQuirkMargin):
(WebCore::Layout::hasMarginBeforeQuirkValue): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginBefore): Deleted.
(WebCore::Layout::BlockFormattingContext::Quirks::shouldIgnoreMarginAfter): Deleted.
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):
(WebCore::Layout::computedPositiveAndNegativeMargin):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginBefore):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 7:43 AM Changeset in webkit [240582] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC] Remove redundant vertical positioning in BlockFormattingContext::computeFloatingPosition
https://bugs.webkit.org/show_bug.cgi?id=193872
Reviewed by Antti Koivisto.
This is taken care of by verticalPositionWithMargin() in BlockFormattingContext::computeHeightAndMargin().
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
- 7:31 AM Changeset in webkit [240581] by
-
- 2 edits in trunk/Source/WebCore
Add missing #include in ScrollingTreeFrameScrollingNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=193905
Patch by cathie chen <cathiechen> on 2019-01-28
Reviewed by Frédéric Wang.
- page/scrolling/ScrollingTreeFrameScrollingNode.cpp: Add
#include "ScrollingStateFrameScrollingNode.h"
- 7:29 AM Changeset in webkit [240580] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC][Quirk] Ignore collapsed(through) margin after when stretching body height.
https://bugs.webkit.org/show_bug.cgi?id=193894
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- 7:08 AM Changeset in webkit [240579] by
-
- 26 edits19 adds in trunk
Limit user-agent interactions based on the touch-action property on iOS
https://bugs.webkit.org/show_bug.cgi?id=193447
<rdar://problem/47283874>
Reviewed by Antti Koivisto and Simon Fraser.
Source/WebCore:
We now compile a list of elements with a non-auto touch-action property that is updated whenever an element has its style changed
or is removed from its document. When the content of that list changes, we inform the scrolling coordinator such that it can compile
a list of TouchActionData structures which hold the touch-action value, the ID of the nearest scroll node and the Region containing
the bounds of each of those elements to send it up to the UI process along with touch regions. Computing the list of allowed touch
actions for a given element accounts for not only the value specified directly on that element's style, but also in its hierarchy,
crossing any frame boundary towards the top-level document's root node.
Tests: pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
pointerevents/ios/touch-action-none-on-iframe.html
pointerevents/ios/touch-action-none-on-parent.html
pointerevents/ios/touch-action-none.html
pointerevents/ios/touch-action-pan-x-pan-y.html
pointerevents/ios/touch-action-pan-x.html
pointerevents/ios/touch-action-pan-y.html
pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html
pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling.html
- WebCore.xcodeproj/project.pbxproj: Update how certain headers are exposed such that they can be used from WebKit.
- dom/Document.cpp:
(WebCore::Document::invalidateRenderingDependentRegions):
(WebCore::Document::nodeWillBeRemoved): Ensure a node that is being removed from this document is no longer listed in its
list of elements with a non-auto touch-action property.
(WebCore::Document::absoluteEventRegionForNode):
(WebCore::Document::absoluteRegionForEventTargets):
(WebCore::Document::updateTouchActionElements): Create a list of elements with a non-auto touch-action property if one doesn't
exist yet and update it to add the given element if it contains a non-auto touch-action, or remove it if it doesn't. If the contents
of that list changed as a result, the scrolling coordinator is informed.
- dom/Document.h:
(WebCore::Document:: const):
- dom/Element.cpp:
(WebCore::parentCrossingFrameBoundaries):
(WebCore::Element::computedTouchActions const): Provide the list of allowed touch actions accounting for the "touch-action" property
specified on this element and all of its hierarchy, crossing frame boundary.
(WebCore::Element::nearestScrollingNodeIDUsingTouchOverflowScrolling const): Provide the ScrollingNodeID, if any, for the nearest scrolling node
for that element. This will allow the UI process to identify which scroll view's behavior to customize to reflect the element's allowed
touch actions.
- dom/Element.h:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const): Compute the region for all elements with a non-auto touch-action property
throughout the provided frame and all of its subframes.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollableAreaParameters::operator== const): Deleted.
- page/scrolling/ScrollingCoordinatorTypes.h: Added.
(WebCore::ScrollableAreaParameters::operator== const):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::touchActionDataAtPoint const): Query the list of TouchActionData objects for a match based on the provided point. Right
now the logic is pretty crude, stopping at the first TouchActionData for which the region contains the provided point, but future patches will
account for overlap and nesting.
- page/scrolling/ScrollingTree.h:
- page/scrolling/ScrollingTreeNode.h:
- platform/EventTrackingRegions.cpp:
(WebCore::operator==):
- platform/EventTrackingRegions.h:
(WebCore::operator!=):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement): Update the list of elements with a non-auto touch-action property when an element's style changes.
Source/WebKit:
Handle the "none", "pan-x", "pan-y" and "pinch-zoom" values for the touch-action property by querying the scrolling tree whenever a touch begins
to identify whether its point is contained within the region of an element with a non-auto touch-action property. If it is, we use the list of
permitted touch actions such to then customize the behavior of the nearest scroll view to pan or zoom only as instructed.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TouchActionData>::encode):
(IPC::ArgumentCoder<TouchActionData>::decode):
(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):
(IPC::ArgumentCoder<Region>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Account for panning constraints set on the content view to prevent deceleration
to pan the view if it ought not.
(-[WKWebView _scrollView:adjustedOffsetForOffset:translation:startPoint:locationInView:horizontalVelocity:verticalVelocity:]): Implement an additional
UIScrollView delegation method to apply the panning constraints set on the content view while panning.
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::touchActionDataAtPoint const):
(WebKit::RemoteScrollingCoordinatorProxy::touchActionDataForScrollNodeID const):
(WebKit::RemoteScrollingCoordinatorProxy::setTouchDataForTouchIdentifier):
(WebKit::RemoteScrollingCoordinatorProxy::clearTouchDataForTouchIdentifier):
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Apply the same logic as in WKWebView.
(-[WKScrollingNodeScrollViewDelegate _scrollView:adjustedOffsetForOffset:translation:startPoint:locationInView:horizontalVelocity:verticalVelocity:]): Apply
the same logic as in WKWebView.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::touchActionData const):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isScrollingOrZooming const):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView preventsPanningInXAxis]):
(-[WKContentView preventsPanningInYAxis]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _handleTouchActionsForTouchEvent:]): As we process touches, check whether there are touch actions set for this touch's points' locations. Based
on those touch actions, either setDefaultPrevented on the _touchEventGestureRecognizer if the touch action is "none" or selectively disable panning and zooming.
(-[WKContentView _resetPanningPreventionFlags]):
(-[WKContentView _didEndScrollingOrZooming]):
LayoutTests:
Add a new series of tests that check that the "none", "pan-x", "pan-y" and "pinch-zoom" values have the expected
impact on page panning on iOS.
- pointerevents/ios/touch-action-none-expected.txt: Added.
- pointerevents/ios/touch-action-none-in-overflow-scrolling-touch-expected.txt: Added.
- pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html: Added.
- pointerevents/ios/touch-action-none-on-iframe-expected.txt: Added.
- pointerevents/ios/touch-action-none-on-iframe.html: Added.
- pointerevents/ios/touch-action-none-on-parent-expected.txt: Added.
- pointerevents/ios/touch-action-none-on-parent.html: Added.
- pointerevents/ios/touch-action-none.html: Added.
- pointerevents/ios/touch-action-pan-x-expected.txt: Added.
- pointerevents/ios/touch-action-pan-x-pan-y-expected.txt: Added.
- pointerevents/ios/touch-action-pan-x-pan-y.html: Added.
- pointerevents/ios/touch-action-pan-x.html: Added.
- pointerevents/ios/touch-action-pan-y-expected.txt: Added.
- pointerevents/ios/touch-action-pan-y.html: Added.
- pointerevents/ios/touch-action-pinch-zoom-allows-zooming-expected.txt: Added.
- pointerevents/ios/touch-action-pinch-zoom-allows-zooming.html: Added.
- pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling-expected.txt: Added.
- pointerevents/ios/touch-action-pinch-zoom-prevents-scrolling.html: Added.
- 5:15 AM Changeset in webkit [240578] by
-
- 2 edits in trunk/Source/WebKit
WebUserContentController::removeUserScriptMessageHandlerInternal may deref and delete itself
https://bugs.webkit.org/show_bug.cgi?id=193901
<rdar://problem/47338669>
Reviewed by David Kilzer.
Don't know how to repro.
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::removeUserScriptMessageHandlerInternal):
Calling userMessageHandlers.removeFirstMatching() may remove the last ref to this
(because WebUserMessageHandlerDescriptorProxy refs WebUserContentController).
Fix by protecting this over the function.
- 1:46 AM Changeset in webkit [240577] by
-
- 8 edits in branches/safari-607-branch
Cherry-pick r240516. rdar://problem/47586889
Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193802
<rdar://problem/46010580>
Reviewed by Andy Estes.
Source/WebKit:
- UIProcess/API/APIUIClient.h: (API::UIClient::didClickGoBackFromSafeBrowsingWarning):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::setDelegate): (WebKit::UIDelegate::UIClient::didClickGoBackFromSafeBrowsingWarning):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationAction):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240576] by
-
- 5 edits in branches/safari-607-branch
Cherry-pick r240533. rdar://problem/47586823
REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
https://bugs.webkit.org/show_bug.cgi?id=193831
<rdar://problem/47399263>
Reviewed by Chris Dumez.
Source/WebKit:
A System Preview (<a rel="ar">) displays in a modal and doesn't trigger
a navigation. If the link was cross origin, it was causing a process swap,
which meant that the response defaulted back to a navigation.
The fix is to not cause a PSON when the navigation is a system preview.
- UIProcess/API/APINavigation.h: (API::Navigation::shouldForceDownload const): This is now just tracking the "download" attribute, and not including System Preview. (API::Navigation::isSystemPreview const): New method to check for a navigation triggered as a System Preview.
- UIProcess/WebPageProxy.cpp: Move the code from receivedPolicyDecision to receivedNavigationPolicyDecision, so that downloads and System Previews are detected before we decide to change process. (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::receivedPolicyDecision):
Tools:
Two new tests that exercise cross-origin and same-origin System
Previews.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240575] by
-
- 15 edits1 delete in branches/safari-607-branch/Source/WebKit
Cherry-pick r240484. rdar://problem/47591281
Drop WebKit::WebKitPolicyAction type as it is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=193827
Reviewed by Antti Koivisto.
Drop WebKit::WebKitPolicyAction type as it is no longer needed. It is now identical to
WebCore::PolicyAction.
- Shared/WebPolicyAction.h: Removed.
- UIProcess/WebFramePolicyListenerProxy.cpp: (WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults): (WebKit::WebFramePolicyListenerProxy::use): (WebKit::WebFramePolicyListenerProxy::download): (WebKit::WebFramePolicyListenerProxy::ignore):
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::setUpPolicyListenerProxy):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationPolicyDecision): (WebKit::WebPageProxy::receivedPolicyDecision): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponseShared):
- UIProcess/WebPageProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::didReceivePolicyDecision): (WebKit::toPolicyAction): Deleted.
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didReceivePolicyDecision):
- WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240574] by
-
- 4 edits in branches/safari-607-branch/Source/WebKit
Cherry-pick r240542. rdar://problem/47586850
REGRESSION (r238818): Snapshot is removed too late after swiping back on Twitter
https://bugs.webkit.org/show_bug.cgi?id=193860
<rdar://problem/47535022>
Reviewed by Antti Koivisto.
- UIProcess/Cocoa/ViewGestureController.cpp: (WebKit::ViewGestureController::didStartProvisionalOrSameDocumentLoadForMainFrame): (WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame): (WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
- UIProcess/Cocoa/ViewGestureController.h: Treat provisional load and same document load the same: they already both unpause the snapshot removal tracker, request render tree size notifications, but same-document navigation was missing the call to dispatchAfterEnsuringDrawing and thus would get stuck waiting for RepaintAfterNavigation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240573] by
-
- 2 edits in branches/safari-607-branch/LayoutTests
Cherry-pick r240532. rdar://problem/47586874
Remove expectation for inspector/css/createStyleSheet.html as test appears to be passing.
https://bugs.webkit.org/show_bug.cgi?id=148636
Unreviewed test gardening.
- platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240572] by
-
- 5 edits2 adds in branches/safari-607-branch
Cherry-pick r240497. rdar://problem/47586863
iOS: inputmode="none" disables hardware keyboard's globe key
https://bugs.webkit.org/show_bug.cgi?id=193811
<rdar://problem/47406553>
Reviewed by Wenson Hsieh.
Source/WebKit:
Removed the support for inputmode="none" for now since we need a new SPI from UIKit
to properly implement this feature some time in the future.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _zoomToRevealFocusedElement]): (-[WKContentView inputView]): (-[WKContentView requiresAccessoryView]): (-[WKContentView textInputTraits]):
LayoutTests:
Updated and renamed the test expecting the keyboard to update upon inputmode content attribute changed
to use inputmode="decimal" instead of inputmode="none", and updated another test to expect inputmode="none"
has no effect instead of hiding the keyboard.
- fast/forms/ios/inputmode-change-update-keyboard-expected.txt: Renamed from inputmode-none-removed-expected.txt.
- fast/forms/ios/inputmode-change-update-keyboard.html: Renamed from inputmode-none-removed.html.
- fast/forms/ios/inputmode-none-expected.txt:
- fast/forms/ios/inputmode-none.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240571] by
-
- 6 edits in branches/safari-607-branch/Source/WebKit
Cherry-pick r240493. rdar://problem/47586905
REGRESSION (PSON): After swipe back, first few attempts to swipe forward not recognized as swipe gestures
https://bugs.webkit.org/show_bug.cgi?id=193818
<rdar://problem/47456584>
Reviewed by Tim Horton.
We don't hit the RenderTreeSizeThreshold milestone to remove the snapshot and allow interaction because we request it
from a wrong process (the one we are leaving behind).
- UIProcess/Cocoa/ViewGestureController.cpp: (WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
Request the RenderTreeSizeThreshold notification when the load has started and we know the process to use.
(WebKit::ViewGestureController::SnapshotRemovalTracker::hasOutstandingEvent):
- UIProcess/Cocoa/ViewGestureController.h: (WebKit::ViewGestureController::SnapshotRemovalTracker::renderTreeSizeThreshold const): (WebKit::ViewGestureController::SnapshotRemovalTracker::setRenderTreeSizeThreshold):
- UIProcess/mac/ViewGestureControllerMac.mm: (WebKit::ViewGestureController::endSwipeGesture):
Don't request immediately, save the threshold to SnapshotRemovalTracker.
(WebKit::ViewGestureController::requestRenderTreeSizeNotificationIfNeeded):
Do the request to the right process.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp: (WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):
Ensure we send the notification even if we reached the threshold before it was requested.
(WebKit::ViewGestureGeometryCollector::sendDidHitRenderTreeSizeThresholdIfNeeded):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
- WebProcess/WebPage/ViewGestureGeometryCollector.h: (WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240570] by
-
- 8 edits in branches/safari-607-branch
Cherry-pick r240490. rdar://problem/47586864
WKWebView.goBack should reload if there is a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193805
<rdar://problem/46908216>
Reviewed by Geoff Garen.
Source/WebKit:
If a WKWebView is showing a safe browsing warning and the user clicks a back button
in the app which calls WKWebView.goBack, the WKWebView is in a state where it has not navigated yet,
so actually going back will appear to the user to go back twice. We can't just do nothing because the
app is in a state where it is expecting a navigation to happen. Reloading achieves what the user expects
and makes the app work like the app expects.
- UIProcess/API/C/WKPage.cpp: (WKPageGoBack):
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView goBack]):
- UIProcess/PageClient.h: (WebKit::PageClient::hasSafeBrowsingWarning const):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::hasSafeBrowsingWarning const):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: (+[Simple3LookupContext sharedLookupContext]): (-[Simple3LookupContext lookUpURL:completionHandler:]): (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]): (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240569] by
-
- 1 edit3 adds in branches/safari-607-branch/Source/WebInspectorUI
Cherry-pick r240488. rdar://problem/47586897
Web Inspector: Add another Protocol Version (iOS 12.2)
https://bugs.webkit.org/show_bug.cgi?id=193810
<rdar://problem/42981838>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-25
Reviewed by Matt Baker.
- UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-12.2.json: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:41 AM Changeset in webkit [240568] by
-
- 4 edits in branches/safari-607-branch
Cherry-pick r240485. rdar://problem/47586895
Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
https://bugs.webkit.org/show_bug.cgi?id=193788
<rdar://problem/47531231>
Reviewed by Alex Christensen.
Source/WebKit:
When the page starts a new provisional load, make sure we cancel any pending one in the provisional
process, as it would have happened in the first provisional load happened in the same process.
Without this, we could have 2 parallel loads happening, one in the committed process and another
in the provisional one, leading to assertion failures in debug.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240567] by
-
- 5 edits in branches/safari-607-branch
Cherry-pick r240477. rdar://problem/47586845
Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=193779
<rdar://problem/46170903>
Reviewed by Antti Koivisto.
Source/WebKit:
- UIProcess/Cocoa/NavigationState.mm: (WebKit::tryAppLink): (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): We were crashing when trying to get the URL of the main frame, which was sad because we never ended up using the main frame URL. Therefore, this patch drops the code in question.
- UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync): Add assertion to make sure that the DecidePolicyForNavigationActionAsync IPC it is getting from the process is related to its main frame.
Tools:
Add API test that quickly navigates forward to a previous process without waiting for it to
suspend. I suspect the crash could have been happening due to receiving leftover IPC from
the process' previous page when reconnecting the it for the forward navigation.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240566] by
-
- 2 edits in branches/safari-607-branch/Source/WebCore
Cherry-pick r240451. rdar://problem/47586844
Fix leak of AVSampleBufferRenderSynchronizer boundaryObserver object.
https://bugs.webkit.org/show_bug.cgi?id=193778
Reviewed by Jon Lee.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::performTaskAtMediaTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240565] by
-
- 5 edits1 add in branches/safari-607-branch
Cherry-pick r240450. rdar://problem/47586830
DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
https://bugs.webkit.org/show_bug.cgi?id=193741
<rdar://problem/47135030>
Reviewed by Antti Koivisto and Simon Fraser.
Source/WebCore:
fireLayoutRelatedMilestonesIfNeeded() is part of the post-layout tasks. In certain cases when
- the received data is not "contentful" yet
- and we are expecting some more (loading is not complete yet)
- but no layout is initiated anymore
nothing triggers the milestone firing.
This patch ensures that we fire the DidFirstVisuallyNonEmptyLayout when the frame load is complete unless we already did.
- page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::loadProgressingStatusChanged):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240564] by
-
- 8 edits1 add in branches/safari-607-branch
Cherry-pick r240449. rdar://problem/47586886
stress/const-semantics.js fails a dfg-eager / ftl-eager run with an ASAN release build.
https://bugs.webkit.org/show_bug.cgi?id=190693
Reviewed by Michael Saboff.
JSTests:
- stress/regress-190693.js: Added. (truth): (assert): (shouldThrowInvalidConstAssignment): (taz):
Source/JavaScriptCore:
JITStubRoutine's fields are marked only when JITStubRoutine::m_mayBeExecuting is true.
This becomes true when we find the executable address in our conservative roots, which
means that we could be executing it right now. This means that object liveness in
JITStubRoutine depends on the information gathered in ConservativeRoots. However, our
constraints are separated, "Conservative Scan" and "JIT Stub Routines". They can even
be executed concurrently, so that "JIT Stub Routines" may miss to mark the actually
executing JITStubRoutine because "Conservative Scan" finds it later.
When finalizing the GC, we delete the dead JITStubRoutines. At that time, since
"Conservative Scan" already finishes, we do not delete some JITStubRoutines which do not
mark the depending objects. Then, in the next cycle, we find JITStubRoutines still live,
attempt to mark the depending objects, and encounter the dead objects which are collected
in the previous cycles.
This patch removes "JIT Stub Routines" and merge it to "Conservative Scan". Since
"Conservative Scan" and "JIT Stub Routines" need to be executed only when the execution
happens (ensured by GreyedByExecution and CollectionPhase check), this change is OK for
GC stop time.
- heap/ConservativeRoots.h: (JSC::ConservativeRoots::roots const): (JSC::ConservativeRoots::roots): Deleted.
- heap/Heap.cpp: (JSC::Heap::addCoreConstraints):
- heap/SlotVisitor.cpp: (JSC::SlotVisitor::append):
- heap/SlotVisitor.h:
- jit/GCAwareJITStubRoutine.cpp: (JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
- jit/GCAwareJITStubRoutine.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240563] by
-
- 3 edits1 add in branches/safari-607-branch
Cherry-pick r240447. rdar://problem/47586899
Object Allocation Sinking phase can move a node that walks the stack into a place where the InlineCallFrame is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=193751
<rdar://problem/47280215>
Reviewed by Michael Saboff.
JSTests:
- stress/object-allocation-sinking-phase-must-only-move-allocations-if-stack-trace-is-still-valid.js: Added. (let.thing): (foo.let.hello): (foo):
Source/JavaScriptCore:
The Object Allocation Sinking phase may move allocations around inside
of the program. However, it was not ensuring that it's still possible
to walk the stack at the point in the program that it moved the allocation to.
Certain InlineCallFrames rely on data in the stack when taking a stack trace.
All allocation sites can do a stack walk (we do a stack walk when we GC).
Conservatively, this patch says we're ok to move this allocation if we are
moving within the same InlineCallFrame. We could be more precise and do an
analysis of stack writes. However, this scenario is so rare that we just
take the conservative-and-straight-forward approach of checking that the place
we're moving to is the same InlineCallFrame as the allocation site.
In general, this issue arises anytime we do any kind of code motion.
Interestingly, LICM gets this right. It gets it right because the only
InlineCallFrames we can't move out of are the InlineCallFrames that
have metadata stored on the stack (callee for closure calls and argument
count for varargs calls). LICM doesn't have this issue because it relies
on Clobberize for doing its effects analysis. In clobberize, we model every
node within an InlineCallFrame that meets the above criteria as reading
from those stack fields. Consequently, LICM won't hoist any node in that
InlineCallFrame past the beginning of the InlineCallFrame since the IR
we generate to set up such an InlineCallFrame contains writes to that
stack location.
- dfg/DFGObjectAllocationSinkingPhase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240562] by
-
- 9 edits in branches/safari-607-branch
Cherry-pick r240443. rdar://problem/47586900
[PSON] Flash on back navigation on Mac
https://bugs.webkit.org/show_bug.cgi?id=193716
<rdar://problem/47148458>
Reviewed by Chris Dumez.
Source/WebKit:
We close the page immediately if we fail to suspend. Layers disappear and we get a flash.
- UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::~SuspendedPageProxy): (WebKit::SuspendedPageProxy::close):
Track closed state so we don't send the message twice, causing unhandled message errors in web process.
(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
Close the suspended page if the suspension fails.
Skip this if we are using web process side compositing on Mac.
- UIProcess/SuspendedPageProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode):
On Mac, close the failed SuspendedPageProxy when entering compositing mode. At this point we don't need it to keep layers alive.
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::closeFailedSuspendedPagesForPage):
- UIProcess/WebProcessPool.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::suspendForProcessSwap):
Don't close the page on suspension failure. This is now managed by the UI process.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Closing of the previous page is delayed so waiting for didFinishNavigation is
not sufficient to guarantee we have received all the messages. Wait for them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240561] by
-
- 4 edits in branches/safari-607-branch
Cherry-pick r240442. rdar://problem/47586826
Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
https://bugs.webkit.org/show_bug.cgi?id=193761
<rdar://problem/47456405>
Reviewed by Alex Christensen.
Source/WebKit:
When doing a history navigation cross-process, the UIProcess would first send the back/forward list items
to the destination WebProcess via WebPage::updateBackForwardListForReattach(), then ask the process to
navigate to the expected back/forward list item.
WebPage::updateBackForwardListForReattach() would call restoreSessionInternal(), which would call
toHistoryItem() on each BackForwardListItem. This may end up creating more than one HistoryItem for each
BackForwardListItem because HistoryItems are part of a tree (each frame has its own list of history items).
Note that BackForwardListItems and HistoryItem share a BackForwardItemIdentifier which is a
(processIdentifier, itemIdentifier) pair. We normally generate the HistoryItem's identifier from inside
its constructor like so:
{ Process::identifier(), generateObjectIdentifier<BackForwardItemIdentifier::ItemIdentifierType>() }
However, when calling updateBackForwardListForReattach() and constructing children HistoryItem,
applyFrameState() would generate the identifier by itself and passing it to the HistoryItem constructor.
Its genegates the ID the exact same way so this would in theory not be a problem. Unfortunately, both
calls to generateObjectIdentifier() get inlined and both call sites end up with their own static counter
to generate ids. As a result, we may end up with conflicts as HistoryItems for child frames (restored
by restoreSessionInternal()) can end up with the same identifier as HistoryItems for top frames.
This confusion would lead to the WebContent process sending the UIProcess bad information and the URL
of subframes could end up as the WebBackForwardListItem's mainframe URL.
- WebProcess/WebCoreSupport/SessionStateConversion.cpp: (WebKit::applyFrameState): Stop calling generateObjectIdentifier() explicitly and let the HistoryItem constructor take care of it. Calling generateObjectIdentifier() for the same type from different places is not safe due to inlining.
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:40 AM Changeset in webkit [240560] by
-
- 4 edits1 add in branches/safari-607-branch
Cherry-pick r240364. rdar://problem/47586820
[DFG] AvailabilityMap::pruneByLiveness should make non-live operands Availability::unavailable instead of Availability()
https://bugs.webkit.org/show_bug.cgi?id=193711
<rdar://problem/47250262>
Reviewed by Saam Barati.
JSTests:
- stress/availability-was-cleared-when-locals-are-not-live.js: Added. (shouldBe): (foo): (bar): (baz):
Source/JavaScriptCore:
When pruning OSR Availability based on bytecode liveness, we accidentally clear the Availability (making it DeadFlush) instead of
making it Availability::unavailable() (Making it ConflictingFlush). In OSRAvailabilityAnalysisPhase, we perform forward analysis.
We first clear all the availability of basic blocks DeadFlush, which is an empty set. And then, we set operands in the root block
ConflictingFlush. In this forward analysis, DeadFlush is BOTTOM, and ConflictingFlush is TOP. Then, we propagate information by
merging availability until we reach to the fixed-point. As an optimization, we perform "pruning" of the availability in the head
of the basic blocks. We remove availabilities of operands which are not live in the bytecode liveness at the head of the basic block.
The problem is, when removing availabilities, we set DeadFlush for them instead of ConflictingFlush. Basically, it means that we set
BOTTOM (an empty set) instead of TOP. Let's consider the following simple example. We have 6 basic blocks, and they are connected
as follows.
BB0 -> BB1 -> BB2 -> BB4
| \
v > BB3 /
BB5
And consider about loc1 in FTL, which is required to be recovered in BB4's OSR exit.
BB0 does nothing
head: loc1 is dead
tail: loc1 is dead
BB1 has MovHint @1, loc1
head: loc1 is dead
tail: loc1 is live
BB2 does nothing
head: loc1 is live
tail: loc1 is live
BB3 has PutStack @1, loc1
head: loc1 is live
tail: loc1 is live
BB4 has OSR exit using loc1
head: loc1 is live
tail: loc1 is live (in bytecode)
BB5 does nothing
head: loc1 is dead
tail: loc1 is dead
In our OSR Availability analysis, we always prune loc1 result in BB1's head since its head says "loc1 is dead".
But at that time, we clear the availability for loc1, which makes it DeadFlush, instead of making it ConflictingFlush.
So, the flush format of loc1 in each tail of BB is like this.
BB0
ConflictingFlush (because all the local operands are initialized with ConflictingFlush)
BB1
DeadFlush+@1 (pruning clears it)
BB2
DeadFlush+@1 (since it is propagated from BB1)
BB3
FlushedJSValue+@1 with loc1 (since it has PutStack)
BB4
FlushedJSValue+@1 with loc1 (since MERGE(DeadFlush, FlushedJSValue) = FlushedJSValue)
BB5
DeadFlush (pruning clears it)
Then, if we go the path BB0->BB1->BB2->BB4, we read the value from the stack while it is not flushed.
The correct fix is making availability "unavailable" when pruning based on bytecode liveness.
- dfg/DFGAvailabilityMap.cpp: (JSC::DFG::AvailabilityMap::pruneByLiveness): When pruning availability, we first set all the operands Availability::unavailable(), and copy the calculated value from the current availability map.
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::OSRAvailabilityAnalysisPhase::run): Add logging things for debugging.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:29 AM Changeset in webkit [240559] by
-
- 16 edits2 adds in trunk
Web Inspector: Add Changes panel to Elements tab
https://bugs.webkit.org/show_bug.cgi?id=193803
Reviewed by Devin Rousso.
Source/WebInspectorUI:
Introduce the new experimental Changes Panel. It shows a list of CSS changes
made via Web Inspector, so the changes could be copied to the source files.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Setting.js:
- UserInterface/Base/Utilities.js:
(Array.diffArrays): Added.
- UserInterface/Controllers/CSSManager.js:
(WI.CSSManager):
(WI.CSSManager.prototype.get modifiedCSSRules):
(WI.CSSManager.prototype.addModifiedCSSRule):
(WI.CSSManager.prototype.removeModifiedCSSRule):
(WI.CSSManager.prototype._mainResourceDidChange):
- UserInterface/Main.html:
- UserInterface/Models/CSSProperty.js:
(WI.CSSProperty):
(WI.CSSProperty.prototype.remove):
(WI.CSSProperty.prototype.replaceWithText):
(WI.CSSProperty.prototype.commentOut):
(WI.CSSProperty.prototype.set text):
(WI.CSSProperty.prototype.get modified):
(WI.CSSProperty.prototype.set name):
(WI.CSSProperty.prototype.set rawValue):
(WI.CSSProperty.prototype.get initialState):
(WI.CSSProperty.prototype._updateOwnerStyleText):
(WI.CSSProperty.prototype._markModified):
Mark CSSProperty modified *before* making any changes to copy its initial state.
- UserInterface/Models/CSSRule.js:
(WI.CSSRule):
(WI.CSSRule.prototype.get id):
(WI.CSSRule.prototype.get initialState):
(WI.CSSRule.prototype.get stringId):
(WI.CSSRule.prototype.markModified):
- UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration):
(WI.CSSStyleDeclaration.prototype.get initialState):
(WI.CSSStyleDeclaration.prototype.get enabledProperties):
(WI.CSSStyleDeclaration.prototype.get properties):
(WI.CSSStyleDeclaration.prototype.set properties):
(WI.CSSStyleDeclaration.prototype.propertyForName):
(WI.CSSStyleDeclaration.prototype.newBlankProperty):
(WI.CSSStyleDeclaration.prototype.markModified):
- UserInterface/Views/ChangesDetailsSidebarPanel.css: Added.
(.sidebar > .panel.changes-panel):
(.sidebar > .panel.changes-panel:not(.empty)):
(.sidebar > .panel.changes-panel.empty):
(.changes-panel ins):
(.changes-panel del):
(.changes-panel del.css-property::before):
(.changes-panel ins.css-property::before):
(@media (prefers-color-scheme: dark)):
- UserInterface/Views/ChangesDetailsSidebarPanel.js: Added.
(WI.ChangesDetailsSidebarPanel):
(WI.ChangesDetailsSidebarPanel.prototype.inspect):
(WI.ChangesDetailsSidebarPanel.prototype.supportsDOMNode):
(WI.ChangesDetailsSidebarPanel.prototype.shown):
(WI.ChangesDetailsSidebarPanel.prototype.detached):
(WI.ChangesDetailsSidebarPanel.prototype.layout):
(WI.ChangesDetailsSidebarPanel.prototype._mainResourceDidChange):
- UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property):
(.spreadsheet-style-declaration-editor .property.modified):
(.spreadsheet-style-declaration-editor .property.modified:not(.selected)):
(@media (prefers-color-scheme: dark)):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
LayoutTests:
Test newly added Array.diffArrays.
- inspector/unit-tests/array-utilities-expected.txt:
- inspector/unit-tests/array-utilities.html:
Use the old
InspectorTest.logmethod since it shows diffs for actual and expected text.
Jan 27, 2019:
- 7:03 PM Changeset in webkit [240558] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix WPE/GTK debug builds after r240557
https://bugs.webkit.org/show_bug.cgi?id=192742
<rdar://problem/46757369>
Also fix an improper format string that was recently added in a different commit.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
- 5:56 PM Changeset in webkit [240557] by
-
- 115 edits in trunk
Replace many uses of String::format with more type-safe alternatives
https://bugs.webkit.org/show_bug.cgi?id=192742
Reviewed by Mark Lam.
Source/JavaScriptCore:
- inspector/InjectedScriptBase.cpp:
(Inspector::InjectedScriptBase::makeCall): Use makeString.
(Inspector::InjectedScriptBase::makeAsyncCall): Ditto.
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::getPropertyValue): Ditto.
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::enable): Ditto.
- jsc.cpp:
(FunctionJSCStackFunctor::operator() const): Ditto.
- runtime/CodeCache.cpp:
(JSC::writeCodeBlock): Use makeString's numeric capabilities instead of
using String::number.
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat): Use string concatenation.
- runtime/IntlObject.cpp:
(JSC::canonicalizeLocaleList): Ditto.
Source/WebCore:
A while back, String::format was more efficient than string concatenation,
but that is no longer true, and we should prefer String::number, makeString,
or concatenation with the "+" operator to String::format for new code.
This is not as good for programmers who are fond of printf formatting
style, and in some cases it's a little harder to read the strings
interspersed with variables rather than a format string, but it's better
in a few ways:
- more efficient (I didn't measure the difference, but it's definitely slower to use String::Format which calls vsnprintf twice than to use the WTF code)
- works in a type-safe way without a need to use a format specifier such as "%" PRIu64 or "%tu" making it much easier to avoid problems due to subtle differences between platforms
- allows us to use StringView in some cases to sidestep the need to allocate temporary WTF::String objects
- does not require converting each WTF::String to a C string, allowing us to remove many cases of ".utf8().data()" and similar expressions, eliminating the allocation of temporary WTF::CString objects
This patch covers a batch of easiest-to-convert call sites.
Later patches will allow us to deprecate or remove String::format.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Use makeString.
- Modules/indexeddb/shared/IDBCursorInfo.cpp:
(WebCore::IDBCursorInfo::loggingString const): Ditto.
- Modules/indexeddb/shared/IDBGetAllRecordsData.cpp:
(WebCore::IDBGetAllRecordsData::loggingString const): Ditto.
- Modules/indexeddb/shared/IDBGetRecordData.cpp:
(WebCore::IDBGetRecordData::loggingString const): Ditto.
- Modules/indexeddb/shared/IDBIndexInfo.cpp:
(WebCore::IDBIndexInfo::loggingString const): Ditto.
(WebCore::IDBIndexInfo::condensedLoggingString const): Ditto.
- Modules/indexeddb/shared/IDBIterateCursorData.cpp:
(WebCore::IDBIterateCursorData::loggingString const): Ditto.
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::condensedLoggingString const): Ditto.
- Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::loggingString const): Ditto.
- Modules/webdatabase/Database.cpp:
(WebCore::formatErrorMessage): Ditto.
- Modules/webdatabase/SQLError.h:
(WebCore::SQLError::create): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Use makeString.
- bindings/scripts/test/JS/JSInterfaceName.cpp:
- bindings/scripts/test/JS/JSMapLike.cpp:
- bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCEReactions.cpp:
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
- bindings/scripts/test/JS/JSTestCallTracer.cpp:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
- bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
- bindings/scripts/test/JS/JSTestIterable.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestPluginInterface.cpp:
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
- bindings/scripts/test/JS/JSTestSerialization.cpp:
- bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
- bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestStringifier.cpp:
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Updated expected results.
Source/WebKit:
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::writeHeaders): Use makeString.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential): Use string concatentation.
- UIProcess/WebInspectorUtilities.cpp:
(WebKit::inspectorPageGroupIdentifierForPage): Use makeString.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processDidFinishLaunching): Ditto.
(WebKit::WebProcessPool::startMemorySampler): Ditto.
Source/WebKitLegacy:
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::writeHeaders): Use makeString.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential): Use string concatentation.
- UIProcess/WebInspectorUtilities.cpp:
(WebKit::inspectorPageGroupIdentifierForPage): Use makeString.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processDidFinishLaunching): Ditto.
(WebKit::WebProcessPool::startMemorySampler): Ditto.
Source/WTF:
- wtf/WorkQueue.cpp:
(WTF::WorkQueue::concurrentApply): Use makeString.
- wtf/dtoa.cpp:
(WTF::dtoa): Use sprintf instead of String::format in the comments,
since these functions have nothing to do with WTF::String.
Tools:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::cacheTestRunnerCallback): Use makeString.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
(WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
- 3:51 PM Changeset in webkit [240556] by
-
- 2 edits in trunk/Source/WebCore
Remove a couple of PLATFORM defines intended for watchOS
https://bugs.webkit.org/show_bug.cgi?id=193888
Reviewed by Alexey Proskuryakov.
Remove the use of !PLATFORM(WATCH), since this is true on every platform.
- editing/cocoa/DictionaryLookup.mm:
- 12:44 PM Changeset in webkit [240555] by
-
- 11 edits3 copies in trunk
Use a load optimizer for some sites
https://bugs.webkit.org/show_bug.cgi?id=193881
<rdar://problem/46325455>
Reviewed by Brent Fulgham.
Source/WebCore:
Expose FormData::flatten to be used by the load optimizer.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/FormData.h:
Source/WebKit:
We will try to speed up some sites with a dedicated load optimizer. The load optimizer lives
within the WebsiteDataStore as one client instance should have only one and it should live
as long as the client lives. How does the load optimizer work? It intercepts every load in
the navigation state. If a request meets some requirements, it will then fetch the request
from its own cache. Once the fetch succeeds, the original load will be ignored and the
optimizer will display the cached content.
Covered by API tests.
- SourcesCocoa.txt:
- UIProcess/Cocoa/LoadOptimizer.h: Added.
- UIProcess/Cocoa/LoadOptimizer.mm: Added.
- UIProcess/Cocoa/MediaCaptureUtilities.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryInterceptNavigation):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::tryAppLink): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::loadOptimizer):
- WebKit.xcodeproj/project.pbxproj:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
- 10:36 AM Changeset in webkit [240554] by
-
- 10 edits2 adds in trunk/Source/WebKit
Web Automation: add support for simulating single touches to Automation.performInteractionSequence
https://bugs.webkit.org/show_bug.cgi?id=193852
<rdar://problem/28360781>
Reviewed by Joseph Pecoraro and Simon Fraser.
This patch makes it possible to simulate touches via the Actions API. The approach is to
use a stripped down version of HIDEventGenerator to send HID events to the UIWindow.
The initial version supports a single touch point; this may be expanded if needed, but
so far it hasn't been an impediment when running desktop-oriented WebDriver test suites.
As part of implementing this support, I went through and added [somewhat obnoxious] ENABLE()
guards so that we don't mistakenly compile mouse support on iOS and touch on Mac,
and vice versa. Each of the interaction methods---touch, mouse, keyboard---can be independently
compiled out. If none is supported (i.e., Windows), then we don't even try to compile
platformSimulate*Interaction methods or SimulatedInputDispatcher. This allows WebAutomationSession
to not include members and code that are never going to be used on a particular platform.
This functionality is covered by existing WebDriver test suites that use Element Click command.
Additional tests that explicitly include 'touch' pointerType will be submitted to WPT later.
- UIProcess/Automation/Automation.json: Update comment.
- UIProcess/Automation/SimulatedInputDispatcher.h:
- UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
- Add appropriate guards for code specific to each interaction type.
- Handle SimulatedInputSourceType::Touch and call out to dispatch events.
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::terminate):
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
(WebKit::WebAutomationSession::mouseEventsFlushedForPage):
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::willClosePage):
Add appropriate guards for code specific to each interaction type.
(WebKit::WebAutomationSession::isSimulatingUserInteraction const):
Add new hook so that we can detect when a touch simulation is in progress.
We don't rely on checking WebKit's event queue, so use a flag.
(WebKit::WebAutomationSession::simulateTouchInteraction):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::cancelInteractionSequence):
(WebKit::WebAutomationSession::performInteractionSequence):
- Add appropriate guards for code specific to each interaction type.
- Bail out immediately if a requested interaction type is not supported.
- Shim Touch input type to Mouse if mouse is not supported but touches are.
Nearly all WebDriver tests in the wild will be requesting a 'mouse' pointerType,
so this is necessary for compatibility. It's easier to shim at this level than try
to implement platformSimulateMouseInteraction for iOS because
platformSimulateMouseinteraction does not use a completion handler but the iOS
implementation would require that.
(WebKit::WebAutomationSession::platformSimulateMouseInteraction): Deleted.
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Deleted.
- Remove these stubs. Platform methods of this class are no longer being filled
with stubs on unsupported platforms because we expect the command to fail earlier.
- UIProcess/Automation/ios/WebAutomationSessionIOS.mm:
(WebKit::WebAutomationSession::platformSimulateTouchInteraction):
- Add appropriate guards for code specific to each interaction type.
- Implement new platform method to simulate touches. This uses _WKTouchEventGenerator.
- UIProcess/Automation/mac/WebAutomationSessionMac.mm:
Add appropriate guards for code specific to each interaction type.
- UIProcess/_WKTouchEventGenerator.h: Added.
- UIProcess/_WKTouchEventGenerator.mm: Added.
(simpleCurveInterpolation):
(calculateNextCurveLocation):
(delayBetweenMove):
(+[_WKTouchEventGenerator sharedTouchEventGenerator]):
(+[_WKTouchEventGenerator nextEventCallbackID]):
(-[_WKTouchEventGenerator init]):
(-[_WKTouchEventGenerator dealloc]):
(-[_WKTouchEventGenerator _createIOHIDEventType:]):
(-[_WKTouchEventGenerator _sendHIDEvent:]):
(-[_WKTouchEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[_WKTouchEventGenerator _updateTouchPoints:count:]):
(-[_WKTouchEventGenerator touchDownAtPoints:touchCount:]):
(-[_WKTouchEventGenerator touchDown:touchCount:]):
(-[_WKTouchEventGenerator touchDown:]):
(-[_WKTouchEventGenerator liftUpAtPoints:touchCount:]):
(-[_WKTouchEventGenerator liftUp:touchCount:]):
(-[_WKTouchEventGenerator liftUp:]):
(-[_WKTouchEventGenerator moveToPoints:touchCount:duration:]):
(-[_WKTouchEventGenerator touchDown:completionBlock:]):
(-[_WKTouchEventGenerator liftUp:completionBlock:]):
(-[_WKTouchEventGenerator moveToPoint:duration:completionBlock:]):
(-[_WKTouchEventGenerator receivedHIDEvent:]):
Copied and simplified from HIDEventGenerator in WebKitTestRunner.
- WebKit.xcodeproj/project.pbxproj:
Add _WKTouchEventGenerator.{h,mm} and make it a private header. The client needs to
route received HID events to -receivedHIDEvent: in order to detect when the marker
HID event has been processed (and thus the interaction is completed).
- config.h: Add ENABLE(WEBDRIVER_*_INTERACTIONS) macros here.
- 8:58 AM Changeset in webkit [240553] by
-
- 26 edits in trunk
Have composited RenderIFrame layers make FrameHosting scrolling tree nodes to parent the iframe's scrolling node
https://bugs.webkit.org/show_bug.cgi?id=193879
Reviewed by Antti Koivisto.
Source/WebCore:
Currently we parent iframe scrolling tree nodes by finding the closest ancestor layer with a scrolling tree node.
This results in scrolling tree nodes being connected across iframe boundaries in some arbitrary ancestor. This
makes updating scrolling tree geometry very error-prone, since changes in the parent document will need to trigger
updates of the scrolling tree node in an iframe.
To address this, I already added a new "FrameHosting" scrolling node type. This patch actually instantiates these
nodes, which are owned by the RenderIFrame's composited layer. Connecting across frame boundaries is theforefore
simply a case of getting the FrameHosting node from the ownerElement's renderer; this is very similar to how we
connect GraphicsLayers together.
RenderLayerBacking gains another scrolling role for FrameHosting and ScrollingNodeID.
Tested by existing tests.
- page/FrameView.h:
- rendering/RenderLayer.cpp:
(WebCore::outputPaintOrderTreeRecursive):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
- rendering/RenderLayerCompositor.cpp:
(WebCore::frameContentsRenderView):
(WebCore::RenderLayerCompositor::frameContentsCompositor):
(WebCore::RenderLayerCompositor::parentFrameContentLayers):
(WebCore::RenderLayerCompositor::isLayerForIFrameWithScrollCoordinatedContents const):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::scrollCoordinatedAncestorInParentOfFrame):
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
- rendering/RenderLayerCompositor.h:
- testing/Internals.cpp:
(WebCore::Internals::scrollingStateTreeAsText const):
Source/WebKit:
Need a specialization of dump() for ScrollingStateFrameHostingNode to avoid infinite recursion.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump):
LayoutTests:
New test results with FrameHosting nodes.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
- scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
- scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
- scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
- scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
- scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt:
- scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt:
- scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt:
- 12:49 AM Changeset in webkit [240552] by
-
- 27 edits6 adds in trunk
Source/JavaScriptCore:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
In order to improve performance when requesting the accessibility hierarchy, we introduce the idea of a "static accessibility tree" which
could be accessed on a different thread by assistive technologies.
That is accomplished by storing all the data needed to answer accessibility attribute queries in a static object that mirrors the
"live" AccessibilityObjects (which interact with both DOM and Render trees).
These static objects are generally created after layout is done and final tasks are being performed. They are then stored in the static tree
representation and able to be read from anywhere.
Tactically this is done with AXIsolatedTreeNodes inside of an AXIsolatedTree. The TreeNodes implement an AccessibilityObjectInterface shared
with AccessibilityObject.
This allows the wrappers to access either one depending on conditions and platforms without significant code duplication or re-organization.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::createIsolatedAccessibilityTree):
(WebCore::AXObjectCache::generateStaticAccessibilityTreeIfNeeded):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h: Added.
- accessibility/isolatedtree: Added.
- accessibility/isolatedtree/AXIsolatedTree.cpp: Added.
(WebCore::AXIsolatedTree::treeCache):
(WebCore::AXIsolatedTree::AXIsolatedTree):
(WebCore::AXIsolatedTree::create):
(WebCore::AXIsolatedTree::treeForID):
(WebCore::AXIsolatedTree::treeForPageID):
(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::rootNode):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::appendNodeChanges):
(WebCore::AXIsolatedTree::applyPendingChanges):
- accessibility/isolatedtree/AXIsolatedTree.h: Added.
(WebCore::AXIsolatedTree::treeIdentifier const):
- accessibility/isolatedtree/AXIsolatedTreeNode.cpp: Added.
To note: we don't mark the attribute map const because even though attributes don't change after initial creation,
we may copy an existing node and replace specific values.
(WebCore::AXIsolatedTreeNode::AXIsolatedTreeNode):
(WebCore::AXIsolatedTreeNode::create):
(WebCore::AXIsolatedTreeNode::initializeAttributeData):
(WebCore::AXIsolatedTreeNode::setProperty):
(WebCore::AXIsolatedTreeNode::doubleAttributeValue const):
(WebCore::AXIsolatedTreeNode::unsignedAttributeValue const):
(WebCore::AXIsolatedTreeNode::boolAttributeValue const):
(WebCore::AXIsolatedTreeNode::stringAttributeValue const):
(WebCore::AXIsolatedTreeNode::intAttributeValue const):
- accessibility/isolatedtree/AXIsolatedTreeNode.h: Added.
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::associateIsolatedTreeNode):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapperBase isolatedTreeNode]):
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- dom/Document.cpp:
(WebCore::Document::pageID const):
- dom/Document.h:
Source/WebCore/PAL:
AX: Introduce isolated accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
- Configurations/FeatureDefines.xcconfig:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):
Source/WebKitLegacy/mac:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
- Configurations/FeatureDefines.xcconfig:
Tools:
AX: Introduce a static accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=193348
<rdar://problem/47203295>
Reviewed by Ryosuke Niwa.
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Jan 26, 2019:
- 6:10 PM Changeset in webkit [240551] by
-
- 13 edits in trunk/Source
Allow scrolling tree nodes to exist in a detached state
https://bugs.webkit.org/show_bug.cgi?id=193754
Reviewed by Zalan Bujtas.
Source/WebCore:
One of the (questionable?) design decisions of the scrolling tree is that the tree implementation
is hidden behind the ScrollingCoordinator interface. That interface only allowed nodes to exist
in a connected state; attachToStateTree() required a non-zero parent for any node that was not
the root.
This makes it impossible to coordinate the hookup of the scrolling tree across frame boundaries;
the scrolling tree has to have been fully constructed in ancestor frames before subframe nodes
can be attached. This is a significant difference from compositing, where a subframe can create
GraphicsLayers which don't have to be parented right away, and actually get parented later via
a compositing update in the parent frame.
We want to be able to hook up the scrolling tree via the same code paths as GraphicsLayer
connection (anything else is too confusing). So we need to be able to instantiate scrolling
tree nodes in a disconnected state, and attach them later.
To achieve this, add the notion of "unparented" nodes to ScrollingCoordinator and the ScrollingStateTree.
Allow clients to create unparented nodes, which can be attached later. ScrollingCoordinator stores
the roots of unparented subtrees in an owning HashMap. Nodes in unparented trees are still referenced
by m_stateNodeMap, so it's possible to find them and set state on them.
Clean up the ScrollingCoordinator interface to remove "state tree" terminology; the state vs. scrolling tree
is really an implementation detail.
This also removes the special-casing of ScrollingNodeType::Subframe nodes which ScrollingStateTree stored
in m_orphanedSubframeNodes; now the unparenting is controlled by the client.
Currently no code creates unparented nodes so there is no behavior change.
- dom/Document.cpp:
(WebCore::Document::setPageCacheState):
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::createNode):
(WebCore::AsyncScrollingCoordinator::insertNode):
(WebCore::AsyncScrollingCoordinator::unparentNode):
(WebCore::AsyncScrollingCoordinator::unparentChildrenAndDestroyNode):
(WebCore::AsyncScrollingCoordinator::detachAndDestroySubtree):
(WebCore::AsyncScrollingCoordinator::clearAllNodes):
(WebCore::AsyncScrollingCoordinator::parentOfNode const):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::attachToStateTree): Deleted.
(WebCore::AsyncScrollingCoordinator::detachFromStateTree): Deleted.
(WebCore::AsyncScrollingCoordinator::clearStateTree): Deleted.
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::handleWheelEvent):
(WebCore::ScrollingCoordinator::createNode):
(WebCore::ScrollingCoordinator::insertNode):
(WebCore::ScrollingCoordinator::unparentNode):
(WebCore::ScrollingCoordinator::unparentChildrenAndDestroyNode):
(WebCore::ScrollingCoordinator::detachAndDestroySubtree):
(WebCore::ScrollingCoordinator::clearAllNodes):
(WebCore::ScrollingCoordinator::parentOfNode const):
(WebCore::ScrollingCoordinator::childrenOfNode const):
(WebCore::ScrollingCoordinator::attachToStateTree): Deleted.
(WebCore::ScrollingCoordinator::detachFromStateTree): Deleted.
(WebCore::ScrollingCoordinator::clearStateTree): Deleted.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeFromParent):
(WebCore::ScrollingStateNode::removeChild):
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::createUnparentedNode):
(WebCore::ScrollingStateTree::insertNode):
(WebCore::ScrollingStateTree::unparentNode):
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
(WebCore::ScrollingStateTree::detachAndDestroySubtree):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
(showScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode): Deleted.
(WebCore::ScrollingStateTree::detachNode): Deleted.
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::nodeCount const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::RenderLayerCompositor::attachScrollingNode):
Source/WebKit:
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
- 3:54 PM Changeset in webkit [240550] by
-
- 5 edits in trunk
Web Inspector: handle CSS Color 4 color syntaxes
https://bugs.webkit.org/show_bug.cgi?id=193166
<rdar://problem/47062403>
Reviewed by Simon Fraser.
Source/WebInspectorUI:
- UserInterface/Models/Color.js:
(WI.Color.fromString):
(WI.Color.fromString.splitFunctionString): Added.
(WI.Color.fromString.parseFunctionAlpha): Added.
(WI.Color.fromString.parseFunctionComponent): Added.
(WI.Color.fromString.parseHueComponent): Added.
(WI.Color.fromString.parsePercentageComponent): Added.
LayoutTests:
- inspector/model/color.html:
- inspector/model/color-expected.txt:
- 2:32 PM Changeset in webkit [240549] by
-
- 13 edits2 adds in trunk
Web Inspector: provide a way to edit the user agent of a remote target
https://bugs.webkit.org/show_bug.cgi?id=193862
<rdar://problem/47359292>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/Page.json:
Add
overrideUserAgentcommand.
Source/WebCore:
Test: inspector/page/overrideUserAgent.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgent const):
(WebCore::FrameLoader::userAgentForJavaScript const):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::applyUserAgentOverride): Added.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): Added.
- inspector/agents/InspectorPageAgent.h:
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideUserAgent): Added.
(WebCore::InspectorPageAgent::applyUserAgentOverride): Added.
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
(WI.initializeTarget):
(WI._handleDeviceSettingsToolbarButtonClicked):
(WI._handleDeviceSettingsToolbarButtonClicked.updateActivatedState):
(WI._handleDeviceSettingsToolbarButtonClicked.applyOverriddenUserAgent):
(WI._handleDeviceSettingsToolbarButtonClicked.applyOverriddenSetting):
(WI._handleDeviceSettingsToolbarButtonClicked.createContainer):
(WI._handleDeviceSettingsToolbarButtonClicked.createColumns):
(WI._handleDeviceSettingsToolbarButtonClicked.calculateTargetFrame):
(WI._handleDeviceSettingsToolbarButtonClicked.showUserAgentInput):
- UserInterface/Views/Main.css:
(.device-settings-content):
(.device-settings-content .user-agent-value): Added.
(.device-settings-content .user-agent-value > select): Added.
(.device-settings-content .user-agent-value > input): Added.
(body[dir=ltr] .device-settings-content .user-agent-value > input): Added.
(body[dir=rtl] .device-settings-content .user-agent-value > input): Added.
(.device-settings-content label > input): Added.
(body[dir=ltr] .device-settings-content label > input): Deleted.
(body[dir=rtl] .device-settings-content label > input): Deleted.
- Localizations/en.lproj/localizedStrings.js:
LayoutTests:
- inspector/page/overrideUserAgent.html: Added.
- inspector/page/overrideUserAgent-expected.txt: Added.
- 12:00 PM Changeset in webkit [240548] by
-
- 1 edit1 copy3 moves in trunk/LayoutTests
Move scrolling-tree/fixed-inside-frame.html into scrolling tree tests
https://bugs.webkit.org/show_bug.cgi?id=193871
Reviewed by Zalan Bujtas.
Move another test into scrollingcoordinator/scrolling-tree, and now that it runs on iOS,
add iOS results.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: Copied from LayoutTests/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt.
- scrollingcoordinator/scrolling-tree/fixed-inside-frame-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt.
- scrollingcoordinator/scrolling-tree/fixed-inside-frame.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/fixed-inside-frame.html.
- scrollingcoordinator/scrolling-tree/resources/autoscrolling-frame-with-fixed.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/resources/autoscrolling-frame-with-fixed.html.
- 11:24 AM Changeset in webkit [240547] by
-
- 5 edits2 adds in trunk
Source/WebCore:
[LFC] The initial values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
https://bugs.webkit.org/show_bug.cgi?id=193867
Reviewed by Antti Koivisto.
The initial content top/bottom value is the border top + padding top.
This is only a problem when the box has float children only. While computing the height using the bottom-most float,
we call "top = std::min(floatTop, top)". With 0 initial top value, this returns an incorrect result when the box
has (top)border/padding.
Test: fast/block/block-only/abs-pos-with-border-padding-and-float-child.html
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):
Tools:
[LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
https://bugs.webkit.org/show_bug.cgi?id=193867
Reviewed by Antti Koivisto.
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
[LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
https://bugs.webkit.org/show_bug.cgi?id=193867
Reviewed by Antti Koivisto.
- fast/block/block-only/abs-pos-with-border-padding-and-float-child-expected.html: Added.
- fast/block/block-only/abs-pos-with-border-padding-and-float-child.html: Added.
- 10:14 AM Scrolling created by
- 10:08 AM WikiStart edited by
- (diff)
- 7:01 AM Changeset in webkit [240546] by
-
- 7 edits2 adds in trunk
[LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
https://bugs.webkit.org/show_bug.cgi?id=193865
Reviewed by Antti Koivisto.
Source/WebCore:
Height computation ->
10.6.3 Block-level non-replaced elements in normal flow when 'overflow' computes to 'visible'
...the bottom edge of the bottom (possibly collapsed) margin of its last in-flow child, if the child's bottom
margin does not collapse with the element's bottom margin
<div style="border: 1px solid green">
<div style="margin-top: 100px;"></div>
</div>
When the child vertical margins collapse through (margin-top = margin-bottom = 100px), the bottom edge of the bottom margin is
the same as the bottom edge of the top margin which is alredy taken into use while positioning so technically the bottom margin value should be ignored.
Test: fast/block/margin-collapse/collapsed-through-child-simple.html
- layout/MarginTypes.h:
(WebCore::Layout::UsedVerticalMargin::isCollapsedThrough const):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::hasCollapsedThroughMargin const):
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
- fast/block/margin-collapse/collapsed-through-child-simple-expected.html: Added.
- fast/block/margin-collapse/collapsed-through-child-simple.html: Added.
- 5:13 AM Changeset in webkit [240545] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] marginAfterCollapsesWithParentMarginAfter/marginAfterCollapsesWithLastInFlowChildMarginAfter should check for border/padding after values.
https://bugs.webkit.org/show_bug.cgi?id=193864
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter):
- 4:44 AM Changeset in webkit [240544] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Box::nextInFlowOrFloatingSibling() should always return sibling floats as well.
https://bugs.webkit.org/show_bug.cgi?id=193855
Reviewed by Antti Koivisto.
Use iterative algorithm to find next/previous siblings.
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::nextInFlowOrFloatingSibling const):
- 1:07 AM Changeset in webkit [240543] by
-
- 21 edits2 adds in trunk
[JSC] NativeErrorConstructor should not have own IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=193713
Reviewed by Saam Barati.
JSTests:
Remove @Error use.
- stress/try-get-by-id-should-spill-registers-dfg.js:
(let.f.createBuiltin):
Source/JavaScriptCore:
This removes an additional member in NativeErrorConstructor, and make sizeof(NativeErrorConstructor) == sizeof(InternalFunction).
We also make error constructors lazily allocated by using LazyClassStructure. Since error structures are not accessed from DFG / FTL
threads, this is OK. While TypeError constructor is eagerly allocated because it is touched from our builtin JS as @TypeError, we should
offer some function instead of exposing TypeError constructor in the future, and remove this @TypeError reference. This change removes
IsoSubspace for NativeErrorConstructor in VM. We also remove @Error and @RangeError references for builtins since they are no longer
referenced.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- builtins/BuiltinNames.h:
- interpreter/Interpreter.h:
- runtime/Error.cpp:
(JSC::createEvalError):
(JSC::createRangeError):
(JSC::createReferenceError):
(JSC::createSyntaxError):
(JSC::createTypeError):
(JSC::createURIError):
(WTF::printInternal): Deleted.
- runtime/Error.h:
- runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::create):
(JSC::ErrorPrototype::finishCreation):
- runtime/ErrorPrototype.h:
(JSC::ErrorPrototype::create): Deleted.
- runtime/ErrorType.cpp: Added.
(JSC::errorTypeName):
(WTF::printInternal):
- runtime/ErrorType.h: Added.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::initializeErrorConstructor):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::internalPromiseConstructor const):
(JSC::JSGlobalObject::errorStructure const):
(JSC::JSGlobalObject::evalErrorConstructor const): Deleted.
(JSC::JSGlobalObject::rangeErrorConstructor const): Deleted.
(JSC::JSGlobalObject::referenceErrorConstructor const): Deleted.
(JSC::JSGlobalObject::syntaxErrorConstructor const): Deleted.
(JSC::JSGlobalObject::typeErrorConstructor const): Deleted.
(JSC::JSGlobalObject::URIErrorConstructor const): Deleted.
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor<errorType>::NativeErrorConstructor):
(JSC::NativeErrorConstructorBase::finishCreation):
(JSC::NativeErrorConstructor<errorType>::constructNativeErrorConstructor):
(JSC::NativeErrorConstructor<errorType>::callNativeErrorConstructor):
(JSC::NativeErrorConstructor::NativeErrorConstructor): Deleted.
(JSC::NativeErrorConstructor::finishCreation): Deleted.
(JSC::NativeErrorConstructor::visitChildren): Deleted.
(JSC::Interpreter::constructWithNativeErrorConstructor): Deleted.
(JSC::Interpreter::callNativeErrorConstructor): Deleted.
- runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructorBase::createStructure):
(JSC::NativeErrorConstructorBase::NativeErrorConstructorBase):
- runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::finishCreation): Deleted.
- runtime/NativeErrorPrototype.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::handleBadI64Use):
Jan 25, 2019:
- 11:29 PM Changeset in webkit [240542] by
-
- 4 edits in trunk/Source/WebKit
REGRESSION (r238818): Snapshot is removed too late after swiping back on Twitter
https://bugs.webkit.org/show_bug.cgi?id=193860
<rdar://problem/47535022>
Reviewed by Antti Koivisto.
- UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::didStartProvisionalOrSameDocumentLoadForMainFrame):
(WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
(WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
- UIProcess/Cocoa/ViewGestureController.h:
Treat provisional load and same document load the same: they already both
unpause the snapshot removal tracker, request render tree size notifications,
but same-document navigation was missing the call to dispatchAfterEnsuringDrawing
and thus would get stuck waiting for RepaintAfterNavigation.
- 10:50 PM Changeset in webkit [240541] by
-
- 14 edits in trunk
Need a mechanism to override navigator.userAgent
https://bugs.webkit.org/show_bug.cgi?id=193762
<rdar://problem/47504939>
Reviewed by Brent Fulgham.
Source/WebCore:
Added the ability to specify user agent string just for navigator.userAgent via DocumentLoader.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setCustomJavaScriptUserAgent):
(WebCore::DocumentLoader::customJavaScriptUserAgent const):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::userAgentForJavaScript const):
- loader/FrameLoader.h:
- page/Navigator.cpp:
(WebCore::Navigator::userAgent const):
Source/WebKit:
This patch adds a new _WKWebsitePolicies SPI to specify the user agent string returned by
navigator.userAgent without affecting the user agent string used to send network requests.
Tests: WebKit.WebsitePoliciesCustomJavaScriptUserAgent
WebKit.WebsitePoliciesCustomUserAgents
- Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
- Shared/WebsitePoliciesData.h:
- UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::data):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setCustomJavaScriptUserAgent:]):
(-[_WKWebsitePolicies customJavaScriptUserAgent]):
Tools:
Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
- 7:57 PM Changeset in webkit [240540] by
-
- 25 edits3 adds in trunk
Web Inspector: provide a way to edit page settings on a remote target
https://bugs.webkit.org/show_bug.cgi?id=193813
<rdar://problem/47359510>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/Page.json:
Add
overrideSettingcommand with supportingSettingenum type.
Source/WebCore:
Test: inspector/page/overrideSetting.html
- page/Settings.yaml:
- Scripts/GenerateSettings.rb:
- Scripts/SettingsTemplates/Settings.cpp.erb:
- Scripts/SettingsTemplates/Settings.h.erb:
Add support for an
inspectorOverrideboolean value for each setting that will take
precedence over the actualSetting's value when set.
- inspector/agents/InspectorPageAgent.h:
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::overrideSetting): Added.
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isRemote const): Added.
- inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::isRemote const): Added.
- inspector/InspectorFrontendClientLocal.h:
(WebCore::InspectorFrontendClientLocal::isRemote const): Added.
Source/WebInspectorUI:
Add toolbar button that shows a popover with the target's (page's) settings when clicked.
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
(WI.initializeTarget): Added.
(WI._handleDeviceSettingsToolbarButtonClicked): Added.
(WI.didDismissPopover): Added.
- UserInterface/Views/Main.css:
(.device-settings-content): Added.
(.device-settings-content .columns): Added.
(.device-settings-content .columns > .column): Added.
(.device-settings-content .columns > .column + .column): Added.
(body[dir=ltr] .device-settings-content label > input): Added.
(body[dir=rtl] .device-settings-content label > input): Added.
- UserInterface/Views/Popover.js:
(WI.Popover.prototype._update.area):
(WI.Popover.prototype._update):
(WI.Popover.prototype._drawBackground):
(WI.Popover.prototype._bestMetricsForEdge):
(WI.Popover.prototype._drawFrame):
If the best area is negative, treat it as the worst area.
Allow areas to be clamped so long as the clamped edge is not the preferred edge.
- UserInterface/Base/Test.js:
(WI.initializeTarget): Added.
- UserInterface/Images/Device.svg: Added.
- Localizations/en.lproj/localizedStrings.js:
Source/WebKit:
- WebProcess/WebPage/WebInspectorUI.h:
(WebKit::WebInspectorUI::isRemote() const): Added.
- WebProcess/WebPage/RemoteWebInspectorUI.h:
(WebKit::RemoteWebInspectorUI::isRemote() const): Added.
LayoutTests:
- inspector/page/overrideSetting.html: Added.
- inspector/page/overrideSetting-expected.txt: Added.
- 7:38 PM Changeset in webkit [240539] by
-
- 3 edits in trunk/Source/WebCore
Document::updateMainArticleElementAfterLayout() should be a no-op when no client depends on knowing the main article element
https://bugs.webkit.org/show_bug.cgi?id=193843
Reviewed by Zalan Bujtas.
- dom/Document.cpp:
(WebCore::Document::updateMainArticleElementAfterLayout):
This function currently does a bit of wasted work after every layout, on clients that don't listen to the
"significant rendered text" layout milestone and therefore don't need to guess the main article element. Simply
don't bother keeping the main article element up to date in this scenario by bailing from
FrameView::updateHasReachedSignificantRenderedTextThreshold if the client doesn't care about the significant
rendered text milestone.
- page/FrameView.cpp:
(WebCore::FrameView::updateHasReachedSignificantRenderedTextThreshold):
- 7:24 PM Changeset in webkit [240538] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Audit: unable to import audits
https://bugs.webkit.org/show_bug.cgi?id=193861
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.async processJSON):
- 5:46 PM Changeset in webkit [240537] by
-
- 4 edits2 adds in trunk
<video> elements not in the DOM should be allowed to AirPlay
https://bugs.webkit.org/show_bug.cgi?id=193837
Source/WebCore:
<rdar://42559491>
Reviewed by Eric Carlson.
Test: media/airplay-allows-buffering.html
Some websites will switch between <video> elements backed by MSE to one backed by
a media file in order to implement an AirPlay control. But when a <video> element is
removed from the DOM and paused, further buffering is blocked. For some ports (namely
Cocoa ones), this keeps AirPlay from engaging. Relax this buffering restriction for
elements who have been asked to play wirelessly, but whose wireless playback has not
started yet.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::dataBufferingPermitted const):
(WebCore::MediaElementSession::setShouldPlayToPlaybackTarget):
LayoutTests:
Reviewed by Eric Carlson.
- media/airplay-allows-buffering-expected.txt: Added.
- media/airplay-allows-buffering.html: Added.
- platform/ios/TestExpectations:
- 5:40 PM Changeset in webkit [240536] by
-
- 3 edits1 copy in trunk/LayoutTests
Fix failing scrollingcoordinator/scrolling-tree/remove-scrolling-role.html
Test needed different macOS and iOS results. Added window.internals.settings.setAsyncOverflowScrollingEnabled(true)
so the test uses async overflow scrolling in the macOS result.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt.
- scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
- scrollingcoordinator/scrolling-tree/remove-scrolling-role.html:
- 5:40 PM Changeset in webkit [240535] by
-
- 1 edit4 adds in trunk/LayoutTests
Add a scrolling tree test that toggles scrollability on an intermediate iframe
https://bugs.webkit.org/show_bug.cgi?id=193849
Reviewed by Dean Jackson.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/resources/scroll-toggling-frame.html: Added.
- scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/toggle-coordinated-frame-scrolling.html: Added.
- 5:06 PM Changeset in webkit [240534] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: No node with given id found
https://bugs.webkit.org/show_bug.cgi?id=193833
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype.layout):
(WI.CanvasContentView.prototype._refreshPixelSize):
Drive-by: show the refresh button when viewing a specific canvas.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype._removeCanvas):
Reset to the overview if the canvas is removed.
- 5:00 PM Changeset in webkit [240533] by
-
- 5 edits in trunk
REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
https://bugs.webkit.org/show_bug.cgi?id=193831
<rdar://problem/47399263>
Reviewed by Chris Dumez.
Source/WebKit:
A System Preview (<a rel="ar">) displays in a modal and doesn't trigger
a navigation. If the link was cross origin, it was causing a process swap,
which meant that the response defaulted back to a navigation.
The fix is to not cause a PSON when the navigation is a system preview.
- UIProcess/API/APINavigation.h:
(API::Navigation::shouldForceDownload const): This is now just tracking
the "download" attribute, and not including System Preview.
(API::Navigation::isSystemPreview const): New method to check for a
navigation triggered as a System Preview.
- UIProcess/WebPageProxy.cpp: Move the code from receivedPolicyDecision to
receivedNavigationPolicyDecision, so that downloads and System Previews are
detected before we decide to change process.
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
Tools:
Two new tests that exercise cross-origin and same-origin System
Previews.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 4:54 PM Changeset in webkit [240532] by
-
- 2 edits in trunk/LayoutTests
Remove expectation for inspector/css/createStyleSheet.html as test appears to be passing.
https://bugs.webkit.org/show_bug.cgi?id=148636
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:44 PM Changeset in webkit [240531] by
-
- 2 edits in trunk/Source/WebKit
Find-in-page on nyt.com scrolls around without touching the screen when find holes are visible
https://bugs.webkit.org/show_bug.cgi?id=193853
Reviewed by Simon Fraser.
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator):
There is no reason to scroll/zoom to the find indicator just because the
holes are up, we should only do it on initial indicator presentation.
This was a mistake in r178755 that was previously never exercised because
isShowingOverlay was always false.
- 4:44 PM Changeset in webkit [240530] by
-
- 32 edits1 copy1 add3 deletes in trunk
[iOS] Add support for the download attribute
https://bugs.webkit.org/show_bug.cgi?id=167341
<rdar://problem/30296281>
Reviewed by Geoffrey Garen.
Source/WTF:
Turn on HTML download attribute support on iOS.
- wtf/FeatureDefines.h:
LayoutTests:
Make download attribute layout tests iOS-friendly and unskip them now that they pass.
- fast/dom/HTMLAnchorElement/anchor-download-unset.html:
- fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-async-delegate.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-base-target-popup-not-allowed.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target-popup-not-allowed.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-blank-target.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
- fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
- fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
- fast/dom/HTMLAnchorElement/anchor-nodownload.html:
- http/tests/download/anchor-download-attribute-content-disposition.html:
- http/tests/download/anchor-download-no-extension.html:
- http/tests/download/anchor-download-no-value.html:
- http/tests/download/anchor-download-redirect.html:
- http/tests/download/area-download.html:
- http/tests/download/convert-cached-load-to-download.html:
- http/tests/security/anchor-download-allow-blob.html:
- http/tests/security/anchor-download-allow-data.html:
- http/tests/security/anchor-download-allow-sameorigin.html:
- http/tests/security/anchor-download-block-crossorigin-expected.txt:
- http/tests/security/anchor-download-block-crossorigin.html:
- platform/ios-wk2/TestExpectations:
- platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt: Copied from LayoutTests/http/tests/security/anchor-download-block-crossorigin-expected.txt.
- 4:18 PM Changeset in webkit [240529] by
-
- 4 edits in tags/Safari-608.1.2.1/Source
Cherry-pick r240461. rdar://problem/47518428
[iOS] Silence MediaPlayer compile warnings
https://bugs.webkit.org/show_bug.cgi?id=193780
<rdar://problem/47518428>
Reviewed by Jer Noble.
Source/WebCore/PAL:
- pal/spi/ios/MediaPlayerSPI.h:
Source/WebKit:
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:09 PM Changeset in webkit [240528] by
-
- 7 edits in tags/Safari-608.1.2.1/Source
Versioning.
- 4:05 PM Changeset in webkit [240527] by
-
- 1 copy in tags/Safari-608.1.2.1
New tag.
- 4:02 PM Changeset in webkit [240526] by
-
- 4 edits in branches/safari-607-branch
Cherry-pick r240335. rdar://problem/47494779
2019-01-23 David Kilzer <ddkilzer@apple.com>
[JSC] Duplicate global variables: JSC::opcodeLengths
<https://webkit.org/b/193714>
<rdar://problem/47340200>
Reviewed by Mark Lam.
- bytecode/Opcode.cpp: (JSC::opcodeLengths): Move array implementation here and mark const.
- bytecode/Opcode.h: (JSC::opcodeLengths): Change to extern declaration.
- 3:52 PM Changeset in webkit [240525] by
-
- 9 edits5 adds in trunk
Update Xcode projects with "Check .xcfilelists" build phase
https://bugs.webkit.org/show_bug.cgi?id=193790
<rdar://problem/47201374>
Reviewed by Alex Christensen.
Support for XCBuild includes specifying inputs and outputs to various
Run Script build phases. These inputs and outputs are specified as
.xcfilelist files. Once created, these .xcfilelist files need to be
kept up-to-date. In order to check that they are up-to-date or not,
add an Xcode build step that invokes an external script that performs
the checking. If the .xcfilelists are found to be out-of-date, update
them, halt the build, and instruct the developer to restart the build
with up-to-date files.
At this time, the checking and regenerating is performed only if the
WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
who want to use this facility can set this variable and test out the
checking/regenerating. Once it seems like there are no egregious
issues that upset a developer's workflow, we'll unconditionally enable
this facility.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/check-xcfilelists.sh: Added.
Source/WebCore:
No new tests since there should be no observable behavior difference.
- Scripts/check-xcfilelists.sh: Added.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- Scripts/check-xcfilelists.sh: Added.
- WebKit.xcodeproj/project.pbxproj:
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
- WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 3:49 PM Changeset in webkit [240524] by
-
- 4 edits1 copy in branches/safari-607-branch
Cherry-pick r240329. rdar://problem/47458354
This is for a follow up fix that was missed in the cherry-pick for rdar://problem/47458354.
2019-01-22 Yusuke Suzuki <ysuzuki@apple.com>
Unreviewed, fix initial global lexical binding epoch
https://bugs.webkit.org/show_bug.cgi?id=193603
<rdar://problem/47380869>
JSTests:
- stress/global-lexical-binding-epoch-should-be-correct-one.js: Added. (f1.f2.f3.f4): (f1.f2.f3): (f1.f2): (f1):
Source/JavaScriptCore:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::finishCreation):
- 3:48 PM Changeset in webkit [240523] by
-
- 1 copy in tags/Safari-607.1.28
Tag Safari-607.1.28.
- 3:45 PM Changeset in webkit [240522] by
-
- 9 edits in trunk/Source
Web Inspector: Exclude Debugger Threads from CPU Usage values in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=193796
<rdar://problem/47532910>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-25
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::machThread):
- runtime/SamplingProfiler.h:
Expose the mach_port_t of the SamplingProfiler thread
so it can be tested against later.
Source/WebCore:
- page/ResourceUsageData.h:
- inspector/agents/InspectorCPUProfilerAgent.cpp:
(WebCore::InspectorCPUProfilerAgent::collectSample):
Show the CPU usage without debugger threads in the Web Inspector's timeline.
- page/ResourceUsageThread.h:
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting):
For OS(DARWIN) ports, when starting to observe resource usage,
we grab the mach_port_t of SamplingProfiler on the main thread
in a thread safe way. For our purposes (Web Inspector timelines),
this will be good enough to identify the SamplingProfiler thread
during timeline recording. The SamplingProfiler thread won't change
during a timeline recording and recording start/stops will never
miss the SamplingProfiler changing.
(WebCore::filterThreads):
(WebCore::threadSendRights):
(WebCore::threadSendRightsExcludingDebuggerThreads):
(WebCore::cpuUsage):
(WebCore::ResourceUsageThread::platformCollectCPUData):
Calculate CPU usage twice, the second time excluding some threads.
- page/linux/ResourceUsageThreadLinux.cpp:
(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting):
(WebCore::ResourceUsageThread::platformCollectCPUData):
Stubs for linux ports.
- 3:44 PM Changeset in webkit [240521] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix Windows build after r240511
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- 3:41 PM Changeset in webkit [240520] by
-
- 6 edits in trunk/Source
Move logic from ChildProcess::setApplicationIsDaemon to NetworkProcess::initializeProcess
https://bugs.webkit.org/show_bug.cgi?id=193844
Reviewed by Andy Estes.
Source/WebCore/PAL:
- pal/spi/mac/HIServicesSPI.h:
Source/WebKit:
This simplifies ChildProcess and removes NetworkProcess-specific code from this generic abstraction.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeProcess):
- Shared/ios/ChildProcessIOS.mm:
(WebKit::ChildProcess::setApplicationIsDaemon): Deleted.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setApplicationIsDaemon): Deleted.
- 3:40 PM Changeset in webkit [240519] by
-
- 3 edits in trunk/Source/WebCore
Remove FrameView::m_significantRenderedTextMilestonePending
https://bugs.webkit.org/show_bug.cgi?id=193842
Reviewed by Wenson Hsieh.
Currently we keep processing the incoming text content until after the "SignificantRenderedTextMilestone" has been reached.
We can actually stop doing it right when the text content is above the threshold (regardless of whether all the conditions are met for the milestone).
This patch also ensures that we don't update Document::m_mainArticleElement once the threshold is reached.
- page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::hasReachedSignificantRenderedTextThreashold):
(WebCore::FrameView::qualifiesAsSignificantRenderedText const):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded): Deleted.
- page/FrameView.h:
- 3:31 PM Changeset in webkit [240518] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve Dark Mode appearance within Memory timeline
https://bugs.webkit.org/show_bug.cgi?id=193804
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-25
Reviewed by Matt Baker.
- UserInterface/Views/TimelineOverview.css:
(.timeline-overview.edit-instruments > .tree-outline.timelines .item.selected):
(.timeline-overview > .tree-outline.timelines .item.selected + .item,):
(@media (prefers-color-scheme: dark)):
(.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
(body.window-inactive .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
Fix some colors for Timelines edit mode.
- UserInterface/Views/CPUTimelineOverviewGraph.css:
(.timeline-overview-graph.cpu:nth-child(even) > .legend):
(@media (prefers-color-scheme: dark)):
(.timeline-overview-graph.cpu > .legend):
(.timeline-overview-graph:nth-child(even) > .legend): Deleted.
- UserInterface/Views/MemoryTimelineOverviewGraph.css:
(.timeline-overview-graph.memory:nth-child(even) > .legend):
(@media (prefers-color-scheme: dark)):
(.timeline-overview-graph.memory > .legend):
(.timeline-overview-graph:nth-child(even) > .legend): Deleted.
Improved colors in CPU / Memory overview graph legends.
- UserInterface/Views/CPUUsageView.css:
(.cpu-usage-view > .details):
- UserInterface/Views/CircleChart.css:
(.circle-chart > svg > path.background):
- UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view > .details):
(.memory-category-view > .details > .name):
- UserInterface/Views/MemoryTimelineView.css:
(.timeline-view.memory > .content > .overview .total-usage,):
(.timeline-view.memory .legend > .row > .size):
Improved colors in CPU / Memory detail views.
- UserInterface/Views/Variables.css:
(:root):
Add a default --text-secondary-color which will end up slightly
lighter in dark mode where it was already implemented.
(@media (prefers-color-scheme: dark)):
Improved max-comparison colors.
- 3:19 PM Changeset in webkit [240517] by
-
- 9 edits in trunk
Update Xcode projects with "Apply Configuration to XCFileLists" build target
https://bugs.webkit.org/show_bug.cgi?id=193781
<rdar://problem/47201153>
Reviewed by Alex Christensen.
Part of generating the .xcfilelists used as part of adopting XCBuild
includes runningmake DerivedSources.makefrom a standalone script.
It’s important for this invocation to have the same environment as
when the actual build invokesmake DerivedSources.make. If the
environments are different, then the two invocations will provide
different results. In order to get the same environment in the
standalone script, have the script launch xcodebuild targeting the
"Apply Configuration to XCFileLists" build target, which will then
re-invoke our standalone script. The script is now running again, this
time in an environment with all workspace, project, target, xcconfig
and other environment variables established.
The "Apply Configuration to XCFileLists" build target accomplishes
this task via a small embedded shell script that consists only of:
eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
The process that invokes "Apply Configuration to XCFileLists" first
sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
evaluated and exports it into the shell environment. When xcodebuild
is invoked, it inherits the value of this variable and canevalthe
contents of that variable. Our external standalone script can then set
WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
of command-line parameters needed to restart itself in the appropriate
state.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
No new tests since there should be no observable behavior difference.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 3:16 PM Changeset in webkit [240516] by
-
- 8 edits in trunk
Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193802
<rdar://problem/46010580>
Reviewed by Andy Estes.
Source/WebKit:
- UIProcess/API/APIUIClient.h:
(API::UIClient::didClickGoBackFromSafeBrowsingWarning):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didClickGoBackFromSafeBrowsingWarning):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
(TEST):
- 3:16 PM Changeset in webkit [240515] by
-
- 2 edits in trunk/LayoutTests
[ iOS Simulator Release ] Layout Test fast/animation/request-animation-frame.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=190888
Unreviewed test gardening.
Patch by Shawn Roberts <Shawn Roberts> on 2019-01-25
- platform/ios-wk2/TestExpectations:
- 3:12 PM Changeset in webkit [240514] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Pressing Tab key doesn't move to next cell with Google Sheets
https://bugs.webkit.org/show_bug.cgi?id=193048
<rdar://problem/46433836>
Reviewed by Brent Fulgham.
WebCore knows how interpret the Tab and Shift + Tab keys. When building with UIKit keyboard additions
we do not need to register key commands for handling them from the UIProcess code. Instead UIKit will
sends key events for these commands to us. This will make the behavior of these key commands when executed
in an editable field match the behavior of these command when executed in a non-editable field since
both code paths will now go through WebCore.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView keyCommands]): Only compile when building with !USE(UIKIT_KEYBOARD_ADDITIONS).
- 2:57 PM Changeset in webkit [240513] by
-
- 2 edits in trunk/Source/WebKit
Fix Linux build.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::requestResourceLoadStatisticsUpdate):
- 2:35 PM Changeset in webkit [240512] by
-
- 8 edits in trunk
[iOS] uiController.keyDown() does not translate Control modified key
https://bugs.webkit.org/show_bug.cgi?id=192898
Reviewed by Wenson Hsieh.
Tools:
Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
key translation, as applicable. Among other cases, key translation occurs when performing
a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
also makes the behavior of uiController.keyDown() more closely match the behavior of a
human pressing down and releasing key(s) using a hardware keyboard.
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
(-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
(-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
(-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
(-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
(-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
(-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator longPress:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
Update code for above renaming.
(hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
(-[HIDEventGenerator keyDown:]): Added.
(-[HIDEventGenerator keyUp:]): Added.
(-[HIDEventGenerator keyPress:completionBlock:]):
(-[HIDEventGenerator eventDispatchThreadEntry:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
(WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
(WTR::parseModifier): Deleted.
LayoutTests:
Make tests more robusts.
- fast/events/ios/key-command-italic-dispatches-keydown.html: Remove the need to special-case the test runner and
expect a single key event that represents Command + I. Now that uiController.keyDown() makes use of HIDEventGenerator
we emit separate key events for each key pressed in the sequence: keydown Command, keydown i, keyup i, keyup Command.
This matches how a human being would execute such a key sequence.
- fast/forms/auto-fill-button/caps-lock-indicator-should-not-be-visible-when-auto-fill-strong-password-button-is-visible-expected.html:
Make the test less flaky by hiding the tap highlight. Depending on timing, the tap highlight may be snapshotted and thus
cause the reference test to mismatch the test. Mitigate this by hiding the tap highlight.
- fast/text/scroll-text-overflow-ellipsis.html: Wait for a keyup event for the down arrow before declaring the
test complete.
- 2:31 PM Changeset in webkit [240511] by
-
- 21 edits2 copies in trunk/Source/JavaScriptCore
Add API to generate and consume cached bytecode
https://bugs.webkit.org/show_bug.cgi?id=193401
<rdar://problem/47514099>
Reviewed by Keith Miller.
Add the
generateBytecodeandgenerateModuleBytecodefunctions to
generate serialized bytecode for a givenSourceCode. These functions
will eagerly generate code for all the nested functions.
Additionally, update the API methods in JSScript to generate and use the
bytecode when the bytecodeCache path is provided.
- API/JSAPIGlobalObject.mm:
(JSC::JSAPIGlobalObject::moduleLoaderFetch):
- API/JSContext.mm:
(-[JSContext wrapperMap]):
- API/JSContextInternal.h:
- API/JSScript.mm:
(+[JSScript scriptWithSource:inVirtualMachine:]):
(+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
(-[JSScript dealloc]):
(-[JSScript readCache]):
(-[JSScript writeCache]):
(-[JSScript hash]):
(-[JSScript source]):
(-[JSScript cachedBytecode]):
(-[JSScript jsSourceCode:]):
- API/JSScriptInternal.h:
- API/JSScriptSourceProvider.h: Copied from Source/JavaScriptCore/API/JSScriptInternal.h.
(JSScriptSourceProvider::create):
(JSScriptSourceProvider::JSScriptSourceProvider):
- API/JSScriptSourceProvider.mm: Copied from Source/JavaScriptCore/API/JSScriptInternal.h.
(JSScriptSourceProvider::hash const):
(JSScriptSourceProvider::source const):
(JSScriptSourceProvider::cachedBytecode const):
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine vm]):
- API/JSVirtualMachineInternal.h:
- API/tests/testapi.mm:
(testBytecodeCache):
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):
(testObjectiveCAPI):
- JavaScriptCore.xcodeproj/project.pbxproj:
- SourcesCocoa.txt:
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/SourceCodeKey.h:
(JSC::SourceCodeKey::source const):
- parser/SourceProvider.h:
(JSC::CachedBytecode::CachedBytecode):
(JSC::CachedBytecode::operator=):
(JSC::CachedBytecode::data const):
(JSC::CachedBytecode::size const):
(JSC::CachedBytecode::owned const):
(JSC::CachedBytecode::~CachedBytecode):
(JSC::CachedBytecode::freeDataIfOwned):
(JSC::SourceProvider::cachedBytecode const):
- parser/UnlinkedSourceCode.h:
(JSC::UnlinkedSourceCode::provider const):
- runtime/CodeCache.cpp:
(JSC::generateUnlinkedCodeBlockForFunctions):
(JSC::writeCodeBlock):
(JSC::serializeBytecode):
- runtime/CodeCache.h:
(JSC::CodeCacheMap::fetchFromDiskImpl):
(JSC::CodeCacheMap::findCacheAndUpdateAge):
(JSC::generateUnlinkedCodeBlockImpl):
(JSC::generateUnlinkedCodeBlock):
- runtime/Completion.cpp:
(JSC::generateBytecode):
(JSC::generateModuleBytecode):
- runtime/Completion.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- 2:23 PM Changeset in webkit [240510] by
-
- 2 edits in trunk/Tools
Complete the implementation of generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=193782
Reviewed by Alex Christensen.
A preliminary version of generate-xcfilelists was added in r238008.
This patch updates that script in order to:
- Support checking of .xcfilelists
- Perform better execution of
make DerivedSources.makeby relaunching generate-xcfilelists under xcodebuild - Support incremental generation and checking of .xcfilelists
- Support supplementary .xcfilelists files from WebKitAdditions
- Support being wrapped by parallel version of generate-xcfilelists in Internal that adds support for (re)generating WebKit projects in that repo.
- Support builds that have been performed in WebKitBuild as well as ~/Library/Developer/code/DerivedData
- Increase robustness and debugging facilities.
- Scripts/generate-xcfilelists:
- 2:21 PM Changeset in webkit [240509] by
-
- 2 edits in trunk/Tools
Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=193297
<rdar://problem/47158841>
Unreviewed test case fix.
These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
Previously, the default data store turned the feature on automatically, allowing these tests to pass.
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
- 2:19 PM Changeset in webkit [240508] by
-
- 14 edits in trunk/Source
Update WebKitAdditions.xcconfig with correct order of variable definitions
https://bugs.webkit.org/show_bug.cgi?id=193793
<rdar://problem/47532439>
Reviewed by Alex Christensen.
XCBuild changes the way xcconfig variables are evaluated. In short,
all config file assignments are now considered in part of the
evaluation. When using the new build system and an .xcconfig file
contains multiple assignments of the same build setting:
- Later assignments using $(inherited) will inherit from earlier assignments in the xcconfig file.
- Later assignments not using $(inherited) will take precedence over earlier assignments. An assignment to a more general setting will mask an earlier assignment to a less general setting. For example, an assignment without a condition ('FOO = bar') will completely mask an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
This affects some of our .xcconfig files, in that sometimes platform-
or sdk-specific definitions appear before the general definitions.
Under the new evaluations rules, the general definitions alway take
effect because they always overwrite the more-specific definitions. The
solution is to swap the order, so that the general definitions are
established first, and then conditionally overwritten by the
more-specific definitions.
Source/JavaScriptCore:
- Configurations/Version.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/Version.xcconfig:
Source/WebCore:
No new tests since there should be no observable behavior difference.
- Configurations/Base.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit:
- Configurations/BaseTarget.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/Version.xcconfig:
- Configurations/WebKitLegacy.xcconfig:
- 2:16 PM Changeset in webkit [240507] by
-
- 20 edits in trunk
Update existing .xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=193791
<rdar://problem/47201706>
Reviewed by Alex Christensen.
Many .xcfilelist files were added in r238824 in order to support
XCBuild. Update these with recent changes to the set of build files
and with the current generate-xcfilelist script.
Source/JavaScriptCore:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- UnifiedSources-input.xcfilelist:
- UnifiedSources-output.xcfilelist:
Source/WebCore:
No new tests since there should be no observable behavior difference.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- UnifiedSources-input.xcfilelist:
- UnifiedSources-output.xcfilelist:
Source/WebKit:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- UnifiedSources-input.xcfilelist:
- UnifiedSources-output.xcfilelist:
Tools:
- DumpRenderTree/DerivedSources-input.xcfilelist:
- DumpRenderTree/DerivedSources-output.xcfilelist:
- WebKitTestRunner/DerivedSources-input.xcfilelist:
- WebKitTestRunner/DerivedSources-output.xcfilelist:
- 2:05 PM Changeset in webkit [240506] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: DOMContentLoaded and load event lines need to be more obvious
https://bugs.webkit.org/show_bug.cgi?id=193186
<rdar://problem/45100694>
Reviewed by Joseph Pecoraro.
Shift around z-index values to make Timelines markers appear behind record bars. Widen the
marker hit region to make it easier to see the tooltip.
- UserInterface/Views/Variables.css:
(:root):
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler):
(.timeline-ruler > .markers):
(.timeline-ruler > .markers > .marker):
(body[dir=ltr] .timeline-ruler > .markers > .marker):
(body[dir=rtl] .timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker::before):
(body[dir=ltr] .timeline-ruler > .markers > .marker::before):
(body[dir=rtl] .timeline-ruler > .markers > .marker::before):
(.timeline-ruler > .markers > .marker::after): Added.
(body[dir=ltr] .timeline-ruler > .markers > .marker::after): Added.
(body[dir=rtl] .timeline-ruler > .markers > .marker::after): Added.
(.timeline-ruler > .markers > .marker.current-time):
(.timeline-ruler > .markers > .marker.current-time::after): Added.
(.timeline-ruler > .markers > .marker.load-event):
(.timeline-ruler > .markers > .marker.dom-content-event):
(.timeline-ruler > .markers > .marker.timestamp):
(.timeline-ruler > .selection-handle):
(.timeline-ruler.both-handles-clamped > .selection-handle):
(.timeline-ruler > .shaded-area):
(.timeline-ruler > .markers > .marker.current-time::before): Deleted.
- UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar):
(.timeline-record-bar > .segment):
- UserInterface/Views/CPUTimelineOverviewGraph.css:
(.timeline-overview-graph.cpu > .legend):
- UserInterface/Views/MemoryTimelineOverviewGraph.css:
(.timeline-overview-graph.memory > .legend):
- 1:56 PM Changeset in webkit [240505] by
-
- 3 edits1 copy17 moves4 adds2 deletes in trunk/LayoutTests
Move more scrolling tree tests into scrollingcoordinator/scrolling-tree
https://bugs.webkit.org/show_bug.cgi?id=193845
Reviewed by Tim Horton.
Gather more tests of the scrolling tree into scrollingcoordinator/scrolling-tree.
- platform/gtk/TestExpectations:
- platform/ios-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Removed.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt: Added.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt: Copied from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt: Added.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt: Added.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt: Renamed from LayoutTests/platform/ios/fast/scrolling/scrolling-tree-includes-frame-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt: Renamed from LayoutTests/platform/ios-wk2/fast/scrolling/scrolling-tree-includes-frame-expected.txt.
- platform/mac-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Removed.
- platform/win/TestExpectations:
- scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt.
- scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt.
- scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html.
- scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt.
- scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed.html.
- scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt.
- scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html.
- scrollingcoordinator/scrolling-tree/coordinated-frame.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/coordinated-frame.html.
- scrollingcoordinator/scrolling-tree/remove-coordinated-frame-expected.txt: Renamed from LayoutTests/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt.
- scrollingcoordinator/scrolling-tree/remove-coordinated-frame.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/remove-coordinated-frame.html.
- scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt: Renamed from LayoutTests/fast/scrolling/ios/remove-scrolling-role-expected.txt.
- scrollingcoordinator/scrolling-tree/remove-scrolling-role.html: Renamed from LayoutTests/fast/scrolling/ios/remove-scrolling-role.html.
- scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html: Renamed from LayoutTests/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html.
- scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame-expected.txt: Renamed from LayoutTests/fast/scrolling/scrolling-tree-includes-frame-expected.txt.
- scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html: Renamed from LayoutTests/fast/scrolling/scrolling-tree-includes-frame.html.
- 1:56 PM Changeset in webkit [240504] by
-
- 1 edit12 moves2 adds in trunk/LayoutTests
Move tests for scrolling tree mutations into their own directory
https://bugs.webkit.org/show_bug.cgi?id=193836
Reviewed by Tim Horton.
Add a scrollingcoordinator/scrolling-tree directory, which will contain tests for scrolling
tree mutations.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt: Renamed from LayoutTests/platform/ios/scrollingcoordinator/gain-scrolling-node-parent-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt: Renamed from LayoutTests/platform/ios/scrollingcoordinator/lose-scrolling-node-parent-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt: Renamed from LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-across-compositing-layers-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt: Renamed from LayoutTests/platform/ios-wk2/scrollingcoordinator/reparent-with-layer-removal-expected.txt.
- scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt: Renamed from LayoutTests/scrollingcoordinator/gain-scrolling-node-parent-expected.txt.
- scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent.html: Renamed from LayoutTests/scrollingcoordinator/gain-scrolling-node-parent.html.
- scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt: Renamed from LayoutTests/scrollingcoordinator/lose-scrolling-node-parent-expected.txt.
- scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent.html: Renamed from LayoutTests/scrollingcoordinator/lose-scrolling-node-parent.html.
- scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt: Renamed from LayoutTests/scrollingcoordinator/reparent-across-compositing-layers-expected.txt.
- scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers.html: Renamed from LayoutTests/scrollingcoordinator/reparent-across-compositing-layers.html.
- scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt: Renamed from LayoutTests/scrollingcoordinator/reparent-with-layer-removal-expected.txt.
- scrollingcoordinator/scrolling-tree/reparent-with-layer-removal.html: Renamed from LayoutTests/scrollingcoordinator/reparent-with-layer-removal.html.
- 1:51 PM Changeset in webkit [240503] by
-
- 2 edits in trunk/Tools
Fix missing dependencies in extract-dependencies-from-makefile
https://bugs.webkit.org/show_bug.cgi?id=193783
<rdar://problem/47201571>
Reviewed by Alex Christensen.
The extract-dependencies-from-makefile script generates .xcfilelists
for XCBuild by invoking a makefile in --debug mode, parsing the
dependency information in the output, and extracting information
regarding targets and dependents. However, the waymakeemits this
dependency information is not rigorous, and so we need to determine
what lines to look for and parse by trial and error. This approach
didn't coriginally atch all the information we needed to collect, so
update the script to look for the additional lines we now know to look
for.
- Scripts/extract-dependencies-from-makefile:
(Parser):
(Parser.addTarget):
(Parser.addPrereq):
(Parser.doParse):
- 1:49 PM Changeset in webkit [240502] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Audit: remove experimental setting
https://bugs.webkit.org/show_bug.cgi?id=193743
<rdar://problem/28234022>
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Setting.js:
(WI.Setting):
(WI.Setting.localStorageKey): Added.
(WI.Setting.migrateValue):
Drive-by: add the localStorage key prefix to the key passed intoWI.Setting.migrateValue.
- UserInterface/Base/Main.js:
(WI.loaded):
- UserInterface/Views/AuditTabContentView.js:
(WI.AuditTabContentView.isTabAllowed):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- Localizations/en.lproj/localizedStrings.js:
- 1:43 PM Changeset in webkit [240501] by
-
- 10 edits in branches/safari-607-branch
Cherry-pick r239940. rdar://problem/47295340
JSTests:
2019-01-14 Mark Lam <mark.lam@apple.com>
Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).
https://bugs.webkit.org/show_bug.cgi?id=193402
<rdar://problem/46012309>
Reviewed by Keith Miller.
- stress/regexp-compile-oom.js:
- Skip this test for !$jitTests because it is tuned for stack usage when the JIT is enabled. As a result, it will fail on cloop builds though there is no bug.
Source/JavaScriptCore:
Also picked up a few missing changes in JITPropertyAccess32_64.cpp from the
cherry-pick of r240041.
2019-01-14 Mark Lam <mark.lam@apple.com>
Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change).
https://bugs.webkit.org/show_bug.cgi?id=193402
<rdar://problem/46012309>
Reviewed by Keith Miller.
The CLoop builds via build-jsc were previously completely disabled after our
change to enable ASM LLInt build without the JIT. As a result, JSC tests have
regressed on CLoop builds. The CLoop builds and tests will be re-enabled when
the fix for https://bugs.webkit.org/show_bug.cgi?id=192955 lands. This patch
fixes all the regressions (and some old bugs) so that the CLoop test bots won't
be red when CLoop build gets re-enabled.
In this patch, we do the following:
- Change CLoopStack::grow() to set the new CLoop stack top at the maximum allocated capacity (after discounting the reserved zone) as opposed to setting it only at the level that the client requested.
This fixes a small performance bug that I happened to noticed when I was
debugging a stack issue. It does not affect correctness.
- In LowLevelInterpreter32_64.asm:
- Fix loadConstantOrVariableTag() to use subi for computing the constant index because the VirtualRegister offset and FirstConstantRegisterIndex values it is operating on are both signed ints. This is just to be pedantic. The previous use of subu will still produce a correct value.
- Fix llintOpWithReturn() to use getu (instead of get) for reading OpIsCellWithType::type because it is of type JSType, which is a uint8_t.
- Fix llintOpWithMetadata() to use loadis for loading OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t5] because it is of type PropertyOffset, which is a signed int.
- Fix commonCallOp() to use getu for loading fields argv and argc because they are of type unsigned for OpCall, OpConstruct, and OpTailCall, which are the clients of commonCallOp.
- Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading OpGetFromScope::Metadata::operand because it is of type uintptr_t.
- In LowLevelInterpreter64.asm:
- Fix llintOpWithReturn() to use getu for reading OpIsCellWithType::type because it is of type JSType, which is a uint8_t.
- Fix llintOpWithMetadata() to use loadi for loading OpGetById::Metadata::modeMetadata.protoLoadMode.structure[t2] because it is of type StructureID, which is a uint32_t.
Fix llintOpWithMetadata() to use loadis for loading
OpGetById::Metadata::modeMetadata.protoLoadMode.cachedOffset[t2] because it
is of type PropertyOffset, which is a signed int.
- commonOp() should reload the metadataTable for op_catch because unlike for the ASM LLInt, the exception unwinding code is not able to restore "callee saved registers" for the CLoop interpreter because the CLoop uses pseudo-registers (see the CLoopRegister class).
This was the source of many exotic Cloop failures after the bytecode format
change (which introduced the metadataTable callee saved register). Hence,
we fix it by reloading metadataTable's value on re-entry via op_catch for
exception handling. We already take care of restoring it in op_ret.
- Fix llintOpWithMetadata() and getClosureVar() to use loadp for loading OpGetFromScope::Metadata::operand because it is of type uintptr_t.
- In LowLevelInterpreter.asm:
Fix metadata() to use loadi for loading metadataTable offsets because they are
of type unsigned. This was also a source of many exotic CLoop test failures.
- Change CLoopRegister into a class with a uintptr_t as its storage element. Previously, we were using a union to convert between various value types that we would store in this pseudo-register. This method of type conversion is undefined behavior according to the C++ spec. As a result, the C++ compiler may choose to elide some CLoop statements, thereby resulting in some exotic bugs.
We fix this by now always using accessor methods and assignment operators to
ensure that we use bitwise_cast to do the type conversions. Since bitwise_cast
uses a memcpy, this ensures that there's no undefined behavior, and that CLoop
statements won't get elided willy-nilly by the compiler.
Ditto for the CloopDobleRegisters.
Similarly, use bitwise_cast for ints2Double() and double2Ints() utility
functions.
Also use bitwise_cast (instead of reinterpret_cast) for the CLoop CAST macro.
- Fix cloop.rb to use the new CLoopRegister and CLoopDoubleRegister classes.
Add a clLValue accessor for offlineasm operand types to distinguish
LValue use of the operands from RValue uses.
Replace the use of clearHighWord() with simply casting to uint32_t. This is
more efficient for the C++ compiler (and help speed up debug build runs).
Also fix 32-bit arithmetic operations to only set the lower 32-bit value of
the pseudo registers. This fixes some CLoop JSC test failures.
This patch has been manually tested with the JSC tests on the following builds:
64bit X86 ASM LLLint (without JIT), 64bit and 32bit X86 CLoop, and ARMv7 Cloop.
- interpreter/CLoopStack.cpp: (JSC::CLoopStack::grow):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp: (JSC::CLoopRegister::i const): (JSC::CLoopRegister::u const): (JSC::CLoopRegister::i32 const): (JSC::CLoopRegister::u32 const): (JSC::CLoopRegister::i8 const): (JSC::CLoopRegister::u8 const): (JSC::CLoopRegister::ip const): (JSC::CLoopRegister::i8p const): (JSC::CLoopRegister::vp const): (JSC::CLoopRegister::cvp const): (JSC::CLoopRegister::callFrame const): (JSC::CLoopRegister::execState const): (JSC::CLoopRegister::instruction const): (JSC::CLoopRegister::vm const): (JSC::CLoopRegister::cell const): (JSC::CLoopRegister::protoCallFrame const): (JSC::CLoopRegister::nativeFunc const): (JSC::CLoopRegister::i64 const): (JSC::CLoopRegister::u64 const): (JSC::CLoopRegister::encodedJSValue const): (JSC::CLoopRegister::opcode const): (JSC::CLoopRegister::operator ExecState*): (JSC::CLoopRegister::operator const Instruction*): (JSC::CLoopRegister::operator JSCell*): (JSC::CLoopRegister::operator ProtoCallFrame*): (JSC::CLoopRegister::operator Register*): (JSC::CLoopRegister::operator VM*): (JSC::CLoopRegister::operator=): (JSC::CLoopRegister::bitsAsDouble const): (JSC::CLoopRegister::bitsAsInt64 const): (JSC::CLoopDoubleRegister::operator T const): (JSC::CLoopDoubleRegister::d const): (JSC::CLoopDoubleRegister::bitsAsInt64 const): (JSC::CLoopDoubleRegister::operator=): (JSC::LLInt::ints2Double): (JSC::LLInt::double2Ints): (JSC::LLInt::decodeResult): (JSC::CLoop::execute): (JSC::LLInt::Ints2Double): Deleted. (JSC::LLInt::Double2Ints): Deleted. (JSC::CLoopRegister::CLoopRegister): Deleted. (JSC::CLoopRegister::clearHighWord): Deleted.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- 1:40 PM Changeset in webkit [240500] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Deny mach lookups to services not used.
https://bugs.webkit.org/show_bug.cgi?id=193828
Reviewed by Brent Fulgham.
Start denying mach lookups to iOS services, which were previously allowed with reporting.
Living-on has indicated that these services are not used.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 1:35 PM Changeset in webkit [240499] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: show uncaught exception view for unhandled promise rejections
https://bugs.webkit.org/show_bug.cgi?id=193832
Reviewed by Matt Baker.
- UserInterface/Debug/UncaughtExceptionReporter.js:
(handleUnhandledPromiseRejection): Added.
- 12:52 PM Changeset in webkit [240498] by
-
- 25 edits in trunk
Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=193297
<rdar://problem/47158841>
Reviewed by Alex Christensen.
Source/WebCore:
Trigger logging to the UIProcess when the ResourceLoadObserver is used in the NetworkProcess.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Notify NetworkProcess a connection was made to a resource.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setLogWebSocketLoadingNotificationCallback): Added.
(WebCore::ResourceLoadObserver::setLogSubresourceLoadingNotificationCallback): Added.
(WebCore::ResourceLoadObserver::setLogSubresourceRedirectNotificationCallback): Added.
(WebCore::ResourceLoadObserver::logSubresourceLoading): Notify NetworkProcess of the load.
(WebCore::ResourceLoadObserver::logWebSocketLoading): Ditto.
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): Ditto.
Source/WebKit:
This patch activates the ResourceLoadStatistics code in the NetworkProcess, and turns
it off in the UIProcess. It also updates test infrastructure to work with this change
in architecture.
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::logSubresourceLoading): Added.
(WebKit::ResourceLoadStatisticsMemoryStore::logSubresourceRedirect): Added.
(WebKit::ResourceLoadStatisticsMemoryStore::logWebSocketLoading): Added.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::logSubresourceLoading): Added.
(WebKit::WebResourceLoadStatisticsStore::logSubresourceRedirect): Added.
(WebKit::WebResourceLoadStatisticsStore::logWebSocketLoading): Added.
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCapForPrevalentResources): Deleted.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logSubresourceLoading): Added.
(WebKit::NetworkConnectionToWebProcess::logSubresourceRedirect): Added.
(WebKit::NetworkConnectionToWebProcess::logWebSocketLoading): Added.
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setResourceLoadStatisticsEnabled):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
- Webprocess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Register new ResourceLoadObserver callbacks.
Tools:
- TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
activating the message used to trigger the callback when it is set.
- 12:45 PM Changeset in webkit [240497] by
-
- 5 edits2 adds2 deletes in trunk
iOS: inputmode="none" disables hardware keyboard's globe key
https://bugs.webkit.org/show_bug.cgi?id=193811
<rdar://problem/47406553>
Reviewed by Wenson Hsieh.
Source/WebKit:
Removed the support for inputmode="none" for now since we need a new SPI from UIKit
to properly implement this feature some time in the future.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView inputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView textInputTraits]):
LayoutTests:
Updated and renamed the test expecting the keyboard to update upon inputmode content attribute changed
to use inputmode="decimal" instead of inputmode="none", and updated another test to expect inputmode="none"
has no effect instead of hiding the keyboard.
- fast/forms/ios/inputmode-change-update-keyboard-expected.txt: Renamed from inputmode-none-removed-expected.txt.
- fast/forms/ios/inputmode-change-update-keyboard.html: Renamed from inputmode-none-removed.html.
- fast/forms/ios/inputmode-none-expected.txt:
- fast/forms/ios/inputmode-none.html:
- 12:39 PM Changeset in webkit [240496] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 12:38 PM Changeset in webkit [240495] by
-
- 3 edits in trunk/Source/WebCore
Remove FrameView::m_firstVisuallyNonEmptyLayoutCallbackPending
https://bugs.webkit.org/show_bug.cgi?id=193835
Reviewed by Simon Fraser.
Currently updateIsVisuallyNonEmpty() is called from fireLayoutRelatedMilestonesIfNeeded() and from the incrementVisually*() functions.
By calling it from incrementVisually*() and setting the m_isVisuallyNonEmpty flag to true early does not have any impact on when the milestone is fired.
The milestone firing, as part of the post-layout tasks is triggered by a subsequent layout.
However having multiple callers of updateIsVisuallyNonEmpty() requires an extra boolen (m_firstVisuallyNonEmptyLayoutCallbackPending) to maintain.
Also calling updateIsVisuallyNonEmpty() repeatedly could be costly (with the current threshold of 200 characters, I don't think it is though).
This patch removes m_firstVisuallyNonEmptyLayoutCallbackPending and moves the logic from updateIsVisuallyNonEmpty() to fireLayoutRelatedMilestonesIfNeeded().
- page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::loadProgressingStatusChanged):
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty): Deleted.
- page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
- 12:24 PM Changeset in webkit [240494] by
-
- 17 edits2 copies1 add in trunk/Source
Move soft-linking of Lookup.framework out of LookupSPI.h
<https://webkit.org/b/193815>
Reviewed by Tim Horton.
Source/WebCore:
- editing/cocoa/DictionaryLookup.mm:
- Remove unused header.
- editing/mac/DictionaryLookupLegacy.mm:
(WebCore::tokenRange):
(WebCore::showPopupOrCreateAnimationController):
(WebCore::DictionaryLookup::hidePopup):
- Move soft-linking to LookupSoftLink.{h,mm}.
- platform/ios/ValidationBubbleIOS.mm:
(WebCore::ValidationBubble::show):
- Update for changes to UIKitSoftLink.{h,mm} now that UIAccessibilityAnnouncementNotification is using SOFT_LINK_CONSTANT*().
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/PlatformMac.cmake:
- Add LookupSoftLink.{h,mm} files to the project.
- pal/ios/UIKitSoftLink.h:
- pal/ios/UIKitSoftLink.mm:
- Change SOFT_LINK_VARIABLE_FOR_HEADER() to SOFT_LINK_CONSTANT_FOR_HEADER() for UIAccessibilityAnnouncementNotification constant.
- pal/mac/LookupSoftLink.h: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h.
- pal/mac/LookupSoftLink.mm: Copied from Source/WebCore/PAL/pal/spi/mac/LookupSPI.h.
- Migrate soft-linking from LookupSPI.h to here.
- pal/spi/mac/LookupSPI.h:
- Replace soft-linking of Lookup.framework with LookupSoftLink.h.
Source/WebKit:
- UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver startObservingLookupDismissalIfNeeded]):
- Move soft-linking to LookupSoftLink.{h,mm}.
Source/WebKitLegacy/mac:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForText]):
- WebView/WebView.mm:
(-[WebView _prepareForDictionaryLookup]):
- Move soft-linking to LookupSoftLink.{h,mm}.
Source/WTF:
- wtf/cocoa/SoftLinking.h:
(SOFT_LINK_CONSTANT_FOR_HEADER):
(SOFT_LINK_CONSTANT_FOR_SOURCE_WITH_EXPORT):
(SOFT_LINK_CONSTANT_MAY_FAIL_FOR_HEADER):
- Remove local declaration of constant. This should be handled by including *SPI.h or "real" headers.
(SOFT_LINK_CONSTANT_MAY_FAIL_FOR_SOURCE_WITH_EXPORT):
- Remove local declaration of constant.
- Rename from SOFT_LINK_CONSTANT_MAY_FAIL_FOR_SOURCE() and add
exportargument to support exporting of functions.
(SOFT_LINK_CONSTANT_MAY_FAIL_FOR_SOURCE):
- Redefine in terms of SOFT_LINK_CONSTANT_MAY_FAIL_FOR_SOURCE_WITH_EXPORT().
- 12:20 PM Changeset in webkit [240493] by
-
- 6 edits in trunk/Source/WebKit
REGRESSION (PSON): After swipe back, first few attempts to swipe forward not recognized as swipe gestures
https://bugs.webkit.org/show_bug.cgi?id=193818
<rdar://problem/47456584>
Reviewed by Tim Horton.
We don't hit the RenderTreeSizeThreshold milestone to remove the snapshot and allow interaction because we request it
from a wrong process (the one we are leaving behind).
- UIProcess/Cocoa/ViewGestureController.cpp:
(WebKit::ViewGestureController::didStartProvisionalLoadForMainFrame):
Request the RenderTreeSizeThreshold notification when the load has started and we know the process to use.
(WebKit::ViewGestureController::SnapshotRemovalTracker::hasOutstandingEvent):
- UIProcess/Cocoa/ViewGestureController.h:
(WebKit::ViewGestureController::SnapshotRemovalTracker::renderTreeSizeThreshold const):
(WebKit::ViewGestureController::SnapshotRemovalTracker::setRenderTreeSizeThreshold):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::endSwipeGesture):
Don't request immediately, save the threshold to SnapshotRemovalTracker.
(WebKit::ViewGestureController::requestRenderTreeSizeNotificationIfNeeded):
Do the request to the right process.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):
Ensure we send the notification even if we reached the threshold before it was requested.
(WebKit::ViewGestureGeometryCollector::sendDidHitRenderTreeSizeThresholdIfNeeded):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold): Deleted.
- 11:56 AM Changeset in webkit [240492] by
-
- 3 edits in trunk/LayoutTests
webkitpy: Implement device type specific expected results (Gardening)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed test gardening.
- platform/ios/TestExpectations: Remove non-existant directories.
- platform/mac/TestExpectations: Ditto.
- 11:45 AM Changeset in webkit [240491] by
-
- 22 edits in trunk/Source
[iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
https://bugs.webkit.org/show_bug.cgi?id=193829
Reviewed by Tim Horton.
Source/WebCore:
No change in behavior.
- page/EventHandler.h:
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::tryToBeginDragAtPoint):
(WebCore::EventHandler::tryToBeginDataInteractionAtPoint): Deleted.
- platform/ios/WebItemProviderPasteboard.mm:
(linkTemporaryItemProviderFilesToDropStagingDirectory):
Source/WebKit:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setDragCaretRect):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didHandleDragStartRequest):
(WebKit::PageClientImpl::didConcludeEditDrag):
(WebKit::PageClientImpl::didChangeDragCaretRect):
(WebKit::PageClientImpl::didHandleStartDataInteractionRequest): Deleted.
(WebKit::PageClientImpl::didConcludeEditDataInteraction): Deleted.
(WebKit::PageClientImpl::didChangeDataInteractionCaretRect): Deleted.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView setupDragAndDropInteractions]):
(-[WKContentView teardownDragAndDropInteractions]):
(-[WKContentView _didHandleDragStartRequest:]):
(-[WKContentView _didConcludeEditDrag:]):
(-[WKContentView _didChangeDragCaretRect:currentRect:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView setupDataInteractionDelegates]): Deleted.
(-[WKContentView teardownDataInteractionDelegates]): Deleted.
(-[WKContentView _didHandleStartDataInteractionRequest:]): Deleted.
(-[WKContentView _didConcludeEditDataInteraction:]): Deleted.
(-[WKContentView _didChangeDataInteractionCaretRect:currentRect:]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didHandleDragStartRequest):
(WebKit::WebPageProxy::requestDragStart):
(WebKit::WebPageProxy::didConcludeEditDrag):
(WebKit::WebPageProxy::didHandleStartDataInteractionRequest): Deleted.
(WebKit::WebPageProxy::requestStartDataInteraction): Deleted.
(WebKit::WebPageProxy::didConcludeEditDataInteraction): Deleted.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::didConcludeEditDrag):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDragStart):
(WebKit::WebPage::requestAdditionalItemsForDragSession):
(WebKit::WebPage::didConcludeEditDrag):
(WebKit::WebPage::requestStartDataInteraction): Deleted.
(WebKit::WebPage::didConcludeEditDataInteraction): Deleted.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::didConcludeEditDrag):
- WebView/WebView.mm:
(-[WebView _requestStartDataInteraction:globalPosition:]):
(-[WebView _didConcludeEditDrag]):
(-[WebView _didConcludeEditDataInteraction]): Deleted.
- WebView/WebViewInternal.h:
- 11:42 AM Changeset in webkit [240490] by
-
- 8 edits in trunk
WKWebView.goBack should reload if there is a safe browsing warning
https://bugs.webkit.org/show_bug.cgi?id=193805
<rdar://problem/46908216>
Reviewed by Geoff Garen.
Source/WebKit:
If a WKWebView is showing a safe browsing warning and the user clicks a back button
in the app which calls WKWebView.goBack, the WKWebView is in a state where it has not navigated yet,
so actually going back will appear to the user to go back twice. We can't just do nothing because the
app is in a state where it is expecting a navigation to happen. Reloading achieves what the user expects
and makes the app work like the app expects.
- UIProcess/API/C/WKPage.cpp:
(WKPageGoBack):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView goBack]):
- UIProcess/PageClient.h:
(WebKit::PageClient::hasSafeBrowsingWarning const):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::hasSafeBrowsingWarning const):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(+[Simple3LookupContext sharedLookupContext]):
(-[Simple3LookupContext lookUpURL:completionHandler:]):
(-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
(TEST):
- 11:39 AM Changeset in webkit [240489] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r237808): offscreen path warning doesn't work
https://bugs.webkit.org/show_bug.cgi?id=193830
Reviewed by Matt Baker.
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.prototype.process):
- 11:37 AM Changeset in webkit [240488] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Web Inspector: Add another Protocol Version (iOS 12.2)
https://bugs.webkit.org/show_bug.cgi?id=193810
<rdar://problem/42981838>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-01-25
Reviewed by Matt Baker.
- UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-12.2.json: Added.
- 11:35 AM Changeset in webkit [240487] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector:
WI.Setting.migrateValuedoesn't take into account the key prefix
https://bugs.webkit.org/show_bug.cgi?id=193814
Reviewed by Matt Baker.
- UserInterface/Base/Setting.js:
(WI.Setting):
(WI.Setting.migrateValue):
(WI.Setting._localStorageKey): Added.
- 11:21 AM Changeset in webkit [240486] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 10:54 AM Changeset in webkit [240485] by
-
- 4 edits in trunk
Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
https://bugs.webkit.org/show_bug.cgi?id=193788
<rdar://problem/47531231>
Reviewed by Alex Christensen.
Source/WebKit:
When the page starts a new provisional load, make sure we cancel any pending one in the provisional
process, as it would have happened in the first provisional load happened in the same process.
Without this, we could have 2 parallel loads happening, one in the committed process and another
in the provisional one, leading to assertion failures in debug.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
- 10:49 AM Changeset in webkit [240484] by
-
- 15 edits1 delete in trunk/Source/WebKit
Drop WebKit::WebKitPolicyAction type as it is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=193827
Reviewed by Antti Koivisto.
Drop WebKit::WebKitPolicyAction type as it is no longer needed. It is now identical to
WebCore::PolicyAction.
- Shared/WebPolicyAction.h: Removed.
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponseShared):
- UIProcess/WebPageProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
(WebKit::toPolicyAction): Deleted.
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceivePolicyDecision):
- WebProcess/WebPage/WebPage.h:
- 10:48 AM Changeset in webkit [240483] by
-
- 2 edits in trunk/Tools
webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=193771
Unreviewed infrastructure fix.
- Scripts/webkitpy/port/darwin.py:
(DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
- 10:46 AM Changeset in webkit [240482] by
-
- 4 edits in trunk
Source/WebCore:
Updated feature status for several features
https://bugs.webkit.org/show_bug.cgi?id=193794
Reviewed by Joseph Pecoraro.
Updated feature status for the following: CSS Font Display,
CSS Text Decoration Level 4, SVG in OpenType Fonts, Web SQL,
File and Directory Entries API, MediaStream Recording API,
Readable Streams, Subresource Integrity, Visual Viewport API,
and Web Audio.
- features.json:
Websites/webkit.org:
Added feature status entry for "Removed in Preview"
https://bugs.webkit.org/show_bug.cgi?id=193794
Reviewed by Joseph Pecoraro.
- wp-content/themes/webkit/status.php:
- 10:45 AM Changeset in webkit [240481] by
-
- 2 edits in trunk/Source/JavaScriptCore
Update JavaScriptCore feature status entries.
https://bugs.webkit.org/show_bug.cgi?id=193797
Reviewed by Mark Lam.
Updated feature status for Async Iteration, and Object rest/spread.
- features.json:
- 10:42 AM Changeset in webkit [240480] by
-
- 2 edits in trunk/Tools
- Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
- 10:39 AM Changeset in webkit [240479] by
-
- 2 edits in trunk/Tools
Add contributors.json entries for Ling Ho and for a new bot watchers group.
- Scripts/webkitpy/common/config/contributors.json:
- 9:58 AM Changeset in webkit [240478] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Add logging of calls
https://bugs.webkit.org/show_bug.cgi?id=193784
Reviewed by Brent Fulgham.
Add permissive logging of calls on iOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 9:32 AM Changeset in webkit [240477] by
-
- 5 edits in trunk
Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=193779
<rdar://problem/46170903>
Reviewed by Antti Koivisto.
Source/WebKit:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::tryAppLink):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
We were crashing when trying to get the URL of the main frame, which was sad because we never
ended up using the main frame URL. Therefore, this patch drops the code in question.
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync):
Add assertion to make sure that the DecidePolicyForNavigationActionAsync IPC it is getting
from the process is related to its main frame.
Tools:
Add API test that quickly navigates forward to a previous process without waiting for it to
suspend. I suspect the crash could have been happening due to receiving leftover IPC from
the process' previous page when reconnecting the it for the forward navigation.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 9:23 AM Changeset in webkit [240476] by
-
- 25 edits10 adds in trunk
Need a way for JavaScript (or bundle) code to participate in undo
https://bugs.webkit.org/show_bug.cgi?id=190009
<rdar://problem/44807048>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Finish hooking up
UndoManager::addItems()to CustomUndoStep.
Tests: editing/undo-manager/undo-manager-add-item-exceptions.html
editing/undo-manager/undo-manager-add-item.html
editing/undo-manager/undo-manager-delete-stale-undo-items.html
editing/undo-manager/undo-manager-item-labels.html
editing/undo-manager/undo-manager-undo-redo-after-garbage-collection.html
- editing/CompositeEditCommand.h:
- editing/CustomUndoStep.cpp:
(WebCore::CustomUndoStep::didRemoveFromUndoManager):
Add a method to invalidate CustomUndoStep. This clears out the pointer to the undo item, and also invalidates
the UndoItem, removing it from its UndoManager.
- editing/CustomUndoStep.h:
- editing/Editor.cpp:
(WebCore::Editor::registerCustomUndoStep):
Add a helper method to register a CustomUndoStep as a platform undoable step.
- editing/Editor.h:
- editing/UndoStep.h:
- page/UndoItem.h:
(WebCore::UndoItem::undoManager const):
- page/UndoManager.cpp:
(WebCore::UndoManager::addItem):
Create a CustomUndoStep with the given UndoItem, and register it with the platform undo manager.
- page/UndoManager.h:
- page/UndoManager.idl:
Mark addItem() as capable of throwing exceptions.
Source/WebKit:
Invalidate undo steps when removing them from WebPage. Invalidation is a no-op for editing actions that come
from the UA, but for custom undo steps backed by an UndoItem, we clear out the custom undo step's pointer to its
UndoItem and additionally disconnect the UndoItem from its UndoManager.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addWebUndoStep):
(WebKit::WebPage::removeWebEditCommand):
- WebProcess/WebPage/WebUndoStep.h:
(WebKit::WebUndoStep::invalidate):
Tools:
Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
(WTR::UIScriptController::platformUndoManager const):
- DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
(WTR::UIScriptController::platformUndoManager const):
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::lastUndoLabel const):
(WTR::UIScriptController::firstRedoLabel const):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::platformUndoManager const):
- WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::platformUndoManager const):
LayoutTests:
Add a few new layout tests covering
UndoManager.addItem().
- editing/undo-manager/undo-manager-add-item-exceptions-expected.txt: Added.
- editing/undo-manager/undo-manager-add-item-exceptions.html: Added.
Add a test to verify that we throw exceptions when calling addItem() in a couple of circumstances.
- editing/undo-manager/undo-manager-add-item-expected.txt: Added.
- editing/undo-manager/undo-manager-add-item.html: Added.
Add a test that exercises the new API in both the top-level context and a child frame.
- editing/undo-manager/undo-manager-delete-stale-undo-items-expected.txt: Added.
- editing/undo-manager/undo-manager-delete-stale-undo-items.html: Added.
Add a test to verify that after adding undo items, undoing, and then performing other edit actions, garbage
collection will destroy JS wrappers for the previously added UndoItems, since these undo items' handlers can no
longer be invoked.
- editing/undo-manager/undo-manager-item-labels-expected.txt: Added.
- editing/undo-manager/undo-manager-item-labels.html: Added.
Add a test verifying that the undo and redo action labels are updated correctly when undoing and redoing.
- editing/undo-manager/undo-manager-undo-redo-after-garbage-collection-expected.txt: Added.
- editing/undo-manager/undo-manager-undo-redo-after-garbage-collection.html: Added.
Add a test to verify that triggering garbage collection after adding an undo item without keeping references to
the item (or its undo/redo handlers) doesn't break the API.
- resources/ui-helper.js:
(window.UIHelper.undoAndRedoLabels):
Add a helper method to grab the platform's current undo and redo action names.
(window.UIHelper):
- 8:50 AM Changeset in webkit [240475] by
-
- 7 edits in trunk
[LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
https://bugs.webkit.org/show_bug.cgi?id=193824
Reviewed by Antti Koivisto.
Source/WebCore:
When clear property is set and floats are present, we have to estimate and set the box's vertical position during
static positioning to be able to properly layout its subtree.
<div style="float: left; width: 100px; height: 100px;"></div>
<div style="clear: left;">
<div style="float: left; width: 100px; height: 100px;"></div>
</div>
In the above example since the second float's parent clears the first float, the second float is positioned below
the first float. If we didn't push down (clear) the box, the float child would get placed next to the first float.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const): Deleted.
(WebCore::Layout::BlockFormattingContext::adjustedVerticalPositionAfterMarginCollapsing const): Deleted.
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):
- layout/displaytree/DisplayBox.h:
Tools:
- LayoutReloaded/misc/LFC-passing-tests.txt:
- 8:46 AM Changeset in webkit [240474] by
-
- 4 edits in trunk/Source/WebCore
[LFC][BFC][MarginCollapsing] Move positive/negative margin value updating to a dedicated function
https://bugs.webkit.org/show_bug.cgi?id=193812
Reviewed by Antti Koivisto.
Move update logic to BlockFormattingContext::MarginCollapse::updatePositiveNegativeMarginValues().
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::updatePositiveNegativeMarginValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues):
- page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):
- 7:54 AM Changeset in webkit [240473] by
-
- 10 edits in trunk/Source/WebKit
[GTK][WPE] Add API to add paths to sandbox
https://bugs.webkit.org/show_bug.cgi?id=193571
This allows applications to add paths to the web process
if required by web extensions.
Patch by Patrick Griffis <Patrick Griffis> on 2019-01-25
Reviewed by Michael Catanzaro.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_add_path_to_sandbox):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/wpe/docs/wpe-0.1-sections.txt:
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
- UIProcess/WebProcessPool.h:
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- 3:36 AM Changeset in webkit [240472] by
-
- 12 edits in trunk/Source/WebCore
Use ENABLE_POINTER_EVENTS for the touch-action property
https://bugs.webkit.org/show_bug.cgi?id=193819
Reviewed by Antti Koivisto.
Since we've added an ENABLE_POINTER_EVENTS we should be using it for anything related to the implementation of the
Pointer Events specification of which the touch-action property is a part.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSPrimitiveValueMappings.h:
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/StyleBuilderConverter.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
- dom/Element.cpp:
(WebCore::Element::allowsDoubleTapGesture const):
- platform/TouchAction.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
- rendering/style/StyleRareNonInheritedData.h:
- 1:27 AM Changeset in webkit [240471] by
-
- 20 edits in trunk
Web Inspector: improve invalid Audit/Recording JSON error messages
https://bugs.webkit.org/show_bug.cgi?id=193476
<rdar://problem/47303659>
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/Models/AuditTestBase.js:
(WI.AuditTestBase):
- UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.async fromPayload):
- UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup.async fromPayload):
- UserInterface/Models/AuditTestCaseResult.js:
(WI.AuditTestCaseResult.async fromPayload.checkArray):
(WI.AuditTestCaseResult.async fromPayload):
- UserInterface/Models/AuditTestGroupResult.js:
(WI.AuditTestGroupResult.async fromPayload):
- UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.synthesizeWarning): Added.
(WI.AuditManager.synthesizeError):
(WI.AuditManager.prototype.async processJSON):
- UserInterface/Models/Recording.js:
(WI.Recording.fromPayload):
(WI.Recording.synthesizeWarning): Added.
(WI.Recording.synthesizeError):
- UserInterface/Models/RecordingFrame.js:
(WI.RecordingFrame.fromPayload):
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.async swizzle):
(WI.RecordingAction.prototype.apply):
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.processJSON):
- Localizations/en.lproj/localizedStrings.js:
LayoutTests:
- inspector/model/auditTestCase.html:
- inspector/model/auditTestCase-expected.txt:
- inspector/model/auditTestCaseResult-expected.txt:
- inspector/model/auditTestGroup.html:
- inspector/model/auditTestGroup-expected.txt:
- inspector/model/auditTestGroupResult-expected.txt:
- inspector/model/recording-expected.txt:
