Timeline



Feb 13, 2019:

10:47 PM Changeset in webkit [241500] by rniwa@webkit.org
  • 4 edits in trunk

Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
​https://bugs.webkit.org/show_bug.cgi?id=194641

Reviewed by Geoffrey Garen.

Source/WebKit:

Fixed the bug by adding a null check to WebFrame::parentFrame.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::parentFrame const):

Tools:

Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
so that the test would fail without this fix.

  • TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:

(TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

10:43 PM Changeset in webkit [241499] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash in DOMTimer::fired
​https://bugs.webkit.org/show_bug.cgi?id=194638

Reviewed by Brent Fulgham.

Source/WebCore:

This patch continues the saga of hunting down timer related crashes after r239814, r225985, r227934.

The crash was caused by the bug that we don't remove a DOMTimer from NestedTimersMap if a DOMTimer
is created & installed inside another DOMTimer's callback (via execute call in DOMTimer::fired).

Fixed the crash by using a Ref in NestedTimersMap. This will keep the timer alive until we exit
from DOMTimer::fired. Because DOMTimer::fired always calls stopTracking() which clears the map
we would not leak these DOM timers.

We could, alternatively, use WeakPtr in NestedTimersMap but that would unnecessarily increase the
size of DOMTimer for a very marginal benefit of DOMTimer objcets being deleted slightly earlier.
Deleting itself in DOMTimer's destructor involves more logic & house keeping in the timer code,
and is no longer the preferred approach when dealing with these classes of bugs in WebKit.

Test: fast/dom/timer-destruction-during-firing.html

  • page/DOMTimer.cpp:

(WebCore::NestedTimersMap::add):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):

LayoutTests:

Added a regression test. It needs debug assertions without the fix.

  • fast/dom/timer-destruction-during-firing-expected.txt: Added.
  • fast/dom/timer-destruction-during-firing.html: Added.
9:33 PM Changeset in webkit [241498] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit

Allow some deprecations in WKDrawingView.
​https://bugs.webkit.org/show_bug.cgi?id=194636

Reviewed by Wenson Hsieh.

  • UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView PNGRepresentation]):
(-[WKDrawingView loadDrawingFromPNGRepresentation:]):
(-[WKDrawingView _canvasViewWillBeginDrawing:]):
(-[WKDrawingView didChangeInk:]):

9:32 PM Changeset in webkit [241497] by Nikita Vasilyev
  • 3 edits
    2 adds in trunk

Web Inspector: Styles: valid values in style attributes are reported as unsupported property values
​https://bugs.webkit.org/show_bug.cgi?id=194619
<rdar://problem/47917373>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Payload of inline styles may contain range that doesn't match
the actual text of the payload - it has an extra empty line at the end.
Mismatching ranges caused data corruption.

  • UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):

LayoutTests:

  • inspector/css/modify-inline-style-expected.txt: Added.
  • inspector/css/modify-inline-style.html: Added.
7:47 PM Changeset in webkit [241496] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update combined and minified copyright header for 2018-2019
​https://bugs.webkit.org/show_bug.cgi?id=194635

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-13
Reviewed by Devin Rousso.

  • Scripts/copy-user-interface-resources.pl:
7:38 PM Changeset in webkit [241495] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Crash when inspecting an element that constantly changes visibility
​https://bugs.webkit.org/show_bug.cgi?id=194632
<rdar://problem/48060258>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-13
Reviewed by Matt Baker and Devin Rousso.

  • inspector/agents/InspectorDOMAgent.h:
  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::processAccessibilityChildren):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
Don't use rvalue-references as that was taking ownership and deleting
the object we want to keep around. Instead simplify this to just use
references so no ref counting changes happen.

7:27 PM Changeset in webkit [241494] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Crash in handleMenuOpen
​https://bugs.webkit.org/show_bug.cgi?id=194627

Reviewed by Zalan Bujtas.

Tests run under libGuardMalloc will cause crashes.

This list of objects is a Node list, not an Element list, so we were
not removing some nodes when they were being deallocated.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):

7:01 PM Changeset in webkit [241493] by ysuzuki@apple.com
  • 8 edits in trunk/Source

We should only make rope strings when concatenating strings long enough.
​https://bugs.webkit.org/show_bug.cgi?id=194465

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch stops us from allocating a rope string if the resulting
rope would be smaller than the size of the JSRopeString object we
would need to allocate.

This patch also adds paths so that we don't unnecessarily allocate
JSString cells for primitives we are going to concatenate with a
string anyway.

The important change from the previous one is that we do not apply
the above rule to JSRopeStrings generated by JSStrings. If we convert
it to JSString, comparison of memory consumption becomes the following,
because JSRopeString does not have StringImpl until it is resolved.

sizeof(JSRopeString) v.s. sizeof(JSString) + sizeof(StringImpl) + content

Since sizeof(JSString) + sizeof(StringImpl) is larger than sizeof(JSRopeString),
resolving eagerly increases memory footprint. The point is that we need to
account newly created JSString and JSRopeString from the operands. This is the
reason why this patch adds different thresholds for each jsString functions.

This patch also avoids concatenation for ropes conservatively. Many ropes are
temporary cells. So we do not resolve eagerly if one of operands is already a
rope.

In CLI execution, this change is performance neutral in JetStream2 (run 6 times, 1 for warming up and average in latter 5.).

Before: 159.3778
After: 160.72340000000003

  • dfg/DFGOperations.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSString.h:

(JSC::JSString::isRope const):

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsAddNonNumber):
(JSC::jsAdd):

Source/WTF:

  • wtf/text/StringImpl.h:

(WTF::StringImpl::headerSize):

6:28 PM Changeset in webkit [241492] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] PiP window can get "stuck" if PiP is closed while Safari window is minimized.
​https://bugs.webkit.org/show_bug.cgi?id=194621
<rdar://problem/48002560>

Reviewed by Eric Carlson.

When Safari is minimized, no rAF() requests are executed. Don't gate responding to presentation
change events in the media-controller.js on rAF().

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._returnMediaLayerToInlineIfNeeded):

6:28 PM Changeset in webkit [241491] by aboya@igalia.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK test gardening
​https://bugs.webkit.org/show_bug.cgi?id=194631

  • platform/gtk/TestExpectations:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
5:36 PM Changeset in webkit [241490] by wilander@apple.com
  • 6 edits in trunk

Ignore Ad Click Attribution where source and destination are same-site
​https://bugs.webkit.org/show_bug.cgi?id=194620
<rdar://problem/47890018>

Reviewed by Jiewen Tan.

Source/WebCore:

Updated the existing test.

We should not accept Ad Click Attribution requests where the site of the
anchor tag and its addestination attribute are same-site. Such attributions
don’t make sense (the site can track intra-site clicks through better means)
and would just lead to increased memory use where are the pending
attributions are stored.

For ports that don't have access to the Public Suffix List, this patch
only checks that the hosts don't match, i.e. not just eTLD+1.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAdClickAttribution const):

Now returns WTF::nullopt if the current document and the
addestination are same site. Also fixed a console message
typo.

LayoutTests:

Same-site test added and test results updated.

  • http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
  • http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
  • platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt:
5:25 PM Changeset in webkit [241489] by youenn@apple.com
  • 8 edits
    2 adds in trunk

getUserMedia with an ideal deviceId constraint doesn't always select the correct device
​https://bugs.webkit.org/show_bug.cgi?id=193614

Source/WebCore:

Reviewed by Eric Carlson.

Compute a fitness score based on constraints.
For each constraint, a fitness score is computed from the distance.
The smaller the distance, the higher the score.
Fitness scores are then summed to give a device fitness score.
Matching devices are then sorted according the fitness score.

For important constraints, deviceId and facingMode, add a more important weight.
This ensures that should any of these ideal constraints are set, they will be respected.

Restrict our automatic setting of default constraints to not add a default ideal facingMode in case of existing deviceId constraint.
Do not set a default ideal frameRate if width and height are already set.

Covered by updated test.

  • platform/mediastream/MediaConstraints.cpp:

(WebCore::FlattenedConstraint::set):
(WebCore::MediaConstraints::setDefaultVideoConstraints):

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::RealtimeMediaSource::selectSettings):
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):

LayoutTests:

Reviewed by Eric Carlson.

  • fast/mediastream/get-user-media-device-id-expected.txt:
  • fast/mediastream/get-user-media-device-id.html:
4:31 PM Changeset in webkit [241488] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Change log level for a log statement

Unreviewed minor fix.

  • BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch.save_patch):

4:28 PM Changeset in webkit [241487] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

[iOS] Add a hack to work around buggy video control library
​https://bugs.webkit.org/show_bug.cgi?id=194615
<rdar://problem/46146946>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/ios/video-volume-ios-quirk.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume): Change m_volume for one turn of the runloop.
(WebCore::HTMLMediaElement::cancelPendingTasks): Clear the task queue used to restore m_volume.
(WebCore::HTMLMediaElement::closeTaskQueues): Close it.

  • html/HTMLMediaElement.h:

LayoutTests:

  • media/ios/video-volume-ios-quirk-expected.txt: Added.
  • media/ios/video-volume-ios-quirk.html: Added.
4:21 PM Changeset in webkit [241486] by jer.noble@apple.com
  • 20 edits
    1 add in trunk

[Cocoa] Media elements will restart network buffering just before suspending
​https://bugs.webkit.org/show_bug.cgi?id=193691

Reviewed by Eric Carlson.

Source/WebCore:

API Test: WebKit.ProcessSuspendMediaBuffering

Allow the Page to suspend all media buffering in its child Documents.

  • dom/Document.cpp:

(WebCore::Document::suspendAllMediaBuffering):
(WebCore::Document::resumeAllMediaBuffering):

  • dom/Document.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::dataBufferingPermitted const):
(WebCore::MediaElementSession::suspendBuffering):
(WebCore::MediaElementSession::resumeBuffering):
(WebCore::MediaElementSession::bufferingSuspended const):

  • html/MediaElementSession.h:
  • page/Page.cpp:

(WebCore::Page::suspendAllMediaBuffering):
(WebCore::Page::resumeAllMediaBuffering):

  • page/Page.h:

(WebCore::Page::mediaPlaybackIsSuspended const):
(WebCore::Page::mediaBufferingIsSuspended const):
(WebCore::Page::mediaPlaybackIsSuspended): Deleted.

  • platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::suspendBuffering):
(WebCore::PlatformMediaSession::resumeBuffering):

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):

  • platform/audio/PlatformMediaSessionManager.h:

Source/WebKit:

When the WebProcess receives a notification that the process is about to become
suspended, it tells the MemoryPressureHandler to release all critical memory. This
has the side effect of causing AVFoundation-backed media elements to dump their
in-memory caches and start downloading media data again. Instead, media elements
should all stop buffering media data during suspension. Add new testing SPI to
simulate suspension and resume messages.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processWillSuspendImminentlyForTesting]):
(-[WKWebView _processDidResumeForTesting]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/ios/WKInkPickerView.mm:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::suspendAllMediaBuffering):
(WebKit::WebPage::resumeAllMediaBuffering):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::processDidResume):
(WebKit::WebProcess::suspendAllMediaBuffering):
(WebKit::WebProcess::resumeAllMediaBuffering):

  • WebProcess/WebProcess.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.

(TEST):

4:16 PM Changeset in webkit [241485] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Fetch builder id to name mapping
​https://bugs.webkit.org/show_bug.cgi?id=194355

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.get_builder_id_to_name_mapping):
(Buildbot._get_display_name_from_builder_name):

4:11 PM Changeset in webkit [241484] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

Entering fullscreen inside a shadow root will not set fullscreen pseudoclasses outside of root
​https://bugs.webkit.org/show_bug.cgi?id=194516
<rdar://problem/44678353>

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html

When walking up the element ancestor chain, use parentElementInComposedTree() to
walk past the shadow root boundary.

  • dom/Element.cpp:

(WebCore::parentCrossingFrameBoundaries):

LayoutTests:

  • fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor-expected.txt: Added.
  • fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html: Added.
  • platform/ios-wk2/TestExpectations:
4:03 PM Changeset in webkit [241483] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Fix sandbox violation during media playback
​https://bugs.webkit.org/show_bug.cgi?id=194616
<rdar://problem/48049264>

Reviewed by Brent Fulgham.

Mach lookup to "com.apple.coremedia.figcontentkeysession.xpc" should be allowed.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
3:14 PM Changeset in webkit [241482] by Chris Dumez
  • 4 edits in trunk/Source

Unreviewed, update localizable strings.

Source/WebCore:

  • en.lproj/Localizable.strings:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
3:08 PM Changeset in webkit [241481] by timothy_horton@apple.com
  • 3 edits
    4 adds in trunk

Encrypted PDFs inside <embed> or <object> crash the Web Content process
​https://bugs.webkit.org/show_bug.cgi?id=194605
<rdar://problem/19894818>

Reviewed by Andy Estes.

Source/WebKit:

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createPasswordEntryForm):
Don't try to create a password form field if we can't make form fields.

This means you will be left with a useless embedded PDF, but at least
the Web Content process won't crash.

We'll need to find an alternative implementation of PDF embedded form
fields that is compatible with <embed> and <object> if we want to support
this. Currently we piggy-back off the fact that we can just insert
<input>s into the PluginDocument's DOM, but we can't do that if there
is no PluginDocument, just a main document, like in the <embed> case.

LayoutTests:

  • fast/replaced/encrypted-pdf-as-object-and-embed-expected.txt: Added.
  • fast/replaced/encrypted-pdf-as-object-and-embed.html: Added.
  • fast/replaced/resources/encrypted-image.pdf: Added.

Add a test ensuring that we don't crash with encrypted PDF in <object> or <embed>.

3:07 PM Changeset in webkit [241480] by jiewen_tan@apple.com
  • 30 edits
    4 adds in trunk

Further restricting webarchive loads
​https://bugs.webkit.org/show_bug.cgi?id=194567
<rdar://problem/47610130>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch futher restricts main frame webarchive loads to the followings:
1) loaded by clients;
2) loaded by drag;
3) reloaded from any of the previous two.

It moves setAlwaysAllowLocalWebarchive, which is used for testing only, from Document
to FrameLoader such that the option is remembered during redirections.

Covered by API tests.

  • dom/Document.h:

(WebCore::Document::setAlwaysAllowLocalWebarchive): Deleted.
(WebCore::Document::alwaysAllowLocalWebarchive const): Deleted.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::disallowWebArchive const):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setAllowsWebArchiveForMainFrame):
(WebCore::DocumentLoader::allowsWebArchiveForMainFrame):

  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setIsRequestFromClientOrUserInput):
(WebCore::FrameLoadRequest::isRequestFromClientOrUserInput):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reload):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::setAlwaysAllowLocalWebarchive):
(WebCore::FrameLoader::alwaysAllowLocalWebarchive const):

  • page/DragController.cpp:

(WebCore::DragController::performDragOperation):

  • testing/Internals.cpp:

(WebCore::Internals::setAlwaysAllowLocalWebarchive const):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
Set a flag to indicate a load is started from clients.

Tools:

Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
navigations on drop.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.

(-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
(-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
(-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
  • TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
  • TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
  • TestWebKitAPI/cocoa/DragAndDropSimulator.h:
  • TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:

(-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
(-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

  • platform/mac/fast/loader/webarchive-encoding-respected.html:
  • webarchive/loading/cache-expired-subresource.html:
  • webarchive/loading/javascript-url-iframe-crash.html:
  • webarchive/loading/mainresource-null-mimetype-crash.html:
  • webarchive/loading/missing-data.html:
  • webarchive/loading/object.html:
  • webarchive/loading/test-loading-archive-subresource-null-mimetype.html:
  • webarchive/loading/test-loading-archive-subresource.html:
  • webarchive/loading/test-loading-archive.html:
  • webarchive/loading/test-loading-top-archive.html:
  • webarchive/loading/video-in-webarchive.html:
2:59 PM Changeset in webkit [241479] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Null-deref crash at SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged()
​https://bugs.webkit.org/show_bug.cgi?id=194613
<rdar://problem/48023912>

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

2:49 PM Changeset in webkit [241478] by Alan Coon
  • 5 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241297. rdar://problem/47969451

Source/WebCore:
Unreviewed build fix; add a HAVE_CELESTIAL guard around Celestial framework usage.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary):

Source/WebCore/PAL:
Unreviewed build fix; add a HAVE_CELESTIAL guard around the CelestialSPI.h contents.

  • pal/spi/ios/CelestialSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:49 PM Changeset in webkit [241477] by Alan Coon
  • 15 edits
    1 move in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241281. rdar://problem/47969451

[Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
​https://bugs.webkit.org/show_bug.cgi?id=194504

Reviewed by Eric Carlson.

Source/WebCore:

This allows the MediaRemote framework to associate the WebContent process with its host application.

  • Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::start):
  • platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::prepareToSendUserMediaPermissionRequest):
  • platform/audio/cocoa/MediaSessionManagerCocoa.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm: (MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest): (MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary): (MediaSessionManagerCocoa::updateNowPlayingInfo):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp: (WebKit::WebUserMediaClient::requestUserMediaAccess):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::userMediaPermissionRequestManager):
  • WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:42 PM Changeset in webkit [241476] by Alan Coon
  • 4 edits in tags/Safari-607.1.34.1/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:36 PM Changeset in webkit [241475] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

AirIRGenerator::addSwitch switch patchpoint needs to model clobbering the scratch register
​https://bugs.webkit.org/show_bug.cgi?id=194610

Reviewed by Michael Saboff.

BinarySwitch might use the scratch register. We must model the
effects of that properly. This is already caught by our br-table
tests on arm64.

  • wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addSwitch):

2:35 PM Changeset in webkit [241474] by Michael Catanzaro
  • 3 edits
    1 move
    1 delete in trunk/Source/WebKit

[WPE][GTK] Merge WebProcessPoolWPE.cpp and WebProcessPoolGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=194551

Reviewed by Carlos Garcia Campos.

  • SourcesGTK.txt:
  • SourcesWPE.txt:
  • UIProcess/glib/WebProcessPoolGLib.cpp: Renamed from Source/WebKit/UIProcess/gtk/WebProcessPoolGtk.cpp.

(WebKit::initializeRemoteInspectorServer):
(WebKit::memoryPressureMonitorDisabled):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInvalidateContext):
(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

  • UIProcess/wpe/WebProcessPoolWPE.cpp: Removed.
2:28 PM Changeset in webkit [241473] by Alan Coon
  • 4 edits in tags/Safari-607.1.35.1/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:23 PM Changeset in webkit [241472] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix unused variable warnings after r241148/r241251
​https://bugs.webkit.org/show_bug.cgi?id=194348
<rdar://problem/47566449>

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError):
(WebCore::SourceBuffer::evictCodedFrames):
(WebCore::SourceBuffer::provideMediaData):

2:10 PM Changeset in webkit [241471] by Alan Coon
  • 7 edits in tags/Safari-607.1.34.1/Source

Versioning.

1:39 PM Changeset in webkit [241470] by Alan Coon
  • 7 edits in tags/Safari-607.1.35.1/Source

Versioning.

1:38 PM Changeset in webkit [241469] by Alan Coon
  • 1 copy in tags/Safari-607.1.34.1

New tag.

1:32 PM Changeset in webkit [241468] by sihui_liu@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: [ Mac Debug WK2 ] Layout Test storage/indexeddb/key-type-infinity-private.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=194413
<rdar://problem/47897254>

Reviewed by Brady Eidson.

IDB clients expected transaction operations to be executed in order, but in
UniqueIDBDatabase::immediateCloseForUserDelete, callbacks in callback map were errored out randomly.
This patch added a callback queue to UniqueIDBDatabase to make sure callbacks will be called in the same order
as IDB Server receives the request.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performKeyDataCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetResultCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performGetAllResultsCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performCountCallback):
(WebCore::IDBServer::UniqueIDBDatabase::forgetErrorCallback):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
1:29 PM Changeset in webkit [241467] by Alan Coon
  • 1 copy in tags/Safari-607.1.35.1

New tag.

1:14 PM Changeset in webkit [241466] by Alan Coon
  • 7 edits in branches/safari-607-branch/Source/WebKit

Apply patch. rdar://problem/40966400

1:11 PM Changeset in webkit [241465] by Alan Coon
  • 3 edits
    2 adds in branches/safari-607-branch

Cherry-pick r241319. rdar://problem/48015672

Source/WebCore:
Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp: (WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

  • fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
  • fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241464] by Alan Coon
  • 4 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241300. rdar://problem/48016008

Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

  1. a Document detaches from its StyleSheetList.
  2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
  3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

  1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

  1. Fix CodeGeneratorJS.pm to null check the opaque root before using it.
  • bindings/js/JSNodeCustom.h: (WebCore::root):
  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241463] by Alan Coon
  • 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241296. rdar://problem/48015654

Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

  • page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241462] by Alan Coon
  • 11 edits in branches/safari-607-branch

Cherry-pick r241289. rdar://problem/48015662

AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
​https://bugs.webkit.org/show_bug.cgi?id=182280
<rdar://problem/37018386>

Reviewed by Alan Bujtas.

Source/WebCore:

Remove the possibility that changing children calls back into updating layout by
handling children changes in a deferred manner.

This follows the same architecture as many other deferred changes, but also requires us to check deferred changes
in updateBackingStore, because things like aria-hidden changes won't trigger a layout, but will require us to update children.

A few tests had to be modified to no longer change the tree and then check the children immediately.

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::prepareForDocumentDestruction): (WebCore::AXObjectCache::performDeferredCacheUpdate):
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::updateBackingStore):
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (convertToNSArray): (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

  • accessibility/aria-hidden-update.html:
  • accessibility/aria-hidden-updates-alldescendants.html:
  • accessibility/image-load-on-delay.html:
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
  • accessibility/removed-anonymous-block-child-causes-crash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241461] by Alan Coon
  • 25 edits
    2 adds
    2 deletes in branches/safari-607-branch

Cherry-pick r241288. rdar://problem/47992210

[Cocoa] Ask platform for generic font family mappings
​https://bugs.webkit.org/show_bug.cgi?id=187723
<rdar://problem/41892438>

Reviewed by Brent Fulgham.

Source/WebCore:

WebKit API allows setting the generic font families for the USCRIPT_COMMON script.
When trying to style a character with a generic font family, we first look to see if
we have a mapping for the particular script the character is rendered with, and if we
don't find a match, we then check USCRIPT_COMMON.

In the Cocoa ports, the only way families get set for non-USCRIPT_COMMON scripts (aka
the only scripts which won't use the API families) is in
SettingsBase::initializeDefaultFontFamilies(). That function only sets the families
for the CJK scripts.

The mappings inside SettingsBase are incorrect and conflict with our policy regarding
user-installed fonts. Instead, we should be consulting with the platform for some of
these mappings, by calling CTFontDescriptorCreateForCSSFamily(). However, the WebKit
API still has to work to set the mappings for untagged content. Therefore, we use the
system mappings for language-tagged content, and the API mappings for non-language-tagged
content. This is a good balance that makes sure we always have a good mapping for every
language, but API clients can still set the mappings, too.

Test: fast/text/ja-sans-serif.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSFontSelector.cpp: (WebCore::resolveGenericFamily):
  • css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontFamily):
  • page/cocoa/SettingsBaseCocoa.mm: (WebCore::SettingsBase::initializeDefaultFontFamilies): (WebCore::osakaMonoIsInstalled): Deleted.
  • platform/graphics/FontDescription.cpp: (WebCore::FontDescription::platformResolveGenericFamily):
  • platform/graphics/FontDescription.h:
  • platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::computeSpecializedChineseLocale): (WebCore::cachedSpecializedChineseLocale): (WebCore::languageChanged): (WebCore::FontDescription::platformResolveGenericFamily):
  • platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::clear): (WebCore::genericFamily): (WebCore::SystemFontDatabaseCoreText::serifFamily): (WebCore::SystemFontDatabaseCoreText::sansSerifFamily): (WebCore::SystemFontDatabaseCoreText::cursiveFamily): (WebCore::SystemFontDatabaseCoreText::fantasyFamily): (WebCore::SystemFontDatabaseCoreText::monospaceFamily):
  • platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

Source/WebCore/PAL:

  • pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

Add an ENABLE in Platform.

  • wtf/Platform.h:

Tools:

Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().

  • DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet):
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet):

LayoutTests:

Update the tests to work with this new model.

  • fast/text/international/font-fallback-to-common-script-expected.html: Removed.
  • fast/text/international/font-fallback-to-common-script.html: Removed.
  • fast/text/international/lang-sensitive-fonts-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml.xhtml:
  • fast/text/international/lang-sensitive-fonts.html:
  • fast/text/international/locale-sensitive-fonts-expected.html:
  • fast/text/international/locale-sensitive-fonts.html:
  • fast/text/ja-sans-serif-expected-mismatch.html: Added.
  • fast/text/ja-sans-serif.html: Added.
  • platform/ios/fast/block/float/016-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241460] by Alan Coon
  • 2 edits in branches/safari-607-branch/Source/JavaScriptCore

Cherry-pick r241267. rdar://problem/47971556

Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor.
​https://bugs.webkit.org/show_bug.cgi?id=194493
<rdar://problem/36380852>

Reviewed by Yusuke Suzuki.

Having duplicate cases in the BinarySwitch is not a correctness issue. It is
however not good for performance and memory usage. As such, a debug ASSERT will
do. We'll also do an audit of the clients of BinarySwitch to see if it's
possible to be instantiated with duplicate cases in
​https://bugs.webkit.org/show_bug.cgi?id=194492 later.

Also added some value dumps to the RELEASE_ASSERT to help debug the issue when we
see duplicate cases.

  • jit/BinarySwitch.cpp: (JSC::BinarySwitch::BinarySwitch):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241459] by Alan Coon
  • 2 edits in branches/safari-607-branch/Source/WebCore

Cherry-pick r241231. rdar://problem/47971603

[Cocoa] CTLineGetGlyphRuns() might return nullptr
​https://bugs.webkit.org/show_bug.cgi?id=194467
<rdar://problem/42423999>

Reviewed by Simon Fraser.

Be somewhat defensive to try to make sure this sort of thing doesn't happen in the future.

Covered by find/text/find-backwards.html

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241458] by Alan Coon
  • 14 edits
    1 add in branches/safari-607-branch

Cherry-pick r241228. rdar://problem/47971567

Nodes that rely on being dominated by CheckInBounds should have a child edge to it
​https://bugs.webkit.org/show_bug.cgi?id=194334
<rdar://problem/47844327>

Reviewed by Mark Lam.

JSTests:

  • stress/check-in-bounds-should-be-a-child-use.js: Added. (func):

Source/JavaScriptCore:

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants):
  • dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::convertToHasIndexedProperty):
  • dfg/DFGIntegerCheckCombiningPhase.cpp: (JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
  • dfg/DFGNodeType.h:
  • dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCheckInBounds): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241457] by Alan Coon
  • 4 edits in branches/safari-607-branch/Source/JavaScriptCore

Cherry-pick r241210. rdar://problem/47971573

Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and StringCharAt nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194446
<rdar://problem/47926792>

Reviewed by Saam Barati.

Fix doesGC() for the following nodes:

CheckTierUpAtReturn:

Calls triggerTierUpNow(), which calls triggerFTLReplacementCompile(),
which calls Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpInLoop:

Calls triggerTierUpNowInLoop(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpAndOSREnter:

Calls triggerOSREntryNow(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

GetByVal:

case Array::String calls operationSingleCharacterString(), which calls
jsSingleCharacterString(), which can allocate a string.

PutByValDirect:
PutByVal:
PutByValAlias:

For the DFG only, the integer TypeArrays calls compilePutByValForIntTypedArray(),
which may call slow paths operationPutByValDirectStrict(), operationPutByValDirectNonStrict(),
operationPutByValStrict(), or operationPutByValNonStrict(). All of these
slow paths call putByValInternal(), which may create exception objects, or
call the generic JSValue::put() which may execute arbitrary code.

StringCharAt:

Can call operationSingleCharacterString(), which calls jsSingleCharacterString(),
which can allocate a string.

Also fix DFG::SpeculativeJIT::compileGetByValOnString() and FTL's compileStringCharAt()
to use the maxSingleCharacterString constant instead of a literal constant.

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString):
  • dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241456] by Alan Coon
  • 5 edits in branches/safari-607-branch

Cherry-pick r241203. rdar://problem/47971610

[WebVTT] Inline WebVTT styles should start with '::cue'
​https://bugs.webkit.org/show_bug.cgi?id=194227
<rdar://problem/47791087>

Reviewed by Eric Carlson.

Source/WebCore:

Check that the CSS string starts with '::cue' and is successfully parsed before adding it
to the CSS stylesheet list. Also, the caption preferences CSS string should start with
'::cue', since it is added inside the video shadow root element.

Test: media/track/track-cue-css.html

  • html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::checkAndStoreStyleSheet):
  • page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):

LayoutTests:

  • media/track/captions-webvtt/css-styling.vtt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241455] by Alan Coon
  • 10 edits in branches/safari-607-branch

Cherry-pick r241200. rdar://problem/47971541

Running RTCRtpSender.getCapabilities("video") before initial offer breaks VP8
​https://bugs.webkit.org/show_bug.cgi?id=194380
<rdar://problem/47916514>

Reviewed by Eric Carlson.

Source/WebCore:

Set whether VP8 is supported at creation of the page.
This ensures that any call creating a peer connection factory will end up supporting the runtime flag configuration.

Add internal API to enable resetting the factory to enable proper testing.

Covered by updated test.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend):
  • page/Page.cpp: (WebCore::m_applicationManifest):
  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:
  • testing/Internals.cpp: (WebCore::Internals::clearPeerConnectionFactory):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • webrtc/video-mute-vp8-expected.txt:
  • webrtc/video-mute-vp8.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 PM Changeset in webkit [241454] by Alan Coon
  • 6 edits in branches/safari-607-branch

Cherry-pick r241198. rdar://problem/47971587

[WebIDL] Support serializing sequences and FrozenArrays of non-interfaces
​https://bugs.webkit.org/show_bug.cgi?id=190997
<rdar://problem/35983035>

Reviewed by Brent Fulgham.

Source/WebCore:

Support serializing sequences and FrozenArrays of types that aren't interfaces. This is
needed to properly serialize PaymentAddress, which has a FrozenArray of DOMStrings.

We should support serializing sequences of interfaces too, but that's slightly more
complicated since it involves iterating the sequence and serializing each of its items. I
left that as a follow-up task, since I don't see any IDLs that currently need this.

We also don't support serializing sequences with the CachedAttribute or CustomGetter
extended attributes, because WebIDL specifies that a new array should be created when
converting an IDL sequence into an ECMAScript value.

Added bindings test cases to TestSerialization.idl and PaymentAddress test cases to
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html.

  • bindings/scripts/CodeGenerator.pm: (GetInterfaceForType): Renamed from GetInterfaceForAttribute. (IsSerializableType): Modified to allow sequences and FrozenArrays of non-interface types. (hasCachedAttributeOrCustomGetterExtendedAttribute): Added a helper to determine if an attribute has the CachedAttribute or CustomGetter extended attributes. (IsSerializableAttribute): Checked for sequences with the CachedAttribute or CustomGetter extended attributes before calling IsSerializableType. (GetInterfaceForAttribute): Renamed to GetInterfaceForType.
  • bindings/scripts/test/JS/JSTestSerialization.cpp:
  • bindings/scripts/test/TestSerialization.idl:

LayoutTests:

  • http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:10 PM Changeset in webkit [241453] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Fix -Wformat warning from r241401
​https://bugs.webkit.org/show_bug.cgi?id=194584
<rdar://problem/47761293>

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

12:49 PM Changeset in webkit [241452] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Make WebRTCUnifiedPlanEnabled true by default
​https://bugs.webkit.org/show_bug.cgi?id=194595

Reviewed by Eric Carlson.

  • Shared/WebPreferences.yaml:
12:47 PM Changeset in webkit [241451] by wilander@apple.com
  • 37 edits
    1 copy
    3 adds in trunk

Store Ad Click Attribution requests in the network process
​https://bugs.webkit.org/show_bug.cgi?id=194510
<rdar://problem/47650118>

Reviewed by Alex Christensen and Daniel Bates.

Source/WebCore:

Test: http/tests/adClickAttribution/store-ad-click-attribution.html

This patch adds support functions for validation and storage of
WebCore::AdClickAttribution objects. It also adds WTF::HashTraits so that
WebCore::AdClickAttribution::Source and WebCore::AdClickAttribution::Destination
can be used in a HashMap.

  • loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::toString const):

  • loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Source::operator== const):
(WebCore::AdClickAttribution::Source::deletedValue):
(WebCore::AdClickAttribution::Source::constructDeletedValue):
(WebCore::AdClickAttribution::Source::deleteValue):
(WebCore::AdClickAttribution::Source::isDeletedValue const):
(WebCore::AdClickAttribution::SourceHash::hash):
(WebCore::AdClickAttribution::SourceHash::equal):
(WebCore::AdClickAttribution::Destination::operator== const):
(WebCore::AdClickAttribution::Destination::matches const):

This convenience function allows matching of a WTF::URL object.

(WebCore::AdClickAttribution::Destination::deletedValue):
(WebCore::AdClickAttribution::Destination::constructDeletedValue):
(WebCore::AdClickAttribution::Destination::deleteValue):
(WebCore::AdClickAttribution::Destination::isDeletedValue const):
(WebCore::AdClickAttribution::DestinationHash::hash):
(WebCore::AdClickAttribution::DestinationHash::equal):
(WebCore::AdClickAttribution::source const):
(WebCore::AdClickAttribution::destination const):

Getters added to support mapped storage based on source and destination.

(WTF::HashTraits<WebCore::AdClickAttribution::Source>::emptyValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Source>::constructDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Source>::isDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::emptyValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::constructDeletedValue):
(WTF::HashTraits<WebCore::AdClickAttribution::Destination>::isDeletedValue):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::adClickAttribution const):
(WebCore::NavigationAction::adClickAttribution): Deleted.

Corrected the constness of this function.

Source/WebKit:

With this patch, WebPageProxy::didCommitLoadForFrame() now looks for
an AdClickAttribution object in its navigation state. If there is an
attribution, it sends it to the network process where the
WebKit::NetworkSession stores it in an object of a new class,
WebKit::NetworkAdClickAttribution.

This patch also covers test infrastructure to support two new
TestRunner functions:

  • dumpAdClickAttribution()
  • clearAdClickAttribution()
  • NetworkProcess/Cookies/WebCookieManager.cpp:

Added missing header include.

  • NetworkProcess/Downloads/DownloadManager.cpp:

Added missing header include.

  • NetworkProcess/NetworkAdClickAttribution.cpp: Added.

(WebKit::NetworkAdClickAttribution::ensureDestinationMapForSource):
(WebKit::NetworkAdClickAttribution::store):
(WebKit::NetworkAdClickAttribution::clear):
(WebKit::NetworkAdClickAttribution::toString const):

  • NetworkProcess/NetworkAdClickAttribution.h: Added.

Stores WebCore::AdClickAttribution objects in a map structure.

  • NetworkProcess/NetworkLoad.cpp:

Added missing header includes.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::storeAdClickAttribution):
(WebKit::NetworkProcess::dumpAdClickAttribution):
(WebKit::NetworkProcess::clearAdClickAttribution):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::storeAdClickAttribution):
(WebKit::NetworkSession::dumpAdClickAttribution):
(WebKit::NetworkSession::clearAdClickAttribution):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

Added missing header include.

  • Sources.txt:

Added NetworkProcess/NetworkAdClickAttribution.cpp.

  • UIProcess/API/APINavigation.h:

(API::Navigation::adClickAttribution const):

  • UIProcess/API/C/WKPage.cpp:

(WKPageDumpAdClickAttribution):
(WKPageClearAdClickAttribution):

Test infrastructure.

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::dumpAdClickAttribution):
(WebKit::NetworkProcessProxy::clearAdClickAttribution):

Test infrastructure.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):

This is where pending Ad Click Attributions are forwarded to the
network process.

(WebKit::WebPageProxy::dumpAdClickAttribution):
(WebKit::WebPageProxy::clearAdClickAttribution):

Test infrastructure.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::dumpAdClickAttribution):
(WebKit::WebProcessPool::clearAdClickAttribution):

Test infrastructure.

  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Added missing data copying from navigationAction to navigationActionData.

Tools:

This patch adds two TestRunner functions:

  • dumpAdClickAttribution()
  • clearAdClickAttribution()

They call into the network process to dump and clear Ad Click
Attribution state, respectively.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::dumpAdClickAttribution):
(WTR::TestRunner::clearAdClickAttribution):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
(WTR::adClickAttributionStringResultCallback):
(WTR::TestController::dumpAdClickAttribution):
(WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
(WTR::adClickAttributionVoidCallback):
(WTR::TestController::clearAdClickAttribution):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::dumpAdClickAttribution):

  • WebKitTestRunner/TestInvocation.h:

LayoutTests:

Marked "Skip" because the feature is not applicable to WK1.

  • http/tests/adClickAttribution/store-ad-click-attribution-expected.txt: Added.
  • http/tests/adClickAttribution/store-ad-click-attribution.html: Added.
  • platform/wk2/TestExpectations:

Marked "Pass."

12:34 PM Changeset in webkit [241450] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Revert r240434
​https://bugs.webkit.org/show_bug.cgi?id=194600
<rdar://problem/48044566>

Reviewed by Brent Fulgham.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::updateVolume):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume):

12:34 PM Changeset in webkit [241449] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Create a randomized free list for new StructureIDs on StructureIDTable resize.
​https://bugs.webkit.org/show_bug.cgi?id=194566
<rdar://problem/47975502>

Reviewed by Michael Saboff.

Also isolate 32-bit implementation of StructureIDTable out more so the 64-bit
implementation is a little easier to read.

This patch appears to be perf neutral on JetStream2 (as run from the command line).

  • runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::makeFreeListFromRange):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

  • runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):
(JSC::StructureIDTable::deallocateID):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::flushOldTables):

11:24 AM Changeset in webkit [241448] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit

Crash in WebKit::CacheStorage::Engine::cachesRootPath
​https://bugs.webkit.org/show_bug.cgi?id=194588
<rdar://problem/46363997>

Reviewed by Youenn Fablet.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::cachesRootPath):

Salt may have not been initialized yet when the Engine is destroyed.

11:16 AM Changeset in webkit [241447] by Tadeu Zagallo
  • 2 edits in trunk/Source/JavaScriptCore

VariableLengthObject::allocate<T> should initialize objects
​https://bugs.webkit.org/show_bug.cgi?id=194534

Reviewed by Michael Saboff.

buffer() should not be called for empty VariableLengthObjects, but
these cases were not being caught due to the objects not being properly
initialized. Fix it so that allocate calls the constructor and fix the
assertion failues.

  • runtime/CachedTypes.cpp:

(JSC::CachedObject::operator new):
(JSC::VariableLengthObject::allocate):
(JSC::CachedVector::encode):
(JSC::CachedVector::decode const):
(JSC::CachedUniquedStringImpl::decode const):
(JSC::CachedBitVector::encode):
(JSC::CachedBitVector::decode const):
(JSC::CachedArray::encode):
(JSC::CachedArray::decode const):
(JSC::CachedImmutableButterfly::CachedImmutableButterfly):
(JSC::CachedBigInt::decode const):

11:11 AM Changeset in webkit [241446] by Alan Coon
  • 7 edits in trunk/Source

Versioning.

11:05 AM Changeset in webkit [241445] by Alan Coon
  • 1 copy in tags/Safari-608.1.6

Tag Safari-608.1.6.

11:00 AM Changeset in webkit [241444] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Stop using setDefersLoading from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=194315

Reviewed by Jer Noble.

That is what CompletionHandlers are for.

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::setDefersLoading): Deleted.

  • loader/MediaResourceLoader.h:
  • platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::responseReceived):
(WebCore::PlatformMediaResource::stop):
(WebCore::PlatformMediaResource::setDefersLoading): Deleted.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Deleted.

10:54 AM Changeset in webkit [241443] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Generate status-bubble
​https://bugs.webkit.org/show_bug.cgi?id=194572

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._should_show_bubble_for):
(StatusBubble._build_bubbles_for_patch):

10:50 AM Changeset in webkit [241442] by Tadeu Zagallo
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlocks read from disk should not be re-written
​https://bugs.webkit.org/show_bug.cgi?id=194535

Reviewed by Michael Saboff.

Keep track of which CodeBlocks have been read from disk or have already
been serialized in CodeCache.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::write):

  • runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(JSC::CodeCacheMap::fetchFromDiskImpl):

10:35 AM Changeset in webkit [241441] by achristensen@apple.com
  • 13 edits in trunk/Source/WebKit

Remove legacy sync messaging in some IPC code
​https://bugs.webkit.org/show_bug.cgi?id=194561

Reviewed by Geoffrey Garen.

Changing some LegacySync messages to Delayed messages. We should probably rename Delayed to Sync.
There are too many ways to send messages. Let's work to get rid of the old one.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAllowsAnySSLCertificateForWebSocket):
(WebKit::NetworkProcess::processWillSuspendImminently):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::handleKeyboardEvent):
(WebKit::PluginControllerProxy::handleEditingCommand):
(WebKit::PluginControllerProxy::isEditingCommandEnabled):
(WebKit::PluginControllerProxy::handlesPageScaleFactor):
(WebKit::PluginControllerProxy::requiresUnifiedScaleFactor):
(WebKit::PluginControllerProxy::paintEntirePlugin):
(WebKit::PluginControllerProxy::supportsSnapshotting):
(WebKit::PluginControllerProxy::snapshot):
(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
(WebKit::PluginControllerProxy::getFormValue):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::deallocate):
(WebKit::NPObjectMessageReceiver::hasMethod):
(WebKit::NPObjectMessageReceiver::invoke):
(WebKit::NPObjectMessageReceiver::invokeDefault):
(WebKit::NPObjectMessageReceiver::hasProperty):
(WebKit::NPObjectMessageReceiver::getProperty):
(WebKit::NPObjectMessageReceiver::setProperty):
(WebKit::NPObjectMessageReceiver::removeProperty):
(WebKit::NPObjectMessageReceiver::enumerate):
(WebKit::NPObjectMessageReceiver::construct):

  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPObjectMessageReceiver.messages.in:
  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::secItemRequest):

  • UIProcess/mac/SecItemShimProxy.h:
  • UIProcess/mac/SecItemShimProxy.messages.in:
10:30 AM Changeset in webkit [241440] by aakash_jain@apple.com
  • 1 edit
    1 copy
    1 add in trunk/Tools

[ews-app] Add status bubble html template
​https://bugs.webkit.org/show_bug.cgi?id=194571

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/templates: Added.
  • BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
10:06 AM Changeset in webkit [241439] by Alan Coon
  • 7 edits in branches/safari-607-branch/Source

Versioning.

10:02 AM Changeset in webkit [241438] by Alan Coon
  • 4 edits in branches/safari-607-branch/Source

Cherry-pick r241352. rdar://problem/48038900

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:45 AM Changeset in webkit [241437] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

[Cocoa] Switch to CVPixelBufferGetBytesPerRow() for calculating CVPixelBuffer base address size.
​https://bugs.webkit.org/show_bug.cgi?id=194580
<rdar://problem/42727739>

Reviewed by Eric Carlson.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
  • platform/graphics/cv/PixelBufferConformerCV.cpp:

(WebCore::CVPixelBufferGetBytePointerCallback):
(WebCore::PixelBufferConformerCV::createImageFromPixelBuffer):

9:12 AM Changeset in webkit [241436] by sihui_liu@apple.com
  • 3 edits
    6 adds in trunk/LayoutTests

Add two regression tests for reference cycle in IndexedDB
​https://bugs.webkit.org/show_bug.cgi?id=194527

Reviewed by Geoffrey Garen.

  • fast/dom/reference-cycle-leaks.html:
  • platform/win/TestExpectations:

The added tests are failing on win bots for unknown reasons, propably related to webkit.org/b/193540. Skip them
on win.

  • storage/indexeddb/resources/result-request-cycle.js: Added.

(prepareDatabase):

  • storage/indexeddb/resources/value-cursor-cycle.js: Added.

(prepareDatabase):
(onOpen.cursorRequest.onsuccess):

  • storage/indexeddb/result-request-cycle-expected.txt: Added.
  • storage/indexeddb/result-request-cycle.html: Added.
  • storage/indexeddb/value-cursor-cycle-expected.txt: Added.
  • storage/indexeddb/value-cursor-cycle.html: Added.
8:55 AM Changeset in webkit [241435] by Truitt Savell
  • 3 edits in trunk/Source/WebKit

Unreviewed, rolling out r241433.

Broke internal builds.

Reverted changeset:

"Move
UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to
SPI"
​https://bugs.webkit.org/show_bug.cgi?id=194531
​https://trac.webkit.org/changeset/241433

8:40 AM Changeset in webkit [241434] by bshafiei@apple.com
  • 4 edits in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241352. rdar://problem/47941089

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp: (WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:46 AM Changeset in webkit [241433] by graouts@webkit.org
  • 3 edits in trunk/Source/WebKit

Move UIWebTouchEventsGestureRecognizer.activeTouchesByIdentifier to SPI
​https://bugs.webkit.org/show_bug.cgi?id=194531
<rdar://problem/47714562>

Reviewed by Dean Jackson.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cancelPointersForGestureRecognizer:]): We update the referenced Radar since we need to keep the call
to respondsToSelector until the SPI has shipped for OpenSource builds to work.

5:34 AM Changeset in webkit [241432] by graouts@webkit.org
  • 18 edits
    3 adds in trunk

Support simulated mouse events on iOS based on a PlatformTouchEvent
​https://bugs.webkit.org/show_bug.cgi?id=194501
<rdar://problem/46910790>

Reviewed by Dean Jackson.

Source/WebCore:

Add support for two new internal runtime flags to control whether simulated mouse events should be dipatched along with touch events and
whether simulated mousemove events dispatched should automatically trigger the behavior preventDefault() would also trigger. To facilitate
that, we allow for a MouseEvent to be created, much like a PointerEvent, based on a PlatformTouchEvent. Then, we set a flag on Event within
EventTarget::innerInvokeEventListeners() to see whether any page code has been evaluated as a result of a mousemove event being dispatched.
Finally, we also track mouse events when invalidating touch regions provided the required internal runtime flag is on.

Test: fast/events/touch/ios/mouse-events-dispatch-with-touch.html

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Event.cpp:
  • dom/Event.h:

(WebCore::Event::hasEncounteredListener const):
(WebCore::Event::setHasEncounteredListener):

  • dom/EventNames.h:

(WebCore::EventNames::isTouchRelatedEventType const):
(WebCore::EventNames::touchRelatedEventNames const):
(WebCore::EventNames::extendedTouchRelatedEventNames const):
(WebCore::EventNames::isTouchEventType const): Deleted.
(WebCore::EventNames::touchAndPointerEventNames const): Deleted.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::moveNodeToNewDocument):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::defaultEventHandler):

  • dom/ios/MouseEventIOS.cpp: Added.

(WebCore::mouseEventType):
(WebCore::MouseEvent::create):

  • dom/ios/PointerEventIOS.cpp:

(WebCore::pointerEventType):
(WebCore::PointerEvent::create):
(WebCore::eventType): Deleted.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):

  • page/EventHandler.h:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::mouseEventsSimulationEnabled const):
(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::mousemoveEventHandlingPreventsDefaultEnabled const):
(WebCore::RuntimeEnabledFeatures::setMousemoveEventHandlingPreventsDefaultEnabled):

Source/WebKit:

Add two new internal runtime flags to control whether simulated mouse events should be dipatched along with touch events and whether
simulated mousemove events dispatched should automatically trigger the behavior preventDefault() would also trigger. We also ensure
that we correctly create touch tracking regions for mouse events.

  • Shared/WebPreferences.yaml:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateTouchEventTracking):

LayoutTests:

Add a new test to check that we correctly dispatch mouse events as touches occur.

  • fast/events/touch/ios/mouse-events-dispatch-with-touch-expected.txt: Added.
  • fast/events/touch/ios/mouse-events-dispatch-with-touch.html: Added.
  • pointerevents/utils.js:

(prototype.handleEvent):
(prototype._handlePointerEvent):
(prototype._handleMouseEvent):

4:21 AM Changeset in webkit [241431] by Tadeu Zagallo
  • 2 edits in trunk/Source/JavaScriptCore

SourceCode should be copied when generating bytecode for functions
​https://bugs.webkit.org/show_bug.cgi?id=194536

Reviewed by Saam Barati.

The FunctionExecutable might be collected while generating the bytecode
for nested functions, in which case the SourceCode reference would no
longer be valid.

  • runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockForFunctions):

2:12 AM Changeset in webkit [241430] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[GTK][WPE] Don't use DumpJSConsoleLogInStdErr expectation in platform TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=194587

Unreviewed gardening.

  • platform/gtk/TestExpectations: Removed DumpJSConsoleLogInStdErr markers which are marked in top TestExpectations.
  • platform/wpe/TestExpectations: Ditto.
1:58 AM Changeset in webkit [241429] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241402 - [FreeType] Unable to render some Hebrew characters
​https://bugs.webkit.org/show_bug.cgi?id=194498

Reviewed by Michael Catanzaro.

We are failing to find a font for some of the combining character sequences because normalization is failing due
to overflow error. In case of overflow, normalize returns the required length for the normalized characters, so
we should handle that case to resize the output buffer and try again.

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence const):

1:58 AM Changeset in webkit [241428] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241401 - Crash in Page::setActivityState because m_page is null
​https://bugs.webkit.org/show_bug.cgi?id=194584

Reviewed by Antti Koivisto.

Add a null check to avoid the crash. Also add a debug assertion to help diagnose this in the future.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

1:57 AM Changeset in webkit [241427] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241352 - Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp:

(WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

1:57 AM Changeset in webkit [241426] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241351 - Responsiveness timers are too expensive for frequent events
​https://bugs.webkit.org/show_bug.cgi?id=194003

Reviewed by Geoffrey Garen.

With each event, we set a responsivness timer to check if the WebProcess
is responsive, and reset the timer when the WebProcess sends an answer.

For frequent events (e.g. wheel events, mouse force events, etc),
we are spamming the kernel with hundreds of timers per second.
That is a bit inefficient.

Another source of inefficiency comes from the timer implementation
itself. Stopping a RunLoop::Timer removes the timer from every mode
and invalidate the timer. It becomes costly since we do it a lot.

With this patch, I tweak ResponsivenessTimer and its use to minimize
how often we schedule system timers.

The first change is to not stop the timer when we get the stop()
calls if we expect more events to come in. Instead, we keep track
if we care about the timeout or not in the attribute "m_waitingForTimer".
When the next event starts, we can reschedule the timer without ever
having told the kernel about the stop.
If there are no next events, the timeout fires but m_waitingForTimer
is false. To avoid idle wake up, the lazy stop is only used when having
following events is common.

The second improvements comes from not even rescheduling the timer
when restarted. Instead of changing the timer, we let the original timer
fire and re-shedule a new one with the missing time.

For more context, also see patches r240759 and r240944.

  • UIProcess/ResponsivenessTimer.cpp:

(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::invalidate):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(WebKit::ResponsivenessTimer::startWithLazyStop):
(WebKit::ResponsivenessTimer::stop):
(WebKit::ResponsivenessTimer::processTerminated):
(WebKit::ResponsivenessTimer::~ResponsivenessTimer): Deleted.

  • UIProcess/ResponsivenessTimer.h:

(WebKit::ResponsivenessTimer::hasActiveTimer const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::isResponsiveWithLazyStop):

  • UIProcess/WebProcessProxy.h:
1:57 AM Changeset in webkit [241425] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241350 - Unreviewed, rolling out r241273.
​https://bugs.webkit.org/show_bug.cgi?id=194579

This change is causing a flaky assertion failure crash in High
Sierra Debug (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Stop using setDefersLoading from WebCore"
​https://bugs.webkit.org/show_bug.cgi?id=194315
​https://trac.webkit.org/changeset/241273

1:57 AM Changeset in webkit [241424] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merge r241338 - WebServiceWorkerProvider::handleFetch no longer needs a CachedResource parameter
​https://bugs.webkit.org/show_bug.cgi?id=194548

Reviewed by Alex Christensen.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::handleFetch):

  • WebProcess/Storage/WebServiceWorkerProvider.h:
1:57 AM Changeset in webkit [241423] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

Merge r241335 - Make B3Value::returnsBool() more precise
​https://bugs.webkit.org/show_bug.cgi?id=194457

Reviewed by Saam Barati.

It is currently used repeatedly in B3ReduceStrength, as well as once in B3LowerToAir.
It has a needlessly complex rule for BitAnd, and has no rule for other easy cases such as BitOr or Select.
No new tests added as this should be indirectly tested by the already existing tests.

  • b3/B3Value.cpp:

(JSC::B3::Value::returnsBool const):

1:57 AM Changeset in webkit [241422] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24

Merge r241333 - Align with Fetch on data: URLs
​https://bugs.webkit.org/show_bug.cgi?id=182325

Patch by Rob Buis <​rbuis@igalia.com> on 2019-02-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectations.

  • web-platform-tests/fetch/data-urls/processing.any-expected.txt:
  • web-platform-tests/fetch/data-urls/processing.any.worker-expected.txt:

Source/WebCore:

The MIME type part of the data url should be serialized as
specified in step 3 under "data" [1].

Test: web-platform-tests/fetch/data-urls/processing.any.js

[1] ​https://fetch.spec.whatwg.org/#concept-scheme-fetch

  • platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::parseMediaType):

1:57 AM Changeset in webkit [241421] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Merege r241330 - Remove firing assertion after r241317
​https://bugs.webkit.org/show_bug.cgi?id=194506

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::setDefersLoading):
The creation of a PageGroupLoadDeferrer in Chrome.cpp tries to defer loading.
See comments in Chrome::runJavaScriptAlert et al.
This was necessary with WebKitLegacy, so keep it, but it doesn't need to do anything in modern WebKit.

1:57 AM Changeset in webkit [241420] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.24

Merger r241319 - Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

  • fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
  • fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.
1:57 AM Changeset in webkit [241419] by Carlos Garcia Campos
  • 28 edits in releases/WebKitGTK/webkit-2.24

Merge r241317 - Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Reviewed by Brady Eidson.

Source/WebCore:

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::setDefersLoading): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::suspend): Deleted.

  • NetworkProcess/NetworkDataTaskBlob.h:
  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::initialize):
(WebKit::NetworkLoad::setDefersLoading): Deleted.

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkLoadParameters.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::setDefersLoading): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::suspend): Deleted.

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::suspend): Deleted.

  • NetworkProcess/curl/NetworkDataTaskCurl.h:
  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::suspend): Deleted.

  • NetworkProcess/soup/NetworkDataTaskSoup.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::setDefersLoading):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDefersLoading): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

  • platform/wk2/TestExpectations:
1:57 AM Changeset in webkit [241418] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241316 - Unreviewed, fix build warnings after content extensions enablement
​https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

Source/WebCore:

  • contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

  • contentextensions/DFABytecodeCompiler.h:
  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::statusString):

Source/WebKit:

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(toResult):

1:57 AM Changeset in webkit [241417] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241315 - Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
​https://bugs.webkit.org/show_bug.cgi?id=194549

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

  • UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsInTimeRange):

1:56 AM Changeset in webkit [241416] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/JavaScriptCore

MNerge r241314 - Unreviewed, fix -Wimplicit-fallthrough warning after r241140
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

1:56 AM Changeset in webkit [241415] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241308 - Make use of is<SubresourceLoader>
​https://bugs.webkit.org/show_bug.cgi?id=194541

Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveResponse):

  • loader/SubresourceLoader.h:

(isType):

Source/WebKit:

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

1:56 AM Changeset in webkit [241414] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241307 - AX: Fix flaky accessibility/loading-iframe-sends-notification.html
​https://bugs.webkit.org/show_bug.cgi?id=194546

Reviewed by Zalan Bujtas.

This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.

  • accessibility/loading-iframe-sends-notification-expected.txt:
  • accessibility/loading-iframe-sends-notification.html:
1:56 AM Changeset in webkit [241413] by Carlos Garcia Campos
  • 7 edits
    1 add in releases/WebKitGTK/webkit-2.24

Merge r241306 - WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
​https://bugs.webkit.org/show_bug.cgi?id=194522
<rdar://problem/47789393>

Reviewed by Chris Dumez.

Source/WebKit:

The InjectedBundle SPI can retain the WebPage or wrapping objects (WKWebProcessPlugInBrowserContextController/WKBundlePageRef).
This can make it so WebPage::close is called before WebPage::~WebPage, and if the SuspendedPageProxy is reused for a subsequent
navigation to the same domain, the WebProcess is reused with a different WebPage instance with the same PageID, which causes problems
when another WebPage registers message handlers and then the previous WebPage is destroyed, which removes both message handlers.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::mainFrameDidLayout):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

(WebKit::WebProcess::eventDispatcher):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.

(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1:56 AM Changeset in webkit [241412] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24/Source/bmalloc

Merge r241305 - Unreviewed, rolling out r241182.
​https://bugs.webkit.org/show_bug.cgi?id=194547

causes a 2-3% Speedometer2 regression. (Requested by
keith_miller on #webkit).

Reverted changeset:

"bmalloc uses more memory on iOS compared to macOS due to
physical page size differences"
​https://bugs.webkit.org/show_bug.cgi?id=192389
​https://trac.webkit.org/changeset/241182

1:56 AM Changeset in webkit [241411] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.24/Source

Merge r241304 - [WPE][GTK] Unsafe g_unsetenv() use in WebProcessPool::platformInitialize
​https://bugs.webkit.org/show_bug.cgi?id=194370

Reviewed by Darin Adler.

Source/JavaScriptCore:

Change a couple WTFLogAlways to use g_warning, for good measure. Of course this isn't
necessary, but it will make errors more visible.

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::start):
(Inspector::dbusConnectionCallAsyncReadyCallback):

  • inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::start):

Source/WebKit:

It is incorrect to use g_unsetenv() here because it is MT-Unsafe. We know that it is
impossible and unreasonable to expect the application has not started other threads at this
point, and threads will be calling getenv(). WebKit itself has probably already started
threads of its own.

Fortunately, the remote inspector in the web process is already prepared to deal with
failure to connect to the inspector server, so we don't need to do anything except stop
messing with the environment.

Note these files are copies of each other. I'll merge them together in a follow-up patch.

  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

1:56 AM Changeset in webkit [241410] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241302 - Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar
​https://bugs.webkit.org/show_bug.cgi?id=194365
<rdar://problem/47868426>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineRecordBar.js:

(WI.TimelineRecordBar.prototype._handleClick):
Mark the "click" event so that later listeners know it was handled by WI.TimelineRecordBar.

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype._instrumentAdded):
(WI.TimelineOverview.prototype._instrumentRemoved):
(WI.TimelineOverview.prototype._handleGraphsContainerClick): Added.
(WI.TimelineOverview.prototype._handleOverviewGraphRecordSelected): Added.
(WI.TimelineOverview.prototype._recordSelected):
Listen for "click" on the graph container and deselect all records when fired, unless the
click was marked by a WI.TimelineRecordBar.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._recordSelected):
Ensure that all WI.TimelineView update their selected record whenever it changes for any
other WI.TimelineView (or if there is no selected record).

  • UserInterface/Views/TimelineOverviewGraph.js:

(WI.TimelineOverviewGraph.prototype.didLayoutSubtree): Added.
Drive-by: since WI.TimelineRecordBar are reused when combining, we need to re-determine
which one holds the currently selected record.

1:56 AM Changeset in webkit [241409] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebInspectorUI

Merge r241301 - Web Inspector: Remove unused maxUsage in CPUTimelineView
​https://bugs.webkit.org/show_bug.cgi?id=194526

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

  • UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView):
(WI.CPUTimelineView.prototype.shown):

1:56 AM Changeset in webkit [241408] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241300 - Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

  1. a Document detaches from its StyleSheetList.
  2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
  3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

  1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

  1. Fix CodeGeneratorJS.pm to null check the opaque root before using it.
  • bindings/js/JSNodeCustom.h:

(WebCore::root):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

1:56 AM Changeset in webkit [241407] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/LayoutTests

Merge r241298 - Unreviewed WPE gardening. Unskip content extensions tests after r241283

  • platform/wpe/TestExpectations: Unskip content extensions tests, and list

as failing those known to not pass due to missing expectaions or timeouts.

1:56 AM Changeset in webkit [241406] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241296 - Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

1:56 AM Changeset in webkit [241405] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24/Source/WebCore

Merge r241295 - [LFC] Remove redundant InlineFormattingContext::computeBorderAndPadding
​https://bugs.webkit.org/show_bug.cgi?id=194540

Reviewed by Antti Koivisto.

Use FormattingContext::computeBorderAndPadding instead.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeBorderAndPadding const):

  • layout/FormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
1:56 AM Changeset in webkit [241404] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.24

Merge r241294 - [LFC][IFC] Add intrinsic width support for float boxes.
​https://bugs.webkit.org/show_bug.cgi?id=194528

Reviewed by Antti Koivisto.

Source/WebCore:

This patch implements a very simple float box support for intrinsic width.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFloatBox const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForInlineBlock const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:

Tools:

Expand tests coverage (2 new tests -> 800).
(This is the correct test ordering --runs-singly --child-processes=1)

  • LayoutReloaded/misc/LFC-passing-tests.txt:
1:12 AM Changeset in webkit [241403] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241131. rdar://problem/47627599

Print backgrounds preference should be honored instead of WKWebViewConfiguration value
​https://bugs.webkit.org/show_bug.cgi?id=194364
<rdar://problem/47627599>

Reviewed by Tim Horton.

Without this patch, changing the preference for printing the background has no effect.
This patch fixes that, and I verified it manually by checking "Print backgrounds" in Safari's print menu.
Unfortunately, the only way to test this is actually printing because only values from WebPageProxy::preferences
or WebPageProxy::configuration's preferences are exposed to the API, but values from WebPageProxy::preferencesStore
are used when printing. Actually printing verifies this change fixes the bug.

  • UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:10 AM Changeset in webkit [241402] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[FreeType] Unable to render some Hebrew characters
​https://bugs.webkit.org/show_bug.cgi?id=194498

Reviewed by Michael Catanzaro.

We are failing to find a font for some of the combining character sequences because normalization is failing due
to overflow error. In case of overflow, normalize returns the required length for the normalized characters, so
we should handle that case to resize the output buffer and try again.

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence const):

1:07 AM Changeset in webkit [241401] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Crash in Page::setActivityState because m_page is null
​https://bugs.webkit.org/show_bug.cgi?id=194584

Reviewed by Antti Koivisto.

Add a null check to avoid the crash. Also add a debug assertion to help diagnose this in the future.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActivityState):

1:05 AM Changeset in webkit [241400] by bshafiei@apple.com
  • 32 edits
    7 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241282. rdar://problem/45929460

[iOS] Mouse/Touch/Pointer events are missing modifier keys
​https://bugs.webkit.org/show_bug.cgi?id=191446
<rdar://problem/45929460>

Reviewed by Tim Horton.

Source/WebCore:

Extract the modifier flags from the WebEvent. This code is only used by Legacy WebKit
on iOS and we will need to fix <rdar://problem/47929759> in order for modifier flags
to be passed to WebKit.

Tests: fast/events/touch/ios/mouse-events-with-modifiers.html

fast/events/touch/ios/pointer-events-with-modifiers.html
fast/events/touch/ios/touch-events-with-modifiers.html

  • platform/ios/PlatformEventFactoryIOS.mm: (WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm: (-[WebEvent initWithMouseEventType:timeStamp:location:]): (-[WebEvent initWithMouseEventType:timeStamp:location:modifiers:]):

Source/WebKit:

Make use of UIKit SPI to retreive the modifier flags when dispatching mouse and touch events.
Add new WebKit SPI for iOS, -[WKNavigationAction modifierFlags], to retrieve the the modifier
flags held when a navigation action was initiated.

  • Platform/spi/ios/UIKitSPI.h: Expose SPI.
  • Shared/NativeWebTouchEvent.h: Re-arrange macro guards so that we can expose the helper function WebKit::webEventModifierFlags(). This is a bit more involved that usual since this header is included from both C++ and Objective-C source files. It only makes sense to expose this function when compiling as part of an Objective-C source file.
  • Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Modified to take the modifier flags held down when the platform touch event was received and pass them through to the base constructor. (WebKit::webEventModifierFlags): Added. Converts from the platform-speciifc UIKeyModifierFlags to OptionSet<WebKit::WebEvent::Modifier>.
  • Shared/ios/WebIOSEventFactory.h:
  • Shared/ios/WebIOSEventFactory.mm: (WebIOSEventFactory::toUIKeyModifierFlags): Added. Converts from OptionSet<WebKit::WebEvent::Modifier> to the platform-specific UIKeyModifierFlags.
  • UIProcess/API/Cocoa/WKNavigationAction.mm: (-[WKNavigationAction modifierFlags]): Added.
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm: (gestureRecognizerModifierFlags): Added.

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapCommited:]):
Pass modifier flags through.

(-[WKContentView _attemptClickAtLocation:modifierFlags:]): Added.
(-[WKContentView actionSheetAssistant:openElementAtLocation:]): This is invoked when a person opens a link
via the action sheet. We don't have access to the modifier flags to pass. It also seems like an implementation
detail that this action is implemented via mouse click and we should re-evaluate this decision in light of
the fact tht the action sheet is browser UI and we tend to be very reserved on what UI actions are visible
to the page. On Mac, opening a link via the context menu is not visible to the page, at least from a mouse
event perspective.
(webEventFlagsForUIKeyModifierFlags): Added.
(-[WKContentView _hoverGestureRecognizerChanged:]): Pass modifier flags through.
(-[WKContentView _attemptClickAtLocation:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::handleTwoFingerTapAtPoint): (WebKit::WebPageProxy::commitPotentialTap): (WebKit::WebPageProxy::handleTap):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::handleSyntheticClick): (WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver): (WebKit::WebPage::completeSyntheticClick): (WebKit::WebPage::handleTap): (WebKit::WebPage::handleTwoFingerTapAtPoint): (WebKit::WebPage::commitPotentialTap): Pass modifier flags through.

Tools:

Add support infrastructure for testing touch and stylus taps when holding modifier keys.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::arrayLength): (WTR::parseModifierArray): (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers(). (WTR::UIScriptController::singleTapAtPointWithModifiers): Added. (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers(). (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

LayoutTests:

Refactor existing iOS key events tests to share code. Add new tests to ensure touch and mouse events
have accurate modifier key details.

  • fast/events/ios/key-events-meta-alt-combinations.html:
  • fast/events/ios/resources/key-tester.js: (computeSubsets.compareByModifierOrder): Deleted.
  • fast/events/resources/compute-subsets.js: Added. (computeSubsets.compareByOriginalArrayOrder): (computeSubsets):
  • fast/events/touch/ios/mouse-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/mouse-events-with-modifiers.html: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers.html: Added.
  • fast/events/touch/ios/touch-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/touch-events-with-modifiers.html: Added.
  • http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Update expected result due to changes to ui-helper.js.
  • http/tests/security/anchor-download-block-crossorigin-expected.txt: Ditto.
  • platform/ios/TestExpectations:
  • resources/ui-helper.js: (window.UIHelper.tapAt.return.new.Promise): (window.UIHelper.tapAt): (window.UIHelper.stylusTapAt.return.new.Promise): (window.UIHelper.stylusTapAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:05 AM Changeset in webkit [241399] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241007. rdar://problem/47836218

Fix a typo in r241006. Substitute Modifier for Modifiers.

  • Shared/mac/NativeWebGestureEventMac.mm: (WebKit::NativeWebGestureEvent::NativeWebGestureEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:05 AM Changeset in webkit [241398] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241006. rdar://problem/47836218

Attempt to fix the build following r241000
(​https://bugs.webkit.org/show_bug.cgi?id=194241)

Substitute OptionSet<WebEvent::Modifier> for Modifiers.

  • Shared/mac/NativeWebGestureEventMac.mm: (WebKit::NativeWebGestureEvent::NativeWebGestureEvent):
  • Shared/mac/WebGestureEvent.h: (WebKit::WebGestureEvent::WebGestureEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241397] by bshafiei@apple.com
  • 8 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241001. rdar://problem/47836218

Attempt to fix the build following r241000
(​https://bugs.webkit.org/show_bug.cgi?id=194241)

Substitute WebEvent::Modifier::CapsLockKey for WebEvent::CapsLockKey.

  • Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent):
  • Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent):
  • UIProcess/API/Cocoa/WKNavigationAction.mm: (toNSEventModifierFlags):
  • UIProcess/Automation/WebAutomationSession.cpp: (WebKit::protocolModifierToWebEventModifier):
  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::modifiersToEventState):
  • UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
  • UIProcess/Cocoa/UIDelegate.mm: (WebKit::toNSEventModifierFlags):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241396] by bshafiei@apple.com
  • 43 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241000. rdar://problem/47836218

Make WebEvent::Modifiers an OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=194241

Reviewed by Simon Fraser.

Use an OptionSet to represent the bitmask of keyboard modifier flags. This improves type safety
and makes debugging more enjoyable because our LLDB pretty-printers have built-in support for
OptionSet.

While I am at it, make WebEvent::Modifier an enum class. It is currently an enum. This makes
this enum more closely match WebCore::PlatformEvent::Modifier.

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI):
  • Shared/NavigationActionData.cpp: (WebKit::NavigationActionData::encode const): (WebKit::NavigationActionData::decode):
  • Shared/NavigationActionData.h:
  • Shared/WebEvent.cpp: (WebKit::WebEvent::WebEvent):
  • Shared/WebEvent.h: (WebKit::WebEvent::shiftKey const): (WebKit::WebEvent::controlKey const): (WebKit::WebEvent::altKey const): (WebKit::WebEvent::metaKey const): (WebKit::WebEvent::capsLockKey const): (WebKit::WebEvent::modifiers const): (WebKit::WebTouchEvent::WebTouchEvent):
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
  • Shared/WebKeyboardEvent.cpp: (WebKit::WebKeyboardEvent::WebKeyboardEvent):
  • Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent):
  • Shared/WebTouchEvent.cpp: (WebKit::WebTouchEvent::WebTouchEvent):
  • Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent):
  • Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent):
  • Shared/ios/NativeWebTouchEventIOS.mm: (WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
  • Shared/ios/WebIOSEventFactory.mm: (modifiersForEvent): (WebIOSEventFactory::createWebKeyboardEvent): (WebIOSEventFactory::createWebMouseEvent):
  • Shared/libwpe/WebEventFactory.cpp: (WebKit::modifiersForEventModifiers): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebTouchEvent):
  • Shared/mac/WebEventFactory.mm: (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/win/WebEventFactory.cpp: (WebKit::modifiersForEvent): (WebKit::modifiersForCurrentKeyState): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • UIProcess/API/APINavigationAction.h:
  • UIProcess/API/APIUIClient.h: (API::UIClient::mouseDidMoveOverElement):
  • UIProcess/API/C/WKPage.cpp: (WKPageSetPageUIClient):
  • UIProcess/API/Cocoa/WKNavigationAction.mm: (toNSEventModifierFlags):
  • UIProcess/API/glib/WebKitPrivate.cpp: (toPlatformModifiers):
  • UIProcess/API/glib/WebKitPrivate.h:
  • UIProcess/API/glib/WebKitUIClient.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewMouseTargetChanged):
  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::simulateMouseInteraction): (WebKit::protocolModifierToWebEventModifier): (WebKit::WebAutomationSession::performMouseInteraction):
  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp: (WebKit::modifiersToEventState): (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
  • UIProcess/Automation/mac/WebAutomationSessionMac.mm: (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
  • UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp: (WebKit::modifiersToEventState): (WebKit::WebAutomationSession::platformSimulateMouseInteraction):
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm: (WebKit::toNSEventModifierFlags): (WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::mouseDidMoveOverElement):
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h: (API::InjectedBundle::PageUIClient::mouseDidMoveOverElement):
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: (WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: (WebKit::InjectedBundleNavigationAction::modifiers const):
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: (WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::showContextMenuAtPoint):
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::createWebEvent const):
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::mouseDidMoveOverElement):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::simulateMouseDown): (WebKit::WebPage::simulateMouseUp): (WebKit::WebPage::simulateMouseMotion):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241395] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241332. rdar://problem/47974770

[iOS] Youtube fails to play.
​https://bugs.webkit.org/show_bug.cgi?id=194565
<rdar://problem/47974770>

Reviewed by Geoffrey Garen.

This is caused by sandbox violations and was introduced in r240500.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241394] by bshafiei@apple.com
  • 5 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241323. rdar://problem/42087017

Find on Page shouldn't zoom in on matches
​https://bugs.webkit.org/show_bug.cgi?id=194557
<rdar://problem/42087017>

Reviewed by Wenson Hsieh.

  • UIProcess/ios/SmartMagnificationController.h:
  • UIProcess/ios/SmartMagnificationController.messages.in:
  • UIProcess/ios/SmartMagnificationController.mm: (WebKit::SmartMagnificationController::scrollToRect):
  • WebProcess/WebPage/ios/FindControllerIOS.mm: (WebKit::FindController::updateFindIndicator): Only scroll to reveal the find result, do not zoom in.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241393] by bshafiei@apple.com
  • 3 edits
    2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241319. rdar://problem/47857150

Source/WebCore:
Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp: (WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

  • fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
  • fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241392] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241314. rdar://problem/47889777

Unreviewed, fix -Wimplicit-fallthrough warning after r241140
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241391] by bshafiei@apple.com
  • 7 edits in branches/safari-608.1.5.1-branch/Source

Cherry-pick r241309. rdar://problem/47924449

REGRESSION (r238955, r240494): Soft-linking optional Lookup.framework triggers release assertion when missing
<​https://webkit.org/b/194529>
<rdar://problem/47924449>

Reviewed by Eric Carlson.

Source/WebCore:

  • SourcesCocoa.txt:
  • Do not include DataDetectorsCoreSoftLink.mm in unified sources.
  • WebCore.xcodeproj/project.pbxproj:
  • Add DataDetectorsCoreSoftLink.mm to the WebCore target now that it isn't part of the unifed sources.
  • platform/cocoa/DataDetectorsCoreSoftLink.mm:
  • Switch from using SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL() to SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE() when linking DataDetectorsCore.framework. None of the other macros assume this framework is optional, and it was likely made optional originally because the framework was new to iOS and thus didn't exist on older versions.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • Change use of SOFT_LINK_CLASS_FOR_SOURCE() macros to SOFT_LINK_CLASS() since the latter can only be used with SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation). This broke after the fix for <wtf/SoftLinking.h> was applied.

Source/WTF:

  • wtf/cocoa/SoftLinking.h: (SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL): Rename SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION() to this and change assertion argument to isOptional. Pass isOptional to framework##Library() method to control assertion behavior. Only check RELEASE_ASSERT() if !isOptional, else that code should be optimized out by the compiler. This fixes the crash. (NO_ASSERT): Remove macro since it's no longer used. (SOFT_LINK_IS_OPTIONAL): Add macro to use for soft-linking optional classes. (SOFT_LINK_IS_NOT_OPTIONAL): Add macro to use for soft-linking non-optional classes. (SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT): Update to use new SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL() macro. (SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT): Ditto. (SOFT_LINK_CLASS_FOR_SOURCE): Ditto. (SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241390] by bshafiei@apple.com
  • 4 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241300. rdar://problem/47973274

Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

  1. a Document detaches from its StyleSheetList.
  2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
  3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

  1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

  1. Fix CodeGeneratorJS.pm to null check the opaque root before using it.
  • bindings/js/JSNodeCustom.h: (WebCore::root):
  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation):
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: (WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241389] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241296. rdar://problem/47841926

Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

  • page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241388] by bshafiei@apple.com
  • 11 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241289. rdar://problem/37018386

AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
​https://bugs.webkit.org/show_bug.cgi?id=182280
<rdar://problem/37018386>

Reviewed by Alan Bujtas.

Source/WebCore:

Remove the possibility that changing children calls back into updating layout by
handling children changes in a deferred manner.

This follows the same architecture as many other deferred changes, but also requires us to check deferred changes
in updateBackingStore, because things like aria-hidden changes won't trigger a layout, but will require us to update children.

A few tests had to be modified to no longer change the tree and then check the children immediately.

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::remove): (WebCore::AXObjectCache::childrenChanged): (WebCore::AXObjectCache::prepareForDocumentDestruction): (WebCore::AXObjectCache::performDeferredCacheUpdate):
  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::updateBackingStore):
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (convertToNSArray): (-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

  • accessibility/aria-hidden-update.html:
  • accessibility/aria-hidden-updates-alldescendants.html:
  • accessibility/image-load-on-delay.html:
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
  • accessibility/removed-anonymous-block-child-causes-crash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241387] by bshafiei@apple.com
  • 25 edits
    2 adds
    2 deletes in branches/safari-608.1.5.1-branch

Cherry-pick r241288. rdar://problem/41892438

[Cocoa] Ask platform for generic font family mappings
​https://bugs.webkit.org/show_bug.cgi?id=187723
<rdar://problem/41892438>

Reviewed by Brent Fulgham.

Source/WebCore:

WebKit API allows setting the generic font families for the USCRIPT_COMMON script.
When trying to style a character with a generic font family, we first look to see if
we have a mapping for the particular script the character is rendered with, and if we
don't find a match, we then check USCRIPT_COMMON.

In the Cocoa ports, the only way families get set for non-USCRIPT_COMMON scripts (aka
the only scripts which won't use the API families) is in
SettingsBase::initializeDefaultFontFamilies(). That function only sets the families
for the CJK scripts.

The mappings inside SettingsBase are incorrect and conflict with our policy regarding
user-installed fonts. Instead, we should be consulting with the platform for some of
these mappings, by calling CTFontDescriptorCreateForCSSFamily(). However, the WebKit
API still has to work to set the mappings for untagged content. Therefore, we use the
system mappings for language-tagged content, and the API mappings for non-language-tagged
content. This is a good balance that makes sure we always have a good mapping for every
language, but API clients can still set the mappings, too.

Test: fast/text/ja-sans-serif.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSFontSelector.cpp: (WebCore::resolveGenericFamily):
  • css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontFamily):
  • page/cocoa/SettingsBaseCocoa.mm: (WebCore::SettingsBase::initializeDefaultFontFamilies): (WebCore::osakaMonoIsInstalled): Deleted.
  • platform/graphics/FontDescription.cpp: (WebCore::FontDescription::platformResolveGenericFamily):
  • platform/graphics/FontDescription.h:
  • platform/graphics/cocoa/FontDescriptionCocoa.cpp: (WebCore::computeSpecializedChineseLocale): (WebCore::cachedSpecializedChineseLocale): (WebCore::languageChanged): (WebCore::FontDescription::platformResolveGenericFamily):
  • platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::clear): (WebCore::genericFamily): (WebCore::SystemFontDatabaseCoreText::serifFamily): (WebCore::SystemFontDatabaseCoreText::sansSerifFamily): (WebCore::SystemFontDatabaseCoreText::cursiveFamily): (WebCore::SystemFontDatabaseCoreText::fantasyFamily): (WebCore::SystemFontDatabaseCoreText::monospaceFamily):
  • platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

Source/WebCore/PAL:

  • pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

Add an ENABLE in Platform.

  • wtf/Platform.h:

Tools:

Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().

  • DumpRenderTree/mac/DumpRenderTree.mm: (allowedFontFamilySet):
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::allowedFontFamilySet):

LayoutTests:

Update the tests to work with this new model.

  • fast/text/international/font-fallback-to-common-script-expected.html: Removed.
  • fast/text/international/font-fallback-to-common-script.html: Removed.
  • fast/text/international/lang-sensitive-fonts-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml.xhtml:
  • fast/text/international/lang-sensitive-fonts.html:
  • fast/text/international/locale-sensitive-fonts-expected.html:
  • fast/text/international/locale-sensitive-fonts.html:
  • fast/text/ja-sans-serif-expected-mismatch.html: Added.
  • fast/text/ja-sans-serif.html: Added.
  • platform/ios/fast/block/float/016-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241386] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241267. rdar://problem/36380852

Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor.
​https://bugs.webkit.org/show_bug.cgi?id=194493
<rdar://problem/36380852>

Reviewed by Yusuke Suzuki.

Having duplicate cases in the BinarySwitch is not a correctness issue. It is
however not good for performance and memory usage. As such, a debug ASSERT will
do. We'll also do an audit of the clients of BinarySwitch to see if it's
possible to be instantiated with duplicate cases in
​https://bugs.webkit.org/show_bug.cgi?id=194492 later.

Also added some value dumps to the RELEASE_ASSERT to help debug the issue when we
see duplicate cases.

  • jit/BinarySwitch.cpp: (JSC::BinarySwitch::BinarySwitch):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241385] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241231. rdar://problem/42423999

[Cocoa] CTLineGetGlyphRuns() might return nullptr
​https://bugs.webkit.org/show_bug.cgi?id=194467
<rdar://problem/42423999>

Reviewed by Simon Fraser.

Be somewhat defensive to try to make sure this sort of thing doesn't happen in the future.

Covered by find/text/find-backwards.html

  • platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241384] by bshafiei@apple.com
  • 14 edits
    1 add in branches/safari-608.1.5.1-branch

Cherry-pick r241228. rdar://problem/47844327

Nodes that rely on being dominated by CheckInBounds should have a child edge to it
​https://bugs.webkit.org/show_bug.cgi?id=194334
<rdar://problem/47844327>

Reviewed by Mark Lam.

JSTests:

  • stress/check-in-bounds-should-be-a-child-use.js: Added. (func):

Source/JavaScriptCore:

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants):
  • dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::convertToHasIndexedProperty):
  • dfg/DFGIntegerCheckCombiningPhase.cpp: (JSC::DFG::IntegerCheckCombiningPhase::handleBlock):
  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
  • dfg/DFGNodeType.h:
  • dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::lowerBoundsCheck):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCheckInBounds): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 AM Changeset in webkit [241383] by bshafiei@apple.com
  • 4 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241210. rdar://problem/47926792

Fix DFG's doesGC() for CheckTierUp*, GetByVal, PutByVal*, and StringCharAt nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194446
<rdar://problem/47926792>

Reviewed by Saam Barati.

Fix doesGC() for the following nodes:

CheckTierUpAtReturn:

Calls triggerTierUpNow(), which calls triggerFTLReplacementCompile(),
which calls Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpInLoop:

Calls triggerTierUpNowInLoop(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

CheckTierUpAndOSREnter:

Calls triggerOSREntryNow(), which calls tierUpCommon(), which calls
Worklist::completeAllReadyPlansForVM(), which uses DeferGC.

GetByVal:

case Array::String calls operationSingleCharacterString(), which calls
jsSingleCharacterString(), which can allocate a string.

PutByValDirect:
PutByVal:
PutByValAlias:

For the DFG only, the integer TypeArrays calls compilePutByValForIntTypedArray(),
which may call slow paths operationPutByValDirectStrict(), operationPutByValDirectNonStrict(),
operationPutByValStrict(), or operationPutByValNonStrict(). All of these
slow paths call putByValInternal(), which may create exception objects, or
call the generic JSValue::put() which may execute arbitrary code.

StringCharAt:

Can call operationSingleCharacterString(), which calls jsSingleCharacterString(),
which can allocate a string.

Also fix DFG::SpeculativeJIT::compileGetByValOnString() and FTL's compileStringCharAt()
to use the maxSingleCharacterString constant instead of a literal constant.

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnString):
  • dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241382] by bshafiei@apple.com
  • 5 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241203. rdar://problem/47791087

[WebVTT] Inline WebVTT styles should start with '::cue'
​https://bugs.webkit.org/show_bug.cgi?id=194227
<rdar://problem/47791087>

Reviewed by Eric Carlson.

Source/WebCore:

Check that the CSS string starts with '::cue' and is successfully parsed before adding it
to the CSS stylesheet list. Also, the caption preferences CSS string should start with
'::cue', since it is added inside the video shadow root element.

Test: media/track/track-cue-css.html

  • html/track/WebVTTParser.cpp: (WebCore::WebVTTParser::checkAndStoreStyleSheet):
  • page/CaptionUserPreferencesMediaAF.cpp: (WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride const):

LayoutTests:

  • media/track/captions-webvtt/css-styling.vtt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241381] by bshafiei@apple.com
  • 10 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241200. rdar://problem/47916514

Running RTCRtpSender.getCapabilities("video") before initial offer breaks VP8
​https://bugs.webkit.org/show_bug.cgi?id=194380
<rdar://problem/47916514>

Reviewed by Eric Carlson.

Source/WebCore:

Set whether VP8 is supported at creation of the page.
This ensures that any call creating a peer connection factory will end up supporting the runtime flag configuration.

Add internal API to enable resetting the factory to enable proper testing.

Covered by updated test.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp: (WebCore::createLibWebRTCPeerConnectionBackend):
  • page/Page.cpp: (WebCore::m_applicationManifest):
  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:
  • testing/Internals.cpp: (WebCore::Internals::clearPeerConnectionFactory):
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • webrtc/video-mute-vp8-expected.txt:
  • webrtc/video-mute-vp8.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241380] by bshafiei@apple.com
  • 6 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241198. rdar://problem/35983035

[WebIDL] Support serializing sequences and FrozenArrays of non-interfaces
​https://bugs.webkit.org/show_bug.cgi?id=190997
<rdar://problem/35983035>

Reviewed by Brent Fulgham.

Source/WebCore:

Support serializing sequences and FrozenArrays of types that aren't interfaces. This is
needed to properly serialize PaymentAddress, which has a FrozenArray of DOMStrings.

We should support serializing sequences of interfaces too, but that's slightly more
complicated since it involves iterating the sequence and serializing each of its items. I
left that as a follow-up task, since I don't see any IDLs that currently need this.

We also don't support serializing sequences with the CachedAttribute or CustomGetter
extended attributes, because WebIDL specifies that a new array should be created when
converting an IDL sequence into an ECMAScript value.

Added bindings test cases to TestSerialization.idl and PaymentAddress test cases to
http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html.

  • bindings/scripts/CodeGenerator.pm: (GetInterfaceForType): Renamed from GetInterfaceForAttribute. (IsSerializableType): Modified to allow sequences and FrozenArrays of non-interface types. (hasCachedAttributeOrCustomGetterExtendedAttribute): Added a helper to determine if an attribute has the CachedAttribute or CustomGetter extended attributes. (IsSerializableAttribute): Checked for sequences with the CachedAttribute or CustomGetter extended attributes before calling IsSerializableType. (GetInterfaceForAttribute): Renamed to GetInterfaceForType.
  • bindings/scripts/test/JS/JSTestSerialization.cpp:
  • bindings/scripts/test/TestSerialization.idl:

LayoutTests:

  • http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241379] by bshafiei@apple.com
  • 3 edits
    2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241171. rdar://problem/47550281

[iOS] Clicking links in Safari using Apple Pencil is much more difficult after r238475
​https://bugs.webkit.org/show_bug.cgi?id=194415
<rdar://problem/47550281>

Reviewed by Tim Horton.

Source/WebKit:

Fix the bug by not firing the Apple-pencil-exclusive tap gesture recognizer in the case where editable images
are disabled. This gesture recognizer is only used for inserting editable images, and currently conflicts with
the synthetic click gesture recognizer used to recognize clicks from generic digitizer inputs.

  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView gestureRecognizerShouldBegin:]): (-[WKContentView _stylusSingleTapRecognized:]):

LayoutTests:

Add a layout test to verify that a stylus tap dispatches clicks.

  • fast/events/touch/ios/pencil-tap-dispatches-click-expected.txt: Added.
  • fast/events/touch/ios/pencil-tap-dispatches-click.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241378] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241170. rdar://problem/47858241

REGRESSION(r239887): Crash under IDBConnectionToClient::didDeleteDatabase(WebCore::IDBResultData const&)
​https://bugs.webkit.org/show_bug.cgi?id=194402
<rdar://problem/47858241>

Reviewed by Geoffrey Garen.

r239887 removed a reference cycle of IDBConnectionToClient so that IDBConnectionToClient would no longer be
around forever. Therefore, ServerOpenRequest should keep a reference to IDBConnectionToClient to make sure it
is valid during access.

  • Modules/indexeddb/server/ServerOpenDBRequest.cpp: (WebCore::IDBServer::ServerOpenDBRequest::maybeNotifyRequestBlocked): (WebCore::IDBServer::ServerOpenDBRequest::notifyDidDeleteDatabase):
  • Modules/indexeddb/server/ServerOpenDBRequest.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241377] by bshafiei@apple.com
  • 11 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241150. rdar://problem/45991585

Overflow element scrollbar is light for dark mode content.
​https://bugs.webkit.org/show_bug.cgi?id=194407
rdar://problem/45991585

Reviewed by Beth Dakin.

Source/WebCore:

Tested by css-dark-mode/supported-color-schemes-scrollbar.html.

  • page/ChromeClient.h: (WebCore::FrameView::preferredScrollbarOverlayStyle): Return WTF::nullopt by default to avoid short-circuiting auto detection in recalculateScrollbarOverlayStyle() for clients, like WK1, that do not implement preferredScrollbarOverlayStyle().
  • page/FrameView.cpp: (WebCore::FrameView::recalculateScrollbarOverlayStyle): Use WTF::nullopt in the false case to auto detect overlay style when page() is null.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::useDarkAppearance const): Added.
  • rendering/RenderLayer.h:
  • testing/Internals.cpp: (WebCore::Internals::scrollbarOverlayStyle const): Added Node argument. (WebCore::Internals::scrollbarUsingDarkAppearance const): Added.
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Updated tests to look at overflow elements and if dark apearance
is used by the scrollbar directly.

  • css-dark-mode/supported-color-schemes-scrollbar-expected.txt:
  • css-dark-mode/supported-color-schemes-scrollbar.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241376] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241143. rdar://problem/47820615

Permit additional IOKit Properties needed by Media PlugIns on older Mac Hardware
​https://bugs.webkit.org/show_bug.cgi?id=194412
<rdar://problem/47820615>

Reviewed by Per Arne Vollan.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241375] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241142. rdar://problem/47820620

Permit additional IOKit Properties needed by older Mac Hardware
​https://bugs.webkit.org/show_bug.cgi?id=194410
<rdar://problem/47820620>

Reviewed by Per Arne Vollan.

  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241374] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r241140. rdar://problem/47889777

Fix more doesGC() for CheckTraps, GetMapBucket, and Switch nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

CheckTraps:

We normally will not emit this node because Options::usePollingTraps() is
false by default. However, as it is implemented now, CheckTraps can GC
because it can allocate a TerminatedExecutionException. If we make the
TerminatedExecutionException a singleton allocated at initialization time,
doesGC() can return false for CheckTraps.
​https://bugs.webkit.org/show_bug.cgi?id=194323

GetMapBucket:

Can call operationJSMapFindBucket() or operationJSSetFindBucket(),
which calls HashMapImpl::findBucket(), which calls jsMapHash(), which
can resolve a rope.

Switch:

If switchData kind is SwitchChar, can call operationResolveRope() .
If switchData kind is SwitchString and the child use kind is not StringIdentUse,

can call operationSwitchString() which resolves ropes.

DirectTailCall:
ForceOSRExit:
Return:
TailCallForwardVarargs:
TailCallVarargs:
Throw:

These are terminal nodes. It shouldn't really matter what doesGC() returns
for them, but following our conservative practice, unless we have a good
reason for doesGC() to return false, we should just return true.

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241373] by bshafiei@apple.com
  • 5 edits
    2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241137. rdar://problem/47259025

Unable to sign in leetcode.
​https://bugs.webkit.org/show_bug.cgi?id=194366
rdar://problem/47259025.

Reviewed by Chris Dumez.

Source/WebCore:

In case a signal is passed as part of a FetchRequestInit,
the IDL binding code is throwing an exception in case signal is not an AbortSignal object.
This breaks an AbortSignal shim used in some web sites.
Relaxed the IDL binding rule by marking signal as any and doing the conversion in FetchRequest.

Test: http/wpt/fetch/request-abort.html
Also covered by manually signing in to leetcode.

  • Modules/fetch/FetchRequest.cpp: (WebCore::FetchRequest::initializeWith):
  • Modules/fetch/FetchRequestInit.h: (WebCore::FetchRequestInit::hasMembers const):
  • Modules/fetch/FetchRequestInit.idl:

LayoutTests:

  • http/wpt/fetch/request-abort-expected.txt: Added.
  • http/wpt/fetch/request-abort.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241372] by bshafiei@apple.com
  • 17 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241130. rdar://problem/47801392

HTMLMediaElement registers wrong ScriptExecutionContext with its ActiveDOMObject parent class
​https://bugs.webkit.org/show_bug.cgi?id=194360

HTMLMediaElement registers the Document used to create it with ActiveDOMObject, when it should
really use that Document's contextDocument(). Rather than just fix this in HTMLMediaElement,
make sure that the correct document is used everywhere by adding a new ActiveDOMObject constructor
taking a Document&, and making an explicitly deleted Document* constructor to catch any new cases.

Reviewed by Geoffrey Garen.

  • Modules/applepay/ApplePaySession.cpp: (WebCore::ApplePaySession::ApplePaySession):
  • Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::MediaRecorder):
  • Modules/mediastream/MediaDevices.cpp: (WebCore::MediaDevices::MediaDevices):
  • Modules/mediastream/UserMediaRequest.cpp: (WebCore::UserMediaRequest::UserMediaRequest):
  • Modules/notifications/Notification.cpp: (WebCore::Notification::Notification):
  • Modules/paymentrequest/PaymentRequest.cpp: (WebCore::PaymentRequest::PaymentRequest):
  • Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
  • animation/WebAnimation.cpp: (WebCore::WebAnimation::WebAnimation):
  • css/FontFaceSet.cpp: (WebCore::FontFaceSet::FontFaceSet):
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject):
  • dom/ActiveDOMObject.h:
  • dom/Document.h: (WebCore::ActiveDOMObject::ActiveDOMObject):
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::HTMLMarqueeElement):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement):
  • page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::IntersectionObserver):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241371] by bshafiei@apple.com
  • 5 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241128. rdar://problem/46664625

[macOS] API test times out after r241026
​https://bugs.webkit.org/show_bug.cgi?id=194372

Reviewed by Alex Christensen.

The API test TestWebKitAPI.RenderingProgress.FirstMeaningfulPaint times out after r241026.
A new function pointer, layoutMilestones, is added to WKBundlePageLoaderClient, in order
for clients to decide which milestones they would like to listen for.

  • WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: (layoutMilestones): (setUpPageLoaderClient):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::layoutMilestones const):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241370] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241124. rdar://problem/47466549

Shrink and hyphenate safe browsing warning text on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=194361
<rdar://problem/47466549>

Reviewed by Geoffrey Garen.

Some internationalizations use long words that didn't fit on small watches.

  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm: (fontOfSize): (-[WKSafeBrowsingWarning addContent]): (-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241369] by bshafiei@apple.com
  • 6 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241121. rdar://problem/42023295

Infinite recursion via CachedResource::~CachedResource
​https://bugs.webkit.org/show_bug.cgi?id=194378
<rdar://problem/42023295>

Reviewed by Daniel Bates.

I don't know the exact steps to trigger this but the mechanism seems clear.

1) An existing resource is removed from or replaced in CachedResourceLoader::m_documentResources map.
2) This decrements the handle count of resource and causes it be deleted.
3) CachedResource::~CachedResource calls m_owningCachedResourceLoader->removeCachedResource(*this). This only happens with

resources that are "owned" by CachedResourceLoader which is a rare special case (used by image document and if memory cache is disabled).

4) CachedResourceLoader::removeCachedResource looks up the resource from the map which causes a temporary CachedResourceHandle to be created.

This increments the handle count of the resource from 0 back to 1.

5) When the temporary dies, CachedResource::~CachedResource is called again and we cycle back to 3).

The fix here is simply to remove CachedResourceLoader::removeCachedResource call from ~CachedResource.
It is a leftover from when the map contained raw pointers instead of owning CachedResourceHandles.

Since m_documentResources map has a handle to the resource, the only way we are in the destructor is that the resource
has been removed from the map already (or is in process of being removed like in this crash). Any call that does anything
other than bail out is going to crash.

CachedResource::n_owningCachedResourceLoader member and CachedResourceLoader::removeCachedResource function only exist to
support this erranous call so they are removed as well.

  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):

This is the substantive change. The rest just removes now-dead code.

  • loader/cache/CachedResource.h: (WebCore::CachedResource::setOwningCachedResourceLoader): Deleted.
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::loadResource): (WebCore::CachedResourceLoader::garbageCollectDocumentResources): (WebCore::CachedResourceLoader::removeCachedResource): Deleted.
  • loader/cache/CachedResourceLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:03 AM Changeset in webkit [241368] by bshafiei@apple.com
  • 29 edits
    3 copies in branches/safari-608.1.5.1-branch

Cherry-pick r241105. rdar://problem/46733045

[Payment Request] It should be possible to require a phonetic name for shipping contacts
​https://bugs.webkit.org/show_bug.cgi?id=194311
<rdar://46733045>

Reviewed by Alex Christensen.

Source/WebCore:

It should be possible to require that a shipping contact has a phonetic name in Payment Request.
To accomplish this, move requiredShippingContactFields from ApplePayPaymentRequest to
ApplePayRequestBase so that it can be used as part of an Apple Pay payment method data.

Since required shipping contact fields can now be specified both in
requiredShippingContactFields and PaymentOptions, we merge the required fields from these
two sources such that, e.g., email is required if it is specified in either place.

So that clients can detect this new feature, the API version number is bumped from 5 to 6.

Added test cases to ApplePayRequestShippingContact.https.html and ApplePayRequestShippingContactV3.https.html.

  • DerivedSources.make:
  • Modules/applepay/ApplePayPaymentRequest.h:
  • Modules/applepay/ApplePayPaymentRequest.idl:
  • Modules/applepay/ApplePayRequestBase.cpp: (WebCore::convertAndValidate):
  • Modules/applepay/ApplePayRequestBase.h:
  • Modules/applepay/ApplePayRequestBase.idl:
  • Modules/applepay/ApplePaySession.cpp: (WebCore::convertAndValidate):
  • Modules/applepay/PaymentCoordinatorClient.cpp: Added. (WebCore::PaymentCoordinatorClient::supportsVersion):
  • Modules/applepay/PaymentCoordinatorClient.h:
  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: (WebCore::mergePaymentOptions): (WebCore::ApplePayPaymentHandler::show):
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.cpp:
  • testing/MockPaymentContactFields.h: Added. (WebCore::MockPaymentContactFields::MockPaymentContactFields):
  • testing/MockPaymentContactFields.idl: Added.
  • testing/MockPaymentCoordinator.cpp: (WebCore::MockPaymentCoordinator::showPaymentUI): (WebCore::MockPaymentCoordinator::supportsVersion): Deleted.
  • testing/MockPaymentCoordinator.h:
  • testing/MockPaymentCoordinator.idl:

Source/WebKit:

  • WebProcess/ApplePay/WebPaymentCoordinator.cpp: (WebKit::WebPaymentCoordinator::supportsVersion): Deleted.
  • WebProcess/ApplePay/WebPaymentCoordinator.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPaymentCoordinatorClient.h:
  • WebCoreSupport/WebPaymentCoordinatorClient.mm: (WebPaymentCoordinatorClient::supportsVersion): Deleted.

LayoutTests:

  • http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt:
  • http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:
  • http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https-expected.txt:
  • http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html:
  • http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
  • http/tests/ssl/applepay/PaymentRequest.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241367] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241026. rdar://problem/46664625

Roll out parts of r238819 since it is a PLT performance regression.
​https://bugs.webkit.org/show_bug.cgi?id=194346

Unreviewed performance fix.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: (didStartProvisionalLoadForFrame): (didReceiveServerRedirectForProvisionalLoadForFrame): (didFinishLoadForFrame): (globalObjectIsAvailableForFrame): (didRemoveFrameFromHierarchy): (didCommitLoadForFrame): (didFinishDocumentLoadForFrame): (didFailProvisionalLoadWithErrorForFrame): (didFailLoadWithErrorForFrame): (didSameDocumentNavigationForFrame): (didLayoutForFrame): (didReachLayoutMilestone): (didFirstVisuallyNonEmptyLayoutForFrame): (didHandleOnloadEventsForFrame): (userAgentForURL): (setUpPageLoaderClient): (willSendRequestForFrame): (didInitiateLoadForResource): (didFinishLoadForResource): (didFailLoadForResource): (setUpResourceLoadClient): (-[WKWebProcessPlugInBrowserContextController setLoadDelegate:]): (ResourceLoadClient::ResourceLoadClient): Deleted. (ResourceLoadClient::loadDelegate const): Deleted. (ResourceLoadClient::pluginContextController const): Deleted. (PageLoaderClient::PageLoaderClient): Deleted. (PageLoaderClient::loadDelegate const): Deleted. (PageLoaderClient::pluginContextController const): Deleted. (PageLoaderClient::didStartProvisionalLoadForFrame): Deleted. (PageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted. (PageLoaderClient::didFinishLoadForFrame): Deleted. (PageLoaderClient::globalObjectIsAvailableForFrame): Deleted. (PageLoaderClient::didRemoveFrameFromHierarchy): Deleted. (PageLoaderClient::didCommitLoadForFrame): Deleted. (PageLoaderClient::didFinishDocumentLoadForFrame): Deleted. (PageLoaderClient::didFailProvisionalLoadWithErrorForFrame): Deleted. (PageLoaderClient::didFailLoadWithErrorForFrame): Deleted. (PageLoaderClient::didSameDocumentNavigationForFrame): Deleted. (PageLoaderClient::didLayoutForFrame): Deleted. (PageLoaderClient::didReachLayoutMilestone): Deleted. (PageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame): Deleted. (PageLoaderClient::layoutMilestones const): Deleted. (PageLoaderClient::didHandleOnloadEventsForFrame): Deleted. (PageLoaderClient::userAgentForURL const): Deleted. (ResourceLoadClient::willSendRequestForFrame): Deleted. (ResourceLoadClient::didInitiateLoadForResource): Deleted. (ResourceLoadClient::didFinishLoadForResource): Deleted. (ResourceLoadClient::didFailLoadForResource): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241366] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241022. rdar://problem/47833940

CoreAudioCaptureSource should not configure its audio unit until it starts producing data
​https://bugs.webkit.org/show_bug.cgi?id=194310

Reviewed by Eric Carlson.

Delay the configuration of the audio unit until the source is instructed to start producing data.
This allows the UIProcess to not start changing the audio unit when
checking for constraints during getUserMedia call before the prompt.
Covered by manual testing.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource): (WebCore::CoreAudioCaptureSource::initializeToStartProducingData): (WebCore::CoreAudioCaptureSource::startProducingData):
  • platform/mediastream/mac/CoreAudioCaptureSource.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241365] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r241021. rdar://problem/45354090

Disable audio ducking at Audio Unit setup time
​https://bugs.webkit.org/show_bug.cgi?id=194303

Reviewed by Eric Carlson.

When creating a CoreAudioCaptureSource, the audio unit might be
reconfigured if a past audio capture was done.
This might trigger audio ducking which is undone in startInternal.
In some cases, startInternal will never call start.
In that case, the audio unit will continue ducking the other processing.
To ensure ducking is disabled, unduck in setupAudioUnit as well as startInternal.

In addition to that, once a shared unit is created, it stays alive until the UIProcess exits.
This might affect all applications.
Instead, whenever the shared unit is stopped, clean it so as to restore the state as if no capture ever happened.
This has noticeable effects in the quality of audio being played on bluetooth devices.

Covered by manual tests.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioSharedUnit::setupAudioUnit): (WebCore::CoreAudioSharedUnit::unduck): (WebCore::CoreAudioSharedUnit::startInternal): (WebCore::CoreAudioSharedUnit::captureFailed): (WebCore::CoreAudioSharedUnit::stopProducingData):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241364] by bshafiei@apple.com
  • 3 edits
    3 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241018. rdar://problem/47822929

RELEASE_ASSERT(!m_document.isResolvingTreeStyle()) in com.apple.WebKit.WebContent at WebCore: WebCore::StyleResolver::~StyleResolver
​https://bugs.webkit.org/show_bug.cgi?id=194333
<rdar://problem/47822929>

Reviewed by Zalan Bujtas.

Source/WebCore:

Content extensions may mutate the extension stylesheet in the middle of a style resolution as a result of
the legacy animation code triggering a resource load.

Test: http/tests/contentextensions/css-display-none-keyframe.html

  • style/StyleScope.cpp: (WebCore::Style::Scope::scheduleUpdate):

Avoid clearing the style resolver if we are in the middle of a style resolution.
A better fix that avoid doing this in the first place is tracked by ​https://bugs.webkit.org/show_bug.cgi?id=194335.

LayoutTests:

  • http/tests/contentextensions/css-display-none-keyframe-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-keyframe.html: Added.
  • http/tests/contentextensions/css-display-none-keyframe.html.json: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241363] by bshafiei@apple.com
  • 6 edits in branches/safari-608.1.5.1-branch

Cherry-pick r241011. rdar://problem/47827420

Web Inspector: Styles: PropertiesChanged shouldn't fire when old and new text are both empty
​https://bugs.webkit.org/show_bug.cgi?id=194318

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Previously, WI.CSSStyleDeclaration.Event.PropertiesChanged fired when
old text and new text were empty strings.

  • UserInterface/Models/CSSStyleDeclaration.js:

LayoutTests:

Fix the flaky test on Debug.

  • inspector/css/modify-css-property-race-expected.txt:
  • inspector/css/modify-css-property-race.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241362] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r241003. rdar://problem/47829275

Web Inspector: Elements tab: selection is broken after deleting the selected node
​https://bugs.webkit.org/show_bug.cgi?id=194300
<rdar://problem/47829275>

Reviewed by Devin Rousso.

Deleting a TreeElement can cause an IndexSet including indexes
outside the deleted range to be passed to SelectionController,
corrupting the internal selection state.

  • UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype._indexesForSubtree.numberOfElementsInSubtree): Added. (WI.TreeOutline.prototype._indexesForSubtree): Finding the last (rightmost leaf) TreeElement in the subtree used TreeElement.prototype.traverseNextElement to do a depth first traversal. This method did not stay within the subtree rooted at treeElement.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241361] by bshafiei@apple.com
  • 4 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r240998. rdar://problem/47832956

Fix DFG's doesGC() for a few more nodes.
​https://bugs.webkit.org/show_bug.cgi?id=194307
<rdar://problem/47832956>

Reviewed by Yusuke Suzuki.

Fix doesGC() for the following nodes:

NumberToStringWithValidRadixConstant:

Calls operationInt32ToStringWithValidRadix(), which calls int32ToString(),
which can allocate a string.
Calls operationInt52ToStringWithValidRadix(), which calls int52ToString(),
which can allocate a string.
Calls operationDoubleToStringWithValidRadix(), which calls numberToString(),
which can allocate a string.

RegExpExecNonGlobalOrSticky: calls createRegExpMatchesArray() which allocates

memory for all kinds of objects.

RegExpMatchFast: calls operationRegExpMatchFastString(), which calls

RegExpObject::execInline() and RegExpObject::matchGlobal(). Both of
these allocates memory for the match result.

RegExpMatchFastGlobal: calls operationRegExpMatchFastGlobalString(), which

calls RegExpObject's collectMatches(), which allocates an array amongst
other objects.

StringFromCharCode:

If the uint32 code to convert is greater than maxSingleCharacterString,
we'll call operationStringFromCharCode(), which calls jsSingleCharacterString(),
which allocates a new string if the code is greater than maxSingleCharacterString.

Also fix SpeculativeJIT::compileFromCharCode() and FTL's compileStringFromCharCode()
to use maxSingleCharacterString instead of a literal constant.

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileFromCharCode):
  • ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241360] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240997. rdar://problem/47805023

Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
​https://bugs.webkit.org/show_bug.cgi?id=194254
<rdar://problem/47805023>

Reviewed by Devin Rousso.

  • UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype.selectionControllerSelectionDidChange): TreeOutline should always call the TreeElement select and deselect methods while processing selection changes. Having notifications suppressed by this._suppressNextSelectionDidChangeEvent should only affect the dispatching of TreeOutline events.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241359] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r240995. rdar://problem/47719379

Reproducible crash under WKShareSheet presentWithParameters when cancelling a share
​https://bugs.webkit.org/show_bug.cgi?id=194301
<rdar://problem/47719379>

Reviewed by Beth Dakin.

  • UIProcess/Cocoa/WKShareSheet.mm: (-[WKShareSheet presentWithParameters:completionHandler:]): NSSharingServicePicker's delegate callbacks can be called synchronously. We release the WKShareSheet (which holds our reference to the NSSharingServicePicker) under sharingServicePicker:didChooseSharingService:. On older versions of macOS, there was nothing keeping the NSSharingServicePicker alive inside showRelativeToRect:ofView:preferredEdge:, thus the whole chain of references would fall and result in sending a message to a released NSSharingServicePicker. To resolve this, keep an extra reference to the WKShareSheet until presentation is complete.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241358] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/JavaScriptCore

Cherry-pick r240991. rdar://problem/47827589

Move DFG nodes that clobberize() says will write(Heap) to the doesGC() list that returns true.
​https://bugs.webkit.org/show_bug.cgi?id=194298
<rdar://problem/47827555>

Reviewed by Saam Barati.

We do this for 3 reasons:

  1. It's clearer when reading doesGC()'s code that these nodes will return true.
  2. If things change in the future where clobberize() no longer reports these nodes as write(Heap), each node should be vetted first to make sure that it can never GC before being moved back to the doesGC() list that returns false.
  3. This reduces the list of nodes that we need to audit to make sure doesGC() is correct in its claims about the nodes' GCing possibility.

The list of nodes moved are:

ArrayPush
ArrayPop
Call
CallEval
CallForwardVarargs
CallVarargs
Construct
ConstructForwardVarargs
ConstructVarargs
DefineDataProperty
DefineAccessorProperty
DeleteById
DeleteByVal
DirectCall
DirectConstruct
DirectTailCallInlinedCaller
GetById
GetByIdDirect
GetByIdDirectFlush
GetByIdFlush
GetByIdWithThis
GetByValWithThis
GetDirectPname
GetDynamicVar
HasGenericProperty
HasOwnProperty
HasStructureProperty
InById
InByVal
InstanceOf
InstanceOfCustom
LoadVarargs
NumberToStringWithRadix
PutById
PutByIdDirect
PutByIdFlush
PutByIdWithThis
PutByOffset
PutByValWithThis
PutDynamicVar
PutGetterById
PutGetterByVal
PutGetterSetterById
PutSetterById
PutSetterByVal
PutStack
PutToArguments
RegExpExec
RegExpTest
ResolveScope
ResolveScopeForHoistingFuncDeclInEval
TailCall
TailCallForwardVarargsInlinedCaller
TailCallInlinedCaller
TailCallVarargsInlinedCaller
ToNumber
ToPrimitive
ValueNegate

  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241357] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/LayoutTests

Cherry-pick r240989. rdar://problem/47827420

Web Inspector: Fix modify-css-property-race.html test failures
​https://bugs.webkit.org/show_bug.cgi?id=194282

Reviewed by Matt Baker.

Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
so it doesn't log the actual values.

  • inspector/css/modify-css-property-race-expected.txt:
  • inspector/css/modify-css-property-race.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241356] by bshafiei@apple.com
  • 16 edits in branches/safari-608.1.5.1-branch

Cherry-pick r240983. rdar://problem/47756320

Unreviewed, rolling out r240742.

Causes crashes on iOS simulator.

Reverted changeset:

"[iOS] Keyups for non-modifier keys identified as "Dead" when
not focused in a content-editable element"
​https://bugs.webkit.org/show_bug.cgi?id=192824
​https://trac.webkit.org/changeset/240742

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241355] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240952. rdar://problem/47559021

Web Inspector: Resources: missing resource data for document on reload
​https://bugs.webkit.org/show_bug.cgi?id=194243
<rdar://problem/47559021>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js: (WI.ResourceDetailsSidebarPanel.prototype.set resource): (WI.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
  • UserInterface/Base/Object.js: (WI.Object.removeEventListener): Drive-by: there's no need to iterate over the entire table to check if thisObject exists, as that is handled for us by ListMultimap, which we later call anyways.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241354] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebInspectorUI

Cherry-pick r240947. rdar://problem/47743864

Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
​https://bugs.webkit.org/show_bug.cgi?id=194169
<rdar://problem/47743864>

Reviewed by Devin Rousso.

  • UserInterface/Views/TreeOutline.js: (WI.TreeOutline.prototype._handleMouseDown): Add a special case for a single-selection TreeOutline with allowsRepeatSelection enabled. Since the element is already selected, bypass the SelectionCongroller and dispatch an event with event.data.selectedByUser set to true.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:02 AM Changeset in webkit [241353] by bshafiei@apple.com
  • 8 edits
    2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r240946. rdar://problem/47827420

Web Inspector: Styles: fix race conditions when editing
​https://bugs.webkit.org/show_bug.cgi?id=192739
<rdar://problem/46752925>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Editing CSS property in the style editor syncronously updates CSSStyleDeclaration on the front-end
and asyncronously updates the backend by calling CSSAgent.setStyleText. After the new style text is applied
on the backend, CSSStyleDeclaration (on the front-end) gets updated.

Unsure there's no race conditions by introducing _updatesInProgressCount:

  • Increment it before calling CSSAgent.setStyleText.
  • Decrement it after CSSAgent.setStyleText is finished.

Prevent updates of CSSStyleDeclaration when _updatesInProgressCount isn't 0.

  • UserInterface/Models/CSSProperty.js: (WI.CSSProperty.prototype._updateOwnerStyleText):
  • UserInterface/Models/CSSStyleDeclaration.js: (WI.CSSStyleDeclaration): (WI.CSSStyleDeclaration.prototype.set text): Removed. (WI.CSSStyleDeclaration.prototype.setText): Added. Change the setter to a method since it has side effects including an asynchronous backend call.
  • UserInterface/Models/DOMNodeStyles.js: (WI.DOMNodeStyles.prototype.changeStyleText):
  • UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.get nameTextField): Removed. (WI.SpreadsheetStyleProperty.prototype.get valueTextField): Removed. Drive-by: remove unused code.

LayoutTests:

  • inspector/css/modify-css-property-expected.txt:
  • inspector/css/modify-css-property-race-expected.txt: Added.
  • inspector/css/modify-css-property-race.html: Added.
  • inspector/css/modify-css-property.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 AM Changeset in webkit [241352] by rniwa@webkit.org
  • 4 edits in trunk/Source

Release assert in PolicyCheckIdentifier::isValidFor via WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction
​https://bugs.webkit.org/show_bug.cgi?id=194582

Reviewed by Antti Koivisto.

Source/WebCore:

Check the zero-ness of m_policyCheck first so that we can differentiate process ID being wrong
from the non-generated identifier being sent to us as it was the case in this failure.

  • loader/PolicyChecker.cpp:

(WebCore::PolicyCheckIdentifier::isValidFor):

Source/WebKit:

The bug was caused by WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction invoking the callback
with responseIdentifier even when we had failed to send the policy check IPC. Clearly, responseIdentifier
is invalid in that case, and we should be using requestIdentifier instead.

Unfortunately no new tests since I'm not aware of a way to make sendSync fail in this case.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

12:41 AM Changeset in webkit [241351] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebKit

Responsiveness timers are too expensive for frequent events
​https://bugs.webkit.org/show_bug.cgi?id=194003

Reviewed by Geoffrey Garen.

With each event, we set a responsivness timer to check if the WebProcess
is responsive, and reset the timer when the WebProcess sends an answer.

For frequent events (e.g. wheel events, mouse force events, etc),
we are spamming the kernel with hundreds of timers per second.
That is a bit inefficient.

Another source of inefficiency comes from the timer implementation
itself. Stopping a RunLoop::Timer removes the timer from every mode
and invalidate the timer. It becomes costly since we do it a lot.

With this patch, I tweak ResponsivenessTimer and its use to minimize
how often we schedule system timers.

The first change is to not stop the timer when we get the stop()
calls if we expect more events to come in. Instead, we keep track
if we care about the timeout or not in the attribute "m_waitingForTimer".
When the next event starts, we can reschedule the timer without ever
having told the kernel about the stop.
If there are no next events, the timeout fires but m_waitingForTimer
is false. To avoid idle wake up, the lazy stop is only used when having
following events is common.

The second improvements comes from not even rescheduling the timer
when restarted. Instead of changing the timer, we let the original timer
fire and re-shedule a new one with the missing time.

For more context, also see patches r240759 and r240944.

  • UIProcess/ResponsivenessTimer.cpp:

(WebKit::ResponsivenessTimer::ResponsivenessTimer):
(WebKit::ResponsivenessTimer::invalidate):
(WebKit::ResponsivenessTimer::timerFired):
(WebKit::ResponsivenessTimer::start):
(WebKit::ResponsivenessTimer::startWithLazyStop):
(WebKit::ResponsivenessTimer::stop):
(WebKit::ResponsivenessTimer::processTerminated):
(WebKit::ResponsivenessTimer::~ResponsivenessTimer): Deleted.

  • UIProcess/ResponsivenessTimer.h:

(WebKit::ResponsivenessTimer::hasActiveTimer const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::isResponsiveWithLazyStop):

  • UIProcess/WebProcessProxy.h:
12:26 AM Changeset in webkit [241350] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r241273.
​https://bugs.webkit.org/show_bug.cgi?id=194579

This change is causing a flaky assertion failure crash in High
Sierra Debug (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Stop using setDefersLoading from WebCore"
​https://bugs.webkit.org/show_bug.cgi?id=194315
​https://trac.webkit.org/changeset/241273

Feb 12, 2019:

11:36 PM Changeset in webkit [241349] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Null deref in userInterfaceLayoutDirection under ViewGestureController::handleSwipeGesture
​https://bugs.webkit.org/show_bug.cgi?id=194569
<rdar://problem/46711049>

Reviewed by Wenson Hsieh.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::handleSwipeGesture):
It is conceivable that we could get here if the client closes the page
e.g. in the callback from willEndSwipeGesture. We already guarded against
this ... one line too late! Rearrange the lines so we don't call into
WebPageProxy at all if we don't have a drawing area (which is a strict subset
of the time that isValid would return true). This is a speculative fix,
since I can no longer reproduce the crash on demand.

11:13 PM Changeset in webkit [241348] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unnecessary null check in bindings.
​https://bugs.webkit.org/show_bug.cgi?id=194581

Reviewed by Yusuke Suzuki.

It is always safe to call visitor.containsOpaqueRoot(root) with a null root pointer.
It will just return false. Since we don't expect the root pointer to be null in
the common case, having a null check here is also not optimal. We'll remove this
unneeded null check.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

10:43 PM Changeset in webkit [241347] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r240738. rdar://problem/47686640

Ensure ENABLE_MEDIA_SOURCE is defined inside DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=194063

Reviewed by Jon Lee.

  • DerivedSources.make:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:36 PM Changeset in webkit [241346] by bshafiei@apple.com
  • 7 edits
    1 add in branches/safari-608.1.5.1-branch

Cherry-pick r241306. rdar://problem/47789393

WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
​https://bugs.webkit.org/show_bug.cgi?id=194522
<rdar://problem/47789393>

Reviewed by Chris Dumez.

Source/WebKit:

The InjectedBundle SPI can retain the WebPage or wrapping objects (WKWebProcessPlugInBrowserContextController/WKBundlePageRef).
This can make it so WebPage::close is called before WebPage::~WebPage, and if the SuspendedPageProxy is reused for a subsequent
navigation to the same domain, the WebProcess is reused with a different WebPage instance with the same PageID, which causes problems
when another WebPage registers message handlers and then the previous WebPage is destroyed, which removes both message handlers.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::~WebPage): (WebKit::WebPage::close): (WebKit::WebPage::mainFrameDidLayout):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h: (WebKit::WebProcess::eventDispatcher):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added. (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:36 PM Changeset in webkit [241345] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r241112. rdar://problem/47764549

AX: com.apple.WebKit.WebContent at WebKit: -[WKAccessibilityWebPageObjectBase axObjectCache]
​https://bugs.webkit.org/show_bug.cgi?id=194306
<rdar://problem/47764549>

Reviewed by Zalan Bujtas.

Check the page reference is still valid.
Modernize code in this area.

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:36 PM Changeset in webkit [241344] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/LayoutTests

Cherry-pick r241031. rdar://problem/47830193

Revert part of r241015 that skipped all WebGL tests

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:35 PM Changeset in webkit [241343] by bshafiei@apple.com
  • 4 edits
    2 adds in branches/safari-608.1.5.1-branch

Cherry-pick r241015. rdar://problem/47830193

REGRESSION (r240909): Release assert in FrameLoader::loadURL when navigating with a non-existent target name
​https://bugs.webkit.org/show_bug.cgi?id=194329

Reviewed by Geoffrey Garen.

Source/WebCore:

The bug was caused by the code path for when navigating with a specific target frame name that does not exist
never setting the load type of PolicyChecker. As a result, we would use whatever load type used in the previous
navigation, resulting in this release assertion.

Updating the load type here should in theory fix the underlying bug r240909 was meant to catch & fix.

Test: fast/loader/navigate-with-new-target-after-back-forward-navigation.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL):

LayoutTests:

Added a regression test.

  • fast/loader/navigate-with-new-target-after-back-forward-navigation-expected.txt: Added.
  • fast/loader/navigate-with-new-target-after-back-forward-navigation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@241015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:35 PM Changeset in webkit [241342] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r240974. rdar://problem/47581081

Protect globalWebSocketStreamMap with a Lock
​https://bugs.webkit.org/show_bug.cgi?id=194224
<rdar://problem/47581081>

Reviewed by Ryosuke Niwa.

  • WebProcess/Network/WebSocketStream.cpp: (WebKit::WebSocketStream::streamWithIdentifier): (WebKit::WebSocketStream::networkProcessCrashed): (WebKit::WebSocketStream::WebSocketStream): (WebKit::WebSocketStream::~WebSocketStream):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:35 PM Changeset in webkit [241341] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.5.1-branch/Source/WebCore

Cherry-pick r240971. rdar://problem/47774298

REGRESSION (r240579): com.apple.WebKit.WebContent at WebCore: WebCore::Document::absoluteEventRegionForNode
​https://bugs.webkit.org/show_bug.cgi?id=194284
<rdar://problem/47774298>

Patch by Antoine Quint <Antoine Quint> on 2019-02-05
Reviewed by Antti Koivisto.

The m_touchActionElements list needs to be HashSet<RefPtr<Element>> instead of HashSet<Element*>. It was initially storing raw pointers based on m_touchEventTargets
which is an EventTargetSet (typedef’d to HashCountedSet<Node*>), but that's because these nodes have an event listener registered for them and as such are kept alive,
whereas elements with a touch-action property aren’t. Elements are removed from this list from Document::nodeWillBeRemoved() and from Document::updateTouchActionElements(),
the latter being called from Style::TreeResolver::resolveElement().

  • dom/Document.cpp: (WebCore::Document::updateTouchActionElements):
  • dom/Document.h: (WebCore::Document::touchActionElements const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@240971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:34 PM Changeset in webkit [241340] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSScript needs to retain its cache path NSURL*
​https://bugs.webkit.org/show_bug.cgi?id=194577

Reviewed by Tim Horton.

  • API/JSScript.mm:

(+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]):
(-[JSScript dealloc]):

10:01 PM Changeset in webkit [241339] by bshafiei@apple.com
  • 7 edits in branches/safari-608.1.5.1-branch/Source

Versioning.

9:24 PM Changeset in webkit [241338] by youenn@apple.com
  • 4 edits in trunk/Source/WebKit

WebServiceWorkerProvider::handleFetch no longer needs a CachedResource parameter
​https://bugs.webkit.org/show_bug.cgi?id=194548

Reviewed by Alex Christensen.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::handleFetch):

  • WebProcess/Storage/WebServiceWorkerProvider.h:
9:04 PM Changeset in webkit [241337] by timothy_horton@apple.com
  • 7 edits
    3 deletes in trunk/Source

Remove WKLegacyPDFView
​https://bugs.webkit.org/show_bug.cgi?id=194559

Reviewed by Andy Estes.

Source/WebKit:

  • Platform/spi/ios/CorePDFSPI.h: Removed.
  • SourcesCocoa.txt:
  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry initWithConfiguration:]):

  • UIProcess/ios/WKLegacyPDFView.h: Removed.
  • UIProcess/ios/WKLegacyPDFView.mm: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Source/WTF:

  • wtf/FeatureDefines.h:
6:32 PM Changeset in webkit [241336] by Chris Dumez
  • 6 edits in trunk

Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
​https://bugs.webkit.org/show_bug.cgi?id=194568
<rdar://problem/47944490>

Reviewed by Ryosuke Niwa.

Source/WebKit:

When the provisional process crashes, it is unsafe to call ProvisionalPageProxy::cancel() because
the WebProcessProxy clears its frame map as soon as the process crashes. Calling cancel() after
that would call WebPageProxy::didFailProvisionalLoadForFrameShared(), which would try to look up
the frame by ID and MESSAGE_CHECK() that the frame is not null. We would fail this check since
the frame has been removed from the WebProcessProxy at this point.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _provisionalWebProcessIdentifier]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::provisionalProcessDidTerminate):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):

6:30 PM Changeset in webkit [241335] by rmorisset@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make B3Value::returnsBool() more precise
​https://bugs.webkit.org/show_bug.cgi?id=194457

Reviewed by Saam Barati.

It is currently used repeatedly in B3ReduceStrength, as well as once in B3LowerToAir.
It has a needlessly complex rule for BitAnd, and has no rule for other easy cases such as BitOr or Select.
No new tests added as this should be indirectly tested by the already existing tests.

  • b3/B3Value.cpp:

(JSC::B3::Value::returnsBool const):

5:34 PM Changeset in webkit [241334] by Alan Coon
  • 1 copy in tags/Safari-607.1.35

Tag Safari-607.1.35.

5:33 PM Changeset in webkit [241333] by commit-queue@webkit.org
  • 5 edits in trunk

Align with Fetch on data: URLs
​https://bugs.webkit.org/show_bug.cgi?id=182325

Patch by Rob Buis <​rbuis@igalia.com> on 2019-02-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectations.

  • web-platform-tests/fetch/data-urls/processing.any-expected.txt:
  • web-platform-tests/fetch/data-urls/processing.any.worker-expected.txt:

Source/WebCore:

The MIME type part of the data url should be serialized as
specified in step 3 under "data" [1].

Test: web-platform-tests/fetch/data-urls/processing.any.js

[1] ​https://fetch.spec.whatwg.org/#concept-scheme-fetch

  • platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::parseMediaType):

5:32 PM Changeset in webkit [241332] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Youtube fails to play.
​https://bugs.webkit.org/show_bug.cgi?id=194565
<rdar://problem/47974770>

Reviewed by Geoffrey Garen.

This is caused by sandbox violations and was introduced in r240500.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
5:05 PM Changeset in webkit [241331] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r241320
​https://bugs.webkit.org/show_bug.cgi?id=194271

  • page/Frame.cpp:

(WebCore::Frame::requestDOMPasteAccess):

5:01 PM Changeset in webkit [241330] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Remove firing assertion after r241317
​https://bugs.webkit.org/show_bug.cgi?id=194506

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::setDefersLoading):
The creation of a PageGroupLoadDeferrer in Chrome.cpp tries to defer loading.
See comments in Chrome::runJavaScriptAlert et al.
This was necessary with WebKitLegacy, so keep it, but it doesn't need to do anything in modern WebKit.

4:45 PM Changeset in webkit [241329] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Remove bug_dummy from parsed test expectations
​https://bugs.webkit.org/show_bug.cgi?id=194562
<rdar://problem/47853999>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
skipped tests.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4:23 PM Changeset in webkit [241328] by Justin Fan
  • 18 edits
    3 moves
    1 delete in trunk

[WebGPU] Remove WebGPUBufferDescriptor/Usage and use GPU versions
​https://bugs.webkit.org/show_bug.cgi?id=194552

Reviewed by Dean Jackson.

WebGPUBufferDescriptor/Usage have been renamed to GPUBufferDescriptor/Usage in the Web GPU API.
Source/WebCore:

Consolidate the two versions of these classes in our implementation.

Affected layout tests updated with new names. No change in behavior.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webgpu/GPUBufferDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUBufferDescriptor.idl.
  • Modules/webgpu/GPUBufferUsage.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUBufferUsage.idl.
  • Modules/webgpu/WebGPUBufferUsage.h: Removed.
  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createBuffer const):

  • Modules/webgpu/WebGPUDevice.h:
  • Modules/webgpu/WebGPUDevice.idl:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • platform/graphics/gpu/GPUBufferDescriptor.h: Moved out GPUBufferUsage.
  • platform/graphics/gpu/GPUBufferUsage.h: Moved from GPUBufferDescriptor.h.

LayoutTests:

Update affected tests to match.

  • webgpu/bind-groups.html:
  • webgpu/buffer-resource-triangles.html:
  • webgpu/buffers.html:
  • webgpu/depth-enabled-triangle-strip.html:
  • webgpu/vertex-buffer-triangle-strip.html:
4:19 PM Changeset in webkit [241327] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Unreviewed, try to fix the internal iOS build after r241321

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
4:02 PM Changeset in webkit [241326] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Add method to fetch patch
​https://bugs.webkit.org/show_bug.cgi?id=194518

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/models/patch.py:

(Patch.get_patch):

4:00 PM Changeset in webkit [241325] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: Experimental setting for CPU Usage Timeline improvements
​https://bugs.webkit.org/show_bug.cgi?id=194556

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Matt Baker.

  • UserInterface/Main.html:
  • UserInterface/Views/LegacyCPUTimelineView.css: Added.
  • UserInterface/Views/LegacyCPUTimelineView.js: Added.

Copy of CPUTimelineView.js/css to be used when the setting is not set.

  • UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
ContentView to create based on the setting.

  • UserInterface/Base/Setting.js:
  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Experimental switch.

3:59 PM Changeset in webkit [241324] by Alan Bujtas
  • 2 edits in trunk/Tools

[LFC] Expand tests coverage (60 new tests -> 860)

Unreviewed test gardening (run-singly, --child-processes=1).

  • LayoutReloaded/misc/LFC-passing-tests.txt:
3:33 PM Changeset in webkit [241323] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

Find on Page shouldn't zoom in on matches
​https://bugs.webkit.org/show_bug.cgi?id=194557
<rdar://problem/42087017>

Reviewed by Wenson Hsieh.

  • UIProcess/ios/SmartMagnificationController.h:
  • UIProcess/ios/SmartMagnificationController.messages.in:
  • UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::scrollToRect):

  • WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator):
Only scroll to reveal the find result, do not zoom in.

3:18 PM Changeset in webkit [241322] by Wenson Hsieh
  • 24 edits
    11 adds in trunk

Allow pages to trigger programmatic paste from script on iOS
​https://bugs.webkit.org/show_bug.cgi?id=194271
<rdar://problem/47808810>

Reviewed by Tim Horton.

Source/WebCore:

Tests: editing/pasteboard/ios/dom-paste-confirmation.html

editing/pasteboard/ios/dom-paste-consecutive-confirmations.html
editing/pasteboard/ios/dom-paste-rejection.html
editing/pasteboard/ios/dom-paste-requires-user-gesture.html

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicator::~UserGestureIndicator):

Reset a gesture token's DOM paste access when exiting the scope of a user gesture. This prevents DOM paste
access permissions from leaking into setTimeout() callbacks when we forward user gesture tokens.

  • dom/UserGestureIndicator.h:

(WebCore::UserGestureToken::resetDOMPasteAccess):

Source/WebKit:

Cancel the pending DOM paste access handler when the menu is about to hide, rather than when the hiding
animation has completed. This ensures that if the page (on behalf of the user) requests DOM paste again during
user interaction before the callout bar has finished fading after the previous DOM paste, we won't automatically
cancel the incoming DOM paste access request because the callout bar animation finished.

This scenario is exercised in the layout test editing/pasteboard/ios/dom-paste-consecutive-confirmations.html.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _willHideMenu:]):
(-[WKContentView _didHideMenu:]):

Tools:

Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::platformSetDidShowMenuCallback):
(WTR::UIScriptController::platformSetDidHideMenuCallback):
(WTR::UIScriptController::rectForMenuAction const):

Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
for when the menu is shown or hidden.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptContext.h:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidShowMenuCallback):
(WTR::UIScriptController::didShowMenuCallback const):
(WTR::UIScriptController::setDidHideMenuCallback):
(WTR::UIScriptController::didHideMenuCallback const):
(WTR::UIScriptController::platformSetDidShowMenuCallback):
(WTR::UIScriptController::platformSetDidHideMenuCallback):
(WTR::UIScriptController::rectForMenuAction const):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::calendarType const):
(WTR::UIScriptController::platformUndoManager const):

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didShowMenu]):
(-[TestRunnerWKWebView _didHideMenu]):

Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::handleMenuWillHideNotification):
(WTR::handleMenuDidHideNotification):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
(WTR::TestController::platformResetStateToConsistentValues):

Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::forEachViewInHierarchy):
(WTR::findViewInHierarchyOfType):

Move forEachViewInHierarchy so that we can use it throughout the file, and then add some additional helper
functions that dig through a given view's hierarchy in search of a view of a given class.

(WTR::UIScriptController::selectionStartGrabberViewRect const):
(WTR::UIScriptController::selectionEndGrabberViewRect const):
(WTR::UIScriptController::selectionCaretViewRect const):
(WTR::UIScriptController::selectionRangeViewRects const):
(WTR::UIScriptController::platformSetDidShowMenuCallback):
(WTR::UIScriptController::platformSetDidHideMenuCallback):

Tweak these to use platformContentView instead of grabbing the content view from WKWebView directly.

(WTR::UIScriptController::rectForMenuAction const):

Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
callout bar) whose label matches the given string.

(WTR::UIScriptController::platformContentView const):

Add a platformContentView() helper on UIScriptController so that we can stop grabbing the value for key
"_currentContentView" from various places in this file. Additionally, rewrite platformUndoManager() in terms
of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.

(WTR::UIScriptController::platformUndoManager const): Deleted.

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::platformContentView const):
(WTR::UIScriptController::platformUndoManager const): Deleted.

LayoutTests:

Add new tests to exercise programmatic pasting.

  • TestExpectations:
  • editing/pasteboard/ios/dom-paste-confirmation-expected.txt: Added.
  • editing/pasteboard/ios/dom-paste-confirmation.html: Added.

Verify that the user can tap "Paste" to allow programmatic pasting.

  • editing/pasteboard/ios/dom-paste-consecutive-confirmations-expected.txt: Added.
  • editing/pasteboard/ios/dom-paste-consecutive-confirmations.html: Added.

Verify that DOM paste access isn't carried over when using setTimeout in a user gesture event handler.

  • editing/pasteboard/ios/dom-paste-rejection-expected.txt: Added.
  • editing/pasteboard/ios/dom-paste-rejection.html: Added.

Verify that resigning first responder dismisses the callout bar and does not allow programmatic pasting.

  • editing/pasteboard/ios/dom-paste-requires-user-gesture-expected.txt: Added.
  • editing/pasteboard/ios/dom-paste-requires-user-gesture.html: Added.

Verify that user gesture is required to present the callout menu for a programmatic paste request.

  • editing/pasteboard/ios/resources/dom-paste-helper.js: Added.

(return.new.Promise.):
(async._waitForOrTriggerPasteMenu):
(async.triggerPasteMenuAfterTapAt):
(async.waitForPasteMenu):

Add helpers to summon, wait for, and interact with the callout bar when the page attempts to trigger a paste.

  • platform/ios-wk2/TestExpectations:
  • platform/win/TestExpectations:

Skip editing/pasteboard/ios by default, and enable it only in the modern WebKit port of iOS.

2:55 PM Changeset in webkit [241321] by Chris Fleizach
  • 67 edits
    1 copy
    1 add in trunk/Source

AX: IsolatedTree: Implement more attributes
​https://bugs.webkit.org/show_bug.cgi?id=193911
<rdar://problem/47599217>

Reviewed by Daniel Bates.

Source/WebCore:

Make use of new HIServices SPI to use a secondary AX thread.
Store root node/focused node status in IsolatedTree rather than on the element.
Implement the following attributes: children, parent, isIgnored, isTree, isTreeItem, relativeFrame, speechHint, title, description.
Implement hit-testing using relative-frames.
Ensure that WKAccessibilityWebPageObject queries happen on main thread when they need to.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::generateIsolatedAccessibilityTree):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::focusedUIElementForPage):

  • accessibility/AccessibilityAttachment.cpp:

(WebCore::AccessibilityAttachment::accessibilityText const):
(WebCore::AccessibilityAttachment::accessibilityText): Deleted.

  • accessibility/AccessibilityAttachment.h:
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityText const):
(WebCore::AccessibilityImageMapLink::accessibilityText): Deleted.

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::accessibilityText const):
(WebCore::AccessibilityMediaControl::accessibilityText): Deleted.

  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityText const):
(WebCore::AccessibilityNodeObject::accessibilityText): Deleted.

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::convertFrameToSpace const):
(WebCore::AccessibilityObject::relativeFrame const):
(WebCore::AccessibilityObject::elementAccessibilityHitTest const):
(WebCore::AccessibilityObject::focusedUIElement const):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::accessibilityText const):
(WebCore::AccessibilityObject::isLink const): Deleted.
(WebCore::AccessibilityObject::isImage const): Deleted.
(WebCore::AccessibilityObject::isAttachment const): Deleted.
(WebCore::AccessibilityObject::isFileUploadButton const): Deleted.
(WebCore::AccessibilityObject::isImageMapLink const): Deleted.
(WebCore::AccessibilityObject::isMediaControlLabel const): Deleted.
(WebCore::AccessibilityObject::isTree const): Deleted.
(WebCore::AccessibilityObject::isTreeItem const): Deleted.
(WebCore::AccessibilityObject::isScrollbar const): Deleted.
(WebCore::AccessibilityObject::accessibilityHitTest const): Deleted.
(WebCore::AccessibilityObject::accessibilityText): Deleted.
(WebCore::AccessibilityObject::roleValue const): Deleted.
(WebCore::AccessibilityObject::wrapper const): Deleted.

  • accessibility/AccessibilityObjectInterface.h: Replaced.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isTabItemSelected const):
(WebCore::AccessibilityRenderObject::remoteSVGElementHitTest const):
(WebCore::AccessibilityRenderObject::elementAccessibilityHitTest const):
(WebCore::AccessibilityRenderObject::accessibilityHitTest const):
(WebCore::AccessibilityRenderObject::selectedChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::accessibilityText const):
(WebCore::AccessibilitySVGElement::accessibilityText): Deleted.

  • accessibility/AccessibilitySVGElement.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest const):

  • accessibility/AccessibilityScrollView.h:
  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::fileUploadButtonReturnsValueInTitle const):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]): Deleted.

  • accessibility/isolatedtree: Replaced.
  • accessibility/isolatedtree/AXIsolatedTree.cpp: Added.

(WebCore::AXIsolatedTree::treePageCache):
(WebCore::AXIsolatedTree::AXIsolatedTree):
(WebCore::AXIsolatedTree::nodeInTreeForID):
(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::focusedUIElement):
(WebCore::AXIsolatedTree::setRootNodeID):
(WebCore::AXIsolatedTree::setFocusedNodeID):
(WebCore::AXIsolatedTree::setInitialRequestInProgress):
(WebCore::AXIsolatedTree::applyPendingChanges):

  • accessibility/isolatedtree/AXIsolatedTree.h: Added.
  • accessibility/isolatedtree/AXIsolatedTreeNode.cpp: Added.

(WebCore::AXIsolatedTreeNode::AXIsolatedTreeNode):
(WebCore::AXIsolatedTreeNode::~AXIsolatedTreeNode):
(WebCore::AXIsolatedTreeNode::initializeAttributeData):
(WebCore::AXIsolatedTreeNode::setProperty):
(WebCore::AXIsolatedTreeNode::setParent):
(WebCore::AXIsolatedTreeNode::setTreeIdentifier):
(WebCore::AXIsolatedTreeNode::focusedUIElement const):
(WebCore::AXIsolatedTreeNode::parentObjectInterfaceUnignored const):
(WebCore::AXIsolatedTreeNode::accessibilityHitTest const):
(WebCore::AXIsolatedTreeNode::tree const):
(WebCore::AXIsolatedTreeNode::rectAttributeValue const):
(WebCore::AXIsolatedTreeNode::stringAttributeValue const):

  • accessibility/isolatedtree/AXIsolatedTreeNode.h: Added.
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::associateIsolatedTreeNode):

  • accessibility/mac/AccessibilityObjectBase.mm: Added.

(WebCore::AccessibilityObject::speechHintAttributeValue const):
(WebCore::AccessibilityObject::descriptionAttributeValue const):
(WebCore::AccessibilityObject::titleAttributeValue const):
(WebCore::AccessibilityObject::helpTextAttributeValue const):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::fileUploadButtonReturnsValueInTitle const):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(addChildToArray):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperBase isolatedTreeNode]):
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):
(-[WebAccessibilityObjectWrapperBase accessibilityObject]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase axBackingObject]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
(convertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertRectToSpace:space:]):
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
(-[WebAccessibilityObjectWrapperBase titleTagShouldBeUsedInDescriptionField]): Deleted.
(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]):
(-[WebAccessibilityObjectWrapper childrenVectorSize]):
(-[WebAccessibilityObjectWrapper childrenVectorArray]):
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

Source/WebCore/PAL:

  • pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

  • Platform/spi/mac/AccessibilityPrivSPI.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

(-[WKAccessibilityWebPageObjectBase clientSupportsIsolatedTree]):
(-[WKAccessibilityWebPageObjectBase isolatedTreeRootObject]):
(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject IGNORE_WARNINGS_END]):
(-[WKAccessibilityWebPageObject convertScreenPointToRootView:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeSizeValue]):
(-[WKAccessibilityWebPageObject accessibilityAttributePositionValue]):
(-[WKAccessibilityWebPageObject accessibilityDataDetectorValue:point:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

2:37 PM Changeset in webkit [241320] by Wenson Hsieh
  • 36 edits
    1 add in trunk/Source

Allow pages to trigger programmatic paste from script on iOS
​https://bugs.webkit.org/show_bug.cgi?id=194271
<rdar://problem/47808810>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for allowing script to trigger programmatic paste commands. Currently on macOS and iOS, the ability
to trigger programmatic paste (i.e. document.execCommand('Paste');) is disabled by default, such that
execCommand is simply a no-op that returns false. This policy is a privacy measure (common among other major
browsers) that prevents untrusted web content from sniffing content from the system pasteboard (even on user
interaction, since unintended user interaction occasionally happens as well!).

In order to make it possible for web pages to programmatically paste without opening the door to privacy and
security issues, we make paste commands triggered from bindings present platform UI on iOS, in the form of a
callout bar with the single option to paste. This UI is dismissed upon any user interaction; furthermore, any
user interaction short of explicitly triggering the "Paste" action subsequently prevents the page from executing
the paste (and causes execCommand to return false). However, if the paste action is chosen by the user, we
instead follow through with the programmatic paste command.

New tests to come in a followup patch.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMPasteAccessPolicy.h: Added.
  • dom/UserGestureIndicator.h:

(WebCore::UserGestureToken::domPasteAccessPolicy const):
(WebCore::UserGestureToken::didRequestDOMPasteAccess):

Add helpers on UserGestureToken to update and query the current DOM paste access policy. The access policies are
"NotRequestedYet" (i.e. pending a response from the user), "Granted" (the user has granted DOM paste access to
the page), or "Denied" (the user has prevented the page from reading the contents of the clipboard). When DOM
paste access is granted or rejected, make this decision sticky until the end of the current user gesture.

  • editing/EditorCommand.cpp:

(WebCore::executePaste):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executePasteAsQuotation):

When executing a paste command where the source is DOM bindings, request DOM paste if needed before proceeding
with the paste.

(WebCore::supportedPaste):

  • loader/EmptyClients.cpp:
  • page/EditorClient.h:
  • page/Frame.cpp:

(WebCore::Frame::requestDOMPasteAccess):

Add a helper method that requests access to the clipboard on behalf of script when pasting.

  • page/Frame.h:
  • page/Settings.yaml:

Introduce a new WebCore setting, used to gate DOM paste access requests.

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:

Add an internal setting to enable or disable DOM paste access requests. This is on by default in iOS only
(excluding watchOS and Apple TV), and is additionally disabled on macOS.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestDOMPasteAccess):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestDOMPasteAccess):

Plumb DOM paste access requests from the web process (WebEditorClient) to the view (WKContentView). As per the
usual, this involves WebEditorClient, WebPage, WebPageProxy, PageClient and finally WKContentView.

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestDOMPasteAccess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestDOMPasteAccess):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView resignFirstResponderForWebView]):
(-[WKContentView _webTouchEventsRecognized:]):

Bail from any pending DOM paste access handler the moment we start handling touches on the web view, or if the
web view resigns first responder, or if the web process crashes.

(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

Reject text selection gestures while waiting for DOM paste access.

(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView canPerformActionForWebView:withSender:]):

If we're handling a DOM paste, always return YES to allow the callout bar to show the "Paste" option.

(-[WKContentView _didHideMenu:]):

If the menu is programmatically hidden by the app while handling a DOM paste request, immediately reject the DOM
paste request.

(-[WKContentView pasteForWebView:]):

Adjust -pasteForWebView: on WKContentView to first check whether there's an outstanding DOM paste completion
handler to invoke, instead of telling the page to execute a paste command.

(-[WKContentView _handleDOMPasteRequestWithResult:]):

Add a helper to take and invoke the current DOM paste completion handler (if it exists) with the given result,
and then dismiss the shared callout bar. Returns whether or not the paste completion handler exists. Invoked
from various sources of user interaction or significant state changes (e.g. following a web process crash in
-cleanupInteraction).

(-[WKContentView _willPerformAction:sender:]):
(-[WKContentView _didPerformAction:sender:]):

Add hooks to detect when WKContentView is executing an editing action. This is to ensure that the page doesn't
get stuck in a bad state in the case where WKWebView has been subclassed, overrides -paste:, and does not
invoke the superclass method (which calls back into -[WKContentView pasteForWebView:]). There are a few
possibilities here:

  1. WKWebView's -paste: action is not overridden. In this case, we will call back into -pasteForWebView:, which will notice that we have a pending paste completion handler and invoke it.
  2. WKWebView's -paste: action is overridden and does not call back into the content view. In this case, we will invoke the paste completion handler in -_didPerformAction:sender:.
  3. WKWebView's -canPerformAction:withSender: is overridden to include additional actions. In this case, we may get a call to invoke a different action selector while waiting for a potential paste action. If this happens, prevent the DOM paste in -_willPerformAction:sender: prior to handling the other action.

(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):

Dismiss DOM paste UI upon handling any key event.

(-[WKContentView showGlobalMenuControllerInRect:]):
(-[WKContentView hideGlobalMenuController]):

Helper methods to present and dismiss the global UIMenuController, that accounts for available platform APIs for
presenting or dismissing the menu controller on iOS.

(-[WKContentView _requestDOMPasteAccessWithElementRect:completionHandler:]):

Attempt to find a good target presentation rect when showing the callout menu. First, we will try to use the
rect of the element the user has interacted with when triggering the paste. If such an element is too large or
does not exist, we fall back to presenting the callout menu near the user's last touch location (with a small
amount of margin, such that the action doesn't overlap with the user's finger, stylus, etc.).

(-[WKContentView _resetShowingTextStyle:]): Deleted.

Rename this to -_didHideMenu:.

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/win/PageClientImpl.cpp:

(WebKit::PageClientImpl::requestDOMPasteAccess):

  • UIProcess/win/PageClientImpl.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestDOMPasteAccess):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestDOMPasteAccess):

Add more plumbing and method stubs.

(WebKit::WebPage::updateCurrentModifierState):
(WebKit::WebPage::rectForElementAtInteractionLocation const):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rectForElementAtInteractionLocation const):
(WebKit::WebPage::rectForElementAtInteractionLocation): Deleted.

Mark this method as const, add a platform-agnostic stub, and adopt it for the purposes of determining where to
position the callout bar when pasting.

Source/WebKitLegacy/mac:

See WebCore and WebKit ChangeLogs for more details.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebEditorClient.h:
1:57 PM Changeset in webkit [241319] by dino@apple.com
  • 3 edits
    2 adds in trunk

Source/WebCore:
Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-02-12
Reviewed by Brady Eidson.

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

LayoutTests:
BitmapRenderer should handle existing ImageBuffers
​https://bugs.webkit.org/show_bug.cgi?id=194555
<rdar://problem/47857150>

Reviewed by Tim Horton.

Test that creates a canvas, triggers an ImageBuffer to be created, then
creates the bitmaprenderer context.

  • fast/canvas/bitmaprenderer-created-after-toBlob-expected.txt: Added.
  • fast/canvas/bitmaprenderer-created-after-toBlob.html: Added.
1:53 PM Changeset in webkit [241318] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: No option to only show unexpected failures in results.html for iPad
​https://bugs.webkit.org/show_bug.cgi?id=194554
<rdar://problem/47922442>

Rubber-stamped by Aakash Jain.

Just because a TestExpecations file does not exist for a specific platform does not mean that
TestExpecations are not being used, given that platforms inherit test expectations.

  • Scripts/webkitpy/port/base.py:

(Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_uses_test_expectations_file):

1:49 PM Changeset in webkit [241317] by achristensen@apple.com
  • 28 edits in trunk

Remove setDefersLoading infrastructure from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=194506

Reviewed by Brady Eidson.

Source/WebCore:

setDefersLoading is inherently racy from WebCore to the NetworkProcess,
it adds unwanted complexity to the initialization and use of network objects,
and it has led to many unrecoverable hang bugs over the years.
We needed to force it into WebKit2 to transition some existing clients who relied on it,
but we have recently finished transitioning those clients to other solutions, mostly
completion handlers.

  • inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::setDefersLoading): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::suspend): Deleted.

  • NetworkProcess/NetworkDataTaskBlob.h:
  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::initialize):
(WebKit::NetworkLoad::setDefersLoading): Deleted.

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkLoadParameters.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::setDefersLoading): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::suspend): Deleted.

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::suspend): Deleted.

  • NetworkProcess/curl/NetworkDataTaskCurl.h:
  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::suspend): Deleted.

  • NetworkProcess/soup/NetworkDataTaskSoup.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::setDefersLoading):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDefersLoading): Deleted.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

  • platform/wk2/TestExpectations:
1:35 PM Changeset in webkit [241316] by Michael Catanzaro
  • 6 edits in trunk/Source

Unreviewed, fix build warnings after content extensions enablement
​https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

Source/WebCore:

  • contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

  • contentextensions/DFABytecodeCompiler.h:
  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::statusString):

Source/WebKit:

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(toResult):

1:21 PM Changeset in webkit [241315] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have
​https://bugs.webkit.org/show_bug.cgi?id=194549

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

  • UserInterface/Models/Timeline.js:

(WI.Timeline.prototype.recordsInTimeRange):

1:17 PM Changeset in webkit [241314] by Michael Catanzaro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix -Wimplicit-fallthrough warning after r241140
​https://bugs.webkit.org/show_bug.cgi?id=194399
<rdar://problem/47889777>

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

1:13 PM Changeset in webkit [241313] by Alan Coon
  • 7 edits
    1 add in branches/safari-607-branch

Apply patch. rdar://problem/48009995

12:44 PM Changeset in webkit [241312] by Alan Coon
  • 7 edits in branches/safari-607-branch/Source

Versioning.

12:30 PM Changeset in webkit [241311] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

Switching focus from a UITextField to an editable WKWebView causes the keyboard to dance
​https://bugs.webkit.org/show_bug.cgi?id=194524
<rdar://problem/35481797>

Reviewed by Wenson Hsieh.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/InputViewUpdateDeferrer.h:
  • UIProcess/ios/InputViewUpdateDeferrer.mm:

(WebKit::InputViewUpdateDeferrer::InputViewUpdateDeferrer):
(WebKit::InputViewUpdateDeferrer::~InputViewUpdateDeferrer):
Make use of the per-responder and much safer input view pinning mechanism.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView becomeFirstResponderForWebView]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:modifierFlags:]):
Always temporarily pin input views when becoming first responder; there are
many paths (such as through the text interaction assistant) that can
focus us on tap, trying to cover them all is a fool's errand. We'll
just get out the big hammer and call it in becomeFirstResponder.
This also means we can remove it from _singleTapCommitted and _attemptClick...

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
Don't release the input view pinning until we return from _elementDidFocus;
it does the rebuilding synchronously, so we need to have actually updated
all of the prerequisites of -inputView before depinning.

12:11 PM Changeset in webkit [241310] by Justin Fan
  • 24 edits
    1 copy
    4 moves
    3 adds
    1 delete in trunk

[Web GPU] DepthStencilAttachment implementation
​https://bugs.webkit.org/show_bug.cgi?id=194458
<rdar://problem/47932446>

Reviewed by Dean Jackson.

Source/WebCore:

Implement ability to provide a depth attachment to the render pass encoder. Also implement
GPULoad/StoreOp and update color attachments' implementation for full functionality.

Test: webgpu/depth-enabled-triangle-strip.html

Update project files for new symbols:

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/webgpu/GPUColor.idl: Renamed from WebGPUColor.idl
  • Modules/webgpu/GPULoadOp.idl: Added. Interface for attachment operation enum.
  • Modules/webgpu/GPUStoreOp.idl: Ditto.
  • Modules/webpug/WebGPUColor.h: Removed.
  • Modules/webgpu/WebGPUCommandBuffer.cpp: Refactored descriptor validation logic out of this file.

(WebCore::WebGPUCommandBuffer::beginRenderPass):

  • Modules/webgpu/WebGPURenderPassDescriptor.cpp: Added. Now owns code for validating descriptors.

(WebCore::WebGPURenderPassDescriptor::validateAndConvertToGPUVersion const):

  • Modules/webgpu/WebGPURenderPassColorAttachmentDescriptor.h/idl: Removed. Code moved into WebGPURenderPassDescriptor.
  • Modules/webgpu/WebGPURenderPassDescriptor.h: Move sub-descriptor definitions into this file.
  • Modules/webgpu/WebGPURenderPassDescriptor.idl: Ditto.
  • Modules/webgpu/WebGPURenderPipelineDescriptor.h: Make depthStencilState optional to match API update.
  • Modules/webgpu/WebGPURenderPipelineDescriptor.idl: Ditto.
  • Modules/webgpu/WebGPUTextureView.h:
  • platform/graphics/gpu/GPULoadOp.h: Added.
  • platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.h: Removed (moved into GPURenderPassDescriptor).
  • platform/graphics/gpu/GPURenderPassDescriptor.h: Mirror WebGPU* changes.
  • platform/graphics/gpu/GPURenderPipelineDescriptor.h: Make depthStencilState optional.

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):

  • platform/graphics/gpu/GPUStoreOp.h: Added.
  • platform/graphics/gpu/GPUTexture.h:
  • platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:

(WebCore::loadActionForGPULoadOp): Added.
(WebCore::storeActionForGPUStoreOp): Added.
(WebCore::populateMtlColorAttachmentsArray): Added. Create all expected color attachments, rather than just the first.
(WebCore::populateMtlDepthStencilAttachment): Added.
(WebCore::GPURenderPassEncoder::create):

  • platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm: Make depthStencilState optional.

(WebCore::GPURenderPipeline::create):

LayoutTests:

Add test and update utility functions for depth texture attachments. Update others to specify their
loadOp and storeOp for all render pass attachments, as these are no longer provided by default by the implementation.

  • webgpu/buffer-resource-triangles.html:
  • webgpu/depth-enabled-triangle-strip-expected.html: Added.
  • webgpu/depth-enabled-triangle-strip.html: Added.
  • webgpu/js/basic-webgpu-functions.js:

(render):

  • webgpu/js/webgpu-functions.js:

(createBasicDepthStateDescriptor):
(createBasicDepthTexture):
(beginBasicRenderPass):
(createBasicPipeline): Deleted.

  • webgpu/render-command-encoding.html:
  • webgpu/render-passes.html:
11:58 AM Changeset in webkit [241309] by ddkilzer@apple.com
  • 7 edits in trunk/Source

REGRESSION (r238955, r240494): Soft-linking optional Lookup.framework triggers release assertion when missing
<​https://webkit.org/b/194529>
<rdar://problem/47924449>

Reviewed by Eric Carlson.

Source/WebCore:

  • SourcesCocoa.txt:
  • Do not include DataDetectorsCoreSoftLink.mm in unified sources.
  • WebCore.xcodeproj/project.pbxproj:
  • Add DataDetectorsCoreSoftLink.mm to the WebCore target now that it isn't part of the unifed sources.
  • platform/cocoa/DataDetectorsCoreSoftLink.mm:
  • Switch from using SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL() to SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE() when linking DataDetectorsCore.framework. None of the other macros assume this framework is optional, and it was likely made optional originally because the framework was new to iOS and thus didn't exist on older versions.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • Change use of SOFT_LINK_CLASS_FOR_SOURCE() macros to SOFT_LINK_CLASS() since the latter can only be used with SOFT_LINK_FRAMEWORK_OPTIONAL(AVFoundation). This broke after the fix for <wtf/SoftLinking.h> was applied.

Source/WTF:

  • wtf/cocoa/SoftLinking.h:

(SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL): Rename
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_ASSERTION() to this
and change assertion argument to isOptional. Pass
isOptional to framework##Library() method to control assertion
behavior. Only check RELEASE_ASSERT() if !isOptional, else
that code should be optimized out by the compiler. This fixes
the crash.
(NO_ASSERT): Remove macro since it's no longer used.
(SOFT_LINK_IS_OPTIONAL): Add macro to use for soft-linking
optional classes.
(SOFT_LINK_IS_NOT_OPTIONAL): Add macro to use for soft-linking
non-optional classes.
(SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT): Update to use new
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL() macro.
(SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT): Ditto.
(SOFT_LINK_CLASS_FOR_SOURCE): Ditto.
(SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL): Ditto.

11:53 AM Changeset in webkit [241308] by youenn@apple.com
  • 5 edits in trunk/Source

Make use of is<SubresourceLoader>
​https://bugs.webkit.org/show_bug.cgi?id=194541

Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveResponse):

  • loader/SubresourceLoader.h:

(isType):

Source/WebKit:

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

11:51 AM Changeset in webkit [241307] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

AX: Fix flaky accessibility/loading-iframe-sends-notification.html
​https://bugs.webkit.org/show_bug.cgi?id=194546

Reviewed by Zalan Bujtas.

This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.

  • accessibility/loading-iframe-sends-notification-expected.txt:
  • accessibility/loading-iframe-sends-notification.html:
11:29 AM Changeset in webkit [241306] by achristensen@apple.com
  • 7 edits
    1 add in trunk

WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
​https://bugs.webkit.org/show_bug.cgi?id=194522
<rdar://problem/47789393>

Reviewed by Chris Dumez.

Source/WebKit:

The InjectedBundle SPI can retain the WebPage or wrapping objects (WKWebProcessPlugInBrowserContextController/WKBundlePageRef).
This can make it so WebPage::close is called before WebPage::~WebPage, and if the SuspendedPageProxy is reused for a subsequent
navigation to the same domain, the WebProcess is reused with a different WebPage instance with the same PageID, which causes problems
when another WebPage registers message handlers and then the previous WebPage is destroyed, which removes both message handlers.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::mainFrameDidLayout):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

(WebKit::WebProcess::eventDispatcher):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.

(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
11:20 AM Changeset in webkit [241305] by commit-queue@webkit.org
  • 5 edits in trunk/Source/bmalloc

Unreviewed, rolling out r241182.
​https://bugs.webkit.org/show_bug.cgi?id=194547

causes a 2-3% Speedometer2 regression. (Requested by
keith_miller on #webkit).

Reverted changeset:

"bmalloc uses more memory on iOS compared to macOS due to
physical page size differences"
​https://bugs.webkit.org/show_bug.cgi?id=192389
​https://trac.webkit.org/changeset/241182

10:45 AM Changeset in webkit [241304] by Michael Catanzaro
  • 6 edits in trunk/Source

[WPE][GTK] Unsafe g_unsetenv() use in WebProcessPool::platformInitialize
​https://bugs.webkit.org/show_bug.cgi?id=194370

Reviewed by Darin Adler.

Source/JavaScriptCore:

Change a couple WTFLogAlways to use g_warning, for good measure. Of course this isn't
necessary, but it will make errors more visible.

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::start):
(Inspector::dbusConnectionCallAsyncReadyCallback):

  • inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::start):

Source/WebKit:

It is incorrect to use g_unsetenv() here because it is MT-Unsafe. We know that it is
impossible and unreasonable to expect the application has not started other threads at this
point, and threads will be calling getenv(). WebKit itself has probably already started
threads of its own.

Fortunately, the remote inspector in the web process is already prepared to deal with
failure to connect to the inspector server, so we don't need to do anything except stop
messing with the environment.

Note these files are copies of each other. I'll merge them together in a follow-up patch.

  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

10:23 AM Changeset in webkit [241303] by Beth Dakin
  • 3 edits in trunk/Source/WebKit

Ensure old binaries have old snapshotting behaviors
​https://bugs.webkit.org/show_bug.cgi?id=194449
-and corresponding-
rdar://problem/47931954

Reviewed by Darin Adler.

Make sure that a nil configuration behaves the same way that it used to on apps
that were linked before FirstWithSnapshotAfterScreenUpdates

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

  • UIProcess/Cocoa/VersionChecks.h:
10:22 AM Changeset in webkit [241302] by Devin Rousso
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar
​https://bugs.webkit.org/show_bug.cgi?id=194365
<rdar://problem/47868426>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineRecordBar.js:

(WI.TimelineRecordBar.prototype._handleClick):
Mark the "click" event so that later listeners know it was handled by WI.TimelineRecordBar.

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview):
(WI.TimelineOverview.prototype._instrumentAdded):
(WI.TimelineOverview.prototype._instrumentRemoved):
(WI.TimelineOverview.prototype._handleGraphsContainerClick): Added.
(WI.TimelineOverview.prototype._handleOverviewGraphRecordSelected): Added.
(WI.TimelineOverview.prototype._recordSelected):
Listen for "click" on the graph container and deselect all records when fired, unless the
click was marked by a WI.TimelineRecordBar.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype._recordSelected):
Ensure that all WI.TimelineView update their selected record whenever it changes for any
other WI.TimelineView (or if there is no selected record).

  • UserInterface/Views/TimelineOverviewGraph.js:

(WI.TimelineOverviewGraph.prototype.didLayoutSubtree): Added.
Drive-by: since WI.TimelineRecordBar are reused when combining, we need to re-determine
which one holds the currently selected record.

10:21 AM Changeset in webkit [241301] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused maxUsage in CPUTimelineView
​https://bugs.webkit.org/show_bug.cgi?id=194526

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-12
Reviewed by Devin Rousso.

  • UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView):
(WI.CPUTimelineView.prototype.shown):

10:21 AM Changeset in webkit [241300] by mark.lam@apple.com
  • 4 edits in trunk/Source/WebCore

Add some null checks in JSNodeCustom.h's root() and generated isReachableFromOpaqueRoots() functions.
​https://bugs.webkit.org/show_bug.cgi?id=194530
<rdar://problem/47973274>

Reviewed by Chris Dumez.

This is needed to fix a null pointer dereference that arises from the following scenario:

  1. a Document detaches from its StyleSheetList.
  2. the JSStyleSheetList that is associated with the detached StyleSheetList has yet to be scanned and collected by the GC.
  3. the GC eventually looks for the opaque root of the StyleSheetList's owner, and discovers a null owner pointer.

This patch fixes this issue by applying the following null checks:

  1. Add a null check in JSNodeCustom.h's root().

root() is called from a isReachableFromOpaqueRoots() generated by CodeGeneratorJS.pm.
isReachableFromOpaqueRoots() calls a ownerNode() method and passes its result
to root(). However, depending on which class the ownerNode() method belongs to,
it can either return a pointer or a reference. The null check only makes sense
in the pointer case.

To accommodate the 2 forms, root() itself is has an overload that takes a
reference instead of a pointer.

Since CodeGeneratorJS.pm can't tell what the generated class' ownerNode()
returns, it can't discern when the result is a pointer and apply the null check.
Instead, we just add the null check to the version of root() that takes a
pointer. If the node pointer is null, we'll return a null opaque root.

  1. Fix CodeGeneratorJS.pm to null check the opaque root before using it.
  • bindings/js/JSNodeCustom.h:

(WebCore::root):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):

9:43 AM Changeset in webkit [241299] by aestes@apple.com
  • 17 edits in trunk

[iOSMac] Enable Parental Controls Content Filtering
​https://bugs.webkit.org/show_bug.cgi?id=194521
<rdar://39732376>

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • platform/ContentFilterUnblockHandler.h:
  • platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
  • platform/cocoa/ParentalControlsContentFilter.mm:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:38 AM Changeset in webkit [241298] by Adrian Perez de Castro
  • 2 edits in trunk/LayoutTests

Unreviewed WPE gardening. Unskip content extensions tests after r241283

  • platform/wpe/TestExpectations: Unskip content extensions tests, and list

as failing those known to not pass due to missing expectaions or timeouts.

8:53 AM Changeset in webkit [241297] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Source/WebCore:
Unreviewed build fix; add a HAVE_CELESTIAL guard around Celestial framework usage.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary):

Source/WebCore/PAL:
Unreviewed build fix; add a HAVE_CELESTIAL guard around the CelestialSPI.h contents.

  • pal/spi/ios/CelestialSPI.h:
8:22 AM Changeset in webkit [241296] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::ScrollingTree::updateTreeFromStateNode
​https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>

Reviewed by Zalan Bujtas.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.

7:59 AM Changeset in webkit [241295] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC] Remove redundant InlineFormattingContext::computeBorderAndPadding
​https://bugs.webkit.org/show_bug.cgi?id=194540

Reviewed by Antti Koivisto.

Use FormattingContext::computeBorderAndPadding instead.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeBorderAndPadding const):

  • layout/FormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
7:42 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro
(diff)
7:34 AM Changeset in webkit [241294] by Alan Bujtas
  • 5 edits in trunk

[LFC][IFC] Add intrinsic width support for float boxes.
​https://bugs.webkit.org/show_bug.cgi?id=194528

Reviewed by Antti Koivisto.

Source/WebCore:

This patch implements a very simple float box support for intrinsic width.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFloatBox const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForInlineBlock const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:

Tools:

Expand tests coverage (2 new tests -> 800).
(This is the correct test ordering --runs-singly --child-processes=1)

  • LayoutReloaded/misc/LFC-passing-tests.txt:
3:40 AM Changeset in webkit [241293] by Carlos Garcia Campos
  • 17 edits in releases/WebKitGTK/webkit-2.24

Revert r240363 - Deprecate API to limit the maximum number of WebProcesses

This reverts commit r240363.

3:19 AM WebKitGTK/2.24.x created by Carlos Garcia Campos
2:47 AM Changeset in webkit [241292] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.24

Branch WebKitGTK for 2.24

2:04 AM Changeset in webkit [241291] by commit-queue@webkit.org
  • 5 edits in trunk

Implement serializing in MIME type parser
​https://bugs.webkit.org/show_bug.cgi?id=193909

Patch by Rob Buis <​rbuis@igalia.com> on 2019-02-12
Reviewed by Darin Adler.

Source/WebCore:

Implement serializing in MIME type parser [1], to preserve the parameter
order the Vector m_parameterNames is introduced, since HashMaps do not
guarantee any order.

Test: ParsedContentType.Serialize

[1] ​https://mimesniff.spec.whatwg.org/#serializing-a-mime-type

  • platform/network/ParsedContentType.cpp:

(WebCore::skipSpaces):
(WebCore::parseQuotedString):
(WebCore::ParsedContentType::parseContentType):
(WebCore::ParsedContentType::parameterValueForName const):
(WebCore::ParsedContentType::parameterCount const):
(WebCore::ParsedContentType::setContentType):
(WebCore::ParsedContentType::setContentTypeParameter):
(WebCore::ParsedContentType::serialize const):

  • platform/network/ParsedContentType.h:

Tools:

Add various tests involving upper case, non-ASCII, control/null characters,
various HTTP whitespace, single quotes and an unpaired surrogate.

  • TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:

(TestWebKitAPI::escapeNonASCIIPrintableCharacters):
(TestWebKitAPI::serializeIfValid):
(TestWebKitAPI::TEST):

1:29 AM Changeset in webkit [241290] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/PAL

[WPE][GTK] Sleep disabler code should inhibit idle when a "System" sleep disabler is requested
​https://bugs.webkit.org/show_bug.cgi?id=194500

Reviewed by Carlos Garcia Campos.

There are three things wrong with the comment at the top of SleepDisablerGLib's constructor:

(1) Nowadays, GNOME suspends the computer automatically on inactivity, and we actually do

want to prevent that.

(2) Inhibiting idle does affect the autosuspend countdown. So the current code should

prevent automatic suspend, just not manual suspend. (I think I stand by my comment that
we do not want to inhibit normal suspend, since that would just be annoying.)

(3) I don't know why I thought HTMLMediaElement::shouldDisableSleep was suspicious.

Anyway, the behavior we want is to ignore the Type argument and just always inhibit idle.
That is, treat type=System the same way we current treat type=Display.

  • pal/system/glib/SleepDisablerGLib.cpp:

(PAL::SleepDisablerGLib::SleepDisablerGLib):

1:28 AM Changeset in webkit [241289] by Chris Fleizach
  • 11 edits in trunk

AXObjectCache::childrenChanged shouldn't update layout or style during another style recalc
​https://bugs.webkit.org/show_bug.cgi?id=182280
<rdar://problem/37018386>

Reviewed by Alan Bujtas.

Source/WebCore:

Remove the possibility that changing children calls back into updating layout by
handling children changes in a deferred manner.

This follows the same architecture as many other deferred changes, but also requires us to check deferred changes
in updateBackingStore, because things like aria-hidden changes won't trigger a layout, but will require us to update children.

A few tests had to be modified to no longer change the tree and then check the children immediately.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertToNSArray):
(-[WebAccessibilityObjectWrapperBase updateObjectBackingStore]):

LayoutTests:

  • accessibility/aria-hidden-update.html:
  • accessibility/aria-hidden-updates-alldescendants.html:
  • accessibility/image-load-on-delay.html:
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html:
  • accessibility/removed-anonymous-block-child-causes-crash.html:

Feb 11, 2019:

6:19 PM Changeset in webkit [241288] by mmaxfield@apple.com
  • 25 edits
    2 adds
    2 deletes in trunk

[Cocoa] Ask platform for generic font family mappings
​https://bugs.webkit.org/show_bug.cgi?id=187723
<rdar://problem/41892438>

Reviewed by Brent Fulgham.

Source/WebCore:

WebKit API allows setting the generic font families for the USCRIPT_COMMON script.
When trying to style a character with a generic font family, we first look to see if
we have a mapping for the particular script the character is rendered with, and if we
don't find a match, we then check USCRIPT_COMMON.

In the Cocoa ports, the only way families get set for non-USCRIPT_COMMON scripts (aka
the only scripts which won't use the API families) is in
SettingsBase::initializeDefaultFontFamilies(). That function only sets the families
for the CJK scripts.

The mappings inside SettingsBase are incorrect and conflict with our policy regarding
user-installed fonts. Instead, we should be consulting with the platform for some of
these mappings, by calling CTFontDescriptorCreateForCSSFamily(). However, the WebKit
API still has to work to set the mappings for untagged content. Therefore, we use the
system mappings for language-tagged content, and the API mappings for non-language-tagged
content. This is a good balance that makes sure we always have a good mapping for every
language, but API clients can still set the mappings, too.

Test: fast/text/ja-sans-serif.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSFontSelector.cpp:

(WebCore::resolveGenericFamily):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFamily):

  • page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::initializeDefaultFontFamilies):
(WebCore::osakaMonoIsInstalled): Deleted.

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::platformResolveGenericFamily):

  • platform/graphics/FontDescription.h:
  • platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::computeSpecializedChineseLocale):
(WebCore::cachedSpecializedChineseLocale):
(WebCore::languageChanged):
(WebCore::FontDescription::platformResolveGenericFamily):

  • platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::clear):
(WebCore::genericFamily):
(WebCore::SystemFontDatabaseCoreText::serifFamily):
(WebCore::SystemFontDatabaseCoreText::sansSerifFamily):
(WebCore::SystemFontDatabaseCoreText::cursiveFamily):
(WebCore::SystemFontDatabaseCoreText::fantasyFamily):
(WebCore::SystemFontDatabaseCoreText::monospaceFamily):

  • platform/graphics/cocoa/SystemFontDatabaseCoreText.h:

Source/WebCore/PAL:

  • pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

Add an ENABLE in Platform.

  • wtf/Platform.h:

Tools:

Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet):

LayoutTests:

Update the tests to work with this new model.

  • fast/text/international/font-fallback-to-common-script-expected.html: Removed.
  • fast/text/international/font-fallback-to-common-script.html: Removed.
  • fast/text/international/lang-sensitive-fonts-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml-expected.html:
  • fast/text/international/lang-sensitive-fonts-xml.xhtml:
  • fast/text/international/lang-sensitive-fonts.html:
  • fast/text/international/locale-sensitive-fonts-expected.html:
  • fast/text/international/locale-sensitive-fonts.html:
  • fast/text/ja-sans-serif-expected-mismatch.html: Added.
  • fast/text/ja-sans-serif.html: Added.
  • platform/ios/fast/block/float/016-expected.txt:
5:50 PM Changeset in webkit [241287] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Remove noisy and unnecessary logs added in r241223
​https://bugs.webkit.org/show_bug.cgi?id=194427

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Errors occur all the time in the XPC connection's event handler, like when a process terminates.
We don't need to print an "error" every time any process terminates.

5:16 PM Changeset in webkit [241286] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Updating for all of Mac WK2 for flaky test
​https://bugs.webkit.org/show_bug.cgi?id=185994

Unreviewed test gardening.

Patch by Shawn Roberts <Shawn Roberts> on 2019-02-11

  • platform/mac-wk2/TestExpectations:
5:15 PM Changeset in webkit [241285] by BJ Burg
  • 2 edits in trunk/Source/WebKit

[Cocoa] Web Automation: client callbacks are not called if delegate does not override
​https://bugs.webkit.org/show_bug.cgi?id=194519
<rdar://problem/47981961>

Reviewed by Joseph Pecoraro.

Call the completion handler directly if the delegate does not implement the relevant method.

  • UIProcess/Cocoa/AutomationSessionClient.mm:

(WebKit::AutomationSessionClient::requestNewPageWithOptions):
(WebKit::AutomationSessionClient::requestSwitchToPage):
(WebKit::AutomationSessionClient::requestHideWindowOfPage):
(WebKit::AutomationSessionClient::requestRestoreWindowOfPage):
(WebKit::AutomationSessionClient::requestMaximizeWindowOfPage):

5:04 PM Changeset in webkit [241284] by dbates@webkit.org
  • 4 edits
    4 adds in trunk

[iOS] Adopt SPI to support Emacs bindings: transpose and delete to end of paragraph
​https://bugs.webkit.org/show_bug.cgi?id=194505
<rdar://problem/47743533>

Reviewed by Tim Horton.

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deleteToEndOfParagraph]): Added.
(-[WKContentView _transpose]): Added.

LayoutTests:

Add tests to ensure that Control + t and Control + k perform a transpose and delete to the
end of the line/paragraph. Skip the tests for now until we have the UIKit fix <rdar://problem/44928156>.

  • fast/events/ios/key-command-delete-to-end-of-paragraph-expected.txt: Added.
  • fast/events/ios/key-command-delete-to-end-of-paragraph.html: Added.
  • fast/events/ios/key-command-transpose-expected.txt: Added.
  • fast/events/ios/key-command-transpose.html: Added.
  • platform/ios/TestExpectations: Skip tests for now.
4:07 PM Changeset in webkit [241283] by Adrian Perez de Castro
  • 26 edits
    1 copy in trunk

[GTK][WPE] Add content extensions support in WKTR and unskip layout tests
​https://bugs.webkit.org/show_bug.cgi?id=193622

Reviewed by Michael Catanzaro.

.:

  • Source/cmake/OptionsGTK.cmake: Enable CONTENT_EXTENSIONS by default.
  • Source/cmake/OptionsWPE.cmake: Ditto.
  • Source/cmake/WebKitFeatures.cmake: Add a private CONTENT_EXTENSIONS option.

Source/WebCore:

No new tests needed.

  • SourcesCocoa.txt: Remove loader/ResourceLoadInfo.cpp, it's not Cocoa-specific anymore.
  • Sources.txt: Add loader/ResourceLoadInfo.cpp, all ports use it now.

Source/WebKit:

  • NetworkProcess/cache/NetworkCacheData.h: Define an adoptAndMapFile() implementation

for GFileIOStream objects.

  • NetworkProcess/cache/NetworkCacheDataSoup.cpp:

(WebKit::NetworkCache::adoptAndMapFile): Added implementation, which extracts the file
descriptor from a GFileIOStream, as it inherits from GFileDescriptorBased, and then
reuses the version of adoptAndMapFile() which takes a file descritor for the actual work.

  • NetworkProcess/NetworkLoadChecker.cpp:

(Webkit::NetworkLoadChecker::checkRequest): Use "this" when referring to
processContentExtensionRulesForLoad() in order to avoid ambiguity.

  • Sources.txt: Add WKUserContentExtensionStoreRef.cpp, all ports use it now.
  • SourcesCocoa.txt: Remove WKUserContentExtensionStoreRef.cpp, because it is not

Cocoa-specific anymore.

  • SourcesGTK.txt: Add APIContentRuleListStoreGLib.cpp.
  • SourcesWPE.txt: Ditto.
  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreCreate): Added.
(toResult): Added.
(WKUserContentExtensionStoreCompile): Added.
(WKUserContentExtensionStoreLookup): Added.
(WKUserContentExtensionStoreRemove): Added.

  • UIProcess/API/C/WKUserContentExtensionStoreRef.h: Add declarations for the new C API

functions and for the WKUserContentExtensionStoreResult status enum.

  • UIProcess/API/glib/APIContentRuleListStoreGLib.cpp: Added.

(API::ContentRuleListStore::defaultStorePath): Add a dummy implementation. The public API
for the GLib based ports (GTK+ and WPE) will not allow using the default store and will
always indicating a path.

Tools:

This adds support for loading content extension rule sets from the JSON files which
accompany the corresponding layout test, using the C API. The Cocoa specific parts
of WKTR for this could be removed, but that is left for a follow-up patch with
cleanups.

  • Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
  • WebKitTestRunner/TestController.cpp:

(WTR::testPath): Subtract one from the length when constructing the result std::string to
avoid having the null-terminator copied into the result.
(WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
part of the preparations to run a test.
(WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
(WTR::contentExtensionStoreCallback): Added.
(WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
used for content extensions test.
(WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
extensions and compiling the JSON rule set for tests involving content extensions.
(WTR::TestController::resetContentExtensions): Removes the content extension built for
testing and disables content extensions.
(WTR::TestController::resetPreferencesToConsistentValues): Add a call to
resetContentExtensions().
(WTR::TestController::userContentController): Added implementation for ports other than Cocoa.

  • WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),

configureContentExtensionForTest(), and userContentController().

LayoutTests:

  • platform/gtk/TestExpectations: Un-skip tests for content extensions and add expectations.
3:24 PM Changeset in webkit [241282] by dbates@webkit.org
  • 32 edits
    7 adds in trunk

[iOS] Mouse/Touch/Pointer events are missing modifier keys
​https://bugs.webkit.org/show_bug.cgi?id=191446
<rdar://problem/45929460>

Reviewed by Tim Horton.

Source/WebCore:

Extract the modifier flags from the WebEvent. This code is only used by Legacy WebKit
on iOS and we will need to fix <rdar://problem/47929759> in order for modifier flags
to be passed to WebKit.

Tests: fast/events/touch/ios/mouse-events-with-modifiers.html

fast/events/touch/ios/pointer-events-with-modifiers.html
fast/events/touch/ios/touch-events-with-modifiers.html

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:

(-[WebEvent initWithMouseEventType:timeStamp:location:]):
(-[WebEvent initWithMouseEventType:timeStamp:location:modifiers:]):

Source/WebKit:

Make use of UIKit SPI to retreive the modifier flags when dispatching mouse and touch events.
Add new WebKit SPI for iOS, -[WKNavigationAction modifierFlags], to retrieve the the modifier
flags held when a navigation action was initiated.

  • Platform/spi/ios/UIKitSPI.h: Expose SPI.
  • Shared/NativeWebTouchEvent.h: Re-arrange macro guards so that we can expose the helper function

WebKit::webEventModifierFlags(). This is a bit more involved that usual since this header is included
from both C++ and Objective-C source files. It only makes sense to expose this function when
compiling as part of an Objective-C source file.

  • Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Modified to take the modifier flags held down
when the platform touch event was received and pass them through to the base constructor.
(WebKit::webEventModifierFlags): Added. Converts from the platform-speciifc UIKeyModifierFlags to
OptionSet<WebKit::WebEvent::Modifier>.

  • Shared/ios/WebIOSEventFactory.h:
  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::toUIKeyModifierFlags): Added. Converts from OptionSet<WebKit::WebEvent::Modifier>
to the platform-specific UIKeyModifierFlags.

  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction modifierFlags]): Added.

  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(gestureRecognizerModifierFlags): Added.

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapCommited:]):
Pass modifier flags through.

(-[WKContentView _attemptClickAtLocation:modifierFlags:]): Added.
(-[WKContentView actionSheetAssistant:openElementAtLocation:]): This is invoked when a person opens a link
via the action sheet. We don't have access to the modifier flags to pass. It also seems like an implementation
detail that this action is implemented via mouse click and we should re-evaluate this decision in light of
the fact tht the action sheet is browser UI and we tend to be very reserved on what UI actions are visible
to the page. On Mac, opening a link via the context menu is not visible to the page, at least from a mouse
event perspective.
(webEventFlagsForUIKeyModifierFlags): Added.
(-[WKContentView _hoverGestureRecognizerChanged:]): Pass modifier flags through.
(-[WKContentView _attemptClickAtLocation:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleTwoFingerTapAtPoint):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::handleTap):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):
Pass modifier flags through.

Tools:

Add support infrastructure for testing touch and stylus taps when holding modifier keys.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::arrayLength):
(WTR::parseModifierArray):
(WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

LayoutTests:

Refactor existing iOS key events tests to share code. Add new tests to ensure touch and mouse events
have accurate modifier key details.

  • fast/events/ios/key-events-meta-alt-combinations.html:
  • fast/events/ios/resources/key-tester.js:

(computeSubsets.compareByModifierOrder): Deleted.

  • fast/events/resources/compute-subsets.js: Added.

(computeSubsets.compareByOriginalArrayOrder):
(computeSubsets):

  • fast/events/touch/ios/mouse-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/mouse-events-with-modifiers.html: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers.html: Added.
  • fast/events/touch/ios/touch-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/touch-events-with-modifiers.html: Added.
  • http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Update expected result

due to changes to ui-helper.js.

  • http/tests/security/anchor-download-block-crossorigin-expected.txt: Ditto.
  • platform/ios/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.tapAt.return.new.Promise):
(window.UIHelper.tapAt):
(window.UIHelper.stylusTapAt.return.new.Promise):
(window.UIHelper.stylusTapAt):

2:52 PM Changeset in webkit [241281] by jer.noble@apple.com
  • 15 edits
    1 move in trunk/Source

[Cocoa] Notify AVSystemController of our presenting PID before registering as a Now Playing app.
​https://bugs.webkit.org/show_bug.cgi?id=194504

Reviewed by Eric Carlson.

Source/WebCore:

This allows the MediaRemote framework to associate the WebContent process with its host application.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):

  • platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::prepareToSendUserMediaPermissionRequest):

  • platform/audio/cocoa/MediaSessionManagerCocoa.h:
  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(MediaSessionManagerCocoa::prepareToSendUserMediaPermissionRequest):
(MediaSessionManagerCocoa::providePresentingApplicationPIDIfNecessary):
(MediaSessionManagerCocoa::updateNowPlayingInfo):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/ios/CelestialSPI.h: Renamed from Source/WebKit/Platform/spi/ios/CelestialSPI.h.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::requestUserMediaAccess):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::userMediaPermissionRequestManager):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::prepareToSendUserMediaPermissionRequest): Deleted.

2:44 PM Changeset in webkit [241280] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Randomize insertion of deallocated StructureIDs into the StructureIDTable's free list.
​https://bugs.webkit.org/show_bug.cgi?id=194512
<rdar://problem/47975465>

Reviewed by Yusuke Suzuki.

  • runtime/StructureIDTable.cpp:

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

  • runtime/StructureIDTable.h:
2:27 PM Changeset in webkit [241279] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: add context menu items to copy a resource's HTTP request/response data
​https://bugs.webkit.org/show_bug.cgi?id=194261
<rdar://problem/21693696>

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/Resource.js:

(WI.Resource.prototype.stringifyHTTPRequest): Added.
(WI.Resource.prototype.stringifyHTTPResponse): Added.
Don't include the request/response data, as that can be very large, and can easily be
accessed by actually selecting the resource in the Resources/Network tab.

  • UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

  • Localizations/en.lproj/localizedStrings.js:
1:55 PM Changeset in webkit [241278] by commit-queue@webkit.org
  • 32 edits
    7 deletes in trunk

Unreviewed, rolling out r241272 and r241276.
​https://bugs.webkit.org/show_bug.cgi?id=194514

Broke the Apple Internal build and the fix requires human
intervention :( (Requested by dydz on #webkit).

Reverted changesets:

"[iOS] Mouse/Touch/Pointer events are missing modifier keys"
​https://bugs.webkit.org/show_bug.cgi?id=191446
​https://trac.webkit.org/changeset/241272

"Fix internal iOS build after r241272"
​https://bugs.webkit.org/show_bug.cgi?id=191446
​https://trac.webkit.org/changeset/241276

1:47 PM Changeset in webkit [241277] by Truitt Savell
  • 3 edits in trunk/Tools

Unreviewed, rolling out r241269.

Caused 5 layout tests crashes on Mac WK1

Reverted changeset:

"DumpRenderTree should report unknown options"
​https://bugs.webkit.org/show_bug.cgi?id=191303
​https://trac.webkit.org/changeset/241269

12:43 PM Changeset in webkit [241276] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix internal iOS build after r241272
​https://bugs.webkit.org/show_bug.cgi?id=191446

  • Platform/spi/ios/UIKitSPI.h:

Declare the _modifierFlags when using the internal SDK also.

11:30 AM Changeset in webkit [241275] by Wenson Hsieh
  • 15 edits in trunk

fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
​https://bugs.webkit.org/show_bug.cgi?id=194313

Reviewed by Tim Horton.

Source/WebKit:

Make -dateTimePickerCalendarType work on iPad by handling the case where the date picker control is a
WKDateTimePopover. This fixes UIScriptController::calendarType() returning null on iPad.

  • UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKFormInputControl dateTimePickerCalendarType]):
(-[WKDateTimePopover calendarType]):

Tools:

Add a helper to determine whether the web view is presenting modal UI.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isPresentingModally const):

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::isPresentingModally const):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/UIScriptControllerCocoa.mm:

(WTR::UIScriptController::calendarType const): Deleted.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isPresentingModally const):
(WTR::UIScriptController::calendarType const):

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::calendarType const):

LayoutTests:

Adjusts an existing layout test to work on both iPhone and iPad simulators.

  • fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry-expected.txt:
  • fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html:

Make this test wait after blurring the currently focused element, such that tapping to focus the next form
control doesn't fail. Notably on iPad, not waiting for the popover to dismiss meant that subsequent taps would
be dispatched too soon, and hit-test to the popover view being dismissed rather than WKWebView.

  • platform/ipad/TestExpectations:

Unskip the test on iPad.

  • resources/ui-helper.js:

Add helpers to query whether or not the keyboard is shown, and whether or not a view controller is being modally
presented over the current root view controller (this is the case when interacting with date pickers on iPad).

(window.UIHelper.isShowingKeyboard):
(window.UIHelper.isPresentingModally):
(window.UIHelper.deactivateFormControl):

Add a new helper method to blur the given form control element and wait for web view chrome to finish dismissing
(on iOS, this is either the date picker input view in the keyboard on iPhone, or the date picker popover view
controller on iPad).

(window.UIHelper.isShowingDataListSuggestions):

Drive-by fix: remove an extraneous ternary conditional statement.

11:25 AM Changeset in webkit [241274] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

GCHeapInspector: Show the retained sizes in more places
​https://bugs.webkit.org/show_bug.cgi?id=194464

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-02-11
Reviewed by Simon Fraser.

  • GCHeapInspector/gc-heap-inspector.html:
  • GCHeapInspector/script/interface.js:

(HeapInspectorUtils.humanReadableSize):
(HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
(HeapInspectorUtils.spanForNode.span.span):
(HeapSnapshotInspector.prototype.buildAllObjectsByType):
(HeapSnapshotInspector.prototype.buildRoots):

11:02 AM Changeset in webkit [241273] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Stop using setDefersLoading from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=194315

Reviewed by Jer Noble.

That is what CompletionHandlers are for.

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::setDefersLoading): Deleted.

  • loader/MediaResourceLoader.h:
  • platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::responseReceived):
(WebCore::PlatformMediaResource::stop):
(WebCore::PlatformMediaResource::setDefersLoading): Deleted.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Deleted.

11:01 AM Changeset in webkit [241272] by dbates@webkit.org
  • 32 edits
    7 adds in trunk

[iOS] Mouse/Touch/Pointer events are missing modifier keys
​https://bugs.webkit.org/show_bug.cgi?id=191446
<rdar://problem/45929460>

Reviewed by Tim Horton.

Source/WebCore:

Extract the modifier flags from the WebEvent. This code is only used by Legacy WebKit
on iOS and we will need to fix <rdar://problem/47929759> in order for modifier flags
to be passed to WebKit.

Tests: fast/events/touch/ios/mouse-events-with-modifiers.html

fast/events/touch/ios/pointer-events-with-modifiers.html
fast/events/touch/ios/touch-events-with-modifiers.html

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

  • platform/ios/WebEvent.h:
  • platform/ios/WebEvent.mm:

(-[WebEvent initWithMouseEventType:timeStamp:location:]):
(-[WebEvent initWithMouseEventType:timeStamp:location:modifiers:]):

Source/WebKit:

Make use of UIKit SPI to retreive the modifier flags when dispatching mouse and touch events.
Add new WebKit SPI for iOS, -[WKNavigationAction modifierFlags], to retrieve the the modifier
flags held when a navigation action was initiated.

  • Platform/spi/ios/UIKitSPI.h: Expose SPI.
  • Shared/NativeWebTouchEvent.h: Re-arrange macro guards so that we can expose the helper function

WebKit::webEventModifierFlags(). This is a bit more involved that usual since this header is included
from both C++ and Objective-C source files. It only makes sense to expose this function when
compiling as part of an Objective-C source file.

  • Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): Modified to take the modifier flags held down
when the platform touch event was received and pass them through to the base constructor.
(WebKit::webEventModifierFlags): Added. Converts from the platform-speciifc UIKeyModifierFlags to
OptionSet<WebKit::WebEvent::Modifier>.

  • Shared/ios/WebIOSEventFactory.h:
  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::toUIKeyModifierFlags): Added. Converts from OptionSet<WebKit::WebEvent::Modifier>
to the platform-specific UIKeyModifierFlags.

  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction modifierFlags]): Added.

  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(gestureRecognizerModifierFlags): Added.

(-[WKContentView _webTouchEventsRecognized:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _twoFingerSingleTapGestureRecognized:]):
(-[WKContentView _singleTapCommited:]):
Pass modifier flags through.

(-[WKContentView _attemptClickAtLocation:modifierFlags:]): Added.
(-[WKContentView actionSheetAssistant:openElementAtLocation:]): This is invoked when a person opens a link
via the action sheet. We don't have access to the modifier flags to pass. It also seems like an implementation
detail that this action is implemented via mouse click and we should re-evaluate this decision in light of
the fact tht the action sheet is browser UI and we tend to be very reserved on what UI actions are visible
to the page. On Mac, opening a link via the context menu is not visible to the page, at least from a mouse
event perspective.
(webEventFlagsForUIKeyModifierFlags): Added.
(-[WKContentView _hoverGestureRecognizerChanged:]): Pass modifier flags through.
(-[WKContentView _attemptClickAtLocation:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleTwoFingerTapAtPoint):
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::handleTap):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):
Pass modifier flags through.

Tools:

Add support infrastructure for testing touch and stylus taps when holding modifier keys.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::arrayLength):
(WTR::parseModifierArray):
(WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
(WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
(WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
(WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.

LayoutTests:

Refactor existing iOS key events tests to share code. Add new tests to ensure touch and mouse events
have accurate modifier key details.

  • fast/events/ios/key-events-meta-alt-combinations.html:
  • fast/events/ios/resources/key-tester.js:

(computeSubsets.compareByModifierOrder): Deleted.

  • fast/events/resources/compute-subsets.js: Added.

(computeSubsets.compareByOriginalArrayOrder):
(computeSubsets):

  • fast/events/touch/ios/mouse-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/mouse-events-with-modifiers.html: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/pointer-events-with-modifiers.html: Added.
  • fast/events/touch/ios/touch-events-with-modifiers-expected.txt: Added.
  • fast/events/touch/ios/touch-events-with-modifiers.html: Added.
  • http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Update expected result

due to changes to ui-helper.js.

  • http/tests/security/anchor-download-block-crossorigin-expected.txt: Ditto.
  • platform/ios/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.tapAt.return.new.Promise):
(window.UIHelper.tapAt):
(window.UIHelper.stylusTapAt.return.new.Promise):
(window.UIHelper.stylusTapAt):

11:00 AM Changeset in webkit [241271] by dbates@webkit.org
  • 4 edits in trunk/Source/WebCore

Separate out outline-style: auto user-agent appearance from Mac animated focus ring drawing
​https://bugs.webkit.org/show_bug.cgi?id=193591

Reviewed by Simon Fraser.

Untangle the Mac-specific concept of animated focus ring drawing from the concepts of using
the fancy shrink-wrapped focus ring appearance and using the platform focus ring color when
outline-style: auto.

No functionality changed. So, no new tests.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::drawFocusRing):
(WebCore::drawFocusRingToContextAtTime):
Change some macro guards.

  • rendering/RenderElement.cpp:

(WebCore::usePlatformFocusRingColorForOutlineStyleAuto): Added.
(WebCore::useShrinkWrappedFocusRingForOutlineStyleAuto): Added.
(WebCore::drawFocusRing): Added.
(WebCore::RenderElement::paintFocusRing): Write in terms of drawFocusRing().

10:49 AM Changeset in webkit [241270] by youenn@apple.com
  • 9 edits
    2 adds in trunk

Filter out Overconstrainederror.constraint when getUserMedia is not granted
​https://bugs.webkit.org/show_bug.cgi?id=194240

Reviewed by Eric Carlson.

Source/WebKit:

Make sure in UIProcess to filter out constraint if either the page was not granted gum access or it has no persistent access.

Refactor UserMediaPermissionRequestManagerProxy to make the implementation easier to understand.

Covered by added test.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo):

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::captureDevicesChanged):
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManagerProxy::grantAccess):
(WebKit::UserMediaPermissionRequestManagerProxy::getRequestAction):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionInvalidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::processUserMediaPermissionValidRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo):
(WebKit::UserMediaPermissionRequestManagerProxy::wasGrantedVideoOrAudioAccess):
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::createPermissionRequest): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::isPending const):
(WebKit::UserMediaPermissionRequestProxy::setEligibleVideoDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::setEligibleAudioDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::hasAudioDevice const):
(WebKit::UserMediaPermissionRequestProxy::hasVideoDevice const):
(WebKit::UserMediaPermissionRequestProxy::hasPersistentAccess const):
(WebKit::UserMediaPermissionRequestProxy::setHasPersistentAccess):
(WebKit::UserMediaPermissionRequestProxy::userMediaID const):
(WebKit::UserMediaPermissionRequestProxy::topLevelDocumentSecurityOrigin const):
(WebKit::UserMediaPermissionRequestProxy::userMediaDocumentSecurityOrigin const):
(WebKit::UserMediaPermissionRequestProxy::userRequest const):
(WebKit::UserMediaPermissionRequestProxy::setDeviceIdentifierHashSalt):
(WebKit::UserMediaPermissionRequestProxy::deviceIdentifierHashSalt const):
(WebKit::UserMediaPermissionRequestProxy::audioDevice const):
(WebKit::UserMediaPermissionRequestProxy::videoDevice const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebPageProxy.h:

LayoutTests:

  • fast/mediastream/overconstrainederror-constraint-expected.txt: Added.
  • fast/mediastream/overconstrainederror-constraint.html: Added.
10:32 AM Changeset in webkit [241269] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

DumpRenderTree should report unknown options
​https://bugs.webkit.org/show_bug.cgi?id=191303

Patch by Darshan Kadu <​dkadu@igalia.com> on 2019-02-11
Reviewed by Frédéric Wang.

Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
to report unknown options.
Added and assigned test options which are currently used in tests.

  • DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

10:22 AM Changeset in webkit [241268] by Truitt Savell
  • 25 edits
    1 copy
    1 add
    2 deletes in trunk

Unreviewed, rolling out r241229.

Revision broke internal builds for watchOS.

Reverted changeset:

"[Cocoa] Ask platform for generic font family mappings"
​https://bugs.webkit.org/show_bug.cgi?id=187723
​https://trac.webkit.org/changeset/241229

10:10 AM Changeset in webkit [241267] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor.
​https://bugs.webkit.org/show_bug.cgi?id=194493
<rdar://problem/36380852>

Reviewed by Yusuke Suzuki.

Having duplicate cases in the BinarySwitch is not a correctness issue. It is
however not good for performance and memory usage. As such, a debug ASSERT will
do. We'll also do an audit of the clients of BinarySwitch to see if it's
possible to be instantiated with duplicate cases in
​https://bugs.webkit.org/show_bug.cgi?id=194492 later.

Also added some value dumps to the RELEASE_ASSERT to help debug the issue when we
see duplicate cases.

  • jit/BinarySwitch.cpp:

(JSC::BinarySwitch::BinarySwitch):

9:29 AM Changeset in webkit [241266] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo][MiniBrowser] Basic authentication always fails.
​https://bugs.webkit.org/show_bug.cgi?id=194496

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2019-02-11
Reviewed by Don Olmstead.

  • MiniBrowser/win/DialogHelper.h:

(Dialog::getText):

9:20 AM Changeset in webkit [241265] by youenn@apple.com
  • 4 edits in trunk

Make Request constructor throw if FetchRequestInit.signal is not undefined, null or an AbortSignal object
​https://bugs.webkit.org/show_bug.cgi?id=194404
<rdar://problem/47891915>

Reviewed by Geoffrey Garen.

Source/WebCore:

Align with the spec, except for known problematic web sites.
Covered by updated test.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::needsSignalQuirk):
(WebCore::processInvalidSignal):
(WebCore::FetchRequest::initializeWith):

LayoutTests:

  • http/wpt/fetch/request-abort-expected.txt:
8:23 AM Changeset in webkit [241264] by Alan Bujtas
  • 12 edits in trunk/Source/WebCore

[LFC] FormattingContext::Geometry::floatingHeightAndMargin should take UsedHorizontalValues
​https://bugs.webkit.org/show_bug.cgi?id=194490

Reviewed by Antti Koivisto.

This is in preparation for adding floating preferred width computation support. It requires height computaiton
which uses containing block width to resolve vertical margins.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeBorderAndPadding const):

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedVerticalMargin):

  • layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

  • layout/LayoutUnits.h:

(WebCore::Layout::UsedHorizontalValues::UsedHorizontalValues):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

8:19 AM Changeset in webkit [241263] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC] FormattingContext::intrinsicWidthConstraints should compute and save the intrinsic widths consistently.
​https://bugs.webkit.org/show_bug.cgi?id=194483

Reviewed by Antti Koivisto.

Rename intrinsicWidthConstraints to computeIntrinsicWidthConstraints (it does not return the width values anymore).

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::BlockFormattingContext::intrinsicWidthConstraints const): Deleted.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::intrinsicWidthConstraints const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
6:08 AM Changeset in webkit [241262] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[WPE] Do not try to create empty egl windows
​https://bugs.webkit.org/show_bug.cgi?id=194497

Reviewed by Žan Doberšek.

In AcceleratedSurfaceWPE we ensure the size we pass to wpe is at least 0x0, but wl_egl_window_create() returns
nullptr if 0 is passed as width or height. We should use at least 1x1 instead.

  • WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:

(WebKit::AcceleratedSurfaceWPE::initialize):
(WebKit::AcceleratedSurfaceWPE::clientResize):

4:14 AM Changeset in webkit [241261] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GStreamer] GstMappedBuffer testsuite build fails
​https://bugs.webkit.org/show_bug.cgi?id=194495

Patch by Philippe Normand <​pnormand@igalia.com> on 2019-02-11
Reviewed by Carlos Garcia Campos.

Fix the build by explicitely adding the gstreamer1.0-audio include
directories to the include path.

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/PlatformWPE.cmake:
12:12 AM Changeset in webkit [241260] by Carlos Garcia Campos
  • 15 edits
    5 deletes in trunk/Source/WebKit

[WPE] Do not use a sync IPC message to send the host FD to the web process
​https://bugs.webkit.org/show_bug.cgi?id=194216

Reviewed by Darin Adler.

It can be sent as a web page creation parameter instead.

  • PlatformWPE.cmake:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • SourcesWPE.txt:
  • UIProcess/API/wpe/CompositingManagerProxy.cpp: Removed.
  • UIProcess/API/wpe/CompositingManagerProxy.h: Removed.
  • UIProcess/API/wpe/CompositingManagerProxy.messages.in: Removed.
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::hostFileDescriptor):

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):

  • UIProcess/API/wpe/WPEView.h:

(WKWPE::View::create):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_hostFileDescriptor):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::releaseHostFileDescriptor):

  • WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:

(WebKit::AcceleratedSurfaceWPE::AcceleratedSurfaceWPE):
(WebKit::AcceleratedSurfaceWPE::initialize):

  • WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.h:
  • WebProcess/WebPage/wpe/CompositingManager.cpp: Removed.
  • WebProcess/WebPage/wpe/CompositingManager.h: Removed.
12:06 AM Changeset in webkit [241259] by zandobersek@gmail.com
  • 9 edits
    5 adds in trunk/LayoutTests

Unreviewed WPE gardening. Adding additional baselines after font variations
enablement. Additionally rebaselining a couple other WPT and WebGL tests.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/css/getComputedStyle: Added.
  • platform/wpe/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/wpe/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
  • platform/wpe/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/wpe/fast/dom/52776-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any.worker-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
  • platform/wpe/svg/css/getComputedStyle-basic-expected.txt: Added.
  • platform/wpe/webgl/2.0.0/conformance/canvas/buffer-offscreen-test-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/canvas/buffer-preserve-test-expected.txt:
  • platform/wpe/webgl/2.0.0/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt:

Feb 10, 2019:

10:36 PM Changeset in webkit [241258] by Carlos Garcia Campos
  • 8 edits in trunk

[GTK][WPE] Add enable-javascript-markup setting
​https://bugs.webkit.org/show_bug.cgi?id=193439

Reviewed by Michael Catanzaro.

Source/WebKit:

Expose JavaScriptMarkupEnabled setting in the GLib API.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_javascript_markup):
(webkit_settings_set_enable_javascript_markup):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/wpe/WebKitSettings.h:
  • UIProcess/API/wpe/docs/wpe-0.1-sections.txt:

Tools:

Add test cases to check the new setting.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):
(testWebKitSettingsJavaScriptMarkup):
(beforeAll):

10:17 PM Changeset in webkit [241257] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

[LFC] Fix spelling error.
​https://bugs.webkit.org/show_bug.cgi?id=194489

Reviewed by Simon Fraser.

instrinsic -> intrinsic

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

  • layout/FormattingState.h:

(WebCore::Layout::FormattingState::setIntrinsicWidthConstraints):
(WebCore::Layout::FormattingState::clearIntrinsicWidthConstraints):
(WebCore::Layout::FormattingState::intrinsicWidthConstraints const):
(WebCore::Layout::FormattingState::setInstrinsicWidthConstraints): Deleted.
(WebCore::Layout::FormattingState::clearInstrinsicWidthConstraints): Deleted.
(WebCore::Layout::FormattingState::instrinsicWidthConstraints const): Deleted.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::intrinsicWidthConstraints const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const): Deleted.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraintsNeedChildrenWidth):
(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraintsNeedChildrenWidth): Deleted.
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints): Deleted.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::intrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
10:02 PM Changeset in webkit [241256] by Darin Adler
  • 20 edits in trunk

Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
​https://bugs.webkit.org/show_bug.cgi?id=194485

Reviewed by Daniel Bates.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json): Use appendUnsignedAsHex along with
reinterpret_cast<uintptr_t> to replace uses of String::format with "%p".

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode): Removed some unneeded casts in StringBuilder code,
including one in a call to appendByteAsHex.
(JSC::globalFuncEscape): Ditto.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::encodeProtocolString): Use appendUnsignedAsHexFixedSize instead of String::format.

  • css/parser/CSSParserToken.cpp:

(WebCore::CSSParserToken::serialize const): Fixed style of many return statements
that called a function returning void; doesn't match WebKit's prevailing style.
Also use break instead of return. Used appendLiteral instead of append in many
cases, and append character instead of single-character literal in others.
Use appendUnsignedAsHex instead of String::format.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::generateHashedName): Use appendUnsignedAsHex instad of appendUnsigned64AsHex.
Should come back here and use makeString once we make HexNumber.h work with that.

  • platform/mac/WebCoreNSURLExtras.mm: Removed unnecessary include of HexNumber.h.
  • rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables): Use appendLiteral instead of multiple calls
to character append. Touched because it was next to a call to appendUnsignedAsHex.

Source/WebKit:

  • UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::completeDeviceIdHashSaltForOriginCall): Use
appendUnsignedAsHex instead of appendUnsigned64AsHex.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::loggingString): Use appendUnsignedAsHex and
reinterpret_cast<uintptr_t> instead of String::format and "%p".

Source/WTF:

  • wtf/HexNumber.h: Removed unused functions placeByteAsHexCompressIfPossible and

placeByteAsHex. Can always bring them back if someone needs them. Updated
appendUnsignedAsHex to be a template so we can use it on any integer type,
got rid of unnecessary use of Vector and unnecessary reversing, and got rid of
appendUnsigned64AsHex since callers can now just use appendUnsignedAsHex.
Rewrote appendUnsignedAsHexFixedSize to share mode code rather than replicating.

  • wtf/Logger.h: Use appendUnsignedAsHex instead of appendUnsigned64AsHex.
  • wtf/URL.cpp: Removed unnecessary include of HexNumber.h.
  • wtf/cocoa/NSURLExtras.h: Added missing include of Foundation.h that was

worked around in NSURLExtras.mm.

  • wtf/cocoa/NSURLExtras.mm: Removed unnecessary includes of HexNumber.h

and Foundation.h.

Tools:

  • WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
8:10 PM Changeset in webkit [241255] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r241230.
​https://bugs.webkit.org/show_bug.cgi?id=194488

"It regressed JetStream2 by ~6%" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"We should only make rope strings when concatenating strings
long enough."
​https://bugs.webkit.org/show_bug.cgi?id=194465
​https://trac.webkit.org/changeset/241230

7:25 PM Changeset in webkit [241254] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BBQ-Air: Emit better code for switch
​https://bugs.webkit.org/show_bug.cgi?id=194053

Reviewed by Yusuke Suzuki.

Instead of emitting a linear set of jumps for Switch, this patch
makes the BBQ-Air backend emit a binary switch.

  • wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addSwitch):

4:29 PM Changeset in webkit [241253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

libWPEWebKit-0.1.so: undefined reference to `JSC::JSValue::asCell() const
​https://bugs.webkit.org/show_bug.cgi?id=194484

Patch by Pablo Saavedra <Pablo Saavedra> on 2019-02-10
Reviewed by Darin Adler.

  • bindings/js/JSUndoItemCustom.cpp:
11:44 AM Changeset in webkit [241252] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk

Unreviewed, rolling out r241167.
​https://bugs.webkit.org/show_bug.cgi?id=194482

Broke the GTK mediastream tests (Requested by philn on
#webkit).

Reverted changeset:

"Filter out Overconstrainederror.constraint when getUserMedia
is not granted"
​https://bugs.webkit.org/show_bug.cgi?id=194240
​https://trac.webkit.org/changeset/241167

11:34 AM Changeset in webkit [241251] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, GTK Debug build fix after r241148.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
SourceBuffer::logClassName and friends are declared for
!RELEASE_LOG_DISABLED builds so adapt calling sites accordingly.

10:03 AM Changeset in webkit [241250] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Add intrinsic width support for inline-block boxes
​https://bugs.webkit.org/show_bug.cgi?id=194479

Reviewed by Antti Koivisto.

Compute the intrinsic width for the inline-block (formatting context root) and set it as the content box width while
laying out the content for the min/max width.

<div style="position: absolute">before<span id=inline-block style="display: inline-block">inline_block content<span>after</div>

The "inline-block" formatting root returns "inline_block" width for the minimum and "inline_block width" for
the maximum width. These min/max values are used to figure out the intrinsic width for the parent <div>.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):

  • layout/inlineformatting/InlineFormattingContext.h:
  • page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

8:53 AM Changeset in webkit [241249] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Add intrinsic width support for replaced boxes
​https://bugs.webkit.org/show_bug.cgi?id=194478

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeMargin const):
(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeMarginBorderAndPadding const): Deleted.

  • layout/inlineformatting/InlineFormattingContext.h:
6:38 AM Changeset in webkit [241248] by aboya@igalia.com
  • 2 edits in trunk/Source/WebCore

[MSE][GStreamer] Add missing return type to lambda
​https://bugs.webkit.org/show_bug.cgi?id=194414

Reviewed by Darin Adler.

Since g_signal_connect() is untyped, a compiler error was not
generated when a lambda with a missing GstFlowReturn return type was
provided for a signal that expects it.

This used to work before r240784 because a recent function call had
set GST_FLOW_OK in the return value register and it happened to
survive until the lambda function call ended. Starting on that commit
such return value was removed and it stopped working on debug.

Of course, the actual problem is in the signature of the lambda
function, and this patch fixes that.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):

Feb 9, 2019:

4:41 PM Changeset in webkit [241247] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Add more tests for clampTo<>()
​https://bugs.webkit.org/show_bug.cgi?id=194462

Reviewed by Geoffrey Garen.

Darin suggested to test the very last floating point number
at the boundaries when truncating to integer.
I added test for max/min and max-1/min-1.

  • TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

3:16 PM Changeset in webkit [241246] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, Lexer should use isLatin1 implementation in WTF
​https://bugs.webkit.org/show_bug.cgi?id=194466

Follow-up after r241233 pointed by Darin.

  • parser/Lexer.cpp:

(JSC::isLatin1): Deleted.

1:00 PM Changeset in webkit [241245] by Darin Adler
  • 5 edits in trunk

Fix change log dates; I thought webkit-patch land would do it for me

1:00 PM Changeset in webkit [241244] by Darin Adler
  • 58 edits in trunk

Eliminate unnecessary String temporaries by using StringConcatenateNumbers
​https://bugs.webkit.org/show_bug.cgi?id=194021

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::count): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::objectGroupForBreakpointAction): Ditto.
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl): Ditto.
(Inspector::InspectorDebuggerAgent::setBreakpoint): Ditto.

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty): Ditto.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed): Use String::numberToStringFixedWidth instead
of calling numberToFixedWidthString to do the same thing.
(JSC::numberProtoFuncToPrecision): Use String::number instead of calling
numberToFixedPrecisionString to do the same thing.

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions): Ditto.

Source/WebCore:

For floating point numbers, String::number gives a fixed precision result,
stripping trailing zeroes. When possible, I changed the code to instead use the
equivalent of String::numberToStringECMAScript, which is what makeString does by
default for floating point, gives the same results for many cases, and gives
better results in many others. However, for floats, we do not yet have a good
implementation, so instead I used FormattedNumber::fixedPrecision to match
the old behavior.

  • Modules/indexeddb/shared/IDBTransactionInfo.cpp:

(WebCore::IDBTransactionInfo::loggingString const): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create): Ditto.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect): Ditto. Added a cast to "unsigned" to sidestep the
ambiguity with 16-bit unsigned types that are sometimes used for numbers (uint16_t)
and sometimes used for UTF-16 code units (UChar) and can be the same type.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream): Use ASCIILiteral when intializing
a string instead of just a normal C literal. Switched to makeString so we could
remove String::number and do the conversion without allocating/destroying a String.
(WebCore::WebSocketChannel::didFail): Ditto.
(WebCore::WebSocketChannel::processFrame): Ditto.

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::WebSocketFrame::parseFrame): Ditto.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake): Ditto.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA const): Ditto.

  • bindings/js/JSDOMConvertNumbers.cpp:

(WebCore::rangeErrorString): Ditto.

  • css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::customCSSText const): Ditto. Used
FormattedNumber::fixedPrecision since these are floats.

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::toString const): Use
StringBuilder::builder.appendECMAScriptNumber instead of
String::numberToStringECMAScript so we can do it without allocating/destroying
a String.

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString const): Ditto.

  • dom/MessagePortIdentifier.h:

(WebCore::MessagePortIdentifier::logString const): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • editing/cocoa/DataDetection.mm:

(WebCore::dataDetectorStringForPath): Remove unnecessary type casts on values
passed to String::number and to StringBuilder::appendNumber. These could do
harm if the values were out of range, and should not be necessary.

  • history/BackForwardItemIdentifier.h:

(WebCore::BackForwardItemIdentifier::logString const): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • html/FTPDirectoryDocument.cpp:

(WebCore::processFileDateString): Ditto.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::getUniformLocation): Ditto.
(WebCore::WebGLRenderingContextBase::checkTextureCompleteness): Ditto.

  • inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::didReceiveResponse): Ditto.

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFailLoadingManifest): Ditto.

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::urlForBlankFrame): Ditto.

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Ditto.
(WebCore::PrintContext::pageSizeAndMarginsInPixels): Ditto.

  • page/WheelEventTestTrigger.cpp:

(WebCore::dumpState): Use StringBuilder::appendNumber instead of
String::number so we can do it without allocating/destroying a String.
Also use StringBuilder::appendLiteral on a literal.

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::ResourceUsageOverlay::platformDraw): Pass explicit
KeepTrailingZeros to FormattedNumber::fixedPrecision to preserve behavior,
since default is now to truncate trailing zeros.

  • platform/graphics/Color.cpp:

(WebCore::Color::cssText): Use StringBuilder::appendNumber instead of
calling numberToFixedPrecisionString to do the same thing.

  • platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::cssText): Ditto.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::animationIdentifier): Remove String::number and let makeString
do the conversion without allocating/destroying a String. Had to add
a typecast to convert the enumeration into an integer.

  • platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(WebCore::PlatformCAFilters::setFiltersOnLayer): Ditto.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::description const): Ditto.

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::MockMediaSample): Use AtomicString::number
instead of String::number to avoid unneccessarily allocating an additional
temporary String when an AtomicString already exists.

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::reportErrorToClient): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::setMaximumSize): Ditto.
(WebCore::SQLiteDatabase::setSynchronous): Ditto. Had to add a typecast to
convert the enumeration into an integer.

  • svg/SVGAngleValue.cpp:

(WebCore::SVGAngleValue::valueAsString const): Ditto.

  • svg/SVGLengthValue.cpp:

(WebCore::SVGLengthValue::valueAsString const): Ditto.

  • testing/Internals.cpp:

(WebCore::Internals::configurationForViewport): Ditto. Used
FormattedNumber::fixedPrecision since these are floats.
(WebCore::Internals::getCurrentCursorInfo): Use StringBuilder::appendNumber
instead of calling numberToFixedPrecisionString to do the same thing.
(WebCore::Internals::queueMicroTask): Remove String::number and let makeString
do the conversion without allocating/destroying a String.
(WebCore::appendOffsets): Use StringBuilder::appendNumber instead of
String::number so we can do it without allocating/destroying a String.

  • workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::toString const): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::databaseFilenameFromVersion): Ditto.

Source/WebKit:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::escapeIDForJSON): Use an ASCIILiteral to create a String.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::makeVersionedDirectoryPath): Remove String::number and let
makeString do the conversion without allocating/destroying a String.

  • NetworkProcess/mac/RemoteNetworkingContext.mm: Removed "using namespace WebCore".

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession): Remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • NetworkProcess/webrtc/NetworkMDNSRegister.cpp: Removed "using namespace WebCore".

(WebKit::registerMDNSNameCallback): Added explicit WebCore prefix as needed.
(WebKit::NetworkMDNSRegister::registerMDNSName): Ditto. Also remove String::number
and let makeString do the conversion without allocating/destroying a String.

  • UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData): Remove String::number and let makeString do the conversion
without allocating/destroying a String.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createInspectorTargets): Ditto.

  • UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView _URLForLinkAnnotation:]): Ditto.

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::uniqueWorldName): Ditto.

  • WebProcess/WebPage/WebPageInspectorTarget.cpp:

(WebKit::WebPageInspectorTarget::identifier const): Ditto.

Source/WTF:

  • wtf/URL.cpp:

(WTF::URL::setPort): Remove String::number and let makeString do the conversion
without allocating/destroying a String. Added a cast to "unsigned" to sidestep the
ambiguity with 16-bit unsigned types that are sometimes used for numbers (uint16_t)
and sometimes used for UTF-16 code units (UChar) and can be the same type.

  • wtf/text/StringConcatenateNumbers.h:

Changed FormattedNumber::fixedPrecision to more closely match String::number and
StringBuilder::appendNumber by defaulting to truncating trailing zeros and using
a named enumeration for the truncation policy rather than a boolean.

Tools:

  • TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:

(TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
to understand. Updated tests for changes to FormattedNumber::fixedPrecision.

12:37 PM Changeset in webkit [241243] by Alan Bujtas
  • 5 edits in trunk

[LFC][IFC] Add intrinsic width support for basic inline containers
​https://bugs.webkit.org/show_bug.cgi?id=194473

Reviewed by Antti Koivisto.

Source/WebCore:

Preferred width computation logic is very similar to normal layout.
One of the main difference is that the preferred width codepath does not provide valid containing block width.
This patch implement basic inline container support by passing nullopt containing block width in UsedHorizontalValues.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::computeMarginBorderAndPadding const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):

  • layout/inlineformatting/InlineFormattingContext.h:

Tools:

Expand tests coverage (11 new tests -> 798)

  • LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
11:44 AM Changeset in webkit [241242] by ysuzuki@apple.com
  • 4 edits in trunk/Source

Unreviewed, rolling in r241237 again
​https://bugs.webkit.org/show_bug.cgi?id=194469

Source/JavaScriptCore:

  • runtime/JSString.h:

(JSC::jsSubstring):

Source/WTF:

After the measurement, this patch was unrelated to recent regression.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::isSubString const):
(WTF::StringImpl::createSubstringSharingImpl):

9:52 AM Changeset in webkit [241241] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r241237.
​https://bugs.webkit.org/show_bug.cgi?id=194474

Shows significant memory increase in WSL (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"[WTF] Use BufferInternal StringImpl if substring StringImpl
takes more memory"
​https://bugs.webkit.org/show_bug.cgi?id=194469
​https://trac.webkit.org/changeset/241237

8:04 AM Changeset in webkit [241240] by Michael Catanzaro
  • 3 edits in trunk/Source/WebKit

[GTK] Fix typo in the newly added API
​https://bugs.webkit.org/show_bug.cgi?id=194472

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2019-02-09
Reviewed by Michael Catanzaro.

Fix a typo: enableed -> enabled.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_set_enable_back_forward_navigation_gestures):

  • UIProcess/API/gtk/WebKitSettings.h:
1:39 AM Changeset in webkit [241239] by Nikita Vasilyev
  • 2 edits in trunk/LayoutTests

Web Inspector: fix typos in tests

Unreviewed test gardening.

  • inspector/css/force-page-appearance.html:
12:11 AM Changeset in webkit [241238] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix MiniBrowser's entitlements
​https://bugs.webkit.org/show_bug.cgi?id=192431

Reviewed by Joseph Pecoraro.

MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
files, making it impossible to load any extension.

  • MiniBrowser/MiniBrowser.entitlements:
Note: See TracTimeline for information about the timeline view.