Timeline



Apr 25, 2019:

11:39 PM Changeset in webkit [244683] by mmaxfield@apple.com
  • 7 edits in trunk/Source

[iOS] Add internal setting to force -webkit-text-size-adjust to "auto"
​https://bugs.webkit.org/show_bug.cgi?id=197275
<rdar://problem/50211019>

Reviewed by Simon Fraser.

Source/WebCore:

This setting makes it easier to investigate the autosizing work we've been doing
in ​https://bugs.webkit.org/show_bug.cgi?id=197250.

  • page/Settings.yaml:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • UIProcess/WebPreferences.h:
11:33 PM Changeset in webkit [244682] by mmaxfield@apple.com
  • 19 edits
    5 adds in trunk

[iOS] Implement idempotent mode for text autosizing
​https://bugs.webkit.org/show_bug.cgi?id=197250
<rdar://problem/50211034>

Reviewed by Jon Lee.

Source/WebCore:

Our text autosizing code has this interesting behavior where it is sensitive to the width of the text's container
and the number of lines of text inside the element. Not only is it sensitive to those things, but as those things
change, their values are stored inside the RenderObject itself and then never recomputed. This means that the text
autosizing parameters are sensitive to the entire history of an element. So, a newly created element with the same
style as an existing element can have dramatically different results.

This patch adds a new mode for text autosizing, which isn't sensitive to either of those things, and therefore
maintains the invariant that a newly created element will behave the same as an existing element with the same style.
Instead of using container size, it instead uses the viewport's initial scale. As the viewport's initial scale
changes, new layouts will be triggered, which will cause the autosizing code to use the new value.

Tests: fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html

fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html

  • page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::applyTextSizingIfNeeded):

  • page/Page.cpp:

(WebCore::Page::setInitialScale): WebKit will push the initial scale down into the page.

  • page/Page.h:

(WebCore::Page::initialScale const):

  • page/SettingsBase.h:
  • page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::textAutosizingUsesIdempotentMode):
(WebCore::SettingsBase::defaultTextAutosizingEnabled):

  • rendering/RenderBlockFlow.cpp:

(WebCore::idempotentTextSize): Describe a piecewise-linear curve for the text size to follow. The curve scales
depending on the viewport's initial scale.
(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderElement.cpp:

(WebCore::includeNonFixedHeight): This new mode should consider max-height as well as height when determining if
content overflows.
(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

  • rendering/RenderElement.h:
  • rendering/RenderObject.h:

Source/WebKit:

Push the initial scale down into the page.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):

LayoutTests:

Add two simple tests that make sure that fonts get autosized > 1x when the layout viewport is wide,
and that fonts don't get autosized when the layout viewport isn't wide.

We don't want to add tons of tests to test exact values because the curve will likely be tweaked
in the future.

  • fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-expected.txt: Added.
  • fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity-expected.txt: Added.
  • fast/text-autosizing/ios/idempotentmode/idempotent-autosizing-identity.html: Added.
  • fast/text-autosizing/ios/idempotentmode/idempotent-autosizing.html: Added.
11:33 PM Changeset in webkit [244681] by bshafiei@apple.com
  • 1 copy in tags/Safari-607.2.6.2.1

Tag Safari-607.2.6.2.1.

11:32 PM Changeset in webkit [244680] by bshafiei@apple.com
  • 2 edits in branches/safari-607.2.6.2-branch/Source/WTF

Cherry-pick r243641. rdar://problem/50232874

Unreviewed build fix.

  • wtf/CMakeLists.txt: Added SpanningTree.h to WTF_PUBLIC_HEADERS.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:26 PM Changeset in webkit [244679] by bshafiei@apple.com
  • 7 edits in branches/safari-607.2.6.2-branch/Source

Versioning.

11:06 PM Changeset in webkit [244678] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit

Make NetworkCache blobs safe for mmap instead of not using blobs
​https://bugs.webkit.org/show_bug.cgi?id=197264
<rdar://problem/49564348>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-25
Reviewed by Antti Koivisto.

This does what r244597 did for WKContentRuleLists but for the NetworkCache's blobs.
Those are the two cases where we were calling mmap and seeing crashes in apps with
default file protection of NSFileProtectionComplete.

  • NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::add):

  • NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::isSafeToUseMemoryMapForPath): Deleted.

  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm:

(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::mayContainBlob const):
(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):
(WebKit::NetworkCache::estimateRecordsSize): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:
10:51 PM Changeset in webkit [244677] by bshafiei@apple.com
  • 1 copy in branches/safari-607.2.6.2-branch

New branch.

8:46 PM Changeset in webkit [244676] by Fujii Hironori
  • 8 edits in trunk

Unreviewed, rolling out r244669.

Windows ports can't clean build.

Reverted changeset:

"[Win] Add flag to enable version information stamping and
disable by default."
​https://bugs.webkit.org/show_bug.cgi?id=197249
​https://trac.webkit.org/changeset/244669

7:55 PM Changeset in webkit [244675] by Simon Fraser
  • 7 edits in trunk

REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
​https://bugs.webkit.org/show_bug.cgi?id=188357
<rdar://problem/42986633>

Reviewed by Dean Jackson.
Source/WebCore:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

Source/WebKit:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetEventThrottlingBehaviorOverride):
(WKBundlePageSetCompositingPolicyOverride): Deleted.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
tests would fall into low memory mode and have different behavior.

Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
to Internals, so it's shared by DRT and WTR.

We no longer need the WK2 C SPI glue.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::prepare):

6:58 PM Changeset in webkit [244674] by sihui_liu@apple.com
  • 8 edits in trunk

[ iOS Sim ] REGRESSION (r242986) Layout Test storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196357
<rdar://problem/49386836>

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatch IDBRequest event to IDBTransaction if event of IDBTransaction has not been dispatched.

Covered by existing tests.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.h:

LayoutTests:

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
6:28 PM Changeset in webkit [244673] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ASSERT(scriptExecutionContext()) in Performance::resourceTimingBufferFullTimerFired()
​https://bugs.webkit.org/show_bug.cgi?id=197300
<rdar://problem/49965990>

Reviewed by Youenn Fablet.

We crash because the scriptExecutionContext has been destroyed by the time the m_resourceTimingBufferFullTimer
timer fires. However, r241598 already makes sure that we stop the timer when the script execution context
is destroyed. This makes me think that somebody restarts the timer *after* the script execution context has
been destroyed. The thing is that we only start the timer in Performance::addResourceTiming() and there are
only 2 call sites for this method. Both call sites get the Performance object from the Window object, which
they get from the Document object. As a result, I would believe that the Window's document is alive, even
though the Performance object's scriptExecutionContext is not. This could indicate that the Performance
object's scriptExecutionContext gets out of sync with its Window's document. I have found one place where
it could happen in theory (DOMWindow::didSecureTransitionTo()). I have not been able to write a test
confirming my theory though so this is a speculative fix. I have also added a few assertions to help us
track down the issue if my speculative fix turns out to be ineffective.

No new tests, we do not know how to reproduce.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::didSecureTransitionTo):
This is a speculative fix for the crash. When a DOMWindow transitions from one document to
another, reset its data members which store the DOMWindow's document to make sure that they
do not get out of sync.

(WebCore::DOMWindow::crypto const):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance const):
Add assertions to make sure that the member's scriptExecutionContext is in sync with
the window's.

  • page/Performance.cpp:

(WebCore::Performance::addResourceTiming):
Add assertion to make sure that the scriptExecutionContext() is non-null when calling this
as this may start the m_resourceTimingBufferFullTimer timer. If my speculative fix above
does not work, we should hit this and this should tell us which call site is causing this.

5:23 PM Changeset in webkit [244672] by youenn@apple.com
  • 2 edits
    1 add in trunk/Source/ThirdParty/libwebrtc

Make sure sockets file descriptors are in the correct range
​https://bugs.webkit.org/show_bug.cgi?id=197301
<rdar://problem/48389381>

Reviewed by Chris Dumez.

  • Source/webrtc/rtc_base/physicalsocketserver.cc:
  • WebKit/0001-fix-197301.patch: Added.
5:17 PM Changeset in webkit [244671] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: Including skipped tests in the final count
​https://bugs.webkit.org/show_bug.cgi?id=197298
<rdar://problem/49705424>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.

5:17 PM Changeset in webkit [244670] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Trying to load a main resource outside the sandbox should not crash the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=197299
<rdar://problem/49808042>

Reviewed by Geoffrey Garen.

Trying to load a main resource outside the sandbox should not crash the WebContent process. We should
simply ignore the load and log an error message.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

4:08 PM Changeset in webkit [244669] by Basuke Suzuki
  • 8 edits in trunk

[Win] Add flag to enable version information stamping and disable by default.
​https://bugs.webkit.org/show_bug.cgi?id=197249

Reviewed by Ross Kirsling.

This feature is only used in AppleWin port. Add flag for this task and make it OFF by default.
Then enable it by default on AppleWin.

.:

  • Source/cmake/OptionsWin.cmake:

Source/JavaScriptCore:

  • CMakeLists.txt:

Source/WebKitLegacy:

  • PlatformWin.cmake:

Source/WTF:

  • wtf/CMakeLists.txt:
3:41 PM Changeset in webkit [244668] by Simon Fraser
  • 2 edits in trunk/Tools

DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
​https://bugs.webkit.org/show_bug.cgi?id=197273

Reviewed by Dean Jackson.

Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
so that WebCoreTestSupport::resetInternalsObject() is always run.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):
(runTest):

3:09 PM Changeset in webkit [244667] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit

Only send a synthetic mouse out event if synthetic mouse move events were sent.
​https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233

Reviewed by Zalan Bujtas.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

2:52 PM Changeset in webkit [244666] by ysuzuki@apple.com
  • 9 edits in trunk/Source/bmalloc

[bmalloc] Follow-up and fixing bug after r244481
​https://bugs.webkit.org/show_bug.cgi?id=197294

Reviewed by Saam Barati.

This patch includes follow-up after r244481 and bug fixes which is introduced in the refactoring.

  • bmalloc/IsoAllocator.h: Remove unused function.
  • bmalloc/IsoAllocatorInlines.h:

(bmalloc::IsoAllocator<Config>::allocateSlow):

  • bmalloc/IsoDeallocatorInlines.h:

(bmalloc::IsoDeallocator<Config>::deallocate):

  • bmalloc/IsoHeapImpl.h: Rename m_usableBits to m_availableShared and add static_assert.
  • bmalloc/IsoHeapImplInlines.h: Do not clear m_numberOfAllocationsFromSharedInOneCycle etc. in scavenge since IsoHeapImpl::scavenge

is not related to thread-local IsoAllocator's status.
(bmalloc::IsoHeapImpl<Config>::scavenge):
(bmalloc::IsoHeapImpl<Config>::forEachLiveObject):
(bmalloc::IsoHeapImpl<Config>::updateAllocationMode): Update m_allocationMode correctly.
(bmalloc::IsoHeapImpl<Config>::allocateFromShared):

  • bmalloc/IsoSharedHeapInlines.h:

(bmalloc::computeObjectSizeForSharedCell):
(bmalloc::IsoSharedHeap::allocateNew):
(bmalloc::IsoSharedHeap::allocateSlow): Add computeObjectSizeForSharedCell.

  • bmalloc/IsoSharedPage.h:
  • bmalloc/IsoSharedPageInlines.h:

(bmalloc::IsoSharedPage::free): Pass const std::lock_guard<Mutex>& in its parameter.

2:42 PM Changeset in webkit [244665] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Disable ContentChangeObserver on iOSMac.
​https://bugs.webkit.org/show_bug.cgi?id=197292
rdar://problem/49039957

Reviewed by Zalan Bujtas.

We don’t need to run any of ContentChangeObserver, because we have hover events on iOSMac.
Disabling it skips the synthetic mouse move events and speeds up clicks.

  • page/SettingsBase.cpp:

(WebCore::SettingsBase::defaultContentChangeObserverEnabled): Return false for PLATFORM(IOSMAC).

2:38 PM Changeset in webkit [244664] by timothy@apple.com
  • 15 edits in trunk

Disable date and time inputs on iOSMac.
​https://bugs.webkit.org/show_bug.cgi?id=197287
rdar://problem/46794376

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • platform/text/mac/LocaleMac.h:
  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::formatDateTime):

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2:27 PM Changeset in webkit [244663] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Fix more Windows builds after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • svg/properties/SVGAnimatedPropertyList.h:
  • svg/properties/SVGProperty.h:
  • svg/properties/SVGPropertyList.h:
1:08 PM Changeset in webkit [244662] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix test-webkitpy after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • lldb/lldbWebKitTester/Configurations/Base.xcconfig:

Also use C++17.

12:43 PM Changeset in webkit [244661] by Shawn Roberts
  • 1 edit
    1 add in trunk/LayoutTests

fast/harness/render-tree-as-text-options.html Rebaselined test for windows
​https://bugs.webkit.org/show_bug.cgi?id=197290

Unreviewed test gardening.

  • platform/win/fast/render-tree-as-text-options-expected.txt: Added.
12:11 PM Changeset in webkit [244660] by achristensen@apple.com
  • 4 edits in trunk/Source

Fix more builds after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

Source/JavaScriptCore:

  • b3/B3Value.h:

There is an older system with libc++ headers that don't have std::conjunction. Just use constexpr and && instead for the one use of it in WebKit.

Source/WebCore:

  • svg/properties/SVGValuePropertyList.h:

Something is preventing MSVC from seeing protected constructors from subclasses.

12:04 PM Changeset in webkit [244659] by pvollan@apple.com
  • 10 edits in trunk

-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
​https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>

Reviewed by Alex Christensen.

Source/WebCore:

Add method to get all origins with persistent credentials from credential storage.

API tests: WKWebsiteDataStore.FetchNonPersistentCredentials

WKWebsiteDataStore.FetchPersistentCredentials

  • platform/network/CredentialStorage.h:
  • platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::originsWithPersistentCredentials):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(-[NavigationTestDelegate init]):
(-[NavigationTestDelegate waitForDidFinishNavigation]):
(-[NavigationTestDelegate webView:didFinishNavigation:]):
(-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TestWebKitAPI::TEST):
(TEST): Deleted.

11:59 AM Changeset in webkit [244658] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Add more tests for ios programmatic iframe scrolling with fixed/sticky layers
​https://bugs.webkit.org/show_bug.cgi?id=197280

This commit adds iOS tests for scrolling iframes containing fixed/sticky layers. They are
extracted from earlier experimental patches for iOS frame scrolling but failed with the
alternative patches initially landed in bug 193539 and follow-up bugs. They now pass again
on trunk, so we can finally import them.

Patch by Frederic Wang <​fwang@igalia.com> on 2019-04-25
Reviewed by Darin Adler.

  • fast/scrolling/ios/programmatic-scroll-iframe-010-expected.html: Added.
  • fast/scrolling/ios/programmatic-scroll-iframe-010.html: Added.
  • fast/scrolling/ios/programmatic-scroll-iframe-011-expected.html: Added.
  • fast/scrolling/ios/programmatic-scroll-iframe-011.html: Added.
  • fast/scrolling/ios/programmatic-scroll-iframe-012-expected.html: Added.
  • fast/scrolling/ios/programmatic-scroll-iframe-012.html: Added.
11:54 AM Changeset in webkit [244657] by Basuke Suzuki
  • 19 edits in trunk/Source/JavaScriptCore

[RemoteInspector] Fix connection and target identifier types.
​https://bugs.webkit.org/show_bug.cgi?id=197243

Reviewed by Ross Kirsling.

Give dedicated type for RemoteControllableTarget's identifier as Inspector::TargetID.

Also rename ClientID type used in Socket backend to ConnectionID because this is the identifier
socket endpoint assign to the newly created connection. The size was changed to uint32_t.
Enough size for managing connections.

  • inspector/remote/RemoteConnectionToTarget.cpp:

(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):
(Inspector::RemoteConnectionToTarget::targetIdentifier const):

  • inspector/remote/RemoteConnectionToTarget.h:
  • inspector/remote/RemoteControllableTarget.h:
  • inspector/remote/RemoteInspector.cpp:

(Inspector::RemoteInspector::nextAvailableTargetIdentifier):
(Inspector::RemoteInspector::registerTarget):
(Inspector::RemoteInspector::unregisterTarget):
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupCompleted):
(Inspector::RemoteInspector::waitingForAutomaticInspection):
(Inspector::RemoteInspector::updateTargetListing):

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

(Inspector::RemoteConnectionToTarget::targetIdentifier const):
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::close):

  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedCloseMessage):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):

  • inspector/remote/socket/RemoteInspectorConnectionClient.cpp:

(Inspector::RemoteInspectorConnectionClient::didReceiveWebInspectorEvent):

  • inspector/remote/socket/RemoteInspectorConnectionClient.h:

(Inspector::RemoteInspectorConnectionClient::didAccept):

  • inspector/remote/socket/RemoteInspectorMessageParser.cpp:

(Inspector::MessageParser::MessageParser):
(Inspector::MessageParser::parse):

  • inspector/remote/socket/RemoteInspectorMessageParser.h:

(Inspector::MessageParser::setDidParseMessageListener):

  • inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::didAccept):
(Inspector::RemoteInspectorServer::didClose):
(Inspector::RemoteInspectorServer::dispatchMap):
(Inspector::RemoteInspectorServer::sendWebInspectorEvent):
(Inspector::RemoteInspectorServer::sendCloseEvent):
(Inspector::RemoteInspectorServer::connectionClosed):

  • inspector/remote/socket/RemoteInspectorServer.h:
  • inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::didClose):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::setup):
(Inspector::RemoteInspector::sendMessageToTarget):

  • inspector/remote/socket/RemoteInspectorSocket.h:
  • inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:

(Inspector::RemoteInspectorSocketEndpoint::connectInet):
(Inspector::RemoteInspectorSocketEndpoint::isListening):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::send):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
11:49 AM Changeset in webkit [244656] by achristensen@apple.com
  • 4 edits in trunk/Source

Source/WebCore:
Fix MSVC build after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • svg/properties/SVGValueProperty.h:

MSVC doesn't think it can access these protected constructors from subclasses.
Make the build work and investigate this later.

Source/WTF:
Fix High Sierra build after r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • wtf/StdLibExtras.h:

High Sierra thinks cplusplus is 201406 even when using C++17.
Removing the cplusplus check resolves the build failure on High Sierra.
We can clean up StdLibExtras more later.

11:49 AM Changeset in webkit [244655] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
<rdar://problem/49755494> and ​https://bugs.webkit.org/show_bug.cgi?id=197284

Reviewed by Chris Dumez.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should

be eligible. Only if all pages are suspended should it be jetsam-able.

11:15 AM Changeset in webkit [244654] by achristensen@apple.com
  • 2 edits in trunk/Tools

Revert some code accidentally committed with r244653
​https://bugs.webkit.org/show_bug.cgi?id=197131

  • TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::TEST):

10:41 AM Changeset in webkit [244653] by achristensen@apple.com
  • 36 edits in trunk

Start using C++17
​https://bugs.webkit.org/show_bug.cgi?id=197131

.:

Reviewed by Darin Adler.

  • Source/cmake/OptionsMSVC.cmake:
  • Source/cmake/WebKitCompilerFlags.cmake:

Source/bmalloc:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/JavaScriptCore:

Reviewed by Darin Alder.

  • Configurations/Base.xcconfig:

Source/ThirdParty:

Reviewed by Darin Adler.

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/WebCore:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:
  • DerivedSources.make:

Source/WebCore/PAL:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/WebInspectorUI:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/WebKit:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:
  • DerivedSources.make:

Source/WebKitLegacy/mac:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:

Source/WTF:

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:
  • wtf/CMakeLists.txt:
  • wtf/Variant.h:

(WTF::switchOn):

Tools:

Reviewed by Darin Adler.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MobileMiniBrowser/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
10:36 AM Changeset in webkit [244652] by achristensen@apple.com
  • 7 edits
    1 add
    1 delete in trunk/Source

Remove DeprecatedOptional
​https://bugs.webkit.org/show_bug.cgi?id=197161

Reviewed by Darin Adler.

Source/JavaScriptCore:

We need to keep a symbol exported from JavaScriptCore for binary compatibility with iOS12.
We need this symbol to be in a file that doesn't include anything because libcxx's implementation of
std::optional is actually std::1::optional, which has a different mangled name. This change will
prevent protocol errors from being reported if you are running the iOS12 simulator with a custom build of WebKit
and using the web inspector with it, but it's necessary to allow us to start using C++17 in WebKit.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/InspectorBackendDispatcher.cpp:
  • inspector/InspectorBackendDispatcher.h:
  • inspector/InspectorBackendDispatcherCompatibility.cpp: Added.

(Inspector::BackendDispatcher::reportProtocolError):

  • inspector/InspectorBackendDispatcherCompatibility.h: Added.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/DeprecatedOptional.h: Removed.
10:24 AM Changeset in webkit [244651] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197286

Unreviewed test gardening

  • platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure
10:22 AM WebKitGTK/2.24.x edited by Michael Catanzaro
(diff)
10:21 AM WebKitGTK/2.24.x edited by Michael Catanzaro
(diff)
10:06 AM Changeset in webkit [244650] by Shawn Roberts
  • 3 edits in trunk/LayoutTests

http/wpt/resource-timing/rt-resources-per-frame.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197207

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure
9:59 AM Changeset in webkit [244649] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GTK] Back/Forward gesture interferes with scrolling
​https://bugs.webkit.org/show_bug.cgi?id=197168

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.

When the gesture is released with 0 velocity close to an edge of the webview,
the finishing animation is way too long, and in some cases it can look like the
gesture is already over, when it's still animating. By scrolling vertically while
that happens, it's possible to reset animation over and over again.

To reduce the duration in this case, instead of using maximum possible duration
(400ms), introduce a base velocity and use it for calculating the duration if
the actual velocity, relative to the end point, is equal to or less than 0.

  • UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::SwipeProgressTracker::startAnimation):

9:58 AM Changeset in webkit [244648] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

[GTK] Back/forward gesture snapshot always times out
​https://bugs.webkit.org/show_bug.cgi?id=197233

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2019-04-25
Reviewed by Michael Catanzaro.

Delaying web process launch caused a regression where we create ViewGestureController when the
web process doesn't yet exist. The controller immediately tries to connect to it and fails,
and because of that never receives DidHitRenderTreeSizeThreshold() message, so navigation
snapshot always stays until timeout after performing the gesture.

To prevent this, create the controller in webkitWebViewBaseDidRelaunchWebProcess() instead of
webkitWebViewBaseCreateWebPage(). Additionally, since settings are now created earlier than
ViewGestureController, store the value of whether swipe gesture is enabled in WebKitWebViewBase
and immediately apply it when creating the controller.

  • UIProcess/API/glib/WebKitWebView.cpp:

(enableBackForwardNavigationGesturesChanged):
Move the logic into webkitWebViewBaseSetEnableBackForwardNavigationGesture().

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetEnableBackForwardNavigationGesture): Added. In addition to what was in
WebKitWebViewBase::enableBackForwardNavigationGesturesChanged(), store the value in a field
for the case ViewGestureController doesn't exist yet.
(webkitWebViewBaseCreateWebPage): Stop creating ViewGestureController.
(webkitWebViewBaseDidRelaunchWebProcess): Move creating ViewGestureController here. Also
immediately call setSwipeGestureEnabled() with the stored value.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
9:48 AM Changeset in webkit [244647] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

http/tests/resourceLoadStatistics/prune-statistics.html is a flaky failure on Debug testers
​https://bugs.webkit.org/show_bug.cgi?id=197285#add_comment

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations for flaky failure
9:29 AM Changeset in webkit [244646] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

fast/css-custom-paint/animate-repaint.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197283

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations for flaky failure
8:50 AM Changeset in webkit [244645] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac iOS WK2] Layout Test http/wpt/cache-storage/cache-quota-after-restart.any.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197040
<rdar://problem/49997641>

Reviewed by Antti Koivisto.

Delay write operations in case synchronize is ongoing.
This is restricted to AvoidRandomness mode which is always used by CacheAPI
and is also used by network cache for layout tests.

Tested by cache-quota-after-restart.any.html no longer exhibiting write disk errors.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::synchronize):
(WebKit::NetworkCache::Storage::store):

8:43 AM Changeset in webkit [244644] by commit-queue@webkit.org
  • 47 edits
    3 deletes in trunk

Unreviewed, rolling out r244627.
​https://bugs.webkit.org/show_bug.cgi?id=197282

Causing internal build failures (Requested by ShawnRoberts on
#webkit).

Reverted changeset:

"Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
​https://bugs.webkit.org/show_bug.cgi?id=197171
​https://trac.webkit.org/changeset/244627

4:29 AM Changeset in webkit [244643] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

redefinition of enumerator 'NSAttachmentCharacter' with Apple internal build
​https://bugs.webkit.org/show_bug.cgi?id=197279

Reviewed by Antoine Quint.

Try to fix the build.

  • platform/mac/WebNSAttributedStringExtras.mm:
2:55 AM Changeset in webkit [244642] by Antti Koivisto
  • 8 edits
    2 adds in trunk

Visited link hash should be computed only once
​https://bugs.webkit.org/show_bug.cgi?id=197229
<rdar://problem/48438924>

Reviewed by Alex Christensen.

Source/WebCore:

Test: fast/history/visited-href-mutation.html

Visited link style is now based on the first target URL of the link element. Further href mutations don't affect styling.

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):

  • dom/VisitedLinkState.cpp:

(WebCore::linkAttribute):
(WebCore::linkHashForElement):

Visited link support is now limited to HTML and SVG <a> elements.

(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::parseAttribute):

  • html/HTMLAnchorElement.h:

(WebCore::HTMLAnchorElement::visitedLinkHash const):
(WebCore::HTMLAnchorElement::invalidateCachedVisitedLinkHash): Deleted.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::visitedLinkHash const):

  • svg/SVGAElement.h:

LayoutTests:

  • fast/history/visited-href-mutation-expected.html: Added.
  • fast/history/visited-href-mutation.html: Added.
12:53 AM WebKitGTK/2.24.x edited by Philippe Normand
(diff)
12:52 AM Changeset in webkit [244641] by Philippe Normand
  • 6 edits in trunk

[GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused
​https://bugs.webkit.org/show_bug.cgi?id=196691

Reviewed by Eric Carlson.

Source/WebCore:

For gif assets, fail media loading early and notify the
MediaPlayer by setting both network and ready states, so that the
MediaPlayer will try with with the next media engine or pass the
error to HTMLMediaElement if there are none.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

LayoutTests:

Unflag test no longer crashing.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/replaced/border-radius-clip-expected.txt:
12:48 AM WebKitGTK/2.24.x edited by Philippe Normand
(diff)
12:47 AM Changeset in webkit [244640] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[REGRESSION(r243197)][GStreamer] http/tests/media/clearkey/collect-webkit-media-session.html hits an ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=197230

Reviewed by Xabier Rodriguez-Calvar.

Perform the resource loader disposal and destruction from the main
thread. Also ensure there's no circular reference between the
CachedResourceStreamingClient and WebKitWebSrc when disposing of
the private WebKitWebSrc storage.

  • platform/graphics/gstreamer/MainThreadNotifier.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate::~_WebKitWebSrcPrivate):
(webkit_web_src_class_init):
(webKitWebSrcDispose):
(webKitWebSrcCloseSession):
(webKitWebSrcFinalize): Deleted.

Apr 24, 2019:

11:42 PM Changeset in webkit [244639] by bshafiei@apple.com
  • 6 edits
    2 adds in branches/safari-607.2.6.0-branch

Cherry-pick r244122. rdar://problem/50132675

Cherry-pick r243639. rdar://problem/49725710

BackwardsGraph needs to consider back edges as the backward's root successor
​https://bugs.webkit.org/show_bug.cgi?id=195991

Reviewed by Filip Pizlo.

JSTests:

  • stress/map-b3-licm-infinite-loop.js: Added.

Source/JavaScriptCore:

  • b3/testb3.cpp: (JSC::B3::testInfiniteLoopDoesntCauseBadHoisting): (JSC::B3::run):

Source/WTF:

Previously, our backwards graph analysis was slightly wrong. The idea of
backwards graph is that the root of the graph has edges to terminals in
the original graph. And then the original directed edges in the graph are flipped.

However, we weren't considering loops as a form of terminality. For example,
we wouldn't consider an infinite loop as a terminal. So there were no edges
from the root to a node in the infinite loop. This lead us to make mistakes
when we used backwards dominators to compute control flow equivalence.

This is better understood in an example:

`
preheader:
while (1) {

if (!isCell(v))

continue;

load structure ID
if (cond)

continue;

return

}
`

In the previous version of this algorithm, the only edge from the backwards
root would be to the block containing the return. This would lead us to
believe that the loading of the structureID backwards dominates the preheader,
leading us to believe it's control flow equivalent to preheader. This is
obviously wrong, since we can loop forever if "v" isn't a cell.

The solution here is to treat any backedge in the graph as a "terminal" node.
Since a backedge implies the existence of a loop.

In the above example, the backwards root now has an edge to both blocks with
"continue". This prevents us from falsely claiming that the return is control
flow equivalent with the preheader.

This patch uses DFS spanning trees to compute back edges. An edge
u->v is a back edge when u is a descendent of v in the DFS spanning
tree of the Graph.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/BackwardsGraph.h: (WTF::BackwardsGraph::BackwardsGraph):
  • wtf/SpanningTree.h: Added. (SpanningTree::SpanningTree): (SpanningTree::isDescendent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:42 PM Changeset in webkit [244638] by bshafiei@apple.com
  • 2 edits in branches/safari-607.2.6.0-branch/Source/WebCore

Cherry-pick r244120. rdar://problem/50132675

Cherry-pick r243104. rdar://problem/49725692

REGRESSION(r236862): early frame decoupling leaves JSC ArrayBuffer objects lingering
​https://bugs.webkit.org/show_bug.cgi?id=195322

Reviewed by Ryosuke Niwa.

Since r236862, DOMWindow objects get disconnected from their Frame object as soon as
their iframe element gets removed from the document. Previously, DOMWindow was a
FrameDestructionObserver and would stay connected to its frame until the frame died.

This means that some of the work that we were doing in DOMWindow::frameDestroyed() and
Document::willDetachPage() no longer happens for subframe windows because they get
disconnected from their frame because they get a chance to get such notifications.
To address this issue, we now also do this work in DOMWindow::willDetachDocumentFromFrame()
which gets called when the iframe gets removed from the document and the document / window
get disconnected from the Frame element.

No new tests, verified locally that the leak is gone on JetStream.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::willDetachDocumentFromFrame):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:42 PM Changeset in webkit [244637] by bshafiei@apple.com
  • 24 edits
    2 adds in branches/safari-607.2.6.0-branch

Cherry-pick r244174. rdar://problem/28160396

Cherry-pick r243841. rdar://problem/49725678

-apple-trailing-word is needed for browser detection
​https://bugs.webkit.org/show_bug.cgi?id=196575

Unreviewed.

PerformanceTests:

  • MotionMark/resources/debug-runner/motionmark.css: (#intro .start-benchmark p):

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This is an unreviewed partial revert of r243819. Turns out there are some websites
which use this property to do browser detection. So, we need to continue to parse
the property, but we don't need the property to do anything.

Test: fast/text/trailing-word-detection.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TrailingWord const):
  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::trailingWord const): (WebCore::RenderStyle::setTrailingWord): (WebCore::RenderStyle::initialTrailingWord):
  • rendering/style/RenderStyleConstants.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/text/trailing-word-detection-expected.txt: Added.
  • fast/text/trailing-word-detection.html: Added.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:42 PM Changeset in webkit [244636] by bshafiei@apple.com
  • 33 edits
    4 deletes in branches/safari-607.2.6.0-branch

Cherry-pick r244173. rdar://problem/28160396

Cherry-pick r243819. rdar://problem/49725678

Remove support for -apple-trailing-word
​https://bugs.webkit.org/show_bug.cgi?id=196525

Reviewed by Zalan Bujtas.

This CSS property is nonstandard and not used.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator TrailingWord const): Deleted.
  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): (WebCore::CSSParserFastPaths::isKeywordPropertyID):
  • rendering/SimpleLineLayout.cpp: (WebCore::SimpleLineLayout::canUseForStyle):
  • rendering/SimpleLineLayoutCoverage.cpp: (WebCore::SimpleLineLayout::printReason):
  • rendering/SimpleLineLayoutCoverage.h:
  • rendering/line/BreakingContext.h: (WebCore::BreakingContext::BreakingContext): (WebCore::BreakingContext::lineBreak): (WebCore::BreakingContext::clearLineBreakIfFitsOnLine): (WebCore::BreakingContext::commitLineBreakClear): (WebCore::BreakingContext::commitLineBreakAtCurrentWidth): (WebCore::BreakingContext::handleBR): (WebCore::BreakingContext::handleFloat): (WebCore::BreakingContext::handleText): (WebCore::BreakingContext::handleEndOfLine): (WebCore::BreakingContext::InlineIteratorHistory::InlineIteratorHistory): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::push): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::update): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::renderer const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::offset const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::atTextParagraphSeparator const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::previousInSameNode const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::get const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::current const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::historyLength const): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::moveTo): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::increment): Deleted. (WebCore::BreakingContext::InlineIteratorHistory::clear): Deleted. (WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord): Deleted.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::trailingWord const): Deleted. (WebCore::RenderStyle::setTrailingWord): Deleted. (WebCore::RenderStyle::initialTrailingWord): Deleted.
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const):
  • rendering/style/StyleRareInheritedData.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

  • UserInterface/Models/CSSKeywordCompletions.js:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/text/trailing-word-expected.html: Removed.
  • fast/text/trailing-word.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/fast/text/trailing-word-parse-expected.txt: Removed.
  • platform/mac/fast/text/trailing-word-parse.html: Removed.
  • platform/win/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@243819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:51 PM Changeset in webkit [244635] by Carlos Garcia Campos
  • 22 edits in trunk

[GTK] Hardcoded text color in input fields
​https://bugs.webkit.org/show_bug.cgi?id=126907

Reviewed by Michael Catanzaro.

.:

Set and expose to build HAVE_OS_DARK_MODE_SUPPORT=1.

  • Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Enable HAVE_OS_DARK_MODE_SUPPORT for GTK port to ensure that dark mode is used when Page::useDarkAppearance()
returns true. This patch reverts r232913, I'll reopen the bug, I think we need to find a better solution for
that.

  • CMakeLists.txt: Add HAVE_OS_DARK_MODE_SUPPORT to FEATURE_DEFINES_WITH_SPACE_SEPARATOR if enabled.
  • css/CSSDefaultStyleSheets.cpp: Ensure html{color:text} is used in simple style sheet when

HAVE_OS_DARK_MODE_SUPPORT is enabled.

  • page/FrameView.cpp:

(WebCore::FrameView::updateBackgroundRecursively): Use CSSValueWindowframe to get the frame view background
color when HAVE_OS_DARK_MODE_SUPPORT is enabled for non-mac ports.

  • platform/gtk/RenderThemeWidget.cpp:

(WebCore::RenderThemeWidget::getOrCreate): Create window widget.
(WebCore::RenderThemeWindow::RenderThemeWindow): Add window widget.

  • platform/gtk/RenderThemeWidget.h:
  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::disabledTextColor const): Always use the color from the theme for consistency with
other form controls.
(WebCore::RenderThemeGtk::systemColor const): Get the color from the theme for CSSValueText, CSSValueGraytext
and CSSValueWindowframe.

  • rendering/RenderThemeGtk.h:

Source/WebKit:

Implement PageClient::effectiveAppearanceIsDark() for GTK port.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::effectiveAppearanceIsDark const): Check if gtk-application-prefer-dark-theme setting is
enabled, or the theme name contains the -dark suffix or the GTK_THEME environment variable contains the :dark suffix.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(themeChanged): Notify the WebPageProxy that the theme has changed.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to notify::gtk-application-prefer-dark-theme and notify::gtk-theme-name.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::setUseDarkAppearance): Set gtk-application-prefer-dark-theme setting accordingly.

Source/WTF:

Define HAVE_OS_DARK_MODE_SUPPORT for GTK port.

  • wtf/Platform.h:

Tools:

Add dark-mode command line option to MiniBrowser.

  • MiniBrowser/gtk/main.c:

(main):

LayoutTests:

Remove expectations for tests that are passing again.

  • platform/gtk/TestExpectations:
10:09 PM Changeset in webkit [244634] by ysuzuki@apple.com
  • 2 edits in trunk/Source/bmalloc

Unreviewed, fix typo in r244481
​https://bugs.webkit.org/show_bug.cgi?id=196837

  • bmalloc/IsoHeapImplInlines.h:

(bmalloc::IsoHeapImpl<Config>::allocateFromShared):

7:17 PM Changeset in webkit [244633] by Alan Bujtas
  • 27 edits in trunk

Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
​https://bugs.webkit.org/show_bug.cgi?id=196948
<rdar://problem/49927131>

Reviewed by Tim Horton.

Source/WebCore:

Covered by existing tests.

  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::enableAutoSizeMode):

  • page/FrameView.h:

Source/WebKit:

Move intrinsicContentSizeDidChange out of DrawingArea. Intrinsic content size is a layout concept and
after r244291 there's no reason to have it in DrawingArea.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):
(WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeIntrinsicContentSize):
(WebKit::WebPageProxy::setViewLayoutSize):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange): Deleted.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::intrinsicContentSizeDidChange): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::intrinsicContentsSizeChanged const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateIntrinsicContentSizeIfNeeded):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeIfNeeded): Deleted.

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::intrinsicContentsSizeChanged const):

  • WebCoreSupport/WebChromeClient.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:

(TEST):
The expected order of incoming events is

  1. didInvalidateIntrinsicContentSize
  2. didFirstLayout

At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
(and remember, all we care about is ordering).

6:11 PM Changeset in webkit [244632] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Do not restart WebRTC stats timer if backend is stopped
​https://bugs.webkit.org/show_bug.cgi?id=197257
<rdar://problem/50095879>

Reviewed by Eric Carlson.

We used to stop and reschedule the stat gathering timer in case the
gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

5:49 PM Changeset in webkit [244631] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Flaky crash under WebCore::AXObjectCache::stopCachingComputedObjectAttributes()
​https://bugs.webkit.org/show_bug.cgi?id=187391
<rdar://problem/40681396

Check for null value returned by AccessibilityObject::axObjectCache.

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-04-24
Reviewed by Chris Fleizach.

No need for new test since existing tests caught this problem.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::firstChild const):
(WebCore::AccessibilityNodeObject::lastChild const):
(WebCore::AccessibilityNodeObject::previousSibling const):
(WebCore::AccessibilityNodeObject::nextSibling const):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::anchorElement const):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
(WebCore::AccessibilityNodeObject::textForLabelElement const):
(WebCore::AccessibilityNodeObject::titleElementText const):
(WebCore::AccessibilityNodeObject::alternativeText const):
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::helpText const):

5:46 PM Changeset in webkit [244630] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (r242132): Nested position:sticky elements move incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=197255
rdar://problem/50137744

Reviewed by Zalan Bujtas.
Source/WebCore:

Revert to the behavior of the code before r242132, where we looked at the direct parent
scrolling tree node instead of walking up the ancestor chain to find an enclosing scrolling node.
This fixes nested sticky behavior.

Test: scrollingcoordinator/mac/nested-sticky.html

  • page/scrolling/cocoa/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::applyLayerPositions):

LayoutTests:

  • scrollingcoordinator/mac/nested-sticky-expected.html: Added.
  • scrollingcoordinator/mac/nested-sticky.html: Added.
5:14 PM Changeset in webkit [244629] by aboya@igalia.com
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed GTK test gardening
​https://bugs.webkit.org/show_bug.cgi?id=197261

  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/inspector/network/har/har-page-expected.txt:
  • platform/gtk/imported/blink/media/track/media-element-move-to-new-document-assert-expected.txt: Removed.
5:03 PM Changeset in webkit [244628] by commit-queue@webkit.org
  • 28 edits in trunk

Unreviewed, rolling out r244228.
​https://bugs.webkit.org/show_bug.cgi?id=197262

Causes compat issues (Requested by smfr on #webkit).

Reverted changeset:

"Unreviewed test gardening for Windows."
​https://trac.webkit.org/changeset/244228

4:56 PM Changeset in webkit [244627] by eric.carlson@apple.com
  • 47 edits
    3 adds in trunk

Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::updateOptions):

  • platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:

(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):

  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::label const):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::devicePicker):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):

  • platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:

(WebCore::validateHEVCParameters):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):

  • platform/mac/SerializedPlatformRepresentationMac.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):

  • platform/mediastream/RealtimeVideoSource.h:
  • platform/mediastream/VideoPreset.h:
  • platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):

  • platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:

(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/cocoa/AVFoundationSoftLink.h: Added.
  • pal/cocoa/AVFoundationSoftLink.mm: Added.

Source/WebKit:

  • Shared/ios/WebIconUtilities.mm:

(WebKit::iconForVideoFile):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone const):

Source/WebKitLegacy/mac:

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.

(TestWebKitAPI::TEST):

4:23 PM Changeset in webkit [244626] by Kocsen Chung
  • 2 edits in branches/safari-607.2.6.0-branch/Source/WebCore

Revert r244120. rdar://problem/50132675

4:23 PM Changeset in webkit [244625] by Kocsen Chung
  • 6 edits
    2 deletes in branches/safari-607.2.6.0-branch

Revert r244122. rdar://problem/50132675

4:22 PM Changeset in webkit [244624] by Kocsen Chung
  • 33 edits
    4 adds in branches/safari-607.2.6.0-branch

Revert r244173. rdar://problem/28160396

4:22 PM Changeset in webkit [244623] by Kocsen Chung
  • 24 edits
    2 deletes in branches/safari-607.2.6.0-branch

Revert r244174. rdar://problem/28160396

4:14 PM Changeset in webkit [244622] by Kocsen Chung
  • 7 edits in branches/safari-607.2.6.0-branch/Source

Versioning.

4:05 PM Changeset in webkit [244621] by Kocsen Chung
  • 37 edits
    4 adds
    4 deletes in branches/safari-607-branch

Revert all the previous reverts to reset the safari-607-branch versioning.

3:42 PM Changeset in webkit [244620] by sbarati@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Add SPI callbacks for before and after module execution
​https://bugs.webkit.org/show_bug.cgi?id=197244
<rdar://problem/50180511>

Reviewed by Yusuke Suzuki.

This is helpful for clients that want to profile execution of modules
in some way. E.g, if they want to time module execution time.

  • API/JSAPIGlobalObject.h:
  • API/JSAPIGlobalObject.mm:

(JSC::JSAPIGlobalObject::moduleLoaderEvaluate):

  • API/JSContextPrivate.h:
  • API/tests/testapi.mm:

(+[JSContextFetchDelegate contextWithBlockForFetch:]):
(-[JSContextFetchDelegate willEvaluateModule:]):
(-[JSContextFetchDelegate didEvaluateModule:]):
(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testLoaderRejectsNilScriptURL):

  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::evaluate):
(JSC::JSModuleLoader::evaluateNonVirtual):

  • runtime/JSModuleLoader.h:
3:26 PM Changeset in webkit [244619] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS] Fix syscall sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=197247
<rdar://problem/50026580>

Reviewed by Brent Fulgham.

A missing syscall in the sandbox of the WebContent process is causing a crash.

  • WebProcess/com.apple.WebProcess.sb.in:
3:04 PM Changeset in webkit [244618] by Alan Coon
  • 28 edits in tags/Safari-608.1.18

Revert r244228. rdar://problem/50183163

3:03 PM Changeset in webkit [244617] by beidson@apple.com
  • 4 edits in trunk

XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
​https://bugs.webkit.org/show_bug.cgi?id=191362

Reviewed by Alex Christensen.

Source/WebCore:

Covered by new API tests.

In 2008 some refactoring added an HTTP(S)-only restriction to copying the form body for
XHRs that POST, and it added that restriction with no explanation.

We definitely want to allow that.

Blobs are broken at this time (covered by bug 197237)

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::sendBytesData):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things from an XHR to a custom protocol.
3:00 PM ad-click-attribution-draft-spec edited by wilander@apple.com
(diff)
2:41 PM Changeset in webkit [244616] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: don't start property selection when pressing right mouse button
​https://bugs.webkit.org/show_bug.cgi?id=197242
<rdar://problem/50180380>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):

2:30 PM Changeset in webkit [244615] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: importing a HAR with an active detail view shows no content
​https://bugs.webkit.org/show_bug.cgi?id=197223

Reviewed by Timothy Hatcher.

When hiding the detail view, we force a layout of the Network table, which causes the
cached row count to be set to 0, which prevents the reloadDataAddedToEndOnly from
rendering anything since the WI.Table thinks it has no rows.

Given that all of the users of WI.Table are backed by an array, we don't need to cache the
number of rows since .length is an extremely cheap operation. In turn, this guarantees
that we are always rendering with an accurate value.

  • UserInterface/Views/Table.js:

(WI.Table):
(WI.Table.prototype.get numberOfRows):
(WI.Table.prototype.reloadData):
(WI.Table.prototype._removeRows):

2:28 PM Changeset in webkit [244614] by wilander@apple.com
  • 23 edits
    2 adds in trunk

Age out unconverted Ad Click Attributions after one week.
​https://bugs.webkit.org/show_bug.cgi?id=197238
<rdar://problem/50177349>

Reviewed by Chris Dumez.

Source/WebCore:

This patch adds the two functions AdClickAttribution::markAsExpired()
and AdClickAttribution::hasExpired() which make use of the existing
m_timeOfAdClick member.

Test: http/tests/adClickAttribution/expired-attributions-removed.html

  • loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::markAsExpired):
(WebCore::AdClickAttribution::hasExpired const):

  • loader/AdClickAttribution.h:

Source/WebKit:

AdClickAttributionManager::storeUnconverted() and
AdClickAttributionManager::convert() now start by calling the new
AdClickAttributionManager::clearExpired() function to remove any
expired, unconverted attributions before continuing.

The rest of the patch is infrastructure to allow tests to expire
all unconverted attributions early.

  • NetworkProcess/AdClickAttributionManager.cpp:

(WebKit::AdClickAttributionManager::storeUnconverted):
(WebKit::AdClickAttributionManager::convert):
(WebKit::AdClickAttributionManager::clearExpired):
(WebKit::AdClickAttributionManager::markAllUnconvertedAsExpiredForTesting):

  • NetworkProcess/AdClickAttributionManager.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::markAdClickAttributionsAsExpiredForTesting):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::markAdClickAttributionsAsExpiredForTesting):

  • NetworkProcess/NetworkSession.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetAdClickAttributionConversionURLForTesting):
(WKPageMarkAdClickAttributionsAsExpiredForTesting):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::markAdClickAttributionsAsExpiredForTesting):

  • UIProcess/WebPageProxy.h:

Tools:

This patch adds infrastructure to allow tests to expire all unconverted
attributions early.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::markAdClickAttributionsAsExpiredForTesting):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/adClickAttribution/expired-attributions-removed-expected.txt: Added.
  • http/tests/adClickAttribution/expired-attributions-removed.html: Added.
2:27 PM Changeset in webkit [244613] by Chris Dumez
  • 2 edits in trunk/Tools

Fix flaky crashes in a couple of PSON API tests
​https://bugs.webkit.org/show_bug.cgi?id=197239

Reviewed by Tim Horton.

Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2:26 PM Changeset in webkit [244612] by Simon Fraser
  • 3 edits
    11 adds in trunk

REGRESSION (iOS 12.2): CSS perspective property value can only be set correctly once
​https://bugs.webkit.org/show_bug.cgi?id=197105
Source/WebCore:

rdar://problem/50068230

Reviewed by Zalan Bujtas.

Make sure we trigger a geometry update when style properties change that
result in a StyleDifference::RecompositeLayer, and which are updated on layers
via RenderLayerBacking::updateGeometry().

Tests: compositing/style-change/backface-visibility-change.html

compositing/style-change/perspective-change.html
compositing/style-change/perspective-origin-change.html
compositing/style-change/transform-origin-change.html
compositing/style-change/transform-style-change.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::recompositeChangeRequiresGeometryUpdate):
(WebCore::RenderLayerCompositor::layerStyleChanged):

LayoutTests:

Reviewed by Zalan Bujtas.

  • compositing/style-change/backface-visibility-change-expected.html: Added.
  • compositing/style-change/backface-visibility-change.html: Added.
  • compositing/style-change/perspective-change-expected.html: Added.
  • compositing/style-change/perspective-change.html: Added.
  • compositing/style-change/perspective-origin-change-expected.html: Added.
  • compositing/style-change/perspective-origin-change.html: Added.
  • compositing/style-change/transform-origin-change-expected.html: Added.
  • compositing/style-change/transform-origin-change.html: Added.
  • compositing/style-change/transform-style-change-expected.html: Added.
  • compositing/style-change/transform-style-change.html: Added.
1:47 PM Changeset in webkit [244611] by Alan Coon
  • 7 edits in tags/Safari-608.1.17.2/Source

Versioning.

1:33 PM Changeset in webkit [244610] by Alan Coon
  • 1 copy in tags/Safari-608.1.17.2

New tag.

1:32 PM Changeset in webkit [244609] by Alan Coon
  • 2 edits in branches/safari-607-branch/Source/WebCore

Revert r244120. rdar://problem/50132675

1:32 PM Changeset in webkit [244608] by Alan Coon
  • 6 edits
    2 deletes in branches/safari-607-branch

Revert r244122. rdar://problem/50132675

1:32 PM Changeset in webkit [244607] by Alan Coon
  • 33 edits
    4 adds in branches/safari-607-branch

Revert r244173. rdar://problem/28160396

1:32 PM Changeset in webkit [244606] by Alan Coon
  • 24 edits
    2 deletes in branches/safari-607-branch

Revert r244174. rdar://problem/28160396

1:21 PM Changeset in webkit [244605] by Alan Coon
  • 7 edits in branches/safari-607-branch/Source

Versioning.

12:27 PM Changeset in webkit [244604] by Kocsen Chung
  • 7 edits in tags/Safari-608.1.18/Source

Versioning.

12:23 PM Changeset in webkit [244603] by Kocsen Chung
  • 1 copy in tags/Safari-608.1.18

Tag Safari-608.1.18.

12:22 PM Changeset in webkit [244602] by Kocsen Chung
  • 7 edits in trunk/Source

Versioning.

12:10 PM Changeset in webkit [244601] by Wenson Hsieh
  • 3 edits in trunk/Source/WebKit

Plumb the navigation's request when determining recommended compatibility mode
​https://bugs.webkit.org/show_bug.cgi?id=197225
<rdar://problem/48389965>

Reviewed by Alex Christensen.

Adds a new argument to effectiveCompatibilityModeAfterAdjustingPolicies.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::effectiveCompatibilityModeAfterAdjustingPolicies):

  • UIProcess/WebPageProxy.h:
12:07 PM Changeset in webkit [244600] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Clean up WKActionSheetAssistant's use of LaunchServices
​https://bugs.webkit.org/show_bug.cgi?id=194645
<rdar://problem/47707952>

Reviewed by Andy Estes.

Source/WebCore/PAL:

  • pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

  • UIProcess/ios/WKActionSheetAssistant.mm:

(applicationHasAppLinkEntitlements):
(-[WKActionSheetAssistant _appendAppLinkOpenActionsForURL:actions:elementInfo:]):
(-[WKActionSheetAssistant _appendOpenActionsForURL:actions:elementInfo:]):
(appLinkForURL): Deleted.
Make this function much more early-returny and flat.
Adopt LS sync SPI instead of using a semaphore ourselves.
Adopt modern open SPI.

Source/WTF:

  • wtf/Platform.h:
11:25 AM Changeset in webkit [244599] by Simon Fraser
  • 29 edits
    4 adds in trunk

Make it possible to control the renderTreeAsText output by setting options on testRunner
​https://bugs.webkit.org/show_bug.cgi?id=197133

Reviewed by Sam Weinig.

Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
that make sense in testing (those that don't dump unstable data like addresses), and plumb
these flags through the various framework layers.

Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.

Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
and hand-code DumpRenderTree bindings.

Some cleanup of the TestRunners, using member initializers.

Source/WebCore:

Test: fast/harness/render-tree-as-text-options.html

  • rendering/RenderLayer.cpp:

(WebCore::showLayerTree):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeDebugInfo):
(WebCore::write):
(WebCore::writeLayer):
(WebCore::writeLayerRenderers):
(WebCore::writeLayers):
(WebCore::externalRepresentation):

  • rendering/RenderTreeAsText.h:

(WebCore::externalRepresentation):
(WebCore::write):
(WebCore::writeDebugInfo):
(): Deleted.

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writePositionAndStyle):
(WebCore::writeStandardPrefix):
(WebCore::writeChildren):
(WebCore::writeSVGResourceContainer):
(WebCore::writeSVGContainer):
(WebCore::write):
(WebCore::writeSVGText):
(WebCore::writeSVGInlineText):
(WebCore::writeSVGImage):
(WebCore::writeSVGGradientStop):
(WebCore::writeResources):

  • rendering/svg/SVGRenderTreeAsText.h:

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentation):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::toRenderAsTextFlags):
(WebKit::WebPage::renderTreeExternalRepresentation const):
(WebKit::WebPage::renderTreeExternalRepresentationForPrinting const):

  • WebProcess/WebPage/WebPage.h:

Source/WebKitLegacy/mac:

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm:

(-[WebFrame renderTreeAsExternalRepresentationForPrinting]):
(toRenderAsTextFlags):
(-[WebFrame renderTreeAsExternalRepresentationWithOptions:]):
(-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): Deleted.

Source/WebKitLegacy/win:

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:

(toRenderAsTextFlags):
(WebFrame::renderTreeAsExternalRepresentation):
(WebFrame::renderTreeAsExternalRepresentationForPrinting):

  • WebFrame.h:

Tools:

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::TestRunner):
(setRenderTreeDumpOptionsCallback):
(TestRunner::staticFunctions):
(TestRunner::setRenderTreeDumpOptions):

  • DumpRenderTree/TestRunner.h:

(TestRunner::renderTreeDumpOptions const):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::TestRunner):
(WTR::TestRunner::setRenderTreeDumpOptions):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::renderTreeDumpOptions const):

LayoutTests:

  • fast/harness/render-tree-as-text-options-expected.txt: Added.
  • fast/harness/render-tree-as-text-options.html: Added.
  • resources/testrunner-constants.js: Added.
11:00 AM Changeset in webkit [244598] by graouts@webkit.org
  • 4 edits
    1 move
    3 adds
    1 delete in trunk

[iOS] Calling preventDefault() when handling a pointerdown event should not prevent panning, zooming or click event dispatch
​https://bugs.webkit.org/show_bug.cgi?id=195839
<rdar://problem/48946154>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: pointerevents/ios/pointer-events-prevent-default-allows-click-event.html

pointerevents/ios/pointer-events-prevent-default-allows-scrolling.html

The Pointer Events specification defines that the default action of any and all pointer events MUST NOT
be a manipulation of the viewport (e.g. panning or zooming). In practice, this means that calling
preventDefault() while handling a Pointer Event has no effect on the inner workings of the user agent,
so we change the method signature of PointerCaptureController::dispatchEventForTouchAtIndex() to return
void since we don't need to know whether preventDefault() was called.

​https://www.w3.org/TR/pointerevents/#declaring-candidate-regions-for-default-touch-behaviors

  • page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::dispatchEventForTouchAtIndex):

  • page/PointerCaptureController.h:

LayoutTests:

Modify the existing test to check that we *have* scrolled after performing a swipe gesture and calling
preventDefault() while handling the pointerdown handling. We also add a new test that checks that the
click event is indeed dispatched when tapping on an element and calling preventDefault() while handling
the pointerdown event.

  • pointerevents/ios/pointer-events-prevent-default-allows-click-event-expected.txt: Added.
  • pointerevents/ios/pointer-events-prevent-default-allows-click-event.html: Added.
  • pointerevents/ios/pointer-events-prevent-default-allows-scrolling-expected.txt: Added.
  • pointerevents/ios/pointer-events-prevent-default-allows-scrolling.html: Renamed from LayoutTests/pointerevents/ios/pointer-events-prevent-default.html.
  • pointerevents/ios/pointer-events-prevent-default-expected.txt: Removed.
10:46 AM Changeset in webkit [244597] by achristensen@apple.com
  • 20 edits
    1 add in trunk

WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
​https://bugs.webkit.org/show_bug.cgi?id=197078
<rdar://problem/49564348>

Reviewed by Geoff Garen.

Source/WebKit:

r242735 was a fix for crashes when using mmap'd memory in apps with default FileProtection of NSFileProtectionComplete.
It is more memory efficient and just as secure to reduce the FileProtection of these files to NSFileProtectionCompleteUnlessOpen.

  • NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::makeSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::pathRegisteredAsUnsafeToMemoryMapForTesting): Deleted.
(WebKit::NetworkCache::registerPathAsUnsafeToMemoryMapForTesting): Deleted.

  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheFileSystemCocoa.mm: Added.

(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::makeSafeToUseMemoryMapForPath):

  • Shared/WebCompiledContentRuleList.cpp:

(WebKit::WebCompiledContentRuleList::conditionsApplyOnlyToDomain const):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecode const):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecode const):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecode const):
(WebKit::WebCompiledContentRuleList::actions const):
(WebKit::WebCompiledContentRuleList::usesCopiedMemory const): Deleted.

  • Shared/WebCompiledContentRuleList.h:
  • Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):
(WebKit::WebCompiledContentRuleListData::size const): Deleted.
(WebKit::WebCompiledContentRuleListData::dataPointer const): Deleted.

  • Shared/WebCompiledContentRuleListData.h:

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):

  • SourcesCocoa.txt:
  • UIProcess/API/APIContentRuleList.cpp:

(API::ContentRuleList::usesCopiedMemory const): Deleted.

  • UIProcess/API/APIContentRuleList.h:
  • UIProcess/API/APIContentRuleListStore.cpp:

(API::openAndMapOrCopyContentRuleList):
(API::compiledToFile):
(API::createExtension):
(API::ContentRuleListStore::getContentRuleListSource):
(API::ContentRuleListStore::readContentsOfFile): Deleted.
(API::MappedOrCopiedData::dataPointer const): Deleted.

  • UIProcess/API/APIContentRuleListStore.h:
  • UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:

(API::ContentRuleListStore::readContentsOfFile): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListStore.mm:

(+[WKContentRuleListStore _registerPathAsUnsafeToMemoryMapForTesting:]): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListStorePrivate.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.mm:

(-[_WKUserContentFilter usesCopiedMemory]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentFilterPrivate.h:
  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:

(TEST_F):
(-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
(-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.

10:23 AM Changeset in webkit [244596] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit

Fix build due to missing SPI declaration of kAXSFullKeyboardAccessEnabledNotification

  • UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm: Import

AccessibilitySupportSPI.h.

10:19 AM Changeset in webkit [244595] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

With async scrolling enabled, this MathML test asserts
​https://bugs.webkit.org/show_bug.cgi?id=196123

Source/WebCore:

This patch ensures that updateScrollInfoAfterLayout() is called during MathML layout. This
fixes assertions when async scrolling is enabled and MathML elements have non-visible overflow.

Patch by Frederic Wang <​fwang@igalia.com> on 2019-04-24
Reviewed by Rob Buis.

Test: mathml/mathml-overflow-crash.html

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::layoutBlock):
(WebCore::RenderMathMLBlock::layoutInvalidMarkup):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::layoutBlock):

  • rendering/mathml/RenderMathMLMath.cpp:

(WebCore::RenderMathMLMath::layoutBlock):

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::layoutBlock):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::layoutBlock):

  • rendering/mathml/RenderMathMLPadded.cpp:

(WebCore::RenderMathMLPadded::layoutBlock):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layoutBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layoutBlock):

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::layoutBlock):

  • rendering/mathml/RenderMathMLSpace.cpp:

(WebCore::RenderMathMLSpace::layoutBlock):

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::layoutBlock):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layoutBlock):

LayoutTests:

Patch by Frederic Wang <​fwang@igalia.com> on 2019-04-24
Reviewed by Rob Buis.

Add a test for each MathML layoutBlock functions/classes.

  • mathml/mathml-overflow-crash-expected.txt: Added.
  • mathml/mathml-overflow-crash.html: Added.
10:14 AM Changeset in webkit [244594] by achristensen@apple.com
  • 8 edits
    1 add in trunk/Tools

Add unit test for r239322
​https://bugs.webkit.org/show_bug.cgi?id=197236

Reviewed by Chris Dumez.

I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
May as well add the test infrastructure which was needed before and will be needed in the future.

  • TestWebKitAPI/TCPServer.cpp:

(TestWebKitAPI::TCPServer::TCPServer):

  • TestWebKitAPI/TCPServer.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TestWebKitAPI::downloadAtRate):

  • TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.

(-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:

(TEST):

9:21 AM Changeset in webkit [244593] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac Debug] Layout Test resize-observer/observe-element-from-other-frame.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197063

Patch by Cathie Chen <cathiechen> on 2019-04-24
Reviewed by Ryosuke Niwa.

RenderingUpdate timer might be fired after ResizeTestHelper's. This would produce a flaky failure.
In order to reduce this failure, extend ResizeTestHelper.TIMEOUT like in bug 177484.

  • resize-observer/resources/resizeTestHelper.js:
8:52 AM Changeset in webkit [244592] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Rebaseline js/dom/dom-static-property-for-in-iteration.html after r244581
​https://bugs.webkit.org/show_bug.cgi?id=197218

Unreviewed test gardening.

  • platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
8:51 AM Changeset in webkit [244591] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix -Wc++11-narrowing on unsigned char platforms like FreeBSD/aarch64
​https://bugs.webkit.org/show_bug.cgi?id=197148

Patch by Greg V <​greg@unrelenting.technology> on 2019-04-24
Reviewed by Alex Christensen.

  • contentextensions/DFACombiner.cpp:
  • contentextensions/NFAToDFA.cpp:
8:44 AM Changeset in webkit [244590] by Chris Dumez
  • 10 edits in trunk

URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
​https://bugs.webkit.org/show_bug.cgi?id=197214
<rdar://problem/49237544>

Reviewed by Alex Christensen.

Source/WebKit:

URL set by document.open() is communicated with the WebPageProxy (since r244361) but not the
WebFrameProxy. This patch fixes this.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mainFrameURL]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/FrameLoadState.cpp:

(WebKit::FrameLoadState::didExplicitOpen):

  • UIProcess/FrameLoadState.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didExplicitOpen):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didExplicitOpenForFrame):

Tools:

Extend API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(TEST):

8:43 AM Changeset in webkit [244589] by Chris Dumez
  • 8 edits
    3 adds in trunk

X-Frame-Options header should be ignored when frame-ancestors CSP directive is present
​https://bugs.webkit.org/show_bug.cgi?id=197226
<rdar://problem/50155649>

Reviewed by Alex Christensen.

Source/WebCore:

X-Frame-Options header should be ignored when frame-ancestors CSP directive is present:

Specification says:
"""
In order to allow backwards-compatible deployment, the frame-ancestors directive _obsoletes_ the
X-Frame-Options header. If a resource is delivered with an policy that includes a directive named
frame-ancestors and whose disposition is "enforce", then the X-Frame-Options header MUST be ignored.
"""

Gecko and Blink follow the specification, WebKit does not. As a result, page [1] is broken with
WebKit-only on Schwab.com. The page height is wrong and you cannot see all the ETFs as a result.

[1] ​https://www.schwab.com/public/schwab/investing/investment_help/investment_research/etf_research/etfs.html?&path=/Prospect/Research/etfs/overview/oneSourceETFs.asp

Test: http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::overridesXFrameOptions const):

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyDirectiveList.h:

(WebCore::ContentSecurityPolicyDirectiveList::hasFrameAncestorsDirective const):

Source/WebKit:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions):

LayoutTests:

Add layout test coverage.

  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-X-Frames-Options.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/frame-ancestors-self-x-frame-options-deny.pl: Added.
8:38 AM Changeset in webkit [244588] by Alan Bujtas
  • 7 edits
    1 delete in trunk/Source/WebCore

[ContentChangeObserver] Do not use the global _WKContentChange in WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=196286
<rdar://problem/49364417>

Reviewed by Simon Fraser.

By reporting WKContentIndeterminateChange in sendMouseMoveEvent enables us to remove the global _WKContentChange state.
Using _WKContentChange is fine as long as only the observed frame reports content change during the synthetic click event.
In case of multiple frames, we should really consult the local state instead.
Unfortunately sendMouseMoveEvent has no access to the observed Document object so we can't really identify the observed content change.
WKContentIndeterminateChange triggers asynchronous decision making at the callsite and in the callback we have access
to the active Document/ContentChangeObverver object and can report the correct state.
This is inline with current WebKit(WK2) behaviour.

Manually tested with a WebKitLegacy test app.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ios/ContentChangeObserver.h:

(WebCore::ContentChangeObserver::setHasNoChangeState):
(WebCore::ContentChangeObserver::setHasIndeterminateState):
(WebCore::ContentChangeObserver::setHasVisibleChangeState):
(WebCore::ContentChangeObserver::setObservedContentState): Deleted.

  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::mouseMoved):

  • platform/ios/wak/WAKWindow.mm:

(-[WAKWindow sendMouseMoveEvent:contentChange:]):

  • platform/ios/wak/WKContentObservation.cpp: Removed.
  • platform/ios/wak/WKContentObservation.h:
7:48 AM WebKitGTK/2.24.x edited by Philippe Normand
(diff)
7:47 AM Changeset in webkit [244587] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLayerProxy
​https://bugs.webkit.org/show_bug.cgi?id=196739

Reviewed by Xabier Rodriguez-Calvar.

The crash was triggered because m_videoDecoderPlatform not being
explicitely set, its value would be inferred as one of the enum
class values. Making it Optional avoids this issue.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
5:23 AM Changeset in webkit [244586] by dino@apple.com
  • 3 edits in trunk/Source/WebKit

Rename _highlightLongPressCanClick and only add gesture recognizer when necessary
​https://bugs.webkit.org/show_bug.cgi?id=197231
<rdar://problem/50164234>

Reviewed by Antoine Quint.

Rename _highlightLongPressCanClick to _longPressCanClick since it will be
used in other places.

Only attach the _highlightLongPressGestureRecognizer when we're not
using long presses for preview. This might revert in the future, if we
can set up an appropriate gesture resolution between the two.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _webTouchEvent:preventsNativeGestures:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemControllerDidCancelPreview:]):

5:18 AM Changeset in webkit [244585] by Philippe Normand
  • 7 edits
    1 add
    21 deletes in trunk/Tools

[Build][GStreamer] Update to 1.16.0
​https://bugs.webkit.org/show_bug.cgi?id=197157

Reviewed by Xabier Rodriguez-Calvar.

The upstreamed patches were removed and a new one was added for a
regression detected in the scaletempo GStreamer element. The GNOME
Flatpak was migrated to 3.32 and I switched a few modules to Meson
on the way, as it is the preferred build system now in GStreamer
1.16.

  • flatpak/files/httpd-autogen.sh:
  • flatpak/flatpakutils.py:

(FlatpakPackage.install):
(WebkitFlatpak.run_in_sandbox):

  • flatpak/org.webkit.CommonModules.yaml:
  • flatpak/org.webkit.WebKit.yaml:
  • gstreamer/jhbuild.modules:
  • gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
  • gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
  • gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
  • gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
  • gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
  • gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
  • gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
  • gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
  • gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
  • gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
5:14 AM WebKitGTK/2.24.x edited by Philippe Normand
(diff)
5:11 AM Changeset in webkit [244584] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
​https://bugs.webkit.org/show_bug.cgi?id=196913

Reviewed by Xabier Rodriguez-Calvar.

The crash was due to a playbin3 code path being triggered during
MSE playback, which is not supposed to work in playbin3 anyway.
The problem is that setting the USE_PLAYBIN3 environment variable
to "1" makes the GStreamer playback plugin register the playbin3
element under the playbin name. So that leads to playbin3 being
used everywhere in WebKit where we assume the playbin element is
used. So the proposed solution is to:

  • use a WebKit-specific environment variable instead of the

GStreamer USE_PLAYBIN3 variable.

  • emit a warning if the USE_PLAYBIN3 environment variable is

detected. We can't unset it ourselves for security reasons.

The patch also includes a code cleanup of the player method
handling the pipeline creation. The previous code had a bug
leading to playbin3 being used for MSE.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

12:53 AM Changeset in webkit [244583] by Carlos Garcia Campos
  • 5 edits in trunk/Tools

[GTK] MiniBrowser: also set the passed bg-color when receiving arguments
​https://bugs.webkit.org/show_bug.cgi?id=197156

Reviewed by Michael Catanzaro.

The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
support was added.

  • MiniBrowser/gtk/BrowserTab.c:

(browser_tab_set_background_color): Set the passed in color as web view background color.

  • MiniBrowser/gtk/BrowserTab.h:
  • MiniBrowser/gtk/BrowserWindow.c:

(browser_window_init): Initialize backgroundColor.
(browser_window_append_view): Call browser_tab_set_background_color().
(browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
are added.

  • MiniBrowser/gtk/main.c:

(main): Call browser_window_set_background_color() before creating the tabs.

12:46 AM Changeset in webkit [244582] by Chris Fleizach
  • 47 edits
    13 deletes in trunk

AX: Remove deprecated Accessibility Object Model events
​https://bugs.webkit.org/show_bug.cgi?id=197073
<rdar://problem/50027819>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/mac/replace-text-with-range.html

  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::setSelected):

  • accessibility/AccessibilityMediaObject.cpp:

(WebCore::AccessibilityMediaObject::increment):
(WebCore::AccessibilityMediaObject::decrement):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::setSelected):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::replaceTextInRange):
(WebCore::AccessibilityObject::scrollToMakeVisible const):
(WebCore::AccessibilityObject::shouldDispatchAccessibilityEvent const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibilityEvent const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibilityEventWithType const): Deleted.
(WebCore::AccessibilityObject::dispatchAccessibleSetValueEvent const): Deleted.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setValue):

  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::setValue):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):
(WebCore::AccessibilityObject::hasAccessibleDismissEventListener const): Deleted.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityPerformEscape]): Deleted.
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):

  • dom/Element.idl:
  • dom/EventNames.h:
  • dom/EventNames.in:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap):

  • page/Settings.yaml:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAccessibilityEventsEnabled): Deleted.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit:

  • Platform/spi/ios/AccessibilitySupportSPI.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView dealloc]):
(accessibilityEventsEnabledChangedCallback): Deleted.
(-[WKWebView _updateAccessibilityEventsEnabled]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/WKFullKeyboardAccessWatcher.mm:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateAccessibilityEventsEnabled): Deleted.

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateAccessibilityEventsEnabled): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • accessibility/mac/AOM-event-accessiblesetvalue-expected.txt: Removed.
  • accessibility/mac/AOM-event-accessiblesetvalue.html: Removed.
  • accessibility/mac/AOM-events-all-expected.txt: Removed.
  • accessibility/mac/AOM-events-all.html: Removed.
  • accessibility/mac/AOM-events-expected.txt: Removed.
  • accessibility/mac/AOM-events-webarea-crash-expected.txt: Removed.
  • accessibility/mac/AOM-events-webarea-crash.html: Removed.
  • accessibility/mac/AOM-events.html: Removed.
  • accessibility/mac/replace-text-with-range-expected.txt: Replaced.
  • accessibility/mac/replace-text-with-range.html: Replaced.

Apr 23, 2019:

9:16 PM Changeset in webkit [244581] by wilander@apple.com
  • 16 edits in trunk

Move Ad Click Attribution from internal feature to experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=197218
<rdar://problem/47651691>

Reviewed by Brent Fulgham.

Source/WebKit:

  • Shared/WebPreferences.yaml:

Tools:

  • DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

LayoutTests:

This patch removes the TestRunner instruction for turning on the internal
feature.

  • http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
  • http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
  • http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
  • http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
  • http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
  • http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
  • http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
  • http/tests/adClickAttribution/send-attribution-conversion-request.html:
  • http/tests/adClickAttribution/store-ad-click-attribution.html:
  • http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
  • http/tests/contentextensions/block-ad-click-attribution.html:
9:06 PM Changeset in webkit [244580] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Shrink DFG::MinifiedNode
​https://bugs.webkit.org/show_bug.cgi?id=197224

Reviewed by Filip Pizlo.

Since it is kept alive with compiled DFG code, we should shrink it to save memory.
If it is effective, we should consider minimizing these OSR exit data more aggressively.

  • dfg/DFGMinifiedNode.h:
7:14 PM Changeset in webkit [244579] by sbarati@apple.com
  • 3 edits
    1 add in trunk

LICM incorrectly assumes it'll never insert a node which provably OSR exits
​https://bugs.webkit.org/show_bug.cgi?id=196721
<rdar://problem/49556479>

Reviewed by Filip Pizlo.

JSTests:

  • stress/licm-should-handle-if-a-hoist-causes-a-provable-osr-exit.js: Added.

(foo):

Source/JavaScriptCore:

Previously, we assumed LICM could never hoist code that caused us
to provably OSR exit. This is a bad assumption, as we may very well
hoist such code. Obviously hoisting such code is not ideal. We shouldn't
hoist something we provably know will OSR exit. However, this is super rare,
and the phase is written in such a way where it's easier to gracefully
handle this case than to prevent us from hoisting such code.

If we wanted to ensure we never hoisted code that would provably exit, we'd
have to teach the phase to know when it inserted code that provably exits. I
saw two ways to do that:
1: Save and restore the AI state before actually hoisting.
2: Write an analysis that can determine if such a node would exit.

(1) is bad because it costs in memory and compile time. (2) will inevitably
have bugs as running into this condition is rare.

So instead of (1) or (2), I opted to have LICM gracefully handle when
it causes a provable exit. When we encounter this, we mark all blocks
in the loop as !cfaHasVisited and !cfaDidFinish.

  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::attemptHoist):

6:50 PM Changeset in webkit [244578] by ysuzuki@apple.com
  • 9 edits
    1 copy in trunk/Source/JavaScriptCore

[JSC] Use node index as DFG::MinifiedID
​https://bugs.webkit.org/show_bug.cgi?id=197186

Reviewed by Saam Barati.

DFG Nodes can be identified with index if the graph is given. We should use unsigned index as a DFG::MinifiedID's underlying
source instead of Node* to reduce the size of VariableEvent from 16 to 12. Vector<VariableEvent> is the main data in DFG's OSR
tracking. It is kept after DFG compilation is done to make OSR work. We saw that this is allocated with large size in GMail.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/DataFormat.h:
  • bytecode/ValueRecovery.h:
  • dfg/DFGGenerationInfo.h:
  • dfg/DFGMinifiedID.h:

(JSC::DFG::MinifiedID::MinifiedID):
(JSC::DFG::MinifiedID::operator! const):
(JSC::DFG::MinifiedID::operator== const):
(JSC::DFG::MinifiedID::operator!= const):
(JSC::DFG::MinifiedID::operator< const):
(JSC::DFG::MinifiedID::operator> const):
(JSC::DFG::MinifiedID::operator<= const):
(JSC::DFG::MinifiedID::operator>= const):
(JSC::DFG::MinifiedID::hash const):
(JSC::DFG::MinifiedID::dump const):
(JSC::DFG::MinifiedID::isHashTableDeletedValue const):
(JSC::DFG::MinifiedID::fromBits):
(JSC::DFG::MinifiedID::bits const):
(JSC::DFG::MinifiedID::invalidIndex):
(JSC::DFG::MinifiedID::otherInvalidIndex):
(JSC::DFG::MinifiedID::node const): Deleted.
(JSC::DFG::MinifiedID::invalidID): Deleted.
(JSC::DFG::MinifiedID::otherInvalidID): Deleted.

  • dfg/DFGMinifiedIDInlines.h: Copied from Source/JavaScriptCore/dfg/DFGMinifiedNode.cpp.

(JSC::DFG::MinifiedID::MinifiedID):

  • dfg/DFGMinifiedNode.cpp:
  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::ValueSource):

  • dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::dataFormat const):

6:28 PM Changeset in webkit [244577] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes
​https://bugs.webkit.org/show_bug.cgi?id=197220
<rdar://problem/49960464>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype._addCollection):
(WI.NetworkTableContentView.prototype._resetCollection): Added.
(WI.NetworkTableContentView.prototype._changeCollection):
(WI.NetworkTableContentView.prototype._mainResourceDidChange):
We want to add the frame's main resource in the case that it's the main frame, but we also
want to clear the main collection of data (e.g. if viewing an imported HAR).
Drive-by: _groupByDOMNodeNavigationItem was renamed in a previous patch.

6:20 PM Changeset in webkit [244576] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: support drag/drop for importing
​https://bugs.webkit.org/show_bug.cgi?id=197221

Reviewed by Timothy Hatcher.

  • UserInterface/Views/NetworkTabContentView.js:

(WI.NetworkTabContentView.prototype.async.handleFileDrop): Added.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.processHAR): Added.
(WI.NetworkTableContentView.prototype._importHAR):

  • UserInterface/Base/FileUtilities.js:

(WI.FileUtilities.async readText):
Only await if the result is a Promise.

5:52 PM Changeset in webkit [244575] by Keith Rollin
  • 6 edits in trunk/Source

Add Xcode version check for Header post-processing scripts
​https://bugs.webkit.org/show_bug.cgi?id=197116
<rdar://problem/50058968>

Reviewed by Brent Fulgham.

There are several places in our Xcode projects that post-process
header files after they've been exported. Because of XCBuild, we're
moving to a model where the post-processing is performed at the same
time the header files are exported, rather than as a distinct
post-processing step. This patch disables the distinct step when the
inline processing is available.

In practice, this means prefixing appropriate post-processing Custom
Build phases with:

if [ "${XCODE_VERSION_MAJOR}" -ge "1100" -a "${USE_NEW_BUILD_SYSTEM}" = "YES" ]; then

# In this configuration, post-processing is performed at the same time as copying in the postprocess-header-rule script, so there's no need for this separate step.
exit 0

fi

Source/JavaScriptCore:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:
5:29 PM Changeset in webkit [244574] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source

Unreviewed, rolling out r244558.
​https://bugs.webkit.org/show_bug.cgi?id=197219

Causing crashes on iOS Sim Release and Debug (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Remove DeprecatedOptional"
​https://bugs.webkit.org/show_bug.cgi?id=197161
​https://trac.webkit.org/changeset/244558

5:24 PM Changeset in webkit [244573] by aestes@apple.com
  • 6 edits in trunk

[iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
​https://bugs.webkit.org/show_bug.cgi?id=196749
<rdar://problem/35773454>

Reviewed by Daniel Bates.

Source/WebCore:

QuickLook previews are in a non-local origin defined by a unique x-apple-ql-id: URL, which
isolates the origin that hosted the document from the document preview itself. When a
QuickLook document is loaded as a file: URL, SecurityOrigin's protections against loading
local resources from non-local origins prevented navigations like location.reload() and
fragment navigations.

To allow reloads and same-document navigations in QuickLook documents loaded from file: URLs,
we should grant the QuickLook document's SecurityOrigin access to the file path that loaded
the preview.

Added a new API test.

  • dom/Document.cpp:

(WebCore::Document::applyQuickLookSandbox):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createNonLocalWithAllowedFilePath):
(WebCore::SecurityOrigin::canDisplay const):

  • page/SecurityOrigin.h:

Tools:

Added a new QuickLook API test and added new expectations to existing QuickLook tests.

  • TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:

(-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
(-[QuickLookDelegate webView:didFinishNavigation:]):
(-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
(-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
(runTest):
(runTestDecideBeforeLoading):
(runTestDecideAfterLoading):
(TEST):

5:13 PM Changeset in webkit [244572] by wilander@apple.com
  • 22 edits
    2 adds in trunk

Remove Ad Click Attribution data when removing website data
​https://bugs.webkit.org/show_bug.cgi?id=197215
<rdar://problem/47668988>

Reviewed by Chris Dumez.

Source/WebKit:

This patch adds a new WebsiteDataType called AdClickAttributions and flags
it as owned by the network process.

The new website data type is added to the Cocoa API layer for
website data records management.

When either of the two WebsiteDataStore::removeData() functions calls
NetworkProcess::deleteWebsiteData() or
NetworkProcess::deleteWebsiteDataForOrigins() over IPC, the network
process now calls into AdClickAttributionManager::clear() and
AdClickAttributionManager::clearForRegistrableDomain() respectively,
if the website datatypes include WebsiteDataType::AdClickAttributions.

The patch removes a couple of completion handlers in NetworkSession function
calls are because those are not asynchronous.

  • NetworkProcess/AdClickAttributionManager.cpp:

(WebKit::AdClickAttributionManager::clear):
(WebKit::AdClickAttributionManager::clearForRegistrableDomain):
(WebKit::AdClickAttributionManager::toString const):

  • NetworkProcess/AdClickAttributionManager.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::clearAdClickAttribution):

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::clearAdClickAttribution):
(WebKit::NetworkSession::clearAdClickAttributionForRegistrableDomain):

  • NetworkProcess/NetworkSession.h:
  • Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::ownerProcess):

  • Shared/WebsiteData/WebsiteDataType.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreClearAdClickAttributionsThroughWebsiteDataRemoval):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

  • UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):

  • UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]):

Tools:

This patch adds test infrastructure to delete Ad Click Attribution data
through WebsiteDataStore::removeData().

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearAdClickAttribution):
(WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/adClickAttribution/clear-through-website-data-removal-expected.txt: Added.
  • http/tests/adClickAttribution/clear-through-website-data-removal.html: Added.
4:52 PM Changeset in webkit [244571] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: Kill unresponsive worker processes
​https://bugs.webkit.org/show_bug.cgi?id=197205
<rdar://problem/50104388>

Reviewed by Lucas Forschler.

  • Scripts/webkitpy/common/message_pool.py:

(_MessagePool.init): Add close timeout.
(_MessagePool._close): Send termination before joining workers, kill unresponsive workers.

4:46 PM Changeset in webkit [244570] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit

Return annotated text checking strings via UIWKDocumentContext
​https://bugs.webkit.org/show_bug.cgi?id=197177
<rdar://problem/49064839>

Reviewed by Ryosuke Niwa.

  • WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h:
  • WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDocumentEditingContext):
Respect the UIWKDocumentRequestAnnotation flag, returning an attributed
string containing the platform text checking annotations.

3:30 PM Changeset in webkit [244569] by Devin Rousso
  • 3 edits in trunk/Source/WebCore

Web Inspector: Debugger: remove ASSERT_NOT_REACHED where it's possible to reach
​https://bugs.webkit.org/show_bug.cgi?id=197210
<rdar://problem/48462912>

Reviewed by Joseph Pecoraro.

  • inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didAddEventListener):
(WebCore::PageDebuggerAgent::didPostMessage):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleAgentEnabled):
(WebCore::InspectorInstrumentation::timelineAgentEnabled):
Drive-by: add additional FAST_RETURN_IF_NO_FRONTENDS.

2:46 PM Changeset in webkit [244568] by achristensen@apple.com
  • 10 edits in trunk

Add unit tests for WKWebView.serverTrust
​https://bugs.webkit.org/show_bug.cgi?id=197202

Source/ThirdParty/libwebrtc:

Reviewed by Youenn Fablet.

  • libwebrtc.xcodeproj/project.pbxproj:

Move boringssl files from libwebrtc target to boringssl target.
Also, add pkcs7 files to boringssl static library.

Tools:

Reviewed by Youenn Fablet

  • TestWebKitAPI/TCPServer.cpp:

(TestWebKitAPI::deleter<BIO>::operator()):
(TestWebKitAPI::deleter<SSL>::operator()):
(TestWebKitAPI::deleter<X509>::operator()):
(TestWebKitAPI::deleter<SSL_CTX>::operator()):
(TestWebKitAPI::deleter<EVP_PKEY>::operator()):
(TestWebKitAPI::TCPServer::TCPServer):
(TestWebKitAPI::TCPServer::listenForConnections):

  • TestWebKitAPI/TCPServer.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TestWebKitAPI::TEST):
(verifyCertificateAndPublicKey):
(-[ServerTrustDelegate webView:didFinishNavigation:]):
(-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TestWebKitAPI::downloadAtRate):

  • TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:

(TEST):

2:38 PM Changeset in webkit [244567] by commit-queue@webkit.org
  • 47 edits
    3 deletes in trunk

Unreviewed, rolling out r244556.
​https://bugs.webkit.org/show_bug.cgi?id=197212

Causing build failures on multiple builders (Requested by
ShawnRoberts on #webkit).

Reverted changeset:

"Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
​https://bugs.webkit.org/show_bug.cgi?id=197171
​https://trac.webkit.org/changeset/244556

2:06 PM Changeset in webkit [244566] by Devin Rousso
  • 10 edits in trunk/Source

Web Inspector: Uncaught Exception: null is not an object (evaluating 'this.ownerDocument.frameIdentifier')
​https://bugs.webkit.org/show_bug.cgi?id=196420
<rdar://problem/49444205>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Modify the existing frameId to represent the owner frame of the node, rather than the
frame it holds (in the case of an <iframe>).

Source/WebCore:

Modify the existing frameId to represent the owner frame of the node, rather than the
frame it holds (in the case of an <iframe>).

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

Source/WebInspectorUI:

  • UserInterface/Models/DOMNode.js:

(WI.DOMNode):
(WI.DOMNode.prototype.get frame): Added.
(WI.DOMNode.prototype.get frameIdentifier): Deleted.
Modify the existing frameId to represent the owner frame of the node, rather than the
frame it holds (in the case of an <iframe>).

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype.domBreakpointsForNode):
(WI.DOMDebuggerManager.prototype._detachDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._nodeInserted):
(WI.DOMDebuggerManager.prototype._nodeRemoved):

  • UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._populateTagContextMenu):
(WI.DOMTreeElement.prototype._buildAttributeDOM):

  • UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype._selectExecutionContext):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype._highlightNodesWithSelector):

1:52 PM Changeset in webkit [244565] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix iOS build.
​https://bugs.webkit.org/show_bug.cgi?id=195537

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setOpenPanelFilesMediaIcon):
AdoptWK constructor is private now. Use adoptWK instead.

1:47 PM Changeset in webkit [244564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Build fix after r244545.

Patch by Remy Demarest <​rdemarest@apple.com> on 2019-04-23
Reviewed by Tim Horton.

  • Platform/spi/mac/AppKitSPI.h:

The SPI was an IPI in High Sierra.

1:40 PM Changeset in webkit [244563] by Devin Rousso
  • 5 edits in trunk

ContentSecurityPolicy::logToConsole should include line/column number and source location
​https://bugs.webkit.org/show_bug.cgi?id=114317
<rdar://problem/13614617>

Reviewed by Timothy Hatcher.

Source/WebCore:

No change in functionality.

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):
(WebCore::ContentSecurityPolicy::logToConsole const):

LayoutTests:

  • inspector/debugger/csp-exceptions.html:
1:32 PM Changeset in webkit [244562] by Devin Rousso
  • 3 edits in trunk/Source/WebCore

Web Inspector: Canvas: support recording TypedOMCSSImageValue
​https://bugs.webkit.org/show_bug.cgi?id=192609

Reviewed by Timothy Hatcher.

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildAction):

1:31 PM Changeset in webkit [244561] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

Accessibility text search and selection API enhancements.
​https://bugs.webkit.org/show_bug.cgi?id=197095
<rdar://problem/48181791>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-04-23
Reviewed by Chris Fleizach.

Source/WebCore:

  • Split the existing SelectTextWithCriteria API into two: search text API (SearchTextWithCriteria) and a text operation API (TextOperation: select, replace, capitalize...).
  • This allows for more flexibility and extensibility.
  • Added the ability to retrieve text markers for multiple search hits.
  • Various code clean up and consolidation.
  • Added LayoutTest for search API.
  • Previous API is marked with "To be deprecated", and is implemented with new implementation. May be removed in a future change.

Test: accessibility/mac/search-text/search-text.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const):
(WebCore::AccessibilityObject::findTextRange const):
(WebCore::AccessibilityObject::findTextRanges const):
(WebCore::AccessibilityObject::performTextOperation):
(WebCore::AccessibilityObject::frame const):
(WebCore::AccessibilityObject::selectText): Deleted.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilitySearchTextCriteria::AccessibilitySearchTextCriteria):
(WebCore::AccessibilityTextOperation::AccessibilityTextOperation):
(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilityTextCriteriaForParameterizedAttribute):
(accessibilitySearchTextCriteriaForParameterizedAttribute):
(accessibilityTextOperationForParameterizedAttribute):
(-[WebAccessibilityObjectWrapper IGNORE_WARNINGS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute): Deleted.

Tools:

Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.

  • DumpRenderTree/AccessibilityTextMarker.h:
  • DumpRenderTree/AccessibilityUIElement.cpp:

(searchTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(convertVectorToObjectArray):
(convertNSArrayToVector):
(searchTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::rowHeaders const):
(AccessibilityUIElement::columnHeaders const):
(AccessibilityUIElement::uiElementArrayAttributeValue const):
(AccessibilityUIElement::searchTextWithCriteria):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::convertVectorToObjectArray):
(WTR::convertNSArrayToVector):
(WTR::searchTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
(WTR::AccessibilityUIElement::searchTextWithCriteria):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::convertElementsToObjectArray): Deleted.

LayoutTests:

  • Added new test for AccessibilitySearchTextWithCriteria API.
  • Updated bounds-for-range expected file that includes a list of available APIs.
  • accessibility/mac/bounds-for-range-expected.txt:
  • accessibility/mac/search-text/search-text-expected.txt: Added.
  • accessibility/mac/search-text/search-text.html: Added.
1:31 PM Changeset in webkit [244560] by Devin Rousso
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: no obvious way of switching to the overview when viewing an imported recording
​https://bugs.webkit.org/show_bug.cgi?id=197178
<rdar://problem/50106641>

Reviewed by Timothy Hatcher.

Expand the idea of "imported" recordings to include "saved" recordings, ones whose
underlying <canvas> was destroyed.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._removeCanvas):
(WI.CanvasTabContentView.prototype._addRecording):
(WI.CanvasTabContentView.prototype._handleRecordingSavedOrStopped): Added.
(WI.CanvasTabContentView.prototype.initialLayout): Deleted.
(WI.CanvasTabContentView.prototype._recordingImportedOrStopped): Deleted.
Make the "Saved Recordings" folder a child of the "Overview" so that the "Overview" path
component is always visible/clickable.

  • UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.contentViewAdded):
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype._addSavedRecording): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingSaved): Added.
(WI.CanvasOverviewContentView.prototype._handleSavedRecordingClicked): Added.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview .content-view.canvas.saved-recordings): Added.
(.content-view.canvas-overview .content-view.canvas.saved-recordings .tree-outline): Added.
(.content-view.canvas-overview .content-view.canvas.saved-recordings .tree-outline > .item.recording > .icon): Added.
Add a card for "Saved Recordings" that mimics the style of regular canvas cards.

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.get savedRecordings): Added.
(WI.CanvasManager.prototype.async processJSON):
(WI.CanvasManager.prototype.disable):
(WI.CanvasManager.prototype._removeCanvas):
(WI.CanvasManager.prototype.get importedRecordings): Deleted.

  • Localizations/en.lproj/localizedStrings.js:
1:27 PM Changeset in webkit [244559] by pvollan@apple.com
  • 11 edits in trunk/Source/WebKit

[iOS] Input field on ddg.gg is auto focused when url is entered with the software keyboard
​https://bugs.webkit.org/show_bug.cgi?id=196740

Reviewed by Megan Gardner.

When an url for a page with an autofocused input field is entered with the software keyboard,
the input field is auto selected, and the software keyboard reappears. This does not happen
when picking the url from favorites. After using the software keyboard to enter the url, the
activity state is being changed to focused. The method '_elementDidFocus' checks whether the
activity state changed, and allows the software keyboard to be shown in this case. To avoid
showing the software keyboard in this case, send the changing activity state bitfield to the
UI process, and check if the focus flag is the only flag set.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

1:25 PM Changeset in webkit [244558] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source

Remove DeprecatedOptional
​https://bugs.webkit.org/show_bug.cgi?id=197161

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-23
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • inspector/InspectorBackendDispatcher.cpp:
  • inspector/InspectorBackendDispatcher.h:

Source/WTF:

This was added in r209326 to be compatible with a shipping version of Safari.
We have released several versions of Safari since then, so do what the comments say and remove it.
The existence of this std::optional makes migrating to C++17 harder, and there's no reason to keep it.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/DeprecatedOptional.h: Removed.
1:18 PM Changeset in webkit [244557] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk

Multiple File Input Icon Set Regardless of File List
​https://bugs.webkit.org/show_bug.cgi?id=195537

Source/WebCore:

Patch by Guy Lewin <​guy@lewin.co.il> on 2019-04-23
Reviewed by Alexey Proskuryakov.

File input elements display icon with an empty file list after
resetting the file list in 'change' event handler - on iOS

Test: fast/forms/file/file-reset-in-change-using-open-panel-with-icon.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::filesChosen):

Source/WebKit:

Patch by Guy Lewin <​guy@lewin.co.il> on 2019-04-23
Reviewed by Alexey Proskuryakov.

Add WKOpenPanelResultListenerChooseMediaFiles() to choose files with
icon and display string on iOS file open panels

  • UIProcess/API/C/WKOpenPanelResultListener.cpp:

(WKOpenPanelResultListenerChooseMediaFiles):

  • UIProcess/API/C/WKOpenPanelResultListener.h:

Tools:

Patch by Guy Lewin <​guy@lewin.co.il> on 2019-04-23
Reviewed by Alexey Proskuryakov.

Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
display string in iOS file inputs

  • DumpRenderTree/TestRunner.cpp:

(SetOpenPanelFilesMediaIconCallback):
(TestRunner::staticFunctions):
(TestRunner::setOpenPanelFilesMediaIcon):

  • DumpRenderTree/TestRunner.h:

(TestRunner::openPanelFilesMediaIcon const):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setOpenPanelFilesMediaIcon):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::runOpenPanel):
(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::openPanelFileURLsMediaIcon const):
(WTR::TestController::setOpenPanelFileURLsMediaIcon):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add a layout test to verify file input icon resets on change event (iOS)
Change expectations according to
file-reset-in-change-using-open-panel.html

Patch by Guy Lewin <​guy@lewin.co.il> on 2019-04-23
Reviewed by Alexey Proskuryakov.

  • fast/forms/file/file-reset-in-change-using-open-panel-with-icon-expected.html: Added.
  • fast/forms/file/file-reset-in-change-using-open-panel-with-icon.html: Added.
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
1:13 PM Changeset in webkit [244556] by eric.carlson@apple.com
  • 47 edits
    3 adds in trunk

Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
​https://bugs.webkit.org/show_bug.cgi?id=197171
<rdar://problem/47454979>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::category const):
(WebCore::AudioSession::routeSharingPolicy const):
(WebCore::AudioSession::routingContextUID const):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::numberOfOutputChannels const):
(WebCore::AudioSession::tryToSetActiveInternal):
(WebCore::AudioSession::preferredBufferSize const):
(WebCore::AudioSession::setPreferredBufferSize):

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::audioKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind const):
(WebCore::AVTrackPrivateAVFObjCImpl::label const):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::createMix):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::updateOptions):

  • platform/graphics/avfoundation/objc/AVFoundationMIMETypeCache.mm:

(WebCore::AVFoundationMIMETypeCache::canDecodeType):
(WebCore::AVFoundationMIMETypeCache::loadMIMETypes):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistableState):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsPersistentKeys):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::supportsMediaCapability):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):

  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::isAvailable):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
(WebCore::CDMSessionAVContentKeySession::contentKeySession):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::setStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::imageDecoderAssetOptions):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSamples):
(SOFT_LINK_CONSTANT_MAY_FAIL): Deleted.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::label const):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label const):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::devicePicker):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack):
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetType const):
(WebCore::exernalDeviceDisplayNameForPlayer):
(WebCore::metadataType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::streamSession):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):

  • platform/graphics/cocoa/HEVCUtilitiesCocoa.mm:

(WebCore::validateHEVCParameters):

  • platform/ios/PlatformSpeechSynthesizerIOS.mm:

(getAVSpeechUtteranceDefaultSpeechRate):
(getAVSpeechUtteranceMaximumSpeechRate):
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(SOFT_LINK_CONSTANT): Deleted.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoRect]):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):

  • platform/mac/SerializedPlatformRepresentationMac.mm:

(WebCore::jsValueWithValueInContext):
(WebCore::jsValueWithAVMetadataItemInContext):

  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::getAVFormatIDKeyWithFallback):
(WebCore::getAVNumberOfChannelsKeyWithFallback):
(WebCore::getAVSampleRateKeyWithFallback):
(WebCore::getAVEncoderBitRateKeyWithFallback):
(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setVideoInput):
(WebCore::MediaRecorderPrivateWriter::setAudioInput):

  • platform/mediastream/RealtimeVideoSource.h:
  • platform/mediastream/VideoPreset.h:
  • platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices):

  • platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:

(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]):

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::deviceIsAvailable):
(WebCore::AVCaptureDeviceManager::updateCachedAVCaptureDevices):
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
(WebCore::AVCaptureDeviceManager::isAvailable):
(WebCore::AVCaptureDeviceManager::~AVCaptureDeviceManager):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoPreset::create):
(WebCore::AVVideoPreset::AVVideoPreset):
(WebCore::AVVideoCaptureSource::create):
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::capabilities):
(WebCore::sensorOrientationFromVideoOutput):
(WebCore::AVVideoCaptureSource::setupSession):
(WebCore::AVVideoCaptureSource::frameDurationForFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::AVVideoCaptureSource::generatePresets):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver captureOutput:didOutputSampleBuffer:fromConnection:]):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/cocoa/AVFoundationSoftLink.h: Added.
  • pal/cocoa/AVFoundationSoftLink.mm: Added.

Source/WebKit:

  • Shared/ios/WebIconUtilities.mm:

(WebKit::iconForVideoFile):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::clone const):

Source/WebKitLegacy/mac:

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):
(SOFT_LINK_CLASS): Deleted.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.

(TestWebKitAPI::TEST):

12:35 PM Changeset in webkit [244555] by dino@apple.com
  • 3 edits in trunk/Source/WebKit

Use additional members and protocols from WebKitAdditions in WKContentViewInteraction
​https://bugs.webkit.org/show_bug.cgi?id=197184
<rdar://problem/50113848>

Reviewed by Wenson Hsieh.

WebKitAdditions defines some macros to include additional members
and protocols for WKContentViewInteraction.

It also defines some new functions. Provide empty version
of those functions when WebKitAdditions is not available.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreview]):
(-[WKContentView _unregisterPreview]):

12:13 PM Changeset in webkit [244554] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Speed up RenderTheme::systemColor on Speedometer2.
​https://bugs.webkit.org/show_bug.cgi?id=197203
rdar://problem/50056756

Reviewed by Tim Horton.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor const): Remove some unused code. And fetch the cache after an early return.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const): Avoid some allocations in LocalDefaultSystemAppearance
when a CSS color is in the system color cache.

11:15 AM Changeset in webkit [244553] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit

Action sheet shares a stringified URL instead of a URL object
​https://bugs.webkit.org/show_bug.cgi?id=197185
<rdar://problem/49962249>

Reviewed by Darin Adler.

  • UIProcess/Cocoa/WKShareSheet.h:
  • UIProcess/Cocoa/WKShareSheet.mm:

(-[WKShareSheet presentWithParameters:inRect:completionHandler:]):
(-[WKShareSheet presentWithParameters:completionHandler:]): Deleted.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::showShareSheet):

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::showShareSheet):
Make it possible to optionally provide WKShareSheet with
a rect to present relative to.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showShareSheet:inRect:completionHandler:]):
(-[WKContentView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKContentView _showShareSheet:completionHandler:]): Deleted.
Instead of stringifying the URL and using the text selection assistant's
share method, hand WKShareSheet a proper URL.

11:06 AM Changeset in webkit [244552] by Devin Rousso
  • 2 edits in trunk/LayoutTests

Unreviewed, speculative fix for failing inspector/canvas/ tests.
<rdar://problem/48248697>

Reviewed by NOBODY (OOPS!).

  • inspector/canvas/resources/recording-utilities.js:
11:02 AM Changeset in webkit [244551] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Add unit tests for UnApplyPatchIfRequired
​https://bugs.webkit.org/show_bug.cgi?id=197197

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestUnApplyPatchIfRequired):
(TestUnApplyPatchIfRequired.test_success):
(TestUnApplyPatchIfRequired.test_failure):
(TestUnApplyPatchIfRequired.test_skip):

10:58 AM Changeset in webkit [244550] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Add unit tests for CleanWorkingDirectory
​https://bugs.webkit.org/show_bug.cgi?id=197195

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestCleanWorkingDirectory):
(TestCleanWorkingDirectory.test_success):
(TestCleanWorkingDirectory.test_failure):

10:54 AM Changeset in webkit [244549] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

[ews-build] Use explicit imports instead of wildcard imports
​https://bugs.webkit.org/show_bug.cgi?id=197194

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/factories.py:
  • BuildSlaveSupport/ews-build/loadConfig.py:
  • BuildSlaveSupport/ews-build/steps_unittest.py:
10:53 AM Changeset in webkit [244548] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Add unit tests for DownloadBuiltProduct
​https://bugs.webkit.org/show_bug.cgi?id=197193

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestDownloadBuiltProduct):
(TestDownloadBuiltProduct.setUp):
(TestDownloadBuiltProduct.tearDown):
(TestDownloadBuiltProduct.test_success):
(TestDownloadBuiltProduct.test_failure):

10:51 AM Changeset in webkit [244547] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-app] Exception while loading status-bubble when no build step has started
​https://bugs.webkit.org/show_bug.cgi?id=196676

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.

10:10 AM Changeset in webkit [244546] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

[iOS] element.focus() sometimes fails to reveal the focused element when it becomes editable dynamically
​https://bugs.webkit.org/show_bug.cgi?id=197188

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by the scroll-to-reveal code triggered by Element::updateFocusAppearance updating
the scroll position via scrolling tree update in a layer tree commit which happens after
_zoomToRevealFocusedElement in WKContentView had already scrolled the frame view.

To fix this problem, we need to defer the editor state update until the layer commit (see r244494),
and update the scrolling tree before invoking WebPageProxy::editorStateChanged which brings up
the keyboard and scroll-to-reveal the caret in the UI process side.

We also avoid revealing the focus for the second time via Document::scheduleScrollToFocusedElement
in Element::updateFocusAppearance as this timer based scrolling also happens after we had already
revealed the caret in _zoomToRevealFocusedElement. This is a bit hacky but works for most cases since
we wouldn't bring up a keyboard if the focused element was not editable anyway.

Test: editing/selection/ios/scrolling-to-focused-element-inside-iframe.html

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance): Avoid scheduling a timer based reavel of the focused element
when we're already revealing the element via selection change.

Source/WebKit:

Commit the scroll tree update before revealing the keyboard via editor state update.

  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

LayoutTests:

Added a regression test.

  • editing/selection/ios/scrolling-to-focused-element-inside-iframe-expected.txt: Added.
  • editing/selection/ios/scrolling-to-focused-element-inside-iframe.html: Added.
9:25 AM Changeset in webkit [244545] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Fix layout issues occuring when entering full screen mode.
​https://bugs.webkit.org/show_bug.cgi?id=197086
<rdar://problem/47733671>.

Patch by Remy Demarest <​rdemarest@apple.com> on 2019-04-23
Reviewed by Darin Adler.

This issue is the result of changing the style mask of the window after entering
full screen mode. Safari adds an invisible toolbar to display the URL of the page
which ends up breaking the layout. Having that window use a style that includes a
titlebar fixes the bug.

Source/WebCore:

  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow constrainFrameRect:toScreen:]): Ensure that the window
can fill the entire screen including the underlapping the menu bar, so that the
window does not resize when the animation is done.
(-[WebCoreFullScreenWindow canBecomeMainWindow]): Borderless windows cannot become
main by default, adding the titlebar allows it to become main, prevent this from
happening at all to preserve the existing behavior.

Source/WebKit:

  • Platform/spi/mac/AppKitSPI.h:

Declare an SPI to be used in WKFullScreenWindowController.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::fullScreenWindow): Make the full screen window show a titlebar
and make the content view underlap the titlebar to match the current behavior.
Remove NSWindowStyleMaskBorderless which has no effects since it is equal to zero.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:webView:page:]): Hide the titlebar
before beginning the animation to full screen.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Show the title
bar when in full screen instead of a blank bar.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Hide the title
bar to restore the initial setting.

9:14 AM Changeset in webkit [244544] by wilander@apple.com
  • 4 edits
    3 adds in trunk

Ad Click Attribution redirects to well-known location should not trigger a conversion if they are blocked by content blockers
​https://bugs.webkit.org/show_bug.cgi?id=197183
<rdar://problem/47763188>

Reviewed by Alex Christensen.

Source/WebKit:

Ad Click Attribution conversions are picked up in the redirect handler
in WebKit::NetworkResourceLoader. Content blocking typically happens in
the continued redirect request handling in the web content process and
a blocked request comes back empty.

We need to call the WebKit::NetworkLoadChecker in the network process
for these specific redirects, just like we do for Ping.

The change makes use of the existing function
NetworkLoadChecker::enableContentExtensionsCheck() for this purpose.

In essence, this change makes it possible to block all conversions made
to a "/.well-known/ad-click-attribution/" URL.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::handleAdClickAttributionConversion):

New convenience function.

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):

Now calls NetworkLoadChecker::enableContentExtensionsCheck() if
an Ad Click Attribution conversion was found in the redirect URL.

(WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest):

If the request was not blocked, it will store any found conversion here.

  • NetworkProcess/NetworkResourceLoader.h:

LayoutTests:

  • http/tests/contentextensions/block-ad-click-attribution-expected.txt: Added.
  • http/tests/contentextensions/block-ad-click-attribution.html: Added.
  • http/tests/contentextensions/block-ad-click-attribution.html.json: Added.
9:10 AM Changeset in webkit [244543] by stephan.szabo@sony.com
  • 4 edits
    1 add in trunk/Tools

[PlayStation] Support running of JSC tests on remote playstation devices
​https://bugs.webkit.org/show_bug.cgi?id=197170

Reviewed by Ross Kirsling.

Script changes

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests): Pass arguments for playstation to
run-jsc-stress-tests

  • Scripts/run-jsc-stress-tests:

Handle $hostOS=="playstation" for determineArchitecture, turning
off $isFTLPlatform and runProfiler and defaulting test writer.

  • Scripts/webkitdirs.pm:

(jscPath): PlayStation WebKit executables have .elf extension
(executableProductDir): PlayStation builds on Windows hosts but
uses bin directory rather than bin64/bin32 for executable output
location.

  • Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
9:06 AM Changeset in webkit [244542] by Shawn Roberts
  • 2 edits in trunk/LayoutTests

fast/selectors/matches-backtracking.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=197068

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations: Updating expectations for flaky test
8:55 AM Changeset in webkit [244541] by don.olmstead@sony.com
  • 10 edits in trunk

[CMake][Win] Use target oriented design for WebKit
​https://bugs.webkit.org/show_bug.cgi?id=197173

Reviewed by Alex Christensen.

.:

Override WebKit_DERIVED_SOUCES_DIR within WinCairo in support of a target
oriented design.

  • Source/cmake/OptionsWinCairo.cmake:

Source/WebKit:

Enumerate public framework headers for WinCairo's WebKit implementation and copy them.
Migrate to use WebKit_DERIVED_SOURCES_DIR.

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • PlatformWin.cmake:

Tools:

  • TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
  • TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
8:38 AM Changeset in webkit [244540] by Chris Dumez
  • 24 edits in trunk

[Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
​https://bugs.webkit.org/show_bug.cgi?id=197097
<rdar://problem/50048318>

Reviewed by Alex Christensen.

Source/WebCore:

  • loader/EmptyFrameLoaderClient.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
If we still have a provisional item (new load has been started or we did not clear it because we're about to retry),
then let the client know the load will continue by passing an extra flag with the didFailProvisionalLoad.

  • loader/FrameLoaderClient.h:
  • loader/FrameLoaderTypes.h:

Source/WebKit:

The issue is that when doing a history navigation with form data, we try to resubmit the form.
We initially use the ReturnCacheDataDontLoad cache policy without prompting the user to get
cached data. If this fails, we sent a DidFailProvisionalLoadForFrame IPC to the UIProcess but
the WebContent process actually retries the load with ReturnCacheDataElseLoad cache policy.
This new load triggers a new decidePolicyForNavigationAction.

This would cause trouble with process-swapping because we normally destroy the
ProvisionalPageProxy as soon as we receive a DidFailProvisionalLoadForFrame IPC from the
provisional process. As a result, the provisional process would not be able to retry.

To address the issue, we add pass a flag with the DidFailProvisionalLoadForFrame IPC to
if the load will continue or not. When this flag is set, the UIProcess does not destroy
the provisional page.

  • Scripts/webkit/messages.py:

Minor IPC message handler build fix.

  • UIProcess/API/Cocoa/WKURLSchemeTask.mm:

(-[WKURLSchemeTaskImpl _onlyIfCached]):

  • UIProcess/API/Cocoa/WKURLSchemeTaskPrivate.h:

Add new _onlyIfCached SPI to WKURLSchemeTaskPrivate to allow for API testing.

  • UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::cancel):
Pass WillContinueLoading flag.

(WebKit::ProvisionalPageProxy::validateInput):
Consider IPC with a navigationID of 0 as valid. When the navigation is triggered by the
WebContent process, it sends us a DecidePolicyForNavigationActionAsync IPC with a navigationID
of 0, until the UIProcess can generate a valid identifier.

(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):

(WebKit::ProvisionalPageProxy::decidePolicyForNavigationActionAsync):
When the WebPageProxy has generated a navigationID for the new WebContent process-initiated
navigation, update m_navigationID so that follow-up IPC is considered valid.

  • UIProcess/ProvisionalPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsyncShared):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidFailProvisionalLoad):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailProvisionalLoad):

  • WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONScheme webView:startURLSchemeTask:]):

8:36 AM Changeset in webkit [244539] by youenn@apple.com
  • 4 edits in trunk/LayoutTests

REGRESSION (r240727) [ Mac iOS ] Layout Test http/tests/workers/service/basic-register-exceptions.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=194368
<rdar://problem/47937467>

Reviewed by Alex Christensen.

Test was exiting sooner than the last registration was rejected.
Make sure that the test is run until the end in a more ordered way.

  • http/tests/workers/service/basic-register-exceptions-expected.txt:
  • http/tests/workers/service/resources/basic-register-exceptions.js:

(async.doTest):
(then): Deleted.
(catch): Deleted.

  • platform/mac-wk2/TestExpectations:
3:47 AM Changeset in webkit [244538] by commit-queue@webkit.org
  • 9 edits in trunk

[ATK] Implement AtkComponentIface scroll_to methods
​https://bugs.webkit.org/show_bug.cgi?id=196856

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-04-23
Reviewed by Michael Catanzaro.

Source/WebCore:

Implement scroll_to and scroll_to_point when ATK >= 2.30.

Fixes: accessibility/scroll-to-global-point-iframe-nested.html

accessibility/scroll-to-global-point-iframe.html
accessibility/scroll-to-global-point-main-window.html
accessibility/scroll-to-global-point-nested.html
accessibility/scroll-to-make-visible-div-overflow.html
accessibility/scroll-to-make-visible-iframe.html
accessibility/scroll-to-make-visible-nested-2.html
accessibility/scroll-to-make-visible-nested.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToMakeVisible const): Add new method receiving the
ScrollRectToVisibleOptions since ATK interface has a parameter to decide how to scroll.

  • accessibility/AccessibilityObject.h:
  • accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:

(atkToContents):
(webkitAccessibleComponentRefAccessibleAtPoint):
(webkitAccessibleComponentGetExtents):
(webkitAccessibleComponentGrabFocus):
(webkitAccessibleComponentScrollTo):
(webkitAccessibleComponentScrollToPoint):
(webkitAccessibleComponentInterfaceInit):
(core): Deleted.

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
(WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().

  • gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.

LayoutTests:

Remove expectations for tests that are passing now.

  • platform/gtk/TestExpectations:

Apr 22, 2019:

6:36 PM Changeset in webkit [244537] by Alan Bujtas
  • 4 edits
    1 copy
    1 add in trunk

[ContentChangeObserver] Some dropdown menus may close without user gesture on americanexpress.com
​https://bugs.webkit.org/show_bug.cgi?id=197175
<rdar://problem/49613013>

Reviewed by Simon Fraser.

Source/WebKit:

Do not generate additional synthetic mouse events (e.g. mouseout in this case) when the content handles the click event. This helps cases when the synthetic mouseout ended up dismissing the dropdown menus.
However it won't regress cases like youtube.com, where sending mouseout is required to have the control bar dismissed on play.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

  • fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented-expected.txt: Added.
  • fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented.html: Added.
6:18 PM Changeset in webkit [244536] by Alan Coon
  • 7 edits in branches/safari-607-branch/Source

Versioning.

5:30 PM Changeset in webkit [244535] by Alan Coon
  • 7 edits in tags/Safari-608.1.17.200/Source

Versioning.

5:24 PM Changeset in webkit [244534] by Alan Coon
  • 1 copy in tags/Safari-608.1.17.200

New tag.

5:22 PM Changeset in webkit [244533] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews-build] Improve summary for UploadBuiltProduct step
​https://bugs.webkit.org/show_bug.cgi?id=197182

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(UploadBuiltProduct): Added descriptionDone.
(UploadBuiltProduct.getResultSummary): Overrided getResultSummary.

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestUploadBuiltProduct.test_success): Updated unit-test.
(TestUploadBuiltProduct.test_failure): Added unit-test for failure case.

5:16 PM Changeset in webkit [244532] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews-build] Trigger queues only after uploading the archive
​https://bugs.webkit.org/show_bug.cgi?id=197180

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/factories.py:

(Factory.init):
(BuildFactory.init): Remove trigger step from factories.
(BuildFactory.propertiesToPassToTriggers): Deleted.

  • BuildSlaveSupport/ews-build/steps.py:

(ConfigureBuild.init): Confiure triggers property.
(Trigger): Step to trigger other queues.
(Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
(UploadBuiltProduct.finished): Trigger builds after upload is successful.

5:16 PM Changeset in webkit [244531] by Alan Coon
  • 1 copy in branches/safari-607.2.6.1-branch

New branch.

5:16 PM Changeset in webkit [244530] by Alan Coon
  • 1 copy in branches/safari-607.2.6.0-branch

New branch.

5:15 PM Changeset in webkit [244529] by commit-queue@webkit.org
  • 4 edits in trunk

Deprecate WKContextCreateWithInjectedBundlePath
​https://bugs.webkit.org/show_bug.cgi?id=197169

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-22
Reviewed by Youenn Fablet.

Source/WebKit:

  • UIProcess/API/C/WKContext.h:

Tools:

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):
Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.

5:07 PM Changeset in webkit [244528] by Alan Coon
  • 1 copy in branches/safari-607.2.1.2-branch

New branch.

5:04 PM Changeset in webkit [244527] by Alan Coon
  • 1 delete in branches/Safari-607.2.1.2

Delete tag.

5:01 PM Changeset in webkit [244526] by Alan Coon
  • 1 copy in branches/Safari-607.2.1.2

New branch.

4:59 PM Changeset in webkit [244525] by Alan Coon
  • 1 delete in tags/Safari-607.2.1.2

Delete tag.

4:50 PM Changeset in webkit [244524] by Alan Coon
  • 1 delete in tags/Safari-607.2.6.1

Delete tag.

4:47 PM Changeset in webkit [244523] by Alan Coon
  • 1 copy in tags/Safari-607.2.6.1

New tag.

4:09 PM Changeset in webkit [244522] by Alan Coon
  • 7 edits in tags/Safari-607.2.1.2/Source

Versioning.

4:05 PM Changeset in webkit [244521] by achristensen@apple.com
  • 15 edits
    1 add in trunk

REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
​https://bugs.webkit.org/show_bug.cgi?id=197093
<rdar://problem/49708268>

Reviewed by Chris Dumez.

Source/WebKit:

Only get the StoredCredentialsPolicy from the NetworkLoadChecker if we haven't already been told not to use credentials.
Also add some test infrastructure for clearing persistent credentials added by the test.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::removeCredential):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::removeCredential):

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _removeCredential:forProtectionSpace:completionHandler:]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::removeCredential):

  • UIProcess/WebProcessPool.h:

Tools:

Add a test that does two loads. The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
and one for loads without credentials, so there are two TCP connections to the same server in this test.

  • TestWebKitAPI/TCPServer.cpp:

(TestWebKitAPI::TCPServer::TCPServer):
(TestWebKitAPI::TCPServer::~TCPServer):
(TestWebKitAPI::TCPServer::socketBindListen):
(TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.

  • TestWebKitAPI/TCPServer.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.

(-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):

  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(respondWithChallengeThenOK):
(TestWebKitAPI::TEST):
(-[ProposedCredentialDelegate webView:didFinishNavigation:]):
(-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TEST):

4:05 PM Changeset in webkit [244520] by Alan Coon
  • 7 edits in tags/Safari-608.1.17.100/Source

Versioning.

4:02 PM Changeset in webkit [244519] by Alan Coon
  • 1 copy in tags/Safari-608.1.17.100

New tag.

3:55 PM Changeset in webkit [244518] by Alan Coon
  • 1 copy in tags/Safari-607.2.1.2

New tag.

3:29 PM Changeset in webkit [244517] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Update libwebrtc logging when WebCore WebRTC logging is updated
​https://bugs.webkit.org/show_bug.cgi?id=197166
<rdar://problem/50107696>

Unreviewed.

Build fix after ​https://trac.webkit.org/changeset/244511.

  • page/Page.cpp:

(WebCore::Page::configureLoggingChannel):

3:17 PM Changeset in webkit [244516] by Chris Dumez
  • 6 edits in trunk

Delayed WebProcessLaunch may break the _relatedWebView SPI
​https://bugs.webkit.org/show_bug.cgi?id=197160

Reviewed by Alex Christensen.

Source/WebKit:

Delayed WebProcessLaunch may break the _relatedWebView SPI. The breakage would happen if the client
would relate a WebView to another which has not launched its initial process yet.

To address the issue, when we need a running process for a WebView which has a related view, we need
to make sure the related view has a running process and use that process. Previously, we would share
the "dummy" process instead.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::ensureRunningProcess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3:12 PM Changeset in webkit [244515] by youenn@apple.com
  • 7 edits in trunk

Cache API should return Abort error in case of putting an aborted fetch
​https://bugs.webkit.org/show_bug.cgi?id=196757

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-abort.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-abort.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-abort.https-expected.txt:

Source/WebCore:

In case of an aborted fetch, call consume callback with an AbortError.
Update the code that handles load cancelling as the loader callback is called.
Covered by rebased tests.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::addAbortSteps):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::~BodyLoader):
(WebCore::FetchResponse::stop):

  • Modules/fetch/FetchResponse.h:
3:11 PM Changeset in webkit [244514] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Sources: auto-continue breakpoint triangle is incorrectly positioned
​https://bugs.webkit.org/show_bug.cgi?id=197179

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status): Added.
(.item.breakpoint .status > .status-image.auto-continue::after):

3:07 PM Changeset in webkit [244513] by dean_johnson@apple.com
  • 2 edits in trunk/Tools

Use curl to download packages for webkitpy autoinstaller
​https://bugs.webkit.org/show_bug.cgi?id=197164

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._download): Use curl(1) to download packages necessary for
webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
errors which are not present when using curl(1).

2:54 PM Changeset in webkit [244512] by david_quesada@apple.com
  • 3 edits in trunk/Source/WebKit

Remove linked-on-or-after check for download attribute handling
​https://bugs.webkit.org/show_bug.cgi?id=197176
rdar://problem/48459714

Reviewed by Alex Christensen.

There are no apps linked prior to this SDK version that are using the _WKDownload SPI,
so it doesn't make sense to preserve the old behavior of forcing download-attribute
links to start downloads.

  • UIProcess/Cocoa/VersionChecks.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

2:29 PM Changeset in webkit [244511] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Update libwebrtc logging when WebCore WebRTC logging is updated
​https://bugs.webkit.org/show_bug.cgi?id=197166

Reviewed by Eric Carlson.

When updating WebRTC logging from Web Inspector, update libwebrtc logging so that no page reload is required.
Manually tested.

  • page/Page.cpp:

(WebCore::Page::configureLoggingChannel):

2:08 PM Changeset in webkit [244510] by Chris Dumez
  • 6 edits in trunk

Unreviewed, rolling out r244502.

Caused crashes on the bots

Reverted changeset:

"Delayed WebProcessLaunch may break the _relatedWebView SPI"
​https://bugs.webkit.org/show_bug.cgi?id=197160
​https://trac.webkit.org/changeset/244502

12:57 PM Changeset in webkit [244509] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Introduce the concept of "opportunistic" stacking contexts
​https://bugs.webkit.org/show_bug.cgi?id=197077

Reviewed by Zalan Bujtas.

Bring back a variant of some code removed in r236424, which allows a RenderLayer
to be stacking context for painting, without actually being on in terms of CSS.

Internally, RenderLayer will call setIsOpportunisticStackingContext() to make a layer
into a stacking context for painting. External callers deal with isStackingContext()
or isCSSStackingContext().

Sadly we can't make m_forcedStackingContext (set on media element layers) trigger a
non-CSS stacking context; media controls use mix-blend-mode, and rely on the fake-stacking
media layer to be the "isolateBlending" ancestor.

No code uses this yet.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::isStackingContextChanged):
(WebCore::RenderLayer::setIsOpportunisticStackingContext):
(WebCore::RenderLayer::setIsCSSStackingContext):
(WebCore::RenderLayer::updateAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::dirtyAncestorChainHasBlendingDescendants):
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::outputPaintOrderTreeLegend):
(WebCore::outputPaintOrderTreeRecursive):
(WebCore::RenderLayer::shouldBeStackingContext const): Deleted.
(WebCore::RenderLayer::setIsStackingContext): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::compositingOpacity const):

12:51 PM Changeset in webkit [244508] by Ryan Haddad
  • 6 edits in trunk

Unreviewed, rolling out r244437.

Still breaks internal tests.

Reverted changeset:

"InjectedBundle parameters often need initialization function
called before unarchiving"
​https://bugs.webkit.org/show_bug.cgi?id=189709
​https://trac.webkit.org/changeset/244437

11:41 AM Changeset in webkit [244507] by Justin Fan
  • 19 edits
    1 copy in trunk

[WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext
​https://bugs.webkit.org/show_bug.cgi?id=197126

Reviewed by Dean Jackson.

Source/WebCore:

GPUSwapChains are now configured via GPUCanvasContext instead of GPUDevice. Covers WebGPU API
pull request #262.

Existing WebGPU tests updated to match.

  • Modules/webgpu/GPUCanvasContext.cpp:

(WebCore::GPUCanvasContext::configureSwapChain):
(WebCore::GPUCanvasContext::replaceSwapChain): Deleted.

  • Modules/webgpu/GPUCanvasContext.h:
  • Modules/webgpu/GPUCanvasContext.idl:
  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createSwapChain const): Deleted.

  • Modules/webgpu/WebGPUDevice.h:

(WebCore::WebGPUDevice::device):

  • Modules/webgpu/WebGPUDevice.idl:
  • Modules/webgpu/WebGPUSwapChainDescriptor.cpp: Copied from Source/WebCore/Modules/webgpu/WebGPUSwapChainDescriptor.h.

(WebCore::WebGPUSwapChainDescriptor::asGPUSwapChainDescriptor const):

  • Modules/webgpu/WebGPUSwapChainDescriptor.h:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::setSwapChain):
(WebCore::GPUDevice::tryCreateSwapChain const): Deleted.

  • platform/graphics/gpu/GPUDevice.h:
  • platform/graphics/gpu/GPUSwapChain.h:
  • platform/graphics/gpu/GPUSwapChainDescriptor.h:

(WebCore::GPUSwapChainDescriptor::GPUSwapChainDescriptor):

  • platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm:

(WebCore::GPUSwapChain::tryCreate):

LayoutTests:

GPUSwapChains are now configured via GPUCanvasContext instead of GPUDevice.

  • webgpu/blend-triangle-strip.html:
  • webgpu/js/webgpu-functions.js:

(createBasicSwapChain):

  • webgpu/whlsl.html:
11:35 AM Changeset in webkit [244506] by ysuzuki@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Use volatile load to populate backing page in MarkedBlock::Footer instead of using holdLock
​https://bugs.webkit.org/show_bug.cgi?id=197152

Reviewed by Saam Barati.

Emit volatile load instead of using holdLock to populate backing page in MarkedBlock::Footer.

  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::isPagedOut):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::populatePage const):

11:30 AM Changeset in webkit [244505] by ysuzuki@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

[JSC] useJIT should subsume useRegExpJIT
​https://bugs.webkit.org/show_bug.cgi?id=197153

Reviewed by Alex Christensen.

useJIT should subsume useRegExpJIT. We should immediately disable JIT feature if useJIT = false,
even if useRegExpJIT is true.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::isSupported):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

  • runtime/VM.cpp:

(JSC::enableAssembler):
(JSC::VM::canUseRegExpJIT): Deleted.

  • runtime/VM.h:
11:29 AM Changeset in webkit [244504] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews-build] Use singular verb in failure description in case of single api test failure
​https://bugs.webkit.org/show_bug.cgi?id=197013

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults):

11:17 AM Changeset in webkit [244503] by Said Abou-Hallawa
  • 3 edits in trunk/Source/WebCore

Mark SVGStringList properties '[SameObject]' in the IDL files
Followup to ​https://bugs.webkit.org/show_bug.cgi?id=197137

Patch by Said Abou-Hallawa <Said Abou-Hallawa> on 2019-04-22
Reviewed by Darin Adler.

The SVG elements do not create tear-off wrappers for SVGStrigList DOM
objects anymore. Instead they return Ref pointers to the same RefCounted
objects. So they should be marked '[SameObject]' in their IDL files.

  • svg/SVGTests.idl:
  • svg/SVGViewElement.idl:
11:03 AM Changeset in webkit [244502] by Chris Dumez
  • 6 edits in trunk

Delayed WebProcessLaunch may break the _relatedWebView SPI
​https://bugs.webkit.org/show_bug.cgi?id=197160

Reviewed by Alex Christensen.

Source/WebKit:

Delayed WebProcessLaunch may break the _relatedWebView SPI. The breakage would happen if the client
would relate a WebView to another which has not launched its initial process yet.

To address the issue, when we need a running process for a WebView which has a related view, we need
to make sure the related view has a running process and use that process. Previously, we would share
the "dummy" process instead.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::ensureRunningProcess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9:38 AM Changeset in webkit [244501] by basuke.suzuki@sony.com
  • 3 edits
    9 copies
    4 adds
    1 delete in trunk/Source/JavaScriptCore

[PlayStation] Restructuring Remote Inspector classes to support multiple platform.
​https://bugs.webkit.org/show_bug.cgi?id=197030

Reviewed by Don Olmstead.

Restructuring the PlayStation's RemoteInspector backend which uses native socket for the communication to be ready for WinCairo.

What we did is basically:

  • Renamed remote/playstation/ to remote/socket/. This directory is now platform independent implementation of socket backend.
  • Renamed RemoteInspectorSocket class to RemoteInspectorSocketEndpoint. This class is platform independent and core of the backend.
  • Merged RemoteInspectorSocket{Client|Server} classes into RemoteInspectorSocketEndpoint class because the differences are little.
  • Defined a new interface functions in Inspector::Socket (new) namespace.
  • Moved POSIX socket implementation into posix\RemoteInspectorSocketPOSIX.{h|cpp}.
  • PlatformPlayStation.cmake:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/playstation/RemoteInspectorSocketClient.h: Merged into RemoteInspectorSocketEndpoint.
  • inspector/remote/playstation/RemoteInspectorSocketClientPlayStation.cpp: Merged into RemoteInspectorSocketEndpoint.
  • inspector/remote/playstation/RemoteInspectorSocketPlayStation.cpp: Removed.
  • inspector/remote/playstation/RemoteInspectorSocketServer.h: Merged into RemoteInspectorSocketEndpoint.
  • inspector/remote/playstation/RemoteInspectorSocketServerPlayStation.cpp: Merged into RemoteInspectorSocketEndpoint.
  • inspector/remote/socket/RemoteInspectorConnectionClient.cpp: Renamed from inspector\remote\playstation\RemoteInspectorConnectionClientPlayStation.cpp.
  • inspector/remote/socket/RemoteInspectorConnectionClient.h: Renamed from inspector\remote\playstation\RemoteInspectorConnectionClient.h.

(Inspector::RemoteInspectorConnectionClient::didAccept):

  • inspector/remote/socket/RemoteInspectorMessageParser.cpp: Renamed from inspector\remote\playstation\RemoteInspectorMessageParserPlayStation.cpp.
  • inspector/remote/socket/RemoteInspectorMessageParser.h: Renamed from inspector\remote\playstation\RemoteInspectorMessageParser.h.
  • inspector/remote/socket/RemoteInspectorServer.cpp: Renamed from inspector\remote\playstation\RemoteInspectorServerPlayStation.cpp.

(Inspector::RemoteInspectorServer::didAccept):
(Inspector::RemoteInspectorServer::start):

  • inspector/remote/socket/RemoteInspectorServer.h: Renamed from inspector\remote\playstation\RemoteInspectorServer.h.
  • inspector/remote/socket/RemoteInspectorSocket.cpp: Renamed from inspector\remote\playstation\RemoteInspectorPlayStation.cpp.

(Inspector::RemoteInspector::start):

  • inspector/remote/socket/RemoteInspectorSocket.h: Copied from inspector\remote\playstation\RemoteInspectorSocket.h.
  • inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp: Added.

(Inspector::RemoteInspectorSocketEndpoint::RemoteInspectorSocketEndpoint):
(Inspector::RemoteInspectorSocketEndpoint::~RemoteInspectorSocketEndpoint):
(Inspector::RemoteInspectorSocketEndpoint::wakeupWorkerThread):
(Inspector::RemoteInspectorSocketEndpoint::connectInet):
(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::isListening):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::send):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.h: Renamed from inspector\remote\playstation\RemoteInspectorSocket.h.
  • inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp: Added.

(Inspector::Socket::connect):
(Inspector::Socket::listen):
(Inspector::Socket::accept):
(Inspector::Socket::createPair):
(Inspector::Socket::setup):
(Inspector::Socket::isValid):
(Inspector::Socket::isListening):
(Inspector::Socket::read):
(Inspector::Socket::write):
(Inspector::Socket::close):
(Inspector::Socket::preparePolling):
(Inspector::Socket::poll):
(Inspector::Socket::isReadable):
(Inspector::Socket::isWritable):
(Inspector::Socket::markWaitingWritable):
(Inspector::Socket::clearWaitingWritable):

9:31 AM Changeset in webkit [244500] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GTK] fix gtk_style_context_set_background deprecation
​https://bugs.webkit.org/show_bug.cgi?id=196912

Patch by Ludovico de Nittis <​ludovico.denittis@collabora.com> on 2019-04-22
Reviewed by Carlos Garcia Campos.

Since gtk 3.18 gtk_style_context_set_background has been deprecated.
Backgrounds are not rendered in the UI process, so it can be
simply removed.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

8:50 AM Changeset in webkit [244499] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r244495.
​https://bugs.webkit.org/show_bug.cgi?id=197159

Causing build failures on OpenSource and Internal bots
(Requested by ShawnRoberts on #webkit).

Reverted changeset:

"WHLSLPrepare.cpp always recompiles, even if nothing was
changed"
​https://bugs.webkit.org/show_bug.cgi?id=197151
​https://trac.webkit.org/changeset/244495

12:58 AM Changeset in webkit [244498] by Carlos Garcia Campos
  • 6 edits in trunk

REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
​https://bugs.webkit.org/show_bug.cgi?id=194630

Reviewed by Michael Catanzaro.

Source/WebCore:

Do not assume core object always has a wrapper in webkitAccessibleRefChild().

Fixes: accessibility/removed-continuation-element-causes-crash.html

accessibility/removed-anonymous-block-child-causes-crash.html

  • accessibility/atk/WebKitAccessible.cpp:

(webkitAccessibleRefChild): Return early if wrapper is nullptr.

Tools:

Return early from getAttributeSet() is passed in accessible is nullptr.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Remove expectations for tests that are passing now.

  • platform/gtk/TestExpectations:

Apr 21, 2019:

11:44 PM Changeset in webkit [244497] by ysuzuki@apple.com
  • 8 edits in trunk/Source/bmalloc

[bmalloc] Use StaticPerProcess' mutex as bmalloc::Heap does with PerProcess
​https://bugs.webkit.org/show_bug.cgi?id=197135

Reviewed by Darin Adler.

This patch leverages StaticPerProcess::mutex() for per process instance's lock in various classes,
as Heap does with PerProcess::mutex().

  • bmalloc/AllIsoHeaps.cpp:

(bmalloc::AllIsoHeaps::add):
(bmalloc::AllIsoHeaps::head):

  • bmalloc/AllIsoHeaps.h:
  • bmalloc/CryptoRandom.cpp:

(bmalloc::ARC4RandomNumberGenerator::randomValues):

  • bmalloc/DebugHeap.cpp:

(bmalloc::DebugHeap::memalignLarge):
(bmalloc::DebugHeap::freeLarge):

  • bmalloc/DebugHeap.h:
  • bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::run):
(bmalloc::Scavenger::runSoon):
(bmalloc::Scavenger::scheduleIfUnderMemoryPressure):
(bmalloc::Scavenger::schedule):
(bmalloc::Scavenger::timeSinceLastFullScavenge):
(bmalloc::Scavenger::scavenge):
(bmalloc::Scavenger::threadRunLoop):

  • bmalloc/Scavenger.h:
11:22 PM Changeset in webkit [244496] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WTF

[WTF] Generic memoryFootprint() implementation should use bmalloc on Linux
​https://bugs.webkit.org/show_bug.cgi?id=196963

Reviewed by Don Olmstead.

Have the generic memoryFootprint() implementation use bmalloc's
memoryFootprint() API on Linux, whenever the system malloc option is
not enabled. Limitation to Linux platforms is due to the bmalloc
implementation being limited to those configurations (excluding iOS
which doesn't use MemoryFootprintGeneric.cpp).

  • wtf/PlatformWPE.cmake: Switch to building MemoryFootprintGeneric.cpp.
  • wtf/generic/MemoryFootprintGeneric.cpp:

(WTF::memoryFootprint):

5:24 PM Changeset in webkit [244495] by Darin Adler
  • 4 edits in trunk/Source/WebCore

WHLSLPrepare.cpp always recompiles, even if nothing was changed
​https://bugs.webkit.org/show_bug.cgi?id=197151

Reviewed by Dan Bernstein.

  • DerivedSources-input.xcfilelist: Script updated this automatically after

DerivedSources.make was corrected.

  • DerivedSources-output.xcfilelist: Ditto, although I had to manually remove

one bogus leftover reference to WHLSLStandardLibrary.cpp.

  • DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to

no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
was running on every build, instead of only when one of the dependencies changed.

2:10 PM Changeset in webkit [244494] by Wenson Hsieh
  • 8 edits in trunk

Defer EditorState updates until the next layer tree flush in a few additional circumstances
​https://bugs.webkit.org/show_bug.cgi?id=197145
<rdar://problem/50078170>

Reviewed by Darin Adler.

Source/WebKit:

Gets rid of sendPartialEditorStateAndSchedulePostLayoutUpdate(), in favor of always scheduling a full editor
state update after the next compositing flush.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateEditorStateAfterLayoutIfEditabilityChanged):
(WebKit::WebPage::setNeedsFontAttributes):
(WebKit::WebPage::didChangeOverflowScrollPosition):
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::didChangeSelectionOrOverflowScrollPosition):
(WebKit::WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::updateVisibleContentRects):

Tools:

Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
focus, or showing the font manager.

  • TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:

(TEST):

  • TestWebKitAPI/Tests/mac/FontManagerTests.mm:

(TestWebKitAPI::TEST):

1:14 PM Changeset in webkit [244493] by Chris Dumez
  • 4 edits in trunk/Source/WebKit

Regression(r243767) WebFrame::m_navigationIsContinuingInAnotherProcess flag is never reset
​https://bugs.webkit.org/show_bug.cgi?id=197144

Reviewed by Darin Adler.

WebFrame::m_navigationIsContinuingInAnotherProcess flag is never reset since it was introduced in
r243767. This leads to leaking Navigation objects in the UIProcess when reusing a previously
suspended process because such process will no longer send the DidDestroyNavigation IPC.

It turns out that resetting the flags causes API tests such as ProcessSwap.QuickBackForwardNavigationWithPSON
to ASSERT. This is because when the UIProcess quickly navigate back and forth without waiting for policy
decisions, we may end up getting the policy decision for a particular navigation *after* we've sent the
DidDestroyNavigation.

As a result, this patch reverts r243767 and fixes in the assertion in http/tests/adClickAttribution/store-ad-click-attribution.html
another way. We initially assumed that the logic in WebPageProxy::didDestroyNavigation() was failing to
ignore the DidDestroyNavigation from the previous process after a swap due to a race, maybe because it was
sometimes received too late and m_provisionalPage was already cleared. However, this would not make sense
since the test is crashing consistently and the page would no longer be able to receive IPC from the
previous process *after* we've committed the provisional process/page.

The real issue was that the DidDestroyNavigation IPC was received *before* we could construct the
provisional page, which is why the logic in WebPageProxy::didDestroyNavigation() was failing to ignore
the bad IPC. In WebPageProxy::receivedNavigationPolicyDecision(), we were calling receivedPolicyDecision()
(which would send the DidReceivePolicyDecision to the previous WebProcess) and then continueNavigationInNewProcess()
in order to construct the provisional page. I personally did not expect we could receive IPC between the
calls to receivedNavigationPolicyDecision() and receivedPolicyDecision(), since we are not yielding and since
the DidReceivePolicyDecision IPC is asynchronous. However, this is exactly what was happening in the context
of this test. The reason is that the DidReceivePolicyDecision IPC was getting wrapped in a synchronous message
and sent as synchronous message due to the Connection::m_inDispatchMessageMarkedToUseFullySynchronousModeForTesting
flag which seems to get set in the test due to some EventSender IPC. I believe this is because the test uses
EventSender to do a click on a link which triggers the navigation.

To address the issue, I now call receivedNavigationPolicyDecision() *after* continueNavigationInNewProcess()
to make sure that we always start the provisional load in the new process before we tell the previous process
to stop loading. This way, there is no way we get IPC from the previous process about the current navigation
before we have a provisional page.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::didDestroyNavigation):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::didReceivePolicyDecision):
(WebKit::WebFrame::documentLoaderDetached):

  • WebProcess/WebPage/WebFrame.h:
12:48 PM Changeset in webkit [244492] by BJ Burg
  • 2 edits in trunk/Tools

WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
​https://bugs.webkit.org/show_bug.cgi?id=197125
<rdar://problem/50061468>

Reviewed by Darin Adler.

Sometimes I want to run wptserve independently of tests. Make it easier to script that
using this class rather than making our own ./wpt serve invocation.

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:

(WebDriverW3CWebServer):
(WebDriverW3CWebServer.document_root): Expose this to clients.
(WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.

(WebDriverW3CWebServer.enter):
(WebDriverW3CWebServer.exit):
Make it possible to use the web server with a 'with' statement.

Note: See TracTimeline for information about the timeline view.