⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 13, 2019:

9:32 PM Changeset in webkit [245274] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari 12.1.1

Added a tag for Safari 12.1.1.

9:32 PM Changeset in webkit [245273] by mitz@apple.com
  • 8 copies
    1 add in releases/Apple/iOS 12.3

Added a tag for iOS 12.3.

9:14 PM Changeset in webkit [245272] by Wenson Hsieh
  • 8 edits in trunk/Source/WebKit

Followup to r245267: fix some more deprecated uses of -[UIApplication interfaceOrientation]
​https://bugs.webkit.org/show_bug.cgi?id=197867
<rdar://problem/50743963>

Reviewed by Simon Fraser.

Add a helper method on WKContentView that asks the view's window's scene for an interface orientation; then,
use this helper from various places in WebKit instead of invoking -[UIApplication interfaceOrientation]
directly. No change in behavior.

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView interfaceOrientation]):

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsPicker initWithInformation:inView:]):

  • UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorPicker initWithView:]):

  • UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePicker initWithView:datePickerMode:]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker initWithView:]):

  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):

8:38 PM Changeset in webkit [245271] by rmorisset@apple.com
  • 2 edits in trunk/Source/WTF

IndexSet::isEmpty should use BitVector::isEmpty() instead of size()
​https://bugs.webkit.org/show_bug.cgi?id=197857

Reviewed by Darin Adler.

  • wtf/IndexSet.h:

(WTF::IndexSet::isEmpty const):

7:34 PM Changeset in webkit [245270] by ysuzuki@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

[JSC] Compress JIT related data more by using Packed<>
​https://bugs.webkit.org/show_bug.cgi?id=197866

Reviewed by Saam Barati.

This patch leverages Packed<> more to reduce JIT related data size. When we measure memory usage on Gmail, we found that a lot of memory is
consumed in DFG data. This patch attempts to reduce that size by using Packed<> to make various data structure's alignment 1.

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit): Add more shrinkToFit.

  • dfg/DFGMinifiedID.h: Make alignment = 1.

(JSC::DFG::MinifiedID::operator! const):
(JSC::DFG::MinifiedID::operator== const):
(JSC::DFG::MinifiedID::operator!= const):
(JSC::DFG::MinifiedID::operator< const):
(JSC::DFG::MinifiedID::operator> const):
(JSC::DFG::MinifiedID::operator<= const):
(JSC::DFG::MinifiedID::operator>= const):
(JSC::DFG::MinifiedID::hash const):
(JSC::DFG::MinifiedID::dump const):
(JSC::DFG::MinifiedID::isHashTableDeletedValue const):
(JSC::DFG::MinifiedID::bits const):

  • dfg/DFGMinifiedIDInlines.h:

(JSC::DFG::MinifiedID::MinifiedID):

  • dfg/DFGMinifiedNode.cpp:

(JSC::DFG::MinifiedNode::fromNode): Make sizeof(MinifiedNode) from 16 to 13 with alignment = 1.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::MinifiedNode::id const):
(JSC::DFG::MinifiedNode::hasConstant const):
(JSC::DFG::MinifiedNode::constant const):
(JSC::DFG::MinifiedNode::isPhantomDirectArguments const):
(JSC::DFG::MinifiedNode::isPhantomClonedArguments const):
(JSC::DFG::MinifiedNode::hasInlineCallFrame const):
(JSC::DFG::MinifiedNode::inlineCallFrame const):
(JSC::DFG::MinifiedNode::op const): Deleted.
(JSC::DFG::MinifiedNode::hasInlineCallFrame): Deleted.

  • dfg/DFGVariableEvent.h: Make sizeof(VariableEvent) from 12 to 10 with alignment = 1.

(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::birth):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id const):
(JSC::DFG::VariableEvent::gpr const):
(JSC::DFG::VariableEvent::tagGPR const):
(JSC::DFG::VariableEvent::payloadGPR const):
(JSC::DFG::VariableEvent::fpr const):
(JSC::DFG::VariableEvent::spillRegister const):
(JSC::DFG::VariableEvent::bytecodeRegister const):
(JSC::DFG::VariableEvent::machineRegister const):
(JSC::DFG::VariableEvent::variableRepresentation const):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::tryToSetConstantRecovery):

7:25 PM Changeset in webkit [245269] by youenn@apple.com
  • 3 edits in trunk/Source/WTF

[Mac] Use realpath for dlopen_preflight
​https://bugs.webkit.org/show_bug.cgi?id=197803

Reviewed by Eric Carlson.

  • wtf/cocoa/SoftLinking.h:
7:25 PM Changeset in webkit [245268] by Wenson Hsieh
  • 7 edits in trunk

[iOS] When running layout tests that tap in the same location, subsequent tests fail to fire click handlers
​https://bugs.webkit.org/show_bug.cgi?id=197821
<rdar://problem/50700512>

Reviewed by Tim Horton.

Source/WebKit:

After r244775, when running back-to-back layout tests on iOS that simulate taps in the same location, the double
tap gesture recognizer for recognizing double clicks ends up recognizing instead of the single tap gesture
recognizer in the subsequent test. This means that click handlers in the subsequent test will fail to recognize,
unless the element with the click handler is also accompanied by a dblclick handler.

To avoid this, we reset the double click gesture recognizer when navigating; this has the additional effect of
making it such that the second page doesn't end up observing a dblclick when the first click was only sent to
the first page.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _didStartProvisionalLoadForMainFrame]):

LayoutTests:

Removes workarounds in a couple of existing layout tests.

  • editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html:
  • editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler.html:
5:12 PM Changeset in webkit [245267] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix some deprecation warnings when using a recent SDK

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsPicker initWithInformation:inView:]):

5:11 PM Changeset in webkit [245266] by Alan Coon
  • 7 edits in branches/safari-608.1.24-branch/Source

Versioning.

5:03 PM Changeset in webkit [245265] by ysuzuki@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, build fix after 245258, missing ThreadSpecific.h include
​https://bugs.webkit.org/show_bug.cgi?id=197146

  • platform/ios/wak/WebCoreThread.mm:
4:43 PM Changeset in webkit [245264] by ysuzuki@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, wrokaround for MACH_VM_MAX_ADDRESS in ARM32_64
​https://bugs.webkit.org/show_bug.cgi?id=197730

Interestingly, MACH_VM_MAX_ADDRESS is larger than 32bit in ARM32_64, I think this is a bug.
But for now, we workaround for this case by using CPU(ADDRESS64).

  • wtf/WTFAssertions.cpp:
4:11 PM Changeset in webkit [245263] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/mac

Make QTKit an optional framework
​https://bugs.webkit.org/show_bug.cgi?id=197075

Reviewed by Eric Carlson.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

4:09 PM Changeset in webkit [245262] by jiewen_tan@apple.com
  • 11 edits in trunk

[WebAuthN] InvalidStateError should be reported to sites
​https://bugs.webkit.org/show_bug.cgi?id=193269
<rdar://problem/48298264>

Reviewed by Brent Fulgham.

Source/WebKit:

This patch implements step 20 about InvalidStateError of the spec:
​https://www.w3.org/TR/webauthn/#createCredential.

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::respondReceived):

  • UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:

(WebKit::CtapHidAuthenticator::continueMakeCredentialAfterResponseReceived const):

LayoutTests:

  • http/wpt/webauthn/ctap-hid-failure.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https-expected.txt:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:
  • http/wpt/webauthn/resources/util.js:
4:09 PM Changeset in webkit [245261] by jer.noble@apple.com
  • 1 edit
    3 adds in trunk/Websites/bugs.webkit.org

Bugzilla should convert "r12345" to a trac.webkit.org link
​https://bugs.webkit.org/show_bug.cgi?id=197790

Reviewed by Alexey Proskuryakov.

  • extensions/Trac/Config.pm: Added.
  • extensions/Trac/Extension.pm: Added.

(bug_format_comment):
(_replace_revision):

3:42 PM Changeset in webkit [245260] by ysuzuki@apple.com
  • 3 edits in trunk/Source/WTF

[WTF] Remove Threading workaround for support libraries in Windows
​https://bugs.webkit.org/show_bug.cgi?id=197350

Reviewed by Darin Adler.

We kept old APIs for some support libraries at 2017. This patch removes them.

  • wtf/Threading.h:
  • wtf/win/ThreadingWin.cpp:

(WTF::createThread): Deleted.
(WTF::waitForThreadCompletion): Deleted.

3:36 PM Changeset in webkit [245259] by Alan Coon
  • 1 copy in tags/Safari-608.1.24.2

Tag Safari-608.1.24.2.

3:32 PM Changeset in webkit [245258] by ysuzuki@apple.com
  • 20 edits in trunk/Source

[WTF] Simplify GCThread and CompilationThread flags by adding them to WTF::Thread
​https://bugs.webkit.org/show_bug.cgi?id=197146

Reviewed by Saam Barati.

Source/JavaScriptCore:

Rename Heap::Thread to Heap::HeapThread to remove conflict between WTF::Thread.

  • heap/AlignedMemoryAllocator.cpp:

(JSC::AlignedMemoryAllocator::registerDirectory):

  • heap/Heap.cpp:

(JSC::Heap::HeapThread::HeapThread):
(JSC::Heap::Heap):
(JSC::Heap::runCurrentPhase):
(JSC::Heap::runBeginPhase):
(JSC::Heap::resumeThePeriphery):
(JSC::Heap::requestCollection):
(JSC::Heap::isCurrentThreadBusy):
(JSC::Heap::notifyIsSafeToCollect):
(JSC::Heap::Thread::Thread): Deleted.

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepth):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::prepareForAllocation):

Source/WebCore:

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity const):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::hasPendingActivity const):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::hasPendingActivity const):

Source/WTF:

Since GCThread and CompilationThread flags exist in WTF, we put these flags into WTF::Thread directly instead of holding them in ThreadSpecific<>.
And this patch removes dependency from Threading.h to ThreadSpecific.h. ThreadSpecific.h's OS threading primitives are moved to ThreadingPrimitives.h,
and Threading.h relies on it instead.

  • wtf/CompilationThread.cpp:

(WTF::isCompilationThread):
(WTF::initializeCompilationThreads): Deleted.
(WTF::exchangeIsCompilationThread): Deleted.

  • wtf/CompilationThread.h:

(WTF::CompilationScope::CompilationScope):
(WTF::CompilationScope::~CompilationScope):
(WTF::CompilationScope::leaveEarly):

  • wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::isMainThreadOrGCThread):
(WTF::initializeGCThreads): Deleted.
(WTF::registerGCThread): Deleted.
(WTF::mayBeGCThread): Deleted.

  • wtf/MainThread.h:
  • wtf/ThreadSpecific.h:

(WTF::canBeGCThread>::ThreadSpecific):
(WTF::canBeGCThread>::set):
(WTF::threadSpecificKeyCreate): Deleted.
(WTF::threadSpecificKeyDelete): Deleted.
(WTF::threadSpecificSet): Deleted.
(WTF::threadSpecificGet): Deleted.

  • wtf/Threading.cpp:

(WTF::Thread::exchangeIsCompilationThread):
(WTF::Thread::registerGCThread):
(WTF::Thread::mayBeGCThread):

  • wtf/Threading.h:

(WTF::Thread::isCompilationThread const):
(WTF::Thread::gcThreadType const):
(WTF::Thread::joinableState const):
(WTF::Thread::hasExited const):
(WTF::Thread::Thread):
(WTF::Thread::joinableState): Deleted.
(WTF::Thread::hasExited): Deleted.

  • wtf/ThreadingPrimitives.h:

(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
(WTF::threadSpecificSet):
(WTF::threadSpecificGet):

  • wtf/win/ThreadSpecificWin.cpp:

(WTF::flsKeys):

3:16 PM Changeset in webkit [245257] by Devin Rousso
  • 3 edits
    16 adds
    2 deletes in trunk/LayoutTests

[ Mac Debug ] Layout Test inspector/audit/basic.html is a flaky timeout on bots
​https://bugs.webkit.org/show_bug.cgi?id=196448
<rdar://problem/49485452>

Reviewed by Alex Christensen.

Split inspector/audit/basic.html into separate tests so each part can run without timing out.

  • inspector/audit/basic-async.html: Added.
  • inspector/audit/basic-async-expected.txt: Added.
  • inspector/audit/basic-boolean.html: Added.
  • inspector/audit/basic-boolean-expected.txt: Added.
  • inspector/audit/basic-debugger.html: Added.
  • inspector/audit/basic-debugger-expected.txt: Added.
  • inspector/audit/basic-error.html: Added.
  • inspector/audit/basic-error-expected.txt: Added.
  • inspector/audit/basic-object.html: Added.
  • inspector/audit/basic-object-expected.txt: Added.
  • inspector/audit/basic-promise.html: Added.
  • inspector/audit/basic-promise-expected.txt: Added.
  • inspector/audit/basic-string.html: Added.
  • inspector/audit/basic-string-expected.txt: Added.
  • inspector/audit/basic-timeout.html: Added.
  • inspector/audit/basic-timeout-expected.txt: Added.
  • inspector/audit/basic.html: Removed.
  • inspector/audit/basic-expected.txt: Removed.
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
3:07 PM Changeset in webkit [245256] by Devin Rousso
  • 2 edits in trunk/LayoutTests

[ Mac WK2 ] Layout Test js/dom/unhandled-promise-rejection-bindings-type-error.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=195969
<rdar://problem/49039441>

Reviewed by Alex Christensen.

  • js/dom/unhandled-promise-rejection-bindings-type-error.html:
3:01 PM Changeset in webkit [245255] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebKit

Take out MediaPlayback UI assertion when any WebProcess is playing audible media
​https://bugs.webkit.org/show_bug.cgi?id=197798

Reviewed by Chris Dumez.

To keep the system from suspending the UIProcess (and all the other constellation of processes that
are necessary to play media), take a UIProcess assertion with the MediaPlayback reason whenever there
is a WebContent process that is playing audible media.

  • Platform/spi/ios/AssertionServicesSPI.h:
  • UIProcess/ProcessAssertion.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updatePlayingMediaDidChange):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setWebProcessIsPlayingAudibleMedia):
(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::webPageMediaStateDidChange):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::toBKSProcessAssertionReason):
(WebKit::ProcessAssertion::ProcessAssertion):

  • WebProcess/WebProcess.h:
3:00 PM Changeset in webkit [245254] by ysuzuki@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, follow-up after r245214
​https://bugs.webkit.org/show_bug.cgi?id=197730

Suggested by Sam. We should have static_assert with MACH_VM_MAX_ADDRESS.

  • wtf/WTFAssertions.cpp:
2:52 PM Changeset in webkit [245253] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
​https://bugs.webkit.org/show_bug.cgi?id=197760

Reviewed by Jer Noble.

Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

2:48 PM Changeset in webkit [245252] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Crash when trying to QuickLook
​https://bugs.webkit.org/show_bug.cgi?id=197853
<rdar://problem/49795964>

Reviewed by Brent Fulgham.

This is caused by a syscall sandbox violation.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
2:34 PM Changeset in webkit [245251] by sbarati@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

macro assembler code-pointer tagging has its arguments backwards
​https://bugs.webkit.org/show_bug.cgi?id=197677

Reviewed by Michael Saboff.

We had the destination as the leftmost instead of the rightmost argument,
which goes against the convention of how we order arguments in macro assembler
methods.

  • assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::tagReturnAddress):
(JSC::MacroAssemblerARM64E::untagReturnAddress):
(JSC::MacroAssemblerARM64E::tagPtr):
(JSC::MacroAssemblerARM64E::untagPtr):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • ftl/FTLThunks.cpp:

(JSC::FTL::genericGenerationThunkGenerator):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::prepareForTailCallSlow):

  • jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareForTailCall):

  • jit/ThunkGenerators.cpp:

(JSC::emitPointerValidation):
(JSC::arityFixupGenerator):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

2:06 PM Changeset in webkit [245250] by Megan Gardner
  • 13 edits in trunk/LayoutTests

Alter Conic Gradient tests to be less subject to noise
​https://bugs.webkit.org/show_bug.cgi?id=197806
<rdar://problem/47272067>

Reviewed by Wenson Hsieh.

There is a currently a bug where there's a lot of detectable noise in
the green gradients. Replace them with the less noisy magenta or blue.
<rdar://problem/50682535>

  • fast/gradients/conic-extended-stops-expected.html:
  • fast/gradients/conic-extended-stops.html:
  • fast/gradients/conic-from-angle-expected.html:
  • fast/gradients/conic-from-angle.html:
  • fast/gradients/conic-gradient-expected.html:
  • fast/gradients/conic-gradient-extended-stops-expected.html:
  • fast/gradients/conic-gradient-extended-stops.html:
  • fast/gradients/conic-gradient.html:
  • fast/gradients/conic-off-center-expected.html:
  • fast/gradients/conic-off-center.html:
  • fast/gradients/conic-two-hints-expected.html:
  • fast/gradients/conic-two-hints.html:
1:52 PM Changeset in webkit [245249] by Tadeu Zagallo
  • 5 edits
    1 add in trunk

JSObject::getOwnPropertyDescriptor is missing an exception check
​https://bugs.webkit.org/show_bug.cgi?id=197693
JSTests:

<rdar://problem/50441784>

Reviewed by Saam Barati.

  • stress/proxy-spread.js: Added.

(foo):

Source/JavaScriptCore:

<rdar://problem/50441784>

Reviewed by Saam Barati.

The method table call to getOwnPropertySlot might throw, and JSObject::getOwnPropertyDescriptor
must handle the exception before calling PropertySlot::getValue, which can also throw.

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

Source/WebCore:

Reviewed by Saam Barati.

JSObject::getOwnPropertyDescriptor assumes that getOwnPropertySlot returns false
if an exception is thrown, but that was not true for JSLocation::getOwnPropertySlotCommon.

This is already covered by http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

  • bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::JSLocation::getOwnPropertySlot):
(WebCore::JSLocation::getOwnPropertySlotByIndex):

1:20 PM Changeset in webkit [245248] by achristensen@apple.com
  • 8 edits in trunk/Source/ThirdParty/ANGLE

Build more ANGLE files
​https://bugs.webkit.org/show_bug.cgi?id=197787

Reviewed by Simon Fraser.

  • ANGLE.xcodeproj/project.pbxproj:
  • src/gpu_info_util/SystemInfo.cpp:

(angle::ParseMacMachineModel):

  • src/gpu_info_util/SystemInfo_mac.mm:

(angle::GetSystemInfo):

  • src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
  • src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.mm:

(rx::IOSurfaceSurfaceCGL::IOSurfaceSurfaceCGL):
(rx::IOSurfaceSurfaceCGL::validateAttributes):

  • src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h:
  • src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:

(rx::WindowSurfaceCGL::initialize):
(-[SwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.

1:10 PM Changeset in webkit [245247] by Alan Coon
  • 2 edits in branches/safari-608.1.24-branch/Source/WebKit

Cherry-pick r245246. rdar://problem/50727815

Correct the sandbox to allow loading libraries from /Library/Apple
​https://bugs.webkit.org/show_bug.cgi?id=197844

Reviewed by Per Arne Vollan.

Grant access to '/Library/Apple' as an appropriate place to load
system frameworks.

  • WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:53 PM Changeset in webkit [245246] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Correct the sandbox to allow loading libraries from /Library/Apple
​https://bugs.webkit.org/show_bug.cgi?id=197844

Reviewed by Per Arne Vollan.

Grant access to '/Library/Apple' as an appropriate place to load
system frameworks.

  • WebProcess/com.apple.WebProcess.sb.in:
12:40 PM Changeset in webkit [245245] by Chris Dumez
  • 33 edits in trunk/Source/WebKit

Unreviewed, rolling out r245240.

Broke the build

Reverted changeset:

"Update TBA macros for API / SPI that has already shipped"
​https://bugs.webkit.org/show_bug.cgi?id=197841
​https://trac.webkit.org/changeset/245240

12:38 PM Changeset in webkit [245244] by youenn@apple.com
  • 4 edits in trunk/Source

Use kDNSServiceFlagsKnownUnique for DNSServiceRegisterRecord only on platforms supporting it
​https://bugs.webkit.org/show_bug.cgi?id=197802

Reviewed by Eric Carlson.

Source/WebKit:

  • NetworkProcess/webrtc/NetworkMDNSRegister.cpp:

(WebKit::NetworkMDNSRegister::registerMDNSName):

Source/WTF:

  • wtf/Platform.h:
12:09 PM Changeset in webkit [245243] by don.olmstead@sony.com
  • 3 edits in trunk/Source/WebKit

decidePolicyForInstallMissingMediaPluginsPermissionRequest requires GStreamer
​https://bugs.webkit.org/show_bug.cgi?id=197843

Reviewed by Alex Christensen.

  • UIProcess/API/wpe/PageClientImpl.cpp:

ENABLE(VIDEO) && USE(GSTREAMER)

  • UIProcess/WebPageProxy.h:

Cleanup the declaration.

11:13 AM Changeset in webkit [245242] by Antti Koivisto
  • 4 edits
    4 adds in trunk

REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=197818
<rdar://problem/50705762>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/scrolling/ios/event-region-scale-transform-shared.html

fast/scrolling/ios/event-region-translate-transform-shared.html

This fixes the assert. However the added tests demonstrate that transform is not taken into account
when computing the event region, ​https://bugs.webkit.org/show_bug.cgi?id=197836.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

LayoutTests:

  • fast/scrolling/ios/event-region-scale-transform-shared-expected.txt: Added.
  • fast/scrolling/ios/event-region-scale-transform-shared.html: Added.
  • fast/scrolling/ios/event-region-translate-transform-shared-expected.txt: Added.
  • fast/scrolling/ios/event-region-translate-transform-shared.html: Added.
  • platform/ios-wk2/TestExpectations:
11:04 AM Changeset in webkit [245241] by don.olmstead@sony.com
  • 7 edits in trunk/Source/WebKit

Move StorageManager.cpp into WebKit/Sources.txt
​https://bugs.webkit.org/show_bug.cgi?id=197842

Reviewed by Michael Catanzaro.

StorageManager.cpp is used by all ports so it should just go into Sources.txt.

  • PlatformMac.cmake:
  • PlatformWin.cmake:
  • Sources.txt:
  • SourcesCocoa.txt:
  • SourcesGTK.txt:
  • SourcesWPE.txt:
10:56 AM Changeset in webkit [245240] by Chris Dumez
  • 33 edits in trunk/Source/WebKit

Update TBA macros for API / SPI that has already shipped
​https://bugs.webkit.org/show_bug.cgi?id=197841
<rdar://problem/50698499>

Reviewed by Alex Christensen.

  • Shared/API/Cocoa/_WKRenderingProgressEvents.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.h:
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
  • UIProcess/API/Cocoa/WKBrowsingContextHistoryDelegate.h:
  • UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
  • UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
  • UIProcess/API/Cocoa/WKConnection.h:
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKProcessGroup.h:
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/API/Cocoa/WKTypeRefWrapper.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKView.h:

(WK_CLASS_DEPRECATED_WITH_REPLACEMENT):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/API/Cocoa/_WKAttachment.h:
  • UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
  • UIProcess/API/Cocoa/_WKDownload.h:
  • UIProcess/API/Cocoa/_WKFormInputSession.h:
  • UIProcess/API/Cocoa/_WKInspector.h:
  • UIProcess/API/Cocoa/_WKInternalDebugFeature.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.h:
  • WebProcess/API/Cocoa/WKWebProcess.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
10:32 AM Changeset in webkit [245239] by ysuzuki@apple.com
  • 21 edits in trunk/Source

[JSC] Compress miscelaneous JIT related data structures with Packed<>
​https://bugs.webkit.org/show_bug.cgi?id=197830

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch leverages Packed<> to compress miscelaneous data structures related to JIT.

  1. JIT IC data structures
  1. ValueRecovery

We use Packed<> for EncodedJSValue in ValueRecovery. This means that conservative GC cannot find
these values. But this is OK anyway since ValueRecovery's constant should be already registered
in DFG graph. From 16 (alignment 8) to 9 (alignment 1).

  1. FTL::ExitValue

We use Packed<> for EncodedJSValue in FTL::ExitValue. This is also OK since this constant should
be already registered by DFG/FTL graph. From 16 (alignment 8) to 9 (alignment 1).

  • assembler/CodeLocation.h:
  • bytecode/ByValInfo.h:
  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::callReturnLocation):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::nearCallMode const):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addJITAddIC):
(JSC::CodeBlock::addJITMulIC):
(JSC::CodeBlock::addJITSubIC):
(JSC::CodeBlock::addJITNegIC):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addMathIC):

  • bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::InlineCallFrame):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::directArgumentsThatWereNotCreated):
(JSC::ValueRecovery::clonedArgumentsThatWereNotCreated):
(JSC::ValueRecovery::gpr const):
(JSC::ValueRecovery::tagGPR const):
(JSC::ValueRecovery::payloadGPR const):
(JSC::ValueRecovery::fpr const):
(JSC::ValueRecovery::virtualRegister const):
(JSC::ValueRecovery::withLocalsOffset const):
(JSC::ValueRecovery::constant const):
(JSC::ValueRecovery::nodeID const):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueNegate):
(JSC::DFG::SpeculativeJIT::compileValueMul):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::materializeNewObject):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsInt52):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::exitArgument const):
(JSC::FTL::ExitValue::adjustStackmapLocationsIndexByOffset):
(JSC::FTL::ExitValue::constant const):
(JSC::FTL::ExitValue::virtualRegister const):
(JSC::FTL::ExitValue::objectMaterialization const):
(JSC::FTL::ExitValue::withVirtualRegister const):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):

  • jit/CachedRecovery.h:
  • jit/CallFrameShuffleData.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_sub):

  • jit/JITMathIC.h:

(JSC::isProfileEmpty):
(JSC::JITBinaryMathIC::JITBinaryMathIC):
(JSC::JITUnaryMathIC::JITUnaryMathIC):

  • jit/PolymorphicCallStubRoutine.h:

(JSC::PolymorphicCallNode::hasCallLinkInfo):

  • jit/SnippetOperand.h:

(JSC::SnippetOperand::asRawBits const):
(JSC::SnippetOperand::asConstInt32 const):
(JSC::SnippetOperand::asConstDouble const):
(JSC::SnippetOperand::setConstInt32):
(JSC::SnippetOperand::setConstDouble):

Source/WTF:

  • wtf/Packed.h:

(WTF::alignof):

9:52 AM Changeset in webkit [245238] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

[macOS] Font formatting options don't work when composing a message in Yahoo mail
​https://bugs.webkit.org/show_bug.cgi?id=197813
<rdar://problem/49382250>

Reviewed by Darin Adler.

Source/WebCore:

The bug happens because on mousedown, the "Aa Font" menu item's event handler hides itself before changing the
font at the text selection. This causes us to clear the selection in FocusController::setFocusedElement.

There is existing logic in clearSelectionIfNeeded that would normally prevent us from clearing the selection due
to the mousePressNode not being able to start a selection. However, since the clickable element in this case is
hidden during mousedown, it is missing a renderer, and we bail from the `mousePressNode->renderer() &&
!mousePressNode->canStartSelection()` check as a result.

This check was orginally added in ​https://trac.webkit.org/r24334 to avoid clearing the selection when clicking
a button; the intention appears to have been making it so that clicking on something that could not start a
selection (back then, synonymous with -webkit-user-select: ignore;) would not clear the current selection; to
this end, it seems odd to additionally require that the thing being clicked should still have a renderer, so
it seems safe to remove this requirement.

Test: editing/selection/preserve-selection-when-clicking-button.html

  • page/FocusController.cpp:

(WebCore::clearSelectionIfNeeded):

LayoutTests:

Add a new layout test to verify that DOM selection is preserved after clicking a button that hides itself
upon mousedown.

  • editing/selection/preserve-selection-when-clicking-button-expected.txt: Added.
  • editing/selection/preserve-selection-when-clicking-button.html: Added.
9:32 AM Changeset in webkit [245237] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit

AX: Need an entitlement for WebContent to send accessibility notifications
​https://bugs.webkit.org/show_bug.cgi?id=197832

Reviewed by Brent Fulgham.

In order to send accessibility notifications on iOS, we need to be able to look up this port.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
9:30 AM Changeset in webkit [245236] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=197793
<rdar://problem/46429187>

Unreviewed, build fix after r245199.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):

8:39 AM Changeset in webkit [245235] by sihui_liu@apple.com
  • 2 edits in trunk/LayoutTests

[ Mojave Debug ] REGRESSION (r242975) Layout Test imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex7-event_order.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=195961
<rdar://problem/49031397>

Reviewed by Youenn Fablet.

r244674 should have fixed this regression.

  • platform/mac-wk2/TestExpectations:
8:39 AM Changeset in webkit [245234] by Michael Catanzaro
  • 4 edits in trunk/Source

Unreviewed, fix unused variable warnings in release builds

Source/WebKit:

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearWebProcessHasUploads):

Source/WTF:

  • wtf/URLHelpers.cpp:

(WTF::URLHelpers::escapeUnsafeCharacters):

6:59 AM Changeset in webkit [245233] by Darin Adler
  • 4 edits in trunk/Source/WebCore

WHLSLPrepare.cpp always recompiles, even if nothing was changed
​https://bugs.webkit.org/show_bug.cgi?id=197151

Reviewed by Dan Bernstein and Keith Rollin.

  • DerivedSources-input.xcfilelist: Script updated this automatically after

DerivedSources.make was corrected.

  • DerivedSources-output.xcfilelist: Ditto, although I had to manually remove

one bogus leftover reference to WHLSLStandardLibrary.cpp.

  • DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to

no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
was running on every build, instead of only when one of the dependencies changed.

1:10 AM WebKitGTK/2.24.x edited by cturner@igalia.com
(diff)

May 12, 2019:

11:51 PM Changeset in webkit [245232] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.24-branch/Source/WebCore

Cherry-pick r245197. rdar://problem/50628434

Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
​https://bugs.webkit.org/show_bug.cgi?id=197760

Reviewed by Jer Noble.

We have all the data we need, and this crash is happening more than
expected.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245231] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.24-branch/Source/WebKit

Cherry-pick r245195. rdar://problem/46548586

Returning incorrect marked text rects
​https://bugs.webkit.org/show_bug.cgi?id=197758
<rdar://problem/46548586>

Reviewed by Tim Horton.

We are not returning marked text rects in the correct view coordinate space.
This is the same translation we are applying to the caret rects.

  • WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformEditorState const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245230] by bshafiei@apple.com
  • 3 edits
    2 adds in branches/safari-608.1.24-branch

Cherry-pick r245191. rdar://problem/48027412

[iOS] baidu.com: Synthetic bold renders too far apart, appears doubled.
​https://bugs.webkit.org/show_bug.cgi?id=197781
<rdar://problem/48027412>

Reviewed by Simon Fraser.

Source/WebCore:

Synthetic bold is essentially two regular glyphs painted with an offset. While on macOS this offset is always 1px (CSS), on iOS larger font produces higher offset value. At paint time, this offset value (in CSS px unit) get converted
to a device pixel value taking context scale into account. This conversion ensures that the gap between the 2 regular glyphs won't get wider (in device pixels) as the user pinch zooms in.
This works as long as the scale on the context is >= 1. This patch ensures that a scaled down context won't blow up this gap.

Test: fast/text/large-synthetic-bold-with-scale-transform.html

  • platform/graphics/cocoa/FontCascadeCocoa.mm: (WebCore::FontCascade::drawGlyphs):

LayoutTests:

  • fast/text/large-synthetic-bold-with-scale-transform-expected.html: Added.
  • fast/text/large-synthetic-bold-with-scale-transform.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245229] by bshafiei@apple.com
  • 5 edits in branches/safari-608.1.24-branch/Source/WebKit

Cherry-pick r245189. rdar://problem/50646747

Let WebKit clients supply an application name for user agent in modern compatibility mode
​https://bugs.webkit.org/show_bug.cgi?id=197782
<rdar://problem/50646747>

Reviewed by Beth Dakin.

Add plumbing for a new private property on WKWebpagePreferences.

  • UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const):
  • UIProcess/API/APIWebsitePolicies.h:
  • UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]): (-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
  • UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245228] by bshafiei@apple.com
  • 17 edits in branches/safari-608.1.24-branch/Source

Cherry-pick r245183. rdar://problem/50065100

Add WKWebViewConfiguration._canShowWhileLocked SPI
​https://bugs.webkit.org/show_bug.cgi?id=197777
<rdar://problem/50065100>

Reviewed by Tim Horton.

Source/WebCore/PAL:

  • pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm: (WebKit::LayerHostingContext::createForExternalHostingProcess):
  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::copy const):
  • UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::canShowWhileLocked const): (API::PageConfiguration::setCanShowWhileLocked):
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration _setCanShowWhileLocked:]): (-[WKWebViewConfiguration _canShowWhileLocked]):
  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters):
  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: (WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::canShowWhileLocked const):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::m_canShowWhileLocked): (WebKit::m_shrinkToFitContentTimer): Deleted.
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::canShowWhileLocked const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245227] by bshafiei@apple.com
  • 3 edits in branches/safari-608.1.24-branch/Source/WebKit

Cherry-pick r245153. rdar://problem/50604700

Guard long press link preview with a USE macro rather than complicated includes
​https://bugs.webkit.org/show_bug.cgi?id=197728
<rdar://problem/50604700>

Reviewed by Wenson Hsieh.

It was getting complicated to manage the coordination between WebKitAdditions
and WebKit without having to split up the includes into multiple files
or have lots of duplication.

Instead, WebKitAdditions will now define a USE macro which can be used
in various places through WebKit.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView dragInteraction:itemsForBeginningSession:]): (-[WKContentView _contentsOfUserInterfaceItem:]): (previewIdentifierForElementAction): (-[WKContentView shouldUsePreviewForLongPress]): (-[WKContentView _registerPreview]): (-[WKContentView _unregisterPreview]): (shouldUsePreviewForLongPress): Deleted. (-[WKContentView _registerPreviewLongPress]): Deleted. (-[WKContentView _unregisterPreviewLongPress]): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245226] by bshafiei@apple.com
  • 2 edits in branches/safari-608.1.24-branch/Source/WebKit

Cherry-pick r245148. rdar://problem/50457731

REGRESSION (r241734): 1% slower PLT on iPad
​https://bugs.webkit.org/show_bug.cgi?id=197745
<rdar://problem/50457731>

Reviewed by Per Arne Vollan.

For now, only create a keyboard when WKContentView becomes first responder if a hardware keyboard
is attached or an editable element is focused to recover the 1% loss when a keyboard is not attached.
We can do better and by that I mean be lazier. We'll do this <​https://bugs.webkit.org/show_bug.cgi?id=197746>.

In r241734 we unified the key event handling code paths so we use exactly one for both software and
hardware key events. We took a simple approach of always requesting UIKit to create a keyboard when
the WKContentView becomes first responder. We did this so that we could continue listening for hardware
key events even when a non-editable element is focused and dispatch DOM events. As it turns out, always
creating a keyboard is expensive and caused a ~1% slowdown in page load time on iPad.

  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _requiresKeyboardWhenFirstResponder]): Only create a keyboard if a hardware keyboard is attached or an editable element is focused. (-[WKContentView _hardwareKeyboardAvailabilityChanged]): Reload all input view (this will cause keyboard creation) if -_requiresKeyboardWhenFirstResponder returns YES.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 PM Changeset in webkit [245225] by bshafiei@apple.com
  • 8 edits
    4 adds in branches/safari-608.1.24-branch

Cherry-pick r245144. rdar://problem/47902054

[iOS] Unable to commit search on MSN.com, qq.com, or sina.com.cn using enter key (hardware or software keyboard)
​https://bugs.webkit.org/show_bug.cgi?id=197632
<rdar://problem/47902054>

Reviewed by Brent Fulgham.

Source/WebKit:

Fixes an issue where it is not possible to submit a <form> with target = "_blank": a form that
opens a new window.

By default we only allow popups to open if they were user initiated (like when a person clicks
on a link). We achieve this by putting a token on the stack, called the UserGestureToken when
WebCore processes an event from WebKit. So long as this token is on the stack we consider
all requests to open a popup to be user initiated. And we implicitly submit a form when pressing
the Return key in an HTML input element during the processing of a TextInputEvent dispatched as
part of inserting a '\n' into the field. On Mac, the keydown dispatches a TextInputEvent synchronously.
However on iOS text insertion, and hence a dispatch of a TextInputEvent event, occurs asynchronously
with respect to the keydown event. So, by the time the UI process calls back to the WebProcess
to perform the text insertion of '\n' we have long since popped the UserGestureToken off the stack
and hence we disallow opening a popup. To fix this, when -insertText is called we query the keyboard
to determine if it's being called by the keyboard. If it is then we can assume that this is
part of key event handling and hence was initiated by the user. We can pass along this detail
to the WebProcess for it to push a new UserGestureToken onto the stack.

For now we only track whether text inserted by the keyboard was user initiated or not. In
<​https://bugs.webkit.org/show_bug.cgi?id=197721> we will fix this up for all editing commands.

  • Platform/spi/ios/UIKitSPI.h: Expose SPI.
  • Shared/Cocoa/InsertTextOptions.cpp: (IPC::ArgumentCoder<WebKit::InsertTextOptions>::encode): (IPC::ArgumentCoder<WebKit::InsertTextOptions>::decode): Encode and decode whether we are processing a user gesture.
  • Shared/Cocoa/InsertTextOptions.h:
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView insertText:]): Query the keyboard to determine whether it called us or the embedding client did. We only want to privilege user initiated actions (the keyboard).
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::insertTextAsync): Push a UserGestureToken onto the stack that is initialized depending on whether we are or are not processing a user gesture.

LayoutTests:

Add tests to ensure we fire input and keypress events in the correct order and that we can
submit a <form> with target = "_blank" using the Return key.

  • fast/events/ios/fire-input-and-keypress-on-return-key-expected.txt: Added.
  • fast/events/ios/fire-input-and-keypress-on-return-key.html: Added.
  • fast/events/ios/submit-form-target-blank-using-return-key-expected.txt: Added.
  • fast/events/ios/submit-form-target-blank-using-return-key.html: Added.
  • platform/ios/TestExpectations: Skip the test until we have the UIKit SPI added in <rdar://problem/50596032>.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@245144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:30 PM Changeset in webkit [245224] by bshafiei@apple.com
  • 7 edits in branches/safari-608.1.24-branch/Source

Versioning.

11:15 PM Changeset in webkit [245223] by bshafiei@apple.com
  • 7 edits in tags/Safari-608.1.23.1/Source

Versioning.

11:07 PM Changeset in webkit [245222] by bshafiei@apple.com
  • 1 copy in tags/Safari-608.1.23.1

Tag Safari-608.1.23.1.

9:13 PM Changeset in webkit [245221] by Simon Fraser
  • 2 edits in trunk/LayoutTests

REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=197818

Approved by Jon Lee.

Skip this test until a fix for bug 197818 lands.

  • platform/ios-wk2/TestExpectations:
8:57 PM Changeset in webkit [245220] by Simon Fraser
  • 3 edits
    2 adds in trunk

When the set of backing-sharing layers changes, we need to issue a repaint
​https://bugs.webkit.org/show_bug.cgi?id=197825

Reviewed by Zalan Bujtas.

Source/WebCore:

If the set of layers painting into a shared backing store changes, we need
to repaint that backing store. This happens when scrolling as shared layers
enter the visible area.

Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setBackingSharingLayers):

LayoutTests:

  • compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
  • compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
8:07 PM Changeset in webkit [245219] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Add logging for RenderLayer clip rects
​https://bugs.webkit.org/show_bug.cgi?id=197547

Reviewed by Zalan Bujtas.

Add a ClipRects log channel, and stream output for ClipRect and ClipRects.

The ClipRect code is performance sensitive, even in debug, so guard the log sites
with clipRectsLogEnabled() because the macro still evaluates its arguments even if
the channel is disabled (we need some better way to log that doesn't do this).

  • platform/Logging.h:
  • rendering/ClipRect.cpp:

(WebCore::operator<<):

  • rendering/ClipRect.h:
  • rendering/RenderLayer.cpp:

(WebCore::operator<<):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
8:01 PM Changeset in webkit [245218] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Refactor composited backing-sharing code
​https://bugs.webkit.org/show_bug.cgi?id=197824

Reviewed by Zalan Bujtas.

Clean up the backing-sharing code to share more code, and make it easier to understand.

Moves more logic into member functions on BackingSharingState, which are named to make
their functions clearer: startBackingSharingSequence/endBackingSharingSequence.

computeCompositingRequirements() and traverseUnchangedSubtree() now just call
updateBeforeDescendantTraversal/updateAfterDescendantTraversal.

No behavior change.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::willBeDestroyed):
(WebCore::RenderLayerBacking::setBackingSharingLayers): Remove the early return, since
we need to call setBackingProviderLayer() on the sharing layers in both code paths.
(WebCore::RenderLayerBacking::removeBackingSharingLayer):
(WebCore::RenderLayerBacking::clearBackingSharingLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::BackingSharingState::backingProviderCandidate const):
(WebCore::RenderLayerCompositor::BackingSharingState::appendSharingLayer):
(WebCore::RenderLayerCompositor::BackingSharingState::startBackingSharingSequence):
(WebCore::RenderLayerCompositor::BackingSharingState::endBackingSharingSequence):
(WebCore::RenderLayerCompositor::BackingSharingState::updateBeforeDescendantTraversal):
(WebCore::RenderLayerCompositor::BackingSharingState::updateAfterDescendantTraversal):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::BackingSharingState::resetBackingProviderCandidate): Deleted.

  • rendering/RenderLayerCompositor.h:
7:57 PM Changeset in webkit [245217] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Use clampTo in AVVideoCaptureSource::setSizeAndFrameRateWithPreset
​https://bugs.webkit.org/show_bug.cgi?id=197704

Reviewed by Alex Christensen.

Use clampTo as suggested in bug 196214 review.
No change of behavior.

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):

7:56 PM Changeset in webkit [245216] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

Use the main screen for screen capture
​https://bugs.webkit.org/show_bug.cgi?id=197804
<rdar://problem/47671383>

Reviewed by Eric Carlson.

If the main screen, i.e. the screen that has focus at the time of
selection of the screen to capture, is capturable, add it to the list
of screen devices, but do not add any other screen.
This will make sure the main screen is selected.
Manually tested.

  • platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDevices):

4:05 PM Changeset in webkit [245215] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

[Curl] Suppress extra didReceiveAuthenticationChallenge call when accessing a server which checks basic auth.
​https://bugs.webkit.org/show_bug.cgi?id=197650

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2019-05-12
Reviewed by Fujii Hironori.

Source/WebCore:

When Curl port accesses a page which checks Basic Authentication credential and server trust challenge occurs,
Curl port calls extra didReceiveAuthenticationChallenge unnecessarily.
This is because Curl port discards information about allowed server trust challenge before in NetworkDataTaskCurl::restartWithCredential.

Test: http/tests/ssl/curl/certificate-and-authentication.html

  • platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::isServerTrustEvaluationDisabled):

Source/WebKit:

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::restartWithCredential):

LayoutTests:

  • TestExpectations:
  • http/tests/resources/basic-auth.php: Added.
  • http/tests/ssl/curl/certificate-and-authentication-expected.txt: Added.
  • http/tests/ssl/curl/certificate-and-authentication.html: Added.
  • platform/wincairo-wk1/TestExpectations:
  • platform/wincairo/TestExpectations:
3:50 PM Changeset in webkit [245214] by ysuzuki@apple.com
  • 33 edits
    5 adds in trunk

[JSC] Compress Watchpoint size by using enum type and Packed<> data structure
​https://bugs.webkit.org/show_bug.cgi?id=197730

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Watchpoint takes 5~ MB memory in Gmail (total memory starts with 400 - 500 MB), so 1~%. Since it is allocated massively,
reducing each size of Watchpoint reduces memory footprint significantly.

As a first step, this patch uses Packed<> and enum to reduce the size of Watchpoint.

  1. Watchpoint should have enum type and should not use vtable. vtable takes one pointer, and it is too costly for such a memory sensitive objects. We perform downcast and dispatch the method of the derived classes based on this enum. Since the # of derived Watchpoint classes are limited (Only 8), we can list up them easily. One unfortunate thing is that we cannot do this for destructor so long as we use "delete" for deleting objects. If we dispatch the destructor of derived class in the destructor of the base class, we call the destructor of the base class multiple times. delete operator override does not help since custom delete operator is called after the destructor is called. While we can fix this issue by always using custom deleter, currently we do not since all the watchpoints do not have members which have non trivial destructor. Once it is strongly required, we can start using custom deleter, but for now, we do not need to do this.
  1. We use Packed<> to compact pointers in Watchpoint. Since Watchpoint is a node of doubly linked list, each one has two pointers for prev and next. This is also too costly. PackedPtr reduces the size and makes alignment 1.S
  1. We use PackedCellPtr<> for JSCells in Watchpoint. This leverages alignment information and makes pointers smaller in Darwin ARM64. One important thing to note here is that since this pointer is packed, it cannot be found by conservative GC scan. It is OK for watchpoint since they are allocated in the heap anyway.

We applied this change to Watchpoint and get the following memory reduction. The highlight is that CodeBlockJettisoningWatchpoint in
ARM64 only takes 2 pointers size.

ORIGINAL X86_64 ARM64

WatchpointSet: 40 32 28
CodeBlockJettisoningWatchpoint: 32 19 15
StructureStubClearingWatchpoint: 56 48 40
AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint: 24 13 11
AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint: 24 13 11
FunctionRareData::AllocationProfileClearingWatchpoint: 32 19 15
ObjectToStringAdaptiveStructureWatchpoint: 56 48 40
LLIntPrototypeLoadAdaptiveStructureWatchpoint: 64 48 48
DFG::AdaptiveStructureWatchpoint: 56 48 40

While we will re-architect the mechanism of Watchpoint, anyway Packed<> mechanism and enum types will be used too.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
  • bytecode/CodeBlockJettisoningWatchpoint.h:
  • bytecode/CodeOrigin.h:
  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
  • bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::fireInternal):

  • bytecode/StructureStubClearingWatchpoint.h:
  • bytecode/Watchpoint.cpp:

(JSC::Watchpoint::fire):

  • bytecode/Watchpoint.h:

(JSC::Watchpoint::Watchpoint):

  • dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::AdaptiveStructureWatchpoint):

  • dfg/DFGAdaptiveStructureWatchpoint.h:
  • heap/PackedCellPtr.h: Added.
  • runtime/FunctionRareData.h:
  • runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp: Added.

(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):

  • runtime/ObjectToStringAdaptiveStructureWatchpoint.h: Added.
  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::clearObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint): Deleted.
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install): Deleted.
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal): Deleted.

  • runtime/StructureRareData.h:

Source/WTF:

This patch introduces a new data structures, WTF::Packed, WTF::PackedPtr, and WTF::PackedAlignedPtr.

  • WTF::Packed

WTF::Packed is data storage. We can read and write trivial (in C++ term [1]) data to this storage. The difference to
the usual storage is that the alignment of this storage is always 1. We access the underlying data by using unalignedLoad/unalignedStore.
This class offers alignment = 1 data structure instead of missing the following characteristics.

  1. Load / Store are non atomic even if the data size is within a pointer width. We should not use this for a member which can be accessed in a racy way. (e.g. fields accessed optimistically from the concurrent compilers).
  1. We cannot take reference / pointer to the underlying storage since they are unaligned.
  1. Access to this storage is unaligned access. The code is using memcpy, and the compiler will convert to an appropriate unaligned access in certain architectures (x86_64 / ARM64). It could be slow. So use it for non performance sensitive & memory sensitive places.
  • WTF::PackedPtr

WTF::PackedPtr is a specialization of WTF::Packed<T*>. And it is basically WTF::PackedAlignedPtr with alignment = 1. We further compact
the pointer by leveraging the platform specific knowledge. In 64bit architectures, the effective width of pointers are less than 64 bit.
In x86_64, it is 48 bits. And Darwin ARM64 is further smaller, 36 bits. This information allows us to compact the pointer to 6 bytes in
x86_64 and 5 bytes in Darwin ARM64.

  • WTF::PackedAlignedPtr

WTF::PackedAlignedPtr is the WTF::PackedPtr with alignment information of the T. If we use this alignment information, we could reduce the
size of packed pointer further in some cases. For example, since we guarantee that JSCells are 16 byte aligned, low 4 bits are empty. Leveraging
this information in Darwin ARM64 platform allows us to make packed JSCell pointer 4 bytes (36 - 4 bits). We do not use passed alignment
information if it is not profitable.

We also have PackedPtrTraits. This is new PtrTraits and use it for various data structures such as Bag<>.

[1]: ​https://en.cppreference.com/w/cpp/types/is_trivial

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Bag.h:

(WTF::Bag::clear):
(WTF::Bag::iterator::operator++):

  • wtf/CMakeLists.txt:
  • wtf/DumbPtrTraits.h:
  • wtf/DumbValueTraits.h:
  • wtf/MathExtras.h:

(WTF::clzConstexpr):
(WTF::clz):
(WTF::ctzConstexpr):
(WTF::ctz):
(WTF::getLSBSetConstexpr):
(WTF::getMSBSetConstexpr):

  • wtf/Packed.h: Added.

(WTF::Packed::Packed):
(WTF::Packed::get const):
(WTF::Packed::set):
(WTF::Packed::operator=):
(WTF::Packed::exchange):
(WTF::Packed::swap):
(WTF::alignof):
(WTF::PackedPtrTraits::exchange):
(WTF::PackedPtrTraits::swap):
(WTF::PackedPtrTraits::unwrap):

  • wtf/Platform.h:
  • wtf/SentinelLinkedList.h:

(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::PtrTraits>::remove):
(WTF::PtrTraits>::prepend):
(WTF::PtrTraits>::append):
(WTF::RawNode>::SentinelLinkedList):
(WTF::RawNode>::remove):
(WTF::BasicRawSentinelNode<T>::remove): Deleted.
(WTF::BasicRawSentinelNode<T>::prepend): Deleted.
(WTF::BasicRawSentinelNode<T>::append): Deleted.

  • wtf/StdLibExtras.h:

(WTF::roundUpToMultipleOfImpl):
(WTF::roundUpToMultipleOfImpl0): Deleted.

  • wtf/UnalignedAccess.h:

(WTF::unalignedLoad):
(WTF::unalignedStore):

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MathExtras.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/Packed.cpp: Added.

(TestWebKitAPI::TEST):

12:43 PM Changeset in webkit [245213] by ysuzuki@apple.com
  • 9 edits
    1 add in trunk/Source/JavaScriptCore

[JSC] Compact generator code's bytecode size
​https://bugs.webkit.org/show_bug.cgi?id=197822

Reviewed by Michael Saboff.

op_put_to_scope's symbolTableOrScopeDepth is represented as int. This was OK for the old bytecode format since
VirtualRegister / scope depth can be represented by int anyway. But it is problematic now since only int8_t range
will be represented in narrow bytecode. When this field is used for symbol table constant index, it is always
larger than FirstConstantRegisterIndex. So it always exceeds the range of int8_t, and results in wide bytecode.
It makes all generator's op_put_to_scope wide bytecode.

In this patch, we introduce a new (logically) union type SymbolTableOrScopeDepth. It holds unsigned value, and we store the
SymbolTableConstantIndex - FirstConstantRegisterIndex in this unsigned value to make op_put_to_scope narrow bytecode.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeGeneratorification.cpp:

(JSC::BytecodeGeneratorification::run):

  • bytecode/BytecodeList.rb:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

  • bytecode/Fits.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::localScopeDepth const):

  • bytecompiler/BytecodeGenerator.h:
  • runtime/SymbolTableOrScopeDepth.h: Added.

(JSC::SymbolTableOrScopeDepth::symbolTable):
(JSC::SymbolTableOrScopeDepth::scopeDepth):
(JSC::SymbolTableOrScopeDepth::raw):
(JSC::SymbolTableOrScopeDepth::symbolTable const):
(JSC::SymbolTableOrScopeDepth::scopeDepth const):
(JSC::SymbolTableOrScopeDepth::raw const):
(JSC::SymbolTableOrScopeDepth::dump const):
(JSC::SymbolTableOrScopeDepth::SymbolTableOrScopeDepth):

Note: See TracTimeline for information about the timeline view.