Timeline
May 14, 2019:
- 10:24 PM Changeset in webkit [245319] by
-
- 9 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245255. rdar://problem/50141840
Take out MediaPlayback UI assertion when any WebProcess is playing audible media
https://bugs.webkit.org/show_bug.cgi?id=197798
Reviewed by Chris Dumez.
To keep the system from suspending the UIProcess (and all the other constellation of processes that
are necessary to play media), take a UIProcess assertion with the MediaPlayback reason whenever there
is a WebContent process that is playing audible media.
- Platform/spi/ios/AssertionServicesSPI.h:
- UIProcess/ProcessAssertion.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updatePlayingMediaDidChange):
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::setWebProcessIsPlayingAudibleMedia): (WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::webPageMediaStateDidChange):
- UIProcess/WebProcessProxy.h:
- UIProcess/ios/ProcessAssertionIOS.mm: (WebKit::toBKSProcessAssertionReason): (WebKit::ProcessAssertion::ProcessAssertion):
- WebProcess/WebProcess.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:23 PM Changeset in webkit [245318] by
-
- 36 edits7 copies39 adds in branches/safari-608.1.24-branch
Cherry-pick r245170. rdar://problem/50445998
Implement backing-sharing in compositing layers, allowing overlap layers to paint into the backing store of another layer
https://bugs.webkit.org/show_bug.cgi?id=197561
<rdar://problem/50445998>
Reviewed by Antti Koivisto.
Source/WebCore:
This change introduces the concept of layers that share backing store for compositing. A layer
which is sharing its backing store first paints itself, and then some set of layers which come
later in paint order in the same stacking context. This reduces the composited layer count in
some overflow scrolling scenarios, thereby also simplifying the scrolling tree.
A backing-shared layer stores a vector of "sharing" RenderLayer* in its RenderLayerBacking. At
paint time, the owning layer is painted, then the sharing layers, setting the owning layer as the
painting root so that positioning and clipping just work.
Sharing layer relationships are constructed in RenderLayerCompositor::computeCompositingRequirements().
We track the last layer which was composited in paint order as a shared candidate. If a later layer
would composite for overlap (and no other reasons), then we allow it to share with the candidate
if the candidate is in its ancestor containing block chain. Sharing is currently limited to layers
in the same stacking context.
isComposited() returns false for sharing layers, but they are like composited layers in that
they behave as painting boundaries, so RenderLayer::paintLayer() needs to stop at them,
and repaints in shared layers have to be directed to their shared layer, hence
changes to RenderLayer::clippingRootForPainting() and RenderLayer::enclosingCompositingLayerForRepaint().
The clipping boundary logic in RenderLayer::backgroundClipRect() needed to be generalized so that
all calls to RenderLayer::parentClipRects() check for crossing painting boundaries and use
TemporaryClipRects in that case.
Tests: compositing/shared-backing/overflow-scroll/absolute-in-stacking-relative-in-scroller.html
compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller.html
compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow.html
compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness.html
compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping.html
compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-relative-clipping.html
compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll.html
compositing/shared-backing/overflow-scroll/scrolled-contents-has-painted-content.html
compositing/shared-backing/overflow-scroll/scrolled-contents-unconstrained-clip.html
compositing/shared-backing/overflow-scroll/shared-layer-clipping.html
compositing/shared-backing/overflow-scroll/shared-layer-composited-bounds.html
compositing/shared-backing/overflow-scroll/shared-layer-nested-relative-stacking.html
compositing/shared-backing/overflow-scroll/shared-layer-repaint.html
compositing/shared-backing/partial-compositing-update.html
compositing/shared-backing/partial-compositing-update2.html
compositing/shared-backing/remove-sharing-layer.html
compositing/shared-backing/sharing-cached-clip-rects.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::ancestorLayerIsInContainingBlockChain const): (WebCore::RenderLayer::setBackingProviderLayer): (WebCore::RenderLayer::disconnectFromBackingProviderLayer): (WebCore::RenderLayer::enclosingCompositingLayerForRepaint const): (WebCore::RenderLayer::clippingRootForPainting const): (WebCore::RenderLayer::clipToRect): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::clipCrossesPaintingBoundary const): (WebCore::RenderLayer::calculateClipRects const): (WebCore::outputPaintOrderTreeLegend): (WebCore::outputPaintOrderTreeRecursive): (WebCore::inContainingBlockChain): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::willBeDestroyed): (WebCore::clearBackingSharingLayerProviders): (WebCore::RenderLayerBacking::setBackingSharingLayers): (WebCore::RenderLayerBacking::removeBackingSharingLayer): (WebCore::RenderLayerBacking::clearBackingSharingLayers): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateDrawsContent): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer const): (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::CompositingState::stateForPaintOrderChildren const): (WebCore::RenderLayerCompositor::CompositingState::propagateStateFromChildren): (WebCore::RenderLayerCompositor::CompositingState::propagateStateFromChildrenForUnchangedSubtree): (WebCore::RenderLayerCompositor::BackingSharingState::resetBackingProviderCandidate): (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::backingProviderLayerCanIncludeLayer): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::traverseUnchangedSubtree): (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason const):
- rendering/RenderLayerCompositor.h:
- rendering/RenderTreeAsText.cpp:
LayoutTests:
New tests for backing sharing, and new baselines of tests whose behavior is changed.
Scrolling tree tests that would be invalidate by sharing are changed to defeat sharing by adding
compositing layers early in stacking order.
- TestExpectations:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap.html:
- compositing/overflow/scrolling-content-clip-to-viewport.html:
- compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
- compositing/shared-backing/overflow-scroll/absolute-in-stacking-relative-in-scroller-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- compositing/shared-backing/overflow-scroll/absolute-in-stacking-relative-in-scroller.html: Added.
- compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller.html: Added.
- compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow.html: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html.
- compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness.html: Added.
- compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping.html: Added.
- compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-relative-clipping-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-relative-clipping.html: Added.
- compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll.html: Added.
- compositing/shared-backing/overflow-scroll/scrolled-contents-has-painted-content-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- compositing/shared-backing/overflow-scroll/scrolled-contents-has-painted-content.html: Added.
- compositing/shared-backing/overflow-scroll/scrolled-contents-unconstrained-clip-expected.html: Added.
- compositing/shared-backing/overflow-scroll/scrolled-contents-unconstrained-clip.html: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-clipping-expected.html: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-clipping.html: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-composited-bounds-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-composited-bounds.html: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-nested-relative-stacking-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-nested-relative-stacking.html: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-repaint-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/shared-layer-repaint.html: Added.
- compositing/shared-backing/partial-compositing-update-expected.txt: Added.
- compositing/shared-backing/partial-compositing-update.html: Added.
- compositing/shared-backing/partial-compositing-update2-expected.txt: Added.
- compositing/shared-backing/partial-compositing-update2.html: Added.
- compositing/shared-backing/remove-sharing-layer-expected.txt: Added.
- compositing/shared-backing/remove-sharing-layer.html: Added.
- compositing/shared-backing/sharing-cached-clip-rects-expected.txt: Added.
- compositing/shared-backing/sharing-cached-clip-rects.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/absolute-in-stacking-relative-in-scroller-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt: Added.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/nested-absolute-with-clipping-in-stacking-overflow-expected.txt: Added.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt: Added.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-clipping-expected.txt: Added.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/relative-in-clipping-in-scroller-in-relative-clipping-expected.txt: Added.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/relative-in-div-in-overflow-scroll-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- platform/ios-wk2/compositing/shared-backing/overflow-scroll/scrolled-contents-has-painted-content-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
- platform/ios/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- platform/ios/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- platform/ios/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
- platform/mac-wk1/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
- platform/mac-wk2/TestExpectations:
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
- scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html:
- scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt:
- scrollingcoordinator/scrolling-tree/positioned-nodes-complex.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:57 PM Changeset in webkit [245317] by
-
- 3 edits2 adds in trunk
Missing cursor/caret showing in search field on google.com
https://bugs.webkit.org/show_bug.cgi?id=197862
<rdar://problem/50291989>
Reviewed by Simon Fraser.
Source/WebCore:
In this bug, the search field is inside of a fixed position container, which is inside of an empty "overflow:
hidden" form element (the new layout test demonstrates a simple version of this). The layer of the fixed
position container's renderer has an overflow clipping layer of itself, and its clipping rect is non-empty, so
the heuristic initially identifies the layer as not fully clipped. However, as the heuristic ascends the
RenderLayer tree, it then finds the layer for the "overflow: hidden" form element's renderer; this layer is
completely clipped, which causes the heuristic to incorrectly believe that the editable element is completely
clipped.
To fix the bug, this patch reworks the clipping portion of the heuristic, such that we no longer need to ascend
the layer tree. Instead of computing the clip rect relative to the nearest ancestor that has an overflow clip
and then walking up the layer tree repeating this process, simply compute the clip rect relative to RenderView's
layer, and then walk up to the parent frame and repeat if necessary.
Test: editing/selection/ios/do-not-hide-selection-in-visible-field.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isTransparentOrFullyClippedRespectingParentFrames const):
LayoutTests:
Add a new layout test that represents a reduced test case version of google.com's search field.
- editing/selection/ios/do-not-hide-selection-in-visible-field.html: Added.
- 9:00 PM Changeset in webkit [245316] by
-
- 2 edits in trunk/LayoutTests
Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
https://bugs.webkit.org/show_bug.cgi?id=197897
<rdar://problem/50306931>
Reviewed by Wenson Hsieh.
Programmatic scrolls are included in the transaction and we want to
ensure that they've been applied. Then we can be sure that the page
has finished scrolling and it's appropriate to test the page offset.
- fast/events/autoscroll-when-input-is-offscreen.html:
- 3:55 PM Changeset in webkit [245315] by
-
- 3 edits in trunk/LayoutTests
storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196445
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations: Not flaky on iOS
- platform/mac-wk2/TestExpectations: Updating expectations for Mac
- 3:50 PM Changeset in webkit [245314] by
-
- 18 edits1 copy2 adds in trunk
[Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
https://bugs.webkit.org/show_bug.cgi?id=197751
<rdar://problem/50631563>
Reviewed by Alex Christensen.
Source/WebCore:
In r243324, when a document has had user agent scripts injected into it, payment APIs were
disabled at runtime by having all entry points return falsy values or throw exceptions
(e.g., ApplePaySession.canMakePayments() returns false).
In the case of user scripts in particular (e.g., WKUserScript), since we know whether these
exist at the time we create a document's DOMWindow, we can do better than r243324 by
completely disabling the payment APIs in the presence of user scripts.
To achieve this, this change introduces the 'EnabledByContext' extended attribute for
interfaces, which instructs the bindings generator to add a conjunct to the payment API
constructors that asks the interface's implementation class whether it should be enabled for
a given ScriptExecutionContext. The PaymentRequest and ApplePaySession interfaces adopt this
new extended attribute to implement the new user script check.
Added new API tests.
- Modules/applepay/ApplePaySession.idl:
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::shouldEnableApplePayAPIs const):
- Modules/applepay/PaymentCoordinator.h:
- Modules/applepay/PaymentSession.cpp:
(WebCore::PaymentSession::enabledForContext):
- Modules/applepay/PaymentSession.h:
- Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::enabledForContext):
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::enabledForContext):
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentRequest.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(NeedsRuntimeCheck):
(GenerateRuntimeEnableConditionalString):
- bindings/scripts/IDLAttributes.json:
- bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttributes):
- bindings/scripts/test/JS/JSTestEnabledForContext.cpp: Added.
- bindings/scripts/test/JS/JSTestEnabledForContext.h: Added.
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::JSTestGlobalObject::finishCreation):
(WebCore::jsTestGlobalObjectTestEnabledForContextConstructorGetter):
(WebCore::jsTestGlobalObjectTestEnabledForContextConstructor):
(WebCore::setJSTestGlobalObjectTestEnabledForContextConstructorSetter):
(WebCore::setJSTestGlobalObjectTestEnabledForContextConstructor):
- bindings/scripts/test/TestEnabledForContext.idl: Added.
Tools:
Added new API tests.
- TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
(-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
(-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
(-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
- 3:44 PM Changeset in webkit [245313] by
-
- 6 edits in trunk
Fix issue with byteOffset on ARM64E
https://bugs.webkit.org/show_bug.cgi?id=197884
Reviewed by Saam Barati.
JSTests:
We didn't have any tests that run with non-byte/non-zero offset
typed arrays.
- stress/ftl-gettypedarrayoffset-wasteful.js:
Source/JavaScriptCore:
We forgot to remove the tag from the ArrayBuffer's data
pointer. This corrupted data when computing the offset. We didn't
catch this because we didn't run any with a non-zero byteOffset in
the JITs.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::untagArrayPtr):
(JSC::FTL::DFG::LowerDFGToB3::removeArrayPtrTag):
(JSC::FTL::DFG::LowerDFGToB3::speculateTypedArrayIsNotNeutered):
- jit/IntrinsicEmitter.cpp:
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):
- 2:49 PM Changeset in webkit [245312] by
-
- 2 edits in trunk/Source/WebCore
[WHLSL] parseEffectfulSuffix() is never called
https://bugs.webkit.org/show_bug.cgi?id=195864
<rdar://problem/50746278>
Reviewed by Myles C. Maxfield.
The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.
No test yet, as it is not testable until the property resolver is finished.
It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).
- Modules/webgpu/WHLSL/WHLSLParser.cpp:
(WebCore::WHLSL::Parser::parseEffectfulPrefix):
- 2:38 PM Changeset in webkit [245311] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r245249): ASSERTION FAILED: !m_needExceptionCheck seen with stress/proxy-delete.js and stress/proxy-property-descriptor.js
https://bugs.webkit.org/show_bug.cgi?id=197885
<rdar://problem/50770190>
Reviewed by Yusuke Suzuki.
In r245249 we added a throw scope to JSObject::getOwnPropertyDescriptor and its
callers now need to check for exceptions.
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performDelete):
- 2:08 PM Changeset in webkit [245310] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245298. rdar://problem/50665984
Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
https://bugs.webkit.org/show_bug.cgi?id=197883
<rdar://problem/50665984>
Reviewed by Alex Christensen.
Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
delegates and those may cause |this| to get destroyed.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didBecomeUnresponsive): (WebKit::WebProcessProxy::didExceedCPULimit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:07 PM Changeset in webkit [245309] by
-
- 35 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245294. rdar://problem/50698499
Update TBA macros for API / SPI that has already shipped
https://bugs.webkit.org/show_bug.cgi?id=197841
<rdar://problem/50698499>
Reviewed by Geoffrey Garen.
- Configurations/WebKit.xcconfig: Disable header postprocessing when building for macOS Mojave
- Shared/API/Cocoa/_WKRenderingProgressEvents.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.h:
- UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
- UIProcess/API/Cocoa/WKBrowsingContextHistoryDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
- UIProcess/API/Cocoa/WKConnection.h:
- UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKProcessGroup.h:
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKTypeRefWrapper.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKView.h: (WK_CLASS_DEPRECATED_WITH_REPLACEMENT):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/Cocoa/_WKAttachment.h:
- UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
- UIProcess/API/Cocoa/_WKDownload.h:
- UIProcess/API/Cocoa/_WKFormInputSession.h:
- UIProcess/API/Cocoa/_WKInspector.h:
- UIProcess/API/Cocoa/_WKInternalDebugFeature.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- WebProcess/API/Cocoa/WKWebProcess.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:07 PM Changeset in webkit [245308] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebCore
Cherry-pick r245253. rdar://problem/50628434
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:07 PM Changeset in webkit [245307] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245252. rdar://problem/49795964
[iOS] Crash when trying to QuickLook
https://bugs.webkit.org/show_bug.cgi?id=197853
<rdar://problem/49795964>
Reviewed by Brent Fulgham.
This is caused by a syscall sandbox violation.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:07 PM Changeset in webkit [245306] by
-
- 3 edits2 adds in branches/safari-608.1.24-branch
Cherry-pick r245238. rdar://problem/49382250
[macOS] Font formatting options don't work when composing a message in Yahoo mail
https://bugs.webkit.org/show_bug.cgi?id=197813
<rdar://problem/49382250>
Reviewed by Darin Adler.
Source/WebCore:
The bug happens because on mousedown, the "Aa Font" menu item's event handler hides itself before changing the
font at the text selection. This causes us to clear the selection in FocusController::setFocusedElement.
There is existing logic in clearSelectionIfNeeded that would normally prevent us from clearing the selection due
to the mousePressNode not being able to start a selection. However, since the clickable element in this case is
hidden during mousedown, it is missing a renderer, and we bail from the `mousePressNode->renderer() &&
!mousePressNode->canStartSelection()` check as a result.
This check was orginally added in https://trac.webkit.org/r24334 to avoid clearing the selection when clicking
a button; the intention appears to have been making it so that clicking on something that could not start a
selection (back then, synonymous with -webkit-user-select: ignore;) would not clear the current selection; to
this end, it seems odd to additionally require that the thing being clicked should still have a renderer, so
it seems safe to remove this requirement.
Test: editing/selection/preserve-selection-when-clicking-button.html
- page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
LayoutTests:
Add a new layout test to verify that DOM selection is preserved after clicking a button that hides itself
upon mousedown.
- editing/selection/preserve-selection-when-clicking-button-expected.txt: Added.
- editing/selection/preserve-selection-when-clicking-button.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:07 PM Changeset in webkit [245305] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245237. rdar://problem/50495880
AX: Need an entitlement for WebContent to send accessibility notifications
https://bugs.webkit.org/show_bug.cgi?id=197832
Reviewed by Brent Fulgham.
In order to send accessibility notifications on iOS, we need to be able to look up this port.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:38 PM Changeset in webkit [245304] by
-
- 2 edits in trunk/LayoutTests
[IntersectionObserver] Update expectations for tests that are no longer flaky
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:36 PM Changeset in webkit [245303] by
-
- 2 edits in trunk/LayoutTests
Rebaseline inspector/model/remote-object.html after r245288
https://bugs.webkit.org/show_bug.cgi?id=197833
Unreviewed test gardening.
- inspector/model/remote-object-expected.txt:
- 1:35 PM Changeset in webkit [245302] by
-
- 2 edits in trunk/Source/WebCore
[WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
https://bugs.webkit.org/show_bug.cgi?id=197890
Reviewed by Myles Maxfield.
callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.
- Modules/webgpu/WHLSL/WHLSLParser.cpp:
(WebCore::WHLSL::Parser::parseEffectfulAssignment):
- 1:30 PM Changeset in webkit [245301] by
-
- 15 edits in trunk/Source
Unreviewed restoration of non-unified build.
Source/JavaScriptCore:
- dfg/DFGMinifiedID.h:
- runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp:
Source/WebCore:
- Modules/cache/DOMCache.cpp:
- bindings/js/JSLazyEventListener.h:
- loader/NavigationScheduler.h:
- page/Quirks.cpp:
- page/Quirks.h:
- rendering/ClipRect.cpp:
Source/WebKit:
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
- UIProcess/WebProcessProxy.cpp:
- 1:03 PM Changeset in webkit [245300] by
-
- 3 edits3 adds in trunk
Do not try to issue repaint while the render tree is being destroyed.
https://bugs.webkit.org/show_bug.cgi?id=197461
<rdar://problem/50368992>
Reviewed by Simon Fraser.
Source/WebCore:
Test: http/tests/svg/crash-on-reload-with-filter.html
We don't need to compute repaint rects when the render tree is getting torn down. We'll issue a full repaint at some point.
Also during full render tree destruction the inline tree state is undefined. We should avoid accessing it.
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
LayoutTests:
- http/tests/svg/crash-on-reload-with-filter-expected.txt: Added.
- http/tests/svg/crash-on-reload-with-filter.html: Added.
- http/tests/svg/resources/finishTest.html: Added.
- 12:48 PM Changeset in webkit [245299] by
-
- 32 edits4 adds in trunk
A service worker process should app nap when all its clients app nap
https://bugs.webkit.org/show_bug.cgi?id=185626
<rdar://problem/46785908>
Reviewed by Alex Christensen.
Source/WebCore:
Update RegistrableDomain to work with SecurityOriginData.
Add internal API to enable accessing to service worker process throttle state.
Test: http/wpt/service-workers/mac/processSuppression.https.html
- platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::RegistrableDomain):
(WebCore::RegistrableDomain::matches const):
(WebCore::RegistrableDomain::registrableDomainFromHost):
- testing/ServiceWorkerInternals.cpp:
(WebCore::ServiceWorkerInternals::isThrottleable const):
- testing/ServiceWorkerInternals.h:
- testing/ServiceWorkerInternals.idl:
- workers/service/SWClientConnection.h:
- workers/service/context/SWContextManager.cpp:
- workers/service/context/SWContextManager.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::serverToContextConnectionCreated):
- workers/service/server/SWServer.h:
(WebCore::SWServer::Connection::server const):
(WebCore::SWServer::connections const):
- workers/service/server/SWServerToContextConnection.h:
Source/WebKit:
Compute whether a given web process can be throttled on every page throttling change.
Send that information to network process which stores that information in WebSWServerConnection.
Every WebSWServerToContextConnection throttle state is then computed based on all WebSWServerConnection
that have a client that matches the registrable domain of the context connection.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
(WebKit::WebSWServerConnection::unregisterServiceWorkerClient):
(WebKit::WebSWServerConnection::hasMatchingClient const):
(WebKit::WebSWServerConnection::computeThrottleState const):
(WebKit::WebSWServerConnection::setThrottleState):
(WebKit::WebSWServerConnection::updateThrottleState):
(WebKit::WebSWServerConnection::serverToContextConnectionCreated):
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
(WebKit::WebSWServerConnection::isThrottleable const):
- NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::setThrottleState):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
(WebKit::WebSWServerToContextConnection::isThrottleable const):
- UIProcess/ServiceWorkerProcessProxy.cpp:
- UIProcess/ServiceWorkerProcessProxy.h:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::updateThrottleState):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::setThrottleState):
(WebKit::WebSWContextManagerConnection::isThrottleable const):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateUserActivity):
(WebKit::WebPage::isThrottleable const):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::arePagesThrottleable const):
- WebProcess/WebProcess.h:
Tools:
Allow to enable app nap through test header.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
- http/wpt/service-workers/mac/throttleable-worker.js: Added.
- http/wpt/service-workers/mac/throttleable.https-expected.txt: Added.
- http/wpt/service-workers/mac/throttleable.https.html: Added.
- platform/ios-wk2/TestExpectations:
- 12:48 PM Changeset in webkit [245298] by
-
- 2 edits in trunk/Source/WebKit
Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
https://bugs.webkit.org/show_bug.cgi?id=197883
<rdar://problem/50665984>
Reviewed by Alex Christensen.
Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
delegates and those may cause |this| to get destroyed.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didExceedCPULimit):
- 12:32 PM Changeset in webkit [245297] by
-
- 2 edits in trunk/Source/WebKit
The network process tries to take a process assertion when NetworkProcess::processWillSuspendImminently() is called
https://bugs.webkit.org/show_bug.cgi?id=197888
Reviewed by Geoffrey Garen.
When actualPrepareToSuspend() in the Network process is called set the 'IsSuspended' flag on the SQLite database tracker and unset
the flag when the process resume. This is consistent with what we already do in the WebProcess and makes sure that
the network process does not try and take on a new assertion due to locked files when getting notified it is about to get
suspended.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::actualPrepareToSuspend):
(WebKit::NetworkProcess::processWillSuspendImminently):
(WebKit::NetworkProcess::resume):
- 12:30 PM Changeset in webkit [245296] by
-
- 7 edits in trunk/Source/WebCore
getUserMedia capture changes on iOS after homing out
https://bugs.webkit.org/show_bug.cgi?id=197707
Reviewed by Eric Carlson.
In case of muting an AVVideoCaptureSource on iOS, the session is cleared.
We need to store the preset information, to setup the new session on unnmuting correctly.
Manually tested.
- platform/mediastream/mac/AVVideoCaptureSource.h:
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):
(WebCore::AVVideoCaptureSource::setSessionSizeAndFrameRate):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
- 12:06 PM Changeset in webkit [245295] by
-
- 6 edits2 adds2 deletes in trunk
[css-grid] Update grid when changing auto repeat type
https://bugs.webkit.org/show_bug.cgi?id=197849
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Import WPT test.
- web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html: Added.
- web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html
This patch makes two 'repeat()' values for 'grid-template' be considered
to be different if one uses 'auto-fill' and the other 'auto-fit'.
Previously, they were considered to be equal if the repeated values
were the same, without comparing the repeat type. Therefore, the grid
was not updated when setting both values one after the other.
- css/CSSGridAutoRepeatValue.cpp:
(WebCore::CSSGridAutoRepeatValue::equals const):
- css/CSSGridAutoRepeatValue.h:
LayoutTests:
Remove the test which has been upstreamed to WPT.
- fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt: Removed.
- fast/css-grid-layout/grid-change-auto-repeat-tracks.html: Removed.
- 11:52 AM Changeset in webkit [245294] by
-
- 35 edits in trunk/Source/WebKit
Update TBA macros for API / SPI that has already shipped
https://bugs.webkit.org/show_bug.cgi?id=197841
<rdar://problem/50698499>
Reviewed by Geoffrey Garen.
- Configurations/WebKit.xcconfig:
Disable header postprocessing when building for macOS Mojave
- Shared/API/Cocoa/_WKRenderingProgressEvents.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.h:
- UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
- UIProcess/API/Cocoa/WKBrowsingContextHistoryDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
- UIProcess/API/Cocoa/WKConnection.h:
- UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKProcessGroup.h:
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKTypeRefWrapper.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKView.h:
(WK_CLASS_DEPRECATED_WITH_REPLACEMENT):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/Cocoa/_WKAttachment.h:
- UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
- UIProcess/API/Cocoa/_WKDownload.h:
- UIProcess/API/Cocoa/_WKFormInputSession.h:
- UIProcess/API/Cocoa/_WKInspector.h:
- UIProcess/API/Cocoa/_WKInternalDebugFeature.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- WebProcess/API/Cocoa/WKWebProcess.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
- 11:28 AM Changeset in webkit [245293] by
-
- 15 edits in trunk
Event region computation should respect transforms
https://bugs.webkit.org/show_bug.cgi?id=197836
<rdar://problem/50762971>
Reviewed by Darin Adler.
Source/WebCore:
- platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapRegion const):
Add support for transforming regions. Non-rectlinear results use enclosing rects.
- platform/graphics/transforms/AffineTransform.h:
- rendering/EventRegion.cpp:
(WebCore::EventRegionContext::EventRegionContext):
(WebCore::EventRegionContext::pushTransform):
(WebCore::EventRegionContext::popTransform):
(WebCore::EventRegionContext::unite):
(WebCore::EventRegionContext::contains const):
Add a context object that holds the current transform.
- rendering/EventRegion.h:
(WebCore::EventRegion::makeContext):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/PaintInfo.h:
Replace the region object with the context.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerByApplyingTransform):
Apply transforms to regions if needed.
(WebCore::RenderLayer::collectEventRegionForFragments):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
- 11:27 AM Changeset in webkit [245292] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: fix test failures after r245280.
- platform/mac-wk2/TestExpectations:
Animating HEICS images is supported only on post macOS Mojave. So these
tests should be skipped in WebKit for now.
- 11:11 AM Changeset in webkit [245291] by
-
- 7 edits in branches/safari-607-branch/Source
Versioning.
- 11:10 AM Changeset in webkit [245290] by
-
- 12 edits in trunk
Unreviewed, rolling out r245281.
https://bugs.webkit.org/show_bug.cgi?id=197887
Broke API Test TestWebKitAPI.Challenge.ClientCertificate
(Requested by aakashjain on #webkit).
Reverted changeset:
"Add a unit test for client certificate authentication"
https://bugs.webkit.org/show_bug.cgi?id=197800
https://trac.webkit.org/changeset/245281
- 10:43 AM Changeset in webkit [245289] by
-
- 6 edits2 moves in trunk
Video frame resizing should be using Trim
https://bugs.webkit.org/show_bug.cgi?id=197722
<rdar://problem/50602188>
Reviewed by Eric Carlson.
Source/WebCore:
Move from letter box to trim mode for resizing.
This ensures no black stripes are present when rendering the stream.
Test: fast/mediastream/resize-trim.html
- platform/cocoa/VideoToolboxSoftLink.cpp:
- platform/cocoa/VideoToolboxSoftLink.h:
- platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::ImageTransferSessionVT):
LayoutTests:
- fast/mediastream/resize-trim-expected.txt: Renamed from LayoutTests/fast/mediastream/resize-letterbox-expected.txt.
- fast/mediastream/resize-trim.html: Renamed from LayoutTests/fast/mediastream/resize-letterbox.html.
- platform/gtk/TestExpectations:
- 10:31 AM Changeset in webkit [245288] by
-
- 16 edits1 add in trunk
[JSC] Shrink sizeof(UnlinkedFunctionExecutable) more
https://bugs.webkit.org/show_bug.cgi?id=197833
Reviewed by Darin Adler.
JSTests:
- stress/generator-name.js: Added.
(shouldBe):
(gen):
(catch):
Source/JavaScriptCore:
It turns out that Gmail creates so many JSFunctions, FunctionExecutables, and UnlinkedFunctionExecutables.
So we should shrink size of them to save memory. As a first step, this patch reduces the sizeof(UnlinkedFunctionExecutable) more by 16 bytes.
- We reorder some fields to get 8 bytes. And we use 31 bits for xxx offset things since their maximum size should be within 31 bits due to String's length & int32_t representation in our parser.
- We drop m_inferredName and prefer m_ecmaName. The inferred name is used to offer better function name when the function expression lacks the name, but now ECMAScript has a specified semantics to name those functions with intuitive names. We should use ecmaName consistently, and should not eat 8 bytes for inferred names in UnlinkedFunctionExecutable.
We also fix generator ecma name.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::inferredName const):
- bytecode/InlineCallFrame.cpp:
(JSC::InlineCallFrame::inferredName const):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createGeneratorFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::tryInferNameInPatternWithIdentifier):
(JSC::ASTBuilder::makeAssignNode):
- parser/Nodes.cpp:
(JSC::FunctionMetadataNode::operator== const):
(JSC::FunctionMetadataNode::dump const):
- parser/Nodes.h:
- runtime/CachedTypes.cpp:
(JSC::CachedFunctionExecutable::ecmaName const):
(JSC::CachedFunctionExecutable::encode):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::CachedFunctionExecutable::inferredName const): Deleted.
- runtime/FunctionExecutable.h:
- runtime/FunctionExecutableDump.cpp:
(JSC::FunctionExecutableDump::dump const):
- runtime/JSFunction.cpp:
(JSC::JSFunction::calculatedDisplayName):
(JSC::getCalculatedDisplayName):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::parserMetaData):
- 10:03 AM Changeset in webkit [245287] by
-
- 5 edits in trunk/Tools
Add support for webkit-test-runner options to WPT importer
https://bugs.webkit.org/show_bug.cgi?id=197826
Reviewed by Alex Christensen.
In case of overwriting an existing test, check if the existing test
contains a <!-- webkit-test-runner --> comment and insert it back if
needed in the new test.
For exporter, forbid creating a WPT PR if there are changes containing
the webkit-test-runner string.
- Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.init):
(_W3CTestConverter.add_webkit_test_runner_options_if_needed):
(_W3CTestConverter.handle_starttag):
(_W3CTestConverter.handle_comment):
(_W3CTestConverter.handle_decl):
(_W3CTestConverter.handle_pi):
- Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter.write_git_patch_file):
(WebPlatformTestExporter.make_pull_request):
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.webkit_test_runner_options):
(TestImporter):
(TestImporter.add_webkit_test_runner_options_to_content):
(TestImporter.copy_html_file):
(TestImporter.write_html_template):
(TestImporter.write_html_files_for_templated_js_tests):
(TestImporter.import_tests):
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(test_manual_slow_test):
(test_webkit_test_runner_options):
- 9:50 AM Changeset in webkit [245286] by
-
- 3 edits2 adds in trunk
[Pointer Events] The pointerenter and pointerleave events target the wrong element on iOS
https://bugs.webkit.org/show_bug.cgi?id=197881
<rdar://problem/50187657>
Patch by Antoine Quint <Antoine Quint> on 2019-05-14
Reviewed by Dean Jackson.
Source/WebCore:
Test: pointerevents/ios/enter-leave-target.html
The "pointerenter" and "pointerleave" should target the element on which the event listener was added and not
the element that would otherwise hit test. This matches the behavior of "mouseenter" and "mouseleave" on macOS.
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::dispatchEventForTouchAtIndex):
LayoutTests:
Add a test where we tap an element that is the child of another element where the parent is the element with the "pointerenter"
and "pointerleave" events registered. The test shows that we correctly set the target to the parent element and not the child.
- pointerevents/ios/enter-leave-target-expected.txt: Added.
- pointerevents/ios/enter-leave-target.html: Added.
- 9:43 AM Changeset in webkit [245285] by
-
- 4 edits2 adds in trunk
[iOS] Cannot scroll to beginning of document after scrolling to end of document and vice versa via key commands
https://bugs.webkit.org/show_bug.cgi?id=197848
<rdar://problem/49523065>
Patch by Daniel Bates <dabates@apple.com> on 2019-05-14
Reviewed by Brent Fulgham.
Source/WebKit:
Following the fix for <rdar://problem/49523065>, UIKit no longer emits a keyup event for a Command-
modified key. This breaks WebKit's own implementation of key command handling for scrolling to the
beginning or end of the document (triggered using Command + Arrow Up and Command + Arrow Down,
respectively) because it watches for keyup events to reset state after initiating a scroll. If state
is not reset then the scroll key command logic becomes confused and may not perform a subsequent scroll.
It seems like we can actually get away with supporting these key commands and future Command modified
commands by preemptively reseting state on keydown if the Command modifier is held down. If this does
not work out then we can do something more complicated.
- UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollingAnimator handleKeyEvent:]):
LayoutTests:
Add a test to ensure that key commands can be used to scroll to the end of the page and then
to the beginning of the page.
- fast/scrolling/ios/scroll-to-beginning-and-end-of-document-expected.txt: Added.
- fast/scrolling/ios/scroll-to-beginning-and-end-of-document.html: Added.
- resources/ui-helper.js:
(window.UIHelper.callFunctionAndWaitForScrollToFinish): Added. Convenience function that invokes the
specified function and returns a Promise that is resolved once the page has finished scrolling. To know
if the page has finished scrolling we listen for DOM scroll events and repeatedly reset a 300ms timer.
The delay of 300ms was chosen to be > 250ms (to give some margin of error), which is the upper bound
delay between scroll event firings, last I recall. When the timer expires we assume that page has
finished scrolling.
(window.UIHelper):
- 9:36 AM Changeset in webkit [245284] by
-
- 2 edits in trunk/Source/WebKit
Protect current WebFrame during form submission
https://bugs.webkit.org/show_bug.cgi?id=197459
<rdar://problem/50368618>
Reviewed by Alex Christensen.
The 'continueWillSubmitForm' method calls a completion handler that
might affect the state of the current frame. Ensure the frame is valid
for the scope of the function.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::continueWillSubmitForm):
- 9:22 AM Changeset in webkit [245283] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Cannot tab or shift + tab out of address bar on google.com
https://bugs.webkit.org/show_bug.cgi?id=197859
<rdar://problem/46651565>
Patch by Daniel Bates <dabates@apple.com> on 2019-05-14
Reviewed by Darin Adler.
Non-editable elements can participate in tab cycling via the HTML tabindex attribute.
We should allow setting the initial focus to such an element when transitioning from
the chrome (e.g. address bar) to the web page.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
- 9:18 AM Changeset in webkit [245282] by
-
- 2 edits in trunk/Tools
[ews-app] Status bubble should turn orange when any build step fails
https://bugs.webkit.org/show_bug.cgi?id=197812
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
(StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
- 8:49 AM Changeset in webkit [245281] by
-
- 12 edits in trunk
Add a unit test for client certificate authentication
https://bugs.webkit.org/show_bug.cgi?id=197800
Patch by Alex Christensen <achristensen@webkit.org> on 2019-05-14
Reviewed by Youenn Fablet.
Source/WebKit:
- Shared/cf/ArgumentCodersCF.cpp:
Move SPI declarations to SecuritySPI.h.
Source/WTF:
- wtf/spi/cocoa/SecuritySPI.h:
Move declarations from ArgumentCodersCF.cpp so they can be shared.
Tools:
Make better abstractions for reading and writing from/to TCPServer.
Add a unit test that causes a client certificate authentication challenge to happen.
- TestWebKitAPI/TCPServer.cpp:
(TestWebKitAPI::TCPServer::TCPServer):
(TestWebKitAPI::TCPServer::read):
(TestWebKitAPI::TCPServer::write):
(TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
(TestWebKitAPI::TCPServer::respondWithOK):
- TestWebKitAPI/TCPServer.h:
- TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(credentialWithIdentity):
(-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(TEST):
(-[ClientCertificateDelegate webView:didFinishNavigation:]):
(-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
(-[ClientCertificateDelegate challengeCount]):
(TestWebKitAPI::TEST):
(respondWithChallengeThenOK): Deleted.
(credentialWithIdentityAndKeychainPath): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
(TEST):
(readRequest): Deleted.
(writeResponse): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
(TestWebKitAPI::TEST):
(TestWebKitAPI::respondWithChallengeThenOK): Deleted.
- 8:13 AM Changeset in webkit [245280] by
-
- 22 edits6 adds in trunk
[CG] Adding support for HEIF-sequence ('public.heics') images
https://bugs.webkit.org/show_bug.cgi?id=197384
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-05-14
Reviewed by Simon Fraser.
Source/WebCore:
-- Get the image repetitionCount and the frame duration.
-- Add a new function setAdditionalSupportedImageTypesForTesting() which
takes a delimited String.
-- Add internal APIs to retrive the image frame count and the frame
duration.
Tests: fast/images/animated-heics-draw.html
fast/images/animated-heics-verify.html
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::animationPropertiesFromProperties):
(WebCore::animationHEICSPropertiesFromProperties):
(WebCore::ImageDecoderCG::repetitionCount const):
(WebCore::ImageDecoderCG::frameDurationAtIndex const):
- platform/graphics/cg/UTIRegistry.cpp:
(WebCore::setAdditionalSupportedImageTypesForTesting):
- platform/graphics/cg/UTIRegistry.h:
- testing/Internals.cpp:
(WebCore::Internals::imageFrameCount):
(WebCore::Internals::imageFrameDurationAtIndex):
- testing/Internals.h:
- testing/Internals.idl:
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setAdditionalSupportedImageTypesForTesting):
- testing/js/WebCoreTestSupport.h:
Tools:
- DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
the test.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::stringForKey):
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::createTestSettingsDictionary):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
the test.
LayoutTests:
Disable the tests for all ports and enable it only for [ Mojave+ WK2]
because of <rdar://problem/42625657>.
- TestExpectations:
- fast/images/animated-heics-draw-expected.txt: Added.
- fast/images/animated-heics-draw.html: Added.
- fast/images/animated-heics-verify-expected.txt: Added.
- fast/images/animated-heics-verify.html: Added.
- fast/images/resources/sea_animation.heics: Added.
- fast/images/resources/sticker.heics: Added.
- platform/mac-wk2/TestExpectations:
- 8:08 AM Changeset in webkit [245279] by
-
- 4 edits10 adds in trunk
[css-grid] Use max size to compute auto repeat tracks
https://bugs.webkit.org/show_bug.cgi?id=197854
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
Imported WPT tests for this bug.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html: Added.
- web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
Source/WebCore:
When available size is indefinite we should use max size to compute the number of auto repeat tracks.
The spec text is very clear (https://drafts.csswg.org/css-grid/#auto-repeat):
When auto-fill is given as the repetition number, if the grid container
has a definite size or max size in the relevant axis...
So far we were not doing that for widths, in this patch we modify RenderGrid::computeAutoRepeatTracksCount()
to do the same than for heights.
We also take advantage to fix problems related to min|max sizes and box-sizing property,
that were inconsistent for columns and rows.
Tests: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-002.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-max-size-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeAutoRepeatTracksCount const):
- 8:07 AM Changeset in webkit [245278] by
-
- 1 edit1 add in trunk/Source/ThirdParty/ANGLE
REGRESSION(r245088): [GTK] Several WebGL tests failing
https://bugs.webkit.org/show_bug.cgi?id=197880
Reviewed by Carlos Garcia Campos.
Enable GLSL compiler output for WebKitGTK.
- PlatformGTK.cmake: Added.
- 8:02 AM Changeset in webkit [245277] by
-
- 2 edits in trunk/LayoutTests
[Win10] Some tests are failing only on specific machines
https://bugs.webkit.org/show_bug.cgi?id=197509
Unreviewed test gardening.
- platform/win/TestExpectations:
- 7:02 AM Changeset in webkit [245276] by
-
- 8 edits in trunk
Implement page-break-* and -webkit-column-break-* as legacy-shorthands.
https://bugs.webkit.org/show_bug.cgi?id=197656
LayoutTests/imported/w3c:
Reviewed by Darin Adler.
According to https://drafts.csswg.org/css-cascade-4/#legacy-shorthand,
implement page-break-* and -webkit-column-break-* as legacy-shorthands for break-*.
This change also serialize page-break-* properties
to CSSStyleDeclaration,
per https://drafts.csswg.org/css-break/#page-break-properties.
- web-platform-tests/css/cssom/serialize-values-expected.txt:
Source/WebCore:
Reviewed by Darin Adler.
According to https://drafts.csswg.org/css-cascade-4/#legacy-shorthand,
implement page-break-* and -webkit-column-break-* as legacy-shorthands for break-*.
This change also serialize page-break-* properties
to CSSStyleDeclaration,
per https://drafts.csswg.org/css-break/#page-break-properties.
- css/CSSProperties.json:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertFontSynthesis):
(WebCore::StyleBuilderConverter::convertPageBreakBetween): Deleted.
(WebCore::StyleBuilderConverter::convertPageBreakInside): Deleted.
(WebCore::StyleBuilderConverter::convertColumnBreakBetween): Deleted.
(WebCore::StyleBuilderConverter::convertColumnBreakInside): Deleted.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::pageBreakPropertyValue const):
- css/StyleProperties.h:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::mapFromPageBreakBetween):
(WebCore::CSSPropertyParser::parseShorthand):
(WebCore::isLegacyBreakProperty): Deleted.
- 6:47 AM WebKitGTK/2.24.x edited by
- (diff)
- 6:20 AM Changeset in webkit [245275] by
-
- 15 edits36 adds in trunk
Implement "line-break: anywhere"
https://bugs.webkit.org/show_bug.cgi?id=181169
<rdar://problem/48507088>
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
New tests to verify the new line-break: anywhere feature and how
it behaves different to 'word-break: break-all'.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-001.html:
- web-platform-tests/css/css-text/line-break/line-break-anywhere-002.html:
- web-platform-tests/css/css-text/line-break/line-break-anywhere-003-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-003.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-004-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-004.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-005-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-005.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-006-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-006.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-007-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-007.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-008-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-008.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-009-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-009.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-010-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-010.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-011-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-011.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-012-expected.html: Added.
- web-platform-tests/css/css-text/line-break/line-break-anywhere-012.html: Added.
- web-platform-tests/css/css-text/parsing/line-break-valid-expected.txt:
- web-platform-tests/css/css-text/word-break/word-break-break-all-016-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-016.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-017-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-017.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-018-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-018.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-019-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-019.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-021-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-021.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-022-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-022.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-023-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-023.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-024-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-all-024.html: Added.
Source/WebCore:
The CSS WG resolved [1] to add a new value 'anywhere' to the 'line-break'
CSS property in order to allow additional breaking opportunities not
considered in the definition of the 'word-break: break-all'.
[1] https://github.com/w3c/csswg-drafts/issues/1171
Tests: imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-003.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-004.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-005.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-006.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-007.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-008.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-009.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-010.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-011.html
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-012.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-016.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-017.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-018.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-019.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-021.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-022.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-023.html
imported/w3c/web-platform-tests/css/css-text/word-break/word-break-break-all-024.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineBreak const):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
- rendering/BreakLines.h:
(WebCore::nextBreakablePositionBreakCharacter):
(WebCore::isBreakable):
- rendering/RenderText.cpp:
(WebCore::mapLineBreakToIteratorMode):
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
- rendering/style/RenderStyleConstants.h:
LayoutTests:
Some of the new tests added to verify the new 'line-break:
anywhere' feature and its different behavior to what 'word-break:
break-all' may provide, fail due to several bugs present in
current WebKit's trunk.
- TestExpectations:
- webkit.org/b/197409
- webkit.org/b/197411
- webkit.org/b/197411
- webkit.org/b/197430
- 6:17 AM WebKitGTK/2.24.x edited by
- (diff)
- 6:16 AM WebKitGTK/2.24.x edited by
- 2.24.3 -> 2.24.2 (diff)
May 13, 2019:
- 9:32 PM Changeset in webkit [245274] by
-
- 9 copies1 add in releases/Apple/Safari 12.1.1
Added a tag for Safari 12.1.1.
- 9:32 PM Changeset in webkit [245273] by
-
- 8 copies1 add in releases/Apple/iOS 12.3
Added a tag for iOS 12.3.
- 9:14 PM Changeset in webkit [245272] by
-
- 8 edits in trunk/Source/WebKit
Followup to r245267: fix some more deprecated uses of -[UIApplication interfaceOrientation]
https://bugs.webkit.org/show_bug.cgi?id=197867
<rdar://problem/50743963>
Reviewed by Simon Fraser.
Add a helper method on WKContentView that asks the view's window's scene for an interface orientation; then,
use this helper from various places in WebKit instead of invoking -[UIApplication interfaceOrientation]
directly. No change in behavior.
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView interfaceOrientation]):
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsPicker initWithInformation:inView:]):
- UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker initWithView:]):
- UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePicker initWithView:datePickerMode:]):
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker initWithView:]):
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):
- 8:38 PM Changeset in webkit [245271] by
-
- 2 edits in trunk/Source/WTF
IndexSet::isEmpty should use BitVector::isEmpty() instead of size()
https://bugs.webkit.org/show_bug.cgi?id=197857
Reviewed by Darin Adler.
- wtf/IndexSet.h:
(WTF::IndexSet::isEmpty const):
- 7:34 PM Changeset in webkit [245270] by
-
- 8 edits in trunk/Source/JavaScriptCore
[JSC] Compress JIT related data more by using Packed<>
https://bugs.webkit.org/show_bug.cgi?id=197866
Reviewed by Saam Barati.
This patch leverages Packed<> more to reduce JIT related data size. When we measure memory usage on Gmail, we found that a lot of memory is
consumed in DFG data. This patch attempts to reduce that size by using Packed<> to make various data structure's alignment 1.
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::shrinkToFit): Add more shrinkToFit.
- dfg/DFGMinifiedID.h: Make alignment = 1.
(JSC::DFG::MinifiedID::operator! const):
(JSC::DFG::MinifiedID::operator== const):
(JSC::DFG::MinifiedID::operator!= const):
(JSC::DFG::MinifiedID::operator< const):
(JSC::DFG::MinifiedID::operator> const):
(JSC::DFG::MinifiedID::operator<= const):
(JSC::DFG::MinifiedID::operator>= const):
(JSC::DFG::MinifiedID::hash const):
(JSC::DFG::MinifiedID::dump const):
(JSC::DFG::MinifiedID::isHashTableDeletedValue const):
(JSC::DFG::MinifiedID::bits const):
- dfg/DFGMinifiedIDInlines.h:
(JSC::DFG::MinifiedID::MinifiedID):
- dfg/DFGMinifiedNode.cpp:
(JSC::DFG::MinifiedNode::fromNode): Make sizeof(MinifiedNode) from 16 to 13 with alignment = 1.
- dfg/DFGMinifiedNode.h:
(JSC::DFG::MinifiedNode::id const):
(JSC::DFG::MinifiedNode::hasConstant const):
(JSC::DFG::MinifiedNode::constant const):
(JSC::DFG::MinifiedNode::isPhantomDirectArguments const):
(JSC::DFG::MinifiedNode::isPhantomClonedArguments const):
(JSC::DFG::MinifiedNode::hasInlineCallFrame const):
(JSC::DFG::MinifiedNode::inlineCallFrame const):
(JSC::DFG::MinifiedNode::op const): Deleted.
(JSC::DFG::MinifiedNode::hasInlineCallFrame): Deleted.
- dfg/DFGVariableEvent.h: Make sizeof(VariableEvent) from 12 to 10 with alignment = 1.
(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::birth):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id const):
(JSC::DFG::VariableEvent::gpr const):
(JSC::DFG::VariableEvent::tagGPR const):
(JSC::DFG::VariableEvent::payloadGPR const):
(JSC::DFG::VariableEvent::fpr const):
(JSC::DFG::VariableEvent::spillRegister const):
(JSC::DFG::VariableEvent::bytecodeRegister const):
(JSC::DFG::VariableEvent::machineRegister const):
(JSC::DFG::VariableEvent::variableRepresentation const):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::tryToSetConstantRecovery):
- 7:25 PM Changeset in webkit [245269] by
-
- 3 edits in trunk/Source/WTF
[Mac] Use realpath for dlopen_preflight
https://bugs.webkit.org/show_bug.cgi?id=197803
Reviewed by Eric Carlson.
- wtf/cocoa/SoftLinking.h:
- 7:25 PM Changeset in webkit [245268] by
-
- 7 edits in trunk
[iOS] When running layout tests that tap in the same location, subsequent tests fail to fire click handlers
https://bugs.webkit.org/show_bug.cgi?id=197821
<rdar://problem/50700512>
Reviewed by Tim Horton.
Source/WebKit:
After r244775, when running back-to-back layout tests on iOS that simulate taps in the same location, the double
tap gesture recognizer for recognizing double clicks ends up recognizing instead of the single tap gesture
recognizer in the subsequent test. This means that click handlers in the subsequent test will fail to recognize,
unless the element with the click handler is also accompanied by a dblclick handler.
To avoid this, we reset the double click gesture recognizer when navigating; this has the additional effect of
making it such that the second page doesn't end up observing a dblclick when the first click was only sent to
the first page.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didStartProvisionalLoadForMainFrame):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView _didStartProvisionalLoadForMainFrame]):
LayoutTests:
Removes workarounds in a couple of existing layout tests.
- editing/selection/ios/clear-selection-after-tapping-on-element-with-no-click-handler.html:
- editing/selection/ios/persist-selection-after-tapping-on-element-with-click-handler.html:
- 5:12 PM Changeset in webkit [245267] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix some deprecation warnings when using a recent SDK
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsPicker initWithInformation:inView:]):
- 5:11 PM Changeset in webkit [245266] by
-
- 7 edits in branches/safari-608.1.24-branch/Source
Versioning.
- 5:03 PM Changeset in webkit [245265] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix after 245258, missing ThreadSpecific.h include
https://bugs.webkit.org/show_bug.cgi?id=197146
- platform/ios/wak/WebCoreThread.mm:
- 4:43 PM Changeset in webkit [245264] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, wrokaround for MACH_VM_MAX_ADDRESS in ARM32_64
https://bugs.webkit.org/show_bug.cgi?id=197730
Interestingly, MACH_VM_MAX_ADDRESS is larger than 32bit in ARM32_64, I think this is a bug.
But for now, we workaround for this case by usingCPU(ADDRESS64).
- wtf/WTFAssertions.cpp:
- 4:11 PM Changeset in webkit [245263] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
Make QTKit an optional framework
https://bugs.webkit.org/show_bug.cgi?id=197075
Reviewed by Eric Carlson.
- WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
- 4:09 PM Changeset in webkit [245262] by
-
- 11 edits in trunk
[WebAuthN] InvalidStateError should be reported to sites
https://bugs.webkit.org/show_bug.cgi?id=193269
<rdar://problem/48298264>
Reviewed by Brent Fulgham.
Source/WebKit:
This patch implements step 20 about InvalidStateError of the spec:
https://www.w3.org/TR/webauthn/#createCredential.
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::respondReceived):
- UIProcess/WebAuthentication/fido/CtapHidAuthenticator.cpp:
(WebKit::CtapHidAuthenticator::continueMakeCredentialAfterResponseReceived const):
LayoutTests:
- http/wpt/webauthn/ctap-hid-failure.https.html:
- http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
- http/wpt/webauthn/public-key-credential-create-failure-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
- http/wpt/webauthn/public-key-credential-create-failure-u2f-silent.https.html:
- http/wpt/webauthn/resources/util.js:
- 4:09 PM Changeset in webkit [245261] by
-
- 1 edit3 adds in trunk/Websites/bugs.webkit.org
Bugzilla should convert "r12345" to a trac.webkit.org link
https://bugs.webkit.org/show_bug.cgi?id=197790
Reviewed by Alexey Proskuryakov.
- extensions/Trac/Config.pm: Added.
- extensions/Trac/Extension.pm: Added.
(bug_format_comment):
(_replace_revision):
- 3:42 PM Changeset in webkit [245260] by
-
- 3 edits in trunk/Source/WTF
[WTF] Remove Threading workaround for support libraries in Windows
https://bugs.webkit.org/show_bug.cgi?id=197350
Reviewed by Darin Adler.
We kept old APIs for some support libraries at 2017. This patch removes them.
- wtf/Threading.h:
- wtf/win/ThreadingWin.cpp:
(WTF::createThread): Deleted.
(WTF::waitForThreadCompletion): Deleted.
- 3:36 PM Changeset in webkit [245259] by
-
- 1 copy in tags/Safari-608.1.24.2
Tag Safari-608.1.24.2.
- 3:32 PM Changeset in webkit [245258] by
-
- 20 edits in trunk/Source
[WTF] Simplify GCThread and CompilationThread flags by adding them to WTF::Thread
https://bugs.webkit.org/show_bug.cgi?id=197146
Reviewed by Saam Barati.
Source/JavaScriptCore:
Rename Heap::Thread to Heap::HeapThread to remove conflict between WTF::Thread.
- heap/AlignedMemoryAllocator.cpp:
(JSC::AlignedMemoryAllocator::registerDirectory):
- heap/Heap.cpp:
(JSC::Heap::HeapThread::HeapThread):
(JSC::Heap::Heap):
(JSC::Heap::runCurrentPhase):
(JSC::Heap::runBeginPhase):
(JSC::Heap::resumeThePeriphery):
(JSC::Heap::requestCollection):
(JSC::Heap::isCurrentThreadBusy):
(JSC::Heap::notifyIsSafeToCollect):
(JSC::Heap::Thread::Thread): Deleted.
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepth):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::prepareForAllocation):
Source/WebCore:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::hasPendingActivity const):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::hasPendingActivity const):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::hasPendingActivity const):
Source/WTF:
Since GCThread and CompilationThread flags exist in WTF, we put these flags into WTF::Thread directly instead of holding them in ThreadSpecific<>.
And this patch removes dependency from Threading.h to ThreadSpecific.h. ThreadSpecific.h's OS threading primitives are moved to ThreadingPrimitives.h,
and Threading.h relies on it instead.
- wtf/CompilationThread.cpp:
(WTF::isCompilationThread):
(WTF::initializeCompilationThreads): Deleted.
(WTF::exchangeIsCompilationThread): Deleted.
- wtf/CompilationThread.h:
(WTF::CompilationScope::CompilationScope):
(WTF::CompilationScope::~CompilationScope):
(WTF::CompilationScope::leaveEarly):
- wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::isMainThreadOrGCThread):
(WTF::initializeGCThreads): Deleted.
(WTF::registerGCThread): Deleted.
(WTF::mayBeGCThread): Deleted.
- wtf/MainThread.h:
- wtf/ThreadSpecific.h:
(WTF::canBeGCThread>::ThreadSpecific):
(WTF::canBeGCThread>::set):
(WTF::threadSpecificKeyCreate): Deleted.
(WTF::threadSpecificKeyDelete): Deleted.
(WTF::threadSpecificSet): Deleted.
(WTF::threadSpecificGet): Deleted.
- wtf/Threading.cpp:
(WTF::Thread::exchangeIsCompilationThread):
(WTF::Thread::registerGCThread):
(WTF::Thread::mayBeGCThread):
- wtf/Threading.h:
(WTF::Thread::isCompilationThread const):
(WTF::Thread::gcThreadType const):
(WTF::Thread::joinableState const):
(WTF::Thread::hasExited const):
(WTF::Thread::Thread):
(WTF::Thread::joinableState): Deleted.
(WTF::Thread::hasExited): Deleted.
- wtf/ThreadingPrimitives.h:
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
(WTF::threadSpecificSet):
(WTF::threadSpecificGet):
- wtf/win/ThreadSpecificWin.cpp:
(WTF::flsKeys):
- 3:16 PM Changeset in webkit [245257] by
-
- 3 edits16 adds2 deletes in trunk/LayoutTests
[ Mac Debug ] Layout Test inspector/audit/basic.html is a flaky timeout on bots
https://bugs.webkit.org/show_bug.cgi?id=196448
<rdar://problem/49485452>
Reviewed by Alex Christensen.
Split inspector/audit/basic.html into separate tests so each part can run without timing out.
- inspector/audit/basic-async.html: Added.
- inspector/audit/basic-async-expected.txt: Added.
- inspector/audit/basic-boolean.html: Added.
- inspector/audit/basic-boolean-expected.txt: Added.
- inspector/audit/basic-debugger.html: Added.
- inspector/audit/basic-debugger-expected.txt: Added.
- inspector/audit/basic-error.html: Added.
- inspector/audit/basic-error-expected.txt: Added.
- inspector/audit/basic-object.html: Added.
- inspector/audit/basic-object-expected.txt: Added.
- inspector/audit/basic-promise.html: Added.
- inspector/audit/basic-promise-expected.txt: Added.
- inspector/audit/basic-string.html: Added.
- inspector/audit/basic-string-expected.txt: Added.
- inspector/audit/basic-timeout.html: Added.
- inspector/audit/basic-timeout-expected.txt: Added.
- inspector/audit/basic.html: Removed.
- inspector/audit/basic-expected.txt: Removed.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 3:07 PM Changeset in webkit [245256] by
-
- 2 edits in trunk/LayoutTests
[ Mac WK2 ] Layout Test js/dom/unhandled-promise-rejection-bindings-type-error.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=195969
<rdar://problem/49039441>
Reviewed by Alex Christensen.
- js/dom/unhandled-promise-rejection-bindings-type-error.html:
- 3:01 PM Changeset in webkit [245255] by
-
- 9 edits in trunk/Source/WebKit
Take out MediaPlayback UI assertion when any WebProcess is playing audible media
https://bugs.webkit.org/show_bug.cgi?id=197798
Reviewed by Chris Dumez.
To keep the system from suspending the UIProcess (and all the other constellation of processes that
are necessary to play media), take a UIProcess assertion with the MediaPlayback reason whenever there
is a WebContent process that is playing audible media.
- Platform/spi/ios/AssertionServicesSPI.h:
- UIProcess/ProcessAssertion.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setWebProcessIsPlayingAudibleMedia):
(WebKit::WebProcessPool::clearWebProcessIsPlayingAudibleMedia):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::webPageMediaStateDidChange):
- UIProcess/WebProcessProxy.h:
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::toBKSProcessAssertionReason):
(WebKit::ProcessAssertion::ProcessAssertion):
- WebProcess/WebProcess.h:
- 3:00 PM Changeset in webkit [245254] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, follow-up after r245214
https://bugs.webkit.org/show_bug.cgi?id=197730
Suggested by Sam. We should have static_assert with MACH_VM_MAX_ADDRESS.
- wtf/WTFAssertions.cpp:
- 2:52 PM Changeset in webkit [245253] by
-
- 2 edits in trunk/Source/WebCore
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- 2:48 PM Changeset in webkit [245252] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Crash when trying to QuickLook
https://bugs.webkit.org/show_bug.cgi?id=197853
<rdar://problem/49795964>
Reviewed by Brent Fulgham.
This is caused by a syscall sandbox violation.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 2:34 PM Changeset in webkit [245251] by
-
- 9 edits in trunk/Source/JavaScriptCore
macro assembler code-pointer tagging has its arguments backwards
https://bugs.webkit.org/show_bug.cgi?id=197677
Reviewed by Michael Saboff.
We had the destination as the leftmost instead of the rightmost argument,
which goes against the convention of how we order arguments in macro assembler
methods.
- assembler/MacroAssemblerARM64E.h:
(JSC::MacroAssemblerARM64E::tagReturnAddress):
(JSC::MacroAssemblerARM64E::untagReturnAddress):
(JSC::MacroAssemblerARM64E::tagPtr):
(JSC::MacroAssemblerARM64E::untagPtr):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- ftl/FTLThunks.cpp:
(JSC::FTL::genericGenerationThunkGenerator):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::prepareForTailCallSlow):
- jit/CallFrameShuffler.cpp:
(JSC::CallFrameShuffler::prepareForTailCall):
- jit/ThunkGenerators.cpp:
(JSC::emitPointerValidation):
(JSC::arityFixupGenerator):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
- 2:06 PM Changeset in webkit [245250] by
-
- 13 edits in trunk/LayoutTests
Alter Conic Gradient tests to be less subject to noise
https://bugs.webkit.org/show_bug.cgi?id=197806
<rdar://problem/47272067>
Reviewed by Wenson Hsieh.
There is a currently a bug where there's a lot of detectable noise in
the green gradients. Replace them with the less noisy magenta or blue.
<rdar://problem/50682535>
- fast/gradients/conic-extended-stops-expected.html:
- fast/gradients/conic-extended-stops.html:
- fast/gradients/conic-from-angle-expected.html:
- fast/gradients/conic-from-angle.html:
- fast/gradients/conic-gradient-expected.html:
- fast/gradients/conic-gradient-extended-stops-expected.html:
- fast/gradients/conic-gradient-extended-stops.html:
- fast/gradients/conic-gradient.html:
- fast/gradients/conic-off-center-expected.html:
- fast/gradients/conic-off-center.html:
- fast/gradients/conic-two-hints-expected.html:
- fast/gradients/conic-two-hints.html:
- 1:52 PM Changeset in webkit [245249] by
-
- 5 edits1 add in trunk
JSObject::getOwnPropertyDescriptor is missing an exception check
https://bugs.webkit.org/show_bug.cgi?id=197693
JSTests:
<rdar://problem/50441784>
Reviewed by Saam Barati.
- stress/proxy-spread.js: Added.
(foo):
Source/JavaScriptCore:
<rdar://problem/50441784>
Reviewed by Saam Barati.
The method table call to getOwnPropertySlot might throw, and JSObject::getOwnPropertyDescriptor
must handle the exception before calling PropertySlot::getValue, which can also throw.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
Source/WebCore:
Reviewed by Saam Barati.
JSObject::getOwnPropertyDescriptor assumes that getOwnPropertySlot returns false
if an exception is thrown, but that was not true for JSLocation::getOwnPropertySlotCommon.
This is already covered by http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
- bindings/js/JSLocationCustom.cpp:
(WebCore::getOwnPropertySlotCommon):
(WebCore::JSLocation::getOwnPropertySlot):
(WebCore::JSLocation::getOwnPropertySlotByIndex):
- 1:20 PM Changeset in webkit [245248] by
-
- 8 edits in trunk/Source/ThirdParty/ANGLE
Build more ANGLE files
https://bugs.webkit.org/show_bug.cgi?id=197787
Reviewed by Simon Fraser.
- ANGLE.xcodeproj/project.pbxproj:
- src/gpu_info_util/SystemInfo.cpp:
(angle::ParseMacMachineModel):
- src/gpu_info_util/SystemInfo_mac.mm:
(angle::GetSystemInfo):
- src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
- src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.mm:
(rx::IOSurfaceSurfaceCGL::IOSurfaceSurfaceCGL):
(rx::IOSurfaceSurfaceCGL::validateAttributes):
- src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h:
- src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
(rx::WindowSurfaceCGL::initialize):
(-[SwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.
- 1:10 PM Changeset in webkit [245247] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245246. rdar://problem/50727815
Correct the sandbox to allow loading libraries from /Library/Apple
https://bugs.webkit.org/show_bug.cgi?id=197844
Reviewed by Per Arne Vollan.
Grant access to '/Library/Apple' as an appropriate place to load
system frameworks.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:53 PM Changeset in webkit [245246] by
-
- 2 edits in trunk/Source/WebKit
Correct the sandbox to allow loading libraries from /Library/Apple
https://bugs.webkit.org/show_bug.cgi?id=197844
Reviewed by Per Arne Vollan.
Grant access to '/Library/Apple' as an appropriate place to load
system frameworks.
- WebProcess/com.apple.WebProcess.sb.in:
- 12:40 PM Changeset in webkit [245245] by
-
- 33 edits in trunk/Source/WebKit
Unreviewed, rolling out r245240.
Broke the build
Reverted changeset:
"Update TBA macros for API / SPI that has already shipped"
https://bugs.webkit.org/show_bug.cgi?id=197841
https://trac.webkit.org/changeset/245240
- 12:38 PM Changeset in webkit [245244] by
-
- 4 edits in trunk/Source
Use kDNSServiceFlagsKnownUnique for DNSServiceRegisterRecord only on platforms supporting it
https://bugs.webkit.org/show_bug.cgi?id=197802
Reviewed by Eric Carlson.
Source/WebKit:
- NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):
Source/WTF:
- wtf/Platform.h:
- 12:09 PM Changeset in webkit [245243] by
-
- 3 edits in trunk/Source/WebKit
decidePolicyForInstallMissingMediaPluginsPermissionRequest requires GStreamer
https://bugs.webkit.org/show_bug.cgi?id=197843
Reviewed by Alex Christensen.
- UIProcess/API/wpe/PageClientImpl.cpp:
ENABLE(VIDEO) && USE(GSTREAMER)
- UIProcess/WebPageProxy.h:
Cleanup the declaration.
- 11:13 AM Changeset in webkit [245242] by
-
- 4 edits4 adds in trunk
REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
https://bugs.webkit.org/show_bug.cgi?id=197818
<rdar://problem/50705762>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/scrolling/ios/event-region-scale-transform-shared.html
fast/scrolling/ios/event-region-translate-transform-shared.html
This fixes the assert. However the added tests demonstrate that transform is not taken into account
when computing the event region, https://bugs.webkit.org/show_bug.cgi?id=197836.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
LayoutTests:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt: Added.
- fast/scrolling/ios/event-region-scale-transform-shared.html: Added.
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt: Added.
- fast/scrolling/ios/event-region-translate-transform-shared.html: Added.
- platform/ios-wk2/TestExpectations:
- 11:04 AM Changeset in webkit [245241] by
-
- 7 edits in trunk/Source/WebKit
Move StorageManager.cpp into WebKit/Sources.txt
https://bugs.webkit.org/show_bug.cgi?id=197842
Reviewed by Michael Catanzaro.
StorageManager.cpp is used by all ports so it should just go into Sources.txt.
- PlatformMac.cmake:
- PlatformWin.cmake:
- Sources.txt:
- SourcesCocoa.txt:
- SourcesGTK.txt:
- SourcesWPE.txt:
- 10:56 AM Changeset in webkit [245240] by
-
- 33 edits in trunk/Source/WebKit
Update TBA macros for API / SPI that has already shipped
https://bugs.webkit.org/show_bug.cgi?id=197841
<rdar://problem/50698499>
Reviewed by Alex Christensen.
- Shared/API/Cocoa/_WKRenderingProgressEvents.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/Cocoa/WKBackForwardListItemPrivate.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.h:
- UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
- UIProcess/API/Cocoa/WKBrowsingContextHistoryDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
- UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
- UIProcess/API/Cocoa/WKConnection.h:
- UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKProcessGroup.h:
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKTypeRefWrapper.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKView.h:
(WK_CLASS_DEPRECATED_WITH_REPLACEMENT):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/Cocoa/_WKAttachment.h:
- UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h:
- UIProcess/API/Cocoa/_WKDownload.h:
- UIProcess/API/Cocoa/_WKFormInputSession.h:
- UIProcess/API/Cocoa/_WKInspector.h:
- UIProcess/API/Cocoa/_WKInternalDebugFeature.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- WebProcess/API/Cocoa/WKWebProcess.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
- 10:32 AM Changeset in webkit [245239] by
-
- 21 edits in trunk/Source
[JSC] Compress miscelaneous JIT related data structures with Packed<>
https://bugs.webkit.org/show_bug.cgi?id=197830
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch leverages Packed<> to compress miscelaneous data structures related to JIT.
- JIT IC data structures
- ValueRecovery
We use Packed<> for EncodedJSValue in ValueRecovery. This means that conservative GC cannot find
these values. But this is OK anyway since ValueRecovery's constant should be already registered
in DFG graph. From 16 (alignment 8) to 9 (alignment 1).
- FTL::ExitValue
We use Packed<> for EncodedJSValue in FTL::ExitValue. This is also OK since this constant should
be already registered by DFG/FTL graph. From 16 (alignment 8) to 9 (alignment 1).
- assembler/CodeLocation.h:
- bytecode/ByValInfo.h:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::callReturnLocation):
- bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::nearCallMode const):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addJITAddIC):
(JSC::CodeBlock::addJITMulIC):
(JSC::CodeBlock::addJITSubIC):
(JSC::CodeBlock::addJITNegIC):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addMathIC):
- bytecode/InlineCallFrame.h:
(JSC::InlineCallFrame::InlineCallFrame):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::inPair):
(JSC::ValueRecovery::inFPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::constant):
(JSC::ValueRecovery::directArgumentsThatWereNotCreated):
(JSC::ValueRecovery::clonedArgumentsThatWereNotCreated):
(JSC::ValueRecovery::gpr const):
(JSC::ValueRecovery::tagGPR const):
(JSC::ValueRecovery::payloadGPR const):
(JSC::ValueRecovery::fpr const):
(JSC::ValueRecovery::virtualRegister const):
(JSC::ValueRecovery::withLocalsOffset const):
(JSC::ValueRecovery::constant const):
(JSC::ValueRecovery::nodeID const):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileValueSub):
(JSC::DFG::SpeculativeJIT::compileValueNegate):
(JSC::DFG::SpeculativeJIT::compileValueMul):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::materializeNewObject):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsInt52):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::exitArgument const):
(JSC::FTL::ExitValue::adjustStackmapLocationsIndexByOffset):
(JSC::FTL::ExitValue::constant const):
(JSC::FTL::ExitValue::virtualRegister const):
(JSC::FTL::ExitValue::objectMaterialization const):
(JSC::FTL::ExitValue::withVirtualRegister const):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileUnaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
- jit/CachedRecovery.h:
- jit/CallFrameShuffleData.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emit_op_sub):
- jit/JITMathIC.h:
(JSC::isProfileEmpty):
(JSC::JITBinaryMathIC::JITBinaryMathIC):
(JSC::JITUnaryMathIC::JITUnaryMathIC):
- jit/PolymorphicCallStubRoutine.h:
(JSC::PolymorphicCallNode::hasCallLinkInfo):
- jit/SnippetOperand.h:
(JSC::SnippetOperand::asRawBits const):
(JSC::SnippetOperand::asConstInt32 const):
(JSC::SnippetOperand::asConstDouble const):
(JSC::SnippetOperand::setConstInt32):
(JSC::SnippetOperand::setConstDouble):
Source/WTF:
- wtf/Packed.h:
(WTF::alignof):
- 9:52 AM Changeset in webkit [245238] by
-
- 3 edits2 adds in trunk
[macOS] Font formatting options don't work when composing a message in Yahoo mail
https://bugs.webkit.org/show_bug.cgi?id=197813
<rdar://problem/49382250>
Reviewed by Darin Adler.
Source/WebCore:
The bug happens because on mousedown, the "Aa Font" menu item's event handler hides itself before changing the
font at the text selection. This causes us to clear the selection in FocusController::setFocusedElement.
There is existing logic in clearSelectionIfNeeded that would normally prevent us from clearing the selection due
to the mousePressNode not being able to start a selection. However, since the clickable element in this case is
hidden during mousedown, it is missing a renderer, and we bail from the `mousePressNode->renderer() &&
!mousePressNode->canStartSelection()` check as a result.
This check was orginally added in https://trac.webkit.org/r24334 to avoid clearing the selection when clicking
a button; the intention appears to have been making it so that clicking on something that could not start a
selection (back then, synonymous with -webkit-user-select: ignore;) would not clear the current selection; to
this end, it seems odd to additionally require that the thing being clicked should still have a renderer, so
it seems safe to remove this requirement.
Test: editing/selection/preserve-selection-when-clicking-button.html
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
LayoutTests:
Add a new layout test to verify that DOM selection is preserved after clicking a button that hides itself
upon mousedown.
- editing/selection/preserve-selection-when-clicking-button-expected.txt: Added.
- editing/selection/preserve-selection-when-clicking-button.html: Added.
- 9:32 AM Changeset in webkit [245237] by
-
- 2 edits in trunk/Source/WebKit
AX: Need an entitlement for WebContent to send accessibility notifications
https://bugs.webkit.org/show_bug.cgi?id=197832
Reviewed by Brent Fulgham.
In order to send accessibility notifications on iOS, we need to be able to look up this port.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 9:30 AM Changeset in webkit [245236] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=197793
<rdar://problem/46429187>
Unreviewed, build fix after r245199.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
- 8:39 AM Changeset in webkit [245235] by
-
- 2 edits in trunk/LayoutTests
[ Mojave Debug ] REGRESSION (r242975) Layout Test imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex7-event_order.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=195961
<rdar://problem/49031397>
Reviewed by Youenn Fablet.
r244674 should have fixed this regression.
- platform/mac-wk2/TestExpectations:
- 8:39 AM Changeset in webkit [245234] by
-
- 4 edits in trunk/Source
Unreviewed, fix unused variable warnings in release builds
Source/WebKit:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearWebProcessHasUploads):
Source/WTF:
- wtf/URLHelpers.cpp:
(WTF::URLHelpers::escapeUnsafeCharacters):
- 6:59 AM Changeset in webkit [245233] by
-
- 4 edits in trunk/Source/WebCore
WHLSLPrepare.cpp always recompiles, even if nothing was changed
https://bugs.webkit.org/show_bug.cgi?id=197151
Reviewed by Dan Bernstein and Keith Rollin.
- DerivedSources-input.xcfilelist: Script updated this automatically after
DerivedSources.make was corrected.
- DerivedSources-output.xcfilelist: Ditto, although I had to manually remove
one bogus leftover reference to WHLSLStandardLibrary.cpp.
- DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to
no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
was running on every build, instead of only when one of the dependencies changed.
- 1:10 AM WebKitGTK/2.24.x edited by
- (diff)
May 12, 2019:
- 11:51 PM Changeset in webkit [245232] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebCore
Cherry-pick r245197. rdar://problem/50628434
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
We have all the data we need, and this crash is happening more than
expected.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245231] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245195. rdar://problem/46548586
Returning incorrect marked text rects
https://bugs.webkit.org/show_bug.cgi?id=197758
<rdar://problem/46548586>
Reviewed by Tim Horton.
We are not returning marked text rects in the correct view coordinate space.
This is the same translation we are applying to the caret rects.
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformEditorState const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245230] by
-
- 3 edits2 adds in branches/safari-608.1.24-branch
Cherry-pick r245191. rdar://problem/48027412
[iOS] baidu.com: Synthetic bold renders too far apart, appears doubled.
https://bugs.webkit.org/show_bug.cgi?id=197781
<rdar://problem/48027412>
Reviewed by Simon Fraser.
Source/WebCore:
Synthetic bold is essentially two regular glyphs painted with an offset. While on macOS this offset is always 1px (CSS), on iOS larger font produces higher offset value. At paint time, this offset value (in CSS px unit) get converted
to a device pixel value taking context scale into account. This conversion ensures that the gap between the 2 regular glyphs won't get wider (in device pixels) as the user pinch zooms in.
This works as long as the scale on the context is >= 1. This patch ensures that a scaled down context won't blow up this gap.
Test: fast/text/large-synthetic-bold-with-scale-transform.html
- platform/graphics/cocoa/FontCascadeCocoa.mm: (WebCore::FontCascade::drawGlyphs):
LayoutTests:
- fast/text/large-synthetic-bold-with-scale-transform-expected.html: Added.
- fast/text/large-synthetic-bold-with-scale-transform.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245229] by
-
- 5 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245189. rdar://problem/50646747
Let WebKit clients supply an application name for user agent in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=197782
<rdar://problem/50646747>
Reviewed by Beth Dakin.
Add plumbing for a new private property on WKWebpagePreferences.
- UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]): (-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
- UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245228] by
-
- 17 edits in branches/safari-608.1.24-branch/Source
Cherry-pick r245183. rdar://problem/50065100
Add WKWebViewConfiguration._canShowWhileLocked SPI
https://bugs.webkit.org/show_bug.cgi?id=197777
<rdar://problem/50065100>
Reviewed by Tim Horton.
Source/WebCore/PAL:
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm: (WebKit::LayerHostingContext::createForExternalHostingProcess):
- Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::copy const):
- UIProcess/API/APIPageConfiguration.h: (API::PageConfiguration::canShowWhileLocked const): (API::PageConfiguration::setCanShowWhileLocked):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration _setCanShowWhileLocked:]): (-[WKWebViewConfiguration _canShowWhileLocked]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: (WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::canShowWhileLocked const):
- WebProcess/WebPage/WebPage.cpp: (WebKit::m_canShowWhileLocked): (WebKit::m_shrinkToFitContentTimer): Deleted.
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::canShowWhileLocked const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245227] by
-
- 3 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245153. rdar://problem/50604700
Guard long press link preview with a USE macro rather than complicated includes
https://bugs.webkit.org/show_bug.cgi?id=197728
<rdar://problem/50604700>
Reviewed by Wenson Hsieh.
It was getting complicated to manage the coordination between WebKitAdditions
and WebKit without having to split up the includes into multiple files
or have lots of duplication.
Instead, WebKitAdditions will now define a USE macro which can be used
in various places through WebKit.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView dragInteraction:itemsForBeginningSession:]): (-[WKContentView _contentsOfUserInterfaceItem:]): (previewIdentifierForElementAction): (-[WKContentView shouldUsePreviewForLongPress]): (-[WKContentView _registerPreview]): (-[WKContentView _unregisterPreview]): (shouldUsePreviewForLongPress): Deleted. (-[WKContentView _registerPreviewLongPress]): Deleted. (-[WKContentView _unregisterPreviewLongPress]): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245226] by
-
- 2 edits in branches/safari-608.1.24-branch/Source/WebKit
Cherry-pick r245148. rdar://problem/50457731
REGRESSION (r241734): 1% slower PLT on iPad
https://bugs.webkit.org/show_bug.cgi?id=197745
<rdar://problem/50457731>
Reviewed by Per Arne Vollan.
For now, only create a keyboard when WKContentView becomes first responder if a hardware keyboard
is attached or an editable element is focused to recover the 1% loss when a keyboard is not attached.
We can do better and by that I mean be lazier. We'll do this <https://bugs.webkit.org/show_bug.cgi?id=197746>.
In r241734 we unified the key event handling code paths so we use exactly one for both software and
hardware key events. We took a simple approach of always requesting UIKit to create a keyboard when
the WKContentView becomes first responder. We did this so that we could continue listening for hardware
key events even when a non-editable element is focused and dispatch DOM events. As it turns out, always
creating a keyboard is expensive and caused a ~1% slowdown in page load time on iPad.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _requiresKeyboardWhenFirstResponder]): Only create a keyboard if a hardware keyboard is attached or an editable element is focused. (-[WKContentView _hardwareKeyboardAvailabilityChanged]): Reload all input view (this will cause keyboard creation) if -_requiresKeyboardWhenFirstResponder returns YES.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 PM Changeset in webkit [245225] by
-
- 8 edits4 adds in branches/safari-608.1.24-branch
Cherry-pick r245144. rdar://problem/47902054
[iOS] Unable to commit search on MSN.com, qq.com, or sina.com.cn using enter key (hardware or software keyboard)
https://bugs.webkit.org/show_bug.cgi?id=197632
<rdar://problem/47902054>
Reviewed by Brent Fulgham.
Source/WebKit:
Fixes an issue where it is not possible to submit a <form> with target = "_blank": a form that
opens a new window.
By default we only allow popups to open if they were user initiated (like when a person clicks
on a link). We achieve this by putting a token on the stack, called the UserGestureToken when
WebCore processes an event from WebKit. So long as this token is on the stack we consider
all requests to open a popup to be user initiated. And we implicitly submit a form when pressing
the Return key in an HTML input element during the processing of a TextInputEvent dispatched as
part of inserting a '\n' into the field. On Mac, the keydown dispatches a TextInputEvent synchronously.
However on iOS text insertion, and hence a dispatch of a TextInputEvent event, occurs asynchronously
with respect to the keydown event. So, by the time the UI process calls back to the WebProcess
to perform the text insertion of '\n' we have long since popped the UserGestureToken off the stack
and hence we disallow opening a popup. To fix this, when -insertText is called we query the keyboard
to determine if it's being called by the keyboard. If it is then we can assume that this is
part of key event handling and hence was initiated by the user. We can pass along this detail
to the WebProcess for it to push a new UserGestureToken onto the stack.
For now we only track whether text inserted by the keyboard was user initiated or not. In
<https://bugs.webkit.org/show_bug.cgi?id=197721> we will fix this up for all editing commands.
- Platform/spi/ios/UIKitSPI.h: Expose SPI.
- Shared/Cocoa/InsertTextOptions.cpp: (IPC::ArgumentCoder<WebKit::InsertTextOptions>::encode): (IPC::ArgumentCoder<WebKit::InsertTextOptions>::decode): Encode and decode whether we are processing a user gesture.
- Shared/Cocoa/InsertTextOptions.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView insertText:]): Query the keyboard to determine whether it called us or the embedding client did. We only want to privilege user initiated actions (the keyboard).
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::insertTextAsync): Push a UserGestureToken onto the stack that is initialized depending on whether we are or are not processing a user gesture.
LayoutTests:
Add tests to ensure we fire input and keypress events in the correct order and that we can
submit a <form> with target = "_blank" using the Return key.
- fast/events/ios/fire-input-and-keypress-on-return-key-expected.txt: Added.
- fast/events/ios/fire-input-and-keypress-on-return-key.html: Added.
- fast/events/ios/submit-form-target-blank-using-return-key-expected.txt: Added.
- fast/events/ios/submit-form-target-blank-using-return-key.html: Added.
- platform/ios/TestExpectations: Skip the test until we have the UIKit SPI added in <rdar://problem/50596032>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:30 PM Changeset in webkit [245224] by
-
- 7 edits in branches/safari-608.1.24-branch/Source
Versioning.
- 11:15 PM Changeset in webkit [245223] by
-
- 7 edits in tags/Safari-608.1.23.1/Source
Versioning.
- 11:07 PM Changeset in webkit [245222] by
-
- 1 copy in tags/Safari-608.1.23.1
Tag Safari-608.1.23.1.
- 9:13 PM Changeset in webkit [245221] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r245208): compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html asserts
https://bugs.webkit.org/show_bug.cgi?id=197818
Approved by Jon Lee.
Skip this test until a fix for bug 197818 lands.
- platform/ios-wk2/TestExpectations:
- 8:57 PM Changeset in webkit [245220] by
-
- 3 edits2 adds in trunk
When the set of backing-sharing layers changes, we need to issue a repaint
https://bugs.webkit.org/show_bug.cgi?id=197825
Reviewed by Zalan Bujtas.
Source/WebCore:
If the set of layers painting into a shared backing store changes, we need
to repaint that backing store. This happens when scrolling as shared layers
enter the visible area.
Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setBackingSharingLayers):
LayoutTests:
- compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
- compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
- 8:07 PM Changeset in webkit [245219] by
-
- 6 edits in trunk/Source/WebCore
Add logging for RenderLayer clip rects
https://bugs.webkit.org/show_bug.cgi?id=197547
Reviewed by Zalan Bujtas.
Add a ClipRects log channel, and stream output for ClipRect and ClipRects.
The ClipRect code is performance sensitive, even in debug, so guard the log sites
with clipRectsLogEnabled() because the macro still evaluates its arguments even if
the channel is disabled (we need some better way to log that doesn't do this).
- platform/Logging.h:
- rendering/ClipRect.cpp:
(WebCore::operator<<):
- rendering/ClipRect.h:
- rendering/RenderLayer.cpp:
(WebCore::operator<<):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayer.h:
- 8:01 PM Changeset in webkit [245218] by
-
- 4 edits in trunk/Source/WebCore
Refactor composited backing-sharing code
https://bugs.webkit.org/show_bug.cgi?id=197824
Reviewed by Zalan Bujtas.
Clean up the backing-sharing code to share more code, and make it easier to understand.
Moves more logic into member functions on BackingSharingState, which are named to make
their functions clearer: startBackingSharingSequence/endBackingSharingSequence.
computeCompositingRequirements() and traverseUnchangedSubtree() now just call
updateBeforeDescendantTraversal/updateAfterDescendantTraversal.
No behavior change.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::willBeDestroyed):
(WebCore::RenderLayerBacking::setBackingSharingLayers): Remove the early return, since
we need to call setBackingProviderLayer() on the sharing layers in both code paths.
(WebCore::RenderLayerBacking::removeBackingSharingLayer):
(WebCore::RenderLayerBacking::clearBackingSharingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::BackingSharingState::backingProviderCandidate const):
(WebCore::RenderLayerCompositor::BackingSharingState::appendSharingLayer):
(WebCore::RenderLayerCompositor::BackingSharingState::startBackingSharingSequence):
(WebCore::RenderLayerCompositor::BackingSharingState::endBackingSharingSequence):
(WebCore::RenderLayerCompositor::BackingSharingState::updateBeforeDescendantTraversal):
(WebCore::RenderLayerCompositor::BackingSharingState::updateAfterDescendantTraversal):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::BackingSharingState::resetBackingProviderCandidate): Deleted.
- rendering/RenderLayerCompositor.h:
- 7:57 PM Changeset in webkit [245217] by
-
- 2 edits in trunk/Source/WebCore
Use clampTo in AVVideoCaptureSource::setSizeAndFrameRateWithPreset
https://bugs.webkit.org/show_bug.cgi?id=197704
Reviewed by Alex Christensen.
Use clampTo as suggested in bug 196214 review.
No change of behavior.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setSizeAndFrameRateWithPreset):
- 7:56 PM Changeset in webkit [245216] by
-
- 2 edits in trunk/Source/WebCore
Use the main screen for screen capture
https://bugs.webkit.org/show_bug.cgi?id=197804
<rdar://problem/47671383>
Reviewed by Eric Carlson.
If the main screen, i.e. the screen that has focus at the time of
selection of the screen to capture, is capturable, add it to the list
of screen devices, but do not add any other screen.
This will make sure the main screen is selected.
Manually tested.
- platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDevices):
- 4:05 PM Changeset in webkit [245215] by
-
- 8 edits4 adds in trunk
[Curl] Suppress extra didReceiveAuthenticationChallenge call when accessing a server which checks basic auth.
https://bugs.webkit.org/show_bug.cgi?id=197650
Patch by Takashi Komori <Takashi.Komori@sony.com> on 2019-05-12
Reviewed by Fujii Hironori.
Source/WebCore:
When Curl port accesses a page which checks Basic Authentication credential and server trust challenge occurs,
Curl port calls extra didReceiveAuthenticationChallenge unnecessarily.
This is because Curl port discards information about allowed server trust challenge before in NetworkDataTaskCurl::restartWithCredential.
Test: http/tests/ssl/curl/certificate-and-authentication.html
- platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::isServerTrustEvaluationDisabled):
Source/WebKit:
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::restartWithCredential):
LayoutTests:
- TestExpectations:
- http/tests/resources/basic-auth.php: Added.
- http/tests/ssl/curl/certificate-and-authentication-expected.txt: Added.
- http/tests/ssl/curl/certificate-and-authentication.html: Added.
- platform/wincairo-wk1/TestExpectations:
- platform/wincairo/TestExpectations:
- 3:50 PM Changeset in webkit [245214] by
-
- 33 edits5 adds in trunk
[JSC] Compress Watchpoint size by using enum type and Packed<> data structure
https://bugs.webkit.org/show_bug.cgi?id=197730
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Watchpoint takes 5~ MB memory in Gmail (total memory starts with 400 - 500 MB), so 1~%. Since it is allocated massively,
reducing each size of Watchpoint reduces memory footprint significantly.
As a first step, this patch uses Packed<> and enum to reduce the size of Watchpoint.
- Watchpoint should have enum type and should not use vtable. vtable takes one pointer, and it is too costly for such a memory sensitive objects. We perform downcast and dispatch the method of the derived classes based on this enum. Since the # of derived Watchpoint classes are limited (Only 8), we can list up them easily. One unfortunate thing is that we cannot do this for destructor so long as we use "delete" for deleting objects. If we dispatch the destructor of derived class in the destructor of the base class, we call the destructor of the base class multiple times. delete operator override does not help since custom delete operator is called after the destructor is called. While we can fix this issue by always using custom deleter, currently we do not since all the watchpoints do not have members which have non trivial destructor. Once it is strongly required, we can start using custom deleter, but for now, we do not need to do this.
- We use Packed<> to compact pointers in Watchpoint. Since Watchpoint is a node of doubly linked list, each one has two pointers for prev and next. This is also too costly. PackedPtr reduces the size and makes alignment 1.S
- We use PackedCellPtr<> for JSCells in Watchpoint. This leverages alignment information and makes pointers smaller in Darwin ARM64. One important thing to note here is that since this pointer is packed, it cannot be found by conservative GC scan. It is OK for watchpoint since they are allocated in the heap anyway.
We applied this change to Watchpoint and get the following memory reduction. The highlight is that CodeBlockJettisoningWatchpoint in
ARM64 only takes 2 pointers size.
ORIGINAL X86_64 ARM64
WatchpointSet: 40 32 28
CodeBlockJettisoningWatchpoint: 32 19 15
StructureStubClearingWatchpoint: 56 48 40
AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint: 24 13 11
AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint: 24 13 11
FunctionRareData::AllocationProfileClearingWatchpoint: 32 19 15
ObjectToStringAdaptiveStructureWatchpoint: 56 48 40
LLIntPrototypeLoadAdaptiveStructureWatchpoint: 64 48 48
DFG::AdaptiveStructureWatchpoint: 56 48 40
While we will re-architect the mechanism of Watchpoint, anyway Packed<> mechanism and enum types will be used too.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
- bytecode/CodeBlockJettisoningWatchpoint.h:
- bytecode/CodeOrigin.h:
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::LLIntPrototypeLoadAdaptiveStructureWatchpoint):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::fireInternal):
- bytecode/StructureStubClearingWatchpoint.h:
- bytecode/Watchpoint.cpp:
(JSC::Watchpoint::fire):
- bytecode/Watchpoint.h:
(JSC::Watchpoint::Watchpoint):
- dfg/DFGAdaptiveStructureWatchpoint.cpp:
(JSC::DFG::AdaptiveStructureWatchpoint::AdaptiveStructureWatchpoint):
- dfg/DFGAdaptiveStructureWatchpoint.h:
- heap/PackedCellPtr.h: Added.
- runtime/FunctionRareData.h:
- runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp: Added.
(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
- runtime/ObjectToStringAdaptiveStructureWatchpoint.h: Added.
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::clearObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint): Deleted.
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install): Deleted.
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal): Deleted.
- runtime/StructureRareData.h:
Source/WTF:
This patch introduces a new data structures, WTF::Packed, WTF::PackedPtr, and WTF::PackedAlignedPtr.
- WTF::Packed
WTF::Packed is data storage. We can read and write trivial (in C++ term [1]) data to this storage. The difference to
the usual storage is that the alignment of this storage is always 1. We access the underlying data by using unalignedLoad/unalignedStore.
This class offers alignment = 1 data structure instead of missing the following characteristics.
- Load / Store are non atomic even if the data size is within a pointer width. We should not use this for a member which can be accessed in a racy way. (e.g. fields accessed optimistically from the concurrent compilers).
- We cannot take reference / pointer to the underlying storage since they are unaligned.
- Access to this storage is unaligned access. The code is using memcpy, and the compiler will convert to an appropriate unaligned access in certain architectures (x86_64 / ARM64). It could be slow. So use it for non performance sensitive & memory sensitive places.
- WTF::PackedPtr
WTF::PackedPtr is a specialization of WTF::Packed<T*>. And it is basically WTF::PackedAlignedPtr with alignment = 1. We further compact
the pointer by leveraging the platform specific knowledge. In 64bit architectures, the effective width of pointers are less than 64 bit.
In x86_64, it is 48 bits. And Darwin ARM64 is further smaller, 36 bits. This information allows us to compact the pointer to 6 bytes in
x86_64 and 5 bytes in Darwin ARM64.
- WTF::PackedAlignedPtr
WTF::PackedAlignedPtr is the WTF::PackedPtr with alignment information of the T. If we use this alignment information, we could reduce the
size of packed pointer further in some cases. For example, since we guarantee that JSCells are 16 byte aligned, low 4 bits are empty. Leveraging
this information in Darwin ARM64 platform allows us to make packed JSCell pointer 4 bytes (36 - 4 bits). We do not use passed alignment
information if it is not profitable.
We also have PackedPtrTraits. This is new PtrTraits and use it for various data structures such as Bag<>.
[1]: https://en.cppreference.com/w/cpp/types/is_trivial
- WTF.xcodeproj/project.pbxproj:
- wtf/Bag.h:
(WTF::Bag::clear):
(WTF::Bag::iterator::operator++):
- wtf/CMakeLists.txt:
- wtf/DumbPtrTraits.h:
- wtf/DumbValueTraits.h:
- wtf/MathExtras.h:
(WTF::clzConstexpr):
(WTF::clz):
(WTF::ctzConstexpr):
(WTF::ctz):
(WTF::getLSBSetConstexpr):
(WTF::getMSBSetConstexpr):
- wtf/Packed.h: Added.
(WTF::Packed::Packed):
(WTF::Packed::get const):
(WTF::Packed::set):
(WTF::Packed::operator=):
(WTF::Packed::exchange):
(WTF::Packed::swap):
(WTF::alignof):
(WTF::PackedPtrTraits::exchange):
(WTF::PackedPtrTraits::swap):
(WTF::PackedPtrTraits::unwrap):
- wtf/Platform.h:
- wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::PtrTraits>::remove):
(WTF::PtrTraits>::prepend):
(WTF::PtrTraits>::append):
(WTF::RawNode>::SentinelLinkedList):
(WTF::RawNode>::remove):
(WTF::BasicRawSentinelNode<T>::remove): Deleted.
(WTF::BasicRawSentinelNode<T>::prepend): Deleted.
(WTF::BasicRawSentinelNode<T>::append): Deleted.
- wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOfImpl):
(WTF::roundUpToMultipleOfImpl0): Deleted.
- wtf/UnalignedAccess.h:
(WTF::unalignedLoad):
(WTF::unalignedStore):
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
(TestWebKitAPI::TEST):
- 12:43 PM Changeset in webkit [245213] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
[JSC] Compact generator code's bytecode size
https://bugs.webkit.org/show_bug.cgi?id=197822
Reviewed by Michael Saboff.
op_put_to_scope's symbolTableOrScopeDepth is represented as int. This was OK for the old bytecode format since
VirtualRegister / scope depth can be represented by int anyway. But it is problematic now since only int8_t range
will be represented in narrow bytecode. When this field is used for symbol table constant index, it is always
larger than FirstConstantRegisterIndex. So it always exceeds the range of int8_t, and results in wide bytecode.
It makes all generator's op_put_to_scope wide bytecode.
In this patch, we introduce a new (logically) union type SymbolTableOrScopeDepth. It holds unsigned value, and we store the
SymbolTableConstantIndex - FirstConstantRegisterIndex in this unsigned value to make op_put_to_scope narrow bytecode.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeGeneratorification.cpp:
(JSC::BytecodeGeneratorification::run):
- bytecode/BytecodeList.rb:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
- bytecode/Fits.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::localScopeDepth const):
- bytecompiler/BytecodeGenerator.h:
- runtime/SymbolTableOrScopeDepth.h: Added.
(JSC::SymbolTableOrScopeDepth::symbolTable):
(JSC::SymbolTableOrScopeDepth::scopeDepth):
(JSC::SymbolTableOrScopeDepth::raw):
(JSC::SymbolTableOrScopeDepth::symbolTable const):
(JSC::SymbolTableOrScopeDepth::scopeDepth const):
(JSC::SymbolTableOrScopeDepth::raw const):
(JSC::SymbolTableOrScopeDepth::dump const):
(JSC::SymbolTableOrScopeDepth::SymbolTableOrScopeDepth):
May 11, 2019:
- 4:17 PM Changeset in webkit [245212] by
-
- 6 edits3 adds in trunk
Overflow scroll that becomes non-scrollable should stop being composited
https://bugs.webkit.org/show_bug.cgi?id=197817
<rdar://problem/50697290>
Reviewed by Antti Koivisto.
Source/WebCore:
Remove the iOS-specific #ifdef around code that triggers a compositing re-evaluation
when scrolling state changes.
Test: compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
LayoutTests:
Put in a compositing/scrolling/async-overflow-scrolling dir so we can enable it only
for platforms that have async overflow scrolling.
- TestExpectations:
- compositing/scrolling/async-overflow-scrolling/become-non-scrollable-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 4:14 PM Changeset in webkit [245211] by
-
- 2 edits in trunk/LayoutTests
Cleaning up results for legacy-animation-engine tests
Two tests were fixed in bug 188357.
The third one is still broken, and we have bug 184611 tracking it.
- platform/mac-wk1/TestExpectations:
- 4:02 PM Changeset in webkit [245210] by
-
- 2 edits in trunk/LayoutTests
Removing flaky expectation for fast/repaint/canvas-object-fit.html
https://bugs.webkit.org/show_bug.cgi?id=188910
- platform/mac-wk1/TestExpectations:
- 3:29 PM Changeset in webkit [245209] by
-
- 2 edits in trunk/LayoutTests
Removing flaky expectation for fast/animation/request-animation-frame.html
https://bugs.webkit.org/show_bug.cgi?id=190888
- platform/ios-wk2/TestExpectations:
- 3:22 PM Changeset in webkit [245208] by
-
- 3 edits8 adds in trunk
Layer bounds are incorrect for sharing layers that paint with transforms
https://bugs.webkit.org/show_bug.cgi?id=197768
<rdar://problem/50695493>
Reviewed by Zalan Bujtas.
Source/WebCore:
We don't need to traverse shared layers if the backing-provider has overflow clip,
because we know they are containing-block descendants and therefore clipped.
Note tha the CSS "clip" property doesn't guarantee this, because the clip rect
can be larger than the element, so in that case we just traverse shared layers.
Tests: compositing/shared-backing/sharing-bounds-clip.html
compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html
compositing/shared-backing/sharing-bounds-transformed-sharing-layer.html
compositing/shared-backing/sharing-bounds.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
LayoutTests:
Tests for backing-shared layer bounds in various configurations.
- compositing/shared-backing/sharing-bounds-clip-expected.txt: Added.
- compositing/shared-backing/sharing-bounds-clip.html: Added.
- compositing/shared-backing/sharing-bounds-expected.txt: Added.
- compositing/shared-backing/sharing-bounds-non-clipping-shared-layer-expected.txt: Added.
- compositing/shared-backing/sharing-bounds-non-clipping-shared-layer.html: Added.
- compositing/shared-backing/sharing-bounds-transformed-sharing-layer-expected.txt: Added.
- compositing/shared-backing/sharing-bounds-transformed-sharing-layer.html: Added.
- compositing/shared-backing/sharing-bounds.html: Added.
- 3:05 PM Changeset in webkit [245207] by
-
- 4 edits2 adds in trunk
Translucent gradient rendering bug due to will-change transform
https://bugs.webkit.org/show_bug.cgi?id=197654
<rdar://problem/50547664>
Reviewed by Dean Jackson.
Source/WebCore:
We failed to re-evaluate 'contentsOpaque' when a background changed, because this
happened in updateGeometry() and that doesn't run for background changes.
However, 'contentsOpaque' also requires knowing about geometry because we have to
turn it off when there's subpixel positioning, and updateConfiguration()
runs before updateGeometry().
So compute m_hasSubpixelRounding in updateGeometry() and set contentsOpaque in
updateAfterDescendants().
Test: compositing/contents-opaque/background-change-to-transparent.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateAfterDescendants):
- rendering/RenderLayerBacking.h:
LayoutTests:
- compositing/contents-opaque/background-change-to-transparent-expected.txt: Added.
- compositing/contents-opaque/background-change-to-transparent.html: Added.
- 1:58 PM Changeset in webkit [245206] by
-
- 3 edits2 adds in trunk
When the scroller hosting a shared layer becomes non-scrollable, content disappears
https://bugs.webkit.org/show_bug.cgi?id=197766
<rdar://problem/50695808>
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderLayerCompositor::requiresOwnBackingStore() should return true for a layer that shares
its backing store. We always made backing for overlap layers, so even if the sharing layers
have no painted content, this should rarely be a backing store memory regression.
Test: compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
LayoutTests:
- compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable-expected.html: Added.
- compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html: Added.
- 10:35 AM Changeset in webkit [245205] by
-
- 6 edits14 adds in trunk
Backing-sharing layers with transforms render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=197692
<rdar://problem/50652127>
Reviewed by Antti Koivisto.
Source/WebCore:
Layers that paint into shared backing need to enter the RenderLayer painting code
in a way that paints the filters, transforms, opacity and blending.
RenderLayerBacking::paintIntoLayer() normally enters at paintLayerContents(), because
the effects are rendered via the GraphicsLayer, but shared layers will paint effects.
Note that if the backing-provider has effects, it will be the stacking context
for the shared layers, so it's correct that sharing layers are impacted by effects
on the backing-provider.
In addition, we have to ensure that we don't over-eagerly make layers shared.
Consider:
<div class="clipping">
<div class="sharing">
<div class="inner">
</div>
</div>
</div>
Here "clipping" is the provider layer, "sharing" paints into shared backing, but
we don't want to also mark "inner" as sharing, since "sharing" will just paint it.
This is akin to avoiding unnecessary compositing of z-order descendants when they can just
paint.
To do this we need to ensure that sharing layers are treated like compositing layers
in the overlap map, i.e. when a layer is sharing, we call overlapMap.pushCompositingContainer(),
and later overlapMap.popCompositingContainer().
Tests: compositing/shared-backing/nested-shared-layers-with-opacity.html
compositing/shared-backing/shared-layer-has-blending.html
compositing/shared-backing/shared-layer-has-filter.html
compositing/shared-backing/shared-layer-has-opacity.html
compositing/shared-backing/shared-layer-has-reflection.html
compositing/shared-backing/shared-layer-has-transform.html
compositing/shared-backing/shared-layer-isolates-blending.html
compositing/shared-backing/shared-transformed-layer-bounds.html
compositing/shared-backing/sharing-layer-becomes-non-scrollable.html
compositing/shared-backing/sharing-layer-has-effect.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerWithEffects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::CompositingState::stateForPaintOrderChildren const):
(WebCore::backingProviderLayerCanIncludeLayer):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
LayoutTests:
Ref tests for effects on sharing layers. The references make "clipping" be stacking context via z-index,
which eliminates sharing.
- compositing/shared-backing/nested-shared-layers-with-opacity-expected.html: Added.
- compositing/shared-backing/nested-shared-layers-with-opacity.html: Added.
- compositing/shared-backing/shared-layer-has-blending-expected.html: Added.
- compositing/shared-backing/shared-layer-has-blending.html: Added.
- compositing/shared-backing/shared-layer-has-filter-expected.html: Added.
- compositing/shared-backing/shared-layer-has-filter.html: Added.
- compositing/shared-backing/shared-layer-has-opacity-expected.html: Added.
- compositing/shared-backing/shared-layer-has-opacity.html: Added.
- compositing/shared-backing/shared-layer-has-reflection-expected.html: Added.
- compositing/shared-backing/shared-layer-has-reflection.html: Added.
- compositing/shared-backing/shared-layer-has-transform-expected.html: Added.
- compositing/shared-backing/shared-layer-has-transform.html: Added.
- compositing/shared-backing/shared-layer-isolates-blending-expected.html: Added.
- compositing/shared-backing/shared-layer-isolates-blending.html: Added.
May 10, 2019:
- 7:15 PM Changeset in webkit [245204] by
-
- 2 edits in trunk/Tools
Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
It became flaky after r245198.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 6:40 PM Changeset in webkit [245203] by
-
- 3 edits1 add in trunk
Call to JSToWasmICCallee::createStructure passes in wrong prototype value
https://bugs.webkit.org/show_bug.cgi?id=197807
<rdar://problem/50530400>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/js-to-wasm-callee-has-correct-prototype.js: Added.
(test.getInstance):
(test):
Source/JavaScriptCore:
We were passing the empty value instead of null. However, the empty
value means the Structure is poly proto. That's definitely not the case
here.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- 5:39 PM Changeset in webkit [245202] by
-
- 2 edits in trunk/Source/WTF
Bag's move operator= leaks memory
https://bugs.webkit.org/show_bug.cgi?id=197757
Reviewed by Keith Miller.
It was unused. So I'm just removing it. We can implement it properly
if we ever need it.
- wtf/Bag.h:
(WTF::Bag::operator=): Deleted.
- 4:42 PM Changeset in webkit [245201] by
-
- 13 edits in trunk/JSTests
[Test262] Unreviewed expectations update following r245188.
- test262/config.yaml:
- test262/expectations.yaml:
- test262/test/intl402/DateTimeFormat/prototype/formatRange/date-is-infinity-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRange/date-is-nan-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRange/date-undefined-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRange/date-x-greater-than-y-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRange/this-is-not-object-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-is-infinity-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-is-nan-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-undefined-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/date-x-greater-than-y-throws.js:
- test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/this-is-not-object-throws.js:
These files have invalid YAML comments. Will also submit corrections back to Test262.
- 4:33 PM Changeset in webkit [245200] by
-
- 4 edits in trunk
A service worker instance should be terminated when its SWServer is destroyed
https://bugs.webkit.org/show_bug.cgi?id=197801
<rdar://problem/50587270>
Reviewed by Chris Dumez.
Source/WebCore:
On session destruction, the SWServer is destroyed.
At that time, it should terminate all its running service workers.
Covered by updated API test.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::~SWServer):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- 4:29 PM Changeset in webkit [245199] by
-
- 4 edits in trunk/Source/WebCore
[iOS] HTMLMediaElement sometimes doesn't send 'webkitplaybacktargetavailabilitychanged' event
https://bugs.webkit.org/show_bug.cgi?id=197793
<rdar://problem/46429187>
Reviewed by Jer Noble.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::MediaElementSession): Initialize m_hasPlaybackTargets.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange): Log
target availability.
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]): Call the client
externalOutputDeviceAvailableDidChange method after the AVRouteDetector is available.
- 4:25 PM Changeset in webkit [245198] by
-
- 5 edits in trunk/Source/WebKit
[PSON] Prevent flashing when the process-swap is forced by the client
https://bugs.webkit.org/show_bug.cgi?id=197799
Reviewed by Geoffrey Garen.
When the process-swap is forced by the client, we would not construct a SuspendedPageProxy for
the previous page, which would cause a white/black flash upon navigation on macOS. The reason
we did not construct a SuspendedPageProxy is that it would be unsafe to keep the page around
in this case because other windows might have an opener link to the page when the swap is forced
and we need those opener / openee links to get severed.
The new approach to maintain the Web facing behavior without flashing is to create a suspended
page proxy for the previous page when the process swap is forced by the client. We then close
the page as soon as we can do so without flashing (when pageEnteredAcceleratedCompositingMode()
has been called).
- UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
(WebKit::SuspendedPageProxy::close):
(WebKit::SuspendedPageProxy::pageEnteredAcceleratedCompositingMode):
(WebKit::SuspendedPageProxy::closeWithoutFlashing):
(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
- UIProcess/SuspendedPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
(WebKit::WebPageProxy::commitProvisionalPage):
- UIProcess/WebPageProxy.h:
- 2:36 PM Changeset in webkit [245197] by
-
- 2 edits in trunk/Source/WebCore
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
We have all the data we need, and this crash is happening more than
expected.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- 2:28 PM Changeset in webkit [245196] by
-
- 2 edits in trunk/Source/WebKit
Streamline test-and-clear operation for ContextMenu
https://bugs.webkit.org/show_bug.cgi?id=197795
<rdar://problem/50473746>
Reviewed by Wenson Hsieh.
Rather than performing a check when entering the function, doing work,
then clearing the member variable, perform the check and clear in
a single operation. Only perform the selection if the menu exists.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didSelectItemFromActiveContextMenu):
- 1:52 PM Changeset in webkit [245195] by
-
- 2 edits in trunk/Source/WebKit
Returning incorrect marked text rects
https://bugs.webkit.org/show_bug.cgi?id=197758
<rdar://problem/46548586>
Reviewed by Tim Horton.
We are not returning marked text rects in the correct view coordinate space.
This is the same translation we are applying to the caret rects.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState const):
- 1:49 PM Changeset in webkit [245194] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] String substring operation should return ropes consistently
https://bugs.webkit.org/show_bug.cgi?id=197765
<rdar://problem/37689944>
Reviewed by Michael Saboff.
Currently we have different policies per string substring operation function.
- String#slice returns the resolved non-rope string
- String#substring returns rope string
- String#substr returns rope string in runtime function, non-rope string in DFG and FTL
Due to (3), we see large memory use in the tested web page[1]. Non rope substring have a problem.
First of all, that returned string seems not used immediately. It is possible that the resulted
string is used as a part of the other ropes (like, xxx.substring(...) + "Hello"). To avoid the
eager materialization of the string, we are using StringImpl::createSubstringSharingImpl for the
resulted non rope string. StringImpl::createSubstringSharingImpl is StringImpl's substring feature: the
substring is pointing the owner StringImpl. While this has memory saving benefit, it can retain owner
StringImpl so long, and it could keep very large owner StringImpl alive.
The problem we are attempting to solve with StringImpl::createSubstringSharingImpl can be solved by
the rope string simply. Rope string can share the underlying string. And good feature of the rope
string is that, when resolving rope string, the rope string always create a new StringImpl instead of
using StringImpl::createSubstringSharingImpl. So we allow the owner StringImpl to be destroyed. And this
resolving only happens when we actually want to use the content of the rope string. In addition, we recently
shrunk the sizeof(JSRopeString) from 48 to 32, so JSRopeString is cheap.
In this patch, we change (2) and (3) to (1), using rope String as a result of substring operations.
RAMification and JetStream2 are neutral. The web page[1] shows large memory footprint improvement from 776MB to 681MB.
[1]: https://beta.observablehq.com/@ldgardner/assignment-4-visualizations-and-multiple-views
- dfg/DFGOperations.cpp:
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSlice):
- runtime/StringPrototypeInlines.h:
(JSC::stringSlice):
- 1:42 PM Changeset in webkit [245193] by
-
- 1 copy in tags/Safari-608.1.24.1
Tag Safari-608.1.24.1.
- 1:37 PM Changeset in webkit [245192] by
-
- 2 edits in trunk/Source/JavaScriptCore
testb3 failing with crash in JSC::B3::BasicBlock::appendNonTerminal
https://bugs.webkit.org/show_bug.cgi?id=197756
<rdar://problem/50641659>
Reviewed by Saam Barati.
When I added https://bugs.webkit.org/show_bug.cgi?id=197265 I assumed that which block is the root does not change in the middle of strength reduction.
But specializeSelect can use splitForward, which uses a new block for the first half of the given block.
So if the block being split is the root block I must update m_root and erase the m_valueInConstant cache.
Erasing the cache cannot cause wrong results: at most it can make us miss some optimization opportunities in this iteration of the fixpoint.
- b3/B3ReduceStrength.cpp:
- 1:30 PM Changeset in webkit [245191] by
-
- 3 edits2 adds in trunk
[iOS] baidu.com: Synthetic bold renders too far apart, appears doubled.
https://bugs.webkit.org/show_bug.cgi?id=197781
<rdar://problem/48027412>
Reviewed by Simon Fraser.
Source/WebCore:
Synthetic bold is essentially two regular glyphs painted with an offset. While on macOS this offset is always 1px (CSS), on iOS larger font produces higher offset value. At paint time, this offset value (in CSS px unit) get converted
to a device pixel value taking context scale into account. This conversion ensures that the gap between the 2 regular glyphs won't get wider (in device pixels) as the user pinch zooms in.
This works as long as the scale on the context is >= 1. This patch ensures that a scaled down context won't blow up this gap.
Test: fast/text/large-synthetic-bold-with-scale-transform.html
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::drawGlyphs):
LayoutTests:
- fast/text/large-synthetic-bold-with-scale-transform-expected.html: Added.
- fast/text/large-synthetic-bold-with-scale-transform.html: Added.
- 1:10 PM Changeset in webkit [245190] by
-
- 2 edits in trunk/Source/WebCore
Gracefully handle inaccessible font face data
https://bugs.webkit.org/show_bug.cgi?id=197762
<rdar://problem/50433861>
Reviewed by Per Arne Vollan.
Make sure CSS Font Face handling gracefully recovers from
missing font data.
Test: fast/text/missing-font-crash.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoadEventOccurred):
(WebCore::CSSFontFace::timeoutFired):
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::font):
- 12:58 PM Changeset in webkit [245189] by
-
- 5 edits in trunk/Source/WebKit
Let WebKit clients supply an application name for user agent in modern compatibility mode
https://bugs.webkit.org/show_bug.cgi?id=197782
<rdar://problem/50646747>
Reviewed by Beth Dakin.
Add plumbing for a new private property on WKWebpagePreferences.
- UIProcess/API/APIWebsitePolicies.cpp:
(API::WebsitePolicies::copy const):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _applicationNameForUserAgentWithModernCompatibility]):
(-[WKWebpagePreferences _setApplicationNameForUserAgentWithModernCompatibility:]):
- UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
- 12:45 PM Changeset in webkit [245188] by
-
- 1499 edits296 adds51 deletes in trunk/JSTests
Update test262 tests.
- 12:41 PM Changeset in webkit [245187] by
-
- 2 edits in trunk/Source/WebKit
The active tab sometimes app naps even though it should not
https://bugs.webkit.org/show_bug.cgi?id=197791
<rdar://problem/48460054>
Reviewed by Geoffrey Garen.
The WebPage constructor was initializing m_activityState but not calling updateThrottleState().
As a result, we would not take a UserActivity even when warranted by the initial activity state.
- WebProcess/WebPage/WebPage.cpp:
- 12:01 PM Changeset in webkit [245186] by
-
- 14 edits in trunk/Source
[WinCairo] storage/indexeddb tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=196289
Reviewed by Alex Christensen.
Source/WebKit:
storage/indexeddb tests were timing out for WinCairo port because
WebKit::NetworkCache classes were not implemented yet for Windows.
Implement WebKit::NetworkCache classes by using WTF::FileSystem
functions.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::readFile): Use
IOChannel::isOpened() to check the channel is opened instead of
checking the file descriptor.
- NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::add):
(WebKit::NetworkCache::BlobStorage::remove):
- NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::Data::mapToFile const):
(WebKit::NetworkCache::mapFile):
(WebKit::NetworkCache::adoptAndMapFile):
(WebKit::NetworkCache::makeSalt):
(WebKit::NetworkCache::readOrMakeSalt):
- NetworkProcess/cache/NetworkCacheData.h:
(WebKit::NetworkCache::Data::isEmpty const):
(WebKit::NetworkCache::Data::size const):
- NetworkProcess/cache/NetworkCacheDataCurl.cpp:
(WebKit::NetworkCache::Data::Data):
(WebKit::NetworkCache::Data::empty):
(WebKit::NetworkCache::Data::data const):
(WebKit::NetworkCache::Data::isNull const):
(WebKit::NetworkCache::Data::apply const):
(WebKit::NetworkCache::Data::subrange const):
(WebKit::NetworkCache::concatenate):
(WebKit::NetworkCache::Data::adoptMap): Deleted.
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::traverseDirectory):
(WebKit::NetworkCache::fileTimes):
(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
- NetworkProcess/cache/NetworkCacheIOChannel.h:
(WebKit::NetworkCache::IOChannel::isOpened const):
(WebKit::NetworkCache::IOChannel::fileDescriptor const): Deleted.
- NetworkProcess/cache/NetworkCacheIOChannelCurl.cpp:
(WebKit::NetworkCache::IOChannel::IOChannel):
(WebKit::NetworkCache::IOChannel::~IOChannel):
(WebKit::NetworkCache::runTaskInQueue):
(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::write):
Source/WTF:
- wtf/FileSystem.h: Added hardLink.
- wtf/glib/FileSystemGlib.cpp:
(WTF::FileSystemImpl::hardLink):
(WTF::FileSystemImpl::hardLinkOrCopyFile):
- wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::hardLink):
(WTF::FileSystemImpl::hardLinkOrCopyFile):
- wtf/win/FileSystemWin.cpp:
(WTF::FileSystemImpl::hardLink):
(WTF::FileSystemImpl::hardLinkOrCopyFile):
Added hardLink. Let hardLinkOrCopyFile use the hardLink.
- 12:01 PM Changeset in webkit [245185] by
-
- 6 edits in trunk
Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
https://bugs.webkit.org/show_bug.cgi?id=197750
Reviewed by Geoffrey Garen.
Source/WebKit:
The UIProcess remembers previous device orientation permission decisions per origin for the duration of the browsing
session. However, the WebContent process was not aware of previous decisions and would therefore not fire any
deviceorientation / devicemotion events until the JS has called requestPermission(). This patches addresses this
problem by having the UIProcess communicate any previous permission decision for the origin via WebSitePolicies.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
- UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp:
(WebKit::WebDeviceOrientationAndMotionAccessController::shouldAllowAccess):
(WebKit::WebDeviceOrientationAndMotionAccessController::cachedDeviceOrientationPermission const):
(WebKit::WebDeviceOrientationAndMotionAccessController::deviceOrientationPermission const): Deleted.
- UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
(TEST):
- 11:56 AM Changeset in webkit [245184] by
-
- 1 edit1 delete in trunk/Tools
Remove legacy test262 import script
https://bugs.webkit.org/show_bug.cgi?id=197788
Reviewed by Yusuke Suzuki.
import-test262-tests doesn't work anymore. We should be using test262-import instead.
- Scripts/import-test262-tests: Removed.
- 11:52 AM Changeset in webkit [245183] by
-
- 17 edits in trunk/Source
Add WKWebViewConfiguration._canShowWhileLocked SPI
https://bugs.webkit.org/show_bug.cgi?id=197777
<rdar://problem/50065100>
Reviewed by Tim Horton.
Source/WebCore/PAL:
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForExternalHostingProcess):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::canShowWhileLocked const):
(API::PageConfiguration::setCanShowWhileLocked):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setCanShowWhileLocked:]):
(-[WKWebViewConfiguration _canShowWhileLocked]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h:
- WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::canShowWhileLocked const):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_canShowWhileLocked):
(WebKit::m_shrinkToFitContentTimer): Deleted.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::canShowWhileLocked const):
- 11:46 AM Changeset in webkit [245182] by
-
- 2 edits in trunk/Tools
[WPE] Forward libepoxy cflags
https://bugs.webkit.org/show_bug.cgi?id=197784
Reviewed by Žan Doberšek.
- wpe/backends/CMakeLists.txt: This is required to keep
-DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
up trying to include X11 headers even when they're not present in the
environment.
- 11:40 AM Changeset in webkit [245181] by
-
- 3 edits2 adds in trunk
ASSERT(isSelfPaintingLayer() hasSelfPaintingLayerDescendant()) on nytimes.com after r245170 https://bugs.webkit.org/show_bug.cgi?id=197776
Reviewed by Zalan Bujtas.
Source/WebCore:
Only try to paint into shared backing for layers that are able to be composited. This
avoids trying to do sharing for non-self-painting layers, which doesn't make sense.
Test: compositing/shared-backing/overflow-scroll/non-self-painting-layer-should-not-share.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
LayoutTests:
- compositing/shared-backing/overflow-scroll/non-self-painting-layer-should-not-share-expected.txt: Added.
- compositing/shared-backing/overflow-scroll/non-self-painting-layer-should-not-share.html: Added.
- 11:15 AM Changeset in webkit [245180] by
-
- 7 edits in branches/safari-608.1.24-branch/Source
Versioning.
- 11:03 AM Changeset in webkit [245179] by
-
- 13 edits in trunk
Fix a bunch of compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=197785
Reviewed by Don Olmstead.
Source/ThirdParty/ANGLE:
Add compiler flags to suppress various warnings triggered by the new version of ANGLE.
- CMakeLists.txt:
Source/WebCore:
- CMakeLists.txt: WebCoreTestSupport should accept extra SYSTEM includes.
- PlatformGTK.cmake: GTK includes should be added to SYSTEM headers to avoid warnings.
- inspector/InspectorCanvas.cpp: Add preprocessor guards to fix unused function warning.
- rendering/RenderLayer.cpp: Fix unused variable warning.
(WebCore::RenderLayer::updateClipRects):
Source/WebKit:
Guard Cocoa-specific format modifier to avoid -Wformat warning.
- NetworkProcess/AdClickAttributionManager.cpp:
(WebKit::AdClickAttributionManager::fireConversionRequest):
Tools:
Add preprocessor guards to avoid -Wunused-function warnings.
- TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
- TestWebKitAPI/Tests/WebCore/IntRect.cpp:
- TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
- 10:19 AM Changeset in webkit [245178] by
-
- 3 edits2 adds in trunk
AX: Crash at WebKit: WebKit::WebSpeechSynthesisClient::speak
https://bugs.webkit.org/show_bug.cgi?id=197761
<rdar://problem/50237614>
Reviewed by Per Arne Vollan.
Source/WebKit:
It's valid for the incoming voice to be nil, so we need to protect against that.
Tests: fast/speechsynthesis/speech-synthesis-real-client-version.html
- WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::speak):
LayoutTests:
- fast/speechsynthesis/speech-synthesis-real-client-version-expected.txt: Added.
- fast/speechsynthesis/speech-synthesis-real-client-version.html: Added.
- 9:56 AM Changeset in webkit [245177] by
-
- 3 edits in trunk/Source/WTF
[WTF] Remove "private:" from Noncopyable and Nonmovable macros
https://bugs.webkit.org/show_bug.cgi?id=197767
Reviewed by Saam Barati.
We no longer need "private:".
- wtf/Noncopyable.h:
- wtf/Nonmovable.h:
- 9:46 AM Changeset in webkit [245176] by
-
- 11 edits1 add in trunk
[WPE][GTK] Add webkit_frame_get_id() API
https://bugs.webkit.org/show_bug.cgi?id=197270
Reviewed by Carlos Garcia Campos.
Source/WebKit:
It's as simple as can be: just an API to return the ID of a frame.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:
(webkit_frame_get_id):
- WebProcess/InjectedBundle/API/gtk/WebKitFrame.h:
- WebProcess/InjectedBundle/API/wpe/WebKitFrame.h:
- WebProcess/InjectedBundle/API/wpe/docs/wpe-webextensions-1.0-sections.txt:
Tools:
This was hard, but I added a test to verify that two different WebKitFrames of the same
WebKitWebPage return two different frame IDs.
- TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
(WebKitFrameTest::willSubmitFormCallback):
(WebKitFrameTest::testSubframe):
(registerTests):
- TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
(testWebKitFrameSubframe):
(beforeAll):
- TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(willSubmitFormCallback):
- TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
- TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
- 9:20 AM Changeset in webkit [245175] by
-
- 4 edits2 adds in trunk
Event region generation needs to know about backing-sharing
https://bugs.webkit.org/show_bug.cgi?id=197694
<rdar://problem/50584991>
Reviewed by Simon Fraser.
Source/WebCore:
Test: pointerevents/ios/touch-action-region-backing-sharing.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
Gather event region from backing sharing layers too.
LayoutTests:
- platform/ios-wk2/TestExpectations:
- pointerevents/ios/touch-action-region-backing-sharing-expected.txt: Added.
- pointerevents/ios/touch-action-region-backing-sharing.html: Added.
- 9:05 AM Changeset in webkit [245174] by
-
- 15 edits in trunk
[WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
https://bugs.webkit.org/show_bug.cgi?id=197271
Reviewed by Youenn Fablet.
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::didAssociateFormControlsTimerFired):
- loader/EmptyClients.h:
- page/ChromeClient.h:
Source/WebKit:
- WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
- WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkit_web_page_class_init):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
- WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
(API::InjectedBundle::FormClient::didAssociateFormControls):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAssociateFormControls):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
- TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(formControlsAssociatedForFrameCallback):
(pageCreatedCallback):
(formControlsAssociatedCallback): Deleted.
- 9:03 AM Changeset in webkit [245173] by
-
- 2 edits in trunk/LayoutTests
[iOS Debug] Layout Test webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=197778
Unreviewed test gardening.
- platform/ios/TestExpectations: Mark test as slow.
- 7:42 AM Changeset in webkit [245172] by
-
- 2 edits in trunk/Tools
[Flatpak] Use the safe PyYAML loader if available
https://bugs.webkit.org/show_bug.cgi?id=197771
Reviewed by Philippe Normand.
- flatpak/flatpakutils.py:
(load_manifest): Use yaml.safe_load() if available, with yaml.load()
still used as fallback when the former is not provided by the module.
