Timeline
May 27, 2019:
- 11:36 PM Changeset in webkit [245807] by
-
- 49 edits in trunk
[GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
https://bugs.webkit.org/show_bug.cgi?id=197944
Reviewed by Michael Catanzaro.
.:
Add USE_WPE_RENDERER option to use WPEBackend-fdo.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsPlayStation.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/WebCore:
- PlatformGTK.cmake:
- SourcesGTK.txt:
- platform/graphics/GLContext.cpp:
(WebCore::GLContext::createContextForWindow): Check current display is X11 before trying to create a GLX context.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay): Use USE(WPE_RENDERER) instead of USE(LIBWPE).
- platform/graphics/PlatformDisplay.h:
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createWindowContext): Use USE(WPE_RENDERER) instead of PLATFORM(WPE).
(WebCore::GLContextEGL::createContext): Ditto.
(WebCore::GLContextEGL::createSharingContext): Ditto.
(WebCore::GLContextEGL::~GLContextEGL): Ditto.
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/egl/GLContextEGLLibWPE.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): Ditto.
- platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE): In GTK port set the display as the shared one for compositing.
- platform/graphics/libwpe/PlatformDisplayLibWPE.h:
Source/WebKit:
The WPEBackend-fdo implementation is quite similar to our Wayland nested compositor, but more efficient (using
linux dmabuf, resource caching, etc.). This allows us to share even more code with WPE port too.
- PlatformGTK.cmake:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::forceRepaint): WPE doesn't support force repaint yet.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const): Use USE(WPE_RENDERER) instead of PLATFORM(WPE).
(WebKit::WebPageCreationParameters::decode): Ditto.
- Shared/WebPageCreationParameters.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const): Ditto.
(WebKit::WebProcessCreationParameters::decode): Ditto.
- Shared/WebProcessCreationParameters.h:
- SourcesGTK.txt:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor): Implement it when using WPE just calling webkitWebViewBaseRenderHostFileDescriptor().
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage): Initialize the web page after the accelerated backing store is created, since
it's used now during intialization.
(webkitWebViewBaseRenderHostFileDescriptor): Return AcceleratedBackingStore::renderHostFileDescriptor()
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters): Use USE(WPE_RENDERER) instead of PLATFORM(WPE).
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess): Remove wayland display name initialization.
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Initialize wayland display name when not using WPE here
now. In case of using WPE, initialize hostClientFileDescriptor and implementationLibraryName.
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions): Remove unused wayland socket command line process parameter.
- UIProcess/gtk/AcceleratedBackingStore.h:
(WebKit::AcceleratedBackingStore::renderHostFileDescriptor): Return -1 by default.
- UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::create): When using WPE call wpe_fdo_initialize_for_egl_display() and
check we have the required extensions.
(WebKit::AcceleratedBackingStoreWayland::AcceleratedBackingStoreWayland): When using WPE initialize the view backend.
(WebKit::AcceleratedBackingStoreWayland::~AcceleratedBackingStoreWayland): When using WPE release the EGL images
still in use and the view texture.
(WebKit::AcceleratedBackingStoreWayland::renderHostFileDescriptor): Call wpe_view_backend_get_renderer_host_fd().
(WebKit::AcceleratedBackingStoreWayland::displayBuffer): Create the view texture if needed, save the pending
image and schedule a redraw.
(WebKit::AcceleratedBackingStoreWayland::paint): When using WPE commit the pending image and use it as target of
the view texture.
- UIProcess/gtk/AcceleratedBackingStoreWayland.h:
- UIProcess/gtk/HardwareAccelerationManager.cpp:
(WebKit::HardwareAccelerationManager::HardwareAccelerationManager): When using WPE disable hardware acceleration
if wpe_fdo_initialize_for_egl_display() fails.
- UIProcess/gtk/WaylandCompositor.cpp:
- UIProcess/gtk/WaylandCompositor.h:
- WebProcess/WebPage/AcceleratedSurface.cpp:
(WebKit::AcceleratedSurface::create): Create an AcceleratedSurfaceLibWPE for GTK port when using WPE and shared
display is Wayland.
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.cpp:
(WebKit::AcceleratedSurfaceLibWPE::initialize): Use the shared display for compositing instead of shared display.
- WebProcess/WebPage/libwpe/AcceleratedSurfaceLibWPE.h:
- WebProcess/WebProcess.h:
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize the wpe display when using WPE.
Tools:
Add WPEBackend-fdo to jhbuild moduleset.
- gtk/jhbuild.modules:
- 9:06 PM Changeset in webkit [245806] by
-
- 7 edits in branches/safari-608.1.24.20-branch
Revert r245775. rdar://problem/35205373
- 9:06 PM Changeset in webkit [245805] by
-
- 13 edits in branches/safari-608.1.24.20-branch
Revert r245637. rdar://problem/35205373
- 6:36 PM Changeset in webkit [245804] by
-
- 8 edits in branches/safari-608.1.24.20-branch
Cherry-pick r245803. rdar://problem/51145977
[iOS] Dropping in an editable element should result in a ranged selection
https://bugs.webkit.org/show_bug.cgi?id=198267
<rdar://problem/51145977>
Reviewed by Tim Horton.
Source/WebKit:
When drag and drop was first implemented for iOS in iOS 11, selection behavior when dropping into editable
elements matched that of macOS, by leaving the inserted content selected after performing the drop. However, in
other parts of the platform (e.g. Notes), both the keyboard and selection views are not shown after a drop.
Instead of matching macOS behavior, WebKit on iOS should match the rest of the platform. This is a little
tricky, since we use the selection range after a drop to create a TextIndicator snapshot when creating a drag
preview. To resolve this, we refactor some of the logic introduced in r245778 to remember the DOM range to
snapshot before collapsing the range to the end of the inserted content.
Tested by adjusting some existing API tests.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
Remove some logic that currently presents the keyboard while the user is performing a drop that focuses an
editable element.
- WebProcess/WebPage/WebPage.h:
Add a member variable to keep track of which range should be snapshotted when generating a drop preview.
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::didConcludeDrop): (WebKit::WebPage::didConcludeEditDrag):
Collapse the selection range to the end after an edit drag (i.e., a drop in an editable area that inserted
content).
(WebKit::WebPage::computeAndSendEditDragSnapshot):
Tools:
Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
visible selection rects, simply check for the start caret rect, as determined by WKContentView's
-selectionRange.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: (TestWebKitAPI::TEST): (makeCGRectValue): Deleted. (checkSelectionRectsWithLogging): Deleted.
- TestWebKitAPI/cocoa/DragAndDropSimulator.h:
Replace finalSelectionRects with finalSelectionStartRect.
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: (-[DragAndDropSimulator _resetSimulatedState]): (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]): (-[DragAndDropSimulator finalSelectionRects]): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:03 PM Changeset in webkit [245803] by
-
- 8 edits in trunk
[iOS] Dropping in an editable element should result in a ranged selection
https://bugs.webkit.org/show_bug.cgi?id=198267
<rdar://problem/51145977>
Reviewed by Tim Horton.
Source/WebKit:
When drag and drop was first implemented for iOS in iOS 11, selection behavior when dropping into editable
elements matched that of macOS, by leaving the inserted content selected after performing the drop. However, in
other parts of the platform (e.g. Notes), both the keyboard and selection views are not shown after a drop.
Instead of matching macOS behavior, WebKit on iOS should match the rest of the platform. This is a little
tricky, since we use the selection range after a drop to create a TextIndicator snapshot when creating a drag
preview. To resolve this, we refactor some of the logic introduced in r245778 to remember the DOM range to
snapshot before collapsing the range to the end of the inserted content.
Tested by adjusting some existing API tests.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
Remove some logic that currently presents the keyboard while the user is performing a drop that focuses an
editable element.
- WebProcess/WebPage/WebPage.h:
Add a member variable to keep track of which range should be snapshotted when generating a drop preview.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didConcludeDrop):
(WebKit::WebPage::didConcludeEditDrag):
Collapse the selection range to the end after an edit drag (i.e., a drop in an editable area that inserted
content).
(WebKit::WebPage::computeAndSendEditDragSnapshot):
Tools:
Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
visible selection rects, simply check for the start caret rect, as determined by WKContentView's
-selectionRange.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::TEST):
(makeCGRectValue): Deleted.
(checkSelectionRectsWithLogging): Deleted.
- TestWebKitAPI/cocoa/DragAndDropSimulator.h:
Replace finalSelectionRects with finalSelectionStartRect.
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator finalSelectionRects]): Deleted.
- 5:10 PM Changeset in webkit [245802] by
-
- 6 edits in trunk
[CURL] Fix crashing SocketStreamHandle.
https://bugs.webkit.org/show_bug.cgi?id=197873
Patch by Takashi Komori <Takashi.Komori@sony.com> on 2019-05-27
Reviewed by Fujii Hironori.
Source/WebCore:
When NetworkSocketStream was destructed SocketStreamHandleImple::platformClose was called wrongly times.
This is because closed state is not set.
Test: http/tests/websocket/tests/hybi/workers/close.html
- platform/network/curl/SocketStreamHandleImpl.h:
- platform/network/curl/SocketStreamHandleImplCurl.cpp:
(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::threadEntryPoint):
(WebCore::SocketStreamHandleImpl::handleError):
(WebCore::SocketStreamHandleImpl::callOnWorkerThread):
(WebCore::SocketStreamHandleImpl::executeTasks):
LayoutTests:
- platform/wincairo-wk1/TestExpectations:
- platform/wincairo/TestExpectations:
- 3:00 PM Changeset in webkit [245801] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed Win Cairo build fix after r245796.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::getAllStorageAccessEntries):
- 2:51 PM Changeset in webkit [245800] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix opensource build of testapi
https://bugs.webkit.org/show_bug.cgi?id=198256
Reviewed by Alexey Proskuryakov.
In r245564, we added custom entitlements to testapi to allow caching
bytecode in data vaults, but we should only use the entitlements for
internal builds. Otherwises, testapi gets killed on launch. Also fix the
formatting for the errors added in the same patch, according to comments
in the bug after the patch had already landed.
- API/JSScript.mm:
(validateBytecodeCachePath):
- Configurations/ToolExecutable.xcconfig:
- 2:50 PM Changeset in webkit [245799] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed Win Cairo build fix after r245796.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
- 2:27 PM Changeset in webkit [245798] by
-
- 19 edits4 adds in trunk
[css-grid] Preserve repeat() notation when serializing declared values
https://bugs.webkit.org/show_bug.cgi?id=197840
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Import WPT test.
- web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-002-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-002.html: Added.
- web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
Source/WebCore:
Tests: fast/css-grid-layout/grid-element-auto-repeat-get-set.html
fast/css-grid-layout/grid-repeat-calc.html
fast/css-grid-layout/named-grid-line-get-set.html
imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-support-repeat-002.html
Before this change, a repeat() notation with an integral number of
repetitions was expanded at parse time. This was observable when reading
declared values using JS APIs.
This patch makes the parser preserve that notation, like it was already
happening when the number of repetitions was automatic and not integral.
The resolved value in getComputedStyle() will still be expanded, though,
as required by the spec.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGridIntegerRepeatValue.cpp: Added.
(WebCore::CSSGridIntegerRepeatValue::customCSSText const):
(WebCore::CSSGridIntegerRepeatValue::equals const):
- css/CSSGridIntegerRepeatValue.h: Added.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isGridIntegerRepeatValue const):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::createGridTrackList):
(WebCore::StyleBuilderConverter::convertGridTrackSizeList):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeGridTrackRepeatFunction):
Tools:
Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
- TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
(TestWebKitAPI::computeNumberOfTracks):
LayoutTests:
Update test expectations.
- fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
- fast/css-grid-layout/grid-element-auto-repeat-get-set.html:
- fast/css-grid-layout/grid-repeat-calc-expected.txt:
- fast/css-grid-layout/grid-repeat-calc.html:
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- 2:21 PM Changeset in webkit [245797] by
-
- 7 edits in branches/safari-608.1.24.20-branch/Source
Versioning.
- 1:30 PM Changeset in webkit [245796] by
-
- 185 edits1 copy in trunk/Source
Use a strongly-typed identifier for pages
https://bugs.webkit.org/show_bug.cgi?id=198206
Reviewed by Youenn Fablet.
Source/WebCore:
- WebCore/*:
Source/WebKit:
- WebKit/*:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::pageLoadCompleted):
- WebCoreSupport/WebResourceLoadScheduler.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::pageID const):
Source/WTF:
- wtf/ObjectIdentifier.h:
(WTF::operator<<):
- 9:19 AM Changeset in webkit [245795] by
-
- 2 edits in trunk/Source/WebKit
[Pointer Events] Test at pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html times out
https://bugs.webkit.org/show_bug.cgi?id=198275
<rdar://problem/50618496>
Patch by Antoine Quint <Antoine Quint> on 2019-05-27
Reviewed by Antti Koivisto.
Only WKCompositingView instances may have associated touch-action data, so we should filter out any hit-testing view
that isn't a WKCompositingView when finding the view that should hit-test when looking for touch-action information.
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(WebKit::touchActionsForPoint):
- 9:06 AM Changeset in webkit [245794] by
-
- 6 edits in trunk/Source/WebCore
Move GraphicsLayerCA::adjustTiledLayerVisibleRect() to TileController
https://bugs.webkit.org/show_bug.cgi?id=198266
Reviewed by Zalan Bujtas.
GraphicsLayerCA::adjustTiledLayerVisibleRect() was computing tile coverage for a
TiledBacking, just like TileController::adjustTileCoverageRect(), so move the code
into TileController as a first step to unifying more of this code. It's currently
used for tiled compositing layers, including overflow:scroll, and tiled layers
whose coverage may be affected by animations, so it's general-purpose.
TileController::adjustTileCoverageRect() is used for scrollable things, so rename
it to adjustTileCoverageRectForScrolling().
No behavior change.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::adjustCoverageRect const):
(WebCore::GraphicsLayerCA::adjustTiledLayerVisibleRect): Deleted.
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::adjustTileCoverageRect const):
(WebCore::TileController::adjustTileCoverageRectForScrolling const):
- platform/graphics/ca/TileController.h:
- 9:00 AM Changeset in webkit [245793] by
-
- 2 edits in trunk/Source/WebCore
Fix Apple Internal builds after r245788.
- platform/PlatformScreen.h:
(WebCore::screenHasTouchDevice):
(WebCore::screenIsTouchPrimaryInputDevice):
- 7:15 AM Changeset in webkit [245792] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Ignore collapsed runs when setting the width on the associated display boxes.
https://bugs.webkit.org/show_bug.cgi?id=198260
<rdar://problem/51145704>
Reviewed by Antti Koivisto.
Collapsed runs don't contribute to the logical width of their containers.
Covered by existing tests.
- layout/inlineformatting/InlineFormattingContextLineLayout.cpp:
(WebCore::Layout::InlineFormattingContext::LineLayout::closeLine const):
- 2:55 AM Changeset in webkit [245791] by
-
- 1 copy in releases/WebKitGTK/webkit-2.25.1
WebKitGTK 2.25.1
- 2:54 AM Changeset in webkit [245790] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.25.1 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers
Source/WebKit:
- gtk/NEWS: Add release notes for 2.25.1.
- 2:52 AM Changeset in webkit [245789] by
-
- 5 edits in trunk/Source
Unreviewed. Fix GTK distcheck
Source/WebCore:
Move mac headers to platform specific makefile.
- Headers.cmake:
- PlatformMac.cmake:
Source/WebKit:
Remove symbols that are not longer present in the library.
- webkitglib-symbols.map:
- 1:34 AM Changeset in webkit [245788] by
-
- 11 edits in trunk
Touch support is reported even when the device doesn't have a touch screen
https://bugs.webkit.org/show_bug.cgi?id=139681
Reviewed by Michael Catanzaro.
Source/WebCore:
Add screenHasTouchDevice() and screenIsTouchPrimaryInputDevice() to PlatformScreen and use it to decide whether
to expose touch events functionality or not.
- bindings/js/WebCoreBuiltinNames.h:
- css/MediaQueryEvaluator.cpp:
(WebCore::hoverEvaluate): Use screenIsTouchPrimaryInputDevice() when touch events are enabled at build time.
(WebCore::anyHoverEvaluate): Use screenHasTouchDevice() when touch events are enabled at build time.
(WebCore::pointerEvaluate): Use screenIsTouchPrimaryInputDevice() when touch events are enabled at build time.
(WebCore::anyPointerEvaluate): Use screenHasTouchDevice() when touch events are enabled at build time.
- dom/GlobalEventHandlers.idl: Make touch event attributes enabled at runtime.
- page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::touchEventsEnabled const): Return whether touch events are enabled.
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setTouchEventsEnabled): Force touch events to be enabled or disabled.
- platform/PlatformScreen.h:
(WebCore::screenHasTouchDevice): Just return true when touch events are enabled at build time for non-gtk ports.
(WebCore::screenIsTouchPrimaryInputDevice): Ditto.
- platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenHasTouchDevice):
(WebCore::screenIsTouchPrimaryInputDevice):
(WebCore::isTouchDevice):
(WebCore::deviceAddedCallback):
(WebCore::deviceRemovedCallback):
LayoutTests:
Remove expectations for tests that are passing now.
- platform/gtk/TestExpectations:
May 26, 2019:
- 6:12 PM Changeset in webkit [245787] by
-
- 16 edits2 adds in trunk/Source
Move VelocityData to WebCore
https://bugs.webkit.org/show_bug.cgi?id=198261
Reviewed by Antti Koivisto.
Move VelocityData and HistoricalVelocityData to WebCore for future use in overflow scroll.
Source/WebCore:
VisibleContentRectUpdateInfo can now store a VelocityData (its timestamp is used as
the timetamp for the entire update).
No behavior change.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- page/FrameView.cpp:
(WebCore::FrameView::setScrollVelocity):
- page/FrameView.h:
- platform/graphics/TiledBacking.h:
(WebCore::VelocityData::VelocityData): Deleted.
(WebCore::VelocityData::velocityOrScaleIsChanging const): Deleted.
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::adjustTileCoverageRect const):
- platform/graphics/ca/TileController.h:
Source/WebKit:
VisibleContentRectUpdateInfo can now store a VelocityData (its timestamp is used as
the timetamp for the entire update).
- Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode const):
(WebKit::VisibleContentRectUpdateInfo::decode):
(WebKit::operator<<):
- Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::scrollVelocity const):
(WebKit::VisibleContentRectUpdateInfo::enclosedInScrollableAncestorView const):
(WebKit::VisibleContentRectUpdateInfo::timestamp const):
(WebKit::operator==):
(WebKit::VisibleContentRectUpdateInfo::horizontalVelocity const): Deleted.
(WebKit::VisibleContentRectUpdateInfo::verticalVelocity const): Deleted.
(WebKit::VisibleContentRectUpdateInfo::scaleChangeRate const): Deleted.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<VelocityData>::encode):
(IPC::ArgumentCoder<VelocityData>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(WebKit::HistoricalVelocityData::VelocityData::VelocityData): Deleted.
(WebKit::HistoricalVelocityData::HistoricalVelocityData): Deleted.
(WebKit::HistoricalVelocityData::velocityForNewData): Deleted.
(WebKit::HistoricalVelocityData::clear): Deleted.
(WebKit::HistoricalVelocityData::append): Deleted.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::adjustVelocityDataForBoundedScale):
(WebKit::WebPage::updateVisibleContentRects):
- 5:10 PM Changeset in webkit [245786] by
-
- 6 edits in trunk/Source/WebCore
Add a GraphicsLayer::Type for ScrolledContents
https://bugs.webkit.org/show_bug.cgi?id=198257
Reviewed by Zalan Bujtas.
This ScrolledContents layer type will be used to choose different tiling behaviors
in a future patch.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::supportsLayerType):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::supportsLayerType):
(WebCore::GraphicsLayerCA::initialize):
(WebCore::GraphicsLayerCA::adjustCoverageRect const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateScrollingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
- 4:16 PM Changeset in webkit [245785] by
-
- 1 copy in tags/Safari-608.1.24.20.5
Tag Safari-608.1.24.20.5.
- 3:39 PM Changeset in webkit [245784] by
-
- 22 edits3 adds in trunk
Resource Load Statistics: Downgrade document.referrer to the referrer's eTLD+1 if the page was navigated to with a prevalent resource referrer containing link decoration
https://bugs.webkit.org/show_bug.cgi?id=198227
<rdar://problem/51117258>
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource.html
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::referrer const):
Now checks if the referrer has been overridden.
(WebCore::Document::wasLoadedWithDataTransferFromPrevalentResource):
(WebCore::Document::downgradeReferrerToRegistrableDomain):
- dom/Document.h:
- page/CrossSiteNavigationDataTransfer.h: Added.
New option set for the growing number of navigational data transfers we care about.
- platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::didCommitCrossSiteLoadWithDataTransferFromPrevalentResource):
(WebCore::NetworkStorageSession::committedCrossSiteLoadWithLinkDecoration): Deleted.
New name since we no longer only look for link decoration but also other means of navigational data transfer.
- platform/network/NetworkStorageSession.h:
Source/WebKit:
This patch adds a call back to the UI process if the network process finds the navigational
data transfer was done by a prevalent resource and we need to adjust something for the page.
Currently, that adjustment is to downgrade document.referrer.
The patch also removes an unused completion handler.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::NetworkProcess::committedCrossSiteLoadWithLinkDecoration): Deleted.
New name since we no longer only look for link decoration but also other means of navigational data transfer.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::NetworkProcessProxy::didCommitCrossSiteLoadWithDataTransferFromPrevalentResource):
(WebKit::NetworkProcessProxy::committedCrossSiteLoadWithLinkDecoration): Deleted.
New name since we no longer only look for link decoration but also other means of navigational data transfer.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::checkIfNavigationContainsDataTransfer):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didCommitCrossSiteLoadWithDataTransferFromPrevalentResource):
(WebKit::isNonUniqueNavigationWithLinkDecoration): Deleted.
New name since we no longer only look for link decoration but also other means of navigational data transfer.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::WebProcessPool::committedCrossSiteLoadWithLinkDecoration): Deleted.
New name since we no longer only look for link decoration but also other means of navigational data transfer.
- UIProcess/WebProcessPool.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::wasLoadedWithDataTransferFromPrevalentResource):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
LayoutTests:
- http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource-expected.txt: Added.
- http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource.html: Added.
- 12:56 PM Changeset in webkit [245783] by
-
- 1 edit in branches/safari-608.1.24.20-branch/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
Build fix after cherry-picking r245778.
- 12:05 PM Changeset in webkit [245782] by
-
- 13 edits in branches/safari-608.1.24.20-branch
Cherry-pick r245637. rdar://problem/35205373
[Paste] Add support for preferred presentation size when pasting an image
https://bugs.webkit.org/show_bug.cgi?id=198132
<rdar://problem/50886917>
Reviewed by Wenson Hsieh.
Source/WebCore:
Set the pasted <img> width/height attributes when the preferred presentation size is available.
- editing/WebContentReader.h:
- editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentForImageAttachment): (WebCore::WebContentReader::readImage):
- editing/markup.cpp: (WebCore::createFragmentForImageAndURL):
- editing/markup.h:
- platform/Pasteboard.h: (WebCore::PasteboardWebContentReader::readImage):
- platform/PasteboardItemInfo.h: (WebCore::PasteboardItemInfo::encode const): (WebCore::PasteboardItemInfo::decode):
- platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::readPasteboardWebContentDataForType): (WebCore::Pasteboard::read): (WebCore::Pasteboard::readRespectingUTIFidelities):
- platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex):
Source/WebKit:
- UIProcess/API/Cocoa/_WKElementAction.mm: (addToReadingList):
- UIProcess/ios/WKActionSheetAssistant.mm: (-[WKActionSheetAssistant defaultActionsForLinkSheet:]): (-[WKActionSheetAssistant defaultActionsForImageSheet:]):
Tools:
- TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:21 AM Changeset in webkit [245781] by
-
- 36 edits in branches/safari-608.1.24.20-branch
Cherry-pick r245778. rdar://problem/35205373
[iOS] Dropped text, attachments, and images should animate into place
https://bugs.webkit.org/show_bug.cgi?id=198243
<rdar://problem/35205373>
Reviewed by Tim Horton.
Source/WebCore:
Add some hooks to notify the chrome client when an HTMLImageElement's image is finished loading. See WebKit
changelog for more detail.
Test: DragAndDropTests.DropPreviewForImageInEditableArea
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/Page.cpp: (WebCore::Page::didFinishLoadingImageForElement):
- page/Page.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::notifyFinished):
Source/WebKit:
Adds support for targeted drop animations on iOS in modern WebKit by adopting UIKit SPI introduced in
<rdar://problem/31075005> to allow updating the drop preview mid-flight. To get the animation right, we refactor
and augment existing logic for taking snapshots after performing a drop in an editable content.
Currently, upon dropping in editable content, we first snapshot the web view and temporarily cover the real web
view with this snapshot. When the TextIndicator data arrives that contains (1) a snapshot of the visible part of
the web view ignoring the selection, and (2) a snapshot of just the selected contents after drop, we crossfade
from the web view snapshot to the snapshot in (1) using a hard-coded time delay (~500ms), and target the drop
preview to the drag caret rect. During this process, snapshot (2) is completely ignored.
This was effectively a halfway implemention of the desired effect of animating the dropped content into place
and crossfading to the final content; before UIKit implemented updateable drag previews, the full implementation
was not possible in modern WebKit (without using synchronous IPC).
Now that we're able to update the drag preview in the middle of the drop animation, we can now utilize snapshot
(2) above and clean up some parts of the drop animation in editable content. See below for more details.
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _doAfterReceivingEditDragSnapshotForTesting:]):
Add a testing hook to perform the given block after any pending edit drag snapshot has been received. See
TestWebKitAPI changes for more detail.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Split up the existing DidConcludeEditDrag IPC message into two messages: WillReceiveEditDragSnapshot and
DidReceiveEditDragSnapshot. This allows us to defer cleaning up the drag session state during an edit drop,
until after the final edit drag snapshot has been received.
- UIProcess/ios/DragDropInteractionState.h:
Add some new methods to help manage the lifecycle of drop preview provider blocks.
- UIProcess/ios/DragDropInteractionState.mm: (WebKit::createTargetedDragPreview):
Drive-by fix: make this return a RetainPtr.
(WebKit::DragDropInteractionState::prepareForDelayedDropPreview):
Stores a drop preview provider, given to us by UIKit.
(WebKit::DragDropInteractionState::deliverDelayedDropPreview):
Invokes the stored drop preview providers with given text indicator data. This is invoked after snapshots are
taken following an edit drag (this is additionally after all images in the inserted fragment have finished
loading).
(WebKit::DragDropInteractionState::clearAllDelayedItemPreviewProviders):
Invokes all stored drop preview providers with a nil preview. This is invoked in any case where drag session
cleanup occurs earlier than normal (e.g., if the web process crashes during drop), and ensures that the handlers
are always invoked when cleaning up the drag session.
(WebKit::DragDropInteractionState::previewForDragItem const):
(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):
Call clearAllDelayedItemPreviewProviders.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::willReceiveEditDragSnapshot): (WebKit::PageClientImpl::didReceiveEditDragSnapshot): (WebKit::PageClientImpl::didConcludeEditDrag): Deleted.
More plumbing (see changes to DidConcludeEditDrag above).
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView cleanupInteraction]): (-[WKContentView cleanUpDragSourceSessionState]): (-[WKContentView _willReceiveEditDragSnapshot]): (-[WKContentView _didReceiveEditDragSnapshot:]):
Set _waitingForEditDragSnapshot to YES in the gap between when -_willReceiveEditDragSnapshot is invoked, and
when -_didReceiveEditDragSnapshot is invoked. If _waitingForEditDragSnapshot is YES, we bail out of
-cleanUpDragSourceSessionState, and instead clean up drag session state after the edit drag snapshot is
received.
(-[WKContentView _deliverDelayedDropPreviewIfPossible:]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView textEffectsWindow]):
Drive-by fix to remove a workaround for a deprecation warning.
(-[WKContentView dropInteraction:item:willAnimateDropWithAnimator:]):
(-[WKContentView dropInteraction:concludeDrop:]):
Implement this hook to ensure that the unselected content snapshot view and visible content snapshot view are
guaranteed to be removed from the view after a drop in editable content, even if the drag edit snapshot arrives
after the drop is concluded.
(-[WKContentView dropInteraction:previewForDroppingItem:withDefault:]):
(-[WKContentView _dropInteraction:delayedPreviewProviderForDroppingItem:previewProvider:]):
Implement the new UIKit SPI here. UIKit hands us a preview provider here, which we can invoke at a later time
to update the drop preview. We do this in _didReceiveEditDragSnapshot.
(-[WKContentView _doAfterReceivingEditDragSnapshotForTesting:]):
(-[WKContentView _didConcludeEditDrag:]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::willReceiveEditDragSnapshot): (WebKit::WebPageProxy::didReceiveEditDragSnapshot): (WebKit::WebPageProxy::didConcludeDrop): (WebKit::WebPageProxy::didConcludeEditDrag): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didFinishLoadingImageForElement):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didFinishLoadingImageForElement):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::didConcludeDrop):
If an edit drag has been concluded, there's no need to hang on to pending dropped image elements anymore; clear
out the set here.
(WebKit::WebPage::didConcludeEditDrag):
After concluding an edit drag, we try to deliver two web content snapshots to the UI process, so that the UI
process can assemble a targeted drop preview for UIKit. One snapshot is of the visible content area, not
including any selected content. The other snapshot is of the selected content only. However, when dropping
images (or a text selection containing images), these images may not yet have been loaded. If that is the case,
these images will appear to be missing from these snapshots.
To ensure that we don't take this snapshot too early, defer it until all image elements in the dropped content
range have finished loading. We can tell that all dropped images have finished loading by using a new client
hook that is invoked when an image has finished loading.
(WebKit::WebPage::didFinishLoadingImageForElement):
(WebKit::WebPage::computeAndSendEditDragSnapshot):
Snapshot the selected content and send it to the UI process.
Source/WebKitLegacy/mac:
Add a new chrome client method. See other changelogs for more detail.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::didFinishLoadingImageForElement):
Source/WebKitLegacy/win:
- WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::didFinishLoadingImageForElement):
- WebCoreSupport/WebChromeClient.h:
Tools:
Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: (TestWebKitAPI::isCompletelyWhite): (TestWebKitAPI::TEST):
Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
UITargetedDragPreviews upon drop.
- TestWebKitAPI/cocoa/DragAndDropSimulator.h:
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: (-[DragAndDropSimulator _resetSimulatedState]): (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]): (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
the end of the simulated drag and drop until after drag previews have been received during an edit drag.
(-[DragAndDropSimulator dropPreviews]):
(-[DragAndDropSimulator delayedDropPreviews]):
Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
previews were provided asynchronously.
(-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
- TestWebKitAPI/ios/UIKitSPI.h:
Stage the new private drop interacton delegate method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:21 AM Changeset in webkit [245780] by
-
- 7 edits in branches/safari-608.1.24.20-branch
Cherry-pick r245775. rdar://problem/35205373
[iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
https://bugs.webkit.org/show_bug.cgi?id=198242
Reviewed by Beth Dakin.
Source/WebCore:
Teach the web content reader to respect the -preferredPresentationSize when creating attachment-backed image
elements. See below for more details.
Test: WKAttachmentTestsIOS.InsertDroppedImageWithPreferredPresentationSize
- editing/WebContentReader.h:
- editing/cocoa/WebContentReaderCocoa.mm: (WebCore::attachmentForFilePath): (WebCore::attachmentForData):
When creating attachment-backed image elements, additionally set width and height attributes from the preferred
presentation size, if specified.
(WebCore::WebContentReader::readFilePath):
Add a version of readFilePath that takes a single file path, and an optional preferred presentation size.
(WebCore::WebContentReader::readFilePaths):
Reimplement readFilePaths in terms of readFilePath.
(WebCore::WebContentReader::readDataBuffer):
Add more plumbing for preferredPresentationSize.
- platform/Pasteboard.h: (WebCore::PasteboardWebContentReader::readFilePath): (WebCore::PasteboardWebContentReader::readDataBuffer):
- platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::read): (WebCore::Pasteboard::readRespectingUTIFidelities):
Forward PasteboardItemInfo's preferredPresentationSize to the web content reader.
Tools:
Add a new test that simulates dropping an image with a preferred presentation size into an editable element
with attachment elements enabled.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:04 AM Changeset in webkit [245779] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Verification] Add areEssentiallyEqual for LayoutRect
https://bugs.webkit.org/show_bug.cgi?id=198250
<rdar://problem/51140119>
Reviewed by Antti Koivisto.
WebKit's inline layout is a mix of int/float/LayoutUnit types, while LFC mostly uses LayoutUnit.
When we compute the used size of a block container (based on the inline tree), the final value might go through a few conversions.
- layout/Verification.cpp:
(WebCore::Layout::areEssentiallyEqual):
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
- 4:31 AM Changeset in webkit [245778] by
-
- 36 edits in trunk
[iOS] Dropped text, attachments, and images should animate into place
https://bugs.webkit.org/show_bug.cgi?id=198243
<rdar://problem/35205373>
Reviewed by Tim Horton.
Source/WebCore:
Add some hooks to notify the chrome client when an HTMLImageElement's image is finished loading. See WebKit
changelog for more detail.
Test: DragAndDropTests.DropPreviewForImageInEditableArea
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/Page.cpp:
(WebCore::Page::didFinishLoadingImageForElement):
- page/Page.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::notifyFinished):
Source/WebKit:
Adds support for targeted drop animations on iOS in modern WebKit by adopting UIKit SPI introduced in
<rdar://problem/31075005> to allow updating the drop preview mid-flight. To get the animation right, we refactor
and augment existing logic for taking snapshots after performing a drop in an editable content.
Currently, upon dropping in editable content, we first snapshot the web view and temporarily cover the real web
view with this snapshot. When the TextIndicator data arrives that contains (1) a snapshot of the visible part of
the web view ignoring the selection, and (2) a snapshot of just the selected contents after drop, we crossfade
from the web view snapshot to the snapshot in (1) using a hard-coded time delay (~500ms), and target the drop
preview to the drag caret rect. During this process, snapshot (2) is completely ignored.
This was effectively a halfway implemention of the desired effect of animating the dropped content into place
and crossfading to the final content; before UIKit implemented updateable drag previews, the full implementation
was not possible in modern WebKit (without using synchronous IPC).
Now that we're able to update the drag preview in the middle of the drop animation, we can now utilize snapshot
(2) above and clean up some parts of the drop animation in editable content. See below for more details.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _doAfterReceivingEditDragSnapshotForTesting:]):
Add a testing hook to perform the given block after any pending edit drag snapshot has been received. See
TestWebKitAPI changes for more detail.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Split up the existing DidConcludeEditDrag IPC message into two messages: WillReceiveEditDragSnapshot and
DidReceiveEditDragSnapshot. This allows us to defer cleaning up the drag session state during an edit drop,
until after the final edit drag snapshot has been received.
- UIProcess/ios/DragDropInteractionState.h:
Add some new methods to help manage the lifecycle of drop preview provider blocks.
- UIProcess/ios/DragDropInteractionState.mm:
(WebKit::createTargetedDragPreview):
Drive-by fix: make this return a RetainPtr.
(WebKit::DragDropInteractionState::prepareForDelayedDropPreview):
Stores a drop preview provider, given to us by UIKit.
(WebKit::DragDropInteractionState::deliverDelayedDropPreview):
Invokes the stored drop preview providers with given text indicator data. This is invoked after snapshots are
taken following an edit drag (this is additionally after all images in the inserted fragment have finished
loading).
(WebKit::DragDropInteractionState::clearAllDelayedItemPreviewProviders):
Invokes all stored drop preview providers with a nil preview. This is invoked in any case where drag session
cleanup occurs earlier than normal (e.g., if the web process crashes during drop), and ensures that the handlers
are always invoked when cleaning up the drag session.
(WebKit::DragDropInteractionState::previewForDragItem const):
(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):
Call clearAllDelayedItemPreviewProviders.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::willReceiveEditDragSnapshot):
(WebKit::PageClientImpl::didReceiveEditDragSnapshot):
(WebKit::PageClientImpl::didConcludeEditDrag): Deleted.
More plumbing (see changes to DidConcludeEditDrag above).
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _willReceiveEditDragSnapshot]):
(-[WKContentView _didReceiveEditDragSnapshot:]):
Set _waitingForEditDragSnapshot to YES in the gap between when -_willReceiveEditDragSnapshot is invoked, and
when -_didReceiveEditDragSnapshot is invoked. If _waitingForEditDragSnapshot is YES, we bail out of
-cleanUpDragSourceSessionState, and instead clean up drag session state after the edit drag snapshot is
received.
(-[WKContentView _deliverDelayedDropPreviewIfPossible:]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView textEffectsWindow]):
Drive-by fix to remove a workaround for a deprecation warning.
(-[WKContentView dropInteraction:item:willAnimateDropWithAnimator:]):
(-[WKContentView dropInteraction:concludeDrop:]):
Implement this hook to ensure that the unselected content snapshot view and visible content snapshot view are
guaranteed to be removed from the view after a drop in editable content, even if the drag edit snapshot arrives
after the drop is concluded.
(-[WKContentView dropInteraction:previewForDroppingItem:withDefault:]):
(-[WKContentView _dropInteraction:delayedPreviewProviderForDroppingItem:previewProvider:]):
Implement the new UIKit SPI here. UIKit hands us a preview provider here, which we can invoke at a later time
to update the drop preview. We do this in _didReceiveEditDragSnapshot.
(-[WKContentView _doAfterReceivingEditDragSnapshotForTesting:]):
(-[WKContentView _didConcludeEditDrag:]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::willReceiveEditDragSnapshot):
(WebKit::WebPageProxy::didReceiveEditDragSnapshot):
(WebKit::WebPageProxy::didConcludeDrop):
(WebKit::WebPageProxy::didConcludeEditDrag): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didFinishLoadingImageForElement):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoadingImageForElement):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didConcludeDrop):
If an edit drag has been concluded, there's no need to hang on to pending dropped image elements anymore; clear
out the set here.
(WebKit::WebPage::didConcludeEditDrag):
After concluding an edit drag, we try to deliver two web content snapshots to the UI process, so that the UI
process can assemble a targeted drop preview for UIKit. One snapshot is of the visible content area, not
including any selected content. The other snapshot is of the selected content only. However, when dropping
images (or a text selection containing images), these images may not yet have been loaded. If that is the case,
these images will appear to be missing from these snapshots.
To ensure that we don't take this snapshot too early, defer it until all image elements in the dropped content
range have finished loading. We can tell that all dropped images have finished loading by using a new client
hook that is invoked when an image has finished loading.
(WebKit::WebPage::didFinishLoadingImageForElement):
(WebKit::WebPage::computeAndSendEditDragSnapshot):
Snapshot the selected content and send it to the UI process.
Source/WebKitLegacy/mac:
Add a new chrome client method. See other changelogs for more detail.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::didFinishLoadingImageForElement):
Source/WebKitLegacy/win:
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::didFinishLoadingImageForElement):
- WebCoreSupport/WebChromeClient.h:
Tools:
Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
- TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::isCompletelyWhite):
(TestWebKitAPI::TEST):
Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
UITargetedDragPreviews upon drop.
- TestWebKitAPI/cocoa/DragAndDropSimulator.h:
- TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
(-[DragAndDropSimulator _resetSimulatedState]):
(-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
the end of the simulated drag and drop until after drag previews have been received during an edit drag.
(-[DragAndDropSimulator dropPreviews]):
(-[DragAndDropSimulator delayedDropPreviews]):
Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
previews were provided asynchronously.
(-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
- TestWebKitAPI/ios/UIKitSPI.h:
Stage the new private drop interacton delegate method.
May 25, 2019:
- 4:14 PM Changeset in webkit [245777] by
-
- 3 edits in trunk/Tools
MobileMiniBrowser: Add iPad support, and allow insecure loads
https://bugs.webkit.org/show_bug.cgi?id=198249
Reviewed by Tim Horton.
Add iPad support to MobileMiniBrowser, and allow insecure loads.
- MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
- MobileMiniBrowser/MobileMiniBrowser/Info.plist:
- 1:14 PM Changeset in webkit [245776] by
-
- 26 edits2 copies1 move2 adds2 deletes in trunk/Source/WebCore
[LFC][IFC] Introduce DisplayRun to display tree
https://bugs.webkit.org/show_bug.cgi?id=197198
Reviewed by Antti Koivisto.
Add a simple inline layout implementation. Now we've got DisplayBoxes for layout boxes and
DisplayRuns for inline runs.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::contentHeightForFormattingContextRoot):
- layout/Verification.cpp:
(WebCore::Layout::areEssentiallyEqual):
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
(WebCore::Layout::resolveForRelativePositionIfNeeded): Deleted.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::marginBox const):
(WebCore::Display::Box::nonCollapsedMarginBox const):
(WebCore::Display::Box::borderBox const):
(WebCore::Display::Box::paddingBox const):
(WebCore::Display::Box::contentBox const):
(WebCore::Display::Box::Rect::Rect): Deleted.
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::rectWithMargin const):
(WebCore::Display::Box::horizontalMargin const):
(WebCore::Display::Box::Rect::intersects const): Deleted.
(WebCore::Display::Box::Rect::invalidateTop): Deleted.
(WebCore::Display::Box::Rect::invalidateLeft): Deleted.
(WebCore::Display::Box::Rect::invalidateWidth): Deleted.
(WebCore::Display::Box::Rect::invalidateHeight): Deleted.
(WebCore::Display::Box::Rect::hasValidPosition const): Deleted.
(WebCore::Display::Box::Rect::hasValidSize const): Deleted.
(WebCore::Display::Box::Rect::hasValidGeometry const): Deleted.
(WebCore::Display::Box::Rect::invalidatePosition): Deleted.
(WebCore::Display::Box::Rect::setHasValidPosition): Deleted.
(WebCore::Display::Box::Rect::setHasValidSize): Deleted.
(WebCore::Display::Box::Rect::top const): Deleted.
(WebCore::Display::Box::Rect::left const): Deleted.
(WebCore::Display::Box::Rect::bottom const): Deleted.
(WebCore::Display::Box::Rect::right const): Deleted.
(WebCore::Display::Box::Rect::topLeft const): Deleted.
(WebCore::Display::Box::Rect::bottomRight const): Deleted.
(WebCore::Display::Box::Rect::size const): Deleted.
(WebCore::Display::Box::Rect::width const): Deleted.
(WebCore::Display::Box::Rect::height const): Deleted.
(WebCore::Display::Box::Rect::setTopLeft): Deleted.
(WebCore::Display::Box::Rect::setTop): Deleted.
(WebCore::Display::Box::Rect::setLeft): Deleted.
(WebCore::Display::Box::Rect::setWidth): Deleted.
(WebCore::Display::Box::Rect::setHeight): Deleted.
(WebCore::Display::Box::Rect::setSize): Deleted.
(WebCore::Display::Box::Rect::shiftLeftTo): Deleted.
(WebCore::Display::Box::Rect::shiftRightTo): Deleted.
(WebCore::Display::Box::Rect::shiftTopTo): Deleted.
(WebCore::Display::Box::Rect::shiftBottomTo): Deleted.
(WebCore::Display::Box::Rect::moveHorizontally): Deleted.
(WebCore::Display::Box::Rect::moveVertically): Deleted.
(WebCore::Display::Box::Rect::expand): Deleted.
(WebCore::Display::Box::Rect::clone const): Deleted.
(WebCore::Display::Box::Rect::operator LayoutRect const): Deleted.
- layout/displaytree/DisplayRect.h: Added.
(WebCore::Display::Rect::expandHorizontally):
(WebCore::Display::Rect::expandVertically):
(WebCore::Display::Rect::intersects const):
(WebCore::Display::Rect::invalidateTop):
(WebCore::Display::Rect::invalidateLeft):
(WebCore::Display::Rect::invalidateWidth):
(WebCore::Display::Rect::invalidateHeight):
(WebCore::Display::Rect::hasValidPosition const):
(WebCore::Display::Rect::hasValidSize const):
(WebCore::Display::Rect::hasValidGeometry const):
(WebCore::Display::Rect::Rect):
(WebCore::Display::Rect::invalidatePosition):
(WebCore::Display::Rect::setHasValidPosition):
(WebCore::Display::Rect::setHasValidSize):
(WebCore::Display::Rect::top const):
(WebCore::Display::Rect::left const):
(WebCore::Display::Rect::bottom const):
(WebCore::Display::Rect::right const):
(WebCore::Display::Rect::topLeft const):
(WebCore::Display::Rect::bottomRight const):
(WebCore::Display::Rect::size const):
(WebCore::Display::Rect::width const):
(WebCore::Display::Rect::height const):
(WebCore::Display::Rect::setTopLeft):
(WebCore::Display::Rect::setTop):
(WebCore::Display::Rect::setLeft):
(WebCore::Display::Rect::setWidth):
(WebCore::Display::Rect::setHeight):
(WebCore::Display::Rect::setSize):
(WebCore::Display::Rect::shiftLeftTo):
(WebCore::Display::Rect::shiftRightTo):
(WebCore::Display::Rect::shiftTopTo):
(WebCore::Display::Rect::shiftBottomTo):
(WebCore::Display::Rect::moveHorizontally):
(WebCore::Display::Rect::moveVertically):
(WebCore::Display::Rect::expand):
(WebCore::Display::Rect::clone const):
(WebCore::Display::Rect::operator LayoutRect const):
- layout/displaytree/DisplayRun.h: Renamed from Source/WebCore/layout/inlineformatting/InlineRun.h.
(WebCore::Display::Run::TextContext::start const):
(WebCore::Display::Run::TextContext::end const):
(WebCore::Display::Run::TextContext::length const):
(WebCore::Display::Run::TextContext::expand):
(WebCore::Display::Run::logicalTopLeft const):
(WebCore::Display::Run::logicalLeft const):
(WebCore::Display::Run::logicalRight const):
(WebCore::Display::Run::logicalTop const):
(WebCore::Display::Run::logicalBottom const):
(WebCore::Display::Run::logicalWidth const):
(WebCore::Display::Run::logicalHeight const):
(WebCore::Display::Run::setLogicalWidth):
(WebCore::Display::Run::setLogicalTop):
(WebCore::Display::Run::setLogicalLeft):
(WebCore::Display::Run::setLogicalRight):
(WebCore::Display::Run::moveVertically):
(WebCore::Display::Run::moveHorizontally):
(WebCore::Display::Run::expandVertically):
(WebCore::Display::Run::expandHorizontally):
(WebCore::Display::Run::setTextContext):
(WebCore::Display::Run::textContext):
(WebCore::Display::Run::textContext const):
(WebCore::Display::Run::Run):
(WebCore::Display::Run::TextContext::TextContext):
- layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::rectInContainingBlock const):
- layout/floats/FloatAvoider.h:
(WebCore::Layout::FloatAvoider::rect const):
- layout/floats/FloatBox.cpp:
(WebCore::Layout::FloatBox::rect const):
- layout/floats/FloatBox.h:
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatPair::intersects const):
- layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::initializeMarginBorderAndPaddingForGenericInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeMarginBorderAndPaddingForInlineContainer const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFloatBox const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForInlineBlock const):
(WebCore::Layout::InlineFormattingContext::computeHorizontalMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::collectInlineContent const):
(WebCore::Layout::InlineFormattingContext::computeMargin const): Deleted.
(WebCore::Layout::addDetachingRules): Deleted.
(WebCore::Layout::createAndAppendInlineItem): Deleted.
- layout/inlineformatting/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::LineLayout::layoutState const):
- layout/inlineformatting/InlineFormattingContextLineLayout.cpp:
(WebCore::Layout::halfLeadingMetrics):
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::contentLogicalRight const):
(WebCore::Layout::Line::contentLogicalWidth const):
(WebCore::Layout::Line::logicalTop const):
(WebCore::Layout::Line::logicalLeft const):
(WebCore::Layout::Line::logicalRight const):
(WebCore::Layout::Line::logicalBottom const):
(WebCore::Layout::Line::logicalWidth const):
(WebCore::Layout::Line::logicalHeight const):
(WebCore::Layout::Line::LineItem::LineItem):
(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::reset):
(WebCore::Layout::Line::close):
(WebCore::Layout::Line::removeTrailingTrimmableContent):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):
(WebCore::Layout::isTrimmableContent):
(WebCore::Layout::Line::trailingTrimmableWidth const):
(WebCore::Layout::Line::hasContent const):
(WebCore::Layout::Line::appendNonBreakableSpace):
(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendInlineContainerEnd):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonTextContent):
(WebCore::Layout::Line::appendHardLineBreak):
(WebCore::Layout::UncommittedContent::isEmpty const):
(WebCore::Layout::UncommittedContent::width const):
(WebCore::Layout::UncommittedContent::add):
(WebCore::Layout::UncommittedContent::reset):
(WebCore::Layout::InlineFormattingContext::LineLayout::LineLayout):
(WebCore::Layout::InlineFormattingContext::LineLayout::initializeLine const):
(WebCore::Layout::InlineFormattingContext::LineLayout::layout const):
(WebCore::Layout::InlineFormattingContext::LineLayout::closeLine const):
(WebCore::Layout::InlineFormattingContext::LineLayout::handleFloat const):
(WebCore::Layout::InlineFormattingContext::LineLayout::commitInlineItemToLine const):
(WebCore::Layout::horizontalAdjustmentForAlignment):
(WebCore::Layout::InlineFormattingContext::LineLayout::alignRuns const):
(WebCore::Layout::Line::isClosed const): Deleted.
(WebCore::Layout::Line::isFirstLine const): Deleted.
(WebCore::Layout::Line::runs): Deleted.
(WebCore::Layout::Line::contentLogicalLeft const): Deleted.
(WebCore::Layout::Line::lastRunType const): Deleted.
(WebCore::Layout::Line::init): Deleted.
(WebCore::Layout::Line::adjustLogicalLeft): Deleted.
(WebCore::Layout::Line::adjustLogicalRight): Deleted.
(WebCore::Layout::Line::appendContent): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::initializeNewLine const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::splitInlineRunIfNeeded const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::createFinalRuns const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::postProcessInlineRuns const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::appendContentToLine const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::computeFloatPosition const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::placeInFlowPositionedChildren const): Deleted.
(WebCore::Layout::adjustedLineLogicalLeft): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::justifyRuns): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::computeExpansionOpportunities const): Deleted.
(WebCore::Layout::InlineFormattingContext::LineLayout::runWidth const): Deleted.
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::inlineItems):
(WebCore::Layout::InlineFormattingState::lineBoxes):
(WebCore::Layout::InlineFormattingState::addInlineItem):
(WebCore::Layout::InlineFormattingState::addInlineRun):
(WebCore::Layout::InlineFormattingState::addLineBox):
(WebCore::Layout::InlineFormattingState::inlineContent): Deleted.
(WebCore::Layout::InlineFormattingState::lastInlineItem const): Deleted.
(WebCore::Layout::InlineFormattingState::appendInlineRun): Deleted.
- layout/inlineformatting/InlineItem.h:
(WebCore::Layout::InlineItem::type const):
(WebCore::Layout::InlineItem::isText const):
(WebCore::Layout::InlineItem::isBox const):
(WebCore::Layout::InlineItem::isHardLineBreak const):
(WebCore::Layout::InlineItem::isFloat const):
(WebCore::Layout::InlineItem::isLineBreak const):
(WebCore::Layout::InlineItem::isContainerStart const):
(WebCore::Layout::InlineItem::isContainerEnd const):
(WebCore::Layout::InlineItem::InlineItem):
(WebCore::Layout::InlineItem::setWidth):
(WebCore::Layout::InlineItem::width const):
(WebCore::Layout::InlineItem::addDetachingRule): Deleted.
(WebCore::Layout::InlineItem::detachingRules const): Deleted.
(WebCore::Layout::InlineItem::nonBreakableStart const): Deleted.
(WebCore::Layout::InlineItem::nonBreakableEnd const): Deleted.
(WebCore::Layout::InlineItem::addNonBreakableStart): Deleted.
(WebCore::Layout::InlineItem::addNonBreakableEnd): Deleted.
(WebCore::Layout::InlineItem::textContent const): Deleted.
- layout/inlineformatting/InlineLineBox.h: Copied from Source/WebCore/layout/floats/FloatBox.h.
(WebCore::Layout::LineBox::logicalTopLeft const):
(WebCore::Layout::LineBox::logicalLeft const):
(WebCore::Layout::LineBox::logicalRight const):
(WebCore::Layout::LineBox::logicalTop const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalWidth const):
(WebCore::Layout::LineBox::logicalHeight const):
(WebCore::Layout::LineBox::LineBox):
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::LineBreaker):
(WebCore::Layout::LineBreaker::breakingContext):
(WebCore::Layout::LineBreaker::wordBreakingBehavior const):
(WebCore::Layout::LineBreaker::runWidth const):
(WebCore::Layout::LineBreaker::isAtBreakingOpportunity):
(WebCore::Layout::LineBreaker::textWidth const):
(WebCore::Layout::InlineLineBreaker::InlineLineBreaker): Deleted.
(WebCore::Layout::InlineLineBreaker::nextRun): Deleted.
(WebCore::Layout::InlineLineBreaker::isAtContentEnd const): Deleted.
(WebCore::Layout::InlineLineBreaker::lineBreakingBehavior): Deleted.
(WebCore::Layout::InlineLineBreaker::runWidth const): Deleted.
(WebCore::Layout::InlineLineBreaker::textWidth const): Deleted.
(WebCore::Layout::InlineLineBreaker::splitRun): Deleted.
(WebCore::Layout::InlineLineBreaker::adjustSplitPositionWithHyphenation const): Deleted.
- layout/inlineformatting/InlineLineBreaker.h:
- layout/inlineformatting/InlineRunProvider.cpp: Removed.
- layout/inlineformatting/InlineRunProvider.h: Removed.
- layout/inlineformatting/InlineTextItem.cpp: Added.
(WebCore::Layout::isWhitespaceCharacter):
(WebCore::Layout::isSoftLineBreak):
(WebCore::Layout::moveToNextNonWhitespacePosition):
(WebCore::Layout::moveToNextBreakablePosition):
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
(WebCore::Layout::InlineTextItem::InlineTextItem):
- layout/inlineformatting/InlineTextItem.h: Copied from Source/WebCore/layout/inlineformatting/text/TextUtil.h.
(WebCore::Layout::InlineTextItem::start const):
(WebCore::Layout::InlineTextItem::end const):
(WebCore::Layout::InlineTextItem::length const):
(WebCore::Layout::InlineTextItem::isWhitespace const):
(WebCore::Layout::InlineTextItem::isCollapsed const):
- layout/inlineformatting/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::hyphenPositionBefore):
(WebCore::Layout::TextUtil::width):
(WebCore::Layout::TextUtil::fixedPitchWidth):
- layout/inlineformatting/text/TextUtil.h:
- layout/layouttree/LayoutBox.h:
- layout/layouttree/LayoutReplaced.cpp:
(WebCore::Layout::Replaced::intrinsicRatio const):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::accumulatedOffsetForInFlowPositionedContinuation):
(WebCore::Layout::TreeBuilder::createSubTree):
(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutBox):
- 11:59 AM Changeset in webkit [245775] by
-
- 7 edits in trunk
[iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
https://bugs.webkit.org/show_bug.cgi?id=198242
Reviewed by Beth Dakin.
Source/WebCore:
Teach the web content reader to respect the -preferredPresentationSize when creating attachment-backed image
elements. See below for more details.
Test: WKAttachmentTestsIOS.InsertDroppedImageWithPreferredPresentationSize
- editing/WebContentReader.h:
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):
When creating attachment-backed image elements, additionally set width and height attributes from the preferred
presentation size, if specified.
(WebCore::WebContentReader::readFilePath):
Add a version of readFilePath that takes a single file path, and an optional preferred presentation size.
(WebCore::WebContentReader::readFilePaths):
Reimplement readFilePaths in terms of readFilePath.
(WebCore::WebContentReader::readDataBuffer):
Add more plumbing for preferredPresentationSize.
- platform/Pasteboard.h:
(WebCore::PasteboardWebContentReader::readFilePath):
(WebCore::PasteboardWebContentReader::readDataBuffer):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):
Forward PasteboardItemInfo's preferredPresentationSize to the web content reader.
Tools:
Add a new test that simulates dropping an image with a preferred presentation size into an editable element
with attachment elements enabled.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
- 11:50 AM Changeset in webkit [245774] by
-
- 2 edits in trunk/Source/WebCore
Opt naver.com into simulated mouse events quirk on iOS
https://bugs.webkit.org/show_bug.cgi?id=198248
<rdar://problem/50598281>
Reviewed by Brent Fulgham.
- page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
- 9:41 AM Changeset in webkit [245773] by
-
- 4 edits in trunk
media/video-remote-control-playpause.html is timing out after r245712
https://bugs.webkit.org/show_bug.cgi?id=198238
Reviewed by Eric Carlson.
Source/WebCore:
Fix regression introduced in r245712.
Covered by test no longer timing out.
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::sessionWillEndPlayback):
LayoutTests:
- platform/mac/TestExpectations:
Removed old flaky expectation that is no longer valid according dashboard.
- 8:01 AM Changeset in webkit [245772] by
-
- 4 edits3 adds in trunk
[Async overflow scrolling] Absolute positioned element inside async overflow scroll didn't get composited sometimes
https://bugs.webkit.org/show_bug.cgi?id=198237
Reviewed by Antti Koivisto.
Source/WebCore:
The logic in requiresCompositingForIndirectReason() that decides if we need to do
compositing for a layer that needs to move independently of its enclosing scroller
was wrong.
Instead of asking question about the enclosing compositing layer, it needs to ask
whether it has different positioning behavior from the layer that it would
otherwise paint into, which is its paint-order parent.
"paintsIntoProvidedBacking" already does a containing-block check against the
scroller, so we know we don't have to do the check in that case.
Test: scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::enclosingCompositedScrollingLayer):
(WebCore::isScrolledByOverflowScrollLayer):
(WebCore::isNonScrolledLayerInsideScrolledCompositedAncestor):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason const):
- rendering/RenderLayerCompositor.h:
LayoutTests:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/absolute-inside-stacking-in-scroller.html: Added.
- 8:01 AM Changeset in webkit [245771] by
-
- 3 edits2 adds in trunk
[macOS] Fix programmatic scroll in RTL overflow with async scrolling enabled
https://bugs.webkit.org/show_bug.cgi?id=198226
Reviewed by Antti Koivisto.
Source/WebCore:
On macOS we need to use a scroll offset to set the layer position, not
a scroll position.
Test: scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html
- page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
(WebCore::ScrollingTreeOverflowScrollingNodeMac::repositionScrollingLayers):
Source/WebCore/../../LayoutTests:
- scrollingcoordinator/mac/rtl-programmatic-overflow-scroll-expected.html: Added.
- scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html: Added.
- 7:33 AM Changeset in webkit [245770] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=198245
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2019-05-25
Rubber-stamped by Michael Catanzaro.
- pt_BR.po:
- 2:25 AM Changeset in webkit [245769] by
-
- 3 edits1 add in trunk
JITOperations getByVal should mark negative array indices as out-of-bounds
https://bugs.webkit.org/show_bug.cgi?id=198229
Reviewed by Saam Barati.
JSTests:
- microbenchmarks/get-by-val-negative-array-index.js: Added.
(foo):
Source/JavaScriptCore:
get_by_val with an array or string as base value and a negative index causes DFG to OSR exit,
but baseline doesn't mark it as out-of-bounds, since it only considers positive indices. This
leads to discarding DFG code, recompiling it and exiting at the same bytecode.
This is observed in the prepack-wtb subtest of JetStream2. In popContext#CdOhFJ, the last item
of the array popped and the new last value is accessed usingarray[array.length - 1], which
is -1 when the array is empty. It shows a ~0.5% progression in JetStream2, but it's within the
noise.
- jit/JITOperations.cpp:
(JSC::getByVal):
May 24, 2019:
- 6:42 PM Changeset in webkit [245768] by
-
- 10 edits in trunk
Make computed width of non-replaced inline return computed style.
https://bugs.webkit.org/show_bug.cgi?id=197814
Reviewed by Antti Koivisto.
Currently, Computed width of non-replaced inline incorrectly returns "auto"
instead of the computed value.
This patch changes the behavior according to
https://drafts.csswg.org/cssom/#resolved-value as below.
'If the property applies to the element or pseudo-element
and the resolved value of the display property is not none or contents,
then the resolved value is the used value.
Otherwise the resolved value is the computed value.'
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
LayoutTests:
- fast/css/getComputedStyle/getComputedStyle-resolved-values-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
- legacy-animation-engine/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
- legacy-animation-engine/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
- 6:39 PM Changeset in webkit [245767] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r245715?) [WK2] Layout Test http/wpt/cache-storage/cache-storage-networkprocess-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=198222
<rdar://problem/51114899>
Reviewed by Alex Christensen.
In case a connection gets closed, handle all of its async reply completion handlers.
This ensures they handlers are called in case the connection does not get destroyed until a much later stage.
- Platform/IPC/Connection.cpp:
(IPC::Connection::~Connection):
(IPC::Connection::connectionDidClose):
(IPC::addAsyncReplyHandler):
(IPC::clearAsyncReplyHandlers):
(IPC::CompletionHandler<void):
- 5:51 PM Changeset in webkit [245766] by
-
- 7 edits in tags/Safari-608.1.25.1/Source
Versioning.
- 5:51 PM Changeset in webkit [245765] by
-
- 14 edits1 add in trunk
[WASM-References] Support Anyref in globals
https://bugs.webkit.org/show_bug.cgi?id=198102
Reviewed by Saam Barati.
JSTests:
Add test for anyrefs in globals, as well as adding a new RefNull initExpr for Builder.
- wasm/Builder.js:
(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
- wasm/Builder_WebAssemblyBinary.js:
(const.putInitExpr):
- wasm/references/anyref_globals.js: Added.
(GetGlobal.0.End.End.WebAssembly):
(5.doGCSet):
(doGCTest):
(doGCSet.doGCTest.let.count.0.doBarrierSet):
Source/JavaScriptCore:
Support anyref for globals, imports and exports. This adds code in B3 and Air to emit a write barrier
on the JSWebAssemblyWrapper whenever an anyref global is set. This also fixes a small bug in emitCCall
for air where it adds code to the wrong block.
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::emitCCall):
(JSC::Wasm::AirIRGenerator::moveOpForValueType):
(JSC::Wasm::AirIRGenerator::setGlobal):
(JSC::Wasm::AirIRGenerator::emitWriteBarrierForJSWrapper):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::setGlobal):
(JSC::Wasm::B3IRGenerator::emitWriteBarrierForJSWrapper):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::setGlobal):
- wasm/WasmInstance.h:
(JSC::Wasm::Instance::loadI32Global const):
(JSC::Wasm::Instance::loadI64Global const):
(JSC::Wasm::Instance::setGlobal):
(JSC::Wasm::Instance::shouldMarkGlobal):
(JSC::Wasm::Instance::numGlobals const):
- wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseInitExpr):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::visitChildren):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
- 5:40 PM Changeset in webkit [245764] by
-
- 1 copy in tags/Safari-608.1.25.1
New tag.
- 5:40 PM Changeset in webkit [245763] by
-
- 7 edits in trunk/Source
Versioning.
- 5:39 PM Changeset in webkit [245762] by
-
- 7 edits in branches/safari-608.1.24.30-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [245761] by
-
- 7 edits in branches/safari-608.1.24.20-branch/Source
Versioning.
- 4:45 PM Changeset in webkit [245760] by
-
- 1 copy in tags/Safari-608.1.24.30.2
Tag Safari-608.1.24.30.2.
- 4:38 PM Changeset in webkit [245759] by
-
- 6 edits2 adds in trunk
[WHLSL] Allow vertex attributes to have arbitrary names in the shader
https://bugs.webkit.org/show_bug.cgi?id=198235
Reviewed by Dean Jackson and Justin Fan.
Source/WebCore:
Metal doesn't allow arbitrary vertex attribute IDs. If you try to create a vertex attribute > 16,
the Metal validation layer will assert. So, we need to have a mapping from whatever the WebGPU
API says the vertex attribute IDs should be to the internally-used vertex attribute IDs.
Test: webgpu/whlsl-arbitrary-vertex-attribute-locations.html
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
(WebCore::WHLSL::Metal::VertexEntryPointScaffolding::VertexEntryPointScaffolding):
- Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:
- Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:
(WebCore::WHLSL::matchVertexAttributes):
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::convertRenderPipelineDescriptor):
(WebCore::trySetInputStateForPipelineDescriptor):
LayoutTests:
- webgpu/whlsl-arbitrary-vertex-attribute-locations-expected.html: Added.
- webgpu/whlsl-arbitrary-vertex-attribute-locations.html: Added.
- 4:17 PM Changeset in webkit [245758] by
-
- 1 copy in tags/Safari-608.1.24.20.4
Tag Safari-608.1.24.20.4.
- 3:48 PM Changeset in webkit [245757] by
-
- 4 edits in trunk/Source/WebKit
Remove unused member in WebsiteDataRecord
https://bugs.webkit.org/show_bug.cgi?id=198231
Reviewed by Brent Fulgham.
The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
with credentials are now stored in the 'origins' member.
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.
- UIProcess/WebsiteData/WebsiteDataRecord.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
- 3:13 PM Changeset in webkit [245756] by
-
- 2 edits in trunk/Source/WebKit
Crash under WebCore::TimerBase::~TimerBase after a download is canceled
https://bugs.webkit.org/show_bug.cgi?id=197927
rdar://problem/50822728
Reviewed by Ryosuke Niwa.
- NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::platformCancelNetworkLoad):
CFNetwork makes no guarantees about what thread is used to call the completion block
passed to -[NSURLSessionDownloadTask cancelByProducingResumeData], and in some cases,
it can be called on a background queue. This eventually causes the Download to be
deallocated on the background queue, which triggers a release assertion failure in
~TimerBase. When CFNetwork finishes canceling the download, we should move to the
main thread before calling didCancel().
- 2:47 PM Changeset in webkit [245755] by
-
- 2 edits in branches/safari-608.1.24.20-branch/Source/WebCore
Cherry-pick r245753. rdar://problem/51068494
Refactor how showLetterpressedGlyphsWithAdvances gets the graphics context.
https://bugs.webkit.org/show_bug.cgi?id=198225
Reviewed by Dean Jackson.
- platform/graphics/cocoa/FontCascadeCocoa.mm: (WebCore::showLetterpressedGlyphsWithAdvances): (WebCore::FontCascade::drawGlyphs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:47 PM Changeset in webkit [245754] by
-
- 5 edits in branches/safari-608.1.24.20-branch/Source/WebCore
Cherry-pick r245752. rdar://problem/51068494
Plumb dark appearance down to GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=198224
rdar://problem/51068494
Reviewed by Dean Jackson.
No test yet, as it is not testable until this gets used.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextStateChange::changesFromState const): (WebCore::GraphicsContextStateChange::accumulate): (WebCore::GraphicsContextStateChange::apply const): (WebCore::GraphicsContextStateChange::dump const): (WebCore::GraphicsContext::setUseDarkAppearance):
- platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::useDarkAppearance const):
- rendering/TextPaintStyle.cpp: (WebCore::TextPaintStyle::operator== const): (WebCore::computeTextPaintStyle): (WebCore::updateGraphicsContext):
- rendering/TextPaintStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:41 PM Changeset in webkit [245753] by
-
- 2 edits in trunk/Source/WebCore
Refactor how showLetterpressedGlyphsWithAdvances gets the graphics context.
https://bugs.webkit.org/show_bug.cgi?id=198225
Reviewed by Dean Jackson.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):
- 2:41 PM Changeset in webkit [245752] by
-
- 5 edits in trunk/Source/WebCore
Plumb dark appearance down to GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=198224
rdar://problem/51068494
Reviewed by Dean Jackson.
No test yet, as it is not testable until this gets used.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContextStateChange::changesFromState const):
(WebCore::GraphicsContextStateChange::accumulate):
(WebCore::GraphicsContextStateChange::apply const):
(WebCore::GraphicsContextStateChange::dump const):
(WebCore::GraphicsContext::setUseDarkAppearance):
- platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::useDarkAppearance const):
- rendering/TextPaintStyle.cpp:
(WebCore::TextPaintStyle::operator== const):
(WebCore::computeTextPaintStyle):
(WebCore::updateGraphicsContext):
- rendering/TextPaintStyle.h:
- 12:49 PM Changeset in webkit [245751] by
-
- 2 edits in trunk/LayoutTests
Rebase compositing/rtl/rtl-overflow-scrolling.html
https://bugs.webkit.org/show_bug.cgi?id=198220
<rdar://problem/51114177>
Unreviewed test gardening.
New result is a progression (scrollX, which is an offset, should not be negative).
- platform/ios-wk2/compositing/rtl/rtl-overflow-scrolling-expected.txt:
- 12:01 PM Changeset in webkit [245750] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Overlay: don't show setting for showing rulers/guides during element selection if it's not supported
https://bugs.webkit.org/show_bug.cgi?id=198221
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
- 11:55 AM Changeset in webkit [245749] by
-
- 3 edits in trunk/Source/WebKit
Update messages_unittest.py after r245715
https://bugs.webkit.org/show_bug.cgi?id=198214
Reviewed by Alexey Proskuryakov.
Update expected results for messages.py output.i
Small refactoring to messages.py: instead of calling the completionHandler in case of decoding error with AsyncReply errors,
call cancelReply directly as it does the same thing.
- Scripts/webkit/MessageReceiverSuperclass-expected.cpp:
(Messages::WebPage::TestAsyncMessage::callReply):
(Messages::WebPage::TestAsyncMessage::cancelReply):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::callReply):
(Messages::WebPage::TestAsyncMessageWithMultipleArguments::cancelReply):
- Scripts/webkit/messages.py:
- 11:26 AM Changeset in webkit [245748] by
-
- 2 edits in trunk/Source/WebCore
Make sure completion handler is always called in SWServer::startSuspension
https://bugs.webkit.org/show_bug.cgi?id=198215
Reviewed by Alex Christensen.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::startSuspension):
Make sure completion handler is called in case of no registration store.
- 10:47 AM Changeset in webkit [245747] by
-
- 3 edits in trunk/LayoutTests
scrollingcoordinator/scrolling-tree/fixed-inside-frame.html is no longer flaky
https://bugs.webkit.org/show_bug.cgi?id=194253
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations: Removing failed expectations
- 9:33 AM Changeset in webkit [245746] by
-
- 4 edits2 adds in trunk
Asssertion failure in dispatchSubtreeModifiedEvent due to TextFieldInputType updating UA shadow tree inside Element::removedFromAncestor
https://bugs.webkit.org/show_bug.cgi?id=198216
Reviewed by Brent Fulgham.
Source/WebCore:
The bug was caused by ListAttributeTargetObserver::idTargetChanged() updating the shadow tree of an input element
within Element::removedFromAncestor via TextFieldInputType::createDataListDropdownIndicator(). Fixed it by
supressing the assertions with ScriptDisallowedScope::EventAllowedScope since it's always safe to update
UA shadow trees of input elements as it's not exposed to author scripts.
Avoiding the creation of dropdown indicator in this particular scenario is a lot more involved and it's not
particularly correct because there could be another datalist element which matches the ID specified in list
content attribute after the removal of the old datalist element.
Test: fast/forms/datalist/datalist-removal-assertion.html
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::TextFieldInputType::createContainer):
- html/shadow/DataListButtonElement.cpp:
(WebCore::DataListButtonElement::DataListButtonElement):
LayoutTests:
Added a regression test.
- fast/forms/datalist/datalist-removal-assertion-expected.txt: Added.
- fast/forms/datalist/datalist-removal-assertion.html: Added.
- 1:19 AM Changeset in webkit [245745] by
-
- 6 edits in trunk/Source/WebCore
[WHLSL] ReadModifyWriteExpression always has a result and new value expression
https://bugs.webkit.org/show_bug.cgi?id=198079
Reviewed by Myles Maxfield.
Let's not pretend it might not.
- Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::resultExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeNewValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeResultExpression):
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
(WebCore::WHLSL::ASTDumper::visit):
- Modules/webgpu/WHLSL/WHLSLChecker.cpp:
(WebCore::WHLSL::Checker::visit):
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
(WebCore::WHLSL::PropertyResolver::visit):
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
(WebCore::WHLSL::Visitor::visit):
- 12:54 AM Changeset in webkit [245744] by
-
- 2 edits in trunk/Tools
Make display-profiler-output work with newer HighLine
https://bugs.webkit.org/show_bug.cgi?id=198205
Reviewed by Saam Barati.
Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
- Scripts/display-profiler-output:
May 23, 2019:
- 10:27 PM Changeset in webkit [245743] by
-
- 3 edits2 adds in branches/safari-608.1.24.20-branch
Cherry-pick r245742. rdar://problem/49720087
With async overflow scrolling, programmatic scroll to a negative offset fails to clamp the scroll offset
https://bugs.webkit.org/show_bug.cgi?id=198208
<rdar://problem/49720087>
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderLayer::scrollToOffset() needs to pass the clamped offset to scrollingCoordinator->requestScrollPositionUpdate(),
otherwise the scrolling tree will round-trip a negative value and scrollLeft will end up negative.
Test: fast/scrolling/programmatic-scroll-to-negative-offset.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
LayoutTests:
- fast/scrolling/programmatic-scroll-to-negative-offset-expected.txt: Added.
- fast/scrolling/programmatic-scroll-to-negative-offset.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:25 PM Changeset in webkit [245742] by
-
- 3 edits2 adds in trunk
With async overflow scrolling, programmatic scroll to a negative offset fails to clamp the scroll offset
https://bugs.webkit.org/show_bug.cgi?id=198208
<rdar://problem/49720087>
Reviewed by Zalan Bujtas.
Source/WebCore:
RenderLayer::scrollToOffset() needs to pass the clamped offset to scrollingCoordinator->requestScrollPositionUpdate(),
otherwise the scrolling tree will round-trip a negative value and scrollLeft will end up negative.
Test: fast/scrolling/programmatic-scroll-to-negative-offset.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
LayoutTests:
- fast/scrolling/programmatic-scroll-to-negative-offset-expected.txt: Added.
- fast/scrolling/programmatic-scroll-to-negative-offset.html: Added.
- 8:19 PM Changeset in webkit [245741] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: prevent stripping
console.assertif it's used inside a string
https://bugs.webkit.org/show_bug.cgi?id=198207
Reviewed by Joseph Pecoraro.
- Scripts/remove-console-asserts.pl:
(removeConsoleAssertsInFile):
- 7:55 PM Changeset in webkit [245740] by
-
- 7 edits in branches/safari-608.1.24.50-branch/Source
Versioning.
- 7:53 PM Changeset in webkit [245739] by
-
- 7 edits in branches/safari-608.1.24.20-branch/Source
Versioning.
- 7:53 PM Changeset in webkit [245738] by
-
- 1 copy in tags/Safari-608.1.24.50.1
Tag Safari-608.1.24.50.1.
- 7:51 PM Changeset in webkit [245737] by
-
- 7 edits in branches/safari-608.1.24.40-branch/Source
Versioning.
- 7:36 PM Changeset in webkit [245736] by
-
- 3 edits in branches/safari-608.1.24.50-branch/Source/WebKit
Cherry-pick r245589. rdar://problem/50971874
[WebAuthN] Make WebAuthN default on only on macOS
https://bugs.webkit.org/show_bug.cgi?id=198068
<rdar://problem/50971874>
Reviewed by Brent Fulgham.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:32 PM Changeset in webkit [245735] by
-
- 7 edits in branches/safari-608.1.24.50-branch/Source
Versioning.
- 7:27 PM Changeset in webkit [245734] by
-
- 1 copy in branches/safari-608.1.24.50-branch
New branch.
- 7:27 PM Changeset in webkit [245733] by
-
- 15 edits in trunk
run-webkit-tests: Remove feature detection support
https://bugs.webkit.org/show_bug.cgi?id=198105
Reviewed by Jonathan Bedard.
Tools:
Feature detection support was added to DRT for Windows and old
run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
But, it doesn't work for DRT for Windows because of feature name
mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
removed in Bug 127833, it is not needed anymore.
- DumpRenderTree/win/DumpRenderTree.cpp:
(main):
- Scripts/webkitpy/port/base.py:
(Port._tests_for_other_platforms):
(Port._skipped_tests_for_unsupported_features):
(Port._runtime_feature_list): Deleted.
(Port.nm_command): Deleted.
(Port._modules_to_search_for_symbols): Deleted.
(Port._symbols_string): Deleted.
(Port._missing_feature_to_skipped_tests): Deleted.
(Port._has_test_in_directories): Deleted.
- Scripts/webkitpy/port/darwin.py:
(DarwinPort.make_command):
(DarwinPort.nm_command): Deleted.
- Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.reset_preferences):
(IOSSimulatorPort.nm_command): Deleted.
- Scripts/webkitpy/port/port_testcase.py:
(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(PortTestCase.test_path_to_test_expectations_file):
(TestWebKitPort._symbols_string): Deleted.
(PortTestCase.test_skipped_directories_for_features): Deleted.
(PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
(PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
- Scripts/webkitpy/port/watch_simulator.py:
(WatchSimulatorPort.reset_preferences):
(WatchSimulatorPort.nm_command): Deleted.
- Scripts/webkitpy/port/win.py:
(WinPort.show_results_html_file):
(WinPort._runtime_feature_list): Deleted.
- Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_operating_system):
(WinPortTest.test_runtime_feature_list): Deleted.
- WebKitTestRunner/Options.cpp:
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionPrintSupportedFeatures): Deleted.
- WebKitTestRunner/Options.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
LayoutTests:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Added Skip for all compositing, animations/3d and transforms/3d tests temporarily.
- 7:09 PM Changeset in webkit [245732] by
-
- 1 copy in tags/Safari-608.1.24.20.3
Tag Safari-608.1.24.20.3.
- 6:59 PM Changeset in webkit [245731] by
-
- 1 delete in tags/Safari-608.1.24.50
Delete tag.
- 6:34 PM Changeset in webkit [245730] by
-
- 12 edits in trunk/Source
Web Inspector: Overlay: rulers/guides should be shown whenever element selection is enabled
https://bugs.webkit.org/show_bug.cgi?id=198088
Reviewed by Timothy Hatcher.
When trying to "measure" the absolute position (to the viewport) or relative position (to
another element) of a given element, often the easiest way is to enable Element Selection
and Show Rulers at the same time.
This can have the undesired "side-effect" of having the rulers be always present, even when
not highlighting any nodes.
The ideal functionality is to allow the rulers/guides to be shown when element selection is
active and a node is hovered, regardless of whether "Show Rulers" is enabled.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Add an optional
showRulersparameter toDOM.setInspectModeEnabledthat supersedes the
current value ofPage.setShowRulersas to whether rulers/guides are shown.
Source/WebCore:
- inspector/InspectorOverlay.h:
(WebCore::InspectorOverlay::setShowRulersDuringElementSelection): Added.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::shouldShowOverlay):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::drawElementTitle):
IfshowRulersDuringElementSelectionis enabled, draw rulers whenever any highlight bounds
are calculated, but don't update the overlay if it's the only thing enabled (e.g. if there's
no currently hovered node, the overlay will disappear).
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::setSearchingForNode):
Add an optionalshowRulersparameter toDOM.setInspectModeEnabledthat supersedes the
current value ofPage.setShowRulersas to whether rulers/guides are shown.
Source/WebInspectorUI:
- UserInterface/Base/Setting.js:
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
Add a setting for controlling whether rulers/guides are shown during element selection.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.set inspectModeEnabled):
Pass the setting value as an optional parameter when callingDOM.setInspectModeEnabled.
- Localizations/en.lproj/localizedStrings.js:
- 6:22 PM Changeset in webkit [245729] by
-
- 20 edits in trunk
Unreviewed, rolling out r245665.
https://bugs.webkit.org/show_bug.cgi?id=198203
Inspector appears blank, again. (Requested by NVI on #webkit).
Reverted changeset:
"Web Inspector: Provide UIString descriptions to improve
localizations"
https://bugs.webkit.org/show_bug.cgi?id=195132
https://trac.webkit.org/changeset/245665
- 5:10 PM Changeset in webkit [245728] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Overlay: rulers should switch sides if they intersect the highlighted node(s) so they don't obstruct any content
https://bugs.webkit.org/show_bug.cgi?id=198165
Reviewed by Timothy Hatcher.
If the highlighted node is against the top edge of the screen, the top ruler should shift to
the bottom, unless the highlighted node is also against the bottom edge of the screen.
If the highlighted node is against the left edge of the screen, the left ruler should shift
to the right, unless the highlighted node is also against the right edge of the screen.
This way, unless the node is very wide/tall, the rulers won't be drawn on top of anything
being highlighted.
- inspector/InspectorOverlay.h:
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::drawBounds):
(WebCore::InspectorOverlay::drawRulers):
Drive-by: create an alias for the type (FloatRect) used when calculating the bounds of
everything that's highlighted.
- 4:41 PM Changeset in webkit [245727] by
-
- 2 edits in trunk/Source/WebCore
[WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction
https://bugs.webkit.org/show_bug.cgi?id=198199
Reviewed by Myles C. Maxfield.
We would dump "*foo.bar" for "(*foo).bar", which is super confusing.
We now dump "(*foo).bar".
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
(WebCore::WHLSL::ASTDumper::visit):
- 4:36 PM Changeset in webkit [245726] by
-
- 7 edits in trunk/Source
Socket-based RWI should be able to inspect a JSContext
https://bugs.webkit.org/show_bug.cgi?id=198197
Reviewed by Don Olmstead.
Source/JavaScriptCore:
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::listingForInspectionTarget const):
Just use the debuggableType strings that WebInspectorUI ultimately wants.
Source/WebKit:
- UIProcess/socket/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::inspect):
- UIProcess/socket/RemoteInspectorClient.h:
- UIProcess/socket/RemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::inspect):
(WebKit::RemoteInspectorProtocolHandler::targetListChanged):
(WebKit::RemoteInspectorProtocolHandler::platformStartTask):
- UIProcess/socket/RemoteInspectorProtocolHandler.h:
Have the RWI client actually pass the debuggableType to WebInspectorUI.
- 4:34 PM Changeset in webkit [245725] by
-
- 3 edits in branches/safari-607-branch/LayoutTests
Land test changes for rdar://problem/51086725.
- inspector/runtime/parse-expected.txt:
- inspector/runtime/parse.html:
- 4:13 PM Changeset in webkit [245724] by
-
- 2 edits in trunk/Source/WebCore
[WHLSL] Don't wrap anonymous variables in parens in the AST dumper
https://bugs.webkit.org/show_bug.cgi?id=198196
Reviewed by Myles C. Maxfield.
This makes the dump of 'foo.bar.x = 42' go from
($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));
to:
($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
(WebCore::WHLSL::ASTDumper::visit):
- 3:58 PM Changeset in webkit [245723] by
-
- 10 edits in trunk
[CMake] Use target oriented design for bmalloc
https://bugs.webkit.org/show_bug.cgi?id=198046
Reviewed by Konstantin Tokarev.
.:
Add WEBKIT_COPY_FILES to WebKitMacros so it is available to all CMake code. Add
bmalloc_FRAMEWORK_HEADERS_DIR for specifying the location to copy bmalloc headers to.
- Source/cmake/WebKitFS.cmake:
- Source/cmake/WebKitMacros.cmake:
Source/bmalloc:
Switch to a target oriented dsign for bmalloc. Use target_include_directories directly
instead of include_directories.
List the headers for bmalloc and copy them using WEBKIT_COPY_FILES.
Add an intermediate target bmalloc_PostBuild which depends on bmalloc and the headers
being copied. Then alias that to WebKit::bmalloc.
- CMakeLists.txt:
- PlatformMac.cmake:
Source/ThirdParty/ANGLE:
Remove WEBKIT_COPY_FILES from CMakelists.txt now that it is in WebKitMacros.
- CMakeLists.txt:
Source/WTF:
Use WebKit::bmalloc target.
- wtf/CMakeLists.txt:
- 3:41 PM Changeset in webkit [245722] by
-
- 2 edits in trunk/Source/WebCore
[WHLSL] Implement property resolver
https://bugs.webkit.org/show_bug.cgi?id=195925
<rdar://problem/48219643>
Unreviewed watchOS build fix.
- Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
(WebCore::WHLSL::AST::AssignmentExpression::AssignmentExpression):
- 3:21 PM Changeset in webkit [245721] by
-
- 3 edits2 adds in trunk
[WHLSL] Property resolver needs to recurse to handle the base when simplifying rvalues
https://bugs.webkit.org/show_bug.cgi?id=198193
Reviewed by Myles Maxfield.
Source/WebCore:
We were only transforming the top most node in the AST. So things like
'x = foo.bar' would work, but 'x = foo.bar.baz' would not.
Test: webgpu/whlsl-nested-dot-expression-rvalue.html
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
(WebCore::WHLSL::PropertyResolver::simplifyRightValue):
LayoutTests:
- webgpu/whlsl-nested-dot-expression-rvalue-expected.html: Added.
- webgpu/whlsl-nested-dot-expression-rvalue.html: Added.
- 3:08 PM Changeset in webkit [245720] by
-
- 2 edits in trunk/LayoutTests
http/tests/resourceLoadStatistics/prune-statistics.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197285
Unreviewed test gardening. Updating expectations for Release as well
- platform/mac-wk2/TestExpectations:
- 2:39 PM Changeset in webkit [245719] by
-
- 2 edits in trunk/LayoutTests
fast/css-grid-layout/flex-content-sized-columns-resize.html is a flaky ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=187828#add_comment
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating for flkay test
- 2:22 PM Changeset in webkit [245718] by
-
- 2 edits in trunk/LayoutTests
fast/css/sticky/sticky-left-percentage.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=198195
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating for flaky test
- 2:19 PM Changeset in webkit [245717] by
-
- 4 edits in trunk/Source
release builds of webkit cannot be used to generate a dyld shared cache
https://bugs.webkit.org/show_bug.cgi?id=198150
<rdar://problem/50675982>
Reviewed by Dan Bernstein.
Restrict the -not_for_dyld_shared_cache linker flag to macosx
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit:
- Configurations/WebKit.xcconfig:
- 2:17 PM Changeset in webkit [245716] by
-
- 20 edits in trunk/Source
[Hittest] Move hittesting from RenderView to Document
https://bugs.webkit.org/show_bug.cgi?id=198192
<rdar://problem/51077762>
Reviewed by Antti Koivisto.
Source/WebCore:
RenderView is not refcounted and may be destroyed in updateLayout(), so enter hit-testing from Document.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint const):
- dom/Document.cpp:
(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower):
(WebCore::FrameFlatteningLayoutDisallower::~FrameFlatteningLayoutDisallower):
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::prepareMouseEvent):
(WebCore::Document::hitTest):
- dom/Document.h:
(WebCore::Document::inHitTesting const):
- dom/TreeScope.cpp:
(WebCore::TreeScope::nodeFromPoint):
(WebCore::TreeScope::elementsFromPoint):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains const):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::isReplacementObscured):
- html/MediaElementSession.cpp:
(WebCore::isElementMainContentForPurposesOfAutoplay):
- page/DragController.cpp:
(WebCore::elementUnderMouse):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag const):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint const):
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::isInsideScrollbar const):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::handleDrag):
(WebCore::hitTestResultInFrame):
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::setNeedsLayoutAfterViewConfigurationChange):
- rendering/RenderView.cpp:
(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower): Deleted.
(WebCore::FrameFlatteningLayoutDisallower::~FrameFlatteningLayoutDisallower): Deleted.
(): Deleted.
(WebCore::RenderView::hitTest): Deleted.
- rendering/RenderView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect const):
Source/WebKit:
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
- 2:15 PM Changeset in webkit [245715] by
-
- 26 edits2 adds1 delete in trunk
CacheStorageConnection callbacks should be completed on network connection close
https://bugs.webkit.org/show_bug.cgi?id=195757
Reviewed by Alex Christensen.
Source/WebCore:
Move HashMap-based callbacks to WorkerCacheStorageConnection.
Make CacheStorageConnection default API to implement use callbacks.
This is used by WebKit layer to do AsyncReply IPC.
Move DOMCacheEngine callbacks to CompletionHandler.
Test: http/wpt/cache-storage/cache-storage-networkprocess-crash.html
- Modules/cache/CacheStorageConnection.cpp:
- Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::engineRepresentation):
- Modules/cache/DOMCacheEngine.h:
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::recordsDataFromRecords):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::recordsFromRecordsData):
(WebCore::recordsOrErrorFromRecordsData):
(WebCore::WorkerCacheStorageConnection::open):
(WebCore::WorkerCacheStorageConnection::openOrRemoveCompleted):
(WebCore::WorkerCacheStorageConnection::remove):
(WebCore::WorkerCacheStorageConnection::retrieveCaches):
(WebCore::WorkerCacheStorageConnection::retrieveCachesCompleted):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::retrieveRecordsCompleted):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::deleteRecordsCompleted):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
(WebCore::WorkerCacheStorageConnection::putRecordsCompleted):
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
(WebCore::WorkerCacheStorageConnection::clearPendingRequests):
- Modules/cache/WorkerCacheStorageConnection.h:
- page/CacheStorageProvider.h:
(WebCore::CacheStorageProvider::createCacheStorageConnection):
Source/WebKit:
Update according new WebCore CacheStorageConnection interface.
Use Async IPC replies so that the completion handlers are called on network crash.
Allow to have specific error handling in case of cancelled reply or badly decoded message.
This allows to reject the corresponding JS promise.
- CMakeLists.txt:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::requestSpace):
(WebKit::CacheStorage::Caches::writeRecord):
- NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
- NetworkProcess/cache/CacheStorageEngineConnection.h:
(IPC::AsyncReplyError<WebCore::DOMCacheEngine::CacheIdentifierOrError>::create):
(IPC::AsyncReplyError<WebCore::DOMCacheEngine::RecordIdentifiersOrError>::create):
(IPC::AsyncReplyError<WebCore::DOMCacheEngine::CacheInfosOrError>::create):
(IPC::AsyncReplyError<WebCore::DOMCacheEngine::RecordsOrError>::create):
- NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/Connection.h:
(IPC::AsyncReplyError::create):
- Scripts/webkit/messages.py:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::open):
(WebKit::WebCacheStorageConnection::remove):
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
- WebProcess/Cache/WebCacheStorageConnection.h:
- WebProcess/Cache/WebCacheStorageConnection.messages.in: Removed.
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
LayoutTests:
- http/wpt/cache-storage/cache-storage-networkprocess-crash-expected.txt: Added.
- http/wpt/cache-storage/cache-storage-networkprocess-crash.html: Added.
- 2:08 PM Changeset in webkit [245714] by
-
- 1 edit in branches/safari-608.1.24.20-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Fix incorrect merge conflict resolution. rdar://problem/50613388
- 2:06 PM Changeset in webkit [245713] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused CSS class "offset-sections"
https://bugs.webkit.org/show_bug.cgi?id=198194
<rdar://problem/51080111>
Reviewed by Devin Rousso.
- UserInterface/Views/DebuggerSidebarPanel.js:
- UserInterface/Views/StyleDetailsPanel.js:
(WI.StyleDetailsPanel):
- 1:56 PM Changeset in webkit [245712] by
-
- 11 edits2 adds in trunk
Multiple videos (with audios) with autoplay & playinline not working. Only one video play at a time.
https://bugs.webkit.org/show_bug.cgi?id=193312
<rdar://problem/47189864>
Reviewed by Jer Noble.
Source/WebCore:
Allow all MediaStream backed video elements to play together.
Any non MediaStream backed video will stop all MediaStream backed video elements.
Conversely, all non MediaStream backed videos will stop when playing one MediaStream backed video.
Refactor PlatformMediaSessionManager as the way to iterate through sessions
is not safe when pausing a session: if playing, the session will be moved in the array of sessions.
To handle this, copy the list of sessions before iterating through them.
For extra safety, make sessions WeakPtr.
Add routines for the case of filtering with a predicate taking a const session.
In that case, we do not copy the vector but iterate through it as a small optimization.
Test: webrtc/concurrentVideoPlayback.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager):
(WebCore::HTMLMediaElement::hasMediaStreamSource const):
- html/HTMLMediaElement.h:
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::activeAudioSessionRequired const):
(WebCore::PlatformMediaSession::canPlayConcurrently const):
(WebCore::PlatformMediaSession::activeAudioSessionRequired): Deleted.
- platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSessionClient::hasMediaStreamSource const):
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::has const):
(WebCore::PlatformMediaSessionManager::activeAudioSessionRequired const):
(WebCore::PlatformMediaSessionManager::canProduceAudio const):
(WebCore::PlatformMediaSessionManager::count const):
(WebCore::PlatformMediaSessionManager::beginInterruption):
(WebCore::PlatformMediaSessionManager::endInterruption):
(WebCore::PlatformMediaSessionManager::addSession):
(WebCore::PlatformMediaSessionManager::removeSession):
(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
(WebCore::PlatformMediaSessionManager::sessionWillEndPlayback):
(WebCore::PlatformMediaSessionManager::setCurrentSession):
(WebCore::PlatformMediaSessionManager::currentSession const):
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground):
(WebCore::PlatformMediaSessionManager::systemWillSleep):
(WebCore::PlatformMediaSessionManager::systemDidWake):
(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForProcess):
(WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::currentSessionsMatching const):
(WebCore::PlatformMediaSessionManager::forEachMatchingSession):
(WebCore::PlatformMediaSessionManager::forEachMatchingSession const):
(WebCore::PlatformMediaSessionManager::forEachSession):
(WebCore::PlatformMediaSessionManager::anyOfSessions const):
(): Deleted.
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const): Deleted.
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const): Deleted.
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const): Deleted.
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const): Deleted.
(WebCore::PlatformMediaSessionManager::forEachSession const): Deleted.
(WebCore::PlatformMediaSessionManager::findSession const): Deleted.
- platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::anyOfSessions const): Deleted.
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(MediaSessionManagerCocoa::updateSessionState):
(MediaSessionManagerCocoa::beginInterruption):
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring):
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
LayoutTests:
- webrtc/concurrentVideoPlayback-expected.txt: Added.
- webrtc/concurrentVideoPlayback.html: Added.
- 1:44 PM Changeset in webkit [245711] by
-
- 2 edits in trunk/LayoutTests
Updating test expectations for failing tests.
<rdar://problem/47088939>
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:43 PM Changeset in webkit [245710] by
-
- 3 edits1 add in trunk
DFG::OSREntry should not perform arity check
https://bugs.webkit.org/show_bug.cgi?id=198189
Reviewed by Saam Barati.
JSTests:
- microbenchmarks/loop-osr-with-arity-mismatch.js: Added.
(foo):
Source/JavaScriptCore:
The check prevents OSR entering from hot loops inside functions that were called
with too few arguments.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- 1:23 PM Changeset in webkit [245709] by
-
- 2 edits in trunk/Source/WebKit
Handling for non-persistent data should be consistent in computeNetworkProcessAccessTypeForDataFetch
https://bugs.webkit.org/show_bug.cgi?id=198050
Reviewed by Youenn Fablet.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessTypeForDataFetch):
- 1:20 PM Changeset in webkit [245708] by
-
- 1 edit in branches/safari-608.1.24.20-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Unreviewed build fix. rdar://problem/50613388
- 1:15 PM Changeset in webkit [245707] by
-
- 2 edits in trunk/Tools
[Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
https://bugs.webkit.org/show_bug.cgi?id=198098
Reviewed by Don Olmstead.
With current CMake and Visual Studio 2019, the default
architecture will match the host, so we should make sure
to explicitly mention the architecture we want for 32-bit
builds as well for cases where we are on x64 and not in an
x64_x32 cross-build vcvars environment.
- Scripts/webkitdirs.pm:
(getVisualStudioToolset): Get toolset name for cmake/msbuild
(getMSBuildPlatformArgument): Update to use getVisualStudioToolset
(getCMakeWindowsToolsetArgument): Get -A argument for cmake
based on toolset
(generateBuildSystemFromCMakeProject): Remove explicit -A x64
in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
- 12:54 PM Changeset in webkit [245706] by
-
- 4 edits in trunk/Source/WebCore
[WHLSL] Add a helper for in-place AST mutation
https://bugs.webkit.org/show_bug.cgi?id=198175
Reviewed by Myles Maxfield.
This makes WHLSL AST mutation code a bit easier to read and write.
Code that looked like:
`
static_assert(sizeof(AST::DereferenceExpression) <= sizeof(AST::DotExpression), "Dot expressions need to be able to become dereference expressions without updating backreferences");
void* location = &dotExpression;
dotExpression.~DotExpression();
auto* dereferenceExpression = new (location) AST::DereferenceExpression(WTFMove(origin), WTFMove(callExpression));
`
Can now be:
`
auto* dereferenceExpression = AST::replaceWith<AST::DereferenceExpression>(dotExpression, WTFMove(origin), WTFMove(callExpression));
`
- Modules/webgpu/WHLSL/AST/WHLSLNode.h:
(WebCore::WHLSL::AST::replaceWith):
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
(WebCore::WHLSL::NameResolver::visit):
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
(WebCore::WHLSL::PropertyResolver::visit):
(WebCore::WHLSL::PropertyResolver::simplifyRightValue):
(WebCore::WHLSL::LeftValueSimplifier::visit):
- 12:45 PM Changeset in webkit [245705] by
-
- 3 edits in tags/Safari-608.1.24.50/Source/WebKit
Cherry-pick r245589. rdar://problem/50971874
[WebAuthN] Make WebAuthN default on only on macOS
https://bugs.webkit.org/show_bug.cgi?id=198068
<rdar://problem/50971874>
Reviewed by Brent Fulgham.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:42 PM Changeset in webkit [245704] by
-
- 7 edits in tags/Safari-608.1.24.50/Source
Versioning.
- 12:33 PM Changeset in webkit [245703] by
-
- 1 copy in tags/Safari-608.1.24.50
New tag.
- 12:33 PM Changeset in webkit [245702] by
-
- 1 copy in tags/Safari-608.1.24.40.4
Tag Safari-608.1.24.40.4.
- 12:12 PM Changeset in webkit [245701] by
-
- 2 edits in trunk/Source/WebCore
[macOS,iOS] Add always-on logging for AVPlayerTimeControlStatus changes
https://bugs.webkit.org/show_bug.cgi?id=197946
<rdar://problem/50627457>
Reviewed by Jon Lee.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::convertEnumerationToString):
(WTF::LogArgument<AVPlayerTimeControlStatus>::toString):
(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):
- 11:32 AM Changeset in webkit [245700] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r245695.
- dom/Element.cpp:
- 11:13 AM Changeset in webkit [245699] by
-
- 4 edits2 adds in trunk
[Pointer Events] Compatibility mouse events can only be prevented while the pointer is pressed
https://bugs.webkit.org/show_bug.cgi?id=198178
Patch by Antoine Quint <Antoine Quint> on 2019-05-23
Reviewed by Dean Jackson.
Source/WebCore:
Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html
The Pointer Events spec, in https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "Mouse events
can only be prevented when the pointer is down. Hovering pointers (e.g. a mouse with no buttons pressed) cannot have their mouse
events prevented." We now track whether the pointer is pressed and clear the preventsCompatibilityMouseEvents when the pointer is
moved and it is not pressed.
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::pointerEventWasDispatched):
- page/PointerCaptureController.h:
LayoutTests:
Add a test that listens "mousemove" events and checks it is not dispatched after preventDefault() is called when handling
"pointerdown" but it is dispatched after releasing the mouse pointer and moving it again.
- pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released-expected.txt: Added.
- pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html: Added.
- 11:08 AM Changeset in webkit [245698] by
-
- 4 edits in trunk
Set default WebsiteDataStore storage quota based on StorageQuotaManager
https://bugs.webkit.org/show_bug.cgi?id=198133
<rdar://problem/51031436>
Reviewed by Geoffrey Garen.
Source/WebKit:
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
(doTest):
- 11:07 AM Changeset in webkit [245697] by
-
- 2 edits in trunk/Source/JavaScriptCore
Lexer<T>::parseDecimal ought to ASSERT isASCIIDigit
https://bugs.webkit.org/show_bug.cgi?id=198156
Reviewed by Keith Miller.
- parser/Lexer.cpp:
(JSC::Lexer<T>::parseDecimal):
Add ASSERT -- apparently the issue with doing so earlier was simply
that m_current can be anything at all when m_buffer8 is non-empty.
(JSC::Lexer<T>::lexWithoutClearingLineTerminator):
Clean up a few things in the vicinity of r245655:
- fix token enum values in a couple of error cases added in the last patch
- add UNLIKELY for existing error cases that forgot to use it
- simplify some control flow
- 11:04 AM Changeset in webkit [245696] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: clicking a source link should never open the Network tab
https://bugs.webkit.org/show_bug.cgi?id=197951
Reviewed by Timothy Hatcher.
The preview panel in the Network tab is really meant to be just that; a preview.
Opening resources in the preview panel is not a great experience, as the Network tab doesn't
have as much of the information one would expect when viewing a resource (namely the
Resource details sidebar panel).
Navigating within the Network tab also completely wipes out the current "state" of what
you're looking at (e.g. which panel), which could be unexpected.
The only way this could happen previously was if the Resources/Debugger/Sources tabs had
never been active at any point in the past. Selecting one of those tabs and then clicking on
an initiator link in the Network tab would re-select that other tab.
- UserInterface/Base/Main.js:
(WI.dialogWasDismissedWithRepresentedObject):
- UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
- 11:02 AM Changeset in webkit [245695] by
-
- 4 edits2 adds in trunk
[Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
https://bugs.webkit.org/show_bug.cgi?id=198177
Patch by Antoine Quint <Antoine Quint> on 2019-05-23
Reviewed by Dean Jackson.
Source/WebCore:
Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html
The Pointer Event spec, in https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "the mouseover,
mouseout, mouseenter, and mouseleave events are never prevented (even if the pointer is down)." We add a new static function which
indicates what is "compatibility" mouse event since those should be excluded, along with "click", which we already excluded.
- dom/Element.cpp:
(WebCore::isCompatibilityMouseEvent):
(WebCore::Element::dispatchMouseEvent):
LayoutTests:
Add a test that listens to all mouse events and checks which are dispatched in the case preventDefault() is called when handling
"pointerdown" and when it isn't.
- platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match.
- pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed-expected.txt: Added.
- pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html: Added.
- 10:59 AM Changeset in webkit [245694] by
-
- 2 edits in trunk/Source/WebCore
Update feature status for shipped features
https://bugs.webkit.org/show_bug.cgi?id=196783
Reviewed by Timothy Hatcher.
Updated feature status for Beacon API, CSS Text Decoration Level 4, Intersection Observer,
Conic Gradients, Datalist Element, and Web Share.
- features.json:
- 10:46 AM Changeset in webkit [245693] by
-
- 2 edits in trunk/LayoutTests
Add Mojave+ back to media/track/track-cue-rendering-vertical.html expectation
https://bugs.webkit.org/show_bug.cgi?id=136627
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:33 AM Changeset in webkit [245692] by
-
- 3 edits in trunk/Tools
generate-xcfilelists should not store temporary build files in /tmp
https://bugs.webkit.org/show_bug.cgi?id=198136
Reviewed by Jonathan Bedard.
Provide the build infrastructure control of the location of
generate-xcfilelists' temporary files by creating them in the build
directory when possible.
- Scripts/webkitpy/generate_xcfilelists_lib/application.py:
(get_xcode_project_temp_dir):
- Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
(BaseGenerator._generate_derived):
(BaseGenerator._generate_unified):
(BaseGenerator):
(BaseGenerator._get_temp_dir):
- 10:20 AM Changeset in webkit [245691] by
-
- 9 edits in trunk/Source/WebKit
Deprecate more preview API
https://bugs.webkit.org/show_bug.cgi?id=198152
Reviewed by Dean Jackson.
This is working towards <rdar://problem/51003503>
- UIProcess/API/Cocoa/WKPreviewActionItem.h:
- UIProcess/API/Cocoa/WKPreviewActionItem.mm:
- UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.h:
- UIProcess/API/Cocoa/WKPreviewActionItemInternal.h:
- UIProcess/API/Cocoa/WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/WKPreviewElementInfo.mm:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::activeTouchActions const):
- UIProcess/ios/WKContentViewInteraction.mm:
(previewIdentifierForElementAction):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemController:commitPreview:]):
- 10:01 AM Changeset in webkit [245690] by
-
- 3 edits2 adds in branches/safari-608.1.24.20-branch
Cherry-pick r245661. rdar://problem/50613388
REGRESSION(r245148): Removing inputmode="none" does not bring up software keyboard
https://bugs.webkit.org/show_bug.cgi?id=198141
Reviewed by Geoffrey Garen.
Source/WebKit:
r245148 changed _requiresKeyboardWhenFirstResponder to return NO when shouldShowAutomaticKeyboardUI
returns NO with regards to software keyboard. This introduced a regression that removing inputmode="none"
no longer brings up the software keyboard. Fixed the bug by making it return YES when inputmode="none"
is present on an editable element in shouldShowAutomaticKeyboardUI, partially restoring the old behavior.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView shouldShowAutomaticKeyboardUI]): (-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]): (-[WKContentView _requiresKeyboardWhenFirstResponder]):
LayoutTests:
Added a regression test.
- fast/forms/ios/inputmode-removing-none-expected.txt: Added.
- fast/forms/ios/inputmode-removing-none.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:00 AM Changeset in webkit [245689] by
-
- 3 edits1 add in branches/safari-608.1.24.20-branch
Cherry-pick r245622. rdar://problem/50754184
[JSC] ArrayBufferContents::tryAllocate signs the pointer with allocation size and authenticates it with sizeInBytes
https://bugs.webkit.org/show_bug.cgi?id=198101
Reviewed by Michael Saboff.
JSTests:
- stress/zero-sized-array-buffer-pointer-should-be-signed-with-zero.js: Added. (shouldBe):
Source/JavaScriptCore:
When we allocate 0-length ArrayBuffer, we allocate 1 byte storage instead because we would like to ensure that
non-neutered ArrayBuffer always have non nullptr. While we allocate a 1 byte storage, this ArrayBuffer says
sizeInBytes = 0. However, we accidentally configure the vector pointer with this 1 byte size in the constructor.
In ARM64E device, we sign the vector pointer with modifier = 1 (1 byte size), and later we authenticate this
pointer with modifier = 0 (sizeInBytes), and fail to authenticate the pointer.
In this patch, we sign the pointer with sizeInBytes so that we correctly authenticate the 0 bytes vector pointer.
- runtime/ArrayBuffer.cpp: (JSC::ArrayBufferContents::tryAllocate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:59 AM Changeset in webkit [245688] by
-
- 2 edits1 add in trunk/Source/WTF
[PlayStation] Implement platformUserPreferredLanguages.
https://bugs.webkit.org/show_bug.cgi?id=198149
Reviewed by Fujii Hironori.
- wtf/PlatformPlayStation.cmake:
- wtf/playstation/LanguagePlayStation.cpp: Added.
(WTF::platformUserPreferredLanguages):
- 9:53 AM Changeset in webkit [245687] by
-
- 3 edits in trunk/JSTests
[PlayStation] Skip additional tests on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=198145
Reviewed by Ross Kirsling.
- exceptionFuzz.yaml:
Add skip on hostOS playstation
- executableAllocationFuzz.yaml:
Add skip on hostOS playstation
- 9:44 AM Changeset in webkit [245686] by
-
- 6 edits in branches/safari-608.1.24.40-branch/Source/WebKit
Cherry-pick r245660. rdar://problem/50698533
REGRESSION (r240552): PDF contents are not exposed to Accessibility (VO, etc.)
https://bugs.webkit.org/show_bug.cgi?id=198146
<rdar://problem/50698533>
Reviewed by Simon Fraser.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::updateMockAccessibilityElementAfterCommittingLoad):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): (WebKit::WebPage::updateMockAccessibilityElementAfterCommittingLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: (-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]): (-[WKAccessibilityWebPageObjectBase setWebPage:]): (-[WKAccessibilityWebPageObjectBase setHasMainFramePlugin:]): In r240552, we changed to only defer to the main frame PluginView's accessibility tree if the cached "has a plugin" bit is true. That bit was only updated in WebPage::platformInitialize, which is long before we've actually loaded anything or have any clue if we're going to have a plugin.
Instead, push updates every time we commit a load, which coincides
with when we make other decisions based on having a plugin or not.
Also, just use the existence of a PluginDocument to make the decision,
instead of actually digging in to see if there's a PluginView, since
PluginView comes in asynchronously.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 AM Changeset in webkit [245685] by
-
- 7 edits in branches/safari-608.1.24.40-branch/Source
Versioning.
- 9:39 AM Changeset in webkit [245684] by
-
- 7 edits in branches/safari-608.1.24.20-branch/Source
Versioning.
- 9:36 AM Changeset in webkit [245683] by
-
- 7 edits in branches/safari-608.1.24.30-branch/Source
Versioning.
- 8:49 AM WebKitGTK/2.24.x edited by
- (diff)
- 8:48 AM Changeset in webkit [245682] by
-
- 5 edits2 copies1 add in trunk
Create scrolling tree nodes for descendants of position:absolute inside stacking-context overflow
https://bugs.webkit.org/show_bug.cgi?id=198154
Reviewed by Antti Koivisto.
Source/WebCore:
There exists code that creates scrolling tree nodes for position:absolute when the containing block
chain skips an enclosing scroller, but the compositing ancestor tree includes the scroller. However
this code explicitly checked that the layer was position:absolute.
This needed to be generalized for any layer whose containing block ancestor chain includes
a position:absolute that skips the scroller, for example a transformed inside a position:absolute,
so remove an explicit isAbsolutelyPositioned() check and some similar assertions.
Test: scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::collectStationaryLayerRelatedOverflowNodes):
(WebCore::RenderLayerCompositor::computeCoordinatedPositioningForLayer const):
(WebCore::collectRelatedCoordinatedScrollingNodes):
LayoutTests:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt: Copied from LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt.
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
- scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow-expected.txt: Copied from LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt.
- scrollingcoordinator/scrolling-tree/composited-in-absolute-in-stacking-context-overflow.html: Added.
- scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt:
- 8:47 AM Changeset in webkit [245681] by
-
- 7 edits in trunk/Source
Fix a few missing header inclusions often masked by by unified sources
https://bugs.webkit.org/show_bug.cgi?id=198180
Reviewed by Eric Carlson.
Source/JavaScriptCore:
- assembler/PerfLog.cpp: Add missing <array> header inclusion.
- wasm/WasmBinding.cpp: Add missing "WasmCallingConvention.h" inclusion.
Source/WebCore:
- editing/markup.h: Add missing "FloatSize.h" inclusion.
- html/FeaturePolicy.cpp: Add missing "HTMLParserIdioms.h" inclusion.
- platform/text/TextCodec.cpp: Add missing <cstdio> inclusion.
- 3:29 AM BuildingCairoOnWindows edited by
- (diff)
- 3:28 AM BuildingCairoOnWindows edited by
- (diff)
- 3:21 AM BuildingCairoOnWindows edited by
- (diff)
- 3:15 AM BuildingCairoOnWindows edited by
- (diff)
- 3:15 AM BuildingCairoOnWindows edited by
- (diff)
- 2:29 AM Changeset in webkit [245680] by
-
- 56 edits1 copy3 adds in trunk
[WHLSL] Implement property resolver
https://bugs.webkit.org/show_bug.cgi?id=195925
<rdar://problem/48219643>
Reviewed by Saam Barati and Robin Morisset.
Source/WebCore:
The property resolver is the thing that replaces dot expressions, index expressions, and
read-modify-write expressions with calls to getters, setters, and anders. This patch doesn't
fully implement the property resolver, but implements enough for simple dot expressions to
work. This is enough for us to be able to test most of the rest of the compiler. Index
expressions and read-modify-write expressions are not fully included in this patch, and will
be finished in a follow-up patch.
The property resolver may introduce anonymous variables in various places. In order to do
this, after the property resolver runs, it will insert all these anonymous variables in the
beginning of the function. However, this means that entries in the VariableDeclarations
vector will all shift, which means VariableDeclarations have to be allocated on the heap so
backreferences to them stay valid. This patch moves the storage associated with these values
to living directly in the vector's storage to living in heap storage (via filling the vector
with UniqueRefs).
This patch also adds the third concept of value-ness. We now have right values, left values,
and abstract left values (for things which have setters but have no address). This addition
is required for the analysis the property resolver performs. This concept is also present in
the spec.
Test: webgpu/whlsl-dot-expressions.html
- Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:
(WebCore::WHLSL::AST::TypeAnnotation::TypeAnnotation):
(WebCore::WHLSL::AST::TypeAnnotation::leftAddressSpace const):
(WebCore::WHLSL::AST::TypeAnnotation::isRightValue const):
(WebCore::WHLSL::AST::TypeAnnotation::visit):
- Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
(WebCore::WHLSL::AST::AssignmentExpression::takeRight):
- Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h:
- Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
(WebCore::WHLSL::AST::Expression::maybeResolvedType):
(WebCore::WHLSL::AST::Expression::resolvedType):
(WebCore::WHLSL::AST::Expression::maybeTypeAnnotation const):
(WebCore::WHLSL::AST::Expression::typeAnnotation const):
(WebCore::WHLSL::AST::Expression::setTypeAnnotation):
(WebCore::WHLSL::AST::Expression::addressSpace const): Deleted.
(WebCore::WHLSL::AST::Expression::setAddressSpace): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
(WebCore::WHLSL::AST::FloatLiteral::clone const):
- Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp:
(WebCore::WHLSL::AST::IntegerLiteral::valueForSelectedType const):
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
(WebCore::WHLSL::AST::IntegerLiteral::clone const):
- Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::MakeArrayReferenceExpression):
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::leftValue):
(WebCore::WHLSL::AST::MakeArrayReferenceExpression::lValue): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
(WebCore::WHLSL::AST::MakePointerExpression::MakePointerExpression):
(WebCore::WHLSL::AST::MakePointerExpression::leftValue):
(WebCore::WHLSL::AST::MakePointerExpression::lValue): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLNullLiteral.h:
(WebCore::WHLSL::AST::NullLiteral::clone const):
- Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleGetterOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleSetterOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleAnderOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::getterFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::anderFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::threadAnderFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::setterFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleGetterOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleAnderOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleSetterOverloads):
(WebCore::WHLSL::AST::PropertyAccessExpression::setGetterFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::setAnderFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::setThreadAnderFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::setSetterFunction):
(WebCore::WHLSL::AST::PropertyAccessExpression::takeBase):
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleGetOverloads): Deleted.
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleSetOverloads): Deleted.
(WebCore::WHLSL::AST::PropertyAccessExpression::possibleAndOverloads): Deleted.
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleGetOverloads): Deleted.
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleSetOverloads): Deleted.
(WebCore::WHLSL::AST::PropertyAccessExpression::setPossibleAndOverloads): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
(WebCore::WHLSL::AST::ReadModifyWriteExpression::oldVariableReference):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::newVariableReference):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::leftValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeLeftValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeOldValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeNewValue):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeNewValueExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::takeResultExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::ReadModifyWriteExpression):
(WebCore::WHLSL::AST::ReadModifyWriteExpression::lValue): Deleted.
- Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
(WebCore::WHLSL::AST::ResolvableType::maybeResolvedType const):
(WebCore::WHLSL::AST::ResolvableType::resolvedType const):
(WebCore::WHLSL::AST::ResolvableType::maybeResolvedType):
(WebCore::WHLSL::AST::ResolvableType::resolvedType):
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
(WebCore::WHLSL::AST::ResourceSemantic::isAcceptableType const):
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
(WebCore::WHLSL::AST::SpecializationConstantSemantic::isAcceptableType const):
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
(WebCore::WHLSL::AST::StageInOutSemantic::isAcceptableType const):
- Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
(WebCore::WHLSL::AST::StructureDefinition::find):
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
(WebCore::WHLSL::AST::TypeReference::maybeResolvedType const):
(WebCore::WHLSL::AST::TypeReference::resolvedType const):
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp:
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::valueForSelectedType const):
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
(WebCore::WHLSL::AST::UnsignedIntegerLiteral::clone const):
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
(WebCore::WHLSL::AST::VariableDeclarationsStatement::VariableDeclarationsStatement):
(WebCore::WHLSL::AST::VariableDeclarationsStatement::variableDeclarations):
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
(WebCore::WHLSL::Metal::attributeForSemantic):
(WebCore::WHLSL::Metal::EntryPointScaffolding::mangledInputPath):
(WebCore::WHLSL::Metal::EntryPointScaffolding::unpackResourcesAndNamedBuiltIns):
(WebCore::WHLSL::Metal::FragmentEntryPointScaffolding::helperTypes):
(WebCore::WHLSL::Metal::FragmentEntryPointScaffolding::unpack):
- Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
(WebCore::WHLSL::Metal::FunctionDeclarationWriter::visit):
(WebCore::WHLSL::Metal::FunctionDefinitionWriter::visit):
- Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:
(WebCore::WHLSL::Metal::writeNativeFunction):
- Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.cpp:
(WebCore::WHLSL::Metal::writeNativeType):
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
(WebCore::WHLSL::Metal::findInVector):
(WebCore::WHLSL::Metal::TypeNamer::visit):
(WebCore::WHLSL::Metal::TypeNamer::createNameNode):
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
(WebCore::WHLSL::ASTDumper::visit):
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
(WebCore::WHLSL::checkDuplicateFunctions):
- Modules/webgpu/WHLSL/WHLSLChecker.cpp:
(WebCore::WHLSL::resolveWithOperatorAnderIndexer):
(WebCore::WHLSL::resolveWithOperatorLength):
(WebCore::WHLSL::resolveWithReferenceComparator):
(WebCore::WHLSL::resolveByInstantiation):
(WebCore::WHLSL::checkOperatorOverload):
(WebCore::WHLSL::Checker::assignTypes):
(WebCore::WHLSL::commit):
(WebCore::WHLSL::Checker::visit):
(WebCore::WHLSL::Checker::recurseAndGetInfo):
(WebCore::WHLSL::Checker::getInfo):
(WebCore::WHLSL::Checker::assignType):
(WebCore::WHLSL::Checker::forwardType):
(WebCore::WHLSL::getUnnamedType):
(WebCore::WHLSL::Checker::finishVisitingPropertyAccess): Deleted.
(WebCore::WHLSL::Checker::recurseAndWrapBaseType): Deleted.
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
(WebCore::WHLSL::Gatherer::takeEntryPointItems):
(WebCore::WHLSL::Gatherer::visit):
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
(WebCore::WHLSL::matchAndCommit):
(WebCore::WHLSL::commit):
(WebCore::WHLSL::inferTypesForCall):
- Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:
(WebCore::WHLSL::getNativeTypeDeclaration):
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
(WebCore::WHLSL::NameResolver::visit):
- Modules/webgpu/WHLSL/WHLSLParser.cpp:
(WebCore::WHLSL::Parser::parseParameters):
(WebCore::WHLSL::Parser::parseVariableDeclarations):
- Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:
- Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
(WebCore::WHLSL::prepareShared):
- Modules/webgpu/WHLSL/WHLSLPrepare.h:
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp: Added.
(WebCore::WHLSL::PropertyResolver::visit):
(WebCore::WHLSL::setterCall):
(WebCore::WHLSL::getterCall):
(WebCore::WHLSL::modify):
(WebCore::WHLSL::PropertyResolver::simplifyRightValue):
(WebCore::WHLSL::LeftValueSimplifier::visit):
(WebCore::WHLSL::PropertyResolver::simplifyLeftValue):
(WebCore::WHLSL::resolveProperties):
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.h: Copied from Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h.
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
(WebCore::WHLSL::RecursiveTypeChecker::visit):
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
(WebCore::WHLSL::conversionCost):
- Modules/webgpu/WHLSL/WHLSLResolvingType.h:
(WebCore::WHLSL::ResolvingType::getUnnamedType):
- Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
- Modules/webgpu/WHLSL/WHLSLSynthesizeArrayOperatorLength.cpp:
(WebCore::WHLSL::FindArrayTypes::takeArrayTypes):
(WebCore::WHLSL::synthesizeArrayOperatorLength):
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
(WebCore::WHLSL::FindAllTypes::takeUnnamedTypes):
(WebCore::WHLSL::FindAllTypes::takeNamedTypes):
(WebCore::WHLSL::synthesizeConstructors):
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
(WebCore::WHLSL::synthesizeEnumerationFunctions):
- Modules/webgpu/WHLSL/WHLSLSynthesizeStructureAccessors.cpp:
(WebCore::WHLSL::synthesizeStructureAccessors):
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
(WebCore::WHLSL::Visitor::visit):
- Modules/webgpu/WHLSL/WHLSLVisitor.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::trySetWHLSLFunctionsForPipelineDescriptor):
LayoutTests:
- webgpu/whlsl-dot-expressions-expected.html: Added.
- webgpu/whlsl-dot-expressions.html: Added.
- 1:39 AM Changeset in webkit [245679] by
-
- 7 edits in trunk/Source/WebKit
[tvOS] Build broken by r245639
https://bugs.webkit.org/show_bug.cgi?id=198172
<rdar://problem/51048991>
Unreviewed build fix.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::touchWithIdentifierWasRemoved):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::touchWithIdentifierWasRemoved): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::touchWithIdentifierWasRemoved):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::touchWithIdentifierWasRemoved): Deleted.
- 1:01 AM WebKitGTK/2.24.x edited by
- (diff)
- 12:55 AM Changeset in webkit [245678] by
-
- 2 edits in trunk/Source/WebKit
[tvOS] Build broken by r245639
https://bugs.webkit.org/show_bug.cgi?id=198172
<rdar://problem/51048991>
Unreviewed build fix.
- WebProcess/WebPage/WebPage.messages.in:
- 12:41 AM Changeset in webkit [245677] by
-
- 2 edits in trunk/Tools
[JHBuild][GStreamer] Enable libsrtp
https://bugs.webkit.org/show_bug.cgi?id=198041
Patch by Philippe Normand <philn@igalia.com> on 2019-05-23
Reviewed by Xabier Rodriguez-Calvar.
- gstreamer/jhbuild.modules: Enable libsrtp. The system version
can't be used from Stretch because it's too old.
- 12:28 AM Changeset in webkit [245676] by
-
- 3 edits in trunk/Source/WebKit
[WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
https://bugs.webkit.org/show_bug.cgi?id=198125
Reviewed by Philippe Normand.
- UIProcess/glib/WebProcessPoolGLib.cpp: Guard the inclusion of GStreamerCommon.h with USE(GSTREAMER).
- WebProcess/glib/WebProcessGLib.cpp: Ditto.
- 12:06 AM Changeset in webkit [245675] by
-
- 6 edits3 adds in trunk
createListFromArrayLike should throw if value is not an object
https://bugs.webkit.org/show_bug.cgi?id=198138
Reviewed by Yusuke Suzuki.
JSTests:
- stress/create-list-from-array-like-not-object.js: Added.
(testValid):
(testInvalid):
- stress/proxy-get-own-property-names-should-not-clear-previous-results.js:
(opt):
- stress/proxy-proto-enumerator.js: Added.
(main):
- stress/proxy-proto-own-keys.js: Added.
(assert):
(ownKeys):
Source/JavaScriptCore:
According to the spec[1], createListFromArrayLike should throw a type error if the array-like value
passed in is not an object.
[1]: https://www.ecma-international.org/ecma-262/9.0/index.html#sec-createlistfromarraylike
- runtime/JSObjectInlines.h:
(JSC::createListFromArrayLike):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performGetOwnPropertyNames):
- runtime/ReflectObject.cpp:
(JSC::reflectObjectConstruct):
