Timeline
Jan 12, 2020:
- 11:33 PM Changeset in webkit [254422] by
-
- 2 edits in trunk/Source/WebKit
Remove CorePDF linkage in WebKit
https://bugs.webkit.org/show_bug.cgi?id=206103
<rdar://problem/58490563>
Reviewed by Wenson Hsieh.
- Configurations/WebKit.xcconfig:
- 7:40 PM Changeset in webkit [254421] by
-
- 7 edits in trunk
Text-indent with percentage value should resolve against the available width
https://bugs.webkit.org/show_bug.cgi?id=206155
<rdar://problem/58514882>
Reviewed by Antti Koivisto.
Source/WebCore:
https://www.w3.org/TR/css-text-3/#text-indent-property
"<percentage> Gives the amount of the indent as a percentage of the block container’s own logical width"
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset const):
LayoutTests:
- platform/mac/css1/text_properties/text_indent-expected.txt:
- platform/mac/css2.1/t1601-c547-indent-01-d-expected.txt:
- 7:12 PM Changeset in webkit [254420] by
-
- 19 edits in trunk
[JSC] Use internal object field mechanism to implement JSStringIterator
https://bugs.webkit.org/show_bug.cgi?id=206144
Reviewed by Ross Kirsling.
JSTests:
- stress/string-iterators.js:
- stress/tailCallForwardArguments.js:
(putFuncToPrivateName.createBuiltin):
(createTailCallForwardingFuncWith):
Source/JavaScriptCore:
This patch uses internal object field mechanism to implement JSStringIterator,
and we also put JSStringIterator into IsoSubspace.
- builtins/BuiltinNames.h:
- builtins/StringIteratorPrototype.js:
(next):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitIsStringIterator):
- bytecompiler/NodesCodegen.cpp:
(JSC::stringIteratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getStringIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putStringIteratorInternalField):
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):
- runtime/JSCast.h:
- runtime/JSStringIterator.cpp:
(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::clone):
(JSC::JSStringIterator::visitChildren):
(JSC::JSStringIterator::iteratedValue const): Deleted.
- runtime/JSStringIterator.h:
- runtime/JSType.cpp:
(WTF::printInternal):
- runtime/JSType.h:
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncIterator):
- runtime/VM.cpp:
- runtime/VM.h:
- 7:10 PM Changeset in webkit [254419] by
-
- 12 edits in trunk/Source/JavaScriptCore
[JSC] Remove IsDone from JSArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=206140
Reviewed by Keith Miller.
We can store
-1in Index field to represent whether the iterator is closed.
While this patch does not change the allocation size of JSArrayIterator, this style can
shrink the size of JSStringIterator when we implement it in the same style.
We also rename iterationKindKeyValue to iterationKindEntries.
- builtins/ArrayIteratorPrototype.js:
(globalPrivate.arrayIteratorNextHelper):
- builtins/MapIteratorPrototype.js:
(globalPrivate.mapIteratorNext):
- builtins/MapPrototype.js:
(entries):
- builtins/SetIteratorPrototype.js:
(globalPrivate.setIteratorNext):
- builtins/SetPrototype.js:
(entries):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::arrayIteratorInternalFieldIndex):
- inspector/JSInjectedScriptHost.cpp:
(Inspector::cloneArrayIteratorObject):
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::finishCreation):
- runtime/JSArrayIterator.h:
- 5:18 PM Changeset in webkit [254418] by
-
- 13 edits in trunk/Source/JavaScriptCore
[JSC] Consistently use "var" in builtin JS
https://bugs.webkit.org/show_bug.cgi?id=206157
Reviewed by Mark Lam.
let / const requires additional bytecode to make it Empty initialized for now.
For builtin JS, we would like to keep it as efficient and compact as we can
so we should usevarconsistently.
- builtins/ArrayPrototype.js:
(sort.stringComparator):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort.merge):
(sort.mergeSort):
(sort.bucketSort):
(sort.comparatorSort):
(sort.stringSort):
(sort):
(globalPrivate.concatSlowPath):
(concat):
- builtins/FunctionPrototype.js:
(call):
(overriddenName.string_appeared_here.symbolHasInstance):
- builtins/GlobalOperations.js:
(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):
- builtins/IteratorHelpers.js:
(performIteration):
- builtins/ModuleLoader.js:
(async loadModule):
(async loadAndEvaluateModule):
(async requestImportModule):
(dependencyKeysIfEvaluated):
- builtins/ObjectConstructor.js:
(fromEntries):
- builtins/PromisePrototype.js:
(finally):
(valueThunk):
(globalPrivate.getThenFinally):
(thrower):
(globalPrivate.getCatchFinally):
(const.valueThunk): Deleted.
(const.thrower): Deleted.
- builtins/RegExpPrototype.js:
(globalPrivate.advanceStringIndex):
(globalPrivate.regExpExec):
(globalPrivate.hasObservableSideEffectsForRegExpMatch):
(globalPrivate.matchSlow):
(overriddenName.string_appeared_here.match):
(overriddenName.string_appeared_here.matchAll):
(getSubstitution):
(overriddenName.string_appeared_here.replace):
(overriddenName.string_appeared_here.search):
(globalPrivate.hasObservableSideEffectsForRegExpSplit):
(overriddenName.string_appeared_here.split):
(intrinsic.RegExpTestIntrinsic.test):
- builtins/RegExpStringIteratorPrototype.js:
(next):
- builtins/StringPrototype.js:
(match):
(matchAll):
(globalPrivate.hasObservableSideEffectsForStringReplace):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(globalPrivate.createHTML):
- builtins/TypedArrayConstructor.js:
(of):
(from):
- builtins/TypedArrayPrototype.js:
(globalPrivate.typedArraySpeciesConstructor):
(globalPrivate.typedArrayClampArgumentToStartOrEnd):
(fill):
(find):
(subarray):
- 4:21 PM Changeset in webkit [254417] by
-
- 4 edits1 copy in trunk/Source/WTF
Platform.h is out of control Part 2: Split WTF_OS_* macro definitions out of Platform.h and into a new OS.h
https://bugs.webkit.org/show_bug.cgi?id=206138
Reviewed by Anders Carlsson.
As a another step towards cleaning up Platform.h, split out OS related
macros into their own file.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/OS.h: Copied from Source/WTF/wtf/Platform.h.
- wtf/Platform.h:
- 2:42 PM Changeset in webkit [254416] by
-
- 6 edits in trunk/Source
[WebCore] Reorganize JSType in WebCore to offer more bits to JSC
https://bugs.webkit.org/show_bug.cgi?id=206141
Reviewed by Keith Miller.
Source/JavaScriptCore:
- runtime/JSType.h:
Source/WebCore:
This patch reorganize JSType a bit to offer more bits to JSC. Then JSC can use JSType for types easily.
- bindings/js/JSDOMWrapper.h:
- bindings/js/JSElementCustom.h:
(JSC::JSCastingHelpers::InheritsTraits<WebCore::JSElement>::inherits):
- domjit/DOMJITHelpers.h:
(WebCore::DOMJIT::branchIfElement):
(WebCore::DOMJIT::branchIfNotElement):
- 1:30 PM Changeset in webkit [254415] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Make iOS bots green until they can be updated.
Unreviewed.
- platform/ios/TestExpectations:
- 11:10 AM Changeset in webkit [254414] by
-
- 5 edits in trunk/Source/WebCore
Remove unneeded MemoryIDBBackingStore::create
https://bugs.webkit.org/show_bug.cgi?id=205512
Reviewed by Youenn Fablet.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createBackingStore): Call makeUnique
instead of MemoryIDBBackingStore::create.
- Modules/indexeddb/server/MemoryCursor.cpp: Removed unneeded include
of MemoryIDBBackingStore.h.
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Fixed a comment
and replaced a global variable with a constant.
(WebCore::IDBServer::MemoryIDBBackingStore::create): Deleted.
- Modules/indexeddb/server/MemoryIDBBackingStore.h: Made the class
final, made more of the member functions private, and moved a couple
function members out from in between the data members.
Jan 11, 2020:
- 11:44 PM Changeset in webkit [254413] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Unreviewed.
Fix build.
- wtf/cocoa/LanguageCocoa.mm:
(WTF::canMinimizeLanguages):
- 11:16 PM Changeset in webkit [254412] by
-
- 22 edits in trunk
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Unreviewed.
Addressing additional review comments.
Source/WTF:
- wtf/cocoa/LanguageCocoa.mm:
(WTF::canMinimizeLanguages):
LayoutTests:
- fast/text/international/system-language/navigator-language/navigator-language-en-GB.html:
- fast/text/international/system-language/navigator-language/navigator-language-en-US.html:
- fast/text/international/system-language/navigator-language/navigator-language-en.html:
- fast/text/international/system-language/navigator-language/navigator-language-es-419.html:
- fast/text/international/system-language/navigator-language/navigator-language-es-ES.html:
- fast/text/international/system-language/navigator-language/navigator-language-es-MX.html:
- fast/text/international/system-language/navigator-language/navigator-language-es.html:
- fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html:
- fast/text/international/system-language/navigator-language/navigator-language-fr.html:
- fast/text/international/system-language/navigator-language/navigator-language-hi.html:
- fast/text/international/system-language/navigator-language/navigator-language-ja.html:
- fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html:
- fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html:
- fast/text/international/system-language/navigator-language/navigator-language-ru.html:
- fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html:
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html:
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html:
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html:
- fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html:
- 10:57 PM Changeset in webkit [254411] by
-
- 2 edits in trunk/Source/WTF
Fix internal Apple builds after r254389
https://bugs.webkit.org/show_bug.cgi?id=206135
Rubber stamped by Zalan Bujtas.
- wtf/spi/cocoa/NSLocaleSPI.h:
- 8:21 PM Changeset in webkit [254410] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Introduce the concept of independent formatting context
https://bugs.webkit.org/show_bug.cgi?id=206137
<rdar://problem/58508015>
Reviewed by Sam Weinig.
At this point it is just about absolute positioned block level boxes since we don't support the "contain" property.
https://www.w3.org/TR/css-display-3/#independent-formatting-context
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::establishesFormattingContext const):
(WebCore::Layout::Box::establishesIndependentFormattingContext const):
- layout/layouttree/LayoutBox.h:
- 5:46 PM Changeset in webkit [254409] by
-
- 23 edits in trunk
Expose frame information on _WKResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=206104
<rdar://problem/57132290>
Reviewed by Dean Jackson.
Source/WebCore:
Covered by API tests.
- page/FrameIdentifier.h:
(WebCore::frameIdentifierFromID): Deleted.
Source/WebKit:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
- NetworkProcess/NetworkResourceLoadParameters.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::resourceLoadInfo):
- Shared/API/Cocoa/_WKFrameHandle.h:
- Shared/API/Cocoa/_WKFrameHandle.mm:
(-[_WKFrameHandle frameID]):
(-[_WKFrameHandle initWithCoder:]):
(-[_WKFrameHandle encodeWithCoder:]):
(-[_WKFrameHandle _frameID]): Deleted.
- Shared/API/Cocoa/_WKFrameHandleInternal.h:
- Shared/ResourceLoadInfo.h:
(WebKit::ResourceLoadInfo::encode const):
(WebKit::ResourceLoadInfo::decode):
- UIProcess/API/APIResourceLoadInfo.h:
- UIProcess/API/Cocoa/_WKInspector.mm:
(-[_WKInspector showMainResourceForFrame:]):
- UIProcess/API/Cocoa/_WKResourceLoadInfo.h:
- UIProcess/API/Cocoa/_WKResourceLoadInfo.mm:
(-[_WKResourceLoadInfo frame]):
(-[_WKResourceLoadInfo parentFrame]):
- UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _canChangeFrameLayout:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):
- UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:
(-[WKReloadFrameErrorRecoveryAttempter attemptRecovery]):
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _wk_pageCountForPrintFormatter:]):
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::evaluateJavaScriptCallback):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]):
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::addParametersFromFrame):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(TEST):
- 5:25 PM Changeset in webkit [254408] by
-
- 8 edits in trunk
[WebCore] Fix crash in module loader due to change in fragment reservation
https://bugs.webkit.org/show_bug.cgi?id=206125
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url-expected.txt:
Source/WebCore:
At some point, CachedResource::url() starts returning URL without fragment.
However, this was invariant in ScriptModuleLoader, so one of WPT test is crashing.
We save source URL so that we preserve fragment information.
Still we need to have fragment information after the redirect to fix a bug filed in [1].
[1]: https://bugs.webkit.org/show_bug.cgi?id=205294
- bindings/js/CachedModuleScriptLoader.cpp:
(WebCore::CachedModuleScriptLoader::load):
- bindings/js/CachedModuleScriptLoader.h:
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::notifyFinished):
LayoutTests:
- 4:49 PM Changeset in webkit [254407] by
-
- 2 edits in trunk/Source/WebCore
[LFC] isOkToAccessDisplayBox should return false on formatting context root access.
https://bugs.webkit.org/show_bug.cgi?id=206123
<rdar://problem/58500267>
Reviewed by Antti Koivisto.
From now on any geometry access outside of the formatting context without a valid reason is considered an escape.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- 4:29 PM Changeset in webkit [254406] by
-
- 7 edits2 adds in trunk
Support image-set() standard syntax
https://bugs.webkit.org/show_bug.cgi?id=160934
<rdar://problem/27891501>
Patch by Noam Rosenthal <Noam Rosenthal> on 2020-01-11
Source/WebCore:
Reviewed by Simon Fraser.
Inside image-set, image URLs can use regular quotes, not necessarily with url().
See https://drafts.csswg.org/css-images-4/#image-set-notation
Test: fast/hidpi/image-set-as-background-quotes.html
- css/parser/CSSPropertyParserHelpers.cpp:
Update CSS parser to allow raw strings as URLs inside image-set.
(WebCore::CSSPropertyParserHelpers::consumeUrlOrStringAsStringView):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):
LayoutTests:
Reviewed by Dean Jackson.
- fast/css/image-set-parsing-invalid.html:
- fast/css/image-set-parsing.html:
Update parsing to include raw strings
- fast/hidpi/image-set-as-background-quotes-expected.html: Added.
- fast/hidpi/image-set-as-background-quotes.html: Added.
Added ref-test for image-set without url().
- 4:16 PM Changeset in webkit [254405] by
-
- 3 edits in trunk/Source/WebCore
[LFC] BlockFormattingContext::verticalPositionWithMargin should take VerticalConstraints
https://bugs.webkit.org/show_bug.cgi?id=206122
<rdar://problem/58500207>
Reviewed by Antti Koivisto.
This prevents verticalPositionWithMargin from reading geometry outside of the formatting context.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):
- layout/blockformatting/BlockFormattingContext.h:
- 4:05 PM Changeset in webkit [254404] by
-
- 3 edits in trunk/Source/WebCore
[LFC][BFC] BlockFormattingContext::computeEstimatedVerticalPositionForAncestors should take ConstraintsPair<HorizontalConstraints>
https://bugs.webkit.org/show_bug.cgi?id=206121
<rdar://problem/58499492>
Reviewed by Antti Koivisto.
This prevents computeEstimatedVerticalPositionForAncestors from reading geometry outside of the formatting context.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForAncestors):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFormattingRoot):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPositionForFloatClear):
- layout/blockformatting/BlockFormattingContext.h:
- 4:03 PM Changeset in webkit [254403] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Introduce BlockFormattingContext::ConstraintsPair
https://bugs.webkit.org/show_bug.cgi?id=206119
<rdar://problem/58498745>
Reviewed by Antti Koivisto.
This is in preparation for passing rootHorizontalConstraints all the way to BlockFormattingContext::computeEstimatedVerticalPosition().
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::ConstraintsPair<T>::ConstraintsPair):
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::ConstraintsPair::operator* const):
(WebCore::Layout::BlockFormattingContext::ConstraintsPair::root const):
- 3:47 PM Changeset in webkit [254402] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] Visually collapse hanging pre-wrap content.
https://bugs.webkit.org/show_bug.cgi?id=206133
<rdar://problem/58505750>
Reviewed by Antti Koivisto.
This change is to comply with other rendering engines when it comes to visually collapsing hanging pre-wrap content.
https://www.w3.org/TR/css-text-3/#white-space-phase-2
"If white-space is set to pre-wrap, the UA must (unconditionally) hang this sequence, unless the sequence
is followed by a forced line break, in which case it must conditionally hang the sequence is instead.
It _may_ also visually collapse the character advance widths of any that would otherwise overflow."
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::visuallyCollapsePreWrapOverflowContent):
- layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::InlineItemRun::adjustLogicalWidth):
- 10:07 AM Changeset in webkit [254401] by
-
- 4 edits1 copy in trunk/Source/WTF
Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
https://bugs.webkit.org/show_bug.cgi?id=206124
Reviewed by Anders Carlsson.
As a step towards cleaning up Platform.h, split out CPU related
macros into their own file.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/CPU.h: Copied from Source/WTF/wtf/Platform.h.
- wtf/Platform.h:
- 9:42 AM Changeset in webkit [254400] by
-
- 9 edits in trunk
[WebGL] Clarify USE_OPENGL_ES_3
https://bugs.webkit.org/show_bug.cgi?id=206081
<rdar://problem/58486798>
Reviewed by Simon Fraser.
Make it clear that USE_ANGLE | USE_OPENGL | USE_OPENGL_ES are exclusive,
and that the availability of OpenGL ES 3 is a separate query.
.:
- Source/cmake/OptionsFTW.cmake:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/OptionsWinCairo.cmake:
Source/WebCore:
- platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
Source/WTF:
- wtf/Platform.h:
- 9:31 AM Changeset in webkit [254399] by
-
- 13 edits2 deletes in trunk/LayoutTests
Import WPT test cases for 2dcontext/imagebitmap
https://bugs.webkit.org/show_bug.cgi?id=205908
Reviewed by Manuel Rego Casasnovas
LayoutTests/imported/w3c:
- web-platform-tests/2dcontext/imagebitmap/canvas-createImageBitmap-video-resize-expected.txt:
- web-platform-tests/2dcontext/imagebitmap/canvas-createImageBitmap-video-resize.html:
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html:
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html:
- web-platform-tests/2dcontext/imagebitmap/no-coop-coep.https.window.html: Removed.
- web-platform-tests/2dcontext/imagebitmap/no-coop-coep.https.window.js: Removed.
- web-platform-tests/2dcontext/imagebitmap/w3c-import.log:
LayoutTests:
Update the expected files.
- platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer-expected.txt:
- 9:02 AM Changeset in webkit [254398] by
-
- 3 edits in trunk/LayoutTests
[LFC][Integration] fast/text/simple-lines-float.html should be about simple line layout only
https://bugs.webkit.org/show_bug.cgi?id=206129
Reviewed by Zalan Bujtas.
Explicitly disable LFC in this SLL feature test.
- fast/text/simple-lines-float-expected.html:
- fast/text/simple-lines-float.html:
- 6:57 AM Changeset in webkit [254397] by
-
- 11 edits in trunk
Add correct grandfathering functionality to the ITP database backend
https://bugs.webkit.org/show_bug.cgi?id=205844
<rdar://problem/58360450>
Reviewed by John Wilander.
Source/WebKit:
This patch adds functionality for grandfathering statistics upon
creation of a new ITP database file. The memory store relies on
the presence of the ITP plist to indicate whether the data should
be grandfathered. Since the database does not use a plist, this patch
adds a boolean variable to track whether the database file previously
existed or not to indicate when to grandfather.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::openITPDatabase):
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
The boolean variable m_isNewResourceLoadStatisticDatabaseFile is set
to true if the database file did not previously exist, indicating ITP
is being used for the first time and data should be grandfathered.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::populateMemoryStoreFromDisk):
This is where the grandfathering happens. The call to logTestingEvent
is for API testing purposes only.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
If a scheduleClearInMemoryAndPersistent is called, the plist is
deleted, and data will be grandfathered upon recreation. To mimic
this, the ITP database store is cleared and becomes "new" again, so
the boolean is set to true.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIsITPDatabaseEnabled):
(WKPreferencesGetIsITPDatabaseEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _isITPDatabaseEnabled]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
In order to properly run the grandfathering
API tests, the 'isITPDatabaseEnabled' boolean needs to be exposed from
Web Preferences.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
The API tests rely on the ITP database flag being set correctly. Since
being on-by-default, the ITP database flag does not show up in the
user defaults menu if enabled. This patch fixes this by first checking
to see if the value is in the defaults menu, otherwise returning the
default preferences value. This ensures the preferences value matches
the actual store being initialized.
Tools:
In order to test both the ITP database and memory stores, this patch
had to restructure the grandfathering API tests.
If the test is for the database backend (ends in *Database), it will
check if the default store matches. If so, it continues on with the
normal test. If not, it has to use an API call to reconstruct the
new store and ensure the grandfathering still happens. Vice versa for
the memory store tests.
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(isITPDatabaseEnabled):
(TEST):
- 12:27 AM Changeset in webkit [254396] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, suppress warnings in GCC, part 2
https://bugs.webkit.org/show_bug.cgi?id=202832
- bytecode/ArithProfile.h:
- 12:18 AM Changeset in webkit [254395] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, suppress warnings in GCC
https://bugs.webkit.org/show_bug.cgi?id=202832
- bytecode/ArithProfile.h:
- 12:07 AM Changeset in webkit [254394] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix RunLoopGeneric's RunLoop::cycle
- wtf/generic/RunLoopGeneric.cpp:
(WTF::RunLoop::cycle):
Jan 10, 2020:
- 10:54 PM Changeset in webkit [254393] by
-
- 3 edits1 add in trunk
[JSC] Flush old tables in End phase
https://bugs.webkit.org/show_bug.cgi?id=206120
<rdar://problem/58039989>
Reviewed by Mark Lam.
JSTests:
- stress/create-many-realms.js: Added.
(foo):
Source/JavaScriptCore:
stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.
- heap/Heap.cpp:
(JSC::Heap::runEndPhase):
(JSC::Heap::stopThePeriphery):
- 9:32 PM Changeset in webkit [254392] by
-
- 23 edits in trunk
[Media in GPU process] Extend the GPU process sandbox to allow access to local files when necessary
https://bugs.webkit.org/show_bug.cgi?id=205967
<rdar://problem/58425020>
Reviewed by youenn fablet.
Source/WebKit:
No new tests, un-skipped existing tests that pass because of this change.
The GPU process sandbox does not allow access to local files so extend it before
attempting to open a file:// url, and revoke the extension when the file is closed.
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::load):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
- GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::invalidate):
(WebKit::RemoteMediaPlayerProxy::load):
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::openGPUProcessConnection):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebProcessProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.h:
(WebKit::GPUProcessConnection::setAuditToken):
(WebKit::GPUProcessConnection::auditToken const):
- WebProcess/GPU/GPUProcessConnectionInfo.h:
(WebKit::GPUProcessConnectionInfo::encode const):
(WebKit::GPUProcessConnectionInfo::decode):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):
(WebKit::MediaPlayerPrivateRemote::cancelLoad):
(WebKit::MediaPlayerPrivateRemote::prepareToPlay):
(WebKit::MediaPlayerPrivateRemote::play):
(WebKit::MediaPlayerPrivateRemote::pause):
(WebKit::MediaPlayerPrivateRemote::setPreservesPitch):
(WebKit::MediaPlayerPrivateRemote::setVolumeDouble):
(WebKit::MediaPlayerPrivateRemote::setMuted):
(WebKit::MediaPlayerPrivateRemote::setPreload):
(WebKit::MediaPlayerPrivateRemote::setPrivateBrowsingMode):
(WebKit::MediaPlayerPrivateRemote::seek):
(WebKit::MediaPlayerPrivateRemote::seekWithTolerance):
(WebKit::MediaPlayerPrivateRemote::prepareForRendering):
(WebKit::MediaPlayerPrivateRemote::setSize):
(WebKit::MediaPlayerPrivateRemote::setVisible):
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenGravity):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::setShouldDisableSleep):
(WebKit::MediaPlayerPrivateRemote::requestResource):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp:
(WebKit::RemoteMediaPlayerMIMETypeCache::canDecodeExtendedType):
(WebKit::RemoteMediaPlayerMIMETypeCache::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerMIMETypeCache::initializeCache):
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::deleteRemoteMediaPlayer):
(WebKit::RemoteMediaPlayerManager::getSupportedTypes):
(WebKit::RemoteMediaPlayerManager::originsInMediaCache):
(WebKit::RemoteMediaPlayerManager::clearMediaCache):
(WebKit::RemoteMediaPlayerManager::clearMediaCacheForOrigins):
(WebKit::RemoteMediaPlayerManager::gpuProcessConnection const):
- WebProcess/GPU/media/RemoteMediaPlayerManager.h:
(WebKit::RemoteMediaPlayerManager::parentProcess const):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureGPUProcessConnection):
LayoutTests:
- gpu-process/TestExpectations:
- 8:57 PM Changeset in webkit [254391] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Temporarily mark the navigator-language tests as flakey until I can figure out what to do with them.
Unreviewed.
- platform/mac/TestExpectations:
- 7:17 PM Changeset in webkit [254390] by
-
- 4 edits in trunk
Object.keys should throw if called on module namespace object with uninitialized binding
https://bugs.webkit.org/show_bug.cgi?id=205983
Reviewed by Yusuke Suzuki.
JSTests:
- test262/expectations.yaml: Mark 2 test cases as passing.
Source/JavaScriptCore:
If JSModuleNamespaceObject::getOwnPropertyNames method is called by
Object.keys or for/in loop, it should invoke GetOwnProperty? on
every binding so a ReferenceError is thrown if the binding is uninitialized.
Complete call stack of internal methods and abstract ops is in "info" meta of
JSTests/test262/test/language/module-code/namespace/internals/object-keys-binding-uninit.js
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertyNames):
- 7:05 PM Changeset in webkit [254389] by
-
- 11 edits41 adds1 delete in trunk
REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Source/WTF:
<rdar://problem/44119496>
Reviewed by Dean Jackson.
We ask the system for the current locale using CFLocaleCopyPreferredLanguages(), and then round-trip
it through CFBundleGetLocalizationInfoForLocalization() / CFBundleCopyLocalizationForLocalizationInfo().
This was to work around the fact that CFLocaleCopyPreferredLanguages() previously didn't report BCP47
language codes. However, that round-tripping was introducing errors, such as "zh-Hant-HK" was getting
turned into "zh-Hant-TW" which is clearly wrong. The CFBundle functions were never supposed to be used
in this way.
Instead, we can use CFLocaleCreateCanonicalLanguageIdentifierFromString() which is intended to
canonicalize locale identifiers, and does return BCP47 language codes. However, this function preserves
more fingerprinting entropy than the old code path, so we pass the input through new NSLocale SPI to
minimize the entropy revealed.
- WTF.xcodeproj/project.pbxproj:
- wtf/Language.h:
- wtf/Platform.h:
- wtf/PlatformMac.cmake:
- wtf/cf/LanguageCF.cpp:
(WTF::httpStyleLanguageCode):
(WTF::platformUserPreferredLanguages):
- wtf/cocoa/LanguageCocoa.mm: Added.
(WTF::minimizedLanguagesFromLanguages):
- wtf/spi/cocoa/NSLocaleSPI.h: Added.
Tools:
Reviewed by Dean Jackson.
Migrate system language tests to LayoutTests, to match the rest of our system language tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Removed.
LayoutTests:
<rdar://problem/44119496>
Reviewed by Dean Jackson.
Migrate and update tests from TestWebKitAPI to LayoutTests, to match the rest of our system language tests.
- platform/mac/TestExpectations: Mark these tests as possibly failing on older versions of macOS.
- fast/text/international/system-language/navigator-language/navigator-language-en-GB-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-en-US.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-en.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-419.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-ES.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-MX.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-es.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-fr-CA-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-fr.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-hi.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-ja.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-pt-PT-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-ru.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hans-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-TW-expected.txt: Added.
- fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html: Added.
- js/dom/navigator-language-expected.txt:
- 6:49 PM Changeset in webkit [254388] by
-
- 3 edits in trunk/Source/WebCore
[LFC] TableFormattingContext::layoutTableCellBox should take HorizontalConstraints
https://bugs.webkit.org/show_bug.cgi?id=206075
<rdar://problem/58483791>
Reviewed by Antti Koivisto.
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
- layout/tableformatting/TableFormattingContext.h:
- 6:32 PM Changeset in webkit [254387] by
-
- 10 edits1 add in trunk
[iOS] Audio from non-frontmost tab continues when app is backgrounded
https://bugs.webkit.org/show_bug.cgi?id=206101
<rdar://problem/58089916>
Reviewed by Eric Carlson.
Source/WebKit:
Tests: WKWebViewPausePlayingAudioTests.InWindow
WKWebViewPausePlayingAudioTests.OutOfWindow
The ApplicationStateTracker will only send notifications about application state to
WebPageProxies when those proxies' views are actually in-window. Add a separate application
state observer strictly for media which fires only when application state notifications are
received while the view is not in-window.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView _applicationDidEnterBackground:]):
(-[WKContentView _applicationWillEnterForeground:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidEnterBackgroundForMedia):
(WebKit::WebPageProxy::applicationWillEnterForegroundForMedia):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationDidEnterBackgroundForMedia):
(WebKit::WebPage::applicationWillEnterForegroundForMedia):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm: Added.
(TestWebKitAPI::autoplayingConfiguration):
(TestWebKitAPI::TEST):
- 5:52 PM Changeset in webkit [254386] by
-
- 3 edits in trunk/LayoutTests
Make http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins* use resource/util.js
https://bugs.webkit.org/show_bug.cgi?id=206100
<rdar://problem/58492335>
Unreviewed test gardening.
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins-database.html:
- http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins.html:
These two tests now use setEnableFeature() in resources/util.js which makes sure
testRunner.setStatisticsNotifyPagesWhenDataRecordsWereScanned() is called with
false before ending the test.
- 5:29 PM Changeset in webkit [254385] by
-
- 2 edits in trunk/LayoutTests
3 editing/spelling test failures on Mojave Release WK1
https://bugs.webkit.org/show_bug.cgi?id=206071
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Update test expectations to disable failing tests.
- 5:27 PM Changeset in webkit [254384] by
-
- 16 edits in trunk/Source
Introduce ENABLE_META_VIEWPORT and use it in some WK2 code
https://bugs.webkit.org/show_bug.cgi?id=206091
Reviewed by Tim Horton.
Source/WebCore:
didDispatchViewportPropertiesChanged() is used for a Coordinated Graphics assertion, so
should be #if ASSERT_ENABLED rather than #ifndef NDEBUG.
- dom/Document.cpp:
(WebCore::Document::updateViewportArguments):
(WebCore::Document::suspend):
- dom/Document.h:
Source/WebKit:
Use ENABLE(META_VIEWPORT) rather than PLATFORM(IOS_FAMILY) to enable various
bits of viewport-related code.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ViewportArguments>::decode):
(IPC::ArgumentCoder<ViewportAttributes>::encode):
(IPC::ArgumentCoder<ViewportAttributes>::decode):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetIgnoresViewportScaleLimits):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::viewportConfiguration const):
Source/WTF:
Define ENABLE_META_VIEWPORT for iOS.
- wtf/FeatureDefines.h:
- 5:06 PM Changeset in webkit [254383] by
-
- 6 edits in trunk
Python3: Support Source/WebKit/Scripts/webkit
https://bugs.webkit.org/show_bug.cgi?id=206078
Reviewed by Stephanie Lewis.
Source/WebKit:
Covered by existing unit tests.
- Scripts/webkit/LegacyMessages-expected.h: Sort forward declarations.
- Scripts/webkit/Messages-expected.h: Ditto.
- Scripts/webkit/messages.py: Sort printed outputs.
Tools:
- Scripts/test-webkitpy-python3: Call test-webkitpy with Python 3 since
everything is now compatible.
- 4:48 PM Changeset in webkit [254382] by
-
- 3 edits in trunk/Tools
webkit-patch crashes when creating new bug with Python 3
https://bugs.webkit.org/show_bug.cgi?id=205911
Reviewed by Stephanie Lewis.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.is_invalid_bugzilla_email): Decode page before applying regex.
(Bugzilla.authenticate): Decode group before printing.
(Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Ensure HTML response
Is a string before applying the regex.
(Bugzilla._check_create_bug_response): Ditto.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Attachment ID should be a string,
not a byte array.
- 4:45 PM Changeset in webkit [254381] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Remove reporting for some well-understood sandbox rules
https://bugs.webkit.org/show_bug.cgi?id=206111
Reviewed by Per Arne Vollan.
Remove sandbox rules designed to generate reporting about resource use for some well-understood
items that are frequently hit in WebKit use.
No new tests. No change in behavior.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 4:32 PM Changeset in webkit [254380] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Add missing escape reason to BlockFormattingContext::Quirks::stretchedInFlowHeight
https://bugs.webkit.org/show_bug.cgi?id=206076
<rdar://problem/58483919>
Reviewed by Antti Koivisto.
This is also a valid formatting context escape.
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- 4:21 PM Changeset in webkit [254379] by
-
- 5 edits in trunk
[iOS] Remove used media-related mach services from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206089
<rdar://problem/58489478>
Reviewed by Per Arne Vollan.
After conducting multiple test passes and large-scale living-on testing with telemetry, we have
confirmed that the following XPC services are not used by the media logic in WebKit, and can be
removed:
com.apple.coremedia.cpeprotector.xpc
com.apple.coremedia.figcontentkeysession.xpc
com.apple.coremedia.routingsessionmanager.xpc
com.apple.coremedia.sts
Source/WebKit:
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 4:13 PM Changeset in webkit [254378] by
-
- 7 edits2 adds in trunk
[LFC][Integration] Update style for layout boxes
https://bugs.webkit.org/show_bug.cgi?id=206074
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: fast/css/simple-color-change.html
For simple style changes we may keep the existing layout boxes. In this case we need to update the style.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateStyle):
Update style in layout boxes.
(WebCore::LayoutIntegration::LineLayout::rootLayoutBox):
- layout/integration/LayoutIntegrationLineLayout.h:
Make root non-const.
- layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::nextSibling):
- layout/layouttree/LayoutContainer.h:
Expose non-const accessors.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::styleDidChange):
Invoke LineLayout::updateStyle
LayoutTests:
- fast/css/simple-color-change-expected.html: Added.
- fast/css/simple-color-change.html: Added.
- 4:01 PM Changeset in webkit [254377] by
-
- 1 copy in tags/Safari-608.5.11
Tag Safari-608.5.11.
- 4:00 PM Changeset in webkit [254376] by
-
- 5 edits in trunk
[iOS] Remove 'com.apple.awdd' from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206095
<rdar://problem/56871147>
Reviewed by Per Arne Vollan.
We no longer need access to 'com.apple.awdd' in the iOS WebContent sandbox. We should remove
it from the sandbox.
Source/WebKit:
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 3:59 PM Changeset in webkit [254375] by
-
- 1 copy in tags/Safari-608.5.7.3.2
Tag Safari-608.5.7.3.2.
- 3:48 PM Changeset in webkit [254374] by
-
- 2 edits in trunk/Source/WebCore
Resource Load Statistics: Align WebCore::NetworkStorageSession's m_thirdPartyCookieBlockingMode init value with r254239
https://bugs.webkit.org/show_bug.cgi?id=206082
<rdar://problem/58487498>
Unreviewed minor, follow-up fix.
- platform/network/NetworkStorageSession.h:
The init value of m_thirdPartyCookieBlockingMode was changed to
ThirdPartyCookieBlockingMode::All to align it with r254239.
- 3:39 PM Changeset in webkit [254373] by
-
- 17 edits4 adds in trunk
Map CSS value ID to system color in the UI process
https://bugs.webkit.org/show_bug.cgi?id=204314
Reviewed by Dean Jackson.
Source/WebCore:
Currently, RenderThemeIOS is mapping CSS value IDs to system colors in the WebContent process. This mapping leads to
invoking selectors on UITraitCollection and UIColor, which will send messages to the runningboard daemon. Since we
will be blocking access to this daemon in the WebContent process, this mapping should be moved to the UI process.
The UI process will create a mapping between CSS value IDs and system colors, and pass it to the WebContent process.
Test: fast/css/ios/system-color-for-css-value.html
- WebCore.xcodeproj/project.pbxproj:
- css/StyleColor.h:
- css/parser/CSSPropertyParser.h:
- rendering/CSSValueKey.h: Added.
(WebCore::operator==):
(WebCore::CSSValueKey::encode const):
(WebCore::CSSValueKey::decode):
(WebCore::CSSValueKey::hash const):
(WTF::CSSValueKeyHash::hash):
(WTF::CSSValueKeyHash::equal):
(WTF::HashTraits<WebCore::CSSValueKey>::emptyValue):
(WTF::HashTraits<WebCore::CSSValueKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::CSSValueKey>::isDeletedValue):
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::cssValueIDSelectorList):
(WebCore::systemColorFromCSSValueID):
(WebCore::globalCSSValueToSystemColorMap):
(WebCore::RenderThemeIOS::getOrCreateCSSValueToSystemColorMap):
(WebCore::RenderThemeIOS::setCSSValueToSystemColorMap):
(WebCore::RenderThemeIOS::systemColor const):
- testing/Internals.cpp:
(WebCore::Internals::systemColorForCSSValue):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Create mapping between CSS value IDs and system colors in the UI process and send to the WebContent process
on process startup.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
LayoutTests:
- TestExpectations:
- fast/css/ios: Added.
- fast/css/ios/system-color-for-css-value-expected.txt: Added.
- fast/css/ios/system-color-for-css-value.html: Added.
- platform/ios/TestExpectations:
- 3:29 PM Changeset in webkit [254372] by
-
- 3 edits in trunk/LayoutTests
[WPE][GTK] Gardening after r254357
https://bugs.webkit.org/show_bug.cgi?id=206079
Unreviewed WPE and GTK+ gardening after r254357.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 3:13 PM Changeset in webkit [254371] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Integration] Fix accessibility/deleting-iframe-destroys-axcache.html and accessibility/div-within-anchors-causes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=206072
Reviewed by Zalan Bujtas.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::lineCount const):
We may have a line layout with 0 runs but 1 line. In these cases line count must return 0
to match other systems.
- 2:52 PM Changeset in webkit [254370] by
-
- 2 edits in trunk/Source/WebKit
Gardening: simple build fix after r254119.
Not reviewed.
We should be using ASSERT_ENABLED instead of ASSERT_DSIABLED.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::sendRequestCallback):
- 2:48 PM Changeset in webkit [254369] by
-
- 1 copy in tags/Safari-609.1.14
Tag Safari-609.1.14.
- 2:48 PM Changeset in webkit [254368] by
-
- 1 delete in tags/Safari-609.1.14
Delete tag.
- 2:38 PM Changeset in webkit [254367] by
-
- 3 edits in trunk/Tools
Fix test assertions after r254345
https://bugs.webkit.org/show_bug.cgi?id=206037
There were two assertions being hit in the new tests:
- Beacon sends POST requests, so the HTTP server that receives them needs to be able to handle POST requests.
- There was an assertion in the destructor of NetworkResourceLoader because we were destroying a WKWebView during a sync xhr.
This isn't a problem in practice, but we may as well wait for the sync xhr to finish before completing the test so we can
keep the sync xhr assertion, which is useful to prevent hangs.
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(-[TestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):
- TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::respondToRequests):
- 2:21 PM Changeset in webkit [254366] by
-
- 5 edits in trunk
[iOS] Remove 'com.apple.powerlog.plxpclogger.xpc' from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206086
<rdar://problem/57195681>
Reviewed by Per Arne Vollan.
Source/WebKit:
Telemetry and testing have confirmed that we no longer need a mach connection to the
'com.apple.powerlog.plxpclogger.xpc' service. We should remove it from the WebContent process sandbox.
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 2:17 PM Changeset in webkit [254365] by
-
- 6 edits in trunk
Remove 'com.apple.iohideventsystem' from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206085
<rdar://problem/36085204>
Reviewed by Alex Christensen.
After r253357 we no longer need access to 'com.apple.iohideventsystem', and should remove it from
the WebContent process sandbox.
Source/WebKit:
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 1:38 PM Changeset in webkit [254364] by
-
- 5 edits in trunk
[iOS] Remove 'com.apple.cookied' from the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=206083
<rdar://problem/56963865>
Reviewed by Per Arne Vollan.
Telemetry and testing have confirmed that we no longer use the 'com.apple.cookied' mach connection
in the WebContent process on iOS. We should remove this from the WebContent process sandbox
Source/WebKit:
Tested by fast/sandbox/ios/sandbox-mach-lookup.html.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 12:39 PM Changeset in webkit [254363] by
-
- 6 edits in trunk
Remove com.apple.locationd.registration from the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=206021
<rdar://problem/58451384>
Reviewed by Per Arne Vollan.
Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove
the blanket allow rule from the sandbox.
Source/WebKit:
Test: fast/sandbox/ios/sandbox-mach-lookup.html
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
LayoutTests:
- fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
- fast/sandbox/ios/sandbox-mach-lookup.html:
- 12:32 PM Changeset in webkit [254362] by
-
- 3 edits2 adds in branches/safari-609-branch
Revert "Revert "Cherry-pick r254301. rdar://problem/58346124""
- 11:56 AM Changeset in webkit [254361] by
-
- 2 edits in trunk/Source/WebKit
Clean up -[WKWebView _didCommitLayerTree:]
https://bugs.webkit.org/show_bug.cgi?id=206049
Reviewed by Tim Horton.
In preparation for sharing more of this code with macOS, factors parts of -[WKWebView _didCommitLayerTree:]
into new functions.
Also pull out part of -[WKWebView _updateVisibleContentRects] into its own function.
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _trackTransactionCommit:]):
(-[WKWebView _updateScrollViewForTransaction:]):
(-[WKWebView _restoreScrollAndZoomStateForTransaction:]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _allowsDoubleTapGestures]):
(-[WKWebView currentlyVisibleContentInsetsWithScale:obscuredInsets:]):
(-[WKWebView _updateVisibleContentRects]):
(areEssentiallyEqualAsFloat): Deleted.
- 11:56 AM Changeset in webkit [254360] by
-
- 7 edits4 adds in trunk/Source/WebKit
[macOS UI-side compositing] Introduce WKScrollView and WKContentView for macOS
https://bugs.webkit.org/show_bug.cgi?id=206042
Reviewed by Tim Horton.
Add WKScrollViewMac and WKWebViewMac, with bare-bones implementations. WKScrollViewMac
has a WKScrollViewDelegate to make it more iOS-like, to avoid clients having to register
boundsDidChange notifications, and WKWebView on macOS becomes the delegate.
These views are only created when UI-side compositing is enabled.
- SourcesCocoa.txt:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/mac/WKContentViewMac.h: Added.
- UIProcess/API/mac/WKContentViewMac.mm: Added.
(-[WKContentView initWithFrame:page:]):
(-[WKContentView isFlipped]):
(-[WKContentView _setAcceleratedCompositingRootLayer:]):
- UIProcess/API/mac/WKScrollViewMac.h: Added.
- UIProcess/API/mac/WKScrollViewMac.mm: Added.
(+[WKScrollView isCompatibleWithResponsiveScrolling]):
(-[WKScrollView initWithFrame:]):
(-[WKScrollView dealloc]):
(-[WKScrollView delegate]):
(-[WKScrollView setDelegate:]):
(-[WKScrollView contentOffset]):
(-[WKScrollView boundsDidChange:]):
(-[WKScrollView setContentInsets:]):
- UIProcess/API/mac/WKWebViewMac.h:
- UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewContentInsetsDidChange:]):
(-[WKWebView _setupScrollAndContentViews]):
- UIProcess/ios/WebPageProxyIOS.mm:
- WebKit.xcodeproj/project.pbxproj:
- 11:36 AM Changeset in webkit [254359] by
-
- 5 edits in trunk/Tools
[GTK][WPE] EWS should not wipe the JHBuild in the unapply patch step
https://bugs.webkit.org/show_bug.cgi?id=206061
Reviewed by Aakash Jain.
The current unapply patch step on the EWS calls the script clean-webkit, which wipes everything.
Rebuilding the JHBuild takes around 30 minutes, even with ccache.
And its not needed to wipe the JHBuild directories on the clean-webkit step, because the WebKit
tooling for building the JHBuild (update-webkitgtk-libs) already detects when the moduleset has
been modified and wipes it when necessary.
This patch adds the optional argument --keep-jhbuild-directory to the script clean-webkit,
that the EWS will pass when doing the unapply patch step for platform GTK or WPE.
- BuildSlaveSupport/ews-build/steps.py:
(CleanWorkingDirectory.start):
- Scripts/clean-webkit:
(main):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.discard_untracked_files):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
- 11:32 AM Changeset in webkit [254358] by
-
- 3 edits2 adds in branches/safari-608.5.7.3-branch
Cherry-pick r254301. rdar://problem/58480222
REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
- page/SecurityOrigin.cpp:
LayoutTests:
- fast/url/data-url-large-expected.txt: Added.
- fast/url/data-url-large.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:16 AM Changeset in webkit [254357] by
-
- 2 edits in trunk/Tools
Build fix for builds without libwebrtc's BoringSSL.
https://bugs.webkit.org/show_bug.cgi?id=206037
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
- 11:06 AM Changeset in webkit [254356] by
-
- 20 edits in trunk
[WebAuthn] Support authenticatorGetNextAssertion
https://bugs.webkit.org/show_bug.cgi?id=203346
<rdar://problem/56558488>
Reviewed by Brent Fulgham.
Source/WebCore:
Covered by new tests within existing test files.
- Modules/webauthn/AuthenticatorAssertionResponse.h:
(WebCore::AuthenticatorAssertionResponse::setName):
(WebCore::AuthenticatorAssertionResponse::name const):
(WebCore::AuthenticatorAssertionResponse::setDisplayName):
(WebCore::AuthenticatorAssertionResponse::displayName const):
(WebCore::AuthenticatorAssertionResponse::setNumberOfCredentials):
(WebCore::AuthenticatorAssertionResponse::numberOfCredentials const):
Adds new members to store new fields of the response from the authenticator. Field "icon"
is omitted given it could be used to track users according to https://github.com/w3c/webauthn/issues/1285.
- Modules/webauthn/fido/DeviceResponseConverter.cpp:
(fido::readCTAPGetAssertionResponse):
Adds new logic to parse above fields from an authenticator response.
Source/WebKit:
This patch implements authenticatorGetNextAssertion as suggested by the spec:
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorGetNextAssertion
The work flow is as follow:
1) When a valid assertion response is received, check its numberOfCredentials member;
2) When it is larger then 1, use authenticatorGetNextAssertion to get all remaining responses;
3) Once all responses are gathered, ask UI clients to pick one to return.
- UIProcess/API/APIWebAuthenticationPanelClient.h:
(API::WebAuthenticationPanelClient::selectAssertionResponses const):
- UIProcess/WebAuthentication/Authenticator.h:
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::selectAssertionResponses):
- UIProcess/WebAuthentication/AuthenticatorManager.h:
- UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::parseRequest):
- UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):
- UIProcess/WebAuthentication/fido/CtapAuthenticator.h:
Tools:
- TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/FidoTestData.h:
Adds new test case for new logic in DeviceResponseConverter.
LayoutTests:
- http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
- http/wpt/webauthn/public-key-credential-get-success-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
- http/wpt/webauthn/resources/util.js:
- 11:02 AM Changeset in webkit [254355] by
-
- 7 edits in branches/safari-608.5.7.3-branch/Source
Versioning.
- 10:56 AM Changeset in webkit [254354] by
-
- 7 edits in branches/safari-608.5.0.2-branch/Source
Versioning.
- 10:55 AM Changeset in webkit [254353] by
-
- 3 edits2 adds in branches/safari-608-branch
Cherry-pick r254301. rdar://problem/58467176
REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
- page/SecurityOrigin.cpp:
LayoutTests:
- fast/url/data-url-large-expected.txt: Added.
- fast/url/data-url-large.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:54 AM Changeset in webkit [254352] by
-
- 7 edits in branches/safari-608-branch/Source
Versioning.
- 10:54 AM Changeset in webkit [254351] by
-
- 10 edits in trunk
Remove 'com.apple.nehelper' from the WebContent sandbox.
https://bugs.webkit.org/show_bug.cgi?id=206025
<rdar://problem/58453508>
Reviewed by Per Arne Vollan.
Now that we generate a dynamic extension for 'com.apple.nehelper' and 'com.apple.nesessionmanager.content-filter',
we should remove the blanket allow rules from the sandbox.
Tests: fast/sandbox/ios/sandbox-mach-lookup.html, fast/sandbox/mac/sandbox-mach-lookup.html
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:50 AM Changeset in webkit [254350] by
-
- 4 edits in trunk/Source/WebCore
[WebGL] Add all remaining WebGL2 implementation functions to GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=206038
<rdar://problem/58459051>
Reviewed by Simon Fraser.
Add stubs for all the GraphicsContextGL methods that will be
necessary to implement WebGL2.
While here, rearrange the header file to mirror the way
WebGL2RenderingContext orders the methods, and mark all the
GraphicsContextGLOpenGL methods as final (rather than override).
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::bufferData):
(WebCore::GraphicsContextGLOpenGL::bufferSubData):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::getBufferSubData):
(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::blitFramebuffer):
(WebCore::GraphicsContextGLOpenGL::framebufferTextureLayer):
(WebCore::GraphicsContextGLOpenGL::invalidateFramebuffer):
(WebCore::GraphicsContextGLOpenGL::invalidateSubFramebuffer):
(WebCore::GraphicsContextGLOpenGL::readBuffer):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::texImage3D):
(WebCore::GraphicsContextGLOpenGL::texSubImage3D):
(WebCore::GraphicsContextGLOpenGL::copyTexSubImage3D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage3D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage3D):
(WebCore::GraphicsContextGLOpenGL::getFragDataLocation):
(WebCore::GraphicsContextGLOpenGL::uniform1ui):
(WebCore::GraphicsContextGLOpenGL::uniform2ui):
(WebCore::GraphicsContextGLOpenGL::uniform3ui):
(WebCore::GraphicsContextGLOpenGL::uniform4ui):
(WebCore::GraphicsContextGLOpenGL::uniform1uiv):
(WebCore::GraphicsContextGLOpenGL::uniform2uiv):
(WebCore::GraphicsContextGLOpenGL::uniform3uiv):
(WebCore::GraphicsContextGLOpenGL::uniform4uiv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3x4fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4x3fv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4i):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4iv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4ui):
(WebCore::GraphicsContextGLOpenGL::vertexAttribI4uiv):
(WebCore::GraphicsContextGLOpenGL::vertexAttribIPointer):
(WebCore::GraphicsContextGLOpenGL::drawRangeElements):
(WebCore::GraphicsContextGLOpenGL::drawBuffers):
(WebCore::GraphicsContextGLOpenGL::clearBufferiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferuiv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfv):
(WebCore::GraphicsContextGLOpenGL::clearBufferfi):
(WebCore::GraphicsContextGLOpenGL::createQuery):
(WebCore::GraphicsContextGLOpenGL::deleteQuery):
(WebCore::GraphicsContextGLOpenGL::isQuery):
(WebCore::GraphicsContextGLOpenGL::beginQuery):
(WebCore::GraphicsContextGLOpenGL::endQuery):
(WebCore::GraphicsContextGLOpenGL::getQuery):
(WebCore::GraphicsContextGLOpenGL::glGetQueryObjectuiv):
(WebCore::GraphicsContextGLOpenGL::createSampler):
(WebCore::GraphicsContextGLOpenGL::deleteSampler):
(WebCore::GraphicsContextGLOpenGL::isSampler):
(WebCore::GraphicsContextGLOpenGL::bindSampler):
(WebCore::GraphicsContextGLOpenGL::samplerParameteri):
(WebCore::GraphicsContextGLOpenGL::samplerParameterf):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameterfv):
(WebCore::GraphicsContextGLOpenGL::getSamplerParameteriv):
(WebCore::GraphicsContextGLOpenGL::fenceSync):
(WebCore::GraphicsContextGLOpenGL::isSync):
(WebCore::GraphicsContextGLOpenGL::deleteSync):
(WebCore::GraphicsContextGLOpenGL::clientWaitSync):
(WebCore::GraphicsContextGLOpenGL::waitSync):
(WebCore::GraphicsContextGLOpenGL::getSynciv):
(WebCore::GraphicsContextGLOpenGL::createTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::deleteTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::isTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::beginTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::endTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::transformFeedbackVaryings):
(WebCore::GraphicsContextGLOpenGL::getTransformFeedbackVarying):
(WebCore::GraphicsContextGLOpenGL::pauseTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::resumeTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindBufferBase):
(WebCore::GraphicsContextGLOpenGL::bindBufferRange):
(WebCore::GraphicsContextGLOpenGL::getUniformIndices):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):
(WebCore::GraphicsContextGLOpenGL::getUniformBlockIndex):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockiv):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockName):
(WebCore::GraphicsContextGLOpenGL::uniformBlockBinding):
(WebCore::GraphicsContextGLOpenGL::texImage2D):
(WebCore::GraphicsContextGLOpenGL::texSubImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexImage2D):
(WebCore::GraphicsContextGLOpenGL::compressedTexSubImage2D):
(WebCore::GraphicsContextGLOpenGL::uniform1fv):
(WebCore::GraphicsContextGLOpenGL::uniform2fv):
(WebCore::GraphicsContextGLOpenGL::uniform3fv):
(WebCore::GraphicsContextGLOpenGL::uniform4fv):
(WebCore::GraphicsContextGLOpenGL::uniform1iv):
(WebCore::GraphicsContextGLOpenGL::uniform2iv):
(WebCore::GraphicsContextGLOpenGL::uniform3iv):
(WebCore::GraphicsContextGLOpenGL::uniform4iv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix2fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix3fv):
(WebCore::GraphicsContextGLOpenGL::uniformMatrix4fv):
(WebCore::GraphicsContextGLOpenGL::readPixels):
- 10:49 AM Changeset in webkit [254349] by
-
- 3 edits4 adds in trunk
ObjectAllocationSinkingPhase doesn't model pointers to allocations in control flow properly
https://bugs.webkit.org/show_bug.cgi?id=204738
<rdar://problem/57553238>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/allocation-sinking-must-model-allocation-pointers-properly-2.js: Added.
(assert):
(v9):
- stress/allocation-sinking-must-model-allocation-pointers-properly-3.js: Added.
(assert):
(v9):
- stress/allocation-sinking-must-model-allocation-pointers-properly-4.js: Added.
(bool):
(effects):
(escape):
(bar):
- stress/allocation-sinking-must-model-allocation-pointers-properly.js: Added.
(alwaysFalse):
(sometimesZero):
(assert):
(v9):
Source/JavaScriptCore:
Allocation sinking phase conducts a points to analysis. It uses this
information for programs like:
`
1: NewObject
2: NewObject
3: PutByOffset(@2, @1, "x")
4: GetByOffset(@2, "x")
`
It solves the points to problem knowing @4 points to @1.
It tracks this data in the LocalHeap data structure. This is used to track
the heap across blocks, and it includes a merge function to handle control
flow merges. However, this merge function would not always merge the pointer
sets together. It sometimes would merge them together, since it had a fast
path check inside merge, which would just copy the contents of the block to be
merged with itself if it were this block's first time merging. This fast path happened
to hide the bug in general case merge code. If we didn't take this fast path,
we would just never transfer pointer sets from predecessor to successor. This
could lead to all kinds of issues, including using the incorrect phantom node
in IR instead of its materialized version. It could also lead to the phase not
sinking objects it is capable of sinking.
This patch makes it so that we merge together the pointer sets. We always add
new pointers to the set. So in pointer A->B, if the set has yet to see A, we
add it. If the set already contains pointer A->B, and we encounter a new
pointer A->C, or if we encounter a merge without any A->* pointer, we mark
the A pointer as top, marking it A->TOP. We do this to ensure that we fixpoint.
We're guaranteed that m_pointers is monotonically increasing (module liveness
pruning, which is a constant). And once something is TOP, it never becomes
anything else. (Instead of marking a pointer top, we used to just remove it
from the set, but this has issues, as it could lead to us ping-ponging in
our fixpoint analysis, add, remove, add, remove, etc.)
So the merge rules are:
{A->B} merge {A->B} => {A->B}
{A->B} merge {A->C} => {A->TOP}
{A->B} merge {A->TOP} => {A->TOP}
{A->B} merge {} => {A->TOP}
Thanks to Samuel Groß of Google Project Zero for identifying this bug.
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- 10:48 AM Changeset in webkit [254348] by
-
- 1 edit3 deletes in trunk/WebKitLibraries
WebKitLibraries: Remove old private framework stubs
https://bugs.webkit.org/show_bug.cgi?id=206067
<rdar://problem/58479518>
Reviewed by Alexey Proskuryakov.
- WebKitPrivateFrameworkStubs/iOS/10: Removed.
- WebKitPrivateFrameworkStubs/iOS/11: Removed.
- WebKitPrivateFrameworkStubs/iOS/12: Removed.
- 10:32 AM Changeset in webkit [254347] by
-
- 2 edits in trunk/Source/WebKit
Silence compiler warning
https://bugs.webkit.org/show_bug.cgi?id=206070
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-01-10
Reviewed by Chris Dumez.
Silence compiler by using the proper formatter for log out.
No functional changes.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
- 10:14 AM Changeset in webkit [254346] by
-
- 2 edits in trunk/Tools
Python 3: Add support to run-webkit-tests (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=205291
Unreviewed follow-up fix.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_diff_image): Diff output is byte array, not string.
(PortTestCase.test_diff_image_failed): Ditto.
(PortTestCase.test_diff_image_crashed): Ditto.
- 10:06 AM Changeset in webkit [254345] by
-
- 27 edits6 adds in trunk
Expand _WKResourceLoadDelegate callbacks
https://bugs.webkit.org/show_bug.cgi?id=206037
Source/WebKit:
<rdar://problem/57132290>
Reviewed by Youenn Fablet.
Add 5 informative delegate callbacks at these times during the loading process:
- When a request is sent.
- When a redirect happens.
- When a challenge happens.
- When a response is received.
- When loading completes or fails.
As mentioned in r254183 these callbacks are only called when a _WKResourceLoadDelegate is given to a WKWebView.
We add a new struct ResourceLoadInfo which will need to be expanded containing currently only the load identifier.
Covered by new API tests which verify the validity of the sent information.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didReceiveChallenge):
- NetworkProcess/NetworkLoadClient.h:
(WebKit::NetworkLoadClient::didReceiveChallenge):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::generateResourceLoadID):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::resourceLoadInfo):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::didReceiveChallenge):
Add a way to send a message informing that a challenge happened with information gathered from the NetworkResourceLoader,
which previously was not informed of challenges because the challenges went directly from the NetworkLoad to the AuthenticationManager.
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::m_shouldCaptureExtraNetworkLoadMetrics): Deleted.
- NetworkProcess/NetworkResourceLoader.h:
- Shared/API/APIObject.h:
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Shared/ResourceLoadInfo.h: Added.
(WebKit::ResourceLoadInfo::encode const):
(WebKit::ResourceLoadInfo::decode):
- SourcesCocoa.txt:
- UIProcess/API/APIResourceLoadClient.h:
- UIProcess/API/APIResourceLoadInfo.h: Added.
- UIProcess/API/Cocoa/_WKResourceLoadDelegate.h:
- UIProcess/API/Cocoa/_WKResourceLoadInfo.h: Added.
- UIProcess/API/Cocoa/_WKResourceLoadInfo.mm: Added.
(-[_WKResourceLoadInfo dealloc]):
(-[_WKResourceLoadInfo resourceLoadID]):
(-[_WKResourceLoadInfo _apiObject]):
- UIProcess/API/Cocoa/_WKResourceLoadInfoInternal.h: Added.
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
An AuthenticationChallengeProxy was only used for challenges that needed credentials, so they wrapped a CompletionHandler.
This new type of informative-only challenge will be given a null CompletionHandler, which means no action can be taken.
- UIProcess/Cocoa/ResourceLoadDelegate.h:
- UIProcess/Cocoa/ResourceLoadDelegate.mm:
(WebKit::ResourceLoadDelegate::setDelegate):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didSendRequest const):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didPerformHTTPRedirection const):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didReceiveChallenge const):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didReceiveResponse const):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::didCompleteWithError const):
(WebKit::ResourceLoadDelegate::ResourceLoadClient::willSendRequest const): Deleted.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::resourceLoadDidSendRequest):
(WebKit::NetworkProcessProxy::resourceLoadDidPerformHTTPRedirection):
(WebKit::NetworkProcessProxy::resourceLoadDidReceiveChallenge):
(WebKit::NetworkProcessProxy::resourceLoadDidReceiveResponse):
(WebKit::NetworkProcessProxy::resourceLoadDidCompleteWithError):
(WebKit::NetworkProcessProxy::pageWillSendRequest): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
Tools:
Reviewed by Youenn Fablet.
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
(-[TestResourceLoadDelegate webView:resourceLoad:didSendRequest:]):
(-[TestResourceLoadDelegate webView:resourceLoad:didPerformHTTPRedirection:newRequest:]):
(-[TestResourceLoadDelegate webView:resourceLoad:didReceiveChallenge:]):
(-[TestResourceLoadDelegate webView:resourceLoad:didReceiveResponse:]):
(-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]):
(TEST):
(-[TestResourceLoadDelegate webView:willSendRequest:]): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- TestWebKitAPI/cocoa/HTTPServer.h:
(TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse):
Add the ability to have non-200 status codes in responses.
Also switch the order of parameters to reflect the fact that header fields are sent before the body.
- TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::statusText):
(TestWebKitAPI::HTTPServer::respondToRequests):
- 9:57 AM Changeset in webkit [254344] by
-
- 8 edits in trunk
Add SPI to enable TLS 1.0 and 1.1 in WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=206046
Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-10
Reviewed by Youenn Fablet.
Source/WebKit:
This is needed for <rdar://problem/58464912>
Covered by API tests.
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
- UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration legacyTLSEnabled]):
(-[_WKWebsiteDataStoreConfiguration setLegacyTLSEnabled:]):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::copy const):
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::legacyTLSEnabled const):
(WebKit::WebsiteDataStoreConfiguration::setLegacyTLSEnabled):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 9:52 AM Changeset in webkit [254343] by
-
- 3 edits in trunk/Source/WebKit
[macOS] Issue sandbox extension to "com.apple.nesessionmanager" prior to 10.15
https://bugs.webkit.org/show_bug.cgi?id=206031
<rdar://problem/58455467>
Reviewed by Per Arne Vollan.
The mach name of 'com.apple.nesessionmanager' changed between macOS 10.14 and 10.15.
We should continue to issue the old name when building for older operating systems."
Covered by existing tests.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 9:40 AM Changeset in webkit [254342] by
-
- 11 edits in trunk
Remove WebsiteDataStore::setCacheStorageDirectory which has been replaced by WebsiteDataStoreConfiguration::setCacheStorageDirectory
https://bugs.webkit.org/show_bug.cgi?id=205841
Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-10
Reviewed by Youenn Fablet.
Source/WebKit:
- UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
(WKWebsiteDataStoreConfigurationCopyCacheStorageDirectory):
(WKWebsiteDataStoreConfigurationSetCacheStorageDirectory):
- UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _cacheStorageDirectory]): Deleted.
(-[WKWebsiteDataStore _setCacheStorageDirectory:]): Deleted.
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::retrieveCacheStorageParameters):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::cacheStorageDirectory const):
(WebKit::WebsiteDataStore::setCacheStorageDirectory): Deleted.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::websiteDataStore):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
- 8:48 AM Changeset in webkit [254341] by
-
- 8 edits in trunk
[WTR] Use short heart beat timer as a TestOption
https://bugs.webkit.org/show_bug.cgi?id=205795
Reviewed by Chris Dumez.
Tools:
Using short service worker heartbeat timeout values creates flakiness on slow bots.
By default, use regular service worker heartbeat timeout values for layout tests.
Add a WTR option value to use short service worker timeout values.
Use this option for service worker spinning layout tests.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
- http/wpt/service-workers/service-worker-spinning-activate.https.html:
- http/wpt/service-workers/service-worker-spinning-fetch.https.html:
- http/wpt/service-workers/service-worker-spinning-install.https.html:
- http/wpt/service-workers/service-worker-spinning-message.https.html:
- 8:16 AM Changeset in webkit [254340] by
-
- 23 edits in trunk/Tools
Python 3: Add support to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=205291
Reviewed by Stephanie Lewis.
- Scripts/test-webkitpy-python3: Add webkitpy.layout_tests.
- Scripts/webkitpy/common/message_pool.py:
(_MessagePool._loop): Move exception inside of loop.
(_Message.repr): Use .format strings.
(_Worker.init): Ditto.
- Scripts/webkitpy/common/wavediff.py:
(WaveDiff.init): Use Python 3 compatible BytesIO and StringIO.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder._read_test_names_from_file): Use .format string.
(LayoutTestFinder.split_into_chunks): Explicitly use integer division.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._get_test_inputs): Use range over xrange.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error): Use .format strings.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator._insert_failure_summaries): Use Python 3 compatible itervalues.
- Scripts/webkitpy/layout_tests/models/test_results.py:
(TestResult.init): Sort type list.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.setUp): Multiple processes are buggy in test-webkitpy.
(RunTest.test_basic): replace buflist with getvalue().
(RunTest.test_child_processes_2): Ditto.
(RunTest.test_child_processes_min): Ditto.
(RunTest.test_keyboard_interrupt): Ditto.
(RunTest.test_missing_and_unexpected_results): Compare dictionaries instead of json strings.
(RunTest.test_crash_with_stderr): Ditto.
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist): Ditto.
(EndToEndTest.test_reftest_with_two_notrefs): Ditto.
- Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.write): Flush stream after writing.
(MeteredStream._erase_last_partial_line): Ditto.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._print_directory_timings): Can't compare string to integer.
(Printer._print_statistics_for_test_timings): Use integer division.
- Scripts/webkitpy/port/darwin.py:
(DarwinPort._merge_crash_logs): Use items over iteritems.
- Scripts/webkitpy/port/device.py:
(Device.hash): Allow hashing of devices.
- Scripts/webkitpy/port/device_port.py:
(DevicePort._install): Use range over xrange.
(DevicePort.setup_test_run): Ditto.
(DevicePort.clean_up_test_run): Ditto.
- Scripts/webkitpy/port/driver.py:
(DriverOutput.init): Text should be decoded, audio encoded.
(Driver.init):
(Driver.run_test):
(Driver._parse_child_processes_output): Output is byte array.
(Driver._check_for_driver_timeout): Ditto.
(Driver._check_for_address_sanitizer_violation): Error lines are byte arrays.
(Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
(Driver._read_optional_image_block): If a block is base64 encoded, we want the decoded
content, otherwise, we want the encoded content.
(Driver._read_header): Lines are byte arrays, decode them before processing.
(Driver._process_stdout_line): Blocks are byte arrays.
(Driver._strip_eof): Lines should be byte arrays, not strings.
(Driver._read_block): Standardize encoding in blocks.
(ContentBlock.init): Content should be a byte array.
(ContentBlock.decode_content): Attempt to decode content.
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_read_binary_block): Content should be encoded.
(DriverTest.test_read_base64_block): Ditto.
(DriverTest.test_check_for_driver_crash): ServerProcess output should be a byte array.
- Scripts/webkitpy/port/image_diff.py:
(ImageDiffer.diff_image): ImageDiff output is in byte arrays.
(ImageDiffer._read): Ditto.
- Scripts/webkitpy/port/server_process.py:
(ServerProcess.write): Encode data before writing it.
- Scripts/webkitpy/port/server_process_mock.py:
(MockServerProcess.init): Convert string mock output to bytes.
(MockServerProcess.read_stdout_line): Stdout lines are byte arrays.
(MockServerProcess.read_stdout): Ditto.
- Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess.NonBlockingFileFromSocket.close): Don't double close socket in Python 3.
(SimulatorProcess._start): Stdin should be a binary stream.
- Scripts/webkitpy/port/test.py:
(unit_test_list): Convert audio streams to byte arrays.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.is_usable): Decode xcrun output.
(SimulatedDevice.install_app): Use xrange over range.
- 7:46 AM Changeset in webkit [254339] by
-
- 5 edits in trunk/Source/WebCore
[LFC][Integration] Fix accessibility/scroll-to-make-visible-iframe-offscreen.html
https://bugs.webkit.org/show_bug.cgi?id=206063
Reviewed by Zalan Bujtas.
This is failing due to missing LFC implementation for RenderText::absoluteQuad.
- rendering/RenderText.cpp:
(WebCore::collectAbsoluteQuadsForNonComplexPaths):
Implement generic version for collecting absolute quads. It doesn't cover everything that is needed for
the complex path so that still calls into layout system specific code.
(WebCore::RenderText::absoluteQuadsClippedToEllipsis const):
(WebCore::RenderText::absoluteQuads const):
(WebCore::RenderText::layoutFormattingContextLineLayout const):
(WebCore::RenderText::usesComplexLineLayoutPath const):
- rendering/RenderText.h:
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::collectAbsoluteQuads): Deleted.
Not needed anymore.
- rendering/SimpleLineLayoutFunctions.h:
- 7:22 AM Changeset in webkit [254338] by
-
- 2 edits in trunk/LayoutTests
[GTK] imported/w3c/web-platform-tests/xhr/anonymous-mode-unsupported.htm is flaky
https://bugs.webkit.org/show_bug.cgi?id=206065
Unreviewed, mark test as flaky.
- platform/gtk/TestExpectations:
- 7:10 AM Changeset in webkit [254337] by
-
- 2 edits in trunk/LayoutTests
[WPE][GTK] Gardening after r254335
https://bugs.webkit.org/show_bug.cgi?id=206062
Unreviewed WPE and GTK+ gardening after r254335.
- platform/gtk/TestExpectations:
- 7:06 AM Changeset in webkit [254336] by
-
- 9 edits in trunk/Source/WebCore
[LFC] Replace FormattingContext::EscapeTypes with EscapeReasons
https://bugs.webkit.org/show_bug.cgi?id=206050
<rdar://problem/58466862>
Reviewed by Antti Koivisto.
EscapeReason is more explicit about why certain formatting context escapes are allowed.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
- layout/FormattingContextQuirks.cpp:
(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraHorizontalSpace):
- 4:46 AM Changeset in webkit [254335] by
-
- 2 edits in trunk/Tools
[Flatpak] Update IceCC to version 1.2
https://bugs.webkit.org/show_bug.cgi?id=206059
Reviewed by Philippe Normand.
Update IceCC/Icecream to version 1.2, which is the same version
currently shipped with Debian stable (Buster). This bump is needed
because IceCC 1.1 does not seem to interoperate with the scheduler
from newer versions and it is expected that people who run IceCC will
install IceCC in their build farm from distribution packages.
- flatpak/org.webkit.CommonModules.yaml: Bump IceCC version to 1.2,
add the Git commit-id for the release tag.
- 4:32 AM Changeset in webkit [254334] by
-
- 7 edits in trunk
Source/WebCore:
[EME][ClearKey] Refactor CDMInstanceClearKey::updateLicense()
https://bugs.webkit.org/show_bug.cgi?id=205999
Patch by Charlie Turner <mail@charles.plus> on 2020-01-10
Reviewed by Xabier Rodriguez-Calvar.
Covered by existing tests.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::toHexString const): Helper utility to view
a shared buffer's contents as a hex string.
- platform/SharedBuffer.h:
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMInstanceClearKey::Key::keyIDAsString const): Uses the
new utility to return a hex string of the key ID for debugging.
(WebCore::CDMInstanceClearKey::Key::keyValueAsString const):
Ditto, but for the key data.
(WebCore::operator==): Added comparison operations to
CDMInstanceClearKey::Key to cleanup code in updateLicense.
(WebCore::operator<):
(WebCore::CDMInstanceSessionClearKey::updateLicense): Refactored
to use operators associated with the key class, so as to avoid
open-coded memcmp's in the middle of conditionals and other
techniques that made the code harder to read that necessary.
- platform/encryptedmedia/clearkey/CDMClearKey.h:
Tools:
[EME][ClearKey] Refactor CDMClearKey::update()
https://bugs.webkit.org/show_bug.cgi?id=205999
Patch by Charlie Turner <mail@charles.plus> on 2020-01-10
Reviewed by Xabier Rodriguez-Calvar.
- TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::TEST_F): Added a test for the new toHexString
helper. It should make sure to zero pad each byte to two
characters, so that it's easy to read.
- 3:58 AM Changeset in webkit [254333] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.4 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.27.4.
- 3:39 AM Changeset in webkit [254332] by
-
- 5 edits in trunk/Source
Unreviewed. Fix GTK and WPE API docs generation
Source/JavaScriptCore:
Add index for new symbols in 2.28.
- API/glib/docs/jsc-glib-docs.sgml:
Source/WebKit:
Fix the name of the new class. WebKitInputMethodFilter -> WebKitInputMethodContext.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/wpe/docs/wpe-docs.sgml:
- 2:53 AM Changeset in webkit [254331] by
-
- 6 edits in trunk
[GLIB] Add GLib specific API for JSC JSValueRef.h's JSValueMakeFromJSONString and JSValueCreateJSONString methods
https://bugs.webkit.org/show_bug.cgi?id=205161
Reviewed by Adrian Perez de Castro.
Source/JavaScriptCore:
Add jsc_value_new_from_json() and jsc_value_to_json().
- API/glib/JSCValue.cpp:
(jsc_value_new_from_json):
(jsc_value_to_json):
- API/glib/JSCValue.h:
- API/glib/docs/jsc-glib-4.0-sections.txt:
Tools:
Add tests for new API.
- TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
(testJSCJSON):
(main):
- 12:45 AM Changeset in webkit [254330] by
-
- 2 edits in trunk/Source/WebKit
Automation: resolveChildFrameWithNodeHandle should return NodeNotFound when node doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=205993
Reviewed by Brian Burg.
According to the spec:
"If element is stale, return error with error code stale element reference."
https://w3c.github.io/webdriver/#switch-to-frame
Fixes: imported/w3c/webdriver/tests/switch_to_frame/switch.py::test_frame_id_webelement_stale_reference
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::resolveChildFrameWithNodeHandle):
- 12:44 AM Changeset in webkit [254329] by
-
- 8 edits in trunk
Automation: evaluateJavaScriptFunction should use Promises
https://bugs.webkit.org/show_bug.cgi?id=204151
Reviewed by Brian Burg.
Source/WebDriver:
- CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const): Timeout errors should return 500 not 408.
- Session.cpp:
(WebDriver::Session::executeScript): Ensure the script body goes between new lines to avoid problems with
trailing comments like in function() { return foo; Comment }.
Source/WebKit:
Make the function to run scripts async and handle the result as a promise. To implement the script timeout we
use another promise that starts the timer and then we run a Promise.race() with both promises. To simplify the
results reporting, all exceptions (including timeout errors that are now handled as exceptions) are now handled
as errors passed to the resultCallback. The boolean parameter has been removed, we can simply check the type of
the value received because results are always strings and errors are always exception objects.
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::evaluateJavaScriptCallback): Handle the script result, including all possible errors now (not only timeouts).
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction): Any exception running the script should be an
internal error now. The code to handle error has been moved to evaluateJavaScriptCallback().
- WebProcess/Automation/WebAutomationSessionProxy.js:
(WebKitAutomation.AutomationSessionProxy.prototype.evaluateJavaScriptFunction): Call _execute and handle the
promise result to call resultCallback wityh either the result or the error.
(WebKitAutomation.AutomationSessionProxy.prototype._execute): Make the function to run the script async and
handle the result as a promise.
WebDriverTests:
Remove expectations for tests that are now passing.
- TestExpectations.json:
- 12:42 AM Changeset in webkit [254328] by
-
- 3 edits in trunk/Source/WebKit
Automation: scripts are executed in the wrong js context after a history navigation
https://bugs.webkit.org/show_bug.cgi?id=204880
<rdar://problem/58413615>
Reviewed by Brian Burg.
After a history navigation we use the script object from the previous frame js context because
didClearWindowObjectForFrame() is not called in that case. We are caching the script object for every frame ID,
and after a history navigation the frame ID is the same, but the frame js context isn't. That also means we might
be leaking the script objects in those cases, because we end up calling JSValueUnprotect with the wrong
context. It would be easier to set the script object as a property of the global object and let JSC handle the
lifetime. Instead of caching the script object and protect/unprotect it, we just check if the global object of
the current js context has the property or not to get or create it. We use a private symbol as the key of the
global object property to ensure it's not visible.
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::WebAutomationSessionProxy): Initialize m_scriptObjectIdentifier.
(WebKit::WebAutomationSessionProxy::scriptObject): Helper function to get the script object for the given
JavaScript context.
(WebKit::WebAutomationSessionProxy::setScriptObject): Helper function to set the script object for the given
JavaScript context.
(WebKit::WebAutomationSessionProxy::scriptObjectForFrame): Get or create the script object.
(WebKit::WebAutomationSessionProxy::elementForNodeHandle): Get the script object from global object.
(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame): Remove the code to unprotect script objects
of the frame.
- WebProcess/Automation/WebAutomationSessionProxy.h: Add m_scriptObjectIdentifier and remove m_webFrameScriptObjectMap.
Jan 9, 2020:
- 10:51 PM Changeset in webkit [254327] by
-
- 11 edits in trunk/Source
Fix various non-unified build issues introduced since r253538
https://bugs.webkit.org/show_bug.cgi?id=205996
Reviewed by Youenn Fablet.
Source/JavaScriptCore:
- bytecode/ExecutableToCodeBlockEdge.cpp: Add missing inclusion of JSObjectInlines.h and
StructureInlines.h
- dfg/DFGVariableEvent.cpp: Add missing inclusion of OperandsInlines.h
- runtime/NarrowingNumberPredictionFuzzerAgent.cpp: Add missing inclusion of CodeBlock.h
- runtime/WideningNumberPredictionFuzzerAgent.cpp: Ditto.
- wasm/WasmOperations.cpp: Add missing inclusion of ButterflyInlines.h
Source/WebCore:
No new tests needed.
- dom/UserGestureIndicator.cpp: Add missing inclusion of DOMWindow.h
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::parseAttribute): Add missing namespace prefix to HTMLNames::openAttr.
(WebCore::HTMLDialogElement::toggleOpen): Ditto.
- page/Page.cpp: Add missing inclusion of MediaRecorderProvider.h
- page/PageConfiguration.h: Add missing inclusion of wtf/Forward.h and wtf/Vector.h
- 9:23 PM Changeset in webkit [254326] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/xhr/event-timeout-order.any.html has been flaky since it was imported in r254154
https://bugs.webkit.org/show_bug.cgi?id=206053
Unreviewed, mark test as flaky.
- 8:44 PM Changeset in webkit [254325] by
-
- 4 edits in trunk/Source/WebKit
REGRESSION(r253868): Socket-based remote inspector cannot inspect any target
https://bugs.webkit.org/show_bug.cgi?id=206045
Reviewed by Don Olmstead.
Revert part of patch, ensuring Target struct stays consistent with socket inspector's messaging protocol.
- UIProcess/socket/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::setTargetList):
(WebKit::debuggableTypeToString): Deleted.
- UIProcess/socket/RemoteInspectorClient.h:
- UIProcess/socket/RemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::targetListChanged):
(WebKit::debuggableTypeToString): Deleted.
- 7:59 PM Changeset in webkit [254324] by
-
- 2 edits in trunk/Tools
Move macOS Test262, JSC, and perf queues to Catalina
https://bugs.webkit.org/show_bug.cgi?id=205971
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Update queue names on dashboard to match new naming scheme (dashes instead of spaces)
- 7:50 PM Changeset in webkit [254323] by
-
- 13 edits1 add2 deletes in trunk
[Win] Use ComplexTextController instead of UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=204884
Reviewed by Brent Fulgham.
Source/WebCore:
UniscribeController doesn't support surrogate pairs and has
rendering glitches of partially selected a combining character.
Remove UniscribeController, and use ComplexTextController by
implementingcollectComplexTextRunsForCharacterswith Uniscribe.
Covered by existing tests.
- PlatformWin.cmake:
- platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Deleted.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthOfTextRange const):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText const):
(WebCore::FontCascade::drawGlyphBuffer const):
(WebCore::FontCascade::floatWidthForComplexText const):
(WebCore::FontCascade::adjustSelectionRectForComplexText const):
(WebCore::FontCascade::offsetForPositionForComplexText const):
- platform/graphics/win/ComplexTextControllerUniscribe.cpp: Added.
(WebCore::shapeByUniscribe):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/win/FontCGWin.cpp:
- platform/graphics/win/FontCascadeDirect2D.cpp:
- platform/graphics/win/FontWin.cpp:
(WebCore::FontCascade::adjustSelectionRectForComplexText const): Deleted.
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText const): Deleted.
(WebCore::FontCascade::floatWidthForComplexText const): Deleted.
(WebCore::FontCascade::offsetForPositionForComplexText const): Deleted.
- platform/graphics/win/UniscribeController.cpp: Removed.
- platform/graphics/win/UniscribeController.h: Removed.
Tools:
- TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Enabled these tests for PLATFORM(WIN).
LayoutTests:
- platform/win/TestExpectations:
- platform/win/fast/text/justify-ideograph-complex-expected.txt: Rebaselined.
- platform/wincairo/TestExpectations:
- 7:38 PM Changeset in webkit [254322] by
-
- 7 edits4 adds in trunk
Block cross-site top-frame navigations from untrusted iframes
https://bugs.webkit.org/show_bug.cgi?id=206027
<rdar://problem/58320516>
Reviewed by Geoffrey Garen.
Source/WebCore:
Block cross-site top-frame navigations from untrusted iframes, unless they have a user gesture.
We already consider third-party iframes as untrusted, we now also treat first-party iframes
as untrusted if they are loaded both third-party scripts & iframes.
Test: http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html
- dom/Document.cpp:
(WebCore::Document::canNavigate):
(WebCore::Document::willLoadScriptElement):
(WebCore::Document::willLoadFrameElement):
(WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):
- dom/Document.h:
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestClassicScript):
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::openURL):
LayoutTests:
Add layout test coverage.
- http/tests/security/block-top-level-navigations-by-third-party-iframes-expected.txt:
- http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes-expected.txt: Added.
- http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html: Added.
- http/tests/security/resources/navigate-top-level-frame-to-failure-page-untrusted-iframe.html: Added.
- http/tests/security/resources/navigate-top-to-error-page.js: Added.
- 7:08 PM Changeset in webkit [254321] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=206007
- platform/gtk/TestExpectations:
- 6:34 PM Changeset in webkit [254320] by
-
- 2 edits in trunk/Source/WebCore
Disable accessibility isolated tree for LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=206048
<rdar://problem/58459580>
Reviewed by Chris Fleizach.
Fix for numerous LayoutTests failing when using accessibility isolated tree.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::clientSupportsIsolatedTree):
- 6:21 PM Changeset in webkit [254319] by
-
- 1 copy in tags/Safari-608.5.10
Tag Safari-608.5.10.
- 6:10 PM Changeset in webkit [254318] by
-
- 4 edits in trunk/Tools
TestController::platformLibraryPathForTesting() returns inner pointer to autoreleased NSString
<https://webkit.org/b/206018>
<rdar://problem/58449733>
Reviewed by Darin Adler.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- Use WTF::AutodrainedPool to fix remaining autoreleasePool leaks.
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformLibraryPathForTesting):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformLibraryPathForTesting):
- Retain NSString since these methods return an inner pointer. This also only needs to be initialized once.
- 5:25 PM Changeset in webkit [254317] by
-
- 6 edits in trunk/Source
Adopt TARGET_OS_MACCATALYST in more places
https://bugs.webkit.org/show_bug.cgi?id=206040
<rdar://problem/57127108>
Reviewed by Simon Fraser.
Source/WebKit:
- Shared/API/Cocoa/WebKit.h:
Source/WebKitLegacy/mac:
- Misc/WebDownload.h:
Source/WTF:
- wtf/Platform.h:
- 5:24 PM Changeset in webkit [254316] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: suggest "color()" when defining color in CSS value
https://bugs.webkit.org/show_bug.cgi?id=205976
Reviewed by Devin Rousso.
- UserInterface/Models/CSSKeywordCompletions.js:
- 5:07 PM Changeset in webkit [254315] by
-
- 4 edits in trunk/Source/WebKit
Clean up -[WKWebView _initializeWithConfiguration:]
https://bugs.webkit.org/show_bug.cgi?id=206039
Reviewed by Tim Horton.
-[WKWebView _initializeWithConfiguration:] is full of platform #ifdefs so needs
cleaning up before adding more code. Factor out WKScrollView and view hookup,
pageConfiguration setup, and notification registration.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setupPageConfiguration:]):
- UIProcess/API/ios/WKWebViewIOS.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setupScrollAndContentViews]):
(-[WKWebView _registerForNotifications]):
- 4:40 PM Changeset in webkit [254314] by
-
- 5 edits in trunk
Text manipulation controller should not observe changes in new replacement elements
https://bugs.webkit.org/show_bug.cgi?id=206015
<rdar://problem/58353667>
Reviewed by Tim Horton.
Source/WebCore:
TextManipulationController may insert elements in the process of completing text replacement operations. When
renderers are created for these elements (after the next layout pass), the controller is notified via
TextManipulationController::didCreateRendererForElement, which causes it to begin observing the newly inserted
elements. For certain clients, this may lead to an unending cycle of text manipulation updates as the new
text manipulation items' tokens will be replaced with new tokens, and we never reach a stable state.
To mitigate this, we avoid adding newly visible elements to m_mutatedElements in the case where the newly
visible elements were recently inserted by text replacement. See below for more details.
Test: TextManipulation.CompleteTextManipulationDoesNotCreateMoreTextManipulationItems
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::didCreateRendererForElement):
Avoid considering an element that has a new renderer, if it is an element we had just inserted using text
manipulation APIs.
(WebCore::TextManipulationController::replace):
As we iterate over and apply each text replacement, remember the elements we've inserted using a WeakHashSet;
this set is cleared in a queued async task, after which layout should be up to date.
- editing/TextManipulationController.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
Add a new API test to verify that we don't fire text manipulation item callbacks due to inserting elements when
completing text manipulation.
(-[TextManipulationDelegate initWithItemCallback]): Deleted.
Remove a stray initializer that was unused (and also doesn't take an ItemCallback, as its name might suggest).
- 4:19 PM Changeset in webkit [254313] by
-
- 1 copy in tags/Safari-608.5.0.2.3
Tag Safari-608.5.0.2.3.
- 3:48 PM Changeset in webkit [254312] by
-
- 11 edits in trunk/Source/WebKit
Use HAVE(TOUCH_BAR) instead of PLATFORM(COCOA) in more places
https://bugs.webkit.org/show_bug.cgi?id=205975
Reviewed by Wenson Hsieh.
Protect Touch Bar-related code with HAVE(TOUCH_BAR) instead of PLATFORM(COCOA).
- Shared/TouchBarMenuData.cpp:
- Shared/TouchBarMenuData.h:
- Shared/TouchBarMenuItemData.cpp:
- Shared/TouchBarMenuItemData.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::forceRequestCandidatesForTesting):
(WebKit::WebViewImpl::setEditableElementIsFocused):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::didChangeSelectionOrOverflowScrollPosition):
(WebKit::WebPage::didInsertMenuElement):
(WebKit::WebPage::didRemoveMenuElement):
(WebKit::WebPage::didInsertMenuItemElement):
(WebKit::WebPage::didRemoveMenuItemElement):
- WebProcess/WebPage/WebPage.h:
- 3:48 PM Changeset in webkit [254311] by
-
- 15 edits in trunk/Source
Add ENABLE_UI_SIDE_COMPOSITING and use it in a few places
https://bugs.webkit.org/show_bug.cgi?id=205982
Reviewed by Jon Lee.
Source/WebKit:
All Remote* things should get wrapped in ENABLE(UI_SIDE_COMPOSITING)
if other platforms build the files, so do some of that. VisibleContentRect*
and ViewUpdateDispatcher* stuff is also UI-side compositing only.
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
- Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):
- Shared/VisibleContentRectUpdateInfo.cpp:
- Shared/VisibleContentRectUpdateInfo.h:
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
- UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::handleMouseEvent):
- UIProcess/RemoteLayerTree/RemoteScrollingTree.h:
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
- WebProcess/WebPage/ViewUpdateDispatcher.h:
- WebProcess/WebPage/WebPage.h:
Source/WTF:
Add a #define ENABLE_UI_SIDE_COMPOSITING for Cocoa platforms. Minor comment cleanup, and
move the duplicate ENABLE_ASYNC_SCROLLING from iOS and macOS sections into the Cocoa section.
- wtf/FeatureDefines.h:
- 3:47 PM Changeset in webkit [254310] by
-
- 2 edits in trunk/Source/WebKit
Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
https://bugs.webkit.org/show_bug.cgi?id=206035
<rdar://problem/58455306>
Reviewed by Brent Fulgham.
No new tests.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setResourceLoadStatisticsEnabled):
Added a check that m_sessionID exists.
- 3:47 PM Changeset in webkit [254309] by
-
- 3 edits2 deletes in branches/safari-609-branch
Revert "Cherry-pick r254301. rdar://problem/58346124"
- 3:33 PM Changeset in webkit [254308] by
-
- 2 edits in trunk/Websites/webkit.org
Add styles to support Web Inspector reference articles
https://bugs.webkit.org/show_bug.cgi?id=206032
Reviewed by Devin Rousso.
- wp-content/themes/webkit/style.css:
(main h1,):
(main h1):
(article .meta .updated):
(article .bodycopy,):
(.image):
(p .image,):
(.image.block):
(.image img):
(.widescreen .image):
(.image.slice-top > picture > img):
(.image.slice-right > picture > img):
(.image.slice-bottom > picture > img):
(.image.slice-left > picture > img):
(.flex):
(.flex.center):
(figure.widescreen):
(article picture):
(article picture > img):
(.single-web_inspector_page .landing-link):
(.single-web_inspector_page .landing-link:hover):
(@media(prefers-color-scheme:dark) article .invert-brightness,):
(@media(prefers-color-scheme:dark) .table-of-contents label:after):
(article h1,): Deleted.
(article .bodycopy): Deleted.
- 3:27 PM Changeset in webkit [254307] by
-
- 2 edits in trunk/Source/WebKit
Install WebKit framework symlink for more iOS-derived platforms
https://bugs.webkit.org/show_bug.cgi?id=206030
Reviewed by Andy Estes.
- WebKit.xcodeproj/project.pbxproj:
- 3:18 PM Changeset in webkit [254306] by
-
- 2 edits in trunk/Source/WebKit
Remove AGXCompilerService access from the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=206020
<rdar://problem/58451395>
Reviewed by Per Arne Vollan.
Now that we generate a dynamic extension for 'com.apple.AGXCompilerService', we should remove the
blanket allow rule from the sandbox.
Covered by existing tests.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 2:59 PM Changeset in webkit [254305] by
-
- 3 edits2 adds in branches/safari-609-branch
Cherry-pick r254301. rdar://problem/58346124
REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
- page/SecurityOrigin.cpp:
LayoutTests:
- fast/url/data-url-large-expected.txt: Added.
- fast/url/data-url-large.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:58 PM Changeset in webkit [254304] by
-
- 1 copy in tags/Safari-608.5.7.3.1
Tag Safari-608.5.7.3.1.
- 2:57 PM Changeset in webkit [254303] by
-
- 6 edits1 copy1 add in trunk/Source/bmalloc
[bmalloc] Extract constants from Heap and share it among Heaps.
https://bugs.webkit.org/show_bug.cgi?id=205834
Reviewed by Geoffrey Garen.
A Heap has many constants (m_vmPageSizePhysical, m_smallLineMetadata and m_pageClasses) and they
are dependent only to vmPageSizePhysical and identical for all Heaps.
Extracting them into a class and make it sharable among heaps. Also this is the first step for
making Heap constants to actualconstexpr.
- CMakeLists.txt: Added HeapConstants.cpp.
- bmalloc.xcodeproj/project.pbxproj: Ditto.
- bmalloc/Heap.cpp: Referencing HeapConstants object to get information.
(bmalloc::Heap::Heap):
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::allocateSmallBumpRangesByMetadata):
(bmalloc::Heap::allocateSmallBumpRangesByObject):
(bmalloc::Heap::initializeLineMetadata): Moved to HeapConstants.cpp.
(bmalloc::Heap::initializePageMetadata): Moved to HeapConstants.cpp.
- bmalloc/Heap.h: Extract metadata initialization and member variables.
- bmalloc/HeapConstants.cpp: Added.
(bmalloc::HeapConstants::HeapConstants):
(bmalloc::HeapConstants::initializeLineMetadata):
(bmalloc::HeapConstants::initializePageMetadata):
- bmalloc/HeapConstants.h:
(bmalloc::HeapConstants::pageClass const):
(bmalloc::HeapConstants::smallLineCount const):
(bmalloc::HeapConstants::startOffset):
(bmalloc::HeapConstants::objectCount):
(bmalloc::HeapConstants::lineMetadata):
- 2:57 PM Changeset in webkit [254302] by
-
- 2 edits in trunk/Tools
Move macOS Test262, JSC, and perf queues to Catalina
https://bugs.webkit.org/show_bug.cgi?id=205971
Unreviewed infrastructure fix.
- BuildSlaveSupport/build.webkit.org-config/config.json: Add missing scheduler for perf queue.
- 2:41 PM Changeset in webkit [254301] by
-
- 3 edits2 adds in trunk
REGRESSION (r253662): Large Data URLs are not being handled properly
https://bugs.webkit.org/show_bug.cgi?id=205979
<rdar://problem/58346124>
Reviewed by Youenn Fablet.
Source/WebCore:
The URL size limitation added in r253662 was too low. We should bump it to handle
reasonable data URI sizes.
Test: fast/url/data-url-large.html.
- page/SecurityOrigin.cpp:
LayoutTests:
- fast/url/data-url-large-expected.txt: Added.
- fast/url/data-url-large.html: Added.
- 2:38 PM Changeset in webkit [254300] by
-
- 1 copy in tags/Safari-609.1.14
Tag Safari-609.1.14.
- 2:36 PM Changeset in webkit [254299] by
-
- 2 edits in trunk/Source/WebKit
Fix a tiny logging mistake in launchProcess
https://bugs.webkit.org/show_bug.cgi?id=206026
Reviewed by Wenson Hsieh.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
- 2:25 PM Changeset in webkit [254298] by
-
- 2 edits in trunk/Source/WebCore
Update status for Web SQL Database
https://bugs.webkit.org/show_bug.cgi?id=205304
Patch by Eamon Sisk <esisk@apple.com> on 2020-01-09
Reviewed by Darin Adler.
The status for Web SQL Database is out of date.
- features.json:
- 2:19 PM Changeset in webkit [254297] by
-
- 2 edits in trunk/Websites/webkit.org
Fix redundant anchor tags when generating table of contents
https://bugs.webkit.org/show_bug.cgi?id=206016
Reviewed by Devin Rousso.
- wp-content/plugins/table-of-contents.php:
- 2:01 PM Changeset in webkit [254296] by
-
- 24 edits2 copies2 adds in trunk
Resource Load Statistics: Add timing information to WebPageProxy::logFrameNavigation() to detect delayed client-side redirects
https://bugs.webkit.org/show_bug.cgi?id=205522
<rdar://problem/58125759>
Reviewed by Chris Dumez.
Source/WebKit:
The purpose of this patch is to capture navigations that happen programmatically
after the document has loaded. These are delayed redirects and should be counted
as redirects in ITP.
To achieve this, a timestamp is captured in
WebPageProxy::didFinishDocumentLoadForFrame() to be able to calculate how much time
has passed since that timestamp in the IPC sent from
WebPageProxy::logFrameNavigation(). The IPC also gets information on whether
userInitiatedActivity exists so that ITP can decide whether to treat the navigation
as triggered by the user or not.
A new test was added and existing test expectations were updated.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation):
Now takes the extra parameters delayAfterMainFrameDocumentLoad
and wasPotentiallyInitiatedByUser.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::logFrameNavigation):
Now takes the extra parameters delayAfterMainFrameDocumentLoad
and wasPotentiallyInitiatedByUser.
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
Now takes the extra parameters delayAfterMainFrameDocumentLoad
and wasPotentiallyInitiatedByUser.
The deleted WebResourceLoadStatisticsStore::logFrameNavigation() was dead code.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::logFrameNavigation):
Now takes the extra parameters delayAfterMainFrameDocumentLoad
and wasPotentiallyInitiatedByUser.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _resourceLoadStatisticsSetShouldSubmitTelemetry:]): Deleted.
Dead code.
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
Now captures a timestamp.
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Removed dead code.
(WebKit::WebPageProxy::logFrameNavigation):
Now sends the diff between now and the timestamp captured in
WebPageProxy::didFinishDocumentLoadForFrame().
- UIProcess/WebPageProxy.h:
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformInitialize):
Removed dead code.
(WebKit::WebsiteDataStore::platformDestroy):
Removed dead code.
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resourceLoadStatistics const): Deleted.
Dead code.
Tools:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):
Removed dead code.
LayoutTests:
Results updated with additional data now that delayed redirects are captured.
- http/tests/resourceLoadStatistics/log-cross-site-load-with-link-decoration-database-expected.txt:
- http/tests/resourceLoadStatistics/log-cross-site-load-with-link-decoration-expected.txt:
- http/tests/resourceLoadStatistics/log-delayed-client-side-redirects-database-expected.txt: Added.
- http/tests/resourceLoadStatistics/log-delayed-client-side-redirects-database.html: Added.
- http/tests/resourceLoadStatistics/log-delayed-client-side-redirects-expected.txt: Added.
- http/tests/resourceLoadStatistics/log-delayed-client-side-redirects.html: Added.
- http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database-expected.txt:
- http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt:
- 1:56 PM Changeset in webkit [254295] by
-
- 4 edits in trunk/Source/WebCore
Implement encoders and decoders for more font-related entities
https://bugs.webkit.org/show_bug.cgi?id=205952
Reviewed by Dean Jackson.
Implement encode/decode template methods for more font-rendering-related objects in WebCore.
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::encode const):
(WebCore::FontDescription::decode):
- platform/graphics/FontSelectionAlgorithm.h:
(WebCore::FontSelectionValue::encode const):
(WebCore::FontSelectionValue::decode):
(WebCore::FontSelectionRange::encode const):
(WebCore::FontSelectionRange::decode):
(WebCore::FontSelectionSpecifiedCapabilities::encode const):
(WebCore::FontSelectionSpecifiedCapabilities::decode):
- platform/graphics/FontTaggedSettings.h:
(WebCore::FontTaggedSetting<T>::encode const):
(WebCore::FontTaggedSetting<T>::decode):
We cast from
uint8_ttocharand back when encoding and decoding because IPC encoders are currently only
able to encodeuint8_ts, rather thanchars. We could alternately address this in a future patch by adding
encode/decode functions forchartoEncoder.h.
(WebCore::FontTaggedSettings<T>::encode const):
(WebCore::FontTaggedSettings<T>::decode):
- 1:39 PM Changeset in webkit [254294] by
-
- 2 edits in trunk/Source/WebKit
WKAccessibilityWebPageObject should use Accessibility::retrieveValueFromMainThread.
https://bugs.webkit.org/show_bug.cgi?id=206009
Reviewed by Chris Fleizach.
- WKAccessibilityWebPageObject now uses Accessibility::retrieveValueFromMainThread,
which is consistent with WebAccessibilityObjectWrapper.
- It also uses a captured protectedSelf to ensure the object is alive
when the lambda is invoked on the main thread.
- Added nullity check for m_page in accessibilityAttributeSizeValue,
which is a potential crasher in the multithreaded mode.
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WKAccessibilityWebPageObject convertScreenPointToRootView:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeSizeValue]):
(-[WKAccessibilityWebPageObject accessibilityAttributePositionValue]):
(-[WKAccessibilityWebPageObject accessibilityDataDetectorValue:point:]):
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):
(retrieveAccessibilityValueFromMainThread): Not needed since it uses now the one in Accessibility nasespace.
- 1:32 PM Changeset in webkit [254293] by
-
- 9 edits in trunk/Source
Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable
https://bugs.webkit.org/show_bug.cgi?id=205966
<rdar://problem/58425000>
Reviewed by Brent Fulgham.
To get default on behavior, experimental features in the network process need to be
turned from enable flags to disable flags. This patch does that for the experimental
website data removal flag.
Source/WebCore:
No new tests. This change just reverses the interpretation of a flag.
- page/Settings.yaml:
Source/WebKit:
This change also aligns the init values of the setting to match the default.
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkSession.h:
- NetworkProcess/NetworkSessionCreationParameters.h:
- Shared/WebPreferences.yaml:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- 1:10 PM Changeset in webkit [254292] by
-
- 2 edits in trunk/Source/WebKit
Set the title for images so it will be correctly displayed in UIContextMenus
https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>
Reviewed by Dean Jackson.
Need to set the title text for images.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView continueContextMenuInteraction:]):
- 12:52 PM Changeset in webkit [254291] by
-
- 4 edits3 adds in trunk
ImageBitmap can't be created in workers in some cases due to main-thread assert in ImageSource
https://bugs.webkit.org/show_bug.cgi?id=205850
Patch by Chris Lord <Chris Lord> on 2020-01-09
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-in-worker-transfer-expected.txt: Added.
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-in-worker-transfer.html: Added.
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-worker.js: Added.
Source/WebCore:
Assert that we're destroyed on the creation thread, rather than on the
main thread. This is required for ImageBitmap creation in workers in
debug builds.
Test: imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-in-worker-transfer.html
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::startAsyncDecodingQueue):
- platform/graphics/ImageSource.h:
- 12:35 PM Changeset in webkit [254290] by
-
- 2 edits in trunk/Tools
Race condition in run-jsc-stress-tests chdir
https://bugs.webkit.org/show_bug.cgi?id=205910
Patch by Paulo Matos <Paulo Matos> on 2020-01-09
Reviewed by Keith Miller.
chdir block was in a race condition when multiple remotes are used.
As an example of this see line 3345 of:
https://ews-build.webkit.org/#/builders/26/builds/5719/steps/12/logs/stdio
quote error:
Tools/Scripts/run-jsc-stress-tests:1946: warning: conflicting chdir during another chdir block
Multiple threads should not enter a chdir block simultaneously, therefore we need
a mutex to guard it. More information is here:
- Scripts/run-jsc-stress-tests:
- 12:24 PM Changeset in webkit [254289] by
-
- 2 edits in trunk/Tools
Move commit queue to Mojave
https://bugs.webkit.org/show_bug.cgi?id=205972
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
- 12:18 PM Changeset in webkit [254288] by
-
- 3 edits in trunk/Source/WebCore
[Cocoa] persistent-usage-record message fails first time; succeeds subsequent times
https://bugs.webkit.org/show_bug.cgi?id=205970
<rdar://problem/57785647>
Reviewed by Eric Carlson.
The AVContentKeySession is created too early; before the CDM has a chance to provide the storage path
for persistent usage records. Delay creation of the AVCKS until it's actually needed during the first
license request.
Drive-by fix: fix the exceptional case where a PUR session is closed but PUR data isn't available; send
a null message rather than an empty array.
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): Deleted.
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): Deleted.
- 12:08 PM Changeset in webkit [254287] by
-
- 2 edits in trunk/Source/WebKit
Fullscreen videos do not enter PiP in first tap
https://bugs.webkit.org/show_bug.cgi?id=205986
Reviewed by Eric Carlson.
This patch essentially reverts the fix for webkit.org/b/204461.
The fix for webkit.org/b/204461 depends on a fix in AVKit along
with a corresponding update in WebKit (webkit.org/b/204979).
We will need to reapply the fix for webkit.org/b/204461 after they are landed.
- WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
- 12:01 PM Changeset in webkit [254286] by
-
- 4 edits in trunk/Source/WebKit
ITP API classes need WK_CLASS_AVAILABLE tags
https://bugs.webkit.org/show_bug.cgi?id=205969
<rdar://problem/58427147>
Reviewed by Dean Jackson.
- UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
- UIProcess/API/Cocoa/_WKResourceLoadStatisticsThirdParty.h:
- WebKit.xcodeproj/project.pbxproj:
This updates the header file targets from Project to Private.
- 11:52 AM Changeset in webkit [254285] by
-
- 3 edits2 copies1 add in trunk/LayoutTests
Bad baseline for Catalina on xhr web-platform-tests imported in r254154
https://bugs.webkit.org/show_bug.cgi?id=205991
Unreviewed, fix some Catalina builds after r254154.
LayoutTests/imported/w3c:
- web-platform-tests/xhr/getallresponseheaders-expected.txt:
LayoutTests:
- platform/mac-highsierra/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt.
- platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt.
- 11:49 AM Changeset in webkit [254284] by
-
- 3 edits2 adds in branches/safari-608.5.7.3-branch
Cherry-pick r254220. rdar://problem/58450166
Fix specification violation in Font Loading API
https://bugs.webkit.org/show_bug.cgi?id=205901
<rdar://problem/58083743>
Reviewed by Brent Fulgham.
Source/WebCore:
Our Font Loading API does not comply with the spec:
If the parsed value is a CSS-wide keyword, return a syntax error.
Rather than crashing, we should return a syntax error.
Test: fast/text/font-loading-global-keyword.html
- css/CSSFontFaceSet.cpp: (WebCore::computeFontSelectionRequest): (WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
LayoutTests:
Test all the entry points to the CSS Font Loading API that accept CSS keywords.
- fast/text/font-loading-global-keyword-expected.txt: Added.
- fast/text/font-loading-global-keyword.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:40 AM Changeset in webkit [254283] by
-
- 7 edits in branches/safari-608.5.7.3-branch/Source
Versioning.
- 11:27 AM Changeset in webkit [254282] by
-
- 1 copy in branches/safari-608.5.7.3-branch
New branch.
- 11:24 AM Changeset in webkit [254281] by
-
- 3 edits in trunk/Source/WebCore
Fix iOS build.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
- 11:13 AM Changeset in webkit [254280] by
-
- 5 edits in trunk/Tools
Move macOS Test262, JSC, and perf queues to Catalina
https://bugs.webkit.org/show_bug.cgi?id=205971
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.macos-highsierra img.logo): Deleted.
- BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
- 11:12 AM Changeset in webkit [254279] by
-
- 3 edits in trunk/LayoutTests
[WebGL] Skip all webgl/2.0.0 tests, as ANGLE switch obsoletes all old expectated results
https://bugs.webkit.org/show_bug.cgi?id=205988
Unreviewed test gardening.
The WebGL dedicated queue will continue to run failing tests.
Normal bots will only enable 2.0.0 tests after development work confirms they are passing with ANGLE.
- TestExpectations:
- platform/mac/TestExpectations:
- 10:56 AM Changeset in webkit [254278] by
-
- 3 edits2 adds in branches/safari-608-branch
Cherry-pick r254220. rdar://problem/58429231
Fix specification violation in Font Loading API
https://bugs.webkit.org/show_bug.cgi?id=205901
<rdar://problem/58083743>
Reviewed by Brent Fulgham.
Source/WebCore:
Our Font Loading API does not comply with the spec:
If the parsed value is a CSS-wide keyword, return a syntax error.
Rather than crashing, we should return a syntax error.
Test: fast/text/font-loading-global-keyword.html
- css/CSSFontFaceSet.cpp: (WebCore::computeFontSelectionRequest): (WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
LayoutTests:
Test all the entry points to the CSS Font Loading API that accept CSS keywords.
- fast/text/font-loading-global-keyword-expected.txt: Added.
- fast/text/font-loading-global-keyword.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:39 AM Changeset in webkit [254277] by
-
- 9 edits in trunk/Source/WebCore
[LFC] Rename UsedHorizontal(Vertical)Values to OverrideHorizontal(Vertical)values
https://bugs.webkit.org/show_bug.cgi?id=206008
<rdar://problem/58443375>
Reviewed by Antti Koivisto.
These structure are a mixture of specified and used values.
What these specified/used values mean in this context is that they override the default input
values for the "compute geometry" functions (e.g. computing the width of a floating box follows
the same set of steps as computing the width of an inline replaced box. So whenever we need to
compute the width of a floating box, we could just call the computeInlineReplacedWidth() function.
However their horizontal margin computations are different and since width and horizontal margins are being computed together,
we need to make sure that inlineReplacedWidthAndMargin() takes a set of pre-computed margin values
and uses them while computing the width value. Same applies to min/max-width/heigh computations.)
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases const):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const):
- layout/LayoutUnits.h:
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin const):
- 10:36 AM Changeset in webkit [254276] by
-
- 7 edits in branches/safari-608-branch/Source
Versioning.
- 10:34 AM Changeset in webkit [254275] by
-
- 7 edits in branches/safari-608.5.0.2-branch/Source
Versioning.
- 10:34 AM Changeset in webkit [254274] by
-
- 4 edits in trunk/Source/WebCore
[LFC] Add missing HorizontalConstraints/VerticalConstraints
https://bugs.webkit.org/show_bug.cgi?id=205987
<rdar://problem/58432728>
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
- layout/inlineformatting/InlineFormattingContext.h:
- 10:33 AM Changeset in webkit [254273] by
-
- 2 edits in branches/safari-608.5.0.2-branch/Source/WebKit
Apply patch. rdar://problem/58396582
- 10:30 AM Changeset in webkit [254272] by
-
- 11 edits in trunk/Source/WebCore
[LFC] Decouple UsedHorizontal(Vertical)Values and Horizontal(Vertical)Constraints
https://bugs.webkit.org/show_bug.cgi?id=205985
<rdar://problem/58431985>
Reviewed by Antti Koivisto.
Some geometry functions need only the constraint values and some need both the constraint and the used values.
Inflow:
horizontal:
width and margin: needs horizontal constraint (containing block width) and the used values (min/max width).
position: needs horizontal constraint (containing block's content box left).
vertical:
height and margin: needs horizontal constraint to resolve margin values and the used values (min/max height).
position: needs vertical constraint (containing block's content box top).
Out-of-flow:
horizontal geometry: horizontal constraint and the used value.
vertical geometry: horizontal and vertical constraint and the vertical used value.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const):
- layout/LayoutUnits.h:
(WebCore::Layout::UsedHorizontalValues::UsedHorizontalValues): Deleted.
(WebCore::Layout::UsedVerticalValues::UsedVerticalValues): Deleted.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::InlineFormattingContext::computeHorizontalAndVerticalGeometry):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin const):
- 10:25 AM Changeset in webkit [254271] by
-
- 14 edits in trunk/Source/WebCore
[LFC] Use Horizontal/VerticalConstraints wherever possible
https://bugs.webkit.org/show_bug.cgi?id=205973
<rdar://problem/58426772>
Reviewed by Antti Koivisto.
Let's pass in Horizontal/VerticalConstraints struct instead of the UsedHorizontal/VerticalValues
to the "compute geometry" functions when only the constraint values are needed/available.
This is also in preparation for decoupling used and constraint values.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::computeBorderAndPadding):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases const):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset const):
(WebCore::Layout::FormattingContext::Geometry::computedPadding const):
(WebCore::Layout::FormattingContext::Geometry::computedHorizontalMargin const):
(WebCore::Layout::FormattingContext::Geometry::computedVerticalMargin const):
- layout/FormattingContextQuirks.cpp:
(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition const):
(WebCore::Layout::BlockFormattingContext::Geometry::staticHorizontalPosition const):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::InlineFormattingContext::computeHorizontalAndVerticalGeometry):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
(WebCore::Layout::InlineFormattingContext::computeHorizontalMargin):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin const):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):
- 10:20 AM Changeset in webkit [254270] by
-
- 14 edits in trunk/Source/WebCore
[LFC] Move Constraints struct out of UsedHorizontal(Vertical)values.
https://bugs.webkit.org/show_bug.cgi?id=205944
<rdar://problem/58415893>
Reviewed by Antti Koivisto.
This is in preparation for decoupling used values and constraints.
Certain "compute geometry" functions only need the constraints while others only need the used values.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::computeBorderAndPadding):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset const):
(WebCore::Layout::FormattingContext::Geometry::computedPadding const):
(WebCore::Layout::FormattingContext::Geometry::computedHorizontalMargin const):
(WebCore::Layout::FormattingContext::Geometry::computedVerticalMargin const):
(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForOutOfFlow):
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForOutOfFlow):
(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForInFlow):
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForInFlow):
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
- layout/LayoutUnits.h:
(WebCore::Layout::UsedHorizontalValues::UsedHorizontalValues):
(WebCore::Layout::UsedVerticalValues::UsedVerticalValues):
(WebCore::Layout::UsedHorizontalValues::Constraints::Constraints): Deleted.
(WebCore::Layout::UsedVerticalValues::Constraints::Constraints): Deleted.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition const):
(WebCore::Layout::BlockFormattingContext::Geometry::staticHorizontalPosition const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::computedTextIndent const):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::computePreferredWidthForColumns):
- layout/tableformatting/TableFormattingContext.h:
- 10:14 AM Changeset in webkit [254269] by
-
- 10 edits in trunk/Source/WebCore
[LFC] FormattingContext::layoutInFlowContent should take UsedVerticalValues::Constraints
https://bugs.webkit.org/show_bug.cgi?id=205937
<rdar://problem/58412170>
Reviewed by Antti Koivisto.
This is in preparation for not needing to query the containing block for constraint information.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
- layout/FormattingContext.h:
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
- layout/blockformatting/BlockFormattingContext.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
- layout/tableformatting/TableFormattingContext.h:
- 10:06 AM Changeset in webkit [254268] by
-
- 4 edits in trunk/Source/WebCore
[LFC][BFC] Start passing in vertical constraints to compute* functions
https://bugs.webkit.org/show_bug.cgi?id=205934
<rdar://problem/58411387>
Reviewed by Antti Koivisto.
This is in preparation for not needing to query the containing block for constraint information.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForInFlow):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- 10:02 AM Changeset in webkit [254267] by
-
- 2 edits in trunk/Source/WebCore
Reformat FrameView logging
https://bugs.webkit.org/show_bug.cgi?id=205984
<rdar://problem/58431722>
Reviewed by Brent Fulgham.
Update the format used by FrameView in its RELEASE_LOG logging. Use
the format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:
<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>
So, for example:
0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame
becomes:
0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame
No new tests -- no new or changed functionality.
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
- 9:59 AM Changeset in webkit [254266] by
-
- 4 edits in trunk/Source/WebCore
[LFC] computeHeightAndMargin/placeInFlowPositionedChildren should take UsedHorizontalValues::Constraints
https://bugs.webkit.org/show_bug.cgi?id=205904
<rdar://problem/58398413>
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::move):
- 9:54 AM Changeset in webkit [254265] by
-
- 3 edits in trunk/Source/WebCore
[LFC][BFC] BlockFormattingContext::layoutFormattingContextRoot should take the horizontal constraints
https://bugs.webkit.org/show_bug.cgi?id=205894
<rdar://problem/58391798>
Reviewed by Antti Koivisto.
layoutFormattingContextRoot should not need to read the containing block's geometry for constraints information.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
- layout/blockformatting/BlockFormattingContext.h:
- 9:37 AM Changeset in webkit [254264] by
-
- 10 edits in trunk/Source/WebCore
IndexedDB: stop cursor prefetching when size of cached records reaches limit
https://bugs.webkit.org/show_bug.cgi?id=205909
Reviewed by Alex Christensen.
SQLiteIDBCursor was allowed to prefetch 8 cursor records at most. This patch introduces a new rule for better
flexibility. Prefetch will stop if either of the following conditions is true:
- number of prefetched records is not less than 128
- size of prefeteched records is not less than 8MB
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::size const):
- Modules/indexeddb/IDBKeyData.h:
- Modules/indexeddb/IDBValue.cpp:
(WebCore::IDBValue::size const):
- Modules/indexeddb/IDBValue.h:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::prefetch):
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::fetch):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::prefetchCursor):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/IDBCursorRecord.h:
(WebCore::IDBCursorRecord::size const):
- 9:36 AM Changeset in webkit [254263] by
-
- 11 edits in trunk/Source/WebCore
[LFC] FormattingContext::layoutOutOfFlowContent should take horizontal and vertical constraints.
https://bugs.webkit.org/show_bug.cgi?id=205892
<rdar://problem/58389802>
Reviewed by Antti Koivisto.
The caller should provide the horizontal/vertical constraints for the the out-of-flow boxes. It helps to make sure that we don't access geometry information
in the parent formatting context.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForOutOfFlow):
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForOutOfFlow):
(WebCore::Layout::FormattingContext::Geometry::horizontalConstraintsForInFlow):
(WebCore::Layout::FormattingContext::Geometry::verticalConstraintsForInFlow):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalConstraints): Deleted.
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalConstraints): Deleted.
(WebCore::Layout::FormattingContext::Geometry::inFlowHorizontalConstraints): Deleted.
(WebCore::Layout::FormattingContext::Geometry::inFlowVerticalConstraints): Deleted.
- layout/FormattingContextQuirks.cpp:
(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
- 8:49 AM Changeset in webkit [254262] by
-
- 5 edits in trunk
Unreviewed, rolling out r254234.
https://bugs.webkit.org/show_bug.cgi?id=206011
Broke production builds (Requested by ap on #webkit).
Reverted changeset:
"build-jsc should invoke make instead of calling xcodebuild
directly"
https://bugs.webkit.org/show_bug.cgi?id=205960
https://trac.webkit.org/changeset/254234
- 8:47 AM Changeset in webkit [254261] by
-
- 3 edits in trunk/LayoutTests
REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205886
<rdar://problem/58387910>
Reviewed by Chris Dumez.
Make sure registrations are stored on disk before crashing the network process.
- http/wpt/service-workers/persistent-importScripts.html:
- platform/mac-wk2/TestExpectations:
- 8:22 AM Changeset in webkit [254260] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205893
<rdar://problem/58391046>
Reviewed by Eric Carlson.
- webrtc/video-autoplay.html:
Speculative fix as I am not able to reproduce locally.
Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element.
We should therefore ensure that the video element is paused before calling getUserMedia.
- 7:58 AM Changeset in webkit [254259] by
-
- 12 edits in trunk/Source
REGRESSION: [ Mac wk2 ] fast/mediastream/captureInGPUProcess.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205873
<rdar://problem/58380638>
Reviewed by Eric Carlson.
Source/WebCore:
Beef up reporting of error cases when device is not found for a getUserMedia call.
Covered by unflaked test.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::create):
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::create):
- platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockRealtimeAudioSource::create):
- platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
(WebCore::MockRealtimeVideoSource::create):
- platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::create):
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::create):
Source/WebKit:
GPUProcess and UIProcess were sometimes getting out of sync with regards to using mock devices or real capture devices.
This ended up in GPUProcess trying to find mock devices based on real device IDs.
Fix this issue by storing this bool value in GPUProcessProxy and send IPC to GPUProcess whenver this value is changed.
Update GPUProcessProxy value whenever UserMediaPermissionRequestManagerProxy is asked to sync this value.
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::singleton):
(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::GPUProcessProxy::setUseMockCaptureDevices):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):
- 7:31 AM Changeset in webkit [254258] by
-
- 130 edits in trunk/LayoutTests
Unreviewed WPE gardening: rebaseline several tests after r254044.
- platform/wpe/css1/basic/containment-expected.txt:
- platform/wpe/css1/basic/contextual_selectors-expected.txt:
- platform/wpe/css1/basic/grouping-expected.txt:
- platform/wpe/css1/basic/id_as_selector-expected.txt:
- platform/wpe/css1/basic/inheritance-expected.txt:
- platform/wpe/css1/box_properties/border-expected.txt:
- platform/wpe/css1/box_properties/border_bottom-expected.txt:
- platform/wpe/css1/box_properties/border_bottom_inline-expected.txt:
- platform/wpe/css1/box_properties/border_bottom_width-expected.txt:
- platform/wpe/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/wpe/css1/box_properties/border_color-expected.txt:
- platform/wpe/css1/box_properties/border_color_inline-expected.txt:
- platform/wpe/css1/box_properties/border_inline-expected.txt:
- platform/wpe/css1/box_properties/border_left-expected.txt:
- platform/wpe/css1/box_properties/border_left_inline-expected.txt:
- platform/wpe/css1/box_properties/border_left_width-expected.txt:
- platform/wpe/css1/box_properties/border_left_width_inline-expected.txt:
- platform/wpe/css1/box_properties/border_right-expected.txt:
- platform/wpe/css1/box_properties/border_right_inline-expected.txt:
- platform/wpe/css1/box_properties/border_right_width-expected.txt:
- platform/wpe/css1/box_properties/border_right_width_inline-expected.txt:
- platform/wpe/css1/box_properties/border_style-expected.txt:
- platform/wpe/css1/box_properties/border_style_inline-expected.txt:
- platform/wpe/css1/box_properties/border_top-expected.txt:
- platform/wpe/css1/box_properties/border_top_inline-expected.txt:
- platform/wpe/css1/box_properties/border_top_width-expected.txt:
- platform/wpe/css1/box_properties/border_top_width_inline-expected.txt:
- platform/wpe/css1/box_properties/border_width-expected.txt:
- platform/wpe/css1/box_properties/border_width_inline-expected.txt:
- platform/wpe/css1/box_properties/clear-expected.txt:
- platform/wpe/css1/box_properties/clear_float-expected.txt:
- platform/wpe/css1/box_properties/float-expected.txt:
- platform/wpe/css1/box_properties/float_elements_in_series-expected.txt:
- platform/wpe/css1/box_properties/float_margin-expected.txt:
- platform/wpe/css1/box_properties/height-expected.txt:
- platform/wpe/css1/box_properties/margin-expected.txt:
- platform/wpe/css1/box_properties/margin_bottom-expected.txt:
- platform/wpe/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/wpe/css1/box_properties/margin_inline-expected.txt:
- platform/wpe/css1/box_properties/margin_left-expected.txt:
- platform/wpe/css1/box_properties/margin_left_inline-expected.txt:
- platform/wpe/css1/box_properties/margin_right-expected.txt:
- platform/wpe/css1/box_properties/margin_right_inline-expected.txt:
- platform/wpe/css1/box_properties/margin_top-expected.txt:
- platform/wpe/css1/box_properties/margin_top_inline-expected.txt:
- platform/wpe/css1/box_properties/padding-expected.txt:
- platform/wpe/css1/box_properties/padding_bottom-expected.txt:
- platform/wpe/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/wpe/css1/box_properties/padding_inline-expected.txt:
- platform/wpe/css1/box_properties/padding_left-expected.txt:
- platform/wpe/css1/box_properties/padding_left_inline-expected.txt:
- platform/wpe/css1/box_properties/padding_right-expected.txt:
- platform/wpe/css1/box_properties/padding_right_inline-expected.txt:
- platform/wpe/css1/box_properties/padding_top-expected.txt:
- platform/wpe/css1/box_properties/padding_top_inline-expected.txt:
- platform/wpe/css1/box_properties/width-expected.txt:
- platform/wpe/css1/cascade/cascade_order-expected.txt:
- platform/wpe/css1/cascade/important-expected.txt:
- platform/wpe/css1/classification/display-expected.txt:
- platform/wpe/css1/classification/list_style-expected.txt:
- platform/wpe/css1/classification/list_style_image-expected.txt:
- platform/wpe/css1/classification/list_style_position-expected.txt:
- platform/wpe/css1/classification/list_style_type-expected.txt:
- platform/wpe/css1/classification/white_space-expected.txt:
- platform/wpe/css1/color_and_background/background-expected.txt:
- platform/wpe/css1/color_and_background/background_attachment-expected.txt:
- platform/wpe/css1/color_and_background/background_color-expected.txt:
- platform/wpe/css1/color_and_background/background_image-expected.txt:
- platform/wpe/css1/color_and_background/background_position-expected.txt:
- platform/wpe/css1/color_and_background/background_repeat-expected.txt:
- platform/wpe/css1/color_and_background/color-expected.txt:
- platform/wpe/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/wpe/css1/font_properties/font-expected.txt:
- platform/wpe/css1/font_properties/font_family-expected.txt:
- platform/wpe/css1/font_properties/font_size-expected.txt:
- platform/wpe/css1/font_properties/font_style-expected.txt:
- platform/wpe/css1/font_properties/font_variant-expected.txt:
- platform/wpe/css1/font_properties/font_weight-expected.txt:
- platform/wpe/css1/formatting_model/canvas-expected.txt:
- platform/wpe/css1/formatting_model/floating_elements-expected.txt:
- platform/wpe/css1/formatting_model/height_of_lines-expected.txt:
- platform/wpe/css1/formatting_model/inline_elements-expected.txt:
- platform/wpe/css1/formatting_model/replaced_elements-expected.txt:
- platform/wpe/css1/formatting_model/vertical_formatting-expected.txt:
- platform/wpe/css1/pseudo/anchor-expected.txt:
- platform/wpe/css1/pseudo/firstletter-expected.txt:
- platform/wpe/css1/pseudo/firstline-expected.txt:
- platform/wpe/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/wpe/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/wpe/css1/text_properties/letter_spacing-expected.txt:
- platform/wpe/css1/text_properties/line_height-expected.txt:
- platform/wpe/css1/text_properties/text_align-expected.txt:
- platform/wpe/css1/text_properties/text_decoration-expected.txt:
- platform/wpe/css1/text_properties/text_indent-expected.txt:
- platform/wpe/css1/text_properties/text_transform-expected.txt:
- platform/wpe/css1/text_properties/vertical_align-expected.txt:
- platform/wpe/css1/text_properties/word_spacing-expected.txt:
- platform/wpe/css1/units/color_units-expected.txt:
- platform/wpe/css1/units/length_units-expected.txt:
- platform/wpe/css1/units/percentage_units-expected.txt:
- platform/wpe/css1/units/urls-expected.txt:
- platform/wpe/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
- platform/wpe/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
- platform/wpe/fast/css/empty-pseudo-class-expected.txt:
- platform/wpe/fast/css/first-child-pseudo-class-expected.txt:
- platform/wpe/fast/css/last-child-pseudo-class-expected.txt:
- platform/wpe/fast/css/only-child-pseudo-class-expected.txt:
- platform/wpe/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/wpe/fast/html/listing-expected.txt:
- platform/wpe/fast/invalid/junk-data-expected.txt:
- platform/wpe/fast/invalid/missing-end-tag-expected.txt:
- platform/wpe/fast/parser/xhtml-alternate-entities-expected.txt:
- platform/wpe/fast/table/border-collapsing/004-expected.txt:
- platform/wpe/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/wpe/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/wpe/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/wpe/svg/custom/bug45331-expected.txt:
- platform/wpe/svg/custom/junk-data-expected.txt:
- platform/wpe/svg/custom/missing-xlink-expected.txt:
- platform/wpe/svg/custom/path-bad-data-expected.txt:
- platform/wpe/svg/custom/use-font-face-crash-expected.txt:
- platform/wpe/svg/hixie/error/012-expected.txt:
- platform/wpe/tables/mozilla/bugs/45621-expected.txt:
- platform/wpe/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/wpe/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- 6:32 AM Changeset in webkit [254257] by
-
- 3 edits in trunk/Source/WebCore/PAL
Don't softlink AVCapture classes on watchOS or tvOS
https://bugs.webkit.org/show_bug.cgi?id=205974
<rdar://problem/45508044>
Reviewed by Jon Lee.
- pal/cocoa/AVFoundationSoftLink.h:
- pal/cocoa/AVFoundationSoftLink.mm:
- 6:31 AM Changeset in webkit [254256] by
-
- 4 edits1 copy1 add in trunk
RemoteVideoSample should be able to support canvas video samples
https://bugs.webkit.org/show_bug.cgi?id=205922
Reviewed by Eric Carlson.
Source/WebCore:
Canvas capture is producing video samples that are not IOSurface backed.
This makes it impossible to send them through IPC via RemoteVideoSample.
We beef up RemoteVideoSample to create an IOSurface for RGBA video samples.
Test: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html
- platform/graphics/RemoteVideoSample.cpp:
(WebCore::transferBGRAPixelBufferToIOSurface):
(WebCore::RemoteVideoSample::create):
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess-expected.txt: Added.
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html: Added.
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html:
Remove no longer valid comment and beef up test in case of assertion failure.
- 6:23 AM Changeset in webkit [254255] by
-
- 2 edits in trunk/WebDriverTests
Unreviewed gardening. Mark imported/w3c/webdriver/tests/switch_to_frame/cross_origin.py::test_nested_cross_origin_iframe as failure
- TestExpectations.json:
- 3:47 AM Changeset in webkit [254254] by
-
- 5 edits in trunk
WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
<https://webkit.org/b/205950>
<rdar://problem/50987831>
Reviewed by Joseph Pecoraro.
Source/WebKit:
- UIProcess/mac/WebPreferencesMac.mm:
(WebKit::WebPreferences::platformInitializeStore):
- Add an @autoreleasepool block around the contents of this method since it generates numerous autoreleased objects when run.
Tools:
- WebKitTestRunner/ios/mainIOS.mm:
(main):
- Add an @autoreleasepool block around a line of code that generates autoreleased objects. These objects would never be released for the life of the process prior to this change.
- WebKitTestRunner/mac/main.mm:
(main):
- Move instantiation of WTR::TestController outside of @autoreleasepool block so the pool can be drained while running tests. Prior to this change, this autoreleasePool would never be drained.
Jan 8, 2020:
- 11:52 PM Changeset in webkit [254253] by
-
- 2 edits in trunk/LayoutTests
Fix test transferToImageBitmap-empty.html after r253099
https://bugs.webkit.org/show_bug.cgi?id=205924
Reviewed by Žan Doberšek.
- http/wpt/offscreen-canvas/transferToImageBitmap-empty.html:
- 10:07 PM Changeset in webkit [254252] by
-
- 71 edits7 adds in trunk
[JSC] Introduce JSArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=204043
Reviewed by Yusuke Suzuki.
JSTests:
- stress/array-iterator-materialize-at-osr-exit.js: Added.
(shouldBe):
(test):
- stress/array-iterator-materialize-one-path.js: Added.
(shouldBe):
(test):
- stress/array-iterator-materialize.js: Added.
(shouldBe):
(test):
- stress/array-iterator-sinking.js: Added.
(shouldBe):
(test):
- stress/array-iterators-next-error-messages.js:
(catch):
- stress/array-iterators-next-with-call.js:
- stress/for-of-iteration.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
- stress/typedarray-functions-with-neutered.js:
(checkProtoFunc):
Source/JavaScriptCore:
This patch introduces JSArrayIterator that changes the iterator object
from a JSFinalObject to an InternalFieldsObject. This makes accessing it
much easier from C++ code and makes the iterator object smaller. It also
means that the JS code for the next function is much simpler and can *almost*
be inlined without shenanigans.
As part of this patch the keys/values/entries functions have been converted to
C++ with intrinsics since that's slightly more efficient in the LLInt/Baseline.
Lastly, this patch also add a custom ISOSubspace for JSArrayIterator objects.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- builtins/ArrayIteratorPrototype.js:
(next):
(globalPrivate.arrayIteratorNextHelper):
(globalPrivate.arrayIteratorValueNext): Deleted.
(globalPrivate.arrayIteratorKeyNext): Deleted.
(globalPrivate.arrayIteratorKeyValueNext): Deleted.
- builtins/ArrayPrototype.js:
(globalPrivate.ArrayIterator): Deleted.
(values): Deleted.
(keys): Deleted.
(entries): Deleted.
- builtins/TypedArrayPrototype.js:
(values): Deleted.
(keys): Deleted.
(entries): Deleted.
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitIsArrayIterator):
- bytecompiler/NodesCodegen.cpp:
(JSC::arrayIteratorInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getArrayIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putArrayIteratorInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isGenerator): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isAsyncGenerator): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isJSArray): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isPromise): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isProxyObject): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isRegExpObject): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isObject): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isDerivedArray): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isMap): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isSet): Deleted.
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isUndefinedOrNull): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGClobbersExitState.cpp:
(JSC::DFG::clobbersExitState):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGHeapLocation.h:
- dfg/DFGMayExit.cpp:
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPhantomNewObject):
(JSC::DFG::Node::convertToPhantomNewArrayIterator):
(JSC::DFG::Node::convertToPhantomCreateActivation):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasObjectMaterializationData):
(JSC::DFG::Node::isPhantomAllocation):
- dfg/DFGNodeType.h:
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGPromotedHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGPromotedHeapLocation.h:
(JSC::DFG::PromotedLocationDescriptor::neededForMaterialization const):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCheckNeutered):
(JSC::DFG::SpeculativeJIT::compileToObjectOrCallObjectConstructor):
(JSC::DFG::SpeculativeJIT::compileNewInternalFieldObject):
(JSC::DFG::SpeculativeJIT::compileNewArrayIterator):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStoreBarrierInsertionPhase.cpp:
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- dfg/DFGValidate.cpp:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckArray):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckNeutered):
(JSC::FTL::DFG::LowerDFGToB3::compileNewInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayIterator):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewInternalFieldObjectImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewInternalFieldObject):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::cloneArrayIteratorObject):
(Inspector::JSInjectedScriptHost::iteratorEntries):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
(JSC::createArrayIteratorObject):
(JSC::arrayProtoFuncValues):
(JSC::arrayProtoFuncEntries):
(JSC::arrayProtoFuncKeys):
- runtime/CommonIdentifiers.h:
- runtime/Intrinsic.cpp:
(JSC::intrinsicName):
- runtime/Intrinsic.h:
- runtime/IterationKind.h:
(): Deleted.
- runtime/JSArrayIterator.cpp: Added.
(JSC::JSArrayIterator::create):
(JSC::JSArrayIterator::createWithInitialValues):
(JSC::JSArrayIterator::createStructure):
(JSC::JSArrayIterator::JSArrayIterator):
(JSC::JSArrayIterator::finishCreation):
(JSC::JSArrayIterator::visitChildren):
- runtime/JSArrayIterator.h: Added.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrayIteratorPrototype const):
(JSC::JSGlobalObject::arrayIteratorStructure const):
- runtime/JSMapIterator.h:
- runtime/JSSetIterator.h:
- runtime/JSType.cpp:
(WTF::printInternal):
- runtime/JSType.h:
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::createTypedArrayIteratorObject):
(JSC::typedArrayViewProtoFuncValues):
(JSC::typedArrayProtoViewFuncEntries):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::JSTypedArrayViewPrototype::finishCreation):
- runtime/VM.cpp:
- runtime/VM.h:
Source/WebCore:
JSDOMIterator should just use the JSC IterationKind enum. Also,
update other files for the enum member name changes.
- bindings/js/JSDOMIterator.h:
(WebCore::IteratorTraits>::asJS):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateIterableDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfacePrototypeFunctionEntriesCaller):
(WebCore::jsTestInterfacePrototypeFunctionKeysCaller):
(WebCore::jsTestInterfacePrototypeFunctionValuesCaller):
- bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::jsTestIterablePrototypeFunctionEntriesCaller):
(WebCore::jsTestIterablePrototypeFunctionKeysCaller):
(WebCore::jsTestIterablePrototypeFunctionValuesCaller):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::jsTestNodePrototypeFunctionEntriesCaller):
(WebCore::jsTestNodePrototypeFunctionKeysCaller):
(WebCore::jsTestNodePrototypeFunctionValuesCaller):
LayoutTests:
Change the labels of iteration kinds to match what JS refers to them as.
- inspector/model/remote-object/iterator-expected.txt:
- inspector/model/remote-object/iterator-large-expected.txt:
- inspector/model/remote-object/iterators-mutated-expected.txt:
- 10:02 PM Changeset in webkit [254251] by
-
- 2 edits in trunk/Tools
build-jsc should work with "testing" and "release+assert" targets
https://bugs.webkit.org/show_bug.cgi?id=205978
Reviewed by Mark Lam.
- Scripts/webkitdirs.pm:
(determineConfiguration):
(determinePassedConfiguration):
- 9:31 PM Changeset in webkit [254250] by
-
- 2 edits14 deletes in trunk/LayoutTests/imported/w3c
Clean up web-platform-tests/resources
https://bugs.webkit.org/show_bug.cgi?id=204652
Reviewed by Dean Jackson.
This patch removes web-platform-tests/resources subdirectories that are
missing in upstream 73d748fca7e8 (import-w3c-tests tool seems to keep them).
Also it removes and marks as "skip" in import-expectations.json two subdirectories:
- web-platform-tests/resources/chromium as it contains Chromium-specific harness we don't use;
- web-platform-tests/resources/test as it contains harness tests we don't run.
In total, this patch removes ~2 MB of unneeded files.
- resources/import-expectations.json:
- web-platform-tests/resources/*: Updated.
- 6:45 PM Changeset in webkit [254249] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Remove some #ifdefs related to iOS port of ANGLE
https://bugs.webkit.org/show_bug.cgi?id=205781
Since the port to the iOS Simulator in
https://bugs.webkit.org/show_bug.cgi?id=205618 , these #ifdefs
should no longer be needed.
Patch by Kenneth Russell <kbr@chromium.org> on 2020-01-08
Reviewed by Dean Jackson.
- src/common/PackedEnums.cpp:
(egl_gl::EGLTextureTargetToTextureType):
- src/libANGLE/validationES2.cpp:
(gl::ValidateFramebufferTexture2D):
- 6:33 PM Changeset in webkit [254248] by
-
- 4 edits in trunk
build-jsc should invoke make instead of calling xcodebuild directly
https://bugs.webkit.org/show_bug.cgi?id=205960
Reviewed by Keith Miller.
.:
- Makefile.shared:
Tools:
This makes build-jsc invoke make instead of directly invoking xcodebuild.
There are some benefits here:
- 'make' is a more standard way to build than build-jsc, so as we make
improvements to the make build (e.g r254234), we'll get the same improvements
in build-jsc.
- There has been a longstanding bug where if you did if you did
build-jsc --release && cd Source/JavaScriptCore && make release
then themake releasecall would rebuild all of JavaScriptCore.
If build-jsc directly invokes make, this issue goes away and allows
the two to interoperate as expected.
- Scripts/build-jsc:
(buildMyProject):
- 6:30 PM Changeset in webkit [254247] by
-
- 2 edits in trunk/JSTests
Unreviewed follow up on r254188. I accidentally included the same test
twice instead of including the two different variants.
- stress/ai-value-mod-should-result-in-constant-int-where-possible.js:
- 6:24 PM Changeset in webkit [254246] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r254235.
https://bugs.webkit.org/show_bug.cgi?id=205981
Broke layout tests (Requested by aakashja_ on #webkit).
Reverted changeset:
"run-webkit-tests: clobber-old-results should remove the
entire results folder"
https://bugs.webkit.org/show_bug.cgi?id=205875
https://trac.webkit.org/changeset/254235
Patch by Commit Queue <commit-queue@webkit.org> on 2020-01-08
- 6:15 PM Changeset in webkit [254245] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Sources: not all injected scripts and style sheets are from extensions
https://bugs.webkit.org/show_bug.cgi?id=205955
Reviewed by Brian Burg.
- UserInterface/Base/Utilities.js:
(isWebKitExtensionScheme): Added.
- UserInterface/Models/CSSStyleSheet.js:
(WI.CSSStyleSheet.prototype.get injected):
- .eslintrc:
Move the logic for detecting an extension injected resource to its own function.
- UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype.treeElementForRepresentedObject):
(WI.SourcesNavigationSidebarPanel.prototype._addStyleSheet):
(WI.SourcesNavigationSidebarPanel.prototype._addScript):
Only show the Anonymous Style Sheets folder once the user tries to show a style sheet that
would be in it.
- UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype.didPresentDialog):
(WI.OpenResourceDialog.prototype._addScriptsForTarget):
(WI.OpenResourceDialog.prototype._handleStyleSheetAdded):
(WI.OpenResourceDialog.prototype._handleStyleSheetRemoved):
Ignore anonymous scripts, and allow injected style sheets to be added after presenting.
- 6:04 PM Changeset in webkit [254244] by
-
- 2 edits in trunk/Source/JavaScriptCore
Instruction.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205945
Reviewed by Mark Lam.
- bytecode/Instruction.h:
(JSC::BaseInstruction::size const):
Changed the types to size_t so that the computation is computed accordingly.
- 6:00 PM Changeset in webkit [254243] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Show RGBA input fields for p3 color picker
https://bugs.webkit.org/show_bug.cgi?id=203928
<rdar://problem/56963805>
Reviewed by Brian Burg.
Display numeric input fields for colors defined via
color(...)CSS syntax.
- UserInterface/Controllers/CodeMirrorColorEditingController.js:
(WI.CodeMirrorColorEditingController.prototype.popoverWillPresent):
Remove unnecessary WI.ColorPicker.Event.FormatChanged event.
- UserInterface/Views/ColorPicker.css:
(.color-picker > .color-inputs > div + div):
- UserInterface/Views/ColorPicker.js:
(WI.ColorPicker):
Don't append inputs of all possible color formats to DOM on instantiation.
(WI.ColorPicker.prototype.set color):
(WI.ColorPicker.prototype.set enableColorComponentInputs):
(WI.ColorPicker.prototype._updateColor):
(WI.ColorPicker.prototype._updateColorGamut):
(WI.ColorPicker.prototype._createColorInputsIfNeeded):
(WI.ColorPicker.prototype._showColorComponentInputs):
(WI.ColorPicker.prototype._handleColorInputsContainerInput):
- UserInterface/Views/InlineSwatch.js:
Remove unnecessary WI.ColorPicker.Event.FormatChanged event.
- 5:42 PM Changeset in webkit [254242] by
-
- 2 edits in trunk/Tools
[ews] Perform validation of patch before retrying CompileWebKit on ToT
https://bugs.webkit.org/show_bug.cgi?id=205953
<rdar://problem/58064430>
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit.evaluateCommand):
- 5:42 PM Changeset in webkit [254241] by
-
- 71 edits1 add in trunk/Source
Reduce binary size by purging C++ type information in Objective-C fields and parameters
https://bugs.webkit.org/show_bug.cgi?id=205905
Reviewed by Saam Barati.
Source/JavaScriptCore:
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo dealloc]):
Source/WebCore:
No behavior change.
- page/mac/WebCoreFrameView.h:
- platform/graphics/cocoa/WebGLLayer.h:
- platform/graphics/cocoa/WebGLLayer.mm:
(-[WebGLLayer initWithGraphicsContextGL:]):
- platform/ios/WebVideoFullscreenControllerAVKit.h:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController videoElement]):
(-[WebVideoFullscreenController setVideoElement:]):
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollAnimationHelperDelegate initWithScrollAnimator:]):
(-[WebScrollAnimationHelperDelegate invalidate]):
(-[WebScrollerImpDelegate scrollAnimator]):
Source/WebKit:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate initWithNetworkSession:wrapper:withCredentials:]):
- Shared/API/Cocoa/WKBrowsingContextHandle.mm:
(-[WKBrowsingContextHandle _initWithPageProxy:]):
(-[WKBrowsingContextHandle _initWithPage:]):
- Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _initWithWebPage:]):
(-[_WKRemoteObjectRegistry _initWithWebPageProxy:]):
- Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _page]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processPool:configuration:]):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::remoteObjectRegistry):
- UIProcess/ios/WKApplicationStateTrackingView.mm:
(-[WKApplicationStateTrackingView willMoveToWindow:]):
(-[WKApplicationStateTrackingView didMoveToWindow]):
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController _manager]):
(-[WKFullScreenViewController _togglePiPAction:]):
(-[WKFullScreenViewController _showPhishingAlert]):
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(WebKit::WKWebViewState::applyTo):
(WebKit::WKWebViewState::store):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
(-[WKFullScreenWindowController _manager]):
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController initWithPage:view:viewImpl:recognizer:]):
(-[WKImmediateActionController _animationControllerForDataDetectedText]):
(-[WKImmediateActionController _animationControllerForDataDetectedLink]):
- UIProcess/mac/WKInspectorViewController.h:
- UIProcess/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController initWithInspectedPage:]):
- UIProcess/mac/WKTextFinderClient.h:
- UIProcess/mac/WKTextFinderClient.mm:
(-[WKTextFinderClient initWithPage:view:usePlatformFindUI:]):
- UIProcess/mac/WKViewLayoutStrategy.h:
- UIProcess/mac/WKViewLayoutStrategy.mm:
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewViewSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
(-[WKDOMDocumentParserYieldToken initWithDocument:]):
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
(-[WKAccessibilityWebPageObjectBase axObjectCache]):
(-[WKAccessibilityWebPageObjectBase setWebPage:]):
Source/WebKitLegacy/mac:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView element]):
- WebCoreSupport/WebEditorClient.mm:
(_WebCreateFragment):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
(-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
- WebCoreSupport/WebGeolocationClient.mm:
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
(-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::resetState):
(-[WebInspectorWindowController setFrontendClient:]):
(-[WebInspectorWindowController setInspectorClient:]):
(-[WebInspectorWindowController inspectorClient]):
- WebInspector/WebInspectorFrontend.h:
- WebInspector/WebInspectorFrontend.mm:
- WebInspector/WebNodeHighlight.h:
- WebInspector/WebNodeHighlight.mm:
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
- WebView/WebDataSource.mm:
(-[WebDataSource _documentLoader]):
(-[WebDataSource addSubresource:]):
- WebView/WebDataSourceInternal.h:
- WebView/WebFrame.mm:
(getWebView):
(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
(-[WebFrame _unmarkAllBadGrammar]):
(-[WebFrame _unmarkAllMisspellings]):
(-[WebFrame _hasSelection]):
(-[WebFrame _atMostOneFrameHasSelection]):
(-[WebFrame _findFrameWithSelection]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
(-[WebFrame _canProvideDocumentSource]):
(-[WebFrame _isDescendantOfFrame:]):
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
(-[WebFrame setTimeoutsPaused:]):
(-[WebFrame prepareForPause]):
(-[WebFrame resumeFromPause]):
(-[WebFrame resetTextAutosizingBeforeLayout]):
(-[WebFrame _globalContextForScriptWorld:]):
(-[WebFrame _layerTreeAsText]):
(-[WebFrame _clearOpener]):
(-[WebFrame focusedNodeHasContent]):
(-[WebFrame _dispatchDidReceiveTitle:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
(-[WebFrame elementAtPoint:]):
(-[WebFrame name]):
(-[WebFrame DOMDocument]):
(-[WebFrame frameElement]):
(-[WebFrame provisionalDataSource]):
(-[WebFrame dataSource]):
(-[WebFrame loadRequest:]):
(-[WebFrame findFrameNamed:]):
(-[WebFrame parentFrame]):
(-[WebFrame childFrames]):
(-[WebFrame windowObject]):
(-[WebFrame globalContext]):
(-[WebFrame javaScriptContext]):
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm:
(-[WebFrameView _web_frame]):
(-[WebFrameView _frameSizeChanged]):
(-[WebFrameView _isVerticalDocument]):
(-[WebFrameView _isFlippedDocument]):
(-[WebFrameView keyDown:keyDown:]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _document]):
- WebView/WebHTMLView.mm:
(-[WebMenuTarget menuController]):
(-[WebMenuTarget setMenuController:]):
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
(-[WebHTMLView _interpretKeyEvent:savingCommands:]):
(-[WebHTMLView setPromisedDragTIFFDataSource:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebNotification.mm:
(-[WebNotification initWithCoreNotification:notificationID:]):
- WebView/WebNotificationInternal.h:
- WebView/WebResource.mm:
(-[WebResource _coreResource]):
- WebView/WebResourceInternal.h:
- WebView/WebVideoFullscreenController.h:
- WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController videoElement]):
(-[WebVideoFullscreenController setVideoElement:]):
- WebView/WebVideoFullscreenHUDWindowController.h:
- WebView/WebView.mm:
(-[WebView page]):
(-[WebView _enterVideoFullscreenForVideoElement:mode:]):
(-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
(-[WebView _supportsFullScreenForElement:withKeyboard:]):
(-[WebView _enterFullScreenForElement:]):
(-[WebView _exitFullScreenForElement:]):
- WebView/WebViewInternal.h:
Source/WTF:
Objective-C has reflection mechanisms. This means that fields, methods, and their types
need to hold its string representations in binary even if we are using release build.
While typical Objective-C class does not have large size of type names, C++ struct / class
has very large one, and putting them in Objective-C method names, parameter types, or fields
makes binary size very large.
Interesting thing is that type information is gathered when parameter is a C++ pointer, reference,
or value. And it gathers one-level deep information from this pointer etc. This means that, if
we use RefPtr<T>, collected type information is the one of RefPtr, not one of T. So it becomes significantly
smaller.
This patch introduces NakedRef<T>. This is similar to Ref while it does not have any ownership. So it
is just a wrapper around T&. We already have NakedPtr<T>. And use NakedRef<T> / NakedPtr<T> instead
of T& and T* if,
- T is C++ class.
- T* / T& is in Objective-C fields or parameter types (including a return type).
Then, these type information is one of NakedRef<T> / NakedPtr<T> instead of T, and we can reduce binary size.
This patch saves 600~KB in binary size.
Note the following things.
- If we use
__attribute__((objc_direct)),__attribute__((objc_direct_members)), possibly, we can completely remove these metadata without using NakedRef / NakedPtr[1]. However, this is not available for our supporting platforms now (including pre-Catalina OSes). This NakedRef / NakedPtr technique can reduce binary without waiting for it. - Reverting NakedRef / NakedPtr to usual reference / pointer is fairly easy since it is well typed. Once
__attribute__((objc_direct))becomes available in our platforms, we can consider it. But using NakedRef / NakedPtr is harmless.
[1]: https://github.com/llvm/llvm-project/commit/d4e1ba3fa9dfec2613bdcc7db0b58dea490c56b1
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/NakedRef.h: Added.
(WTF::NakedRef::NakedRef):
(WTF::NakedRef::operator-> const):
(WTF::NakedRef::get const):
(WTF::NakedRef::operator T& const):
(WTF::NakedRef::operator! const):
(WTF::=):
(WTF::NakedRef<T>::swap):
(WTF::swap):
- 5:32 PM Changeset in webkit [254240] by
-
- 2 edits in trunk/PerformanceTests
REGRESSION (r242911?): High Sierra Release WK2 Perf bot timing out while running IndexedDB/large-number-of-inserts.html
https://bugs.webkit.org/show_bug.cgi?id=195952
<rdar://problem/49137688>
Re-enable the test after recent IDB performance improvement.
Reviewed by Alexey Proskuryakov.
- Skipped:
- 5:21 PM Changeset in webkit [254239] by
-
- 9 edits in trunk/Source
Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable
https://bugs.webkit.org/show_bug.cgi?id=205963
<rdar://problem/58424136>
Reviewed by Brent Fulgham.
To get default on behavior, experimental features in the network process need to be
turned from enable flags to disable flags. This patch does that for the experimental
cookie blocking flag.
Source/WebCore:
No new tests. This change just reverses the interpretation of a flag.
- page/Settings.yaml:
Source/WebKit:
This change also aligns the init values of the setting to match the default.
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkSession.h:
- NetworkProcess/NetworkSessionCreationParameters.h:
- Shared/WebPreferences.yaml:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- 5:18 PM Changeset in webkit [254238] by
-
- 1 edit in trunk/Source/WebCore/platform/LocalizedStrings.cpp
Unreviewed, fix builds with WEB_CRYPTO enabled, following r217686
- 4:59 PM Changeset in webkit [254237] by
-
- 5 edits in trunk/Source/WebKit
Allow some sysctl-read calls needed by WebRTC
https://bugs.webkit.org/show_bug.cgi?id=205946
<rdar://problem/58416475>
Reviewed by Per Arne Vollan.
This patch allows some sysctl-read calls that are needed when running WebRTC tests.
It also removes telemetry and logging from a UIKit class that was confirmed to be
needed by Performance and PowerLogging code.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 4:39 PM Changeset in webkit [254236] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
- 4:30 PM Changeset in webkit [254235] by
-
- 3 edits in trunk/Tools
run-webkit-tests: clobber-old-results should remove the entire results folder
https://bugs.webkit.org/show_bug.cgi?id=205875
<rdar://problem/58236117>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._clobber_old_results): Remove entire results folder.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
entire results directory.
- 4:13 PM Changeset in webkit [254234] by
-
- 5 edits in trunk
build-jsc should invoke make instead of calling xcodebuild directly
https://bugs.webkit.org/show_bug.cgi?id=205960
Reviewed by Keith Miller.
.:
- Makefile.shared:
Source/JavaScriptCore:
The various jsc, and test* binaries can all be compiled in parallel.
This patch makes that happen when building with make via the CLI
that these are built in parallel. To make this work, in Xcode, I needed
to mark these binaries as depending on JavaScriptCore.framework.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Makefile:
- 4:05 PM Changeset in webkit [254233] by
-
- 1 copy in tags/Safari-608.5.9
Tag Safari-608.5.9.
- 3:59 PM Changeset in webkit [254232] by
-
- 3 edits in trunk/Source/WebCore
Move logic for parsing image-orientation to CSSParserFastPaths
https://bugs.webkit.org/show_bug.cgi?id=205962
Reviewed by Simon Fraser.
Covered by exiting tests. No change in functionality.
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeImageOrientation): Deleted.
- 3:45 PM Changeset in webkit [254231] by
-
- 1 edit7 adds in trunk/LayoutTests
few web-platform-tests are failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=205927
Unreviewed test gardening.
- platform/ios-wk2/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub-expected.txt: Added.
- platform/ios/imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https-expected.txt: Added.
- platform/ios/imported/w3c/web-platform-tests/content-security-policy/frame-src/frame-src-same-document-meta-expected.txt: Added.
- platform/ios/imported/w3c/web-platform-tests/xhr/event-timeout-order.any-expected.txt: Added.
- 3:41 PM Changeset in webkit [254230] by
-
- 5 edits6 adds in trunk/Source/JavaScriptCore
Add FuzzerAgents that narrow and widen number predictions
https://bugs.webkit.org/show_bug.cgi?id=203993
Patch by Tuomas Karkkainen <tuomas.webkit@apple.com> on 2020-01-08
Reviewed by Yusuke Suzuki.
Add two FuzzerAgents such that for any predictions that are originally subsets of SpecFullNumber:
- one adds more number types to the prediction
- the other removes some of the number types from the prediction
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/NarrowingNumberPredictionFuzzerAgent.cpp: Added.
- runtime/NarrowingNumberPredictionFuzzerAgent.h: Added.
- runtime/NumberPredictionFuzzerAgent.cpp: Added.
- runtime/NumberPredictionFuzzerAgent.h: Added.
- runtime/OptionsList.h:
- runtime/VM.cpp:
- runtime/WideningNumberPredictionFuzzerAgent.cpp: Added.
- runtime/WideningNumberPredictionFuzzerAgent.h: Added.
- 3:38 PM Changeset in webkit [254229] by
-
- 8 edits in trunk
<img>.naturalWidth should return the density-corrected intrinsic width
https://bugs.webkit.org/show_bug.cgi?id=150443
Patch by Noam Rosenthal <Noam Rosenthal> on 2020-01-08
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Updated expected results.
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
All tests now pass.
- web-platform-tests/html/semantics/embedded-content/the-img-element/intrinsicsize/intrinsicsize-with-responsive-images.tentative-expected.txt:
Still fails but failure values are different.
Source/WebCore:
Take image's density into account when requesting naturalWidth/naturalHeight, not in SVG.
This now complies with the standard (https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-naturalwidth)
It also matches the behavior on Chrome and on Firefox.
Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html
Updaded expected results
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::effectiveImageDevicePixelRatio const):
(WebCore::HTMLImageElement::naturalWidth const):
(WebCore::HTMLImageElement::naturalHeight const):
- html/HTMLImageElement.h:
Use effective image devicePixelRatio for naturalWidth/height calculation
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::unclampedImageSizeForRenderer const):
(WebCore::CachedImage::imageSizeForRenderer const):
- loader/cache/CachedImage.h:
Don't clamp to 1 when calculating naturalWidth/naturalHeight, as this has
nothing to do with zoomed images. Zoomed images behavior remains the same.
- 2:22 PM Changeset in webkit [254228] by
-
- 4 edits in trunk/Source
REGRESSION: (r254186) [ Mac ] inspector/css/add-rule.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205938
<rdar://problem/58413597>
Reviewed by Brian Burg.
Source/WebCore:
Covered by existing tests.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::originalStyleSheetText const):
(WebCore::InspectorStyleSheet::resourceStyleSheetText const):
(WebCore::InspectorStyleSheet::inlineStyleSheetText const):
(WebCore::InspectorStyleSheet::extensionStyleSheetText const):
The Inspector Style Sheet is an inline style sheet, so it goes throughinlineStyleSheetText
instead ofresourceStyleSheetText. Style sheets are only be sourced from one place anyways
so there's no reason to gate each function based on theorigin.
Source/WebInspectorUI:
- UserInterface/Models/CSSStyleSheet.js:
(WI.CSSStyleSheet.prototype.get injected):
schemecan benull, so check that it exists before callingString.prototypefunctions.
- 2:20 PM Changeset in webkit [254227] by
-
- 11 edits in trunk
Rename testing build configuration to release+assert, and add new testing build configuration.
https://bugs.webkit.org/show_bug.cgi?id=205954
Reviewed by Yusuke Suzuki.
.:
"make release-assert" builds a release build with ASSERT_ENABLED=1.
"make testing" builds a debug build with clang optimization level forced to -O3.
- Makefile:
- Makefile.shared:
- Source/Makefile:
Source/ThirdParty:
- Makefile:
Tools:
Added a --force-opt shortcut for the --force-optimization-level option of
set-webkit-configuration. This makes it less painful to type this on the command
line for those of us who would like to use this option often in our local builds.
- Makefile:
- Scripts/set-webkit-configuration:
WebKitLibraries:
- Makefile:
- 2:10 PM Changeset in webkit [254226] by
-
- 2 edits in trunk/Source/WebCore
Suppress "unused parameter" when including libWebRTC headers in LibWebRTCProviderCocoa.cpp
https://bugs.webkit.org/show_bug.cgi?id=205951
Reviewed by Eric Carlson.
Suppress the "unused parameter" warning that results from including
video_encoder.h, which contains the
following line of code (wherereasonis unused):
`
virtual void OnDroppedFrame(DropReason reason) {}
`
This matches other places in WebCore where we attempt to
#include <webrtc/sdk/WebKit/WebKitUtilities.h>.
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
- 2:09 PM Changeset in webkit [254225] by
-
- 2 edits in trunk/Tools
Move EWS from macOS High Sierra to macOS Mojave
https://bugs.webkit.org/show_bug.cgi?id=205948
Reviewed by Aakash Jain.
- BuildSlaveSupport/ews-build/config.json:
- 2:04 PM Changeset in webkit [254224] by
-
- 2 edits in trunk/Source/JavaScriptCore
TypeProfiler.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205947
Reviewed by Mark Lam.
Added cast to keep the hash() calculation unsigned.
- runtime/TypeProfiler.h:
(JSC::QueryKey::hash const):
- 2:00 PM Changeset in webkit [254223] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix some IOS_FAMILY builds after r254210.
- Shared/AuxiliaryProcess.h:
- 1:47 PM Changeset in webkit [254222] by
-
- 4 edits in trunk
Make _callAsyncFunction:withArguments: work with promises.
https://bugs.webkit.org/show_bug.cgi?id=205654
Reviewed by Saam Barati.
Source/WebCore:
Covered by API tests.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeAsynchronousUserAgentScriptInWorld):
Tools:
Test that:
- Resolve results in success handler being called
- Reject results in error handler being called
- Both resolve and reject becoming unreachable results in the error handler being called
- Both native Promise objects and arbitrary thenables work
- Any object where "then" is callable - even if not a function - works
- TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
(TestWebKitAPI::tryGCPromise):
(TestWebKitAPI::TEST):
- 1:30 PM Changeset in webkit [254221] by
-
- 4 edits in trunk/Tools
Regression r254160: 6 API test failures
https://bugs.webkit.org/show_bug.cgi?id=205935
<rdar://problem/58411559>
Revert API test changes in r254160. I mistakenly thought this were legitimate changes,
but they were actually the result of a bug I have since corrected in r254167.
- TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(TEST):
- TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(TEST):
- 1:26 PM Changeset in webkit [254220] by
-
- 3 edits2 adds in trunk
Fix specification violation in Font Loading API
https://bugs.webkit.org/show_bug.cgi?id=205901
<rdar://problem/58083743>
Reviewed by Brent Fulgham.
Source/WebCore:
Our Font Loading API does not comply with the spec:
If the parsed value is a CSS-wide keyword, return a syntax error.
Rather than crashing, we should return a syntax error.
Test: fast/text/font-loading-global-keyword.html
- css/CSSFontFaceSet.cpp:
(WebCore::computeFontSelectionRequest):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
LayoutTests:
Test all the entry points to the CSS Font Loading API that accept CSS keywords.
- fast/text/font-loading-global-keyword-expected.txt: Added.
- fast/text/font-loading-global-keyword.html: Added.
- 1:18 PM Changeset in webkit [254219] by
-
- 4 edits in trunk
Fix testing Makefile to inherit preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=205940
Reviewed by Mark Lam.
.:
- Makefile.shared:
Tools:
- Makefile:
- 12:54 PM Changeset in webkit [254218] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSArrayBufferView.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205943
Reviewed by Saam Barati.
Added cast to size_t to make the whole calculation size_t.
- runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::sizeOf):
- 12:50 PM Changeset in webkit [254217] by
-
- 3 edits2 adds in branches/safari-608-branch
Cherry-pick r252847. rdar://problem/58414545
REGRESSION (Safari 13): WebSocket payload is truncated when x-webkit-deflate-frame is used
https://bugs.webkit.org/show_bug.cgi?id=202401
<rdar://problem/55922632>
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/websocket/tests/hybi/deflate-extension.html
- Modules/websockets/WebSocketDeflater.cpp: (WebCore::WebSocketDeflater::finish): Make sure to continue calling deflate until all output data is flushed.
LayoutTests:
- http/tests/websocket/tests/hybi/deflate-extension-expected.txt: Added.
- http/tests/websocket/tests/hybi/deflate-extension.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:45 PM Changeset in webkit [254216] by
-
- 7 edits in branches/safari-608-branch/Source
Versioning.
- 12:41 PM Changeset in webkit [254215] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed, update test expectations
https://bugs.webkit.org/show_bug.cgi?id=205931
- platform/gtk/TestExpectations:
- 12:27 PM Changeset in webkit [254214] by
-
- 93 edits1 move in trunk/Source
[WebGL] More GraphicsContext3D to GraphicsContextGL renaming
https://bugs.webkit.org/show_bug.cgi?id=205949
<rdar://problem/58416989>
Reviewed by Antoine Quint.
Source/WebCore:
Rename the GC3D-prefixed types.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- html/OffscreenCanvas.cpp:
- html/canvas/ANGLEInstancedArrays.cpp:
- html/canvas/ANGLEInstancedArrays.h:
- html/canvas/OESVertexArrayObject.cpp:
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGL2RenderingContext.cpp:
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLActiveInfo.h:
- html/canvas/WebGLBuffer.cpp:
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLDrawBuffers.cpp:
- html/canvas/WebGLDrawBuffers.h:
- html/canvas/WebGLFramebuffer.cpp:
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLObject.cpp:
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.cpp:
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLQuery.cpp:
- html/canvas/WebGLQuery.h:
- html/canvas/WebGLRenderbuffer.cpp:
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
- html/canvas/WebGLRenderingContextBase.h:
- html/canvas/WebGLSampler.cpp:
- html/canvas/WebGLSampler.h:
- html/canvas/WebGLShader.cpp:
- html/canvas/WebGLShader.h:
- html/canvas/WebGLShaderPrecisionFormat.cpp:
- html/canvas/WebGLShaderPrecisionFormat.h:
- html/canvas/WebGLSync.cpp:
- html/canvas/WebGLSync.h:
- html/canvas/WebGLTexture.cpp:
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLTransformFeedback.cpp:
- html/canvas/WebGLTransformFeedback.h:
- html/canvas/WebGLUniformLocation.cpp:
- html/canvas/WebGLUniformLocation.h:
- html/canvas/WebGLVertexArrayObject.cpp:
- html/canvas/WebGLVertexArrayObject.h:
- html/canvas/WebGLVertexArrayObjectBase.cpp:
- html/canvas/WebGLVertexArrayObjectBase.h:
- html/canvas/WebGLVertexArrayObjectOES.cpp:
- html/canvas/WebGLVertexArrayObjectOES.h:
- platform/graphics/ExtensionsGL.h:
- platform/graphics/GraphicsContextGL.cpp:
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/GraphicsTypesGL.h: Renamed from Source/WebCore/platform/graphics/GraphicsTypes3D.h.
- platform/graphics/ImageBuffer.cpp:
- platform/graphics/ImageBuffer.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/angle/ExtensionsGLANGLE.cpp:
- platform/graphics/angle/ExtensionsGLANGLE.h:
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
- platform/graphics/angle/TemporaryANGLESetting.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
- platform/graphics/cocoa/WebGLLayer.mm:
- platform/graphics/cv/TextureCacheCV.h:
- platform/graphics/cv/TextureCacheCV.mm:
- platform/graphics/cv/VideoTextureCopierCV.cpp:
- platform/graphics/cv/VideoTextureCopierCV.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/opengl/ExtensionsGLOpenGL.cpp:
- platform/graphics/opengl/ExtensionsGLOpenGL.h:
- platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
- platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
- platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:
- platform/graphics/opengl/ExtensionsGLOpenGLES.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
- platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
- platform/graphics/opengl/TemporaryOpenGLSetting.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
- platform/graphics/texmap/TextureMapperGL.cpp:
Source/WebKit:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::copyVideoTextureToPlatformTexture):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- 11:58 AM Changeset in webkit [254213] by
-
- 3 edits in trunk/Source/WebKit
Remove NATIVE_MOUSE_EVENT_HANDLER macros
https://bugs.webkit.org/show_bug.cgi?id=205897
Reviewed by Tim Horton.
Remove the NATIVE_MOUSE_EVENT_HANDLER and NATIVE_MOUSE_EVENT_HANDLER_INTERNAL which are almost identical,
calling a couple of shared functions instead. The only reason the eventName was used was for logging, so just
log the -[NSEvent type] instead.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::operator<<):
(WebKit::WebViewImpl::nativeMouseEventHandler):
(WebKit::WebViewImpl::nativeMouseEventHandlerInternal):
(WebKit::WebViewImpl::mouseEntered):
(WebKit::WebViewImpl::mouseExited):
(WebKit::WebViewImpl::otherMouseDown):
(WebKit::WebViewImpl::otherMouseDragged):
(WebKit::WebViewImpl::otherMouseUp):
(WebKit::WebViewImpl::rightMouseDown):
(WebKit::WebViewImpl::rightMouseDragged):
(WebKit::WebViewImpl::rightMouseUp):
(WebKit::WebViewImpl::mouseMovedInternal):
(WebKit::WebViewImpl::mouseDownInternal):
(WebKit::WebViewImpl::mouseUpInternal):
(WebKit::WebViewImpl::mouseDraggedInternal):
- 11:56 AM Changeset in webkit [254212] by
-
- 3 edits in trunk/Source/WebCore
After playing a video and making it full screen, the video exits full screen and stops but the audio continues to play
https://bugs.webkit.org/show_bug.cgi?id=205896
Patch by Peng Liu <Peng Liu> on 2020-01-08
Reviewed by Jer Noble.
AVKit calls playerViewController:shouldExitFullScreenWithReason in the scenario that the exit fullscreen request
is from the web process (e.g., through Javascript API videoElement.webkitExitFullscreen()).
We have to ignore the callback in that case.
No new tests, covered by existing tests.
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::exitFullscreen):
(VideoFullscreenInterfaceAVKit::cleanupFullscreen):
(VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler):
(VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
- 11:50 AM Changeset in webkit [254211] by
-
- 2 edits in trunk/Source/WebKit
Remove an unused variable in WebCoreArgumentCodersCocoa.mm after r254202
https://bugs.webkit.org/show_bug.cgi?id=205939
Reviewed by Tim Horton.
Remove an unused temporary variable that was only used for debugging.
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<FontHandle>::decodePlatformData):
- 11:38 AM Changeset in webkit [254210] by
-
- 5 edits in trunk/Source/WebKit
Move UIProcess DependencyProcessAssertion from WebContent to AuxiliaryProcess
https://bugs.webkit.org/show_bug.cgi?id=205836
Reviewed by Alex Christensen.
Move UIProcess DependencyProcessAssertion from WebContent to AuxiliaryProcess, so that other auxiliary
processes (Network Process, GPU Process) also benefit from it.
- Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::initializeConnection):
- Shared/AuxiliaryProcess.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- 11:36 AM Changeset in webkit [254209] by
-
- 3 edits in trunk/Source/WebKit
Network process sandboxes should not include 'common.sb' or 'system.sb'
https://bugs.webkit.org/show_bug.cgi?id=205521
<rdar://problem/58095870>
Reviewed by Per Arne Vollan.
This patch replaces the 'include' with a copy/paste of the contents of the relevant
sandbox include file. I removed definitions that were not referenced in the existing
Network sandbox, but did not otherwise edit the contents. There are duplicates and
redundancies after this patch, which I will remove as a follow-up step once we confirm
that this has no regressions.
I also updated the sandbox to generate telemetry for some mach connections that we think
are unneeded, or that should be targeted for removal.
No new tests. There should be no change in behavior.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
- 11:26 AM Changeset in webkit [254208] by
-
- 2 edits in trunk/Source/WebKit
IPC::Connection::sendMessage() should use CRASH_WITH_INFO()
<https://webkit.org/b/205419>
<rdar://problem/58058661>
Reviewed by Mark Lam.
- Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::sendMessage):
- Switch from CRASH() to CRASH_WITH_INFO().
- 11:15 AM Changeset in webkit [254207] by
-
- 2 edits in trunk/Source/WebCore
Fix for parameterized attribute TextMarkerRangeForUIElement which should run ion main thread.
https://bugs.webkit.org/show_bug.cgi?id=205920
Reviewed by Chris Fleizach.
Parameterized attribute TextMarkerRangeForUIElement must run on main
thread since it invokes DOM Range methods.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- 11:02 AM Changeset in webkit [254206] by
-
- 2 edits in trunk/Source/WebCore
Add encoding/decoding support for data structures in TextFlags.h
https://bugs.webkit.org/show_bug.cgi?id=205903
Reviewed by Tim Horton.
Adds encoders and decoders for the enum classes and structs in TextFlags.h, with the eventual goal of being able
to send font creation parameters when sending font data to the GPU process. No change in behavior.
- platform/text/TextFlags.h:
(WebCore::FontVariantSettings::encode const):
(WebCore::FontVariantSettings::decode):
(WebCore::FontVariantLigaturesValues::encode const):
(WebCore::FontVariantLigaturesValues::decode):
(WebCore::FontVariantNumericValues::encode const):
(WebCore::FontVariantNumericValues::decode):
(WebCore::FontVariantEastAsianValues::encode const):
(WebCore::FontVariantEastAsianValues::decode):
- 10:58 AM Changeset in webkit [254205] by
-
- 4 edits in trunk
Proxy's OwnPropertyKeys? is correct only in PropertyNameMode::StringsAndSymbols
https://bugs.webkit.org/show_bug.cgi?id=205772
Reviewed by Ross Kirsling.
JSTests:
- test262/expectations.yaml: Mark 12 test cases as passing.
Source/JavaScriptCore:
This change fixes two spec compatibility issues:
(steps 8-11 of https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys)
- If Object.getOwnPropertyNames is called on Proxy with "ownKeys" trap,
symbol keys of Proxy's target are ignored during invariants validation.
- If Object.getOwnPropertySymbols is called on Proxy with "ownKeys" trap,
string keys of Proxy's target are ignored during invariants validation.
Given that per spec
uncheckedResultKeyscontains both strings and symbols,
seenKeysand explanation comment about it is removed.
Specifying PrivateSymbolMode::Exclude eliminates any chance of false TypeErrors
during invariants validation, since user code can't possibly return a private symbol
from "ownKeys" trap, yet an object with private symbols can be Proxy's target.
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performGetOwnPropertyNames):
- 9:13 AM Changeset in webkit [254204] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, rolling out r254174.
Broke 80 tests on Catalina
Reverted changeset:
"Network process sandboxes should not include 'common.sb' or
'system.sb'"
https://bugs.webkit.org/show_bug.cgi?id=205521
https://trac.webkit.org/changeset/254174
- 9:02 AM Changeset in webkit [254203] by
-
- 4 edits in trunk/LayoutTests
[GTK][WPE] Unreviewed gardening for unexpected passes
https://bugs.webkit.org/show_bug.cgi?id=205854
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 8:33 AM Changeset in webkit [254202] by
-
- 13 edits in trunk/Source
Add support for encoding WebCore::Font over IPC for DisplayList::DrawGlyphs
https://bugs.webkit.org/show_bug.cgi?id=205830
<rdar://problem/57347719>
Reviewed by Dean Jackson.
Source/WebCore:
Add support for encoding Fonts. In the case where the Font is installed, we use platform encoders to send across
the font descriptor, and reconstruct the font using this descriptor on the receiving end (see the existing
implementations of encodeFontInternal and decodeFontInternal). In the case where the Font is not installed, we
instead send the font face data over (plumbed across from the CachedFont), and reconstruct the platform font
data from the raw font data on the receiving end.
This allows us to render web fonts in the GPU process through the
DrawGlyphsdisplay list item.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::font):
- css/CSSFontFaceSource.h:
- platform/graphics/Font.cpp:
(WebCore::Font::setFontFaceData):
Add a way to set font face data used to create the Font. This data comes from a CachedFont's data buffer, and is
used to serialize FontHandles when building display list items.
(WebCore::FontHandle::FontHandle):
Add a serializable wrapper class that contains a nullable Font. The encoder/decoders for FontHandle are
implemented in WebKit2.
- platform/graphics/Font.h:
(WebCore::Font::fontFaceData const):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::DrawGlyphs):
Finish implementing the encode/decode methods for DrawGlyphs, by sending the Font data over via FontHandle.
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawGlyphs::create):
(WebCore::DisplayList::DrawGlyphs::encode const):
(WebCore::DisplayList::DrawGlyphs::decode):
When decoding
DrawGlyphs, avoid having to rebuild the glyph Vector by adding (and using) new DrawGlyphs
constructors that takeVector&&s.
Source/WebKit:
Add basic support for encoding and decoding a FontHandle.
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<FontHandle>::encodePlatformData):
(IPC::ArgumentCoder<FontHandle>::decodePlatformData):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FontHandle>::encode):
(IPC::ArgumentCoder<FontHandle>::decode):
When encoding a Font on Cocoa platforms, send across the font face data (if present); otherwise, fall back to
sending the font descriptor for the UIFont or NSFont (as is the case for installed fonts).
- Shared/WebCoreArgumentCoders.h:
- Shared/curl/WebCoreArgumentCodersCurl.cpp:
(IPC::ArgumentCoder<FontHandle>::encodePlatformData):
(IPC::ArgumentCoder<FontHandle>::decodePlatformData):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<FontHandle>::encodePlatformData):
(IPC::ArgumentCoder<FontHandle>::decodePlatformData):
- 8:30 AM Changeset in webkit [254201] by
-
- 7 edits2 adds in trunk
[Web Animations] Stop creating CSS Animations for <noscript> elements
https://bugs.webkit.org/show_bug.cgi?id=205925
<rdar://problem/58158479>
Reviewed by Antti Koivisto.
Source/WebCore:
Test: webanimations/no-css-animation-on-noscript.html
It makes no sense to create CSS Animations for a <noscript> element and it has the side effect of potential crashes.
Indeed, AnimationTimeline::updateCSSAnimationsForElement() may be called without a currentStyle and so we never have
a list of previously-applied animations to compare to the list of animations in afterChangeStyle. So on each call we
end up creating a new CSSAnimation and the previous animation for the same name is never explicitly removed from the
effect stack and is eventually destroyed and the WeakPtr for it in the stack ends up being null, which would cause a
crash under KeyframeEffectStack::ensureEffectsAreSorted().
We now prevent elements such as <noscript> from being considered for CSS Animations in TreeResolver::resolveElement().
- dom/Element.cpp:
(WebCore::Element::rendererIsNeeded):
- dom/Element.h:
(WebCore::Element::rendererIsEverNeeded):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsEverNeeded):
(WebCore::HTMLElement::rendererIsNeeded): Deleted.
- html/HTMLElement.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
LayoutTests:
Add a new test that checks that setting the
animationproperty on a <noscript> element does not yield the creation of a CSSAnimation object.
- webanimations/no-css-animation-on-noscript-expected.txt: Added.
- webanimations/no-css-animation-on-noscript.html: Added.
- 7:57 AM Changeset in webkit [254200] by
-
- 6 edits in trunk/Source
[WTF] Allow MediaTime static constants
https://bugs.webkit.org/show_bug.cgi?id=205723
Reviewed by Darin Adler.
Source/WebCore:
Since MediaTime no longer has a non-trivial destructor, declaring
MediaTime variables no longer has potential side effects as far as the
compiler is concerned and it can therefore print "unused variable"
errors where that is the case.
This patch marks one of such variable as intentionally unused, since
it's only used in Debug and would otherwise break the Release build.
Actually unused variables are also removed.
- platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::imageForTime):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
Source/WTF:
Despite all its convenience methods, at its core MediaTime is a rather
trivial class with only integral members. Despite this, since it had a
destructor declared, this made the class non-trivially destructible
even if the implementation was empty, and therefore clang did not
allow to use it for static variables unless done in form of a pointer.
By removing the destructor this restriction is lifted and we don't
need heap allocations for static MediaTime objects.
Previous usages of heap allocation for static MediaTime objects have
been rewritten to take advantage of this. Test coverage is provided by
successful compilation without [-Werror,-Wexit-time-destructors]
errors and existing tests.
- wtf/MediaTime.cpp:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):
(WTF::MediaTime::~MediaTime): Deleted.
- wtf/MediaTime.h:
- 7:13 AM Changeset in webkit [254199] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Editing: Allow line breaks in lists
https://bugs.webkit.org/show_bug.cgi?id=205913
Patch by Milan Crha <mcrha@redhat.com> on 2020-01-08
Reviewed by Carlos Garcia Campos.
- UIProcess/gtk/KeyBindingTranslator.cpp:
Treat Shift+Enter as "InsertLineBreak", instead of "InsertNewLine".
- 6:10 AM Changeset in webkit [254198] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r253939): [GTK] Broke build with !USE(WPE_RENDERER)
https://bugs.webkit.org/show_bug.cgi?id=205648
Reviewed by Carlos Alberto Lopez Perez.
- platform/graphics/GraphicsContextGL.h: Rename enum None to
DOMSourceNone to avoid name collission.
- 6:09 AM Changeset in webkit [254197] by
-
- 2 edits in trunk/WebDriverTests
Unreviewed gardening. Add expectations for several tests failing
- TestExpectations.json:
- 6:07 AM Changeset in webkit [254196] by
-
- 3 edits in trunk/Tools
Allow multiple cmakeargs inside inside envvar
https://bugs.webkit.org/show_bug.cgi?id=205722
Patch by Paulo Matos <Paulo Matos> on 2020-01-08
Reviewed by Carlos Alberto Lopez Perez.
Allow sub-argument lists to be passed in a build environment variable.
- Scripts/build-jsc:
- Scripts/build-webkit:
- 5:48 AM Changeset in webkit [254195] by
-
- 4 edits in trunk
RegExp.prototype[Symbol.replace] does not support named capture groups
https://bugs.webkit.org/show_bug.cgi?id=205783
Reviewed by Ross Kirsling.
JSTests:
- test262/expectations.yaml: Mark 6 test cases as passing.
Source/JavaScriptCore:
This patch adds named capture groups support to RegExp.prototype[Symbol.replace],
for both functional and string pattern replacement.
(steps 14.j-l of https://tc39.es/ecma262/#sec-regexp.prototype-@@replace)
This method is used in slow path of String.prototype.replace (RegExp subclass handling),
yet it also can be invoked directly in user code.
- builtins/RegExpPrototype.js:
(getSubstitution):
(Symbol.replace):
- 4:45 AM Changeset in webkit [254194] by
-
- 39 edits13 adds in trunk
Implement MediaRecorder backend in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=205802
Reviewed by Eric Carlson.
Source/WebCore:
Add a page provider to create MediaRecorderPrivate implementations.
This is used by WebKit layer to implement this in GPUProcess.
Update MediaRecorderPrivate by adding an error callback that is used to surface errors as MediaRecorder error events.
Covered by existing tests as MediaRecorder implementation in WebKitTestRunner will use GPUProcess.
- Headers.cmake:
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
- Modules/mediarecorder/MediaRecorder.h:
- Modules/mediarecorder/MediaRecorderProvider.cpp: Added.
(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):
- Modules/mediarecorder/MediaRecorderProvider.h: Added.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::mediaRecorderProvider):
- page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
- page/PageConfiguration.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::create):
- platform/mediastream/MediaStreamPrivate.h:
- platform/mediastream/MediaStreamTrackPrivate.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setUseGPUProcessForWebRTC):
Source/WebKit:
Add support for sending audio/video tracks to record from WebProcess to GPUProcess.
Add a MediaRecorderPrivate implementation that supports sending one audio track and/or one video track to GPUProcess
and stopping/fetching data from the remote recorder in GPUProcess.
In GPUProcess, implement the remote recorder using the existing WebCore recorder writer.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::userMediaCaptureManagerProxy):
(WebKit::GPUConnectionToWebProcess::mediaRecorderManager):
(WebKit::GPUConnectionToWebProcess::didReceiveMessage):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp: Added.
(WebKit::RemoteMediaRecorder::create):
(WebKit::RemoteMediaRecorder::RemoteMediaRecorder):
(WebKit::RemoteMediaRecorder::~RemoteMediaRecorder):
(WebKit::RemoteMediaRecorder::storage):
(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
(WebKit::RemoteMediaRecorder::audioSamplesAvailable):
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
(WebKit::RemoteMediaRecorder::fetchData):
(WebKit::RemoteMediaRecorder::stopRecording):
- GPUProcess/webrtc/RemoteMediaRecorder.h: Added.
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in: Added.
- GPUProcess/webrtc/RemoteMediaRecorderManager.cpp: Added.
(WebKit::RemoteMediaRecorderManager::RemoteMediaRecorderManager):
(WebKit::RemoteMediaRecorderManager::~RemoteMediaRecorderManager):
(WebKit::RemoteMediaRecorderManager::didReceiveRemoteMediaRecorderMessage):
(WebKit::RemoteMediaRecorderManager::createRecorder):
(WebKit::RemoteMediaRecorderManager::releaseRecorder):
- GPUProcess/webrtc/RemoteMediaRecorderManager.h: Added.
(WebKit::RemoteMediaRecorderManager::didReceiveMessageFromWebProcess):
- GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in: Added.
- Scripts/webkit/messages.py:
- Sources.txt:
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/media/MediaRecorderProvider.cpp: Added.
(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):
- WebProcess/GPU/media/MediaRecorderProvider.h: Added.
- WebProcess/GPU/webrtc/MediaRecorderIdentifier.h: Added.
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: Added.
(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::~MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::sampleBufferUpdated):
(WebKit::MediaRecorderPrivate::audioSamplesAvailable):
(WebKit::MediaRecorderPrivate::storageChanged):
(WebKit::MediaRecorderPrivate::fetchData):
(WebKit::MediaRecorderPrivate::stopRecording):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h: Added.
- WebProcess/GPU/webrtc/MediaRecorderProvider.cpp: Added.
(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):
- WebProcess/GPU/webrtc/MediaRecorderProvider.h: Added.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_overriddenMediaType):
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::initWithFrame):
LayoutTests:
- http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html:
Do not use GPUProcess for this test until canvas buffers are IOSurfaces.
- 4:12 AM Changeset in webkit [254193] by
-
- 5 edits18 adds in trunk/LayoutTests
[CSS Font Loading] Import css-font-loading WPT tests
https://bugs.webkit.org/show_bug.cgi?id=205863
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/css/css-font-loading/META.yml: Added.
- web-platform-tests/css/css-font-loading/empty-family-load-expected.txt: Added.
- web-platform-tests/css/css-font-loading/empty-family-load.html: Added.
- web-platform-tests/css/css-font-loading/font-face-reject-expected.txt: Added.
- web-platform-tests/css/css-font-loading/font-face-reject.html: Added.
- web-platform-tests/css/css-font-loading/fontface-descriptor-updates-expected.html: Added.
- web-platform-tests/css/css-font-loading/fontface-descriptor-updates.html: Added.
- web-platform-tests/css/css-font-loading/fontfaceset-no-root-element.html: Added.
- web-platform-tests/css/css-font-loading/fontfacesetloadevent-constructor-expected.txt: Added.
- web-platform-tests/css/css-font-loading/fontfacesetloadevent-constructor.html: Added.
- web-platform-tests/css/css-font-loading/idlharness.https-expected.txt: Added.
- web-platform-tests/css/css-font-loading/idlharness.https.html: Added.
- web-platform-tests/css/css-font-loading/resources/GenI102.woff2: Added.
- web-platform-tests/css/css-font-loading/resources/GenR102.woff2: Added.
- web-platform-tests/css/css-font-loading/resources/w3c-import.log: Added.
- web-platform-tests/css/css-font-loading/w3c-import.log: Added.
LayoutTests:
Tests failing:
- https://webkit.org/b/184138 imported/w3c/web-platform-tests/css/css-font-loading/fontfacesetloadevent-constructor.html
- https://webkit.org/b/184138 imported/w3c/web-platform-tests/css/css-font-loading/idlharness.https.html
- https://webkit.org/b/205864 imported/w3c/web-platform-tests/css/css-font-loading/font-face-reject.html
- 3:53 AM Changeset in webkit [254192] by
-
- 36 edits2 adds1 delete in trunk/WebDriverTests
Unreviewed. Update W3C WebDriver imported tests.
- TestExpectations.json:
- imported/w3c/importer.json:
- imported/w3c/tools/webdriver/webdriver/init.py:
- imported/w3c/tools/webdriver/webdriver/client.py:
- imported/w3c/tools/webdriver/webdriver/error.py:
- imported/w3c/tools/webdriver/webdriver/transport.py:
- imported/w3c/tools/wptrunner/docs/expectation.rst:
- imported/w3c/tools/wptrunner/requirements.txt:
- imported/w3c/tools/wptrunner/requirements_firefox.txt:
- imported/w3c/tools/wptrunner/tox.ini:
- imported/w3c/tools/wptrunner/wptrunner/browsers/init.py:
- imported/w3c/tools/wptrunner/wptrunner/browsers/android_weblayer.py: Added.
- imported/w3c/tools/wptrunner/wptrunner/browsers/base.py:
- imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py:
- imported/w3c/tools/wptrunner/wptrunner/browsers/servodriver.py:
- imported/w3c/tools/wptrunner/wptrunner/browsers/webkit.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executorservodriver.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executorwebdriver.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/protocol.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/reftest-wait_marionette.js: Removed.
- imported/w3c/tools/wptrunner/wptrunner/executors/reftest-wait_webdriver.js:
- imported/w3c/tools/wptrunner/wptrunner/testdriver-extra.js:
- imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
- imported/w3c/tools/wptrunner/wptrunner/tests/init.py:
- imported/w3c/tools/wptrunner/wptrunner/tests/browsers/test_webkitgtk.py: Added.
- imported/w3c/tools/wptrunner/wptrunner/tests/test_wpttest.py:
- imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
- imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
- imported/w3c/webdriver/tests/find_element_from_element/find.py:
- imported/w3c/webdriver/tests/new_session/default_values.py:
- imported/w3c/webdriver/tests/perform_actions/support/keys.py:
- imported/w3c/webdriver/tests/perform_actions/validity.py:
- imported/w3c/webdriver/tests/send_alert_text/send.py:
- imported/w3c/webdriver/tests/set_window_rect/set.py:
- 2:29 AM Changeset in webkit [254191] by
-
- 2 edits in trunk/Source/WebKit
Improve logging of creating a service worker
https://bugs.webkit.org/show_bug.cgi?id=205849
Reviewed by Chris Dumez.
Add some release logging to identify which service worker is created in which process.
No change of observable behavior.
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
- 1:00 AM Changeset in webkit [254190] by
-
- 7 edits in trunk
[HarfBuzz][GTK] fast/text/complex-first-glyph-with-initial-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118221
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Arabic diacritics made glyphs vertically unaligned if the first
glyph had a vertical offset.
The initial advance should be same with the first glyph origin for
HarfBuzz. See the diagram in ComplexTextController.h for details.
<https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/ComplexTextController.h?rev=224007#L109>
drawGlyphs of Cairo port was assuming upward y-axis for glyph
advances even though those of Mac and AppleWin port are assuming
downward y-axis. This is a problem for Windows ports because
AppleWin and WinCairo port are sharing the code calculating
advances.
Covered by existing tests.
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::drawGlyphs):
- platform/graphics/cairo/GraphicsContextImplCairo.cpp:
(WebCore::GraphicsContextImplCairo::drawGlyphs):
Sum up the height of advances into yOffset instead of subtraction.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Don't negate offsetY. Set m_initialAdvance as the first item of
m_glyphOrigins.
LayoutTests:
- platform/gtk/TestExpectations: Unmarked
fast/text/complex-first-glyph-with-initial-advance.html and
fast/text/initial-advance-in-intermediate-run-complex.html.
- platform/wincairo/TestExpectations: Unmarked
fast/text/complex-first-glyph-with-initial-advance.html and
fast/text/complex-initial-advance.html.
