Context Navigation

← Previous Period
Next Period →

Timeline

Jan 15, 2020:

9:41 PM Changeset in webkit [254668] by beidson@apple.com

23 edits
4 copies
1 add in trunk

Add WKContentWorld SPI, and use it in JavaScript execution.
https://bugs.webkit.org/show_bug.cgi?id=206310

Reviewed by Alex Christensen.
Source/WebKit:

Covered by API tests.

_WKContentWorld is a UI Process wrapper for an InjectedBundleScriptWorld.
Much like _WKUserContentWorld is. But different in that:

Its APIs are named different things
Only one unique instance per string name
It is used with evaluateJavascript: and callAsyncJavaScriptFunction: instead of WKUserContentController.

But _WKContentWorld and _WKUserContentWorld do have to work together a little bit to avoid conflicts in the WebProcess.

The new versions of evaluateJavascript: and callAsyncJavaScriptFunction: are also included, as well as API tests for all the new stuff.

Shared/API/APIObject.h:
Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

UIProcess/API/APIContentWorld.cpp: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.cpp.

(API::ContentWorld::sharedWorldWithName):
(API::ContentWorld::pageContentWorld):
(API::ContentWorld::defaultClientWorld):
(API::ContentWorld::ContentWorld):
(API::ContentWorld::~ContentWorld):

UIProcess/API/APIContentWorld.h: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h.

UIProcess/API/APIUserContentWorld.cpp:

(API::UserContentWorld::generateIdentifier):
(API::UserContentWorld::UserContentWorld):
(API::generateIdentifier): Deleted.

UIProcess/API/APIUserContentWorld.h:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView evaluateJavaScript:completionHandler:]):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:inWorld:]):
(-[WKWebView _callAsyncJavaScriptFunction:withArguments:inWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScript:inWorld:completionHandler:]):
(-[WKWebView _evaluateJavaScriptWithoutUserGesture:completionHandler:]):
(-[WKWebView _evaluateJavaScript:asAsyncFunction:withArguments:forceUserGesture:completionHandler:]): Deleted.
(-[WKWebView _callAsyncFunction:withArguments:completionHandler:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

UIProcess/API/Cocoa/_WKContentWorld.h: Added.
UIProcess/API/Cocoa/_WKContentWorld.mm: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h.

(+[_WKContentWorld pageContentWorld]):
(+[_WKContentWorld defaultClientWorld]):
(+[_WKContentWorld worldWithName:]):
(-[_WKContentWorld dealloc]):
(-[_WKContentWorld name]):
(-[_WKContentWorld _apiObject]):

UIProcess/API/Cocoa/_WKContentWorldInternal.h: Copied from Source/WebKit/UIProcess/API/APIUserContentWorld.h.

UIProcess/UserContent/WebUserContentControllerProxy.cpp:
UIProcess/UserContent/WebUserContentControllerProxy.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::runJavaScriptInMainFrameScriptWorld):

UIProcess/WebPageProxy.h:

WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::worldMap):
(WebKit::WebUserContentController::worldForIdentifier):
(WebKit::WebUserContentController::addUserContentWorld):
(WebKit::WebUserContentController::addUserContentWorlds):

WebProcess/UserContent/WebUserContentController.h:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScript):
(WebKit::WebPage::runJavaScriptInMainFrameScriptWorld):
(WebKit::WebPage::runJavaScriptInFrame):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Sources.txt:
WebKit.xcodeproj/project.pbxproj:

Tools:

Update previous callAsyncFunction calls with the new signature.
Add tests for new _WKContentWorld class and its behavior with regard to executing JavaScript.

TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:

(TestWebKitAPI::tryGCPromise):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:

(TEST):

TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):

9:08 PM Changeset in webkit [254667] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview/Safari Technology Preview 98

Added a tag for Safari Technology Preview release 98.

7:50 PM Changeset in webkit [254666] by don.olmstead@sony.com

25 edits in trunk/Source/WebCore

[LFC] Fix CMake Build
https://bugs.webkit.org/show_bug.cgi?id=206334

Reviewed by Zalan Bujtas.

No new tests. No change in behavior.

Adds in the required CMake values to get LFC to compile. Fixes all issues with
the non-unified build in the layout directory.

CMakeLists.txt:
Headers.cmake:
layout/FormattingContextGeometry.cpp:
layout/FormattingContextQuirks.cpp:
layout/FormattingState.cpp:
layout/LayoutContext.h:
layout/LayoutPhase.cpp:
layout/LayoutPhase.h:
layout/LayoutState.cpp:
layout/LayoutUnits.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:
layout/blockformatting/BlockFormattingContextQuirks.cpp:
layout/blockformatting/BlockMarginCollapse.cpp:
layout/inlineformatting/InlineFormattingContext.cpp:
layout/inlineformatting/InlineLineBreaker.h:
layout/inlineformatting/InlineTextItem.cpp:
layout/inlineformatting/LineLayoutContext.cpp:
layout/inlineformatting/text/TextUtil.cpp:
layout/inlineformatting/text/TextUtil.h:
layout/layouttree/LayoutBox.cpp:
layout/layouttree/LayoutTreeBuilder.cpp:
layout/layouttree/LayoutTreeBuilder.h:
layout/tableformatting/TableFormattingContext.cpp:
layout/tableformatting/TableFormattingContextGeometry.cpp:

7:34 PM Changeset in webkit [254665] by Alan Coon

5 edits in branches/safari-609-branch

Apply patch. rdar://problem/58353217

7:28 PM Changeset in webkit [254664] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Gardening tests using language override
https://bugs.webkit.org/show_bug.cgi?id=206333

Patch by Lauro Moura <Lauro Moura> on 2020-01-15
Reviewed by Carlos Alberto Lopez Perez.

platform/gtk/TestExpectations:

7:10 PM Changeset in webkit [254663] by Ross Kirsling

4 edits
1 delete in trunk/Source/WebKit

[PlayStation] Add stubs for WebContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=206324

Reviewed by Don Olmstead.

WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:

(WebKit::WebContextMenuClient::lookUpInDictionary): Deleted.
(WebKit::WebContextMenuClient::isSpeaking): Deleted.
(WebKit::WebContextMenuClient::speak): Deleted.
(WebKit::WebContextMenuClient::stopSpeaking): Deleted.
Bring GTK/WPE stubs down for broader use.

7:02 PM Changeset in webkit [254662] by rniwa@webkit.org

3 edits
2 adds in trunk

Nullptr crash in DocumentLoader::clearMainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=206204

Source/WebCore:

Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-01-15
Reviewed by Ryosuke Niwa.

Test: loader/change-src-during-iframe-load-crash.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::frameLoader const):
(WebCore::DocumentLoader::clearMainResourceLoader):

LayoutTests:

Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
accessing activeDocumentLoader.

Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-01-15
Reviewed by Ryosuke Niwa.

loader/change-src-during-iframe-load-crash-expected.txt: Added.
loader/change-src-during-iframe-load-crash.html: Added.

6:23 PM Changeset in webkit [254661] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] LineBreaker::shouldWrapInlineContent should take the candidate content width
https://bugs.webkit.org/show_bug.cgi?id=206305
<rdar://problem/58613977>

Reviewed by Antti Koivisto.

We already have the width information of the candidate runs. Let's not loop through the runs just to re-collect the logical width.
~3% progression on PerformanceTests/Layout/line-layout-simple.html.

layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::ContinuousContent::ContinuousContent):

layout/inlineformatting/InlineLineBreaker.h:
layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineCandidateContent::inlineContentLogicalWidth const):
(WebCore::Layout::LineCandidateContent::append):
(WebCore::Layout::LineCandidateContent::reset):
(WebCore::Layout::LineLayoutContext::tryAddingInlineItems):

6:09 PM Changeset in webkit [254660] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r254565.
https://bugs.webkit.org/show_bug.cgi?id=206331

It caused many timeouts for the layout tests of the GTK port
(Requested by clopez on #webkit).

Reverted changeset:

"[GStreamer] Several buffering fixes"
https://bugs.webkit.org/show_bug.cgi?id=206234
https://trac.webkit.org/changeset/254565

6:00 PM Changeset in webkit [254659] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate
https://bugs.webkit.org/show_bug.cgi?id=206261
<rdar://problem/57562592>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-15
Reviewed by David Kilzer.

There's no reason to keep a raw pointer when we can keep a smart pointer.
This will make this more robust against someone forgetting to clear this pointer value.

platform/network/ResourceHandle.h:
platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::SynchronousLoaderClient):
(WebCore::SynchronousLoaderClient::didFinishLoading):
(WebCore::SynchronousLoaderClient::didFail):

platform/network/SynchronousLoaderClient.h:

(WebCore::SynchronousLoaderMessageQueue::create):
(WebCore::SynchronousLoaderMessageQueue::append):
(WebCore::SynchronousLoaderMessageQueue::kill):
(WebCore::SynchronousLoaderMessageQueue::killed const):
(WebCore::SynchronousLoaderMessageQueue::waitForMessage):

platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::makeDelegate):

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate initWithHandle:messageQueue:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):

5:43 PM Changeset in webkit [254658] by Ross Kirsling

4 edits
2 deletes in trunk/Source/WebKit

[PlayStation] Add stub for WebPopupMenu::setUpPlatformData
https://bugs.webkit.org/show_bug.cgi?id=206323

Reviewed by Don Olmstead.

SourcesGTK.txt:
SourcesWPE.txt:
WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Removed.
WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Removed.

Bring GTK/WPE stub down for broader use.

5:40 PM Changeset in webkit [254657] by commit-queue@webkit.org

42 edits
2 adds in trunk

[SVG2]: Implement support for the 'pathLength' attribute
https://bugs.webkit.org/show_bug.cgi?id=72401

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-01-15
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInStroke-01-expected.txt:

Source/WebCore:

The spec link is:

https://svgwg.org/svg2-draft/paths.html#PathLengthAttribute

The 'pathLength' attribute affects the calculations for text on a path,
stroke dash offset and stroke dash array. 'pathLength' has no effect on
percentage lengths.

Tests: svg/custom/stroke-dash-array-pathLength.svg

rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::targetElement const):
A helper function which returns the target element. Notice target element
can't be used in this context unless it is a SVGGeometryElement. See
pathFromGraphicsElement().

(WebCore::RenderSVGTextPath::layoutPath const):
Use the new function targetElement().

(WebCore::RenderSVGTextPath::startOffset const):
In SVGTextLayoutEngine::beginTextPathLayout(), we used to check whether
startOffset is in the range [0, 1] to treat it as a percentage or not.
This is of course wrong especially when using with 'pathLength'. So we
need to return the SVGLengthValue to make the decision correctly.

rendering/svg/RenderSVGTextPath.h:

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
Apply 'pathLength' to the shape 'stroke-dashoffset' and 'stroke-dasharray'
properties.

rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):
Add the 'pathLength' property to the shape stroke property.

rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::beginTextPathLayout):
Apply 'pathLength' to the text path 'start-offset' property.

LayoutTests:

TestExpectations:

platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-percentage-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/shapes/line-dasharray-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-001-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-002-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-003-expected.txt:

'pathLength' is now included in the DRT of the stroke. Other tests will
need to be rebaselined.

platform/ios-simulator/imported/w3c/web-platform-tests/svg/import/paths-dom-01-f-manual-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-percentage-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-percentage-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/shapes/line-dasharray-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-001-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-002-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-003-expected.txt:
platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftests/textpath-shape-001-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/import/paths-dom-01-f-manual-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-percentage-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/path/distance/pathLength-zero-percentage-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/shapes/line-dasharray-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-001-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-002-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-003-expected.txt:
platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/textpath-shape-001-expected.txt:

'pathLength' is now included in the DRT of the stroke. These tests were
rendering incorrectly. With this patch, the rendering matches the rendering
of other browsers.

platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathLength-positive-percentage-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/shapes/line-dasharray-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-001-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-002-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/svg/shapes/reftests/pathlength-003-expected.txt:

'pathLength' is now included in the DRT of the stroke. Other tests will
need to be rebaselined.

svg/custom/stroke-dash-array-pathLength-expected.svg: Added.
svg/custom/stroke-dash-array-pathLength.svg: Added.

5:17 PM Changeset in webkit [254656] by Ross Kirsling

2 edits in trunk/Source/WebKit

[PlayStation] Add stubs for WebEditorClient
https://bugs.webkit.org/show_bug.cgi?id=206320

Reviewed by Don Olmstead.

WebProcess/WebCoreSupport/WebEditorClient.cpp:

4:56 PM Changeset in webkit [254655] by timothy_horton@apple.com

2 edits in trunk/Source/WebKitLegacy/ios

WebKit should not expose a unprefixed CGRectValue category method on NSValue
https://bugs.webkit.org/show_bug.cgi?id=206297
<rdar://problem/58592554>

Reviewed by Wenson Hsieh.

WebView/WebPDFViewPlaceholder.mm:

(-[NSValue CGRectValue]): Deleted.

4:35 PM Changeset in webkit [254654] by Jonathan Bedard

2 edits in trunk/Tools

run-api-tests no longer supports wildcards in test names
https://bugs.webkit.org/show_bug.cgi?id=206319
<rdar://problem/58351608>

Reviewed by Chris Dumez.

Scripts/webkitpy/api_tests/manager.py:

(Manager._find_test_subset):

4:09 PM Changeset in webkit [254653] by caitp@igalia.com

57 edits
6 adds in trunk

[JSC] Add support for public class fields
https://bugs.webkit.org/show_bug.cgi?id=174212

Reviewed by Yusuke Suzuki.

JSTests:

New syntax invalidates some test expectations:

"async <linefeed> MethodDefinition" is no longer an unexpected "async"
token. It is now an instance field named "async" with no initializer,
and an automatic semicolon, followed by MethodDefinition.

"get|set GeneratorMethodDefinition"'s error message has changed, due to "get"
being valid class field names.

Many class-syntax tests relating to automatic semicolon insertion are
no longer valid, as a line containing nothing but an identifier is now
a valid class element.

stress/async-await-syntax.js:
stress/class-fields-bytecode-cache.js: Added.
stress/class-fields-computed-to-property-key.js: Added.
stress/class-fields-function-name.js: Added.
stress/class-fields-harmony.js: Added.
stress/class-fields-proxy-define-property.js: Added.
stress/class-fields-stress-instance.js: Added.
stress/generator-syntax.js:
stress/method-name.js:
test262/config.yaml:

Source/JavaScriptCore:

Implements the instance class fields proposal (https://tc39.es/proposal-class-fields/),
minus support for private fields (split into a separate patch).

In summary, class fields are initialized by a synthetic JSFunction. In its unlinked state,
the UnlinkedFunctionExecutable for the function includes an ordered list of JSTokenLocations
pointing to the start of each class field in the class. Each of these fields are parsed and
included as DefineFieldNodes, which implement the appropriate DefineField behaviour in the
proposal. This synthetic function is only created, and only loaded, if there are class fields
present. The decision to use a synthetic function was for simplicity. There are a number of
factors which make inlining the initialization complicated, though we may opt to do this in
the future. For reference, the complexities are: instance fields and constructor in different
currently in different parsing arenas, distinct scopes between the 2 which require work to manage,
and complexity in doing to this work for child classes, where the location of initialization can
depend, and in some cases occur more than once.

Computed property fields require a new bytecode, op_to_property_key, as an implementation
detail. It is necessary in the proposal to convert computed properties to property keys
during class evaluation, rather than during field initialization. Additionally, we allocate
the class lexical scope when computed class fields are used (previously, only when there was
a class name), as a location to keep the computed property keys. They can be loaded from the
scope via indexed keys.

To illustrate computed field names in action, consider the following pseudocode:

<during class evaluation>
1) fieldName = emitNode({expr})
2) fieldName = emitToPropertyKey(fieldName)
3) classScope[numComputedNames++] = fieldName

<during class field initialization>
1) fieldName = emitGetFromScope(classScope, computedFieldNameIndex++)
2) value = emitNode({initializer})
3) instance[fieldName] = value

The feature is currently hidden behind the feature flag JSC::Options::useClassFields.

LayoutTests:

New syntax invalidates some test expectations:

"async <linefeed> MethodDefinition" is no longer an unexpected "async"
token. It is now an instance field named "async" with no initializer,
and an automatic semicolon, followed by MethodDefinition.

"get|set GeneratorMethodDefinition"'s error message has changed, due to "get"
being valid class field names.

Many class-syntax tests relating to automatic semicolon insertion are
no longer valid, as a line containing nothing but an identifier is now
a valid class element.

js/class-syntax-semicolon-expected.txt:
js/script-tests/class-syntax-semicolon.js:

3:55 PM Changeset in webkit [254652] by Chris Dumez

6 edits
6 adds in trunk

Regression(r253213) Load hang and high CPU usage when trying to load myuhc.com
https://bugs.webkit.org/show_bug.cgi?id=206315
<rdar://problem/58139842>

Reviewed by Geoffrey Garen.

Source/WebCore:

Starting in r253213, we now throw when trying to do a sync XHR during unload. Unfortunately, this is confusing the script
on myuhc.com and it ends up retrying the sync XHR in a tight loop. To address the issue, I am putting in a safety net which
ignores calls to XMLHttpRequest.send() instead of throwing, once we've reached 5 sync XHR failures during unload.

Throwing is useful because this gives a change for Web authors to fall back to using Beacon API or Fetch KeepAlive if the
sync XHR fails. There is already code out there doing just that. You could imagine content doing more than one sync XHR
during unload, each one with a good beacon API fallback. For this reason, I put in a limit of 5 sync failures before
we stop throwing. Having a limit is important to break bad loops when the content simply retries the same sync XHR load
when the sync XHR send() call throws.

Tests: fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html

fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html

dom/Document.cpp:

(WebCore::Document::didRejectSyncXHRDuringPageDismissal):
(WebCore::Document::shouldIgnoreSyncXHRs const):

dom/Document.h:
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::prepareToSend):

LayoutTests:

Add layout test coverage.

fast/xmlhttprequest/resources/xmlhttprequest-multiple-sync-xhr-during-unload-iframe.html: Added.
fast/xmlhttprequest/resources/xmlhttprequest-sync-xhr-failure-loop-during-unload-iframe.html: Added.
fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt: Added.
fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html: Added.
fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload-expected.txt: Added.
fast/xmlhttprequest/xmlhttprequest-sync-xhr-failure-loop-during-unload.html: Added.

3:25 PM Changeset in webkit [254651] by Alan Coon

5 edits in branches/safari-610.1.1-branch

Revert r254379. rdar://problem/58542040

3:25 PM Changeset in webkit [254650] by Alan Coon

7 edits in branches/safari-610.1.1-branch

Revert r254537. rdar://problem/58542040

3:07 PM Changeset in webkit [254649] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254267. rdar://problem/58606290

Reformat FrameView logging
https://bugs.webkit.org/show_bug.cgi?id=205984
<rdar://problem/58431722>

Reviewed by Brent Fulgham.

Update the format used by FrameView in its RELEASE_LOG logging. Use
the format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4a1cf8010 - FrameView::fireLayoutRelatedMilestonesIfNeeded() - firing first visually non-empty layout milestone on the main frame

becomes:

0x561be8010 - [frame=0x55d47e000, main=1] FrameView::fireLayoutRelatedMilestonesIfNeeded: Firing first visually non-empty layout milestone on the main frame

No new tests -- no new or changed functionality.

page/FrameView.cpp: (WebCore::FrameView::paintContents): (WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254648] by Alan Coon

8 edits in branches/safari-609-branch

Cherry-pick r254229. rdar://problem/58605950

<img>.naturalWidth should return the density-corrected intrinsic width
https://bugs.webkit.org/show_bug.cgi?id=150443

Patch by Noam Rosenthal <Noam Rosenthal> on 2020-01-08
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Updated expected results.

web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:

All tests now pass.

web-platform-tests/html/semantics/embedded-content/the-img-element/intrinsicsize/intrinsicsize-with-responsive-images.tentative-expected.txt:

Still fails but failure values are different.

Source/WebCore:

Take image's density into account when requesting naturalWidth/naturalHeight, not in SVG.

This now complies with the standard (https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-naturalwidth)
It also matches the behavior on Chrome and on Firefox.

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html

Updaded expected results

html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::effectiveImageDevicePixelRatio const): (WebCore::HTMLImageElement::naturalWidth const): (WebCore::HTMLImageElement::naturalHeight const):
html/HTMLImageElement.h:

Use effective image devicePixelRatio for naturalWidth/height calculation

loader/cache/CachedImage.cpp: (WebCore::CachedImage::unclampedImageSizeForRenderer const): (WebCore::CachedImage::imageSizeForRenderer const):
loader/cache/CachedImage.h:

Don't clamp to 1 when calculating naturalWidth/naturalHeight, as this has
nothing to do with zoomed images. Zoomed images behavior remains the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254647] by Alan Coon

32 edits
6 adds in branches/safari-609-branch

Cherry-pick r254187. rdar://problem/58605950

Implement css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89052

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-01-07
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-images/inheritance-expected.txt:
web-platform-tests/css/css-images/inheritance.html: This test is re-synced from upstream

web-platform-tests/css/css-images/parsing/image-orientation-computed-expected.txt:
web-platform-tests/css/css-images/parsing/image-orientation-valid-expected.txt:

Source/JavaScriptCore:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Implement the CSS image-orientation property for content images. The valid
values are "from-image" or "none". The default value is "from-image".

Specification: https://drafts.csswg.org/css-images-3/#the-image-orientation
GitHub issue: https://github.com/w3c/csswg-drafts/issues/4164

Tests: fast/images/image-orientation-dynamic-from-image.html

fast/images/image-orientation-dynamic-none.html
fast/images/image-orientation-none.html

Configurations/FeatureDefines.xcconfig:
css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator ImageOrientation const): Deleted.
css/CSSProperties.json:
css/CSSValueKeywords.in:
css/parser/CSSPropertyParser.cpp: (WebCore::consumeImageOrientation): (WebCore::CSSPropertyParser::parseSingleValue):
rendering/RenderElement.cpp: (WebCore::RenderElement::imageOrientation const):
rendering/RenderImage.cpp: (WebCore::RenderImage::styleDidChange):
rendering/style/RenderStyle.cpp: (WebCore::rareInheritedDataChangeRequiresLayout):
rendering/style/RenderStyle.h: (WebCore::RenderStyle::setImageOrientation): (WebCore::RenderStyle::initialImageOrientation): (WebCore::RenderStyle::imageOrientation const):
rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const):
rendering/style/StyleRareInheritedData.h:
style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertImageOrientation):

Source/WebCore/PAL:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

wtf/FeatureDefines.h:

Tools:

Remove the ENABLE_CSS_IMAGE_ORIENTATION feature flag.

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Test the css image-orientation property.

fast/images/image-orientation-dynamic-from-image-expected.html: Added.
fast/images/image-orientation-dynamic-from-image.html: Added.
fast/images/image-orientation-dynamic-none-expected.html: Added.
fast/images/image-orientation-dynamic-none.html: Added.
fast/images/image-orientation-none-expected.html: Added.
fast/images/image-orientation-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254646] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254179. rdar://problem/58606203

Reformat FrameLoader logging
https://bugs.webkit.org/show_bug.cgi?id=205884
<rdar://problem/58387123>

Reviewed by Brent Fulgham.

Update the format used by FrameLoader in its RELEASE_LOG logging. Use
the format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4aa2df000 - FrameLoader::allAllLoaders: Clearing provisional document loader (frame = 0x4a8ad3550, main = 0 m_provisionalDocumentLoader=0x0)

becomes:

0x465fb61a0 - [frame=0x465c98a20, main=0] FrameLoader::stopAllLoaders: Clearing provisional document loader (m_provisionalDocumentLoader=0x0)

No new tests -- no new or changed functionality.

loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::clearProvisionalLoadForPolicyCheck): (WebCore::FrameLoader::reloadWithOverrideEncoding): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::stopForBackForwardCache): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadDifferentDocumentItem): (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254645] by Alan Coon

6 edits in branches/safari-609-branch

Cherry-pick r254089. rdar://problem/58606252

XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
https://bugs.webkit.org/show_bug.cgi?id=205685

Reviewed by Alex Christensen.

Source/WebCore:

There is no blob registry in the UIProcess.
This should not matter since we do not yet support blobs in custom scheme handlers.
But we are calling the blob registry when creating a request body, which does not work in UIProcess.
Instead, pass a lambda that will be called in case of blobs.
Covered by API test.

platform/network/FormData.cpp: (WebCore::FormDataElement::lengthInBytes const): (WebCore::FormData::resolveBlobReferences):
platform/network/FormData.h:
platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::createHTTPBodyCFReadStream):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254644] by Alan Coon

3 edits in branches/safari-609-branch/Source/WebInspectorUI

Cherry-pick r254058. rdar://problem/58606175

Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
https://bugs.webkit.org/show_bug.cgi?id=205659

Reviewed by Brian Burg.

Limit the height of the canvas and shader program tree a recording is selected.

UserInterface/Views/CanvasSidebarPanel.js: (WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
UserInterface/Views/CanvasSidebarPanel.css: (.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254643] by Alan Coon

3 edits in branches/safari-609-branch

Cherry-pick r254007. rdar://problem/58605939

REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing
https://bugs.webkit.org/show_bug.cgi?id=201900
<rdar://problem/55466061>

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::registerMDNSName): Fix message typo (missing space).

LayoutTests:

platform/ios/TestExpectations: Reenable test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:07 PM Changeset in webkit [254642] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r250024. rdar://problem/58605939

Unreviewed iOS 13 test gardening, update test expectations.

platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@250024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:05 PM Changeset in webkit [254641] by Ross Kirsling

2 edits in trunk/Source/WebCore

Unreviewed build fix for ENABLE_ACCESSIBILITY=OFF following r254566.

accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::wrapper const):
(WebCore::AXCoreObject::setWrapper):
Remove invalid override specifiers.

2:48 PM Changeset in webkit [254640] by Simon Fraser

2 edits in trunk/Source/WebCore

Unreviewed cleanup.

TextStream is used outside #if ENABLE(KINETIC_SCROLLING) lower down, so remove
these guards.

platform/PlatformWheelEvent.h:

2:23 PM Changeset in webkit [254639] by Jon Davis

2 edits in trunk/Websites/webkit.org

Add Web Inspector Reference notice to Web Inspector blog posts
https://bugs.webkit.org/show_bug.cgi?id=206308

Reviewed by Devin Rousso.

wp-content/themes/webkit/functions.php:

2:15 PM Changeset in webkit [254638] by Alan Coon

2 edits in branches/safari-609-branch/Source

Apply patch. rdar://problem/58610979

2:15 PM Changeset in webkit [254637] by Adrian Perez de Castro

2 edits in trunk/Source/JavaScriptCore

Offlineasm warnings with newer Ruby versions
https://bugs.webkit.org/show_bug.cgi?id=206233

Reviewed by Yusuke Suzuki.

Avoid a warning about using Object#=~ on Annotation instances, which
has been deprecated in Ruby 2.7.

offlineasm/parser.rb: Swap checks to prevent applying the =~ operator

to Annotation instances, which do not define it.

2:04 PM Changeset in webkit [254636] by ddkilzer@apple.com

4 edits in trunk/Tools

Enable -Wconditional-uninitialized in DumpRenderTree, WebKitTestRunner
<https://webkit.org/b/206269>
<rdar://problem/58589158>

Reviewed by Brent Fulgham.

DumpRenderTree/mac/Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.

DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Initialize imageRef stack variable to nullptr.

WebKitTestRunner/Configurations/Base.xcconfig:

(WARNING_CFLAGS): Add -Wconditional-uninitialized switch.

2:03 PM Changeset in webkit [254635] by Alan Coon

1 copy in tags/Safari-609.1.14.1

Tag Safari-609.1.14.1.

1:49 PM Changeset in webkit [254634] by Antti Koivisto

7 edits in trunk/Source/WebCore

[LFC] Cache display box for the first LayoutState to Layout::Box
https://bugs.webkit.org/show_bug.cgi?id=206288

Reviewed by Zalan Bujtas.

Add a single item cache for the common case to avoid using the hash.

layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::displayBox):

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::displayBoxForRootLayoutBox):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBoxSlow):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox): Deleted.
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const): Deleted.

layout/LayoutState.h:

(WebCore::Layout::Box::cachedDisplayBoxForLayoutState const):
(WebCore::Layout::LayoutState::hasDisplayBox const):
(WebCore::Layout::LayoutState::ensureDisplayBoxForLayoutBox):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::setCachedDisplayBoxForLayoutState const):

layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::hasCachedDisplayBox const):

layout/layouttree/LayoutTreeBuilder.h:

1:41 PM Changeset in webkit [254633] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: collapsing a virtualized folder in a WI.TreeOutline doesn't updated the DOM
https://bugs.webkit.org/show_bug.cgi?id=206302

Reviewed by Timothy Hatcher.

UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype._updateVirtualizedElements):
When collapsing a currently visible WI.TreeElement, it will still be in the cached set of
visible and attached WI.TreeElements, meaning that _updateVirtualizedElements will early
return since it thinks that the same WI.TreeElement are being shown. Add another check to
ensure that it only thinks that if the same number of WI.TreeElement are visible.

1:30 PM Changeset in webkit [254632] by keith_miller@apple.com

183 edits
7 deletes in trunk

Revert bytecode checkpoints since it breaks watch
https://bugs.webkit.org/show_bug.cgi?id=206301

Unreviewed, revert.

1:22 PM Changeset in webkit [254631] by Simon Fraser

9 edits
1 copy in trunk/Source/WebCore

Add more mousewheel-scrolling logging and improve the latching code
https://bugs.webkit.org/show_bug.cgi?id=206298

Reviewed by Tim Horton.

Make PlatformWheelEvent TextStream-loggable, and add more Scrolling logging in some places
related to mouseWheel scrolling and latching.

Make the ownership of Elements and Nodes given to ScrollLatchingState more explicit by passing in
RefPtr<>&&.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBox):
(WebCore::EventHandler::defaultWheelEventHandler):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformPrepareForWheelEvents):
(WebCore::EventHandler::platformCompleteWheelEvent):

page/scrolling/ScrollLatchingState.cpp:

(WebCore::ScrollLatchingState::setWheelEventElement):
(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement):
(WebCore::ScrollLatchingState::setScrollableContainer):

page/scrolling/ScrollLatchingState.h:
page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):

platform/PlatformWheelEvent.cpp: Copied from Source/WebCore/page/scrolling/ScrollLatchingState.cpp.

(WebCore::operator<<):

platform/PlatformWheelEvent.h:

1:17 PM Changeset in webkit [254630] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] LineLayoutContext::nextContentForLine should take LineCandidateContent&
https://bugs.webkit.org/show_bug.cgi?id=206300
<rdar://problem/58612197>

Reviewed by Antti Koivisto.

~5% progression on PerformanceTests/Layout/line-layout-simple.html.
LineLayoutContext::nextContentForLine is hot and LineCandidateContent has Vector members (too heavy).

layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineCandidateContent::reset):
(WebCore::Layout::LineLayoutContext::layoutLine):
(WebCore::Layout::LineLayoutContext::nextContentForLine):

layout/inlineformatting/LineLayoutContext.h:

12:42 PM Changeset in webkit [254629] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] ContinuousContent should not need a copy of RunList
https://bugs.webkit.org/show_bug.cgi?id=206293
<rdar://problem/58607446>

Reviewed by Antti Koivisto.

~4% progression on PerformanceTests/Layout/line-layout-simple.html.

layout/inlineformatting/InlineLineBreaker.cpp:

12:21 PM Changeset in webkit [254628] by aakash_jain@apple.com

4 edits
2 deletes in trunk

Unreviewed, rolling out r254576.
https://bugs.webkit.org/show_bug.cgi?id=206306

Introduced failing test loader/change-src-during-iframe-load-
crash.html (Requested by aakashja_ on #webkit).

Reverted changeset:

"Null Ptr Deref @
WebCore::DocumentLoader::clearMainResourceLoader"
https://bugs.webkit.org/show_bug.cgi?id=206204
https://trac.webkit.org/changeset/254576

Patch by Commit Queue <commit-queue@webkit.org> on 2020-01-15

12:18 PM Changeset in webkit [254627] by don.olmstead@sony.com

8 edits
3 deletes in trunk/Source/WebKit

Share WebInspector stubs for ports without local inspection
https://bugs.webkit.org/show_bug.cgi?id=206267

Reviewed by Alex Christensen.

No new tests. No change in behavior.

Ports that do no allow local inspection of a web page can share a number of stubs
around the Web Inspector. This is the case for iOS, WPE and the PlayStation port.
Make the platform guards specific to actual implementations.

SourcesWPE.txt:
UIProcess/RemoteWebInspectorProxy.cpp:
UIProcess/WebInspectorProxy.cpp:
UIProcess/mac/RemoteWebInspectorProxyMac.mm:
UIProcess/wpe/WebInspectorProxyWPE.cpp: Removed.
WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::localizedStringsURL const):

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL const):

WebProcess/WebPage/mac/WebInspectorUIMac.mm:
WebProcess/WebPage/wpe/WebInspectorUIWPE.cpp: Removed.
WebProcess/WebPage/wpe/WebInspectorWPE.cpp: Removed.

11:57 AM Changeset in webkit [254626] by Alexey Shvayka

4 edits in trunk

Object.preventExtensions should throw if not successful
https://bugs.webkit.org/show_bug.cgi?id=206131

Reviewed by Ross Kirsling.

JSTests:

test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

With this change, Object.preventExtensions throws TypeError if PreventExtensions
returns false. This is possible if Object.preventExtensions is called on a Proxy object.
(step 3 of https://tc39.es/ecma262/#sec-object.preventextensions)

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorPreventExtensions):

11:33 AM Changeset in webkit [254625] by Jonathan Bedard

5 edits in trunk

webkitpy: Remove self assignments
https://bugs.webkit.org/show_bug.cgi?id=206294

Reviewed by Aakash Jain.

Source/JavaScriptCore:

inspector/scripts/codegen/generator.py:

(Generator.js_name_for_parameter_type):

Tools:

Scripts/webkitpy/common/webkit_finder.py:

(WebKitFinder.webkit_base):

Scripts/webkitpy/port/factory.py:

(_builder_options):

11:16 AM Changeset in webkit [254624] by Alan Coon

19 edits in branches/safari-609-branch/Source

Cherry-pick r254551. rdar://problem/58508705

Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384

Rolling this out for the 2nd time.

Source/ThirdParty/ANGLE:

it caused issues with the shared dyld cache, because the cache doesn't know to include the libary until it already exists in the build
probably related to the above, we saw some performance regressions directly related to this change

ANGLE.xcodeproj/project.pbxproj:
Configurations/ANGLE.xcconfig:
Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
include/CMakeLists.txt:
include/GLSLANG/ShaderLang.h:
include/GLSLANG/ShaderVars.h:
src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: (rx::DisplayCGL::isValidNativeWindow const):
src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: (rx::WindowSurfaceCGL::WindowSurfaceCGL): (rx::WindowSurfaceCGL::~WindowSurfaceCGL):
src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: (rx::DisplayEAGL::terminate): (rx::DisplayEAGL::isValidNativeWindow const): (rx::WorkerContextEAGL::~WorkerContextEAGL):
src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm: (rx::WindowSurfaceEAGL::WindowSurfaceEAGL): (rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):

Source/WebCore:

Configurations/WebCore.xcconfig:
Configurations/WebCoreTestSupport.xcconfig:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::cleanupCompilers): (WebCore::ANGLEWebKitBridge::compileShaderSource): (WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254623] by Alan Coon

2 edits in branches/safari-609-branch/JSTests

Cherry-pick r254496. rdar://problem/58553161

Unreviewed. Change useLLInt=0 to forceBaseline=1

stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254622] by Alan Coon

45 edits
1 copy
3 adds in branches/safari-609-branch

Cherry-pick r254464. rdar://problem/58553161

Replace uses of Box<Identifier> with a new CacheableIdentifier class.
https://bugs.webkit.org/show_bug.cgi?id=205544
<rdar://problem/58041800>

Reviewed by Saam Barati.

JSTests:

stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js: Added.

Source/JavaScriptCore:

The introduction of the use of Box<Identifier> was to get around having to
ref/deref the underlying UniqedStringImpl in Identifiers from the compiler
and GC threads. However, it proves to be difficult to control when these
Box<Identifier>s get destructed, and requires that we find all the places in
the compier and GC threads where this can happen, and apply keep alive tactics
there to defer destruction of the Box<Identifier> to the mutator thread.

This patch fixes this by replacing uses of Box<Identifier> with
CacheableIdentifier, which is effectively a tagged union of a JSCell* or a
UniquedStringImpl*. The JSCell*, in this case, can be either a Symbol* or a
JSString* that is backed by an atom string. The VM runtime ensures that we'll
never try to cache an identifier from a JSCell that is not one of these. This
CacheableIdentifier can be destructed from the compiler or GC thread. Since it
doesn't hold a ref of the underlying UniquedStringImpl, it won't try to deref
it on destruction.

Instead, we'll need to visit CacheableIdentifiers during GC scans to keep the
JSCell in it alive, and that JSCell will, in turn, keep the underlying
UniquedStringImpl alive.

This patch also does the following:

Add a visitAggregate() method to StructureStubInfo, PolymorphicAccess, and AccessCase to visit the CacheableIdentifier's JSCell identifier. This visitAggregate() is called from CodeBlock::stronglyVisitStrongReferences().

When we write barrier a CodeBlock, it guarantees that its visitAggregate()
methods is called. However, it does not guarantee that its propagateTransitions()
method will be called. Since the CacheableIdentifier's reference to a cell
should be a strong reference, visiting it via a StructureStubInfo::visitAggregate()
method is the right thing to do.
See https://bugs.webkit.org/show_bug.cgi?id=205544#c7 for an example of why
propagateTransitions() doesn't always do the job.

StructureStubInfo::visitWeakReferences() is also inappropriate for this
because it is only called after all marking is done. It is also not meant
to keep cells alive but merely for clearing weak references to dead cells.

Also add to visitAggregate() for ModuleNamespaceData's m_identifier in GetByStatus::markIfCheap().

Remove previously applied keep alive tactics to work around Box<Identifier> destruction. This also retores the allowance to destruct DFG::Plans on a compiler thread.

Added a JSString:getValueImpl() helper.

Added a write barrier in DFG and FTL JITFinalizer's finalizeCommon() to ensure that frozen values are scanned by the GC.

During compilation, the frozen values were previously protected by the Plan.
After finalization, they should be protected by the CodeBlock. Hence, we
should barrier the CodeBlock since the last GC scan of the CodeBlock may have
happened before the frozen values were registered with the CodeBlock.

GC considerations:
==================
The following also addresses Yusuke's concerns in https://bugs.webkit.org/show_bug.cgi?id=205544#c10.

CacheableIdentifier is only stored as fields in 4 classes/structs:

AccessCase::m_identifier
GetByIdVariant::m_identifier
ModuleNamespaceData::m_identifier
StructureStubInfo::m_getByIdSelfIdentifier

AccessCase::m_identifier
========================
While the access case is being created and added in tryCacheGetBy(), the
CacheableIdentifier is still on the stack and protected from the GC. At the
bottom of tryCacheGetBy(), StructureStubInfo::addAccessCase() is called to add
the access case.

StructureStubInfo::addAccessCase() will barrier the owner CodeBlock at its end,
and CodeBlock::stronglyVisitStrongReferences() will visit the StructureStubInfo,
which in turn visits the AccessCase. StructureStubInfo::visitAggregate() has
been added for this purpose.

GetByIdVariant::m_identifier
============================
GetByIdVariant is only stored in GetByStatus. Both GetByIdVariant and GetByStatus
are only created and handled in the DFG/FTL compiler threads. While the compiler
thread is working with them, they are safe from the GC because the GC won't collect
objects until the compiler thread is at a SafePoint.

At compiler SafePoints, any GetByStatus that needs to be persisted is stored in
DFG::Plan::m_recordedStatuses. The Plan will visit the m_recordedStatuses in
Plan::checkLivenessAndVisitChildren().

At the end of compilation, Plan::m_recordedStatuses is transferred over to the owner
CodeBlock's DFG::CommonData in Plan::finalizeWithoutNotifyingCallback().
Plan::finalizeWithoutNotifyingCallback() will also barrier the owner CodeBlock at
its end.

Thereafter, CodeBlock::stronglyVisitStrongReferences() will visit the recordedStatuses.

ModuleNamespaceData::m_identifier
=================================
ModuleNamespaceData is only stored in a GetByStatus, and is therefore protected
similarly as the GetByIdVariant::m_identifier case above.

StructureStubInfo::m_getByIdSelfIdentifier
==========================================
StructureStubInfo::initGetByIdSelf() is called from inside tryCacheGetBy().
StructureStubInfo::initGetByIdSelf() will barrier the owner CodeBlock. The
CacheableIdentifier here is protected in the same way as the AccessCase::m_identifier
case above.

DesiredIdentifiers
==================
The compiler thread may also stash a CacheableIdentifier's uid in its
DesiredIdentifiers. Normally, the identifiers stashed in DesiredIdentifiers are
from identifiers that the CodeBlock already knows abut and manages (e.g. from
GetByIds). For uids from a cell-based CacheableIdentifier variable is passed to
a GetByVal, we need kep the cell alive in order to keep the uid alive. This is
achieved by freezing the cell with freezeStrong() in the op_get_by_val case in
the DFG BytecodeParser.

Reseting a StructureStubInfo while its IC code is still executing on the stack
==============================================================================
The concern is that IC code may call slow path / getter functions that may in turn:

reset the IC, and
run the GC.

This can be a problem if:

there is a scenario where we return from the slow path / getter function and run IC code that uses the cell / uid from the CacheableIdentifier.

This is because the StructureStubInfo is what visits the that cell, which
in turn its uid alive. Once the StructureStubInfo is reset, it will no
longer be associated with any AccessCase or the m_getByIdSelfIdentifier.
As such they will not be visited, and the CacheableIdentifier may be collected
by the GC.

In practice, the generated IC code never uses the cell / uid after it calls
any slow path / getter function. I've verified this by auditing the code
generation in InlineAccess::generateSelfInAccess() and PolymorphicAccess::regenerate().
Hence, there's no issue with using a collected cell / uid.

there is a scenario where a slow path / getter function makes use of the cell / uid from the CacheableIdentifier but does not protect it.

The only 2 slow path functions:

operationGetByValGeneric()
operationGetByValOptimize()

operationGetByValGeneric() does not use any CacheableIdentifier from the StructureStubInfo.

operationGetByValOptimize() modifies the StructureStubInfo in tryCacheGetBy()
under the protection of a GCSafeConcurrentJSLocker, and can reset the
StructureStubInfo. However, it does not use any CacheableIdentifier after
that.

Hence, there's also no GC issue here.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp: (JSC::AccessCase::AccessCase): (JSC::AccessCase::create): (JSC::AccessCase::fromStructureStubInfo): (JSC::AccessCase::commit): (JSC::AccessCase::canReplace const): (JSC::AccessCase::dump const): (JSC::AccessCase::visitAggregate const): (JSC::AccessCase::generateWithGuard): (JSC::AccessCase::generateImpl):
bytecode/AccessCase.h: (JSC::AccessCase::uid const): (JSC::AccessCase::identifier const):
bytecode/CodeBlock.cpp: (JSC::CodeBlock::propagateTransitions): (JSC::CodeBlock::stronglyVisitStrongReferences):
bytecode/GetByIdVariant.cpp: (JSC::GetByIdVariant::GetByIdVariant): (JSC::GetByIdVariant::attemptToMerge): (JSC::GetByIdVariant::visitAggregate): (JSC::GetByIdVariant::dumpInContext const):
bytecode/GetByIdVariant.h: (JSC::GetByIdVariant::identifier const): (JSC::GetByIdVariant::overlaps):
bytecode/GetByStatus.cpp: (JSC::GetByStatus::computeFromLLInt): (JSC::GetByStatus::computeFor): (JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback): (JSC::GetByStatus::visitAggregate): (JSC::GetByStatus::singleIdentifier const):
bytecode/GetByStatus.h:
bytecode/GetterSetterAccessCase.cpp: (JSC::GetterSetterAccessCase::GetterSetterAccessCase): (JSC::GetterSetterAccessCase::create):
bytecode/GetterSetterAccessCase.h:
bytecode/InstanceOfAccessCase.cpp: (JSC::InstanceOfAccessCase::InstanceOfAccessCase):
bytecode/IntrinsicGetterAccessCase.cpp: (JSC::IntrinsicGetterAccessCase::IntrinsicGetterAccessCase): (JSC::IntrinsicGetterAccessCase::create):
bytecode/IntrinsicGetterAccessCase.h:
bytecode/ModuleNamespaceAccessCase.cpp: (JSC::ModuleNamespaceAccessCase::ModuleNamespaceAccessCase): (JSC::ModuleNamespaceAccessCase::create):
bytecode/ModuleNamespaceAccessCase.h:
bytecode/PolymorphicAccess.cpp: (JSC::PolymorphicAccess::visitAggregate): (JSC::PolymorphicAccess::regenerate):
bytecode/PolymorphicAccess.h:
bytecode/ProxyableAccessCase.cpp: (JSC::ProxyableAccessCase::ProxyableAccessCase): (JSC::ProxyableAccessCase::create):
bytecode/ProxyableAccessCase.h:
bytecode/RecordedStatuses.cpp: (JSC::RecordedStatuses::visitAggregate):
bytecode/RecordedStatuses.h:
bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::addAccessCase): (JSC::StructureStubInfo::visitAggregate):
bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::getByIdSelfIdentifier):
dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseGetById): (JSC::DFG::ByteCodeParser::parseBlock):
dfg/DFGDesiredIdentifiers.cpp: (JSC::DFG::DesiredIdentifiers::ensure): (JSC::DFG::DesiredIdentifiers::at const): (JSC::DFG::DesiredIdentifiers::reallyAdd): (JSC::DFG::DesiredIdentifiers::processCodeBlockIdentifiersIfNeeded): Deleted.
dfg/DFGDesiredIdentifiers.h:
dfg/DFGJITFinalizer.cpp: (JSC::DFG::JITFinalizer::finalizeCommon):
dfg/DFGPlan.cpp: (JSC::DFG::Plan::~Plan): (JSC::DFG::Plan::checkLivenessAndVisitChildren): (JSC::DFG::Plan::cancel):
dfg/DFGPlan.h: (JSC::DFG::Plan::keepAliveIdentifier): Deleted.
dfg/DFGWorklist.cpp: (JSC::DFG::Worklist::removeAllReadyPlansForVM): (JSC::DFG::Worklist::removeDeadPlans): (JSC::DFG::Worklist::removeNonCompilingPlansForVM): (JSC::DFG::Worklist::deleteCancelledPlansForVM): Deleted.
dfg/DFGWorklist.h:
ftl/FTLJITFinalizer.cpp: (JSC::FTL::JITFinalizer::finalizeCommon):
jit/JITOperations.cpp:
jit/Repatch.cpp: (JSC::tryCacheGetBy): (JSC::repatchGetBy): (JSC::tryCacheArrayGetByVal): (JSC::tryCacheInstanceOf):
jit/Repatch.h:
runtime/CacheableIdentifier.cpp: Added. (JSC::CacheableIdentifier::dump const):
runtime/CacheableIdentifier.h: Added. (JSC::CacheableIdentifier::CacheableIdentifier): (JSC::CacheableIdentifier::isUid const): (JSC::CacheableIdentifier::isCell const): (JSC::CacheableIdentifier::isSymbol const): (JSC::CacheableIdentifier::operator bool const):
runtime/CacheableIdentifierInlines.h: Added. (JSC::CacheableIdentifier::CacheableIdentifier): (JSC::CacheableIdentifier::cell const): (JSC::CacheableIdentifier::uid const): (JSC::CacheableIdentifier::isCacheableIdentifierCell): (JSC::CacheableIdentifier::isSymbolCell const): (JSC::CacheableIdentifier::isStringCell const): (JSC::CacheableIdentifier::setCellBits): (JSC::CacheableIdentifier::setUidBits): (JSC::CacheableIdentifier::visitAggregate const): (JSC::CacheableIdentifier::operator== const): (JSC::CacheableIdentifier::operator!= const):
runtime/ExceptionHelpers.cpp: (JSC::functionCallBase):
runtime/JSString.h: (JSC::JSString::getValueImpl const):
runtime/VM.cpp: (JSC::VM::ensureWatchpointSetForImpureProperty): (JSC::VM::addImpureProperty): (JSC::VM::registerWatchpointForImpureProperty): Deleted.
runtime/VM.h:

Source/WebCore:

bindings/js/CommonVM.cpp: (WebCore::addImpureProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254621] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254415. rdar://problem/58548648

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Make iOS bots green until they can be updated.

Unreviewed.

platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254620] by Alan Coon

2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r254413. rdar://problem/58548648

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Unreviewed.

Fix build.

wtf/cocoa/LanguageCocoa.mm: (WTF::canMinimizeLanguages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254619] by Alan Coon

22 edits in branches/safari-609-branch

Cherry-pick r254412. rdar://problem/58548648

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Unreviewed.

Addressing additional review comments.

Source/WTF:

wtf/cocoa/LanguageCocoa.mm: (WTF::canMinimizeLanguages):

LayoutTests:

fast/text/international/system-language/navigator-language/navigator-language-en-GB.html:
fast/text/international/system-language/navigator-language/navigator-language-en-US.html:
fast/text/international/system-language/navigator-language/navigator-language-en.html:
fast/text/international/system-language/navigator-language/navigator-language-es-419.html:
fast/text/international/system-language/navigator-language/navigator-language-es-ES.html:
fast/text/international/system-language/navigator-language/navigator-language-es-MX.html:
fast/text/international/system-language/navigator-language/navigator-language-es.html:
fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html:
fast/text/international/system-language/navigator-language/navigator-language-fr.html:
fast/text/international/system-language/navigator-language/navigator-language-hi.html:
fast/text/international/system-language/navigator-language/navigator-language-ja.html:
fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html:
fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html:
fast/text/international/system-language/navigator-language/navigator-language-ru.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html:
fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254618] by Alan Coon

2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r254411. rdar://problem/58548648

Fix internal Apple builds after r254389
https://bugs.webkit.org/show_bug.cgi?id=206135

Rubber stamped by Zalan Bujtas.

wtf/spi/cocoa/NSLocaleSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254617] by Alan Coon

3 edits
1 add in branches/safari-609-branch

Cherry-pick r254393. rdar://problem/58553158

[JSC] Flush old tables in End phase
https://bugs.webkit.org/show_bug.cgi?id=206120
<rdar://problem/58039989>

Reviewed by Mark Lam.

JSTests:

stress/create-many-realms.js: Added. (foo):

Source/JavaScriptCore:

stopThePeriphery is stopping compiler threads and main thread (mutator), which means making m_worldIsStopped = true.
It is not for stopping all heap threads including a concurrent marker. The concurrent collector can work while executing
stopThePeriphery. This means that concurrent collectors can access to the old StructureIDTable while it is destroyed
in stopThePeriphery. Destroying old StructureIDTable in GC End phase, this is appropriate phase that we can ensure no
other threads (accessing to heap) are working including concurrent markers, mutator, and compiler threads.

heap/Heap.cpp: (JSC::Heap::runEndPhase): (JSC::Heap::stopThePeriphery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254616] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254391. rdar://problem/58548648

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Temporarily mark the navigator-language tests as flakey until I can figure out what to do with them.

Unreviewed.

platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:16 AM Changeset in webkit [254615] by Alan Coon

11 edits
41 adds
1 delete in branches/safari-609-branch

Cherry-pick r254389. rdar://problem/58548648

REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043
Source/WTF:

<rdar://problem/44119496>

Reviewed by Dean Jackson.

We ask the system for the current locale using CFLocaleCopyPreferredLanguages(), and then round-trip
it through CFBundleGetLocalizationInfoForLocalization() / CFBundleCopyLocalizationForLocalizationInfo().
This was to work around the fact that CFLocaleCopyPreferredLanguages() previously didn't report BCP47
language codes. However, that round-tripping was introducing errors, such as "zh-Hant-HK" was getting
turned into "zh-Hant-TW" which is clearly wrong. The CFBundle functions were never supposed to be used
in this way.

Instead, we can use CFLocaleCreateCanonicalLanguageIdentifierFromString() which is intended to
canonicalize locale identifiers, and does return BCP47 language codes. However, this function preserves
more fingerprinting entropy than the old code path, so we pass the input through new NSLocale SPI to
minimize the entropy revealed.

WTF.xcodeproj/project.pbxproj:
wtf/Language.h:
wtf/Platform.h:
wtf/PlatformMac.cmake:
wtf/cf/LanguageCF.cpp: (WTF::httpStyleLanguageCode): (WTF::platformUserPreferredLanguages):
wtf/cocoa/LanguageCocoa.mm: Added. (WTF::minimizedLanguagesFromLanguages):
wtf/spi/cocoa/NSLocaleSPI.h: Added.

Tools:

Reviewed by Dean Jackson.

Migrate system language tests to LayoutTests, to match the rest of our system language tests.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Removed.

LayoutTests:

<rdar://problem/44119496>

Reviewed by Dean Jackson.

Migrate and update tests from TestWebKitAPI to LayoutTests, to match the rest of our system language tests.

platform/mac/TestExpectations: Mark these tests as possibly failing on older versions of macOS.
fast/text/international/system-language/navigator-language/navigator-language-en-GB-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-en-US.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-en.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-419.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-ES.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-MX.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-es.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-fr-CA-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-fr.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-hi.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-ja.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-pt-PT-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-ru.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hans-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-TW-expected.txt: Added.
fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html: Added.
js/dom/navigator-language-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254614] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254374. rdar://problem/58549092

Resource Load Statistics: Align WebCore::NetworkStorageSession's m_thirdPartyCookieBlockingMode init value with r254239
https://bugs.webkit.org/show_bug.cgi?id=206082
<rdar://problem/58487498>

Unreviewed minor, follow-up fix.

platform/network/NetworkStorageSession.h:

The init value of m_thirdPartyCookieBlockingMode was changed to
ThirdPartyCookieBlockingMode::All to align it with r254239.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254613] by Alan Coon

8 edits in branches/safari-609-branch

Cherry-pick r254344. rdar://problem/58559189

Add SPI to enable TLS 1.0 and 1.1 in WKWebViews
https://bugs.webkit.org/show_bug.cgi?id=206046

Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-10
Reviewed by Youenn Fablet.

Source/WebKit:

This is needed for <rdar://problem/58464912>
Covered by API tests.

UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration legacyTLSEnabled]): (-[_WKWebsiteDataStoreConfiguration setLegacyTLSEnabled:]):
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters):
UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const):
UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: (WebKit::WebsiteDataStoreConfiguration::legacyTLSEnabled const): (WebKit::WebsiteDataStoreConfiguration::setLegacyTLSEnabled):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254612] by Alan Coon

7 edits
4 adds in branches/safari-609-branch

Cherry-pick r254322. rdar://problem/58549088

Block cross-site top-frame navigations from untrusted iframes
https://bugs.webkit.org/show_bug.cgi?id=206027
<rdar://problem/58320516>

Reviewed by Geoffrey Garen.

Source/WebCore:

Block cross-site top-frame navigations from untrusted iframes, unless they have a user gesture.
We already consider third-party iframes as untrusted, we now also treat first-party iframes
as untrusted if they are loaded both third-party scripts & iframes.

Test: http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html

dom/Document.cpp: (WebCore::Document::canNavigate): (WebCore::Document::willLoadScriptElement): (WebCore::Document::willLoadFrameElement): (WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking):
dom/Document.h:
dom/ScriptElement.cpp: (WebCore::ScriptElement::requestClassicScript):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL):

LayoutTests:

Add layout test coverage.

http/tests/security/block-top-level-navigations-by-third-party-iframes-expected.txt:
http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes-expected.txt: Added.
http/tests/security/block-top-level-navigations-by-untrusted-first-party-iframes.html: Added.
http/tests/security/resources/navigate-top-level-frame-to-failure-page-untrusted-iframe.html: Added.
http/tests/security/resources/navigate-top-to-error-page.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254611] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254310. rdar://problem/58552856

Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
https://bugs.webkit.org/show_bug.cgi?id=206035
<rdar://problem/58455306>

Reviewed by Brent Fulgham.

No new tests.

WebProcess/WebProcess.cpp: (WebKit::WebProcess::setResourceLoadStatisticsEnabled):

Added a check that m_sessionID exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254610] by Alan Coon

9 edits in branches/safari-609-branch/Source

Cherry-pick r254293. rdar://problem/58549084

Resource Load Statistics: Flip experimental website data removal setting from an enable to a disable
https://bugs.webkit.org/show_bug.cgi?id=205966
<rdar://problem/58425000>

Reviewed by Brent Fulgham.

To get default on behavior, experimental features in the network process need to be
turned from enable flags to disable flags. This patch does that for the experimental
website data removal flag.

Source/WebCore:

No new tests. This change just reverses the interpretation of a flag.

page/Settings.yaml:

Source/WebKit:

This change also aligns the init values of the setting to match the default.

NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
NetworkProcess/NetworkSession.h:
NetworkProcess/NetworkSessionCreationParameters.h:
Shared/WebPreferences.yaml:
UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess):
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254609] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254292. rdar://problem/58552868

Set the title for images so it will be correctly displayed in UIContextMenus
https://bugs.webkit.org/show_bug.cgi?id=205980
<rdar://problem/57701988>

Reviewed by Dean Jackson.

Need to set the title text for images.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView continueContextMenuInteraction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254608] by Alan Coon

3 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254288. rdar://problem/58548984

[Cocoa] persistent-usage-record message fails first time; succeeds subsequent times
https://bugs.webkit.org/show_bug.cgi?id=205970
<rdar://problem/57785647>

Reviewed by Eric Carlson.

The AVContentKeySession is created too early; before the CDM has a chance to provide the storage path
for persistent usage records. Delay creation of the AVCKS until it's actually needed during the first
license request.

Drive-by fix: fix the exceptional case where a PUR session is closed but PUR data isn't available; send
a null message rather than an empty array.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceFairPlayStreamingAVFObjC::contentKeySession): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): Deleted. (WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254607] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254287. rdar://problem/58552886

Fullscreen videos do not enter PiP in first tap
https://bugs.webkit.org/show_bug.cgi?id=205986

Reviewed by Eric Carlson.

This patch essentially reverts the fix for webkit.org/b/204461.
The fix for webkit.org/b/204461 depends on a fix in AVKit along
with a corresponding update in WebKit (webkit.org/b/204979).
We will need to reapply the fix for webkit.org/b/204461 after they are landed.

WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254606] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254261. rdar://problem/58549081

REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205886
<rdar://problem/58387910>

Reviewed by Chris Dumez.

Make sure registrations are stored on disk before crashing the network process.

http/wpt/service-workers/persistent-importScripts.html:
platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254605] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254260. rdar://problem/58552882

REGRESSION: [ Mac ] webrtc/video-autoplay.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205893
<rdar://problem/58391046>

Reviewed by Eric Carlson.

webrtc/video-autoplay.html: Speculative fix as I am not able to reproduce locally. Hypothesis is that removing from DOM the video element is supposed to asynchronously pause the video element. We should therefore ensure that the video element is paused before calling getUserMedia.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254604] by Alan Coon

5 edits in branches/safari-609-branch

Cherry-pick r254254. rdar://problem/58548978

WebKitTestRunner leaks objects in a top-level autoreleasePool that's never cleared
<https://webkit.org/b/205950>
<rdar://problem/50987831>

Reviewed by Joseph Pecoraro.

Source/WebKit:

UIProcess/mac/WebPreferencesMac.mm: (WebKit::WebPreferences::platformInitializeStore):
Add an @autoreleasepool block around the contents of this method since it generates numerous autoreleased objects when run.

Tools:

WebKitTestRunner/ios/mainIOS.mm: (main):
Add an @autoreleasepool block around a line of code that generates autoreleased objects. These objects would never be released for the life of the process prior to this change.
WebKitTestRunner/mac/main.mm: (main):
Move instantiation of WTR::TestController outside of @autoreleasepool block so the pool can be drained while running tests. Prior to this change, this autoreleasePool would never be drained.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254603] by Alan Coon

2 edits in branches/safari-609-branch/JSTests

Cherry-pick r254247. rdar://problem/58553146

Unreviewed follow up on r254188. I accidentally included the same test
twice instead of including the two different variants.

stress/ai-value-mod-should-result-in-constant-int-where-possible.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254602] by Alan Coon

2 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r254244. rdar://problem/58553148

Instruction.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205945

Reviewed by Mark Lam.

bytecode/Instruction.h: (JSC::BaseInstruction::size const): Changed the types to size_t so that the computation is computed accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254601] by Alan Coon

9 edits in branches/safari-609-branch/Source

Cherry-pick r254239. rdar://problem/58549100

Resource Load Statistics: Flip experimental cookie blocking setting from an enable to a disable
https://bugs.webkit.org/show_bug.cgi?id=205963
<rdar://problem/58424136>

Reviewed by Brent Fulgham.

To get default on behavior, experimental features in the network process need to be
turned from enable flags to disable flags. This patch does that for the experimental
cookie blocking flag.

Source/WebCore:

No new tests. This change just reverses the interpretation of a flag.

page/Settings.yaml:

Source/WebKit:

This change also aligns the init values of the setting to match the default.

NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
NetworkProcess/NetworkSession.h:
NetworkProcess/NetworkSessionCreationParameters.h:
Shared/WebPreferences.yaml:
UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess):
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254600] by Alan Coon

2 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r254218. rdar://problem/58553153

JSArrayBufferView.h: Multiplication result converted to larger type
https://bugs.webkit.org/show_bug.cgi?id=205943

Reviewed by Saam Barati.

Added cast to size_t to make the whole calculation size_t.

runtime/JSArrayBufferView.h: (JSC::JSArrayBufferView::sizeOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254599] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254208. rdar://problem/58559193

IPC::Connection::sendMessage() should use CRASH_WITH_INFO()
<https://webkit.org/b/205419>
<rdar://problem/58058661>

Reviewed by Mark Lam.

Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::Connection::sendMessage):
Switch from CRASH() to CRASH_WITH_INFO().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254598] by Alan Coon

7 edits
2 adds in branches/safari-609-branch

Cherry-pick r254201. rdar://problem/58552859

[Web Animations] Stop creating CSS Animations for <noscript> elements
https://bugs.webkit.org/show_bug.cgi?id=205925
<rdar://problem/58158479>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: webanimations/no-css-animation-on-noscript.html

It makes no sense to create CSS Animations for a <noscript> element and it has the side effect of potential crashes.
Indeed, AnimationTimeline::updateCSSAnimationsForElement() may be called without a currentStyle and so we never have
a list of previously-applied animations to compare to the list of animations in afterChangeStyle. So on each call we
end up creating a new CSSAnimation and the previous animation for the same name is never explicitly removed from the
effect stack and is eventually destroyed and the WeakPtr for it in the stack ends up being null, which would cause a
crash under KeyframeEffectStack::ensureEffectsAreSorted().

We now prevent elements such as <noscript> from being considered for CSS Animations in TreeResolver::resolveElement().

dom/Element.cpp: (WebCore::Element::rendererIsNeeded):
dom/Element.h: (WebCore::Element::rendererIsEverNeeded):
html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsEverNeeded): (WebCore::HTMLElement::rendererIsNeeded): Deleted.
html/HTMLElement.h:
style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):

LayoutTests:

Add a new test that checks that setting the animation property on a <noscript> element does not yield the creation of a CSSAnimation object.

webanimations/no-css-animation-on-noscript-expected.txt: Added.
webanimations/no-css-animation-on-noscript.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254597] by Alan Coon

3 edits
2 adds in branches/safari-609-branch

Cherry-pick r254188. rdar://problem/58553146

AI rule for ValueMod/ValueDiv produce constants with the wrong format when the result can be an int32
https://bugs.webkit.org/show_bug.cgi?id=205906
<rdar://problem/56108519>

Reviewed by Yusuke Suzuki.

JSTests:

stress/ai-value-div-should-result-in-constant-int-where-possible.js: Added. (foo.bar.f): (foo.): (foo):
stress/ai-value-mod-should-result-in-constant-int-where-possible.js: Added. (foo.bar.f): (foo.): (foo):

Source/JavaScriptCore:

The runtime code for ValueMod and ValueDiv produces an int32 when the result
is of int32 value. However, the AI was saying the result is in double format.
This patch fixes AI to produce a JSValue in the right format.

dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::handleConstantDivOp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254596] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKitLegacy

Cherry-pick r254169. rdar://problem/58552876

REGRESSION (r248734): different threads write m_storageMap of StorageAreaImpl at the same time
https://bugs.webkit.org/show_bug.cgi?id=205764
<rdar://problem/58179425>

Reviewed by Maciej Stachowiak.

In StorageAreaImpl, we avoid modifying m_storageMap from different threads at the same time by blocking main
thread access to it until the writes(importing items) of storage thread is done.

In r248734 we introduced a new case where the main thread could modify m_storageMap for session change, but we
didn't add the wait there.

Storage/StorageAreaImpl.cpp: (WebKit::StorageAreaImpl::importItems): (WebKit::StorageAreaImpl::sessionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:15 AM Changeset in webkit [254595] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254157. rdar://problem/58549081

REGRESSION: [ Mac wk2 ] http/wpt/service-workers/persistent-importScripts.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205886

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254594] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254155. rdar://problem/58552864

Add a move constructor to IDBResultData
https://bugs.webkit.org/show_bug.cgi?id=205833
<rdar://problem/58146233>

Reviewed by Youenn Fablet.

Modules/indexeddb/shared/IDBResultData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254593] by Alan Coon

4 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r254152. rdar://problem/58552854

[JSC] Remove vm accessor in JSVirtualMachine to reduce binary size
https://bugs.webkit.org/show_bug.cgi?id=205880

Reviewed by Mark Lam.

Objective-C has reflection mechanism. This means that fields, methods, and their types
need to hold its string representations in binary even if we are using release build.
While typical Objective-C class does not have large size of type names, C++ struct / class
has very large one, and putting them in Objective-C method names, parameter types, or fields
makes binary size very large.

By analyzing JavaScriptCore binary, I found that Objective-C method type symbols are taking 200~KB
binary size. (Section objc_methtype: 235081 (addr 0x105e9a3 offset 17164707)). And it is due to
JSC::VM type included in [JSVirtualMachine vm] accessor.

This patch removes this accessor and gets 200KB binary size reduction.

API/JSScript.mm: (-[JSScript readCache]): (-[JSScript sourceCode]): (-[JSScript jsSourceCode]): (-[JSScript writeCache:]):
API/JSVirtualMachine.mm: (-[JSVirtualMachine JSContextGroupRef]): (-[JSVirtualMachine isWebThreadAware]): (-[JSVirtualMachine vm]): Deleted.
API/JSVirtualMachineInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254592] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254147. rdar://problem/58549096

Reformat WebFrameLoaderClient logging
https://bugs.webkit.org/show_bug.cgi?id=205869
<rdar://problem/58379240>

Reviewed by Brent Fulgham.

Update the format used by WebFrameLoaderClient in its RELEASE_LOG
logging. Use the format used by WebPageProxy and
NetworkResourceLoader, which is generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4a1d7c310 - WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition, page = 0x7f83ba009208

becomes:

0x4a1d7c310 - [webFrame=0x7ff703f03b68, webFrameID=3, webPage=0x7ff704831808, webPageID=15] WebFrameLoaderClient::dispatchDidReachLayoutMilestone: dispatching didCompletePageTransition

No new tests - no added or changed functionality.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254591] by Alan Coon

5 edits in branches/safari-609-branch

Cherry-pick r254145. rdar://problem/58552861

REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807
<rdar://problem/58344669>

Reviewed by Dean Jackson.

Source/WebInspectorUI:

UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.async createBootstrapScript): (WI.NetworkManager.prototype._handleBootstrapScriptContentDidChange): Ensure that Page.setBootstrapScript is called when restoring the bootstrap script from the IndexedDB storage. Otherwise, in situations like when Web Inspector is first opened, we will show the Inspector Bootstrap Script in the UI, but not actually set it on the inspected page.

LayoutTests:

inspector/page/setBootstrapScript-main-frame.html: In addition to waiting for Page.reload, we should also wait for the page to actually load. Set the content of the bootstrap script during its creation instead of as a two step process. Avoid an assertion by setting the enabled state after the bootstrap script is initalized.

platform/mac/TestExpectations: Remove expectation added in r254059.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254590] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore/PAL

Cherry-pick r254141. rdar://problem/58559202

Flaky API Test: TestWebKitAPI.WebKitLegacy.AudioSessionCategoryIOS
https://bugs.webkit.org/show_bug.cgi?id=194340
<rdar://problem/50507254>

Reviewed by Eric Carlson.

Workaround for AVFoundation crash for OS versions prior to platform fix. This crash occurrs infrequently
while triggering KVO due to an internal @property change. Work around the crash by disabling KVO for that
property at runtime, by injecting a new class method +automaticallyNotifiesObserversOfSuppressesVideoLayers
immediately after soft linking the AVFoundation library.

pal/cocoa/AVFoundationSoftLink.mm: (PAL::justReturnsNO): (PAL::AVFoundationLibrary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254589] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254099. rdar://problem/58552889

[iOS] Only prewarm fonts with valid font names
https://bugs.webkit.org/show_bug.cgi?id=205822

Reviewed by Brent Fulgham.

The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.

No new tests, no behavior change.

platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::prewarmGlobally):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254588] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254092. rdar://problem/58552872

NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
https://bugs.webkit.org/show_bug.cgi?id=205824
<rdar://problem/55107625>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-01-06
Reviewed by Chris Dumez.

Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
This was introduced in r252185 or r248640.

NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::isolatedSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254587] by Alan Coon

3 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254078. rdar://problem/58549073

Reformat WebPage logging
https://bugs.webkit.org/show_bug.cgi?id=205709
<rdar://problem/58290285>

Reviewed by Brent Fulgham.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)',

becomes:

0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2)

This new form is a lot more verbose, but it really helps in tracing
activity from the top of our page/frame/resource load stack to the
bottom.

No new tests - no added or changed functionality.

WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoad): (WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler): (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): (WebKit::WebLoaderStrategy::networkProcessCrashed): (WebKit::WebLoaderStrategy::loadResourceSynchronously):
WebProcess/Network/WebLoaderStrategy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254586] by Alan Coon

6 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254074. rdar://problem/58549078

REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1
https://bugs.webkit.org/show_bug.cgi?id=205810

Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042.

platform/mac-wk1/pageoverlay/overlay-installation-expected.txt:
platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt:
platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt:
platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt:
platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254585] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r254067. rdar://problem/58552878

REGRESSION(r247626): Introduced memory regression
https://bugs.webkit.org/show_bug.cgi?id=205815

Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.

platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::prewarmGlobally): (WebCore::fontFamiliesForPrewarming): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254584] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKitLegacy/mac

Cherry-pick r254063. rdar://problem/58559198

[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=205791

Patch by Antoine Quint <Antoine Quint> on 2020-01-06
Reviewed by Dean Jackson.

It was an oversight that it had not been done along with the WebKit change.

WebView/WebPreferences.mm: (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254583] by Alan Coon

2 edits in branches/safari-609-branch/LayoutTests

Cherry-pick r254059. rdar://problem/58552861

REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807

Unreviewed test gardening.

platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254582] by Alan Coon

12 edits
2 adds in branches/safari-609-branch

Cherry-pick r254054. rdar://problem/58549108

REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'
https://bugs.webkit.org/show_bug.cgi?id=205694
<rdar://problem/58062987>

Reviewed by Zalan Bujtas.

Source/WebCore:

After r252724, which separated 'used' from 'specified' z-index in style, we need to copy
the specified to the used z-index in animated styles, while preserving the existing 'forceStackingContext'
behavior which set the used z-index to 0.

Do so by creating Adjuster::adjustAnimatedStyle(), which is called from TreeResolver::createAnimatedElementUpdate()
if any animations could have affected the style. We need to pass back information about whether the animation should
force stacking context.

Test: animations/z-index-in-keyframe.html

animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::apply):
animation/KeyframeEffect.h: (WebCore::KeyframeEffect::triggersStackingContext const):
dom/Element.cpp: (WebCore::Element::applyKeyframeEffects):
dom/Element.h:
page/animation/CSSAnimationController.h: (): Deleted.
page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::animate):
style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjustAnimatedStyle):
style/StyleAdjuster.h:
style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate):

LayoutTests:

animations/z-index-in-keyframe-expected.html: Added.
animations/z-index-in-keyframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254581] by Alan Coon

11 edits in branches/safari-609-branch

Cherry-pick r254042. rdar://problem/58549102

Source/WebCore/PAL:
DumpRenderTree doesn't always call updateRendering() when a test completes
https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Add -[CATransaction synchronize].

pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:
DumpRenderTree doesn't always call updateRendering() when a test completes
https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Use the QuartzCore SPI header.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Source/WebKitLegacy/mac:
Fix a souce of WebKit1 test flakiness
https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Some animation tests (and possibly many others) are flakey or broken in WK1 because
there was no code to guarantee that Page::updateRendering() was called at notifyDone()
time.

WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers,
and flushes a CATransaction.

In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView,
and just called [webView display] to make this happen. However, with layer backing, AppKit behavior
changes, and WebCore changes that make more things happen with HTML event loop timing, this
approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what
WK2 is doing.

WebView/WebView.mm: (-[WebView _forceRepaintForTesting]):
WebView/WebViewPrivate.h:

Tools:
DumpRenderTree doesn't always call updateRendering() when a test completes
https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Some animation tests (and possibly many others) are flakey or broken in WK1 because
there was no code to guarantee that Page::updateRendering() was called at notifyDone()
time.

WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers,
and flushes a CATransaction.

In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView,
and just called [webView display] to make this happen. However, with layer backing, AppKit behavior
changes, and WebCore changes that make more things happen with HTML event loop timing, this
approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what
WK2 is doing.

DumpRenderTree/mac/DumpRenderTree.mm: (updateDisplay):
DumpRenderTree/mac/PixelDumpSupportMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [254580] by Alan Coon

2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r254033. rdar://problem/58548645

Reformat WebPage logging
https://bugs.webkit.org/show_bug.cgi?id=205705
<rdar://problem/58288704>

Reviewed by Alex Christensen.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0

becomes:

0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)

No new tests - no added or changed functionality.

WebProcess/WebPage/WebPage.cpp: (WebKit::m_overriddenMediaType): (WebKit::WebPage::createPlugin): (WebKit::WebPage::freezeLayerTree): (WebKit::WebPage::unfreezeLayerTree): (WebKit::WebPage::markLayersVolatile): (WebKit::WebPage::cancelMarkLayersVolatile): (WebKit::WebPage::touchEventSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:12 AM Changeset in webkit [254579] by Devin Rousso

2 edits in trunk/Websites/webkit.org

Web Inspector Reference: the meta info at the end of the article should always be on its own line
https://bugs.webkit.org/show_bug.cgi?id=206277

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/style.css:

(article .bodycopy, article .meta):

11:11 AM Changeset in webkit [254578] by Devin Rousso

3 edits in trunk/Websites/webkit.org

Web Inspector Reference: put the original author and last modified author on separate lines
https://bugs.webkit.org/show_bug.cgi?id=206274

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/single-web_inspector_page.php:
wp-content/themes/webkit/style.css:

(article .meta .written): Added.
(article .meta .written, article .meta .updated): Added.
(article .meta .updated): Deleted.

10:58 AM Changeset in webkit [254577] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is a flaky failure on Mac wk2
https://bugs.webkit.org/show_bug.cgi?id=206296

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

10:40 AM Changeset in webkit [254576] by achristensen@apple.com

4 edits
2 adds in trunk

Null Ptr Deref @ WebCore::DocumentLoader::clearMainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=206204

Source/WebCore:

Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-01-15
Reviewed by Alex Christensen.

Test: loader/change-src-during-iframe-load-crash.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::frameLoader const):
(WebCore::DocumentLoader::clearMainResourceLoader):

LayoutTests:

Added a NULL pointer check for FrameLoader. If FramLoader is NULL then return instead of
accessing activeDocumentLoader.

Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-01-15
Reviewed by Alex Christensen.

loader/change-src-during-iframe-load-crash-expected.txt: Added.
loader/change-src-during-iframe-load-crash.html: Added.

10:22 AM Changeset in webkit [254575] by Jon Davis

2 edits in trunk/Websites/webkit.org

Ensure UAs update the stylesheet
https://bugs.webkit.org/show_bug.cgi?id=206292

Reviewed by Devin Rousso.

wp-content/themes/webkit/header.php:

9:59 AM Changeset in webkit [254574] by jer.noble@apple.com

7 edits
2 adds in trunk

Revert fullscreen CSS quirk for reddit.com; add width and height style to fullscreen.css.
https://bugs.webkit.org/show_bug.cgi?id=206206

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/fullscreen-user-agent-style.html

Add the "width:100%;height:100%;" from the modern Fullscreen API spec to our own
fullscreen stylesheet, and revert the quirk for reddit.com.

css/fullscreen.css:

(:-webkit-full-screen):

page/Quirks.cpp:

(WebCore::Quirks::needsFullWidthHeightFullscreenStyleQuirk const): Deleted.

page/Quirks.h:
style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

LayoutTests:

fullscreen/full-screen-test.js:

(waitFor):

fullscreen/fullscreen-user-agent-style-expected.txt: Added.
fullscreen/fullscreen-user-agent-style.html: Added.

9:50 AM Changeset in webkit [254573] by Truitt Savell

3 edits in trunk/LayoutTests

REGRESSION: [ Mac iOS ] storage/websql/statement-error-callback.html is timing out flakily
https://bugs.webkit.org/show_bug.cgi?id=206291

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac/TestExpectations:

9:48 AM Changeset in webkit [254572] by weinig@apple.com

4 edits
1 copy in trunk/Source/WTF

Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h
https://bugs.webkit.org/show_bug.cgi?id=206272

Reviewed by Anders Carlsson.

As a another step towards cleaning up Platform.h, split out all the legacy platform
macros into their own file.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Platform.h:
wtf/PlatformLegacy.h: Copied from Source/WTF/wtf/Platform.h.

9:18 AM Changeset in webkit [254571] by Alan Coon

19 edits in branches/safari-609.1.14-branch/Source

Cherry-pick r254551. rdar://problem/58508705

Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384

Rolling this out for the 2nd time.

Source/ThirdParty/ANGLE:

it caused issues with the shared dyld cache, because the cache doesn't know to include the libary until it already exists in the build
probably related to the above, we saw some performance regressions directly related to this change

ANGLE.xcodeproj/project.pbxproj:
Configurations/ANGLE.xcconfig:
Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
include/CMakeLists.txt:
include/GLSLANG/ShaderLang.h:
include/GLSLANG/ShaderVars.h:
src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: (rx::DisplayCGL::isValidNativeWindow const):
src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: (rx::WindowSurfaceCGL::WindowSurfaceCGL): (rx::WindowSurfaceCGL::~WindowSurfaceCGL):
src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: (rx::DisplayEAGL::terminate): (rx::DisplayEAGL::isValidNativeWindow const): (rx::WorkerContextEAGL::~WorkerContextEAGL):
src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm: (rx::WindowSurfaceEAGL::WindowSurfaceEAGL): (rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):

Source/WebCore:

Configurations/WebCore.xcconfig:
Configurations/WebCoreTestSupport.xcconfig:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::cleanupCompilers): (WebCore::ANGLEWebKitBridge::compileShaderSource): (WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:14 AM Changeset in webkit [254570] by Alan Coon

19 edits in branches/safari-610.1.1-branch/Source

Cherry-pick r254551. rdar://problem/58508705

Build ANGLE as a dynamic library
https://bugs.webkit.org/show_bug.cgi?id=204708
rdar://57349384

Rolling this out for the 2nd time.

Source/ThirdParty/ANGLE:

it caused issues with the shared dyld cache, because the cache doesn't know to include the libary until it already exists in the build
probably related to the above, we saw some performance regressions directly related to this change

ANGLE.xcodeproj/project.pbxproj:
Configurations/ANGLE.xcconfig:
Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
include/CMakeLists.txt:
include/GLSLANG/ShaderLang.h:
include/GLSLANG/ShaderVars.h:
src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: (rx::DisplayCGL::isValidNativeWindow const):
src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: (rx::WindowSurfaceCGL::WindowSurfaceCGL): (rx::WindowSurfaceCGL::~WindowSurfaceCGL):
src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: (rx::DisplayEAGL::terminate): (rx::DisplayEAGL::isValidNativeWindow const): (rx::WorkerContextEAGL::~WorkerContextEAGL):
src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm: (rx::WindowSurfaceEAGL::WindowSurfaceEAGL): (rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):

Source/WebCore:

Configurations/WebCore.xcconfig:
Configurations/WebCoreTestSupport.xcconfig:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::cleanupCompilers): (WebCore::ANGLEWebKitBridge::compileShaderSource): (WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
platform/graphics/ANGLEWebKitBridge.h:
platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: (WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:18 AM Changeset in webkit [254569] by ddkilzer@apple.com

11 edits in trunk/Source/WebKit

[Cocoa] Create a simulated crash log when the UI Process receives an invalid CoreIPC message
<https://webkit.org/b/205368>
<rdar://problem/58024593>

Reviewed by Chris Dumez.

UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::logInvalidMessage):

Extract common logging code to new method that calls RELEASE_LOG_FAULT().
UIProcess/AuxiliaryProcessProxy.h:

(WebKit::AuxiliaryProcessProxy::logInvalidMessage):
(WebKit::AuxiliaryProcessProxy::processName):

Add method declarations.

UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::didReceiveInvalidMessage):

Use new AuxiliaryProcessProxy::logInvalidMessage().
UIProcess/GPU/GPUProcessProxy.h:

(WebKit::GPUProcessProxy::processName const):

Add implementation.

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):

Use new AuxiliaryProcessProxy::logInvalidMessage().
UIProcess/Network/NetworkProcessProxy.h:

(WebKit::NetworkProcessProxy::processName const):

Add implementation.

UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didReceiveInvalidMessage):

Use new AuxiliaryProcessProxy::logInvalidMessage().
UIProcess/Plugins/PluginProcessProxy.h:

(WebKit::PluginProcessProxy::processName const):

Add implementation.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInvalidMessage):

Use new AuxiliaryProcessProxy::logInvalidMessage().
UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::processName const):

Add implementation.

7:46 AM Changeset in webkit [254568] by Antti Koivisto

4 edits in trunk/Source/WebCore

[LFC][Integration] Call SimpleLineLayout::canUseFor only once
https://bugs.webkit.org/show_bug.cgi?id=206281

Reviewed by Sam Weinig.

It can be somewhat costly.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::canUseFor):

layout/integration/LayoutIntegrationLineLayout.h:

(WebCore::LayoutIntegration::LineLayout::canUseFor):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):

6:44 AM Changeset in webkit [254567] by clopez@igalia.com

6 edits in trunk

[GTK] Turn off antialiasing when rendering with Ahem
https://bugs.webkit.org/show_bug.cgi?id=204671

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Many CSS related tests use the "Ahem" font to compare its special
squared glyphs with the positioned elements of the test. But if
we enable antialiasing for this font, then the antialiasing of
the glyphs causes small pixel differences with the reference test.

So, this patch disables antialiasing for the Ahem font in GTK and WPE
ports. This commit its pretty much like r252701 for the Mac/iOS ports.

Covered by existing tests.

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawGlyphs):

platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

LayoutTests:

platform/gtk/TestExpectations:

6:42 AM Changeset in webkit [254566] by Andres Gonzalez

13 edits in trunk/Source/WebCore

Implementation of AXIsolatedObject::press().
https://bugs.webkit.org/show_bug.cgi?id=206177

Reviewed by Chris Fleizach.

Implemented AXIsolatedObject::press().
For link objects, press causes the destruction and re-creation of the

isolated tree. Thus also added AXIsolatedTree:removeTreeForPageID.

AXIsolatedTree::applyPendingChanges now also properly detaches isolated

objects that have been removed.

Moved set and get wrapper to AXCoreObject so that it can be used for

both isolated and live objects.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::createIsolatedTreeHierarchy):

accessibility/AXObjectCache.h: