Timeline
Mar 16, 2020:
- 10:27 PM Changeset in webkit [258541] by
-
- 6 edits in trunk
Remove the zero-delay ScrollingCoordinatorMac commit timer
https://bugs.webkit.org/show_bug.cgi?id=209164
Reviewed by Zalan Bujtas.
Source/WebCore:
The scrolling tree on macOS should just commit at rendering update time. There's no need
for a separate zero-delay timer.
Tested by existing tests.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorMac::commitTreeState): Deleted.
LayoutTests:
Dumping layers just made this test flakey. It's enough to test for scroll events on the overflow.
- tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt:
- tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html:
- 10:22 PM Changeset in webkit [258540] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] JSMapIterator and JSSetIterator are CellType
https://bugs.webkit.org/show_bug.cgi?id=209168
<rdar://problem/59705631>
Reviewed by Saam Barati.
They are JSCell, not JSObject since they are not used as a user-observable set/map iterators in JSC.
However, their JSType is ObjectType. They should use CellType instead.
- runtime/JSMapIterator.h:
- runtime/JSSetIterator.h:
- 10:09 PM Changeset in webkit [258539] by
-
- 5 edits in trunk/Source
Add a bit more UIHitTesting logging, and make it possible to dump EventRegions from WebKit
https://bugs.webkit.org/show_bug.cgi?id=209058
Reviewed by Antti Koivisto.
Source/WebCore:
Export operator<<(TextStream&, const EventRegion&) so it can be used from Webkit.
- rendering/EventRegion.h:
Source/WebKit:
Add a UIHitTesting log.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
- 9:44 PM Changeset in webkit [258538] by
-
- 2 edits in trunk/Source/WebCore
Remove a 'using namespace WebCore' in MediaSessionManagerCocoa
https://bugs.webkit.org/show_bug.cgi?id=209162
Reviewed by Simon Fraser.
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
Unified source cleanliness. Not currently causing any trouble, but
it did when I changed something locally!
- 7:30 PM WebKitGTK/2.28.x edited by
- (diff)
- 6:32 PM Changeset in webkit [258537] by
-
- 3 edits in trunk/LayoutTests
WPE and GTK gardening.
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 6:01 PM Changeset in webkit [258536] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r257380): Web Inspector: deleting node causes TreeOutline to lose focus
https://bugs.webkit.org/show_bug.cgi?id=208364
<rdar://problem/59871772>
Reviewed by Devin Rousso.
Maintain keyboard focus within TreeOutline when selection changes.
- UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.select):
- 5:32 PM Changeset in webkit [258535] by
-
- 1 copy in tags/Safari-610.1.7.4
Tag Safari-610.1.7.4.
- 5:31 PM Changeset in webkit [258534] by
-
- 8 edits in branches/safari-610.1.7-branch/Source
Versioning.
- 5:30 PM Changeset in webkit [258533] by
-
- 2 edits in trunk/Source/WebCore/PAL
Build fix.
- pal/spi/cocoa/AVFoundationSPI.h:
r258314 was missing a nullability annotation.
- 5:14 PM Changeset in webkit [258532] by
-
- 3 edits2 adds in trunk
A change event gets dispatched when textarea gets changed without focus
https://bugs.webkit.org/show_bug.cgi?id=202144
Patch by ChangSeok Oh <ChangSeok Oh> on 2020-03-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
A crash happens in WebCore::ValidationMessage::buildBubbleTree. An immediate reason
is that DOM tree is modified in buildBubbleTree triggered by a timer.
The function calls document.updateLayout() that causes a change event
for textarea to fire when something changed in the textarea.
This bug is not reproduced on Mac because buildBubbleTree is not called.
See ValidationMessage::setMessage.
On the other hand, the root cause of this issue is triggering the change event
for textarea even if it is not focused when a change is made. This behavior
is different to what Gecko and Chromium do. When loading the test, they do not
trigger the change event although the textarea is filled by the script
since the textarea is not focused. Only when we manually make a change (meaning
the textarea is focused by user input), the event gets dispatched. To fix it,
setChangedSinceLastFormControlChangeEvent(true) is moved below the focus check
in HTMLTextAreaElement::subtreeHasChanged();
Test: fast/forms/textfield-onchange-without-focus.html
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
LayoutTests:
The test should be identical to the extected result without crash.
- fast/forms/textfield-onchange-without-focus-expected.html: Added.
- fast/forms/textfield-onchange-without-focus.html: Added.
- 5:12 PM Changeset in webkit [258531] by
-
- 13 edits1 add in trunk
JavaScript identifier grammar supports unescaped astral symbols, but JSC doesn’t
https://bugs.webkit.org/show_bug.cgi?id=208998
Reviewed by Michael Saboff.
JSTests:
- stress/unicode-identifiers-with-surrogate-pairs.js: Added.
(let.c.of.chars.eval.foo):
(throwsSyntaxError):
(let.c.of.continueChars.throwsSyntaxError.foo):
Source/JavaScriptCore:
This patch fixes a bug in the parser that allows for surrogate pairs when parsing identifiers.
It also makes a few other changes to the parser:
1) When looking for keywords we just need to check that subsequent
character cannot be a identifier part or an escape start.
2) The only time we call parseIdentifierSlowCase is when we hit an
escape start or a surrogate pair so we can optimize that to just
copy everything up slow character into our buffer.
3) We shouldn't allow for asking if a UChar is an identifier start/part.
- KeywordLookupGenerator.py:
(Trie.printSubTreeAsC):
(Trie.printAsC):
- parser/Lexer.cpp:
(JSC::isNonLatin1IdentStart):
(JSC::isIdentStart):
(JSC::isSingleCharacterIdentStart):
(JSC::cannotBeIdentStart):
(JSC::isIdentPart):
(JSC::isSingleCharacterIdentPart):
(JSC::cannotBeIdentPartOrEscapeStart):
(JSC::Lexer<LChar>::currentCodePoint const):
(JSC::Lexer<UChar>::currentCodePoint const):
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
(JSC::Lexer<CharacterType>::parseIdentifierSlowCase):
(JSC::Lexer<T>::lexWithoutClearingLineTerminator):
(JSC::Lexer<T>::scanRegExp):
(JSC::isIdentPartIncludingEscapeTemplate): Deleted.
(JSC::isIdentPartIncludingEscape): Deleted.
- parser/Lexer.h:
(JSC::Lexer::setOffsetFromSourcePtr): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::printUnexpectedTokenText):
- parser/ParserTokens.h:
Source/WTF:
- wtf/text/WTFString.cpp:
(WTF::String::fromCodePoint):
- wtf/text/WTFString.h:
LayoutTests:
Fix broken test that asserted a non-ID_START codepoint was a start codepoint and
an ID_START codepoint was not a valid codepoint...
- js/script-tests/unicode-escape-sequences.js:
- js/unicode-escape-sequences-expected.txt:
- 5:03 PM Changeset in webkit [258530] by
-
- 2 edits in trunk/Source/WebKit
Crash under WebCookieCache::clearForHost()
https://bugs.webkit.org/show_bug.cgi?id=209149
<rdar://problem/60453086>
Reviewed by Darin Adler.
Alternative fix for Bug 209149 based on comments from Darin.
- WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::clearForHost):
(WebKit::WebCookieCache::pruneCacheIfNecessary):
- 4:56 PM Changeset in webkit [258529] by
-
- 2 edits in trunk/Source/WebKit
Fix the macCatalyst build after r258525
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
- 4:34 PM Changeset in webkit [258528] by
-
- 6 edits in trunk/Source/WebCore
Update touch event regions once per frame
https://bugs.webkit.org/show_bug.cgi?id=209153
Reviewed by Zalan Bujtas.
Call document->updateTouchEventRegions() once at the end of Page::updateRendering() instead
of relying on a timer.
Also rename the functions called from Internal to make it clear they are testing-only.
Page::scrollingStateTreeAsText() needs to eagerly update event regions because they are input
to the scrolling tree.
- dom/Document.cpp:
(WebCore::Document::Document):
- page/Page.cpp:
(WebCore::Page::scrollingStateTreeAsText):
(WebCore::Page::touchEventRectsForEventForTesting):
(WebCore::Page::passiveTouchEventListenerRectsForTesting):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::touchEventRectsForEvent): Deleted.
(WebCore::Page::passiveTouchEventListenerRects): Deleted.
- page/Page.h:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
- testing/Internals.cpp:
(WebCore::Internals::touchEventRectsForEvent):
(WebCore::Internals::passiveTouchEventListenerRects):
- 4:16 PM Changeset in webkit [258527] by
-
- 2 edits in trunk/Tools
Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
https://bugs.webkit.org/show_bug.cgi?id=209151
Reviewed by Yusuke Suzuki.
- Scripts/webkitpy/common/config/contributors.json:
- 4:12 PM Changeset in webkit [258526] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209154
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:02 PM Changeset in webkit [258525] by
-
- 45 edits1 delete in trunk/Source
Move most of TextIterator off of live ranges
https://bugs.webkit.org/show_bug.cgi?id=209129
Reviewed by Antti Koivisto.
Source/WebCore:
- Change almost all arguments and return values of functions in TextIterator.h to use SimpleRange instead of live ranges. Exceptions are an overload of plainText TextIterator::rangeLength, TextIterator::rangeFromLocationAndLength, TextIterator::getLocationAndLengthFromRange, and TextIterator::subrange. Those five are a little trickier to convert, so I will do them each in separate patches.
- Go with the flow in adding an include of Node.h to BoundaryPoint.h. I had avoided this in the initial version, but now it seems practical to just leave it that way. This led to removing BoundaryPoint.cpp and moving all functions to the header.
- Converted many member functions of the Position class from using int to unsigned for offsets. The DOM specifies unsigned for offsets, but for some reason we used int for them a lot historically, even though negative numbers don't make sense. New classes like StaticRange, SimpleRange, and BoundaryPoint are already using unsigned exclusively and we'll eventually convert everything.
- Remove includes of SimpleRange.h from files that also include TextIterator.h, now that TextIterator.h pulls it in.
- Sources.txt: Removed BoundaryPoint.cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange): Updated to pass a reference
to a range rather than a pointer, after null-checking it.
(WebCore::AXObjectCache::lengthForRange): Ditto.
(WebCore::AXObjectCache::nextBoundary): Ditto.
(WebCore::AXObjectCache::previousBoundary): Ditto.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::stringForRange const): Ditto.
(WebCore::AccessibilityObject::stringForVisiblePositionRange): Ditto.
(WebCore::AccessibilityObject::lengthForVisiblePositionRange const): Ditto.
- accessibility/AccessibilityObjectInterface.h: Removed an extra include.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Updated to pass a reference to a range rather than a pointer, after null-checking it.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]): Ditto.
- dom/BoundaryPoint.cpp: Removed.
- dom/BoundaryPoint.h: Removed redundant includes and forward declarations
since we're now committing to including "Node.h" here. Moved functions
all out of the .cpp file and made them inlines.
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::collectTextRanges): Pass a reference to
a range instead of a pointer.
- dom/Position.cpp:
(WebCore::Position::Position): Take unsigned.
(WebCore::Position::moveToPosition): Ditto.
(WebCore::Position::moveToOffset): Ditto.
(WebCore::Position::parentAnchoredEquivalent const): Cast to unsigned.
(WebCore::Position::anchorTypeForLegacyEditingPosition): Take unsigned.
(WebCore::Position::previous const): Use unsigned.
(WebCore::Position::next const): Ditto.
(WebCore::Position::uncheckedPreviousOffset): Take unsigned.
(WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion): Ditto.
(WebCore::Position::uncheckedNextOffset): Ditto.
(WebCore::Position::atLastEditingPositionForNode const): Cast to unsigned.
(WebCore::Position::atEndOfTree const): Ditto.
(WebCore::Position::rendersInDifferentPosition const): Added casts to
unsigned and also removed unneeded redundant checks. In a place where
we had already checked that both nodes were the same and both offsets
were different, we were checking the types of both nodes (but they are
the same so only need to check one) and we were checking that both
offsets were different (but we already knew they were different).
(WebCore::searchAheadForBetterMatch): Use unsigned.
(WebCore::Position::getInlineBoxAndOffset const): Ditto.
(WebCore::Position::equals const): Removed a cast to int.
(WebCore::makeBoundaryPoint): Moved this function here so now it can be
used in more places.
- dom/Position.h: Changed many argument types to unsigned. Moved declarations
of all the functions up above all the inline implementations of the functions
to separate interface from implementation a bit better. Wrote a FIXME about
the name createLegacyEditingPosition. Moved makeBoundaryPoint here and exported
it from WebCore so we can use it from more places.
- dom/Range.cpp:
(WebCore::createLiveRange): Moved these functions here from SimpleRange.cpp
because a live range is more advanced concept, so makes more sense for live
range to know about simple range rather than vice versa.
- dom/Range.h: Removed some unneeded includes and forward declarations.
Added a FIXME about renaming to LiveRange. Moved the createLiveRange
functions here. Moved declarations of functions above inline function bodies.
- dom/SimpleRange.cpp:
(WebCore::createLiveRange): Moved to Range.cpp.
- dom/SimpleRange.h: Exported the constructor. Removed unneeded overload
that takes a Range*.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Refactored code a bit and use unsigned.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Use unsigned.
- editing/Editing.cpp:
(WebCore::visibleImageElementsInRangeWithNonLoadedImages): Use a reference
to a range rather than a pointer.
- editing/Editing.h: Added a forward declaration of Range that now seems to
be needed to compile.
- editing/Editor.cpp:
(WebCore::Editor::selectedText const): Call makeBoundaryPoint twice here to
convert two Position objects into a SimpleRange.
- editing/HTMLInterchange.cpp: Removed some extra includes.
(WebCore::convertHTMLTextToInterchangeFormat): Use variadic
StringBuilder::append.
- editing/TextIterator.cpp:
(WebCore::firstNode): Added. We use this instead of Range::firstNode.
If we find we need it outside TextIterator we can find a header for it.
Not sure it would be great to add it to in BoundaryPoint.h, nor is it
obviously better as a BoundaryPoint member function.
(WebCore::TextIterator::TextIterator): Cut down on the extra constructors
and have the single remaining one take a SimpleRange.
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
Ditto. Also change some int to unsigned.
(WebCore::CharacterIterator::CharacterIterator): Ditto.
(WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Ditto.
(WebCore::WordAwareIterator::WordAwareIterator): Ditto.
(WebCore::TextIterator::rangeLength): Since this is one of the functions
that still takes a live range pointer, updated it to check for null and
pass a reference rather than a pointer.
(WebCore::TextIterator::rangeFromLocationAndLength): Ditto.
(WebCore::hasAnyPlainText): Removed now-unneeded call to createLiveRange.
(WebCore::plainText): Updated the main implementation to take a SimpleRange,
eliminating the version that takes two Position objects, but keeping the
one that takes a live range pointer for now.
(WebCore::plainTextReplacingNoBreakSpace): Removed all but the one, and
have that one take a SimpleRange.
- editing/TextIterator.h: Removed the include of SimpleRange.h. Also
Updated for the changes above, eliminating five different constructors
that take a live range and also overloads that take two Position objects.
- editing/TextManipulationController.cpp:
(WebCore::ParagraphContentIterator::ParagraphContentIterator):
Call makeBoundaryPoint twice here to convert two Position objects into
a SimpleRange.
- editing/VisibleSelection.cpp: Removed an include.
- editing/VisibleUnits.cpp:
(WebCore::suffixLengthForRange): Pass a reference to a range known to
not be null.
(WebCore::previousBoundary): Ditto.
(WebCore::nextBoundary): Ditto.
- editing/cocoa/DataDetection.mm:
(WebCore::buildQuery): Take a SimpleRange.
(WebCore::DataDetection::detectContentInRange): Added a null check on
a live range and pass a reference to it.
- editing/cocoa/DictionaryLookup.mm:
(WebCOre::DictionaryLookup::rangeAtHitTestResult): Ditto.
- editing/cocoa/HTMLConverter.mm:
(WebCore::editingAttributedStringFromRange): Pass a reference to a range
known to not be null.
- page/TextIndicator.cpp:
(WebCore::estimatedTextColorsForRange): Ditto.
(WebCore::containsOnlyWhiteSpaceText): Ditto.
- page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Ditto.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::selectedText const): Added a null check on
a live range and pass a reference to it.
Source/WebKit:
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
(-[WKDOMTextIterator initWithRange:]): Leave _textIterator as a nullptr
if the passed-in range is nil since we no longer offer a way to create
an empty TextIterator; other clients don't seem to need one.
(-[WKDOMTextIterator advance]): Add a null check.
(-[WKDOMTextIterator atEnd]): Ditto.
(-[WKDOMTextIterator currentRange]): Ditto.
(-[WKDOMTextIterator currentTextPointer]): Ditto.
(-[WKDOMTextIterator currentTextLength]): Ditto.
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm: Removed include.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales): Pass
a reference to a range known not to be null.
- WebProcess/WebPage/WebPage.cpp: Removed an include.
- WebProcess/WebPage/ios/WebPageIOS.mm: Removed a "using naemsapce WebCore".
Added two local functions
(WebKit::plainTextForContext): Added. Helper for just this file where calling
plainTextReplacingNoBreakSpace on a possibly null Range is common.
(WebKit::plainTextForDisplay): Ditto. This one passes true for isDisplayString.
Not entirely clear how carefully we chose which of the two to call, or if there
is sufficient test coverage.
(WebKit::WebPage::platformEditorState const): Use plainTextForContext
and plainTextForDisplay.
(WebKit::WebPage::getSelectionContext): Ditto.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Use plainTextForDisplay.
(WebKit::WebPage::requestDictationContext): Use plainTextForContext.
(WebKit::WebPage::replaceSelectedText): Ditto.
(WebKit::WebPage::replaceDictatedText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::dataDetectorLinkPositionInformation): Use plainTextForDisplay.
(WebKit::WebPage::requestDocumentEditingContext): Use RetainPtr instead of
autorelease. Use makeBoundaryPoint to convert Position objects to SimpleRange.
Source/WebKitLegacy/mac:
- WebView/WebFrame.mm: Removed an include.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
Add casts to unsigned.
- WebView/WebTextIterator.mm:
(-[WebTextIterator initWithRange:]): Leave _private->_textIterator
as a nullptr if the passed-in range is nil since we no longer offer
a way to create an empty TextIterator; other clients don't seem to
need one.
(-[WebTextIterator advance]): Check _private->_textIterator for null.
(-[WebTextIterator atEnd]): Ditto.
(-[WebTextIterator currentRange]): Ditto.
(-[WebTextIterator currentTextPointer]): Ditto.
(-[WebTextIterator currentTextLength]): Ditto.
(-[WebTextIterator currentNode]): Ditto.
(-[WebTextIterator currentText]): Ditto.
- 3:49 PM Changeset in webkit [258524] by
-
- 1 delete in branches/safari-610.1.7.3-branch
Delete branch.
- 3:41 PM Changeset in webkit [258523] by
-
- 1 copy in branches/safari-610.1.7.3-branch
New branch.
- 3:10 PM Changeset in webkit [258522] by
-
- 3 edits2 adds in trunk
Crash in CSSValue::isPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=208309
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-03-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Added a NULL check before dereferencing value in ApplyStyleCommand::computedFontSize
Test: editing/execCommand/primitive-value.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
LayoutTests:
Added a testcase attached to bugzilla issue 208309, with little modification.
- editing/execCommand/primitive-value-expected.txt: Added.
- editing/execCommand/primitive-value.html: Added.
- 3:04 PM Changeset in webkit [258521] by
-
- 4 edits in trunk
Crash under WebCookieCache::clearForHost()
https://bugs.webkit.org/show_bug.cgi?id=209149
<rdar://problem/60453086>
Reviewed by Alex Christensen.
Source/WebKit:
Make sure WebCookieCache::pruneCacheIfNecessary() keeps alive the host String it is passing
to WebCookieCache::clearForHost(). Previously, it was merely deferencing a HashSet iterator
and passing that to clearForHost(). However, clearForHost() would then drop the String from
the HashSet and the host would no longer be valid.
Change covered by new API test.
- WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::pruneCacheIfNecessary):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
(TEST):
- 2:50 PM Changeset in webkit [258520] by
-
- 8 edits3 deletes in trunk
Remove support for WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=208894
<rdar://problem/60297590>
Reviewed by Brent Fulgham.
This project provided support for facilities that are now handled
elsewhere and is no longer needed.
.:
- .gitignore:
- Source/PlatformWin.cmake:
- Source/cmake/OptionsAppleWin.cmake:
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
- Makefile:
- WebKitSystemInterface.h: Removed.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed.
- win/lib32/WebKitSystemInterface.lib: Removed.
- 2:41 PM Changeset in webkit [258519] by
-
- 3 edits in trunk/Source/WebKitLegacy/mac
Always include System.framework in WebKitLegacy's CPLUSPLUSFLAGS
https://bugs.webkit.org/show_bug.cgi?id=209147
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- Configurations/WebKitLegacy.xcconfig:
Bring WebKitLegacy's xcconfigs in line with all the other projects,
adding System.framework globally, and in Base.xcconfig.
- 2:11 PM Changeset in webkit [258518] by
-
- 8 edits in trunk
[macOS] Accessibility sandbox regressions
https://bugs.webkit.org/show_bug.cgi?id=209065
Source/WebCore/PAL:
Reviewed by Brent Fulgham.
Add Accessibility notification name.
- pal/spi/cocoa/NSAccessibilitySPI.h:
Source/WebKit:
<rdar://problem/60202450>
Reviewed by Brent Fulgham.
When Accessibility is enabled, the WebContent process needs access to the preference service, since Accessibility
is relying on some advanced features of the service. Also, when CF prefs direct mode is enabled, the WebContent
sandbox needs to explicitly allow reading of the various plist files.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
- WebProcess/com.apple.WebProcess.sb.in:
Tools:
Reviewed by Brent Fulgham.
- TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
(TEST):
- TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
(TEST):
- 1:54 PM Changeset in webkit [258517] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream tests are flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209148
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:21 PM Changeset in webkit [258516] by
-
- 3 edits2 adds in trunk
Color Picker crashes on touch
https://bugs.webkit.org/show_bug.cgi?id=209086
Reviewed by Darin Adler.
Source/WebCore:
Vector sizing lost in refactor. Not perfomance sensitive code, so just expanding vector as needed.
Test: fast/forms/color/color-input-activate-crash.html
- html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestedColors const):
LayoutTests:
- fast/forms/color/color-input-activate-crash-expected.txt: Added.
- fast/forms/color/color-input-activate-crash.html: Added.
- 1:11 PM Changeset in webkit [258515] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] Crash under -[WKPreferenceObserver init]
https://bugs.webkit.org/show_bug.cgi?id=209145
Reviewed by Darin Adler.
Handle the case when calling [NSUserDefaults initWithSuiteName:] did not succeed.
No new tests, since I have not been able to reproduce.
- UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKPreferenceObserver init]):
- 12:57 PM Changeset in webkit [258514] by
-
- 3 edits in trunk/LayoutTests
IndexedDB hits assertion with crypto/workers/subtle/aes-indexeddb.html
https://bugs.webkit.org/show_bug.cgi?id=202648
<rdar://problem/56059602>
Unreviewed test gardening.
- TestExpectations:
- platform/ios-simulator/TestExpectations:
- 12:56 PM Changeset in webkit [258513] by
-
- 5 edits in trunk/Source/WebKit
Remove unused IPC messages from DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=209090
<rdar://problem/60333300>
Reviewed by Wenson Hsieh.
Do not compile the following three unused messages in DrawingAreaProxy when
building for a Cocoa platform target.
DrawingAreaProxy::Update
DrawingAreaProxy::DidUpdateBackingStoreState
DrawingAreaProxy::ExitAcceleratedCompositingMode
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode):
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode): Deleted.
- 12:50 PM Changeset in webkit [258512] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] Only set CF prefs direct mode for the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=209091
<rdar://problem/60337842>
Reviewed by Brent Fulgham.
Currently, we enable CF prefs direct mode in XPCServiceMain. This is incorrect, it should only be enabled
for the WebContent process.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceMain):
- 11:49 AM Changeset in webkit [258511] by
-
- 8 edits in trunk/Source
Remove FrameView::scheduleRenderingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=209109
Reviewed by Antti Koivisto.
FrameView::scheduleRenderingUpdate() called through to compositor(), but that just
turned around to call scheduleRenderingUpdate() via Page. So Remove it and change
callers to call Page::scheduleRenderingUpdate() directly.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::setViewExposedRect):
(WebCore::FrameView::scheduleRenderingUpdate): Deleted.
- page/FrameView.h:
- page/Page.cpp:
(WebCore::Page::scheduleRenderingUpdate):
- page/Page.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleRenderingUpdate):
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
- 11:42 AM Changeset in webkit [258510] by
-
- 3 edits in trunk/Source/WebCore
Commit Xcode-modified xcfilelist.
New WebXR idl files.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- 11:42 AM Changeset in webkit [258509] by
-
- 3 edits in trunk/Source/WebCore
Factor some post-updateRendering code into its own function
https://bugs.webkit.org/show_bug.cgi?id=209108
Reviewed by Antti Koivisto.
Make a new function to hold code that needs to do post update-rendering work.
It asserts that the layout is clean at the end.
- page/Page.cpp:
(WebCore::Page::updateRendering):
(WebCore::Page::doAfterUpdateRendering):
- page/Page.h:
- 10:34 AM Changeset in webkit [258508] by
-
- 27 edits2 adds in trunk
ASSERTION FAILURE: !result.innerNode() (request.resultIsElementList() && result.listBasedTestResult().size()) in RenderLayer::hitTestContents() https://bugs.webkit.org/show_bug.cgi?id=209112
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update test result now that more sub-tests are passing.
- web-platform-tests/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint-expected.txt:
Source/WebCore:
Fix rect-based hit testing (e.g. used in the impl of document.elementsFromPoint()) of ::before
and ::after pseudo elements. Same issue as in r133330, updateHitTestResult() and addNodeToRectBasedTestResult()
are using different "hit" nodes. In particular, RenderObject::updateHitTestResult() knows how to
reason about ::before and ::after pseudo elements, but addNodeToRectBasedTestResult() cannot.
Standardize the concept of the node used for hit testing from something-specifically added to RenderBlock
in r133330 to all renderers. Have both updateHitTestResult() and addNodeToRectBasedTestResult()
make use of this concept so that they consider the same hit node.
Test: fast/dom/nodesFromRect/pseudo-empty-svg-image-crash.html
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hitTest):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
Update code to call nodeForHitTest() to keep the code behavior we have today. Note that RenderElement::element()
and RenderText::textNode() just cast the return value of RenderObject::node().
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest const): Remove special case for RenderView now that I added RenderView::nodeForHitTest().
Moreover, this special case was returning the document even though RenderView::updateHitTestResult() hit
test the document element. See remarks for RenderView::nodeForHitTest() for more details.
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint): Use nodeForHitTest(). This fixes the bug. Currently, updateHitTestResult()
knows that when RenderObject::node() is nullptr and the parent renderer is for generated content that it can
walk up the hierarchy to find the hit PseudoElement. But in the call to addNodeToListBasedTestResult(), RenderObject::element()
was passed, which is nullptr for an anonymous node, and addNodeToListBasedTestResult() doesn't have enough info
to know that this means generated content was hit and hence it is not able to find the PseudoElement. This
disagreement caused the assertion failure because updateHitTestResult() would update the inner node, but
addNodeToListBasedTestResult() would not add a node to the set.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline): Use nodeForHitTest().
(WebCore::RenderInline::updateHitTestResult): Update code as needed to use nodeForHitTest(). Also while I
am here fix up code style of comment and rename the local from element to node to match the return value
of nodeForHitTest().
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::nodeForHitTest const): Added.
(WebCore::RenderMultiColumnSet::updateHitTestResult): Update code as needed to use nodeForHitTest().
- rendering/RenderMultiColumnSet.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::nodeForHitTest const): Added.
(WebCore::RenderObject::updateHitTestResult): Update code as needed to use nodeForHitTest().
- rendering/RenderObject.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint): Ditto.
- rendering/RenderView.cpp:
(WebCore::RenderView::nodeForHitTest const): Added. This overrides RenderBlock::nodeForHitTest(), which
following r155370 was returning the document as the hit test node even though RenderView::updateHitTestResult()
considered the document element as the hit node for a RenderView. As a result of this change, the rect-based
hit testing no longer returns the document (seen in test results as #document) in the list of nodes.
(WebCore::RenderView::updateHitTestResult): Update code as needed to use nodeForHitTest().
- rendering/RenderView.h:
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow): Ditto.
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint): Ditto.
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtFloatPoint): Ditto.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint): Ditto.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtFloatPoint): Ditto.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint): Ditto.
LayoutTests:
Add a new test for an pseudo element.
Also update tests now that I added the RenderView::nodeForHitTest(), which returns the
same hit test node (the document element) as used in RenderView::updateHitTestResult().
Currently RenderView::nodeForHitTest() would actually fall back to RenderBlock::nodeForHitTest(),
which returned the document (seen in the test resutls as #document).
- fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Update test to match new results.
- fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html: Ditto.
- fast/dom/nodesFromRect/pseudo-empty-svg-image-crash-expected.txt: Added.
- fast/dom/nodesFromRect/pseudo-empty-svg-image-crash.html: Added.
- 10:24 AM Changeset in webkit [258507] by
-
- 3 edits in trunk/Source/WebKit
WebPage::GetDataSelectionForPasteboard should validate its
sizevariable
<https://webkit.org/b/209092>
<rdar://problem/60181345>
Reviewed by Brent Fulgham.
- Platform/IPC/Connection.h:
(MESSAGE_CHECK_WITH_RETURN_VALUE_BASE): Add.
- Variant of MESSAGE_CHECK_BASE() that takes a return value.
- UIProcess/mac/WebPageProxyMac.mm:
(MESSAGE_CHECK_WITH_RETURN_VALUE): Add.
(WebKit::WebPageProxy::dataSelectionForPasteboard):
- Use new MESSAGE_CHECK_WITH_RETURN_VALUE() macro to update
check for handle.isNull() and to add check for
sizevariable. - Add static_cast<size_t>() to
sizevariable to denote type change.
- 9:51 AM Changeset in webkit [258506] by
-
- 3 edits in trunk/Source/WebCore
Make CoreAudioCaptureSourceFactoryIOS an AudioSession::InterruptionObserver
https://bugs.webkit.org/show_bug.cgi?id=209138
Reviewed by Eric Carlson.
Instead of listening to Audiosession interruptions, CoreAudioCaptureSourceFactoryIOS is now relying on AudioSession directly.
This allows removing some duplicate code.
No change of behavior.
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.h:
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
(-[WebCoreAudioCaptureSourceIOSListener initWithCallback:]):
(WebCore::CoreAudioCaptureSourceFactoryIOS::CoreAudioCaptureSourceFactoryIOS):
(WebCore::CoreAudioCaptureSourceFactoryIOS::~CoreAudioCaptureSourceFactoryIOS):
(-[WebCoreAudioCaptureSourceIOSListener handleInterruption:]): Deleted.
- 9:44 AM Changeset in webkit [258505] by
-
- 2 edits in trunk/Tools
Unreviewed infrastructure fix.
- BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
while the hardware is out for repair.
- 9:41 AM Changeset in webkit [258504] by
-
- 14 edits2 adds in trunk
Apply rotation at source level if WebRTC sink ask so
https://bugs.webkit.org/show_bug.cgi?id=205645
Reviewed by Eric Carlson.
Source/WebCore:
Add a virtual method to RealtimeMediaSource to pass the information that the sink prefers the frames to be rotated before sending them.
Source/WebKit:
Implement RealtimeMediaSource setShouldApplyRotation by sending IPC to capture process.
In capture process, if rotation should be applied, use an ImageRotationSessionVT session to apply it before sending the video frame.
This allows WebProcess to no longer need an ImageRotationSessionVT for WebRTC.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::setShouldApplyRotation):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::rotatePixelBuffer):
(WebKit::UserMediaCaptureManagerProxy::setShouldApplyRotation):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::setShouldApplyRotation):
LayoutTests:
- webrtc/video-rotation-no-cvo-expected.txt: Added.
- webrtc/video-rotation-no-cvo.html: Added.
- 9:36 AM Changeset in webkit [258503] by
-
- 4 edits2 adds in trunk
Audio is not played from an audio element when the srcObject object has unstarted video tracks
https://bugs.webkit.org/show_bug.cgi?id=207041
<rdar://problem/59084745>
Reviewed by Eric Carlson.
Source/WebCore:
In case MediaPlayer is an audio element, we should just make it as if there is no video track in the stream.
Test: imported/w3c/web-platform-tests/webrtc/audio-video-element-playing.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::activeVideoTrack const):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didPassCORSAccessCheck const):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode const):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentReadyState):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
LayoutTests:
- webrtc/audio-video-element-playing-expected.txt: Added.
- webrtc/audio-video-element-playing.html: Added.
- 9:34 AM Changeset in webkit [258502] by
-
- 3 edits2 adds in trunk
RTCRtpSender of kind video should have a null dtmf attribute
https://bugs.webkit.org/show_bug.cgi?id=209135
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/webrtc/RTCRtpSender.https-expected.txt: Added.
- web-platform-tests/webrtc/RTCRtpSender.https.html: Added.
Source/WebCore:
Test: imported/w3c/web-platform-tests/webrtc/RTCRtpSender.https.html
- Modules/mediastream/RTCRtpSender.cpp:
(WebCore::RTCRtpSender::dtmf):
- 9:22 AM Changeset in webkit [258501] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] (r258249) fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html is a flaky failure (209052)
https://bugs.webkit.org/show_bug.cgi?id=209052
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:14 AM Changeset in webkit [258500] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=209139
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 9:09 AM Changeset in webkit [258499] by
-
- 4 edits113 adds in trunk/LayoutTests
[WebXR] Import wpt tests
https://bugs.webkit.org/show_bug.cgi?id=208989
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/webxr/META.yml: Added.
- web-platform-tests/webxr/ar-module/idlharness.https.window.html: Added.
- web-platform-tests/webxr/ar-module/idlharness.https.window.js: Added.
(async idl_array):
- web-platform-tests/webxr/ar-module/w3c-import.log: Added.
- web-platform-tests/webxr/ar-module/xrDevice_isSessionSupported_immersive-ar.https.html: Added.
- web-platform-tests/webxr/ar-module/xrDevice_requestSession_immersive-ar.https.html: Added.
- web-platform-tests/webxr/ar-module/xrSession_environmentBlendMode.https.html: Added.
- web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html: Added.
- web-platform-tests/webxr/dom-overlay/w3c-import.log: Added.
- web-platform-tests/webxr/events_input_source_recreation.https.html: Added.
- web-platform-tests/webxr/events_input_sources_change.https.html: Added.
- web-platform-tests/webxr/events_referenceSpace_reset_immersive.https.html: Added.
- web-platform-tests/webxr/events_referenceSpace_reset_inline.https.html: Added.
- web-platform-tests/webxr/events_session_select.https.html: Added.
- web-platform-tests/webxr/events_session_select_subframe.https.html: Added.
- web-platform-tests/webxr/events_session_squeeze.https.html: Added.
- web-platform-tests/webxr/exclusive_requestFrame_nolayer.https.html: Added.
- web-platform-tests/webxr/gamepads-module/idlharness.https.window.html: Added.
- web-platform-tests/webxr/gamepads-module/idlharness.https.window.js: Added.
(async idl_array):
- web-platform-tests/webxr/gamepads-module/w3c-import.log: Added.
- web-platform-tests/webxr/gamepads-module/xrInputSource_gamepad_disconnect.https.html: Added.
- web-platform-tests/webxr/gamepads-module/xrInputSource_gamepad_input_registered.https.html: Added.
- web-platform-tests/webxr/getInputPose_handedness.https.html: Added.
- web-platform-tests/webxr/getInputPose_pointer.https.html: Added.
- web-platform-tests/webxr/getViewerPose_emulatedPosition.https.html: Added.
- web-platform-tests/webxr/hit-test/ar_hittest_subscription_refSpaces.https.html: Added.
- web-platform-tests/webxr/hit-test/ar_hittest_subscription_states.https.html: Added.
- web-platform-tests/webxr/hit-test/w3c-import.log: Added.
- web-platform-tests/webxr/hit-test/xrRay_constructor.https.html: Added.
- web-platform-tests/webxr/hit-test/xrRay_matrix.https.html: Added.
- web-platform-tests/webxr/idlharness.https.window.html: Added.
- web-platform-tests/webxr/idlharness.https.window.js: Added.
(async idl_array):
- web-platform-tests/webxr/navigator_xr_sameObject.https.html: Added.
- web-platform-tests/webxr/render_state_vertical_fov_immersive.https.html: Added.
- web-platform-tests/webxr/render_state_vertical_fov_inline.https.html: Added.
- web-platform-tests/webxr/resources/w3c-import.log: Added.
- web-platform-tests/webxr/resources/webxr_check.html: Added.
- web-platform-tests/webxr/resources/webxr_math_utils.js: Added.
(let.transform_point_by_matrix):
(let.normalize_quaternion):
(let.conjugate_quaternion):
(let.multiply_quaternions):
(let.normalize_perspective):
(let.transform_point_by_quaternion):
- web-platform-tests/webxr/resources/webxr_test_asserts.js: Added.
(const.assert_point_approx_equals):
(const.assert_point_significantly_not_equals):
(const.assert_transform_approx_equals):
(const.assert_matrix_approx_equals):
(const.assert_matrix_significantly_not_equals):
(const.assert_ray_approx_equals):
- web-platform-tests/webxr/resources/webxr_test_constants.js: Added.
- web-platform-tests/webxr/resources/webxr_test_constants_fake_world.js: Added.
(createFakeWorld):
- web-platform-tests/webxr/resources/webxr_util.js: Added.
(xr_promise_test):
(async let):
(async xr_session_promise_test):
(async promise_simulate_user_activation):
- web-platform-tests/webxr/w3c-import.log: Added.
- web-platform-tests/webxr/webGLCanvasContext_create_xrcompatible.https.html: Added.
- web-platform-tests/webxr/webGLCanvasContext_makecompatible_contextlost.https.html: Added.
- web-platform-tests/webxr/webxr-supported-by-feature-policy.html: Added.
- web-platform-tests/webxr/webxr_availability.http.sub.html: Added.
- web-platform-tests/webxr/webxr_feature_policy.https.html: Added.
- web-platform-tests/webxr/webxr_feature_policy.https.html.headers: Added.
- web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https.html: Added.
- web-platform-tests/webxr/xrDevice_disconnect_ends.https.html: Added.
- web-platform-tests/webxr/xrDevice_isSessionSupported_immersive.https.html: Added.
- web-platform-tests/webxr/xrDevice_isSessionSupported_immersive_unsupported.https.html: Added.
- web-platform-tests/webxr/xrDevice_isSessionSupported_inline.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_immersive.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_immersive_no_gesture.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_immersive_unsupported.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_no_mode.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_optionalFeatures.https.html: Added.
- web-platform-tests/webxr/xrDevice_requestSession_requiredFeatures_unknown.https.html: Added.
- web-platform-tests/webxr/xrFrame_getPose.https.html: Added.
- web-platform-tests/webxr/xrFrame_getViewerPose_getPose.https.html: Added.
- web-platform-tests/webxr/xrFrame_lifetime.https.html: Added.
- web-platform-tests/webxr/xrFrame_session_sameObject.https.html: Added.
- web-platform-tests/webxr/xrInputSource_add_remove.https.html: Added.
- web-platform-tests/webxr/xrInputSource_emulatedPosition.https.html: Added.
- web-platform-tests/webxr/xrInputSource_profiles.https.html: Added.
- web-platform-tests/webxr/xrInputSource_sameObject.https.html: Added.
- web-platform-tests/webxr/xrPose_transform_sameObject.https.html: Added.
- web-platform-tests/webxr/xrReferenceSpace_originOffset.https.html: Added.
- web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https.html: Added.
- web-platform-tests/webxr/xrReferenceSpace_originOffset_viewer.https.html: Added.
- web-platform-tests/webxr/xrRigidTransform_constructor.https.html: Added.
- web-platform-tests/webxr/xrRigidTransform_inverse.https.html: Added.
- web-platform-tests/webxr/xrRigidTransform_matrix.https.html: Added.
- web-platform-tests/webxr/xrRigidTransform_sameObject.https.html: Added.
- web-platform-tests/webxr/xrSession_cancelAnimationFrame.https.html: Added.
- web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html: Added.
- web-platform-tests/webxr/xrSession_end.https.html: Added.
- web-platform-tests/webxr/xrSession_features_deviceSupport.https.html: Added.
- web-platform-tests/webxr/xrSession_input_events_end.https.html: Added.
- web-platform-tests/webxr/xrSession_prevent_multiple_exclusive.https.html: Added.
- web-platform-tests/webxr/xrSession_requestAnimationFrame_callback_calls.https.html: Added.
- web-platform-tests/webxr/xrSession_requestAnimationFrame_data_valid.https.html: Added.
- web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerPose.https.html: Added.
- web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https.html: Added.
- web-platform-tests/webxr/xrSession_requestReferenceSpace.https.html: Added.
- web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https.html: Added.
- web-platform-tests/webxr/xrSession_sameObject.https.html: Added.
- web-platform-tests/webxr/xrSession_viewer_availability.https.html: Added.
- web-platform-tests/webxr/xrSession_viewer_referenceSpace.https.html: Added.
- web-platform-tests/webxr/xrSession_visibilityState.https.html: Added.
- web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html: Added.
- web-platform-tests/webxr/xrView_eyes.https.html: Added.
- web-platform-tests/webxr/xrView_match.https.html: Added.
- web-platform-tests/webxr/xrView_oneframeupdate.https.html: Added.
- web-platform-tests/webxr/xrView_sameObject.https.html: Added.
- web-platform-tests/webxr/xrViewerPose_views_sameObject.https.html: Added.
- web-platform-tests/webxr/xrViewport_valid.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_constructor.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_framebuffer_sameObject.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https.html: Added.
- web-platform-tests/webxr/xrWebGLLayer_viewports.https.html: Added.
LayoutTests:
- TestExpectations: Mark all of them as skipped.
- 8:49 AM Changeset in webkit [258498] by
-
- 35 edits89 adds in trunk
[WebXR] IDLs, stubs and build configuration for WPE
https://bugs.webkit.org/show_bug.cgi?id=208702
Reviewed by Dean Jackson.
.:
Added a new compile flag for WEBXR which depends on WEBGL.
For the WPE port, added OpenXR detection and USE_OPENXR define to be
used in the sources. It also adds a dependency between USE_OPENXR and
ENABLE_WEBXR.
Largely based on previous work by Žan Doberšek.
- Source/cmake/FindOpenXR.cmake: Added.
- Source/cmake/OptionsWPE.cmake: Added mandatory OpenXR dependency if
WEBXR is enabled exposing USE_OPENXR to the build.
- Source/cmake/WebKitFeatures.cmake: Added ENABLE_WEBXR.
- Source/cmake/tools/vsprops/FeatureDefines.props: Ditto.
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Ditto.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
Source/WebCore:
Added the IDLs defined by the spec with very basic empty implementations to get them
built. Apart from that a very basic implementation of the required platform code using
OpenXR API was also added.
No new tests as no new functionality was really added (empty implementations). However
follow up patches will import the already available WPT tests for WebXR.
Largely based on previous work by Žan Doberšek.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR off by default.
- DerivedSources.make:
- Modules/webxr/NavigatorWebXR.cpp: Added.
(WebCore::NavigatorWebXR::xr):
(WebCore::NavigatorWebXR::from):
- Modules/webxr/NavigatorWebXR.h: Added.
- Modules/webxr/NavigatorWebXR.idl: Added.
- Modules/webxr/WebXRBoundedReferenceSpace.cpp: Added.
(WebCore::WebXRBoundedReferenceSpace::boundsGeometry const):
- Modules/webxr/WebXRBoundedReferenceSpace.h: Added.
- Modules/webxr/WebXRBoundedReferenceSpace.idl: Added.
- Modules/webxr/WebXRFrame.cpp: Added.
(WebCore::WebXRFrame::create):
(WebCore::WebXRFrame::WebXRFrame):
(WebCore::WebXRFrame::session const):
(WebCore::WebXRFrame::getViewerPose):
(WebCore::WebXRFrame::getPose):
- Modules/webxr/WebXRFrame.h: Added.
- Modules/webxr/WebXRFrame.idl: Added.
- Modules/webxr/WebXRInputSource.cpp: Added.
(WebCore::WebXRInputSource::create):
(WebCore::WebXRInputSource::WebXRInputSource):
(WebCore::WebXRInputSource::handedness const):
(WebCore::WebXRInputSource::targetRayMode const):
(WebCore::WebXRInputSource::targetRaySpace const):
(WebCore::WebXRInputSource::gripSpace const):
(WebCore::WebXRInputSource::profiles const):
- Modules/webxr/WebXRInputSource.h: Added.
- Modules/webxr/WebXRInputSource.idl: Added.
- Modules/webxr/WebXRInputSourceArray.cpp: Added.
(WebCore::WebXRInputSourceArray::length const):
(WebCore::WebXRInputSourceArray::item const):
- Modules/webxr/WebXRInputSourceArray.h: Added.
- Modules/webxr/WebXRInputSourceArray.idl: Added.
- Modules/webxr/WebXRPose.cpp: Added.
(WebCore::WebXRPose::create):
(WebCore::WebXRPose::WebXRPose):
(WebCore::WebXRPose::transform const):
(WebCore::WebXRPose::emulatedPosition const):
- Modules/webxr/WebXRPose.h: Added.
- Modules/webxr/WebXRPose.idl: Added.
- Modules/webxr/WebXRReferenceSpace.cpp: Added.
(WebCore::WebXRReferenceSpace::WebXRReferenceSpace):
(WebCore::WebXRReferenceSpace::getOffsetReferenceSpace):
- Modules/webxr/WebXRReferenceSpace.h: Added.
- Modules/webxr/WebXRReferenceSpace.idl: Added.
- Modules/webxr/WebXRRenderState.cpp: Added.
(WebCore::WebXRRenderState::create):
(WebCore::WebXRRenderState::WebXRRenderState):
(WebCore::WebXRRenderState::depthNear const):
(WebCore::WebXRRenderState::depthFar const):
(WebCore::WebXRRenderState::inlineVerticalFieldOfView const):
(WebCore::WebXRRenderState::baseLayer const):
- Modules/webxr/WebXRRenderState.h: Added.
- Modules/webxr/WebXRRenderState.idl: Added.
- Modules/webxr/WebXRRigidTransform.cpp: Added.
(WebCore::WebXRRigidTransform::create):
(WebCore::WebXRRigidTransform::WebXRRigidTransform):
(WebCore::WebXRRigidTransform::position const):
(WebCore::WebXRRigidTransform::orientation const):
(WebCore::WebXRRigidTransform::matrix const):
(WebCore::WebXRRigidTransform::inverse const):
- Modules/webxr/WebXRRigidTransform.h: Added.
- Modules/webxr/WebXRRigidTransform.idl: Added.
- Modules/webxr/WebXRSession.cpp: Added.
(WebCore::WebXRSession::environmentBlendMode const):
(WebCore::WebXRSession::visibilityState const):
(WebCore::WebXRSession::renderState const):
(WebCore::WebXRSession::inputSources const):
(WebCore::WebXRSession::updateRenderState):
(WebCore::WebXRSession::requestReferenceSpace):
(WebCore::WebXRSession::requestAnimationFrame):
(WebCore::WebXRSession::cancelAnimationFrame):
(WebCore::WebXRSession::end):
(WebCore::WebXRSession::activeDOMObjectName const):
(WebCore::WebXRSession::stop):
- Modules/webxr/WebXRSession.h: Added.
- Modules/webxr/WebXRSession.idl: Added.
- Modules/webxr/WebXRSpace.cpp: Added.
(WebCore::WebXRSpace::WebXRSpace):
- Modules/webxr/WebXRSpace.h: Added.
- Modules/webxr/WebXRSpace.idl: Added.
- Modules/webxr/WebXRSystem.cpp: Added.
(WebCore::WebXRSystem::create):
(WebCore::WebXRSystem::WebXRSystem):
(WebCore::WebXRSystem::isSessionSupported):
(WebCore::WebXRSystem::requestSession):
(WebCore::WebXRSystem::activeDOMObjectName const):
(WebCore::WebXRSystem::stop):
- Modules/webxr/WebXRSystem.h: Added.
- Modules/webxr/WebXRSystem.idl: Added.
- Modules/webxr/WebXRView.cpp: Added.
(WebCore::WebXRView::create):
(WebCore::WebXRView::WebXRView):
(WebCore::WebXRView::eye const):
(WebCore::WebXRView::projectionMatrix const):
(WebCore::WebXRView::transform const):
- Modules/webxr/WebXRView.h: Added.
- Modules/webxr/WebXRView.idl: Added.
- Modules/webxr/WebXRViewerPose.cpp: Added.
(WebCore::WebXRViewerPose::create):
(WebCore::WebXRViewerPose::views const):
- Modules/webxr/WebXRViewerPose.h: Added.
- Modules/webxr/WebXRViewerPose.idl: Added.
- Modules/webxr/WebXRViewport.cpp: Added.
(WebCore::WebXRViewport::create):
(WebCore::WebXRViewport::x const):
(WebCore::WebXRViewport::y const):
(WebCore::WebXRViewport::width const):
(WebCore::WebXRViewport::height const):
- Modules/webxr/WebXRViewport.h: Added.
- Modules/webxr/WebXRViewport.idl: Added.
- Modules/webxr/WebXRWebGLLayer.cpp: Added.
(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
(WebCore::WebXRWebGLLayer::antialias const):
(WebCore::WebXRWebGLLayer::ignoreDepthValues const):
(WebCore::WebXRWebGLLayer::framebuffer const):
(WebCore::WebXRWebGLLayer::framebufferWidth const):
(WebCore::WebXRWebGLLayer::framebufferHeight const):
(WebCore::WebXRWebGLLayer::getViewport):
(WebCore::WebXRWebGLLayer::getNativeFramebufferScaleFactor):
- Modules/webxr/WebXRWebGLLayer.h: Added.
- Modules/webxr/WebXRWebGLLayer.idl: Added.
- Modules/webxr/XREnvironmentBlendMode.h: Added.
- Modules/webxr/XREnvironmentBlendMode.idl: Added.
- Modules/webxr/XREye.h: Added.
- Modules/webxr/XREye.idl: Added.
- Modules/webxr/XRFrameRequestCallback.h: Added.
- Modules/webxr/XRFrameRequestCallback.idl: Added.
- Modules/webxr/XRHandedness.h: Added.
- Modules/webxr/XRHandedness.idl: Added.
- Modules/webxr/XRInputSourceEvent.cpp: Added.
(WebCore::XRInputSourceEvent::create):
(WebCore::XRInputSourceEvent::XRInputSourceEvent):
(WebCore::XRInputSourceEvent::frame const):
(WebCore::XRInputSourceEvent::inputSource const):
(WebCore::XRInputSourceEvent::buttonIndex const):
- Modules/webxr/XRInputSourceEvent.h: Added.
- Modules/webxr/XRInputSourceEvent.idl: Added.
- Modules/webxr/XRInputSourcesChangeEvent.cpp: Added.
(WebCore::XRInputSourcesChangeEvent::create):
(WebCore::XRInputSourcesChangeEvent::XRInputSourcesChangeEvent):
(WebCore::XRInputSourcesChangeEvent::session const):
(WebCore::XRInputSourcesChangeEvent::added const):
(WebCore::XRInputSourcesChangeEvent::removed const):
- Modules/webxr/XRInputSourcesChangeEvent.h: Added.
- Modules/webxr/XRInputSourcesChangeEvent.idl: Added.
- Modules/webxr/XRReferenceSpaceEvent.cpp: Added.
(WebCore::XRReferenceSpaceEvent::create):
(WebCore::XRReferenceSpaceEvent::XRReferenceSpaceEvent):
(WebCore::XRReferenceSpaceEvent::referenceSpace const):
(WebCore::XRReferenceSpaceEvent::transform const):
- Modules/webxr/XRReferenceSpaceEvent.h: Added.
- Modules/webxr/XRReferenceSpaceEvent.idl: Added.
- Modules/webxr/XRReferenceSpaceType.h: Added.
- Modules/webxr/XRReferenceSpaceType.idl: Added.
- Modules/webxr/XRRenderStateInit.h: Added.
- Modules/webxr/XRRenderStateInit.idl: Added.
- Modules/webxr/XRSessionEvent.cpp: Added.
(WebCore::XRSessionEvent::create):
(WebCore::XRSessionEvent::XRSessionEvent):
(WebCore::XRSessionEvent::session const):
- Modules/webxr/XRSessionEvent.h: Added.
- Modules/webxr/XRSessionEvent.idl: Added.
- Modules/webxr/XRSessionInit.h: Added.
- Modules/webxr/XRSessionInit.idl: Added.
- Modules/webxr/XRSessionMode.h: Added.
- Modules/webxr/XRSessionMode.idl: Added.
- Modules/webxr/XRTargetRayMode.h: Added.
- Modules/webxr/XRTargetRayMode.idl: Added.
- Modules/webxr/XRVisibilityState.h: Added.
- Modules/webxr/XRVisibilityState.idl: Added.
- Modules/webxr/XRWebGLLayerInit.h: Added.
- Modules/webxr/XRWebGLLayerInit.idl: Added.
- PlatformWPE.cmake: Added OpenXR libraries and include paths.
- Sources.txt: Added new cpp files.
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/IDLTypes.h: Added SequenceStorageType.
- bindings/js/JSDOMConvertSequences.h:
- bindings/js/WebCoreBuiltinNames.h:
- dom/EventNames.h:
- dom/EventNames.in: Added WebXR events.
- dom/EventTargetFactory.in: Added WebXR event targets.
- page/RuntimeEnabledFeatures.h: Added new runtime feature for WebXR.
(WebCore::RuntimeEnabledFeatures::setWebXREnabled):
(WebCore::RuntimeEnabledFeatures::webXREnabled const):
- platform/xr/PlatformXR.cpp: Added.
- platform/xr/PlatformXR.h: Added.
- platform/xr/openxr/PlatformXR.cpp: Added.
(PlatformXR::createStructure): Utility function to create OpenXR structs.
(PlatformXR::resultToString): Translates OpenXR error codes to strings.
(PlatformXR::Instance::Impl::Impl):
(PlatformXR::Instance::Impl::~Impl):
(PlatformXR::Instance::singleton):
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR off by default.
Source/WebKit:
Added WebXR to the list of experimental features.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR off by default.
- Shared/WebPreferences.yaml: Added WebXR feature.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultWebXREnabled): Set WebXR to off by default unless HAVE_SYSTEM_FEATURE_FLAGS.
- Shared/WebPreferencesDefaultValues.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
Tools:
- Scripts/webkitperl/FeatureList.pm: Added WebXR.
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
- 8:27 AM Changeset in webkit [258497] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Path copy constructor and operator must also copy over CTM
https://bugs.webkit.org/show_bug.cgi?id=183327
Patch by Zan Dobersek <zdobersek@igalia.com> on 2020-03-16
Reviewed by Carlos Garcia Campos.
Cairo implementations of Path copy constructor and assignment operator
must also copy over the current transformation matrix that's maintained
on the source path's cairo_t context.
cairo_copy_path() copies the current path off of a Cairo context, but
during that also transforms every point on the path through inverse of
the CTM, back into user coordinates. For copying to be done correctly,
the copied path must be transformed through the CTM when it's appended
to the target Cairo context. For that reason the CTM has to be copied
over from source to target context before the path is copied and
appended.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path):
(WebCore::Path::operator=):
- 8:26 AM Changeset in webkit [258496] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Add telemetry for message filtering
https://bugs.webkit.org/show_bug.cgi?id=208925
<rdar://problem/58885485>
Reviewed by Darin Adler.
On iOS, add telemetry for message filtering in the WebContent process' sandbox.
No new tests, no behavior change.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 8:19 AM Changeset in webkit [258495] by
-
- 4 edits in trunk
[Cocoa] Limit set of classes that can be decoded when a preference has changed
https://bugs.webkit.org/show_bug.cgi?id=208012
Reviewed by Brent Fulgham.
Source/WebKit:
As a hardening measure, limit the set of ObjectiveC classes that can be decoded in the WebContent process
as a result of a preference change.
API tests: WebKit.PreferenceChangesDictionary
WebKit.PreferenceChangesData
WebKit.PreferenceChangesDate
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::notifyPreferencesChanged):
Tools:
- TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
(TEST):
- 6:15 AM Changeset in webkit [258494] by
-
- 11 edits3 adds in trunk
Unique origins should not be Potentially Trustworthy
https://bugs.webkit.org/show_bug.cgi?id=209049
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/interfaces-window.https-expected.txt:
Source/WebCore:
Unique origins should not be considered trustworthy as per https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy.
Test: http/tests/security/iframe-unique-origin.https.html
- dom/Document.cpp:
(WebCore::Document::isSecureContext const):
Removed check for top level origins as we make all unique origins not trusted.
- page/SecurityOrigin.cpp:
Source/WebKit:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::hasNavigatedAwayFromAppBoundDomain):
We should only check this for the main frame since this is tied to the page.
Tools:
- TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
(TestWebKitAPI::TEST_F):
LayoutTests:
- editing/async-clipboard/resources/sanitize-when-reading-markup-iframe.html: Added.
- editing/async-clipboard/sanitize-when-reading-markup.html:
Updating test to use HTTP instead of data URL for iFrame since clipboard is SecureContext.
- http/tests/security/iframe-unique-origin.https-expected.txt: Added.
- http/tests/security/iframe-unique-origin.https.html: Added.
- 6:15 AM Changeset in webkit [258493] by
-
- 14 edits in trunk
Remove the use of empty WebRTC sources for receiver tracks
https://bugs.webkit.org/show_bug.cgi?id=209061
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/webrtc/RTCPeerConnection-track-stats.https-expected.txt:
Source/WebCore:
We no longer need to create receivers with empty sources since we now always have a libwebrtc receiver from which we can get the track.
We remove that code path.
This sldo allows using the right track parameters from the start, like track id.
Covered by existing and rebased tests.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::addPendingTrackEvent):
(WebCore::LibWebRTCMediaEndpoint::collectTransceivers):
(WebCore::LibWebRTCMediaEndpoint::newTransceiver):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::createReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::LibWebRTCPeerConnectionBackend::newRemoteTransceiver):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
(WebCore::LibWebRTCRtpReceiverBackend::createSource):
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.h:
- platform/mediastream/RealtimeIncomingAudioSource.cpp:
(WebCore::RealtimeIncomingAudioSource::RealtimeIncomingAudioSource):
- platform/mediastream/RealtimeIncomingAudioSource.h:
- platform/mediastream/RealtimeIncomingVideoSource.cpp:
(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
- platform/mediastream/RealtimeIncomingVideoSource.h:
- testing/MockLibWebRTCPeerConnection.h:
(WebCore::MockMediaStreamTrack::state const):
(WebCore::MockRtpReceiver::SetObserver):
- 5:41 AM Changeset in webkit [258492] by
-
- 13 edits in trunk
[Cairo][SVG] marker-mid isn't shown on a joint of rectilinearly connected line-to path segments
https://bugs.webkit.org/show_bug.cgi?id=113849
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Marker-mid of svg is not displayed because path elements that added to
cairo backend are optimized. If the new line_to has same slope with
the previous path element, then the path element is joined to previous
path element.
Example:
added path elements : moveto(-5,-2), lineto(0,-2), lineto(5,-2)
cairo_path_data : moveto(-5,-2), lineto(5, -2)
This patch stores all of path informations separately in order to avoid
this problem. When generating positions of markers, we use stored path
informations instead of cairo_path_data.
When a new operation can't be directly stored in an ElementPath, we fallback to use cairo_path_data() in
Path::apply().
- platform/graphics/Path.h: Add new constructor that receives a cairo context, make ensureCairoPath() private
and add m_elements member.
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::platformPathForGlyph const): Create a cairo context for the path and use the new constructor
that receives a RefPtr<cairo_t>&&.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path): Initialize m_elements to an empty vector when created without a cairo context.
(WebCore::Path::operator=): Also copy m_elements.
(WebCore::Path::clear): Initialize m_elements to an empty vector.
(WebCore::Path::translate): Apply the translate to elements in m_elements.
(WebCore::Path::appendElement): Helper to add an operation to m_elements.
(WebCore::Path::moveToSlowCase): Call appendElement() if m_elements is not nullopt.
(WebCore::Path::addLineToSlowCase): Ditto.
(WebCore::Path::addRect): Ditto.
(WebCore::Path::addQuadCurveToSlowCase): Ditto.
(WebCore::Path::addBezierCurveToSlowCase): Ditto.
(WebCore::Path::addArcSlowCase): Set m_elements to nullopt.
(WebCore::Path::addArcTo): Ditto.
(WebCore::Path::addEllipse): Ditto.
(WebCore::Path::addPath): Ditto.
(WebCore::Path::closeSubpath): Call appendElement() if m_elements is not nullopt.
(WebCore::Path::applySlowCase const): Use elements from m_elements if it's not nullopt, otherwise fallback to
use cairo_path_data.
(WebCore::Path::transform): Apply the transform to elements in m_elements.
LayoutTests:
Remove svg/custom/local-url-reference-marker.html from expectations and rebaseline other tests.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/svg/import/text-path-01-b-manual-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/svg/import/text-path-02-b-manual-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-008-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/textpath-shape-001-expected.txt:
- platform/gtk/svg/text/text-path-01-b-expected.png:
- platform/gtk/svg/text/text-path-01-b-expected.txt:
- platform/wpe/TestExpectations:
- 5:17 AM Changeset in webkit [258491] by
-
- 624 edits2 copies2 adds in trunk/LayoutTests
[Gtk] Update pixel test baseline in svg/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=209137
Ruber-stamped by Žan Doberšek.
Update pixel test baseline, reflecting the status quo with WebKit ToT.
- platform/gtk/svg: > 600 modifications of the -expected.png files.
- platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.png: Added.
- platform/gtk/svg/filters/filter-refresh-expected.png: Copied from LayoutTests/platform/gtk/svg/filters/feImage-reference-invalidation-expected.png.
- platform/gtk/svg/hixie/error/015-expected.png: Copied from LayoutTests/platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
- 4:08 AM Changeset in webkit [258490] by
-
- 1 edit27 adds in trunk/LayoutTests
[Gtk] Add missing pixel test results in svg/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=209136
Reviewed by Žan Doberšek.
Add pixel tests results based on current WebKit ToT.
No Gtk bot is running pixel tests, but it is still helpful to have an
updated pixel test baseline for local development. Many SVG tests
still depend on the pixel test output as only way to catch
regressions. This should be changed in future, but for now we should
at least have an accurate baseline.
- platform/gtk/svg/animations/animate-marker-orienttype-1-expected.png: Added.
- platform/gtk/svg/animations/animate-marker-orienttype-2-expected.png: Added.
- platform/gtk/svg/animations/animate-marker-orienttype-3-expected.png: Added.
- platform/gtk/svg/animations/animate-viewport-overflow-2-expected.png: Added.
- platform/gtk/svg/animations/animate-viewport-overflow-expected.png: Added.
- platform/gtk/svg/animations/avoid-calculating-for-non-animating-elements-expected.png: Added.
- platform/gtk/svg/css/shape-rendering-parsing-expected.png: Added.
- platform/gtk/svg/custom/non-scaling-stroke-markers-expected.png: Added.
- platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
- platform/gtk/svg/custom/use-on-symbol-inside-pattern-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGClipPath-prefixed-influences-hitTesting-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGClipPath-prefixed-path-influences-hitTesting-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGClipPathElement-prefixed-css-transform-influences-hitTesting-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGClipPathElement-prefixed-transform-influences-hitTesting-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-edgeMode-attr-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/gtk/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
- platform/gtk/svg/filters/feBlend-all-blendmodes-expected.png: Added.
- platform/gtk/svg/filters/filter-image-ref-root-expected.png: Added.
- platform/gtk/svg/hixie/text/001-expected.png: Added.
- platform/gtk/svg/in-html/overflow-repaint-expected.png: Added.
- platform/gtk/svg/overflow/overflow-scroll-on-outermost-svg-element-expected.png: Added.
- platform/gtk/svg/text/scaled-font-expected.png: Added.
- platform/gtk/svg/text/text-hkern-expected.png: Added.
- platform/gtk/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.png: Added.
- platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
- 2:29 AM Changeset in webkit [258489] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=209105
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 1:11 AM Changeset in webkit [258488] by
-
- 2 edits in trunk/Source/WebCore
Remove addHTTPOriginIfNeeded calls
https://bugs.webkit.org/show_bug.cgi?id=209127
Patch by Rob Buis <rbuis@igalia.com> on 2020-03-16
Reviewed by Darin Adler.
Remove addHTTPOriginIfNeeded calls since they are get requests and navigations and the spec [1]
indicates that the Origin header should not be written out, making these calls no-ops.
[1] https://fetch.spec.whatwg.org/#append-a-request-origin-header
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadURL):
- 12:20 AM Changeset in webkit [258487] by
-
- 16 edits in trunk/Source
Simplify ChromeClient.createWindow
https://bugs.webkit.org/show_bug.cgi?id=209123
Patch by Rob Buis <rbuis@igalia.com> on 2020-03-16
Reviewed by Darin Adler.
Source/WebCore:
Simplify ChromeClient.createWindow by removing the FrameLoadRequest parameter.
It was only passed for its ResourceRequest member, which can also be obtained
from the NavigationAction parameter.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::createWindow):
- page/Chrome.cpp:
(WebCore::Chrome::createWindow const):
- page/Chrome.h:
- page/ChromeClient.h:
- page/ContextMenuController.cpp:
(WebCore::openNewWindow):
Source/WebKit:
Adapt to API change.
- WebProcess/Inspector/WebInspector.cpp:
(WebKit::WebInspector::openInNewTab):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchCreatePage):
Mar 15, 2020:
- 7:58 PM Changeset in webkit [258486] by
-
- 4 edits in trunk
KeyedDecoderGeneric fails to allocate Vector while decoding broken data
https://bugs.webkit.org/show_bug.cgi?id=207324
Reviewed by Darin Adler.
Source/WebCore:
There were three crash bugs in it.
KeyedDecoderGeneric was trying to allocate a buffer without
ensuring the size wouldn't exceed the decoding data size by using
bufferIsLargeEnoughToContain.
It was trying to push an itme into the top dictionary of emtpy
m_dictionaryStack when EndObject tag would appear without the
preceding BeginObject tag.
It was trying to push an item into the top array of empty
m_arrayStack when EndArray tag would appear without the preceding
BeginArray tag.
Tests: TestWebKitAPI: KeyedCoding.DecodeRandomData
- platform/generic/KeyedDecoderGeneric.cpp:
(WebCore::readString):
(WebCore::KeyedDecoderGeneric::KeyedDecoderGeneric):
Check bufferIsLargeEnoughToContain(size) before allocating a Vector with size.
Check if m_dictionaryStack and m_arrayStack are empty.
Tools:
- TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
(TestWebKitAPI::generateRandomData): Added.
(TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
- 7:33 PM Changeset in webkit [258485] by
-
- 4 edits in trunk/LayoutTests
WPE gardening.
Updated a test baseline with new message after changed from
js-test-pre to js-test.
Unreviewed test gardening.
- platform/gtk/TestExpectations: Updated an expectation with new bug
number.
- platform/wpe/TestExpectations:
- platform/wpe/fast/frames/sandboxed-iframe-navigation-allowed-expected.txt:
- 7:08 PM Changeset in webkit [258484] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
[ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
https://bugs.webkit.org/show_bug.cgi?id=209014
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-15
Reviewed by Darin Adler.
Silence compiler warning.
- changes.diff:
- src/common/utilities.cpp:
- 6:41 PM Changeset in webkit [258483] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy]
https://bugs.webkit.org/show_bug.cgi?id=209015
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-15
Reviewed by Darin Adler.
Suppress compiler warning. If this were WebKit code, I might take the time to fix it, but
with third-party code it's probably best to just turn off warnings that upstream is not
using.
- CMakeLists.txt:
- 6:17 PM Changeset in webkit [258482] by
-
- 6 edits in trunk/Source/WebCore
[DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions::enableBackForwardCache
https://bugs.webkit.org/show_bug.cgi?id=207481
<rdar://problem/59331661>
Reviewed by Darin Adler.
Add a support for a new excludeFromInternalSetting option in Settings.yaml and use it for
'usesBackForwardCache' setting. This means that script will no longer be able to toggle
this particular setting via internals.settings JS API. Tests wanting to turn on the
back / forward cache are supposed to use the following:
<!-- webkit-test-runner [ enableBackForwardCache=true ] -->
Using internals.settings JS API to turn on the back/forward cache would not work well
with WebKit2 because of process-swap-on-navigation. Support for it in WK1 / DRT was
causing flakiness because of a conflict between the 2 ways of enabling the setting.
- Scripts/GenerateSettings.rb:
- Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
- Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
- Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb:
- page/Settings.yaml:
- 2:28 PM Changeset in webkit [258481] by
-
- 2 edits in trunk/LayoutTests
Regression r258439: quicklook/multi-sheet-numbers-09.html is failing consistently on iOS
https://bugs.webkit.org/show_bug.cgi?id=209128
Partially revert r258439.
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 8:33 AM Changeset in webkit [258480] by
-
- 6 edits2 adds in trunk
[LFC][TFC] Add basic column span support for content box width
https://bugs.webkit.org/show_bug.cgi?id=209120
<rdar://problem/60463424>
Reviewed by Antti Koivisto.
Source/WebCore:
Take the column spanning into account when computing the content width for the table cell.
[content box width = column width(1) + column width(2) + .. + column width(spanning value) + ((spanning value - 1) * horizontal spacing)]
Test: fast/layoutformattingcontext/table-colspan-simple.html
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
(WebCore::Layout::TableFormattingContext::positionTableCells):
- layout/tableformatting/TableFormattingContext.h:
- layout/tableformatting/TableGrid.cpp:
(WebCore::Layout::TableGrid::appendCell):
- layout/tableformatting/TableGrid.h:
(WebCore::Layout::TableGrid::CellInfo::startColumn const):
(WebCore::Layout::TableGrid::CellInfo::endColumn const):
(WebCore::Layout::TableGrid::CellInfo::startRow const):
(WebCore::Layout::TableGrid::CellInfo::endRow const):
(WebCore::Layout::TableGrid::CellInfo::columnSpan const):
(WebCore::Layout::TableGrid::CellInfo::rowSpan const):
LayoutTests:
- fast/layoutformattingcontext/table-colspan-simple-expected.html: Added.
- fast/layoutformattingcontext/table-colspan-simple.html: Added.
- 3:51 AM Changeset in webkit [258479] by
-
- 4 edits in trunk/Source/JavaScriptCore
reportZappedCellAndCrash should handle PreciseAllocation in IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=209042
Reviewed by Mark Lam.
This patch adds support of PreciseAllocation cells to reportZappedCellAndCrash, since now it is frequently used
as a lower-tier cells in IsoSubspace.
- heap/IsoSubspace.h:
- heap/IsoSubspaceInlines.h:
(JSC::IsoSubspace::forEachLowerTierFreeListedPreciseAllocation):
- runtime/JSCell.cpp:
(JSC::reportZappedCellAndCrash):
- 3:16 AM Changeset in webkit [258478] by
-
- 37 edits2 adds in trunk
Should not use variable-length-array (VLA)
https://bugs.webkit.org/show_bug.cgi?id=209043
Reviewed by Mark Lam.
PerformanceTests:
- MediaTime/Configurations/Base.xcconfig:
Source/bmalloc:
- Configurations/Base.xcconfig:
Source/JavaScriptCore:
This patch disables variable-length-array (VLA). If this feature uses user-input, user can
control the stack height consumed by C++ code. This patch avoids using VLA. To achieve that,
- We set
-Wvlawarning option to trigger warnings if it is used. - Introduce MarkedJSValueRefArray for API. This replaces
JSValueRef arguments[variableLength]use case. MarkedJSValueRefArray registers itself to JSC GC so that GC can mark it as a strong root.
- API/JSContext.mm:
(+[JSContext currentArguments]):
- API/JSValue.mm:
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
- API/MarkedJSValueRefArray.cpp: Added.
(JSC::MarkedJSValueRefArray::MarkedJSValueRefArray):
(JSC::MarkedJSValueRefArray::~MarkedJSValueRefArray):
(JSC::MarkedJSValueRefArray::visitAggregate):
- API/MarkedJSValueRefArray.h: Added.
- API/tests/minidom.c:
(print):
- API/tests/testapi.cpp:
(TestAPI::markedJSValueArrayAndGC):
(testCAPIViaCpp):
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- heap/Heap.cpp:
(JSC::Heap::addCoreConstraints):
(JSC::Heap::addMarkedJSValueRefArray):
- heap/Heap.h:
- heap/MarkedSpace.h:
(JSC::MarkedSpace::activeWeakSetsBegin): Deleted.
(JSC::MarkedSpace::activeWeakSetsEnd): Deleted.
(JSC::MarkedSpace::newActiveWeakSetsBegin): Deleted.
(JSC::MarkedSpace::newActiveWeakSetsEnd): Deleted.
- runtime/ArgList.h:
Source/WebCore:
- Configurations/Base.xcconfig:
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
- platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):
- platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
(WebCore::updateDisplayID):
(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDevices):
Source/WebCore/PAL:
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit:
- Configurations/Base.xcconfig:
- UIProcess/_WKTouchEventGenerator.mm:
(-[_WKTouchEventGenerator touchDown:touchCount:]):
(-[_WKTouchEventGenerator liftUp:touchCount:]):
(-[_WKTouchEventGenerator moveToPoints:touchCount:duration:]):
Source/WebKitLegacy/mac:
- Configurations/Base.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- wtf/UUID.cpp:
(WTF::bootSessionUUIDString):
Tools:
- ContentExtensionTester/Configurations/Base.xcconfig:
- lldb/lldbWebKitTester/Configurations/Base.xcconfig:
Mar 14, 2020:
- 8:40 PM Changeset in webkit [258477] by
-
- 3 edits in trunk/Source/WebKit
Fix the "deliver cached ranges" logic in PDFPlugin (and other small cleanups)
https://bugs.webkit.org/show_bug.cgi?id=209097
Reviewed by Tim Hatcher.
Streaming in data always appended to the buffer instead of first growing the buffer.
This wasn't noticed earlier because we often did not grow the buffer for successful range request completion.
But now we often do!
So this cleans that all up.
At the same time it revealed other interactions with PDFKit that force us to handle data requests on the main
thread after the document load is complete - Which is fine!
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::dataProviderGetBytesAtPositionCallback): If on the main thread (and the document load is complete)
handle the request directly!
(WebKit::PDFPlugin::getResourceBytesAtPositionMainThread):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData):
(WebKit::PDFPlugin::ensureDataBufferLength):
(WebKit::PDFPlugin::didFail):
(WebKit::PDFPlugin::maybeClearHighLatencyDataProviderFlag):
(WebKit::PDFPlugin::documentDataDidFinishLoading):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::manualStreamDidReceiveData): Grow the buffer instead of append.
- 5:14 PM Changeset in webkit [258476] by
-
- 8 edits in trunk/Source
Add missing checks needed for AppBound Quirk
https://bugs.webkit.org/show_bug.cgi?id=209117
<rdar://problem/60460097>
Reviewed by John Wilander.
The checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.
Source/WebCore:
Two additional call sites need to check the state of the flag.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.
- loader/FrameLoaderClient.h: Add new API for the 'NeedsInAppBrowserPrivacyQuirks'
debug flag.
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately): Ditto.
Source/WebKit:
These changes let the WebFrameLoaderClient report the quirk state to WebCore code.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.
- 3:59 PM Changeset in webkit [258475] by
-
- 20 edits in trunk/Source
Change all return values in TextIterator header from live ranges to SimpleRange
https://bugs.webkit.org/show_bug.cgi?id=208906
Reviewed by Antti Koivisto.
Source/WebCore:
This is another step in moving off of live ranges for WebKit internals.
- Change return values of remaining functions that were returning live ranges in the TextIterator header to return SimpleRange.
- Change some arguments from live ranges to SimpleRange.
- At some call sites, use createLiveRange to convert the SimpleRange into a live range (for now), but at others update the code to use SimpleRange.
- Renamed a version of findPlainText that returns a boolean to containsPlainText.
- Convert call sites that were using createLiveRange just to use the Range::startPosition and Range::endPosition functions to instead use a new overload of the createLegacyEditingPosition function that can be used with SimpleRange::start and SimpleRange::end because it takes a BoundaryPoint.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rangeMatchesTextNearRange): Return Optional<SimpleRange>
and take SimpleRange argument.
(WebCore::AXObjectCache::previousBoundary): Updated since
SimplifiedBackwardsTextIterator::range now returns SimpleRange.
- accessibility/AXObjectCache.h: Updated for the above.
- accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::containsText const): Updated for name change.
Now containsPlainText instead of findPlainText.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use createLegacyEditingPosition instead of createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Use createLiveRange.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use createLegacyEditingPosition instead of createLiveRange.
- dom/Position.cpp:
(WebCore::createLegacyEditingPosition): Added an overload that takes a BoundaryPoint.
- dom/Position.h: Updated for the above, also removed unneeded includes and forward
declarations.
- editing/Editing.cpp:
(WebCore::visiblePositionForIndexUsingCharacterIterator): Updated since
CharacterIterator::range is now a SimpleRange, use createLegacyEditingPosition.
- editing/Editor.cpp:
(WebCore::Editor::advanceToNextMisspelling): Updated since CharacterIterator::range
is now a SimpleRange.
(WebCore::Editor::rangeOfString): Updated since findPlainText now returns a
SimpleRange; use createLiveRange.
(WebCore::Editor::countMatchesForText): Ditto.
- editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::range const): Return a SimpleRange.
(WebCore::CharacterIterator::range const): Ditto.
(WebCore::characterSubrange): Updated since CharacterIterator::range returns
a SimpleRange. Use createLiveRange.
(WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Cut down
code here by initializing data members in the class definition.
(WebCore::BackwardsCharacterIterator::range const): Return a SimpleRange.
(WebCore::WordAwareIterator::WordAwareIterator): Cut down code here by
initializing data members in the class definition.
(WebCore::hasAnyPlainText): Take a SimpleRange, use createLiveRange.
(WebCore::plainTextUsingBackwardsTextIteratorForTesting): Take a SimpleRange,
use createLiveRange.
(WebCore::collapsedToBoundary): Take and return a SimpleRange.
(WebCore::findPlainTextMatches): Take a SimpleRange, use createLiveRange.
(WebCore::rangeForMatch): Take and return a SimpleRange.
(WebCore::findClosestPlainText): Ditto.
(WebCore::findPlainText): Ditto.
(WebCore::containsPlainText): Renamed from findPlainText since this returns
a boolean, not a found location of some text.
- editing/TextIterator.h: Updated for the above. Also changed some data
members to use unsigned for offsets rather than int.
- editing/TextManipulationController.cpp:
(WebCore::ParagraphContentIterator::startPosition): Use
createLegacyEditingPosition instead of createLiveRange.
(WebCore::ParagraphContentIterator::endPosition): Ditto.
- editing/VisiblePosition.h: Added a forward declaration here since Position.h
no longer forward declares it.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::appendTrailingWhitespace): Updated since
CharacterIterator::range is now a SimpleRange, use createLegacyEditingPosition.
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary): Ditto.
(WebCore::nextBoundary): Ditto.
- testing/Internals.cpp:
(WebCore::Internals::rangeOfStringNearLocation): Updated since
findClosestPlainText now returns a SimpleRange, use createLiveRange.
Source/WebKit:
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm: Removed unneeded include of
TextIterator.h.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeNearPositionMatchesText): Removed unused originalRange argument,
changed return type to Optional<SimpleRange> since findClosestPlainText now
returns a SimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Updated since
rangeNearPositionMatchesText now returns Optional<SimpleRange>, use createLiveRange.
(WebKit::WebPage::requestDocumentEditingContext): Updated since
CharacterIterator::range returns SimpleRange, use createLiveRange.
- 3:17 PM Changeset in webkit [258474] by
-
- 3 edits in trunk/Source/WebKit
Gather PDF scripts to run on a background thread.
https://bugs.webkit.org/show_bug.cgi?id=209063
Reviewed by Geoff Garen.
In incremental loading mode, gathering document scripts will sometimes require PDFKit/CG
to lock and wait on data loads from our data provider.
So if we gather them on the main thread, we will hang the main thread and therefore deadlock
with our data provider thread/queue.
So let's gather those scripts on a background thread!
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData):
(WebKit::PDFPlugin::documentDataDidFinishLoading):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::streamDidFinishLoading):
(WebKit::PDFPlugin::manualStreamDidFinishLoading):
(WebKit::PDFPlugin::tryRunScriptsInPDFDocument): Only actually gathers scripts to execute if there
is a m_pdfDocument and the entire document data finished loading.
(WebKit::PDFPlugin::pdfDocumentDidLoad): Deleted.
(WebKit::PDFPlugin::runScriptsInPDFDocument): Deleted.
- 3:04 PM Changeset in webkit [258473] by
-
- 3 edits2 adds in trunk
[LFC][TFC] Fill in the gaps with anonymous table cell boxes
https://bugs.webkit.org/show_bug.cgi?id=209114
<rdar://problem/60458806>
Reviewed by Antti Koivisto.
Source/WebCore:
17.5 Visual layout of table contents
A "missing cell" is a cell in the row/column grid that is not
occupied by an element or pseudo-element. Missing cells are rendered
as if an anonymous table-cell box occupied their position in the grid.
(https://www.w3.org/TR/CSS22/tables.html)
This helps to keep TableGrid an actual grid.
Test: fast/layoutformattingcontext/table-missing-cells-simple.html
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::buildTableStructure):
LayoutTests:
- fast/layoutformattingcontext/table-missing-cells-simple-expected.html: Added.
- fast/layoutformattingcontext/table-missing-cells-simple.html: Added.
- 12:53 PM Changeset in webkit [258472] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.26
Merge r257720 - ASSERT(m_column != unsetColumnIndex) in RenderTable::cellBefore
https://bugs.webkit.org/show_bug.cgi?id=208397
Patch by Doug Kelly <Doug Kelly> on 2020-03-02
Reviewed by Zalan Bujtas.
Source/WebCore:
When inserting a cell into a table row which is not visible, this can lead to attempting to compute the repaint
rects during tree building. Instead, mark the layer as dirty using dirtyVisibleContentStatus(), and the visibility
will be recomputed at a later time.
Test: fast/table/insert-cell-invisible-parent.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertedIntoTree):
LayoutTests:
- fast/table/insert-cell-invisible-parent-expected.txt: Added.
- fast/table/insert-cell-invisible-parent.html: Added.
- 12:53 PM Changeset in webkit [258471] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.26
Merge r257897 - Crash in SVGElement::removeEventListener with symbol element
https://bugs.webkit.org/show_bug.cgi?id=207920
Patch by Doug Kelly <Doug Kelly> on 2020-03-04
Reviewed by Ryosuke Niwa.
Source/WebCore:
Resolves a crash in SVGElement::removeEventListener by only attaching the events to the window if the SVG element is both the outermost
SVG element, in addition to ensuring the SVG element is attached to the tree. The symbol element's behavior when referenced by a use
tag actually creates an svg tag instead, so the SVGSVGElement's special behavior for copying attributes is vital.
Note that Chrome and Firefox have a similar behavior for detached SVG elements as to what this change creates: in both other browsers,
onerror is not fired for a detached svg element, and in Firefox, onresize is not fired for a detached svg element (it is however fired
in Chrome).
Tests: fast/events/detached-svg-parent-window-events.html
fast/events/onerror-svg-symbol.html
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
LayoutTests:
- fast/events/detached-svg-parent-window-events-expected.txt: Added.
- fast/events/detached-svg-parent-window-events.html: Added.
- fast/events/onerror-svg-symbol-expected.txt: Added.
- fast/events/onerror-svg-symbol.html: Added.
- 12:52 PM Changeset in webkit [258470] by
-
- 2 edits in releases/WebKitGTK/webkit-2.26/Source/bmalloc
Merge r258142 - Build failure on ppc64le if unix is undefined
https://bugs.webkit.org/show_bug.cgi?id=207906
Patch by Mike Gorse <mgorse@suse.com> on 2020-03-09
Reviewed by Yusuke Suzuki.
- bmalloc/BPlatform.h: Check for unix along with unix.
- 12:19 PM Changeset in webkit [258469] by
-
- 10 edits2 deletes in trunk
Cleanup RenderMediaControls.cpp and RenderMediaControlElements.cpp
https://bugs.webkit.org/show_bug.cgi?id=209008
Reviewed by Daniel Bates.
Source/WebCore:
Merge RenderMediaControls.[h|cpp] and RenderMediaControlElements.[h|cpp].
Remove class RenderMediaVolumeSliderContainer because we can use RenderBlockFlow
to render MediaControlTextTrackContainerElement.
No new tests, no functional change.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/shadow/MediaControlElementTypes.cpp:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):
- rendering/RenderMediaControlElements.cpp: Removed.
- rendering/RenderMediaControlElements.h: Removed.
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer):
(WebCore::RenderMediaControlTimelineContainer::layout):
- rendering/RenderMediaControls.h:
- rendering/RenderThemeMac.mm:
LayoutTests:
Remove unused code in a test.
- media/track/track-cue-rendering-rtl.html:
- 12:01 PM Changeset in webkit [258468] by
-
- 3 edits in trunk/Source/WebCore
Share HitTestResult::addNodeToListBasedTestResult() impl for LayoutRect and FloatRect overloads
https://bugs.webkit.org/show_bug.cgi?id=209107
Reviewed by Brady Eidson.
Remove code duplication for adding a node to the result set.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToListBasedTestResultCommon): Added.
(WebCore::HitTestResult::addNodeToListBasedTestResult): Write in terms of addNodeToListBasedTestResultCommon().
- rendering/HitTestResult.h:
- 9:10 AM Changeset in webkit [258467] by
-
- 2 edits in trunk
[CMake] Warning when ccache is not installed
https://bugs.webkit.org/show_bug.cgi?id=208952
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-14
Reviewed by Daniel Bates.
Change the warning when ccache is not installed to a status message. We shouldn't be
printing warnings except when there is an actual problem.
- Source/cmake/WebKitCCache.cmake:
- 5:57 AM Changeset in webkit [258466] by
-
- 3 edits2 adds in trunk
[Tree building] Reset the fragmented flow status before calling child.willBeRemovedFromTree.
https://bugs.webkit.org/show_bug.cgi?id=209100
<rdar://problem/60434672>
Reviewed by Simon Fraser.
Source/WebCore:
::willBeRemovedFromTree() assumes all the cleanup has happened and it's the final step before calling d'tor.
It clears m_fragmentList that resetFragmentedFlowStateOnRemoval() later checks for consistency (m_fragmentList.contains(fragment)).
Test: fast/multicol/reparent-fragment-flow-content.html
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::detachFromRenderElement):
LayoutTests:
- fast/multicol/reparent-fragment-flow-content-expected.txt: Added.
- fast/multicol/reparent-fragment-flow-content.html: Added.
- 3:22 AM Changeset in webkit [258465] by
-
- 10 edits in trunk
Set Origin header value to null rather than omitting it
https://bugs.webkit.org/show_bug.cgi?id=186030
Patch by Rob Buis <rbuis@igalia.com> on 2020-03-14
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Update improved test result.
- web-platform-tests/fetch/origin/assorted.window-expected.txt:
Source/WebCore:
For every redirect, addHTTPOriginIfNeeded should be called to
make sure that the tainted origin logic is applied [1, Step 10] and
thus the request after redirect has the correct Origin header.
Make AppleWin treat 308 redirects like 307 and so keeping http
methods across redirects. This is similar to
https://bugs.webkit.org/show_bug.cgi?id=154348.
[1] https://fetch.spec.whatwg.org/#concept-http-network-or-cache-fetch
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
- platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):
LayoutTests:
Update improved test result.
- http/tests/security/cors-post-redirect-307-expected.txt:
- http/tests/security/cors-post-redirect-307-pson-expected.txt:
- http/tests/security/cors-post-redirect-308-expected.txt:
- 12:15 AM Changeset in webkit [258464] by
-
- 3 edits in trunk/Source/WebCore
Call SVGTRefElement::buildPendingResource in SVGElement::didFinishInsertingNode
https://bugs.webkit.org/show_bug.cgi?id=208981
Reviewed by Antti Koivisto.
This patch moves the call to SVGTRefElement::buildPendingResource from SVGElement::insertedIntoAncestor
to SVGElement::didFinishInsertingNode.
- svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoAncestor): Return true when the element has a pending resource ID.
(WebCore::SVGElement::didFinishInsertingNode): Added. Calls buildPendingResourcesIfNeeded.
- svg/SVGElement.h:
- 12:03 AM Changeset in webkit [258463] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix windows build by making configSizeToProtect stay 4KB.
- runtime/JSCConfig.h:
Mar 13, 2020:
- 11:43 PM Changeset in webkit [258462] by
-
- 3 edits in trunk/LayoutTests
PROGRESSION: webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205736
Unreviewed test expectation update.
- TestExpectations:
- webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt:
- 11:16 PM Changeset in webkit [258461] by
-
- 4 edits in trunk/LayoutTests
PROGRESSION (r253926): webgl/1.0.3/conformance/renderbuffers/feedback-loop.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205738
Unreviewed test expectation updates.
- TestExpectations:
- platform/ios/TestExpectations:
- webgl/1.0.3/conformance/renderbuffers/feedback-loop-expected.txt:
- 9:11 PM Changeset in webkit [258460] by
-
- 5 edits in trunk/Source
configSizeToProtect should be 16KB
https://bugs.webkit.org/show_bug.cgi?id=209068
Reviewed by Keith Miller.
Source/bmalloc:
- bmalloc/Gigacage.h:
Source/JavaScriptCore:
- runtime/JSCConfig.h:
- 8:11 PM Changeset in webkit [258459] by
-
- 4 edits2 adds in trunk
SVGMatrix should have the access right of its owner SVGTransform always
https://bugs.webkit.org/show_bug.cgi?id=207462
Reviewed by Simon Fraser.
Source/WebCore:
The SVGMatrix needs to be reattached to its owner SVGTransform when the
access right of this owner changes. The access right of the owner changes
when it gets attached to or detached from a higher level owner.
Test: svg/dom/SVGTransformList-anim-read-only.html
- svg/SVGTransform.h:
- svg/properties/SVGProperty.h:
(WebCore::SVGProperty::attach):
(WebCore::SVGProperty::detach):
(WebCore::SVGProperty::reattach):
LayoutTests:
- svg/dom/SVGTransformList-anim-read-only-expected.txt: Added.
- svg/dom/SVGTransformList-anim-read-only.html: Added.
- 7:10 PM Changeset in webkit [258458] by
-
- 17 edits in trunk
WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=209011
<rdar://problem/59370588>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-13
Reviewed by Youenn Fablet.
Source/WebCore:
This is basically r258343 but for legacy TLS negotiation instead of plaintext HTTP use.
- dom/SecurityContext.h:
(WebCore::SecurityContext::usedLegacyTLS const):
(WebCore::SecurityContext::setUsedLegacyTLS):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::usedLegacyTLS const):
(WebCore::CachedFrame::setUsedLegacyTLS): Deleted.
- history/CachedFrame.h:
(WebCore::CachedFrame::usedLegacyTLS const): Deleted.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::includeCertificateInfo const):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::setUsedLegacyTLS):
Source/WebKit:
- NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::didReceiveResponse):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::notifyDidReceiveResponse):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::usedLegacyTLS): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 7:01 PM Changeset in webkit [258457] by
-
- 6 edits in trunk
[watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
https://bugs.webkit.org/show_bug.cgi?id=209089
Reviewed by Tim Horton.
Source/WebKit:
Handle text suggestions that lack
displayTextgracefully in Quickboard by not showing them as AutoFill
candidates. Currently, they are presented as blank collection view cells in Quickboard, which leads to a
confusing user experience.
Test: WKWebViewAutoFillTests.DoNotShowBlankTextSuggestions
- UIProcess/ios/forms/WKFocusedFormControlView.mm:
(-[WKFocusedFormControlView setSuggestions:]):
Tools:
Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
marketing name for the feature.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(runUntilReceivesAutoplayEvent):
Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
and 32-bit integers. This is because this function took aWKAutoplayEvent(a 32-bit integer), but compared
against the_WKAutoplayEventtype (an NSInteger that is 64 bits on this architecture). There didn't seem to
be any compelling reason to compare against different types here (especially since we only set
receivedAutoplayEventunder the Objective-C delegate method that provides a_WKAutoplayEvent), so I changed
these all to be_WKAutoplayEvent.
- TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(-[AutoFillTestView _autofillInputView]):
(-[AutoFillTestView textInputHasAutoFillContext]):
(TestWebKitAPI::TEST):
(-[AutofillTestView initWithFrame:]): Deleted.
(-[AutofillTestView _autofillInputView]): Deleted.
(-[AutofillTestView textInputHasAutofillContext]): Deleted.
- TestWebKitAPI/ios/UIKitSPI.h:
- 6:43 PM Changeset in webkit [258456] by
-
- 3 edits in trunk/Source/WebKit
Clean up sandbox violations found during testing
https://bugs.webkit.org/show_bug.cgi?id=209096
<rdar://problem/59931477>
Reviewed by Geoffrey Garen.
Remove telemetry from some items, and allow access to some IOKit properties
needed for media playback on macOS and iOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 6:43 PM Changeset in webkit [258455] by
-
- 3 edits2 adds in trunk
[Tree building] Block::attachIgnoringContinuation should allow inline tables as before child container
https://bugs.webkit.org/show_bug.cgi?id=209095
<rdar://problem/59837588>
Reviewed by Simon Fraser.
Source/WebCore:
It's perfectly valid to have an inline table as the anonymous container for the before child.
It'll get wrapped inside an anonymous block right before we insert the block box candidate, so
the final result will be something like:
new block level child (this is the child we are inserting)
anonymous block wrapper
inline table (this is the before child's inline container)
before child
Test: fast/table/before-child-is-inline-table.html
- rendering/updating/RenderTreeBuilderBlock.cpp:
(WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation):
LayoutTests:
- fast/table/before-child-is-inline-table-expected.txt: Added.
- fast/table/before-child-is-inline-table.html: Added.
- 6:27 PM Changeset in webkit [258454] by
-
- 2 edits in trunk/Source/WebCore
[GPU Process] GraphicsContextStateChange::apply() should process ShadowsIgnoreTransformsChange before processing ShadowChange
https://bugs.webkit.org/show_bug.cgi?id=209071
Reviewed by Darin Adler.
Ensure GraphicsContextStateChange::apply() calls shadowsIgnoreTransforms()
before calling setLegacyShadow() or setShadow().
Test: This patch fixes the following tests when running:
"run-webkit-tests --internal-feature RenderCanvasInGPUProcessEnabled"
fast/canvas/canvas-image-shadow.html
fast/canvas/canvas-scale-drawImage-shadow.html
fast/canvas/canvas-scale-fillPath-shadow.html
fast/canvas/canvas-scale-fillRect-shadow.html
fast/canvas/canvas-scale-shadowBlur.html
fast/canvas/canvas-transforms-fillRect-shadow.html
fast/canvas/fillText-shadow.html
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContextStateChange::apply const):
- 6:01 PM Changeset in webkit [258453] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix JSC / test262 tests
https://bugs.webkit.org/show_bug.cgi?id=209033
<rdar://problem/58946936>
Follow-up change for DisallowGC causes crash because CodeBlock is nullptr when function call is non JS calls.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- 5:19 PM Changeset in webkit [258452] by
-
- 2 edits in trunk/Source/JavaScriptCore
Missing arithMode for ArithAbs and ArithNegate in DFGClobberize
https://bugs.webkit.org/show_bug.cgi?id=208685
<rdar://problem/60115088>
Reviewed by Saam Barati.
In the pure case of ArithNegate and ArithAbs in DFGClobberize, their PureValues did not include their
respective ArithMode. That means that e.g. a CheckOverflow ArithNegate/Abs could be considered equivalent
to an Unchecked version of the same node.
Thanks to Samuel Groß of Google Project Zero for identifying this bug.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 5:05 PM Changeset in webkit [258451] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, reverting r258446.
These expectations are no longer needed.
Reverted changeset:
"[ Mac ] http/tests/security/mixedContent/insecure-worker-
global-scope.html is flaky failing."
https://bugs.webkit.org/show_bug.cgi?id=209093
https://trac.webkit.org/changeset/258446
- 4:59 PM Changeset in webkit [258450] by
-
- 2 edits5 deletes in trunk/LayoutTests
Unreviewed, reverting r258431.
These tests are flaky failing.
Reverted changeset:
"Add mixed content block test for imported scripts in worker
global scope"
https://bugs.webkit.org/show_bug.cgi?id=209075
https://trac.webkit.org/changeset/258431
- 4:57 PM Changeset in webkit [258449] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, drop unused variable in WebPageProxy::backForwardGoToItem().
- UIProcess/WebPageProxy.cpp:
- 4:35 PM Changeset in webkit [258448] by
-
- 10 edits in trunk/Source
Remove unused code related to removePrevalentDomains()
https://bugs.webkit.org/show_bug.cgi?id=209078
<rdar://problem/59681984>
Reviewed by Brent Fulgham.
The various removePrevalentDomains() functions and its IPC endpoint are unused and should be removed.
Source/WebCore:
No new tests. Just dead code removal.
- platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::removePrevalentDomains): Deleted.
- platform/network/NetworkStorageSession.h:
Source/WebKit:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::clearBlockingStateForDomains): Deleted.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::removePrevalentDomains): Deleted.
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler): Deleted.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::removePrevalentDomains): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- 4:33 PM Changeset in webkit [258447] by
-
- 16 edits2 adds in trunk/Source
[Cocoa] Push applicationSDKVersion() down from WebCore into WTF
https://bugs.webkit.org/show_bug.cgi?id=209030
Reviewed by Simon Fraser.
Source/JavaScriptCore:
dyld_get_program_sdk_version() gives you the wrong answer in the Web Process (or at least
not the answer you actually want). There are already facilities for the UI Process to tell
the Web Process what the real value is, but those functions are currently in WebCore,
which is inaccessible to WTF. This patch is in preparation for
https://bugs.webkit.org/show_bug.cgi?id=208969 which needs to know this information in WTF.
I also found a few places which were calling dyld_get_program_sdk_version() in JavaScriptCore
and WebCore (which is wrong because those libraries exist in the Web Process), and have fixed
them up to use applicationSDKVersion() instead.
- API/JSWrapperMap.mm:
(supportsInitMethodConstructors):
Source/WebCore:
- html/HTMLObjectElement.cpp:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
- platform/RuntimeApplicationChecks.h:
- platform/Timer.cpp:
(WebCore::shouldSuppressThreadSafetyCheck):
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::applicationSDKVersionOverride): Deleted.
(WebCore::setApplicationSDKVersion): Deleted.
(WebCore::applicationSDKVersion): Deleted.
Source/WebKit:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCSSOMViewScrollingAPIEnabled):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/PlatformMac.cmake:
- wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: Added.
- wtf/cocoa/RuntimeApplicationChecksCocoa.h: Added.
(WTF::applicationSDKVersionOverride):
(WTF::setApplicationSDKVersion):
(WTF::applicationSDKVersion):
- 4:33 PM Changeset in webkit [258446] by
-
- 2 edits in trunk/LayoutTests
[ Mac ] http/tests/security/mixedContent/insecure-worker-global-scope.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209093
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:29 PM Changeset in webkit [258445] by
-
- 4 edits in trunk/Source/WebKit
Remove unused IPC function UserMediaCaptureManagerProxy::SetMuted
https://bugs.webkit.org/show_bug.cgi?id=209087
<rdar://problem/59658963>
Reviewed by Eric Carlson.
Remove the unused UserMediaCaptureManagerProxy message 'SetMuted'.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::setMuted): Deleted.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- 4:21 PM Changeset in webkit [258444] by
-
- 3 edits in trunk/Source/WebKit
Remove unused GetNetworkLoadInformationRequest call
https://bugs.webkit.org/show_bug.cgi?id=209081
<rdar://problem/59659064>
Reviewed by Geoffrey Garen.
Remove dead code associated with an unused IPC message.
- NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadInformationRequest): Deleted.
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- 4:20 PM Changeset in webkit [258443] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Reload CodeBlock or suppress GC while setting up calls
https://bugs.webkit.org/show_bug.cgi?id=209033
<rdar://problem/58946936>
Reviewed by Saam Barati.
The sequence of Interpreter::execute is the following.
- Getting CodeBlock from Executable
- Doing a lot of setups
- Setting (1)'s CodeBlock to ProtoFrame
- Calling code through Executable
During (2), it would be possible that GC happens and it replaces CodeBlock in Executable.
Then, when executing JITCode with CodeBlock in (4), we use new JITCode with old CodeBlock.
In this patch,
For ProgramExecutable, FunctionExecutable, ModuleProgramExecutable, we ensure that no GC happens
after getting CodeBlock by placing DisallowGC. For EvalExecutable, we reload CodeBlock after setting
up environment. It is possible that FunctionExecutable* stored in CodeBlock can be different when
executing a new CodeBlock, but this is OK since this different does not appear and we do not rely on
this: we are touchingnameof FunctionExecutable* which is retrieved from CodeBlock. But this name
will not be changed since this is derived from UnlinkedFunctionExecutable which is shared by multiple
CodeBlocks. And FunctionExecutable* generation ordering must be the same for every CodeBlock generation
from the same UnlinkedCodeBlock.
- bytecode/CodeBlock.h:
(JSC::ScriptExecutable::prepareForExecution):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
- interpreter/InterpreterInlines.h:
(JSC::Interpreter::execute):
- runtime/DisallowScope.h:
(JSC::DisallowScope::disable):
- runtime/StringPrototype.cpp:
- 4:15 PM Changeset in webkit [258442] by
-
- 11 edits in trunk/Source
[WebAuthn] Customize a bit more on the macOS LocalAuthentication prompt
https://bugs.webkit.org/show_bug.cgi?id=208703
<rdar://problem/60136974>
Reviewed by Darin Adler.
Source/WebCore:
- en.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::touchIDPromptTitle):
- platform/LocalizedStrings.h:
Adds a new formatted UI string to help with RP ID.
Source/WebKit:
On macOS, LocalAuthentication prompt can be shown anywhere that is probably not on top of
our UI clients. Therefore, add a RP ID to the dialog to help users to identify what has
happened. In addition, it removes the password fallback button.
- Platform/spi/Cocoa/LocalAuthenticationSPI.h:
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterDecidePolicy):
(WebKit::LocalAuthenticator::continueGetAssertionAfterResponseSelected):
- UIProcess/WebAuthentication/Cocoa/LocalConnection.h:
- UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:
(WebKit::LocalConnection::verifyUser const):
- UIProcess/WebAuthentication/Mock/MockLocalConnection.h:
- UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:
(WebKit::MockLocalConnection::verifyUser const):
- 4:04 PM Changeset in webkit [258441] by
-
- 4 edits in trunk/Source/WebKit
Remove Unused IPC message PlaybackSessionManagerProxy::PictureInPictureActiveChanged
https://bugs.webkit.org/show_bug.cgi?id=209085
<rdar://problem/59658916>
Reviewed by Geoffrey Garen.
Remove the unused PlaybackSessionManagerProxy message 'PictureInPictureActiveChanged'.
- UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
- UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
- UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionManagerProxy::pictureInPictureActiveChanged): Deleted.
- 3:35 PM Changeset in webkit [258440] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: (r256232) [ Mac wk1 Release ] resize-observer/delete-observers-in-callbacks.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207847
<rdar://problem/59516099>
Unreviewed, unskip test now that is should no longer be flaky after r258438.
- platform/mac-wk1/TestExpectations:
- 3:33 PM Changeset in webkit [258439] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (257844): fast/scrolling/scroll-container-horizontally.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=209083
Also changed expectations for a test that is now timing out.
Unreviewwd test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-wk2/TestExpectations:
- 3:32 PM Changeset in webkit [258438] by
-
- 2 edits in trunk/Tools
Unreviewed, reverting r256232.
Caused ResizeObserver tests to become flaky
Reverted changeset:
"[DRT] InternalSettingsGenerated::resetToConsistentState() may
override TestOptions"
https://bugs.webkit.org/show_bug.cgi?id=207481
https://trac.webkit.org/changeset/256232
- 3:18 PM Changeset in webkit [258437] by
-
- 2 edits in trunk/LayoutTests
[ Mac Release ] css3/selectors3/xml/css3-modsel-d4.xml is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209084
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:56 PM Changeset in webkit [258436] by
-
- 11 edits in trunk
[ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
https://bugs.webkit.org/show_bug.cgi?id=209016
<rdar://problem/60329530>
Reviewed by Chris Dumez.
Source/WebKit:
This patch adds a function to re-initialize app bound domains for
in-app-browser-privacy tests, since they are only initialized once
when the WebsiteDataStore is created. This causes issues if the tests
are run in parallel with other tests with different app-bound domains.
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreReinitializeAppBoundDomains):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::clearAppBoundDomains):
(WebKit::WebsiteDataStore::reinitializeAppBoundDomains):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Re-initialize the app-bound domains when the correct
TestOptions parameter is set.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::reinitializeAppBoundDomains):
- WebKitTestRunner/TestController.h:
LayoutTests:
Use TestOptions to trigger the re-initialization of app-bound domains.
- http/tests/in-app-browser-privacy/app-bound-domain.html:
- http/tests/in-app-browser-privacy/switch-session-on-navigation-to-app-bound-domain.html:
- 2:51 PM Changeset in webkit [258435] by
-
- 2 edits in trunk/LayoutTests
[ Mac ] fast/animation/request-animation-frame-timestamps.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209079
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:49 PM Changeset in webkit [258434] by
-
- 14 edits in trunk/Source/WebCore
Safari sometimes crashes when switch video into PiP mode
https://bugs.webkit.org/show_bug.cgi?id=208904
Reviewed by Simon Fraser.
With this patch, MediaControlTextTrackContainerElement won't paint its subtree
to an image buffer (for the captions in video fullscreen or picture-in-picture mode)
when the cues are updated. Instead, it only sets the flag m_needsGenerateTextTrackRepresentation
to true after running layout based on the new cues. After that, it paints its subtree
to an image buffer if needed at the end of Page::updateRendering() when the layout is clean.
TextTrackRepresentationCocoa will use the image buffer to set the content of the layer
for captions in video fullscreen or picture-in-picture mode.
MediaControlTextTrackContainerElement class is responsible for rendering the captions in both:
1) a video player in the inline mode.
2) a video player in "video fullscreen" or picture-in-picture mode.
This patch refactors some functions to make their responsibilities clear.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::updateTextTrackRepresentationImageIfNeeded):
- Modules/mediacontrols/MediaControlsHost.h:
- dom/Document.cpp:
(WebCore::Document::setMediaElementShowingTextTrack):
(WebCore::Document::clearMediaElementShowingTextTrack):
(WebCore::Document::updateTextTrackRepresentationImageIfNeeded):
- dom/Document.h:
Functions textTracksAreReady(), textTrackReadyStateChanged() and configureTextTrackDisplay()
should be wrapped with "#if ENABLE(VIDEO_TRACK)".
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setTextTrackRepresentation):
(WebCore::HTMLMediaElement::textTracksAreReady const):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::updateTextTrackRepresentationImageIfNeeded):
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createElementRenderer):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationImageIfNeeded):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationIfNeeded):
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackStyle):
(WebCore::MediaControlTextTrackContainerElement::enteredFullscreen):
(WebCore::MediaControlTextTrackContainerElement::updateVideoDisplaySize):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
(WebCore::MediaControlTextTrackContainerElement::textTrackRepresentationBoundsChanged):
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentation): Deleted.
(WebCore::MediaControlTextTrackContainerElement::updateTextTrackRepresentationStyle): Deleted.
(WebCore::MediaControlTextTrackContainerElement::layoutIfNecessary): Deleted.
(WebCore::MediaControlTextTrackContainerElement::updateCueStyles): Deleted.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateTextTrackRepresentationImageIfNeeded):
- html/shadow/MediaControls.h:
- page/Page.cpp:
(WebCore::Page::updateRendering):
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaControlTextTrackContainer::RenderMediaControlTextTrackContainer):
(WebCore::RenderMediaControlTextTrackContainer::layout):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement): Deleted.
(WebCore::RenderTextTrackContainerElement::layout): Deleted.
- rendering/RenderMediaControlElements.h:
- 2:47 PM Changeset in webkit [258433] by
-
- 1 copy in tags/Safari-609.2.1.2.1
Tag Safari-609.2.1.2.1.
- 2:39 PM Changeset in webkit [258432] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ Mac wk2 ] svg/custom/object-sizing-explicit-width.xhtml is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=209077
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:32 PM Changeset in webkit [258431] by
-
- 2 edits5 adds in trunk/LayoutTests
Add mixed content block test for imported scripts in worker global scope
https://bugs.webkit.org/show_bug.cgi?id=209075
<rdar://problem/27483005>
Reviewed by Brent Fulgham.
- http/tests/security/mixedContent/insecure-worker-global-scope-expected.txt: Added.
- http/tests/security/mixedContent/insecure-worker-global-scope.html: Added.
- http/tests/security/mixedContent/resources/worker-importing-insecure-script.js: Added.
- http/tests/security/mixedContent/resources/worker-importing-secure-script.js: Added.
- http/tests/security/mixedContent/resources/worker-sending-message.js: Added.
- platform/mac-wk1/TestExpectations:
Test for some reason fails on Mojave Debug WK1 but not on Mojave Release WK1 or other bots.
Therefore skipped.
- 2:25 PM Changeset in webkit [258430] by
-
- 1 copy in tags/Safari-610.1.7.3
Tag Safari-610.1.7.3.
- 1:56 PM Changeset in webkit [258429] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r257840): [ iOS ] fast/backgrounds/hidpi-bitmap-background-on-subpixel-position.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=208601
Fixing test expectations.
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 1:38 PM Changeset in webkit [258428] by
-
- 1 copy in tags/Safari-609.2.1
Tag Safari-609.2.1.
- 1:37 PM Changeset in webkit [258427] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Delete IC creation should check mayNeedToCheckCell/canCacheDeleteIC regardless of Structure::outOfLineCapacity
https://bugs.webkit.org/show_bug.cgi?id=209027
Reviewed by Saam Barati.
Delete IC code generation assumes that mayNeedToCheckCell (it is replaced with canCacheDeleteIC) is false
while we are looking into this status only if Structure::outOfLineCapacity meets a certain condition. We should avoid
create Delete IC when mayNeedToCheckCell/canCacheDeleteIC is true regardless of Structure::outOfLineCapacity
- bytecode/AccessCase.cpp:
(JSC::AccessCase::createDelete):
(JSC::AccessCase::generateImpl):
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::mayHaveIndexingHeader const):
(JSC::Structure::canCacheDeleteIC const):
- 1:31 PM Changeset in webkit [258426] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r257640. rdar://problem/60260332
updateCSSTransitionsForElementAndProperty should clone RenderStyles
https://bugs.webkit.org/show_bug.cgi?id=208356
rdar://59869560
Reviewed by Antti Koivisto.
Make ownership of the local variable clear by cloning the RenderStyles
used in updateCSSTransitionsForElementAndProperty rather than referencing
different versions.
- animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:31 PM Changeset in webkit [258425] by
-
- 2 edits in branches/safari-609.2.1.2-branch/Source/WebCore
Cherry-pick r257746. rdar://problem/60260331
ScriptController::executeIfJavaScriptURL() uses wrong JSGlobalObject.
https://bugs.webkit.org/show_bug.cgi?id=208290
<rdar://problem/59839476>
Reviewed by Chris Dumez.
The call to executeScriptIgnoringException() may have changed the current global
object of the window. We should be using the original global object that produced
the result string.
Also added a missing exception check needed after a potential rope resolution.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:22 PM Changeset in webkit [258424] by
-
- 14 edits2 deletes in trunk
Unreviewed, reverting r258391.
Breaks internal builds.
Reverted changeset:
"Apply rotation at source level if WebRTC sink ask so"
https://bugs.webkit.org/show_bug.cgi?id=205645
https://trac.webkit.org/changeset/258391
- 1:19 PM Changeset in webkit [258423] by
-
- 4 edits in trunk/LayoutTests
[Mac wk2 ] fast/dom/attr_dead_doc.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207668
<rdar://problem/59404606>
Reviewed by Geoffrey Garen.
The test was doing a navigation to about:blank and relying on a 100ms timer to update the src
attribute of the img element. We now remove the frame from the document instead since it
detaches the document synchronously. It gets rid of the 100ms timer and replaces it with a
0 timer which will reliably give the same output.
- fast/dom/attr_dead_doc-expected.txt:
- fast/dom/attr_dead_doc.html:
- platform/mac-wk2/TestExpectations:
- 1:07 PM Changeset in webkit [258422] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 Debug] inspector/injected-script/avoid-getter-invocation.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209073
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 12:43 PM Changeset in webkit [258421] by
-
- 32 edits1 copy1 add3 deletes in trunk
Report all third party loads on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=209032
<rdar://problem/60397323>
Reviewed by Chris Dumez.
Source/WebCore:
Test: http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html
Rename this function to more accurately reflect its purpose of sending
loaded registrable domains to the WebPage.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
Source/WebKit:
Test: http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html
Removed IPC to the Network Process asking if a resource load is from
a prevalent domain. This now stores and sends all loaded registrable
domains. This patch is mostly updating naming to reflect this and
deleting the unnecessary code to communicate with the
ResourceLoadStatisticsStore.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::requestStorageAccessUnderOpener):
(WebKit::NetworkConnectionToWebProcess::isPrevalentSubresourceLoad): Deleted.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _loadedThirdPartyDomainsFor:completionHandler:]):
(-[WKWebsiteDataStore _clearLoadedThirdPartyDomainsFor:]):
(-[WKWebsiteDataStore _getPrevalentDomainsFor:completionHandler:]): Deleted.
(-[WKWebsiteDataStore _clearPrevalentDomainsFor:]): Deleted.
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didLoadFromRegistrableDomain):
(WebKit::WebFrameLoaderClient::addLoadedRegistrableDomain): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didLoadFromRegistrableDomain):
Add a check that this is a third party by comparing the target domain
to the main frame domain.
(WebKit::WebPage::loadedThirdPartyDomains):
(WebKit::WebPage::clearLoadedThirdPartyDomains):
(WebKit::WebPage::addLoadedRegistrableDomain): Deleted.
(WebKit::WebPage::getPrevalentDomains): Deleted.
(WebKit::WebPage::clearPrevalentDomains): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Mostly naming updates to reflect the change in use for this SPI call.
It now returns all loaded third party domains, not just prevalent ones.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::getLoadedThirdPartyDomains):
(WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
(WTR::TestRunner::getPrevalentDomains): Deleted.
(WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::getLoadedThirdPartyDomains):
(WTR::TestController::clearLoadedThirdPartyDomains):
(WTR::TestController::getPrevalentDomains): Deleted.
(WTR::TestController::clearPrevalentDomains): Deleted.
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
(WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::getLoadedThirdPartyDomains):
(WTR::TestController::clearLoadedThirdPartyDomains):
(WTR::TestController::getPrevalentDomains): Deleted.
(WTR::TestController::clearPrevalentDomains): Deleted.
LayoutTests:
Now that we report all loaded third party domains, we no longer need
ITP to test this call. We can eliminate the dual testing for
memory/database setup and any logic related to setting a resource
as prevalent.
- http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported-expected.txt: Copied from LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt.
- http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html: Added.
- http/tests/resourceLoadStatistics/prevalent-domains-per-page-database-expected.txt: Removed.
- http/tests/resourceLoadStatistics/prevalent-domains-per-page-database.html: Removed.
- http/tests/resourceLoadStatistics/prevalent-domains-per-page.html: Removed.
- http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt:
- http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html:
- platform/ios/TestExpectations:
Since this test no longer uses UIHelper.activateAt, it can be
unskipped in iOS
- 12:33 PM Changeset in webkit [258420] by
-
- 3 edits in trunk/Tools
[ews] run FindModifiedChangeLogs early in the build
https://bugs.webkit.org/show_bug.cgi?id=209060
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/factories.py:
- BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
- 12:19 PM Changeset in webkit [258419] by
-
- 2 edits in trunk/JSTests
skip wasm/function-tests/grow-memory-cause-gc.js on memory limited devices
https://bugs.webkit.org/show_bug.cgi?id=209069
<rdar://problem/59954558>
Reviewed by Yusuke Suzuki.
- wasm/function-tests/grow-memory-cause-gc.js:
- 12:07 PM Changeset in webkit [258418] by
-
- 6 edits in trunk/Tools
[GTK] Add EWS testers to run GTK layout tests
https://bugs.webkit.org/show_bug.cgi?id=207648
Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
tests (layout tests).
- BuildSlaveSupport/ews-build/config.json: Added new queue for
WK2 tests.
- BuildSlaveSupport/ews-build/factories.py:
(GTKTestsFactory):
- BuildSlaveSupport/ews-build/factories_unittest.py:
(TestCommitQueueFactory.test_commit_queue_factory):
(TestGTKFactory): Added unit-test.
(TestGTKFactory.test_gtk_factory):
- BuildSlaveSupport/ews-build/loadConfig.py:
- BuildSlaveSupport/ews-build/loadConfig_unittest.py:
(TagsForBuilderTest.test_getTagsForBuilder):
- 11:57 AM Changeset in webkit [258417] by
-
- 2 edits in trunk/LayoutTests
[ Mac Debug ] http/tests/css/shared-stylesheet-mutation-preconstruct.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209072
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:55 AM Changeset in webkit [258416] by
-
- 18 edits in trunk/Source/WebCore
Remove AffectedByDrag style flag
https://bugs.webkit.org/show_bug.cgi?id=209054
Reviewed by Simon Fraser.
As a followup to r258321, remove the last remaining user action related AffectedBy flag.
This also cleans out a bunch of scetchy, risky code from render tree (style invalidation!).
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::createDragImage const):
- dom/Element.cpp:
(WebCore::Element::isUserActionElementDragged const):
(WebCore::Element::setBeingDragged):
Move dragged state for render tree to Element where it belongs.
(WebCore::Element::hasFlagsSetDuringStylingOfChildren const):
- dom/Element.h:
(WebCore::Element::isBeingDragged const):
(WebCore::Element::descendantsAffectedByPreviousSibling const):
(WebCore::Element::setDescendantsAffectedByPreviousSibling):
(WebCore::Element::childrenAffectedByDrag const): Deleted.
(WebCore::Element::setChildrenAffectedByDrag): Deleted.
- dom/Node.h:
- dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::isBeingDragged):
(WebCore::UserActionElementSet::setBeingDragged):
Invalidate using PseudoClassChangeInvalidation that doesn't require any flags.
- platform/DragImage.cpp:
(WebCore::ScopedNodeDragEnabler::ScopedNodeDragEnabler):
(WebCore::ScopedNodeDragEnabler::~ScopedNodeDragEnabler):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateDragState): Deleted.
- rendering/RenderBlock.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateDragState): Deleted.
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::updateDragState): Deleted.
(WebCore::RenderObject::setIsDragging): Deleted.
- rendering/RenderObject.h:
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
(WebCore::RenderObject::isDragging const): Deleted.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::affectedByDrag const): Deleted.
(WebCore::RenderStyle::setAffectedByDrag): Deleted.
- style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):
- style/StyleRelations.h:
- 11:52 AM Changeset in webkit [258415] by
-
- 2 edits1 add in trunk/Tools
Add API endpoint in EWS django app to provide patch status in json format
https://bugs.webkit.org/show_bug.cgi?id=208940
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
- BuildSlaveSupport/ews-app/ews/views/status.py: Added.
- 11:36 AM Changeset in webkit [258414] by
-
- 2 edits in trunk/Tools
WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
https://bugs.webkit.org/show_bug.cgi?id=209055
<rdar://problem/60272692>
Reviewed by Simon Fraser.
Now that WebKitTestRunner has a bundleID, its' user default values
persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
to NO before running tests. It will be set to YES in PlatformWebView
if specified by the test.
- WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):
- 11:24 AM Changeset in webkit [258413] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209067
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 11:10 AM Changeset in webkit [258412] by
-
- 10 edits3 moves in trunk
[CMake] Eleminate mismatches between Find* module names and variables they set
https://bugs.webkit.org/show_bug.cgi?id=208948
Reviewed by Michael Catanzaro.
.:
- Source/cmake/FindLibseccomp.cmake:
- Source/cmake/FindWPEBackend_fdo.cmake: Renamed from Source/cmake/FindWPEBackend-fdo.cmake.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/ThirdParty/libwebrtc:
- CMakeLists.txt:
- cmake/FindAlsaLib.cmake:
- cmake/FindLibEvent.cmake:
- cmake/FindLibOpus.cmake: Renamed from Source/ThirdParty/libwebrtc/cmake/FindOpus.cmake.
- cmake/FindLibVpx.cmake: Renamed from Source/ThirdParty/libwebrtc/cmake/FindVpx.cmake.
Tools:
- wpe/backends/CMakeLists.txt:
- 10:56 AM Changeset in webkit [258411] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
[iOS] 9 imported/w3c/web-platform-tests/pointerevents/pointerevent tests are failing since import in r253630
https://bugs.webkit.org/show_bug.cgi?id=209064
<rdar://problem/60330378>
Reviewed by Simon Fraser.
In r253630 we imported a host of new and updated WPT tests and these included changes to testdriver.js that our testdriver-vendor.js
implementation didn't know to handle. Specifically, pauses are now added after each pointer action to add a 16ms delay.
It was a mistake to use a stationary touch for pauses, instead we shuld just increase the time offset with the value set in the pause
and avoid changing any other state, so no resetting the last known x and y values, or adding a new touch into the event stream that
will be passed to UIScriptController.
And since there is now a built-in pause between pointer actions, there is also no need to set a harcoded value for a default
timeoffset, this is now provided directly by the action input.
- web-platform-tests/resources/testdriver-vendor.js:
- 10:51 AM Changeset in webkit [258410] by
-
- 4 edits in trunk
Bound functions should pass correct NewTarget value
https://bugs.webkit.org/show_bug.cgi?id=209057
Reviewed by Keith Miller.
JSTests:
- test262/expectations.yaml: Mark 4 test cases as passing.
Source/JavaScriptCore:
This change implements steps 5-6 of bound function's Construct? method [1],
fixing bound function subclasses and aligning JSC with V8 and SpiderMonkey.
[1]: https://tc39.es/ecma262/#sec-bound-function-exotic-objects-construct-argumentslist-newtarget
- runtime/JSBoundFunction.cpp:
(JSC::boundThisNoArgsFunctionConstruct):
(JSC::boundFunctionConstruct):
- 10:44 AM Changeset in webkit [258409] by
-
- 4 edits in branches/safari-610.1.7-branch
Cherry-pick r258399. rdar://problem/60422524
Crash in TextIterator::node via TextManipulationController::replace
https://bugs.webkit.org/show_bug.cgi?id=209048
Reviewed by Wenson Hsieh.
Source/WebCore:
The crash was caused by item.start being null in TextManipulationController::replace for a paragraph
consisting of just an image because TextManipulationController::observeParagraphs never may never set
startOfCurrentParagraph in such a case (content.isTextContent can be false for an image!).
Fixed the bug by setting startOfCurrentParagraph to a position before the current content's node
when inserting a token for a RenderReplaced if it's null.
Test: TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage
- editing/TextManipulationController.cpp: (WebCore::TextManipulationController::observeParagraphs):
Tools:
Added a regression test.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:44 AM Changeset in webkit [258408] by
-
- 2 edits in branches/safari-610.1.7-branch/Source/WebKitLegacy/ios
Cherry-pick r258383. rdar://problem/60408777
rdar://problem/60359230 Mark locationManager:didChangeAuthorizationStatus: as deprecated.
- Misc/WebGeolocationCoreLocationProvider.mm: (-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:40 AM Changeset in webkit [258407] by
-
- 2 edits in trunk/Tools
[ews-app] reduce logging
https://bugs.webkit.org/show_bug.cgi?id=209062
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
(BugzillaBeautifulSoup.authenticate):
(BugzillaBeautifulSoup._load_query):
- 10:16 AM Changeset in webkit [258406] by
-
- 2 edits in trunk/LayoutTests
[iOS WK2] Some pointerevents tests time out
https://bugs.webkit.org/show_bug.cgi?id=209026
<rdar://problem/60338691>
Reviewed by Wenson Hsieh.
Pointerevents tests that used ui.* functions threw errors in the UI-side script because ui._run() bungled
the callbacks. Fix ui._run() to take two arguments, the command name and all arguments except the callback,
which it adds.
The tests are skipped in Open Source because most of them require touch events.
- pointerevents/utils.js:
(const.ui.new.UIController.prototype.swipe):
(const.ui.new.UIController.prototype.tap):
(const.ui.new.UIController.prototype.doubleTap):
(const.ui.new.UIController.prototype.doubleTapToZoom):
(const.ui.new.UIController.prototype.tapStylus):
(const.ui.new.UIController.prototype._runEvents):
(const.ui.new.UIController.prototype._run):
(const.ui.new.UIController):
(const.ui.new.UIController.prototype._run.): Deleted.
(const.ui.new.UIController.prototype._run.return.new.Promise): Deleted.
- 10:14 AM Changeset in webkit [258405] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] fast/frames/sandboxed-iframe-navigation-allowed.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206680
<rdar://problem/58840416>
Reviewed by Sam Weinig.
Make sure both iframes have finished loading before running the test. Previously, it was waiting for one of the
iframes to be loaded before doing the checks on both iframes. In some cases, the second iframe would not have
finished loading yet.
- fast/frames/sandboxed-iframe-navigation-allowed.html:
- 10:05 AM Changeset in webkit [258404] by
-
- 8 edits in branches/safari-609.2.1.2-branch/Source
Versioning.
- 9:50 AM Changeset in webkit [258403] by
-
- 4 edits in trunk/Source/WebKit
Remove unused SmartMagnificationController Magnify message
https://bugs.webkit.org/show_bug.cgi?id=209036
<rdar://problem/59678060>
Reviewed by Tim Horton.
Remove the unused Magnify message from the SmartMagnificationController, since this is dead code.
- UIProcess/ios/SmartMagnificationController.h:
- UIProcess/ios/SmartMagnificationController.messages.in:
- UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::magnify): Deleted.
- 9:35 AM Changeset in webkit [258402] by
-
- 2 edits in trunk/Source/WebCore
[WebAccessibilityObjectWrapper renderWidgetChildren] does not need to run on main thread.
https://bugs.webkit.org/show_bug.cgi?id=209053
<rdar://problem/60349440>
Reviewed by Chris Fleizach.
Since we are caching the platform widget in IsolatedMode (NSView),
there is no need to dispatch renderWidgetChildren to the main thread.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
- 9:22 AM Changeset in webkit [258401] by
-
- 2 edits in trunk/Source/WebKit
WebPageProxy::SetPromisedDataForImage should validate its
imageSizeandarchiveSizeparameters
<https://webkit.org/b/209029>
<rdar://problem/60181394>
Reviewed by Youenn Fablet.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setPromisedDataForImage):
- Validate
imageSizeandarchiveSizeusing MESSAGE_CHECK(). - Add static_cast<size_t>() to
imageSizeandarchiveSizeparameters to denote type change. - Add nullptr check for SharedMemory::map() result with
archiveHandle.
- 9:11 AM Changeset in webkit [258400] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] webgpu/whlsl/uint-bitwise.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=209056
Unreviewed test gardening
- platform/mac/TestExpectations:
- 8:20 AM Changeset in webkit [258399] by
-
- 4 edits in trunk
Crash in TextIterator::node via TextManipulationController::replace
https://bugs.webkit.org/show_bug.cgi?id=209048
Reviewed by Wenson Hsieh.
Source/WebCore:
The crash was caused by item.start being null in TextManipulationController::replace for a paragraph
consisting of just an image because TextManipulationController::observeParagraphs never may never set
startOfCurrentParagraph in such a case (content.isTextContent can be false for an image!).
Fixed the bug by setting startOfCurrentParagraph to a position before the current content's node
when inserting a token for a RenderReplaced if it's null.
Test: TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::observeParagraphs):
Tools:
Added a regression test.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
- 7:55 AM Changeset in webkit [258398] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=209047
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 7:53 AM WebKitGTK/2.26.x edited by
- Marked 2.26.5 merges as done (diff)
- 7:51 AM Changeset in webkit [258397] by
-
- 2 edits in releases/WebKitGTK/webkit-2.26/Source/WebCore
Merge r257292 - PS-2019-006: [GTK] WebKit - AXObjectCache - m_deferredFocusedNodeChange - UaF
https://bugs.webkit.org/show_bug.cgi?id=204342
Reviewed by Carlos Garcia Campos.
m_deferredFocusedNodeChange keeps pairs of a old node and a new one
to update a focused node later. When a node is removed in the document,
it is also removed from the pair vector. The problem is only comparing
the new node in each pair with a removed node decides the removal.
In the case where the removed node lives in m_deferredFocusedNodeChange
as an old node, a crash happens while we get a renderer of the removed node
to handle focused elements. To fix this, we find all entries of which old node
is matched to the removed node, and set their first value null.
No new tests since no functionality changed.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
- 7:51 AM Changeset in webkit [258396] by
-
- 2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit
Merge r256703 - [Geoclue] Avoid usage of provider in callbacks after it has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=207420
GeoclueGeolocationProvider was making non-cancelable g_dbus_proxy_call(s) with
bare |this| pointer.
Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2020-02-15
Reviewed by Carlos Garcia Campos.
- UIProcess/geoclue/GeoclueGeolocationProvider.cpp:
(WebKit::GeoclueGeolocationProvider::start):
(WebKit::GeoclueGeolocationProvider::stop):
(WebKit::GeoclueGeolocationProvider::setupManager):
(WebKit::GeoclueGeolocationProvider::createClient):
(WebKit::GeoclueGeolocationProvider::startClient):
(WebKit::GeoclueGeolocationProvider::didFail):
- UIProcess/geoclue/GeoclueGeolocationProvider.h:
- 7:51 AM Changeset in webkit [258395] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.26
Merge r258143 - Tail calls are broken on ARM_THUMB2 and MIPS
https://bugs.webkit.org/show_bug.cgi?id=197797
Reviewed by Yusuke Suzuki.
JSTests:
- stress/tail-call-with-spilled-registers.js: Added.
Source/JavaScriptCore:
prepareForTailCalloperation expects that header size + parameters
size is aligned with stack (alignment is 16-bytes for every architecture).
This means that headerSizeInBytes + argumentsIncludingThisInBytes needs
to be multiple of 16. This was not being preserved during getter IC code
for 32-bits. The code generated was taking in account only
headerSizeInRegisters (it is 4 on 32-bits) and argumentsIncludingThis
(that is always 1 for getters) and allocating 32-bytes when applying
operation(headerSize + argumentsIncludingThis) * 8 - sizeof(CallerFrameAndPC).
This results in a stack frame with size of 40 bytes (after we push
lrandsp). SinceprepareForTailCallexpects frames to be
16-bytes aligned, it will then calculate the top of such frame
considering it is 48 bytes, cloberring values of previous frame and
causing unexpected behavior. This patch is fixing how this IC code
calculates the stack frame usingroundArgumentCountToAlignFrame(numberOfParameters)
aligning with what we do on code without IC installed.
This was not a problem for getter and setter IC on 64-bits because
roundArgumentCountToAlignFrame(1) == 1androundArgumentCountToAlignFrame(2) == 3
while it isroundArgumentCountToAlignFrame(1) == 2and
roundArgumentCountToAlignFrame(2) == 2for MIPS and ARMv7.
- bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
- 5:01 AM Changeset in webkit [258394] by
-
- 4 edits in releases/WebKitGTK/webkit-2.26/Source/WebCore
Merge r254680 - Do not detect the stopped animations in Nicosia::Animation to avoid flashback
https://bugs.webkit.org/show_bug.cgi?id=206280
Patch by Tomoki Imai <Tomoki Imai> on 2020-01-16
Reviewed by Carlos Garcia Campos.
This fixes the animation flashback issue found in https://webkit.org/blog-files/3d-transforms/morphing-cubes.html.
The flashback was caused by using the old layer transform matrix saved when the animation has been started.
The root cause is an inconsistency of animation state in Nicosia::Animation and CoordinatedGraphicsLayer.
For Nicosia::Animation, ThreadedCompositor increases MonitonicTime for animation every frame, and calls Nicosia::Animation::apply.
For CoordinatedGraphicsLayer, CSSAnimationController updates animations list and if the animation has been finished it updates CSS value.
There is a chance to use old layer state while the Nicosia::Animation stopped, but CoordinatedGraphicsLayer still obtains old CSS value and animations.
In this patch, all the Nicosia::Animation is considered to have "AnimationFillMode::Forwards" or "AnimationFillMode::Both",
which means they are active and use the last position when the animation is stopped.
Stopping and removing animations should be only done by CSSAnimationController and CoordinatedGraphicsScene
as they can remove the animation from the list and update the CSS value at the same time.
Mac implementation GraphicsLayerCA has a similar logic, it replaces AnimationFillMode with Forwards or Both.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp?rev=254502#L3248
Tested manually with https://webkit.org/blog-files/3d-transforms/morphing-cubes.html
- platform/graphics/nicosia/NicosiaAnimation.cpp:
(Nicosia::Animation::apply): Return the last value for stopped animations to avoid flickering
(Nicosia::Animation::isActive const): Removed. It should always return true because
all the animations are considered as fillsForwards in Nicosia::Animation to avoid flashback.
(Nicosia::Animations::hasActiveAnimationsOfType const): Remove isActive check.
(Nicosia::Animations::getActiveAnimations() const): Removed. It returns whole animations list because all the animations are active.
- platform/graphics/nicosia/NicosiaAnimation.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
- 3:37 AM Changeset in webkit [258393] by
-
- 3 edits in trunk/Source/WebKit
[SOUP] Notify web process about WebSocket handshake request and response
https://bugs.webkit.org/show_bug.cgi?id=208994
Reviewed by Youenn Fablet.
This makes WebSockets appear again in web inspector.
- NetworkProcess/soup/WebSocketTaskSoup.cpp:
(WebKit::WebSocketTask::WebSocketTask): Save the handshake message and notify the channel when the request is sent.
(WebKit::WebSocketTask::didConnect): Notify the channel that handshake response has been received.
(WebKit::WebSocketTask::didFail): Notify the channel that handshake response has been received if handshake
failed.
- NetworkProcess/soup/WebSocketTaskSoup.h:
- 3:31 AM Changeset in webkit [258392] by
-
- 2 edits in trunk/Source/WebCore
-Wredundant-move in CSSPropertyParserHelpers.cpp
https://bugs.webkit.org/show_bug.cgi?id=209019
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-13
Reviewed by Youenn Fablet.
Silence compiler warning by removing improper WTFMove().
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
- 3:13 AM Changeset in webkit [258391] by
-
- 14 edits2 adds in trunk
Apply rotation at source level if WebRTC sink ask so
https://bugs.webkit.org/show_bug.cgi?id=205645
Reviewed by Eric Carlson.
Source/WebCore:
Add a virtual method to RealtimeMediaSource to pass the information that the sink prefers the frames to be rotated before sending them.
Source/WebKit:
Implement RealtimeMediaSource setShouldApplyRotation by sending IPC to capture process.
In capture process, if rotation should be applied, use an ImageRotationSessionVT session to apply it before sending the video frame.
This allows WebProcess to no longer need an ImageRotationSessionVT for WebRTC.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::setShouldApplyRotation):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::rotatePixelBuffer):
(WebKit::UserMediaCaptureManagerProxy::setShouldApplyRotation):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::setShouldApplyRotation):
LayoutTests:
- webrtc/video-rotation-no-cvo-expected.txt: Added.
- webrtc/video-rotation-no-cvo.html: Added.
- 3:10 AM Changeset in webkit [258390] by
-
- 13 edits in trunk/Source
Remove use of PlatformMediaSession types in AudioSession
https://bugs.webkit.org/show_bug.cgi?id=208995
Reviewed by Eric Carlson.
Source/WebCore:
Remove type for beginInterruption since AudioSession always trigger system interruptions.
Have a dedicated type for endInterruption.
No change of behavior.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::beginInterruption):
(WebCore::AudioSession::endInterruption):
- platform/audio/AudioSession.h:
- platform/audio/ios/AudioSessionIOS.mm:
(-[WebInterruptionObserverHelper interruption:]):
(WebCore::AudioSession::beginInterruption):
(WebCore::AudioSession::endInterruption):
- platform/audio/ios/MediaSessionManagerIOS.h:
Source/WebKit:
Update code according WebCore API changes.
Make use of AudioSession current code path to make RemoteAudioSession notify its observers.
- GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::setCategory):
(WebKit::RemoteAudioSessionProxy::beginInterruption):
(WebKit::RemoteAudioSessionProxy::endInterruption):
- GPUProcess/media/RemoteAudioSessionProxy.h:
- GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::tryToSetActiveForProcess):
(WebKit::RemoteAudioSessionProxyManager::beginAudioSessionInterruption):
(WebKit::RemoteAudioSessionProxyManager::endAudioSessionInterruption):
- GPUProcess/media/RemoteAudioSessionProxyManager.h:
- WebProcess/GPU/media/RemoteAudioSession.cpp:
(WebKit::RemoteAudioSession::beginInterruption): Deleted.
(WebKit::RemoteAudioSession::endInterruption): Deleted.
- WebProcess/GPU/media/RemoteAudioSession.h:
- WebProcess/GPU/media/RemoteAudioSession.messages.in:
- 2:46 AM Changeset in webkit [258389] by
-
- 2 edits in trunk/Source/WebKit
Release build fix after r258384.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::threadEntry):
(WebKit::PDFPlugin::ByteRangeRequest::maybeComplete):
- 1:33 AM Changeset in webkit [258388] by
-
- 11 edits in trunk/Source/WebCore
Remove unused affectedBy style flags
https://bugs.webkit.org/show_bug.cgi?id=209009
Reviewed by Antoine Quint.
These flags are unused after r258321. Remove the flags and the code that generates them.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addStyleRelationFunction):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasFocusWithin):
- dom/Element.cpp:
(WebCore::Element::hasFlagsSetDuringStylingOfChildren const):
(WebCore::Element::resetStyleRelations):
- dom/Element.h:
(WebCore::Element::styleAffectedByEmpty const):
(WebCore::Element::descendantsAffectedByPreviousSibling const):
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::setDescendantsAffectedByPreviousSibling):
(WebCore::Element::styleAffectedByActive const): Deleted.
(WebCore::Element::styleAffectedByFocusWithin const): Deleted.
(WebCore::Element::childrenAffectedByHover const): Deleted.
(WebCore::Element::setStyleAffectedByFocusWithin): Deleted.
(WebCore::Element::setChildrenAffectedByHover): Deleted.
(WebCore::Element::setStyleAffectedByActive): Deleted.
- dom/Node.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::affectedByDrag const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::affectedByHover const): Deleted.
(WebCore::RenderStyle::affectedByActive const): Deleted.
(WebCore::RenderStyle::setAffectedByHover): Deleted.
(WebCore::RenderStyle::setAffectedByActive): Deleted.
- style/StyleRelations.cpp:
(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):
- style/StyleRelations.h:
- style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):
Compare the hasFocusWithin bit instead.
- 12:57 AM Changeset in webkit [258387] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, change ASSERT to ASSERT_WITH_SECURITY_IMPLICATION since it is now enabled under ENABLE(SECURITY_ASSERTIONS)
https://bugs.webkit.org/show_bug.cgi?id=209041
<rdar://problem/59705631>
- runtime/JSCast.h:
(JSC::jsCast):
- 12:53 AM Changeset in webkit [258386] by
-
- 9 edits in trunk/Source
Report crashed cell in jsCast in debug builds
https://bugs.webkit.org/show_bug.cgi?id=209041
<rdar://problem/59705631>
Reviewed by Mark Lam.
Source/JavaScriptCore:
To collect more information when crashing with jsCast, we attempt to use reportZappedCellAndCrash.
If it succeeds, we can get more information in registers. We enable this only for ASSERT_ENABLED
build. For non ASSERT_ENABLED, we keep the original assertion since this assertion can be enabled
via ENABLE(SECURITY_ASSERTIONS).
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::reportZappedCellAndCrash): Deleted.
- heap/SlotVisitor.h:
- runtime/JSCast.h:
(JSC::jsCast):
- runtime/JSCell.cpp:
(JSC::reportZappedCellAndCrash):
- runtime/JSCell.h:
Source/WebCore:
We should take JSLock when touching JSC::VM.
- page/MemoryRelease.cpp:
(WebCore::logMemoryStatisticsAtTimeOfDeath):
- page/PerformanceLogging.cpp:
(WebCore::PerformanceLogging::memoryUsageStatistics):
- 12:24 AM Changeset in webkit [258385] by
-
- 2 edits in trunk/Tools
Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
https://bugs.webkit.org/show_bug.cgi?id=209038
Reviewed by Keith Miller.
This allows us to automatically pull in some tests that are in non open sourced Apple
checkouts.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
Mar 12, 2020:
- 10:55 PM Changeset in webkit [258384] by
-
- 4 edits in trunk/Source/WebKit
Add a very verbose logging mode for incremental PDF loading
https://bugs.webkit.org/show_bug.cgi?id=208975
Reviewed by Simon Fraser.
Adds a verbose logging channel that includes a full dump of the PDFPlugin's loading status
for each logging message.
- Platform/Logging.h:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfLog):
(WebKit::PDFPlugin::logStreamLoader):
(WebKit::PDFPlugin::verboseLog):
(WebKit::dataProviderGetBytesAtPositionCallback):
(WebKit::dataProviderGetByteRangesCallback):
(WebKit::PDFPlugin::getResourceBytesAtPosition):
(WebKit::PDFPlugin::adoptBackgroundThreadDocument):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithBytes):
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData):
(WebKit::PDFPlugin::forgetLoader):
- 10:45 PM Changeset in webkit [258383] by
-
- 2 edits in trunk/Source/WebKitLegacy/ios
rdar://problem/60359230 Mark locationManager:didChangeAuthorizationStatus: as deprecated.
- Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
- 10:30 PM Changeset in webkit [258382] by
-
- 5 edits2 adds in trunk
REGRESSION(r255957): Element with scroll-behavior:smooth isn't draggable after r255957
https://bugs.webkit.org/show_bug.cgi?id=208566
Reviewed by Simon Fraser and Frédéric Wang.
Source/WebCore:
To perform smooth scroll, RenderLayer::scrollRectToVisible checks the value of scroll-behavior.
It starts an animated scrolling if scroll-behavior is smooth.
On the other hand, the drag action would start an autoscroll if the element is scrollable.
The autoscroll uses m_autoscrollTimer which is a repeating timer, when the timer fired it calls
scrollRectToVisible with different positions.
So if performing autoscroll on scroll-bahavior: smooth element, there are two nested animations.
When timer fired, scrollRectToVisible is called, because of scroll-behavior:smooth, it starts
animated scrolling not instant scrolling. Then there's the next timer fired, the previous
animated scrolling would be canceled. Eventually, the element becomes un-draggable.
To fix this, while performing autoscroll, scrollRectToVisible shouldn't trigger animated scrolling
no matter what the value of scroll-behavior is.
Test: fast/events/drag-smooth-scroll-element.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
LayoutTests:
The test uses eventSender to generate drag action.
- fast/events/drag-smooth-scroll-element-expected.txt: Added.
- fast/events/drag-smooth-scroll-element.html: Added.
- platform/ios/TestExpectations: IOS doesn't support mouse events, so skip the test.
- 9:16 PM Changeset in webkit [258381] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG nodes that take a TypedArray's storage need to keepAlive the TypedArray
https://bugs.webkit.org/show_bug.cgi?id=209035
Reviewed by Saam Barati.
It might be possible to produce a graph where the last reference to a TypedArray
is via a GetByVal or PutByVal. Since those nodes don't create any reference to the
TypedArray in B3 we may end up not keeping the TypedArray alive until after the
storage access.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
- 8:47 PM Changeset in webkit [258380] by
-
- 5 edits2 adds in trunk
RenderTreeNeedsLayoutChecker asserts with imported/w3c/web-platform-tests/css/css-position/position-absolute-crash-chrome-005.html
https://bugs.webkit.org/show_bug.cgi?id=209022
<rdar://problem/60390647>
Reviewed by Simon Fraser.
Source/WebCore:
Fix the case when
- the block level box is no longer the containing block for its out-of-flow descendants and
- the new containing block does not get marked dirty because there's a re-layout boundary (overflow: hidden)
between the old and the new containing block.
Test: fast/block/containing-block-for-out-of-flow-becomes-static.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
LayoutTests:
- TestExpectations:
- fast/block/containing-block-for-out-of-flow-becomes-static-expected.html: Added.
- fast/block/containing-block-for-out-of-flow-becomes-static.html: Added.
- 8:09 PM Changeset in webkit [258379] by
-
- 6 edits in trunk/Source
Correct preference handling and naming conventions in AppBound browsing preferences
https://bugs.webkit.org/show_bug.cgi?id=209031
<rdar://problem/60396298>
Reviewed by John Wilander.
Source/WebKit:
I made a mistake in the handling of preferences related to the IsInAppBrowserPrivacyEnabled
and the quirk flag, which led to some code not executing when expected.
This patch does the following:
- Uses the correct naming scheme for WebKit Internal Debug flags. They should be 'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'.
- Updates the local quirk state in WebPage when page settings change.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WebKitLegacy/mac:
This patch consistently uses the correct naming scheme for WebKit Internal Debug flags.
They should be 'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences isInAppBrowserPrivacyEnabled]):
(-[WebPreferences setInAppBrowserPrivacyEnabled:]):
(-[WebPreferences needsInAppBrowserPrivacyQuirks]):
(-[WebPreferences setNeedsInAppBrowserPrivacyQuirks:]):
- 5:51 PM Changeset in webkit [258378] by
-
- 4 edits in branches/safari-610.1.7-branch
Cherry-pick r258371. rdar://problem/60395490
Crash in TextManipulationController::replace
https://bugs.webkit.org/show_bug.cgi?id=209021
Reviewed by Wenson Hsieh.
Source/WebCore:
This patch addresses two issues that can lead to a crash in TextManipulationController::replace.
The biggest issue here is that commonAncestor can be a descendent of insertionPoint's containerNode.
Addressed this issue by computing the first node to remove in the same traveral where commonAncestor
is computed by way of remembering the very first content node (firstContentNode). This also lets us
eliminate the secondary, redundant traversal to discover all the nodes to remove.
In addition, the set of nodes to remove could sometimes contain commonAncestor and its ancestors.
This patch addresses this issue by removing all inclusive ancestors of commonAncestor from nodesToRemove.
- editing/TextManipulationController.cpp: (WebCore::TextManipulationController::replace):
Tools:
Added a regression test.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:51 PM Changeset in webkit [258377] by
-
- 5 edits in branches/safari-610.1.7-branch
Revert r258353. rdar://problem/60395490
- 5:51 PM Changeset in webkit [258376] by
-
- 4 edits in branches/safari-610.1.7-branch
Revert r258354. rdar://problem/60395490
- 5:47 PM Changeset in webkit [258375] by
-
- 8 edits in branches/safari-610.1.7-branch/Source
Versioning.
- 5:15 PM Changeset in webkit [258374] by
-
- 2 edits in trunk/Source/WebKit
WebPageProxy::SaveImageToLibrary should validate its
imageSizeparameter
<https://webkit.org/b/209012>
<rdar://problem/60181295>
Reviewed by Chris Dumez.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::saveImageToLibrary):
- Validate upper bound of
imageSizeparameter. - Add static_cast<size_t>() to
imageSizeparameter to denote type change.
- 4:55 PM Changeset in webkit [258373] by
-
- 3 edits in trunk/LayoutTests
http/tests/paymentrequest/page-cache-completed-payment-response.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207385
<rdar://problem/59260167>
Unreviewed, address flakiness by only making sure that the promises get rejected, without checking
which error it is actually rejected with, since this is racy.
- http/tests/paymentrequest/page-cache-completed-payment-response.https.html:
- platform/mac-wk2/TestExpectations:
- 4:49 PM Changeset in webkit [258372] by
-
- 5 edits in trunk/LayoutTests
[ Mac ] fast/history/page-cache-webdatabase-pending-transaction.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=207010
<rdar://problem/59035295>
Unreviewed, silence console messages to address flakiness.
LayoutTests/imported/w3c:
- web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno-expected.txt:
LayoutTests:
- TestExpectations:
- platform/mac/TestExpectations:
- 4:29 PM Changeset in webkit [258371] by
-
- 4 edits in trunk
Crash in TextManipulationController::replace
https://bugs.webkit.org/show_bug.cgi?id=209021
Reviewed by Wenson Hsieh.
Source/WebCore:
This patch addresses two issues that can lead to a crash in TextManipulationController::replace.
The biggest issue here is that commonAncestor can be a descendent of insertionPoint's containerNode.
Addressed this issue by computing the first node to remove in the same traveral where commonAncestor
is computed by way of remembering the very first content node (firstContentNode). This also lets us
eliminate the secondary, redundant traversal to discover all the nodes to remove.
In addition, the set of nodes to remove could sometimes contain commonAncestor and its ancestors.
This patch addresses this issue by removing all inclusive ancestors of commonAncestor from nodesToRemove.
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
Tools:
Added a regression test.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
- 4:21 PM Changeset in webkit [258370] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (257740?): [ iOS ] fast/events/autoscroll-in-iframe.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=209025
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 4:17 PM Changeset in webkit [258369] by
-
- 4 edits in trunk/Source/WebKit
Check for overflows in MachMessage::messageSize()
https://bugs.webkit.org/show_bug.cgi?id=209020
<rdar://problem/58264215>
Reviewed by Alex Christensen.
- Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::Connection::sendOutgoingMessage):
- Platform/IPC/cocoa/MachMessage.cpp:
(IPC::MachMessage::messageSize):
- Platform/IPC/cocoa/MachMessage.h:
- 4:14 PM Changeset in webkit [258368] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 Debug ] webgpu/whlsl/vector-compare.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=209024
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:10 PM Changeset in webkit [258367] by
-
- 5 edits in trunk/LayoutTests
[ macOS iOS ] fast/dom/connected-subframe-counter-overflow.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207152
<rdar://problem/59127411>
Unreviewed, mark the test as slow instead of flaky timeout. The test is slow to run because
it checks for some overflow and adds a lot of iframes to the document.
This patch also speed up the test a bit by marking the iframes as display:none *before* inserting
them into the document. We also now add the frames in a timer to yield and make sure that the
main thread stays responsive while running this test.
- TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 4:06 PM Changeset in webkit [258366] by
-
- 1 copy in tags/Safari-610.1.7.2
Tag Safari-610.1.7.2.
- 4:04 PM Changeset in webkit [258365] by
-
- 8 edits in branches/safari-610.1.7-branch/Source
Versioning.
- 3:43 PM Changeset in webkit [258364] by
-
- 5 edits in trunk/LayoutTests
[ Mac wk2 Release ] fast/dom/navigator-detached-no-crash.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207151
<rdar://problem/59126935>
Unreviewed, silence console warnings to address flakiness.
- TestExpectations:
- platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
- 3:29 PM Changeset in webkit [258363] by
-
- 3 edits in branches/safari-609-branch/LayoutTests
Cherry-pick r254979. rdar://problem/58836694
Actually fix history link directs on dashboard and results.html
https://bugs.webkit.org/show_bug.cgi?id=206666
Reviewed by Jonathan Bedard.
- fast/harness/results.html:
- legacy-animation-engine/fast/harness/results.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:56 PM Changeset in webkit [258362] by
-
- 2 edits in trunk/LayoutTests
[ Catalina wk2 ] webrtc/video-autoplay1.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=209018
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 2:42 PM Changeset in webkit [258361] by
-
- 35 edits in trunk
[CMake] Find modules should find pkg-config with find_package(PkgConfig QUIET)
https://bugs.webkit.org/show_bug.cgi?id=208948
Reviewed by Michael Catanzaro.
- Source/cmake/FindATK.cmake:
- Source/cmake/FindATKBridge.cmake:
- Source/cmake/FindATSPI.cmake:
- Source/cmake/FindCairo.cmake:
- Source/cmake/FindCairoGL.cmake:
- Source/cmake/FindEGL.cmake:
- Source/cmake/FindEnchant.cmake:
- Source/cmake/FindFontconfig.cmake:
- Source/cmake/FindGDK3.cmake:
- Source/cmake/FindGLIB.cmake:
- Source/cmake/FindGObjectIntrospection.cmake:
- Source/cmake/FindGStreamer.cmake:
- Source/cmake/FindGTK3.cmake:
- Source/cmake/FindGTKUnixPrint.cmake:
- Source/cmake/FindHarfBuzz.cmake:
- Source/cmake/FindLibEpoxy.cmake:
- Source/cmake/FindLibNotify.cmake:
- Source/cmake/FindLibPSL.cmake:
- Source/cmake/FindLibSoup.cmake:
- Source/cmake/FindLibseccomp.cmake:
- Source/cmake/FindLibsecret.cmake:
- Source/cmake/FindLibtasn1.cmake:
- Source/cmake/FindLibxkbcommon.cmake:
- Source/cmake/FindNghttp2.cmake:
- Source/cmake/FindOpenGL.cmake:
- Source/cmake/FindOpenGLES2.cmake:
- Source/cmake/FindOpenJPEG.cmake:
- Source/cmake/FindSQLite3.cmake:
- Source/cmake/FindWOFF2Dec.cmake:
- Source/cmake/FindWPE.cmake:
- Source/cmake/FindWPEBackend-fdo.cmake:
- Source/cmake/FindWayland.cmake:
- Source/cmake/FindWaylandProtocols.cmake:
- Source/cmake/FindWebP.cmake:
- 2:41 PM Changeset in webkit [258360] by
-
- 1 copy in tags/Safari-610.1.7.1
Tag Safari-610.1.7.1.
- 2:36 PM Changeset in webkit [258359] by
-
- 13 edits1 add in trunk
[macOS] _AXSApplicationAccessibilityEnabled should not be called
https://bugs.webkit.org/show_bug.cgi?id=208953
Reviewed by Brent Fulgham.
Source/WebCore:
The function _AXSApplicationAccessibilityEnabled and the notification kAXSApplicationAccessibilityEnabledNotification
exist on macOS, but they do not have the same behavior as on iOS, and should not be used in the same way. Using this
function and notification on macOS was introduced in <https://bugs.webkit.org/show_bug.cgi?id=208690>, and this patch
partially reverts this behavior.
API test: WebKit.IsRemoteUIAppForAccessibility
- testing/Internals.cpp:
(WebCore::Internals::isRemoteUIAppForAccessibility):
- testing/Internals.h:
- testing/Internals.idl:
- testing/Internals.mm:
(WebCore::Internals::isRemoteUIAppForAccessibility):
Source/WebCore/PAL:
Declare method to check if the process is a remote UI app for accessibility.
- pal/spi/cocoa/NSAccessibilitySPI.h:
Source/WebKit:
On macOS, stop using the function _AXSApplicationAccessibilityEnabled and listening to the notification
kAXSApplicationAccessibilityEnabledNotification, since they do not have the same behavior as on iOS.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::unblockAccessibilityServer):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 2:33 PM Changeset in webkit [258358] by
-
- 2 edits in trunk
[CMake] Avoid calling FPHSA multiple time in FindPerlModules.cmake
https://bugs.webkit.org/show_bug.cgi?id=208948
Reviewed by Michael Catanzaro.
- Source/cmake/FindPerlModules.cmake:
- 2:22 PM Changeset in webkit [258357] by
-
- 6 edits in trunk
Resource load statistics data summary should return all third party data
https://bugs.webkit.org/show_bug.cgi?id=209000
<rdar://problem/60348306>
Reviewed by John Wilander.
Source/WebKit:
No new tests, this patch adjusts old tests to test this new behavior
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _setThirdPartyCookieBlockingMode:onlyOnSitesWithoutUserInteraction:completionHandler:]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
Added new function _setThirdPartyCookieBlockingMode so API tests can
set this parameter.
Tools:
Marked only 2 of 3 domains prevalent in data summary tests to ensure
the call returns all third parties, not just prevalent ones.
Added a more aggressive check for the size of the array at the
beginning of the test to ensure the array is still returning 3 values.
Also removed the ASSERT statements as they seem to cause timeouts (not
clear crashes) when they are not true, which is hard to debug.
If these values are nil, the test will fail in the EXPECT_WK_STREQ
checks, we don't need ASSERT statements.
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
- 2:12 PM Changeset in webkit [258356] by
-
- 8 edits in trunk/Source/WebCore
Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often.
https://bugs.webkit.org/show_bug.cgi?id=209010
Reviewed by Chris Fleizach.
- [WebAccessibilityObjectWrapper scrollViewParent] is called very often
and blocks the AXThread to retrieve a value from the main thread. This
change caches the PlatformWidget for the corresponding ScrollView (an
NSView) to avoid hitting the main thread that often.
- In Addition, made the ScrollView member of AccessibilityScrollView a
WeakPtr instead of a naked pointer.
- Removed an unused lock from AXIsolatedObject and the const qualifier
from the return value of stringAttributeValue which is unnecessary.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::platformWidget const):
(WebCore::AccessibilityScrollView::widgetForAttachmentView const):
(WebCore::AccessibilityScrollView::webAreaObject const):
(WebCore::AccessibilityScrollView::documentFrameView const):
(WebCore::AccessibilityScrollView::parentObject const):
(WebCore::AccessibilityScrollView::parentObjectIfExists const):
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable const):
- accessibility/AccessibilityScrollView.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::stringAttributeValue const):
(WebCore::AXIsolatedObject::platformWidget const):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper scrollViewParent]):
- 2:06 PM Changeset in webkit [258355] by
-
- 1 edit6 adds in trunk/Tools
resultsdpy: Add script to run local instance
https://bugs.webkit.org/show_bug.cgi?id=208746
Rubber-stamped by Aakash Jain.
- resultsdbpy/resultsdbpy/example: Added.
- resultsdbpy/resultsdbpy/example/init.py: Added.
- resultsdbpy/resultsdbpy/example/environment.py: Added.
(Environment): Organize environment variables used by results database.
(ModelFromEnvironment): Construct the database model from the environment.
(main): Create and drop tables, if required.
- resultsdbpy/resultsdbpy/example/main.py: Added.
(health): Web-server health check.
(handle_errors):
(main): Run results database web-server.
- resultsdbpy/resultsdbpy/example/worker.py: Added.
(main): Asynchronously process uploaded results.
- resultsdbpy/resultsdbpy/run: Added.
- 2:01 PM Changeset in webkit [258354] by
-
- 4 edits in branches/safari-610.1.7-branch
Revert r258037. rdar://problem/60382950
- 2:01 PM Changeset in webkit [258353] by
-
- 5 edits in branches/safari-610.1.7-branch
Revert r258093. rdar://problem/60382950
- 1:47 PM Changeset in webkit [258352] by
-
- 8 edits in branches/safari-610.1.7-branch/Source
Versioning.
- 1:18 PM Changeset in webkit [258351] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk2 ] fast/scrolling/momentum-scroll-with-borders.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=209013
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 12:10 PM Changeset in webkit [258350] by
-
- 2 edits in trunk/Tools
run-webkit-tests --use-gpu-process should enable GPU Process for canvas
https://bugs.webkit.org/show_bug.cgi?id=209004
Reviewed by Tim Horton.
Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
use_gpu_processis specified.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 12:06 PM Changeset in webkit [258349] by
-
- 2 edits in trunk/Source/WebCore
Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=208996
Reviewed by Chris Fleizach.
Covered by existing tests.
Dispatch to the main thread the computation of these accessibility attributes.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 12:02 PM Changeset in webkit [258348] by
-
- 2 edits in trunk/LayoutTests
[WPE] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208993
Unreviewed gardening.
- platform/wpe/TestExpectations:
- 12:01 PM Changeset in webkit [258347] by
-
- 2 edits in trunk/Tools
Make flatpack import for run-webkit-tests only happen on linux systems
https://bugs.webkit.org/show_bug.cgi?id=208954
Reviewed by Philippe Normand.
- Scripts/run-webkit-tests: Added an if statement to find the system platform
to determine if we need the flatpackutils import.
- 11:43 AM Changeset in webkit [258346] by
-
- 5 edits2 moves in trunk
AX: Isolated tree: Crash in URL retrieval
https://bugs.webkit.org/show_bug.cgi?id=208942
<rdar://problem/60337588>
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/url-test.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url const): Check for m_renderer
before dereferencing and re-use the associated Node. Also fixes the last
type check and downcast that were using different types.
LayoutTests:
Moved the url-test.html test to the root directory so that it is
executed in both Mac and iOS.
- accessibility/url-test-expected.txt: Renamed from LayoutTests/accessibility/ios-simulator/url-test-expected.txt.
- accessibility/url-test.html: Renamed from LayoutTests/accessibility/ios-simulator/url-test.html.
- platform/ios-simulator/TestExpectations:
- platform/win/TestExpectations:
- 11:34 AM Changeset in webkit [258345] by
-
- 2 edits in trunk/LayoutTests/platform
REGRESSION: [ Mac iOS wk2 ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/execution-timing/085.html is failing
https://bugs.webkit.org/show_bug.cgi?id=209006
Unreviewed test gardening
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 11:33 AM Changeset in webkit [258344] by
-
- 13 edits1 add in trunk/Source/JavaScriptCore
[JSC] Use CacheableIdentifier in ByValInfo
https://bugs.webkit.org/show_bug.cgi?id=208978
Reviewed by Saam Barati.
CodeBlock::finalizeUnconditionally discards JITData. And this includes ByValInfo, which holds Identifier.
However, finalizeUnconditionally is only guaranteeing that the main thread is not working. It can be invoked
in the heap thread, and it is not not setting the AtomStringTable for this heap thread. If Identifier destroys
AtomStringImpl, which fails to unregister itself from the table.
In this patch,
- We explicitly set nullptr for the current AtomStringTable to catch the bug as soon as possible in GC end phase.
- We use CacheableIdentifier in ByValInfo to avoid destroying Identifier in CodeBlock::finalizeUnconditionally.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bytecode/ByValInfo.cpp: Added.
(JSC::ByValInfo::visitAggregate):
- bytecode/ByValInfo.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handlePutByVal):
- heap/Heap.cpp:
(JSC::Heap::runEndPhase):
- jit/JIT.h:
- jit/JITOperations.cpp:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitByValIdentifierCheck):
- runtime/CacheableIdentifier.h:
- 11:28 AM Changeset in webkit [258343] by
-
- 11 edits in trunk
WKWebView.hasOnlySecureContent should be correct after back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=207609
Source/WebCore:
<rdar://problem/59371252>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-12
Reviewed by Ryosuke Niwa.
The web process informs the UI process of insecure content loads when http resources are requested from https pages.
The web process also remembers that this happened.
Rather than ask the UI process during a navigation, which can sometimes get information about the wrong navigation,
just use the remembered values. We will need to do something for legacy TLS loads too, but I left that code as it is
for this patch. Another is coming soon.
Covered by API tests.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::setUsedLegacyTLS):
(WebCore::CachedFrame::hasInsecureContent const):
(WebCore::CachedFrame::setHasInsecureContent): Deleted.
- history/CachedFrame.h:
(WebCore::CachedFrame::hasInsecureContent const): Deleted.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
Source/WebKit:
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-12
Reviewed by Ryosuke Niwa.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::usedLegacyTLS):
(WebKit::WebPageProxy::hasInsecureContent): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):
Tools:
Patch by Alex Christensen <achristensen@webkit.org> on 2020-03-12
Reviewed by Ryosuke Niwa.
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 11:18 AM Changeset in webkit [258342] by
-
- 5 edits in trunk
REGRESSION (r257938): Some pointerevents/ios/touch-action-region tests started to fail
https://bugs.webkit.org/show_bug.cgi?id=209005
<rdar://problem/60337239>
Reviewed by Tim Horton, Wenson Hsieh.
Source/WebCore:
We need to continue to paint event regions if there are touch-action elements.
Tested by existing tests.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
LayoutTests:
New baselines for tests with overflow:scroll, where the scrolled container gets
a rectangular event region.
- pointerevents/ios/touch-action-region-backing-sharing-expected.txt:
- pointerevents/ios/touch-action-region-overflow-expected.txt:
- 11:15 AM Changeset in webkit [258341] by
-
- 2 edits in trunk/LayoutTests
Fixed expectations for two tests from 'Pass Failure' to 'Pass ImageOnlyFailure'
https://bugs.webkit.org/show_bug.cgi?id=205525
https://bugs.webkit.org/show_bug.cgi?id=205524
Unreviewed test gardening
- platform/mac/TestExpectations:
- 11:05 AM Changeset in webkit [258340] by
-
- 2 edits in trunk/Source/WebKit
Drop unused WebProcess::UpdateActivePages IPC
https://bugs.webkit.org/show_bug.cgi?id=209002
<rdar://problem/59682658>
Reviewed by Geoffrey Garen.
- WebProcess/WebProcess.messages.in:
- 10:56 AM Changeset in webkit [258339] by
-
- 32 edits in trunk/Source
Source/WebCore:
FrameLoader should own its FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=208918
Reviewed by Geoffrey Garen.
Update Frame/FrameLoader constructors to get a UniqueRef<FrameLoaderClient>.
This makes the lifetime management much clearer and allows some WebKit1/WebKit2 clean-up.
Covered by existing tests.
- loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
- loader/EmptyFrameLoaderClient.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::initForSynthesizedDocument):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::setOpener):
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::willLoadMediaElementURL):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::setDocumentLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::clientRedirectCancelledOrFinished):
(WebCore::FrameLoader::clientRedirected):
(WebCore::FrameLoader::closeOldDataSources):
(WebCore::FrameLoader::willChangeTitle):
(WebCore::FrameLoader::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::didReachLayoutMilestone):
(WebCore::FrameLoader::didReachVisuallyNonEmptyState):
(WebCore::FrameLoader::frameLoadCompleted):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::userAgent const):
(WebCore::FrameLoader::dispatchOnloadEvents):
(WebCore::FrameLoader::detachViewsAndDocumentLoader):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
(WebCore::FrameLoader::loadDifferentDocumentItem):
(WebCore::FrameLoader::cancelledError const):
(WebCore::FrameLoader::blockedByContentBlockerError const):
(WebCore::FrameLoader::blockedError const):
(WebCore::FrameLoader::blockedByContentFilterError const):
(WebCore::FrameLoader::connectionProperties):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
(WebCore::FrameLoader::didChangeTitle):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
(WebCore::FrameLoader::completePageTransitionIfNeeded):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::create):
- page/Frame.h:
- page/Page.cpp:
(WebCore::Page::Page):
- page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
- page/PageConfiguration.h:
- workers/service/context/SWContextManager.cpp:
- workers/service/context/SWContextManager.h:
Source/WebKit:
FrameLoader should own its FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=208918
Reviewed by Geoffrey Garen.
Pass a UniqueRef to the PageConfiguration.
Update WebFrameLoaderClient according updated FrameLoaderClient interface.
WebFrame no longer needs to ref/unref itself to keep the loader client alive.
Update WebFrame construction to not need a static_cast at initialization of the main frame.
The ownership is now that a WebCore::FrameLoader owns a FrameLoaderClient who owns a WebFrame.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::tryLoadingSynchronouslyUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::~WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::webPageProxyID const):
(WebKit::WebFrameLoaderClient::pageID const):
(WebKit::WebFrameLoaderClient::frameID const):
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
(WebKit::WebFrameLoaderClient::dispatchDidDispatchOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::dispatchShow):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::applyToDocumentLoader):
(WebKit::WebFrameLoaderClient::allowsContentJavaScriptFromMostRecentNavigation const):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::willReplaceMultipartContent):
(WebKit::WebFrameLoaderClient::didReplaceMultipartContent):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::didDetectXSS):
(WebKit::WebFrameLoaderClient::cancelledError const):
(WebKit::WebFrameLoaderClient::blockedError const):
(WebKit::WebFrameLoaderClient::blockedByContentBlockerError const):
(WebKit::WebFrameLoaderClient::cannotShowURLError const):
(WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError const):
(WebKit::WebFrameLoaderClient::blockedByContentFilterError const):
(WebKit::WebFrameLoaderClient::cannotShowMIMETypeError const):
(WebKit::WebFrameLoaderClient::fileDoesNotExistError const):
(WebKit::WebFrameLoaderClient::pluginWillHandleLoadError const):
(WebKit::WebFrameLoaderClient::shouldFallBack const):
(WebKit::WebFrameLoaderClient::restoreViewState):
(WebKit::WebFrameLoaderClient::didFinishLoad):
(WebKit::WebFrameLoaderClient::userAgent const):
(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::webGLPolicyForURL const):
(WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL const):
(WebKit::WebFrameLoaderClient::objectContentType):
(WebKit::WebFrameLoaderClient::overrideMediaType const):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebFrameLoaderClient::willInjectUserScript):
(WebKit::WebFrameLoaderClient::willCacheResponse const):
(WebKit::WebFrameLoaderClient::createNetworkingContext):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::initWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::WebFrame):
(WebKit::WebFrame::frameLoaderClient const):
(WebKit::WebFrame::fromCoreFrame):
(WebKit::WebFrame::didReceivePolicyDecision):
- WebProcess/WebPage/WebFrame.h:
(WebKit::WebFrame::create):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_processDisplayName):
Source/WebKitLegacy/mac:
FrameLoader should own its FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=208918
Reviewed by Geoffrey Garen.
Update according new Frame/FrameLoader constructors and FrameLoaderClient interface.
- WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::setWebFrame):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::~WebFrameLoaderClient):
(WebFrameLoaderClient::cancelledError const):
(WebFrameLoaderClient::blockedError const):
(WebFrameLoaderClient::blockedByContentBlockerError const):
(WebFrameLoaderClient::cannotShowURLError const):
(WebFrameLoaderClient::interruptedForPolicyChangeError const):
(WebFrameLoaderClient::blockedByContentFilterError const):
(WebFrameLoaderClient::cannotShowMIMETypeError const):
(WebFrameLoaderClient::fileDoesNotExistError const):
(WebFrameLoaderClient::pluginWillHandleLoadError const):
(WebFrameLoaderClient::shouldFallBack const):
(WebFrameLoaderClient::userAgent const):
- WebView/WebFrame.mm:
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
(+[WebFrame _createMainFrameWithSimpleHTMLDocumentWithPage:frameView:style:]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKitLegacy/win:
Make sure a preflight fails if response headers are invalid
https://bugs.webkit.org/show_bug.cgi?id=208924
Reviewed by Geoffrey Garen.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::cancelledError const):
(WebFrameLoaderClient::blockedError const):
(WebFrameLoaderClient::blockedByContentBlockerError const):
(WebFrameLoaderClient::cannotShowURLError const):
(WebFrameLoaderClient::interruptedForPolicyChangeError const):
(WebFrameLoaderClient::cannotShowMIMETypeError const):
(WebFrameLoaderClient::fileDoesNotExistError const):
(WebFrameLoaderClient::pluginWillHandleLoadError const):
(WebFrameLoaderClient::shouldFallBack const):
(WebFrameLoaderClient::userAgent const):
(WebFrameLoaderClient::frameLoaderDestroyed): Deleted.
(WebFrameLoaderClient::cancelledError): Deleted.
(WebFrameLoaderClient::blockedError): Deleted.
(WebFrameLoaderClient::blockedByContentBlockerError): Deleted.
(WebFrameLoaderClient::cannotShowURLError): Deleted.
(WebFrameLoaderClient::interruptedForPolicyChangeError): Deleted.
(WebFrameLoaderClient::cannotShowMIMETypeError): Deleted.
(WebFrameLoaderClient::fileDoesNotExistError): Deleted.
(WebFrameLoaderClient::pluginWillHandleLoadError): Deleted.
(WebFrameLoaderClient::shouldFallBack): Deleted.
(WebFrameLoaderClient::userAgent): Deleted.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebFrame.cpp:
(WebFrame::createSubframeWithOwnerElement):
- 10:40 AM Changeset in webkit [258338] by
-
- 4 edits in trunk/Source/WebKit
Drop unused LogGlobalDiagnosticMessageWithValue IPC message
https://bugs.webkit.org/show_bug.cgi?id=208974
<rdar://problem/59682189>
Reviewed by Chris Dumez.
I added these messages for ITP, but we later switched to tracking network sessions
individually and no longer need this "global" message.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::logGlobalDiagnosticMessageWithValue): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- 10:10 AM Changeset in webkit [258337] by
-
- 11 edits in trunk/Source/WebKit
Networking process should kill the WebContent process if an invalid IPC message is received from it
https://bugs.webkit.org/show_bug.cgi?id=208999
Reviewed by Geoffrey Garen.
If the NetworkProcess receives a bad IPC from a WebProcess, it now sends an IPC to the UIProcess
asking for said WebProcess to be terminated.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
- Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageSynchronous):
(IPC::handleMessageSynchronousWantsConnection):
(IPC::handleMessageAsync):
I noticed when testing this patch that the decoder was sometimes not marked as invalid even though
decoding failed (verified this by not decoding enough data or decoding too much data). As a result,
the IPC message would get ignored but didReceiveInvalidMessage() would not get called. To address
this, I know mark the decoder as invalid anytime decoding fails, instead of asserting that it is
already invalid.
- Shared/ProcessTerminationReason.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::wkProcessTerminationReason):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::terminateWebProcess):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
- 10:09 AM Changeset in webkit [258336] by
-
- 6 edits2 adds in trunk
REGRESSION (r254054): finance.google.com watch list renders initially then disappears for 5+ seconds before reappearing
https://bugs.webkit.org/show_bug.cgi?id=208972
<rdar://problem/59727171>
Reviewed by Zalan Bujtas.
Source/WebCore:
After r254054 we could get a style change in which opacity was unchanged, but
hasAutoUsedZIndex() in the style changed (because Adjuster::adjustAnimatedStyle() can set it).
In this case we failed to trigger layout, which means that we failed to recompute visual
overflow when a layer changed from being self-painting to non-self-painting (which affects
visual overflow computation and has hasAutoUsedZIndex() as input). We'd thus fail to paint some
renderers because their visual overflow didn't intersect the paint dirty rect.
Fix by having RenderStyle::changeRequiresLayout() return true if hasAutoUsedZIndex() differs
between the styles. This has minimal performance impact; rareNonInheritedDataChangeRequiresLayout()
already returns true if opacity, filters and other stacking-context-affecting properties change.
Test: fast/overflow/animation-recompute-overflow.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
(WebCore::RenderBox::addLayoutOverflow):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout const):
LayoutTests:
Ref test, and some rebaselines where repaint order changed.
- css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
- fast/overflow/animation-recompute-overflow-expected.html: Added.
- fast/overflow/animation-recompute-overflow.html: Added.
- platform/ios/css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt:
- 9:32 AM Changeset in webkit [258335] by
-
- 4 edits in trunk/Source/WebKit
Remove unused GetWebCoreStatistics message
https://bugs.webkit.org/show_bug.cgi?id=209001
<rdar://problem/59682747>
Reviewed by Chris Dumez.
- WebProcess/WebProcess.cpp:
(WebKit::fromCountedSetToHashMap): Deleted.
(WebKit::getWebCoreMemoryCacheStatistics): Deleted.
(WebKit::WebProcess::getWebCoreStatistics): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 9:28 AM Changeset in webkit [258334] by
-
- 6 edits in trunk/Source/WebKit
WebPasteboardProxy::SetPasteboardBufferForType should validate its
sizeparameter
<https://webkit.org/b/208902>
<rdar://problem/60181117>
Reviewed by Chris Dumez.
- Platform/IPC/Connection.h:
(MESSAGE_CHECK_BASE):
- Define in terms of MESSAGE_CHECK_COMPLETION_BASE() with a no-op completion handler.
(MESSAGE_CHECK_COMPLETION_BASE):
- Rename from MESSAGE_CHECK_BASE() and add completion handler parameter.
- Platform/SharedMemory.h:
(WebKit::SharedMemory::Handle::size const): Add.
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(MESSAGE_CHECK):
- Define macro to use in WebPasteboardProxy::setPasteboardBufferForType().
- Undefine macro at end of source file due to unified sources.
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
- Add IPC::Connection& parameter after change to WebPasteboardProxy.messages.in. Use with MESSAGE_CHECK().
- Validate
sizeparameter using MESSAGE_CHECK(). Because SharedMemory::Handle::size() returns a size_t value, we do not need to checksize <= std::numeric_limits<size_t>::max(). - Add static_cast<size_t>() to size parameter to denote type change.
- UIProcess/WebPasteboardProxy.h:
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
- Add IPC::Connection& parameter after change to WebPasteboardProxy.messages.in.
- UIProcess/WebPasteboardProxy.messages.in:
(SetPasteboardBufferForType):
- Add 'WantsConnection' attribute to add IPC::Connection& parameter to WebPasteboardProxy::setPasteboardBufferForType().
- 9:19 AM Changeset in webkit [258333] by
-
- 4 edits in trunk
FocusController::setFocusedElement() should tell client of refocused element
https://bugs.webkit.org/show_bug.cgi?id=208880
Reviewed by Wenson Hsieh.
Source/WebCore:
If the specified new focus element is non-nullptr and is already focused then tell the client
that the element was re-focused so that it may update its input state, if needed. On iOS, this
lets the UI process evaluate again whether to start an input session (i.e. bring up the keyboard),
which may have been disallowed when the element was originally focused (say, it was programmatically
focused and there was no hardware keyboard attached).
- page/FocusController.cpp:
(WebCore::FocusController::setFocusedElement):
Tools:
Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
to start an input session. Currently, it does not even try.
- TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
(TEST):
- 8:47 AM Changeset in webkit [258332] by
-
- 1 copy in releases/WPE WebKit/webkit-2.28.0
WPE WebKit 2.28.0
- 8:47 AM Changeset in webkit [258331] by
-
- 4 edits in releases/WebKitGTK/webkit-2.28
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.28.0 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.28.0.
- 8:38 AM Changeset in webkit [258330] by
-
- 13 edits4 adds in trunk
Implement wildcard behavior for Cross-Origin-Expose-Headers
https://bugs.webkit.org/show_bug.cgi?id=208800
Patch by Rob Buis <rbuis@igalia.com> on 2020-03-12
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Update improved test results and add a test for testing
xhr and wildcard behavior for Cross-Origin-Expose-Headers behavior.
- web-platform-tests/fetch/api/cors/cors-expose-star.sub.any-expected.txt:
- web-platform-tests/fetch/api/cors/cors-expose-star.sub.any.worker-expected.txt:
- web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
- web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
- web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
- web-platform-tests/service-workers/service-worker/fetch-cors-exposed-header-names.https-expected.txt:
- web-platform-tests/xhr/cors-expose-star.sub.any-expected.txt: Added.
- web-platform-tests/xhr/cors-expose-star.sub.any.html: Added.
- web-platform-tests/xhr/cors-expose-star.sub.any.js: Added.
(sharedHeaders.string_appeared_here.async_test):
(string_appeared_here.async_test):
- web-platform-tests/xhr/resources/top.txt: Added.
Source/WebCore:
Implement wildcard behavior for Cross-Origin-Expose-Headers [1] while also
checking for credentials mode.
Test: imported/w3c/web-platform-tests/xhr/cors-expose-star.sub.any.html
[1] https://fetch.spec.whatwg.org/#ref-for-concept-response-cors-exposed-header-name-list%E2%91%A2
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::create):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::BodyLoader::start):
- Modules/fetch/FetchResponse.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didFinishLoading):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::filter):
(WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting):
- platform/network/ResourceResponseBase.h:
- 8:36 AM Changeset in webkit [258329] by
-
- 2 edits in trunk/Source/WebKit
Provide orientation to GPUProcess when it will start to capture
https://bugs.webkit.org/show_bug.cgi?id=208911
Reviewed by Eric Carlson.
Provide orientation to GPUProcess whenever starting to capture.
This fixes the case of spinning the GPUProcess/starting capture in landscape mode.
Do not send orientation to GPUProcess if it is not yet started as an optimization.
Manually tested.
- UIProcess/WebPageProxy.cpp:
- 8:25 AM Changeset in webkit [258328] by
-
- 2 edits in trunk/Tools
[GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=208970
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-03-12
Reviewed by Daniel Bates.
Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
#!/usr/bin/env python.
#!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
probably has similar rules.
Note this is the only script that attempts to use /usr/bin/python in tarball builds.
Everything else that does so is probably only used by webkit-build.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
- gtkdoc/generate-gtkdoc:
- 8:17 AM Changeset in webkit [258327] by
-
- 7 edits1 delete in trunk/Source/WebKit
Remove TextTrackPrivateRemote.messages.in
https://bugs.webkit.org/show_bug.cgi?id=208935
Reviewed by Don Olmstead.
No new tests, no functional change.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/media/TextTrackPrivateRemote.messages.in: Removed.
- 8:14 AM Changeset in webkit [258326] by
-
- 3 edits in trunk/Source/WebCore
Remove no longer used code in LibWebRTCMediaEndpoint to handle remote streams
https://bugs.webkit.org/show_bug.cgi?id=208919
Reviewed by Eric Carlson.
These stream APIs are legacy now and not useful anymore.
Stop implementing the corresponding callbacks and remove related code.
Coverd by existing tests.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream): Deleted.
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack): Deleted.
(WebCore::LibWebRTCMediaEndpoint::OnAddStream): Deleted.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- 7:09 AM Changeset in webkit [258325] by
-
- 3 edits in trunk/Source/WebCore
[Curl] sort out MS vs Seconds confusion in Cookies
https://bugs.webkit.org/show_bug.cgi?id=208964
Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2020-03-12
Reviewed by Don Olmstead.
Making sure curl parser is storing expires using millis in the code. Using consistent time
functions around the changed code.
- platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::searchCookies):
(WebCore::CookieJarDB::getAllCookies):
(WebCore::CookieJarDB::setCookie):
- platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::parseExpiresMS):
(WebCore::CookieUtil::parseCookieAttributes):
- 7:05 AM Changeset in webkit [258324] by
-
- 18 edits in trunk/Source
Move AudioSession interruption listener code to AudioSession
https://bugs.webkit.org/show_bug.cgi?id=208714
Reviewed by Jer Noble.
Source/WebCore:
Move AudioSession interruption detection code from MediaSessionManagerIOS helper to AudioSessionIOS.
Add interruption observer capabilities to AudioSession and make MediaSessionManagerIOS an observer of it.
Manually tested.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::addInterruptionObserver):
(WebCore::AudioSession::removeInterruptionObserver):
(WebCore::AudioSession::beginInterruption):
(WebCore::AudioSession::endInterruption):
- platform/audio/AudioSession.h:
- platform/audio/ios/AudioSessionIOS.mm:
(-[WebInterruptionObserverHelper initWithCallback:]):
(-[WebInterruptionObserverHelper dealloc]):
(-[WebInterruptionObserverHelper clearCallback]):
(-[WebInterruptionObserverHelper interruption:]):
(WebCore::AudioSessionPrivate::AudioSessionPrivate):
(WebCore::AudioSessionPrivate::~AudioSessionPrivate):
(WebCore::AudioSession::addInterruptionObserver):
(WebCore::AudioSession::removeInterruptionObserver):
(WebCore::AudioSession::beginInterruption):
(WebCore::AudioSession::endInterruption):
- platform/audio/ios/MediaSessionHelperIOS.h:
- platform/audio/ios/MediaSessionHelperIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
- platform/audio/ios/MediaSessionManagerIOS.h:
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::providePresentingApplicationPIDIfNecessary):
Source/WebKit:
Make RemoteAudioSessionProxyManager an observer for AudioSession interruptions.
When being interrupted, notify all WebProcesses and trigger begin/end interruption mechanisms.
We only send interruption to sessions that are active in RemoteAudioSessionProxyManager.
Minor refactorting to move manager proxies from a map to a weak hash set.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::audioSessionProxy):
- GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::setCategory):
(WebKit::RemoteAudioSessionProxy::setPreferredBufferSize):
(WebKit::RemoteAudioSessionProxy::tryToSetActive):
- GPUProcess/media/RemoteAudioSessionProxyManager.cpp:
(WebKit::RemoteAudioSessionProxyManager::RemoteAudioSessionProxyManager):
(WebKit::RemoteAudioSessionProxyManager::~RemoteAudioSessionProxyManager):
(WebKit::RemoteAudioSessionProxyManager::addProxy):
(WebKit::RemoteAudioSessionProxyManager::removeProxy):
(WebKit::RemoteAudioSessionProxyManager::setCategoryForProcess):
(WebKit::RemoteAudioSessionProxyManager::setPreferredBufferSizeForProcess):
(WebKit::RemoteAudioSessionProxyManager::tryToSetActiveForProcess):
(WebKit::RemoteAudioSessionProxyManager::beginAudioSessionInterruption):
(WebKit::RemoteAudioSessionProxyManager::endAudioSessionInterruption):
- GPUProcess/media/RemoteAudioSessionProxyManager.h:
- GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp:
- GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h:
- WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp:
- WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h:
- WebProcess/GPU/media/ios/RemoteMediaSessionHelper.messages.in:
- 6:55 AM Changeset in webkit [258323] by
-
- 2 edits in trunk/Source/WebKit
[GPUP] Use standard int type in RemoteMediaPlayerState
https://bugs.webkit.org/show_bug.cgi?id=208962
Reviewed by Eric Carlson.
An unsigned long long is at least 64-bits so use uint64_t instead. This issue
was found when compiling out the GPU Process. No specialization of unsigned long
long was found which resulted in errors. This appears to be a non-Cocoa problem.
- WebProcess/GPU/media/RemoteMediaPlayerState.h:
(WebKit::RemoteMediaPlayerState::decode):
- 6:41 AM Changeset in webkit [258322] by
-
- 14 edits in trunk/Source/WebKit
GPUProcess should ensure UIProcess granted capture access to a WebProcess making a capture request
https://bugs.webkit.org/show_bug.cgi?id=208910
Reviewed by Eric Carlson.
When UIProcess receives a getUserMedia request, it will send to GPUProcess a notification of what is allowed.
GPUProcess stores for each connection to web process whether microphone, camera and/or display are allowed.
We do not disable access for a given process for now.
A future refactoring should probably streamline the implementation so that, in case capture happens in GPUProcess,
GPUProcess receives the getUserMedia request, asks permission to UIProcess and, upon granted permission, creates directly the sources.
Covered by existing tests.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::updateCaptureAccess):
- GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::allowsAudioCapture const):
(WebKit::GPUConnectionToWebProcess::allowsVideoCapture const):
(WebKit::GPUConnectionToWebProcess::allowsDisplayCapture const):
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::createGPUConnectionToWebProcess):
(WebKit::GPUProcess::updateCaptureAccess):
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updateCaptureAccess):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
- 6:30 AM Changeset in webkit [258321] by
-
- 12 edits14 adds in trunk
Accurate style invalidation for user action pseudo classes
https://bugs.webkit.org/show_bug.cgi?id=208859
<rdar://problem/55196888>
Reviewed by Zalan Bujtas.
Source/WebCore:
Currently :hover, :focus, :focus-within and :active lack fine grained invalidation using
rule sets like we do with class and attribute selectors.
This can be added easily following the same pattern.
Tests: fast/selectors/style-invalidation-hover-change-descendants.html
fast/selectors/style-invalidation-hover-change-siblings.html
fast/selectors/style-invalidation-focus-change-descendants.html
fast/selectors/style-invalidation-focus-change-siblings.html
fast/selectors/style-invalidation-focus-within-change-descendants.html
fast/selectors/style-invalidation-focus-within-change-siblings.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::setActive):
(WebCore::Element::setFocus):
(WebCore::Element::setHasFocusWithin):
(WebCore::Element::setHovered):
Use PseudoClassChangeInvalidation.
- dom/Element.h:
(WebCore::Element::setHasFocusWithin): Deleted.
- page/FrameViewLayoutContext.cpp:
(WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker):
- style/PseudoClassChangeInvalidation.cpp: Added.
(WebCore::Style::PseudoClassChangeInvalidation::computeInvalidation):
Compute invalidation rule set for a pseudo class change.
(WebCore::Style::PseudoClassChangeInvalidation::invalidateStyleWithRuleSets):
- style/PseudoClassChangeInvalidation.h: Added.
(WebCore::Style::PseudoClassChangeInvalidation::PseudoClassChangeInvalidation):
(WebCore::Style::PseudoClassChangeInvalidation::~PseudoClassChangeInvalidation):
- style/RuleFeature.cpp:
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
(WebCore::Style::RuleFeatureSet::collectFeatures):
Collect pseudo class features, similar to classes/attributes.
(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
(WebCore::Style::RuleFeatureSet::shrinkToFit):
- style/RuleFeature.h:
- style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::collectFeatures const):
(WebCore::Style::ensureInvalidationRuleSets):
Make more generic to allow enum key.
(WebCore::Style::ScopeRuleSets::pseudoClassInvalidationRuleSets const):
Create pseudo class invalidation ruleset.
- style/StyleScopeRuleSets.h:
LayoutTests:
- fast/selectors/style-invalidation-focus-change-descendants-expected.txt: Added.
- fast/selectors/style-invalidation-focus-change-descendants.html: Added.
- fast/selectors/style-invalidation-focus-change-siblings-expected.txt: Added.
- fast/selectors/style-invalidation-focus-change-siblings.html: Added.
- fast/selectors/style-invalidation-focus-within-change-descendants-expected.txt: Added.
- fast/selectors/style-invalidation-focus-within-change-descendants.html: Added.
- fast/selectors/style-invalidation-focus-within-change-siblings-expected.txt: Added.
- fast/selectors/style-invalidation-focus-within-change-siblings.html: Added.
- fast/selectors/style-invalidation-hover-change-descendants-expected.txt: Added.
- fast/selectors/style-invalidation-hover-change-descendants.html: Added.
- fast/selectors/style-invalidation-hover-change-siblings-expected.txt: Added.
- fast/selectors/style-invalidation-hover-change-siblings.html: Added.
- 3:39 AM Changeset in webkit [258320] by
-
- 4 edits in trunk/Source/WebKit
Drop unused EnableEnumeratingAllNetworkInterfaces / DisableEnumeratingAllNetworkInterfaces IPC messages
https://bugs.webkit.org/show_bug.cgi?id=208973
<rdar://problem/59683940>
Reviewed by Youenn Fablet.
Remove two unused IPC messages.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::disableEnumeratingAllNetworkInterfaces): Deleted.
(WebKit::WebPage::enableEnumeratingAllNetworkInterfaces): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:37 AM Changeset in webkit [258319] by
-
- 2 edits in trunk/LayoutTests
[WPE] Gardening, expected to fail but passed
https://bugs.webkit.org/show_bug.cgi?id=208987
Unreviewed gardening.
- platform/wpe/TestExpectations:
- 2:50 AM Changeset in webkit [258318] by
-
- 3 edits1 add in trunk/LayoutTests
[WPE] Gardening, update TestExpectations and baselines
https://bugs.webkit.org/show_bug.cgi?id=208986
Unreviewed gardening.
- platform/wpe/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-text-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-datalist-crash-expected.txt: Added.
- 1:10 AM Changeset in webkit [258317] by
-
- 8 edits in trunk
[GPU Process] GraphicsContextStateChange must accumulate fill and stroke fields as single properties
https://bugs.webkit.org/show_bug.cgi?id=208971
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-03-12
Reviewed by Simon Fraser.
Source/WebCore:
Setting the fill or the stroke should set one field: color, gradient or
pattern. When detecting a change any of them, accumulate() should copy
all of the fields from the source state to the destination state.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContextStateChange::accumulate):
- platform/graphics/GraphicsContext.h:
LayoutTests:
Adjust the change-flags values in the displaylists tests since the first
bit was not used.
- displaylists/canvas-display-list-expected.txt:
- displaylists/extent-includes-shadow-expected.txt:
- displaylists/extent-includes-transforms-expected.txt:
- displaylists/layer-dispay-list-expected.txt:
- 12:48 AM Changeset in webkit [258316] by
-
- 18 edits2 copies1 add in trunk/Source/WebCore
AnimationTimeline should not have multiple HashMaps with raw Element* keys
https://bugs.webkit.org/show_bug.cgi?id=208079
<rdar://problem/59687906>
Reviewed by Ryosuke Niwa.
We introduce a new ElementAnimationRareData class that holds the KeyframeEffectStack previously owned by ElementRareData as well as a few maps and lists
owned by AnimationTimeline which would use raw Element pointers as keys. Specifically, this is what changed:
- AnimationTimeline::m_elementToRunningCSSTransitionByCSSPropertyID → ElementAnimationRareData::runningTransitionByProperty()
- AnimationTimeline::m_elementToCompletedCSSTransitionByCSSPropertyID → ElementAnimationRareData::completedTransitionByProperty()
- AnimationTimeline::m_elementToCSSAnimationsCreatedByMarkupMap → ElementAnimationRareData::animationsCreatedByMarkup()
- AnimationTimeline::m_elementToCSSTransitionsMap → ElementAnimationRareData::transitions()
- AnimationTimeline::m_elementToCSSAnimationsMap → ElementAnimationRareData::cssAnimations()
- AnimationTimeline::m_elementToAnimationsMap → ElementAnimationRareData::webAnimations()
For convenience, these new members are exposed via Element directly.
No change in behavior, so no new tests.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/AnimationPlaybackEventInit.h:
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::removeCSSTransitionFromMap):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement):
(WebCore::AnimationTimeline::animationsForElement const):
(WebCore::AnimationTimeline::removeCSSAnimationCreatedByMarkup):
(WebCore::AnimationTimeline::willDestroyRendererForElement):
(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::updateCSSAnimationsForElement):
(WebCore::propertyInStyleMatchesValueForTransitionInMap):
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
(WebCore::removeAnimationFromMapForElement): Deleted.
(WebCore::AnimationTimeline::ensureRunningTransitionsByProperty): Deleted.
- animation/AnimationTimeline.h:
- animation/ComputedEffectTiming.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::transitionDidComplete):
- animation/ElementAnimationRareData.cpp: Copied from Source/WebCore/animation/ComputedEffectTiming.h.
(WebCore::ElementAnimationRareData::ElementAnimationRareData):
(WebCore::ElementAnimationRareData::~ElementAnimationRareData):
(WebCore::ElementAnimationRareData::ensureKeyframeEffectStack):
- animation/ElementAnimationRareData.h: Added.
(WebCore::ElementAnimationRareData::keyframeEffectStack):
(WebCore::ElementAnimationRareData::webAnimations):
(WebCore::ElementAnimationRareData::cssAnimations):
(WebCore::ElementAnimationRareData::transitions):
(WebCore::ElementAnimationRareData::animationsCreatedByMarkup):
(WebCore::ElementAnimationRareData::setAnimationsCreatedByMarkup):
(WebCore::ElementAnimationRareData::completedTransitionByProperty):
(WebCore::ElementAnimationRareData::runningTransitionsByProperty):
- animation/KeyframeEffect.h:
- animation/OptionalEffectTiming.h:
- animation/WebAnimation.h:
- animation/WebAnimationTypes.h: Copied from Source/WebCore/animation/WebAnimationUtilities.h.
(WebCore::WebAnimationsMarkableDoubleTraits::isEmptyValue):
(WebCore::WebAnimationsMarkableDoubleTraits::emptyValue):
- animation/WebAnimationUtilities.h:
(WebCore::WebAnimationsMarkableDoubleTraits::isEmptyValue): Deleted.
(WebCore::WebAnimationsMarkableDoubleTraits::emptyValue): Deleted.
- dom/Element.cpp:
(WebCore::Element::animationRareData const):
(WebCore::Element::ensureAnimationRareData):
(WebCore::Element::keyframeEffectStack const):
(WebCore::Element::ensureKeyframeEffectStack):
(WebCore::Element::hasKeyframeEffects const):
(WebCore::Element::webAnimations):
(WebCore::Element::cssAnimations):
(WebCore::Element::transitions):
(WebCore::Element::animationsCreatedByMarkup):
(WebCore::Element::setAnimationsCreatedByMarkup):
(WebCore::Element::completedTransitionByProperty):
(WebCore::Element::runningTransitionsByProperty):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::elementAnimationRareData):
(WebCore::ElementRareData::useTypes const):
(WebCore::ElementRareData::ensureAnimationRareData):
(WebCore::ElementRareData::keyframeEffectStack): Deleted.
(WebCore::ElementRareData::setKeyframeEffectStack): Deleted.
- dom/Node.cpp:
(WebCore::stringForRareDataUseType):
- dom/NodeRareData.h:
- 12:08 AM Changeset in webkit [258315] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening, update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=208977
Unreviewed gardening.
- platform/gtk/TestExpectations:
