Timeline



Jun 14, 2020:

10:56 PM Changeset in webkit [263018] by svillar@igalia.com
  • 7 edits in trunk

Unreviewed, reverting r262124.

Twitter videos go blank after exiting fullscreen

Reverted changeset:

"[css-flex] Allow indefinite size flex items to be definite
wrt resolving percentages inside them"
​https://bugs.webkit.org/show_bug.cgi?id=212264
​https://trac.webkit.org/changeset/262124

7:07 PM Changeset in webkit [263017] by weinig@apple.com
  • 31 edits
    2 copies
    1 add
    1 delete in trunk

[WPT] html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray.html fails due to lack of caching of Plugin objects
​https://bugs.webkit.org/show_bug.cgi?id=213185

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt:

Update results now that this test passes.

Source/WebCore:

Tests:

  • Updates results for web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray.html which now passes.
  • Splits up http/tests/plugins/plugin-javascript-access.html, adding http/tests/plugins/plugin-javascript-access-allow-all-plugins.html which tests the internals.setShowAllPlugins(true) case. This was required now that the plugin and mimetype arrays are immutable after creation.

Overhaul web exposed plugin APIs:

  • All DOMPlugin and DOMMimeTypes are now created together (along with the DOMPluginArray and DOMMimeTypeArray) on first access of either navigator.plugins or navigator.mimeTypes.
  • DOMPlugins are created and stored in the DOMPluginArray (fixing the initial lack of caching issue)
  • DOMMimeTypes are created and stored in the DOMMimeTypeArray.
  • DOMPlugins hold a strong reference to their associated DOMMimeType. The DOMMimeType has a weak reference back to the DOMPlugin. This means for a single executation context, we only ever create one DOMPlugin / DOMMimeType for each underlying plugin / mimetype.
  • Update GC so that DOMPlugin and DOMMimeType (in addition to DOMPluginArray and DOMMimeTypeArray which were already doing this) use navigator reachability for their lifetime. This is almost correct, except if we ever implement DOMPluginArray.refresh(false) to match the spec, in which case you could end up with some DOMPlugins and DOMMimeTypes that are marked as reachable when they really are not, but only plugins that were removed. This seems so unlikely to matter that implementing a more strict reachability function seems like the wrong way to go.
  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

Add NavigatorPlugins.idl

  • loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):
(WebCore::logPluginRequest):
Simplify and cleanup code making use of the new webVisibleMimeTypes() rather than the
clunky getWebVisibleMimesAndPluginIndices().

  • page/Navigator.cpp:
  • page/Navigator.h:

(WebCore::Navigator::initializePluginAndMIMETypeArrays):
(WebCore::Navigator::plugins):
(WebCore::Navigator::mimeTypes):
Fully initialize Navigator.plugins/mimeTypes on first access of either, following
the specified behavior that they should not change after initial access for a script
execution context. This also ensures we always return the same wrappers for these
objects on multiple accesses, something the spec mandates but we failed to do prior.
In addition, we now correctly sort the plugins by name and mimeTypes by type, also as
specified.

  • page/Navigator.idl:
  • page/NavigatorPlugins.idl: Added.

Split NavigatorPlugins out of Navigator.idl as specified. No functional change but
makes things nicer when we match the spec closer.

  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::suffixes const):
(WebCore::DOMMimeType::enabledPlugin const):

  • plugins/DOMMimeType.h:

(WebCore::DOMMimeType::create):
(WebCore::DOMMimeType::navigator):

  • plugins/DOMMimeType.idl:
  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::DOMMimeTypeArray):
(WebCore::DOMMimeTypeArray::length const):
(WebCore::DOMMimeTypeArray::item):
(WebCore::DOMMimeTypeArray::namedItem):
(WebCore::DOMMimeTypeArray::supportedPropertyNames):
(WebCore::DOMMimeTypeArray::getPluginData const): Deleted.

  • plugins/DOMMimeTypeArray.h:
  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):
(WebCore::DOMPlugin::supportedPropertyNames):

  • plugins/DOMPlugin.h:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::DOMPluginArray):
(WebCore::DOMPluginArray::length const):
(WebCore::DOMPluginArray::item):
(WebCore::DOMPluginArray::namedItem):
(WebCore::DOMPluginArray::supportedPropertyNames):
(WebCore::DOMPluginArray::pluginData const): Deleted.

  • plugins/DOMPluginArray.h:

Rather than dynamically accessing plugin information through Page
on each interaction with the DOM plugin objects, we now fully initialize
them on creation, allowing for correct wrapper caching and behavior if
plugins are added / removed (e.g. the arrays should not change).

  • plugins/PluginData.cpp:

(WebCore::PluginData::initPlugins):
(WebCore::PluginData::publiclyVisiblePluginsAndAdditionalWebVisiblePlugins const):
(WebCore::PluginData::webVisibleMimeTypes const):
(WebCore::supportsMimeTypeForPlugins):
(WebCore::PluginData::supportsMimeType const):
(WebCore::PluginData::supportsWebVisibleMimeType const):
(WebCore::PluginData::supportsWebVisibleMimeTypeForURL const):
(WebCore::PluginData::pluginFileForWebVisibleMimeType const):
(WebCore::PluginData::publiclyVisiblePlugins const): Deleted.
(WebCore::PluginData::getWebVisibleMimesAndPluginIndices const): Deleted.
(WebCore::PluginData::getMimesAndPluginIndices const): Deleted.
(WebCore::PluginData::getMimesAndPluginIndiciesForPlugins const): Deleted.
(WebCore::PluginData::getPluginInfoForWebVisibleMimeType const): Deleted.

  • plugins/PluginData.h:

Simplify interface by removing out parameter based getWebVisibleMimesAndPluginIndices
(and helpers) and adding more straigtword alternatives. getWebVisibleMimesAndPluginIndices
was useful for the old DOM plugin model, but now that the arrays are initialized all
together, it no longer provides an optimization. Instead, all callers really just want
a either a list of MimeClassInfos or to know if one is supported under a specific scenario,
so we now just expose that.

Source/WebKit:

  • UIProcess/Plugins/PluginInfoStore.h:

Add missing #include that is now needed due to pruning of unnecessary #includes
in WebCore.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::pluginSupportsExtension):
Update to use new webVisibleMimeTypes() rather than the clunky getWebVisibleMimesAndPluginIndices().

LayoutTests:

  • http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Added.
  • http/tests/plugins/plugin-javascript-access-allow-all-plugins.html: Added.
  • http/tests/plugins/plugin-javascript-access-expected.txt:
  • http/tests/plugins/plugin-javascript-access.html:

Split out internals.setShowAllPlugins(true) part of plugin-javascript-access.html to
allow the test to continue working now that navigator.plugins is immutable after
accessing it.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.

Remove imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray.html
from TestExpectations now that it passes all the time.

5:58 PM Changeset in webkit [263016] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit

[IPC hardening] Return type of -[NSCoder validateClassSupportsSecureCoding:] is incorrect
<​https://webkit.org/b/213161>
<rdar://problem/64050085>

Reviewed by Darin Adler.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(validateClass):

  • Fix return type of -[NSCoder validateClassSupportsSecureCoding:]. Throw an NSException in case the method ever returns NO without throwing its own NSException. (Currently this method does throw an NSException instead of returning NO.)
4:45 PM Changeset in webkit [263015] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-14
Reviewed by Geoffrey Garen.

Added a regression test.

  • fast/rendering/widget-removal-in-render-tree-builder-crash-expected.txt: Added.
  • fast/rendering/widget-removal-in-render-tree-builder-crash.html: Added.
4:06 PM Changeset in webkit [263014] by Wenson Hsieh
  • 2 edits in trunk/Tools

[iOS] Two KeyboardInputTests are failing on recent iOS SDK versions
​https://bugs.webkit.org/show_bug.cgi?id=213183
<rdar://problem/64273483>

Reviewed by Tim Horton.

On recent versions of the iOS SDK, iOS simulators that are not shown on-screen are treated as if the hardware
keyboard is not available (that is, +[UIIKeyboard isInHardwareKeyboardMode] returns NO). When running API
tests while Simulator.app is already launched, an iOS simulator is presented on-screen, whereas the simulator
is not visible when running API tests without launching Simulator.app beforehand.

This discrepancy causes two iOS API tests to fail (i.e. CaretSelectionRectAfterRestoringFirstResponder and
RangedSelectionRectAfterRestoringFirstResponder), due to the fact that -[WKWebView becomeFirstResponder] no
longer causes an input session to begin.

Interestingly, these tests already attempt to circumvent this by using webViewWithAutofocusedInput(), which
creates and loads a WKWebView with a single autofocusing input element, with a _WKInputDelegate that
unconditionally allows input sessions to begin. However, this doesn't work as intended in these tests, because
nothing keeps the delegate (a TestInputDelegate) alive past the scope of the call to
webViewWithAutofocusedInput(). Since [WKWebView _inputDelegate] is a weak property, the input delegate
simply disappears after we finish waiting for the load to finish (and the autofocused input element begins its
input session). This causes us to erroneously fall back to default behavior (i.e.
_WKFocusStartsInputSessionPolicyAuto) for subsequent calls to show the keyboard for the focused element, as is
the case when these two API tests call -becomeFirstResponder. The end result is that the keyboard doesn't
appear and text selection views are not created and laid out, but only when API tests are run without having
launched the Simulator app beforehand.

To fix this, refactor webViewWithAutofocusedInput() into webViewAndInputDelegateWithAutofocusedInput(),
which returns both the new WKWebView as well as the TestInputDelegate of the web view. The call site is then
responsible for keeping the input delegate around for as long as it needs.

  • TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(webViewWithAutofocusedInput):

Drive-by fix: fix a potential stack smasher by using an Objective-C block when setting the input delegate's
policy handler, and by using __block for the doneWaiting boolean flag. This is now a problem becuase this
block may be invoked multiple times.

(webViewAndInputDelegateWithAutofocusedInput):

1:27 PM Changeset in webkit [263013] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[AppleWin] Unreviewed test gardening

  • platform/win/TestExpectations: Marked fast/text/combining-character-sequence-vertical.html with ImageOnlyFailure.
11:57 AM Changeset in webkit [263012] by weinig@apple.com
  • 7 edits
    2 adds in trunk

[WPT] websockets/Close-reason-unpaired-surrogates.any.html fails due to failure to convert unpaired surrogates to replacement character for close reason
​https://bugs.webkit.org/show_bug.cgi?id=213182

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/websockets/Close-reason-unpaired-surrogates.any-expected.txt:
  • web-platform-tests/websockets/Close-reason-unpaired-surrogates.any.worker-expected.txt:
  • web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any-expected.txt: Added.
  • web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.worker-expected.txt: Added.

Update/add results now that these tests pass.

Source/WebCore:

Now passing the following tests:

imported/w3c/web-platform-tests/websockets/Close-reason-unpaired-surrogates.any.html
imported/w3c/web-platform-tests/websockets/Close-reason-unpaired-surrogates.any.worker.html
imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.html
imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.worker.html

  • Modules/websockets/WebSocket.idl:

Match spec (​https://html.spec.whatwg.org/multipage/web-sockets.html#the-websocket-interface)
by making the reason argument in close() a USVString rather than a DOMString. This causes
all unpaired surrogates to be replaced with \uFFFD, the replacement character.

LayoutTests:

Unskips the following tests which now pass all the time:

imported/w3c/web-platform-tests/websockets/Close-reason-unpaired-surrogates.any.worker.html
imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.html
imported/w3c/web-platform-tests/websockets/Secure-Close-Reason-Unpaired-surrogates.any.worker.html

11:55 AM Changeset in webkit [263011] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

Add wasm regresion test for loop
​https://bugs.webkit.org/show_bug.cgi?id=213176

Reviewed by Darin Adler.

This patch adds one more regression test for r246134.

  • wasm/regress/regression-with-loop.js: Added.
2:07 AM Changeset in webkit [263010] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[SOUP] Disable HSTS for requests when cookies will be blocked by ITP
​https://bugs.webkit.org/show_bug.cgi?id=210739

Reviewed by Michael Catanzaro.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::shouldAllowHSTSProtocolUpgrade const):

12:11 AM Changeset in webkit [263009] by commit-queue@webkit.org
  • 4 edits in trunk

Withdraw FileReaderSync from ServiceWorker
​https://bugs.webkit.org/show_bug.cgi?id=213136

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-14
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/historical.https-expected.txt:

Source/WebCore:

FileReaderSync is not exposed for ServiceWorker.

We does not support SharedWorker. We don't have to care about it.

  • fileapi/FileReaderSync.idl:

Jun 13, 2020:

11:34 PM Changeset in webkit [263008] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=213166
Rename executeIfJavaScriptURL to executeJavaScriptURL

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-13
Reviewed by Darin Adler.

Rename executeIfJavaScriptURL to executeJavaScriptURL in order to make the function
unconditional, i.e. the passed url is expected to have the javascript protocol, this
is asserted first thing in the method. This allows us to remove the return parameter
since the remaining return statements all return true.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeJavaScriptURL):
(WebCore::ScriptController::executeIfJavaScriptURL): Deleted.

  • bindings/js/ScriptController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::submitForm):

  • loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::requestFrame):

5:39 PM Changeset in webkit [263007] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][Floats] Floating positioned box is always a float avoider.
​https://bugs.webkit.org/show_bug.cgi?id=213162

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/layoutformattingcontext/inline-float-simple.html

  • layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isFloatAvoider const): also fix the independent formatting context case.

LayoutTests:

  • fast/layoutformattingcontext/inline-float-simple-expected.html: Added.
  • fast/layoutformattingcontext/inline-float-simple.html: Added.
1:40 PM Changeset in webkit [263006] by Devin Rousso
  • 12 edits
    1 add in trunk

Make errors an own property of AggregateError instead of a prototype accessor
​https://bugs.webkit.org/show_bug.cgi?id=212677

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/AggregateError-own-property-errors.js: Added.
  • test262/expectations.yaml:

Mark 9 tests as failing while waiting for test262 to update to match the spec.

Source/JavaScriptCore:

  • runtime/AggregateError.h:

(JSC::AggregateError::destroy): Deleted.
(JSC::AggregateError::subspaceFor): Deleted.
(JSC::AggregateError::errors): Deleted.

  • runtime/AggregateError.cpp:

(JSC::AggregateError::AggregateError):
(JSC::AggregateError::finishCreation): Added.
(JSC::AggregateError::visitChildren): Deleted.

  • runtime/AggregateErrorPrototype.h:
  • runtime/AggregateErrorPrototype.cpp:

(JSC::AggregateErrorPrototype::finishCreation):
(JSC::aggregateErrorPrototypeAccessorErrors): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::initializeAggregateErrorConstructor):

  • runtime/VM.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):
Remove aggregateErrorSpace since AggregateError doesn't add any new member variables.
Ensure that it can share an IsoSubspace with ErrorInstance.

  • runtime/CommonIdentifiers.h:

Add errors.

1:20 PM Changeset in webkit [263005] by sbarati@apple.com
  • 2 edits in trunk/Tools

compare-results should have an option to print a breakdown and to save the breakdown as csv file
​https://bugs.webkit.org/show_bug.cgi?id=213140

Reviewed by Filip Pizlo.

In this patch, compare-results has a new --breakdown feature which will
break down the results for -a and -b per subtest. It will also show you
p values with a significance threshold determined using the Bonferroni
correction for testing multiple hypotheses:
​https://en.wikipedia.org/wiki/Bonferroni_correction

And there is also now a --csv option to generate a csv file containing
the same per subtest breakdown.

--breakdown will print out results like:

| subtest | ms | ms | b / a | pValue, alpha = 0.003125 |

| Elm-TodoMVC |616.625000 |583.625000 |0.946483 | 0.065002 |
| VueJS-TodoMVC |89.425000 |83.225000 |0.930668 | 0.039102 |
| EmberJS-TodoMVC |695.875000 |664.000000 |0.954194 | 0.088901 |
| Flight-TodoMVC |263.600000 |257.600000 |0.977238 | 0.249259 |
| BackboneJS-TodoMVC |213.025000 |201.550000 |0.946133 | 0.000636 (significant) |
| Preact-TodoMVC |48.800000 |47.550000 |0.974385 | 0.502768 |
| AngularJS-TodoMVC |745.300000 |704.275000 |0.944955 | 0.011779 |
| Inferno-TodoMVC |607.900000 |354.800000 |0.583649 | 0.000000 (significant) |
| Vanilla-ES2015-TodoMVC |214.950000 |200.575000 |0.933124 | 0.005018 |
| Angular2-TypeScript-TodoMVC |191.575000 |187.025000 |0.976250 | 0.542229 |
| VanillaJS-TodoMVC |162.075000 |160.375000 |0.989511 | 0.747186 |
| jQuery-TodoMVC |855.275000 |833.825000 |0.974920 | 0.103439 |
| EmberJS-Debug-TodoMVC |2056.250000 |1952.050000 |0.949325 | 0.000003 (significant) |
| React-TodoMVC |475.225000 |428.950000 |0.902625 | 0.007566 |
| React-Redux-TodoMVC |791.100000 |736.675000 |0.931203 | 0.066091 |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |208.050000 |202.000000 |0.970920 | 0.152470 |

  • Scripts/compare-results:

(readJSONFile):
(speedometer2Breakdown):
(jetStream2Breakdown):
(motionMarkBreakdown):
(plt5Breakdown):
(displayStr):
(dumpBreakdowns):
(writeCSV):
(detectMotionMark1_1):
(detectMotionMark1_1_1):
(motionMarkResults):
(detectBenchmark):
(getOptions):
(main):
(motionMark1_1Results): Deleted.

12:06 PM Changeset in webkit [263004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Fix Overrelease in makeFailureSetForAllTextManipulationItems
​https://bugs.webkit.org/show_bug.cgi?id=213165
<rdar://problem/61389164>

Patch by Richard Houle <​rhoule@apple.com> on 2020-06-13
Reviewed by Wenson Hsieh.

  • UIProcess/API/Cocoa/WKWebView.mm:

(makeFailureSetForAllTextManipulationItems):

11:35 AM Changeset in webkit [263003] by weinig@apple.com
  • 9 edits in trunk

[WPT] dom/nodes/Document-createCDATASection-xhtml.xhtml fails due to missing exception in Document.createCDATASection()
​https://bugs.webkit.org/show_bug.cgi?id=213167

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Document-createCDATASection-xhtml-expected.txt:

Update results to show we are now passing all subtests.

Source/WebCore:

Tested by existing (formerly failing) test: imported/w3c/web-platform-tests/dom/nodes/Document-createCDATASection-xhtml.xhtml

Throw an "InvalidCharacterError" DOMException if the data passed to createCDATASection
contains the string "]]>" as specified by ​https://dom.spec.whatwg.org/#dom-document-createcdatasection

  • dom/Document.cpp:

(WebCore::Document::createCDATASection):

LayoutTests:

  • dom/xhtml/level3/core/documentnormalizedocument07-expected.txt:
  • dom/xhtml/level3/core/documentnormalizedocument08-expected.txt:
  • dom/xhtml/level3/core/handleerror01-expected.txt:
  • dom/xhtml/level3/core/splitcdatasections01-expected.txt:

Update expected results with new error now being thrown.

11:24 AM Changeset in webkit [263002] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Obsolete comment in FontCustomPlatformDataFreeType.cpp
​https://bugs.webkit.org/show_bug.cgi?id=213169

Unreviewed, remove the stale comment.

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-13

  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::defaultFontconfigOptions):

11:14 AM Changeset in webkit [263001] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[Mac Catalyst] Color inputs and selects fail to display popovers when clicked
​https://bugs.webkit.org/show_bug.cgi?id=213157
<rdar://problem/64004135>

Reviewed by Tim Horton.

In Mac Catalyst, presenting popovers using UIPopoverController causes the first responder to change. This
means that the WKContentView will resign first responder, which in turn causes the currently presented popover
to be dismissed. This means that popovers for color inputs and select elements will be dismissed immediately
after presentation.

To mitigate this, adapt the approach taken in r259840 to WKColorPopover and WKSelectPopover by teaching the
base class (WKRotatingPopover) to temporarily preserve the focused element in light of first responder changes
while presenting a popover on Mac Catalyst.

  • UIProcess/ios/forms/WKFormPopover.mm:

(-[WKRotatingPopover presentPopoverAnimated:]):
(-[WKRotatingPopover dismissPopoverAnimated:]):

9:42 AM Changeset in webkit [263000] by weinig@apple.com
  • 33 edits
    1 add in trunk

Extended Color: Experiment with strongly typed ColorComponents
​https://bugs.webkit.org/show_bug.cgi?id=212396

Reviewed by Darin Adler.

Source/WebCore:

Adds simple explicit types for sRGBA, LinearSRGBA, DisplayP3,
LinearDisplayP3, XYZA and HSLA colors. Conversion to/from
ColorComponents<float> is easy but explicit to make conversions
easier to spot.

The goal is to add type clarity (you know when you are dealing
with an sRGB color vs. a DisplayP3 color) and make dealing with
the colors nicer (color.red rather than color[0]). It also allows
us to simplify the naming of functions that convert between color
types as now only the output type needs to be in the function name.

  • Headers.cmake:

Add new header, ColorTypes.h

  • WebCore.xcodeproj/project.pbxproj:

Add new header, ColorTypes.h

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
Switch from hslToSRGB({ ... }) to toSRGBA(HSLAColor { ... })

  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):
Update to use toHSLA() and HSLA<float> making the code a bit more readable.

  • platform/graphics/Color.cpp:

(WebCore::Color::lightened const):
(WebCore::Color::darkened const):
(WebCore::Color::isDark const):
(WebCore::Color::lightness const):
(WebCore::Color::luminance const):
(WebCore::Color::colorSpaceAndComponents const):
(WebCore::Color::toSRGBASimpleColorLossy const):
(WebCore::Color::toSRGBALossy const):
(WebCore::Color::toSRGBAComponentsLossy const): Deleted.

  • platform/graphics/Color.h:

Renames toSRGBAComponentsLossy() to toSRGBALossy() which now returns
a SRGBA<float>.

  • platform/graphics/ColorMatrix.h:

(WebCore::ColorMatrix::transformColorComponents const): Deleted.
Remove transformColorComponents, keeping just transformedColorComponents
to simplify the interface. With late conversion to ColorComponents, the
latter is more straightforward to use in most cases anyway.

  • platform/graphics/ColorUtilities.cpp:

(WebCore::linearToRGBColorComponent):
(WebCore::rgbToLinearColorComponent):
(WebCore::toLinearSRGBA):
(WebCore::toSRGBA):
(WebCore::toLinearDisplayP3):
(WebCore::toDisplayP3):
(WebCore::toXYZ):
(WebCore::lightness):
(WebCore::luminance):
(WebCore::contrastRatio):
(WebCore::toHSLA):
(WebCore::premultiplied):
(WebCore::rgbToLinearComponents): Deleted.
(WebCore::linearToRGBComponents): Deleted.
(WebCore::xyzToLinearSRGB): Deleted.
(WebCore::linearSRGBToXYZ): Deleted.
(WebCore::XYZToLinearP3): Deleted.
(WebCore::linearP3ToXYZ): Deleted.
(WebCore::p3ToSRGB): Deleted.
(WebCore::sRGBToP3): Deleted.
(WebCore::sRGBToHSL): Deleted.
(WebCore::hslToSRGB): Deleted.

  • platform/graphics/ColorUtilities.h:

Rename / rework conversion and utility functions to operate on explicit Color
types. In doing so, simplify the names of the conversion functions so only name
the output type. For instance:

ColorComponents<float> p3ToSRGB(const ColorComponents<float>&);

is now

SRGBA<float> toSRGBA(const DisplayP3<float>&);

as the input type is implicit in the call. A little duplication was needed
for linearToRGBColorComponent/rgbToLinearColorComponent (as it was used for
both sRGB and DisplayP3 linearization), but mostly things stay the same.

  • platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::toSRGBALossy const):
(WebCore::ExtendedColor::toSRGBAComponentsLossy const): Deleted.

  • platform/graphics/ExtendedColor.h:

Renamed toSRGBAComponentsLossy() to toSRGBALossy() and have it
return a SRGBA<float>.

  • platform/graphics/SimpleColor.h:

(WebCore::SimpleColor::asSRGBA const):
(WebCore::makeSimpleColor):
(WebCore::SimpleColor::asSRGBFloatComponents const): Deleted.
Rename asSRGBFloatComponents() to asSRGBA<T>() and have it
return a SRGBA<float>. Replace makeSimpleColor taking FloatComponents
with one taking a SRGBA<float>, making it much clearer that this
is only valid for sRGB.

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):
Rework to support seperate types for SRGB<float> and LinearSRGBA<float>.

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::BasicColorMatrixFilterOperation::transformColor const):
(WebCore::BasicComponentTransferFilterOperation::transformColor const):
(WebCore::InvertLightnessFilterOperation::transformColor const):
(WebCore::InvertLightnessFilterOperation::inverseTransformColor const):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::transformColor const):
(WebCore::FilterOperation::inverseTransformColor const):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::transformColor const):
(WebCore::FilterOperations::inverseTransformColor const):
Use SRGBA<float> rather than ColorComponents<float> to make it clear
that the filters only work on sRGB colors right now.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

  • rendering/TextPaintStyle.cpp:

(WebCore::textColorIsLegibleAgainstBackgroundColor):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::setSourceRGBAFromColor):

  • platform/graphics/cairo/GradientCairo.cpp:

(WebCore::addColorStopRGBA):
(WebCore::setCornerColorRGBA):
(WebCore::interpolateColorStop):

  • platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::operator GdkRGBA const):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawNumber):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::clearColor):

  • platform/graphics/win/ColorDirect2D.cpp:

(WebCore::Color::operator D2D1_COLOR_F const):
(WebCore::Color::operator D2D1_VECTOR_4F const):

  • platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):

  • platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::colorWithGlobalAlpha const):
Update to call toSRGBALossy() rather than toSRGBAComponentsLossy().

Source/WebKit:

  • UIProcess/API/wpe/WebKitColor.cpp:

(webkitColorFillFromWebCoreColor):

  • UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::beginSwipeGesture):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::getDocumentBackgroundColor):
Update to call toSRGBALossy() rather than toSRGBAComponentsLossy().

Tools:

  • TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:

(TestWebKitAPI::TEST):
Update for changed names (e.g. toSRGBAComponentsLossy() -> toSRGBALossy())
and use of explicit types.

9:24 AM Changeset in webkit [262999] by commit-queue@webkit.org
  • 21 edits
    1 delete in trunk/Source

Remove FileError.h
​https://bugs.webkit.org/show_bug.cgi?id=213119

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-13
Reviewed by Chris Dumez.

Source/WebCore:

  • Headers.cmake:
  • Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::didFail):

  • Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::createMessageQueue):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):

  • Modules/websockets/WebSocketChannel.h:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/BlobLoader.h:

(WebCore::BlobLoader::didFail):

  • fileapi/FileError.h: Removed.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::didFail):

  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):
(WebCore::FileReaderLoader::cancel):
(WebCore::FileReaderLoader::cleanup):
(WebCore::FileReaderLoader::didReceiveResponse):
(WebCore::FileReaderLoader::didReceiveData):
(WebCore::FileReaderLoader::didFail):
(WebCore::FileReaderLoader::failed):
(WebCore::FileReaderLoader::toErrorCode):
(WebCore::FileReaderLoader::httpStatusCodeToErrorCode):
(WebCore::FileReaderLoader::arrayBufferResult const):
(WebCore::FileReaderLoader::stringResult):

  • fileapi/FileReaderLoader.h:

(WebCore::FileReaderLoader::errorCode const):

  • fileapi/FileReaderLoaderClient.h:
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSync::startLoading):

  • fileapi/FileReaderSync.h:
  • fileapi/NetworkSendQueue.cpp:

(WebCore::NetworkSendQueue::processMessages):

  • fileapi/NetworkSendQueue.h:
  • html/ImageBitmap.cpp:

Source/WebKit:

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::createMessageQueue):

1:43 AM Changeset in webkit [262998] by Diego Pino Garcia
  • 2 edits in trunk/Tools

Unreviewed, fix configuration setting of WPE Debug (Tests JS) bot
​https://bugs.webkit.org/show_bug.cgi?id=213164

The bot was meant to run as Debug.

  • BuildSlaveSupport/build.webkit.org-config/config.json:

Jun 12, 2020:

11:22 PM Changeset in webkit [262997] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Automation.computeElementLayout should return iframe-relative element rects (when coordinate system is 'Page')
​https://bugs.webkit.org/show_bug.cgi?id=213139
<rdar://problem/55042445>

Reviewed by Devin Rousso.

Automation.computeElementLayout has two coordinate systems it can use, LayoutViewport (used for hit testing)
and Page (used for Get Element Rect). Since Get Element Rect expects coordinates relative to the current
browsing context, make the mode simpler by reporting the bounds from Element::boundingClientRect() which
are frame-relative.

Covered by existing WPT suite. The semantics of this command are under review, as
the remote end steps seem to describe a different result than what the non-normative text does.

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):

11:13 PM Changeset in webkit [262996] by Simon Fraser
  • 11 edits
    2 adds in trunk

REGRESSION(r261985): Unable to respond to large comments on Bugzilla with always-on scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=213135
<rdar://problem/64302086>

Reviewed by Tim Horton.
Source/WebCore:

The combination of programmatic scrolls (e.g. anchor click, reveal selection) and user scrolling
could result in a mismatch between the main thread and scrolling thread scroll positions, resulting
in missing tiles and offset cursor handling.

This happened if a programmatic scroll occurred and 'scrolledSinceLastCommit' was true for
the equivalent scrolling node at the start of a rendering update. synchronizeStateFromScrollingTree()
would take the scrolling thread's notion of the scroll position, clobbering the position resulting
from the programmatic scroll.

To fix this, call commitTreeStateIfNeeded() before synchronizeStateFromScrollingTree() to ensure that
any programmatic scrolls have been pushed to the scrolling tree before we fetch its state.

Some infrastructure is needed for testing; getting into the state where a programmatic
scroll and 'scrolledSinceLastCommit' happened in the same event loop cycle required adding
internals.scrollBySimulatingWheelEvent(), which just pokes the scrolling tree directly
without the complexities of wheel events dispatched via the UI process.

Test: scrollingcoordinator/mac/reveal-selection-tile-coverage.html

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollBySimulatingWheelEventForTesting):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::scrollBySimulatingWheelEventForTesting):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollBySimulatingWheelEventForTesting):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::willStartRenderingUpdate):

  • testing/Internals.cpp:

(WebCore::Internals::scrollBySimulatingWheelEvent):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Test that does a fake user scroll then a programmatic scroll from a timer (i.e. outside
the rendering update), then dumps tile caches to check that coverage rects match the
right scroll position.

  • scrollingcoordinator/mac/reveal-selection-tile-coverage-expected.txt: Added.
  • scrollingcoordinator/mac/reveal-selection-tile-coverage.html: Added.
8:09 PM Changeset in webkit [262995] by rmorisset@apple.com
  • 4 edits
    1 add in trunk
The
operator (and similar ones) should produce valid bytecode even if the right side is a static error

​https://bugs.webkit.org/show_bug.cgi?id=213154

Reviewed by Devin Rousso.

JSTests:

  • stress/bytecode-for-rmw-with-invalid-right-side.js: Added.

(catch):

Source/JavaScriptCore:

There were two minor issues here that interacted:

  • emitThrowReferenceError did not take an optional dst argument like everything else, and instead always returned a new temporary. As a result, the various functions that sometimes did "return emitThrowReferenceError(..);" could return a different RegisterID than the one provided to them through dst, breaking the invariant stated at the top of the file.
  • ShortCircuitReadModifyResolveNode::emitBytecode used the result of such a function, unnecessarily, and (correctly) relied on the invariant being upheld.

The combination of these led to the bytecode trying to do a move of a temporary that was only defined in one of the predecessors of the basic block it was on,
which was caught by validateBytecode.

I fixed both issues, and verified that either fix is enough to stop the bug.
I fixed the first because other code may depend on that invariant in more subtle ways.
I fixed the second because it was just unnecessary complexity and made the code misleading.

I also reworded the comment at the top of NodesCodegen.cpp based on Keith's explanation and Mark's advice to make it less cryptic.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowReferenceError):
(JSC::PostfixNode::emitBytecode):
(JSC::DeleteBracketNode::emitBytecode):
(JSC::DeleteDotNode::emitBytecode):
(JSC::PrefixNode::emitBytecode):
(JSC::ShortCircuitReadModifyResolveNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):

  • parser/Nodes.h:
7:55 PM Changeset in webkit [262994] by ddkilzer@apple.com
  • 74 edits in trunk/Source

[IPC hardening] Check enum values in IPC::Decoder::decodeEnum() an IPC::Encoder::encodeEnum()
<​https://webkit.org/b/211988>
<rdar://problem/63137695>

Reviewed by Darin Adler.

Replace decodeEnum() with decode() and encodeEnum() with
operator<<().

Source/ThirdParty/libwebrtc:

  • Source/webrtc/sdk/WebKit/WebKitEncoder.h:

(webrtc::WebKitEncodedFrameInfo::decode):
(webrtc::WebKitEncodedFrameInfo::encode const):

Source/WebCore:

  • Modules/applicationmanifest/ApplicationManifest.h:

(WebCore::ApplicationManifest::decode):

  • Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::encode const):
(WebCore::IDBKeyData::decode):

  • Modules/indexeddb/shared/IDBCursorInfo.h:

(WebCore::IDBCursorInfo::encode const):
(WebCore::IDBCursorInfo::decode):

  • Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::encode const):
(WebCore::IDBError::decode):

  • Modules/indexeddb/shared/IDBGetAllRecordsData.h:

(WebCore::IDBGetAllRecordsData::encode const):
(WebCore::IDBGetAllRecordsData::decode):

  • Modules/indexeddb/shared/IDBGetRecordData.h:

(WebCore::IDBGetRecordData::encode const):
(WebCore::IDBGetRecordData::decode):

  • Modules/indexeddb/shared/IDBIterateCursorData.h:

(WebCore::IDBIterateCursorData::encode const):
(WebCore::IDBIterateCursorData::decode):

  • Modules/indexeddb/shared/IDBRequestData.h:

(WebCore::IDBRequestData::encode const):
(WebCore::IDBRequestData::decode):

  • Modules/indexeddb/shared/IDBResultData.h:

(WebCore::IDBResultData::encode const):
(WebCore::IDBResultData::decode):

  • Modules/indexeddb/shared/IDBTransactionInfo.h:

(WebCore::IDBTransactionInfo::encode const):
(WebCore::IDBTransactionInfo::decode):

  • Modules/webauthn/PublicKeyCredentialCreationOptions.h:

(WebCore::PublicKeyCredentialCreationOptions::Parameters::decode):
(WebCore::PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::decode):

  • Modules/webauthn/PublicKeyCredentialDescriptor.h:

(WebCore::PublicKeyCredentialDescriptor::decode):

  • dom/ExceptionData.h:

(WebCore::ExceptionData::encode const):
(WebCore::ExceptionData::decode):

  • html/DataListSuggestionInformation.h:

(WebCore::DataListSuggestionInformation::encode const):
(WebCore::DataListSuggestionInformation::decode):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::encode const):
(WebCore::SecurityOrigin::decode):

  • platform/ContextMenuItem.h:

(WTF::EnumTraits<WebCore::ContextMenuAction>):

  • Add missing ContextMenuItemTagPasteAsPlainText that was added in r261800.
  • platform/LinkIcon.h:

(WebCore::LinkIcon::encode const):
(WebCore::LinkIcon::decode):

  • platform/PasteboardItemInfo.h:

(WebCore::PasteboardItemInfo::encode const):
(WebCore::PasteboardItemInfo::decode):

  • platform/ScreenProperties.h:

(WebCore::ScreenData::encode const):
(WebCore::ScreenData::decode):

  • platform/graphics/InbandGenericCue.h:

(WebCore::GenericCueData::encode const):

  • platform/graphics/Path.h:

(WebCore::Path::encode const):
(WebCore::Path::decode):

  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::SetState::encode const):
(WebCore::DisplayList::SetState::decode):
(WebCore::DisplayList::DrawTiledScaledImage::encode const):
(WebCore::DisplayList::DrawTiledScaledImage::decode):

  • platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::encode const):

  • platform/mediastream/MediaConstraints.h:

(WebCore::MediaConstraint::encode const):
(WebCore::MediaConstraint::decode):

  • platform/mediastream/MediaStreamRequest.h:

(WebCore::MediaStreamRequest::encode const):
(WebCore::MediaStreamRequest::decode):

  • platform/mediastream/RealtimeMediaSourceCapabilities.h:

(WebCore::CapabilityValueOrRange::encode const):
(WebCore::CapabilityValueOrRange::decode):
(WebCore::RealtimeMediaSourceCapabilities::encode const):
(WebCore::RealtimeMediaSourceCapabilities::decode):

  • platform/mediastream/RealtimeMediaSourceSettings.h:

(WebCore::RealtimeMediaSourceSettings::encode const):
(WebCore::RealtimeMediaSourceSettings::decode):

  • platform/mock/MockMediaDevice.h:

(WebCore::MockDisplayProperties::encode const):

  • platform/network/HTTPHeaderMap.h:

(WebCore::HTTPHeaderMap::CommonHeader::encode const):
(WebCore::HTTPHeaderMap::CommonHeader::decode):

  • testing/MockWebAuthenticationConfiguration.h:

(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):

  • workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::decode):

  • workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

Source/WebKit:

  • GPUProcess/media/TextTrackPrivateRemoteConfiguration.h:

(WebKit::TextTrackPrivateRemoteConfiguration::encode const):

  • GPUProcess/media/TrackPrivateRemoteConfiguration.h:

(WebKit::TrackPrivateRemoteConfiguration::encode const):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • Platform/IPC/Decoder.h:

(IPC::Decoder::decode):
(IPC::Decoder::operator>>):

  • Make use of std::underlying_type_t<>.

(IPC::Decoder::decodeEnum): Delete.

  • Replace with calls to decode().
  • Platform/IPC/Encoder.h:

(IPC::Encoder::operator<<):
(IPC::Encoder::encode):

  • Make use of WTF::enumToUnderlyingType<>.

(IPC::Encoder::encodeEnum): Delete.

  • Replace with calls to operator<<().
  • Shared/Cocoa/ArgumentCodersCocoa.mm:

(IPC::decodeObject):

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::encode const):
(WebKit::ContextMenuContextData::decode):

  • Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

  • Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::encode const):
(WebKit::PlatformPopupMenuData::decode):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode const):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode const):
(WebKit::PrintInfo::decode):

  • Shared/RTCPacketOptions.cpp:

(WebKit::RTCPacketOptions::encode const):
(WebKit::RTCPacketOptions::decode):

  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateNode>::encode):
(ArgumentCoder<RequestedScrollData>::encode):
(ArgumentCoder<RequestedScrollData>::decode):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):

  • Shared/SessionState.cpp:

(WebKit::HTTPBody::Element::encode const):
(WebKit::HTTPBody::Element::decode):
(WebKit::PageState::encode const):
(WebKit::PageState::decode):

  • Shared/TouchBarMenuItemData.cpp:

(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::encode const):
(WebKit::WebContextMenuItemData::decode):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<LinearTimingFunction>::encode):
(IPC::ArgumentCoder<CubicBezierTimingFunction>::encode):
(IPC::ArgumentCoder<CubicBezierTimingFunction>::decode):
(IPC::ArgumentCoder<StepsTimingFunction>::encode):
(IPC::ArgumentCoder<SpringTimingFunction>::encode):
(IPC::ArgumentCoder<PluginInfo>::encode):
(IPC::ArgumentCoder<PluginInfo>::decode):
(IPC::ArgumentCoder<ProtectionSpace>::encode):
(IPC::ArgumentCoder<ProtectionSpace>::decode):
(IPC::ArgumentCoder<Credential>::encode):
(IPC::ArgumentCoder<Credential>::decode):
(IPC::ArgumentCoder<Cursor>::encode):
(IPC::ArgumentCoder<Cursor>::decode):
(IPC::ArgumentCoder<ResourceError>::encode):
(IPC::ArgumentCoder<ResourceError>::decode):
(IPC::ArgumentCoder<DragData>::encode):
(IPC::ArgumentCoder<DragData>::decode):
(IPC::ArgumentCoder<CompositionUnderline>::encode):
(IPC::ArgumentCoder<CompositionUnderline>::decode):
(IPC::ArgumentCoder<FileChooserSettings>::encode):
(IPC::ArgumentCoder<FileChooserSettings>::decode):
(IPC::ArgumentCoder<TextCheckingRequestData>::encode):
(IPC::ArgumentCoder<TextCheckingRequestData>::decode):
(IPC::ArgumentCoder<TextCheckingResult>::encode):
(IPC::ArgumentCoder<TextCheckingResult>::decode):
(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::decode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::decode):
(IPC::ArgumentCoder<FilterOperation>::encode):
(IPC::decodeFilterOperation):
(IPC::ArgumentCoder<FontAttributes>::encode):
(IPC::ArgumentCoder<FontAttributes>::decode):
(IPC::ArgumentCoder<WebCore::SerializedPlatformDataCueValue>::encode):
(IPC::ArgumentCoder<WebCore::SerializedPlatformDataCueValue>::decode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::encode const):
(WebKit::WebPopupItem::decode):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::Entry::encode const):
(WebKit::WebsiteData::Entry::decode):

  • Shared/curl/WebCoreArgumentCodersCurl.cpp:

(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData):

  • Shared/glib/InputMethodState.cpp:

(WebKit::InputMethodState::encode const):
(WebKit::InputMethodState::decode):

  • Shared/glib/UserMessage.cpp:

(WebKit::UserMessage::encode const):
(WebKit::UserMessage::decode):

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::encode const):
(WebKit::ColorSpaceData::decode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::encode const):
(WebKit::SecItemRequestData::decode):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::ResourceRequest>::decodePlatformData):
(IPC::ArgumentCoder<WebCore::CertificateInfo>::encode):
(IPC::ArgumentCoder<WebCore::CertificateInfo>::decode):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<SoupNetworkProxySettings>::encode):
(IPC::ArgumentCoder<SoupNetworkProxySettings>::decode):

  • WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

  • WebProcess/Network/NetworkProcessConnectionInfo.h:

(WebKit::NetworkProcessConnectionInfo::decode):

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::encode const):
(WebKit::Plugin::Parameters::decode):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::KeyframeValue::encode const):
(WebKit::PlatformCAAnimationRemote::KeyframeValue::decode):
(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):

7:01 PM Changeset in webkit [262993] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

[iPadOS] Focusing selects and color inputs should not bring up the software keyboard
​https://bugs.webkit.org/show_bug.cgi?id=213149
<rdar://problem/64312450>

Reviewed by Darin Adler.

Source/WebKit:

After <trac.webkit.org/r261658>, we now opt into bringing up the software keyboard when focusing color inputs
and select elements. This is due to the changes in -_shouldShowAutomaticKeyboardUIIgnoringInputMode, which
were intended to make us return NO for date and time inputs, but also unintentionally makes us return YES
on iPadOS.

This patch fixes the bug by returning !WebKit::currentUserInterfaceIdiomIsPad() instead, and additionally
preserves the existing behavior of now showing a color picker for <input type="color" readonly> on iPhone.

Test: fast/forms/ios/ipad/select-should-not-bring-up-software-keyboard.html

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView becomeFirstResponderForWebView]):
(-[WKContentView resignFirstResponderForWebView]):
(-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):

LayoutTests:

Add a new layout test.

  • fast/forms/ios/ipad/select-should-not-bring-up-software-keyboard-expected.txt: Added.
  • fast/forms/ios/ipad/select-should-not-bring-up-software-keyboard.html: Added.
6:15 PM Changeset in webkit [262992] by ysuzuki@apple.com
  • 3 edits
    1 add in trunk

[JSC] el(Greek) characters' upper-case conversion is locale-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=213155
<rdar://problem/55018467>

Reviewed by Darin Adler.

JSTests:

  • stress/intl-el-case.js: Added.

(shouldBe):

Source/JavaScriptCore:

CLDR defines 4 locales which has language-sensitive case conversions. "az", "el", "lt", and "tr", where,

az = Azerbaijani
el = Greek
lt = Lithuanian
tr = Turkish

We can ensure it easily like this.

  1. Download CLDR data
  2. ls common/transforms/*Upper.xml

common/transforms/az-Upper.xml
common/transforms/el-Upper.xml
common/transforms/lt-Upper.xml
common/transforms/tr-Upper.xml

And ECMA-402 String.prototype.{toLocaleLowerCase,toLocaleUpperCase} requires these locales are listed as availableLocales.

  1. Let availableLocales be a List with language tags that includes the languages for which the Unicode Character Database contains language sensitive case mappings. Implementations may add additional language tags if they support case mapping for additional locales.

​https://tc39.es/ecma402/#sup-string.prototype.tolocalelowercase

This patch adds "el" to our maintained availableLocales list. Previously we only had "az", "lt", and "tr".

  • runtime/StringPrototype.cpp:

(JSC::toLocaleCase):
(JSC::stringProtoFuncToLocaleUpperCase):

5:22 PM Changeset in webkit [262991] by keith_miller@apple.com
  • 17 edits
    1 delete in trunk

Tests expecting a crash should use a signal handler in the JSC CLI process
​https://bugs.webkit.org/show_bug.cgi?id=212479

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/ensure-crash.js:
  • stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition-debug.js:
  • stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition.js:
  • stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js: Removed.
  • stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js:
  • stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js:

Source/JavaScriptCore:

Have the -s option use WTF::Signals and make sure it adds breakpoint catching
as well.

  • jsc.cpp:

(printUsageStatement):
(CommandLine::parseArguments):

  • tools/SigillCrashAnalyzer.cpp:

(JSC::installCrashHandler):

Source/WTF:

Add signals for floating point exceptions and breakpoints. There's a
note for breakpoints that explains how using them in the same process
as lldb will cause badness. Fortunately, the only place I plan on using
the breakpoint handler is to check for tests where crashing is expected.

  • wtf/threads/Signals.cpp:

(WTF::fromMachException):
(WTF::toMachMask):

  • wtf/threads/Signals.h:

(WTF::toSystemSignal):
(WTF::fromSystemSignal):

Tools:

Crashing tests should now exit with status zero.

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb:
  • Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
  • Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
5:06 PM Changeset in webkit [262990] by Alan Coon
  • 5 edits in branches/safari-609-branch

Cherry-pick r262978. rdar://problem/64315997

Stop allowing pages served over HTTPS with "Cache-Control: no-store" into the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=213147
<rdar://problem/64249683>

Reviewed by Geoffrey Garen.

Source/WebCore:

Stop allowing pages served over HTTPS with "Cache-Control: no-store" into the back/forward cache.
This is a revert of r250437 due to push back from Web developers.

No new tests, updated existing tests.

  • history/BackForwardCache.cpp: (WebCore::canCacheFrame):

LayoutTests:

Update layout test coverage.

  • http/tests/navigation/https-in-page-cache-expected.txt:
  • http/tests/navigation/resources/https-in-page-cache-1.php:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:06 PM Changeset in webkit [262989] by Alan Coon
  • 5 edits
    1 add in branches/safari-609-branch

Cherry-pick r262707. rdar://problem/64226888

File URLs with hostnames are misleading
​https://bugs.webkit.org/show_bug.cgi?id=212739
<rdar://problem/63754917>

Reviewed by Alex Christensen.

Source/WebCore:

Showing a file URL like ​file://example.org/test is misleading to users.
To prevent this, we just do a redirection to the same file URL with an empty host.
Remove the port at the same time.
Covered by added API test.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/open-window-with-file-url-with-host.html: Added.
  • TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:06 PM Changeset in webkit [262988] by Alan Coon
  • 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r262508. rdar://problem/62977672

[iOS] Hide the PiP button in fullscreen mode if PiP is disabled in preferences
​https://bugs.webkit.org/show_bug.cgi?id=212699
<rdar://problem/60391437>

Reviewed by Eric Carlson.

In r260474, we hid the PiP button in fullscreen when PiP was unsupported on the
current device; we must also hide the PiP button when clients have disabled PiP
via preferences.

  • UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController videoControlsManagerDidChange]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:55 PM Changeset in webkit [262987] by Andres Gonzalez
  • 4 edits in trunk/LayoutTests

Re-write accessibility/form-control-value-settable.html so that it can pass in both isolated tree mode on and off.
​https://bugs.webkit.org/show_bug.cgi?id=213150

Reviewed by Chris Fleizach.

In isolated tree mode, it is necessary to setTimeout after setting the
focus so that the isolated tree can be updated.

  • accessibility/form-control-value-settable.html:
  • platform/gtk/accessibility/form-control-value-settable-expected.txt:
  • platform/mac/accessibility/form-control-value-settable-expected.txt:
4:45 PM Changeset in webkit [262986] by Alan Coon
  • 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-609.3.4

4:32 PM Changeset in webkit [262985] by achristensen@apple.com
  • 12 edits in trunk

Make API tests tolerant of our relatively new use of WebPageProxy::preconnectTo
​https://bugs.webkit.org/show_bug.cgi?id=213144

Reviewed by Geofferey Garen.

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::taskServerConnectionSucceeded):
(WebKit::NetworkSessionCocoa::taskReceivedBytes): Deleted.
Fix our logic that remembers successful client certificate connections.
If a task completes with no error (like a preconnect task does), consider that a successful connection.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::preconnectTo):
Remove the check to not preconnect to loopback addresses.
This was making our tests different than the real internet and prevented me from landing a perfectly good test
in ​https://bugs.webkit.org/show_bug.cgi?id=213109

Tools:

Most changes are straightforward moving to HTTPServer, which is more tolerant of different numbers of connections except these two:

The ResourceLoadDelegate.Challenge API test was checking the output of _WKResourceLoadDelegate.didReceiveChallenge
by using a server trust challenge. Now that preconnecting happens, the server trust evaluation would happen with a
PreconnectTask, not the main resource load. The WKNavigationDelegate still gets the challenge and there is no problem
here, but in order to continue to test _WKResourceLoadDelegate.didReceiveChallenge I use a basic authentication challenge
instead of a server trust evaluation.

The WebKit.FastServerTrust API test now has two failed attempts (one from the preconnect attempt, one from the main resource load attempt),
but only when _strictTrustEvaluate is not available.

  • TestWebKitAPI/TCPServer.cpp:

(TestWebKitAPI::TCPServer::TCPServer):

  • TestWebKitAPI/TCPServer.h:
  • TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(TEST):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • TestWebKitAPI/cocoa/HTTPServer.h:
  • TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):

3:38 PM Changeset in webkit [262984] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Preferences are not being observed if the process pool is being created after activation
​https://bugs.webkit.org/show_bug.cgi?id=213145

Reviewed by Brent Fulgham.

If the app is creating the Web process pool after being activated, preferences will not be observed until the app is being backgrounded
and then foregrounded again, since the preference observer is initialized when handling the app activation notification.

No new tests, since an API test would make sense in this case, but API tests aren't run on iOS.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

3:22 PM Changeset in webkit [262983] by Alan Coon
  • 8 edits in branches/safari-610.1.15.51-branch/Source

Versioning 610.1.15.51.4.

3:17 PM Changeset in webkit [262982] by Alan Coon
  • 1 copy in tags/Safari-610.1.15.51.3

Tag Safari-610.1.15.51.3.

3:16 PM Changeset in webkit [262981] by Alan Coon
  • 8 edits in branches/safari-610.1.15.51-branch/Source

Versioning.

3:15 PM Changeset in webkit [262980] by Alan Coon
  • 1 copy in tags/Safari-610.1.15.50.4

Tag Safari-610.1.15.50.4.

3:13 PM Changeset in webkit [262979] by Alexey Shvayka
  • 7 edits in trunk

AsyncGenerator should await "return" completions
​https://bugs.webkit.org/show_bug.cgi?id=212774

Reviewed by Ross Kirsling.

JSTests:

With this change, async generator stress tests now pass in Chrome and Firefox (tested manually).

  • stress/async-iteration-yield-star-interface.js:
  • stress/async-iteration-yield-star.js:
  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This patch fixes 2 spec discrepancies, observable with async generators if the
value of "return" completion is a Promise, aligning JSC with V8 and SpiderMonkey.

  • builtins/AsyncGeneratorPrototype.js:

(onFulfilled):
This change implements step 8 of AsyncGeneratorYield [1], that is executed after
step 15 of AsyncGeneratorResumeNext [2] (implemented as @doAsyncGeneratorBodyCall).
We are safe to rely on AsyncGeneratorState? being "suspendedYield" (set in
step 6 of AsyncGeneratorYield [1]) instead of adding extra field to AsyncGenerator:
AsyncGeneratorResumeNext [2] does not overwrite "suspendedYield" state.
This change fixes most of test262 cases.

[1]: ​https://tc39.es/ecma262/#sec-asyncgeneratoryield
[2]: ​https://tc39.es/ecma262/#sec-asyncgeneratorresumenext

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDelegateYield):
This change implements step 7.c.iii.1 of yield* runtime semantics [3], that is
observable only if Value? has userland "then" getter. Awaited result is discarded.
This change fixes async-generator/yield-star-return-then-getter-ticks.js test262 case.

[3]: ​https://tc39.es/ecma262/#sec-generator-function-definitions-runtime-semantics-evaluation

3:05 PM Changeset in webkit [262978] by Chris Dumez
  • 5 edits in trunk

Stop allowing pages served over HTTPS with "Cache-Control: no-store" into the back/forward cache
​https://bugs.webkit.org/show_bug.cgi?id=213147
<rdar://problem/64249683>

Reviewed by Geoffrey Garen.

Source/WebCore:

Stop allowing pages served over HTTPS with "Cache-Control: no-store" into the back/forward cache.
This is a revert of r250437 due to push back from Web developers.

No new tests, updated existing tests.

  • history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

LayoutTests:

Update layout test coverage.

  • http/tests/navigation/https-in-page-cache-expected.txt:
  • http/tests/navigation/resources/https-in-page-cache-1.php:
2:58 PM Changeset in webkit [262977] by Jason_Lawrence
  • 2 edits in trunk/Source/WTF

Unreviewed, reverting r262904.

This commit broke a test on Mac wk1 Debug.

Reverted changeset:

"[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on
a timer"
​https://bugs.webkit.org/show_bug.cgi?id=213063
​https://trac.webkit.org/changeset/262904

2:03 PM Changeset in webkit [262976] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac wk1 Debug ] media/remoteplayback-target-availability.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=213146

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:02 PM Changeset in webkit [262975] by Diego Pino Garcia
  • 4 edits in trunk/Tools

[buildbot] [GTK][WPE] Move WebDriver test to own bot
​https://bugs.webkit.org/show_bug.cgi?id=212527

Reviewed by Carlos Alberto Lopez Perez.

Move 'webdriver-test' step from GTK Release and GTK Debug test bots
to separated bots.

For bots that require a Wayland display (WPE and GTK Wayland),
'webdriver-test' step is run on the corresponding general test bot,
since it's not possible at the moment to run tests that require a
Wayland display in a bot set as a container.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/factories.py:

(TestFactory.init):
(TestWebDriverFactory):
(TestWebDriverFactory.init):

  • BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1:56 PM Changeset in webkit [262974] by Ross Kirsling
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, address Darin's feedback on r262890.

  • runtime/IntlObject.cpp:

(JSC::addScriptlessLocaleIfNeeded):
Use != instead of < for clarity.

1:52 PM Changeset in webkit [262973] by Adrian Perez de Castro
  • 8 edits in trunk

Build is broken with EVENT_LOOP_TYPE=GLib
​https://bugs.webkit.org/show_bug.cgi?id=212987

Reviewed by Konstantin Tokarev.

.:

  • Source/cmake/OptionsJSCOnly.cmake: Add gio-unix as a required component of the GLib

package, as it is needed for the remote inspector support with EVENT_LOOP_TYPE=GLib.

Source/JavaScriptCore:

  • PlatformJSCOnly.cmake: Add sources needed to support the remote inspector to

JavaScriptCore_SOURCES.

Source/WTF:

  • wtf/CurrentTime.cpp: Make sure that <time.h> is included to get clock_gettime() and

friends defined when USE_GLIB is disabled.

  • wtf/PlatformJSCOnly.cmake: Use FileSystemGLib instead of FileSystemPOSIX when

EVENT_LOOP_TYPE=GLib is set, add missing sources needed when ENABLE_REMOTE_INSPECTOR
is set.

  • wtf/glib/RunLoopSourcePriority.h: Use the same list of priorities for WPE and JSCOnly.
1:36 PM Changeset in webkit [262972] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Stop to use ActiveDOMObject::setPendingActivity() for Modules/fetch
​https://bugs.webkit.org/show_bug.cgi?id=213037

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Youenn Fablet.

By ActiveDOMObject's comments,
these methods should be replaced with using makePendingActivity().

JSFetchRequest/JSFetchResponse (as derived class of JSDOMWrapper) hold
FetchRequest/FetchResponse, and they have FetchBodyOwner
as a base class and keep alive it. We can replace
setPendingActivity() calling from FetchBodyOwner.

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::loadBlob):
(WebCore::FetchBodyOwner::finishBlobLoading):
(WebCore::FetchBodyOwner::virtualHasPendingActivity const):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchBodySource.cpp:

(WebCore::FetchBodySource::setActive):
(WebCore::FetchBodySource::setInactive):

  • Modules/fetch/FetchBodySource.h:
12:47 PM Changeset in webkit [262971] by commit-queue@webkit.org
  • 18 edits in trunk

[Curl] Implement functions to use ResourceLoadStatistics.
​https://bugs.webkit.org/show_bug.cgi?id=207692

Patch by Takashi Komori <​Takashi.Komori@sony.com> on 2020-06-12
Reviewed by Don Olmstead.

Implement functions which are required to implement ResourceLoadStatistics for Curl port.

Source/WebCore:

Tests: http/tests/resourceLoadStatistics/

  • CMakeLists.txt:
  • platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::openDatabase):
(WebCore::CookieJarDB::setCookie):
(WebCore::CookieJarDB::allDomains):
(WebCore::CookieJarDB::deleteCookiesForHostname):

  • platform/network/curl/CookieJarDB.h:
  • platform/network/curl/NetworkStorageSessionCurl.cpp:

(WebCore::NetworkStorageSession::setCookiesFromDOM const):
(WebCore::NetworkStorageSession::setCookies):
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
(WebCore::NetworkStorageSession::getHostnamesWithCookies):

Source/WebKit:

In NetworkDataTaskCurl.cpp we check if we should block cookies and block if needed.

Tests: http/tests/resourceLoadStatistics/

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create):

  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::createCurlRequest):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCurl::blockCookies):
(WebKit::NetworkDataTaskCurl::unblockCookies):
(WebKit::NetworkDataTaskCurl::shouldBlockCookies):
(WebKit::NetworkDataTaskCurl::isThirdPartyRequest):

  • NetworkProcess/curl/NetworkDataTaskCurl.h:
  • NetworkProcess/curl/NetworkSessionCurl.cpp:

(WebKit::NetworkSessionCurl::NetworkSessionCurl):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetAllStorageAccessEntries):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

Tools:

Tests: http/tests/resourceLoadStatistics/

  • WebKitTestRunner/TestController.cpp:

(WTR::GetAllStorageAccessEntriesCallbackContext::GetAllStorageAccessEntriesCallbackContext):
(WTR::getAllStorageAccessEntriesCallback):
(WTR::TestController::getAllStorageAccessEntries):

LayoutTests:

Tests: http/tests/resourceLoadStatistics/

  • platform/wincairo-wk1/TestExpectations:
  • platform/wincairo/TestExpectations:
12:38 PM Changeset in webkit [262970] by Russell Epstein
  • 1 copy in tags/Safari-609.3.3

Tag Safari-609.3.3.

12:36 PM Changeset in webkit [262969] by Russell Epstein
  • 1 delete in tags/Safari-609.3.3

Delete tag.

12:31 PM Changeset in webkit [262968] by Russell Epstein
  • 1 copy in tags/Safari-609.3.3

Tag Safari-609.3.3.

12:25 PM Changeset in webkit [262967] by Ryan Haddad
  • 2 edits in branches/safari-609-branch/Tools

Cherry-pick r261243. rdar://problem/61953702

REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots
​https://bugs.webkit.org/show_bug.cgi?id=210676

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm: (TestWebKitAPI::TEST): Skip the test to get the bots to green.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:24 PM Changeset in webkit [262966] by Andres Gonzalez
  • 5 edits in trunk/Source/WebCore

In isolated tree mode 2, AXIsolatedObject::setChildrenIDs should be called only on secondary thread.
​https://bugs.webkit.org/show_bug.cgi?id=213124

Reviewed by Chris Fleizach.

Covered by existing tests.

  • AXIsolatedTree::createSubtree was calling AXIsolatedObject::setChildrenIDs

which should be called only on the secondary thread. Now it is queueing
the children update under lock.

  • The unsigned int range for object IDs was being overrun for large

number of objects like in the case of the sample page in <rdar://problem/59331146>.
Increased the size of AXID to size_t.

  • Better handle the case of invalid object IDs, although this needs

more work, since we should never encounter this case.

  • accessibility/AccessibilityObjectInterface.h: AXID are now size_t instead of unsigned ints.
  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::setChildrenIDs): Inlined in header.

  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::createSubtree):

12:14 PM Changeset in webkit [262965] by Russell Epstein
  • 1 delete in tags/Safari-609.3.3

Delete tag.

12:13 PM Changeset in webkit [262964] by Russell Epstein
  • 1 copy in tags/Safari-609.3.3

Tag Safari-609.3.3.

11:53 AM Changeset in webkit [262963] by ysuzuki@apple.com
  • 3 edits in trunk/LayoutTests

[ Mojave wk2 Release ] js/dom/unhandled-promise-rejection-console-no-report.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=212851

Reviewed by Darin Adler.

This test is wrong since both onunhandledrejection and setTimeout are driven by macro-tasks.
There is no ordering between them so they have race condition, and this race condition makes this
the test flaky. We should fix the test. This patch removes the dependency to setTimeout.

  • js/dom/unhandled-promise-rejection-console-no-report-expected.txt:
  • js/dom/unhandled-promise-rejection-console-no-report.html:
11:40 AM Changeset in webkit [262962] by aestes@apple.com
  • 5 edits in trunk/Source/WebCore

FileInputType should use WeakPtr for FileListCreator lambdas
​https://bugs.webkit.org/show_bug.cgi?id=213130
<rdar://problem/64276591>

Reviewed by David Kilzer.

FileInputType::filesChosen was passing a completion handler to FileListCreator::create that
captured |this|. If the FileListCreator instance still existed when |this| was destroyed,
FileInputType::~FileInputType would clear the captured |this| by calling
FileListCreator::clear. This can be simplified by having the FileListCreator completion
handler capture a WeakPtr to |this|.

Also, when FileInputType::allowsDirectories is false, m_fileListCreator would not be
properly cleared after creating the file list. The FileListCreator completion handler would
set m_fileListCreator to nullptr, but would be executed *before* FileListCreator::create
returned and set m_fileListCreator to the newly-created FileListCreator object. Fixed this
by having FileListCreator::create execute the completion handler immediately and return
nullptr in cases where a FileListCreator does not need to be created for directory
resolution.

Covered by existing tests.

  • html/FileInputType.cpp:

(WebCore::FileInputType::~FileInputType):
(WebCore::FileInputType::filesChosen):

  • html/FileInputType.h:
  • html/FileListCreator.cpp:

(WebCore::createFileList):
(WebCore::FileListCreator::create):
(WebCore::FileListCreator::FileListCreator):
(WebCore::FileListCreator::createFileList):

  • html/FileListCreator.h:

(WebCore::FileListCreator::create): Deleted.

11:24 AM Changeset in webkit [262961] by graouts@webkit.org
  • 3 edits in trunk/LayoutTests

Double tap to zoom out doesn't work after upgrading to iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=205158
<rdar://problem/205158>

Unreviewed. Make the test that was previously added into a test that can be run on iPad instead
of having to be skipped.

  • fast/events/ios/fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out.html:
  • platform/ipad/TestExpectations:
11:22 AM Changeset in webkit [262960] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (r262618): Very slow typing in a github issue
​https://bugs.webkit.org/show_bug.cgi?id=213137
<rdar://problem/64214117>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/media/media-query-keyframes-resolution-count.html

If a stylesheet had multiple media queries and one of them forced static resolution
(by containing @keyframes rule for example) we would end up reseting the style multiple
times and forcing unneeded style resolutions.

  • style/RuleSet.cpp:

(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):

We can't bail out from the loop. Even though the result is known we still need to loop to
save the evaluation result for all media queries.

LayoutTests:

  • fast/media/media-query-keyframes-resolution-count-expected.txt: Added.
  • fast/media/media-query-keyframes-resolution-count.html: Added.
11:03 AM Changeset in webkit [262959] by graouts@webkit.org
  • 4 edits
    2 adds in trunk

Double tap to zoom out doesn't work after upgrading to iOS 13
​https://bugs.webkit.org/show_bug.cgi?id=205158
<rdar://problem/205158>

Reviewed by Wenson Hsieh.

Source/WebKit:

Test: fast/events/ios/fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out.html

In order to determine whether a significant zoom to happen, we should use the current page scale
factor and not the initial page scale factor.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:nodeIsRootLevel:]):

LayoutTests:

Add a test that double taps to zoom in and then double taps to zoom out. This test would fail to zoom
out prior to this source change. This test is skipped on iPad since desktop-class browsing mode has
heuristics that would prevent the second double-tap to zoom out.

  • fast/events/ios/fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out-expected.txt: Added.
  • fast/events/ios/fast-click-double-tap-to-zoom-in-on-text-and-then-again-to-zoom-out.html: Added.
  • platform/ipad/TestExpectations:
10:40 AM Changeset in webkit [262958] by Jonathan Bedard
  • 6 edits in trunk/Tools

Support building test runners for watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=213128
<rdar://problem/64298006>

Reviewed by Tim Horton.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Link against framework stubs.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Apply iOS rules to all embedded sdks.
  • WebKitTestRunner/Configurations/Base.xcconfig: Link against framework stubs.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Apply iOS rules to all embedded sdks.
  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Use watchOS entitlements for tvOS.
10:39 AM Changeset in webkit [262957] by Jonathan Bedard
  • 7 edits in trunk/Tools

TestWebKitAPI: Build for watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=213127
<rdar://problem/64297979>

Reviewed by Tim Horton.

  • TestWebKitAPI/Configurations/Base.xcconfig: Link against framework stubs.
  • TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Apply iOS rules to all embedded sdks.
  • TestWebKitAPI/Configurations/TestWTF.xcconfig: Ditto.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Link against framework stubs.
  • TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Apply iOS rules to all embedded sdks.
  • TestWebKitAPI/config.h: WatchOS uses SSL.
10:29 AM Changeset in webkit [262956] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: modify initial content localized string for Inspector Bootstrap Script
​https://bugs.webkit.org/show_bug.cgi?id=213134

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.async createBootstrapScript):

  • Localizations/en.lproj/localizedStrings.js:
9:30 AM Changeset in webkit [262955] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: (r262397): [ Mac wk2 ] inspector/canvas/create-context-webgpu.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=213123

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:20 AM Changeset in webkit [262954] by Lauro Moura
  • 4 edits in trunk/LayoutTests

[GTK][WPE] Remove some duplicated entries and add missing bug info

Unreviewed test gardening

Unified the unsuported tests entries for GTK and WPE and added some
entries for the skipped top level tests.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
9:14 AM Changeset in webkit [262953] by commit-queue@webkit.org
  • 23 edits
    1 delete in trunk

LayoutTests/imported/w3c:
Change FileReader.error to DOMException from obsoleted FileError
​https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

  • web-platform-tests/FileAPI/historical.https-expected.txt: FileError should not be exposed.

Source/WebCore:
FileReader.error should be DOMException now
​https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

By the [lastest spec](​https://w3c.github.io/FileAPI/),
FileReader.error should return DOMException
and this remove obsoleted FileError from exposed interfaces.

Internally, our codebase still depends on fileapi/FileError.h
in everywhere. I'll plan to create a patch to refactor them.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.order:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/FileError.idl: Removed.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::abort):
(WebCore::FileReader::didFail):

  • fileapi/FileReader.h:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSync::errorCodeToException):

  • fileapi/FileReaderSync.h:

LayoutTests:
Change FileReader.error to DOMException from obsoleted FileError
​https://bugs.webkit.org/show_bug.cgi?id=213117

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-06-12
Reviewed by Chris Dumez.

By the [lastest spec](​https://w3c.github.io/FileAPI/),
FileReader.error should return DOMException
and this change remove FileError from exposed interfaces.

  • fast/files/file-reader-abort-expected.txt:
  • fast/files/file-reader-abort-using-open-panel-expected.txt:
  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt: Update to DOMException error code from FileError error code.
  • platform/mac-wk1/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: FileError should not be exposed.
9:09 AM Changeset in webkit [262952] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk/Tools

Unreviewed, reverting r262942.
​https://bugs.webkit.org/show_bug.cgi?id=213132

Broke gst-libav due to dav1d ABI bump

Reverted changeset:

"[Flatpak SDK] Add libavif"
​https://bugs.webkit.org/show_bug.cgi?id=212964
​https://trac.webkit.org/changeset/262942

8:55 AM Changeset in webkit [262951] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][TFC] Add support for min/max-width
​https://bugs.webkit.org/show_bug.cgi?id=213111

Reviewed by Antti Koivisto.

Source/WebCore:

Apply min/max-width to constrain the available width for the table content.

Test: fast/layoutformattingcontext/table-min-max-width-simple.html

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::computedWidthAndMargin):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):

LayoutTests:

  • fast/layoutformattingcontext/table-min-max-width-simple-expected.html: Added.
  • fast/layoutformattingcontext/table-min-max-width-simple.html: Added.
8:48 AM Changeset in webkit [262950] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Add WKUserScript initializer SPI with alternative names
​https://bugs.webkit.org/show_bug.cgi?id=213096

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-12
Reviewed by Youenn Fablet.

And deprecate the existing ones so we can remove them soon.

  • UIProcess/API/Cocoa/WKUserScript.mm:

(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:includeMatchPatternStrings:excludeMatchPatternStrings:associatedURL:contentWorld:deferRunningUntilNotification:]):

  • UIProcess/API/Cocoa/WKUserScriptPrivate.h:
8:45 AM Changeset in webkit [262949] by ysuzuki@apple.com
  • 1 edit
    1 add in trunk/JSTests

[JSC] Add sampling-profiler code-origin lookup test
​https://bugs.webkit.org/show_bug.cgi?id=213108
<rdar://problem/52044072>

Reviewed by Saam Barati.

This is fixed by r262920. This patch just adds a test additionally.
We are keeping CallSiteIndex valid until corresponding JIT stub is destroyed.
This fixes SamplingProfiler too since SamplingProfiler also collects CallSiteIndex and gets corresponding CodeOrigin.
Since SamplingProfiler does this CallSiteIndex => CodeOrigin before running GC finalizer, validity of CallSiteIndex
should be kept correctly.

  • stress/sampling-profiler-code-origin.js: Added.

(let.oThrow.get f):
(foo):
(return.get f):
(f):

8:43 AM Changeset in webkit [262948] by Lauro Moura
  • 2 edits in trunk/WebDriverTests

[WebDriver][WPE] Add remaining WPE failures to expectations.

Unreviewed test gardening.

8:19 AM Changeset in webkit [262947] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. Fix GTK4 build

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSynthesizeKeyEvent):

7:40 AM Changeset in webkit [262946] by Antti Koivisto
  • 46 edits
    2 adds in trunk

Relative font size values (em) within CSS animations compound
​https://bugs.webkit.org/show_bug.cgi?id=194749
<rdar://problem/48171898>

Reviewed by Antoine Quint.

Source/WebCore:

The em unit should be relative to the font size of the parent style when resolving 'font-size' property.
We weren't passing the parent style when resolving keyframes.

Test case by Scott Kellum.

Test: animations/keyframe-em-unit.html

  • style/StyleResolver.cpp:

(WebCore::Style::Resolver::styleForKeyframe):

  • style/StyleResolver.h:

(WebCore::Style::Resolver::overrideDocumentElementStyle const):
(WebCore::Style::Resolver::setOverrideDocumentElementStyle):
(WebCore::Style::Resolver::setParentElementStyleForKeyframes):

Add a way to pass the parent element style directly to the style resolver.
This should really be passed via the animation system like other context but that requires
lots of refactoring.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Pass it.

LayoutTests:

  • animations/keyframe-em-unit-expected.html: Added.
  • animations/keyframe-em-unit.html: Added.
7:28 AM Changeset in webkit [262945] by weinig@apple.com
  • 15 edits in trunk

Document.currentScript does not work for SVGScriptElements
​https://bugs.webkit.org/show_bug.cgi?id=213104

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/documents/dom-tree-accessors/Document.currentScript-expected.txt:

Update test results after making currentScript work with SVGScriptElements.

  • web-platform-tests/content-security-policy/nonce-hiding/svgscript-nonces-hidden-meta.tentative.sub-expected.txt:
  • web-platform-tests/content-security-policy/nonce-hiding/svgscript-nonces-hidden.tentative-expected.txt:

Update results. Not passing, but getting further.

Source/WebCore:

Updates results for existing tests.

  • WebCore.xcodeproj/project.pbxproj:

Add CurrentScriptIncrementer.h to the Xcode project as it was missing.

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):
(WebCore::CurrentScriptIncrementer::~CurrentScriptIncrementer):
Re-work using ScriptElement, removing the HTMLScriptElement checks. Also changes
scriptType check to explicitly check that against classic scripts, as they are
the only supported type, and if any types other than modules are added in the
future, we would not want this to change behavior.

  • dom/Document.cpp:

(WebCore::Document::pushCurrentScript):

  • dom/Document.h:

(WebCore::Document::currentScript const):
Use an Element, rather than an HTMLScriptElement for currentScript/currentScriptStack
so that either an HTMLScriptElement or an SVGScriptElement can be stored. Using a
ScriptElement would be possible, but would complicate the implementation unnecessarily
by requiring currentScript to have an additional checks before extracting the Element.
Variant<RefPtr<HTMLScriptElement>, RefPtr<SVGScriptElement>> could also have been used
but also would unnecessarily complicated the interface and caused more memory to be used.

  • dom/Document.idl:

Update interface to use Element rather HTMLScriptElement with a comment explaining why we
are not using HTMLOrSVGScriptElement but retaining the same observable behavior.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeClassicScript):
(WebCore::ScriptElement::executeModuleScript):
Pass *this directly to CurrentScriptIncrementer to simplify implementation.

Source/WebKit:

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:

(webkit_dom_document_get_current_script):
Update to account for change in Document::currentScript() now returning an
Element* that can be either an HTMLScriptElement or an SVGScriptElement. To
keep API compatibility, only return non-null for HTMLScriptElements.

Source/WebKitLegacy/mac:

  • DOM/DOMDocument.mm:

(-[DOMDocument currentScript]):
Update to account for change in Document::currentScript() now returning an
Element* that can be either an HTMLScriptElement or an SVGScriptElement. To
keep API compatibility, only return non-null for HTMLScriptElements.

6:21 AM Changeset in webkit [262944] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK WebDriver tests after r262938

Ensure a valid title for backforward items in MiniBrowser, using the URL when the title is empty.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowCreateBackForwardMenu):

2:54 AM Changeset in webkit [262943] by Philippe Normand
  • 2 edits in trunk/Tools

[Flatpak SDK] Update GTK4 to 3.98.5

Rubber-stamped by Carlos Alberto Lopez Perez.

  • buildstream/elements/sdk/gtk.bst:
2:24 AM Changeset in webkit [262942] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

[Flatpak SDK] Add libavif
​https://bugs.webkit.org/show_bug.cgi?id=212964

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-12
Reviewed by Carlos Alberto Lopez Perez.

  • buildstream/elements/freedesktop-sdk.bst:
  • buildstream/elements/sdk-platform.bst:
  • buildstream/elements/sdk/libavif.bst: Added.
  • buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Added.
2:22 AM Changeset in webkit [262941] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

[Flatpak SDK] Add libkate
​https://bugs.webkit.org/show_bug.cgi?id=212865

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-12
Reviewed by Carlos Alberto Lopez Perez.

The GStreamer kate decoder is required for some media/track tests being re-enabled in bug
120665.

  • buildstream/elements/sdk-platform.bst:
  • buildstream/elements/sdk/gst-plugins-bad.bst:
  • buildstream/elements/sdk/libkate.bst: Added.
1:49 AM Changeset in webkit [262940] by cturner@igalia.com
  • 2 edits
    1 add in trunk/Source/WebKit

[GTK] Add an internal API to run javascript without forced user gestures
​https://bugs.webkit.org/show_bug.cgi?id=212969

Reviewed by Carlos Garcia Campos.

To be used by tests in a follow-up commit.

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptWithParams): Factor out the glue to run
JavaScript in the page.
(webkitWebViewRunJavascriptWithoutForcedUserGestures): Add a new
internal API for use by tests.
(webkit_web_view_run_javascript): Modified to use factored out
glue.

  • UIProcess/API/glib/WebKitWebViewInternal.h: Added. Place to keep

API test-specific internal APIs.

1:42 AM Changeset in webkit [262939] by Carlos Garcia Campos
  • 10 edits
    1 move
    1 add
    1 delete in trunk

[GTK4] Get MiniBrowser ready for GTK4
​https://bugs.webkit.org/show_bug.cgi?id=210276

Reviewed by Adrian Perez de Castro.

.:

Bump GTK4 required version.

  • Source/cmake/OptionsGTK.cmake:

Tools:

Port MiniBrowser to GTK4. BrowserSearchBar has been renamed as BrowserSearchBox, because in GTK GtkSearchBar is
final class, so we derive from GtkBox and to be used as contents of a GtkSearchBar.

  • MiniBrowser/gtk/BrowserCellRendererVariant.c:

(browserCellRendererVariantCellRendererSnapshot):
(browser_cell_renderer_variant_class_init):

  • MiniBrowser/gtk/BrowserCellRendererVariant.h:
  • MiniBrowser/gtk/BrowserSearchBar.c: Removed.
  • MiniBrowser/gtk/BrowserSearchBox.c: Added.

(setFailedStyleForEntry):
(doSearch):
(searchNext):
(searchPrevious):
(searchEntryMenuIconPressedCallback):
(searchEntryClearIconReleasedCallback):
(searchEntryChangedCallback):
(searchEntryActivatedCallback):
(searchPreviousButtonCallback):
(searchNextButtonCallback):
(searchMenuCheckButtonToggledCallback):
(findControllerFailedToFindTextCallback):
(findControllerFoundTextCallback):
(browserSearchBoxFinalize):
(browserSearchBoxDispose):
(browserSearchBoxSizeAllocate):
(browser_search_box_class_init):
(browser_search_box_new):
(browser_search_box_get_entry):

  • MiniBrowser/gtk/BrowserSearchBox.h: Renamed from Tools/MiniBrowser/gtk/BrowserSearchBar.h.
  • MiniBrowser/gtk/BrowserSettingsDialog.c:

(browser_settings_dialog_init):
(browser_settings_dialog_new):

  • MiniBrowser/gtk/BrowserSettingsDialog.h:
  • MiniBrowser/gtk/BrowserTab.c:

(loadChanged):
(createInfoBarQuestionMessage):
(tlsErrorsDialogResponse):
(loadFailedWithTLSerrors):
(permissionRequestDialogResponse):
(decidePermissionRequest):
(colorChooserRequestFinished):
(runColorChooserCallback):
(tabCloseClicked):
(browserTabConstructed):
(browserTabIsSearchBarOpen):
(browser_tab_start_search):
(browser_tab_stop_search):
(browser_tab_enter_fullscreen):
(browser_tab_leave_fullscreen):

  • MiniBrowser/gtk/BrowserWindow.c:

(settingsCallback):
(resetEntryProgress):
(webViewLoadProgressChanged):
(browserWindowCreateBackForwardMenu):
(browserWindowUpdateNavigationMenu):
(navigationButtonPressed):
(navigationButtonPressCallback):
(scrollEventCallback):
(webViewIsLoadingChanged):
(searchCallback):
(insertImageDialogResponse):
(insertImageCommandCallback):
(insertLinkDialogResponse):
(insertLinkCommandCallback):
(typingAttributesChanged):
(browserWindowSaveSession):
(browserWindowFinalize):
(browserWindowDispose):
(addToolbarButton):
(browserWindowSwitchTab):
(browserWindowTabAddedOrRemoved):
(browserWindowBuildPopoverMenu):
(browserWindowCloseRequest):
(browserWindowDeleteEvent):
(browser_window_class_init):
(browser_window_append_view):
(browser_window_set_background_color):

  • MiniBrowser/gtk/CMakeLists.txt:
1:28 AM Changeset in webkit [262938] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] MiniBrowser: stop using GtkToolbar
​https://bugs.webkit.org/show_bug.cgi?id=212898

Reviewed by Adrian Perez de Castro.

GtkToolbar iss no longer available in GTK4, use a GtkBox with buttons instead. Also use symbolic icons and move
some of the actions to a gear menu.

  • MiniBrowser/gtk/BrowserWindow.c:

(browserWindowHistoryItemActivated):
(browserWindowCreateBackForwardMenu):
(browserWindowUpdateNavigationMenu):
(navigationButtonPressCallback):
(browserWindowCanZoomDefault):
(browserWindowUpdateZoomActions):
(webViewIsLoadingChanged):
(addToolbarButton):
(browserWindowBuildPopoverMenu):
(resetStatusText): Deleted.
(browserWindowHistoryItemSelected): Deleted.
(browserWindowSetupEditorToolbarItem): Deleted.

1:25 AM Changeset in webkit [262937] by Carlos Garcia Campos
  • 4 edits in trunk/Tools

[GTK] MiniBrowser: stop using GtkToolbar for the search bar
​https://bugs.webkit.org/show_bug.cgi?id=212817

Reviewed by Adrian Perez de Castro.

Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4. Also use a GtkPopover for the
options menu instead of the GtkMenu.

  • MiniBrowser/gtk/BrowserSearchBar.c:

(setFailedStyleForEntry):
(doSearch):
(searchEntryMenuIconPressedCallback):
(searchEntryChangedCallback):
(searchMenuCheckButtonToggledCallback):
(browserSearchBarFinalize):
(browser_search_bar_new):
(browser_search_bar_open):
(browser_search_bar_close):
(browser_search_bar_is_open):
(searchCloseButtonClickedCallback): Deleted.
(searchEntryClearIconReleasedCallback): Deleted.

  • MiniBrowser/gtk/BrowserSearchBar.h:
  • MiniBrowser/gtk/BrowserTab.c:

(browser_tab_start_search):
(browser_tab_stop_search):

1:19 AM Changeset in webkit [262936] by Carlos Garcia Campos
  • 9 edits in trunk

[GTK4] Make WebDriver work
​https://bugs.webkit.org/show_bug.cgi?id=212316

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Add helper gtk definitions to avoid ifdefs and implement currentScreenMonitor() for GTK4.

  • platform/gtk/GtkVersioning.h:

(gtk_window_move):
(gtk_window_minimize):
(gtk_window_unminimize):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::currentScreenMonitor):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::getCurrentScreenMonitor): Deleted.

Source/WebKit:

Fix UIClient::setWindowFrame to wait for surface size-changed signal after resizing the window and implement
maximize, minimize and restore windows for GTK4.

  • UIProcess/API/glib/WebKitUIClient.cpp:
  • UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(surfaceStateChangedCallback):
(webkitWebViewMonitorWindowState):
(webkitWebViewMaximizeWindow):
(webkitWebViewMinimizeWindow):
(webkitWebViewRestoreWindow):

Tools:

Stop connecting to WebKitWebView::close signal twice for newaly created windows.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewCreate):

12:01 AM Changeset in webkit [262935] by Keith Rollin
  • 4 edits in trunk/Source/WebKitLegacy

Add dependencies for Migrate Headers and Generate Export Files build phases
​https://bugs.webkit.org/show_bug.cgi?id=213072
<rdar://problem/64249345>

Reviewed by Tim Horton.

These build phases have incomplete specifications for the files they
consume and produce, which can lead to incorrect builds. Address this
by:

  • Adding the WebCore/PrivateHeaders directory (which contains the headers being migrated) as input to the Migrate Headers build phase
  • Touching a timestamp file when re-exporting any headers in the Migrate Headers build phase
  • Adding the timestamp file as an output of the Migrate Headers build phase
  • Adding the timestamp file as an input of the Generate Export Files build phase
  • Adding other files that Generate Export Files consumes to the list of input files

In this way, if any exported headers are changed, both Migrate Headers
and Generate Export Files will be run.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

  • MigrateHeaders.make:

Jun 11, 2020:

11:17 PM Changeset in webkit [262934] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262932
​https://bugs.webkit.org/show_bug.cgi?id=213115

Unreviewed test gardening.

  • platform/glib/TestExpectations:
11:02 PM Changeset in webkit [262933] by ddkilzer@apple.com
  • 83 edits
    1 add in trunk/Source

[IPC] Add WTF::EnumTraits<> for every enum type used in IPC
<​https://webkit.org/b/213093>

Reviewed by Darin Adler.

Summary:

  • Change underlying type of enum class to bool when there are only two values. In some cases, reorder the two values so the mapping to 0 and 1 makes more sense. Converting every enum to an enum class is not a goal of this patch, so some two-value enums stil have WTF::EnumTraits<> defined as noted below.
  • Add WTF::EnumTraits<> for the remaining enum types that are used by IPC::Encoder::encodeEnum() and IPC::Decoder::decodeEnum() so that WTF::isValidEnum<>() checks may be added next.
  • Add #include <WebCore/LibWebRTCEnumTraits.h> as needed.

Source/WebCore:

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • Add LibWebRTCEnumTraits.h to project. Keep these definitions separate from the libwebrtc project cut down on changes to re-merge after updating.
  • platform/mediastream/libwebrtc/LibWebRTCEnumTraits.h: Add.
  • Modules/applepay/ApplePaySessionPaymentRequest.h:
  • Modules/indexeddb/IDBTransactionMode.h:
  • Modules/indexeddb/IndexedDB.h:

(WTF::EnumTraits<WebCore::IndexedDB::IndexRecordType>):

  • Remove after changing enum class to bool.
  • Modules/indexeddb/shared/IDBGetRecordData.h:
  • Modules/indexeddb/shared/IDBResultData.h:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionCode.h:
  • editing/CompositionUnderline.h:
  • html/Autofill.h:
  • html/DataListSuggestionInformation.h:
  • html/EnterKeyHint.h:
  • html/LinkIconType.h:
  • loader/FrameLoaderTypes.h:
  • Alphabetize WTF::EnumTraits<> definitions.
  • loader/ResourceLoaderOptions.h:
  • page/SecurityOrigin.h:
  • page/UserStyleSheetTypes.h:

(WTF::EnumTraits<WebCore::UserStyleLevel>):

  • Define this since UserStyleLevel is not an enum class.
  • page/scrolling/ScrollingCoordinatorTypes.h:
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/FileChooser.h:
  • platform/PopupMenuStyle.h:
  • platform/ScreenProperties.h:
  • platform/ScrollTypes.h:
  • platform/SerializedPlatformDataCueValue.h:

(WebCore::SerializedPlatformDataCueValue::PlatformType):

  • Convert from enum to enum class.
  • platform/UserInterfaceLayoutDirection.h:
  • platform/animation/TimingFunction.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsTypes.h:
  • Alphabetize WTF::EnumTraits<> definitions.
  • platform/graphics/Image.h:
  • platform/graphics/Path.h:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/MediaStreamRequest.h:

(WTF::EnumTraits<WebCore::MediaStreamRequest::Type>):

  • Fix EnumTraits definition (missing "::Type").
  • platform/mediastream/RealtimeMediaSourceCapabilities.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/network/CredentialBase.h:
  • platform/network/ProtectionSpaceBase.h:
  • platform/network/ResourceErrorBase.h:
  • platform/network/soup/SoupNetworkProxySettings.h:
  • platform/text/TextChecking.h:

(WTF::EnumTraits<WebCore::TextCheckingProcessType):

  • Define this since TextCheckingProcessType is not an enum class.
  • platform/text/WritingMode.h:
  • rendering/Pagination.h:
  • workers/service/ServiceWorkerJobType.h:

Source/WebKit:

  • GPUProcess/GPUConnectionToWebProcess.h:
  • GPUProcess/GPUProcess.h:
  • NetworkProcess/NetworkLoadParameters.h:
  • Shared/API/APIObject.h:
  • Shared/ContextMenuContextData.h:
  • Shared/DrawingAreaInfo.h:
  • Shared/FocusedElementInformation.h:
  • Shared/PrintInfo.h:

(WTF::EnumTraits<WebKit::PrintInfo::PrintMode>):

  • Define this since PrintMode is not an enum class.
  • Shared/RTCPacketOptions.cpp:
  • Shared/SessionState.h:
  • Shared/TouchBarMenuItemData.h:
  • Shared/WebEvent.h:
  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem):

  • Fix reference to WebPopupItem::Type enum.
  • Shared/WebPopupItem.h:

(WebKit::WebPopupItem::Type):

  • Convert from enum to enum class.
  • Shared/WebsiteData/WebsiteDataType.h:
  • Shared/glib/InputMethodState.h:
  • Shared/glib/UserMessage.h:
  • Shared/mac/ColorSpaceData.mm:
  • Shared/mac/SecItemRequestData.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):

  • Fix reference to WebPopupItem::Type enum.
  • WebProcess/Plugins/Plugin.cpp:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::populateItems):

  • Fix reference to WebPopupItem::Type enum.
  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:
5:29 PM Changeset in webkit [262932] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Linear Scan uses the wrong Interval for spills for tmps with roles of early def or late use
​https://bugs.webkit.org/show_bug.cgi?id=213055
<rdar://problem/59874018>

Reviewed by Yusuke Suzuki.

There was a bug in linear scan when computing the live range interval for
spill tmps that had early defs or late uses. When linear scan spills a
tmp, it creates a new tmp that it loads to and stores from, and replaces the old tmp
with the new tmp, and emits stores/loads around pertinent instructions. The live
interval for such tmps is small by nature, it's contained in the interval for the
instruction itself. However, we'd build this interval purely based off the
original tmp's arg timing. So, for example, let's consider a program like this:

RandoInsn: LateUse:Tmp1, Use:Tmp2, [early = N, late = N+1]
Let's say that Tmp1's last use is RandoInsn, and it had a def before
RandoInsn, therefore, its live range will be something like:
[J where J < N, N+1]

and now imagine we spilled Tmp1 for some reason, and rewrote the
program to be:
Move Addr(spill for Tmp1), TmpSpill
RandoInsn: LateUse:TmpSpill, Use:Tmp2, [early = N, late = N+1]

We used to incorrectly mark the live range for TmpSpill to just be [N+1, N+2).
However, the bug here is that we neglected that TmpSpill actually had an earlier
def at [N, N+1). So, the live range for TmpSpill was wrong. This could incorrectly
lead us to allocate Tmp2 and TmpSpill to the same register, since their live
ranges may not intersect if Tmp2 dies at RandoInsn.

We also had the symmetric bug for EarlyDefs: we wouldn't account for the
store-spill that'd happen after something like RandoInsn.

The fix is to account for the loads/stores of spill tmps when assigning
them a live range.

This patch contains a standalone test in testair. It also fixes crashes we had when
running B3O1 tests using typed arrays on arm64e since we had patchpoints that utilized
LateUse for signing and auth.

  • b3/B3Procedure.h:
  • b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
  • b3/air/testair.cpp:
5:09 PM Changeset in webkit [262931] by sbarati@apple.com
  • 2 edits in trunk/Tools

Skip wasm-js2 test on memory limited devices
​https://bugs.webkit.org/show_bug.cgi?id=213099

Reviewed by Yusuke Suzuki.

  • Scripts/run-jsc-stress-tests:
4:51 PM Changeset in webkit [262930] by commit-queue@webkit.org
  • 8 edits in trunk

Re-enable download resume tests
​https://bugs.webkit.org/show_bug.cgi?id=213098
<rdar://problem/63512518>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-11
Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):

Source/WTF:

Workaround is no longer needed because underlying bug has been fixed.

  • wtf/PlatformHave.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4:43 PM Changeset in webkit [262929] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Fix comment after blocklist transition
​https://bugs.webkit.org/show_bug.cgi?id=213100

Reviewed by Wenson Hsieh.

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

3:47 PM Changeset in webkit [262928] by sbarati@apple.com
  • 13 edits
    2 moves in trunk/Source/JavaScriptCore

Replace uses of black/white list with block/allow list
​https://bugs.webkit.org/show_bug.cgi?id=213084

Reviewed by Keith Miller.

We should be using racially neutral names in our code. From Chromium style guide:

"Terms such as 'blacklist' and 'whitelist' reinforce the notion that
black==bad and white==good."

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

  • dfg/DFGDriver.cpp:

(JSC::DFG::ensureGlobalDFGAllowlist):
(JSC::DFG::compileImpl):
(JSC::DFG::ensureGlobalDFGWhitelist): Deleted.

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::ensureGlobalFTLAllowlist):
(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::ensureGlobalFTLWhitelist): Deleted.

  • heap/MachineStackMarker.cpp:
  • inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.should_generate_types_for_domain):
(ObjCGenerator.should_generate_commands_for_domain):
(ObjCGenerator.should_generate_events_for_domain):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::ensureGlobalJITAllowlist):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::ensureGlobalJITWhitelist): Deleted.

  • runtime/OptionsList.h:
  • tools/FunctionAllowlist.cpp: Copied from Source/JavaScriptCore/tools/FunctionWhitelist.cpp.

(JSC::FunctionAllowlist::FunctionAllowlist):
(JSC::FunctionAllowlist::contains const):
(JSC::FunctionWhitelist::FunctionWhitelist): Deleted.
(JSC::FunctionWhitelist::contains const): Deleted.

  • tools/FunctionAllowlist.h: Copied from Source/JavaScriptCore/tools/FunctionWhitelist.h.
  • tools/FunctionWhitelist.cpp: Removed.
  • tools/FunctionWhitelist.h: Removed.
3:31 PM Changeset in webkit [262927] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, reverting r262696.
​https://bugs.webkit.org/show_bug.cgi?id=213097

It broke running JSC tests on watchOS

Reverted changeset:

"Allow run-jsc-stress-tests still run if some of the remote
hosts are not available"
​https://bugs.webkit.org/show_bug.cgi?id=201426
​https://trac.webkit.org/changeset/262696

3:11 PM Changeset in webkit [262926] by sihui_liu@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r262879): 3 TestWebKitAPI.TextManipulation tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=213079
<rdar://problem/64256870>

Reviewed by Wenson Hsieh.

Update a few tests after behavior change in r262879. From r262879, we no longer use visible positions of element
to calculate range to observe. Instead, we use the first and end position in the element to decide the range. In
previous implementation, the range can be extended to outside of the element, like some visible positon before
or after the element.

TextManipulation.StartTextManipulationFindNewlyDisplayedParagraph: Different elements would make separate ranges
because we create range with the boundaries of element. We can consider merging adjacent ranges later.
TextManipulation.StartTextManipulationFindSameParagraphWithNewContent: The newly observing range only includes
the newly inserted element now.
TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem: The p element
is not manipulated as it is the common ancestor of manipulated elements. And we want to make sure the newly
inserted element is child of a manipulated element.

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

2:05 PM Changeset in webkit [262925] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r262776): Flaky crash under -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
​https://bugs.webkit.org/show_bug.cgi?id=213059

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-11
Reviewed by Alex Christensen.

My r262776 patch did not null check m_handle and it can cause crashes
in some cases, so add the check.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):

2:02 PM Changeset in webkit [262924] by Jonathan Bedard
  • 2 edits in trunk/Source/WTF

WebKit: Make UIGestureRecognizer build for watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=213038
<rdar://problem/64217654>

Reviewed by Tim Horton.

  • wtf/PlatformHave.h: Enable HAVE(UI_GESTURE_RECOGNIZER_MODIFIER_FLAGS) for watchOS and tvOS.
1:47 PM Changeset in webkit [262923] by Alan Coon
  • 6 edits in branches/safari-609-branch

Cherry-pick r261217. rdar://problem/62978240

Fix animation ordering to make imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative.html pass
​https://bugs.webkit.org/show_bug.cgi?id=211468
<rdar://problem/62732578>

Reviewed by David Kilzer.

LayoutTests/imported/w3c:

Mark the final two failures in imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative.html as PASS.

  • web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt:

Source/WebCore:

The "Animation composite order" section of the CSS Animations Level 2 specification (​https://drafts.csswg.org/css-animations-2/#animation-composite-order)
defines the relative composite order of animations. We bake this into compareAnimationsByCompositeOrder(), but this function would not yield consistent
results if it is called in a non-stable sort, because if both CSSAnimation objects passed to this function have the same backing Animation object, they
would not return the same value if passed in a different order. The Web Animations spec always ensures that procedures that sort using the composite
order are called as part of a stable sort. So we change all call sites to use std::stable_sort and add an assertion in case we have two CSSAnimation
objects with the same backing Animation objects to catch cases like this in the future.

Finally, since we already know only relevant animations can find their way into the output of Document::getAnimations(), we also ensure we iterate over
m_animations (which holds only relevant animations) rather than m_allAnimations (which may not).

  • animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::getAnimations const):
  • animation/KeyframeEffectStack.cpp: (WebCore::KeyframeEffectStack::ensureEffectsAreSorted):
  • animation/WebAnimationUtilities.cpp: (WebCore::compareAnimationsByCompositeOrder):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:47 PM Changeset in webkit [262922] by Beth Dakin
  • 39 edits in trunk/Source

Replace instances of whitelist in WebCore with allowlist
​https://bugs.webkit.org/show_bug.cgi?id=213068

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addAllowedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions): Deleted.

  • Modules/webdatabase/DatabaseAuthorizer.h:
  • dom/ExtensionStyleSheets.cpp:

(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestMethodAllowlist):
(WebCore::isSimpleCrossOriginAccessRequest):
(WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Deleted.

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod const):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::setOnlineAllowlist):
(WebCore::ApplicationCache::isURLInOnlineAllowlist):
(WebCore::ApplicationCache::setOnlineWhitelist): Deleted.
(WebCore::ApplicationCache::isURLInOnlineWhitelist): Deleted.

  • loader/appcache/ApplicationCache.h:

(WebCore::ApplicationCache::onlineAllowlist const):
(WebCore::ApplicationCache::onlineWhitelist const): Deleted.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
(WebCore::ApplicationCacheHost::getApplicationCacheFallbackResource):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::openDatabase):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::loadCache):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/appcache/ManifestParser.h:
  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canRequest const):
(WebCore::SecurityOrigin::canDisplay const):

  • page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::isAccessAllowed):
(WebCore::SecurityPolicy::addOriginAccessAllowlistEntry):
(WebCore::SecurityPolicy::removeOriginAccessAllowlistEntry):
(WebCore::SecurityPolicy::resetOriginAccessAllowlists):
(WebCore::SecurityPolicy::isAccessWhiteListed): Deleted.
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry): Deleted.
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry): Deleted.
(WebCore::SecurityPolicy::resetOriginAccessWhitelists): Deleted.

  • page/SecurityPolicy.h:
  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/UserContentURLPattern.h:
  • page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::allowlist const):
(WebCore::UserScript::encode const):
(WebCore::UserScript::decode):
(WebCore::UserScript::whitelist const): Deleted.

  • page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::allowlist const):
(WebCore::UserStyleSheet::whitelist const): Deleted.

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontAllowlist):
(WebCore::FontCache::setFontAllowlist):
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWhitelist): Deleted.
(WebCore::FontCache::setFontWhitelist): Deleted.

  • platform/network/HTTPParsers.cpp:

(WebCore::isValidAcceptHeaderValue):

  • rendering/FloatingObjects.h:
  • style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::transferMatchedRules):

  • style/ElementRuleCollector.h:
  • style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::addMatch):

  • style/RuleData.cpp:

(WebCore::Style::determinePropertyAllowlistType):
(WebCore::Style::RuleData::RuleData):
(WebCore::Style::determinePropertyWhitelistType): Deleted.

  • style/RuleData.h:

(WebCore::Style::RuleData::propertyAllowlistType const):
(WebCore::Style::RuleData::propertyWhitelistType const): Deleted.

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::addOriginAccessWhitelistEntry):
(WebKit::NetworkConnectionToWebProcess::removeOriginAccessWhitelistEntry):
(WebKit::NetworkConnectionToWebProcess::resetOriginAccessWhitelists):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::decode):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::removeOriginAccessWhitelistEntry):
(WebKit::InjectedBundle::resetOriginAccessWhitelists):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):
(+[WebView _setFontWhitelist:]):

1:45 PM Changeset in webkit [262921] by Alan Coon
  • 1 copy in tags/Safari-610.1.15.51.2

Tag Safari-610.1.15.51.2.

1:11 PM Changeset in webkit [262920] by ysuzuki@apple.com
  • 15 edits
    3 adds in trunk

[JSC] Return DisposableCallSiteIndex when destroying GCAwareJITStubRoutineWithExceptionHandler
​https://bugs.webkit.org/show_bug.cgi?id=213069
<rdar://problem/64205186>

Reviewed by Saam Barati.

JSTests:

  • stress/dont-dispose-callsiteindex-while-executing.js: Added.

(emptyFunction):
(foo.bar.set catch):
(foo.bar):
(foo):

Source/JavaScriptCore:

Inside GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount, we are returning DisposableCallSiteIndex to freelist.
However, GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount can be called even if the code of GCAwareJITStubRoutineWithExceptionHandler is
on the stack. Let's consider the following scenario.

  1. Execute GCAwareJITStubRoutineWithExceptionHandler's code. Set CallSiteIndex to the stack.
  2. Execute more code. (1)'s GCAwareJITStubRoutineWithExceptionHandler's code is on the stack.
  3. (1)'s GCAwareJITStubRoutineWithExceptionHandler's refcount becomes zero.
  4. CallSiteIndex of GCAwareJITStubRoutineWithExceptionHandler is returned.
  5. Execute StackVisitor to construct frames. But we cannot find CodeOrigin corresponding to CallSiteIndex stored in (1) since it is already returned.

DisposableCallSiteIndex should be returned after ensuring that GCAwareJITStubRoutineWithExceptionHandler's code is not on the stack. Detecting this is the functionality
what GCAwareJITStubRoutineWithExceptionHandler can offer. It is destroyed after ensuring that GCAwareJITStubRoutineWithExceptionHandler's code is not on the stack.

This patch delays DisposableCallSiteIndex returning until we destroy owner GCAwareJITStubRoutineWithExceptionHandler. But it is possible that CodeBlock* corresponding to
GCAwareJITStubRoutineWithExceptionHandler is already destroyed. To avoid this condition, we extract CodeOrigins vector as Ref<DFG::CodeOriginPool> and keep it alive from
GCAwareJITStubRoutineWithExceptionHandler too. And since CodeOrigin addition / removal happens only from the main thread after finishing the compilation, and
GCAwareJITStubRoutineWithExceptionHandler's destructor is called from the Heap's finalizer, which must be executed from the main thread, we can just modify it without a lock.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
(JSC::CodeBlock::codeOrigins):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::codeOrigin):

  • dfg/DFGCodeOriginPool.cpp: Added.

(JSC::DFG::CodeOriginPool::addCodeOrigin):
(JSC::DFG::CodeOriginPool::addUniqueCallSiteIndex):
(JSC::DFG::CodeOriginPool::lastCallSite const):
(JSC::DFG::CodeOriginPool::addDisposableCallSiteIndex):
(JSC::DFG::CodeOriginPool::removeDisposableCallSiteIndex):
(JSC::DFG::CodeOriginPool::shrinkToFit):

  • dfg/DFGCodeOriginPool.h: Added.

(JSC::DFG::CodeOriginPool::create):
(JSC::DFG::CodeOriginPool::get):
(JSC::DFG::CodeOriginPool::size const):

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):
(JSC::DFG::CommonData::addCodeOrigin): Deleted.
(JSC::DFG::CommonData::addUniqueCallSiteIndex): Deleted.
(JSC::DFG::CommonData::lastCallSite const): Deleted.
(JSC::DFG::CommonData::addDisposableCallSiteIndex): Deleted.
(JSC::DFG::CommonData::removeDisposableCallSiteIndex): Deleted.

  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exceptionCheck):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addCallSite):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDelBy):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileInById):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail):
(JSC::FTL::DFG::LowerDFGToB3::getById):
(JSC::FTL::DFG::LowerDFGToB3::getByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToB3::callPreflight):

  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::callSiteIndexForCodeOrigin):

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutineWithExceptionHandler::GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::~GCAwareJITStubRoutineWithExceptionHandler):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::aboutToDie):
(JSC::GCAwareJITStubRoutineWithExceptionHandler::observeZeroRefCount):

  • jit/GCAwareJITStubRoutine.h:
12:56 PM Changeset in webkit [262919] by Ryan Haddad
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, reverting r262909.

This test causes macOS WK1 tests to intermittently exit early

Reverted changeset:

"Release Assert @
WebCore::RenderTreeBuilder::RenderTreeBuilder"
​https://bugs.webkit.org/show_bug.cgi?id=212714
​https://trac.webkit.org/changeset/262909

12:43 PM Changeset in webkit [262918] by aestes@apple.com
  • 9 edits
    6 adds in trunk

[iOS] nullptr deref in FileInputType::iconLoaded when the input's type attribute is modified by a change event listener
​https://bugs.webkit.org/show_bug.cgi?id=208244
<rdar://problem/41855350>

Reviewed by Wenson Hsieh.

Source/WebCore:

When an <input> element's type attribute changes, its existing InputType is detached from
the HTMLInputElement by nulling InputType::m_element. When FileInputType::filesChosen is
called, it dispatches the input and change events, which can run arbitrary JavaScript that
might modify the element's type attribute. If this happens, FileInputType::m_element will be
null after returning from FileInputType::setFiles and if there is an icon will be
dereferenced by FileInputType::iconLoaded.

Fixed this by checking for a non-null m_element before calling iconLoaded. While here, also
fixed a bug where we sometimes checked the length of m_fileList before FileListCreator had
finished setting m_fileList. This bug resulted in missing file icons whenever an
<input type=file> had the webkitdirectory attribute.

Tests: fast/forms/file/file-input-type-detached-on-change.html

fast/forms/file/file-input-webkitdirectory-icon.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::filesChosen):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(SetOpenPanelFilesMediaIconCallback):
(TestRunner::staticFunctions):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setOpenPanelFilesMediaIcon):

LayoutTests:

  • fast/forms/file/file-input-type-detached-on-change-expected.txt: Added.
  • fast/forms/file/file-input-type-detached-on-change.html: Added.
  • fast/forms/file/file-input-webkitdirectory-icon-expected.html: Added.
  • fast/forms/file/file-input-webkitdirectory-icon.html: Added.
  • fast/forms/file/file-reset-in-change-using-open-panel-with-icon.html:
  • fast/forms/file/open-file-panel-crash.html:
  • fast/forms/file/resources/file-icon-bytes.js: Added.
12:41 PM Changeset in webkit [262917] by Jonathan Bedard
  • 3 edits in trunk/Source/WebKit

WebKit: Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT)
​https://bugs.webkit.org/show_bug.cgi?id=213076
<rdar://problem/64254698>

Reviewed by Tim Horton.

No new tests, behavior unchanged.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _requestDocumentContext:completionHandler:]): Guard requestDocumentContext with HAVE(UI_WK_DOCUMENT_CONTEXT).
(-[WKWebView _adjustSelectionWithDelta:completionHandler:]): Ditto.

12:23 PM Changeset in webkit [262916] by Alan Coon
  • 8 edits in branches/safari-610.1.15.50-branch/Source

Versioning.

11:58 AM Changeset in webkit [262915] by Jonathan Bedard
  • 2 edits in trunk/Source/WebKit

WebKit: Add UIKit SPI for watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=213077
<rdar://problem/64255131>

Reviewed by Tim Horton.

No new tests, behavior unchanged.

  • Platform/spi/ios/UIKitSPI.h:
11:55 AM Changeset in webkit [262914] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Remove references to "slave" in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=213085

Reviewed by Wenson Hsieh.

This feature is referred to as a mediagroup in html, so let's use that terminology here as
well.

  • html/MediaController.cpp:

(WebCore::MediaController::buffered const):
(WebCore::MediaController::seekable const):
(WebCore::MediaController::played):
(WebCore::MediaController::duration const):
(WebCore::MediaController::setCurrentTime):
(WebCore::MediaController::play):
(WebCore::MediaController::updateReadyState):
(WebCore::MediaController::updatePlaybackState):
(WebCore::MediaController::isBlocked const):
(WebCore::MediaController::hasEnded const):

11:54 AM Changeset in webkit [262913] by ddkilzer@apple.com
  • 32 edits in trunk/Source

[IPC] Adopt enum class for DragSourceAction
<​https://webkit.org/b/212885>
<rdar://problem/64094134>

Reviewed by Darin Adler.

Source/WebCore:

Summary:

  • Convert DragSourceAction to enum class.
  • Remove DragSourceActionNone by using Optional<> and OptionSet<> (as dictated by how the code used the value).
  • Remove DragSourceActionAny and replace (as needed) with anyDragSourceAction(). (Some--but not all--uses were removed.)
  • Add both WTF::EnumTraits<> and WTF::OptionSetTraits<> for DragSourceAction since both Optional<> and OptionSet<> are used with IPC.
  • loader/EmptyClients.cpp:
  • page/DragActions.h:

(WebCore::DragSourceAction):

  • Convert to enum class.

(WebCore::anyDragSourceAction): Add.

  • Replaces WebCore::DragSourceActionAny.

(WTF::EnumTraits<WebCore::DragSourceAction>): Add.
(WTF::OptionSetTraits<WebCore::DragSourceAction>): Add.

  • page/DragClient.h:
  • page/DragController.cpp:

(WebCore::DragController::delegateDragSourceAction):
(WebCore::DragController::draggableElement const):
(WebCore::DragController::prepareForDragStart const):
(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):

  • Use OptionSet<>::toSingleValue() and add ASSERT() that it does not return WTF::nullopt.
  • page/DragController.h:

(WebCore::DragController::dragSourceAction const):

  • page/DragState.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragSourceActionsAllowed const):
(WebCore::EventHandler::dragHysteresisExceeded const):

  • Use OptionSet<>::toSingleValue() and add ASSERT() that it does not return WTF::nullopt.
  • Remove case statements for DragSourceActionNone and DragSourceActionAny, along with ASSERT_NOT_REACHED(). The ASSERT() for toSingleValue() replaces the DragSourceActionNone case.

(WebCore::EventHandler::didStartDrag):
(WebCore::ExactlyOneBitSet): Delete.

  • Move to WTF::OptionSet<>::hasExactlyOneBitSet().

(WebCore::EventHandler::handleDrag):

  • Add code to #ifndef NDEBUG/#endif instead of modifying dragState().type in-place since it seemed weird to modify it just to check an ASSERT(), even though it was overwritten immediately after that.
  • page/EventHandler.h:
  • platform/DragItem.h:

(WebCore::DragItem::encode const):
(WebCore::DragItem::decode):

  • Stop using decodeEnum()/encodeEnum() with Optional<DragSourceAction>.

Source/WebKit:

Summary:

  • Convert argument parameters from uint64_t to OptionSet<DragSourceAction>.
  • Convert DragSourceAction to OptionSet<DragSourceAction>.
  • Scripts/webkit/messages.py:
  • Map DragSourceAction enum to DragActions.h header.
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/DragDropInteractionState.h:
  • UIProcess/ios/DragDropInteractionState.mm:

(WebKit::shouldUseDragImageToCreatePreviewForDragSource):
(WebKit::shouldUseVisiblePathToCreatePreviewForDragSource):
(WebKit::shouldUseTextIndicatorToCreatePreviewForDragSource):
(WebKit::canUpdatePreviewForActiveDragSource):
(WebKit::DragDropInteractionState::anyActiveDragSourceIs const):
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::hasStagedDragSource const):
(WebKit::DragDropInteractionState::updatePreviewsForActiveDragSources):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startDrag:item:]):
(-[WKContentView _allowedDragSourceActions]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::requestDragStart):
(WebKit::WebPageProxy::requestAdditionalItemsForDragSession):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::dragSourceActionMaskForPoint):

  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::allowedDragSourceActions const):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestDragStart):
(WebKit::WebPage::requestAdditionalItemsForDragSession):

Source/WebKitLegacy/mac:

Summary:

  • Add and use conversion functions between OptionSet<WebCore::DragSourceAction> and WebDragSourceAction.
  • Update method signatures.
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:

(coreDragSourceActionMask): Add.
(WebDragClient::dragSourceActionMaskForPoint):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

  • WebView/WebView.mm:

(kit): Add.

  • Convert from Optional<WebCore::DragSourceAction> to WebDragSourceAction.

(-[WebView _startDrag:]):

  • WebView/WebViewInternal.h:

(kit): Add declaration to reuse function in WebDragClient.mm.

Source/WebKitLegacy/win:

Summary:

  • Add and use conversion functions between OptionSet<WebCore::DragSourceAction> and WebDragSourceAction.
  • Update method signatures.
  • WebCoreSupport/WebDragClient.cpp:

(coreDragSourceActionMask): Add.
(kit): Add.

  • Convert from WebCore::DragSourceAction to WebDragSourceAction.

(WebDragClient::dragSourceActionMaskForPoint):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

  • WebCoreSupport/WebDragClient.h:

(WebDragClient::dragSourceActionMaskForPoint):

Source/WTF:

  • wtf/OptionSet.h:

(WTF::OptionSet::hasExactlyOneBitSet const): Add.

  • Move here from WebCore::ExactlyOneBitSet() in Source/WebCore/page/EventHandler.cpp.

(WTF::OptionSet::toSingleValue const): Add.

  • Use hasExactlyOneBitSet() to determine whether exactly one enum bitmask value can be returned.
11:47 AM Changeset in webkit [262912] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] inspector/page/setBootstrapScript-sub-frame.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=213087

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:01 AM Changeset in webkit [262911] by Alan Coon
  • 1 edit in branches/safari-609-branch/Source/WebCore/loader/FrameLoader.cpp

Unreviewed build fix. rdar://problem/64232759

Error: no member named 'protocolIsJavaScript' in 'WTF::URL'.

10:57 AM Changeset in webkit [262910] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

[iOS] editing/selection/ios/update-selection-after-overflow-scroll.html times out
​https://bugs.webkit.org/show_bug.cgi?id=213082
<rdar://problem/64228007>

Reviewed by Megan Gardner.

This test makes a programmatic selection, and then scrolls an overflow area with accelerated scrolling by using
UIHelper.immediateScrollElementAtContentPointToOffset(). This helper method hit-tests for a subscrollable
region, and then uses platform API to change the content offset. However, after timing changes in the system,
this hit-testing now fails because it ends up finding the callout menu that shows up after making the text
selection, and so scrolling fails.

Fix this by using (40, 40) instead of (150, 100) when hit-testing the child scroll view when scrolling.

  • editing/selection/ios/update-selection-after-overflow-scroll.html:
10:51 AM Changeset in webkit [262909] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-11
Reviewed by Geoffrey Garen.

Added a regression test.

  • fast/rendering/widget-removal-in-render-tree-builder-crash-expected.txt: Added.
  • fast/rendering/widget-removal-in-render-tree-builder-crash.html: Added.
10:23 AM Changeset in webkit [262908] by Alexey Shvayka
  • 4 edits in trunk

RegExp.prototype getters should throw on cross-realm access
​https://bugs.webkit.org/show_bug.cgi?id=213075

Reviewed by Saam Barati.

JSTests:

  • test262/expectations.yaml: Mark 14 test cases as passing.

Source/JavaScriptCore:

This patch makes RegExp.prototype getters throw TypeError when called on
RegExp.prototype object from another realm, aligning JSC with V8 and SpiderMonkey.

The spec [1] allows same-realm access to avoid breaking the web, while makes
RegExp.prototype an ordinary object (rather than RegExp instance) where possible.

[1]: ​https://tc39.es/ecma262/#sec-get-regexp.prototype.global (step 3.a)

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoGetterGlobal):
(JSC::regExpProtoGetterIgnoreCase):
(JSC::regExpProtoGetterMultiline):
(JSC::regExpProtoGetterDotAll):
(JSC::regExpProtoGetterSticky):
(JSC::regExpProtoGetterUnicode):
(JSC::regExpProtoGetterSource):

10:16 AM Changeset in webkit [262907] by Alan Coon
  • 2 edits in branches/safari-610.1.15.51-branch/Source/WebKit

Cherry-pick r262159. rdar://problem/64257403

Fix the engineering build on internal SDKs

  • Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Silenced a deprecation warning.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:16 AM Changeset in webkit [262906] by Alan Coon
  • 2 edits in branches/safari-610.1.15.50-branch/Source/WebKit

Cherry-pick r262159. rdar://problem/64257403

Fix the engineering build on internal SDKs

  • Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Silenced a deprecation warning.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [262905] by youenn@apple.com
  • 8 edits
    2 adds in trunk

End a remote MediaStreamTrack if its source is ended
​https://bugs.webkit.org/show_bug.cgi?id=213074

Reviewed by Eric Carlson.

Source/WebCore:

Make remote audio/video source observers of their webrtc source.
In case the webrtc source ends, end the source, thus its related tracks as well.
This is covered by the above test.

Test: webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html

  • platform/mediastream/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::~RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::startProducingData):
(WebCore::RealtimeIncomingAudioSource::stopProducingData):
(WebCore::RealtimeIncomingAudioSource::OnChanged):

  • platform/mediastream/RealtimeIncomingAudioSource.h:
  • platform/mediastream/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):
(WebCore::RealtimeIncomingVideoSource::~RealtimeIncomingVideoSource):
(WebCore::RealtimeIncomingVideoSource::startProducingData):
(WebCore::RealtimeIncomingVideoSource::stopProducingData):
(WebCore::RealtimeIncomingVideoSource::OnChanged):

  • platform/mediastream/RealtimeIncomingVideoSource.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::requestToEnd):
(WebCore::RealtimeMediaSource::end):

  • platform/mediastream/RealtimeMediaSource.h:

LayoutTests:

  • webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive-expected.txt: Added.
  • webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html: Added.
9:28 AM Changeset in webkit [262904] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on a timer
​https://bugs.webkit.org/show_bug.cgi?id=213063

Reviewed by Anders Carlsson.

Always use the RunLoop API for main thread tasks.

Previously, callOnMainThread sometimes scheduled a timer and sometimes
used the RunLoop. (Ironically, the timer behavior was added in r55816
with the intention to establish a single point of execution. Now, it has
the opposite effect.)

I picked the RunLoop API rather than the timer API because it moves us
closer to universally applying the RunLoop speedup in
​https://bugs.webkit.org/show_bug.cgi?id=202874. Also, it avoids
allocating a timer, which can be expensive.

  • wtf/cocoa/MainThreadCocoa.mm:

(WTF::scheduleDispatchFunctionsOnMainThread): The webIfExists() check
is a superset of the isWebThread() check, so we can just remove the
isWebThread() check when scheduling tasks to the web thread.
(WTF::timerFired): Deleted.
(WTF::postTimer): Deleted.

8:18 AM Changeset in webkit [262903] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] MediaUsageManagerCocoa should use a different USVideoUsage initializer
​https://bugs.webkit.org/show_bug.cgi?id=213058

Reviewed by Jer Noble.

No new tests, tested manually.

  • UIProcess/Media/cocoa/MediaUsageManagerCocoa.mm:

(WebKit::MediaUsageManagerCocoa::reset): Drive-by fix: don't call -stop unless the
element was playing.
(WebKit::MediaUsageManagerCocoa::updateMediaUsage): Use a different initializer so
we can pass in the state.

7:41 AM Changeset in webkit [262902] by Paulo Matos
  • 2 edits in trunk/Source/JavaScriptCore

Add missing include to JSONObject.cpp - non-unified build
​https://bugs.webkit.org/show_bug.cgi?id=213073

Reviewed by Adrian Perez de Castro.

  • runtime/JSONObject.cpp:
5:47 AM Changeset in webkit [262901] by Oriol Brufau
  • 19 edits
    50 adds in trunk/LayoutTests

[css-grid] Reimport WPT tests removed in r262809
​https://bugs.webkit.org/show_bug.cgi?id=213028

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

r261841 imported some WPT grid tests, but it was reverted in r262809.
This patch reimports these tests again.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-003-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-003.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-004-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-004.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-005-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-005.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-006-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-006.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-007-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-007.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-008-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-008.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-009-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-009.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-010-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-010.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-011-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-011.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-012-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-012.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-013-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-013.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-014-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-014.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-lr-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-vertical-rl-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-003-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-003.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-004-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-004.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-005-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-005.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-006-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-006.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-007-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-007.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-008-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-008.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-009-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-009.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-010-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-010.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-011-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-011.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-012-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-012.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-013-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-013.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-014-expected.xht: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-014.html: Added.
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-001.html:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002.html:
  • web-platform-tests/css/css-grid/grid-items/w3c-import.log:

LayoutTests:

Add failure expectations of the new tests.

2:41 AM Changeset in webkit [262900] by commit-queue@webkit.org
  • 4 edits in trunk

Improve url-setters.html WPT test
​https://bugs.webkit.org/show_bug.cgi?id=213046

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-11
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test expectation.

  • web-platform-tests/url/url-setters-expected.txt:

Source/WebCore:

Improve url-setters.html WPT test by testing for failure that can occur
when setting host or hostname [1].

[1] ​https://url.spec.whatwg.org/#host-state

  • html/URLDecomposition.cpp:

(WebCore::URLDecomposition::setHost):
(WebCore::URLDecomposition::setHostname):

1:58 AM Changeset in webkit [262899] by ChangSeok Oh
  • 10 edits in trunk/Source

[GTK] Implement button-press-event, button-release-event, and absolute-axis-event of GAMEPAD API.
​https://bugs.webkit.org/show_bug.cgi?id=133850

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This is a follow-up change after r261965, implementing the rest of missing GAMEPAD API
for the gtk port. Buttons and analog sticks of standard gamepads work with this change.

No new tests since existing tests can cover this change.

  • html/OffscreenCanvas.h:
  • platform/gamepad/manette/ManetteGamepad.cpp:

(WebCore::toStandardGamepadAxis):
(WebCore::onAbsoluteAxisEvent):
(WebCore::toStandardGamepadButton):
(WebCore::onButtonPressEvent):
(WebCore::onButtonReleaseEvent):
(WebCore::ManetteGamepad::ManetteGamepad):
(WebCore::ManetteGamepad::~ManetteGamepad):
(WebCore::ManetteGamepad::buttonPressedOrReleased):
(WebCore::ManetteGamepad::absoluteAxisChanged):

  • platform/gamepad/manette/ManetteGamepad.h:
  • platform/gamepad/manette/ManetteGamepadProvider.cpp:

(WebCore::ManetteGamepadProvider::ManetteGamepadProvider):
(WebCore::ManetteGamepadProvider::~ManetteGamepadProvider):
(WebCore::ManetteGamepadProvider::gamepadHadInput):
(WebCore::ManetteGamepadProvider::inputNotificationTimerFired):

  • platform/gamepad/manette/ManetteGamepadProvider.h:

Source/WebKit:

  • UIProcess/Gamepad/UIGamepadProvider.cpp: Add the OS(LINUX) guard.
  • UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp:

(WebKit::getWebPageProxy): Build fix. WebKitWebViewBase is used, not WebKitWebViewPrivate.

  • UIProcess/Gamepad/manette/UIGamepadProviderManette.cpp: Add the OS(LINUX) guard.
1:09 AM Changeset in webkit [262898] by svillar@igalia.com
  • 4 edits in trunk/Source/WebCore

[WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
​https://bugs.webkit.org/show_bug.cgi?id=212529

Reviewed by Youenn Fablet.

The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
to unsigned long from long as there was no point in using signed integers for that. However
we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
returned by requestAnimationFrame().

We landed ​https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
safely also replace signed by unsigned integers in our implementation.

No new tests as there is no change in functionality.

Reland r262718.

  • Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.

  • Modules/webxr/WebXRSession.h: Ditto.
  • Modules/webxr/WebXRSession.idl: Ditto.
12:52 AM Changeset in webkit [262897] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Setting the style at the last style change event to null should not create an ElementAnimationRareData object
​https://bugs.webkit.org/show_bug.cgi?id=213070
<rdar://problem/63841893>

Reviewed by Tim Horton.

In r262154 we added code that records the pre-animation style for a given element in
Style::TreeResolver::createAnimatedElementUpdate(), which is in Web Animations spec
parlance the style at the last style change event. This style is set on the backing
ElementAnimationRareData object for the given Element. For any element that did not
actually have any animations, we would set this style to null, but the function on
Element acting as a go-between would always create the backing ElementAnimationRareData
even though it would set a null value. We now only creaste the ElementAnimationRareData
object if there is a value to be stored, which fixes a performance regression in the
Speedometer2 test.

  • dom/Element.cpp:

(WebCore::Element::setLastStyleChangeEventStyle):

12:50 AM Changeset in webkit [262896] by svillar@igalia.com
  • 2 edits in trunk/Tools

Unreviewed, updated libsoup dependency in jhbuild.

  • wpe/jhbuild.modules:

Jun 10, 2020:

11:31 PM Changeset in webkit [262895] by commit-queue@webkit.org
  • 7 edits in trunk

[macOS]: The File Picker of the <input> file element should show the selection filter
​https://bugs.webkit.org/show_bug.cgi?id=212485

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-06-10
Reviewed by Darin Adler.

Source/WebCore/PAL:

Expose an SPI from CoreServcies to get all the UTIs known by the system.

  • pal/spi/cocoa/CoreServicesSPI.h:

Source/WebKit:

Add two private helpers to WKOpenPanelParameters.

  • UIProcess/API/Cocoa/WKOpenPanelParameters.mm:

(-[WKOpenPanelParameters _allowedFileExtensions]):
Returns an array of strings representing the allowed extensions.

(-[WKOpenPanelParameters _allowedFileExtensionsDescription]):
Returns a string representing a description for the allowed extensions.

  • UIProcess/API/Cocoa/WKOpenPanelParametersPrivate.h:

Tools:

Create a view with an NSPopupButton for the file extensions filter. Set
this view as the AccessoryView of the OpenPanel. Create a customized target
for the NSPopupButton to respond to changing its selection.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[FileExtensionsPopupTarget initWithOpenPanel:allowedFileExtensions:]):
(-[FileExtensionsPopupTarget popupAction:]):
(-[FileExtensionsPopupTarget dealloc]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController createFilterView:popupTarget:]):
(-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):

9:23 PM Changeset in webkit [262894] by Beth Dakin
  • 12 edits in trunk/Source

Replace instances of blacklist in WebCore with blocklist
​https://bugs.webkit.org/show_bug.cgi?id=213064

Reviewed by Tim Horton.

Source/WebCore:

  • dom/ExtensionStyleSheets.cpp:

(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const):

  • page/Frame.cpp:

(WebCore::Frame::injectUserScriptImmediately):

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesPatterns):

  • page/UserContentURLPattern.h:
  • page/UserScript.h:

(WebCore::UserScript::UserScript):
(WebCore::UserScript::blocklist const):
(WebCore::UserScript::encode const):
(WebCore::UserScript::decode):
(WebCore::UserScript::blacklist const): Deleted.

  • page/UserStyleSheet.h:

(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::blocklist const):
(WebCore::UserStyleSheet::blacklist const): Deleted.

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
(WebCore::GraphicsContextGLOpenGL::checkGPUStatus):

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlocklistedCodecs):
(WebCore::extendTextCodecMaps):
(WebCore::pruneBlacklistedCodecs): Deleted.

Source/WebKit:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::decode):

8:27 PM Changeset in webkit [262893] by commit-queue@webkit.org
  • 10 edits
    12 adds in trunk

Multiple SVG Filters Unexpectedly lightens image using linearRGB
​https://bugs.webkit.org/show_bug.cgi?id=212649

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-06-10
Reviewed by Myles C. Maxfield, Simon Fraser, Darin Adler

Source/WebCore:

Added color space conversion of input FilterEffect ImageBuffer and ImageData
for filters that directly manipulates pixel values. The conversion
is missing only on CG platforms because on CG platforms,
FilterEffect::transformResultColorSpace doesn't perform any operations
Its author assumed all filters are using CG ImageBuffers, and that
CG will handle the conversion which is not the case. The following filters
operates on the raw pixels inside an ImageBuffer, and this requires an explicit
color space conversion of the pixel values when the ImageData are retrieved
by calling FilterEffect::copy{Pre/Un}multipliedData().

The filters affected are feComponentTransfer, feComposite, feConvolveMatrix
feGaussianBlur, FELighting, feMorphology. The conversion is done
by CG, by drawing the input ImageBuffer to a new ImageBuffer that
has the correct color space tag. The ImageData is then pulled from
this new ImageBuffer and used in platformApplySoftware()

Tests: svg/filters/feComponentTransfer-clipped-expected.svg

svg/filters/feComponentTransfer-clipped.svg
svg/filters/feComposite-clipped-expected.svg
svg/filters/feComposite-clipped.svg
svg/filters/feConvolveMatrix-clipped-expected.svg
svg/filters/feConvolveMatrix-clipped.svg
svg/filters/feGaussianBlur-clipped-expected.svg
svg/filters/feGaussianBlur-clipped.svg
svg/filters/feLighting-clipped-expected.svg
svg/filters/feLighting-clipped.svg
svg/filters/feMorphology-clipped-expected.svg
svg/filters/feMorphology-clipped.svg

  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware): Modified function call to

FilterEffect::premultipliedResult, color space conversion is required on CG
platforms, so operatingColorSpace is passed in and input will be converted to
that color space

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware): Similarly, color space conversion

Required on CG color space conversion is required on CG
platforms, so operatingColorSpace is passed in and input will be converted to
that color space

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware): converting to operating space

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware): converting to operating space

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware): converting to operating space

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyDegenerate): converting to operating space
(WebCore::FEMorphology::platformApplySoftware): converting to operating space

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::unmultipliedResult): modified function signature so that

The Optional ColorSpace enum could be passed in to copyUnmultipliedResult()

(WebCore::FilterEffect::premultipliedResult): modified function signature so that

The Optional ColorSpace enum could be passed in to copyUnmultipliedResult()

(WebCore::FilterEffect::convertImageDataToColorSpace): helper function that takes an ImageData ptr

as input, put it into an ImageBuffer, and calls convertImageBufferToColorSpace to
perform color conversion, and returns the converted ImageData

(WebCore::FilterEffect::convertImageBufferToColorSpace): helper function that takes an ImageBuffer ptr

as input, create a new ImageBuffer with target color space, write input ImageBuffer to this new buffer
(CG backend handles the conversion) and returns the ImageData in the buffer.

(WebCore::FilterEffect::copyConvertedImageBufferToDestination): helper function that copies data from ImageBuffer

whose data is converted to the correct color space, to the destination array

(WebCore::FilterEffect::copyConvertedImageDataToDestination): helper function that copies data from ImageData

whose data is converted to the correct color space, to the destination array

(WebCore::FilterEffect::copyUnmultipliedResult): added an optional argument, colorSpace, which will be passed

into requiresAdditionalColorSpaceConversion, in order to determine if color space conversion is required
when obtaining the unmultiplied result. Then, added code to convert color space before writing to the
destination array

(WebCore::FilterEffect::copyPremultipliedResult): added an optional argument, colorSpace, which will be passed

into requiresAdditionalColorSpaceConversion, in order to determine if color space conversion is required
when obtaining the premultiplied result. Then, added code to convert color space before writing to the
destination array.

(WebCore::FilterEffect::requiresImageDataColorSpaceConversion): unction that only returns true

when 1) destination color space is non-null and is different than current color space AND

2) the code is running on CG platforms

This function will only be called inside copy{Un, Pre}multipliedResult, to address the issue
where color space is needed for filters that modifies raw pixels.

  • platform/graphics/filters/FilterEffect.h: Added function declarations

LayoutTests:

Added new tests that checks SVG render results for
feComponentTransfer, feComposite, feConvolveMatrix
feGaussianBlur, feMorphology and lighting

  • svg/filters/feComponentTransfer-clipped-expected.svg: Added.
  • svg/filters/feComponentTransfer-clipped.svg: Added.
  • svg/filters/feComposite-clipped-expected.svg: Added.
  • svg/filters/feComposite-clipped.svg: Added.
  • svg/filters/feConvolveMatrix-clipped-expected.svg: Added.
  • svg/filters/feConvolveMatrix-clipped.svg: Added.
  • svg/filters/feGaussianBlur-clipped-expected.svg: Added.
  • svg/filters/feGaussianBlur-clipped.svg: Added.
  • svg/filters/feLighting-clipped-expected.svg: Added.
  • svg/filters/feLighting-clipped.svg: Added.
  • svg/filters/feMorphology-clipped-expected.svg: Added.
  • svg/filters/feMorphology-clipped.svg: Added.
8:01 PM Changeset in webkit [262892] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[Line clamp] Do not apply the special anchor handling when the anchor content is visible after clamping
​https://bugs.webkit.org/show_bug.cgi?id=213052
<rdar://problem/59739131>

Reviewed by Simon Fraser.

Source/WebCore:

Line clamping tries to preserve the anchor text if it is at the bottom of the paragraph to support cases like "... Read more", where the "read more" is an actual link.
This patch makes sure that we only apply the special case handling if the anchor text get clamped.

Test: fast/flexbox/line-clamp-with-anchor-content-only.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

LayoutTests:

  • fast/flexbox/line-clamp-with-anchor-content-only-expected.html: Added.
  • fast/flexbox/line-clamp-with-anchor-content-only.html: Added.
7:40 PM Changeset in webkit [262891] by Wenson Hsieh
  • 3 edits in trunk/Source/WebKit

[iOS] editing/pasteboard/dom-paste tests consistently time out
​https://bugs.webkit.org/show_bug.cgi?id=213061
<rdar://problem/64211161>

Reviewed by Darin Adler.

On recent versions of iOS, system changes have moved the timing of the call to
-requestAutocorrectionContextWithCompletionHandler: when focusing an editable element. This results in a
consistently reproducible deadlock between the UI process and web process if a page tries to request
programmatic clipboard access during the click event (importantly, in the same runloop as element focus).

What ends up happening is that the autocorrection context is requested by the UI process shortly after the
(unbounded) sync IPC message for the DOM paste arrives, so we end up waiting forever for the sync-IPC-blocked
web process to respond. Normally this just results in a 1 second hang, and the DOM paste proceeds as normal.
However these layout tests purposefully opt out of sync IPC timeouts (precisely so that we can catch bugs like
this). See below for more details.

  • UIProcess/ios/WKContentViewInteraction.h:

Keep track of the most recent autocorrection context that arrived in the UI process.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):

Clear out the autocorrection context, in case the web process crashes.

(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

If the autocorrection context is requested while handling a DOM paste, we know that the latest autocorrection
context must be up to date, since the autocorrection context is computed and sent immediately before a DOM paste
request. Use this to immediately invoke the completion handler, without any sync IPC back to the web process.

(-[WKContentView _handleAutocorrectionContext:]):

7:20 PM Changeset in webkit [262890] by Ross Kirsling
  • 3 edits
    1 add in trunk

REGRESSION(r260697): [Intl] "missing script" locales like zh-TW are no longer mapped
​https://bugs.webkit.org/show_bug.cgi?id=213007

Reviewed by Darin Adler.

JSTests:

  • stress/intl-missing-script-locales.js: Added.

Source/JavaScriptCore:

addMissingScriptLocales was removed from IntlObject when changing our locale resolution to depend more directly
on ICU, but apparently even latest ICU won't perform this legacy "region implies script" mapping for us.

ICU 65+ does have uloc_openAvailableByType which will do the trick, so perhaps we should use this in the future,
but it still doesn't seem to help us with Collator, which has its own separate set of "available locales".

The exact set of locales which should be mapped is currently under discussion here:
​https://github.com/tc39/ecma402/issues/159
But the crux seems to be that we should ensure we have an xx-ZZ alias for all available xx-Yyyy-ZZ locales.

  • runtime/IntlObject.cpp:

(JSC::addScriptlessLocaleIfNeeded):
(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):

7:20 PM Changeset in webkit [262889] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[iOS] Option + Forward Delete should delete next word
​https://bugs.webkit.org/show_bug.cgi?id=213062
rdar://64225458

Patch by Hiro (mzp) Mizuno <​mzp@apple.com> on 2020-06-10
Reviewed by Daniel Bates.

Source/WebKit:

Implement support for pressing Option + Forward Delete to delete the next word. This makes text editing
in WebKit more closely match the platform conventions.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformAction:withSender:]): Handle _deleteForwardByWord.
(-[WKContentView _deleteForwardByWord]): Added.

LayoutTests:

Add tests to ensure that Option + Forward Delete delete to the next word.
Skip the tests for now until we have the UIKit fix <rdar://problem/63253983>.

  • fast/events/ios/key-command-delete-next-word-expected.txt: Added.
  • fast/events/ios/key-command-delete-next-word.html: Added.
  • platform/ios/TestExpectations: Skip tests for now
6:05 PM Changeset in webkit [262888] by Alan Coon
  • 8 edits in branches/safari-610.1.15.51-branch/Source

Versioning.

6:05 PM Changeset in webkit [262887] by Alan Coon
  • 6 edits
    1 copy
    1 add in branches/safari-609-branch

Cherry-pick r262870. rdar://problem/64232759

Improve CSP compliance under PSON
​https://bugs.webkit.org/show_bug.cgi?id=212995
<rdar://problem/62996186>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline an existing test, since CSP is now checked before any navigations performed by a form action.

  • web-platform-tests/content-security-policy/form-action/form-action-src-blocked.sub-expected.txt:

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html

The form submission logic was only considering CSP if the form
action was a JavaScript URL. This is incorrect, as CSP might
apply to any URL.

This is also covered by the existing form-action CSP tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): All URLs should be evaluted for compliance with CSP.

LayoutTests:

Add a new test to confirm that CSP rules are honored for form-action operations during process swap.
This also rebaselines an existing test, since CSP is now checked before any navigations performed by
a form action.

  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Rebaselined.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:46 PM Changeset in webkit [262886] by Alan Coon
  • 1 copy in tags/Safari-610.1.15.51.1

Tag Safari-610.1.15.51.1.

5:46 PM Changeset in webkit [262885] by Jonathan Bedard
  • 3 edits in trunk/WebKitLibraries

Catalyst WebKit apps continue to play audio after quitting (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=212981
<rdar://problem/57089471>

Unreviewed build fix.

  • WebKitPrivateFrameworkStubs/appletvos/13/RunningBoardServices.framework/RunningBoardServices.tbd:
  • WebKitPrivateFrameworkStubs/watchos/6/RunningBoardServices.framework/RunningBoardServices.tbd:
5:41 PM Changeset in webkit [262884] by Jonathan Bedard
  • 2 edits
    1 delete in trunk/Tools

Generalize configure-xcode-for-ios-development (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=207043
<rdar://problem/63946933>

Reviewed by Darin Adler.

  • EWSTools/start-queue-mac.sh: Use configure-xcode-for-embedded-development over configure-xcode-for-ios-development.
  • Scripts/configure-xcode-for-ios-development: Removed.
5:36 PM Changeset in webkit [262883] by Alan Coon
  • 2 edits in branches/safari-609-branch/Source/WebKit

Cherry-pick r262850. rdar://problem/64226899

[iOS] Add entitlement for PAC exceptions
​https://bugs.webkit.org/show_bug.cgi?id=213027
<rdar://problem/63985737>

Reviewed by Brent Fulgham.

On iOS, add entitlement for PAC exceptions.

  • Scripts/process-entitlements.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:36 PM Changeset in webkit [262882] by Alan Coon
  • 7 edits
    2 adds in branches/safari-609-branch

Cherry-pick r262841. rdar://problem/64226920

REGRESSION(r262798): fast/mediastream/media-stream-track-interrupted.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=213011

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, a source that is muted and for which its observers get ended will not be ended.
This is a potential issue as the source can get unmuted, in which case, the audio shared unit might be asked to restart.
This is crashing in debug as we would not have the AudioSession correct category for audio capture.

Test: fast/mediastream/track-ended-while-muted.html
Also covered by fast/mediastream/media-stream-track-interrupted.html no longer flakily crashing in debug.

  • platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::requestToEnd): End the source even if muted.
  • platform/mediastream/RealtimeMediaSource.h:
  • testing/Internals.cpp: (WebCore::Internals::isMediaStreamSourceEnded const):
  • testing/Internals.h:
  • testing/Internals.idl: Add necessary test infrastructure.

LayoutTests:

  • fast/mediastream/track-ended-while-muted-expected.txt: Added.
  • fast/mediastream/track-ended-while-muted.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [262881] by Alan Coon
  • 14 edits in branches/safari-609-branch

Apply patch. rdar://problem/64226920

5:33 PM Changeset in webkit [262880] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] CRASH: imported/w3c/web-platform-tests/remote-playback/watch-availability-initial-callback.html is flaky crashing
​https://bugs.webkit.org/show_bug.cgi?id=213044
<rdar://problem/62317723>

Reviewed by Eric Carlson.

Add null-checks around previously non-null-checked derefs of WeakPtr<HTMLMediaElement>.

  • Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::watchAvailability):
(WebCore::RemotePlayback::shouldPlayToRemoteTargetChanged):
(WebCore::RemotePlayback::playbackTargetPickerWasDismissed):

5:28 PM Changeset in webkit [262879] by sihui_liu@apple.com
  • 4 edits in trunk

Text manipulation does not observe inserted elements that are invisible
​https://bugs.webkit.org/show_bug.cgi?id=213057
<rdar://problem/63768253>

Reviewed by Wenson Hsieh.

Source/WebCore:

TextManipulationController gets notification when renderer of an element is created and starts observing the
element. It currently sets the observing range to be the visible start position and visible end position of the
element. When the invisible content becomes visible later, TextManipulationController does not get notification
and will miss the content. Therefore, TextManipulationController should use the actual start and end positions
of the element for range.

Test: TextManipulation.StartTextManipulationFindsInsertedClippedText

  • editing/TextManipulationController.cpp:

(WebCore::makeHashablePositionRange):
(WebCore::TextManipulationController::scheduleObservationUpdate):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

5:15 PM Changeset in webkit [262878] by ggaren@apple.com
  • 45 edits in trunk

Some style improvements to main thread code
​https://bugs.webkit.org/show_bug.cgi?id=213051

Reviewed by Darin Adler.

Source/WebCore:

Updated for rename.

  • WebCore.order:
  • platform/ios/wak/WebCoreThread.mm:

(StartWebThread):

Source/WebDriver:

Updated for rename.

  • WebDriverService.cpp:

(WebDriver::WebDriverService::run):

Source/WebKit:

Updated for rename.

  • Shared/Cocoa/WebKit2InitializeCocoa.mm:

(WebKit::runInitializationCode):
(WebKit::InitializeWebKit2):

  • Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

Source/WebKitLegacy/mac:

Updated for rename.

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

  • Misc/WebCache.mm:

(+[WebCache initialize]):

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

  • Misc/WebIconDatabase.mm:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]):

  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

  • WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]):

  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

  • WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

  • WebView/WebView.mm:

(+[WebView initialize]):

  • WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKitLegacy/win:

Updated for rename.

  • WebView.cpp:

(WebView::WebView):

Source/WTF:

  • wtf/RunLoop.cpp:

(WTF::RunLoop::initializeMain): Renamed initializeMainRunLoop => initializeMain
to match the getter's name.
(WTF::RunLoop::initializeWeb): Samesies.
(WTF::RunLoop::webIfExists): Added an IfExists accessor for use in
scheduleDispatchFunctionsOnMainThread().
(WTF::RunLoop::initializeMainRunLoop): Deleted.
(WTF::RunLoop::initializeWebRunLoop): Deleted.

  • wtf/RunLoop.h:
  • wtf/cocoa/MainThreadCocoa.mm:

(WTF::scheduleDispatchFunctionsOnMainThread): Use RunLoop::webIfExists()
to check for the web thread run loop, since that's more explicit than
checking a pthread variable.

(WTF::isWebThread): Renamed mainThreadPthread => webThreadPthread because
it's the web thread. Changed style on globals to "s_" for consistency.
Removed mainThreadNSThread because it was unused.
(WTF::initializeApplicationUIThread):
(WTF::initializeWebThread):
(WTF::canCurrentThreadAccessThreadLocalData):

Tools:

Updated for rename.

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(ApplicationManifestParserTest::SetUp):

  • TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:

(TestWebKitAPI::ComplexTextControllerTest::SetUp):

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::ContentExtensionTest::SetUp):

  • TestWebKitAPI/Tests/WebCore/DNS.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(initializeInAppBrowserPrivacyTestSettings):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

5:10 PM Changeset in webkit [262877] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=212714

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-06-10
Reviewed by Geoffrey Garen.

Replaced call to WTFMove(widgetNewParentMap()) with std::exchange(widgetNewParentMap(), { }) in the
WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), thereby making it explicit to set the source map empty.

Test would be added later.

  • rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

5:07 PM Changeset in webkit [262876] by Jonathan Bedard
  • 3 edits
    1 copy in trunk/Tools

results.webkit.org: Health check should access redis and Cassandra
​https://bugs.webkit.org/show_bug.cgi?id=212899
<rdar://problem/64118077>

Reviewed by Stephanie Lewis.

  • resultsdbpy/resultsdbpy/example/main.py:

(health): Check the health status of the model.

  • resultsdbpy/resultsdbpy/model/model.py:

(Model.HealthTable):
(Model.init): Construct a Cassandra table used to check the health of our Cassandra connection.
(Model.healthy): Make both a read and write connection to our two database dependencies so that if
our connection to those databases fails, an instance will be forced to restart.

  • resultsdbpy/resultsdbpy/model/model_unittest.py: Added.

(ModelTest):
(ModelTest.init_database):
(ModelTest.test_health):

5:00 PM Changeset in webkit [262875] by Jonathan Bedard
  • 3 edits in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h (Follow-up fix 2)
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Unreviewed build fix.

  • UIProcess/ios/forms/WKNumberPadViewController.mm:

(-[WKNumberPadViewController addContentViewAnimations:]): Correct APPLE_INTERNAL_SDK macro.

  • UIProcess/ios/forms/WKQuickboardListViewController.mm:

(-[WKQuickboardListViewController initWithDelegate:]): Ditto.

4:58 PM Changeset in webkit [262874] by Fujii Hironori
  • 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations:
  • platform/wincairo/fast/text/justify-ideograph-leading-expansion-expected.txt:
4:38 PM Changeset in webkit [262873] by Alan Coon
  • 1 copy in tags/Safari-610.1.15.50.3

Tag Safari-610.1.15.50.3.

4:15 PM Changeset in webkit [262872] by ysuzuki@apple.com
  • 3 edits
    2 adds in trunk

[JSC] JSCallbackObject::deleteProperty should redirect to Parent::deletePropertyByIndex if propertyName is index
​https://bugs.webkit.org/show_bug.cgi?id=213041
<rdar://problem/64204300>

Reviewed by Darin Adler.

Source/JavaScriptCore:

We have an infinite recursion here.

-> JSCallbackObject::deletePropertyByIndex

-> JSCell::deleteProperty

-> JSCallbackObject::deleteProperty

-> JSObject::deleteProperty

-> JSCallbackObject::deletePropertyByIndex

When propertyName in JSCallbackObject::deleteProperty is an index, we should go to JSObject::deletePropertyByIndex instead of JSObject::deleteProperty.

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::deleteProperty):

LayoutTests:

  • js/dom/callbackobject-delete-should-not-infinite-recursion-expected.txt: Added.
  • js/dom/callbackobject-delete-should-not-infinite-recursion.html: Added.
4:14 PM Changeset in webkit [262871] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[ Mac ] mathml/scripts-removeChild.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=208574
<rdar://problem/60041327>

Unreviewed test gardening.

Can't reproduce flakiness anymore.

  • platform/mac/TestExpectations:
4:11 PM Changeset in webkit [262870] by Brent Fulgham
  • 6 edits
    1 copy
    1 add in trunk

Improve CSP compliance under PSON
​https://bugs.webkit.org/show_bug.cgi?id=212995
<rdar://problem/62996186>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline an existing test, since CSP is now checked before any navigations performed by a form action.

  • web-platform-tests/content-security-policy/form-action/form-action-src-blocked.sub-expected.txt:

Source/WebCore:

Tests: http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html

The form submission logic was only considering CSP if the form
action was a JavaScript URL. This is incorrect, as CSP might
apply to any URL.

This is also covered by the existing form-action CSP tests.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm): All URLs should be evaluted for
compliance with CSP.

LayoutTests:

Add a new test to confirm that CSP rules are honored for form-action operations during process swap.
This also rebaselines an existing test, since CSP is now checked before any navigations performed by
a form action.

  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt: Rebaselined.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked-expected.txt.
  • http/tests/security/contentSecurityPolicy/1.1/form-action-src-self-blocked.html: Added.
4:11 PM Changeset in webkit [262869] by Russell Epstein
  • 2 edits in branches/safari-610.1.15.51-branch/Source/WebKit

Cherry-pick r262864. rdar://problem/64223970

Crash growing a CFData with incremental PDF loading.
<rdar://problem/63670403> and ​https://bugs.webkit.org/show_bug.cgi?id=213035

Reviewed by Alex Christensen.

No test - No reliable way to trigger.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::ensureDataBufferLength): When you call CFDataCreateMutable with a size other than 0, your data object can never grow beyond that size. And, in fact, CFData will crash on purpose when this is attempted. So always create our mutable CFDatas with size 0 even if we immediately plan to grow them.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@262864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:05 PM Changeset in webkit [262868] by Jonathan Bedard
  • 2 edits in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Unreviewed build fix.

  • Platform/spi/watchos/PepperUICoreSPI.h: Add PUICPickerView headers.
4:04 PM Changeset in webkit [262867] by Alan Coon
  • 1 edit in branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h

Unreviewed build fix. rdar://problem/63902456

Undeclared identifier 'm_unexpectedActivityTimer'.

3:37 PM Changeset in webkit [262866] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (r262858): Fix macOS build when building EndowmentStateTracker.mm

  • UIProcess/EndowmentStateTracker.mm:
  • Move #if PLATFORM(IOS_FAMILY) to fix macOS build.
3:34 PM Changeset in webkit [262865] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] Return early from preference change notification handler if there is no observer
​https://bugs.webkit.org/show_bug.cgi?id=213050

Reviewed by Darin Adler.

Currently, the observer member is checked inside the loop iterating over all the keys,
but this check should be moved outside of the loop.

No new tests, since this is not a change in behavior.

  • UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]):

3:23 PM Changeset in webkit [262864] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Crash growing a CFData with incremental PDF loading.
<rdar://problem/63670403> and ​https://bugs.webkit.org/show_bug.cgi?id=213035

Reviewed by Alex Christensen.

No test - No reliable way to trigger.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::ensureDataBufferLength): When you call CFDataCreateMutable with a size other than 0,

your data object can never grow beyond that size.
And, in fact, CFData will crash on purpose when this is attempted.
So always create our mutable CFDatas with size 0 even if we immediately plan to grow them.

3:03 PM Changeset in webkit [262863] by ggaren@apple.com
  • 4 edits in trunk/Source/WTF

[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on NSObject methods
​https://bugs.webkit.org/show_bug.cgi?id=213043

Reviewed by Simon Fraser.

Original patch by Sihui Liu.

From ​https://bugs.webkit.org/show_bug.cgi?id=202874, this is the subset
of Sihui's patch that unifies some of RunLoop and callOnMainThread.

My goal is to simplify the code, and shrink the diff when testing
CFRunLoopSource1 in the future.

  • wtf/RunLoop.cpp:

(WTF::RunLoop::initializeWebRunLoop):
(WTF::RunLoop::web):

  • wtf/RunLoop.h:
  • wtf/cocoa/MainThreadCocoa.mm:

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::initializeWebThread):
(-[JSWTFMainThreadCaller call]): Deleted.

2:47 PM Changeset in webkit [262862] by Jonathan Bedard
  • 3 edits
    1 add in trunk/Source/WebKit

WebKit: Add ClockKitSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=212994
<rdar://problem/64181092>

Reviewed by Wenson Hsieh.

No new tests, behavior unchanged.

  • Platform/spi/watchos: Added.
  • Platform/spi/watchos/ClockKitSPI.h: Added.
  • UIProcess/ios/forms/WKTimePickerViewController.mm: Import ClockKitSPI.h and UIKitSPI.h.
  • WebKit.xcodeproj/project.pbxproj: Include ClockKitSPI.
2:44 PM Changeset in webkit [262861] by BJ Burg
  • 6 edits in trunk/Source

WebDriver on non-iOS ports cannot perform ActionChain which has scrolling down to the element and click it
​https://bugs.webkit.org/show_bug.cgi?id=208232
<rdar://problem/59859491>

Reviewed by Devin Rousso.

Source/WebCore:

  • platform/ScrollView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents const):
Create a version of this function that works with FloatPoint.

Source/WebKit:

  • UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
The provided coordinates are in LayoutViewport coordinate system, which does
not take topContentInset into account. Add back in the topContentInset
when translating to flipped window coordinates.

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):
The calculations of element bounds and IVCP have an incorrect handling of
root coordinates as contents/absolute coordinates. Add the missing conversion.

2:26 PM Changeset in webkit [262860] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit

[iOS] Update sandbox rules for correct sanitizer paths in current OS releases
​https://bugs.webkit.org/show_bug.cgi?id=213040
<rdar://problem/64187043>

Reviewed by Per Arne Vollan.

Update the sandbox rules on iOS platforms to allow access to the
new system locations for Asan libraries.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
2:17 PM Changeset in webkit [262859] by keith_miller@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests should skip tests marked as slow in quick mode.
​https://bugs.webkit.org/show_bug.cgi?id=213042

Reviewed by Yusuke Suzuki.

  • Scripts/run-jsc-stress-tests:
1:49 PM Changeset in webkit [262858] by jer.noble@apple.com
  • 13 edits
    2 adds in trunk

Catalyst WebKit apps continue to play audio after quitting
​https://bugs.webkit.org/show_bug.cgi?id=212981
<rdar://problem/57089471>

Reviewed by Chris Dumez.

Source/WebKit:

RunningBoard will track whether a process (and it's associated child processes) are "user-visible" by
granting those processes an "endowment", similar to the existing endowment for application visibility.
Track changes to these endowments using a RBSProcessMonitor, and for Catalyst apps, react to losing the
"user-visible" endowment by suspending all media playback.

Move all the endowment-related code into a new class, EndowmentStateTracker, which is a singleton object
that can have mulitple WebPageProxy clients. Update references to the previously global static
isApplicationForeground() function to refer to EndowmentStateTracker instead.

Drive-by fix: move some iOS-only functions in WebPageProxy.cpp into WebPageProxyIOS.mm.

  • UIProcess/ApplicationStateTracker.h:
  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::isApplicationForeground): Deleted.

  • UIProcess/EndowmentStateTracker.h: Added.

(WebKit::EndowmentStateTracker::isVisible const):
(WebKit::EndowmentStateTracker::isUserFacing const):

  • UIProcess/EndowmentStateTracker.mm: Added.

(WebKit::handleForPID):
(WebKit::EndowmentStateTracker::isApplicationForeground):
(WebKit::EndowmentStateTracker::isApplicationUserFacing):
(WebKit::EndowmentStateTracker::singleton):
(WebKit::EndowmentStateTracker::EndowmentStateTracker):
(WebKit::EndowmentStateTracker::addClient):
(WebKit::EndowmentStateTracker::removeClient):
(WebKit::EndowmentStateTracker::setIsUserFacing):
(WebKit::EndowmentStateTracker::setIsVisible):

  • UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::processWillBecomeSuspended): Deleted.
(WebKit::WebPageProxy::processWillBecomeForeground): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isApplicationVisible):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::processWillBecomeSuspended):
(WebKit::WebPageProxy::processWillBecomeForeground):
(WebKit::WebPageProxy::isUserFacingChanged):
(WebKit::WebPageProxy::isVisibleChanged):

  • WebKit.xcodeproj/project.pbxproj:

Source/WTF:

Add the ability to call copyToVector() on a WeakHashSet. This requires two changes:

  • A template specialization that returns a Vector<WeakPtr<T>> from copyToVector()
  • A template specialization that calls calculateSize() rather than size() on the object being iterated upon.
  • wtf/WeakHashSet.h:

(WTF::copyToVector):

WebKitLibraries:

  • WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd:
1:49 PM Changeset in webkit [262857] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, reverting r262718.
​https://bugs.webkit.org/show_bug.cgi?id=213047

Broke WPE Debug too

Reverted changeset:

"[WebXR] Pass an unsigned long to cancelAnimationCallback() as
handle"
​https://bugs.webkit.org/show_bug.cgi?id=212529
​https://trac.webkit.org/changeset/262718

1:37 PM Changeset in webkit [262856] by graouts@webkit.org
  • 6 edits in trunk

Subframes should not autosize independently
​https://bugs.webkit.org/show_bug.cgi?id=212984
<rdar://problem/64175493>

Reviewed by Simon Fraser.

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::enableAutoSizeMode):

Source/WebKit:

Ensure we only call FrameView::enableSizeToContentAutoSizeMode() for the main frame.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:

(TEST): Added test for <object>.

1:36 PM Changeset in webkit [262855] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, WPE Debug build fix attempt after r262838.

Second attempt. :) Still broken because of r262718 though...

  • platform/xr/openxr/PlatformXROpenXR.cpp:
1:34 PM Changeset in webkit [262854] by Jonathan Bedard
  • 13 edits
    2 adds in trunk/Source/WebKit

WebKit:Add PepperUICoreSPI.h
​https://bugs.webkit.org/show_bug.cgi?id=212996
<rdar://problem/64182627>

Reviewed by Tim Horton.

No new tests, behavior unchanged.

  • Platform/spi/watchos: Added.
  • Platform/spi/watchos/PepperUICoreSPI.h: Added.
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm: Include PepperUICoreSPI header.
  • UIProcess/ios/WKScrollView.mm: Ditto.
  • UIProcess/ios/forms/WKDatePickerViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.
  • UIProcess/ios/forms/WKFocusedFormControlView.mm: Ditto.
  • UIProcess/ios/forms/WKNumberPadView.mm: Include PepperUICoreSPI header.
  • UIProcess/ios/forms/WKNumberPadViewController.h: Remove headers duplicated in PepperUICoreSPI.h.
  • UIProcess/ios/forms/WKNumberPadViewController.mm: Ditto.

(-[WKNumberPadViewController addContentViewAnimations:]): Limit addAnimation to Internal builds.

  • UIProcess/ios/forms/WKQuickboardListViewController.h: Include PepperUICoreSPI header.
  • UIProcess/ios/forms/WKQuickboardListViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.

(-[WKQuickboardListViewController initWithDelegate:]):

  • UIProcess/ios/forms/WKSelectMenuListViewController.mm: Remove headers duplicated in PepperUICoreSPI.h.
  • UIProcess/ios/forms/WKTextInputListViewController.mm: Ditto.
  • WebKit.xcodeproj/project.pbxproj: Add PepperUICoreSPI.h.
1:31 PM Changeset in webkit [262853] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

Unreviewed, WPE Debug build fix attempt after r262838.

Still broken because of r262718 though...

  • platform/xr/openxr/PlatformXROpenXR.cpp:
1:19 PM Changeset in webkit [262852] by Ryan Haddad
  • 2 edits in trunk/LayoutTests/imported/w3c

REGRESSION(r262809): [ macOS iOS ] imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=213026

Unreviewed test gardening.

  • web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001-expected.txt:

Check in a new baseline that accounts for the failing subtests to get the bots to green.

1:19 PM Changeset in webkit [262851] by Ryan Haddad
  • 2 edits in trunk/Tools

[Mojave] Flaky API Test: TestWebKitAPI.WebKitLegacy.CrossPartitionFileSchemeAccess
​https://bugs.webkit.org/show_bug.cgi?id=206956

Unreviewed test gardening.

  • TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Disable this test for Mojave.
12:31 PM Changeset in webkit [262850] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Add entitlement for PAC exceptions
​https://bugs.webkit.org/show_bug.cgi?id=213027
<rdar://problem/63985737>

Reviewed by Brent Fulgham.

On iOS, add entitlement for PAC exceptions.

  • Scripts/process-entitlements.sh:
12:26 PM Changeset in webkit [262849] by James Savage
  • 6 edits in trunk/Source/WebKit

Swift Overlay API refinements
​https://bugs.webkit.org/show_bug.cgi?id=212939
<rdar://problem/64140013>

Reviewed by Darin Adler.

This patch cleans up some inconsistencies in the various Swift projections,
and modifies JavaScript evaluation callbacks to be optional to account for
scripts which may not evaluate to a useful result (such as ones that simply
modify the DOM without reporting a status). It also standardizes on using
completionHandler as an argument label to match the rest of WebKit API, and
the majority of the Swift API refinements.

It also fixes a module issue where the WebKit.h umbrella was missing an
import of WKScriptReplyWithMessageHandler.h, making the type unusable from
Swift source files/

  • Shared/API/Cocoa/WebKit.h: Add missing header.
  • UIProcess/API/Cocoa/WebKitSwiftOverlay.swift:

(callAsyncJavaScript(_:arguments:in:completionHandler:)): Rename completion

argument, and make optional. Note: Optional closures are implicitly
@escaping, making the annotation redundant and incompatible, so it must
be removed. In Swift, Optional.map()'s closure is invoked iff the Optional
contains some value, and the result of that transform is returned, else
nil is propagated. This allows us to apply the closure transform if the
client value is non-nil, without using intermediary variables or if/let.

(evaluateJavaScript(_:in:completionHandler:)): Ditto.

  • SwiftOverlay/Tests/WebKitTests.swift:

(WebKitTests.testAPI): Update names to reflect changes.

  • SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything (Catalyst).xcscheme:

Ensure that the unit test files get built as part of Build & Run, so that
any changes to names get flagged without even running the tests.

  • SwiftOverlay/WebKitSwiftOverlay.xcodeproj/xcshareddata/xcschemes/Everything.xcscheme:

Ditto.

12:20 PM Changeset in webkit [262848] by Devin Rousso
  • 8 edits in trunk/Source/WebInspectorUI

Web Inspector: text inputs should not spellcheck
​https://bugs.webkit.org/show_bug.cgi?id=213032
<rdar://problem/64195429>

Reviewed by Brian Burg.

  • UserInterface/Base/Main.js:

(WI._handleDeviceSettingsTabBarButtonClicked.showUserAgentInput):

  • UserInterface/Views/BoxShadowEditor.js:

(WI.BoxShadowEditor):

  • UserInterface/Views/CookiePopover.js:

(WI.CookiePopover.prototype.show.createInputRow):

  • UserInterface/Views/EditableDataGridNode.js:

(WI.EditableDataGridNode.prototype.createCellContent):

  • UserInterface/Views/InputPopover.js:

(WI.InputPopover.prototype.show):

  • UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection.prototype._addProbeButtonClicked):

  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createConsoleSettingsView):

12:08 PM Changeset in webkit [262847] by caitp@igalia.com
  • 1 edit
    1 add in trunk/JSTests

[JSC] add stress test for op_get_private_name
​https://bugs.webkit.org/show_bug.cgi?id=213024

Reviewed by Mark Lam.

  • stress/get-private-name.js: Added.
12:04 PM Changeset in webkit [262846] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

ASSERTION FAILED: suspendedState == State::Running in WebKit::WebResourceLoadStatisticsStore::suspend
​https://bugs.webkit.org/show_bug.cgi?id=213031
<rdar://problem/64131092>

Reviewed by Chris Dumez.

There is a race condition if two calls are made to
WebResourceLoadStatisticsStore::suspend() simultanously.
WebResourceLoadStatisticsStore::resume() notifies the background
thread to continue and releases a lock, then sometimes the second call
to suspend obtains the lock and updates the suspendedState variable
before the background thread resumes and checks the result. This patch allows the
suspendedState to be either State::Running or State::WillSuspend to
account for this.

No new tests, this should fix http/wpt/service-workers/service-worker-spinning-fetch.https.html.

  • NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::suspend):

10:59 AM Changeset in webkit [262845] by achristensen@apple.com
  • 4 edits in trunk

Revert r259770
​https://bugs.webkit.org/show_bug.cgi?id=210097
<rdar://problem/64175992>

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(TEST):

10:42 AM Changeset in webkit [262844] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Add some null checks in PDFPlugin::updatePageAndDeviceScaleFactors
​https://bugs.webkit.org/show_bug.cgi?id=213009
<rdar://problem/63756100>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-06-10
Reviewed by Chris Dumez.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors):

9:51 AM Changeset in webkit [262843] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

BaseAudioSharedUnit does not need to restart its audio unit at resume time.
​https://bugs.webkit.org/show_bug.cgi?id=213021

Reviewed by Eric Carlson.

Removing a case that should not happen, and was guarded by ASSERT.
Keeping ASSERT to make sure we do not break this assumption.

  • platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::resume):
(WebCore::BaseAudioSharedUnit::suspend):

9:20 AM Changeset in webkit [262842] by Devin Rousso
  • 3 edits
    2 adds in trunk

Web Inspector: XHR request with same URL as main resource will hide the main resource request
​https://bugs.webkit.org/show_bug.cgi?id=212850
<rdar://problem/33072149>

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype._addNewResourceToFrameOrTarget):
When creating a new resource, don't re-use the frame's main resource if the URL matches.

LayoutTests:

  • inspector/network/request-main-url.html: Added.
  • inspector/network/request-main-url-expected.txt: Added.
9:02 AM Changeset in webkit [262841] by youenn@apple.com
  • 7 edits
    2 adds in trunk

REGRESSION(r262798): fast/mediastream/media-stream-track-interrupted.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=213011

Reviewed by Eric Carlson.

Source/WebCore:

Before the patch, a source that is muted and for which its observers get ended will not be ended.
This is a potential issue as the source can get unmuted, in which case, the audio shared unit might be asked to restart.
This is crashing in debug as we would not have the AudioSession correct category for audio capture.

Test: fast/mediastream/track-ended-while-muted.html
Also covered by fast/mediastream/media-stream-track-interrupted.html no longer flakily crashing in debug.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::requestToEnd):
End the source even if muted.

  • platform/mediastream/RealtimeMediaSource.h:
  • testing/Internals.cpp:

(WebCore::Internals::isMediaStreamSourceEnded const):

  • testing/Internals.h:
  • testing/Internals.idl:

Add necessary test infrastructure.

LayoutTests:

  • fast/mediastream/track-ended-while-muted-expected.txt: Added.
  • fast/mediastream/track-ended-while-muted.html: Added.
8:35 AM Changeset in webkit [262840] by clopez@igalia.com
  • 28 edits
    8 adds
    12 deletes in trunk/LayoutTests

Layout tests outside of the WPT import should not use resources from it
​https://bugs.webkit.org/show_bug.cgi?id=212661

Reviewed by Youenn Fablet.

Some layout tests were using resource files from the imported WPT tests.
This is an issue because updating the WPT tests may break this tests in the future.

To fix this the used resource files are copied inside the main folder of each test
and the tests modified to use them.

On top of that, some tests are de-duplicates (in favor of the WPT versions, which are the same).
This is the list of tests de-duplicated:
canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.emptysrc.html
canvas/philip/tests/2d.drawImage.incomplete.nosrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.nosrc.html
canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.removedsrc.html
canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.emptysrc.html
canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.removedsrc.html
fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html -> imported/w3c/web-platform-tests/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html

  • canvas/philip/tests/2d.drawImage.incomplete.emptysrc-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html: Removed.
  • canvas/philip/tests/2d.drawImage.incomplete.nosrc-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.incomplete.nosrc.html: Removed.
  • canvas/philip/tests/2d.drawImage.incomplete.removedsrc-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html: Removed.
  • canvas/philip/tests/2d.pattern.image.incomplete.emptysrc-expected.txt: Removed.
  • canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html: Removed.
  • canvas/philip/tests/2d.pattern.image.incomplete.removedsrc-expected.txt: Removed.
  • canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html: Removed.
  • fast/css/resources/shadow-helper.js: Added.

(getElementByShadowIds):
(ceClass.):
(installCustomElement):

  • fast/css/shadow-parts/exportparts-syntax.html:
  • fast/css/shadow-parts/invalidation-class-before-after.html:
  • fast/css/shadow-parts/invalidation-class-descendant-combinator-export.html:
  • fast/css/shadow-parts/invalidation-class-descendant-combinator.html:
  • fast/css/shadow-parts/invalidation-class-sibling-combinator-export.html:
  • fast/css/shadow-parts/invalidation-class-sibling-combinator.html:
  • fast/custom-elements/DOMImplementation-createDocument.html:
  • fast/custom-elements/adopting-from-frameless-document.html:
  • fast/custom-elements/disconnected-callback-in-detached-iframe.html:
  • fast/custom-elements/document-createElementNS.html:
  • fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html:
  • fast/custom-elements/perform-microtask-checkpoint-before-construction.html:
  • fast/custom-elements/reactions-for-webkit-extensions.html:
  • fast/custom-elements/resources/custom-elements-helpers.js: Added.

(create_window_in_test):
(test_with_window):
(prototype.attributeChangedCallback):
(prototype.connectedCallback):
(prototype.disconnectedCallback):
(prototype.adoptedCallback):
(return.takeLog):
(create_constructor_log):
(assert_constructor_log_entry):
(create_connected_callback_log):
(assert_connected_log_entry):
(create_disconnected_callback_log):
(assert_disconnected_log_entry):
(assert_adopted_log_entry):
(create_adopted_callback_log):
(create_attribute_changed_callback_log):
(assert_attribute_log_entry):
(define_new_custom_element.CustomElement):
(define_new_custom_element.CustomElement.prototype.attributeChangedCallback):
(define_new_custom_element.CustomElement.prototype.connectedCallback):
(define_new_custom_element.CustomElement.prototype.disconnectedCallback):
(define_new_custom_element.CustomElement.prototype.adoptedCallback):
(define_new_custom_element.return.takeLog):
(CustomElement):
(CustomElement.prototype.attributeChangedCallback):
(CustomElement.prototype.connectedCallback):
(CustomElement.prototype.disconnectedCallback):
(CustomElement.prototype.adoptedCallback):

  • fast/custom-elements/resources/reactions.js: Added.

(testNodeConnector):
(testNodeDisconnector):
(testInsertingMarkup):
(testParsingMarkup):
(prototype.test):
(testReflectBooleanAttribute):
(testAttributeAdder):

  • fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html:
  • fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html:
  • fast/images/resources/green-256x256.png: Added.
  • fast/images/sizes-dynamic-001-expected.html:
  • fast/images/sizes-dynamic-001.html:
  • fast/images/sizes-dynamic-002-expected.html:
  • fast/images/sizes-dynamic-002.html:
  • fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees-expected.txt: Removed.
  • fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html: Removed.
  • mathml/non-core/frac-linethickness-001-expected.html:
  • mathml/non-core/frac-linethickness-001.html:
  • mathml/non-core/frac-linethickness-002-expected.html:
  • mathml/non-core/frac-linethickness-002.html:
  • mathml/non-core/lengths-1.html:
  • mathml/non-core/lengths-2.html:
  • mathml/non-core/lengths-3.html:
  • mathml/presentation/radical-bar-visibility.html:
  • mathml/resources/fraction-rulethickness10000.woff: Added.
  • mathml/resources/radical-degreebottomraisepercent25-rulethickness1000.woff: Added.
  • mathml/resources/xheight500.woff: Added.
7:30 AM Changeset in webkit [262839] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

[iPadOS] editing/selection/ios/toggle-callout-bar-after-tap-in-selected-non-editable-text.html times out
​https://bugs.webkit.org/show_bug.cgi?id=213010
<rdar://problem/64182061>

Reviewed by Tim Horton.

This test times out because the second tap (which is intended to toggle callout bar visibility by tapping on the
text selection) misses completely, due to the fact that the midpoint of the selected paragraph element is
somewhere in the middle of the page.

Fix this by simply making the selection target inline-block, such that the element width doesn't expand to
the width of the page.

  • editing/selection/ios/toggle-callout-bar-after-tap-in-selected-non-editable-text.html:
6:20 AM WPTExportProcess edited by clopez@igalia.com
(diff)
6:17 AM Changeset in webkit [262838] by svillar@igalia.com
  • 5 edits
    2 adds
    2 deletes in trunk/Source/WebCore

[WebXR] Refactor OpenXR platform code
​https://bugs.webkit.org/show_bug.cgi?id=212470

Reviewed by Youenn Fablet.

Refactored a bit the platform code because we want to extend the PlatformXR::Device for the OpenXR
library. Also we're removing all the device id code because there is no need to expose it.

The idea from now on is to only define interfaces in PlatformXR.h and then add all the OpenXR specifics
in the newly renamed PlatformXROpenXR.[ch] files. We're also renaming PlatformXR.cpp to
PlatformXROpenXR.cpp to clearly state that it's the OpenXR implementation and to differentiate it from
the implementation agnostic PlatformXR.h file.

No new tests as there is no change in functionality.

  • Sources.txt: Added renamed files. Removed PlatformXR.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/xr/PlatformXR.cpp: Removed.
  • platform/xr/PlatformXR.h:

(PlatformXR::Device::id const): Deleted.
(PlatformXR::Device::operator== const): Deleted.

  • platform/xr/openxr/PlatformXROpenXR.cpp: Renamed from Source/WebCore/platform/xr/openxr/PlatformXR.cpp.

(PlatformXR::Instance::Impl::~Impl): Call xrDestroyInstance() on m_instance.
(PlatformXR::Instance::Impl::collectSupportedSessionModes): Do not pass XrSystemId as argument
as it's stored in the OpenXRDevice object.
(PlatformXR::Instance::enumerateImmersiveXRDevices): Create an OpenXRDevice instead of a Device.

  • platform/xr/openxr/PlatformXROpenXR.h: Added.
4:18 AM Changeset in webkit [262837] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, reverting r262807.
​https://bugs.webkit.org/show_bug.cgi?id=213019

It is breaking JSC queues (Requested by caiolima on #webkit).

Reverted changeset:

"Add a timeout monitor for JSC stress test"
​https://bugs.webkit.org/show_bug.cgi?id=211978
​https://trac.webkit.org/changeset/262807

12:34 AM Changeset in webkit [262836] by Diego Pino Garcia
  • 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening, update expectations after r262834
​https://bugs.webkit.org/show_bug.cgi?id=213014

Unreviewed gardening.

Garden latest failures from bots and adjust the actual result of
several flaky failures.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
Note: See TracTimeline for information about the timeline view.