Timeline
Aug 5, 2020:
- 11:16 PM Changeset in webkit [265321] by
-
- 2 edits in trunk/Source/WebCore
Remove the StyleResolver-specific evaluate function in MediaQueryEvaluator
https://bugs.webkit.org/show_bug.cgi?id=152089
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-05
Reviewed by Darin Adler.
The function mentioned in the bug is already gone (see r252736), also remove
the StyleResolver reference.
- css/MediaQueryEvaluator.h:
- 9:06 PM Changeset in webkit [265320] by
-
- 2 edits in trunk/LayoutTests
[GTK][WPE] Garden backdrop-filter debug crashes
Unreviewed test gardening.
- platform/glib/TestExpectations:
- 8:54 PM Changeset in webkit [265319] by
-
- 4 edits in trunk/Source/WebCore
Add some more Animations logging
https://bugs.webkit.org/show_bug.cgi?id=215181
Reviewed by Zalan Bujtas.
Add logging that shows when DeclarativeAnimation::tick() runs and when it invalidates style.
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::tick):
- animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
- animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::invalidate):
- 7:35 PM Changeset in webkit [265318] by
-
- 2 edits in trunk/Source/WebCore
Netflix.com shows a scrubber that doesn't work
https://bugs.webkit.org/show_bug.cgi?id=215199
Reviewed by Eric Carlson.
The "contentDuration" property of WebPlaybackControlsManager needs to be infinite
when the video is not seekable. Otherwise, AVKit will show a scrubber that doesn't
work on the Touch Bar.
- platform/mac/WebPlaybackControlsManager.mm:
(-[WebPlaybackControlsManager contentDuration]):
(-[WebPlaybackControlsManager setContentDuration:]):
- 6:58 PM Changeset in webkit [265317] by
-
- 4 edits in trunk
[WebGL2] Upgrade vertexAttribPointer with new supported types
https://bugs.webkit.org/show_bug.cgi?id=215036
Patch by James Darpinian <James Darpinian> on 2020-08-05
Reviewed by Dean Jackson.
Tested by updated WebGL conformance tests webgl/2.0.0/conformance/attribs/gl-vertexattribpointer-offsets.html and webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::sizeInBytes):
(WebCore::WebGLRenderingContextBase::vertexAttribPointer):
- 6:43 PM Changeset in webkit [265316] by
-
- 2 edits in trunk/Tools
Rename BigSur EWS to AppleSilicon EWS
https://bugs.webkit.org/show_bug.cgi?id=215205
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/config.json:
- 5:58 PM Changeset in webkit [265315] by
-
- 74 edits in trunk
Remove all references to non-existent 10.16
https://bugs.webkit.org/show_bug.cgi?id=215202
Reviewed by Wenson Hsieh.
Source/bmalloc:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/DebugProject.xcconfig:
- gtest/xcode/Config/ReleaseProject.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebCore/PAL:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WebKit:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
- Scripts/process-entitlements.sh:
- WebProcess/com.apple.WebProcess.sb.in:
Source/WebKitLegacy/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- wtf/PlatformEnableCocoa.h:
- wtf/PlatformHave.h:
- wtf/PlatformUse.h:
Tools:
- ContentExtensionTester/Configurations/Base.xcconfig:
- ContentExtensionTester/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- ImageDiff/cg/Configurations/Base.xcconfig:
- ImageDiff/cg/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
- TestWebKitAPI/config.h:
- WebEditingTester/Configurations/Base.xcconfig:
- WebEditingTester/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- lldb/lldbWebKitTester/Configurations/Base.xcconfig:
- lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
- 5:33 PM Changeset in webkit [265314] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] imported/w3c/web-platform-tests/svg/import/linking-a-10-f-manual.svg is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215204
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 5:24 PM Changeset in webkit [265313] by
-
- 3 edits1 add in trunk
Fix returnEarlyFromInfiniteLoopsForFuzzing in DFG and validateDoesGC
https://bugs.webkit.org/show_bug.cgi?id=215194
<rdar://problem/66158641>
Reviewed by Mark Lam.
JSTests:
- stress/validate-does-gc-with-return-early-from-infinite-loop-2.js: Added.
(vm.useJIT):
Source/JavaScriptCore:
I already fixed this same issue in the FTL in r264330, but I forgot
to do it in the DFG.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:54 PM Changeset in webkit [265312] by
-
- 2 edits in trunk/Tools
r264813 breaks Make runner on remote devices
https://bugs.webkit.org/show_bug.cgi?id=215179
Reviewed by Saam Barati.
This patch is setting up the proper
LD_LIBRARY_PATHvalue to run JSC
stress tests on remote devices.
- Scripts/run-jsc-stress-tests:
- 4:21 PM Changeset in webkit [265311] by
-
- 7 edits in trunk/Source/WebCore
Crash in com.apple.WebKit.WebContent at com.apple.AppKit: _NSAccessibilityRemoveAllObserversAndSendDestroyedNotification
https://bugs.webkit.org/show_bug.cgi?id=215189
<rdar://problem/66561167>
Reviewed by Chris Fleizach.
AXIsolatedObject::detachPlatformWrapper was calling the wrapper's detach
method that in turn calls the system NSAccessibilityUnregisterUniqueIdForUIElement
on the secondary thread. This function is not thread safe and hence the
random crashes.
This changes AXIsolatedObject::detachPlatformWrapper to call the
wrapper's detachIsolatedObject, avoiding the above problem altogether.
The wrapper's detach remains the same that it was before isolated tree
mode was introduced, and should only run on the main thread.
- accessibility/AccessibilityObjectInterface.h:
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::applyPendingChanges):
- accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::detachPlatformWrapper):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject:]):
(-[WebAccessibilityObjectWrapperBase detachAXObject]): Merged back into detach.
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject]): Deleted.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
- 4:19 PM Changeset in webkit [265310] by
-
- 2 edits1 add in trunk/Tools
Add a createWebArchiveData from a custom scheme API test
https://bugs.webkit.org/show_bug.cgi?id=215187
Reviewed by Tim Horton.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm: Added.
- 4:16 PM Changeset in webkit [265309] by
-
- 2 edits in trunk/LayoutTests
[ macOS Release wk1 ] imported/w3c/web-platform-tests/css/css-overflow/overflow-recalc-001.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=214703
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Update expectatins to reflect that this is an image failure.
- 3:22 PM Changeset in webkit [265308] by
-
- 2 edits in trunk/LayoutTests
[GTK][WPE] media/media-source/media-source-webm.html is timing out
Unreviewed test gardening.
Instead of the previous missing 'update' event entries, now times out
waiting for resize event, which is not raised because the size does
not seem to be changing (all resize events return 320x240).
- platform/glib/TestExpectations:
- 3:18 PM Changeset in webkit [265307] by
-
- 29 edits2 copies in trunk
Add constructor for DynamicsCompressorNode
https://bugs.webkit.org/show_bug.cgi?id=215180
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
Source/WebCore:
Add constructor for DynamicsCompressorNode:
This patch also add a new handleAudioNodeOptions() member function to
AudioNode to avoid code duplication and every node constructor.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::create):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::initializeDefaultNodeOptions):
(WebCore::AudioNode::handleAudioNodeOptions):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createDynamicsCompressor):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::create):
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::create):
(WebCore::ConvolverNode::ConvolverNode):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::create):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::create):
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::setChannelCount):
(WebCore::DynamicsCompressorNode::setChannelCountMode):
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/DynamicsCompressorNode.idl:
- Modules/webaudio/DynamicsCompressorOptions.h: Copied from Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl.
- Modules/webaudio/DynamicsCompressorOptions.idl: Copied from Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl.
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::create):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::create):
(WebCore::PannerNode::PannerNode):
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::create):
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 2:30 PM Changeset in webkit [265306] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 ] imported/w3c/web-platform-tests/preload/single-download-preload.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215192
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 2:12 PM Changeset in webkit [265305] by
-
- 5 edits in trunk/Tools
results.webkit.org: Return worker status to caller
https://bugs.webkit.org/show_bug.cgi?id=215086
<rdar://problem/66476525>
Rubber-stamped by Aakash Jain.
- resultsdbpy/resultsdbpy/model/model.py:
(Model.do_work): Return if process has successfully processed results.
- resultsdbpy/resultsdbpy/model/model_unittest.py:
(ModelTest.test_no_work):
- resultsdbpy/resultsdbpy/model/upload_context.py:
(UploadContext._do_job_for_key): Return if the job was successful.
(UploadContext.do_processing_work): Return true if any processed jobs were successful.
- resultsdbpy/resultsdbpy/model/upload_context_unittest.py:
(UploadContextTest.test_async_callback):
- 2:08 PM Changeset in webkit [265304] by
-
- 2 edits in trunk/Tools
Make report-non-inclusive-language ignore files within .svn and .git
https://bugs.webkit.org/show_bug.cgi?id=215156
Reviewed by Darin Adler.
- Scripts/report-non-inclusive-language:
- 1:47 PM Changeset in webkit [265303] by
-
- 2 edits in trunk/Source/WebKit
[Cocoa] Sandbox extension token not cleared from memory
https://bugs.webkit.org/show_bug.cgi?id=215136
Reviewed by Geoffrey Garen.
As a security mitigation, an invalidated sandbox extension should have its token cleared from memory.
No new tests, covered by existing tests.
- Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::m_length):
(WebKit::SandboxExtensionImpl::~SandboxExtensionImpl):
- 1:41 PM Changeset in webkit [265302] by
-
- 3 edits in trunk/Tools
EWS emails about build failure should include relevant error logs
https://bugs.webkit.org/show_bug.cgi?id=215174
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.start):
(AnalyzeCompileWebKitResults):
(AnalyzeCompileWebKitResults.getResults): Method to read the logs from previous build step.
(AnalyzeCompileWebKitResults.analyzeResults): Made a separate method called using deferred after reading the logs from previous steps.
(AnalyzeCompileWebKitResults.getBuildStepByName): Method to get step object from step name.
(AnalyzeCompileWebKitResults.filter_logs_containing_error): Filter the logs to include in email.
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Renamed from send_email_for_build_failure. Added
relevant error logs in email.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 12:51 PM Changeset in webkit [265301] by
-
- 3 edits in trunk/Websites/webkit.org
Enhance feature status page origin for flexible test environments
https://bugs.webkit.org/show_bug.cgi?id=215178
Reviewed by Devin Rousso.
- wp-content/themes/webkit/css-status.php:
- wp-content/themes/webkit/status.php:
- 12:40 PM Changeset in webkit [265300] by
-
- 2 edits in trunk/LayoutTests
[ iOS wk2 Release ] imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215185
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 12:40 PM Changeset in webkit [265299] by
-
- 3 edits in trunk/Source/JavaScriptCore
The various AllowList options should be able to take the function name inline
https://bugs.webkit.org/show_bug.cgi?id=215184
Reviewed by Saam Barati.
Right now when I use the various AllowList JSC options I almost
always only care about a single function. Right now you need to
create a file with that single name in it. That is inconvenient, so
this patch changes the behavior to treat the string as the
function name if no file at that path exists. I'm also
speculatively assuming fopen doesn't return ENOENT when it fails
due to sandboxing... I didn't feel like testing it because this is
a debug option.
- runtime/OptionsList.h:
- tools/FunctionAllowlist.cpp:
(JSC::FunctionAllowlist::FunctionAllowlist):
- 12:23 PM Changeset in webkit [265298] by
-
- 15 edits2 copies in trunk
Add constructor to ConvolverNode
https://bugs.webkit.org/show_bug.cgi?id=215169
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
Source/WebCore:
Add constructor to ConvolverNode, as per specification:
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createConvolver):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::create):
(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):
(WebCore::ConvolverNode::setChannelCount):
(WebCore::ConvolverNode::setChannelCountMode):
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/ConvolverNode.idl:
- Modules/webaudio/ConvolverOptions.h: Copied from Source/WebCore/Modules/webaudio/ConvolverNode.idl.
- Modules/webaudio/ConvolverOptions.idl: Copied from Source/WebCore/Modules/webaudio/ConvolverNode.idl.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 12:12 PM Changeset in webkit [265297] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add assertions / inline capacity to checkpoint side state stacks
https://bugs.webkit.org/show_bug.cgi?id=215175
Reviewed by Saam Barati.
The inline capacity should hopefully avoid unneeded mallocs close to 100% of the time during our OSR exit ramp.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileExit):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- runtime/VM.cpp:
(JSC::VM::pushCheckpointOSRSideState):
- runtime/VM.h:
- 11:53 AM Changeset in webkit [265296] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS wk2 Release ] editing/selection/navigation-clears-editor-state.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215177
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 11:50 AM Changeset in webkit [265295] by
-
- 7 edits in trunk/Source/WebKit
[Cocoa] Remove obsolete sandbox extension after r264178
https://bugs.webkit.org/show_bug.cgi?id=215154
Reviewed by Brent Fulgham.
After r264178, the code related to issuing an extension to com.apple.lsd.mapdb is obsolete, and should be removed.
No new tests, covered by existing tests.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/com.apple.WebProcess.sb.in:
- 11:48 AM Changeset in webkit [265294] by
-
- 9 edits15 adds2 deletes in trunk/LayoutTests
Re-sync web-platform-tests (2 dirs + 2 files)
https://bugs.webkit.org/show_bug.cgi?id=215173
Reviewed by Carlos Alberto Lopez Perez.
LayoutTests/imported/w3c:
web-platform-tests revision: 993c1bc4c880
- web-platform-tests/css/cssom/*: Updated.
- web-platform-tests/dom/idlharness.window-expected.txt:
- web-platform-tests/dom/idlharness.window.js:
- web-platform-tests/intersection-observer/*: Updated.
- web-platform-tests/performance-timeline/po-observe.any.*: Added.
LayoutTests:
Remove a duplicate test added in r259800 that was manually exported [1] and synced.
[1]: https://github.com/web-platform-tests/wpt/pull/23101
- js/getOwnPropertyDescriptor-host-object-proxy-expected.txt: Removed.
- js/getOwnPropertyDescriptor-host-object-proxy.html: Removed.
- 10:51 AM Changeset in webkit [265293] by
-
- 12 edits in trunk/Source/WebCore
REGRESSION (r265266) DumpRenderTree crash at WebKitAudioListener::dopplerFactor
https://bugs.webkit.org/show_bug.cgi?id=215171
<rdar://problem/66556999>
Reviewed by Eric Carlson.
We were calling the isWebKitAudioContext() virtual function from the BaseAudioContext
constructor, which was not OK. We now initialize the listener lazily so that we can
know if we are a WebKitAudioContext or not at the time of creation.
Also use downcast<> instead of static_cast<> to cast from AudioListener to
WebKitAudioListener for extra safety. Finally, AudioListener was missing a virtual
destructor even though we were using polymorphism.
No new tests, covered by existing tests that are crashing on the bots.
- Modules/webaudio/AudioListener.h:
(WebCore::AudioListener::isWebKitAudioListener const):
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::constructCommon):
(WebCore::WebCore::BaseAudioContext::listener):
- Modules/webaudio/BaseAudioContext.h:
(WebCore::BaseAudioContext::listener): Deleted.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::listener):
(WebCore::PannerNode::getAzimuthElevation):
(WebCore::PannerNode::distanceConeGain):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/WebKitAudioContext.h:
(WebCore::WebKitAudioContext::listener):
- Modules/webaudio/WebKitAudioListener.h:
(isType):
- Modules/webaudio/WebKitAudioListener.idl:
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::listener):
(WebCore::WebKitAudioPannerNode::getAzimuthElevation):
(WebCore::WebKitAudioPannerNode::dopplerRate):
(WebCore::WebKitAudioPannerNode::distanceConeGain):
- Modules/webaudio/WebKitAudioPannerNode.h:
- 10:22 AM Changeset in webkit [265292] by
-
- 19 edits2 deletes in branches/safari-610.1.25-branch
Revert r265115. rdar://problem/66552761
- 9:54 AM Changeset in webkit [265291] by
-
- 6 edits in trunk
Align BiquadFilterNode.getFrequencyResponse() with the specification
https://bugs.webkit.org/show_bug.cgi?id=215148
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that all checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-basic-expected.txt:
Source/WebCore:
Align BiquadFilterNode.getFrequencyResponse() with the specification:
In particular, the 3 argument arrays should not be nullable and we should throw
if they have different lengths.
No new tests, rebaselined existing tests.
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::getFrequencyResponse):
- Modules/webaudio/BiquadFilterNode.h:
- Modules/webaudio/BiquadFilterNode.idl:
- 9:52 AM Changeset in webkit [265290] by
-
- 19 edits4 copies in trunk
Add constructor to BiquadFilterNode
https://bugs.webkit.org/show_bug.cgi?id=215144
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
Source/WebCore:
Add constructor to BiquadFilterNode:
No new tests, rebaselined existing tests..
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createBiquadFilter):
- Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::create):
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadFilterNode.h:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/BiquadFilterOptions.h: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
- Modules/webaudio/BiquadFilterOptions.idl: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
- Modules/webaudio/BiquadFilterType.h: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
- Modules/webaudio/BiquadFilterType.idl: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
- Modules/webaudio/BiquadProcessor.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 9:36 AM Changeset in webkit [265289] by
-
- 24 edits in trunk
Update event regions only once per frame
https://bugs.webkit.org/show_bug.cgi?id=215132
<rdar://problem/66533779>
Reviewed by Darin Adler.
Source/WebCore:
Event regions (for touch-action, editable areas etc) were updated as part of
compositing updates, but we only need their output once per rendering update, so
move their computation out of RenderLayerCompositor::updateBackingAndHierarchy()
and into a new RenderLayer tree walk that is called from Page::doAfterUpdateRendering().
RenderLayerBacking stores a dirty bit to track when regions need to be updated.
Reduces the amount of time spent in rendering updates when scrolling on facebook.com
on iPad, which has lots of discontiguous touch-action regions.
- dom/Document.cpp:
(WebCore::Document::updateEventRegions):
- dom/Document.h:
- page/Frame.cpp:
(WebCore::Frame::layerTreeAsText const):
- page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::maintainsEventRegion const):
(WebCore::RenderLayerBacking::updateEventRegion):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateEventRegions):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Tests that dispatch mouseWheel events in a way that tests event regions need to wait
now for a rendering update.await UIHelper.animationFrame()is not enough, because
the function resumes inside a microtask at the end of the requestAnimationFrame callback,
which is before we've completed the rest of the rendering update, and thus before
the event regions have been updated.
In addition,
await UIHelper.animationFrame()followed by eventSender calls to issue
wheel events actually trigger Page::updateRendering() re-entrancy, via the
WKBundlePageForceRepaint() in EventSendingController::mouseScrollByWithWheelAndMomentumPhases().
To fix this, add and use UIHelper.renderingUpdate(), which waits for a rAF and uses a setTimeout()
to get past the end of the current rendering update.
- fast/scrolling/mac/absolute-in-overflow-scroll-dynamic-expected.html:
- fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html:
- fast/scrolling/mac/absolute-in-overflow-scroll.html:
- fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
- fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
- fast/scrolling/mac/async-scroll-overflow-top-inset.html:
- fast/scrolling/mac/async-scroll-overflow.html:
- fast/scrolling/mac/clip-path-hit-test.html:
- fast/scrolling/mac/move-node-in-overflow-scroll.html:
- fast/scrolling/mac/overflow-scrolled-document.html:
- fast/scrolling/mac/overflow-zoomed-document.html:
- fast/scrolling/mac/overlapped-overflow-scroll.html:
- resources/ui-helper.js:
(window.UIHelper.async renderingUpdate):
- 9:21 AM WebKitFlatpakSDK/SpeedUpBuild edited by
- (diff)
- 9:11 AM Changeset in webkit [265288] by
-
- 3 edits in trunk/LayoutTests
[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215088
<rdar://problem/66489006>
Reviewed by Eric Carlson.
- platform/mac-wk2/TestExpectations:
- webrtc/datachannel/gather-candidates-networkprocess-crash.html:
Sending IPC to the network process is now happening in a background thread and in case of network process crash
we might need to wait a little bit longer since the socket creation/sending is not blocked on getting a proper connection.
- 8:50 AM Changeset in webkit [265287] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed non-unified build fix.
No new tests needed.
- Modules/webaudio/AudioListener.h: Add forward declaration for BaseAudioSharedUnit.
- 8:46 AM Changeset in webkit [265286] by
-
- 6 edits in trunk
TextManipulationController should observe newly inserted or displayed text
https://bugs.webkit.org/show_bug.cgi?id=215157
Patch by Sihui Liu <sihui_liu@appe.com> on 2020-08-05
Reviewed by Wenson Hsieh.
Source/WebCore:
TextManipulationController already tracks renderer state of Element, but the case where Text children of an
Element is newly inserted and displayed is not covered. Therefore, TextManipulationController also needs to
know when render of Text is created.
API test: TextManipulation.CompleteTextManipulationForNewlyDisplayedText
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::didCreateRendererForTextNode):
(WebCore::TextManipulationController::scheduleObservationUpdate):
(WebCore::TextManipulationController::removeNode):
- editing/TextManipulationController.h:
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createTextRenderer):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 8:19 AM Changeset in webkit [265285] by
-
- 3 edits in trunk/LayoutTests
[ iOS ] imported/mozilla/svg/image/image-filter-01.svg is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=215167
Unreviewed test gardening.
- TestExpectations:
- platform/ios-wk2/TestExpectations:
- 7:43 AM Changeset in webkit [265284] by
-
- 6 edits1 add in trunk
[iOS] Keyboard shortcuts and arrow key scrolling stop working after navigating via swipe gesture
https://bugs.webkit.org/show_bug.cgi?id=215137
<rdar://problem/65082979>
Reviewed by Tim Horton.
Source/WebKit:
The process of starting a navigation swipe gesture causes the first responder (in this case, WKContentView) to
resign. Subsequently, nothing makes the content view first responder again once the navigation gesture ends,
even if the gesture is cancelled and we don't end up navigating. This results in several symptoms, two of which
are that keyboard shortcuts stop working, and pressing arrow keys does not scroll the web view after ending the
swipe gesture.
To mitigate this, add a mechanism to have the web view remember that our content view was first responder before
calling-startInteractiveTransition:; after ending the interactive transition (i.e. swipe gesture), we then
restore the web view's content view as first responder if it is not already first responder (and it is also
parented, which is not the case when swiping back to close a newly opened tab in Safari).
Test: NavigationSwipeTests.RestoreFirstResponderAfterNavigationSwipe
NavigationSwipeTests.DoNotBecomeFirstResponderAfterNavigationSwipeIfWebViewIsUnparented
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _navigationGestureDidBegin]):
(-[WKWebView _navigationGestureDidEnd]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/NavigationSwipeTests.mm: Added.
(-[TestNavigationInteractiveTransition startInteractiveTransition:]):
Add an API test that exercises the bug by resigning first responder underneath
-startInteractiveTransition:,
and checking that we have become first responder once again after completing the transition.
- TestWebKitAPI/ios/UIKitSPI.h:
- 5:01 AM WebKitFlatpakSDK/SpeedUpBuild edited by
- (diff)
- 5:00 AM Sccache edited by
- (diff)
- 5:00 AM WebKitFlatpakSDK/SpeedUpBuild edited by
- (diff)
- 4:53 AM WebKitFlatpakSDK edited by
- (diff)
- 4:48 AM WebKitFlatpakSDK edited by
- (diff)
- 4:47 AM WebKitFlatpakSDK edited by
- (diff)
- 4:45 AM WebKitFlatpakSDK edited by
- (diff)
- 4:45 AM WebKitFlatpakSDK created by
- 4:44 AM WebKitFlatpakSDK/SpeedUpBuild created by
- 4:44 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 4:43 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 4:27 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 4:26 AM WebKitGTK/SpeedUpBuild edited by
- (diff)
- 4:03 AM Changeset in webkit [265283] by
-
- 4 edits in trunk/Source/WebCore
RegistrationDatabase::openSQLiteDatabase can spin
https://bugs.webkit.org/show_bug.cgi?id=215120
<rdar://problem/64850347>
Reviewed by Geoffrey Garen.
In case we fail opening the database when importing, we delete the database, the file and retry.
We do not need to retry in that case since there is nothing to import. Update the code to proceed with sending an import failure to SWServer.
In case of pushing changes to the database, it might be useful to retry but it is best to do this asynchronously.
For instance, there might be a script deleting the files/folders where is stored the database.
In that case, we check the result of pushing changes.
If they succeed, we call the completion handler and stop.
Otherwise, we will retry pushing the changes if changes were not pushed again in the meantime.
We introduce a push counter for that purpose.
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::postTaskToWorkQueue):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::importRecordsIfNecessary):
(WebCore::RegistrationDatabase::pushChanges):
(WebCore::RegistrationDatabase::schedulePushChanges):
(WebCore::RegistrationDatabase::doPushChanges):
- workers/service/server/RegistrationDatabase.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::registrationStoreDatabaseFailedToOpen):
- 1:33 AM Changeset in webkit [265282] by
-
- 2 edits in trunk/Source/WebCore
SWServerJobQueue::didResolveRegistrationPromise should not assume its registration key relates to an existing worker
https://bugs.webkit.org/show_bug.cgi?id=215123
<rdar://problem/65096786>
Reviewed by Geoffrey Garen.
We know that in some cases, the registration is null in SWServerJobQueue::didResolveRegistrationPromise.
This might happen for instance in case a worker gets terminated, thus removing a job and the next job is clearing the registration.
Also, SWServerJobQueue::didResolveRegistrationPromise is not checking that the job identifier is the same in SWServerJobQueue::install
and SWServerJobQueue::didResolveRegistrationPromise while other code paths do.
A future refactoring might allow to call SWServerJobQueue::didResolveRegistrationPromise code synchronously from SWServerJobQueue::install.
In the meantime, let's add a null check and add release logging for that case.
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
- 1:22 AM Changeset in webkit [265281] by
-
- 8 edits in trunk
Allow multiple calls to PerformanceObserver.observe with different types
https://bugs.webkit.org/show_bug.cgi?id=214884
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-05
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update improved test expectations.
- web-platform-tests/performance-timeline/po-observe-type.any-expected.txt:
- web-platform-tests/performance-timeline/po-observe-type.any.worker-expected.txt:
Source/WebCore:
Allow multiple calls to PerformanceObserver.observe with different type, but
throw an exception if the observer type is changed [1].
Behavior matches Firefox and Chrome.
Test: imported/web-platform-tests/performance-timeline/po-observe-type.any.html
[1] https://w3c.github.io/performance-timeline/#observe-method
- page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::observe):
- page/PerformanceObserver.h:
LayoutTests:
Unskip po-observe-type.any.html.
- 1:11 AM Changeset in webkit [265280] by
-
- 4 edits in trunk/Source/WebCore
Update AudioSampleDataSource offset computation
https://bugs.webkit.org/show_bug.cgi?id=215127
<rdar://problem/65938265>
Reviewed by Eric Carlson.
As per logs, it sometimes happens that the offset is so big that the timestamp is below the start of the window.
In that case, our logic is not able to catch up and reduce the offset.
To handle this, we special case if the timestamp is below the start frame and do as if we were starting from scratch.
Otherwise, we continue our logic to fine tune the offset by slowly making it bigger to not hit the end of the window but still be close to it.
Updated logging to help further debugging this issue if needed.
- platform/audio/mac/AudioSampleDataSource.h:
- platform/audio/mac/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::computeOffsetDelay):
(WebCore::AudioSampleDataSource::pullSamplesInternal):
(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):
- platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:
(WebCore::RealtimeIncomingAudioSourceCocoa::OnData):
- 1:03 AM Changeset in webkit [265279] by
-
- 2 edits in trunk/JSTests
Unreviewed, skip private field test
Private field has a bug and this test is failing. We skip it since private field is not enabled.
- stress/put-by-val-direct-putprivate.js:
- 12:22 AM Changeset in webkit [265278] by
-
- 4 edits in trunk/Source/WebCore
AX: WebCore should provide a way to get raw role for accessibility objects
https://bugs.webkit.org/show_bug.cgi?id=215149
Patch by Eric Liang <ericliang@apple.com> on 2020-08-05
Reviewed by Chris Fleizach.
Added a conversion from WebRole to string for accessibility.
This allows us to get it in the WebKit bundle.
- accessibility/AXLogger.cpp:
(WebCore::operator<<):
- accessibility/AccessibilityObjectInterface.h:
(WebCore::accessibilityRoleToString):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper _accessibilityWebRoleAsString]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
Aug 4, 2020:
- 10:15 PM Changeset in webkit [265277] by
-
- 2 edits3 copies3 adds in trunk/Tools
[webkitcorepy] Add mocks.ContextStack
https://bugs.webkit.org/show_bug.cgi?id=214484
Reviewed by Dewei Zhu.
Add a class which allows a context leveraging mock to stack. This is useful when
mocking requests or subprocess, where a single function (or class of functions)
is handling calls that are destined for different for different mock handlers.
- Scripts/libraries/webkitcorepy/webkitcorepy/mocks: Added.
- Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py: Added.
- Scripts/libraries/webkitcorepy/webkitcorepy/mocks/context_stack.py: Added.
(ContextStack): Class which stacks mock handlers.
- Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks: Added.
- Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/init.py: Added.
- Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/context_stack_unittest.py: Added.
(to_be_replaced): Function to be mocked
(ExampleStack): Example mock handler.
(ContextStack): Test suite.
- 9:19 PM Changeset in webkit [265276] by
-
- 15 edits in trunk/Source
[JSC] Use LazyNeverDestroyed & std::call_once for complex singletons
https://bugs.webkit.org/show_bug.cgi?id=215153
<rdar://problem/65718983>
Reviewed by Mark Lam.
Source/JavaScriptCore:
We are getting some crashes in RemoteInspector and this speculatively fixes the crash.
My guess is that NeverDestroyed<RemoteInspector> calls constructor twice in heavily contended situation:
WebKit's static does not have thread-safety. If two threads come here at the same time, it is possible that
constructor is invoked twice. In that case, later constructor will clear members, which involves clearing
Lock m_mutex field. This makes Lock's invariant broken.
This patch uses LazyNeverDestroyed and std::call_once to ensure invoking constructor only once.
- API/glib/JSCVirtualMachine.cpp:
- dfg/DFGCommonData.cpp:
- disassembler/Disassembler.cpp:
- inspector/remote/RemoteInspector.h:
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::singleton):
- inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::singleton):
- inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::singleton):
- inspector/remote/socket/RemoteInspectorServer.h:
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::singleton):
- inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::singleton):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::opcodeIDTable):
- runtime/IntlObject.cpp:
(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):
(JSC::defaultLocale):
(JSC::numberingSystemsForLocale):
Source/WTF:
Add lock's bits in crash information to investigate if this speculative fix does not work.
- wtf/LockAlgorithmInlines.h:
(WTF::Hooks>::lockSlow):
(WTF::Hooks>::unlockSlow):
- 7:32 PM Changeset in webkit [265275] by
-
- 2 edits in trunk/LayoutTests
Disable isolated-tree-mode-on-off.html because it is causing other test failures..
https://bugs.webkit.org/show_bug.cgi?id=215151
<rdar://problem/66542837>
Reviewed by Chris Fleizach.
This test turns isolated tree mode on and causes other concurrent test
to also run in isolated tree mode, and thus random failures. Will enable
once all tests succeed in isolated tree mode, or we can turn the mode on
only for a particular test without affecting others.
- platform/mac/TestExpectations:
- 6:56 PM Changeset in webkit [265274] by
-
- 2 edits in trunk/Tools
[webkitcorepy] REGRESSION(r265254): autoinstaller is failing to execute setup.py on win32 Python
https://bugs.webkit.org/show_bug.cgi?id=215152
Reviewed by Jonathan Bedard.
There were two problems. Win32 Python needs SYSTEMROOT environment
variable to run setup.py. win-inet-pton is using_for the
directory name (win_inet_pton-1.1.0).
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Add a new candidate directory by replacing '-'
with '_'. Pass through SYSTEMROOT env var.
- 6:41 PM Changeset in webkit [265273] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r265167): media/media-source/media-source-webm.html failing
https://bugs.webkit.org/show_bug.cgi?id=215142
<rdar://problem/66487888>
Reviewed by Eric Carlson.
Once we started checking the "codecs=" parameter of the MIME type in MediaSource.isTypeSupported(),
the media-source-webm.html test started failing, as the codecs string didn't include some mandatory
entries. Also re-wrote the test to use a single try/catch block to catch errors without timing out.
- media/media-source/content/test-vp9-manifest.json:
- media/media-source/media-source-webm.html:
- 6:32 PM Changeset in webkit [265272] by
-
- 13 edits1 add in trunk
CheckpointSideState shoud play nicely with StackOverflowException unwinding.
https://bugs.webkit.org/show_bug.cgi?id=215114
Reviewed by Saam Barati.
JSTests:
- stress/stack-overflow-into-frame-with-pending-checkpoint.js: Added.
(foo.catch.async bar):
(foo.catch):
(foo):
Source/JavaScriptCore:
This patch fixes an issue where we the StackVisitor would
automatically unwind into the first frame before calling into the
provided functor. As a note, we do this because the first frame is
not fully initialized at the time we check for stack
overflow. When this happened we would fail to clear the side state
causing a memory leak. To fix this the unwind function now clears
every checkpoint up to and including the call frame containing our
handler. Some care needs to be taken that we don't clear
checkpoint side state for other threads, which could happen if
there are no checkpoints on the current thread and an API
miggrated us from another thread below the current thread.
This patch also makes two refacorings. The first is to make the
checkpoint side state into a stack, which is how we used it
anyway. The second is that CallFrame::dump and everything associated
with it is now marked const so we can PointerDump a CallFrame*.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileExit):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeIndex const):
(JSC::CallFrame::codeOrigin const):
(JSC::CallFrame::dump const):
(JSC::CallFrame::bytecodeIndex): Deleted.
(JSC::CallFrame::codeOrigin): Deleted.
(JSC::CallFrame::dump): Deleted.
- interpreter/CallFrame.h:
(JSC::CallFrame::argument const):
(JSC::CallFrame::uncheckedArgument const):
(JSC::CallFrame::getArgumentUnsafe const):
(JSC::CallFrame::thisValue const):
(JSC::CallFrame::newTarget const):
(JSC::CallFrame::argument): Deleted.
(JSC::CallFrame::uncheckedArgument): Deleted.
(JSC::CallFrame::getArgumentUnsafe): Deleted.
(JSC::CallFrame::thisValue): Deleted.
(JSC::CallFrame::newTarget): Deleted.
- interpreter/CheckpointOSRExitSideState.h:
(JSC::CheckpointOSRExitSideState::CheckpointOSRExitSideState):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator() const):
(JSC::Interpreter::unwind):
(): Deleted.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::slow_path_checkpoint_osr_exit_from_inlined_call):
(JSC::LLInt::slow_path_checkpoint_osr_exit):
- runtime/VM.cpp:
(JSC::VM::scanSideState const):
(JSC::VM::pushCheckpointOSRSideState):
(JSC::VM::popCheckpointOSRSideState):
(JSC::VM::popAllCheckpointOSRSideStateUntil):
(JSC::VM::addCheckpointOSRSideState): Deleted.
(JSC::VM::findCheckpointOSRSideState): Deleted.
- runtime/VM.h:
Source/WTF:
Add a helper so we can have soft stack bounds.
- wtf/StackBounds.h:
(WTF::StackBounds::withSoftOrigin const):
- 6:27 PM Changeset in webkit [265271] by
-
- 4 edits2 moves in trunk/Tools
Move poseAsClass() into the TestRunnerShared directory
https://bugs.webkit.org/show_bug.cgi?id=215147
Reviewed by Tim Horton.
Move the duplicated implementations of
poseAsClass()out of WebKitTestRunner and DumpRenderTree,
and into helper files in TestRunnerShared instead.
No change in behavior.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTree.mm:
(poseAsClass): Deleted.
(setPersistentUserStyleSheetLocation): Deleted.
- TestRunnerShared/cocoa/PoseAsClass.h: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.h.
- TestRunnerShared/cocoa/PoseAsClass.mm: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.mm.
(swizzleAllMethods):
(poseAsClass):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 5:43 PM Changeset in webkit [265270] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r265263
https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 4:48 PM Changeset in webkit [265269] by
-
- 5 edits in trunk/Source
"DoubleDown Casino" respin button stops working with trackpad
https://bugs.webkit.org/show_bug.cgi?id=215146
<rdar://problem/64668138>
Reviewed by Tim Horton.
Source/WebCore:
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isDoubleDown): Added.
Source/WebKit:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView shouldUseMouseGestureRecognizer]):
- 4:38 PM Changeset in webkit [265268] by
-
- 2 edits in branches/safari-610.1.25-branch/Source/WebKit
Cherry-pick r265260. rdar://problem/66548143
[iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=215108
Reviewed by Youenn Fablet.
This asserts because it appears that the WebContent and Networking process do not have the required entitlement
com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Add the entitlement for simulator.
No new tests, covered by existing tests.
- Resources/ios/XPCService-embedded-simulator.entitlements:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:10 PM Changeset in webkit [265267] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
https://bugs.webkit.org/show_bug.cgi?id=214965
Unreviewed, address review comments.
Add comment explaining why a set of MobileGestalt queries are performed when starting up the WebContent process on iOS.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 4:01 PM Changeset in webkit [265266] by
-
- 24 edits2 copies in trunk
Align AudioListener with the W3C specification
https://bugs.webkit.org/show_bug.cgi?id=215134
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/historical-expected.txt:
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic-expected.txt:
Source/WebCore:
Align AudioListener with the W3C specification:
Note that the prefixed API still behaves the way it used to. I have maintained
the old version of the AudioListener API by moving it to a new
WebKitAudioListener interface.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioListener.cpp:
(WebCore::AudioListener::AudioListener):
(WebCore::AudioListener::setPosition):
(WebCore::AudioListener::position const):
(WebCore::AudioListener::setOrientation):
(WebCore::AudioListener::orientation const):
(WebCore::AudioListener::upVector const):
- Modules/webaudio/AudioListener.h:
(WebCore::AudioListener::create):
(WebCore::AudioListener::positionX):
(WebCore::AudioListener::positionY):
(WebCore::AudioListener::positionZ):
(WebCore::AudioListener::forwardX):
(WebCore::AudioListener::forwardY):
(WebCore::AudioListener::forwardZ):
(WebCore::AudioListener::upX):
(WebCore::AudioListener::upY):
(WebCore::AudioListener::upZ):
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::constructCommon):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::dopplerRate):
- Modules/webaudio/WebKitAudioContext.h:
(WebCore::WebKitAudioContext::listener):
- Modules/webaudio/WebKitAudioContext.idl:
- Modules/webaudio/WebKitAudioListener.h: Copied from Source/WebCore/Modules/webaudio/AudioListener.h.
- Modules/webaudio/WebKitAudioListener.idl: Copied from Source/WebCore/Modules/webaudio/AudioListener.idl.
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::listener):
- Modules/webaudio/WebKitAudioPannerNode.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- 3:54 PM Changeset in webkit [265265] by
-
- 2 edits in trunk/Source/WTF
[MSVC] wtf/Optional.h: error C2280: 'WTF::constexpr_storage_t<T> &WTF::constexpr_storage_t<T>::operator =(const WTF::constexpr_storage_t<T> &)': attempting to reference a deleted function
https://bugs.webkit.org/show_bug.cgi?id=215003
Reviewed by Yusuke Suzuki.
Microsoft reported the upcoming MSVC can't compile
Optional<std::pair<JSC::SamplingProfiler::StackFrame::CodeLocation,JSC::CodeBlock *>>.
wtf/Optional.h(419,39): error C2280: 'WTF::constexpr_storage_t<T> &WTF::constexpr_storage_t<T>::operator =(const WTF::constexpr_storage_t<T> &)': attempting to reference a deleted function
They suggests using std::is_trivially_copy_assignable_v in
Optional ctor instead of std::is_trivially_copyable_v.
- wtf/Optional.h:
(WTF::Optional::Optional): Replaced std::is_trivially_copyable_v with std::is_trivially_copy_assignable_v.
- 3:49 PM Changeset in webkit [265264] by
-
- 6 edits in trunk
[iOS] Check that Accessibility is enabled when receiving the enable Accessibility notification
https://bugs.webkit.org/show_bug.cgi?id=215112
Source/WebCore/PAL:
Reviewed by Youenn Fablet.
Declare NSApplication methods to enable enhanced accessibility user interface, and check if it is enabled.
- pal/spi/mac/NSApplicationSPI.h:
Source/WebKit:
<rdar://problem/66498397>
Reviewed by Youenn Fablet.
As a security mitigation, return early when handling this notification if Accessibility is not enabled.
API test: WebKit.AccessibilityHasNoPreferencesServiceAccessWhenPostingNotification
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
Tools:
Reviewed by Youenn Fablet.
Added test WebKit.AccessibilityHasNoPreferencesServiceAccessWhenPostingNotification.
- TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
(TEST):
- 3:39 PM Changeset in webkit [265263] by
-
- 2 edits in trunk/Source/WebKit
Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>
Reviewed by Eric Carlson.
We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).
We should not issue this extension on the iOS family of targets.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 3:18 PM Changeset in webkit [265262] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table
https://bugs.webkit.org/show_bug.cgi?id=215138
Reviewed by Devin Rousso.
Simplify LTR/RTL CSS code by using logical CSS properties. This patch doesn't introduce any visual changes.
- UserInterface/Views/DataGrid.css:
(.data-grid):
(.data-grid th:not(:last-child) > .header-cell-content):
(.data-grid:focus tr.selected td:not(:last-child)):
(body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content): Deleted.
(body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content): Deleted.
(body[dir=ltr] .data-grid:focus tr.selected td:not(:last-child)): Deleted.
(body[dir=rtl] .data-grid:focus tr.selected td:not(:last-child)): Deleted.
- UserInterface/Views/NetworkDetailView.css:
(.network-table.showing-detail .network-detail):
(body[dir=ltr] .network-table.showing-detail .network-detail): Deleted.
(body[dir=rtl] .network-table.showing-detail .network-detail): Deleted.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline td.graph-column):
(body[dir=ltr] .data-grid.timeline td.graph-column): Deleted.
(body[dir=rtl] .data-grid.timeline td.graph-column): Deleted.
- 3:02 PM Changeset in webkit [265261] by
-
- 5 edits in trunk/Source/WebCore
Add glyph origins member to GlyphBuffer
https://bugs.webkit.org/show_bug.cgi?id=215057
Reviewed by Darin Adler.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.
The solution for https://bugs.webkit.org/show_bug.cgi?id=214769 requires applying
letter-spacing after text shaping. Today, we apply letter-spacing before text
shaping, which is wrong. However, if we want to apply letter-spacing after text
shaping, we need to use CTFontShapeGlyphs(), which outputs glyph origins in
addition to glyph advances. Adding a glyph origins field to GlyphBuffer allows us
to flatten these origins at the appropriate places.
This patch is meant to be applied on top of
https://bugs.webkit.org/show_bug.cgi?id=215051, which decreases the inline sizes
of these vector members from 2048 to 1024. I measured the median and mean of these
strings in our Page Load Test to be 6 and 7.4, which indicates we were being wildly
inefficient with the members of GlyphBuffer. Decreasing these inline sizes means
we're now using less memory than we were before.
No new tests becasue there is no behavior change yet. This patch just adds the
field. The next patch will hook up CTFontShapeGlyphs() itself.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::drawText const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::drawGlyphBuffer const):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferOrigin::GlyphBufferOrigin):
(WebCore::GlyphBufferOrigin::operator FloatPoint):
(WebCore::GlyphBufferOrigin::setX):
(WebCore::GlyphBufferOrigin::setY):
(WebCore::GlyphBufferOrigin::x const):
(WebCore::GlyphBufferOrigin::y const):
(WebCore::GlyphBufferOrigin::encode const):
(WebCore::GlyphBufferOrigin::decode):
(WebCore::GlyphBuffer::clear):
(WebCore::GlyphBuffer::origins):
(WebCore::GlyphBuffer::origins const):
(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::remove):
(WebCore::GlyphBuffer::makeHole):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::flatten):
(WebCore::GlyphBuffer::isFlattened const):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawGlyphs):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const):
- 2:03 PM Changeset in webkit [265260] by
-
- 2 edits in trunk/Source/WebKit
[iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=215108
Reviewed by Youenn Fablet.
This asserts because it appears that the WebContent and Networking process do not have the required entitlement
com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Add the entitlement for simulator.
No new tests, covered by existing tests.
- Resources/ios/XPCService-embedded-simulator.entitlements:
- 1:55 PM Changeset in webkit [265259] by
-
- 14 edits2 adds in trunk
AX: VoiceOver needs access to font styling at insertion point
https://bugs.webkit.org/show_bug.cgi?id=215129
Source/WebCore:
<rdar://problem/65114972>
Reviewed by Darin Adler.
Give access to relevant font styling properties at the insertion point so that VoiceOver can speak them
when text commands alter styling.
Test: accessibility/mac/resolved-text-editing.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::resolvedEditingStyles const):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityResolvedEditingStyles]):
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::resolvedEditingStyles const):
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Reviewed by Darin Adler.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::attributeValueAsync):
LayoutTests:
Reviewed by Darin Adler.
- accessibility/mac/resolved-text-editing-expected.txt: Added.
- accessibility/mac/resolved-text-editing.html: Added.
- 1:50 PM Changeset in webkit [265258] by
-
- 3 edits5 adds in trunk
Add test coverage for handling redirects with App-Bound Domains
https://bugs.webkit.org/show_bug.cgi?id=215128
<rdar://problem/66528515>
Reviewed by Brady Eidson.
Tools:
We should always make a new WebView if the test options indicate an
app-bound view, because we need a new configuration.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::ensureViewSupportsOptionsForTest):
LayoutTests:
Add two new tests to confirm that App Bound Domains behaves correctly
for redirect cases: one for top-frame redirects, and one for sub-frame
redirects.
- http/tests/in-app-browser-privacy/resources/redirect.php: Added.
- http/tests/in-app-browser-privacy/sub-frame-redirect-to-non-app-bound-domain-blocked-expected.txt: Added.
- http/tests/in-app-browser-privacy/sub-frame-redirect-to-non-app-bound-domain-blocked.html: Added.
- http/tests/in-app-browser-privacy/top-frame-redirect-to-non-app-bound-domain-blocked-expected.txt: Added.
- http/tests/in-app-browser-privacy/top-frame-redirect-to-non-app-bound-domain-blocked.html: Added.
- 1:45 PM Changeset in webkit [265257] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r265019): ASSERTION FAILED: !m_impl m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::PlaybackSessionInterfaceAVKit::invalidate() https://bugs.webkit.org/show_bug.cgi?id=215118
Reviewed by Jer Noble.
Revert the change about using a WeakPtr of PlaybackSessionModel in r265019.
On WK1, a VideoFullscreenControllerContext (a subclass of PlaybackSessionModel)
object is created on the main thread, so we cannot use a WeakPtr of it on
the UI thread.
No new tests, fix an API test failure: WebKitLegacy.AudioSessionCategoryIOS.
- platform/ios/PlaybackSessionInterfaceAVKit.h:
- platform/ios/PlaybackSessionInterfaceAVKit.mm:
(WebCore::PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::playbackSessionModel const):
- 12:26 PM Changeset in webkit [265256] by
-
- 8 edits in trunk
Align AudioBufferSourceNode's start() / stop() with the specification
https://bugs.webkit.org/show_bug.cgi?id=215130
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline a couple of web-platform-tests now that they are passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-grain-expected.txt:
Source/WebCore:
Align AudioBufferSourceNode's start() / stop() with the specification:
- https://www.w3.org/TR/webaudio/#dom-audiobuffersourcenode-start
- https://www.w3.org/TR/webaudio/#dom-audioscheduledsourcenode-stop
In particular, we should throw a RangeError when the parameters are invalid,
not an InvalidStateError. Also, we should not return early if there is no
buffer.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::startPlaying):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::startLater):
(WebCore::AudioScheduledSourceNode::stopLater):
LayoutTests:
Rebaseline test because exception message changed.
- webaudio/audiobuffersource-exception-expected.txt:
- 12:24 PM Changeset in webkit [265255] by
-
- 2 edits in trunk/Source/WebKitLegacy/ios
Try to fix Catalyst build
https://bugs.webkit.org/show_bug.cgi?id=215133
rdar://66534119
- WebCoreSupport/WebVisiblePosition.mm: Add include of SimpleRange.h.
- 12:06 PM Changeset in webkit [265254] by
-
- 3 edits in trunk/Tools
[webkitcorepy] Use setup.py for the autoinstaller
https://bugs.webkit.org/show_bug.cgi?id=215067
<rdar://problem/66432719>
Reviewed by Stephanie Lewis.
- Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Add all requests dependencies.
- Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archiveinit): Add extension, tar.gz by default.
(Package.Archive.path): Support multiple file types.
(Package.Archive.unpack): Support .zip files.
(Package.init): Add slow_install flag.
(Package.archives): Handle case were a library does not have a tiny version.
(Package.install): Call setup.py instead of just moving the library out of the package.
- 11:56 AM Changeset in webkit [265253] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/canvas/draw-focus-if-needed.html is passing and expectations need to be removed
https://bugs.webkit.org/show_bug.cgi?id=214840
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 11:14 AM Changeset in webkit [265252] by
-
- 2 edits in trunk/Source/WTF
about: scheme URL constants should be backed by StaticStringImpl
https://bugs.webkit.org/show_bug.cgi?id=215113
Reviewed by Darin Adler.
- wtf/URL.cpp:
(WTF::aboutBlankURL):
(WTF::aboutSrcDocURL):
- 10:18 AM Changeset in webkit [265251] by
-
- 2 edits in branches/safari-610.1.25-branch/Source/WebKit
Cherry-pick r265222. rdar://problem/66528551
Fix the macCatalyst build
- UIProcess/EndowmentStateTracker.mm: (WebKit::EndowmentStateTracker::stateFromEndowments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:18 AM Changeset in webkit [265250] by
-
- 16 edits in branches/safari-610.1.25-branch/Source/JavaScriptCore
Cherry-pick r265186. rdar://problem/66528563
Unreviewed, reverting r265151.
https://bugs.webkit.org/show_bug.cgi?id=215074
Broke ARM64E JSC tests
Reverted changeset:
"validate untagArrayPtr"
https://bugs.webkit.org/show_bug.cgi?id=214953
https://trac.webkit.org/changeset/265151
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:14 AM Changeset in webkit [265249] by
-
- 2 edits in trunk/Tools
Add myself to contributors.json
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 9:56 AM Changeset in webkit [265248] by
-
- 15 edits2 adds in trunk
Add the ability of comparing the accessibility tree with isolated tree mode on and off.
https://bugs.webkit.org/show_bug.cgi?id=215000
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/mac/isolated-tree-mode-on-off.html
Added [WebAccessibilityObjectWrapper isIsolatedObject] for testing
purposes, so that layout tests can determine whether an object is
isolated or not. It should not be used by real clients since there
should be no difference in behavior of a WebAccessibilityObjectWrapper
from a client point of view, regardless the underlying object being
isolated or not.
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase isIsolatedObject]):
Tools:
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::setIsolatedTreeMode):
(WTR::AccessibilityController::setAccessibilityIsolatedTreeMode): Renamed setIsolatedTreeMode.
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
Exposes setIsolatedTreeMode to JavaScript code so that it can be turned
on and off in a layout tests.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
Exposes isIsolatedObject to JavaScript code so that layout tests can
check whether the underlying accessibility object is an AXIsolatedObject
or an AXObject.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting): Rename.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isIsolatedObject const):
LayoutTests:
- accessibility/mac/isolated-tree-mode-on-off-expected.txt: Added.
- accessibility/mac/isolated-tree-mode-on-off.html: Added.
- resources/accessibility-helper.js:
(dumpAccessibilityTree): In addition to dumping the accessibility tree
into an element with id="tree", it returns a string representation of
the accessibility tree.
- 9:53 AM Changeset in webkit [265247] by
-
- 1 copy in branches/safari-610.1.25-branch
New branch.
- 9:44 AM Changeset in webkit [265246] by
-
- 5 edits in trunk/Tools
[ews] Apple Silicon builder should skip non-relevant patches
https://bugs.webkit.org/show_bug.cgi?id=215111
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/factories.py:
(BuildFactory.init): Added the checkRelevance parameter.
(macOSBuildOnlyFactory.init):
- BuildSlaveSupport/ews-build/factories_unittest.py:
(TestBuildFactory.test_macos_build_only_factory): Updated unit-test.
- BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Added patch relevance info for Big Sur.
(CheckPatchRelevance._patch_is_relevant):
- BuildSlaveSupport/ews-build/steps_unittest.py:
(TestCheckPatchRelevance.test_relevant_bigsur_builder_patch): Drive-by fix to make the comparision more robust.
(TestCheckPatchRelevance.test_non_relevant_patch_on_various_queues): Made the unit-test generic to cover multiple queues.
(TestCheckPatchRelevance.test_non_relevant_patch): Deleted.
- 9:23 AM Changeset in webkit [265245] by
-
- 16 edits2 copies2 adds in trunk
Move non standard AudioBufferSourceNode API to new WebKitAudioBufferSourceNode interface
https://bugs.webkit.org/show_bug.cgi?id=215106
Reviewed by Eric Carlson.
Source/WebCore:
Move non standard AudioBufferSourceNode API to new WebKitAudioBufferSourceNode interface
to maintain backward compatibility while having an unprefixed API that matches the
specification:
In particular the 'playbackState' and 'gain' attributes should not part of the standard.
Test: webaudio/audiobuffersourcenode-legacy-api.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::reset):
- Modules/webaudio/AudioBufferSourceNode.h:
(WebCore::AudioBufferSourceNode::legacyGainValue const):
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/WebKitAudioBufferSourceNode.h: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
- Modules/webaudio/WebKitAudioBufferSourceNode.idl: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
- Modules/webaudio/WebKitAudioContext.cpp:
(WebCore::WebKitAudioContext::createWebKitBufferSource):
- Modules/webaudio/WebKitAudioContext.h:
- Modules/webaudio/WebKitAudioContext.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
Add layout test coverage.
- webaudio/audiobuffersourcenode-legacy-api-expected.txt: Added.
- webaudio/audiobuffersourcenode-legacy-api.html: Added.
- 9:01 AM Changeset in webkit [265244] by
-
- 4 edits in trunk/Source/WebCore
Remove AudioSampleDataSource::setPaused
https://bugs.webkit.org/show_bug.cgi?id=215125
Reviewed by Geoffrey Garen.
m_paused is unused except for setting m_transitioningFromPaused.
setPaused is only used in AudioMediaStreamTrackRenderCocoa at creation of the source.
We can remove the call for setPaused(true) and remove setPaused/m_paused.
- platform/audio/mac/AudioSampleDataSource.h:
- platform/audio/mac/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::setPaused): Deleted.
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
- 12:40 AM Changeset in webkit [265243] by
-
- 3 edits5 adds in trunk
Performance.getEntriesByName/Type should match case sensitive
https://bugs.webkit.org/show_bug.cgi?id=214960
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-04
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Import relevant test.
- web-platform-tests/performance-timeline/case-sensitivity.any-expected.txt: Added.
- web-platform-tests/performance-timeline/case-sensitivity.any.html: Added.
- web-platform-tests/performance-timeline/case-sensitivity.any.js: Added.
(test):
- web-platform-tests/performance-timeline/case-sensitivity.any.worker-expected.txt: Added.
- web-platform-tests/performance-timeline/case-sensitivity.any.worker.html: Added.
Source/WebCore:
Performance.getEntriesByName/Type should match case sensitive [1].
Behavior matches Firefox and Chrome.
Tests: imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.html
imported/w3c/web-platform-tests/performance-timeline/case-sensitivity.any.worker.html
[1] https://w3c.github.io/performance-timeline/#getentriesbytype-method
- page/Performance.cpp:
(WebCore::Performance::getEntriesByType const):
(WebCore::Performance::getEntriesByName const):
Aug 3, 2020:
- 10:57 PM Changeset in webkit [265242] by
-
- 4 edits in trunk/Source/WebCore
m_isEditableRegionEnabled should be reset in didCommitLoad, not didFinishLoad
https://bugs.webkit.org/show_bug.cgi?id=215115
Reviewed by Wenson Hsieh.
Resetting m_isEditableRegionEnabled in didFinishLoad() is too late because
inline script at the end of the <body> (e.g. in a layout test) will have already
run before the reset.
Fix by adding Page::didCommitLoad() and resetting m_isEditableRegionEnabled there.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
- page/Page.cpp:
(WebCore::Page::didCommitLoad):
(WebCore::Page::didFinishLoad):
- page/Page.h:
- 10:16 PM WPTUpdateBotDesign created by
- 9:49 PM Changeset in webkit [265241] by
-
- 4 edits in trunk/Source/WebCore
Unconditionally record string offsets in the fast text codepath
https://bugs.webkit.org/show_bug.cgi?id=215051
Reviewed by Darin Adler.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.
The solution for https://bugs.webkit.org/show_bug.cgi?id=214769 requires applying
letter-spacing after text shaping. Today, we apply letter-spacing before text
shaping, which is wrong. However, if we want to apply letter-spacing after text
shaping, we will need a way of mapping back which shaped glyphs correspond to
which characters in the string, so we can apply letter-spacing to the correct
glyphs. Therefore, we need to record string offsets any time letter-spacing can
be applied (which is all the time - letter spacing can be applied on any element).
This also helps on the path toward https://bugs.webkit.org/show_bug.cgi?id=214769.
When we move off the complex text codepath, we will need these string offsets
to calculate things like what the text range of a selection is when the user has
selected some glyphs on the page.
There is no performance change because these string offsets were already being
calculated; the difference is just that we're storing them now. Also, we were
being wildly inefficient with the members of GlyphBuffer, giving them inline
sizes of 2048. I measured the median and mean of these strings in our Page Load
Test to be 6 and 7.4. So, I cut down the inline sizes down to 1024, so now we're
using less memory than we were before.
No new tests because there is no behavior change. The additional string offsets
are unused (for now). A subsequent patch will start using them.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::layoutText const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::computeUnderlineType):
(WebCore::FontCascade::layoutSimpleText const):
(WebCore::FontCascade::layoutComplexText const):
(WebCore::FontCascade::dashesForIntersectionsWithRect const):
- platform/graphics/FontCascade.h:
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::clear):
(WebCore::GlyphBuffer::fonts):
(WebCore::GlyphBuffer::offsetsInString):
(WebCore::GlyphBuffer::fonts const):
(WebCore::GlyphBuffer::offsetsInString const):
(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::advanceAt const):
(WebCore::GlyphBuffer::stringOffsetAt const):
(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::remove):
(WebCore::GlyphBuffer::makeHole):
(WebCore::GlyphBuffer::expandLastAdvance):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::swap):
(WebCore::GlyphBuffer::saveOffsetsInString): Deleted.
(WebCore::GlyphBuffer::offsetInString const): Deleted.
- 9:32 PM Changeset in webkit [265240] by
-
- 5 edits in trunk/Source/WebCore
Rename WidthIterator::m_currentCharacter to WidthIterator::m_currentCharacterIndex
https://bugs.webkit.org/show_bug.cgi?id=215056
Reviewed by Darin Adler.
It represents an index, not a character.
No new tests because there is no behavior change.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::offsetForPositionForSimpleText const):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::currentCharacterIndex const):
(WebCore::WidthIterator::currentCharacter const): Deleted.
- 9:02 PM Changeset in webkit [265239] by
-
- 10 edits1 delete in trunk/LayoutTests
[GTK][WPE] Gardening some failures and rebaseline.
Unreviewed test gardening.
LayoutTests/imported/w3c:
Rebaseline expectations after r264478 updated the interface
descriptions.
- web-platform-tests/webxr/ar-module/idlharness.https.window-expected.txt:
- web-platform-tests/webxr/idlharness.https.window-expected.txt:
LayoutTests:
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/wpe/mathml/opentype/opentype-stretchy-expected.txt: Removed.
- 7:33 PM Changeset in webkit [265238] by
-
- 5 edits in trunk
Allow -accessoryDone to blur the focused element on iPad when AutoFilling strong passwords
https://bugs.webkit.org/show_bug.cgi?id=215105
<rdar://problem/65143984>
Reviewed by Tim Horton.
Source/WebKit:
-accessoryDoneis now used to dismiss the strong password AutoFill keyboard after choosing a password on iOS,
due to how it hides the keyboard without causing the content view to resign first responder; being stuck in a
state where the content view is not first responder causes several issues when choosing strong passwords on iOS,
such as keyboard shortcuts no longer working.
On iPad, to ensure that
-accessoryDoneactually dismisses the keyboard, we need to additionally teach
-endEditingAndUpdateFocusAppearanceWithReason:(when givenEndEditingReasonAccessoryDone) to allow the
focused element to blur when dismissing the strong password input view.
Test: KeyboardInputTests.TestWebViewAccessoryDoneDuringStrongPasswordAssistance
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
Refactor this logic into a local helper lambda with early returns, instead of using a single if statement.
Tools:
Add an API test that exercises the behavior change when run on iPad simulator.
- TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
- TestWebKitAPI/ios/UIKitSPI.h:
- 6:51 PM Changeset in webkit [265237] by
-
- 11 edits in trunk/Source/WebInspectorUI
Web Inspector: Change DataGrid and Table styles to closer match macOS
https://bugs.webkit.org/show_bug.cgi?id=214563
<rdar://problem/65841032>
Reviewed by Devin Rousso.
- Remove vertical borders from table contents and only keep them on the table headers.
- Use 1px borders instead of hairline (0.5px) borders to closer match macOS.
- Refactoring: add "sorted" CSS class on sorted header columns to replace
th:matches(.sort-ascending, .sort-descending)that is used 10 times with.sorted.
- UserInterface/Views/CPUTimelineView.css:
(.timeline-view.cpu :matches(.area-chart, .stacked-area-chart) .markers > div):
- UserInterface/Views/DataGrid.css:
(.data-grid):
--data-grid-column-border-start is no longer used, remove it.
(.data-grid.inline):
(.data-grid th):
(.data-grid th > .header-cell-content):
(body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content):
(body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content):
(.data-grid th.sortable:active):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child):
(.data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
Remove styles that are no longer relevant because columns don't have vertical borders anymore.
(.data-grid th.sort-ascending > .header-cell-content:first-child::after):
(.data-grid th.sort-descending > .header-cell-content:first-child::after):
(@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending) > .header-cell-content:first-child::after):
Don't change the background color of the sorted header cells to match macOS.
(body[dir=ltr] .data-grid :matches(th, td):not(:last-child)): Deleted.
(body[dir=rtl] .data-grid :matches(th, td):not(:last-child)): Deleted.
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after): Deleted.
(.data-grid th.sort-ascending > div:first-child::after): Deleted.
(.data-grid th.sort-descending > div:first-child::after): Deleted.
(.data-grid table:matches(.header, .data)): Deleted.
(body[dir=ltr] .data-grid :matches(th, td):first-child): Deleted.
(body[dir=rtl] .data-grid :matches(th, td):first-child): Deleted.
(@media (-webkit-min-device-pixel-ratio: 2) .data-grid table:matches(.header, .data)): Deleted.
(@media (-webkit-min-device-pixel-ratio: 2) .data-grid :matches(th, td):first-child): Deleted.
(@media (prefers-color-scheme: dark) .data-grid th.sortable:active): Deleted.
(@media (prefers-color-scheme: dark) .data-grid th.sort-ascending > div:first-child::after,): Deleted.
- UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype.insertColumn):
- UserInterface/Views/NetworkDetailView.css:
(body[dir=ltr] .network-table.showing-detail .network-detail):
(body[dir=rtl] .network-table.showing-detail .network-detail):
Now that columns don't have borders, add a vertical border to the Network details pane.
- UserInterface/Views/NetworkTableContentView.css:
(.network-table > .table .header .cell.waterfall:matches(.sort-ascending, .sort-descending)):
(body[dir=ltr] .network-table > .table :not(.header) .cell.waterfall):
(body[dir=rtl] .network-table > .table :not(.header) .cell.waterfall):
Add a vertical border for the zeroth mark of the graph.
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
(.timeline-overview-graph.rendering-frame > .divider):
- UserInterface/Views/Table.css:
(.table):
(.table > .header > .sortable:active):
(.table > .header > :matches(.sort-ascending, .sort-descending)):
(.table > .header .cell):
(.table > .header .cell:not(:first-child)::before):
(body[dir=ltr] .table > .header .cell:not(:first-child)::before):
(body[dir=rtl] .table > .header .cell:not(:first-child)::before):
(body[dir=ltr] .table .cell:not(:last-child)): Deleted.
(body[dir=rtl] .table .cell:not(:last-child)): Deleted.
(body[dir=ltr] .table .cell:first-child): Deleted.
(body[dir=rtl] .table .cell:first-child): Deleted.
(@media (prefers-color-scheme: dark) .table > .header > .sortable:active): Deleted.
(@media (prefers-color-scheme: dark) .table > .header > :matches(.sort-ascending, .sort-descending)): Deleted.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid th.graph-column:matches(.sort-ascending, .sort-descending)):
(.data-grid.timeline th.graph-column > .timeline-ruler):
(body[dir=ltr] .data-grid.timeline td.graph-column):
(body[dir=rtl] .data-grid.timeline td.graph-column):
Add a vertical border for the zeroth mark of the graph.
(.data-grid.timeline td.graph-column .timeline-record-bar):
(@media (prefers-color-scheme: dark) .data-grid th:matches(.sort-ascending, .sort-descending)): Deleted.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header > .divider > .label):
Reset font-weight from sorted column header.
(.timeline-ruler > .markers > .divider):
- UserInterface/Views/Variables.css:
(:root):
(@media (prefers-color-scheme: dark) :root):
Use more precise color for --even-zebra-stripe-row-background-color.
Drive-by: remove unused --border-color-dark variable.
- 6:16 PM Changeset in webkit [265236] by
-
- 2 edits in trunk/Source/WebCore/PAL
Check for the presence of libAccessibility before trying to load the _AXSIsolatedTreeMode function.
https://bugs.webkit.org/show_bug.cgi?id=215107
<rdar://problem/66192260>
Reviewed by Chris Fleizach.
- pal/spi/cocoa/AccessibilitySupportSoftLink.h:
Trying to load _AXSIsolatedTreeMode when the library is not present
triggers an assert.
- 6:05 PM Changeset in webkit [265235] by
-
- 10 edits in trunk/Source
Move user gesture propagation over promise behind a feature flag
https://bugs.webkit.org/show_bug.cgi?id=215014
Reviewed by Eric Carlson.
Source/WebCore:
If runtime flag is false, disable user gesture propagation to the next micro task.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueMicrotaskToEventLoop):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::userGesturePromisePropagationEnabled const):
(WebCore::RuntimeEnabledFeatures::setUserGesturePromisePropagationEnabled):
Source/WebKit:
Add a preference, on by default.
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences userGesturePromisePropagationEnabled]):
(-[WebPreferences setUserGesturePromisePropagationEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 5:36 PM Changeset in webkit [265234] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS Release ] imported/w3c/web-platform-tests/css/css-animations/webkit-writing-mode-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215110
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:31 PM Changeset in webkit [265233] by
-
- 17 edits2 copies in trunk
Add constructor for AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=215096
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
Source/WebCore:
Add constructor for AudioBufferSourceNode as per:
This patch also adds support for the detune attribute on AudioBufferSourceNode,
which gets initialized by the constructor.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::reset):
(WebCore::AudioBufferSourceNode::totalPitchRate):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioBufferSourceOptions.h: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
- Modules/webaudio/AudioBufferSourceOptions.idl: Copied from Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createBufferSource):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 5:24 PM Changeset in webkit [265232] by
-
- 6 edits in trunk/Source/WebCore
Add an EventRegions log channel
https://bugs.webkit.org/show_bug.cgi?id=215092
Reviewed by Daniel Bates.
Add a log channel for EventRegions, add logging in some interesting places.
- platform/Logging.h:
- rendering/EventRegion.cpp:
(WebCore::EventRegion::unite):
(WebCore::EventRegion::uniteTouchActions):
(WebCore::EventRegion::uniteEventListeners):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
- 5:15 PM Changeset in webkit [265231] by
-
- 7 edits in trunk/Source/WebCore
Make FontCascade.drawText() return a FloatSize instead of a float
https://bugs.webkit.org/show_bug.cgi?id=215055
Reviewed by Darin Adler.
Advances are philosophically two-dimensional data structures.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.
No new tests because there shouldn't be any behavior change. But in the weird
rare case where there might be, we should be defensive and handle it correctly.
I've never seen one of these cases, though.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawElementTitle):
- page/DebugPageOverlays.cpp:
(WebCore::drawRightAlignedText):
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::drawText const):
- platform/graphics/FontCascade.h:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawBidiText):
- platform/graphics/GraphicsContext.h:
- 4:43 PM Changeset in webkit [265230] by
-
- 2 edits in trunk/Source/WebKit
Null check parentProcessConnection when creating a NetworkDataTaskCocoa
https://bugs.webkit.org/show_bug.cgi?id=215109
<rdar://problem/64853922>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-03
Reviewed by Chris Dumez.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
Null check parentProcessConnection. Otherwise, we can dereference null and crash between disconnecting with the parent process and terminating,
which isn't the worst time to crash because we are trying to terminate anyways. But we may as well not crash.
- 3:53 PM Changeset in webkit [265229] by
-
- 4 edits1 add in trunk
Occasional crashes when running nested runloops while using UIWebView
https://bugs.webkit.org/show_bug.cgi?id=213067
<rdar://problem/64239727>
Reviewed by Darin Adler.
Source/WebCore:
New test: WebKitLegacy.NestedRunLoopUnderRunLoopObserverDoubleUnlock
- platform/ios/wak/WebCoreThread.mm:
(MainRunLoopAutoUnlock):
(_WebThreadAutoLock):
Under certain circumstances, a CFRunLoopObserver that is already removed
can fire again (e.g. when removed in a nested runloop, it can be fired again
in the main runloop).
The WebThread code assumes that the auto-unlock observer is called exactly
once after being installed. If this is not the case, the main thread lock
count can underflow, wreaking havoc the next time we try to lock.
Instead of depending on CFRunLoop to do this for us, make it explicit
with a global boolean.
This leaves in place the somewhat-odd behavior that running a nested
runloop can cause the main runloop's WebThread lock to be dropped, because
a great deal of code (and tests) depend on this behavior (keeping the lock
held until the outer runloop spins would result in deadlock if the inner
runloop's loop condition depends on the WebThread being able to execute code).
However, this is not unique to this underflow case, and appears to be
extremely long-standing behavior, so maintaining it seems the best course of action.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitLegacy/ios/WebThreadLock.mm: Added.
Add a API test that fails before this change.
- 3:48 PM Changeset in webkit [265228] by
-
- 36 edits in trunk
Remove the ENABLE_DATA_INTERACTION feature flag
https://bugs.webkit.org/show_bug.cgi?id=215091
Reviewed by Megan Gardner.
.:
- Source/cmake/OptionsFTW.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
ENABLE(DATA_INTERACTION)is an alias forPLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT). It was used early on
when bringing drag and drop support to iPad in order to hide the feature from open source WebKit code, and has
not been necessary for several years.
- page/DragController.cpp:
(WebCore::DragController::shouldUseCachedImageForDragImage const):
- page/DragController.h:
(WebCore::DragController::canLoadDataFromDraggingPasteboard const):
- page/EventHandler.cpp:
(WebCore::EventHandler::dragCancelled):
(WebCore::EventHandler::didStartDrag):
- page/FocusController.cpp:
(WebCore::shouldClearSelectionWhenChangingFocusedElement):
- page/mac/DragControllerMac.mm:
- platform/DragImage.cpp:
- platform/ios/WebItemProviderPasteboard.mm:
Source/WebCore/PAL:
- pal/spi/ios/UIKitSPI.h:
Source/WebKit:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/DragDropInteractionState.h:
- UIProcess/ios/DragDropInteractionState.mm:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
- UIProcess/ios/WebPageProxyIOS.mm:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebDragClient.mm:
- WebView/WebView.mm:
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
Source/WTF:
- wtf/PlatformEnable.h:
- wtf/PlatformEnableCocoa.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:41 PM Changeset in webkit [265227] by
-
- 15 edits2 copies in trunk
Add constructor for GainNode
https://bugs.webkit.org/show_bug.cgi?id=215093
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
Source/WebCore:
Add constructor for GainNode as per:
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createGain):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::create):
(WebCore::GainNode::GainNode):
(WebCore::GainNode::process):
(WebCore::GainNode::reset):
- Modules/webaudio/GainNode.h:
- Modules/webaudio/GainNode.idl:
- Modules/webaudio/GainOptions.h: Copied from Source/WebCore/Modules/webaudio/GainNode.idl.
- Modules/webaudio/GainOptions.idl: Copied from Source/WebCore/Modules/webaudio/GainNode.idl.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 3:34 PM Changeset in webkit [265226] by
-
- 2 edits in trunk/LayoutTests
[ macOS iOS ] fast/images/async-image-body-background-image.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=175193
Unreviewed test gardening.
Patch by Hector Lopez <Hector Lopez> on 2020-08-03
- platform/ios-wk2/TestExpectations:
- 3:28 PM Changeset in webkit [265225] by
-
- 1 copy in tags/Safari-610.1.24
Tag Safari-610.1.24.
- 3:16 PM Changeset in webkit [265224] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: "Show transparency grid" string needs to be disambiguated for localization
https://bugs.webkit.org/show_bug.cgi?id=215101
Reviewed by Darin Adler.
Add two different string keys with the same English translation. This is specifically
needed for Portuguese, apparently.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
- UserInterface/Views/GraphicsOverviewContentView.js:
(WI.GraphicsOverviewContentView):
- UserInterface/Views/ImageResourceContentView.js:
- UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
- UserInterface/Views/ResourceCollectionContentView.js:
(WI.ResourceCollectionContentView):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createSourcesSettingsView):
- 3:14 PM Changeset in webkit [265223] by
-
- 8 edits in trunk/Source
Versioning.
WebKit-610.1.26
- 2:49 PM Changeset in webkit [265222] by
-
- 2 edits in trunk/Source/WebKit
Fix the macCatalyst build
- UIProcess/EndowmentStateTracker.mm:
(WebKit::EndowmentStateTracker::stateFromEndowments):
- 2:49 PM Changeset in webkit [265221] by
-
- 17 edits2 copies in trunk
Add constructor to DelayNode
https://bugs.webkit.org/show_bug.cgi?id=215083
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
Source/WebCore:
Add constructor to DelayNode:
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createDelay):
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
(WebCore::DelayNode::create):
(WebCore::DelayNode::delayTime):
- Modules/webaudio/DelayNode.h:
- Modules/webaudio/DelayNode.idl:
- Modules/webaudio/DelayOptions.h: Copied from Source/WebCore/Modules/webaudio/DelayNode.idl.
- Modules/webaudio/DelayOptions.idl: Copied from Source/WebCore/Modules/webaudio/DelayNode.idl.
- Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
- Modules/webaudio/DelayProcessor.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 2:35 PM Changeset in webkit [265220] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r243301): Network: initiator column missing
https://bugs.webkit.org/show_bug.cgi?id=215044
Reviewed by Brian Burg.
- UserInterface/Views/NetworkTimelineView.js:
(WI.NetworkTimelineView):
- 2:05 PM Changeset in webkit [265219] by
-
- 1 edit1 delete in trunk/Source/ThirdParty/libwebrtc
Remove libwebrtc protobuf copy
https://bugs.webkit.org/show_bug.cgi?id=215076
rdar://problem/66291604
Reviewed by Eric Carlson.
This is not used currently and contains code that is not up to date.
- Source/third_party/protobuf: Removed.
- 2:04 PM Changeset in webkit [265218] by
-
- 5 edits in trunk/Source/WebCore
Make WidthIterator::advance() return void
https://bugs.webkit.org/show_bug.cgi?id=215053
Reviewed by Darin Adler.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769
and https://bugs.webkit.org/show_bug.cgi?id=206208.
This is a small simplification in the fast text codepath. It used to return
how many characters were consumed. However, this information is already
exposed by just calling currentCharacter() on the width iterator before and
after calling advance().
No new tests because there is no behavior change.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::drawText const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::layoutSimpleText const):
(WebCore::FontCascade::adjustSelectionRectForSimpleText const):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
- platform/graphics/WidthIterator.h:
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
- 2:02 PM Changeset in webkit [265217] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GTK] 2.29.4 fails to build in armhf
https://bugs.webkit.org/show_bug.cgi?id=214966
Reviewed by Michael Catanzaro.
SP register cannot be used as a destination register of SUB or ADD
on Thumb mode.
- llint/LowLevelInterpreter32_64.asm:
- 2:01 PM Changeset in webkit [265216] by
-
- 3 edits in trunk/Source/WebCore
MediaRecorderPrivateWriter should ensure its writer input is ready for more data before appending new samples
https://bugs.webkit.org/show_bug.cgi?id=215081
Reviewed by Eric Carlson.
After r265192, we were checking whether the writer input was ready.
If so, we were pushing pending samples and then the new sample.
The issue is that pushing pending samples might make the writer input no longer ready.
Update the code to enqueue the sample if its writer input is not ready.
Add an ASSERT in appendCompressedVideoSampleBuffer to make sure this is the case.
Also make sure that we only enqueue the end of segment sample if video writer input is ready.
Make sure flushCompressedSampleBuffers is called directly by stopRecording only if not already flushing samples.
If we are not flushing, we proceed with the stop steps.
If not, we wait for the end of flushCompressedSampleBuffers to proceed with the stop steps.
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::stopRecording):
(WebCore::MediaRecorderPrivateWriter::finishedFlushingSamples):
(WebCore::MediaRecorderPrivateWriter::doStopRecording):
- 1:59 PM Changeset in webkit [265215] by
-
- 4 edits in trunk/Source
Finalize the list of MobileGestalt queries needed to populate the in-memory cache in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=215095
<rdar://problem/66034080>
Reviewed by Geoffrey Garen.
Source/WebCore/PAL:
Declare constants for MobileGestalt questions.
- pal/spi/ios/MobileGestaltSPI.h:
Source/WebKit:
When the MobileGestalt cache is invalid, we issue a temporary extension to the MobileGestalt daemon for the WebContent process,
which will populate the in-memory cache by doing a set of MobileGestalt queries before revoking the extension. This patch
finalizes the list of MobileGestalt queries needed to populate the in-memory cache in the WebContent process on iOS before
revoking the temporary extension to com.apple.mobilegestalt.xpc. This list was compiled by querying every possible MobileGestalt
key after the temporary extension was revoked, and make a note of all queries that were contacting the MobileGestalt daemon to
get the answer. The added queries in this patch should make the list complete, and ensures that all cachable values are in the
in-memory cache before revoking the extension, since every possible MobileGestalt query was tested. This again means that users
that have an invalid MobileGestalt cache, will have access to the exact same MobileGestalt values, as those users who have a
valid MobileGestalt cache.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 1:45 PM Changeset in webkit [265214] by
-
- 2 edits in trunk/LayoutTests
Regression (r265160): http/tests/misc/gamepads-insecure.html fails consistently on windows
https://bugs.webkit.org/show_bug.cgi?id=215099
Unreviewed test gardening.
- platform/win/TestExpectations: Skip this test on Windows since gamepad isn't supported.
- 1:40 PM Changeset in webkit [265213] by
-
- 5 edits in trunk
[iOS 14] editing/selection/ios/select-all-non-editable-text-using-keyboard.html sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=215089
<rdar://problem/66282806>
Reviewed by Tim Horton.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
Tools:
Add some logging to try and diagnose this flaky test failure. The timeout only happens on iOS 14, and also does
not reproduce on my local machine. This patch tests a couple of hypotheses which may explain why the test times
out:
- The test may be starting in a state where the content view is not first responder, or the view's window is
not the key window.
- Synthesizing the modifier keydown HID event may be failing to change the live modifier flags on the
application's
GSKeyboardRef(e.g. the issue that was fixed in <https://trac.webkit.org/r264907>).
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::keyDown):
- WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp handleKeyHIDEvent:]):
- 1:38 PM Changeset in webkit [265212] by
-
- 2 edits in trunk/Tools
Disable gtk-wk2 queue temporarily
https://bugs.webkit.org/show_bug.cgi?id=215098
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/config.json:
- 1:29 PM Changeset in webkit [265211] by
-
- 8 edits in trunk
REGRESSION (r264170): fast/events/touch/ios/long-press-on-image.html times out
https://bugs.webkit.org/show_bug.cgi?id=215075
<rdar://problem/66294637>
Reviewed by Megan Gardner.
Tools:
This test started timing out after r264170, due to the
if (self.showingContextMenu)early return added inside
-[TestRunnerWKWebView _didShowContextMenu]. If this test is run after another test that attempts to show a
context menu but does not dismiss it, we will begin the test in a state whereshowingContextMenuis already
set toYES, which means thatdidShowContextMenuCallbackwill never be invoked.
To address this, force any context menu interactions on
WKContentViewto dismiss between tests. See below for
more details.
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView immediatelyDismissContextMenuIfNeeded]):
When resetting state between tests, forcibly dismiss any context menus that were shown while running the
previous test and resetshowingContextMenuback toNO.
(-[TestRunnerWKWebView contentView]):
Drive-by refactoring: add a readonly helper property to grab the WKWebView's content view for testing purposes,
and use this property instead of directly calling-valueForKeyPath:in a few places (see below).
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::notifyDone):
(WTR::TestController::platformResetStateToConsistentValues):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::platformContentView const):
(WTR::UIScriptControllerIOS::calendarType const):
LayoutTests:
Drive-by fix: this helper function had intended to use the
didDismissContextMenuCallbackproperty to register
callbacks for context menu dismissal, but instead, it sets a new property (didHideContextMenuCallback) on
UIScriptControllerthat doesn't actually have any effect. The purpose of doing this is to make it safe to
invokewaitForInputSessionToDismiss()in the middle of the context menu dismissal animation when dismissing
date pickers on iOS. While it seems that none of our existing tests currently depend on this behavior in order
to pass, it still seems important to fix to avoid timing out when using this helper method in the future.
- resources/ui-helper.js:
(window.UIHelper.waitForInputSessionToDismiss.return.new.Promise.):
(window.UIHelper.waitForInputSessionToDismiss.return.new.Promise):
(window.UIHelper.waitForInputSessionToDismiss):
- 12:22 PM Changeset in webkit [265210] by
-
- 26 edits2 adds in trunk
Added AudioBuffer Constructor
https://bugs.webkit.org/show_bug.cgi?id=214990
Patch by Clark Wang <clark_wang@apple.com> on 2020-08-03
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Re-baselined existing tests. Some now fail due to unsupported sampleRate.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
Source/WebCore:
Added AudioBuffer constructor according to spec: https://www.w3.org/TR/webaudio/#AudioBuffer-constructors.
Added in AudioBufferOptions files. Updated BaseAudioContext::createBuffer to use new constructor.
Re-baselined existing tests. Some fail now due to unsupported sampleRate.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
(WebCore::AudioBuffer::AudioBuffer):
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferOptions.h: Added.
- Modules/webaudio/AudioBufferOptions.idl: Added.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createBuffer):
- Modules/webaudio/BaseAudioContext.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
Re-baselined existing tests. Some now fail due to unsupported sampleRate.
- TestExpectations:
- webaudio/audiobuffer-crash-expected.txt:
- webaudio/audiobuffersource-channels-expected.txt:
- 11:31 AM Changeset in webkit [265209] by
-
- 4 edits in trunk
should be able to request an editing context for a given region of a given input
https://bugs.webkit.org/show_bug.cgi?id=215042
<rdar://problem/65561491>
Reviewed by Wenson Hsieh.
Source/WebKit:
Right now, it's only possible to request an editing context for either an entire input
element or a particular rect of the page. It should be possible to request an editing
context for a particular rect within a given input element as well (e.g. get one paragraph
or the currently selected text in a<textarea>instead of the entire thing).
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(TEST.DocumentEditingContext.SpatialRequest_RectEncompassingInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectBeforeInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectInsideInput): Added.
(TEST.DocumentEditingContext.SpatialRequest_RectAfterInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectEncompassingInputWithSelection): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectBeforeInputWithSelection): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectBeforeSelectionInInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectAfterSelectionInInput): Added.
(TEST.DocumentEditingContext.SpatialAndCurrentSelectionRequest_RectAfterInputWithSelection): Added.
- 11:19 AM Changeset in webkit [265208] by
-
- 83 edits in trunk
[WebGL2] webgl/2.0.0/conformance[2]/textures/image_bitmap* failures
https://bugs.webkit.org/show_bug.cgi?id=211484
Patch by Kenneth Russell <kbr@chromium.org> on 2020-08-03
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Rebaseline a test which is now passing.
- web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt:
Source/WebCore:
Implement ImageBitmapOptions' ImageOrientation and
PremultiplyAlpha settings.
ImageOrientation="flipY" is supported directly while constructing
ImageBitmap's representation, ImageBuffer.
PremultiplyAlpha="premultiply" can not be supported via
ImageBuffer's graphics operations, so this attribute is stored on
ImageBitmap, serialized and deserialized when ImageBitmap is
transferred, and handled in the WebGL implementation.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readImageBitmap):
(WebCore::SerializedScriptValue::SerializedScriptValue):
- bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::SerializedScriptValue):
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::create):
(WebCore::ImageBitmap::detachBitmaps):
(WebCore::imageOrientationForOrientation):
(WebCore::ImageBitmap::createPromise):
(WebCore::ImageBitmap::createFromBuffer):
- html/ImageBitmap.h:
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::transferToImageBitmap):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImageSourceHelper):
- platform/graphics/ImageBuffer.h:
LayoutTests:
Rebaseline and/or enable several dozen WebGL tests under:
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_blob/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_canvas/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image/
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_video/
which are now passing.
- TestExpectations:
- webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgb-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgb-rgb-unsigned_short_5_6_5-expected.txt:
- webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_short_4_4_4_4-expected.txt:
- webgl/2.0.0/conformance/textures/image_bitmap_from_canvas/tex-2d-rgba-rgba-unsigned_short_5_5_5_1-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r16f-red-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r32f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8-red-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-r8ui-red_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg16f-rg-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg32f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8-rg-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r16f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r16f-red-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r32f-red-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r8-red-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg16f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg16f-rg-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg32f-rg-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg8-rg-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rg8ui-rg_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb16f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb16f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb32f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb565-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb565-rgb-unsigned_short_5_6_5-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb5_a1-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb5_a1-rgba-unsigned_short_5_5_5_1-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb9_e5-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgb9_e5-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba16f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba16f-rgba-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba32f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba4-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_canvas/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba16f-rgba-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba32f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_image/tex-3d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba16f-rgba-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba32f-rgba-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba4-rgba-unsigned_short_4_4_4_4-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-rgba8ui-rgba_integer-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8-rgb-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-2d-srgb8_alpha8-rgba-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r11f_g11f_b10f-rgb-half_float-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8-red-unsigned_byte-expected.txt:
- webgl/2.0.0/conformance2/textures/image_bitmap_from_video/tex-3d-r8ui-red_integer-unsigned_byte-expected.txt:
- webgl/TestExpectations:
- 11:00 AM Changeset in webkit [265207] by
-
- 2 edits in trunk/Source/WebCore
[WebDriver] window.print should not invoke native UI
https://bugs.webkit.org/show_bug.cgi?id=215084
Reviewed by Devin Rousso.
This could be handled at a higher level if there is a valid use case to allow printing,
but I'm not aware of one. For now, this fixes a script evaluation hang on Mac and iOS.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::print):
Don't call out to print delegates if this is a WebDriver-controlled page.
- 10:49 AM Changeset in webkit [265206] by
-
- 3 edits in trunk/Source/WebCore
Remove unused API in HighlightMap
https://bugs.webkit.org/show_bug.cgi?id=215078
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-03
Reviewed by Sam Weinig.
Remove unused API in HighlightMap, this is probably not needed
anymore since the maplike code changed at some point.
- Modules/highlight/HighlightMap.cpp:
(WebCore::HighlightMap::getGroupForKey): Deleted.
- Modules/highlight/HighlightMap.h:
- 10:49 AM Changeset in webkit [265205] by
-
- 2 edits in trunk/Source/WebCore
[WebGL2] Assert when restoring lost context
https://bugs.webkit.org/show_bug.cgi?id=214999
Patch by James Darpinian <James Darpinian> on 2020-08-03
Reviewed by Darin Adler.
Remove an assert that was wrong when restoring a lost context.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
- 10:30 AM Changeset in webkit [265204] by
-
- 2 edits in trunk/Tools
run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words
https://bugs.webkit.org/show_bug.cgi?id=215077
Reviewed by Alexey Proskuryakov.
- Scripts/run-jsc-stress-tests:
- 10:27 AM Changeset in webkit [265203] by
-
- 1 edit688 deletes in trunk/LayoutTests
Remove duplicate layout test results
https://bugs.webkit.org/show_bug.cgi?id=215069
Reviewed by Darin Adler.
Remove results deleted by check-for-duplicated-platform-test-results.
- platform/glib/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/svg/shapes/scripted/disabled-shapes-not-hit-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/contain-and-cover-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/gtk/fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt: Removed.
- platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/animations/seeking-events-4-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
- platform/gtk/media/video-controls-no-scripting-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
- platform/gtk/svg/custom/circular-marker-reference-2-expected.txt: Removed.
- platform/gtk/svg/custom/non-circular-marker-reference-expected.txt: Removed.
- platform/ios-13/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Removed.
- platform/ios-13/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
- platform/ios-13/fast/inline/br-text-decoration-expected.txt: Removed.
- platform/ios-13/fast/layers/inline-dirty-z-order-lists-expected.txt: Removed.
- platform/ios-13/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Removed.
- platform/ios-13/fast/text/international/bidi-LDB-2-CSS-expected.txt: Removed.
- platform/ios-13/fast/text/international/bidi-LDB-2-HTML-expected.txt: Removed.
- platform/ios-13/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Removed.
- platform/ios-simulator/fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt: Removed.
- platform/ios-simulator/webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt: Removed.
- platform/ios-wk2/compositing/overflow/overflow-scroll-expected.txt: Removed.
- platform/ios-wk2/compositing/overflow/scrollbar-painting-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Removed.
- platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Removed.
- platform/ios-wk2/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
- platform/ios-wk2/fast/clip/014-expected.txt: Removed.
- platform/ios-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
- platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Removed.
- platform/ios-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
- platform/ios-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
- platform/ios-wk2/fast/forms/tabbing-input-iframe-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/overflow-unsplittable-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/BottomToTop-bt-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/BottomToTop-lr-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/BottomToTop-rl-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/BottomToTop-tb-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/RightToLeft-bt-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/RightToLeft-lr-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/pagination/RightToLeft-tb-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/vertical-rl/column-rules-expected.txt: Removed.
- platform/ios-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
- platform/ios-wk2/fast/overflow/overflow-auto-position-absolute-expected.txt: Removed.
- platform/ios-wk2/fast/overflow/paged-x-div-expected.txt: Removed.
- platform/ios-wk2/fast/overflow/paged-x-div-with-column-gap-expected.txt: Removed.
- platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Removed.
- platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/preventScroll-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
- platform/ios/animations/3d/replace-filling-transform-expected.txt: Removed.
- platform/ios/animations/animation-offscreen-to-onscreen-expected.txt: Removed.
- platform/ios/animations/opacity-transform-animation-expected.txt: Removed.
- platform/ios/animations/suspend-transform-animation-expected.txt: Removed.
- platform/ios/compositing/contents-opaque/background-clip-expected.txt: Removed.
- platform/ios/compositing/contents-opaque/background-color-expected.txt: Removed.
- platform/ios/compositing/contents-opaque/table-parts-expected.txt: Removed.
- platform/ios/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
- platform/ios/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Removed.
- platform/ios/css3/calc/line-height-expected.txt: Removed.
- platform/ios/fast/attachment/attachment-disabled-dom-expected.txt: Removed.
- platform/ios/fast/attachment/attachment-dom-expected.txt: Removed.
- platform/ios/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
- platform/ios/fast/borders/border-radius-different-width-001-expected.txt: Removed.
- platform/ios/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
- platform/ios/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
- platform/ios/fast/dynamic/001-expected.txt: Removed.
- platform/ios/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
- platform/ios/fast/events/constructors/keyboard-event-constructor-expected.txt: Removed.
- platform/ios/fast/forms/005-expected.txt: Removed.
- platform/ios/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
- platform/ios/fast/reflections/table-cell-expected.txt: Removed.
- platform/ios/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
- platform/ios/fast/table/008-expected.txt: Removed.
- platform/ios/fast/table/caption-relayout-expected.txt: Removed.
- platform/ios/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/ios/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/ios/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
- platform/ios/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/ios/fast/table/table-row-split2-expected.txt: Removed.
- platform/ios/fast/table/table-section-split2-expected.txt: Removed.
- platform/ios/fast/table/table-split-expected.txt: Removed.
- platform/ios/fast/table/table-split2-expected.txt: Removed.
- platform/ios/fast/text/system-font-weight-expected.txt: Removed.
- platform/ios/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
- platform/ios/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt: Removed.
- platform/ios/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio-affects-container-width-when-height-changes-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
- platform/ios/quicklook/numbers-expected.html: Removed.
- platform/ios/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/ios/swipe/basic-cached-back-swipe-expected.txt: Removed.
- platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/ios/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/ios/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
- platform/ios/webaudio/audiobuffersource-expected.wav: Removed.
- platform/ios/webaudio/audiobuffersource-multi-channels-expected.wav: Removed.
- platform/ios/webaudio/audiochannelmerger-stereo-expected.txt: Removed.
- platform/ios/webaudio/audionode-channel-rules-expected.txt: Removed.
- platform/ios/webaudio/audionode-connect-order-expected.txt: Removed.
- platform/ios/webaudio/audioparam-connect-audioratesignal-expected.txt: Removed.
- platform/ios/webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Removed.
- platform/ios/webaudio/audioparam-linearRampToValueAtTime-expected.txt: Removed.
- platform/ios/webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
- platform/ios/webaudio/audioparam-setValueAtTime-expected.txt: Removed.
- platform/ios/webaudio/audioparam-setValueCurveAtTime-expected.txt: Removed.
- platform/ios/webaudio/audioparam-summingjunction-expected.txt: Removed.
- platform/ios/webaudio/audioprocessingevent-expected.txt: Removed.
- platform/ios/webaudio/automatic-pull-node-expected.txt: Removed.
- platform/ios/webaudio/biquad-allpass-expected.txt: Removed.
- platform/ios/webaudio/biquad-bandpass-expected.txt: Removed.
- platform/ios/webaudio/biquad-getFrequencyResponse-expected.txt: Removed.
- platform/ios/webaudio/biquad-highpass-expected.txt: Removed.
- platform/ios/webaudio/biquad-highshelf-expected.txt: Removed.
- platform/ios/webaudio/biquad-lowpass-expected.txt: Removed.
- platform/ios/webaudio/biquad-lowshelf-expected.txt: Removed.
- platform/ios/webaudio/biquad-notch-expected.txt: Removed.
- platform/ios/webaudio/biquad-peaking-expected.txt: Removed.
- platform/ios/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.
- platform/ios/webaudio/convolution-mono-mono-expected.txt: Removed.
- platform/ios/webaudio/delaynode-expected.txt: Removed.
- platform/ios/webaudio/delaynode-max-default-delay-expected.txt: Removed.
- platform/ios/webaudio/delaynode-max-nondefault-delay-expected.txt: Removed.
- platform/ios/webaudio/delaynode-maxdelay-expected.txt: Removed.
- platform/ios/webaudio/delaynode-scheduling-expected.txt: Removed.
- platform/ios/webaudio/dynamicscompressor-basic-expected.txt: Removed.
- platform/ios/webaudio/gain-basic-expected.txt: Removed.
- platform/ios/webaudio/gain-expected.wav: Removed.
- platform/ios/webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
- platform/ios/webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
- platform/ios/webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
- platform/ios/webaudio/mediaelementaudiosourcenode-gc-expected.txt: Removed.
- platform/ios/webaudio/mixing-expected.wav: Removed.
- platform/ios/webaudio/oscillator-sine-expected.wav: Removed.
- platform/ios/webaudio/panner-equalpower-expected.txt: Removed.
- platform/ios/webaudio/panner-equalpower-stereo-expected.txt: Removed.
- platform/ios/webaudio/realtimeanalyser-fft-scaling-expected.txt: Removed.
- platform/ios/webaudio/sample-accurate-scheduling-expected.txt: Removed.
- platform/ios/webaudio/stereo2mono-down-mixing-expected.txt: Removed.
- platform/ios/webaudio/test-basic-expected.wav: Removed.
- platform/ios/webaudio/up-mixing-mono-51-expected.wav: Removed.
- platform/ios/webaudio/up-mixing-mono-stereo-expected.wav: Removed.
- platform/ios/webaudio/up-mixing-stereo-51-expected.wav: Removed.
- platform/ios/webaudio/waveshaper-expected.txt: Removed.
- platform/ios/webaudio/waveshaper-oversample-2x-expected.txt: Removed.
- platform/ios/webaudio/waveshaper-oversample-4x-expected.txt: Removed.
- platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
- platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
- platform/mac-mojave/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
- platform/mac-wk1/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Removed.
- platform/mac-wk1/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
- platform/mac-wk1/http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/joint-session-history/joint-session-history-only-fully-active-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/001-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/002-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-miterlimit-computed-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-computed-expected.txt: Removed.
- platform/mac-wk1/inspector/model/remote-object/number-expected.txt: Removed.
- platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: Removed.
- platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Removed.
- platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
- platform/mac/accessibility/negative-tabindex-does-not-expose-label-expected.txt: Removed.
- platform/mac/accessibility/svg-bounds-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Removed.
- platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-traversal-expected.txt: Removed.
- platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Removed.
- platform/mac/compositing/contents-opaque/table-parts-expected.txt: Removed.
- platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
- platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Removed.
- platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
- platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/mac/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
- platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
- platform/mac/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
- platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/mac/fast/css/image-rendering-expected.txt: Removed.
- platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/mac/fast/dom/HTMLImageElement/resources/blue_rect.jpg: Removed.
- platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Removed.
- platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/mac/fast/dynamic/001-expected.txt: Removed.
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
- platform/mac/fast/events/document-elementFromPoint-expected.txt: Removed.
- platform/mac/fast/flexbox/flex-hang-expected.txt: Removed.
- platform/mac/fast/forms/005-expected.txt: Removed.
- platform/mac/fast/images/repaint-subrect-grid-expected.txt: Removed.
- platform/mac/fast/images/zoomed-img-size-expected.txt: Removed.
- platform/mac/fast/invalid/018-expected.txt: Removed.
- platform/mac/fast/lists/list-marker-before-content-table-expected.txt: Removed.
- platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Removed.
- platform/mac/fast/multicol/break-properties-expected.txt: Removed.
- platform/mac/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
- platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
- platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
- platform/mac/fast/parser/style-script-head-test-expected.txt: Removed.
- platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Removed.
- platform/mac/fast/reflections/table-cell-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
- platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-col-background-expected.txt: Removed.
- platform/mac/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/mac/fast/repaint/table-row-expected.txt: Removed.
- platform/mac/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/mac/fast/repaint/table-writing-modes-h-expected.txt: Removed.
- platform/mac/fast/repaint/table-writing-modes-v-expected.txt: Removed.
- platform/mac/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
- platform/mac/fast/table/008-expected.txt: Removed.
- platform/mac/fast/table/031-expected.txt: Removed.
- platform/mac/fast/table/032-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/bug14274-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
- platform/mac/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
- platform/mac/fast/table/caption-relayout-expected.txt: Removed.
- platform/mac/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/mac/fast/table/height-percent-test-expected.txt: Removed.
- platform/mac/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/mac/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
- platform/mac/fast/table/table-anonymous-row-bug-expected.txt: Removed.
- platform/mac/fast/table/table-anonymous-section-bug-expected.txt: Removed.
- platform/mac/fast/table/table-before-child-style-update-expected.txt: Removed.
- platform/mac/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
- platform/mac/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
- platform/mac/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
- platform/mac/fast/table/table-cell-split-expected.txt: Removed.
- platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
- platform/mac/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
- platform/mac/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
- platform/mac/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
- platform/mac/fast/table/table-row-before-child-style-update-expected.txt: Removed.
- platform/mac/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/mac/fast/table/table-row-split2-expected.txt: Removed.
- platform/mac/fast/table/table-row-style-not-updated-expected.txt: Removed.
- platform/mac/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
- platform/mac/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
- platform/mac/fast/table/table-section-split2-expected.txt: Removed.
- platform/mac/fast/table/table-split-expected.txt: Removed.
- platform/mac/fast/table/table-split2-expected.txt: Removed.
- platform/mac/fast/table/table-style-not-updated-expected.txt: Removed.
- platform/mac/fast/table/wide-colspan-expected.txt: Removed.
- platform/mac/fast/table/wide-column-expected.txt: Removed.
- platform/mac/fast/text/whitespace/013-expected.txt: Removed.
- platform/mac/fast/text/whitespace/014-expected.txt: Removed.
- platform/mac/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
- platform/mac/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Removed.
- platform/mac/http/tests/inspector/network/resource-sizes-memory-cache-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
- platform/mac/media/track/video-track-alternate-groups-expected.txt: Removed.
- platform/mac/security/block-test-expected.txt: Removed.
- platform/mac/security/block-test-no-port-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
- platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
- platform/mac/svg/custom/fractional-rects-expected.txt: Removed.
- platform/mac/svg/custom/js-update-container-expected.txt: Removed.
- platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
- platform/mac/svg/custom/viewBox-hit-expected.txt: Removed.
- platform/mac/svg/hixie/text/001-expected.txt: Removed.
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
- platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Removed.
- platform/mac/svg/text/text-hkern-expected.txt: Removed.
- platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
- platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug56201-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/mac/userscripts/script-run-at-end-expected.txt: Removed.
- platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
- platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
- platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/win/css2.1/tables/table-anonymous-objects-181-expected.txt: Removed.
- platform/win/editing/deleting/smart-delete-001-expected.txt: Removed.
- platform/win/editing/deleting/smart-delete-002-expected.txt: Removed.
- platform/win/editing/deleting/smart-delete-003-expected.txt: Removed.
- platform/win/editing/deleting/smart-delete-004-expected.txt: Removed.
- platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/win/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
- platform/win/fast/borders/border-radius-different-width-001-expected.txt: Removed.
- platform/win/fast/borders/table-borders-expected.txt: Removed.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/win/fast/canvas/fallback-content-expected.txt: Removed.
- platform/win/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
- platform/win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
- platform/win/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
- platform/win/fast/css/button-height-expected.txt: Removed.
- platform/win/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/win/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/win/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/win/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/win/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/win/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/win/fast/css/first-letter-block-form-controls-crash-expected.txt: Removed.
- platform/win/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/win/fast/css/percentage-non-integer-expected.txt: Removed.
- platform/win/fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Removed.
- platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/win/fast/dom/adopt-attribute-crash-expected.txt: Removed.
- platform/win/fast/dom/adopt-node-crash-2-expected.txt: Removed.
- platform/win/fast/dynamic/001-expected.txt: Removed.
- platform/win/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
- platform/win/fast/events/event-attribute-expected.txt: Removed.
- platform/win/fast/events/ondragenter-expected.txt: Removed.
- platform/win/fast/forms/005-expected.txt: Removed.
- platform/win/fast/forms/access-key-for-all-elements-expected.txt: Removed.
- platform/win/fast/forms/form-associated-element-crash3-expected.txt: Removed.
- platform/win/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
- platform/win/fast/invalid/012-expected.txt: Removed.
- platform/win/fast/lists/list-marker-before-content-table-expected.txt: Removed.
- platform/win/fast/multicol/renderer-positioned-assert-crash-expected.txt: Removed.
- platform/win/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
- platform/win/fast/reflections/table-cell-expected.txt: Removed.
- platform/win/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
- platform/win/fast/repaint/float-overflow-expected.txt: Removed.
- platform/win/fast/repaint/float-overflow-right-expected.txt: Removed.
- platform/win/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-col-background-expected.txt: Removed.
- platform/win/fast/repaint/table-hover-on-link-expected.txt: Removed.
- platform/win/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/win/fast/repaint/table-row-expected.txt: Removed.
- platform/win/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-section-repaint-expected.txt: Removed.
- platform/win/fast/repaint/table-writing-modes-h-expected.txt: Removed.
- platform/win/fast/repaint/table-writing-modes-v-expected.txt: Removed.
- platform/win/fast/replaced/005-expected.txt: Removed.
- platform/win/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
- platform/win/fast/table/005-expected.txt: Removed.
- platform/win/fast/table/006-expected.txt: Removed.
- platform/win/fast/table/008-expected.txt: Removed.
- platform/win/fast/table/013-expected.txt: Removed.
- platform/win/fast/table/031-expected.txt: Removed.
- platform/win/fast/table/032-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/002-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/002-vertical-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/bug14274-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
- platform/win/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
- platform/win/fast/table/caption-relayout-expected.txt: Removed.
- platform/win/fast/table/dynamic-cellpadding-expected.txt: Removed.
- platform/win/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/win/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/win/fast/table/height-percent-test-expected.txt: Removed.
- platform/win/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/win/fast/table/multiple-percent-height-rows-expected.txt: Removed.
- platform/win/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
- platform/win/fast/table/table-anonymous-row-bug-expected.txt: Removed.
- platform/win/fast/table/table-anonymous-section-bug-expected.txt: Removed.
- platform/win/fast/table/table-before-child-style-update-expected.txt: Removed.
- platform/win/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
- platform/win/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
- platform/win/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
- platform/win/fast/table/table-cell-split-expected.txt: Removed.
- platform/win/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
- platform/win/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
- platform/win/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
- platform/win/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
- platform/win/fast/table/table-row-before-child-style-update-expected.txt: Removed.
- platform/win/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/win/fast/table/table-row-split2-expected.txt: Removed.
- platform/win/fast/table/table-row-style-not-updated-expected.txt: Removed.
- platform/win/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
- platform/win/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
- platform/win/fast/table/table-section-split2-expected.txt: Removed.
- platform/win/fast/table/table-split-expected.txt: Removed.
- platform/win/fast/table/table-split2-expected.txt: Removed.
- platform/win/fast/table/table-style-not-updated-expected.txt: Removed.
- platform/win/fast/table/wide-colspan-expected.txt: Removed.
- platform/win/fast/table/wide-column-expected.txt: Removed.
- platform/win/fast/text/whitespace/013-expected.txt: Removed.
- platform/win/fast/text/whitespace/014-expected.txt: Removed.
- platform/win/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
- platform/win/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
- platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Removed.
- platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Removed.
- platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Removed.
- platform/win/svg/custom/glyph-setting-d-attribute-expected.png: Removed.
- platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
- platform/win/svg/foreignObject/text-tref-02-b-expected.png: Removed.
- platform/win/svg/text/kerning-expected.png: Removed.
- platform/win/svg/text/multichar-glyph-expected.png: Removed.
- platform/win/tables/mozilla/bugs/bug106795-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug1220-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug1261-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug139524-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug139524-3-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug139524-4-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug15933-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug18440-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug2123-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug219693-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug219693-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug22513-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug2585-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug46944-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug53690-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug53690-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug55789-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug56201-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug8361-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug97383-expected.txt: Removed.
- platform/win/tables/mozilla/other/slashlogo-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Removed.
- platform/wincairo/css3/calc/line-height-expected.txt: Removed.
- platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt: Removed.
- platform/wk2/http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled-expected.txt: Removed.
- platform/wk2/http/tests/contentextensions/block-everything-unless-domain-expected.txt: Removed.
- platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Removed.
- platform/wk2/http/tests/security/drag-drop-local-file-expected.txt: Removed.
- platform/wk2/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
- platform/wk2/webarchive/loading/javascript-url-iframe-crash-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
- platform/wpe/webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt: Removed.
- platform/wpe/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.
- 10:13 AM Changeset in webkit [265202] by
-
- 7 edits in trunk/Source/WebKit
doesParentProcessHaveITPEnabled() check should match behavior in determineITPStateInternal() check
https://bugs.webkit.org/show_bug.cgi?id=215031
<rdar://problem/66384618>
Reviewed by Brent Fulgham.
Checking ITP state from a WebKit child process should have the same
behavior as checking it from the UI process. In order to do this,
we must pass the value of hasRequestedCrossWebsiteTrackingPermission
to the network process to know if an application has included the
NSCrossWebsiteTrackingUsageDescription value in their Info.plist.
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::activateSessionCleanup):
- Shared/Cocoa/DefaultWebBrowserChecks.h:
- Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::hasRequestedCrossWebsiteTrackingPermission):
(WebKit::doesParentProcessHaveITPEnabled):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- 9:59 AM Changeset in webkit [265201] by
-
- 2 edits in trunk/Tools
REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
https://bugs.webkit.org/show_bug.cgi?id=215038
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/results/options.py:
(upload_options):
For compatibility, make it possible to create the option with a differently-named flag.
- 9:54 AM Changeset in webkit [265200] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215088
Unreviewed test gardening.
Patch by Hector Lopez <Hector Lopez> on 2020-08-03
- platform/mac-wk2/TestExpectations:
- 9:42 AM Changeset in webkit [265199] by
-
- 16 edits in trunk/Source
Non-unified build fixes, early August 20202 edition
https://bugs.webkit.org/show_bug.cgi?id=215082
Unreviewed build fix.
Source/JavaScriptCore:
- dfg/DFGOSREntry.h: Add missing inclusion of CodeLocation.h
- ftl/FTLGeneratedFunction.h: Ditto.
- jit/CallFrameShuffler.h: Forward-declare CCallHelpers.
Source/WebCore:
No new tests needed.
- accessibility/AccessibilityRenderObject.cpp: Add missing inclusion of Range.h.
- dom/RadioButtonGroups.cpp: Ditto.
- editing/Editing.cpp: Ditto.
- editing/EditingStyle.cpp: Ditto.
- editing/EditorCommand.cpp: Ditto.
- editing/FrameSelection.cpp: Ditto.
- editing/TypingCommand.cpp: Ditto.
- editing/VisiblePosition.cpp: Add missing inclusion of SimpleRange.h.
- rendering/HitTestResult.cpp: Add missing inclusion of Range.h.
Source/WebKit:
- WebProcess/WebPage/FindController.h: Add missing inclusion of WebCore/SimpleRange.h.
- 9:18 AM Changeset in webkit [265198] by
-
- 5 edits2 adds in trunk
REGRESSION(r259585) Text decoration color with value currentColor miscomputed in some cases
https://bugs.webkit.org/show_bug.cgi?id=215079
Reviewed by Zalan Bujtas.
Source/WebCore:
r259585 did some refactoring that broke a special case where text decoration color comes from
'-webkit-text-fill-color' property.
Test: fast/text/text-decoration-currentcolor-fill-color.html
- rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::decorationColor):
Move resolving currentColor to RenderStyle.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorResolvingCurrentColor const):
Handle CSSPropertyTextDecorationColor as a special case here.
(WebCore::RenderStyle::visitedDependentColor const):
LayoutTests:
- fast/text/text-decoration-currentcolor-fill-color-expected.html: Added.
- fast/text/text-decoration-currentcolor-fill-color.html: Added.
- 9:03 AM Changeset in webkit [265197] by
-
- 3 edits in trunk/LayoutTests
[ macOS wk2 Release ] media/video-background-tab-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=209353
Unreviewed test gardening.
Patch by Hector Lopez <Hector Lopez> on 2020-08-03
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 8:51 AM Changeset in webkit [265196] by
-
- 18 edits2 adds in trunk
Added Constructor to AnalyserNode
https://bugs.webkit.org/show_bug.cgi?id=215040
Patch by Clark Wang <clark_wang@apple.com> on 2020-08-03
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Re-baselined existing tests.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-sizing-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
Source/WebCore:
Introduced AnalyserNode constructor and AnalyserOptions according to spec:
https://www.w3.org/TR/webaudio/#AnalyserNode-constructors.
Re-baselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::create):
(WebCore::AnalyserNode::AnalyserNode):
(WebCore::AnalyserNode::setFftSize):
(WebCore::AnalyserNode::setMinMaxDecibels):
(WebCore::AnalyserNode::setMinDecibels):
(WebCore::AnalyserNode::setMaxDecibels):
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AnalyserOptions.h: Added.
- Modules/webaudio/AnalyserOptions.idl: Added.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createAnalyser):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
Re-baselined existing tests.
- webaudio/analyser-exception-expected.txt:
- 5:29 AM Changeset in webkit [265195] by
-
- 2 edits in trunk/Tools
[WPE][GTK] run-minibrowser no longer assumes release configuration by default
https://bugs.webkit.org/show_bug.cgi?id=214961
Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.
- Scripts/webkitpy/port/base.py:
(Port.set_option_default): Ensure default value is set on optparsed options. In the case of
the default build configuration being set from the Port constructor, this wasn't done
properly. After fixing this, the WPE and GTK ports are correctly implicitely reusing the
build configuration option through the _build_path() method.
- 5:26 AM Changeset in webkit [265194] by
-
- 2 edits in trunk/Tools
REGRESSION(r264096): [flatpak] Clean gst-build within build-webkit fails
https://bugs.webkit.org/show_bug.cgi?id=214080
Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Don't attempt to configure the gst-env when starting sccache-dist.
- 4:44 AM Changeset in webkit [265193] by
-
- 2 edits in trunk/JSTests
[JSC][MIPS] Test gardening July 31st edition
https://bugs.webkit.org/show_bug.cgi?id=215023
Unreviewed Gardening.
- stress/typedarray-access-neutered.js:
- 3:09 AM Changeset in webkit [265192] by
-
- 3 edits in trunk/Source/WebCore
MediaRecorderPrivateWriter::appendEndOfVideoSampleDurationIfNeeded should only call requestMediaDataWhenReadyOnQueue once
https://bugs.webkit.org/show_bug.cgi?id=214972
Reviewed by Eric Carlson.
When processing a compressed sample, pass it to the writer if its ready.
Otherwise buffer it and retry passing it to the writer next time we have a sample.
When finishing a write, we call requestMediaDataWhenReadyOnQueue to finish passing samples that are still enqueued.
Covered by existing tests no longer triggering ObjC exception.
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedAudioSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedVideoSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):
Aug 2, 2020:
- 11:41 PM Changeset in webkit [265191] by
-
- 6 edits in trunk/Tools
Improve the check-for-duplicated-platform-test-results script
https://bugs.webkit.org/show_bug.cgi?id=215072
Reviewed by Darin Adler.
check-for-duplicated-platform-test-results had some problems.
First, it defaulted to -wk1 results directories, and didn't check -wk2 directories, so
run the logic twice, with options.webkit_test_runner True and False.
Second, it only looked for results in the most specific fallback directory, so
with a fallback path like 'mac-mojave-wk1 -> mac-mojave -> mac-wk1 -> mac -> generic'
it would only remove results in mac-mojave-wk1, not in 'mac-mojave'.
Also add some logging to the script.
- Scripts/check-for-duplicated-platform-test-results:
(remove_layout_test_path_prefix):
(check_duplicate.sha1):
(check_duplicate):
(platform_list):
(find_duplicates_in_path):
(find_duplicates_in_path.find_duplicates):
(check_platform):
(main):
- Scripts/webkitpy/port/base.py:
(Port.supports_layout_tests): Some ports (iOS and watch device ports) don't support
testing with no associated device. Need to fix errors thrown from default_baseline_search_path().
- Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort.supports_layout_tests):
- Scripts/webkitpy/port/watch_device.py:
(WatchDevicePort.supports_layout_tests):
- Scripts/webkitpy/port/win.py: self._os_version is None when run on another platform.
(WinPort.default_baseline_search_path):
(WinCairoPort._search_paths):
- 5:47 PM Changeset in webkit [265190] by
-
- 59 edits in trunk/Source
Remove some member functions of Range and many calls to createLiveRange
https://bugs.webkit.org/show_bug.cgi?id=215070
Reviewed by Sam Weinig.
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::nextBoundary): Remove createLiveRange.
(WebCore::AXObjectCache::previousBoundary): Ditto.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper positionForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Ditto.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]): Ditto.
- dom/DocumentMarkerController.cpp:
(WebCore::updateRenderedRectsForMarker): Renamed range to makeSimpleRange.
(WebCore::makeSimpleRange): Ditto.
- dom/DocumentMarkerController.h: Update for the above.
- dom/Range.cpp:
(WebCore::Range::text const): Use makeSimpleRange.
(WebCore::Range::shadowRoot const): Deleted.
(WebCore::intervalsSufficientlyOverlap): Deleted.
(WebCore::adjustLineHeightOfSelectionRects): Deleted.
(WebCore::coalesceSelectionRects): Deleted.
(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines const): Deleted.
(WebCore::Range::collectSelectionRects const): Deleted.
- dom/Range.h: Update for the above. Also make pastLastNode private since it is
only used inside the Range class's implementation.
- dom/SimpleRange.cpp:
(WebCore::SimpleRange::SimpleRange): Removed overload that takes a Range.
- dom/SimpleRange.h: Update for the above. Removed both constructor overloads
that take a Range.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired): Remove createLiveRange.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use
makeSimpleRange.
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
Remove createLiveRange.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleAtSelectionStart): Remove createLiveRange.
- editing/Editor.cpp:
(WebCore::Editor::performCutOrCopy): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::replaceRangeForSpellChecking): Ditto.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Change out
argument type to SimpleRange.
- editing/InsertListCommand.h: Update for above.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::isCheckable const): Rewrite questionable logic
to use intersectingNodes instead of firstNode.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findUngrammaticalPhrases const): Remove createLiveRange.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- editing/markup.cpp:
(WebCore::createFragmentFromText): Ditto.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAsChildOfElement): Use makeRangeSelectingNodeContents.
- editing/win/EditorWin.cpp:
(WebCore::Editor::pasteWithPasteboard): Remove createLiveRange.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange): Use makeSimpleRange.
(WebCore::DOMSelection::deleteFromDocument): Remove createLiveRange.
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Take SimpleRange.
(WebCore::DragController::concludeEditDrag): Remove createLiveRange.
(WebCore::DragController::startDrag): Ditto.
- page/TextIndicator.cpp:
(WebCore::selectionRects): Deleted.
(WebCore::initializeIndicator): Call collectSelectionRects directly here,
avoiding createLiveRange and using map to convert from Vector<SelectionRect>
to Vector<FloatRect>.
- page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Use makeSimpleRange.
- platform/DragImage.cpp:
(WebCore::createDragImageForRange): Take SimpleRange.
- platform/DragImage.h: Update createDragImageForRange to take SimpleRange.
- platform/Pasteboard.h: Updated Windows-only layering-violating functions
to take SimpleRange.
- platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForRange): Take SimpleRange.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject): Take SimpleRange.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.
- rendering/RenderObject.cpp:
(WebCore::intervalsSufficientlyOverlap): Added. Moved from Range. Mostly unchanged
but uses SimpleRange now instead of a live range, and intersectingNodes instead of
a loop using firstNode and pastLastNode.
(WebCore::adjustLineHeightOfSelectionRects): Ditto.
(WebCore::coalesceSelectionRects): Ditto.
(WebCore::RenderObject::collectSelectionRectsWithoutUnionInteriorLines): Ditto.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.
(WebCore::RenderObject::collectSelectionRects): Ditto.
- rendering/RenderObject.h: Update for above.
- testing/Internals.cpp:
(WebCore::Internals::markerRangeForNode): Use makeSimplRange.
(WebCore::Internals::locationFromRange): Ditto.
(WebCore::Internals::lengthFromRange): Ditto.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Ditto.
(WebCore::Internals::subrange): Ditto.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.
(WebCore::Internals::textIndicatorForRange): Ditto.
Source/WebKit:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Use makeSimpleRange.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(API::PageOverlayClientImpl::actionContextForResultAtPoint): Ditto.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange textRects]): Ditto.
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
(-[WKDOMTextIterator initWithRange:]): Ditto.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Remove createLiveRange.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const): Ditto.
(WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.
Source/WebKitLegacy/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame selectionRectsForCoreRange:]): Remove createLiveRange.
(-[WebFrame selectionRectsForRange:]): Use makeSimpleRange.
- WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Ditto.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Rename firstVP/secondVP
to firstPosition/secondPosition.
Source/WebKitLegacy/mac:
- DOM/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Use makeSimpleRange.
(-[DOMRange textRects]): Ditto.
- DOM/DOMDocument.mm: Update includes.
- DOM/DOMRange.mm: Ditto.
- DOM/DOMRangeInternal.h: Ditto.
- DOM/DOMUIKitExtensions.mm: Ditto.
- DOM/DOMUtility.mm: Ditto.
- DOM/WebDOMOperations.mm:
(-[DOMRange webArchive]): Use makeSimpleRange.
(-[DOMRange markupString]): Ditto.
- WebView/WebFrame.mm:
(-[WebFrame _stringForRange:]): Use makeSimpleRange.
(-[WebFrame _convertToDOMRange:]): Return a SimpleRange.
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Ditto.
(-[WebFrame _convertNSRangeToDOMRange:]): Update for above.
(-[WebFrame _convertDOMRangeToNSRange:]): Use makeSimpleRange.
(-[WebFrame _selectNSRange:]): Update for above.
(-[WebFrame selectWithoutClosingTypingNSRange:]): Ditto.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use makeSimpleRange.
(-[WebFrame dictationResultMetadataForRange:]): Ditto.
- WebView/WebFrameInternal.h: Update for above.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Use makeSimpleRange.
(-[WebHTMLView attributedSubstringFromRange:]): Use auto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Deleted.
(-[WebHTMLView attributedString]): Rewrote to use SimpleRange consistently.
(-[WebHTMLView selectedAttributedString]): Ditto.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForDataDetectedText]):
Use makeSimpleRange.
- WebView/WebTextIterator.mm:
(-[WebTextIterator initWithRange:]): Ditto.
- WebView/WebView.mm:
(-[WebView _didConcludeEditDrag]): Remove createLiveRange.
- 4:05 PM Changeset in webkit [265189] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix CLoop build
https://bugs.webkit.org/show_bug.cgi?id=215010
- tools/SigillCrashAnalyzer.cpp:
- 1:49 PM Changeset in webkit [265188] by
-
- 4 edits in trunk
Table data is incorrectly translated in some articles on en.wikipedia.org
https://bugs.webkit.org/show_bug.cgi?id=215071
<rdar://problem/66354013>
Reviewed by Darin Adler.
Source/WebCore:
Text in table cells sometimes end up in adjacent cells after translation, since adjacent cells are currently
extracted as different tokens in a single item; mitigate this by splitting text in table cells into different
text manipulation items instead.
Test: TextManipulation.StartTextManipulationExtractsTableCellsAsSeparateItems
- editing/TextManipulationController.cpp:
(WebCore::isEnclosingItemBoundaryElement):
Tools:
Add a new API test to exercise the change.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 8:12 AM Changeset in webkit [265187] by
-
- 9 edits1 add52 deletes in trunk
Write a script to find duplicate files and delete some duplicate tests in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=215073
Reviewed by Anders Carlsson.
Tools:
- Scripts/find-duplicate-files: Added. Basic script that uses MD5 digests
to find duplicate files.
- Scripts/report-non-inclusive-language: Tweaked a tiny bit; use a variable.
LayoutTests:
- TestExpectations: Removed expectations for removed tests.
- css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Removed.
The above was just a stray copy of a test with the wrong extension, so ignored.
- css3/font-variant-petite-caps-synthesis-coverage-expected.html: Removed.
- css3/font-variant-petite-caps-synthesis-coverage.html: Removed.
- css3/font-variant-small-caps-synthesis-coverage-expected.html: Removed.
- css3/font-variant-small-caps-synthesis-coverage.html: Removed.
These are duplicates of the same tests without the suffix "coverage".
- fast/dom/Document/document-close-iframe-load-expected.txt: Removed.
- fast/dom/Document/document-close-iframe-load.html: Removed.
- fast/dom/Document/document-close-nested-iframe-load-expected.txt: Removed.
- fast/dom/Document/document-close-nested-iframe-load.html: Removed.
These tests are also in the directory "fast/parser". Chose to delete this copy.
- fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Removed.
- fast/forms/label/labels-set-htmlFor-attribute.html: Removed.
This test also exists under the name "labels-change-...".
- fast/loader/unload-form-about-blank-expected.txt: Removed.
- fast/loader/unload-form-about-blank.html: Removed.
This test also exists under the name "unload-form-post-about-blank...".
- fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
- fast/ruby/before-table-doesnt-crash.html: Removed.
This is just a copy of the test "before-block-...", not a separate test.
- http/tests/misc/submit-post-in-utf16be.html:
Used the iconv tool to turn this into a UTF-16BE input file so it tests
what it is intended to test. Before this was a UTF-16LE file.
- imported/blink/001-a-expected.html: Removed.
- imported/blink/001-a.html: Removed.
- imported/blink/001-q-expected.html: Removed.
- imported/blink/001-q.html: Removed.
- imported/blink/001-s-expected.html: Removed.
- imported/blink/001-s.html: Removed.
These are identical duplicates of tests that are in WPT.
- imported/blink/animations/animation-events-prefixed-04-expected.txt: Removed.
- imported/blink/animations/animation-events-prefixed-04.html: Removed.
- imported/blink/animations/animation-events-unprefixed-04-expected.txt: Removed.
- imported/blink/animations/animation-events-unprefixed-04.html: Removed.
These are duplicates of tests in the directory imported/blink/virtual/stable/animations-unprefixed.
- imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash-expected.txt: Removed.
- imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html: Removed.
- imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Removed.
- imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Removed.
- imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Removed.
- imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Removed.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Removed.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html: Removed.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Removed.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Removed.
- imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Removed.
These are identical duplicates of tests in the same named directories outside "imported/blink".
Maybe imported by Blink from WebKit and then back?
- imported/blink/img_border_percent-expected.xhtml: Removed.
- imported/blink/img_border_percent.xhtml: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space-expected.html: Removed.
- imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space.html: Removed.
- imported/blink/object_border_perc-expected.xhtml: Removed.
- imported/blink/object_border_perc.xhtml: Removed.
- imported/blink/object_border_pixel-expected.xhtml: Removed.
- imported/blink/object_border_pixel.xhtml: Removed.
These are identical duplicates of tests that are in WPT.
- platform/gtk/TestExpectations: Removed expectations for removed tests.
- platform/ios/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- platform/wpe/TestExpectations: Ditto.
- svg/dom/SVGLengthList-removeItem-expected.txt: Removed.
- svg/dom/SVGLengthList-removeItem.xhtml: Removed.
This was a duplicate of the SVGLengthList-addItem test.
- 1:22 AM Changeset in webkit [265186] by
-
- 16 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r265151.
https://bugs.webkit.org/show_bug.cgi?id=215074
Broke ARM64E JSC tests
Reverted changeset:
"validate untagArrayPtr"
https://bugs.webkit.org/show_bug.cgi?id=214953
https://trac.webkit.org/changeset/265151
Aug 1, 2020:
- 11:21 PM Changeset in webkit [265185] by
-
- 3 edits in trunk/Source/WebCore
Remove superfluous ResourceTiming constructor overload
https://bugs.webkit.org/show_bug.cgi?id=215063
Patch by Rob Buis <rbuis@igalia.com> on 2020-08-01
Reviewed by Sam Weinig.
Remove superfluous ResourceTiming constructor overload, we
can just call another overload from ResourceTiming::fromLoad.
- loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::fromLoad):
- loader/ResourceTiming.h:
- 8:19 PM Changeset in webkit [265184] by
-
- 2 edits in trunk/LayoutTests
Remove test expectation for a WPT test that was removed
https://bugs.webkit.org/show_bug.cgi?id=215066
rdar://42904780
Reviewed by Sam Weinig.
- platform/mac-wk1/TestExpectations: Removed failure expectation for
a WPT WebCryptoAPI test that no longer exists.
- 7:53 PM Changeset in webkit [265183] by
-
- 11 edits1 copy3 adds in trunk
Special HID mapping for the Logitech F310/F710 controllers.
https://bugs.webkit.org/show_bug.cgi?id=215050
Reviewed by Tim Horton.
Source/WebCore:
Covered by API test.
These two controllers match the standard mapping perfectly. Easy to support.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/gamepad/KnownGamepads.h:
- platform/gamepad/mac/GamepadConstantsMac.h:
- platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::create):
- platform/gamepad/mac/HIDGamepadElement.cpp:
(WebCore::HIDGamepadElement::HIDGamepadElement):
- platform/gamepad/mac/HIDGamepadElement.h:
(WebCore::HIDGamepadElement::isAxis const):
- platform/gamepad/mac/LogitechGamepad.cpp: Added.
(WebCore::LogitechGamepadHatswitch::gamepadValueChanged):
(WebCore::LogitechGamepad::LogitechGamepad):
- platform/gamepad/mac/LogitechGamepad.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/HIDGamepads.mm:
- TestWebKitAPI/mac/GamepadMappings/LogitechF310.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF310Mapping):
- TestWebKitAPI/mac/GamepadMappings/LogitechF710.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF710Mapping):
- TestWebKitAPI/mac/VirtualGamepad.h:
- 6:50 PM Changeset in webkit [265182] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Remove the build warnings below since r265150.
warning: unused parameter ‘foo’ [-Wunused-parameter]
No new tests, no new behaviors.
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::doCertificatesMatch):
- 6:18 PM Changeset in webkit [265181] by
-
- 3 edits in trunk/Source/WebKit
Fix and further refine makefile rule for WebKit messages generated files
https://bugs.webkit.org/show_bug.cgi?id=215064
Reviewed by Sam Weinig.
- DerivedSources-output.xcfilelist: Updated for a file that was omitted
because of a typo in the makefile.
- DerivedSources.make: Fix "addsufix" typo and reorganized things a bit.
- 3:55 PM Changeset in webkit [265180] by
-
- 13 edits1 copy2 adds in trunk
Special HID mapping for the Google Stadia controller
https://bugs.webkit.org/show_bug.cgi?id=215061
Reviewed by Tim Horton.
Source/WebCore:
New API test coverage.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/gamepad/GamepadConstants.h:
- platform/gamepad/KnownGamepads.h:
- platform/gamepad/mac/GamepadConstantsMac.h:
- platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::create):
- platform/gamepad/mac/HIDGamepadElement.cpp:
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadHatswitch::gamepadValueChanged):
(WebCore::HIDGamepadHatswitch::normalizedValue):
- platform/gamepad/mac/HIDGamepadElement.h:
(WebCore::HIDGamepadElement::isAxis const):
(WebCore::HIDGamepadHatswitch::HIDGamepadHatswitch):
- platform/gamepad/mac/StadiaHIDGamepad.cpp: Added.
(WebCore::StadiaHIDGamepad::StadiaHIDGamepad):
- platform/gamepad/mac/StadiaHIDGamepad.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/HIDGamepads.mm:
- TestWebKitAPI/mac/GamepadMappings/GoogleStadia.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::googleStadiaMapping):
- TestWebKitAPI/mac/VirtualGamepad.h:
- 2:48 PM Changeset in webkit [265179] by
-
- 7 edits in trunk/Source
Unreviewed, reverting r265097, r265113, and r265122.
https://bugs.webkit.org/show_bug.cgi?id=215065
Broke AppleSilicon Big Sur
Reverted changesets:
"Strip pointers instead of authing for byteOffset to not allow
for a possible way to guess data pac"
https://bugs.webkit.org/show_bug.cgi?id=214952
https://trac.webkit.org/changeset/265097
"Compute number of PAC bits from what the OS says its address
space is"
https://bugs.webkit.org/show_bug.cgi?id=214986
https://trac.webkit.org/changeset/265113
"Remove UB from nonPACBitsMask computation"
https://bugs.webkit.org/show_bug.cgi?id=214996
https://trac.webkit.org/changeset/265122
- 10:54 AM Changeset in webkit [265178] by
-
- 2 edits in trunk/Source/WebKit
Prevent multiple invocations of generate-message-receiver.py
https://bugs.webkit.org/show_bug.cgi?id=215054
Reviewed by Darin Adler.
WebKit/DerivedSources.make is written such that
generate-message-receiver.py can be invoked N times, where N is the
value passed to -j. This results in the N invocations of
generate-message-receiver.py trying trying to generate the same set of
files at the same time, possibly leading to their being corrupted. We
have reports of generated files starting with a 4K block of NULs, and
this contention may be causing it. Address this by using a "pattern
rule" in the makefile, which is documented in GNU make's documentation
as the approach to take when there is one build rule that creates
multiple outputs, as is the case here.
See also <https://bugs.webkit.org/show_bug.cgi?id=166814> and
<http://trac.webkit.org/changeset/210507>.
No new tests -- no new or changed functionality.
- DerivedSources.make:
- 10:51 AM Changeset in webkit [265177] by
-
- 3 edits in trunk/Source/WebCore
Convert LinkHeader to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=215017
Reviewed by Darin Adler.
Update LinkHeader parsing to use StringParsingBuffer and do some light cleanup.
- loader/LinkHeader.cpp:
(WebCore::isSpaceOrTab):
(WebCore::isNotURLTerminatingChar):
(WebCore::isValidParameterNameChar):
(WebCore::isParameterValueEnd):
(WebCore::isParameterValueChar):
(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::validFieldEnd):
(WebCore::parseParameterDelimiter):
(WebCore::paramterNameFromString):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):
(WebCore::LinkHeader::LinkHeader):
(WebCore::LinkHeaderSet::LinkHeaderSet):
(WebCore::LinkHeaderSet::init): Deleted.
- loader/LinkHeader.h:
- 8:50 AM Changeset in webkit [265176] by
-
- 64 edits in trunk/Source
Remove Range::create and many more uses of live ranges
https://bugs.webkit.org/show_bug.cgi?id=215004
Reviewed by Sam Weinig.
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const):
Use makeSimpleRange.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Use SimpleRange.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(rangeLengthForObject): Take SimpleRange.
(webkitAccessibleHyperlinkGetStartIndex): Use makeSimpleRange.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject): Ditto.
- accessibility/atk/WebKitAccessibleUtil.cpp:
(objectFocusedAndCaretOffsetUnignored): Ditto.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
Take SimpleRange.
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use makeSimpleRange.
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRange]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]): Use auto.
(-[WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:]):
Remove createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Add createLiveRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
Use auto.
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]): Get rid of local.
(-[WebAccessibilityObjectWrapper textMarkersForRange:]): Take SimpleRange.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilityTextOperationForParameterizedAttribute): Remove makeSimpleRange.
(accessibilityMisspellingSearchCriteriaForParameterizedAttribute): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]): Take SimpleRange.
(textMarkerRangeFromRange): Ditto.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForRange:isStart:]): Ditto.
(startOrEndTextmarkerForRange): Return SimpleRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use auto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeAtTextMarker:forUnit:]): Ditto.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.
- dom/DocumentMarkerController.cpp:
(WebCore::updateRenderedRectsForMarker): Use document marker range function.
(WebCore::range): Added.
- dom/DocumentMarkerController.h: Update for above.
- dom/Position.cpp: Removed unneeded Range.h include.
- dom/Range.cpp:
(WebCore::Range::Range): Removed unused overload that takes start/end.
(WebCore::Range::create): Removed overloads that take start/end.
(WebCore::Range::setStart): Removed overload that takes Position.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::cloneRange const): Rewrote to use setStart/End since
that's what the constructor used to do.
(WebCore::Range::contains const): Use SimpleRange/createLiveRange
instead of makeRange. Soon this function will be deleted.
(WebCore::rangeOfContents): Deleted.
(WebCore::createLiveRange): Rewrote to use setStart/End since that's
what the constructor used to do.
- dom/Range.h: Update for above removals.
- dom/SimpleRange.h: Export commonInclusiveAncestor for use outside WebCore.
- dom/StaticRange.cpp:
(WebCore::StaticRange::create): Added overload that copies the SimpleRange.
- dom/StaticRange.h: Update for above.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use document
marker range function.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use makeSimpleRange.
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
Ditto.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirectionForSelection): Use makeSimpleRange and
intersectingNodes.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Use makeRangeSelectingNodeContents.
(WebCore::Editor::updateMarkersForWordsAffectedByEditing): Use makeSimpleRange.
(WebCore::Editor::transpose): Ditto.
(WebCore::Editor::rangeOfString): Use makeRangeSelectingNodeContents.
(WebCore::Editor::handleAcceptedCandidate): Update since rangeForTextCheckingResult
now returns an Optional<SimpleRange>.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectRangeOnElement): Use SimpleRange.
- editing/ReplaceRangeWithTextCommand.cpp:
(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand): Take
SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::willApplyCommand): Update since
m_rangeToBeReplaced is a SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::doApply): Ditto.
(WebCore::ReplaceRangeWithTextCommand::targetRanges const): Ditto.
- editing/ReplaceRangeWithTextCommand.h: Update for above.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertedContentRange const):
Return a SimpleRange.
- editing/ReplaceSelectionCommand.h: Update for above.
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
Take a SimpleRange.
(WebCore::SpellingCorrectionCommand::create): Moved here from header.
- editing/SpellingCorrectionCommand.h: Update for above.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspelledWordOrUngrammaticalPhrase const):
Use makeSimpleRange.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Use makeSimpleRange.
(WebCore::TypingCommand::willAddTypingToOpenCommand): Take SimpleRange.
(WebCore::TypingCommand::deleteKeyPressed): Remove createLiveRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
- editing/TypingCommand.h: Update for above.
- editing/VisiblePosition.cpp:
(WebCore::makeRange): Deleted.
(WebCore::startVisiblePosition): Deleted.
(WebCore::endVisiblePosition): Deleted.
(WebCore::setStart): Deleted.
(WebCore::setEnd): Deleted.
- editing/VisiblePosition.h: Update for above. Also export makeSimpleRange
for use outside WebCore.
- editing/VisibleUnits.cpp:
(WebCore::suffixLengthForRange): Take SimpleRange.
(WebCore::prefixLengthForRange): Ditto.
(WebCore::previousBoundary): Use makeSimpleRange.
(WebCore::nextBoundary): Ditto.
- editing/VisibleUnits.h: Update for above.
- editing/cocoa/DataDetection.mm:
(WebCore::buildQuery): Remove unused local variable.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setDictationPhrasesAsChildOfElement): Use makeRangeSelectingNodeContents.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::getRangeAt): Use createLiveRange.
- page/DragController.cpp:
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Remove makeSimpleRange.
- page/Frame.cpp:
(WebCore::Frame::rangeForPoint): Return SimpleRange.
- page/Frame.h: Update for above.
- page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Use makeRangeSelectingNodeContents,
intersectingNodes, and makeSimpleRange.
- testing/Internals.cpp:
(WebCore::Internals::markerRangeForNode): Use createLiveRange and the document
marker range function.
Source/WebKit:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(API::PageOverlayClientImpl::actionContextForResultAtPoint): Return a
structure that includes a SimpleRange.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::visibleRange): Use makeSimpleRange.
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Use SimpleRange.
- WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::rangeAndOffsetRelativeToSelection): Use SimpleRange.
(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Ditto.
(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::characterIndexForPointAsync): Remove makeSimpleRange.
(WebKit::WebPage::deleteSurrounding): Use makeSimpleRange.
- WebProcess/WebPage/WebPageOverlay.cpp:
(WebKit::WebPageOverlay::actionContextForResultAtPoint): Use return value instead of out argument.
- WebProcess/WebPage/WebPageOverlay.h: Update for above.
- WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::getPlatformEditorState const): Use makeSimpleRange.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::computeEditableRootHasContentAndPlainText): Use makeSimpleRange.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Removed unneeded null checks that
are already done by makeSimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Use makeSimpleRange.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::linkIndicatorPositionInformation): Use makeRangeSelectingNodeContents.
(WebKit::dataDetectorLinkPositionInformation): Ditto.
(WebKit::WebPage::requestDocumentEditingContext): Use makeSimpleRange.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Update for change to the
actionContextForResultAtPoint return value.
Source/WebKitLegacy/ios:
- WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame wordAtPoint:]): Use makeSimpleRange.
- WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Use document
marker range function.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Use makeSimpleRange.
Source/WebKitLegacy/mac:
- DOM/DOMUIKitExtensions.mm:
(-[DOMNode rangeOfContainingParagraph]): Use makeSimpleRange.
- WebView/WebFrame.mm:
(-[WebFrame _characterRangeAtPoint:]): Update since rangeAtPoint takes a SimpleRange.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use document marker range function.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]): Use makeRangeSelectingNodeContents.
(-[WebImmediateActionController _animationControllerForDataDetectedLink]): Ditto.
Source/WebKitLegacy/win:
- AccessibleTextImpl.cpp:
(AccessibleText::scrollSubstringTo): Use makeSimpleRange.
- 6:40 AM Changeset in webkit [265175] by
-
- 11 edits in trunk/Source/WebKit
Unreviewed, reverting r265171.
https://bugs.webkit.org/show_bug.cgi?id=215060
broke 2 mac api tests
Reverted changeset:
"[Mac] Add Experimental Feature preference for SW VP9"
https://bugs.webkit.org/show_bug.cgi?id=215043
https://trac.webkit.org/changeset/265171
- 1:02 AM Changeset in webkit [265174] by
-
- 2 edits in trunk/Source/WebKit
Unable to select multiple lines of vertical text correctly
https://bugs.webkit.org/show_bug.cgi?id=213671
<rdar://problem/53753636>
Reviewed by Darin Adler.
In order to make for a better text selection experience, we pulled the selection position
down to be on the last line selectable, rather than snap the selection to a single position.
This made for a better selection experience on small text, but we failed to take
vertical text into account, and a user is locked into only selecting vertical text that ends below the
other anchor point of the selection. We should have the same behavior for vertical text, but correctly
calculated for X instead of Y.
This does not fix all cases, but it fixes the most glaring cases.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeForPointInRootViewCoordinates):
