Timeline



Aug 5, 2020:

11:16 PM Changeset in webkit [265321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the StyleResolver-specific evaluate function in MediaQueryEvaluator
​https://bugs.webkit.org/show_bug.cgi?id=152089

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-05
Reviewed by Darin Adler.

The function mentioned in the bug is already gone (see r252736), also remove
the StyleResolver reference.

  • css/MediaQueryEvaluator.h:
9:06 PM Changeset in webkit [265320] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GTK][WPE] Garden backdrop-filter debug crashes

Unreviewed test gardening.

  • platform/glib/TestExpectations:
8:54 PM Changeset in webkit [265319] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Add some more Animations logging
​https://bugs.webkit.org/show_bug.cgi?id=215181

Reviewed by Zalan Bujtas.

Add logging that shows when DeclarativeAnimation::tick() runs and when it invalidates style.

  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::tick):

  • animation/DocumentTimelinesController.cpp:

(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::invalidate):

7:35 PM Changeset in webkit [265318] by Peng Liu
  • 2 edits in trunk/Source/WebCore

Netflix.com shows a scrubber that doesn't work
​https://bugs.webkit.org/show_bug.cgi?id=215199

Reviewed by Eric Carlson.

The "contentDuration" property of WebPlaybackControlsManager needs to be infinite
when the video is not seekable. Otherwise, AVKit will show a scrubber that doesn't
work on the Touch Bar.

  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager contentDuration]):
(-[WebPlaybackControlsManager setContentDuration:]):

6:58 PM Changeset in webkit [265317] by commit-queue@webkit.org
  • 4 edits in trunk

[WebGL2] Upgrade vertexAttribPointer with new supported types
​https://bugs.webkit.org/show_bug.cgi?id=215036

Patch by James Darpinian <James Darpinian> on 2020-08-05
Reviewed by Dean Jackson.

Tested by updated WebGL conformance tests webgl/2.0.0/conformance/attribs/gl-vertexattribpointer-offsets.html and webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::sizeInBytes):
(WebCore::WebGLRenderingContextBase::vertexAttribPointer):

6:43 PM Changeset in webkit [265316] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Rename BigSur EWS to AppleSilicon EWS
​https://bugs.webkit.org/show_bug.cgi?id=215205

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/ews-build/config.json:
5:58 PM Changeset in webkit [265315] by timothy_horton@apple.com
  • 74 edits in trunk

Remove all references to non-existent 10.16
​https://bugs.webkit.org/show_bug.cgi?id=215202

Reviewed by Wenson Hsieh.

Source/bmalloc:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/DebugProject.xcconfig:
  • gtest/xcode/Config/ReleaseProject.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/ThirdParty/libwebrtc:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:
  • Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebCore/PAL:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WebKit:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:
  • Scripts/process-entitlements.sh:
  • WebProcess/com.apple.WebProcess.sb.in:

Source/WebKitLegacy/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitTargetConditionals.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • wtf/PlatformEnableCocoa.h:
  • wtf/PlatformHave.h:
  • wtf/PlatformUse.h:

Tools:

  • ContentExtensionTester/Configurations/Base.xcconfig:
  • ContentExtensionTester/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • ImageDiff/cg/Configurations/Base.xcconfig:
  • ImageDiff/cg/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
  • TestWebKitAPI/config.h:
  • WebEditingTester/Configurations/Base.xcconfig:
  • WebEditingTester/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • lldb/lldbWebKitTester/Configurations/Base.xcconfig:
  • lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
5:33 PM Changeset in webkit [265314] by Karl Rackler
  • 2 edits in trunk/LayoutTests

[ iOS wk2 ] imported/w3c/web-platform-tests/svg/import/linking-a-10-f-manual.svg is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215204

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
5:24 PM Changeset in webkit [265313] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Fix returnEarlyFromInfiniteLoopsForFuzzing in DFG and validateDoesGC
​https://bugs.webkit.org/show_bug.cgi?id=215194
<rdar://problem/66158641>

Reviewed by Mark Lam.

JSTests:

  • stress/validate-does-gc-with-return-early-from-infinite-loop-2.js: Added.

(vm.useJIT):

Source/JavaScriptCore:

I already fixed this same issue in the FTL in r264330, but I forgot
to do it in the DFG.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:54 PM Changeset in webkit [265312] by Caio Lima
  • 2 edits in trunk/Tools

r264813 breaks Make runner on remote devices
​https://bugs.webkit.org/show_bug.cgi?id=215179

Reviewed by Saam Barati.

This patch is setting up the proper LD_LIBRARY_PATH value to run JSC
stress tests on remote devices.

  • Scripts/run-jsc-stress-tests:
4:21 PM Changeset in webkit [265311] by Andres Gonzalez
  • 7 edits in trunk/Source/WebCore

Crash in com.apple.WebKit.WebContent at com.apple.AppKit: _NSAccessibilityRemoveAllObserversAndSendDestroyedNotification
​https://bugs.webkit.org/show_bug.cgi?id=215189
<rdar://problem/66561167>

Reviewed by Chris Fleizach.

AXIsolatedObject::detachPlatformWrapper was calling the wrapper's detach
method that in turn calls the system NSAccessibilityUnregisterUniqueIdForUIElement
on the secondary thread. This function is not thread safe and hence the
random crashes.
This changes AXIsolatedObject::detachPlatformWrapper to call the
wrapper's detachIsolatedObject, avoiding the above problem altogether.
The wrapper's detach remains the same that it was before isolated tree
mode was introduced, and should only run on the main thread.

  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::applyPendingChanges):

  • accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:

(WebCore::AXIsolatedObject::detachPlatformWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject:]):
(-[WebAccessibilityObjectWrapperBase detachAXObject]): Merged back into detach.
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):

4:19 PM Changeset in webkit [265310] by beidson@apple.com
  • 2 edits
    1 add in trunk/Tools

Add a createWebArchiveData from a custom scheme API test
​https://bugs.webkit.org/show_bug.cgi?id=215187

Reviewed by Tim Horton.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm: Added.
4:16 PM Changeset in webkit [265309] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[ macOS Release wk1 ] imported/w3c/web-platform-tests/css/css-overflow/overflow-recalc-001.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=214703

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations: Update expectatins to reflect that this is an image failure.
3:22 PM Changeset in webkit [265308] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[GTK][WPE] media/media-source/media-source-webm.html is timing out

Unreviewed test gardening.

Instead of the previous missing 'update' event entries, now times out
waiting for resize event, which is not raised because the size does
not seem to be changing (all resize events return 320x240).

  • platform/glib/TestExpectations:
3:18 PM Changeset in webkit [265307] by Chris Dumez
  • 29 edits
    2 copies in trunk

Add constructor for DynamicsCompressorNode
​https://bugs.webkit.org/show_bug.cgi?id=215180

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:

Source/WebCore:

Add constructor for DynamicsCompressorNode:

This patch also add a new handleAudioNodeOptions() member function to
AudioNode to avoid code duplication and every node constructor.

No new tests, rebaselined existing tests.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::initializeDefaultNodeOptions):
(WebCore::AudioNode::handleAudioNodeOptions):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createDynamicsCompressor):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):

  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::create):
(WebCore::ConvolverNode::ConvolverNode):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):

  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::create):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::create):
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::setChannelCount):
(WebCore::DynamicsCompressorNode::setChannelCountMode):

  • Modules/webaudio/DynamicsCompressorNode.h:
  • Modules/webaudio/DynamicsCompressorNode.idl:
  • Modules/webaudio/DynamicsCompressorOptions.h: Copied from Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl.
  • Modules/webaudio/DynamicsCompressorOptions.idl: Copied from Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl.
  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::create):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::create):
(WebCore::PannerNode::PannerNode):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::create):

  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
2:30 PM Changeset in webkit [265306] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS wk2 ] imported/w3c/web-platform-tests/preload/single-download-preload.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215192

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
2:12 PM Changeset in webkit [265305] by Jonathan Bedard
  • 5 edits in trunk/Tools

results.webkit.org: Return worker status to caller
​https://bugs.webkit.org/show_bug.cgi?id=215086
<rdar://problem/66476525>

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/model/model.py:

(Model.do_work): Return if process has successfully processed results.

  • resultsdbpy/resultsdbpy/model/model_unittest.py:

(ModelTest.test_no_work):

  • resultsdbpy/resultsdbpy/model/upload_context.py:

(UploadContext._do_job_for_key): Return if the job was successful.
(UploadContext.do_processing_work): Return true if any processed jobs were successful.

  • resultsdbpy/resultsdbpy/model/upload_context_unittest.py:

(UploadContextTest.test_async_callback):

2:08 PM Changeset in webkit [265304] by Beth Dakin
  • 2 edits in trunk/Tools

Make report-non-inclusive-language ignore files within .svn and .git
​https://bugs.webkit.org/show_bug.cgi?id=215156

Reviewed by Darin Adler.

  • Scripts/report-non-inclusive-language:
1:47 PM Changeset in webkit [265303] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[Cocoa] Sandbox extension token not cleared from memory
​https://bugs.webkit.org/show_bug.cgi?id=215136

Reviewed by Geoffrey Garen.

As a security mitigation, an invalidated sandbox extension should have its token cleared from memory.

No new tests, covered by existing tests.

  • Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::SandboxExtensionImpl::m_length):
(WebKit::SandboxExtensionImpl::~SandboxExtensionImpl):

1:41 PM Changeset in webkit [265302] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

EWS emails about build failure should include relevant error logs
​https://bugs.webkit.org/show_bug.cgi?id=215174

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.start):
(AnalyzeCompileWebKitResults):
(AnalyzeCompileWebKitResults.getResults): Method to read the logs from previous build step.
(AnalyzeCompileWebKitResults.analyzeResults): Made a separate method called using deferred after reading the logs from previous steps.
(AnalyzeCompileWebKitResults.getBuildStepByName): Method to get step object from step name.
(AnalyzeCompileWebKitResults.filter_logs_containing_error): Filter the logs to include in email.
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Renamed from send_email_for_build_failure. Added
relevant error logs in email.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
12:51 PM Changeset in webkit [265301] by Jon Davis
  • 3 edits in trunk/Websites/webkit.org

Enhance feature status page origin for flexible test environments
​https://bugs.webkit.org/show_bug.cgi?id=215178

Reviewed by Devin Rousso.

  • wp-content/themes/webkit/css-status.php:
  • wp-content/themes/webkit/status.php:
12:40 PM Changeset in webkit [265300] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS wk2 Release ] imported/w3c/web-platform-tests/IndexedDB/structured-clone-transaction-state.any.worker.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215185

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
12:40 PM Changeset in webkit [265299] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

The various AllowList options should be able to take the function name inline
​https://bugs.webkit.org/show_bug.cgi?id=215184

Reviewed by Saam Barati.

Right now when I use the various AllowList JSC options I almost
always only care about a single function. Right now you need to
create a file with that single name in it. That is inconvenient, so
this patch changes the behavior to treat the string as the
function name if no file at that path exists. I'm also
speculatively assuming fopen doesn't return ENOENT when it fails
due to sandboxing... I didn't feel like testing it because this is
a debug option.

  • runtime/OptionsList.h:
  • tools/FunctionAllowlist.cpp:

(JSC::FunctionAllowlist::FunctionAllowlist):

12:23 PM Changeset in webkit [265298] by Chris Dumez
  • 15 edits
    2 copies in trunk

Add constructor to ConvolverNode
​https://bugs.webkit.org/show_bug.cgi?id=215169

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:

Source/WebCore:

Add constructor to ConvolverNode, as per specification:

No new tests, rebaselined existing tests.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createConvolver):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::create):
(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):
(WebCore::ConvolverNode::setChannelCount):
(WebCore::ConvolverNode::setChannelCountMode):

  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/ConvolverNode.idl:
  • Modules/webaudio/ConvolverOptions.h: Copied from Source/WebCore/Modules/webaudio/ConvolverNode.idl.
  • Modules/webaudio/ConvolverOptions.idl: Copied from Source/WebCore/Modules/webaudio/ConvolverNode.idl.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
12:12 PM Changeset in webkit [265297] by keith_miller@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add assertions / inline capacity to checkpoint side state stacks
​https://bugs.webkit.org/show_bug.cgi?id=215175

Reviewed by Saam Barati.

The inline capacity should hopefully avoid unneeded mallocs close to 100% of the time during our OSR exit ramp.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • runtime/VM.cpp:

(JSC::VM::pushCheckpointOSRSideState):

  • runtime/VM.h:
11:53 AM Changeset in webkit [265296] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ macOS iOS wk2 Release ] editing/selection/navigation-clears-editor-state.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215177

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:50 AM Changeset in webkit [265295] by pvollan@apple.com
  • 7 edits in trunk/Source/WebKit

[Cocoa] Remove obsolete sandbox extension after r264178
​https://bugs.webkit.org/show_bug.cgi?id=215154

Reviewed by Brent Fulgham.

After r264178, the code related to issuing an extension to com.apple.lsd.mapdb is obsolete, and should be removed.

No new tests, covered by existing tests.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/com.apple.WebProcess.sb.in:
11:48 AM Changeset in webkit [265294] by Alexey Shvayka
  • 9 edits
    15 adds
    2 deletes in trunk/LayoutTests

Re-sync web-platform-tests (2 dirs + 2 files)
​https://bugs.webkit.org/show_bug.cgi?id=215173

Reviewed by Carlos Alberto Lopez Perez.

LayoutTests/imported/w3c:

web-platform-tests revision: 993c1bc4c880

  • web-platform-tests/css/cssom/*: Updated.
  • web-platform-tests/dom/idlharness.window-expected.txt:
  • web-platform-tests/dom/idlharness.window.js:
  • web-platform-tests/intersection-observer/*: Updated.
  • web-platform-tests/performance-timeline/po-observe.any.*: Added.

LayoutTests:

Remove a duplicate test added in r259800 that was manually exported [1] and synced.

[1]: ​https://github.com/web-platform-tests/wpt/pull/23101

  • js/getOwnPropertyDescriptor-host-object-proxy-expected.txt: Removed.
  • js/getOwnPropertyDescriptor-host-object-proxy.html: Removed.
10:51 AM Changeset in webkit [265293] by Chris Dumez
  • 12 edits in trunk/Source/WebCore

REGRESSION (r265266) DumpRenderTree crash at WebKitAudioListener::dopplerFactor
​https://bugs.webkit.org/show_bug.cgi?id=215171
<rdar://problem/66556999>

Reviewed by Eric Carlson.

We were calling the isWebKitAudioContext() virtual function from the BaseAudioContext
constructor, which was not OK. We now initialize the listener lazily so that we can
know if we are a WebKitAudioContext or not at the time of creation.

Also use downcast<> instead of static_cast<> to cast from AudioListener to
WebKitAudioListener for extra safety. Finally, AudioListener was missing a virtual
destructor even though we were using polymorphism.

No new tests, covered by existing tests that are crashing on the bots.

  • Modules/webaudio/AudioListener.h:

(WebCore::AudioListener::isWebKitAudioListener const):

  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::constructCommon):
(WebCore::WebCore::BaseAudioContext::listener):

  • Modules/webaudio/BaseAudioContext.h:

(WebCore::BaseAudioContext::listener): Deleted.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::listener):
(WebCore::PannerNode::getAzimuthElevation):
(WebCore::PannerNode::distanceConeGain):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/WebKitAudioContext.h:

(WebCore::WebKitAudioContext::listener):

  • Modules/webaudio/WebKitAudioListener.h:

(isType):

  • Modules/webaudio/WebKitAudioListener.idl:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::listener):
(WebCore::WebKitAudioPannerNode::getAzimuthElevation):
(WebCore::WebKitAudioPannerNode::dopplerRate):
(WebCore::WebKitAudioPannerNode::distanceConeGain):

  • Modules/webaudio/WebKitAudioPannerNode.h:
10:22 AM Changeset in webkit [265292] by Russell Epstein
  • 19 edits
    2 deletes in branches/safari-610.1.25-branch

Revert r265115. rdar://problem/66552761

9:54 AM Changeset in webkit [265291] by Chris Dumez
  • 6 edits in trunk

Align BiquadFilterNode.getFrequencyResponse() with the specification
​https://bugs.webkit.org/show_bug.cgi?id=215148

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that all checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-basic-expected.txt:

Source/WebCore:

Align BiquadFilterNode.getFrequencyResponse() with the specification:

In particular, the 3 argument arrays should not be nullable and we should throw
if they have different lengths.

No new tests, rebaselined existing tests.

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::getFrequencyResponse):

  • Modules/webaudio/BiquadFilterNode.h:
  • Modules/webaudio/BiquadFilterNode.idl:
9:52 AM Changeset in webkit [265290] by Chris Dumez
  • 19 edits
    4 copies in trunk

Add constructor to BiquadFilterNode
​https://bugs.webkit.org/show_bug.cgi?id=215144

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:

Source/WebCore:

Add constructor to BiquadFilterNode:

No new tests, rebaselined existing tests..

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createBiquadFilter):

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::create):
(WebCore::BiquadFilterNode::BiquadFilterNode):

  • Modules/webaudio/BiquadFilterNode.h:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/BiquadFilterOptions.h: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
  • Modules/webaudio/BiquadFilterOptions.idl: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
  • Modules/webaudio/BiquadFilterType.h: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
  • Modules/webaudio/BiquadFilterType.idl: Copied from Source/WebCore/Modules/webaudio/BiquadFilterNode.idl.
  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/BiquadProcessor.h:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
9:36 AM Changeset in webkit [265289] by Simon Fraser
  • 24 edits in trunk

Update event regions only once per frame
​https://bugs.webkit.org/show_bug.cgi?id=215132
<rdar://problem/66533779>

Reviewed by Darin Adler.

Source/WebCore:

Event regions (for touch-action, editable areas etc) were updated as part of
compositing updates, but we only need their output once per rendering update, so
move their computation out of RenderLayerCompositor::updateBackingAndHierarchy()
and into a new RenderLayer tree walk that is called from Page::doAfterUpdateRendering().

RenderLayerBacking stores a dirty bit to track when regions need to be updated.

Reduces the amount of time spent in rendering updates when scrolling on facebook.com
on iPad, which has lots of discontiguous touch-action regions.

  • dom/Document.cpp:

(WebCore::Document::updateEventRegions):

  • dom/Document.h:
  • page/Frame.cpp:

(WebCore::Frame::layerTreeAsText const):

  • page/Page.cpp:

(WebCore::Page::doAfterUpdateRendering):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::maintainsEventRegion const):
(WebCore::RenderLayerBacking::updateEventRegion):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateEventRegions):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Tests that dispatch mouseWheel events in a way that tests event regions need to wait
now for a rendering update. await UIHelper.animationFrame() is not enough, because
the function resumes inside a microtask at the end of the requestAnimationFrame callback,
which is before we've completed the rest of the rendering update, and thus before
the event regions have been updated.

In addition, await UIHelper.animationFrame() followed by eventSender calls to issue
wheel events actually trigger Page::updateRendering() re-entrancy, via the
WKBundlePageForceRepaint() in EventSendingController::mouseScrollByWithWheelAndMomentumPhases().

To fix this, add and use UIHelper.renderingUpdate(), which waits for a rAF and uses a setTimeout()
to get past the end of the current rendering update.

  • fast/scrolling/mac/absolute-in-overflow-scroll-dynamic-expected.html:
  • fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html:
  • fast/scrolling/mac/absolute-in-overflow-scroll.html:
  • fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
  • fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
  • fast/scrolling/mac/async-scroll-overflow-top-inset.html:
  • fast/scrolling/mac/async-scroll-overflow.html:
  • fast/scrolling/mac/clip-path-hit-test.html:
  • fast/scrolling/mac/move-node-in-overflow-scroll.html:
  • fast/scrolling/mac/overflow-scrolled-document.html:
  • fast/scrolling/mac/overflow-zoomed-document.html:
  • fast/scrolling/mac/overlapped-overflow-scroll.html:
  • resources/ui-helper.js:

(window.UIHelper.async renderingUpdate):

9:21 AM WebKitFlatpakSDK/SpeedUpBuild edited by Philippe Normand
(diff)
9:11 AM Changeset in webkit [265288] by youenn@apple.com
  • 3 edits in trunk/LayoutTests

[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215088
<rdar://problem/66489006>

Reviewed by Eric Carlson.

  • platform/mac-wk2/TestExpectations:
  • webrtc/datachannel/gather-candidates-networkprocess-crash.html:

Sending IPC to the network process is now happening in a background thread and in case of network process crash
we might need to wait a little bit longer since the socket creation/sending is not blocked on getting a proper connection.

8:50 AM Changeset in webkit [265287] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

Unreviewed non-unified build fix.

No new tests needed.

  • Modules/webaudio/AudioListener.h: Add forward declaration for BaseAudioSharedUnit.
8:46 AM Changeset in webkit [265286] by commit-queue@webkit.org
  • 6 edits in trunk

TextManipulationController should observe newly inserted or displayed text
​https://bugs.webkit.org/show_bug.cgi?id=215157

Patch by Sihui Liu <​sihui_liu@appe.com> on 2020-08-05
Reviewed by Wenson Hsieh.

Source/WebCore:

TextManipulationController already tracks renderer state of Element, but the case where Text children of an
Element is newly inserted and displayed is not covered. Therefore, TextManipulationController also needs to
know when render of Text is created.

API test: TextManipulation.CompleteTextManipulationForNewlyDisplayedText

  • editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::didCreateRendererForTextNode):
(WebCore::TextManipulationController::scheduleObservationUpdate):
(WebCore::TextManipulationController::removeNode):

  • editing/TextManipulationController.h:
  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createTextRenderer):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

8:19 AM Changeset in webkit [265285] by Hector Lopez
  • 3 edits in trunk/LayoutTests

[ iOS ] imported/mozilla/svg/image/image-filter-01.svg is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=215167

Unreviewed test gardening.

7:43 AM Changeset in webkit [265284] by Wenson Hsieh
  • 6 edits
    1 add in trunk

[iOS] Keyboard shortcuts and arrow key scrolling stop working after navigating via swipe gesture
​https://bugs.webkit.org/show_bug.cgi?id=215137
<rdar://problem/65082979>

Reviewed by Tim Horton.

Source/WebKit:

The process of starting a navigation swipe gesture causes the first responder (in this case, WKContentView) to
resign. Subsequently, nothing makes the content view first responder again once the navigation gesture ends,
even if the gesture is cancelled and we don't end up navigating. This results in several symptoms, two of which
are that keyboard shortcuts stop working, and pressing arrow keys does not scroll the web view after ending the
swipe gesture.

To mitigate this, add a mechanism to have the web view remember that our content view was first responder before
calling -startInteractiveTransition:; after ending the interactive transition (i.e. swipe gesture), we then
restore the web view's content view as first responder if it is not already first responder (and it is also
parented, which is not the case when swiping back to close a newly opened tab in Safari).

Test: NavigationSwipeTests.RestoreFirstResponderAfterNavigationSwipe

NavigationSwipeTests.DoNotBecomeFirstResponderAfterNavigationSwipeIfWebViewIsUnparented

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _navigationGestureDidBegin]):
(-[WKWebView _navigationGestureDidEnd]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/ios/NavigationSwipeTests.mm: Added.

(-[TestNavigationInteractiveTransition startInteractiveTransition:]):

Add an API test that exercises the bug by resigning first responder underneath -startInteractiveTransition:,
and checking that we have become first responder once again after completing the transition.

  • TestWebKitAPI/ios/UIKitSPI.h:
5:01 AM WebKitFlatpakSDK/SpeedUpBuild edited by Philippe Normand
(diff)
5:00 AM Sccache edited by Philippe Normand
(diff)
5:00 AM WebKitFlatpakSDK/SpeedUpBuild edited by Philippe Normand
(diff)
4:53 AM WebKitFlatpakSDK edited by Philippe Normand
(diff)
4:48 AM WebKitFlatpakSDK edited by Philippe Normand
(diff)
4:47 AM WebKitFlatpakSDK edited by Philippe Normand
(diff)
4:45 AM WebKitFlatpakSDK edited by Philippe Normand
(diff)
4:45 AM WebKitFlatpakSDK created by Philippe Normand
4:44 AM WebKitFlatpakSDK/SpeedUpBuild created by Philippe Normand
4:44 AM WebKitGTK/SpeedUpBuild edited by Philippe Normand
(diff)
4:43 AM WebKitGTK/SpeedUpBuild edited by Philippe Normand
(diff)
4:27 AM WebKitGTK/SpeedUpBuild edited by Philippe Normand
(diff)
4:26 AM WebKitGTK/SpeedUpBuild edited by Philippe Normand
(diff)
4:03 AM Changeset in webkit [265283] by youenn@apple.com
  • 4 edits in trunk/Source/WebCore

RegistrationDatabase::openSQLiteDatabase can spin
​https://bugs.webkit.org/show_bug.cgi?id=215120
<rdar://problem/64850347>

Reviewed by Geoffrey Garen.

In case we fail opening the database when importing, we delete the database, the file and retry.
We do not need to retry in that case since there is nothing to import. Update the code to proceed with sending an import failure to SWServer.

In case of pushing changes to the database, it might be useful to retry but it is best to do this asynchronously.
For instance, there might be a script deleting the files/folders where is stored the database.
In that case, we check the result of pushing changes.
If they succeed, we call the completion handler and stop.
Otherwise, we will retry pushing the changes if changes were not pushed again in the meantime.
We introduce a push counter for that purpose.

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::postTaskToWorkQueue):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::importRecordsIfNecessary):
(WebCore::RegistrationDatabase::pushChanges):
(WebCore::RegistrationDatabase::schedulePushChanges):
(WebCore::RegistrationDatabase::doPushChanges):

  • workers/service/server/RegistrationDatabase.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::registrationStoreDatabaseFailedToOpen):

1:33 AM Changeset in webkit [265282] by youenn@apple.com
  • 2 edits in trunk/Source/WebCore

SWServerJobQueue::didResolveRegistrationPromise should not assume its registration key relates to an existing worker
​https://bugs.webkit.org/show_bug.cgi?id=215123
<rdar://problem/65096786>

Reviewed by Geoffrey Garen.

We know that in some cases, the registration is null in SWServerJobQueue::didResolveRegistrationPromise.
This might happen for instance in case a worker gets terminated, thus removing a job and the next job is clearing the registration.
Also, SWServerJobQueue::didResolveRegistrationPromise is not checking that the job identifier is the same in SWServerJobQueue::install
and SWServerJobQueue::didResolveRegistrationPromise while other code paths do.

A future refactoring might allow to call SWServerJobQueue::didResolveRegistrationPromise code synchronously from SWServerJobQueue::install.
In the meantime, let's add a null check and add release logging for that case.

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):

1:22 AM Changeset in webkit [265281] by commit-queue@webkit.org
  • 8 edits in trunk

Allow multiple calls to PerformanceObserver.observe with different types
​https://bugs.webkit.org/show_bug.cgi?id=214884

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-05
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update improved test expectations.

  • web-platform-tests/performance-timeline/po-observe-type.any-expected.txt:
  • web-platform-tests/performance-timeline/po-observe-type.any.worker-expected.txt:

Source/WebCore:

Allow multiple calls to PerformanceObserver.observe with different type, but
throw an exception if the observer type is changed [1].

Behavior matches Firefox and Chrome.

Test: imported/web-platform-tests/performance-timeline/po-observe-type.any.html

[1] ​https://w3c.github.io/performance-timeline/#observe-method

  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe):

  • page/PerformanceObserver.h:

LayoutTests:

Unskip po-observe-type.any.html.

1:11 AM Changeset in webkit [265280] by youenn@apple.com
  • 4 edits in trunk/Source/WebCore

Update AudioSampleDataSource offset computation
​https://bugs.webkit.org/show_bug.cgi?id=215127
<rdar://problem/65938265>

Reviewed by Eric Carlson.

As per logs, it sometimes happens that the offset is so big that the timestamp is below the start of the window.
In that case, our logic is not able to catch up and reduce the offset.
To handle this, we special case if the timestamp is below the start frame and do as if we were starting from scratch.
Otherwise, we continue our logic to fine tune the offset by slowly making it bigger to not hit the end of the window but still be close to it.
Updated logging to help further debugging this issue if needed.

  • platform/audio/mac/AudioSampleDataSource.h:
  • platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::computeOffsetDelay):
(WebCore::AudioSampleDataSource::pullSamplesInternal):
(WebCore::AudioSampleDataSource::pullAvalaibleSamplesAsChunks):

  • platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:

(WebCore::RealtimeIncomingAudioSourceCocoa::OnData):

1:03 AM Changeset in webkit [265279] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Unreviewed, skip private field test

Private field has a bug and this test is failing. We skip it since private field is not enabled.

  • stress/put-by-val-direct-putprivate.js:
12:22 AM Changeset in webkit [265278] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

AX: WebCore should provide a way to get raw role for accessibility objects
​https://bugs.webkit.org/show_bug.cgi?id=215149

Patch by Eric Liang <​ericliang@apple.com> on 2020-08-05
Reviewed by Chris Fleizach.

Added a conversion from WebRole to string for accessibility.
This allows us to get it in the WebKit bundle.

  • accessibility/AXLogger.cpp:

(WebCore::operator<<):

  • accessibility/AccessibilityObjectInterface.h:

(WebCore::accessibilityRoleToString):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper _accessibilityWebRoleAsString]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):

Aug 4, 2020:

10:15 PM Changeset in webkit [265277] by Jonathan Bedard
  • 2 edits
    3 copies
    3 adds in trunk/Tools

[webkitcorepy] Add mocks.ContextStack
​https://bugs.webkit.org/show_bug.cgi?id=214484

Reviewed by Dewei Zhu.

Add a class which allows a context leveraging mock to stack. This is useful when
mocking requests or subprocess, where a single function (or class of functions)
is handling calls that are destined for different for different mock handlers.

  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks/context_stack.py: Added.

(ContextStack): Class which stacks mock handlers.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/init.py: Added.
  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/context_stack_unittest.py: Added.

(to_be_replaced): Function to be mocked
(ExampleStack): Example mock handler.
(ContextStack): Test suite.

9:19 PM Changeset in webkit [265276] by ysuzuki@apple.com
  • 15 edits in trunk/Source

[JSC] Use LazyNeverDestroyed & std::call_once for complex singletons
​https://bugs.webkit.org/show_bug.cgi?id=215153
<rdar://problem/65718983>

Reviewed by Mark Lam.

Source/JavaScriptCore:

We are getting some crashes in RemoteInspector and this speculatively fixes the crash.
My guess is that NeverDestroyed<RemoteInspector> calls constructor twice in heavily contended situation:
WebKit's static does not have thread-safety. If two threads come here at the same time, it is possible that
constructor is invoked twice. In that case, later constructor will clear members, which involves clearing
Lock m_mutex field. This makes Lock's invariant broken.
This patch uses LazyNeverDestroyed and std::call_once to ensure invoking constructor only once.

  • API/glib/JSCVirtualMachine.cpp:
  • dfg/DFGCommonData.cpp:
  • disassembler/Disassembler.cpp:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::singleton):

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::singleton):

  • inspector/remote/socket/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::singleton):

  • inspector/remote/socket/RemoteInspectorServer.h:
  • inspector/remote/socket/RemoteInspectorSocket.cpp:

(Inspector::RemoteInspector::singleton):

  • inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:

(Inspector::RemoteInspectorSocketEndpoint::singleton):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::opcodeIDTable):

  • runtime/IntlObject.cpp:

(JSC::intlAvailableLocales):
(JSC::intlCollatorAvailableLocales):
(JSC::defaultLocale):
(JSC::numberingSystemsForLocale):

Source/WTF:

Add lock's bits in crash information to investigate if this speculative fix does not work.

  • wtf/LockAlgorithmInlines.h:

(WTF::Hooks>::lockSlow):
(WTF::Hooks>::unlockSlow):

7:32 PM Changeset in webkit [265275] by Andres Gonzalez
  • 2 edits in trunk/LayoutTests

Disable isolated-tree-mode-on-off.html because it is causing other test failures..
​https://bugs.webkit.org/show_bug.cgi?id=215151
<rdar://problem/66542837>

Reviewed by Chris Fleizach.

This test turns isolated tree mode on and causes other concurrent test
to also run in isolated tree mode, and thus random failures. Will enable
once all tests succeed in isolated tree mode, or we can turn the mode on
only for a particular test without affecting others.

  • platform/mac/TestExpectations:
6:56 PM Changeset in webkit [265274] by Fujii Hironori
  • 2 edits in trunk/Tools

[webkitcorepy] REGRESSION(r265254): autoinstaller is failing to execute setup.py on win32 Python
​https://bugs.webkit.org/show_bug.cgi?id=215152

Reviewed by Jonathan Bedard.

There were two problems. Win32 Python needs SYSTEMROOT environment
variable to run setup.py. win-inet-pton is using _ for the
directory name (win_inet_pton-1.1.0).

  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Add a new candidate directory by replacing '-'
with '_'. Pass through SYSTEMROOT env var.

6:41 PM Changeset in webkit [265273] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

REGRESSION(r265167): media/media-source/media-source-webm.html failing
​https://bugs.webkit.org/show_bug.cgi?id=215142
<rdar://problem/66487888>

Reviewed by Eric Carlson.

Once we started checking the "codecs=" parameter of the MIME type in MediaSource.isTypeSupported(),
the media-source-webm.html test started failing, as the codecs string didn't include some mandatory
entries. Also re-wrote the test to use a single try/catch block to catch errors without timing out.

  • media/media-source/content/test-vp9-manifest.json:
  • media/media-source/media-source-webm.html:
6:32 PM Changeset in webkit [265272] by keith_miller@apple.com
  • 13 edits
    1 add in trunk

CheckpointSideState shoud play nicely with StackOverflowException unwinding.
​https://bugs.webkit.org/show_bug.cgi?id=215114

Reviewed by Saam Barati.

JSTests:

  • stress/stack-overflow-into-frame-with-pending-checkpoint.js: Added.

(foo.catch.async bar):
(foo.catch):
(foo):

Source/JavaScriptCore:

This patch fixes an issue where we the StackVisitor would
automatically unwind into the first frame before calling into the
provided functor. As a note, we do this because the first frame is
not fully initialized at the time we check for stack
overflow. When this happened we would fail to clear the side state
causing a memory leak. To fix this the unwind function now clears
every checkpoint up to and including the call frame containing our
handler. Some care needs to be taken that we don't clear
checkpoint side state for other threads, which could happen if
there are no checkpoints on the current thread and an API
miggrated us from another thread below the current thread.

This patch also makes two refacorings. The first is to make the
checkpoint side state into a stack, which is how we used it
anyway. The second is that CallFrame::dump and everything associated
with it is now marked const so we can PointerDump a CallFrame*.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeIndex const):
(JSC::CallFrame::codeOrigin const):
(JSC::CallFrame::dump const):
(JSC::CallFrame::bytecodeIndex): Deleted.
(JSC::CallFrame::codeOrigin): Deleted.
(JSC::CallFrame::dump): Deleted.

  • interpreter/CallFrame.h:

(JSC::CallFrame::argument const):
(JSC::CallFrame::uncheckedArgument const):
(JSC::CallFrame::getArgumentUnsafe const):
(JSC::CallFrame::thisValue const):
(JSC::CallFrame::newTarget const):
(JSC::CallFrame::argument): Deleted.
(JSC::CallFrame::uncheckedArgument): Deleted.
(JSC::CallFrame::getArgumentUnsafe): Deleted.
(JSC::CallFrame::thisValue): Deleted.
(JSC::CallFrame::newTarget): Deleted.

  • interpreter/CheckpointOSRExitSideState.h:

(JSC::CheckpointOSRExitSideState::CheckpointOSRExitSideState):

  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator() const):
(JSC::Interpreter::unwind):
(): Deleted.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::slow_path_checkpoint_osr_exit_from_inlined_call):
(JSC::LLInt::slow_path_checkpoint_osr_exit):

  • runtime/VM.cpp:

(JSC::VM::scanSideState const):
(JSC::VM::pushCheckpointOSRSideState):
(JSC::VM::popCheckpointOSRSideState):
(JSC::VM::popAllCheckpointOSRSideStateUntil):
(JSC::VM::addCheckpointOSRSideState): Deleted.
(JSC::VM::findCheckpointOSRSideState): Deleted.

  • runtime/VM.h:

Source/WTF:

Add a helper so we can have soft stack bounds.

  • wtf/StackBounds.h:

(WTF::StackBounds::withSoftOrigin const):

6:27 PM Changeset in webkit [265271] by Wenson Hsieh
  • 4 edits
    2 moves in trunk/Tools

Move poseAsClass() into the TestRunnerShared directory
​https://bugs.webkit.org/show_bug.cgi?id=215147

Reviewed by Tim Horton.

Move the duplicated implementations of poseAsClass() out of WebKitTestRunner and DumpRenderTree,
and into helper files in TestRunnerShared instead.

No change in behavior.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(poseAsClass): Deleted.
(setPersistentUserStyleSheetLocation): Deleted.

  • TestRunnerShared/cocoa/PoseAsClass.h: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.h.
  • TestRunnerShared/cocoa/PoseAsClass.mm: Renamed from Tools/WebKitTestRunner/mac/PoseAsClass.mm.

(swizzleAllMethods):
(poseAsClass):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
5:43 PM Changeset in webkit [265270] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix after r265263
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

4:48 PM Changeset in webkit [265269] by Devin Rousso
  • 5 edits in trunk/Source

"DoubleDown Casino" respin button stops working with trackpad
​https://bugs.webkit.org/show_bug.cgi?id=215146
<rdar://problem/64668138>

Reviewed by Tim Horton.

Source/WebCore:

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isDoubleDown): Added.

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView shouldUseMouseGestureRecognizer]):

4:38 PM Changeset in webkit [265268] by Alan Coon
  • 2 edits in branches/safari-610.1.25-branch/Source/WebKit

Cherry-pick r265260. rdar://problem/66548143

[iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
​https://bugs.webkit.org/show_bug.cgi?id=215108

Reviewed by Youenn Fablet.

This asserts because it appears that the WebContent and Networking process do not have the required entitlement
com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Add the entitlement for simulator.

No new tests, covered by existing tests.

  • Resources/ios/XPCService-embedded-simulator.entitlements:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:10 PM Changeset in webkit [265267] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
​https://bugs.webkit.org/show_bug.cgi?id=214965

Unreviewed, address review comments.

Add comment explaining why a set of MobileGestalt queries are performed when starting up the WebContent process on iOS.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:01 PM Changeset in webkit [265266] by Chris Dumez
  • 24 edits
    2 copies in trunk

Align AudioListener with the W3C specification
​https://bugs.webkit.org/show_bug.cgi?id=215134

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/historical-expected.txt:
  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic-expected.txt:

Source/WebCore:

Align AudioListener with the W3C specification:

Note that the prefixed API still behaves the way it used to. I have maintained
the old version of the AudioListener API by moving it to a new
WebKitAudioListener interface.

No new tests, rebaselined existing tests.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):
(WebCore::AudioListener::setPosition):
(WebCore::AudioListener::position const):
(WebCore::AudioListener::setOrientation):
(WebCore::AudioListener::orientation const):
(WebCore::AudioListener::upVector const):

  • Modules/webaudio/AudioListener.h:

(WebCore::AudioListener::create):
(WebCore::AudioListener::positionX):
(WebCore::AudioListener::positionY):
(WebCore::AudioListener::positionZ):
(WebCore::AudioListener::forwardX):
(WebCore::AudioListener::forwardY):
(WebCore::AudioListener::forwardZ):
(WebCore::AudioListener::upX):
(WebCore::AudioListener::upY):
(WebCore::AudioListener::upZ):

  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::constructCommon):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::dopplerRate):

  • Modules/webaudio/WebKitAudioContext.h:

(WebCore::WebKitAudioContext::listener):

  • Modules/webaudio/WebKitAudioContext.idl:
  • Modules/webaudio/WebKitAudioListener.h: Copied from Source/WebCore/Modules/webaudio/AudioListener.h.
  • Modules/webaudio/WebKitAudioListener.idl: Copied from Source/WebCore/Modules/webaudio/AudioListener.idl.
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::listener):

  • Modules/webaudio/WebKitAudioPannerNode.h:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
3:54 PM Changeset in webkit [265265] by Fujii Hironori
  • 2 edits in trunk/Source/WTF

[MSVC] wtf/Optional.h: error C2280: 'WTF::constexpr_storage_t<T> &WTF::constexpr_storage_t<T>::operator =(const WTF::constexpr_storage_t<T> &)': attempting to reference a deleted function
​https://bugs.webkit.org/show_bug.cgi?id=215003

Reviewed by Yusuke Suzuki.

Microsoft reported the upcoming MSVC can't compile
Optional<std::pair<JSC::SamplingProfiler::StackFrame::CodeLocation,JSC::CodeBlock *>>.

wtf/Optional.h(419,39): error C2280: 'WTF::constexpr_storage_t<T> &WTF::constexpr_storage_t<T>::operator =(const WTF::constexpr_storage_t<T> &)': attempting to reference a deleted function

They suggests using std::is_trivially_copy_assignable_v in
Optional ctor instead of std::is_trivially_copyable_v.

  • wtf/Optional.h:

(WTF::Optional::Optional): Replaced std::is_trivially_copyable_v with std::is_trivially_copy_assignable_v.

3:49 PM Changeset in webkit [265264] by pvollan@apple.com
  • 6 edits in trunk

[iOS] Check that Accessibility is enabled when receiving the enable Accessibility notification
​https://bugs.webkit.org/show_bug.cgi?id=215112
Source/WebCore/PAL:

Reviewed by Youenn Fablet.

Declare NSApplication methods to enable enhanced accessibility user interface, and check if it is enabled.

  • pal/spi/mac/NSApplicationSPI.h:

Source/WebKit:

<rdar://problem/66498397>

Reviewed by Youenn Fablet.

As a security mitigation, return early when handling this notification if Accessibility is not enabled.

API test: WebKit.AccessibilityHasNoPreferencesServiceAccessWhenPostingNotification

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):

Tools:

Reviewed by Youenn Fablet.

Added test WebKit.AccessibilityHasNoPreferencesServiceAccessWhenPostingNotification.

  • TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:

(TEST):

3:39 PM Changeset in webkit [265263] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

Reviewed by Eric Carlson.

We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).

We should not issue this extension on the iOS family of targets.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

3:18 PM Changeset in webkit [265262] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table
​https://bugs.webkit.org/show_bug.cgi?id=215138

Reviewed by Devin Rousso.

Simplify LTR/RTL CSS code by using logical CSS properties. This patch doesn't introduce any visual changes.

  • UserInterface/Views/DataGrid.css:

(.data-grid):
(.data-grid th:not(:last-child) > .header-cell-content):
(.data-grid:focus tr.selected td:not(:last-child)):
(body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content): Deleted.
(body[dir=rtl] .data-grid th:not(:last-child) > .header-cell-content): Deleted.
(body[dir=ltr] .data-grid:focus tr.selected td:not(:last-child)): Deleted.
(body[dir=rtl] .data-grid:focus tr.selected td:not(:last-child)): Deleted.

  • UserInterface/Views/NetworkDetailView.css:

(.network-table.showing-detail .network-detail):
(body[dir=ltr] .network-table.showing-detail .network-detail): Deleted.
(body[dir=rtl] .network-table.showing-detail .network-detail): Deleted.

  • UserInterface/Views/TimelineDataGrid.css:

(.data-grid.timeline td.graph-column):
(body[dir=ltr] .data-grid.timeline td.graph-column): Deleted.
(body[dir=rtl] .data-grid.timeline td.graph-column): Deleted.

3:02 PM Changeset in webkit [265261] by mmaxfield@apple.com
  • 5 edits in trunk/Source/WebCore

Add glyph origins member to GlyphBuffer
​https://bugs.webkit.org/show_bug.cgi?id=215057

Reviewed by Darin Adler.

This is in preparation for ​https://bugs.webkit.org/show_bug.cgi?id=214769
and ​https://bugs.webkit.org/show_bug.cgi?id=206208.

The solution for ​https://bugs.webkit.org/show_bug.cgi?id=214769 requires applying
letter-spacing after text shaping. Today, we apply letter-spacing before text
shaping, which is wrong. However, if we want to apply letter-spacing after text
shaping, we need to use CTFontShapeGlyphs(), which outputs glyph origins in
addition to glyph advances. Adding a glyph origins field to GlyphBuffer allows us
to flatten these origins at the appropriate places.

This patch is meant to be applied on top of
​https://bugs.webkit.org/show_bug.cgi?id=215051, which decreases the inline sizes
of these vector members from 2048 to 1024. I measured the median and mean of these
strings in our Page Load Test to be 6 and 7.4, which indicates we were being wildly
inefficient with the members of GlyphBuffer. Decreasing these inline sizes means
we're now using less memory than we were before.

No new tests becasue there is no behavior change yet. This patch just adds the
field. The next patch will hook up CTFontShapeGlyphs() itself.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawText const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::drawGlyphBuffer const):

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferOrigin::GlyphBufferOrigin):
(WebCore::GlyphBufferOrigin::operator FloatPoint):
(WebCore::GlyphBufferOrigin::setX):
(WebCore::GlyphBufferOrigin::setY):
(WebCore::GlyphBufferOrigin::x const):
(WebCore::GlyphBufferOrigin::y const):
(WebCore::GlyphBufferOrigin::encode const):
(WebCore::GlyphBufferOrigin::decode):
(WebCore::GlyphBuffer::clear):
(WebCore::GlyphBuffer::origins):
(WebCore::GlyphBuffer::origins const):
(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::remove):
(WebCore::GlyphBuffer::makeHole):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::flatten):
(WebCore::GlyphBuffer::isFlattened const):
(WebCore::GlyphBuffer::swap):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawGlyphs):

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const):

2:03 PM Changeset in webkit [265260] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
​https://bugs.webkit.org/show_bug.cgi?id=215108

Reviewed by Youenn Fablet.

This asserts because it appears that the WebContent and Networking process do not have the required entitlement
com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Add the entitlement for simulator.

No new tests, covered by existing tests.

  • Resources/ios/XPCService-embedded-simulator.entitlements:
1:55 PM Changeset in webkit [265259] by Chris Fleizach
  • 14 edits
    2 adds in trunk

AX: VoiceOver needs access to font styling at insertion point
​https://bugs.webkit.org/show_bug.cgi?id=215129
Source/WebCore:

<rdar://problem/65114972>

Reviewed by Darin Adler.

Give access to relevant font styling properties at the insertion point so that VoiceOver can speak them
when text commands alter styling.

Test: accessibility/mac/resolved-text-editing.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::resolvedEditingStyles const):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityResolvedEditingStyles]):

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::resolvedEditingStyles const):

  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::attributeValueAsync):

LayoutTests:

Reviewed by Darin Adler.

  • accessibility/mac/resolved-text-editing-expected.txt: Added.
  • accessibility/mac/resolved-text-editing.html: Added.
1:50 PM Changeset in webkit [265258] by Kate Cheney
  • 3 edits
    5 adds in trunk

Add test coverage for handling redirects with App-Bound Domains
​https://bugs.webkit.org/show_bug.cgi?id=215128
<rdar://problem/66528515>

Reviewed by Brady Eidson.

Tools:

We should always make a new WebView if the test options indicate an
app-bound view, because we need a new configuration.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::ensureViewSupportsOptionsForTest):

LayoutTests:

Add two new tests to confirm that App Bound Domains behaves correctly
for redirect cases: one for top-frame redirects, and one for sub-frame
redirects.

  • http/tests/in-app-browser-privacy/resources/redirect.php: Added.
  • http/tests/in-app-browser-privacy/sub-frame-redirect-to-non-app-bound-domain-blocked-expected.txt: Added.
  • http/tests/in-app-browser-privacy/sub-frame-redirect-to-non-app-bound-domain-blocked.html: Added.
  • http/tests/in-app-browser-privacy/top-frame-redirect-to-non-app-bound-domain-blocked-expected.txt: Added.
  • http/tests/in-app-browser-privacy/top-frame-redirect-to-non-app-bound-domain-blocked.html: Added.
1:45 PM Changeset in webkit [265257] by Peng Liu
  • 3 edits in trunk/Source/WebCore
REGRESSION (r265019): ASSERTION FAILED: !m_impl
m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::PlaybackSessionInterfaceAVKit::invalidate()

​https://bugs.webkit.org/show_bug.cgi?id=215118

Reviewed by Jer Noble.

Revert the change about using a WeakPtr of PlaybackSessionModel in r265019.
On WK1, a VideoFullscreenControllerContext (a subclass of PlaybackSessionModel)
object is created on the main thread, so we cannot use a WeakPtr of it on
the UI thread.

No new tests, fix an API test failure: WebKitLegacy.AudioSessionCategoryIOS.

  • platform/ios/PlaybackSessionInterfaceAVKit.h:
  • platform/ios/PlaybackSessionInterfaceAVKit.mm:

(WebCore::PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit):
(WebCore::PlaybackSessionInterfaceAVKit::playbackSessionModel const):

12:26 PM Changeset in webkit [265256] by Chris Dumez
  • 8 edits in trunk

Align AudioBufferSourceNode's start() / stop() with the specification
​https://bugs.webkit.org/show_bug.cgi?id=215130

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline a couple of web-platform-tests now that they are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-grain-expected.txt:

Source/WebCore:

Align AudioBufferSourceNode's start() / stop() with the specification:

In particular, we should throw a RangeError when the parameters are invalid,
not an InvalidStateError. Also, we should not return early if there is no
buffer.

No new tests, rebaselined existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::startPlaying):

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::startLater):
(WebCore::AudioScheduledSourceNode::stopLater):

LayoutTests:

Rebaseline test because exception message changed.

  • webaudio/audiobuffersource-exception-expected.txt:
12:24 PM Changeset in webkit [265255] by Darin Adler
  • 2 edits in trunk/Source/WebKitLegacy/ios

Try to fix Catalyst build
​https://bugs.webkit.org/show_bug.cgi?id=215133
rdar://66534119

  • WebCoreSupport/WebVisiblePosition.mm: Add include of SimpleRange.h.
12:06 PM Changeset in webkit [265254] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitcorepy] Use setup.py for the autoinstaller
​https://bugs.webkit.org/show_bug.cgi?id=215067
<rdar://problem/66432719>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Add all requests dependencies.
  • Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.Archiveinit): Add extension, tar.gz by default.
(Package.Archive.path): Support multiple file types.
(Package.Archive.unpack): Support .zip files.
(Package.init): Add slow_install flag.
(Package.archives): Handle case were a library does not have a tiny version.
(Package.install): Call setup.py instead of just moving the library out of the package.

11:56 AM Changeset in webkit [265253] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS ] fast/canvas/draw-focus-if-needed.html is passing and expectations need to be removed
​https://bugs.webkit.org/show_bug.cgi?id=214840

Unreviewed test gardening.

  • platform/ios/TestExpectations:
11:14 AM Changeset in webkit [265252] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

about: scheme URL constants should be backed by StaticStringImpl
​https://bugs.webkit.org/show_bug.cgi?id=215113

Reviewed by Darin Adler.

  • wtf/URL.cpp:

(WTF::aboutBlankURL):
(WTF::aboutSrcDocURL):

10:18 AM Changeset in webkit [265251] by Russell Epstein
  • 2 edits in branches/safari-610.1.25-branch/Source/WebKit

Cherry-pick r265222. rdar://problem/66528551

Fix the macCatalyst build

  • UIProcess/EndowmentStateTracker.mm: (WebKit::EndowmentStateTracker::stateFromEndowments):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:18 AM Changeset in webkit [265250] by Russell Epstein
  • 16 edits in branches/safari-610.1.25-branch/Source/JavaScriptCore

Cherry-pick r265186. rdar://problem/66528563

Unreviewed, reverting r265151.
​https://bugs.webkit.org/show_bug.cgi?id=215074

Broke ARM64E JSC tests

Reverted changeset:

"validate untagArrayPtr"
​https://bugs.webkit.org/show_bug.cgi?id=214953
​https://trac.webkit.org/changeset/265151

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [265249] by Hector Lopez
  • 2 edits in trunk/Tools

Add myself to contributors.json

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
9:56 AM Changeset in webkit [265248] by Andres G