Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 21, 2020:

6:32 PM Changeset in webkit [266022] by Alexey Shvayka

• 2 edits in trunk/Source/JavaScriptCore

StrictEq should not care about masqueradesAsUndefinedWatchpoint
​https://bugs.webkit.org/show_bug.cgi?id=215743

Reviewed by Yusuke Suzuki.

This patch removes masqueradesAsUndefinedWatchpoint handling for StrictEq
from fixupCompareStrictEqAndSameValue(), aligning it with SameValue.

According to the spec [1], only a few language constructs special-case
IsHTMLDDA? objects: ToBoolean, abstract equality, and typeof.

No behavior change.

[1]: ​https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):

5:52 PM Changeset in webkit [266021] by Wenson Hsieh

• 4 edits
  1 add in trunk

[macOS] Unable to copy text from the function browser panel in Numbers
​https://bugs.webkit.org/show_bug.cgi?id=215740
<rdar://problem/65189303>

Reviewed by Darin Adler.

Source/WebKit:

On some versions of Xcode, using Interface Builder to set up WKWebViews causes the WKWebView to contain two
WKFlippedViews as subviews; one of these is created and added in the normal initialization path of the web view
underneath WebViewImpl's constructor, and the other is created and added underneath the superclass (NSView's)
-initWithCoder: implementation.

This causes issues when hit-testing WKWebView using the -hitTest: method, which is expected to return the
WKWebView itself instead of the inner WKFlippedView. The logic that tries to implement this behavior is in
WebViewImpl::hitTest, which calls into WKWebView's -hitTest: method and returns the WKWebView if the hit-
tested view ended up being equal to the m_layerHostingView. Since we end up with two layer hosting views (only
one of which is the real m_layerHostingView), we fail the check and end up returning the other WKFlippedView.
In the context of this bug, this erroneous hit-test causes AppKit to ask if the WKFlippedView can become the
first responder upon mousedown (which it cannot), and so the window's first responder remains the same (instead
of changing to WKWebView).

To fix this, adjust the constructor of WebViewImpl to avoid making an extra layer hosting view in the case where
decoding the WKWebView already initialized and placed the layer hosting view, and just use the existing one
instead.

Test: WKWebView.HitTestAfterInitializingFromCoder

• UIProcess/Cocoa/WebViewImpl.mm:

(-[WKFlippedView initWithFrame:]):
(-[WKFlippedView initWithCoder:]):
(-[WKFlippedView _commonInitialize]):

Override both designated initialization codepaths so that we call the -_commonInitialize helper, which sets
the autoresizing mask. This was previously called immediately after creating the WKFlippedView in the
constructor of WebViewImpl.

(WebKit::WebViewImpl::WebViewImpl):

Tools:

Add a new API test that serializes a WKWebView, then deserializes it, and then verifies that calling -hitTest:
on the deserialized WKWebView grabs the WKWebView itself rather than the WKFlippedView underneath it.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/WKWebViewCoders.mm: Added.

5:20 PM Changeset in webkit [266020] by Jonathan Bedard

• 2 edits
  1 add in trunk/Tools

Regression (r265942): Layout-tests are hanging on iOS EWS
​https://bugs.webkit.org/show_bug.cgi?id=215742
<rdar://problem/67584717>

Unreviewed infrastructure fix.

Partial revert of r265942, since EWS is raising objc exceptions after forking.

• Scripts/webkitpy/common/timeout_context.py:

(Timeout):

• Scripts/webkitpy/common/timeout_context_unittest.py: Added.

(TimeoutContextTests):

4:46 PM Changeset in webkit [266019] by commit-queue@webkit.org

• 6 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r265965.
​https://bugs.webkit.org/show_bug.cgi?id=215744

getCallData can be called from DFG concurrent compiler, but it
is not safe in DOM PluginObject

Reverted changeset:

"Use jsTypeofIsObject() in DFG AI and
operationTypeOfIsObject()"
​https://bugs.webkit.org/show_bug.cgi?id=144457
​https://trac.webkit.org/changeset/265965

4:07 PM Changeset in webkit [266018] by Alexey Shvayka

• 10 edits in trunk

Align "length" properties of function prototypes with the spec
​https://bugs.webkit.org/show_bug.cgi?id=215716

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This change defines Function.prototype.length [1] as Configurable? and
removes "length" properties from other (async/generator) function prototypes
that are ordinary non-callable objects [2], aligning JSC with V8 and SpiderMonkey.

Also, adds inherits() ASSERT in FunctionPrototype::finishCreation()
to match (most of) the other built-ins.

[1]: ​https://tc39.es/ecma262/#sec-properties-of-the-function-prototype-object
[2]: ​https://tc39.es/ecma262/#sec-async-function-prototype-properties

• runtime/AsyncFunctionPrototype.cpp:

(JSC::AsyncFunctionPrototype::finishCreation):

• runtime/AsyncGeneratorFunctionPrototype.cpp:

(JSC::AsyncGeneratorFunctionPrototype::finishCreation):

• runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):

• runtime/GeneratorFunctionPrototype.cpp:

(JSC::GeneratorFunctionPrototype::finishCreation):

LayoutTests:

• js/kde/prototype_length-expected.txt:
• js/kde/script-tests/prototype_length.js:

3:49 PM Changeset in webkit [266017] by Simon Fraser

• 2 edits in trunk/Tools

Fix the Color/ExtendedColor lldb data provider
​https://bugs.webkit.org/show_bug.cgi?id=215735

Reviewed by Darin Adler.

Fix the data provider for Color after Color and ExtendedColor internals changed.

• lldb/lldb_webkit.py:

(WebCoreColorProvider._to_string_extended):
(WebCoreColorProvider.to_string):

3:49 PM Changeset in webkit [266016] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Add some FIXMEs in the EventHandler wheel event handling code for all the things that are wrong
​https://bugs.webkit.org/show_bug.cgi?id=215741

Reviewed by Wenson Hsieh.

There is much confusing code here. Trying to document the issues I've found.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

• page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

2:30 PM Changeset in webkit [266015] by Alexey Shvayka

• 5 edits in trunk

Define Intl[Symbol.toStringTag]
​https://bugs.webkit.org/show_bug.cgi?id=215715

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-object.js:
• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch utilizes JSC_TO_STRING_TAG_WITHOUT_TRANSITION() to define Symbol.toStringTag
on Intl namespace object, implementing the recent spec change [1] and aligning JSC with V8.
Also, adds inherits() ASSERT to match (most of) the other built-ins.

[1]: ​https://github.com/tc39/ecma402/pull/487

• runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

2:29 PM Changeset in webkit [266014] by aestes@apple.com

• 4 edits in trunk/Source/WebKit

IPC::encodeSharedBuffer combines SharedBuffer data segments when copying to SharedMemory
​https://bugs.webkit.org/show_bug.cgi?id=215737
<rdar://problem/67568099>

Reviewed by Darin Adler.

IPC::encodeSharedBuffer called SharedBuffer::data() when copying data into SharedMemory,
requiring the SharedBuffer to combine its data segments. This can be avoided by using
SharedMemory::copyBuffer() instead.

• Platform/SharedMemory.cpp:

(WebKit::SharedMemory::copyBuffer): Modernized to use auto and range-based for loops.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer): Used SharedMemory::copyBuffer() to create a copy of the buffer in
a new SharedMemory. Calling this function does not combine the buffer's data segments.

• Platform/SharedMemory.h: Added a FIXME for how SharedMemory's factory functions could be

improved.

1:41 PM Changeset in webkit [266013] by Alexey Shvayka

• 8 edits
  1 add in trunk

Function.prototype.bind should not clamp "length" to int32
​https://bugs.webkit.org/show_bug.cgi?id=215733

Reviewed by Darin Adler.

JSTests:

• microbenchmarks/function-bind-creation.js: Added.
• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch fixes to integer conversion of target function's "length" values
beyond UINT_MAX, aligning JSC with the spec [1], V8 and SpiderMonkey.

double is used instead of uint64_t to retain semantics of JS Number type [2]
and hold Infinity values. To avoid spreading double length over JSFunction::create()
and its subclasses, JSBoundFunction is modified to use JSFunction::finishCreation(VM&)
overload, removing 2 unused arguments and speeding up bound function creation by ~9%.

[1]: ​https://tc39.es/ecma262/#sec-function.prototype.bind (step 6.c.i)
[2]: ​https://tc39.es/ecma262/#sec-ecmascript-language-types-number-type

• builtins/FunctionPrototype.js:

(bind):

• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

• runtime/JSBoundFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::reifyLength):

• runtime/JSGlobalObject.cpp:

(JSC::makeBoundFunction):

12:43 PM Changeset in webkit [266012] by Lauro Moura

• 2 edits in trunk/Tools

[GLIB] Update checked exception after r265942
​https://bugs.webkit.org/show_bug.cgi?id=215738

Reviewed by Carlos Alberto Lopez Perez.

Avoid aborting the full script on a timeout due to unchecked
exception.

• glib/api_test_runner.py:

(TestRunner._run_google_test): Use exception from new timeout module.

12:16 PM Changeset in webkit [266011] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Use closeReason provided in didCloseWithCode delegate for the NSURLSessionWebSocket code path
​https://bugs.webkit.org/show_bug.cgi?id=215519

Patch by Jiten Mehta <​jmehta@apple.com> on 2020-08-21
Reviewed by Youenn Fablet.

Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:webSocketTask:didCloseWithCode:reason:]):

11:28 AM Changeset in webkit [266010] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Merge two DOMURL constructors
​https://bugs.webkit.org/show_bug.cgi?id=215734

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-21
Reviewed by Darin Adler.

Merge two DOMURL constructors to make it match the relevant WebIDL:
​https://url.spec.whatwg.org/#dom-url-url-url-base-base

• html/DOMURL.cpp:

(WebCore::DOMURL::create):

• html/DOMURL.h:
• html/DOMURL.idl:

10:43 AM Changeset in webkit [266009] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Fix USE_ANGLE=0 build after "WebGLLayer clobbers TEXTURE_2D binding on iOS"
​https://bugs.webkit.org/show_bug.cgi?id=211758

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-08-21
Reviewed by Kenneth Russell.

No new tests, build fix.

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getUniformIndices): Mark parameters unused
when USE_ANGLE=0

• platform/graphics/cocoa/WebGLLayer.mm: Define scoped binding restorer

only for USE_ANGLE=1, since it's not used otherwise and it is implemented
in terms of ANGLE gl::... API.

• platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

Include Logging.h to make RELEASE_LOG(WebGL, ...) work.
Presumably this file is not compiled with USE_ANGLE=1 or
the unified build mechanism hides the error.

9:39 AM Changeset in webkit [266008] by Russell Epstein

• 1 copy in tags/Safari-610.1.28.1.3

Tag Safari-610.1.28.1.3.

9:36 AM Changeset in webkit [266007] by Russell Epstein

• 9 edits in branches/safari-610.1.28.1-branch/Source

Cherry-pick r265953. rdar://problem/67560218

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNetWin.cpp: (WebCore::createPrivateStorageSession):
• platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::createPrivateStorageSession):

Source/WebKit:

• WebProcess/Network/NetworkProcessConnection.h: (WebKit::NetworkProcessConnection::cookieAcceptPolicy const):
• WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm: (WebKit::WebCookieCache::inMemoryStorageSession):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [266006] by Russell Epstein

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.3

9:25 AM Changeset in webkit [266005] by Russell Epstein

• 2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r265252. rdar://problem/67080756

about: scheme URL constants should be backed by StaticStringImpl
​https://bugs.webkit.org/show_bug.cgi?id=215113

Reviewed by Darin Adler.

• wtf/URL.cpp: (WTF::aboutBlankURL): (WTF::aboutSrcDocURL):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:42 AM Changeset in webkit [266004] by Andres Gonzalez

• 6 edits in trunk

Source/WebCore:
Range::contains does not work correctly when the common ancestor node is a Document.
​https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Test: accessibility/mac/selected-visible-position-range.html.

For a Range with a Document object as common ancestor, Range::contains(otherRange)
would return false for any given other range in the same document. This
causes problems in VoiceOver navigation and Braille functionality in
the MacOS Mail.app.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const):
Use SimpleRange::isNull instead of repeating its implementation.

• dom/Range.cpp:

(WebCore::Range::contains const): Compare the Documents of the ranges'
common ancesstor nodes instead of their ownerDocuments.

LayoutTests:
Range::contains(const Range&) should compare the Documents to which the Ranges belong, not the ownerDocuments.
​https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Revamped the following test to check that a collapsed selection range is
set to the correct character offset in the text content. In addition,
properly used the Promise returned by waitFor in order to make the test
timing independent and work in isolated tree mode.

• accessibility/mac/selected-visible-position-range-expected.txt:
• accessibility/mac/selected-visible-position-range.html:

4:29 AM Changeset in webkit [266003] by aestes@apple.com

• 48 edits
  3 copies in trunk/Source/WebKit

REGRESSION (r257667): 1.9x more CPU time in IPC::SharedBufferDataReference decoding during Netflix playback
​https://bugs.webkit.org/show_bug.cgi?id=215232
<rdar://problem/66637920>

Reviewed by Geoff Garen.

Prior to r257667, an IPC message defined a IPC::SharedBufferDataReference argument to allow
its sender to easily encode SharedBuffer data as a DataReference. SharedBufferDataReference
cost the same to encode as a DataReference -- both copied data into the Encoder -- but did
so by iterating over the SharedBuffer's data segments rather than combining them into a
contiguous allocation. The message argument was received as a decoded IPC::DataReference,
which stores a pointer into the IPC::Decoder's buffer rather than making a copy.

In r257667, IPC::SharedBufferDataReference switched its encoder to use IPC::ArgumentCoder's
SharedBuffer specialization, which works by allocating a SharedMemory buffer, copying
SharedBuffer data into it, creating a SharedMemory::IPCHandle from it, and encoding the
handle. It makes only one copy like the old encoder did, but pays the added cost of
combining SharedBuffer data segments prior to copying by needlessly calling
SharedBuffer::data() (this should be fixed independently).

Since this serialization could no longer be decoded by DataReference's decoder,
SharedBufferDataReference implemented a decoder, also in terms of ArgumentCoder's SharedBuffer
specialization. It works by mapping a SharedMemory buffer from a decoded
SharedMemory::IPCHandle and copying that buffer into a new SharedBuffer. This copy is a cost
that the old decoder did not incur, but in some cases the message receiver would have made
such a copy anyway and can instead just ref the decoded SharedBuffer. In other cases though,
the receiver either made no copies or couldn't use the decoded SharedBuffer to avoid making
its own copy so creating the SharedBuffer was pure added cost.

There are additional costs from allocating, mapping, and deleting shared memory and Mach
send rights, but they are offset by savings due to smaller Encoder and Decoder buffers. The
additional SharedBuffer combining and copying is not offset elsewhere, and on net makes
sending and receiving IPC::SharedBufferDataReferences use up to 2x more CPU time when
playing a video on netflix.com in Safari.

Resolve this slowdown by reverting the argument encoding changes made to
IPC::SharedBufferDataReference in r257667. For compatibility with code added after r257667,
the current IPC::SharedBufferDataReference was copied to IPC::SharedBufferCopy and retains
the behavior of copying into a SharedBuffer when decoded. IPC::SharedBufferDataReference now
has the pre-r257667 behavior of decoding to an IPC::DataReference. Messages added after
r257667 whose receivers were designed to handle a SharedBuffer were changed to use
IPC::SharedBufferCopy, and all other receivers of messages with IPC::SharedBufferDataReference
arguments were changed to handle an IPC::DataReference.

• GPUProcess/media/RemoteCDMInstanceProxy.cpp:
• GPUProcess/media/RemoteCDMInstanceProxy.h:
• GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
• GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
• GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
• GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
• GPUProcess/media/RemoteCDMProxy.cpp:
• GPUProcess/media/RemoteCDMProxy.h:
• GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
• GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
• GPUProcess/media/RemoteLegacyCDMSessionProxy.messages.in:
• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::platformRegisterAttachment):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebPasteboardProxy.h:
• UIProcess/WebPasteboardProxy.messages.in:
• UIProcess/gtk/WebPasteboardProxyGtk.cpp:
• WebProcess/GPU/media/RemoteCDMInstance.cpp:
• WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
• WebProcess/GPU/media/RemoteCDMInstanceSession.h:
• WebProcess/GPU/media/RemoteCDMInstanceSession.messages.in:
• WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
• WebProcess/GPU/media/RemoteLegacyCDMSession.h:
• WebProcess/GPU/media/RemoteLegacyCDMSession.messages.in:
• WebProcess/WebCoreSupport/WebEditorClient.cpp:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Replaced

IPC::SharedBufferDataReference with IPC::SharedBufferCopy.

• NetworkProcess/NetworkResourceLoader.cpp:
• NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
• NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
• NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
• WebProcess/Network/WebResourceLoader.cpp:
• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Network/WebResourceLoader.messages.in:
• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Removed the DidReceiveSharedBuffer

message and reverted the DidReceiveData message back to taking an
IPC::SharedBufferDataReference.

• Platform/IPC/Encoder.h: Made Encoder::reserve(size_t) public so

SharedBufferCopy::encode(Encoder&) can call it.

• Platform/IPC/HandleMessage.h: Restored the CodingType specialization that decodes

SharedBufferDataReference arguments as DataReferences.

• Platform/IPC/SharedBufferCopy.cpp:
• Platform/IPC/SharedBufferCopy.h: Copied from SharedBufferDataReference.h. Implemented the

interface and decoding behavior that SharedBufferDataReference had between r257667 and this
change.

• Platform/IPC/SharedBufferDataReference.cpp:
• Platform/IPC/SharedBufferDataReference.h: Reverted to the pre-r257667 interface and

decoding behvior.

• Scripts/webkit/messages.py: Removed an unneeded special case.

• Sources.txt:
• WebKit.xcodeproj/project.pbxproj: Added SharedBuffer{Copy,DataReference}.cpp.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::finishedLoadingIcon):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/WebPage.h: Used const IPC::DataReference& in message receiver

signatures for SharedBufferDataReference arguments.

• UIProcess/WebURLSchemeTask.cpp:
• WebProcess/GPU/media/RemoteAudioBusData.h:
• WebProcess/GPU/media/RemoteCDM.cpp:
• WebProcess/Network/WebLoaderStrategy.cpp: Removed unused includes.

12:51 AM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

Aug 20, 2020:

11:55 PM Changeset in webkit [266002] by Peng Liu

• 2 edits in trunk/Source/WebKit

Mac Catalyst Apps require "playsinline" attribute to support playing videos in the inline mode
​https://bugs.webkit.org/show_bug.cgi?id=215724

Reviewed by Tim Horton.

Currently WebKit::currentUserInterfaceIdiomIsPad() returns NO on Mac Catalyst apps.
Therefore, the behavior of Mac Catalyst apps regarding the inline media playback
support is not consistent with iPad apps.

This patch removes the usage of WebKit::currentUserInterfaceIdiomIsPad() to decide
the settings of the inline media playback support on Mac Catalyst apps.

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

11:55 PM Changeset in webkit [266001] by Fujii Hironori

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/TestExpectations: Remove lines for removed tests.

11:46 PM Changeset in webkit [266000] by commit-queue@webkit.org

• 8 edits in trunk

[GTK][WPE] Debug crashes in backdrop filter tests
​https://bugs.webkit.org/show_bug.cgi?id=215209

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-20
Reviewed by Adrian Perez de Castro.

Source/WebCore:

This only happens in WKTR because RenderLayerCompositor::flushPendingLayerChanges() is called from
RenderLayerCompositor::layerTreeAsText(), so the coordinator doesn't know layers are being flushed and we don't
return early from notifyFlushRequired(). We don't really need to have a coordinator associated to the backdrop
layer, we just need to attach the layer to the coordinator to ensure it's updated.

• platform/graphics/nicosia/NicosiaAnimation.cpp:

(Nicosia::Animation::applyInternal): Handle AnimatedPropertyWebkitBackdropFilter.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer): Detach also the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Attach the backdrop layer to the
coordinator if there's one.
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Do not call this for the
backdrop layer.
(WebCore::CoordinatedGraphicsLayer::invalidateCoordinator): Set coordinator to nullptr.
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded): Set the coordinator and attach
the layer. Also attach the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::setCoordinator): Deleted.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::~CompositingCoordinator): Use invalidateCoordinator() instead of setCoordinator()
that has been removed.
(WebKit::CompositingCoordinator::createGraphicsLayer): Use setCoordinatorIncludingSubLayersIfNeeded() instead of
attaching the layer directly.
(WebKit::CompositingCoordinator::attachLayer): Do not call setCoordinator(), the caller is expected to set the
coordinator.

LayoutTests:

Remove expectations for tests that are now passing.

• platform/glib/TestExpectations:

11:20 PM Changeset in webkit [265999] by Diego Pino Garcia

• 2 edits in trunk/Tools

[EWS] Add more workers to GTK-WK2-Tests-EWS queue
​https://bugs.webkit.org/show_bug.cgi?id=215408

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/config.json:

9:53 PM Changeset in webkit [265998] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Mark several WebGL tests as failure after r265975.

• platform/glib/TestExpectations:

8:50 PM Changeset in webkit [265997] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Replace IC on Proxy must write barrier Proxy's target
​https://bugs.webkit.org/show_bug.cgi?id=215720

Reviewed by Yusuke Suzuki.

The put_by_id opcode in the baseline and the DFG/FTl will emit a writeBarrier
after the operation is complete. But it does this to the base object. In the
case of an IC with the base as a Proxy, we're not actually storing to the Proxy, but
instead, the Proxy's target. This patch makes it so our IC code writeBarriers
the Proxy's target. This fixed a crash when running Speedometer2.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::canReplace const):
(JSC::AccessCase::generateImpl):

• bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::preserveLiveRegistersToStackForCallWithoutExceptions):

• bytecode/PolymorphicAccess.h:

7:31 PM Changeset in webkit [265996] by pvollan@apple.com

• 6 edits
  1 add in trunk

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
​https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

• pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::reduceMotionPreferenceKey):
(WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added.

(TEST):

7:10 PM Changeset in webkit [265995] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(r156546): 18 media tests broken
​https://bugs.webkit.org/show_bug.cgi?id=122021

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

6:39 PM Changeset in webkit [265994] by Alan Coon

• 1 copy in tags/Safari-610.1.26.3

Tag Safari-610.1.26.3.

6:38 PM Changeset in webkit [265993] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.26-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
​https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

• animations/legacy-encoding-timing-function-expected.txt: Added.
• animations/legacy-encoding-timing-function.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:36 PM Changeset in webkit [265992] by Alan Coon

• 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.3

6:33 PM Changeset in webkit [265991] by Chris Dumez

• 12 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio tests.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:

6:33 PM Changeset in webkit [265990] by Hector Lopez

• 1 edit in trunk/LayoutTests/ChangeLog

[ macOS ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

• platform/mac/TestExpectations:

6:33 PM Changeset in webkit [265989] by Hector Lopez

• 2 edits in trunk/LayoutTests

fast/repaint/list-item-equal-style-change-no-repaint.html
​https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:47 PM Changeset in webkit [265988] by Russell Epstein

• 5 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67417186

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp: (run):
• b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [265987] by Russell Epstein

• 4 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r264643. rdar://problem/67027034

TryGetById clobberize rules are wrong.
​https://bugs.webkit.org/show_bug.cgi?id=163834
<rdar://problem/65625807>

Reviewed by Keith Miller.

Theoretically, TryGetById can do the same things GetById does i.e. reify lazy
properties, read the stack, etc. Hence, its clobberize rule should be clobberTop
just like GetById. However, in practice, we don't currently use @tryGetById to
access anything on the stack (and probably never will). But as a conservative
measure, we'll just treat TryGetById like it can. In clobberize terms, this
means we declare TryGetById as doing read(World) (just like GetById) instead of
read(Heap).

• dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
• dfg/DFGClobberize.h: (JSC::DFG::clobberize):
• dfg/DFGClobbersExitState.cpp: (JSC::DFG::clobbersExitState):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@264643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:19 PM Changeset in webkit [265986] by Karl Rackler

• 25 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c

Unreviewed test gardening. Revert unnecessary baseline.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

5:12 PM Changeset in webkit [265985] by Wenson Hsieh

• 3 edits
  2 adds in trunk

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
​https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

• animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

• animations/animation-followed-by-two-transitions-expected.txt: Added.
• animations/animation-followed-by-two-transitions.html: Added.

4:53 PM Changeset in webkit [265984] by Russell Epstein

• 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-7609.4.1

4:48 PM Changeset in webkit [265983] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkitcorepy] Fix pip package
​https://bugs.webkit.org/show_bug.cgi?id=215717
<rdar://problem/67512294>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/MANIFEST.in: Add cacert.pem.
• Scripts/libraries/webkitcorepy/setup.py: Include submodules.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Version bump.

4:34 PM Changeset in webkit [265982] by Karl Rackler

• 3 edits in branches/safari-610.1.28.1-branch/LayoutTests

rdar://67367072 REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

4:15 PM Changeset in webkit [265981] by Chris Dumez

• 4 edits in trunk

AudioBufferSourceNode should use "final" values for playbackRate and detune
​https://bugs.webkit.org/show_bug.cgi?id=215669

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:

Source/WebCore:

AudioBufferSourceNode should use "final" values for playbackRate and detune to take into
account changes to the AudioParamTimeline (for example, when
AudioBufferSourceNode.playbackRate.setValueAtTime() is called).

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

4:14 PM Changeset in webkit [265980] by Chris Dumez

• 36 edits in trunk

AudioParam.automationRate attribute is missing
​https://bugs.webkit.org/show_bug.cgi?id=215710

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

Source/WebCore:

Add initial support for AudioParam.automationRate:

• ​https://www.w3.org/TR/webaudio/#dom-audioparam-automationrate

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

• Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::setAutomationRate):
(WebCore::AudioParam::calculateSampleAccurateValues):

• Modules/webaudio/AudioParam.h:
• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

• Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):
(WebCore::ConstantSourceNode::process):

• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

• Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

• Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):
(WebCore::GainNode::process):

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::distanceConeGain):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::process):

• Modules/webaudio/WebKitAudioBufferSourceNode.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::distanceConeGain):

• Modules/webaudio/WebKitAudioPannerNode.h:
• Modules/webaudio/WebKitDynamicsCompressorNode.h:

4:12 PM Changeset in webkit [265979] by Karl Rackler

• 3 edits in branches/safari-610.1.28.0-branch/LayoutTests

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

4:11 PM Changeset in webkit [265978] by Karl Rackler

• 24 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Jazz/Azul wk2 ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Rebaseline failing test since required webaudio changes are not intended to be cherry-picked to the branch.

Unreviewed test gardening.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

3:55 PM Changeset in webkit [265977] by James Savage

• 3 edits in trunk/Source/WebKit

Could not find module 'WebKit' for target 'armv7-apple-ios'
<​https://bugs.webkit.org/show_bug.cgi?id=215190>
<rdar://problem/65642049>

Reviewed by Brady Eidson.

The config changes here got added to the wrong config file. They need to
be for the overlay, not its tests.

• SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig:
• SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig:

3:51 PM Changeset in webkit [265976] by Alan Coon

• 1 copy in tags/Safari-610.1.28.3.2

Tag Safari-610.1.28.3.2.

3:41 PM Changeset in webkit [265975] by commit-queue@webkit.org

• 16 edits in trunk

[WebGL2] Pass context-lost-restored.html test
​https://bugs.webkit.org/show_bug.cgi?id=215599

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-08-20
Reviewed by Dean Jackson.

Source/WebCore:

Support losing extensions, and restoring them via
WEBGL_lose_context.

Necessarily changed WebGLExtensions to be RefCounted rather than
managed via unique_ptr. Multiple instances of the same
WebGLExtension subclass can now be vended from a WebGL rendering
context, and WebGLExtensions can now outlive their rendering
context - they do not ref their context.

Extensions now hold a weak pointer to their
WebGLRenderingContextBase rather than a C++ reference. When an
extension's parent context is lost, that pointer is nulled out.
Extensions are forcibly lost upon WebGL context destruction.

WebGL extensions' IDLs still use
GenerateIsReachable=ImplWebGLRenderingContext, so that if the
context is still alive, the JavaScript wrappers for the extension
objects will be preserved. (If the extension is lost, the bindings
will fetch nullptr for the context, which won't be in the opaque
root set, so the JavaScript wrapper won't be artificially kept
alive.)

Covered by existing WebGL conformance tests.

• html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::drawArraysInstancedANGLE):
(WebCore::ANGLEInstancedArrays::drawElementsInstancedANGLE):
(WebCore::ANGLEInstancedArrays::vertexAttribDivisorANGLE):

• html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):

• html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

• html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::drawBuffersWEBGL):

• html/canvas/WebGLExtension.cpp:

(WebCore::WebGLExtension::WebGLExtension):
(WebCore::WebGLExtension::loseParentContext):

• html/canvas/WebGLExtension.h:

(WebCore::WebGLExtension::context):
(WebCore::WebGLExtension::isLost):
(WebCore::WebGLExtension::ref): Deleted.
(WebCore::WebGLExtension::deref): Deleted.

• html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
(WebCore::WebGLLoseContext::loseParentContext):

• html/canvas/WebGLLoseContext.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::loseExtensions):

• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

Rebaselined WebGL conformance tests which are now fully passing.

• webgl/1.0.3/conformance/context/context-lost-restored-expected.txt:
• webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:

3:38 PM Changeset in webkit [265974] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.2

Tag Safari-610.1.28.1.2.

3:37 PM Changeset in webkit [265973] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.2

Tag Safari-610.1.28.0.2.

3:34 PM Changeset in webkit [265972] by Alan Coon

• 1 copy in tags/Safari-610.1.26.2

Tag Safari-610.1.26.2.

3:32 PM Changeset in webkit [265971] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] Handle bugs with unicode characters in title in ews emails
​https://bugs.webkit.org/show_bug.cgi?id=215627

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ensure email_subject is unicode.
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Ditto.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:09 PM Changeset in webkit [265970] by Alan Coon

• 2 edits in branches/safari-610.1.26-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364266

Fix null pointer crashes in network process after r265835

​​https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:09 PM Changeset in webkit [265969] by Alan Coon

• 4 edits in branches/safari-610.1.26-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:57 PM Changeset in webkit [265968] by Alan Coon

• 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.2

2:39 PM Changeset in webkit [265967] by Lauro Moura

• 41 edits
  1 move
  1 add
  1 delete in trunk/LayoutTests

[GTK][WPE] Rebaseline websocket tests after r265592

Unreviewed test gardening.

• platform/glib/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Renamed from LayoutTests/platform/wpe/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt.
• platform/glib/http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/close-before-open-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/close-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/closed-port-delay-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-error-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-invalid-parameter-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Added.
• platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
• platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt:
• platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt:
• platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Removed.

2:37 PM Changeset in webkit [265966] by Alexey Shvayka

• 4 edits in trunk

Invalid early errors for class methods named "constructor" and "prototype"
​https://bugs.webkit.org/show_bug.cgi?id=215413

Reviewed by Darin Adler.

JSTests:

• test262/expectations.yaml: Mark 24 test cases as passing.

Source/JavaScriptCore:

This change removes invalid early syntax errors, allowing static async/generator
methods named "constructor" and instance async/generator methods named "prototype",
which aligns JSC with the spec [1], V8, and SpiderMonkey.

Also, removes a FIXME related to super() calls outside constructor that was
resolved in r181404 and is covered by test262 suite.

[1]: ​https://tc39.es/ecma262/#sec-class-definitions-static-semantics-early-errors

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

2:25 PM Changeset in webkit [265965] by Alexey Shvayka

• 6 edits in trunk/Source/JavaScriptCore

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

This patch:

1. Refactors jsTypeofIsObject(), leveraging fast path of isCallable(), moves it to the header, and utilizes it in DFG AI and operationTypeOfIsObject() to eliminate code duplication.

2. Splits jsTypeofIsFunction() into 2 methods to accomodate operationTypeOfIsFunction() calling it with JSObject* argument.

3. Removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.h:
• runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsObject):
(JSC::jsTypeofIsFunction):

2:08 PM Changeset in webkit [265964] by Aditya Keerthi

• 5 edits in trunk/Source

Add runtime setting for editable components in date/time inputs
​https://bugs.webkit.org/show_bug.cgi?id=215705

Reviewed by Wenson Hsieh.

Source/WebCore:

This setting controls the ability to edit individual components of date
and time input types. For example, <input type=date> will have three
editable components - year, month, and day.

• page/Settings.yaml:

Source/WebKit:

Added DateTimeInputsEditableComponentsEnabled as a runtime setting. This
setting is enabled by default on macOS.

• Shared/WebPreferences.yaml:
• Shared/WebPreferencesDefaultValues.h:

2:02 PM Changeset in webkit [265963] by commit-queue@webkit.org

• 4 edits in trunk

XMLHttpRequest.open should use USVString
​https://bugs.webkit.org/show_bug.cgi?id=215704

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-20
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/xhr/open-url-encoding-expected.txt:

Source/WebCore:

XMLHttpRequest.open should use USVString as mentioned in the FIXMEs and the spec [1].

Test: imported/w3c/web-platform-tests/xhr/open-url-encoding.html

[1] ​https://xhr.spec.whatwg.org/#ref-for-dom-xmlhttprequest-open

• xml/XMLHttpRequest.idl:

1:44 PM Changeset in webkit [265962] by Chris Dumez

• 25 edits
  7 adds in trunk

Introduce StereoPannerNode Interface
​https://bugs.webkit.org/show_bug.cgi?id=215518

Patch by Clark Wang <​clark_wang@apple.com> on 2020-08-20
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-baselined existing tests. Some now fail due to missing automation rate.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-panning-expected.txt:

Source/WebCore:

Added StereoPannerNode according to spec: ​https://www.w3.org/TR/webaudio/#stereopannernode.
Used Chromium implementation for guidance: ​https://source.chromium.org/chromium/chromium/src/
+/master:third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc.
Added in StereoPannerOptions and StereoPanner files as well. The latter used Chromium
implementation for guidance: ​https://source.chromium.org/chromium/chromium/src/+
/master:third_party/blink/renderer/platform/audio/stereo_panner.cc

Re-baselined existing tests. Some now fail due to missing automation rate.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createStereoPanner):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/BaseAudioContext.idl:
• Modules/webaudio/StereoPannerNode.cpp: Added.

(WebCore::StereoPannerNode::create):
(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::~StereoPannerNode):
(WebCore::StereoPannerNode::process):
(WebCore::StereoPannerNode::initialize):
(WebCore::StereoPannerNode::uninitialize):
(WebCore::StereoPannerNode::listener):
(WebCore::StereoPannerNode::setChannelCount):
(WebCore::StereoPannerNode::setChannelCountMode):

• Modules/webaudio/StereoPannerNode.h: Added.
• Modules/webaudio/StereoPannerNode.idl: Added.
• Modules/webaudio/StereoPannerOptions.h: Added.
• Modules/webaudio/StereoPannerOptions.idl: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• platform/audio/StereoPanner.cpp: Added.

(WebCore::StereoPanner::create):
(WebCore::StereoPanner::StereoPanner):
(WebCore::StereoPanner::panWithSampleAccurateValues):
(WebCore::StereoPanner::panToTargetValue):

• platform/audio/StereoPanner.h: Added.

(WebCore::StereoPanner::~StereoPanner):

• platform/graphics/cocoa/SourceBufferParserWebM.cpp:

1:37 PM Changeset in webkit [265961] by Alexey Shvayka

• 11 edits
  1 move
  271 adds
  15 deletes in trunk/JSTests

Update test262 to commit e0a65ee75ef8
​https://bugs.webkit.org/show_bug.cgi?id=215708

Reviewed by Yusuke Suzuki.

• test262/expectations.yaml:
• test262/harness/*: Updated.
• test262/latest-changes-summary.txt:
• test262/test/*: Updated.
• test262/test262-Revision.txt:

1:37 PM Changeset in webkit [265960] by Diego Pino Garcia

• 2 edits in trunk/Tools

[ews] Add 'jsc-mips-tests' bubble
​https://bugs.webkit.org/show_bug.cgi?id=215697

This new bubble runs jscore-tests for JSC MIPS 32-bit. The former
'jsc-mips' bubble now reports about successful binary builds for the
same architecture.

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

1:06 PM Changeset in webkit [265959] by svillar@igalia.com

• 5 edits in trunk/Source/WebCore

Unreviewed, reverting r265850.

Tests crash on debug builds

Reverted changeset:

"[WebXR] Make "in parallel" code run really in parallel"
​https://bugs.webkit.org/show_bug.cgi?id=215642
​https://trac.webkit.org/changeset/265850

12:57 PM Changeset in webkit [265958] by Diego Pino Garcia

• 5 edits in trunk/Tools

[ews] Split JSC MIPS queue into separate builder and tester queue
​https://bugs.webkit.org/show_bug.cgi?id=212009

Reviewed by Aakash Jain.

Currently there are two EWS JSC MIPS configured, one that runs as
buildAndTest and another one that runs as buildOnly.

This patch changes the buildAndTest bot to test, and makes the
bot fetch the binary product produced by the buildOnly bot.

• BuildSlaveSupport/ews-build/config.json:
• BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory):
(JSCTestsFactory.init):

• BuildSlaveSupport/ews-build/factories_unittest.py:

(TestLayoutTestsFactory.test_gtk_factory):
(TestJSCBuildFactory):
(TestJSCBuildFactory.test_jsc_mipsel_factory):
(TestJSCBuildFactory.test_jsc_armv7_factory):
(TestJSCBuildAndTestsFactory):
(TestJSCBuildAndTestsFactory.test_jsc_mipsel_factory):
(TestJSCBuildAndTestsFactory.test_jsc_armv7_factory):
(TestJSCTestsFactory):
(TestJSCTestsFactory.test_jsc_mipsel_factory):
(TestJSCTestsFactory.test_jsc_armv7_factory):

• BuildSlaveSupport/ews-build/loadConfig.py:

12:32 PM Changeset in webkit [265957] by Jonathan Bedard

• 3 edits
  2 adds in trunk/Tools

[webkitcorepy] Add subprocess_utils.run
​https://bugs.webkit.org/show_bug.cgi?id=215702
<rdar://problem/67487751>

Reviewed by Dewei Zhu.

Python 3's subprocess.run API is much better than the multiple subprocess APIs that Python 2 provides. Rather than
requiring new scripts and libraries to be fully Python 3, we should provide a Python 2 API identical to subprocess.run.

• Scripts/libraries/webkitcorepy/README.md: Document usage of subprocess_utils.run.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export subprocess_utils, bump minor version.
• Scripts/libraries/webkitcorepy/webkitcorepy/subprocess_utils.py: Added.

(run): Declare Python 2 version of Python 3's subprocess.run API.
(TimeoutExpired): Ditto.
(CompletedProcess): Ditto.

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/subprocess_utils_unittest.py: Added.

(SubprocessUtils):
(SubprocessUtils.test_run):
(SubprocessUtils.test_run_exit):
(SubprocessUtils.test_run_timeout):
(SubprocessUtils.test_run_timeout_context):

11:48 AM Changeset in webkit [265956] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Revert "Versioning."

11:47 AM Changeset in webkit [265955] by Alan Coon

• 1 copy in tags/Safari-610.2.2

Tag Safari-610.2.2.

11:37 AM Changeset in webkit [265954] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215706

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:53 AM Changeset in webkit [265953] by Chris Dumez

• 9 edits in trunk/Source

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::createPrivateStorageSession):

• platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::createPrivateStorageSession):

Source/WebKit:

• WebProcess/Network/NetworkProcessConnection.h:

(WebKit::NetworkProcessConnection::cookieAcceptPolicy const):

• WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm:

(WebKit::WebCookieCache::inMemoryStorageSession):

10:30 AM Changeset in webkit [265952] by youenn@apple.com

• 3 edits in trunk/Source/WebKit

Align console log message of new WebSocket code path with the legacy code path
​https://bugs.webkit.org/show_bug.cgi?id=215695

Reviewed by Alex Christensen.

No observable change of behavior from the page.
Console log messages appear in expected.txt files when NSURLSession code path is enabled.

• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::connect):
(WebKit::WebSocketChannel::didReceiveMessageError):

• WebProcess/Network/WebSocketChannel.h:

9:49 AM Changeset in webkit [265951] by youenn@apple.com

• 1 edit
  3 adds in trunk/LayoutTests

Add a WebSocket test checking close with 1000
​https://bugs.webkit.org/show_bug.cgi?id=215694

Reviewed by Alex Christensen.

http/tests/websocket/tests/hybi/client-close.html is not running consistently between Firefox, Chrome, WebKit legacy WebSocket and WebKit NSURLSession WebSocket.
Add another test that uses an explicit close code that runs consistently between Firefox, Chrome and WebKit legacy WebSocket.

• http/tests/websocket/tests/hybi/client-close-2-expected.txt: Added.
• http/tests/websocket/tests/hybi/client-close-2.html: Added.
• http/tests/websocket/tests/hybi/client-close-2_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

9:44 AM Changeset in webkit [265950] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.0-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
​https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

• animations/legacy-encoding-timing-function-expected.txt: Added.
• animations/legacy-encoding-timing-function.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:44 AM Changeset in webkit [265949] by Karl Rackler

• 2 edits in trunk/LayoutTests

Test failing on Rosetta as well as AS - adding test expectation for Rosetta
​https://bugs.webkit.org/show_bug.cgi?id=207150

Unreviewed test gardening.

• platform/mac/TestExpectationsRosetta:

9:35 AM Changeset in webkit [265948] by Alan Coon

• 5 edits in branches/safari-610.1.28.3-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439277

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp: (run):
• b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [265947] by Alan Coon

• 8 edits in branches/safari-610.1.28.3-branch/Source

Versioning.

WebKit-7610.1.28.3.2

9:32 AM Changeset in webkit [265946] by Alan Coon

• 5 edits in branches/safari-610.1.28.2-branch/Source/JavaScriptCore

Revert r265929. rdar://problem/67439277

9:28 AM Changeset in webkit [265945] by Karl Rackler

• 2 edits in trunk/LayoutTests

Four separate reported tests failures: rdar://6453565 rdar://65848157 rdar://66660924 rdar://6684253
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

• platform/mac/TestExpectationsRosetta:

9:22 AM Changeset in webkit [265944] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] fast/scrolling/mac/scrollbars/overlay-scrollbar-hovered.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215700

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:12 AM Changeset in webkit [265943] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://66661355 ([ASi Layout Tests] 3 compositing tests failing with 0.01% diffs)
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

• platform/mac/TestExpectationsRosetta:

7:33 AM Changeset in webkit [265942] by Jonathan Bedard

• 5 edits
  2 adds
  1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Darin Adler and Dewei Zhu.

The Timeout class is a generally useful Python utility, it should not live inside webkitpy.

• Scripts/libraries/webkitcorepy/README.md: Document Timeout object.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Expose Timeout object API, increment version.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/time_.py:

(_MetaTime.enter): Replace timeout.py's ORIGINAL_SLEEP variable to speed up testing.

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/timeout_unittest.py: Added.

(TimeoutTests): Added.

• Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py: Added.

(Timeout): Class representing a stackable Timeout context.
(Timeout.Data): Class containing information about a specific deadline.
(Timeout.Exception): Exception belonging to the Timeout object.
(Timeout.DisableAlarm): For some block of code, disable Timeout alarms. This is useful because many APIs (such as
subprocess.run) define their own timeouts which do better cleanup than an interrupt would.
(Timeout.default_handler): Default Timeout handler which raises an exception.
(Timeout.current): Return the current Timeout.Data class, if one exists.
(Timeout.deadline): Return the closest deadline, if one exists.
(Timeout.difference): Return the number of seconds between the current time and the closest deadline.
(Timeout.check): Check if we have surpassed the closest deadline., raise an exception if we have.
(Timeout.bind): Create a signal based on the closest deadline.
(Timeout.sleep): Override the sleep function because if we ever request a sleep that is greater than the closest deadline,
we should imiediately trigger the timeout logic without waiting for the timeout to actually expire.
(Timeout.init): Create a Timeout context, 1 second by default.
(Timeout.enter):
(Timeout.exit):

• Scripts/webkitpy/common/timeout_context.py:

(Timeout): Moved to webkitcorepy.

6:53 AM Changeset in webkit [265941] by Diego Pino Garcia

• 1 edit
  1 move in trunk/LayoutTests

[GTK] Unreviewed test gardening. Move WPE baseline for collection-iterators.html test to GLIB.

• platform/glib/fast/dom/collection-iterators-expected.txt: Renamed from LayoutTests/platform/wpe/fast/dom/collection-iterators-expected.txt.

6:06 AM Changeset in webkit [265940] by Lauro Moura

• 6 edits in trunk

REGRESSION(r265856) [GTK][WPE] hybi websockets tests failing
​https://bugs.webkit.org/show_bug.cgi?id=215679

Reviewed by Carlos Garcia Campos.

Source/WebKit:

r265856 changed WebSocketChannel to expect AbnormalClosure when the
closing handshake is not received.

Covered by existing tests.

• NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::didFail):

LayoutTests:

Rebaseline and update expectations.

• platform/glib/TestExpectations:
• platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:

3:43 AM Changeset in webkit [265939] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

WebSocketTask::close should correctly compute reason byte size in UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=215645

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/close.html with NSURLSession code path enabled.

• NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::close):
Instead of calling sizeInBytes, we should just get the utf8 CString and gets its size directly.

12:15 AM Changeset in webkit [265938] by Diego Pino Garcia

• 12 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines after r265851.

• platform/gtk/fast/layers/video-layer-expected.txt:
• platform/gtk/media/audio-controls-rendering-expected.txt:
• platform/gtk/media/controls-after-reload-expected.txt:
• platform/gtk/media/controls-strict-expected.txt:
• platform/gtk/media/media-controls-clone-expected.txt:
• platform/gtk/media/video-controls-rendering-expected.txt:
• platform/gtk/media/video-display-toggle-expected.txt:
• platform/gtk/media/video-empty-source-expected.txt:
• platform/gtk/media/video-no-audio-expected.txt:
• platform/gtk/media/video-playing-and-pause-expected.txt:
• platform/gtk/media/video-zoom-controls-expected.txt:

Aug 19, 2020:

11:26 PM Changeset in webkit [265937] by Russell Epstein

• 2 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364266

Fix null pointer crashes in network process after r265835

​​https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:26 PM Changeset in webkit [265936] by Russell Epstein

• 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 PM Changeset in webkit [265935] by Fujii Hironori

• 2 edits in trunk/Source/WebKit

IPC message can't be decoded due to uninitialized NavigationActionData member variables with the latest MSVC
​https://bugs.webkit.org/show_bug.cgi?id=215662

Reviewed by Darin Adler.

WinCairo WebKit2 is crashing in AuxiliaryProcess::didReceiveInvalidMessage
if it is compiled by the latest MSVC (Visual Studio 2019 16.7) with optimizer (/O2).

LockHistory is a bool based enum type. NavigationActionData
doesn't initialize the member variable of it. IPC::Encoder
converts a LockHistory value to the underlying type bool. The
uninitialized value is converted 0 or 1 in GCC, Clang and old
MSVC. However, the latest MSVC doesn't convert and IPC::Decoder
detects an invalid enum value.

• Shared/NavigationActionData.h: Added initializes for userGestureTokenIdentifier, lockHistory and lockBackForwardList.

10:07 PM Changeset in webkit [265934] by ysuzuki@apple.com

• 35 edits
  12 adds in trunk

[JSC] Add Object.getOwnPropertyNames caching as it is done for Object.keys, and accelerate Object.getOwnPropertyDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=215666

Reviewed by Saam Barati.

JSTests:

• microbenchmarks/get-own-property-descriptor.js: Added.

(object.get test):
(object.set test):

• stress/get-own-property-names-bad-time.js: Added.

(shouldBe):
(test):

• stress/get-own-property-names-dfg.js: Added.

(shouldBe):
(test):

• stress/keys-bad-time.js: Added.

(shouldBe):
(test):

• stress/keys-dfg.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-cached-zero.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-changed-attribute.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-changed-index.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-changed.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-indexed-non-cache.js: Added.

(shouldBe):
(test):

• stress/object-get-own-property-names-overrides-get-property-names.js: Added.

(shouldBe):
(test):
(noInline):

• stress/object-keys-cache.js: Added.

(shouldBe):
(symbol):

Source/JavaScriptCore:

Object.getOwnPropertyNames is immutable for Structure if structure meets some conditions. And we have optimization for Object.keys.
This patch wires existing caching mechanism for Object.keys to Object.getOwnPropertyNames so that Object.getOwnPropertyNames has
full support of caching & inlined code in DFG / FTL.

We also pre-bake structure for the result of Object.getOwnPropertyDescriptor so that we do not need to perform hash table lookup every
time we create an object for Object.getOwnPropertyDescriptor. This makes Object.getOwnPropertyDescriptor 2x faster from the microbenchmark.

The above two optimization makes Speedometer2/Inferno-TodoMVC 7% faster, and it also optimizes Speedometer2/EmberJS-Debug by 5%.
In total, we can get 0.7 - 1.0% progression in Speedometer2.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::DFG::SpeculativeJIT::compileObjectKeys): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeys): Deleted.

• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/IteratorOperations.cpp:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::dataPropertyDescriptorObjectStructure const):
(JSC::JSGlobalObject::accessorPropertyDescriptorObjectStructure const):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncOwnKeys):

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::objectConstructorKeys):
(JSC::ownPropertyKeys):
(JSC::constructObjectFromPropertyDescriptorSlow):

• runtime/ObjectConstructor.h:

(JSC::createDataPropertyDescriptorObjectStructure):
(JSC::createAccessorPropertyDescriptorObjectStructure):
(JSC::constructObjectFromPropertyDescriptor):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectOwnKeys):

• runtime/Structure.cpp:

(JSC::Structure::canCachePropertyNameEnumerator const):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::setCachedPropertyNames):
(JSC::Structure::cachedPropertyNames const):
(JSC::Structure::cachedPropertyNamesIgnoringSentinel const):
(JSC::Structure::canCacheOwnPropertyNames const):
(JSC::Structure::setCachedOwnKeys): Deleted.
(JSC::Structure::cachedOwnKeys const): Deleted.
(JSC::Structure::cachedOwnKeysIgnoringSentinel const): Deleted.
(JSC::Structure::canCacheOwnKeys const): Deleted.

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedPropertyNames const):
(JSC::StructureRareData::cachedPropertyNamesIgnoringSentinel const):
(JSC::StructureRareData::cachedPropertyNamesConcurrently const):
(JSC::StructureRareData::setCachedPropertyNames):
(JSC::StructureRareData::cachedOwnKeys const): Deleted.
(JSC::StructureRareData::cachedOwnKeysIgnoringSentinel const): Deleted.
(JSC::StructureRareData::cachedOwnKeysConcurrently const): Deleted.
(JSC::StructureRareData::setCachedOwnKeys): Deleted.

10:00 PM Changeset in webkit [265933] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Improperly linearized PDFs show up as blank gray on Big Sur.
rdar://problem/67117968 and ​https://bugs.webkit.org/show_bug.cgi?id=215683

Reviewed by Darin Adler.

Will add a new test once an in-house expert helps us construct an example PDF that
we will have the legal right to commit.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::threadEntry): When PDFKit indicates a PDFDocument is *improperly* linearized

(as opposed to not linearized at all), we failed to appopriately notify the main thread that
it needs to start handling the PDF.
Failure to create a PDFDocument is equivalent to receiving the "nonlinearized sentinel", so
adding that call fixes this issue.

8:51 PM Changeset in webkit [265932] by Simon Fraser

• 3 edits
  2 adds in trunk

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
​https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

• WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

• animations/legacy-encoding-timing-function-expected.txt: Added.
• animations/legacy-encoding-timing-function.html: Added.

7:50 PM Changeset in webkit [265931] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GTK][WPE] Gardening websocket failures

Unreviewed test gardening.

• platform/glib/TestExpectations:

6:50 PM Changeset in webkit [265930] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix null pointer crashes in network process after r265835

​​https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

6:26 PM Changeset in webkit [265929] by Alan Coon

• 5 edits in branches/safari-610.1.28.2-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439277

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp: (run):
• b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:25 PM Changeset in webkit [265928] by Alan Coon

• 8 edits in branches/safari-610.1.28.2-branch/Source

Versioning.

WebKit-7610.1.28.2.2

6:22 PM Changeset in webkit [265927] by Alan Coon

• 5 edits in branches/safari-610.1.28.1-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439265

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp: (run):
• b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [265926] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.2

6:15 PM Changeset in webkit [265925] by Alan Coon

• 5 edits in branches/safari-610.1.28.0-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439269

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp: (run):
• b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:15 PM Changeset in webkit [265924] by Alan Coon

• 2 edits in branches/safari-610.1.28.0-branch/Source/WebCore

Cherry-pick r265890. rdar://problem/67439260

[iOS] Restore a 10_15_* user-agent string when requesting desktop site
​https://bugs.webkit.org/show_bug.cgi?id=215657
<rdar://problem/67376157>

Reviewed by Tim Horton.

Reporting a major version of 11_0 causes numerous compatibility issues on websites that attempt to parse major
and minor versions from the user agent string. This partially reverts r263970, and replaces the string with
10_15_6, which matches the UA string of the latest shipped macOS version.

• platform/ios/UserAgentIOS.mm: (WebCore::standardUserAgentWithApplicationName):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:15 PM Changeset in webkit [265923] by Alan Coon

• 6 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r265882. rdar://problem/67439284

REGRESSION (r261407): Sharing rich links from Twitter/Netflix via Messages is unreliable
​https://bugs.webkit.org/show_bug.cgi?id=215656
<rdar://problem/67087352>

Reviewed by Tim Horton.

The WKWebView._clientNavigationsRunAtForegroundPriority SPI was not working for the
MessagesViewService because the view is unparented and PageClient::isApplicationVisible()
would not work return accurate results when [view window] returns nil. It is very
unfortunate to have to rely on the view or the view's window to determine application
visibility so this patch fixes this. We now rely on UIKit's visibility endowment to
determine if the UIProcess is visible, using RunningBoard API. I have verified that the
visibility endowment properly gets propagated from the host application to the view
service when the application is a view service and I have verified that this detects
the MessagesViewService as visible for the use-case at <rdar://problem/67087352>, which
causes the WKWebView._clientNavigationsRunAtForegroundPriority SPI to work as intended.

Note that when the application does not have the visibility endowment, we still allow
it to take a foreground assertion for client navigations if the process is allowed to
run in the background for an extended period of time, according to RunningBoard. This
allows the SPI to work for daemons (like maild) which rely on it.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::canTakeForegroundAssertions): (WebKit::PageClientImpl::isApplicationVisible): Deleted.
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::shouldForceForegroundPriorityForClientNavigation const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:12 PM Changeset in webkit [265922] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.2

5:49 PM Changeset in webkit [265921] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 Release ] http/tests/security/contentSecurityPolicy/worker-redirect-allowed.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215676

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

5:45 PM Changeset in webkit [265920] by Alan Coon

• 1 copy in tags/Safari-610.1.28.3.1

Tag Safari-610.1.28.3.1.

5:45 PM Changeset in webkit [265919] by Alan Coon

• 1 copy in tags/Safari-610.1.28.2.1

Tag Safari-610.1.28.2.1.

5:44 PM Changeset in webkit [265918] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.1

Tag Safari-610.1.28.1.1.

5:43 PM Changeset in webkit [265917] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.1

Tag Safari-610.1.28.0.1.

5:39 PM Changeset in webkit [265916] by Kate Cheney

• 30 edits in trunk

Third party domains are not stored in the case of back/forward navigations
​https://bugs.webkit.org/show_bug.cgi?id=215595
<rdar://problem/66642893>

Reviewed by Chris Dumez.

Source/WebCore:

Add a FrameLoaderClient function to store loaded third party
domains in a CachedPage in the case of back/forward navigations.

• history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

• history/CachedPage.h:
• loader/FrameLoaderClient.h:

Source/WebKit:

This patch adds the ability to retrieve loaded third party domains from the page
synchronously to be stored in the CachedPage in the case of a
back/forward navigation.

It also changes the functions loadedThirdPartyDomains and
getLoadedThirdPartyDomains to loadedSubresourceDomains and
getLoadedSubresourceDomains respectively based on the conversation from
​https://bugs.webkit.org/show_bug.cgi?id=215595.

• UIProcess/API/C/WKPage.cpp:

(WKPageLoadedSubresourceDomains):
(WKPageClearLoadedSubresourceDomains):
(WKPageLoadedThirdPartyDomains): Deleted.
(WKPageClearLoadedThirdPartyDomains): Deleted.

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _loadedSubresourceDomainsFor:completionHandler:]):
(-[WKWebsiteDataStore _clearLoadedSubresourceDomainsFor:]):
(-[WKWebsiteDataStore _loadedThirdPartyDomainsFor:completionHandler:]): Deleted.
(-[WKWebsiteDataStore _clearLoadedThirdPartyDomainsFor:]): Deleted.

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getLoadedSubresourceDomains):
(WebKit::WebPageProxy::clearLoadedSubresourceDomains):
(WebKit::WebPageProxy::loadedThirdPartyDomains): Deleted.
(WebKit::WebPageProxy::clearLoadedThirdPartyDomains): Deleted.

• UIProcess/WebPageProxy.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::loadedSubresourceDomains const):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didLoadFromRegistrableDomain):
(WebKit::WebPage::getLoadedSubresourceDomains):
(WebKit::WebPage::clearLoadedSubresourceDomains):
(WebKit::WebPage::loadedThirdPartyDomains): Deleted.
(WebKit::WebPage::clearLoadedThirdPartyDomains): Deleted.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::loadedSubresourceDomains const):

• WebProcess/WebPage/WebPage.messages.in:

Tools:

API test coverage, including a new scheme handler to load third party
domains. Also this patch changes the function name from
loadedThirdPartyDomains to loadedSubresourceDomains based on the
conversation from ​https://bugs.webkit.org/show_bug.cgi?id=215595.

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(-[ResourceLoadStatisticsSchemeHandler webView:startURLSchemeTask:]):
(-[ResourceLoadStatisticsSchemeHandler webView:stopURLSchemeTask:]):
(TEST):

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::loadedSubresourceDomains):
(WTR::TestRunner::callDidReceiveLoadedSubresourceDomainsCallback):
(WTR::TestRunner::loadedThirdPartyDomains): Deleted.
(WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback): Deleted.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::LoadedSubresourceDomainsCallbackContext::LoadedSubresourceDomainsCallbackContext):
(WTR::loadedSubresourceDomainsCallback):
(WTR::TestController::loadedSubresourceDomains):
(WTR::TestController::clearLoadedSubresourceDomains):
(WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext): Deleted.
(WTR::loadedThirdPartyDomainsCallback): Deleted.
(WTR::TestController::loadedThirdPartyDomains): Deleted.
(WTR::TestController::clearLoadedThirdPartyDomains): Deleted.

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveLoadedSubresourceDomains):
(WTR::TestInvocation::didReceiveLoadedThirdPartyDomains): Deleted.

• WebKitTestRunner/TestInvocation.h:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::loadedSubresourceDomains):
(WTR::TestController::clearLoadedSubresourceDomains):
(WTR::TestController::loadedThirdPartyDomains): Deleted.
(WTR::TestController::clearLoadedThirdPartyDomains): Deleted.

LayoutTests:

Updated layout tests to use the new function name.

• http/tests/resourceLoadStatistics/loaded-registrable-domains-get-reported.html:
• http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html:

5:31 PM Changeset in webkit [265915] by Alan Coon

• 1 copy in tags/Safari-610.1.26.1

Tag Safari-610.1.26.1.

5:30 PM Changeset in webkit [265914] by Alan Coon

• 4 edits in branches/safari-610.1.28.0-branch

Revert r265878. rdar://problem/67364266

5:28 PM Changeset in webkit [265913] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
​https://bugs.webkit.org/show_bug.cgi?id=215667
<rdar://problem/67103788>

Unreviewed test gardening.

• platform/ios/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:

5:27 PM Changeset in webkit [265912] by Alan Coon

• 4 edits in branches/safari-610.1.26-branch

Revert r265900. rdar://problem/67364266

5:25 PM Changeset in webkit [265911] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

Update fast/selectors/lang-dynamic.html after r265487
​https://bugs.webkit.org/show_bug.cgi?id=215665
<rdar://problem/67083106>

Unreviewed test gardening.

• fast/selectors/lang-dynamic-expected.html:

5:22 PM Changeset in webkit [265910] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://65269589 ([ macOS and iOS ] media/vp9.html is failing consistently.)
Add exception of BigSur wk2 only to run test for macOS

Unreviewed test gardening

• platform/mac-wk2/TestExpectations:

5:16 PM Changeset in webkit [265909] by Karl Rackler

• 3 edits in trunk/LayoutTests

rdar://65269589 ([ macOS and iOS ] media/vp9.html is failing consistently.)
Change test expectation to skip macOS with the exception of BigSur wk2

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:56 PM Changeset in webkit [265908] by Chris Dumez

• 18 edits in trunk

Blob is missing text() & arrayBuffer() operations
​https://bugs.webkit.org/show_bug.cgi?id=215663

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/blob/Blob-array-buffer.any-expected.txt:
• web-platform-tests/FileAPI/blob/Blob-array-buffer.any.worker-expected.txt:
• web-platform-tests/FileAPI/blob/Blob-text.any-expected.txt:
• web-platform-tests/FileAPI/blob/Blob-text.any.worker-expected.txt:
• web-platform-tests/FileAPI/idlharness-expected.txt:
• web-platform-tests/FileAPI/idlharness.worker-expected.txt:

Source/WebCore:

Implementation support for Blob.text() & Blob.arrayBuffer() as per specification:

• ​https://w3c.github.io/FileAPI/#blob-section

The implementation relies on the pre-existing BlobLoader class but the following
changes were made:

• Stop calling start() in the BlobLoader constructor and have the caller call start() explicitly after constructing the BlobLoader. This is important because the load may fail synchronously in some cases.
• Add support for reading Blob as text. Previously, BlobLoader would only support reading the blob as an ArrayBuffer.
• Use a CompletionHandler instead of a Function and make sure that it is always called.

No new tests, rebaselined existing tests.

• fileapi/Blob.cpp:

(WebCore::Blob::~Blob):
(WebCore::Blob::loadBlob):
(WebCore::Blob::text):
(WebCore::Blob::arrayBuffer):

• fileapi/Blob.h:
• fileapi/Blob.idl:
• fileapi/BlobLoader.h:

(WebCore::BlobLoader::BlobLoader):
(WebCore::BlobLoader::~BlobLoader):
(WebCore::BlobLoader::cancel):
(WebCore::BlobLoader::start):
(WebCore::BlobLoader::didFinishLoading):
(WebCore::BlobLoader::didFail):
(WebCore::BlobLoader::complete): Deleted.

• fileapi/NetworkSendQueue.cpp:

(WebCore::NetworkSendQueue::enqueue):
(WebCore::NetworkSendQueue::clear):
(WebCore::NetworkSendQueue::processMessages):

• page/ShareDataReader.cpp:

(WebCore::ShareDataReader::start):
(WebCore::ShareDataReader::didFinishLoading):
(WebCore::ShareDataReader::cancel):

4:25 PM Changeset in webkit [265907] by Alexey Shvayka

• 55 edits
  6 adds in trunk

Introduce OpIsCallable bytecode and intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=215572

Reviewed by Ross Kirsling and Saam Barati.

JSTests:

• stress/type-of-functions-and-objects.js:
• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch:

1. Aligns slow_path_is_function with DFG/FTL implementations by introducing jsTypeofIsFunction() helper. This fixes typeof document.all === "function" to return false instead of true.

2. Renames is_function bytecode op to typeof_is_function, aligning it with typeof_is_undefined and typeof_is_object. New name offers better semantics and clearly communicates the op should be avoided when implementing new features because of typeof behavior with IsHTMLDDA? objects [1].

3. Adds is_callable bytecode op and utilizes it in built-ins via intrinsic, removing typeof callback === "function" checks. This prevents IsHTMLDDA? objects from being considered non-callable [2].

To preserve the fast path for JSFunctionType,
createFunctionThatMasqueradesAsUndefined() is relocated to InternalFunction.

typeof microbenchmarks are neutral.

[1]: ​https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot-typeof
[2]: ​https://tc39.es/ecma262/#sec-array.prototype.map (step 3)

• builtins/ArrayConstructor.js:
• builtins/ArrayPrototype.js:

(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(find):
(findIndex):
(sort):
(flatMap):

• builtins/FunctionPrototype.js:

(overriddenName.string_appeared_here.symbolHasInstance):
(bind):

• builtins/MapPrototype.js:

(forEach):

• builtins/PromiseConstructor.js:

(all):
(allSettled):
(any):
(race):
(nakedConstructor.Promise):
(nakedConstructor.InternalPromise):

• builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.resolvePromise):
(globalPrivate.resolveWithoutPromise):

• builtins/PromisePrototype.js:

(finally):
(globalPrivate.getThenFinally):
(globalPrivate.getCatchFinally):

• builtins/ReflectObject.js:

(apply):

• builtins/RegExpPrototype.js:

(globalPrivate.regExpExec):
(overriddenName.string_appeared_here.replace):

• builtins/SetPrototype.js:

(forEach):

• builtins/TypedArrayConstructor.js:
• builtins/TypedArrayPrototype.js:

(every):
(find):
(findIndex):
(forEach):
(some):
(sort):
(reduce):
(reduceRight):
(map):
(filter):

• bytecode/BytecodeIntrinsicRegistry.h:
• bytecode/BytecodeList.rb:
• bytecode/BytecodeUseDef.cpp:

(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOpImpl):
(JSC::BytecodeGenerator::emitIsCallable):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:
• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIsCallable):
(JSC::DFG::SpeculativeJIT::compileIsFunction): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsCallable):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction): Deleted.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JITOperations.h:
• jsc.cpp:

(functionMakeMasquerader):

• llint/LowLevelInterpreter.asm:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

• runtime/InternalFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::createFunctionThatMasqueradesAsUndefined): Deleted.

• runtime/JSFunction.h:
• runtime/Operations.h:

(JSC::jsTypeofIsFunction):

Source/WebCore:

No new tests, no behavior change.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase const):

LayoutTests:

• js/dom/document-all-is-callable-builtins-expected.txt: Added.
• js/dom/document-all-is-callable-builtins.html: Added.
• js/dom/document-all-typeof-is-function-fold-expected.txt: Added.
• js/dom/document-all-typeof-is-function-fold.html: Added.
• js/dom/script-tests/document-all-is-callable-builtins.js: Added.
• js/dom/script-tests/document-all-typeof-is-function-fold.js: Added.

4:24 PM Changeset in webkit [265906] by Chris Dumez

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform.html

• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

3:44 PM Changeset in webkit [265905] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.3

3:36 PM Changeset in webkit [265904] by Peng Liu

• 7 edits
  2 adds in trunk

A PiP window is closed when the video element is removed from DOM
​https://bugs.webkit.org/show_bug.cgi?id=215594

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/remove-video-element-in-pip-from-document.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::pauseAfterDetachedTask):
When a video is playing in the picture-in-picture mode, do not pause it or exit the
picture-in-picture mode when detaching the video element from the DOM.
(WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
Always return true when the video is playing in the picture-in-picture mode.

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::willBeDestroyed):
Don't hide the player when destroying the renderer of an inline video.

LayoutTests:

• TestExpectations:
• media/remove-video-element-in-pip-from-document-expected.txt: Added.
• media/remove-video-element-in-pip-from-document.html: Added.
• platform/ipad/TestExpectations:
• platform/mac-wk2/TestExpectations:

3:35 PM Changeset in webkit [265903] by Russell Epstein

• 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r265792. rdar://problem/67420555

Assert failure after r265715
​https://bugs.webkit.org/show_bug.cgi?id=215592

Reviewed by Darin Adler.

The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. This
happens because after r265715 the new XPC event handler set in AuthenticationManager::initializeConnection,
will no longer be called on the main thread. This patch addresses this issue by dispatching this work on
the main thread.

No new tests, covered by existing tests.

• Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: (WebKit::AuthenticationManager::initializeConnection):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:35 PM Changeset in webkit [265902] by Russell Epstein

• 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r265761. rdar://problem/67420550

[Mac] Add Experimental Feature preference for SW VP9
​https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Darin Adler.

Follow up fix: during a rebase, a line deletion was dropped which causes the SW decoder to
always be registered regardless of the new setting.

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::enableVP9Decoder): (WebKit::WebProcess::enableVP9SWDecoder):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:55 PM Changeset in webkit [265901] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.26-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:55 PM Changeset in webkit [265900] by Alan Coon

• 4 edits in branches/safari-610.1.26-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:53 PM Changeset in webkit [265899] by Alan Coon

• 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.1

2:40 PM Changeset in webkit [265898] by Russell Epstein

• 1 copy in branches/safari-610.1.26-branch

New branch.

2:30 PM Changeset in webkit [265897] by Russell Epstein

• 4 edits in branches/safari-610.1.25.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:29 PM Changeset in webkit [265896] by Russell Epstein

• 3 edits
  2 adds in branches/safari-610.1.25.0-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:26 PM Changeset in webkit [265895] by Russell Epstein

• 8 edits in branches/safari-610.1.25.0-branch/Source

Versioning.

WebKit-7610.1.25.0.3

2:15 PM Changeset in webkit [265894] by Russell Epstein

• 3 edits
  2 adds in branches/safari-610.1.28.0-branch

Cherry-pick r265881. rdar://problem/67423220

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:57 PM Changeset in webkit [265893] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r265775): DFG ASSERTION FAILED: AI-clobberize disagreement; AI says FoldedClobber while clobberize says (Direct:[], Super:[])
​https://bugs.webkit.org/show_bug.cgi?id=215639
<rdar://problem/67376432>

Reviewed by Robin Morisset.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

12:49 PM Changeset in webkit [265892] by Alan Coon

• 1 copy in branches/safari-610.2.2-branch

New branch.

12:46 PM Changeset in webkit [265891] by Tadeu Zagallo

• 5 edits in trunk/Source/JavaScriptCore

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

• b3/B3ReduceStrength.cpp:
• b3/testb3.h:
• b3/testb3_1.cpp:

(run):

• b3/testb3_5.cpp:

(testCheckSubBitAnd):

12:44 PM Changeset in webkit [265890] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

[iOS] Restore a 10_15_* user-agent string when requesting desktop site
​https://bugs.webkit.org/show_bug.cgi?id=215657
<rdar://problem/67376157>

Reviewed by Tim Horton.

Reporting a major version of 11_0 causes numerous compatibility issues on websites that attempt to parse major
and minor versions from the user agent string. This partially reverts r263970, and replaces the string with
10_15_6, which matches the UA string of the latest shipped macOS version.

• platform/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName):

12:19 PM Changeset in webkit [265889] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] svg/custom/object-sizing-no-width-height.xhtml is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215658

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:10 PM Changeset in webkit [265888] by Chris Dumez

• 3 edits in trunk/LayoutTests

Mark 3 webaudio WPT tests as flaky instead of consistently failing.

Those tests are for WebAudio automation, which we do not support. The values being printed
on failure sometimes differ.

• TestExpectations:
• platform/mac/TestExpectationsRosetta:

12:03 PM Changeset in webkit [265887] by Alan Coon

• 7 edits in branches/safari-610.1.28.3-branch

Apply patch. rdar://problem/67415363

11:59 AM Changeset in webkit [265886] by Alan Coon

• 8 edits in branches/safari-610.1.28.3-branch/Source

Versioning.

WebKit-7610.1.28.3.1

11:47 AM Changeset in webkit [265885] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitcorepy] Failure to set index should not be fatal
​https://bugs.webkit.org/show_bug.cgi?id=215653
<rdar://problem/67410416>

Reviewed by Stephanie Lewis.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py:
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.set_index): By default, log an error instead of raising an exception if an index is unreachable.

11:36 AM Changeset in webkit [265884] by Alan Coon

• 1 copy in branches/safari-610.1.28.3-branch

New branch.

11:35 AM Changeset in webkit [265883] by Jonathan Bedard

• 70 edits
  2 deletes in trunk/Tools

[webkitpy] Adopt webkitcorepy's OutputCapture
​https://bugs.webkit.org/show_bug.cgi?id=215628
<rdar://problem/67353710>

Reviewed by Dewei Zhu.

Remove webkitpy's OutputCapture in favor of webkitcorepy's. The refactor retains the orginal
functionality of the old OutputCapture, but deletes some now unused code.

• Scripts/webkitpy/common/checkout/checkout_unittest.py:
• Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
• Scripts/webkitpy/common/net/credentials_unittest.py:
• Scripts/webkitpy/common/net/ewsserver_unittest.py:
• Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
• Scripts/webkitpy/common/net/layouttestresults_unittest.py:
• Scripts/webkitpy/common/system/outputcapture.py: Removed.
• Scripts/webkitpy/common/system/outputcapture_unittest.py: Removed.
• Scripts/webkitpy/common/system/stack_utils_unittest.py:
• Scripts/webkitpy/common/system/user_unittest.py:
• Scripts/webkitpy/common/system/workspace_unittest.py:
• Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
• Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
• Scripts/webkitpy/performance_tests/perftest_unittest.py:
• Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
• Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
• Scripts/webkitpy/port/base_unittest.py:
• Scripts/webkitpy/port/config_unittest.py:
• Scripts/webkitpy/port/darwin_testcase.py:
• Scripts/webkitpy/port/gtk_unittest.py:
• Scripts/webkitpy/port/ios_device_unittest.py:
• Scripts/webkitpy/port/ios_simulator_unittest.py:
• Scripts/webkitpy/port/leakdetector_unittest.py:
• Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
• Scripts/webkitpy/port/mac_unittest.py:
• Scripts/webkitpy/port/port_testcase.py:
• Scripts/webkitpy/port/server_process_unittest.py:
• Scripts/webkitpy/port/watch_simulator_unittest.py:
• Scripts/webkitpy/port/westondriver_unittest.py:
• Scripts/webkitpy/port/win_unittest.py:
• Scripts/webkitpy/port/wpe_unittest.py:
• Scripts/webkitpy/port/xvfbdriver_unittest.py:
• Scripts/webkitpy/style/checkers/python.py:
• Scripts/webkitpy/style/main_unittest.py:
• Scripts/webkitpy/test/finder_unittest.py:
• Scripts/webkitpy/test/main_unittest.py:
• Scripts/webkitpy/test/printer.py:
• Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
• Scripts/webkitpy/tool/bot/irc_command_unittest.py:
• Scripts/webkitpy/tool/bot/ircbot_unittest.py:
• Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
• Scripts/webkitpy/tool/bot/queueengine_unittest.py:
• Scripts/webkitpy/tool/bot/sheriff_unittest.py:
• Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
• Scripts/webkitpy/tool/commands/commandtest.py:
• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
• Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
• Scripts/webkitpy/tool/commands/queries_unittest.py:
• Scripts/webkitpy/tool/commands/queues_unittest.py:
• Scripts/webkitpy/tool/commands/queuestest.py:
• Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
• Scripts/webkitpy/tool/multicommandtool_unittest.py:
• Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
• Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
• Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
• Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
• Scripts/webkitpy/tool/steps/commit_unittest.py:
• Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
• Scripts/webkitpy/tool/steps/runtests_unittest.py:
• Scripts/webkitpy/tool/steps/steps_unittest.py:
• Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
• Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
• Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
• Scripts/webkitpy/w3c/test_converter_unittest.py:
• Scripts/webkitpy/w3c/test_importer_unittest.py:
• Scripts/webkitpy/w3c/test_parser_unittest.py:

11:33 AM Changeset in webkit [265882] by Chris Dumez

• 6 edits in trunk/Source/WebKit

REGRESSION (r261407): Sharing rich links from Twitter/Netflix via Messages is unreliable
​https://bugs.webkit.org/show_bug.cgi?id=215656
<rdar://problem/67087352>

Reviewed by Tim Horton.

The WKWebView._clientNavigationsRunAtForegroundPriority SPI was not working for the
MessagesViewService because the view is unparented and PageClient::isApplicationVisible()
would not work return accurate results when [view window] returns nil. It is very
unfortunate to have to rely on the view or the view's window to determine application
visibility so this patch fixes this. We now rely on UIKit's visibility endowment to
determine if the UIProcess is visible, using RunningBoard API. I have verified that the
visibility endowment properly gets propagated from the host application to the view
service when the application is a view service and I have verified that this detects
the MessagesViewService as visible for the use-case at <rdar://problem/67087352>, which
causes the WKWebView._clientNavigationsRunAtForegroundPriority SPI to work as intended.

Note that when the application does not have the visibility endowment, we still allow
it to take a foreground assertion for client navigations if the process is allowed to
run in the background for an extended period of time, according to RunningBoard. This
allows the SPI to work for daemons (like maild) which rely on it.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):

• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::canTakeForegroundAssertions):
(WebKit::PageClientImpl::isApplicationVisible): Deleted.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::shouldForceForegroundPriorityForClientNavigation const):

11:14 AM Changeset in webkit [265881] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

11:07 AM Changeset in webkit [265880] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitcorepy] Don't overwrite foreign packages by default
​https://bugs.webkit.org/show_bug.cgi?id=215654
<rdar://problem/67411393>

Reviewed by Darin Adler.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.is_cached): Consider a package cached if it is foreign and overwrite_foreign_packages is false.
(AutoInstall): Add overwrite_foreign_packages flag.

10:28 AM Changeset in webkit [265879] by Alan Coon

• 7 edits in branches/safari-610.1.28.0-branch

Apply patch. rdar://problem/67364254

10:28 AM Changeset in webkit [265878] by Alan Coon

• 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:28 AM Changeset in webkit [265877] by Alan Coon

• 4 edits in branches/safari-610.1.28.0-branch

Cherry-pick r265812. rdar://problem/67364276

The CSS specificity of :host() pseudo-classes is wrong
​https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

​https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

• css/CSSSelector.cpp: (WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

• TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:26 AM Changeset in webkit [265876] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitcorepy] Correct autoinstaller logging
​https://bugs.webkit.org/show_bug.cgi?id=215650
<rdar://problem/67408049>

Reviewed by Stephanie Lewis.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Log "Downloading" insteading of "Installing" before downloading a package.

10:23 AM Changeset in webkit [265875] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.1

10:21 AM Changeset in webkit [265874] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.1

10:17 AM Changeset in webkit [265873] by Alan Coon

• 7 edits in branches/safari-610.1.28.1-branch

Apply patch. rdar://problem/67370822

10:17 AM Changeset in webkit [265872] by Alan Coon

• 4 edits in branches/safari-610.1.28.1-branch

Cherry-pick r265835. rdar://problem/67364262

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:17 AM Changeset in webkit [265871] by Alan Coon

• 4 edits in branches/safari-610.1.28.1-branch

Cherry-pick r265812. rdar://problem/67364273

The CSS specificity of :host() pseudo-classes is wrong
​https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

​https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

• css/CSSSelector.cpp: (WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

• TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:13 AM Changeset in webkit [265870] by Aditya Keerthi

• 2 edits in trunk/Source/WebCore

Remove use of ControlSize in ThemeMac
​https://bugs.webkit.org/show_bug.cgi?id=215651

Reviewed by Sam Weinig.

ThemeMac contains incorrectly mixes the use of Carbon's ControlSize
and AppKit's NSControlSize. This inconsistency went unnoticed as
ControlSize is a UInt16, and NSControlSize is an NSUInteger.

No new tests as there is no change in behavior.

• platform/mac/ThemeMac.mm:

(WebCore::controlSizeFromPixelSize):

This method always returns an NSControlSize, but it's declared return
type is a ControlSize. Correct the declared return type.

(WebCore::setControlSize):
(WebCore::paintStepper):
(WebCore::ThemeMac::inflateControlPaintRect const):

10:07 AM Changeset in webkit [265869] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests/imported/w3c

Implement PerfomanceObserverInit.buffered
​https://bugs.webkit.org/show_bug.cgi?id=214883

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-19
Reviewed by Darin Adler.

Sync case-sensitivity.any.js which was upstreamed to WPT
a bit differently than in r265390 and specifically managed to
use one timeout instead of multiple, making it a faster test.

• web-platform-tests/performance-timeline/case-sensitivity.any-expected.txt:
• web-platform-tests/performance-timeline/case-sensitivity.any.js:

(async_test):

• web-platform-tests/performance-timeline/case-sensitivity.any.worker-expected.txt:

10:07 AM Changeset in webkit [265868] by Alan Coon

• 7 edits in branches/safari-610.1.28.2-branch

Apply patch. rdar://problem/67373871

9:59 AM Changeset in webkit [265867] by Alan Coon

• 8 edits in branches/safari-610.1.28.2-branch/Source

Versioning.

WebKit-7610.1.28.2.1

9:55 AM Changeset in webkit [265866] by Jonathan Bedard

• 10 edits in trunk/Tools

[webkitpy] Use webkitcorepy's auto installer for selenium
​https://bugs.webkit.org/show_bug.cgi?id=215648
<rdar://problem/67405967>

Reviewed by Darin Adler.

• Scripts/webkitpy/init.py:
• Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver): Implicitly use webkitcorepy's auto-installer.

• Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver): Ditto.

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver): Ditto.
(OSXChromeCanaryDriver.launch_driver): Ditto.

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver): Ditto.
(OSXFirefoxNightlyDriver.launch_driver): Ditto.

• Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver): Ditto.

• Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test): Ditto.

• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove selenium.
(AutoinstallImportHook._install_selenium): Deleted.

• Scripts/webkitpy/webdriver_plt/liveplt.py: Implicitly use webkitcorepy's auto-installer.

9:30 AM Changeset in webkit [265865] by Alan Coon

• 1 copy in branches/safari-610.1.28.2-branch

New branch.

9:30 AM Changeset in webkit [265864] by Alan Coon

• 1 copy in branches/safari-610.1.28.1-branch

New branch.

9:30 AM Changeset in webkit [265863] by Alan Coon

• 1 copy in branches/safari-610.1.28.0-branch

New branch.

9:20 AM Changeset in webkit [265862] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] accessibility/mac/select-element-selection-with-optgroups.html is a flaky failure

​https://bugs.webkit.org/show_bug.cgi?id=215649

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:11 AM Changeset in webkit [265861] by Karl Rackler

• 3 edits in trunk/LayoutTests

rdar://problem/65269589 [ Mac and iOS ] media/vp9.html is failing consistently.
Moved test expectation from only mac wk1 to mac.

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:
• platform/mac/TestExpectations:

9:03 AM Changeset in webkit [265860] by Aditya Keerthi

• 7 edits
  2 adds in trunk

[macOS] Move stepper painting code off of Carbon API
​https://bugs.webkit.org/show_bug.cgi?id=215619
<rdar://problem/41936617>

Reviewed by Darin Adler.

Source/WebCore:

Use CoreUI and AppKit SPI to paint steppers. There are two benefits to
this new approach.

1. The stepper now has an appropriate appearance in dark mode.

2. We move away from using the outdated Carbon API.

Note that we still cannot use NSStepperCell to paint steppers, since it
is not possible to draw one with the up button highlighted. However, the
approach used in this patch is shared by NSStepperCell.

Test: fast/forms/number/number-dark-appearance.html

• platform/mac/ThemeMac.mm:

(WebCore::paintStepper):

Source/WebCore/PAL:

Add forward declarations for CoreUI SPI on non-internal SDKs.

Also grouped declarations by key and value pairs.

• pal/spi/mac/CoreUISPI.h:

LayoutTests:

Added a test to verify that the stepper appearance is different under dark mode.

• TestExpectations:
• fast/forms/number/number-dark-appearance-expected-mismatch.html: Added.
• fast/forms/number/number-dark-appearance.html: Added.
• platform/mac/TestExpectations:

8:50 AM Changeset in webkit [265859] by Lauro Moura

• 2 edits in trunk/Source/WebCore

[WebXR] Remove uneeded assert

Rubber-stamped by Sergio Villar Senin

context being a Document is tracked by the downcast when capturing.
Fixes debug build error complaining about not capturing context.

Covered by existing tests.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::requestReferenceSpace):

8:44 AM Changeset in webkit [265858] by svillar@igalia.com

• 4 edits in trunk

[css-flexbox] min-height:auto not updated after an image loads when the image has a specified height and width.
​https://bugs.webkit.org/show_bug.cgi?id=210475

Reviewed by Javier Fernandez.

Source/WebCore:

The flex layout algorithm needs the item's intrinsic size even if it has a specified size, that's
why the flex item size should be recomputed in the event of changes in its intrinsic size.

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange): set the needs layout flag
also for replaced elements which happen to be flex items.

LayoutTests:

• TestExpectations: Removed two tests that are passing now.

8:39 AM Changeset in webkit [265857] by achristensen@apple.com

• 2 edits in trunk/Tools

[Catalina/iOS 13] TestWebKitAPI.TLSVersion.LegacySubresources is failing
​https://bugs.webkit.org/show_bug.cgi?id=215640

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

This tests behavior using CFNetwork functionality which is only available to Big Sur, iOS 14, and updated versions of Catalina.

8:39 AM Changeset in webkit [265856] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

WebSocketChannel::didClose should correctly compute whether a closing handshake was received
​https://bugs.webkit.org/show_bug.cgi?id=215644

Reviewed by Darin Adler.

Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.

• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::didClose):
As noted by Jiten Mehta, absence of closing handshake from the server is notified by WebSocketChannel::CloseEventCodeAbnormalClosure.
Update check accordingly.

8:34 AM Changeset in webkit [265855] by svillar@igalia.com

• 4 edits in trunk

[css-flexbox] Apply aspect ratios when computing flex-basis
​https://bugs.webkit.org/show_bug.cgi?id=215570

Reviewed by Javier Fernandez.

Source/WebCore:

Aspect ratios (clamped by min/max restrictions) should be considered when computing flex-basis.

Based on Blink's crrev.com/c/1525444 & crrev.com/c/1672014 by <​cbiesinger@chromium.org>

• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):

LayoutTests:

• TestExpectations: Removed a test that is passing now.

8:02 AM Changeset in webkit [265854] by youenn@apple.com

• 8 edits
  2 adds in trunk

Optimise resolution of promises with values in ReadableStream implementation
​https://bugs.webkit.org/show_bug.cgi?id=215557
<rdar://problem/66828616>

Reviewed by Yusuke Suzuki.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-stream-with-broken-then.any-expected.txt:
• web-platform-tests/fetch/api/response/response-stream-with-broken-then.any.worker-expected.txt:

Remaining test failure will be handled as part of pipeTo algorithm refresh.

Source/WebCore:

Instead of going through the slow @Promise.@resolve, we can directly use @fulfillPromise which is faster.
To make things consistent, we move from @newPromiseCapability to @newPromise.
Test: streams/readableStream-then.html

• Modules/streams/ReadableByteStreamInternals.js:

(readableByteStreamControllerPull):
(readableStreamFulfillReadIntoRequest):
(readableByteStreamControllerPullInto):

• Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerPull):
(readableStreamClose):
(readableStreamFulfillReadRequest):
(readableStreamDefaultReaderRead):

• Modules/streams/StreamInternals.js:

(createFulfilledPromise):

LayoutTests:

• streams/readableStream-then-expected.txt: Added.
• streams/readableStream-then.html: Added.

7:54 AM Changeset in webkit [265853] by Karl Rackler

• 4 edits in trunk/LayoutTests

rdar://67353771 ([run-webkit-tests] Rosetta specific test expectations)
Placing original test expectations back in place and adding Rosetta specific expectations

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

7:46 AM Changeset in webkit [265852] by Lauro Moura

• 7 edits
  1 delete in trunk/LayoutTests

[WPE] Gardening and rebaseline touch tests

Unreviewed test gardening.

LayoutTests/imported/w3c:

Move some WPE-specific baselines here as it is only tested there.

Also rebaseline after r265749 updated some constructor rules.

• web-platform-tests/touch-events/historical-expected.txt:
• web-platform-tests/touch-events/idlharness.window-expected.txt:
• web-platform-tests/touch-events/touch-retargeting-expected.txt:
• web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt:

LayoutTests:

Updated some baselines in the toplevel directory as only WPE is
running them.

• platform/glib/TestExpectations:
• platform/wpe/imported/w3c/web-platform-tests/touch-events/historical-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/touch-events/idlharness.window-expected.txt: Removed.

6:33 AM Changeset in webkit [265851] by svillar@igalia.com

• 6 edits
  6 deletes in trunk

<button> should support display:inline-grid/grid/inline-flex/flex correctly
​https://bugs.webkit.org/show_bug.cgi?id=209656

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Replaced FAIL expectation by PASS one. Both tests should pass now with no failures.

• web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt:
• web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt:

Source/WebCore:

Button elements with display type (inline-) flex or grid should be laid out as their
display type states and not as buttons. That's mentioned in the HTML spec here
​https://html.spec.whatwg.org/multipage/rendering.html#button-layout.

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::createElementRenderer): let HTMLFormControlElement create
a renderer instead of using a RenderButton whenever display is (inline-)grid/flex.

LayoutTests:

• platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
• platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/flex-expected.txt: Removed.
• platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/grid-expected.txt: Removed.

6:11 AM Changeset in webkit [265850] by svillar@igalia.com

• 5 edits in trunk/Source/WebCore

[WebXR] Make "in parallel" code run really in parallel
​https://bugs.webkit.org/show_bug.cgi?id=215642

Reviewed by Carlos Garcia Campos.

As the HTML spec mentions ​https://html.spec.whatwg.org/multipage/infrastructure.html#in-parallel
"in parallel" means that the task should be run in parallel to the event loop using any available
mechanism (threads, processess...). We were instead queueing those tasks to be run in the main
thread causing freezes while initializing the whole OpenXR machinery.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::WebXRSession): create a WorkQueue.
(WebCore::WebXRSession::requestReferenceSpace): Dispatch to the work queue.

• Modules/webxr/WebXRSession.h:
• Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::WebXRSystem): create a WorkQueue.
(WebCore::WebXRSystem::isSessionSupported): Dispatch to the work queue.
(WebCore::WebXRSystem::requestSession): Ditto.

• Modules/webxr/WebXRSystem.h:

2:12 AM Changeset in webkit [265849] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Skip more tests using plugins after r265753.

• platform/gtk/TestExpectations:

Aug 18, 2020:

9:03 PM Changeset in webkit [265848] by Lauro Moura

• 4 edits in trunk/LayoutTests

[GTK][WPE] Gardening

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/wpe/TestExpectations:
• platform/wpe/webgl/1.0.3/conformance/context/methods-expected.txt:

Rebaselined after r265711.

8:15 PM Changeset in webkit [265847] by Hector Lopez

• 6 edits in trunk/LayoutTests

[ macOS iOS ] fast/text/emoji-gender* text expectations change
​https://bugs.webkit.org/show_bug.cgi?id=215636

Unreviewed test gardening.

• TestExpectations:
• platform/glib/TestExpectations:
• platform/ios-wk1/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

7:34 PM Changeset in webkit [265846] by Jonathan Bedard

• 5 edits
  1 add in trunk

[run-webkit-tests] Rosetta specific test expectations
​https://bugs.webkit.org/show_bug.cgi?id=215633
<rdar://problem/67353771>

Reviewed by Darin Adler.

Tools:

• Scripts/webkitpy/port/mac.py:

(MacPort.expectations_dict): Add special case for Rosetta expectations.

• Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_rosetta_expectations):

LayoutTests:

• platform/mac/TestExpectations: Move Rosetta expectations.
• platform/mac/TestExpectationsRosetta: Added.

7:24 PM Changeset in webkit [265845] by Chris Dumez

• 5 edits in trunk

AudioBuffer.duration should use double precision
​https://bugs.webkit.org/show_bug.cgi?id=215632

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-expected.txt:

Source/WebCore:

AudioBuffer.duration should use double precision:

• ​https://www.w3.org/TR/webaudio/#AudioBuffer

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBuffer.h:

(WebCore::AudioBuffer::duration const):

• Modules/webaudio/AudioBuffer.idl:

6:28 PM Changeset in webkit [265844] by rniwa@webkit.org

• 5 edits in trunk/Source/WebCore

Rename replaceAllChildren to replaceAllChildrenWithNewText
​https://bugs.webkit.org/show_bug.cgi?id=215634

Reviewed by Darin Adler.

Renamed ContainerNode::replaceAllChildren to replaceAllChildrenWithNewText and changed
the type of Argument from Ref<Node>&& to const String&.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):

• dom/ContainerNode.h:
• dom/Node.cpp:

(WebCore::Node::setTextContent):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

5:59 PM Changeset in webkit [265843] by Alan Coon

• 1 copy in tags/Safari-610.1.28

Tag Safari-610.1.28.

5:54 PM Changeset in webkit [265842] by Andres Gonzalez

• 12 edits in trunk

Fix for accessibility/mac/aria-expanded-notifications.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=215613

Reviewed by Darin Adler.

Source/WebCore:

Test: accessibility/mac/aria-expanded-notifications.html.

Refactored AXObjectCache::handleAriaExpandedChange so that it doesn't
call into AccessibilityObject to handle the notification, to then call
into AXObjectCache again. The new implementation is cleaner and more
straightforward.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::updateIsolatedTree): Updates the isolated tree
on the row expanded/collapsed-related notifications.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsRowCountChange const): Added.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
Deleted, not needed any longer since it is handled in AXObjectCache where
it should.

• accessibility/AccessibilityRenderObject.h:
• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): Caches the
supportsRowCountChange property.
(WebCore::AXIsolatedObject::handleAriaExpandedChanged): Deleted, not
needed any longer.

• accessibility/isolatedtree/AXIsolatedObject.h:

LayoutTests:

• accessibility/mac/aria-expanded-notifications-expected.txt:
• accessibility/mac/aria-expanded-notifications.html: Removed unnecessary

call to accessibilityController.focusedElement. Some code cleanup.

4:49 PM Changeset in webkit [265841] by commit-queue@webkit.org

• 33 edits in trunk

[WebGL2] Various parameters should be non-nullable in IDL
​https://bugs.webkit.org/show_bug.cgi?id=215616

Patch by James Darpinian <James Darpinian> on 2020-08-18
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes 5 conformance tests:
conformance/misc/error-reporting.html
conformance/misc/null-object-behaviour.html
conformance/misc/bad-arguments-test.html
conformance/textures/misc/tex-sub-image-2d-bad-args.html
conformance/programs/get-active-test.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::bindAttribLocation):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::detachShader):
(WebCore::WebGLRenderingContextBase::getActiveAttrib):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
(WebCore::WebGLRenderingContextBase::getAttribLocation):
(WebCore::WebGLRenderingContextBase::getProgramParameter):
(WebCore::WebGLRenderingContextBase::getProgramInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderParameter):
(WebCore::WebGLRenderingContextBase::getShaderInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderSource):
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::shaderSource):
(WebCore::WebGLRenderingContextBase::validateProgram):

• html/canvas/WebGLRenderingContextBase.h:
• html/canvas/WebGLRenderingContextBase.idl:
• inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::updateShader):

LayoutTests:

• fast/canvas/webgl/context-lost-expected.txt:
• fast/canvas/webgl/context-lost.html:
• fast/canvas/webgl/error-reporting-expected.txt:
• fast/canvas/webgl/error-reporting.html:
• fast/canvas/webgl/get-active-test-expected.txt:
• fast/canvas/webgl/get-active-test.html:
• fast/canvas/webgl/gl-object-get-calls-expected.txt:
• fast/canvas/webgl/gl-object-get-calls.html:
• fast/canvas/webgl/null-object-behaviour-expected.txt:
• fast/canvas/webgl/null-object-behaviour.html:
• inspector/canvas/recording-webgl-frameCount.html:
• inspector/canvas/recording-webgl-full-expected.txt:
• inspector/canvas/recording-webgl-full.html:
• inspector/canvas/recording-webgl-memoryLimit.html:
• inspector/canvas/recording-webgl-snapshots.html:
• inspector/canvas/recording-webgl2-frameCount.html:
• inspector/canvas/recording-webgl2-full.html:
• inspector/canvas/recording-webgl2-memoryLimit.html:
• inspector/canvas/recording-webgl2-snapshots.html:
• inspector/canvas/resources/recording-webgl.js:

(load):

• webgl/2.0.0/conformance/misc/bad-arguments-test-expected.txt:
• webgl/2.0.0/conformance/misc/error-reporting-expected.txt:
• webgl/2.0.0/conformance/misc/null-object-behaviour-expected.txt:
• webgl/2.0.0/conformance/programs/get-active-test-expected.txt:
• webgl/2.0.0/conformance/state/gl-object-get-calls-expected.txt:
• webgl/2.0.0/conformance/textures/misc/tex-sub-image-2d-bad-args-expected.txt:
• webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:

4:44 PM Changeset in webkit [265840] by ysuzuki@apple.com

• 2 edits in trunk/Tools

Unreviewed, contributors.json is broken

• Scripts/webkitpy/common/config/contributors.json:

4:22 PM Changeset in webkit [265839] by dino@apple.com

• 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Adding some Google folks to contributors.

• Scripts/webkitpy/common/config/contributors.json:

4:15 PM Changeset in webkit [265838] by Chris Dumez

• 5 edits in trunk

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear"
​https://bugs.webkit.org/show_bug.cgi?id=215625

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:

Source/WebCore:

PannerNode's rolloffFactor should be clamped to [0, 1] internally when distanceModel is "linear":

• ​https://www.w3.org/TR/webaudio/#dom-pannernode-rollofffactor

No new tests, rebaselined existing test.

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::setRolloffFactor):

• platform/audio/Distance.cpp:

(WebCore::DistanceEffect::linearGain):

4:01 PM Changeset in webkit [265837] by Darin Adler

• 2 edits in trunk/Websites/webkit.org

• languages.md: Fixed "Movaje" typo.

3:51 PM Changeset in webkit [265836] by Chris Dumez

• 4 edits in trunk

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext
​https://bugs.webkit.org/show_bug.cgi?id=215624

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:

Source/WebCore:

ScriptProcessNode should only run script asynchronously if the audio context is not an OfflineAudioContext.
If the context is an OfflineAudioContext, then it should pause processing until the script has finished
execution. This aligns our behavior with Blink and helps us pass more WPT tests.

No new tests, rebaselined existing test.

• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

3:18 PM Changeset in webkit [265835] by commit-queue@webkit.org

• 4 edits in trunk

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

2:44 PM Changeset in webkit [265834] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

[Catalyst] Video should pause automatically when switching desktops
​https://bugs.webkit.org/show_bug.cgi?id=215620

Reviewed by Jer Noble.

• platform/audio/ios/MediaSessionManagerIOS.h:
• platform/audio/ios/MediaSessionManagerIOS.mm: Don't override resetRestrictions

on Catalyst so we don't pause video in the background.

2:24 PM Changeset in webkit [265833] by commit-queue@webkit.org

• 11 edits
  1 copy
  4 adds in trunk

[WebGL2] Pass user-defined-properties-on-context.html layout test
​https://bugs.webkit.org/show_bug.cgi?id=215433

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-08-18
Reviewed by Yusuke Suzuki.

Source/WebCore:

Keep the canvas' rendering context alive from the canvas itself by
adding a custom mark function for HTMLCanvasElement, and adding a
new GenerateIsReachable=ImplCanvasBase extended IDL attribute,
used from all rendering context types (2D, WebGL, and WebGPU).

This patch does not touch OffscreenCanvas since the implementation
there seems to be incomplete and there are no associated tests of
GC behavior.

Tests: fast/canvas/2d.context.expando.html

webgpu/expando-properties.html

• Modules/webgpu/GPUCanvasContext.idl:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSHTMLCanvasElementCustom.cpp: Copied from Source/WebCore/html/canvas/WebGLRenderingContext.idl.

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/IDLAttributes.json:
• html/HTMLCanvasElement.idl:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.idl:

LayoutTests:

Rebaseline user-defined-properties-on-context.html, which is now
fully passing.

Add tests of expando properties on 2D and WebGPU contexts. Add a
FIXME to the WebGPU test, as that specification no longer defines
a canvas rendering context.

• fast/canvas/2d.context.expando-expected.txt: Added.
• fast/canvas/2d.context.expando.html: Added.
• webgl/2.0.0/conformance/context/user-defined-properties-on-context-expected.txt:
• webgpu/expando-properties-expected.txt: Added.
• webgpu/expando-properties.html: Added.

2:13 PM Changeset in webkit [265832] by Chris Dumez

• 4 edits in trunk

WaveShaperNode.curve setter should create a copy of the input array
​https://bugs.webkit.org/show_bug.cgi?id=215615

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that all checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

WaveShaperNode.curve setter should create a copy of the input array, so that follow-up modifications
of the array by the JS do not impact audio processing:

• ​https://www.w3.org/TR/webaudio/#dom-waveshapernode-curve

No new tests, rebaselined existing test.

• Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setCurve):

1:58 PM Changeset in webkit [265831] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r262381): replaceChildren should not use DeferChildrenChanged::No
​https://bugs.webkit.org/show_bug.cgi?id=215600

Reviewed by Antti Koivisto.

It's not correct to use DeferChildrenChanged::No when the new node may have an old parent.
Use DeferChildrenChanged::Yes instead.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildren): Added a release assertion to make sure
people don't start using this function incorrectly in the future.
(WebCore::ContainerNode::replaceChildren): Fixed the bug.

1:46 PM Changeset in webkit [265830] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update byte offsets in JSString.h comment
​https://bugs.webkit.org/show_bug.cgi?id=215621

Reviewed by Yusuke Suzuki.

• runtime/JSString.h:

1:22 PM Changeset in webkit [265829] by Karl Rackler

• 2 edits in trunk/LayoutTests

Disable plug-in tests on Apple Silicon
Updating test expectation in include Rosetta

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:12 PM Changeset in webkit [265828] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://66861801 ([ Layout Tests] REGRESSION (r265487): svg/W3C-I18N/tspan-direction-rtl.svg is a constant failure)
Updating expectations in include Rosetta.

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:07 PM Changeset in webkit [265827] by Darin Adler

• 1 edit
  1 add in trunk/Websites/webkit.org

Document versions of C++ and Python
​https://bugs.webkit.org/show_bug.cgi?id=215191

Reviewed by Jonathan Bedard.

• languages.md: Added.

10:53 AM Changeset in webkit [265826] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215614

Unreviewed test gardening.

• platform/mac/TestExpectations:

10:08 AM Changeset in webkit [265825] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67289434 ([ Rosetta Layout Tests ] REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs

Unreviewed test gardening.

• platform/mac/TestExpectations:

10:00 AM Changeset in webkit [265824] by Chris Dumez

• 11 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline webaudio WPT tests that are marked as flaky.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

9:59 AM Changeset in webkit [265823] by Simon Fraser

• 9 edits in trunk

Turn off wheel event regions until we need them
​https://bugs.webkit.org/show_bug.cgi?id=215586

Reviewed by Darin Adler.
Source/WebCore:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

• page/scrolling/ScrollingTree.cpp:
• page/scrolling/ScrollingTree.h:
• page/scrolling/mac/ScrollingTreeMac.h:
• page/scrolling/mac/ScrollingTreeMac.mm:

Source/WTF:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

• wtf/PlatformEnableCocoa.h:

LayoutTests:

Leave ENABLE_WHEEL_EVENT_REGIONS off because it's currently unused, and adds extra
region building overhead on macOS.

• platform/mac-wk2/TestExpectations:

9:56 AM Changeset in webkit [265822] by youenn@apple.com

• 8 edits in trunk

Update platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html to account for low latency code path
​https://bugs.webkit.org/show_bug.cgi?id=215601

Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing/updated test.

• testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder):
In case low latency code path is enabled, supportsVCPEncoder should return true.

LayoutTests:

Update test to check software encoder for both baseline and high profiles.
Move baseline/high profile selection routines to routines.js.

• platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
• platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
• webrtc/h264-baseline.html:
• webrtc/h264-high.html:
• webrtc/routines.js:

9:49 AM Changeset in webkit [265821] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67281310 REGRESSION (r265639): [ BigSur ] 11 canvas layout tests are a constant failure)
Should skip this only on Rosetta, not all Intel Big Sur Macs
Clean up arm64 only gardening.

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:36 AM Changeset in webkit [265820] by Simon Fraser

• 16 edits
  1 copy
  1 add in trunk

REGRESSION (Async overflow scrolling): No rubberbanding in overflow:scroll in the wheel event region
​https://bugs.webkit.org/show_bug.cgi?id=215598
<rdar://problem/64895442>

Reviewed by Darin Adler.
Source/WebCore:

Scrolling in overflow:scroll inside the non-fast event region (e.g. inside an ancestor with a wheel event
handler) happens via ScrollAnimatorMac::handleWheelEvent() which calls ScrollableArea::setScrollOffsetFromAnimation()
which bounces to the scrolling thread via RenderLayer::requestScrollPositionUpdate(). We were clamping the
scroll offset here, thus disallowing the overscrolled offsets required for rubberbanding.

Fix is to allow clamping for user scrolls. Also add more logging.

Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region.html

• dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

LayoutTests:

Remove an unneeded var successfullyParsed = true in existing tests.

New test that detect rubberbanding.

• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
• fast/scrolling/mac/async-scroll-overflow-rtl.html:
• fast/scrolling/mac/async-scroll-overflow-top-inset.html:
• fast/scrolling/mac/async-scroll-overflow.html:
• fast/scrolling/mac/hit-test-overflow-tiled-layer.html:
• fast/scrolling/mac/move-node-in-overflow-scroll.html:
• fast/scrolling/mac/overflow-scrolled-document.html:
• fast/scrolling/mac/overflow-zoomed-document.html:
• fast/scrolling/mac/overlapped-overflow-scroll.html:
• fast/scrolling/mac/rubberband-overflow-in-wheel-region-expected.txt: Added.
• fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Copied from LayoutTests/fast/scrolling/mac/overflow-scrolled-document.html.

9:31 AM Changeset in webkit [265819] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, null-deref fix after r265797.

MockAudioDestinationCocoa::tick() is calling AudioDestinationCocoa::inputProc()
with a null AudioTimeStamp struct so we need to deal with this.

• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::render):

9:20 AM Changeset in webkit [265818] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215611

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:04 AM Changeset in webkit [265817] by aakash_jain@apple.com

• 3 edits
  2 adds in trunk/Tools

Develop a mechanism to unsubscribe from ews emails
​https://bugs.webkit.org/show_bug.cgi?id=215585

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/emails.json: Added.
• BuildSlaveSupport/ews-build/send_email.py:

(get_email_ids):
(send_email_to_patch_author): Do not email patch authors whose email is in unsubscribe list.
(send_email_to_bot_watchers):

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):

• BuildSlaveSupport/ews-build/email_unittest.py: Added unit-tests.

(EmailsDotJSONTest.test_valid_emails_json):
(EmailsDotJSONTest.test_emails_json_required_categories_present):

9:01 AM Changeset in webkit [265816] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

[Mac] Unhandled keyDown: events cause a system beep in full screen mode
​https://bugs.webkit.org/show_bug.cgi?id=215596
<rdar://problem/65823962>

Reviewed by Darin Adler.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController noResponderFor:]):

8:39 AM Changeset in webkit [265815] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS wk1 iOS ] imported/w3c/web-platform-tests/IndexedDB/transaction_bubble-and-capture.htm is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215608

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:

8:16 AM Changeset in webkit [265814] by youenn@apple.com

• 3 edits in trunk/Source/WebKit

NetworkSocketChannel should delay sending back error message as done by NetworkSocketStream
​https://bugs.webkit.org/show_bug.cgi?id=215563

Reviewed by Alex Christensen.

Apply same policy as NetworkSocketStream in case of WebSocket connection error.
Covered by http/tests/websocket/tests/hybi/closed-port-delay.html with NSURLSession WebSocket code path.

• NetworkProcess/NetworkSocketChannel.cpp:

(WebKit::NetworkSocketChannel::NetworkSocketChannel):
(WebKit::NetworkSocketChannel::didClose):
(WebKit::NetworkSocketChannel::didReceiveMessageError):
(WebKit::NetworkSocketChannel::sendDelayedError):

• NetworkProcess/NetworkSocketChannel.h:

8:09 AM Changeset in webkit [265813] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 ] webgpu/whlsl/do-while-loop-break.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215606

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

7:45 AM Changeset in webkit [265812] by Antti Koivisto

• 4 edits in trunk

The CSS specificity of :host() pseudo-classes is wrong
​https://bugs.webkit.org/show_bug.cgi?id=202494
<rdar://problem/66292568>

Reviewed by Anders Carlsson.

Source/WebCore:

​https://drafts.csswg.org/css-scoping/#host-selector

“The specificity of :host() is that of a pseudo-class, plus the specificity of its argument.”

• css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):

LayoutTests:

• TestExpectations:

2:54 AM Changeset in webkit [265811] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test baseline after r265749.

• platform/gtk/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

1:45 AM Changeset in webkit [265810] by youenn@apple.com

• 5 edits in trunk/Source/WebCore

Add a JS built-in routine to mark a promise as handled
​https://bugs.webkit.org/show_bug.cgi?id=215558

Reviewed by Darin Adler.

Wrap long line of code inside a method to ease code readability.
No change of behavior.

• Modules/streams/ReadableStream.js:

(pipeThrough):

• Modules/streams/ReadableStreamInternals.js:

(readableStreamError):
(readableStreamReaderGenericRelease):

• Modules/streams/StreamInternals.js:

(markPromiseAsHandled):
(shieldingPromiseResolve):

• Modules/streams/WritableStreamInternals.js:

(setUpWritableStreamDefaultWriter):
(writableStreamRejectCloseAndClosedPromiseIfNeeded):
(writableStreamDefaultWriterEnsureClosedPromiseRejected):
(writableStreamDefaultWriterEnsureReadyPromiseRejected):

1:03 AM Changeset in webkit [265809] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed GLib gardening. Skip more tests using plugins after r265753

• platform/glib/TestExpectations:

Aug 17, 2020:

7:48 PM Changeset in webkit [265808] by Karl Rackler

• 2 edits in trunk/LayoutTests

REGRESSION (r265701): [ BigSur ] 3 webaudio/the-audio-api/the-audioparam-interface tests are a constant failure)
rdar://67289434

Unreviewed test gardening.

• platform/mac/TestExpectations:

7:37 PM Changeset in webkit [265807] by Hector Lopez

• 2 edits in trunk/LayoutTests

ASSERTION FAILURE: WebKit::AuthenticationManager::initializeConnection(IPC::Connection *)_block_invoke
​https://bugs.webkit.org/show_bug.cgi?id=215025

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

7:31 PM Changeset in webkit [265806] by Lauro Moura

• 3 edits in trunk/LayoutTests

[GTK][WPE] Update some expectations after closed bugs

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

7:22 PM Changeset in webkit [265805] by Russell Epstein

• 73 edits
  3 adds in branches/safari-610.1-branch

Cherry-pick r265749. rdar://problem/67284454

JSDOMConstructorNotConstructable should be a constructor
​https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/send-file-form-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
• web-platform-tests/custom-elements/Document-createElement-expected.txt:
• web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
• web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
• web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
• web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
• web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
• web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
• web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
• web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
• web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
• web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
• web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
• web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
• web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
• web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
• web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
• web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:

Source/WebCore:

Test: js/dom/window-is-constructor.html

While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable) should be true. To fix it, we add getConstructData
which configures a function throwing an error.

• bindings/js/JSDOMConstructorNotConstructable.h:

LayoutTests:

• editing/async-clipboard/clipboard-interfaces-expected.txt:
• editing/undo-manager/undo-manager-interfaces-expected.txt:
• fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
• http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
• http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
• js/interface-objects-expected.txt:
• performance-api/paint-timing/paint-timing-apis-expected.txt:
• performance-api/performance-observer-api-expected.txt:
• performance-api/performance-timeline-api-expected.txt:
• performance-api/resource-timing-apis-expected.txt:
• performance-api/user-timing-apis-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:22 PM Changeset in webkit [265804] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265774. rdar://problem/67284328

[Cocoa] Avoid waiting for Launch Services on every load
​https://bugs.webkit.org/show_bug.cgi?id=215569

Reviewed by Darin Adler.

Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.

No new tests, covered by existing tests.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:22 PM Changeset in webkit [265803] by Russell Epstein

• 6 edits in branches/safari-610.1-branch/Source

Cherry-pick r265743. rdar://problem/67284428

Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
​https://bugs.webkit.org/show_bug.cgi?id=215529
<rdar://problem/66866163>

Reviewed by Geoff Garen.
Source/WebCore:

r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.

• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::isRecentlyActive): (WebCore::ScrollingTree::setRecentlyActive):
• page/scrolling/ScrollingTree.h:
• page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::willStartRenderingUpdate): (WebCore::ThreadedScrollingTree::displayDidRefresh):

Source/WebKit:

r261985 added two code paths that wake up the scrolling thread on every
rendering update (triggered by displayDidRefresh()). One is a ping from
the EventDispatcher thread, the other is a wake-and-block from the main
thread. If the scrolling thread isn't active (no wheel events received recently),
we can avoid both of these to reduce the number of CPU core wakeups.

• WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::wheelEvent):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265802] by Russell Epstein

• 4 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265727. rdar://problem/67284319

Revert r263551
​https://bugs.webkit.org/show_bug.cgi?id=215530
<rdar://problem/66961066>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-14
Reviewed by Geoffrey Garen.

I was hoping to fix many developers' bugs, but it caused hangs and more hangs, so back to the status quo.
​https://bugs.webkit.org/show_bug.cgi?id=203547 will fix this the right way in the hopefully-not-too-distant future.

• UIProcess/API/APIHTTPCookieStore.cpp: (API::HTTPCookieStore::setCookies): (API::HTTPCookieStore::registerForNewProcessPoolNotifications): (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):
• UIProcess/API/APIHTTPCookieStore.h:
• UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm: (API::HTTPCookieStore::flushDefaultUIProcessCookieStore):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265801] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265723. rdar://problem/67284292

Crash inside FrameLoader::defaultRequestCachingPolicy (null DocumentLoader)
<rdar://problem/42167093> and ​https://bugs.webkit.org/show_bug.cgi?id=215527

Reviewed by Darin Adler.

We have CrashTracer data, but despite my best efforts no way of reproducing.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::defaultRequestCachingPolicy): If a PingLoader is sending a CSP violation report sometime after part of the Document's lifecycle, the FrameLoader as a null DocumentLoader here. Like everywhere else in FrameLoader, null check it.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265800] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265722. rdar://problem/67284309

RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
​https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>

Reviewed by Simon Fraser.

Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.

• rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::scrollWidth const): (WebCore::RenderTextControlSingleLine::scrollHeight const): (WebCore::RenderTextControlSingleLine::scrollLeft const): (WebCore::RenderTextControlSingleLine::scrollTop const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265799] by Russell Epstein

• 5 edits in branches/safari-610.1-branch

Cherry-pick r265645. rdar://problem/67285376

VoiceOver not able to invoke play button on some web sites.
​https://bugs.webkit.org/show_bug.cgi?id=215484
<rdar://problem/62729643>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/ios-simulator/has-touch-event-listener.html.

We were checking for the presence of listeners for touchstart and touchend
events only. Now we check for the presence of any touch-related event listener.

• accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::hasTouchEventListener const):

LayoutTests:

Expanded this test to check for all touch-related event listeners.

• accessibility/ios-simulator/has-touch-event-listener-expected.txt:
• accessibility/ios-simulator/has-touch-event-listener.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:21 PM Changeset in webkit [265798] by Russell Epstein

• 3 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265427. rdar://problem/67284328

Add required entitlement for Catalyst
​https://bugs.webkit.org/show_bug.cgi?id=215244

Reviewed by Darin Adler.

The entitlement 'com.apple.private.webkit.use-xpc-endpoint' should be added to the WebContent process on Catalyst as well,
since it is needed on all Apple platforms. This entitlement is needed to support direct XPC communication between WebKit
processes, which is used to send the Launch Services database to the WebContent process from the Networking process. Also,
add some more logging related to this, to detect if it takes a long time for the WebContent process to receive the database.

• Scripts/process-entitlements.sh:
• WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::platformDidReceiveLoadParameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:16 PM Changeset in webkit [265797] by Chris Dumez

• 28 edits
  2 copies in trunk

AudioContext.getOutputTimestamp() is missing
​https://bugs.webkit.org/show_bug.cgi?id=215591

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-getoutputtimestamp-expected.txt:

Source/WebCore:

AudioContext.getOutputTimestamp() is missing:

• ​https://www.w3.org/TR/webaudio/#dom-audiocontext-getoutputtimestamp

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::getOutputTimestamp):

• Modules/webaudio/AudioContext.h:
• Modules/webaudio/AudioContext.idl:
• Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioTimestamp.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
• Modules/webaudio/AudioTimestamp.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::handlePreRenderTasks):
(WebCore::BaseAudioContext::outputPosition):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/audio/AudioIOCallback.h:

(WebCore::AudioIOPosition::encode const):
(WebCore::AudioIOPosition::decode):

• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::machAbsoluteTimeToMonotonicTime):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::inputProc):

• platform/audio/cocoa/AudioDestinationCocoa.h:

Source/WebKit:

• GPUProcess/media/RemoteAudioDestinationManager.cpp:
• WebProcess/GPU/media/RemoteAudioBusData.h:

(WebKit::RemoteAudioBusData::encode const):
(WebKit::RemoteAudioBusData::decode):

• WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:

(WebKit::RemoteAudioDestinationProxy::renderBuffer):

7:12 PM Changeset in webkit [265796] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE][WebDriver] Gardening some failures

Unreviewed test gardening.

• TestExpectations.json:

7:07 PM Changeset in webkit [265795] by Hector Lopez

• 3 edits in trunk/LayoutTests

WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html
​https://bugs.webkit.org/show_bug.cgi?id=215221

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations: expectation removal
• platform/mac-wk2/TestExpectations: expectation removal

6:24 PM Changeset in webkit [265794] by Chris Dumez

• 6 edits
  2 deletes in trunk

Improve channel mixing support in AudioBus
​https://bugs.webkit.org/show_bug.cgi?id=215597

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that all checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-channel-rules-expected.txt:

Source/WebCore:

Improve channel mixing support in AudioBus to match the specification:

• ​https://www.w3.org/TR/webaudio/#channel-up-mixing-and-down-mixing

Our implementation also matches Blink's:

• ​https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/platform/audio/audio_bus.cc

No new tests, rebaselined existing test.

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyFrom):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersSumFromByUpMixing):
(WebCore::AudioBus::speakersSumFromByDownMixing):

• platform/audio/AudioBus.h:

LayoutTests:

Remove outdated test. A newer version of this test is present in web-platform-tests.

• webaudio/audionode-channel-rules-expected.txt: Removed.
• webaudio/audionode-channel-rules.html: Removed.

5:53 PM Changeset in webkit [265793] by Karl Rackler

• 2 edits in trunk/LayoutTests

Removing added entry in error.

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:49 PM Changeset in webkit [265792] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

Assert failure after r265715
​https://bugs.webkit.org/show_bug.cgi?id=215592

Reviewed by Darin Adler.

The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. This
happens because after r265715 the new XPC event handler set in AuthenticationManager::initializeConnection,
will no longer be called on the main thread. This patch addresses this issue by dispatching this work on
the main thread.

No new tests, covered by existing tests.

• Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:

(WebKit::AuthenticationManager::initializeConnection):

5:43 PM Changeset in webkit [265791] by Karl Rackler

• 2 edits in trunk/LayoutTests

Adding BigSur to existing test expectations

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:53 PM Changeset in webkit [265790] by Russell Epstein

• 24 edits in branches/safari-610.1-branch

Cherry-pick r265289. rdar://problem/66944320

Update event regions only once per frame
​https://bugs.webkit.org/show_bug.cgi?id=215132
<rdar://problem/66533779>

Reviewed by Darin Adler.

Source/WebCore:

Event regions (for touch-action, editable areas etc) were updated as part of
compositing updates, but we only need their output once per rendering update, so
move their computation out of RenderLayerCompositor::updateBackingAndHierarchy()
and into a new RenderLayer tree walk that is called from Page::doAfterUpdateRendering().

RenderLayerBacking stores a dirty bit to track when regions need to be updated.

Reduces the amount of time spent in rendering updates when scrolling on facebook.com
on iPad, which has lots of discontiguous touch-action regions.

• dom/Document.cpp: (WebCore::Document::updateEventRegions):
• dom/Document.h:
• page/Frame.cpp: (WebCore::Frame::layerTreeAsText const):
• page/Page.cpp: (WebCore::Page::doAfterUpdateRendering):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const): (WebCore::RenderLayerBacking::updateEventRegion):
• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateEventRegions): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
• rendering/RenderLayerCompositor.h:

LayoutTests:

Tests that dispatch mouseWheel events in a way that tests event regions need to wait
now for a rendering update. await UIHelper.animationFrame() is not enough, because
the function resumes inside a microtask at the end of the requestAnimationFrame callback,
which is before we've completed the rest of the rendering update, and thus before
the event regions have been updated.

In addition, await UIHelper.animationFrame() followed by eventSender calls to issue
wheel events actually trigger Page::updateRendering() re-entrancy, via the
WKBundlePageForceRepaint() in EventSendingController::mouseScrollByWithWheelAndMomentumPhases().

To fix this, add and use UIHelper.renderingUpdate(), which waits for a rAF and uses a setTimeout()
to get past the end of the current rendering update.

• fast/scrolling/mac/absolute-in-overflow-scroll-dynamic-expected.html:
• fast/scrolling/mac/absolute-in-overflow-scroll-dynamic.html:
• fast/scrolling/mac/absolute-in-overflow-scroll.html:
• fast/scrolling/mac/async-scroll-overflow-hidden-on-one-axis.html:
• fast/scrolling/mac/async-scroll-overflow-rtl-zoomed.html:
• fast/scrolling/mac/async-scroll-overflow-top-inset.html:
• fast/scrolling/mac/async-scroll-overflow.html:
• fast/scrolling/mac/clip-path-hit-test.html:
• fast/scrolling/mac/move-node-in-overflow-scroll.html:
• fast/scrolling/mac/overflow-scrolled-document.html:
• fast/scrolling/mac/overflow-zoomed-document.html:
• fast/scrolling/mac/overlapped-overflow-scroll.html:
• resources/ui-helper.js: (window.UIHelper.async renderingUpdate):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:53 PM Changeset in webkit [265789] by Russell Epstein

• 6 edits in branches/safari-610.1-branch/Source/WebCore

Cherry-pick r265232. rdar://problem/66944320

Add an EventRegions log channel
​https://bugs.webkit.org/show_bug.cgi?id=215092

Reviewed by Daniel Bates.

Add a log channel for EventRegions, add logging in some interesting places.

• platform/Logging.h:
• rendering/EventRegion.cpp: (WebCore::EventRegion::unite): (WebCore::EventRegion::uniteTouchActions): (WebCore::EventRegion::uniteEventListeners):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateEventRegion):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265788] by Russell Epstein

• 27 edits in branches/safari-610.1-branch/Source

Cherry-pick r265562. rdar://problem/66944332

Add the support to return to element fullscreen from picture-in-picture
​https://bugs.webkit.org/show_bug.cgi?id=215305

Reviewed by Jer Noble.

Source/WebCore:

When a container element enters fullscreen (with the fullscreen API), a descendant
video element will enter the video fullscreen standby state so that it can enter
picture-in-picture on application suspend (r226217). But we cannot restore
to that state from the picture-in-picture mode when we click the "restore" button
on the top-right corner of the PiP window. Instead, the video element will return
to the inline mode.

However, when a video element enters video fullscreen first and then enters
picture-in-picture, we can let the video restore to fullscreen by clicking the
"restore" button on the top-right corner of the picture-in-picture window.

The inconsistent behaviors may confuse users who are not aware of the difference
between the fullscreen API (or element fullscreen) and video fullscreen.

This patch enables the support to restore to element fullscreen from picture-in-picture
mode so that users can have a consistent experience on element fullscreen and
video fullscreen.

• dom/FullscreenManager.h: Export requestFullscreenForElement() so that we can use it in WebKit code.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen): (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):
• html/HTMLMediaElement.h:
• page/ChromeClient.h: (WebCore::ChromeClient::prepareForVideoFullscreen): Add the interface to request a video element to be prepared for the video fullscreen standby state.

• platform/cocoa/VideoFullscreenChangeObserver.h: Add prepareToExitFullscreen() and fullscreenWillReturnToInline().

• platform/cocoa/VideoFullscreenModel.h: (WebCore::VideoFullscreenModelClient::hasVideoChanged): (WebCore::VideoFullscreenModelClient::videoDimensionsChanged): (WebCore::VideoFullscreenModelClient::prepareToExitPictureInPicture): Some minor clean-ups and add function prepareToExitPictureInPicture().

• platform/ios/VideoFullscreenInterfaceAVKit.h:
• platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::cleanupFullscreen): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStop): (VideoFullscreenInterfaceAVKit::didStartPictureInPicture): (VideoFullscreenInterfaceAVKit::willStopPictureInPicture): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler): (VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture): (VideoFullscreenInterfaceAVKit::willEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::setWillEnterStandbyFromPictureInPicture): (VideoFullscreenInterfaceAVKit::fullscreenMayReturnToInline): Deleted. When we enter picture-in-picture, we need to save the state and be prepared to restore to element fullscreen if needed.

Before we exit picture-in-picture, if the "restore" button is clicked, we need
to notify the client to prepare for the picture-in-picture stop, and call
VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture(true) when the client
is ready.

Based on those changes, a client (e.g., WKFullScreenWindowControllerVideoFullscreenModelClient)
can coordinate with WKFullScreenWindowController to implement the "restore to
element fullscreen" feature.

• platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::fullscreenWillReturnToInline): (VideoFullscreenControllerContext::fullscreenMayReturnToInline): Deleted.

Source/WebKit:

This patch replaces WKFullScreenViewControllerVideoFullscreenModelClient
with WKFullScreenWindowControllerVideoFullscreenModelClient. We need to do
that because the instance of WKFullScreenViewControllerVideoFullscreenModelClient
will be destroyed after the container element exits fullscreen while the video
element enters picture-in-picture.

The instance of WKFullScreenWindowControllerVideoFullscreenModelClient
will always exist when the WKFullScreenWindowController instance is alive,
so that it can receive callbacks from the VideoFullscreenInterfaceAVKit instance
to implement the "return to element fullscreen from picture-in-picture" feature.

This patch supports the following transitions:
element fullscreen -> picture-in-picture (through user gestures)
element fullscreen -> picture-in-picture (through the PiP button)
picture-in-picture -> element fullscreen (when the tab is visible)
picture-in-picture -> element fullscreen (when the tab is invisible)
picture-in-picture -> element fullscreen (when the browser is in background)
picture-in-picture -> inline (when the browser is in foreground)
exit picture-in-picture when the browser is in background

• UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenModelContext::fullscreenWillReturnToInline): (WebKit::VideoFullscreenModelContext::prepareToExitFullscreen): Notify clients to prepare for the stop of fullscreen/picture-in-picture. (WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID): Fix issues that increase the client count unnecessarily. (WebKit::VideoFullscreenManagerProxy::preparedToReturnToInline): Call m_page->fullscreenMayReturnToInline() earlier. (WebKit::VideoFullscreenManagerProxy::fullscreenMayReturnToInline): Ditto. (WebKit::VideoFullscreenManagerProxy::fullscreenWillReturnToInline): Notify VideoFullscreenManager to prepare for exiting picture-in-picture or video fullscreen and report the destination rectangle of the exit picture-in-picture or video fullscreen animations.

• UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::requestEnterFullScreen):
• UIProcess/WebFullScreenManagerProxy.h: Add a function requestEnterFullScreen() so that we can request an element to enter fullscreen from the UI process side.

• UIProcess/ios/fullscreen/WKFullScreenViewController.h:
• UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController dealloc]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController setAnimatingViewAlpha:]): (-[WKFullScreenViewController _cancelAction:]): (WKFullScreenViewControllerVideoFullscreenModelClient::setParent): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::setInterface): Deleted. (WKFullScreenViewControllerVideoFullscreenModelClient::interface const): Deleted. (-[WKFullScreenViewController willEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController didEnterPictureInPicture]): Deleted. (-[WKFullScreenViewController failedToEnterPictureInPicture]): Deleted. Minor clean-ups and remove code related to WKFullScreenViewControllerVideoFullscreenModelClient.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.h:
• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): (WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): (WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): (-[WKFullScreenWindowController initWithWebView:]): (-[WKFullScreenWindowController dealloc]): (-[WKFullScreenWindowController enterFullScreen]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController requestEnterFullScreen]): (-[WKFullScreenWindowController requestExitFullScreen]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController videoControlsManagerDidChange]): (-[WKFullScreenWindowController willEnterPictureInPicture]): (-[WKFullScreenWindowController didEnterPictureInPicture]): (-[WKFullScreenWindowController failedToEnterPictureInPicture]): (-[WKFullScreenWindowController prepareToExitPictureInPicture]): (-[WKFullScreenWindowController didExitPictureInPicture]): Add WKFullScreenWindowControllerVideoFullscreenModelClient and implement the support to "restore fullscreen from picture-in-picture".

• WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): (WebKit::WebFullScreenManager::requestEnterFullScreen):
• WebProcess/FullScreen/WebFullScreenManager.h:
• WebProcess/FullScreen/WebFullScreenManager.messages.in: Add the interface requestEnterFullScreen() and the corresponding IPC message.

• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::prepareForVideoFullscreen):
• WebProcess/WebCoreSupport/WebChromeClient.h: Add the interface to prepare for video fullscreen standby. The web process can use this interface to create a VideoFullscreenManager instance to avoid the scenario that an IPC message comes from the VideoFullscreenManagerProxy but the VideoFullscreenManager instance is not constructed yet.

• WebProcess/cocoa/VideoFullscreenManager.h:
• WebProcess/cocoa/VideoFullscreenManager.messages.in:
• WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::fullscreenWillReturnToInline): (WebKit::VideoFullscreenManager::fullscreenMayReturnToInline): Deleted. Rename fullscreenMayReturnToInline() to fullscreenWillReturnToInline(). In the UI process side, fullscreenMayReturnToInline() is used by VideoFullscreenManagerProxy to notify applications regarding UI changes (e.g., switch browser tabs).

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265787] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/ThirdParty/libwebrtc

Cherry-pick r265500. rdar://problem/66944395

Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
​https://bugs.webkit.org/show_bug.cgi?id=215378
<rdar://problem/66788144>

Reviewed by Eric Carlson.

• Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c: (sctp_handle_asconf):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265786] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265270. rdar://problem/66944311

Unreviewed build fix after r265263
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265785] by Russell Epstein

• 2 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265263. rdar://problem/66944311

Limit 'com.apple.webkit.microphone' use to macOS and MacCatalyst
​https://bugs.webkit.org/show_bug.cgi?id=215139
<rdar://problem/66501746>

Reviewed by Eric Carlson.

We only need the 'com.apple.webkit.microphone' Sandbox Extension at startup on
macOS and MacCatalyst (and even on those platforms, only until <rdar://problem/29448368>
is fixed).

We should not issue this extension on the iOS family of targets.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:49 PM Changeset in webkit [265784] by Russell Epstein

• 14 edits
  2 adds in branches/safari-610.1-branch

Cherry-pick r265259. rdar://problem/66944362

AX: VoiceOver needs access to font styling at insertion point
​https://bugs.webkit.org/show_bug.cgi?id=215129
Source/WebCore:

<rdar://problem/65114972>

Reviewed by Darin Adler.

Give access to relevant font styling properties at the insertion point so that VoiceOver can speak them
when text commands alter styling.

Test: accessibility/mac/resolved-text-editing.html

• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::resolvedEditingStyles const):
• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilityResolvedEditingStyles]):
• accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::resolvedEditingStyles const):
• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/mac/WebAccessibilityObjectWrapperBase.h:
• accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase baseAccessibilityResolvedEditingStyles]):
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Reviewed by Darin Adler.

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::attributeValueAsync):

LayoutTests:

Reviewed by Darin Adler.

• accessibility/mac/resolved-text-editing-expected.txt: Added.
• accessibility/mac/resolved-text-editing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:24 PM Changeset in webkit [265783] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] webaudio/oscillator-square.html is a flaky failure
Nhttps://bugs.webkit.org/show_bug.cgi?id=215593

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

4:19 PM Changeset in webkit [265782] by Karl Rackler

• 6 edits
  3 deletes in trunk

Unreviewed, reverting r265603.

Reverting per commiter because commit caused consisent crash
with test.

Reverted changeset:

"Font loads quickly followed by navigations may fail
indefinitely"
​https://bugs.webkit.org/show_bug.cgi?id=215435
​https://trac.webkit.org/changeset/265603

4:13 PM Changeset in webkit [265781] by Chris Dumez

• 10 edits in trunk

AudioNode.disconnect() does not match the specification
​https://bugs.webkit.org/show_bug.cgi?id=215578

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-expected.txt:

Source/WebCore:

AudioNode.disconnect() did not match the specification. There were a lot of overloads in
the specification that we did not support:

• ​https://www.w3.org/TR/webaudio/#dom-audionode-disconnect

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect): Deleted.
(WebCore::AudioBasicInspectorNode::disconnect): Deleted.

• Modules/webaudio/AudioBasicInspectorNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):

• Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::updatePullStatus):

• Modules/webaudio/AudioNode.idl:
• Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isConnectedTo const):

4:12 PM Changeset in webkit [265780] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215353

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-17
Reviewed by Jon Lee.

GCController.collect() is flaky. Calling this function from JS does not
guarantee the memory of all the deallocated objects is garbage-collected.
Multiple calls to GCController.collect() may be invoked to overcome this
problem. Putting idle time before requesting the numberOfLiveNodes()
might be needed as well.

The test adds 100 <use> elements. Each of them references a <rect> element
and adds an <animate> element to animate the 'x' property. This is a big
number of objects to be allocated, deallocated and garbage collected. To
overcome the flakiness of GCController.collect(), three <use> elements
can be added instead. This number of objects should be enough to test the
SVG animated properties do not leak. And at the same time the test won't
exercise the flakiness of GCController.collect().

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• svg/animations/smil-leak-element-instances-noBaseValRef.svg:

4:01 PM Changeset in webkit [265779] by Russell Epstein

• 8 edits in branches/safari-610.1-branch/Source

Versioning.

WebKit-7610.1.28

3:44 PM Changeset in webkit [265778] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Stop webkitpy from warning about not having a 64-bit git on Apple silicon
​https://bugs.webkit.org/show_bug.cgi?id=214718

Patch by Saagar Jha <​saagar@saagarjha.com> on 2020-08-17
Reviewed by Jonathan Bedard.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git._executable_is_64bit): Loosen 64-bit check to succeed on systems that aren't x86_64.

3:26 PM Changeset in webkit [265777] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] media/modern-media-controls/volume-down-support/volume-down-support.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215587

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:21 PM Changeset in webkit [265776] by Alan Coon

• 1 copy in tags/Safari-610.1.27

Tag Safari-610.1.27.

3:10 PM Changeset in webkit [265775] by sbarati@apple.com

• 17 edits
  5 adds in trunk

Have an OOB+SaneChain Array::Speculation
​https://bugs.webkit.org/show_bug.cgi?id=215487

Reviewed by Yusuke Suzuki.

JSTests:

• microbenchmarks/oob-sane-chain-contiguous.js: Added.
• microbenchmarks/oob-sane-chain-double-read-undefined.js: Added.
• microbenchmarks/oob-sane-chain-double.js: Added.
• microbenchmarks/oob-sane-chain-int32.js: Added.
• stress/oob-sane-chain-negative-index.js: Added.

Source/JavaScriptCore:

This patch adds a new ArrayMode speculation in the DFG/FTL called OutOfBoundsSaneChain.
It allows us to do fast things when we go OOB, like simply return undefined.
This is because we install watchpoints on the prototype chain to ensure they
have no indexed properties. This patch implements OutOfBoundsSaneChain on
GetByVal over Int32/Double/Contiguous original JS arrays. We can extend it in
the future to non original JS arrays if we prove their prototype is Array.prototype.
To implement this properly, we also need to ensure that the index isn't negative,
as Array.prototype/Object.prototype may have negative indexed accessors. We
do this via speculation, and if we ever recompile, and see an exit because of
this, we will stop speculating OutOfBoundsSaneChain.

This is about 20% faster on crypto-md5-SP. And ~3-4x faster on the
microbenchmarks I created.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine const):
(JSC::DFG::arraySpeculationToString):

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isInBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBoundsSaneChain const):
(JSC::DFG::ArrayMode::isOutOfBounds const):
(JSC::DFG::ArrayMode::isEffectfulOutOfBounds const):
(JSC::DFG::ArrayMode::isInBounds const):
(JSC::DFG::ArrayMode::isSaneChain const): Deleted.

• dfg/DFGCSEPhase.cpp:
• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::setSaneChainIfPossible):
(JSC::DFG::FixupPhase::convertToHasIndexedProperty):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileHasIndexedProperty):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):

2:54 PM Changeset in webkit [265774] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Avoid waiting for Launch Services on every load
​https://bugs.webkit.org/show_bug.cgi?id=215569

Reviewed by Darin Adler.

Currently, we are waiting for the Launch Services database to be present on every load in the WebContent process.
It should be sufficient to wait only on the first load. Since we now are waiting only once per WebContent process,
increase the maximum wait time from 1s to 5s.

No new tests, covered by existing tests.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::platformDidReceiveLoadParameters):

2:35 PM Changeset in webkit [265773] by Fujii Hironori

• 5 edits in trunk

[WTF] HashTable<Ref<K>, V>::HashTable(const HashTable& other) can't compile
​https://bugs.webkit.org/show_bug.cgi?id=215550

Reviewed by Darin Adler.

Source/WTF:

Even though the copy constructor takes a const HashTable
reference, RefHashTraits::assignToEmpty takes non-const Ref<P>. It
seems that RefHashTraits::assignToEmpty and
Ref::assignToHashTableEmptyValue are unnecessary. Just remove them.

• wtf/HashTraits.h:

(WTF::RefHashTraits::assignToEmpty): Deleted.

• wtf/Ref.h:

(WTF::Ref::assignToHashTableEmptyValue): Deleted.

Tools:

• TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

2:16 PM Changeset in webkit [265772] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS ] media/track/track-in-band-style.html is a flaky timeout and failure
​https://bugs.webkit.org/show_bug.cgi?id=215583

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

1:53 PM Changeset in webkit [265771] by Jonathan Bedard

• 5 edits in trunk/Tools

[resultsdbpy]: Depend on webkitcorepy
​https://bugs.webkit.org/show_bug.cgi?id=215573
<rdar://problem/67250272>

Reviewed by Dewei Zhu.

• Scripts/libraries/resultsdbpy/resultsdbpy/init.py:

(_maybe_add_webkitcorepy_path): Attempt to add. webkitcorepy to the. Python path.

• Scripts/libraries/resultsdbpy/setup.py: Add webkitcorepy, remove webkitcorepy's dependencies.
• Scripts/libraries/webkitcorepy/setup.py: Add six as a dependency.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Include. package name, bump version.

1:34 PM Changeset in webkit [265770] by Hector Lopez

• 3 edits in trunk/LayoutTests

[ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getStats.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215581

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

1:20 PM Changeset in webkit [265769] by Jonathan Bedard

• 3 edits
  2 adds in trunk/Tools

[webkitcorepy] Add OutputCapture to webkitcorepy
​https://bugs.webkit.org/show_bug.cgi?id=215380
<rdar://problem/66846384>

Reviewed by Dewei Zhu.

Although webkitpy has an OutputCapture class, that class does not separate logging from
stdout and stderr, which makes the API less useful. This version of the OutputCapture class
is inspired by the one in webkitpy, but with a cleaner interface.

• Scripts/libraries/webkitcorepy/README.md: Document usage of OutputCapture.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export LoggerCapture, OutputCapture and

OutputDuplicate as API, bump version.

• Scripts/libraries/webkitcorepy/webkitcorepy/output_capture.py: Added.

(LoggerCapture): Capture logs at some level for the duration of the interface.
(OutputCapture): Capture stdout, stderr and all logging channels for the duration of the interface.
(OutputCapture.ReplaceSysStream): Replace sys.stdout or sys.stderr for a block.
(OutputDuplicate): Context which can duplicate all output for a block of code. This is useful to both print and
capture logs.
(OutputDuplicate.Stream): File-like object that routes output to multiple file-like objects.

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/output_capture_unittest.py: Added.

(LoggerCaptureTest):
(OutputCaptureTest):
(OutputOutputDuplicateTest):

12:54 PM Changeset in webkit [265768] by Fujii Hironori

• 3 edits in trunk/Tools

[TestWebKitAPI] Some WTF_HashMap tests are failing if TestWTF is executed directly
​https://bugs.webkit.org/show_bug.cgi?id=215556

Reviewed by Darin Adler.

Some tests using RefLogger were failing if TestWTF is executed
directly without run-api-tests test driver script. Subsequent
tests were failing due to extra "deref(a) " which is a leftover of
the previous tests. Because run-api-tests is spawning a TestWTF
process for each test, it hides this issue.

• TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Added blocks or calling clear() method to destroy local variables and added more
EXPECT_STREQ("deref(a) ", takeLogStr().c_str()).

12:29 PM Changeset in webkit [265767] by Lauro Moura

• 2 edits in trunk/Tools

[WPE] Fix file url in WPEQt api test
​https://bugs.webkit.org/show_bug.cgi?id=215577

Reviewed by Philippe Normand.

The test expects the load to fail, so avoid ​file://foo.html resolving
to ​file:///.

• TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:

(TestLoadRequest::main):

12:29 PM Changeset in webkit [265766] by Jonathan Bedard

• 3 edits in trunk/Tools

[webkitcorepy] Autoinstaller is very slow in git-svn checkouts
​https://bugs.webkit.org/show_bug.cgi?id=215534
<rdar://problem/67120623>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Download packages to a temporary directory so that setup.py runs faster.

12:14 PM Changeset in webkit [265765] by Chris Dumez

• 6 edits in trunk

WaveShaperNode should not output silence when it has no input or when input is silence
​https://bugs.webkit.org/show_bug.cgi?id=215574

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline existing test now that all checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs-expected.txt:

Source/WebCore:

WaveShaperNode should not output silence when it has no input or when input is silence.
It should still apply its curve to the silent input.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
Do not disable the WaveShaperNode's output when its has no input. The WaveShaperNode
may still provide non-silent output when it has no input.

• Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::propagatesSilence const):

• Modules/webaudio/WaveShaperNode.h:

Override propagatesSilence() to return false when the WaveShaperNode has a curve to apply,
so that we ask the node to process the input even when it is silence.

12:08 PM Changeset in webkit [265764] by Russell Epstein

• 6 edits
  3 deletes in branches/safari-610.1-branch

Revert "Cherry-pick r265603. rdar://problem/67084483"

This reverts commit r265700.

12:00 PM Changeset in webkit [265763] by Russell Epstein

• 31 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265725. rdar://problem/67260862

Convert remaining SharedMemory::Handle to SharedMemory::IPCHandle
​https://bugs.webkit.org/show_bug.cgi?id=215471
<rdar://problem/67024177>

Reviewed by David Kilzer.

Use the new struct for sending SharedMemory::Handle objects via IPC, so
we can include the exact size of data (SharedMemory::Handle::size()
rounds up to the nearest page), and verify these sizes match when decoding.

In many cases, the size is not sent as a separate argument via IPC, so
we can initialize the IPCHandle object with SharedMemory::Handle::size().

We can remove the additional size parameter when it exists, because
we are now passing IPCHandle which should include the size value.

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.messages.in:
• GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
• GPUProcess/webrtc/RemoteMediaRecorder.h:
• GPUProcess/webrtc/RemoteMediaRecorder.messages.in: Send SharedMemory::IPCHandle object instead of SharedMemory::Handle over IPC.

• NetworkProcess/ServiceWorker/WebSWOriginStore.cpp: (WebKit::WebSWOriginStore::sendStoreHandle): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.

• Platform/SharedMemory.h: Remove encode/decode functions in SharedMemory::Handle.

• Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted.
• Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
• Platform/win/SharedMemoryWin.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): (WebKit::SharedMemory::Handle::encode const): Deleted. (WebKit::SharedMemory::Handle::decode): Deleted. Remove SharedMemory::Handle encode/decode functions so we will not ever send a SharedMemory::Handle object over IPC accidentally in the future.

• Shared/ShareableBitmap.cpp: (WebKit::ShareableBitmap::Handle::encode const): (WebKit::ShareableBitmap::Handle::decode): Keep m_size here because it is an IntSize object and is useful to check width/height parameters in the SharableBitmap object.

• Shared/ShareableResource.cpp: (WebKit::ShareableResource::Handle::encode const): (WebKit::ShareableResource::Handle::decode):
• Shared/WebCompiledContentRuleListData.cpp: (WebKit::WebCompiledContentRuleListData::encode const): (WebKit::WebCompiledContentRuleListData::decode):
• Shared/WebCoreArgumentCoders.cpp: (IPC::encodeSharedBuffer): (IPC::decodeSharedBuffer):
• Shared/WebHitTestResultData.cpp: (WebKit::WebHitTestResultData::encode const): (WebKit::WebHitTestResultData::decode): More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
• UIProcess/VisitedLinkStore.cpp: (WebKit::VisitedLinkStore::sendStoreHandleToProcess):
• WebProcess/GPU/media/RemoteAudioBusData.h: (WebKit::RemoteAudioBusData::encode const): (WebKit::RemoteAudioBusData::decode): Since no additional size parameter is being sent in this function, we can use handle.size() as the IPCHandle::dataSize parameter.

• WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp: (WebKit::AudioMediaStreamTrackRenderer::storageChanged):
• WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp: (WebKit::MediaRecorderPrivate::storageChanged):
• WebProcess/Storage/WebSWClientConnection.cpp: (WebKit::WebSWClientConnection::setSWOriginTableSharedMemory):
• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:
• WebProcess/WebPage/VisitedLinkTableController.cpp: (WebKit::VisitedLinkTableController::setVisitedLinkTable):
• WebProcess/WebPage/VisitedLinkTableController.h:
• WebProcess/WebPage/VisitedLinkTableController.messages.in:
• WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::audioStorageChanged):
• WebProcess/cocoa/RemoteCaptureSampleManager.h:
• WebProcess/cocoa/RemoteCaptureSampleManager.messages.in: More cases of converting between SharedMemory::Handle and SharedMemory::IPCHandle when encoding/decoding.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:00 PM Changeset in webkit [265762] by Russell Epstein

• 5 edits in branches/safari-610.1-branch/Source/WebKit

Cherry-pick r265638. rdar://problem/67260815

Create SharedMemory::IPCHandle object to validate the size of SharedMemory::Handle objects sent over IPC
​https://bugs.webkit.org/show_bug.cgi?id=215288
<rdar://problem/60870795>

Reviewed by David Kilzer.

Part 1 of a multi-patch plan to convert all SharedMemory::Handle
objects being sent over IPC to use SharedMemory::IPCHandle objects instead.

• Platform/SharedMemory.h: (WebKit::SharedMemory::IPCHandle::IPCHandle):
• Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode): Validate the size of the data sent in the IPCHandle::decode() function.
• Platform/unix/SharedMemoryUnix.cpp: (WebKit::SharedMemory::IPCHandle::encode const): (WebKit::SharedMemory::IPCHandle::decode):
• Platform/win/SharedMemoryWin.cpp: Implement IPCHandle encode and decode for all platforms for when we remove SharedMemory::Handle encode/decode functions.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:51 AM Changeset in webkit [265761] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

[Mac] Add Experimental Feature preference for SW VP9
​https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Darin Adler.

Follow up fix: during a rebase, a line deletion was dropped which causes the SW decoder to
always be registered regardless of the new setting.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::enableVP9Decoder):
(WebKit::WebProcess::enableVP9SWDecoder):

10:35 AM Changeset in webkit [265760] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] media/modern-media-controls/volume-up-support/volume-up-support.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215576

Unreviewed test gardening.

• platform/mac/TestExpectations:

10:26 AM Changeset in webkit [265759] by youenn@apple.com

• 2 edits in trunk/Source/WTF

Bump HAVE_NSURLSESSION_WEBSOCKET requirement to BigSur for MacOS
​https://bugs.webkit.org/show_bug.cgi?id=215517

Reviewed by Alex Christensen.

Catalina NSURLSession WebSocket is missing some features we need.
Bump it to Big Sur.

• wtf/PlatformHave.h:

10:07 AM Changeset in webkit [265758] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Remove message check in WebSocketTask::readNextMessage
​https://bugs.webkit.org/show_bug.cgi?id=215561

Reviewed by Alex Christensen.

This if check was added as a workaround to cases where both error and message were null.
This is no longer the case as per running existing tests with NSURLSession WebSocket code path on BigSur.

• NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::readNextMessage):

10:03 AM Changeset in webkit [265757] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Remove Cocoa WebSocketTask::send workaround
​https://bugs.webkit.org/show_bug.cgi?id=215564

Reviewed by Alex Christensen.

Covered by existing tests run in Debug.

• NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::sendString):
(WebKit::WebSocketTask::sendData):

9:33 AM Changeset in webkit [265756] by ddkilzer@apple.com

• 10 edits in trunk/Source

Clean up DragApplicationFlags after switch to OptionSet<>
<​https://webkit.org/b/215349>

Reviewed by Darin Adler.

Change WebCore::DragApplicationFlags to an enum class.

Source/WebCore:

No new tests since no change in behavior.

• page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::isCopyKeyDown):

• page/mac/DragControllerMac.mm:

(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):

• platform/DragData.h:

Source/WebKit:

• UIProcess/API/gtk/DropTargetGtk3.cpp:

(WebKit::DropTarget::drop):

• Switch to use OptionSet<WebCore::DragApplicationFlags>.
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::applicationFlagsForDrag):

• WebProcess/WebPage/WebPage.h:
• Update forward declaration.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView applicationFlags:]): Deleted.
(-[WebView _applicationFlagsForDrag:]):

• Rename -applicationFlags: to -_applicationFlagsForDrag: since it's only used internally.
• Switch to return OptionSet<WebCore::DragApplicationFlags>.

(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

• Switch to calling -_applicationFlagsForDrag:.

7:06 AM Changeset in webkit [265755] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po

Merge r265754 - [GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
​https://bugs.webkit.org/show_bug.cgi?id=215547

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.

• pl.po:

7:05 AM Changeset in webkit [265754] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK][l10n] Updated Polish translation of WebKitGTK for 2.30
​https://bugs.webkit.org/show_bug.cgi?id=215547

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2020-08-17
Rubber-stamped by Carlos Garcia Campos.

• pl.po:

5:41 AM Changeset in webkit [265753] by Carlos Garcia Campos

• 41 edits
  12 deletes in trunk

[GTK][WPE] Remove support for NPAPI plugins
​https://bugs.webkit.org/show_bug.cgi?id=215503

Reviewed by Darin Adler.

.:

• Source/cmake/OptionsGTK.cmake:

Source/WebKit:

• PlatformGTK.cmake:
• PluginProcess/unix/PluginControllerProxyUnix.cpp: Removed.
• PluginProcess/unix/PluginProcessMainUnix.cpp: Removed.
• PluginProcess/unix/PluginProcessUnix.cpp: Removed.
• Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: Removed.
• Shared/Plugins/unix/PluginSearchPath.cpp: Removed.
• Shared/Plugins/unix/PluginSearchPath.h: Removed.
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/glib/WebKitMimeInfo.cpp:

(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type):
(webkit_mime_info_get_description):
(webkit_mime_info_get_extensions):

• UIProcess/API/glib/WebKitMimeInfoPrivate.h: Removed.
• UIProcess/API/glib/WebKitPlugin.cpp:

(webkit_plugin_get_name):
(webkit_plugin_get_description):
(webkit_plugin_get_path):
(webkit_plugin_get_mime_info_list):

• UIProcess/API/glib/WebKitPluginPrivate.h: Removed.
• UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_plugins):
(webkit_settings_set_enable_plugins):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_additional_plugins_directory):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewLoadFail):

• UIProcess/API/glib/WebKitWebsiteData.cpp:

(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(toWebsiteDataTypes):

• UIProcess/API/gtk/WebKitError.h:
• UIProcess/API/gtk/WebKitMimeInfo.h:
• UIProcess/API/gtk/WebKitPlugin.h:
• UIProcess/API/gtk/WebKitSettings.h:
• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/WebKitWebsiteData.h:
• UIProcess/API/wpe/WebKitError.h:
• UIProcess/API/wpe/WebKitMimeInfo.h:
• UIProcess/API/wpe/WebKitPlugin.h:
• UIProcess/API/wpe/WebKitSettings.h:
• UIProcess/API/wpe/WebKitWebContext.h:
• UIProcess/API/wpe/WebKitWebsiteData.h:
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Plugins/gtk/PluginInfoCache.cpp: Removed.
• UIProcess/Plugins/gtk/PluginInfoCache.h: Removed.
• UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp: Removed.
• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp: Removed.
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/gtk/WebPageProxyGtk.cpp:
• WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Removed.
• WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Removed.
• WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp: Removed.
• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Removed.
• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Removed.
• WebProcess/Plugins/PluginController.h:
• WebProcess/Plugins/PluginView.cpp:
• WebProcess/Plugins/PluginView.h:

Tools:

• PlatformGTK.cmake:
• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(beforeAll):

LayoutTests:

Skip tests using plugins and remove expectations.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/accessibility/plugin-expected.txt: Removed.
• platform/gtk/http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Removed.
• platform/gtk/plugins/document-open-expected.txt: Removed.
• platform/gtk/plugins/embed-attributes-style-expected.png: Removed.
• platform/gtk/plugins/embed-attributes-style-expected.txt: Removed.
• platform/gtk/plugins/iframe-plugin-bgcolor-expected.png: Removed.
• platform/gtk/plugins/invalidate-rect-with-null-npp-argument-expected.txt: Removed.
• platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html: Removed.
• platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.png: Removed.
• platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt: Removed.
• platform/gtk/plugins/nested-plugin-objects-expected.txt: Removed.
• platform/gtk/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
• platform/gtk/plugins/netscape-dom-access-expected.png: Removed.
• platform/gtk/plugins/netscape-dom-access-expected.txt: Removed.
• platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Removed.
• platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Removed.
• platform/gtk/plugins/plugin-clip-subframe-expected.txt: Removed.
• platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Removed.
• platform/gtk/plugins/plugin-javascript-access-expected.txt: Removed.
• platform/gtk/plugins/resize-from-plugin-expected.txt: Removed.
• platform/wpe/TestExpectations:

5:21 AM Changeset in webkit [265752] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Set Sec-WebSocket-Protocol for WebSocket NSURLSession code path
​https://bugs.webkit.org/show_bug.cgi?id=215456
<rdar://problem/66996369>

Reviewed by Alex Christensen.

Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/set-protocol.html, http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html
Code change originating from Jiten Mehta.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):
Set Sec-WebSocket-Protocol to support WebSocket protocol negotiation.

4:04 AM Changeset in webkit [265751] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

REGRESSION(r265725) [GTK][WPE] Several http/tests timeout/failures
​https://bugs.webkit.org/show_bug.cgi?id=215542

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-17
Reviewed by Sergio Villar Senin.

The problem is that ShareableResource is now using the dataSize member of IPCHandle to encode/decode the
resource size, but SharedMemoryUnix is not encoding/decoding dataSize.

• Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):

12:38 AM Changeset in webkit [265750] by youenn@apple.com

• 2 edits in trunk/Tools

Update W3C test exporter to use Authorisation header instead of query parameter to validate GitHub account
​https://bugs.webkit.org/show_bug.cgi?id=215548

Reviewed by Darin Adler.

• Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter._validate_and_save_token):
access_token query parameter is dbeing deprecated in favor of Authorization header.
Update script accordingly.

12:37 AM Changeset in webkit [265749] by ysuzuki@apple.com

• 74 edits
  2 adds in trunk

JSDOMConstructorNotConstructable should be a constructor
​https://bugs.webkit.org/show_bug.cgi?id=215554
<rdar://problem/65770688>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/send-file-form-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-baseURL.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disabled-regular-sheet-insertion-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-disallow-import.tentative-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-duplicate-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-constructable-expected.txt:
• web-platform-tests/css/cssom/CSSStyleSheet-modify-after-removal-expected.txt:
• web-platform-tests/custom-elements/Document-createElement-expected.txt:
• web-platform-tests/custom-elements/Document-createElementNS-expected.txt:
• web-platform-tests/custom-elements/HTMLElement-attachInternals-expected.txt:
• web-platform-tests/custom-elements/HTMLElement-constructor-expected.txt:
• web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• web-platform-tests/custom-elements/customized-built-in-constructor-exceptions-expected.txt:
• web-platform-tests/custom-elements/htmlconstructor/newtarget-expected.txt:
• web-platform-tests/custom-elements/parser/serializing-html-fragments-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLAreaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLBaseElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLButtonElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLCanvasElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLDataElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLDetailsElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLEmbedElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLFieldSetElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLImageElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLLIElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLLabelElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMapElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMediaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMetaElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLMeterElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLModElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLOListElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLOptGroupElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLParamElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLProgressElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLQuoteElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLSlotElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLStyleElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTableCellElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTableColElement-expected.txt:
• web-platform-tests/custom-elements/reactions/HTMLTimeElement-expected.txt:
• web-platform-tests/custom-elements/upgrading/Document-importNode-expected.txt:
• web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:
• web-platform-tests/dom/nodes/Node-appendChild-cereactions-vs-script.window-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
• web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:
• web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
• web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
• web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
• web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
• web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
• web-platform-tests/webrtc/RTCIceTransport-extension.https-expected.txt:

Source/WebCore:

Test: js/dom/window-is-constructor.html

While JSDOMConstructorNotConstructable throws an error, still it should be a constructor, which means,
IsConstructor(JSDOMConstructorNotConstructable) should be true. To fix it, we add getConstructData
which configures a function throwing an error.

• bindings/js/JSDOMConstructorNotConstructable.h:

LayoutTests:

• editing/async-clipboard/clipboard-interfaces-expected.txt:
• editing/undo-manager/undo-manager-interfaces-expected.txt:
• fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
• http/wpt/html/browsers/the-window-object/window-is-constructor-expected.txt: Added.
• http/wpt/html/browsers/the-window-object/window-is-constructor.html: Added.
• js/interface-objects-expected.txt:
• performance-api/paint-timing/paint-timing-apis-expected.txt:
• performance-api/performance-observer-api-expected.txt:
• performance-api/performance-timeline-api-expected.txt:
• performance-api/resource-timing-apis-expected.txt:
• performance-api/user-timing-apis-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLInputElement-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/custom-elements/builtin-coverage-expected.txt:

12:31 AM Changeset in webkit [265748] by youenn@apple.com

• 5 edits in trunk

Make sure writableStreamDefaultWriterEnsureClosedPromiseRejected overwrite the closedPromise if needed
​https://bugs.webkit.org/show_bug.cgi?id=215540

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/streams/writable-streams/aborting.any-expected.txt:
• web-platform-tests/streams/writable-streams/aborting.any.worker-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/streams/WritableStreamInternals.js:

(writableStreamDefaultWriterEnsureClosedPromiseRejected):
As per spec, if promise is already settled, we overwrite it to reject it.

12:26 AM Changeset in webkit [265747] by youenn@apple.com

• 6 edits in trunk

Check WritableStream underlyingSink methods
​https://bugs.webkit.org/show_bug.cgi?id=215539

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/streams/writable-streams/bad-underlying-sinks.any-expected.txt:
• web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.js:

(test):

• web-platform-tests/streams/writable-streams/bad-underlying-sinks.any.worker-expected.txt:

Source/WebCore:

Covered by updated tests.

• Modules/streams/WritableStream.js:

(initializeWritableStream):