Timeline



Aug 24, 2020:

11:15 PM Changeset in webkit [266103] by Carlos Garcia Campos
  • 6 edits in trunk/Source

[GTK] Implement rendering frames timeline panel for GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=150392
<rdar://problem/23200510>

Reviewed by Brian Burg.

Source/WebCore:

Use new RunLoop API to observe the run loop events when the GLib event loop is used.

  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):

  • inspector/agents/InspectorTimelineAgent.h:

Source/WTF:

Add API to observe RunLoop events for GLib event loop implementation.

  • wtf/RunLoop.h:
  • wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop): Use RunLoopSource struct and initialize the RunLoop.
(WTF::RunLoop::observe): Add the given observer to the set.
(WTF::RunLoop::notify): Notife observers of the given event.
(WTF::RunLoop::TimerBase::TimerBase): Use RunLoopSource struct and initialize the RunLoop.

10:04 PM Changeset in webkit [266102] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix TLSVersion.DefaultBehavior on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=215791

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave.
Enable it for newer OSes.

9:32 PM Changeset in webkit [266101] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG should always run CFG Simplification after Constant Folding.
​https://bugs.webkit.org/show_bug.cgi?id=215286

Reviewed by Robin Morisset.

We didn't do this originally because LICM, many years ago, was
unsound if the CFG didn't have exactly the right shape around
loops. This is no longer true so we don't have to worry about
changing the CFG anymore. While, this doesn't appear to be a
speedup on JetStream 2 CFG, probably because we'd eventually
simplify the graph in B3, CFG Simplification is very cheap and
make other DFG optimizations easier in the future.

Also, remove unecessary validation rule that no exitOKs can come
before any Phi nodes in DFG. This isn't required and fails after
merging two basic blocks where the latter block has a Phi.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGValidate.cpp:
8:36 PM Changeset in webkit [266100] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Make TLSVersion.DefaultBehavior more robust
​https://bugs.webkit.org/show_bug.cgi?id=215791

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/cocoa/HTTPServer.h:
  • TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
(TestWebKitAPI::HTTPServer::respondWithOK):

7:44 PM Changeset in webkit [266099] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called,

instead of when deciding to dispatch to the main thread.

(WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch

to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread.

(WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when
(WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is

safe to do after destroy(), up until the very end when we get into pluginView() derefencing.
So it seems prudent to add another check here.

(WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and

adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument,
so for added coverage it seems like a prudent place to add the check.

7:03 PM Changeset in webkit [266098] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Update iOS layout test results after r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

  • web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt:

Apparently there's a newly passing test here, too.
I wonder why macOS isn't affected by this change.

7:00 PM Changeset in webkit [266097] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.

6:53 PM Changeset in webkit [266096] by mmaxfield@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

  • platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.
6:51 PM Changeset in webkit [266095] by keith_miller@apple.com
  • 22 edits
    2 deletes in trunk/Source/JavaScriptCore

Remove MovHintRemoval phase
​https://bugs.webkit.org/show_bug.cgi?id=215785

Reviewed by Saam Barati.

The MovHintRemoval phase doesn't play nicely with our OSR
Availability. Specifically, it needs to do a tricky dance where it
marks all the live ranges of the ZombieHints as not
exitOK. There's also an issue because we treated unused locals as
kill in this block, which is wrong for SSA when a MovHint is
used in another block. Since removing MovHintRemoval isn't a
performance regression, we are removing it rather than fixing bugs
related to it. Relatedly, since the only place we produce
ZombieHints is MovHintRemoval this patch also removes that node
type.

  • Sources.txt:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGMovHintRemovalPhase.cpp: Removed.
  • dfg/DFGMovHintRemovalPhase.h: Removed.
  • dfg/DFGNode.h:

(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::hasUnlinkedOperand):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGPhantomInsertionPhase.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVarargsForwardingPhase.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):

  • runtime/OptionsList.h:
5:36 PM Changeset in webkit [266094] by Hector Lopez
  • 5 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

  • TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
5:26 PM Changeset in webkit [266093] by Alan Coon
  • 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.3

5:14 PM Changeset in webkit [266092] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

  • platform/ios-13/TestExpectations:
5:05 PM Changeset in webkit [266091] by keith_miller@apple.com
  • 5 edits
    11 adds in trunk/JSTests

Update test262 (mid Aug 2020 edition)
​https://bugs.webkit.org/show_bug.cgi?id=215784

Rubber-stamped by Saam Barati and Yusuke Suzuki.

  • test262/expectations.yaml:
  • test262/latest-changes-summary.txt:
  • test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):
(nonNumberableLimit.Symbol.toPrimitive):

  • test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.toString):

  • test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js:
  • test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableReceiver.toString):
(splitter.Symbol.split):
(catch):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):

  • test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js: Added.

(A):
(export.default.async A):

  • test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js: Added.

(export.default.async A):

  • test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js: Added.

(AG):
(export.default.async AG):

  • test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js: Added.

(export.default.async AG):

  • test262/test/language/module-code/export-default-function-declaration-binding-exists.js: Added.

(F):
(export.default.F):

  • test262/test/language/module-code/export-default-function-declaration-binding.js: Added.

(export.default.F):

  • test262/test/language/module-code/export-default-generator-declaration-binding-exists.js: Added.

(G):
(export.default.G):

  • test262/test/language/module-code/export-default-generator-declaration-binding.js: Added.

(export.default.G):

  • test262/test262-Revision.txt:
3:48 PM Changeset in webkit [266090] by Wenson Hsieh
  • 4 edits in trunk

Unreviewed, fix the internal iOS 13.4 build

Source/WebKit:

The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a
problem when building with a non-internal SDK since the SPI is declared in the !USE(APPLE_INTERNAL_SDK)
section in UIKitSPI.h, but on internal builds of iOS 13.4, this declaration is absent from both the internal
SDK and UIKitSPI.h.

To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target,
this can be moved back into the non-internal section only.

  • Platform/spi/ios/UIKitSPI.h:

Tools:

See Source/WebKit/ChangeLog.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::clipSelectionViewRectToContentView):

3:46 PM Changeset in webkit [266089] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] enable email notifications to patch authors for build or layout test failures on their patch
​https://bugs.webkit.org/show_bug.cgi?id=215776

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch.
(AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure.

3:45 PM Changeset in webkit [266088] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews] set references header in email so as to group similar emails together
​https://bugs.webkit.org/show_bug.cgi?id=215777

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/send_email.py:

(send_email): Add support for setting references header.
(send_email_to_patch_author):
(send_email_to_bot_watchers):

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Set references header appropriately.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:36 PM Changeset in webkit [266087] by commit-queue@webkit.org
  • 34 edits in trunk

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/abort/general.any-expected.txt:
  • web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
  • web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

  • web-platform-tests/fetch/api/request/request-consume-expected.txt:
  • web-platform-tests/fetch/api/request/request-init-002-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

  • web-platform-tests/fetch/api/response/response-consume-expected.txt:
  • web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt:

This change makes the formData failures in this file look like all the other failures in this file,
which should be fixed together in a separate patch.

  • web-platform-tests/fetch/api/response/response-init-002-expected.txt:
  • web-platform-tests/url/urlencoded-parser.any-expected.txt:
  • web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::formData):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeFormData):

  • Modules/fetch/FetchBody.h:
  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::formDataFromData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):

  • Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

  • WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish):
Add a fast path that allows non-blob FormData responses from service workers to not hang.
This part is covered by this layout test:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

  • wtf/text/WTFString.cpp:

(WTF::fromUTF8Helper):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8ReplacingInvalidSequences):

  • wtf/text/WTFString.h:
  • wtf/unicode/UTF8Conversion.cpp:

(WTF::Unicode::convertUTF8ToUTF16Impl):
(WTF::Unicode::convertUTF8ToUTF16):
(WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):

  • wtf/unicode/UTF8Conversion.h:
2:41 PM Changeset in webkit [266086] by commit-queue@webkit.org
  • 24 edits in trunk/Source

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
​https://bugs.webkit.org/show_bug.cgi?id=213048

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession.
To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and
WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838.

I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS
state querying and removal works with the new CFNetwork SPI as it did with the old one.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

  • NetworkProcess/NetworkSessionCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::hstsStorage const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession): Deleted.
(WebKit::WebProcessPool::resetHSTSHosts): Deleted.
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted.

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const):

  • UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy const):

  • UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

Source/WTF:

  • wtf/PlatformHave.h:
2:35 PM Changeset in webkit [266085] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215783

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
2:06 PM Changeset in webkit [266084] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Disable unused RPC services
​https://bugs.webkit.org/show_bug.cgi?id=215779

Reviewed by Alexey Proskuryakov.

  • .htaccess:
12:26 PM Changeset in webkit [266083] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=215778

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
12:17 PM Changeset in webkit [266082] by emilio
  • 12 edits in trunk

Support quotes:auto and fix quotes serialization.
​https://bugs.webkit.org/show_bug.cgi?id=215646

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-content/inheritance-expected.txt: Annotate progression.
  • web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-content/inheritance.html

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::Ref<CSSValue>valueForQuotes):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeQuotes):

  • rendering/style/QuotesData.h:

(WebCore::QuotesData::size const):

  • style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertQuotes):

LayoutTests:

  • platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Annotate progression.
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.
  • platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.
11:57 AM Changeset in webkit [266081] by Russell Epstein
  • 8 edits in trunk/Source

Versioning.

WebKit-7611.1.1

11:53 AM Changeset in webkit [266080] by Jonathan Bedard
  • 4 edits in trunk/Tools

[resultsdbpy] Fix pip package
​https://bugs.webkit.org/show_bug.cgi?id=215721
<rdar://problem/67518275>

Reviewed by Dewei Zhu.

  • Scripts/libraries/resultsdbpy/MANIFEST.in: Add html and css.
  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Include submodules.
  • Scripts/libraries/resultsdbpy/setup.py: Version bump.
11:44 AM Changeset in webkit [266079] by Russell Epstein
  • 1 copy in branches/safari-610-branch

New branch.

11:44 AM Changeset in webkit [266078] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=214997

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:40 AM Changeset in webkit [266077] by Devin Rousso
  • 27 edits
    7 moves in trunk/Source

Web Inspector: rename ScriptDebugServer subclasses/methods
​https://bugs.webkit.org/show_bug.cgi?id=215363
<rdar://problem/67310441>

Reviewed by Brian Burg.

r266074 merged Inspector::ScriptDebugServer into JSC::Debugger. All subclasses and
functions should be renamed to match this change.

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectDebugger.h: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.h.
  • inspector/JSGlobalObjectDebugger.cpp: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.cpp.
  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:
  • inspector/agents/InspectorAuditAgent.h:
  • inspector/agents/InspectorAuditAgent.cpp:
  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:
  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/InspectorRuntimeAgent.cpp:
  • inspector/agents/InspectorScriptProfilerAgent.cpp:
  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
  • inspector/remote/RemoteInspectionTarget.cpp:
  • inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

Source/WebCore:

  • Headers.cmake:
  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.h:
  • inspector/InspectorController.cpp:
  • inspector/PageDebugger.h: Renamed from Source/WebCore/inspector/PageScriptDebugServer.h.
  • inspector/PageDebugger.cpp: Renamed from Source/WebCore/inspector/PageScriptDebugServer.cpp.
  • inspector/mac/PageDebuggerMac.mm: Renamed from Source/WebCore/inspector/mac/PageScriptDebugServerMac.mm.
  • inspector/WorkerDebugger.h: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.h.
  • inspector/WorkerDebugger.cpp: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.cpp.
  • inspector/WorkerInspectorController.h:
  • inspector/WorkerInspectorController.cpp:
  • inspector/agents/InspectorTimelineAgent.cpp:
  • inspector/agents/page/PageDebuggerAgent.cpp:
11:13 AM Changeset in webkit [266076] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
​https://bugs.webkit.org/show_bug.cgi?id=205826

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WI.loaded):

11:06 AM Changeset in webkit [266075] by sihui_liu@apple.com
  • 4 edits in trunk

Source/WebCore:
Text manipulation should not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

TextManipulationController currently does not set correct start path for insertion. Therefore, it does not mark
the nodes on the start path but out of range correctly, and may change position of those nodes by mistake. For
example, in the newly added test, text node "zero" can be moved around even though it is not in range.

API test: TextManipulation.CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange

  • editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace):

Tools:
Text manipulationshould not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

  • TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

10:34 AM Changeset in webkit [266074] by Devin Rousso
  • 107 edits
    1 copy
    3 adds
    4 deletes in trunk

Web Inspector: allow event breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215362
<rdar://problem/66932921>

Reviewed by Brian Burg.

Source/JavaScriptCore:

This allows developers to do things like:

  • only pause when window.event.type is a certain value
  • ignore the first N pauses
  • evaluate JavaScript whenever an event listener is invoked without pausing
  • inspector/protocol/DOM.json:

Add an options paramater to DOM.setBreakpointForEventListener to allow configuration.

  • inspector/protocol/DOMDebugger.json:

Add an options paramater to DOMDebugger.setEventBreakpoint to allow configuration.

  • debugger/Breakpoint.h:

(JSC::Breakpoint::id const): Added.
(JSC::Breakpoint::sourceID const): Added.
(JSC::Breakpoint::lineNumber const): Added.
(JSC::Breakpoint::columnNumber const): Added.
(JSC::Breakpoint::condition const): Added.
(JSC::Breakpoint::actions const): Added.
(JSC::Breakpoint::isAutoContinue const): Added.
(JSC::Breakpoint::resetHitCount): Added.
(JSC::Breakpoint::isLinked const): Added.
(JSC::Breakpoint::isResolved const): Added.
(JSC::BreakpointsList::~BreakpointsList): Deleted.

  • debugger/Breakpoint.cpp: Added.

(JSC::Breakpoint::Action::Action): Added.
(JSC::Breakpoint::create): Added.
(JSC::Breakpoint::Breakpoint): Added.
(JSC::Breakpoint::link): Added.
(JSC::Breakpoint::resolve): Added.
(JSC::Breakpoint::shouldPause): Added.
Unify JSC::Breakpoint and Inspector::ScriptBreakpoint.

  • debugger/DebuggerPrimitives.h:
  • debugger/Debugger.h:
  • debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::addObserver): Added.
(JSC::Debugger::removeObserver): Added.
(JSC::Debugger::canDispatchFunctionToObservers const): Added.
(JSC::Debugger::dispatchFunctionToObservers): Added.
(JSC::Debugger::sourceParsed): Added.
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::applyBreakpoints):
(JSC::Debugger::resolveBreakpoint):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::didHitBreakpoint): Added.
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::evaluateBreakpointCondition): Added.
(JSC::Debugger::evaluateBreakpointActions): Added.
(JSC::Debugger::schedulePauseAtNextOpportunity): Added.
(JSC::Debugger::cancelPauseAtNextOpportunity): Added.
(JSC::Debugger::schedulePauseForSpecialBreakpoint): Added.
(JSC::Debugger::cancelPauseForSpecialBreakpoint): Added.
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepNextExpression):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::handlePause): Added.
(JSC::Debugger::exceptionOrCaughtValue): Added.
(JSC::Debugger::atExpression):
(JSC::Debugger::clearNextPauseState):
(JSC::Debugger::willRunMicrotask): Added.
(JSC::Debugger::didRunMicrotask): Added.
(JSC::Debugger::hasBreakpoint): Deleted.
(JSC::Debugger::setPauseOnNextStatement): Deleted.
Unify JSC::Debugger and Inspector::ScriptDebugServer to simplify breakpoint logic.
Introduce the concept of a "special breakpoint", which is essentially a JSC::Breakpoint
that is expected to pause at the next opportunity but isn't tied to a particular location.
As an example, whenever an event breakpoint is hit, instead of just pausing at the next
opportunity, the newly managed JSC::Breakpoint is used as a "special breakpoint", allowing
for it's configuration (ie.g. condition, ignore count, actions, auto-continue) to be used.

  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::objectGroupForBreakpointAction):
(Inspector::breakpointActionTypeForString): Added.
(Inspector::parseBreakpointOptions): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::fromPayload): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::ProtocolBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::createDebuggerBreakpoint const): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::matchesScriptURL const): Added.
(Inspector::InspectorDebuggerAgent::debuggerBreakpointFromPayload): Added.
(Inspector::InspectorDebuggerAgent::enable):
(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::buildDebuggerLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::didSetBreakpoint):
(Inspector::InspectorDebuggerAgent::resolveBreakpoint):
(Inspector::InspectorDebuggerAgent::removeBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::schedulePauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::pause):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::didBecomeIdle):
(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionSound):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):
(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::matches): Deleted.
(Inspector::buildObjectForBreakpointCookie): Deleted.
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol): Deleted.
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement): Deleted.
(Inspector::InspectorDebuggerAgent::cancelPauseOnNextStatement): Deleted.
Create a private ProtocolBreakpoint class that holds the data sent by the frontend. This
is necessary because breakpoints in the frontend have a potentially one-to-many relationship
with breakpoints in the backend, as the same script can be loaded many times on a page. Each
of those scripts is independent, however, and can execute differently, meaning that the same
breakpoint for each script also needs a different state (e.g. ignore count). As such, the
ProtocolBreakpoint is effectively a template that is actualized whenever a new script is
parsed that matches the URL of the ProtocolBreakpoint to create a JSC::Breakpoint that
is used by the JSC::Debugger. ProtocolBreakpoint also parses breakpoint configurations.

  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectScriptDebugServer.h:
  • inspector/JSGlobalObjectScriptDebugServer.cpp:

(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::attachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::detachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):

  • inspector/agents/InspectorAuditAgent.h:
  • inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::setPauseOnExceptionsState):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):

  • inspector/agents/InspectorScriptProfilerAgent.cpp:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:

Replace Inspector::ScriptDebugServer with JSC::Debugger.

  • runtime/JSMicrotask.cpp:

(JSC::JSMicrotask::run):
Drive-by: r248894 mistakenly omitted the call to notify the debugger that the microtask ran.

  • inspector/ScriptBreakpoint.h: Removed.
  • inspector/ScriptDebugListener.h: Removed.
  • inspector/ScriptDebugServer.h: Removed.
  • inspector/ScriptDebugServer.cpp: Removed.
  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:

Source/WebCore:

This allows developers to do things like:

  • only pause when window.event.type is a certain value
  • ignore the first N pauses
  • evaluate JavaScript whenever an event listener is invoked without pausing

Tests: inspector/dom/breakpoint-for-event-listener.html

inspector/dom-debugger/event-animation-frame-breakpoints.html
inspector/dom-debugger/event-interval-breakpoints.html
inspector/dom-debugger/event-listener-breakpoints.html
inspector/dom-debugger/event-timeout-breakpoints.html

  • inspector/agents/InspectorDOMAgent.h:
  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setBreakpointForEventListener):
(WebCore::InspectorDOMAgent::removeBreakpointForEventListener):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::breakpointForEventListener):
(WebCore::InspectorDOMAgent::hasBreakpointForEventListener): Deleted.

  • inspector/agents/InspectorDOMDebuggerAgent.h:
  • inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::mainFrameNavigated):
(WebCore::InspectorDOMDebuggerAgent::setEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::didHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::willFireTimer):
(WebCore::InspectorDOMDebuggerAgent::didFireTimer):

  • inspector/agents/page/PageDOMDebuggerAgent.h:
  • inspector/agents/page/PageDOMDebuggerAgent.cpp:

(WebCore::PageDOMDebuggerAgent::disable):
(WebCore::PageDOMDebuggerAgent::mainFrameNavigated):
(WebCore::PageDOMDebuggerAgent::willFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::didFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::setAnimationFrameBreakpoint):

  • inspector/agents/worker/WorkerDOMDebuggerAgent.h:
  • inspector/agents/worker/WorkerDOMDebuggerAgent.cpp:

(WebCore::WorkerDOMDebuggerAgent::setAnimationFrameBreakpoint):
Keep a JSC::Breakpoint for each event breakpoint instead of a simple bool, allowing for
configuration when the breakpoint is first set. When any of these breakpoints are hit, pass
it to the JSC::Debugger as a "special breakpoint", which behaves the same as "pause ASAP"
but also supports a condition, an ignore count, actions, and auto-continue. Reset the hit
count for any of these "special breakpoints" that persist across Web Inspector sessions
when the main frame navigates.

  • inspector/PageScriptDebugServer.h:
  • inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::attachDebugger):
(WebCore::PageScriptDebugServer::detachDebugger):
(WebCore::PageScriptDebugServer::didPause):
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore::PageScriptDebugServer::runEventLoopWhilePausedInternal):
(WebCore::PageScriptDebugServer::isContentScript const):
(WebCore::PageScriptDebugServer::reportException const):

  • inspector/WorkerScriptDebugServer.h:
  • inspector/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::attachDebugger):
(WebCore::WorkerScriptDebugServer::detachDebugger):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
(WebCore::WorkerScriptDebugServer::reportException const):

  • inspector/agents/page/PageDebuggerAgent.h:
  • inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::sourceMapURLForScript):
Replace Inspector::ScriptDebugServer with JSC::Debugger.

  • inspector/TimelineRecordFactory.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createProbeSampleData):

  • inspector/agents/InspectorTimelineAgent.h:
  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::breakpointActionProbe):
Replace Inspector::ScriptBreakpoint with JSC::Breakpoint.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::didFireTimer):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didHandleEventImpl):
(WebCore::InspectorInstrumentation::didFireTimerImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameImpl):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):
When notifying Web Inspector that activity did occur, include all information previously
included when notifying Web Inspector that that activity was about to occur so that Web
Inspector can know whether a pause for the "special breakpoint" for that activity is still
scheduled and if so cancel it.

Source/WebInspectorUI:

This allows developers to do things like:

  • only pause when window.event.type is a certain value
  • ignore the first N pauses
  • evaluate JavaScript whenever an event listener is invoked without pausing
  • UserInterface/Models/Breakpoint.js:

(WI.Breakpoint):
(WI.Breakpoint.prototype.toJSON):
(WI.Breakpoint.prototype.get special): Added.
(WI.Breakpoint.prototype.get removable): Added.
(WI.Breakpoint.prototype.get editable): Added.
(WI.Breakpoint.prototype.set condition):
(WI.Breakpoint.prototype.get ignoreCount):
(WI.Breakpoint.prototype.set ignoreCount):
(WI.Breakpoint.prototype.get autoContinue):
(WI.Breakpoint.prototype.set autoContinue):
(WI.Breakpoint.prototype.get actions):
(WI.Breakpoint.prototype.get probeActions):
(WI.Breakpoint.prototype.cycleToNextMode):
(WI.Breakpoint.prototype.createAction):
(WI.Breakpoint.prototype.recreateAction):
(WI.Breakpoint.prototype.removeAction):
(WI.Breakpoint.prototype.clearActions):
(WI.Breakpoint.prototype.remove): Added.
(WI.Breakpoint.prototype.optionsToProtocol): Added.
(WI.Breakpoint.prototype.breakpointActionDidChange):
(WI.Breakpoint.fromJSON): Deleted.
(WI.Breakpoint.prototype.get sourceCodeLocation): Deleted.
(WI.Breakpoint.prototype.get contentIdentifier): Deleted.
(WI.Breakpoint.prototype.get scriptIdentifier): Deleted.
(WI.Breakpoint.prototype.get target): Deleted.
(WI.Breakpoint.prototype.get identifier): Deleted.
(WI.Breakpoint.prototype.set identifier): Deleted.
(WI.Breakpoint.prototype.get resolved): Deleted.
(WI.Breakpoint.prototype.set resolved): Deleted.
(WI.Breakpoint.prototype.saveIdentityToCookie): Deleted.
(WI.Breakpoint.prototype._isSpecial): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationLocationChanged): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationDisplayLocationChanged): Deleted.

  • UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint):
(WI.DOMBreakpoint.fromJSON): Added.
(WI.DOMBreakpoint.prototype.remove): Added.
(WI.DOMBreakpoint.prototype.toJSON):
(WI.DOMBreakpoint.deserialize): Deleted.
(WI.DOMBreakpoint.prototype.get disabled): Deleted.
(WI.DOMBreakpoint.prototype.set disabled): Deleted.

  • UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint):
(WI.EventBreakpoint.fromJSON): Added.
(WI.EventBreakpoint.prototype.get special): Added.
(WI.EventBreakpoint.prototype.get editable): Added.
(WI.EventBreakpoint.prototype.remove): Added.
(WI.EventBreakpoint.prototype.saveIdentityToCookie):
(WI.EventBreakpoint.prototype.toJSON):
(WI.EventBreakpoint.deserialize): Deleted.
(WI.EventBreakpoint.prototype.get disabled): Deleted.
(WI.EventBreakpoint.prototype.set disabled): Deleted.

  • UserInterface/Models/JavaScriptBreakpoint.js: Copied from UserInterface/Models/Breakpoint.js.

(WI.JavaScriptBreakpoint):
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get sourceCodeLocation):
(WI.JavaScriptBreakpoint.prototype.get contentIdentifier):
(WI.JavaScriptBreakpoint.prototype.get scriptIdentifier):
(WI.JavaScriptBreakpoint.prototype.get target):
(WI.JavaScriptBreakpoint.prototype.get special): Added.
(WI.JavaScriptBreakpoint.prototype.get removable): Added.
(WI.JavaScriptBreakpoint.prototype.get editable): Added.
(WI.JavaScriptBreakpoint.prototype.get identifier):
(WI.JavaScriptBreakpoint.prototype.set identifier):
(WI.JavaScriptBreakpoint.prototype.get resolved):
(WI.JavaScriptBreakpoint.prototype.set resolved):
(WI.JavaScriptBreakpoint.prototype.remove): Added.
(WI.JavaScriptBreakpoint.prototype.saveIdentityToCookie):
(WI.JavaScriptBreakpoint.prototype._isSpecial):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationLocationChanged):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationDisplayLocationChanged):

  • UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint):
(WI.URLBreakpoint.fromJSON): Added.
(WI.URLBreakpoint.prototype.get special): Added.
(WI.URLBreakpoint.prototype.remove): Added.
(WI.URLBreakpoint.prototype.toJSON):
(WI.URLBreakpoint.deserialize): Deleted.
(WI.URLBreakpoint.prototype.get disabled): Deleted.
(WI.URLBreakpoint.prototype.set disabled): Deleted.
Rename WI.Breakpoint to WI.JavaScriptBreakpoint and use WI.Breakpoint as a new common
base class for all breakpoint types, allowing more logic to be shared (e.g. disabled state).
Additionally, breakpoints are now able to

  • determine whether or not they're
    • special
    • removable
    • editable (i.e. configurable)
  • remove themselves

without the caller needing to know what manager to consult with.

  • UserInterface/Controllers/DOMManager.js:

(WI.DOMManager):
(WI.DOMManager.supportsEventListenerBreakpointConfiguration): Added.
(WI.DOMManager.prototype.setBreakpointForEventListener):
(WI.DOMManager.prototype.removeBreakpointForEventListener):
(WI.DOMManager.prototype._setEventBreakpoint): Added.
(WI.DOMManager.prototype._removeEventBreakpoint): Added.
(WI.DOMManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for specific listener breakpoints.

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.addEventBreakpoint):
(WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._commandArgumentsForEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._setEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointDisabledStateChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DOMDebuggerManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for special event breakpoints.
Store special event breakpoints inside WI.objectStores.eventBreakpoints.

  • UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype.addProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.removeProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.updateProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype._setBreakpoint):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._handleBreakpointActionsDidChange):
(WI.DebuggerManager.prototype.isBreakpointRemovable): Deleted.
(WI.DebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DebuggerManager.prototype.isBreakpointEditable): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointActionType): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointOptions): Deleted.
(WI.DebuggerManager.prototype._addProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._removeProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._updateProbesForBreakpoint): Deleted.
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WI.BreakpointPopoverController.prototype.appendContextMenuItems):
(WI.BreakpointPopoverController.prototype._createPopoverContent):
Allow any breakpoint instead of only WI.JavaScriptBreakpoint.
Drive-by: the existing ignoreCount value wasn't being used to populate the <input>.

  • UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
(WI.BreakpointTreeElement.prototype.get listenerSet): Added.
(WI.BreakpointTreeElement.prototype.updateStatus): Added.
(WI.BreakpointTreeElement.prototype.updateTitles): Added.
(WI.BreakpointTreeElement.prototype.get breakpoint): Deleted.
(WI.BreakpointTreeElement.prototype.get filterableData): Deleted.
(WI.BreakpointTreeElement.prototype._updateTitles): Deleted.
(WI.BreakpointTreeElement.prototype._updateStatus): Deleted.
(WI.BreakpointTreeElement.prototype._breakpointLocationDidChange): Deleted.

  • UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image):
(.item.breakpoint.paused .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.paused .icon): Added.
(.item.breakpoint .status > .status-image.resolved): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.selected .status > .status-image.resolved): Deleted.
(.item.breakpoint .subtitle.formatted-location): Deleted.
(.breakpoint-debugger-statement-icon .icon): Deleted.
(.breakpoint-exception-icon .icon): Deleted.
(.breakpoint-assertion-icon .icon): Deleted.
(.breakpoint-microtask-icon .icon): Deleted.
(.breakpoint-paused-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon > span): Deleted.
(.data-updated.breakpoint-generic-line-icon .icon > span): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-debugger-statement-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-exception-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-assertion-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-microtask-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-paused-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-generic-line-icon .icon): Deleted.

  • UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement):
(WI.DOMBreakpointTreeElement.prototype.onattach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onenter): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onspace): Deleted.
(WI.DOMBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.DOMBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.DOMBreakpointTreeElement.prototype._updateStatus): Deleted.

  • UserInterface/Views/DOMBreakpointTreeElement.css:

(.item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(.breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.

  • UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):
(WI.EventBreakpointTreeElement.prototype.onattach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.EventBreakpointTreeElement.prototype.onenter): Deleted.
(WI.EventBreakpointTreeElement.prototype.onspace): Deleted.
(WI.EventBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.EventBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.EventBreakpointTreeElement.prototype._updateStatus): Deleted.

  • UserInterface/Views/EventBreakpointTreeElement.css:

(.item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(.item.breakpoint.event.interval:not(.paused) .icon): Added.
(.item.breakpoint.event.listener:not(.paused) .icon): Added.
(.item.breakpoint.event.timeout:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.interval:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.listener:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.timeout:not(.paused) .icon): Added.
(.breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.

  • UserInterface/Views/JavaScriptBreakpointTreeElement.js: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js.

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype.get filterableData):
(WI.JavaScriptBreakpointTreeElement.prototype.updateStatus): Added.
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles): Added.
(WI.JavaScriptBreakpointTreeElement.prototype._breakpointLocationDidChange):

  • UserInterface/Views/JavaScriptBreakpointTreeElement.css: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.css.

(.item.breakpoint.javascript .status > .status-image): Added.
(.item.breakpoint.javascript .status > .status-image.resolved): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.javascript.selected .status > .status-image.resolved): Added.
(.item.breakpoint.javascript .subtitle.formatted-location): Added.
(.item.breakpoint.javascript.line .icon): Added.
(.item.breakpoint.javascript.line .icon > span): Added.
(.data-updated.item.breakpoint.javascript.line .icon > span): Added.
(.item.breakpoint.javascript.debugger-statement .icon): Added.
(.item.breakpoint.javascript.exception .icon): Added.
(.item.breakpoint.javascript.assertion .icon): Added.
(.item.breakpoint.javascript.microtask .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.line .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.debugger-statement .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.exception .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.assertion .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.microtask .icon): Added.

  • UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):
(WI.URLBreakpointTreeElement.prototype.onattach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.URLBreakpointTreeElement.prototype.onenter): Deleted.
(WI.URLBreakpointTreeElement.prototype.onspace): Deleted.
(WI.URLBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.URLBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.URLBreakpointTreeElement.prototype._updateStatus): Deleted.

  • UserInterface/Views/URLBreakpointTreeElement.css:

(.item.breakpoint.url .subtitle): Added.
(.item.breakpoint.url:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.url:not(.paused) .icon): Added.
(.breakpoint.url .subtitle): Deleted.
(.breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
Rename WI.BreakpointTreeElement to WI.JavaScriptBreakpointTreeElement and use
WI.BreakpointTreeElement as a new common base class for all breakpoint tree elements,
allowing more logic and styles to be shared (e.g. disabled state).

  • UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype.closed):
(WI.SourcesNavigationSidebarPanel.prototype._insertDebuggerTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._compareJavaScriptBreakpointTreeElements): Added.
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._removeAllBreakpoints):
(WI.SourcesNavigationSidebarPanel.prototype._breakpointsBeneathTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._addIssue):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._handleTreeSelectionDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._compareBreakpointTreeElements): Deleted.

  • UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.createProbe):
(WI.ProbeSet.prototype.willRemove):

  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

  • UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.inspect):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor):
(WI.SourceCodeTextEditor.prototype.close):
(WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):

  • UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get supplementalRepresentedObjects):
(WI.TextResourceContentView.prototype._probeSetsChanged):
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

  • UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):
(WI.ContentView.isViewable):

  • UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.

  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Replace WI.DOMBreakpoint with WI.Breakpoint.

  • UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):

  • UserInterface/Views/EventListenerSectionGroup.css:

(.event-listener-section > .content input[type="checkbox"] + .go-to-arrow): Added.
(.event-listener-section > .content input[type="checkbox"]:not(:checked) + .go-to-arrow): Added.
Add a go-to arrow next to the Breakpoint checkbox that reveals the WI.EventBreakpoint in
the Sources Tab.

  • UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView.prototype._appendActionButtonClicked):
Drive-by: minor code cleanup.

  • UserInterface/Views/CallFrameTreeElement.js:

(WI.CallFrameTreeElement.prototype.populateContextMenu):
Drive-by: include source code location context menu items.

  • UserInterface/Base/Setting.js:
  • UserInterface/Main.html:
  • UserInterface/Test.html:

LayoutTests:

  • inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Added.
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.async teardown):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.removeBreakpoint):

  • inspector/dom/breakpoint-for-event-listener.html:
  • inspector/dom/breakpoint-for-event-listener-expected.txt:
  • inspector/dom-debugger/event-animation-frame-breakpoints.html:
  • inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
  • inspector/dom-debugger/event-interval-breakpoints.html:
  • inspector/dom-debugger/event-interval-breakpoints-expected.txt:
  • inspector/dom-debugger/event-listener-breakpoints.html:
  • inspector/dom-debugger/event-listener-breakpoints-expected.txt:
  • inspector/dom-debugger/event-timeout-breakpoints.html:
  • inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Add tests for new event breakpoint configuration options.

  • http/tests/inspector/debugger/debugger-test.js:

(TestPage.registerInitializer.InspectorTest.startTracingBreakpoints):

  • http/tests/inspector/resources/probe-test.js:

(TestPage.registerInitializer.ProtocolTest.Probe.installTracingListeners):

  • inspector/debugger/breakpoint-action-eval.html:
  • inspector/debugger/breakpoint-action-log.html:
  • inspector/debugger/breakpoint-columns.html:
  • inspector/debugger/breakpoint-scope.html:
  • inspector/debugger/debugger-stack-overflow.html:
  • inspector/debugger/pause-reason.html:
  • inspector/debugger/probe-manager-add-remove-actions.html:
  • inspector/debugger/stepping/stepping-through-autoContinue-breakpoint.html:
  • inspector/debugger/tail-deleted-frames-this-value.html:
  • inspector/debugger/tail-recursion.html:
  • inspector/worker/debugger-pause.html:
  • inspector/worker/debugger-shared-breakpoint.html:

Update existing breakpoint tests to use new model objects.

10:32 AM Changeset in webkit [266073] by Hector Lopez
  • 2 edits in trunk/LayoutTests

Regression (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Unreviewwed test gardening.

  • platform/ios-wk2/TestExpectations:
10:31 AM Changeset in webkit [266072] by Devin Rousso
  • 39 edits in trunk/Source

Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type
​https://bugs.webkit.org/show_bug.cgi?id=201150
<rdar://problem/56545911>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/scripts/codegen/objc_generator_templates.py:
  • inspector/augmentable/AugmentableInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::registerAlternateAgent): Added.
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent): Deleted.

  • inspector/InspectorAgentRegistry.h:
  • inspector/InspectorAgentRegistry.cpp:

(Inspector::AgentRegistry::appendExtraAgent): Deleted.

  • inspector/protocol/Inspector.json:
  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomain): Deleted.
(Inspector::InspectorAgent::activateExtraDomains): Deleted.

  • inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
  • inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
  • inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
  • inspector/scripts/tests/expected/domain-targetTypes.json-result:
  • inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
  • inspector/scripts/tests/expected/enum-values.json-result:
  • inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
  • inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:

Rebase protocol tests.

Source/WebInspectorUI:

  • UserInterface/Base/Object.js:
  • UserInterface/Protocol/InspectorObserver.js:

(WI.InspectorObserver.prototype.activateExtraDomains):

  • UserInterface/Protocol/Target.js:

(WI.Target.prototype.activateExtraDomain):

  • UserInterface/Controllers/AppController.js:

(WI.AppController.prototype.activateExtraDomains):

  • UserInterface/Controllers/AnimationManager.js:

(WI.AnimationManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/ApplicationCacheManager.js:

(WI.ApplicationCacheManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/DOMStorageManager.js:

(WI.DOMStorageManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/DatabaseManager.js:

(WI.DatabaseManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/MemoryManager.js:

(WI.MemoryManager.prototype.activateExtraDomain):

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype._extraDomainsActivated):

  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.activateExtraDomain):

  • UserInterface/Base/Main.js:

(WI.activateExtraDomains):

  • UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleExtraDomainsActivated):
Add compatibility comments.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackend.Domain):
Add FIXMEs.

10:30 AM Changeset in webkit [266071] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
​https://bugs.webkit.org/show_bug.cgi?id=205827

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WI.loaded):

10:24 AM Changeset in webkit [266070] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215681

Reviewed by Brian Burg.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):

10:21 AM Changeset in webkit [266069] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show non-inherited properties
​https://bugs.webkit.org/show_bug.cgi?id=215682

Reviewed by Brian Burg.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender):

10:17 AM Changeset in webkit [266068] by youenn@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths
​https://bugs.webkit.org/show_bug.cgi?id=215766

Reviewed by Alex Christensen.

Add a test showing the difference of behavior at connection close time in python websocket script.
This behavior was previously covered in http/tests/websocket/tests/hybi/close-on-* tests.
The test is written so that Chrome, Firefox and NSURLSession WebSocket code path generate all PASS.
Legacy WebSocket code path generates one FAIL.

  • http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py: Added.
  • http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Added.
  • http/tests/websocket/tests/hybi/close-and-server-script-exception.html: Added.
  • http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html: Added.
10:13 AM Changeset in webkit [266067] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215773

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:11 AM Changeset in webkit [266066] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: grey out properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215680

Reviewed by Brian Burg.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(.editing), body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(:hover, .editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-link): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-string): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-comment): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-link): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-string): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-comment): Deleted.
Add additional :nots to existing rules to ensure that they don't conflict with a new rule
that changes the color of the .name/.value to grey when the property is not applied/used.

10:01 AM Changeset in webkit [266065] by Hector Lopez
  • 2 edits in trunk/LayoutTests

webkit-test-runner: Add support for the reftest-wait class name
​https://bugs.webkit.org/show_bug.cgi?id=186045

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
9:51 AM Changeset in webkit [266064] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=215765
<rdar://problem/67677285>

Reviewed by Eric Carlson.

Following ​https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.

  • Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:
9:25 AM Changeset in webkit [266063] by Aditya Keerthi
  • 46 edits
    11 adds in trunk

[macOS] Show picker for date and datetime-local input types
​https://bugs.webkit.org/show_bug.cgi?id=214946

Reviewed by Darin Adler and Wenson Hsieh.

Source/WebCore:

Date and datetime-local input types require a calendar picker to be presented when activated.
Consequently, BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent was modified to
create a DateTimeChooser and display a calendar upon activation. This object is destroyed
when the element is blurred, hiding the calendar.

There is currently no picker UI for month, week, and time input types. As a result,
handleDOMActivateEvent is a no-op on those input types.

Wrote an encoder and decoder for DateTimeChooserParameters, so that the picker can be
created with the correct values.

Tests: fast/forms/date/date-show-hide-picker.html

fast/forms/datetimelocal/datetimelocal-show-hide-picker.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::elementDidBlur):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isPresentingAttachedView const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):

  • html/BaseChooserOnlyDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp:
  • html/MonthInputType.cpp:

(WebCore::MonthInputType::handleDOMActivateEvent):

  • html/MonthInputType.h:
  • html/TimeInputType.cpp:

(WebCore::TimeInputType::handleDOMActivateEvent):

  • html/TimeInputType.h:
  • html/WeekInputType.cpp:

(WebCore::WeekInputType::handleDOMActivateEvent):

  • html/WeekInputType.h:
  • loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createDateTimeChooser):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::createDateTimeChooser):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/DateTimeChooser.h:
  • platform/DateTimeChooserClient.h:
  • platform/DateTimeChooserParameters.h: Added.

(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):

Source/WebKit:

Created WKDateTimePicker as a wrapper around NSDatePicker. The picker is
displayed in its own NSWindow, ensuring the view is always above the page.
WebPageProxy and WKDateTimePicker communicate through WebDateTimePickerMac,
in order for the picker to be initialized with the correct initial, minimum,
and maximum date, and so that the chosen date can be sent back to the
WebProcess.

Added IPC messages to enable communication between the UIProcess and the
WebProcess necessary for showing and hiding the picker.

  • Sources.txt:
  • SourcesCocoa.txt:
  • UIProcess/PageClient.h:
  • UIProcess/WebDateTimePicker.cpp: Added.

(WebKit::WebDateTimePicker::WebDateTimePicker):
(WebKit::WebDateTimePicker::~WebDateTimePicker):
(WebKit::WebDateTimePicker::endPicker):

  • UIProcess/WebDateTimePicker.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showDateTimePicker):
(WebKit::WebPageProxy::endDateTimePicker):
(WebKit::WebPageProxy::didChooseDate):
(WebKit::WebPageProxy::didEndDateTimePicker):
(WebKit::WebPageProxy::closeOverlayedViews):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDateTimePicker):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::createDateTimePicker):

  • UIProcess/mac/WebDateTimePickerMac.h: Added.
  • UIProcess/mac/WebDateTimePickerMac.mm: Added.

(WebKit::WebDateTimePickerMac::create):
(WebKit::WebDateTimePickerMac::~WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::endPicker):
(WebKit::WebDateTimePickerMac::showDateTimePicker):
(WebKit::WebDateTimePickerMac::didChooseDate):
(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerWindow canBecomeKeyWindow]):
(-[WKDateTimePickerWindow hasKeyAppearance]):
(-[WKDateTimePickerWindow shadowOptions]):
(-[WKDateTimePicker initWithParams:inView:]):
(-[WKDateTimePicker showPicker:]):
(-[WKDateTimePicker invalidate]):
(-[WKDateTimePicker didChooseDate:]):
(-[WKDateTimePicker dateFormatStringForType:]):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDateTimeChooser):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebDateTimeChooser.cpp: Added.

(WebKit::WebDateTimeChooser::WebDateTimeChooser):
(WebKit::WebDateTimeChooser::didChooseDate):
(WebKit::WebDateTimeChooser::didEndChooser):
(WebKit::WebDateTimeChooser::endChooser):
(WebKit::WebDateTimeChooser::showChooser):

  • WebProcess/WebCoreSupport/WebDateTimeChooser.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActiveDateTimeChooser):
(WebKit::WebPage::didChooseDate):
(WebKit::WebPage::didEndDateTimePicker):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createDateTimeChooser):

Tools:

Added isShowingDateTimePicker testing hook in order to enable testing of the visibility of
the picker.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::isShowingDateTimePicker const):

  • WebKitTestRunner/mac/UIScriptControllerMac.h:
  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::isShowingDateTimePicker const):

LayoutTests:

Added tests to verify that the picker is correctly shown and hidden for date and
datetime-local input types.

  • fast/forms/date/date-show-hide-picker-expected.txt: Added.
  • fast/forms/date/date-show-hide-picker.html: Added.
  • fast/forms/datetimelocal/datetimelocal-show-hide-picker-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-show-hide-picker.html: Added.
  • platform/ios/TestExpectations:
  • resources/ui-helper.js:

(window.UIHelper.isShowingDateTimePicker):

9:22 AM Changeset in webkit [266062] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] Rename LineBox::baseline to alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214784

Reviewed by Antti Koivisto.

See ​https://www.w3.org/TR/css-inline-3/#alignment-baseline
Use the spec term. This helps to tell the dominant and the alignment baselines apart during line building.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::resetAlignmentBaseline):
(WebCore::Layout::LineBox::setBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::baseline const): Deleted.
(WebCore::Layout::LineBox::resetBaseline): Deleted.

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

  • layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):

8:50 AM Changeset in webkit [266061] by Adrian Perez de Castro
  • 7 edits in trunk/Source

Non-unified build fixes, late August 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=215768

Unreviewed build fix.

Source/WebCore:

No new tests needed.

  • Modules/webaudio/StereoPannerNode.cpp: Add missing headers AudioNodeInput.h,

AudioNodeOutput.h, and wtf/IsoMallocInlines.h.

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
Add JSC:: namespace to SlotVisitor parameter type.

  • dom/SimpleRange.cpp: Add missing ShadowRoot.h header.
  • history/CachedPage.cpp: Add missing FrameLoaderClient.h header.

Source/WebKit:

  • UIProcess/WebURLSchemeTask.cpp: Add missing SharedBufferDataReference.h header.
8:42 AM Changeset in webkit [266060] by Hector Lopez
  • 2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2
​https://bugs.webkit.org/show_bug.cgi?id=189672

Unreviewed test gardening.

  • platform/mac/TestExpectations:
8:02 AM Changeset in webkit [266059] by youenn@apple.com
  • 12 edits in trunk/LayoutTests

http/tests/websocket/tests/hybi/close-on-* tests are not interoperable
​https://bugs.webkit.org/show_bug.cgi?id=215692

Reviewed by Darin Adler.

Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path.
This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception
while it is for Chrome, Firefox and NSURLSession WebSocket code path.
Change the WebSocket server script to more reliably send the socket message at closing time of the connection.

  • http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt:
  • http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt:
  • http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
  • http/tests/websocket/tests/hybi/close-on-unload-expected.txt:
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt:
  • http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html:
  • http/tests/websocket/tests/hybi/close-on-unload.html:
  • http/tests/websocket/tests/hybi/close-on-unload_wsh.py:

(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
8:02 AM Changeset in webkit [266058] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=215767

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
7:57 AM Changeset in webkit [266057] by youenn@apple.com
  • 7 edits in trunk

Cocoa WebSocketTask should expose WebSocket server extensions
​https://bugs.webkit.org/show_bug.cgi?id=215696

Reviewed by Darin Adler.

Source/WebKit:

Send back to WebProcess the value of server WebSocket extensions.

  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::didConnect):

LayoutTests:

Make the tests agnostic of using the legacy or standard deflate extension.
If using the standard deflate extensions, do not expect subparameters (this matches Chrome, Firefox and NSURLSession code path).

  • http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
  • http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
  • http/tests/websocket/tests/hybi/extensions-expected.txt:
  • http/tests/websocket/tests/hybi/extensions.html:
7:50 AM Changeset in webkit [266056] by Alan Bujtas
  • 12 edits in trunk/Source/WebCore

[LFC][IFC] Use the term 'baseline' to indicate alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214779

Reviewed by Antti Koivisto.

This patch is in preparation for decoupling the line box and the root inline box geometry.
Inline boxes have ascent/descent pairs, while line boxes have inline boxes and a baseline.

  • layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

  • layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::AscentAndDescent::height const):
(WebCore::Layout::LineBox::ascentAndDescent const):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::setBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::height const): Deleted.
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater): Deleted.
(WebCore::Layout::LineBox::baselineOffset const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::Baseline): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setAscent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setDescent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::reset): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::ascent const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::descent const): Deleted.

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::alignContentVertically):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

  • layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):
(WebCore::Layout::LineBuilder::baselineOffset const): Deleted.

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace):

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

  • layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Row::setBaseline):
(WebCore::Layout::TableGrid::Row::baseline const):
(WebCore::Layout::TableGrid::Cell::setBaseline):
(WebCore::Layout::TableGrid::Cell::baseline const):
(WebCore::Layout::TableGrid::Row::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Row::baselineOffset const): Deleted.
(WebCore::Layout::TableGrid::Cell::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Cell::baselineOffset const): Deleted.

  • layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

6:10 AM Changeset in webkit [266055] by Carlos Garcia Campos
  • 18 edits in trunk

Unreviewed. Fix GTK4 build

Source/WebCore:

  • SourcesGTK.txt:
  • platform/gtk/GtkUtilities.cpp:

(WebCore::monitorWorkArea):

  • platform/gtk/GtkUtilities.h:
  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenAvailableRect):

Source/WebKit:

  • PlatformGTK.cmake:
  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

  • UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed):
(webkit_script_dialog_impl_class_init):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEvent):
(webkit_web_view_base_class_init):

  • UIProcess/API/gtk/WebKitWebViewDialog.cpp:

(webkitWebViewDialogConstructed):
(webkitWebViewDialogSetChild):

  • UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:

(webkit_inspector_window_init):

  • UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::show):

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

Tools:

  • MiniBrowser/gtk/BrowserSearchBox.c:
  • MiniBrowser/gtk/BrowserWindow.c:
5:29 AM Changeset in webkit [266054] by commit-queue@webkit.org
  • 4 edits in trunk

Make window.find not default the search string to undefined
​https://bugs.webkit.org/show_bug.cgi?id=215757

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-24
Reviewed by Darin Adler.

Source/WebCore:

Make window.find not default the search string to undefined, instead
use the null string. Before this change window.find() would find a
hit in a page containing the text string "undefined".

Test: fast/text/window-find.html

  • page/DOMWindow.idl:

LayoutTests:

Add tests to verify window.find() does not use "undefined"
as text string. This also fixes the logic of the test to
not always output PASS at the end.

  • fast/text/window-find.html:
2:55 AM Changeset in webkit [266053] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Unreviewed, ignore RangeErrors when ICU is too old

Since ICU version is different (very sad), some of tests can throw an error.

  • stress/intl-language-tag.js:

(let.shouldThrow):
(let.shouldNotThrow):
(suppressErrors):
(vm.icuVersion):
(shouldThrow): Deleted.
(shouldNotThrow): Deleted.

2:26 AM Changeset in webkit [266052] by commit-queue@webkit.org
  • 7 edits in trunk

RTCRtpSynchronizationSource.rtpTimestamp is not present
​https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <​justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

  • LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

  • Modules/mediastream/RTCRtpContributingSource.idl:
  • Modules/mediastream/RTCRtpContributingSource.idl:
  • Modules/mediastream/RTCRtpSynchronizationSource.idl:

Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.

  • Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::fillRTCRtpContributingSource):

Aug 23, 2020:

6:51 PM Changeset in webkit [266051] by Wenson Hsieh
  • 15 edits
    2 adds in trunk

Programmatic selection of text in a text field causes the highlight overlay to spill out
​https://bugs.webkit.org/show_bug.cgi?id=215647
<rdar://problem/67404979>

Reviewed by Darin Adler.

Source/WebCore:

See WebKit ChangeLog for more detail.

  • html/HTMLTextFormControlElement.h: Export a helper function.

Source/WebKit:

UIKit consults the SPI method -_selectionClipRect on WKContentView to determine the maximum bounds in which it
is allowed to show text selection UI (i.e. the text caret view, selection highlight views, and selection
grabbers). Normally, when contentEditable elements and editable text form controls are focused, we plumb the
bounds of the focused element to the UI process via focusedElementRect in editor state's post layout data.
However, in this case, the selection is inside a readonly text field that is *not* focused; this causes us to
return CGRectNull from -_selectionClipRect, which means that UIKit selection UI is not clipped at all and
instead overflows the bounds of the input element.

To fix this, rearrange some logic in WebPage::getPlatformEditorState in WebPageIOS.mm such that we compute
and send the selection clipping rect if the selection is inside a text form control, even if it is not the
focused element. In doing this, we also rename some confusingly-named members in EditorState::PostLayoutData
(see below for more detail).

Test: editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html

  • Platform/spi/ios/UIKitSPI.h:

Add a declaration for -_selectionClipRect.

  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
(WebKit::operator<<):

  • Shared/EditorState.h:

Split the existing rect member focusedElementRect into two: selectionClipRect on iOS, and
selectionBoundingRect on macOS. Previously, focusedElementRect was set to the focused element's bounding
rect on iOS (as expected), but on macOS, we set to the bounds of the ranged or caret selection; we proceed to
use this rect to mean the bounds of the selection anyways in macOS-specific code, so it makes more sense to just
move this into the macOS-specific section.

Additionally, after the below change in WebPageIOS, focusedElementRect is no longer specific to the focused
element, so rename it instead to selectionClipRect instead. In WKContentViewInteraction.mm, this rect is
effectively only used in two ways: as the selection clip rect for UIKit, and to determine if the selection would
be completely clipped anyways (in which case we suppress UIKit text interactions), so selectionClipRect is a
name that is suitable for both purposes.

  • UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView _candidateRect]):

  • UIProcess/Cocoa/WebViewImpl.mm:

Rename focusedElementRect to selectionBoundingRect on macOS.

(WebKit::WebViewImpl::handleRequestedCandidates):

  • UIProcess/ios/WKContentViewInteraction.mm:

Rename focusedElementRect to selectionClipRect on iOS.

(WebKit::WKSelectionDrawingInfo::WKSelectionDrawingInfo):
(-[WKContentView _selectionClipRect]):

Change this to not require a focused element when returning the selection clip rect, and instead return the
editor state's selection clip rect as long as it is not empty.

(-[WKContentView _updateSelectionAssistantSuppressionState]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const):

Refactor this code to compute and send selectionClipRect as long as the selection is inside a form control or
editing host (not just when there is a focused element). Also leave a drive-by FIXME about using the focused
element (instead of the selection container node) when computing the caret color.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getPlatformEditorState const):

Tools:

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::clipSelectionViewRectToContentView):

Add a helper function to clip UIKit selection UI rects (for carets, selection grabbers, and ranged selection
highlights) to the content view's (WKContentView's) bounds, as well as the selection clip rect if it is nonnull.

(WTR::UIScriptControllerIOS::selectionStartGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionEndGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionCaretViewRect const):
(WTR::UIScriptControllerIOS::selectionRangeViewRects const):

LayoutTests:

  • editing/selection/ios/select-all-in-readonly-input-does-not-overflow-expected.txt: Added.
  • editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html: Added.

Add a new layout test to verify that the width of the selection view does not exceed the width of the readonly
input containing the selected text.

  • resources/ui-helper.js:

(window.UIHelper.async waitForSelectionToAppear):

Adjust this UIHelper function to additionally resolve to the selection rects, so that it won't be necessary for
callers to ask for the selection view rects separately after waiting for selection views to appear.

6:30 PM Changeset in webkit [266050] by Fujii Hironori
  • 4 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations:
  • platform/wincairo/css1/text_properties/letter_spacing-expected.txt:
  • platform/wincairo/fast/text/emphasis-expected.txt:
2:21 PM Changeset in webkit [266049] by Lauro Moura
  • 3 edits in trunk/LayoutTests

Avoid timeout when http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html fails
​https://bugs.webkit.org/show_bug.cgi?id=215759

Reviewed by Darin Adler.

  • http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html:

Finish the test if the test fails because the close callback is
called.

  • platform/glib/TestExpectations: Update expectation.
10:06 AM Changeset in webkit [266048] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] Introduce the root inline box
​https://bugs.webkit.org/show_bug.cgi?id=214733

Reviewed by Antti Koivisto.

This is in preparation for having a dedicated line box for each line with inline boxes inside.
At this point we only use the root inline box to proxy the baseline handling.
See ​https://www.w3.org/TR/css-inline-3/#model

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::Baseline::height const):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::setLogicalHeightIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::Baseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::setAscent):
(WebCore::Layout::LineBox::InlineBox::Baseline::setDescent):
(WebCore::Layout::LineBox::InlineBox::Baseline::reset):
(WebCore::Layout::LineBox::InlineBox::Baseline::ascent const):
(WebCore::Layout::LineBox::InlineBox::Baseline::descent const):
(WebCore::Layout::InlineBox::Baseline::height const): Deleted.
(WebCore::Layout::InlineBox::logicalRect const): Deleted.
(WebCore::Layout::InlineBox::scrollableOverflow const): Deleted.
(WebCore::Layout::InlineBox::logicalLeft const): Deleted.
(WebCore::Layout::InlineBox::logicalRight const): Deleted.
(WebCore::Layout::InlineBox::logicalTop const): Deleted.
(WebCore::Layout::InlineBox::logicalBottom const): Deleted.
(WebCore::Layout::InlineBox::logicalWidth const): Deleted.
(WebCore::Layout::InlineBox::logicalHeight const): Deleted.
(WebCore::Layout::InlineBox::resetDescent): Deleted.
(WebCore::Layout::InlineBox::setLogicalHeight): Deleted.
(WebCore::Layout::InlineBox::setLogicalWidth): Deleted.
(WebCore::Layout::InlineBox::setScrollableOverflow): Deleted.
(WebCore::Layout::InlineBox::moveHorizontally): Deleted.
(WebCore::Layout::InlineBox::expandHorizontally): Deleted.
(WebCore::Layout::InlineBox::shrinkHorizontally): Deleted.
(WebCore::Layout::InlineBox::expandVertically): Deleted.
(WebCore::Layout::InlineBox::shrinkVertically): Deleted.
(WebCore::Layout::InlineBox::isConsideredEmpty const): Deleted.
(WebCore::Layout::InlineBox::setIsConsideredEmpty): Deleted.
(WebCore::Layout::InlineBox::setIsConsideredNonEmpty): Deleted.
(WebCore::Layout::InlineBox::InlineBox): Deleted.
(WebCore::Layout::InlineBox::setLogicalHeightIfGreater): Deleted.
(WebCore::Layout::InlineBox::baseline const): Deleted.
(WebCore::Layout::InlineBox::setBaselineOffsetIfGreater): Deleted.
(WebCore::Layout::InlineBox::setAscentIfGreater): Deleted.
(WebCore::Layout::InlineBox::setDescentIfGreater): Deleted.
(WebCore::Layout::InlineBox::baselineOffset const): Deleted.
(WebCore::Layout::InlineBox::resetBaseline): Deleted.
(WebCore::Layout::InlineBox::Baseline::Baseline): Deleted.
(WebCore::Layout::InlineBox::Baseline::setAscent): Deleted.
(WebCore::Layout::InlineBox::Baseline::setDescent): Deleted.
(WebCore::Layout::InlineBox::Baseline::reset): Deleted.
(WebCore::Layout::InlineBox::Baseline::ascent const): Deleted.
(WebCore::Layout::InlineBox::Baseline::descent const): Deleted.

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

  • layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox const):

  • layout/inlineformatting/LineLayoutContext.h:
6:53 AM Changeset in webkit [266047] by Alan Bujtas
  • 14 edits in trunk/Source/WebCore

[LFC][IFC] Display::LineBox does not need ascent/descent geometry
​https://bugs.webkit.org/show_bug.cgi?id=214720

Reviewed by Antti Koivisto.

Line box is just a rectangular area that contains all the inline boxes that form a single line.
It generally has a non-zero baseline (the root inline box's baseline), but it does not have ascent/descent geometry.

  • layout/displaytree/DisplayLineBox.h:

(WebCore::Display::LineBox::baseline const):
(WebCore::Display::LineBox::LineBox):
(WebCore::Display::LineBox::Baseline::height const): Deleted.
(WebCore::Display::LineBox::Baseline::ascent const): Deleted.
(WebCore::Display::LineBox::Baseline::descent const): Deleted.
(WebCore::Display::LineBox::baselineOffset const): Deleted.
(WebCore::Display::LineBox::Baseline::Baseline): Deleted.

  • layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

  • layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::alignContentVertically):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::paint):

  • layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::layoutFormattingContextEnabled const):
(WebCore::RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled const):

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::boundingBoxForRenderTreeDump const):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::baseline const):
(WebCore::SimpleLineLayout::RunResolver::Run::baselineOffset const): Deleted.

  • rendering/line/LineLayoutTraversal.h:

(WebCore::LineLayoutTraversal::Box::baseline const):
(WebCore::LineLayoutTraversal::Box::baselineOffset const): Deleted.

  • rendering/line/LineLayoutTraversalComplexPath.h:

(WebCore::LineLayoutTraversal::ComplexPath::baseline const):
(WebCore::LineLayoutTraversal::ComplexPath::baselineOffset const): Deleted.

  • rendering/line/LineLayoutTraversalDisplayRunPath.h:

(WebCore::LineLayoutTraversal::DisplayRunPath::baseline const):
(WebCore::LineLayoutTraversal::DisplayRunPath::baselineOffset const): Deleted.

  • rendering/line/LineLayoutTraversalSimplePath.h:

(WebCore::LineLayoutTraversal::SimplePath::baseline const):
(WebCore::LineLayoutTraversal::SimplePath::baselineOffset const): Deleted.

6:40 AM Changeset in webkit [266046] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not use undefined default param in CSSStyleDeclaration.idl
​https://bugs.webkit.org/show_bug.cgi?id=215753

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-23
Reviewed by Darin Adler.

Do not use undefined default parameter value in CSSStyleDeclaration.idl, instead use no explicit default
parameter at all. This means a zero length String will be used, which will be more efficient when using
the cssPropertyID helper method, as well as less error-prone.

  • css/CSSStyleDeclaration.idl:
5:45 AM Changeset in webkit [266045] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[LFC][IFC] Move all line height and baseline adjustment logic to LineBuilder::adjustBaselineAndLineHeight
​https://bugs.webkit.org/show_bug.cgi?id=214474

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

  • layout/inlineformatting/InlineLineBuilder.h:

LayoutTests:

  • fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple-expected.html: Added.
  • fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html: Added.
12:11 AM Changeset in webkit [266044] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, wrong merge resolution between r266031 and r263837
​https://bugs.webkit.org/show_bug.cgi?id=209774

r263837 is landed after r266031 is configured. OSS buildbots didn't catch this since they are using old ICU headers.

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

Aug 22, 2020:

11:06 PM Changeset in webkit [266043] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, assertion was opposite
​https://bugs.webkit.org/show_bug.cgi?id=215058

We should ensure that this is *not* zero.

  • runtime/IntlObject.cpp:

(JSC::parseVariantCode):

7:27 PM Changeset in webkit [266042] by Lauro Moura
  • 2 edits in trunk/LayoutTests

[WPE] Rebaseline test after r265851

Updated the Render element name.

Unreviewed test gardening.

  • platform/wpe/fast/layers/video-layer-expected.txt:
6:51 PM Changeset in webkit [266041] by mmaxfield@apple.com
  • 3 edits in trunk/LayoutTests

Make fast/text/letter-spacing-shaping.html more robust
​https://bugs.webkit.org/show_bug.cgi?id=215711

Unreviewed test gardening.

  • fast/text/letter-spacing-shaping-expected.html:
  • fast/text/letter-spacing-shaping.html:
6:15 PM Changeset in webkit [266040] by Alan Bujtas
  • 6 edits
    1 move in trunk/Source/WebCore

[LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
​https://bugs.webkit.org/show_bug.cgi?id=214406

Reviewed by Antti Koivisto.

This is in prepartion for supporting nested lineboxes required by certain vertical alignment values.

<div>text content</div> <- This content requires only one inline box, the root linebox.
<div>nested <span><span style="vertical-align: text-top">text</span> </span>content</div> <- the content [text] is vertically
aligned with the top of the _parent element_'s font and not the root inline box.

  1. Let's rename the LineBoxBuilder to InlineBox. We'll have a bunch of these.
  2. Pass in the parent inline to adjustBaselineAndLineHeight (currently there's only one inline box per line, the root inline box).
  • WebCore.xcodeproj/project.pbxproj:
  • layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

  • layout/inlineformatting/InlineLineBox.h: Renamed from Source/WebCore/layout/inlineformatting/InlineLineBoxBuilder.h.

(WebCore::Layout::LineBox::Baseline::height const):
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::scrollableOverflow const):
(WebCore::Layout::LineBox::logicalLeft const):
(WebCore::Layout::LineBox::logicalRight const):
(WebCore::Layout::LineBox::logicalTop const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalWidth const):
(WebCore::Layout::LineBox::logicalHeight const):
(WebCore::Layout::LineBox::resetDescent):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setLogicalWidth):
(WebCore::Layout::LineBox::setScrollableOverflow):
(WebCore::Layout::LineBox::moveHorizontally):
(WebCore::Layout::LineBox::expandHorizontally):
(WebCore::Layout::LineBox::shrinkHorizontally):
(WebCore::Layout::LineBox::expandVertically):
(WebCore::Layout::LineBox::shrinkVertically):
(WebCore::Layout::LineBox::isConsideredEmpty const):
(WebCore::Layout::LineBox::setIsConsideredEmpty):
(WebCore::Layout::LineBox::setIsConsideredNonEmpty):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setLogicalHeightIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::Baseline::Baseline):
(WebCore::Layout::LineBox::Baseline::setAscent):
(WebCore::Layout::LineBox::Baseline::setDescent):
(WebCore::Layout::LineBox::Baseline::reset):
(WebCore::Layout::LineBox::Baseline::ascent const):
(WebCore::Layout::LineBox::Baseline::descent const):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

  • layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox const):

  • layout/inlineformatting/LineLayoutContext.h:
5:26 PM Changeset in webkit [266039] by ysuzuki@apple.com
  • 15 edits
    1 add in trunk

[JSC] Implement Intl Language Tag Parser
​https://bugs.webkit.org/show_bug.cgi?id=215058

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

  • stress/intl-collator.js:
  • stress/intl-datetimeformat.js:
  • stress/intl-language-tag.js: Added.

(shouldThrow):
(shouldNotThrow):

  • stress/intl-locale.js:
  • stress/intl-numberformat.js:
  • stress/intl-object.js:
  • stress/intl-pluralrules.js:
  • stress/intl-relativetimeformat.js:
  • stress/string-toLocaleLowerCase.js:
  • stress/string-toLocaleUpperCase.js:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds LanguageTagParser which performs isStructurallyValidLanguageTag[1] validation precisely.
The spec strictly defines acceptable format as language-tag and this is not the same to ICU's one and this
is even tested in test262. We should have LanguageTagParser to validate the input.

[1]: ​https://tc39.es/ecma402/#sec-isstructurallyvalidlanguagetag

  • runtime/IntlLocale.cpp:

(JSC::LocaleIDBuilder::initialize):
(JSC::IntlLocale::initializeLocale):

  • runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::parseVariantCode):
(JSC::convertToUnicodeSingletonIndex):
(JSC::isUnicodeExtensionAttribute):
(JSC::isUnicodeExtensionKey):
(JSC::isUnicodeExtensionTypeComponent):
(JSC::isUnicodePUExtensionValue):
(JSC::isUnicodeOtherExtensionValue):
(JSC::isUnicodeTKey):
(JSC::isUnicodeTValueComponent):
(JSC::LanguageTagParser::LanguageTagParser):
(JSC::LanguageTagParser::isEOS):
(JSC::LanguageTagParser::next):
(JSC::LanguageTagParser::parseUnicodeLocaleId):
(JSC::LanguageTagParser::parseUnicodeLanguageId):
(JSC::LanguageTagParser::parseUnicodeExtensionAfterPrefix):
(JSC::LanguageTagParser::parseTransformedExtensionAfterPrefix):
(JSC::LanguageTagParser::parseOtherExtensionAfterPrefix):
(JSC::LanguageTagParser::parsePUExtensionAfterPrefix):
(JSC::LanguageTagParser::parseExtensionsAndPUExtensions):
(JSC::isStructurallyValidLanguageTag):
(JSC::isUnicodeLanguageId):

  • runtime/IntlObject.h:
3:45 PM Changeset in webkit [266038] by emilio
  • 4 edits
    96 adds in trunk/LayoutTests

Import css-content tests.
​https://bugs.webkit.org/show_bug.cgi?id=215751

Reviewed by Antti Koivisto.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-content/META.yml: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
  • web-platform-tests/css/css-content/computed-value-expected.txt: Added.
  • web-platform-tests/css/css-content/computed-value.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
  • web-platform-tests/css/css-content/element-replacement-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
  • web-platform-tests/css/css-content/element-replacement.html: Added.
  • web-platform-tests/css/css-content/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-content/inheritance.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
  • web-platform-tests/css/css-content/quotes-001-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-001.html: Added.
  • web-platform-tests/css/css-content/quotes-002-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-002.html: Added.
  • web-platform-tests/css/css-content/quotes-003-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-003.html: Added.
  • web-platform-tests/css/css-content/quotes-004-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-004.html: Added.
  • web-platform-tests/css/css-content/quotes-005-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-005.html: Added.
  • web-platform-tests/css/css-content/quotes-006-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-006.html: Added.
  • web-platform-tests/css/css-content/quotes-007-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-007.html: Added.
  • web-platform-tests/css/css-content/quotes-008-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-008.html: Added.
  • web-platform-tests/css/css-content/quotes-009-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-009.html: Added.
  • web-platform-tests/css/css-content/quotes-010-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-010.html: Added.
  • web-platform-tests/css/css-content/quotes-011-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-011.html: Added.
  • web-platform-tests/css/css-content/quotes-012-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-012.html: Added.
  • web-platform-tests/css/css-content/quotes-013-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-013.html: Added.
  • web-platform-tests/css/css-content/quotes-014-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-014.html: Added.
  • web-platform-tests/css/css-content/quotes-015-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-015.html: Added.
  • web-platform-tests/css/css-content/quotes-016-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-016.html: Added.
  • web-platform-tests/css/css-content/quotes-017-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-017.html: Added.
  • web-platform-tests/css/css-content/quotes-018-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-018.html: Added.
  • web-platform-tests/css/css-content/quotes-019-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-019.html: Added.
  • web-platform-tests/css/css-content/quotes-020-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-020.html: Added.
  • web-platform-tests/css/css-content/quotes-021-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-021.html: Added.
  • web-platform-tests/css/css-content/quotes-022-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-022.html: Added.
  • web-platform-tests/css/css-content/quotes-023-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-023.html: Added.
  • web-platform-tests/css/css-content/quotes-024-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-024.html: Added.
  • web-platform-tests/css/css-content/quotes-025-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-025.html: Added.
  • web-platform-tests/css/css-content/quotes-026-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-026.html: Added.
  • web-platform-tests/css/css-content/quotes-027-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-027.html: Added.
  • web-platform-tests/css/css-content/quotes-028-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-028.html: Added.
  • web-platform-tests/css/css-content/quotes-029-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-029.html: Added.
  • web-platform-tests/css/css-content/quotes-030-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-030.html: Added.
  • web-platform-tests/css/css-content/quotes-031-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-031.html: Added.
  • web-platform-tests/css/css-content/quotes-032-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-032.html: Added.
  • web-platform-tests/css/css-content/quotes-033-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-033.html: Added.
  • web-platform-tests/css/css-content/quotes-034-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-034.html: Added.
  • web-platform-tests/css/css-content/resources/rect.svg: Added.
  • web-platform-tests/css/css-content/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/css/css-content/META.yml: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
  • web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
  • web-platform-tests/css/css-content/computed-value-expected.txt: Added.
  • web-platform-tests/css/css-content/computed-value.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
  • web-platform-tests/css/css-content/element-replacement-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
  • web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
  • web-platform-tests/css/css-content/element-replacement.html: Added.
  • web-platform-tests/css/css-content/inheritance-expected.txt: Added.
  • web-platform-tests/css/css-content/inheritance.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
  • web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
  • web-platform-tests/css/css-content/quotes-001-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-001.html: Added.
  • web-platform-tests/css/css-content/quotes-002-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-002.html: Added.
  • web-platform-tests/css/css-content/quotes-003-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-003.html: Added.
  • web-platform-tests/css/css-content/quotes-004-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-004.html: Added.
  • web-platform-tests/css/css-content/quotes-005-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-005.html: Added.
  • web-platform-tests/css/css-content/quotes-006-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-006.html: Added.
  • web-platform-tests/css/css-content/quotes-007-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-007.html: Added.
  • web-platform-tests/css/css-content/quotes-008-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-008.html: Added.
  • web-platform-tests/css/css-content/quotes-009-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-009.html: Added.
  • web-platform-tests/css/css-content/quotes-010-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-010.html: Added.
  • web-platform-tests/css/css-content/quotes-011-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-011.html: Added.
  • web-platform-tests/css/css-content/quotes-012-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-012.html: Added.
  • web-platform-tests/css/css-content/quotes-013-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-013.html: Added.
  • web-platform-tests/css/css-content/quotes-014-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-014.html: Added.
  • web-platform-tests/css/css-content/quotes-015-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-015.html: Added.
  • web-platform-tests/css/css-content/quotes-016-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-016.html: Added.
  • web-platform-tests/css/css-content/quotes-017-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-017.html: Added.
  • web-platform-tests/css/css-content/quotes-018-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-018.html: Added.
  • web-platform-tests/css/css-content/quotes-019-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-019.html: Added.
  • web-platform-tests/css/css-content/quotes-020-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-020.html: Added.
  • web-platform-tests/css/css-content/quotes-021-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-021.html: Added.
  • web-platform-tests/css/css-content/quotes-022-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-022.html: Added.
  • web-platform-tests/css/css-content/quotes-023-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-023.html: Added.
  • web-platform-tests/css/css-content/quotes-024-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-024.html: Added.
  • web-platform-tests/css/css-content/quotes-025-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-025.html: Added.
  • web-platform-tests/css/css-content/quotes-026-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-026.html: Added.
  • web-platform-tests/css/css-content/quotes-027-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-027.html: Added.
  • web-platform-tests/css/css-content/quotes-028-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-028.html: Added.
  • web-platform-tests/css/css-content/quotes-029-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-029.html: Added.
  • web-platform-tests/css/css-content/quotes-030-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-030.html: Added.
  • web-platform-tests/css/css-content/quotes-031-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-031.html: Added.
  • web-platform-tests/css/css-content/quotes-032-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-032.html: Added.
  • web-platform-tests/css/css-content/quotes-033-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-033.html: Added.
  • web-platform-tests/css/css-content/quotes-034-expected.html: Added.
  • web-platform-tests/css/css-content/quotes-034.html: Added.
  • web-platform-tests/css/css-content/resources/rect.svg: Added.
  • web-platform-tests/css/css-content/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests:

3:34 PM Changeset in webkit [266037] by ysuzuki@apple.com
  • 5 edits in trunk

Unreviewed, workaround for old ICU headers in macOS Catalina bots
​https://bugs.webkit.org/show_bug.cgi?id=209774

EWS and Catalina bots are inconsistent in terms of ICU header versions.
This patch adds a workaround which checks ICU header version too at runtime.

JSTests:

  • stress/intl-numberformat-unified-ja.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

  • stress/intl-numberformat-unified.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

Source/JavaScriptCore:

  • tools/JSDollarVM.cpp:

(JSC::functionICUHeaderVersion):
(JSC::JSDollarVM::finishCreation):

3:25 PM Changeset in webkit [266036] by Alexey Shvayka
  • 4 edits in trunk

The ThrowTypeError? function object must not be extensible
​https://bugs.webkit.org/show_bug.cgi?id=108873

Reviewed by Yusuke Suzuki.

JSTests:

  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This patch:

  1. Sets the value of %ThrowTypeError% "name" property to the empty string, as required [1] for anonymous built-in functions.
  1. Calls JSObject::freeze() on %ThrowTypeError%, making it non-extensible and its "name" and "length" properties non-configurable to match the spec [2].

Both changes align JSC with V8 and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects
[2]: ​https://tc39.es/ecma262/#sec-%throwtypeerror%

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

1:41 PM Changeset in webkit [266035] by ysuzuki@apple.com
  • 8 edits
    3 adds in trunk

[ECMA-402] Intl.DateTimeFormat dateStyle/timeStyle missing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=209776

Reviewed by Darin Adler and Ross Kirsling.

JSTests:

  • stress/intl-date-time-format-date-time-style-basic.js: Added.

(shouldBe):
(shouldBe.o.format):

  • stress/intl-date-time-format-date-time-style-hour-cycle.js: Added.

(shouldBe):
(shouldBe.o.format):

  • stress/intl-date-time-style-option-consistency.js: Added.

(shouldThrow):
(value.of.Object.entries):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.DateTimeFormat dateStyle and timeStyle options. When it is specified,
we query the best date-time format with these options to ICU instead of configuring each date-time
formats.

Since ECMA402 requires enforcement of hourCycle specified from the option, even if ICU ignores that.
So, after getting the appropriate pattern from ICU, we modify this pattern and re-create UDateFormat
from the modified pattern.

  • builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

  • runtime/CommonIdentifiers.h:
  • runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::formatStyleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):

  • runtime/IntlDateTimeFormat.h:
1:30 PM Changeset in webkit [266034] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Unreviewed, Catalina test262 bot is using older SDK than actual Catalina's one

We should update the bot. For now, skipping these tests.

  • test262/config.yaml:
1:16 PM Changeset in webkit [266033] by ysuzuki@apple.com
  • 7 edits
    3 adds in trunk

[ECMA-402] Implement Intl.DateTimeFormat.prototype.formatRange
​https://bugs.webkit.org/show_bug.cgi?id=209778

Reviewed by Ross Kirsling.

JSTests:

test262 failures are due to either of

  1. formatRangeToParts is missing
  2. ICU version difference
  • stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js: Added.

(shouldBe):
(shouldThrow):
(vm.icuVersion):

  • stress/intl-datetimeformat-formatrange-relevant-extensions.js: Added.

(shouldBe):
(shouldThrow):

  • stress/intl-datetimeformat-formatrange.js: Added.

(shouldBe):
(shouldThrow):
(test):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds Intl.DateTimeFormat#formatRange. It takes two dates, and
generates formatted text which represents interval between these two dates.
We skip the implementation of Intl.DateTimeFormat#formatRangeToParts since
ICU udtitvfmt_formatToResult API is not getting stable state yet. We retrieve
pattern from UDateFormat, get skeleton from that pattern, and construct
UDateIntervalFormat from this skeleton.

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):
(JSC::IntlDateTimeFormat::formatRange):
(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeFuncFormatRange):

12:22 PM Changeset in webkit [266032] by ysuzuki@apple.com
  • 21 edits
    15 adds in trunk

[JSC] Add Intl.Segmenter
​https://bugs.webkit.org/show_bug.cgi?id=213638

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-segmenter.js: Added.

(shouldBe):
(shouldNotThrow):
(func):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.Segmenter[1]. Intl.Segmenter offers access to ICU break iterator feature, which can break strings into grapheme cluster / words / sentences.

[1]: ​https://github.com/tc39/proposal-intl-segmenter

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • runtime/CommonIdentifiers.h:
  • runtime/IntlObject.cpp:

(JSC::createSegmenterConstructor):
(JSC::IntlObject::finishCreation):
(JSC::intlSegmenterAvailableLocales):

  • runtime/IntlObject.h:
  • runtime/IntlSegmentIterator.cpp: Added.

(JSC::IntlSegmentIterator::create):
(JSC::IntlSegmentIterator::createStructure):
(JSC::IntlSegmentIterator::IntlSegmentIterator):
(JSC::IntlSegmentIterator::finishCreation):
(JSC::IntlSegmentIterator::visitChildren):
(JSC::IntlSegmentIterator::next):

  • runtime/IntlSegmentIterator.h: Added.
  • runtime/IntlSegmentIteratorPrototype.cpp: Added.

(JSC::IntlSegmentIteratorPrototype::create):
(JSC::IntlSegmentIteratorPrototype::createStructure):
(JSC::IntlSegmentIteratorPrototype::IntlSegmentIteratorPrototype):
(JSC::IntlSegmentIteratorPrototype::finishCreation):
(JSC::IntlSegmentIteratorPrototypeFuncNext):

  • runtime/IntlSegmentIteratorPrototype.h: Added.
  • runtime/IntlSegmenter.cpp: Added.

(JSC::IntlSegmenter::create):
(JSC::IntlSegmenter::createStructure):
(JSC::IntlSegmenter::IntlSegmenter):
(JSC::IntlSegmenter::finishCreation):
(JSC::IntlSegmenter::initializeSegmenter):
(JSC::IntlSegmenter::segment const):
(JSC::IntlSegmenter::resolvedOptions const):
(JSC::IntlSegmenter::granularityString):
(JSC::IntlSegmenter::createSegmentDataObject):

  • runtime/IntlSegmenter.h: Added.
  • runtime/IntlSegmenterConstructor.cpp: Added.

(JSC::IntlSegmenterConstructor::create):
(JSC::IntlSegmenterConstructor::createStructure):
(JSC::IntlSegmenterConstructor::IntlSegmenterConstructor):
(JSC::IntlSegmenterConstructor::finishCreation):
(JSC::constructIntlSegmenter):
(JSC::callIntlSegmenter):
(JSC::IntlSegmenterConstructorSupportedLocalesOf):

  • runtime/IntlSegmenterConstructor.h: Added.
  • runtime/IntlSegmenterPrototype.cpp: Added.

(JSC::IntlSegmenterPrototype::create):
(JSC::IntlSegmenterPrototype::createStructure):
(JSC::IntlSegmenterPrototype::IntlSegmenterPrototype):
(JSC::IntlSegmenterPrototype::finishCreation):
(JSC::IntlSegmenterPrototypeFuncSegment):
(JSC::IntlSegmenterPrototypeFuncResolvedOptions):

  • runtime/IntlSegmenterPrototype.h: Added.
  • runtime/IntlSegments.cpp: Added.

(JSC::IntlSegments::create):
(JSC::IntlSegments::createStructure):
(JSC::IntlSegments::IntlSegments):
(JSC::IntlSegments::finishCreation):
(JSC::IntlSegments::containing):
(JSC::IntlSegments::createSegmentIterator):
(JSC::IntlSegments::visitChildren):

  • runtime/IntlSegments.h: Added.
  • runtime/IntlSegmentsPrototype.cpp: Added.

(JSC::IntlSegmentsPrototype::create):
(JSC::IntlSegmentsPrototype::createStructure):
(JSC::IntlSegmentsPrototype::IntlSegmentsPrototype):
(JSC::IntlSegmentsPrototype::finishCreation):
(JSC::IntlSegmentsPrototypeFuncContaining):
(JSC::IntlSegmentsPrototypeFuncIterator):

  • runtime/IntlSegmentsPrototype.h: Added.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::segmentIteratorStructure):
(JSC::JSGlobalObject::segmenterStructure):
(JSC::JSGlobalObject::segmentsStructure):

  • runtime/OptionsList.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/text/WTFString.cpp:

(WTF::String::charactersWithoutNullTermination const):
(WTF::String::charactersWithNullTermination const):

  • wtf/text/WTFString.h:
11:32 AM Changeset in webkit [266031] by ysuzuki@apple.com
  • 17 edits
    3 adds in trunk

[ECMA-402] Implement unified Intl.NumberFormat
​https://bugs.webkit.org/show_bug.cgi?id=209774

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

All test262 failures are due to old ICU version. Once ICU is updated, they will go away.

  • stress/intl-numberformat-unified-ja.js: Added.

(shouldBe):
(vm.icuVersion):

  • stress/intl-numberformat-unified.js: Added.

(shouldBe):
(vm.icuVersion):

  • stress/intl-numberformat.js:

(testNumberFormat):
(shouldBe.testNumberFormat.Intl.NumberFormat):

  • test262/config.yaml:
  • test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements updated Intl.NumberFormat. This update was proposed in [1], and integrated into ECMA-402 spec.
This patch adds support for missing features in the previous Intl.NumberFormat implementation. Adding "unit", "unitDisplay",
"signDisplay", "notation", and "currencySign". Then Intl.NumberFormat can now handle "unit" etc.

To support new features, we need to use UNumberFormatter which is available after ICU 64 (while it is offered in ICU 62, some
critical part are added in 64 too). So, we keep the old UNumberFormat based implementation which is used for [60, 64) since WebKit
currently supports ICU 60. Old implementation does not support new things. If ICU is 64 or later, Intl.NumberFormat starts using
UNumberFormatter, and implements all the specified features.

[1]: ​https://github.com/tc39/proposal-unified-intl-numberformat

(JSC::IntlCollator::UCollatorDeleter::operator() const): Deleted.

  • runtime/IntlCollator.h:
  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::sanctionedSimpleUnitIdentifier):
(JSC::WellFormedUnit::WellFormedUnit):
(JSC::wellFormedUnitIdentifier):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::format const):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::notationString):
(JSC::IntlNumberFormat::currencySignString):
(JSC::IntlNumberFormat::unitDisplayString):
(JSC::IntlNumberFormat::compactDisplayString):
(JSC::IntlNumberFormat::signDisplayString):
(JSC::IntlNumberFormat::resolvedOptions const):
(JSC::partTypeString):
(JSC::IntlNumberFormat::formatToPartsInternal):
(JSC::IntlNumberFormat::formatToParts const):
(JSC::IntlNumberFormat::UNumberFormatDeleter::operator() const): Deleted.

  • runtime/IntlNumberFormat.h:
  • runtime/IntlNumberFormatInlines.h: Added.

(JSC::setNumberFormatDigitOptions):
(JSC::IntlFieldIterator::IntlFieldIterator):
(JSC::IntlFieldIterator::next):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions const):
(JSC::IntlPluralRules::UPluralRulesDeleter::operator() const): Deleted.
(JSC::IntlPluralRules::UNumberFormatDeleter::operator() const): Deleted.
(JSC::UEnumerationDeleter::operator() const): Deleted.

  • runtime/IntlPluralRules.h:
  • runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::formatToParts const):
(JSC::IntlRelativeTimeFormat::URelativeDateTimeFormatterDeleter::operator() const): Deleted.
(JSC::IntlRelativeTimeFormat::UNumberFormatDeleter::operator() const): Deleted.

  • runtime/IntlRelativeTimeFormat.h:
  • tools/JSDollarVM.cpp:

(JSC::functionICUVersion):

11:08 AM Changeset in webkit [266030] by ysuzuki@apple.com
  • 16 edits
    28 adds in trunk

Console object's @@toStringTag should be "console" instead of "Console"
​https://bugs.webkit.org/show_bug.cgi?id=215750

Reviewed by Ross Kirsling.

LayoutTests/imported/w3c:

Import ToT wpt/console tests including @@toStringTag tests.

  • resources/import-expectations.json:
  • web-platform-tests/console/META.yml: Added.
  • web-platform-tests/console/console-is-a-namespace.any-expected.txt: Added.
  • web-platform-tests/console/console-is-a-namespace.any.html: Added.
  • web-platform-tests/console/console-is-a-namespace.any.js: Added.

(test):

  • web-platform-tests/console/console-is-a-namespace.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-is-a-namespace.any.worker.html: Added.
  • web-platform-tests/console/console-label-conversion.any-expected.txt: Added.
  • web-platform-tests/console/console-label-conversion.any.html: Added.
  • web-platform-tests/console/console-label-conversion.any.js: Added.

(const.method.of.methods.test):

  • web-platform-tests/console/console-label-conversion.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-label-conversion.any.worker.html: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any-expected.txt: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.html: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.js: Added.

(test):
(test.t.t.add_cleanup):

  • web-platform-tests/console/console-namespace-object-class-string.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-namespace-object-class-string.any.worker.html: Added.
  • web-platform-tests/console/console-tests-historical.any-expected.txt: Added.
  • web-platform-tests/console/console-tests-historical.any.html: Added.
  • web-platform-tests/console/console-tests-historical.any.js: Added.

(test):

  • web-platform-tests/console/console-tests-historical.any.worker-expected.txt: Added.
  • web-platform-tests/console/console-tests-historical.any.worker.html: Added.
  • web-platform-tests/console/idlharness.any-expected.txt: Added.
  • web-platform-tests/console/idlharness.any.html: Added.
  • web-platform-tests/console/idlharness.any.js: Added.
  • web-platform-tests/console/idlharness.any.worker-expected.txt: Added.
  • web-platform-tests/console/idlharness.any.worker.html: Added.
  • web-platform-tests/console/w3c-import.log: Added.

Source/JavaScriptCore:

Use "console" instead of "Console". Now, namespace object has @@toStringTag.
​https://github.com/web-platform-tests/wpt/pull/24717

  • runtime/ConsoleObject.cpp:

LayoutTests:

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/loader/window-properties-restored-from-page-cache-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • inspector/debugger/pause-for-internal-scripts-expected.txt:
  • inspector/debugger/stepping/stepping-internal-scripts-expected.txt:
  • js/console-expected.txt:
  • js/console.html:
  • platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:
10:57 AM Changeset in webkit [266029] by ysuzuki@apple.com
  • 8 edits in trunk

[JSC] Enable Intl.DisplayNames
​https://bugs.webkit.org/show_bug.cgi?id=215749

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-displaynames.js:
  • stress/intl-parse-unicode-subtags.js:
  • stress/intl-suppored-locales-of.js:
  • test262/config.yaml:

Source/JavaScriptCore:

Enable Intl.DisplayNames by default. This is already stage 4 and integrated into the spec.

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

  • runtime/OptionsList.h:
9:16 AM Changeset in webkit [266028] by Darin Adler
  • 24 edits in trunk

Move node geometry functions from Range to RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=215677

Reviewed by Zalan Bujtas.

Source/WebCore:

Moved functions that return quads and rectangles out of Range into RenderObject.
We could find another home for them, but for now they make sense as static member
functions there since RenderObject has the non-static member functions that they
call on multiple nodes. Mostly did not change the design of these functions much,
and was careful not to change behavior at all. But did change a few things:

  • Got rid of the functions that return a single unioned rectangle. Instead callers call unionRect at each call site.
  • Changed the "use selection height" boolean to a BoundingRectBehavior flag.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::boundsForRects): Call unionRect(RenderObject::absoluteTextRects) instead
of Range::absoluteBoundingBox.

  • dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Instead of passing "true", pass
"RenderObject::BoundingRectBehavior::UseSelectionHeight".

  • dom/Range.cpp:

(WebCore::Range::absoluteBoundingBox const): Deleted.
(WebCore::Range::absoluteRectsForRangeInText const): Deleted.
(WebCore::Range::absoluteTextRects const): Deleted.
(WebCore::Range::getClientRects const): Call RenderObject::clientBorderAndTextRects.
(WebCore::Range::getBoundingClientRect const): Call
unionRect(RenderObject::clientBorderAndTextRects).
(WebCore::Range::borderAndTextRects const): Deleted.
(WebCore::Range::boundingRect const): Deleted.
(WebCore::Range::absoluteBoundingRect const): Deleted.

  • dom/Range.h: Updated for above.
  • dom/SimpleRange.cpp:

(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Fix bug affecting
empty ranges by calling enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advance): Refactor to call enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advanceSkippingChildren): Ditto.
(WebCore::IntersectingNodeIterator::enforceEndInvariant): Added.

  • dom/SimpleRange.h: Added enforceEndInvariant.
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::getClippedVisibleTextRectangles const): Instead of
passing a useSelectionHeight boolean, pass BoundingRectBehavior.

  • page/TextIndicator.cpp:

(WebCore::absoluteBoundingRectForRange): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebCore::initializeIndicator): Call RenderObject::absoluteTextRects.

  • platform/graphics/GeometryUtilities.cpp:

(WebCore::unionRectIgnoringZeroRects): Added.

  • platform/graphics/GeometryUtilities.h: Updated for above.
  • rendering/RenderLineBreak.h: Marked a lot of functions final.

Added a default value for the absoluteQuads out argument.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect): Tweaked code style a bit.
(WebCore::RenderObject::absoluteTextQuads): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument. Also added a downcast so the
call to RenderLineBreak::absoluteQuads is a non-virtual function call.
(WebCore::absoluteRectsForRangeInText): Added.
(WebCore::RenderObject::absoluteTextRects): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument.
(WebCore::nodeBefore): Added.
(WebCore::borderAndTextRects): Added.
(WebCore::RenderObject::absoluteBorderAndTextRects): Added.
(WebCore::RenderObject::clientBorderAndTextRects): Added.

  • rendering/RenderObject.h: Updated for above.

Source/WebKit:

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates const):
Call unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebKit::InjectedBundleRangeHandle::renderedImage): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestEvasionRectsAboveSelection): Call
unionRect(RenderObject::absoluteTextRects).
(WebKit::WebPage::requestDocumentEditingContext): Call
unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/mac:

  • DOM/DOM.mm:

(-[DOMRange boundingBox]): Call unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/win:

  • AccessibleTextImpl.cpp:

(AccessibleText::scrollSubstringTo): Call
unionRect(RenderObject::absoluteTextRects) instead of
Range::absoluteBoundingBox.

LayoutTests:

  • fast/dom/Range/scale-page-bounding-client-rect.html: Fix this test that accidentally

depended on getting rects for an empty range (the contents of a div element with no
text inside it) to instead get rects for a non-empty element (the div element, not
just its contents). Test now works correctly, but results don't need to change.

  • fast/dom/Range/scale-page-client-rects.html: Ditto.
9:13 AM Changeset in webkit [266027] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Make some small improvements involving sorting
​https://bugs.webkit.org/show_bug.cgi?id=215617

Reviewed by Anders Carlsson.

  • contentextensions/DFA.cpp:

(WebCore::ContentExtensions::printTransitions): Fixed "incomming" spelling error.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet): Use std::stable_sort instead of std::sort
because there is no guarantee that each image has different resolution and we want
repeatable behavior when they are the same.

  • page/Performance.cpp:

(WebCore::Performance::appendBufferedEntriesByType const): Removed the return
value since we don't need it any more.

  • page/Performance.h: Updated for above.
  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe): Use std::stable_sort only on the new
entries and then use std::inplace_merge. It's wasteful to re-sort the entire
array when adding entries. A little less elegant, but more efficient.

9:11 AM Changeset in webkit [266026] by Darin Adler
  • 35 edits
    1 add in trunk

Create documentOrder function, start refactoring to use it instead of Range::compare functions
​https://bugs.webkit.org/show_bug.cgi?id=215551

Reviewed by Chris Dumez.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Make TextControlInnerElements.h Private so

we can use it from unit tests.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text const): Tweak code slightly.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedTextRange const): Always use the native
text control's idea of the selected text range. There is no need to use the
document-based range with any of these native text controls. The check before would
almost always return true, except for unusual cases, particularly combo box, which
returns false for isARIATextControl. We may want to change isARIATextControl to
return true for combo box, but it's not necessary for this fix. Without this change,
a test involving a combo box was failing because changes caused
documentBasedSelectedTextRange to no longer accidentally do the right thing.

  • dom/BoundaryPoint.h: Added != and documentOrder.
  • dom/Document.h: Export allocation function and constructor so we can allocate

in a unit test.

  • dom/Node.cpp:

(WebCore::connectedInSameTreeScope): Renamed from areNodesConnectedInSameTreeScope.
(WebCore::Node::compareDocumentPosition): Updated for name change above.
(WebCore::depth): Changed to take a const& and to walk acrosss shadow host boundaries,
so this can be used in algorithms that are intended to work on the combined tree.
Has no effect when called on nodes that are not in a shadow tree.
(WebCore::commonInclusiveAncestorAndChildren): Refactored so this can be used by
callers that need to know the distinct ancestor children as well as the common
ancestor. Also revised it to work across shadow tree boundaries.
(WebCore::commonInclusiveAncestor): Updated to call commonInclusiveAncestorAndChildren.
(WebCore::isSiblingSubsequent): Added.
(WebCore::documentOrder): Added. Implemented using commonInclusiveAncestorAndChildren and
isSiblingSubsequent.

  • dom/Node.h: Updated for above. Also added PartialOrdering class, a compatible

subset of C++20's std::partial_ordering, for return value for documentOrder.

  • dom/Position.cpp:

(WebCore::Position::computeOffsetInContainerNode const): Removed clamping the
result to the length of the container node; not needed.
(WebCore::Position::previous const): Updated for name change.
(WebCore::Position::next const): Updated for name change.
(WebCore::Position::upstream const): Updated for name change.
(WebCore::Position::downstream const): Updated for name change.
(WebCore::commonInclusiveAncestor): Renamed from commonShadowIncludingAncestor
since this is now the same as the commonInclusiveAncestor that takes two nodes;
they now both take shadow trees into account.
(WebCore::makeContainerOffsetPosition): Added. Clearer way to construct
positions from containers and offsets. An alternative to makeDeprecatedLegacyPosition
for cases where we don't need the deprecated legacy behavior.
(WebCore::makeDeprecatedLegacyPosition): Renamed from createLegacyEditingPosition.
Adding the word "deprecated" to be clearer that this is not just "legacy" but also
something we are trying to get rid of. Changing from "create" to "make" because
this does not allocate memory on the heap.
(WebCore::documentOrder): Added. Still to do: more optimized implementation when
we can compare two positions without computing node offsets.

  • dom/Position.h: Updated for above.

(WebCore::minOffsetForNode): Deleted.

  • dom/RadioButtonGroups.cpp:

(WebCore::RadioButtonGroup::members const): Use documentOrder instead of
documentOrderComparator.

  • dom/Range.cpp:

(WebCore::areRangesEqual): Rewrote to not use Position.
(WebCore::rangesOverlap): Updated for name change.
(WebCore::Range::expand): Rewrote to not use Range::start/endPosition.
(WebCore::operator<<): Deleted.

  • dom/Range.h: Removed now-unused Range::start/endPosition, documentOrderComparator,

and TextStream operators.

  • dom/RangeBoundaryPoint.h: Removed now-unused RangeBoundaryPoint::toPosition.

Added makeBoundaryPoint function to convert RangeBoundaryPoint into BoundaryPoint.

  • dom/SimpleRange.cpp:

(WebCore::isOffsetBeforeChild): Added. For use by documentOrder.
(WebCore::documentOrder): Added.

  • editing/TextIterator.cpp:

(WebCore::characterCount): Use documentOrder instead of
Range::compareBoundaryPoints.

  • editing/VisiblePosition.cpp:

(WebCore::areVisiblePositionsInSameTreeScope): Updated for name change.

  • editing/VisiblePosition.h: Use assignment insteed of calling clear,

to possibly prepare to get rid of Position::clear in the future.
Added a documentORder function that takes two visible positions.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted): Use
commonInclusiveAncestor instead of commonShadowIncludingAncestor.

  • editing/markup.cpp:

(WebCore::serializePreservingVisualAppearanceInternal): Ditto.

  • html/HTMLBodyElement.h: Export create function so it can used in unit tests.
  • html/HTMLDivElement.h: Ditto.
  • html/HTMLHtmlElement.h: Ditto.
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::create): Added so it can be used in unit tests.

  • html/HTMLTextAreaElement.h: Ditto. Also export the innerTextElement function

so it can be used in unit tests.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use makeDeprecatedLegacyPosition directly
rather than using Range::start/endPosition. This was the only place in WebCore
still using Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good to
have it be explicit here rather than hidden inside the Range class.
(WebCore::DOMSelection::containsNode const): Added a check of containingShadowRoot.
This preserves the old behavior. Before, constructing the range resulted in
a collapsed range when the shadow tree was involved. This is a more direct way
to achieve the same result.

  • page/Page.cpp:

(WebCore::replaceRanges): Use documentOrder instead of comparePositions.
Eventually we will delete comparePositions.

Source/WebKit:

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange rangeByExpandingToWordBoundaryByCharacters:inDirection:]):
Use makeDeprecatedLegacyPosition instead of Range::start/endPosition.
This was the only place in the WebKit framework still using
Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good
to have it be explicit here rather than hidden inside the Range class.

Source/WebKitLegacy/ios:

  • WebCoreSupport/WebVisiblePosition.mm:

(-[DOMRange startPosition]): Rewrote to not use Range::startPosition.
(-[DOMRange endPosition]): Rewrote to not use Range::endPosition.

Source/WebKitLegacy/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
Rewrite to use makeSimpleRange and makeContainerOffsetPosition. Simplifies
the null checks. Would love to remove the function but at this time it's
still used by Apple's Mail app (albeit in a peculiar way, always passing a
constant string).

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added DocumentOrder.cpp.
  • TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Added.

Relatively thorough test of three different documentOrder functions.
Could still use even more test cases involving different types of shadow trees.

7:33 AM Changeset in webkit [266025] by Philippe Normand
  • 14 edits in trunk

[GTK][WPE] Compilation warnings with clang/gcc 10
​https://bugs.webkit.org/show_bug.cgi?id=215699

Reviewed by Darin Adler.

.:

  • Source/cmake/WebKitCompilerFlags.cmake: Disable tautological-compare and

misleading-indentation warnings triggering false-positive when building JSC.

Source/WebCore:

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h: Mark class as final because its destructor is marked as such.

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseDirectory const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::sessionID const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseRootDirectoryIsolatedCopy const): Deleted.

  • dom/messageports/MessagePortChannelProviderImpl.h: Ditto.
  • layout/Verification.cpp:

(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded): Remove spurious
matchingRuns assignment. I have no idea how this was supposed to work?

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): Use FALLTHROUGH macro.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decodeFrame): Ditto.

Source/WebKit:

  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Use null input touch event enum value for touch event handling.

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Wrap m_geometry private field in GTK

ifdefs, this is not used in WPE.

  • WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowFrame): Return rect built with explicit initializers.

  • wpe/backends/WindowViewBackend.cpp: Supply additional touch client callbacks, mandated by the interface.
6:25 AM Changeset in webkit [266024] by Lauro Moura
  • 2 edits in trunk/Tools

Unreviewed, reverting r266012.

Fix API tests after r266020

Reverted changeset:

"[GLIB] Update checked exception after r265942"
​https://bugs.webkit.org/show_bug.cgi?id=215738
​https://trac.webkit.org/changeset/266012

1:27 AM Changeset in webkit [266023] by ysuzuki@apple.com
  • 2 edits in trunk/Tools

Unreviewed, add slackId to my contributors.json entry

Slack allows multiple users having the same name. How to identify one user in slack is using Slack member ID.
Try setting a slackId and leverage it via WKR / WebKitBot.

  • Scripts/webkitpy/common/config/contributors.json:

Aug 21, 2020:

6:32 PM Changeset in webkit [266022] by Alexey Shvayka
  • 2 edits in trunk/Source/JavaScriptCore

StrictEq should not care about masqueradesAsUndefinedWatchpoint
​https://bugs.webkit.org/show_bug.cgi?id=215743

Reviewed by Yusuke Suzuki.

This patch removes masqueradesAsUndefinedWatchpoint handling for StrictEq
from fixupCompareStrictEqAndSameValue(), aligning it with SameValue.

According to the spec [1], only a few language constructs special-case
IsHTMLDDA? objects: ToBoolean, abstract equality, and typeof.

No behavior change.

[1]: ​https://tc39.es/ecma262/#sec-IsHTMLDDA-internal-slot

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):

5:52 PM Changeset in webkit [266021] by Wenson Hsieh
  • 4 edits
    1 add in trunk

[macOS] Unable to copy text from the function browser panel in Numbers
​https://bugs.webkit.org/show_bug.cgi?id=215740
<rdar://problem/65189303>

Reviewed by Darin Adler.

Source/WebKit:

On some versions of Xcode, using Interface Builder to set up WKWebViews causes the WKWebView to contain two
WKFlippedViews as subviews; one of these is created and added in the normal initialization path of the web view
underneath WebViewImpl's constructor, and the other is created and added underneath the superclass (NSView's)
-initWithCoder: implementation.

This causes issues when hit-testing WKWebView using the -hitTest: method, which is expected to return the
WKWebView itself instead of the inner WKFlippedView. The logic that tries to implement this behavior is in
WebViewImpl::hitTest, which calls into WKWebView's -hitTest: method and returns the WKWebView if the hit-
tested view ended up being equal to the m_layerHostingView. Since we end up with two layer hosting views (only
one of which is the real m_layerHostingView), we fail the check and end up returning the other WKFlippedView.
In the context of this bug, this erroneous hit-test causes AppKit to ask if the WKFlippedView can become the
first responder upon mousedown (which it cannot), and so the window's first responder remains the same (instead
of changing to WKWebView).

To fix this, adjust the constructor of WebViewImpl to avoid making an extra layer hosting view in the case where
decoding the WKWebView already initialized and placed the layer hosting view, and just use the existing one
instead.

Test: WKWebView.HitTestAfterInitializingFromCoder

  • UIProcess/Cocoa/WebViewImpl.mm:

(-[WKFlippedView initWithFrame:]):
(-[WKFlippedView initWithCoder:]):
(-[WKFlippedView _commonInitialize]):

Override both designated initialization codepaths so that we call the -_commonInitialize helper, which sets
the autoresizing mask. This was previously called immediately after creating the WKFlippedView in the
constructor of WebViewImpl.

(WebKit::WebViewImpl::WebViewImpl):

Tools:

Add a new API test that serializes a WKWebView, then deserializes it, and then verifies that calling -hitTest:
on the deserialized WKWebView grabs the WKWebView itself rather than the WKFlippedView underneath it.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WKWebViewCoders.mm: Added.
5:20 PM Changeset in webkit [266020] by Jonathan Bedard
  • 2 edits
    1 add in trunk/Tools

Regression (r265942): Layout-tests are hanging on iOS EWS
​https://bugs.webkit.org/show_bug.cgi?id=215742
<rdar://problem/67584717>

Unreviewed infrastructure fix.

Partial revert of r265942, since EWS is raising objc exceptions after forking.

  • Scripts/webkitpy/common/timeout_context.py:

(Timeout):

  • Scripts/webkitpy/common/timeout_context_unittest.py: Added.

(TimeoutContextTests):

4:46 PM Changeset in webkit [266019] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r265965.
​https://bugs.webkit.org/show_bug.cgi?id=215744

getCallData can be called from DFG concurrent compiler, but it
is not safe in DOM PluginObject

Reverted changeset:

"Use jsTypeofIsObject() in DFG AI and
operationTypeOfIsObject()"
​https://bugs.webkit.org/show_bug.cgi?id=144457
​https://trac.webkit.org/changeset/265965

4:07 PM Changeset in webkit [266018] by Alexey Shvayka
  • 10 edits in trunk

Align "length" properties of function prototypes with the spec
​https://bugs.webkit.org/show_bug.cgi?id=215716

Reviewed by Ross Kirsling.

JSTests:

  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This change defines Function.prototype.length [1] as Configurable? and
removes "length" properties from other (async/generator) function prototypes
that are ordinary non-callable objects [2], aligning JSC with V8 and SpiderMonkey.

Also, adds inherits() ASSERT in FunctionPrototype::finishCreation()
to match (most of) the other built-ins.

[1]: ​https://tc39.es/ecma262/#sec-properties-of-the-function-prototype-object
[2]: ​https://tc39.es/ecma262/#sec-async-function-prototype-properties

  • runtime/AsyncFunctionPrototype.cpp:

(JSC::AsyncFunctionPrototype::finishCreation):

  • runtime/AsyncGeneratorFunctionPrototype.cpp:

(JSC::AsyncGeneratorFunctionPrototype::finishCreation):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::finishCreation):

  • runtime/GeneratorFunctionPrototype.cpp:

(JSC::GeneratorFunctionPrototype::finishCreation):

LayoutTests:

  • js/kde/prototype_length-expected.txt:
  • js/kde/script-tests/prototype_length.js:
3:49 PM Changeset in webkit [266017] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the Color/ExtendedColor lldb data provider
​https://bugs.webkit.org/show_bug.cgi?id=215735

Reviewed by Darin Adler.

Fix the data provider for Color after Color and ExtendedColor internals changed.

  • lldb/lldb_webkit.py:

(WebCoreColorProvider._to_string_extended):
(WebCoreColorProvider.to_string):

3:49 PM Changeset in webkit [266016] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Add some FIXMEs in the EventHandler wheel event handling code for all the things that are wrong
​https://bugs.webkit.org/show_bug.cgi?id=215741

Reviewed by Wenson Hsieh.

There is much confusing code here. Trying to document the issues I've found.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

2:30 PM Changeset in webkit [266015] by Alexey Shvayka
  • 5 edits in trunk

Define Intl[Symbol.toStringTag]
​https://bugs.webkit.org/show_bug.cgi?id=215715

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-object.js:
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch utilizes JSC_TO_STRING_TAG_WITHOUT_TRANSITION() to define Symbol.toStringTag
on Intl namespace object, implementing the recent spec change [1] and aligning JSC with V8.
Also, adds inherits() ASSERT to match (most of) the other built-ins.

[1]: ​https://github.com/tc39/ecma402/pull/487

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

2:29 PM Changeset in webkit [266014] by aestes@apple.com
  • 4 edits in trunk/Source/WebKit

IPC::encodeSharedBuffer combines SharedBuffer data segments when copying to SharedMemory
​https://bugs.webkit.org/show_bug.cgi?id=215737
<rdar://problem/67568099>

Reviewed by Darin Adler.

IPC::encodeSharedBuffer called SharedBuffer::data() when copying data into SharedMemory,
requiring the SharedBuffer to combine its data segments. This can be avoided by using
SharedMemory::copyBuffer() instead.

  • Platform/SharedMemory.cpp:

(WebKit::SharedMemory::copyBuffer): Modernized to use auto and range-based for loops.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer): Used SharedMemory::copyBuffer() to create a copy of the buffer in
a new SharedMemory. Calling this function does not combine the buffer's data segments.

  • Platform/SharedMemory.h: Added a FIXME for how SharedMemory's factory functions could be

improved.

1:41 PM Changeset in webkit [266013] by Alexey Shvayka
  • 8 edits
    1 add in trunk

Function.prototype.bind should not clamp "length" to int32
​https://bugs.webkit.org/show_bug.cgi?id=215733

Reviewed by Darin Adler.

JSTests:

  • microbenchmarks/function-bind-creation.js: Added.
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch fixes to integer conversion of target function's "length" values
beyond UINT_MAX, aligning JSC with the spec [1], V8 and SpiderMonkey.

double is used instead of uint64_t to retain semantics of JS Number type [2]
and hold Infinity values. To avoid spreading double length over JSFunction::create()
and its subclasses, JSBoundFunction is modified to use JSFunction::finishCreation(VM&)
overload, removing 2 unused arguments and speeding up bound function creation by ~9%.

[1]: ​https://tc39.es/ecma262/#sec-function.prototype.bind (step 6.c.i)
[2]: ​https://tc39.es/ecma262/#sec-ecmascript-language-types-number-type

  • builtins/FunctionPrototype.js:

(bind):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

  • runtime/JSBoundFunction.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::reifyLength):

  • runtime/JSGlobalObject.cpp:

(JSC::makeBoundFunction):

12:43 PM Changeset in webkit [266012] by Lauro Moura
  • 2 edits in trunk/Tools

[GLIB] Update checked exception after r265942
​https://bugs.webkit.org/show_bug.cgi?id=215738

Reviewed by Carlos Alberto Lopez Perez.

Avoid aborting the full script on a timeout due to unchecked
exception.

  • glib/api_test_runner.py:

(TestRunner._run_google_test): Use exception from new timeout module.

12:16 PM Changeset in webkit [266011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Use closeReason provided in didCloseWithCode delegate for the NSURLSessionWebSocket code path
​https://bugs.webkit.org/show_bug.cgi?id=215519

Patch by Jiten Mehta <​jmehta@apple.com> on 2020-08-21
Reviewed by Youenn Fablet.

Covered by existing protocol tests with NSURLSession code path enabled.
http/tests/websocket/tests/hybi/workers/close-code-and-reason.html

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:webSocketTask:didCloseWithCode:reason:]):

11:28 AM Changeset in webkit [266010] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Merge two DOMURL constructors
​https://bugs.webkit.org/show_bug.cgi?id=215734

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-21
Reviewed by Darin Adler.

Merge two DOMURL constructors to make it match the relevant WebIDL:
​https://url.spec.whatwg.org/#dom-url-url-url-base-base

  • html/DOMURL.cpp:

(WebCore::DOMURL::create):

  • html/DOMURL.h:
  • html/DOMURL.idl:
10:43 AM Changeset in webkit [266009] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix USE_ANGLE=0 build after "WebGLLayer clobbers TEXTURE_2D binding on iOS"
​https://bugs.webkit.org/show_bug.cgi?id=211758

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-08-21
Reviewed by Kenneth Russell.

No new tests, build fix.

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getUniformIndices): Mark parameters unused
when USE_ANGLE=0

  • platform/graphics/cocoa/WebGLLayer.mm: Define scoped binding restorer

only for USE_ANGLE=1, since it's not used otherwise and it is implemented
in terms of ANGLE gl::... API.

  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

Include Logging.h to make RELEASE_LOG(WebGL, ...) work.
Presumably this file is not compiled with USE_ANGLE=1 or
the unified build mechanism hides the error.

9:39 AM Changeset in webkit [266008] by Russell Epstein
  • 1 copy in tags/Safari-610.1.28.1.3

Tag Safari-610.1.28.1.3.

9:36 AM Changeset in webkit [266007] by Russell Epstein
  • 9 edits in branches/safari-610.1.28.1-branch/Source

Cherry-pick r265953. rdar://problem/67560218

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNetWin.cpp: (WebCore::createPrivateStorageSession):
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::createPrivateStorageSession):

Source/WebKit:

  • WebProcess/Network/NetworkProcessConnection.h: (WebKit::NetworkProcessConnection::cookieAcceptPolicy const):
  • WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm: (WebKit::WebCookieCache::inMemoryStorageSession):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [266006] by Russell Epstein
  • 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.3

9:25 AM Changeset in webkit [266005] by Russell Epstein
  • 2 edits in branches/safari-609-branch/Source/WTF

Cherry-pick r265252. rdar://problem/67080756

about: scheme URL constants should be backed by StaticStringImpl
​https://bugs.webkit.org/show_bug.cgi?id=215113

Reviewed by Darin Adler.

  • wtf/URL.cpp: (WTF::aboutBlankURL): (WTF::aboutSrcDocURL):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:42 AM Changeset in webkit [266004] by Andres Gonzalez
  • 6 edits in trunk

Source/WebCore:
Range::contains does not work correctly when the common ancestor node is a Document.
​https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Test: accessibility/mac/selected-visible-position-range.html.

For a Range with a Document object as common ancestor, Range::contains(otherRange)
would return false for any given other range in the same document. This
causes problems in VoiceOver navigation and Braille functionality in
the MacOS Mail.app.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const):
Use SimpleRange::isNull instead of repeating its implementation.

  • dom/Range.cpp:

(WebCore::Range::contains const): Compare the Documents of the ranges'
common ancesstor nodes instead of their ownerDocuments.

LayoutTests:
Range::contains(const Range&) should compare the Documents to which the Ranges belong, not the ownerDocuments.
​https://bugs.webkit.org/show_bug.cgi?id=215714

Reviewed by Darin Adler.

Revamped the following test to check that a collapsed selection range is
set to the correct character offset in the text content. In addition,
properly used the Promise returned by waitFor in order to make the test
timing independent and work in isolated tree mode.

  • accessibility/mac/selected-visible-position-range-expected.txt:
  • accessibility/mac/selected-visible-position-range.html:
4:29 AM Changeset in webkit [266003] by aestes@apple.com
  • 48 edits
    3 copies in trunk/Source/WebKit

REGRESSION (r257667): 1.9x more CPU time in IPC::SharedBufferDataReference decoding during Netflix playback
​https://bugs.webkit.org/show_bug.cgi?id=215232
<rdar://problem/66637920>

Reviewed by Geoff Garen.

Prior to r257667, an IPC message defined a IPC::SharedBufferDataReference argument to allow
its sender to easily encode SharedBuffer data as a DataReference. SharedBufferDataReference
cost the same to encode as a DataReference -- both copied data into the Encoder -- but did
so by iterating over the SharedBuffer's data segments rather than combining them into a
contiguous allocation. The message argument was received as a decoded IPC::DataReference,
which stores a pointer into the IPC::Decoder's buffer rather than making a copy.

In r257667, IPC::SharedBufferDataReference switched its encoder to use IPC::ArgumentCoder's
SharedBuffer specialization, which works by allocating a SharedMemory buffer, copying
SharedBuffer data into it, creating a SharedMemory::IPCHandle from it, and encoding the
handle. It makes only one copy like the old encoder did, but pays the added cost of
combining SharedBuffer data segments prior to copying by needlessly calling
SharedBuffer::data() (this should be fixed independently).

Since this serialization could no longer be decoded by DataReference's decoder,
SharedBufferDataReference implemented a decoder, also in terms of ArgumentCoder's SharedBuffer
specialization. It works by mapping a SharedMemory buffer from a decoded
SharedMemory::IPCHandle and copying that buffer into a new SharedBuffer. This copy is a cost
that the old decoder did not incur, but in some cases the message receiver would have made
such a copy anyway and can instead just ref the decoded SharedBuffer. In other cases though,
the receiver either made no copies or couldn't use the decoded SharedBuffer to avoid making
its own copy so creating the SharedBuffer was pure added cost.

There are additional costs from allocating, mapping, and deleting shared memory and Mach
send rights, but they are offset by savings due to smaller Encoder and Decoder buffers. The
additional SharedBuffer combining and copying is not offset elsewhere, and on net makes
sending and receiving IPC::SharedBufferDataReferences use up to 2x more CPU time when
playing a video on netflix.com in Safari.

Resolve this slowdown by reverting the argument encoding changes made to
IPC::SharedBufferDataReference in r257667. For compatibility with code added after r257667,
the current IPC::SharedBufferDataReference was copied to IPC::SharedBufferCopy and retains
the behavior of copying into a SharedBuffer when decoded. IPC::SharedBufferDataReference now
has the pre-r257667 behavior of decoding to an IPC::DataReference. Messages added after
r257667 whose receivers were designed to handle a SharedBuffer were changed to use
IPC::SharedBufferCopy, and all other receivers of messages with IPC::SharedBufferDataReference
arguments were changed to handle an IPC::DataReference.

  • GPUProcess/media/RemoteCDMInstanceProxy.cpp:
  • GPUProcess/media/RemoteCDMInstanceProxy.h:
  • GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
  • GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
  • GPUProcess/media/RemoteCDMProxy.cpp:
  • GPUProcess/media/RemoteCDMProxy.h:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
  • GPUProcess/media/RemoteLegacyCDMSessionProxy.messages.in:
  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::platformRegisterAttachment):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPasteboardProxy.h:
  • UIProcess/WebPasteboardProxy.messages.in:
  • UIProcess/gtk/WebPasteboardProxyGtk.cpp:
  • WebProcess/GPU/media/RemoteCDMInstance.cpp:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.h:
  • WebProcess/GPU/media/RemoteCDMInstanceSession.messages.in:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.h:
  • WebProcess/GPU/media/RemoteLegacyCDMSession.messages.in:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Replaced

IPC::SharedBufferDataReference with IPC::SharedBufferCopy.

  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Removed the DidReceiveSharedBuffer

message and reverted the DidReceiveData message back to taking an
IPC::SharedBufferDataReference.

  • Platform/IPC/Encoder.h: Made Encoder::reserve(size_t) public so

SharedBufferCopy::encode(Encoder&) can call it.

  • Platform/IPC/HandleMessage.h: Restored the CodingType specialization that decodes

SharedBufferDataReference arguments as DataReferences.

  • Platform/IPC/SharedBufferCopy.cpp:
  • Platform/IPC/SharedBufferCopy.h: Copied from SharedBufferDataReference.h. Implemented the

interface and decoding behavior that SharedBufferDataReference had between r257667 and this
change.

  • Platform/IPC/SharedBufferDataReference.cpp:
  • Platform/IPC/SharedBufferDataReference.h: Reverted to the pre-r257667 interface and

decoding behvior.

  • Scripts/webkit/messages.py: Removed an unneeded special case.
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj: Added SharedBuffer{Copy,DataReference}.cpp.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::finishedLoadingIcon):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h: Used const IPC::DataReference& in message receiver

signatures for SharedBufferDataReference arguments.

  • UIProcess/WebURLSchemeTask.cpp:
  • WebProcess/GPU/media/RemoteAudioBusData.h:
  • WebProcess/GPU/media/RemoteCDM.cpp:
  • WebProcess/Network/WebLoaderStrategy.cpp: Removed unused includes.
12:51 AM BuildingCairoOnWindows edited by Fujii Hironori
(diff)

Aug 20, 2020:

11:55 PM Changeset in webkit [266002] by Peng Liu
  • 2 edits in trunk/Source/WebKit

Mac Catalyst Apps require "playsinline" attribute to support playing videos in the inline mode
​https://bugs.webkit.org/show_bug.cgi?id=215724

Reviewed by Tim Horton.

Currently WebKit::currentUserInterfaceIdiomIsPad() returns NO on Mac Catalyst apps.
Therefore, the behavior of Mac Catalyst apps regarding the inline media playback
support is not consistent with iPad apps.

This patch removes the usage of WebKit::currentUserInterfaceIdiomIsPad() to decide
the settings of the inline media playback support on Mac Catalyst apps.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

11:55 PM Changeset in webkit [266001] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations: Remove lines for removed tests.
11:46 PM Changeset in webkit [266000] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK][WPE] Debug crashes in backdrop filter tests
​https://bugs.webkit.org/show_bug.cgi?id=215209

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-20
Reviewed by Adrian Perez de Castro.

Source/WebCore:

This only happens in WKTR because RenderLayerCompositor::flushPendingLayerChanges() is called from
RenderLayerCompositor::layerTreeAsText(), so the coordinator doesn't know layers are being flushed and we don't
return early from notifyFlushRequired(). We don't really need to have a coordinator associated to the backdrop
layer, we just need to attach the layer to the coordinator to ensure it's updated.

  • platform/graphics/nicosia/NicosiaAnimation.cpp:

(Nicosia::Animation::applyInternal): Handle AnimatedPropertyWebkitBackdropFilter.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer): Detach also the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Attach the backdrop layer to the
coordinator if there's one.
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Do not call this for the
backdrop layer.
(WebCore::CoordinatedGraphicsLayer::invalidateCoordinator): Set coordinator to nullptr.
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded): Set the coordinator and attach
the layer. Also attach the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::setCoordinator): Deleted.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::~CompositingCoordinator): Use invalidateCoordinator() instead of setCoordinator()
that has been removed.
(WebKit::CompositingCoordinator::createGraphicsLayer): Use setCoordinatorIncludingSubLayersIfNeeded() instead of
attaching the layer directly.
(WebKit::CompositingCoordinator::attachLayer): Do not call setCoordinator(), the caller is expected to set the
coordinator.

LayoutTests:

Remove expectations for tests that are now passing.

  • platform/glib/TestExpectations:
11:20 PM Changeset in webkit [265999] by Diego Pino Garcia
  • 2 edits in trunk/Tools

[EWS] Add more workers to GTK-WK2-Tests-EWS queue
​https://bugs.webkit.org/show_bug.cgi?id=215408

Reviewed by Aakash Jain.

  • BuildSlaveSupport/ews-build/config.json:
9:53 PM Changeset in webkit [265998] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Mark several WebGL tests as failure after r265975.

  • platform/glib/TestExpectations:
8:50 PM Changeset in webkit [265997] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Replace IC on Proxy must write barrier Proxy's target
​https://bugs.webkit.org/show_bug.cgi?id=215720

Reviewed by Yusuke Suzuki.

The put_by_id opcode in the baseline and the DFG/FTl will emit a writeBarrier
after the operation is complete. But it does this to the base object. In the
case of an IC with the base as a Proxy, we're not actually storing to the Proxy, but
instead, the Proxy's target. This patch makes it so our IC code writeBarriers
the Proxy's target. This fixed a crash when running Speedometer2.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::canReplace const):
(JSC::AccessCase::generateImpl):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::preserveLiveRegistersToStackForCallWithoutExceptions):

  • bytecode/PolymorphicAccess.h:
7:31 PM Changeset in webkit [265996] by pvollan@apple.com
  • 6 edits
    1 add in trunk

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
​https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

  • pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::reduceMotionPreferenceKey):
(WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added.

(TEST):

7:10 PM Changeset in webkit [265995] by Hector Lopez
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 18 media tests broken
​https://bugs.webkit.org/show_bug.cgi?id=122021

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
6:39 PM Changeset in webkit [265994] by Alan Coon
  • 1 copy in tags/Safari-610.1.26.3

Tag Safari-610.1.26.3.

6:38 PM Changeset in webkit [265993] by Alan Coon
  • 3 edits
    2 adds in branches/safari-610.1.26-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
​https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

  • animations/legacy-encoding-timing-function-expected.txt: Added.
  • animations/legacy-encoding-timing-function.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:36 PM Changeset in webkit [265992] by Alan Coon
  • 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.3

6:33 PM Changeset in webkit [265991] by Chris Dumez
  • 12 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio tests.

  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
6:33 PM Changeset in webkit [265990] by Hector Lopez
  • 1 edit in trunk/LayoutTests/ChangeLog

[ macOS ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

  • platform/mac/TestExpectations:
6:33 PM Changeset in webkit [265989] by Hector Lopez
  • 2 edits in trunk/LayoutTests

fast/repaint/list-item-equal-style-change-no-repaint.html
​https://bugs.webkit.org/show_bug.cgi?id=215723

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:47 PM Changeset in webkit [265988] by Russell Epstein
  • 5 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67417186

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [265987] by Russell Epstein
  • 4 edits in branches/safari-609-branch/Source/JavaScriptCore

Cherry-pick r264643. rdar://problem/67027034

TryGetById clobberize rules are wrong.
​https://bugs.webkit.org/show_bug.cgi?id=163834
<rdar://problem/65625807>

Reviewed by Keith Miller.

Theoretically, TryGetById can do the same things GetById does i.e. reify lazy
properties, read the stack, etc. Hence, its clobberize rule should be clobberTop
just like GetById. However, in practice, we don't currently use @tryGetById to
access anything on the stack (and probably never will). But as a conservative
measure, we'll just treat TryGetById like it can. In clobberize terms, this
means we declare TryGetById as doing read(World) (just like GetById) instead of
read(Heap).

  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGClobbersExitState.cpp: (JSC::DFG::clobbersExitState):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@264643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:19 PM Changeset in webkit [265986] by Karl Rackler
  • 25 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c

Unreviewed test gardening. Revert unnecessary baseline.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
5:12 PM Changeset in webkit [265985] by Wenson Hsieh
  • 3 edits
    2 adds in trunk

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
​https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

  • animations/animation-followed-by-two-transitions-expected.txt: Added.
  • animations/animation-followed-by-two-transitions.html: Added.
4:53 PM Changeset in webkit [265984] by Russell Epstein
  • 8 edits in branches/safari-609-branch/Source

Versioning.

WebKit-7609.4.1

4:48 PM Changeset in webkit [265983] by Jonathan Bedard
  • 4 edits in trunk/Tools

[webkitcorepy] Fix pip package
​https://bugs.webkit.org/show_bug.cgi?id=215717
<rdar://problem/67512294>

Reviewed by Dewei Zhu.

  • Scripts/libraries/webkitcorepy/MANIFEST.in: Add cacert.pem.
  • Scripts/libraries/webkitcorepy/setup.py: Include submodules.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Version bump.
4:34 PM Changeset in webkit [265982] by Karl Rackler
  • 3 edits in branches/safari-610.1.28.1-branch/LayoutTests

rdar://67367072 REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
4:15 PM Changeset in webkit [265981] by Chris Dumez
  • 4 edits in trunk

AudioBufferSourceNode should use "final" values for playbackRate and detune
​https://bugs.webkit.org/show_bug.cgi?id=215669

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:

Source/WebCore:

AudioBufferSourceNode should use "final" values for playbackRate and detune to take into
account changes to the AudioParamTimeline (for example, when
AudioBufferSourceNode.playbackRate.setValueAtTime() is called).

No new tests, rebaselined existing test.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

4:14 PM Changeset in webkit [265980] by Chris Dumez
  • 36 edits in trunk

AudioParam.automationRate attribute is missing
​https://bugs.webkit.org/show_bug.cgi?id=215710

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:

Source/WebCore:

Add initial support for AudioParam.automationRate:

No new tests, rebaselined existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::setAutomationRate):
(WebCore::AudioParam::calculateSampleAccurateValues):

  • Modules/webaudio/AudioParam.h:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):
(WebCore::ConstantSourceNode::process):

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::process):

  • Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):
(WebCore::GainNode::process):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::distanceConeGain):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::process):

  • Modules/webaudio/WebKitAudioBufferSourceNode.h:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::distanceConeGain):

  • Modules/webaudio/WebKitAudioPannerNode.h:
  • Modules/webaudio/WebKitDynamicsCompressorNode.h:
4:12 PM Changeset in webkit [265979] by Karl Rackler
  • 3 edits in branches/safari-610.1.28.0-branch/LayoutTests

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Catalina / iOS ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Adding test expectations for[ Catalina / iOS ]

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
4:11 PM Changeset in webkit [265978] by Karl Rackler
  • 24 edits in branches/safari-610.1.28.0-branch/LayoutTests/imported/w3c/web-platform-tests/webaudio

rdar://67367072 ([ safari-610.1-branch ] REGRESSION (r265805): [ Jazz/Azul wk2 ] 24 w3c/web-platform-tests/webaudio/ tests are a constant failure)
Rebaseline failing test since required webaudio changes are not intended to be cherry-picked to the branch.

Unreviewed test gardening.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/cycle-without-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/processing-model/feedback-delay-time-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-channels-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/ctor-audiobuffersource-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-setBuffer-already-has-value-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiosourcenode-interface/mediastreamaudiosourcenode-ctor-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
3:55 PM Changeset in webkit [265977] by James Savage
  • 3 edits in trunk/Source/WebKit

Could not find module 'WebKit' for target 'armv7-apple-ios'
<​https://bugs.webkit.org/show_bug.cgi?id=215190>
<rdar://problem/65642049>

Reviewed by Brady Eidson.

The config changes here got added to the wrong config file. They need to
be for the overlay, not its tests.

  • SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig:
  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig:
3:51 PM Changeset in webkit [265976] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.3.2

Tag Safari-610.1.28.3.2.

3:41 PM Changeset in webkit [265975] by commit-queue@webkit.org
  • 16 edits in trunk

[WebGL2] Pass context-lost-restored.html test
​https://bugs.webkit.org/show_bug.cgi?id=215599

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-08-20
Reviewed by Dean Jackson.

Source/WebCore:

Support losing extensions, and restoring them via
WEBGL_lose_context.

Necessarily changed WebGLExtensions to be RefCounted rather than
managed via unique_ptr. Multiple instances of the same
WebGLExtension subclass can now be vended from a WebGL rendering
context, and WebGLExtensions can now outlive their rendering
context - they do not ref their context.

Extensions now hold a weak pointer to their
WebGLRenderingContextBase rather than a C++ reference. When an
extension's parent context is lost, that pointer is nulled out.
Extensions are forcibly lost upon WebGL context destruction.

WebGL extensions' IDLs still use
GenerateIsReachable=ImplWebGLRenderingContext, so that if the
context is still alive, the JavaScript wrappers for the extension
objects will be preserved. (If the extension is lost, the bindings
will fetch nullptr for the context, which won't be in the opaque
root set, so the JavaScript wrapper won't be artificially kept
alive.)

Covered by existing WebGL conformance tests.

  • html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::drawArraysInstancedANGLE):
(WebCore::ANGLEInstancedArrays::drawElementsInstancedANGLE):
(WebCore::ANGLEInstancedArrays::vertexAttribDivisorANGLE):

  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::createVertexArrayOES):
(WebCore::OESVertexArrayObject::deleteVertexArrayOES):
(WebCore::OESVertexArrayObject::isVertexArrayOES):
(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):

  • html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

  • html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::drawBuffersWEBGL):

  • html/canvas/WebGLExtension.cpp:

(WebCore::WebGLExtension::WebGLExtension):
(WebCore::WebGLExtension::loseParentContext):

  • html/canvas/WebGLExtension.h:

(WebCore::WebGLExtension::context):
(WebCore::WebGLExtension::isLost):
(WebCore::WebGLExtension::ref): Deleted.
(WebCore::WebGLExtension::deref): Deleted.

  • html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::loseContext):
(WebCore::WebGLLoseContext::restoreContext):
(WebCore::WebGLLoseContext::loseParentContext):

  • html/canvas/WebGLLoseContext.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::~WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::loseExtensions):

  • html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

Rebaselined WebGL conformance tests which are now fully passing.

  • webgl/1.0.3/conformance/context/context-lost-restored-expected.txt:
  • webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
3:38 PM Changeset in webkit [265974] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.1.2

Tag Safari-610.1.28.1.2.

3:37 PM Changeset in webkit [265973] by Alan Coon
  • 1 copy in tags/Safari-610.1.28.0.2

Tag Safari-610.1.28.0.2.

3:34 PM Changeset in webkit [265972] by Alan Coon
  • 1 copy in tags/Safari-610.1.26.2

Tag Safari-610.1.26.2.

3:32 PM Changeset in webkit [265971] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[ews] Handle bugs with unicode characters in title in ews emails
​https://bugs.webkit.org/show_bug.cgi?id=215627

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ensure email_subject is unicode.
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Ditto.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:09 PM Changeset in webkit [265970] by Alan Coon
  • 2 edits in branches/safari-610.1.26-branch/Source/WebKit

Cherry-pick r265930. rdar://problem/67364266

Fix null pointer crashes in network process after r265835

​​https://bugs.webkit.org/show_bug.cgi?id=215626

<rdar://problem/67268892>

Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:09 PM Changeset in webkit [265969] by Alan Coon
  • 4 edits in branches/safari-610.1.26-branch

Cherry-pick r265835. rdar://problem/67364266

WKWebViews using fastServerTrustEvaluationEnabled should only allow legacy TLS for main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=215626
<rdar://problem/67268892>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-18
Reviewed by Darin Adler.

Source/WebKit:

We have introduced public API webView:authenticationChallenge:shouldAllowDeprecatedTLS: in WKNavigationDelegate to allow
applications to choose whether to allow TLS 1.0 or 1.1 connections. We don't want to break this API or break existing third party
apps that load pages that load third party subresources that use TLS 1.0 or 1.1.

However, we do want Safari, which uses fastServerTrustEvaluationEnabled SPI, to silently fail subresource loads that use TLS 1.0 or 1.1.
This matches the current behavior of Chrome and Firefox, which was not implemented in those other browsers when we decided to ask about subresources.

Covered by an API test.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:57 PM Changeset in webkit [265968] by Alan Coon
  • 8 edits in branches/safari-610.1.26-branch/Source

Versioning.

WebKit-7610.1.26.2

2:39 PM Changeset in webkit [265967] by Lauro Moura
  • 41 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

[GTK][WPE] Rebaseline websocket tests after r265592

Unreviewed test gardening.

  • platform/glib/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Renamed from LayoutTests/platform/wpe/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt.
  • platform/glib/http/tests/websocket/tests/hybi/broken-utf8-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-before-open-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/close-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/closed-port-delay-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/error-event-ready-state-non-existent-url-with-server-responding-404-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/fragmented-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-error-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-invalid-http-version-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-mismatch-protocol-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-accept-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-extensions-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-header-value-sec-websocket-protocol-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-non-ascii-status-line-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/handshake-ok-with-http-version-beyond-1_1-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-invalid-parameter-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/interleaved-fragments-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/invalid-encode-length-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/invalid-masked-frames-from-server-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/long-control-frame-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/long-invalid-header-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Added.
  • platform/glib/http/tests/websocket/tests/hybi/reserved-bits-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/reserved-opcodes-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/too-long-payload-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/websocket-event-target-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt:
  • platform/gtk/http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt:
  • platform/gtk/http/tests/websocket/connection-refusal-in-frame-resource-load-statistics-expected.txt: Removed.
2:37 PM Changeset in webkit [265966] by Alexey Shvayka
  • 4 edits in trunk

Invalid early errors for class methods named "constructor" and "prototype"
​https://bugs.webkit.org/show_bug.cgi?id=215413

Reviewed by Darin Adler.

JSTests:

  • test262/expectations.yaml: Mark 24 test cases as passing.

Source/JavaScriptCore:

This change removes invalid early syntax errors, allowing static async/generator
methods named "constructor" and instance async/generator methods named "prototype",
which aligns JSC with the spec [1], V8, and SpiderMonkey.

Also, removes a FIXME related to super() calls outside constructor that was
resolved in r181404 and is covered by test262 suite.

[1]: ​https://tc39.es/ecma262/#sec-class-definitions-static-semantics-early-errors

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

2:25 PM Changeset in webkit [265965] by Alexey Shvayka
  • 6 edits in trunk/Source/JavaScriptCore

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

This patch:

  1. Refactors jsTypeofIsObject(), leveraging fast path of isCallable(), moves it to the header, and utilizes it in DFG AI and operationTypeOfIsObject() to eliminate code duplication.
  1. Splits jsTypeofIsFunction() into 2 methods to accomodate operationTypeOfIsFunction() calling it with JSObject* argument.
  1. Removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGOperations.cpp:
  • runtime/CommonSlowPaths.h:
  • runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

  • runtime/Operations.h:

(JSC::jsTypeofIsObject):
(JSC::jsTypeofIsFunction):

2:08 PM Changeset in webkit [265964] by Aditya Keerthi
  • 5 edits in trunk/Source

Add runtime setting for editable components in date/time inputs
​https://bugs.webkit.org/show_bug.cgi?id=215705

Reviewed by Wenson Hsieh.

Source/WebCore:

This setting controls the ability to edit individual components of date
and time input types. For example, <input type=date> will have three
editable components - year, month, and day.

  • page/Settings.yaml:

Source/WebKit:

Added DateTimeInputsEditableComponentsEnabled as a runtime setting. This
setting is enabled by default on macOS.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
2:02 PM Changeset in webkit [265963] by commit-queue@webkit.org
  • 4 edits in trunk

XMLHttpRequest.open should use USVString
​https://bugs.webkit.org/show_bug.cgi?id=215704

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-20
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

  • web-platform-tests/xhr/open-url-encoding-expected.txt:

Source/WebCore:

XMLHttpRequest.open should use USVString as mentioned in the FIXMEs and the spec [1].

Test: imported/w3c/web-platform-tests/xhr/open-url-encoding.html

[1] ​https://xhr.spec.whatwg.org/#ref-for-dom-xmlhttprequest-open

  • xml/XMLHttpRequest.idl:
1:44 PM Changeset in webkit [265962] by Chris Dumez
  • 25 edits
    7 adds in trunk

Introduce StereoPannerNode Interface
​https://bugs.webkit.org/show_bug.cgi?id=215518

Patch by Clark Wang <​clark_wang@apple.com> on 2020-08-20
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-baselined existing tests. Some now fail due to missing automation rate.

  • web-platform-tests/webaudio/idlharness.https.window-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/automation-rate-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-basic-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/stereopannernode-panning-expected.txt:

Source/WebCore:

Added StereoPannerNode according to spec: ​https://www.w3.org/TR/webaudio/#stereopannernode.
Used Chromium implementation for guidance: ​https://source.chromium.org/chromium/chromium/src/
+/master:third_party/blink/renderer/modules/webaudio/stereo_panner_node.cc.
Added in StereoPannerOptions and StereoPanner files as well. The latter used Chromium
implementation for guidance: ​https://source.chromium.org/chromium/chromium/src/+
/master:third_party/blink/renderer/platform/audio/stereo_panner.cc

Re-baselined existing tests. Some now fail due to missing automation rate.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createStereoPanner):

  • Modules/webaudio/BaseAudioContext.h:
  • Modules/webaudio/BaseAudioContext.idl:
  • Modules/webaudio/StereoPannerNode.cpp: Added.

(WebCore::StereoPannerNode::create):
(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::~StereoPannerNode):
(WebCore::StereoPannerNode::process):
(WebCore::StereoPannerNode::initialize):
(WebCore::StereoPannerNode::uninitialize):
(WebCore::StereoPannerNode::listener):
(WebCore::StereoPannerNode::setChannelCount):
(WebCore::StereoPannerNode::setChannelCountMode):

  • Modules/webaudio/StereoPannerNode.h: Added.
  • Modules/webaudio/StereoPannerNode.idl: Added.
  • Modules/webaudio/StereoPannerOptions.h: Added.
  • Modules/webaudio/StereoPannerOptions.idl: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • platform/audio/StereoPanner.cpp: Added.

(WebCore::StereoPanner::create):
(WebCore::StereoPanner::StereoPanner):
(WebCore::StereoPanner::panWithSampleAccurateValues):
(WebCore::StereoPanner::panToTargetValue):

  • platform/audio/StereoPanner.h: Added.

(WebCore::StereoPanner::~StereoPanner):

  • platform/graphics/cocoa/SourceBufferParserWebM.cpp:
1:37 PM Changeset in webkit [265961] by Alexey Shvayka
  • 11 edits
    1 move
    271 adds
    15 deletes in trunk/JSTests

Update test262 to commit e0a65ee75ef8
​https://bugs.webkit.org/show_bug.cgi?id=215708

Reviewed by Yusuke Suzuki.

  • test262/expectations.yaml:
  • test262/harness/*: Updated.
  • test262/latest-changes-summary.txt:
  • test262/test/*: Updated.
  • test262/test262-Revision.txt:
1:37 PM Changeset in webkit [265960] by Diego Pino Garcia
  • 2 edits in trunk/Tools

[ews] Add 'jsc-mips-tests' bubble
​https://bugs.webkit.org/show_bug.cgi?id=215697

This new bubble runs jscore-tests for JSC MIPS 32-bit. The former
'jsc-mips' bubble now reports about successful binary builds for the
same architecture.

Reviewed by Aakash Jain.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

1:06 PM Changeset in webkit [265959] by svillar@igalia.com
  • 5 edits in trunk/Source/WebCore

Unreviewed, reverting r265850.

Tests crash on debug builds

Reverted changeset:

"[WebXR] Make "in parallel" code run really in parallel"
​https://bugs.webkit.org/show_bug.cgi?id=215642
​https://trac.webkit.org/changeset/265850

12:57 PM Changeset in webkit [265958] by Diego Pino Garcia
  • 5 edits in trunk/Tools

[ews] Split JSC MIPS queue into separate builder and tester queue
​https://bugs.webkit.org/show_bug.cgi?id=212009

Reviewed by Aakash Jain.

Currently there are two EWS JSC MIPS configured, one that runs as
buildAndTest and another one that runs as buildOnly.

This patch changes the buildAndTest bot to test, and makes the
bot fetch the binary product produced by the buildOnly bot.

  • BuildSlaveSupport/ews-build/config.json:
  • BuildSlaveSupport/ews-build/factories.py:

(JSCTestsFactory):
(JSCTestsFactory.init):

  • BuildSlaveSupport/ews-build/factories_unittest.py:

(TestLayoutTestsFactory.test_gtk_factory):
(TestJSCBuildFactory):
(TestJSCBuildFactory.test_jsc_mipsel_factory):
(TestJSCBuildFactory.test_jsc_armv7_factory):
(TestJSCBuildAndTestsFactory):
(TestJSCBuildAndTestsFactory.test_jsc_mipsel_factory):
(TestJSCBuildAndTestsFactory.test_jsc_armv7_factory):
(TestJSCTestsFactory):
(TestJSCTestsFactory.test_jsc_mipsel_factory):
(TestJSCTestsFactory.test_jsc_armv7_factory):

  • BuildSlaveSupport/ews-build/loadConfig.py:
12:32 PM Changeset in webkit [265957] by Jonathan Bedard
  • 3 edits
    2 adds in trunk/Tools

[webkitcorepy] Add subprocess_utils.run
​https://bugs.webkit.org/show_bug.cgi?id=215702
<rdar://problem/67487751>

Reviewed by Dewei Zhu.

Python 3's subprocess.run API is much better than the multiple subprocess APIs that Python 2 provides. Rather than
requiring new scripts and libraries to be fully Python 3, we should provide a Python 2 API identical to subprocess.run.

  • Scripts/libraries/webkitcorepy/README.md: Document usage of subprocess_utils.run.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Export subprocess_utils, bump minor version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/subprocess_utils.py: Added.

(run): Declare Python 2 version of Python 3's subprocess.run API.
(TimeoutExpired): Ditto.
(CompletedProcess): Ditto.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/subprocess_utils_unittest.py: Added.

(SubprocessUtils):
(SubprocessUtils.test_run):
(SubprocessUtils.test_run_exit):
(SubprocessUtils.test_run_timeout):
(SubprocessUtils.test_run_timeout_context):

11:48 AM Changeset in webkit [265956] by Alan Coon
  • 8 edits in branches/safari-610.2.2-branch/Source

Revert "Versioning."

11:47 AM Changeset in webkit [265955] by Alan Coon
  • 1 copy in tags/Safari-610.2.2

Tag Safari-610.2.2.

11:37 AM Changeset in webkit [265954] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ iOS Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-createHTMLDocument-parse-error-external-classic.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215706

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:53 AM Changeset in webkit [265953] by Chris Dumez
  • 9 edits in trunk/Source

Sandbox violation when calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=215701
<rdar://problem/67069826>

Reviewed by Geoffrey Garen.

The sandbox does not allow calling [NSHTTPCookieStorage sharedHTTPCookieStorage] from the WebProcess.
createPrivateStorageSession() was calling [NSHTTPCookieStorage sharedHTTPCookieStorage] to retrieve
the cookieAcceptPolicy and createPrivateStorageSession() is used by the cookie cache in the WebProcess.
To address the issue, we now allow the caller of createPrivateStorageSession() to provide the
cookieAcceptPolicy and we have the cookie cache retrieve the cookieAcceptPolicy from the
NetworkProcessConnection.

Source/WebCore:

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNetWin.cpp:

(WebCore::createPrivateStorageSession):

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::createPrivateStorageSession):

Source/WebKit:

  • WebProcess/Network/NetworkProcessConnection.h:

(WebKit::NetworkProcessConnection::cookieAcceptPolicy const):

  • WebProcess/WebPage/Cocoa/WebCookieCacheCocoa.mm:

(WebKit::WebCookieCache::inMemoryStorageSession):

10:30 AM Changeset in webkit [265952] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

Align console log message of new WebSocket code path with the legacy code path
​https://bugs.webkit.org/show_bug.cgi?id=215695

Reviewed by Alex Christensen.

No observable change of behavior from the page.
Console log messages appear in expected.txt files when NSURLSession code path is enabled.

  • WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::connect):
(WebKit::WebSocketChannel::didReceiveMessageError):

  • WebProcess/Network/WebSocketChannel.h:
9:49 AM Changeset in webkit [265951] by youenn@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add a WebSocket test checking close with 1000
​https://bugs.webkit.org/show_bug.cgi?id=215694

Reviewed by Alex Christensen.

http/tests/websocket/tests/hybi/client-close.html is not running consistently between Firefox, Chrome, WebKit legacy WebSocket and WebKit NSURLSession WebSocket.
Add another test that uses an explicit close code that runs consistently between Firefox, Chrome and WebKit legacy WebSocket.

  • http/tests/websocket/tests/hybi/client-close-2-expected.txt: Added.
  • http/tests/websocket/tests/hybi/client-close-2.html: Added.
  • http/tests/websocket/tests/hybi/client-close-2_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

9:44 AM Changeset in webkit [265950] by Alan Coon
  • 3 edits
    2 adds in branches/safari-610.1.28.0-branch

Cherry-pick r265932. rdar://problem/67485356

Fix possible crash when webAnimationsCSSIntegrationEnabled is false
​https://bugs.webkit.org/show_bug.cgi?id=215668
<rdar://problem/67402003>

Reviewed by Dean Jackson.

Source/WebKit:

When webAnimationsCSSIntegrationEnabled is false, GraphicsLayerCA::setupAnimation() doesn't
set a timing function on the animation, causing a null de-ref when the animation is being encoded.
Fix the encoder to handle null timing functions.

Test: animations/legacy-encoding-timing-function.html

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::Properties::encode const): (WebKit::PlatformCAAnimationRemote::Properties::decode):

LayoutTests:

  • animations/legacy-encoding-timing-function-expected.txt: Added.
  • animations/legacy-encoding-timing-function.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:44 AM Changeset in webkit [265949] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Test failing on Rosetta as well as AS - adding test expectation for Rosetta
​https://bugs.webkit.org/show_bug.cgi?id=207150

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
9:35 AM Changeset in webkit [265948] by Alan Coon
  • 5 edits in branches/safari-610.1.28.3-branch/Source/JavaScriptCore

Cherry-pick r265891. rdar://problem/67439277

B3 IntRange is incorrect for negative masks
​https://bugs.webkit.org/show_bug.cgi?id=215536
<rdar://problem/67130430>

Reviewed by Michael Saboff and Robin Morisset.

In the B3 ReduceStrength phase, we compute rangeForMask as (0, mask). This is correct for
positive values, but incorrect when negative. To fix it, we use (INT_MIN & mask, INT_MAX & mask)
as the range for negative masks.

  • b3/B3ReduceStrength.cpp:
  • b3/testb3.h:
  • b3/testb3_1.cpp: (run):
  • b3/testb3_5.cpp: (testCheckSubBitAnd):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:34 AM Changeset in webkit [265947] by Alan Coon
  • 8 edits in branches/safari-610.1.28.3-branch/Source

Versioning.

WebKit-7610.1.28.3.2

9:32 AM Changeset in webkit [265946] by Alan Coon
  • 5 edits in branches/safari-610.1.28.2-branch/Source/JavaScriptCore

Revert r265929. rdar://problem/67439277

9:28 AM Changeset in webkit [265945] by Karl Rackler
  • 2 edits in trunk/LayoutTests

Four separate reported tests failures: rdar://6453565 rdar://65848157 rdar://66660924 rdar://6684253
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
9:22 AM Changeset in webkit [265944] by Hector Lopez
  • 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] fast/scrolling/mac/scrollbars/overlay-scrollbar-hovered.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215700

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:12 AM Changeset in webkit [265943] by Karl Rackler
  • 2 edits in trunk/LayoutTests

rdar://66661355 ([ASi Layout Tests] 3 compositing tests failing with 0.01% diffs)
Tests failing on Rosetta as well as AS - adding test expectations for Rosetta

Unreviewed test gardening.

  • platform/mac/TestExpectationsRosetta:
7:33 AM Changeset in webkit [265942] by Jonathan Bedard
  • 5 edits
    2 adds
    1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Darin Adler and Dewei Zhu.

The Timeout class is a generally useful Python utility, it should not live inside webkitpy.

  • Scripts/libraries/webkitcorepy/README.md: Document Timeout object.
  • Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Expose Timeout object API, increment version.
  • Scripts/libraries/webkitcorepy/webkitcorepy/mocks/time_.py:

(_MetaTime.enter): Replace timeout.py's ORIGINAL_SLEEP variable to speed up testing.

  • Scripts/libraries/webkitcorepy/webkitcorepy/tests/timeout_unittest.py: Added.

(TimeoutTests): Added.

  • Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py: Added.

(Timeout): Class representing a stackable Timeout context.
(Timeout.Data): Class containing information about a specific deadline.
(Timeout.Exception): Exception belonging to the Timeout object.
(Timeout.DisableAlarm): For some block of code, disable Timeout alarms. This is useful because many APIs (such as
subprocess.run) define their own timeouts which do better cleanup than an interrupt would.
(Timeout.default_handler): Default Timeout handler which raises an exception.
(Timeout.current): Return the current Timeout.Data class, if one exists.
(Timeout.deadline): Return the closest deadline, if one exists.
(Timeout.difference): Return the number of seconds between the current time and the closest deadline.
(Timeout.check): Check if we have surpassed the closest deadline., raise an exception if we have.
(Timeout.bind): Create a signal based on the closest deadline.
(Timeout.sleep): Override the sleep function because if we ever request a sleep that is greater than the closest deadline,
we should imiediately trigger the timeout logic without waiting for the timeout to actually expire.
(Timeout.init): Create a Timeout context, 1 second by default.
(Timeout.enter):
(Timeout.exit):

  • Scripts/webkitpy/common/timeout_context.py:

(Timeout): Moved to webkitcorepy.

6:53 AM Changeset in webkit [265941] by Diego Pino Garcia
  • 1 edit
    1 move in trunk/LayoutTests

[GTK] Unreviewed test gardening. Move WPE baseline for collection-iterators.html test to GLIB.

  • platform/glib/fast/dom/collection-iterators-expected.txt: Renamed from LayoutTests/platform/wpe/fast/dom/collection-iterators-expected.txt.
6:06 AM Changeset in webkit [265940] by Lauro Moura
  • 6 edits in trunk

REGRESSION(r265856) [GTK][WPE] hybi websockets tests failing
​https://bugs.webkit.org/show_bug.cgi?id=215679

Reviewed by Carlos Garcia Campos.

Source/WebKit:

r265856 changed WebSocketChannel to expect AbnormalClosure when the
closing handshake is not received.

Covered by existing tests.

  • NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::didFail):

LayoutTests:

Rebaseline and update expectations.

  • platform/glib/TestExpectations:
  • platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
3:43 AM Changeset in webkit [265939] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

WebSocketTask::close should correctly compute reason byte size in UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=215645

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/close.html with NSURLSession code path enabled.

  • NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::close):
Instead of calling sizeInBytes, we should just get the utf8 CString and gets its size directly.

12:15 AM Changeset in webkit [265938] by Diego Pino Garcia
  • 12 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines after r265851.

  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
Note: See TracTimeline for information about the timeline view.