Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 26, 2020:

11:46 PM Changeset in webkit [266225] by BJ Burg

• 4 edits in trunk/Source

Web Inspector: button for Inspector^{2 doesn't work without setting default for DeveloperExtrasEnabled
​https://bugs.webkit.org/show_bug.cgi?id=215828}

Reviewed by Devin Rousso.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::inspectInspector):
Explicitly set DeveloperExtrasEnabled for the Inspector
web view so that the Inspect context menu appears and
so the [2] button works as expected.

Source/WebInspectorUI:

Drive-by: because the Inspector^{2 button is text-only and has no
.name element, the '2' button does not become dimmed when the
window is inactive, unlike every other item in the tab bar.
Fix this by coloring the text-only button similar to tab labels.}

• UserInterface/Debug/Bootstrap.css:

(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover):
(.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected):
(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected >):

10:43 PM Changeset in webkit [266224] by Jonathan Bedard

• 7 edits
  1 delete in trunk/Tools

[webkitcorepy] Move Timeout to webkitcorepy (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=215584
<rdar://problem/67270713>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:

(Timeout.enter): Forward patch flag to disable context.
(Timeout.exit): Ditto.

• Scripts/webkitpy/common/timeout_context.py: Replace with webkitcorepy's Timeout object.

(Timeout): Deleted.

• Scripts/webkitpy/common/timeout_context_unittest.py: Removed.
• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Opt-out of patching time.sleep().

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.launch_app): Opt-out of patching time.sleep().

• glib/api_test_runner.py:

(TestRunner._run_google_test): Use specific Timeout exception.

10:27 PM Changeset in webkit [266223] by Alexey Shvayka

• 8 edits in trunk/Source

Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
​https://bugs.webkit.org/show_bug.cgi?id=144457

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch refactors jsTypeofIsObject(), leveraging fast path of isCallable(),
moves it to the header, and utilizes it in operationTypeOfIsObject() & DFG AI
(minding concurrency) to eliminate code duplication.

Also, removes orphaned slow_path_is_object declaration.

No behavior change, typeof microbenchmarks are neutral.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGOperations.cpp:
• runtime/CommonSlowPaths.h:
• runtime/Operations.cpp:

(JSC::jsTypeofIsObject): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsObjectWithConcurrency):
(JSC::jsTypeofIsObject):

Source/WTF:

• wtf/TriState.h:

(WTF::invert):

9:36 PM Changeset in webkit [266222] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder should not align the runs
​https://bugs.webkit.org/show_bug.cgi?id=215016

Reviewed by Antti Koivisto.

This is in preparation for moving alignment logic over to the LineBox.
LineBuilder is responsible for adding content to the line, but the final alignment will be done by the LineBox.
This works well with preferred width computation, where we use the LineBuilder to compute line width but we
don't really need to construct a LineBox (and no alignment is needed).

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::removeTrailingTrimmableContent):
(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::LineContentAligner::formattingContext const): Deleted.
(WebCore::Layout::LineContentAligner::layoutState const): Deleted.
(WebCore::Layout::LineContentAligner::LineContentAligner): Deleted.
(WebCore::Layout::LineContentAligner::alignHorizontally): Deleted.
(WebCore::Layout::LineContentAligner::alignVertically): Deleted.
(WebCore::Layout::LineContentAligner::justifyRuns): Deleted.
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineContentAligner::collectHangingContent const): Deleted.
(WebCore::Layout::LineContentAligner::runContentHeight const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox):
(WebCore::Layout::LineBuilder::runs):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::close):

• layout/inlineformatting/LineLayoutContext.h:

9:28 PM Changeset in webkit [266221] by Chris Dumez

• 19 edits in trunk

Add support for sub-sample accurate start for AudioBufferSourceNode
​https://bugs.webkit.org/show_bug.cgi?id=215868

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:

Source/WebCore:

Implement sub-sample accurate start for AudioBufferSourceNode.
Previously, if the start time was between sample boundaries, we would
start the output at the frame before the start time. This is actually
incorrect because we haven't actually started yet. We should start
the output at the next boundary, and interpolating the value based on
the true start time and the sample boundary.

This is based on the following Chromium changes:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/1212270
• ​https://chromium-review.googlesource.com/c/chromium/src/+/1446869

No new tests, rebaselined existing test.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::process):

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::process):

• platform/audio/AudioUtilities.cpp:

(WebCore::AudioUtilities::timeToSampleFrame):

• platform/audio/AudioUtilities.h:

LayoutTests:

Update existing layout tests to reflect behavior change.

• platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav:
• webaudio/gain-expected.wav:
• webaudio/resources/distance-model-testing.js:
• webaudio/resources/panner-model-testing.js:

8:57 PM Changeset in webkit [266220] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Gardening some accessibility debug crashes

Unreviewed test gardening.

• platform/glib/TestExpectations:

8:43 PM Changeset in webkit [266219] by Chris Dumez

• 4 edits in trunk

Update DynamicsCompressorNode::process() to use AudioParam::finalValue()
​https://bugs.webkit.org/show_bug.cgi?id=215874

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-dynamics-compressor-connections-expected.txt:

Source/WebCore:

Update DynamicsCompressorNode::process() to use AudioParam::finalValue(). All of DynamicsCompressorNode
use k-rate (in fixed mode) so we should be using AudioParam::finalValue() unconditionally.

No new tests, rebaselined existing test.

• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::process):

8:35 PM Changeset in webkit [266218] by Devin Rousso

• 3 edits in trunk/Source/WebCore

REGRESSION: touchbar controls don't reflect video state in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager setPlaying:]):
(-[WebPlaybackControlsManager isPlaying]):
Create an actual ivar _playing for holding the play/pause state. This is needed because
AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the
related video controller (in this case AVTouchBarPlaybackControlsControlling) changes
using an NSValueBinding. KVO needs an actual ivar in order to function properly.

8:21 PM Changeset in webkit [266217] by Ryan Haddad

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, reverting r266200.

Broke test for macOS

Reverted changeset:

"Unreviewed, rebaseline constant css-cascade test failure"
​https://trac.webkit.org/changeset/266200

6:58 PM Changeset in webkit [266216] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

[macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification
​https://bugs.webkit.org/show_bug.cgi?id=215869

Reviewed by Darin Adler.

On macOS, stop logging mach-lookup sandbox violations of com.apple.CoreDisplay.Notification for performance reasons.

No new tests, since there is no change in behavior. The service was already being denied in the sandbox.

• WebProcess/com.apple.WebProcess.sb.in:

6:55 PM Changeset in webkit [266215] by Alexey Shvayka

• 3 edits
  2 adds in trunk

Merge putLength() into setLength()
​https://bugs.webkit.org/show_bug.cgi?id=211279

Reviewed by Darin Adler and Saam Barati.

JSTests:

• microbenchmarks/array-shift-unshift-empty.js: Added.
• stress/array-setLength-on-proxy-error.js: Added.

Source/JavaScriptCore:

This patch:

1. Replaces all putLength() call sites with setLength(), saving two JSValue instantiations in arrayProtoFuncPop() and two in arrayProtoFuncShift().

2. Merges putLength() into setLength(), removing superfluous put() call for JSArray. Also, performs put() in strict mode to preserve the original error messages, like ones in ProxyObject::performPut().

3. Inlines performPop(), which avoided an extra index check and Identifier creation, as it was on the slow path anyway (note JSArray::pop() call).

This change advances provided setLength()-heavy microbenchmark by ~40%,
while existing Array tests are neutral.

• runtime/ArrayPrototype.cpp:

(JSC::setLength):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncUnShift):
(JSC::putLength): Deleted.

6:52 PM Changeset in webkit [266214] by Kate Cheney

• 19 edits in trunk/Source

Resource Load Statistics data summary does not report data which is held up in the web content process.
​https://bugs.webkit.org/show_bug.cgi?id=215822
<rdar://problem/66682044>

Reviewed by Chris Dumez.

Source/WebCore:

Send empty lambda when calling updateCentralStatisticsStore() because
in these cases we don't care about timing.

• loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::updateCentralStatisticsStore):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::close):

• testing/Internals.cpp:

(WebCore::Internals::notifyResourceLoadObserver):

Source/WebKit:

No new tests, this fixes a timing bug that is flaky to reproduce, so I
was unable to write a test case. Non-regressed behavior is confirmed
with existing API testing.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
Most of the time, the completion handler will be an empty function,
but we should handle it in the network process so we fix the
case where we wait to send the full data summary until the update has
finished.

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):
Delete extra space.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
Don't ask the network process for data until any lingering data
in the web content process has been sent first.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleResourceLoadStatisticsNotifyObserver):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::~WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):

• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::flushResourceLoadStatistics):
(WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

6:47 PM Changeset in webkit [266213] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make isIndex use MAX_ARRAY_INDEX
​https://bugs.webkit.org/show_bug.cgi?id=215872

Reviewed by Darin Adler.

It's already written in such a way where it relies on what MAX_ARRAY_INDEX
is defined as. But instead of MAX_ARRAY_INDEX, the function was hardcoding
MAX_ARRAY_INDEX + 1.

• runtime/Identifier.h:

(JSC::isIndex):

6:26 PM Changeset in webkit [266212] by rniwa@webkit.org

• 12 edits in trunk/Source/WebCore

Make it possible to create a WeakPtr to Node and use it store assigned nodes in SlotAssignment
​https://bugs.webkit.org/show_bug.cgi?id=215673
<rdar://problem/67440818>

Reviewed by Darin Adler.

This patch makes Node inherit from CanMakeWeakPtr<Node> and uses it in SlotAssignment's assignedNodes
and related member variables and functions.

No new tests since there should be no behavioral difference.

• dom/ComposedTreeIterator.cpp:

(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::advanceInSlot):

• dom/ComposedTreeIterator.h:

(WebCore::firstChildInComposedTreeIgnoringUserAgentShadow):
(WebCore::nextSiblingInComposedTreeIgnoringUserAgentShadow):

• dom/ContainerNode.h:
• dom/Node.h:
• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::assignedNodesForSlot):

• dom/ShadowRoot.h:
• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::assignToSlot):

• dom/SlotAssignment.h:
• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::assignedNodes const):
(WebCore::flattenAssignedNodes):
(WebCore:: const): Deleted.

• html/HTMLSlotElement.h:
• page/FocusController.cpp:

(WebCore::FocusNavigationScope::firstNodeInScope const):
(WebCore::FocusNavigationScope::lastNodeInScope const):

6:02 PM Changeset in webkit [266211] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION: ASSERT NOT REACHED: WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree
​https://bugs.webkit.org/show_bug.cgi?id=215875

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

6:00 PM Changeset in webkit [266210] by Alexey Shvayka

• 7 edits in trunk/Source/JavaScriptCore

Use unsigned type for length of JSFunction
​https://bugs.webkit.org/show_bug.cgi?id=215870

Reviewed by Darin Adler.

Since the length value of a built-in function is its arity,
we can communicate it's always non-negative via method signatures.

No behavior change: length values redefined by user code are unaffected.

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):

• runtime/InternalFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):

• runtime/JSFunction.h:
• runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::finishCreation):
(JSC::JSNativeStdFunction::create):

• runtime/JSNativeStdFunction.h:

5:43 PM Changeset in webkit [266209] by Russell Epstein

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.3

5:10 PM Changeset in webkit [266208] by clopez@igalia.com

• 6 edits in trunk/Tools

[GTK][WPE] Add bots for generating nightly bundle packages
​https://bugs.webkit.org/show_bug.cgi?id=215623

Reviewed by Aakash Jain.

This adds a new type of bots for GTK and WPE that runs nightly (once per day).
The goal of this bots its to build WebKit for a specific distribution (Ubuntu LTS and LTS-1)
and generate a bundle with the result of the build. The bundles are then uploaded to a
server for consumption on other CIs like WPT.

The MiniBrowser bundle targets a specific distribution, so each one of this new bots has to
run the generate-minibrowser-bundle step. However, the JSC bundle is distro-agnostic because
for JSC is possible to bundle all the system libraries (similar to a static build).
That means that we only need to run the step generate-jsc-bundle in one of the bots.
This step for generating the JSC bundle was previously executed in the bot
'GTK Linux 64-bit Release (Build)'. This patch moves it to one of this new added bots.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/factories.py:

(BuildFactory):
(BuildFactory.init):
(TestFactory):
(TestFactory.init):
(BuildAndGenerateMiniBrowserBundleFactory):
(BuildAndGenerateMiniBrowserJSCBundleFactory):

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
• BuildSlaveSupport/build.webkit.org-config/steps.py:

(GenerateJSCBundle):
(GenerateMiniBrowserBundle):

• BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

5:08 PM Changeset in webkit [266207] by Andres Gonzalez

• 8 edits in trunk

Buttons with aria-haspopup attribute are not exposed to accessibility clients as form controls.
​https://bugs.webkit.org/show_bug.cgi?id=215866

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/search-predicate-element-count.html.

Buttons with aria-haspopup were not included in the search results for
client queries for form controls. Added buttons with aria-haspopup which
have role PopUpButton, to the list of roles returned as form controls.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isARIAInput): Re-wrote using a switch statement for clarity and maintainability.
(WebCore::AccessibilityObject::isARIAControl): Ditto.

• accessibility/AccessibilityObject.h:

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick): isARIAControl false implies

isARIAInput false, thus removed the

isARIAInput call.

LayoutTests:

Expanded this test to include the case of buttons with aria-haspopup and
several other elements with ARIA roles that need to be retrieved when
clients search for input fields or form controls.

• accessibility/mac/search-predicate-element-count-expected.txt:
• accessibility/mac/search-predicate-element-count.html:

5:06 PM Changeset in webkit [266206] by commit-queue@webkit.org

• 7 edits
  4 adds in trunk

Leading white spaces should be ignored when parsing an SVG list property
​https://bugs.webkit.org/show_bug.cgi?id=215602

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-08-26
Reviewed by Sam Weinig.

Source/WebCore:

The SVG2.0 specs state that the CSS value definition syntax must be used
to define the syntax of the SVG attributes. The CSS syntax states that
leading and trailing spaces should be ignored when parsing the primitive
data types of all the SVG lists.

This has been inconsistency between WebKit and other browsers and within
WebKit itself. Parsing the attribute string of an SVGTransformList skips
the leading white spaces while the rest of the lists do not do that.

All the parsing methods should skip the leading white spaces before looping
to parse individual items. The last step of the loop is to skip the trailing
spaces and the delimiter which we do already.

Tests: svg/custom/feColorMatrix-values-leading-spaces.html

svg/dom/svg-list-properties-parser-leading-trailing-spaces.html

• svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse):

• svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse):

• svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse):

• svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parseGeneric):

LayoutTests:

• svg/custom/feColorMatrix-values-leading-spaces-expected.html: Added.
• svg/custom/feColorMatrix-values-leading-spaces.html: Added.
• svg/dom/length-list-parser-expected.txt:
• svg/dom/svg-list-properties-parser-leading-trailing-spaces-expected.txt: Added.
• svg/dom/svg-list-properties-parser-leading-trailing-spaces.html: Added.

4:58 PM Changeset in webkit [266205] by Alan Coon

• 1 copy in tags/Safari-610.2.2.3

Tag Safari-610.2.2.3.

4:38 PM Changeset in webkit [266204] by Alan Coon

• 54 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266168. rdar://problem/67836301

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::getType):
• Modules/async-clipboard/ClipboardImageReader.h: (WebCore::ClipboardImageReader::ClipboardImageReader):
• Modules/async-clipboard/ClipboardItem.cpp: (WebCore::ClipboardItem::blobFromString):
• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: (WebCore::ClipboardItemBindingsDataSource::getType):
• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm: (WebCore::ClipboardImageReader::readBuffer):
• Modules/entriesapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::getFile):
• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp: (WebCore::FileSystemFileEntry::file):
• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::fromFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::blobFromData): (WebCore::packageFormData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve): (WebCore::FetchBodyConsumer::takeAsBlob):
• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::blob):
• Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::stopRecording): (WebCore::MediaRecorder::requestData):
• Modules/mediastream/RTCDataChannel.cpp: (WebCore::RTCDataChannel::didReceiveRawData):
• Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::didReceiveBinaryData):
• Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
• bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal):
• dom/DataTransfer.cpp: (WebCore::DataTransfer::updateFileList): (WebCore::DataTransfer::items): (WebCore::DataTransfer::filesFromPasteboardAndItemList const): (WebCore::DataTransfer::files const):
• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp: (WebCore::DataTransferItemList::DataTransferItemList): (WebCore::DataTransferItemList::remove): (WebCore::DataTransferItemList::clear): (WebCore::DataTransferItemList::ensureItems const): (WebCore::DataTransferItemList::document const):
• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp: (WebCore::WebCorePasteboardFileReader::readFilename): (WebCore::WebCorePasteboardFileReader::readBuffer):
• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentForImageAttachment): (WebCore::replaceRichContentWithAttachments): (WebCore::createFragmentAndAddResources): (WebCore::sanitizeMarkupWithArchive): (WebCore::WebContentReader::readImage): (WebCore::attachmentForFilePath): (WebCore::attachmentForData):
• editing/markup.cpp: (WebCore::restoreAttachmentElementsInFragment):
• fileapi/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::loadBlob): (WebCore::Blob::activeDOMObjectName const):
• fileapi/Blob.h: (WebCore::Blob::create): (WebCore::Blob::deserialize): (WebCore::Blob::slice const):
• fileapi/Blob.idl:
• fileapi/File.cpp: (WebCore::File::createWithRelativePath): (WebCore::File::create): (WebCore::File::File): (WebCore::File::activeDOMObjectName const):
• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp: (WebCore::DOMFormData::createFileEntry):
• html/DirectoryFileListCreator.cpp: (WebCore::FileInformation::isolatedCopy const): (WebCore::appendDirectoryFiles): (WebCore::gatherFileInformation): (WebCore::toFileList): (WebCore::DirectoryFileListCreator::start):
• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp: (WebCore::FileInputType::appendFormData const): (WebCore::FileInputType::filesChosen):
• html/HTMLAttachmentElement.cpp: (WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toBlob):
• testing/Internals.cpp: (WebCore::Internals::createFile):
• testing/ServiceWorkerInternals.cpp: (WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):
• workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::dispatchFetchEvent):
• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266203] by Alan Coon

• 34 edits in branches/safari-610-branch

Cherry-pick r266087. rdar://problem/67836301

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/abort/general.any-expected.txt:
• web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers.
• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt: This change makes the formData failures in this file look like all the other failures in this file, which should be fixed together in a separate patch.
• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/url/urlencoded-parser.any-expected.txt:
• web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

• Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::formData): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeFormData):
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::formDataFromData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve):
• Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish): Add a fast path that allows non-blob FormData responses from service workers to not hang. This part is covered by this layout test: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

• wtf/text/WTFString.cpp: (WTF::fromUTF8Helper): (WTF::String::fromUTF8): (WTF::String::fromUTF8ReplacingInvalidSequences):
• wtf/text/WTFString.h:
• wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertUTF8ToUTF16Impl): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):
• wtf/unicode/UTF8Conversion.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:38 PM Changeset in webkit [266202] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266176. rdar://problem/67836292

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:21 PM Changeset in webkit [266201] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)
Rebaseline test, remove test expectation.

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

4:12 PM Changeset in webkit [266200] by Karl Rackler

• 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline constant css-cascade test failure

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

3:39 PM Changeset in webkit [266199] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.3

3:34 PM Changeset in webkit [266198] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid unnecessarily copying a Vector in WebCore::transformsForValue
​https://bugs.webkit.org/show_bug.cgi?id=215858

Reviewed by Tim Horton.

Avoid copying the Vector of TransformOperations in this helper function by directly appending newly created
transform operations to the given TransformOperations. This does, however, mean that we need to clear these
items in the case where conversion fails and we return false.

• css/TransformFunctions.cpp:

(WebCore::transformsForValue):

3:27 PM Changeset in webkit [266197] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.4

Tag Safari-610.1.28.0.4.

3:15 PM Changeset in webkit [266196] by Lauro Moura

• 3 edits
  2 copies
  1 add
  2 deletes in trunk/LayoutTests

[WPE][GTK] Gardening and rebaseline

Unreviewed test gardening.

Moving some GTK-specific baselines to GLIB and removing some uneeded
baselines (failure should be expected)

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Copied from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.
• platform/gtk/streams/pipe-to-expected.txt: Removed.
• platform/wpe/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Renamed from LayoutTests/platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt.

3:14 PM Changeset in webkit [266195] by Alan Coon

• 1 copy in tags/Safari-610.2.2.2

Tag Safari-610.2.2.2.

3:03 PM Changeset in webkit [266194] by Aditya Keerthi

• 4 edits
  2 adds in trunk

[iOS] Disabled options in the multi-select picker should not be selectable
​https://bugs.webkit.org/show_bug.cgi?id=201458
<rdar://problem/55018179>

Reviewed by Wenson Hsieh.

Source/WebKit:

WKMultipleSelectPicker is displayed when a <select multiple> or a
<select> with an <optgroup> is activated. Due to <rdar://problem/18745253>,
group rows and disabled rows were selectable in the picker. r175266 added a
workaround for this issue, preventing group rows from being selectable.
However, the workaround did not account for disabled rows, which means that
it is possible to select disabled options in the multi-select picker.

To fix this behavior, the same fix that was applied to group rows is now
applied to disabled rows. pickerView:row:column:checked: resets the style
for the associated view if item.disabled is true.

Test: fast/forms/ios/disabled-options-in-multi-select-picker.html

• UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker pickerView:row:column:checked:]):

LayoutTests:

Added a test to verify that disabled options cannot be selected when the
multi-select picker is presented.

• fast/forms/ios/disabled-options-in-multi-select-picker-expected.txt: Added.
• fast/forms/ios/disabled-options-in-multi-select-picker.html: Added.
• platform/ipad/TestExpectations:

2:32 PM Changeset in webkit [266193] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r266074): cannot edit JavaScript breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=215860

Reviewed by Brian Burg.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.prototype.get editable):

2:05 PM Changeset in webkit [266192] by Chris Dumez

• 10 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky webaudio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

2:04 PM Changeset in webkit [266191] by Hector Lopez

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

2:01 PM Changeset in webkit [266190] by Jonathan Bedard

• 4 edits
  3 adds in trunk/Tools

[webkitcorepy] Standard Popen mocking API

​https://bugs.webkit.org/show_bug.cgi?id=215712
<rdar://problem/67501911>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/README.md: Add mocks.Subprocess documentation.
• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py: Export Subprocess, ProcessCompletion.
• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py: Added.

(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(PopenBase): Base class to share code between Python 2 and 3 constructor.
(Popen): Mock Popen object (for both Python 2 and 3). This object extracts a ProcessCompletion object from the
mocked Subprocess stack and behaives according to the content of that object.

• Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py: Added.

(ProcessCompletion): Class which captures the result of a mock Popen call.
(Subprocess):
(Subprocess.CommandRoute): Object which routes a set of subprocess arguments to a specific ProcessCompletion or callback which
generates a ProcessCompletion.
(Subprocess.completion_generator_for): Given a file, search through the mocked Subprocess stack to find the
first completion for the provided file.
(Subprocess.completion_for): Extract file name from arguments, find the completion generator, and call
it with the provieded arguments, working directory and stdin.
(Subprocess.init):

• Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/subprocess_unittest.py: Added.

(MockSubprocess):
(MockCheckOutput):
(MockCheckCall):
(MockRun):

1:42 PM Changeset in webkit [266189] by dino@apple.com

• 3 edits
  2 adds in trunk

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only
mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

1:32 PM Changeset in webkit [266188] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.4

Tag Safari-610.1.28.1.4.

1:18 PM Changeset in webkit [266187] by commit-queue@webkit.org

• 19 edits in trunk

Implement DataTransfer constructor and multipart form filename encoding as other browsers do
​https://bugs.webkit.org/show_bug.cgi?id=215837

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/send-file-form-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-utf-8-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative-expected.txt:
• web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-constructor-001-expected.txt:
• web-platform-tests/html/editing/dnd/datastore/datatransfer-types-expected.txt:

This test still fails because of bindings issues. DataTransfer.types should apparently return
a cached JSValue that is updated whenever the contents change, which I don't think our bindings
generator can handle right now, so these tests are now failing in a different way.
I think that's fine because I think most uses of DataTransfer.types will just be checking the contents,
not whether its === to a stored reference like these tests do. We should fix this later.

• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html:

Updated to successfully submit the form to a listening server in our test infrastructure,
so that we see PASS like we do now on wpt.live

• web-platform-tests/service-workers/service-worker/data-transfer-files.https-expected.txt:

Source/WebCore:

Covered by newly passing WPT tests that Chrome and Firefox both pass.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::create):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):

LayoutTests:

• fast/dom/dom-constructors-expected.txt:
• fast/dom/dom-constructors.html:

1:09 PM Changeset in webkit [266186] by Chris Dumez

• 22 edits
  11 adds in trunk

IIRFilterNode interface is not supported
​https://bugs.webkit.org/show_bug.cgi?id=215810

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/webaudio/idlharness.https.window-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/test-iirfilternode-expected.txt:

Source/WebCore:

Add support for IIRFilterNode interface:

• ​https://www.w3.org/TR/webaudio/#iirfilternode

The implementation is based on Chromium's.

No new tests, rebaselined existing tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):
(WebCore::AudioNode::disableOutputsIfNecessary):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::createIIRFilter):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/BaseAudioContext.idl:
• Modules/webaudio/IIRDSPKernel.cpp: Added.

(WebCore::IIRDSPKernel::IIRDSPKernel):
(WebCore::IIRDSPKernel::getFrequencyResponse):
(WebCore::IIRDSPKernel::process):
(WebCore::IIRDSPKernel::reset):

• Modules/webaudio/IIRDSPKernel.h: Added.
• Modules/webaudio/IIRFilterNode.cpp: Added.

(WebCore::isFilterStable):
(WebCore::IIRFilterNode::create):
(WebCore::IIRFilterNode::IIRFilterNode):
(WebCore::IIRFilterNode::getFrequencyResponse):

• Modules/webaudio/IIRFilterNode.h: Added.
• Modules/webaudio/IIRFilterNode.idl: Added.
• Modules/webaudio/IIRFilterOptions.h: Added.
• Modules/webaudio/IIRFilterOptions.idl: Added.
• Modules/webaudio/IIRProcessor.cpp: Added.

(WebCore::IIRProcessor::IIRProcessor):
(WebCore::IIRProcessor::~IIRProcessor):
(WebCore::IIRProcessor::createKernel):
(WebCore::IIRProcessor::process):
(WebCore::IIRProcessor::getFrequencyResponse):

• Modules/webaudio/IIRProcessor.h: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• platform/audio/IIRFilter.cpp: Added.

(WebCore::evaluatePolynomial):
(WebCore::IIRFilter::IIRFilter):
(WebCore::IIRFilter::reset):
(WebCore::IIRFilter::process):
(WebCore::IIRFilter::getFrequencyResponse):
(WebCore::IIRFilter::tailTime):

• platform/audio/IIRFilter.h: Added.
• platform/graphics/ImageUtilities.h:

1:04 PM Changeset in webkit [266185] by Alan Coon

• 6 edits
  1 add in branches/safari-610.1.28.1-branch

Cherry-pick r265996. rdar://problem/67707045

[macOS] Web pages are not responding correctly to changes in "Reduce motion" setting
​https://bugs.webkit.org/show_bug.cgi?id=215664

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare "Reduce motion" preference key, as well as notification sent when the "Reduce motion" setting is changed.

• pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

This happens because there is a race between the preference change and notification being received in the WebContent
process. This race is usually won by the notification, which then reads the wrong preference value when being handled.
This bug was introduced when access to the preference daemon was closed in the WebContent process, and preferences
were updated from the UI process. This patch addresses this issue by re-posting the notification when the preference
value is updated in the WebContent process.

API test: WebKit.AccessibilityReduceMotion

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::reduceMotionPreferenceKey): (WebKit::dispatchSimulatedNotificationsForPreferenceChange):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm: Added. (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:04 PM Changeset in webkit [266184] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r265985. rdar://problem/67707039

REGRESSION (r263729): Carousel freezes on "fourth page"/fourth click on right arrow on netflix.com
​https://bugs.webkit.org/show_bug.cgi?id=215655
<rdar://problem/65845979>

Reviewed by Dean Jackson.

Source/WebCore:

On netflix.com, when clicking on the left and right arrows in each movie or TV show carousel, the page attempts
to animate to the next page of the carousel using a CSS transform transition. The logic applies transform and
transition CSS properties to a container div, and adds a transitionend event listener which the page
expects to be invoked when the animation is complete. While waiting for this transitionend event, the script
also sets a boolean flag that prevents the carousel from being advanced to any other page. However, after the
changes in r263729, the carousel gets into a state where transition and transform styles are set, but the
animation never begins, and thus, no subsequent transitionend event is observed. This causes the page to
believe that the carousel is indefinitely animating, so it never unsets the boolean flag, which results in the
carousel being permanently stuck.

This occurs because we now have logic in AnimationTimeline::updateCSSTransitionsForElementAndProperty that
moves the CSSTransition from the element's map of running transitions to the map of completed transitions in
the case where the corresponding WebAnimation is already in Finished state. However, consider the case where
there is no matching backing animation (i.e. matchingBackingAnimation is nullptr); for instance, this can
happen if the transition CSS property is set to none in the middle of the transitionend event, as demonstrated
in the new layout test. Before the change, we would've removed the CSSTransition from the map of running
transitions and canceled it, but now, we instead move it to the map of completed transitions, where it remains
until the next CSS transition update is triggered (which would potentially be indefinitely long!).

On netflix.com, this next CSS transition update happens the page attempts to advance the carousel. Since the old
CSSTransition is still in the "completed" transitions map, we end up returning true when checking
propertyInStyleMatchesValueForTransitionInMap, and consequently never attempt to create a new CSSTransition
and add it to the map of running transitions in step 1 of the algorithm. As described above, this causes the
carousel to get stuck in a bad state.

To fix this, we simply revert to pre-r263729 behavior in the case where the matching backing animation was
already removed, and allow step 3 of the algorithm to cancel the running animation and remove it altogether
instead of moving it into the element's completed transitions map.

Test: animations/animation-followed-by-two-transitions.html

• animation/AnimationTimeline.cpp: (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

LayoutTests:

Adds a layout test inspired by animation logic used in the broken carousel UI on netflix.com. This test can be
manually run by opening the test in a browser and verifying that the green square quickly slides across the
screen twice, and two transitionend events are observed in the process.

• animations/animation-followed-by-two-transitions-expected.txt: Added.
• animations/animation-followed-by-two-transitions.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:57 PM Changeset in webkit [266183] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.4

12:54 PM Changeset in webkit [266182] by eric.carlson@apple.com

• 2 edits in trunk/Tools

TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>

Reviewed by Jer Noble.

This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force
GC while waiting for status to change.
(TEST_F):

12:44 PM Changeset in webkit [266181] by commit-queue@webkit.org

• 4 edits in trunk

Use endings from FilePropertyBag when constructing Blob data from the File
​https://bugs.webkit.org/show_bug.cgi?id=215857

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-26
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/FileAPI/file/File-constructor-endings-expected.txt:

Source/WebCore:

We had an unnecessary conversion function that converted one of the two properties of BlobPropertyBag (endings was missing).
Since FilePropertyBag inherits from BlobPropertyBag, just use the original FilePropertyBag to get both properties.

Covered by newly-passing WPT tests that Chrome and Firefox both pass.

• fileapi/File.cpp:

(WebCore::File::File):
(WebCore::convertPropertyBag): Deleted.

12:36 PM Changeset in webkit [266180] by ysuzuki@apple.com

• 6 edits in trunk

[JSC] Enable Intl.Segmenter
​https://bugs.webkit.org/show_bug.cgi?id=215854

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-segmenter.js:
• test262/config.yaml:

Source/JavaScriptCore:

This is already stage-3 and all the features are implemented. Let's just enable it.

• runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

• runtime/OptionsList.h:

11:49 AM Changeset in webkit [266179] by Russell Epstein

• 5 edits
  4 adds in branches/safari-610.1.28.0-branch

Apply patch. rdar://problem/67812567

11:41 AM Changeset in webkit [266178] by ysuzuki@apple.com

• 8 edits
  1 add in trunk

[JSC] Add ASCII comparison fast path for IntlCollator
​https://bugs.webkit.org/show_bug.cgi?id=215798

Reviewed by Darin Adler, Ross Kirsling, and Saam Barati.

JSTests:

• stress/string-locale-compare-uca-ducet.js: Added.

(shouldBe):

• stress/string-localeCompare.js:

(data.sort):

Source/JavaScriptCore:

The idea behind this change is the following: ICU Collator's comparison is too slow. We should have fast path for ASCII strings when we know this equals to ICU Collator's result.
The problem is that even for ASCII strings, collation is super complicated!

1. Unicode defines Unicode Collation Algorithm (UCA). To perform collation, it uses collation element tables which defines weights on various levels per code point. UCA also offers the Default Unicode Collation Element Table (DUCET). This UCA with DUCET is used when using ICU Root Collator.
2. UCA collation consists of rules, which defines how collation works. And ICU locales define customized collations by adding special rules to that.
3. UCA behaves differently by using different options.

Based on that, our observation is that some of major locales are not defining additional rules in (2). This means that they behaves the same to UCA with DUCET.
This patch implements a simplified version of comparison which generates the same results for ASCII strings (excluding control characters) to UCA with DUCET. This fast path can be usable only when the following conditions are met.

1. The collator does not have additional rules to ICU Root Colator.
2. The collator is using default options.

These checks are very important since there are a lot of edge-case locales. For example,

1. th (Thai language) ignores punctuations (even including ASCII punctuations) by default. This is defined as ignore-punctuations option is enabled by default, so without (2)'s check, th comparison becomes wrong.
2. There are contraction concept (multiple letters behave as a single letter). "ch" letters are ordered interestingly in Czech language. So even in ASCII, Czech shows very interesting collation behavior.

So we cannot safely take this fast path without carefully querying the information to ICU.

This shows 37% improvement in JetStream2/cdjs in en-US environment.

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings const):
(JSC::canDoASCIIUCADUCETComparisonWithUCollator):
(JSC::IntlCollator::updateCanDoASCIIUCADUCETComparison const):
(JSC::IntlCollator::checkICULocaleInvariants):

• runtime/IntlCollator.h:
• runtime/IntlObject.cpp:

(JSC::intlCollatorAvailableLocales):

• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h:

(JSC::canUseASCIIUCADUCETComparison):
(JSC::compareASCIIWithUCADUCET):

11:07 AM Changeset in webkit [266177] by youenn@apple.com

• 16 edits
  2 copies in trunk

Abort pipeTo based on AbortSignal
​https://bugs.webkit.org/show_bug.cgi?id=215448

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:

Source/WebCore:

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/streams/ReadableStreamInternals.js:

(readableStreamPipeToWritableStream):
(pipeToFinalize):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::makeDOMExceptionForBuiltins):
(WebCore::whenSignalAborted):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortAlgorithm.h: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortAlgorithm.idl: Copied from Source/WebCore/dom/AbortSignal.idl.
• dom/AbortSignal.cpp:

(WebCore::AbortSignal::whenSignalAborted):

• dom/AbortSignal.h:
• dom/AbortSignal.idl:

10:57 AM Changeset in webkit [266176] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[Mac,EME] Netflix.com shows HDCP error for all streams
​https://bugs.webkit.org/show_bug.cgi?id=215825

Reviewed by Eric Carlson.

New API added to AVContentKeySession hits a sandbox restriction when run in the WebContent process, and the default
behavior when an error checking HDCP status is to report that the output is restricted, regardless of the displays
actual capabilities. To work around this behavior for now, pass in an empty displayID array, rather than the actual
displayID. This causes AVFoundation to do a "lowest common level of support" rather than a specific display check.
The upside is that this call no longer requires a connection to the WindowServer. The downside is that the
AVContentKeyRequest will report that its output is restricted if any non-HDCP compliant display is attached.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

10:53 AM Changeset in webkit [266175] by Russell Epstein

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.4

10:43 AM Changeset in webkit [266174] by Russell Epstein

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.2

10:40 AM Changeset in webkit [266173] by Oriol Brufau

• 4 edits
  2 adds in trunk

[css-grid] Set available column space before grid items prelayout
​https://bugs.webkit.org/show_bug.cgi?id=199648

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Import WPT test.

• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008-expected.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html: Added.
• web-platform-tests/css/css-grid/alignment/self-baseline/w3c-import.log:

Source/WebCore:

Before running the grid track sizing algorithm, there is a prelayout
step which takes care of the baseline alignment of the items.
In order to do that, we estimate the size of the grid area, since we
have not calculated the final size yet.

The problem was that, when calculating this estimate, the available
column space had not been set yet. So if a column had a percentage track
sizing function, it would be treated as auto and the estimated size
would be wrong.

This patch sets the available column space so that we can resolve
percentage track sizing functions and get a more correct estimate.

Test: imported/w3c/web-platform-tests/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

10:34 AM Changeset in webkit [266172] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

Enable WritableStream by default
​https://bugs.webkit.org/show_bug.cgi?id=149842

Reviewed by Alex Christensen.

Implementation is now ready and is up to date with the latest specification.

• Shared/WebPreferences.yaml:

10:24 AM Changeset in webkit [266171] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Code cleanup and consistent naming in AXIsolatedTree classes, no change in behavior.
​https://bugs.webkit.org/show_bug.cgi?id=215850

Reviewed by Chris Fleizach.

• Renamed AXIsolatedObject::m_attributeMap to m_propertyMap for naming

conssistency.

• typedef -> using
• Removed AXPropertyName::None, not used.
• Replaced AccessibilityIsolatedTreeMathMultiscriptPair alias with its

definition, shorter, clearer, and can be used for other property of the
same type.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setMathscripts):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::mathPrescripts):
(WebCore::AXIsolatedObject::mathPostscripts):
(WebCore::AXIsolatedObject::intPointAttributeValue const):
(WebCore::AXIsolatedObject::objectAttributeValue const):
(WebCore::AXIsolatedObject::rectAttributeValue const):
(WebCore::AXIsolatedObject::vectorAttributeValue const):
(WebCore::AXIsolatedObject::optionSetAttributeValue const):
(WebCore::AXIsolatedObject::pairAttributeValue const):
(WebCore::AXIsolatedObject::uint64AttributeValue const):
(WebCore::AXIsolatedObject::urlAttributeValue const):
(WebCore::AXIsolatedObject::pathAttributeValue const):
(WebCore::AXIsolatedObject::colorAttributeValue const):
(WebCore::AXIsolatedObject::floatAttributeValue const):
(WebCore::AXIsolatedObject::doubleAttributeValue const):
(WebCore::AXIsolatedObject::unsignedAttributeValue const):
(WebCore::AXIsolatedObject::boolAttributeValue const):
(WebCore::AXIsolatedObject::stringAttributeValue const):
(WebCore::AXIsolatedObject::intAttributeValue const):

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/isolatedtree/AXIsolatedTree.h:

9:48 AM Changeset in webkit [266170] by ysuzuki@apple.com

• 9 edits in trunk

[JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
​https://bugs.webkit.org/show_bug.cgi?id=215840

Reviewed by Ross Kirsling.

JSTests:

Test262 is showing wrong ordering of option property accesses compared to the latest PR.
Later, we should update Test262.

• stress/intl-datetimeformat.js:

(const.options.get second):
(const.options.get fractionalSecondDigits):
(const.options.get localeMatcher):
(const.options.get timeZoneName):
(const.options.get formatMatcher):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements fractionalSecondDigits option for Intl.DateTimeFormat. If it is
specified, milliseconds in N digits are represented in the formatted output.
This extension is about to be merged into the spec[1]. SpiderMonkey and V8 support it,
and V8 shipped it without flags.

[1]: ​https://github.com/tc39/ecma402/pull/347

• builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

• runtime/CommonIdentifiers.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::partTypeString):

• runtime/IntlDateTimeFormat.h:

9:46 AM Changeset in webkit [266169] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Move inline run alignment logic to a dedicated class
​https://bugs.webkit.org/show_bug.cgi?id=214527
<rdar://problem/66115796>

Reviewed by Antti Koivisto.

This is in preparation for moving line alignment logic to LineBox (LineBuilder will not going to be responsible for aligning runs on the line).

• layout/FormattingContext.h:
• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineContentAligner::formattingContext const):
(WebCore::Layout::LineContentAligner::layoutState const):
(WebCore::Layout::LineContentAligner::LineContentAligner):
(WebCore::Layout::LineContentAligner::alignHorizontally):
(WebCore::Layout::LineContentAligner::alignVertically):
(WebCore::Layout::LineContentAligner::justifyRuns):
(WebCore::Layout::LineContentAligner::adjustBaselineAndLineHeight):
(WebCore::Layout::LineContentAligner::collectHangingContent const):
(WebCore::Layout::LineContentAligner::runContentHeight const):
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::~LineBuilder):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::clear):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::alignContentVertically): Deleted.
(WebCore::Layout::LineBuilder::justifyRuns): Deleted.
(WebCore::Layout::LineBuilder::alignHorizontally): Deleted.
(WebCore::Layout::LineBuilder::collectHangingContent): Deleted.
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBuilder::runContentHeight const): Deleted.
(WebCore::Layout::LineBuilder::layoutState const): Deleted.
(WebCore::Layout::LineBuilder::root const): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::availableWidth const):
(WebCore::Layout::LineBuilder::contentLogicalRight const):
(WebCore::Layout::LineBuilder::logicalTop const): Deleted.
(WebCore::Layout::LineBuilder::logicalBottom const): Deleted.
(WebCore::Layout::LineBuilder::logicalLeft const): Deleted.
(WebCore::Layout::LineBuilder::logicalRight const): Deleted.
(WebCore::Layout::LineBuilder::logicalWidth const): Deleted.
(WebCore::Layout::LineBuilder::logicalHeight const): Deleted.
(WebCore::Layout::LineBuilder::baseline const): Deleted.

9:18 AM Changeset in webkit [266168] by Chris Dumez

• 54 edits
  2 adds in trunk

REGRESSION (r265908): Crash under Blob::arrayBuffer() / Blob::text() in stress GC
​https://bugs.webkit.org/show_bug.cgi?id=215832
<rdar://problem/67741677>

Reviewed by Ryosuke Niwa.

Source/WebCore:

r265908 added support for Blob::arrayBuffer() / Blob::text() which are asynchronous operations
returning promises. The crash is due to the fact that the Blob's JS wrapper may get garbage
collected before the promise is settled.

To address the issue, this patch makes Blob an ActiveDOMObject and creates an
ActiveDOMObject::pendingActivity whenever there is a pending promise so that the JS wrapper
does not get garbage collected too early.

Test: fast/files/blob-text-gc.html

• Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::getType):

• Modules/async-clipboard/ClipboardImageReader.h:

(WebCore::ClipboardImageReader::ClipboardImageReader):

• Modules/async-clipboard/ClipboardItem.cpp:

(WebCore::ClipboardItem::blobFromString):

• Modules/async-clipboard/ClipboardItem.h:
• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::getType):

• Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getFile):

• Modules/entriesapi/DOMFileSystem.h:
• Modules/entriesapi/FileSystemFileEntry.cpp:

(WebCore::FileSystemFileEntry::file):

• Modules/entriesapi/FileSystemFileEntry.h:
• Modules/entriesapi/FileSystemFileEntry.idl:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::fromFormData):

• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::blobFromData):
(WebCore::packageFormData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeAsBlob):

• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::blob):

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::requestData):

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::didReceiveRawData):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

• Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::updateFileList):
(WebCore::DataTransfer::items):
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):
(WebCore::DataTransfer::files const):

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::remove):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::DataTransferItemList::document const):

• dom/DataTransferItemList.h:
• dom/DataTransferItemList.idl:
• editing/WebCorePasteboardFileReader.cpp:

(WebCore::WebCorePasteboardFileReader::readFilename):
(WebCore::WebCorePasteboardFileReader::readBuffer):

• editing/WebCorePasteboardFileReader.h:
• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readImage):
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):

• editing/markup.cpp:

(WebCore::restoreAttachmentElementsInFragment):

• fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::loadBlob):
(WebCore::Blob::activeDOMObjectName const):

• fileapi/Blob.h:

(WebCore::Blob::create):
(WebCore::Blob::deserialize):
(WebCore::Blob::slice const):

• fileapi/Blob.idl:
• fileapi/File.cpp:

(WebCore::File::createWithRelativePath):
(WebCore::File::create):
(WebCore::File::File):
(WebCore::File::activeDOMObjectName const):

• fileapi/File.h:
• fileapi/File.idl:
• html/DOMFormData.cpp:

(WebCore::DOMFormData::createFileEntry):

• html/DirectoryFileListCreator.cpp:

(WebCore::FileInformation::isolatedCopy const):
(WebCore::appendDirectoryFiles):
(WebCore::gatherFileInformation):
(WebCore::toFileList):
(WebCore::DirectoryFileListCreator::start):

• html/DirectoryFileListCreator.h:
• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):
(WebCore::FileInputType::filesChosen):

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

• testing/Internals.cpp:

(WebCore::Internals::createFile):

• testing/ServiceWorkerInternals.cpp:

(WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):

• workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createResponseBlob):

Source/WebKit:

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):

LayoutTests:

Add better test coverage.

• fast/files/blob-text-gc-expected.txt: Added.
• fast/files/blob-text-gc.html: Added.

5:08 AM Changeset in webkit [266167] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

When caching the AccessibilityText property in AXIsolatedObject, the Strings need to be isolatedCopied.
​https://bugs.webkit.org/show_bug.cgi?id=215834

Reviewed by Chris Fleizach.

The initialization of the AccessibilityText property in AXIsolatedObject::initializeAttributeData
wasn't isolatedCopying the Strings contained in the AccessibilityText structure.
Instead it was copying the String into a different structure. This patch
straightlines the caching of the AccessibilityText property by isolatedCopying
the original Strings. This simplifies the retrieval of this property
since there is no conversion to make in the AXIsolatedObject::accessibilityText
method.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData): isolatedCopies the
String in AccessibilityText.
(WebCore::AXIsolatedObject::accessibilityText const): No conversion
needed to retrieve the property.

• accessibility/isolatedtree/AXIsolatedTree.h:

Removed the AccessibilityIsolatedTreeText structure since it is not needed.

4:16 AM Changeset in webkit [266166] by youenn@apple.com

• 44 edits
  2 adds in trunk

enumerateDevices should expose audiooutput devices that are tied to an audio input device
​https://bugs.webkit.org/show_bug.cgi?id=215806

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https-expected.txt:
• web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https.html:

Source/WebCore:

Add support for a speaker selection feature policy, as per ​https://w3c.github.io/mediacapture-output/#permissions-policy-integration.
Add support for speaker mock devices and for listing speakers on MacOS in CoreAudioCaptureDeviceManager.
Add support for groupId to group microphones and speakers for both mock audio manager and CoreAudioCaptureDeviceManager.
For mock speakers, we add two audiooutput devices that are related to a microphone and one audiooutput that is not related to any microphone.

Test: fast/mediastream/enumerate-speaker.html

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::checkSpeakerAccess):
(WebCore::toMediaDeviceInfoKind):
(WebCore::MediaDevices::refreshDevices):

• Modules/mediastream/MediaDevices.h:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::sourceCaptureState):
(WebCore::MediaStreamTrack::updateToPageMutedState):

• html/FeaturePolicy.cpp:

(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

• html/FeaturePolicy.h:
• page/Settings.yaml:
• platform/mediastream/CaptureDevice.h:

(WebCore::CaptureDevice::label const):
(WebCore::CaptureDevice::setGroupId):

• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::getMediaStreamDevices):

• platform/mediastream/RealtimeMediaSourceFactory.h:
• platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::GStreamerAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:

(WebCore::CoreAudioCaptureDevice::create):
(WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice):
(WebCore::CoreAudioCaptureDevice::relatedAudioDeviceIDs):

• platform/mediastream/mac/CoreAudioCaptureDevice.h:
• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::CoreAudioCaptureDeviceManager::captureDevices):
(WebCore::deviceHasOutputStreams):
(WebCore::getDefaultCaptureInputDevice):
(WebCore::hasDevice):
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSourceFactory::speakerDevices const):

• platform/mediastream/mac/CoreAudioCaptureSource.h:
• platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:

(WebCore::DisplayCaptureManagerCocoa::captureDeviceWithPersistentID):

• platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::create):

• platform/mock/MockMediaDevice.h:

(WebCore::MockSpeakerProperties::encode const):
(WebCore::MockSpeakerProperties::decode):
(WebCore::MockMediaDevice::isSpeaker const):
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::speakerProperties const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decode):

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):
(WebCore::deviceListForDevice):
(WebCore::toCaptureDevice):
(WebCore::createMockDevice):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSourceCenter::microphoneDevices):
(WebCore::MockRealtimeMediaSourceCenter::speakerDevices):
(WebCore::MockRealtimeMediaSourceCenter::videoDevices):

• platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit:

Introduce an experimental flag (off by default) to cover speaker selection, including exposing speaker devices to web pages.
Update UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList to only expose speakers that are tied to a microphone that is exposed.
This aligns with ​https://w3c.github.io/mediacapture-output/#privacy-obtaining-consent.

• GPUProcess/GPUConnectionToWebProcess.cpp:
• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKMockMediaDevice.cpp:

(WKAddMockMediaDevice):

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetExposeSpeakersEnabled):
(WKPreferencesGetExposeSpeakersEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::isMicrophoneDevice):
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):

• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::sourceTypeFromDeviceType):
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::~RemoteRealtimeMediaSource):

• WebProcess/cocoa/UserMediaCaptureManager.h:

Tools:

Enable experimental flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

• fast/mediastream/enumerate-speaker-expected.txt: Added.
• fast/mediastream/enumerate-speaker.html: Added.
• fast/mediastream/get-user-media-device-id.html:
• http/tests/media/media-stream/enumerate-devices-source-id.html:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
• http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html:

Rewrite test to use testharness and ensure order of the iframe tests so that console messages are ordered.

• http/tests/media/media-stream/resources/enumerate-devices-iframe.html:

2:08 AM Changeset in webkit [266165] by Diego Pino Garcia

• 3 edits in trunk/Tools

[ews] Split JSC ARMv7 queue into separate builder and tester queue
​https://bugs.webkit.org/show_bug.cgi?id=215728

Reviewed by Aakash Jain.

This new bubble runs jscore-tests for JSC ARMv7 32-bit. The former
'jsc-armv7' bubble now reports about successful binary builds for the
same architecture.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

• BuildSlaveSupport/ews-build/config.json:

12:53 AM Changeset in webkit [266164] by Paulo Matos

• 2 edits in trunk/JSTests

Skip stress/array-species-create-should-handle-masquerader.js on MIPS

Unreviewed Gardening.

• stress/array-species-create-should-handle-masquerader.js:

12:51 AM Changeset in webkit [266163] by Diego Pino Garcia

• 2 edits
  2 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Emit baseline after r266129.

Also mark two tests as time out flaky after r266118.

• platform/glib/TestExpectations:
• platform/gtk/streams/pipe-to-expected.txt: Added.

12:22 AM Changeset in webkit [266162] by youenn@apple.com

• 5 edits in trunk

pipeThrough should check for readableStream type
​https://bugs.webkit.org/show_bug.cgi?id=215497

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

Aug 25, 2020:

11:26 PM Changeset in webkit [266161] by Diego Pino Garcia

• 17 edits in trunk/LayoutTests

[GTK] Update test expectations. Update baselines after r266118.

• platform/glib/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
• platform/gtk/css1/font_properties/font-expected.txt:
• platform/gtk/fast/css/font-face-multiple-faces-expected.txt:
• platform/gtk/fast/css/font-face-synthetic-bold-italic-expected.txt:
• platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
• platform/gtk/fast/invalid/junk-data-expected.txt:
• platform/gtk/fast/invalid/missing-end-tag-expected.txt:
• platform/gtk/fast/parser/xhtml-alternate-entities-expected.txt:
• platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
• platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
• platform/gtk/svg/custom/bug45331-expected.txt:
• platform/gtk/svg/custom/junk-data-expected.txt:
• platform/gtk/svg/custom/missing-xlink-expected.txt:
• platform/gtk/svg/custom/path-bad-data-expected.txt:
• platform/gtk/svg/custom/use-font-face-crash-expected.txt:
• platform/gtk/svg/hixie/error/012-expected.txt:

11:15 PM Changeset in webkit [266160] by Fujii Hironori

• 4 edits in trunk/Source/WebCore

Move FreeType port's Font::platformWidthForGlyph and Font::platformBoundsForGlyph for Cairo port (WinCairo port)
​https://bugs.webkit.org/show_bug.cgi?id=215838

Reviewed by Carlos Garcia Campos.

WinCairo was using GDI API to implement
Font::platformWidthForGlyph and Font::platformBoundsForGlyph. This
is a problem for Cairo DirectWrite font backend (Bug 215259).
FreeType port has platform independent implementations which are
using Cairo API. Use them for WinCairo.

• platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved from SimpleFontDataFreeType.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformBoundsForGlyph const): Moved to FontCairo.cpp.
(WebCore::Font::platformWidthForGlyph const): Ditto.

• platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformWidthForGlyph const): Deleted.

10:17 PM Changeset in webkit [266159] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
​https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

• stress/ftl-entry-osr-exit-has-nullptr-node.js: Added.

(foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToThis):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueSub):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMul):
(JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileStrCat):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToB3::compileArithClz32):
(JSC::FTL::DFG::LowerDFGToB3::compileValueDiv):
(JSC::FTL::DFG::LowerDFGToB3::compileValueMod):
(JSC::FTL::DFG::LowerDFGToB3::compileArithAbs):
(JSC::FTL::DFG::LowerDFGToB3::compileArithUnary):
(JSC::FTL::DFG::LowerDFGToB3::compileValuePow):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRandom):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFloor):
(JSC::FTL::DFG::LowerDFGToB3::compileArithCeil):
(JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc):
(JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt):
(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):
(JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec):
(JSC::FTL::DFG::LowerDFGToB3::compileValueNegate):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift):
(JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames):
(JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate):
(JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumeric):
(JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive):
(JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArgument):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileSameValue):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileSwitch):
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):
(JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError):
(JSC::FTL::DFG::LowerDFGToB3::mapHashString):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileMapSet):
(JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsCallable):
(JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileInByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileParseInt):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
(JSC::FTL::DFG::LowerDFGToB3::compileToIndexString):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):
(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
(JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName):
(JSC::FTL::DFG::LowerDFGToB3::compileStringReplace):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
(JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileStringSlice):
(JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::compileLoopHint):
(JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare):
(JSC::FTL::DFG::LowerDFGToB3::stringsEqual):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::boolify):
(JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds):
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):

• jsc.cpp:

(runJSC):

• runtime/OptionsList.h:

10:09 PM Changeset in webkit [266158] by timothy_horton@apple.com

• 5 edits
  4 adds in trunk

Web Share API Level 2 functions even when its experimental feature flag is disabled
​https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

• page/Navigator.cpp:

(WebCore::Navigator::canShare):
Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
If the Web Content process sends us files, but the Level 2 feature flag is disabled,
something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

• fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/canShare-with-files-feature-disabled.html: Added.
• fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/share-with-files-feature-disabled.html: Added.

Add some tests that ensure that disabling the feature actually works.

7:25 PM Changeset in webkit [266157] by rniwa@webkit.org

• 24 edits in trunk

HashMap<Ref<T>>::take should return RefPtr<T>
​https://bugs.webkit.org/show_bug.cgi?id=215830

Reviewed by Darin Adler.

Source/WebCore:

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::removeTreeForPageID):

• crypto/SubtleCrypto.cpp:

(WebCore::getPromise):

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition):

• dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::notifyFinished):

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didRemoveDOMNode):

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::uninstallPageOverlay):

• workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::claim):

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::cancelFetch):

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::workerContextTerminated):

Source/WebKit:

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):

• NetworkProcess/NetworkResourceLoadMap.cpp:

(WebKit::NetworkResourceLoadMap::take):

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willClosePage):

• UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::taskCompleted):

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasDenied):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::didCheckSucceed):

Source/WTF:

Updated the hash traits for Ref<T> to make HashMap<Ref<T>> and HashSet<Ref<T>>
return RefPtr<T> instad of Optional<Ref<T>>.

• wtf/HashTraits.h:

(WTF::RefHashTraits::take):

Tools:

• TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

7:22 PM Changeset in webkit [266156] by Alan Bujtas

• 3 edits
  2 adds in trunk

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
​https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

• fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
• fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

6:31 PM Changeset in webkit [266155] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

[LFC][IFC] Do not move the runs out of the LineBuilder while closing the line
​https://bugs.webkit.org/show_bug.cgi?id=214790

Reviewed by Antti Koivisto.

Closing the line should not mean that the LineBuilder does not have the line runs anymore.
This is in preparation for moving alignment code from LineBuilder to LineBox.
(This patch also refactors InlineFormattingContext::lineLayout to make it less verbose.)

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::append):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::runs const):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::layoutInlineContent):
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::nextContentForLine):
(WebCore::Layout::LineLayoutContext::commitFloats):
(WebCore::Layout::LineLayoutContext::layoutLine): Deleted.

• layout/inlineformatting/LineLayoutContext.h:

(WebCore::Layout::LineLayoutContext::InlineItemRange::isEmpty const):
(WebCore::Layout::LineLayoutContext::InlineItemRange::size const):

5:28 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

5:08 PM Changeset in webkit [266154] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK][WPE] Add a script for generating MiniBrowser bundles (follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=215266

Unreviewed follow-up fix.

Ensure the install-dependencies script of the bundle calls apt-get update
before trying to install the system packages when --autoinstall is passed.

• Scripts/generate-bundle:

4:55 PM Changeset in webkit [266153] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67764580 REGRESSION: [ BigSur ] 20 fast/ and tables/ tests are a constant failure

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:33 PM Changeset in webkit [266152] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.3

Tag Safari-610.1.28.0.3.

3:46 PM Changeset in webkit [266151] by timothy_horton@apple.com

• 8 edits
  2 adds in trunk

Web Share API can share non-HTTP(S) URLs
​https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

• page/Navigator.cpp:

(WebCore::shareableURLForShareData):
(WebCore::Navigator::canShare):
(WebCore::Navigator::share):
Factor out the code to complete and check the scheme of the URL.
Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showShareSheet):
Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

• fast/web-share/share-disallows-file-urls-expected.txt: Added.
• fast/web-share/share-disallows-file-urls.html: Added.
• fast/web-share/share-transient-activation-expired.html:
• fast/web-share/share-transient-activation.html:
• fast/web-share/share.html:

Add a test that ensures that sharing a non-HTTP-family URL fails,
and fix the existing tests to share HTTP-family URLs.

3:26 PM Changeset in webkit [266150] by commit-queue@webkit.org

• 18 edits in trunk/Tools

Remove unneeded HAVE(NETWORK_FRAMEWORK) macro
​https://bugs.webkit.org/show_bug.cgi?id=215824

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Darin Adler.

This used to be needed for High Sierra support, which was before Network.framework was introduced.
Now, we can assume it is available on all Cocoa platforms.

• TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
• TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:
• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm:
• TestWebKitAPI/config.h:

3:20 PM Changeset in webkit [266149] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] The layout test animations/steps-transform-rendering-updates.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=215827

Unreviewed test gardening.

• platform/win/TestExpectations:

3:08 PM Changeset in webkit [266148] by beidson@apple.com

• 5 edits
  3 adds in trunk

Font loads quickly followed by navigations may fail indefinitely
<rdar://problem/65560550> and ​https://bugs.webkit.org/show_bug.cgi?id=215435

Reviewed by Myles C. Maxfield.

Source/WebCore:

Second take at this.

Myles took the first swipe at this, but a conflict with SuspendableTimer caused issues
in the form of layout test asserts with
http/tests/security/navigate-when-restoring-cached-page.html

His original ChangeLog entry:

Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.

This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:

1. The second page in the above story will not see that the font has failed, or

even started, and will then re-request the font and load it successfully

2. If the user goes "back" to the previous page, the zero-delay timer is restarted,

the CachedFont realizes it's already succeeded, and the previous page is rendered
as expected.

Test: fast/loader/font-load-timer.html

---

Now the explanation of the failure it caused:
The font loading timer was a SuspendableTimer, which is an ActiveDOMObject.

An ActiveDOMObject was used to make sure the delayed font loads play well with the
page cache, which is still necessary.

But we also still need to suspend the timer manually when "stopLoading()" is called,
which doesn't play well with ActiveDOMObject's automatic suspend/resume.

My solution:

• Make the timer "just a normal timer"
• Make CSSFontSelector itself the ActiveDOMObject
• Let DocumentLoader explicitly pause the font load timer
• Rely on ActiveDOMObject to resume the timer

These keep the bug fixed and resolve the layout test ASSERT seen with
http/tests/security/navigate-when-restoring-cached-page.html

• css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::beginLoadingFontSoon):
(WebCore::CSSFontSelector::suspendFontLoadingTimer):
(WebCore::CSSFontSelector::fontLoadingTimerFired):
(WebCore::CSSFontSelector::stop):
(WebCore::CSSFontSelector::suspend):
(WebCore::CSSFontSelector::resume):
(WebCore::CSSFontSelector::beginLoadTimerFired): Deleted.

• css/CSSFontSelector.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):

LayoutTests:

1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.

• fast/loader/font-load-timer-expected.html: Added.
• fast/loader/font-load-timer.html: Added.
• fast/loader/resources/font-load-timer-navigation-destination.html: Added.

3:00 PM Changeset in webkit [266147] by Alan Coon

• 1 copy in tags/Safari-610.2.2.1

Tag Safari-610.2.2.1.

2:57 PM Changeset in webkit [266146] by Alan Coon

• 19 edits
  2 deletes in branches/safari-610.2.2-branch

Revert r265115. rdar://problem/67759082

2:51 PM Changeset in webkit [266145] by pvollan@apple.com

• 3 edits in trunk/Source/WTF

[Win] Assert failure under RunLoop::RunLoop
​https://bugs.webkit.org/show_bug.cgi?id=215812

Reviewed by Brent Fulgham.

The assert 'ASSERT(::IsWindow(m_runLoopMessageWindow))' under RunLoop::RunLoop will fail if the JSC API JSGlobalContextCreate*()
is being called by a client before WTF::initializeMainThread() has been called. The assertion fails because the method
RunLoop::registerRunLoopMessageWindowClass() has not been called yet, since it is only called when initializing the main thread.
This patch addresses this issue by making sure the window class has been registered before being referenced in RunLoop::RunLoopl
The method call is also removed from the main thread initialization, since the window class is only used in RunLoop::RunLoop,
making it sufficient to only be registered there. Also change the debug assert to a release assert, so we can catch similar
issues in release builds.

• wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):

2:43 PM Changeset in webkit [266144] by Peng Liu

• 2 edits in trunk/Source/WebCore

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
​https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

2:34 PM Changeset in webkit [266143] by Megan Gardner

• 4 edits in trunk/Source

Trying to lookup when WebView is in a popover causes process to hang. Fix for Legacy WebView.
​https://bugs.webkit.org/show_bug.cgi?id=215792

Reviewed by Tim Horton.

Source/WebKit:

Update code based on Darin's suggestion for mirror fix in legacy webkit.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Source/WebKitLegacy/mac:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=214773 also needed in legacy WebView.
The Lookup framework does not populate the menus that it vends with the option to 'lookup'
words that are selected in popovers. WebKit should follow the pattern and not put the
item in the menu as Lookup is not able to handle this situation. Also if Lookup is disabled
via defaults, we should not show it in the menu.

• WebView/WebHTMLView.mm:

(customMenuFromDefaultItems):

2:22 PM Changeset in webkit [266142] by rniwa@webkit.org

• 8 edits in trunk

Resolve with the class used to define the Custom Element
​https://bugs.webkit.org/show_bug.cgi?id=215562

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync'ed the test with that in ​https://github.com/web-platform-tests/wpt/pull/25033.

• web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
• web-platform-tests/custom-elements/CustomElementRegistry.html:

Source/WebCore:

Implemented the new behavior to resolve customElements.whenDefined(~)
with the custom element's constructor when it's defined.

Test: imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):
(WebCore::whenDefinedPromise):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::resolveWithJSValue): Added.

• dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::addElementDefinition): Made this return DeferredPromise.

• dom/CustomElementRegistry.h:

1:20 PM Changeset in webkit [266141] by clopez@igalia.com

• 4 edits in trunk

[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
​https://bugs.webkit.org/show_bug.cgi?id=215730

Reviewed by Philippe Normand.

Source/WebKit:

QWheelEvent position is not available on Qt < 5.14. Use posF instead in that case.
Tested with Qt 5.11

No new tests, is a build fix.

• UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:

(WPEQtViewBackend::dispatchWheelEvent):

Tools:

When not running in flatpak the path to the qml directory is different.

• Scripts/run-qt-wpe-minibrowser:

12:09 PM Changeset in webkit [266140] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix read-after-free introduced in r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::packageFormData):
Keep the CString in scope while we are using it.

12:04 PM Changeset in webkit [266139] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Mojave wk1 ] fast/layers/hidpi-transform-on-child-content-is-mispositioned.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215819

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:49 AM Changeset in webkit [266138] by Devin Rousso

• 3 edits
  3 adds in trunk

Web Inspector: breakpoint condition should be evaluated before the ignore count
​https://bugs.webkit.org/show_bug.cgi?id=215364
<rdar://problem/67310703>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Previously, when pausing, JSC::Breakpoint would check that it's ignoreCount before it
would even attempt to evaluate it's condition. This meant that a JSC::Breakpoint with
a condition of foo === 42 and an ignoreCount of 3 would ignore the first three
pauses and then only pause if foo === 42. This is likely contrary to the expectation of
most users (especially since the condition input is before the ignoreCount input in
the Web Inspector frontend UI) in that they would probably expect to ignore the first
three pauses if foo === 42.

• debugger/Breakpoint.cpp:

(JSC::Breakpoint::shouldPause):

LayoutTests:

• inspector/debugger/resources/condition-ignoreCount.js: Added.

(trigger): Added.

• inspector/debugger/setBreakpoint-condition-ignoreCount.html: Added.
• inspector/debugger/setBreakpoint-condition-ignoreCount-expected.txt: Added.

11:47 AM Changeset in webkit [266137] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Release ] webgl/2.0.0/conformance2/textures/canvas_sub_rectangle/tex-2d-rgb32f-rgb-float.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215817

Unreviewed test gardening.

• platform/mac/TestExpectations:

11:46 AM Changeset in webkit [266136] by Andres Gonzalez

• 6 edits in trunk/Source/WebCore

Crash in WebCore::AccessibilityRenderObject::textUnderElement in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=215790

Reviewed by Darin Adler.

This crash is happening in isolated tree mode because AXIsolatedObject::initializeAttributeData
is caching all properties of the object on a checked state changed notification.
In some cases like the web page in the bug report, not all properties
can be computed in the notification handler. In particular AccessibilityRenderObject::textUnderElement
does the following checks:

Renders referenced by accessibility objects could get destroyed, if TextIterator ends up triggering
style update/layout here. See also AXObjectCache::deferTextChangedIfNeeded().
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->childNeedsStyleRecalc());
ASSERT_WITH_SECURITY_IMPLICATION(!nodeDocument->view()->layoutContext().isInRenderTreeLayout());

This patch addresses this problem by only updating the checked state
property of the isolated object, instead of all properties, in the
checked state change notification.
This is also a performance enhancement since only the property that
changed is re-calculated. The same approach will be used for other properties.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::updateIsolatedTree): Checked state changed notifications
trigger an update of the corresponding isolated object's chekced state
instead of the creation of a new object and re-calculation of all cached properties.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setProperty): Removed ASSERT since it is now
called in applyPendingChanges on the secondary thread.

• accessibility/isolatedtree/AXIsolatedObject.h: Moved the AXPropertyName

enumeration, the AttributeValueVariant and attribute map declarations
out of this header into AXIsolatedTree.h in order to be able to use them
in both classes.

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNode): Removed unnecessary scope operator.
(WebCore::AXIsolatedTree::updateNodeCheckedState): Added.
(WebCore::AXIsolatedTree::applyPendingChanges): Added updating the pending
properties on the secondary thread.

• accessibility/isolatedtree/AXIsolatedTree.h: Moved to this header the declarations

that are now shared by AXIsolatedObject and AXIsolatedTree.

11:37 AM Changeset in webkit [266135] by Devin Rousso

• 2 edits in trunk/Tools

REGRESSION(r265601): invalid blame URL copied when include_revision is false
​https://bugs.webkit.org/show_bug.cgi?id=215796

Reviewed by Daniel Bates.

• CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:

(CopyWebKitPermalinkCommand.permalink_for_path):
Always add ? to the URL before the revision and/or blame and have each have their own &.

11:07 AM Changeset in webkit [266134] by jer.noble@apple.com

• 4 edits
  1 add in trunk

[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=215660
<rdar://problem/65263150>

Reviewed by Darin Adler.

Source/WebKit:

API Test: Fullscreen.Focus.

The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
try to change the firstResponder in response to activation.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FullscreenFocus.mm: Added.

(-[FullscreenFocusUIDelegate _webViewDidEnterFullscreen:]):
(-[FullscreenFocusUIDelegate _webViewDidExitFullscreen:]):
(TestWebKitAPI::TEST):

11:06 AM Changeset in webkit [266133] by commit-queue@webkit.org

• 10 edits in trunk/Source

Clean up deprecated and unused SPI to set HSTS storage on ProcessPoolConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=215788

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-25
Reviewed by Chris Dumez.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

After rdar://problem/65047971 this is no longer needed because the replacement on WebsiteDataStoreConfiguration has been adopted.
The selector on _WKProcessPoolConfiguration had already been deprecated, and is left for now to allow easier debugging with OSes that use it still.

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

• UIProcess/API/APIProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setHSTSStorageDirectory:]):
(-[_WKProcessPoolConfiguration hstsStorageDirectory]):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

10:45 AM Changeset in webkit [266132] by Alan Coon

• 2 edits in branches/safari-610.2.2-branch/Source/WebKit

Cherry-pick r266099. rdar://problem/67742560

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:45 AM Changeset in webkit [266131] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.2.2-branch

Cherry-pick r265881. rdar://problem/67742375

REGRESSION(r265092): delegatesFocus causes WebKit to crash
​https://bugs.webkit.org/show_bug.cgi?id=215622

Reviewed by Youenn Fablet.

Source/WebCore:

The bug was caused by a missing nullptr check. Added it.

Test: fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html

• page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Added a nullptr check.

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-unsuccessfully-by-activation.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@265881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:41 AM Changeset in webkit [266130] by Alan Coon

• 8 edits in branches/safari-610.2.2-branch/Source

Versioning.

WebKit-7610.2.2.1

10:36 AM Changeset in webkit [266129] by youenn@apple.com

• 48 edits
  15 deletes in trunk

Refresh ReadableStream.pipeTo implementation up to spec
​https://bugs.webkit.org/show_bug.cgi?id=215415

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any-expected.txt:
• web-platform-tests/fetch/api/response/response-stream-disturbed-by-pipe.any.worker-expected.txt:
• web-platform-tests/streams/idlharness.any-expected.txt:
• web-platform-tests/streams/idlharness.any.worker-expected.txt:
• web-platform-tests/streams/piping/abort.any-expected.txt:
• web-platform-tests/streams/piping/abort.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/close-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-backward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward.any.worker-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward-expected.txt: Removed.
• web-platform-tests/streams/piping/error-propagation-forward.any-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.any.worker-expected.txt:
• web-platform-tests/streams/piping/flow-control-expected.txt: Removed.
• web-platform-tests/streams/piping/flow-control.any-expected.txt:
• web-platform-tests/streams/piping/flow-control.any.worker-expected.txt:
• web-platform-tests/streams/piping/general-expected.txt: Removed.
• web-platform-tests/streams/piping/general.any-expected.txt:
• web-platform-tests/streams/piping/general.any.worker-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation-expected.txt: Removed.
• web-platform-tests/streams/piping/multiple-propagation.any-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation.any.worker-expected.txt:
• web-platform-tests/streams/piping/pipe-through-expected.txt: Removed.
• web-platform-tests/streams/piping/pipe-through.any-expected.txt:
• web-platform-tests/streams/piping/pipe-through.any.worker-expected.txt:
• web-platform-tests/streams/piping/then-interception.any-expected.txt:
• web-platform-tests/streams/piping/then-interception.any.worker-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any-expected.txt:
• web-platform-tests/streams/piping/throwing-options.any.worker-expected.txt:
• web-platform-tests/streams/piping/transform-streams-expected.txt: Removed.
• web-platform-tests/streams/readable-streams/patched-global.any-expected.txt:
• web-platform-tests/streams/readable-streams/patched-global.any.worker-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any-expected.txt:
• web-platform-tests/streams/readable-streams/reentrant-strategies.any.worker-expected.txt:

Source/WebCore:

Update pipeTo implementation as per specification.
Keep the old implementation if WritableStream is not enabled.

Covered by existing tests.

• Modules/streams/ReadableStream.js:

(pipeThrough):

• Modules/streams/ReadableStreamInternals.js:

(acquireReadableStreamDefaultReader):
(readableStreamPipeToWritableStream):
(pipeToLoop):
(pipeToErrorsMustBePropagatedForward):
(pipeToErrorsMustBePropagatedBackward):
(pipeToClosingMustBePropagatedForward):
(pipeToClosingMustBePropagatedBackward):
(pipeToShutdownWithAction):
(pipeToShutdown):

• Modules/streams/WritableStream.js:

(initializeWritableStream):

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::isWritableStreamAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:
• dom/AbortSignal.idl:

Tools:

Put console log in stderr as this makes some tests flaky otherwise.

• DumpRenderTree/TestOptions.cpp:

(shouldDumpJSConsoleLogInStdErr):

• WebKitTestRunner/TestOptions.cpp:

(WTR::shouldDumpJSConsoleLogInStdErr):

LayoutTests:

Re-enable piping tests.
Remove obsolete tests.

• TestExpectations:
• streams/readable-stream-pipeThrough-expected.txt:
• streams/readable-stream-pipeThrough.html:

Update according new API.

• streams/reference-implementation/pipe-to-expected.txt: Removed.
• streams/reference-implementation/pipe-to.html: Removed.
• streams/reference-implementation/pipe-through-expected.txt: Removed.
• streams/reference-implementation/pipe-through.html: Removed.
• streams/reference-implementation/pipe-to-options-expected.txt: Removed.
• streams/reference-implementation/pipe-to-options.html: Removed.
• streams/reference-implementation/readable-stream-templated-expected:

9:59 AM Changeset in webkit [266128] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] inspector/console/queryInstances.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215814

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:44 AM Changeset in webkit [266127] by commit-queue@webkit.org

• 4 edits in trunk

Add setting for lazy iframe loading
​https://bugs.webkit.org/show_bug.cgi?id=215566

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Youenn Fablet.

Source/WebCore:

Add setting for lazy iframe loading, disabling it until
this feature is implemented.

• page/Settings.yaml:

LayoutTests:

Enable the lazy iframe loading setting in testharnessreport.js for the iframe lazy
loading WPT tests in html/semantics/embedded-content/the-iframe-element.

• resources/testharnessreport.js:

9:43 AM Changeset in webkit [266126] by Hector Lopez

• 2 edits in trunk/LayoutTests

macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.

<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

9:39 AM Changeset in webkit [266125] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[LFC][IFC] The initial alignment baseline is always set by the strut
​https://bugs.webkit.org/show_bug.cgi?id=214785

Reviewed by Antti Koivisto.

Let's just use the strut ascent as the initial alignment baseline.

• layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::root const):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):
(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::root const):

• layout/inlineformatting/InlineLineBuilder.h:

9:36 AM Changeset in webkit [266124] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: corrected to skip

9:32 AM Changeset in webkit [266123] by Darin Adler

• 12 edits in trunk

REGRESSION (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Reviewed by Anders Carlsson.

Source/WebCore:

• dom/Range.cpp:

(WebCore::Range::getClientRects const): Call updateLayout since it's not safe
to start working with the render tree without updating it first. Not required
to fix this bug, but an obvious omission. Ideally should make a test to show
this is needed.
(WebCore::Range::getBoundingClientRect const): Ditto.

• dom/SimpleRange.cpp:

(WebCore::order): Added.
(WebCore::documentOrder): Removed bogus special case. Test case proving this is
wrong is coming in the next documentOrder-related patch. Not needed to fix this
bug, but seems dangerous to leave this in the tree the way it was.
(WebCore::firstIntersectingNodeWithDeprecatedZeroOffsetStartQuirk): Added.
(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Added.

• dom/SimpleRange.h: Added intersectingNodesWithDeprecatedZeroOffsetStartQuirk.

• rendering/RenderObject.cpp:

(WebCore::borderAndTextRects): Use intersectingNodesWithDeprecatedZeroOffsetStartQuirk
because this needs to get the set of nodes in a way that works for our incorrectly
formed selection ranges and includes the first element even when the range technically
starts inside that element. We need to fix those, but that's a big project that affects
a lot of editing code. For now, restoring the old quirk is expedient.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.

LayoutTests:

• platform/ios-wk2/TestExpectations: Removed failure expectation.

• platform/ios/ios/fast/coordinates/element-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/element-client-rects.html:
• platform/ios/ios/fast/coordinates/range-client-rects-expected.txt:
• platform/ios/ios/fast/coordinates/range-client-rects.html:

Changed tests so it's easier to read their results by putting rectangles and
rectangle lists into strings instead of comparing one value per line.

• platform/ios/ios/fast/coordinates/resources/helpers.js:

(rectString): Added.
(rectStrings): Added.
(setExpectedClientRectValues): Deleted.
(verifyClientRect): Deleted.

9:30 AM Changeset in webkit [266122] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] http/tests/websocket/construct-in-detached-frame.html is a flaky crash
<rdar://problem/61278051>

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:15 AM Changeset in webkit [266121] by eric.carlson@apple.com

• 17 edits in trunk

[macOS] Update audio arbitration manager when audio transport changes
​https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated AudioRoutingArbitration API test.

• platform/audio/AudioSession.cpp:

(WebCore::AudioSession::audioOutputDeviceChanged): Add empty method.
(WebCore::setIsPlayingToBluetoothOverride): Ditto.

• platform/audio/AudioSession.h:

• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::defaultDeviceTransportIsBluetooth): New.
(WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth
if bluetooth transport has changed since the last arbitration update.
(WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth
transport for testing.
(WebCore::AudioSession::setCategory): Update routing arbitration if audio session category
or bluetooth transport changes.

• testing/Internals.cpp:

(WebCore::Internals::setIsPlayingToBluetoothOverride):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _audioRoutingArbitrationUpdateTime]):

• UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:

(WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):

• UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:

(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm:

(AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help
debugging when the test fails.

• TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:

9:08 AM Changeset in webkit [266120] by youenn@apple.com

• 4 edits
  7 adds in trunk

Generated bindings for derived dictionaries are not regenerated when the base dictionary changes
​https://bugs.webkit.org/show_bug.cgi?id=181714

Reviewed by Darin Adler.

Source/WebCore:

Add dictionary file dependencies to SupplementalDependencies.dep.
We add the base dictionary IDL file as a dependency to the JS cpp file of the derived dictionary.
We do so if we detect that a dictionary is deriving from another and both dictionaries are in their own IDL file.

Covered by updated binding tests.

• bindings/scripts/preprocess-idls.pl:

(updateDictionaryDependencies):

• bindings/scripts/test/SupplementalDependencies.dep: Added.
• bindings/scripts/test/TestDerivedDictionary2.idl: Added.
• bindings/scripts/test/TestInheritedDictionary2.idl: Added.
• bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestDerivedDictionary2>):
(WebCore::convertDictionaryToJS):
(WebCore::convertDictionary<TestDerivedDictionary2::Dictionary>):

• bindings/scripts/test/JS/JSTestDerivedDictionary2.h: Added.
• bindings/scripts/test/JS/JSTestInheritedDictionary2.cpp: Added.

(WebCore::convertDictionary<TestInheritedDictionary2>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestInheritedDictionary2.h: Added.

Tools:

Add regression testing coverage for the generation of the makefile dependency file.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):
(BindingsTests):
(BindingsTests.detect_file_changes):
(BindingsTests.main):

9:06 AM Changeset in webkit [266119] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS Debug ] webaudio/webaudio-gc.html is a flaky crash.
<rdar://problem/65571152>

Unreviewed test gardening.

• platform/mac/TestExpectations:

9:03 AM Changeset in webkit [266118] by mmaxfield@apple.com

• 5 edits
  6 adds in trunk

Fonts lie about being monospaced
​https://bugs.webkit.org/show_bug.cgi?id=162546
<rdar://problem/28494654>

Reviewed by Darin Adler.

Source/WebCore:

When a font reports itself to be monospace, we use this as a
signal that we can perform width computations by assuming all
characters have the same width as the space character. However,
some fonts erroneously claim to be monospaced. We can't know
this ahead of time without measuring a bunch of characters at
font load time, which would be too slow, so even though the
optimization would be nice there is no practical way to do it
correctly. Firefox and Chrome both do not use this signal, so
therefore they both correctly render these fonts. We should
ignore this bit in the font as well. Also, CJK fonts generally
do not have this bit set (because they usually have at least
one character which is not fullwidth) so this isn't a concern
there.

Our Page Load Test shows this is not a performance regression.

Tests: fast/text/font-erroneous-monospace.html

fast/text/font-monospaced-lie.html

• rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache const):

LayoutTests:

Add two tests for fonts which claim to be monospaced but actually aren't.

• fast/text/font-erroneous-monospace-expected.html: Added.
• fast/text/font-erroneous-monospace.html: Added.
• fast/text/font-monospaced-lie-expected.txt: Added.
• fast/text/font-monospaced-lie.html: Added.
• fast/text/line-break-after-question-mark-expected.txt:
• fast/text/line-break-after-question-mark.html:
• fast/text/resources/Ahem-fixed-pitch.ttf: Added.
• fast/text/resources/AhemErroneousMonospace.ttf: Added.

8:58 AM Changeset in webkit [266117] by Alexey Shvayka

• 8 edits in trunk

Invalid early error for object literal method named "proto"
​https://bugs.webkit.org/show_bug.cgi?id=215760

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

According to Annex B [1], { __proto__: null, __proto__() {} } is a valid object literal as the second
__proto__ wasn't obtained from PropertyDefinition : PropertyName : AssignmentExpression production.
Currently, JSC throws an early SyntaxError, unlike V8 and SpiderMonkey.

Since a method needs super binding, the most straightforward fix would be adding SuperBinding field
to SyntaxChecker::Property and exposing it via an accessor. However, given that Property is a very
common structure, this approach would noticeably increase memory pressure during parsing.

Instead, this patch reworks SyntaxChecker::Property to accept isUnderscoreProtoSetter parameter,
removing optional name field, its accessor, and shouldCheckPropertyForUnderscoreProtoDuplicate(),
which reduces sizeof(SyntaxChecker::Property) by a factor of 8: from 16 to 2 bytes.
Also, this change avoids two extra makeNumericIdentifier() calls, speeding up numeric keys parsing.

This approach is feasible because "proto" is the only identifier-based early error for object
literals [2], with no such errors being added in upcoming stage 2-4 proposals.

Additionally, this patch removes strict / complete bool parameter from {parse,create}Property()
signatures as a) it was always true, b) is now unused, and c) strict mode can be checked via scope.

[1]: ​https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers
[2]: ​https://tc39.es/ecma262/#sec-object-initializer-static-semantics-early-errors

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::isUnderscoreProtoSetter const):
(JSC::ASTBuilder::getName const): Deleted.

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::shouldCheckPropertyForUnderscoreProtoDuplicate): Deleted.

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::Property::operator!):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::operatorStackPop):

8:48 AM Changeset in webkit [266116] by youenn@apple.com

• 28 edits
  5 adds in trunk

Add support for MediaRecorder bitrate options
​https://bugs.webkit.org/show_bug.cgi?id=214973

Reviewed by Eric Carlson.

Source/WebCore:

Pipe options to MediaRecorderPrivate constructor.
For the actual implementation, pass it down to VideoSampleBufferCompressor and AudioSampleBufferCompressor.
For AudioSampleBufferCompressor, we do not handle well some bit rates, so for now, we limit to specific values.

Tests: http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html

http/wpt/mediarecorder/MediaRecorder-video-bitrate.html

• Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::create):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::startRecording):

• Modules/mediarecorder/MediaRecorder.h:
• Modules/mediarecorder/MediaRecorderProvider.cpp:

(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):

• Modules/mediarecorder/MediaRecorderProvider.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:
• platform/mediarecorder/MediaRecorderPrivate.h:
• platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::create):

• platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:

(WebCore::AudioSampleBufferCompressor::setBitsPerSecond):
(WebCore::AudioSampleBufferCompressor::outputBitRate const):
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
Do not exit when not able to set bitrate as we still want to set m_maxOutputPacketSize.
In case of error in setting up the converter, clean it up so that we do not use a partially set up converter.

• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
• platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::create):
(WebCore::MediaRecorderPrivateWriter::setOptions):

• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.h:
• platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::setBitsPerSecond):
(WebCore::setCompressionSessionProperty):
(WebCore::VideoSampleBufferCompressor::initCompressionSession):

• testing/Internals.cpp:

(WebCore::createRecorderMockSource):

Source/WebKit:

Serialize options when creating remote media recorder.

• GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::create):

• GPUProcess/webrtc/RemoteMediaRecorder.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.cpp:

(WebKit::RemoteMediaRecorderManager::createRecorder):

• GPUProcess/webrtc/RemoteMediaRecorderManager.h:
• GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
• WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:

(WebKit::MediaRecorderPrivate::MediaRecorderPrivate):
(WebKit::MediaRecorderPrivate::startRecording):

• WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
• WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:

(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

• WebProcess/GPU/webrtc/MediaRecorderProvider.h:

LayoutTests:

• http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate-expected.txt: Added.
• http/wpt/mediarecorder/MediaRecorder-video-bitrate.html: Added.

8:46 AM Changeset in webkit [266115] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/W3C/video/events/event_order_canplay_canplaythrough.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215809

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:29 AM Changeset in webkit [266114] by commit-queue@webkit.org

• 25 edits in trunk/Source/WebCore

Use more enum classes in DateComponents
​https://bugs.webkit.org/show_bug.cgi?id=215544

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-25
Reviewed by Sam Weinig.

Make Type and SecondFormat enum classes since this is more readable
and allows us to have less includes in header files.

• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serializeWithComponents const):

• html/DateInputType.cpp:

(WebCore::DateInputType::dateType const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::dateType const):

• html/DateTimeLocalInputType.h:
• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dateType const):

• html/HTMLInputElement.h:
• html/InputType.cpp:

(WebCore::InputType::dateType const):

• html/InputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::dateType const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::dateType const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::dateType const):

• html/WeekInputType.h:
• platform/DateComponents.cpp:

(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::DateComponents::millisecondsSinceEpochForTime const):
(WebCore::DateComponents::millisecondsSinceEpoch const):
(WebCore::DateComponents::monthsSinceEpoch const):
(WebCore::DateComponents::toStringForTime const):
(WebCore::DateComponents::toString const):

• platform/DateComponents.h:

(WebCore::DateComponents::DateComponents):
(WebCore::DateComponents::type const):

• platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime):

• platform/text/PlatformLocale.h:
• platform/text/cocoa/LocaleCocoa.mm:

(WebCore::LocaleCocoa::formatDateTime):

• platform/text/ios/LocalizedDateCache.h:
• platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::formatterForDateType):
(WebCore::LocalizedDateCache::maximumWidthForDateType):
(WebCore::LocalizedDateCache::createFormatterForType):
(WebCore::LocalizedDateCache::calculateMaximumWidth):

8:29 AM Changeset in webkit [266113] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Debug ] media/controls/forced-tracks-only.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215808

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:07 AM Changeset in webkit [266112] by commit-queue@webkit.org

• 8 edits in trunk/Source

[SOUP] Initialize HSTS storage directory from network session initialization
​https://bugs.webkit.org/show_bug.cgi?id=215802

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2020-08-25
Reviewed by Alex Christensen.

Source/WebCore:

Stop handling HSTS persistent storage as a global setting. SoupNetworkSession::setHSTSPersistentStorage() is no
longer static and it does what setupHSTSEnforcer() did but simplified. The session is now always created with a
memory enforcer that is only replaced by a persistent one when setHSTSPersistentStorage() is called on
non-ephemeral sessions.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setHSTSPersistentStorage):
(WebCore::SoupNetworkSession::getHostNamesWithHSTSCache):
(WebCore::SoupNetworkSession::deleteHSTSCacheForHostNames):
(WebCore::SoupNetworkSession::clearHSTSCache):
(WebCore::hstsStorageDirectory): Deleted.
(WebCore::SoupNetworkSession::setupHSTSEnforcer): Deleted.

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Instead of network process initialization, since it's not actually a global setting.

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Remove code to initialize HSTS storage.

• NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup): Call SoupNetworkSession::setHSTSPersistentStorage() if the
path is not mpety.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed): Remove the ode to set the HSTS storage directory as process pool configuration.

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess): Initialize hstsStorageDirectory in default network session parameters.

7:35 AM Changeset in webkit [266111] by Philippe Normand

• 2 edits in trunk/Source/WebCore

Unreviewed, follow-up to r266109

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio): The element clock can be null so we need
to check it before attempting to use it.

1:46 AM Changeset in webkit [266110] by Paulo Matos

• 3 edits in trunk/JSTests

Skip failing tests on MIPS for later investigation

Unreviewed Gardening.

• stress/intl-segmenter.js:
• stress/typedarray-functions-with-neutered.js:

1:13 AM Changeset in webkit [266109] by Philippe Normand

• 4 edits in trunk/Source/WebCore

[GStreamer][WebAudio] Fill in output timestamps
​https://bugs.webkit.org/show_bug.cgi?id=215703

Reviewed by Xabier Rodriguez-Calvar.

Set the output timestamp as the buffer PTS. The monotonic timestamp is retrieved using the
corresponding GLib API, offset'ed by the pipeline clock time (which always starts at 0).

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcAllocateBuffersAndRenderAudio):

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstClock>):
(WTF::derefGPtr<GstClock>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

1:11 AM Changeset in webkit [266108] by Diego Pino Garcia

• 3 edits
  1 copy
  5 deletes in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Updated hybi baselines after r266057.

• platform/glib/http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Renamed from LayoutTests/platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-expected.txt.
• platform/glib/http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
• platform/glib/http/tests/websocket/tests/hybi/extensions-expected.txt:
• platform/gtk/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.
• platform/gtk/http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-expected.txt: Removed.
• platform/wpe/http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt: Removed.

1:06 AM Changeset in webkit [266107] by ysuzuki@apple.com

• 13 edits
  1 add in trunk/Source/JavaScriptCore

[JSC] Add concurrency-aware version of isCallable / isConstructor to make it usable in DFG compiler
​https://bugs.webkit.org/show_bug.cgi?id=215746

Reviewed by Saam Barati.

This patch adds isCallableWithConcurrency and isConstructorWithConcurrency to JSCell, JSValue etc.
This can work even if it is called from concurrent compiler threads. We also add jsTypeStringForValueWithConcurrency
and jsTypeofIsFunctionWithConcurrency which are using the above WithConcurrency functionalities.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• runtime/Concurrency.h: Added.

(WTF::printInternal):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
(JSC::InternalFunction::getConstructData):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:

(JSC::JSValue::isCallableWithConcurrency const):
(JSC::JSValue::isConstructorWithConcurrency const):

• runtime/JSCell.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::isCallableWithConcurrency):
(JSC::JSCell::isConstructorWithConcurrency):
(JSC::JSCell::isCallable):
(JSC::JSCell::isConstructor):

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getConstructData):

• runtime/NumberPrototype.cpp:

(JSC::throwVMToThisNumberError):

• runtime/Operations.cpp:

(JSC::jsTypeStringForValueWithConcurrency):
(JSC::jsTypeStringForValue): Deleted.

• runtime/Operations.h:

(JSC::jsTypeofIsFunctionWithConcurrency):
(JSC::jsTypeStringForValue):
(JSC::jsTypeofIsFunction):

12:45 AM Changeset in webkit [266106] by Alexey Shvayka

• 13 edits
  1 add in trunk

Implementation of the class "extends" clause incorrectly uses proto for setting prototypes
​https://bugs.webkit.org/show_bug.cgi?id=205848

Reviewed by Keith Miller.

JSTests:

• microbenchmarks/class-derived-creation.js: Added.
• test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

To prevent class extends from breaking if Object.prototype.proto is overridden
or removed, this patch replaces OpPutById bytecodes in ClassExprNode::emitBytecode()
with JSObject::setPrototypeDirect() invocations via OpCall.

Since the spec sets Prototype? values directly [1], we are safe to skip method
table lookups and cycle checks.

Although this approach adds 4 mov ops to emitted bytecode for class extends creation,
increasing instruction count to 35, I prefer it over introducing a slow path only op.
To avoid emitting 2 extra mov ops, globalFuncSetPrototypeDirect() uses thisRegister().

Aligns JSC with V8 and SpiderMonkey. Derived class creation microbenchmark is neutral.

[1]: ​https://tc39.es/ecma262/#sec-createbuiltinfunction (step 7)

• builtins/BuiltinNames.h:
• bytecode/BytecodeDumper.cpp:

(JSC::CodeBlockBytecodeDumper<Block>::dumpConstants): Fix typo.

• bytecode/LinkTimeConstant.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitSetPrototypeOf):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

• parser/Nodes.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

12:42 AM Changeset in webkit [266105] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK/WPE build after r266103

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

12:01 AM Changeset in webkit [266104] by Diego Pino Garcia

• 3 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Reintroduce several WPT css-content failing tests removed in r266094.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:

Aug 24, 2020:

11:15 PM Changeset in webkit [266103] by Carlos Garcia Campos

• 6 edits in trunk/Source

[GTK] Implement rendering frames timeline panel for GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=150392
<rdar://problem/23200510>

Reviewed by Brian Burg.

Source/WebCore:

Use new RunLoop API to observe the run loop events when the GLib event loop is used.

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):

• inspector/agents/InspectorTimelineAgent.h:

Source/WTF:

Add API to observe RunLoop events for GLib event loop implementation.

• wtf/RunLoop.h:
• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop): Use RunLoopSource struct and initialize the RunLoop.
(WTF::RunLoop::observe): Add the given observer to the set.
(WTF::RunLoop::notify): Notife observers of the given event.
(WTF::RunLoop::TimerBase::TimerBase): Use RunLoopSource struct and initialize the RunLoop.

10:04 PM Changeset in webkit [266102] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix TLSVersion.DefaultBehavior on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=215791

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave.
Enable it for newer OSes.

9:32 PM Changeset in webkit [266101] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG should always run CFG Simplification after Constant Folding.
​https://bugs.webkit.org/show_bug.cgi?id=215286

Reviewed by Robin Morisset.

We didn't do this originally because LICM, many years ago, was
unsound if the CFG didn't have exactly the right shape around
loops. This is no longer true so we don't have to worry about
changing the CFG anymore. While, this doesn't appear to be a
speedup on JetStream 2 CFG, probably because we'd eventually
simplify the graph in B3, CFG Simplification is very cheap and
make other DFG optimizations easier in the future.

Also, remove unecessary validation rule that no exitOKs can come
before any Phi nodes in DFG. This isn't required and fails after
merging two basic blocks where the latter block has a Phi.

• dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGValidate.cpp:

8:36 PM Changeset in webkit [266100] by commit-queue@webkit.org

• 4 edits in trunk/Tools

Make TLSVersion.DefaultBehavior more robust
​https://bugs.webkit.org/show_bug.cgi?id=215791

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
(TestWebKitAPI::HTTPServer::respondWithOK):

7:44 PM Changeset in webkit [266099] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called,

instead of when deciding to dispatch to the main thread.

(WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch

to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread.

(WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when
(WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is

safe to do after destroy(), up until the very end when we get into pluginView() derefencing.
So it seems prudent to add another check here.

(WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and

adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument,
so for added coverage it seems like a prudent place to add the check.

7:03 PM Changeset in webkit [266098] by achristensen@apple.com

• 2 edits in trunk/LayoutTests/imported/w3c

Update iOS layout test results after r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt:

Apparently there's a newly passing test here, too.
I wonder why macOS isn't affected by this change.

7:00 PM Changeset in webkit [266097] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.

6:53 PM Changeset in webkit [266096] by mmaxfield@apple.com

• 1 edit in trunk/LayoutTests/ChangeLog

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing
<rdar://problem/66861801>

Unreviewed test gardening.

• platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords.

6:51 PM Changeset in webkit [266095] by keith_miller@apple.com

• 22 edits
  2 deletes in trunk/Source/JavaScriptCore

Remove MovHintRemoval phase
​https://bugs.webkit.org/show_bug.cgi?id=215785

Reviewed by Saam Barati.

The MovHintRemoval phase doesn't play nicely with our OSR
Availability. Specifically, it needs to do a tricky dance where it
marks all the live ranges of the ZombieHints as not
exitOK. There's also an issue because we treated unused locals as
kill in this block, which is wrong for SSA when a MovHint is
used in another block. Since removing MovHintRemoval isn't a
performance regression, we are removing it rather than fixing bugs
related to it. Relatedly, since the only place we produce
ZombieHints is MovHintRemoval this patch also removes that node
type.

• Sources.txt:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGMayExit.cpp:
• dfg/DFGMovHintRemovalPhase.cpp: Removed.
• dfg/DFGMovHintRemovalPhase.h: Removed.
• dfg/DFGNode.h:

(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::hasUnlinkedOperand):

• dfg/DFGNodeType.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

• dfg/DFGPhantomInsertionPhase.cpp:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGVarargsForwardingPhase.cpp:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):

• runtime/OptionsList.h:

5:36 PM Changeset in webkit [266094] by Hector Lopez

• 5 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• TestExpectations:
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

5:26 PM Changeset in webkit [266093] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.3

5:14 PM Changeset in webkit [266092] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure)

Unreviewed test gardening.

• platform/ios-13/TestExpectations:

5:05 PM Changeset in webkit [266091] by keith_miller@apple.com

• 5 edits
  11 adds in trunk/JSTests

Update test262 (mid Aug 2020 edition)
​https://bugs.webkit.org/show_bug.cgi?id=215784

Rubber-stamped by Saam Barati and Yusuke Suzuki.

• test262/expectations.yaml:
• test262/latest-changes-summary.txt:
• test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):
(nonNumberableLimit.Symbol.toPrimitive):

• test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableSeparator.toString):

• test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js:
• test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added.

(ExpectedError):
(ExpectedError.prototype.toString):
(nonStringableReceiver.toString):
(splitter.Symbol.split):
(catch):
(nonStringableSeparator.Symbol.toPrimitive):
(nonStringableSeparator.toString):
(nonStringableSeparator.valueOf):

• test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js: Added.

(A):
(export.default.async A):

• test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js: Added.

(export.default.async A):

• test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js: Added.

(AG):
(export.default.async AG):

• test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js: Added.

(export.default.async AG):

• test262/test/language/module-code/export-default-function-declaration-binding-exists.js: Added.

(F):
(export.default.F):

• test262/test/language/module-code/export-default-function-declaration-binding.js: Added.

(export.default.F):

• test262/test/language/module-code/export-default-generator-declaration-binding-exists.js: Added.

(G):
(export.default.G):

• test262/test/language/module-code/export-default-generator-declaration-binding.js: Added.

(export.default.G):

• test262/test262-Revision.txt:

3:48 PM Changeset in webkit [266090] by Wenson Hsieh

• 4 edits in trunk

Unreviewed, fix the internal iOS 13.4 build

Source/WebKit:

The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a
problem when building with a non-internal SDK since the SPI is declared in the !USE(APPLE_INTERNAL_SDK)
section in UIKitSPI.h, but on internal builds of iOS 13.4, this declaration is absent from both the internal
SDK and UIKitSPI.h.

To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target,
this can be moved back into the non-internal section only.

• Platform/spi/ios/UIKitSPI.h:

Tools:

See Source/WebKit/ChangeLog.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::clipSelectionViewRectToContentView):

3:46 PM Changeset in webkit [266089] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews] enable email notifications to patch authors for build or layout test failures on their patch
​https://bugs.webkit.org/show_bug.cgi?id=215776

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch.
(AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure.

3:45 PM Changeset in webkit [266088] by aakash_jain@apple.com

• 3 edits in trunk/Tools

[ews] set references header in email so as to group similar emails together
​https://bugs.webkit.org/show_bug.cgi?id=215777

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/send_email.py:

(send_email): Add support for setting references header.
(send_email_to_patch_author):
(send_email_to_bot_watchers):

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Set references header appropriately.
(ReRunWebKitTests.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

3:36 PM Changeset in webkit [266087] by commit-queue@webkit.org

• 34 edits in trunk

Implement Request/Response consuming as FormData
​https://bugs.webkit.org/show_bug.cgi?id=215671

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/abort/general.any-expected.txt:
• web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:

This remaining failing test now fails similarly in all browsers.

• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt:

This change makes the formData failures in this file look like all the other failures in this file,
which should be fixed together in a separate patch.

• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/url/urlencoded-parser.any-expected.txt:
• web-platform-tests/url/urlencoded-parser.any.worker-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt:

Source/WebCore:

Covered by many newly passing WPT tests, for most of which Safari was the only failing browser.

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::formData):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeFormData):

• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::formDataFromData):
(WebCore::resolveWithTypeAndData):
(WebCore::FetchBodyConsumer::resolve):

• Modules/fetch/FetchBodyConsumer.h:

Source/WebKit:

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish):
Add a fast path that allows non-blob FormData responses from service workers to not hang.
This part is covered by this layout test:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html

Source/WTF:

In order to be compatible with other browsers, we need a verson of String::fromUTF8 that
uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things.
Leave everything else as it is, use templates and constexpr to not add any branches, but add
String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers.

• wtf/text/WTFString.cpp:

(WTF::fromUTF8Helper):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8ReplacingInvalidSequences):

• wtf/text/WTFString.h:
• wtf/unicode/UTF8Conversion.cpp:

(WTF::Unicode::convertUTF8ToUTF16Impl):
(WTF::Unicode::convertUTF8ToUTF16):
(WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences):

• wtf/unicode/UTF8Conversion.h:

2:41 PM Changeset in webkit [266086] by commit-queue@webkit.org

• 24 edits in trunk/Source

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
​https://bugs.webkit.org/show_bug.cgi?id=213048

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Youenn Fablet.

Source/WebCore/PAL:

• pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession.
To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and
WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838.

I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS
state querying and removal works with the new CFNetwork SPI as it did with the old one.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

• NetworkProcess/NetworkSessionCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::hstsStorage const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::hostNamesWithHSTSCache const):
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames):
(WebKit::NetworkProcess::clearHSTSCache):
(WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted.

• UIProcess/API/C/mac/WKContextPrivateMac.h:
• UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):

• UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
• UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:

(-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]):
(-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession): Deleted.
(WebKit::WebProcessPool::resetHSTSHosts): Deleted.
(WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted.

• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:

(WebKit::WebsiteDataStoreConfiguration::copy const):

• UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:

Source/WTF:

• wtf/PlatformHave.h:

2:35 PM Changeset in webkit [266085] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215783

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

2:06 PM Changeset in webkit [266084] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Disable unused RPC services
​https://bugs.webkit.org/show_bug.cgi?id=215779

Reviewed by Alexey Proskuryakov.

• .htaccess:

12:26 PM Changeset in webkit [266083] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=215778

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:17 PM Changeset in webkit [266082] by emilio

• 12 edits in trunk

Support quotes:auto and fix quotes serialization.
​https://bugs.webkit.org/show_bug.cgi?id=215646

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-content/inheritance-expected.txt: Annotate progression.
• web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-content/inheritance.html

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::Ref<CSSValue>valueForQuotes):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeQuotes):

• rendering/style/QuotesData.h:

(WebCore::QuotesData::size const):

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertQuotes):

LayoutTests:

• platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Annotate progression.
• platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Ditto.

11:57 AM Changeset in webkit [266081] by Russell Epstein

• 8 edits in trunk/Source

Versioning.

WebKit-7611.1.1

11:53 AM Changeset in webkit [266080] by Jonathan Bedard

• 4 edits in trunk/Tools

[resultsdbpy] Fix pip package
​https://bugs.webkit.org/show_bug.cgi?id=215721
<rdar://problem/67518275>

Reviewed by Dewei Zhu.

• Scripts/libraries/resultsdbpy/MANIFEST.in: Add html and css.
• Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Include submodules.
• Scripts/libraries/resultsdbpy/setup.py: Version bump.

11:44 AM Changeset in webkit [266079] by Russell Epstein

• 1 copy in branches/safari-610-branch

New branch.

11:44 AM Changeset in webkit [266078] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 Release ] http/tests/workers/service/basic-install-event-waitUntil-reject.html is a flaky timeout

​https://bugs.webkit.org/show_bug.cgi?id=214997

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

11:40 AM Changeset in webkit [266077] by Devin Rousso

• 27 edits
  7 moves in trunk/Source

Web Inspector: rename ScriptDebugServer subclasses/methods
​https://bugs.webkit.org/show_bug.cgi?id=215363
<rdar://problem/67310441>

Reviewed by Brian Burg.

r266074 merged Inspector::ScriptDebugServer into JSC::Debugger. All subclasses and
functions should be renamed to match this change.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• inspector/InspectorEnvironment.h:
• inspector/JSGlobalObjectDebugger.h: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.h.
• inspector/JSGlobalObjectDebugger.cpp: Renamed from Source/JavaScriptCore/inspector/JSGlobalObjectScriptDebugServer.cpp.
• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:
• inspector/agents/InspectorAuditAgent.h:
• inspector/agents/InspectorAuditAgent.cpp:
• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:
• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:
• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
• inspector/remote/RemoteInspectionTarget.cpp:
• inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

Source/WebCore:

• Headers.cmake:
• Sources.txt:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorController.h:
• inspector/InspectorController.cpp:
• inspector/PageDebugger.h: Renamed from Source/WebCore/inspector/PageScriptDebugServer.h.
• inspector/PageDebugger.cpp: Renamed from Source/WebCore/inspector/PageScriptDebugServer.cpp.
• inspector/mac/PageDebuggerMac.mm: Renamed from Source/WebCore/inspector/mac/PageScriptDebugServerMac.mm.
• inspector/WorkerDebugger.h: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.h.
• inspector/WorkerDebugger.cpp: Renamed from Source/WebCore/inspector/WorkerScriptDebugServer.cpp.
• inspector/WorkerInspectorController.h:
• inspector/WorkerInspectorController.cpp:
• inspector/agents/InspectorTimelineAgent.cpp:
• inspector/agents/page/PageDebuggerAgent.cpp:

11:13 AM Changeset in webkit [266076] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Resources Tab and Debugger Tab with the Sources Tab
​https://bugs.webkit.org/show_bug.cgi?id=205826

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WI.loaded):

11:06 AM Changeset in webkit [266075] by sihui_liu@apple.com

• 4 edits in trunk

Source/WebCore:
Text manipulation should not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

TextManipulationController currently does not set correct start path for insertion. Therefore, it does not mark
the nodes on the start path but out of range correctly, and may change position of those nodes by mistake. For
example, in the newly added test, text node "zero" can be moved around even though it is not in range.

API test: TextManipulation.CompleteTextManipulationShouldOnlyChangeNodesInParagraphRange

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace):

Tools:
Text manipulationshould not manipulate nodes out of paragraph range
​https://bugs.webkit.org/show_bug.cgi?id=215406

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

10:34 AM Changeset in webkit [266074] by Devin Rousso

• 107 edits
  1 copy
  3 adds
  4 deletes in trunk

Web Inspector: allow event breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215362
<rdar://problem/66932921>

Reviewed by Brian Burg.

Source/JavaScriptCore:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

• inspector/protocol/DOM.json:

Add an options paramater to DOM.setBreakpointForEventListener to allow configuration.

• inspector/protocol/DOMDebugger.json:

Add an options paramater to DOMDebugger.setEventBreakpoint to allow configuration.

• debugger/Breakpoint.h:

(JSC::Breakpoint::id const): Added.
(JSC::Breakpoint::sourceID const): Added.
(JSC::Breakpoint::lineNumber const): Added.
(JSC::Breakpoint::columnNumber const): Added.
(JSC::Breakpoint::condition const): Added.
(JSC::Breakpoint::actions const): Added.
(JSC::Breakpoint::isAutoContinue const): Added.
(JSC::Breakpoint::resetHitCount): Added.
(JSC::Breakpoint::isLinked const): Added.
(JSC::Breakpoint::isResolved const): Added.
(JSC::BreakpointsList::~BreakpointsList): Deleted.

• debugger/Breakpoint.cpp: Added.

(JSC::Breakpoint::Action::Action): Added.
(JSC::Breakpoint::create): Added.
(JSC::Breakpoint::Breakpoint): Added.
(JSC::Breakpoint::link): Added.
(JSC::Breakpoint::resolve): Added.
(JSC::Breakpoint::shouldPause): Added.
Unify JSC::Breakpoint and Inspector::ScriptBreakpoint.

• debugger/DebuggerPrimitives.h:
• debugger/Debugger.h:
• debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::addObserver): Added.
(JSC::Debugger::removeObserver): Added.
(JSC::Debugger::canDispatchFunctionToObservers const): Added.
(JSC::Debugger::dispatchFunctionToObservers): Added.
(JSC::Debugger::sourceParsed): Added.
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::applyBreakpoints):
(JSC::Debugger::resolveBreakpoint):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::didHitBreakpoint): Added.
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::evaluateBreakpointCondition): Added.
(JSC::Debugger::evaluateBreakpointActions): Added.
(JSC::Debugger::schedulePauseAtNextOpportunity): Added.
(JSC::Debugger::cancelPauseAtNextOpportunity): Added.
(JSC::Debugger::schedulePauseForSpecialBreakpoint): Added.
(JSC::Debugger::cancelPauseForSpecialBreakpoint): Added.
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepNextExpression):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::handlePause): Added.
(JSC::Debugger::exceptionOrCaughtValue): Added.
(JSC::Debugger::atExpression):
(JSC::Debugger::clearNextPauseState):
(JSC::Debugger::willRunMicrotask): Added.
(JSC::Debugger::didRunMicrotask): Added.
(JSC::Debugger::hasBreakpoint): Deleted.
(JSC::Debugger::setPauseOnNextStatement): Deleted.
Unify JSC::Debugger and Inspector::ScriptDebugServer to simplify breakpoint logic.
Introduce the concept of a "special breakpoint", which is essentially a JSC::Breakpoint
that is expected to pause at the next opportunity but isn't tied to a particular location.
As an example, whenever an event breakpoint is hit, instead of just pausing at the next
opportunity, the newly managed JSC::Breakpoint is used as a "special breakpoint", allowing
for it's configuration (ie.g. condition, ignore count, actions, auto-continue) to be used.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::objectGroupForBreakpointAction):
(Inspector::breakpointActionTypeForString): Added.
(Inspector::parseBreakpointOptions): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::fromPayload): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::ProtocolBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::createDebuggerBreakpoint const): Added.
(Inspector::InspectorDebuggerAgent::ProtocolBreakpoint::matchesScriptURL const): Added.
(Inspector::InspectorDebuggerAgent::debuggerBreakpointFromPayload): Added.
(Inspector::InspectorDebuggerAgent::enable):
(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::buildDebuggerLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::didSetBreakpoint):
(Inspector::InspectorDebuggerAgent::resolveBreakpoint):
(Inspector::InspectorDebuggerAgent::removeBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseAtNextOpportunity): Added.
(Inspector::InspectorDebuggerAgent::schedulePauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::cancelPauseForSpecialBreakpoint): Added.
(Inspector::InspectorDebuggerAgent::pause):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::didBecomeIdle):
(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionSound):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):
(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::matches): Deleted.
(Inspector::buildObjectForBreakpointCookie): Deleted.
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol): Deleted.
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement): Deleted.
(Inspector::InspectorDebuggerAgent::cancelPauseOnNextStatement): Deleted.
Create a private ProtocolBreakpoint class that holds the data sent by the frontend. This
is necessary because breakpoints in the frontend have a potentially one-to-many relationship
with breakpoints in the backend, as the same script can be loaded many times on a page. Each
of those scripts is independent, however, and can execute differently, meaning that the same
breakpoint for each script also needs a different state (e.g. ignore count). As such, the
ProtocolBreakpoint is effectively a template that is actualized whenever a new script is
parsed that matches the URL of the ProtocolBreakpoint to create a JSC::Breakpoint that
is used by the JSC::Debugger. ProtocolBreakpoint also parses breakpoint configurations.

• inspector/InspectorEnvironment.h:
• inspector/JSGlobalObjectScriptDebugServer.h:
• inspector/JSGlobalObjectScriptDebugServer.cpp:

(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::attachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::detachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):

• inspector/agents/InspectorAuditAgent.h:
• inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::setPauseOnExceptionsState):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):

• inspector/agents/InspectorScriptProfilerAgent.cpp:
• inspector/agents/JSGlobalObjectDebuggerAgent.h:

Replace Inspector::ScriptDebugServer with JSC::Debugger.

• runtime/JSMicrotask.cpp:

(JSC::JSMicrotask::run):
Drive-by: r248894 mistakenly omitted the call to notify the debugger that the microtask ran.

• inspector/ScriptBreakpoint.h: Removed.
• inspector/ScriptDebugListener.h: Removed.
• inspector/ScriptDebugServer.h: Removed.
• inspector/ScriptDebugServer.cpp: Removed.
• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:

Source/WebCore:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

Tests: inspector/dom/breakpoint-for-event-listener.html

inspector/dom-debugger/event-animation-frame-breakpoints.html
inspector/dom-debugger/event-interval-breakpoints.html
inspector/dom-debugger/event-listener-breakpoints.html
inspector/dom-debugger/event-timeout-breakpoints.html

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setBreakpointForEventListener):
(WebCore::InspectorDOMAgent::removeBreakpointForEventListener):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::breakpointForEventListener):
(WebCore::InspectorDOMAgent::hasBreakpointForEventListener): Deleted.

• inspector/agents/InspectorDOMDebuggerAgent.h:
• inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::mainFrameNavigated):
(WebCore::InspectorDOMDebuggerAgent::setEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::didHandleEvent):
(WebCore::InspectorDOMDebuggerAgent::willFireTimer):
(WebCore::InspectorDOMDebuggerAgent::didFireTimer):

• inspector/agents/page/PageDOMDebuggerAgent.h:
• inspector/agents/page/PageDOMDebuggerAgent.cpp:

(WebCore::PageDOMDebuggerAgent::disable):
(WebCore::PageDOMDebuggerAgent::mainFrameNavigated):
(WebCore::PageDOMDebuggerAgent::willFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::didFireAnimationFrame):
(WebCore::PageDOMDebuggerAgent::setAnimationFrameBreakpoint):

• inspector/agents/worker/WorkerDOMDebuggerAgent.h:
• inspector/agents/worker/WorkerDOMDebuggerAgent.cpp:

(WebCore::WorkerDOMDebuggerAgent::setAnimationFrameBreakpoint):
Keep a JSC::Breakpoint for each event breakpoint instead of a simple bool, allowing for
configuration when the breakpoint is first set. When any of these breakpoints are hit, pass
it to the JSC::Debugger as a "special breakpoint", which behaves the same as "pause ASAP"
but also supports a condition, an ignore count, actions, and auto-continue. Reset the hit
count for any of these "special breakpoints" that persist across Web Inspector sessions
when the main frame navigates.

• inspector/PageScriptDebugServer.h:
• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::PageScriptDebugServer):
(WebCore::PageScriptDebugServer::attachDebugger):
(WebCore::PageScriptDebugServer::detachDebugger):
(WebCore::PageScriptDebugServer::didPause):
(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore::PageScriptDebugServer::runEventLoopWhilePausedInternal):
(WebCore::PageScriptDebugServer::isContentScript const):
(WebCore::PageScriptDebugServer::reportException const):

• inspector/WorkerScriptDebugServer.h:
• inspector/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::attachDebugger):
(WebCore::WorkerScriptDebugServer::detachDebugger):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
(WebCore::WorkerScriptDebugServer::reportException const):

• inspector/agents/page/PageDebuggerAgent.h:
• inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::sourceMapURLForScript):
Replace Inspector::ScriptDebugServer with JSC::Debugger.

• inspector/TimelineRecordFactory.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createProbeSampleData):

• inspector/agents/InspectorTimelineAgent.h:
• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::breakpointActionProbe):
Replace Inspector::ScriptBreakpoint with JSC::Breakpoint.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::didFireTimer):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didHandleEventImpl):
(WebCore::InspectorInstrumentation::didFireTimerImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameImpl):

• dom/EventTarget.cpp:

(WebCore::EventTarget::innerInvokeEventListeners):

• page/DOMTimer.cpp:

(WebCore::DOMTimer::fired):
When notifying Web Inspector that activity did occur, include all information previously
included when notifying Web Inspector that that activity was about to occur so that Web
Inspector can know whether a pause for the "special breakpoint" for that activity is still
scheduled and if so cancel it.

Source/WebInspectorUI:

This allows developers to do things like:

• only pause when window.event.type is a certain value
• ignore the first N pauses
• evaluate JavaScript whenever an event listener is invoked without pausing

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint):
(WI.Breakpoint.prototype.toJSON):
(WI.Breakpoint.prototype.get special): Added.
(WI.Breakpoint.prototype.get removable): Added.
(WI.Breakpoint.prototype.get editable): Added.
(WI.Breakpoint.prototype.set condition):
(WI.Breakpoint.prototype.get ignoreCount):
(WI.Breakpoint.prototype.set ignoreCount):
(WI.Breakpoint.prototype.get autoContinue):
(WI.Breakpoint.prototype.set autoContinue):
(WI.Breakpoint.prototype.get actions):
(WI.Breakpoint.prototype.get probeActions):
(WI.Breakpoint.prototype.cycleToNextMode):
(WI.Breakpoint.prototype.createAction):
(WI.Breakpoint.prototype.recreateAction):
(WI.Breakpoint.prototype.removeAction):
(WI.Breakpoint.prototype.clearActions):
(WI.Breakpoint.prototype.remove): Added.
(WI.Breakpoint.prototype.optionsToProtocol): Added.
(WI.Breakpoint.prototype.breakpointActionDidChange):
(WI.Breakpoint.fromJSON): Deleted.
(WI.Breakpoint.prototype.get sourceCodeLocation): Deleted.
(WI.Breakpoint.prototype.get contentIdentifier): Deleted.
(WI.Breakpoint.prototype.get scriptIdentifier): Deleted.
(WI.Breakpoint.prototype.get target): Deleted.
(WI.Breakpoint.prototype.get identifier): Deleted.
(WI.Breakpoint.prototype.set identifier): Deleted.
(WI.Breakpoint.prototype.get resolved): Deleted.
(WI.Breakpoint.prototype.set resolved): Deleted.
(WI.Breakpoint.prototype.saveIdentityToCookie): Deleted.
(WI.Breakpoint.prototype._isSpecial): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationLocationChanged): Deleted.
(WI.Breakpoint.prototype._sourceCodeLocationDisplayLocationChanged): Deleted.

• UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint):
(WI.DOMBreakpoint.fromJSON): Added.
(WI.DOMBreakpoint.prototype.remove): Added.
(WI.DOMBreakpoint.prototype.toJSON):
(WI.DOMBreakpoint.deserialize): Deleted.
(WI.DOMBreakpoint.prototype.get disabled): Deleted.
(WI.DOMBreakpoint.prototype.set disabled): Deleted.

• UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint):
(WI.EventBreakpoint.fromJSON): Added.
(WI.EventBreakpoint.prototype.get special): Added.
(WI.EventBreakpoint.prototype.get editable): Added.
(WI.EventBreakpoint.prototype.remove): Added.
(WI.EventBreakpoint.prototype.saveIdentityToCookie):
(WI.EventBreakpoint.prototype.toJSON):
(WI.EventBreakpoint.deserialize): Deleted.
(WI.EventBreakpoint.prototype.get disabled): Deleted.
(WI.EventBreakpoint.prototype.set disabled): Deleted.

• UserInterface/Models/JavaScriptBreakpoint.js: Copied from UserInterface/Models/Breakpoint.js.

(WI.JavaScriptBreakpoint):
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get sourceCodeLocation):
(WI.JavaScriptBreakpoint.prototype.get contentIdentifier):
(WI.JavaScriptBreakpoint.prototype.get scriptIdentifier):
(WI.JavaScriptBreakpoint.prototype.get target):
(WI.JavaScriptBreakpoint.prototype.get special): Added.
(WI.JavaScriptBreakpoint.prototype.get removable): Added.
(WI.JavaScriptBreakpoint.prototype.get editable): Added.
(WI.JavaScriptBreakpoint.prototype.get identifier):
(WI.JavaScriptBreakpoint.prototype.set identifier):
(WI.JavaScriptBreakpoint.prototype.get resolved):
(WI.JavaScriptBreakpoint.prototype.set resolved):
(WI.JavaScriptBreakpoint.prototype.remove): Added.
(WI.JavaScriptBreakpoint.prototype.saveIdentityToCookie):
(WI.JavaScriptBreakpoint.prototype._isSpecial):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationLocationChanged):
(WI.JavaScriptBreakpoint.prototype._sourceCodeLocationDisplayLocationChanged):

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint):
(WI.URLBreakpoint.fromJSON): Added.
(WI.URLBreakpoint.prototype.get special): Added.
(WI.URLBreakpoint.prototype.remove): Added.
(WI.URLBreakpoint.prototype.toJSON):
(WI.URLBreakpoint.deserialize): Deleted.
(WI.URLBreakpoint.prototype.get disabled): Deleted.
(WI.URLBreakpoint.prototype.set disabled): Deleted.
Rename WI.Breakpoint to WI.JavaScriptBreakpoint and use WI.Breakpoint as a new common
base class for all breakpoint types, allowing more logic to be shared (e.g. disabled state).
Additionally, breakpoints are now able to

• determine whether or not they're
  • special
  • removable
  • editable (i.e. configurable)
• remove themselves

without the caller needing to know what manager to consult with.

• UserInterface/Controllers/DOMManager.js:

(WI.DOMManager):
(WI.DOMManager.supportsEventListenerBreakpointConfiguration): Added.
(WI.DOMManager.prototype.setBreakpointForEventListener):
(WI.DOMManager.prototype.removeBreakpointForEventListener):
(WI.DOMManager.prototype._setEventBreakpoint): Added.
(WI.DOMManager.prototype._removeEventBreakpoint): Added.
(WI.DOMManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for specific listener breakpoints.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.addEventBreakpoint):
(WI.DOMDebuggerManager.prototype.removeEventBreakpoint):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._commandArgumentsForEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._setEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeEventBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointDisabledStateChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleEventBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DOMDebuggerManager.prototype._updateEventBreakpoint): Deleted.
Keep track of configuration changes for special event breakpoints.
Store special event breakpoints inside WI.objectStores.eventBreakpoints.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype.addProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.removeProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype.updateProbesForBreakpoint): Added.
(WI.DebuggerManager.prototype._setBreakpoint):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._handleBreakpointActionsDidChange):
(WI.DebuggerManager.prototype.isBreakpointRemovable): Deleted.
(WI.DebuggerManager.prototype.isBreakpointSpecial): Deleted.
(WI.DebuggerManager.prototype.isBreakpointEditable): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointActionType): Deleted.
(WI.DebuggerManager.prototype._debuggerBreakpointOptions): Deleted.
(WI.DebuggerManager.prototype._addProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._removeProbesForBreakpoint): Deleted.
(WI.DebuggerManager.prototype._updateProbesForBreakpoint): Deleted.
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

• UserInterface/Controllers/BreakpointPopoverController.js:

(WI.BreakpointPopoverController.prototype.appendContextMenuItems):
(WI.BreakpointPopoverController.prototype._createPopoverContent):
Allow any breakpoint instead of only WI.JavaScriptBreakpoint.
Drive-by: the existing ignoreCount value wasn't being used to populate the <input>.

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
(WI.BreakpointTreeElement.prototype.get listenerSet): Added.
(WI.BreakpointTreeElement.prototype.updateStatus): Added.
(WI.BreakpointTreeElement.prototype.updateTitles): Added.
(WI.BreakpointTreeElement.prototype.get breakpoint): Deleted.
(WI.BreakpointTreeElement.prototype.get filterableData): Deleted.
(WI.BreakpointTreeElement.prototype._updateTitles): Deleted.
(WI.BreakpointTreeElement.prototype._updateStatus): Deleted.
(WI.BreakpointTreeElement.prototype._breakpointLocationDidChange): Deleted.

• UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image):
(.item.breakpoint.paused .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.paused .icon): Added.
(.item.breakpoint .status > .status-image.resolved): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.selected .status > .status-image.resolved): Deleted.
(.item.breakpoint .subtitle.formatted-location): Deleted.
(.breakpoint-debugger-statement-icon .icon): Deleted.
(.breakpoint-exception-icon .icon): Deleted.
(.breakpoint-assertion-icon .icon): Deleted.
(.breakpoint-microtask-icon .icon): Deleted.
(.breakpoint-paused-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon): Deleted.
(.breakpoint-generic-line-icon .icon > span): Deleted.
(.data-updated.breakpoint-generic-line-icon .icon > span): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-debugger-statement-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-exception-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-assertion-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-microtask-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-paused-icon .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint-generic-line-icon .icon): Deleted.

• UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement):
(WI.DOMBreakpointTreeElement.prototype.onattach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.DOMBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onenter): Deleted.
(WI.DOMBreakpointTreeElement.prototype.onspace): Deleted.
(WI.DOMBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.DOMBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.DOMBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.DOMBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/DOMBreakpointTreeElement.css:

(.item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(.item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.subtree-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.attribute-modified:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.dom.node-removed:not(.paused) .icon): Added.
(.breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-subtree-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-attribute-modified:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.dom.breakpoint-for-node-removed:not(.breakpoint-paused-icon) .icon): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):
(WI.EventBreakpointTreeElement.prototype.onattach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.EventBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.EventBreakpointTreeElement.prototype.onenter): Deleted.
(WI.EventBreakpointTreeElement.prototype.onspace): Deleted.
(WI.EventBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.EventBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.EventBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.EventBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.css:

(.item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(.item.breakpoint.event.interval:not(.paused) .icon): Added.
(.item.breakpoint.event.listener:not(.paused) .icon): Added.
(.item.breakpoint.event.timeout:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.animation-frame:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.interval:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.listener:not(.paused) .icon): Added.
(@media(prefers-color-scheme: dark) .item.breakpoint.event.timeout:not(.paused) .icon): Added.
(.breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(.breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-animation-frame:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-interval:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-listener:not(.breakpoint-paused-icon) .icon): Deleted.
(@media(prefers-color-scheme: dark) .breakpoint.event.breakpoint-for-timeout:not(.breakpoint-paused-icon) .icon): Deleted.

• UserInterface/Views/JavaScriptBreakpointTreeElement.js: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js.

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype.get filterableData):
(WI.JavaScriptBreakpointTreeElement.prototype.updateStatus): Added.
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles): Added.
(WI.JavaScriptBreakpointTreeElement.prototype._breakpointLocationDidChange):

• UserInterface/Views/JavaScriptBreakpointTreeElement.css: Copied from Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.css.

(.item.breakpoint.javascript .status > .status-image): Added.
(.item.breakpoint.javascript .status > .status-image.resolved): Added.
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .item.breakpoint.javascript.selected .status > .status-image.resolved): Added.
(.item.breakpoint.javascript .subtitle.formatted-location): Added.
(.item.breakpoint.javascript.line .icon): Added.
(.item.breakpoint.javascript.line .icon > span): Added.
(.data-updated.item.breakpoint.javascript.line .icon > span): Added.
(.item.breakpoint.javascript.debugger-statement .icon): Added.
(.item.breakpoint.javascript.exception .icon): Added.
(.item.breakpoint.javascript.assertion .icon): Added.
(.item.breakpoint.javascript.microtask .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.line .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.debugger-statement .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.exception .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.assertion .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.javascript.microtask .icon): Added.

• UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):
(WI.URLBreakpointTreeElement.prototype.onattach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondetach): Deleted.
(WI.URLBreakpointTreeElement.prototype.ondelete): Deleted.
(WI.URLBreakpointTreeElement.prototype.onenter): Deleted.
(WI.URLBreakpointTreeElement.prototype.onspace): Deleted.
(WI.URLBreakpointTreeElement.prototype.populateContextMenu): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementClicked): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementFocused): Deleted.
(WI.URLBreakpointTreeElement.prototype._statusImageElementMouseDown): Deleted.
(WI.URLBreakpointTreeElement.prototype._toggleBreakpoint): Deleted.
(WI.URLBreakpointTreeElement.prototype._updateStatus): Deleted.

• UserInterface/Views/URLBreakpointTreeElement.css:

(.item.breakpoint.url .subtitle): Added.
(.item.breakpoint.url:not(.paused) .icon): Added.
(@media (prefers-color-scheme: dark) .item.breakpoint.url:not(.paused) .icon): Added.
(.breakpoint.url .subtitle): Deleted.
(.breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
(@media (prefers-color-scheme: dark) .breakpoint.url:not(.breakpoint-paused-icon) .icon): Deleted.
Rename WI.BreakpointTreeElement to WI.JavaScriptBreakpointTreeElement and use
WI.BreakpointTreeElement as a new common base class for all breakpoint tree elements,
allowing more logic and styles to be shared (e.g. disabled state).

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype.closed):
(WI.SourcesNavigationSidebarPanel.prototype._insertDebuggerTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._compareJavaScriptBreakpointTreeElements): Added.
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._removeAllBreakpoints):
(WI.SourcesNavigationSidebarPanel.prototype._breakpointsBeneathTreeElement):
(WI.SourcesNavigationSidebarPanel.prototype._addIssue):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._handleTreeSelectionDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._compareBreakpointTreeElements): Deleted.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.createProbe):
(WI.ProbeSet.prototype.willRemove):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

• UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WI.ProbeDetailsSidebarPanel.prototype.inspect):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor):
(WI.SourceCodeTextEditor.prototype.close):
(WI.SourceCodeTextEditor.prototype.textEditorBreakpointAdded):

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get supplementalRepresentedObjects):
(WI.TextResourceContentView.prototype._probeSetsChanged):
Probes now support WI.EventBreakpoint in addition to WI.JavaScriptBreakpoint.

• UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):
(WI.ContentView.isViewable):

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):
Replace WI.Breakpoint with WI.JavaScriptBreakpoint.

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Replace WI.DOMBreakpoint with WI.Breakpoint.

• UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):

• UserInterface/Views/EventListenerSectionGroup.css:

(.event-listener-section > .content input[type="checkbox"] + .go-to-arrow): Added.
(.event-listener-section > .content input[type="checkbox"]:not(:checked) + .go-to-arrow): Added.
Add a go-to arrow next to the Breakpoint checkbox that reveals the WI.EventBreakpoint in
the Sources Tab.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView.prototype._appendActionButtonClicked):
Drive-by: minor code cleanup.

• UserInterface/Views/CallFrameTreeElement.js:

(WI.CallFrameTreeElement.prototype.populateContextMenu):
Drive-by: include source code location context menu items.

• UserInterface/Base/Setting.js:
• UserInterface/Main.html:
• UserInterface/Test.html:

LayoutTests:

• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Added.
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.async teardown):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.removeBreakpoint):

• inspector/dom/breakpoint-for-event-listener.html:
• inspector/dom/breakpoint-for-event-listener-expected.txt:
• inspector/dom-debugger/event-animation-frame-breakpoints.html:
• inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
• inspector/dom-debugger/event-interval-breakpoints.html:
• inspector/dom-debugger/event-interval-breakpoints-expected.txt:
• inspector/dom-debugger/event-listener-breakpoints.html:
• inspector/dom-debugger/event-listener-breakpoints-expected.txt:
• inspector/dom-debugger/event-timeout-breakpoints.html:
• inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Add tests for new event breakpoint configuration options.

• http/tests/inspector/debugger/debugger-test.js:

(TestPage.registerInitializer.InspectorTest.startTracingBreakpoints):

• http/tests/inspector/resources/probe-test.js:

(TestPage.registerInitializer.ProtocolTest.Probe.installTracingListeners):

• inspector/debugger/breakpoint-action-eval.html:
• inspector/debugger/breakpoint-action-log.html:
• inspector/debugger/breakpoint-columns.html:
• inspector/debugger/breakpoint-scope.html:
• inspector/debugger/debugger-stack-overflow.html:
• inspector/debugger/pause-reason.html:
• inspector/debugger/probe-manager-add-remove-actions.html:
• inspector/debugger/stepping/stepping-through-autoContinue-breakpoint.html:
• inspector/debugger/tail-deleted-frames-this-value.html:
• inspector/debugger/tail-recursion.html:
• inspector/worker/debugger-pause.html:
• inspector/worker/debugger-shared-breakpoint.html:

Update existing breakpoint tests to use new model objects.

10:32 AM Changeset in webkit [266073] by Hector Lopez

• 2 edits in trunk/LayoutTests

Regression (r266028): platform/ios/ios/fast/coordinates/range-client-rects.html
​https://bugs.webkit.org/show_bug.cgi?id=215772

Unreviewwed test gardening.

• platform/ios-wk2/TestExpectations:

10:31 AM Changeset in webkit [266072] by Devin Rousso

• 39 edits in trunk/Source

Web Inspector: remove "extra domains" concept now that domains can be added based on the debuggable type
​https://bugs.webkit.org/show_bug.cgi?id=201150
<rdar://problem/56545911>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/scripts/codegen/objc_generator_templates.py:
• inspector/augmentable/AugmentableInspectorController.h:

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::registerAlternateAgent): Added.
(Inspector::JSGlobalObjectInspectorController::appendExtraAgent): Deleted.

• inspector/InspectorAgentRegistry.h:
• inspector/InspectorAgentRegistry.cpp:

(Inspector::AgentRegistry::appendExtraAgent): Deleted.

• inspector/protocol/Inspector.json:
• inspector/agents/InspectorAgent.h:
• inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::activateExtraDomain): Deleted.
(Inspector::InspectorAgent::activateExtraDomains): Deleted.

• inspector/scripts/tests/expected/command-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
• inspector/scripts/tests/expected/domain-debuggableTypes.json-result:
• inspector/scripts/tests/expected/domain-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/domain-targetTypes.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/enum-values.json-result:
• inspector/scripts/tests/expected/event-targetType-matching-domain-debuggableType.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:

Rebase protocol tests.

Source/WebInspectorUI:

• UserInterface/Base/Object.js:
• UserInterface/Protocol/InspectorObserver.js:

(WI.InspectorObserver.prototype.activateExtraDomains):

• UserInterface/Protocol/Target.js:

(WI.Target.prototype.activateExtraDomain):

• UserInterface/Controllers/AppController.js:

(WI.AppController.prototype.activateExtraDomains):

• UserInterface/Controllers/AnimationManager.js:

(WI.AnimationManager.prototype.activateExtraDomain):

• UserInterface/Controllers/ApplicationCacheManager.js:

(WI.ApplicationCacheManager.prototype.activateExtraDomain):

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.activateExtraDomain):

• UserInterface/Controllers/DOMStorageManager.js:

(WI.DOMStorageManager.prototype.activateExtraDomain):

• UserInterface/Controllers/DatabaseManager.js:

(WI.DatabaseManager.prototype.activateExtraDomain):

• UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.activateExtraDomain):

• UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager.prototype.activateExtraDomain):

• UserInterface/Controllers/MemoryManager.js:

(WI.MemoryManager.prototype.activateExtraDomain):

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype._extraDomainsActivated):

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype.activateExtraDomain):

• UserInterface/Base/Main.js:

(WI.activateExtraDomains):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleExtraDomainsActivated):
Add compatibility comments.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackend.Domain):
Add FIXMEs.

10:30 AM Changeset in webkit [266071] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove legacy code for replacing the Canvas Tab with the Graphics Tab
​https://bugs.webkit.org/show_bug.cgi?id=205827

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Main.js:

(WI.loaded):

10:24 AM Changeset in webkit [266070] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215681

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):

10:21 AM Changeset in webkit [266069] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: don't show non-inherited properties
​https://bugs.webkit.org/show_bug.cgi?id=215682

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender):

10:17 AM Changeset in webkit [266068] by youenn@apple.com

• 1 edit
  4 adds in trunk/LayoutTests

Add a test showing the difference of behavior when closing a WebSocket connection between legacy WebSocket and NSURLSession WebSocket code paths
​https://bugs.webkit.org/show_bug.cgi?id=215766

Reviewed by Alex Christensen.

Add a test showing the difference of behavior at connection close time in python websocket script.
This behavior was previously covered in http/tests/websocket/tests/hybi/close-on-* tests.
The test is written so that Chrome, Firefox and NSURLSession WebSocket code path generate all PASS.
Legacy WebSocket code path generates one FAIL.

• http/tests/websocket/tests/hybi/close-and-exceptions_wsh.py: Added.
• http/tests/websocket/tests/hybi/close-and-server-script-exception-expected.txt: Added.
• http/tests/websocket/tests/hybi/close-and-server-script-exception.html: Added.
• http/tests/websocket/tests/hybi/resources/close-and-server-script-exception-iframe.html: Added.

10:13 AM Changeset in webkit [266067] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=215773

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

10:11 AM Changeset in webkit [266066] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: grey out properties that aren't used/apply
​https://bugs.webkit.org/show_bug.cgi?id=215680

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .name:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(.editing), body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .name:not(:hover, .editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled):is(.invalid-name, .invalid-value, .other-vendor, .overridden) > .content > .value-container > .value:not(:hover, .editing)): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-link): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-string): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled, .invalid-name, .invalid-value, .other-vendor, .overridden) > .content .value:not(:hover, .editing) .token-comment): Added.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .name:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing), body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing)): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-link, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-link): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-string, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-string): Deleted.
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(.editing) .token-comment, body.meta-key-pressed .spreadsheet-style-declaration-editor > .property:not(.disabled) > .content .value:not(:hover, .editing) .token-comment): Deleted.
Add additional :nots to existing rules to ensure that they don't conflict with a new rule
that changes the color of the .name/.value to grey when the property is not applied/used.

10:01 AM Changeset in webkit [266065] by Hector Lopez

• 2 edits in trunk/LayoutTests

webkit-test-runner: Add support for the reftest-wait class name
​https://bugs.webkit.org/show_bug.cgi?id=186045

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:51 AM Changeset in webkit [266064] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=215765
<rdar://problem/67677285>

Reviewed by Eric Carlson.

Following ​https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.

• Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:

9:25 AM Changeset in webkit [266063] by Aditya Keerthi

• 46 edits
  11 adds in trunk

[macOS] Show picker for date and datetime-local input types
​https://bugs.webkit.org/show_bug.cgi?id=214946

Reviewed by Darin Adler and Wenson Hsieh.

Source/WebCore:

Date and datetime-local input types require a calendar picker to be presented when activated.
Consequently, BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent was modified to
create a DateTimeChooser and display a calendar upon activation. This object is destroyed
when the element is blurred, hiding the calendar.

There is currently no picker UI for month, week, and time input types. As a result,
handleDOMActivateEvent is a no-op on those input types.

Wrote an encoder and decoder for DateTimeChooserParameters, so that the picker can be
created with the correct values.

Tests: fast/forms/date/date-show-hide-picker.html

fast/forms/datetimelocal/datetimelocal-show-hide-picker.html

• WebCore.xcodeproj/project.pbxproj:
• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
(WebCore::BaseChooserOnlyDateAndTimeInputType::elementDidBlur):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isPresentingAttachedView const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/HTMLInputElement.cpp:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::handleDOMActivateEvent):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::handleDOMActivateEvent):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::handleDOMActivateEvent):

• html/WeekInputType.h:
• loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createDateTimeChooser):

• loader/EmptyClients.h:
• page/Chrome.cpp:

(WebCore::Chrome::createDateTimeChooser):

• page/Chrome.h:
• page/ChromeClient.h:
• platform/DateTimeChooser.h:
• platform/DateTimeChooserClient.h:
• platform/DateTimeChooserParameters.h: Added.

(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):

Source/WebKit:

Created WKDateTimePicker as a wrapper around NSDatePicker. The picker is
displayed in its own NSWindow, ensuring the view is always above the page.
WebPageProxy and WKDateTimePicker communicate through WebDateTimePickerMac,
in order for the picker to be initialized with the correct initial, minimum,
and maximum date, and so that the chosen date can be sent back to the
WebProcess.

Added IPC messages to enable communication between the UIProcess and the
WebProcess necessary for showing and hiding the picker.

• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/PageClient.h:
• UIProcess/WebDateTimePicker.cpp: Added.

(WebKit::WebDateTimePicker::WebDateTimePicker):
(WebKit::WebDateTimePicker::~WebDateTimePicker):
(WebKit::WebDateTimePicker::endPicker):

• UIProcess/WebDateTimePicker.h: Added.
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showDateTimePicker):
(WebKit::WebPageProxy::endDateTimePicker):
(WebKit::WebPageProxy::didChooseDate):
(WebKit::WebPageProxy::didEndDateTimePicker):
(WebKit::WebPageProxy::closeOverlayedViews):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDateTimePicker):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::createDateTimePicker):

• UIProcess/mac/WebDateTimePickerMac.h: Added.
• UIProcess/mac/WebDateTimePickerMac.mm: Added.

(WebKit::WebDateTimePickerMac::create):
(WebKit::WebDateTimePickerMac::~WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::WebDateTimePickerMac):
(WebKit::WebDateTimePickerMac::endPicker):
(WebKit::WebDateTimePickerMac::showDateTimePicker):
(WebKit::WebDateTimePickerMac::didChooseDate):
(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerWindow canBecomeKeyWindow]):
(-[WKDateTimePickerWindow hasKeyAppearance]):
(-[WKDateTimePickerWindow shadowOptions]):
(-[WKDateTimePicker initWithParams:inView:]):
(-[WKDateTimePicker showPicker:]):
(-[WKDateTimePicker invalidate]):
(-[WKDateTimePicker didChooseDate:]):
(-[WKDateTimePicker dateFormatStringForType:]):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createDateTimeChooser):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/WebDateTimeChooser.cpp: Added.

(WebKit::WebDateTimeChooser::WebDateTimeChooser):
(WebKit::WebDateTimeChooser::didChooseDate):
(WebKit::WebDateTimeChooser::didEndChooser):
(WebKit::WebDateTimeChooser::endChooser):
(WebKit::WebDateTimeChooser::showChooser):

• WebProcess/WebCoreSupport/WebDateTimeChooser.h: Added.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setActiveDateTimeChooser):
(WebKit::WebPage::didChooseDate):
(WebKit::WebPage::didEndDateTimePicker):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createDateTimeChooser):

Tools:

Added isShowingDateTimePicker testing hook in order to enable testing of the visibility of
the picker.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::isShowingDateTimePicker const):

• WebKitTestRunner/mac/UIScriptControllerMac.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::isShowingDateTimePicker const):

LayoutTests:

Added tests to verify that the picker is correctly shown and hidden for date and
datetime-local input types.

• fast/forms/date/date-show-hide-picker-expected.txt: Added.
• fast/forms/date/date-show-hide-picker.html: Added.
• fast/forms/datetimelocal/datetimelocal-show-hide-picker-expected.txt: Added.
• fast/forms/datetimelocal/datetimelocal-show-hide-picker.html: Added.
• platform/ios/TestExpectations:
• resources/ui-helper.js:

(window.UIHelper.isShowingDateTimePicker):

9:22 AM Changeset in webkit [266062] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Rename LineBox::baseline to alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214784

Reviewed by Antti Koivisto.

See ​https://www.w3.org/TR/css-inline-3/#alignment-baseline
Use the spec term. This helps to tell the dominant and the alignment baselines apart during line building.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::resetAlignmentBaseline):
(WebCore::Layout::LineBox::setBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::baseline const): Deleted.
(WebCore::Layout::LineBox::resetBaseline): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):

8:50 AM Changeset in webkit [266061] by Adrian Perez de Castro

• 7 edits in trunk/Source

Non-unified build fixes, late August 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=215768

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• Modules/webaudio/StereoPannerNode.cpp: Add missing headers AudioNodeInput.h,

AudioNodeOutput.h, and wtf/IsoMallocInlines.h.

• bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
Add JSC:: namespace to SlotVisitor parameter type.

• dom/SimpleRange.cpp: Add missing ShadowRoot.h header.
• history/CachedPage.cpp: Add missing FrameLoaderClient.h header.

Source/WebKit:

• UIProcess/WebURLSchemeTask.cpp: Add missing SharedBufferDataReference.h header.

8:42 AM Changeset in webkit [266060] by Hector Lopez

• 2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2
​https://bugs.webkit.org/show_bug.cgi?id=189672

Unreviewed test gardening.

• platform/mac/TestExpectations:

8:02 AM Changeset in webkit [266059] by youenn@apple.com

• 12 edits in trunk/LayoutTests

http/tests/websocket/tests/hybi/close-on-* tests are not interoperable
​https://bugs.webkit.org/show_bug.cgi?id=215692

Reviewed by Darin Adler.

Before the patch, tests were not passing in Chrome, Firefox and NSURLSession WebSocket code path.
This was due to the fact the web socket script is using try/finally and the closure of the connection is not raising an exception
while it is for Chrome, Firefox and NSURLSession WebSocket code path.
Change the WebSocket server script to more reliably send the socket message at closing time of the connection.

• http/tests/websocket/tests/hybi/close-on-navigate-new-location-expected.txt:
• http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:
• http/tests/websocket/tests/hybi/close-on-unload-and-force-gc-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
• http/tests/websocket/tests/hybi/close-on-unload-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent-expected.txt:
• http/tests/websocket/tests/hybi/close-on-unload-reference-in-parent.html:
• http/tests/websocket/tests/hybi/close-on-unload.html:
• http/tests/websocket/tests/hybi/close-on-unload_wsh.py:

(web_socket_transfer_data):

• http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
• http/tests/websocket/tests/hybi/send-after-close-on-unload.html:

8:02 AM Changeset in webkit [266058] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=215767

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

7:57 AM Changeset in webkit [266057] by youenn@apple.com

• 7 edits in trunk

Cocoa WebSocketTask should expose WebSocket server extensions
​https://bugs.webkit.org/show_bug.cgi?id=215696

Reviewed by Darin Adler.

Source/WebKit:

Send back to WebProcess the value of server WebSocket extensions.

• NetworkProcess/cocoa/WebSocketTaskCocoa.mm:

(WebKit::WebSocketTask::didConnect):

LayoutTests:

Make the tests agnostic of using the legacy or standard deflate extension.
If using the standard deflate extensions, do not expect subparameters (this matches Chrome, Firefox and NSURLSession code path).

• http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt:
• http/tests/websocket/tests/hybi/deflate-frame-parameter.html:
• http/tests/websocket/tests/hybi/extensions-expected.txt:
• http/tests/websocket/tests/hybi/extensions.html:

7:50 AM Changeset in webkit [266056] by Alan Bujtas

• 12 edits in trunk/Source/WebCore

[LFC][IFC] Use the term 'baseline' to indicate alignment baseline
​https://bugs.webkit.org/show_bug.cgi?id=214779

Reviewed by Antti Koivisto.

This patch is in preparation for decoupling the line box and the root inline box geometry.
Inline boxes have ascent/descent pairs, while line boxes have inline boxes and a baseline.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::AscentAndDescent::height const):
(WebCore::Layout::LineBox::ascentAndDescent const):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::setBaselineIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::height const): Deleted.
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater): Deleted.
(WebCore::Layout::LineBox::baselineOffset const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::Baseline): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setAscent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::setDescent): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::reset): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::ascent const): Deleted.
(WebCore::Layout::LineBox::InlineBox::Baseline::descent const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::alignContentVertically):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::baseline const):
(WebCore::Layout::LineBuilder::baselineOffset const): Deleted.

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

• layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace):

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

• layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Row::setBaseline):
(WebCore::Layout::TableGrid::Row::baseline const):
(WebCore::Layout::TableGrid::Cell::setBaseline):
(WebCore::Layout::TableGrid::Cell::baseline const):
(WebCore::Layout::TableGrid::Row::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Row::baselineOffset const): Deleted.
(WebCore::Layout::TableGrid::Cell::setBaselineOffset): Deleted.
(WebCore::Layout::TableGrid::Cell::baselineOffset const): Deleted.

• layout/tableformatting/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):

6:10 AM Changeset in webkit [266055] by Carlos Garcia Campos

• 18 edits in trunk

Unreviewed. Fix GTK4 build

Source/WebCore:

• SourcesGTK.txt:
• platform/gtk/GtkUtilities.cpp:

(WebCore::monitorWorkArea):

• platform/gtk/GtkUtilities.h:
• platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenAvailableRect):

Source/WebKit:

• PlatformGTK.cmake:
• UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

• UIProcess/API/gtk/WebKitScriptDialogImpl.cpp:

(webkitScriptDialogImplConstructed):
(webkit_script_dialog_impl_class_init):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEvent):
(webkit_web_view_base_class_init):

• UIProcess/API/gtk/WebKitWebViewDialog.cpp:

(webkitWebViewDialogConstructed):
(webkitWebViewDialogSetChild):

• UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:

(webkit_inspector_window_init):

• UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::show):

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

Tools:

• MiniBrowser/gtk/BrowserSearchBox.c:
• MiniBrowser/gtk/BrowserWindow.c:

5:29 AM Changeset in webkit [266054] by commit-queue@webkit.org

• 4 edits in trunk

Make window.find not default the search string to undefined
​https://bugs.webkit.org/show_bug.cgi?id=215757

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-24
Reviewed by Darin Adler.

Source/WebCore:

Make window.find not default the search string to undefined, instead
use the null string. Before this change window.find() would find a
hit in a page containing the text string "undefined".

Test: fast/text/window-find.html

• page/DOMWindow.idl:

LayoutTests:

Add tests to verify window.find() does not use "undefined"
as text string. This also fixes the logic of the test to
not always output PASS at the end.

• fast/text/window-find.html:

2:55 AM Changeset in webkit [266053] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, ignore RangeErrors when ICU is too old

Since ICU version is different (very sad), some of tests can throw an error.

• stress/intl-language-tag.js:

(let.shouldThrow):
(let.shouldNotThrow):
(suppressErrors):
(vm.icuVersion):
(shouldThrow): Deleted.
(shouldNotThrow): Deleted.

2:26 AM Changeset in webkit [266052] by commit-queue@webkit.org

• 7 edits in trunk

RTCRtpSynchronizationSource.rtpTimestamp is not present
​https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <​justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

• LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpContributingSource.idl:
• Modules/mediastream/RTCRtpSynchronizationSource.idl:

Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.

• Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::fillRTCRtpContributingSource):

Aug 23, 2020:

6:51 PM Changeset in webkit [266051] by Wenson Hsieh

• 15 edits
  2 adds in trunk

Programmatic selection of text in a text field causes the highlight overlay to spill out
​https://bugs.webkit.org/show_bug.cgi?id=215647
<rdar://problem/67404979>

Reviewed by Darin Adler.

Source/WebCore:

See WebKit ChangeLog for more detail.

• html/HTMLTextFormControlElement.h: Export a helper function.

Source/WebKit:

UIKit consults the SPI method -_selectionClipRect on WKContentView to determine the maximum bounds in which it
is allowed to show text selection UI (i.e. the text caret view, selection highlight views, and selection
grabbers). Normally, when contentEditable elements and editable text form controls are focused, we plumb the
bounds of the focused element to the UI process via focusedElementRect in editor state's post layout data.
However, in this case, the selection is inside a readonly text field that is *not* focused; this causes us to
return CGRectNull from -_selectionClipRect, which means that UIKit selection UI is not clipped at all and
instead overflows the bounds of the input element.

To fix this, rearrange some logic in WebPage::getPlatformEditorState in WebPageIOS.mm such that we compute
and send the selection clipping rect if the selection is inside a text form control, even if it is not the
focused element. In doing this, we also rename some confusingly-named members in EditorState::PostLayoutData
(see below for more detail).

Test: editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html

• Platform/spi/ios/UIKitSPI.h:

Add a declaration for -_selectionClipRect.

• Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
(WebKit::operator<<):

• Shared/EditorState.h:

Split the existing rect member focusedElementRect into two: selectionClipRect on iOS, and
selectionBoundingRect on macOS. Previously, focusedElementRect was set to the focused element's bounding
rect on iOS (as expected), but on macOS, we set to the bounds of the ranged or caret selection; we proceed to
use this rect to mean the bounds of the selection anyways in macOS-specific code, so it makes more sense to just
move this into the macOS-specific section.

Additionally, after the below change in WebPageIOS, focusedElementRect is no longer specific to the focused
element, so rename it instead to selectionClipRect instead. In WKContentViewInteraction.mm, this rect is
effectively only used in two ways: as the selection clip rect for UIKit, and to determine if the selection would
be completely clipped anyways (in which case we suppress UIKit text interactions), so selectionClipRect is a
name that is suitable for both purposes.

• UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView _candidateRect]):

• UIProcess/Cocoa/WebViewImpl.mm:

Rename focusedElementRect to selectionBoundingRect on macOS.

(WebKit::WebViewImpl::handleRequestedCandidates):

• UIProcess/ios/WKContentViewInteraction.mm:

Rename focusedElementRect to selectionClipRect on iOS.

(WebKit::WKSelectionDrawingInfo::WKSelectionDrawingInfo):
(-[WKContentView _selectionClipRect]):

Change this to not require a focused element when returning the selection clip rect, and instead return the
editor state's selection clip rect as long as it is not empty.

(-[WKContentView _updateSelectionAssistantSuppressionState]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const):

Refactor this code to compute and send selectionClipRect as long as the selection is inside a form control or
editing host (not just when there is a focused element). Also leave a drive-by FIXME about using the focused
element (instead of the selection container node) when computing the caret color.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getPlatformEditorState const):

Tools:

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::clipSelectionViewRectToContentView):

Add a helper function to clip UIKit selection UI rects (for carets, selection grabbers, and ranged selection
highlights) to the content view's (WKContentView's) bounds, as well as the selection clip rect if it is nonnull.

(WTR::UIScriptControllerIOS::selectionStartGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionEndGrabberViewRect const):
(WTR::UIScriptControllerIOS::selectionCaretViewRect const):
(WTR::UIScriptControllerIOS::selectionRangeViewRects const):

LayoutTests:

• editing/selection/ios/select-all-in-readonly-input-does-not-overflow-expected.txt: Added.
• editing/selection/ios/select-all-in-readonly-input-does-not-overflow.html: Added.

Add a new layout test to verify that the width of the selection view does not exceed the width of the readonly
input containing the selected text.

• resources/ui-helper.js:

(window.UIHelper.async waitForSelectionToAppear):

Adjust this UIHelper function to additionally resolve to the selection rects, so that it won't be necessary for
callers to ask for the selection view rects separately after waiting for selection views to appear.

6:30 PM Changeset in webkit [266050] by Fujii Hironori

• 4 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/TestExpectations:
• platform/wincairo/css1/text_properties/letter_spacing-expected.txt:
• platform/wincairo/fast/text/emphasis-expected.txt:

2:21 PM Changeset in webkit [266049] by Lauro Moura

• 3 edits in trunk/LayoutTests

Avoid timeout when http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html fails
​https://bugs.webkit.org/show_bug.cgi?id=215759

Reviewed by Darin Adler.

• http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html:

Finish the test if the test fails because the close callback is
called.

• platform/glib/TestExpectations: Update expectation.

10:06 AM Changeset in webkit [266048] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Introduce the root inline box
​https://bugs.webkit.org/show_bug.cgi?id=214733

Reviewed by Antti Koivisto.

This is in preparation for having a dedicated line box for each line with inline boxes inside.
At this point we only use the root inline box to proxy the baseline handling.
See ​https://www.w3.org/TR/css-inline-3/#model

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::Baseline::height const):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::setLogicalHeightIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::Baseline):
(WebCore::Layout::LineBox::InlineBox::Baseline::setAscent):
(WebCore::Layout::LineBox::InlineBox::Baseline::setDescent):
(WebCore::Layout::LineBox::InlineBox::Baseline::reset):
(WebCore::Layout::LineBox::InlineBox::Baseline::ascent const):
(WebCore::Layout::LineBox::InlineBox::Baseline::descent const):
(WebCore::Layout::InlineBox::Baseline::height const): Deleted.
(WebCore::Layout::InlineBox::logicalRect const): Deleted.
(WebCore::Layout::InlineBox::scrollableOverflow const): Deleted.
(WebCore::Layout::InlineBox::logicalLeft const): Deleted.
(WebCore::Layout::InlineBox::logicalRight const): Deleted.
(WebCore::Layout::InlineBox::logicalTop const): Deleted.
(WebCore::Layout::InlineBox::logicalBottom const): Deleted.
(WebCore::Layout::InlineBox::logicalWidth const): Deleted.
(WebCore::Layout::InlineBox::logicalHeight const): Deleted.
(WebCore::Layout::InlineBox::resetDescent): Deleted.
(WebCore::Layout::InlineBox::setLogicalHeight): Deleted.
(WebCore::Layout::InlineBox::setLogicalWidth): Deleted.
(WebCore::Layout::InlineBox::setScrollableOverflow): Deleted.
(WebCore::Layout::InlineBox::moveHorizontally): Deleted.
(WebCore::Layout::InlineBox::expandHorizontally): Deleted.
(WebCore::Layout::InlineBox::shrinkHorizontally): Deleted.
(WebCore::Layout::InlineBox::expandVertically): Deleted.
(WebCore::Layout::InlineBox::shrinkVertically): Deleted.
(WebCore::Layout::InlineBox::isConsideredEmpty const): Deleted.
(WebCore::Layout::InlineBox::setIsConsideredEmpty): Deleted.
(WebCore::Layout::InlineBox::setIsConsideredNonEmpty): Deleted.
(WebCore::Layout::InlineBox::InlineBox): Deleted.
(WebCore::Layout::InlineBox::setLogicalHeightIfGreater): Deleted.
(WebCore::Layout::InlineBox::baseline const): Deleted.
(WebCore::Layout::InlineBox::setBaselineOffsetIfGreater): Deleted.
(WebCore::Layout::InlineBox::setAscentIfGreater): Deleted.
(WebCore::Layout::InlineBox::setDescentIfGreater): Deleted.
(WebCore::Layout::InlineBox::baselineOffset const): Deleted.
(WebCore::Layout::InlineBox::resetBaseline): Deleted.
(WebCore::Layout::InlineBox::Baseline::Baseline): Deleted.
(WebCore::Layout::InlineBox::Baseline::setAscent): Deleted.
(WebCore::Layout::InlineBox::Baseline::setDescent): Deleted.
(WebCore::Layout::InlineBox::Baseline::reset): Deleted.
(WebCore::Layout::InlineBox::Baseline::ascent const): Deleted.
(WebCore::Layout::InlineBox::Baseline::descent const): Deleted.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox const):

• layout/inlineformatting/LineLayoutContext.h:

6:53 AM Changeset in webkit [266047] by Alan Bujtas

• 14 edits in trunk/Source/WebCore

[LFC][IFC] Display::LineBox does not need ascent/descent geometry
​https://bugs.webkit.org/show_bug.cgi?id=214720

Reviewed by Antti Koivisto.

Line box is just a rectangular area that contains all the inline boxes that form a single line.
It generally has a non-zero baseline (the root inline box's baseline), but it does not have ascent/descent geometry.

• layout/displaytree/DisplayLineBox.h:

(WebCore::Display::LineBox::baseline const):
(WebCore::Display::LineBox::LineBox):
(WebCore::Display::LineBox::Baseline::height const): Deleted.
(WebCore::Display::LineBox::Baseline::ascent const): Deleted.
(WebCore::Display::LineBox::Baseline::descent const): Deleted.
(WebCore::Display::LineBox::baselineOffset const): Deleted.
(WebCore::Display::LineBox::Baseline::Baseline): Deleted.

• layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::alignContentVertically):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

• layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::paint):

• layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::layoutFormattingContextEnabled const):
(WebCore::RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled const):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::boundingBoxForRenderTreeDump const):

• rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::baseline const):
(WebCore::SimpleLineLayout::RunResolver::Run::baselineOffset const): Deleted.

• rendering/line/LineLayoutTraversal.h:

(WebCore::LineLayoutTraversal::Box::baseline const):
(WebCore::LineLayoutTraversal::Box::baselineOffset const): Deleted.

• rendering/line/LineLayoutTraversalComplexPath.h:

(WebCore::LineLayoutTraversal::ComplexPath::baseline const):
(WebCore::LineLayoutTraversal::ComplexPath::baselineOffset const): Deleted.

• rendering/line/LineLayoutTraversalDisplayRunPath.h:

(WebCore::LineLayoutTraversal::DisplayRunPath::baseline const):
(WebCore::LineLayoutTraversal::DisplayRunPath::baselineOffset const): Deleted.

• rendering/line/LineLayoutTraversalSimplePath.h:

(WebCore::LineLayoutTraversal::SimplePath::baseline const):
(WebCore::LineLayoutTraversal::SimplePath::baselineOffset const): Deleted.

6:40 AM Changeset in webkit [266046] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Do not use undefined default param in CSSStyleDeclaration.idl
​https://bugs.webkit.org/show_bug.cgi?id=215753

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-23
Reviewed by Darin Adler.

Do not use undefined default parameter value in CSSStyleDeclaration.idl, instead use no explicit default
parameter at all. This means a zero length String will be used, which will be more efficient when using
the cssPropertyID helper method, as well as less error-prone.

• css/CSSStyleDeclaration.idl:

5:45 AM Changeset in webkit [266045] by Alan Bujtas

• 4 edits
  2 adds in trunk

[LFC][IFC] Move all line height and baseline adjustment logic to LineBuilder::adjustBaselineAndLineHeight
​https://bugs.webkit.org/show_bug.cgi?id=214474

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLineBuilder.h:

LayoutTests:

• fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple-expected.html: Added.
• fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html: Added.

12:11 AM Changeset in webkit [266044] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, wrong merge resolution between r266031 and r263837
​https://bugs.webkit.org/show_bug.cgi?id=209774

r263837 is landed after r266031 is configured. OSS buildbots didn't catch this since they are using old ICU headers.

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

Aug 22, 2020:

11:06 PM Changeset in webkit [266043] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, assertion was opposite
​https://bugs.webkit.org/show_bug.cgi?id=215058

We should ensure that this is *not* zero.

• runtime/IntlObject.cpp:

(JSC::parseVariantCode):

7:27 PM Changeset in webkit [266042] by Lauro Moura

• 2 edits in trunk/LayoutTests

[WPE] Rebaseline test after r265851

Updated the Render element name.

Unreviewed test gardening.

• platform/wpe/fast/layers/video-layer-expected.txt:

6:51 PM Changeset in webkit [266041] by mmaxfield@apple.com

• 3 edits in trunk/LayoutTests

Make fast/text/letter-spacing-shaping.html more robust
​https://bugs.webkit.org/show_bug.cgi?id=215711

Unreviewed test gardening.

• fast/text/letter-spacing-shaping-expected.html:
• fast/text/letter-spacing-shaping.html:

6:15 PM Changeset in webkit [266040] by Alan Bujtas

• 6 edits
  1 move in trunk/Source/WebCore

[LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box.
​https://bugs.webkit.org/show_bug.cgi?id=214406

Reviewed by Antti Koivisto.

This is in prepartion for supporting nested lineboxes required by certain vertical alignment values.

<div>text content</div> <- This content requires only one inline box, the root linebox.
<div>nested <span><span style="vertical-align: text-top">text</span> </span>content</div> <- the content [text] is vertically
aligned with the top of the _parent element_'s font and not the root inline box.

1. Let's rename the LineBoxBuilder to InlineBox. We'll have a bunch of these.
2. Pass in the parent inline to adjustBaselineAndLineHeight (currently there's only one inline box per line, the root inline box).

• WebCore.xcodeproj/project.pbxproj:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineHeightConstraints const):

• layout/inlineformatting/InlineLineBox.h: Renamed from Source/WebCore/layout/inlineformatting/InlineLineBoxBuilder.h.

(WebCore::Layout::LineBox::Baseline::height const):
(WebCore::Layout::LineBox::logicalRect const):
(WebCore::Layout::LineBox::scrollableOverflow const):
(WebCore::Layout::LineBox::logicalLeft const):
(WebCore::Layout::LineBox::logicalRight const):
(WebCore::Layout::LineBox::logicalTop const):
(WebCore::Layout::LineBox::logicalBottom const):
(WebCore::Layout::LineBox::logicalWidth const):
(WebCore::Layout::LineBox::logicalHeight const):
(WebCore::Layout::LineBox::resetDescent):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setLogicalWidth):
(WebCore::Layout::LineBox::setScrollableOverflow):
(WebCore::Layout::LineBox::moveHorizontally):
(WebCore::Layout::LineBox::expandHorizontally):
(WebCore::Layout::LineBox::shrinkHorizontally):
(WebCore::Layout::LineBox::expandVertically):
(WebCore::Layout::LineBox::shrinkVertically):
(WebCore::Layout::LineBox::isConsideredEmpty const):
(WebCore::Layout::LineBox::setIsConsideredEmpty):
(WebCore::Layout::LineBox::setIsConsideredNonEmpty):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::setLogicalHeightIfGreater):
(WebCore::Layout::LineBox::baseline const):
(WebCore::Layout::LineBox::setBaselineOffsetIfGreater):
(WebCore::Layout::LineBox::setAscentIfGreater):
(WebCore::Layout::LineBox::setDescentIfGreater):
(WebCore::Layout::LineBox::baselineOffset const):
(WebCore::Layout::LineBox::resetBaseline):
(WebCore::Layout::LineBox::Baseline::Baseline):
(WebCore::Layout::LineBox::Baseline::setAscent):
(WebCore::Layout::LineBox::Baseline::setDescent):
(WebCore::Layout::LineBox::Baseline::reset):
(WebCore::Layout::LineBox::Baseline::ascent const):
(WebCore::Layout::LineBox::Baseline::descent const):

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::adjustBaselineAndLineHeight):
(WebCore::Layout::LineBuilder::halfLeadingMetrics):

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::lineBox const):

• layout/inlineformatting/LineLayoutContext.h:

5:26 PM Changeset in webkit [266039] by ysuzuki@apple.com

• 15 edits
  1 add in trunk

[JSC] Implement Intl Language Tag Parser
​https://bugs.webkit.org/show_bug.cgi?id=215058

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

• stress/intl-collator.js:
• stress/intl-datetimeformat.js:
• stress/intl-language-tag.js: Added.

(shouldThrow):
(shouldNotThrow):

• stress/intl-locale.js:
• stress/intl-numberformat.js:
• stress/intl-object.js:
• stress/intl-pluralrules.js:
• stress/intl-relativetimeformat.js:
• stress/string-toLocaleLowerCase.js:
• stress/string-toLocaleUpperCase.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds LanguageTagParser which performs isStructurallyValidLanguageTag[1] validation precisely.
The spec strictly defines acceptable format as language-tag and this is not the same to ICU's one and this
is even tested in test262. We should have LanguageTagParser to validate the input.

[1]: ​https://tc39.es/ecma402/#sec-isstructurallyvalidlanguagetag

• runtime/IntlLocale.cpp:

(JSC::LocaleIDBuilder::initialize):
(JSC::IntlLocale::initializeLocale):

• runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::parseVariantCode):
(JSC::convertToUnicodeSingletonIndex):
(JSC::isUnicodeExtensionAttribute):
(JSC::isUnicodeExtensionKey):
(JSC::isUnicodeExtensionTypeComponent):
(JSC::isUnicodePUExtensionValue):
(JSC::isUnicodeOtherExtensionValue):
(JSC::isUnicodeTKey):
(JSC::isUnicodeTValueComponent):
(JSC::LanguageTagParser::LanguageTagParser):
(JSC::LanguageTagParser::isEOS):
(JSC::LanguageTagParser::next):
(JSC::LanguageTagParser::parseUnicodeLocaleId):
(JSC::LanguageTagParser::parseUnicodeLanguageId):
(JSC::LanguageTagParser::parseUnicodeExtensionAfterPrefix):
(JSC::LanguageTagParser::parseTransformedExtensionAfterPrefix):
(JSC::LanguageTagParser::parseOtherExtensionAfterPrefix):
(JSC::LanguageTagParser::parsePUExtensionAfterPrefix):
(JSC::LanguageTagParser::parseExtensionsAndPUExtensions):
(JSC::isStructurallyValidLanguageTag):
(JSC::isUnicodeLanguageId):

• runtime/IntlObject.h:

3:45 PM Changeset in webkit [266038] by emilio

• 4 edits
  96 adds in trunk/LayoutTests

Import css-content tests.
​https://bugs.webkit.org/show_bug.cgi?id=215751

Reviewed by Antti Koivisto.

• resources/import-expectations.json:
• web-platform-tests/css/css-content/META.yml: Added.
• web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
• web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
• web-platform-tests/css/css-content/computed-value-expected.txt: Added.
• web-platform-tests/css/css-content/computed-value.html: Added.
• web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-alt.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
• web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
• web-platform-tests/css/css-content/element-replacement-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
• web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
• web-platform-tests/css/css-content/element-replacement.html: Added.
• web-platform-tests/css/css-content/inheritance-expected.txt: Added.
• web-platform-tests/css/css-content/inheritance.html: Added.
• web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
• web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
• web-platform-tests/css/css-content/quotes-001-expected.html: Added.
• web-platform-tests/css/css-content/quotes-001.html: Added.
• web-platform-tests/css/css-content/quotes-002-expected.html: Added.
• web-platform-tests/css/css-content/quotes-002.html: Added.
• web-platform-tests/css/css-content/quotes-003-expected.html: Added.
• web-platform-tests/css/css-content/quotes-003.html: Added.
• web-platform-tests/css/css-content/quotes-004-expected.html: Added.
• web-platform-tests/css/css-content/quotes-004.html: Added.
• web-platform-tests/css/css-content/quotes-005-expected.html: Added.
• web-platform-tests/css/css-content/quotes-005.html: Added.
• web-platform-tests/css/css-content/quotes-006-expected.html: Added.
• web-platform-tests/css/css-content/quotes-006.html: Added.
• web-platform-tests/css/css-content/quotes-007-expected.html: Added.
• web-platform-tests/css/css-content/quotes-007.html: Added.
• web-platform-tests/css/css-content/quotes-008-expected.html: Added.
• web-platform-tests/css/css-content/quotes-008.html: Added.
• web-platform-tests/css/css-content/quotes-009-expected.html: Added.
• web-platform-tests/css/css-content/quotes-009.html: Added.
• web-platform-tests/css/css-content/quotes-010-expected.html: Added.
• web-platform-tests/css/css-content/quotes-010.html: Added.
• web-platform-tests/css/css-content/quotes-011-expected.html: Added.
• web-platform-tests/css/css-content/quotes-011.html: Added.
• web-platform-tests/css/css-content/quotes-012-expected.html: Added.
• web-platform-tests/css/css-content/quotes-012.html: Added.
• web-platform-tests/css/css-content/quotes-013-expected.html: Added.
• web-platform-tests/css/css-content/quotes-013.html: Added.
• web-platform-tests/css/css-content/quotes-014-expected.html: Added.
• web-platform-tests/css/css-content/quotes-014.html: Added.
• web-platform-tests/css/css-content/quotes-015-expected.html: Added.
• web-platform-tests/css/css-content/quotes-015.html: Added.
• web-platform-tests/css/css-content/quotes-016-expected.html: Added.
• web-platform-tests/css/css-content/quotes-016.html: Added.
• web-platform-tests/css/css-content/quotes-017-expected.html: Added.
• web-platform-tests/css/css-content/quotes-017.html: Added.
• web-platform-tests/css/css-content/quotes-018-expected.html: Added.
• web-platform-tests/css/css-content/quotes-018.html: Added.
• web-platform-tests/css/css-content/quotes-019-expected.html: Added.
• web-platform-tests/css/css-content/quotes-019.html: Added.
• web-platform-tests/css/css-content/quotes-020-expected.html: Added.
• web-platform-tests/css/css-content/quotes-020.html: Added.
• web-platform-tests/css/css-content/quotes-021-expected.html: Added.
• web-platform-tests/css/css-content/quotes-021.html: Added.
• web-platform-tests/css/css-content/quotes-022-expected.html: Added.
• web-platform-tests/css/css-content/quotes-022.html: Added.
• web-platform-tests/css/css-content/quotes-023-expected.html: Added.
• web-platform-tests/css/css-content/quotes-023.html: Added.
• web-platform-tests/css/css-content/quotes-024-expected.html: Added.
• web-platform-tests/css/css-content/quotes-024.html: Added.
• web-platform-tests/css/css-content/quotes-025-expected.html: Added.
• web-platform-tests/css/css-content/quotes-025.html: Added.
• web-platform-tests/css/css-content/quotes-026-expected.html: Added.
• web-platform-tests/css/css-content/quotes-026.html: Added.
• web-platform-tests/css/css-content/quotes-027-expected.html: Added.
• web-platform-tests/css/css-content/quotes-027.html: Added.
• web-platform-tests/css/css-content/quotes-028-expected.html: Added.
• web-platform-tests/css/css-content/quotes-028.html: Added.
• web-platform-tests/css/css-content/quotes-029-expected.html: Added.
• web-platform-tests/css/css-content/quotes-029.html: Added.
• web-platform-tests/css/css-content/quotes-030-expected.html: Added.
• web-platform-tests/css/css-content/quotes-030.html: Added.
• web-platform-tests/css/css-content/quotes-031-expected.html: Added.
• web-platform-tests/css/css-content/quotes-031.html: Added.
• web-platform-tests/css/css-content/quotes-032-expected.html: Added.
• web-platform-tests/css/css-content/quotes-032.html: Added.
• web-platform-tests/css/css-content/quotes-033-expected.html: Added.
• web-platform-tests/css/css-content/quotes-033.html: Added.
• web-platform-tests/css/css-content/quotes-034-expected.html: Added.
• web-platform-tests/css/css-content/quotes-034.html: Added.
• web-platform-tests/css/css-content/resources/rect.svg: Added.
• web-platform-tests/css/css-content/resources/w3c-import.log: Added.
• web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• web-platform-tests/css/css-content/META.yml: Added.
• web-platform-tests/css/css-content/attr-case-insensitive-expected.html: Added.
• web-platform-tests/css/css-content/attr-case-insensitive.html: Added.
• web-platform-tests/css/css-content/computed-value-expected.txt: Added.
• web-platform-tests/css/css-content/computed-value.html: Added.
• web-platform-tests/css/css-content/element-replacement-alt-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-alt.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-contents-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-contents.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-none-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-display-none.html: Added.
• web-platform-tests/css/css-content/element-replacement-dynamic-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-dynamic.html: Added.
• web-platform-tests/css/css-content/element-replacement-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-image-alt-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-image-alt.html: Added.
• web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative-expected.html: Added.
• web-platform-tests/css/css-content/element-replacement-on-replaced-element.tentative.html: Added.
• web-platform-tests/css/css-content/element-replacement.html: Added.
• web-platform-tests/css/css-content/inheritance-expected.txt: Added.
• web-platform-tests/css/css-content/inheritance.html: Added.
• web-platform-tests/css/css-content/pseudo-element-inline-box-expected.html: Added.
• web-platform-tests/css/css-content/pseudo-element-inline-box.html: Added.
• web-platform-tests/css/css-content/quotes-001-expected.html: Added.
• web-platform-tests/css/css-content/quotes-001.html: Added.
• web-platform-tests/css/css-content/quotes-002-expected.html: Added.
• web-platform-tests/css/css-content/quotes-002.html: Added.
• web-platform-tests/css/css-content/quotes-003-expected.html: Added.
• web-platform-tests/css/css-content/quotes-003.html: Added.
• web-platform-tests/css/css-content/quotes-004-expected.html: Added.
• web-platform-tests/css/css-content/quotes-004.html: Added.
• web-platform-tests/css/css-content/quotes-005-expected.html: Added.
• web-platform-tests/css/css-content/quotes-005.html: Added.
• web-platform-tests/css/css-content/quotes-006-expected.html: Added.
• web-platform-tests/css/css-content/quotes-006.html: Added.
• web-platform-tests/css/css-content/quotes-007-expected.html: Added.
• web-platform-tests/css/css-content/quotes-007.html: Added.
• web-platform-tests/css/css-content/quotes-008-expected.html: Added.
• web-platform-tests/css/css-content/quotes-008.html: Added.
• web-platform-tests/css/css-content/quotes-009-expected.html: Added.
• web-platform-tests/css/css-content/quotes-009.html: Added.
• web-platform-tests/css/css-content/quotes-010-expected.html: Added.
• web-platform-tests/css/css-content/quotes-010.html: Added.
• web-platform-tests/css/css-content/quotes-011-expected.html: Added.
• web-platform-tests/css/css-content/quotes-011.html: Added.
• web-platform-tests/css/css-content/quotes-012-expected.html: Added.
• web-platform-tests/css/css-content/quotes-012.html: Added.
• web-platform-tests/css/css-content/quotes-013-expected.html: Added.
• web-platform-tests/css/css-content/quotes-013.html: Added.
• web-platform-tests/css/css-content/quotes-014-expected.html: Added.
• web-platform-tests/css/css-content/quotes-014.html: Added.
• web-platform-tests/css/css-content/quotes-015-expected.html: Added.
• web-platform-tests/css/css-content/quotes-015.html: Added.
• web-platform-tests/css/css-content/quotes-016-expected.html: Added.
• web-platform-tests/css/css-content/quotes-016.html: Added.
• web-platform-tests/css/css-content/quotes-017-expected.html: Added.
• web-platform-tests/css/css-content/quotes-017.html: Added.
• web-platform-tests/css/css-content/quotes-018-expected.html: Added.
• web-platform-tests/css/css-content/quotes-018.html: Added.
• web-platform-tests/css/css-content/quotes-019-expected.html: Added.
• web-platform-tests/css/css-content/quotes-019.html: Added.
• web-platform-tests/css/css-content/quotes-020-expected.html: Added.
• web-platform-tests/css/css-content/quotes-020.html: Added.
• web-platform-tests/css/css-content/quotes-021-expected.html: Added.
• web-platform-tests/css/css-content/quotes-021.html: Added.
• web-platform-tests/css/css-content/quotes-022-expected.html: Added.
• web-platform-tests/css/css-content/quotes-022.html: Added.
• web-platform-tests/css/css-content/quotes-023-expected.html: Added.
• web-platform-tests/css/css-content/quotes-023.html: Added.
• web-platform-tests/css/css-content/quotes-024-expected.html: Added.
• web-platform-tests/css/css-content/quotes-024.html: Added.
• web-platform-tests/css/css-content/quotes-025-expected.html: Added.
• web-platform-tests/css/css-content/quotes-025.html: Added.
• web-platform-tests/css/css-content/quotes-026-expected.html: Added.
• web-platform-tests/css/css-content/quotes-026.html: Added.
• web-platform-tests/css/css-content/quotes-027-expected.html: Added.
• web-platform-tests/css/css-content/quotes-027.html: Added.
• web-platform-tests/css/css-content/quotes-028-expected.html: Added.
• web-platform-tests/css/css-content/quotes-028.html: Added.
• web-platform-tests/css/css-content/quotes-029-expected.html: Added.
• web-platform-tests/css/css-content/quotes-029.html: Added.
• web-platform-tests/css/css-content/quotes-030-expected.html: Added.
• web-platform-tests/css/css-content/quotes-030.html: Added.
• web-platform-tests/css/css-content/quotes-031-expected.html: Added.
• web-platform-tests/css/css-content/quotes-031.html: Added.
• web-platform-tests/css/css-content/quotes-032-expected.html: Added.
• web-platform-tests/css/css-content/quotes-032.html: Added.
• web-platform-tests/css/css-content/quotes-033-expected.html: Added.
• web-platform-tests/css/css-content/quotes-033.html: Added.
• web-platform-tests/css/css-content/quotes-034-expected.html: Added.
• web-platform-tests/css/css-content/quotes-034.html: Added.
• web-platform-tests/css/css-content/resources/rect.svg: Added.
• web-platform-tests/css/css-content/resources/w3c-import.log: Added.
• web-platform-tests/css/css-content/w3c-import.log: Added.

LayoutTests:

• TestExpectations:

3:34 PM Changeset in webkit [266037] by ysuzuki@apple.com

• 5 edits in trunk

Unreviewed, workaround for old ICU headers in macOS Catalina bots
​https://bugs.webkit.org/show_bug.cgi?id=209774

EWS and Catalina bots are inconsistent in terms of ICU header versions.
This patch adds a workaround which checks ICU header version too at runtime.

JSTests:

• stress/intl-numberformat-unified-ja.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

• stress/intl-numberformat-unified.js:

(vm.icuVersion.64.vm.icuHeaderVersion):
(vm.icuVersion): Deleted.

Source/JavaScriptCore:

• tools/JSDollarVM.cpp:

(JSC::functionICUHeaderVersion):
(JSC::JSDollarVM::finishCreation):

3:25 PM Changeset in webkit [266036] by Alexey Shvayka

• 4 edits in trunk

The ThrowTypeError? function object must not be extensible
​https://bugs.webkit.org/show_bug.cgi?id=108873

Reviewed by Yusuke Suzuki.

JSTests:

• test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This patch:

1. Sets the value of %ThrowTypeError% "name" property to the empty string, as required [1] for anonymous built-in functions.

2. Calls JSObject::freeze() on %ThrowTypeError%, making it non-extensible and its "name" and "length" properties non-configurable to match the spec [2].

Both changes align JSC with V8 and SpiderMonkey.

[1]: ​https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects
[2]: ​https://tc39.es/ecma262/#sec-%throwtypeerror%

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

1:41 PM Changeset in webkit [266035] by ysuzuki@apple.com

• 8 edits
  3 adds in trunk

[ECMA-402] Intl.DateTimeFormat dateStyle/timeStyle missing in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=209776

Reviewed by Darin Adler and Ross Kirsling.

JSTests:

• stress/intl-date-time-format-date-time-style-basic.js: Added.

(shouldBe):
(shouldBe.o.format):

• stress/intl-date-time-format-date-time-style-hour-cycle.js: Added.

(shouldBe):
(shouldBe.o.format):

• stress/intl-date-time-style-option-consistency.js: Added.

(shouldThrow):
(value.of.Object.entries):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.DateTimeFormat dateStyle and timeStyle options. When it is specified,
we query the best date-time format with these options to ICU instead of configuring each date-time
formats.

Since ECMA402 requires enforcement of hourCycle specified from the option, even if ICU ignores that.
So, after getting the appropriate pattern from ICU, we modify this pattern and re-create UDateFormat
from the modified pattern.

• builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

• runtime/CommonIdentifiers.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::formatStyleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):

• runtime/IntlDateTimeFormat.h:

1:30 PM Changeset in webkit [266034] by ysuzuki@apple.com

• 2 edits in trunk/JSTests

Unreviewed, Catalina test262 bot is using older SDK than actual Catalina's one

We should update the bot. For now, skipping these tests.

• test262/config.yaml:

1:16 PM Changeset in webkit [266033] by ysuzuki@apple.com

• 7 edits
  3 adds in trunk

[ECMA-402] Implement Intl.DateTimeFormat.prototype.formatRange
​https://bugs.webkit.org/show_bug.cgi?id=209778

Reviewed by Ross Kirsling.

JSTests:

test262 failures are due to either of

1. formatRangeToParts is missing
2. ICU version difference

• stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js: Added.

(shouldBe):
(shouldThrow):
(vm.icuVersion):

• stress/intl-datetimeformat-formatrange-relevant-extensions.js: Added.

(shouldBe):
(shouldThrow):

• stress/intl-datetimeformat-formatrange.js: Added.

(shouldBe):
(shouldThrow):
(test):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds Intl.DateTimeFormat#formatRange. It takes two dates, and
generates formatted text which represents interval between these two dates.
We skip the implementation of Intl.DateTimeFormat#formatRangeToParts since
ICU udtitvfmt_formatToResult API is not getting stable state yet. We retrieve
pattern from UDateFormat, get skeleton from that pattern, and construct
UDateIntervalFormat from this skeleton.

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):
(JSC::IntlDateTimeFormat::formatRange):
(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeFuncFormatRange):

12:22 PM Changeset in webkit [266032] by ysuzuki@apple.com

• 21 edits
  15 adds in trunk

[JSC] Add Intl.Segmenter
​https://bugs.webkit.org/show_bug.cgi?id=213638

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-segmenter.js: Added.

(shouldBe):
(shouldNotThrow):
(func):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements Intl.Segmenter[1]. Intl.Segmenter offers access to ICU break iterator feature, which can break strings into grapheme cluster / words / sentences.

[1]: ​https://github.com/tc39/proposal-intl-segmenter

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• runtime/CommonIdentifiers.h:
• runtime/IntlObject.cpp:

(JSC::createSegmenterConstructor):
(JSC::IntlObject::finishCreation):
(JSC::intlSegmenterAvailableLocales):

• runtime/IntlObject.h:
• runtime/IntlSegmentIterator.cpp: Added.

(JSC::IntlSegmentIterator::create):
(JSC::IntlSegmentIterator::createStructure):
(JSC::IntlSegmentIterator::IntlSegmentIterator):
(JSC::IntlSegmentIterator::finishCreation):
(JSC::IntlSegmentIterator::visitChildren):
(JSC::IntlSegmentIterator::next):

• runtime/IntlSegmentIterator.h: Added.
• runtime/IntlSegmentIteratorPrototype.cpp: Added.

(JSC::IntlSegmentIteratorPrototype::create):
(JSC::IntlSegmentIteratorPrototype::createStructure):
(JSC::IntlSegmentIteratorPrototype::IntlSegmentIteratorPrototype):
(JSC::IntlSegmentIteratorPrototype::finishCreation):
(JSC::IntlSegmentIteratorPrototypeFuncNext):

• runtime/IntlSegmentIteratorPrototype.h: Added.
• runtime/IntlSegmenter.cpp: Added.

(JSC::IntlSegmenter::create):
(JSC::IntlSegmenter::createStructure):
(JSC::IntlSegmenter::IntlSegmenter):
(JSC::IntlSegmenter::finishCreation):
(JSC::IntlSegmenter::initializeSegmenter):
(JSC::IntlSegmenter::segment const):
(JSC::IntlSegmenter::resolvedOptions const):
(JSC::IntlSegmenter::granularityString):
(JSC::IntlSegmenter::createSegmentDataObject):

• runtime/IntlSegmenter.h: Added.
• runtime/IntlSegmenterConstructor.cpp: Added.

(JSC::IntlSegmenterConstructor::create):
(JSC::IntlSegmenterConstructor::createStructure):
(JSC::IntlSegmenterConstructor::IntlSegmenterConstructor):
(JSC::IntlSegmenterConstructor::finishCreation):
(JSC::constructIntlSegmenter):
(JSC::callIntlSegmenter):
(JSC::IntlSegmenterConstructorSupportedLocalesOf):

• runtime/IntlSegmenterConstructor.h: Added.
• runtime/IntlSegmenterPrototype.cpp: Added.

(JSC::IntlSegmenterPrototype::create):
(JSC::IntlSegmenterPrototype::createStructure):
(JSC::IntlSegmenterPrototype::IntlSegmenterPrototype):
(JSC::IntlSegmenterPrototype::finishCreation):
(JSC::IntlSegmenterPrototypeFuncSegment):
(JSC::IntlSegmenterPrototypeFuncResolvedOptions):

• runtime/IntlSegmenterPrototype.h: Added.
• runtime/IntlSegments.cpp: Added.

(JSC::IntlSegments::create):
(JSC::IntlSegments::createStructure):
(JSC::IntlSegments::IntlSegments):
(JSC::IntlSegments::finishCreation):
(JSC::IntlSegments::containing):
(JSC::IntlSegments::createSegmentIterator):
(JSC::IntlSegments::visitChildren):

• runtime/IntlSegments.h: Added.
• runtime/IntlSegmentsPrototype.cpp: Added.

(JSC::IntlSegmentsPrototype::create):
(JSC::IntlSegmentsPrototype::createStructure):
(JSC::IntlSegmentsPrototype::IntlSegmentsPrototype):
(JSC::IntlSegmentsPrototype::finishCreation):
(JSC::IntlSegmentsPrototypeFuncContaining):
(JSC::IntlSegmentsPrototypeFuncIterator):

• runtime/IntlSegmentsPrototype.h: Added.
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::segmentIteratorStructure):
(JSC::JSGlobalObject::segmenterStructure):
(JSC::JSGlobalObject::segmentsStructure):

• runtime/OptionsList.h:
• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Source/WTF:

• wtf/text/WTFString.cpp:

(WTF::String::charactersWithoutNullTermination const):
(WTF::String::charactersWithNullTermination const):

• wtf/text/WTFString.h:

11:32 AM Changeset in webkit [266031] by ysuzuki@apple.com

• 17 edits
  3 adds in trunk

[ECMA-402] Implement unified Intl.NumberFormat
​https://bugs.webkit.org/show_bug.cgi?id=209774

Reviewed by Ross Kirsling and Darin Adler.

JSTests:

All test262 failures are due to old ICU version. Once ICU is updated, they will go away.

• stress/intl-numberformat-unified-ja.js: Added.

(shouldBe):
(vm.icuVersion):

• stress/intl-numberformat-unified.js: Added.

(shouldBe):
(vm.icuVersion):

• stress/intl-numberformat.js:

(testNumberFormat):
(shouldBe.testNumberFormat.Intl.NumberFormat):

• test262/config.yaml:
• test262/expectations.yaml:

Source/JavaScriptCore:

This patch implements updated Intl.NumberFormat. This update was proposed in [1], and integrated into ECMA-402 spec.
This patch adds support for missing features in the previous Intl.NumberFormat implementation. Adding "unit", "unitDisplay",
"signDisplay", "notation", and "currencySign". Then Intl.NumberFormat can now handle "unit" etc.

To support new features, we need to use UNumberFormatter which is available after ICU 64 (while it is offered in ICU 62, some
critical part are added in 64 too). So, we keep the old UNumberFormat based implementation which is used for [60, 64) since WebKit
currently supports ICU 60. Old implementation does not support new things. If ICU is 64 or later, Intl.NumberFormat starts using
UNumberFormatter, and implements all the specified features.

[1]: ​https://github.com/tc39/proposal-unified-intl-numberformat

• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/IntlCollator.cpp:

(JSC::IntlCollator::UCollatorDeleter::operator() const): Deleted.

• runtime/IntlCollator.h:
• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator() const): Deleted.

• runtime/IntlDateTimeFormat.h:
• runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::sanctionedSimpleUnitIdentifier):
(JSC::WellFormedUnit::WellFormedUnit):
(JSC::wellFormedUnitIdentifier):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::format const):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::notationString):
(JSC::IntlNumberFormat::currencySignString):
(JSC::IntlNumberFormat::unitDisplayString):
(JSC::IntlNumberFormat::compactDisplayString):
(JSC::IntlNumberFormat::signDisplayString):
(JSC::IntlNumberFormat::resolvedOptions const):
(JSC::partTypeString):
(JSC::IntlNumberFormat::formatToPartsInternal):
(JSC::IntlNumberFormat::formatToParts const):
(JSC::IntlNumberFormat::UNumberFormatDeleter::operator() const): Deleted.

• runtime/IntlNumberFormat.h:
• runtime/IntlNumberFormatInlines.h: Added.

(JSC::setNumberFormatDigitOptions):
(JSC::IntlFieldIterator::IntlFieldIterator):
(JSC::IntlFieldIterator::next):

• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions const):
(JSC::IntlPluralRules::UPluralRulesDeleter::operator() const): Deleted.
(JSC::IntlPluralRules::UNumberFormatDeleter::operator() const): Deleted.
(JSC::UEnumerationDeleter::operator() const): Deleted.

• runtime/IntlPluralRules.h:
• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::formatToParts const):
(JSC::IntlRelativeTimeFormat::URelativeDateTimeFormatterDeleter::operator() const): Deleted.
(JSC::IntlRelativeTimeFormat::UNumberFormatDeleter::operator() const): Deleted.

• runtime/IntlRelativeTimeFormat.h:
• tools/JSDollarVM.cpp:

(JSC::functionICUVersion):

11:08 AM Changeset in webkit [266030] by ysuzuki@apple.com

• 16 edits
  28 adds in trunk

Console object's @@toStringTag should be "console" instead of "Console"
​https://bugs.webkit.org/show_bug.cgi?id=215750

Reviewed by Ross Kirsling.

LayoutTests/imported/w3c:

Import ToT wpt/console tests including @@toStringTag tests.

• resources/import-expectations.json:
• web-platform-tests/console/META.yml: Added.
• web-platform-tests/console/console-is-a-namespace.any-expected.txt: Added.
• web-platform-tests/console/console-is-a-namespace.any.html: Added.
• web-platform-tests/console/console-is-a-namespace.any.js: Added.

(test):

• web-platform-tests/console/console-is-a-namespace.any.worker-expected.txt: Added.
• web-platform-tests/console/console-is-a-namespace.any.worker.html: Added.
• web-platform-tests/console/console-label-conversion.any-expected.txt: Added.
• web-platform-tests/console/console-label-conversion.any.html: Added.
• web-platform-tests/console/console-label-conversion.any.js: Added.

(const.method.of.methods.test):

• web-platform-tests/console/console-label-conversion.any.worker-expected.txt: Added.
• web-platform-tests/console/console-label-conversion.any.worker.html: Added.
• web-platform-tests/console/console-namespace-object-class-string.any-expected.txt: Added.
• web-platform-tests/console/console-namespace-object-class-string.any.html: Added.
• web-platform-tests/console/console-namespace-object-class-string.any.js: Added.

(test):
(test.t.t.add_cleanup):

• web-platform-tests/console/console-namespace-object-class-string.any.worker-expected.txt: Added.
• web-platform-tests/console/console-namespace-object-class-string.any.worker.html: Added.
• web-platform-tests/console/console-tests-historical.any-expected.txt: Added.
• web-platform-tests/console/console-tests-historical.any.html: Added.
• web-platform-tests/console/console-tests-historical.any.js: Added.

(test):

• web-platform-tests/console/console-tests-historical.any.worker-expected.txt: Added.
• web-platform-tests/console/console-tests-historical.any.worker.html: Added.
• web-platform-tests/console/idlharness.any-expected.txt: Added.
• web-platform-tests/console/idlharness.any.html: Added.
• web-platform-tests/console/idlharness.any.js: Added.
• web-platform-tests/console/idlharness.any.worker-expected.txt: Added.
• web-platform-tests/console/idlharness.any.worker.html: Added.
• web-platform-tests/console/w3c-import.log: Added.

Source/JavaScriptCore:

Use "console" instead of "Console". Now, namespace object has @@toStringTag.
​https://github.com/web-platform-tests/wpt/pull/24717

• runtime/ConsoleObject.cpp:

LayoutTests:

• fast/dom/Window/window-lookup-precedence-expected.txt:
• fast/loader/window-properties-restored-from-page-cache-expected.txt:
• http/tests/security/cross-frame-access-put-expected.txt:
• inspector/debugger/pause-for-internal-scripts-expected.txt:
• inspector/debugger/stepping/stepping-internal-scripts-expected.txt:
• js/console-expected.txt:
• js/console.html:
• platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:

10:57 AM Changeset in webkit [266029] by ysuzuki@apple.com

• 8 edits in trunk

[JSC] Enable Intl.DisplayNames
​https://bugs.webkit.org/show_bug.cgi?id=215749

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-displaynames.js:
• stress/intl-parse-unicode-subtags.js:
• stress/intl-suppored-locales-of.js:
• test262/config.yaml:

Source/JavaScriptCore:

Enable Intl.DisplayNames by default. This is already stage 4 and integrated into the spec.

• runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):

• runtime/OptionsList.h:

9:16 AM Changeset in webkit [266028] by Darin Adler

• 24 edits in trunk

Move node geometry functions from Range to RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=215677

Reviewed by Zalan Bujtas.

Source/WebCore:

Moved functions that return quads and rectangles out of Range into RenderObject.
We could find another home for them, but for now they make sense as static member
functions there since RenderObject has the non-static member functions that they
call on multiple nodes. Mostly did not change the design of these functions much,
and was careful not to change behavior at all. But did change a few things:

• Got rid of the functions that return a single unioned rectangle. Instead callers call unionRect at each call site.
• Changed the "use selection height" boolean to a BoundingRectBehavior flag.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::boundsForRects): Call unionRect(RenderObject::absoluteTextRects) instead
of Range::absoluteBoundingBox.

• dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker): Instead of passing "true", pass
"RenderObject::BoundingRectBehavior::UseSelectionHeight".

• dom/Range.cpp:

(WebCore::Range::absoluteBoundingBox const): Deleted.
(WebCore::Range::absoluteRectsForRangeInText const): Deleted.
(WebCore::Range::absoluteTextRects const): Deleted.
(WebCore::Range::getClientRects const): Call RenderObject::clientBorderAndTextRects.
(WebCore::Range::getBoundingClientRect const): Call
unionRect(RenderObject::clientBorderAndTextRects).
(WebCore::Range::borderAndTextRects const): Deleted.
(WebCore::Range::boundingRect const): Deleted.
(WebCore::Range::absoluteBoundingRect const): Deleted.

• dom/Range.h: Updated for above.

• dom/SimpleRange.cpp:

(WebCore::IntersectingNodeIterator::IntersectingNodeIterator): Fix bug affecting
empty ranges by calling enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advance): Refactor to call enforceEndInvariant.
(WebCore::IntersectingNodeIterator::advanceSkippingChildren): Ditto.
(WebCore::IntersectingNodeIterator::enforceEndInvariant): Added.

• dom/SimpleRange.h: Added enforceEndInvariant.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::getClippedVisibleTextRectangles const): Instead of
passing a useSelectionHeight boolean, pass BoundingRectBehavior.

• page/TextIndicator.cpp:

(WebCore::absoluteBoundingRectForRange): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebCore::initializeIndicator): Call RenderObject::absoluteTextRects.

• platform/graphics/GeometryUtilities.cpp:

(WebCore::unionRectIgnoringZeroRects): Added.

• platform/graphics/GeometryUtilities.h: Updated for above.

• rendering/RenderLineBreak.h: Marked a lot of functions final.

Added a default value for the absoluteQuads out argument.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect): Tweaked code style a bit.
(WebCore::RenderObject::absoluteTextQuads): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument. Also added a downcast so the
call to RenderLineBreak::absoluteQuads is a non-virtual function call.
(WebCore::absoluteRectsForRangeInText): Added.
(WebCore::RenderObject::absoluteTextRects): Replaced boolean useSelectionHeight
argument with a BoundingRectBehavior argument.
(WebCore::nodeBefore): Added.
(WebCore::borderAndTextRects): Added.
(WebCore::RenderObject::absoluteBorderAndTextRects): Added.
(WebCore::RenderObject::clientBorderAndTextRects): Added.

• rendering/RenderObject.h: Updated for above.

Source/WebKit:

• WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates const):
Call unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).
(WebKit::InjectedBundleRangeHandle::renderedImage): Call
unionRectIgnoringZeroRects(RenderObject::absoluteBorderAndTextRects).

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestEvasionRectsAboveSelection): Call
unionRect(RenderObject::absoluteTextRects).
(WebKit::WebPage::requestDocumentEditingContext): Call
unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/mac:

• DOM/DOM.mm:

(-[DOMRange boundingBox]): Call unionRect(RenderObject::absoluteTextRects).

Source/WebKitLegacy/win:

• AccessibleTextImpl.cpp:

(AccessibleText::scrollSubstringTo): Call
unionRect(RenderObject::absoluteTextRects) instead of
Range::absoluteBoundingBox.

LayoutTests:

• fast/dom/Range/scale-page-bounding-client-rect.html: Fix this test that accidentally

depended on getting rects for an empty range (the contents of a div element with no
text inside it) to instead get rects for a non-empty element (the div element, not
just its contents). Test now works correctly, but results don't need to change.

• fast/dom/Range/scale-page-client-rects.html: Ditto.

9:13 AM Changeset in webkit [266027] by Darin Adler

• 6 edits in trunk/Source/WebCore

Make some small improvements involving sorting
​https://bugs.webkit.org/show_bug.cgi?id=215617

Reviewed by Anders Carlsson.

• contentextensions/DFA.cpp:

(WebCore::ContentExtensions::printTransitions): Fixed "incomming" spelling error.

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet): Use std::stable_sort instead of std::sort
because there is no guarantee that each image has different resolution and we want
repeatable behavior when they are the same.

• page/Performance.cpp:

(WebCore::Performance::appendBufferedEntriesByType const): Removed the return
value since we don't need it any more.

• page/Performance.h: Updated for above.

• page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe): Use std::stable_sort only on the new
entries and then use std::inplace_merge. It's wasteful to re-sort the entire
array when adding entries. A little less elegant, but more efficient.

9:11 AM Changeset in webkit [266026] by Darin Adler

• 35 edits
  1 add in trunk

Create documentOrder function, start refactoring to use it instead of Range::compare functions
​https://bugs.webkit.org/show_bug.cgi?id=215551

Reviewed by Chris Dumez.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj: Make TextControlInnerElements.h Private so

we can use it from unit tests.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text const): Tweak code slightly.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedTextRange const): Always use the native
text control's idea of the selected text range. There is no need to use the
document-based range with any of these native text controls. The check before would
almost always return true, except for unusual cases, particularly combo box, which
returns false for isARIATextControl. We may want to change isARIATextControl to
return true for combo box, but it's not necessary for this fix. Without this change,
a test involving a combo box was failing because changes caused
documentBasedSelectedTextRange to no longer accidentally do the right thing.

• dom/BoundaryPoint.h: Added != and documentOrder.

• dom/Document.h: Export allocation function and constructor so we can allocate

in a unit test.

• dom/Node.cpp:

(WebCore::connectedInSameTreeScope): Renamed from areNodesConnectedInSameTreeScope.
(WebCore::Node::compareDocumentPosition): Updated for name change above.
(WebCore::depth): Changed to take a const& and to walk acrosss shadow host boundaries,
so this can be used in algorithms that are intended to work on the combined tree.
Has no effect when called on nodes that are not in a shadow tree.
(WebCore::commonInclusiveAncestorAndChildren): Refactored so this can be used by
callers that need to know the distinct ancestor children as well as the common
ancestor. Also revised it to work across shadow tree boundaries.
(WebCore::commonInclusiveAncestor): Updated to call commonInclusiveAncestorAndChildren.
(WebCore::isSiblingSubsequent): Added.
(WebCore::documentOrder): Added. Implemented using commonInclusiveAncestorAndChildren and
isSiblingSubsequent.

• dom/Node.h: Updated for above. Also added PartialOrdering class, a compatible

subset of C++20's std::partial_ordering, for return value for documentOrder.

• dom/Position.cpp:

(WebCore::Position::computeOffsetInContainerNode const): Removed clamping the
result to the length of the container node; not needed.
(WebCore::Position::previous const): Updated for name change.
(WebCore::Position::next const): Updated for name change.
(WebCore::Position::upstream const): Updated for name change.
(WebCore::Position::downstream const): Updated for name change.
(WebCore::commonInclusiveAncestor): Renamed from commonShadowIncludingAncestor
since this is now the same as the commonInclusiveAncestor that takes two nodes;
they now both take shadow trees into account.
(WebCore::makeContainerOffsetPosition): Added. Clearer way to construct
positions from containers and offsets. An alternative to makeDeprecatedLegacyPosition
for cases where we don't need the deprecated legacy behavior.
(WebCore::makeDeprecatedLegacyPosition): Renamed from createLegacyEditingPosition.
Adding the word "deprecated" to be clearer that this is not just "legacy" but also
something we are trying to get rid of. Changing from "create" to "make" because
this does not allocate memory on the heap.
(WebCore::documentOrder): Added. Still to do: more optimized implementation when
we can compare two positions without computing node offsets.

• dom/Position.h: Updated for above.

(WebCore::minOffsetForNode): Deleted.

• dom/RadioButtonGroups.cpp:

(WebCore::RadioButtonGroup::members const): Use documentOrder instead of
documentOrderComparator.

• dom/Range.cpp:

(WebCore::areRangesEqual): Rewrote to not use Position.
(WebCore::rangesOverlap): Updated for name change.
(WebCore::Range::expand): Rewrote to not use Range::start/endPosition.
(WebCore::operator<<): Deleted.

• dom/Range.h: Removed now-unused Range::start/endPosition, documentOrderComparator,

and TextStream operators.

• dom/RangeBoundaryPoint.h: Removed now-unused RangeBoundaryPoint::toPosition.

Added makeBoundaryPoint function to convert RangeBoundaryPoint into BoundaryPoint.

• dom/SimpleRange.cpp:

(WebCore::isOffsetBeforeChild): Added. For use by documentOrder.
(WebCore::documentOrder): Added.

• editing/TextIterator.cpp:

(WebCore::characterCount): Use documentOrder instead of
Range::compareBoundaryPoints.

• editing/VisiblePosition.cpp:

(WebCore::areVisiblePositionsInSameTreeScope): Updated for name change.

• editing/VisiblePosition.h: Use assignment insteed of calling clear,

to possibly prepare to get rid of Position::clear in the future.
Added a documentORder function that takes two visible positions.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted): Use
commonInclusiveAncestor instead of commonShadowIncludingAncestor.

• editing/markup.cpp:

(WebCore::serializePreservingVisualAppearanceInternal): Ditto.

• html/HTMLBodyElement.h: Export create function so it can used in unit tests.
• html/HTMLDivElement.h: Ditto.
• html/HTMLHtmlElement.h: Ditto.
• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::create): Added so it can be used in unit tests.

• html/HTMLTextAreaElement.h: Ditto. Also export the innerTextElement function

so it can be used in unit tests.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange): Use makeDeprecatedLegacyPosition directly
rather than using Range::start/endPosition. This was the only place in WebCore
still using Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good to
have it be explicit here rather than hidden inside the Range class.
(WebCore::DOMSelection::containsNode const): Added a check of containingShadowRoot.
This preserves the old behavior. Before, constructing the range resulted in
a collapsed range when the shadow tree was involved. This is a more direct way
to achieve the same result.

• page/Page.cpp:

(WebCore::replaceRanges): Use documentOrder instead of comparePositions.
Eventually we will delete comparePositions.

Source/WebKit:

• WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange rangeByExpandingToWordBoundaryByCharacters:inDirection:]):
Use makeDeprecatedLegacyPosition instead of Range::start/endPosition.
This was the only place in the WebKit framework still using
Range::start/endPosition and over time we would like to move from
makeDeprecatedLegacyPosition to makeContainerOffsetPosition, so it's good
to have it be explicit here rather than hidden inside the Range class.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebVisiblePosition.mm:

(-[DOMRange startPosition]): Rewrote to not use Range::startPosition.
(-[DOMRange endPosition]): Rewrote to not use Range::endPosition.

Source/WebKitLegacy/mac:

• WebView/WebFrame.mm:

(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
Rewrite to use makeSimpleRange and makeContainerOffsetPosition. Simplifies
the null checks. Would love to remove the function but at this time it's
still used by Apple's Mail app (albeit in a peculiar way, always passing a
constant string).

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added DocumentOrder.cpp.
• TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Added.

Relatively thorough test of three different documentOrder functions.
Could still use even more test cases involving different types of shadow trees.

7:33 AM Changeset in webkit [266025] by Philippe Normand

• 14 edits in trunk

[GTK][WPE] Compilation warnings with clang/gcc 10
​https://bugs.webkit.org/show_bug.cgi?id=215699

Reviewed by Darin Adler.

.:

• Source/cmake/WebKitCompilerFlags.cmake: Disable tautological-compare and

misleading-indentation warnings triggering false-positive when building JSC.

Source/WebCore:

• Modules/indexeddb/server/SQLiteIDBBackingStore.h: Mark class as final because its destructor is marked as such.

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseDirectory const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::sessionID const): Deleted.
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseRootDirectoryIsolatedCopy const): Deleted.

• dom/messageports/MessagePortChannelProviderImpl.h: Ditto.
• layout/Verification.cpp:

(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded): Remove spurious
matchingRuns assignment. I have no idea how this was supposed to work?

• platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): Use FALLTHROUGH macro.

• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decodeFrame): Ditto.

Source/WebKit:

• UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Use null input touch event enum value for touch event handling.

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Wrap m_geometry private field in GTK

ifdefs, this is not used in WPE.

• WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowFrame): Return rect built with explicit initializers.

• wpe/backends/WindowViewBackend.cpp: Supply additional touch client callbacks, mandated by the interface.

6:25 AM Changeset in webkit [266024] by Lauro Moura

• 2 edits in trunk/Tools

Unreviewed, reverting r266012.

Fix API tests after r266020

Reverted changeset:

"[GLIB] Update checked exception after r265942"
​https://bugs.webkit.org/show_bug.cgi?id=215738
​https://trac.webkit.org/changeset/266012

1:27 AM Changeset in webkit [266023] by ysuzuki@apple.com

• 2 edits in trunk/Tools

Unreviewed, add slackId to my contributors.json entry

Slack allows multiple users having the same name. How to identify one user in slack is using Slack member ID.
Try setting a slackId and leverage it via WKR / WebKitBot.

• Scripts/webkitpy/common/config/contributors.json: