Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 3, 2020:

11:10 PM Changeset in webkit [266579] by rniwa@webkit.org

• 2 edits in trunk/Source/WTF

GTK+ build fix attempt after r266573.

• wtf/CompactUniquePtrTuple.h:

10:58 PM Changeset in webkit [266578] by rniwa@webkit.org

• 6 edits in trunk/Source/WebCore

Store all styling flags in m_rendererWithStyleFlags
​https://bugs.webkit.org/show_bug.cgi?id=216069

Reviewed by Darin Adler.

This patch moves all remaining styling flags and Style::Validity from m_nodeFlags
to m_rendererWithStyleFlags since CSS JIT no longer rely on these flags directly
and CompactPointerTuple has been expanded to store up to 16 bits of data as opposed
to just 8 bits.

No new tests since there should be no behavioral change.

• dom/ContainerNode.h:

(WebCore::ContainerNode::directChildNeedsStyleRecalc const):
(WebCore::ContainerNode::setDirectChildNeedsStyleRecalc):

• dom/Element.cpp:

(WebCore::Element::resetStyleRelations):

• dom/Element.h:

(WebCore::Element::styleAffectedByEmpty const):
(WebCore::Element::descendantsAffectedByPreviousSibling const):
(WebCore::Element::childrenAffectedByFirstChildRules const):
(WebCore::Element::childrenAffectedByLastChildRules const):
(WebCore::Element::childrenAffectedByForwardPositionalRules const):
(WebCore::Element::descendantsAffectedByForwardPositionalRules const):
(WebCore::Element::childrenAffectedByBackwardPositionalRules const):
(WebCore::Element::descendantsAffectedByBackwardPositionalRules const):
(WebCore::Element::childrenAffectedByPropertyBasedBackwardPositionalRules const):
(WebCore::Element::affectsNextSiblingElementStyle const):
(WebCore::Element::styleIsAffectedByPreviousSibling const): Moved here from Node.
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::setDescendantsAffectedByPreviousSibling):
(WebCore::Element::setChildrenAffectedByFirstChildRules):
(WebCore::Element::setChildrenAffectedByLastChildRules):
(WebCore::Element::setChildrenAffectedByForwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByForwardPositionalRules):
(WebCore::Element::setChildrenAffectedByBackwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByBackwardPositionalRules):
(WebCore::Element::setChildrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::Element::setAffectsNextSiblingElementStyle):
(WebCore::Element::setStyleIsAffectedByPreviousSibling):

• dom/Node.cpp:

(WebCore::Node::adjustStyleValidity):

• dom/Node.h:

(WebCore::Node::styleValidity const):
(WebCore::Node::styleResolutionShouldRecompositeLayer const):
(WebCore::Node::childNeedsStyleRecalc const):
(WebCore::Node::styleIsAffectedByPreviousSibling const): Moved to Element.
(WebCore::Node::setChildNeedsStyleRecalc):
(WebCore::Node::flagChildrenAffectedByFirstChildRulesFlag): Deleted.
(WebCore::Node::flagChildrenAffectedByLastChildRulesFlag): Deleted.
(WebCore::Node::flagAffectsNextSiblingElementStyle): Deleted.
(WebCore::Node::flagStyleIsAffectedByPreviousSibling): Deleted.
(WebCore::Node::NodeStyleFlag): Added. Moved most of flags from m_nodeFlags here.
(WebCore::Node::DynamicStyleRelationFlag): Renamed from ElementStyleFlag.
(WebCore::Node::StyleBitfields): Added. A helper struct to read and manipulate
bit-fields stored in m_rendererWithStyleFlags.
(WebCore::Node::StyleBitfields::fromRaw): Added.
(WebCore::Node::StyleBitfields::toRaw): Added.
(WebCore::Node::StyleBitfields::styleValidity const): Added.
(WebCore::Node::StyleBitfields::setStyleValidity): Added.
(WebCore::Node::StyleBitfields::dynamicStyleRelations const): Added.
(WebCore::Node::StyleBitfields::setDynamicStyleRelation): Added.
(WebCore::Node::StyleBitfields::clearDynamicStyleRelations): Added.
(WebCore::Node::StyleBitfields::flags const): Added.
(WebCore::Node::StyleBitfields::setFlag): Added.
(WebCore::Node::StyleBitfields::clearFlag): Added.
(WebCore::Node::StyleBitfields::clearDescendantsNeedStyleResolution): Added.
(WebCore::Node::styleBitfields const): Added.
(WebCore::Node::setStyleBitfields): Added.
(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags): Deleted.
(WebCore::Node::hasDynamicStyleRelationFlag const): Added.
(WebCore::Node::setHasValidStyle): Moved here from the class declaration.
(WebCore::Node::setDynamicStyleRelationFlag): Added.
(WebCore::Node::clearChildNeedsStyleRecalc): Added.
(WebCore::Node::setHasValidStyle):

10:19 PM Changeset in webkit [266577] by Carlos Garcia Campos

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. [GLIB] Add missing return

There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.

• API/glib/JSCValue.cpp:

(jsc_value_object_invoke_methodv):

10:13 PM Changeset in webkit [266576] by Carlos Garcia Campos

• 14 edits in trunk

[GTK] Unexpected User-Agent on redirect
​https://bugs.webkit.org/show_bug.cgi?id=191858

Reviewed by Youenn Fablet.

Source/WebKit:

Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the
quirks if needed. Also ensure quirks are applied for downloads started in the UI process.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request.

• UIProcess/API/glib/WebKitDownloadClient.cpp:
• UIProcess/WebPageProxy.h: Add userAgentForURL().
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent().

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/playstation/WebPageProxyPlayStation.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

• UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

Tools:

Add unit tests to check the user agent is sent in headers and preserved after a redirect for both main resource
and subresources.

• TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(serverCallback):
(testDownloadUserAgent):
(beforeAll):

• TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(testUserAgent):
(serverCallback):
(beforeAll):

8:07 PM Changeset in webkit [266575] by Chris Dumez

• 13 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky Web Audio tests.

• web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

8:03 PM Changeset in webkit [266574] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Catalina debug wk2 ] html5lib/generated/run-template-data.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=216164

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

8:01 PM Changeset in webkit [266573] by rniwa@webkit.org

• 6 edits
  2 adds in trunk

Add CompactUniquePtrTuple
​https://bugs.webkit.org/show_bug.cgi?id=215936

Reviewed by Darin Adler.

Source/WTF:

Added a new template class, CompactUniquePtrTuple, which stores a pointer and up to 16-bits of
a POD type using CompactPointerTuple.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/CompactUniquePtrTuple.h: Added.

(WTF::makeCompactUniquePtr): Added. Like makeUnique, creates an object of the specified type
and returns CompactUniquePtrTuple.
(WTF::CompactUniquePtrTuple): Added.
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Move constructor.
(WTF::CompactUniquePtrTuple::~CompactUniquePtrTuple):
(WTF::CompactUniquePtrTuple::operator=):
(WTF::CompactUniquePtrTuple::pointer):
(WTF::CompactUniquePtrTuple::moveToUniquePtr): Clears this pointer and returns unique_ptr.
(WTF::CompactUniquePtrTuple::setPointer): Like CompactPointerTuple sets the pointer component
of this tuple, freeing the old object if there is already one stored.
(WTF::CompactUniquePtrTuple::type):
(WTF::CompactUniquePtrTuple::setType):
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Constructor which takes unique_ptr&&.
(WTF::CompactUniquePtrTuple::deletePointer):

Tools:

Added basic unit tests for CompactUniquePtrTuple.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp: Added.

(TestWebKitAPI::A): Adde.
(TestWebKitAPI::A::A):
(TestWebKitAPI::A::~A):
(WTF_CompactUniquePtrTuple.Basic):

8:01 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:59 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:59 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:49 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:40 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:33 PM Changeset in webkit [266572] by Hector Lopez

• 1 edit
  2 deletes in trunk/LayoutTests

Correction for Rebasline at changeset ​https://trac.webkit.org/changeset/266500/webkit

Unreviewed test gardening.

• platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
• platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt: Removed.

7:33 PM Changeset in webkit [266571] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, fix debug build after r266570.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

7:07 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:00 PM Changeset in webkit [266570] by Chris Dumez

• 9 edits in trunk

Tests using OscillatorNode are flaky
​https://bugs.webkit.org/show_bug.cgi?id=216152

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

Source/WebCore:

OscillatorNode was caching the different kind of PeriodicWaves in global static
variables. However, the PeriodicWaves are specific to a given sample rate.
As a result, we would sometimes use a cached periodic wave that was using the
wrong sample rate, leading to flaky failures. To address the issue, we now
cache the periodic waves per audio context instead.

No new tests, rebaselined existing tests and unskip them.

• Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

• Modules/webaudio/BaseAudioContext.h:
• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::setType):

• Modules/webaudio/OscillatorNode.h:

6:56 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM Changeset in webkit [266569] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=216162

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

6:52 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:51 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:11 PM Changeset in webkit [266568] by commit-queue@webkit.org

• 10 edits
  5 adds in trunk

Web Inspector fails to preview response from XHR requests
​https://bugs.webkit.org/show_bug.cgi?id=215852

Patch by Patrick Angle <Patrick Angle> on 2020-09-03
Reviewed by Devin Rousso.

Source/WebCore:

Test: http/tests/inspector/network/fetch-response-body.html

Added workaround for 304 XHR/Fetch requests so that the mimeType and content are correctly set, otherwise the
frontend does not have the information it needs to preview the response.

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived): Storing new ResourceData members
(WebCore::NetworkResourcesData::dataForURL): Support for finding a previous non-304 response for a URL.

• inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::httpStatusText const):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusText):
(WebCore::NetworkResourcesData::ResourceData::mimeType const):
(WebCore::NetworkResourcesData::ResourceData::setMIMEType):
(WebCore::NetworkResourcesData::ResourceData::responseTimestamp const):
(WebCore::NetworkResourcesData::ResourceData::setResponseTimestamp):

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::willSendRequest): Fixed issue where it was possible that we would inform the

frontend that a request was of type Other even though we had request information indicating it was XHR
or Fetch.

(WebCore::InspectorNetworkAgent::didReceiveResponse): Added code path to work around underlying issue where

XHR/Fetch 304s are not cached, and end up not passing necessary information to the frontend as a result.

Source/WebInspectorUI:

Responses with a no content error and a status code of 304 now show a Resource has no cached content message instead

of a generic error. Also responses with empty content and no mime type now show a Resource has no content
message.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Models/Resource.js: More consistant error handling model - previously some paths rejected on

failure and some resolved with an error property.

(WI.Resource.prototype.requestContent):
(WI.Resource.prototype._requestContentFailure):

• UserInterface/Views/ResourceContentView.js: Error messages

(WI.ResourceContentView.prototype.async showGenericNoContentMessage): Text now consistent with other messages.
(WI.ResourceContentView.prototype.showNoCachedContentMessage):
(WI.ResourceContentView.prototype._contentAvailable):

LayoutTests:

Added new test cases and associated resources to test handling of 304 Not Modified responses to XHR requests.
We test both XHR for a PHP page as well as for a text file, as they behaved differently (incorrectly) before
this patch.

• http/tests/inspector/network/fetch-response-body-304-expected.txt:
• http/tests/inspector/network/fetch-response-body-304.html:
• http/tests/inspector/network/resources/.htaccess: Cache-Control header for fetch-cachable.txt
• http/tests/inspector/network/resources/fetch-cachable.php:
• http/tests/inspector/network/resources/fetch-cachable.txt:
• platform/mac-wk1/TestExpectations: Tests rely on disk-cache which is not present in WK1

6:03 PM Changeset in webkit [266567] by ysuzuki@apple.com

• 15 edits
  2 moves
  9 adds in trunk

[JSC] Cache toString / valueOf / @@toPrimitive for major cases
​https://bugs.webkit.org/show_bug.cgi?id=216061

Reviewed by Saam Barati.

JSTests:

• stress/delete-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/delete-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/delete-cached-value-of-property.js: Added.

(shouldBe):
(shouldThrow):
(object.proto.valueOf):

• stress/hide-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/hide-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/hide-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

• stress/replace-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

• stress/replace-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

• stress/replace-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

Source/JavaScriptCore:

When toPrimitive is called, we need to look-up three properties at most to perform operation. And these special properties do not have caching mechanism at all.
We found that Speedometer2/EmberJS-Debug-TodoMVC is using very much time for this property look-up. We should have caching mechanism in StructureRareData, which
should be similar to @@toStringTag & Object#toString caching mechanism.

This patch generalizes @@toStringTag & Object#toString caching mechanism as SpecialPropertyCache. And we accelerate toString / valueOf / @@toPrimitive look-ups in
toPrimitive with this caching mechanism.

This patch improved Speedometer2/EmberJS-Debug-TodoMVC by 10%.

• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• bytecode/Watchpoint.cpp:
• bytecode/Watchpoint.h:
• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp.

(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::CachedSpecialPropertyAdaptiveStructureWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::fireInternal):

• runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.h: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.h.
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::objectProtoToStringFunction const):

• runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::toPrimitive const):

• runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):
(JSC::objectProtoFuncToString):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::cacheSpecialProperty):
(JSC::Structure::setObjectToStringValue): Deleted.

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):
(JSC::StructureRareData::ensureSpecialPropertyCacheSlow):
(JSC::StructureRareData::giveUpOnSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialPropertySlow):
(JSC::StructureRareData::clearCachedSpecialProperty):
(JSC::StructureRareData::finalizeUnconditionally):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid const):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::handleFire):
(JSC::StructureRareData::setObjectToStringValue): Deleted.
(JSC::StructureRareData::clearObjectToStringValue): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::isValid const): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire): Deleted.

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedSpecialProperty const):
(JSC::StructureRareData::canCacheSpecialProperty):
(JSC::StructureRareData::ensureSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialProperty):
(JSC::StructureRareData::objectToStringValue const): Deleted.

6:02 PM Changeset in webkit [266566] by Hector Lopez

• 1 edit in trunk/LayoutTests/ChangeLog

REGRESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

5:59 PM Changeset in webkit [266565] by Hector Lopez

• 2 edits in trunk/LayoutTests

RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

5:58 PM Changeset in webkit [266564] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure.
​https://bugs.webkit.org/show_bug.cgi?id=207267

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:43 PM Changeset in webkit [266563] by Hector Lopez

• 3 edits in trunk/LayoutTests

REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216159

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

5:13 PM Changeset in webkit [266562] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216155

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:00 PM Changeset in webkit [266561] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216156

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

3:47 PM Changeset in webkit [266560] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together
​https://bugs.webkit.org/show_bug.cgi?id=216087

Reviewed by Tadeu Zagallo.

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions):

2:43 PM Changeset in webkit [266559] by Chris Dumez

• 23 edits in trunk

AudioDestinationNode.maxChannelCount always returns 0
​https://bugs.webkit.org/show_bug.cgi?id=216127

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt:

Source/WebCore:

Update AudioDestinationNode.maxChannelCount to return a sane value on both macOS
and iOS. Also make sure the proper exceptions are thrown when trying to create
an AudioNode with an invalid number of channels.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioDestinationNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::setChannelCount):

• Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::setChannelCount):

• platform/audio/AudioSession.cpp:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

• platform/audio/AudioSession.h:
• platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::maxChannelCount):

• platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

2:42 PM Changeset in webkit [266558] by Chris Dumez

• 4 edits in trunk

Make AudioParam.cancelScheduledValues() standards compliant
​https://bugs.webkit.org/show_bug.cgi?id=216132

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:

Source/WebCore:

Align our implementation of AudioParam.cancelScheduledValues() with Chromium's
to give us a few more passes on WPT tests. In particular, this adds special
handling for when the cancelTime lands in the middle of a SetValueCurve event.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::cancelScheduledValues):

2:38 PM Changeset in webkit [266557] by Darin Adler

• 76 edits in trunk/Source

Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
​https://bugs.webkit.org/show_bug.cgi?id=216102

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::characterOffsetForTextMarkerData): Use Affinity.

• accessibility/AXObjectCache.h: Ditto.
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::performTextOperation): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions const): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForRange const): Ditto.
(WebCore::AccessibilityObject::replaceTextInRange): Ditto.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const): Removed unneeded
call to Position::equal, simplified code.
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const): Use Affinity.
(WebCore::AccessibilityRenderObject::visiblePositionForIndex const): Ditto.
(WebCore::AccessibilityRenderObject::doAXRangeForLine const): Ditto.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Use Affinity.
(wordAtPositionForAtkBoundary): Ditto.
(sentenceAtPositionForAtkBoundary): Ditto.
(lineAtPositionForAtkBoundary): Ditto.

• accessibility/atk/WebKitAccessibleUtil.cpp:

(objectFocusedAndCaretOffsetUnignored): Rely on default affinity.

• dom/Element.cpp:

(WebCore::Element::updateFocusAppearance): Rely on default affinity.

• dom/Position.cpp:

(WebCore::Position::previousCharacterPosition const): Use Affinity.
(WebCore::Position::nextCharacterPosition const): Ditto.
(WebCore::Position::leadingWhitespacePosition const): Ditto.
(WebCore::Position::trailingWhitespacePosition const): Ditto.
(WebCore::Position::inlineBoxAndOffset const): Ditto.

• editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::formatSelection): Ditto.

• editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply): Ditto.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones): Rely on default affinity.
(WebCore::CompositeEditCommand::moveParagraphs): Ditto.

• editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Use Affinity.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers): Ditto.
(WebCore::DeleteSelectionCommand::doApply): Ditto.

• editing/Editing.cpp:

(WebCore::firstInSpecialElement): Rely on default affinity.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::visiblePositionBeforeNode): Ditto.
(WebCore::visiblePositionAfterNode): Ditto.
(WebCore::visiblePositionForIndexUsingCharacterIterator): Use Affinity.

• editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Use Affinity.
(WebCore::Editor::canDeleteRange const): Rely on default affinity.
(WebCore::Editor::applyStyle): Use isNone and isCaret.
(WebCore::Editor::applyParagraphStyle): Ditto.
(WebCore::Editor::setComposition): Use Affinity.
(WebCore::Editor::advanceToNextMisspelling): Rely on default affinity.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
(WebCore::Editor::markAndReplaceFor): Ditto. Use isCaret.
(WebCore::Editor::transpose): Rely on default affinity.
(WebCore::Editor::insertTextPlaceholder): Ditto.
(WebCore::Editor::removeTextPlaceholder): Ditto.
(WebCore::Editor::firstRectForRange const): Ditto. Also simplify
rectangle calculation at the end of the function.
(WebCore::Editor::shouldChangeSelection const): Use Affinity.
(WebCore::Editor::findString): Rely on default affinity.

• editing/Editor.h: Use Affinity.
• editing/EditorCommand.cpp:

(WebCore::executeDeleteToMark): Ditto.
(WebCore::executeSelectToMark): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo): Ditto.
(WebCore::FrameSelection::modify): Ditto.
(WebCore::FrameSelection::setBase): Ditto.
(WebCore::FrameSelection::setExtent): Ditto.
(WebCore::FrameSelection::setSelectedRange): Ditto.
(WebCore::FrameSelection::revealSelection): Use isNone and isCaret.
(WebCore::FrameSelection::setSelectionFromNone): Rely on default affinity.
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection): Ditto.

• editing/FrameSelection.h: Use Affinity.

• editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentRegion): Rely on default affinity.

• editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply): Use Affinity.

• editing/InsertNestedListCommand.cpp:

(WebCore::InsertNestedListCommand::doApply): Ditto.

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Use Affinity.

• editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab): Rely on default affinity.

• editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition): Use Affinity.

• editing/RenderedPosition.h: Ditto.

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Rely on default affinity.
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
Use VisibleSelection::defaultAffinity.

• editing/TextAffinity.h: Removed EAffinity, UPSTREAM, DOWNSTREAM.

• editing/TextIterator.cpp:

(WebCore::TextIterator::shouldRepresentNodeOffsetZero): Rely on
default affinity.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty): Use Affinity.
(WebCore::TypingCommand::deleteKeyPressed): Use isCaretOrRange and isRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use Affinity.
(WebCore::VisiblePosition::previous const): Rely on default affinity.
(WebCore::VisiblePosition::left const): Ditto.
(WebCore::VisiblePosition::right const): Ditto.
(WebCore::operator<<): Use Affinity.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection): Use Affinity. Also use
initialize in the class definition.
(WebCore::VisibleSelection::selectionFromContentsOfNode): Rely on
default affinity.
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
Rename from "pos" to "position".
(WebCore::VisibleSelection::updateSelectionType): Update from
m_selectionType to m_type and use Affinity.
(WebCore::VisibleSelection::validate): Use isRange.
(WebCore::VisibleSelection::setWithoutValidation): Use Affinity and
m_type.

• editing/VisibleSelection.h: Removed SEL_DEFAULT_AFFINITY, replacing

it with VisibleSelection::defaultAffinity. Removed both
VisibleSelection::SelectionType and VisibleSelection::selectionType,
replacing with private VisibleSelection::Type. Also renamed
m_selectionType to m_type.

• editing/VisibleUnits.cpp:

(WebCore::logicallyPreviousBox): Use Affinity.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Rely on default affinity.
(WebCore::nextLinePosition): Ditto.
(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.
(WebCore::withinTextUnitOfGranularity): Use Affinity.
(WebCore::enclosingTextUnitOfGranularity): Ditto.

• editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeAtHitTestResult): Use isRange.

• loader/EmptyClients.cpp: Use Affinity.
• page/DOMSelection.cpp:

(WebCore::DOMSelection::collapse): Ditto.
(WebCore::DOMSelection::collapseToEnd): Ditto.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::setBaseAndExtent): Ditto.
(WebCore::DOMSelection::setPosition): Ditto.
(WebCore::DOMSelection::extend): Ditto.

• page/EditorClient.h: Ditto.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
Rely on default affinity.

• page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):
Use constructor that takes a single Position and Affinity.

• page/Page.cpp:

(WebCore::replaceRanges): Use Affinity.

• page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use isNone.

• rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries): Use Affinity.
(WebCore::RenderBlock::positionForPoint): Ditto.

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPointWithInlineChildren): Ditto.

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::positionForPoint): Ditto.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::positionForPoint): Ditto.
(WebCore::RenderObject::createVisiblePosition const): Ditto.

• rendering/RenderObject.h: Ditto.
• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.

• rendering/RenderTreeAsText.cpp:

(WebCore::writeSelection): Ditto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint): Ditto.

Source/WebKit:

• WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:

(API::InjectedBundle::EditorClient::shouldChangeSelectedRange): Use Affinity.

• WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI): Dito.

• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Ditto.

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): Ditto.

• WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Ditto.
• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldChangeSelectedRange): Ditto.

• WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.

• WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::insertDictatedTextAsync): Rely on default affinity.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync): Ditto.
(WebKit::WebPage::setCompositionAsync): Ditto.
(WebKit::WebPage::deleteSurrounding): Ditto.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDrag): Use Affinity.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.
(WebKit::WebPage::replaceSelectedText): Ditto.
(WebKit::WebPage::replaceDictatedText): Ditto.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::updateSelectionWithDelta): Ditto.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Use Affinity.
(-[WebFrame smartExtendRangedSelection:]): Use visibleStart/End/Extent so we don't
need to write explicit code to handle affinity.

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition setAffinity:]): Use Affinity.

Source/WebKitLegacy/mac:

• DOM/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]): Rely on default affinity.

• WebCoreSupport/WebEditorClient.h:

(kit): Use Affinity.
(core): Ditto.

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldChangeSelectedRange): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame _caretRectAtPosition:affinity:]): Ditto.
(-[WebFrame _selectNSRange:]): Rely on default affinity.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use isNone.

• WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]): Rely on default affinity.

Source/WebKitLegacy/win:

• WebCoreSupport/WebEditorClient.cpp:

(toWebSelectionAffinity): Added.
(WebEditorClient::shouldChangeSelectedRange): Use Affinity.

• WebCoreSupport/WebEditorClient.h: Ditto.

2:35 PM Changeset in webkit [266556] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Unreviewed, reverting r266498.
​https://bugs.webkit.org/show_bug.cgi?id=216143

crashes in debug

Reverted changeset:

"Simplify some editing code"
​https://bugs.webkit.org/show_bug.cgi?id=216097
​https://trac.webkit.org/changeset/266498

2:31 PM Changeset in webkit [266555] by Alan Coon

• 22 edits in branches/safari-610-branch

Cherry-pick r266265. rdar://problem/68168939

[iOS] provide a way to get previously inserted alternatives for the selected text
​https://bugs.webkit.org/show_bug.cgi?id=215816
<rdar://problem/66646042>

Reviewed by Darin Adler.

Source/WebCore:

• editing/cocoa/AlternativeTextUIController.h:
• editing/cocoa/AlternativeTextUIController.mm: (WebCore::AlternativeTextUIController::alternativesForContext): Return the raw NSTextAlternatives * and let the caller create the Vector<String> if they need to so that callers that don't can use the actual NSTextAlternatives *.

• editing/Editor.h:
• editing/Editor.cpp: (WebCore::Editor::applyDictationAlternative): Added. (WebCore::Editor::applyDictationAlternativelternative): Deleted.
• page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Drive-by: fix typo.

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView alternativesForSelectedText]):

• UIProcess/WebPageProxy.h:
• UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformDictationAlternatives): Added.
• UIProcess/PageClient.h:
• UIProcess/Cocoa/PageClientImplCocoa.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::dictationAlternatives): (WebKit::PageClientImplCocoa::platformDictationAlternatives): Added. Provide a way to get the raw NSTextAlternatives * for a given WebCore::DictationContext.

• Shared/EditorState.h:
• Shared/EditorState.cpp: (WebKit::EditorState::PostLayoutData::encode const): (WebKit::EditorState::PostLayoutData::decode):
• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPlatformEditorState const): Include a Vector<WebCore::DictationContext> as part of the EditorState that contains all of the WebCore::DictationContext that exist in the currently selected range (or the range of the word containing the cursor if nothing is selected).

• Platform/spi/ios/UIKitSPI.h:

Source/WebKitLegacy/mac:

• WebView/WebView.mm: (-[WebView _dictationAlternatives:]): Create a Vector<String> from the returned NSTextAlternatives * now that the member WebCore::AlternativeTextUIController::alternativesForContext returns it.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: (InsertTextAlternatives.Simple):

• TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266554] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266218. rdar://problem/68168930

REGRESSION: touchbar controls don't reflect video state in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebPlaybackControlsManager.mm: (-[WebPlaybackControlsManager setPlaying:]): (-[WebPlaybackControlsManager isPlaying]): Create an actual ivar _playing for holding the play/pause state. This is needed because AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the related video controller (in this case AVTouchBarPlaybackControlsControlling) changes using an NSValueBinding. KVO needs an actual ivar in order to function properly.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266553] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266156. rdar://problem/68168945

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
​https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

• rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

• fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
• fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266552] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266144. rdar://problem/68168942

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
​https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266551] by Alan Coon

• 5 edits
  4 adds in branches/safari-610-branch

Cherry-pick r266158. rdar://problem/67812825

Web Share API Level 2 functions even when its experimental feature flag is disabled
​https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

• page/Navigator.cpp: (WebCore::Navigator::canShare): Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): If the Web Content process sends us files, but the Level 2 feature flag is disabled, something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

• fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/canShare-with-files-feature-disabled.html: Added.
• fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
• fast/web-share/share-with-files-feature-disabled.html: Added. Add some tests that ensure that disabling the feature actually works.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266550] by Alan Coon

• 8 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266151. rdar://problem/68168950

Web Share API can share non-HTTP(S) URLs
​https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

• page/Navigator.cpp: (WebCore::shareableURLForShareData): (WebCore::Navigator::canShare): (WebCore::Navigator::share): Factor out the code to complete and check the scheme of the URL. Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

• fast/web-share/share-disallows-file-urls-expected.txt: Added.
• fast/web-share/share-disallows-file-urls.html: Added.
• fast/web-share/share-transient-activation-expired.html:
• fast/web-share/share-transient-activation.html:
• fast/web-share/share.html: Add a test that ensures that sharing a non-HTTP-family URL fails, and fix the existing tests to share HTTP-family URLs.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266549] by Alan Coon

• 16 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266292. rdar://problem/67963525

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
​https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

• page/FrameView.cpp: (WebCore::FrameView::wheelEvent):
• page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer):
• page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent):
• page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode):
• page/scrolling/ScrollingTree.h:
• page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
• page/scrolling/ThreadedScrollingTree.h:
• page/scrolling/mac/ScrollingCoordinatorMac.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):
• page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

• fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
• fast/scrolling/latching/iframe-latch-small-deltas.html:
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
• fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266548] by Alan Coon

• 4 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266262. rdar://problem/67963581

Scrolling on select element doesn't work after scrolling the page
​https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

• page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):
• page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

• fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
• fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266547] by Alan Coon

• 7 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266248. rdar://problem/67963541

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
​https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

• editing/Editor.h:
• editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary):

See above for more details.

• testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString):
• testing/Internals.h:
• testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

• editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
• editing/mac/input/change-back-to-replaced-string.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266546] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266240. rdar://problem/67963550

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
​https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266545] by Alan Coon

• 3 edits
  3 adds in branches/safari-610-branch

Cherry-pick r266239. rdar://problem/67963562

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
​https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

• media/content/video-as-img.mp4: Added.
• media/video-as-img-output-pts-expected.txt: Added.
• media/video-as-img-output-pts.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266544] by Alan Coon

• 3 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266189. rdar://problem/68145721

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266543] by Alan Coon

• 5 edits
  1 add in branches/safari-610-branch

Cherry-pick r266159. rdar://problem/67951883

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
​https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

• stress/ftl-entry-osr-exit-has-nullptr-node.js: Added. (foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

• ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToThis): (JSC::FTL::DFG::LowerDFGToB3::compileValueAdd): (JSC::FTL::DFG::LowerDFGToB3::compileValueSub): (JSC::FTL::DFG::LowerDFGToB3::compileValueMul): (JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC): (JSC::FTL::DFG::LowerDFGToB3::compileStrCat): (JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub): (JSC::FTL::DFG::LowerDFGToB3::compileArithClz32): (JSC::FTL::DFG::LowerDFGToB3::compileValueDiv): (JSC::FTL::DFG::LowerDFGToB3::compileValueMod): (JSC::FTL::DFG::LowerDFGToB3::compileArithAbs): (JSC::FTL::DFG::LowerDFGToB3::compileArithUnary): (JSC::FTL::DFG::LowerDFGToB3::compileValuePow): (JSC::FTL::DFG::LowerDFGToB3::compileArithRandom): (JSC::FTL::DFG::LowerDFGToB3::compileArithRound): (JSC::FTL::DFG::LowerDFGToB3::compileArithFloor): (JSC::FTL::DFG::LowerDFGToB3::compileArithCeil): (JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc): (JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt): (JSC::FTL::DFG::LowerDFGToB3::compileArithFRound): (JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec): (JSC::FTL::DFG::LowerDFGToB3::compileValueNegate): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift): (JSC::FTL::DFG::LowerDFGToB3::compileGetById): (JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree): (JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty): (JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty): (JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage): (JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf): (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById): (JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteById): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPush): (JSC::FTL::DFG::LowerDFGToB3::compileArraySlice): (JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPop): (JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope): (JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileNewFunction): (JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly): (JSC::FTL::DFG::LowerDFGToB3::compileCreateRest): (JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames): (JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate): (JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol): (JSC::FTL::DFG::LowerDFGToB3::compileNewArray): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread): (JSC::FTL::DFG::LowerDFGToB3::compileCreateThis): (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileSpread): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize): (JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray): (JSC::FTL::DFG::LowerDFGToB3::compileToNumber): (JSC::FTL::DFG::LowerDFGToB3::compileToNumeric): (JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf): (JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive): (JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey): (JSC::FTL::DFG::LowerDFGToB3::compileMakeRope): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode): (JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset): (JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetArgument): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): (JSC::FTL::DFG::LowerDFGToB3::compileSameValue): (JSC::FTL::DFG::LowerDFGToB3::compileCallEval): (JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength): (JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileSwitch): (JSC::FTL::DFG::LowerDFGToB3::compileThrow): (JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError): (JSC::FTL::DFG::LowerDFGToB3::mapHashString): (JSC::FTL::DFG::LowerDFGToB3::compileMapHash): (JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket): (JSC::FTL::DFG::LowerDFGToB3::compileSetAdd): (JSC::FTL::DFG::LowerDFGToB3::compileMapSet): (JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject): (JSC::FTL::DFG::LowerDFGToB3::compileIsCallable): (JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileInByVal): (JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty): (JSC::FTL::DFG::LowerDFGToB3::compileParseInt): (JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl): (JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname): (JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator): (JSC::FTL::DFG::LowerDFGToB3::compileToIndexString): (JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps): (JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp): (JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName): (JSC::FTL::DFG::LowerDFGToB3::compileStringReplace): (JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength): (JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart): (JSC::FTL::DFG::LowerDFGToB3::compare): (JSC::FTL::DFG::LowerDFGToB3::compileStringSlice): (JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScope): (JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOM): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter): (JSC::FTL::DFG::LowerDFGToB3::compileLoopHint): (JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare): (JSC::FTL::DFG::LowerDFGToB3::stringsEqual): (JSC::FTL::DFG::LowerDFGToB3::allocateJSArray): (JSC::FTL::DFG::LowerDFGToB3::boolify): (JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined): (JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds): (JSC::FTL::DFG::LowerDFGToB3::switchStringSlow): (JSC::FTL::DFG::LowerDFGToB3::buildTypeOf): (JSC::FTL::DFG::LowerDFGToB3::lazySlowPath): (JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid): (JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const): (JSC::FTL::DFG::LowerDFGToB3::callCheck): (JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):
• jsc.cpp: (runJSC):
• runtime/OptionsList.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:04 PM Changeset in webkit [266542] by commit-queue@webkit.org

• 11 edits
  8 adds in trunk

CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia()
​https://bugs.webkit.org/show_bug.cgi?id=213673

Patch by Frank Yang <​guowei_yang@apple.com> on 2020-09-03
Reviewed by Darin Adler, Simon Fraser.

Source/WebCore:

Tests: css3/filters/effect-grayscale-square.html

css3/filters/effect-hue-rotate-square.html
css3/filters/effect-saturate-square.html
css3/filters/effect-sepia-square.html

Added CoreImage implementation of SourceGraphic and partial of FEColorMatrix,
which is used to implement sepia(), grayscale() hue-rotate() and saturate().
Also added CIFilter caching, by storing CIFilters in a hash map, where the key
is the level of traversal (an integer).

• platform/graphics/coreimage/FilterEffectRendererCoreImage.h:

Imported FEColorMatrix.h and SourceGraphic.h; added function getCIContext()
that returns a static copy of CIContext.

• platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::getCIContext): Creating a

CIContext is expensive. Instead of creating a CIContext on each frame
update, we just use a static singleton on every draw

(WebCore::FilterEffectRendererCoreImage::supportsCoreImageRendering):

the function now returns true if the filter chain contains SourceGraphic
and FEColorMatrix of TYPE_MATRIX, TYPE_SATURATE and TYPE_HUEROTATE

(WebCore::FilterEffectRendererCoreImage::connectCIFilters):

Made slight changes to wrap Obj-C pointers in RetainPtr

(WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic):

Use the source image to create a CIImage and return it. If the source image
is backed by IOSurface, we create a CIImage directly from the IOSurface; otherwise
we create a CIImage by getting the NativeImagePtr from source image.

(WebCore::FilterEffectRendererCoreImage::imageForFEColorMatrix):

Based on the type of the matrix and input parameter,
create different types of CIColorMatrix filers that are used to implement
sepia, grayscale, hue-rotate, saturate

(WebCore::FilterEffectRendererCoreImage::output const):

Added a logging line

(WebCore::FilterEffectRendererCoreImage::renderToImageBuffer):

Minor refactors

(WebCore::FilterEffectRendererCoreImage::clearResult):
(WebCore::FilterEffectRendererCoreImage::FilterEffectRendererCoreImage):

• platform/graphics/filters/FEColorMatrix.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to FEColorMatrix

• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData const): removed

ASSERT(hasResult()); from the function, because CoreImage path wouldn't create
image buffers inside FilterEffect, but CI path still needs to consult this function
to obtain geometry info

• platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filterEffectClassType const): Made the function a const
(WebCore::FilterEffect::normalizedFloats): Changed this function to public since it is

consulted in FilterEffectCoreImageRenderer.

(WebCore::FilterEffect::filterEffectClassType): Deleted.

• platform/graphics/filters/SourceGraphic.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to SourceGraphic

• rendering/CSSFilter.cpp:

(WebCore::CSSFilter::build):

Checks whether m_filterRenderer is already created, no need to re-create if the pointer
is non-null

(WebCore::CSSFilter::allocateBackingStoreIfNeeded):

If we are using m_filterRenderer, which is currently using CoreImage and relies on
IOSurfaces, we ask source image to use IOSurface for performance concerns.

LayoutTests:

• css3/filters/effect-grayscale-square-expected.html: Added.
• css3/filters/effect-grayscale-square.html: Added.
• css3/filters/effect-hue-rotate-square-expected.html: Added.
• css3/filters/effect-hue-rotate-square.html: Added.
• css3/filters/effect-saturate-square-expected.html: Added.
• css3/filters/effect-saturate-square.html: Added.
• css3/filters/effect-sepia-square-expected.html: Added.
• css3/filters/effect-sepia-square.html: Added.
• fast/filter-image/background-filter-image-expected.html:

This is the expected result for the background image filter. The background image
is not upsampled for retina screens due to a bug, so the test runner is comparing
an unscaled image with an upscaled-then-downscaled image. CoreImage handles upscaling
and downscaling differently, so the pixel diff will fail. Thus, turning off CI for this
particular test case until the background image filter not upsampling bug is fixed.

• fast/filter-image/background-filter-image.html:

ditto

1:54 PM Changeset in webkit [266541] by Chris Dumez

• 4 edits in trunk

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
​https://bugs.webkit.org/show_bug.cgi?id=216130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:

Source/WebCore:

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies.

No new tests, rebaselined existing test.

• platform/audio/Biquad.cpp:

(WebCore::Biquad::getFrequencyResponse):

1:43 PM Changeset in webkit [266540] by Lauro Moura

• 2 edits in trunk/Tools

[GTK][WPE] generate-bundle: Remove the zip extension from the uploaded checksum filename
​https://bugs.webkit.org/show_bug.cgi?id=216137

Reviewed by Jonathan Bedard.

• Scripts/generate-bundle:

1:32 PM Changeset in webkit [266539] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk

Mark uniform samplers in an array unused per element
​https://bugs.webkit.org/show_bug.cgi?id=215630

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2020-09-03
Reviewed by Dean Jackson.

Mark uniform samplers in an uniform sampler array unused per
element, if driver informs the element being unused.
Before, one element would mark the whole array as being
unused, and samplers that were in use would not be updated.

Source/ThirdParty/ANGLE:

• src/libANGLE/Context.cpp:

(gl::StateCache::updateActiveImageUnitIndices):

• src/libANGLE/Program.cpp:

(gl::SamplerBinding::SamplerBinding):
(gl::ImageBinding::ImageBinding):
(gl::Program::getSamplerUniformBinding const):
(gl::Program::getImageUniformBinding const):
(gl::Program::linkSamplerAndImageBindings):
(gl::Program::updateSamplerUniform):
(gl::Program::serialize const):
(gl::Program::deserialize):

• src/libANGLE/ProgramExecutable.cpp:

(gl::ProgramExecutable::updateActiveSamplers):
(gl::ProgramExecutable::updateActiveImages):
(gl::ProgramExecutable::setSamplerUniformTextureTypeAndFormat):

• src/libANGLE/ProgramExecutable.h:
• src/libANGLE/renderer/gl/ProgramGL.cpp:

(rx::ProgramGL::markUnusedUniformLocations):

• src/libANGLE/renderer/metal/ProgramMtl.mm:

(rx::ProgramMtl::updateTextures):

• src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp:

(rx::ProgramExecutableVk::updateImagesDescriptorSet):
(rx::ProgramExecutableVk::updateTexturesDescriptorSet):

• src/tests/gl_tests/ComputeShaderTest.cpp:
• src/tests/gl_tests/UniformTest.cpp:

LayoutTests:

• fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added.
• fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added.

1:07 PM Changeset in webkit [266538] by Devin Rousso

• 24 edits
  7 adds in trunk

Web Inspector: allow url breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215793

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/DOMDebugger.json:

Add an options parameter to DOMDebugger.setURLBreakpoint to allow configuration.
Add an isRegex parameter to DOMDebugger.removeURLBreakpoint so that we know what
type of URL breakpoint is being removed.

Source/WebCore:

Tests: inspector/dom-debugger/url-breakpoints.html

inspector/dom-debugger/url-breakpoints-all-requests.html
inspector/dom-debugger/url-breakpoints-containing.html
inspector/dom-debugger/url-breakpoints-matching.html

• inspector/agents/InspectorDOMDebuggerAgent.h:
• inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::setURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::breakOnURLIfNeeded):

Source/WebInspectorUI:

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.get editable): Added.
(WI.URLBreakpoint.fromJSON):
(WI.URLBreakpoint.prototype.get editable):

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._setURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleURLBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype._updateURLBreakpoint): Deleted.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialBreakpoint): Added.
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint): Deleted.

• UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover.get editable):

• UserInterface/Base/Setting.js:

LayoutTests:

• inspector/debugger/resources/breakpoint-options-utilities.js:

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):

• inspector/dom-debugger/resources/url-breakpoint-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.URLBreakpoint.teardown):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.addBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.request):

• inspector/dom-debugger/url-breakpoints.html:
• inspector/dom-debugger/url-breakpoints-expected.txt:
• inspector/dom-debugger/url-breakpoints-all-requests.html: Added.
• inspector/dom-debugger/url-breakpoints-all-requests-expected.txt: Added.
• inspector/dom-debugger/url-breakpoints-containing.html: Added.
• inspector/dom-debugger/url-breakpoints-containing-expected.txt: Added.
• inspector/dom-debugger/url-breakpoints-matching.html: Added.
• inspector/dom-debugger/url-breakpoints-matching-expected.txt: Added.

Split the one URL breakpoint test into four so they run quicker.

• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Deleted.

• inspector/dom-debugger/event-animation-frame-breakpoints.html:
• inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
• inspector/dom-debugger/event-interval-breakpoints.html:
• inspector/dom-debugger/event-interval-breakpoints-expected.txt:
• inspector/dom-debugger/event-listener-breakpoints.html:
• inspector/dom-debugger/event-listener-breakpoints-expected.txt:
• inspector/dom-debugger/event-timeout-breakpoints.html:
• inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Use InspectorTest.BreakpointOptions.addTestCases instead of duplicating the logic.

12:17 PM Changeset in webkit [266537] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: record button disappears when UI is narrow
​https://bugs.webkit.org/show_bug.cgi?id=216133

Reviewed by Devin Rousso.

The record button is one of the most important items on Timelines toolbar.
It should always be visible.

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):

11:42 AM Changeset in webkit [266536] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, reverting r266507.
​https://bugs.webkit.org/show_bug.cgi?id=216135

Broke JSC EWS

Reverted changeset:

"kill-old-processes: Remove stale Apache2 shm segments"
​https://bugs.webkit.org/show_bug.cgi?id=216068
​https://trac.webkit.org/changeset/266507

11:21 AM Changeset in webkit [266535] by achristensen@apple.com

• 1 edit
  1 delete in trunk/LayoutTests/imported/w3c

Remove unused test expectations file.

• web-platform-tests/encoding/textdecoder-labels-expected.txt: Removed.

10:53 AM Changeset in webkit [266534] by Devin Rousso

• 35 edits
  1 add in trunk

Web Inspector: allow special JavaScript breakpoints to be configured
​https://bugs.webkit.org/show_bug.cgi?id=215794

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/Debugger.json:

Add an options parameter to the following commands for configuring the related breakpoint:

• Debugger.setPauseOnDebuggerStatements
• Debugger.setPauseOnExceptions
• Debugger.setPauseOnAssertions
• Debugger.setPauseOnMicrotasks

• debugger/Debugger.h:

(JSC::Debugger::needsExceptionCallbacks const):
(JSC::Debugger::pauseOnAllExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnAllExceptionsBreakpoint): Added.
(JSC::Debugger::pauseOnUncaughtExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnUncaughtExceptionsBreakpoint): Added.
(JSC::Debugger::setPauseOnDebuggerStatementsBreakpoint): Added.
(JSC::Debugger::pauseOnExceptionsState const): Deleted.
(JSC::Debugger::setPauseOnDebuggerStatements): Deleted.

• debugger/Debugger.cpp:

(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::~TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::replace): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::restore): Added.
(JSC::Debugger::Debugger):
(JSC::Debugger::breakProgram):
(JSC::Debugger::exception):
(JSC::Debugger::didReachDebuggerStatement):
(JSC::Debugger::setPauseOnExceptionsState): Deleted.
Add JSC::Breakpoint member variables for the Debugger Statements and Exceptions
breakpoints. Split the Exceptions breakpoint into two JSC::Breakpoint now that
All Exceptions and Uncaught Exceptions can be independently configured (the All
Exceptions breakpoint still takes precedence).

• debugger/DebuggerCallFrame.h:
• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
If there is no CallFrame, climb the backtrace until the first valid CallFrame is reached.
This is needed when pausing in native code, such as for assertions/exceptions.

• debugger/Breakpoint.h:

Export JSC::Breakpoint::create so that other parts of WebKit can create breakpoints.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::setPauseOnDebuggerStatements):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::setPauseOnAssertions):
(Inspector::InspectorDebuggerAgent::setPauseOnMicrotasks):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::breakProgram):
Add JSC::Breakpoint member variables for the Assertion Failures and All Microtasks
breakpoints. Pass them to the JSC::Debugger when they are hit.

• inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::setPauseOnExceptionsState): Deleted.
Use TemporarilyDisableExceptionBreakpoints to save, override, and restore the exceptions
breakpoints now that they've been separated into two JSC::Breakpoint instead of an enum.

Source/WebInspectorUI:

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint.prototype.reset): Added.
Provide a way to consistently clear the current configuration.

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.supportsMicrotasks): Added.
(WI.JavaScriptBreakpoint.supportsDebuggerStatements): Added.
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get editable):
(WI.JavaScriptBreakpoint.prototype._isSpecial):

• UserInterface/Models/SourceCodeLocation.js:

(WI.SourceCodeLocation.get specialBreakpointLocation): Added.
Add a helper for the special null:Infinity:Infinity breakpoint location for consistency.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.async initializeTarget):
(WI.DebuggerManager.prototype.createAssertionFailuresBreakpoint): Added.
(WI.DebuggerManager.prototype.createAllMicrotasksBreakpoint): Added.
(WI.DebuggerManager.prototype.set breakpointsEnabled):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype._setPauseOnExceptions): Added.
(WI.DebuggerManager.prototype._createSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._updateSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._breakpointDisabledStateDidChange):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._updateBreakOnExceptionsState): Deleted.
Maintain a WI.Setting for the configuration of each special WI.JavaScriptBreakpoint.
Have a common path for updating all special WI.JavaScriptBreakpoint to avoid duplicated
code.
Add methods for creating the Assertion Failures and All Microtasks WI.JavaScriptBreakpoint
since they can be removed (in addition to being disabled) and re-added.

• UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.appendContextMenuItems):

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
If the WI.Breakpoint is not removable, make sure to reset it in addition to disabling
it so that no configuration persists if the WI.Breakpoint is later enabled.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointTreeOutlineElementRemoved): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved): Deleted.
Eliminate the need to listen for when breakpoints are added to the WI.TreeOutline, which
was previously used to update the WI.Setting for whether special WI.JavaScriptBreakpoint
are visible.
Don't assume that a WI.Breakpoint exists for each special WI.JavaScriptBreakpoint.

• UserInterface/Base/Setting.js:

(WI.Setting):
(WI.Setting.migrateValue):
(WI.Setting.reset):
(WI.Setting.prototype.get value):
(WI.Setting.prototype.save):
(WI.Setting._localStorageKeyPrefix): Added.
(WI.Setting._localStorageKey): Deleted.
Eagerly compute the key prefix as it shouldn't change through the lifetime of Web Inspector
and is used early on too.
Add a static member isFirstLaunch which can be used by other WI.Setting to adjust their
value when Web Inspector is in a clean state (e.g. show the Assertion Failures breakpoint by
default, but only for the first launch). This is needed because WI.Setting clears the key
from localStorage if the current value matches the _defaultValue.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.willRemove):
(WI.ProbeSet.prototype._sampleCollected):
(WI.ProbeSet.prototype._breakpointResolvedStateDidChange): Deleted.
Drive-by: remove an unused event.

• Localizations/en.lproj/localizedStrings.js:

Source/WebKitLegacy/mac:

• WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):

LayoutTests:

• inspector/debugger/resources/breakpoint-options-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):
(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases.removeBreakpoint):

• inspector/debugger/break-on-exception.html:
• inspector/debugger/break-on-exception-expected.txt:
• inspector/debugger/break-on-uncaught-exception.html:
• inspector/debugger/break-on-uncaught-exception-expected.txt:
• inspector/debugger/setPauseOnAssertions.html:
• inspector/debugger/setPauseOnAssertions-expected.txt:
• inspector/debugger/setPauseOnDebuggerStatements.html:
• inspector/debugger/setPauseOnDebuggerStatements-expected.txt:
• inspector/debugger/setPauseOnMicrotasks.html:
• inspector/debugger/setPauseOnMicrotasks-expected.txt:

Add tests for global JavaScript breakpoint configuration options.

10:53 AM Changeset in webkit [266533] by achristensen@apple.com

• 11 edits
  1 delete in trunk

Implement TextEncoder's encodeInto()
​https://bugs.webkit.org/show_bug.cgi?id=193274

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/encodeInto.any-expected.txt:
• web-platform-tests/encoding/encodeInto.any.worker-expected.txt:
• web-platform-tests/encoding/idlharness-expected.txt: Removed.
• web-platform-tests/encoding/idlharness.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• bindings/js/JSDOMConvertBufferSource.h:

(WebCore::JSConverter<IDLUint8Array>::convertNewlyCreated):

• dom/TextEncoder.cpp:

(WebCore::TextEncoder::encodeInto):

• dom/TextEncoder.h:
• dom/TextEncoder.idl:

10:39 AM Changeset in webkit [266532] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Finish comment describing the various *Stack SSA nodes in DFG
​https://bugs.webkit.org/show_bug.cgi?id=216110

Reviewed by Sam Weinig.

• dfg/DFGNodeType.h:

10:22 AM Changeset in webkit [266531] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length
<​https://webkit.org/b/216092>

Reviewed by Tim Horton.

• rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness):

• Add default initializer for m_length.

10:20 AM Changeset in webkit [266530] by ddkilzer@apple.com

• 2 edits in trunk/Source/JavaScriptCore

AbstractMacroAssembler::Jump class has uninitialized instance variables
<​https://webkit.org/b/216082>

Reviewed by Michael Saboff.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump):

• Switch to default constructor syntax.
• Provide defaults for instance variables.

10:04 AM Changeset in webkit [266529] by Ross Kirsling

• 19 edits
  1 add in trunk

[JSC] Add missing detached buffer errors for DataView
​https://bugs.webkit.org/show_bug.cgi?id=216062

Reviewed by Yusuke Suzuki.

JSTests:

• stress/detached-buffer-typeerror.js:

Add new test.

• stress/dataview-jit-neuter.js:
• stress/native-constructors-length.js:

Update existing tests.

• test262/expectations.yaml:

Mark 74 test cases as passing.

Source/JavaScriptCore:

DataView methods are often expected to throw a TypeError if the underlying ArrayBuffer is detached
(or neutered, in older terminology) -- this patch adds a slew of missing cases from the following spec section:

• ​https://tc39.es/ecma262/#sec-properties-of-the-dataview-prototype-object

At the same time:

• get rid of JSDataView::getOwnPropertySlot, which was turning dataViewProtoGetterByte{Length,Offset} into mostly unreachable code and erroneously causing byte{Length,Offset} to have property descriptors
• perform some simple cleanup of neighboring error calls / messages
• fix value of DataView.length (our only other DataView spec bug)

• runtime/JSDataView.cpp:

(JSC::JSDataView::create):
(JSC::JSDataView::getOwnPropertySlot): Deleted.

• runtime/JSDataView.h:
• runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):
(JSC::dataViewProtoGetterByteLength):
(JSC::dataViewProtoGetterByteOffset):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):

LayoutTests:

• fast/canvas/webgl/arraybuffer-transfer-of-control.html:
• js/dom/constructor-length.html:
• js/script-tests/typedarray-constructors.js:
• js/typedarray-constructors-expected.txt:
• platform/glib/js/dom/constructor-length-expected.txt:
• platform/ios/js/dom/constructor-length-expected.txt:
• platform/mac/js/dom/constructor-length-expected.txt:
• platform/win/js/dom/constructor-length-expected.txt:
• platform/wincairo/js/dom/constructor-length-expected.txt:

Update tests and expectations.

9:57 AM Changeset in webkit [266528] by achristensen@apple.com

• 10 edits in trunk

TextDecoder should ignore byte-order-mark like other browsers and spec
​https://bugs.webkit.org/show_bug.cgi?id=216108

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
• web-platform-tests/encoding/textdecoder-ignorebom.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• dom/TextDecoder.cpp:

(WebCore::TextDecoder::ignoreBOMIfNecessary):
(WebCore::TextDecoder::decode):
(WebCore::TextDecoder::prependBOMIfNecessary): Deleted.

• dom/TextDecoder.h:

9:33 AM Changeset in webkit [266527] by achristensen@apple.com

• 18 edits
  2 adds in trunk

Align ISO-8859-{3,6,7,8,8-I} and windows-{874,1253,1255,1257} encodings with Chrome, Firefox, and the specification
​https://bugs.webkit.org/show_bug.cgi?id=216094

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/single-byte-decoder-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-single-byte.any-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/text/TextCodec.h:
• platform/text/TextCodecCJK.cpp:

(WebCore::Function<void):

• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

• platform/text/TextCodecSingleByte.cpp: Added.

(WebCore::tableForDecoding):
(WebCore::tableForEncoding):
(WebCore::TextCodecSingleByte::encode):
(WebCore::TextCodecSingleByte::decode):
(WebCore::TextCodecSingleByte::TextCodecSingleByte):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

• platform/text/TextCodecSingleByte.h: Copied from Source/WebCore/platform/text/TextCodec.h.

LayoutTests:

• fast/encoding/char-decoding-expected.txt:
• fast/encoding/char-decoding.html:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

9:31 AM Changeset in webkit [266526] by graouts@webkit.org

• 4 edits
  2 adds in trunk

Consecutive requestAnimationFrame callbacks may be passed the same timestamp
​https://bugs.webkit.org/show_bug.cgi?id=216122
<rdar://problem/68269445>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-unique-timestamp.html

Ensure that the page only sees increasing timestamps in requestAnimationFrame() callbacks.

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const):

LayoutTests:

Add a test that two subsequent animation frames as identified via requestAnimationFrame() callbacks
are provided increasing timestamps.

Also removing flaky expectation for two WPT animations tests which pass reliably after this fix.

• fast/animation/request-animation-frame-unique-timestamp-expected.txt: Added.
• fast/animation/request-animation-frame-unique-timestamp.html: Added.
• platform/mac-wk2/TestExpectations:

9:28 AM Changeset in webkit [266525] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(r266466): [ iOS wk2 ] fast/encoding/charset-replacement.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216126

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:28 AM Changeset in webkit [266524] by Aditya Keerthi

• 10 edits in trunk

[macOS] Support stepping using keyboard in date inputs
​https://bugs.webkit.org/show_bug.cgi?id=216090

Reviewed by Darin Adler.

Source/WebCore:

Users should be able to step through dates using the up and down arrow
keys, matching the functionality of NSDatePicker. To achieve this
functionality, stepUp and stepDown methods were added to
DateTimeFieldElement, incrementing and decrementing the value of the
focused field on an up arrow keypress and a down arrow keypress
respectively. If the currently focused field is empty during the
keypress, stepping up will start from the minimum value and stepping
down will start from the maximum value.

Covered by a new test case in an existing test file.

• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

• html/shadow/DateTimeFieldElement.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::setValueAsIntegerByStepping):
(WebCore::DateTimeNumericFieldElement::stepDown):
(WebCore::DateTimeNumericFieldElement::stepUp):

• html/shadow/DateTimeNumericFieldElement.h:
• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):

• html/shadow/DateTimeSymbolicFieldElement.h:

LayoutTests:

Added a new test case to the existing set of keyboard testcases for editable date inputs.

• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:

9:27 AM Changeset in webkit [266523] by weinig@apple.com

• 78 edits
  1 move
  2 adds in trunk/Source/WebCore

Update WebIDL parser to more closely align with current WebIDL spec
​https://bugs.webkit.org/show_bug.cgi?id=216089

Reviewed by Chris Dumez.

Major changes are:

• 'implements' keyword is now called 'includes' (this is the only observable change).
• Added support for parsing namespaces, async iterable, partial mixins and ObservableArray, though the code generators don't support them yet, so they just clearly error out.
• Update list of keywords that can be used as argument names.
• Update parser to use the current terminology from WebIDL.
• Added more comments to be clear what next steps to take such as removing legacy constructs like serializer, exception, legacycaller and moving synthetic operation additions from the parser to the code generators.

• Modules/fetch/FetchRequest.idl:
• Modules/fetch/FetchResponse.idl:
• bindings/scripts/IDLParser.pm:

(Parse):
(applyTypedefs):
(parseDefinition):
(parseCallbackOrInterfaceOrMixin):
(parseCallbackRestOrInterface):
(parseInterfaceOrMixin):
(parseInterface):
(parseNamespace):
(parseNamespaceMembers):
(parseNamespaceMember):
(parsePartialDefinition):
(parsePartialInterfaceOrPartialMixin):
(parsePartialInterface):
(parsePartialInterfaceMembers):
(parsePartialInterfaceMember):
(parseInterfaceMember):
(parsePartialDictionary):
(parseIncludesStatement):
(parseInheritAttribute):
(parseOperation):
(parseRegularOperation):
(parseSpecial):
(parseAsyncIterable):
(parseOptionalIterableInterface):
(parseArgumentNameKeyword):
(parseDistinguishableType):
(parseConstType):
(parsePrimitiveType):
(applyMemberList):
(parseCallbackOrInterface): Deleted.
(parseImplementsStatement): Deleted.
(parseOperationOrReadWriteAttributeOrMaplike): Deleted.
(parseReadWriteAttribute): Deleted.
(parseInherit): Deleted.

• bindings/scripts/preprocess-idls.pl:

(getIncludedInterfacesFromIDL):
(getImplementedInterfacesFromIDL): Deleted.

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttr):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttrSetter):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttr):
(WebCore::jsTestInterfaceIncludesStr1Getter):
(WebCore::jsTestInterfaceIncludesStr1):
(WebCore::jsTestInterfaceIncludesStr2Getter):
(WebCore::jsTestInterfaceIncludesStr2):
(WebCore::setJSTestInterfaceIncludesStr2Setter):
(WebCore::setJSTestInterfaceIncludesStr2):
(WebCore::jsTestInterfaceIncludesStr3Getter):
(WebCore::jsTestInterfaceIncludesStr3):
(WebCore::setJSTestInterfaceIncludesStr3Setter):
(WebCore::setJSTestInterfaceIncludesStr3):
(WebCore::jsTestInterfaceIncludesNodeGetter):
(WebCore::jsTestInterfaceIncludesNode):
(WebCore::setJSTestInterfaceIncludesNodeSetter):
(WebCore::setJSTestInterfaceIncludesNode):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4Body):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4):
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttrSetter): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::jsTestInterfaceImplementsStr1Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr1): Deleted.
(WebCore::jsTestInterfaceImplementsStr2Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr2): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2): Deleted.
(WebCore::jsTestInterfaceImplementsStr3Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr3): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3): Deleted.
(WebCore::jsTestInterfaceImplementsNodeGetter): Deleted.
(WebCore::jsTestInterfaceImplementsNode): Deleted.
(WebCore::setJSTestInterfaceImplementsNodeSetter): Deleted.
(WebCore::setJSTestInterfaceImplementsNode): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4Body): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4): Deleted.

• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestImplements.idl: Removed.
• bindings/scripts/test/TestIncludes.idl: Copied from Source/WebCore/bindings/scripts/test/TestImplements.idl.
• bindings/scripts/test/TestInterface.idl:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestOperationConditional.idl:
• dom/CharacterData.idl:
• dom/DeviceMotionEvent.idl:
• dom/DeviceOrientationEvent.idl:
• dom/Document.idl:
• dom/DocumentFragment.idl:
• dom/DocumentType.idl:
• dom/Element.idl:
• dom/ShadowRoot.idl:
• dom/Text.idl:
• html/HTMLAnchorElement.idl:
• html/HTMLAreaElement.idl:
• html/HTMLBodyElement.idl:
• html/HTMLElement.idl:
• html/HTMLFrameSetElement.idl:
• html/canvas/CanvasRenderingContext2D.idl:
• html/canvas/OffscreenCanvasRenderingContext2D.idl:
• html/canvas/PaintRenderingContext2D.idl:
• html/canvas/Path2D.idl:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.idl:
• page/DOMWindow.idl:
• page/Navigator.idl:
• page/WorkerNavigator.idl:
• svg/SVGAElement.idl:
• svg/SVGAltGlyphElement.idl:
• svg/SVGAnimationElement.idl:
• svg/SVGCursorElement.idl:
• svg/SVGElement.idl:
• svg/SVGFEBlendElement.idl:
• svg/SVGFEColorMatrixElement.idl:
• svg/SVGFEComponentTransferElement.idl:
• svg/SVGFECompositeElement.idl:
• svg/SVGFEConvolveMatrixElement.idl:
• svg/SVGFEDiffuseLightingElement.idl:
• svg/SVGFEDisplacementMapElement.idl:
• svg/SVGFEDropShadowElement.idl:
• svg/SVGFEFloodElement.idl:
• svg/SVGFEGaussianBlurElement.idl:
• svg/SVGFEImageElement.idl:
• svg/SVGFEMergeElement.idl:
• svg/SVGFEMorphologyElement.idl:
• svg/SVGFEOffsetElement.idl:
• svg/SVGFESpecularLightingElement.idl:
• svg/SVGFETileElement.idl:
• svg/SVGFETurbulenceElement.idl:
• svg/SVGFilterElement.idl:
• svg/SVGGlyphRefElement.idl:
• svg/SVGGradientElement.idl:
• svg/SVGGraphicsElement.idl:
• svg/SVGImageElement.idl:
• svg/SVGMPathElement.idl:
• svg/SVGMarkerElement.idl:
• svg/SVGMaskElement.idl:
• svg/SVGPatternElement.idl:
• svg/SVGSVGElement.idl:
• svg/SVGScriptElement.idl:
• svg/SVGSymbolElement.idl:
• svg/SVGTRefElement.idl:
• svg/SVGTextPathElement.idl:
• svg/SVGUseElement.idl:
• svg/SVGViewElement.idl:
• svg/SVGViewSpec.idl:
• workers/Worker.idl:
• workers/WorkerGlobalScope.idl:
• workers/service/ServiceWorker.idl:

9:14 AM Changeset in webkit [266522] by achristensen@apple.com

• 1 edit
  1 copy in trunk/LayoutTests

Rebase Windows test expectations after r266466

9:11 AM Changeset in webkit [266521] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

Rebase iOS test results after r266399
​https://bugs.webkit.org/show_bug.cgi?id=216022

• platform/ios/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:

9:06 AM Changeset in webkit [266520] by achristensen@apple.com

• 12 edits in trunk

Align EUC-KR encoding with Chrome, Firefox, and specification
​https://bugs.webkit.org/show_bug.cgi?id=216081

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-errors-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-misc-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucKREncodingIndex):
(WebCore::eucKREncode):
(WebCore::TextCodecCJK::eucKRDecode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h:
• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

9:05 AM Changeset in webkit [266519] by Hector Lopez

• 2 edits in trunk/LayoutTests

REGRESSION(266399?): [ iOS wk2 ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216124

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

8:33 AM Changeset in webkit [266518] by Chris Dumez

• 11 edits in trunk

Make our implementation of ChannelMergerNode standards compliant
​https://bugs.webkit.org/show_bug.cgi?id=216113

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that they are passing.

• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-non-default-expected.txt:

Source/WebCore:

This aligns our implementation of ChannelMergerNode with Chromium's, allowing us
to pass more web platform tests.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
(WebCore::AudioNode::disableOutputs):

• Modules/webaudio/AudioNode.h:

Split disableOutputs() out of disableOutputsIfNecessary() so that it can be called
directly.

• Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::connect):

• Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isEnabled const):
When connected to an output, AudioNodeInput keeps the output either in m_outputs when
the output is enabled, m_disabledOutputs when it is disabled. AudioNodeInput's enable()
& disable() take care of moving the output from one map to another. However, connect()
would assume that the output we're connecting to is enabled and add it to m_outputs
unconditionally. This was causing an assertion to get hit in enable() later on because
the output we're trying to enable was not in m_disabledOutputs (because it was already
in m_outputs). This change is needed because the ChannelMergerNode now disables its
output right away, before it is connected.

• Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):
Make sure that the output has a number of channels equal to the number of inputs.
Initially disable outputs so that we output a single silent channel until something
is connected.

(WebCore::ChannelMergerNode::process):

• Modules/webaudio/ChannelMergerNode.h:

Simplify code now that the number of inputs is equal to output's number of channels.

8:29 AM Changeset in webkit [266517] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use unicode macros instead of manual range checks in TextCodecUTF16
​https://bugs.webkit.org/show_bug.cgi?id=216098

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-03
Reviewed by Darin Adler.

No change in behavior. Just responding to feedback from bug 216058.

• platform/text/TextCodecSingleByte.cpp: Added.

(WebCore::tableForDecoding):
(WebCore::tableForEncoding):
(WebCore::TextCodecSingleByte::encode):
(WebCore::TextCodecSingleByte::decode):
(WebCore::TextCodecSingleByte::TextCodecSingleByte):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

• platform/text/TextCodecSingleByte.h: Added.
• platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

7:56 AM Changeset in webkit [266516] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-bottom
​https://bugs.webkit.org/show_bug.cgi?id=215538
<rdar://problem/67613372>

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + descent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-bottom-nested.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

• fast/layoutformattingcontext/vertical-align-bottom-nested-expected.html: Added.
• fast/layoutformattingcontext/vertical-align-bottom-nested.html: Added.

7:51 AM Changeset in webkit [266515] by Alan Bujtas

• 3 edits
  2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-top
​https://bugs.webkit.org/show_bug.cgi?id=215545
<rdar://problem/67629969>

Reviewed by Antti Koivisto.

Source/WebCore:

See ​https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + ascent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-top-nested.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

• fast/layoutformattingcontext/vertical-align-top-nested-expected.html: Added.
• fast/layoutformattingcontext/vertical-align-top-nested.html: Added.

7:40 AM Changeset in webkit [266514] by Aditya Keerthi

• 15 edits in trunk

[macOS] Add disabled and readonly behaviors to date inputs
​https://bugs.webkit.org/show_bug.cgi?id=216005

Reviewed by Devin Rousso.

Source/WebCore:

Added methods to EditControlOwner and FieldOwner so that
DateTimeEditElement and DateTimeFieldElement are aware of the readonly
and disabled states of their containing element.

Disabled inputs should not be focusable and should not respond to any
keyboard events. On the other hand, readonly inputs should respond to
some keyboard events (such as left arrow, right arrow, and the tab
key), but should not be editable.

• css/html.css: Updated to add GrayText color for disabled fields.

(input[disabled]::-webkit-datetime-edit-year-field,):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerDisabled const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerReadOnly const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabled const):
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly const):

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):

If the owning element is disabled or readonly, elide a call to
handleKeyboardEvent, which is implemented by subclasses to achieve
editability.

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Disabled inputs should not respond to any events.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled const):
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly const):
(WebCore::DateTimeFieldElement::isFocusable const): Disabled inputs should not be focusable.

• html/shadow/DateTimeFieldElement.h:

LayoutTests:

Added tests for disabled and readonly date inputs in existing test files.

• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
• fast/forms/date/date-editable-components/date-editable-components-mouse-events-expected.txt:
• fast/forms/date/date-editable-components/date-editable-components-mouse-events.html:

7:20 AM Changeset in webkit [266513] by Wenson Hsieh

• 3 edits in trunk/Source/WebCore

Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
​https://bugs.webkit.org/show_bug.cgi?id=216101

Reviewed by Tim Horton.

The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time under RenderLayer::paintLayerByApplyingTransform just
inverting the transformation matrix (underneath TransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.

TransformationMatrix::inverse() currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.

However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.

We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition of TransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks in TransformationMatrix::inverse().

We also apply a similar optimization to TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.

I measured this locally to be a (statistically significant) 2% improvement on Multiply.

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isInvertible const):
(WebCore::TransformationMatrix::inverse const):

• platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::type const):

7:19 AM Changeset in webkit [266512] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Mark more convolver related tests as flaky crash.

• platform/gtk/TestExpectations:

6:24 AM Changeset in webkit [266511] by youenn@apple.com

• 14 edits in trunk

Expose RTCPeerConnection.restartIce
​https://bugs.webkit.org/show_bug.cgi?id=216072

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-restartIce.https-expected.txt:
• web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Add plubming code to expose restartIce.
Covered by rebased test.

• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::restartIce):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::restartIce):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

• TestExpectations:

4:22 AM Changeset in webkit [266510] by Alan Bujtas

• 5 edits
  4 adds in trunk

Source/WebCore:
[LFC][IFC] Add support nested inline box sizing and positioning
​https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

This patch splits the line box construction process into a few distinct steps.

1. Construct the inline boxes as needed. There's always a root inline box.
2. Size them by taking the vertical alignment into account
   • child inline boxes stretch their parent inline boxes in most cases (depending on the vertical-align property value).
3. Position the inline boxes relative to the line box.

Test: fast/layoutformattingcontext/vertical-align-middle-nested.html

fast/layoutformattingcontext/vertical-align-middle-simple.html

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineHeight):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const): Deleted.
(WebCore::Layout::LineBox::alignVertically): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::setLogicalHeight):
(WebCore::Layout::LineBox::InlineBox::setBaseline):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):

LayoutTests:
[LFC][IFC] Fix nested inline box sizing and positioning
​https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

• fast/layoutformattingcontext/vertical-align-middle-nested-expected.html:
• fast/layoutformattingcontext/vertical-align-middle-nested.html:
• fast/layoutformattingcontext/vertical-align-middle-simple-expected.html:
• fast/layoutformattingcontext/vertical-align-middle-simple.html:

3:15 AM Changeset in webkit [266509] by Alan Bujtas

• 9 edits in trunk/Source/WebCore

[LFC][IFC] Finalize InlineBox alignment in LineBox
​https://bugs.webkit.org/show_bug.cgi?id=215410

Reviewed by Antti Koivisto.

This patch completes the InlineBox transition.

LineBox now has a dedicated root inline box and additional inline boxes as needed.
Both horizontal and vertical alignments are performed on the inline boxes as opposed to on the runs.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineFormattingContext.h:
• layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::halfLeadingMetrics):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::alignVertically):
(WebCore::Layout::LineBox::rectForRun const): Deleted.
(WebCore::Layout::LineBox::alignHorizontally): Deleted.
(WebCore::Layout::LineBox::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBox::collectHangingContent const): Deleted.

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::AscentAndDescent::height const):
(WebCore::Layout::LineBox::InlineBox::logicalRect const):
(WebCore::Layout::LineBox::InlineBox::logicalTop const):
(WebCore::Layout::LineBox::InlineBox::logicalLeft const):
(WebCore::Layout::LineBox::InlineBox::logicalWidth const):
(WebCore::Layout::LineBox::InlineBox::logicalHeight const):
(WebCore::Layout::LineBox::InlineBox::baseline const):
(WebCore::Layout::LineBox::InlineBox::descent const):
(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::isAtomicInlineLevelBox const):
(WebCore::Layout::LineBox::InlineBox::setHasStrut):
(WebCore::Layout::LineBox::InlineBox::hasStrut const):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::AscentAndDescent::height const): Deleted.
(WebCore::Layout::LineBox::ascentAndDescent const): Deleted.
(WebCore::Layout::LineBox::setScrollableOverflow): Deleted.
(WebCore::Layout::LineBox::InlineBox::InlineBox): Deleted.
(WebCore::Layout::LineBox::setLogicalHeightIfGreater): Deleted.
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::setAscentIfGreater): Deleted.
(WebCore::Layout::LineBox::setDescentIfGreater): Deleted.
(WebCore::Layout::LineBox::halfLeadingMetrics): Deleted.

• layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::Run::logicalRight const):

1:38 AM Changeset in webkit [266508] by youenn@apple.com

• 6 edits in trunk

calling transceiver setCodecPreferences doesn't change the order of codecs in the offer/answer generated by the browser
​https://bugs.webkit.org/show_bug.cgi?id=215567
<rdar://problem/67277554>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html:

Source/WebCore:

Make sure to serialize sdpFmtp information so that setCodecPreferences succeeds.
Also make sure to throw the exception if there is any.

Covered by updated imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html.

• Modules/mediastream/RTCRtpTransceiver.idl:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::toRTCRtpCapabilities):

1:07 AM Changeset in webkit [266507] by Diego Pino Garcia

• 2 edits in trunk/Tools

kill-old-processes: Remove stale Apache2 shm segments
​https://bugs.webkit.org/show_bug.cgi?id=216068

Reviewed by Alexey Proskuryakov.

When Apache2 terminates abruptely, it may not free up allocated shared
memory segments. When later Apache2 is started again, if its pid
matches the pid of orphan shm segments it fails believing there's
already an Apache2 instance running. To avoid this situation, after
killing Apache2 we check for potential conflicting shm segments and
remove them.

• BuildSlaveSupport/kill-old-processes:

(listAllWebKitPrograms):
(removeOrphanShmSegmentsOf):
(removeShmSegments):
(removeShmSegment):
(cmd):
(allShmSegments):
(main):

12:48 AM Changeset in webkit [266506] by rniwa@webkit.org

• 2 edits in trunk/Tools

Static assert the return type of compactMap
​https://bugs.webkit.org/show_bug.cgi?id=216119

Reviewed by Darin Adler.

Added static_assert for the return types of compactMap in varoius unit tests.

(WTF_Vector.CompactMapStaticFunctionReturnOptional):
(WTF_Vector.CompactMapStaticFunctionReturnRefPtr):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRef):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRefPtr):
(WTF_Vector.CompactMapLambdaReturnOptional):
(WTF_Vector.CompactMapLambdaCopyVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaMoveVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaReturnRefPtr):
(WTF_Vector.CompactMapLambdaReturnRefPtrFromMovedRef):
(WTF_Vector.CompactMapLambdaReturnOptionalRefPtr):

Sep 2, 2020:

11:20 PM Writing testharness Tests edited by Fujii Hironori

(diff)

10:51 PM Changeset in webkit [266505] by achristensen@apple.com

• 1 edit
  2 deletes in trunk/LayoutTests/imported/w3c

Remove some unused old expectations files

• web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt: Removed.
• web-platform-tests/encoding/textdecoder-utf16-surrogates-expected.txt: Removed.

10:27 PM Changeset in webkit [266504] by achristensen@apple.com

• 1 edit
  1 copy in trunk/LayoutTests

Rebase Windows test expectations after r266466
​https://bugs.webkit.org/show_bug.cgi?id=216063

• platform/win/fast/encoding/charset-replacement-expected.txt: Copied from fast/encoding/charset-replacement-expected.txt.

A document with just one replacement character is 2 pixels different on Windows.

10:24 PM Changeset in webkit [266503] by ysuzuki@apple.com

• 8 edits
  1 copy
  4 adds in trunk/JSTests

[JSC] Update test262
​https://bugs.webkit.org/show_bug.cgi?id=216116

Reviewed by Ross Kirsling.

Rebaseline test262.

• test262/expectations.yaml:
• test262/harness/compareArray.js:

(assert.compareArray):

• test262/harness/testIntl.js:

(regExpPropertiesDefaultValues):

• test262/latest-changes-summary.txt:
• test262/test/annexB/language/expressions/object/proto-poisoned-object-prototype.js: Added.
• test262/test/built-ins/Array/prototype/push/length-near-integer-limit-set-failure.js: Added.
• test262/test/built-ins/Object/defineProperty/redefine-length-with-various-values-and-configurable-true.js: Added.
• test262/test/harness/compare-array-falsy-arguments.js: Added.

(assertThrows):

• test262/test/intl402/DateTimeFormat/constructor-options-order-fractionalSecondDigits.js:
• test262/test/language/expressions/object/proto-permitted-dup-shorthand.js: Copied from JSTests/test262/test/language/expressions/object/proto-permitted-dup.js.
• test262/test/language/expressions/object/proto-permitted-dup.js:

(obj.proto):
(obj.async proto):

• test262/test262-Revision.txt:

10:20 PM Changeset in webkit [266502] by Lauro Moura

• 4 edits
  2 adds in trunk/LayoutTests

[GLIB] Rebaseline and garden some tests

Unreviewed test gardening.

• platform/glib/fast/encoding/charset-replacement-expected.txt: Added.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

8:22 PM Changeset in webkit [266501] by Chris Dumez

• 12 edits in trunk

Choose adequate number of channels for ConvolverNode's output
​https://bugs.webkit.org/show_bug.cgi?id=216099

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-cascade-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

Choose adequate number of channels for ConvolverNode's output. We were using 2 channels for
the output no matter what but we're supposed to use a single channel if both the input
and the response buffer are mono.

This is based on the following Blink change by Raymond Toy:

• ​https://codereview.chromium.org/2732523003

No new tests, rebaselined existing tests.

• Modules/webaudio/ConvolverNode.cpp:

(WebCore::computeNumberOfOutputChannels):
(WebCore::ConvolverNode::create):
Set the shouldNormalize flag *before* we set the buffer since setBuffer() relies on
the flag. This gives us a few more test passes.

(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):
(WebCore::ConvolverNode::checkNumberOfChannelsForInput):

• Modules/webaudio/ConvolverNode.h:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb):
(WebCore::Reverb::initialize):
(WebCore::Reverb::process):

• platform/audio/Reverb.h:

7:59 PM Changeset in webkit [266500] by Hector Lopez

• 2 edits
  2 copies
  6 adds in trunk/LayoutTests

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:

7:08 PM Changeset in webkit [266499] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r251254): Web Inspector: Text insertion point is invisible when editing DOM nodes
​https://bugs.webkit.org/show_bug.cgi?id=210197
<rdar://problem/61485409>

Reviewed by Devin Rousso.

r251254 promoted the selection area into a layer on top the the tree outline item.
Combined with the existing WebKit bug (​https://webkit.org/b/213501), it introduced the regression.

This patch is largely a workaround for the WebKit bug.

Revert r251254 and instead change the background color of the shadow DOM items from
the semi-transparent gray to black (white in the dark mode) with 5% transparency, which
produced the same gray color overlayed on top of the white background of the DOM tree outline.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom):
(.tree-outline.dom li .selection-area):

(.tree-outline.dom li > :not(.selection-area)): Deleted.
Don't introduce a layer for every DOM node.

(.tree-outline.dom li.parent.shadow::after):
(.tree-outline.dom li.parent.shadow + ol.children.expanded):
(@media (prefers-color-scheme: dark) .tree-outline.dom):
(@media (prefers-color-scheme: dark) .tree-outline.dom .shadow):

6:32 PM Changeset in webkit [266498] by Darin Adler

• 6 edits in trunk/Source/WebCore

Simplify some editing code
​https://bugs.webkit.org/show_bug.cgi?id=216097

Reviewed by Sam Weinig.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):
If string is empty, don't add a text node. Turns out all callers wanted
this behavior.

• dom/Node.cpp:

(WebCore::Node::setTextContent): Simplify by relying on new behavior
of replaceAllChildrenWithNewText when passed an empty string.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Use
replaceAllChildrenWithNewText instead of the unnecessarily complicated
code that was here. Also simplify the VisibeSelection manipulation at
the end of the function.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText): Simplify by relying on new
behavior of replaceAllChildrenWithNewText when passed an empty string.

• page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument): Simplify by using the
selection function that takes a SimpleRange rather than the one that
takes two containers and offsets.

6:04 PM Changeset in webkit [266497] by Jon Davis

• 3 edits in trunk/Websites/webkit.org

Add an STP callout to Web Inspector documentation
​https://bugs.webkit.org/show_bug.cgi?id=216105

Reviewed by Devin Rousso.

• wp-content/themes/webkit/single-web_inspector_page.php:
• wp-content/themes/webkit/style.css:

(article .meta .icon):

4:58 PM Changeset in webkit [266496] by msaboff@apple.com

• 4 edits
  1 add in trunk

ASSERTION FAILED: value.isCell() && value.asCell()->type() == CustomGetterSetterType ./bytecode/ObjectPropertyConditionSet.cpp
​https://bugs.webkit.org/show_bug.cgi?id=216103

Reviewed by Saam Barati.

JSTests:

New teset.

• stress/custom-get-set-override.js: Added.

(overrideFunction.o.customFunction):
(overrideFunction):

Source/JavaScriptCore:

Changed the ASSERT to an if statement. This checks to see if, the likely newly changed,
property is still a custom getter setter before caching its access as such.

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::generateConditionsForPrototypePropertyHitCustom):

• tools/JSDollarVM.cpp: Added test helper function.

4:34 PM Changeset in webkit [266495] by dino@apple.com

• 2 edits in trunk/Tools

Update Kimmo's email.

• Scripts/webkitpy/common/config/contributors.json:

4:23 PM Changeset in webkit [266494] by Karl Rackler

• 2 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Mojave

Unreviewed test gardening.

• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt:

3:44 PM Changeset in webkit [266493] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Remove custom domain from SameSite=strict jail protection
​https://bugs.webkit.org/show_bug.cgi?id=216083
<rdar://problem/68220223>

Reviewed by Alex Christensen.

No new tests. This was a site-specific opt-in rule. The feature
itself has tests.

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::shouldEnforceSameSiteStrictForSpecificDomain const):

3:11 PM Changeset in webkit [266492] by Chris Dumez

• 10 edits
  2 adds in trunk

Don't modify the response when creating a ConvolverNode
​https://bugs.webkit.org/show_bug.cgi?id=216093

Reviewed by Eric Carlson.

Source/WebCore:

When creating a ConvolverNode with normalization (the default), the
ConvolverNode was modifying the supplied AudioBuffer containing the
desired impulse response. This happens because the normalization
factor was applied to the buffer, convolver stages were computed, and
then the normalization was undone. Due to floating-point roundoff,
this can (and does) modify the buffer.

Instead, compute the scale factor and pass it into the various
routines so that the scaling can be done there. For stages using an
FFT, the resulting FFT is scaled by the factor. For the direct
convolver, the response is modified there. (The direct convolver
makes a copy of the reponse, so this is safe.)

This is a cherry-pick of the following Blink change by Raymond Toy:

• ​https://chromium-review.googlesource.com/c/chromium/src/+/1623457

Test: webaudio/convolvernode-unmodified-buffer.html

• platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::scaleFFT):

• platform/audio/FFTFrame.h:
• platform/audio/Reverb.cpp:

(WebCore::Reverb::Reverb):
(WebCore::Reverb::initialize):

• platform/audio/Reverb.h:
• platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

• platform/audio/ReverbConvolver.h:
• platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

• platform/audio/ReverbConvolverStage.h:

LayoutTests:

Import layout test from Blink.

• webaudio/convolvernode-unmodified-buffer-expected.txt: Added.
• webaudio/convolvernode-unmodified-buffer.html: Added.

3:07 PM Changeset in webkit [266491] by Chris Dumez

• 4 edits in trunk

Fix rounding for DelayDSPKernel's buffer size calculation
​https://bugs.webkit.org/show_bug.cgi?id=216091

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/maxdelay-rounding-expected.txt:

Source/WebCore:

Fix rounding for DelayDSPKernel's buffer size calculation. The DelayNode needs to buffer
|maxDelayTime| sample frames, plus one frame for interpolation. If |maxDelayTime| isn't
an integer, we have to round it up or the buffer would end up one frame short.

No new tests, rebaselined existing test.

• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::bufferLengthForDelay const):

2:25 PM Changeset in webkit [266490] by Karl Rackler

• 2 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Catalina

Unreviewed test gardening.

• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt:

2:24 PM Changeset in webkit [266489] by Darin Adler

• 14 edits in trunk/Source

Change Affinity into an enum class
​https://bugs.webkit.org/show_bug.cgi?id=216096

Reviewed by Wenson Hsieh.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset): Use prefix.

• dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition const): Ditto.
(WebCore::Position::inlineBoxAndOffset const): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): Ditto.

• editing/TextAffinity.h: Use an enum class.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use prefix.

• editing/VisiblePosition.h: Ditto.
• editing/VisibleUnits.cpp:

(WebCore::visualWordPosition): Ditto.
(WebCore::nextBoundary): Ditto.
(WebCore::endPositionForLine): Ditto.
(WebCore::atBoundaryOfGranularity): Ditto.
(WebCore::nextLineBoundaryInDirection): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::createVisiblePositionForBox): Ditto.
(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
Use prefix.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.h:

(kit): Use prefix.
(core): Ditto.

2:16 PM Changeset in webkit [266488] by rniwa@webkit.org

• 4 edits in trunk

Add a variant of map which filters items to Vector.h
​https://bugs.webkit.org/show_bug.cgi?id=215879

Reviewed by Darin Adler and Yusuke Suzuki.

Source/WTF:

This patch adds WTF::compactMap, which calls a function on each item in an iterable object like WTF::map
but also filters the returned value. The mapped function may return Optional<T> or RefPtr<T>. The value
is kept in the result if the returned value is not WTF::nullopt in the case of Optional<T> and not null
in the case of RefPtr<T>. The result will be either Vector<T> for Optional<T> or else Vector<Ref<T>>.

• wtf/Vector.h:

(WTF::CompactMapTraits:): Added. Traits to have a different behavior
(WTF::CompactMapTraits<Optional<T>>::hasValue): Added.
(WTF::CompactMapTraits<Optional<T>>::extractValue): Added.
(WTF::CompactMapTraits<RefPtr<T>>::hasValue): Added.
(WTF::CompactMapTraits<RefPtr<T>>::extractValue): Added.
(WTF::CompactMap): Added. The helper to use WTFMove on the argument to the mapped function if possible.
(WTF::compactMap): Added.

Tools:

Added unit tests.

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::evenMultipliedByFive):
(WTF_Vector.CompactMapStaticFunctionReturnOptional):
(TestWebKitAPI::RefCountedObject):
(TestWebKitAPI::RefCountedObject::create):
(TestWebKitAPI::RefCountedObject::ref):
(TestWebKitAPI::RefCountedObject::RefCountedObject):
(TestWebKitAPI::createRefCountedForOdd):
(WTF_Vector.CompactMapStaticFunctionReturnRefPtr):
(TestWebKitAPI::createRefCountedForEven):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRef):
(TestWebKitAPI::createRefCountedWhenDivisibleByThree):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRefPtr):
(WTF_Vector.CompactMapLambdaReturnOptional):
(TestWebKitAPI::CountedObject):
(TestWebKitAPI::CountedObject::CountedObject):
(TestWebKitAPI::CountedObject::value):
(TestWebKitAPI::CountedObject::count):
(WTF_Vector.CompactMapLambdaCopyVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaMoveVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaReturnRefPtr):
(WTF_Vector.CompactMapLambdaReturnRefPtrFromMovedRef):
(WTF_Vector.CompactMapLambdaReturnOptionalRefPtr):

2:01 PM Changeset in webkit [266487] by Darin Adler

• 39 edits in trunk/Source

Remove comparePositions and make VisiblePosition improvements
​https://bugs.webkit.org/show_bug.cgi?id=215982

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset): Updated for
inlineBoxAndOffset.

• accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Use std::max/min instead of comparePositions.
(isWhiteSpaceBetweenSentences): Use isPointInRange instead of comparePositions.

• dom/Position.cpp:

(WebCore::Position::rendersInDifferentPosition const): Updated for
inlineBoxAndOffset.
(WebCore::Position::inlineBoxAndOffset const): Renamed from
getInlineBoxAndOffset and changed to use a return value instead of out arguments.

• dom/Position.h: Added InlineBoxAndOffset structure for the inlineBoxAndOffset

function. Update for rename of EAffinity to Affinity. Changed getInlineBoxAndOffset
to inlineBoxAndOffset and use a return value instead of out arguments. Change
<, >, <=, and >= to call documentOrder.

• editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd): Use <= instead of comparePositions.
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY.
(WebCore::ApplyStyleCommand::applyBlockStyle): Use < instead of comparePositions.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto. Also added
a missing null check.
(WebCore::ApplyStyleCommand::applyInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use <= and < instead
of comparePositions.
(WebCore::ApplyStyleCommand::removeInlineStyle): Use <= instead of comparePositions.
(WebCore::ApplyStyleCommand::nodeFullySelected const): Use >= and <= instead of
comparePositions.
(WebCore::ApplyStyleCommand::nodeFullyUnselected const): Use < and > instead of
comparePositions.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText): Use < instead of
comparePositions, in a way that handles the null case correctly.
(WebCore::CompositeEditCommand::deleteInsignificantTextDownstream): Removed
unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
Ditto. Also use < instead of comparePositions.
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Use <=
instead of comparePositions.
(WebCore::CompositeEditCommand::moveParagraphs): Use <= and >= instead of
comparePositions.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializeStartEnd): Use >= instead of
comparePositions
(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers):
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY, and
in other cases removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Use >= instead
of comparePositions.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Use >= instead of
comparePositions, also use isOrphan and merge two checks into one.

• editing/Editing.cpp:

(WebCore::comparePositions): Deleted.
(WebCore::firstEditablePositionAfterPositionInRoot): Use < instead of
comparePositions.
(WebCore::lastEditablePositionBeforePositionInRoot): Use > instead of
comparePositions.
(WebCore::isNodeVisiblyContainedWithin): Use < instead of comparePositions.
(WebCore::localCaretRectInRendererForCaretPainting): Update for
localCaretRect function that no longer uses an out argument.

• editing/Editing.h: Deleted comparePositions.

• editing/Editor.cpp:

(WebCore::Editor::adjustedSelectionRange): Use >= instead of
comparePositions.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionByMouseIfDifferent): Assign
an empty value rather than using a clear function.
(WebCore::FrameSelection::directionOfSelection): Updated for
inlineBoxAndOffset.
(WebCore::FrameSelection::contains const): Use isPointInRange instead
of comparePositions.
(WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
Use Upstream instead of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::FrameSelection::elementRangeContainingCaretSelection const):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::FrameSelection::characterInRelationToCaretSelection const): Ditto.
(WebCore::FrameSelection::characterBeforeCaretSelection const): Deleted.
There is only one caller, and we can move the algorithm, now a one-liner, there.
(WebCore::FrameSelection::characterAfterCaretSelection const): Deleted. Ditto.
(WebCore::FrameSelection::selectionAtDocumentStart const): Deleted. Ditto.
(WebCore::FrameSelection::selectionAtWordStart const): Use visibleStart
inatead of creating a new position with VP_DEFAULT_AFFINITY. Also streamlined
the function a bit.
(WebCore::FrameSelection::selectRangeOnElement): Deleted.
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY.
(WebCore::FrameSelection::selectionAtSentenceStart const): Ditto.

• editing/FrameSelection.h: Updated for above.

• editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
Removed unnecessary explicit use of VP_DEFAULT_AFFINITY. Also tightened
up the code a bit including removing an unnecessary assertion.
(WebCore::InsertParagraphSeparatorCommand::doApply): Use <= instead of
comparePositions.

• editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition): Have the VisiblePosition
constructor call through to the Position/Affinity constructor instead
of repeating the logic twice. Update for inlineBoxAndOffset. Initialize
m_offset in the class definition so we don't have to do it here.

• editing/RenderedPosition.h: Initialize all data members. Sorted a

function member above the data members.

• editing/TextAffinity.h: Renamed for modern WebKit coding style,

eliminating the use of all caps and the "E" prefix on EAffinity.
For now, old names are also still supported.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use member construction
rather than assignment. Rewrote the code that stores upstream affinity
only when appropriate to be more straightforward. The old code would
set to upstream and then change back. The new code sets to upstream
only after testing that it worked. Should also be faster since it
saves one call to canonicalPosition.
(WebCore::VisiblePosition::init): Deleted. Rolled into the constructor.
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate const):
Update for inlineBoxAndOffset.
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate const): Ditto.
(WebCore::VisiblePosition::localCaretRect const): Return the renderer as
part of the return value rather than an out argument. Update for
inlineBoxAndOffset and streamline logic a bit.
(WebCore::VisiblePosition::absoluteSelectionBoundsForLine const):
Update for inlineBoxAndOffset and remove unneded special cases already
covered by that function.
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation const):
Updated for localCaretRect.
(WebCore::documentOrder): Added.

• editing/VisiblePosition.h: Added VisiblePosition::defaultAffinity

to replace VP_DEFAULT_AFFINITY. Deleted VP_UPSTREAM_IF_POSSIBLE; callers
will just use Upstream. Deleted the clear function. Renamed
getInlineBoxAndOffset to inlineBoxAndOffset and use a return value
instead of out arguments. Use a return value instead of out
arguments for localCaretRect. Made canonicalPosition a static member
function. Use documentOrder to implement <, >, <=, and >=.

• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::toNormalizedRange const): Use > instead
of comparePositions. Also do the comparison after calling
parentAnchoredEquivalent instead of before.
(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents):
Use <= instead of comparePositions.
(WebCore::VisibleSelection::setWithoutValidation): Ditto.

• editing/VisibleUnits.cpp:

(WebCore::visualWordPosition): Update for inlineBoxAndOffset.
(WebCore::nextBoundary): Use Upstream instad of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::endPositionForLine): Ditto.
(WebCore::previousLinePosition): Update for inlineBoxAndOffset.
(WebCore::nextLinePosition): Ditto.
(WebCore::atBoundaryOfGranularity): Use Upstream instead of
VP_UPSTREAM_IF_POSSIBLE. This is especially important here,
because setAffinity does not actually check if upstream is possible,
so it is setting to Upstream unconditionally. The old name was
misleading here.
(WebCore::nextLineBoundaryInDirection): Ditto. Same misleading use.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::convert): Use > instead of comparePositions.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Removed unnecessary
explicit use of VP_DEFAULT_AFFINITY.

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes): Use <=
instead of comparePositions.
(WebCore::serializePreservingVisualAppearanceInternal): Use ==
and < instead of comparePositions.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick): Use <
instead of comparePositions.
(WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::createVisiblePositionForBox): Use VisiblePosition::defaultAffinity
instead of VP_DEFAULT_AFFINITY and Upstream instead of VP_UPSTREAM_IF_POSSIBLE.
(WebCore::RenderTextLineBoxes::positionForPoint const): DItto.

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPointInRootViewCoordinates): Use <= instead of
comparePositions.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition positionByMovingInDirection:amount:withAffinityDownstream:]):
Use Upstream instead of VP_UPSTREAM_IF_POSSIBLE. Since we were calling
setAffinity here, VP_UPSTREAM_IF_POSSIBLE was misleading since that function
does not check the validity of the affinity.
(-[DOMNode startPosition]): Removed unnecessary explicit VP_DEFAULT_AFFINITY.
(-[DOMNode endPosition]): Ditto.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebEditorClient.h:

(kit): Update for changes to Affinity enumeration.
(core): Ditto.

• WebView/WebFrame.mm:

(-[WebFrame characterBeforeCaretSelection]): Moved the code from
FrameSelection::characterBeforeCaretSelection because it's a one-liner now.
Added a call to updateLayout because it's unclear why we could do without it before.
Also added a null check for frame, since there's no guarantee it's not null.
(-[WebFrame characterAfterCaretSelection]): Ditto.
(-[WebFrame selectionAtDocumentStart]): Ditto.
(-[WebFrame selectNSRange:onElement:]): Ditto, but also added a comment because
this method is not useful and almost certainly not used.
(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]):
Use VisiblePosition::defaultAffinity instead of VP_DEFAULT_AFFINITY.

Source/WebKitLegacy/win:

• AccessibleTextImpl.cpp:

(AccessibleText::isInRange): Use isPointInRange instead of
comparePositions.

1:45 PM Changeset in webkit [266486] by timothy_horton@apple.com

• 2 edits in trunk/LayoutTests

RWT's lint-test-files complains about nonexistent editing/images tests

• TestExpectations:

Remove a stale expectation for a directory that has been deleted.

1:41 PM Changeset in webkit [266485] by timothy_horton@apple.com

• 5 edits in trunk/Source

iPad + Trackpad: JW Library highlighting and edit menus don't appear
​https://bugs.webkit.org/show_bug.cgi?id=216086

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isJWLibrary):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
Add JW Library to the list.

1:32 PM Changeset in webkit [266484] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266363. rdar://problem/68229370

Wheel event region code is not fully disabled
​https://bugs.webkit.org/show_bug.cgi?id=216008
<rdar://problem/68086333>

Reviewed by Simon Fraser.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
• rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):

Use the relevant ENABLE flag rather than !PLATFORM_IOS to compile out the code.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:21 PM Changeset in webkit [266483] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://67281310 ([ Rosetta Layout Tests ] REGRESSION (r265639): [ Big Sur ] 1 canvas layout test is a constant failure)
Removing test expectations that now pass on Big Sur Rosetta 20A2364

Unreviewed test gardening.

• platform/mac/TestExpectationsRosetta:

12:53 PM Changeset in webkit [266482] by Karl Rackler

• 2 edits in trunk/LayoutTests

rdar://66802945 (REGRESSION (20A2323e-20A234b): [ Layout Test] 1 canvas layout test is a constant failure)
Removing test expectations that now pass on Big Sur 20A2364

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:44 PM Changeset in webkit [266481] by Chris Dumez

• 7 edits in trunk

New AutoParam timeline events should have their startTime adjusted when they are in the past
​https://bugs.webkit.org/show_bug.cgi?id=216080

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:

Source/WebCore:

New AutoParam timeline events should have their startTime adjusted when they are in the past.
We adjust the time to be the current time when it is in the past.

No new tests, rebaselined existing tests.

• Modules/webaudio/AudioParam.cpp:

12:20 PM Changeset in webkit [266480] by Devin Rousso

• 36 edits
  1 copy
  1 move
  1 add
  1 delete in trunk

Web Inspector: allow event breakpoints to be configured when they're added
​https://bugs.webkit.org/show_bug.cgi?id=215747

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/Breakpoint.js:

(WI.Breakpoint):
(WI.Breakpoint.prototype.get displayName): Added.
(WI.Breakpoint.prototype.addAction): Added.
(WI.Breakpoint.prototype.removeAction):
(WI.Breakpoint.prototype._handleBreakpointActionChanged): Added.
(WI.Breakpoint.prototype.createAction): Deleted.
(WI.Breakpoint.prototype.recreateAction): Deleted.
(WI.Breakpoint.prototype.breakpointActionDidChange): Deleted.

• UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint.displayNameForType):
(WI.DOMBreakpoint.prototype.get displayName): Added.

• UserInterface/Models/EventBreakpoint.js:

(WI.EventBreakpoint.get editable): Added.
(WI.EventBreakpoint.fromJSON):
(WI.EventBreakpoint.prototype.get displayName): Added.
(WI.EventBreakpoint.prototype.get editable):

• UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.get displayName): Added.

• UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.prototype.get displayName): Added.
Add a get displayName "virtual" member function.

• UserInterface/Models/BreakpointAction.js:

(WI.BreakpointAction):
(WI.BreakpointAction.fromJSON):
(WI.BreakpointAction.prototype.get type):
(WI.BreakpointAction.prototype.set type): Added.
(WI.BreakpointAction.prototype.set data): Added.
(WI.BreakpointAction.prototype.get breakpoint): Deleted.
Remove the requirement that WI.BreakpointAction be passed a WI.Breakpoint when its
constructed. Instead, have WI.BreakpointAction dispatch events when its type or data
changes.

• UserInterface/Views/BreakpointActionView.js:

(WI.BreakpointActionView):
(WI.BreakpointActionView.prototype._pickerChanged):
(WI.BreakpointActionView.prototype._appendActionButtonClicked):
(WI.BreakpointActionView.prototype._removeAction):
(WI.BreakpointActionView.prototype._updateBody):
(WI.BreakpointActionView.prototype._handleLogInputInput): Added.
(WI.BreakpointActionView.prototype._handleJavaScriptCodeMirrorChange): Added.
(WI.BreakpointActionView.prototype._logInputChanged): Deleted.
(WI.BreakpointActionView.prototype._codeMirrorBlurred): Deleted.
Call functions on the delegate instead of directly manipulating a WI.Breakpoint as there
is no longer a WI.Breakpoint to manipulate since WI.BreakpointAction doesn't have one.

• UserInterface/Controllers/BreakpointPopoverController.js: Removed.
• UserInterface/Views/BreakpointPopoverController.css: Removed.
• UserInterface/Views/BreakpointPopover.js: Renamed from Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css.

(WI.BreakpointPopover):
(WI.BreakpointPopover.appendContextMenuItems):
(WI.BreakpointPopover.prototype.get breakpoint):
(WI.BreakpointPopover.prototype.show):
(WI.BreakpointPopover.dismiss):
(WI.BreakpointPopover.prototype.completionControllerShouldAllowEscapeCompletion):
(WI.BreakpointPopover.prototype.breakpointActionViewAppendActionView):
(WI.BreakpointPopover.prototype.breakpointActionViewRemoveActionView):
(WI.BreakpointPopover.prototype.breakpointActionViewResized):
(WI.BreakpointPopover.prototype.populateContent):
(WI.BreakpointPopover.prototype.addRow):
(WI.BreakpointPopover.prototype.createBreakpoint):
(WI.BreakpointPopover.prototype._presentOverTargetElement):
(WI.BreakpointPopover.prototype._parseIgnoreCountNumber):
(WI.BreakpointPopover.prototype._updateIgnoreCountText):
(WI.BreakpointPopover.prototype._createAddActionButton):
(WI.BreakpointPopover.prototype._insertBreakpointActionView):
(WI.BreakpointPopover.prototype._handleEnabledCheckboxChange):
(WI.BreakpointPopover.prototype._handleConditionCodeMirrorBeforeChange):
(WI.BreakpointPopover.prototype._handleConditionCodeMirrorChange):
(WI.BreakpointPopover.prototype._handleIgnoreCountInputChange):
(WI.BreakpointPopover.prototype._handleAddActionButtonClick):
(WI.BreakpointPopover.prototype._handleAutoContinueCheckboxChange):

• UserInterface/Views/BreakpointPopover.css: Added.

(.popover .edit-breakpoint-popover-content):
(.popover .edit-breakpoint-popover-content.wide):
(.popover .edit-breakpoint-popover-content > label.toggle):
(.popover .edit-breakpoint-popover-content > table):
(.popover .edit-breakpoint-popover-content > table > tr > th):
(.popover .edit-breakpoint-popover-content > table > tr > td):
(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor):
(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor > .CodeMirror):
(.popover .edit-breakpoint-popover-content.wide .condition > .CodeMirror):
(.popover .edit-breakpoint-popover-content input#edit-breakpoint-popover-ignore-count):
(.popover .edit-breakpoint-popover-content input:is(#edit-breakpoint-popover-ignore-count, #edit-breakpoint-popover-auto-continue)):
(.popover .edit-breakpoint-popover-content > .reference-page-link-container):
(body[dir=ltr] .popover .edit-breakpoint-popover-content > .reference-page-link-container):
(body[dir=rtl] .popover .edit-breakpoint-popover-content > .reference-page-link-container):
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content > table > tr > th):

• UserInterface/Views/EventBreakpointPopover.js:

(WI.EventBreakpointPopover):
(WI.EventBreakpointPopover.get editable): Added.
(WI.EventBreakpointPopover.prototype.dismiss):
(WI.EventBreakpointPopover.prototype.populateContent): Added.
(WI.EventBreakpointPopover.prototype.createBreakpoint): Added.
(WI.EventBreakpointPopover.prototype._showSuggestionsView):
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputKeydown): Added.
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputInput): Added.
(WI.EventBreakpointPopover.prototype._handleDOMEventNameInputBlur): Added.
(WI.EventBreakpointPopover.prototype.get breakpoint): Deleted.
(WI.EventBreakpointPopover.prototype.show): Deleted.
(WI.EventBreakpointPopover.prototype._presentOverTargetElement): Deleted.

• UserInterface/Views/EventBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .event input): Added.
(.popover .edit-breakpoint-popover-content .event:last-child input): Added.
(.popover .edit-breakpoint-popover-content .event input::placeholder): Added.
(.popover .event-breakpoint-content): Deleted.
(.popover .event-breakpoint-content > input): Deleted.
(.popover .event-breakpoint-content > input::placeholder): Deleted.
(.popover .event-breakpoint-content .reference-page-link-container): Deleted.

• UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover):
(WI.URLBreakpointPopover.get editable): Added.
(WI.URLBreakpointPopover.prototype.populateContent): Added.
(WI.URLBreakpointPopover.prototype.createBreakpoint): Added.
(WI.URLBreakpointPopover.prototype._updateEditor):
(WI.URLBreakpointPopover.prototype.get breakpoint): Deleted.
(WI.URLBreakpointPopover.prototype.show): Deleted.
(WI.URLBreakpointPopover.prototype.dismiss): Deleted.
(WI.URLBreakpointPopover.prototype._createEditor): Deleted.
(WI.URLBreakpointPopover.prototype._presentOverTargetElement): Deleted.

• UserInterface/Views/URLBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .url .editor): Added.
(.popover .edit-breakpoint-popover-content .url:last-child .editor): Added.
(.popover .edit-breakpoint-popover-content .url .editor > .CodeMirror): Added.
(.popover .edit-breakpoint-popover-content .url .editor > .CodeMirror-scroll): Added.
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content .url .editor): Added.
(.popover .url-breakpoint-content): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor > .CodeMirror): Deleted.
(.popover .url-breakpoint-content > .editor-wrapper > .editor > .CodeMirror-scroll): Deleted.
(.popover .url-breakpoint-content .reference-page-link-container): Deleted.
(@media (prefers-color-scheme: dark) .popover .url-breakpoint-content > .editor-wrapper > .editor): Deleted.
Make WI.BreakpointPopoverController into a subclass of WI.Popover with a static member
function for adding context menu items. This allows both WI.EventBreakpointPopover and
WI.URLBreakpointPopover to inherit from WI.BreakpointPopover, meaning that they can show
the configuration UI when adding the breakpoint instead of as a second step after creating
the breakpoint.

• UserInterface/Models/ProbeSet.js:

(WI.ProbeSet.prototype.createProbe):
Update to use newly named WI.Breakpoint.prototype.addAction.

• UserInterface/Views/ContextMenuUtilities.js:
• UserInterface/Views/DOMBreakpointTreeElement.js:

(WI.DOMBreakpointTreeElement):
(WI.DOMBreakpointTreeElement.displayNameForType): Deleted.

• UserInterface/Views/EventBreakpointTreeElement.js:

(WI.EventBreakpointTreeElement):

• UserInterface/Views/JavaScriptBreakpointTreeElement.js:

(WI.JavaScriptBreakpointTreeElement):
(WI.JavaScriptBreakpointTreeElement.prototype.updateTitles):

• UserInterface/Views/URLBreakpointTreeElement.js:

(WI.URLBreakpointTreeElement):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
Use the new WI.Breakpoint.prototype.get displayName.

• UserInterface/Base/Main.js:
• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.populateContextMenu):

• UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
Replace WI.breakpointPopoverController with WI.BreakpointPopover.

• UserInterface/Views/Variables.css:

(:root):

• UserInterface/Views/Main.css:

(.reference-page-link):
Create a variable for the size of the reference page (?) button so it can be use elsewhere.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/LoadLocalizedStrings.js:

(WI.repeatedUIString.debuggerStatements): Added.
(WI.repeatedUIString.allExceptions): Added.
(WI.repeatedUIString.uncaughtExceptions): Added.
(WI.repeatedUIString.assertionFailures): Added.
(WI.repeatedUIString.allMicrotasks): Added.
(WI.repeatedUIString.allAnimationFrames): Added.
(WI.repeatedUIString.allIntervals): Added.
(WI.repeatedUIString.allEvents): Added.
(WI.repeatedUIString.allTimeouts): Added.
Create repeated localized string helper functions for special breakpoints.

• UserInterface/Base/ReferencePage.js: Added.

Add an enum for reference page URLs.

• UserInterface/Main.html:

LayoutTests:

• inspector/debugger/breakpoint-action-eval.html:
• inspector/debugger/breakpoint-action-log.html:
• inspector/debugger/probe-manager-add-remove-actions.html:
• inspector/debugger/stepping/stepping-through-autoContinue-breakpoint.html:
• inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.async suite):
(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases):

• inspector/dom/breakpoint-for-event-listener.html:

Update to use newly named WI.Breakpoint.prototype.addAction.

12:19 PM Changeset in webkit [266479] by wilander@apple.com

• 8 edits in trunk

Storage Access API: Allow requests for storage access from nested iframes
​https://bugs.webkit.org/show_bug.cgi?id=216019
<rdar://problem/68109918>

Reviewed by Alex Christensen.

It was decided browsers should support requests for storage access from nested
iframes as part of the standardization of the Storage Access API. The issue is
discussed here: ​https://github.com/privacycg/storage-access/issues/10.

Source/WebCore:

No new tests. Existing tests were changed.

• dom/DocumentStorageAccess.cpp:

(WebCore::DocumentStorageAccess::requestStorageAccessQuickCheck):

LayoutTests:

• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database-expected.txt:
• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-database.html:

Now sets a cookie for the third party so that the test checks granted access.

• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe-expected.txt:
• http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html:

Now sets a cookie for the third party so that the test checks granted access.

• http/tests/storageAccess/resources/nesting-iframe.html:

Changed to now expect to be granted storage access.

12:15 PM Changeset in webkit [266478] by Jonathan Bedard

• 2 edits
  1 add in trunk/Tools

[webkitcorepy] Add NoAction class
​https://bugs.webkit.org/show_bug.cgi?id=216079
<rdar://problem/68216301>

Reviewed by Dewei Zhu.

This is an argparse action we've duplicated in a few Internal scripts, it should
be in a shared library.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/arguments.py: Added.

(NoAction): argparse action supporting a binary flag.

11:44 AM Changeset in webkit [266477] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: duplicate "Timeline Recording 1" on open
​https://bugs.webkit.org/show_bug.cgi?id=216060

Reviewed by Brian Burg.

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager):
(WI.TimelineManager.prototype.get recordings): Deleted.
Don't reset in the constructor as this is already done in enable and disable, which
is called whenever the Timeline Tab is added/removed.

• UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):
There should never be any existing recordings when adding the Timelines Tab, as they should
have been removed when the tab was last removed (via WI.TimelineManager.prototype.disable).

11:32 AM Changeset in webkit [266476] by Chris Dumez

• 21 edits in trunk

OfflineAudioContext incorrectly renders at beginning of output buffer after resuming
​https://bugs.webkit.org/show_bug.cgi?id=216078

Reviewed by Geoff Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/adding-events-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

Source/WebCore:

OfflineAudioContext incorrectly renders at beginning of output buffer after resuming,
instead of rendering where it left off.

No new tests, rebaselined existing tests.

• Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

• Modules/webaudio/OfflineAudioDestinationNode.h:

10:38 AM Changeset in webkit [266475] by Devin Rousso

• 4 edits in trunk/LayoutTests

REGRESSION: [ macOS ] media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=215614
<rdar://problem/67333849>

Reviewed by Eric Carlson.

• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl-expected.txt:

• platform/mac/TestExpectations:

10:37 AM Changeset in webkit [266474] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.7

Tag Safari-610.1.28.1.7.

10:33 AM Changeset in webkit [266473] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.7

10:28 AM Changeset in webkit [266472] by Karl Rackler

• 52 adds in trunk/LayoutTests/platform

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Added.
• platform/mac-catalina/fast/css/continuationCrash-expected.txt: Added.
• platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-positioned-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-sizes-expected.txt: Added.
• platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Added.
• platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Added.
• platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Added.
• platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Added.
• platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
• platform/mac-catalina/fast/forms/select-selected-expected.txt: Added.
• platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Added.
• platform/mac-catalina/fast/parser/document-write-option-expected.txt: Added.
• platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
• platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Added.
• platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
• platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Added.
• platform/mac-mojave/fast/css/continuationCrash-expected.txt: Added.
• platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-positioned-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-sizes-expected.txt: Added.
• platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Added.
• platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Added.
• platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Added.
• platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
• platform/mac-mojave/fast/forms/select-selected-expected.txt: Added.
• platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Added.
• platform/mac-mojave/fast/parser/document-write-option-expected.txt: Added.
• platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
• platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
• platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Added.

10:28 AM Changeset in webkit [266471] by Karl Rackler

• 19 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Copy current test expectations to Catalina and Mojave and update Big Sur

Unreviewed test gardening.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

10:04 AM Changeset in webkit [266470] by sihui_liu@apple.com

• 3 edits in trunk

REGRESSION (r264661): Crashes in WebCore::wrap<WebCore::Blob> in CloneDeserializer
​https://bugs.webkit.org/show_bug.cgi?id=215835

Reviewed by Youenn Fablet.

Partially revert r264661 as there are cases, other than our previous IDB, where we may not use JSDOMGlobalObject
for serialization and deserialization, like the one showed in the crashlog. Therefore, we still need the check
for JSDOMGlobalObject.

API Test: WebKit.EvaluateJavaScriptThatCreatesBlob

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

9:38 AM Changeset in webkit [266469] by Chris Dumez

• 4 edits in trunk

Implement event convergence for AudioParam.setTargetAtTime()
​https://bugs.webkit.org/show_bug.cgi?id=216064

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test that is now passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/set-target-conv-expected.txt:

Source/WebCore:

Implement event convergence for AudioParam.setTargetAtTime(). This is to match Chromium's
behavior and pass the corresponding WPT test.

No new tests, rebaselined existing test.

• Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::hasSetTargetConverged):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

9:19 AM Changeset in webkit [266468] by youenn@apple.com

• 53 edits
  5 copies
  2 deletes in trunk

Introduce a C++ chain of operations in RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=216006

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-addIceCandidate-timing.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-iceConnectionState.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-operations.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-perfect-negotiation.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-parameterless.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-rollback-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-track-stats.https-expected.txt:
• web-platform-tests/webrtc/RTCRtpTransceiver.https-expected.txt:
• web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Remove RTCPeerConnection JS built-ins and introduce a C++ version.
This allows to make replaceTrack part of the chain of operation.
Also update setLocalDescription to take no parameters.

Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Headers.cmake:
• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::PeerConnectionBackend::transceiverFromSender): Deleted.

• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):

• Modules/mediastream/RTCIceCandidate.h:
• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::getStats):
(WebCore::RTCPeerConnection::doClose):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):
(WebCore::RTCPeerConnection::chainOperation):
(WebCore::RTCPeerConnection::initializeWith): Deleted.
(WebCore::RTCPeerConnection::queuedCreateOffer): Deleted.
(WebCore::RTCPeerConnection::queuedCreateAnswer): Deleted.
(WebCore::RTCPeerConnection::queuedSetLocalDescription): Deleted.
(WebCore::RTCPeerConnection::queuedSetRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::queuedAddIceCandidate): Deleted.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js: Removed.
• Modules/mediastream/RTCPeerConnectionInternals.js: Removed.
• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::RTCRtpSender):
(WebCore::RTCRtpSender::replaceTrack):
(WebCore::RTCRtpSender::isCreatedBy const):
(WebCore::RTCRtpSender::dtmf):
(WebCore::RTCRtpSender::currentTransceiverDirection const):

• Modules/mediastream/RTCRtpSender.h:
• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/RTCRtpSenderBackend.h:
• Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create):

• Modules/mediastream/RTCSessionDescription.h:
• Modules/mediastream/RTCSessionDescription.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doSetLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doSetRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiverFromTrackOrKind):
(WebCore::LibWebRTCPeerConnectionBackend::newRemoteTransceiver):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

• fast/mediastream/RTCIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt:
• fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid-expected.txt:
• webrtc/libwebrtc/release-while-creating-offer-expected.txt:
• webrtc/remove-track-expected.txt:
• webrtc/remove-track.html:

Make sure we are in a stable state before going to removeTrack actual test.
Also make sure to call setRemoteDescription for second test.

9:10 AM Changeset in webkit [266467] by youenn@apple.com

• 28 edits
  1 move in trunk/Source

Introduce a ThreadableWebSocketChannel identifier
​https://bugs.webkit.org/show_bug.cgi?id=216034

Reviewed by Alex Christensen.

Source/WebCore:

Clean-up code to have a single identifier for all WebSockets.
We use a WebSocketIdentifier that is now moved from WebKit to WebCore.
Introduce CookieGetter name following comments from ​https://bugs.webkit.org/show_bug.cgi?id=215928 review.
No change of behavior.

• Headers.cmake:
• Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::ThreadableWebSocketChannel):

• Modules/websockets/ThreadableWebSocketChannel.h:

(WebCore::ThreadableWebSocketChannel::ref):
(WebCore::ThreadableWebSocketChannel::deref):
(WebCore::ThreadableWebSocketChannel::identifier const):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::clientHandshakeRequest const):

• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest const):

• Modules/websockets/WebSocketHandshake.h:
• Modules/websockets/WebSocketIdentifier.h: Added.
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• WebCore.xcodeproj/project.pbxproj:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):

• page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

• page/SocketProvider.h:

Source/WebKit:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:
• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkSocketChannel.h:
• NetworkProcess/NetworkSocketStream.h:
• Scripts/webkit/messages.py:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::WebSocketChannel):

• WebProcess/Network/WebSocketChannel.h:

(WebKit::WebSocketChannel::identifier const): Deleted.

• WebProcess/Network/WebSocketChannelManager.h:
• WebProcess/Network/WebSocketIdentifier.h: Removed.
• WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

• WebProcess/Network/WebSocketProvider.h:
• WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::create):
(WebKit::WebSocketStream::WebSocketStream):

• WebProcess/Network/WebSocketStream.h:

8:52 AM Changeset in webkit [266466] by achristensen@apple.com

• 9 edits in trunk

Allow direct creation of replacement codec
​https://bugs.webkit.org/show_bug.cgi?id=216063

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/replacement-encodings.any-expected.txt:
• web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt:

Source/WebCore:

Chrome and Firefox do.
Covered by a newly passing web platform test.

• platform/text/TextCodecReplacement.cpp:

(WebCore::TextCodecReplacement::registerEncodingNames):

• platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::TextEncoding):

LayoutTests:

• fast/encoding/charset-replacement-expected.txt:
• fast/encoding/charset-replacement.html:

8:50 AM Changeset in webkit [266465] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Timelines: Frames: clicking a record bar to select it when another record bar is already selected instead removes all selections
​https://bugs.webkit.org/show_bug.cgi?id=216045
<rdar://problem/68156740>

Reviewed by Brian Burg.

• UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WI.RenderingFrameTimelineOverviewGraph.prototype._mouseClicked):

8:49 AM Changeset in webkit [266464] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Graphics: reloading the page doesn't automatically deselect shaders if they are shown
​https://bugs.webkit.org/show_bug.cgi?id=216054
<rdar://problem/68167882>

Reviewed by Brian Burg.

• UserInterface/Views/GraphicsTabContentView.js:

(WI.GraphicsTabContentView.prototype._removeCanvas):

8:48 AM Changeset in webkit [266463] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: re-enabling the JavaScript Allocations timeline doesn't show previously captured heap snapshots in the table
​https://bugs.webkit.org/show_bug.cgi?id=216057
<rdar://problem/68172848>

Reviewed by Brian Burg.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView):
Add a WI.HeapAllocationsTimelineDataGridNode for each WI.HeapAllocationsTimelineRecord
that already exists when the WI.HeapAllocationsTimelineView is created.

8:37 AM Changeset in webkit [266462] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

[LFC][IFC] Start constructing InlineBoxes for inline runs
​https://bugs.webkit.org/show_bug.cgi?id=215168

Reviewed by Antti Koivisto.

In this transitional step we start constructing inline boxes. However at this point, each run gains a dedicated inline box.
While this is somewhat incorrect from the spec point of view, this is all internal and very tempoarary at this point.

• layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

• layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::rectForRun const):
(WebCore::Layout::LineBox::alignHorizontally):
(WebCore::Layout::LineBox::alignVertically):
(WebCore::Layout::LineBox::adjustBaselineAndLineHeight):

• layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::inlineRectList const): Deleted.

8:35 AM Changeset in webkit [266461] by Aditya Keerthi

• 11 edits
  2 adds in trunk

[macOS] Update date picker when the inner control is edited
​https://bugs.webkit.org/show_bug.cgi?id=216004

Reviewed by Wenson Hsieh.

Source/WebCore:

The value of the attached date picker should match the value in the
inner control. In order to achieve this behavior, m_dateTimeChooser
is notified whenever didChangeValueFromControl is called.

Note that the attached date picker's value is not updated on a
programmatic edit (setting input.value), as a sudden change not
triggered by the user would result in a poor user experience.

Test: fast/forms/date/date-editable-components/date-picker-update-on-edit.html

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::didChangeValueFromControl):

Source/WebKit:

• UIProcess/mac/WebDateTimePickerMac.mm:

(WebKit::WebDateTimePickerMac::showDateTimePicker):

If showDateTimePicker is called while a picker is already being
displayed, call updatePicker: rather than showPicker:.

(-[WKDateTimePicker initWithParams:inView:]):

The NSDatePicker and NSDateFormatter should use a UTC timezone.
This is necessary as all double values passed into WKDateTimePicker
are UTC timestamps. This has no effect on the value returned to
the WebProcess on user selection, as a timezone-agnostic format
string is used.

(-[WKDateTimePicker updatePicker:]):

Set the date value of the owned NSDatePicker to the value in the
DateTimeChooserParameters.

Tools:

Added dateTimePickerValue testing hook in order to enable testing the
current value of the presented date picker. The returned value is a
UTC timestamp is milliseconds, matching the date input's valueAsNumber.

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::dateTimePickerValue const):

• WebKitTestRunner/mac/UIScriptControllerMac.h:
• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::dateTimePickerValue const):

LayoutTests:

Added a test to verify that the date picker is updated when the user edits the control.

• fast/forms/date/date-editable-components/date-picker-update-on-edit-expected.txt: Added.
• fast/forms/date/date-editable-components/date-picker-update-on-edit.html: Added.
• resources/ui-helper.js:

(window.UIHelper.dateTimePickerValue):

8:32 AM Changeset in webkit [266460] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] The WPT server is not always starting when running layout tests
​https://bugs.webkit.org/show_bug.cgi?id=216035

Reviewed by Youenn Fablet.

The Web platform test server is not always starting when running layout tests using Cygwin. It seems that starting the WPT server
takes longer time on Windows. Currently, the timeout is set to 20 seconds with polling every second. This patch addresses this
issue by waiting up to 60 seconds with polling every 10th second.

• Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase.start):

8:30 AM Changeset in webkit [266459] by Caio Lima

• 2 edits in trunk/JSTests

[ARMv7] Skip stress/intl-segmenter.js
​https://bugs.webkit.org/show_bug.cgi?id=216074

Unreviewed Gardening.

Skipping this test for ARMv7, since some boards we have are using ICU
60 and causes issues for this test.

• stress/intl-segmenter.js:

8:03 AM Changeset in webkit [266458] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] Update test expectations for failures only seen on one specific bot
​https://bugs.webkit.org/show_bug.cgi?id=216036

Unreviewed test gardening.

• platform/win/TestExpectations:

7:45 AM Changeset in webkit [266457] by achristensen@apple.com

• 13 edits in trunk

Align UTF-16 decoder with Chrome, Firefox, and specification
​https://bugs.webkit.org/show_bug.cgi?id=216058

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-streaming.any-expected.txt:
• web-platform-tests/encoding/textdecoder-fatal-streaming.any.worker-expected.txt:
• web-platform-tests/encoding/textdecoder-utf16-surrogates.any-expected.txt:
• web-platform-tests/encoding/textdecoder-utf16-surrogates.any.worker-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

• platform/text/TextCodecUTF16.h:

(): Deleted.

LayoutTests:

• imported/blink/fast/encoding/utf-16-odd-byte-expected.txt:

7:42 AM Changeset in webkit [266456] by Diego Pino Garcia

• 2 edits in trunk/Tools

Unreviewed. Follow-up r266450, fix script due to missing variable.

• Scripts/clean-webkit:

(removeFiles): Add missing argument 'fs'.
(main):

6:29 AM Changeset in webkit [266455] by Philippe Normand

• 31 edits
  4 adds
  12 deletes in trunk

[Flatpak SDK] Update to FDO 20.08
​https://bugs.webkit.org/show_bug.cgi?id=215763

Reviewed by Žan Doberšek.

.:

• .gitignore: Ignore buildstream local Flatpak repository. This is created only when

manually building the SDK.

Tools:

Highlights:

• ICU 67 (see bug 215327)
• gcc update from 9.3.0 to 10.0
• clang update from 8.0 to 10.0
• perf is now included
• usable pipewire (host needs a working daemon and recent enough xdg-desktop-portal though)
• Mesa is no longer loaded from the flathub GL extension, but included in our downstream SDK, with debug symbols

This patch only includes the build definitions updates, bumping the SDK branch to 0.3. The
actual migration will be landed in a follow-up patch.

• buildstream/elements/flatpak-platform-extensions.bst:
• buildstream/elements/flatpak-runtimes.bst:
• buildstream/elements/flatpak/platform.bst:
• buildstream/elements/flatpak/sdk.bst:
• buildstream/elements/freedesktop-sdk.bst:
• buildstream/elements/sdk-build-depends/swig.bst:
• buildstream/elements/sdk-platform.bst:
• buildstream/elements/sdk.bst:
• buildstream/elements/sdk/at-spi2-atk.bst: Removed.
• buildstream/elements/sdk/at-spi2-core.bst: Removed.
• buildstream/elements/sdk/atk.bst: Removed.
• buildstream/elements/sdk/brotli.bst: Removed.
• buildstream/elements/sdk/glib.bst:
• buildstream/elements/sdk/gobject-introspection.bst: Removed.
• buildstream/elements/sdk/graphene.bst:
• buildstream/elements/sdk/gst-plugins-bad.bst:
• buildstream/elements/sdk/gst-plugins-good.bst:
• buildstream/elements/sdk/gstreamer.bst:
• buildstream/elements/sdk/gtk+-3.bst:
• buildstream/elements/sdk/gtk.bst:
• buildstream/elements/sdk/libdrm.bst: Added.
• buildstream/elements/sdk/libgcrypt.bst:
• buildstream/elements/sdk/libsecret.bst:
• buildstream/elements/sdk/libsoup.bst:
• buildstream/elements/sdk/libsrtp2.bst: Removed.
• buildstream/elements/sdk/mesa.bst: Added.
• buildstream/elements/sdk/pygobject.bst:
• buildstream/elements/sdk/python2-pygobject.bst:
• buildstream/elements/sdk/rr.bst:
• buildstream/elements/sdk/shared-mime-info.bst:
• buildstream/elements/sdk/v4lutils.bst: Removed.
• buildstream/elements/sdk/woff2.bst:
• buildstream/elements/sdk/xorg-server.bst:
• buildstream/elements/test-infra/httpd.bst:
• buildstream/patches/fdo/0001-Pango-Bump-to-1.45-master.patch: Removed.
• buildstream/patches/fdo/0001-dav1d-Bump-to-0.7.0.patch: Removed.
• buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Removed.
• buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Removed.
• buildstream/patches/mesa/mesa_libdrm_deps.patch: Added.
• buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch:

Removed because a variant was landed upstream 2 years ago:
​https://gitlab.freedesktop.org/xorg/xserver/-/commit/319af6f471912160ab3eb6395ef50f9950063d43

• buildstream/project.conf:
• flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): White-list a few Mesa environment variables.

2:45 AM Changeset in webkit [266454] by youenn@apple.com

• 4 edits in trunk/Source/WebCore

Safari is not able to hear audio when using WebRTC in multiple tabs
​https://bugs.webkit.org/show_bug.cgi?id=215270
<rdar://problem/66736746>

Reviewed by Eric Carlson.

Covered by manually testing that audio continues when two pages in the same process create a peer connection,
one plays audio with WebRTC and the second one is closed.
Before the patch, the closing page would stop the audio device module, even though the first page would like the module to continue playing.
Fix this by creating an audio module per page instead of process wide.

• platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::initializePeerConnectionFactoryAndThreads):
(WebCore::LibWebRTCProvider::factory):
(WebCore::LibWebRTCProvider::createPeerConnectionFactory):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

2:31 AM Changeset in webkit [266453] by Diego Pino Garcia

• 5 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines and expectations after r266452.

• platform/glib/TestExpectations:
• platform/glib/fetch/fetch-url-serialization-expected.txt: Update after r266399.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt: Update after r266398.
• platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt: Update after r266417.

1:04 AM Changeset in webkit [266452] by Said Abou-Hallawa

• 4 edits in trunk/Source

Unreviewed, reverting r266449.

Underlying frameworks do not work correctly for loopCount >=
1.

Reverted changeset:

"[CG] REGRESSION (Big Sur): A GIF image with a finite
loopCount loops an extra cycle"
​https://bugs.webkit.org/show_bug.cgi?id=216018
​https://trac.webkit.org/changeset/266449

Sep 1, 2020:

11:57 PM Changeset in webkit [266451] by Nikita Vasilyev

• 4 edits
  2 adds in trunk

REGRESSION(r243264): Web Inspector: Style pane doesn't update after toggling CSS class
​https://bugs.webkit.org/show_bug.cgi?id=202065
<rdar://problem/55149141>

Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles):
(WI.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
(WI.DOMNodeStyles.prototype.refresh):
(WI.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
r243264 introduced this bug by never clearing _styleMap making it impossible to diff old
and new style declarations. Create and clear _styleMap at the same place as it was before r243264.

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.layout):
Layout now always re-layouts everything. Rules with modified selectors are now preserved by
exiting layout early.

(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionSelectorWillChange):
Remove logic that tried to preserve indexes of CSS rules with modified selectors that
don't match (SectionIndexSymbol and everything related to it). Instead, avoid re-layout after
editing a selector.

LayoutTests:

Added a test to verify that WI.DOMNodeStyles.Event.Refreshed fires with appropriate
significantChange flag.

• inspector/css/node-styles-refreshed-expected.txt: Added.
• inspector/css/node-styles-refreshed.html: Added.

9:50 PM Changeset in webkit [266450] by Diego Pino Garcia

• 2 edits in trunk/Tools

[Flatpak SDK] Adapt clean-webkit script to flatpak
​https://bugs.webkit.org/show_bug.cgi?id=216044

Reviewed by Philippe Normand.

Keep relevant directories in WebKitBuild/ when using flatpak.

• Scripts/clean-webkit:

(usesFlatpak):
(listWebKitBuildFiles):
(removeFiles):
(main):

8:13 PM Changeset in webkit [266449] by commit-queue@webkit.org

• 4 edits in trunk/Source

[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
​https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/66660579>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-09-01
Reviewed by Tim Horton.

Source/WebCore:

Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::repetitionCount const):

Source/WTF:

Add a new macro for the new accurate behavior of CGImageSource.

Unrelated change: Fix the conditions for enabling the WebP images.

• wtf/PlatformHave.h:

7:54 PM Changeset in webkit [266448] by commit-queue@webkit.org

• 26 edits in trunk

Align ISO-2022-JP and Shift_JIS encodings with Chrome, Firefox, and the specification
​https://bugs.webkit.org/show_bug.cgi?id=216052

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-csshiftjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms932-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms_kanji-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-shift-jis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-sjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-windows-31j-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-x-sjis-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

• platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::TextCodecCJK):
(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucJPEncode):
(WebCore::TextCodecCJK::iso2022JPEncode):
(WebCore::shiftJISEncode):
(WebCore::big5Encode):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h:
• platform/text/TextCodecICU.cpp:

7:18 PM Changeset in webkit [266447] by ysuzuki@apple.com

• 6 edits in trunk

Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled
​https://bugs.webkit.org/show_bug.cgi?id=216043
<rdar://problem/66394369>

Reviewed by Mark Lam.

Source/JavaScriptCore:

• tools/JSDollarVM.cpp:

(JSC::functionIsGigacageEnabled):
(JSC::JSDollarVM::finishCreation):

LayoutTests:

The test is stressing Gigacage Exhaustion. So without Gigacage, this test is meaningless.
GuardMalloc behaves differently from usual Malloc / bmalloc: which crashes when exhausting memory.
As a result, we observe test crash when GuardMalloc is enabled. Since our test harness does not support
GuardMalloc annotation in TestExpectations, we needed a workaround to avoid this crash.

• TestExpectations:
• fast/css-custom-paint/out-of-memory-while-adding-worklet-module-expected.txt:
• fast/css-custom-paint/script-tests/out-of-memory-while-adding-worklet-module.js:

(vm.isGigacageEnabled.useAllMemory.try.get Object):
(vm.isGigacageEnabled.useAllMemory.try.foo):
(vm.isGigacageEnabled):
(useAllMemory.try.get Object): Deleted.
(useAllMemory.try.foo): Deleted.
(): Deleted.
(catch): Deleted.

6:56 PM Changeset in webkit [266446] by Hector Lopez

• 51 edits in trunk

Unreviewed, reverting r266408.

Revision caused constant crashes on iOS and macOS

Reverted changeset:

"Convert runtime flag to setting for lazy image loading"
​https://bugs.webkit.org/show_bug.cgi?id=215610
​https://trac.webkit.org/changeset/266408

6:55 PM Changeset in webkit [266445] by ddkilzer@apple.com

• 3 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] InternalFormat::blendSupport is uninitialized by constructor
<​https://webkit.org/b/216053>
<rdar://problem/68166032>

Reviewed by Kenneth Russell.

• changes.diff: Add this patch.
• src/libANGLE/formatutils.cpp:

(gl::InternalFormat::InternalFormat):

• Initialize blendSupport to NeverSupported.

6:51 PM Changeset in webkit [266444] by Alan Coon

• 1 copy in tags/Safari-610.1.28.0.5

Tag Safari-610.1.28.0.5.

6:46 PM Changeset in webkit [266443] by dino@apple.com

• 8 edits
  4 adds in trunk

REGRESSION(r262366): MotionMark1.1 | macOS | Some devices | 1-3% overall regression
​https://bugs.webkit.org/show_bug.cgi?id=215989
<rdar://problem/66845937>

Reviewed by Darin Adler.

Source/WebCore:

The new approach to compositing WebGL caused a slowdown in some
canvas performance tests. They were notifying the Document
of all drawing commands, even on 2d canvases that didn't need
to prepare before compositing.

The solution is to only add the Document as an observer
when necessary. This recovers the performance hit - measured
using the Canvas Lines MotionMark test.

Tests: fast/canvas/webgl/move-canvas-in-document-while-clean.html

fast/canvas/webgl/move-canvas-in-document.html

• dom/Document.cpp:

(WebCore::Document::prepareCanvasesForDisplayIfNeeded): Leave a FIXME
indicating that we should try to avoid the copyToVector if we
can ensure that the prepareForDisplay call will not mutate the HashSet.

• html/CanvasBase.cpp: Remove some copyToVector calls. It should be

fine to iterate over the HashSet for these notification functions.
(WebCore::CanvasBase::notifyObserversCanvasChanged):
(WebCore::CanvasBase::notifyObserversCanvasResized):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Don't add the Document as
a canvas observer. Wait until we know it is a context that needs observing.
(WebCore::HTMLCanvasElement::createContextWebGL): Now we can add it as an
observer.
(WebCore::HTMLCanvasElement::didMoveToNewDocument): Swap observation to the new
Document.
(WebCore::HTMLCanvasElement::insertedIntoAncestor): Ditto, but also be aware that
we might be in a "dirty" state, and thus need to immediately tell the new
document that the canvas needs preparation.
(WebCore::HTMLCanvasElement::removedFromAncestor): Remove the observer.
(WebCore::HTMLCanvasElement::needsPreparationForDisplay): Use a virtual function
on the context instead of checking the type.
(WebCore::HTMLCanvasElement::prepareForDisplay): Ditto.

• html/canvas/CanvasRenderingContext.h: New virtual functions to avoid type checking

in HTMLCanvasElement.
(WebCore::CanvasRenderingContext::compositingResultsNeedUpdating const):
(WebCore::CanvasRenderingContext::needsPreparationForDisplay const):
(WebCore::CanvasRenderingContext::prepareForDisplay):

• html/canvas/WebGLRenderingContextBase.cpp: Implementations of the virtual functions

that tell HTMLCanvasElement that it needs to prepareForDisplay.
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::didComposite):

• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

• fast/canvas/webgl/move-canvas-in-document-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean-expected.html: Added.
• fast/canvas/webgl/move-canvas-in-document-while-clean.html: Added.
• fast/canvas/webgl/move-canvas-in-document.html: Added.

6:31 PM Changeset in webkit [266442] by Alan Coon

• 3 edits in branches/safari-610-branch/Source/WTF

Cherry-pick r266145. rdar://problem/68179384

[Win] Assert failure under RunLoop::RunLoop
​https://bugs.webkit.org/show_bug.cgi?id=215812

Reviewed by Brent Fulgham.

The assert 'ASSERT(::IsWindow(m_runLoopMessageWindow))' under RunLoop::RunLoop will fail if the JSC API JSGlobalContextCreate*()
is being called by a client before WTF::initializeMainThread() has been called. The assertion fails because the method
RunLoop::registerRunLoopMessageWindowClass() has not been called yet, since it is only called when initializing the main thread.
This patch addresses this issue by making sure the window class has been registered before being referenced in RunLoop::RunLoopl
The method call is also removed from the main thread initialization, since the window class is only used in RunLoop::RunLoop,
making it sufficient to only be registered there. Also change the debug assert to a release assert, so we can catch similar
issues in release builds.

• wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
• wtf/win/RunLoopWin.cpp: (WTF::RunLoop::registerRunLoopMessageWindowClass): (WTF::RunLoop::RunLoop):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:30 PM Changeset in webkit [266441] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets should be reported as type 'websocket' in Network Tab
​https://bugs.webkit.org/show_bug.cgi?id=216055
<rdar://problem/68171040>

Reviewed by Darin Adler.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.shortDisplayNameForResourceType):

6:19 PM Changeset in webkit [266440] by Alan Coon

• 5 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266280. rdar://problem/68177624

REGRESSION (r263506): scale transform transitions won't overshoot
​https://bugs.webkit.org/show_bug.cgi?id=215826
<rdar://problem/67759310>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html

In r263506 we made a change where accelerated animations would set their animation-wide
timing functions using PlatformCAAnimation::setTimingFunction() instead of setting it
on individual keyframes. This change was required to support the unique ability of
JS-originated animations to specify both an animation-wide timing function as well as
per-keyframe timing functions.

In the case of CSS Transitions, this meant that instead of setting a per-keyframe timing
function, this change would set the animation-wide timing function since CSS Transitions
should map the transition-timing-function property to the "easing" property of the Animation
object exposed by the Web Animations API, not as the timing function of the single keyframe
interval.

However, this change surfaced a bug in Core Animation on macOS and iOS where a cubic-bezier()
timing function with y values above 1 get clipped when applied to a CAKeyframeAnimation using
the timingFunction property (singular) instead of the timingFunctions property (plural).

To work around this issue, we set Animation::property() on the generated Animation object passed
to GraphicsLayerCA to make it possible to detect when we're dealing with a CSS Transition and
set the timing function on the keyframe interval rather than on the animation itself.

Alas, this does not fix the case where a JS-originated animation will specify an animation-wide
timing function with a cubic-bezier() timing function with y values above 1. There is no known
workaround at this time for this case and this is covered by bug 215918.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

LayoutTests:

Add a new test that checks that a CSS Transition using a cubic-bezier() timing function with
a y value beyond 1 does not get clipped.

• platform/win/TestExpectations:
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1-expected.html: Added.
• webanimations/accelerated-css-transition-with-easing-y-axis-above-1.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266439] by Alan Coon

• 5 edits
  2 adds in branches/safari-610-branch

Cherry-pick r266241. rdar://problem/68177624

REGRESSION (r263506): timing of CSS Animation on ​https://animate.style is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=215807
<rdar://problem/66770136>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-css-animation-with-easing.html

In r263506, we added a way for accelerated animations to adhere to both a timing function set on the
animation, affecting the timing of the entire animation, as well as a timing function set on individual
keyframes, affecting the timing of the animation in a given interval. Alas, this change broke handling
of timing functions with implicit animation-timing-function on keyframes.

That code change assumed that the Animation object ultimately passed to GraphicsLayerCA::setupAnimation()
would return the animation-wide timing function through Animation::timingFunction(). This was correct for
JS-originated animations, but not for CSS Animations, since that value was set based on the computed CSS
property animation-timing-function for the target element. However, that CSS property does not specify
the animation-wide timing function, but rather the default timing function to use for keyframes should
they fail to specify an explicit timing function.

To fix this, first, we ensure that the animation-wide timing function is set on the Animation object,
changing KeyframeEffect::backingAnimationForCompositedRenderer() to always generate an Animation object
based on the effect, divorcing itself from the Animation object created through CSS.

Then, we add a new member to Animation to specify the default timing function for keyframes, allowing
GraphicsLayerCA to use it to determine the timing function when building keyframes.

• animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::backingAnimationForCompositedRenderer const): Always generate an Animation object based on the effect's properties, also setting the new defaultTimingFunctionForKeyframes in the case of a CSS Animation object.
• platform/animation/Animation.h: (WebCore::Animation::defaultTimingFunctionForKeyframes const): (WebCore::Animation::setDefaultTimingFunctionForKeyframes):
• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::animationHasStepsTimingFunction): Use the optional defaultTimingFunctionForKeyframes to determine whether a keyframe uses a steps timing function. (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Use the optional defaultTimingFunctionForKeyframes to determine the timing function for a keyframe.

LayoutTests:

Add a new test that checks that a CSS Animation with implicit and explicit animation-timing-function
values behave the same when running accelerated.

• webanimations/accelerated-css-animation-with-easing-expected.html: Added.
• webanimations/accelerated-css-animation-with-easing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266438] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266301. rdar://problem/68177648

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Brent Fulgham.

Add iokit-property to WebContent sandbox that should have been a part of r266282.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266437] by Alan Coon

• 6 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266291. rdar://problem/68177666

No need to run full can-use-for (fast inline layout codepath) check on every style change.
​https://bugs.webkit.org/show_bug.cgi?id=215937
<rdar://problem/67951360>

Reviewed by Antti Koivisto.

Let's use the StyleDifference to figure out how extensive the can-use-for check should be.
We can certainly skip some relatively expensive content checks when we know that the style change only triggers repaint or positioned-movement-only changes.

• layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::canUseForAfterStyleChange):
• layout/integration/LayoutIntegrationLineLayout.h:
• rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::styleDidChange):
• rendering/SimpleLineLayout.cpp: (WebCore::SimpleLineLayout::canUseForAfterStyleChange):
• rendering/SimpleLineLayout.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266436] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266282. rdar://problem/68177648

[macOS] Fix iokit-get-properties sandbox violations
​https://bugs.webkit.org/show_bug.cgi?id=215925

Reviewed by Darin Adler.

A few iokit properties needs to be added to the WebContent process' sandbox after observing these being in use.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266435] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266281. rdar://problem/68177575

Remove adopted node from TextManipulationController
​https://bugs.webkit.org/show_bug.cgi?id=215914

Reviewed by Wenson Hsieh.

Remove Node from TextManipulationController when it gets adopted to a new document.

• dom/Node.cpp: (WebCore::Node::moveNodeToNewDocument):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266434] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266099. rdar://problem/68176073

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar
<rdar://problem/67473335> and ​https://bugs.webkit.org/show_bug.cgi?id=215787

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266433] by Alan Coon

• 19 edits in branches/safari-610-branch/Source

Cherry-pick r266214. rdar://problem/68164557

Resource Load Statistics data summary does not report data which is held up in the web content process.
​https://bugs.webkit.org/show_bug.cgi?id=215822
<rdar://problem/66682044>

Reviewed by Chris Dumez.

Source/WebCore:

Send empty lambda when calling updateCentralStatisticsStore() because
in these cases we don't care about timing.

• loader/ResourceLoadObserver.h: (WebCore::ResourceLoadObserver::updateCentralStatisticsStore):
• page/DOMWindow.cpp: (WebCore::DOMWindow::close):
• testing/Internals.cpp: (WebCore::Internals::notifyResourceLoadObserver):

Source/WebKit:

No new tests, this fixes a timing bug that is flaky to reproduce, so I
was unable to write a test case. Non-regressed behavior is confirmed
with existing API testing.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated): Most of the time, the completion handler will be an empty function, but we should handle it in the network process so we fix the case where we wait to send the full data summary until the update has finished.

(WebKit::WebResourceLoadStatisticsStore::aggregatedThirdPartyData):
Delete extra space.

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):
• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):
• UIProcess/WebProcessPool.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary): Don't ask the network process for data until any lingering data in the web content process has been sent first.

• WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleResourceLoadStatisticsNotifyObserver):
• WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: (WebKit::WebResourceLoadObserver::WebResourceLoadObserver): (WebKit::WebResourceLoadObserver::~WebResourceLoadObserver): (WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):
• WebProcess/WebCoreSupport/WebResourceLoadObserver.h:
• WebProcess/WebProcess.cpp: (WebKit::WebProcess::flushResourceLoadStatistics): (WebKit::WebProcess::sendResourceLoadStatisticsDataImmediately):
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266432] by Alan Coon

• 8 edits
  1 add in branches/safari-610-branch

Cherry-pick r266178. rdar://problem/68164567

[JSC] Add ASCII comparison fast path for IntlCollator
​https://bugs.webkit.org/show_bug.cgi?id=215798

Reviewed by Darin Adler, Ross Kirsling, and Saam Barati.

JSTests:

• stress/string-locale-compare-uca-ducet.js: Added. (shouldBe):
• stress/string-localeCompare.js: (data.sort):

Source/JavaScriptCore:

The idea behind this change is the following: ICU Collator's comparison is too slow. We should have fast path for ASCII strings when we know this equals to ICU Collator's result.
The problem is that even for ASCII strings, collation is super complicated!

1. Unicode defines Unicode Collation Algorithm (UCA). To perform collation, it uses collation element tables which defines weights on various levels per code point. UCA also offers the Default Unicode Collation Element Table (DUCET). This UCA with DUCET is used when using ICU Root Collator.
2. UCA collation consists of rules, which defines how collation works. And ICU locales define customized collations by adding special rules to that.
3. UCA behaves differently by using different options.

Based on that, our observation is that some of major locales are not defining additional rules in (2). This means that they behaves the same to UCA with DUCET.
This patch implements a simplified version of comparison which generates the same results for ASCII strings (excluding control characters) to UCA with DUCET. This fast path can be usable only when the following conditions are met.

1. The collator does not have additional rules to ICU Root Colator.
2. The collator is using default options.

These checks are very important since there are a lot of edge-case locales. For example,

1. th (Thai language) ignores punctuations (even including ASCII punctuations) by default. This is defined as ignore-punctuations option is enabled by default, so without (2)'s check, th comparison becomes wrong.
2. There are contraction concept (multiple letters behave as a single letter). "ch" letters are ordered interestingly in Czech language. So even in ASCII, Czech shows very interesting collation behavior.

So we cannot safely take this fast path without carefully querying the information to ICU.

This shows 37% improvement in JetStream2/cdjs in en-US environment.

• runtime/IntlCollator.cpp: (JSC::IntlCollator::initializeCollator): (JSC::IntlCollator::compareStrings const): (JSC::canDoASCIIUCADUCETComparisonWithUCollator): (JSC::IntlCollator::updateCanDoASCIIUCADUCETComparison const): (JSC::IntlCollator::checkICULocaleInvariants):
• runtime/IntlCollator.h:
• runtime/IntlObject.cpp: (JSC::intlCollatorAvailableLocales):
• runtime/IntlObject.h:
• runtime/IntlObjectInlines.h: (JSC::canUseASCIIUCADUCETComparison): (JSC::compareASCIIWithUCADUCET):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266431] by Alan Coon

• 4 edits in branches/safari-610-branch/Source

Cherry-pick r266143. rdar://problem/68164547

Trying to lookup when WebView is in a popover causes process to hang. Fix for Legacy WebView.
​https://bugs.webkit.org/show_bug.cgi?id=215792

Reviewed by Tim Horton.

Source/WebKit:

Update code based on Darin's suggestion for mirror fix in legacy webkit.

• UIProcess/mac/WebContextMenuProxyMac.mm: (WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Source/WebKitLegacy/mac:

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=214773 also needed in legacy WebView.
The Lookup framework does not populate the menus that it vends with the option to 'lookup'
words that are selected in popovers. WebKit should follow the pattern and not put the
item in the menu as Lookup is not able to handle this situation. Also if Lookup is disabled
via defaults, we should not show it in the menu.

• WebView/WebHTMLView.mm: (customMenuFromDefaultItems):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266430] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266140. rdar://problem/68164582

Fix read-after-free introduced in r266087
​https://bugs.webkit.org/show_bug.cgi?id=215671

• Modules/fetch/FetchBodyConsumer.cpp: (WebCore::packageFormData): Keep the CString in scope while we are using it.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266429] by Alan Coon

• 4 edits
  1 add in branches/safari-610-branch

Cherry-pick r266134. rdar://problem/68164543

[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=215660
<rdar://problem/65263150>

Reviewed by Darin Adler.

Source/WebKit:

API Test: Fullscreen.Focus.

The default behavior of NSWindow is to change its -keyViewSelectionDirection to NSSelectingNext when activating
and changing the firstResponder. This causes WKWebView to change it's focus in response to becoming first responder.
The cheap fix is to ensure WKWebView is already the firstResponder when the window is activated. Then NSWindow won't
try to change the firstResponder in response to activation.

• UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/FullscreenFocus.mm: Added. (-[FullscreenFocusUIDelegate _webViewDidEnterFullscreen:]): (-[FullscreenFocusUIDelegate _webViewDidExitFullscreen:]): (TestWebKitAPI::TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266428] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc

Cherry-pick r266064. rdar://problem/68164535

Enable VP9D_SET_LOOP_FILTER_OPT for libvpx vp9 decoder
​https://bugs.webkit.org/show_bug.cgi?id=215765
<rdar://problem/67677285>

Reviewed by Eric Carlson.

Following ​https://webrtc-review.googlesource.com/c/src/+/177335 upstream, let's enable VP9D_SET_LOOP_FILTER_OPT for improved performances.

• Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:19 PM Changeset in webkit [266427] by Alan Coon

• 15 edits in branches/safari-610-branch/Source

Cherry-pick r266268. rdar://problem/68107183

Remove the feature flag for capped cookies set in 3rd-party CNAME cloaked HTTP responses and add ITP debug logging
​https://bugs.webkit.org/show_bug.cgi?id=215902
<rdar://problem/66699731>

Reviewed by Brent Fulgham.

This change removes the feature flag, effectively turning the feature on.
It also adds log output of cookie names that have been capped when ITP
Debug Mode is enabled.

Source/WebCore:

WebCore::NetworkStorageSession now has a member flag for ITP debug logging.

No new tests. This feature already has tests.

• page/Settings.yaml:
• platform/network/NetworkStorageSession.cpp: (WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled): (WebCore::NetworkStorageSession::resourceLoadStatisticsDebugLoggingEnabled const):

New function to be able to conditionalize log output in the new feature.

• platform/network/NetworkStorageSession.h:

Source/WebKit:

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):

Now sets the flag in WebCore::NetworkStorageSession through the new function
WebCore::NetworkStorageSession::setResourceLoadStatisticsDebugLoggingEnabled().

• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::resetParametersToDefaultValues): (WebKit::NetworkProcess::setIsRunningResourceLoadStatisticsTest):
• NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession): (WebKit::NetworkSession::setFirstPartyHostCNAMEDomain): (WebKit::NetworkSession::firstPartyHostCNAMEDomain):
• NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::setCNAMECloakingMitigationEnabled): Deleted. (WebKit::NetworkSession::cnameCloakingMitigationEnabled const): Deleted.
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::updateFirstPartyInfoForSession): (WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):
• Shared/ResourceLoadStatisticsParameters.h: (WebKit::ResourceLoadStatisticsParameters::encode const): (WebKit::ResourceLoadStatisticsParameters::decode):
• Shared/WebPreferences.yaml:
• UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess):
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::platformSetNetworkParameters):
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::parameters):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266426] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266238. rdar://problem/68161715

Unreviewed, add missing double quote in r266216.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266425] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266229. rdar://problem/68161195

Animation are invalidating too much
​https://bugs.webkit.org/show_bug.cgi?id=215849

Reviewed by Antoine Quint.

• animation/KeyframeEffect.cpp: (WebCore::invalidateElement):

Changes due to animations can't affect sibling elements so we can use internal invalidation.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266424] by Alan Coon

• 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266216. rdar://problem/68161715

[macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification
​https://bugs.webkit.org/show_bug.cgi?id=215869

Reviewed by Darin Adler.

On macOS, stop logging mach-lookup sandbox violations of com.apple.CoreDisplay.Notification for performance reasons.

No new tests, since there is no change in behavior. The service was already being denied in the sandbox.

• WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266423] by Alan Coon

• 2 edits in branches/safari-610-branch/Tools

Cherry-pick r266102. rdar://problem/68160088

Fix TLSVersion.DefaultBehavior on Mojave
​https://bugs.webkit.org/show_bug.cgi?id=215791

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave. Enable it for newer OSes.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266422] by Alan Coon

• 4 edits in branches/safari-610-branch/Tools

Cherry-pick r266100. rdar://problem/68160088

Make TLSVersion.DefaultBehavior more robust
​https://bugs.webkit.org/show_bug.cgi?id=215791

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-08-24
Reviewed by Darin Adler.

After r265573 sometimes it would assert, which is not a problem because it was failing the first connection
then succeeding the second connection as intended and as happens in the real internet.
Use HTTPServer which accepts a variable number of connections to keep the test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):
• TestWebKitAPI/cocoa/HTTPServer.h:
• TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK): (TestWebKitAPI::HTTPServer::respondWithOK):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266421] by Alan Coon

• 5 edits
  6 adds in branches/safari-610-branch

Cherry-pick r266118. rdar://problem/68160083

Fonts lie about being monospaced
​https://bugs.webkit.org/show_bug.cgi?id=162546
<rdar://problem/28494654>

Reviewed by Darin Adler.

Source/WebCore:

When a font reports itself to be monospace, we use this as a
signal that we can perform width computations by assuming all
characters have the same width as the space character. However,
some fonts erroneously claim to be monospaced. We can't know
this ahead of time without measuring a bunch of characters at
font load time, which would be too slow, so even though the
optimization would be nice there is no practical way to do it
correctly. Firefox and Chrome both do not use this signal, so
therefore they both correctly render these fonts. We should
ignore this bit in the font as well. Also, CJK fonts generally
do not have this bit set (because they usually have at least
one character which is not fullwidth) so this isn't a concern
there.

Our Page Load Test shows this is not a performance regression.

Tests: fast/text/font-erroneous-monospace.html

fast/text/font-monospaced-lie.html

• rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache const):

LayoutTests:

Add two tests for fonts which claim to be monospaced but actually aren't.

• fast/text/font-erroneous-monospace-expected.html: Added.
• fast/text/font-erroneous-monospace.html: Added.
• fast/text/font-monospaced-lie-expected.txt: Added.
• fast/text/font-monospaced-lie.html: Added.
• fast/text/line-break-after-question-mark-expected.txt:
• fast/text/line-break-after-question-mark.html:
• fast/text/resources/Ahem-fixed-pitch.ttf: Added.
• fast/text/resources/AhemErroneousMonospace.ttf: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:18 PM Changeset in webkit [266420] by Alan Coon

• 8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.2.4

5:54 PM Changeset in webkit [266419] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS wk2 ] fast/scrolling/latching/latched-scroll-remove-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=216059

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:56 PM Changeset in webkit [266418] by Kate Cheney

• 2 edits in trunk/Source/WebKit

Pass the correct data size for the SharedMemory::Handle in WebCompiledContentRuleListData::encode
​https://bugs.webkit.org/show_bug.cgi?id=216049
<rdar://problem/60758278>

Reviewed by Alex Christensen.

No new tests, validated by existing API tests.

• Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):

4:11 PM Changeset in webkit [266417] by Chris Dumez

• 46 edits in trunk

Make sure BiquadFilterNode tail is getting processed
​https://bugs.webkit.org/show_bug.cgi?id=216050

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-tail-expected.txt:

Source/WebCore:

Some nodes have have a significant tail-time and shouldn't be disconnected simply because
they no longer have any input connections. We used to deal with this by hard-coding
node types in AudioNode::disableOutputsIfNecessary() which was not ideal. We now use
a AudioNode::requiresTailProcessing() virtual function instead, similarly to what Blink
is doing.

This patch fixes tail processing for BiquadFilterNode.

No new tests, rebaselined existing test.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::requiresTailProcessing const):

• Modules/webaudio/AnalyserNode.h:
• Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::requiresTailProcessing const):

• Modules/webaudio/AudioBasicProcessorNode.h:
• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::requiresTailProcessing const):

• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/ChannelMergerNode.h:
• Modules/webaudio/ChannelSplitterNode.h:
• Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::requiresTailProcessing const):

• Modules/webaudio/ConvolverNode.h:
• Modules/webaudio/DefaultAudioDestinationNode.h:
• Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::requiresTailProcessing const):

• Modules/webaudio/DelayDSPKernel.h:
• Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::requiresTailProcessing const):

• Modules/webaudio/DynamicsCompressorNode.h:
• Modules/webaudio/GainNode.h:
• Modules/webaudio/IIRDSPKernel.cpp:

(WebCore::IIRDSPKernel::requiresTailProcessing const):

• Modules/webaudio/IIRDSPKernel.h:
• Modules/webaudio/MediaElementAudioSourceNode.h:
• Modules/webaudio/MediaStreamAudioDestinationNode.h:
• Modules/webaudio/MediaStreamAudioSourceNode.h:
• Modules/webaudio/OfflineAudioDestinationNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::requiresTailProcessing const):

• Modules/webaudio/PannerNode.h:
• Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::requiresTailProcessing const):

• Modules/webaudio/ScriptProcessorNode.h:
• Modules/webaudio/StereoPannerNode.h:
• Modules/webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::requiresTailProcessing const):

• Modules/webaudio/WaveShaperDSPKernel.h:
• Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::requiresTailProcessing const):

• Modules/webaudio/WebKitAudioPannerNode.h:
• platform/audio/AudioDSPKernel.h:
• platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::requiresTailProcessing const):

• platform/audio/AudioDSPKernelProcessor.h:
• platform/audio/AudioProcessor.h:
• platform/audio/DynamicsCompressor.h:
• platform/audio/EqualPowerPanner.h:
• platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::requiresTailProcessing const):

• platform/audio/HRTFPanner.h:
• platform/audio/Panner.h:

3:56 PM Changeset in webkit [266416] by Kate Cheney

• 2 edits in trunk/Source/WebKit

WebPasteboardProxy::getPasteboardStringsForType() and WebPasteboardProxy::readURLFromPasteboard() should check return value of SharedMemory::createHandle()
​https://bugs.webkit.org/show_bug.cgi?id=211002
<rdar://problem/60103950>

Reviewed by Wenson Hsieh.

• UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
Check result of SharedMemory::createHandle() and return early
on failure.

3:54 PM Changeset in webkit [266415] by Alan Coon

• 5 edits in branches/safari-610.1.28.0-branch/Source/WebKit

Cherry-pick r266411. rdar://problem/68111667

[iOS] AGX compiler service sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>

Reviewed by Brent Fulgham.

For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.

• Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::agxCompilerServices): (WebKit::WebProcessPool::platformInitializeWebProcess):
• WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:53 PM Changeset in webkit [266414] by Alan Coon

• 8 edits in branches/safari-610.1.28.0-branch/Source

Versioning.

WebKit-7610.1.28.0.5

3:41 PM Changeset in webkit [266413] by Alan Coon

• 1 copy in tags/Safari-610.2.3

Tag Safari-610.2.3.

2:49 PM Changeset in webkit [266412] by Hector Lopez

• 6 edits in trunk/Source/WebKit

Unreviewed, reverting r266384.

Revision is causing 5 API faliures/timeouts and build failures
on macOS

Reverted changeset:

"Webpages flash when switching between windows"
​https://bugs.webkit.org/show_bug.cgi?id=216012
​https://trac.webkit.org/changeset/266384

2:25 PM Changeset in webkit [266411] by pvollan@apple.com

• 5 edits in trunk/Source/WebKit

[iOS] AGX compiler service sandbox violation
​https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>

Reviewed by Brent Fulgham.

For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::agxCompilerServices):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:45 PM Changeset in webkit [266410] by Chris Dumez

• 2 edits in trunk/Source/WebCore

<video> element prevents screen from sleeping even after playback finishes
​https://bugs.webkit.org/show_bug.cgi?id=216017
<rdar://problem/66665846>

Reviewed by Darin Adler.

When video playback would finish (due to reaching end of file), HTMLMediaElement::mediaPlayerRateChanged()
would get called, which would call updateSleepDisabling(). The idea was that updateSleepDisabling() would
destroy the SleepDisabler to allow the display to sleep again. However, updateSleepDisabling() would not
destroy the SleepDisabler because it does not know yet that the media has been paused. We only learned
about it later on, when MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() gets called.
To address the problem, we now call updateSleepDisabling() when
MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange() is called too.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::timeControlStatusDidChange):

12:52 PM Changeset in webkit [266409] by Chris Dumez

• 8 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky Web Audio WPT tests.

• web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

12:24 PM Changeset in webkit [266408] by commit-queue@webkit.org

• 51 edits in trunk

Convert runtime flag to setting for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-01
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js.
The new expected results are improvements.

• web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading. Settings are
preferred over RuntimeEnabledFeatures as they are not global singletons
and are automatically accessible in layout tests via InternalSettingsGenerated.

• loader/ImageLoader.cpp:

Source/WebKit:

Remove lazy image loading runtime flag.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations
and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests
that should be skipped.

• TestExpectations:
• http/tests/lazyload/attribute.html:
• http/tests/lazyload/js-image.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
• http/tests/lazyload/lazy.html:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• resources/testharnessreport.js:

11:51 AM Changeset in webkit [266407] by timothy_horton@apple.com

• 6 edits in trunk/Source

Some apps linked beyond iOS 13.4 don't respect mouse events, only touch events
​https://bugs.webkit.org/show_bug.cgi?id=216021
<rdar://problem/64830335>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isFIFACompanion):
(WebCore::IOSApplication::isNoggin):
(WebCore::IOSApplication::isOKCupid):
Add some more bundle checks.

Source/WebKit:

• UIProcess/Cocoa/VersionChecks.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
(-[WKContentView shouldUseMouseGestureRecognizer]):
Remove Feedly from the list, they are no longer affected.
Add a once-per-app-launch error-level log message to warn developers
of the impending behavior change.
Add three new apps with a later linked-on target.

11:51 AM Changeset in webkit [266406] by mark.lam@apple.com

• 6 edits in trunk/Source

Remove some PtrTag debugging code from release builds.
​https://bugs.webkit.org/show_bug.cgi?id=216025
<rdar://problem/68098263>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Removed PtrTag name lookup debugging utility from release builds.

• runtime/JSCPtrTag.cpp:
• runtime/JSCPtrTag.h:

Source/WTF:

Converted uses of PtrTagAction::ReleaseAssert to PtrTagAction::DebugAssert.
These assertions serve a purpose during development (hence, PtrTagAction::DebugAssert),
but is no longer needed for release builds. Previously, we use these assertions
to verify that pointers are tagged correctly in release build. Clang takes care
of that automatically now.

Also removed PtrTag name lookup debugging utility from release builds.

• wtf/PtrTag.cpp:
• wtf/PtrTag.h:

(WTF::untagCodePtr):
(WTF::retagCodePtrImpl):
(WTF::assertIsCFunctionPtr):
(WTF::assertIsNotTagged):
(WTF::assertIsTagged):
(WTF::assertIsTaggedWith):

11:19 AM Changeset in webkit [266405] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Crashtracer in SubresourceLoader::didCancel.
<rdar://problem/32831629> and ​https://bugs.webkit.org/show_bug.cgi?id=216020

Reviewed by Alex Christensen.

No new tests (Despite spotting theoretical ways this is possible, unable to construct a reproduction)

It's possible for a newly created SubresourceLoader to be cancelled right after creation.
In this case, m_resource will be null inside of SubresourceLoader::didCancel.

Other parts of SubresourceLoader null check m_resource, so it's reasonable to state ::didCancel should as well.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didCancel): Early return if reachedTerminalState(), and ASSERT(m_resource) after.

11:13 AM Changeset in webkit [266404] by Megan Gardner

• 4 edits in trunk/Source

Switch to class method for smart insert/delete
​https://bugs.webkit.org/show_bug.cgi?id=215871
<rdar://problem/67281776>

Reviewed by Darin Adler.

No process changes. Covered by existing tests.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::isSmartInsertDeleteEnabled):

10:48 AM Changeset in webkit [266403] by Antti Koivisto

• 8 edits
  2 adds in trunk

EventRegion paint should respect layer's foreground and background painting phases
​https://bugs.webkit.org/show_bug.cgi?id=216031
<rdar://problem/67282372>

Reviewed by Simon Fraser.

Source/WebCore:

We are currently painting event region for the box background to the foreground layer, which can cause
foreground layer to wrongly catch scroll events. Similarly we are unnecessarily painting foreground for
layers that don't need it.

Test: fast/scrolling/mac/negative-z-index-overflow-scroll.html

• rendering/PaintPhase.h:

Add two new event region specific PaintBehaviors for foreground and background paint. This essentially duplicates
foreground/background PaintPhases but since event region paint is itself a paint phase we can't use those.
This should be reconciled at some point.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents):

Add the background flag when painting contents as the descendant backgrounds are part of the layer foreground.

(WebCore::RenderBlock::paintObject):

Respect the new flags.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Setup the flags based on what we are supposed to be painting on this layer.

(WebCore::RenderLayer::collectEventRegionForFragments):

Flag filtering moves to paintLayerContents.

LayoutTests:

• editing/editable-region/text-field-inside-composited-negative-z-index-layer-expected.txt:
• fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt: Added.
• fast/scrolling/mac/negative-z-index-overflow-scroll.html: Added.
• pointerevents/ios/touch-action-none-relative-inside-composited-negative-z-index-layer-expected.txt:
• pointerevents/ios/touch-action-region-backing-sharing-expected.txt:

10:15 AM Changeset in webkit [266402] by Alan Coon

• 1 copy in tags/Safari-610.1.28.1.6

Tag Safari-610.1.28.1.6.

10:12 AM Changeset in webkit [266401] by Alan Coon

• 3 edits
  2 adds in branches/safari-610.1.28.1-branch

Cherry-pick r266189. rdar://problem/68145716

Flickering on sedona.dev
​https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

• html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

• fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
• fast/canvas/webgl/compositing-without-drawing.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 AM Changeset in webkit [266400] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit

Upstream PencilKit text input support
​https://bugs.webkit.org/show_bug.cgi?id=216030

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _shouldSimulateKeyboardInputOnTextInsertion]):
(-[WKContentView setUpScribbleInteraction]):
(-[WKContentView cleanUpScribbleInteraction]):
(-[WKContentView _textInputContextByScribbleIdentifier:]):
(-[WKContentView _elementForTextInputContextIsFocused:]):
(-[WKContentView indirectScribbleInteraction:requestElementsInRect:completion:]):
(-[WKContentView indirectScribbleInteraction:isElementFocused:]):
(-[WKContentView indirectScribbleInteraction:focusElementIfNeeded:referencePoint:completion:]):
(-[WKContentView indirectScribbleInteraction:frameForElement:]):
(-[WKContentView indirectScribbleInteraction:willBeginWritingInElement:]):
(-[WKContentView indirectScribbleInteraction:didFinishWritingInElement:]):

9:42 AM Changeset in webkit [266399] by commit-queue@webkit.org

• 44 edits in trunk

Update URL fragment percent encode set
​https://bugs.webkit.org/show_bug.cgi?id=216022

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-origin-expected.txt:
• web-platform-tests/url/a-element-origin-xhtml-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/failure-expected.txt:
• web-platform-tests/url/resources/setters_tests.json:
• web-platform-tests/url/resources/urltestdata.json:

Also add some new tests from upstream. Some of them are failing now. That's fine for now.

• web-platform-tests/url/url-constructor-expected.txt:
• web-platform-tests/url/url-origin-expected.txt:
• web-platform-tests/url/url-setters-expected.txt:

Source/WTF:

It now matches the behavior of Chrome and Firefox, as well as the spec at
​https://url.spec.whatwg.org/#fragment-percent-encode-set

• wtf/URLParser.cpp:

(WTF::isInFragmentEncodeSet):
(WTF::URLParser::parse):

Tools:

• TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

• fast/dom/DOMURL/set-href-attribute-hash-expected.txt:
• fast/dom/DOMURL/set-href-attribute-hash.html:
• fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
• fast/dom/HTMLAnchorElement/set-href-attribute-hash.html:
• fast/url/anchor-expected.txt:
• fast/url/anchor.html:
• fast/url/segments-expected.txt:
• fast/url/segments-from-data-url-expected.txt:
• fast/url/segments-from-data-url.html:
• fast/url/segments-from-data-url2-expected.txt:
• fast/url/segments-from-data-url2.html:
• fast/url/segments.html:
• fast/url/standard-url-expected.txt:
• fast/url/standard-url.html:
• fast/url/url-tojson-expected.txt:
• fast/url/url-tojson.html:
• fetch/fetch-url-serialization-expected.txt:
• fetch/fetch-urls.json:
• http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
• http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
• svg/dom/viewspec-parser-1-expected.txt:
• svg/dom/viewspec-parser-3-expected.txt:
• svg/dom/viewspec-parser-4-expected.txt:
• svg/dom/viewspec-parser-5-expected.txt:
• svg/dom/viewspec-parser-6-expected.txt:
• svg/dom/viewspec-parser-7-expected.txt:

9:39 AM Changeset in webkit [266398] by Chris Dumez

• 13 edits in trunk

Add proper k-rate automation support for BiquadFilterNode
​https://bugs.webkit.org/show_bug.cgi?id=216027

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
• web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:

Source/WebCore:

Add proper k-rate automation support for BiquadFilterNode. This patch is
based on Chromium's implementation.

No new tests, rebaselined existing tests.

• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::hasConstantValues):
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
(WebCore::BiquadDSPKernel::updateCoefficients):
(WebCore::BiquadDSPKernel::process):
(WebCore::BiquadDSPKernel::getFrequencyResponse):
(WebCore::BiquadDSPKernel::tailTime const):
(WebCore::BiquadDSPKernel::updateTailTime):

• Modules/webaudio/BiquadDSPKernel.h:
• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::checkForDirtyCoefficients):
(WebCore::BiquadProcessor::getFrequencyResponse):

• Modules/webaudio/BiquadProcessor.h:
• platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):
(WebCore::Biquad::process):
(WebCore::Biquad::processFast):
(WebCore::Biquad::reset):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setNormalizedCoefficients):
(WebCore::Biquad::setLowShelfParams):
(WebCore::Biquad::setHighShelfParams):
(WebCore::Biquad::setPeakingParams):
(WebCore::Biquad::setAllpassParams):
(WebCore::Biquad::setNotchParams):
(WebCore::Biquad::setBandpassParams):
(WebCore::Biquad::getFrequencyResponse):
(WebCore::repeatedRootResponse):
(WebCore::rootFinder):
(WebCore::Biquad::tailFrame):

• platform/audio/Biquad.h:

9:02 AM Changeset in webkit [266397] by commit-queue@webkit.org

• 21 edits
  1 copy
  1 add in trunk

Align Big5 decoding with spec, Chrome, and Firefox
​https://bugs.webkit.org/show_bug.cgi?id=216016

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-big5-hkscs-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-cn-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-csbig5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-errors-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-extra-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-x-x-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-big5-hkscs-expected.txt:

Source/WebCore:

I also introduce a new class TextCodecCJK instead of duct taping this into TextCodecICU.
Covered by web platform tests.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecCJK.cpp: Added.

(WebCore::TextCodecCJK::TextCodecCJK):
(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucJPEncode):
(WebCore::big5Encode):
(WebCore::appendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::big5DecodeIndex):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

• platform/text/TextCodecCJK.h: Added.
• platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::encode):
(WebCore::eucJPEncode): Deleted.
(WebCore::big5Encode): Deleted.
(WebCore::uncheckedAppendDecimal): Deleted.
(WebCore::urlEncodedEntityUnencodableHandler): Deleted.
(WebCore::entityUnencodableHandler): Deleted.
(WebCore::questionMarkUnencodableHandler): Deleted.
(WebCore::Function<void): Deleted.

• platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

Source/WTF:

• wtf/text/CodePointIterator.h:

8:44 AM Changeset in webkit [266396] by Aditya Keerthi

• 31 edits
  1 copy
  7 adds in trunk

[macOS] Handle events for date inputs with editable components
​https://bugs.webkit.org/show_bug.cgi?id=215938

Reviewed by Darin Adler.

Source/WebCore:

This patch adds actual editability to date inputs with editable
components, as the individual components now respond to keyboard
events. Number keys can be used to enter a day, month, or year. The
left and right arrow keys, as well as the tab key, can be used to
traverse the various components. Finally, the backspace and delete keys
can be used to clear the value of a particular component.

To match the behavior of NSDatePicker, a typeahead buffer with a
timeout is used when editing. For example, entering "2" and "3" in
immediate succession will result in a year of "0023", but a one second
gap between the two characters will result in a year of "0003".

Finally, this patch ensures that "focus", "blur", "input", and "change"
events are dispatched appropriately.

Tests: fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html

fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html
fast/forms/date/date-editable-components/date-editable-components-mouse-events.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleFocusEvent):

Override this method so that any attempt to focus the date input
element will focus the appropriate editable component.

(WebCore::BaseChooserOnlyDateAndTimeInputType::hasCustomFocusLogic const):

Override this method and return false if editable components are
present so that the element can be a FocusScopeOwner. This is needed to
be able to tab through individual components.

(WebCore::BaseChooserOnlyDateAndTimeInputType::didBlurFromControl):
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChangeValueFromControl):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::isKeyboardFocusable const): Date inputs should be keyboard focusable on all platforms.

• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::formatDateTimeFieldsState const): Serialize the state of the edit control into a valid HTML date string.

• html/DateInputType.h:
• html/DateTimeFieldsState.h: Added.

DateTimeFieldsState is used to serialize and deserialize the contents of
DateTimeEditElement. In the future, this class will also be used to
save form state on forward/backward navigation.

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::formatDateTimeFieldsState const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::formatDateTimeFieldsState const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::formatDateTimeFieldsState const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::formatDateTimeFieldsState const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::fieldIndexOf const):
(WebCore::DateTimeEditElement::blurFromField):

If a field is blurred, ensure the owner is notified if none of the
other fields are focused.

(WebCore::DateTimeEditElement::fieldValueChanged):
(WebCore::DateTimeEditElement::focusOnNextFocusableField):
(WebCore::DateTimeEditElement::focusByOwner):
(WebCore::DateTimeEditElement::focusOnNextField):
(WebCore::DateTimeEditElement::focusOnPreviousField):
(WebCore::DateTimeEditElement::value const):
(WebCore::DateTimeEditElement::valueAsDateTimeFieldsState const):

• html/shadow/DateTimeEditElement.h:
• html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
(WebCore::DateTimeFieldElement::dispatchBlurEvent):
(WebCore::DateTimeFieldElement::didBlur):
(WebCore::DateTimeFieldElement::updateVisibleValue): Add EventBehavior parameter to dispatch "input" and "change" events accordingly.

• html/shadow/DateTimeFieldElement.h:
• html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeSymbolicMonthFieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::populateDateTimeFieldsState):

• html/shadow/DateTimeFieldElements.h:
• html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::Range::clampValue const):
(WebCore::DateTimeNumericFieldElement::Range::isInRange const):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue const):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::didBlur):

• html/shadow/DateTimeNumericFieldElement.h:

(WebCore::DateTimeNumericFieldElement::Range::Range):

• html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):

• html/shadow/DateTimeSymbolicFieldElement.h:
• platform/DateComponents.cpp:

(WebCore::DateComponents::parseYear):
(WebCore::withinHTMLDateLimits):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

• platform/DateComponents.h: Partial revert of changes made in r265126, to ensure the minimumYear and maximumYear are accessible.

(WebCore::DateComponents::minimumYear):
(WebCore::DateComponents::maximumYear):

LayoutTests:

Added tests to verify correctness for keyboard and mouse inputs in date
inputs with editable components. These tests also ensure that the
appropriate events are dispatched: "click", "blur", "focus", "input"
and "change".

• TestExpectations:
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html: Added.
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html: Added.
• fast/forms/date/date-editable-components/date-editable-components-mouse-events-expected.txt: Added.
• fast/forms/date/date-editable-components/date-editable-components-mouse-events.html: Added.
• platform/mac-wk2/TestExpectations:

8:42 AM Changeset in webkit [266395] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Fix crash during WebPage constructor
​https://bugs.webkit.org/show_bug.cgi?id=216028
<rdar://problem/67781279>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-09-01
Reviewed by Timothy Hatcher.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):

7:06 AM Changeset in webkit [266394] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r265722 - RenderTextControlSingleLine::scroll* functions should not call Element::scroll* on the inner text content
​https://bugs.webkit.org/show_bug.cgi?id=215516
<rdar://problem/64739768>

Reviewed by Simon Fraser.

Normally the RenderBox::content*, border*, padding* and scroll* functions grab the geometry information from the renderer itself.
The clients of these functions expect the geometry data to be consistent with the rest of the rendering context
(e.g coordinates are in the coordinate system of the containing block, paint time operations are not applied etc).
Also these functions are supposed to be const. They should not mutate the geometry or the render tree itself.
Forwarding ::scroll* calls to Element::scroll* can't guarantee neither of these above.

• rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth const):
(WebCore::RenderTextControlSingleLine::scrollHeight const):
(WebCore::RenderTextControlSingleLine::scrollLeft const):
(WebCore::RenderTextControlSingleLine::scrollTop const):

7:06 AM Changeset in webkit [266393] by Carlos Garcia Campos

• 5 edits
  2 adds in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r265630 - Add RenderTreeMutationDisallowedScope to track intrusive render tree mutations
​https://bugs.webkit.org/show_bug.cgi?id=215463
<rdar://problem/67012831>

Reviewed by Simon Fraser.

RenderLayer::enclosingScrollableLayer should not mutate the render tree accidentally.
This is related to <rdar://problem/64739768>.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderTreeMutationDisallowedScope.cpp: Added.
• rendering/RenderTreeMutationDisallowedScope.h: Added.

(WebCore::RenderTreeMutationDisallowedScope::RenderTreeMutationDisallowedScope):
(WebCore::RenderTreeMutationDisallowedScope::~RenderTreeMutationDisallowedScope):
(WebCore::RenderTreeMutationDisallowedScope::isMutationAllowed):

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::destroy):

6:54 AM Changeset in webkit [266392] by Lauro Moura

• 2 edits in trunk/LayoutTests

[GLIB] Add expected image failure after r266387

Unreviewed test gardening.

• platform/glib/TestExpectations:

5:53 AM Changeset in webkit [266391] by youenn@apple.com

• 10 edits in trunk/Source

Enable inspection of WebSocket when opening Web Inspector in the middle of the connection like done for the legacy WebSocket implementation
​https://bugs.webkit.org/show_bug.cgi?id=215928

Reviewed by Devin Rousso.

Source/WebCore:

Retrofit API used by Inspector from WebCore::WebSocketChannel to ThreadableWebSocketChannel.
Make Inspector code work with ThreadableWebSocketChannel.
Add a dummy implementation for Worker WebSocket (not supported currently by Web Inspector).

Covered by http/tests/websocket/tests/hybi/inspector with NSURLSession WebSocket code path enabled.

• Modules/websockets/ThreadableWebSocketChannel.h:
• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::clientHandshakeRequest const):

• Modules/websockets/WebSocketChannel.h:
• Modules/websockets/WorkerThreadableWebSocketChannel.h:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):

• inspector/agents/page/PageNetworkAgent.cpp:

Source/WebKit:

Implement inspector related API and add additional messages for WebSocket frames.

• WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::close):
(WebKit::WebSocketChannel::didClose):
(WebKit::WebSocketChannel::didSendHandshakeRequest):
(WebKit::WebSocketChannel::didReceiveHandshakeResponse):
(WebKit::WebSocketChannel::clientHandshakeRequest const):
(WebKit::WebSocketChannel::serverHandshakeResponse const):
(WebKit::WebSocketChannel::handshakeMode const):

• WebProcess/Network/WebSocketChannel.h:

2:51 AM Changeset in webkit [266390] by Chris Lord

• 13 edits in trunk/Source/WebCore

[GTK][WPE] Add support for smooth scrolling animation with async scrolling
​https://bugs.webkit.org/show_bug.cgi?id=210382

Reviewed by Carlos Garcia Campos.

This removes the dependency on ScrollableArea from
ScrollAnimationSmooth, which allows its use as a utility class for
smooth scrolling. This class is then used in the Nicosia async layer
composition scrolling code to provide smooth scrolling, when the
feature is enabled. This mirrors the work done in bug 209230 for
kinetic scrolling.

No new tests, enabling existing functionality in more situations.

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::scrollTo):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::ScrollingTreeFrameScrollingNodeNicosia):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::ScrollingTreeOverflowScrollingNodeNicosia):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateAfterChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::stopScrollAnimations):

• page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
• platform/ScrollAnimation.h:

(WebCore::ScrollAnimation::serviceAnimation):

• platform/ScrollAnimationKinetic.cpp:
• platform/ScrollAnimationKinetic.h:
• platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::updateVisibleLengths):
(WebCore::ScrollAnimationSmooth::animationTimerFired):

• platform/ScrollAnimationSmooth.h:
• platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):

• platform/generic/ScrollAnimatorGeneric.cpp:

(WebCore::ScrollAnimatorGeneric::ScrollAnimatorGeneric):
(WebCore::ScrollAnimatorGeneric::ensureSmoothScrollingAnimation):

1:58 AM Changeset in webkit [266389] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Do not use the default WebsiteDataStore for downloads
​https://bugs.webkit.org/show_bug.cgi?id=216001

Reviewed by Adrian Perez de Castro.

Use the web context one instead.

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextStartDownload):

1:55 AM Changeset in webkit [266388] by Carlos Garcia Campos

• 12 edits in trunk/Source

[Linux] Web Inspector: show per thread cpu usage
​https://bugs.webkit.org/show_bug.cgi?id=215883

Reviewed by Adrian Perez de Castro.

Source/JavaScriptCore:

Remove platform specific getter machThread() and add thread() to return the Thread instead. The caller knows how
to get the machThread or id from a Thread.

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopBytecodes):
(JSC::SamplingProfiler::machThread): Deleted.

• runtime/SamplingProfiler.h:

(JSC::SamplingProfiler::thread):

Source/WebCore:

Get per thread CPU usage and information to fill ResourceUsageData in Linux.

• page/ResourceUsageThread.h:
• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Update to new API in SamplingProfiler.

• page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Initialize m_samplingProfilerThreadID.
(WebCore::threadInfoMap):
(WebCore::threadCPUUsage):
(WebCore::collectCPUUsage):
(WebCore::ResourceUsageThread::platformCollectCPUData):
(WebCore::cpuUsage): Deleted.

Source/WTF:

Add API to get the thread ID in Linux platform.

• wtf/Threading.cpp:

(WTF::Thread::initializeInThread):

• wtf/Threading.h:

(WTF::Thread::id const):

• wtf/ThreadingPrimitives.h:
• wtf/posix/ThreadingPOSIX.cpp:

(WTF::Thread::currentID):

Aug 31, 2020:

11:56 PM Changeset in webkit [266387] by mmaxfield@apple.com

• 6 edits
  2 adds in trunk

Ahom text is still busted
​https://bugs.webkit.org/show_bug.cgi?id=216024
<rdar://problem/60571257>

Reviewed by Zalan Bujtas.

Source/WebCore:

r259533 didn't actually solve the problem becasue I made a typo.
Luckily, iOS 14 and macOS Big Sur include a font with which this patch can be tested!
So this patch actually fixes it for real.

Test: fast/text/ahom.html

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::characterRangeCodePath):

LayoutTests:

• fast/text/ahom-expected-mismatch.html: Added.
• fast/text/ahom.html: Added.
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• platform/ios-13/TestExpectations:

10:19 PM Changeset in webkit [266386] by commit-queue@webkit.org

• 19 edits
  1 delete in trunk/LayoutTests

Unreviewed, reverting r266378 and r266381.
​https://bugs.webkit.org/show_bug.cgi?id=216029

rebaselined tests for new OS without leaving old baselines
behind

Reverted changesets:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266378

"[ BigSur+ ] platform/mac/media/media-source/is-type-
supported-vp9-codec-check.html"
​https://trac.webkit.org/changeset/266381

9:08 PM Changeset in webkit [266385] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE][WebDriver] Gardening a few more failures

Unreviewed test gardening.

• TestExpectations.json:

8:59 PM Changeset in webkit [266384] by sihui_liu@apple.com

• 6 edits in trunk/Source/WebKit

Webpages flash when switching between windows
​https://bugs.webkit.org/show_bug.cgi?id=216012

Reviewed by Darin Adler.

Based on patches from Tim Horton. To avoid flash, we need to make sure view to be selected updates its content
before UI process commits its transaction. We did this by making UI process block until receiving a reply
DidUpdateActivityState from web process. However, web process did not make sure the reply would be sent after
normal rendering update and corresponding transasction commit. Instead, it flushed transactions in progress and
replied. To fix this, now we make web process reply in transaction commit handler after rendering update.

In the switching case, view to be unselected will detach from root layer in its web process, which makes its
content empty. This change is independent from the UI process commit, so we want this to happen after UI process
commits (which submits the view hierachy change). Otherwise, empty content(white flash) on the unselected view
will be displayed. To fix this, we let UI process send the activity state update message in transaction commit
handler.

• UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::scheduleActivityStateUpdate):

• UIProcess/WebPageProxy.cpp:

(WebKit::m_limitsNavigationsToAppBoundDomains):
(WebKit::WebPageProxy::setSuppressVisibilityUpdates):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacksIfNeeded):
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired): Deleted.

7:45 PM Changeset in webkit [266383] by mark.lam@apple.com

• 3 edits
  2 adds in trunk

Missing exception check while handling the onbeforeunload event.
​https://bugs.webkit.org/show_bug.cgi?id=216015
<rdar://problem/66324934>

Reviewed by Saam Barati.

Source/WebCore:

Test: js/dom/missing-exception-check-while-handling-onbeforeunload.html

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

LayoutTests:

• js/dom/missing-exception-check-while-handling-onbeforeunload-expected.txt: Added.
• js/dom/missing-exception-check-while-handling-onbeforeunload.html: Added.

6:18 PM Changeset in webkit [266382] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

6:10 PM Changeset in webkit [266381] by Karl Rackler

• 1 edit
  2 adds in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac/fast/forms/date/date-input-rendering-basic-expected.txt: Added.

5:48 PM Changeset in webkit [266380] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] platform/mac/media/media-source/is-type-supported-vp9-codec-check.html
rdar://65188503

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:04 PM Changeset in webkit [266379] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html is a constant failure
rdar://problem/66487888

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:01 PM Changeset in webkit [266378] by Karl Rackler

• 19 edits in trunk/LayoutTests

Rebaseline after macOS build progression.
Add for Big-Sur

Unreviewed test gardening.

• platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
• platform/mac/fast/css/continuationCrash-expected.txt:
• platform/mac/fast/css/text-overflow-input-expected.txt:
• platform/mac/fast/forms/button-positioned-expected.txt:
• platform/mac/fast/forms/button-sizes-expected.txt:
• platform/mac/fast/forms/input-button-sizes-expected.txt:
• platform/mac/fast/forms/input-disabled-color-expected.txt:
• platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
• platform/mac/fast/forms/input-text-word-wrap-expected.txt:
• platform/mac/fast/forms/listbox-bidi-align-expected.txt:
• platform/mac/fast/forms/plaintext-mode-2-expected.txt:
• platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
• platform/mac/fast/forms/select-selected-expected.txt:
• platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
• platform/mac/fast/parser/document-write-option-expected.txt:
• platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
• platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
• platform/mac/tables/mozilla/bugs/bug33855-expected.txt:

4:36 PM Changeset in webkit [266377] by Alan Coon

• 8 edits in branches/safari-610.1.28.1-branch/Source

Versioning.

WebKit-7610.1.28.1.6

4:36 PM Changeset in webkit [266376] by Hector Lopez

• 2 edits in trunk/LayoutTests

Unreviewed, reverting r266374.

Revision set up incorrect expectation

Reverted changeset:

"[ BigSur+ ] media/media-source/media-source-webm.html"
​https://trac.webkit.org/changeset/266374

4:34 PM Changeset in webkit [266375] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Avoid computing metadata for idempotent text autosizing on macOS
​https://bugs.webkit.org/show_bug.cgi?id=216011

Reviewed by Darin Adler.

Avoids an unnecessary call to adjustForTextAutosizing during style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates the AutosizeStatus fields on RenderStyle that are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatus is designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.

• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

4:24 PM Changeset in webkit [266374] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ BigSur+ ] media/media-source/media-source-webm.html
rdar://66487888

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:19 PM Changeset in webkit [266373] by jh718.park@samsung.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the unused variable build warning since r238538.

No new tests, no new behaviors.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement):

4:16 PM Changeset in webkit [266372] by Jonathan Bedard

• 5 edits in trunk/Tools

[webkitcorepy] Register another package in the WebKit repository
​https://bugs.webkit.org/show_bug.cgi?id=216013
<rdar://problem/68097461>

Reviewed by Dewei Zhu.

• Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(AutoInstall.register): If a package is also checked into the webkit repository,
we prefer the checked in version to the auto-installed version.

• Scripts/webkitpy/init.py: Add webkitscmpy dependency.
• Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path): Handle case where the autoinstalled
directory is no the first in the Python path.

3:16 PM Changeset in webkit [266371] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ macOS ] Tests expectations changed as test passing but expected to fail
​https://bugs.webkit.org/show_bug.cgi?id=215786

Unreviewed test gardening.

• platform/mac/TestExpectations: correction

3:04 PM Changeset in webkit [266370] by Hector Lopez

• 2 edits in trunk/LayoutTests

[ Mac wk2 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html
rdar://problem/66492801

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:18 PM Changeset in webkit [266369] by jeffm@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after ​http://trac.webkit.org/changeset/266364/webkit.

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:

Regenerated these files.

2:14 PM Changeset in webkit [266368] by Lauro Moura

• 5 edits in trunk/LayoutTests

[GLIB] Gardening some failures and flakies

Unreviewed test gardening.

• platform/glib/TestExpectations:
• platform/gtk-wayland/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

1:25 PM Changeset in webkit [266367] by youenn@apple.com

• 4 edits in trunk/LayoutTests

Update imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html so that it no longer times out if first test fails
​https://bugs.webkit.org/show_bug.cgi?id=216009

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https-expected.txt:
• web-platform-tests/webrtc/RTCPeerConnection-mandatory-getStats.https.html:

Wrap internal asserts in first test in its own test wrapper.
Migrate all promise tests to simple synchronous tests.

LayoutTests:

• TestExpectations:

12:54 PM Changeset in webkit [266366] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, address flakiness of imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum.html

LayoutTests/imported/w3c:

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:

LayoutTests:

• TestExpectations:

12:37 PM Changeset in webkit [266365] by Karl Rackler

• 2 edits in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=215909
Removed test expectations

Unreviewed test gardening.

• platform/wincairo/TestExpectations:

11:59 AM Changeset in webkit [266364] by commit-queue@webkit.org

• 13 edits
  3 adds in trunk/Source

Implement WEBGL_compressed_texture_s3tc_srgb extension
​https://bugs.webkit.org/show_bug.cgi?id=215973

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

• src/libANGLE/renderer/gl/formatutilsgl.cpp:

(rx::nativegl::ExtAndVersionOrExt):
(rx::nativegl::BuildInternalFormatInfoMap):

Source/WebCore:

Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

• CMakeLists.txt:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGLCompressedTextureS3TCsRGB.cpp: Added.

(WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB):
(WebCore::WebGLCompressedTextureS3TCsRGB::getName const):
(WebCore::WebGLCompressedTextureS3TCsRGB::supported):

• html/canvas/WebGLCompressedTextureS3TCsRGB.h: Added.
• html/canvas/WebGLCompressedTextureS3TCsRGB.idl: Added.
• html/canvas/WebGLExtension.h:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/ExtensionsGL.h:

11:51 AM Changeset in webkit [266363] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Wheel event region code is not fully disabled
​https://bugs.webkit.org/show_bug.cgi?id=216008
<rdar://problem/68086333>

Reviewed by Simon Fraser.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::maintainsEventRegion const):

Use the relevant ENABLE flag rather than !PLATFORM_IOS to compile out the code.

11:28 AM Changeset in webkit [266362] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

WebGL goes in a bad state where glContext.createProgram() returns null
​https://bugs.webkit.org/show_bug.cgi?id=215844

Patch by James Darpinian <James Darpinian> on 2020-08-31
Reviewed by Kenneth Russell.

Added test webgl/2.0.0/conformance/canvas/render-after-resize-test.html

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshape):

11:23 AM Changeset in webkit [266361] by timothy_horton@apple.com

• 5 edits in trunk/Source/WebKit

Upstream support for image picker confirmation and downscaling
​https://bugs.webkit.org/show_bug.cgi?id=215997

Reviewed by Anders Carlsson.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showRunOpenPanel:frameInfo:resultListener:]):

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _configureImagePicker:]): Deleted.

11:16 AM Changeset in webkit [266360] by weinig@apple.com

• 103 edits in trunk/Source

Many settings in RuntimeEnabledSettings should autogenerated Settings: Part 1
​https://bugs.webkit.org/show_bug.cgi?id=215981

Reviewed by Darin Adler.

This moves an initial chunk of RuntimeEnabledSettings settings to Settings.yaml, focusing
on settings that don't require substantial refactoring or new features to work in Settings.yaml.
Source/WebCore:

The one "substantial" change to Settings generation was to switch the conditional key, to require
the complete conditional form (e.g. require ENABLE(FOO) rather than FOO), which matches
WebPreferences.yaml in WebKit, and is more versitile allowing non-ENABLE based conditionals.

• Modules/credentialmanagement/BasicCredential.idl:
• Modules/credentialmanagement/CredentialsContainer.idl:
• Modules/credentialmanagement/NavigatorCredentials.idl:
• Modules/encryptedmedia/MediaKeyMessageEvent.idl:
• Modules/encryptedmedia/MediaKeySession.idl:
• Modules/encryptedmedia/MediaKeyStatusMap.idl:
• Modules/encryptedmedia/MediaKeySystemAccess.idl:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/encryptedmedia/NavigatorEME.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
• Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
• Modules/gamepad/Gamepad.idl:
• Modules/gamepad/GamepadButton.idl:
• Modules/gamepad/GamepadEvent.idl:
• Modules/gamepad/NavigatorGamepad.idl:
• Modules/mediarecorder/BlobEvent.idl:
• Modules/mediarecorder/MediaRecorder.idl:
• Modules/mediarecorder/MediaRecorderErrorEvent.idl:
• Modules/mediastream/MediaDevices.idl:
• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::updateCaptureAccordingToMutedState):

• Modules/mediastream/NavigatorMediaDevices.idl:
• Modules/webauthn/AuthenticatorAssertionResponse.idl:
• Modules/webauthn/AuthenticatorAttestationResponse.idl:
• Modules/webauthn/AuthenticatorResponse.idl:
• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

• Modules/webauthn/PublicKeyCredential.idl:
• Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb:
• Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb:
• Scripts/SettingsTemplates/Settings.cpp.erb:
• Scripts/SettingsTemplates/Settings.h.erb:
• WebCore.xcodeproj/project.pbxproj:
• css/DOMCSSCustomPropertyDescriptor.idl:
• css/DOMCSSRegisterCustomProperty.idl:
• dom/BeforeLoadEvent.idl:
• dom/CustomElementRegistry.idl:
• dom/DataTransfer.idl:
• dom/DataTransferItem.idl:
• dom/DataTransferItemList.idl:
• dom/Document.cpp:

(WebCore::createUpgradeCandidateElement):

• dom/Document.idl:
• dom/Element.idl:
• dom/InputEvent.idl:
• dom/Node.cpp:

(WebCore::Node::dispatchBeforeLoadEvent):

• dom/StaticRange.idl:
• editing/Editor.cpp:

(WebCore::Editor::registerCustomUndoStep):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isSystemPreviewLink):
(WebCore::HTMLAnchorElement::parseAdClickAttribution const):
(WebCore::HTMLAnchorElement::handleClick):
(WebCore::HTMLAnchorElement::referrerPolicy const):

• html/HTMLAnchorElement.idl:
• html/HTMLAreaElement.idl:
• html/HTMLButtonElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLFormElement.idl:
• html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::referrerPolicy const):

• html/HTMLIFrameElement.idl:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::attributeChanged):
(WebCore::HTMLImageElement::isSystemPreviewImage const):
(WebCore::HTMLImageElement::referrerPolicy const):

• html/HTMLImageElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):
(WebCore::HTMLLinkElement::referrerPolicy const):

• html/HTMLLinkElement.idl:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateShouldContinueAfterNeedKey):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::webkitSetMediaKeys):
(WebCore::HTMLMediaElement::keyAdded):
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):

• html/HTMLMediaElement.idl:
• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

• html/HTMLObjectElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::isSystemPreviewImage):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::referrerPolicy const):

• html/HTMLScriptElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTextAreaElement.idl:
• html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):

• html/MediaEncryptedEvent.idl:
• html/WebKitMediaKeyError.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType const):
(WebCore::TokenPreloadScanner::scan):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):

• loader/LinkLoader.h:
• page/DOMWindow.idl:
• page/IntersectionObserver.idl:
• page/IntersectionObserverEntry.idl:
• page/Navigator.cpp:

(WebCore::Navigator::canShare):
(WebCore::Navigator::share):

• page/Navigator.h:
• page/NavigatorShare.idl:
• page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::touchEventsEnabled const): Deleted.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setMouseEventsSimulationEnabled):
(WebCore::RuntimeEnabledFeatures::setBlankAnchorTargetImpliesNoOpenerEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::blankAnchorTargetImpliesNoOpenerEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPrefetchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPrefetchEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaPreloadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaPreloadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInputEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::inputEventsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCustomElementsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::customElementsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationLocalAuthenticatorEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationLocalAuthenticatorEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSCustomPropertiesAndValuesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssCustomPropertiesAndValuesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSyntheticEditingCommandsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::syntheticEditingCommandsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaRecorderEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaRecorderEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaDevicesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaDevicesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::screenCaptureEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setScreenCaptureEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setGamepadsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::gamepadsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setDownloadAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::downloadAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIntersectionObserverEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::intersectionObserverEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUndoManagerAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::undoManagerAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::encryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyEncryptedMediaAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyEncryptedMediaAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setSystemPreviewEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::systemPreviewEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLegacyBeforeLoadEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::legacyBeforeLoadEventEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::adClickAttributionEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setAdClickAttributionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setTouchEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::referrerPolicyAttributeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setReferrerPolicyAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::interruptAudioOnPageVisibilityChangeEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setInterruptAudioOnPageVisibilityChangeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::linkPreloadResponsiveImagesEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setLinkPreloadResponsiveImagesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setIsInAppBrowserPrivacyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isInAppBrowserPrivacyEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setNeedsInAppBrowserPrivacyQuirks): Deleted.
(WebCore::RuntimeEnabledFeatures::needsInAppBrowserPrivacyQuirks const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebShareFileAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webShareFileAPIEnabled const): Deleted.

• page/Settings.yaml:
• page/UndoItem.idl:
• page/UndoManager.idl:
• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setScreenCaptureEnabled): Deleted.

• testing/InternalSettings.h:
• testing/InternalSettings.idl:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setShouldInterruptAudioOnPageVisibilityChange):
(WebCore::Internals::addPrefetchLoadEventListener):

Source/WebKit:

In WebKit, this means mostly removing now unnecessary use of the webcoreBinding key in
WebPreferences.yaml and removing now superfluous cases in InjectedBundle::overrideBoolPreferenceForTestRunner.

• Shared/WebPreferences.yaml:

Removing now unnecessary use of the webcoreBinding key and fix indentation of a few cases.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Remove now superfluous cases, as each boolean Settings based setting gets handled automatically.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Remove explicit setting of setInteractiveFormValidationEnabled now that we don't have the
RuntimeEnabledSettings variant being set by the generator.

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::notifyPreferencesChanged):
Update changed settings to use Settings rather than RuntimeEnabledSettings.

10:43 AM Changeset in webkit [266359] by ysuzuki@apple.com

• 21 edits in trunk/Source/JavaScriptCore

[JSC] StructureStubInfo / CallLinkInfo / ByValInfo should set CodeOrigin or BytecodeIndex at construction
​https://bugs.webkit.org/show_bug.cgi?id=215987
<rdar://problem/66370323>

Reviewed by Mark Lam.

We had race condition during construction of StructureStubInfo and CodeOrigin field setting.

1. The thread creates StructureStubInfo by calling CodeBlock::addStubInfo. This is guarded by the lock. But at this point we are not setting StructureStubInfo::codeOrigin.
2. Then (1)'s thread attempts to set StructureStubInfo::codeOrigin. But at this point, it is not guarded by the lock.
3. Before (2) is executed, DFG ByteCodeParser calls CodeBlock::getICStatusMap. It creates HashMap<CodeOrigin, StructureStubInfo*>.
4. Since StructureStubInfo*'s codeOrigin is not configured yet, (3) sees invalid CodeOrigin. And storing invalid CodeOrigin as a HashMap key is not correct.

We should configure CodeOrigin at construction of StructureStubInfo, which is guarded by the lock. We have the same problem for CallLinkInfo and ByValInfo. This patch fixes them.
To reproduce this, we need to execute a script 2~ days repeatedly. So it is difficult to add a test.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):
(JSC::ByValInfo::setUp):

• bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::CallLinkInfo):

• bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::setUpCall):
(JSC::CallLinkInfo::setCodeOrigin): Deleted.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::addByValInfo):
(JSC::CodeBlock::addCallLinkInfo):

• bytecode/CodeBlock.h:
• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):

• bytecode/StructureStubInfo.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):

• jit/JIT.cpp:

(JSC::JIT::link):

• jit/JITCall.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):

• jit/JITInlineCacheGenerator.cpp:

(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):

• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

10:22 AM Changeset in webkit [266358] by Hector Lopez

• 56 edits in trunk

Unreviewed, reverting r266350.

Revision is causing a constant crash on both macOS and iOS

Reverted changeset:

"Convert runtime flag to setting for lazy image loading"
​https://bugs.webkit.org/show_bug.cgi?id=215610
​https://trac.webkit.org/changeset/266350

9:56 AM Changeset in webkit [266357] by stephan.szabo@sony.com

• 2 edits in trunk

[PlayStation] Build fix for intermittent copy errors
​https://bugs.webkit.org/show_bug.cgi?id=215951

Reviewed by Ross Kirsling.

• Source/cmake/OptionsPlayStation.cmake:

When copying platform specific files into the binary
directory post build on executable targets, we'd
intermittently get copy errors in parallel builds.

9:47 AM Changeset in webkit [266356] by jh718.park@samsung.com

• 3 edits
  80 copies
  22 adds
  1 delete in trunk/LayoutTests

Import css-conditional tests.
​https://bugs.webkit.org/show_bug.cgi?id=216000

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/conditional/LICENSE: Renamed from LayoutTests/css3/conditional/w3c/LICENSE.
• web-platform-tests/css/conditional/META.yml: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-001.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002-expected.html: Added.
• web-platform-tests/css/conditional/at-media-whitespace-optional-002.html: Added.
• web-platform-tests/css/conditional/at-supports-001-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-001.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-001.html.
• web-platform-tests/css/conditional/at-supports-002-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-002.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-002.html.
• web-platform-tests/css/conditional/at-supports-003-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-003.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-003.html.
• web-platform-tests/css/conditional/at-supports-004-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-004.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-004.html.
• web-platform-tests/css/conditional/at-supports-005-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-005.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-005.html.
• web-platform-tests/css/conditional/at-supports-006-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-006.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-006.html.
• web-platform-tests/css/conditional/at-supports-007-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-007.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-007.html.
• web-platform-tests/css/conditional/at-supports-008-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-008.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-008.html.
• web-platform-tests/css/conditional/at-supports-009-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-009.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-009.html.
• web-platform-tests/css/conditional/at-supports-010-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-010.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-010.html.
• web-platform-tests/css/conditional/at-supports-011-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-011.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-011.html.
• web-platform-tests/css/conditional/at-supports-012-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-012.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-012.html.
• web-platform-tests/css/conditional/at-supports-013-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-013.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-013.html.
• web-platform-tests/css/conditional/at-supports-014-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-014.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-014.html.
• web-platform-tests/css/conditional/at-supports-015-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-015.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-015.html.
• web-platform-tests/css/conditional/at-supports-016-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-016.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-016.html.
• web-platform-tests/css/conditional/at-supports-017-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-017.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-017.html.
• web-platform-tests/css/conditional/at-supports-018-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-018.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-018.html.
• web-platform-tests/css/conditional/at-supports-019-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-019.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-019.html.
• web-platform-tests/css/conditional/at-supports-020-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-020.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-020.html.
• web-platform-tests/css/conditional/at-supports-021-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-021.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-021.html.
• web-platform-tests/css/conditional/at-supports-022-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-022.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-022.html.
• web-platform-tests/css/conditional/at-supports-023-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-023.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-023.html.
• web-platform-tests/css/conditional/at-supports-024-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-024.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-024.html.
• web-platform-tests/css/conditional/at-supports-025-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-025.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-025.html.
• web-platform-tests/css/conditional/at-supports-026-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-026.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-026.html.
• web-platform-tests/css/conditional/at-supports-027-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-027.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-027.html.
• web-platform-tests/css/conditional/at-supports-028-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-028.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-028.html.
• web-platform-tests/css/conditional/at-supports-029-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-029.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-029.html.
• web-platform-tests/css/conditional/at-supports-030-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-030.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-030.html.
• web-platform-tests/css/conditional/at-supports-031-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-031.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-031.html.
• web-platform-tests/css/conditional/at-supports-032-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-032.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-032.html.
• web-platform-tests/css/conditional/at-supports-033-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-033.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-033.html.
• web-platform-tests/css/conditional/at-supports-034-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-034.html: Added.
• web-platform-tests/css/conditional/at-supports-035-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-035.html: Added.
• web-platform-tests/css/conditional/at-supports-036-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-036.html: Added.
• web-platform-tests/css/conditional/at-supports-037-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-037.html: Added.
• web-platform-tests/css/conditional/at-supports-038-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-038.html: Added.
• web-platform-tests/css/conditional/at-supports-039-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-039.html: Added.
• web-platform-tests/css/conditional/at-supports-040-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-040.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-040.html.
• web-platform-tests/css/conditional/at-supports-041-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-041.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041.html.
• web-platform-tests/css/conditional/at-supports-042-expected.html: Copied from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-042.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-042.html.
• web-platform-tests/css/conditional/at-supports-043-expected.html: Renamed from LayoutTests/css3/conditional/w3c/at-supports-041-expected.html.
• web-platform-tests/css/conditional/at-supports-043.html: Added.
• web-platform-tests/css/conditional/idlharness-expected.txt: Added.
• web-platform-tests/css/conditional/idlharness.html: Added.
• web-platform-tests/css/conditional/js/001-expected.txt: Added.
• web-platform-tests/css/conditional/js/001.html: Added.
• web-platform-tests/css/conditional/reference/background-lime.html: Added.
• web-platform-tests/css/conditional/test_group_insertRule-expected.txt: Added.
• web-platform-tests/css/conditional/test_group_insertRule.html: Added.

LayoutTests:

• TestExpectations:
• css3/conditional/w3c/at-supports-001-expected.html: Removed.
• css3/conditional/w3c/at-supports-002-expected.html: Removed.
• css3/conditional/w3c/at-supports-003-expected.html: Removed.
• css3/conditional/w3c/at-supports-004-expected.html: Removed.
• css3/conditional/w3c/at-supports-005-expected.html: Removed.
• css3/conditional/w3c/at-supports-006-expected.html: Removed.
• css3/conditional/w3c/at-supports-007-expected.html: Removed.
• css3/conditional/w3c/at-supports-008-expected.html: Removed.
• css3/conditional/w3c/at-supports-009-expected.html: Removed.
• css3/conditional/w3c/at-supports-010-expected.html: Removed.
• css3/conditional/w3c/at-supports-011-expected.html: Removed.
• css3/conditional/w3c/at-supports-012-expected.html: Removed.
• css3/conditional/w3c/at-supports-013-expected.html: Removed.
• css3/conditional/w3c/at-supports-014-expected.html: Removed.
• css3/conditional/w3c/at-supports-015-expected.html: Removed.
• css3/conditional/w3c/at-supports-016-expected.html: Removed.
• css3/conditional/w3c/at-supports-017-expected.html: Removed.
• css3/conditional/w3c/at-supports-018-expected.html: Removed.
• css3/conditional/w3c/at-supports-019-expected.html: Removed.
• css3/conditional/w3c/at-supports-020-expected.html: Removed.
• css3/conditional/w3c/at-supports-021-expected.html: Removed.
• css3/conditional/w3c/at-supports-022-expected.html: Removed.
• css3/conditional/w3c/at-supports-023-expected.html: Removed.
• css3/conditional/w3c/at-supports-024-expected.html: Removed.
• css3/conditional/w3c/at-supports-025-expected.html: Removed.
• css3/conditional/w3c/at-supports-026-expected.html: Removed.
• css3/conditional/w3c/at-supports-027-expected.html: Removed.
• css3/conditional/w3c/at-supports-028-expected.html: Removed.
• css3/conditional/w3c/at-supports-029-expected.html: Removed.
• css3/conditional/w3c/at-supports-030-expected.html: Removed.
• css3/conditional/w3c/at-supports-031-expected.html: Removed.
• css3/conditional/w3c/at-supports-032-expected.html: Removed.
• css3/conditional/w3c/at-supports-033-expected.html: Removed.
• css3/conditional/w3c/at-supports-040-expected.html: Removed.
• css3/conditional/w3c/at-supports-042-expected.html: Removed.

9:13 AM Changeset in webkit [266355] by weinig@apple.com

• 4 edits in trunk/Source/WebCore

DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() is not actually a setting, so should not be in DeprecatedGlobalSettings
​https://bugs.webkit.org/show_bug.cgi?id=215978

Reviewed by Darin Adler.

Move behavior quirk defined by DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow() to its
only call site in CommonVM.cpp

• bindings/js/CommonVM.cpp:

(WebCore::globalConstRedeclarationShouldThrow):
(WebCore::commonVMSlow):

• page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::globalConstRedeclarationShouldThrow): Deleted.

• page/DeprecatedGlobalSettings.h:

8:51 AM Changeset in webkit [266354] by achristensen@apple.com

• 20 edits
  1 add in trunk

Make Big5 encoder conform to the specification and behavior of Chrome and Firefox
​https://bugs.webkit.org/show_bug.cgi?id=215983

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/big5-encoder-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-cn-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-csbig5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-pua-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-x-x-big5-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-misc-expected.txt:
• web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-expected.txt:

Source/WebCore:

Covered by web platform tests.

• platform/text/EncodingTables.cpp:
• platform/text/EncodingTables.h:
• platform/text/TextCodecICU.cpp:

(WebCore::eucJPEncode):
(WebCore::big5Encode):
(WebCore::uncheckedAppendDecimal):
(WebCore::urlEncodedEntityUnencodableHandler):
(WebCore::entityUnencodableHandler):
(WebCore::questionMarkUnencodableHandler):
(WebCore::Function<void):
(WebCore::TextCodecICU::encode):

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/URLParser.cpp:

(WTF::CodePointIterator::CodePointIterator): Deleted.
(WTF::CodePointIterator::operator== const): Deleted.
(WTF::CodePointIterator::operator!= const): Deleted.
(WTF::CodePointIterator::atEnd const): Deleted.
(WTF::CodePointIterator::codeUnitsSince const): Deleted.
(WTF::CodePointIterator<LChar>::operator const): Deleted.
(WTF::CodePointIterator<LChar>::operator): Deleted.
(WTF::CodePointIterator<UChar>::operator const): Deleted.
(WTF::CodePointIterator<UChar>::operator): Deleted.

• wtf/text/CodePointIterator.h: Added.

(WTF::CodePointIterator::CodePointIterator):
(WTF::CodePointIterator::operator== const):
(WTF::CodePointIterator::operator!= const):
(WTF::CodePointIterator::atEnd const):
(WTF::CodePointIterator::codeUnitsSince const):
(WTF::CodePointIterator<LChar>::operator const):
(WTF::CodePointIterator<LChar>::operator):
(WTF::CodePointIterator<UChar>::operator const):
(WTF::CodePointIterator<UChar>::operator):

8:14 AM Changeset in webkit [266353] by Wenson Hsieh

• 4 edits in trunk/Source/WebCore

Optimize the implementation of TransformationMatrix::rotate(double)
​https://bugs.webkit.org/show_bug.cgi?id=215994

Reviewed by Tim Horton.

TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which
has a fast path for the case where we're rotating about the z-axis. However, we can make this *slightly* faster
by omitting the hypotenuse computation, several floating point comparisons, and several assignments in this case
because we already know that we're just rotating about the z-axis.

This is a small (but measurable) improvement on the Multiply subtest of MotionMark, which applies a little over
3 million rotation transformations over the course of 30 seconds.

• platform/graphics/transforms/RotateTransformOperation.h:

Instead of calling rotate3d, just have rotate directly call multiply with the following
TransformationMatrix:
`
[[ cos(z) sin(z) 0 0 ]

[ -sin(z) cos(z) 0 0 ]
[ 0 0 1 0 ]
[ 0 0 0 1 ]]

`
...where z is the angle of rotation, in radians.

• platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::rotate):

• platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::rotate): Deleted.

8:12 AM Changeset in webkit [266352] by Karl Rackler

• 1 edit
  4 adds in trunk/LayoutTests

Windows baselines after r266228 and r266273.
Add wincairo

Unreviewed test gardening.

• platform/wincairo/streams/reference-implementation/transform-stream-errors-expected.txt: Added.
• platform/wincairo/streams/reference-implementation/transform-stream-expected.txt: Added.

7:25 AM Changeset in webkit [266351] by Aditya Keerthi

• 20 edits
  14 adds in trunk

[macOS] Date inputs should contain editable components
​https://bugs.webkit.org/show_bug.cgi?id=215155

Reviewed by Devin Rousso.

Source/WebCore:

Currently, users are unable to edit the values in date and time input types.
To match system date controls, users should be able to select and edit
individual components of the input. For example, <input type="date"> should
contain an editable year, month, and day control.

Note that this functionality was present in WebKit, up until it was removed
in r150876. Previously known as "INPUT_MULTIPLE_FIELDS_UI", the feature was
removed as it was only used by Chromium port. However, much of the removed
logic remains useful and is resurfaced in this patch. Modifications were made
to update the code to follow current WebKit practices.

DateTimeEditElement is a wrapper element that contains individual fields.
The fields are all DateTimeFieldElements. Note that DateTimeFieldElements
are further specialized into DateTimeNumericFieldElement (for integral
values) and DateTimeSymbolicFieldElement (for symbolic values such as A.M
and P.M). DateTimeEditElement builds the control using the visitor pattern
and existing parsing logic contained in DateTimeFormat.

In order to reduce the patch size, this patch only sets up the rendering
and layout of multiple fields for <input type="date">. Upcoming patches will
add rendering for other date/time input types and introduce editability.

Test: fast/forms/date/date-pseudo-elements.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/html.css:

(input::-webkit-datetime-edit):
(input::-webkit-datetime-edit-fields-wrapper):
(input::-webkit-datetime-edit-year-field,):
(input::-webkit-datetime-edit-year-field:focus,):
(input::-webkit-datetime-edit-text):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat):
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseChooserOnlyDateAndTimeInputType::valueForEditControl const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::localeIdentifier const):

• html/BaseChooserOnlyDateAndTimeInputType.h:
• html/BaseDateAndTimeInputType.h:
• html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat const):
(WebCore::DateInputType::setupLayoutParameters const):

• html/DateInputType.h:
• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat const):
(WebCore::DateTimeLocalInputType::setupLayoutParameters const):

• html/DateTimeLocalInputType.h:
• html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat const):
(WebCore::MonthInputType::setupLayoutParameters const):

• html/MonthInputType.h:
• html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat const):
(WebCore::TimeInputType::setupLayoutParameters const):

• html/TimeInputType.h:
• html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat const):
(WebCore::WeekInputType::setupLayoutParameters const):

• html/WeekInputType.h:
• html/shadow/DateTimeEditElement.cpp: Added.

(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::build):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
(WebCore::DateTimeEditElement::fieldsWrapperElement const):
(WebCore::DateTimeEditElement::addField):
(WebCore::DateTimeEditElement::create):
(WebCore::DateTimeEditElement::layout):
(WebCore::DateTimeEditElement::localeIdentifier const):
(WebCore::DateTimeEditElement::resetFields):
(WebCore::DateTimeEditElement::setValueAsDate):
(WebCore::DateTimeEditElement::setEmptyValue):
(WebCore::DateTimeEditElement::value const):

• html/shadow/DateTimeEditElement.h: Added.
• html/shadow/DateTimeFieldElement.cpp: Added.

(WebCore::DateTimeFieldElement::DateTimeFieldElement):
(WebCore::DateTimeFieldElement::initialize):
(WebCore::DateTimeFieldElement::localeForOwner const):
(WebCore::DateTimeFieldElement::localeIdentifier const):
(WebCore::DateTimeFieldElement::updateVisibleValue):
(WebCore::DateTimeFieldElement::supportsFocus const):

• html/shadow/DateTimeFieldElement.h: Added.
• html/shadow/DateTimeFieldElements.cpp: Added.

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeDayFieldElement::setValueAsDate):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeMonthFieldElement::setValueAsDate):
(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::setValueAsDate):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
(WebCore::DateTimeYearFieldElement::create):
(WebCore::DateTimeYearFieldElement::setValueAsDate):

• html/shadow/DateTimeFieldElements.h: Added.
• html/shadow/DateTimeNumericFieldElement.cpp: Added.

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue const):
(WebCore::DateTimeNumericFieldElement::hasValue const):
(WebCore::DateTimeNumericFieldElement::initialize):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::value const):
(WebCore::DateTimeNumericFieldElement::valueAsInteger const):
(WebCore::DateTimeNumericFieldElement::visibleValue const):

• html/shadow/DateTimeNumericFieldElement.h: Added.
• html/shadow/DateTimeSymbolicFieldElement.cpp: Added.

(WebCore::makeVisibleEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::hasValue const):
(WebCore::DateTimeSymbolicFieldElement::initialize):
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
(WebCore::DateTimeSymbolicFieldElement::setValueAsInteger):
(WebCore::DateTimeSymbolicFieldElement::value const):
(WebCore::DateTimeSymbolicFieldElement::valueAsInteger const):
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue const):
(WebCore::DateTimeSymbolicFieldElement::visibleValue const):

• html/shadow/DateTimeSymbolicFieldElement.h: Added.

(WebCore::DateTimeSymbolicFieldElement::symbolsSize const):

LayoutTests:

Added a test to verify styling of pseudo elements within date inputs.
Rebaselined existing tests to match new appearance.

• fast/forms/date/date-pseudo-elements-expected.txt: Added.
• fast/forms/date/date-pseudo-elements.html: Added.
• platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
• platform/mac-wk2/fast/forms/date/date-pseudo-elements-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-appearance-basic-expected.txt: Added.
• platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:

4:51 AM Changeset in webkit [266350] by commit-queue@webkit.org

• 56 edits in trunk

Convert runtime flag to setting for lazy image loading
​https://bugs.webkit.org/show_bug.cgi?id=215610

Patch by Rob Buis <​rbuis@igalia.com> on 2020-08-31
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js.
The new expected results are improvements.

• web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:

Source/WebCore:

Convert runtime flag to setting for lazy image loading.

• html/HTMLImageElement.idl:
• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setLazyImageLoadingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::lazyImageLoadingEnabled const): Deleted.

• page/Settings.yaml:

Source/WebKit:

Remove lazy image loading runtime flag.

• Shared/WebPreferences.yaml:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Remove lazy image loading runtime flag.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations
and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests
that should be skipped.

• TestExpectations:
• http/tests/lazyload/attribute.html:
• http/tests/lazyload/js-image.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
• http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
• http/tests/lazyload/lazy.html:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• resources/testharnessreport.js:

2:45 AM Changeset in webkit [266349] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Flatpak] SDK branch upgrade path is broken
​https://bugs.webkit.org/show_bug.cgi?id=215927

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-08-31
Reviewed by Adrian Perez de Castro.

The development environment (flatpak install) needs to be performed before attempting to
rebuild toolchain archives. In most cases this wasn't an issue, but when the SDK needs to be
upgraded to a new ABI/branch, the previous version needs to be removed, that triggers a new
flatpak install and toolchain archives update, which need then to be done in the right
order.

• flatpak/flatpakutils.py:

(WebkitFlatpak.main):

2:01 AM Changeset in webkit [266348] by youenn@apple.com

• 35 edits
  5 adds in trunk

Add support for TextDecoderStream
​https://bugs.webkit.org/show_bug.cgi?id=215919

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/streams/backpressure.any-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any-expected.txt:
• web-platform-tests/encoding/streams/decode-attributes.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/decode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
• web-platform-tests/encoding/streams/decode-ignore-bom.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any-expected.txt:
• web-platform-tests/encoding/streams/decode-incomplete-input.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any-expected.txt:
• web-platform-tests/encoding/streams/decode-split-character.any.worker-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/decode-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any.worker-expected.txt:
• web-platform-tests/encoding/streams/realms.window-expected.txt:

Source/WebCore:

Implement TextEncoderStream as a JS built-in.
It is enabled by transform stream runtime flag.

TextDecoderStream takes a TransformStream and TextDecoderStreamEncoder as private slots.
Add TextDecoderStreamEncoder to implement the actual UTF-8 encoding steps, as a wrapper around TextDecoder.

Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/TextDecoderStream.idl: Added.
• dom/TextDecoderStream.js: Added.

(initializeTextDecoderStream):
(getter.encoding):
(getter.fatal):
(getter.ignoreBOM):
(getter.readable):
(getter.writable):

• dom/TextDecoderStreamDecoder.cpp: Added.

(WebCore::TextDecoderStreamDecoder::create):
(WebCore::TextDecoderStreamDecoder::TextDecoderStreamDecoder):
(WebCore::TextDecoderStreamDecoder::decode):
(WebCore::TextDecoderStreamDecoder::flush):

• dom/TextDecoderStreamDecoder.h: Added.

(WebCore::TextDecoderStreamDecoder::encoding const):

• dom/TextDecoderStreamDecoder.idl: Added.

LayoutTests:

• TestExpectations:

Unskipping encoding tests except legacy-* tests which are big and slow.

1:58 AM Changeset in webkit [266347] by youenn@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Disable sniffing for WebSocket handshakes
​https://bugs.webkit.org/show_bug.cgi?id=215932

Reviewed by Darin Adler.

Covered by http/tests/websocket/tests/hybi/handshake-error.html no longer timing out with NSURLSession WebSocket code path.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):

12:23 AM Changeset in webkit [266346] by ysuzuki@apple.com

• 5 edits in trunk

[JSC] @defaultPromiseThen fast path should check species constructor
​https://bugs.webkit.org/show_bug.cgi?id=215996

Reviewed by Ross Kirsling.

JSTests:

• test262/expectations.yaml:

Source/JavaScriptCore:

When executing @defaultPromiseThen fast path, we assumed that this execution is not observable.
This is wrong only for species constructor part: this @@species access & derived constructor calls
can be observable. In this patch,

1. We extract part of Promise#then as @performPromiseThen, which corresponds to the spec's PerformPromiseThen.
2. In promise fast path, we check @speciesConstructor is @Promise or @InternalPromise. If it is not, then we go to the slow path.

This fixes Promise#finally failures in test262.

• builtins/PromiseOperations.js:

(globalPrivate.promiseResolveThenableJobFast):
(globalPrivate.promiseResolveThenableJobWithoutPromiseFast):
(globalPrivate.promiseResolveThenableJobWithDerivedPromise):
(onFulfilled):
(onRejected):
(globalPrivate.performPromiseThen):

• builtins/PromisePrototype.js:

(then):
(onFulfilled): Deleted.
(onRejected): Deleted.

Aug 30, 2020:

10:18 PM Changeset in webkit [266345] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKitLegacy/mac

Remove an unused addition point

• WebCoreSupport/WebFrameLoaderClient.mm:

9:51 PM Changeset in webkit [266344] by Wenson Hsieh

• 9 edits in trunk/Source/WebCore

Make StyleRareNonInheritedData::mask and StyleBackgroundData::background DataRefs
​https://bugs.webkit.org/show_bug.cgi?id=215942

Reviewed by Darin Adler.

A significant amount of time in MotionMark's Multiply subtest is spent underneath the copy constructor
StyleRareNonInheritedData, and a significant amount of time underneath this copy constructor is spent copying
the rare non-inherited data's mask (a FillLayer).

This FillLayer is currently inline data in StyleRareNonInheritedData; to reduce the cost of copying rare
non-inherited data, we can instead make this a DataRef<FillLayer>, such that copying rare data will only copy
the reference to the FillLayer rather than the FillLayer itself.

Upon mutating the FillLayer, we now use DataRef::access() to ensure that these FillLayers are copied
before writing. See below for more details.

• css/makeprop.pl:

(generateFillLayerPropertyInheritValueSetter):
(generateFillLayerPropertyValueSetter):

• rendering/style/FillLayer.cpp:

(WebCore::FillLayer::create):
(WebCore::FillLayer::FillLayer):

Deeply copy the FillLayer's linked list of FillLayers. This preserves existing behavior, which currently
uses std::unique_ptr to store the pointer to the next FillLayer (and therefore, requires a deep copy of the
linked list when copying FillLayer).

In a future patch, we could probably further optimize this as well to behave in a copy-on-write way, by turning
the RefPtr<FillLayer> m_next; into an Optional<DataRef<FillLayer>> instead (and then use access() to copy
the next FillLayer prior to writing).

(WebCore::FillLayer::~FillLayer):
(WebCore::FillLayer::operator=):

• rendering/style/FillLayer.h:

Make FillLayer ref-counted, and introduce new create methods for constructing FillLayers. Use these
methods in several places where we currently call the constructors directly, via makeUnique.

(WebCore::FillLayer::copy const):
(WebCore::FillLayer::setNext):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::hasBackgroundImage const):
(WebCore::RenderStyle::hasFixedBackgroundImage const):
(WebCore::RenderStyle::backgroundRepeatX const):
(WebCore::RenderStyle::backgroundRepeatY const):
(WebCore::RenderStyle::backgroundComposite const):
(WebCore::RenderStyle::backgroundAttachment const):
(WebCore::RenderStyle::backgroundClip const):
(WebCore::RenderStyle::backgroundOrigin const):
(WebCore::RenderStyle::backgroundXPosition const):
(WebCore::RenderStyle::backgroundYPosition const):
(WebCore::RenderStyle::backgroundSizeType const):
(WebCore::RenderStyle::backgroundSizeLength const):
(WebCore::RenderStyle::ensureBackgroundLayers):
(WebCore::RenderStyle::maskImage const):
(WebCore::RenderStyle::maskRepeatX const):
(WebCore::RenderStyle::maskRepeatY const):
(WebCore::RenderStyle::maskComposite const):
(WebCore::RenderStyle::maskClip const):
(WebCore::RenderStyle::maskOrigin const):
(WebCore::RenderStyle::maskXPosition const):
(WebCore::RenderStyle::maskYPosition const):
(WebCore::RenderStyle::maskSizeType const):
(WebCore::RenderStyle::maskSizeLength const):
(WebCore::RenderStyle::ensureMaskLayers):
(WebCore::RenderStyle::hasMask const):
(WebCore::RenderStyle::setBackgroundXPosition):
(WebCore::RenderStyle::setBackgroundYPosition):
(WebCore::RenderStyle::setBackgroundSize):
(WebCore::RenderStyle::setBackgroundSizeLength):
(WebCore::RenderStyle::clearBackgroundLayers):
(WebCore::RenderStyle::inheritBackgroundLayers):
(WebCore::RenderStyle::clearMaskLayers):
(WebCore::RenderStyle::inheritMaskLayers):
(WebCore::RenderStyle::setMaskImage):
(WebCore::RenderStyle::setMaskXPosition):
(WebCore::RenderStyle::setMaskYPosition):
(WebCore::RenderStyle::setMaskSize):

• rendering/style/StyleBackgroundData.cpp:

(WebCore::StyleBackgroundData::StyleBackgroundData):
(WebCore::StyleBackgroundData::dump const):

• rendering/style/StyleBackgroundData.h:

Since FillLayer is now ref-counted, StyleBackgroundData::background needs to be a DataRef as well.

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

• rendering/style/StyleRareNonInheritedData.h:

9:37 PM Changeset in webkit [266343] by Lauro Moura

• 2 edits in trunk/WebDriverTests

[WPE] Gardening some webdriver failures

Unreviewed test gardening.

• TestExpectations.json:

8:26 PM Changeset in webkit [266342] by timothy_horton@apple.com

• 85 edits
  17 deletes in trunk

Remove unused editable image code
​https://bugs.webkit.org/show_bug.cgi?id=215991

Reviewed by Simon Fraser.

Source/WebCore:

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• editing/EditAction.cpp:

(WebCore::undoRedoLabel):

• editing/EditAction.h:
• editing/Editor.cpp:

(WebCore::Editor::insertEditableImage): Deleted.

• editing/Editor.h:
• editing/EditorCommand.cpp:

(WebCore::createCommandMap):
(WebCore::executeInsertEditableImage): Deleted.
(WebCore::enabledInRichlyEditableTextWithEditableImagesEnabled): Deleted.

• editing/InsertEditableImageCommand.cpp: Removed.
• editing/InsertEditableImageCommand.h: Removed.
• en.lproj/Localizable.strings:
• html/HTMLAttributeNames.in:
• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement):
(WebCore::HTMLImageElement::supportsFocus const): Deleted.
(WebCore::HTMLImageElement::isFocusable const): Deleted.
(WebCore::HTMLImageElement::didFinishInsertingNode): Deleted.
(WebCore::HTMLImageElement::hasEditableImageAttribute const): Deleted.
(WebCore::HTMLImageElement::editableImageViewID const): Deleted.
(WebCore::HTMLImageElement::updateEditableImage): Deleted.
(WebCore::HTMLImageElement::defaultEventHandler): Deleted.

• html/HTMLImageElement.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::associateEditableImageWithAttachment): Deleted.
(WebCore::ChromeClient::didCreateEditableImage): Deleted.
(WebCore::ChromeClient::didDestroyEditableImage): Deleted.

• page/EditableImageReference.cpp: Removed.
• page/EditableImageReference.h: Removed.
• page/Settings.yaml:
• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::nextEmbeddedViewID): Deleted.

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setContentsToSolidColor):
(WebCore::GraphicsLayer::setContentsToEmbeddedView): Deleted.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayerForEmbeddedView): Deleted.
(WebCore::GraphicsLayerCA::setContentsToEmbeddedView): Deleted.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::embeddedViewID const): Deleted.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::isEditableImage const): Deleted.
(WebCore::RenderImage::requiresLayer const): Deleted.

• rendering/RenderImage.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly const):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
(WebCore::RenderLayerCompositor::reasonsForCompositing const):
(WebCore::RenderLayerCompositor::requiresCompositingForEditableImage const): Deleted.

• rendering/RenderLayerCompositor.h:

Source/WebKit:

• DerivedSources.make:
• Platform/spi/ios/PencilKitSPI.h: Removed.
• Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

• Shared/FocusedElementInformation.h:
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
• Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):

• Shared/WebPreferences.yaml:
• SourcesCocoa.txt:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setEditableImagesEnabled:]): Deleted.
(-[WKWebViewConfiguration _editableImagesEnabled]): Deleted.

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/API/ios/WKWebViewIOS.h:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _setupScrollAndContentViews]):
(-[WKWebView _stylusTapGestureShouldCreateEditableImage]): Deleted.

• UIProcess/PageClient.h:

(WebKit::PageClient::createDrawingView): Deleted.

• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::clearLayers):
(WebKit::RemoteLayerTreeHost::makeNode):

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::makeNode):
(WebKit::RemoteLayerTreeHost::createEmbeddedView): Deleted.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(-[WKEmbeddedView initWithEmbeddedViewID:]): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::willUpdateAttachmentAttributes):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::editableImageController): Deleted.

• UIProcess/ios/EditableImageController.h: Removed.
• UIProcess/ios/EditableImageController.messages.in: Removed.
• UIProcess/ios/EditableImageController.mm: Removed.
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createDrawingView): Deleted.

• UIProcess/ios/PencilKitSoftLink.h: Removed.
• UIProcess/ios/PencilKitSoftLink.mm: Removed.
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView _stylusSingleTapRecognized:]): Deleted.
(-[WKContentView _drawingCoordinator]): Deleted.

• UIProcess/ios/WKDrawingCoordinator.h: Removed.
• UIProcess/ios/WKDrawingCoordinator.mm: Removed.
• UIProcess/ios/WKDrawingView.h: Removed.
• UIProcess/ios/WKDrawingView.mm: Removed.
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::handleStylusSingleTapAtPoint): Deleted.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::associateEditableImageWithAttachment): Deleted.
(WebKit::WebChromeClient::didCreateEditableImage): Deleted.
(WebKit::WebChromeClient::didDestroyEditableImage): Deleted.

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayerForEmbeddedView): Deleted.

• WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h:
• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::createForEmbeddedView): Deleted.
(WebKit::PlatformCALayerRemote::embeddedViewID const): Deleted.

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
• WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerDidEnterContext):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableElement):
(WebKit::WebPage::getFocusedElementInformation):
(WebKit::WebPage::handleStylusSingleTapAtPoint): Deleted.

Tools:

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::drawSquareInEditableImage): Deleted.
(WTR::UIScriptController::numberOfStrokesInEditableImage): Deleted.

• TestRunnerShared/spi/PencilKitTestSPI.h: Removed.
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(webViewForTestingAttachments):
(TestWebKitAPI::forEachViewInHierarchy): Deleted.
(TestWebKitAPI::findEditableImageCanvas): Deleted.
(TestWebKitAPI::drawSquareInEditableImage): Deleted.

• TestWebKitAPI/ios/PencilKitTestSPI.h: Removed.
• WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

• WebKitTestRunner/ios/UIScriptControllerIOS.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::findEditableImageCanvas const): Deleted.
(WTR::UIScriptControllerIOS::drawSquareInEditableImage): Deleted.
(WTR::UIScriptControllerIOS::numberOfStrokesInEditableImage): Deleted.

LayoutTests:

• editing/images/basic-editable-image-expected.txt: Removed.
• editing/images/basic-editable-image-from-execCommand-expected.txt: Removed.
• editing/images/basic-editable-image-from-execCommand.html: Removed.
• editing/images/basic-editable-image-with-gesture-expected.txt: Removed.
• editing/images/basic-editable-image-with-gesture.html: Removed.
• editing/images/basic-editable-image.html: Removed.
• editing/images/editable-image-creates-attachment-expected.txt: Removed.
• editing/images/editable-image-creates-attachment.html: Removed.
• editing/images/paste-editable-image-expected.txt: Removed.
• editing/images/paste-editable-image.html: Removed.
• editing/images/redo-insert-editable-image-maintains-strokes-expected.txt: Removed.
• editing/images/redo-insert-editable-image-maintains-strokes.html: Removed.
• editing/images/reparent-editable-image-maintains-strokes-expected.txt: Removed.
• editing/images/reparent-editable-image-maintains-strokes.html: Removed.
• editing/images/undo-insert-editable-image-expected.txt: Removed.
• editing/images/undo-insert-editable-image.html: Removed.
• resources/ui-helper.js:

(window.UIHelper.drawSquareInEditableImage): Deleted.
(window.UIHelper.numberOfStrokesInEditableImage): Deleted.

6:29 PM Changeset in webkit [266341] by ysuzuki@apple.com

• 4 edits in trunk

[JSC] Use -2 for grouping options in IntlRelativeTimeFormat
​https://bugs.webkit.org/show_bug.cgi?id=215984

Reviewed by Ross Kirsling.

JSTests:

• stress/intl-relativetimeformat.js:

Source/JavaScriptCore:

Several test262 tests are failing after ICU 67. This is because Intl.RelativeTimeFormat is not using locale-sensitive grouping option.
There are hidden option -2 for UNumberFormat. It is supported so long, but it is not explicitly documented. After ICU 68, it is exposed as a constant,
we should pass -2 to UNumberFormat's grouping options to use locale-sensitive grouping option here.

• runtime/IntlRelativeTimeFormat.cpp:

(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):

6:26 PM Changeset in webkit [266340] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] async function cannot appear in single-statement context
​https://bugs.webkit.org/show_bug.cgi?id=215993

Reviewed by Darin Adler.

JSTests:

• stress/async-function-lookahead.js: Added.

(testSyntax):
(testSyntaxError):
(testSyntax.false.async t):
(testSyntaxError.false.async t):

• test262/expectations.yaml:

Source/JavaScriptCore:

The following code is syntax error[1] because ExpressionStatement has async [no LineTerminator here] function lookahead.

if (false)

async function t() { }

[1]: ​https://tc39.es/ecma262/#sec-expression-statement

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::maybeParseAsyncFunctionDeclarationStatement): Deleted.

• parser/Parser.h:

6:20 PM Changeset in webkit [266339] by weinig@apple.com

• 6 edits
  1 copy
  2 adds in trunk/Source/WebCore

EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface
​https://bugs.webkit.org/show_bug.cgi?id=215992

Reviewed by Darin Adler.

Add support for merging extended attributes that support conjunctions (like EnabledBySetting) when
they are used in both a partial wide context and on a member. This allows a case like:

[

EnabledBySettings=FirstSetting

] partial interface Foo {

[EnabledBySettings=SecondSetting] attribute DOMString bar;

};

to be identical to:

partial interface Foo {

[EnabledBySettings=FirstSetting&SecondSetting] attribute DOMString bar;

};

• bindings/scripts/CodeGenerator.pm:

(MergeExtendedAttributesFromSupplemental):
Factor out and rework merging logic. Only allow adding extended attributes that are allowed for the context
they are being merge into to be merged, and only allow extended attributes declared in IDLAttributes.json as
supporting conjunctions to be merged.

(ProcessSupplementalDependencies):
Call MergeExtendedAttributesFromSupplemental for each type of member.

(ExtendedAttributeContains):
Fix variable name, since this is used for all extended attributes, not just callWith.

• bindings/scripts/IDLAttributes.json:

Add supportsConjunction keys for extended attributes that support the conjunction (&) syntax and semantics.

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingPrototype::finishCreation):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttributeGetter):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttributeSetter):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::jsTestEnabledBySettingSupplementalAttributeGetter):
(WebCore::jsTestEnabledBySettingSupplementalAttribute):
(WebCore::setJSTestEnabledBySettingSupplementalAttributeSetter):
(WebCore::setJSTestEnabledBySettingSupplementalAttribute):

• bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp: Added.
• bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h: Added.
• bindings/scripts/test/SupplementalDependencies.dep:
• bindings/scripts/test/TestEnabledBySetting.idl:
• bindings/scripts/test/TestEnabledBySettingSupplemental.idl: Added.

Add/update tests.

4:16 PM Changeset in webkit [266338] by Simon Fraser

• 2 edits in trunk/Source/WebCore

REGRESSION (r266333): Mousewheel scrolling no longer works on WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=215990

Reviewed by Tim Horton.

Make sure we call processWheelEventForScrolling() when ENABLE(WHEEL_EVENT_LATCHING) is not
defined.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

3:25 PM Changeset in webkit [266337] by Simon Fraser

• 3 edits
  2 adds in trunk

Rubberbanding in an overflow:scroll can trigger page jiggles
​https://bugs.webkit.org/show_bug.cgi?id=215629
<rdar://problem/67295797>

Reviewed by Tim Horton.

Source/WebCore:

When a scroller starts to rubberband, and is receiving momentum scroll events, it gets
into a state where events are ignored (to stop endless stretching). When in that
state, ScrollController::handleWheelEvent() needs to report that it handled the event,
to avoid the event bouncing to the scrolling thread and triggering page scrolls.

Test: fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html

• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

LayoutTests:

• fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle-expected.txt: Added.
• fast/scrolling/mac/rubberband-overflow-in-wheel-region-root-jiggle.html: Added.

3:09 PM Changeset in webkit [266336] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r266262): Scroll latching fails when scrolling into a preventDefault() region
​https://bugs.webkit.org/show_bug.cgi?id=215988
<rdar://problem/68034716>

Reviewed by Tim Horton.
Source/WebCore:

In r266262 ScrollingTreeLatchingController started to consult the "last handled wheel event"
time when deciding whether to use the latched node, but we didn't update this timestamp when
handling an event on the latched node, on the scrolling thread. So fix that.

Test: fast/scrolling/latching/latched-scroll-into-nonfast-region.html

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent):

LayoutTests:

• fast/scrolling/latching/latched-scroll-into-nonfast-region-expected.txt: Added.
• fast/scrolling/latching/latched-scroll-into-nonfast-region.html: Added.

1:24 PM Changeset in webkit [266335] by Fujii Hironori

• 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo/TestExpectations:

12:45 PM Changeset in webkit [266334] by Simon Fraser

• 1 edit
  1 add in trunk/LayoutTests

Add missing test result from r266333.

• fast/scrolling/latching/latched-scroll-remove-iframe-expected.txt: Added.

10:25 AM Changeset in webkit [266333] by Simon Fraser

• 16 edits
  3 adds
  2 deletes in trunk

Rewrite main thread scroll latching logic
​https://bugs.webkit.org/show_bug.cgi?id=215979

Reviewed by Tim Horton.
Source/WebCore:

The existing main thread wheel event handling and latching logic had a number of issues,
some of which were indicated via the FIXME comments added in r266016:

• It tracked scrollable containers as ContainerNodes rather than ScrollableAreas
• It fetched and used latched state from a different frame, causing an EventHandler to end up scrolling some unrelated frame.
• Overflow scrolling ignored latched state.
• The latching stack's purpose was unclear.

This patch fixes those issues. The design is as follow:

• Latching logic is moved into ScrollLatchingController, which is owned by Page.
• ScrollLatchingController owns a stack of FrameState.
• When receiving a wheel event, determineWheelEventTarget() identifies the target ScrollableArea, if any, for that frame only.
• As hit-testing descends into subframes, state is pushed onto ScrollLatchingController's state stack. Frames with potential scrollers have a non-null ScrollableArea in their state.
• The latched ScrollableArea is the top non-null ScrollableArea in this stack.
• EventHandler consults ScrollLatchingController for select, overflow and frame scrolling.

This change fixes an issue where scrolling over an overflow:scroll in the non-fast scrollable
region would rubber-band the overflow, rather than the main page (tested by the adjusted
fast/scrolling/mac/rubberband-overflow-in-wheel-region.html).

Tests: fast/scrolling/latching/latched-scroll-remove-iframe.html

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::EventHandler::completeWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearLatchedState):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::clearLatchedStateTimerFired): Deleted.
(WebCore::EventHandler::clearOrScheduleClearingLatchedStateIfNeeded): Deleted.

• page/EventHandler.h:
• page/Page.cpp:

(WebCore::Page::startMonitoringWheelEvents):
(WebCore::Page::scrollLatchingController):
(WebCore::Page::scrollLatchingControllerIfExists):
(WebCore::Page::latchingState): Deleted.
(WebCore::Page::pushNewLatchingState): Deleted.
(WebCore::Page::resetLatchingState): Deleted.
(WebCore::Page::popLatchingState): Deleted.
(WebCore::Page::removeLatchingStateForTarget): Deleted.

• page/Page.h:

(WebCore::Page::latchingStateStack const): Deleted.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::determineWheelEventTarget):
(WebCore::EventHandler::processWheelEventForScrolling):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::processWheelEventForScrollSnap):
(WebCore::deltaIsPredominantlyVertical): Deleted.
(WebCore::scrolledToEdgeInDominantDirection): Deleted.
(WebCore::latchingIsLockedToPlatformFrame): Deleted.
(WebCore::latchingIsLockedToAncestorOfThisFrame): Deleted.
(WebCore::latchedToFrameOrBody): Deleted.
(WebCore::EventHandler::clearOrScheduleClearingLatchedStateIfNeeded): Deleted.
(WebCore::frameViewForLatchingState): Deleted.

• page/scrolling/ScrollLatchingController.cpp: Added.

(WebCore::ScrollLatchingController::ScrollLatchingController):
(WebCore::ScrollLatchingController::clear):
(WebCore::ScrollLatchingController::clearOrScheduleClearIfNeeded):
(WebCore::ScrollLatchingController::clearTimerFired):
(WebCore::ScrollLatchingController::receivedWheelEvent):
(WebCore::ScrollLatchingController::latchingAllowsScrollingInFrame const):
(WebCore::ScrollLatchingController::updateLatchingStateForFrame):
(WebCore::ScrollLatchingController::getLatchingStateForFrame const):
(WebCore::ScrollLatchingController::removeLatchingStateForTarget):
(WebCore::ScrollLatchingController::removeLatchingStateForFrame):
(WebCore::deltaIsPredominantlyVertical):
(WebCore::ScrollLatchingController::shouldLatchToScrollableArea const):
(WebCore::ScrollLatchingController::hasStateForFrame const):
(WebCore::ScrollLatchingController::stateForFrame):
(WebCore::ScrollLatchingController::stateForFrame const):
(WebCore::ScrollLatchingController::dump const):
(WebCore::operator<<):

• page/scrolling/ScrollLatchingController.h: Added.

(WebCore::ScrollLatchingController::cumulativeEventDelta const):

• page/scrolling/ScrollLatchingState.cpp: Removed.
• page/scrolling/ScrollLatchingState.h: Removed.
• page/scrolling/ScrollingTreeLatchingController.cpp:

(WebCore::ScrollingTreeLatchingController::receivedWheelEvent):
(WebCore::ScrollingTreeLatchingController::nodeDidHandleEvent):

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsHorizontalStretching const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::allowsVerticalStretching const):
(WebCore::newGestureIsStarting): Deleted.

• platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::isGestureStart const):
(WebCore::PlatformWheelEvent::isGestureContinuation const):
(WebCore::PlatformWheelEvent::shouldResetLatching const):
(WebCore::PlatformWheelEvent::isNonGestureEvent const):
(WebCore::PlatformWheelEvent::shouldConsiderLatching const): Deleted. Renamed to isGestureStart(). This class
should not prescribe latching behaviors.

LayoutTests:

Add a test for iframe unparenting in the middle of a latched scroll.

• fast/scrolling/latching/latched-scroll-remove-iframe.html: Added.
• fast/scrolling/latching/scroll-nested-iframe.html: 1000ms -> 0ms
• fast/scrolling/mac/rubberband-overflow-in-wheel-region.html: Test needs to latch the overflow by scrolling down then up.

2:53 AM Changeset in webkit [266332] by youenn@apple.com

• 26 edits
  5 adds in trunk

Add support for TextEncoderStream
​https://bugs.webkit.org/show_bug.cgi?id=215916

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/encoding/idlharness.any-expected.txt:
• web-platform-tests/encoding/idlharness.any.worker-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any-expected.txt:
• web-platform-tests/encoding/streams/backpressure.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any-expected.txt:
• web-platform-tests/encoding/streams/encode-bad-chunks.any.worker-expected.txt:
• web-platform-tests/encoding/streams/encode-utf8.any-expected.txt:
• web-platform-tests/encoding/streams/encode-utf8.any.worker-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any-expected.txt:
• web-platform-tests/encoding/streams/readable-writable-properties.any.worker-expected.txt:
• web-platform-tests/encoding/streams/realms.window-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Implement TextEncoderStream as a JS built-in.
It is controlled by transform stream runtime flag.

TextEncoderStream takes a TransformStream and TextEncoderStreamEncoder as private slots.
Add TextEncoderStreamEncoder to implement the actual UTF-8 encoding steps.
Covered by rebased tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Modules/streams/TransformStream.idl:
• Modules/streams/TransformStream.js:

(initializeTransformStream):

• Modules/streams/TransformStreamInternals.js:

(createTransformStream):

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/TextEncoderStream.idl: Added.
• dom/TextEncoderStream.js: Added.

(initializeTextEncoderStream):
(getter.encoding):
(getter.readable):
(getter.writable):

• dom/TextEncoderStreamEncoder.cpp: Added.

(WebCore::TextEncoderStreamEncoder::encode):
(WebCore::TextEncoderStreamEncoder::flush):

• dom/TextEncoderStreamEncoder.h: Added.

(WebCore::TextEncoderStreamEncoder::create):

• dom/TextEncoderStreamEncoder.idl: Added.

LayoutTests:

• TestExpectations:

2:40 AM Changeset in webkit [266331] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[GTK] REGRESSION(r150392) insufficient space allocation results in heap corruption
​https://bugs.webkit.org/show_bug.cgi?id=215976

Patch by Jim Mason <​jmason@ibinx.com> on 2020-08-30
Reviewed by Carlos Garcia Campos.

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::TimerBase):