Context Navigation

← Previous Period
Next Period →

Timeline

Sep 7, 2020:

9:30 PM Changeset in webkit [266714] by rniwa@webkit.org

11 edits in trunk/Source/WebCore

Move all remaining flags from ElementRareData to Node to reduce the frequency
https://bugs.webkit.org/show_bug.cgi?id=216208

Reviewed by Darin Adler.

This patch moves all remaining bit flags from ElementRareData to Node::m_nodeFlags. It also stores
tabIndex of 0 and -1 in Node::m_nodeFlags to avoid creating ElementRareData for these common values.

No new tests since there should be no behavioral change.

dom/Element.cpp:

(WebCore::Element::clearTabIndexExplicitlyIfNeeded): Deleted. Merged into setTabIndexExplicitly.
(WebCore::Element::setTabIndexExplicitly): Now takes Optional<int>. Stores 0 and -1 as node flags.
(WebCore::Element::tabIndexSetExplicitly const): Added the special casing for 0 and -1.
(WebCore::Element::removedFromAncestor):
(WebCore::Element::containsFullScreenElement const): Deleted.
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::hasPendingResources const): Deleted.
(WebCore::Element::setHasPendingResources): Deleted.
(WebCore::Element::clearHasPendingResources): Deleted.
(WebCore::Element::hasCSSAnimation const): Deleted.
(WebCore::Element::setHasCSSAnimation): Deleted.
(WebCore::Element::clearHasCSSAnimation): Deleted.
(WebCore::Element::createElementIdentifier):

dom/Element.h:

(WebCore::Element::hasPendingResources const): Moved here from Element.cpp.
(WebCore::Element::setHasPendingResources): Ditto.
(WebCore::Element::clearHasPendingResources): Ditto.
(WebCore::Element::hasCSSAnimation const): Ditto.
(WebCore::Element::setHasCSSAnimation): Ditto.
(WebCore::Element::clearHasCSSAnimation): Ditto.
(WebCore::Element::containsFullScreenElement const): Ditto.

dom/ElementRareData.cpp:
dom/ElementRareData.h:

(WebCore::ElementRareData::tabIndex const): Deleted.
(WebCore::ElementRareData::setTabIndexExplicitly): Deleted.
(WebCore::ElementRareData::tabIndexSetExplicitly const): Deleted.
(WebCore::ElementRareData::clearTabIndexExplicitly): Deleted.
(WebCore::ElementRareData::containsFullScreenElement): Deleted.
(WebCore::ElementRareData::setContainsFullScreenElement): Deleted.
(WebCore::ElementRareData::hasPendingResources const): Deleted.
(WebCore::ElementRareData::setHasPendingResources): Deleted.
(WebCore::ElementRareData::hasCSSAnimation const): Deleted.
(WebCore::ElementRareData::setHasCSSAnimation): Deleted.
(WebCore::ElementRareData::hasElementIdentifier const): Deleted.
(WebCore::ElementRareData::setHasElementIdentifier): Deleted.
(WebCore::ElementRareData::useTypes const): Added the missing use types for style maps, part list,
and part names.
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::unusualTabIndex const): Renamed from tabIndex.
(WebCore::ElementRareData::setUnusualTabIndex): Ditto from setTabIndexExplicitly.

dom/Node.cpp:

(WebCore::stringForRareDataUseType): Added the missing strings.

dom/Node.h:

(WebCore::Node::NodeFlags): Moved bit flags from ElementRareData and reserved the two highest bits
to store TabIndexState.
(WebCore::Node::s_tabIndexStateBitOffset): Added.
(WebCore::Node::s_tabIndexStateBitMask): Added.
(WebCore::Node::TabIndexState): Added.
(WebCore::Node::tabIndexState const): Added.
(WebCore::Node::setTabIndexState): Added.

dom/NodeRareData.h:

(WebCore::NodeRareData::UseType): Added the missing use types: style maps, part list, and part names.

html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::parseAttribute):

svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute):

8:50 PM Changeset in webkit [266713] by rniwa@webkit.org

5 edits in trunk

Make CompactUniquePtrTuple actually work with subclassing and custom deleter
https://bugs.webkit.org/show_bug.cgi?id=216225

Reviewed by Darin Adler.

Source/WTF:

Fixed bugs in CompactUniquePtrTuple which prevented subclassing and custom deleter to work.

wtf/CompactPointerTuple.h:

(WTF::CompactPointerTuple::CompactPointerTuple): Added move constructor with implicit cast
of a convertible pointer type.

wtf/CompactUniquePtrTuple.h:

(WTF::makeCompactUniquePtr): Added the missing deleter from the return type.
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Allow Deleter to be different if it's
the default deleter in the move constructor so that CompactUniquePtrTuple<U, Type> could be
moved to CompactUniquePtrTuple<T, Type> if U is convertible to T without having to specify
the same deleter (std::default_delete<U> is not same as std::default_delete<T> but allow it).
(WTF::CompactUniquePtrTuple::operator=): Ditto.
(WTF::CompactUniquePtrTuple::setPointer): Ditto from std::unique_ptr.
(WTF::CompactUniquePtrTuple): Friend declare all other specializations of CompactUniquePtrTuple
so that the above fixes work.

Tools:

TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp:

(TestWebKitAPI::A::~A): Make this virtual.
(TestWebKitAPI::B): Added.
(TestWebKitAPI::B::B): Added.
(TestWebKitAPI::B::~B): Added.
(WTF_CompactUniquePtrTuple.Subclassing): Added. Tests subclassing.
(TestWebKitAPI::ADeleter): Added.
(TestWebKitAPI::ADeleter::operator() const):
(WTF_CompactUniquePtrTuple.Deleter): Added. Tests a custom deleter.

7:46 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

6:35 PM Changeset in webkit [266712] by Chris Dumez

12 edits
5 adds
2 deletes in trunk

AudioParam.cancelAndHoldAtTime() is missing
https://bugs.webkit.org/show_bug.cgi?id=215947
<rdar://problem/68362061>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

web-platform-tests/webaudio/idlharness.https.window-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurveAtTime-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:

Source/WebCore:

Add implementation for AudioParam.cancelAndHoldAtTime():

https://www.w3.org/TR/webaudio/#dom-audioparam-cancelandholdattime

This patch is based on the following Blink commit by Raymond Toy:

https://codereview.chromium.org/1533103002

Tests: webaudio/audioparam-cancel-and-hold.html

webaudio/cancel-values-crash-913217.html

Modules/webaudio/AudioParam.cpp:
Modules/webaudio/AudioParam.h:
Modules/webaudio/AudioParam.idl:
Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::setValueAtTime):
(WebCore::AudioParamTimeline::linearRampToValueAtTime):
(WebCore::AudioParamTimeline::exponentialRampToValueAtTime):
(WebCore::AudioParamTimeline::setTargetAtTime):
(WebCore::AudioParamTimeline::setValueCurveAtTime):
(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelAndHoldAtTime):
(WebCore::AudioParamTimeline::removeCancelledEvents):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::linearRampAtTime):
(WebCore::AudioParamTimeline::exponentialRampAtTime):
(WebCore::AudioParamTimeline::valueCurveAtTime):
(WebCore::AudioParamTimeline::handleCancelValues):

Modules/webaudio/AudioParamTimeline.h:

(WebCore::AudioParamTimeline::ParamEvent::createSetValueEvent):
(WebCore::AudioParamTimeline::ParamEvent::createLinearRampEvent):
(WebCore::AudioParamTimeline::ParamEvent::createExponentialRampEvent):
(WebCore::AudioParamTimeline::ParamEvent::createSetTargetEvent):
(WebCore::AudioParamTimeline::ParamEvent::createSetValueCurveEvent):
(WebCore::AudioParamTimeline::ParamEvent::createCancelValuesEvent):
(WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
(WebCore::AudioParamTimeline::ParamEvent::type const):
(WebCore::AudioParamTimeline::ParamEvent::savedEvent):
(WebCore::AudioParamTimeline::ParamEvent::setCancelledValue):
(WebCore::AudioParamTimeline::ParamEvent::hasDefaultCancelledValue const):
(WebCore::AudioParamTimeline::ParamEvent::curvePointsPerSecond const):
(WebCore::AudioParamTimeline::ParamEvent::curveEndValue const):

LayoutTests:

webaudio/audioparam-cancel-and-hold-expected.txt: Added.
webaudio/audioparam-cancel-and-hold.html: Added.
webaudio/cancel-values-crash-913217-expected.txt: Added.
webaudio/cancel-values-crash-913217.html: Added.
webaudio/resources/audio-param.js: Added.

Import layout test coverage from Blink.

webaudio/audioparam-setValueCurveAtTime-expected.txt: Removed.
webaudio/audioparam-setValueCurveAtTime.html: Removed.

Remove outdated test. This test is now part of web-platform-tests at
webaudio/the-audio-api/the-audioparam-interface/audioparam-setValueCurveAtTime.html
and is now passing.

3:35 PM Changeset in webkit [266711] by Karl Rackler

1 edit
9 deletes in trunk/LayoutTests

Remove duplicate test expectaions from platform/mac-bigsur
rdar://68372418

Unreviewed test gardening.

platform/mac-bigsur/fast/css/text-overflow-input-expected.txt: Removed.
platform/mac-bigsur/fast/forms/button-sizes-expected.txt: Removed.
platform/mac-bigsur/fast/forms/button-table-styles-expected.txt: Removed.
platform/mac-bigsur/fast/forms/input-button-sizes-expected.txt: Removed.
platform/mac-bigsur/fast/forms/listbox-bidi-align-expected.txt: Removed.
platform/mac-bigsur/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
platform/mac-bigsur/tables/mozilla/bugs/bug33855-expected.txt: Removed.
platform/mac-bigsur/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.

1:55 PM Changeset in webkit [266710] by commit-queue@webkit.org

6 edits in trunk/Source

Unreviewed, reverting r266645.
https://bugs.webkit.org/show_bug.cgi?id=216251

Caused MotionMark regression

Reverted changeset:

"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
https://bugs.webkit.org/show_bug.cgi?id=216195
https://trac.webkit.org/changeset/266645

12:36 PM Changeset in webkit [266709] by weinig@apple.com

12 edits
12 adds in trunk

[WebIDL] Fix issues found by preprocess-idls.pl parser validation and enabled parser validation by default for the tests
https://bugs.webkit.org/show_bug.cgi?id=216246

Reviewed by Darin Adler.

Source/WebCore:

Enabling preprocess-idls.pl's validation parser for run-bindings-tests revealed a few issues
that this change fixes:

Includes statements (as well as any other non-extended attribute related statement) in a comment were being treated as being part of the document. Fixed this by moving the existing c/c++ style comment removal from getInterfaceExtendedAttributesFromIDL to processIDL so it is run for all IDLs. Since getInterfaceExtendedAttributesFromIDL was called for most files anyway, this doesn't measurably change the performance.
Some test IDLs did not have their primary interface name matching the name of the IDL file. This resulted in a number of tests not actually producing any output. Updated the tests themselves to match name.

To ensure we don't regress here, the validation parser is now always enabled when running
the tests, and preprocess-idls.pl has been updated to be a little less noisy when running
with the validation parser enabled (unless you specify --verbose) so that the test output
is not disturbed.

bindings/scripts/preprocess-idls.pl:

(processIDL):
(getPartialNamesFromIDL):
(getIncludedInterfacesFromIDL):
(isCallbackInterfaceFromIDL):
(isMixinInterfaceFromIDL):
(containsIterableInterfaceFromIDL):
(containsInterfaceOrCallbackInterfaceFromIDL):
(containsInterfaceWithConstantsFromIDL):
(getInterfaceExtendedAttributesFromIDL):
(getUndefinedBaseDictionariesFromIDL):

bindings/scripts/test/JS/JSTestDomainSecurity.cpp: Added.
bindings/scripts/test/JS/JSTestDomainSecurity.h: Added.
bindings/scripts/test/JS/JSTestMapLike.cpp: Added.
bindings/scripts/test/JS/JSTestMapLike.h: Added.
bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp: Added.
bindings/scripts/test/JS/JSTestReadOnlyMapLike.h: Added.
bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp: Added.
bindings/scripts/test/JS/JSTestReadOnlySetLike.h: Added.
bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp: Added.
bindings/scripts/test/JS/JSTestReportExtraMemoryCost.h: Added.
bindings/scripts/test/JS/JSTestSetLike.cpp: Added.
bindings/scripts/test/JS/JSTestSetLike.h: Added.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestDomainSecurity.idl:
bindings/scripts/test/TestMapLike.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestReadOnlyMapLike.idl:
bindings/scripts/test/TestReadOnlySetLike.idl:
bindings/scripts/test/TestReportExtraMemoryCost.idl:
bindings/scripts/test/TestSetLike.idl:

Tools:

Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
Enable the parser validation for preprocess-idls.pl to catch accidental differences between
the fast regex based scanner in preprocess-idls.pl and the real IDL parser.

12:04 PM Changeset in webkit [266708] by youenn@apple.com

2 edits in trunk/Source/WebCore

Fix https://trac.webkit.org/changeset/266508 as per post-commit comments
https://bugs.webkit.org/show_bug.cgi?id=216242

Reviewed by Alex Christensen.

No change of behavior.

platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::toRTCRtpCapabilities):

11:54 AM Changeset in webkit [266707] by Alan Bujtas

3 edits in trunk/LayoutTests

Unreviewed rebaselining.

The test output (render tree dump) is sensitive to float precision.

r266509 slightly changed the way we compute the run's horizontal position
and its new position is 0.000061px more to the right. The integral ceil that we apply
to the run's width computation in the dump-render-tree-as-text makes the final value go from 39px to 40px.
(Note that final width value has dependency on the horizontal positon.)

platform/ios-wk2/TestExpectations:
platform/ios/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:

11:42 AM Changeset in webkit [266706] by weinig@apple.com

17 edits
1 copy
3 adds in trunk/Source/WebCore

[WebIDL] Support extended attributes on includes statements to allow for conditionalized inclusion
https://bugs.webkit.org/show_bug.cgi?id=216235

Reviewed by Darin Adler.

In some circumstancs, such as with the AnimationFrameProvider interface mixin, it is
useful to only include a mixin based on some conditional. For AnimationFrameProvider,
we currently only want to include it in DedicatedWorkerGlobalScope if ENABLE(OFFSCREEN_CANVAS)
is set at compile time, and the runtime feature flag offscreenCanvasEnabled() is turned
on. To support that, this change adds support for specifying extended attributes on the
includes statement itself, and having those extended attributes applied to each member
of the mixin. For AnimationFrameProvider in DedicatedWorkerGlobalScope, that looks like:

[Conditional=OFFSCREEN_CANVAS, EnabledAtRuntime=OffscreenCanvas] DedicatedWorkerGlobalScope includes AnimationFrameProvider;

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:

Add new files, update xcfilelists.

animation/AnimationFrameProvider.idl: Added.
page/DOMWindow.idl:
workers/DedicatedWorkerGlobalScope.idl:

Split AnimationFrameProvider.idl out into its own mixin (as specified) and included it in
both DOMWindow and DedicatedWorkerGlobalScope (conditionally).

bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(ProcessDictionaryAndEnumerationImplementedAsOverrides):
(ProcessInterfaces):
(ProcessCallbackFunctions):
(ProcessDictionaries):
(ProcessEnumerations):
Split processing of each different type of top level type into its own function,
and defer processing of supplemental dependencies until the primary type has been
selected.

(MergeExtendedAttributesFromSupplemental):
(IsValidSupplementalInterface):
(IsValidSupplementalDictionary):
(ProcessInterfaceSupplementalDependencies):
(ProcessDictionarySupplementalDependencies):
Split ProcessSupplementalDependencies into ProcessInterfaceSupplementalDependencies
and ProcessDictionarySupplementalDependencies, which now get passed the primary
interface or dictionary that needs supplementing. ProcessInterfaceSupplementalDependencies
now also supports merging extended attributes from includes statements and checking
that all includes are listed in the dependency set.

bindings/scripts/IDLAttributes.json:

Allow setting use of Conditional, EnabledAtRuntime and EnabledBySetting for
includes statements.

bindings/scripts/IDLParser.pm:

(parseIncludesStatement):
Fix ordering of struct members so that extendedAttributes is always last (no real
good reason other than most of the structs already did this and the lack of consistency
bothered me). Add extendedAttributes to IDLIncludesStatement and set it when
parsing.

bindings/scripts/preprocess-idls.pl:

(getIncludedInterfacesFromIDL):
Fix bug in regex (found easily by the validation parser!) that incorrectly required the interface
name in the includes statement to be the first word on a line.

bindings/scripts/test/BindingTestGlobalConstructors.idl:
bindings/scripts/test/JS/JSTestConditionalIncludes.cpp: Added.
bindings/scripts/test/JS/JSTestConditionalIncludes.h: Added.
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestConditionalIncludes.idl: Added.
bindings/scripts/test/TestIncludes.idl:

Add tests for extended attributes on includes statements.

10:55 AM Changeset in webkit [266705] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Add memory cache with/without validation to logResourceResponseSource
https://bugs.webkit.org/show_bug.cgi?id=216244
<rdar://problem/64184239>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-07
Reviewed by Darin Adler.

loader/ResourceLoader.cpp:

(WebCore::logResourceResponseSource):

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::memoryCacheKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheAfterValidationKey):

page/DiagnosticLoggingKeys.h:

10:43 AM Changeset in webkit [266704] by Darin Adler

2 edits in trunk/LayoutTests

platform/mac-wk2/TestExpectations: Revert change I accidentally included in my last patch.

10:11 AM Changeset in webkit [266703] by Darin Adler

14 edits in trunk

Make TextCodecCJK and TextCodecSingleByte thread-safe and refactor a bit to share code
https://bugs.webkit.org/show_bug.cgi?id=216229

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

web-platform-tests/encoding/eof-utf-8-one.html:
web-platform-tests/encoding/eof-utf-8-three.html:
web-platform-tests/encoding/eof-utf-8-two.html:

Updated these files with fresh copies. Somehow, the trailing invalid
UTF-8 sequences from these files must have gotten lost when we
re-synced web-platform-tests/encoding from upstream. If we do that
again, then these tests will start failing again.

Source/WebCore:

The text encoding machinery is usable on multiple threads, but our new TextCodec
classes have some global data structures that need to be guarded to keep that intact.

platform/text/EncodingTables.cpp:

(WebCore::checkEncodingTableInvariants): One-time check for invariants that clients
of these tables depend on.

platform/text/EncodingTables.h: Added checkEncodingTableInvariants. Also Added

function templates for encoding tables: Added findFirstInSortedPairs,
findLastInSortedPairs and findInSortedPairs for searching a sorted array of pairs
used as a map. Added sortByFirst to aid in the creation of such a sorted array.
And added isSortedByFirst and sortedFirstsAreUnique so we can assert those invariants.
One of the good features of the findInSortedPairs functions is that they handle integer
values that don't fit in an integral key type, returning WTF::nullopt in that case.
That lets us pass code point values when looking in tables that use code units as their
key, without separately checking if they are in range, which otherwise requires
converting to UChar and checking for equality or calling U_IS_BMP.

platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::TextCodecCJK): Call checkEncodingTableInvariants.
(WebCore::TextCodecCJK::encode const): Ditto.
(WebCore::jis0208DecodeIndex): Use std::call_once for thread safety.
Use sortByFirst and sortedFirstsAreUnique.
(WebCore::codePointJIS0208): Use findFirstInSortedPairs.
(WebCore::codePointJIS0212): Ditto.
(WebCore::TextCodecCJK::eucJPDecode): Cast to char instad of LChar when adding
an ASCII character to a StringBuilder.
(WebCore::eucJPEncode): Use the name codePoint instead of c to match other
surrounding code. Use findLastInSortedPairs.
(WebCore::iso2022JPEncode): Removed some unneeded casts to uint8_t when appending
bytes to a Vector. Added a static_assert to check the size of iso2022JPKatakana.
Use findLastInSortedPairs.
(WebCore::shiftJISEncode): Use findInSortedPairs.
(WebCore::eucKREncodingIndex): Use std::call_once for thread safety.
Use sortByFirst and sortedFirstsAreUnique.
(WebCore::eucKREncode): Removed some unneeded casts to uint8_t when appending
bytes to a Vector. Use findFirstInSortedPairs.
(WebCore::TextCodecCJK::eucKRDecode): Use findFirstInSortedPairs.
(WebCore::big5Encode): Use findInSortedPairs. Also renamed c to codePoint.
(WebCore::big5DecodeIndex): Use std::call_once for thread safety.
Use sortByFirst and sortedFirstsAreUnique.
(WebCore::TextCodecCJK::big5Decode): Use findFirstInSortedPairs. Cast to char
instad of LChar when adding an ASCII character to a StringBuilder.

platform/text/TextCodecSingleByte.cpp:

(WebCore::tableForEncoding): Return an IteratorRange instead of a pair of
pointer and size. This works with std::begin/end. Also make table with actual
encoded bytes, by adding 0x80 here, rather than doing that when using the table.
(WebCore::encode): Use std::call_once for thread safety.
Use sortByFirst and sortedFirstsAreUnique. The code before was not sorting at
all, which means it probably didn't work in any cases where the code units
happen to not be in ascending order. We should add some test cases.
(WebCore::decode): Use findFirstInSortedPairs. Also use StringView::codePoints
because these are likely to be 8-bit strings and we don't need to temporarily
upconvert them to 16-bit just to encode them. Should probably later measure if
the use of StringView::upconvertedCharacters plus CodePointIterator<UChar>
instead of StringView::codePoints is better for performance in the CJK encoding
functions. This approach means more branching inside the loop, but the other
version involves memory allocation and a second loop when the characters are
all 8-bit.

Tools:

TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST): Removed an unused variable. At one point, with
code that I wrote and now have rolled out, this was causing a build failure.

LayoutTests:

TestExpectations: Removed expectation that skips the three eof-utf-8

tests. They were failing because the tests were imported into the source
tree improperly and are passing now that is fixed.

10:02 AM Changeset in webkit [266702] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Build failure; cannot find seccomp.h
https://bugs.webkit.org/show_bug.cgi?id=216226

Patch by Mike Gorse <mgorse@suse.com> on 2020-09-07
Reviewed by Darin Adler.

No new tests (build fix only).

PlatformGTK.cmake: Add LIBSECCOMP_INCLUDE_DIRS to

WebKit_SYSTEM_INCLUDE_DIRECTORIES.

9:11 AM Changeset in webkit [266701] by youenn@apple.com

5 edits in trunk

Fix Internals::supportsVCPEncoder on BigSur
https://bugs.webkit.org/show_bug.cgi?id=216174

Reviewed by Eric Carlson.

Source/WebCore:

Fixed by unflaked test.

testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder):
All MacOS supported versions now supports VCP.

LayoutTests:

platform/mac-wk2/TestExpectations:
platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:

Slight modification to make the test run faster and output more comprehensive error message if error happens.

9:11 AM Changeset in webkit [266700] by youenn@apple.com

2 edits in trunk/Source/WebCore

Update IDLAttributes.json to forbid Exposed on dictionary
https://bugs.webkit.org/show_bug.cgi?id=216243

Reviewed by Alex Christensen.

bindings/scripts/IDLAttributes.json:

8:51 AM Changeset in webkit [266699] by youenn@apple.com

7 edits
12 adds in trunk

Safari takes too long to fetch images from memory cache
https://bugs.webkit.org/show_bug.cgi?id=216048
<rdar://problem/68260952>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/fetch/stale-while-revalidate/stale-image.html:
web-platform-tests/html/dom/elements/images/bypass-cache-revalidation-expected.txt: Added.
web-platform-tests/html/dom/elements/images/bypass-cache-revalidation.html: Added.
web-platform-tests/html/dom/elements/images/image.py: Added.

(main):

Source/WebCore:

In case of image resource, we skip revalidation if the stored image is from the same document.
This is inline with https://html.spec.whatwg.org/#updating-the-image-data:list-of-available-images
which defines a list of available images for each Document.
In case fetch mode is different, we do not skip revalidation as we might otherwise bypass security checks.

Tests: http/wpt/html/dom/elements/images/bypass-cache-redirection-revalidation.html

http/wpt/html/dom/elements/images/hover-image-change.html
imported/w3c/web-platform-tests/html/dom/elements/images/bypass-cache-revalidation.html

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):
(WebCore::CachedImage::canSkipRevalidation const):

loader/cache/CachedImage.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy const):

LayoutTests:

http/wpt/html/dom/elements/images/bypass-cache-redirection-revalidation-expected.txt: Added.
http/wpt/html/dom/elements/images/bypass-cache-redirection-revalidation.html: Added.
http/wpt/html/dom/elements/images/hover-image-change-expected.html: Added.
http/wpt/html/dom/elements/images/hover-image-change.html: Added.
http/wpt/html/dom/elements/images/redirect.py: Added.

5:37 AM Changeset in webkit [266698] by youenn@apple.com

27 edits
8 adds in trunk

Add missing members to RTCIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=216075

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCIceCandidate-constructor-expected.txt:
web-platform-tests/webrtc/RTCIceCandidate-constructor.html:
web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/ThirdParty/libwebrtc:

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:

Source/WebCore:

Sync IDL with latest spec.
Add missing enums and make use of libwebrtc parse routine to get fields from candidate SDP.
Covered by updated tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::RTCIceCandidate):
(WebCore::RTCIceCandidate::create):

Modules/mediastream/RTCIceCandidate.h:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCIceCandidateInit.h:
Modules/mediastream/RTCIceCandidateInit.idl:
Modules/mediastream/RTCIceCandidateType.h: Added.
Modules/mediastream/RTCIceCandidateType.idl: Added.
Modules/mediastream/RTCIceComponent.h: Added.
Modules/mediastream/RTCIceComponent.idl: Added.
Modules/mediastream/RTCIceProtocol.h: Added.
Modules/mediastream/RTCIceProtocol.idl: Added.
Modules/mediastream/RTCIceTcpCandidateType.h: Added.
Modules/mediastream/RTCIceTcpCandidateType.idl: Added.
Modules/mediastream/RTCStatsReport.h:
Modules/mediastream/RTCStatsReport.idl:
Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::iceCandidateState):
(WebCore::fillRTCIceCandidateStats):

Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::toRTCIceComponent):
(WebCore::toRTCIceProtocol):
(WebCore::toRTCIceTcpCandidateType):
(WebCore::toRTCIceCandidateType):
(WebCore::parseIceCandidateSDP):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionForIceCandidates::sendCandidates):

LayoutTests:

fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt:

3:09 AM Changeset in webkit [266697] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[GStreamer] Convert custom GObject subclasses to WEBKIT_DEFINE_TYPE
https://bugs.webkit.org/show_bug.cgi?id=204673

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-09-07
Reviewed by Philippe Normand.

Instead of using G_DEFINE_TYPE macro use rather WEBKIT_DEFINE_TYPE
since it handles private structures.

No new tests since no functional changes.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

Renamed the private structure to match with class name so it can
be autogeneterated by the macro.
(_WebKitWebAudioSrcPrivate::_WebKitWebAudioSrcPrivate): add
constructure.
(_WebKitWebAudioSrcPrivate::~_WebKitWebAudioSrcPrivate): add
destructor.
(webkit_web_audio_src_class_init): remove duplicated
initialization.
(webKitWebAudioSrcConstructed): add constructed vmethod to
initalize some private members.
(webKitWebAudioSrcSetProperty): renamed private structure.
(webKitWebAudioSrcGetProperty): ditto.
(webKitWebAudioSrcAllocateBuffersAndRenderAudio): ditto.
(webKitWebAudioSrcLoop): ditto.

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkConstructed): add constructed vmethod to initalize
some private members.
(webkit_video_sink_class_init): remove duplicated initialization.

platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init): remove duplicated
initialization.

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkit_media_common_encryption_decrypt_class_init): remove
duplicated initialization.
(constructed): add constructed vmethod to initalize some private
members.

platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp:

(webkit_media_thunder_decrypt_class_init): remove duplicated
initialization.

2:54 AM Changeset in webkit [266696] by svillar@igalia.com

7 edits in trunk

[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
https://bugs.webkit.org/show_bug.cgi?id=212264

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

web-platform-tests/css/css-flexbox/percentage-heights-003-expected.txt: There were 3 subtests

marked as failures. All of them work fine now.

Source/WebCore:

Implement https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 which modified
the way percentages were resolved in flexible items with indefinite sizes. From now on we can pretend that
they're really definite.

This allows us to mark 3 tests which were testing percentages in flex items as correct.

Based on Blink's crrev.com/1247184 by <cbiesinger@chromium.org>

This is a reland of r263399 which got reverted due to bug 214655. This same patch was previously relanded in
r262124 which got reverted due to the bug fixed in r263389.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Do only check flex container main size
definiteness when computing the main size for percentage resolution, no need to check flex basis at all.

LayoutTests:

css3/flexbox/definite-main-size-expected.txt: Updated expectation.
css3/flexbox/definite-main-size.html: Updated comment.

2:20 AM Changeset in webkit [266695] by svillar@igalia.com

7 edits
2 deletes in trunk

[css-flexbox] min-height: auto not applied to nested flexboxes.
https://bugs.webkit.org/show_bug.cgi?id=210089

Reviewed by Daniel Bates.

Source/WebCore:

Nested flexboxes with column direction were not computing correctly min-size:auto because
we were explicitly preventing them from doing so in the code. Implemented the required bits to
make it work correctly and thus removed the retriction. The idea is to set an indefinite override
containing block size so that percentages would be resolved to auto as spec'ed. The code which
decides whether to apply min-size:auto was refactored in the shouldApplyMinSizeAutoForChild() method.

In order not to cause regressions some other two additional changes were also implemented. First we
had to adjust childHasIntrinsicMainAxisSize() so that it also takes into account the cases where
shouldApplyMinSizeAutoForChild() is true and return true. Secondly we had to add an additional case
to mainAxisLengthIsDefinite() so that it returns false for column flows where the flexBasis is intrinsic.

Inspired by Blink's crrev.com/c/1641510, crrev.com/c/1269995 & crrev.com/c/1786297 by <cbiesinger@chromium.org>

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::shouldApplyMinSizeAutoForChild const): Refactored from
RenderFlexibleBox::adjustChildSizeForMinAndMax.
(WebCore::RenderFlexibleBox::mainAxisLengthIsDefinite const): Additional case for column flows.
(WebCore::RenderFlexibleBox::layoutFlexItems): Reset m_hasDefiniteHeight to Unknown after calling
constructFlexItem() because the latter might set now an override containing block height which basically
potentially makes any cached size value incorrect.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax): Directly call shouldApplyMinSizeAutoForChild().
(WebCore::RenderFlexibleBox::constructFlexItem): Set an indefinite override containing block size for
children with percentage sizes so that they're resolved as auto.
(WebCore::RenderFlexibleBox::childHasIntrinsicMainAxisSize const): Return true for those cases where the
main axis length is indefinite and also when shouldApplyMinSizeAutoForChild().

rendering/RenderFlexibleBox.h:

LayoutTests:

Apart from enabling some tests we're removing a test which is now invalid as it was added
under the condition that we were not matching the specs wrt percentage height computation in
column flexboxes.

TestExpectations: Removed two test cases that are passing now.
fast/flexbox/nested-column-intrinsic-min-disabled-expected.html: Removed.
fast/flexbox/nested-column-intrinsic-min-disabled.html: Removed.
platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Updated.
platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Ditto.

1:28 AM Changeset in webkit [266694] by jh718.park@samsung.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove the build warning below since r266567.
warning: parameter ‘hint’ set but not used [-Wunused-but-set-parameter]

runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):

Sep 6, 2020:

11:19 PM Changeset in webkit [266693] by mmaxfield@apple.com

8 edits in trunk/Source

[iOS] attachmentActionFont() Needs to use kCTFontSymbolicTrait: @(kCTFontTraitTightLeading | kCTFontTraitEmphasized) to get the short emphasized footnote font
https://bugs.webkit.org/show_bug.cgi?id=215707
<rdar://problem/63930892>

Reviewed by Darin Adler.

Source/WebCore:

This is the correct way to get the short emphasized footnote font.

rendering/RenderThemeIOS.mm:

(WebCore::attachmentActionFont):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h: Add an optimzation for platforms which support it.

Source/WTF:

wtf/PlatformHave.h:

11:11 PM Changeset in webkit [266692] by mmaxfield@apple.com

7 edits in trunk/Source/WebCore

[Cocoa] Prepare for migrating to CTFontHasTable() once it's faster than CTFontCopyAvailableTables()
https://bugs.webkit.org/show_bug.cgi?id=215688

Reviewed by Darin Adler.

Source/WebCore:

We can directly ask Core Text for the information we're looking for.

No new tests because there is no behavior change.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontType::FontType):

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::fontHasVerticalGlyphs):

platform/graphics/opentype/OpenTypeCG.cpp:

(WebCore::OpenType::fontHasMathTable):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

8:11 PM Writing testharness Tests edited by Fujii Hironori

(diff)

7:34 PM Writing Layout Tests for DumpRenderTree edited by Fujii Hironori

Use js-test.js instread of js-test-pre.js (diff)

7:22 PM Changeset in webkit [266691] by Wenson Hsieh

19 edits in trunk/Source/WebCore

Make WebCore::WritingMode an 8-bit enum class
https://bugs.webkit.org/show_bug.cgi?id=216233

Reviewed by Darin Adler.

Narrow WebCore::WritingMode to an 8-bit enum class; no change in behavior.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WritingMode const):

css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):

dom/Element.cpp:

(WebCore::toScrollAlignmentForInlineDirection):
(WebCore::toScrollAlignmentForBlockDirection):

page/FrameView.cpp:

(WebCore::paginationModeForRenderStyle):

platform/text/WritingMode.h:
rendering/GridBaselineAlignment.cpp:

(WebCore::BaselineGroup::isOppositeBlockFlow const):
(WebCore::BaselineGroup::isOrthogonalBlockFlow const):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
(WebCore::RenderBlock::borderTop const):
(WebCore::RenderBlock::borderLeft const):
(WebCore::RenderBlock::borderBottom const):
(WebCore::RenderBlock::borderRight const):

rendering/RenderBox.cpp:

(WebCore::shouldFlipBeforeAfterMargins):
(WebCore::RenderBox::visualOverflowRectForPropagation const):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):

rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::orientation const):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isLeftToRightFlow const):
(WebCore::RenderFlexibleBox::transformedWritingMode const):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore const):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter const):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore const):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter const):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild const):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop const):
(WebCore::RenderTableCell::paddingBottom const):
(WebCore::RenderTableCell::paddingLeft const):
(WebCore::RenderTableCell::paddingRight const):

rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):

rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::borderBeforeInWritingMode):
(WebCore::borderAndPaddingBeforeInWritingMode):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::borderBefore const):
(WebCore::RenderStyle::borderAfter const):
(WebCore::RenderStyle::borderBeforeWidth const):
(WebCore::RenderStyle::borderAfterWidth const):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::initialWritingMode):
(WebCore::RenderStyle::setWritingMode):

style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

style/StyleBuilderState.cpp:

(WebCore::Style::BuilderState::adjustStyleForInterCharacterRuby):

7:07 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:57 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

6:33 PM Changeset in webkit [266690] by mmaxfield@apple.com

7 edits in trunk/Source

CTFontGetPhysicalSymbolicTraits() is faster than CTFontCopyPhysicalFont()/CTFontGetSymbolicTraits()
https://bugs.webkit.org/show_bug.cgi?id=215685

Reviewed by Darin Adler.

Source/WebCore:

Instead of making the two calls, we can make a single call that has the same effect.

No new tests because there is no behavior change.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::computeNecessarySynthesis):
(WebCore::FontCache::systemFallbackForCharacters):

platform/graphics/cocoa/FontCacheCoreText.h:
platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:

(WebCore::FontFamilySpecificationCoreText::fontRanges const):

Source/WTF:

wtf/PlatformHave.h:

5:59 PM Changeset in webkit [266689] by Wenson Hsieh

3 edits in trunk/Source/WebCore

[MotionMark - Multiply] Web process spends ~1% of total samples in PropertyCascade::resolveDirectionAndWritingMode
https://bugs.webkit.org/show_bug.cgi?id=216223

Reviewed by Darin Adler.

A few subtests in MotionMark (Leaves, Focus, Design, and especially Multiply) spend large amounts of time in
style resolution (Document::resolveStyle) due to constant style changes across many elements during every
frame. In Multiply, ~3-4% of the time underneath Document::resolveStyle is spent resolving direction and
writing modes inside PropertyCascade::resolveDirectionAndWritingMode (i.e., ~2.3 million invocations). This
helper function is responsible for computing the text direction and CSS writing mode that is used to resolve
direction-aware CSS properties (which are enumerated in CSSProperty::isDirectionAwareProperty). Resolving the
direction and writing mode involves iterating over all of the matched CSS properties (m_matchResult) in the
property cascade in search of CSS properties for writing and direction, which can be relatively expensive when
there are lots of properties in the cascade.

However, if there are no direction-aware CSS properties in the cascade, this work can actually be elided; to
achieve this, we can store the inherited Direction in m_direction, and then lazily resolve it if needed.

I measured this locally to yield a little under ~1% in the Multiply subtest in MotionMark. Otherwise, there is
no change in behavior; see below for more details.

style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::set):

If we encounter a direction-aware CSS property, then use direction() to ensure that the direction and writing
mode are resolved.

(WebCore::Style::PropertyCascade::direction const):

Make this getter call resolveDirectionAndWritingMode if needed.

style/PropertyCascade.h:

Add a new bool member to keep track of whether or not the CSS direction has not yet been resolved. Note that
since this member variable fits within the padding after Direction m_direction;, this class is still the same
size.

(WebCore::Style::PropertyCascade::direction const): Deleted.

5:52 PM Changeset in webkit [266688] by mmaxfield@apple.com

11 edits
1 add in trunk

Make GlyphBufferAdvance and GlyphBufferOrigin more robust
https://bugs.webkit.org/show_bug.cgi?id=215143

Reviewed by Zalan Bujtas.

Source/WebCore:

GlyphBuffer contains vectors of advances and origins, which are conceptually
FloatSizes and FloatPoints. However, we need to pass these arrays into CTFontShapeGlyphs()
or CTFontTransformGlyphsWithLanguage(), which expects these vectors to use platform types.
Rather than converting in/out of platform types around the call site, we can simply use
the platform types throughout. Indeed, that's what we're doing today.

However, the mechanism we use today to make this platform-independent is to make a struct
which inherits from the platform types. Then, we static_cast the array of the struct to
an array of the base type. This is brittle, because it relies on the assumption that the
struct doesn't have any members added to it, which would change the stride of the array
and feed garbage into the shaping function.

Instead, a better design is to typedef the native type, and have all interactions with the
types go through standalone functions which deal with the native type. That way, we can't
accidentally change the size of the array elements.

No new tests because there is no behavior change.

Headers.cmake:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText const):
(WebCore::FontCascade::layoutComplexText const):
(WebCore::FontCascade::drawGlyphBuffer const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::GlyphToPathTranslator::extents):
(WebCore::GlyphToPathTranslator::advance):

platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::add):
(WebCore::GlyphBuffer::makeHole):
(WebCore::GlyphBuffer::expandLastAdvance):
(WebCore::GlyphBuffer::flatten):
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance): Deleted.
(WebCore::GlyphBufferAdvance::operator FloatSize): Deleted.
(WebCore::GlyphBufferAdvance::setWidth): Deleted.
(WebCore::GlyphBufferAdvance::setHeight): Deleted.
(WebCore::GlyphBufferAdvance::width const): Deleted.
(WebCore::GlyphBufferAdvance::height const): Deleted.
(WebCore::GlyphBufferAdvance::encode const): Deleted.
(WebCore::GlyphBufferAdvance::decode): Deleted.
(WebCore::GlyphBufferOrigin::GlyphBufferOrigin): Deleted.
(WebCore::GlyphBufferOrigin::operator FloatPoint): Deleted.
(WebCore::GlyphBufferOrigin::setX): Deleted.
(WebCore::GlyphBufferOrigin::setY): Deleted.
(WebCore::GlyphBufferOrigin::x const): Deleted.
(WebCore::GlyphBufferOrigin::y const): Deleted.
(WebCore::GlyphBufferOrigin::encode const): Deleted.
(WebCore::GlyphBufferOrigin::decode): Deleted.
(WebCore::toFloatSize): Deleted.

platform/graphics/GlyphBufferMembers.h: Added.

(WebCore::createGlyphBufferAdvance):
(WebCore::floatSizeFromGlyphBufferAdvance):
(WebCore::setGlyphBufferAdvanceWidth):
(WebCore::setGlyphBufferAdvanceHeight):
(WebCore::glyphBufferAdvanceWidth):
(WebCore::glyphBufferAdvanceHeight):
(WebCore::createGlyphBufferOrigin):
(WebCore::floatPointFromGlyphBufferOrigin):
(WebCore::setGlyphBufferOriginX):
(WebCore::setGlyphBufferOriginY):
(WebCore::glyphBufferOriginX):
(WebCore::glyphBufferOriginY):

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::computeBounds):

Tools:

TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:

(TestWebKitAPI::TEST_F):

5:20 PM Changeset in webkit [266687] by weinig@apple.com

8 edits in trunk

[WebIDL] Add mode to preprocess-idls.pl to validate fast regex based scanner with the normal IDL parser
https://bugs.webkit.org/show_bug.cgi?id=216231

Reviewed by Darin Adler.

Source/WebCore:

To aid tracking down mistakes in the fast regex based scanner in preprocess-idls.pl, this
adds a validation mode to the script which checks the results against what the normal, much
slower, IDL parser gets. In building it, it caught that we were not creating a dependency on
RTCRtpCodingParameters.idl for dictionaries that derived from it because it was missing from
DerivedSources.make/CMakeLists.txt, which would have manifested in confusing build errors
in some cases.

CMakeLists.txt:
DerivedSources.make:
bindings/scripts/generate-bindings-all.pl:

Add missing RTCRtpCodingParameters.idl and update invocation of preprocess-idls.pl to
pass in idlAttributesFile, which the parser needs (it is not read when not validating).

bindings/scripts/test/SupplementalDependencies.dep:

Updated to include missing dictionary dependencies.

bindings/scripts/preprocess-idls.pl:

(GeneratePartialInterface):
(processIDL):
(getPartialNamesFromIDL):
(getIncludedInterfacesFromIDL):
(isCallbackInterfaceFromIDL):
(isMixinInterfaceFromIDL):
(containsIterableInterfaceFromIDL):
(containsInterfaceOrCallbackInterfaceFromIDL):
(containsInterfaceWithConstantsFromIDL):
(getInterfaceExtendedAttributesFromIDL):
(getUndefinedBaseDictionariesFromIDL):
(shouldExposeInterface):
(getFileContents): Deleted.
(interfaceIsIterable): Deleted.
(containsInterfaceFromIDL): Deleted.
(interfaceHasConstantAttribute): Deleted.
(updateDictionaryDependencies): Deleted.

Allow enabling a validation mode via the $validateAgainstParser variable which parses each IDL with the normal IDL parser and compares results.
Updates a bunch of naming to be more clear about which variables contain file names vs. file paths.
Renames functions to use more consistent naming.
Fixes bug in dictionary dependency analysis that silently ignored dependencies that weren't in the file list.

Tools:

Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
Update for rename from idlFilesList to idlFileNamesList and to pass the idlAttributesFile argument.

5:00 PM Changeset in webkit [266686] by mmaxfield@apple.com

16 edits in trunk/Source/WebCore

Remove all non-web-exposed uses of ENABLE(VARIATION_FONTS)
https://bugs.webkit.org/show_bug.cgi?id=216211

Reviewed by Darin Adler.

This is the first step toward enabling variation fonts on all ports.
This patch compiles internal data structures on all ports, keeping care to not make
any web-exposed changes. It also stops consulting with ENABLE(VARIATION_FONTS) on
Cocoa platforms, since the flag is enabled on all Cocoa platforms and we've been
shipping it for years.

No new tests because there is no behavior change.

css/CSSFontVariationValue.cpp:
css/CSSFontVariationValue.h:
css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::isFontFeatureValue const):
(WebCore::CSSValue::isFontVariationValue const):

platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator== const):
(WebCore::FontDescriptionKey::computeHash const):

platform/graphics/FontCascadeDescription.cpp:
platform/graphics/FontDescription.h:

(WebCore::FontDescription::setFeatureSettings):
(WebCore::FontDescription::setVariationSettings):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::encode const):
(WebCore::FontDescription::decode):

platform/graphics/FontTaggedSettings.cpp:

(WebCore::operator<<):

platform/graphics/FontTaggedSettings.h:

(WebCore::FontVariationSettings::isEmpty const): Deleted.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::denormalizeVariationWidth):
(WebCore::normalizeVariationWidth):
(WebCore::preparePlatformFont):
(WebCore::extractVariationBounds):
(WebCore::variationCapabilitiesForFontDescriptor):

platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setFontVariationSettings):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::fontVariationSettings const):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertFontVariationSettings):

style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyInheritFontFeatureSettings):
(WebCore::Style::BuilderCustom::applyInheritFontVariationSettings):

4:42 PM Changeset in webkit [266685] by Alan Bujtas

17 edits
1 move in trunk/Source/WebCore

[LFC][IFC] Rename Display::LineBox to Display::Line
https://bugs.webkit.org/show_bug.cgi?id=216232

Reviewed by Sam Weinig.

Display::LineBox represent a line and not to be confused with Layout::LineBox which represents a collection of inline boxes.

WebCore.xcodeproj/project.pbxproj:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):

layout/displaytree/DisplayInlineContent.h:

(WebCore::Display::InlineContent::lineForRun const):
(WebCore::Display::InlineContent::lineBoxForRun const): Deleted.

layout/displaytree/DisplayLine.h: Renamed from Source/WebCore/layout/displaytree/DisplayLineBox.h.

(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::left const):
(WebCore::Display::Line::right const):
(WebCore::Display::Line::top const):
(WebCore::Display::Line::bottom const):
(WebCore::Display::Line::width const):
(WebCore::Display::Line::height const):
(WebCore::Display::Line::baseline const):
(WebCore::Display::Line::Line):
(WebCore::Display::Line::moveVertically):

layout/displaytree/DisplayPainter.cpp:

(WebCore::Display::paintInlineContent):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::createDisplayBoxesForLineContent):

layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

layout/inlineformatting/InlineFormattingState.h:

(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::constructInlineBoxes):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::collectOverflow):
(WebCore::LayoutIntegration::LineLayout::paint):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):

layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):

layout/tableformatting/TableFormattingContextGeometry.cpp:

(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):

rendering/line/LineLayoutTraversalDisplayRunPath.h:

(WebCore::LineLayoutTraversal::DisplayRunPath::baseline const):
(WebCore::LineLayoutTraversal::DisplayRunPath::line const):
(WebCore::LineLayoutTraversal::DisplayRunPath::lineBox const): Deleted.

4:09 PM Changeset in webkit [266684] by Chris Dumez

11 edits in trunk

ConvolverNode incorrectly outputs silence because m_reverb is null
https://bugs.webkit.org/show_bug.cgi?id=216230

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Unreviewed, rebaseline tests that are now passing.

web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:

Source/WebCore:

ConvolverNode relies on m_reverb to to audio processing. m_reverb would get initialized
when calling ConvolverNode::setBuffer(). However, setting the buffer would cause
ConvolverNode::checkNumberOfChannelsForInput(), which could cause unitialize() and then
initialize() to get called. The issue was that unitialize() would null out m_reverb
and nothing would re-initialize it.

No new tests, rebaselined existing tests.

Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::initialize): Deleted.
(WebCore::ConvolverNode::uninitialize): Deleted.

Modules/webaudio/ConvolverNode.h:

LayoutTests:

Unreviewed, unskip tests that should hopefully not be flaky anymore, not that they
are passing.

TestExpectations:

3:20 PM Changeset in webkit [266683] by mmaxfield@apple.com

18 edits in trunk

Letter-spacing should disable ligatures
https://bugs.webkit.org/show_bug.cgi?id=176215
<rdar://problem/17044265>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

This test is sensitive the order of the CSSPropertyID enum values.

web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Apparently this

test is sensitive to the ordering of CSSPropertyID enum values in CSSPropertyNames.h.
I filed https://bugs.webkit.org/show_bug.cgi?id=216170 about this.

Source/WebCore:

The CSS Text spec[1] says:
"When the effective spacing between two characters is not zero (due to either justification
or a non-zero value of letter-spacing), user agents should not apply optional ligatures."

The CSS Fonts spec[2] describes exactly how this is supposed to work:
"Step 11. Feature settings determined by properties other than font-variant or
font-feature-settings are applied. For example, setting a non-default value for the
letter-spacing property disables optional ligatures."

Disabling ligatures requires modifying font features, which means that the information about
whether we should disable them or not needs to be inside the FontDescription. This patch adds
a new bit, m_shouldDisableLigaturesForSpacing, to FontDescription. preparePlatformFont()
reads this bit and disables ligatures appropriately.

There's a bit of complexity here because the letter-spacing value itself lies inside the
RenderStyle, but the derived bit lies inside the FontDescriptor, which is one reason why
this patch migrates letter-spacing to use custom codegen functions. There's also a bit of
complexity about dependencies which is explained in a comment in
maybeUpdateFontForLetterSpacing().

[1] https://drafts.csswg.org/css-text-3/#letter-spacing-property
[2] https://drafts.csswg.org/css-fonts-4/#feature-variation-precedence

Test: imported/w3c/web-platform-tests/css/css-fonts/font-feature-resolution-001.html

css/CSSProperties.json: letter-spacing has to be high-priority because it affects font

selection, but it has to be processed after zoom because its <length> value is sensitive to
zoom. This adds a new keyword CSSProperties.json: sink-property which can let a property
sink to the bottom of its priority bucket.

css/makeprop.pl:

(addProperty):
(sortByDescendingPriorityAndName):

platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

platform/graphics/FontDescription.h:

(WebCore::FontDescription::shouldDisableLigaturesForSpacing const):
(WebCore::FontDescription::setShouldDisableLigaturesForSpacing):
(WebCore::FontDescription::operator== const):
(WebCore::FontDescription::encode const):
(WebCore::FontDescription::decode):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont): We can get into a situation where "liga" and "clig" don't
match, which means whichever one is later clobbers whichever one is earlier when applied to
AAT fonts. We need to make sure these values match so we don't get surprising results.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setLetterSpacing):
(WebCore::RenderStyle::setLetterSpacingWithoutUpdatingFontDescription):

rendering/style/RenderStyle.h:
style/StyleBuilderCustom.h:

(WebCore::Style::applyLetterSpacing):
(WebCore::Style::BuilderCustom::applyInheritLetterSpacing):
(WebCore::Style::BuilderCustom::applyInitialLetterSpacing):
(WebCore::Style::maybeUpdateFontForLetterSpacing):
(WebCore::Style::BuilderCustom::applyValueLetterSpacing):
(WebCore::Style::BuilderCustom::applyValueWebkitLocale):
(WebCore::Style::BuilderCustom::applyInitialFontFamily):
(WebCore::Style::BuilderCustom::applyInheritFontFamily):
(WebCore::Style::BuilderCustom::applyValueFontFamily):
(WebCore::Style::BuilderCustom::applyInitialFontSize):
(WebCore::Style::BuilderCustom::applyInheritFontSize):
(WebCore::Style::BuilderCustom::applyValueFontSize):

style/StyleBuilderState.h:

Tools:

Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONCSSPropertiesChecker.check_codegen_properties):

LayoutTests:

imported/w3c/web-platform-tests/css/css-fonts/font-feature-resolution-001.html passes now.

TestExpectations:
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt:

Apparently this test is sensitive to the ordering of CSSPropertyID enum values in CSSPropertyNames.h.
I filed https://bugs.webkit.org/show_bug.cgi?id=216170 about this.

platform/mac-wk1/editing/mac/attributed-string/letter-spacing-expected.txt: Updated.
platform/mac-mojave-wk1/editing/mac/attributed-string/letter-spacing-expected.txt: Updated

2:32 PM Changeset in webkit [266682] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC][IFC] LineBox should contain all inline boxes
https://bugs.webkit.org/show_bug.cgi?id=216221

Reviewed by Antti Koivisto.

In this patch we decouple the line box and the line.

Previously the LineBox was pretty much representing the line.
It was responsible for both placing the inline boxes and sizing the line and position itself based on line-height/half leading.
Now the LineBox is only responsible for placing the inline boxes and sizing itself, it has no position geometry anymore neither
does it compute the line height.
The line size is computed later using the combination of line-height property/LineBox height/FontMetrics::lineSpacing/half leading.
This geometry is preserved in Display::LineBox (this needs to be renamed to Display::Line).

LineBuilder places the runs on the line after each other (at this point they only have horizontal geometry).
LineBreaker tells when to stop.
We start constructing inline boxes for the runs (root inline box etc) and place them inside an LineBox. This is when horizontal and vertical alignment happen.
We use the fully sized LineBox to compute the line geometry. Note that the line's geometry does not necessarily match the LineBox width/height (see below).
We construct a Display::LineBox for the line and Display::Runs for the runs inside the inline boxes.

LineBox:

fully contains all the inline boxes, both horizontally and vertically.
has only width and height geometry
height is not constrained by the line-height property
does not have the concept of overflow.

Line:

contains the LineBox, but the LineBox can overflow the line, both horizontally and vertically.
has position relative to the root block container.

Simple case.
<div>font went crazy with line spacing</div>

_ line

| ^{|

| | line spacing |

| v |}

| -------------------------------------------LineBox | -------------------------------------------

^{| |}

| line box height | |

----v--------------------------------------| alignment baseline

| | ^{| | line spacing | |

|v_| scrollable overflow}

When glyphs in subsequent lines overflow:
<div style="line-height: 5px; font-size: 20px;">line box overflows the line</div>

_ LineBox

| ^{|

| | line box height |

| | |}

-Line

| | ^{| | |

| | | line height | | |}

-v--------------------

| | |

| alignment baseline

| | |
|v_|

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::createDisplayBoxesForLineContent):

12:10 PM Changeset in webkit [266681] by Darin Adler

26 edits in trunk/Source

TextCodec refinements
https://bugs.webkit.org/show_bug.cgi?id=216219

Reviewed by Sam Weinig.

Source/JavaScriptCore:

parser/Lexer.h:

(JSC::Lexer<UChar>::isWhiteSpace): Use byteOrderMark constant.

Source/WebCore:

dom/TextDecoder.cpp:

(WebCore::TextDecoder::bytesNeededForFullBOMIgnoreCheck const): Deleted.
(WebCore::TextDecoder::isBeginningOfIncompleteBOM const): Deleted.
(WebCore::TextDecoder::ignoreBOMIfNecessary): Deleted.
(WebCore::TextDecoder::decode): Call stripByteOrderMark on the TextCodec
to tell it to ignore the BOM, once when creating the codec, and also after
each non-streaming invocation. Removed the rest of the BOM handling.

dom/TextDecoder.h: Removed WaitForMoreBOMBytes, ignoreBOMIfNecessary,

bytesNeededForFullBOMIgnoreCheck, isBeginningOfIncompleteBOM, m_buffer,
m_bomIgnoredIfNecessary, and made m_options const.

platform/text/TextCodec.h: Added a virtual stripByteOrderMark function

to be used before decoding; does nothing by default. Changed the encode
function to be a const member function to help implementers remember to
not have it save any state, unlike the decode function which should.

platform/text/TextCodecCJK.cpp: Moved the TextCodecCJK::Encoding

enumeration in here.
(WebCore::jis0208DecodeIndex): Use a named type and use std::size
instead of WTF_ARRAY_LENGTH.
(WebCore::codePointJIS0212): Ditto.
(WebCore::iso2022JPEncode): Made this a non-member function and moved
the encoding state in here since each call to encode is separate and
we don't want to leave any state behind in the TextCodec between calls.
(WebCore::eucKREncodingIndex): Use a refernece instead of a pointer
and std::size instead of WTF_ARRAY_LENGTH.
(WebCore::big5DecodeIndex): Ditto.
(WebCore::TextCodecCJK::encode const): Made const.

platform/text/TextCodecCJK.h: Marked the class final, moved

the enumeration values for Encoding, ISO2022JPEncoderState, and
m_iso2022JPEncoderState out of the class definition. Made encode const.

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::encode const): Made const.

platform/text/TextCodecICU.h: Marked the class final, and

rearranged the class members to match other TextCodec classes,
with register functions before the constructor and destructor.
Made encode const.

platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::encode const): Made const.

platform/text/TextCodecLatin1.h: Removed a stray blank line

and made encode const.

platform/text/TextCodecReplacement.cpp:

(WebCore::TextCodecReplacement::encode const): Added.

platform/text/TextCodecReplacement.h: Marked the class final,

changed it to no longer derive from TextCodecUTF8, and added
an encode function.

platform/text/TextCodecSingleByte.cpp: Moved the

TextCodecSingleByte::Encoding enumeration in here and changed
from Iso to ISO. Added SingleByteDecodeTable type and
moved TextCodecSingleByte::EncodeTable in here and renamed
it to SingleByteEncodeTable so it's not a class member any more.
Marked all the decode tables static since we don't get internal
linkage from just marking them constexpr, while moving to use
the SingleByteDecodeTable type.
(WebCore::tableForEncoding): Use SingleByteDecodeTable and
SingleByteEncodeTable type names. Use std::count to count the
replacement characters instead of writing our own loop.
Use std::size(decodeTable) instead of defining a tableSize.
Update for ISO name change. Use RELEASE_ASSERT_NOT_REACHED so
we don't have to write a dead code return statement.
(WebCore::tableForDecoding): Use SingleByteDecideTable type
for return value. Update for ISO name change. Use
RELEASE_ASSERT_NOT_REACHED so we don't have to write a dead
code return statement. Also make this constexpr since it's
just selecting a global based on an enumeration value.
(WebCore::encode): Made this a non-member function since it
does not need access to TextCodec members. This helps us keep
implementation details out of the header.
(WebCore::decode): Ditto.
(WebCore::TextCodecSingleByte::encode const): Made this const
and updated to call the non-member function.
(WebCore::TextCodecSingleByte::decode): Ditto.
(WebCore::TextCodecSingleByte::registerCodecs): Update for
the ISO name change.

platform/text/TextCodecSingleByte.h: Marked the class

final, and moved the enumeration values for Encoding, EncodeTable,
and the encode and decode functions that take table arguments
all out of the class definition. Made encode const.

platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode): Added logic to drop the first
byte order mark after m_shouldStripByteOrderMark is set to true.
Changed code to call through rather than recursively calling self
in the case of an unpaired lead surrogate, removing the need to
put the processBytesShared lambda into a Function. Renamed the
processBytesShared lambda to processCodeUnit.
(WebCore::TextCodecUTF16::encode const): Made const.

platform/text/TextCodecUTF16.h: Marked the class final, added

a stripByteOrderMark member function and a m_shouldStripByteOrderMark
data member, and made encode const.

platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::handlePartialSequence): Added logic to
drop the first byte order mark after m_shouldStripByteOrderMark is
set to true, making sure to keep it out of the hot ASCII decode loop.
(WebCore::TextCodecUTF8::decode): Ditto. Also added code to make sure
the partial sequence is cleared out as part of a flush even when
stopOnError is true.
(WebCore::TextCodecUTF8::encodeUTF8): Renamed this so it can be
a static member function, so it can be called by TextCodecReplacement.
(WebCore::TextCodecUTF8::encode const): Made this const and have it
call encodeUTF8.

platform/text/TextCodecUTF8.h: Marked the class final, added

a stripByteOrderMark member function and a m_shouldStripByteOrderMark
data member, added static member function encodeUTF8, and made the
encode function const.

platform/text/TextCodecUserDefined.cpp:

(WebCore::TextCodecUserDefined::encode const): Made const.

platform/text/TextCodecUserDefined.h: Marked the class final and

made encode const.

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString): Use byteOrderMark.

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::switchToUTF16): Ditto.
(WebCore::nativeEndianUTF16Encoding): Ditto.

Source/WTF:

wtf/unicode/CharacterNames.h: Use constexpr instead of just const.

Added byteOrderMark, synonym for zeroWidthNoBreakSpace.

8:59 AM Changeset in webkit [266680] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC][IFC] Move Line handing to LineBuilder
https://bugs.webkit.org/show_bug.cgi?id=216200

Reviewed by Antti Koivisto.

LineBuilder owns Line now.
LineBuilder can build line for both layout and intrinsic width computation (now these are two distinct code paths).
LineBuilder also constructs the LineBox when needed (This was previously in InlineFormattingContext::lineLayout).

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):
(WebCore::Layout::InlineFormattingContext::constraintsForLine): Deleted.

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::computedTextIndent const): Deleted.

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::formattingContext const):
(WebCore::Layout::LineBox::root const):
(WebCore::Layout::LineBox::layoutState const):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::contentLogicalWidth const):
(WebCore::Layout::LineBox::formattingContext const): Deleted.
(WebCore::Layout::LineBox::root const): Deleted.
(WebCore::Layout::LineBox::layoutState const): Deleted.

layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::constraintsForLine):
(WebCore::Layout::LineBuilder::commitFloats):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
(WebCore::Layout::LineBuilder::commitPartialContent):
(WebCore::Layout::LineBuilder::rebuildLine):
(WebCore::Layout::LineBuilder::layoutState const):

layout/inlineformatting/InlineLineBuilder.h:

Sep 5, 2020:

9:56 PM Changeset in webkit [266679] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, suppress exception checking after unwrapForOldFunctions
https://bugs.webkit.org/show_bug.cgi?id=216193

runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

7:49 PM Changeset in webkit [266678] by weinig@apple.com

74 edits
1 copy
2 adds
1 delete in trunk/Source/WebCore

[WebIDL] Add support for interface mixins
https://bugs.webkit.org/show_bug.cgi?id=216217

Reviewed by Darin Adler.

Implement support for WebIDL interface mixins, which are interface fragments
that can be included into other interfaces (using an 'includes' statement),
but do not create new types themselves.

Prior to this, we have been emulating the behavior by allowing any interface
to be included in another interface, and marking some interfaces with the
[LegacyNoInterfaceObject] extended attribute. This change codifies that with
in the spec approved way.

Updates IDL parser to parse mixin interfaces (and fixes the parsing of callback interfaces to be a bit more strict while I was there).
Updates IDL pre-processor to avoid creating global variables and IsoSubspaces for mixins.
Updates IDL code generator to only support including mixin interfaces during supplemental inclusion.
Updates IDL files to use interface mixin where appropriately specified.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
CMakeLists.txt:
DerivedSources-output.xcfilelist:
DerivedSources.make:
dom/DeviceOrientationOrMotionEvent.idl: Removed.

Remove DeviceOrientationOrMotionEvent.idl and corresponding generated files, inlining
it into DeviceMotionEvent.idl and DeviceOrientationEvent.idl as specified. This is
needed as mixin interfaces do not support static operations or attributes.

bindings/scripts/CodeGenerator.pm:

(IsValidSupplementalInterface):
(IsValidSupplementalDictionary):
(ProcessSupplementalDependencies):
(GetInterfaceExtendedAttributesFromName):
Update IDL code generator to only support including mixin interfaces during
supplemental inclusion. Also removes some left of remnents of exception interface
support.

bindings/scripts/IDLParser.pm:

(parseCallbackRestOrInterface):
(parseCallbackInterface):
(parseCallbackInterfaceMembers):
(parseCallbackInterfaceMember):
(parseMixin):
(parseMixinMembers):
(parseMixinMember):
(parseNamespace):
(parsePartialInterfaceMember):
(parseAttributeOrOperationForStringifierOrStatic):
Update IDL parser to parse mixin interfaces and fix the parsing of callback
interfaces to match the spec by restricting its members to constants and
regular functions.

bindings/scripts/preprocess-idls.pl:

(isMixinInterfaceFromIDL):
(containsInterfaceFromIDL):
(getInterfaceExtendedAttributesFromIDL):
(containsInterfaceOrExceptionFromIDL): Deleted.
Ensure mixin interfaces don't get exposed on any global objects and
remove some left of remnents of exception interface support.

bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp: Added.
bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.h: Added.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestIncludes.idl:
bindings/scripts/test/TestLegacyNoInterfaceObject.idl: Added.
bindings/scripts/test/TestOperationBase.idl:

Update bindings tests to use mixins for includes. Add new dedicated
[LegacyNoInterfaceObject] since it was no longer being tested.

Modules/fetch/FetchBody.idl:
Modules/mediasource/VideoPlaybackQuality.idl:
Modules/speech/SpeechSynthesis.idl:
Modules/speech/SpeechSynthesisVoice.idl:
Modules/streams/ReadableStreamSink.idl:
accessibility/AccessibilityRole.idl:
accessibility/AriaAttributes.idl:
animation/Animatable.idl:
css/ElementCSSInlineStyle.idl:
css/StyleMedia.idl:
dom/ChildNode.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document.idl:
dom/DocumentAndElementEventHandlers.idl:
dom/DocumentOrShadowRoot.idl:
dom/EventListener.idl:
dom/GlobalEventHandlers.idl:
dom/NavigatorMaxTouchPoints.idl:
dom/NonDocumentTypeChildNode.idl:
dom/NonElementParentNode.idl:
dom/ParentNode.idl:
dom/Slotable.idl:
html/HTMLHyperlinkElementUtils.idl:
html/HTMLOrForeignElement.idl:
html/canvas/CanvasCompositing.idl:
html/canvas/CanvasDrawImage.idl:
html/canvas/CanvasDrawPath.idl:
html/canvas/CanvasFillStrokeStyles.idl:
html/canvas/CanvasFilters.idl:
html/canvas/CanvasGradient.idl:
html/canvas/CanvasImageData.idl:
html/canvas/CanvasImageSmoothing.idl:
html/canvas/CanvasPath.idl:
html/canvas/CanvasPathDrawingStyles.idl:
html/canvas/CanvasRect.idl:
html/canvas/CanvasShadowStyles.idl:
html/canvas/CanvasState.idl:
html/canvas/CanvasText.idl:
html/canvas/CanvasTextDrawingStyles.idl:
html/canvas/CanvasTransform.idl:
html/canvas/CanvasUserInterface.idl:
html/canvas/WebGLRenderingContextBase.idl:
page/GlobalCrypto.idl:
page/GlobalPerformance.idl:
page/Navigator.idl:
page/NavigatorID.idl:
page/NavigatorLanguage.idl:
page/NavigatorOnLine.idl:
page/NavigatorPlugins.idl:
page/NavigatorServiceWorker.idl:
page/NavigatorShare.idl:
page/WindowEventHandlers.idl:
page/WindowOrWorkerGlobalScope.idl:
svg/SVGFilterPrimitiveStandardAttributes.idl:
svg/SVGFitToViewBox.idl:
svg/SVGTests.idl:
svg/SVGURIReference.idl:
svg/SVGZoomAndPan.idl:
workers/AbstractWorker.idl:
xml/XPathEvaluator.idl:
xml/XPathNSResolver.idl:

Update IDLs.

6:36 PM Changeset in webkit [266677] by Wenson Hsieh

10 edits in trunk/Source

[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190

Reviewed by Darin Adler.

Source/WebCore:

In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContents due to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time via MonotonicTime::now().

We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable on Page. See below for more details, as well as
the WebKit2 ChangeLog.

page/ChromeClient.h:

(WebCore::ChromeClient::timestampForPaintFrequencyTracking const):

Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.

page/Page.cpp:

(WebCore::Page::updateRendering):

Update m_lastRenderingUpdateTimestamp.

page/Page.h:

(WebCore::Page::lastRenderingUpdateTimestamp const):

rendering/PaintFrequencyTracker.h:

Drive-by cleanup: narrow the PaintFrequency enum to bool width.

(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.

(WebCore::RenderLayer::simulateFrequentPaint):

rendering/RenderLayer.h:

Source/WebKit:

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):

In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).

Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions in SinglePaintFrequencyTracking::end(). As such, we
stick with MonotonicTime::now() in WebKit1.

WebProcess/WebCoreSupport/WebChromeClient.h:

5:44 PM Changeset in webkit [266676] by weinig@apple.com

2 edits in trunk/Source/WebCore

Fix formatting of LegacyOverrideBuiltIns
https://bugs.webkit.org/show_bug.cgi?id=216218

Reviewed by Darin Adler.

Neglected to fix this bit of feedback in a previous change. Makes
enum class LegacyOverrideBuiltIns a bit more readable.

bindings/js/JSDOMAbstractOperations.h:

5:26 PM Changeset in webkit [266675] by Oriol Brufau

6 edits
2 adds in trunk

[css-grid] Use min-content size for intrinsic maximums resolution
https://bugs.webkit.org/show_bug.cgi?id=216142

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT test.

web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001-expected.txt: Added.
web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html: Added.
web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:

Source/WebCore:

By mistake the specification used to say that, for items spanning
multiple tracks, the growth limits of the tracks with an intrinsic max
track sizing function should grow to accommodate the minimum
contribution of the item.

But this was a mistake, because an intrinsic max track sizing function
can only be min-content or max-content. So instead of distributing the
minimum contribution, it should be the min-content contribution.

The spec has been fixed and there is a CSSWG resolution in
https://github.com/w3c/csswg-drafts/issues/4790

This patch fixes the problem by reverting r207290. The change is likely
web compatible, since it only affects a rare edge case with 'minmax()'
where the min sizing function is 'auto' or a fixed value smaller than
the min-content contribution, the max sizing function is 'min-content',
and an item whose minimum contribution is forced to be different than
the min-content contribution, and spans multiple tracks.

This is a port of https://crrev.com/803871 from Chromium.

Tests: fast/css-grid-layout/grid-intrinsic-maximums.html

imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::itemSizeForTrackSizeComputationPhase const):

LayoutTests:

Update test expectations. Some are wrong due to bug 216144.

fast/css-grid-layout/grid-intrinsic-maximums-expected.html:

5:11 PM Changeset in webkit [266674] by Oriol Brufau

60 edits
1 delete in trunk

[css-logical] Ship flow-relative shorthand and offset properties
https://bugs.webkit.org/show_bug.cgi?id=216178

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update test expectations and remove instances of

web-platform-tests/css/css-cascade/parsing/all-valid-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007-expected.txt:
web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016-expected.txt:
web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-007-expected.txt:
web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-012-expected.txt:
web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-014-expected.txt:
web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-016-expected.txt:
web-platform-tests/css/css-logical/animation-001-expected.txt:
web-platform-tests/css/css-logical/animation-002-expected.txt:
web-platform-tests/css/css-logical/getComputedStyle-listing-expected.txt:
web-platform-tests/css/css-logical/inheritance-expected.txt:
web-platform-tests/css/css-logical/logical-box-border-color.html:
web-platform-tests/css/css-logical/logical-box-border-shorthands.html:
web-platform-tests/css/css-logical/logical-box-border-style.html:
web-platform-tests/css/css-logical/logical-box-border-width.html:
web-platform-tests/css/css-logical/logical-box-inset.html:
web-platform-tests/css/css-logical/logical-box-margin.html:
web-platform-tests/css/css-logical/logical-box-padding.html:
web-platform-tests/css/css-logical/parsing/border-block-color-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-color-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-style-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-style-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-width-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-block-width-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-color-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-color-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-style-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-style-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-width-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/border-inline-width-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-block-inline-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-block-inline-shorthand-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-block-inline-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-shorthand-expected.txt:
web-platform-tests/css/css-logical/parsing/inset-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/margin-block-inline-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/margin-block-inline-shorthand-expected.txt:
web-platform-tests/css/css-logical/parsing/margin-block-inline-valid-expected.txt:
web-platform-tests/css/css-logical/parsing/padding-block-inline-computed-expected.txt:
web-platform-tests/css/css-logical/parsing/padding-block-inline-shorthand-expected.txt:
web-platform-tests/css/css-logical/parsing/padding-block-inline-valid-expected.txt:
web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001-expected.txt:
web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001-expected.txt:
web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001-expected.txt:
web-platform-tests/quirks/unitless-length/excluded-properties-001.html:
web-platform-tests/quirks/unitless-length/excluded-properties-003.html:

Source/WebCore:

This patch ships the logical properties that were already implemented behind a flag.
Specifically:

border-block, border-block-color, border-block-style, border-block-width
border-inline, border-inline-color, border-inline-style, border-inline-width
inset-block-start, inset-block-end, inset-inline-start, inset-inline-end
inset, inset-block, inset-inline
margin-block, margin-inline
padding-block, padding-inline

Tests: imported/w3c/web-platform-tests/css/css-cascade/parsing/all-valid.html

imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-001.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-002.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-003.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-004.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-005.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-007.html
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-016.html
imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-007.html
imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-012.html
imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-014.html
imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-016.html
imported/w3c/web-platform-tests/css/css-logical/animation-001.html
imported/w3c/web-platform-tests/css/css-logical/animation-002.html
imported/w3c/web-platform-tests/css/css-logical/getComputedStyle-listing.html
imported/w3c/web-platform-tests/css/css-logical/inheritance.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-border-color.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-border-shorthands.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-border-style.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-border-width.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-inset.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-margin.html
imported/w3c/web-platform-tests/css/css-logical/logical-box-padding.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-color-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-color-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-style-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-style-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-width-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-block-width-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-color-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-color-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-style-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-style-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-width-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/border-inline-width-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-block-inline-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-block-inline-shorthand.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-block-inline-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-shorthand.html
imported/w3c/web-platform-tests/css/css-logical/parsing/inset-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/margin-block-inline-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/margin-block-inline-shorthand.html
imported/w3c/web-platform-tests/css/css-logical/parsing/margin-block-inline-valid.html
imported/w3c/web-platform-tests/css/css-logical/parsing/padding-block-inline-computed.html
imported/w3c/web-platform-tests/css/css-logical/parsing/padding-block-inline-shorthand.html
imported/w3c/web-platform-tests/css/css-logical/parsing/padding-block-inline-valid.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-001.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-001.html
imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-001.html
imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001.html
imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-003.html

css/CSSProperties.json: Enable logical properties by default.
css/makeprop.pl: Avoid compile warning when generating isEnabledCSSProperty if there is no property behind flag.

LayoutTests:

css-properties-behind-flags.html used to check that CSS properties
disabled behind a flag were effectible disabled.
But there is no longer any CSS property disabled behind a flag, so I'm
just removing it.

platform/mac/TestExpectations:
webexposed/css-properties-behind-flags-expected.txt: Removed.
webexposed/css-properties-behind-flags.html: Removed.

3:27 PM Changeset in webkit [266673] by mmaxfield@apple.com

6 edits
1 delete in trunk/Source/WebCore

[iOS Family] Remove the concept of custom fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=215690

Reviewed by Sam Weinig.

They're no longer necessary for iOS, and macOS doesn't
even have the concept of custom fallback fonts, so we
can just remove the entire concept.

platform/graphics/FontCache.h:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

platform/graphics/cocoa/FontCacheCoreText.h:
platform/graphics/ios/FontCacheIOS.mm:

(WebCore::requiresCustomFallbackFont): Deleted.
(WebCore::FontCache::getCustomFallbackFont): Deleted.

2:34 PM Changeset in webkit [266672] by mmaxfield@apple.com

15 edits
2 adds in trunk/Source

[Cocoa] USE(PLATFORM_SYSTEM_FALLBACK_LIST) is true on all Cocoa platforms, so there's no need to consult it in Cocoa-specific files
https://bugs.webkit.org/show_bug.cgi?id=215684

Reviewed by Darin Adler.

Source/WebCore:

Removes dead code.

No new tests because there is no behavior change.

Configurations/WebCore.xcconfig:
PlatformFTW.cmake:
PlatformWin.cmake:
page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::platformReleaseMemory):

platform/FreeType.cmake:
platform/graphics/FontCascadeDescription.cpp:

(WebCore::FontCascadeDescription::effectiveFamilyCount const): Deleted.
(WebCore::FontCascadeDescription::effectiveFamilyAt const): Deleted.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::invalidateFontCache):

platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::FontCascadeDescription::effectiveFamilyAt const):

platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:

(WebCore::FontFamilySpecificationCoreText::fontRanges const):

platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
platform/graphics/harfbuzz/FontDescriptionHarfBuzz.cpp: Added. Moved port-specific

implementations into port-specific files.
(WebCore::FontCascadeDescription::effectiveFamilyCount const):
(WebCore::FontCascadeDescription::effectiveFamilyAt const):

platform/graphics/win/FontDescriptionWin.cpp: Added. Moved port-specific

implementations into port-specific files.
(WebCore::FontCascadeDescription::effectiveFamilyCount const):
(WebCore::FontCascadeDescription::effectiveFamilyAt const):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

wtf/PlatformUse.h:

1:54 PM Changeset in webkit [266671] by achristensen@apple.com

4 edits in trunk

XML documents in iframes should not inherit encoding from parent frame
https://bugs.webkit.org/show_bug.cgi?id=216216

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/utf-32-from-win1252-expected.txt:

Source/WebCore:

This seems to match the behavior of Chrome and Firefox.
Covered by newly passing web platform tests, which other browsers already pass.

loader/DocumentWriter.cpp:

(WebCore::canReferToParentFrameEncoding):

1:10 PM Changeset in webkit [266670] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: AXI: Audit: obtuse error strings
https://bugs.webkit.org/show_bug.cgi?id=201080
<rdar://problem/54648118>

Patch by Greg Doolittle <gr3g@apple.com> on 2020-09-05
Reviewed by Devin Rousso.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager):

1:06 PM Changeset in webkit [266669] by Devin Rousso

20 edits
11 adds in trunk

Web Inspector: allow DOM breakpoints to be configured
https://bugs.webkit.org/show_bug.cgi?id=215795

Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/protocol/DOMDebugger.json:

Add an options parameter to DOMDebugger.setDOMBreakpoint to allow configuration.

Source/WebCore:

Tests: inspector/dom-debugger/attribute-modified-style.html

inspector/dom-debugger/dom-breakpoints.html
inspector/dom-debugger/dom-breakpoint-attribute-modified.html
inspector/dom-debugger/dom-breakpoint-node-removed-ancestor.html
inspector/dom-debugger/dom-breakpoint-node-removed-direct.html
inspector/dom-debugger/dom-breakpoint-subtree-modified-add.html
inspector/dom-debugger/dom-breakpoint-subtree-modified-remove.html

inspector/agents/page/PageDOMDebuggerAgent.h:
inspector/agents/page/PageDOMDebuggerAgent.cpp:

(WebCore::PageDOMDebuggerAgent::disable):
(WebCore::PageDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::PageDOMDebuggerAgent::removeDOMBreakpoint):
(WebCore::PageDOMDebuggerAgent::frameDocumentUpdated):
(WebCore::calculateDistance): Added.
(WebCore::PageDOMDebuggerAgent::willInsertDOMNode):
(WebCore::PageDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::PageDOMDebuggerAgent::didRemoveDOMNode):
(WebCore::PageDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::PageDOMDebuggerAgent::willInvalidateStyleAttr):
(WebCore::PageDOMDebuggerAgent::buildPauseDataForDOMBreakpoint): Added.
(WebCore::domTypeForName): Deleted.
(WebCore::domTypeName): Deleted.
(WebCore::PageDOMDebuggerAgent::didInsertDOMNode): Deleted.
(WebCore::PageDOMDebuggerAgent::descriptionForDOMEvent): Deleted.
(WebCore::PageDOMDebuggerAgent::updateSubtreeBreakpoints): Deleted.
(WebCore::PageDOMDebuggerAgent::hasBreakpoint): Deleted.
Replace the bitmask with separate HashMap for each type of DOM breakpoint. Instead of
propagating the SubtreeModified bit to the entire subtree when new nodes are added (which
means there's an entry in the HashMap for every descendant) and removing them all when
that node is removed, only keep nodes in each HashMap if it directly has a DOM breakpoint.
Walk up the ancestor chain when nodes are added/removed to determine if there is a nearby
breakpoint to pause. When a node is removed, remove any existing DOM breakpoint if it's
owner is part of the removed subtree.

inspector/agents/worker/WorkerDOMDebuggerAgent.h:
inspector/agents/worker/WorkerDOMDebuggerAgent.cpp:

(WebCore::WorkerDOMDebuggerAgent::setDOMBreakpoint):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):

Source/WebInspectorUI:

UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype._setChildNodes):
Dispatch events for each new child node added and each existing child node removed so that
any listeners can also know when new nodes are added via a full children payload update.

UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WI.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._detachDOMBreakpointsForFrame): Added.
(WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
(WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
(WI.DOMDebuggerManager.prototype._setDOMBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeDOMBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointDOMNodeWillChange): Added.
(WI.DOMDebuggerManager.prototype._handleDOMBreakpointDOMNodeDidChange): Added.
(WI.DOMDebuggerManager.prototype._childFrameWasRemoved):
(WI.DOMDebuggerManager.prototype._mainResourceDidChange):
(WI.DOMDebuggerManager.prototype._nodeInserted):
(WI.DOMDebuggerManager.prototype._nodeRemoved):
(WI.DOMDebuggerManager.prototype._detachDOMBreakpoint): Deleted.
(WI.DOMDebuggerManager.prototype._detachBreakpointsForFrame): Deleted.
(WI.DOMDebuggerManager.prototype._updateDOMBreakpoint): Deleted.
Recursively walk any added node's subtree to resolve and set any matching DOM breakpoints.
Iterate all existing DOM breakpoints to see if the owner node is part of the subtree of any
removed nodes and remove ot if so.

UserInterface/Models/DOMBreakpoint.js:

(WI.DOMBreakpoint):
(WI.DOMBreakpoint.displayNameForType):
(WI.DOMBreakpoint.fromJSON):
(WI.DOMBreakpoint.prototype.get editable): Added.
(WI.DOMBreakpoint.prototype.get domNode): Added.
(WI.DOMBreakpoint.prototype.set domNode): Added.
(WI.DOMBreakpoint.prototype.get domNodeIdentifier): Deleted.
(WI.DOMBreakpoint.prototype.set domNodeIdentifier): Deleted.

UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype._domTreeElementAdded):
(WI.DOMTreeContentView.prototype._domBreakpointAddedOrRemoved):
(WI.DOMTreeContentView.prototype._handleDOMBreakpointDisabledStateChanged):
(WI.DOMTreeContentView.prototype._handleDOMBreakpointDOMNodeWillChange): Added.
(WI.DOMTreeContentView.prototype._handleDOMBreakpointDOMNodeDidChange): Added.
(WI.DOMTreeContentView.prototype._updateBreakpointStatus):
(WI.DOMTreeContentView.prototype._restoreBreakpointsAfterUpdate):
(WI.DOMTreeContentView.prototype._handleDOMBreakpointDOMNodeChanged): Deleted.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._updatePauseReasonSection):
(WI.SourcesNavigationSidebarPanel.prototype._handleDOMBreakpointDOMNodeWillChange): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleDOMBreakpointDOMNodeDidChange): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleDOMBreakpointDOMNodeChanged): Deleted.
Use a WI.DOMNode instead of an identifier instead of fetching the node for the identifier
each time and checking if is valid.

LayoutTests:

inspector/debugger/resources/breakpoint-options-utilities.js:

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):

inspector/dom-debugger/resources/dom-breakpoint-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.DOMBreakpoint.teardown):
(TestPage.registerInitializer.InspectorTest.DOMBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.DOMBreakpoint.addBreakpoint):
(TestPage.registerInitializer.InspectorTest.DOMBreakpoint.awaitQuerySelector):

inspector/dom-debugger/attribute-modified-style.html:
inspector/dom-debugger/attribute-modified-style-expected.txt:
inspector/dom-debugger/dom-breakpoints.html:
inspector/dom-debugger/dom-breakpoints-expected.txt:
inspector/dom-debugger/dom-breakpoint-attribute-modified.html: Added.
inspector/dom-debugger/dom-breakpoint-attribute-modified-expected.txt: Added.
inspector/dom-debugger/dom-breakpoint-node-removed-ancestor.html: Added.
inspector/dom-debugger/dom-breakpoint-node-removed-ancestor-expected.txt: Added.
inspector/dom-debugger/dom-breakpoint-node-removed-direct.html: Added.
inspector/dom-debugger/dom-breakpoint-node-removed-direct-expected.txt: Added.
inspector/dom-debugger/dom-breakpoint-subtree-modified-add.html: Added.
inspector/dom-debugger/dom-breakpoint-subtree-modified-remove-expected.txt: Added.
inspector/dom-debugger/dom-breakpoint-subtree-modified-remove.html: Added.
inspector/dom-debugger/dom-breakpoint-subtree-modified-add-expected.txt: Added.

12:48 PM Changeset in webkit [266668] by achristensen@apple.com

12 edits
1 delete in trunk

TextDecoder should properly handle streams
https://bugs.webkit.org/show_bug.cgi?id=216202

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
web-platform-tests/encoding/streams/decode-non-utf8.any.js:
web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:
web-platform-tests/encoding/streams/decode-split-character.any-expected.txt:
web-platform-tests/encoding/streams/decode-split-character.any.worker-expected.txt:
web-platform-tests/encoding/streams/realms.window-expected.txt:
web-platform-tests/encoding/textdecoder-fatal-streaming-expected.txt: Removed.
web-platform-tests/encoding/textdecoder-fatal-streaming.any-expected.txt:
web-platform-tests/encoding/textdecoder-fatal-streaming.any.worker-expected.txt:

Source/WebCore:

A TextCodec keeps state when it decodes part of valid input, such as the first byte of a multibyte sequence.
TextEncoding::decode makes a new TextCodec and throws away that state.
In order to properly handle streaming, we need to keep the TextCodec and call TextCodec::decode directly.

Covered by newly passing web platform tests. I also added a test that failed in my first implementation attempt
but passes now in WebKit as well as Chromium. Firefox hasn't implemented TextDecoderStream yet, but this test will
hopefully help them not make the same mistake I did.

dom/TextDecoder.cpp:

(WebCore::TextDecoder::decode):
(WebCore::codeUnitByteSize): Deleted.

dom/TextDecoder.h:

11:21 AM Changeset in webkit [266667] by mmaxfield@apple.com

9 edits in trunk/Source

[Cocoa] CTFontIsSystemUIFont() is faster than CTFontDescriptorIsSystemUIFont()/CTFontCopyFontDescriptor()
https://bugs.webkit.org/show_bug.cgi?id=215687

Reviewed by Darin Adler.

Source/WebCore:

Instead of making the two calls, we can make a single call that has the same effect.

No new tests because there is no behavior change.

platform/graphics/FontPlatformData.h:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontIsSystemFont):

platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::primaryFontIsSystemFont const):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::isSystemFont):

Source/WebCore/PAL:

pal/spi/cocoa/CoreTextSPI.h:

Source/WTF:

wtf/PlatformHave.h:

11:07 AM Changeset in webkit [266666] by mmaxfield@apple.com

4 edits in trunk/Source

[Cocoa] Migrate off SPI in Font::platformWidthForGlyph()
https://bugs.webkit.org/show_bug.cgi?id=215670

Reviewed by Zalan Bujtas.

Source/WebCore:

All the tests pass, and the microbenchmark attached to <rdar://problem/21026016> says it isn't a regression.

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformWidthForGlyph const):

Source/WTF:

wtf/PlatformUse.h:

10:57 AM Changeset in webkit [266665] by mmaxfield@apple.com

5 edits
2 adds in trunk

[macOS] Don't apply synthetic bold or italics to emoji
https://bugs.webkit.org/show_bug.cgi?id=215686

Reviewed by Darin Adler.

Source/WebCore:

Italicized emoji are one of the most hideous things I've ever seen.

This unifies the behavior between macOS and iOS.

Test: fast/text/emoji-synthesis.html

WebCore.xcodeproj/xcshareddata/xcschemes/WebCore.xcscheme:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::computeNecessarySynthesis):

LayoutTests:

fast/text/emoji-synthesis-expected.html: Added.
fast/text/emoji-synthesis.html: Added.
platform/win/TestExpectations:
platform/mac/fast/text/fallback-traits-fixup-expected.txt:

10:55 AM Changeset in webkit [266664] by Simon Fraser

3 edits in trunk/Source/WebCore

REGRESSION (r260571): Scrolling on weather.com in Safari causes the gradient background to flicker (fixed backgrounds)
https://bugs.webkit.org/show_bug.cgi?id=216192
<rdar://problem/68192010>

Reviewed by Tim Horton.

If a page has slow-scrolling reasons, like background-attachment:fixed on a non-root element,
then we should never update layer positions on the scrolling thread, since this results
in scroll position being out of sync with the painted background position.

page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::canUpdateLayersOnScrollingThread const):
(WebCore::ThreadedScrollingTree::waitForRenderingUpdateCompletionOrTimeout):
(WebCore::ThreadedScrollingTree::delayedRenderingUpdateDetectionTimerFired):
(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):

page/scrolling/ThreadedScrollingTree.h:

10:51 AM Changeset in webkit [266663] by mmaxfield@apple.com

8 edits
1 delete in trunk/Source/WebCore

[Cocoa] Unify implementation of custom font name aliases between all Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=215689

Reviewed by Darin Adler.

The existing code is duplicated almost verbatim. There's no point in having two copies of the same thing.

No new tests because there is no behavior change.

PlatformMac.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontWithFamilySpecialCase):
(WebCore::fontWithFamily):

platform/graphics/cocoa/FontCacheCoreText.h:
platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::FontCascadeDescription::effectiveFamilyCount const):
(WebCore::FontCascadeDescription::effectiveFamilyAt const):

platform/graphics/ios/FontCacheIOS.mm:

(WebCore::baseSystemFontDescriptor): Deleted.
(WebCore::systemFontModificationAttributes): Deleted.
(WebCore::systemFontDescriptor): Deleted.
(WebCore::platformFontWithFamilySpecialCase): Deleted.

platform/graphics/mac/FontCacheMac.mm: Removed.

10:14 AM Changeset in webkit [266662] by weinig@apple.com

189 edits
1 copy
7 moves
4 adds
5 deletes in trunk/Source

[WebIDL] Realign our IDL extended attribute names with those specified in WebIDL
https://bugs.webkit.org/show_bug.cgi?id=216194

Reviewed by Darin Adler.

Source/WebCore:

Over time, the WebIDL and HTML specifications have added / renamed extended attributes and we have
not stayed up to date. This updates the names everywhere and URLs in IDLAttributes.json.

[AllowShared] -> new, marked as unsupported
[HTMLConstructor] - > new, marked as unsupported
[LegacyLenientSetter] -> renamed from [LenientSetter], still unsupported
[LegacyLenientThis] -> renamed from [LenientThis]
[LegacyNamespace] -> new, marked as unsupported
[LegacyNoInterfaceObject] -> renamed from [NoInterfaceObject]
[LegacyNullToEmptyString] -> renamed from [TreatNullAs=EmptyString]
[LegacyOverrideBuiltIns] -> renamed from OverrideBuiltins
[LegacyTreatNonObjectAsNull] -> renamed from [TreatNonObjectAsNull], still unsupported
[LegacyUnforgeable] -> renamed from [Unforgeable]
[Serializable] -> new, marked as unsupported
[Transferable] -> new, marked as unsupported

Modules/applepay/ApplePayCancelEvent.idl:
Modules/applepay/ApplePayPaymentAuthorizedEvent.idl:
Modules/applepay/ApplePayPaymentMethodSelectedEvent.idl:
Modules/applepay/ApplePayShippingContactSelectedEvent.idl:
Modules/applepay/ApplePayShippingMethodSelectedEvent.idl:
Modules/applepay/ApplePayValidateMerchantEvent.idl:
Modules/fetch/FetchBody.idl:
Modules/mediacontrols/MediaControlsHost.idl:
Modules/mediasource/VideoPlaybackQuality.idl:
Modules/mediastream/RTCPeerConnection.idl:
Modules/plugins/QuickTimePluginReplacement.idl:
Modules/quota/StorageInfo.idl:
Modules/quota/StorageQuota.idl:
Modules/speech/SpeechSynthesis.idl:
Modules/speech/SpeechSynthesisVoice.idl:
Modules/streams/ReadableStreamSink.idl:
Modules/streams/ReadableStreamSource.idl:
Modules/webaudio/WebKitAudioBufferSourceNode.idl:
Modules/webaudio/WebKitAudioListener.idl:
Modules/webaudio/WebKitDynamicsCompressorNode.idl:
Modules/webaudio/WebKitOscillatorNode.idl:
Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb:
accessibility/AccessibilityRole.idl:
accessibility/AriaAttributes.idl:
animation/Animatable.idl:
bindings/IDLTypes.h:
bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::disableLegacyOverrideBuiltInsBehavior):
(WebCore::DOMWrapperWorld::shouldDisableLegacyOverrideBuiltInsBehavior const):
(WebCore::DOMWrapperWorld::disableOverrideBuiltinsBehavior): Deleted.
(WebCore::DOMWrapperWorld::shouldDisableOverrideBuiltinsBehavior const): Deleted.

bindings/js/JSDOMAbstractOperations.h:

(WebCore::isVisibleNamedProperty):
(WebCore::accessVisibleNamedProperty):

bindings/js/JSDOMConvertNullable.h:
bindings/js/JSDOMConvertStrings.h:

(WebCore::Converter<IDLTreatNullAsEmptyAdaptor<T>>::convert): Deleted.
(WebCore::JSConverter<IDLTreatNullAsEmptyAdaptor<T>>::convert): Deleted.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlot):
(GenerateGetOwnPropertySlotByIndex):
(GeneratePut):
(GeneratePutByIndex):
(GenerateIsLegacyUnforgeablePropertyName):
(GenerateDefineOwnProperty):
(GenerateDeletePropertyCommon):
(AttributeShouldBeOnInstance):
(OperationShouldBeOnInstance):
(IsAcceleratedDOMAttribute):
(GetJSCAttributesForAttribute):
(GenerateHeader):
(GenerateImplementation):
(GenerateAttributeGetterTrampolineDefinition):
(GenerateAttributeSetterTrampolineDefinition):
(IsAnnotatedType):
(GetAnnotatedIDLType):
(GenerateConstructorHelperMethods):
(NeedsConstructorProperty):
(IsLegacyUnforgeable):
(ComputeFunctionSpecial):
(GenerateIsUnforgeablePropertyName): Deleted.
(IsUnforgeable): Deleted.

bindings/scripts/IDLAttributes.json:
bindings/scripts/preprocess-idls.pl:
bindings/scripts/test/BindingTestGlobalConstructors.idl:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp: Added.
bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.h: Added.
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.h: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.h: Added.
bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp: Removed.
bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h: Removed.
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp: Removed.
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h: Removed.
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp: Removed.
bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h: Removed.
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp: Removed.
bindings/scripts/test/JS/JSTestOverrideBuiltins.h: Removed.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestIncludes.idl:
bindings/scripts/test/TestLegacyOverrideBuiltIns.idl: Added.
bindings/scripts/test/TestNamedSetterWithLegacyOverrideBuiltIns.idl: Added.
bindings/scripts/test/TestNamedSetterWithLegacyUnforgeableProperties.idl: Added.
bindings/scripts/test/TestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.idl: Added.
bindings/scripts/test/TestNamedSetterWithOverrideBuiltins.idl: Removed.
bindings/scripts/test/TestNamedSetterWithUnforgableProperties.idl: Removed.
bindings/scripts/test/TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.idl: Removed.
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestOperationBase.idl:
bindings/scripts/test/TestOverrideBuiltins.idl: Removed.
css/CSSStyleDeclaration.idl:
css/CSSUnknownRule.idl:
css/ElementCSSInlineStyle.idl:
css/MediaList.idl:
css/StyleMedia.idl:
dom/CharacterData.idl:
dom/ChildNode.idl:
dom/DOMImplementation.idl:
dom/DOMStringMap.idl:
dom/DeviceOrientationOrMotionEvent.idl:
dom/Document.idl:
dom/DocumentAndElementEventHandlers.idl:
dom/DocumentOrShadowRoot.idl:
dom/Element.idl:
dom/Event.idl:
dom/EventListener.idl:
dom/GlobalEventHandlers.idl:
dom/NavigatorMaxTouchPoints.idl:
dom/NonDocumentTypeChildNode.idl:
dom/NonElementParentNode.idl:
dom/ParentNode.idl:
dom/ShadowRoot.idl:
dom/Slotable.idl:
html/HTMLBodyElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLFontElement.idl:
html/HTMLFormElement.idl:
html/HTMLFrameElement.idl:
html/HTMLHyperlinkElementUtils.idl:
html/HTMLIFrameElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLObjectElement.idl:
html/HTMLOrForeignElement.idl:
html/HTMLOutputElement.idl:
html/HTMLTableCellElement.idl:
html/HTMLTableElement.idl:
html/HTMLTableRowElement.idl:
html/HTMLTextAreaElement.idl:
html/canvas/ANGLEInstancedArrays.idl:
html/canvas/CanvasCompositing.idl:
html/canvas/CanvasDrawImage.idl:
html/canvas/CanvasDrawPath.idl:
html/canvas/CanvasFillStrokeStyles.idl:
html/canvas/CanvasFilters.idl:
html/canvas/CanvasImageData.idl:
html/canvas/CanvasImageSmoothing.idl:
html/canvas/CanvasPath.idl:
html/canvas/CanvasPathDrawingStyles.idl:
html/canvas/CanvasRect.idl:
html/canvas/CanvasShadowStyles.idl:
html/canvas/CanvasState.idl:
html/canvas/CanvasText.idl:
html/canvas/CanvasTextDrawingStyles.idl:
html/canvas/CanvasTransform.idl:
html/canvas/CanvasUserInterface.idl:
html/canvas/EXTBlendMinMax.idl:
html/canvas/EXTColorBufferFloat.idl:
html/canvas/EXTColorBufferHalfFloat.idl:
html/canvas/EXTFragDepth.idl:
html/canvas/EXTShaderTextureLOD.idl:
html/canvas/EXTTextureFilterAnisotropic.idl:
html/canvas/EXTsRGB.idl:
html/canvas/OESElementIndexUint.idl:
html/canvas/OESStandardDerivatives.idl:
html/canvas/OESTextureFloat.idl:
html/canvas/OESTextureFloatLinear.idl:
html/canvas/OESTextureHalfFloat.idl:
html/canvas/OESTextureHalfFloatLinear.idl:
html/canvas/OESVertexArrayObject.idl:
html/canvas/WebGLColorBufferFloat.idl:
html/canvas/WebGLCompressedTextureASTC.idl:
html/canvas/WebGLCompressedTextureATC.idl:
html/canvas/WebGLCompressedTextureETC.idl:
html/canvas/WebGLCompressedTextureETC1.idl:
html/canvas/WebGLCompressedTexturePVRTC.idl:
html/canvas/WebGLCompressedTextureS3TC.idl:
html/canvas/WebGLCompressedTextureS3TCsRGB.idl:
html/canvas/WebGLDebugRendererInfo.idl:
html/canvas/WebGLDebugShaders.idl:
html/canvas/WebGLDepthTexture.idl:
html/canvas/WebGLDrawBuffers.idl:
html/canvas/WebGLLoseContext.idl:
html/canvas/WebGLRenderingContextBase.idl:
html/canvas/WebGLVertexArrayObjectOES.idl:
html/track/TextTrackCueGeneric.idl:
html/track/VTTRegionList.idl:
inspector/CommandLineAPIHost.idl:
inspector/InspectorFrontendHost.idl:
page/DOMWindow.idl:
page/GlobalCrypto.idl:
page/GlobalPerformance.idl:
page/Location.idl:
page/NavigatorID.idl:
page/NavigatorLanguage.idl:
page/NavigatorOnLine.idl:
page/NavigatorPlugins.idl:
page/NavigatorServiceWorker.idl:
page/NavigatorShare.idl:
page/RemoteDOMWindow.idl:
page/WindowEventHandlers.idl:
page/WindowOrWorkerGlobalScope.idl:
svg/SVGFilterPrimitiveStandardAttributes.idl:
svg/SVGFitToViewBox.idl:
svg/SVGTests.idl:
svg/SVGURIReference.idl:
svg/SVGZoomAndPan.idl:
testing/GCObservation.idl:
testing/InternalSettings.idl:
testing/Internals.idl:
testing/InternalsMapLike.idl:
testing/InternalsSetLike.idl:
testing/MallocStatistics.idl:
testing/MemoryInfo.idl:
testing/MockCDMFactory.idl:
testing/MockContentFilterSettings.idl:
testing/MockPageOverlay.idl:
testing/MockPaymentCoordinator.idl:
testing/ServiceWorkerInternals.idl:
testing/TypeConversions.idl:
testing/WebFakeXRDevice.idl:
testing/WebFakeXRInputController.idl:
testing/WebXRTest.idl:
workers/AbstractWorker.idl:
xml/XPathNSResolver.idl:

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::disableOverrideBuiltinsBehavior):
Update for new name WebCore::DOMWrapperWorld.

8:57 AM Changeset in webkit [266661] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

-Wreturn-type warning in BaseAudioContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=216215

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-09-05
Reviewed by Darin Adler.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

8:45 AM Changeset in webkit [266660] by Darin Adler

12 edits
3 deletes in trunk

CSS revert should serialize as "revert", not "Revert"
https://bugs.webkit.org/show_bug.cgi?id=216187

Reviewed by Anders Carlsson.

LayoutTests/imported/w3c:

web-platform-tests/css/css-color-adjust/parsing/color-scheme-valid-expected.txt: Expect

one additional test to pass instead of fail.

web-platform-tests/css/css-values/unset-value-storage-expected.txt: Expect pass instead of fail.
web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Ditto.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-values/unset-value-storage.html

imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html

css/CSSRevertValue.cpp:

(WebCore::CSSRevertValue::customCSSText const): Use lowercase "revert".

css/StyleProperties.cpp:

(WebCore::isCSSWideValueKeyword): Added. Replaces isInitialOrInherit.
(WebCore::StyleProperties::fontValue const): Use isCSSWideValueKeyword rather
than isInitialOrInherit.
(WebCore::StyleProperties::getLayeredShorthandValue const): Ditto. Also
rearranged thee function a bit and shortened some excessively wordy code.
(WebCore::StyleProperties::getShorthandValue const): Ditto.
(WebCore::StyleProperties::borderPropertyValue const): Ditto.
(WebCore::StyleProperties::asText const): Added code to properly handle the
case where both background-position/repeat-x and -y are the same CSS-wide
value keyword as well as cases involving "initial". The general case above
handles these properly, but background-position/repeat have their own code,
which needed to repeat some of the same logic.
(WebCore::StyleProperties::PropertyReference::cssText const): Use makeString
instead of StringBuilder.

dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged): Removed incorrect code that
detached the CSS object model style wrapper from the element when the style
attribute was removed. This was incorrect behavior; it should stay attached.
This fix happens to be tested by the same file as the "revert"/"Revert" fix
and I wanted the whole file to pass, not just one more test.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::addBlockStyle): Rewrote for simplicity, but
also so this works properly when inlineStyle is non-null but empty. This case
arises in one test now because of the change to StyledElement above.

LayoutTests:

editing/spelling/spelling-dots-position-expected.html: Remove some unneeded style text.

Caught my eye because it uses "background-position: initial".

fast/css/background-position-serialize-expected.txt: Updated for a progression.

We now correctly omit "background-position: initial initial; background-repeat: initial initial;".

platform/gtk/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Removed.
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Removed.
platform/wpe/imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block-expected.txt: Removed.

These were only needed because the failure strings depended on the exact set of attributes.
But the test passes now.

8:18 AM Changeset in webkit [266659] by Darin Adler

4 edits in trunk

Implement serialization of CSSPropertyGap
https://bugs.webkit.org/show_bug.cgi?id=216210

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/css/css-align/parsing/gap-valid-expected.txt: Expect pass.

Source/WebCore:

css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const): Use get2Values to serialize
the gap shorthand.

3:11 AM Changeset in webkit [266658] by rniwa@webkit.org

5 edits in trunk

Unreviewed, reverting r266614 and r266657.
https://bugs.webkit.org/show_bug.cgi?id=216213

Broke builds

Reverted changesets:

"Fix Internals::supportsVCPEncoder on BigSur"
https://bugs.webkit.org/show_bug.cgi?id=216174
https://trac.webkit.org/changeset/266614

"Fix the build after r266614"
https://bugs.webkit.org/show_bug.cgi?id=216174
https://trac.webkit.org/changeset/266657

Patch by Commit Queue <commit-queue@webkit.org> on 2020-09-05

12:20 AM Changeset in webkit [266657] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Fix the build after r266614
https://bugs.webkit.org/show_bug.cgi?id=216174

Unreviewed.

testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder): These parentheses really should be in
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h,
but I don't know the process for updating that third-party library. This is a
short-term build fix.

Sep 4, 2020:

11:43 PM Changeset in webkit [266656] by commit-queue@webkit.org

3 edits
2 adds in trunk

CSS :visited color taken on non-visited link when using CSS variables
https://bugs.webkit.org/show_bug.cgi?id=210525

Source/WebCore:

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-09-04
Reviewed by Darin Adler.

This patch fixes a bug in which :visited styles with variables (custom properties)
were being applied to non-visited links, as the builder link match state was
unconditionally changed from MatchVisited to MatchDefault when resolving said variables.
Now all link state mutations are limited to the smallest scope possible, meaning the
erroneous reset to MatchDefault is no longer necessary.

Test: fast/css/link-with-variable-styling.html

style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyCustomProperty): Limit m_linkState mutations with SetForScope to prevent said
mutations from leaking out and causing unintended side effects.

LayoutTests:

Add reftest ensuring :visited link styles don't override regular styles
for links that have not yet been visited.

Patch by Tyler Wilcock <Tyler Wilcock> on 2020-09-04
Reviewed by Darin Adler.

fast/css/link-with-variable-styling-expected.html: Added.
fast/css/link-with-variable-styling.html: Added.

9:53 PM Changeset in webkit [266655] by ysuzuki@apple.com

19 edits
2 adds in trunk

[JSC] Align legacy Intl constructor behavior to spec
https://bugs.webkit.org/show_bug.cgi?id=216193

Reviewed by Darin Adler.

JSTests:

stress/intl-datetimeformat.js:
stress/intl-legacy-constructors.js: Added.

(shouldBe):
(shouldThrow):
(testLegacyConstructor):

stress/intl-numberformat.js:

Source/JavaScriptCore:

Legacy Intl constructors (Intl.DateTimeFormat and Intl.NumberFormat) have special handling when it is called via Intl.DateTimeFormat() form.
This allowed legacy Intl constructors to be used with prototype-based inheritance without using class syntax. This legacy behavior is later specified
explicitly in the spec. So we should align our implementation to the spec's one.

When defining fallback formats, we need to put them into the property which is visible via Symbol("IntlLegacyConstructedSymbol").
Even if the provided thisValue is IntlDateTimeFormat* / IntlNumberFormat*, we should create another instance and put it to Symbol("IntlLegacyConstructedSymbol") field.

JavaScriptCore.xcodeproj/project.pbxproj:
builtins/BuiltinNames.cpp:

(JSC::BuiltinNames::BuiltinNames):

builtins/BuiltinNames.h:

(JSC::BuiltinNames::intlLegacyConstructedSymbol const):

runtime/CommonIdentifiers.h:
runtime/IntlDateTimeFormat.h:
runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::finishCreation):
(JSC::callIntlDateTimeFormat):

runtime/IntlDateTimeFormatInlines.h: Added.

(JSC::IntlDateTimeFormat::unwrapForOldFunctions):

runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):
(JSC::IntlDateTimeFormatPrototypeFuncFormatRange):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

runtime/IntlNumberFormat.h:
runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::finishCreation):
(JSC::callIntlNumberFormat):

runtime/IntlNumberFormatInlines.h:

(JSC::IntlNumberFormat::unwrapForOldFunctions):

runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncFormatToParts):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

runtime/IntlObject.cpp:

(JSC::createDateTimeFormatConstructor):
(JSC::createNumberFormatConstructor):

runtime/IntlObjectInlines.h:

(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):
(JSC::unwrapForLegacyIntlConstructor):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::dateTimeFormatConstructor):
(JSC::JSGlobalObject::dateTimeFormatPrototype):
(JSC::JSGlobalObject::numberFormatConstructor):
(JSC::JSGlobalObject::numberFormatPrototype):

9:07 PM Changeset in webkit [266654] by commit-queue@webkit.org

30 edits
2 copies
2 adds in trunk

Move PDF heads-up display to UI process on macOS
https://bugs.webkit.org/show_bug.cgi?id=215780
<rdar://problem/58715847>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-04
Reviewed by Tim Horton.

Source/WebKit:

This has many benefits including the one in the radar, testability, and moving WebKit-specific code from PDFKit to WebKit.

Now that the HUD is displayed in the UI process instead of in the web content, zooming in keeps the HUD the same size.
A 3d-transformed iframe with a PDF in it now shows the HUD in the place you can click on it, instead of in the transformed PDF.
Also, moving the mouse to the HUD within the first 3 seconds prevents it from hiding, which it does when the mouse leaves the HUD.
The rest of the behavior I think should be the same. Most users should not notice any difference.

Functionality covered by API tests, the first tests for PDF content interaction!

Scripts/webkit/messages.py:
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/mac/WKView.mm:

(-[WKView _createPDFHUD:rect:]):
(-[WKView _pdfHUD:changedLocation:]):
(-[WKView _removePDFHUD:]):
(-[WKView _removeAllPDFHUDs]):

UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView mouseMoved:]):
(-[WKWebView mouseDown:]):
(-[WKWebView mouseUp:]):
(-[WKWebView _createPDFHUD:rect:]):
(-[WKWebView _pdfHUD:changedLocation:]):
(-[WKWebView _removePDFHUD:]):
(-[WKWebView _removeAllPDFHUDs]):

UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView pdfHUDs]):

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::createPDFHUD):
(WebKit::WebViewImpl::updatePDFHUDLocation):
(WebKit::WebViewImpl::removePDFHUD):
(WebKit::WebViewImpl::removeAllPDFHUDs):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::processDidTerminate):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication): Deleted.
(WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication): Deleted.

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::createPDFHUD):
(WebKit::PageClientImpl::updatePDFHUDLocation):
(WebKit::PageClientImpl::removePDFHUD):
(WebKit::PageClientImpl::removeAllPDFHUDs):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
(WebKit::WebPageProxy::createPDFHUD):
(WebKit::WebPageProxy::removePDFHUD):
(WebKit::WebPageProxy::updatePDFHUDLocation):
(WebKit::WebPageProxy::pdfZoomIn):
(WebKit::WebPageProxy::pdfZoomOut):
(WebKit::WebPageProxy::pdfSaveToPDF):
(WebKit::WebPageProxy::pdfOpenWithPreview):

WebKit.xcodeproj/project.pbxproj:
WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate openWithNativeApplication]):
(-[WKPDFLayerControllerDelegate saveToPDF]):
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::~PDFPlugin):
(WebKit::PDFPlugin::frameForHUD const):
(WebKit::PDFPlugin::calculateSizes):
(WebKit::PDFPlugin::convertFromPDFViewToRootView const):
(WebKit::PDFPlugin::visibilityDidChange):
(WebKit::PDFPlugin::zoomIn):
(WebKit::PDFPlugin::zoomOut):
(WebKit::PDFPlugin::save):
(WebKit::PDFPlugin::openWithPreview):

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::zoomPDFIn):
(WebKit::WebPage::zoomPDFOut):
(WebKit::WebPage::savePDF):
(WebKit::WebPage::openPDFWithPreview):
(WebKit::WebPage::createPDFHUD):
(WebKit::WebPage::updatePDFHUDLocation):
(WebKit::WebPage::removePDFHUD):

Source/WTF:

wtf/PlatformHave.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

(pdfData):
(TEST):
(checkFrame):

TestWebKitAPI/cocoa/TestUIDelegate.h:
TestWebKitAPI/cocoa/TestUIDelegate.mm:

(-[TestUIDelegate _webView:saveDataToFile:suggestedFilename:mimeType:originatingURL:]):

8:52 PM Changeset in webkit [266653] by Karl Rackler

2 edits in trunk/LayoutTests

(REGRESSION (r266045): [ Big Sur ] 6 forms and 3 tables tests are a constant failure with approximately 1px difference)
rdar://68372418

Unreviewed test gardening.

platform/mac/TestExpectations:

8:41 PM Changeset in webkit [266652] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix build when using non-standard unified sources.

Modules/applepay/ApplePayPaymentMethod.h:

There was a missing include.

7:51 PM Changeset in webkit [266651] by achristensen@apple.com

6 edits in trunk

Align KOI8-U and ibm866 encodings with Chrome, Firefox, and the specification
https://bugs.webkit.org/show_bug.cgi?id=216184

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/single-byte-decoder-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

platform/text/TextCodecICU.cpp:
platform/text/TextCodecSingleByte.cpp:

(WebCore::tableForEncoding):
(WebCore::tableForDecoding):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

platform/text/TextCodecSingleByte.h:

6:05 PM Changeset in webkit [266650] by Chris Dumez

2 edits in trunk/Source/WebKit

handleXPCEndpointMessages does not check XPC object is an xpc_endpoint_t
https://bugs.webkit.org/show_bug.cgi?id=216196
<rdar://problem/68198293>

Reviewed by Per Arne Vollan.

Add a check to have sure the XPC object is indeed an xpc_endpoint_t before
using it.

WebProcess/cocoa/HandleXPCEndpointMessages.mm:

(WebKit::handleXPCEndpointMessages):

5:19 PM Changeset in webkit [266649] by weinig@apple.com

14 edits
3 moves
1 add
1 delete in trunk/Source/WebCore

[WebIDL] Adopt LegacyFactoryFunction extended attribute in lieu of NamedConstructor
https://bugs.webkit.org/show_bug.cgi?id=213316

Reviewed by Darin Adler.

Rename the following the extended attributes to more closely align with WebIDL:

NamedConstructor -> LegacyFactoryFunction
ConstructorCallWith -> LegacyFactoryFunctionCallWith
ConstructorEnabledBySetting -> LegacyFactoryFunctionEnabledBySetting
ConstructorMayThrowException -> LegacyFactoryFunctionMayThrowException

Note, ConstructorCallWith, ConstructorEnabledBySetting and ConstructorMayThrowException
were only used with NamedConstructors previously as normal constructors don't require
interface level extended attributes for these as the extended attribute can be directly
on the constructor itself. Ideally, we would do the same with LegacyFactoryFunction by
allowing extended attributes on the operator itself like:

[

...
LegacyFactoryFunction=[CallWith=Document] Audio(optional [AtomString] DOMString src)

]

but this requires changes to the IDLParser (which are straightforward) and creates a lot of
additional complexity inside the very hacky preprocess-idls.pl reproducing those parser changes.
I will leave that additional cleanup for a subsequent change.

html/HTMLAudioElement.idl:
html/HTMLImageElement.idl:
html/HTMLOptionElement.idl:
html/track/TextTrackCue.idl:

Update to use new names.

bindings/js/JSDOMLegacyFactoryFunction.h: Copied from bindings/js/JSDOMNamedConstructor.h.
bindings/js/JSDOMNamedConstructor.h: Removed.
WebCore.xcodeproj/project.pbxproj:

Update for rename of JSDOMNamedConstructor.h to JSDOMLegacyFactoryFunction.h

bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/IDLParser.pm:

(applyExtendedAttributeList):

bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttributes):
Update IDL processing to handle new names.

bindings/scripts/IDLAttributes.json:

Update extended attribute definitions for new names. Removed unused Constructor extended attribute.

bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp: Copied from bindings/scripts/test/JS/JSTestNamedConstructor.cpp.
bindings/scripts/test/JS/JSTestLegacyFactoryFunction.h: Copied from bindings/scripts/test/JS/JSTestNamedConstructor.h.
bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Removed.
bindings/scripts/test/JS/JSTestNamedConstructor.h: Removed.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestLegacyFactoryFunction.idl: Copied from bindings/scripts/test/TestNamedConstructor.idl.
bindings/scripts/test/TestNamedConstructor.idl: Removed.

Update tests for new names.

4:38 PM Changeset in webkit [266648] by Truitt Savell

2 edits in trunk/LayoutTests

fast/text/international/generic-font-family-language-traditional.html is passing, remove expectation.
rdar://60227623

Unreviewed test gardening.

platform/mac/TestExpectations:

4:34 PM Changeset in webkit [266647] by Truitt Savell

2 edits in trunk/LayoutTests

Correct typo in expectation for imported/blink/fast/text/international/text-shaping-arabic.html
rdar://41103260

Unreviewed test gardening.

platform/mac/TestExpectations:

4:32 PM Changeset in webkit [266646] by Truitt Savell

2 edits in trunk/LayoutTests

imported/blink/fast/text/international/text-shaping-arabic.html is Passing on Big Sur
rdar://41103260

Unreviewed test gardening.

platform/mac/TestExpectations:

4:30 PM Changeset in webkit [266645] by Chris Dumez

6 edits in trunk/Source

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

UIProcess/mac/DisplayLink.cpp:

(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::displayLinkCallback):
(WebKit::DisplayLink::hasObservers const): Deleted.

UIProcess/mac/DisplayLink.h:

4:19 PM Changeset in webkit [266644] by Chris Dumez

3 edits in trunk/LayoutTests

REGRESSION(266399?): [ iOS wk2 ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216124
<rdar://problem/68282113>

Unreviewed, rebaselined test on iOS.

platform/ios-wk2/TestExpectations:
platform/ios/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:

4:01 PM Changeset in webkit [266643] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION (r265603): ASSERTION FAILED: m_suspended in WebCore::SuspendableTimerBase::resume() seen with http/tests/security/no-indexeddb-from-sandbox.html
https://bugs.webkit.org/show_bug.cgi?id=215465

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

3:45 PM Changeset in webkit [266642] by Hector Lopez

2 edits in trunk/LayoutTests

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

3:33 PM Changeset in webkit [266641] by Alexey Shvayka

2 edits in trunk/Source/JavaScriptCore

Array.prototype.push should always perform Set? in strict mode
https://bugs.webkit.org/show_bug.cgi?id=216121

Unreviewed, address Darin's feedback on r266581.

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush): Remove unnecessary static_cast<uint64_t>.

3:29 PM Changeset in webkit [266640] by Jonathan Bedard

3 edits
1 copy in trunk/Tools

[webkitcorepy] Add mock Response object
https://bugs.webkit.org/show_bug.cgi?id=216150
<rdar://problem/68307522>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/mocks/init.py:
Scripts/libraries/webkitcorepy/webkitcorepy/mocks/requests.py: Added.

(Response): A response object similar to the one used by requests.

2:58 PM Changeset in webkit [266639] by Alan Coon

1 copy in tags/Safari-610.2.4

Tag Safari-610.2.4.

2:44 PM Changeset in webkit [266638] by Jonathan Bedard

5 edits in trunk/Tools

run-webkit-tests rebuilds ImageDiff every time
https://bugs.webkit.org/show_bug.cgi?id=204420
<rdar://problem/68232690>

Reviewed by Tim Horton.

Scripts/webkitpy/port/base.py:

(Port.check_image_diff): Check the version of ImageDiff we actually intend to use.
(Port): Use webkitcorepy's Memoize in _path_to_image_diff.
(Port._build_image_diff): Clear the memoized cache after building ImageDiff.

Scripts/webkitpy/port/darwin.py:

(DarwinPort): Memoize _path_to_image_diff.

Scripts/webkitpy/port/gtk.py:

(GtkPort): Memoize _path_to_image_diff.

Scripts/webkitpy/port/wpe.py:

(WPEPort): Memoize _path_to_image_diff.

2:21 PM Changeset in webkit [266637] by Karl Rackler

2 edits in trunk/LayoutTests

[ Big Sur ] imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framerate.html is a flaky failure/timeout)
rdar://68364365

Unreviewed test gardening.

platform/mac/TestExpectations:

1:45 PM Changeset in webkit [266636] by Diego Pino Garcia

2 edits in trunk/Tools

[GTK] Unreviewed test gardening. Mark several GTK API tests as flaky.

These tests were failing in EWS GTK-API tests bots, but I didn't
manage to reproduce the failures in tip of master.

TestWebKitAPI/glib/TestExpectations.json:

1:43 PM Changeset in webkit [266635] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Cocoa,EME] -outputObscuredDueToInsufficientExternalProtection KVO will set OutputObscured for all attached MediaKeySessions.
https://bugs.webkit.org/show_bug.cgi?id=216185

Reviewed by Eric Carlson.

When EME clients add licenses that have, for instance, different HDCP level requirements, the keyStatus for
each key in the Session (and indeed all attached MediaKeySessions) will be marked as OutputRestricted, since
it is impossible to tell from that KVO which key or session was responsible for creating the violation.

On platforms where the more granular -willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays: query
is available, ignore the KVO from AVSampleBufferDisplayLayer, and rely entirely on the per-request query to
determine key status.

Drive-by fix: add logging when we receive the -outputObscuredDueToInsufficientExternalProtection KVO notification, and
include keyIDs in the keyStatus logging.

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WTF::LogArgument<WebCore::CDMInstanceFairPlayStreamingAVFObjC::Keys>::toString):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtectionForDisplayID const):

1:17 PM Changeset in webkit [266634] by sihui_liu@apple.com

8 edits in trunk/Source

Webpages flash when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=216012

Reviewed by Tim Horton.

Source/WebCore/PAL:

pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

Based on patches from Tim Horton. To avoid flash, we need to make sure view to be selected updates its content
before UI process commits its transaction. We did this by making UI process block until receiving a reply
DidUpdateActivityState from web process. However, web process did not make sure the reply would be sent after
normal rendering update and corresponding transasction commit. Instead, it flushed transactions in progress and
replied. To fix this, now we make web process reply in transaction commit handler after rendering update, if
there is an active transaction.

In the switching case, view to be unselected will detach from root layer in its web process, which makes its
content empty. This change is independent from the UI process commit, so we want this to happen after UI process
commits (which submits the view hierachy change). Otherwise, empty content(white flash) on the unselected view
will be displayed. To fix this, we let UI process send the activity state change message in transaction commit
handler, if there is an active transaction.

UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::scheduleActivityStateUpdate):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setSuppressVisibilityUpdates):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::dispatchActivityStateChange):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::updateRendering):
(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacks):
(WebKit::TiledCoreAnimationDrawingArea::handleActivityStateChangeCallbacksIfNeeded):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::didUpdateActivityStateTimerFired): Deleted.

1:06 PM Changeset in webkit [266633] by Alan Coon

1 copy in tags/Safari-610.2.3.1

Tag Safari-610.2.3.1.

1:04 PM Changeset in webkit [266632] by Alan Coon

8 edits in branches/safari-610.2.3-branch/Source

Versioning.

WebKit-7610.2.3.1

12:22 PM Changeset in webkit [266631] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.29.91

WPE WebKit 2.29.91

12:21 PM Changeset in webkit [266630] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.91 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for the 2.29.91 release.

12:19 PM Changeset in webkit [266629] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Notify bot watchers about pre-existing and flaky test failures for JSC tests
https://bugs.webkit.org/show_bug.cgi?id=215948

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(AnalyzeJSCTestsResults.start):
(AnalyzeJSCTestsResults.send_email_for_flaky_failure):
(AnalyzeJSCTestsResults):
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):

12:12 PM Changeset in webkit [266628] by Jonathan Bedard

4 edits
4 copies
14 adds in trunk/Tools

[webkitscmpy] Add root, branch and remote for local SCM repositories
https://bugs.webkit.org/show_bug.cgi?id=215960
<rdar://problem/67968919>

Reviewed by Dewei Zhu.

Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version.
Scripts/libraries/webkitcorepy/webkitcorepy/decorators.py: Added.

(Memoize): Add a memoize call that can cache a response for a set amount of time
Or be explicitly cleared.

Scripts/libraries/webkitcorepy/webkitcorepy/tests/decorators_unittest.py: Added.

(TestMemoize):

Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
Scripts/libraries/webkitscmpy/webkitscmpy/local: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/local/init.py: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: Added.

(Git): Object representing a local git checkout.
(Git.is_checkout): Check if a given path is a git checkout.
(Git.init): Initialize a Git checkout.
(Git.root_path): Return the path for the root of the local repository.
(Git.branch): Return the current branch.
(Git.remote): Return the url of the remote.

Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py: Added.

(Scm): Base class for all local SCM checkouts.
(Scm.Exception):
(Scm.from_path): Given a path, return an instantiated SVN object from that
path, if possible.
(Scm.init):
(Scm.root_path): Virtual function implemented by children.
(Scm.branch): Ditto.
(Scm.remote): Ditto.

Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py: Added.

(Svn): Object representing a local Svn checkout.
(Svn.is_checkout): Check if a given path is a svn checkout.
(Svn.init): Initialize a Svn checkout.
(Svn.info): Return the contents of svn info as a dictionary.
(Svn.root_path): Return the path for the root of the local repository.
(Svn.branch): Return the current branch.
(Svn.remote): Return the url of the remote.

Scripts/libraries/webkitscmpy/webkitscmpy/mocks: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/mocks/init.py: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/init.py: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Added.

(Git): Mock a local Git repository.
(Git.init):

Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py: Added.

(Svn): Mock a local SVN repository.

Scripts/libraries/webkitscmpy/webkitscmpy/test: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/test/init.py: Added.
Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: Added.

(TestGit):

Scripts/libraries/webkitscmpy/webkitscmpy/test/scm_unittest.py: Added.

(TestScm):

Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py: Added.

(TestSvn):

11:54 AM Changeset in webkit [266627] by Chris Dumez

11 edits in trunk

Improve interpolation algorithm in OscillatorNode
https://bugs.webkit.org/show_bug.cgi?id=216183

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

Source/WebCore:

Align our OscillatorNode implementation with Chromium to get us a few more
passes on WPT tests. In particular, the following changes were made:

Align detune AudioParam nominal range values with Chromium's.
We now clamp the frequency value to lie within Nyquist frequency.
Use different interpolation algorithms based on frequency.
Split A-Rate / K-Rate processing code into separate functions for clarity.

No new tests, rebaselined existing tests.

Modules/webaudio/OscillatorNode.cpp:

(WebCore::detuneToFrequencyMultiplier):
(WebCore::clampFrequency):
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::doInterpolation):
(WebCore::OscillatorNode::processARate):
(WebCore::OscillatorNode::processKRate):
(WebCore::OscillatorNode::process):

Modules/webaudio/OscillatorNode.h:

LayoutTests:

Unskip test that should no longer be flaky now that it is passing.

TestExpectations:

11:50 AM Changeset in webkit [266626] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Notify bot watchers about pre-existing and flaky test failures for API tests
https://bugs.webkit.org/show_bug.cgi?id=215949

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-build/steps.py:

(AnalyzeAPITestsResults.analyzeResults):
(AnalyzeAPITestsResults.send_email_for_flaky_failure):
(AnalyzeAPITestsResults):
(AnalyzeAPITestsResults.send_email_for_pre_existing_failure):

11:48 AM Changeset in webkit [266625] by Alan Coon

1 copy in branches/safari-610.2.3-branch

New branch.

11:42 AM Changeset in webkit [266624] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
https://bugs.webkit.org/show_bug.cgi?id=216176

Patch by Patrick Angle <Patrick Angle> on 2020-09-04
Reviewed by Devin Rousso.

Resolved element not being pluralized in some audit test descriptions.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager):

11:30 AM Changeset in webkit [266623] by weinig@apple.com

7 edits in trunk/Source/WebCore

[WebIDL] Remove support for exception interfaces from WebIDL parser and code generators
https://bugs.webkit.org/show_bug.cgi?id=216129

Reviewed by Chris Dumez.

Replace exception interfaces, only used by DOMException.idl, OverconstrainedError.idl
and the tests, with a new "Exception" extended attribute on the interface.

The way WebIDL specifies things, the extended attribute should not really be necessary,
as the DOMException interface is specifically called out as having special EcmaScript
bindings (https://heycam.github.io/webidl/#es-DOMException-specialness), but since
OverconstrainedError is currently relying on those semantics, using an extended attribute
was a useful tool to maintain parity.

Modules/mediastream/OverconstrainedError.idl:
bindings/scripts/test/TestException.idl:
dom/DOMException.idl:

Replace use of special "exception" style interface with Exception extended attribute.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
Replace $interface->isException with $interface->extendedAttributes->{Exception}

bindings/scripts/IDLAttributes.json:

Add new Exception attribute.

bindings/scripts/IDLParser.pm:

(parseDefinition):
(parseDictionaryMembers):
(parseDictionaryMember):
(parseArgument):
(parseArgumentsRest):
(parseException): Deleted.
(parseExceptionMembers): Deleted.
(parseOptionalOrRequiredArgument): Deleted.
(parseExceptionMember): Deleted.
(parseExceptionField): Deleted.
Remove custom exception parsing. Update places using the $nextExceptionField_1 and $nextExceptionMembers_1
to use more clearly named constants.

11:23 AM Changeset in webkit [266622] by Nikita Vasilyev

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Localization: "Low/Medium/High" strings need separate keys for different uses in the UI
https://bugs.webkit.org/show_bug.cgi?id=216136

Reviewed by Brian Burg.

Provide enough context to understand what nouns "low/medium/high" are used with
("impact" and "priority", in our case). This is necessary to determine adjectives'
grammatical gender.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Models/Resource.js:

(WI.Resource.displayNameForPriority):

UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype._layoutEnergyChart):
Drive-by: merge two if blocks into one to minimize code repetition.

11:06 AM Changeset in webkit [266621] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix indentation after r266533
https://bugs.webkit.org/show_bug.cgi?id=193274

dom/TextEncoder.cpp:

(WebCore::TextEncoder::encodeInto):

dom/TextEncoder.idl:

10:46 AM Changeset in webkit [266620] by achristensen@apple.com

26 edits
2 deletes in trunk

Align EUC-JP, ISO-2022-JP, and Shift_JIS decoding with Chrome, Firefox, and the specification
https://bugs.webkit.org/show_bug.cgi?id=216168

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

web-platform-tests/encoding/iso-2022-jp-decoder-expected.txt: Removed.
web-platform-tests/encoding/iso-2022-jp-decoder.any-expected.txt:
web-platform-tests/encoding/iso-2022-jp-decoder.any.worker-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-decode-errors-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-decode-csiso2022jp-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-decode-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp_chars-csiso2022jp.html:
web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp_chars.html:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-csshiftjis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-errors-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-ms932-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-ms_kanji-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-shift-jis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-sjis-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-windows-31j-expected.txt:
web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-x-sjis-expected.txt:
web-platform-tests/encoding/streams/decode-non-utf8.any-expected.txt:
web-platform-tests/encoding/streams/decode-non-utf8.any.worker-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

platform/text/EncodingTables.cpp:
platform/text/EncodingTables.h:
platform/text/TextCodecCJK.cpp:

(WebCore::WTF_ARRAY_LENGTH):
(WebCore::TextCodecCJK::decodeCommon):
(WebCore::codePointJIS0208):
(WebCore::codePointJIS0212):
(WebCore::TextCodecCJK::eucJPDecode):
(WebCore::TextCodecCJK::iso2022JPDecode):
(WebCore::TextCodecCJK::iso2022JPEncode):
(WebCore::TextCodecCJK::shiftJISDecode):
(WebCore::TextCodecCJK::eucKRDecode):
(WebCore::TextCodecCJK::big5Decode):
(WebCore::TextCodecCJK::decode):

platform/text/TextCodecCJK.h:

LayoutTests:

platform/mac/imported/w3c/web-platform-tests/encoding/eof-shift_jis-expected.txt: Removed.

10:23 AM Changeset in webkit [266619] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Add a fast path in TransformationMatrix::mapRect(const FloatRect&) for affine transformations
https://bugs.webkit.org/show_bug.cgi?id=216139

Reviewed by Tim Horton.

Add a fast path when mapping 2D points through affine transformation matrices that takes advantage of both:

The predetermined 0 and 1 values in affine transformation matrices.
The fact that points in the FloatRect are aligned with x and y axes (as opposed to a FloatQuad of 4 arbitrary

points), which allows us to avoid mapping all 4 corners of the rect through the matrix.

The current implementation of this method maps each of the 4 corners through the transformation matrix, creates
a FloatQuad using these 4 transformed points, and then asks the FloatQuad for its bounding box. This requires
a total of 26 floating point additions, 24 multiplications and 20 comparisons, as well as a small (but
measurable) amount of overhead when creating the FloatPoints and FloatQuad and asking for the bounding rect.

We can pare this down to just 8 additions, 8 multiplications, and 4 comparisons by using a different strategy
that instead branches on the 4 relevant matrix coefficients a, b, c, d (rather than the each of the final x
and y coordinates) to determine which of the min or max x and y values to multiply in order to compute the min
and max x and y coordinates in the final bounding rect.

In a quick microbenchmark that maps FloatRects through an affine TransformationMatrix, this roughly halves the
time spent in TransformationMatrix::mapRect; on the Multiply subtest of MotionMark (which invokes this method
~17 million times, almost entirely with affine transformation matrices), I measured a ~1% improvement.

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::mapRect const):

10:22 AM Changeset in webkit [266618] by Darin Adler

6 edits in trunk/Source/WebCore

Simplify some editing code
https://bugs.webkit.org/show_bug.cgi?id=216097

Reviewed by Sam Weinig.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceAllChildrenWithNewText):
If string is empty, don't add a text node. Turns out all callers wanted
this behavior.

dom/Node.cpp:

(WebCore::Node::setTextContent): Simplify by relying on new behavior
of replaceAllChildrenWithNewText when passed an empty string.

editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAsChildOfElement): Use
replaceAllChildrenWithNewText instead of the unnecessarily complicated
code that was here. Also simplify the VisibeSelection manipulation at
the end of the function.

html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText): Simplify by relying on new
behavior of replaceAllChildrenWithNewText when passed an empty string.

page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument): Simplify by using the
selection function that takes a SimpleRange rather than the one that
takes two containers and offsets.

10:18 AM Changeset in webkit [266617] by weinig@apple.com

6 edits in trunk/Source/WebCore

[WebIDL] Remove support for the legacycaller special operation type in favor of an extended attribute
https://bugs.webkit.org/show_bug.cgi?id=216157

Reviewed by Anders Carlsson.

WebIDL no longer specifies the legacycaller special operation type, so to make our
parser more closely match the spec, this change removes support for it. Since we still
need something for HTMLAllCollection's override of Call?, it is replaced with a
new extended attribute [LegacyCaller], which has the same semantics as the old special.

bindings/scripts/CodeGeneratorJS.pm:

(AddLegacyCallerOperationIfNeeded):

bindings/scripts/IDLAttributes.json:
bindings/scripts/IDLParser.pm:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectTestDefaultToJSONConstructorGetter):
(WebCore::jsTestGlobalObjectTestDefaultToJSONConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONConstructorSetter):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONConstructor):

bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestObj.idl:
html/HTMLAllCollection.idl:

10:00 AM Changeset in webkit [266616] by Chris Dumez

6 edits
2 adds in trunk

REGRESSION(macOS Big Sur) https://magenta.github.io/lofi-player/ is broken
https://bugs.webkit.org/show_bug.cgi?id=216163
<rdar://problem/68198173>

Reviewed by Eric Carlson.

Source/WebCore:

Address a crash and a backward-compatibility issue on https://magenta.github.io/lofi-player/.

Test: webaudio/webkitofflineaudiocontext-startRendering-crash.html

Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioListener.idl:
Modules/webaudio/OscillatorNode.idl:

Even after fixing the crash, the game would fail to load because it expected
window.OscillatorNode to exist. When we started working on modern Web Audio,
we renamed the non-standard oscillator node to WebKitOscillatorNode and
added a new standards compliant OscillatorNode behind a runtime flag (off
by default). As a result, window.OscillatorNode no longer existed on Big Sur,
which is not backward compatible. To address the issue, we now expose
window.OscillatorNode even if modern unprefixed WebAudio is not enabled and
we merely disable its constructor at runtime. The same policy applies to
AudioBufferSourceNode & AudioListener because we did the exact same thing
for these interfaces.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::startRendering):
Make sure we call lazyInitialize() before we start offline rendering.
The context may not be initialized yet if no audio nodes were created
for this context. This is similar to what is done in our modern Web
Audio code in OfflineAudioContext::startOfflineRendering(), which is
why the crash was not reproducible when enabling the Modern Web Audio
experimental feature.

LayoutTests:

Add layout test that was reproducing the crash on https://magenta.github.io/lofi-player/.

webaudio/webkitofflineaudiocontext-startRendering-crash-expected.txt: Added.
webaudio/webkitofflineaudiocontext-startRendering-crash.html: Added.

9:40 AM Changeset in webkit [266615] by youenn@apple.com

9 edits
1 copy
41 adds in trunk

Binding generator is not always computing the right interface attributes
https://bugs.webkit.org/show_bug.cgi?id=216173

Reviewed by Alex Christensen.

Source/WebCore:

Update the regular expression to make sure preprocess-idls.pl computes the right attributes for interfaces.
Previously, it was causing issues if a dictionary defined before an interface in the same file had some extended attributes.
Add some global objects IDL files to enable binding test coverage.
Covered by binding tests and existing layout tests.

bindings/scripts/preprocess-idls.pl:

(getInterfaceExtendedAttributesFromIDL):

bindings/scripts/test/BindingTestGlobalConstructors.idl: Added.
bindings/scripts/test/DOMWindow.idl: Added.
bindings/scripts/test/DOMWindowConstructors.idl: Added.
bindings/scripts/test/DedicatedWorkerGlobalScope.idl: Added.
bindings/scripts/test/DedicatedWorkerGlobalScopeConstructors.idl: Added.
bindings/scripts/test/ExposedToWorkerAndWindow.idl: Added.
bindings/scripts/test/JS/JSBindingTestGlobalConstructors.cpp: Added.
bindings/scripts/test/JS/JSBindingTestGlobalConstructors.h: Added.
bindings/scripts/test/JS/JSDOMWindow.cpp: Added.

(WebCore::JSDOMWindowConstructor::prototypeForStructure):
(WebCore::JSDOMWindowConstructor::initializeProperties):
(WebCore::JSDOMWindowPrototype::finishCreation):
(WebCore::JSDOMWindow::JSDOMWindow):
(WebCore::JSDOMWindow::finishCreation):
(WebCore::JSDOMWindow::getConstructor):
(WebCore::IDLAttribute<JSDOMWindow>::cast):
(WebCore::jsDOMWindowConstructor):
(WebCore::setJSDOMWindowConstructor):
(WebCore::jsDOMWindowExposedToWorkerAndWindowConstructorGetter):
(WebCore::jsDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::setJSDOMWindowExposedToWorkerAndWindowConstructorSetter):
(WebCore::setJSDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::jsDOMWindowTestNodeConstructorGetter):
(WebCore::jsDOMWindowTestNodeConstructor):
(WebCore::setJSDOMWindowTestNodeConstructorSetter):
(WebCore::setJSDOMWindowTestNodeConstructor):
(WebCore::jsDOMWindowTestObjectConstructorGetter):
(WebCore::jsDOMWindowTestObjectConstructor):
(WebCore::setJSDOMWindowTestObjectConstructorSetter):
(WebCore::setJSDOMWindowTestObjectConstructor):
(WebCore::jsDOMWindowTestPromiseRejectionEventConstructorGetter):
(WebCore::jsDOMWindowTestPromiseRejectionEventConstructor):
(WebCore::setJSDOMWindowTestPromiseRejectionEventConstructorSetter):
(WebCore::setJSDOMWindowTestPromiseRejectionEventConstructor):
(WebCore::JSDOMWindow::subspaceForImpl):
(WebCore::JSDOMWindow::analyzeHeap):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSDOMWindow::toWrapped):

bindings/scripts/test/JS/JSDOMWindow.h: Added.

(WebCore::JSDOMWindow::create):
(WebCore::JSDOMWindow::createStructure):
(WebCore::JSDOMWindow::subspaceFor):
(WebCore::JSDOMWindow::wrapped const):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSDOMWindowConstructors.cpp: Added.
bindings/scripts/test/JS/JSDOMWindowConstructors.h: Added.
bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp: Added.

(WebCore::JSDedicatedWorkerGlobalScopeConstructor::prototypeForStructure):
(WebCore::JSDedicatedWorkerGlobalScopeConstructor::initializeProperties):
(WebCore::JSDedicatedWorkerGlobalScopePrototype::finishCreation):
(WebCore::JSDedicatedWorkerGlobalScope::JSDedicatedWorkerGlobalScope):
(WebCore::JSDedicatedWorkerGlobalScope::finishCreation):
(WebCore::JSDedicatedWorkerGlobalScope::getConstructor):
(WebCore::jsDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSDedicatedWorkerGlobalScopeConstructor):
(WebCore::JSDedicatedWorkerGlobalScope::subspaceForImpl):
(WebCore::JSDedicatedWorkerGlobalScope::analyzeHeap):

bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h: Added.

(WebCore::JSDedicatedWorkerGlobalScope::create):
(WebCore::JSDedicatedWorkerGlobalScope::createStructure):
(WebCore::JSDedicatedWorkerGlobalScope::subspaceFor):
(WebCore::JSDedicatedWorkerGlobalScope::wrapped const):

bindings/scripts/test/JS/JSDedicatedWorkerGlobalScopeConstructors.cpp: Added.
bindings/scripts/test/JS/JSDedicatedWorkerGlobalScopeConstructors.h: Added.
bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp: Added.

(WebCore::convertDictionary<ExposedToWorkerAndWindow::Dict>):
(WebCore::convertDictionaryToJS):
(WebCore::JSExposedToWorkerAndWindowConstructor::construct):
(WebCore::JSExposedToWorkerAndWindowConstructor::prototypeForStructure):
(WebCore::JSExposedToWorkerAndWindowConstructor::initializeProperties):
(WebCore::JSExposedToWorkerAndWindowPrototype::finishCreation):
(WebCore::JSExposedToWorkerAndWindow::JSExposedToWorkerAndWindow):
(WebCore::JSExposedToWorkerAndWindow::finishCreation):
(WebCore::JSExposedToWorkerAndWindow::createPrototype):
(WebCore::JSExposedToWorkerAndWindow::prototype):
(WebCore::JSExposedToWorkerAndWindow::getConstructor):
(WebCore::JSExposedToWorkerAndWindow::destroy):
(WebCore::IDLOperation<JSExposedToWorkerAndWindow>::cast):
(WebCore::jsExposedToWorkerAndWindowConstructor):
(WebCore::setJSExposedToWorkerAndWindowConstructor):
(WebCore::jsExposedToWorkerAndWindowPrototypeFunctionDoSomethingBody):
(WebCore::jsExposedToWorkerAndWindowPrototypeFunctionDoSomething):
(WebCore::JSExposedToWorkerAndWindow::subspaceForImpl):
(WebCore::JSExposedToWorkerAndWindow::analyzeHeap):
(WebCore::JSExposedToWorkerAndWindowOwner::isReachableFromOpaqueRoots):
(WebCore::JSExposedToWorkerAndWindowOwner::finalize):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSExposedToWorkerAndWindow::toWrapped):

bindings/scripts/test/JS/JSExposedToWorkerAndWindow.h: Copied from Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h.

(WebCore::JSExposedToWorkerAndWindow::create):
(WebCore::JSExposedToWorkerAndWindow::createStructure):
(WebCore::JSExposedToWorkerAndWindow::subspaceFor):
(WebCore::wrapperOwner):
(WebCore::wrapperKey):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp: Added.

(WebCore::JSPaintWorkletGlobalScopeConstructor::prototypeForStructure):
(WebCore::JSPaintWorkletGlobalScopeConstructor::initializeProperties):
(WebCore::JSPaintWorkletGlobalScopePrototype::finishCreation):
(WebCore::JSPaintWorkletGlobalScope::JSPaintWorkletGlobalScope):
(WebCore::JSPaintWorkletGlobalScope::finishCreation):
(WebCore::JSPaintWorkletGlobalScope::getConstructor):
(WebCore::jsPaintWorkletGlobalScopeConstructor):
(WebCore::setJSPaintWorkletGlobalScopeConstructor):
(WebCore::JSPaintWorkletGlobalScope::subspaceForImpl):
(WebCore::JSPaintWorkletGlobalScope::analyzeHeap):

bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h: Added.

(WebCore::JSPaintWorkletGlobalScope::create):
(WebCore::JSPaintWorkletGlobalScope::createStructure):
(WebCore::JSPaintWorkletGlobalScope::subspaceFor):
(WebCore::JSPaintWorkletGlobalScope::wrapped const):

bindings/scripts/test/JS/JSPaintWorkletGlobalScopeConstructors.cpp: Added.
bindings/scripts/test/JS/JSPaintWorkletGlobalScopeConstructors.h: Added.
bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp: Added.

(WebCore::JSServiceWorkerGlobalScopeConstructor::prototypeForStructure):
(WebCore::JSServiceWorkerGlobalScopeConstructor::initializeProperties):
(WebCore::JSServiceWorkerGlobalScopePrototype::finishCreation):
(WebCore::JSServiceWorkerGlobalScope::JSServiceWorkerGlobalScope):
(WebCore::JSServiceWorkerGlobalScope::finishCreation):
(WebCore::JSServiceWorkerGlobalScope::getConstructor):
(WebCore::jsServiceWorkerGlobalScopeConstructor):
(WebCore::setJSServiceWorkerGlobalScopeConstructor):
(WebCore::JSServiceWorkerGlobalScope::subspaceForImpl):
(WebCore::JSServiceWorkerGlobalScope::analyzeHeap):

bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h: Added.

(WebCore::JSServiceWorkerGlobalScope::create):
(WebCore::JSServiceWorkerGlobalScope::createStructure):
(WebCore::JSServiceWorkerGlobalScope::subspaceFor):
(WebCore::JSServiceWorkerGlobalScope::wrapped const):

bindings/scripts/test/JS/JSServiceWorkerGlobalScopeConstructors.cpp: Added.
bindings/scripts/test/JS/JSServiceWorkerGlobalScopeConstructors.h: Added.
bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectDOMWindowConstructorGetter):
(WebCore::jsTestGlobalObjectDOMWindowConstructor):
(WebCore::setJSTestGlobalObjectDOMWindowConstructorSetter):
(WebCore::setJSTestGlobalObjectDOMWindowConstructor):
(WebCore::jsTestGlobalObjectDedicatedWorkerGlobalScopeConstructorGetter):
(WebCore::jsTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectDedicatedWorkerGlobalScopeConstructorSetter):
(WebCore::setJSTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectPaintWorkletGlobalScopeConstructorGetter):
(WebCore::jsTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectPaintWorkletGlobalScopeConstructorSetter):
(WebCore::setJSTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectServiceWorkerGlobalScopeConstructorGetter):
(WebCore::jsTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectServiceWorkerGlobalScopeConstructorSetter):
(WebCore::setJSTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectWorkerGlobalScopeConstructorGetter):
(WebCore::jsTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkerGlobalScopeConstructorSetter):
(WebCore::setJSTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectWorkletGlobalScopeConstructorGetter):
(WebCore::jsTestGlobalObjectWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkletGlobalScopeConstructorSetter):
(WebCore::setJSTestGlobalObjectWorkletGlobalScopeConstructor):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
bindings/scripts/test/JS/JSWorkerGlobalScope.cpp: Added.

(WebCore::JSWorkerGlobalScopeConstructor::prototypeForStructure):
(WebCore::JSWorkerGlobalScopeConstructor::initializeProperties):
(WebCore::JSWorkerGlobalScopePrototype::finishCreation):
(WebCore::JSWorkerGlobalScope::JSWorkerGlobalScope):
(WebCore::JSWorkerGlobalScope::finishCreation):
(WebCore::JSWorkerGlobalScope::createPrototype):
(WebCore::JSWorkerGlobalScope::prototype):
(WebCore::JSWorkerGlobalScope::getConstructor):
(WebCore::IDLAttribute<JSWorkerGlobalScope>::cast):
(WebCore::jsWorkerGlobalScopeConstructor):
(WebCore::setJSWorkerGlobalScopeConstructor):
(WebCore::jsWorkerGlobalScopeExposedToWorkerAndWindowConstructorGetter):
(WebCore::jsWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::setJSWorkerGlobalScopeExposedToWorkerAndWindowConstructorSetter):
(WebCore::setJSWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::jsWorkerGlobalScopeTestNodeConstructorGetter):
(WebCore::jsWorkerGlobalScopeTestNodeConstructor):
(WebCore::setJSWorkerGlobalScopeTestNodeConstructorSetter):
(WebCore::setJSWorkerGlobalScopeTestNodeConstructor):
(WebCore::jsWorkerGlobalScopeTestObjectConstructorGetter):
(WebCore::jsWorkerGlobalScopeTestObjectConstructor):
(WebCore::setJSWorkerGlobalScopeTestObjectConstructorSetter):
(WebCore::setJSWorkerGlobalScopeTestObjectConstructor):
(WebCore::jsWorkerGlobalScopeTestPromiseRejectionEventConstructorGetter):
(WebCore::jsWorkerGlobalScopeTestPromiseRejectionEventConstructor):
(WebCore::setJSWorkerGlobalScopeTestPromiseRejectionEventConstructorSetter):
(WebCore::setJSWorkerGlobalScopeTestPromiseRejectionEventConstructor):
(WebCore::JSWorkerGlobalScope::subspaceForImpl):
(WebCore::JSWorkerGlobalScope::analyzeHeap):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSWorkerGlobalScope::toWrapped):

bindings/scripts/test/JS/JSWorkerGlobalScope.h: Added.

(WebCore::JSWorkerGlobalScope::create):
(WebCore::JSWorkerGlobalScope::createStructure):
(WebCore::JSWorkerGlobalScope::subspaceFor):
(WebCore::JSWorkerGlobalScope::wrapped const):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSWorkerGlobalScopeConstructors.cpp: Added.
bindings/scripts/test/JS/JSWorkerGlobalScopeConstructors.h: Added.
bindings/scripts/test/JS/JSWorkletGlobalScope.cpp: Added.

(WebCore::JSWorkletGlobalScopeConstructor::prototypeForStructure):
(WebCore::JSWorkletGlobalScopeConstructor::initializeProperties):
(WebCore::JSWorkletGlobalScopePrototype::finishCreation):
(WebCore::JSWorkletGlobalScope::JSWorkletGlobalScope):
(WebCore::JSWorkletGlobalScope::finishCreation):
(WebCore::JSWorkletGlobalScope::createPrototype):
(WebCore::JSWorkletGlobalScope::prototype):
(WebCore::JSWorkletGlobalScope::getConstructor):
(WebCore::jsWorkletGlobalScopeConstructor):
(WebCore::setJSWorkletGlobalScopeConstructor):
(WebCore::JSWorkletGlobalScope::subspaceForImpl):
(WebCore::JSWorkletGlobalScope::analyzeHeap):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSWorkletGlobalScope::toWrapped):

bindings/scripts/test/JS/JSWorkletGlobalScope.h: Added.

(WebCore::JSWorkletGlobalScope::create):
(WebCore::JSWorkletGlobalScope::createStructure):
(WebCore::JSWorkletGlobalScope::subspaceFor):
(WebCore::JSWorkletGlobalScope::wrapped const):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSWorkletGlobalScopeConstructors.cpp: Added.
bindings/scripts/test/JS/JSWorkletGlobalScopeConstructors.h: Added.
bindings/scripts/test/PaintWorkletGlobalScope.idl: Added.
bindings/scripts/test/PaintWorkletGlobalScopeConstructors.idl: Added.
bindings/scripts/test/ServiceWorkerGlobalScope.idl: Added.
bindings/scripts/test/ServiceWorkerGlobalScopeConstructors.idl: Added.
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/WorkerGlobalScope.idl: Added.
bindings/scripts/test/WorkerGlobalScopeConstructors.idl: Added.
bindings/scripts/test/WorkletGlobalScope.idl: Added.
bindings/scripts/test/WorkletGlobalScopeConstructors.idl: Added.
dom/TextEncoder.idl:

Tools:

Add support to validate global constructor idl file generator.

Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

9:39 AM Changeset in webkit [266614] by youenn@apple.com

5 edits in trunk

Fix Internals::supportsVCPEncoder on BigSur
https://bugs.webkit.org/show_bug.cgi?id=216174

Reviewed by Eric Carlson.

Source/WebCore:

Fixed by unflaked test.

testing/Internals.cpp:

(WebCore::Internals::supportsVCPEncoder):

LayoutTests:

platform/mac-wk2/TestExpectations:
platform/mac/webrtc/captureCanvas-webrtc-software-encoder-expected.txt:
platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:

Slight modification to make the test run faster and output more comprehensive error message if error happens.

9:35 AM Changeset in webkit [266613] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add client decoder entitlement
https://bugs.webkit.org/show_bug.cgi?id=216175
<rdar://problem/67532128>

Reviewed by Brent Fulgham.

Add client decoder entitlement in the WebContent process on macOS.

Scripts/process-entitlements.sh:

9:25 AM Changeset in webkit [266612] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Localization: typo in WAI-ARIA string ("[the] element have")
https://bugs.webkit.org/show_bug.cgi?id=216176

Patch by Patrick Angle <Patrick Angle> on 2020-09-04
Reviewed by Brian Burg.

Resolved auxiliary verb in localizable strings having the wrong pluralization for the singular element.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype._addDefaultTests):
(WI.AuditManager):

9:11 AM Changeset in webkit [266611] by youenn@apple.com

5 edits
2 adds in trunk

MediaRecorder timeslice parameter causing internal error on longer videos
https://bugs.webkit.org/show_bug.cgi?id=216076
<rdar://problem/68209422>

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/wpt/fetch/blob-range.html

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::readDataAsync):

Source/WebKit:

Test: http/wpt/fetch/blob-range.html

NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::readData):
readData can be re-entrant so we need to reset m_currentItemReadSize before consuming data.

LayoutTests:

http/wpt/fetch/blob-range-expected.txt: Added.
http/wpt/fetch/blob-range.html: Added.

8:44 AM Changeset in webkit [266610] by Aditya Keerthi

3 edits
2 adds in trunk

REGRESSION (r241734): [iOS] Changing the value of a select element and tapping on another results in two changes
https://bugs.webkit.org/show_bug.cgi?id=216077

Reviewed by Darin Adler.

Source/WebKit:

r241734 added a call to [self _endEditing] in
[WKContentView _elementDidBlur] to ensure that any open form controls
are dismissed when using the keyboard to change focus.
[self _endEditing] calls [_inputPeripheral endEditing], which
eventually calls [WKFormControl controlEndEditing].

However, if the focus is changed by tapping on another form control, a
a gesture recognizer calls [_inputPeripheral endEditing]. Consequently,
changing the focused element by tapping results in two calls to
[WKFormControl controlEndEditing]. First from the gesture recognizer,
and then from [WKContentView _elementDidBlur].

For certain form controls on iPhone, such as the select element,
controlEndEditing is responsible for updating the element's value in
the WebProcess. Note that the same is not true on iPad, as
controlEndEditing simply dismisses a popover. Now, the first call to
[WKSelectSinglePicker controlEndEditing] correctly updates the expected
select element. However, when tapping on another select element, the
second call to [WKSelectSinglePicker controlEndEditing] also attempts
to update the value of the focused element. By this time, the focused
element in the WebProcess is the second select element. Consequently,
changing the value in one select element and then tapping another
results in updates to both elements.

To fix this issue, while preserving the intent of r241734, we should
prevent callers from being able to end editing in a control twice. Note
that WKFormPeripheralBase already keeps track of the editing state of a
control in a boolean variable _editing. If the control has finished
being edited, _editing is set to false. This patch adds an early return
to [WKFormPeripheralBase endEditing] if _editing is false, ensuring
controlEndEditing is never called twice. For parity, also ensure that
controlBeginEditing can only be called if the control is not already
being edited.

Test: fast/forms/ios/select-picker-change-and-focus-another-select.html

UIProcess/ios/forms/WKFormPeripheralBase.mm:

(-[WKFormPeripheralBase beginEditing]): Early return if control is already being edited.
(-[WKFormPeripheralBase endEditing]): Early return if control is not being edited.

LayoutTests:

fast/forms/ios/select-picker-change-and-focus-another-select-expected.txt: Added.
fast/forms/ios/select-picker-change-and-focus-another-select.html: Added.

8:23 AM Changeset in webkit [266609] by youenn@apple.com

6 edits in trunk

TextDecoderStreamDecoder.@encoding is broken
https://bugs.webkit.org/show_bug.cgi?id=216169

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/encoding/streams/decode-attributes.any-expected.txt:
web-platform-tests/encoding/streams/decode-attributes.any.worker-expected.txt:

Source/WebCore:

Binding generator does not support private attributes.
Use a private method instead.
Covered by rebased tests.

dom/TextDecoderStream.js:

(initializeTextDecoderStream):

dom/TextDecoderStreamDecoder.idl:

8:03 AM Changeset in webkit [266608] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

WebCore::DOMTimerFireState constructor fails to initialize m_initialDOMTreeVersion, m_previous on worker threads
<https://webkit.org/b/216085>

Reviewed by Darin Adler.

page/DOMTimer.cpp:

(WebCore::DOMTimerFireState):

Reorder instance variables so more logic can be moved into the initializer list.

7:57 AM Changeset in webkit [266607] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[macOS] UI process sometimes crashes under -[WKSharingServicePickerDelegate sharingService:didShareItems:]
https://bugs.webkit.org/show_bug.cgi?id=216167
<rdar://problem/68287449>

Reviewed by Anders Carlsson.

It's not clear what causes the array of items in this delegate method to be empty, but we should at least be
robust against this scenario and avoid crashing the application process.

UIProcess/mac/WKSharingServicePickerDelegate.mm:

(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):

7:43 AM Changeset in webkit [266606] by Kate Cheney

4 edits in trunk/Source/WebKit

WebProcessProxy::checkURLReceivedFromWebProcess() does not always need to check the back/forward list
https://bugs.webkit.org/show_bug.cgi?id=216109
<rdar://problem/59867349>

Reviewed by Brady Eidson.

We should not need to check the back/forward list when setting a
pasteboard URL because any valid pasteboard URL will be handled
by one of the other if-statements in
WebProcessProxy::checkURLReceivedFromWebProcess(), therefore checking
again is a waste of time.

This also hardens the process against potential abuse by preventing
the possibility of an invalid URL in the back/forward list being
saved in the pasteboard property list.

UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::setPasteboardURL):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):

UIProcess/WebProcessProxy.h:

7:39 AM Changeset in webkit [266605] by Alan Bujtas

5 edits
2 moves in trunk/Source/WebCore

[LFC][IFC] Rename LineLayoutContext to LineBuilder
https://bugs.webkit.org/show_bug.cgi?id=216166

Reviewed by Antti Koivisto.

LineLayoutContext builds the line.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/inlineformatting/InlineFormattingContext.cpp:

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineLineBuilder.cpp: Renamed from Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp.

(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::nextWrapOpportunity):
(WebCore::Layout::LineCandidate::InlineContent::runs const):
(WebCore::Layout::LineCandidate::InlineContent::logicalWidth const):
(WebCore::Layout::LineCandidate::InlineContent::trailingLineBreak const):
(WebCore::Layout::LineCandidate::InlineContent::appendLineBreak):
(WebCore::Layout::LineCandidate::InlineContent::setTrailingLineBreak):
(WebCore::Layout::LineCandidate::FloatContent::list const):
(WebCore::Layout::LineCandidate::FloatContent::intrusiveWidth const):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineCandidate::InlineContent::reset):
(WebCore::Layout::LineCandidate::FloatContent::append):
(WebCore::Layout::LineCandidate::FloatContent::reset):
(WebCore::Layout::LineCandidate::reset):
(WebCore::Layout::LineBuilder::inlineItemWidth const):
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::nextContentForLine):
(WebCore::Layout::LineBuilder::commitFloats):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
(WebCore::Layout::LineBuilder::commitPartialContent):
(WebCore::Layout::LineBuilder::rebuildLine):

layout/inlineformatting/InlineLineBuilder.h: Renamed from Source/WebCore/layout/inlineformatting/LineLayoutContext.h.

(WebCore::Layout::LineBuilder::InlineItemRange::isEmpty const):
(WebCore::Layout::LineBuilder::InlineItemRange::size const):
(WebCore::Layout::LineBuilder::formattingContext const):
(WebCore::Layout::LineBuilder::root const):

6:57 AM Changeset in webkit [266604] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Share bots between JSC builder and tester queues
https://bugs.webkit.org/show_bug.cgi?id=215934

Reviewed by Carlos Alberto Lopez Perez.

BuildSlaveSupport/ews-build/config.json:

5:59 AM Changeset in webkit [266603] by Alan Bujtas

10 edits
2 moves in trunk/Source/WebCore

Rename LineBuilder to Line
https://bugs.webkit.org/show_bug.cgi?id=216165

Reviewed by Antti Koivisto.

This class evolved to the actual line and LineLayoutContext became the LineBuilder.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::lineDescentNeedsCollapsing const):

layout/inlineformatting/InlineLine.cpp: Renamed from Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp.

(WebCore::Layout::isWhitespacePreserved):
(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::~Line):
(WebCore::Layout::Line::open):
(WebCore::Layout::Line::clearContent):
(WebCore::Layout::Line::close):
(WebCore::Layout::Line::removeTrailingTrimmableContent):
(WebCore::Layout::Line::visuallyCollapsePreWrapOverflowContent):
(WebCore::Layout::Line::moveLogicalLeft):
(WebCore::Layout::Line::moveLogicalRight):
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendPartialTrailingTextItem):
(WebCore::Layout::Line::appendWith):
(WebCore::Layout::Line::appendNonBreakableSpace):
(WebCore::Layout::Line::appendInlineContainerStart):
(WebCore::Layout::Line::appendInlineContainerEnd):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineBox):
(WebCore::Layout::Line::appendReplacedInlineBox):
(WebCore::Layout::Line::appendLineBreak):
(WebCore::Layout::Line::isRunVisuallyNonEmpty const):
(WebCore::Layout::Line::formattingContext const):
(WebCore::Layout::Line::TrimmableTrailingContent::TrimmableTrailingContent):
(WebCore::Layout::Line::TrimmableTrailingContent::addFullyTrimmableContent):
(WebCore::Layout::Line::TrimmableTrailingContent::addPartiallyTrimmableContent):
(WebCore::Layout::Line::TrimmableTrailingContent::remove):
(WebCore::Layout::Line::TrimmableTrailingContent::removePartiallyTrimmableContent):
(WebCore::Layout::Line::Run::Run):
(WebCore::Layout::Line::Run::expand):
(WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
(WebCore::Layout::Line::Run::trailingLetterSpacing const):
(WebCore::Layout::Line::Run::removeTrailingLetterSpacing):
(WebCore::Layout::Line::Run::removeTrailingWhitespace):
(WebCore::Layout::Line::Run::visuallyCollapseTrailingWhitespace):
(WebCore::Layout::Line::Run::setExpansionBehavior):
(WebCore::Layout::Line::Run::expansionBehavior const):
(WebCore::Layout::Line::Run::setHorizontalExpansion):

layout/inlineformatting/InlineLine.h: Renamed from Source/WebCore/layout/inlineformatting/InlineLineBuilder.h.

(WebCore::Layout::Line::setHasIntrusiveFloat):
(WebCore::Layout::Line::hasIntrusiveFloat const):
(WebCore::Layout::Line::isVisuallyEmpty const):
(WebCore::Layout::Line::lineLogicalWidth const):
(WebCore::Layout::Line::contentLogicalWidth const):
(WebCore::Layout::Line::availableWidth const):
(WebCore::Layout::Line::trimmableTrailingWidth const):
(WebCore::Layout::Line::isTrailingRunFullyTrimmable const):
(WebCore::Layout::Line::Run::isText const):
(WebCore::Layout::Line::Run::isBox const):
(WebCore::Layout::Line::Run::isLineBreak const):
(WebCore::Layout::Line::Run::isContainerStart const):
(WebCore::Layout::Line::Run::isContainerEnd const):
(WebCore::Layout::Line::Run::layoutBox const):
(WebCore::Layout::Line::Run::style const):
(WebCore::Layout::Line::Run::textContent const):
(WebCore::Layout::Line::Run::logicalWidth const):
(WebCore::Layout::Line::Run::logicalLeft const):
(WebCore::Layout::Line::Run::logicalRight const):
(WebCore::Layout::Line::Run::expansion const):
(WebCore::Layout::Line::Run::hasExpansionOpportunity const):
(WebCore::Layout::Line::Run::expansionOpportunityCount const):
(WebCore::Layout::Line::Run::hasTrailingWhitespace const):
(WebCore::Layout::Line::Run::trailingWhitespaceWidth const):
(WebCore::Layout::Line::Run::moveHorizontally):
(WebCore::Layout::Line::Run::shrinkHorizontally):
(WebCore::Layout::Line::Run::setNeedsHyphen):
(WebCore::Layout::Line::Run::hasCollapsibleTrailingWhitespace const):
(WebCore::Layout::Line::Run::hasCollapsedTrailingWhitespace const):
(WebCore::Layout::Line::runs const):
(WebCore::Layout::Line::contentLogicalRight const):
(WebCore::Layout::Line::TrimmableTrailingContent::width const):
(WebCore::Layout::Line::TrimmableTrailingContent::isEmpty const):
(WebCore::Layout::Line::TrimmableTrailingContent::isTrailingRunFullyTrimmable const):
(WebCore::Layout::Line::TrimmableTrailingContent::isTrailingRunPartiallyTrimmable const):
(WebCore::Layout::Line::TrimmableTrailingContent::reset):
(WebCore::Layout::Line::Run::trailingWhitespaceType const):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):

layout/inlineformatting/InlineLineBox.h:
layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::layoutInlineContent):
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::commitFloats):
(WebCore::Layout::LineLayoutContext::handleFloatsAndInlineContent):
(WebCore::Layout::LineLayoutContext::commitPartialContent):
(WebCore::Layout::LineLayoutContext::rebuildLine):

layout/inlineformatting/LineLayoutContext.h:

5:58 AM Changeset in webkit [266602] by Oriol Brufau

24 edits
34 adds in trunk/LayoutTests

[css-grid] Import grid tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=216147

LayoutTests/imported/w3c:

Import grid tests from WPT.

Reviewed by Carlos Alberto Lopez Perez.

web-platform-tests/css/css-grid/alignment/grid-baseline-align-001-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-baseline-align-001.html: Added.
web-platform-tests/css/css-grid/alignment/grid-baseline-justify-001-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-baseline-justify-001.html: Added.
web-platform-tests/css/css-grid/alignment/grid-gutters-014-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-gutters-014.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-1-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-1.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-10-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-10.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-2-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-2.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-3-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-3.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-4-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-4.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-5.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-6.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-7.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-8-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-8.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-9-expected.html: Added.
web-platform-tests/css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-9.html: Added.
web-platform-tests/css/css-grid/alignment/w3c-import.log:
web-platform-tests/css/css-grid/grid-definition/grid-auto-explicit-rows-001-expected.txt: Added.
web-platform-tests/css/css-grid/grid-definition/grid-auto-explicit-rows-001.html: Added.
web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-columns-001-expected.txt:
web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-columns-001.html:
web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-rows-001-expected.txt:
web-platform-tests/css/css-grid/grid-definition/grid-auto-fill-rows-001.html:
web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-rows-001-expected.txt:
web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-rows-001.html:
web-platform-tests/css/css-grid/grid-definition/grid-template-columns-fit-content-001-expected.html:
web-platform-tests/css/css-grid/grid-definition/grid-template-columns-fit-content-001.html:
web-platform-tests/css/css-grid/grid-definition/grid-template-rows-fit-content-001-expected.html:
web-platform-tests/css/css-grid/grid-definition/grid-template-rows-fit-content-001.html:
web-platform-tests/css/css-grid/grid-definition/support/testing-utils.js:

(testGridTemplateColumnsRows):

web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
web-platform-tests/css/css-grid/grid-items/grid-item-flex-container-001-expected.txt: Added.
web-platform-tests/css/css-grid/grid-items/grid-item-flex-container-001.html: Added.
web-platform-tests/css/css-grid/grid-items/w3c-import.log:
web-platform-tests/css/css-grid/grid-model/grid-gutters-and-tracks-001.html:
web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-002-expected.xht: Added.
web-platform-tests/css/css-grid/layout-algorithm/flex-and-intrinsic-sizes-002.html: Added.
web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-003-expected.txt:
web-platform-tests/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-003.html:
web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid-expected.txt:
web-platform-tests/css/css-grid/parsing/grid-template-areas-invalid.html:
web-platform-tests/css/css-grid/parsing/grid-template-areas-one-cell-expected.txt: Added.
web-platform-tests/css/css-grid/parsing/grid-template-areas-one-cell.html: Added.
web-platform-tests/css/css-grid/parsing/w3c-import.log:

LayoutTests:

Reviewed by Carlos Alberto Lopez Perez.

Mark some new tests as failing.

TestExpectations:

5:57 AM Changeset in webkit [266601] by Adrian Perez de Castro

2 edits in trunk

Unreviewed. [WPE] Bump version numbers

Source/cmake/OptionsWPE.cmake:

5:38 AM Changeset in webkit [266600] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Horizontal alignment should move the inline boxes and not the line box
https://bugs.webkit.org/show_bug.cgi?id=216153

Reviewed by Antti Koivisto.

When the "text-align" property triggers horizontal alignment, the line content (inline boxes and runs) should
be moved horizontally while the line box should stay at the initial top/left position.
This patch is also a preparation for making the LineBox more aligned with the spec.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::horizontalAlignmentOffset const):

5:25 AM Changeset in webkit [266599] by Carlos Garcia Campos

2 edits in trunk

Unreviewed. [GTK] Bump version numbers

Source/cmake/OptionsGTK.cmake:

5:12 AM Changeset in webkit [266598] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.29.92

WebKitGTK 2.29.92

5:12 AM Changeset in webkit [266597] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.30

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.92 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.29.92.

4:16 AM Changeset in webkit [266596] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.30

Merge r266584 - [GLIB] Stop using firefox user agent quirk for google docs
https://bugs.webkit.org/show_bug.cgi?id=215845

Reviewed by Adrian Perez de Castro.

Source/WebCore:

It causes problems with the CSP headers when accounts.youtube.com is used by google login and it no longer works
for google docs in any case.

platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

Tools:

Update API tests. Bring back UserAgentQuirks.cpp to the build that was removed in r244857.

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWPE.cmake:
TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

4:16 AM Changeset in webkit [266595] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.30

Merge r266297 - [WPE] Enable Notifications support
https://bugs.webkit.org/show_bug.cgi?id=215924

Reviewed by Philippe Normand.

Enable web notifications support for the WPE port. The code is shared with the GTK
port, but as we do not try to find and enable libnotify the default implementation
is a stub: embedders can customize how to display notifications by connecting to
the WebKitWebView:show-notification signal. This way we do not add any additional
build dependencies.

Source/cmake/OptionsWPE.cmake: Flip ENABLE_NOTIFICATIONS to ON.

LayoutTests:

platform/wpe/TestExpectations: Update test expectations.

4:16 AM Changeset in webkit [266594] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/JavaScriptCore

Merge r266577 - Unreviewed. [GLIB] Add missing return

There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.

API/glib/JSCValue.cpp:

(jsc_value_object_invoke_methodv):

4:16 AM Changeset in webkit [266593] by Carlos Garcia Campos

14 edits in releases/WebKitGTK/webkit-2.30

Merge r266576 - [GTK] Unexpected User-Agent on redirect
https://bugs.webkit.org/show_bug.cgi?id=191858

Reviewed by Youenn Fablet.

Source/WebKit:

Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the
quirks if needed. Also ensure quirks are applied for downloads started in the UI process.

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request.

UIProcess/API/glib/WebKitDownloadClient.cpp:
UIProcess/WebPageProxy.h: Add userAgentForURL().
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent().

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/playstation/WebPageProxyPlayStation.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

Tools:

Add unit tests to check the user agent is sent in headers and preserved after a redirect for both main resource
and subresources.

TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(serverCallback):
(testDownloadUserAgent):
(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(testUserAgent):
(serverCallback):
(beforeAll):

4:16 AM Changeset in webkit [266592] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r266389 - [GTK][WPE] Do not use the default WebsiteDataStore for downloads
https://bugs.webkit.org/show_bug.cgi?id=216001

Reviewed by Adrian Perez de Castro.

Use the web context one instead.

UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextStartDownload):

4:16 AM Changeset in webkit [266591] by Carlos Garcia Campos

8 edits in releases/WebKitGTK/webkit-2.30

Merge r266000 - [GTK][WPE] Debug crashes in backdrop filter tests
https://bugs.webkit.org/show_bug.cgi?id=215209

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-08-20
Reviewed by Adrian Perez de Castro.

Source/WebCore:

This only happens in WKTR because RenderLayerCompositor::flushPendingLayerChanges() is called from
RenderLayerCompositor::layerTreeAsText(), so the coordinator doesn't know layers are being flushed and we don't
return early from notifyFlushRequired(). We don't really need to have a coordinator associated to the backdrop
layer, we just need to attach the layer to the coordinator to ensure it's updated.

platform/graphics/nicosia/NicosiaAnimation.cpp:

(Nicosia::Animation::applyInternal): Handle AnimatedPropertyWebkitBackdropFilter.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer): Detach also the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): Attach the backdrop layer to the
coordinator if there's one.
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers): Do not call this for the
backdrop layer.
(WebCore::CoordinatedGraphicsLayer::invalidateCoordinator): Set coordinator to nullptr.
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded): Set the coordinator and attach
the layer. Also attach the backdrop layer.
(WebCore::CoordinatedGraphicsLayer::setCoordinator): Deleted.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::~CompositingCoordinator): Use invalidateCoordinator() instead of setCoordinator()
that has been removed.
(WebKit::CompositingCoordinator::createGraphicsLayer): Use setCoordinatorIncludingSubLayersIfNeeded() instead of
attaching the layer directly.
(WebKit::CompositingCoordinator::attachLayer): Do not call setCoordinator(), the caller is expected to set the
coordinator.

LayoutTests:

Remove expectations for tests that are now passing.

platform/glib/TestExpectations:

4:16 AM Changeset in webkit [266590] by Carlos Garcia Campos

12 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r266388 - [Linux] Web Inspector: show per thread cpu usage
https://bugs.webkit.org/show_bug.cgi?id=215883

Reviewed by Adrian Perez de Castro.

Source/JavaScriptCore:

Remove platform specific getter machThread() and add thread() to return the Thread instead. The caller knows how
to get the machThread or id from a Thread.

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopBytecodes):
(JSC::SamplingProfiler::machThread): Deleted.

runtime/SamplingProfiler.h:

(JSC::SamplingProfiler::thread):

Source/WebCore:

Get per thread CPU usage and information to fill ResourceUsageData in Linux.

page/ResourceUsageThread.h:
page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Update to new API in SamplingProfiler.

page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformSaveStateBeforeStarting): Initialize m_samplingProfilerThreadID.
(WebCore::threadInfoMap):
(WebCore::threadCPUUsage):
(WebCore::collectCPUUsage):
(WebCore::ResourceUsageThread::platformCollectCPUData):
(WebCore::cpuUsage): Deleted.

Source/WTF:

Add API to get the thread ID in Linux platform.

wtf/Threading.cpp:

(WTF::Thread::initializeInThread):

wtf/Threading.h:

(WTF::Thread::id const):

wtf/ThreadingPrimitives.h:
wtf/posix/ThreadingPOSIX.cpp:

(WTF::Thread::currentID):

4:16 AM Changeset in webkit [266589] by Carlos Garcia Campos

12 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r266227 - [GTK] Include the run loop source name in frame rendering timeline
https://bugs.webkit.org/show_bug.cgi?id=215847

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Include the given name in rendering frame record data.

inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createRenderingFrameData):

inspector/TimelineRecordFactory.h:
inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

Source/WebInspectorUI:

Show the frame name if present in timeline panel.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

UserInterface/Models/RenderingFrameTimelineRecord.js:

(WI.RenderingFrameTimelineRecord):
(WI.RenderingFrameTimelineRecord.prototype.get name):

UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.displayNameForRecord):

Source/WTF:

Pass the run loop source name to the observer.

wtf/RunLoop.h:
wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::notify):

4:16 AM WebKitGTK/2.30.x edited by Carlos Garcia Campos

(diff)

4:16 AM Changeset in webkit [266588] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WTF

Merge r266331 - [GTK] REGRESSION(r150392) insufficient space allocation results in heap corruption
https://bugs.webkit.org/show_bug.cgi?id=215976

Patch by Jim Mason <jmason@ibinx.com> on 2020-08-30
Reviewed by Carlos Garcia Campos.

wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::TimerBase):

4:15 AM Changeset in webkit [266587] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r266103 - [GTK] Implement rendering frames timeline panel for GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=150392
<rdar://problem/23200510>

Reviewed by Brian Burg.

Source/WebCore:

Use new RunLoop API to observe the run loop events when the GLib event loop is used.

inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):

inspector/agents/InspectorTimelineAgent.h:

Source/WTF:

Add API to observe RunLoop events for GLib event loop implementation.

wtf/RunLoop.h:
wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::RunLoop): Use RunLoopSource struct and initialize the RunLoop.
(WTF::RunLoop::observe): Add the given observer to the set.
(WTF::RunLoop::notify): Notife observers of the given event.
(WTF::RunLoop::TimerBase::TimerBase): Use RunLoopSource struct and initialize the RunLoop.

4:15 AM Changeset in webkit [266586] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.30

Merge r265940 - REGRESSION(r265856) [GTK][WPE] hybi websockets tests failing
https://bugs.webkit.org/show_bug.cgi?id=215679

Reviewed by Carlos Garcia Campos.

Source/WebKit:

r265856 changed WebSocketChannel to expect AbnormalClosure when the
closing handshake is not received.

Covered by existing tests.

NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::didFail):

LayoutTests:

Rebaseline and update expectations.

platform/glib/TestExpectations:
platform/glib/http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
platform/glib/http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:

4:15 AM Changeset in webkit [266585] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r265856 - WebSocketChannel::didClose should correctly compute whether a closing handshake was received
https://bugs.webkit.org/show_bug.cgi?id=215644

Reviewed by Darin Adler.

Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled.

WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::didClose):
As noted by Jiten Mehta, absence of closing handshake from the server is notified by WebSocketChannel::CloseEventCodeAbnormalClosure.
Update check accordingly.

4:14 AM Changeset in webkit [266584] by Carlos Garcia Campos

6 edits in trunk

[GLIB] Stop using firefox user agent quirk for google docs
https://bugs.webkit.org/show_bug.cgi?id=215845

Reviewed by Adrian Perez de Castro.

Source/WebCore:

It causes problems with the CSP headers when accounts.youtube.com is used by google login and it no longer works
for google docs in any case.

platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

Tools:

Update API tests. Bring back UserAgentQuirks.cpp to the build that was removed in r244857.

TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWPE.cmake:
TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

1:31 AM Changeset in webkit [266583] by Diego Pino Garcia

2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectations after r266559.

platform/glib/TestExpectations:

1:23 AM Changeset in webkit [266582] by Diego Pino Garcia

3 edits
1 delete in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update baselines after r266528.

platform/glib/imported/w3c/web-platform-tests/encoding/single-byte-decoder-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any-expected.txt:
platform/glib/imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker-expected.txt:

1:05 AM Changeset in webkit [266581] by Alexey Shvayka

4 edits in trunk

Array.prototype.push should always perform Set? in strict mode
https://bugs.webkit.org/show_bug.cgi?id=216121

Reviewed by Darin Adler.

JSTests:

test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch fixes arrayProtoFuncPush() to throw a TypeError if putting an
index beyond UINT32_MAX has failed, aligning JSC with the spec [1], V8,
and SpiderMonkey. Also, refactors the method leveraging putByIndexInline().

Array.prototype.push microbenchmarks, including varargs tests, are neutral.

[1]: https://tc39.es/ecma262/#sec-array.prototype.push (step 5.b)

runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPush):

12:02 AM Changeset in webkit [266580] by James Darpinian

2 edits in trunk/Tools

Update James Darpinian's status to committer
https://bugs.webkit.org/show_bug.cgi?id=216154

Reviewed by Kenneth Russell.

Scripts/webkitpy/common/config/contributors.json:

Sep 3, 2020:

11:10 PM Changeset in webkit [266579] by rniwa@webkit.org

2 edits in trunk/Source/WTF

GTK+ build fix attempt after r266573.

wtf/CompactUniquePtrTuple.h:

10:58 PM Changeset in webkit [266578] by rniwa@webkit.org

6 edits in trunk/Source/WebCore

Store all styling flags in m_rendererWithStyleFlags
https://bugs.webkit.org/show_bug.cgi?id=216069

Reviewed by Darin Adler.

This patch moves all remaining styling flags and Style::Validity from m_nodeFlags
to m_rendererWithStyleFlags since CSS JIT no longer rely on these flags directly
and CompactPointerTuple has been expanded to store up to 16 bits of data as opposed
to just 8 bits.

No new tests since there should be no behavioral change.

dom/ContainerNode.h:

(WebCore::ContainerNode::directChildNeedsStyleRecalc const):
(WebCore::ContainerNode::setDirectChildNeedsStyleRecalc):

dom/Element.cpp:

(WebCore::Element::resetStyleRelations):

dom/Element.h:

(WebCore::Element::styleAffectedByEmpty const):
(WebCore::Element::descendantsAffectedByPreviousSibling const):
(WebCore::Element::childrenAffectedByFirstChildRules const):
(WebCore::Element::childrenAffectedByLastChildRules const):
(WebCore::Element::childrenAffectedByForwardPositionalRules const):
(WebCore::Element::descendantsAffectedByForwardPositionalRules const):
(WebCore::Element::childrenAffectedByBackwardPositionalRules const):
(WebCore::Element::descendantsAffectedByBackwardPositionalRules const):
(WebCore::Element::childrenAffectedByPropertyBasedBackwardPositionalRules const):
(WebCore::Element::affectsNextSiblingElementStyle const):
(WebCore::Element::styleIsAffectedByPreviousSibling const): Moved here from Node.
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::setDescendantsAffectedByPreviousSibling):
(WebCore::Element::setChildrenAffectedByFirstChildRules):
(WebCore::Element::setChildrenAffectedByLastChildRules):
(WebCore::Element::setChildrenAffectedByForwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByForwardPositionalRules):
(WebCore::Element::setChildrenAffectedByBackwardPositionalRules):
(WebCore::Element::setDescendantsAffectedByBackwardPositionalRules):
(WebCore::Element::setChildrenAffectedByPropertyBasedBackwardPositionalRules):
(WebCore::Element::setAffectsNextSiblingElementStyle):
(WebCore::Element::setStyleIsAffectedByPreviousSibling):

dom/Node.cpp:

(WebCore::Node::adjustStyleValidity):

dom/Node.h:

(WebCore::Node::styleValidity const):
(WebCore::Node::styleResolutionShouldRecompositeLayer const):
(WebCore::Node::childNeedsStyleRecalc const):
(WebCore::Node::styleIsAffectedByPreviousSibling const): Moved to Element.
(WebCore::Node::setChildNeedsStyleRecalc):
(WebCore::Node::flagChildrenAffectedByFirstChildRulesFlag): Deleted.
(WebCore::Node::flagChildrenAffectedByLastChildRulesFlag): Deleted.
(WebCore::Node::flagAffectsNextSiblingElementStyle): Deleted.
(WebCore::Node::flagStyleIsAffectedByPreviousSibling): Deleted.
(WebCore::Node::NodeStyleFlag): Added. Moved most of flags from m_nodeFlags here.
(WebCore::Node::DynamicStyleRelationFlag): Renamed from ElementStyleFlag.
(WebCore::Node::StyleBitfields): Added. A helper struct to read and manipulate
bit-fields stored in m_rendererWithStyleFlags.
(WebCore::Node::StyleBitfields::fromRaw): Added.
(WebCore::Node::StyleBitfields::toRaw): Added.
(WebCore::Node::StyleBitfields::styleValidity const): Added.
(WebCore::Node::StyleBitfields::setStyleValidity): Added.
(WebCore::Node::StyleBitfields::dynamicStyleRelations const): Added.
(WebCore::Node::StyleBitfields::setDynamicStyleRelation): Added.
(WebCore::Node::StyleBitfields::clearDynamicStyleRelations): Added.
(WebCore::Node::StyleBitfields::flags const): Added.
(WebCore::Node::StyleBitfields::setFlag): Added.
(WebCore::Node::StyleBitfields::clearFlag): Added.
(WebCore::Node::StyleBitfields::clearDescendantsNeedStyleResolution): Added.
(WebCore::Node::styleBitfields const): Added.
(WebCore::Node::setStyleBitfields): Added.
(WebCore::Node::hasStyleFlag const):
(WebCore::Node::setStyleFlag):
(WebCore::Node::clearStyleFlags): Deleted.
(WebCore::Node::hasDynamicStyleRelationFlag const): Added.
(WebCore::Node::setHasValidStyle): Moved here from the class declaration.
(WebCore::Node::setDynamicStyleRelationFlag): Added.
(WebCore::Node::clearChildNeedsStyleRecalc): Added.
(WebCore::Node::setHasValidStyle):

10:19 PM Changeset in webkit [266577] by Carlos Garcia Campos

2 edits in trunk/Source/JavaScriptCore

Unreviewed. [GLIB] Add missing return

There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.

API/glib/JSCValue.cpp:

(jsc_value_object_invoke_methodv):

10:13 PM Changeset in webkit [266576] by Carlos Garcia Campos

14 edits in trunk

[GTK] Unexpected User-Agent on redirect
https://bugs.webkit.org/show_bug.cgi?id=191858

Reviewed by Youenn Fablet.

Source/WebKit:

Clear the user agent on new request after a redirect to ensure a new one is computed taking into account the
quirks if needed. Also ensure quirks are applied for downloads started in the UI process.

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Clear the user agent on new request.

UIProcess/API/glib/WebKitDownloadClient.cpp:
UIProcess/WebPageProxy.h: Add userAgentForURL().
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download): Use userAgentForURL() instead of userAgent().

UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::userAgentForURL): Implement it to apply quirks if needed.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::userAgentForURL): Just return the web page user agent.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/playstation/WebPageProxyPlayStation.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::userAgentForURL): Ditto.

Tools:

Add unit tests to check the user agent is sent in headers and preserved after a redirect for both main resource
and subresources.

TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:

(serverCallback):
(testDownloadUserAgent):
(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:

(testUserAgent):
(serverCallback):
(beforeAll):

8:07 PM Changeset in webkit [266575] by Chris Dumez

13 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline flaky Web Audio tests.

web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-upmixing-1-channel-response-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:

8:03 PM Changeset in webkit [266574] by Karl Rackler

2 edits in trunk/LayoutTests

[ Catalina debug wk2 ] html5lib/generated/run-template-data.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=216164

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

8:01 PM Changeset in webkit [266573] by rniwa@webkit.org

6 edits
2 adds in trunk

Add CompactUniquePtrTuple
https://bugs.webkit.org/show_bug.cgi?id=215936

Reviewed by Darin Adler.

Source/WTF:

Added a new template class, CompactUniquePtrTuple, which stores a pointer and up to 16-bits of
a POD type using CompactPointerTuple.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/CompactUniquePtrTuple.h: Added.

(WTF::makeCompactUniquePtr): Added. Like makeUnique, creates an object of the specified type
and returns CompactUniquePtrTuple.
(WTF::CompactUniquePtrTuple): Added.
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Move constructor.
(WTF::CompactUniquePtrTuple::~CompactUniquePtrTuple):
(WTF::CompactUniquePtrTuple::operator=):
(WTF::CompactUniquePtrTuple::pointer):
(WTF::CompactUniquePtrTuple::moveToUniquePtr): Clears this pointer and returns unique_ptr.
(WTF::CompactUniquePtrTuple::setPointer): Like CompactPointerTuple sets the pointer component
of this tuple, freeing the old object if there is already one stored.
(WTF::CompactUniquePtrTuple::type):
(WTF::CompactUniquePtrTuple::setType):
(WTF::CompactUniquePtrTuple::CompactUniquePtrTuple): Constructor which takes unique_ptr&&.
(WTF::CompactUniquePtrTuple::deletePointer):

Tools:

Added basic unit tests for CompactUniquePtrTuple.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp: Added.

(TestWebKitAPI::A): Adde.
(TestWebKitAPI::A::A):
(TestWebKitAPI::A::~A):
(WTF_CompactUniquePtrTuple.Basic):

8:01 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:59 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:59 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:49 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:40 PM Debugging With Visual Studio edited by Fujii Hironori

(diff)

7:33 PM Changeset in webkit [266572] by Hector Lopez

1 edit
2 deletes in trunk/LayoutTests

Correction for Rebasline at changeset https://trac.webkit.org/changeset/266500/webkit

Unreviewed test gardening.

platform/mac-catalina/fast/forms/date/date-pseudo-elements-expected.txt: Removed.
platform/mac-mojave/fast/forms/date/date-pseudo-elements-expected.txt: Removed.

7:33 PM Changeset in webkit [266571] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, fix debug build after r266570.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

7:07 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

7:00 PM Changeset in webkit [266570] by Chris Dumez

9 edits in trunk

Tests using OscillatorNode are flaky
https://bugs.webkit.org/show_bug.cgi?id=216152

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/detune-limiting-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:

Source/WebCore:

OscillatorNode was caching the different kind of PeriodicWaves in global static
variables. However, the PeriodicWaves are specific to a given sample rate.
As a result, we would sometimes use a cached periodic wave that was using the
wrong sample rate, leading to flaky failures. To address the issue, we now
cache the periodic waves per audio context instead.

No new tests, rebaselined existing tests and unskip them.

Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::periodicWave):

Modules/webaudio/BaseAudioContext.h:
Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::setType):

Modules/webaudio/OscillatorNode.h:

6:56 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:54 PM Changeset in webkit [266569] by Hector Lopez

2 edits in trunk/LayoutTests

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=216162

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

6:52 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:51 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:11 PM Changeset in webkit [266568] by commit-queue@webkit.org

10 edits
5 adds in trunk

Web Inspector fails to preview response from XHR requests
https://bugs.webkit.org/show_bug.cgi?id=215852

Patch by Patrick Angle <Patrick Angle> on 2020-09-03
Reviewed by Devin Rousso.

Source/WebCore:

Test: http/tests/inspector/network/fetch-response-body.html

Added workaround for 304 XHR/Fetch requests so that the mimeType and content are correctly set, otherwise the
frontend does not have the information it needs to preview the response.

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived): Storing new ResourceData members
(WebCore::NetworkResourcesData::dataForURL): Support for finding a previous non-304 response for a URL.

inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::httpStatusText const):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusText):
(WebCore::NetworkResourcesData::ResourceData::mimeType const):
(WebCore::NetworkResourcesData::ResourceData::setMIMEType):
(WebCore::NetworkResourcesData::ResourceData::responseTimestamp const):
(WebCore::NetworkResourcesData::ResourceData::setResponseTimestamp):

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::willSendRequest): Fixed issue where it was possible that we would inform the

frontend that a request was of type Other even though we had request information indicating it was XHR
or Fetch.

(WebCore::InspectorNetworkAgent::didReceiveResponse): Added code path to work around underlying issue where

XHR/Fetch 304s are not cached, and end up not passing necessary information to the frontend as a result.

Source/WebInspectorUI:

Responses with a no content error and a status code of 304 now show a Resource has no cached content message instead

of a generic error. Also responses with empty content and no mime type now show a Resource has no content
message.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Models/Resource.js: More consistant error handling model - previously some paths rejected on

failure and some resolved with an error property.

(WI.Resource.prototype.requestContent):
(WI.Resource.prototype._requestContentFailure):

UserInterface/Views/ResourceContentView.js: Error messages

(WI.ResourceContentView.prototype.async showGenericNoContentMessage): Text now consistent with other messages.
(WI.ResourceContentView.prototype.showNoCachedContentMessage):
(WI.ResourceContentView.prototype._contentAvailable):

LayoutTests:

Added new test cases and associated resources to test handling of 304 Not Modified responses to XHR requests.
We test both XHR for a PHP page as well as for a text file, as they behaved differently (incorrectly) before
this patch.

http/tests/inspector/network/fetch-response-body-304-expected.txt:
http/tests/inspector/network/fetch-response-body-304.html:
http/tests/inspector/network/resources/.htaccess: Cache-Control header for fetch-cachable.txt
http/tests/inspector/network/resources/fetch-cachable.php:
http/tests/inspector/network/resources/fetch-cachable.txt:
platform/mac-wk1/TestExpectations: Tests rely on disk-cache which is not present in WK1

6:03 PM Changeset in webkit [266567] by ysuzuki@apple.com

15 edits
2 moves
9 adds in trunk

[JSC] Cache toString / valueOf / @@toPrimitive for major cases
https://bugs.webkit.org/show_bug.cgi?id=216061

Reviewed by Saam Barati.

JSTests:

stress/delete-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

stress/delete-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

stress/delete-cached-value-of-property.js: Added.

(shouldBe):
(shouldThrow):
(object.proto.valueOf):

stress/hide-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

stress/hide-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

stress/hide-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

stress/replace-cached-to-primitive-property.js: Added.

(shouldBe):
(object.proto.Symbol.toPrimitive):

stress/replace-cached-to-string-property.js: Added.

(shouldBe):
(object.proto.toString):

stress/replace-cached-value-of-property.js: Added.

(shouldBe):
(object.proto.valueOf):

Source/JavaScriptCore:

When toPrimitive is called, we need to look-up three properties at most to perform operation. And these special properties do not have caching mechanism at all.
We found that Speedometer2/EmberJS-Debug-TodoMVC is using very much time for this property look-up. We should have caching mechanism in StructureRareData, which
should be similar to @@toStringTag & Object#toString caching mechanism.

This patch generalizes @@toStringTag & Object#toString caching mechanism as SpecialPropertyCache. And we accelerate toString / valueOf / @@toPrimitive look-ups in
toPrimitive with this caching mechanism.

This patch improved Speedometer2/EmberJS-Debug-TodoMVC by 10%.

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/Watchpoint.cpp:
bytecode/Watchpoint.h:
runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.cpp: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.cpp.

(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::CachedSpecialPropertyAdaptiveStructureWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::install):
(JSC::CachedSpecialPropertyAdaptiveStructureWatchpoint::fireInternal):

runtime/CachedSpecialPropertyAdaptiveStructureWatchpoint.h: Renamed from Source/JavaScriptCore/runtime/ObjectToStringAdaptiveStructureWatchpoint.h.
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::objectProtoToStringFunction const):

runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::toPrimitive const):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):
(JSC::objectProtoFuncToString):

runtime/Structure.h:
runtime/StructureInlines.h:

(JSC::Structure::cacheSpecialProperty):
(JSC::Structure::setObjectToStringValue): Deleted.

runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):
(JSC::StructureRareData::ensureSpecialPropertyCacheSlow):
(JSC::StructureRareData::giveUpOnSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialPropertySlow):
(JSC::StructureRareData::clearCachedSpecialProperty):
(JSC::StructureRareData::finalizeUnconditionally):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::isValid const):
(JSC::CachedSpecialPropertyAdaptiveInferredPropertyValueWatchpoint::handleFire):
(JSC::StructureRareData::setObjectToStringValue): Deleted.
(JSC::StructureRareData::clearObjectToStringValue): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::isValid const): Deleted.
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire): Deleted.

runtime/StructureRareData.h:
runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::cachedSpecialProperty const):
(JSC::StructureRareData::canCacheSpecialProperty):
(JSC::StructureRareData::ensureSpecialPropertyCache):
(JSC::StructureRareData::cacheSpecialProperty):
(JSC::StructureRareData::objectToStringValue const): Deleted.

6:02 PM Changeset in webkit [266566] by Hector Lopez

1 edit in trunk/LayoutTests/ChangeLog

REGRESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:59 PM Changeset in webkit [266565] by Hector Lopez

2 edits in trunk/LayoutTests

RERESSION(r266509): [ iOS wk2 ] css2.1/t0905-c5525-fltwidth-00-c-g.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216160

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:58 PM Changeset in webkit [266564] by Karl Rackler

2 edits in trunk/LayoutTests

[ Mac wk2 ] webgpu/whlsl/ensure-proper-variable-lifetime.html is flaky ImageOnlyFailure.
https://bugs.webkit.org/show_bug.cgi?id=207267

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

5:43 PM Changeset in webkit [266563] by Hector Lopez

3 edits in trunk/LayoutTests

REGRESSION(r266511): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-restartIce.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216159

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

5:13 PM Changeset in webkit [266562] by Karl Rackler

2 edits in trunk/LayoutTests

[ Mojave+ debug wk2 ] imported/w3c/web-platform-tests/css/css-transitions/transition-base-response-002.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216155

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

5:00 PM Changeset in webkit [266561] by Hector Lopez

2 edits in trunk/LayoutTests

[ iOS wk2 ] http/tests/misc/script-async.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216156

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

3:47 PM Changeset in webkit [266560] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together
https://bugs.webkit.org/show_bug.cgi?id=216087

Reviewed by Tadeu Zagallo.

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions):

2:43 PM Changeset in webkit [266559] by Chris Dumez

23 edits in trunk

AudioDestinationNode.maxChannelCount always returns 0
https://bugs.webkit.org/show_bug.cgi?id=216127

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/ctor-biquadfilter-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/ctor-delay-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-dynamicscompressornode-interface/ctor-dynamicscompressor-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/ctor-gain-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/ctor-mediastreamaudiodestination-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/ctor-oscillator-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/ctor-panner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/ctor-stereopanner-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt:

Source/WebCore:

Update AudioDestinationNode.maxChannelCount to return a sane value on both macOS
and iOS. Also make sure the proper exceptions are thrown when trying to create
an AudioNode with an invalid number of channels.

No new tests, rebaselined existing tests.

Modules/webaudio/AudioDestinationNode.h:
Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::setChannelCount):

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::setChannelCount):

platform/audio/AudioSession.cpp:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

platform/audio/AudioSession.h:
platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestination::create):
(WebCore::AudioDestination::maxChannelCount):

platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSession::maximumNumberOfOutputChannels const):

2:42 PM Changeset in webkit [266558] by Chris Dumez

4 edits in trunk

Make AudioParam.cancelScheduledValues() standards compliant
https://bugs.webkit.org/show_bug.cgi?id=216132

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/cancel-scheduled-values-expected.txt:

Source/WebCore:

Align our implementation of AudioParam.cancelScheduledValues() with Chromium's
to give us a few more passes on WPT tests. In particular, this adds special
handling for when the cancelTime lands in the middle of a SetValueCurve event.

No new tests, rebaselined existing test.

Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::cancelScheduledValues):

2:38 PM Changeset in webkit [266557] by Darin Adler

76 edits in trunk/Source

Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
https://bugs.webkit.org/show_bug.cgi?id=216102

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::characterOffsetForTextMarkerData): Use Affinity.

accessibility/AXObjectCache.h: Ditto.
accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::performTextOperation): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForUnorderedPositions const): Ditto.
(WebCore::AccessibilityObject::visiblePositionRangeForRange const): Ditto.
(WebCore::AccessibilityObject::replaceTextInRange): Ditto.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const): Removed unneeded
call to Position::equal, simplified code.
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const): Use Affinity.
(WebCore::AccessibilityRenderObject::visiblePositionForIndex const): Ditto.
(WebCore::AccessibilityRenderObject::doAXRangeForLine const): Ditto.

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject): Use Affinity.
(wordAtPositionForAtkBoundary): Ditto.
(sentenceAtPositionForAtkBoundary): Ditto.
(lineAtPositionForAtkBoundary): Ditto.

accessibility/atk/WebKitAccessibleUtil.cpp:

(objectFocusedAndCaretOffsetUnignored): Rely on default affinity.

dom/Element.cpp:

(WebCore::Element::updateFocusAppearance): Rely on default affinity.

dom/Position.cpp:

(WebCore::Position::previousCharacterPosition const): Use Affinity.
(WebCore::Position::nextCharacterPosition const): Ditto.
(WebCore::Position::leadingWhitespacePosition const): Ditto.
(WebCore::Position::trailingWhitespacePosition const): Ditto.
(WebCore::Position::inlineBoxAndOffset const): Ditto.

editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::formatSelection): Ditto.

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply): Ditto.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphWithClones): Rely on default affinity.
(WebCore::CompositeEditCommand::moveParagraphs): Ditto.

editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Use Affinity.

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::smartDeleteParagraphSpacers): Ditto.
(WebCore::DeleteSelectionCommand::doApply): Ditto.

editing/Editing.cpp:

(WebCore::firstInSpecialElement): Rely on default affinity.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::visiblePositionBeforeNode): Ditto.
(WebCore::visiblePositionAfterNode): Ditto.
(WebCore::visiblePositionForIndexUsingCharacterIterator): Use Affinity.

editing/Editor.cpp:

(WebCore::Editor::selectionForCommand): Use Affinity.
(WebCore::Editor::canDeleteRange const): Rely on default affinity.
(WebCore::Editor::applyStyle): Use isNone and isCaret.
(WebCore::Editor::applyParagraphStyle): Ditto.
(WebCore::Editor::setComposition): Use Affinity.
(WebCore::Editor::advanceToNextMisspelling): Rely on default affinity.
(WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
(WebCore::Editor::markAndReplaceFor): Ditto. Use isCaret.
(WebCore::Editor::transpose): Rely on default affinity.
(WebCore::Editor::insertTextPlaceholder): Ditto.
(WebCore::Editor::removeTextPlaceholder): Ditto.
(WebCore::Editor::firstRectForRange const): Ditto. Also simplify
rectangle calculation at the end of the function.
(WebCore::Editor::shouldChangeSelection const): Use Affinity.
(WebCore::Editor::findString): Rely on default affinity.

editing/Editor.h: Use Affinity.
editing/EditorCommand.cpp:

(WebCore::executeDeleteToMark): Ditto.
(WebCore::executeSelectToMark): Ditto.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo): Ditto.
(WebCore::FrameSelection::modify): Ditto.
(WebCore::FrameSelection::setBase): Ditto.
(WebCore::FrameSelection::setExtent): Ditto.
(WebCore::FrameSelection::setSelectedRange): Ditto.
(WebCore::FrameSelection::revealSelection): Use isNone and isCaret.
(WebCore::FrameSelection::setSelectionFromNone): Rely on default affinity.
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection): Ditto.

editing/FrameSelection.h: Use Affinity.

editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentRegion): Rely on default affinity.

editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply): Use Affinity.

editing/InsertNestedListCommand.cpp:

(WebCore::InsertNestedListCommand::doApply): Ditto.

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Use Affinity.

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab): Rely on default affinity.

editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::RenderedPosition): Use Affinity.

editing/RenderedPosition.h: Ditto.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Rely on default affinity.
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
Use VisibleSelection::defaultAffinity.

editing/TextAffinity.h: Removed EAffinity, UPSTREAM, DOWNSTREAM.

editing/TextIterator.cpp:

(WebCore::TextIterator::shouldRepresentNodeOffsetZero): Rely on
default affinity.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::makeEditableRootEmpty): Use Affinity.
(WebCore::TypingCommand::deleteKeyPressed): Use isCaretOrRange and isRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::VisiblePosition): Use Affinity.
(WebCore::VisiblePosition::previous const): Rely on default affinity.
(WebCore::VisiblePosition::left const): Ditto.
(WebCore::VisiblePosition::right const): Ditto.
(WebCore::operator<<): Use Affinity.

editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::VisibleSelection): Use Affinity. Also use
initialize in the class definition.
(WebCore::VisibleSelection::selectionFromContentsOfNode): Rely on
default affinity.
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
Rename from "pos" to "position".
(WebCore::VisibleSelection::updateSelectionType): Update from
m_selectionType to m_type and use Affinity.
(WebCore::VisibleSelection::validate): Use isRange.
(WebCore::VisibleSelection::setWithoutValidation): Use Affinity and
m_type.

editing/VisibleSelection.h: Removed SEL_DEFAULT_AFFINITY, replacing

it with VisibleSelection::defaultAffinity. Removed both
VisibleSelection::SelectionType and VisibleSelection::selectionType,
replacing with private VisibleSelection::Type. Also renamed
m_selectionType to m_type.

editing/VisibleUnits.cpp:

(WebCore::logicallyPreviousBox): Use Affinity.
(WebCore::logicallyNextBox): Ditto.
(WebCore::previousLinePosition): Rely on default affinity.
(WebCore::nextLinePosition): Ditto.
(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.
(WebCore::withinTextUnitOfGranularity): Use Affinity.
(WebCore::enclosingTextUnitOfGranularity): Ditto.

editing/cocoa/DictionaryLookup.mm:

(WebCore::DictionaryLookup::rangeAtHitTestResult): Use isRange.

loader/EmptyClients.cpp: Use Affinity.
page/DOMSelection.cpp:

(WebCore::DOMSelection::collapse): Ditto.
(WebCore::DOMSelection::collapseToEnd): Ditto.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::setBaseAndExtent): Ditto.
(WebCore::DOMSelection::setPosition): Ditto.
(WebCore::DOMSelection::extend): Ditto.

page/EditorClient.h: Ditto.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):
Rely on default affinity.

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):
Use constructor that takes a single Position and Affinity.

page/Page.cpp:

(WebCore::replaceRanges): Use Affinity.

page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use isNone.

rendering/RenderBlock.cpp:

(WebCore::positionForPointRespectingEditingBoundaries): Use Affinity.
(WebCore::RenderBlock::positionForPoint): Ditto.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPointWithInlineChildren): Ditto.

rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::positionForPoint): Ditto.

rendering/RenderObject.cpp:

(WebCore::RenderObject::positionForPoint): Ditto.
(WebCore::RenderObject::createVisiblePosition const): Ditto.

rendering/RenderObject.h: Ditto.
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint): Ditto.

rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.

rendering/RenderTreeAsText.cpp:

(WebCore::writeSelection): Ditto.

rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint): Ditto.

Source/WebKit:

WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:

(API::InjectedBundle::EditorClient::shouldChangeSelectedRange): Use Affinity.

WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI): Dito.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Ditto.

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange): Ditto.

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Ditto.
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldChangeSelectedRange): Ditto.

WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.

WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::insertDictatedTextAsync): Rely on default affinity.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync): Ditto.
(WebKit::WebPage::setCompositionAsync): Ditto.
(WebKit::WebPage::deleteSurrounding): Ditto.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDrag): Use Affinity.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::moveSelectionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::selectTextWithGranularityAtPoint): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): Ditto.
(WebKit::WebPage::updateSelectionWithExtentPoint): Ditto.
(WebKit::WebPage::replaceSelectedText): Ditto.
(WebKit::WebPage::replaceDictatedText): Ditto.
(WebKit::WebPage::applyAutocorrectionInternal): Ditto.
(WebKit::WebPage::updateSelectionWithDelta): Ditto.

Source/WebKitLegacy/ios:

WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]): Use Affinity.
(-[WebFrame smartExtendRangedSelection:]): Use visibleStart/End/Extent so we don't
need to write explicit code to handle affinity.

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition setAffinity:]): Use Affinity.

Source/WebKitLegacy/mac:

DOM/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]): Rely on default affinity.

WebCoreSupport/WebEditorClient.h:

(kit): Use Affinity.
(core): Ditto.

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldChangeSelectedRange): Ditto.

WebView/WebFrame.mm:

(-[WebFrame _caretRectAtPosition:affinity:]): Ditto.
(-[WebFrame _selectNSRange:]): Rely on default affinity.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use isNone.

WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]): Rely on default affinity.

Source/WebKitLegacy/win:

WebCoreSupport/WebEditorClient.cpp:

(toWebSelectionAffinity): Added.
(WebEditorClient::shouldChangeSelectedRange): Use Affinity.

WebCoreSupport/WebEditorClient.h: Ditto.

2:35 PM Changeset in webkit [266556] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Unreviewed, reverting r266498.
https://bugs.webkit.org/show_bug.cgi?id=216143

crashes in debug

Reverted changeset:

"Simplify some editing code"
https://bugs.webkit.org/show_bug.cgi?id=216097
https://trac.webkit.org/changeset/266498

2:31 PM Changeset in webkit [266555] by Alan Coon

22 edits in branches/safari-610-branch

Cherry-pick r266265. rdar://problem/68168939

[iOS] provide a way to get previously inserted alternatives for the selected text
https://bugs.webkit.org/show_bug.cgi?id=215816
<rdar://problem/66646042>

Reviewed by Darin Adler.

Source/WebCore:

editing/cocoa/AlternativeTextUIController.h:
editing/cocoa/AlternativeTextUIController.mm: (WebCore::AlternativeTextUIController::alternativesForContext): Return the raw NSTextAlternatives * and let the caller create the Vector<String> if they need to so that callers that don't can use the actual NSTextAlternatives *.

editing/Editor.h:
editing/Editor.cpp: (WebCore::Editor::applyDictationAlternative): Added. (WebCore::Editor::applyDictationAlternativelternative): Deleted.
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Drive-by: fix typo.

Source/WebKit:

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView alternativesForSelectedText]):

UIProcess/WebPageProxy.h:
UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformDictationAlternatives): Added.
UIProcess/PageClient.h:
UIProcess/Cocoa/PageClientImplCocoa.h:
UIProcess/Cocoa/PageClientImplCocoa.mm: (WebKit::PageClientImplCocoa::dictationAlternatives): (WebKit::PageClientImplCocoa::platformDictationAlternatives): Added. Provide a way to get the raw NSTextAlternatives * for a given WebCore::DictationContext.

Shared/EditorState.h:
Shared/EditorState.cpp: (WebKit::EditorState::PostLayoutData::encode const): (WebKit::EditorState::PostLayoutData::decode):
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getPlatformEditorState const): Include a Vector<WebCore::DictationContext> as part of the EditorState that contains all of the WebCore::DictationContext that exist in the currently selected range (or the range of the word containing the cursor if nothing is selected).

Platform/spi/ios/UIKitSPI.h:

Source/WebKitLegacy/mac:

WebView/WebView.mm: (-[WebView _dictationAlternatives:]): Create a Vector<String> from the returned NSTextAlternatives * now that the member WebCore::AlternativeTextUIController::alternativesForContext returns it.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: (InsertTextAlternatives.Simple):

TestWebKitAPI/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266554] by Alan Coon

3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266218. rdar://problem/68168930

REGRESSION: touchbar controls don't reflect video state in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=215873
<rdar://problem/66723354>

Reviewed by Eric Carlson.

platform/mac/WebPlaybackControlsManager.h:
platform/mac/WebPlaybackControlsManager.mm: (-[WebPlaybackControlsManager setPlaying:]): (-[WebPlaybackControlsManager isPlaying]): Create an actual ivar _playing for holding the play/pause state. This is needed because AVTouchBarScrubber uses KVO to update the state of the play/pause button whenever the related video controller (in this case AVTouchBarPlaybackControlsControlling) changes using an NSValueBinding. KVO needs an actual ivar in order to function properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266553] by Alan Coon

3 edits
2 adds in branches/safari-610-branch

Cherry-pick r266156. rdar://problem/68168945

Facebook post with lots of comments has cut off scrollbar, and can't scroll fully to the bottom (sticky)
https://bugs.webkit.org/show_bug.cgi?id=215719
<rdar://problem/66411757>

Reviewed by Simon Fraser.

Source/WebCore:

While computing the scrollable overflow for inflow positioned (or transformed) renderers, we need to take their paint geometry into
account so that scrolling matches their final positions.
e.g.

<div style="width: 100px; height: 100px;"></div>
<div style="position: relative; top: -20; width: 50px; height: 50px;"></div>

While the inflow positioned block box is placed right below the previous sibling div, visually they overlap each other.
If these boxes happen to be in a scrollable container, the scrolling should be driven by the overlapping state (paint geometry) and not
by the layout geometry (where the 2 boxes are placed vertically after each other).

While stickily positioned boxes are also considered inflow positioned, their initial inflow layout positions contribute to the scrollable overflow
as they are not stationary boxes.

Test: fast/css/scrollable-overflow-with-sticky-positioning.html

rendering/RenderBox.cpp: (WebCore::RenderBox::layoutOverflowRectForPropagation const):

LayoutTests:

fast/css/scrollable-overflow-with-sticky-positioning-expected.html: Added.
fast/css/scrollable-overflow-with-sticky-positioning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266552] by Alan Coon

2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266144. rdar://problem/68168942

When using airplay with Youtube, the Youtube tab becomes completely empty and is unresponsive for an extended period of time if we switch the tab
https://bugs.webkit.org/show_bug.cgi?id=215821

Reviewed by Eric Carlson.

We should ignore the request to paint the current video frame when we are using airplay.
It is not necessary to do so, and -[AVAssetImageGenerator copyCGImageAtTime:actualTime:error:]
will block the web process for a long time if the video is airplaying.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266551] by Alan Coon

5 edits
4 adds in branches/safari-610-branch

Cherry-pick r266158. rdar://problem/67812825

Web Share API Level 2 functions even when its experimental feature flag is disabled
https://bugs.webkit.org/show_bug.cgi?id=215831
<rdar://problem/67760687>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/web-share/canShare-with-files-feature-disabled.html

fast/web-share/share-with-files-feature-disabled.html

We had a feature flag for Web Share API Level 2, but it isn't actually
consulted anywhere in the implementation.

page/Navigator.cpp: (WebCore::Navigator::canShare): Rewrite canShare to be a bit more readable, and also to consult the Level 2 feature flag.

(WebCore::Navigator::share):
Since canShare (per the spec) will return true if we have files and other content,
even if files are not shareable, check the feature flag again before loading the files.

Source/WebKit:

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): If the Web Content process sends us files, but the Level 2 feature flag is disabled, something fishy is happening, so fire a MESSAGE_CHECK.

LayoutTests:

fast/web-share/canShare-with-files-feature-disabled-expected.txt: Added.
fast/web-share/canShare-with-files-feature-disabled.html: Added.
fast/web-share/share-with-files-feature-disabled-expected.txt: Added.
fast/web-share/share-with-files-feature-disabled.html: Added. Add some tests that ensure that disabling the feature actually works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:31 PM Changeset in webkit [266550] by Alan Coon

8 edits
2 adds in branches/safari-610-branch

Cherry-pick r266151. rdar://problem/68168950

Web Share API can share non-HTTP(S) URLs
https://bugs.webkit.org/show_bug.cgi?id=215823
<rdar://problem/62083130>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/web-share/share-disallows-file-urls.html

page/Navigator.cpp: (WebCore::shareableURLForShareData): (WebCore::Navigator::canShare): (WebCore::Navigator::share): Factor out the code to complete and check the scheme of the URL. Make canShare() return NO and share() fail for non-HTTP(S) or data: URLs.

Source/WebKit:

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::showShareSheet): Ensure that only HTTP family or data: URLs are shared.

LayoutTests:

fast/web-share/share-disallows-file-urls-expected.txt: Added.
fast/web-share/share-disallows-file-urls.html: Added.
fast/web-share/share-transient-activation-expired.html:
fast/web-share/share-transient-activation.html:
fast/web-share/share.html: Add a test that ensures that sharing a non-HTTP-family URL fails, and fix the existing tests to share HTTP-family URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266549] by Alan Coon

16 edits
2 adds in branches/safari-610-branch

Cherry-pick r266292. rdar://problem/67963525

Vertical scrolling gets stuck when a horizontal scroller is under the mouse (google search results)
https://bugs.webkit.org/show_bug.cgi?id=215641
<rdar://problem/67430532>

Reviewed by Tim Horton.
Source/WebCore:

There are two parts to this fix. First, findEnclosingScrollableContainer() needs
to use the same vertical-biasing delta fixup that we use in other places, to bias towards
vertical scrolling.

Second, when we've determined that the main frame should perform the scroll and dispatch
the wheel event to the scrolling thread, we used to hit-test from scratch on the scrolling
thread and and try to send the event to a scroller which we already know should not handle
it. So pass along a target ScrollingNodeID, and start the scrolling thread handling from
that node.

Test: fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html

page/FrameView.cpp: (WebCore::FrameView::wheelEvent):
page/mac/EventHandlerMac.mm: (WebCore::findEnclosingScrollableContainer):
page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::handleWheelEvent):
page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::handleWheelEvent): (WebCore::ScrollingTree::handleWheelEventWithNode):
page/scrolling/ScrollingTree.h:
page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEventAfterMainThread):
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::handleWheelEvent):
page/scrolling/nicosia/ScrollingCoordinatorNicosia.cpp: (WebCore::ScrollingCoordinatorNicosia::handleWheelEvent):
page/scrolling/nicosia/ScrollingCoordinatorNicosia.h:

LayoutTests:

After this change iframe-latch-small-deltas.html would time-out because WheelEventTestMonitor
would get stuck with a "content scrolling" defer region, due to begin/end wheel
events not getting both sent to the iframe. But the test was actually broken; logging shows
that it reset latching state anyway, and it's not testing the shipping configuration of
async iframe scrolling. So fix the test to use async iframe scrolling, and to avoid
rubber-banding, so that latching is not cleared due to elapsed time.

fast/scrolling/latching/iframe-latch-small-deltas-expected.txt:
fast/scrolling/latching/iframe-latch-small-deltas.html:
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas-expected.txt: Added.
fast/scrolling/mac/horizontal-overflow-trapping-small-deltas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266548] by Alan Coon

4 edits
2 adds in branches/safari-610-branch

Cherry-pick r266262. rdar://problem/67963581

Scrolling on select element doesn't work after scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=215900
Source/WebCore:

<rdar://problem/67766032>

Reviewed by Tim Horton.

The scrolling thread could use a node that was latched some time ago; we need to
check the freshness of the latched node before using it.

Test: fast/scrolling/latching/latching-stuck-to-main-page.html

page/scrolling/ScrollingTreeLatchingController.cpp: (WebCore::ScrollingTreeLatchingController::receivedWheelEvent): (WebCore::ScrollingTreeLatchingController::latchedNodeForEvent const): (WebCore::ScrollingTreeLatchingController::latchedNodeIsRelevant const):
page/scrolling/ScrollingTreeLatchingController.h:

LayoutTests:

Reviewed by Tim Horton.

fast/scrolling/latching/latching-stuck-to-main-page-expected.txt: Added.
fast/scrolling/latching/latching-stuck-to-main-page.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266547] by Alan Coon

7 edits
2 adds in branches/safari-610-branch

Cherry-pick r266248. rdar://problem/67963541

Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
https://bugs.webkit.org/show_bug.cgi?id=215892
<rdar://problem/67731156>

Reviewed by Tim Horton.

Source/WebCore:

While reverting the replaced string in Editor::changeBackToReplacedString, it's possible for text replacement
(Editor::replaceSelectionWithText) to cause the text checking paragraph range to become orphaned (if for no
reason other than the fact that arbitrary script can run in between). If this happens, then our attempts to
expand the checking range to paragraph boundaries underneath TextCheckingParagraph::paragraphRange will result
in a null dereference, since the boundary points computed underneath the expandToParagraphBoundary helper will
be nullopt.

Mitigate this (and any other potentially similar crashes) by making expandToParagraphBoundary robust in the
case where expanding to the start and end fails, and just fall back to returning the original text checking
range instead.

Test: editing/mac/input/change-back-to-replaced-string.html

editing/Editor.h:
editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary):

See above for more details.

testing/Internals.cpp: (WebCore::Internals::changeBackToReplacedString):
testing/Internals.h:
testing/Internals.idl:

Add a simple internal testing hook to change the currently selected text back to the given replaced string.

LayoutTests:

Add a layout test to exercise the crash.

editing/mac/input/change-back-to-replaced-string-expected.txt: Added.
editing/mac/input/change-back-to-replaced-string.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266546] by Alan Coon

2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266240. rdar://problem/67963550

REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests
https://bugs.webkit.org/show_bug.cgi?id=215861

Reviewed by Eric Carlson.

Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialized, which in the case of
AVPlayer does a bunch of work which shows up on power-use tests. Because the API being checked for will always exist
in macOS 11, and that code is already protected by a HAVE(AVPLAYER_VIDEORANGEOVERRIDE) pragma, just return early
here without running the +instancesRespondToSelector: check.

WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266545] by Alan Coon

3 edits
3 adds in branches/safari-610-branch

Cherry-pick r266239. rdar://problem/67963562

REGRESSION (r258215): Title preview movie isn't displayed at www.thismmalife.com
https://bugs.webkit.org/show_bug.cgi?id=215774
<rdar://problem/67707957>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-as-img-output-pts.html

Use CMSampleBufferGetOutputPresentationTimeStamp() for sample PTS.

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::storeSampleBuffer):

LayoutTests:

media/content/video-as-img.mp4: Added.
media/video-as-img-output-pts-expected.txt: Added.
media/video-as-img-output-pts.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266544] by Alan Coon

3 edits
2 adds in branches/safari-610-branch

Cherry-pick r266189. rdar://problem/68145721

Flickering on sedona.dev
https://bugs.webkit.org/show_bug.cgi?id=215141

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/canvas/webgl/compositing-without-drawing.html

Our logic to determine if a canvas needs to be "repainted"
was over-zealous for WebGL. We were marking any context
that called draw commands as dirty, but they could in fact
be rendering to an offscreen texture/framebuffer. Then, when
it came time to composite, we'd happily swap buffers and
show something that had never been rendered to.

The fix is simply to ignore any of the dirtying notifications
when we are not bound to the default (canvas) framebuffer.

html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver): Only mark if we're rendering to the default framebuffer.

LayoutTests:

Test that serves an animation frame that touches
WebGL, but not in a way that requires a recomposite.

fast/canvas/webgl/compositing-without-drawing-expected.html: Added.
fast/canvas/webgl/compositing-without-drawing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:30 PM Changeset in webkit [266543] by Alan Coon

5 edits
1 add in branches/safari-610-branch

Cherry-pick r266159. rdar://problem/67951883

[JSC] FTL should use m_origin instead of m_node->origin since m_node can be nullptr
https://bugs.webkit.org/show_bug.cgi?id=215833

Reviewed by Mark Lam.

JSTests:

stress/ftl-entry-osr-exit-has-nullptr-node.js: Added. (foo):

Source/JavaScriptCore:

While we are using m_node->origin, m_node can be nullptr (at the entry of the FTL function).
m_origin is always pointing appropriate origin. We should use it instead.

ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileToObjectOrCallObjectConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToThis): (JSC::FTL::DFG::LowerDFGToB3::compileValueAdd): (JSC::FTL::DFG::LowerDFGToB3::compileValueSub): (JSC::FTL::DFG::LowerDFGToB3::compileValueMul): (JSC::FTL::DFG::LowerDFGToB3::compileBinaryMathIC): (JSC::FTL::DFG::LowerDFGToB3::compileStrCat): (JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub): (JSC::FTL::DFG::LowerDFGToB3::compileArithClz32): (JSC::FTL::DFG::LowerDFGToB3::compileValueDiv): (JSC::FTL::DFG::LowerDFGToB3::compileValueMod): (JSC::FTL::DFG::LowerDFGToB3::compileArithAbs): (JSC::FTL::DFG::LowerDFGToB3::compileArithUnary): (JSC::FTL::DFG::LowerDFGToB3::compileValuePow): (JSC::FTL::DFG::LowerDFGToB3::compileArithRandom): (JSC::FTL::DFG::LowerDFGToB3::compileArithRound): (JSC::FTL::DFG::LowerDFGToB3::compileArithFloor): (JSC::FTL::DFG::LowerDFGToB3::compileArithCeil): (JSC::FTL::DFG::LowerDFGToB3::compileArithTrunc): (JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt): (JSC::FTL::DFG::LowerDFGToB3::compileArithFRound): (JSC::FTL::DFG::LowerDFGToB3::compileIncOrDec): (JSC::FTL::DFG::LowerDFGToB3::compileValueNegate): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitAnd): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitOr): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitXor): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitRShift): (JSC::FTL::DFG::LowerDFGToB3::compileValueBitLShift): (JSC::FTL::DFG::LowerDFGToB3::compileGetById): (JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis): (JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite): (JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree): (JSC::FTL::DFG::LowerDFGToB3::compileDefineDataProperty): (JSC::FTL::DFG::LowerDFGToB3::compileDefineAccessorProperty): (JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage): (JSC::FTL::DFG::LowerDFGToB3::compileGetPrototypeOf): (JSC::FTL::DFG::LowerDFGToB3::compileGetByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById): (JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById): (JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteById): (JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPush): (JSC::FTL::DFG::LowerDFGToB3::compileArraySlice): (JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf): (JSC::FTL::DFG::LowerDFGToB3::compileArrayPop): (JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope): (JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileNewFunction): (JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments): (JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly): (JSC::FTL::DFG::LowerDFGToB3::compileCreateRest): (JSC::FTL::DFG::LowerDFGToB3::compileObjectKeysOrObjectGetOwnPropertyNames): (JSC::FTL::DFG::LowerDFGToB3::compileObjectCreate): (JSC::FTL::DFG::LowerDFGToB3::compileNewSymbol): (JSC::FTL::DFG::LowerDFGToB3::compileNewArray): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSpread): (JSC::FTL::DFG::LowerDFGToB3::compileCreateThis): (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileSpread): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer): (JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize): (JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray): (JSC::FTL::DFG::LowerDFGToB3::compileToNumber): (JSC::FTL::DFG::LowerDFGToB3::compileToNumeric): (JSC::FTL::DFG::LowerDFGToB3::compileCallNumberConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf): (JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive): (JSC::FTL::DFG::LowerDFGToB3::compileToPropertyKey): (JSC::FTL::DFG::LowerDFGToB3::compileMakeRope): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode): (JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset): (JSC::FTL::DFG::LowerDFGToB3::compileGetGlobalThis): (JSC::FTL::DFG::LowerDFGToB3::compileGetArgument): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): (JSC::FTL::DFG::LowerDFGToB3::compileSameValue): (JSC::FTL::DFG::LowerDFGToB3::compileCallEval): (JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength): (JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs): (JSC::FTL::DFG::LowerDFGToB3::compileSwitch): (JSC::FTL::DFG::LowerDFGToB3::compileThrow): (JSC::FTL::DFG::LowerDFGToB3::compileThrowStaticError): (JSC::FTL::DFG::LowerDFGToB3::mapHashString): (JSC::FTL::DFG::LowerDFGToB3::compileMapHash): (JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket): (JSC::FTL::DFG::LowerDFGToB3::compileSetAdd): (JSC::FTL::DFG::LowerDFGToB3::compileMapSet): (JSC::FTL::DFG::LowerDFGToB3::compileTypeOfIsObject): (JSC::FTL::DFG::LowerDFGToB3::compileIsCallable): (JSC::FTL::DFG::LowerDFGToB3::compileIsConstructor): (JSC::FTL::DFG::LowerDFGToB3::compileInByVal): (JSC::FTL::DFG::LowerDFGToB3::compileHasOwnProperty): (JSC::FTL::DFG::LowerDFGToB3::compileParseInt): (JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom): (JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty): (JSC::FTL::DFG::LowerDFGToB3::compileHasStructurePropertyImpl): (JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname): (JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator): (JSC::FTL::DFG::LowerDFGToB3::compileToIndexString): (JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation): (JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps): (JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp): (JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName): (JSC::FTL::DFG::LowerDFGToB3::compileStringReplace): (JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenTail): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength): (JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee): (JSC::FTL::DFG::LowerDFGToB3::getArgumentsStart): (JSC::FTL::DFG::LowerDFGToB3::compare): (JSC::FTL::DFG::LowerDFGToB3::compileStringSlice): (JSC::FTL::DFG::LowerDFGToB3::compileToLowerCase): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithRadix): (JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScopeForHoistingFuncDeclInEval): (JSC::FTL::DFG::LowerDFGToB3::compileResolveScope): (JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOM): (JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter): (JSC::FTL::DFG::LowerDFGToB3::compileLoopHint): (JSC::FTL::DFG::LowerDFGToB3::genericJSValueCompare): (JSC::FTL::DFG::LowerDFGToB3::stringsEqual): (JSC::FTL::DFG::LowerDFGToB3::allocateJSArray): (JSC::FTL::DFG::LowerDFGToB3::boolify): (JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined): (JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds): (JSC::FTL::DFG::LowerDFGToB3::switchStringSlow): (JSC::FTL::DFG::LowerDFGToB3::buildTypeOf): (JSC::FTL::DFG::LowerDFGToB3::lazySlowPath): (JSC::FTL::DFG::LowerDFGToB3::masqueradesAsUndefinedWatchpointIsStillValid): (JSC::FTL::DFG::LowerDFGToB3::codeOriginDescriptionOfCallSite const): (JSC::FTL::DFG::LowerDFGToB3::callCheck): (JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):
jsc.cpp: (runJSC):
runtime/OptionsList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:04 PM Changeset in webkit [266542] by commit-queue@webkit.org

11 edits
8 adds in trunk

CoreImage Implementation of SourceGraphic and saturate(), hue-rotate(), grayscale() and sepia()
https://bugs.webkit.org/show_bug.cgi?id=213673

Patch by Frank Yang <guowei_yang@apple.com> on 2020-09-03
Reviewed by Darin Adler, Simon Fraser.

Source/WebCore:

Tests: css3/filters/effect-grayscale-square.html

css3/filters/effect-hue-rotate-square.html
css3/filters/effect-saturate-square.html
css3/filters/effect-sepia-square.html

Added CoreImage implementation of SourceGraphic and partial of FEColorMatrix,
which is used to implement sepia(), grayscale() hue-rotate() and saturate().
Also added CIFilter caching, by storing CIFilters in a hash map, where the key
is the level of traversal (an integer).

platform/graphics/coreimage/FilterEffectRendererCoreImage.h:

Imported FEColorMatrix.h and SourceGraphic.h; added function getCIContext()
that returns a static copy of CIContext.

platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::getCIContext): Creating a

CIContext is expensive. Instead of creating a CIContext on each frame
update, we just use a static singleton on every draw

(WebCore::FilterEffectRendererCoreImage::supportsCoreImageRendering):

the function now returns true if the filter chain contains SourceGraphic
and FEColorMatrix of TYPE_MATRIX, TYPE_SATURATE and TYPE_HUEROTATE

(WebCore::FilterEffectRendererCoreImage::connectCIFilters):

Made slight changes to wrap Obj-C pointers in RetainPtr

(WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic):

Use the source image to create a CIImage and return it. If the source image
is backed by IOSurface, we create a CIImage directly from the IOSurface; otherwise
we create a CIImage by getting the NativeImagePtr from source image.

(WebCore::FilterEffectRendererCoreImage::imageForFEColorMatrix):

Based on the type of the matrix and input parameter,
create different types of CIColorMatrix filers that are used to implement
sepia, grayscale, hue-rotate, saturate

(WebCore::FilterEffectRendererCoreImage::output const):

Added a logging line

(WebCore::FilterEffectRendererCoreImage::renderToImageBuffer):

Minor refactors

(WebCore::FilterEffectRendererCoreImage::clearResult):
(WebCore::FilterEffectRendererCoreImage::FilterEffectRendererCoreImage):

platform/graphics/filters/FEColorMatrix.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to FEColorMatrix

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputImageData const): removed

ASSERT(hasResult()); from the function, because CoreImage path wouldn't create
image buffers inside FilterEffect, but CI path still needs to consult this function
to obtain geometry info

platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filterEffectClassType const): Made the function a const
(WebCore::FilterEffect::normalizedFloats): Changed this function to public since it is

consulted in FilterEffectCoreImageRenderer.

(WebCore::FilterEffect::filterEffectClassType): Deleted.

platform/graphics/filters/SourceGraphic.h:

(isType): added SPECIALIZE_TYPE_TRAITS so that we can downcast to SourceGraphic

rendering/CSSFilter.cpp:

(WebCore::CSSFilter::build):

Checks whether m_filterRenderer is already created, no need to re-create if the pointer
is non-null

(WebCore::CSSFilter::allocateBackingStoreIfNeeded):

If we are using m_filterRenderer, which is currently using CoreImage and relies on
IOSurfaces, we ask source image to use IOSurface for performance concerns.

LayoutTests:

css3/filters/effect-grayscale-square-expected.html: Added.
css3/filters/effect-grayscale-square.html: Added.
css3/filters/effect-hue-rotate-square-expected.html: Added.
css3/filters/effect-hue-rotate-square.html: Added.
css3/filters/effect-saturate-square-expected.html: Added.
css3/filters/effect-saturate-square.html: Added.
css3/filters/effect-sepia-square-expected.html: Added.
css3/filters/effect-sepia-square.html: Added.
fast/filter-image/background-filter-image-expected.html:

This is the expected result for the background image filter. The background image
is not upsampled for retina screens due to a bug, so the test runner is comparing
an unscaled image with an upscaled-then-downscaled image. CoreImage handles upscaling
and downscaling differently, so the pixel diff will fail. Thus, turning off CI for this
particular test case until the background image filter not upsampling bug is fixed.

fast/filter-image/background-filter-image.html:

ditto

1:54 PM Changeset in webkit [266541] by Chris Dumez

4 edits in trunk

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies
https://bugs.webkit.org/show_bug.cgi?id=216130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-getFrequencyResponse-expected.txt:

Source/WebCore:

BiquadFilterNode.getFrequencyResponse() should return NaN for out-of-bounds frequencies.

No new tests, rebaselined existing test.

platform/audio/Biquad.cpp:

(WebCore::Biquad::getFrequencyResponse):

1:43 PM Changeset in webkit [266540] by Lauro Moura

2 edits in trunk/Tools

[GTK][WPE] generate-bundle: Remove the zip extension from the uploaded checksum filename
https://bugs.webkit.org/show_bug.cgi?id=216137

Reviewed by Jonathan Bedard.

Scripts/generate-bundle:

1:32 PM Changeset in webkit [266539] by commit-queue@webkit.org

11 edits
2 adds in trunk

Mark uniform samplers in an array unused per element
https://bugs.webkit.org/show_bug.cgi?id=215630

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-09-03
Reviewed by Dean Jackson.

Mark uniform samplers in an uniform sampler array unused per
element, if driver informs the element being unused.
Before, one element would mark the whole array as being
unused, and samplers that were in use would not be updated.

Source/ThirdParty/ANGLE:

src/libANGLE/Context.cpp:

(gl::StateCache::updateActiveImageUnitIndices):

src/libANGLE/Program.cpp:

(gl::SamplerBinding::SamplerBinding):
(gl::ImageBinding::ImageBinding):
(gl::Program::getSamplerUniformBinding const):
(gl::Program::getImageUniformBinding const):
(gl::Program::linkSamplerAndImageBindings):
(gl::Program::updateSamplerUniform):
(gl::Program::serialize const):
(gl::Program::deserialize):

src/libANGLE/ProgramExecutable.cpp:

(gl::ProgramExecutable::updateActiveSamplers):
(gl::ProgramExecutable::updateActiveImages):
(gl::ProgramExecutable::setSamplerUniformTextureTypeAndFormat):

src/libANGLE/ProgramExecutable.h:
src/libANGLE/renderer/gl/ProgramGL.cpp:

(rx::ProgramGL::markUnusedUniformLocations):

src/libANGLE/renderer/metal/ProgramMtl.mm:

(rx::ProgramMtl::updateTextures):

src/libANGLE/renderer/vulkan/ProgramExecutableVk.cpp:

(rx::ProgramExecutableVk::updateImagesDescriptorSet):
(rx::ProgramExecutableVk::updateTexturesDescriptorSet):

src/tests/gl_tests/ComputeShaderTest.cpp:
src/tests/gl_tests/UniformTest.cpp:

LayoutTests:

fast/canvas/webgl/glsl-sampler-array-unused-element-expected.txt: Added.
fast/canvas/webgl/glsl-sampler-array-unused-element.html: Added.

1:07 PM Changeset in webkit [266538] by Devin Rousso

24 edits
7 adds in trunk

Web Inspector: allow url breakpoints to be configured
https://bugs.webkit.org/show_bug.cgi?id=215793

Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/protocol/DOMDebugger.json:

Add an options parameter to DOMDebugger.setURLBreakpoint to allow configuration.
Add an isRegex parameter to DOMDebugger.removeURLBreakpoint so that we know what
type of URL breakpoint is being removed.

Source/WebCore:

Tests: inspector/dom-debugger/url-breakpoints.html

inspector/dom-debugger/url-breakpoints-all-requests.html
inspector/dom-debugger/url-breakpoints-containing.html
inspector/dom-debugger/url-breakpoints-matching.html

inspector/agents/InspectorDOMDebuggerAgent.h:
inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::setURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeURLBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::breakOnURLIfNeeded):

Source/WebInspectorUI:

UserInterface/Models/URLBreakpoint.js:

(WI.URLBreakpoint.get editable): Added.
(WI.URLBreakpoint.fromJSON):
(WI.URLBreakpoint.prototype.get editable):

UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager):
(WI.DOMDebuggerManager.prototype.initializeTarget):
(WI.DOMDebuggerManager.prototype.addURLBreakpoint):
(WI.DOMDebuggerManager.prototype.removeURLBreakpoint):
(WI.DOMDebuggerManager.prototype._setURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._removeURLBreakpoint): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointDisabledStateChanged):
(WI.DOMDebuggerManager.prototype._handleURLBreakpointEditablePropertyChanged): Added.
(WI.DOMDebuggerManager.prototype._handleURLBreakpointActionsChanged): Added.
(WI.DOMDebuggerManager.prototype._updateURLBreakpoint): Deleted.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialBreakpoint): Added.
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu.addToggleForSpecialEventBreakpoint): Deleted.

UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover.get editable):

UserInterface/Base/Setting.js:

LayoutTests:

inspector/debugger/resources/breakpoint-options-utilities.js:

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):

inspector/dom-debugger/resources/url-breakpoint-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.URLBreakpoint.teardown):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.createBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.addBreakpoint):
(TestPage.registerInitializer.InspectorTest.URLBreakpoint.request):

inspector/dom-debugger/url-breakpoints.html:
inspector/dom-debugger/url-breakpoints-expected.txt:
inspector/dom-debugger/url-breakpoints-all-requests.html: Added.
inspector/dom-debugger/url-breakpoints-all-requests-expected.txt: Added.
inspector/dom-debugger/url-breakpoints-containing.html: Added.
inspector/dom-debugger/url-breakpoints-containing-expected.txt: Added.
inspector/dom-debugger/url-breakpoints-matching.html: Added.
inspector/dom-debugger/url-breakpoints-matching-expected.txt: Added.

Split the one URL breakpoint test into four so they run quicker.

inspector/dom-debugger/resources/event-breakpoint-utilities.js:

(TestPage.registerInitializer.InspectorTest.EventBreakpoint.addBreakpointOptionsTestCases): Deleted.

inspector/dom-debugger/event-animation-frame-breakpoints.html:
inspector/dom-debugger/event-animation-frame-breakpoints-expected.txt:
inspector/dom-debugger/event-interval-breakpoints.html:
inspector/dom-debugger/event-interval-breakpoints-expected.txt:
inspector/dom-debugger/event-listener-breakpoints.html:
inspector/dom-debugger/event-listener-breakpoints-expected.txt:
inspector/dom-debugger/event-timeout-breakpoints.html:
inspector/dom-debugger/event-timeout-breakpoints-expected.txt:

Use InspectorTest.BreakpointOptions.addTestCases instead of duplicating the logic.

12:17 PM Changeset in webkit [266537] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: record button disappears when UI is narrow
https://bugs.webkit.org/show_bug.cgi?id=216133

Reviewed by Devin Rousso.

The record button is one of the most important items on Timelines toolbar.
It should always be visible.

UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):

11:42 AM Changeset in webkit [266536] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, reverting r266507.
https://bugs.webkit.org/show_bug.cgi?id=216135

Broke JSC EWS

Reverted changeset:

"kill-old-processes: Remove stale Apache2 shm segments"
https://bugs.webkit.org/show_bug.cgi?id=216068
https://trac.webkit.org/changeset/266507

11:21 AM Changeset in webkit [266535] by achristensen@apple.com

1 edit
1 delete in trunk/LayoutTests/imported/w3c

Remove unused test expectations file.

web-platform-tests/encoding/textdecoder-labels-expected.txt: Removed.

10:53 AM Changeset in webkit [266534] by Devin Rousso

35 edits
1 add in trunk

Web Inspector: allow special JavaScript breakpoints to be configured
https://bugs.webkit.org/show_bug.cgi?id=215794

Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/protocol/Debugger.json:

Add an options parameter to the following commands for configuring the related breakpoint:

Debugger.setPauseOnDebuggerStatements
Debugger.setPauseOnExceptions
Debugger.setPauseOnAssertions
Debugger.setPauseOnMicrotasks

debugger/Debugger.h:

(JSC::Debugger::needsExceptionCallbacks const):
(JSC::Debugger::pauseOnAllExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnAllExceptionsBreakpoint): Added.
(JSC::Debugger::pauseOnUncaughtExceptionsBreakpoint const): Added.
(JSC::Debugger::setPauseOnUncaughtExceptionsBreakpoint): Added.
(JSC::Debugger::setPauseOnDebuggerStatementsBreakpoint): Added.
(JSC::Debugger::pauseOnExceptionsState const): Deleted.
(JSC::Debugger::setPauseOnDebuggerStatements): Deleted.

debugger/Debugger.cpp:

(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::~TemporarilyDisableExceptionBreakpoints): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::replace): Added.
(JSC::Debugger::TemporarilyDisableExceptionBreakpoints::restore): Added.
(JSC::Debugger::Debugger):
(JSC::Debugger::breakProgram):
(JSC::Debugger::exception):
(JSC::Debugger::didReachDebuggerStatement):
(JSC::Debugger::setPauseOnExceptionsState): Deleted.
Add JSC::Breakpoint member variables for the Debugger Statements and Exceptions
breakpoints. Split the Exceptions breakpoint into two JSC::Breakpoint now that
All Exceptions and Uncaught Exceptions can be independently configured (the All
Exceptions breakpoint still takes precedence).

debugger/DebuggerCallFrame.h:
debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):
If there is no CallFrame, climb the backtrace until the first valid CallFrame is reached.
This is needed when pausing in native code, such as for assertions/exceptions.

debugger/Breakpoint.h:

Export JSC::Breakpoint::create so that other parts of WebKit can create breakpoints.

inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::handleConsoleAssert):
(Inspector::InspectorDebuggerAgent::setPauseOnDebuggerStatements):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::setPauseOnAssertions):
(Inspector::InspectorDebuggerAgent::setPauseOnMicrotasks):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
(Inspector::InspectorDebuggerAgent::willRunMicrotask):
(Inspector::InspectorDebuggerAgent::didRunMicrotask):
(Inspector::InspectorDebuggerAgent::breakProgram):
Add JSC::Breakpoint member variables for the Assertion Failures and All Microtasks
breakpoints. Pass them to the JSC::Debugger when they are hit.

inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::setPauseOnExceptionsState): Deleted.
Use TemporarilyDisableExceptionBreakpoints to save, override, and restore the exceptions
breakpoints now that they've been separated into two JSC::Breakpoint instead of an enum.

Source/WebInspectorUI:

UserInterface/Models/Breakpoint.js:

(WI.Breakpoint.prototype.reset): Added.
Provide a way to consistently clear the current configuration.

UserInterface/Models/JavaScriptBreakpoint.js:

(WI.JavaScriptBreakpoint.supportsMicrotasks): Added.
(WI.JavaScriptBreakpoint.supportsDebuggerStatements): Added.
(WI.JavaScriptBreakpoint.fromJSON):
(WI.JavaScriptBreakpoint.prototype.toJSON):
(WI.JavaScriptBreakpoint.prototype.get editable):
(WI.JavaScriptBreakpoint.prototype._isSpecial):

UserInterface/Models/SourceCodeLocation.js:

(WI.SourceCodeLocation.get specialBreakpointLocation): Added.
Add a helper for the special null:Infinity:Infinity breakpoint location for consistency.

UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.async initializeTarget):
(WI.DebuggerManager.prototype.createAssertionFailuresBreakpoint): Added.
(WI.DebuggerManager.prototype.createAllMicrotasksBreakpoint): Added.
(WI.DebuggerManager.prototype.set breakpointsEnabled):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype._setPauseOnExceptions): Added.
(WI.DebuggerManager.prototype._createSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._updateSpecialBreakpoint): Added.
(WI.DebuggerManager.prototype._breakpointDisabledStateDidChange):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
(WI.DebuggerManager.prototype._updateBreakOnExceptionsState): Deleted.
Maintain a WI.Setting for the configuration of each special WI.JavaScriptBreakpoint.
Have a common path for updating all special WI.JavaScriptBreakpoint to avoid duplicated
code.
Add methods for creating the Assertion Failures and All Microtasks WI.JavaScriptBreakpoint
since they can be removed (in addition to being disabled) and re-added.

UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.appendContextMenuItems):

UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement.prototype.ondelete):
If the WI.Breakpoint is not removable, make sure to reset it in addition to disabling
it so that no configuration persists if the WI.Breakpoint is later enabled.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointTreeOutlineElementRemoved): Added.
(WI.SourcesNavigationSidebarPanel.prototype._handleBreakpointElementAddedOrRemoved): Deleted.
Eliminate the need to listen for when breakpoints are added to the WI.TreeOutline, which
was previously used to update the WI.Setting for whether special WI.JavaScriptBreakpoint
are visible.
Don't assume that a WI.Breakpoint exists for each special WI.JavaScriptBreakpoint.

UserInterface/Base/Setting.js:

(WI.Setting):
(WI.Setting.migrateValue):
(WI.Setting.reset):
(WI.Setting.prototype.get value):
(WI.Setting.prototype.save):
(WI.Setting._localStorageKeyPrefix): Added.
(WI.Setting._localStorageKey): Deleted.
Eagerly compute the key prefix as it shouldn't change through the lifetime of Web Inspector
and is used early on too.
Add a static member isFirstLaunch which can be used by other WI.Setting to adjust their
value when Web Inspector is in a clean state (e.g. show the Assertion Failures breakpoint by
default, but only for the first launch). This is needed because WI.Setting clears the key
from localStorage if the current value matches the _defaultValue.

UserInterface/Models/ProbeSet.js:

(WI.ProbeSet):
(WI.ProbeSet.prototype.willRemove):
(WI.ProbeSet.prototype._sampleCollected):
(WI.ProbeSet.prototype._breakpointResolvedStateDidChange): Deleted.
Drive-by: remove an unused event.

Localizations/en.lproj/localizedStrings.js:

Source/WebKitLegacy/mac:

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):

LayoutTests:

inspector/debugger/resources/breakpoint-options-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases):
(TestPage.registerInitializer.InspectorTest.BreakpointOptions.addTestCases.removeBreakpoint):

inspector/debugger/break-on-exception.html:
inspector/debugger/break-on-exception-expected.txt:
inspector/debugger/break-on-uncaught-exception.html:
inspector/debugger/break-on-uncaught-exception-expected.txt:
inspector/debugger/setPauseOnAssertions.html:
inspector/debugger/setPauseOnAssertions-expected.txt:
inspector/debugger/setPauseOnDebuggerStatements.html:
inspector/debugger/setPauseOnDebuggerStatements-expected.txt:
inspector/debugger/setPauseOnMicrotasks.html:
inspector/debugger/setPauseOnMicrotasks-expected.txt:

Add tests for global JavaScript breakpoint configuration options.

10:53 AM Changeset in webkit [266533] by achristensen@apple.com

11 edits
1 delete in trunk

Implement TextEncoder's encodeInto()
https://bugs.webkit.org/show_bug.cgi?id=193274

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/encodeInto.any-expected.txt:
web-platform-tests/encoding/encodeInto.any.worker-expected.txt:
web-platform-tests/encoding/idlharness-expected.txt: Removed.
web-platform-tests/encoding/idlharness.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

bindings/js/JSDOMConvertBufferSource.h:

(WebCore::JSConverter<IDLUint8Array>::convertNewlyCreated):

dom/TextEncoder.cpp:

(WebCore::TextEncoder::encodeInto):

dom/TextEncoder.h:
dom/TextEncoder.idl:

10:39 AM Changeset in webkit [266532] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Finish comment describing the various *Stack SSA nodes in DFG
https://bugs.webkit.org/show_bug.cgi?id=216110

Reviewed by Sam Weinig.

dfg/DFGNodeType.h:

10:22 AM Changeset in webkit [266531] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length
<https://webkit.org/b/216092>

Reviewed by Tim Horton.

rendering/style/TextDecorationThickness.h:

(WebCore::TextDecorationThickness):

Add default initializer for m_length.

10:20 AM Changeset in webkit [266530] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

AbstractMacroAssembler::Jump class has uninitialized instance variables
<https://webkit.org/b/216082>

Reviewed by Michael Saboff.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump):

Switch to default constructor syntax.
Provide defaults for instance variables.

10:04 AM Changeset in webkit [266529] by Ross Kirsling

19 edits
1 add in trunk

[JSC] Add missing detached buffer errors for DataView
https://bugs.webkit.org/show_bug.cgi?id=216062

Reviewed by Yusuke Suzuki.

JSTests:

stress/detached-buffer-typeerror.js:

Add new test.

stress/dataview-jit-neuter.js:
stress/native-constructors-length.js:

Update existing tests.

test262/expectations.yaml:

Mark 74 test cases as passing.

Source/JavaScriptCore:

DataView methods are often expected to throw a TypeError if the underlying ArrayBuffer is detached
(or neutered, in older terminology) -- this patch adds a slew of missing cases from the following spec section:

https://tc39.es/ecma262/#sec-properties-of-the-dataview-prototype-object

At the same time:

get rid of JSDataView::getOwnPropertySlot, which was turning dataViewProtoGetterByte{Length,Offset} into mostly unreachable code and erroneously causing byte{Length,Offset} to have property descriptors
perform some simple cleanup of neighboring error calls / messages
fix value of DataView.length (our only other DataView spec bug)

runtime/JSDataView.cpp:

(JSC::JSDataView::create):
(JSC::JSDataView::getOwnPropertySlot): Deleted.

runtime/JSDataView.h:
runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):
(JSC::dataViewProtoGetterByteLength):
(JSC::dataViewProtoGetterByteOffset):

runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):

LayoutTests:

fast/canvas/webgl/arraybuffer-transfer-of-control.html:
js/dom/constructor-length.html:
js/script-tests/typedarray-constructors.js:
js/typedarray-constructors-expected.txt:
platform/glib/js/dom/constructor-length-expected.txt:
platform/ios/js/dom/constructor-length-expected.txt:
platform/mac/js/dom/constructor-length-expected.txt:
platform/win/js/dom/constructor-length-expected.txt:
platform/wincairo/js/dom/constructor-length-expected.txt:

Update tests and expectations.

9:57 AM Changeset in webkit [266528] by achristensen@apple.com

10 edits in trunk

TextDecoder should ignore byte-order-mark like other browsers and spec
https://bugs.webkit.org/show_bug.cgi?id=216108

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/streams/decode-ignore-bom.any-expected.txt:
web-platform-tests/encoding/textdecoder-ignorebom.any-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

dom/TextDecoder.cpp:

(WebCore::TextDecoder::ignoreBOMIfNecessary):
(WebCore::TextDecoder::decode):
(WebCore::TextDecoder::prependBOMIfNecessary): Deleted.

dom/TextDecoder.h:

9:33 AM Changeset in webkit [266527] by achristensen@apple.com

18 edits
2 adds in trunk

Align ISO-8859-{3,6,7,8,8-I} and windows-{874,1253,1255,1257} encodings with Chrome, Firefox, and the specification
https://bugs.webkit.org/show_bug.cgi?id=216094

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/single-byte-decoder-expected.txt:
web-platform-tests/encoding/textdecoder-fatal-single-byte.any-expected.txt:
web-platform-tests/encoding/textdecoder-fatal-single-byte.any.worker-expected.txt:

Source/WebCore:

Covered by newly passing web platform tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/text/TextCodec.h:
platform/text/TextCodecCJK.cpp:

(WebCore::Function<void):

platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

platform/text/TextCodecSingleByte.cpp: Added.

(WebCore::tableForDecoding):
(WebCore::tableForEncoding):
(WebCore::TextCodecSingleByte::encode):
(WebCore::TextCodecSingleByte::decode):
(WebCore::TextCodecSingleByte::TextCodecSingleByte):
(WebCore::TextCodecSingleByte::registerEncodingNames):
(WebCore::TextCodecSingleByte::registerCodecs):

platform/text/TextCodecSingleByte.h: Copied from Source/WebCore/platform/text/TextCodec.h.

LayoutTests:

fast/encoding/char-decoding-expected.txt:
fast/encoding/char-decoding.html:
platform/ios/TestExpectations:
platform/mac/TestExpectations:

9:31 AM Changeset in webkit [266526] by graouts@webkit.org

4 edits
2 adds in trunk

Consecutive requestAnimationFrame callbacks may be passed the same timestamp
https://bugs.webkit.org/show_bug.cgi?id=216122
<rdar://problem/68269445>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/animation/request-animation-frame-unique-timestamp.html

Ensure that the page only sees increasing timestamps in requestAnimationFrame() callbacks.

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::shouldRescheduleRequestAnimationFrame const):

LayoutTests:

Add a test that two subsequent animation frames as identified via requestAnimationFrame() callbacks
are provided increasing timestamps.

Also removing flaky expectation for two WPT animations tests which pass reliably after this fix.

fast/animation/request-animation-frame-unique-timestamp-expected.txt: Added.
fast/animation/request-animation-frame-unique-timestamp.html: Added.
platform/mac-wk2/TestExpectations:

9:28 AM Changeset in webkit [266525] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION(r266466): [ iOS wk2 ] fast/encoding/charset-replacement.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216126

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

9:28 AM Changeset in webkit [266524] by Aditya Keerthi

10 edits in trunk

[macOS] Support stepping using keyboard in date inputs
https://bugs.webkit.org/show_bug.cgi?id=216090

Reviewed by Darin Adler.

Source/WebCore:

Users should be able to step through dates using the up and down arrow
keys, matching the functionality of NSDatePicker. To achieve this
functionality, stepUp and stepDown methods were added to
DateTimeFieldElement, incrementing and decrementing the value of the
focused field on an up arrow keypress and a down arrow keypress
respectively. If the currently focused field is empty during the
keypress, stepping up will start from the minimum value and stepping
down will start from the maximum value.

Covered by a new test case in an existing test file.

html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

html/shadow/DateTimeFieldElement.h:
html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::setValueAsIntegerByStepping):
(WebCore::DateTimeNumericFieldElement::stepDown):
(WebCore::DateTimeNumericFieldElement::stepUp):

html/shadow/DateTimeNumericFieldElement.h:
html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):

html/shadow/DateTimeSymbolicFieldElement.h:

LayoutTests:

Added a new test case to the existing set of keyboard testcases for editable date inputs.

fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:

9:27 AM Changeset in webkit [266523] by weinig@apple.com

78 edits
1 move
2 adds in trunk/Source/WebCore

Update WebIDL parser to more closely align with current WebIDL spec
https://bugs.webkit.org/show_bug.cgi?id=216089

Reviewed by Chris Dumez.

Major changes are:

'implements' keyword is now called 'includes' (this is the only observable change).
Added support for parsing namespaces, async iterable, partial mixins and ObservableArray, though the code generators don't support them yet, so they just clearly error out.
Update list of keywords that can be used as argument names.
Update parser to use the current terminology from WebIDL.
Added more comments to be clear what next steps to take such as removing legacy constructs like serializer, exception, legacycaller and moving synthetic operation additions from the parser to the code generators.

Modules/fetch/FetchRequest.idl:
Modules/fetch/FetchResponse.idl:
bindings/scripts/IDLParser.pm:

(Parse):
(applyTypedefs):
(parseDefinition):
(parseCallbackOrInterfaceOrMixin):
(parseCallbackRestOrInterface):
(parseInterfaceOrMixin):
(parseInterface):
(parseNamespace):
(parseNamespaceMembers):
(parseNamespaceMember):
(parsePartialDefinition):
(parsePartialInterfaceOrPartialMixin):
(parsePartialInterface):
(parsePartialInterfaceMembers):
(parsePartialInterfaceMember):
(parseInterfaceMember):
(parsePartialDictionary):
(parseIncludesStatement):
(parseInheritAttribute):
(parseOperation):
(parseRegularOperation):
(parseSpecial):
(parseAsyncIterable):
(parseOptionalIterableInterface):
(parseArgumentNameKeyword):
(parseDistinguishableType):
(parseConstType):
(parsePrimitiveType):
(applyMemberList):
(parseCallbackOrInterface): Deleted.
(parseImplementsStatement): Deleted.
(parseOperationOrReadWriteAttributeOrMaplike): Deleted.
(parseReadWriteAttribute): Deleted.
(parseInherit): Deleted.

bindings/scripts/preprocess-idls.pl:

(getIncludedInterfacesFromIDL):
(getImplementedInterfacesFromIDL): Deleted.

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttrGetter):
(WebCore::jsTestInterfaceConstructorIncludesStaticAttr):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttrSetter):
(WebCore::setJSTestInterfaceConstructorIncludesStaticAttr):
(WebCore::jsTestInterfaceIncludesStr1Getter):
(WebCore::jsTestInterfaceIncludesStr1):
(WebCore::jsTestInterfaceIncludesStr2Getter):
(WebCore::jsTestInterfaceIncludesStr2):
(WebCore::setJSTestInterfaceIncludesStr2Setter):
(WebCore::setJSTestInterfaceIncludesStr2):
(WebCore::jsTestInterfaceIncludesStr3Getter):
(WebCore::jsTestInterfaceIncludesStr3):
(WebCore::setJSTestInterfaceIncludesStr3Setter):
(WebCore::setJSTestInterfaceIncludesStr3):
(WebCore::jsTestInterfaceIncludesNodeGetter):
(WebCore::jsTestInterfaceIncludesNode):
(WebCore::setJSTestInterfaceIncludesNodeSetter):
(WebCore::setJSTestInterfaceIncludesNode):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod1):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod2):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3Body):
(WebCore::jsTestInterfacePrototypeFunctionIncludesMethod3):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4Body):
(WebCore::jsTestInterfaceConstructorFunctionIncludesMethod4):
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttrGetter): Deleted.
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttrSetter): Deleted.
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr): Deleted.
(WebCore::jsTestInterfaceImplementsStr1Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr1): Deleted.
(WebCore::jsTestInterfaceImplementsStr2Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr2): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr2): Deleted.
(WebCore::jsTestInterfaceImplementsStr3Getter): Deleted.
(WebCore::jsTestInterfaceImplementsStr3): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3Setter): Deleted.
(WebCore::setJSTestInterfaceImplementsStr3): Deleted.
(WebCore::jsTestInterfaceImplementsNodeGetter): Deleted.
(WebCore::jsTestInterfaceImplementsNode): Deleted.
(WebCore::setJSTestInterfaceImplementsNodeSetter): Deleted.
(WebCore::setJSTestInterfaceImplementsNode): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3Body): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4Body): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4): Deleted.

bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/SupplementalDependencies.dep:
bindings/scripts/test/TestImplements.idl: Removed.
bindings/scripts/test/TestIncludes.idl: Copied from Source/WebCore/bindings/scripts/test/TestImplements.idl.
bindings/scripts/test/TestInterface.idl:
bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestOperationConditional.idl:
dom/CharacterData.idl:
dom/DeviceMotionEvent.idl:
dom/DeviceOrientationEvent.idl:
dom/Document.idl:
dom/DocumentFragment.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/ShadowRoot.idl:
dom/Text.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBodyElement.idl:
html/HTMLElement.idl:
html/HTMLFrameSetElement.idl:
html/canvas/CanvasRenderingContext2D.idl:
html/canvas/OffscreenCanvasRenderingContext2D.idl:
html/canvas/PaintRenderingContext2D.idl:
html/canvas/Path2D.idl:
html/canvas/WebGL2RenderingContext.idl:
html/canvas/WebGLRenderingContext.idl:
page/DOMWindow.idl:
page/Navigator.idl:
page/WorkerNavigator.idl:
svg/SVGAElement.idl:
svg/SVGAltGlyphElement.idl:
svg/SVGAnimationElement.idl:
svg/SVGCursorElement.idl:
svg/SVGElement.idl:
svg/SVGFEBlendElement.idl:
svg/SVGFEColorMatrixElement.idl:
svg/SVGFEComponentTransferElement.idl:
svg/SVGFECompositeElement.idl:
svg/SVGFEConvolveMatrixElement.idl:
svg/SVGFEDiffuseLightingElement.idl:
svg/SVGFEDisplacementMapElement.idl:
svg/SVGFEDropShadowElement.idl:
svg/SVGFEFloodElement.idl:
svg/SVGFEGaussianBlurElement.idl:
svg/SVGFEImageElement.idl:
svg/SVGFEMergeElement.idl:
svg/SVGFEMorphologyElement.idl:
svg/SVGFEOffsetElement.idl:
svg/SVGFESpecularLightingElement.idl:
svg/SVGFETileElement.idl:
svg/SVGFETurbulenceElement.idl:
svg/SVGFilterElement.idl:
svg/SVGGlyphRefElement.idl:
svg/SVGGradientElement.idl:
svg/SVGGraphicsElement.idl:
svg/SVGImageElement.idl:
svg/SVGMPathElement.idl:
svg/SVGMarkerElement.idl:
svg/SVGMaskElement.idl:
svg/SVGPatternElement.idl:
svg/SVGSVGElement.idl:
svg/SVGScriptElement.idl:
svg/SVGSymbolElement.idl:
svg/SVGTRefElement.idl:
svg/SVGTextPathElement.idl:
svg/SVGUseElement.idl:
svg/SVGViewElement.idl:
svg/SVGViewSpec.idl:
workers/Worker.idl:
workers/WorkerGlobalScope.idl:
workers/service/ServiceWorker.idl:

9:14 AM Changeset in webkit [266522] by achristensen@apple.com

1 edit
1 copy in trunk/LayoutTests

Rebase Windows test expectations after r266466

9:11 AM Changeset in webkit [266521] by achristensen@apple.com

2 edits in trunk/LayoutTests

Rebase iOS test results after r266399
https://bugs.webkit.org/show_bug.cgi?id=216022

platform/ios/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:

9:06 AM Changeset in webkit [266520] by achristensen@apple.com

12 edits in trunk

Align EUC-KR encoding with Chrome, Firefox, and specification
https://bugs.webkit.org/show_bug.cgi?id=216081

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-errors-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-misc-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han-expected.txt:
web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-misc-expected.txt:

Source/WebCore:

Covered by web platform tests.

platform/text/EncodingTables.cpp:
platform/text/EncodingTables.h:
platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucKREncodingIndex):
(WebCore::eucKREncode):
(WebCore::TextCodecCJK::eucKRDecode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode):

platform/text/TextCodecCJK.h:
platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerCodecs):

9:05 AM Changeset in webkit [266519] by Hector Lopez

2 edits in trunk/LayoutTests

REGRESSION(266399?): [ iOS wk2 ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216124

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

8:33 AM Changeset in webkit [266518] by Chris Dumez

11 edits in trunk

Make our implementation of ChannelMergerNode standards compliant
https://bugs.webkit.org/show_bug.cgi?id=216113

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that they are passing.

web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-disconnect-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-expected.txt:
web-platform-tests/webaudio/the-audio-api/the-channelmergernode-interface/audiochannelmerger-input-non-default-expected.txt:

Source/WebCore:

This aligns our implementation of ChannelMergerNode with Chromium's, allowing us
to pass more web platform tests.

No new tests, rebaselined existing tests.

Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
(WebCore::AudioNode::disableOutputs):

Modules/webaudio/AudioNode.h:

Split disableOutputs() out of disableOutputsIfNecessary() so that it can be called
directly.

Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::connect):

Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::isEnabled const):
When connected to an output, AudioNodeInput keeps the output either in m_outputs when
the output is enabled, m_disabledOutputs when it is disabled. AudioNodeInput's enable()
& disable() take care of moving the output from one map to another. However, connect()
would assume that the output we're connecting to is enabled and add it to m_outputs
unconditionally. This was causing an assertion to get hit in enable() later on because
the output we're trying to enable was not in m_disabledOutputs (because it was already
in m_outputs). This change is needed because the ChannelMergerNode now disables its
output right away, before it is connected.

Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):
Make sure that the output has a number of channels equal to the number of inputs.
Initially disable outputs so that we output a single silent channel until something
is connected.

(WebCore::ChannelMergerNode::process):

Modules/webaudio/ChannelMergerNode.h:

Simplify code now that the number of inputs is equal to output's number of channels.

8:29 AM Changeset in webkit [266517] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Use unicode macros instead of manual range checks in TextCodecUTF16
https://bugs.webkit.org/show_bug.cgi?id=216098

Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-03
Reviewed by Darin Adler.

No change in behavior. Just responding to feedback from bug 216058.

platform/text/TextCodecSingleByte.cpp: Added.

platform/text/TextCodecSingleByte.h: Added.
platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::decode):

7:56 AM Changeset in webkit [266516] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-bottom
https://bugs.webkit.org/show_bug.cgi?id=215538
<rdar://problem/67613372>

Reviewed by Antti Koivisto.

Source/WebCore:

See https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + descent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-bottom-nested.html

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

fast/layoutformattingcontext/vertical-align-bottom-nested-expected.html: Added.
fast/layoutformattingcontext/vertical-align-bottom-nested.html: Added.

7:51 AM Changeset in webkit [266515] by Alan Bujtas

3 edits
2 adds in trunk

[LFC][IFC] Add support for vertical-align: text-top
https://bugs.webkit.org/show_bug.cgi?id=215545
<rdar://problem/67629969>

Reviewed by Antti Koivisto.

Source/WebCore:

See https://www.w3.org/TR/css-inline-3/#propdef-alignment-baseline
(align with the baseline + ascent of the parent inline box)

Test: fast/layoutformattingcontext/vertical-align-top-nested.html

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight):

LayoutTests:

fast/layoutformattingcontext/vertical-align-top-nested-expected.html: Added.
fast/layoutformattingcontext/vertical-align-top-nested.html: Added.

7:40 AM Changeset in webkit [266514] by Aditya Keerthi

15 edits in trunk

[macOS] Add disabled and readonly behaviors to date inputs
https://bugs.webkit.org/show_bug.cgi?id=216005

Reviewed by Devin Rousso.

Source/WebCore:

Added methods to EditControlOwner and FieldOwner so that
DateTimeEditElement and DateTimeFieldElement are aware of the readonly
and disabled states of their containing element.

Disabled inputs should not be focusable and should not respond to any
keyboard events. On the other hand, readonly inputs should respond to
some keyboard events (such as left arrow, right arrow, and the tab
key), but should not be editable.

css/html.css: Updated to add GrayText color for disabled fields.

(input[disabled]::-webkit-datetime-edit-year-field,):

html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerDisabled const):
(WebCore::BaseChooserOnlyDateAndTimeInputType::isEditControlOwnerReadOnly const):

html/BaseChooserOnlyDateAndTimeInputType.h:
html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabled const):
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly const):

html/shadow/DateTimeEditElement.h:
html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):

If the owning element is disabled or readonly, elide a call to
handleKeyboardEvent, which is implemented by subclasses to achieve
editability.

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Disabled inputs should not respond to any events.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled const):
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly const):
(WebCore::DateTimeFieldElement::isFocusable const): Disabled inputs should not be focusable.

html/shadow/DateTimeFieldElement.h:

LayoutTests:

Added tests for disabled and readonly date inputs in existing test files.

fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events-expected.txt:
fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html:
fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
fast/forms/date/date-editable-components/date-editable-components-mouse-events-expected.txt:
fast/forms/date/date-editable-components/date-editable-components-mouse-events.html:

7:20 AM Changeset in webkit [266513] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
https://bugs.webkit.org/show_bug.cgi?id=216101

Reviewed by Tim Horton.

The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time under RenderLayer::paintLayerByApplyingTransform just
inverting the transformation matrix (underneath TransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.

TransformationMatrix::inverse() currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.

However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.

We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition of TransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks in TransformationMatrix::inverse().

We also apply a similar optimization to TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.

I measured this locally to be a (statistically significant) 2% improvement on Multiply.

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::isInvertible const):
(WebCore::TransformationMatrix::inverse const):

platform/graphics/transforms/TransformationMatrix.h:

(WebCore::TransformationMatrix::type const):

7:19 AM Changeset in webkit [266512] by Diego Pino Garcia

2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Mark more convolver related tests as flaky crash.

platform/gtk/TestExpectations:

6:24 AM Changeset in webkit [266511] by youenn@apple.com

14 edits in trunk

Expose RTCPeerConnection.restartIce
https://bugs.webkit.org/show_bug.cgi?id=216072

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCPeerConnection-restartIce.https-expected.txt:
web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/WebCore:

Add plubming code to expose restartIce.
Covered by rebased test.

Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::restartIce):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::restartIce):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

TestExpectations:

4:22 AM Changeset in webkit [266510] by Alan Bujtas

5 edits
4 adds in trunk

Source/WebCore:
[LFC][IFC] Add support nested inline box sizing and positioning
https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

This patch splits the line box construction process into a few distinct steps.

Construct the inline boxes as needed. There's always a root inline box.
Size them by taking the vertical alignment into account
- child inline boxes stretch their parent inline boxes in most cases (depending on the vertical-align property value).
Position the inline boxes relative to the line box.

Test: fast/layoutformattingcontext/vertical-align-middle-nested.html

fast/layoutformattingcontext/vertical-align-middle-simple.html

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineHeight):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const): Deleted.
(WebCore::Layout::LineBox::alignVertically): Deleted.

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::setLogicalHeight):
(WebCore::Layout::LineBox::InlineBox::setBaseline):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):

LayoutTests:
[LFC][IFC] Fix nested inline box sizing and positioning
https://bugs.webkit.org/show_bug.cgi?id=215748

Reviewed by Antti Koivisto.

fast/layoutformattingcontext/vertical-align-middle-nested-expected.html:
fast/layoutformattingcontext/vertical-align-middle-nested.html:
fast/layoutformattingcontext/vertical-align-middle-simple-expected.html:
fast/layoutformattingcontext/vertical-align-middle-simple.html:

3:15 AM Changeset in webkit [266509] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC][IFC] Finalize InlineBox alignment in LineBox
https://bugs.webkit.org/show_bug.cgi?id=215410

Reviewed by Antti Koivisto.

This patch completes the InlineBox transition.

LineBox now has a dedicated root inline box and additional inline boxes as needed.
Both horizontal and vertical alignments are performed on the inline boxes as opposed to on the runs.

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::constraintsForLine):
(WebCore::Layout::InlineFormattingContext::setDisplayBoxesForLine):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextQuirks.cpp:

(WebCore::Layout::InlineFormattingContext::Quirks::initialLineHeight const):

layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::halfLeadingMetrics):
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_inlineFormattingContext):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox const):
(WebCore::Layout::LineBox::inlineRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
(WebCore::Layout::LineBox::alignVertically):
(WebCore::Layout::LineBox::rectForRun const): Deleted.
(WebCore::Layout::LineBox::alignHorizontally): Deleted.
(WebCore::Layout::LineBox::adjustBaselineAndLineHeight): Deleted.
(WebCore::Layout::LineBox::collectHangingContent const): Deleted.

layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::AscentAndDescent::height const):
(WebCore::Layout::LineBox::InlineBox::logicalRect const):
(WebCore::Layout::LineBox::InlineBox::logicalTop const):
(WebCore::Layout::LineBox::InlineBox::logicalLeft const):
(WebCore::Layout::LineBox::InlineBox::logicalWidth const):
(WebCore::Layout::LineBox::InlineBox::logicalHeight const):
(WebCore::Layout::LineBox::InlineBox::baseline const):
(WebCore::Layout::LineBox::InlineBox::descent const):
(WebCore::Layout::LineBox::InlineBox::setLogicalTop):
(WebCore::Layout::LineBox::InlineBox::setLogicalWidth):
(WebCore::Layout::LineBox::InlineBox::isAtomicInlineLevelBox const):
(WebCore::Layout::LineBox::InlineBox::setHasStrut):
(WebCore::Layout::LineBox::InlineBox::hasStrut const):
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::AscentAndDescent::height const): Deleted.
(WebCore::Layout::LineBox::ascentAndDescent const): Deleted.
(WebCore::Layout::LineBox::setScrollableOverflow): Deleted.
(WebCore::Layout::LineBox::InlineBox::InlineBox): Deleted.
(WebCore::Layout::LineBox::setLogicalHeightIfGreater): Deleted.
(WebCore::Layout::LineBox::setAlignmentBaselineIfGreater): Deleted.
(WebCore::Layout::LineBox::setAscentIfGreater): Deleted.
(WebCore::Layout::LineBox::setDescentIfGreater): Deleted.
(WebCore::Layout::LineBox::halfLeadingMetrics): Deleted.

layout/inlineformatting/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::Run::logicalRight const):

1:38 AM Changeset in webkit [266508] by youenn@apple.com

6 edits in trunk

calling transceiver setCodecPreferences doesn't change the order of codecs in the offer/answer generated by the browser
https://bugs.webkit.org/show_bug.cgi?id=215567
<rdar://problem/67277554>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences-expected.txt:
web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html:

Source/WebCore:

Make sure to serialize sdpFmtp information so that setCodecPreferences succeeds.
Also make sure to throw the exception if there is any.

Covered by updated imported/w3c/web-platform-tests/webrtc/RTCRtpTransceiver-setCodecPreferences.html.

Modules/mediastream/RTCRtpTransceiver.idl:
platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::toRTCRtpCapabilities):

1:07 AM Changeset in webkit [266507] by Diego Pino Garcia

2 edits in trunk/Tools

kill-old-processes: Remove stale Apache2 shm segments
https://bugs.webkit.org/show_bug.cgi?id=216068

Reviewed by Alexey Proskuryakov.

When Apache2 terminates abruptely, it may not free up allocated shared
memory segments. When later Apache2 is started again, if its pid
matches the pid of orphan shm segments it fails believing there's
already an Apache2 instance running. To avoid this situation, after
killing Apache2 we check for potential conflicting shm segments and
remove them.

BuildSlaveSupport/kill-old-processes:

(listAllWebKitPrograms):
(removeOrphanShmSegmentsOf):
(removeShmSegments):
(removeShmSegment):
(cmd):
(allShmSegments):
(main):

12:48 AM Changeset in webkit [266506] by rniwa@webkit.org

2 edits in trunk/Tools

Static assert the return type of compactMap
https://bugs.webkit.org/show_bug.cgi?id=216119

Reviewed by Darin Adler.

Added static_assert for the return types of compactMap in varoius unit tests.

(WTF_Vector.CompactMapStaticFunctionReturnOptional):
(WTF_Vector.CompactMapStaticFunctionReturnRefPtr):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRef):
(WTF_Vector.CompactMapStaticFunctionReturnOptionalRefPtr):
(WTF_Vector.CompactMapLambdaReturnOptional):
(WTF_Vector.CompactMapLambdaCopyVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaMoveVectorReturnOptionalCountedObject):
(WTF_Vector.CompactMapLambdaReturnRefPtr):
(WTF_Vector.CompactMapLambdaReturnRefPtrFromMovedRef):
(WTF_Vector.CompactMapLambdaReturnOptionalRefPtr):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed