Timeline
Sep 19, 2020:
- 9:32 PM Changeset in webkit [267323] by
-
- 2 edits in trunk/Tools
[GLIB] Merge API test expectations
Unreviewed test gardening.
Two TestUIClient sections were causing the first one to be ignored.
- TestWebKitAPI/glib/TestExpectations.json:
- 9:30 PM Changeset in webkit [267322] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed gardening.
- platform/glib/TestExpectations:
- 7:51 PM Changeset in webkit [267321] by
-
- 20 edits in trunk/LayoutTests
Selection API: Update some more tests so they don't accidentally rely on flaws in WebKit's old implementation
https://bugs.webkit.org/show_bug.cgi?id=216737
Reviewed by Sam Weinig.
Like the three tests I modified in r267220, these tests are accidentally
depending on the fact that our selection object implementation currently
allows invalid indexes. It's clear that these are mistakes in the tests,
not intentional, and fixing these does not change the test expectations,
only the tests themselves.
- accessibility/mac/select-text-should-match-whole-words.html: Set the selection
with separate calls to the collapse function. The old code tried to reuse the
same range to set the selection back to an old value, but that won't work if
the selection updates the range (as it is supposed to do).
- editing/execCommand/indent-selection.html: Pass a valid index, 1, instead of
an invalid one, 2.
- editing/pasteboard/paste-visible-script.html: Ditto.
- editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html:
Pass a valid index, 0, instead of an invalid one, 10500000000. Also fixed line
endings in this file, which were all Windows-style CR/LF pairs to be Unix-style
LF like most of our other files.
- editing/pasteboard/testcase-9507.html: Use childNodes.length to compute a
valid index instead of passing 5, which was an invalid one.
- editing/style/apply-style-crash2.html: Pass a valid index, 0, instead of
an invalid one, 4.
- editing/style/query-typing-style.html: Pass a valid index, 0, instead of
an invalid one, 1.
- editing/undo/undo-paste-when-caret-is-not-in-range.html: Pass valid index
1 instead of invalid ones, 3 and 4.
- fast/block/float/float-list-changed-before-layout-crash.html: Pass a valid
index, 0, instead of an invalid one, 1.
- fast/dynamic/checkbox-selection-crash.html: Use childNodes.length to compute
a valid index instead of passing 1000, which was an invalid one.
- fast/repaint/selection-gap-absolute-child.html: Pass a valid index, 0, instead
of an invalid one, 1.
- fast/repaint/selection-gap-fixed-child.html: Ditto.
- fast/repaint/selection-gap-flipped-absolute-child.html: Ditto.
- fast/repaint/selection-gap-flipped-fixed-child.html: Ditto.
- fast/repaint/selection-gap-transformed-absolute-child.html: Ditto.
- fast/repaint/selection-gap-transformed-fixed-child.html: Ditto.
- fast/replaced/selection-rect.html: Select the image with a range in its
parent node with valid indices instead of relying WebKit's quirky way of
expressing selections of replaced elements, which involves an invalid index
of 1 for an image element with no children. This test has nothing to do with
the particular selection range technique used, so it's fine to change it.
- http/tests/security/resources/foreign-domain-iframe-for-selection-test.html:
Use childNodes.length to compute a valid index instead of passing 10, which was
an invalid one.
- imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html:
Use a valid index, 0, instead of an invalid one, 4.
- 11:52 AM Changeset in webkit [267320] by
-
- 5 edits in trunk/Source/WebCore
Implementation for AXIsolatedObject::nextSibling and previousSibling.
https://bugs.webkit.org/show_bug.cgi?id=216710
Reviewed by Chris Fleizach.
Implementation for AXIsolatedObject::previousSibling and nextSibling which
are invoked by VoiceOver in Safari Reader mode.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::previousSibling const):
- Fixed crash caused by dereferencing m_renderer->parent() which can be null.
- Added check for the AXObjectCache that can become null.
(WebCore::AccessibilityRenderObject::nextSibling const):
- Code style cleanup.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- Added caching of next/previousSiblling objects.
(WebCore::AXIsolatedObject::previousSibling const): Inlined in header..
(WebCore::AXIsolatedObject::nextSibling const): Inlined in header.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/isolatedtree/AXIsolatedTree.h:
- 10:43 AM Changeset in webkit [267319] by
-
- 1 copy in tags/Safari-610.2.6.1.3
Tag Safari-610.2.6.1.3.
- 10:39 AM Changeset in webkit [267318] by
-
- 1 edit in branches/safari-610.2.6.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp
Cherry-pick r266958. rdar://problem/69202514
Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.
- UIProcess/mac/DisplayLink.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:37 AM Changeset in webkit [267317] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.3
- 10:07 AM Changeset in webkit [267316] by
-
- 10 edits in trunk
Performance and PerformanceNavigation interfaces are missing toJSON operations
https://bugs.webkit.org/show_bug.cgi?id=216728
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update results now that we pass more subtests.
- web-platform-tests/hr-time/idlharness.any-expected.txt:
- web-platform-tests/hr-time/idlharness.any.worker-expected.txt:
- web-platform-tests/hr-time/performance-tojson-expected.txt:
Source/WebCore:
Add missing toJSON operations to Performance and PerformanceNavigation and update
comments in related IDLs.
Updates results for existing tests, more of which now pass.
- page/Performance.idl:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.idl:
- page/PerformanceNavigation.idl:
- page/PerformanceTiming.idl:
- 9:46 AM Changeset in webkit [267315] by
-
- 5 edits in trunk/Source/WebCore
[LFC][IFC] InlineFormattingContext::computeGeometryForLineContent should not construct Display::Lines
https://bugs.webkit.org/show_bug.cgi?id=216723
Reviewed by Antti Koivisto.
Display::Lines construction should live in the display builder. However currently we don't yet have a real builder, so let's
just use the integration layer.
This is also in preparation for removing all the Display::InlineContent code from the Layout namespace.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::LineLayout::constructDisplayContent):
- layout/integration/LayoutIntegrationLineLayout.h:
- 8:05 AM Changeset in webkit [267314] by
-
- 8 edits1 copy1 move12 adds2 deletes in trunk/LayoutTests
Resync web-platform-tests/hr-time from upstream
https://bugs.webkit.org/show_bug.cgi?id=216724
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Resync web-platform-tests/hr-time from upstream.
- web-platform-tests/hr-time/META.yml: Added.
- web-platform-tests/hr-time/OWNERS: Removed.
- web-platform-tests/hr-time/idlharness-expected.txt: Removed.
- web-platform-tests/hr-time/idlharness.any-expected.txt: Added.
- web-platform-tests/hr-time/idlharness.any.html: Added.
- web-platform-tests/hr-time/idlharness.any.js: Added.
- web-platform-tests/hr-time/idlharness.any.worker-expected.txt: Added.
- web-platform-tests/hr-time/idlharness.any.worker.html: Added.
- web-platform-tests/hr-time/idlharness.html: Removed.
- web-platform-tests/hr-time/monotonic-clock.any.js:
- web-platform-tests/hr-time/performance-tojson-expected.txt: Added.
- web-platform-tests/hr-time/performance-tojson.html: Added.
- web-platform-tests/hr-time/resources/unload-a.html: Added.
- web-platform-tests/hr-time/resources/unload-b.html: Added.
- web-platform-tests/hr-time/resources/unload-c.html: Added.
- web-platform-tests/hr-time/resources/unload.js: Added.
- web-platform-tests/hr-time/resources/w3c-import.log:
- web-platform-tests/hr-time/timeOrigin-expected.txt:
- web-platform-tests/hr-time/w3c-import.log:
- web-platform-tests/hr-time/window-worker-timeOrigin.window-expected.txt: Added.
- web-platform-tests/hr-time/window-worker-timeOrigin.window.html: Added.
LayoutTests:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
Update paths in expectations.
- 7:48 AM Changeset in webkit [267313] by
-
- 8 edits2 adds in trunk
Selection API: Extend lifetime of selection live range to preserve expando properties
https://bugs.webkit.org/show_bug.cgi?id=216721
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/selection/expando.html
- dom/Range.cpp:
(WebCore::Range::window): Added. Returns window if range is associated with selection.
- dom/Range.h: Added window.
- dom/Range.idl: Added GenerateIsReachable=ReachableFromDOMWindow.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::disassociateLiveRange): Removed a FIXME comment about the
need for this fix.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added a comment explaining
why an associated live range might not be contained in the document.
LayoutTests:
- editing/selection/expando-expected.txt: Added.
- editing/selection/expando.html: Added.
- TestExpectations: Skip the new test since DumpRenderTree doesn't support enabling
internal properties.
- platform/wk2/TestExpectations: Unskip the new test since WebKitTestRunner does.
- 7:22 AM Changeset in webkit [267312] by
-
- 8 edits3 adds in trunk/Source/WebCore
Add support for Settings equivilent of RuntimeConditionallyReadWrite
https://bugs.webkit.org/show_bug.cgi?id=216697
Reviewed by Darin Adler.
Adds a new extended attribute, [SettingsConditionallyReadWrite] to allow users of
[RuntimeConditionallyReadWrite] to convert from RuntimeEnabledFeatures to Settings.
- bindings/scripts/CodeGeneratorJS.pm:
(NeedsRuntimeReadWriteCheck):
(GeneratePropertiesHashTable):
(GenerateRuntimeEnableConditionalString):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.json:
Adds new extended attribute.
- bindings/scripts/test/DOMWindowConstructors.idl:
- bindings/scripts/test/JS/JSDOMWindow.cpp:
- bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: Added.
- bindings/scripts/test/JS/JSTestConditionallyReadWrite.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/SupplementalDependencies.dep:
- bindings/scripts/test/TestConditionallyReadWrite.idl: Added.
- bindings/scripts/test/TestObj.idl:
Move conditionally read-write tests to a new test, TestConditionallyReadWrite.idl and
update results.
- 7:20 AM Changeset in webkit [267311] by
-
- 7 edits in trunk/Source
Remove runtime setting for enabling/disabling the CrossOriginResourcePolicy API
https://bugs.webkit.org/show_bug.cgi?id=216561
Reviewed by Darin Adler.
Remove runtime setting for enabling/disabling CrossOriginResourcePolicy. It has been
enabled by default for a while and there are no known reasons one would need to
disable it.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCrossOriginResourcePolicyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::crossOriginResourcePolicyEnabled const): Deleted.
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCrossOriginResourcePolicyEnabled):
(WKPreferencesGetCrossOriginResourcePolicyEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
- 5:54 AM Changeset in webkit [267310] by
-
- 7 edits in trunk/Source/WebCore
ASSERTION FAILED: &formattingContextRoot == m_rootContainer.get() in WebCore::Layout::LayoutState::establishedInlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=216668
Reviewed by Zalan Bujtas.
Display::View didn't unparent the GraphicsLayers when Document::documentWillBecomeInactive() was called,
so a layer pointing to an old LayoutState would try to paint.
Fix by plumbing setIsInWindow() through to Display::View and using it to detach the root layer.
- dom/Document.cpp:
(WebCore::Document::documentWillBecomeInactive): The ASSERT_IMPLIES() is there to ensure that this isn't
a behavior change; we used to go to RenderView directly, and now go via FrameView.
- layout/display/DisplayLayerController.cpp:
(WebCore::Display::LayerController::detachRootLayer):
(WebCore::Display::LayerController::setIsInWindow):
- layout/display/DisplayLayerController.h:
- layout/display/DisplayView.cpp:
(WebCore::Display::View::setIsInWindow):
- layout/display/DisplayView.h:
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
Sep 18, 2020:
- 11:42 PM Changeset in webkit [267309] by
-
- 2 edits in trunk/Tools
[GTK] API test /webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing
- TestWebKitAPI/glib/TestExpectations.json:
- 7:52 PM Changeset in webkit [267308] by
-
- 18 edits1 add in trunk/Source/WebCore
[LFC][IFC] Do not use Display::Line geometry in layout
https://bugs.webkit.org/show_bug.cgi?id=216711
Reviewed by Simon Fraser.
This patch introduces Layout::LineGeometry.
LineGeometry is used to hold the logical geometry of line and it is input to subsequent layouts.
This patch is also in preparation for moving out the "displayInlineItem" construction from Layout::InlineFormattingContext.
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):
- layout/displaytree/DisplayLine.h:
(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::baseline const):
(WebCore::Display::Line::Line):
(WebCore::Display::Line::left const): Deleted.
(WebCore::Display::Line::right const): Deleted.
(WebCore::Display::Line::top const): Deleted.
(WebCore::Display::Line::bottom const): Deleted.
(WebCore::Display::Line::width const): Deleted.
(WebCore::Display::Line::height const): Deleted.
(WebCore::Display::Line::moveVertically): Deleted.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::invalidateFormattingState):
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::lines const):
(WebCore::Layout::InlineFormattingState::lines):
(WebCore::Layout::InlineFormattingState::addLine):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):
(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent):
(WebCore::Layout::InlineFormattingState::clearDisplayInlineContent): Deleted.
- layout/inlineformatting/InlineLineBuilder.cpp:
- layout/inlineformatting/InlineLineBuilder.h:
- layout/inlineformatting/InlineLineGeometry.h: Added.
(WebCore::Layout::InlineLineGeometry::logicalLeft const):
(WebCore::Layout::InlineLineGeometry::logicalRight const):
(WebCore::Layout::InlineLineGeometry::logicalTop const):
(WebCore::Layout::InlineLineGeometry::logicalBottom const):
(WebCore::Layout::InlineLineGeometry::logicalWidth const):
(WebCore::Layout::InlineLineGeometry::logicalHeight const):
(WebCore::Layout::InlineLineGeometry::logicalRect const):
(WebCore::Layout::InlineLineGeometry::lineBoxLogicalRect const):
(WebCore::Layout::InlineLineGeometry::baseline const):
(WebCore::Layout::InlineLineGeometry::moveVertically):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):
- layout/inlineformatting/InlineTextItem.h:
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::paint):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):
- 7:20 PM Changeset in webkit [267307] by
-
- 5 edits4 copies12 moves110 adds22 deletes in trunk/LayoutTests
Import remaining webaudio layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216719
Reviewed by Darin Adler.
Import remaining webaudio tests from Blink that we had not imported yet.
- TestExpectations:
- webaudio/BiquadFilter/biquad-829349-expected.txt: Added.
- webaudio/BiquadFilter/biquad-829349.html: Added.
- webaudio/BiquadFilter/tail-time-allpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-allpass.html: Added.
- webaudio/BiquadFilter/tail-time-bandpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-bandpass.html: Added.
- webaudio/BiquadFilter/tail-time-highpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-highpass.html: Added.
- webaudio/BiquadFilter/tail-time-highshelf-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-highshelf.html: Added.
- webaudio/BiquadFilter/tail-time-lowpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-lowpass.html: Added.
- webaudio/BiquadFilter/tail-time-lowshelf-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-lowshelf.html: Added.
- webaudio/BiquadFilter/tail-time-notch-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-notch.html: Added.
- webaudio/BiquadFilter/tail-time-peaking-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-peaking.html: Added.
- webaudio/BiquadFilter/test-tail-time.js: Added.
(testTailTime):
- webaudio/BiquadFilter/unstable-filter-warning-expected.txt: Added.
- webaudio/BiquadFilter/unstable-filter-warning.html: Added.
- webaudio/ChannelMerger/audiochannelmerger-cycle-expected.txt: Added.
- webaudio/ChannelMerger/audiochannelmerger-cycle.html: Added.
- webaudio/Convolver/unmmodified-buffer-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/Convolver/unmmodified-buffer.html: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer.html.
- webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state-expected.txt: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-simple-expected.txt: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-simple.html: Added.
- webaudio/IIRFilter/iir-tail-time-expected.txt: Added.
- webaudio/IIRFilter/iir-tail-time.html: Added.
- webaudio/IIRFilter/iir-unstable-expected.txt: Added.
- webaudio/IIRFilter/iir-unstable.html: Added.
- webaudio/IIRFilter/unstable-filter-warning-expected.txt: Added.
- webaudio/IIRFilter/unstable-filter-warning.html: Added.
- webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt: Added.
- webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html: Added.
- webaudio/MediaElementAudioSource/resampling-crash-expected.txt: Added.
- webaudio/MediaElementAudioSource/resampling-crash.html: Added.
- webaudio/MediaStreamAudioDestination/create-in-destroyed-context-expected.txt: Added.
- webaudio/MediaStreamAudioDestination/create-in-destroyed-context.html: Added.
- webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode-expected.txt: Added.
- webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html: Added.
- webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource-expected.txt: Added.
- webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource.html: Added.
- webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode-expected.txt: Added.
- webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-constructor-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test.html: Added.
- webaudio/OfflineAudioContext/onstatechange-expected.txt: Added.
- webaudio/OfflineAudioContext/onstatechange.html: Added.
- webaudio/Panner/hrtf-database-expected.txt: Added.
- webaudio/Panner/hrtf-database.html: Added.
- webaudio/Panner/panner-loop-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/Panner/panner-loop.html: Added.
- webaudio/Panner/panner-set-position-expected.txt: Added.
- webaudio/Panner/panner-set-position.html: Added.
- webaudio/PeriodicWave/ctor-periodicwave-expected.txt: Added.
- webaudio/PeriodicWave/ctor-periodicwave.html: Added.
- webaudio/PeriodicWave/periodicwave-contexts-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-contexts.html: Added.
- webaudio/PeriodicWave/periodicwave-exceptions-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-exceptions.html: Added.
- webaudio/PeriodicWave/periodicwave-lengths-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-lengths.html: Added.
- webaudio/PeriodicWave/periodicwave-normalization-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-normalization.html: Added.
- webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode.html: Added.
- webaudio/WaveShaper/waveshaper-364379-expected.txt: Added.
- webaudio/WaveShaper/waveshaper-364379.html: Added.
- webaudio/WaveShaper/waveshaper-oversample-2x-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/WaveShaper/waveshaper-oversample-2x.html: Added.
- webaudio/WaveShaper/waveshaper-oversample-4x-expected.txt: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/WaveShaper/waveshaper-oversample-4x.html: Added.
- webaudio/audio-scheduled-source-basic-expected.txt: Added.
- webaudio/audio-scheduled-source-basic.html: Added.
- webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
- webaudio/javascriptaudionode-downmix8-2channel-input.html: Removed.
- webaudio/javascriptaudionode-expected.txt: Removed.
- webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
- webaudio/javascriptaudionode-upmix2-8channel-input.html: Removed.
- webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
- webaudio/javascriptaudionode-zero-input-channels.html: Removed.
- webaudio/javascriptaudionode.html: Removed.
- webaudio/mediastreamaudiodestinationnode-expected.txt: Removed.
- webaudio/mediastreamaudiodestinationnode.html: Removed.
- webaudio/mediastreamaudiosourcenode-expected.txt: Removed.
- webaudio/mediastreamaudiosourcenode.html: Removed.
- webaudio/offlineaudiocontext-constructor-expected.txt: Removed.
- webaudio/offlineaudiocontext-constructor.html: Removed.
- webaudio/panner-loop-expected.txt: Removed.
- webaudio/panner-loop.html: Removed.
- webaudio/periodicwave-lengths-expected.txt: Removed.
- webaudio/periodicwave-lengths.html: Removed.
- webaudio/resources/audionodeoptions.js: Added.
(testAudioNodeOptions):
(initializeContext):
(testInvalidConstructor):
(testDefaultConstructor):
(testDefaultAttributes):
- webaudio/resources/biquad-filters.js: Added.
(createLowpassFilter):
(createHighpassFilter):
(normalizeFilterCoefficients):
(createBandpassFilter):
(createLowShelfFilter):
(createHighShelfFilter):
(createPeakingFilter):
(createNotchFilter):
(createAllpassFilter):
(filterData):
(createFilter):
- webaudio/resources/hrtf/Composite.flac: Added.
- webaudio/resources/hrtf/Composite.wav: Added.
- webaudio/resources/hrtf/README: Added.
- webaudio/resources/scriptprocessornode-testing-audit.js: Added.
(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):
- webaudio/resources/scriptprocessornode-testing.js: Added.
(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):
- webaudio/resources/waveshaper-testing.js:
(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):
- webaudio/waveshaper-oversample-2x-expected.txt: Removed.
- webaudio/waveshaper-oversample-2x.html: Removed.
- webaudio/waveshaper-oversample-4x-expected.txt: Removed.
- webaudio/waveshaper-oversample-4x.html: Removed.
- 7:19 PM Changeset in webkit [267306] by
-
- 6 edits in trunk
[JSC] Generator declaration should not be allowed in single statement context
https://bugs.webkit.org/show_bug.cgi?id=216720
Reviewed by Ross Kirsling.
JSTests:
- stress/generator-syntax.js:
(testSyntaxError.gen):
- test262/expectations.yaml:
Source/JavaScriptCore:
Generator declaration in single statement context (like the following code) should be syntax error.
We already made async function / async generator function syntax error. We should apply the same rule
to generator declaration too.
if (false)
function * gen() { }
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseExportDeclaration):
- parser/Parser.h:
- 6:34 PM Changeset in webkit [267305] by
-
- 4 edits in trunk
[macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data
https://bugs.webkit.org/show_bug.cgi?id=216718
<rdar://problem/69150358>
Reviewed by Tim Horton.
Source/WebKit:
Test: CopyHTML.WriteRichTextSelectionToPasteboard
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
After r265702, the
IPCHandlereceived in the UI process was always being converted into a buffer of size 0,
due to using thesizelocal variable (which is no longer set as an outparam of the sync IPC message). Instead,
useipcHandle.dataSize.
Tools:
Add a new API test to verify that we get non-empty web archive data when using
-writeSelectionToPasteboard:types:to grab selected content as rich text data.
- TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
- 6:22 PM Changeset in webkit [267304] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct
https://bugs.webkit.org/show_bug.cgi?id=216717
Reviewed by Mark Lam.
When starting full GC, at beginMarking, PreciseAllocation's mark bit is cleared to be usable for upcoming marking.
However, this means that HeapCell::isLive will see this object as dead until it is marked.
Let's consider that this object is not newly allocated one. Then, its isNewlyAllocated is false. And now mark bit
is also cleared. Since PreciseAllocation::isLive is isNewlyAllocated isMarked, then it looks dead, while it is live. This confuses HeapCell:isLive function and makes some of watchpoints perform wrong decisions (e.g. this condition is
no longer valid, let's just discard it).
At the beginning of full collection, we should propagate the old mark bit to isNewlyAllocated so that it looks live
during marking. This is similar trick to MarkedBlock::aboutToMark.
- heap/PreciseAllocation.cpp:
(JSC::PreciseAllocation::flip):
- 5:40 PM Changeset in webkit [267303] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add flex box/item to showLayoutTree
https://bugs.webkit.org/show_bug.cgi?id=216694
Reviewed by Sam Weinig.
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputLayoutBox): 'Table principal' -> 'Table wrapper box' for consistency sake.
- 5:40 PM Changeset in webkit [267302] by
-
- 1 copy in tags/Safari-610.2.6.1.2
Tag Safari-610.2.6.1.2.
- 5:27 PM Changeset in webkit [267301] by
-
- 9 edits2 adds in trunk
console APIs shouldn't crash making a string that's too long for a console warning when using user provided labels
https://bugs.webkit.org/show_bug.cgi?id=216709
<rdar://problem/68275357>
Reviewed by Mark Lam and Devin Rousso.
Source/JavaScriptCore:
Various console APIs send warnings when a label can't be found. These warnings
include the label itself. If this label has a long enough length, when we make
these warning strings, we can crash, because we exceed max string length.
This patch fixes this by truncating the label everywhere it's used if it
exceeds a length of 10000.
- inspector/JSGlobalObjectConsoleClient.cpp:
(Inspector::JSGlobalObjectConsoleClient::profile):
- inspector/ScriptArguments.h:
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::logTiming):
(Inspector::InspectorConsoleAgent::stopTiming):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::countReset):
Source/WebCore:
Test: inspector/console/console-oom.html
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
- inspector/agents/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::didReceiveResponse):
LayoutTests:
- TestExpectations:
- inspector/console/console-oom-expected.txt: Added.
- inspector/console/console-oom.html: Added.
- 5:17 PM Changeset in webkit [267300] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.2
- 4:29 PM Changeset in webkit [267299] by
-
- 1 copy in tags/Safari-610.2.6.1.1
Tag Safari-610.2.6.1.1.
- 4:20 PM Changeset in webkit [267298] by
-
- 2 edits in trunk/Source/WebKit
Remove unneeded respondsToSelector staging for keyboard.
https://bugs.webkit.org/show_bug.cgi?id=216421
Staging needed for dual work in UIKit in 2019, no longer needed.
Reviewed by Tim Horton.
No behavior change, covered by existing tests.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertText:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
- 4:18 PM Changeset in webkit [267297] by
-
- 5 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266797. rdar://problem/68732167
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195
Reviewed by Simon Fraser.
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.
After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.
Source/WebCore:
- platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):
Source/WebKit:
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
- UIProcess/mac/DisplayLink.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267296] by
-
- 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit
Cherry-pick r266771. rdar://problem/68732073
Regression(r260614) Power usage has increased due to extra thread hopping
https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>
Reviewed by Simon Fraser.
Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.
- UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
- UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
- WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267295] by
-
- 6 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266710. rdar://problem/68732167
Unreviewed, reverting r266645.
https://bugs.webkit.org/show_bug.cgi?id=216251
Caused MotionMark regression
Reverted changeset:
"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
https://bugs.webkit.org/show_bug.cgi?id=216195
https://trac.webkit.org/changeset/266645
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267294] by
-
- 6 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266645. rdar://problem/68732167
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195
Reviewed by Simon Fraser.
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.
After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.
Source/WebCore:
- platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):
Source/WebKit:
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
- UIProcess/mac/DisplayLink.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267293] by
-
- 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit
Revert r266771. rdar://problem/68732073
- 4:18 PM Changeset in webkit [267292] by
-
- 5 edits in branches/safari-610.2.6.1-branch/Source
Revert r266797. rdar://problem/68732167
- 4:18 PM Changeset in webkit [267291] by
-
- 26 edits1 copy3 adds in branches/safari-610.2.6.1-branch
Cherry-pick r266846. rdar://problem/68740516
Don't create event regions when the page has no subscrollers
https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/scrolling/mac/event-region-subscroller-frame.html
fast/scrolling/mac/event-region-subscroller-overflow.html
Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
- page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):
Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):
Don't maintain event region if there are no subscrollers and none of the other reasons were hit.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
Invalidate event regions if a subscroller appears.
(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Add overflow scrollers to some existing tests so they still generate event regions.
- fast/scrolling/ios/border-radius-event-region-expected.txt:
- fast/scrolling/ios/border-radius-event-region.html:
- fast/scrolling/ios/event-region-float-expected.txt:
- fast/scrolling/ios/event-region-float.html:
- fast/scrolling/ios/event-region-pointer-events-expected.txt:
- fast/scrolling/ios/event-region-pointer-events.html:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-scale-transform-shared.html:
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-translate-transform-shared.html:
- fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
- fast/scrolling/ios/event-region-visibility-hidden.html:
- fast/scrolling/mac/border-radius-event-region-expected.txt:
- fast/scrolling/mac/border-radius-event-region.html:
- fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-frame.html: Added.
- fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
- fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
- fast/scrolling/mac/event-region-visibility-hidden.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267290] by
-
- 10 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266677. rdar://problem/68740526
[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190
Reviewed by Darin Adler.
Source/WebCore:
In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContentsdue to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time viaMonotonicTime::now().
We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable onPage. See below for more details, as well as
the WebKit2 ChangeLog.
- page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):
Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.
- page/Page.cpp: (WebCore::Page::updateRendering):
Update
m_lastRenderingUpdateTimestamp.
- page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
- rendering/PaintFrequencyTracker.h:
Drive-by cleanup: narrow the
PaintFrequencyenum toboolwidth.
(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):
Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.
(WebCore::RenderLayer::simulateFrequentPaint):
- rendering/RenderLayer.h:
Source/WebKit:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):
In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).
Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions inSinglePaintFrequencyTracking::end(). As such, we
stick withMonotonicTime::now()in WebKit1.
- WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267289] by
-
- 4 edits in branches/safari-610.2.6.1-branch
Cherry-pick r266232. rdar://problem/68732143
Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>
Reviewed by Antoine Quint.
Source/WebCore:
Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):
Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.
LayoutTests:
- animations/steps-transform-rendering-updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:54 PM Changeset in webkit [267288] by
-
- 180 edits in trunk/Source
[WebGPU] Add ENABLE(WHLSL_COMPILER) guard
https://bugs.webkit.org/show_bug.cgi?id=216713
Reviewed by Myles C. Maxfield.
Source/WebCore:
Replaces the ENABLE(WEBGPU) guards in the Modules/webgpu/WHLSL with ENABLE(WHLSL_COMPILER)
since not all ports need a WHLSL compiler to support WebGPU.
- Modules/webgpu/WHLSL/AST/WHLSLAST.h:
- Modules/webgpu/WHLSL/AST/WHLSLAddressEscapeMode.h:
- Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
- Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLBlock.h:
- Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLBreak.h:
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLContinue.h:
- Modules/webgpu/WHLSL/AST/WHLSLDefaultDelete.h:
- Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
- Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLExpression.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLNameSpace.h:
- Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
- Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
- Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLQualifier.h:
- Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h:
- Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
- Modules/webgpu/WHLSL/AST/WHLSLSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStatement.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLStatementList.h:
- Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
- Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h:
- Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLType.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h:
- Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:
- Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.h:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.h:
- Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h:
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
- Modules/webgpu/WHLSL/WHLSLASTDumper.h:
- Modules/webgpu/WHLSL/WHLSLBuildStandardLibraryFunctionMap.py:
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h:
- Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h:
- Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.h:
- Modules/webgpu/WHLSL/WHLSLChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLChecker.h:
- Modules/webgpu/WHLSL/WHLSLCodeLocation.h:
- Modules/webgpu/WHLSL/WHLSLComputeDimensions.cpp:
- Modules/webgpu/WHLSL/WHLSLComputeDimensions.h:
- Modules/webgpu/WHLSL/WHLSLError.h:
- Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.h:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
- Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:
- Modules/webgpu/WHLSL/WHLSLHighZombieFinder.h:
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
- Modules/webgpu/WHLSL/WHLSLInferTypes.h:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
- Modules/webgpu/WHLSL/WHLSLLexer.cpp:
- Modules/webgpu/WHLSL/WHLSLLexer.h:
- Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h:
- Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
- Modules/webgpu/WHLSL/WHLSLNameContext.h:
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
- Modules/webgpu/WHLSL/WHLSLNameResolver.h:
- Modules/webgpu/WHLSL/WHLSLParser.cpp:
- Modules/webgpu/WHLSL/WHLSLParser.h:
- Modules/webgpu/WHLSL/WHLSLParsingMode.h:
- Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:
- Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
- Modules/webgpu/WHLSL/WHLSLPrepare.h:
- Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp:
- Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.h:
- Modules/webgpu/WHLSL/WHLSLProgram.cpp:
- Modules/webgpu/WHLSL/WHLSLProgram.h:
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.h:
- Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.h:
- Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLRecursionChecker.h:
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h:
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h:
- Modules/webgpu/WHLSL/WHLSLResolvingType.h:
- Modules/webgpu/WHLSL/WHLSLScopedSetAdder.h:
- Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:
- Modules/webgpu/WHLSL/WHLSLSemanticMatcher.h:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryFunctionMap.h:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h:
- Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h:
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h:
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h:
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
- Modules/webgpu/WHLSL/WHLSLVisitor.h:
Source/WTF:
Adds a default for ENABLE_WHLSL_COMPILER on Cocoa platforms.
- wtf/PlatformEnable.h:
- wtf/PlatformEnableCocoa.h:
- 3:50 PM Changeset in webkit [267287] by
-
- 2 edits in trunk/Source/WebCore
Crash under WebCore::shouldResetFocusNavigationStartingNode()
https://bugs.webkit.org/show_bug.cgi?id=216714
<rdar://problem/68132047>
Reviewed by Darin Adler.
Protect anchorElement in FrameView::scrollToFragmentInternal() to make sure
it stays alive until the time we pass it to setFocusNavigationStartingNode().
- page/FrameView.cpp:
(WebCore::FrameView::scrollToFragmentInternal):
- 3:27 PM Changeset in webkit [267286] by
-
- 2 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r267208. rdar://problem/69178138
Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>
Reviewed by Brent Fulgham.
Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.
No new tests, no way currently to test apps with different iOS
versions. Tested manually.
- Shared/Cocoa/DefaultWebBrowserChecks.mm: (WebKit::determineITPStateInternal): Ignore the early return for the linked-on-or-after check if the app has the default browser entitlement so we still enable ITP based on the user's preference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:27 PM Changeset in webkit [267285] by
-
- 3 edits1 add in branches/safari-610-branch
Cherry-pick r266907. rdar://problem/69178126
[JSC] unshift / shift should take structure lock
https://bugs.webkit.org/show_bug.cgi?id=216378
<rdar://problem/68496096>
Reviewed by Mark Lam.
JSTests:
- stress/unshift-and-concurrent-access.js: Added.
Source/JavaScriptCore:
When unshifting / shifting butterfly, we need to move property storage values too.
If property storage values are moved while concurrent JIT compiler is accessing it, it could include garbage value.
For example, concurrent JIT compiler is accessing [2] property storage.
1 2 3
[ JSValue ][ JSValue ][ Header ]
But unshift moved it like this.
1 2 3
[ JSValue ][ JSValue ][ Header ]
Since butterfly pointer held by JSObject is not updated yet, concurrent JIT compiler will read [ Header ] as JSValue and crash.
In this patch, we take structure lock when shifting existing butterfly since this affect on property storage. Since JSObject::getDirectConcurrently
takes a structure lock, this locking prevents concurrent compilers from getting an invalid value.
- runtime/JSArray.cpp: (JSC::JSArray::unshiftCountSlowCase): (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::unshiftCountWithArrayStorage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:25 PM Changeset in webkit [267284] by
-
- 9 edits in trunk
REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
https://bugs.webkit.org/show_bug.cgi?id=216394
<rdar://problem/68679551>
Reviewed by Tim Horton.
Source/WebKit:
In WebKitTestRunner, we reset the states and load about:blank page between tests. The resetting may cause some
activity state changes of web page, like WindowIsActive. Before r266634, these changes will be dispatched
quickly enough (before runloop waits or when runloop exits) to web process, so web process can do rendering with
updated activity state. After r266634, dispatch of the changes may be delayed (until CATransaction commits).
Page activity state can affect scrollability (in FrameView::computeScrollability()) and scrollability can affect
tiling size (in TileController::computeTileSize()). Different tilings may cause the tiny pixel difference we see
in the test results.
To fix this, create an SPI for sending out activity state updates in next runloop cycle and adopt it in WTR.
- UIProcess/API/C/WKPage.cpp:
(WKPageDispatchActivityStateUpdateForTesting):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchActivityStateUpdateForTesting):
- UIProcess/WebPageProxy.h:
Tools:
Make sure activity state changes for window updates in resetStateToConsistentValues are dispatched in time.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Update test expectations as tests should be passing.
- platform/mac-wk2/TestExpectations:
- 2:18 PM Changeset in webkit [267283] by
-
- 5 edits1 add in trunk
Date/time inputs should not use user-specified formats
https://bugs.webkit.org/show_bug.cgi?id=216484
<rdar://problem/68864815>
Reviewed by Wenson Hsieh.
Source/WebCore:
On macOS, users can specify custom date and time formats through System
Preferences. These formats can be different from the default for the
user’s current locale. Using these formats when rendering date and time
inputs is a potential fingerprinting vector, as sites can apply CSS to
components of the input, and measure the size of the input.
To fix, we create a new NSLocale even if the identifier matches
[NSLocale currentLocale]. This ensures that m_locale does not contain
the user's changes to the locale.
- platform/text/cocoa/LocaleCocoa.h:
- platform/text/cocoa/LocaleCocoa.mm:
(WebCore::Locale::create):
(WebCore::LocaleCocoa::LocaleCocoa):
Tools:
Added a test which sets a custom date format using "defaults write"
and verifies that the width is indistinguishable from the default
format.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/DateInputTests.mm: Added.
(createWebViewForTest):
(DateInputsTests.IgnoresUserEditsToLocale):
- 1:50 PM Changeset in webkit [267282] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline test after r266816 changed wptserve output.
- web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:
- 1:34 PM Changeset in webkit [267281] by
-
- 11 edits in trunk
[macOS] Date/time inputs should focus the next editable component when entering a separator key
https://bugs.webkit.org/show_bug.cgi?id=216661
<rdar://problem/69091856>
Reviewed by Wenson Hsieh.
Source/WebCore:
NSDatePicker focuses the next editable field when entering a separator
key. We should match this behavior to be consistent with the rest of
the system.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
Tools:
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::keyDown):
Add support for colon, semicolon, and comma keys. The keycode values are
taken from the virtual keycode values in HIToolbox/Events.h.
Note that the keycode for colon and semicolon is the same, as there is
no distinct value for colon. This is safe as it matches the Javascript
behavior.
LayoutTests:
Added new test cases to the existing set of keyboard tests for date/time inputs.
- fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
- fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
- fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events-expected.txt:
- fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events.html:
- fast/forms/time/time-editable-components/time-editable-components-keyboard-events-expected.txt:
- fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html:
- 1:28 PM Changeset in webkit [267280] by
-
- 5 edits in trunk/JSTests
[ARMv7][MIPS] Test gaderning September version
https://bugs.webkit.org/show_bug.cgi?id=216699
Unreviewed test gardening.
- stress/array-species-create-should-handle-masquerader.js:
- stress/compare-eq-should-use-known-other-use.js:
- stress/ftl-reflect-get-prototype-of.js:
- stress/typedarray-access-neutered.js:
- 1:17 PM Changeset in webkit [267279] by
-
- 5 edits in trunk
WKWebView._tryClose should return whether it succeeded or not
https://bugs.webkit.org/show_bug.cgi?id=216660
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.
Source/WebKit:
The return value of WKPageTryClose is used by Safari.
In order to migrate to WKWebView _tryClose, we need to expose this return value.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _tryClose]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
(TEST):
- 1:15 PM Changeset in webkit [267278] by
-
- 2 edits in trunk/Tools
Make TLSVersion.NetworkSession API test more robust
https://bugs.webkit.org/show_bug.cgi?id=216704
<rdar://problem/68643674>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.
r265573 made preconnect attempts to legacy TLS servers fail.
This caused the TLSVersion.NetworkSession to assert because the first connection attempt would fail
(and the second would succeed if it was supposed to succeed with the conditions in the test).
The test calls waitForDidFailProvisionalNavigation in cases where it is supposed to fail and
waitForDidFinishNavigation in cases where it supposed to succeed.
Like I did in r266100 with another test, use HTTPServer which allows a variable number of connection attempts.
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 12:46 PM Changeset in webkit [267277] by
-
- 2 edits in trunk/Tools
Make ews-app robust against config.json issues
https://bugs.webkit.org/show_bug.cgi?id=216705
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.fetch_config):
(Buildbot.update_icons_for_queues_mapping):
- 12:36 PM Changeset in webkit [267276] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266619. rdar://problem/69101154
Add a fast path in TransformationMatrix::mapRect(const FloatRect&) for affine transformations
https://bugs.webkit.org/show_bug.cgi?id=216139
Reviewed by Tim Horton.
Add a fast path when mapping 2D points through affine transformation matrices that takes advantage of both:
- The predetermined 0 and 1 values in affine transformation matrices.
- The fact that points in the FloatRect are aligned with x and y axes (as opposed to a FloatQuad of 4 arbitrary
points), which allows us to avoid mapping all 4 corners of the rect through the matrix.
The current implementation of this method maps each of the 4 corners through the transformation matrix, creates
a FloatQuad using these 4 transformed points, and then asks the FloatQuad for its bounding box. This requires
a total of 26 floating point additions, 24 multiplications and 20 comparisons, as well as a small (but
measurable) amount of overhead when creating the FloatPoints and FloatQuad and asking for the bounding rect.
We can pare this down to just 8 additions, 8 multiplications, and 4 comparisons by using a different strategy
that instead branches on the 4 relevant matrix coefficientsa, b, c, d(rather than the each of the final x
and y coordinates) to determine which of the min or max x and y values to multiply in order to compute the min
and max x and y coordinates in the final bounding rect.
In a quick microbenchmark that maps FloatRects through an affine TransformationMatrix, this roughly halves the
time spent inTransformationMatrix::mapRect; on the Multiply subtest of MotionMark (which invokes this method
~17 million times, almost entirely with affine transformation matrices), I measured a ~1% improvement.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapRect const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267275] by
-
- 3 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266513. rdar://problem/69153717
Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
https://bugs.webkit.org/show_bug.cgi?id=216101
Reviewed by Tim Horton.
The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time underRenderLayer::paintLayerByApplyingTransformjust
inverting the transformation matrix (underneathTransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.
TransformationMatrix::inverse()currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.
However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.
We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition ofTransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks inTransformationMatrix::inverse().
We also apply a similar optimization to
TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.
I measured this locally to be a (statistically significant) 2% improvement on Multiply.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::isInvertible const): (WebCore::TransformationMatrix::inverse const):
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::type const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267274] by
-
- 4 edits2 adds in branches/safari-610-branch
Cherry-pick r266834. rdar://problem/69101124
REGRESSION (r260360): Ionic modal dialog doesn't animate correctly when dragged and released
https://bugs.webkit.org/show_bug.cgi?id=216308
<rdar://problem/68567444>
Reviewed by Simon Fraser.
Source/WebCore:
We fixed seeking for animations with a reversed playback rate in r261637, the fix for bug 204717,
but only looked at the animation's playback rate. However, an animation can also play in reverse
using the "direction" property of the timing object passed to updateTiming(), so we should also
check that it's playing forwards in order to be seeked.
Test: webanimations/accelerated-animation-easing-and-direction-update.html
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::animationCanBeAccelerated const):
LayoutTests:
Add a new test that updates the "easing" and "direction" timing properties of a playing animation
and checks that it matches the display of another animation with similar timing properties from
the start.
- platform/win/TestExpectations:
- webanimations/accelerated-animation-easing-and-direction-update-expected.html: Added.
- webanimations/accelerated-animation-easing-and-direction-update.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267273] by
-
- 8 edits in branches/safari-610-branch/Source
Cherry-pick r266802. rdar://problem/69101097
Text copied and pasted from Mac Catalyst apps appears larger than expected
https://bugs.webkit.org/show_bug.cgi?id=215971
<rdar://problem/65768907>
Reviewed by Tim Horton.
Source/WebKit:
Various pieces of platform logic in Mac Catalyst depend on the user interface idiom (i.e. Mac or iPad) of the
app, as well as the application-wide "scale factor". In the context of this bug, NSAttributedString to RTF data
conversion methods inUIFoundationconsult the scale factor ofUIiOSMacIdiomManagerto determine whether to
emit 0 (standard) or 1 (iOS) for the\cocoatextscalingattribute. The fact that the web process' scale factor
may be out of sync with the UI process' scale factor leads to copied RTF data in the web process appearing
either larger or smaller than expected, due to an incorrectNSTextScalingTypevalue.
To mitigate this (as well as any other issues), we add a mechanism for the UI process to forward the global
scale factor and user interface idiom to the web process inside of the web process creation parameters, and then
use new UIKit SPI to override the scale factor and idiom within the web process.
- Scripts/process-entitlements.sh:
Add a new entitlement needed to use
_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
Use
_UIApplicationCatalystUserInterfaceIdiomand_UIApplicationCatalystScaleFactorto grab the global user
interface idiom and scale factor, respectively.
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Override the idiom and scale factor in the web process with the idiom and scale factor from the UI process,
using the new SPI_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor. As this function hasn't landed
yet, we soft link the function for now to avoid causing the web process to instantly crash on any builds without
the fix for <rdar://problem/68524148>.
Source/WTF:
Add a new flag to guard the presence of
_UIApplicationCatalystUserInterfaceIdiom,
_UIApplicationCatalystScaleFactor, and_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.
- wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267272] by
-
- 5 edits4 adds in branches/safari-610-branch
Cherry-pick r266789. rdar://problem/69101080
REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback
https://bugs.webkit.org/show_bug.cgi?id=215853
<rdar://problem/67815853>
Reviewed by Simon Fraser.
Source/WebCore:
Stop accelerated animations if the timing function has changed in a way that makes it so that it should
no longer play accelerated, but otherwise simply update their timing properties such that may keep
playing.
Test: webanimations/accelerated-animation-easing-update-after-pause.html
webanimations/accelerated-animation-easing-update-steps-after-pause.html
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::canBeAccelerated const): (WebCore::KeyframeEffect::updateAcceleratedActions): (WebCore::KeyframeEffect::animationDidChangeTimingProperties):
- animation/KeyframeEffect.h:
LayoutTests:
Add new tests that check that updating an animation's easing does not stop it.
- platform/win/TestExpectations:
- webanimations/accelerated-animation-easing-update-after-pause-expected.html: Added.
- webanimations/accelerated-animation-easing-update-after-pause.html: Added.
- webanimations/accelerated-animation-easing-update-steps-after-pause-expected.html: Addded.
- webanimations/accelerated-animation-easing-update-steps-after-pause.html: Addded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267271] by
-
- 26 edits1 copy3 adds in branches/safari-610-branch
Cherry-pick r266846. rdar://problem/68740511
Don't create event regions when the page has no subscrollers
https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/scrolling/mac/event-region-subscroller-frame.html
fast/scrolling/mac/event-region-subscroller-overflow.html
Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
- page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):
Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):
Don't maintain event region if there are no subscrollers and none of the other reasons were hit.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
Invalidate event regions if a subscroller appears.
(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Add overflow scrollers to some existing tests so they still generate event regions.
- fast/scrolling/ios/border-radius-event-region-expected.txt:
- fast/scrolling/ios/border-radius-event-region.html:
- fast/scrolling/ios/event-region-float-expected.txt:
- fast/scrolling/ios/event-region-float.html:
- fast/scrolling/ios/event-region-pointer-events-expected.txt:
- fast/scrolling/ios/event-region-pointer-events.html:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-scale-transform-shared.html:
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-translate-transform-shared.html:
- fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
- fast/scrolling/ios/event-region-visibility-hidden.html:
- fast/scrolling/mac/border-radius-event-region-expected.txt:
- fast/scrolling/mac/border-radius-event-region.html:
- fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-frame.html: Added.
- fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
- fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
- fast/scrolling/mac/event-region-visibility-hidden.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267270] by
-
- 10 edits in branches/safari-610-branch/Source
Cherry-pick r266677. rdar://problem/68740521
[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190
Reviewed by Darin Adler.
Source/WebCore:
In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContentsdue to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time viaMonotonicTime::now().
We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable onPage. See below for more details, as well as
the WebKit2 ChangeLog.
- page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):
Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.
- page/Page.cpp: (WebCore::Page::updateRendering):
Update
m_lastRenderingUpdateTimestamp.
- page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
- rendering/PaintFrequencyTracker.h:
Drive-by cleanup: narrow the
PaintFrequencyenum toboolwidth.
(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):
Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.
(WebCore::RenderLayer::simulateFrequentPaint):
- rendering/RenderLayer.h:
Source/WebKit:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):
In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).
Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions inSinglePaintFrequencyTracking::end(). As such, we
stick withMonotonicTime::now()in WebKit1.
- WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267269] by
-
- 4 edits in branches/safari-610-branch
Cherry-pick r266232. rdar://problem/68178664
Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>
Reviewed by Antoine Quint.
Source/WebCore:
Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):
Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.
LayoutTests:
- animations/steps-transform-rendering-updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267268] by
-
- 11 edits5 adds in branches/safari-610-branch
Cherry-pick r267057. rdar://problem/69101182
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
https://bugs.webkit.org/show_bug.cgi?id=216203
<rdar://problem/67438626>
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/media/hls/hls-hdr-switch.html
In r264710, we adopted a new API to set the preferred HDR mode for every AVPlayer created by an HTMLMediaElement. The
MediaPlayerPrivateAVFoundationObjC object will query its parent when it creates an AVPlayer, or the MediaPlayer will
tell the MediaPlayerPrivate... that the HDR mode changes if the AVPlayer is already created. However, in r264710, we
neglected to cache the new value of the preferred HDR mode, so subsequent queries will just return "Standard". This means
HDR mode will correctly be applied if it changes after the AVPlayer has been created, but not initially.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreferredDynamicRangeMode):
LayoutTests:
- http/tests/media/hls/hls-hdr-switch-expected.txt: Added.
- http/tests/media/hls/hls-hdr-switch.html: Added.
- http/tests/media/resources/hls/green-bip.ts: Added.
- http/tests/media/resources/hls/hdr.m3u8: Added.
- http/tests/media/resources/hls/red-bip.ts: Added.
- http/tests/media/resources/hls/test-live.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267267] by
-
- 4 edits in branches/safari-610-branch/Source
Cherry-pick r267031. rdar://problem/69101165
Web Inspector: docking buttons don't work when already docked if window is too small
https://bugs.webkit.org/show_bug.cgi?id=216488
<rdar://problem/68242717>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Base/Main.js: (WI.updateDockingAvailability): (WI.updateDockedState): (WI._updateDockNavigationItems): Always be sure to update the docking navigation items when docking becomes unavailable instead of just forcing Web Inspector to undock as if Web Inspector is already undocked then none of the docking navigation items will be updated. This makes it so that the docking navigation items are hidden when docking becomes unavailable while undocked.
Source/WebKit:
- UIProcess/Inspector/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::attach): (WebKit::WebInspectorProxy::attachAvailabilityChanged): If Web Inspector is already attached, it can re-attach with a different configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267266] by
-
- 3 edits1 add in branches/safari-610-branch
Cherry-pick r267017. rdar://problem/69100994
Don't assume byte code operands are uint32 JSValues
https://bugs.webkit.org/show_bug.cgi?id=216386
Reviewed by Yusuke Suzuki.
JSTests:
- stress/dont-assume-bytecode-operand-is-uint32.js: Added. (async foo):
Source/JavaScriptCore:
The slow path for enumerator_generic_pname was assuming that its input index operand
would always be a UInt32 JSValue boxed as int32. However, this assumption isn't true
because that value can have double format in the DFG, and remain in that format when
we exit from the DFG to baseline/LLInt code.
This was found via the widening number fuzzing agent.
I also audited two more places that seem like they suffer from the same issue,
and also switched them to using the asUInt32AsAnyInt function:
- enumerator_structure_pname
- create_rest
- runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267265] by
-
- 3 edits2 adds in branches/safari-610-branch
Cherry-pick r266972. rdar://problem/69101020
REGRESSION (r255383): Transition from email to password field on login.live.com stutters after going back and forth
https://bugs.webkit.org/show_bug.cgi?id=216368
<rdar://problem/67019460>
Reviewed by Simon Fraser.
Source/WebCore:
Ensure we repaint before disconnecting from the backing provider layer.
Test: compositing/animation/repaint-after-clearing-shared-backing.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
LayoutTests:
- compositing/animation/repaint-after-clearing-shared-backing-expected.html: Added.
- compositing/animation/repaint-after-clearing-shared-backing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267264] by
-
- 6 edits in branches/safari-610-branch
Cherry-pick r266827. rdar://problem/69101047
[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/68304035>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-10
Reviewed by Tim Horton.
Source/WebCore:
Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.
- platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::ImageDecoderCG::repetitionCount const):
Source/WTF:
Add a new macro for the new accurate behavior of CGImageSource.
Unrelated change: Fix the conditions for enabling the WebP images.
- wtf/PlatformHave.h:
LayoutTests:
- platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267263] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266752. rdar://problem/69101201
Web process crashes at WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby
https://bugs.webkit.org/show_bug.cgi?id=216283
Reviewed by Alex Christensen.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267262] by
-
- 2 edits in branches/safari-610-branch/Source/JavaScriptCore
Cherry-pick r266747. rdar://problem/69101160
re-enable TCSM on all OSs
https://bugs.webkit.org/show_bug.cgi?id=216281
Reviewed by Tadeu Zagallo.
- runtime/Options.cpp: (JSC::defaultTCSMValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267261] by
-
- 12 edits in branches/safari-610-branch/Source
Cherry-pick r266745. rdar://problem/69100985
Tighten checks when creating an audio buffer list
https://bugs.webkit.org/show_bug.cgi?id=216237
<rdar://problem/68271376>
Reviewed by Geoffrey Garen.
Source/WebCore:
Add a routine to check there is no multiplication integer overflow.
- platform/audio/cocoa/WebAudioBufferList.cpp: (WebCore::computeBufferSize): (WebCore::WebAudioBufferList::isSupportedDescription): (WebCore::WebAudioBufferList::setSampleCount):
- platform/audio/cocoa/WebAudioBufferList.h:
Source/WebKit:
Add message checks to verify that no message integer overflows happen when processing audio buffer list messages.
- GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::audioTrackRendererManager):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesAvailable):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp: (WebKit::RemoteAudioMediaStreamTrackRendererManager::RemoteAudioMediaStreamTrackRendererManager): (WebKit::RemoteAudioMediaStreamTrackRendererManager::createRenderer):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged): (WebKit::RemoteMediaRecorder::audioSamplesAvailable):
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267260] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266375. rdar://problem/69101035
Avoid computing metadata for idempotent text autosizing on macOS
https://bugs.webkit.org/show_bug.cgi?id=216011
Reviewed by Darin Adler.
Avoids an unnecessary call to
adjustForTextAutosizingduring style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates theAutosizeStatusfields onRenderStylethat are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatusis designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.
- style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267259] by
-
- 9 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266344. rdar://problem/69101085
Make StyleRareNonInheritedData::mask and StyleBackgroundData::background DataRefs
https://bugs.webkit.org/show_bug.cgi?id=215942
Reviewed by Darin Adler.
A significant amount of time in MotionMark's Multiply subtest is spent underneath the copy constructor
StyleRareNonInheritedData, and a significant amount of time underneath this copy constructor is spent copying
the rare non-inherited data's mask (aFillLayer).
This
FillLayeris currently inline data inStyleRareNonInheritedData; to reduce the cost of copying rare
non-inherited data, we can instead make this aDataRef<FillLayer>, such that copying rare data will only copy
the reference to theFillLayerrather than theFillLayeritself.
Upon mutating the
FillLayer, we now useDataRef::access()to ensure that theseFillLayers are copied
before writing. See below for more details.
- css/makeprop.pl: (generateFillLayerPropertyInheritValueSetter): (generateFillLayerPropertyValueSetter):
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::create): (WebCore::FillLayer::FillLayer):
Deeply copy the
FillLayer's linked list ofFillLayers. This preserves existing behavior, which currently
usesstd::unique_ptrto store the pointer to the nextFillLayer(and therefore, requires a deep copy of the
linked list when copyingFillLayer).
In a future patch, we could probably further optimize this as well to behave in a copy-on-write way, by turning
theRefPtr<FillLayer> m_next;into anOptional<DataRef<FillLayer>>instead (and then useaccess()to copy
the nextFillLayerprior to writing).
(WebCore::FillLayer::~FillLayer):
(WebCore::FillLayer::operator=):
- rendering/style/FillLayer.h:
Make
FillLayerref-counted, and introduce newcreatemethods for constructingFillLayers. Use these
methods in several places where we currently call the constructors directly, viamakeUnique.
(WebCore::FillLayer::copy const):
(WebCore::FillLayer::setNext):
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasBackgroundImage const): (WebCore::RenderStyle::hasFixedBackgroundImage const): (WebCore::RenderStyle::backgroundRepeatX const): (WebCore::RenderStyle::backgroundRepeatY const): (WebCore::RenderStyle::backgroundComposite const): (WebCore::RenderStyle::backgroundAttachment const): (WebCore::RenderStyle::backgroundClip const): (WebCore::RenderStyle::backgroundOrigin const): (WebCore::RenderStyle::backgroundXPosition const): (WebCore::RenderStyle::backgroundYPosition const): (WebCore::RenderStyle::backgroundSizeType const): (WebCore::RenderStyle::backgroundSizeLength const): (WebCore::RenderStyle::ensureBackgroundLayers): (WebCore::RenderStyle::maskImage const): (WebCore::RenderStyle::maskRepeatX const): (WebCore::RenderStyle::maskRepeatY const): (WebCore::RenderStyle::maskComposite const): (WebCore::RenderStyle::maskClip const): (WebCore::RenderStyle::maskOrigin const): (WebCore::RenderStyle::maskXPosition const): (WebCore::RenderStyle::maskYPosition const): (WebCore::RenderStyle::maskSizeType const): (WebCore::RenderStyle::maskSizeLength const): (WebCore::RenderStyle::ensureMaskLayers): (WebCore::RenderStyle::hasMask const): (WebCore::RenderStyle::setBackgroundXPosition): (WebCore::RenderStyle::setBackgroundYPosition): (WebCore::RenderStyle::setBackgroundSize): (WebCore::RenderStyle::setBackgroundSizeLength): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::inheritBackgroundLayers): (WebCore::RenderStyle::clearMaskLayers): (WebCore::RenderStyle::inheritMaskLayers): (WebCore::RenderStyle::setMaskImage): (WebCore::RenderStyle::setMaskXPosition): (WebCore::RenderStyle::setMaskYPosition): (WebCore::RenderStyle::setMaskSize):
- rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleBackgroundData::dump const):
- rendering/style/StyleBackgroundData.h:
Since
FillLayeris now ref-counted,StyleBackgroundData::backgroundneeds to be aDataRefas well.
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- rendering/style/StyleRareNonInheritedData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267258] by
-
- 5 edits2 adds in branches/safari-610-branch
Cherry-pick r266290. rdar://problem/69101142
[iOS] Vertical text's logical width calculation is stale from the previous height of the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=215910
Reviewed by Simon Fraser.
Source/WebCore:
When there is vertical text (really: orthogonal flows) in the content, the available width of the vertical
text is the height of its containing block. However, the height of the containing block (indeed: all ancestors)
may be "auto", in which case the CSS spec says the available width of the element should be "the initial
containing block's size."[1]
Previously, we were using the FrameView's visibleHeight as this metric. However, the visibleHeight is calculated
asynchronously, after layout, after a round-trip from the Web Process to the UI Process and back to the Web
Process. Therefore, if content changes the WKWebView's size and the web view immediatey re-lays-out, this
visibleHeight metric is stale from whatever the previous height of the WKWebView was. In addition, the
visibleHeight metric isn't even supposed to be used inside layout; it's instead only supposed to be used for
things like position: fixed elements.
Instead, we should use FrameView::layoutSize(), which is set before layout to the size of the WKWebView. The
name even indicates that it should be used for layout purposes.
[1] https://drafts.csswg.org/css-writing-modes-4/#orthogonal-auto
Test: WebKit.OrthogonalFlowAvailableSize
- rendering/RenderBox.cpp: (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
- rendering/RenderView.cpp: (WebCore::RenderView::availableLogicalHeight const):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/OrthogonalFlowAvailableSize.mm: Added. (TEST):
- TestWebKitAPI/Tests/WebKit/orthogonal-flow-available-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267257] by
-
- 4 edits in branches/safari-610-branch
Cherry-pick r266244. rdar://problem/69101147
REGRESSION (r264790): IndexedDB may abort transactions of in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=215855
<rdar://problem/67418574>
Reviewed by Youenn Fablet.
Source/WebCore:
We don't abort transactions on in-memory database before process suspension because they don't hold database
file lock. Before r264790, only ephemeral session would use in-memory databases, so we only checked session. Now
persistent session also uses in-memory databases for third-party storage, so we need to add another check.
API test: IndexedDB.SuspendImminentlyForThirdPartyDatabases
- Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::stopDatabaseActivitiesOnMainThread):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: (postResult): (catch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267256] by
-
- 5 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r266411. rdar://problem/68300959
[iOS] AGX compiler service sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>
Reviewed by Brent Fulgham.
For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::agxCompilerServices): (WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:34 PM Changeset in webkit [267255] by
-
- 3 edits1 add in trunk
DFG should ensure there are PhantomLocals for the taken block of op_jneq_ptr
https://bugs.webkit.org/show_bug.cgi?id=216669
Reviewed by Saam Barati.
JSTests:
- stress/jneq-ptr-opcode-variable-only-live-on-taken-branch.js: Added.
(bar):
(foo):
Source/JavaScriptCore:
Right now, if there is a local that is live on the taken branch but dead on
not-taken branch then nothing will preserve it for OSR exit. This patch simply
adds a PhantomLocal for each live operand for the first bytecode of the taken block.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:30 PM Changeset in webkit [267254] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r267137): PaintFrequencyTracker needs to track all the painting
https://bugs.webkit.org/show_bug.cgi?id=216677
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-18
Reviewed by Simon Fraser.
r267137 removed all the optimizations which the Design test got from
r230544 because it resets the renderingUpdateTimestamp to zero when it
exists. This makes RenderLayer always retrieves this timestamp with value
equal to zero. There is no direct call from Page::updateRendering() to
RenderLayer::paintLayerContents(). Painting has to be scheduled to the
next run-loop. Because SinglePaintFrequencyTracking tracks only the painting
whose timestamp is not zero, SinglePaintFrequencyTracking has not been
tracking any painting.
The solution is to track all the painting. When renderingUpdateTimestamp()
is zero, SinglePaintFrequencyTracking will use MonotonicTime::now() instead.
This will happen in cases like calling updateControlTints() before calling
Page::updateRendering().
- page/Page.cpp:
(WebCore::Page::updateRendering):
- page/Page.h:
(WebCore::Page::lastRenderingUpdateTimestamp const):
(WebCore::Page::renderingUpdateTimestamp const): Deleted.
- rendering/PaintFrequencyTracker.h:
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
(WebCore::SinglePaintFrequencyTracking::~SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):
- 12:18 PM Changeset in webkit [267253] by
-
- 6 edits1 copy4 moves60 adds in trunk/LayoutTests
Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216706
Reviewed by Eric Carlson.
Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink.
- webaudio/AudioContext/audiocontext-close-basic-expected.txt: Added.
- webaudio/AudioContext/audiocontext-close-basic.html: Added.
- webaudio/AudioContext/audiocontext-listener-should-not-crash-expected.txt: Added.
- webaudio/AudioContext/audiocontext-listener-should-not-crash.html: Added.
- webaudio/AudioListener/audiolistener-automation-position-expected.txt: Added.
- webaudio/AudioListener/audiolistener-automation-position.html: Added.
- webaudio/AudioListener/audiolistener-set-position-expected.txt: Added.
- webaudio/AudioListener/audiolistener-set-position.html: Added.
- webaudio/AudioNode/tail-connections-expected.txt: Added.
- webaudio/AudioNode/tail-connections.html: Added.
- webaudio/AudioNode/tail-processing-expected.txt: Added.
- webaudio/AudioNode/tail-processing.html: Added.
- webaudio/AudioParam/audioparam-automation-clamping-expected.txt: Added.
- webaudio/AudioParam/audioparam-automation-clamping.html: Added.
- webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold-expected.txt.
- webaudio/AudioParam/audioparam-cancel-and-hold.html: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold.html.
- webaudio/AudioParam/audioparam-clamp-time-to-current-time-expected.txt: Added.
- webaudio/AudioParam/audioparam-clamp-time-to-current-time.html: Added.
- webaudio/AudioParam/audioparam-initial-event-expected.txt: Added.
- webaudio/AudioParam/audioparam-initial-event.html: Added.
- webaudio/AudioParam/audioparam-k-rate-expected.txt: Added.
- webaudio/AudioParam/audioparam-k-rate.html: Added.
- webaudio/AudioParam/audioparam-linearRamp-value-attribute-expected.txt: Added.
- webaudio/AudioParam/audioparam-linearRamp-value-attribute.html: Added.
- webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt: Added.
- webaudio/AudioParam/audioparam-negative-exponentialRamp.html: Added.
- webaudio/AudioParam/audioparam-nominal-range-expected.txt: Renamed from LayoutTests/webaudio/audioparam-nominal-range-expected.txt.
- webaudio/AudioParam/audioparam-nominal-range.html: Renamed from LayoutTests/webaudio/audioparam-nominal-range.html.
- webaudio/AudioParam/audioparam-processing-expected.txt: Added.
- webaudio/AudioParam/audioparam-processing.html: Added.
- webaudio/AudioParam/audioparam-sampling-expected.txt: Added.
- webaudio/AudioParam/audioparam-sampling.html: Added.
- webaudio/AudioParam/audioparam-setTarget-timeConstant-0-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-limit-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-limit.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-sampling-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-copy-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-copy.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-duration-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-duration.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-end-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-end.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html: Added.
- webaudio/AudioParam/audioparam-update-value-attribute-expected.txt: Added.
- webaudio/AudioParam/audioparam-update-value-attribute.html: Added.
- webaudio/AudioParam/audioparam-value-setter-error-expected.txt: Added.
- webaudio/AudioParam/audioparam-value-setter-error.html: Added.
- webaudio/AudioParam/cancel-values-crash-913217-expected.txt: Added.
- webaudio/AudioParam/cancel-values-crash-913217.html: Added.
- webaudio/AudioParam/value-setter-warnings-expected.txt: Added.
- webaudio/AudioParam/value-setter-warnings.html: Added.
- webaudio/AudioParam/worklet-warnings-expected.txt: Added.
- webaudio/AudioParam/worklet-warnings.html: Added.
- webaudio/audioparam-exponentialRampToValueAtTime.html:
- webaudio/audioparam-linearRampToValueAtTime.html:
- webaudio/audioparam-setValueAtTime.html:
- webaudio/resources/audioparam-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audioparam-testing.js.
(renderLength):
(createConstantBuffer):
(createConstantArray):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(getStartEndFrames):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createReferenceSineArray):
(createSineWaveArray):
(endValueDelta):
(relativeErrorMetric):
(differenceErrorMetric):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/set-position-vs-curve-test.js: Added.
(testPositionSetterVsCurve):
- 11:55 AM Changeset in webkit [267252] by
-
- 7 edits in trunk
webaudio/Analyser/handle-silent-inputs.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=216708
Reviewed by Geoffrey Garen.
Source/WebCore:
Merge the following fix to AnalyserNode from Blink so that webaudio/Analyser/handle-silent-inputs.html
layout test starts passing:
No new tests, rebaselined existing test.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::process):
(WebCore::AnalyserNode::updatePullStatus):
(WebCore::AnalyserNode::tailTime const):
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
LayoutTests:
Rebaseline test that is now passing.
- webaudio/Analyser/handle-silent-inputs-expected.txt:
- 10:53 AM Changeset in webkit [267251] by
-
- 10 edits9 adds in trunk/LayoutTests/imported/w3c
Resync web-platform-tests/webaudio from upstream
https://bugs.webkit.org/show_bug.cgi?id=216700
Reviewed by Sam Weinig.
Resync web-platform-tests/webaudio from upstream 175a1086e0061c75d1.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/not-fully-active-helper.sub.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/w3c-import.log: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv.html:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/w3c-import.log:
- 10:52 AM Changeset in webkit [267250] by
-
- 4 edits in trunk/Source/WebKit
Webpages flash when getting closed
https://bugs.webkit.org/show_bug.cgi?id=216131
<rdar://problem/62264106>
Reviewed by Chris Dumez.
Closing a page in web process will detach root CA layer and clears content in view immediately. If this happens
in web process before transaction, which contains view hierachy change or layer change, is committed in UI
process, we would see a white flash. To try fixing this issue, we explicitly delay sending the close message
to next runloop cycle.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
- UIProcess/WebProcessProxy.cpp:
(WebKit::m_shutdownPreventingScopeCounter):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):
- UIProcess/WebProcessProxy.h: remove class ScopePreventingShutdown and use RefCounter to prevent process
shutdown.
(WebKit::WebProcessProxy::shutdownPreventingScope):
(WebKit::WebProcessProxy::ScopePreventingShutdown::ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::ScopePreventingShutdown::~ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::makeScopePreventingShutdown): Deleted.
- 10:26 AM Changeset in webkit [267249] by
-
- 9 edits in trunk/Source
Add internal flag to enable/disable H264 hardware encoder
https://bugs.webkit.org/show_bug.cgi?id=216534
Reviewed by Eric Carlson.
Source/WebCore:
Update process-wide hardware H264 boolean flag based on internal feature flag.
No change of behavior.
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):
(WebCore::LibWebRTCProviderCocoa::~LibWebRTCProviderCocoa):
(WebCore::LibWebRTCProviderCocoa::setH264HardwareEncoderAllowed): Deleted.
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setH264HardwareEncoderAllowed):
Source/WebKit:
- Shared/WebPreferencesInternal.yaml:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 10:19 AM Changeset in webkit [267248] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iOS wk2 ] compositing/clipping/border-radius-on-webgl.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215324
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 10:18 AM Changeset in webkit [267247] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.1
- 10:15 AM Changeset in webkit [267246] by
-
- 10 edits in trunk
Hash deviceIds in WebProcess instead of UIProcess to allow audio output device IDs in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=216693
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices-returned-objects.https-expected.txt:
Source/WebCore:
Make sure to create new MediaDeviceInfo objects everytime enumerateDevices is called.
Covered by updated tests.
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::computeDevices):
(WebCore::MediaDevices::enumerateDevices):
(WebCore::MediaDevices::refreshDevices): Deleted.
- Modules/mediastream/MediaDevices.h:
Source/WebKit:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
LayoutTests:
- fast/mediastream/device-change-event-2.html:
- 10:13 AM Changeset in webkit [267245] by
-
- 11 edits1 copy53 adds5 deletes in trunk/LayoutTests
Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216649
Reviewed by Eric Carlson.
Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink to extend
webaudio test coverage.
- webaudio/Analyser/automatic-pull-node-expected.txt: Added.
- webaudio/Analyser/automatic-pull-node.html: Added.
- webaudio/Analyser/handle-silent-inputs-expected.txt: Added.
- webaudio/Analyser/handle-silent-inputs.html: Added.
- webaudio/Analyser/realtimeanalyser-byte-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-byte-data.html: Added.
- webaudio/Analyser/realtimeanalyser-downmix-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-downmix.html: Added.
- webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-fftsize-reset.html: Added.
- webaudio/Analyser/realtimeanalyser-float-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-float-data.html: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html: Added.
- webaudio/Analyser/realtimeanalyser-freq-data.html: Added.
- webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-multiple-calls.html: Added.
- webaudio/Analyser/realtimeanalyser-zero-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-zero.html: Added.
- webaudio/AudioBuffer/audiobuffer-resample-expected.txt: Added.
- webaudio/AudioBuffer/audiobuffer-resample.html: Added.
- webaudio/AudioBuffer/huge-buffer-expected.txt: Added.
- webaudio/AudioBuffer/huge-buffer.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulation-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-late-start-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-late-start.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-points-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-points.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-detune-modulation-expected.wav: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-loop-points-expected.wav: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-playbackrate-modulation-expected.wav: Added.
- webaudio/audiobuffersource-loop-comprehensive-expected.txt: Removed.
- webaudio/audiobuffersource-loop-comprehensive.html: Removed.
- webaudio/audiobuffersource-loop-points-expected.wav: Removed.
- webaudio/audiobuffersource-loop-points.html: Removed.
- webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html:
- webaudio/audiobuffersource-negative-playbackrate-interpolated.html:
- webaudio/audiobuffersource-negative-playbackrate-loop.html:
- webaudio/audiobuffersource-negative-playbackrate.html:
- webaudio/audiobuffersource-playbackrate-expected.wav: Removed.
- webaudio/audiobuffersource-start.html:
- webaudio/resources/audiobuffersource-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audiobuffersource-testing.js.
(createTestBuffer):
(createRamp):
(checkSingleTest):
(checkAllTests):
- webaudio/resources/audiobuffersource-testing.js:
(createTestBuffer):
(checkSingleTest):
(checkAllTests):
(createSawtoothWithModulation):
- webaudio/resources/buffer-loader.js:
(BufferLoader):
(request.onload):
(request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):
- webaudio/resources/fft.js: Added.
(FFT):
(this.toString):
(FFT.prototype.FFTException):
(FFT.prototype.FFTRadix2Core):
(FFT.prototype.fft):
(FFT.prototype.iFFTRadix2Core):
(FFT.prototype.ifft):
(FFT.prototype.ifftScale):
(FFT.prototype.RFFTRadix2CoreStage1):
(FFT.prototype.rfft):
- webaudio/resources/realtimeanalyser-testing.js: Added.
(createGraph):
(applyWindow):
(computeFFTMagnitude):
(dbToLinear):
(linearToDb):
(clipMagnitude):
(compareFloatFreq):
(smoothFFT):
(convertFloatToByte):
- 10:08 AM Changeset in webkit [267244] by
-
- 1 copy in branches/safari-610.2.6.1-branch
New branch.
- 10:03 AM Changeset in webkit [267243] by
-
- 12 edits1 delete in trunk
REGRESSION(r254031): Captions fail to load on jw.org
https://bugs.webkit.org/show_bug.cgi?id=216672
<rdar://problem/69016059>
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
- web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:
Source/WebCore:
Revert r254031.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::load):
LayoutTests:
- http/tests/security/contentSecurityPolicy/resources/track.php: Removed.
- http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
- http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
- http/tests/security/text-track-crossorigin-expected.txt:
- http/tests/security/text-track-crossorigin.html:
- 10:02 AM Changeset in webkit [267242] by
-
- 2 edits in branches/safari-610-branch/Tools
Cherry-pick r267224. rdar://problem/57029120
Unreviewed test gardening for rdar://57029120.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:43 AM Changeset in webkit [267241] by
-
- 2 edits in trunk/Source/WebCore
[macOS Big Sur] ASSERTION FAILED: !m_gamepadMap.get(device)./platform/gamepad/mac/HIDGamepadProvider.mm(233) under WebCore::HIDGamepadProvider::deviceAdded
https://bugs.webkit.org/show_bug.cgi?id=216665
<rdar://problem/68641574>
Reviewed by Alex Christensen.
On macOS Big Sur, it appears we get notified multiple times that the Shenzhen Longshengwei Technology Gamepad
is getting added during Gamepad.GCFVersusHID API test. This was causing an assertion to be hit under
HIDGamepadProvider::deviceAdded() where we expected the device not not already be in the map. In this patch,
we work around this HID quirk on Big Sur by ignoring the notification if we already know about the device.
No new tests, fixes existing API test.
- platform/gamepad/mac/HIDGamepadProvider.mm:
(WebCore::HIDGamepadProvider::deviceAdded):
- 9:43 AM Changeset in webkit [267240] by
-
- 2 edits in trunk/Source/WebCore
Vectorize SetTargetAtTime processing in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=216673
<rdar://problem/69111432>
Reviewed by Sam Weinig.
Fix the SSE implementation of VectorMath::vsadd() to properly deal with source
and destination alignment, similarly to what is done in other VectorMath functions.
No new tests, fixes existing crash on GTK bots.
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsadd):
- 9:32 AM Changeset in webkit [267239] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unified build fixes from ARMv7 build failures
https://bugs.webkit.org/show_bug.cgi?id=216698
Reviewed by Adrian Perez de Castro.
- llint/LLIntThunks.cpp:
- runtime/FileBasedFuzzerAgent.cpp:
- runtime/FunctionExecutableDump.cpp:
- runtime/NativeExecutable.cpp:
- runtime/WeakMapImpl.cpp:
- 8:24 AM Changeset in webkit [267238] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html.
- web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
- 8:13 AM Changeset in webkit [267237] by
-
- 6 edits in trunk/Source/WebKit
Unified build fixes in media code
https://bugs.webkit.org/show_bug.cgi?id=216691
Reviewed by Sam Weinig.
Add missing includes and/or missing undef.
No change of behavior.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- WebProcess/WebPage/WebPageOverlay.h:
- WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSource.h:
- 5:15 AM Changeset in webkit [267236] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Move computedLineLogicalRect to InlineFormattingContext::Geometry
https://bugs.webkit.org/show_bug.cgi?id=216680
Reviewed by Simon Fraser.
This function computes line geometry. It belongs in InlineFormattingContext::Geometry.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const): Deleted.
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):
- 4:23 AM Changeset in webkit [267235] by
-
- 2 edits in trunk/Source/WebKit
Enable paint timing by default
https://bugs.webkit.org/show_bug.cgi?id=211736
Reviewed by Simon Fraser.
- Shared/WebPreferencesExperimental.yaml:
PaintTimingEnabled default to true.
- 4:16 AM Changeset in webkit [267234] by
-
- 9 edits in trunk/Source/WebCore
[LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
https://bugs.webkit.org/show_bug.cgi?id=216678
Reviewed by Simon Fraser.
Move the LineBox related logic out of the LineBox class to InlineFormattingContext::Geometry::LineBoxBuilder.
This makes the LineBox class a light, box like class that we can cache in the InlineFormattingState.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::formattingContext const):
(WebCore::Layout::LineBoxBuilder::root const):
(WebCore::Layout::LineBoxBuilder::layoutState const):
(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
(WebCore::Layout::LineBoxBuilder::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBoxBuilder::alignInlineBoxesVerticallyAndComputeLineBoxHeight):
(WebCore::Layout::InlineFormattingContext::Geometry::lineBoxForLineContent):
- layout/inlineformatting/InlineLine.cpp:
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_isLineVisuallyEmpty):
(WebCore::Layout::LineBox::addRootInlineBox):
(WebCore::Layout::LineBox::addInlineBox):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::collectHangingContent): Deleted.
(WebCore::Layout::horizontalAlignmentOffset): Deleted.
(WebCore::Layout::m_inlineFormattingContext): Deleted.
(WebCore::Layout::LineBox::constructInlineBoxes): Deleted.
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight): Deleted.
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight): Deleted.
(WebCore::Layout::LineBox::formattingContext const): Deleted.
(WebCore::Layout::LineBox::root const): Deleted.
(WebCore::Layout::LineBox::layoutState const): Deleted.
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setHorizontalAlignmentOffset):
(WebCore::Layout::LineBox::rootInlineBox):
(WebCore::Layout::LineBox::nonRootInlineBoxes const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
- layout/inlineformatting/InlineLineBuilder.h:
- 4:10 AM Changeset in webkit [267233] by
-
- 2 edits in trunk/LayoutTests
[WPE] Unreviewed test gardening. Mark several fast/layoutformattingcontext as failure after r267024.
- platform/wpe/TestExpectations:
- 3:35 AM WebKitGTK/2.30.x edited by
- (diff)
- 2:18 AM Changeset in webkit [267232] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po
Merge r267228 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=216436
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.
- pt_BR.po:
- 2:18 AM Changeset in webkit [267231] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Merge r267226 - [GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
https://bugs.webkit.org/show_bug.cgi?id=216430
Reviewed by Adrian Perez de Castro.
Source/WebKit:
The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().
Tools:
Add unit test to check we can start downloads in ephemeral sessions before a web view is created.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadEphemeralContext):
(beforeAll):
- 2:17 AM Changeset in webkit [267230] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit
Unreviewed. [GTK] Add an env var to force single process model
WEBKIT_USE_SINGLE_WEB_PROCESS=1 can be used to force the single process model when PSON is disabled. This is a
temporary solution for applications still depending on the single process mode behavior. It will be only
available in 2.28 series.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
- 1:20 AM Changeset in webkit [267229] by
-
- 2 edits in trunk/Tools
[ews] Set only one worker for JSC ARMv7 builder and tester queues
https://bugs.webkit.org/show_bug.cgi?id=216476
Reviewed by Aakash Jain.
Currently many builds are failing in EWS JSC ARMv7 tester queue due to
a linking error in libicu. The problem lies on the boards that are
used to run the tests which have different system libraries.
Temporarily use one single builder and tester producing binaries compatible
with the boards.
- BuildSlaveSupport/ews-build/config.json:
- 1:19 AM Changeset in webkit [267228] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=216436
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.
- pt_BR.po:
- 1:15 AM Changeset in webkit [267227] by
-
- 23 edits5 adds in trunk
XHR.timeout is affected by long tasks
https://bugs.webkit.org/show_bug.cgi?id=216266
<rdar://problem/68908150>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/xhr/xhr-timeout-longtask.any-expected.txt: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.html: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.js: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.worker-expected.txt: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html: Added.
Source/WebCore:
Long tasks may block the main thread, which may block IPC processing of load messages.
In that case, even though the load is finished, WebProcess did not know that yet and will cancel the load.
To prevent that, in case of XHR timeout, do an explicit check to compute the done flag.
https://fetch.spec.whatwg.org/#done-flag
Tests: imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.html
imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::computeIsDone):
- loader/DocumentThreadableLoader.h:
- loader/LoaderStrategy.h:
- loader/ThreadableLoader.h:
- loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::notifyIsDone):
- loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::notifyIsDone):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::notifyIsDone):
- loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::MainThreadBridge::loaderProxy):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReachTimeout):
(WebCore::XMLHttpRequest::notifyIsDone):
- xml/XMLHttpRequest.h:
Source/WebKit:
Go to network process to know whether a load is finished or not.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::isResourceLoadFinished):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::isResourceLoadFinished):
- WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::isResourceLoadFinished):
- WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
platform/mac-wk1/TestExpectations: Skip WK1 test.
- 1:14 AM Changeset in webkit [267226] by
-
- 4 edits in trunk
[GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
https://bugs.webkit.org/show_bug.cgi?id=216430
Reviewed by Adrian Perez de Castro.
Source/WebKit:
The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().
Tools:
Add unit test to check we can start downloads in ephemeral sessions before a web view is created.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadEphemeralContext):
(beforeAll):
- 12:38 AM Changeset in webkit [267225] by
-
- 4 edits in trunk/Source/WebKit
Enable MediaRecorder by default on MacOS
https://bugs.webkit.org/show_bug.cgi?id=216663
Reviewed by Eric Carlson.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultMediaRecorderEnabled):
- Shared/WebPreferencesDefaultValues.h:
- Shared/WebPreferencesExperimental.yaml:
Sep 17, 2020:
- 9:54 PM Changeset in webkit [267224] by
-
- 2 edits in trunk/Tools
Unreviewed test gardening for rdar://57029120.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
- 9:11 PM Changeset in webkit [267223] by
-
- 2 edits in branches/safari-610-branch/Tools
Cherry-pick r266182. rdar://problem/66950074
TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>
Reviewed by Jer Noble.
This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.
- TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force GC while waiting for status to change. (TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:08 PM Changeset in webkit [267222] by
-
- 31 edits in trunk
Remove runtime setting for enabling/disabling the UserTiming and ResourceTiming APIs
https://bugs.webkit.org/show_bug.cgi?id=216556
Reviewed by Darin Adler.
Remove runtime setting for enabling/disabling UserTiming and ResourceTiming
APIs. They have both been on for a while in WebKit2 and there aren't any
known uses cases for disabling them. In addition to removing the setting,
they are now enabled in LegacyWebKit as well.
Source/WebCore:
In addition to removing UserTiming and ResourceTiming, we can also remove the
checks for PerformanceTimelineEnabled, as that was defined entirely in terms
of the former.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportResourceTiming):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
- page/Performance.idl:
- page/PerformanceEntry.cpp:
(WebCore::PerformanceEntry::parseEntryTypeString):
- page/PerformanceEntry.idl:
- page/PerformanceObserver.idl:
- page/PerformanceObserverEntryList.idl:
- page/PerformanceResourceTiming.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUserTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::userTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::performanceTimelineEnabled const): Deleted.
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUserTimingEnabled):
(WKPreferencesGetUserTimingEnabled):
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setUserTimingEnabled:]):
(-[WebPreferences userTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
(-[WebPreferences resourceTimingEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setUserTimingEnabled):
(WebPreferences::userTimingEnabled):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 7:06 PM Changeset in webkit [267221] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) in speculationFromCell()'s isSanePointer().
https://bugs.webkit.org/show_bug.cgi?id=216638
Reviewed by Saam Barati.
We should be using OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) instead of assuming the
width of the pointer address bits.
- bytecode/SpeculatedType.cpp:
(JSC::isSanePointer):
- 6:45 PM Changeset in webkit [267220] by
-
- 23 edits in trunk
Selection API: Introduce LiveRangeSelectionEnabled, off by default
https://bugs.webkit.org/show_bug.cgi?id=216656
Reviewed by Sam Weinig.
Source/WebCore:
For interoperability, the Selection API requires behavior that is quite different
from how our Selection object has behaves historically. Specifically, the range
returned is a live range that update as the selection updates and the selection,
in turn, is updated if the returned range is modified.
This significant change will have compatibility impact on websites and other
content that assumes the legacy WebKit behavior, so we are developing it behind
a feature flag, LiveRangeSelectionEnabled.
This patch introduces the live range selection behind the flag, but leaves one
significant area unresolved, changing selection to keep track of the original
endpoints rather than only canonicalized endpoints, and a couple of loose ends,
lifetime of ride-along properties on the live range object, and updating test
expectations for the new behavior.
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Fixed timing of call to Document::textRemoved
by letting setDataAndUpdate do it; otherwise it can be called after the selection
has been updated, and the range gets updated twice.
(WebCore::CharacterData::appendData): Pass UpdateLiveRanges::No to setDataAndUpdate,
to preserve the existing "don't update ranges" behavior for now at least.
(WebCore::CharacterData::insertData): Fixed timing of call to Document::textInserted
by letting setDataAndUpdate do it, for the same reason as above.
(WebCore::CharacterData::deleteData): Ditto, for textRemoved.
(WebCore::CharacterData::replaceData): Ditto, for textRemoved and textInserted.
(WebCore::CharacterData::setDataAndUpdate): Added UpdateLiveRanges argument and
calls to textRemoved and textInserted, after setting data, but before other updates.
- dom/CharacterData.h: Made setDataAndUpdate protected and added UpdateLiveRanges.
- dom/Document.h: Added optimized version of the Node::contains function. When the
node in question is the document we can just check treeScope and isConnected
rather than walking up the tree.
- dom/Node.cpp:
(WebCore::Node::isDescendantOf const): Moved special case for document to the top
of the function; seems a more important special case than disconnected nodes and
nodes with no children.
(WebCore::Node::isDescendantOrShadowDescendantOf const): Reworded the FIXME for clarity.
(WebCore::Node::contains const): Changed this to toke a reference instead of a pointer.
The pointer flavor is now inlined in the header.
- dom/Node.h: Added an overload of contains that takes a reference, analogous to what
we already have for isDescendantOf.
- dom/Position.cpp:
(WebCore::Position::Position): Removed too-strict assertions. When we start using
positions to represent arbitrary DOM positions for things outside editing we won't
want these assertions any more, and we hit them when we use Position in a more
straightforward way, like some cases in this patch.
(WebCore::Position::primaryDirection const): Added a missing null check. This case
is hit in some test cases in the new mode.
- dom/Range.cpp: Removed some, but probably not all, of the unneeded headers.
(WebCore::Range::~Range): Added an assertion.
(WebCore::Range::updateAssociatedSelection): Added. Tells FrameSelection to update
the selection when this is the live range associated with the selection.
(WebCore::Range::updateDocument): Added an assertion.
(WebCore::Range::setStart): Call updateAssociatedSelection.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::collapse): Ditto.
(WebCore::Range::processContents): Call collapse here to share slightly more
code so we don't have to call updateAssociatedSelection here.
(WebCore::Range::checkNodeOffsetPair): Made this a static function so it can
be used outside the Range class. Also fixed indentation of the switch statement.
(WebCore::Range::selectNodeContents): Call updateAssociatedSelection and
updateDocument.
(WebCore::setBothEndpoints): Added.
(WebCore::Range::updateFromSelection): Added. Uses setBothEndpoints.
(WebCore::createLiveRange): Refactored to call setBothEndpoints.
- dom/Range.h: Added didAssociateWithSelection, didDisassociateFromSelection,
updateFromSelection, updateAssociatedSelection, and m_isAssociatedWithSelection.
Also made checkNodeOffsetPair a public static member function instead of a
private non-static member function.
- dom/Text.cpp:
(WebCore::Text::setDataAndUpdate): Update to pass along UpdateLiveRanges argument.
- dom/Text.h: Ditto. Also made the override of setDataAndUpdate private.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Call
updateAssociatedLiveRange after updating the selection.
(WebCore::containsEndpoints): Added. Used to check if a live range still has the
document as its root node so it can remain associated this with the selection.
(WebCore::FrameSelection::associatedLiveRange): Added.
(WebCore::FrameSelection::disassociateLiveRange): Added.
(WebCore::FrameSelection::associateLiveRange): Added.
(WebCore::FrameSelection::updateFromAssociatedLiveRange): Added.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added.
- editing/FrameSelection.h: Added associatedLiveRange, associateLiveRange,
disassociateLiveRange, updateFromAssociatedLiveRange, updateAssociatedLiveRange,
and m_associatedLiveRange. Also change m_document to a WeakPtr and do some
tidying up.
- page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor): Assert the live range setting is false,
since this code is not used in that case. Changed the return type to RefPtr.
Address the FIXME here by getting the document in a simpler way.
(WebCore::DOMSelection::create): Moved here from the header.
(WebCore::DOMSelection::frame const): Added. Returns a RefPtr. This gets rid
of the need for various instances of the "protector" pattern in this file.
(WebCore::DOMSelection::range const): Added. Returns the selected range, but
checks for the shadow tree case and returns null in that case.
(WebCore::DOMSelection::anchorPosition const): Redid as a member function.
(WebCore::DOMSelection::focusPosition const): Ditto.
(WebCore::DOMSelection::basePosition const): Ditto.
(WebCore::DOMSelection::extentPosition const): Ditto.
(WebCore::DOMSelection::anchorNode const): Rewrote to be simpler using the
functions above.
(WebCore::DOMSelection::anchorOffset const): Ditto.
(WebCore::DOMSelection::focusNode const): Ditto.
(WebCore::DOMSelection::focusOffset const): Ditto.
(WebCore::DOMSelection::baseNode const): Ditto.
(WebCore::DOMSelection::baseOffset const): Ditto.
(WebCore::DOMSelection::extentNode const): Ditto.
(WebCore::DOMSelection::extentOffset const): Ditto.
(WebCore::DOMSelection::isCollapsed const): Rewrote using DOMSelection::range
and SimpleRange::collapsed.
(WebCore::DOMSelection::type const): Updated since frame returns RefPtr.
(WebCore::DOMSelection::rangeCount const): Ditto.
(WebCore::DOMSelection::collapse): Added new corrected checking for special
cases, guarded by the setting.
(WebCore::DOMSelection::collapseToEnd): Updated since frame returns RefPtr.
way to do protection. Added a call to disassociateLiveRange. No need to put
under a setting guard since it does nothing if feature is not enabled.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::empty): Call removeAllRanges so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::setBaseAndExtent): Use makeRefPtr, added corrected
checking for special cases guarded by the setting.
(WebCore::DOMSelection::setPosition): Call collapse so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::modify): Updated since frame returns RefPtr.
(WebCore::DOMSelection::extend): Ditto. Also added corrected checking for
special cases guarded by the setting.
(WebCore::DOMSelection::getRangeAt): Added a version of this function that
simply returns the associated live range, creating one if needed, guarded
by the setting.
(WebCore::DOMSelection::removeAllRanges): Updated since frame returns RefPtr.
(WebCore::DOMSelection::addRange): Added a version of this function that
matches the specification, guarded by the setting.
(WebCore::DOMSelection::removeRange): Added.
(WebCore::DOMSelection::deleteFromDocument): Added a version of this
function that simply calls deleteContents on the associated live range,
guarded by the setting.
(WebCore::DOMSelection::containsNode const): Put the text node workaround
inside a setting check. I also figured out why workaround was added: it
works around unwanted range canonicalization in various tests, but also
introduces incorrect behavior. Also rewrote to use DOMSelection::range.
(WebCore::DOMSelection::toString): Use DOMSelection::range, guarded by
the setting, so we return empty string when selection is in the shadow tree.
(WebCore::DOMSelection::shadowAdjustedNode const): When the live range
setting is enabled, adjust by changing the node to nullptr, not finding an
ancestor in the document.
(WebCore::DOMSelection::shadowAdjustedOffset const): Ditto, but offset 0.
(WebCore::DOMSelection::isValidForPosition const): Assert that the live range
selection setting is disabled, because this incorrect check should only be
used to preserve legacy behavior until we are ready to turn it on.
- page/DOMSelection.h: Updated since setBaseAndExtent, setPosition, and
collapse can raise exceptions, although they only do so when the live range
selection setting is on. Added removeRange. Moved the create function
out of the class definition into the .cpp file. Made return values of
baseNode, extentNode, anchorNode, focusNode, and shadowAdjustedNode RefPtr.
Made toString const. Added frame, range, anchorPosition, focusPosition,
basePosition, and extentPosition private functions. Removed visibleSelection.
- page/DOMSelection.idl: Updated file to match a recent draft of the
Selection standard, reordering things to match the order they appear there.
Added removeRange, guarded by the setting. Also got rid of the
unncecessary "undefined" string defaults for the arguments to the modify
method since they have no effect on observed behavior anyway.
- page/Settings.yaml: Added liveRangeSelectionEnabled.
Source/WebKit:
- Shared/WebPreferencesInternal.yaml: Added LiveRangeSelectionEnabled.
LayoutTests:
- editing/selection/move-to-line-boundary-clear-selection.html: Fix test that accidentally
relied on our non-standard behavior of clamping a too-high offset to a valid value. This
was not what we were trying to test. Without this change, the test fails in the new mode.
The offset was "5", which seems to be a character count, rather than "1", meaning "after
the text node".
- editing/selection/toString-1.html: Ditto. The offset here was 3, but the HTML element
has only 2 children, the head and the body.
- editing/selection/user-select-all-selection.html: Ditto. The code was passing the wrong
container by acccident, the parent of the text node rather than the text node.
- 6:44 PM Changeset in webkit [267219] by
-
- 5 edits in trunk/Source
Web Inspector: REGRESSION(r266885): fix open source build
https://bugs.webkit.org/show_bug.cgi?id=216675
Reviewed by Timothy Hatcher.
Add back methods used by
WebInspector.framework.
Source/JavaScriptCore:
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::getInteger): Added.
(Inspector::BackendDispatcher::getDouble): Added.
(Inspector::BackendDispatcher::getString): Added.
Source/WTF:
- wtf/JSONValues.h:
- wtf/JSONValues.cpp:
(WTF::JSONImpl::Value::asDouble const): Added.
(WTF::JSONImpl::Value::asInteger const): Added.
(WTF::JSONImpl::Value::asString const): Added.
(WTF::JSONImpl::ObjectBase::getBoolean const): Added.
(WTF::JSONImpl::ObjectBase::getString const): Added.
(WTF::JSONImpl::ObjectBase::getObject const): Added.
(WTF::JSONImpl::ObjectBase::getArray const): Added.
(WTF::JSONImpl::ObjectBase::getValue const): Added.
- 6:33 PM Changeset in webkit [267218] by
-
- 11 edits2 deletes in trunk
Vectorize SetTargetAtTime processing in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=216673
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode-expected.txt:
Source/WebCore:
Vectorize SetTargetAtTime processing in AudioParamTimeline.
The patch is based on the Blink implementation at:
I have however added the USE(ACCELERATE) and HAVE(ARM_NEON_INTRINSICS) implementations
for DARWIN and non-SSE platforms.
This allows us to pass some more tests that we were failing merely due to precision
issues. Now that our implemention matches Blink's, our results are consistent
with Blink.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::processSetTarget):
- Modules/webaudio/AudioParamTimeline.h:
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsadd):
(WebCore::VectorMath::vsmul):
- platform/audio/VectorMath.h:
LayoutTests:
- webaudio/audioparam-cancel-and-hold-expected.txt:
Rebaseline test now that one more subtest is passing.
- webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
- webaudio/audioparam-setTargetAtTime.html: Removed.
Remove outdated test now that it was upstreamed to WPT. The updated
copy resides at:
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime.html
- 6:32 PM Changeset in webkit [267217] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215773
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 6:17 PM Changeset in webkit [267216] by
-
- 3 edits1 add in trunk
Inconsistent loop exit assertion in B3ReduceLoopStrength
https://bugs.webkit.org/show_bug.cgi?id=216274
<rdar://problem/68513573>
Reviewed by Keith Miller.
JSTests:
- stress/reduce-loop-strength-multiple-exits.js: Added.
(build_array):
(main):
Source/JavaScriptCore:
On B3ReduceLoopStrength, we first calculate where the loop exits to, and ensure there's only
one exit target. Later on, we compute how many places within the loop exit to that single exit
target. Currently, we assume that having a single target implies that we'll only ever have one
exit point, which is incorrect. To fix it, instead of asserting there should only be one exit
point, we just bail if we find more than one.
- b3/B3ReduceLoopStrength.cpp:
(JSC::B3::ReduceLoopStrength::reduceByteCopyLoopsToMemcpy):
- 5:50 PM Changeset in webkit [267215] by
-
- 4 edits in trunk/Source
Per-app accent color overrides are broken
https://bugs.webkit.org/show_bug.cgi?id=216674
<rdar://problem/67745464>
Reviewed by Wenson Hsieh.
Source/WebCore/PAL:
- pal/spi/mac/NSApplicationSPI.h:
Source/WebKit:
No new tests; I've no idea how to write a test that would have caught this;
any test I can imagine would have also written to _accentColor and worked fine.
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::accentColor):
AppKit changed the meaning of the IPI. Use the correct version.
We still write to _accentColor; it is now purely an override.
- 5:33 PM Changeset in webkit [267214] by
-
- 3 edits in branches/safari-610-branch
Cherry-pick r267162. rdar://problem/69104937
REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619
Reviewed by Chris Dumez.
Tools:
In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
LayoutTests:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:50 PM Changeset in webkit [267213] by
-
- 1 copy in tags/Safari-610.2.6
Tag Safari-610.2.6.
- 3:50 PM Changeset in webkit [267212] by
-
- 1 delete in tags/Safari-610.2.6
Delete tag.
- 3:46 PM Changeset in webkit [267211] by
-
- 1 copy in tags/Safari-610.2.6
Tag Safari-610.2.6.
- 3:36 PM Changeset in webkit [267210] by
-
- 4 edits2 adds in trunk
[Cocoa] canPlayType('audio/mpeg; codecs="mp3"') returns ""
https://bugs.webkit.org/show_bug.cgi?id=147309
Reviewed by Darin Adler.
Source/WebCore:
'audio/mpeg; codecs="mp3"' is not an RFC 3003 compliant MIME type but some big
web sites use it. AVFoundation says the type is not supported, but MediaPlayerPrivateMediaSourceAVFObjC
previously returned "maybe" for all extended types where the container type is
supported. This bug was fixed when we moved the MIME type logic from MediaPlayerPrivateMediaSourceAVFObjC
to MIMETypeCache, so add a mechanism to override extended types and use it to
support 'audio/mpeg; codecs="mp3"'.
Test: media/media-can-play-mp3.html
- platform/graphics/MIMETypeCache.cpp:
(WebCore::MIMETypeCache::canDecodeType):
(WebCore::MIMETypeCache::overrideExtendedType):
- platform/graphics/MIMETypeCache.h:
LayoutTests:
- media/media-can-play-mp3-expected.txt: Added.
- media/media-can-play-mp3.html: Added.
- 2:45 PM Changeset in webkit [267209] by
-
- 8 edits in branches/safari-610-branch/Source
Versioning.
WebKit-7610.2.7
- 1:42 PM Changeset in webkit [267208] by
-
- 2 edits in trunk/Source/WebKit
Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>
Reviewed by Brent Fulgham.
Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.
No new tests, no way currently to test apps with different iOS
versions. Tested manually.
- Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::determineITPStateInternal):
Ignore the early return for the linked-on-or-after check if the
app has the default browser entitlement so we still enable ITP based
on the user's preference.
- 1:33 PM Changeset in webkit [267207] by
-
- 3 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266772. rdar://problem/69087333
[ iOS wk2 ] fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216300
<rdar://problem/68542670>
Reviewed by Wenson Hsieh.
- fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: shouldBecomeDifferent only works if both of the strings it evals are evaluable in the global scope.
- platform/ios-wk2/TestExpectations: Remove the failure expectation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:21 PM Changeset in webkit [267206] by
-
- 2 edits in trunk/Source/WebKit
WebKit::XPCServiceEventHandler block should call exit() on the main thread
<https://webkit.org/b/216594>
<rdar://problem/68053217>
Reviewed by Chris Dumez.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Call exit() on the main thread. I chose dispatch_sync() here so that if other crashes occur on the main thread, we will know if this background thread is waiting to call exit() at the same time. Also, if a different background thread calls exit() in the future with this block running on the main thread, we'll know where the block came from since the XPC handler thread will be waiting for the dispatch_sync() to return (instead of having a mysterious block calling exit() on the main thread and not knowing where it came from).
- Add logging (including simulated crash logs) when either of these exit() code paths is taken.
- 12:52 PM Changeset in webkit [267205] by
-
- 3 edits2 adds in trunk
Segfault in WebCore::IDBKey::createBinary
https://bugs.webkit.org/show_bug.cgi?id=216501
Reviewed by Youenn Fablet.
Source/WebCore:
If we can't get a copy of the JSBufferView, return an invalid IDBKey.
This can happen if we are low on memory. The existing calling code already
handles the case where we might produce an invalid IDBKey.
Test: storage/indexeddb/IDBKey-create-array-buffer-view-oom.html
- Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::createBinary):
LayoutTests:
New test. Since this test is looking for the out of memory condition, the test is written
to avoid false failures in the case we can't achieve out of memory. That is when the
expected exception is not thrown.
- storage/indexeddb/IDBKey-create-array-buffer-view-oom-expected.txt: Added.
- storage/indexeddb/IDBKey-create-array-buffer-view-oom.html: Added.
- 12:28 PM Changeset in webkit [267204] by
-
- 7 edits in trunk/Source/WebCore
Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
https://bugs.webkit.org/show_bug.cgi?id=216654
Reviewed by Simon Fraser.
Before we implemented the correct way to sort animations using KeyframeEffectStack, we relied on distinct animation collections
for CSS Transtions and CSS Animations and remaining Web Animations on ElementAnimationRareData. We don't need those anymore and
we can use a single collection which we can now name animations() for all animations.
Additionally, the AnimationTimeline::animationsForElement() method where these collections were used when requesting unsorted
animations was unnecessary and an incorrect design. Animations do not belong to a given timeline, so we now use the accessors
on ElementAnimationRareData directly to get the sorted list of effects or the single animations collection.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::willChangeRendererForElement):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::animationsForElement const): Deleted.
- animation/AnimationTimeline.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationCanBeRemoved):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement):
- animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::animations):
(WebCore::ElementAnimationRareData::webAnimations): Deleted.
(WebCore::ElementAnimationRareData::cssAnimations): Deleted.
(WebCore::ElementAnimationRareData::transitions): Deleted.
- dom/Element.cpp:
(WebCore::Element::animations const):
(WebCore::Element::ensureAnimations):
(WebCore::Element::getAnimations):
(WebCore::Element::webAnimations const): Deleted.
(WebCore::Element::cssAnimations const): Deleted.
(WebCore::Element::transitions const): Deleted.
(WebCore::Element::ensureWebAnimations): Deleted.
(WebCore::Element::ensureCSSAnimations): Deleted.
(WebCore::Element::ensureTransitions): Deleted.
- dom/Element.h:
- 11:54 AM Changeset in webkit [267203] by
-
- 10 edits in trunk/Source
Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for.
https://bugs.webkit.org/show_bug.cgi?id=216651
Patch by Hoa Dinh <dvh@apple.com> on 2020-09-17
Reviewed by Alex Christensen.
Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks and reflects the change where it's used.
Source/WebCore:
Source/WebCore:
- loader/FrameLoaderTypes.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
Source/WebKit:
Source/WebKit:
- Shared/SessionState.cpp:
(WebKit::isValidEnum):
- UIProcess/API/APINavigationAction.h:
- UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(toExternalURLsPolicy):
(toWebCoreExternalURLsPolicy):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeSessionHistoryEntry):
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- 11:39 AM Changeset in webkit [267202] by
-
- 7 edits in trunk
AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent
https://bugs.webkit.org/show_bug.cgi?id=216629
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:
Source/WebCore:
AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent.
This behavior is consistent with Gecko and Blink. Previously, we'd use AnalyserNode.minDecibels
instead.
No new tests, rebaselined existing test.
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
- platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::linearToDecibels):
- 11:10 AM Changeset in webkit [267201] by
-
- 7 edits1 add in trunk/LayoutTests
Regression(r267144) 4 webaudio/oscillator tests are broken
https://bugs.webkit.org/show_bug.cgi?id=216625
<rdar://problem/69024624>
Reviewed by Darin Adler.
- webaudio/oscillator-custom.html:
- webaudio/oscillator-sawtooth.html:
- webaudio/oscillator-sine.html:
- webaudio/oscillator-square.html:
- webaudio/oscillator-triangle.html:
Update tests to use oscillator-testing-legacy.js since they are not compatible
with the newer oscillator-testing.js that was resync'd from Blink.
- webaudio/oscillator-triangle-expected.wav:
Rebaseline test that has different output due to the fix in r267153.
- webaudio/resources/oscillator-testing-legacy.js: Added.
Restore old copy of oscillator-testing.js and rename it to oscillator-testing-legacy.js.
- 11:07 AM Changeset in webkit [267200] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] bwrap: add pipewire socket as bind mount
https://bugs.webkit.org/show_bug.cgi?id=216606
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-09-17
Reviewed by Philippe Normand.
Add pipewire socket to bwrap as a try binding mount.
- flatpak/webkit-bwrap:
- 10:54 AM Changeset in webkit [267199] by
-
- 4 edits3 adds in trunk
[JSC] Async generator default-export is not handled
https://bugs.webkit.org/show_bug.cgi?id=216643
Reviewed by Ross Kirsling.
JSTests:
- modules/async-generator-default.js: Added.
(from.string_appeared_here.import.test.from.string_appeared_here.async test2):
- modules/async-generator-default/module.js: Added.
(export.default.async test):
- test262/expectations.yaml:
Source/JavaScriptCore:
export default async function * test() { }syntax should be correctly handled.
This patch adds the code retrieving "test" name from the above declaration correctly.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseExportDeclaration):
- 10:47 AM Changeset in webkit [267198] by
-
- 2 edits in trunk/Source/WebCore
[iOS] YouTube does not route video to AirPlay the first time
https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>
Reviewed by Eric Carlson.
Difficult to test this, since it requires an live AppleTV device.
During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
- 10:45 AM Changeset in webkit [267197] by
-
- 3 edits in trunk/Tools
[ews] Re-enable api-gtk queue
https://bugs.webkit.org/show_bug.cgi?id=216647
Reviewed by Aakash Jain.
The queue was disabled temporarily in r266956.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
- BuildSlaveSupport/ews-build/config.json:
- 10:17 AM Changeset in webkit [267196] by
-
- 4 edits3 adds in trunk
[JSC] Update JSModuleNamespaceObject::defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=216640
Reviewed by Ross Kirsling.
JSTests:
- modules/module-namespace-object-define-own-property.js: Added.
(from.string_appeared_here.import.as.ns.from.string_appeared_here.shouldThrow):
(shouldThrow):
(shouldThrow.):
(get TypeError):
- modules/module-namespace-object-define-own-property/module.js: Added.
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch implements spec update of JSModuleNamespaceObject::defineOwnProperty.
We implement https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-defineownproperty-p-desc precisely.
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::getOwnPropertyNames):
(JSC::JSModuleNamespaceObject::defineOwnProperty):
- 10:08 AM Changeset in webkit [267195] by
-
- 2 edits in trunk/LayoutTests
[WPE] Unreviewed gardening. Several fast/events/mouse-* tests are flaky after r264117.
The test started failing somewhere between r264103-r264117.
- platform/wpe/TestExpectations:
- 9:17 AM Changeset in webkit [267194] by
-
- 5 edits in trunk/Source/WebKit
We shouldn't need to specify a category for preferences now that they are split into separate files
https://bugs.webkit.org/show_bug.cgi?id=216648
Reviewed by Tim Horton.
Remove need / ability to specify a category in the yaml, rather, infer the category
from which file it is in.
- Scripts/GeneratePreferences.rb:
- Shared/WebPreferencesDebug.yaml:
- Shared/WebPreferencesExperimental.yaml:
- Shared/WebPreferencesInternal.yaml:
- 8:59 AM Changeset in webkit [267193] by
-
- 4 edits in trunk/LayoutTests
[WPE] Unreviewed gardening. Update baselines after r20056.
- platform/glib/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:
- platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Updated after r266510.
- platform/wpe/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt: Updated after r266399.
- 8:43 AM Changeset in webkit [267192] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add some pointer sanity checks to speculationFromCell().
https://bugs.webkit.org/show_bug.cgi?id=216638
rdar://23226333
Reviewed by Yusuke Suzuki.
Add some sanity checks to mitigate against some potential pointer corruptions
from profiling data. The goal here is not to exhaustively filter out all possible
bad pointers, but simply to filter out as many as possible to reduce crashes from
such bad pointers, and to do so with the least possible performance impact.
It is OK to do such filtering here because we're only trying to compute a
SpeculatedType from the pointer. If the pointer is bad, we can just return
SpecNone indicating that we don't have any info to speculate on.
- bytecode/SpeculatedType.cpp:
(JSC::isSanePointer):
(JSC::speculationFromCell):
- runtime/StructureIDTable.h:
(JSC::StructureIDTable::tryGet):
- runtime/VM.h:
(JSC::VM::tryGetStructure):
- 8:07 AM Changeset in webkit [267191] by
-
- 12 edits in trunk/Source/WebCore
Style::Change should be enum class
https://bugs.webkit.org/show_bug.cgi?id=216644
Reviewed by Sam Weinig.
Also improve the names of the values.
- dom/Document.cpp:
(WebCore::Document::resolveStyle):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
- rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::updateElementRenderer):
- rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
- style/StyleChange.cpp:
(WebCore::Style::determineChange):
- style/StyleChange.h:
(): Deleted.
- style/StyleTreeResolver.cpp:
(WebCore::Style::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolveComposedTree):
- style/StyleTreeResolver.h:
- style/StyleUpdate.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::willRecalcStyle):
- 7:44 AM Changeset in webkit [267190] by
-
- 2 edits in trunk/Tools
[GTK] Unreviewed gardening. API test WebKitWebInspectorServer/test-page-list is flaky.
- TestWebKitAPI/glib/TestExpectations.json:
- 7:11 AM Changeset in webkit [267189] by
-
- 4 edits in trunk/LayoutTests
[GLIB] Unreviewwed test gardening. Update baselines after WPT update in r267167.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
- 5:39 AM Changeset in webkit [267188] by
-
- 153 edits2 copies2 deletes in trunk
Remove the legacy animation code
https://bugs.webkit.org/show_bug.cgi?id=216608
Reviewed by Dean Jackson.
Source/WebCore:
We remove the legacy animation code found in Source/WebCore/page/animation/, save for CSSPropertyAnimation which
is also used by the new Web Animations engine and now moved to Source/WebCore/animation/. Since we now have a single
animation engine, the runtime flags to optionally enable the Web Animations engine are not needed anymore and removed
as well.
We also remove some testing utilities and some RenderLayerBacking methods specific to accelerated transitions which
the new animation engine does not use.
- CMakeLists.txt:
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/Animatable.idl:
- animation/AnimationEffect.idl:
- animation/AnimationPlaybackEvent.idl:
- animation/AnimationPlaybackEventInit.idl:
- animation/AnimationTimeline.idl:
- animation/CSSAnimation.idl:
- animation/CSSPropertyAnimation.cpp: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.cpp.
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
- animation/CSSPropertyAnimation.h: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.h.
- animation/CSSTransition.idl:
- animation/DocumentAnimations.idl:
- animation/DocumentOrShadowRootAnimations.idl:
- animation/DocumentTimeline.idl:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.idl:
- animation/WebAnimationTypes.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- dom/Document.cpp:
(WebCore::Document::resolveStyle):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::implicitClose):
(WebCore::Document::resume):
- dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::clearHostElement):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::destroy):
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layout):
- page/Page.cpp:
(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAnimationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsCSSIntegrationEnabled const): Deleted.
- page/animation/AnimationBase.cpp: Removed.
- page/animation/AnimationBase.h: Removed.
- page/animation/CSSAnimationController.cpp: Removed.
- page/animation/CSSAnimationController.h: Removed.
- page/animation/CSSAnimationControllerPrivate.h: Removed.
- page/animation/CompositeAnimation.cpp: Removed.
- page/animation/CompositeAnimation.h: Removed.
- page/animation/ImplicitAnimation.cpp: Removed.
- page/animation/ImplicitAnimation.h: Removed.
- page/animation/KeyframeAnimation.cpp: Removed.
- page/animation/KeyframeAnimation.h: Removed.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::isKeyframe):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::animatedStyle):
- rendering/RenderElement.h:
(WebCore::RenderElement::startTransition): Deleted.
(WebCore::RenderElement::transitionPaused): Deleted.
(WebCore::RenderElement::transitionFinished): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform const):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):
(WebCore::RenderLayerBacking::startTransition): Deleted.
(WebCore::RenderLayerBacking::transitionPaused): Deleted.
(WebCore::RenderLayerBacking::transitionFinished): Deleted.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::startTransition): Deleted.
(WebCore::RenderLayerModelObject::transitionPaused): Deleted.
(WebCore::RenderLayerModelObject::transitionFinished): Deleted.
- rendering/RenderLayerModelObject.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::legacyAnimation const): Deleted.
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
- style/StyleAdjuster.cpp:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::webAnimationsCSSIntegrationEnabled): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::numberOfActiveAnimations const):
(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::animationsInterval const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
(WebCore::Internals::acceleratedAnimationsForElement):
(WebCore::Internals::numberOfAnimationTimelineInvalidations const):
(WebCore::Internals::pauseAnimationAtTimeOnElement): Deleted.
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- Shared/WebPreferencesExperimental.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebAnimationsEnabled): Deleted.
(WKPreferencesGetWebAnimationsEnabled): Deleted.
(WKPreferencesSetWebAnimationsCSSIntegrationEnabled): Deleted.
(WKPreferencesGetWebAnimationsCSSIntegrationEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setWebAnimationsCSSIntegrationEnabled:]): Deleted.
(-[WKPreferences _webAnimationsCSSIntegrationEnabled]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setWebAnimationsEnabled): Deleted.
(WebKit::InjectedBundle::setWebAnimationsCSSIntegrationEnabled): Deleted.
- WebProcess/InjectedBundle/InjectedBundle.h:
Source/WebKitLegacy/mac:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webAnimationsEnabled]): Deleted.
(-[WebPreferences setWebAnimationsEnabled:]): Deleted.
(-[WebPreferences webAnimationsCSSIntegrationEnabled]): Deleted.
(-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- Interfaces/IWebFramePrivate.idl:
- Interfaces/IWebPreferencesPrivate.idl:
- WebFrame.cpp:
(WebFrame::resumeAnimations): Deleted.
(WebFrame::suspendAnimations): Deleted.
(WebFrame::pauseAnimation): Deleted.
(WebFrame::pauseTransition): Deleted.
(WebFrame::numberOfActiveAnimations): Deleted.
- WebFrame.h:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::webAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsEnabled): Deleted.
(WebPreferences::webAnimationsEnabled): Deleted.
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):
(TestOptions::webViewIsCompatibleWithOptions const):
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
LayoutTests:
Remove any use of now-removed testing methods and some runtime flags from layout tests.
- animations/legacy-encoding-timing-function.html:
- animations/resources/animation-test-helpers.js:
(pauseAnimationAtTimeOnElement):
- http/tests/contentextensions/css-display-none-keyframe.html:
- imported/blink/transitions/resources/opacity-transform-transitions-inside-iframe-inner.html: Removed.
- transitions/background-position-transitions.html:
- transitions/background-transitions.html:
- transitions/blendmode-transitions.html:
- transitions/border-radius-transition.html:
- transitions/clip-path-path-transitions.html:
- transitions/clip-path-transitions.html:
- transitions/clip-transition.html:
- transitions/color-transition-all.html:
- transitions/color-transition-premultiplied.html:
- transitions/color-transition-rounding.html:
- transitions/cross-fade-background-image.html:
- transitions/cross-fade-border-image.html:
- transitions/cubic-bezier-overflow-color.html:
- transitions/cubic-bezier-overflow-length.html:
- transitions/cubic-bezier-overflow-shadow.html:
- transitions/cubic-bezier-overflow-svg-length.html:
- transitions/cubic-bezier-overflow-transform.html:
- transitions/default-timing-function.html:
- transitions/delay.html:
- transitions/flex-transitions.html:
- transitions/font-family-during-transition.html:
- transitions/frames-timing-function.html:
- transitions/interrupted-all-transition.html:
- transitions/longhand-vs-shorthand-initial.html:
- transitions/mask-transitions.html:
- transitions/min-max-width-height-transitions.html:
- transitions/mismatched-shadow-styles.html:
- transitions/mismatched-shadow-transitions.html:
- transitions/mixed-type.html:
- transitions/move-after-transition.html:
- transitions/multiple-background-size-transitions.html:
- transitions/multiple-background-transitions.html:
- transitions/multiple-mask-transitions.html:
- transitions/multiple-shadow-transitions.html:
- transitions/negative-delay.html:
- transitions/opacity-transition-zindex.html:
- transitions/resources/transition-test-helpers.js:
- transitions/shape-outside-transitions.html:
- transitions/shorthand-border-transitions.html:
- transitions/shorthand-transitions.html:
- transitions/steps-timing-function.html:
- transitions/svg-layout-transition.html:
- transitions/svg-text-shadow-transition.html:
- transitions/svg-transitions.html:
- transitions/text-indent-transition.html:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match.html:
- transitions/transition-end-event-rendering.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-hit-test.html:
- transitions/transition-in-delay-phase.html:
- transitions/transition-on-element-with-content.html:
- transitions/transition-shorthand-delay.html:
- transitions/transition-timing-function.html:
- transitions/transition-to-from-auto.html:
- transitions/transition-to-from-undefined.html:
- transitions/visited-link-color.html:
- transitions/zero-duration-in-list.html:
- transitions/zero-duration-with-non-zero-delay-start.html:
- webanimations/accelerated-animation-interruption-display-none.html:
- webanimations/accelerated-animation-removal-upon-transition-completion.html:
- webanimations/accelerated-animation-suspension.html:
- webanimations/accelerated-transition-by-removing-property.html:
- webanimations/accessing-current-time-after-clearing-css-animation-effect.html:
- webanimations/accessing-current-time-after-finished-css-animation-target-removal.html:
- webanimations/css-animation-effect-target-change-and-animation-removal-crash.html:
- webanimations/css-animation-effect-target-change-and-get-keyframes-crash.html:
- webanimations/css-animations.html:
- webanimations/css-transition-in-flight-reversal-accelerated.html:
- webanimations/empty-keyframes-crash.html:
- webanimations/partly-accelerated-transition-by-removing-property.html:
- webanimations/setting-css-animation-none-after-clearing-effect.html:
- webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html:
- 5:12 AM Changeset in webkit [267187] by
-
- 4 edits in trunk
Clean up lazy frame loading
https://bugs.webkit.org/show_bug.cgi?id=216560
Patch by Rob Buis <rbuis@igalia.com> on 2020-09-17
Reviewed by Youenn Fablet.
Source/WebKit:
Allow web preference to be consistent with lazy image loading.
- Shared/WebPreferencesExperimental.yaml:
LayoutTests:
Remove WPT specific custom code to set the
lazy frame loading setting, not needed since
experimental features will be enabled for WPT
runs and that will set this setting.
- resources/testharnessreport.js:
- 3:30 AM Changeset in webkit [267186] by
-
- 17 edits in trunk
Support export namespace
export * as ns
https://bugs.webkit.org/show_bug.cgi?id=214379
Reviewed by Ross Kirsling.
JSTests:
- stress/modules-syntax-error.js:
- stress/modules-syntax.js:
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch supports
export * as ns from "module"syntax. If it is used, we expose "module"'s namespace object as "ns".
For each module environment, we create *namespace* (starNamespace) private symbol scope variable. And we fill it later
with module namespace object. This way allows us to use module namespace object IC and super fast imported module binding
lookup though environment variable lookup mechanism.
- builtins/BuiltinNames.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/NodesAnalyzeModule.cpp:
(JSC::ExportNamedDeclarationNode::analyzeModule):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseExportDeclaration):
- runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::ExportEntry::createNamespace):
(JSC::AbstractModuleRecord::resolveExportImpl):
(JSC::AbstractModuleRecord::getModuleNamespace):
(JSC::AbstractModuleRecord::setModuleEnvironment):
(JSC::AbstractModuleRecord::dump):
- runtime/AbstractModuleRecord.h:
- runtime/CommonIdentifiers.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::name):
(JSC::JSFunction::reifyName):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
- runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::instantiateDeclarations):
(JSC::JSModuleRecord::evaluate):
- wasm/js/JSWebAssemblyModule.cpp:
(JSC::JSWebAssemblyModule::finishCreation):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
- 2:19 AM Changeset in webkit [267185] by
-
- 11 edits in trunk/Source
Unified build fix for "redefinition of 'kCMVideoCodecType_VP9"
https://bugs.webkit.org/show_bug.cgi?id=216205
Reviewed by Youenn Fablet.
Source/WebCore:
kCMVideoCodecType_VP9 is present in the macOS Big Sur SDK, so the redeclaration can
be removed. To protect builds using prior OS SDKs, wrap the entire VP9 implementation
in ENABLE(VP9) checks.
- platform/graphics/VP9Utilities.cpp:
- platform/graphics/VP9Utilities.h:
- platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
(): Deleted.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- platform/graphics/cocoa/VP9UtilitiesCocoa.h:
- platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::parseVPCodecParameters):
(WebCore::Internals::setHardwareVP9DecoderDisabledForTesting):
(WebCore::Internals::setVP9ScreenSizeAndScaleForTesting):
Source/WebKit:
Wrap calls to WebCore VP9 functions in ENABLE(VP9) checks.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- 1:05 AM Changeset in webkit [267184] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Optimize Promise#finally by avoiding creating multiple environments
https://bugs.webkit.org/show_bug.cgi?id=216637
Reviewed by Ross Kirsling.
Let's just create functions inside Promise#finally. This avoids creating
multiple lexical environments that are captured by each function.
- builtins/PromisePrototype.js:
(finally):
(globalPrivate.getThenFinally): Deleted.
(globalPrivate.getCatchFinally): Deleted.
- 1:01 AM Changeset in webkit [267183] by
-
- 5 edits in trunk
[css-flex] Remove flexbox's specific computePreferredLogicalWidths()
https://bugs.webkit.org/show_bug.cgi?id=216577
Reviewed by Darin Adler.
Source/WebCore:
Remove the flexbox override of computePreferredLogicalWidths() because it's essentially the same as RenderBlock's
but worst because it was missing some cases that were properly handled in the superclass.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Deleted.
- rendering/RenderFlexibleBox.h: Ditto.
LayoutTests:
- TestExpectations: Removed flexbox_stf-table-singleline.html and flexbox_stf-table-singleline-2.html that are now passing.
Sep 16, 2020:
- 9:40 PM Changeset in webkit [267182] by
-
- 10 edits1 move in trunk/Source/WebCore
[LFC][IFC] Move InlineRect from Display to Layout namespace
https://bugs.webkit.org/show_bug.cgi?id=216633
Reviewed by Simon Fraser.
Let's move the Display type over to Layout namespace. Display tree needs a different set of data types.
- WebCore.xcodeproj/project.pbxproj:
- layout/displaytree/DisplayLine.h:
(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::Line):
- layout/displaytree/DisplayRun.h:
(WebCore::Display::Run::rect const):
(WebCore::Display::Run::inkOverflow const):
(WebCore::Display::Run::Run):
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):
(WebCore::Layout::LineBox::constructInlineBoxes):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::InlineBox::logicalRect const):
- layout/inlineformatting/InlineRect.h: Renamed from Source/WebCore/layout/displaytree/DisplayInlineRect.h.
(WebCore::Layout::InlineRect::expandHorizontally):
(WebCore::Layout::InlineRect::expandVertically):
(WebCore::Layout::InlineRect::invalidateTop):
(WebCore::Layout::InlineRect::invalidateLeft):
(WebCore::Layout::InlineRect::invalidateWidth):
(WebCore::Layout::InlineRect::invalidateHeight):
(WebCore::Layout::InlineRect::hasValidPosition const):
(WebCore::Layout::InlineRect::hasValidSize const):
(WebCore::Layout::InlineRect::hasValidGeometry const):
(WebCore::Layout::InlineRect::InlineRect):
(WebCore::Layout::InlineRect::invalidatePosition):
(WebCore::Layout::InlineRect::setHasValidPosition):
(WebCore::Layout::InlineRect::setHasValidSize):
(WebCore::Layout::InlineRect::top const):
(WebCore::Layout::InlineRect::left const):
(WebCore::Layout::InlineRect::bottom const):
(WebCore::Layout::InlineRect::right const):
(WebCore::Layout::InlineRect::topLeft const):
(WebCore::Layout::InlineRect::size const):
(WebCore::Layout::InlineRect::width const):
(WebCore::Layout::InlineRect::height const):
(WebCore::Layout::InlineRect::setTopLeft):
(WebCore::Layout::InlineRect::setTop):
(WebCore::Layout::InlineRect::setBottom):
(WebCore::Layout::InlineRect::setLeft):
(WebCore::Layout::InlineRect::setWidth):
(WebCore::Layout::InlineRect::setHeight):
(WebCore::Layout::InlineRect::moveHorizontally):
(WebCore::Layout::InlineRect::moveVertically):
(WebCore::Layout::InlineRect::moveBy):
(WebCore::Layout::InlineRect::expand):
(WebCore::Layout::InlineRect::expandToContain):
(WebCore::Layout::InlineRect::expandVerticallyToContain):
(WebCore::Layout::InlineRect::inflate):
(WebCore::Layout::InlineRect::operator InlineLayoutRect const):
- 8:58 PM Changeset in webkit [267181] by
-
- 7 edits3 adds in trunk/Source/WebKit
WebPreferences.yaml is overwhelming, what if we split it up a bit
https://bugs.webkit.org/show_bug.cgi?id=216627
Reviewed by Tim Horton.
Split out experimental, internal and debug preferences into their own
yaml files to add a bit of order.
- CMakeLists.txt:
- DerivedSources.make:
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDebug.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
- Shared/WebPreferencesExperimental.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
- Shared/WebPreferencesInternal.yaml: Copied from Source/WebKit/Shared/WebPreferences.yaml.
- WebKit.xcodeproj/project.pbxproj:
- 7:59 PM Changeset in webkit [267180] by
-
- 10 edits in trunk/Source/WebCore
[LFC] Remove partial invalidation
https://bugs.webkit.org/show_bug.cgi?id=216631
Reviewed by Simon Fraser.
Invalidation fails when the LayoutTree does not match the RenderTree structures (e.g. table wrapper box).
Since incremental layouts are not supported yet, it has a very little value. Let's remove it for now.
- layout/display/DisplayView.h:
- layout/integration/LayoutIntegrationLineLayout.h:
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::LayoutTree::LayoutTree):
(WebCore::Layout::TreeBuilder::buildLayoutTree):
(WebCore::Layout::TreeBuilder::TreeBuilder):
(WebCore::Layout::TreeBuilder::createReplacedBox):
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLineBreakBox):
(WebCore::Layout::TreeBuilder::createContainer):
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::printLayoutTreeForLiveDocuments):
(WebCore::Layout::LayoutTreeContent::LayoutTreeContent): Deleted.
(WebCore::Layout::LayoutTreeContent::addLayoutBoxForRenderer): Deleted.
(WebCore::Layout::TreeBuilder::buildTree): Deleted.
- layout/layouttree/LayoutTreeBuilder.h:
(WebCore::Layout::LayoutTree::root const):
(WebCore::Layout::LayoutTree::append):
(WebCore::Layout::LayoutTreeContent::rootLayoutBox const): Deleted.
(WebCore::Layout::LayoutTreeContent::rootLayoutBox): Deleted.
(WebCore::Layout::LayoutTreeContent::rootRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::addBox): Deleted.
(WebCore::Layout::LayoutTreeContent::addContainer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer): Deleted.
(WebCore::Layout::LayoutTreeContent::layoutBoxForRenderer const): Deleted.
(WebCore::Layout::LayoutTreeContent::rendererForLayoutBox const): Deleted.
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):
(WebCore::FrameViewLayoutContext::invalidateLayoutTreeContent): Deleted.
(WebCore::FrameViewLayoutContext::invalidateLayoutState): Deleted.
- page/FrameViewLayoutContext.h:
(WebCore::FrameViewLayoutContext::layoutFormattingState const):
(WebCore::FrameViewLayoutContext::layoutTreeContent const): Deleted.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
(WebCore::RenderTreeBuilder::detachFromRenderElement):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRendererStyle):
- 7:58 PM Changeset in webkit [267179] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216634
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:23 PM Changeset in webkit [267178] by
-
- 2 edits in trunk/LayoutTests
Added fast/selectors/selection-window-inactive-stroke-color.html to bug and changed expectations
https://bugs.webkit.org/show_bug.cgi?id=216394
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:05 PM Changeset in webkit [267177] by
-
- 14 edits3 adds in trunk
[CMake] Add a new library target TestRunnerShared
https://bugs.webkit.org/show_bug.cgi?id=216465
.:
WinCairo port is using both DRT and WTR. However, it has a problem
for precompiled header builds to compile the source of
TestRunnerShared twice for DRT and WTR.
Add a new library target TestRunnerShared. Re-enable precompiled
header for DRT and WTR for WinCairo.
Reviewed by Don Olmstead.
- Source/cmake/OptionsWinCairo.cmake:
- Source/cmake/WebKitFS.cmake:
Tools:
Reviewed by Don Olmstead.
- DumpRenderTree/CMakeLists.txt:
- DumpRenderTree/PlatformWin.cmake:
- PlatformFTW.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWPE.cmake:
- PlatformWin.cmake:
- TestRunnerShared/CMakeLists.txt: Added.
- TestRunnerShared/config/config.h: Added.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/PlatformFTW.cmake:
- WebKitTestRunner/PlatformWin.cmake:
- 6:57 PM Changeset in webkit [267176] by
-
- 3 edits in trunk/Source/WebKit
Revert _setIgnoresAppBoundDomains SPI to compile for macOS
https://bugs.webkit.org/show_bug.cgi?id=216628
<rdar://problem/69025655>
Reviewed by Tim Horton.
We need to give users of the _setIgnoresAppBoundDomains SPI time to
convert uses to iOS only, so in the meantime we should still compile
the SPI for macOS so we don't break anything.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 6:53 PM Changeset in webkit [267175] by
-
- 8 edits in trunk/Source/WebCore
MutationObserverRegistration should be ref counted
https://bugs.webkit.org/show_bug.cgi?id=216528
Reviewed by Darin Adler.
This patch makes MutationObserverRegistration ref counted so that the transient registry can store
Ref<MutationObserverRegistration> instead of a raw pointer. It also merges NodeMutationObserverData
into NodeRareData now that NodeRareData is actually rare after r266714 and r266769.
Before this patch, MutationObserverRegistration had to be kept alive by the originally observed node
using m_nodeKeptAlive whenever a transient observation occurs (i.e. observation of a node which used
to be a part of the subtree of the observed node). With this patch, this complexity is eliminated.
No new tests since there should be no behavioral difference.
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::disconnect): Skip any node for which the observed node had been deleted.
This means that the registration is alive for transient nodes (i.e. a node which used to be a part of
the subtree of the observed node).
(WebCore::MutationObserver::observationStarted): Converted debug assert to a release assert.
(WebCore::MutationObserver::observationEnded): Ditto.
(WebCore::MutationObserver::deliver): Simplified logic a bit using WTF::map.
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::create): Added.
(WebCore::MutationObserverRegistration::MutationObserverRegistration): Create a WeakPtr for m_node.
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): Deleted the code for
m_nodeKeptAlive since the observed node is no longer responsible for keeping this
MutationObserverRegistration alive while transient observarion takes place.
(WebCore::MutationObserverRegistration::takeTransientRegistrations): Ditto.
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom const):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet const): Skip m_node if it has been
deleted. This is possible during transient observations.
- dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration): This class is now ref counted. Also made m_node WeakPtr.
(WebCore::MutationObserverRegistration::node):
- dom/Node.cpp:
(WebCore::Node::clearRareData):
(WebCore::Node::moveNodeToNewDocument):
(WebCore::Node::mutationObserverRegistry): Deleted.
(WebCore::Node::transientMutationObserverRegistry): Deleted.
(WebCore::collectMatchingObserversForMutation): Now takes a reference to registry.
(WebCore::Node::registeredMutationObservers):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver): Converted debug assertions to release assertions. With
script execution forbidden during tree mutations, this should never happen now.
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver): Ditto.
(WebCore::Node::notifyMutationObserversNodeWillDetach):
- dom/Node.h:
- dom/NodeRareData.cpp:
- dom/NodeRareData.h:
(WebCore::NodeMutationObserverData): Merged into NodeRareData.
(WebCore::NodeRareData::mutationObserverData): Deleted.
(WebCore::NodeRareData::ensureMutationObserverData): Deleted.
(WebCore::NodeRareData::mutationObserverRegistry): Added.
(WebCore::NodeRareData::mutationObserverRegistryIfExists): Added.
(WebCore::NodeRareData::transientMutationObserverRegistry): Added.
(WebCore::NodeRareData::useTypes const):
- 5:23 PM Changeset in webkit [267174] by
-
- 2 edits in branches/safari-610-branch/LayoutTests/imported/w3c
Cherry-pick r266098. rdar://problem/67703327
Update iOS layout test results after r266087
https://bugs.webkit.org/show_bug.cgi?id=215671
- web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt: Apparently there's a newly passing test here, too. I wonder why macOS isn't affected by this change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:58 PM Changeset in webkit [267173] by
-
- 1 edit4 deletes in trunk/LayoutTests
Unreviewed, reverting r267171.
The tests need to be fixed
Reverted changeset:
"4 webaudio/oscillator tests missing expected results"
https://bugs.webkit.org/show_bug.cgi?id=216625
https://trac.webkit.org/changeset/267171
- 4:56 PM Changeset in webkit [267172] by
-
- 16 edits in trunk
Remove runtime setting for enabling/disabling CSS shadow parts
https://bugs.webkit.org/show_bug.cgi?id=216567
Reviewed by Tim Horton.
Remove runtime setting for enabling/disabling CSS shadow parts. It is
on by default and there is no known reason one would need to disable it.
Source/WebCore:
- css/CSSSelector.cpp:
(WebCore::CSSSelector::parsePseudoElementType):
- dom/Element.cpp:
(WebCore::Element::partAttributeChanged):
- dom/Element.idl:
- dom/ShadowRoot.cpp:
(WebCore::parsePartMappingsList):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSShadowPartsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssShadowPartsEnabled const): Deleted.
- style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateShadowParts):
Source/WebKit:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setCSSShadowPartsEnabled:]):
(-[WebPreferences cssShadowPartsEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- 4:54 PM Changeset in webkit [267171] by
-
- 1 edit4 adds in trunk/LayoutTests
4 webaudio/oscillator tests missing expected results
https://bugs.webkit.org/show_bug.cgi?id=216625
Unreviewed test gardening.
- webaudio/oscillator-custom-expected.txt: Added.
- webaudio/oscillator-sawtooth-expected.txt: Added.
- webaudio/oscillator-square-expected.txt: Added.
- webaudio/oscillator-triangle-expected.txt: Added.
- 4:26 PM Changeset in webkit [267170] by
-
- 4 edits in trunk
AudioBufferSourceNode.start() ignores 'when' parameter when pitch rate is 0
https://bugs.webkit.org/show_bug.cgi?id=216623
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-playbackrate-zero-expected.txt:
Source/WebCore:
AudioBufferSourceNode::renderFromBuffer() has special logic when pitch rate is 0 since
the output value is constant. However, that logic was wrongly always writing to the
begining of the destination buffer, ignoring the computed writeIndex. As a result,
instead of having silence at the beginning of the destination buffer, we would have
it at the end.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- 3:43 PM Changeset in webkit [267169] by
-
- 4 edits in trunk
AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
https://bugs.webkit.org/show_bug.cgi?id=216622
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline test that is now passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-start-expected.txt:
Source/WebCore:
AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We
are supposed to output silence. However, in order implementation, we were just resetting the offset
to 0, playing the buffer from the beginning.
To address the issue, I have dropped the logic that would reset the read offset if past the end of
the buffer.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::startPlaying):
Drop dead code since m_isGrain is always true in this function.
- 3:40 PM Changeset in webkit [267168] by
-
- 4 edits in trunk/LayoutTests
[ macOS iOS Debug ] imported/w3c/web-platform-tests/selection/*: 4 tests marked as slow
https://bugs.webkit.org/show_bug.cgi?id=216492
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 3:31 PM Changeset in webkit [267167] by
-
- 50 edits in trunk/LayoutTests
Update WPT test harness so that webaudio tests output results that are consistent across different machines
https://bugs.webkit.org/show_bug.cgi?id=216332
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline tests.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-scheduling-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audiobuffersource-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-exponentialRampToValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-linearRampToValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setTargetAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueCurveAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-output-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/ctor-iirfilter-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-iirfilternode-interface/iirfilter-getFrequencyResponse-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-oscillatornode-interface/osc-basic-waveform-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-position-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-equalpower-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
LayoutTests:
Unskip tests that should now pass on all platforms.
- TestExpectations:
- resources/testharnessreport.js:
(self.testRunner.add_completion_callback):
Our webaudio implementation uses single precision for floating point audio values. However, the tests were
printing out those values with 16 digits, even when the checks were passing. We had to skip those tests
because digits after the 6th one may differ across machines and we were getting TEXT diffs. To address the
issue we now strip arrays from PASS lines in webaudio tests output and replace them with the string
'[expected array]'. As long as the check is passing, the actual value in the array does not really matter.
- webaudio/Oscillator/no-dezippering-expected.txt:
- webaudio/Oscillator/osc-440hz-expected.txt:
- webaudio/Oscillator/osc-negative-freq-expected.txt:
- webaudio/Oscillator/start-sampling-expected.txt:
- webaudio/audioparam-cancel-and-hold-expected.txt:
- webaudio/convolvernode-unmodified-buffer-expected.txt:
Rebaseline tests.
- 3:30 PM Changeset in webkit [267166] by
-
- 35 edits in trunk
Remove ENABLE_METER_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=216582
Reviewed by Fujii Hironori.
With PlayStation finally planning to turn this on,
no ports had this disabled, so remove the enable flag.
.:
- Source/cmake/OptionsFTW.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsPlayStation.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/WebCore:
- DerivedSources.make:
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityProgressIndicator.cpp:
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.cpp:
- css/html.css:
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
- html/HTMLMeterElement.idl:
- html/HTMLTagNames.in:
- platform/LocalizedStrings.h:
- platform/cocoa/LocalizedStringsCocoa.mm:
- rendering/RenderMeter.cpp:
- rendering/RenderMeter.h:
- rendering/RenderObject.h:
- rendering/RenderTheme.cpp:
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
- rendering/RenderThemeWin.cpp:
- rendering/RenderThemeWin.h:
Source/WTF:
- wtf/PlatformEnable.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:05 PM Changeset in webkit [267165] by
-
- 2 edits in trunk/Tools
EWS emails to bot watchers about build failures should be grouped properly
https://bugs.webkit.org/show_bug.cgi?id=216495
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Set email headers appropriately.
- 3:04 PM Changeset in webkit [267164] by
-
- 25 edits2 deletes in trunk
Remove runtime setting for enabling/disabling the isSecureContext API?
https://bugs.webkit.org/show_bug.cgi?id=216562
Reviewed by Darin Adler.
Remove runtime setting for enabling/disabling the the isSecureContext attribute.
on window and the worker global scope. There is no known reason one would need
to disable it.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setIsSecureContextAttributeEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::isSecureContextAttributeEnabled const): Deleted.
- page/WindowOrWorkerGlobalScope.idl:
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIsSecureContextAttributeEnabled):
(WKPreferencesGetIsSecureContextAttributeEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setIsSecureContextAttributeEnabled:]):
(-[WebPreferences isSecureContextAttributeEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setIsSecureContextAttributeEnabled):
(WebPreferences::isSecureContextAttributeEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
- DumpRenderTree/win/DumpRenderTree.cpp:
(setWebPreferencesForTestOptions):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
- platform/win/TestExpectations:
- security/isSecureContext-disabled-expected.txt: Removed.
- security/isSecureContext-disabled.html: Removed.
- 3:04 PM Changeset in webkit [267163] by
-
- 3 edits1 add in trunk
Don't IC a null custom accessor/value setter
https://bugs.webkit.org/show_bug.cgi?id=216620
<rdar://problem/68976066>
Reviewed by Mark Lam.
JSTests:
- stress/dont-ic-null-custom-setter.js: Added.
Source/JavaScriptCore:
Our runtime allows CustomGetterSetter objects setter field to not contain an
actual C function to call. In such a scenario, the runtime just does nothing
except return false to the ::put code (which may result in throwing an
exception in strict mode code).
However, our IC code never considered whether this function could be nullptr.
The fix here is simple: don't IC such custom accessor/value setters.
- runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::isCacheableCustom const):
- 2:56 PM Changeset in webkit [267162] by
-
- 4 edits in trunk
REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619
Reviewed by Chris Dumez.
Tools:
In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 2:52 PM Changeset in webkit [267161] by
-
- 2 edits in trunk/Tools
[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
https://bugs.webkit.org/show_bug.cgi?id=216566
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.
- 2:34 PM Changeset in webkit [267160] by
-
- 19 edits37 copies1 move14 adds8 deletes in branches/safari-610-branch/LayoutTests
Unreviewed test gardening, land baselines for rdar://67764580 and rdar://68372418.
- platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt:
- platform/mac-bigsur/fast/css/text-overflow-input-expected.txt: Removed.
- platform/mac-bigsur/fast/forms/button-sizes-expected.txt: Removed.
- platform/mac-bigsur/fast/forms/input-button-sizes-expected.txt: Removed.
- platform/mac-bigsur/fast/forms/listbox-bidi-align-expected.txt: Removed.
- platform/mac-bigsur/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
- platform/mac-bigsur/tables/mozilla/bugs/bug33855-expected.txt: Removed.
- platform/mac-catalina/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
- platform/mac-catalina/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
- platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
- platform/mac-catalina/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
- platform/mac-catalina/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
- platform/mac-catalina/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
- platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
- platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
- platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
- platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
- platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
- platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
- platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
- platform/mac-catalina/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
- platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
- platform/mac-catalina/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
- platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
- platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
- platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
- platform/mac-catalina/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
- platform/mac-mojave/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac-bigsur/fast/block/margin-collapse/103-expected.txt.
- platform/mac-mojave/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
- platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
- platform/mac-mojave/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
- platform/mac-mojave/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
- platform/mac-mojave/fast/forms/button-table-styles-expected.txt: Renamed from LayoutTests/platform/mac-bigsur/fast/forms/button-table-styles-expected.txt.
- platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
- platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
- platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
- platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
- platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
- platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
- platform/mac-mojave/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
- platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select/optgroup-rendering-expected.txt.
- platform/mac-mojave/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
- platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
- platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
- platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/mac/fast/forms/select-selected-expected.txt:
- platform/mac/fast/forms/select/optgroup-rendering-expected.txt:
- platform/mac/fast/parser/document-write-option-expected.txt:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- 2:11 PM Changeset in webkit [267159] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Flatpak SDK][WPE] Launching the remote inspector kills MB
https://bugs.webkit.org/show_bug.cgi?id=213899
Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-16
Reviewed by Adrian Perez de Castro.
Load inspector resources from developer build artefacts, when the inspector server is
running in this configuration. Fall back to system libraries loading mechanism otherwise.
- inspector/remote/glib/RemoteInspectorUtils.cpp:
(Inspector::backendCommands):
- 1:58 PM Changeset in webkit [267158] by
-
- 23 edits in trunk/Source/WebCore
[LFC] Box geometry is all logical
https://bugs.webkit.org/show_bug.cgi?id=216614
Reviewed by Simon Fraser.
Rename top/left/bottom/right/width/height to logical*. These coordinates are in the Layout namespace, therefore they are all logical.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::layout):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForBoxAndAncestors):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticVerticalPosition const):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):
- layout/display/DisplayLayerController.cpp:
(WebCore::Display::LayerController::prepareForDisplay):
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintBoxDecoration):
(WebCore::Display::Painter::absoluteBoxGeometry):
(WebCore::Display::paintSubtree):
(WebCore::Display::collectPaintRootsAndContentRect):
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):
- layout/floats/FloatingState.h:
(WebCore::Layout::FloatingState::FloatItem::rectWithMargin const):
(WebCore::Layout::FloatingState::FloatItem::bottom const):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::inlineItemWidth const):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::prepareFloatingState):
- layout/layouttree/LayoutBoxGeometry.cpp:
(WebCore::Layout::BoxGeometry::borderBox const):
- layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::logicalBottom const):
(WebCore::Layout::BoxGeometry::logicalRight const):
(WebCore::Layout::BoxGeometry::logicalBottomRight const):
(WebCore::Layout::BoxGeometry::logicalSize const):
(WebCore::Layout::BoxGeometry::logicalWidth const):
(WebCore::Layout::BoxGeometry::logicalHeight const):
(WebCore::Layout::BoxGeometry::isEmpty const):
(WebCore::Layout::BoxGeometry::logicalRect const):
(WebCore::Layout::BoxGeometry::logicalRectWithMargin const):
(WebCore::Layout::BoxGeometry::logicalTop const):
(WebCore::Layout::BoxGeometry::logicalLeft const):
(WebCore::Layout::BoxGeometry::logicalTopLeft const):
(WebCore::Layout::BoxGeometry::setLogicalTopLeft):
(WebCore::Layout::BoxGeometry::setLogicalTop):
(WebCore::Layout::BoxGeometry::setLogicalLeft):
(WebCore::Layout::BoxGeometry::bottom const): Deleted.
(WebCore::Layout::BoxGeometry::right const): Deleted.
(WebCore::Layout::BoxGeometry::bottomRight const): Deleted.
(WebCore::Layout::BoxGeometry::size const): Deleted.
(WebCore::Layout::BoxGeometry::width const): Deleted.
(WebCore::Layout::BoxGeometry::height const): Deleted.
(WebCore::Layout::BoxGeometry::rect const): Deleted.
(WebCore::Layout::BoxGeometry::rectWithMargin const): Deleted.
(WebCore::Layout::BoxGeometry::top const): Deleted.
(WebCore::Layout::BoxGeometry::left const): Deleted.
(WebCore::Layout::BoxGeometry::topLeft const): Deleted.
(WebCore::Layout::BoxGeometry::setTopLeft): Deleted.
(WebCore::Layout::BoxGeometry::setTop): Deleted.
(WebCore::Layout::BoxGeometry::setLeft): Deleted.
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputLayoutBox):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):
- layout/tableformatting/TableLayout.cpp:
(WebCore::Layout::TableFormattingContext::TableLayout::distributedVerticalSpace):
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layoutUsingFormattingContext):
- 1:09 PM Changeset in webkit [267157] by
-
- 10 edits3 adds in trunk
[LFC][FFC] Add basic flex item sizing and positioning
https://bugs.webkit.org/show_bug.cgi?id=216613
Reviewed by Antti Koivisto.
Source/WebCore:
This patch adds support for single line (no-wrap), row based flex item layout with default spacing.
Test: fast/layoutformattingcontext/flex-box-simple.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContent):
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
(WebCore::Layout::FlexFormattingContext::computeIntrinsicWidthConstraintsForFlexItems):
- layout/flexformatting/FlexFormattingContext.h:
(WebCore::Layout::FlexFormattingContext::Geometry::Geometry):
- layout/flexformatting/FlexFormattingContextGeometry.cpp: Added.
(WebCore::Layout::FlexFormattingContext::Geometry::intrinsicWidthConstraints):
- layout/flexformatting/FlexFormattingState.h:
(WebCore::Layout::FlexFormattingState::lines const): Flex layout has the concept of lines where flex wrap may trigger multi-line layout.
(WebCore::Layout::FlexFormattingState::addLine):
LayoutTests:
- fast/layoutformattingcontext/flex-box-simple-expected.html: Added.
- fast/layoutformattingcontext/flex-box-simple.html: Added.
- 12:07 PM HackingWebInspector edited by
- Replace IRC with Slack. Update paths. (diff)
- 11:43 AM Changeset in webkit [267156] by
-
- 13 edits in trunk/Source/WebKit
RemoteSampleBufferDisplayLayer should process its IPC messages from a background thread
https://bugs.webkit.org/show_bug.cgi?id=216475
Reviewed by Eric Carlson.
Use a process wide work queue to process all track video renderer messages in a background thread.
This queue is shared by all RemoteSampleBufferDisplayLayerManager and RemoteSampleBufferDisplayLayer objects, which are per web process.
Since LocalSampleBufferDisplayLayer must currently be created in main thread, hop to main thread to create/delete renderers.
We update messages.py to support WantsAsyncDispatchMessage, which removes the sync handling with dispatchMessage.
This allows RemoteSampleBufferDisplayLayerManager to also handle messages from RemoteSampleBufferDisplayLayer.
Update RemoteSampleBufferDisplayLayerManager accordingly as well.
Covered by webrtc/video.html with GPU process enabled.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::videoMediaStreamTrackRendererQueue):
- GPUProcess/GPUProcess.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp:
(WebKit::RemoteAudioMediaStreamTrackRendererManager::dispatchMessage):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.cpp:
(WebKit::RemoteSampleBufferDisplayLayerManager::RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::~RemoteSampleBufferDisplayLayerManager):
(WebKit::RemoteSampleBufferDisplayLayerManager::close):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchToThread):
(WebKit::RemoteSampleBufferDisplayLayerManager::dispatchMessage):
(WebKit::RemoteSampleBufferDisplayLayerManager::createLayer):
(WebKit::RemoteSampleBufferDisplayLayerManager::releaseLayer):
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
- Scripts/webkit/messages.py:
- SourcesCocoa.txt:
- 11:21 AM Changeset in webkit [267155] by
-
- 14 edits in trunk/Source/WebKit
Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216585
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-16
Reviewed by Geoffrey Garen.
It will eventually be replaced by WKNavigationDelegate's didReceiveAuthenticationChallenge in rdar://30655740
but the SPI needs to continue to exist somewhere until that is complete.
In the meantime, it needs to be moved from the WebProcessPool for https://bugs.webkit.org/show_bug.cgi?id=216041
and rdar://problem/68942815 tracks Safari's adoption of the SPI introduced here, which I will fix within an hour of landing this.
- UIProcess/API/C/WKContext.cpp:
(WKContextAllowSpecificHTTPSCertificateForHost):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]): Deleted.
- UIProcess/API/Cocoa/WKProcessGroupPrivate.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _allowTLSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_allow_tls_certificate_for_host):
Use the default data store until this API can be replaced by API in a different place.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::allowSpecificHTTPSCertificateForHost): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::allowSpecificHTTPSCertificateForHost):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 10:57 AM Changeset in webkit [267154] by
-
- 118 edits in trunk
Enable full CSS color parsing within a worker for OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=204575
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline existing OffscreenCanvas tests now that full CSS color
parsing is available.
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgb-eof.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-eof.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-num-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4-expected.txt:
- web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.rgba-solid-4.worker-expected.txt:
Source/WebCore:
Enable full CSS color parsing in OffscreenCanvas by removing the
unnecessary use of CSSValuePool::singleton in color-parsing code in
CSSPropertyParserHelpers and adding a new helper function to return a
Color instead of a CSSPrimitiveValue when parsing a color.
Rebaselined existing layout tests.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeDegrees const):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeDegrees):
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseColorWorkerSafe):
- css/parser/CSSParser.h:
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumePercentRaw):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeAngleRaw):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):
- css/parser/CSSPropertyParserHelpers.h:
- 10:40 AM Changeset in webkit [267153] by
-
- 27 edits in trunk
Merge PeriodicWave improvements from Blink
https://bugs.webkit.org/show_bug.cgi?id=216576
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline tests that now have a slightly different output.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-connection-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-biquad-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-delay-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-gain-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-oscillator-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-1-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-4-chan-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-gainnode-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/automation-changes-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-rolloff-clamping-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-copy-curve-expected.txt:
Source/WebCore:
Merge PeriodicWave improvements from Blink:
These fixes allow us to pass some of the tests imported from Blink.
No new tests, rebaselined existing tests.
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::maxNumberOfPartials const):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
(WebCore::PeriodicWave::periodicWaveSize const):
- Modules/webaudio/PeriodicWave.h:
LayoutTests:
Rebaseline tests that are now passing.
- webaudio/Oscillator/no-dezippering-expected.txt:
- webaudio/Oscillator/osc-negative-freq-expected.txt:
- webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt:
- webaudio/Oscillator/start-sampling-expected.txt:
- 10:08 AM Changeset in webkit [267152] by
-
- 2 edits in trunk/LayoutTests
Correction to test expectation for imported/w3c/web-platform-tests/css/css-position/fixed-z-index-blend.html
webkit.org/b/207891
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:06 AM Changeset in webkit [267151] by
-
- 4 edits in trunk
OfflineAudioContext should support up to 32 channels
https://bugs.webkit.org/show_bug.cgi?id=216587
Reviewed by Darin Adler.
Source/WebCore:
OfflineAudioContext should support up to 32 channels. It previously had
an artificial limit of 10.
No new tests, updated existing test.
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
LayoutTests:
Update test that is now passing.
- webaudio/dom-exceptions-expected.txt:
- 9:56 AM Changeset in webkit [267150] by
-
- 6 edits in trunk/Source
Remove unneeded HAVE_FOUNDATION_WITH_SAVE_COOKIES_WITH_COMPLETION_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=216572
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-16
Reviewed by Youenn Fablet.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
It's available everywhere we support.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::saveCookies):
(WebKit::NetworkProcess::platformFlushCookies):
Source/WTF:
- wtf/PlatformHave.h:
- 9:39 AM Changeset in webkit [267149] by
-
- 2 edits in trunk/Tools
[Flatpak] webkit-bwrap drive-by cleanups
Rubber-stamped by Adrian Perez de Castro.
- flatpak/webkit-bwrap: Extend lists with tuples, use itertools and map to build the final
command line.
- 9:34 AM Changeset in webkit [267148] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Limit reported macOS release to 10.15 series
https://bugs.webkit.org/show_bug.cgi?id=216593
<rdar://problem/68937905>
Reviewed by Maciej Stachowiak.
If the reported system OS is 11.0 (or beyond) report the last stable release
of macOS.
- platform/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName):
- 9:00 AM Changeset in webkit [267147] by
-
- 15 edits in trunk
OfflineAudioContext constructor should not throw when given a bad buffer length
https://bugs.webkit.org/show_bug.cgi?id=216584
Reviewed by Youenn Fablet.
Source/WebCore:
OfflineAudioContext constructor should not throw when given a bad buffer length. We should
instead throw later on when trying to start rendering.
No new tests, rebaselined existing test.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::BaseAudioContext):
- Modules/webaudio/BaseAudioContext.h:
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::OfflineAudioContext):
(WebCore::OfflineAudioContext::create):
(WebCore::OfflineAudioContext::startOfflineRendering):
- Modules/webaudio/OfflineAudioContext.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::maxChannelCount const):
LayoutTests:
Rebaseline test now that more checks are passing.
- webaudio/dom-exceptions-expected.txt:
- 8:55 AM Changeset in webkit [267146] by
-
- 7 edits1 add in trunk/Source/WebCore
[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
https://bugs.webkit.org/show_bug.cgi?id=216590
Reviewed by Youenn Fablet.
Adds NavigatorCookies interface mixin and includes it in Navigator.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- page/Navigator.idl:
- page/NavigatorCookies.idl: Added.
- 8:51 AM Changeset in webkit [267145] by
-
- 7 edits in trunk/Source/WebKit
Move LibWebRTCCodecsProxy message handling out of the main thread
https://bugs.webkit.org/show_bug.cgi?id=216531
Reviewed by Eric Carlson.
Use a process wide work queue to process all LibWebRTCCodecsProxy messages in a background thread.
This queue is shared by all LibWebRTCCodecsProxy objects, which are per web process.
Covered by webrtc/video.html with GPU process enabled.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::~GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
(WebKit::GPUConnectionToWebProcess::libWebRTCCodecsProxy): Deleted.
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::libWebRTCCodecsQueue):
- GPUProcess/GPUProcess.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
(WebKit::LibWebRTCCodecsProxy::create):
(WebKit::LibWebRTCCodecsProxy::didReceiveMessageFromWebProcess): Deleted.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::~LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::dispatchToThread):
(WebKit::LibWebRTCCodecsProxy::close):
- 8:32 AM Changeset in webkit [267144] by
-
- 3 edits34 adds4 deletes in trunk/LayoutTests
Import OscillatorNode layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216569
Reviewed by Eric Carlson.
Import OscillatorNode layout tests from Blink.
- webaudio/Oscillator/no-dezippering-expected.txt: Added.
- webaudio/Oscillator/no-dezippering.html: Added.
- webaudio/Oscillator/osc-440hz-expected.txt: Added.
- webaudio/Oscillator/osc-440hz.html: Added.
- webaudio/Oscillator/osc-low-freq-expected.txt: Added.
- webaudio/Oscillator/osc-low-freq.html: Added.
- webaudio/Oscillator/osc-negative-freq-expected.txt: Added.
- webaudio/Oscillator/osc-negative-freq.html: Added.
- webaudio/Oscillator/osc-sweep-snr-custom-expected.txt: Added.
- webaudio/Oscillator/osc-sweep-snr-custom.html: Added.
- webaudio/Oscillator/osc-sweep-snr-sawtooth-expected.txt: Added.
- webaudio/Oscillator/osc-sweep-snr-sawtooth.html: Added.
- webaudio/Oscillator/osc-sweep-snr-sine-expected.txt: Added.
- webaudio/Oscillator/osc-sweep-snr-sine.html: Added.
- webaudio/Oscillator/osc-sweep-snr-square-expected.txt: Added.
- webaudio/Oscillator/osc-sweep-snr-square.html: Added.
- webaudio/Oscillator/osc-sweep-snr-triangle-expected.txt: Added.
- webaudio/Oscillator/osc-sweep-snr-triangle.html: Added.
- webaudio/Oscillator/oscillator-basic-expected.txt: Added.
- webaudio/Oscillator/oscillator-basic.html: Added.
- webaudio/Oscillator/oscillator-ended-expected.txt: Added.
- webaudio/Oscillator/oscillator-ended.html: Added.
- webaudio/Oscillator/oscillator-late-start-expected.txt: Added.
- webaudio/Oscillator/oscillator-late-start.html: Added.
- webaudio/Oscillator/start-sampling-expected.txt: Added.
- webaudio/Oscillator/start-sampling.html: Added.
- webaudio/oscillator-basic-expected.txt: Removed.
- webaudio/oscillator-basic.html: Removed.
- webaudio/oscillator-ended-expected.txt: Removed.
- webaudio/oscillator-ended.html: Removed.
- webaudio/resources/audio-file-utils.js: Added.
- webaudio/resources/oscillator-testing.js:
- webaudio/resources/start-stop-exceptions.js: Added.
- 8:09 AM Changeset in webkit [267143] by
-
- 32 edits in trunk/Source
Non-unified build fixes, early September 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=216599
Unreviewed build fix.
Largely based on a patch by Lauro Moura <Lauro Moura>
Source/JavaScriptCore:
- runtime/IntlCache.cpp: Add missing wtf/Vector.h include.
- runtime/IntlCache.h: Add missing wtf/text/CString.h include.
- runtime/IntlNumberFormatPrototype.cpp: Replace IntlNumberFormat.h
include with IntlNumberFormatInlines.h to fix linking.
Source/WebCore:
- Modules/async-clipboard/ClipboardImageReader.cpp: Add missing Document.h include.
- Modules/async-clipboard/ClipboardImageReader.h: Add missing forward declaration
for Document.
- Modules/fetch/FetchBodyConsumer.cpp: Add missing includes for DOMFormData.h,
HTTPParsers.h, and JSDOMFormData.h.
- css/parser/CSSSelectorParser.cpp: Move CSSSelectorParser declaration to header.
- css/parser/CSSSelectorParser.h: Ditto.
- css/parser/CSSSupportsParser.cpp: Add missing CSSSelectorParser.h include.
- dom/DataTransferItemList.cpp: Add missing includes for ContextDestructionObserver.h
and Document.h.
- html/HTMLMetaElement.cpp: Add missing includes for Settings.h and
wtf/IsoMallocInlines.h.
- html/canvas/EXTBlendMinMax.cpp: Add missing wtf/IsoMallocInlines.h include.
- html/canvas/EXTColorBufferFloat.cpp: Ditto.
- html/canvas/OESElementIndexUint.cpp: Ditto.
- html/canvas/WebGLCompressedTextureASTC.cpp: Ditto.
- html/canvas/WebGLCompressedTextureATC.cpp: Ditto.
- html/canvas/WebGLCompressedTextureETC.cpp: Ditto.
- inspector/InspectorFrontendHost.cpp: Add missing Settings.h include.
- layout/display/DisplayLayerController.cpp: Add missing LayoutState.h include.
- layout/displaytree/DisplayPainter.h: Add missing LayoutBox.h include.
- layout/inlineformatting/InlineLineBox.cpp: Add missing InlineFormattingContext.h
include.
- platform/audio/FFTFrame.cpp: Add missing VectorMath.h include.
- platform/audio/SincResampler.h: Add missing wtf/Optional.h include.
- rendering/SimpleLineLayout.h: Add missing RenderStyleConstants.h include.
Source/WebKit:
- GPUProcess/media/RemoteCDMProxy.cpp: Add missing WebCore/SharedBuffer.h include.
- GPUProcess/media/RemoteMediaResourceLoader.cpp: Add missing WebCore/ResourceError.h
include.
- NetworkProcess/webrtc/NetworkRTCProvider.cpp: Add missing DataReference.h include.
- UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
(WebKit::WebDataListSuggestionsDropdownGtk::show): Add missing namespace to
WebCore::monitorWorkArea() call.
- WebProcess/Network/WebSocketChannelManager.cpp: Add missing
WebCore/WebSocketIdentifier.h include.
(WebKit::WebSocketChannelManager::didReceiveMessage): Add missing namespace to
WebCore::WebSocketIdentifierType usage.
- 7:05 AM Changeset in webkit [267142] by
-
- 3 edits in trunk/Source/WebCore
[LFC][FFC] Create a Layout::ContainerBox for flex container
https://bugs.webkit.org/show_bug.cgi?id=216598
Reviewed by Antti Koivisto.
A flex container establishes a flex formatting context.
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::createFormattingContext):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
- 6:45 AM Changeset in webkit [267141] by
-
- 4 edits2 adds in trunk
[Cocoa] Use OTF font features instead of AAT font features when possible
https://bugs.webkit.org/show_bug.cgi?id=182845
<rdar://problem/33046942>
Reviewed by Myles C. Maxfield.
Source/WebCore:
Using OTF font features instead of AAT font features allows WebKit to
leverage CoreText's mapping between OTF and AAT features. This prevents us
from having to maintain our own mapping, and adds support for previously
missing features (for AAT fonts), such as stylistic alternatives.
Note that the hlig and hist features are not mapped by CoreText for AAT
fonts, in which case we handle the mapping to an AAT font feature ourselves.
Test: css3/font-feature-settings-stylistic-set.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::appendTrueTypeFeature):
(WebCore::preparePlatformFont):
LayoutTests:
- css3/font-feature-settings-stylistic-set-expected-mismatch.html: Added.
- css3/font-feature-settings-stylistic-set.html: Added.
- platform/win/TestExpectations:
- 6:17 AM WebKitGTK/2.30.x edited by
- (diff)
- 3:26 AM WebKitFlatpakSDK/PerfTools edited by
- (diff)
- 3:24 AM WebKitFlatpakSDK/PerfTools edited by
- (diff)
- 2:20 AM WebKitFlatpakSDK/PerfTools created by
- 2:16 AM WebKitFlatpakSDK edited by
- (diff)
- 12:18 AM Changeset in webkit [267140] by
-
- 2 edits3 adds in trunk/Tools
[Flatpak SDK] Cherry-pick Mesa use-after-free fixes
https://bugs.webkit.org/show_bug.cgi?id=216532
Reviewed by Žan Doberšek.
These patches are not in any stable Mesa release yet. The crash is happening on various
tests on both WPE and GTK test bots.
Upstream MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5789
- buildstream/elements/sdk/mesa.bst:
- buildstream/patches/mesa/0001-mesa-rename-_mesa_free_errors_data.patch: Added.
- buildstream/patches/mesa/0002-mesa-add-bool-param-to-_mesa_free_context_data.patch: Added.
- buildstream/patches/mesa/0003-mesa-st-release-debug_output-after-destroying-the-co.patch: Added.
- 12:10 AM Changeset in webkit [267139] by
-
- 7 edits9 deletes in trunk/Tools
[GStreamer] Update Flatpak SDK to 1.18.0
https://bugs.webkit.org/show_bug.cgi?id=216270
Reviewed by Žan Doberšek.
Update to GStreamer 1.18.0, removing the patches now being shipped in this release.
- buildstream/elements/sdk/gst-libav.bst:
- buildstream/elements/sdk/gst-plugins-bad.bst:
- buildstream/elements/sdk/gst-plugins-base.bst:
- buildstream/elements/sdk/gst-plugins-good.bst:
- buildstream/elements/sdk/gst-plugins-ugly.bst:
- buildstream/elements/sdk/gstreamer.bst:
- buildstream/patches/gst-libav-stop-caching-codecs.patch: Removed.
- buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Removed.
- buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Removed.
- buildstream/patches/gst-plugins-base-0001-oggstream-Workaround-for-broken-PAR-in-VP8-BOS.patch: Removed.
- buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Removed.
- buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Removed.
- buildstream/patches/gst-plugins-base-0003-glbasefilter-add-support-for-changing-the-display.patch: Removed.
- buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Removed.
- buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Removed.
- 12:08 AM Changeset in webkit [267138] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer][1.18] Regressions
https://bugs.webkit.org/show_bug.cgi?id=216558
Reviewed by Xabier Rodriguez-Calvar.
The most significant change here is the added support for video rendering stats caching.
This was caught by
imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html
- platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkGetProperty): Fix 1.18 version runtime check. 1.17 was the development version of 1.18.
- platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::videoPlaybackQualityMetrics): Cache or reuse cached
statistics. Caching is required so that metrics queries performed after EOS still return
valid values.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Sep 15, 2020:
- 11:33 PM Changeset in webkit [267137] by
-
- 9 edits in trunk/Source
REGRESSION(r266677): ASSERTION FAILED in PaintFrequencyTracker::end()
https://bugs.webkit.org/show_bug.cgi?id=216591
<rdar://problem/68635418>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-15
Reviewed by Simon Fraser.
Source/WebCore:
Make RenderLayer track the painting which is scheduled through
RenderingUpdateScheduler only. We can do this by (1) reseting Page::
m_renderingUpdateTimestamp at the end of Page::updateRendering() and (2)
making SinglePaintFrequencyTracking track the painting only if the
timestamp is not zero.
- page/ChromeClient.h:
(WebCore::ChromeClient::timestampForPaintFrequencyTracking const): Deleted.
- page/Page.cpp:
(WebCore::Page::updateRendering):
- page/Page.h:
(WebCore::Page::renderingUpdateTimestamp const):
(WebCore::Page::lastRenderingUpdateTimestamp const): Deleted.
- rendering/PaintFrequencyTracker.h:
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):
Source/WebKit:
timestampForPaintFrequencyTracking() do not have to be in ChromeClient.
RenderLayer can access it through its page(). No need to special case
isSVGImageChromeClient() because we are going to track the painting that
goes through Page::updateRendering(). This means all the painting of the
SVG image RenderLayers will be tracked by the same timestamp. Currently
we do not support compositing inside the SVG image which means there is
only one RenderLayer per SVG image.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::timestampForPaintFrequencyTracking const): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 11:22 PM Changeset in webkit [267136] by
-
- 4 edits in trunk
Fix lazy image load painting
https://bugs.webkit.org/show_bug.cgi?id=216554
Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Darin Adler.
Source/WebCore:
Fix lazy image load painting, when LoadImmediately was introduced, it correctly
triggered the immediate load but after finishing the load there was no transition
to the finished lazy load state, causing the logic in RenderImage::paint to not
paint the finished load. This was not detected before since most lazy load WPT tests are
not pixel tests but rather test correct load events etc. (image-loading-subpixel-clip.html
is an exception since it is a reftest).
Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
LayoutTests:
The test image-loading-subpixel-clip.html now passes.
- 11:07 PM Changeset in webkit [267135] by
-
- 3 edits1 add in trunk
JSImmutableButterfly::get needs to return jsDoubleNumber for double arrays
https://bugs.webkit.org/show_bug.cgi?id=216589
<rdar://problem/68061245>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/jsimmutablebutterfly-get-must-return-double-boxed-value.js: Added.
Source/JavaScriptCore:
We are using JSImmutableButterfly::get in AI to constant fold GetByVal,
but we were failing to always return a boxed double value for double loads.
We were calling jsNumber instead of jsDooubleNumber. This is in contrast to
the runtime, which always returns a double boxed value. This would lead AI
to disagree with the runtime, and miscompile code.
- runtime/JSImmutableButterfly.h:
(JSC::JSImmutableButterfly::get const):
- 9:43 PM Changeset in webkit [267134] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] 'display: flex' generates a flex container box that is block-level when placed in flow layout
https://bugs.webkit.org/show_bug.cgi?id=216596
Reviewed by Simon Fraser.
See https://www.w3.org/TR/css-flexbox-1/#flex-containers.
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isBlockLevelBox const):
- 9:33 PM Changeset in webkit [267133] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Use isBlockBox() in Box::establishesBlockFormattingContext
https://bugs.webkit.org/show_bug.cgi?id=216595
Reviewed by Simon Fraser.
Let's use the Box::isBlockBox() function (now that we have it) to check if a box establishes a new BFC (this matches spec language now).
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::establishesBlockFormattingContext const):
- 9:23 PM Changeset in webkit [267132] by
-
- 7 edits5 adds in trunk
[JSC] Cache UDateTimePatternGenerator
https://bugs.webkit.org/show_bug.cgi?id=213454
Reviewed by Ross Kirsling.
JSTests:
- microbenchmarks/date-to-locale-date-string.js: Added.
- microbenchmarks/date-to-locale-string.js: Added.
- microbenchmarks/date-to-locale-time-string.js: Added.
Source/JavaScriptCore:
ICU udatpg_open function is particularly slow. As a result, 80~% of time is used by this function when calling Date#toLocaleString.
We should have last-used cache in VM, which covers major cases like, "One locale (possibly default locale) is used and continuously
use toLocaleString with that locale".
This significantly improves toLocaleString / toLocaleDateString / toLocaleTimeString performance.
ToT Patched
date-to-locale-string 392.0092+-0.6811 87.3196+-3.1598 definitely 4.4894x faster
date-to-locale-date-string 377.9117+-7.8701 70.4155+-3.6661 definitely 5.3669x faster
date-to-locale-time-string 373.1970+-3.0142 67.3790+-2.8952 definitely 5.5388x faster
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- runtime/IntlCache.cpp: Added.
(JSC::IntlCache::cacheSharedPatternGenerator):
(JSC::IntlCache::getBestDateTimePattern):
- runtime/IntlCache.h: Added.
(JSC::IntlCache::getSharedPatternGenerator):
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::intlCache):
- 8:10 PM Changeset in webkit [267131] by
-
- 5 edits in trunk/Source
[macOS] Date pickers should respect the document's color scheme
https://bugs.webkit.org/show_bug.cgi?id=216514
<rdar://problem/68889548>
Reviewed by Tim Horton.
Source/WebCore:
Added the useDarkAppearance property to DateTimeChooserParameters, which
is based on Document::useDarkAppearance and the associated element's
computed style.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
- platform/DateTimeChooserParameters.h:
(WebCore::DateTimeChooserParameters::encode const):
(WebCore::DateTimeChooserParameters::decode):
Source/WebKit:
Use the appearance property of NSWindow to ensure the appearance of the
contained NSDatePicker matches the value encoded in DateTimeChooserParameters.
- UIProcess/mac/WebDateTimePickerMac.mm:
(-[WKDateTimePicker initWithParams:inView:]):
- 7:53 PM Changeset in webkit [267130] by
-
- 10 edits5 adds1 delete in trunk
WebKit should support building with clang ThreadSanitizer enabled
<https://webkit.org/b/216318>
<rdar://problem/31615729>
Reviewed by Darin Adler.
This patch doesn't attempt to resolve every potential false
positive, but makes it easy to build WebKit with TSan enabled.
.:
- Makefile.shared:
- Update to work with
make [args] TSAN=YES.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- Add ThreadSanitizerSupport.h to the project.
- wtf/Compiler.h:
- Define TSAN_ENABLED and SUPPRESS_TSAN macros.
- wtf/Locker.h:
(WTF::Locker::~Locker):
(WTF::Locker::unlockEarly):
(WTF::Locker::operator=):
(WTF::Locker::lock):
- Instrument lock/unlock methods for ThreadSanitizer.
- wtf/ThreadSanitizerSupport.h: Add.
(AnnotateHappensBefore):
(AnnotateHappensAfter):
- Declare TSan runtime functions needed to annotate WTF::Locker.
(TSAN_ANNOTATE_HAPPENS_BEFORE):
(TSAN_ANNOTATE_HAPPENS_AFTER):
- Define macros used to call TSan runtime functions if TSan is enabled.
Tools:
- Scripts/set-webkit-configuration:
- Add support for --[no-]tsan switches.
- Scripts/webkitdirs.pm:
(determineTSanIsEnabled):
(tsanIsEnabled):
(XcodeOptions):
(generateBuildSystemFromCMakeProject):
- Add support for building with TSan enabled.
- asan/asan.xcconfig: Rename to sanitizer/asan.xcconfig.
- sanitizer/asan.xcconfig: Rename from asan/asan.xcconfig.
- Extract common variables to sanitizer.xcconfig.
- sanitizer/sanitizer.xcconfig: Add.
- Extract common variables from asan.xcconfig.
- sanitizer/tsan.xcconfig: Add.
- Add support for TSan.
- 7:42 PM Changeset in webkit [267129] by
-
- 2 edits in trunk/LayoutTests
Change test expectation description
rdar://68957822
Unreviewed test gardening.
- platform/mac/TestExpectationsRosetta:
- 7:36 PM Changeset in webkit [267128] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [ BigSur wk2 rosetta ] compositing/contents-scale/hidpi-compositing-layer-positioned-on-scaled-context.html is a flaky failure
rdar://68957822
Unreviewed test gardening.
- platform/mac/TestExpectationsRosetta:
- 7:21 PM Changeset in webkit [267127] by
-
- 2 edits in trunk/LayoutTests
[ BigSur+ ] webrtc/captureCanvas-webrtc-software-h264-high.html is a constant failure/timeout
<rdar://68957215>
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 6:37 PM Changeset in webkit [267126] by
-
- 3 edits1 move1 delete in trunk/Source/WebCore
Delete LocaleToScriptMappingICU.cpp since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=216592
Reviewed by Myles C. Maxfield.
All ports are using LocaleToScriptMappingDefault.cpp and nobody is using / building LocaleToScriptMappingICU.cpp.
Let's remove it and rename LocaleToScriptMappingDefault.cpp to LocaleToScriptMapping.cpp
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/LocaleToScriptMapping.cpp: Renamed from Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp.
- platform/text/LocaleToScriptMappingICU.cpp: Removed.
- 6:17 PM Changeset in webkit [267125] by
-
- 3 edits1 add in trunk
Check whether the iterator is callable in spread
https://bugs.webkit.org/show_bug.cgi?id=215974
Patch by HyeockJin Kim <kherootz@gmail.com> on 2020-09-15
Reviewed by Darin Adler.
JSTests:
- stress/spread-array-iterator.js: Added.
(shouldThrowTypeError):
(shouldThrowExactly):
(f):
(C):
Source/JavaScriptCore:
- builtins/IteratorHelpers.js:
(performIteration):
- 6:07 PM Changeset in webkit [267124] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html: Correction for test expectations
<rdar://68947198>
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations: to include wk1
- 5:57 PM Changeset in webkit [267123] by
-
- 14 edits in trunk
Move local storage sync SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216581
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.
Source/WebKit:
This move is needed for https://bugs.webkit.org/show_bug.cgi?id=216041
We no longer need to sync the legacy private browsing storage because it is no longer used by WebKitTestRunner. Thank goodness.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearLegacyPrivateBrowsingLocalStorage): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/C/WKContext.cpp:
(WKContextSyncLocalStorage): Deleted.
(WKContextClearLegacyPrivateBrowsingLocalStorage): Deleted.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSyncLocalStorage):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::syncLocalStorage): Deleted.
(WebKit::WebProcessPool::clearLegacyPrivateBrowsingLocalStorage): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::syncLocalStorage):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::clearLocalStorage):
(WTR::TestController::syncLocalStorage):
- 5:54 PM Changeset in webkit [267122] by
-
- 11 edits in trunk
Move service worker testing timeout setting from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216578
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Geoffrey Garen.
Source/WebKit:
This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041
- UIProcess/API/C/WKContext.cpp:
(WKContextSetServiceWorkerFetchTimeoutForTesting): Deleted.
(WKContextResetServiceWorkerFetchTimeoutForTesting): Deleted.
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetServiceWorkerFetchTimeoutForTesting):
(WKWebsiteDataStoreResetServiceWorkerFetchTimeoutForTesting):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setServiceWorkerTimeoutForTesting): Deleted.
(WebKit::WebProcessPool::resetServiceWorkerTimeoutForTesting): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::resetServiceWorkerTimeoutForTesting):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::setServiceWorkerFetchTimeoutForTesting):
- 5:50 PM Changeset in webkit [267121] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS wk2 ] media/media-continues-playing-after-replace-source.html is a flaky failure
<rdar://68952824>
Unreviewed test gardening.
- platform/ios/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 5:22 PM Changeset in webkit [267120] by
-
- 11 edits2 moves in trunk/Tools
[TestRunnerShared] Add a new class UIScriptControllerCommon to implement UIScriptController::windowIsKey and UIScriptController::setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=216469
Reviewed by Darin Adler.
Even though UIScriptController class is defined in
TestRunnerShared, UIScriptController::windowIsKey and
UIScriptController::setWindowIsKey methods were defined in the
client modules DRT and WTR. I'd like to make TestRunnerShared a
stand-alone library which doesn't depend on DRT and WTR (Bug
216465).
Add a new class UIScriptControllerCommon to host the common
methods by renaming UIScriptController.cpp.
- DumpRenderTree/CMakeLists.txt:
- TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::windowIsKey const):
(WTR::UIScriptController::setWindowIsKey):
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/UIScriptControllerCommon.cpp: Renamed from Tools/WebKitTestRunner/UIScriptController.cpp.
(WTR::UIScriptControllerCommon::windowIsKey const):
(WTR::UIScriptControllerCommon::setWindowIsKey):
- WebKitTestRunner/UIScriptControllerCommon.h: Added.
(WTR::UIScriptControllerCommon::UIScriptControllerCommon):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
- WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::UIScriptControllerCocoa):
- WebKitTestRunner/gtk/UIScriptControllerGtk.h:
(WTR::UIScriptControllerGtk::UIScriptControllerGtk):
- WebKitTestRunner/win/UIScriptControllerWin.h:
(WTR::UIScriptControllerWin::UIScriptControllerWin):
- WebKitTestRunner/wpe/UIScriptControllerWPE.h:
- 5:15 PM Changeset in webkit [267119] by
-
- 17 edits in branches/safari-610.2.5.1-branch
Cherry-pick r266121. rdar://problem/68949249
[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated AudioRoutingArbitration API test.
- platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
- platform/audio/AudioSession.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.
- platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.
- testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
- UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):
- UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):
- UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
- TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:13 PM Changeset in webkit [267118] by
-
- 8 edits in branches/safari-610.2.5.1-branch/Source
Versioning.
WebKit-7610.2.5.1.2
- 5:09 PM Changeset in webkit [267117] by
-
- 17 edits in branches/safari-610-branch
Cherry-pick r266121. rdar://problem/68949237
[macOS] Update audio arbitration manager when audio transport changes
https://bugs.webkit.org/show_bug.cgi?id=215781
<rdar://problem/65920613>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated AudioRoutingArbitration API test.
- platform/audio/AudioSession.cpp: (WebCore::AudioSession::audioOutputDeviceChanged): Add empty method. (WebCore::setIsPlayingToBluetoothOverride): Ditto.
- platform/audio/AudioSession.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::audioOutputDeviceChanged): Call AudioSession::audioOutputDeviceChanged.
- platform/audio/mac/AudioSessionMac.mm: (WebCore::defaultDeviceTransportIsBluetooth): New. (WebCore::AudioSession::audioOutputDeviceChanged): Clear m_private->playingToBluetooth if bluetooth transport has changed since the last arbitration update. (WebCore::AudioSession::setIsPlayingToBluetoothOverride): Allow override of bluetooth transport for testing. (WebCore::AudioSession::setCategory): Update routing arbitration if audio session category or bluetooth transport changes.
- testing/Internals.cpp: (WebCore::Internals::setIsPlayingToBluetoothOverride):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
- UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _audioRoutingArbitrationUpdateTime]):
- UIProcess/Media/AudioSessionRoutingArbitratorProxy.h: (WebKit::AudioSessionRoutingArbitratorProxy::arbitrationUpdateTime const):
- UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm: (WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add message string to help debugging when the test fails.
- TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:06 PM Changeset in webkit [267116] by
-
- 4 edits in trunk/Source
[macOS Big Sur] CGFontRenderingGetFontSmoothingDisabled() is no longer useful
https://bugs.webkit.org/show_bug.cgi?id=216588
<rdar://problem/68657748>
Reviewed by Simon Fraser.
Source/WebCore:
No new tests because there is no behavior change.
- platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::FontCascade::isSubpixelAntialiasingAvailable):
Source/WTF:
We can eliminate WebKit's use of it to eventually phase it out entirely.
- wtf/PlatformHave.h:
- 4:51 PM Changeset in webkit [267115] by
-
- 2 edits in trunk/JSTests
Unreviewed, skip construct-return-early-from-infinite-loop-for-fuzzer.js when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=216406
We are not supporting returnEarlyFromInfiniteLoopsForFuzzing option for CLoop.
- stress/construct-return-early-from-infinite-loop-for-fuzzer.js:
(vm.useJIT):
- 4:46 PM Changeset in webkit [267114] by
-
- 3 edits1 add in trunk
Object allocation sinking forgets escaped nodes when structure changes
https://bugs.webkit.org/show_bug.cgi?id=216214
<rdar://problem/68518460>
Reviewed by Saam Barati.
JSTests:
- stress/allocation-sinking-changing-structures.js: Added.
(main.v4.get v4):
(main):
Source/JavaScriptCore:
Consider the following program:
bb0:
a: NewObject
b: CreateActivation()
_: Branch(bb2, bb1)
bb1:
_: PutByOffset(a, 'x', 42)
_: PutStrucute(a, {x: 0})
_: Branch(bb2, bb1)
bb2:
_: CheckStructure(a, {x: 0})
_: PutClosureVar(b, 0, Kill:a)
_: Branch(bb3, bb2)
bb3:
c: GetClosureVar(b, 0)
_: PutByOffset(global, 'y', c)
_: Return
Due to the order we visit the program, we'll visit bb2 before bb1. The first time we visit bb2, heapAtHead will be:
#@a: ObjectAllocation({})
#@b: ActivationAllocation()
@a => #@a
@b => #@b
Now CheckStructure would always fail, so it will escape @a and heapAtTail will be:
#@a: EscapedAllocation()
#@b: ActivationAllocation()
@a => #@a
@b => #@b
And after pruning:
#@b: ActivationAllocation()
@b => #@b
Now, we'll visit bb3 and then bb1. When we visit bb1 we'll set the structure {x: 0} for the #@a and eventually visit bb2 again. This time around CheckStructure will no longer escape @a, since the allocation has the right structure, and heapAtTail will be:
#@a: ObjectAllocation({x: 0})
#@b: ActivationAllocation(0: #@a)
@b => #@b
However, we now have to merge into bb3, which has heapAtHead:
#@b: ActivationAllocation()
@b => #@b
Since we can't add the extra field to the activation, we'll end up escaping @a at the edge and therefore pruning #@b, which will leave the heap for bb3 unchanged.
That's a problem, since PutClosureVar didn't see the escaped object, but GetClosureVar thinks it's escaped. The materialization for @a will be placed after the
PutClosureVar, at end of bb2, when the node is already dead. When computing the SSA defs, the PutByOffset at bb3 will then see @a (which at this point will be a
PhantomNewObject) instead of its materialization.
The issue happens because we don't allow allocations to add extra fields while merging, but we do allow adding new structures. This results in different decisions
being made about what escapes in CheckStructure and MultiGetByOffset. To avoid this problem, we track two sets of structures: structures and structuresForMaterialization.
The first is used for checks and should never grow while the second is used for materialization and is allowed to grow.
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- 4:38 PM Changeset in webkit [267113] by
-
- 7 edits1 add in trunk
CustomFunctionEquivalence PropertyCondition needs to check if the structure has the property
https://bugs.webkit.org/show_bug.cgi?id=216575
<rdar://problem/68286930>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/has-static-property-property-condition-needs-to-check-if-structure-has-property.js: Added.
(foo):
Source/JavaScriptCore:
The CustomFunctionEquivalence PropertyCondition would only return false to
isStillValidAssumingImpurePropertyWatchpoint if the Structure's static
property table was reified or if the static property table did not contain the
property. However, this missed the obvious case of where we store to this
property in normal object storage without reifying the static property table.
The fix here is simple: we first check if the Structure's property table
has this property, and if so, return false.
This patch also renames CustomFunctionEquivalence to HasStaticProperty to
better capture what we're doing.
- bytecode/ObjectPropertyCondition.h:
(JSC::ObjectPropertyCondition::hasStaticProperty):
(JSC::ObjectPropertyCondition::customFunctionEquivalence): Deleted.
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition const):
(JSC::ObjectPropertyConditionSet::slotBaseCondition const):
(JSC::generateConditionsForPrototypePropertyHitCustom):
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::dumpInContext const):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const):
(JSC::PropertyCondition::isStillValid const):
(JSC::PropertyCondition::isWatchableWhenValid const):
(WTF::printInternal):
- bytecode/PropertyCondition.h:
(JSC::PropertyCondition::hasStaticProperty):
(JSC::PropertyCondition::hash const):
(JSC::PropertyCondition::operator== const):
(JSC::PropertyCondition::customFunctionEquivalence): Deleted.
- tools/JSDollarVM.cpp:
(JSC::functionCreateStaticCustomValue):
(JSC::JSDollarVM::finishCreation):
- 4:34 PM Changeset in webkit [267112] by
-
- 6 edits in trunk/Source/WebCore
[Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp
https://bugs.webkit.org/show_bug.cgi?id=216525
Reviewed by Dean Jackson.
This migrates:
- Font::isProbablyOnlyUsedToRenderIcons()
- Font::platformSupportsCodePoint()
- Font::determinePitch()
- Font::platformBoundsForGlyph()
- Font::platformPathForGlyph()
- Font::applyTransforms()
from the old Windows CG codepath to the Core Text codepath. This patch unifies these functions
between the Apple Windows port and the macOS / iOS ports.
Covered by existing tests.
- platform/graphics/Font.cpp:
(WebCore::Font::variantCapsSupportsCharacterForSynthesis const):
(WebCore::Font::platformSupportsCodePoint const): Deleted.
- platform/graphics/coretext/FontCoreText.cpp:
(WebCore::Font::platformWidthForGlyph const): Move this up into the #if !PLATFORM(WIN) section.
We don't want to migrate this one just yet because it causes a significant number of test failures,
which require more investigation.
(WebCore::Font::determinePitch):
(WebCore::Font::isProbablyOnlyUsedToRenderIcons const):
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::Font::platformBoundsForGlyph const): Deleted.
(WebCore::Font::platformPathForGlyph const): Deleted.
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::Font::determinePitch): The WinCairo port is the only port still using the non-CG Windows
implementation of this function, so we can just move it directly into the CairoWin-specific file.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::Font::determinePitch): Deleted.
- 4:33 PM Changeset in webkit [267111] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r266634): [ BigSur wk2 ] fast/selectors/text-field-selection-window-inactive-stroke-color.html is a flaky image failure
rdar://68947260
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:21 PM Changeset in webkit [267110] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r267053): ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient in [WKFullScreenWindowController _completedExitFullScreen]
https://bugs.webkit.org/show_bug.cgi?id=216571
Reviewed by Jer Noble.
It is possible that an element exits fullscreen before it completely enters
fullscreen. In that case, the client of VideoFullscreenManagerProxy is nullptr.
No new tests, fixing an assertion failure when running
TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _completedExitFullScreen]):
- 4:08 PM Changeset in webkit [267109] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections.html
<rdar://68947198>
Unreviewed test gardening.
- platform/ios/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 3:56 PM Changeset in webkit [267108] by
-
- 6 edits1 add in trunk
[JSC] Apply Intl.DateTimeFormat hour-cycle correctly when timeStyle is used
https://bugs.webkit.org/show_bug.cgi?id=216521
Reviewed by Ross Kirsling.
JSTests:
JSTests/stress/intl-date-time-format-date-time-style-hour-cycle.js result is now matching against V8 and SpiderMonkey,
and this new behavior is more reasonable.
- stress/intl-date-time-format-date-time-style-hour-cycle.js:
(shouldBe.o.format):
(shouldBe):
- stress/intl-datetimeformat-hour-cycle.js: Added.
(shouldBe):
(throw.new.Error):
- test262/expectations.yaml:
Source/JavaScriptCore:
When specifying timeStyle in Intl.DateTimeFormat, we need to check that the generated format also follows to the hourCycle / hour12 options
specified in the constructor. Because dayPeriod can be included automatically, just replacing symbols after generating a pattern can dump strange result.
For example, the generated one is something like "02:12:47 PM Coordinated Universal Time". And we adjust the pattern to make it "14:12:47 PM Coordinated Universal Time"
when hourCycle H23 / H24 is specified. But this looks strange since dayPeriod "PM" should not exist when using H23 / H24.
In this patch, we revise our hour-cycle handling in Intl.DateTimeFormat. We align our behavior to SpiderMonkey's one[1] rather than the spec's one: when hour12 is specified,
we will just use 'H' or 'h' skeleton and do not enforce hour-cycle after generating pattern in hour12 case. If hour12 is not specified, then we use 'h' or 'H' skeleton
symbols based on hour-cycle, and later we modify the pattern based on hour-cycle. If both are not offered, we use 'j' which allows ICU to pick preferable one.
This is slightly different behavior to the spec (hcDefault etc.) but the spec's behavior can cause a bit surprising result[2,3], and SpiderMonkey like behavior will be
integrated into the spec eventually[4].
[1]: https://github.com/tc39/ecma402/issues/402#issuecomment-623628320
[2]: https://github.com/tc39/ecma402/issues/402
[3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1045791
[4]: https://github.com/tc39/ecma402/pull/436
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::setFormatsFromPattern):
(JSC::IntlDateTimeFormat::parseHourCycle):
(JSC::IntlDateTimeFormat::hourCycleFromPattern):
(JSC::IntlDateTimeFormat::replaceHourCycleInSkeleton):
(JSC::IntlDateTimeFormat::replaceHourCycleInPattern):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::hourCycleString):
(JSC::IntlDateTimeFormat::resolvedOptions const):
(JSC::IntlDateTimeFormat::createDateIntervalFormatIfNecessary):
- runtime/IntlDateTimeFormat.h:
- 3:37 PM Changeset in webkit [267107] by
-
- 5 edits in trunk
ScriptProcessorNode should throw when trying to change its channel count or channel count mode
https://bugs.webkit.org/show_bug.cgi?id=216583
Reviewed by Geoffrey Garen.
Source/WebCore:
ScriptProcessorNode should throw when trying to change its channel count or channel count mode:
- https://www.w3.org/TR/webaudio/#audionode-channelcount-constraints
- https://www.w3.org/TR/webaudio/#audionode-channelcountmode-constraints
No new tests, rebaselined existing test.
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::setChannelCount):
(WebCore::ScriptProcessorNode::setChannelCountMode):
- Modules/webaudio/ScriptProcessorNode.h:
LayoutTests:
Rebaseline test now that more checks are passing.
- webaudio/dom-exceptions-expected.txt:
- 3:25 PM Changeset in webkit [267106] by
-
- 2 edits in trunk/Source/WebCore
CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>
Reviewed by Eric Carlson.
Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
- 3:05 PM Changeset in webkit [267105] by
-
- 1 edit2 adds in trunk/LayoutTests
Import webaudio/dom-exceptions.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=216579
Reviewed by Geoffrey Garen.
Import webaudio/dom-exceptions.html layout test from Blink to extend test coverage.
- webaudio/dom-exceptions-expected.txt: Added.
- webaudio/dom-exceptions.html: Added.
- 3:04 PM Changeset in webkit [267104] by
-
- 1 copy in tags/Safari-610.1.28.1.9
Tag Safari-610.1.28.1.9.
- 3:02 PM Changeset in webkit [267103] by
-
- 2 edits in branches/safari-610.1.28.1-branch/Source/WebKit
Cherry-pick r265930. rdar://problem/67364262
Fix null pointer crashes in network process after r265835
<rdar://problem/67268892>
Call the correct CompletionHandler. completionHandler has already been moved from at this point.
This crash was being hit in the test, but the test recovered from it.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:58 PM Changeset in webkit [267102] by
-
- 4 edits in trunk
[JSC] Intl.Collator should take collation option
https://bugs.webkit.org/show_bug.cgi?id=216529
Reviewed by Ross Kirsling.
JSTests:
- stress/intl-collator-co-extension.js:
(shouldThrow):
Source/JavaScriptCore:
This patch adds "collation" option to Intl.Collator. We are already getting consensus[1], and will be integrated into the spec.
Previously, passing "collation" is only available through "-u-co-" unicode extension in the passed locale. The proposal exposes
collation option as an option to Intl.Collator so that we can set it easily.
"collation" is used only when "usage" is "sort". "search" usage will filter out collation options since "search" itself is one of
the "collation" option.
[1]: https://github.com/tc39/ecma402/pull/459
- runtime/IntlCollator.cpp:
(JSC::IntlCollator::sortLocaleData):
(JSC::IntlCollator::initializeCollator):
- 2:43 PM Changeset in webkit [267101] by
-
- 2 edits in trunk/Source/WebCore
preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command
https://bugs.webkit.org/show_bug.cgi?id=216527
Reviewed by Darin Adler.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor): Use shellwords() to split the $preprocessor.
Use Cygwin Perl's builtin functions instead of spawning process.
- 2:41 PM Changeset in webkit [267100] by
-
- 3 edits in trunk/LayoutTests
[ macOS iOS ] imported/w3c/web-platform-tests/css/css-flexbox/quirks-auto-block-size-with-percentage-item.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=216292
Unreviewed test gardening!.
- platform/mac-wk1/TestExpectations: adjustment for Debug
- platform/mac-wk2/TestExpectations: adjustment for Debug
- 2:28 PM Changeset in webkit [267099] by
-
- 8 edits in branches/safari-610.1.28.1-branch/Source
Versioning.
WebKit-7610.1.28.1.9
- 1:59 PM Changeset in webkit [267098] by
-
- 22 edits in trunk
Remove runtime setting for enabling/disabling the fetch API
https://bugs.webkit.org/show_bug.cgi?id=216519
Reviewed by Alex Christensen.
Remove runtime setting for enabling/disabling the fetch API. There is no
reason one needs to disable it now and it has been on by default for
a long enough time.
Source/WebCore:
- Modules/fetch/FetchBody.idl:
- Modules/fetch/FetchHeaders.idl:
- Modules/fetch/FetchRequest.idl:
- Modules/fetch/FetchResponse.idl:
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setFetchAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::fetchAPIEnabled const): Deleted.
Source/WebKit:
Also cleans up WKPreferencesRefPrivate.h/WKPreferences.cpp to move all the obsolete
preferences to the bottom with a comment about removing them when possible.
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesResetTestRunnerOverrides):
(WKPreferencesSetPrivateBrowsingEnabled):
(WKPreferencesGetPrivateBrowsingEnabled):
(WKPreferencesSetIgnoreViewportScalingConstraints):
(WKPreferencesGetIgnoreViewportScalingConstraints):
(WKPreferencesSetWebRTCLegacyAPIEnabled):
(WKPreferencesGetWebRTCLegacyAPIEnabled):
(WKPreferencesSetNewBlockInsideInlineModelEnabled):
(WKPreferencesGetNewBlockInsideInlineModelEnabled):
(WKPreferencesSetLongMousePressEnabled):
(WKPreferencesGetLongMousePressEnabled):
(WKPreferencesSetAntialiasedFontDilationEnabled):
(WKPreferencesGetAntialiasedFontDilationEnabled):
(WKPreferencesSetHixie76WebSocketProtocolEnabled):
(WKPreferencesGetHixie76WebSocketProtocolEnabled):
(WKPreferencesSetApplicationChromeModeEnabled):
(WKPreferencesGetApplicationChromeModeEnabled):
(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):
(WKPreferencesSetFetchAPIEnabled):
(WKPreferencesGetFetchAPIEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setFetchAPIEnabled:]):
(-[WebPreferences fetchAPIEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::fetchAPIEnabled):
(WebPreferences::setFetchAPIEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- 1:44 PM Changeset in webkit [267097] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the build with recent SDKs.
rdar://68939059
- platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::FontCascade::isSubpixelAntialiasingAvailable):
- 1:04 PM Changeset in webkit [267096] by
-
- 2 edits2 adds in trunk/Tools
[webkitscmpy] Add Contributor object
https://bugs.webkit.org/show_bug.cgi?id=216402
<rdar://problem/68702680>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
- Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: Added.
(Contributor): Object mapping a contributor by name to their associated email addresses.
(Contributor.clear): Clear the in-memory cache of Contributor objects.
(Contributor.from_scm_log): Find or generate a Contributor object given a commit log line from
an SCM tool.
(Contributor.init):
(Contributor.email): Return a single email for a Contributor.
(Contributor.repr):
(Contributor.hash):
(Contributor.cmp):
(Contributor.eq):
(Contributor.ne):
(Contributor.lt):
(Contributor.le):
(Contributor.gt):
(Contributor.ge):
- Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py: Added.
(TestContributor):
(TestContributor.test_git_log):
(TestContributor.test_svn_log):
(TestContributor.test_svn_patch_by_log):
(TestContributor.test_author_mapping):
(TestContributor.test_email_mapping):
(TestContributor.test_invalid_log):
(TestContributor.test_comparison):
(TestContributor.test_string_comparison):
(TestContributor.test_hash):
(TestContributor.test_sorting):
- 12:43 PM Changeset in webkit [267095] by
-
- 18 edits in trunk
Remove runtime setting for enabling/disabling custom elements
https://bugs.webkit.org/show_bug.cgi?id=216518
Reviewed by Tim Horton.
Remove runtime setting for enabling/disabling custom elements. There is no
reason one need to disable it now, and it has been on by default for
a long enough time.
Source/WebCore:
- dom/CustomElementRegistry.idl:
- dom/Document.cpp:
(WebCore::createUpgradeCandidateElement):
- page/DOMWindow.idl:
- page/Settings.yaml:
Source/WebKit:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setCustomElementsEnabled:]):
(-[WebPreferences customElementsEnabled]):
- WebView/WebPreferencesPrivate.h:
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::customElementsEnabled):
(WebPreferences::setCustomElementsEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- 11:57 AM Changeset in webkit [267094] by
-
- 3 edits in trunk/Source/WebCore
Improve thread-safety in ScriptProcessorNode implementation
https://bugs.webkit.org/show_bug.cgi?id=216555
Reviewed by Geoffrey Garen.
Improve thread-safety in ScriptProcessorNode implementation:
- Use a Lock instead of a volatile bool to determine if the main thread is still busy firing the event.
- Pass the doubleBufferIndex to the main thread by capturing it in the lambda instead of relying on a data member.
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::fireProcessEvent):
- Modules/webaudio/ScriptProcessorNode.h:
- 11:49 AM Changeset in webkit [267093] by
-
- 7 edits in trunk/Tools
[webkitscmpy] Add default_branch for local SCM repositories
https://bugs.webkit.org/show_bug.cgi?id=216422
<rdar://problem/68735897>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.default_branch): Query the local checkout for the default branch.
(Git):
(Git.branches): Strip "remotes/origin/" from branch names.
- Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.default_branch):
- Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.default_branch): The default svn branch is always 'trunk'.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branches):
(TestGit.test_tags):
(TestGit):
(TestGit.test_default_branch):
- Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
(TestSvn.test_tags):
(TestSvn):
(TestSvn.test_default_branch):
- 11:39 AM Changeset in webkit [267092] by
-
- 4 edits in trunk
REGRESSION (r267002): ASSERTION FAILED:[ iOS wk2 Debug ] !HashTranslator::equal(KeyTraits::emptyValue(), key) on compositing/ios/overflow-scroll-update-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=216520
<rdar://problem/68894931>
Reviewed by Tim Horton.
Source/WebKit:
Avoid hash lookups with zero nodeIDs.
- WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const):
(WebKit::RemoteScrollingCoordinator::isUserScrollInProgress const):
(WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress const):
LayoutTests:
- platform/ios-wk2/TestExpectations:
- 11:25 AM Changeset in webkit [267091] by
-
- 14 edits in trunk
Move WKContextClearCachedCredentials SPI to WKWebsiteDataStoreClearCachedCredentials
https://bugs.webkit.org/show_bug.cgi?id=216513
Reviewed by Chris Dumez.
Source/WebKit:
The credentials are owned by session anyways.
This is needed for https://bugs.webkit.org/show_bug.cgi?id=216041
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearCachedCredentials):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/C/WKContext.cpp:
(WKContextClearCachedCredentials): Deleted.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreClearCachedCredentials):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearCachedCredentials):
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::clearCachedCredentials):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- 11:07 AM Changeset in webkit [267090] by
-
- 20 edits in trunk
Remove unused plumbing for setting whether the storage access API is enabled
https://bugs.webkit.org/show_bug.cgi?id=216516
Reviewed by Youenn Fablet.
Source/WebCore:
Sending a boolean from the process pool to the network process has been superceded by a preference in WebPreferences.yaml.
The boolean sent to the network process was not even used any more.
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled): Deleted.
Source/WebKit:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled): Deleted.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetStorageAccessAPIEnabled): Deleted.
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerSetStorageAccessAPIEnabled): Deleted.
- UIProcess/API/C/WKCookieManager.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _isStorageAccessAPIEnabled]): Deleted.
(-[WKProcessPool _setStorageAccessAPIEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setStorageAccessAPIEnabled): Deleted.
- UIProcess/WebProcessPool.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- 10:04 AM Changeset in webkit [267089] by
-
- 10 edits2 copies1 add6 deletes in trunk/Source/WebCore
[WebIDL] Update Fetch IDLs to use WindowOrWorkerGlobalScope partial mixin
https://bugs.webkit.org/show_bug.cgi?id=216524
Reviewed by Darin Adler.
Move global fetch() function definition from DOMWindowFetch.idl & WorkerGlobalScopeFetch.idl
to single WindowOrWorkerGlobalScopeFetch.idl, matching the spec.
Also cleanup some comments in other Fetch related IDLs.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/fetch/DOMWindowFetch.cpp: Removed.
- Modules/fetch/DOMWindowFetch.h: Removed.
- Modules/fetch/DOMWindowFetch.idl: Removed.
- Modules/fetch/FetchRequest.idl:
- Modules/fetch/FetchRequestInit.idl:
- Modules/fetch/FetchResponse.idl:
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp: Added.
(WebCore::WindowOrWorkerGlobalScopeFetch::fetch):
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.h: Added.
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl: Added.
- Modules/fetch/WorkerGlobalScopeFetch.cpp: Removed.
- Modules/fetch/WorkerGlobalScopeFetch.h: Removed.
- Modules/fetch/WorkerGlobalScopeFetch.idl: Removed.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 9:28 AM Changeset in webkit [267088] by
-
- 14 edits in trunk
Move WebSocket TLS bypass SPI from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216509
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-15
Reviewed by Youenn Fablet.
Source/WebKit:
After https://bugs.webkit.org/show_bug.cgi?id=216041 we will be unable to determine which WebsiteDataStore's
NetworkProcess to add the TLS bypass to, so we need to move the SPI to the WebsiteDataStore object. This breaks
off a piece of that large change into a small, easy-to-review change.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetAllowsAnySSLCertificateForWebSocketTesting): Deleted.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetAllowsAnySSLCertificateForWebSocketTesting):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _allowAnyTLSCertificateForWebSocketTesting]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setAllowsAnySSLCertificateForWebSocket): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::setAllowsAnySSLCertificate):
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::setAllowsAnySSLCertificate):
- 9:16 AM Changeset in webkit [267087] by
-
- 3 edits1 add in trunk/Source/WebCore
[LFC] Move Layout::Rect to a dedicated file
https://bugs.webkit.org/show_bug.cgi?id=216553
Reviewed by Antti Koivisto.
- WebCore.xcodeproj/project.pbxproj:
- layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::Rect::expandHorizontally): Deleted.
(WebCore::Layout::Rect::expandVertically): Deleted.
(WebCore::Layout::Rect::intersects const): Deleted.
(WebCore::Layout::Rect::invalidateTop): Deleted.
(WebCore::Layout::Rect::invalidateLeft): Deleted.
(WebCore::Layout::Rect::invalidateWidth): Deleted.
(WebCore::Layout::Rect::invalidateHeight): Deleted.
(WebCore::Layout::Rect::hasValidPosition const): Deleted.
(WebCore::Layout::Rect::hasValidSize const): Deleted.
(WebCore::Layout::Rect::hasValidGeometry const): Deleted.
(WebCore::Layout::Rect::Rect): Deleted.
(WebCore::Layout::Rect::invalidatePosition): Deleted.
(WebCore::Layout::Rect::setHasValidPosition): Deleted.
(WebCore::Layout::Rect::setHasValidSize): Deleted.
(WebCore::Layout::Rect::top const): Deleted.
(WebCore::Layout::Rect::left const): Deleted.
(WebCore::Layout::Rect::bottom const): Deleted.
(WebCore::Layout::Rect::right const): Deleted.
(WebCore::Layout::Rect::topLeft const): Deleted.
(WebCore::Layout::Rect::bottomRight const): Deleted.
(WebCore::Layout::Rect::size const): Deleted.
(WebCore::Layout::Rect::width const): Deleted.
(WebCore::Layout::Rect::height const): Deleted.
(WebCore::Layout::Rect::setTopLeft): Deleted.
(WebCore::Layout::Rect::setTop): Deleted.
(WebCore::Layout::Rect::setLeft): Deleted.
(WebCore::Layout::Rect::setWidth): Deleted.
(WebCore::Layout::Rect::setHeight): Deleted.
(WebCore::Layout::Rect::setSize): Deleted.
(WebCore::Layout::Rect::shiftLeftTo): Deleted.
(WebCore::Layout::Rect::shiftRightTo): Deleted.
(WebCore::Layout::Rect::shiftTopTo): Deleted.
(WebCore::Layout::Rect::shiftBottomTo): Deleted.
(WebCore::Layout::Rect::moveHorizontally): Deleted.
(WebCore::Layout::Rect::moveVertically): Deleted.
(WebCore::Layout::Rect::expand): Deleted.
(WebCore::Layout::Rect::clone const): Deleted.
(WebCore::Layout::Rect::operator LayoutRect const): Deleted.
- layout/layouttree/LayoutGeometryRect.h: Added.
(WebCore::Layout::Rect::expandHorizontally):
(WebCore::Layout::Rect::expandVertically):
(WebCore::Layout::Rect::intersects const):
(WebCore::Layout::Rect::invalidateTop):
(WebCore::Layout::Rect::invalidateLeft):
(WebCore::Layout::Rect::invalidateWidth):
(WebCore::Layout::Rect::invalidateHeight):
(WebCore::Layout::Rect::hasValidPosition const):
(WebCore::Layout::Rect::hasValidSize const):
(WebCore::Layout::Rect::hasValidGeometry const):
(WebCore::Layout::Rect::Rect):
(WebCore::Layout::Rect::invalidatePosition):
(WebCore::Layout::Rect::setHasValidPosition):
(WebCore::Layout::Rect::setHasValidSize):
(WebCore::Layout::Rect::top const):
(WebCore::Layout::Rect::left const):
(WebCore::Layout::Rect::bottom const):
(WebCore::Layout::Rect::right const):
(WebCore::Layout::Rect::topLeft const):
(WebCore::Layout::Rect::bottomRight const):
(WebCore::Layout::Rect::size const):
(WebCore::Layout::Rect::width const):
(WebCore::Layout::Rect::height const):
(WebCore::Layout::Rect::setTopLeft):
(WebCore::Layout::Rect::setTop):
(WebCore::Layout::Rect::setLeft):
(WebCore::Layout::Rect::setWidth):
(WebCore::Layout::Rect::setHeight):
(WebCore::Layout::Rect::setSize):
(WebCore::Layout::Rect::shiftLeftTo):
(WebCore::Layout::Rect::shiftRightTo):
(WebCore::Layout::Rect::shiftTopTo):
(WebCore::Layout::Rect::shiftBottomTo):
(WebCore::Layout::Rect::moveHorizontally):
(WebCore::Layout::Rect::moveVertically):
(WebCore::Layout::Rect::expand):
(WebCore::Layout::Rect::clone const):
(WebCore::Layout::Rect::operator LayoutRect const):
- 7:55 AM Changeset in webkit [267086] by
-
- 4 edits in trunk
[css-flexbox] Indefinite flex-basis percentage should cause height to be ignored
https://bugs.webkit.org/show_bug.cgi?id=210077
Reviewed by Darin Adler.
Source/WebCore:
If flex-basis is a percentage of an indefinite height we should ignore
what height specifies and treat it and as height:auto.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::cacheChildMainSize): Cache the intrinsic height of the child when
flex-basis is a percentage of an indefinite length.
LayoutTests:
- TestExpectations: Removed flex-basis-010.html which is passing now.
- 7:35 AM Changeset in webkit [267085] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Update date picker appearance to match system date pickers
https://bugs.webkit.org/show_bug.cgi?id=216517
<rdar://problem/68890678>
Reviewed by Wenson Hsieh.
System date pickers in macOS do not use NSVisualEffectView. Instead, use
a solid background view with three rounded corners.
- UIProcess/mac/WebDateTimePickerMac.mm:
(-[WKDateTimePickerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WKDateTimePickerBackdropView drawRect:]):
(-[WKDateTimePicker initWithParams:inView:]):
- 7:24 AM Changeset in webkit [267084] by
-
- 3 edits1 move2 adds2 deletes in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update baselines and expectations after r267083.
- platform/glib/TestExpectations:
- platform/glib/fast/text/justify-ideograph-leading-expansion-expected.png: Updated after r267010.
- platform/glib/fast/text/justify-ideograph-leading-expansion-expected.txt: Renamed from LayoutTests/platform/wpe/fast/text/justify-ideograph-leading-expansion-expected.txt.
- platform/gtk/fast/repaint/spanner-with-margin-expected.txt: Updated after r266818.
- platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Removed.
- platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Removed.
- 4:36 AM Changeset in webkit [267083] by
-
- 50 edits in trunk
Convert runtime flag to setting for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=215610
Patch by Rob Buis <rbuis@igalia.com> on 2020-09-15
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Remove the webkit-test-runner directive additions done to the lazy image loading tests.
The new expected results are improvements.
- web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html:
Source/WebCore:
Convert runtime flag to setting for lazy image loading. Settings are
preferred over RuntimeEnabledFeatures as they are not global singletons
and are automatically accessible in layout tests via InternalSettingsGenerated.
- loader/ImageLoader.cpp:
Source/WebKit:
Remove lazy image loading runtime flag.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLazyImageLoadingEnabled): Deleted.
(WKPreferencesGetLazyImageLoadingEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Tools:
Remove lazy image loading runtime flag.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
Update test expectations and adjust the tests in http/tests/lazyload/ to
enable the setting. Fow WK1 list more tests that should be skipped.
- TestExpectations:
- http/tests/lazyload/attribute.html:
- http/tests/lazyload/js-image.html:
- http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html:
- http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html:
- http/tests/lazyload/lazy.html:
- http/tests/lazyload/resources/lazy-load-in-iframe.html:
- platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- 2:02 AM Changeset in webkit [267082] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests: handle remotes that are down on startup
https://bugs.webkit.org/show_bug.cgi?id=216357
Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-15
Reviewed by Yusuke Suzuki.
Previously, the GNU parallel runner would needlessly fail to run if a
remote host was down on startup, as it used forEachRemote for the
preparatory steps (which would instafail on error).
Change forEachRemote to (optionally) recover from failure by removing
the remote host from the array. This also handles the case where a
remote unexpectedly comes up during a test run (by not picking it up).
- Scripts/run-jsc-stress-tests:
- 1:56 AM Changeset in webkit [267081] by
-
- 14 edits in trunk
End of media capture should not be reported before 3 seconds of the start of capture
https://bugs.webkit.org/show_bug.cgi?id=216415
Source/WebCore:
Reviewed by Eric Carlson.
Add a timer that allows taking a function and a delay as parameter.
Covered by added API test.
- platform/Timer.h:
(WebCore::DeferrableTaskTimer::fired):
(WebCore::DeferrableTaskTimer::doTask):
(WebCore::DeferrableTaskTimer::cancel):
Source/WebKit:
<rdar://problem/68512358>
Reviewed by Eric Carlson.
Add support for delaying of end of capture notification to the application.
This allows to ensure that a capture indicator stays for long enough for the user to notice it.
A capture indicator should be visible to the user for at least three seconds.
A timer is scheduled when starting a capture and there is no ongoing capture.
As long as the timer is active, the capture state cannot be transitioned to no capture.
Other transitions are allowed.
Once the timer kicks in, any capture state update is done synchronously.
Ensure to update the capture state when the timer kicks in.
Note that even navigations will not allow transitioning the capture state sooner.
This is done to ensure a page does not try to capture one frame before navigating to another page.
In practice, very few pages should navigate quickly after starting capture.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetMediaState):
(WKPageSetMediaCaptureReportingDelayForTesting):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mediaCaptureState]):
- UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
- UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _mediaCaptureReportingDelayForTesting]):
(-[WKWebView _setMediaCaptureReportingDelayForTesting:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
(WebKit::WebPageProxy::updateReportedMediaCaptureState):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::reportedMediaCaptureState const):
(WebKit::WebPageProxy::mediaCaptureReportingDelay const):
(WebKit::WebPageProxy::setMediaCaptureReportingDelay):
Tools:
Reviewed by Eric Carlson.
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
Add a notCapturing boolean and wait for the notification before going back to the capturing page.
Decrease delay to 1 second to make the test run faster.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Make sure to set media capture state delay to zero.
- 1:55 AM Changeset in webkit [267080] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Remove the build warning below since r228533.
warning: ‘%40s’ directive argument is null [-Wformat-overflow=]
Since gcc which has version >= 9 is stricter about passing null string
pointers to printf-like functions, add null string pointer check
to fix the warning proactively.
- jsc.cpp:
(runJSC):
- 12:13 AM Changeset in webkit [267079] by
-
- 9 edits in trunk/Source/WebKit
Enable VP9 in GPUProcess if page needs it
https://bugs.webkit.org/show_bug.cgi?id=216472
Reviewed by Eric Carlson.
In case a page is using GPUProcess for media, send the VP9 parameters to GPUProcess.
GPUProcess will enable VP9 decoders based on that input.
Covered by LayoutTests/media/vp9.html with GPU process enabled.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::enableVP9Decoders):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/GPUConnectionToWebProcess.messages.in:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::enableVP9Decoders):
- GPUProcess/GPUProcess.h:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::updateParameters):
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_limitsNavigationsToAppBoundDomains):
