Timeline
Sep 26, 2020:
- 11:30 PM Changeset in webkit [267651] by
-
- 1478 edits in trunk/LayoutTests/imported/w3c
Remove trailing spaces from expected.txt files in web-platform-tests/[A-Za-h] minus css, dom, encoding, and html
https://bugs.webkit.org/show_bug.cgi?id=217024
Reviewed by Zalan Bujtas.
This affects many files, and it's not helpful to fill the change log with a list of them.
- 11:26 PM Changeset in webkit [267650] by
-
- 2454 edits in trunk/LayoutTests/imported/w3c
Remove trailing spaces from expected.txt files in web-platform-tests/css
https://bugs.webkit.org/show_bug.cgi?id=217018
Reviewed by Zalan Bujtas.
This affects many files, and it's not helpful to fill the change log with a list of them.
- 11:20 PM Changeset in webkit [267649] by
-
- 1289 edits in trunk/LayoutTests/imported/w3c
Remove trailing spaces from expected.txt files in web-platform-tests/[w-z]*
https://bugs.webkit.org/show_bug.cgi?id=217022
Reviewed by Zalan Bujtas.
This affects many files, and it's not helpful to fill the change log with a list of them.
- 10:56 PM Changeset in webkit [267648] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Add <wbr> to showLayoutTree
https://bugs.webkit.org/show_bug.cgi?id=217025
Reviewed by Darin Adler.
This patch also tweaks the inline tree output (one line geometry output per line, different output format).
<div style="width: 100px;">first_line<wbr>second_line</div>
block box at (0,10) size 100x20
line at (0.00,0.00) size 100.00x10.00 baseline at (8.00)
line at (0.00,10.00) size 100.00x10.00 baseline at (8.00)
text run at (0.00,0.00) size 100.00x10.00 run(0, 10)
text run at (0.00,0.00) size 110.00x10.00 run(0, 11)
anonymous inline box (0x495583d20) length->(10) "first_line"
word break opportunity at (100,8) size 0x0 (0x4967c0680)
anonymous inline box (0x495591e00) length->(11) "second_line"
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutBox):
- 9:43 PM Changeset in webkit [267647] by
-
- 2952 edits in trunk/LayoutTests/imported/w3c
Remove trailing spaces from expected.txt files in web-platform-tests/[i-v]*
https://bugs.webkit.org/show_bug.cgi?id=217020
Reviewed by Zalan Bujtas.
This affects many files, and it's not helpful to fill the change log with a list of them.
- 8:34 PM Changeset in webkit [267646] by
-
- 4387 edits in trunk/LayoutTests/imported/w3c
Remove trailing spaces from expected.txt files in web-platform-tests/html
https://bugs.webkit.org/show_bug.cgi?id=217019
Reviewed by Zalan Bujtas.
This affects many files, and it's not helpful to fill the change log with a list of them.
- 7:48 PM Changeset in webkit [267645] by
-
- 14 edits in trunk
Remove support for setting CMYKA fill and stroke colors in 2D canvas
https://bugs.webkit.org/show_bug.cgi?id=217002
Reviewed by Darin Adler.
Source/WebCore:
Remove support for
setFillColor(c, m, y, k, a)andsetStrokeColor(c, m, y, k, a)on
CanvasRenderingContext2D, which was initially introduced in 2004 with <https://trac.webkit.org/r6730>.
Setting colors from CMYKA components is non-standard and unsupported in both Firefox and Chrome;
importantly, this is implemented inCanvasStyle::applyStrokeColorby calling directly into CoreGraphics
API using the platformCGContextRef, which is null when using the GPU Process; this subsequently causes
the web process to crash.
In lieu of adding new DisplayList items to support setting fill and stroke colors with CMYKA components,
we can take this opportunity to just drop support for this canvas API entirely. Fixes the following tests
when using the GPU Process to render canvas:
- fast/canvas/canvas-color-serialization.html
- fast/canvas/canvas-overloads-setFillColor.html
- fast/canvas/canvas-overloads-setStrokeColor.html
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/CanvasRenderingContext2DBase.cpp:
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::isEquivalentColor const):
(WebCore::CanvasStyle::applyStrokeColor const):
(WebCore::CanvasStyle::applyFillColor const):
- html/canvas/CanvasStyle.h:
(WebCore::CanvasStyle::color const):
LayoutTests:
Remove calls to
CanvasRenderingContext2D.setFillColor(c, m, y, k, a)and
CanvasRenderingContext2D.setStrokeColor(c, m, y, k, a)in these layout tests.
- fast/canvas/canvas-color-serialization-expected.txt:
- fast/canvas/canvas-color-serialization.html:
- fast/canvas/set-colors-expected.txt:
- fast/canvas/set-colors.html:
- inspector/canvas/recording-2d-full-expected.txt:
- inspector/canvas/resources/recording-2d.js:
- platform/ios/fast/canvas/set-colors-expected.txt:
- platform/mac/fast/canvas/set-colors-expected.txt:
- 7:15 PM Changeset in webkit [267644] by
-
- 3539 edits in trunk/LayoutTests
Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many)
https://bugs.webkit.org/show_bug.cgi?id=217016
Reviewed by Zalan Bujtas.
Done with this command:
find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/CONSOLE MESSAGE:/ { next }; /<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$g'
This affects many files, and it's not helpful to clog the change log with a list of them.
- 6:03 PM Changeset in webkit [267643] by
-
- 3 edits2 deletes in branches/safari-610-branch
Revert r266887. rdar://problem/69586659
- 6:03 PM Changeset in webkit [267642] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Revert r266899. rdar://problem/69586659
- 5:21 PM Changeset in webkit [267641] by
-
- 13 edits1 copy in trunk/Source/WebKitLegacy
[Preferences] Generate Debug and Internal preferences for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217015
Reviewed by Darin Adler.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj:
Adds generation of WebPreferencesInternalFeatures.mm from WebPreferencesInternalFeatures.mm.erb.
Source/WebKitLegacy/mac:
Imports WebPreferencesDebug.yaml and WebPreferencesInternal.yaml from WebKit and starts
generating them.
In addition, preference yaml files must now be sorted alphabetically by preference name, and
this is now enforced by GeneratePreferences.rb, generating an error if they are out of order.
- Scripts/GeneratePreferences.rb:
- Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
- Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: Added.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(+[WebPreferences _internalDebugFeatures]): Deleted.
- WebView/WebPreferencesDebug.yaml:
- WebView/WebPreferencesDefaultValues.h:
- WebView/WebPreferencesExperimental.yaml:
- WebView/WebPreferencesInternal.yaml:
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 4:23 PM Changeset in webkit [267640] by
-
- 11 edits in trunk/Tools
Change dumpAsText to strip trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=216944
Reviewed by Alan Bujtas.
- DumpRenderTree/mac/DumpRenderTree.mm:
(dumpFramesAsText): Strip trailing spaces.
- DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
Don't add trailing space.
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:addMessageToConsole:withSource:]): Ditto.
(addLeadingSpaceStripTrailingSpaces): Added.
(stripTrailingSpaces): Added.
(-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Don't add trailing space.
(-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:setStatusText:]): Ditto.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dumpFramesAsText): Strip trailing spaces.
- DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::willPerformClientRedirectToURL): Don't add trailing space.
- DumpRenderTree/win/UIDelegate.cpp:
(toMessage): Changed to return std::wstring.
(stripTrailingSpaces): Added.
(addLeadingSpaceStripTrailingSpaces): Added.
(UIDelegate::runJavaScriptAlertPanelWithMessage): Don't add trailing space.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.
(UIDelegate::setStatusText): Ditto.
- Scripts/webkitpy/port/base.py:
(Port.do_text_results_differ): Strip trailing spaces from expected text.
Plan is to remove this after stripping the actual expected.txt files.
- Scripts/webkitpy/port/win.py:
(WinPort.do_text_results_differ): Call through to base.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText): Strip trailing spaces.
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Don't add trailing space.
(WTR::InjectedBundlePage::decidePolicyForNavigationAction): Ditto.
(WTR::stripTrailingSpaces): Added.
(WTR::addLeadingSpaceStripTrailingSpaces): Added.
(WTR::InjectedBundlePage::willAddMessageToConsole): Don't add trailing space.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
- 3:13 PM Changeset in webkit [267639] by
-
- 24 edits2 adds2 deletes in trunk
Constructing an AudioNode for a closed context should not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=216994
Reviewed by Darin Adler.
Source/WebCore:
Constructing an AudioNode for a closed context should not throw an exception. This
behavior is not as per specification and does not match the behavior of Chrome &
Firefox either.
Test: webaudio/construct-node-with-closed-context.html
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::create):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::lazyInitialize):
(WebCore::BaseAudioContext::sampleRate const):
- Modules/webaudio/BaseAudioContext.h:
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::create):
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
- Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::create):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::create):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::create):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::create):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::create):
- Modules/webaudio/IIRFilterNode.cpp:
(WebCore::IIRFilterNode::create):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::create):
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::create):
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::create):
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::create):
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::create):
LayoutTests:
- http/wpt/webaudio/audiocontext-stopped-expected.txt: Removed.
- http/wpt/webaudio/audiocontext-stopped.html: Removed.
Drop outdated test. It is replaced with the new test I am introducing.
- webaudio/MediaStreamAudioDestination/create-in-destroyed-context-expected.txt:
Rebaseline Blink-imported test that is now passing.
- webaudio/construct-node-with-closed-context-expected.txt: Added.
- webaudio/construct-node-with-closed-context.html: Added.
Add layout test coverage.
- 3:07 PM Changeset in webkit [267638] by
-
- 3 edits in trunk/Source/WebCore
Drop AudioNode::lazyInitialize()
https://bugs.webkit.org/show_bug.cgi?id=217004
Reviewed by Darin Adler.
Drop AudioNode::lazyInitialize(), this is dead code.
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::lazyInitialize): Deleted.
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::isInitialized const):
- 2:31 PM Changeset in webkit [267637] by
-
- 7 edits2 adds in trunk
[LFC][IFC] Add support for <wbr>
https://bugs.webkit.org/show_bug.cgi?id=217014
Reviewed by Antti Koivisto.
Source/WebCore:
Introduce the WordBreakOpportunity type of InlineItem and take it into account while searching for word break opportunities.
It generates an empty line run but it does not yet have geometry information.
Test: fast/layoutformattingcontext/wbr-simple.html
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
- layout/inlineformatting/InlineItem.h:
(WebCore::Layout::InlineItem::isWordBreakOpportunity const):
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::appendWith):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendWordBreakOpportunity):
- layout/inlineformatting/InlineLine.h:
(WebCore::Layout::Line::Run::isWordBreakOpportunity const):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::nextWrapOpportunity):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::inlineItemWidth const):
(WebCore::Layout::LineBuilder::nextContentForLine):
LayoutTests:
- fast/layoutformattingcontext/wbr-simple-expected.html: Added.
- fast/layoutformattingcontext/wbr-simple.html: Added.
- 2:08 PM Changeset in webkit [267636] by
-
- 3 edits1 add in branches/safari-610-branch
Cherry-pick r267135. rdar://problem/69586651
JSImmutableButterfly::get needs to return jsDoubleNumber for double arrays
https://bugs.webkit.org/show_bug.cgi?id=216589
<rdar://problem/68061245>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/jsimmutablebutterfly-get-must-return-double-boxed-value.js: Added.
Source/JavaScriptCore:
We are using JSImmutableButterfly::get in AI to constant fold GetByVal,
but we were failing to always return a boxed double value for double loads.
We were calling jsNumber instead of jsDooubleNumber. This is in contrast to
the runtime, which always returns a double boxed value. This would lead AI
to disagree with the runtime, and miscompile code.
- runtime/JSImmutableButterfly.h: (JSC::JSImmutableButterfly::get const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267635] by
-
- 7 edits1 add in branches/safari-610-branch
Cherry-pick r267113. rdar://problem/69586723
CustomFunctionEquivalence PropertyCondition needs to check if the structure has the property
https://bugs.webkit.org/show_bug.cgi?id=216575
<rdar://problem/68286930>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/has-static-property-property-condition-needs-to-check-if-structure-has-property.js: Added. (foo):
Source/JavaScriptCore:
The CustomFunctionEquivalence PropertyCondition would only return false to
isStillValidAssumingImpurePropertyWatchpoint if the Structure's static
property table was reified or if the static property table did not contain the
property. However, this missed the obvious case of where we store to this
property in normal object storage without reifying the static property table.
The fix here is simple: we first check if the Structure's property table
has this property, and if so, return false.
This patch also renames CustomFunctionEquivalence to HasStaticProperty to
better capture what we're doing.
- bytecode/ObjectPropertyCondition.h: (JSC::ObjectPropertyCondition::hasStaticProperty): (JSC::ObjectPropertyCondition::customFunctionEquivalence): Deleted.
- bytecode/ObjectPropertyConditionSet.cpp: (JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition const): (JSC::ObjectPropertyConditionSet::slotBaseCondition const): (JSC::generateConditionsForPrototypePropertyHitCustom):
- bytecode/PropertyCondition.cpp: (JSC::PropertyCondition::dumpInContext const): (JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const): (JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const): (JSC::PropertyCondition::isStillValid const): (JSC::PropertyCondition::isWatchableWhenValid const): (WTF::printInternal):
- bytecode/PropertyCondition.h: (JSC::PropertyCondition::hasStaticProperty): (JSC::PropertyCondition::hash const): (JSC::PropertyCondition::operator== const): (JSC::PropertyCondition::customFunctionEquivalence): Deleted.
- tools/JSDollarVM.cpp: (JSC::functionCreateStaticCustomValue): (JSC::JSDollarVM::finishCreation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267634] by
-
- 5 edits3 adds in branches/safari-610-branch
Cherry-pick r267067. rdar://problem/69586680
REGRESSION (Async overflow scroll): Code snippets on getkirby.com appear and disappear as content is scrolled
https://bugs.webkit.org/show_bug.cgi?id=216490
<rdar://problem/67018073>
Reviewed by Zalan Bujtas.
Source/WebCore:
The content in question had a z-order layer tree like this:
A (0,0) width=997 height=829 (layerID 20) {sc 2} RenderView
+ B (0,0) width=997 height=8 RenderBlock HTML class='no-js'
+ C (0,0) width=997 height=829 RenderFlexibleBox MAIN
n D (0,0) width=256 height=829 RenderFlexibleBox NAV class='left panel'
n E (0,0) width=256 height=829 (layerID 25) {sc 3} RenderBlock DIV class='scroller'
n F (256,0) width=741 height=829 RenderFlexibleBox ARTICLE class='main panel'
n G (0,0) width=741 height=829 (layerID 26) {sc 4} RenderBlock DIV class='scroller'
n H (0,-816) width=741 height=2810 RenderBlock DIV class='article-content'
+ I (0,0) width=256 height=1000 (layerID 27) overlap RenderBlock (relative positioned) DIV class='content'
+ J (10,300) width=721 height=202 (layerID 28) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ K (10,802) width=721 height=202 (layerID 29) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ L (10,1304) width=721 height=202 (layerID 30) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,1806) width=721 height=202 (layerID 31) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,2308) width=721 height=202 (layerID 32) overlap RenderBlock (relative positioned) DIV class='relative-box'
When layer 'G' is scrolled, the code would find the paint-order parent, F, which is normal-flow because it has overflow:hidden,
and would call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it. However, that doesn't go high enough, because
we need to update J-M since their ancestor clipping stacks have geometry that relies on the scroll position of G. If we don't
update that geometry, GraphicsLayers have an incorrect notion of what's visible, and we don't attach backing store.
The fix is to climb up to the stacking context B and call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it.
Test: compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollTo):
LayoutTests:
- compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267633] by
-
- 8 edits2 adds in branches/safari-610-branch
Cherry-pick r266923. rdar://problem/69586712
REGRESSION (Async overflow scroll): Mouse wheel scrolling over an "always-on" overflow scrollbar doesn't work
https://bugs.webkit.org/show_bug.cgi?id=216381
<rdar://problem/68593743>
Reviewed by Antti Koivisto.
Source/WebCore:
The scrollbar and scroll corner layers need event regions and scrollingNodeIDs so that
we hit-test them via CA layers and find the right scrolling node.
Test: fast/scrolling/mac/mousewheel-over-scrollbar.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterDescendants): (WebCore::RenderLayerBacking::updateEventRegion): (WebCore::RenderLayerBacking::detachFromScrollingCoordinator): (WebCore::RenderLayerBacking::setScrollingNodeIDForRole):
LayoutTests:
- fast/scrolling/mac/border-radius-event-region-expected.txt:
- fast/scrolling/mac/event-region-scrolled-contents-layer-expected.txt:
- fast/scrolling/mac/event-region-subscroller-overflow-expected.txt:
- fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
- fast/scrolling/mac/mousewheel-over-scrollbar-expected.txt: Added.
- fast/scrolling/mac/mousewheel-over-scrollbar.html: Added.
- fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267632] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266899. rdar://problem/69586659
Address a post-commit review comment after r266887
https://bugs.webkit.org/show_bug.cgi?id=216257
Reviewed by Darin Adler.
Remove a check that currently makes us conditionally set
IsComputedStyleInvalidFlagif there is a computed
style in rare data. There should be no change in behavior; this just makes the code a bit simpler.
- dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::storeDisplayContentsStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267631] by
-
- 4 edits2 adds in branches/safari-610-branch
Cherry-pick r266887. rdar://problem/69586659
REGRESSION (r257839): clickpay.com - password placeholder text cannot be replaced
https://bugs.webkit.org/show_bug.cgi?id=216257
<rdar://problem/68150686>
Reviewed by Antti Koivisto.
Source/WebCore:
On clickpay.com, the field in the login form that contains the text "Password" is actually a plain text input,
referred to by the site's script as the "null text input". The page adds a focus event listener to this null
text input, and inside of this focus event listener, it reveals a hidden password field by removing an inline
display: none;style rule on the real password input element, programmatically focuses it, and then hides the
null text input by setting it todisplay: none;via inline style.
However, after the changes in r257839, we no longer attempt to do a style update upon programmatic focus in the
case where the programmatically focused element does not have a renderer yet (this applies to the password field
in this scenario, because it previously haddisplay: none;). When we determine whether the newly displayed
password field is focusable usingElement::isVisibleWithoutResolvingFullStyle, we then attempt to use either
the existing computedRenderStyleon the element, or perform a partial computed style resolution using the
ResolveComputedStyleMode::RenderedOnlyflag.
But in the case where
ElementRareData's computed style exists, it is not guaranteed to be up to date if the
inline style changed since the computed style was last set. In the context of this bug, it's actually Safari's
AutoFill logic (embedded in the injected bundle) that ends up asking for the computed style of the password
input, forcing it to be created and set (though, as demonstrated in the layout test, simply grabbing the
computed style is sufficient to replicate the bug outside of Safari).
The end result is that we'll use this stale computed style, which still believes that the password input is not
displayed, and we end up not focusing the element due to believing that the password input is hidden. To fix
this, we would need to either check whether the element has an invalid style (i.e.needsStyleRecalc()) before
attempting to use the existing computed style, or clear out theElementRareDatacomputed style anytime the
element's style is invalidated. However, both of these approaches will cause us to perform partial style
resolution much more aggressively, leading to a 2-3% regression in Speedometer.
To address the bug without hampering our performance wins from r257839, we add a new node flag so that we can
remember when computed styles are no longer valid due to style invalidation, and consult this flag in
Element::isVisibleWithoutResolvingFullStyleto avoid using the existing computed style.
Test: fast/forms/programmatic-focus-after-display.html
- dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::resolveComputedStyle): (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
- dom/Node.h: (WebCore::Node::setHasValidStyle):
LayoutTests:
Add a new layout test to verify that the bug does not occur. See WebCore/ChangeLog for more details.
- fast/forms/programmatic-focus-after-display-expected.txt: Added.
- fast/forms/programmatic-focus-after-display.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267630] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266884. rdar://problem/69583178
Revert accidental hard-coding of compositing logging from r266825.
- platform/Logging.cpp: (WebCore::initializeLogChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267629] by
-
- 25 edits1 copy10 adds in branches/safari-610-branch
Cherry-pick r266825. rdar://problem/69583178
REGRESSION (Async overflow scroll): Truncated scrollbars in facebook chat
https://bugs.webkit.org/show_bug.cgi?id=216294
<rdar://problem/61918702>
Reviewed by Antti Koivisto.
Source/WebCore:
When both async overflow scroll and overlay scrollbars are enabled, it's possible for
composited layers that are later in z-order than the overflow to overlap the scrollbars
(overflow does not create stacking context, so they are later siblings to the overflow).
To fix this we have to hoist the layer that hosts the overflow controls above all later layers
which belong to contents scrolled by this overflow. We know which layers these are; they have
ancestor clippings stacks that reference the overflow layer.
This overflow controls layer hoisting happens in the context of the enclosing composited layer.
So to fix this RenderLayerCompositor::updateBackingAndHierarchy() tracks these layers that belong to
an overflow scroll. RenderLayerCompositor::adjustOverflowScrollbarContainerLayers() uses them to find
the overflow scroll layers whose controls need hoisting, and where to insert those overflow controls
hosting layers in the sublayers list of the enclosing composited layer.
An additional source of complexity occurs with overflow scroll nested inside another scroller or
overflow:hidden (in the same composited stacking context): the overflow controls reparenting is hoisting
that layer up, so that layer itself needs additional layers to clip it (essentially the overflow control
layer behaves like a later sibling that needs its own ancestor clipping stack). When this occurs,
RenderLayerBacking creates an additional "ancestor clipping stack" in m_overflowControlsHostLayerAncestorClippingStack
which is a parallel stack to m_ancestorClippingStack, but with its own set of clipping layers. At some point
this will also need scrolling tree nodes created for it. Some minor refactoring helps share code for
the two LayerAncestorClippingStacks.
This new code all runs late in the compositing update for a given layer, which is not ideal; we replicate
some code from updateGeometry() and updateInternalHierarchy(). Ideally we'd be able to know at
computeCompositingRequirements() time if we need to do layer hoisting and ancestor clipping stack duplication,
but that proves hard because of ordering dependencies.
Tests: compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html
compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html
- rendering/LayerAncestorClippingStack.cpp: (WebCore::LayerAncestorClippingStack::compositedClipData const):
- rendering/LayerAncestorClippingStack.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::RenderLayerBacking::updateGeometry): (WebCore::RenderLayerBacking::adjustOverflowControlsPositionRelativeToAncestor): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateAncestorClippingStack): (WebCore::RenderLayerBacking::ensureOverflowControlsHostLayerAncestorClippingStack): (WebCore::RenderLayerBacking::ensureClippingStackLayers): (WebCore::RenderLayerBacking::removeClippingStackLayers): (WebCore::RenderLayerBacking::connectClippingStackLayers): (WebCore::RenderLayerBacking::updateClippingStackLayerGeometry): (WebCore::RenderLayerBacking::updateAncestorClipping): (WebCore::RenderLayerBacking::offsetRelativeToRendererOriginForDescendantLayers const):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::UpdateBackingTraversalState::UpdateBackingTraversalState): (WebCore::RenderLayerCompositor::UpdateBackingTraversalState::stateForDescendants const): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy): (WebCore::RenderLayerCompositor::adjustOverflowScrollbarContainerLayers): (WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Some new tests, and new baselines for tests that have different layer trees now.
- compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
- compositing/layer-creation/clipping-scope/overlap-constrained-inside-scroller-expected.txt:
- compositing/layer-creation/clipping-scope/scroller-with-negative-z-children-expected.txt:
- compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
- compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
- compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-clipped-by-scroll-expected.txt:
- compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-expected.txt:
- compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-nested-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-for-negative-z-in-scroller-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-hidden-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-visible-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-gain-clipping-layer-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-in-clipped-expected.txt:
- compositing/scrolling/async-overflow-scrolling/layer-in-overflow-lose-clipping-layer-expected.txt:
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html: Added.
- compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html: Added.
- compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position-expected.txt: Added.
- compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html: Added.
- compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt:
- compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267628] by
-
- 16 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r266804. rdar://problem/69583164
macCatalyst: Form controls behave strangely (like iPhone) in macOS-idiom apps
https://bugs.webkit.org/show_bug.cgi?id=216326
Reviewed by Wenson Hsieh.
- Shared/UserInterfaceIdiom.h:
- Shared/UserInterfaceIdiom.mm: (WebKit::userInterfaceIdiomIsPad): (WebKit::currentUserInterfaceIdiomIsPadOrMac): (WebKit::setCurrentUserInterfaceIdiomIsPadOrMac): (WebKit::currentUserInterfaceIdiomIsPad): Deleted. (WebKit::setCurrentUserInterfaceIdiomIsPad): Deleted.
- Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::defaultTextAutosizingUsesIdempotentMode):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/ios/SmartMagnificationController.mm: (WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): (-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]): (-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]): (-[WKContentView _zoomToRevealFocusedElement]): (-[WKContentView requiresAccessoryView]): (-[WKContentView _updateAccessory]): (shouldShowKeyboardForElement): (-[WKContentView _shouldUseLegacySelectPopoverDismissalBehavior]):
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (WebKit::WebDataListSuggestionsDropdownIOS::show):
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::desktopClassBrowsingSupported):
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm: (-[WKAirPlayRoutePicker show:fromRect:]):
- UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _showPhotoPickerWithSourceType:]): (-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
- UIProcess/ios/forms/WKFormColorControl.mm: (-[WKFormColorControl initWithView:]):
- UIProcess/ios/forms/WKFormColorPicker.mm: (-[WKColorPicker initWithView:inPopover:]): (-[WKColorPicker drawSelectionIndicatorForColorButton:]):
- UIProcess/ios/forms/WKFormSelectControl.mm: (-[WKFormSelectControl initWithView:]):
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Rename currentUserInterfaceIdiomIsPad to currentUserInterfaceIdiomIsPadOrMac, and force it to YES on macCatalyst since internally we use it to distinguish between iPhone and iPad behavior, and (for our behaviors, at least) macCatalyst should always follow iPad.
We should clean this up, and make all callers make their
iPhone vs. iPad vs. macOS decisions more explicit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267627] by
-
- 6 edits in branches/safari-610-branch
Cherry-pick r266798. rdar://problem/69583118
Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and https://bugs.webkit.org/show_bug.cgi?id=216317
Reviewed by Geoffrey Garen.
Source/WebKit:
Covered by new API test.
When WebsiteDataStores are gathering all the NetworkProcesses they might need to message, they miss some
obvious candidates if there are no longer any related WKWebViews.
Fix that by tracking which sessions a NetworkProcess knows about.
- UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::addSession): (WebKit::NetworkProcessProxy::hasSession const): (WebKit::NetworkProcessProxy::removeSession):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::isAssociatedProcessPool const):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [267626] by
-
- 5 edits3 adds in branches/safari-610-branch
Cherry-pick r266148. rdar://problem/69583151
Font loads quickly followed by navigations may fail indefinitely
<rdar://problem/65560550> and https://bugs.webkit.org/show_bug.cgi?id=215435
Reviewed by Myles C. Maxfield.
Source/WebCore:
Second take at this.
Myles took the first swipe at this, but a conflict with SuspendableTimer caused issues
in the form of layout test asserts with
http/tests/security/navigate-when-restoring-cached-page.html
His original ChangeLog entry:
Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.
This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:
- The second page in the above story will not see that the font has failed, or even started, and will then re-request the font and load it successfully
- If the user goes "back" to the previous page, the zero-delay timer is restarted, the CachedFont realizes it's already succeeded, and the previous page is rendered as expected.
Test: fast/loader/font-load-timer.html
---
Now the explanation of the failure it caused:
The font loading timer was a SuspendableTimer, which is an ActiveDOMObject.
An ActiveDOMObject was used to make sure the delayed font loads play well with the
page cache, which is still necessary.
But we also still need to suspend the timer manually when "stopLoading()" is called,
which doesn't play well with ActiveDOMObject's automatic suspend/resume.
My solution:
- Make the timer "just a normal timer"
- Make CSSFontSelector itself the ActiveDOMObject
- Let DocumentLoader explicitly pause the font load timer
- Rely on ActiveDOMObject to resume the timer
These keep the bug fixed and resolve the layout test ASSERT seen with
http/tests/security/navigate-when-restoring-cached-page.html
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::clearDocument): (WebCore::CSSFontSelector::beginLoadingFontSoon): (WebCore::CSSFontSelector::suspendFontLoadingTimer): (WebCore::CSSFontSelector::fontLoadingTimerFired): (WebCore::CSSFontSelector::stop): (WebCore::CSSFontSelector::suspend): (WebCore::CSSFontSelector::resume): (WebCore::CSSFontSelector::beginLoadTimerFired): Deleted.
- css/CSSFontSelector.h:
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
LayoutTests:
1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.
- fast/loader/font-load-timer-expected.html: Added.
- fast/loader/font-load-timer.html: Added.
- fast/loader/resources/font-load-timer-navigation-destination.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:45 PM Changeset in webkit [267625] by
-
- 3 edits in trunk/Source/WebCore
Fix Big Sur clean build after r267613
https://bugs.webkit.org/show_bug.cgi?id=217003
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- 1:43 PM WebKitGTK/2.30.x edited by
- (diff)
- 12:52 PM Changeset in webkit [267624] by
-
- 9 edits in trunk/Source/JavaScriptCore
Unreviewed, follow-up after r267373 to resolve post-commit review comments
https://bugs.webkit.org/show_bug.cgi?id=216667
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):
- runtime/HashMapImpl.h:
(JSC::jsMapHash):
- 9:34 AM Changeset in webkit [267623] by
-
- 9 edits in trunk/Source/WebKitLegacy
[Preferences] It should be possible to have different default values for WebKitLegacy and WebKit in preference yaml files
https://bugs.webkit.org/show_bug.cgi?id=216987
Reviewed by Darin Adler.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj:
Update script phase to explicitly specify the frontend (WebKitLegacy) and the templates to generate.
Source/WebKitLegacy/mac:
Add new syntax for default values that allows specializing based on both frontend (WebKit or
WebKitLegacy) and then futher based on platform macros. For example, the preference for
CSSTypedOMEnabled now looks like:
CSSTypedOMEnabled:
type: bool
humanReadableName: "CSS Typed OM"
humanReadableDescription: "Enable the CSS Typed OM"
webcoreBinding: RuntimeEnabledFeatures
condition: ENABLE(CSS_TYPED_OM)
defaultValue:
WebKitLegacy:
default: false
WebKit:
"ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) PLATFORM(WPE))": true default: false
Which means that in WebKitLegacy, the default value is false, and in WebKit, the default
value will be:
#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) PLATFORM(WPE)) true
#else
false
#endif
As many platform macro based conditions can be provided as wanted, and they are evaluated
in the order specified in the file.
The syntax currently always requires explicitly specifying WebKitLegacy and WebKit and default
for each, even if they are all the same, but could be extended in the future to allow compaction
if that becomes desirable. There is also not yet support for conditionally enabling a feature
based on os-feature-flags or linked-on-or-after checks, so those still require specifying the
default value as a function, but that seems like a nice future improvement.
As this is still staging for doing this for both WebKitLegacy and WebKit, this change only effects
WebKitLegacy for now, and subsequent changes will move this to a shared location.
- Scripts/GeneratePreferences.rb:
- Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
- Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb:
- WebView/WebPreferencesExperimental.yaml:
- 7:14 AM Changeset in webkit [267622] by
-
- 3 edits2 adds in trunk
[LFC][IFC] Line content logical width expands with run expansions (text-align: justify)
https://bugs.webkit.org/show_bug.cgi?id=217011
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/run-expansion-extends-line-content-width.html
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::applyRunExpansion):
LayoutTests:
- fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html: Added.
- fast/layoutformattingcontext/run-expansion-extends-line-content-width.html: Added.
- 6:52 AM Changeset in webkit [267621] by
-
- 4 edits in trunk/Source
[SOUP] Do not set site for cookies twice in case of redirection
https://bugs.webkit.org/show_bug.cgi?id=217010
Reviewed by Michael Catanzaro.
Source/WebCore:
Only set is-toplevel-navigation on SoupMessage when same site info is present.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageMembers const):
Source/WebKit:
ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in
NetworkDataTaskSoup::continueHTTPRedirection().
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Do not set same site information here, it will be done
again in NetworkDataTaskSoup::createRequest().
- 6:51 AM Changeset in webkit [267620] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
https://bugs.webkit.org/show_bug.cgi?id=149551
Reviewed by Michael Catanzaro.
The problem is that we are not including all the cookies in the web socket request. There are two cookies with
the Lax same-site policy set, that are not included for the websocket request.
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.
Sep 25, 2020:
- 11:48 PM Changeset in webkit [267619] by
-
- 3 edits in trunk/Source/WebKit
Add -[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:] to provide a way to allow app link
https://bugs.webkit.org/show_bug.cgi?id=216977
Patch by Hoa Dinh <dvh@apple.com> on 2020-09-25
Reviewed by Alex Christensen.
The method -[WKWebView _loadRequest:shouldOpenExternalURLs:] would only allow opening external or not.
It wasn't providing the ability to allow external URL but not app links.
This patch adds -[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:]. The parameters value for
shouldOpenExternalURLsPolicy has the same meaning than WebCore::ShouldOpenExternalURLsPolicy.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Added enum _WKShouldOpenExternalURLsPolicy,
- 11:39 PM Changeset in webkit [267618] by
-
- 87 edits in trunk
Unreviewed, reverting r267608.
Caused API test failures
Reverted changeset:
"Move NetworkProcessProxy ownership from WebProcessPool to
WebsiteDataStore"
https://bugs.webkit.org/show_bug.cgi?id=216041
https://trac.webkit.org/changeset/267608
- 10:21 PM Changeset in webkit [267617] by
-
- 4 edits2 adds in trunk
[LFC][IFC] Incorrect breaking position when inline box content fits the line but the inline content itself does not.
https://bugs.webkit.org/show_bug.cgi?id=217007
Reviewed by Simon Fraser.
Source/WebCore:
When the inline box does not fit the line but its text content does, the last breaking opportunity (in case of arbitrary breaking position)
is not the end of the text.
e.g
<div style="width: 200px; word-break: break-word;"><span style="border-right: 100px;">text_content_fits</span></div>
in this case the border right overflows the containing block and should be wrapped to the next available vertical position.
However the last breaking opportunity is not between 's' and the </span> but between 't' and 's'.
Test: fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): [container start](<span>) and [container end](</span>) runs are not collapsible.
LayoutTests:
- fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not-expected.html: Added.
- fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html: Added.
- 7:44 PM Changeset in webkit [267616] by
-
- 11 edits in trunk
[GPU Process] fast/canvas/canvas-composite-canvas.html and fast/canvas/canvas-composite-image.html fail
https://bugs.webkit.org/show_bug.cgi?id=216982
Reviewed by Simon Fraser.
Source/WebCore:
When painting into display-list-backed image buffers with remote
IOSurface-backed image buffers in the GPU
process, the display-list-backed image buffer has an initial CTM of the identity matrix, while theIOSurface-
backed image buffer's initial CTM is flipped about the x-axis. This is because image buffer backends based on
CoreGraphics always flip their context about the x-axis upon creation, inImageBufferCGBackend::setupContext().
This causes the CTM of the DisplayList context in the web process to fall out of sync with the CTM of the
platform context in the GPU process, so any canvas rendering codepaths that attempt to consult the current CTM
in the web process (e.g.CanvasRenderingContext2DBase::fullCanvasCompositedDrawImage) will get an incorrect
value.
To fix this, we give the display-list-backed image buffer in the web process an initial CTM that matches the CTM
of the native image buffer in the GPU process; see below for more details.
Tests: fast/canvas/canvas-composite-canvas.html and fast/canvas/canvas-composite-image.html
- platform/graphics/ImageBufferBackend.h:
- platform/graphics/cg/ImageBufferCGBitmapBackend.h:
Add a flag indicating whether the origin (0, 0) is intended to be at the top left corner of the image, in which
case we set up the image buffer's graphics context by flipping it vertically about the x-axis. This is true on
CoreGraphics-backed image buffers.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
- platform/graphics/displaylists/DisplayListDrawingContext.cpp:
(WebCore::DisplayList::DrawingContext::DrawingContext):
- platform/graphics/displaylists/DisplayListDrawingContext.h:
(WebCore::DisplayList::DrawingContext::DrawingContext):
Add an additional argument to the constructor of
DrawingContext, so that it now takes an initial affine CTM.
By default, this is the identity matrix.
- platform/graphics/displaylists/DisplayListImageBuffer.h:
(WebCore::DisplayList::ImageBuffer::ImageBuffer):
(WebCore::DisplayList::ImageBuffer::initialDrawingContextCTM):
Add a helper to compute the initial CTM of the drawing context. This was previously only the identity matrix,
but if we're using an image buffer backend that will flip the context vertically, then we need to start the
CTM of the display-list-backed image buffer in the same state.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::Recorder):
Rename the
baseCTMargument toinitialCTM. This is because this argument determines the CTM of the initial
graphics context state in the state stack, rather than the value of the base CTM. See above for more details.
- platform/graphics/transforms/AffineTransform.h:
LayoutTests:
Rebaseline this display list test to account for the fact that display list extent rects are in the global
coordinate space, and are therefore vertically flipped since the initial CTM flips everything about the x-axis.
- displaylists/canvas-display-list-expected.txt:
- 6:42 PM Changeset in webkit [267615] by
-
- 11 edits2 adds in trunk/Source/WebCore
Move SerializationState from ImageBuffer to ImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=216565
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-25
Reviewed by Kenneth Russell.
Introduce ImageBitmapBacking and make it a member of ImageBitmap. It
represents the backing store of an ImageBitmap. Currently it encapsulates
an ImageBuffer and the new enum SerializationState. In the future, it can
be extended to encapsulate either a texture or an ImageBuffer.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTransferredImageBitmap):
(WebCore::CloneDeserializer::readImageBitmap):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::computeMemoryCost const):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h:
(WebCore::SerializedScriptValue::SerializedScriptValue):
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::create):
(WebCore::ImageBitmap::detachBitmaps):
(WebCore::ImageBitmap::resolveWithBlankImageBuffer):
(WebCore::ImageBitmap::createPromise):
(WebCore::ImageBitmap::createFromBuffer):
(WebCore::ImageBitmap::ImageBitmap):
(WebCore::ImageBitmap::takeImageBitmapBacking):
(WebCore::ImageBitmap::takeImageBuffer):
(WebCore::ImageBitmap::width const): Deleted.
(WebCore::ImageBitmap::height const): Deleted.
(WebCore::ImageBitmap::close): Deleted.
(WebCore::ImageBitmap::transferOwnershipAndClose): Deleted.
- html/ImageBitmap.h:
- html/ImageBitmapBacking.cpp: Added.
(WebCore::ImageBitmapBacking::ImageBitmapBacking):
(WebCore::ImageBitmapBacking::buffer const):
(WebCore::ImageBitmapBacking::takeImageBuffer):
(WebCore::ImageBitmapBacking::width const):
(WebCore::ImageBitmapBacking::height const):
- html/ImageBitmapBacking.h: Added.
(WebCore::ImageBitmapBacking::originClean const):
(WebCore::ImageBitmapBacking::premultiplyAlpha const):
(WebCore::ImageBitmapBacking::forciblyPremultiplyAlpha const):
(WebCore::ImageBitmapBacking::serializationState const):
- html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::transferToImageBitmap):
- html/canvas/ImageBitmapRenderingContext.cpp:
(WebCore::ImageBitmapRenderingContext::setOutputBitmap):
- platform/graphics/ImageBuffer.h:
(): Deleted.
- 5:50 PM Changeset in webkit [267614] by
-
- 9 edits32 adds in trunk
visibilitychange:hidden doesn't fire during page navigations
https://bugs.webkit.org/show_bug.cgi?id=151234
<rdar://problem/23688763>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Import page-visibility WPT tests from upstream.
- resources/import-expectations.json:
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt:
- web-platform-tests/page-visibility/*: Added.
Source/WebCore:
Fire a visibilitychange during document unload, as per the specification:
- https://www.w3.org/TR/page-visibility/#reacting-to-visibilitychange-changes
- https://html.spec.whatwg.org/multipage/browsing-the-web.html#unloading-document-visibility-change-steps
Note that the specification currently says to fire the visibilitychange event before the pagehide event.
However, Both Chrome and Firefox fire the pagehide event then the visibilitychange event. This change
aligns our behavior with both Chrome and Firefox. The following bug has been filed against the
specification:
We also fire a visibilitychange event when coming out of the back/forward cache. This makes sense given
that we fire one when the document enters the back/forward cache. This is also Firefox's behavior.
I have verified that the new fast/history/back-forward-cache-visibility-state.html layout test is passing
in Firefox.
Tests: fast/history/back-forward-cache-visibility-state.html
imported/w3c/web-platform-tests/page-visibility/idlharness.window.html
imported/w3c/web-platform-tests/page-visibility/iframe-unload.html
imported/w3c/web-platform-tests/page-visibility/onvisibilitychange.html
imported/w3c/web-platform-tests/page-visibility/test_attributes_exist.html
imported/w3c/web-platform-tests/page-visibility/test_child_document.html
imported/w3c/web-platform-tests/page-visibility/test_default_view.html
imported/w3c/web-platform-tests/page-visibility/test_read_only.html
imported/w3c/web-platform-tests/page-visibility/unload-bubbles.html
imported/w3c/web-platform-tests/page-visibility/unload.html
- dom/Document.cpp:
(WebCore::Document::visibilityState const):
(WebCore::Document::setHiddenDueToDismissal):
- dom/Document.h:
- history/CachedPage.cpp:
(WebCore::firePageShowAndPopStateEvents):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
LayoutTests:
Add test coverage for the visibilitychange event and document.visibilitystate when entering
and coming out of the back/forward cache.
- fast/history/back-forward-cache-visibility-state-expected.txt: Added.
- fast/history/back-forward-cache-visibility-state.html: Added.
- 5:41 PM Changeset in webkit [267613] by
-
- 11 edits6 adds in trunk
Support OES_fbo_render_mipmap
https://bugs.webkit.org/show_bug.cgi?id=217003
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webgl/conformance/extensions/oes-fbo-render-mipmap.html
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- html/canvas/OESFBORenderMipmap.cpp: Added.
(WebCore::OESFBORenderMipmap::OESFBORenderMipmap):
(WebCore::OESFBORenderMipmap::getName const):
(WebCore::OESFBORenderMipmap::supported):
- html/canvas/OESFBORenderMipmap.h: Added.
- html/canvas/OESFBORenderMipmap.idl: Added.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::framebufferTexture2D):
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
- webgl/conformance/extensions/oes-fbo-render-mipmap-expected.txt: Added.
- webgl/conformance/extensions/oes-fbo-render-mipmap.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-fbo-render-mipmap.html: Added.
- 5:27 PM Changeset in webkit [267612] by
-
- 5 edits in trunk/Source
Crunchyroll playback controls do not work on iPad with trackpad
https://bugs.webkit.org/show_bug.cgi?id=217000
<rdar://problem/66362029>
Reviewed by Wenson Hsieh.
Source/WebCore:
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isCrunchyroll):
Source/WebKit:
- UIProcess/ios/WKContentViewInteraction.mm:
(applicationIsKnownToIgnoreMouseEvents):
Add it to the list.
- 5:14 PM Changeset in webkit [267611] by
-
- 8 edits in trunk/Source/WebCore
Make renderingUpdateScheduler() internal to Page
https://bugs.webkit.org/show_bug.cgi?id=216993
Reviewed by Said Abou-Hallawa.
renderingUpdateScheduler() should be an implementation detail of Page.
Also add some explanatory comments.
- dom/Document.cpp:
(WebCore::Document::scheduleTimedRenderingUpdate):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::scheduleAnimation):
- page/Page.cpp:
(WebCore::Page::scheduleImmediateRenderingUpdate):
- page/Page.h:
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::didChangeViewExposedRect):
(WebCore::PageOverlayController::notifyFlushRequired):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
- 5:09 PM Changeset in webkit [267610] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, update xcfilelist files.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- 5:01 PM Changeset in webkit [267609] by
-
- 22 edits in trunk/Source/WebCore
Avoid having to call context.lazyInitialize() in every AudioNode factory function
https://bugs.webkit.org/show_bug.cgi?id=216989
Reviewed by Darin Adler.
Avoid having to call context.lazyInitialize() in every AudioNode factory function.
Replace all these calls with a single one inside the AudioNode constructor.
No new tests, no Web facing behavior change.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::create):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::lazyInitialize):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::create):
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
- Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::create):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::create):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::create):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::create):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::create):
- Modules/webaudio/IIRFilterNode.cpp:
(WebCore::IIRFilterNode::create):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::create):
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::create):
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::create):
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::create):
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::create):
- 4:53 PM Changeset in webkit [267608] by
-
- 87 edits in trunk
Move NetworkProcessProxy ownership from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216041
Reviewed by Brady Eidson.
Source/WebKit:
This patch moves the things on WebProcessPool associated with NetworkProcessProxy ownership and moves them
to WebsiteDataStore. It's pretty mechanical, but it reaches its fingers into a lot of things. Some comments
on interesting parts are below.
Why am I doing this? I'm glad you asked.
WKWebView had a fundamental cookie problem before this change. It had a WKWebsiteDataStore that could point to a cookie store on disk
that could be used in multiple network processes at the same time. This led to problems with cookies being received over the network
in those different processes being unable to be shared until they were written to disk, something that does not happen immediately, especially
on iOS. This problem is even worse with session cookies, which should be kept in memory and never be written to disk. Those processes
did not use shared memory to share the cookies. They just didn't share them, which led to cookie incorrectness. This was unfortunately
the default configuration if you call [[WKWebView alloc] init] more than once, which many developers do. There was also occasional cookie
corruption and loss from multiple processes writing cookies to the same file. All these problems can be worked around by doing what Safari does:
manually setting the WKProcessPool of all WKWebViewConfigurations to the same process pool to only use one network process. This is not intuitive
or well documented, and even though I have spent the majority of WWDC labs for the last 3 years telling developers to do it, most developers do not.
The default behavior should not lead to cookie incorrectness, corruption, or loss. This accomplishes that.
A bigger problem that can't really be worked around well is what we were doing in our WKHTTPCookieStore API. Many developers call setCookie:completionHandler:
to "log in" the user by setting a cookie, then in the completion handler, they open a WKWebView to their page and expect the cookie to be sent. Before this
change, we would not know which process pool to set the cookie in so we would guess. If there were no process pools, we would start writing to disk and hope
it writes fast enough. We can't wait for it to complete because it causes hangs like rdar://problem/66961066. This solution allows to start the network
process of that WebsiteDataStore and set the cookie in that process. We now know that is the only process this WebsiteDataStore will ever use. Now, users
will be able to actually be logged in all the time in such apps.
- NetworkProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
- NetworkProcess/Cookies/WebCookieManager.h:
- NetworkProcess/Cookies/WebCookieManager.messages.in:
- NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
- NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
- NetworkProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensureSession):
(WebKit::NetworkProcess::storageSession const):
(WebKit::NetworkProcess::forEachNetworkStorageSession):
(WebKit::NetworkProcess::defaultStorageSession const): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/WebStorage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::close):
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::saveCookies):
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.
- NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.
- Platform/IPC/Attachment.h:
- Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
- Shared/WebsiteDataStoreParameters.h:
- UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::cookiesForURL):
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::deleteAllCookies):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications): Deleted.
(API::HTTPCookieStore::unregisterForNewProcessPoolNotifications): Deleted.
- UIProcess/API/APIHTTPCookieStore.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetUseSeparateServiceWorkerProcess):
(WKContextSetPrimaryWebsiteDataStore):
(WKContextGetCookieManager): Deleted.
(WKContextSetAllowsAnySSLCertificateForServiceWorkerTesting): Deleted.
(WKContextTerminateNetworkProcess): Deleted.
(WKContextGetNetworkProcessIdentifier): Deleted.
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageGetWebsiteDataStore):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreTerminateNetworkProcess):
(WKWebsiteDataStoreGetNetworkProcessIdentifier):
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setUseSeparateServiceWorkerProcess:]):
(-[WKProcessPool _terminateNetworkProcess]): Deleted.
(-[WKProcessPool _sendNetworkProcessWillSuspendImminently]): Deleted.
(-[WKProcessPool _sendNetworkProcessPrepareToSuspend:]): Deleted.
(-[WKProcessPool _sendNetworkProcessDidResume]): Deleted.
(-[WKProcessPool _networkProcessIdentifier]): Deleted.
(-[WKProcessPool _makeNextNetworkProcessLaunchFailForTesting]): Deleted.
(-[WKProcessPool _synthesizeAppIsBackground:]): Deleted.
(-[WKProcessPool _setAllowsAnySSLCertificateForServiceWorker:]): Deleted.
(-[WKProcessPool _networkProcessHasEntitlementForTesting:]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _networkProcessHasEntitlementForTesting:]):
(-[WKWebsiteDataStore _terminateNetworkProcess]):
(-[WKWebsiteDataStore _sendNetworkProcessPrepareToSuspend:]):
(-[WKWebsiteDataStore _sendNetworkProcessWillSuspendImminently]):
(-[WKWebsiteDataStore _sendNetworkProcessDidResume]):
(-[WKWebsiteDataStore _synthesizeAppIsBackground:]):
(-[WKWebsiteDataStore _networkProcessIdentifier]):
(+[WKWebsiteDataStore _makeNextNetworkProcessLaunchFailForTesting]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/API/glib/WebKitCookieManager.cpp:
(_WebKitCookieManagerPrivate::cookieManager const):
(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_add_cookie):
(webkit_cookie_manager_get_cookies):
(webkit_cookie_manager_delete_cookie):
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):
- UIProcess/AuxiliaryProcessProxy.h:
- UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::updateProcessSuppressionState):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting): Deleted.
(WebKit::WebProcessPool::xpcEndpointMessage const): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessXPCEndpointToWebProcess): Deleted.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::cancel):
(WebKit::DownloadProxy::publishProgress):
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::applicationDidEnterBackground):
(WebKit::DownloadProxyMap::applicationWillEnterForeground):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::invalidate):
- UIProcess/Downloads/DownloadProxyMap.h:
- UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::allNetworkProcesses):
(WebKit::defaultProcess):
(WebKit::NetworkProcessProxy::defaultNetworkProcess):
(WebKit::NetworkProcessProxy::terminate):
(WebKit::NetworkProcessProxy::didTerminate):
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
(WebKit::anyProcessPoolAlwaysRunsAtBackgroundPriority):
(WebKit::anyProcessPoolShouldTakeUIBackgroundAssertion):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::networkProcessCrashed):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
(WebKit::NetworkProcessProxy::didFinishLaunching):
(WebKit::NetworkProcessProxy::setDomainsWithUserInteraction):
(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::removeSession):
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID):
(WebKit::NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess):
(WebKit::anyProcessPoolHasForegroundWebProcesses):
(WebKit::anyProcessPoolHasBackgroundWebProcesses):
(WebKit::NetworkProcessProxy::updateProcessAssertion):
(WebKit::NetworkProcessProxy::hasSession const): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxyCocoa.mm:
(WebKit::NetworkProcessProxy::XPCEventHandler::handleXPCEvent const):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostnames):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::supplementName): Deleted.
(WebKit::WebCookieManagerProxy::create): Deleted.
(WebKit::WebCookieManagerProxy::processPoolDestroyed): Deleted.
(WebKit::WebCookieManagerProxy::processDidClose): Deleted.
(WebKit::WebCookieManagerProxy::refWebContextSupplement): Deleted.
(WebKit::WebCookieManagerProxy::derefWebContextSupplement): Deleted.
- UIProcess/WebCookieManagerProxy.h:
(WebKit::WebCookieManagerProxy::create):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setControlledByAutomation):
(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):
(WebKit::WebPageProxy::preconnectTo):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::logFrameNavigation):
(WebKit::WebPageProxy::dumpAdClickAttribution):
(WebKit::WebPageProxy::clearAdClickAttribution):
(WebKit::WebPageProxy::setAdClickAttributionOverrideTimerForTesting):
(WebKit::WebPageProxy::setAdClickAttributionConversionURLForTesting):
(WebKit::WebPageProxy::markAdClickAttributionsAsExpiredForTesting):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::urlSchemesWithCustomProtocolHandlers):
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::languageChanged):
(WebKit::WebProcessPool::sendMemoryPressureEvent):
(WebKit::WebProcessPool::networkProcessCrashed):
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::removeFromServiceWorkerProcesses):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateServiceWorkerUserAgent):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::WebProcessPool::registerURLSchemeAsLocal):
(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):
(WebKit::WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebProcessPool::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::setCacheModelSynchronouslyForTesting):
(WebKit::WebProcessPool::createDownloadProxy):
(WebKit::WebProcessPool::terminateServiceWorkers):
(WebKit::WebProcessPool::serviceWorkerProcesses):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::isServiceWorkerPageID const):
(WebKit::WebProcessPool::setUseSeparateServiceWorkerProcess):
(WebKit::WebProcessPool::hasServiceWorkerForegroundActivityForTesting const):
(WebKit::WebProcessPool::hasServiceWorkerBackgroundActivityForTesting const):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient): Deleted.
(WebKit::WebProcessPool::networkingProcessConnection): Deleted.
(WebKit::WebProcessPool::ensureNetworkProcess): Deleted.
There seems to be a lot of code removal here, but most of it was duplicate code with
WebsiteDataStore::parameters which is used instead. That which was not duplicate was
moved to NetworkProcessProxy::sendCreationParametersToNewProcess. This was the hardest part of this patch.
(WebKit::WebProcessPool::getNetworkProcessConnection): Deleted.
(WebKit::WebProcessPool::networkProcessIdentifier): Deleted.
(WebKit::WebProcessPool::synthesizeAppIsBackground): Deleted.
(WebKit::WebProcessPool::sendSyncToNetworkingProcess): Deleted.
(WebKit::WebProcessPool::clearCachedCredentials): Deleted.
(WebKit::WebProcessPool::terminateNetworkProcess): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessPrepareToSuspendForTesting): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessWillSuspendImminentlyForTesting): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessDidResume): Deleted.
(WebKit::WebProcessPool::flushCookies): Deleted.
(WebKit::WebProcessPool::didCommitCrossSiteLoadWithDataTransfer): Deleted.
- UIProcess/WebProcessPool.h:
(WebKit::WebProcessPool::sendToNetworkingProcess): Deleted.
(WebKit::WebProcessPool::sendToNetworkingProcessRelaunchingIfNecessary): Deleted.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::getNetworkProcessConnection):
(WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToWebProcess):
(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToAllWebProcesses):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::forEachWebsiteDataStore):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::registerWithSessionIDMap):
(WebKit::WebsiteDataStore::existingDataStoreForSessionID):
(WebKit::WebsiteDataStore::networkProcess):
(WebKit::WebsiteDataStore::networkProcess const):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::resetServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::isGrandfathered):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::statisticsDatabaseHasAllTables):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::domainIDExistsInDatabase):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
(WebKit::WebsiteDataStore::getAllStorageAccessEntries):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setUseITPDatabase):
(WebKit::WebsiteDataStore::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::deleteCookiesForTesting):
(WebKit::WebsiteDataStore::hasLocalStorageForTesting const):
(WebKit::WebsiteDataStore::hasIsolatedSessionForTesting const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WebKit::WebsiteDataStore::setThirdPartyCookieBlockingMode):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldEnbleSameSiteStrictEnforcementForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsToSameSiteStrictCookiesForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyHostCNAMEDomainForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsThirdPartyCNAMEDomainForTesting):
(WebKit::WebsiteDataStore::syncLocalStorage):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::processPools const):
(WebKit::WebsiteDataStore::allowSpecificHTTPSCertificateForHost):
(WebKit::WebsiteDataStore::getNetworkProcessConnection):
(WebKit::WebsiteDataStore::networkProcessCrashed):
(WebKit::WebsiteDataStore::terminateNetworkProcess):
(WebKit::WebsiteDataStore::sendNetworkProcessPrepareToSuspendForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessWillSuspendImminentlyForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessDidResume):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::setStatisticsTestingCallback):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::isResourceLoadStatisticsEphemeral const):
(WebKit::WebsiteDataStore::setAdClickAttributionDebugMode):
(WebKit::WebsiteDataStore::flushCookies):
(WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket):
(WebKit::WebsiteDataStore::clearCachedCredentials):
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::getLocalStorageDetails):
(WebKit::WebsiteDataStore::resetQuota):
(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):
(WebKit::WebsiteDataStore::renameOriginInWebsiteData):
(WebKit::WebsiteDataStore::hasAppBoundSession const):
(WebKit::WebsiteDataStore::clearAppBoundSession):
(WebKit::WebsiteDataStore::forwardAppBoundDomainsToITPIfInitialized):
(WebKit::WebsiteDataStore::setAppBoundDomainsForITP):
(WebKit::WebsiteDataStore::updateBundleIdentifierInNetworkProcess):
(WebKit::WebsiteDataStore::clearBundleIdentifierInNetworkProcess):
(WebKit::WebsiteDataStore::makeNextNetworkProcessLaunchFailForTesting):
(WebKit::WebsiteDataStore::shouldMakeNextNetworkProcessLaunchFailForTesting):
(WebKit::WebsiteDataStore::maybeRegisterWithSessionIDMap): Deleted.
(WebKit::WebsiteDataStore::existingNonDefaultDataStoreForSessionID): Deleted.
(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations): Deleted.
(WebKit::WebsiteDataStore::isAssociatedProcessPool const): Deleted.
(WebKit::WebsiteDataStore::pendingCookies const): Deleted.
(WebKit::WebsiteDataStore::addPendingCookie): Deleted.
(WebKit::WebsiteDataStore::removePendingCookie): Deleted.
(WebKit::WebsiteDataStore::clearPendingCookies): Deleted.
(WebKit::WebsiteDataStore::didCreateNetworkProcess): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp:
(WebKit::WebsiteDataStore::setNetworkProxySettings):
- UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setPersistentCredentialStorageEnabled):
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- UIProcess/soup/WebCookieManagerProxySoup.cpp:
(WebKit::WebCookieManagerProxy::setCookiePersistentStorage):
- UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
(WebKit::WebProcessPool::setNetworkProxySettings):
- WebProcess/Network/NetworkProcessConnectionInfo.h:
Tools:
Most changes to tests are just calling a function on the WKWebsiteDataStore instead of the WKProcessPool
because we want to do something with the network process and it has a new owner.
Exceptions are noted inline.
- TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::downloadAtRate):
- TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
(checkRecoveryAfterCrash):
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):
This test was making a WKWebsiteDataStore, getting its resource load statistics directory,
putting things in that directory, then starting the network process and making sure everything
works when initializing the network process. Now, network process initialization happens when a
WKWebsiteDataStore is instantiated, so we need to put things there before instantiating a WKWebsiteDataStore.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
Before this change, each WKProcessPool had its own network process, which holds the service worker registry
for the WebsiteDataStores used with that process pool. Now, the network process still needs to have a service
worker registry in it, but when we receive a message from it looking for a web process to run the service
worker, we go arbitrarily to the first process pool that has a process we can use. This logic is in
WebProcessPool::establishWorkerContextConnectionToNetworkProcess. Because we use the first process pool each
time, setting the custom user agent to two different things in two different process pools causes only one
to be used. This is not a problem in practice, though, because the only application that uses the SPI to
set a service worker's custom user agent is Safari, which only has one process pool. This test still verifies
that a user ageint is correctly sent.
Similarly, the tests that count service worker processes either have different results or need to be run with
one process pool per parent process. To keep the results the same, I separated the tests into different
TEST(ServiceWorkers, ...) macros which are run in separate parent processes.
The test RestoreFromDiskNonDefaultStore needs to use the same data store for both WKWebViews now because otherwise
there was a race condition in the startup of a new network process that wasn't there before because we were using the
same process pool and therefore the same network process. I added spinning the run loop and sleeping to be able to
reproduce the race condition failure and I use the same WKWebsiteDataStore to use the same network process, which was
the intent of using the same WKProcessPool before. The test still tests that the registration is re-used when we are
not using the default data store.
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(-[CheckSessionCookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[CheckSessionCookieUIDelegate waitForMessage]):
(-[CheckSessionCookieUIDelegate alertCookieHTML]):
(TEST):
This is the whole point of me doing this.
I took a test that was flaky only on iOS (because of different NSHTTPCookieStorage syncing behavior) and made
it flaky nowhere (fingers crossed!) and added a test that correctly handles session cookies like we could not
before this change.
I also re-used some test infrastructure and made it stop using process-global static variables for test state.
- TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
(TEST):
- TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
(-[CloseWhileStartingProtocol startLoading]):
(TestWebKitAPI::runTest):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::findAndDumpWebKitProcessIdentifiers):
(WTR::TestController::networkProcessDidCrash):
(WTR::TestController::terminateNetworkProcess):
(WTR::TestController::platformAdjustContext):
WKContextSetAllowsAnySSLCertificateForServiceWorkerTesting is not needed, so I removed it.
WKContextSetPrimaryWebsiteDataStore isn't needed any more because WKContextRef (WebProcessPool) doesn't
own a network process any more, so it doesn't care which is the default WebsiteDataStore.
In fact, the "default" WebsiteDataStore isn't really important in the network process any more.
- 4:53 PM Changeset in webkit [267607] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r266932): [ Catalina wk2 ] fast/scrolling/latching/latched-scroll-into-nonfast-region.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217001
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:20 PM Changeset in webkit [267606] by
-
- 2 edits5 deletes in trunk/LayoutTests
REGRESSION(267504): [ macOS ] webaudio/silence-after-playback.html results missing
https://bugs.webkit.org/show_bug.cgi?id=216983
<rdar://problem/69582243>
Reviewed by Eric Carlson.
Drop outdated test which no longer makes sense now that the webkit-prefixed WebAudio API has
been disabled. The WebKit-prefixed API used to allow calling createMediaElementSource() on
an OfflineAudioContext. The test was checking that we were outputting silence after the
media element has finished playing, if the OfflineAudioContext buffer length is longer than
the media duration. However, as per the specification, createMediaElementSource() is only
exposed on AudioContext (which does not have an underlying buffer), not on
OfflineAudioContext:
- platform/gtk/webaudio/silence-after-playback-expected.wav: Removed.
- platform/mac-mojave/webaudio/silence-after-playback-expected.wav: Removed.
- platform/mac/webaudio/silence-after-playback-expected.wav: Removed.
- platform/wpe/webaudio/silence-after-playback-expected.wav: Removed.
- webaudio/silence-after-playback.html: Removed.
- 4:18 PM Changeset in webkit [267605] by
-
- 2 edits in trunk/Source/WebCore
Use CMake 3.10 compatible list functions
https://bugs.webkit.org/show_bug.cgi?id=216996
Reviewed by Fujii Hironori.
POP_FRONT and PREPEND were added in CMake 3.15.
- WebCoreMacros.cmake: Use GET and REMOVE_AT instead of POP_FRONT.
- 4:02 PM Changeset in webkit [267604] by
-
- 30 edits in trunk/Source/WebCore
Drop AudioNode::setNodeType()
https://bugs.webkit.org/show_bug.cgi?id=216988
Reviewed by Eric Carlson.
Drop AudioNode::setNodeType() in favor of passing the NodeType to the AudioNode constructor.
This makes sure we never forget to set the type.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- Modules/webaudio/AudioNode.cpp:
(WebCore::convertEnumerationToString):
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::printNodeCounts):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::context):
(WebCore::AudioNode::context const):
(WebCore::AudioNode::nodeType const):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
- Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::ConstantSourceNode):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
- Modules/webaudio/IIRFilterNode.cpp:
(WebCore::IIRFilterNode::IIRFilterNode):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNodeBase::PannerNodeBase):
(WebCore::PannerNode::PannerNode):
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::StereoPannerNode):
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
- 3:54 PM Changeset in webkit [267603] by
-
- 9 edits in trunk
%TypedArray%.{from, of} no longer perform AllocateTypedArray
https://bugs.webkit.org/show_bug.cgi?id=216991
Reviewed by Yusuke Suzuki.
JSTests:
- stress/typedarray-of.js:
Fix test.
- test262/expectations.yaml:
Mark twelve test cases as passing.
Source/JavaScriptCore:
Back in ES2015, %TypedArray%.of and %TypedArray%.from appear to have been based on the abstract operation
AllocateTypedArray, which involved crawling the prototype chain to find the appropriate constructor and
only permittedthisto be a (derived) typed array.
This appears to have gone away as of ES2016 -- we simply expect
thisto be a constructor and verify that it
produced a typed array (of sufficient length).
- builtins/BuiltinNames.h:
- builtins/TypedArrayConstructor.js:
(of):
(from):
(allocateInt8Array): Deleted.
(allocateInt16Array): Deleted.
(allocateInt32Array): Deleted.
(allocateUint32Array): Deleted.
(allocateUint16Array): Deleted.
(allocateUint8Array): Deleted.
(allocateUint8ClampedArray): Deleted.
(allocateFloat32Array): Deleted.
(allocateFloat64Array): Deleted.
- runtime/JSGenericTypedArrayViewConstructor.h:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::create):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- 3:49 PM Changeset in webkit [267602] by
-
- 46 edits1 move8 adds in trunk/Source
WebGL should use GLES in iOS apps running on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=216722
<rdar://problem/68976337>
Reviewed by Tim Horton and Ken Russell.
Source/ThirdParty/ANGLE:
Change ANGLE to dynamically load either EAGL (OpenGLES) or CGL (OpenGL) depending
on both compile and runtime configurations.
Intel Mac -> CGL
Intel Mac Catalyst -> CGL
Intel iOS Simulator -> EAGL
iOS Device -> EAGL
Apple Silicon Mac -> CGL
Apple Silicon Mac Catalyst (with Mac app) -> CGL
Apple Silicon Mac Catalyst (with iOS app) -> EAGL
The trickiest bit is Apple Silicon Mac Catalyst, which depends on the
type of the application it is attempting to run. In that case ANGLE must compile
both the CGL and EAGL interfaces and then pick one to use after launch.
- ANGLE.xcodeproj/project.pbxproj: Add new files.
- Configurations/ANGLE-dynamic.xcconfig: Remove all the OpenGL* linking.
- Configurations/ANGLE-static.xcconfig:
- GLESv2.cmake: New files.
- src/common/platform.h: New definitions for CPU type on Apple Systems.
- src/gpu_info_util/SystemInfo.h: Split SystemInfo for Apple into two
files, for iOS and Mac. Added a field for isiOSAppOnMac that will only
be true when running an iOS binary on Apple Silicon.
- src/gpu_info_util/SystemInfo_apple.mm: Added. Decides which SystemInfo
to call.
(angle::GetSystemInfo):
- src/gpu_info_util/SystemInfo_ios.cpp:
(angle::GetSystemInfo_ios):
(angle::GetSystemInfo): Deleted.
- src/gpu_info_util/SystemInfo_macos.mm:
(angle::GetSystemInfo_mac):
(angle::GetSystemInfo): Deleted.
- src/libANGLE/Caps.cpp: Can no longer just check for PLATFORM_IOS. This
might still need a runtime check.
(gl::DetermineDepthTextureANGLESupport):
(gl::DetermineDepthTextureOESSupport):
- src/libANGLE/Display.cpp: This is the main initialization point for
ANGLE, which decides at compile/runtime which variant of Display to
create.
- src/libANGLE/formatutils.cpp: Add the correct formats.
(gl::BuildInternalFormatInfoMap):
- src/libANGLE/renderer/gl/SoftLinking_apple.h: Added. Macros to help soft-link
functions and ObjC classes.
- src/libANGLE/renderer/gl/cgl/CGLFunctions.cpp: Added. Where we soft-link all
the OpenGL/CGL API.
- src/libANGLE/renderer/gl/cgl/CGLFunctions.h: Added.
- src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: Use the soft-linked methods.
- src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:
- src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h:
- src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: Rename WebSwapLayer to WebSwapLayerCGL
otherwise it clashes with the EAGL version.
(rx::WindowSurfaceCGL::initialize):
(-[WebSwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.
(-[WebSwapLayer copyCGLPixelFormatForDisplayMask:]): Deleted.
(-[WebSwapLayer copyCGLContextForPixelFormat:]): Deleted.
(-[WebSwapLayer canDrawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Deleted.
(-[WebSwapLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Deleted.
- src/libANGLE/renderer/gl/eagl/DeviceEAGL.cpp: Similar changes to the CGL implementation.
- src/libANGLE/renderer/gl/eagl/DeviceEAGL.h:
- src/libANGLE/renderer/gl/eagl/DisplayEAGL.h:
- src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
(rx::DisplayEAGL::initialize):
(rx::DisplayEAGL::terminate):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
(rx::WorkerContextEAGL::makeCurrent):
(rx::WorkerContextEAGL::unmakeCurrent):
(rx::DisplayEAGL::createWorkerContext):
- src/libANGLE/renderer/gl/eagl/EAGLFunctions.h: Added.
- src/libANGLE/renderer/gl/eagl/EAGLFunctions.mm: Added.
- src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
- src/libANGLE/renderer/gl/eagl/PbufferSurfaceEAGL.cpp:
- src/libANGLE/renderer/gl/eagl/RendererEAGL.cpp:
- src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.h:
- src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
(-[WebSwapLayerEAGL display]):
(rx::WindowSurfaceEAGL::initialize):
(-[WebSwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.
(-[WebSwapLayer display]): Deleted.
- src/libANGLE/renderer/gl/renderergl_utils.cpp: Runtime check.
(rx::nativegl_gl::GenerateCaps):
Source/WebCore:
- Configurations/WebCore.xcconfig: Remove all OpenGL/OpenGLES linking.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/GraphicsContextGL.h: Change the ANGLE IOSurface texture binding
enums into functions, because they have to be calculated at run-time.
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: Use the new soft-linked
functions from PAL. Also implement the IOSurface texture binding helpers that were
previously enums.
- platform/mac/PlatformScreenMac.mm:
- platform/mac/WebGLBlocklist.mm:
Source/WebCore/PAL:
Add soft-linking content for OpenGL/OpenGLES.
- PAL.xcodeproj/project.pbxproj:
- pal/PlatformMac.cmake:
- pal/cocoa/OpenGLSoftLinkCocoa.h: Added.
- pal/cocoa/OpenGLSoftLinkCocoa.mm: Added.
Source/WebKit:
- Configurations/WebKit.xcconfig: Remove OpenGL linking.
- UIProcess/mac/HighPerformanceGPUManager.mm: Renamed to .mm. Use the PAL soft-linked OpenGL API.
- 3:41 PM Changeset in webkit [267601] by
-
- 14 edits19 adds in trunk
Support EXT_float_blend
https://bugs.webkit.org/show_bug.cgi?id=216949
Reviewed by Kenneth Russell.
Source/ThirdParty/ANGLE:
- src/libANGLE/renderer/gl/renderergl_utils.cpp:
(rx::nativegl_gl::GenerateCaps):
Source/WebCore:
Test: webgl/conformance/extensions/ext-float-blend.html
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- html/canvas/EXTFloatBlend.cpp: Added.
(WebCore::EXTFloatBlend::EXTFloatBlend):
(WebCore::EXTFloatBlend::getName const):
(WebCore::EXTFloatBlend::supported):
- html/canvas/EXTFloatBlend.h: Added.
- html/canvas/EXTFloatBlend.idl: Added.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
- webgl/conformance/extensions/ext-float-blend-expected.txt: Added.
- webgl/conformance/extensions/ext-float-blend.html: Added.
- webgl/resources/...: Added some support files.
- 3:24 PM Changeset in webkit [267600] by
-
- 1 copy in tags/Safari-611.1.1
Tag Safari-611.1.1.
- 3:09 PM Changeset in webkit [267599] by
-
- 9 edits in trunk/Source/WebKit
Replace the usages of (IPC::Attachment fencePort) with IPC::MachPort
https://bugs.webkit.org/show_bug.cgi?id=207683
Reviewed by Daniel Bates.
No new tests, no functional change.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::setVideoLayerFrame): Replace the
IPC::Attachment argument with a MachSendRight.
- WebProcess/cocoa/VideoFullscreenManager.h:
- WebProcess/cocoa/VideoFullscreenManager.messages.in:
- WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::setVideoLayerFrameFenced):
r232451 adds a check for mach port disposition, which is not necessary now.
Because ArgumentCoder<MachSendRight>::decode() provides the check.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setTopContentInset): Replace the IPC::Attachment
argument with a MachSendRight.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTopContentInsetFenced): Ditto.
r232451 adds a check for mach port disposition, which is not necessary now.
Because ArgumentCoder<MachSendRight>::decode() provides the check.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:03 PM Changeset in webkit [267598] by
-
- 1 edit2 moves in trunk/Tools
Unreviewed dashboard fix.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device.png: Removed.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device@2x.png: Removed.
- 3:03 PM Changeset in webkit [267597] by
-
- 2 edits in trunk/Source/WebKit
Tweak the names of the GPU process audio/video capture internal feature flags
https://bugs.webkit.org/show_bug.cgi?id=216992
Reviewed by Tim Horton.
Keep all 6 of the GPU process feature flags together by adjusting the human readable names of
CaptureAudioInGPUProcessEnabledandCaptureVideoInGPUProcessEnabledto start with "GPU Process:", after
<https://trac.webkit.org/r267516>.
- Shared/WebPreferencesInternal.yaml:
- 2:47 PM Changeset in webkit [267596] by
-
- 3 edits2 adds in trunk
[LFC][IFC] Incorrect width value is set for partially collapsible trailing space
https://bugs.webkit.org/show_bug.cgi?id=216990
Reviewed by Simon Fraser.
Source/WebCore:
Use the letter-spacing value as the collapsible space.
Test: fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent):
LayoutTests:
- fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing-expected.html: Added.
- fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html: Added.
- 2:43 PM Changeset in webkit [267595] by
-
- 2 edits in trunk/Source/WebCore
Fix WEBGL_compressed_texture_s3tc_srgb in WebGL 2
https://bugs.webkit.org/show_bug.cgi?id=216951
Reviewed by Kenneth Russell.
Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
- 2:32 PM Changeset in webkit [267594] by
-
- 242 edits8 deletes in trunk/Source
[JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
https://bugs.webkit.org/show_bug.cgi?id=216966
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch introduces JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION and changes how to define host functions.
In the new way, we declare a function like,
JSC_DECLARE_HOST_FUNCTION(functionHelloWorld);
And define the function like,
JSC_DEFINE_HOST_FUNCTION(functionHelloWorld, (JSGlobalObject* globalObject, CallFrame* callFrame))
{
function body.
}
This makes adding some meta information to each function easy, which helps JIT-caging to collect allowed function pointers.
- API/JSAPIWrapperObject.mm:
(JSC::JSCallbackObject<JSAPIWrapperObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):
- API/JSCallbackConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSCallbackConstructor): Deleted.
- API/JSCallbackFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callJSCallbackFunction): Deleted.
- API/JSCallbackObject.cpp:
(JSC::JSCallbackObject<JSNonFinalObject>::getCallFunction):
(JSC::JSCallbackObject<JSNonFinalObject>::getConstructFunction):
(JSC::JSCallbackObject<JSGlobalObject>::getCallFunction):
(JSC::JSCallbackObject<JSGlobalObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::getConstructData):
(JSC::JSCallbackObject<Parent>::constructImpl):
(JSC::JSCallbackObject<Parent>::getCallData):
(JSC::JSCallbackObject<Parent>::callImpl):
(JSC::JSCallbackObject<Parent>::construct): Deleted.
(JSC::JSCallbackObject<Parent>::call): Deleted.
- API/ObjCCallbackFunction.mm:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callObjCCallbackFunction): Deleted.
(JSC::constructObjCCallbackFunction): Deleted.
- API/glib/JSAPIWrapperGlobalObject.cpp:
(JSC::JSCallbackObject<JSAPIWrapperGlobalObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperGlobalObject>::getConstructFunction):
- API/glib/JSAPIWrapperObjectGLib.cpp:
(JSC::JSCallbackObject<JSAPIWrapperObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):
- API/glib/JSCCallbackFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callJSCCallbackFunction): Deleted.
(JSC::constructJSCCallbackFunction): Deleted.
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSC_DEFINE_HOST_FUNCTION):
(Inspector::jsInjectedScriptHostPrototypeAttributeEvaluate): Deleted.
(Inspector::jsInjectedScriptHostPrototypeAttributeSavedResultAlias): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionInternalConstructorName): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIsHTMLAllCollection): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIsPromiseRejectedWithNativeGetterTypeError): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionProxyTargetValue): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakMapSize): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakMapEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakSetSize): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakSetEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIteratorEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionQueryInstances): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionQueryHolders): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionEvaluateWithScopeExtension): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionFunctionDetails): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionGetInternalProperties): Deleted.
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSC_DEFINE_HOST_FUNCTION):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluateWithScopeExtension): Deleted.
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeCaller): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeSourceID): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeLine): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeColumn): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeFunctionName): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeScopeChain): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeThisObject): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeType): Deleted.
(Inspector::jsJavaScriptCallFrameIsTailDeleted): Deleted.
- jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
(functionPrintStdOut): Deleted.
(functionPrintStdErr): Deleted.
(functionDebug): Deleted.
(functionDescribe): Deleted.
(functionDescribeArray): Deleted.
(functionSleepSeconds): Deleted.
(functionJSCStack): Deleted.
(functionGCAndSweep): Deleted.
(functionFullGC): Deleted.
(functionEdenGC): Deleted.
(functionHeapSize): Deleted.
(functionResetMemoryPeak): Deleted.
(functionAddressOf): Deleted.
(functionVersion): Deleted.
(functionRun): Deleted.
(functionRunString): Deleted.
(functionLoad): Deleted.
(functionLoadString): Deleted.
(functionReadFile): Deleted.
(functionCheckSyntax): Deleted.
(functionSetSamplingFlags): Deleted.
(functionClearSamplingFlags): Deleted.
(functionGetRandomSeed): Deleted.
(functionSetRandomSeed): Deleted.
(functionIsRope): Deleted.
(functionCallerSourceOrigin): Deleted.
(functionReadline): Deleted.
(functionPreciseTime): Deleted.
(functionNeverInlineFunction): Deleted.
(functionNoDFG): Deleted.
(functionNoFTL): Deleted.
(functionNoOSRExitFuzzing): Deleted.
(functionOptimizeNextInvocation): Deleted.
(functionNumberOfDFGCompiles): Deleted.
(functionCallerIsOMGCompiled): Deleted.
(functionDollarCreateRealm): Deleted.
(functionDollarEvalScript): Deleted.
(functionDollarAgentStart): Deleted.
(functionDollarAgentReceiveBroadcast): Deleted.
(functionDollarAgentReport): Deleted.
(functionDollarAgentSleep): Deleted.
(functionDollarAgentBroadcast): Deleted.
(functionDollarAgentGetReport): Deleted.
(functionDollarAgentLeaving): Deleted.
(functionDollarAgentMonotonicNow): Deleted.
(functionWaitForReport): Deleted.
(functionHeapCapacity): Deleted.
(functionFlashHeapAccess): Deleted.
(functionDisableRichSourceInfo): Deleted.
(functionMallocInALoop): Deleted.
(functionTotalCompileTime): Deleted.
(functionJSCOptions): Deleted.
(functionReoptimizationRetryCount): Deleted.
(functionTransferArrayBuffer): Deleted.
(functionFailNextNewCodeBlock): Deleted.
(functionQuit): Deleted.
(functionFalse): Deleted.
(functionUndefined1): Deleted.
(functionUndefined2): Deleted.
(functionIsInt32): Deleted.
(functionIsPureNaN): Deleted.
(functionIdentity): Deleted.
(functionEffectful42): Deleted.
(functionMakeMasquerader): Deleted.
(functionCallMasquerader): Deleted.
(functionHasCustomProperties): Deleted.
(functionDumpTypesForAllVariables): Deleted.
(functionDrainMicrotasks): Deleted.
(functionSetTimeout): Deleted.
(functionReleaseWeakRefs): Deleted.
(functionFinalizationRegistryLiveCount): Deleted.
(functionFinalizationRegistryDeadCount): Deleted.
(functionIs32BitPlatform): Deleted.
(functionCreateGlobalObject): Deleted.
(functionCreateHeapBigInt): Deleted.
(functionCreateBigInt32): Deleted.
(functionUseBigInt32): Deleted.
(functionIsBigInt32): Deleted.
(functionIsHeapBigInt): Deleted.
(functionCheckModuleSyntax): Deleted.
(functionPlatformSupportsSamplingProfiler): Deleted.
(functionGenerateHeapSnapshot): Deleted.
(functionGenerateHeapSnapshotForGCDebugging): Deleted.
(functionResetSuperSamplerState): Deleted.
(functionEnsureArrayStorage): Deleted.
(functionStartSamplingProfiler): Deleted.
(functionSamplingProfilerStackTraces): Deleted.
(functionMaxArguments): Deleted.
(functionAsyncTestStart): Deleted.
(functionAsyncTestPassed): Deleted.
(functionWebAssemblyMemoryMode): Deleted.
(functionSetUnhandledRejectionCallback): Deleted.
(functionAsDoubleNumber): Deleted.
- runtime/AggregateErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAggregateErrorConstructor): Deleted.
(JSC::constructAggregateErrorConstructor): Deleted.
- runtime/ArrayConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithArrayConstructor): Deleted.
(JSC::callArrayConstructor): Deleted.
(JSC::arrayConstructorPrivateFuncIsArraySlow): Deleted.
- runtime/ArrayConstructor.h:
- runtime/ArrayPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::arrayProtoFuncSpeciesCreate): Deleted.
(JSC::arrayProtoFuncToString): Deleted.
(JSC::arrayProtoFuncToLocaleString): Deleted.
(JSC::arrayProtoFuncJoin): Deleted.
(JSC::arrayProtoFuncValues): Deleted.
(JSC::arrayProtoFuncEntries): Deleted.
(JSC::arrayProtoFuncKeys): Deleted.
(JSC::arrayProtoFuncPop): Deleted.
(JSC::arrayProtoFuncPush): Deleted.
(JSC::arrayProtoFuncReverse): Deleted.
(JSC::arrayProtoFuncShift): Deleted.
(JSC::arrayProtoFuncSlice): Deleted.
(JSC::arrayProtoFuncSplice): Deleted.
(JSC::arrayProtoFuncUnShift): Deleted.
(JSC::arrayProtoFuncIndexOf): Deleted.
(JSC::arrayProtoFuncLastIndexOf): Deleted.
(JSC::arrayProtoPrivateFuncConcatMemcpy): Deleted.
(JSC::arrayProtoPrivateFuncAppendMemcpy): Deleted.
- runtime/ArrayPrototype.h:
- runtime/AsyncFunctionConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAsyncFunctionConstructor): Deleted.
(JSC::constructAsyncFunctionConstructor): Deleted.
- runtime/AsyncGeneratorFunctionConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAsyncGeneratorFunctionConstructor): Deleted.
(JSC::constructAsyncGeneratorFunctionConstructor): Deleted.
- runtime/AtomicsObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::atomicsFuncAdd): Deleted.
(JSC::atomicsFuncAnd): Deleted.
(JSC::atomicsFuncCompareExchange): Deleted.
(JSC::atomicsFuncExchange): Deleted.
(JSC::atomicsFuncIsLockFree): Deleted.
(JSC::atomicsFuncLoad): Deleted.
(JSC::atomicsFuncOr): Deleted.
(JSC::atomicsFuncStore): Deleted.
(JSC::atomicsFuncSub): Deleted.
(JSC::atomicsFuncWait): Deleted.
(JSC::atomicsFuncWake): Deleted.
(JSC::atomicsFuncXor): Deleted.
- runtime/BigIntConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callBigIntConstructor): Deleted.
(JSC::bigIntConstructorFuncAsUintN): Deleted.
(JSC::bigIntConstructorFuncAsIntN): Deleted.
- runtime/BigIntPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::bigIntProtoFuncToString): Deleted.
(JSC::bigIntProtoFuncToLocaleString): Deleted.
(JSC::bigIntProtoFuncValueOf): Deleted.
- runtime/BooleanConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callBooleanConstructor): Deleted.
(JSC::constructWithBooleanConstructor): Deleted.
- runtime/BooleanPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::booleanProtoFuncToString): Deleted.
(JSC::booleanProtoFuncValueOf): Deleted.
- runtime/ConsoleObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::consoleProtoFuncDebug): Deleted.
(JSC::consoleProtoFuncError): Deleted.
(JSC::consoleProtoFuncLog): Deleted.
(JSC::consoleProtoFuncInfo): Deleted.
(JSC::consoleProtoFuncWarn): Deleted.
(JSC::consoleProtoFuncClear): Deleted.
(JSC::consoleProtoFuncDir): Deleted.
(JSC::consoleProtoFuncDirXML): Deleted.
(JSC::consoleProtoFuncTable): Deleted.
(JSC::consoleProtoFuncTrace): Deleted.
(JSC::consoleProtoFuncAssert): Deleted.
(JSC::consoleProtoFuncCount): Deleted.
(JSC::consoleProtoFuncCountReset): Deleted.
(JSC::consoleProtoFuncProfile): Deleted.
(JSC::consoleProtoFuncProfileEnd): Deleted.
(JSC::consoleProtoFuncTakeHeapSnapshot): Deleted.
(JSC::consoleProtoFuncTime): Deleted.
(JSC::consoleProtoFuncTimeLog): Deleted.
(JSC::consoleProtoFuncTimeEnd): Deleted.
(JSC::consoleProtoFuncTimeStamp): Deleted.
(JSC::consoleProtoFuncGroup): Deleted.
(JSC::consoleProtoFuncGroupCollapsed): Deleted.
(JSC::consoleProtoFuncGroupEnd): Deleted.
(JSC::consoleProtoFuncRecord): Deleted.
(JSC::consoleProtoFuncRecordEnd): Deleted.
(JSC::consoleProtoFuncScreenshot): Deleted.
- runtime/DateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithDateConstructor): Deleted.
(JSC::callDate): Deleted.
(JSC::dateParse): Deleted.
(JSC::dateNow): Deleted.
(JSC::dateUTC): Deleted.
- runtime/DatePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::dateProtoFuncToString): Deleted.
(JSC::dateProtoFuncToUTCString): Deleted.
(JSC::dateProtoFuncToISOString): Deleted.
(JSC::dateProtoFuncToDateString): Deleted.
(JSC::dateProtoFuncToTimeString): Deleted.
(JSC::dateProtoFuncToPrimitiveSymbol): Deleted.
(JSC::dateProtoFuncGetTime): Deleted.
(JSC::dateProtoFuncGetFullYear): Deleted.
(JSC::dateProtoFuncGetUTCFullYear): Deleted.
(JSC::dateProtoFuncGetMonth): Deleted.
(JSC::dateProtoFuncGetUTCMonth): Deleted.
(JSC::dateProtoFuncGetDate): Deleted.
(JSC::dateProtoFuncGetUTCDate): Deleted.
(JSC::dateProtoFuncGetDay): Deleted.
(JSC::dateProtoFuncGetUTCDay): Deleted.
(JSC::dateProtoFuncGetHours): Deleted.
(JSC::dateProtoFuncGetUTCHours): Deleted.
(JSC::dateProtoFuncGetMinutes): Deleted.
(JSC::dateProtoFuncGetUTCMinutes): Deleted.
(JSC::dateProtoFuncGetSeconds): Deleted.
(JSC::dateProtoFuncGetUTCSeconds): Deleted.
(JSC::dateProtoFuncGetMilliSeconds): Deleted.
(JSC::dateProtoFuncGetUTCMilliseconds): Deleted.
(JSC::dateProtoFuncGetTimezoneOffset): Deleted.
(JSC::dateProtoFuncSetTime): Deleted.
(JSC::dateProtoFuncSetMilliSeconds): Deleted.
(JSC::dateProtoFuncSetUTCMilliseconds): Deleted.
(JSC::dateProtoFuncSetSeconds): Deleted.
(JSC::dateProtoFuncSetUTCSeconds): Deleted.
(JSC::dateProtoFuncSetMinutes): Deleted.
(JSC::dateProtoFuncSetUTCMinutes): Deleted.
(JSC::dateProtoFuncSetHours): Deleted.
(JSC::dateProtoFuncSetUTCHours): Deleted.
(JSC::dateProtoFuncSetDate): Deleted.
(JSC::dateProtoFuncSetUTCDate): Deleted.
(JSC::dateProtoFuncSetMonth): Deleted.
(JSC::dateProtoFuncSetUTCMonth): Deleted.
(JSC::dateProtoFuncSetFullYear): Deleted.
(JSC::dateProtoFuncSetUTCFullYear): Deleted.
(JSC::dateProtoFuncSetYear): Deleted.
(JSC::dateProtoFuncGetYear): Deleted.
(JSC::dateProtoFuncToJSON): Deleted.
- runtime/DatePrototype.h:
- runtime/ErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructErrorConstructor): Deleted.
(JSC::callErrorConstructor): Deleted.
- runtime/ErrorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::errorProtoFuncToString): Deleted.
- runtime/FinalizationRegistryConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callFinalizationRegistry): Deleted.
(JSC::constructFinalizationRegistry): Deleted.
- runtime/FinalizationRegistryPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncFinalizationRegistryRegister): Deleted.
(JSC::protoFuncFinalizationRegistryUnregister): Deleted.
- runtime/FunctionConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithFunctionConstructor): Deleted.
(JSC::callFunctionConstructor): Deleted.
- runtime/FunctionPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callFunctionPrototype): Deleted.
(JSC::functionProtoFuncToString): Deleted.
- runtime/GeneratorFunctionConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callGeneratorFunctionConstructor): Deleted.
(JSC::constructGeneratorFunctionConstructor): Deleted.
- runtime/InspectorInstrumentationObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::inspectorInstrumentationObjectLog): Deleted.
- runtime/IntlCollatorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlCollator): Deleted.
(JSC::callIntlCollator): Deleted.
(JSC::IntlCollatorConstructorFuncSupportedLocalesOf): Deleted.
- runtime/IntlCollatorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlCollatorFuncCompare): Deleted.
(JSC::IntlCollatorPrototypeGetterCompare): Deleted.
(JSC::IntlCollatorPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlDateTimeFormat): Deleted.
(JSC::callIntlDateTimeFormat): Deleted.
(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf): Deleted.
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlDateTimeFormatFuncFormatDateTime): Deleted.
(JSC::IntlDateTimeFormatPrototypeGetterFormat): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncFormatRange): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlDisplayNamesConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlDisplayNames): Deleted.
(JSC::callIntlDisplayNames): Deleted.
(JSC::IntlDisplayNamesConstructorSupportedLocalesOf): Deleted.
- runtime/IntlDisplayNamesPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlDisplayNamesPrototypeFuncOf): Deleted.
(JSC::IntlDisplayNamesPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlLocaleConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlLocale): Deleted.
(JSC::callIntlLocale): Deleted.
- runtime/IntlLocalePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlLocalePrototypeFuncMaximize): Deleted.
(JSC::IntlLocalePrototypeFuncMinimize): Deleted.
(JSC::IntlLocalePrototypeFuncToString): Deleted.
(JSC::IntlLocalePrototypeGetterBaseName): Deleted.
(JSC::IntlLocalePrototypeGetterCalendar): Deleted.
(JSC::IntlLocalePrototypeGetterCaseFirst): Deleted.
(JSC::IntlLocalePrototypeGetterCollation): Deleted.
(JSC::IntlLocalePrototypeGetterHourCycle): Deleted.
(JSC::IntlLocalePrototypeGetterNumeric): Deleted.
(JSC::IntlLocalePrototypeGetterNumberingSystem): Deleted.
(JSC::IntlLocalePrototypeGetterLanguage): Deleted.
(JSC::IntlLocalePrototypeGetterScript): Deleted.
(JSC::IntlLocalePrototypeGetterRegion): Deleted.
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlNumberFormat): Deleted.
(JSC::callIntlNumberFormat): Deleted.
(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf): Deleted.
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlNumberFormatFuncFormat): Deleted.
(JSC::IntlNumberFormatPrototypeGetterFormat): Deleted.
(JSC::IntlNumberFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::intlObjectFuncGetCanonicalLocales): Deleted.
- runtime/IntlPluralRulesConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlPluralRules): Deleted.
(JSC::callIntlPluralRules): Deleted.
(JSC::IntlPluralRulesConstructorFuncSupportedLocalesOf): Deleted.
- runtime/IntlPluralRulesPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlPluralRulesPrototypeFuncSelect): Deleted.
(JSC::IntlPluralRulesPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlRelativeTimeFormatConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlRelativeTimeFormat): Deleted.
(JSC::callIntlRelativeTimeFormat): Deleted.
(JSC::IntlRelativeTimeFormatConstructorFuncSupportedLocalesOf): Deleted.
- runtime/IntlRelativeTimeFormatPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlRelativeTimeFormatPrototypeFuncFormat): Deleted.
(JSC::IntlRelativeTimeFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlRelativeTimeFormatPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlSegmentIteratorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmentIteratorPrototypeFuncNext): Deleted.
- runtime/IntlSegmenterConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlSegmenter): Deleted.
(JSC::callIntlSegmenter): Deleted.
(JSC::IntlSegmenterConstructorSupportedLocalesOf): Deleted.
- runtime/IntlSegmenterPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmenterPrototypeFuncSegment): Deleted.
(JSC::IntlSegmenterPrototypeFuncResolvedOptions): Deleted.
- runtime/IntlSegmentsPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmentsPrototypeFuncContaining): Deleted.
(JSC::IntlSegmentsPrototypeFuncIterator): Deleted.
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callArrayBuffer): Deleted.
(JSC::constructArrayBuffer): Deleted.
(JSC::constructSharedArrayBuffer): Deleted.
(JSC::arrayBufferFuncIsView): Deleted.
- runtime/JSArrayBufferPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::arrayBufferProtoFuncSlice): Deleted.
(JSC::arrayBufferProtoGetterFuncByteLength): Deleted.
(JSC::sharedArrayBufferProtoGetterFuncByteLength): Deleted.
- runtime/JSBoundFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::boundThisNoArgsFunctionCall): Deleted.
(JSC::boundFunctionCall): Deleted.
(JSC::boundThisNoArgsFunctionConstruct): Deleted.
(JSC::boundFunctionConstruct): Deleted.
(JSC::isBoundFunction): Deleted.
(JSC::hasInstanceBoundFunction): Deleted.
- runtime/JSBoundFunction.h:
- runtime/JSCustomGetterSetterFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::customGetterSetterFunctionCall): Deleted.
- runtime/JSDataViewPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::dataViewProtoGetterBuffer): Deleted.
(JSC::dataViewProtoGetterByteLength): Deleted.
(JSC::dataViewProtoGetterByteOffset): Deleted.
(JSC::dataViewProtoFuncGetInt8): Deleted.
(JSC::dataViewProtoFuncGetInt16): Deleted.
(JSC::dataViewProtoFuncGetInt32): Deleted.
(JSC::dataViewProtoFuncGetUint8): Deleted.
(JSC::dataViewProtoFuncGetUint16): Deleted.
(JSC::dataViewProtoFuncGetUint32): Deleted.
(JSC::dataViewProtoFuncGetFloat32): Deleted.
(JSC::dataViewProtoFuncGetFloat64): Deleted.
(JSC::dataViewProtoFuncSetInt8): Deleted.
(JSC::dataViewProtoFuncSetInt16): Deleted.
(JSC::dataViewProtoFuncSetInt32): Deleted.
(JSC::dataViewProtoFuncSetUint8): Deleted.
(JSC::dataViewProtoFuncSetUint16): Deleted.
(JSC::dataViewProtoFuncSetUint32): Deleted.
(JSC::dataViewProtoFuncSetFloat32): Deleted.
(JSC::dataViewProtoFuncSetFloat64): Deleted.
- runtime/JSFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::argumentsGetter):
(JSC::callerGetter):
(JSC::callHostFunctionAsConstructor): Deleted.
(JSC::JSFunction::argumentsGetter): Deleted.
(JSC::JSFunction::callerGetter): Deleted.
- runtime/JSFunction.h:
- runtime/JSGenericTypedArrayViewConstructor.h:
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::JSGenericTypedArrayViewConstructor):
(JSC::constructGenericTypedArrayViewImpl):
(JSC::callGenericTypedArrayViewImpl):
(JSC::constructGenericTypedArrayView): Deleted.
(JSC::callGenericTypedArrayView): Deleted.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncCopyWithin): Deleted.
(JSC::genericTypedArrayViewProtoFuncIncludes): Deleted.
(JSC::genericTypedArrayViewProtoFuncIndexOf): Deleted.
(JSC::genericTypedArrayViewProtoFuncJoin): Deleted.
(JSC::genericTypedArrayViewProtoFuncLastIndexOf): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncBuffer): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncLength): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncByteLength): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset): Deleted.
(JSC::genericTypedArrayViewProtoFuncReverse): Deleted.
(JSC::genericTypedArrayViewPrivateFuncSort): Deleted.
(JSC::genericTypedArrayViewProtoFuncSlice): Deleted.
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::makeBoundFunction): Deleted.
(JSC::hasOwnLengthProperty): Deleted.
(JSC::createPrivateSymbol): Deleted.
(JSC::assertCall): Deleted.
(JSC::enableSamplingProfiler): Deleted.
(JSC::disableSamplingProfiler): Deleted.
(JSC::enableSuperSampler): Deleted.
(JSC::disableSuperSampler): Deleted.
(JSC::enqueueJob): Deleted.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::globalFuncEval): Deleted.
(JSC::globalFuncParseInt): Deleted.
(JSC::globalFuncParseFloat): Deleted.
(JSC::globalFuncDecodeURI): Deleted.
(JSC::globalFuncDecodeURIComponent): Deleted.
(JSC::globalFuncEncodeURI): Deleted.
(JSC::globalFuncEncodeURIComponent): Deleted.
(JSC::globalFuncEscape): Deleted.
(JSC::globalFuncUnescape): Deleted.
(JSC::globalFuncThrowTypeError): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsCalleeAndCaller): Deleted.
(JSC::globalFuncMakeTypeError): Deleted.
(JSC::globalFuncProtoGetter): Deleted.
(JSC::globalFuncProtoSetter): Deleted.
(JSC::globalFuncSetPrototypeDirect): Deleted.
(JSC::globalFuncHostPromiseRejectionTracker): Deleted.
(JSC::globalFuncBuiltinLog): Deleted.
(JSC::globalFuncBuiltinDescribe): Deleted.
(JSC::globalFuncImportModule): Deleted.
(JSC::globalFuncPropertyIsEnumerable): Deleted.
(JSC::globalFuncOwnKeys): Deleted.
(JSC::globalFuncDateTimeFormat): Deleted.
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSModuleLoader.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::moduleLoaderParseModule): Deleted.
(JSC::moduleLoaderRequestedModules): Deleted.
(JSC::moduleLoaderModuleDeclarationInstantiation): Deleted.
(JSC::moduleLoaderResolve): Deleted.
(JSC::moduleLoaderResolveSync): Deleted.
(JSC::moduleLoaderFetch): Deleted.
(JSC::moduleLoaderGetModuleNamespaceObject): Deleted.
(JSC::moduleLoaderEvaluate): Deleted.
- runtime/JSNativeStdFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::runStdFunction): Deleted.
- runtime/JSONObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSONProtoFuncParse): Deleted.
(JSC::JSONProtoFuncStringify): Deleted.
- runtime/JSObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::objectPrivateFuncInstanceOf): Deleted.
- runtime/JSObject.h:
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructTypedArrayView): Deleted.
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::typedArrayViewPrivateFuncIsTypedArrayView): Deleted.
(JSC::typedArrayViewPrivateFuncIsNeutered): Deleted.
(JSC::typedArrayViewPrivateFuncLength): Deleted.
(JSC::typedArrayViewPrivateFuncGetOriginalConstructor): Deleted.
(JSC::typedArrayViewProtoFuncValues): Deleted.
(JSC::typedArrayProtoViewFuncEntries): Deleted.
(JSC::typedArrayViewProtoFuncKeys): Deleted.
(JSC::typedArrayViewPrivateFuncSort): Deleted.
(JSC::typedArrayViewProtoFuncSet): Deleted.
(JSC::typedArrayViewProtoFuncCopyWithin): Deleted.
(JSC::typedArrayViewProtoFuncIncludes): Deleted.
(JSC::typedArrayViewProtoFuncLastIndexOf): Deleted.
(JSC::typedArrayViewProtoFuncIndexOf): Deleted.
(JSC::typedArrayViewProtoFuncJoin): Deleted.
(JSC::typedArrayViewProtoGetterFuncBuffer): Deleted.
(JSC::typedArrayViewProtoGetterFuncLength): Deleted.
(JSC::typedArrayViewProtoGetterFuncByteLength): Deleted.
(JSC::typedArrayViewProtoGetterFuncByteOffset): Deleted.
(JSC::typedArrayViewProtoFuncReverse): Deleted.
(JSC::typedArrayViewPrivateFuncSubarrayCreate): Deleted.
(JSC::typedArrayViewProtoFuncSlice): Deleted.
(JSC::typedArrayViewProtoGetterFuncToStringTag): Deleted.
- runtime/JSTypedArrayViewPrototype.h:
- runtime/JSTypedArrays.cpp:
(JSC::createUint8TypedArray): Deleted.
- runtime/MapConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callMap): Deleted.
(JSC::constructMap): Deleted.
(JSC::mapPrivateFuncMapBucketHead): Deleted.
(JSC::mapPrivateFuncMapBucketNext): Deleted.
(JSC::mapPrivateFuncMapBucketKey): Deleted.
(JSC::mapPrivateFuncMapBucketValue): Deleted.
- runtime/MapConstructor.h:
- runtime/MapPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::mapProtoFuncClear): Deleted.
(JSC::mapProtoFuncDelete): Deleted.
(JSC::mapProtoFuncGet): Deleted.
(JSC::mapProtoFuncHas): Deleted.
(JSC::mapProtoFuncSet): Deleted.
(JSC::mapProtoFuncValues): Deleted.
(JSC::mapProtoFuncKeys): Deleted.
(JSC::mapProtoFuncEntries): Deleted.
(JSC::mapProtoFuncSize): Deleted.
- runtime/MathObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::mathProtoFuncAbs): Deleted.
(JSC::mathProtoFuncACos): Deleted.
(JSC::mathProtoFuncASin): Deleted.
(JSC::mathProtoFuncATan): Deleted.
(JSC::mathProtoFuncATan2): Deleted.
(JSC::mathProtoFuncCeil): Deleted.
(JSC::mathProtoFuncClz32): Deleted.
(JSC::mathProtoFuncCos): Deleted.
(JSC::mathProtoFuncExp): Deleted.
(JSC::mathProtoFuncFloor): Deleted.
(JSC::mathProtoFuncHypot): Deleted.
(JSC::mathProtoFuncLog): Deleted.
(JSC::mathProtoFuncMax): Deleted.
(JSC::mathProtoFuncMin): Deleted.
(JSC::mathProtoFuncPow): Deleted.
(JSC::mathProtoFuncRandom): Deleted.
(JSC::mathProtoFuncRound): Deleted.
(JSC::mathProtoFuncSign): Deleted.
(JSC::mathProtoFuncSin): Deleted.
(JSC::mathProtoFuncSqrt): Deleted.
(JSC::mathProtoFuncTan): Deleted.
(JSC::mathProtoFuncIMul): Deleted.
(JSC::mathProtoFuncACosh): Deleted.
(JSC::mathProtoFuncASinh): Deleted.
(JSC::mathProtoFuncATanh): Deleted.
(JSC::mathProtoFuncCbrt): Deleted.
(JSC::mathProtoFuncCosh): Deleted.
(JSC::mathProtoFuncExpm1): Deleted.
(JSC::mathProtoFuncFround): Deleted.
(JSC::mathProtoFuncLog1p): Deleted.
(JSC::mathProtoFuncLog10): Deleted.
(JSC::mathProtoFuncLog2): Deleted.
(JSC::mathProtoFuncSinh): Deleted.
(JSC::mathProtoFuncTanh): Deleted.
(JSC::mathProtoFuncTrunc): Deleted.
- runtime/MathObject.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callEvalError): Deleted.
(JSC::constructEvalError): Deleted.
(JSC::callRangeError): Deleted.
(JSC::constructRangeError): Deleted.
(JSC::callReferenceError): Deleted.
(JSC::constructReferenceError): Deleted.
(JSC::callSyntaxError): Deleted.
(JSC::constructSyntaxError): Deleted.
(JSC::callTypeError): Deleted.
(JSC::constructTypeError): Deleted.
(JSC::callURIError): Deleted.
(JSC::constructURIError): Deleted.
- runtime/NativeFunction.h:
- runtime/NullGetterFunction.cpp:
(JSC::NullGetterFunctionInternal::JSC_DEFINE_HOST_FUNCTION):
(JSC::NullGetterFunctionInternal::callReturnUndefined): Deleted.
- runtime/NullSetterFunction.cpp:
(JSC::NullSetterFunctionInternal::JSC_DEFINE_HOST_FUNCTION):
(JSC::NullSetterFunctionInternal::callReturnUndefined): Deleted.
(JSC::NullSetterFunctionInternal::callThrowError): Deleted.
- runtime/NumberConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructNumberConstructor): Deleted.
(JSC::callNumberConstructor): Deleted.
(JSC::numberConstructorFuncIsInteger): Deleted.
(JSC::numberConstructorFuncIsSafeInteger): Deleted.
- runtime/NumberPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::numberProtoFuncToExponential): Deleted.
(JSC::numberProtoFuncToFixed): Deleted.
(JSC::numberProtoFuncToPrecision): Deleted.
(JSC::numberProtoFuncToString): Deleted.
(JSC::numberProtoFuncToLocaleString): Deleted.
(JSC::numberProtoFuncValueOf): Deleted.
- runtime/NumberPrototype.h:
- runtime/ObjectConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithObjectConstructor): Deleted.
(JSC::callObjectConstructor): Deleted.
(JSC::objectConstructorGetPrototypeOf): Deleted.
(JSC::objectConstructorSetPrototypeOf): Deleted.
(JSC::objectConstructorGetOwnPropertyNames): Deleted.
(JSC::objectConstructorGetOwnPropertySymbols): Deleted.
(JSC::objectConstructorKeys): Deleted.
(JSC::objectConstructorAssign): Deleted.
(JSC::objectConstructorValues): Deleted.
(JSC::objectConstructorDefineProperty): Deleted.
(JSC::objectConstructorDefineProperties): Deleted.
(JSC::objectConstructorCreate): Deleted.
(JSC::objectConstructorPreventExtensions): Deleted.
(JSC::objectConstructorIsSealed): Deleted.
(JSC::objectConstructorIsFrozen): Deleted.
(JSC::objectConstructorIsExtensible): Deleted.
(JSC::objectConstructorIs): Deleted.
- runtime/ObjectConstructor.h:
- runtime/ObjectPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::objectProtoFuncValueOf): Deleted.
(JSC::objectProtoFuncHasOwnProperty): Deleted.
(JSC::objectProtoFuncIsPrototypeOf): Deleted.
(JSC::objectProtoFuncDefineGetter): Deleted.
(JSC::objectProtoFuncDefineSetter): Deleted.
(JSC::objectProtoFuncLookupGetter): Deleted.
(JSC::objectProtoFuncLookupSetter): Deleted.
(JSC::objectProtoFuncPropertyIsEnumerable): Deleted.
(JSC::objectProtoFuncToLocaleString): Deleted.
(JSC::objectProtoFuncToString): Deleted.
- runtime/ObjectPrototype.h:
- runtime/ProxyConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::makeRevocableProxy): Deleted.
(JSC::constructProxyObject): Deleted.
(JSC::callProxy): Deleted.
- runtime/ProxyObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::performProxyCall): Deleted.
(JSC::performProxyConstruct): Deleted.
- runtime/ProxyRevoke.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::performProxyRevoke): Deleted.
- runtime/ReflectObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::reflectObjectConstruct): Deleted.
(JSC::reflectObjectDefineProperty): Deleted.
(JSC::reflectObjectGet): Deleted.
(JSC::reflectObjectGetOwnPropertyDescriptor): Deleted.
(JSC::reflectObjectGetPrototypeOf): Deleted.
(JSC::reflectObjectIsExtensible): Deleted.
(JSC::reflectObjectOwnKeys): Deleted.
(JSC::reflectObjectPreventExtensions): Deleted.
(JSC::reflectObjectSet): Deleted.
(JSC::reflectObjectSetPrototypeOf): Deleted.
- runtime/RegExpConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::esSpecRegExpCreate): Deleted.
(JSC::esSpecIsRegExp): Deleted.
(JSC::constructWithRegExpConstructor): Deleted.
(JSC::callRegExpConstructor): Deleted.
- runtime/RegExpConstructor.h:
- runtime/RegExpPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::regExpProtoFuncTestFast): Deleted.
(JSC::regExpProtoFuncExec): Deleted.
(JSC::regExpProtoFuncMatchFast): Deleted.
(JSC::regExpProtoFuncCompile): Deleted.
(JSC::regExpProtoFuncToString): Deleted.
(JSC::regExpProtoGetterGlobal): Deleted.
(JSC::regExpProtoGetterIgnoreCase): Deleted.
(JSC::regExpProtoGetterMultiline): Deleted.
(JSC::regExpProtoGetterDotAll): Deleted.
(JSC::regExpProtoGetterSticky): Deleted.
(JSC::regExpProtoGetterUnicode): Deleted.
(JSC::regExpProtoGetterFlags): Deleted.
(JSC::regExpProtoGetterSource): Deleted.
(JSC::regExpProtoFuncSearchFast): Deleted.
(JSC::regExpProtoFuncSplitFast): Deleted.
- runtime/RegExpPrototype.h:
- runtime/SetConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callSet): Deleted.
(JSC::constructSet): Deleted.
(JSC::setPrivateFuncSetBucketHead): Deleted.
(JSC::setPrivateFuncSetBucketNext): Deleted.
(JSC::setPrivateFuncSetBucketKey): Deleted.
- runtime/SetConstructor.h:
- runtime/SetPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::setProtoFuncAdd): Deleted.
(JSC::setProtoFuncClear): Deleted.
(JSC::setProtoFuncDelete): Deleted.
(JSC::setProtoFuncHas): Deleted.
(JSC::setProtoFuncSize): Deleted.
(JSC::setProtoFuncValues): Deleted.
(JSC::setProtoFuncEntries): Deleted.
- runtime/StringConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::stringFromCharCode):
(JSC::stringFromCodePoint): Deleted.
(JSC::constructWithStringConstructor): Deleted.
(JSC::callStringConstructor): Deleted.
- runtime/StringConstructor.h:
- runtime/StringPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::stringProtoFuncRepeatCharacter): Deleted.
(JSC::stringProtoFuncReplaceUsingRegExp): Deleted.
(JSC::stringProtoFuncReplaceUsingStringSearch): Deleted.
(JSC::stringProtoFuncReplaceAllUsingStringSearch): Deleted.
(JSC::stringProtoFuncToString): Deleted.
(JSC::stringProtoFuncCharAt): Deleted.
(JSC::stringProtoFuncCharCodeAt): Deleted.
(JSC::stringProtoFuncCodePointAt): Deleted.
(JSC::stringProtoFuncIndexOf): Deleted.
(JSC::builtinStringIndexOfInternal): Deleted.
(JSC::stringProtoFuncLastIndexOf): Deleted.
(JSC::stringProtoFuncSlice): Deleted.
(JSC::stringProtoFuncSplitFast): Deleted.
(JSC::stringProtoFuncSubstr): Deleted.
(JSC::stringProtoFuncSubstring): Deleted.
(JSC::builtinStringSubstringInternal): Deleted.
(JSC::stringProtoFuncToLowerCase): Deleted.
(JSC::stringProtoFuncToUpperCase): Deleted.
(JSC::stringProtoFuncLocaleCompare): Deleted.
(JSC::stringProtoFuncToLocaleLowerCase): Deleted.
(JSC::stringProtoFuncToLocaleUpperCase): Deleted.
(JSC::stringProtoFuncTrim): Deleted.
(JSC::stringProtoFuncTrimStart): Deleted.
(JSC::stringProtoFuncTrimEnd): Deleted.
(JSC::stringProtoFuncStartsWith): Deleted.
(JSC::stringProtoFuncEndsWith): Deleted.
(JSC::stringProtoFuncIncludes): Deleted.
(JSC::builtinStringIncludesInternal): Deleted.
(JSC::stringProtoFuncIterator): Deleted.
(JSC::stringProtoFuncNormalize): Deleted.
- runtime/StringPrototype.h:
- runtime/Structure.h:
- runtime/SymbolConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callSymbol): Deleted.
(JSC::constructSymbol): Deleted.
(JSC::symbolConstructorFor): Deleted.
(JSC::symbolConstructorKeyFor): Deleted.
- runtime/SymbolPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::symbolProtoGetterDescription): Deleted.
(JSC::symbolProtoFuncToString): Deleted.
(JSC::symbolProtoFuncValueOf): Deleted.
- runtime/WeakMapConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakMap): Deleted.
(JSC::constructWeakMap): Deleted.
- runtime/WeakMapPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakMapDelete): Deleted.
(JSC::protoFuncWeakMapGet): Deleted.
(JSC::protoFuncWeakMapHas): Deleted.
(JSC::protoFuncWeakMapSet): Deleted.
- runtime/WeakObjectRefConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakRef): Deleted.
(JSC::constructWeakRef): Deleted.
- runtime/WeakObjectRefPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakRefDeref): Deleted.
- runtime/WeakSetConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakSet): Deleted.
(JSC::constructWeakSet): Deleted.
- runtime/WeakSetPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakSetDelete): Deleted.
(JSC::protoFuncWeakSetHas): Deleted.
(JSC::protoFuncWeakSetAdd): Deleted.
- tools/JSDollarVM.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSDollarVM::finishCreation):
(JSC::functionCrash): Deleted.
(JSC::functionBreakpoint): Deleted.
(JSC::functionDFGTrue): Deleted.
(JSC::functionFTLTrue): Deleted.
(JSC::functionCpuMfence): Deleted.
(JSC::functionCpuRdtsc): Deleted.
(JSC::functionCpuCpuid): Deleted.
(JSC::functionCpuPause): Deleted.
(JSC::functionCpuClflush): Deleted.
(JSC::functionLLintTrue): Deleted.
(JSC::functionBaselineJITTrue): Deleted.
(JSC::functionNoInline): Deleted.
(JSC::functionGC): Deleted.
(JSC::functionEdenGC): Deleted.
(JSC::functionGCSweepAsynchronously): Deleted.
(JSC::functionDumpSubspaceHashes): Deleted.
(JSC::functionCallFrame): Deleted.
(JSC::functionCodeBlockForFrame): Deleted.
(JSC::functionCodeBlockFor): Deleted.
(JSC::functionDumpSourceFor): Deleted.
(JSC::functionDumpBytecodeFor): Deleted.
(JSC::functionDataLog): Deleted.
(JSC::functionPrint): Deleted.
(JSC::functionDumpCallFrame): Deleted.
(JSC::functionDumpStack): Deleted.
(JSC::functionDumpRegisters): Deleted.
(JSC::functionDumpCell): Deleted.
(JSC::functionIndexingMode): Deleted.
(JSC::functionInlineCapacity): Deleted.
(JSC::functionValue): Deleted.
(JSC::functionGetPID): Deleted.
(JSC::functionHaveABadTime): Deleted.
(JSC::functionIsHavingABadTime): Deleted.
(JSC::functionCallWithStackSize): Deleted.
(JSC::functionCreateGlobalObject): Deleted.
(JSC::functionCreateProxy): Deleted.
(JSC::functionCreateRuntimeArray): Deleted.
(JSC::functionCreateNullRopeString): Deleted.
(JSC::functionCreateImpureGetter): Deleted.
(JSC::functionCreateCustomGetterObject): Deleted.
(JSC::functionCreateDOMJITNodeObject): Deleted.
(JSC::functionCreateDOMJITGetterObject): Deleted.
(JSC::functionCreateDOMJITGetterNoEffectsObject): Deleted.
(JSC::functionCreateDOMJITGetterComplexObject): Deleted.
(JSC::functionCreateDOMJITFunctionObject): Deleted.
(JSC::functionCreateDOMJITCheckJSCastObject): Deleted.
(JSC::functionCreateDOMJITGetterBaseJSObject): Deleted.
(JSC::functionCreateWasmStreamingParser): Deleted.
(JSC::functionCreateStaticCustomAccessor): Deleted.
(JSC::functionCreateStaticCustomValue): Deleted.
(JSC::functionCreateObjectDoingSideEffectPutWithoutCorrectSlotStatus): Deleted.
(JSC::functionCreateEmptyFunctionWithName): Deleted.
(JSC::functionSetImpureGetterDelegate): Deleted.
(JSC::functionCreateBuiltin): Deleted.
(JSC::functionGetPrivateProperty): Deleted.
(JSC::functionCreateRoot): Deleted.
(JSC::functionCreateElement): Deleted.
(JSC::functionGetElement): Deleted.
(JSC::functionCreateSimpleObject): Deleted.
(JSC::functionGetHiddenValue): Deleted.
(JSC::functionSetHiddenValue): Deleted.
(JSC::functionShadowChickenFunctionsOnStack): Deleted.
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(JSC::functionFindTypeForExpression): Deleted.
(JSC::functionReturnTypeFor): Deleted.
(JSC::functionFlattenDictionaryObject): Deleted.
(JSC::functionDumpBasicBlockExecutionRanges): Deleted.
(JSC::functionHasBasicBlockExecuted): Deleted.
(JSC::functionBasicBlockExecutionCount): Deleted.
(JSC::functionEnableDebuggerModeWhenIdle): Deleted.
(JSC::functionDisableDebuggerModeWhenIdle): Deleted.
(JSC::functionDeleteAllCodeWhenIdle): Deleted.
(JSC::functionGlobalObjectCount): Deleted.
(JSC::functionGlobalObjectForObject): Deleted.
(JSC::functionGetGetterSetter): Deleted.
(JSC::functionLoadGetterFromGetterSetter): Deleted.
(JSC::functionCreateCustomTestGetterSetter): Deleted.
(JSC::functionDeltaBetweenButterflies): Deleted.
(JSC::functionCurrentCPUTime): Deleted.
(JSC::functionTotalGCTime): Deleted.
(JSC::functionParseCount): Deleted.
(JSC::functionIsWasmSupported): Deleted.
(JSC::functionMake16BitStringIfPossible): Deleted.
(JSC::JSDollarVMHelper::functionGetStructureTransitionList): Deleted.
(JSC::functionGetConcurrently): Deleted.
(JSC::functionHasOwnLengthProperty): Deleted.
(JSC::functionRejectPromiseAsHandled): Deleted.
(JSC::functionSetUserPreferredLanguages): Deleted.
(JSC::functionICUVersion): Deleted.
(JSC::functionICUHeaderVersion): Deleted.
(JSC::functionAssertEnabled): Deleted.
(JSC::functionIsMemoryLimited): Deleted.
(JSC::functionUseJIT): Deleted.
(JSC::functionIsGigacageEnabled): Deleted.
(JSC::functionToUncacheableDictionary): Deleted.
- wasm/js/JSWebAssembly.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyCompileFunc): Deleted.
(JSC::webAssemblyInstantiateFunc): Deleted.
(JSC::webAssemblyValidateFunc): Deleted.
(JSC::webAssemblyCompileStreamingInternal): Deleted.
(JSC::webAssemblyInstantiateStreamingInternal): Deleted.
- wasm/js/JSWebAssembly.h:
- wasm/js/WebAssemblyCompileErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyCompileError): Deleted.
(JSC::callJSWebAssemblyCompileError): Deleted.
- wasm/js/WebAssemblyFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWebAssemblyFunction): Deleted.
- wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyGlobal): Deleted.
(JSC::callJSWebAssemblyGlobal): Deleted.
- wasm/js/WebAssemblyGlobalPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyGlobalProtoFuncValueOf): Deleted.
(JSC::webAssemblyGlobalProtoGetterFuncValue): Deleted.
(JSC::webAssemblyGlobalProtoSetterFuncValue): Deleted.
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyInstance): Deleted.
(JSC::callJSWebAssemblyInstance): Deleted.
- wasm/js/WebAssemblyInstancePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyInstanceProtoFuncExports): Deleted.
- wasm/js/WebAssemblyLinkErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyLinkError): Deleted.
(JSC::callJSWebAssemblyLinkError): Deleted.
- wasm/js/WebAssemblyMemoryConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyMemory): Deleted.
(JSC::callJSWebAssemblyMemory): Deleted.
- wasm/js/WebAssemblyMemoryPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyMemoryProtoFuncGrow): Deleted.
(JSC::webAssemblyMemoryProtoFuncBuffer): Deleted.
- wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyModuleCustomSections): Deleted.
(JSC::webAssemblyModuleImports): Deleted.
(JSC::webAssemblyModuleExports): Deleted.
(JSC::constructJSWebAssemblyModule): Deleted.
(JSC::callJSWebAssemblyModule): Deleted.
- wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyRuntimeError): Deleted.
(JSC::callJSWebAssemblyRuntimeError): Deleted.
- wasm/js/WebAssemblyTableConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyTable): Deleted.
(JSC::callJSWebAssemblyTable): Deleted.
- wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyTableProtoFuncLength): Deleted.
(JSC::webAssemblyTableProtoFuncGrow): Deleted.
(JSC::webAssemblyTableProtoFuncGet): Deleted.
(JSC::webAssemblyTableProtoFuncSet): Deleted.
- wasm/js/WebAssemblyWrapperFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWebAssemblyWrapperFunction): Deleted.
Source/WebCore:
No behavior change. We also annotate custom getters / setters with JIT_OPERATION since they can be invoked from JIT code.
- bindings/js/JSDOMBuiltinConstructor.h:
(WebCore::JSDOMBuiltinConstructor<JSClass>::construct):
- bindings/js/JSDOMConstructor.h:
- bindings/js/JSDOMConstructorBase.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::callThrowTypeError): Deleted.
- bindings/js/JSDOMConstructorBase.h:
- bindings/js/JSDOMConstructorNotConstructable.h:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::makeThisTypeErrorForBuiltins): Deleted.
(WebCore::makeGetterTypeErrorForBuiltins): Deleted.
(WebCore::makeDOMExceptionForBuiltins): Deleted.
(WebCore::isReadableByteStreamAPIEnabled): Deleted.
(WebCore::isWritableStreamAPIEnabled): Deleted.
(WebCore::whenSignalAborted): Deleted.
- bindings/js/JSDOMIterator.h:
(WebCore::IteratorTraits>::next):
- bindings/js/JSDOMLegacyFactoryFunction.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowWebKit):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsDOMWindowInstanceFunctionOpenDatabase): Deleted.
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::callPlugin): Deleted.
- bindings/js/StructuredClone.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::cloneArrayBuffer): Deleted.
(WebCore::structuredCloneArrayBuffer): Deleted.
(WebCore::structuredCloneArrayBufferView): Deleted.
- bindings/js/StructuredClone.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateAttributeGetterTrampolineDefinition):
(GenerateAttributeSetterTrampolineDefinition):
(GenerateOperationTrampolineDefinition):
(GenerateDefaultToJSONOperationDefinition):
(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
(GenerateIterableDefinition):
(GenerateConstructorDefinitions):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSDOMWindow.cpp:
(WebCore::jsDOMWindowConstructor):
(WebCore::setJSDOMWindowConstructor):
(WebCore::jsDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::setJSDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::jsDOMWindowTestConditionallyReadWriteConstructor):
(WebCore::setJSDOMWindowTestConditionallyReadWriteConstructor):
(WebCore::jsDOMWindowTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSDOMWindowTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsDOMWindowTestNodeConstructor):
(WebCore::setJSDOMWindowTestNodeConstructor):
(WebCore::jsDOMWindowTestObjectConstructor):
(WebCore::setJSDOMWindowTestObjectConstructor):
(WebCore::jsDOMWindowTestPromiseRejectionEventConstructor):
(WebCore::setJSDOMWindowTestPromiseRejectionEventConstructor):
- bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp:
(WebCore::jsDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSDedicatedWorkerGlobalScopeConstructor):
- bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:
(WebCore::JSExposedToWorkerAndWindowConstructor::construct):
(WebCore::jsExposedToWorkerAndWindowConstructor):
(WebCore::setJSExposedToWorkerAndWindowConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsExposedToWorkerAndWindowPrototypeFunctionDoSomething): Deleted.
- bindings/scripts/test/JS/JSMapLike.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsMapLikePrototypeFunctionForEach): Deleted.
(WebCore::jsMapLikePrototypeFunctionSet): Deleted.
(WebCore::jsMapLikePrototypeFunctionClear): Deleted.
(WebCore::jsMapLikePrototypeFunctionDelete): Deleted.
- bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp:
(WebCore::jsPaintWorkletGlobalScopeConstructor):
(WebCore::setJSPaintWorkletGlobalScopeConstructor):
- bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsReadOnlyMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSReadOnlySetLike.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsReadOnlySetLikePrototypeFunctionHas): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionValues): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp:
(WebCore::jsServiceWorkerGlobalScopeConstructor):
(WebCore::setJSServiceWorkerGlobalScopeConstructor):
- bindings/scripts/test/JS/JSSetLike.cpp:
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsSetLikePrototypeFunctionHas): Deleted.
(WebCore::jsSetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsSetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsSetLikePrototypeFunctionValues): Deleted.
(WebCore::jsSetLikePrototypeFunctionForEach): Deleted.
(WebCore::jsSetLikePrototypeFunctionAdd): Deleted.
(WebCore::jsSetLikePrototypeFunctionClear): Deleted.
(WebCore::jsSetLikePrototypeFunctionDelete): Deleted.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::prototypeForStructure):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction): Deleted.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage): Deleted.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionOverloadedMethod): Deleted.
- bindings/scripts/test/JS/JSTestCEReactions.cpp:
(WebCore::jsTestCEReactionsConstructor):
(WebCore::setJSTestCEReactionsConstructor):
(WebCore::jsTestCEReactionsAttributeWithCEReactions):
(WebCore::setJSTestCEReactionsAttributeWithCEReactions):
(WebCore::jsTestCEReactionsReflectAttributeWithCEReactions):
(WebCore::setJSTestCEReactionsReflectAttributeWithCEReactions):
(WebCore::jsTestCEReactionsStringifierAttribute):
(WebCore::setJSTestCEReactionsStringifierAttribute):
(WebCore::jsTestCEReactionsAttributeWithCEReactionsNotNeeded):
(WebCore::setJSTestCEReactionsAttributeWithCEReactionsNotNeeded):
(WebCore::jsTestCEReactionsReflectAttributeWithCEReactionsNotNeeded):
(WebCore::setJSTestCEReactionsReflectAttributeWithCEReactionsNotNeeded):
(WebCore::jsTestCEReactionsStringifierAttributeNotNeeded):
(WebCore::setJSTestCEReactionsStringifierAttributeNotNeeded):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactions): Deleted.
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactionsNotNeeded): Deleted.
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
(WebCore::jsTestCEReactionsStringifierConstructor):
(WebCore::setJSTestCEReactionsStringifierConstructor):
(WebCore::jsTestCEReactionsStringifierValue):
(WebCore::setJSTestCEReactionsStringifierValue):
(WebCore::jsTestCEReactionsStringifierValueWithoutReactions):
(WebCore::setJSTestCEReactionsStringifierValueWithoutReactions):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCEReactionsStringifierPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::JSTestCallTracerConstructor::prototypeForStructure):
(WebCore::jsTestCallTracerConstructor):
(WebCore::setJSTestCallTracerConstructor):
(WebCore::jsTestCallTracerTestAttributeInterface):
(WebCore::setJSTestCallTracerTestAttributeInterface):
(WebCore::jsTestCallTracerTestAttributeSpecified):
(WebCore::setJSTestCallTracerTestAttributeSpecified):
(WebCore::jsTestCallTracerTestAttributeWithVariant):
(WebCore::setJSTestCallTracerTestAttributeWithVariant):
(WebCore::jsTestCallTracerTestReadonlyAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterface): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecified): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArguments): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument): Deleted.
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::jsTestClassWithJSBuiltinConstructorConstructor):
(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:
(WebCore::JSTestConditionalIncludesConstructor::prototypeForStructure):
(WebCore::jsTestConditionalIncludesConstructor):
(WebCore::setJSTestConditionalIncludesConstructor):
(WebCore::jsTestConditionalIncludesTestAttr):
(WebCore::jsTestConditionalIncludesMixinReadOnlyAttribute):
(WebCore::jsTestConditionalIncludesMixinAttribute):
(WebCore::setJSTestConditionalIncludesMixinAttribute):
(WebCore::jsTestConditionalIncludesMixinCustomAttribute):
(WebCore::setJSTestConditionalIncludesMixinCustomAttribute):
(WebCore::jsTestConditionalIncludesMixinNodeAttribute):
(WebCore::setJSTestConditionalIncludesMixinNodeAttribute):
(WebCore::jsTestConditionalIncludesPartialMixinAttributeFromPartial):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinComplexOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinCustomOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinConditionalOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinSettingsConditionalOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinResultFieldOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionPartialMixinOperationFromPartial): Deleted.
- bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:
(WebCore::JSTestConditionallyReadWriteConstructor::prototypeForStructure):
(WebCore::jsTestConditionallyReadWriteConstructor):
(WebCore::setJSTestConditionallyReadWriteConstructor):
(WebCore::jsTestConditionallyReadWriteConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteConditionalAndConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteConditionalAndConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeable):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeable):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributePromise):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributePromise):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeable):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeable):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributePromise):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributePromise):
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
(WebCore::jsTestDOMJITConstructor):
(WebCore::setJSTestDOMJITConstructor):
(WebCore::jsTestDOMJITAnyAttr):
(WebCore::jsTestDOMJITBooleanAttr):
(WebCore::jsTestDOMJITByteAttr):
(WebCore::jsTestDOMJITOctetAttr):
(WebCore::jsTestDOMJITShortAttr):
(WebCore::jsTestDOMJITUnsignedShortAttr):
(WebCore::jsTestDOMJITLongAttr):
(WebCore::jsTestDOMJITUnsignedLongAttr):
(WebCore::jsTestDOMJITLongLongAttr):
(WebCore::jsTestDOMJITUnsignedLongLongAttr):
(WebCore::jsTestDOMJITFloatAttr):
(WebCore::jsTestDOMJITUnrestrictedFloatAttr):
(WebCore::jsTestDOMJITDoubleAttr):
(WebCore::jsTestDOMJITUnrestrictedDoubleAttr):
(WebCore::jsTestDOMJITDomStringAttr):
(WebCore::jsTestDOMJITByteStringAttr):
(WebCore::jsTestDOMJITUsvStringAttr):
(WebCore::jsTestDOMJITNodeAttr):
(WebCore::jsTestDOMJITBooleanNullableAttr):
(WebCore::jsTestDOMJITByteNullableAttr):
(WebCore::jsTestDOMJITOctetNullableAttr):
(WebCore::jsTestDOMJITShortNullableAttr):
(WebCore::jsTestDOMJITUnsignedShortNullableAttr):
(WebCore::jsTestDOMJITLongNullableAttr):
(WebCore::jsTestDOMJITUnsignedLongNullableAttr):
(WebCore::jsTestDOMJITLongLongNullableAttr):
(WebCore::jsTestDOMJITUnsignedLongLongNullableAttr):
(WebCore::jsTestDOMJITFloatNullableAttr):
(WebCore::jsTestDOMJITUnrestrictedFloatNullableAttr):
(WebCore::jsTestDOMJITDoubleNullableAttr):
(WebCore::jsTestDOMJITUnrestrictedDoubleNullableAttr):
(WebCore::jsTestDOMJITDomStringNullableAttr):
(WebCore::jsTestDOMJITByteStringNullableAttr):
(WebCore::jsTestDOMJITUsvStringNullableAttr):
(WebCore::jsTestDOMJITNodeNullableAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDOMJITPrototypeFunctionGetAttribute): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionItem): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionHasAttribute): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionGetElementById): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionGetElementsByName): Deleted.
- bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:
(WebCore::jsTestDefaultToJSONConstructor):
(WebCore::setJSTestDefaultToJSONConstructor):
(WebCore::jsTestDefaultToJSONLongAttribute):
(WebCore::jsTestDefaultToJSONEnabledBySettingsAttribute):
(WebCore::jsTestDefaultToJSONEnabledByConditionalAttribute):
(WebCore::jsTestDefaultToJSONEventHandlerAttribute):
(WebCore::setJSTestDefaultToJSONEventHandlerAttribute):
(WebCore::jsTestDefaultToJSONFirstStringAttribute):
(WebCore::setJSTestDefaultToJSONFirstStringAttribute):
(WebCore::jsTestDefaultToJSONSecondLongAttribute):
(WebCore::setJSTestDefaultToJSONSecondLongAttribute):
(WebCore::jsTestDefaultToJSONThirdUnJSONableAttribute):
(WebCore::setJSTestDefaultToJSONThirdUnJSONableAttribute):
(WebCore::jsTestDefaultToJSONFourthUnrestrictedDoubleAttribute):
(WebCore::setJSTestDefaultToJSONFourthUnrestrictedDoubleAttribute):
(WebCore::jsTestDefaultToJSONFifthLongClampedAttribute):
(WebCore::setJSTestDefaultToJSONFifthLongClampedAttribute):
(WebCore::jsTestDefaultToJSONSixthTypedefAttribute):
(WebCore::setJSTestDefaultToJSONSixthTypedefAttribute):
(WebCore::jsTestDefaultToJSONSeventhDirectlyToJSONableAttribute):
(WebCore::setJSTestDefaultToJSONSeventhDirectlyToJSONableAttribute):
(WebCore::jsTestDefaultToJSONEighthIndirectlyAttribute):
(WebCore::setJSTestDefaultToJSONEighthIndirectlyAttribute):
(WebCore::jsTestDefaultToJSONNinthOptionalDirectlyToJSONableAttribute):
(WebCore::setJSTestDefaultToJSONNinthOptionalDirectlyToJSONableAttribute):
(WebCore::jsTestDefaultToJSONTenthFrozenArrayAttribute):
(WebCore::setJSTestDefaultToJSONTenthFrozenArrayAttribute):
(WebCore::jsTestDefaultToJSONEleventhSequenceAttribute):
(WebCore::setJSTestDefaultToJSONEleventhSequenceAttribute):
(WebCore::jsTestDefaultToJSONTwelfthInterfaceSequenceAttribute):
(WebCore::setJSTestDefaultToJSONTwelfthInterfaceSequenceAttribute):
(WebCore::jsTestDefaultToJSONThirteenthRecordAttribute):
(WebCore::setJSTestDefaultToJSONThirteenthRecordAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONPrototypeFunctionToJSON): Deleted.
- bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:
(WebCore::jsTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsTestDefaultToJSONFilteredByExposedNormalAttribute):
(WebCore::jsTestDefaultToJSONFilteredByExposedFilteredByExposedWindowAttribute):
(WebCore::jsTestDefaultToJSONFilteredByExposedFilteredByExposedWorkerAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONFilteredByExposedPrototypeFunctionToJSON): Deleted.
- bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp:
(WebCore::jsTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::setJSTestDefaultToJSONIndirectInheritanceConstructor):
- bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:
(WebCore::jsTestDefaultToJSONInheritConstructor):
(WebCore::setJSTestDefaultToJSONInheritConstructor):
(WebCore::jsTestDefaultToJSONInheritInheritLongAttribute):
(WebCore::setJSTestDefaultToJSONInheritInheritLongAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONInheritPrototypeFunctionToJSON): Deleted.
- bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:
(WebCore::jsTestDefaultToJSONInheritFinalConstructor):
(WebCore::setJSTestDefaultToJSONInheritFinalConstructor):
(WebCore::jsTestDefaultToJSONInheritFinalFinalLongAttributeFoo):
(WebCore::setJSTestDefaultToJSONInheritFinalFinalLongAttributeFoo):
(WebCore::jsTestDefaultToJSONInheritFinalFinalLongAttributeBar):
(WebCore::setJSTestDefaultToJSONInheritFinalFinalLongAttributeBar):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONInheritFinalPrototypeFunctionToJSON): Deleted.
- bindings/scripts/test/JS/JSTestDomainSecurity.cpp:
(WebCore::JSTestDomainSecurityConstructor::prototypeForStructure):
(WebCore::jsTestDomainSecurityConstructor):
(WebCore::setJSTestDomainSecurityConstructor):
(WebCore::jsTestDomainSecurityExcitingAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDomainSecurityPrototypeFunctionExcitingFunction): Deleted.
(WebCore::jsTestDomainSecurityPrototypeFunctionPostMessage): Deleted.
(WebCore::jsTestDomainSecurityPrototypeFunctionOverloadedMethod): Deleted.
- bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
(WebCore::JSTestEnabledBySettingConstructor::prototypeForStructure):
(WebCore::jsTestEnabledBySettingConstructor):
(WebCore::setJSTestEnabledBySettingConstructor):
(WebCore::jsTestEnabledBySettingTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestEnabledBySettingTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestEnabledBySettingEnabledBySettingAttribute):
(WebCore::setJSTestEnabledBySettingEnabledBySettingAttribute):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::jsTestEnabledBySettingSupplementalAttribute):
(WebCore::setJSTestEnabledBySettingSupplementalAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestEnabledBySettingPrototypeFunctionEnabledBySettingOperation): Deleted.
- bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
(WebCore::jsTestEnabledForContextConstructor):
(WebCore::setJSTestEnabledForContextConstructor):
(WebCore::jsTestEnabledForContextTestSubObjEnabledForContextConstructor):
(WebCore::setJSTestEnabledForContextTestSubObjEnabledForContextConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::setJSTestEventConstructorConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorAttr3):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetConstructor):
(WebCore::setJSTestEventTargetConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestEventTargetPrototypeFunctionItem): Deleted.
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionConstructor):
(WebCore::setJSTestExceptionConstructor):
(WebCore::jsTestExceptionName):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::jsTestGenerateIsReachableConstructor):
(WebCore::setJSTestGenerateIsReachableConstructor):
(WebCore::jsTestGenerateIsReachableASecretAttribute):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectConstructor):
(WebCore::setJSTestGlobalObjectConstructor):
(WebCore::jsTestGlobalObjectRegularAttribute):
(WebCore::setJSTestGlobalObjectRegularAttribute):
(WebCore::jsTestGlobalObjectPublicAndPrivateAttribute):
(WebCore::setJSTestGlobalObjectPublicAndPrivateAttribute):
(WebCore::jsTestGlobalObjectPublicAndPrivateConditionalAttribute):
(WebCore::setJSTestGlobalObjectPublicAndPrivateConditionalAttribute):
(WebCore::jsTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::setJSTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::jsTestGlobalObjectDOMWindowConstructor):
(WebCore::setJSTestGlobalObjectDOMWindowConstructor):
(WebCore::jsTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectTestCEReactionsConstructor):
(WebCore::setJSTestGlobalObjectTestCEReactionsConstructor):
(WebCore::jsTestGlobalObjectTestCEReactionsStringifierConstructor):
(WebCore::setJSTestGlobalObjectTestCEReactionsStringifierConstructor):
(WebCore::jsTestGlobalObjectTestCallTracerConstructor):
(WebCore::setJSTestGlobalObjectTestCallTracerConstructor):
(WebCore::jsTestGlobalObjectTestCallbackInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestCallbackInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestClassWithJSBuiltinConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestClassWithJSBuiltinConstructorConstructor):
(WebCore::jsTestGlobalObjectTestConditionalIncludesConstructor):
(WebCore::setJSTestGlobalObjectTestConditionalIncludesConstructor):
(WebCore::jsTestGlobalObjectTestDOMJITConstructor):
(WebCore::setJSTestGlobalObjectTestDOMJITConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONInheritConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONInheritConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONInheritFinalConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONInheritFinalConstructor):
(WebCore::jsTestGlobalObjectTestDomainSecurityConstructor):
(WebCore::setJSTestGlobalObjectTestDomainSecurityConstructor):
(WebCore::jsTestGlobalObjectTestEnabledBySettingConstructor):
(WebCore::setJSTestGlobalObjectTestEnabledBySettingConstructor):
(WebCore::jsTestGlobalObjectTestEnabledForContextConstructor):
(WebCore::setJSTestGlobalObjectTestEnabledForContextConstructor):
(WebCore::jsTestGlobalObjectTestEventConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestEventConstructorConstructor):
(WebCore::jsTestGlobalObjectTestEventTargetConstructor):
(WebCore::setJSTestGlobalObjectTestEventTargetConstructor):
(WebCore::jsTestGlobalObjectTestExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestExceptionConstructor):
(WebCore::jsTestGlobalObjectTestGenerateIsReachableConstructor):
(WebCore::setJSTestGlobalObjectTestGenerateIsReachableConstructor):
(WebCore::jsTestGlobalObjectTestGlobalObjectConstructor):
(WebCore::setJSTestGlobalObjectTestGlobalObjectConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestInterfaceLeadingUnderscoreConstructor):
(WebCore::setJSTestGlobalObjectTestInterfaceLeadingUnderscoreConstructor):
(WebCore::jsTestGlobalObjectTestIterableConstructor):
(WebCore::setJSTestGlobalObjectTestIterableConstructor):
(WebCore::jsTestGlobalObjectTestJSBuiltinConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestJSBuiltinConstructorConstructor):
(WebCore::jsTestGlobalObjectTestLegacyFactoryFunctionConstructor):
(WebCore::setJSTestGlobalObjectTestLegacyFactoryFunctionConstructor):
(WebCore::jsTestGlobalObjectAudioConstructor):
(WebCore::setJSTestGlobalObjectAudioConstructor):
(WebCore::jsTestGlobalObjectTestLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestMapLikeConstructor):
(WebCore::setJSTestGlobalObjectTestMapLikeConstructor):
(WebCore::jsTestGlobalObjectTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestGlobalObjectTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterCallWithConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterCallWithConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIndexedGetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIndexedGetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestOperationConditionalConstructor):
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructor):
(WebCore::jsTestGlobalObjectTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::setJSTestGlobalObjectTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::jsTestGlobalObjectTestPluginInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestPluginInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestReadOnlyMapLikeConstructor):
(WebCore::setJSTestGlobalObjectTestReadOnlyMapLikeConstructor):
(WebCore::jsTestGlobalObjectTestReadOnlySetLikeConstructor):
(WebCore::setJSTestGlobalObjectTestReadOnlySetLikeConstructor):
(WebCore::jsTestGlobalObjectTestReportExtraMemoryCostConstructor):
(WebCore::setJSTestGlobalObjectTestReportExtraMemoryCostConstructor):
(WebCore::jsTestGlobalObjectTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestSerializedScriptValueInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestSetLikeConstructor):
(WebCore::setJSTestGlobalObjectTestSetLikeConstructor):
(WebCore::jsTestGlobalObjectTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestGlobalObjectTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestGlobalObjectTestStringifierConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierConstructor):
(WebCore::jsTestGlobalObjectTestStringifierAnonymousOperationConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierAnonymousOperationConstructor):
(WebCore::jsTestGlobalObjectTestStringifierNamedOperationConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierNamedOperationConstructor):
(WebCore::jsTestGlobalObjectTestStringifierOperationImplementedAsConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierOperationImplementedAsConstructor):
(WebCore::jsTestGlobalObjectTestStringifierOperationNamedToStringConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierOperationNamedToStringConstructor):
(WebCore::jsTestGlobalObjectTestStringifierReadOnlyAttributeConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierReadOnlyAttributeConstructor):
(WebCore::jsTestGlobalObjectTestStringifierReadWriteAttributeConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierReadWriteAttributeConstructor):
(WebCore::jsTestGlobalObjectTestTypedefsConstructor):
(WebCore::setJSTestGlobalObjectTestTypedefsConstructor):
(WebCore::jsTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkletGlobalScopeConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestGlobalObjectInstanceFunctionRegularOperation): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestGlobalObjectConstructorFunctionEnabledAtRuntimeOperationStatic): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorld): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabled): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionTestPrivateFunction): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionTestFeatureGetSecretBoolean): Deleted.
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
(WebCore::jsTestIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestIndexedSetterNoIdentifierConstructor):
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
(WebCore::jsTestIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestIndexedSetterThrowingExceptionConstructor):
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
(WebCore::jsTestIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestIndexedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestIndexedSetterWithIdentifierPrototypeFunctionIndexedSetter): Deleted.
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceConstructor):
(WebCore::jsTestInterfaceMixinReadOnlyAttribute):
(WebCore::jsTestInterfaceMixinAttribute):
(WebCore::setJSTestInterfaceMixinAttribute):
(WebCore::jsTestInterfaceMixinCustomAttribute):
(WebCore::setJSTestInterfaceMixinCustomAttribute):
(WebCore::jsTestInterfaceMixinNodeAttribute):
(WebCore::setJSTestInterfaceMixinNodeAttribute):
(WebCore::jsTestInterfacePartialMixinAttributeFromPartial):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceReflectAttribute):
(WebCore::setJSTestInterfaceReflectAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestInterfacePrototypeFunctionEntriesCaller):
(WebCore::jsTestInterfacePrototypeFunctionMixinOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinComplexOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinCustomOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinConditionalOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinSettingsConditionalOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinResultFieldOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionPartialMixinOperationFromPartial): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionEntries): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionKeys): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionValues): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
(WebCore::jsTestInterfaceLeadingUnderscoreConstructor):
(WebCore::setJSTestInterfaceLeadingUnderscoreConstructor):
(WebCore::jsTestInterfaceLeadingUnderscoreReadonly):
- bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::jsTestIterableConstructor):
(WebCore::setJSTestIterableConstructor):
(WebCore::jsTestIterablePrototypeFunctionEntriesCaller):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestIterablePrototypeFunctionEntries): Deleted.
(WebCore::jsTestIterablePrototypeFunctionKeys): Deleted.
(WebCore::jsTestIterablePrototypeFunctionValues): Deleted.
(WebCore::jsTestIterablePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::jsTestJSBuiltinConstructorConstructor):
(WebCore::setJSTestJSBuiltinConstructorConstructor):
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom):
(WebCore::jsTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::setJSTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestJSBuiltinConstructorPrototypeFunctionTestCustomFunction): Deleted.
- bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
(WebCore::JSTestLegacyFactoryFunctionLegacyFactoryFunction::construct):
(WebCore::jsTestLegacyFactoryFunctionConstructor):
(WebCore::setJSTestLegacyFactoryFunctionConstructor):
- bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp:
(WebCore::JSTestLegacyNoInterfaceObjectPrototype::finishCreation):
(WebCore::jsTestLegacyNoInterfaceObjectReadonlyStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectReadWriteStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectReadWriteStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectCustomGetterSetterStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectCustomGetterSetterStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectNodeAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectNodeAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectConstructorStaticStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectConstructorStaticStringAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionVoidOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionThrowingOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionCustomOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectConstructorFunctionStaticOperation): Deleted.
- bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp:
(WebCore::jsTestLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestLegacyOverrideBuiltInsConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestLegacyOverrideBuiltInsPrototypeFunctionNamedItem): Deleted.
- bindings/scripts/test/JS/JSTestMapLike.cpp:
(WebCore::jsTestMapLikeConstructor):
(WebCore::setJSTestMapLikeConstructor):
(WebCore::jsTestMapLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionForEach): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionSet): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionClear): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionDelete): Deleted.
- bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp:
(WebCore::jsTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestMapLikeWithOverriddenOperationsSet):
(WebCore::setJSTestMapLikeWithOverriddenOperationsSet):
(WebCore::jsTestMapLikeWithOverriddenOperationsSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionClear): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionGet): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionHas): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionEntries): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionKeys): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionValues): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionForEach): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionDelete): Deleted.
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
(WebCore::jsTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestNamedAndIndexedSetterNoIdentifierConstructor):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
(WebCore::jsTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestNamedAndIndexedSetterThrowingExceptionConstructor):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionIndexedSetter): Deleted.
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
(WebCore::jsTestNamedDeleterNoIdentifierConstructor):
(WebCore::setJSTestNamedDeleterNoIdentifierConstructor):
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
(WebCore::jsTestNamedDeleterThrowingExceptionConstructor):
(WebCore::setJSTestNamedDeleterThrowingExceptionConstructor):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
(WebCore::jsTestNamedDeleterWithIdentifierConstructor):
(WebCore::setJSTestNamedDeleterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedDeleterWithIdentifierPrototypeFunctionNamedDeleter): Deleted.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
(WebCore::jsTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::setJSTestNamedDeleterWithIndexedGetterConstructor):
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
(WebCore::jsTestNamedGetterCallWithConstructor):
(WebCore::setJSTestNamedGetterCallWithConstructor):
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
(WebCore::jsTestNamedGetterNoIdentifierConstructor):
(WebCore::setJSTestNamedGetterNoIdentifierConstructor):
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
(WebCore::jsTestNamedGetterWithIdentifierConstructor):
(WebCore::setJSTestNamedGetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedGetterWithIdentifierPrototypeFunctionGetterName): Deleted.
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
(WebCore::jsTestNamedSetterNoIdentifierConstructor):
(WebCore::setJSTestNamedSetterNoIdentifierConstructor):
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
(WebCore::jsTestNamedSetterThrowingExceptionConstructor):
(WebCore::setJSTestNamedSetterThrowingExceptionConstructor):
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
(WebCore::jsTestNamedSetterWithIdentifierConstructor):
(WebCore::setJSTestNamedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIdentifierPrototypeFunctionNamedSetter): Deleted.
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
(WebCore::jsTestNamedSetterWithIndexedGetterConstructor):
(WebCore::setJSTestNamedSetterWithIndexedGetterConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIndexedGetterPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedSetterWithIndexedGetterPrototypeFunctionIndexedSetter): Deleted.
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::setJSTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionIndexedSetter): Deleted.
- bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:
(WebCore::jsTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
- bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesConstructor::prototypeForStructure):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::setJSTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesUnforgeableAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesInstanceFunctionUnforgeableOperation): Deleted.
- bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor::prototypeForStructure):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsUnforgeableAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsInstanceFunctionUnforgeableOperation): Deleted.
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
(WebCore::jsTestNodeConstructor):
(WebCore::setJSTestNodeConstructor):
(WebCore::jsTestNodeName):
(WebCore::setJSTestNodeName):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNodePrototypeFunctionEntriesCaller):
(WebCore::jsTestNodePrototypeFunctionTestWorkerPromise): Deleted.
(WebCore::jsTestNodePrototypeFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestNodePrototypeFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestNodePrototypeFunctionTestFeatureGetSecretBoolean): Deleted.
(WebCore::jsTestNodePrototypeFunctionToJSON): Deleted.
(WebCore::jsTestNodePrototypeFunctionEntries): Deleted.
(WebCore::jsTestNodePrototypeFunctionKeys): Deleted.
(WebCore::jsTestNodePrototypeFunctionValues): Deleted.
(WebCore::jsTestNodePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjConstructor):
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjConstructorTestStaticReadonlyObj):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::setJSTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::setJSTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::jsTestObjClampedShortAttr):
(WebCore::setJSTestObjClampedShortAttr):
(WebCore::jsTestObjEnforceRangeShortAttr):
(WebCore::setJSTestObjEnforceRangeShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::jsTestObjUsvstringAttr):
(WebCore::setJSTestObjUsvstringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::setJSTestObjTestNullableObjAttr):
(WebCore::jsTestObjLenientTestObjAttr):
(WebCore::setJSTestObjLenientTestObjAttr):
(WebCore::jsTestObjUnforgeableAttr):
(WebCore::jsTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjUsvstringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjUsvstringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjByteStringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjByteStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjStringLongRecordAttr):
(WebCore::setJSTestObjStringLongRecordAttr):
(WebCore::jsTestObjUsvstringLongRecordAttr):
(WebCore::setJSTestObjUsvstringLongRecordAttr):
(WebCore::jsTestObjStringObjRecordAttr):
(WebCore::setJSTestObjStringObjRecordAttr):
(WebCore::jsTestObjStringNullableObjRecordAttr):
(WebCore::setJSTestObjStringNullableObjRecordAttr):
(WebCore::jsTestObjStringVoidCallbackRecordAttr):
(WebCore::setJSTestObjStringVoidCallbackRecordAttr):
(WebCore::jsTestObjDictionaryAttr):
(WebCore::setJSTestObjDictionaryAttr):
(WebCore::jsTestObjNullableDictionaryAttr):
(WebCore::setJSTestObjNullableDictionaryAttr):
(WebCore::jsTestObjAnnotatedTypeInUnionAttr):
(WebCore::setJSTestObjAnnotatedTypeInUnionAttr):
(WebCore::jsTestObjAnnotatedTypeInSequenceAttr):
(WebCore::setJSTestObjAnnotatedTypeInSequenceAttr):
(WebCore::jsTestObjImplementationEnumAttr):
(WebCore::setJSTestObjImplementationEnumAttr):
(WebCore::jsTestObjMediaDevices):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::setJSTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedUSVStringAttr):
(WebCore::setJSTestObjReflectedUSVStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedUSVURLAttr):
(WebCore::setJSTestObjReflectedUSVURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjEnabledAtRuntimeAttribute):
(WebCore::setJSTestObjEnabledAtRuntimeAttribute):
(WebCore::jsTestObjConstructorEnabledAtRuntimeAttributeStatic):
(WebCore::setJSTestObjConstructorEnabledAtRuntimeAttributeStatic):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::jsTestObjCustomAttr):
(WebCore::setJSTestObjCustomAttr):
(WebCore::jsTestObjOnfoo):
(WebCore::setJSTestObjOnfoo):
(WebCore::jsTestObjOnwebkitfoo):
(WebCore::setJSTestObjOnwebkitfoo):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::setJSTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjCachedAttribute3):
(WebCore::jsTestObjAnyAttribute):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::jsTestObjObjectAttribute):
(WebCore::setJSTestObjObjectAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::setJSTestObjMutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::setJSTestObjStrawberry):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::setJSTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::setJSTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringSettableAttribute):
(WebCore::setJSTestObjNullableStringSettableAttribute):
(WebCore::jsTestObjNullableUSVStringSettableAttribute):
(WebCore::setJSTestObjNullableUSVStringSettableAttribute):
(WebCore::jsTestObjNullableByteStringSettableAttribute):
(WebCore::setJSTestObjNullableByteStringSettableAttribute):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::setJSTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjTestReadOnlyVoidPromiseAttribute):
(WebCore::jsTestObjTestReadOnlyPromiseAttribute):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::setJSTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::setJSTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjStringifierAttribute):
(WebCore::setJSTestObjStringifierAttribute):
(WebCore::jsTestObjConditionallyExposedToWindowAttribute):
(WebCore::setJSTestObjConditionallyExposedToWindowAttribute):
(WebCore::jsTestObjConditionallyExposedToWorkerAttribute):
(WebCore::setJSTestObjConditionallyExposedToWorkerAttribute):
(WebCore::jsTestObjConditionallyExposedToWindowAndWorkerAttribute):
(WebCore::setJSTestObjConditionallyExposedToWindowAndWorkerAttribute):
(WebCore::callJSTestObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionEnabledAtRuntimeOperationStatic): Deleted.
(WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): Deleted.
(WebCore::jsTestObjPrototypeFunctionWorldSpecificMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestFeatureGetSecretBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionUndefinedMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionByteMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionOctetMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionLongMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionObjMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Deleted.
(WebCore::jsTestObjInstanceFunctionUnforgeableMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithXPathNSResolverParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionNullableStringMethod): Deleted.
(WebCore::jsTestObjConstructorFunctionNullableStringStaticMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionNullableStringSpecialMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithStandaloneEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArgAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableUSVStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableByteStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithRecord): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithExceptionReturningLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithExceptionReturningObject): Deleted.
(WebCore::jsTestObjPrototypeFunctionCustomMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionPrivateMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionPublicAndPrivateMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Deleted.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithDocumentArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithCallerDocumentArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithCallerWindowArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArgAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalDoubleIsNaN): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalFloatIsNaN): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLongIsZero): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLongIsZero): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmpty): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanIsFalse): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAny): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalObject): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapper): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapperIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalXPathNSResolver): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalRecord): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalPromise): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionAndOptionalArg): Deleted.
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg): Deleted.
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithDistinguishingUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWith2DistinguishingUnions): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithNonDistinguishingUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithOptionalUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableNonDistinguishingParameter): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethod): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethod2): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampOnOptional): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRange): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeOnOptional): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionOperationWithOptionalUnionParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetElementById): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert1): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert2): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert3): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert4): Deleted.
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionOrange): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicUnionMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionAny): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithFloatArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithOptionalIntArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestCustomPromiseFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticCustomPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestCustomReturnsOwnPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnsOwnPromiseAndPromiseProxyFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalOverload): Deleted.
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload): Deleted.
(WebCore::jsTestObjPrototypeFunctionAttachShadowRoot): Deleted.
(WebCore::jsTestObjPrototypeFunctionOperationWithExternalDictionaryParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionBufferSourceParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionLegacyCallerNamed): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimization): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimizationWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWorkerFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowAndWorkerFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestOperationConditional.cpp:
(WebCore::jsTestOperationConditionalConstructor):
(WebCore::setJSTestOperationConditionalConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestOperationConditionalPrototypeFunctionNonConditionalOperation): Deleted.
(WebCore::jsTestOperationConditionalPrototypeFunctionConditionalOperation): Deleted.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::jsTestOverloadedConstructorsConstructor):
(WebCore::setJSTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::construct):
(WebCore::jsTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::setJSTestOverloadedConstructorsWithSequenceConstructor):
- bindings/scripts/test/JS/JSTestPluginInterface.cpp:
(WebCore::jsTestPluginInterfaceConstructor):
(WebCore::setJSTestPluginInterfaceConstructor):
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
(WebCore::JSTestPromiseRejectionEventConstructor::construct):
(WebCore::jsTestPromiseRejectionEventConstructor):
(WebCore::setJSTestPromiseRejectionEventConstructor):
(WebCore::jsTestPromiseRejectionEventPromise):
(WebCore::jsTestPromiseRejectionEventReason):
- bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp:
(WebCore::jsTestReadOnlyMapLikeConstructor):
(WebCore::setJSTestReadOnlyMapLikeConstructor):
(WebCore::jsTestReadOnlyMapLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp:
(WebCore::jsTestReadOnlySetLikeConstructor):
(WebCore::setJSTestReadOnlySetLikeConstructor):
(WebCore::jsTestReadOnlySetLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestReadOnlySetLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionForEach): Deleted.
- bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp:
(WebCore::jsTestReportExtraMemoryCostConstructor):
(WebCore::setJSTestReportExtraMemoryCostConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionFunction): Deleted.
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionFunctionReturning): Deleted.
- bindings/scripts/test/JS/JSTestSetLike.cpp:
(WebCore::jsTestSetLikeConstructor):
(WebCore::setJSTestSetLikeConstructor):
(WebCore::jsTestSetLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSetLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionForEach): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionAdd): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionClear): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionDelete): Deleted.
- bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp:
(WebCore::jsTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestSetLikeWithOverriddenOperationsAdd):
(WebCore::setJSTestSetLikeWithOverriddenOperationsAdd):
(WebCore::jsTestSetLikeWithOverriddenOperationsSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionDelete): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionHas): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionEntries): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionKeys): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionValues): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionForEach): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionClear): Deleted.
- bindings/scripts/test/JS/JSTestStringifier.cpp:
(WebCore::jsTestStringifierConstructor):
(WebCore::setJSTestStringifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
(WebCore::jsTestStringifierAnonymousOperationConstructor):
(WebCore::setJSTestStringifierAnonymousOperationConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierAnonymousOperationPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
(WebCore::jsTestStringifierNamedOperationConstructor):
(WebCore::setJSTestStringifierNamedOperationConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierNamedOperationPrototypeFunctionIdentifier): Deleted.
(WebCore::jsTestStringifierNamedOperationPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
(WebCore::jsTestStringifierOperationImplementedAsConstructor):
(WebCore::setJSTestStringifierOperationImplementedAsConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierOperationImplementedAsPrototypeFunctionIdentifier): Deleted.
(WebCore::jsTestStringifierOperationImplementedAsPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
(WebCore::jsTestStringifierOperationNamedToStringConstructor):
(WebCore::setJSTestStringifierOperationNamedToStringConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierOperationNamedToStringPrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
(WebCore::jsTestStringifierReadOnlyAttributeConstructor):
(WebCore::setJSTestStringifierReadOnlyAttributeConstructor):
(WebCore::jsTestStringifierReadOnlyAttributeIdentifier):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierReadOnlyAttributePrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
(WebCore::jsTestStringifierReadWriteAttributeConstructor):
(WebCore::setJSTestStringifierReadWriteAttributeConstructor):
(WebCore::jsTestStringifierReadWriteAttributeIdentifier):
(WebCore::setJSTestStringifierReadWriteAttributeIdentifier):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierReadWriteAttributePrototypeFunctionToString): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::jsTestTypedefsConstructor):
(WebCore::setJSTestTypedefsConstructor):
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsSerializedScriptValue):
(WebCore::setJSTestTypedefsSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsAttributeWithClamp):
(WebCore::setJSTestTypedefsAttributeWithClamp):
(WebCore::jsTestTypedefsAttributeWithClampInTypedef):
(WebCore::setJSTestTypedefsAttributeWithClampInTypedef):
(WebCore::jsTestTypedefsBufferSourceAttr):
(WebCore::setJSTestTypedefsBufferSourceAttr):
(WebCore::jsTestTypedefsDomTimeStampAttr):
(WebCore::setJSTestTypedefsDomTimeStampAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestTypedefsPrototypeFunctionFunc): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionSequenceOfNullablesArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfNullablesArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfUnionsArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionUnionArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampInTypedef): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionPointFunction): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionStringSequenceFunction): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionStringSequenceFunction2): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithException): Deleted.
- bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:
(WebCore::jsWorkerGlobalScopeConstructor):
(WebCore::setJSWorkerGlobalScopeConstructor):
(WebCore::jsWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::setJSWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::jsWorkerGlobalScopeTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSWorkerGlobalScopeTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsWorkerGlobalScopeTestNodeConstructor):
(WebCore::setJSWorkerGlobalScopeTestNodeConstructor):
(WebCore::jsWorkerGlobalScopeTestObjectConstructor):
(WebCore::setJSWorkerGlobalScopeTestObjectConstructor):
(WebCore::jsWorkerGlobalScopeTestPromiseRejectionEventConstructor):
(WebCore::setJSWorkerGlobalScopeTestPromiseRejectionEventConstructor):
- bindings/scripts/test/JS/JSWorkletGlobalScope.cpp:
(WebCore::jsWorkletGlobalScopeConstructor):
(WebCore::setJSWorkletGlobalScopeConstructor):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::JSC_DEFINE_HOST_FUNCTION):
(JSC::Bindings::callObjCFallbackObject): Deleted.
- bridge/runtime_array.cpp:
(JSC::arrayLengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::lengthGetter): Deleted.
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
(JSC::methodLengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::RuntimeMethod::lengthGetter): Deleted.
(JSC::callRuntimeMethod): Deleted.
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::fallbackObjectGetter):
(JSC::Bindings::fieldGetter):
(JSC::Bindings::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::JSC_DEFINE_HOST_FUNCTION):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):
(JSC::Bindings::throwRuntimeObjectInvalidAccessError):
(JSC::Bindings::RuntimeObject::fallbackObjectGetter): Deleted.
(JSC::Bindings::RuntimeObject::fieldGetter): Deleted.
(JSC::Bindings::RuntimeObject::methodGetter): Deleted.
(JSC::Bindings::callRuntimeObject): Deleted.
(JSC::Bindings::callRuntimeConstructor): Deleted.
(JSC::Bindings::RuntimeObject::throwInvalidAccessError): Deleted.
- bridge/runtime_object.h:
Source/WebKit:
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSC_DEFINE_HOST_FUNCTION):
(WebKit::callMethod): Deleted.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSC_DEFINE_HOST_FUNCTION):
(WebKit::callNPJSObject): Deleted.
(WebKit::constructWithConstructor): Deleted.
Source/WTF:
Rename JSC_HOST_CALL to JSC_HOST_CALL_ATTRIBUTE, and introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION.
We also introduce JSC_ANNOTATE_HOST_FUNCTION if the function is not defined as free-function[1].
[1]: https://stackoverflow.com/questions/4861914/what-is-the-meaning-of-the-term-free-function-in-c
- wtf/PlatformCallingConventions.h:
- 2:29 PM Changeset in webkit [267593] by
-
- 7 edits1 delete in trunk
Unreviewed, reverting r267589.
Broke document.visibilityState when coming out of back/forward
cache
Reverted changeset:
"visibilitychange:hidden doesn't fire during page navigations"
https://bugs.webkit.org/show_bug.cgi?id=151234
https://trac.webkit.org/changeset/267589
- 2:26 PM Changeset in webkit [267592] by
-
- 18 edits in trunk
Add an experimental feature flag for CSS individual transform properties
https://bugs.webkit.org/show_bug.cgi?id=216271
<rdar://problem/68914539>
Reviewed by Dean Jackson.
Source/WebCore:
- page/Settings.yaml:
Source/WebKit:
- Shared/WebPreferencesExperimental.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
(-[WebPreferences cssIndividualTransformPropertiesEnabled]):
(-[WebPreferences CSSIndividualTransformPropertiesEnabled]):
- WebView/WebPreferencesExperimental.yaml:
- WebView/WebPreferencesPrivate.h:
Source/WebKitLegacy/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::CSSIndividualTransformPropertiesEnabled):
(WebPreferences::setCSSIndividualTransformPropertiesEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
- 1:36 PM Changeset in webkit [267591] by
-
- 21 edits in trunk/Source
Get rid of AudioNode::RefType
https://bugs.webkit.org/show_bug.cgi?id=216945
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/CachedTypes.cpp:
(JSC::CachedRefPtr::decode const):
Source/WebCore:
Previously, the node had ref()/deref() function taking a RefType parameter.
The RefType would be used to determine which counter should be incremented
or decremented: either m_normalRefCount or m_connectionRefCount.
In a previous patch, I have already ported code that was calling ref() / deref()
explicitly with RefTypeNormal to use RefPtr<> instead. This patch goes further by:
- Dropping the RefType parameter to ref() / deref(). ref() / deref() now increment or decrement m_normalRefCount only. Clients are expected to use RefPtr to handle ref counting.
- Introduce new incrementConnectionCount() / decrementConnectionCount() to increment or decrement m_connectionRefCount. To reduce the chance of leakage, clients should not call these functions directly anymore. Instead, they use use the new AudioConnectionRefPtr<> pointer type to handle the connection ref counting for them. AudioConnectionRefPtr<> is a RefPtr<> which special traits causing incrementConnectionCount() and decrementConnectionCount() to get called on the AudioNode instead of ref() and deref().
I believe this new design is a bit simpler to reason about and less prone to leaks.
There is no longer any code explicitly ref'ing or deref'ing the AudioNodes. Instead,
RefPtr<> or AudioConnectionRefPtr<> is used to increment/decrement the right internal
count.
No new tests, no Web-facing behavior change.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setPannerNode):
(WebCore::AudioBufferSourceNode::clearPannerNode):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::disableOutputsIfNecessary):
(WebCore::AudioNode::incrementConnectionCount):
(WebCore::AudioNode::decrementConnectionCount):
(WebCore::AudioNode::decrementConnectionCountWithLock):
(WebCore::AudioNode::markNodeForDeletionIfNecessary):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::derefWithLock):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNodeConnectionRefDerefTraits::refIfNotNull):
(WebCore::AudioNodeConnectionRefDerefTraits::derefIfNotNull):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::connect):
(WebCore::AudioNodeInput::disconnect):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::propagateChannelCount):
(WebCore::AudioNodeOutput::addInput):
(WebCore::AudioNodeOutput::disconnectAllInputs):
(WebCore::AudioNodeOutput::disable):
(WebCore::AudioNodeOutput::enable):
- Modules/webaudio/AudioNodeOutput.h:
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::~BaseAudioContext):
(WebCore::BaseAudioContext::refNode):
(WebCore::BaseAudioContext::derefNode):
(WebCore::BaseAudioContext::derefUnfinishedSourceNodes):
(WebCore::BaseAudioContext::addDeferredDecrementConnectionCount):
(WebCore::BaseAudioContext::handlePostRenderTasks):
(WebCore::BaseAudioContext::handleDeferredDecrementConnectionCounts):
- Modules/webaudio/BaseAudioContext.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::process):
Source/WTF:
Add third template parameter to RefPtr allowing to define the traits
from incrementing / decrementing the refcount. The default traits
call ref() / deref() but this can now be customized to call other
functions.
- wtf/CompactRefPtrTuple.h:
- wtf/Forward.h:
- wtf/RefPtr.h:
(WTF::DefaultRefDerefTraits::refIfNotNull):
(WTF::DefaultRefDerefTraits::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):
(WTF::V>::RefPtr):
(WTF::V>::leakRef):
(WTF::=):
(WTF::V>::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::static_pointer_cast):
(WTF::adoptRef):
(WTF::is):
- 1:19 PM Changeset in webkit [267590] by
-
- 3 edits in trunk/Source/WebCore
Simplify SVGTests.hasExtension idl
https://bugs.webkit.org/show_bug.cgi?id=216984
Patch by Rob Buis <rbuis@igalia.com> on 2020-09-25
Reviewed by Sam Weinig.
Simplify SVGTests.hasExtension idl by removing optional and default parameter.
Skipping the parameter will now result in the parameter being a null string,
which gives the same behaviour as before as the method just checks
against non null namespaces.
[1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
- page/DOMWindow.idl:
- svg/SVGTests.idl:
- 1:11 PM Changeset in webkit [267589] by
-
- 7 edits30 adds in trunk
visibilitychange:hidden doesn't fire during page navigations
https://bugs.webkit.org/show_bug.cgi?id=151234
<rdar://problem/23688763>
Reviewed by Darin Adler and Ryosuke Niwa.
LayoutTests/imported/w3c:
Import page-visibility WPT tests from upstream.
- resources/import-expectations.json:
- web-platform-tests/page-visibility/*: Added.
Source/WebCore:
Fire a visibilitychange during document unload, as per the specification:
- https://www.w3.org/TR/page-visibility/#reacting-to-visibilitychange-changes
- https://html.spec.whatwg.org/multipage/browsing-the-web.html#unloading-document-visibility-change-steps
Tests: imported/w3c/web-platform-tests/page-visibility/idlharness.window.html
imported/w3c/web-platform-tests/page-visibility/iframe-unload.html
imported/w3c/web-platform-tests/page-visibility/onvisibilitychange.html
imported/w3c/web-platform-tests/page-visibility/test_attributes_exist.html
imported/w3c/web-platform-tests/page-visibility/test_child_document.html
imported/w3c/web-platform-tests/page-visibility/test_default_view.html
imported/w3c/web-platform-tests/page-visibility/test_read_only.html
imported/w3c/web-platform-tests/page-visibility/unload-bubbles.html
imported/w3c/web-platform-tests/page-visibility/unload.html
- dom/Document.cpp:
(WebCore::Document::visibilityState const):
- dom/Document.h:
(WebCore::Document::setIsUnloadingOrUnloaded):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
- 12:49 PM Changeset in webkit [267588] by
-
- 7 edits in trunk
make_names.pl no longer needs C preprocessor
https://bugs.webkit.org/show_bug.cgi?id=216953
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitCompilerFlags.cmake: Removed CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS which was used only for make_names.pl.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- WebCoreMacros.cmake: Changed GENERATE_DOM_NAMES from a macro to a function so that list(POP_FRONT ARGN var) works as exepected.
- dom/make_names.pl: Removed --preprocessor and --extraDefines options.
(readNames):
(readAttrs):
(readTags):
(buildConstructorMap):
(printConstructorSignature):
(printConstructorInterior):
(printConstructors):
(printFunctionTable):
(printJSElementIncludes):
(printElementIncludes):
(printConditionalElementIncludes):
(usesDefaultJSWrapper):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(preprocessorCommand): Deleted.
- 12:03 PM Changeset in webkit [267587] by
-
- 3 edits2 adds in trunk
[LFC][MarginCollapsing] Only inflow boxes collapse their quirk margins with their parents
https://bugs.webkit.org/show_bug.cgi?id=216981
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::shouldCollapseMarginBeforeWithParentMarginBefore const):
LayoutTests:
- fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating-expected.html: Added.
- fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html: Added.
- 12:03 PM Changeset in webkit [267586] by
-
- 2 edits in trunk/Tools
REGRESSION (r267516):
--use-gpu-processno longer enables GPU process when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=216980
Reviewed by Tim Horton.
Rename
UseGPUProcessForMediaandRenderCanvasInGPUProcessEnabled, and additionally enable a few internal
feature flags:UseGPUProcessForWebGLEnabled,UseGPUProcessForDOMRenderingEnabled, and
CaptureVideoInGPUProcessEnabled.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 11:21 AM Changeset in webkit [267585] by
-
- 6 edits1 add in branches/safari-610-branch
Cherry-pick r266813. rdar://problem/69582551
OutOfBoundsSaneChain operations should use their own heap locations
https://bugs.webkit.org/show_bug.cgi?id=216328
<rdar://problem/68568039>
Reviewed by Keith Miller.
JSTests:
- stress/out-of-bounds-sane-chain-need-their-own-heap-location.js: Added. (foo):
Source/JavaScriptCore:
There is code in local CSE that does some basic bounds check elimination
for PutByVal. It does this analysis by seeing if a particular heap location
is already defined, and if so, it eliminates the bounds check for the
PutByVal. This doesn't work for OutOfBoundsSaneChain for the obvious reason
that these GetByVals are not proven to be in bounds. So GetByVal's in the
OutOfBoundsSaneChain mode reusing non OutOfBoundsSaneChain heap locations
can lead to a bug where we mistakenly remove a bounds check. The fix is to
have all OutOfBoundsSaneChain operations use distinct heaps, and for CSE to
not query those heaps.
- dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::isAnySaneChain const): Deleted.
- dfg/DFGClobberize.h: (JSC::DFG::clobberize):
- dfg/DFGHeapLocation.cpp: (WTF::printInternal):
- dfg/DFGHeapLocation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:21 AM Changeset in webkit [267584] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r267106. rdar://problem/69381319
CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>
Reviewed by Eric Carlson.
Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:20 AM Changeset in webkit [267583] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266765. rdar://problem/69382910
[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215353
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-08
Reviewed by Geoffrey Garen.
This patch reverts r265780 and goes in the opposite direction: allocating
lots and lots of objects, then proving that the number of live objects
did not grow a lot.
GCController can be conservative sometimes and leaves some objects here
and there. So we should not be checking that *all* the objects were freed
to verify there was no leak in allocating the SVG properties objects.
Instead we can check for an end-to-end test the memory did not grow a lot
despite the huge number of allocations.
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:20 AM Changeset in webkit [267582] by
-
- 3 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266689. rdar://problem/69382883
[MotionMark - Multiply] Web process spends ~1% of total samples in PropertyCascade::resolveDirectionAndWritingMode
https://bugs.webkit.org/show_bug.cgi?id=216223
Reviewed by Darin Adler.
A few subtests in MotionMark (Leaves, Focus, Design, and especially Multiply) spend large amounts of time in
style resolution (Document::resolveStyle) due to constant style changes across many elements during every
frame. In Multiply, ~3-4% of the time underneathDocument::resolveStyleis spent resolving direction and
writing modes insidePropertyCascade::resolveDirectionAndWritingMode(i.e., ~2.3 million invocations). This
helper function is responsible for computing the text direction and CSS writing mode that is used to resolve
direction-aware CSS properties (which are enumerated inCSSProperty::isDirectionAwareProperty). Resolving the
direction and writing mode involves iterating over all of the matched CSS properties (m_matchResult) in the
property cascade in search of CSS properties for writing and direction, which can be relatively expensive when
there are lots of properties in the cascade.
However, if there are no direction-aware CSS properties in the cascade, this work can actually be elided; to
achieve this, we can store the inheritedDirectioninm_direction, and then lazily resolve it if needed.
I measured this locally to yield a little under ~1% in the Multiply subtest in MotionMark. Otherwise, there is
no change in behavior; see below for more details.
- style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::PropertyCascade): (WebCore::Style::PropertyCascade::set):
If we encounter a direction-aware CSS property, then use
direction()to ensure that the direction and writing
mode are resolved.
(WebCore::Style::PropertyCascade::direction const):
Make this getter call
resolveDirectionAndWritingModeif needed.
- style/PropertyCascade.h:
Add a new
boolmember to keep track of whether or not the CSS direction has not yet been resolved. Note that
since this member variable fits within the padding afterDirection m_direction;, this class is still the same
size.
(WebCore::Style::PropertyCascade::direction const): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:20 AM Changeset in webkit [267581] by
-
- 4 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266353. rdar://problem/69382920
Optimize the implementation of TransformationMatrix::rotate(double)
https://bugs.webkit.org/show_bug.cgi?id=215994
Reviewed by Tim Horton.
TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which
has a fast path for the case where we're rotating about the z-axis. However, we can make this *slightly* faster
by omitting the hypotenuse computation, several floating point comparisons, and several assignments in this case
because we already know that we're just rotating about the z-axis.
This is a small (but measurable) improvement on the Multiply subtest of MotionMark, which applies a little over
3 million rotation transformations over the course of 30 seconds.
- platform/graphics/transforms/RotateTransformOperation.h:
Instead of calling
rotate3d, just haverotatedirectly callmultiplywith the following
TransformationMatrix:
`
[[ cos(z) sin(z) 0 0 ]
[ -sin(z) cos(z) 0 0 ]
[ 0 0 1 0 ]
[ 0 0 0 1 ]]
`
...wherezis the angle of rotation, in radians.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rotate):
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::rotate): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:20 AM Changeset in webkit [267580] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266198. rdar://problem/69382901
Avoid unnecessarily copying a Vector in WebCore::transformsForValue
https://bugs.webkit.org/show_bug.cgi?id=215858
Reviewed by Tim Horton.
Avoid copying the
VectorofTransformOperations in this helper function by directly appending newly created
transform operations to the givenTransformOperations. This does, however, mean that we need to clear these
items in the case where conversion fails and we return false.
- css/TransformFunctions.cpp: (WebCore::transformsForValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:55 AM Changeset in webkit [267579] by
-
- 5 edits1 add in trunk/Tools
results.webkit.org: Use s3 for cold storage
https://bugs.webkit.org/show_bug.cgi?id=216662
<rdar://problem/69092010>
Rubber-stamped by Aakash Jain.
- Scripts/libraries/resultsdbpy/resultsdbpy/init.py:
- Scripts/libraries/resultsdbpy/resultsdbpy/model/archive_context.py:
(ArchiveContext.init): Differentiate between cache storage and long-term storage of archives.
(ArchiveContext.enter): Connect to the cold storage archive, if one is available.
(ArchiveContext.exit): Disconnect from the cold storage archive, if applicable.
(ArchiveContext.register): Save to cold storage instead of cache storage by default.
(ArchiveContext.find_archive):
- Scripts/libraries/resultsdbpy/resultsdbpy/model/model.py:
(Model.init): Pass S3 credentials to ArchiveContext.
- Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py: Added.
(S3Archiver):
(S3Archiver.Credentials):
(S3Archiver.init): Connect to S3 and configure our bucket.
(S3Archiver._cipher): Construct new AES cipher, if a key was provided.
(S3Archiver.enter): Create S3 resource, if one is not available.
(S3Archiver.exit): Teardown S3 resource.
(S3Archiver.save): Save an archive to S3 by it's hash.
(S3Archiver.retrieve): Retreive an archive from S3 by its hash.
- Scripts/libraries/resultsdbpy/setup.py: Add boto3.
- 10:47 AM Changeset in webkit [267578] by
-
- 54 edits2 copies4 adds16 deletes in trunk
Bug 216702 - Implement the CSS math-style property
https://bugs.webkit.org/show_bug.cgi?id=216702
Patch by Frederic Wang <fwang@igalia.com> on 2020-09-25
Reviewed by Rob Buis.
LayoutTests/imported/w3c:
Rebaseline tests to take into account new PASS results.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt:
- web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt:
- web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt:
- web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt:
- web-platform-tests/mathml/relations/css-styling/displaystyle-2-expected.txt:
- web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
Source/WebCore:
This patch implements the math-style property [1][2] and uses it to map MathML's displaystyle
attribute to style, instead of using an internal inheritance mechanism. In addition, four
changes are made to improve the MathML implementation:
- Support for the displaystyle attribute on all the MathML elements.
- Better handling of dynamic update of displaystyle.
- RenderMathMLUnderOver uses its own displaystyle (rather than the one of the core operator
at its base in order) to determine whether to move its under/over scripts.
- display/displaystyle are made case-insensitive.
[1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property
[2] https://github.com/w3c/csswg-drafts/issues/5387
No new tests, already covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator MathStyle const):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/mathml.css: Implement displaystyle rules using math-style.
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute const):
(WebCore::MathMLElement::collectStyleForPresentationAttribute):
- mathml/MathMLElement.h:
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::parseAttribute):
- mathml/MathMLMathElement.h:
- mathml/MathMLPresentationElement.cpp:
(WebCore::MathMLPresentationElement::parseAttribute):
- mathml/MathMLPresentationElement.h:
- mathml/MathMLRowElement.cpp:
- mathml/MathMLRowElement.h:
- mathml/MathMLSpaceElement.h:
- mathml/MathMLTokenElement.h:
- rendering/mathml/MathMLStyle.cpp:
(WebCore::MathMLStyle::updateStyleIfNeeded):
(WebCore::MathMLStyle::resolveMathMLStyle):
- rendering/mathml/MathMLStyle.h:
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::styleDidChange):
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::fractionParameters const):
(WebCore::RenderMathMLFraction::stackParameters const):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::styleDidChange):
- rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::isLargeOperatorInDisplayStyle const):
(WebCore::RenderMathMLOperator::shouldMoveLimits const):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::verticalParameters):
- rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::shouldMoveLimits):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::mathStyle const):
(WebCore::RenderStyle::setMathStyle):
(WebCore::RenderStyle::initialMathStyle):
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
- rendering/style/StyleRareInheritedData.h:
LayoutTests:
Rebaseline tests to take into account new PASS results.
- TestExpectations:
- mathml/opentype/large-operators-displaystyle-dynamic.html: Do the dynamic change directly
after page load but do a requestAnimationFrame before completing the test.
- platform/glib/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt.
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt.
- platform/ios-13/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- 10:42 AM Changeset in webkit [267577] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
https://bugs.webkit.org/show_bug.cgi?id=216307
<rdar://problem/68565824>
Reviewed by Brian Burg.
- UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
Don't update the element if it hasn't been attached yet. It will use the latest data when attached.
- 10:19 AM Changeset in webkit [267576] by
-
- 43 edits4 adds in trunk
Add CSSConditionRule and CSSGroupingRule
https://bugs.webkit.org/show_bug.cgi?id=216855
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/css/conditional/idlharness-expected.txt:
- web-platform-tests/css/cssom/MediaList-expected.txt:
- web-platform-tests/css/cssom/cssimportrule-expected.txt:
- web-platform-tests/css/cssom/idlharness-expected.txt:
Updated expectations to expect more tests to pass.
Source/WebCore:
- CMakeLists.txt: Added CSSConditionRule.idl and CSSGroupingRule.idl.
- DerivedSources-input.xcfilelist: Updated.
- DerivedSources-output.xcfilelist: Updated.
- DerivedSources.make: Added CSSConditionRule.idl and CSSGroupingRule.idl.
- Headers.cmake: Added CSSConditionRule.h.
- Sources.txt: Add CSSConditionRule.cpp, JSCSSConditioRule.cpp,
and JSCSSGroupingRule.cpp.
- WebCore.xcodeproj/project.pbxproj: Added all the files.
- css/CSSConditionRule.cpp: Added.
- css/CSSConditionRule.h: Added.
- css/CSSConditionRule.idl: Added.
- css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::~CSSGroupingRule): Use a range-based for loop
and nullptr.
(WebCore::CSSGroupingRule::appendCSSTextForItems const): Use variadic
append to clean this up a bit.
(WebCore::CSSGroupingRule::item const): Use auto.
- css/CSSGroupingRule.h: Made m_groupRule private instead of protected.
Did some other tweaks.
- css/CSSGroupingRule.idl: Added.
- css/CSSImportRule.idl: Added [Exposed=Window], changed href to be a
USVString, added [SameObject, PutForwards=mediaText] to media
and [SameObject] to styleSheet.
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule): Derive from CSSConditionRule.
(WebCore::CSSMediaRule::mediaQueries const): Return a reference.
(WebCore::CSSMediaRule::cssText const): Streamline since we don't need a
null check.
(WebCore::CSSMediaRule::conditionText const): Added.
(WebCore::CSSMediaRule::setConditionText): Added.
(WebCore::CSSMediaRule::media const): Streamline since we don't need a
null check.
(WebCore::CSSMediaRule::reattach): Ditto.
- css/CSSMediaRule.h: Derive from CSSConditionRule.
- css/CSSMediaRule.idl: Derive from CSSConditionRule. Added
[Exposed=Window]. Added [SameObject, PutForwards=mediaText] to media.
Removed insertRule and deleteRule since they are now inherited from
CSSGroupingRule.
- css/CSSRule.h: Added MARGIN_RULE constant even though we don't have
that rule type. Moved inline functions out of the class body to help
clarity a bit.
- css/CSSRule.idl: Added [Exposed=Window], changed a few things to match
the specification.
- css/CSSStyleRule.idl: Added [Exposed=Window]. Added [SameObject]
to style.
- css/CSSStyleSheet.idl: Added [Exposed=Window].
- css/CSSSupportsRule.cpp:
(WebCore::CSSSupportsRule::CSSSupportsRule): Derive from CSSConditionRule.
(WebCore::CSSSupportsRule::create): Added.
(WebCore::CSSSupportsRule::cssText const): Use variadic append.
(WebCore::CSSSupportsRule::conditionText const): Updated to use groupRule.
(WebCore::CSSSupportsRule::setConditionText): Added. Not implemented yet.
- css/CSSSupportsRule.h: Derive from CSSConditionRule.
- css/CSSSupportsRule.idl: Derive from CSSConditionRule.
Added [Exposed=Window].
- css/MediaList.cpp:
(WebCore::MediaQuerySet::set): Use move instead of swap.
- css/MediaList.idl: Added [Exposed=Window] and marked mediaText as
the stringifier.
- css/StyleRule.cpp:
(WebCore::StyleRule::create): Moved here from the header.
(WebCore::StyleRule::copy const): Ditto.
(WebCore::StyleRulePage::create): Ditto.
(WebCore::StyleRuleGroup::StyleRuleGroup): Use move instead of swap.
(WebCore::StyleRuleMedia::create): Use move instead of swap.
(WebCore::StyleRuleMedia::copy const): Moved out of the header.
(WebCore::StyleRuleSupports::StyleRuleSupports): Ditto.
(WebCore::StyleRuleSupports::create): Ditto.
(WebCore::StyleRuleNamespace::StyleRuleNamespace): Ditto.
(WebCore::StyleRuleNamespace::create): Ditto.
- css/StyleRule.h: Moved function bodies out of the class
defintiion for clarity.
- css/StyleSheet.idl: Added [Exposed=Window] and
[SameObject, PutForwards=mediaText] for media.
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule): Updated since
mediaQueries returns a reference.
- css/StyleSheetList.idl: Added [Exposed=Window].
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeMediaRule): Use WTFMove since
the create function now takes an rvalue reference.
(WebCore::CSSParserImpl::consumeSupportsRule): Ditto.
- style/RuleSet.cpp:
(WebCore::Style::RuleSet::addChildRules): Updated since mediaQueries
returns a reference.
- style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::addToDefaultStyle): Ditto.
Source/WebKitLegacy/mac:
- DOM/DOMCSS.mm:
(kitClass): Added a default case since we don't intend to list every single rule type here.
LayoutTests:
- fast/dom/domListEnumeration-expected.txt:
- fast/dom/domListEnumeration.html:
Updated since toString is now implemented and enumerable.
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/non-numeric-values-numeric-parameters.html:
Updated test and expectations since CSSMediaRule's deleteRule no longer allows omitting
the index to delete rule 0 (both non-standard and inconsistent with CSSStyleSheet).
- 10:04 AM Changeset in webkit [267575] by
-
- 9 edits16 adds in trunk/Source/WebKitLegacy
[Preferences] Start generating experimental feature preferences for legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=216909
Reviewed by Tim Horton.
Source/WebKitLegacy:
- WebKitLegacy.xcodeproj/project.pbxproj:
Add new files.
Source/WebKitLegacy/mac:
As a stepping stone to unified preferences definitions and generation, this adds
generation of "experimental feature" preferences for WebKitLegacy. The generator
is almost identical to the one in WebKit, but the templates are changed. The end
goal will be to share the preferences definition (yaml) files. In this pass, I
have copied WebPreferencesExperimental.yaml from WebKit, but change the default
values to match the existing WebKitLegacy default values (and temporarily removed
WebSQLDisabled, as WebKitLegacy has a WebSQLEnabled, and its not clear how to map
to the inverse yet). I have also imported empty versions of WebPreferences.yaml,
WebPreferencesDebug.yaml, and WebPreferencesInternal.yaml, to keep the generator
happy, these will be filled in subsequent changes or, if we decide on a good home
for them, perhaps in WTF, we can just switch to using the shared ones.
Much of the change is moving around existing getter/setters in WebPreferences
to go in their own category, with the intention to remove them when we we have
determined no more callers remain.
- Scripts: Added.
- Scripts/GeneratePreferences.rb: Added.
- Scripts/PreferencesTemplates: Added.
- Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Added.
- Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: Added.
- Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb: Added.
- WebView/WebFeature.h: Added.
- WebView/WebFeature.m: Added.
(-[WebFeature initWithKey:preferenceKey:name:details:defaultValue:hidden:]):
(-[WebFeature description]):
- WebView/WebFeatureInternal.h: Added.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
- WebView/WebPreferences.yaml: Added.
- WebView/WebPreferencesDebug.yaml: Added.
- WebView/WebPreferencesDefaultValues.h: Added.
- WebView/WebPreferencesDefaultValues.mm: Added.
- WebView/WebPreferencesExperimental.yaml: Added.
- WebView/WebPreferencesInternal.h: Added.
- WebView/WebPreferencesInternal.yaml: Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- WebView/WebViewInternal.h:
- 9:34 AM Changeset in webkit [267574] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening, land test expectations for rdar://69347249.
- platform/mac/TestExpectations:
- platform/mac/TestExpectationsRosetta:
- 9:24 AM Changeset in webkit [267573] by
-
- 3 edits in trunk/Source/WebCore
Clean up VideoLayerManagerObjC
https://bugs.webkit.org/show_bug.cgi?id=216946
Reviewed by Eric Carlson.
Remove m_videoInlineFrame. Also, change the order of some variables
and functions to put related things together.
No new tests since no functional changes.
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::didDestroyVideoLayer):
(WebCore::VideoLayerManagerObjC::setVideoFullscreenLayer):
- 9:05 AM Changeset in webkit [267572] by
-
- 5 edits2 adds in trunk
[LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue
https://bugs.webkit.org/show_bug.cgi?id=216976
Reviewed by Antti Koivisto.
Source/WebCore:
Geometry::computedHeightValue is a simple resolver function. It should not really care about
whether the box's containing block has valid vertical geometry. The callsite (where this assert is important) is already testing this condition.
Test: fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple.html
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):
(WebCore::Layout::FormattingContext::Geometry::constraintsForInFlowContent):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
LayoutTests:
- fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple-expected.html: Added.
- fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple.html: Added.
- 8:22 AM Changeset in webkit [267571] by
-
- 37 edits1 add in trunk
Reduce the reliance on PseudoElement in the animation code
https://bugs.webkit.org/show_bug.cgi?id=216931
LayoutTests/imported/w3c:
Reviewed by Antti Koivisto.
Mark a WPT test progression.
- web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt:
Source/WebCore:
<rdar://problem/69511682>
Reviewed by Antti Koivisto.
We have so far relied on PseudoElement as a foundation for supporting animations of pseudo-elements. This is not a
great choice since PseudoElement is currently limited to ::before and ::after pseudo-elements only. This patch
refactors animation-related code to rely on PseudoElement as little as possible without making changes outside
of the animation code, as a first step towards supporting animation of more pseudo-elements.
This patch introduces a new struct Styleable which combines an Element& and PseudoId. We use this struct instead
of Element objects wherever necessary in the animation code. On top of that, we add a PseudoId parameter to all the
Element methods wrapping access to ElementAnimationRareData and use a HashMap<PseudoId, std::unique_ptr<ElementAnimationRareData>>
to be able to separate animation data per pseudo-element.
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::removeAnimation):
(WebCore::AnimationTimeline::animationWasAddedToStyleable):
(WebCore::AnimationTimeline::animationWasRemovedFromStyleable):
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement):
(WebCore::AnimationTimeline::removeCSSAnimationCreatedByMarkup):
(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::willChangeRendererForStyleable):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForStyleable):
(WebCore::shouldConsiderAnimation):
(WebCore::AnimationTimeline::updateCSSAnimationsForStyleable):
(WebCore::keyframeEffectForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForStyleableAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForStyleable):
(WebCore::AnimationTimeline::animationWasAddedToElement): Deleted.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Deleted.
(WebCore::AnimationTimeline::willChangeRendererForElement): Deleted.
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement): Deleted.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Deleted.
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty): Deleted.
(WebCore::AnimationTimeline::updateCSSTransitionsForElement): Deleted.
- animation/AnimationTimeline.h:
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::create):
(WebCore::CSSAnimation::CSSAnimation):
- animation/CSSAnimation.h:
- animation/CSSTransition.cpp:
(WebCore::CSSTransition::create):
(WebCore::CSSTransition::CSSTransition):
- animation/CSSTransition.h:
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::owningElement const):
(WebCore::DeclarativeAnimation::disassociateFromOwningElement):
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):
- animation/DeclarativeAnimation.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationCanBeRemoved):
(WebCore::DocumentTimeline::transitionDidComplete):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::runningAnimationsForRendererAreAllAccelerated const):
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated const): Deleted.
- animation/DocumentTimeline.h:
- animation/ElementAnimationRareData.cpp:
(WebCore::ElementAnimationRareData::ElementAnimationRareData):
- animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::pseudoId const):
- animation/KeyframeEffect.cpp:
(WebCore::elementOrPseudoElementForStyleable):
(WebCore::invalidateElement):
(WebCore::KeyframeEffect::animationTimelineDidChange):
(WebCore::KeyframeEffect::updateEffectStackMembership):
(WebCore::KeyframeEffect::targetStyleable const):
(WebCore::KeyframeEffect::setTarget):
(WebCore::KeyframeEffect::setPseudoElement):
(WebCore::KeyframeEffect::didChangeTargetStyleable):
(WebCore::KeyframeEffect::invalidate):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::didChangeTargetElementOrPseudoElement): Deleted.
- animation/KeyframeEffect.h:
- animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::addEffect):
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::effectTargetDidChange):
(WebCore::WebAnimation::persist):
(WebCore::WebAnimation::commitStyles):
- animation/WebAnimation.h:
- animation/WebAnimationUtilities.cpp:
(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder):
(WebCore::compareCSSTransitions):
(WebCore::compareCSSAnimations):
- dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
(WebCore::Element::animationRareData const):
(WebCore::Element::ensureAnimationRareData):
(WebCore::Element::keyframeEffectStack const):
(WebCore::Element::ensureKeyframeEffectStack):
(WebCore::Element::hasKeyframeEffects const):
(WebCore::Element::applyKeyframeEffects):
(WebCore::Element::animations const):
(WebCore::Element::hasCompletedTransitionsForProperty const):
(WebCore::Element::hasRunningTransitionsForProperty const):
(WebCore::Element::hasRunningTransitions const):
(WebCore::Element::ensureAnimations):
(WebCore::Element::animationsCreatedByMarkup):
(WebCore::Element::setAnimationsCreatedByMarkup):
(WebCore::Element::ensureCompletedTransitionsByProperty):
(WebCore::Element::ensureRunningTransitionsByProperty):
(WebCore::Element::lastStyleChangeEventStyle const):
(WebCore::Element::setLastStyleChangeEventStyle):
(WebCore::Element::getAnimations):
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::useTypes const):
(WebCore::ElementRareData::animationRareData const):
(WebCore::ElementRareData::ensureAnimationRareData):
(WebCore::ElementRareData::elementAnimationRareData): Deleted.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::clearHostElement):
(WebCore::PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasRunningAcceleratedAnimations const):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
- style/StyleTreeResolver.h:
- style/Styleable.h: Added.
(WebCore::Styleable::Styleable):
(WebCore::Styleable::fromElement):
(WebCore::Styleable::fromRenderer):
(WebCore::Styleable::operator== const):
(WebCore::Styleable::operator!= const):
(WebCore::Styleable::keyframeEffectStack const):
(WebCore::Styleable::ensureKeyframeEffectStack const):
(WebCore::Styleable::hasKeyframeEffects const):
(WebCore::Styleable::applyKeyframeEffects const):
(WebCore::Styleable::animations const):
(WebCore::Styleable::hasCompletedTransitionsForProperty const):
(WebCore::Styleable::hasRunningTransitionsForProperty const):
(WebCore::Styleable::hasRunningTransitions const):
(WebCore::Styleable::ensureAnimations const):
(WebCore::Styleable::ensureCompletedTransitionsByProperty const):
(WebCore::Styleable::ensureRunningTransitionsByProperty const):
(WebCore::Styleable::animationsCreatedByMarkup const):
(WebCore::Styleable::setAnimationsCreatedByMarkup const):
(WebCore::Styleable::lastStyleChangeEventStyle const):
(WebCore::Styleable::setLastStyleChangeEventStyle const):
LayoutTests:
<rdar://problem/69511682>
Reviewed by Antti Koivisto.
Update a couple of tests which relied on an internals method to get a pseudo element and instead use
the Web Animations API to determine whether a given animation targets a pseudo-element. This has the
added benefit of having the same code run in a testing environment as in a regular browser.
- fast/css-generated-content/pseudo-animation.html:
- fast/css-generated-content/pseudo-transition.html:
- 8:17 AM Changeset in webkit [267570] by
-
- 1 edit97 adds in trunk/LayoutTests/imported/w3c
Import WPT tests for css/css-transforms/animation and css/css-transforms/parsing
https://bugs.webkit.org/show_bug.cgi?id=216973
Reviewed by Sam Weinig.
- web-platform-tests/css/css-transforms/animation/composited-transform-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/composited-transform.html: Added.
- web-platform-tests/css/css-transforms/animation/list-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/list-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/matrix-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/matrix-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/perspective-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/perspective-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/perspective-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/perspective-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/perspective-origin-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/perspective-origin-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/rotate-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/rotate-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/rotate-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/scale-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/scale-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/scale-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/scale-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-001-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-001.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-002-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-002.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-003-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-003.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-004-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-004.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-005.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-006-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-006.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-matrix-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-matrix-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-origin-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-origin-interpolation.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-perspective-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-perspective-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-rotate-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-rotate-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-scale-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-scale-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-skew-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-skew-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-translate-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/transform-translate-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/translate-composition-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/translate-composition.html: Added.
- web-platform-tests/css/css-transforms/animation/translate-interpolation-expected.txt: Added.
- web-platform-tests/css/css-transforms/animation/translate-interpolation.html: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-computed.html: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/backface-visibility-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-computed-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-computed.html: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/perspective-origin-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/scale-parsing-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/scale-parsing-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/scale-parsing-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/scale-parsing-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-computed-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-computed.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-box-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-computed-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-computed.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-origin-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/transform-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/transform-valid.html: Added.
- web-platform-tests/css/css-transforms/parsing/translate-parsing-invalid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/translate-parsing-invalid.html: Added.
- web-platform-tests/css/css-transforms/parsing/translate-parsing-valid-expected.txt: Added.
- web-platform-tests/css/css-transforms/parsing/translate-parsing-valid.html: Added.
- 8:08 AM Changeset in webkit [267569] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Deny access to diagnosticd in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=216929
<rdar://problem/58496834>
Reviewed by Darin Adler.
After the change-set <https://trac.webkit.org/changeset/267498> landed, an extension to diagnostics
is issued when required, so the unconditional rule can be removed from the WebContent sandbox.
- WebProcess/com.apple.WebProcess.sb.in:
- 7:35 AM Changeset in webkit [267568] by
-
- 10 edits1 move1 delete in trunk
Implement default behavior for getUserMedia requests in case where there is no delegate set
https://bugs.webkit.org/show_bug.cgi?id=216968
Reviewed by Eric Carlson.
Source/WebKit:
In case page UIDelegate is not set, make the getUserMedia request do its default action.
In case there is a UIDelegate but no getUserMedia specific delegates, make the getUserMedia request do its default action.
Default action is deny for getDisplayMedia and for non cocoa ports.
For cocoa ports, a prompt is shown.
Manually tested with MiniBrowser and MobileMiniBrowser.
- SourcesCocoa.txt:
- UIProcess/API/APIUIClient.h:
(API::UIClient::decidePolicyForUserMediaPermissionRequest):
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::requestUserMediaAuthorizationForFrame):
- UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.mm.
(WebKit::alertMessageText):
(WebKit::UserMediaPermissionRequestProxy::doDefaultAction):
- UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.h: Removed.
- UIProcess/UserMediaPermissionRequestProxy.cpp:
(WebKit::UserMediaPermissionRequestProxy::doDefaultAction):
- UIProcess/UserMediaPermissionRequestProxy.h:
- WebKit.xcodeproj/project.pbxproj:
Tools:
Add camera and microphone entitlements to MobileMiniBrowser.
Expose mediaDevices to web pages and use mock devices.
- MobileMiniBrowser/MobileMiniBrowser/Info.plist:
- MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
(-[WebViewController createWebView]):
- 7:17 AM Changeset in webkit [267567] by
-
- 2 edits in trunk/Tools
[webkitperl] Check for custom Flatpak user dirs in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=216959
Reviewed by Philippe Normand.
- Scripts/webkitdirs.pm: Check for WEBKIT_FLATPAK_USER_DIR
(getUserFlatpakPath):
- 7:05 AM Changeset in webkit [267566] by
-
- 3 edits in trunk/Source/WebCore
Fix LibWebRTCRtpReceiverBackend for internal build
https://bugs.webkit.org/show_bug.cgi?id=216965
Reviewed by Eric Carlson.
Move some includes to cpp file and add macros to disable deprecated warnings.
No change of behavior.
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
(WebCore::LibWebRTCRtpReceiverBackend::LibWebRTCRtpReceiverBackend):
- Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.h:
- 6:16 AM Changeset in webkit [267565] by
-
- 19 edits15 deletes in trunk/Source/WebCore
Remove Simple Line Layout
https://bugs.webkit.org/show_bug.cgi?id=216914
Reviewed by Sam Weinig.
It is already fully covered by LFC and so unused. Remove the code.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXLogger.cpp:
- accessibility/AccessibilityObjectInterface.h:
- editing/TextIterator.cpp:
- layout/Verification.cpp:
(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded): Deleted.
- layout/integration/LayoutIntegrationLineLayout.cpp:
- layout/integration/LayoutIntegrationPagination.cpp:
- rendering/ComplexLineLayout.cpp:
(WebCore::ComplexLineLayout::layoutLineBoxes):
(WebCore::ComplexLineLayout::addOverflowFromInlineChildren):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::lineCount const):
(WebCore::RenderBlockFlow::positionForPoint):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines const):
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):
(WebCore::RenderBlockFlow::ensureLineBoxes):
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
(WebCore::RenderBlockFlow::layoutSimpleLines): Deleted.
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasSimpleLineLayout const): Deleted.
(WebCore::RenderBlockFlow::simpleLineLayout const): Deleted.
(WebCore::RenderBlockFlow::simpleLineLayout): Deleted.
- rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::removeLineFragmentInfo):
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::usesComplexLineLayoutPath const):
(WebCore::RenderText::linesVisualOverflowBoundingBox const):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
(WebCore::RenderText::simpleLineLayout const): Deleted.
- rendering/RenderText.h:
- rendering/SimpleLineLayout.cpp: Removed.
- rendering/SimpleLineLayout.h: Removed.
- rendering/SimpleLineLayoutCoverage.cpp: Removed.
- rendering/SimpleLineLayoutCoverage.h: Removed.
- rendering/SimpleLineLayoutFlowContents.cpp: Removed.
- rendering/SimpleLineLayoutFlowContents.h: Removed.
- rendering/SimpleLineLayoutFunctions.cpp: Removed.
- rendering/SimpleLineLayoutFunctions.h: Removed.
- rendering/SimpleLineLayoutPagination.cpp: Removed.
- rendering/SimpleLineLayoutPagination.h: Removed.
- rendering/SimpleLineLayoutResolver.cpp: Removed.
- rendering/SimpleLineLayoutResolver.h: Removed.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp: Removed.
- rendering/SimpleLineLayoutTextFragmentIterator.h: Removed.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::clearGlyphDisplayLists):
- rendering/line/LineLayoutTraversal.cpp:
(WebCore::LineLayoutTraversal::firstTextBoxFor):
(WebCore::LineLayoutTraversal::elementBoxFor):
- rendering/line/LineLayoutTraversal.h:
- rendering/line/LineLayoutTraversalSimplePath.h: Removed.
- 4:51 AM Changeset in webkit [267564] by
-
- 6 edits1 add in trunk
DataView instances should not have own "byteLength" and "byteOffset" properties
https://bugs.webkit.org/show_bug.cgi?id=149906
Reviewed by Ross Kirsling.
JSTests:
- stress/dataview-no-own-properties.js: Added.
Source/JavaScriptCore:
Following JSDataView::getOwnPropertySlot() deletion in r266529, this patch
removes related method overrides that incorrectly reported "byteLength" and
"byteOffset" as own properties of DataView instances [1].
This change brings DataView objects in compliance with invariants of internal
methods [2] and aligns JSC with V8 and SpiderMonkey.
DataView microbenchmarks are neutral.
[1]: https://tc39.es/ecma262/#sec-properties-of-dataview-instances
[2]: https://tc39.es/ecma262/#sec-invariants-of-the-essential-internal-methods
- runtime/JSDataView.cpp:
(JSC::JSDataView::put): Deleted.
(JSC::JSDataView::defineOwnProperty): Deleted.
(JSC::JSDataView::deleteProperty): Deleted.
(JSC::JSDataView::getOwnNonIndexPropertyNames): Deleted.
- runtime/JSDataView.h:
LayoutTests:
- inspector/model/remote-object/object-expected.txt:
- 4:48 AM Changeset in webkit [267563] by
-
- 16 edits in trunk
Introduce WKWebViewConfiguration mediaCaptureEnabled
https://bugs.webkit.org/show_bug.cgi?id=216872
Reviewed by Alex Christensen.
Source/WebKit:
Add a new boolean configuration to enable/disable mediaDevices exposure.
Value is off by default.
A future patch will remove the mediaDevices WebPreferences based API, given there is no need
to enable/disable mediaDevices during the lifetime of a page.
Covered by existing tests.
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy const):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::setMediaDevicesEnabled):
(API::PageConfiguration::mediaDevicesEnabled const):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _mediaDevicesEnabled]):
(-[WKWebViewConfiguration _setMediaDevicesEnabled:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Tools:
Make use of new configuration boolean instead of mediaDevicesEnabled WebPreferences API.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate defaultConfiguration]):
- TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(TestWebKitAPI::GetDisplayMediaTest::SetUp):
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
(MediaCaptureDisabledTest::SetUp):
- TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
(MediaCaptureSimulateFailedSandbox::SetUp):
- 4:24 AM Changeset in webkit [267562] by
-
- 6 edits in trunk
[LFC][Integration] Enable on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=216928
<rdar://problem/69505961>
Reviewed by Zalan Bujtas.
.:
- Source/cmake/OptionsWin.cmake:
Source/WTF:
- wtf/PlatformEnableWinApple.h:
LayoutTests:
- platform/win/TestExpectations:
- 1:57 AM Changeset in webkit [267561] by
-
- 2 edits in trunk/JSTests
REGRESSION (r267514): mozilla-tests.yaml/js1_5/Array/regress-157652.js.mozilla* timing out
https://bugs.webkit.org/show_bug.cgi?id=216955
Unreviewed test gardening: skip mozilla/regress-157652.js in --debug.
r267514 removed special handling of sparse arrays, causing the timeout.
- mozilla/mozilla-tests.yaml:
- 1:52 AM Changeset in webkit [267560] by
-
- 13 edits in trunk/Source
Non-unified build fixes, late September 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=216950
Unreviewed build fix.
Source/JavaScriptCore:
- inspector/agents/InspectorConsoleAgent.cpp: Add missing ScriptArguments.h include.
Source/WebCore:
No new tests needed.
- Modules/webaudio/AudioNodeInput.cpp: Add missing AudioUtilities.h include.
- Modules/webaudio/AudioNodeOutput.cpp: Ditto.
- Modules/webaudio/BiquadProcessor.cpp: Ditto.
- Modules/webaudio/GainNode.cpp: Ditto.
- Modules/webaudio/PannerNode.cpp: Ditto.
- page/PerformanceUserTiming.cpp: Add missing JavaScriptCore/JSCJSValueInlines.h include.
- platform/audio/AudioUtilities.h: Add missing <cmath> include.
Source/WebKit:
- NetworkProcess/NetworkSessionCreationParameters.cpp: Arrange guards to include
WebCoreArgumentCoders.h with USE(SOUP).
- UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp: Add missing WebCoreArgumentCoders.h
include.
Sep 24, 2020:
- 10:40 PM Changeset in webkit [267559] by
-
- 4 edits in trunk
%TypedArray%.prototype.toLocaleString must make conscious use of @toString
https://bugs.webkit.org/show_bug.cgi?id=216956
Reviewed by Yusuke Suzuki.
JSTests:
- test262/expectations.yaml:
Mark four test cases as passing.
Source/JavaScriptCore:
A fascinating bug: if we override Number.prototype.toLocaleString to return { valueOf() { ... } },
then we can observe our %TypedArray%.prototype.toLocaleString resolving its element values in the wrong order.
- builtins/TypedArrayPrototype.js:
(toLocaleString):
Wrap the toLocaleString call for each element in @toString(), as the spec indicates.
- 10:02 PM Changeset in webkit [267558] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Several WPT's MathML tests are crashing in GTK/WPE Debug.
- platform/glib/TestExpectations:
- 9:49 PM Changeset in webkit [267557] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes.
https://bugs.webkit.org/show_bug.cgi?id=216957
Reviewed by Simon Fraser.
The overloaded LineBox::InlineBox constructors were representing different types of inline level boxes.
These new helper functions make it easier to figure out how to initiate LineBox::InlineBox objects depending on the type of
the inline level box.
This patch also removes an incorrect ASSERT on the inline box's height. It is okay to have a zero height inline box.
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::m_baseline):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::InlineBox::createBoxForRootInlineBox):
(WebCore::Layout::LineBox::InlineBox::createBoxForAtomicInlineLevelBox):
(WebCore::Layout::LineBox::InlineBox::createBoxForInlineBox):
- 8:19 PM Changeset in webkit [267556] by
-
- 3 edits in branches/safari-610-branch/Tools
Cherry-pick r267501. rdar://problem/69454393
Force SYSTEM_VERSION_COMPAT=0 in Webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=216895
<rdar://problem/69454393>
Reviewed by Dewei Zhu.
- Scripts/configure-xcode-for-embedded-development:
- Scripts/webkitpy/init.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:00 PM Changeset in webkit [267555] by
-
- 4 edits2 adds2 deletes in trunk/LayoutTests
[GLIB] Rebaseline and unify some expectations after r267551
Unreviewed test gardening.
This one was missing from previous mathml gardening:
- platform/glib/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt:
After r267551:
- platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
- 7:51 PM Changeset in webkit [267554] by
-
- 5 edits in trunk
%TypedArray%.prototype.sort must throw if comparator is defined and uncallable
https://bugs.webkit.org/show_bug.cgi?id=216952
Reviewed by Yusuke Suzuki.
JSTests:
- stress/typedarray-sort.js:
Fix test.
- test262/expectations.yaml:
Mark two test cases as passing.
Source/JavaScriptCore:
- builtins/TypedArrayPrototype.js:
(sort):
- 4:59 PM Changeset in webkit [267553] by
-
- 2 edits in trunk/Tools
InAppBrowserPrivacy HTTPCookie tests incorrectly use the IsInAppBrowserPrivacyEnabled NSUserDefaults value
https://bugs.webkit.org/show_bug.cgi?id=216896
<rdar://problem/69456713>
Reviewed by Brady Eidson.
The IsInAppBrowserPrivacyEnabled UserDefaults value no longer enables
App-Bound Domains, so the tests should not use it in this way.
Changing the bundle identifier using
cleanUpInAppBrowserPrivacyTestSettings() and
initializeInAppBrowserPrivacyTestSettings() is enough to
enable/disable App-Bound Domains.
This patch also adds a WKHTTPCookieStoreObserver to test setting
app-bound cookies. This ensures we don't get a false positive from
the test by being allowed to set but not retrieve app-bound cookies.
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
(-[InAppBrowserPrivacyCookieObserver cookiesDidChangeInCookieStore:]):
(setUpCookieTestWithWebsiteDataStore):
(TEST):
(setUpCookieTest): Deleted.
Changed name and simplified.
- 4:56 PM Changeset in webkit [267552] by
-
- 1 copy in tags/Safari-610.2.6.1.6
Tag Safari-610.2.6.1.6.
- 3:40 PM Changeset in webkit [267551] by
-
- 11 edits in trunk
CSS angle unit conversions should consistently use the same associativity
https://bugs.webkit.org/show_bug.cgi?id=216906
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Rebaseline tests for different rounding errors in angle unit conversions. The minmax-angle-computed test
is now passing and the webaudio tests just have slightly different results now.
- web-platform-tests/css/css-values/minmax-angle-computed-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:
Source/WebCore:
Right now we inconsistently associate our floating point math for
angle unit conversions. In particular,
conversionToCanonicalUnitsScaleFactor expects there to be a single
fixed constant we can multiply by to change units. However, the
various conversion functions in WTF are not associated in this
way. e.g. rad2deg does ((radian * 180) / pi) rather than
(radian * (180 / pi)). Since FP math is NOT associative these
produce different results. For example, 1.57 radians is
89.954373835539258 degrees in the first case but
89.954373835539243 in the second.
This patch changes the WTF functions to operate on a single scale
factor when converting to/from the canonical unit. Conversions
between non-canonical units first convert to the canonical unit
(degree). Also, conversionToCanonicalUnitsScaleFactor now gets the
scale factor from WTF to ensure we get the same associativity
everywhere.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):
Source/WTF:
Right now we inconsistently associate our floating point math for
angle unit conversions. In particular,
conversionToCanonicalUnitsScaleFactor expects there to be a single
fixed constant we can multiply by to change units. However, the
various conversion functions in WTF are not associated in this
way. e.g. rad2deg does ((radian * 180) / pi) rather than
(radian *(180 / pi)). Since FP math is NOT associative these
produce different results. For example, 1.57 radians is
89.954373835539258 degrees in the first case but
89.954373835539243 in the second.
This patch changes those WTF functions to operate on a single
scale factor when converting to/from the canonical
unit. Conversions between non-canonical units first convert to the
canonical unit (degree).
- wtf/MathExtras.h:
(deg2rad):
(rad2deg):
(deg2grad):
(grad2deg):
(deg2turn):
(turn2deg):
(rad2grad):
(grad2rad):
LayoutTests:
Rebaseline tests.
- 3:25 PM Changeset in webkit [267550] by
-
- 3 edits in trunk/Source/WebCore
[SVG2] Remove color-profile tag
https://bugs.webkit.org/show_bug.cgi?id=216910
Reviewed by Darin Adler.
SVG2 removed color-profile element.
- dom/Document.cpp:
(WebCore::Document::validateCustomElementName):
- svg/svgtags.in:
- 3:05 PM Changeset in webkit [267549] by
-
- 6 edits in trunk
JSTests:
%TypedArray%.prototype.{map, filter} should perform TypedArraySpeciesCreate correctly
https://bugs.webkit.org/show_bug.cgi?id=216938
Reviewed by Yusuke Suzuki.
- stress/typedarray-slice.js:
Fix test.
- test262/expectations.yaml:
Mark ten test cases as passing.
Source/JavaScriptCore:
%TypedArray% methods should perform TypedArraySpeciesCreate correctly
https://bugs.webkit.org/show_bug.cgi?id=216938
Reviewed by Yusuke Suzuki.
map, filter, and slice are obliged to throw when:
- this.constructor is defined but not an object
- the species constructor produces a valid typed array which is shorter than the expected length
- builtins/TypedArrayPrototype.js:
(map):
(filter):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSlice):
- 2:59 PM Changeset in webkit [267548] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.6
- 2:55 PM Changeset in webkit [267547] by
-
- 3 edits2 copies3 moves104 adds4 deletes in trunk/LayoutTests
[GLIB] Update baseline and expectations after r267531
Unreviewed test gardening.
Also unified some shared expectations between GTK and WPE.
Some flakies likely to be still around in WPE. Will garden as they
appear in the test runs.
- platform/glib/TestExpectations:
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt.
- platform/glib/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt.
- platform/glib/mathml/presentation/menclose-notation-values-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/menclose-notation-values-expected.txt.
- platform/glib/mathml/presentation/mspace-children-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/mspace-children-expected.txt.
- platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Copied from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt.
- platform/wpe/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Removed.
- platform/wpe/mathml/presentation/menclose-notation-values-expected.txt: Removed.
- platform/wpe/mathml/presentation/mspace-children-expected.txt: Removed.
- 2:47 PM Changeset in webkit [267546] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
https://bugs.webkit.org/show_bug.cgi?id=216942
<rdar://problem/69520398>
Reviewed by Brian Burg.
- UserInterface/Views/Sidebar.js:
(WI.Sidebar.prototype.insertSidebarPanel):
insertSidebarPanel was exiting early when sidebarPanel.parentSidebar matched the current sidebar,
creating a state whenthis._sidebarPanelsis an empty array.
- 2:36 PM Changeset in webkit [267545] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=216937
<rdar://problem/69149171>
Reviewed by Darin Adler.
Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
Make sure the aliasing happens for macOS so the command doesn't fail frivolously.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::performInteractionSequence):
Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
This is the case for macOS.
- 1:10 PM Changeset in webkit [267544] by
-
- 74 edits in trunk/Source/WebCore
Use more inline initialization and constexpr in WebAudio code
https://bugs.webkit.org/show_bug.cgi?id=216939
Reviewed by Darin Adler.
Use more inline initialization and constexpr in WebAudio code.
- Modules/webaudio/AudioBufferSourceNode.cpp:
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
- Modules/webaudio/AudioNodeOutput.h:
- Modules/webaudio/AudioParamTimeline.h:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/AudioSummingJunction.cpp:
(WebCore::AudioSummingJunction::AudioSummingJunction):
- Modules/webaudio/AudioSummingJunction.h:
- Modules/webaudio/BiquadDSPKernel.cpp:
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ConvolverNode.cpp:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
- Modules/webaudio/DelayNode.cpp:
- Modules/webaudio/DynamicsCompressorNode.cpp:
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::numberOfPartialsForRange const):
- Modules/webaudio/PeriodicWave.h:
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::RealtimeAnalyser):
- Modules/webaudio/RealtimeAnalyser.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::WaveShaperProcessor):
- Modules/webaudio/WaveShaperProcessor.h:
- Modules/webaudio/WebKitAudioContext.cpp:
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
- Modules/webaudio/WebKitAudioPannerNode.h:
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::AudioBus):
- platform/audio/AudioBus.h:
- platform/audio/AudioChannel.h:
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/AudioHardwareListener.cpp:
(WebCore::AudioHardwareListener::AudioHardwareListener):
- platform/audio/AudioHardwareListener.h:
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
- platform/audio/AudioResampler.h:
- platform/audio/AudioResamplerKernel.cpp:
(WebCore::AudioResamplerKernel::AudioResamplerKernel):
- platform/audio/AudioResamplerKernel.h:
- platform/audio/Biquad.cpp:
- platform/audio/Cone.cpp:
- platform/audio/Cone.h:
- platform/audio/Distance.cpp:
- platform/audio/Distance.h:
- platform/audio/DownSampler.cpp:
(WebCore::DownSampler::DownSampler):
- platform/audio/DownSampler.h:
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
- platform/audio/DynamicsCompressorKernel.h:
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::EqualPowerPanner):
- platform/audio/EqualPowerPanner.h:
- platform/audio/FFTConvolver.cpp:
(WebCore::FFTConvolver::FFTConvolver):
- platform/audio/FFTConvolver.h:
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::HRTFDatabase):
- platform/audio/HRTFDatabase.h:
- platform/audio/HRTFElevation.cpp:
- platform/audio/HRTFElevation.h:
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::HRTFKernel):
- platform/audio/HRTFKernel.h:
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
- platform/audio/HRTFPanner.h:
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::PlatformMediaSession):
- platform/audio/PlatformMediaSession.h:
- platform/audio/PushPullFIFO.cpp:
(WebCore::PushPullFIFO::PushPullFIFO):
- platform/audio/PushPullFIFO.h:
- platform/audio/Reverb.cpp:
- platform/audio/ReverbAccumulationBuffer.cpp:
(WebCore::ReverbAccumulationBuffer::ReverbAccumulationBuffer):
- platform/audio/ReverbAccumulationBuffer.h:
- platform/audio/ReverbConvolver.cpp:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/audio/ReverbInputBuffer.cpp:
(WebCore::ReverbInputBuffer::ReverbInputBuffer):
- platform/audio/ReverbInputBuffer.h:
- 12:57 PM Changeset in webkit [267543] by
-
- 21 edits in trunk/Source/WebCore
Simplify AudioNode::addInput() / addOutput() call sites
https://bugs.webkit.org/show_bug.cgi?id=216941
Reviewed by Darin Adler.
Simplify AudioNode::addInput() / addOutput() call sites by moving the input / output
node construction from the call site to the function implementation.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::addInput):
(WebCore::AudioNode::addOutput):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
- Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::ConstantSourceNode):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::StereoPannerNode):
- Modules/webaudio/WebKitAudioPannerNode.cpp:
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
- 12:08 PM Changeset in webkit [267542] by
-
- 3 edits in trunk/Tools
[results.webkit.org] Drop old archive chunks
https://bugs.webkit.org/show_bug.cgi?id=216936
<rdar://problem/69513686>
Unreviewed emergency infrastructure change.
- Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Increment package version.
- Scripts/libraries/resultsdbpy/resultsdbpy/model/cassandra_archiver.py:
(CassandraArchiver.ArchiveChunks): Changer archive chunk table.
- 11:32 AM Changeset in webkit [267541] by
-
- 38 edits in trunk/Source/WebCore
Declare render quantum size constant in AudioUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=216935
Reviewed by Eric Carlson.
Declare render quantum size [1] constant in AudioUtilities.h so that it can be used in both
platform/ and Modules/webaudio/. Also update the code so that we have a single constant
instead of many.
[1] https://www.w3.org/TR/webaudio/#render-quantum-size
- Modules/webaudio/AudioListener.cpp:
(WebCore::AudioListener::AudioListener):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
- Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::processOnlyAudioParams):
- Modules/webaudio/ConstantSourceNode.cpp:
(WebCore::ConstantSourceNode::ConstantSourceNode):
- Modules/webaudio/ConstantSourceNode.h:
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::processOnlyAudioParams):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::processOnlyAudioParams):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
(WebCore::GainNode::processOnlyAudioParams):
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::suspendOfflineRendering):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::processOnlyAudioParams):
(WebCore::PannerNode::processSampleAccurateValues):
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::RealtimeAnalyser):
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::processOnlyAudioParams):
- Modules/webaudio/StereoPannerNode.h:
- Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):
- platform/audio/AudioResamplerKernel.cpp:
(WebCore::AudioResamplerKernel::AudioResamplerKernel):
(WebCore::AudioResamplerKernel::getSourcePointer):
(WebCore::AudioResamplerKernel::process):
- platform/audio/AudioResamplerKernel.h:
- platform/audio/AudioUtilities.h:
- platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
- platform/audio/Biquad.h:
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::pan):
- platform/audio/IIRFilter.cpp:
(WebCore::IIRFilter::tailTime):
- platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::provideInput):
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateSessionState):
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::framesPerBuffer const):
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_class_init):
- 11:29 AM Changeset in webkit [267540] by
-
- 2 edits in trunk/Source/WebKit
CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code
https://bugs.webkit.org/show_bug.cgi?id=216934
<rdar://problem/69216768>
Reviewed by Alex Christensen.
Add a check for a valid key.
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::firstPartyHostCNAMEDomain):
- 11:28 AM Changeset in webkit [267539] by
-
- 12 edits1 copy in trunk/Source
Add libwebrtc.dylib version check
https://bugs.webkit.org/show_bug.cgi?id=216884
<rdar://problem/69441354>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Introduce isMatchingBundleVersion to check libwebrtc.dylib version.
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Configurations/libwebrtc.xcconfig:
- Source/webrtc/sdk/WebKit/WebKitUtilities.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::isMatchingBundleVersion):
Source/WebCore:
Use webrtc::isMatchingBundleVersion to check for libwebrtc.dylib presence and for version matching.
If version does not match, crash the web process.
No change of behavior.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProvider::webRTCAvailable):
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.mm:
- 11:23 AM Changeset in webkit [267538] by
-
- 2 edits in trunk/Source/JavaScriptCore
[PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
https://bugs.webkit.org/show_bug.cgi?id=216805
Reviewed by Don Olmstead.
When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.
On Windows, there's no such fancy feature from the beginning.
- inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
(Inspector::Socket::read):
(Inspector::Socket::write):
- 10:47 AM Changeset in webkit [267537] by
-
- 36 edits in trunk/Source/WebCore
Drop AudioNode::reset() and all its overrides
https://bugs.webkit.org/show_bug.cgi?id=216932
Reviewed by Eric Carlson.
Drop AudioNode::reset() and all its overrides. This is dead code.
- Modules/webaudio/AnalyserNode.cpp:
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicProcessorNode.cpp:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.cpp:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/ChannelMergerNode.cpp:
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.cpp:
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConstantSourceNode.h:
- Modules/webaudio/ConvolverNode.cpp:
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DynamicsCompressorNode.cpp:
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.cpp:
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/OscillatorNode.cpp:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.cpp:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/RealtimeAnalyser.cpp:
- Modules/webaudio/RealtimeAnalyser.h:
- Modules/webaudio/ScriptProcessorNode.cpp:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/StereoPannerNode.h:
- Modules/webaudio/WebKitAudioPannerNode.cpp:
- Modules/webaudio/WebKitAudioPannerNode.h:
- 9:49 AM Changeset in webkit [267536] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix the build for recent SDKs.
rdar://69394018
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::decode):
- 9:16 AM Changeset in webkit [267535] by
-
- 3 edits in trunk/Source/JavaScriptCore
[MIPS] Broken build after r267371
https://bugs.webkit.org/show_bug.cgi?id=216893
Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-09-24
Reviewed by Adrian Perez de Castro.
This addresses two issues.
First, the fix in https://bugs.webkit.org/show_bug.cgi?id=216772 was not
getting exercised, because the LabelReference offset was always zero.
The reason the offset was zero is that LabelReference.mapChildren would discard
the offset when generating a new LabelReference to wrap the Label returned by
the code block it yielded to.
The reason this was only an issue on MIPS is because only MIPS was using the
result of calls to LabelReference.mapChildren (in its lowering phase,
assignRegistersToTemporaries -> replaceTemporariesWithRegisters ->
mapChildren). Other archs, e.g. X86_64 only call mapChildren in earlier phases
(specifically, subsequent to a call to isASTErroneous), in which the new
LabelReferences returned by mapChildren are later discarded. Even though ARM
32/64 contains indirect calls to mapChildren, those are made after the
arm{,64}LowerLabelReferences transformation which doesn't leave any
LabelReference nodes around for .mapChildren to be called on.
So this is not an issue for architectures other than MIPS because
(a) AddImmediates.fold correctly constructs a LabelReference with an offset by
calling LabelReference.plusOffset and
(b) they don't call (and therefore don't use the result of)
LabelReference.mapChildren in their lowering code.
Second, the code we generate needs to look up the /label/ in the GOT, not the
computed address. After the lookup, we simply need to add the offset.
- offlineasm/ast.rb:
- offlineasm/mips.rb:
- 9:14 AM Changeset in webkit [267534] by
-
- 34 edits in trunk
[GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=216927
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-09-24
Reviewed by Alex Christensen.
Source/WebCore:
Make proxySettings a member of SoupNetworkSession, instead of being global.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::proxySettings): Deleted.
(WebCore::SoupNetworkSession::setupProxy): Deleted.
- platform/network/soup/SoupNetworkSession.h:
Source/WebKit:
Make proxy settings per session instead of global to the network process. The web context API now simply
forwards the request to the website data manager.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setNetworkProxySettings):
- NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::NetworkSessionSoup):
(WebKit::NetworkSessionSoup::setProxySettings):
- NetworkProcess/soup/NetworkSessionSoup.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionCreate):
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_set_network_proxy_settings):
- UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkit_website_data_manager_set_network_proxy_settings):
- UIProcess/API/gtk/WebKitNetworkProxySettings.h:
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebsiteDataManager.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/wpe/WebKitNetworkProxySettings.h:
- UIProcess/API/wpe/WebKitWebContext.h:
- UIProcess/API/wpe/WebKitWebsiteDataManager.h:
- UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::networkProxySettings const):
- UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setNetworkProxySettings):
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setNetworkProxySettings): Deleted.
Tools:
Use the new API in tests.
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextProxySettings):
- 8:52 AM Changeset in webkit [267533] by
-
- 2 edits in trunk/Source/WTF
[LFC][Integration] Enable on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=216928
Reviewed by Sam Weinig.
- wtf/PlatformEnableWinApple.h:
For consistency.
- 8:23 AM Changeset in webkit [267532] by
-
- 5 edits2 copies2 adds in trunk
web audio api outputs silence for 302 redirected resource in safari
https://bugs.webkit.org/show_bug.cgi?id=214932
<rdar://problem/66300050>
Reviewed by Darin Adler.
Source/WebCore:
If the resource is redirected to another origin, treat it as tainted only if the crossorigin attribute
is not set. This is done for consistency with Blink:
- https://github.com/chromium/chromium/blob/master/media/blink/webmediaplayer_impl.cc (see WouldTaintOrigin())
The new behavior also seems to match Firefox.
Tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html
http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::wouldTaintOrigin):
LayoutTests:
Add layout test coverage. Update existing test to reflect the fact that the frequency returned by
the AnalyserNode is -Infinity when input is silent, not minDecibels (this has changed fairly
recently).
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
- 8:20 AM Changeset in webkit [267531] by
-
- 98 edits11 copies7 moves407 adds2 deletes in trunk/LayoutTests
Resync WPT's mathml and math-script-level-and-math-style tests
https://bugs.webkit.org/show_bug.cgi?id=216871
Patch by Frederic Wang <fwang@igalia.com> on 2020-09-24
Reviewed by Rob Buis.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative.html: Added.
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-002.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-003.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative-expected.html.
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-003.tentative.html: Added.
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-004.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-001.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative-expected.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-004.tentative-expected.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-004.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-005.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-font-size-clamping-001.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative.html:
- web-platform-tests/css/css-fonts/math-script-level-and-math-style/w3c-import.log:
- web-platform-tests/mathml/crashtests/display-and-column-properties.html: Added.
- web-platform-tests/mathml/crashtests/multicol-on-token-elements.html: Added.
- web-platform-tests/mathml/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/w3c-import.log.
- web-platform-tests/mathml/presentation-markup/direction/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-2-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-2.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-3-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-3.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-invalid.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-legacy-bevelled-attribute.tentative-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-legacy-bevelled-attribute.tentative.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
- web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
- web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
- web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3.html: Added.
- web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation-expected.html:
- web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation.html:
- web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units.html: Added.
- web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001.html: Added.
- web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002.html: Added.
- web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003.html: Added.
- web-platform-tests/mathml/presentation-markup/mpadded/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log.
- web-platform-tests/mathml/presentation-markup/mrow/dynamic-mrow-like-001-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/dynamic-mrow-like-001.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline.html:
- web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy.html:
- web-platform-tests/mathml/presentation-markup/mrow/legacy-mfenced-element-001-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/legacy-mfenced-element-001.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/legacy-mstyle-attributes.html:
- web-platform-tests/mathml/presentation-markup/mrow/merror-001.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/mrow-painting-order-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/mrow-painting-order.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/no-spacing.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/spacing.html: Added.
- web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html:
- web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002.html:
- web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html.
- web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-002-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-form-expected.html:
- web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus-expected.html:
- web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-lspace-rspace-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-lspace-rspace.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-movablelimits-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-movablelimits.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-single-char-and-children-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-single-char-and-children.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001-expected.txt: Removed.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001.html: Removed.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006.html: Added.
- web-platform-tests/mathml/presentation-markup/operators/support/operator-dictionary-tests.css: Added.
(@font-face):
(math, math *):
- web-platform-tests/mathml/presentation-markup/operators/support/operator-dictionary-tests.js: Added.
(OperatorDictionaryTests.spaceBetween):
(OperatorDictionaryTests.string_appeared_here):
(OperatorDictionaryTests.run):
- web-platform-tests/mathml/presentation-markup/operators/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/w3c-import.log.
- web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/radicals/dynamic-radical-paint-invalidation-001-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/radicals/dynamic-radical-paint-invalidation-001.html: Added.
- web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2.html: Added.
- web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html:
- web-platform-tests/mathml/presentation-markup/scripts/empty-underover.html: Added.
- web-platform-tests/mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative.html: Added.
- web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
- web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
- web-platform-tests/mathml/presentation-markup/scripts/underover-legacy-align-attribute-001-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/scripts/underover-legacy-align-attribute-001.html: Added.
- web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
- web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html.
- web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
- web-platform-tests/mathml/presentation-markup/spaces/space-like-001.html:
- web-platform-tests/mathml/presentation-markup/spaces/space-like-002.html:
- web-platform-tests/mathml/presentation-markup/spaces/space-like-003.html:
- web-platform-tests/mathml/presentation-markup/spaces/space-vertical-align.tentative-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/spaces/space-vertical-align.tentative.html: Added.
- web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001.html: Added.
- web-platform-tests/mathml/presentation-markup/tables/w3c-import.log:
- web-platform-tests/mathml/presentation-markup/tokens/dynamic-mtext-like-001-expected.html: Added.
- web-platform-tests/mathml/presentation-markup/tokens/dynamic-mtext-like-001.html: Added.
- web-platform-tests/mathml/presentation-markup/tokens/ms-001-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/direction/direction-009-expected.html.
- web-platform-tests/mathml/presentation-markup/tokens/ms-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/direction/direction-009.html.
- web-platform-tests/mathml/presentation-markup/tokens/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log.
- web-platform-tests/mathml/relations/css-styling/#default-text-properties.html#: Added.
- web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html:
- web-platform-tests/mathml/relations/css-styling/attribute-mapping-002.html:
- web-platform-tests/mathml/relations/css-styling/blur-filter-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/blur-filter.html: Added.
- web-platform-tests/mathml/relations/css-styling/clip-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/clip-path-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/clip-path.html: Added.
- web-platform-tests/mathml/relations/css-styling/clip.html: Added.
- web-platform-tests/mathml/relations/css-styling/color-001.html:
- web-platform-tests/mathml/relations/css-styling/color-002.html:
- web-platform-tests/mathml/relations/css-styling/color-003.html:
- web-platform-tests/mathml/relations/css-styling/color-004.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004-expected.html.
- web-platform-tests/mathml/relations/css-styling/color-004.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004.html.
- web-platform-tests/mathml/relations/css-styling/color-005-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004-expected.html.
- web-platform-tests/mathml/relations/css-styling/color-005.html: Added.
- web-platform-tests/mathml/relations/css-styling/default-font-family.html: Added.
- web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root.html: Added.
- web-platform-tests/mathml/relations/css-styling/display-2.html: Added.
- web-platform-tests/mathml/relations/css-styling/displaystyle-3.html: Added.
- web-platform-tests/mathml/relations/css-styling/mathcolor-mathbackground-css-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/mathcolor-mathbackground-css.html: Added.
- web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords-expected.html:
- web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords.html:
- web-platform-tests/mathml/relations/css-styling/multi-column-layout.html: Added.
- web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html:
- web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003.html: Added.
- web-platform-tests/mathml/relations/css-styling/padding-border-margin/w3c-import.log:
- web-platform-tests/mathml/relations/css-styling/presentational-hints-001-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/presentational-hints-001.html: Added.
- web-platform-tests/mathml/relations/css-styling/presentational-hints-002-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/presentational-hints-002.html: Added.
- web-platform-tests/mathml/relations/css-styling/scriptlevel-001.html: Added.
- web-platform-tests/mathml/relations/css-styling/transform-expected.html: Added.
- web-platform-tests/mathml/relations/css-styling/transform.html: Added.
- web-platform-tests/mathml/relations/css-styling/visibility-001.html:
- web-platform-tests/mathml/relations/css-styling/visibility-002.html:
- web-platform-tests/mathml/relations/css-styling/visibility-003.html:
- web-platform-tests/mathml/relations/css-styling/visibility-004.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html.
- web-platform-tests/mathml/relations/css-styling/visibility-004.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004.html.
- web-platform-tests/mathml/relations/css-styling/visibility-005-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html.
- web-platform-tests/mathml/relations/css-styling/visibility-005.html: Added.
- web-platform-tests/mathml/relations/css-styling/w3c-import.log:
- web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html:
- web-platform-tests/mathml/relations/html5-tree/content-editable.html: Added.
- web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html:
- web-platform-tests/mathml/relations/html5-tree/css-inline-style-interface.tentative.html:
- web-platform-tests/mathml/relations/html5-tree/display-1.html:
- web-platform-tests/mathml/relations/html5-tree/dynamic-2-expected.html: Added.
- web-platform-tests/mathml/relations/html5-tree/dynamic-2.html: Added.
- web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html: Added.
- web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html: Added.
- web-platform-tests/mathml/relations/html5-tree/href-click-3.html:
- web-platform-tests/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html:
- web-platform-tests/mathml/relations/html5-tree/integration-point-1.html:
- web-platform-tests/mathml/relations/html5-tree/integration-point-4.html:
- web-platform-tests/mathml/relations/html5-tree/integration-point-5.html: Added.
- web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html:
- web-platform-tests/mathml/relations/html5-tree/required-extensions-2.html:
- web-platform-tests/mathml/relations/html5-tree/tabindex-001.html:
- web-platform-tests/mathml/relations/html5-tree/tabindex-002.html:
- web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
- web-platform-tests/mathml/support/box-comparison.js:
(compareSizeWithAndWithoutStyle):
- web-platform-tests/mathml/support/feature-detection.js:
(MathMLFeatureDetection.string_appeared_here):
- web-platform-tests/mathml/support/layout-comparison.js:
(childrenHaveEmptyBoundingClientRects):
- web-platform-tests/mathml/support/mathml-fragments.js:
(FragmentHelper.isTokenElement):
- web-platform-tests/mathml/support/operator-dictionary.json:
- web-platform-tests/mathml/tools/axisheight.py:
- web-platform-tests/mathml/tools/fractions.py:
- web-platform-tests/mathml/tools/largeop.py:
- web-platform-tests/mathml/tools/limits.py:
- web-platform-tests/mathml/tools/mathvariant-transforms.py:
- web-platform-tests/mathml/tools/operator-dictionary.py:
(createStretchy):
- web-platform-tests/mathml/tools/percentscaledown.py:
- web-platform-tests/mathml/tools/radicals.py:
(createStretchyRadical):
- web-platform-tests/mathml/tools/scripts.py:
- web-platform-tests/mathml/tools/stacks.py:
- web-platform-tests/mathml/tools/stretchstacks.py:
- web-platform-tests/mathml/tools/underover.py:
- web-platform-tests/mathml/tools/use-typo-lineheight.py:
- web-platform-tests/mathml/tools/utils/pycache/w3c-import.log: Delete
- web-platform-tests/mathml/tools/utils/mathfont.py:
(create):
(drawRectangleGlyph):
- web-platform-tests/mathml/tools/utils/misc.py:
- web-platform-tests/mathml/tools/utils/w3c-import.log:
- web-platform-tests/mathml/tools/xHeight.py:
LayoutTests:
Resync WPT's mathml and math-script-level-and-math-style tests
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
- platform/ios-13/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
- platform/wpe/TestExpectations:
- tests-options.json:
- 8:11 AM Changeset in webkit [267530] by
-
- 3 edits in trunk/Source/WebCore
Regression(r265280) Web Audio sources malfunction when disconnected from the audio graph
https://bugs.webkit.org/show_bug.cgi?id=216703
<rdar://problem/69158436>
Reviewed by Eric Carlson.
In case of an audio source that stops producing data, but does not end or mute the track,
we would continuously try to read the data until getting to the end of the data.
When reaching the end of the data, we would return silence and go back in time a little bit
to restart playing with some margin. This allows to read just one chunk of audio until we are back to the end of data.
We fix this by storing the end of the data counter when reaching it.
When trying to pull some more data, we will go back in time a little bit only if some more data was added in the meantime.
Otherwise, we just output silence.
Covered by manual test.
- platform/audio/mac/AudioSampleDataSource.h:
- platform/audio/mac/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pullSamplesInternal):
- 7:17 AM Changeset in webkit [267529] by
-
- 2 edits in trunk/Tools
[JHBUILD] Port jhbuild-wrapper to python3
https://bugs.webkit.org/show_bug.cgi?id=216916
Reviewed by Adrian Perez de Castro.
Python2 is at its EOL, distributions are starting to remove it and python3 should be used by default now. Migrated
jhbuild wrapper code to python3 (while keeping backwards compatibility with python2 just in case).
- jhbuild/jhbuild-wrapper:
(ensure_jhbuild): Replace has_key() by the more pythonic construction with 'in'.
- 6:21 AM Changeset in webkit [267528] by
-
- 5 edits2 adds in trunk
currentColor isn't recalculated when a text node doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=216780
<rdar://problem/69320933>
Reviewed by Antoine Quint.
Source/WebCore:
We fail to repaint with the new background color when 'background-color' property has value 'currentColor' and the current color changes.
Test case by Cory LaViska.
Test: fast/css/currentColor-background-paint.html
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaint const):
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::isEquivalentForPainting const):
- rendering/style/StyleBackgroundData.h:
LayoutTests:
- fast/css/currentColor-background-paint-expected.html: Added.
- fast/css/currentColor-background-paint.html: Added.
- 5:52 AM Changeset in webkit [267527] by
-
- 2 edits in trunk/Source/WebCore
Root node with stateless wheel event isn't always scrollable
https://bugs.webkit.org/show_bug.cgi?id=216875
Reviewed by Simon Fraser.
Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which
does not trigger rubber-band, we should check the scroll content of the root node.
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event
doesn't trigger rubber-band, should check the scroll content.
- 4:54 AM Changeset in webkit [267526] by
-
- 3 edits3 deletes in trunk
Unreviewed, reverting r267495 and r267512.
https://bugs.webkit.org/show_bug.cgi?id=216924
Broke transform-stream.html test
Reverted changesets:
"Missing scope release in JSDOMBuiltinConstructorBase"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267495
"Unreviewed, we should put it under js/dom since it is not
usable in JSC shell"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267512
- 4:49 AM Changeset in webkit [267525] by
-
- 4 edits4 deletes in trunk
Unreviewed, reverting r267507.
https://bugs.webkit.org/show_bug.cgi?id=216923
Broke two layout tests on windows
Reverted changeset:
"web audio api outputs silence for 302 redirected resource in
safari"
https://bugs.webkit.org/show_bug.cgi?id=214932
https://trac.webkit.org/changeset/267507
- 2:17 AM Changeset in webkit [267524] by
-
- 4 edits in trunk
REGRESSION(r267502): [GTK][WPE] ephemeral WebKitWebsiteDataManager ignores TLS errors by default
https://bugs.webkit.org/show_bug.cgi?id=216919
Reviewed by Adrian Perez de Castro.
Source/WebKit:
Initialize ignoreTLSErrors on website data store for ephemeral sessions.
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerConstructed):
Tools:
Add a test case to check we propagate the setting to the network process for ephemeral sessions too.
- TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(EphemeralSSLTest::setup):
(EphemeralSSLTest::teardown):
(testTLSErrorsEphemeral):
(beforeAll):
- 2:16 AM Changeset in webkit [267523] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r267502) [GLIB] Make WTR ignoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=216911
Reviewed by Adrian Perez de Castro.
I forgot to initialize ignoreTLSErrors in network session parameters.
- UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
- 12:35 AM Changeset in webkit [267522] by
-
- 5 edits in trunk
%TypedArray%.prototype.fill must only evaluate its argument once
https://bugs.webkit.org/show_bug.cgi?id=216912
Reviewed by Yusuke Suzuki.
JSTests:
- stress/typedarray-fill.js:
Fix test.
- test262/expectations.yaml:
Mark two test cases as passing.
Source/JavaScriptCore:
Currently, we evaluate the argument in
typedArray.fill({ valueOf() { ... } })once per filled element,
but it should only be evaluated once in total.
- builtins/TypedArrayPrototype.js:
(fill):
- 12:10 AM Changeset in webkit [267521] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (iOS/Safari 14): MediaRecorder produces invalid video files
https://bugs.webkit.org/show_bug.cgi?id=216832
<rdar://problem/69377550>
Reviewed by Eric Carlson.
Start the audio and video timestamps at zero.
Compute the audio timestamp based on the sample count and the video timestamp based
on the time at which the video sample is received.
Covered by manually testing Safari generated videos on VLC, Chrome and Firefox.
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::initialize):
(WebCore::MediaRecorderPrivateWriter::startAssetWriter):
(WebCore::copySampleBufferWithCurrentTimeStamp):
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
(WebCore::createAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
- 12:01 AM Changeset in webkit [267520] by
-
- 4 edits in trunk/Source/ThirdParty/ANGLE
REGRESSION: Textures Fail to Render in WebGL from HLS Stream [iOS 14]
https://bugs.webkit.org/show_bug.cgi?id=215908
<rdar://problem/68000962>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-09-24
Reviewed by Dean Jackson.
Disable ANGLE workers until EAGL implementation is more complete.
Current implementation fails to compile any shader, since the
compilation happens in the worker thread and worker EAGL context
which does not use the same sharegroup as the main context.
The shader objects are created in the main context but the shader
source setting and compilation happens in the worker context.
EAGL needs a flush between state changes, and adding that
correctly is a bigger change to be done later.
Use sized formats when calling [EAGLContext -texImageIOSurface]
from EGL_ANGLE_iosurface_client_buffer code. The texImageIOSurface
accepts parameters with glTexImage2D logic. On ES3, some of the
internal formats must be sized formats. The EAGLContext instantiated
by ANGLE is ES3, even if the ANGLE context would be ES2.
No tests added since this should be caught with the many video
related tests. It's unclear why this is not the case -- at
least on real hw. This is to be investigated later, too.
- src/libANGLE/renderer/driver_utils.h:
(rx::IsIOS):
- src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
- src/libANGLE/renderer/gl/renderergl_utils.cpp:
(rx::nativegl_gl::InitializeFeatures):
Sep 23, 2020:
- 11:15 PM Changeset in webkit [267519] by
-
- 9 edits1 add in trunk
%ArrayIteratorPrototype%.next must check for detached buffers
https://bugs.webkit.org/show_bug.cgi?id=216904
Reviewed by Yusuke Suzuki.
JSTests:
- stress/detach-buffer-during-iteration.js: Added.
- test262/expectations.yaml:
Mark two test cases as passing.
Source/JavaScriptCore:
Per https://tc39.es/ecma262/#sec-%arrayiteratorprototype%.next:
- If a has a TypedArrayName? internal slot, then
- If IsDetachedBuffer(a.ViewedArrayBuffer?) is true, throw a TypeError exception.
- builtins/ArrayIteratorPrototype.js:
(next):
- builtins/BuiltinNames.h:
- bytecode/LinkTimeConstant.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncIsNeutered):
- runtime/JSTypedArrayViewPrototype.h:
- 10:59 PM Changeset in webkit [267518] by
-
- 18 edits in trunk/Source/JavaScriptCore
[JSC] Simply some of template-specialized host functions by defining each function
https://bugs.webkit.org/show_bug.cgi?id=216907
Reviewed by Saam Barati.
This makes automatically-registering these functions in JIT-caging easy.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::callImpl):
(JSC::APICallbackFunction::constructImpl):
(JSC::APICallbackFunction::call): Deleted.
(JSC::APICallbackFunction::construct): Deleted.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallbackConstructor):
(JSC::JSCallbackConstructor::getConstructData):
- API/JSCallbackFunction.cpp:
(JSC::callJSCallbackFunction):
(JSC::JSCallbackFunction::JSCallbackFunction):
- API/ObjCCallbackFunction.mm:
(JSC::callObjCCallbackFunction):
(JSC::constructObjCCallbackFunction):
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
- API/glib/JSCCallbackFunction.cpp:
(JSC::callJSCCallbackFunction):
(JSC::constructJSCCallbackFunction):
(JSC::JSCCallbackFunction::JSCCallbackFunction):
- dfg/DFGOperations.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jsc.cpp:
(accessorMakeMasquerader):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSGenericArrayBufferConstructor<sharingMode>::JSGenericArrayBufferConstructor):
(JSC::JSGenericArrayBufferConstructor<sharingMode>::constructImpl):
(JSC::constructArrayBuffer):
(JSC::constructSharedArrayBuffer):
(JSC::JSGenericArrayBufferConstructor<sharingMode>::constructArrayBuffer): Deleted.
- runtime/JSArrayBufferConstructor.h:
- runtime/JSCustomGetterSetterFunction.cpp:
(JSC::customGetterSetterFunctionCall):
(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall): Deleted.
- runtime/JSCustomGetterSetterFunction.h:
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor<errorType>::constructImpl):
(JSC::NativeErrorConstructor<errorType>::callImpl):
(JSC::callEvalError):
(JSC::constructEvalError):
(JSC::callRangeError):
(JSC::constructRangeError):
(JSC::callReferenceError):
(JSC::constructReferenceError):
(JSC::callSyntaxError):
(JSC::constructSyntaxError):
(JSC::callTypeError):
(JSC::constructTypeError):
(JSC::callURIError):
(JSC::constructURIError):
(JSC::callFunction):
(JSC::constructFunction):
(JSC::NativeErrorConstructor<errorType>::NativeErrorConstructor):
(JSC::NativeErrorConstructorBase::finishCreation):
(JSC::NativeErrorConstructor<errorType>::constructNativeErrorConstructor): Deleted.
(JSC::NativeErrorConstructor<errorType>::callNativeErrorConstructor): Deleted.
- runtime/NativeErrorConstructor.h:
- runtime/RegExpConstructor.cpp:
(JSC::regExpConstructorDollarImpl):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):
(JSC::regExpConstructorDollar): Deleted.
- tools/JSDollarVM.cpp:
- 9:33 PM Changeset in webkit [267517] by
-
- 3 edits in trunk/Tools
[Windows] Ignore render tree dump based results on Windows
https://bugs.webkit.org/show_bug.cgi?id=209897
Reviewed by Darin Adler.
Render tree dumps are port specific and so difficult to maintain. They are mostly very old and
have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs.
This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by
default on Apple Windows port.
With the option set the render tree dump tests are still run (so crashes are detected) but their
output is treated as if it always passed. Missing results are not written to disk.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_text):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 8:36 PM Changeset in webkit [267516] by
-
- 18 edits in trunk/Source
Add feature flags for GPU Process features
https://bugs.webkit.org/show_bug.cgi?id=216901
Reviewed by Tim Horton.
Source/WebCore:
Rename useGPUProcessForMedia to useGPUProcessForMediaEnabled.
No new tests since no functional changes.
- page/Settings.yaml:
Source/WebKit:
Add feature flags for the following GPU Process features:
- 2D canvas in GPU process
- WebGL in GPU process
- DOM rendering in GPU Process
Also, clean up some related feature/function names.
- FeatureFlags/WebKit.plist:
Add keys for the GPU process features and sort all keys.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
(WebKit::defaultUseGPUProcessForMediaEnabled):
(WebKit::defaultUseGPUProcessForWebGLEnabled):
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):
(WebKit::defaultUseGPUProcessForMedia): Deleted.
(WebKit::defaultRenderCanvasInGPUProcessEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.h:
- Shared/WebPreferencesInternal.yaml:
Add preferences and corresponding default values.
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Rename useGPUProcessForMedia to useGPUProcessForMediaEnabled.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Use useGPUProcessForCanvasRenderingEnabled instead of renderCanvasInGPUProcessEnabled.
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::updatePreferences):
Use useGPUProcessForMediaEnabled instead of useGPUProcessForMedia.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_limitsNavigationsToAppBoundDomains): Ditto.
(WebKit::WebPage::updatePreferences): Ditto.
Source/WebKitLegacy/mac:
Minor cleanups.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences useGPUProcessForMediaEnabled]):
(-[WebPreferences setUseGPUProcessForMediaEnabled:]):
(-[WebPreferences useGPUProcessForMedia]): Deleted.
(-[WebPreferences setUseGPUProcessForMedia:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 8:15 PM Changeset in webkit [267515] by
-
- 6 edits in trunk/Source/WebCore
[LFC][Integration] Line layout logic should consult LayoutState whether remove trailing letter spacing.
https://bugs.webkit.org/show_bug.cgi?id=216905
Reviewed by Sam Weinig.
This is in preparation for completely moving away from the RuntimeEnabledFeatures check.
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::shouldIgnoreTrailingLetterSpacing const):
- layout/LayoutState.h:
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::appendTextContent):
- layout/inlineformatting/InlineLine.h:
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
- 7:46 PM Changeset in webkit [267514] by
-
- 9 edits58 adds in trunk
Update Array.prototype.sort to be consistent with tightened spec
https://bugs.webkit.org/show_bug.cgi?id=202582
Reviewed by Yusuke Suzuki and Keith Miller.
JSTests:
Provided microbenchmarks test receivers that are half-sorted: 50% of their
items and item pairs (to accomodate merge sort) are at the right place.
Arrays of multiple sizes (8/24/64 items) are tested with both userland
and default comparator (to cover bucket sort).
- ChakraCore/test/Array/array_sort.baseline-jsc: Fix typo in error message.
- microbenchmarks/array-prototype-sort-large-array-comparator.js: Added.
- microbenchmarks/array-prototype-sort-large-array.js: Added.
- microbenchmarks/array-prototype-sort-medium-array-comparator.js: Added.
- microbenchmarks/array-prototype-sort-medium-array.js: Added.
- microbenchmarks/array-prototype-sort-small-array-comparator.js: Added.
- microbenchmarks/array-prototype-sort-small-array.js: Added.
- mozilla/js1_5/Array/regress-157652.js: Skip sorting sparse array of UINT_MAX size.
- stress/regress-188577.js: Replace sort() with unshift() and refactor.
Source/JavaScriptCore:
This patch implements the spec change [1] that reduces amount of cases resulting
in an implementation-defined sort order, aligning JSC with V8 and SpiderMonkey.
To achieve this, we collect all existing non-undefined receiver elements to a
temporary array, sort it, and write back sorted items, followed byundefined
values and holes.
This change is proven to be web-compatible (shipping since Chrome 76) and neutral
on peak memory consumption in the wild.
Although we can unobservably detect sparse receivers, we can't avoid creating a
temporary array for common case since userland comparators may throw; string
sorting won't measurably benefit from this, only increasing code complexity.
This change uses @putByValDirect unless the spec requires Set?, avoids using
closure variables, and adds a few drive-by optimizations, resulting in ~22%
faster string sorting and 13% speed-up for userland comparators.
Dromaeo/jslib is neutral.
[1]: https://github.com/tc39/ecma262/pull/1585
- builtins/ArrayPrototype.js:
(sort.stringComparator):
Optimization #1: replace char-by-char comparison loop with > operator, aligning
JSC with V8 and SpiderMonkey. This semantically equivalent change alone is a ~15%
progression for string sort.
(sort.compact):
(sort.commit):
Optimization #2: copy large non-numeric arrays in a loop rather than @appendMemcpy.
Using the latter unconditionally regresses provided microbenchmarks.
(sort.merge):
Optimization #3: replacetypeofcheck and negation with strict equality.
(sort.mergeSort):
Optimization #4: always return sorted array instead of copying, even if it's the buffer.
Tweak: create the buffer with correct length.
(sort.bucketSort):
Optimization #5: avoid emitting 2 extra get_by_val ops by saving bucket lookup to a variable.
Tweak: create new bucket via array literal.
(sort): Fix typo in error message.
(sort.compactSparse): Deleted.
(sort.compactSlow): Deleted.
(sort.comparatorSort): Deleted.
(sort.stringSort): Deleted.
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
Remove @Object.@getPrototypeOf as it's now unused and we have @getPrototypeOf intrinsic anyway.
LayoutTests:
While adding new LayoutTests for JS-only features is undesirable, it's a
quick-and-dirty way to import the tests [1] and fix the call count/order
of observable operations via debug() and text expectations.
The tests are imported into LayoutTests/js/dom instead of LayoutTests/js for
run-javascriptcore-tests to ignore them as they require array-sort-harness.js.
These files will be removed shortly in favor of thorough test262 coverage,
which is required for the proposal [2] to be merged.
[1]: https://gist.github.com/szuend/05ae15b4e1329b264ab4c9a1cda09242
[2]: https://github.com/tc39/ecma262/pull/1585
- TestExpectations: Mark a test as slow.
- js/dom/array-sort-*-expected.txt: Added.
- js/dom/array-sort-*.html: Added.
- js/dom/script-tests/array-sort-*.js: Added.
- js/resources/array-sort-harness.js: Added.
- 7:34 PM Changeset in webkit [267513] by
-
- 1 copy in tags/Safari-610.2.6.1.5
Tag Safari-610.2.6.1.5.
- 6:36 PM Changeset in webkit [267512] by
-
- 1 edit3 moves in trunk/LayoutTests
Unreviewed, we should put it under js/dom since it is not usable in JSC shell
https://bugs.webkit.org/show_bug.cgi?id=216851
- js/dom/script-tests/transform-stream.js: Renamed from LayoutTests/js/script-tests/transform-stream.js.
- js/dom/transform-stream-expected.txt: Renamed from LayoutTests/js/transform-stream-expected.txt.
- js/dom/transform-stream.html: Renamed from LayoutTests/js/transform-stream.html.
- 5:22 PM Changeset in webkit [267511] by
-
- 2 edits in trunk/Tools
Unreviewed config fix.
- BuildSlaveSupport/build.webkit.org-config/config.json: Fixing random unicode character.
- 4:41 PM Changeset in webkit [267510] by
-
- 5 edits12 adds in trunk/Tools
Update iOS, watchOS and tvOS builders and tester with new SDKs
https://bugs.webkit.org/show_bug.cgi?id=216658
Reviewed by Jonathan Bedard.
Bumped the versions on iOS, tvOS, and watchOS in config, dashboard and main CSS. Also, added the updated
images for the queues.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Simulator.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Simulator@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14Simulator.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14Simulator@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS7.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS7@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator7.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator7@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-simulator-14 img.logo):
(table.queue-grid tr.platform.ios-14 img.logo):
(table.queue-grid tr.platform.tvos-simulator-14 img.logo):
(table.queue-grid tr.platform.tvos-14 img.logo):
(table.queue-grid tr.platform.watchos-simulator-7 img.logo):
(table.queue-grid tr.platform.watchos-7 img.logo):
(table.queue-grid tr.platform.ios-simulator-13 img.logo): Deleted.
(table.queue-grid tr.platform.ios-13 img.logo): Deleted.
(table.queue-grid tr.platform.tvos-simulator-13 img.logo): Deleted.
(table.queue-grid tr.platform.tvos-13 img.logo): Deleted.
(table.queue-grid tr.platform.watchos-simulator-6 img.logo): Deleted.
(table.queue-grid tr.platform.watchos-6 img.logo): Deleted.
- BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
- 4:39 PM Changeset in webkit [267509] by
-
- 10 edits13 copies4 adds2 deletes in trunk/Source/WebCore
[LFC Display] Add the beginnings of a CSS display box hierarchy and CSS painter
https://bugs.webkit.org/show_bug.cgi?id=216752
Reviewed by Zalan Bujtas.
Add some Display::Box subclasses to display/css, a Display::Tree class to own the
display tree, and a DisplayTreeBuilder. Also add css/DisplayCSSPainter which is
the beginnings of a class that knows how to paint a CSS stacking context.
This code other than DisplayCSSPainter is deliberately vague about how much is
CSS specific. It's likely that some box classes will be shared with SVG painting.
- CMakeLists.txt:
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- display/DisplayLayerController.cpp:
(WebCore::Display::LayerController::RootLayerClient::paintContents):
(WebCore::Display::LayerController::RootLayerClient::deviceScaleFactor const):
(WebCore::Display::LayerController::prepareForDisplay):
(WebCore::Display::LayerController::ensureRootLayer):
(WebCore::Display::LayerController::updateRootLayerGeometry):
- display/DisplayLayerController.h:
- display/DisplayTree.cpp: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::Tree::Tree):
- display/DisplayTree.h: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::Tree::rootBox const):
- display/DisplayTreeBuilder.cpp: Added.
(WebCore::Display::TreeBuilder::TreeBuilder):
(WebCore::Display::TreeBuilder::build const):
(WebCore::Display::TreeBuilder::recursiveBuildDisplayTree const):
(WebCore::Display::TreeBuilder::displayBoxForRootBox const):
(WebCore::Display::TreeBuilder::displayBoxForLayoutBox const):
(WebCore::Display::outputDisplayBox):
(WebCore::Display::outputDisplayTree):
(WebCore::Display::showDisplayTree):
- display/DisplayTreeBuilder.h: Copied from Source/WebCore/display/DisplayView.h.
- display/DisplayView.cpp:
(WebCore::Display::View::prepareForDisplay):
(WebCore::Display::View::deviceScaleFactor const):
- display/DisplayView.h:
- display/css/DisplayBox.cpp: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::Box::Box):
(WebCore::Display::Box::setNextSibling):
(WebCore::Display::Box::debugDescription const):
- display/css/DisplayBox.h: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::Box::Box):
(WebCore::Display::Box::style const):
(WebCore::Display::Box::borderBoxFrame const):
(WebCore::Display::Box::isContainerBox const):
(WebCore::Display::Box::isImageBox const):
(WebCore::Display::Box::isReplacedBox const):
(WebCore::Display::Box::nextSibling const):
- display/css/DisplayCSSPainter.cpp: Added.
(WebCore::Display::CSSPainter::paintBoxDecorations):
(WebCore::Display::CSSPainter::paintBoxContent):
(WebCore::Display::CSSPainter::paintBox):
(WebCore::Display::CSSPainter::recursivePaintDescendants):
(WebCore::Display::CSSPainter::paintStackingContext):
(WebCore::Display::CSSPainter::isStackingContextPaintingBoundary):
(WebCore::Display::CSSPainter::recursiveCollectLayers):
(WebCore::Display::CSSPainter::paintTree):
- display/css/DisplayCSSPainter.h: Copied from Source/WebCore/display/DisplayView.h.
- display/css/DisplayContainerBox.cpp: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ContainerBox::ContainerBox):
(WebCore::Display::ContainerBox::setFirstChild):
(WebCore::Display::ContainerBox::debugDescription const):
- display/css/DisplayContainerBox.h: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ContainerBox::firstChild const):
- display/css/DisplayImageBox.cpp: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ImageBox::ImageBox):
(WebCore::Display::ImageBox::setImage):
(WebCore::Display::ImageBox::debugDescription const):
- display/css/DisplayImageBox.h: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ImageBox::image const):
- display/css/DisplayReplacedBox.cpp: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ReplacedBox::ReplacedBox):
- display/css/DisplayReplacedBox.h: Copied from Source/WebCore/display/DisplayView.h.
(WebCore::Display::ReplacedBox::replacedContentRect const):
- display/css/DisplayStyle.cpp: Copied from Source/WebCore/display/DisplayView.cpp.
(WebCore::Display::Style::Style):
(WebCore::Display::Style::hasBackground const):
(WebCore::Display::Style::hasVisibleBorder const):
- display/css/DisplayStyle.h: Added.
(WebCore::Display::Style::backgroundColor const):
(WebCore::Display::Style::hasBackgroundImage const):
(WebCore::Display::Style::borderLeft const):
(WebCore::Display::Style::borderRight const):
(WebCore::Display::Style::borderTop const):
(WebCore::Display::Style::borderBottom const):
(WebCore::Display::Style::zIndex const):
(WebCore::Display::Style::isStackingContext const):
(WebCore::Display::Style::isPositioned const):
(WebCore::Display::Style::isFloating const):
(WebCore::Display::Style::participatesInZOrderSorting const):
(WebCore::Display::Style::setIsPositioned):
(WebCore::Display::Style::setIsFloating):
- layout/displaytree/DisplayBox.cpp: Removed.
- layout/displaytree/DisplayBox.h: Removed.
- layout/layouttree/LayoutIterator.h: Unified sources build fix.
- 4:28 PM Changeset in webkit [267508] by
-
- 3 edits in trunk/Tools
webkitpy: Make sw_vers the source of truth for the MacOS version
https://bugs.webkit.org/show_bug.cgi?id=216903
<rdar://problem/69462735>
Reviewed by Dewei Zhu.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.init): Use sw_vers instead of platform.mac_ver().
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(fake_executive): Set a valid return value for sw_vers by default.
- 4:25 PM Changeset in webkit [267507] by
-
- 4 edits2 copies2 adds in trunk
web audio api outputs silence for 302 redirected resource in safari
https://bugs.webkit.org/show_bug.cgi?id=214932
<rdar://problem/66300050>
Reviewed by Darin Adler.
Source/WebCore:
If the resource is redirected to another origin, treat it as tainted only if the crossorigin attribute
is not set. This is done for consistency with Blink:
- https://github.com/chromium/chromium/blob/master/media/blink/webmediaplayer_impl.cc (see WouldTaintOrigin())
The new behavior also seems to match Firefox.
Tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html
http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::wouldTaintOrigin):
LayoutTests:
Add layout test coverage. Update existing test to reflect the fact that the frequency returned by
the AnalyserNode is -Infinity when input is silent, not minDecibels (this has changed fairly
recently).
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
- 4:06 PM Changeset in webkit [267506] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
https://bugs.webkit.org/show_bug.cgi?id=215667
Unreviewed test gardening.
- platform/ios/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
- 4:06 PM Changeset in webkit [267505] by
-
- 6 edits in trunk/Source/WebCore
Use less explicit ref() / deref() calls in WebAudio code
https://bugs.webkit.org/show_bug.cgi?id=216894
Reviewed by Darin Adler.
- Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::clearPendingActivity):
(WebCore::BaseAudioContext::makePendingActivity):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::startRendering):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaEngineWasUpdated):
(WebCore::HTMLMediaElement::createMediaPlayer):
- 3:48 PM Changeset in webkit [267504] by
-
- 131 edits5 deletes in trunk
Turn off the legacy prefixed WebAudio API
https://bugs.webkit.org/show_bug.cgi?id=216886
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/webaudio/historical-expected.txt:
Rebaseline test that is now passing.
Source/WebCore:
Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled
in r267488.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioBufferSourceNode.idl:
Make sure legacy constants get unexposed if the PrefixedWebAudio setting is disabled.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GetRuntimeEnabledStaticProperties):
- bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:
(WebCore::JSTestConditionalIncludesConstructor::initializeProperties):
(WebCore::JSTestConditionalIncludesPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
(WebCore::JSTestEnabledBySettingConstructor::prototypeForStructure):
(WebCore::JSTestEnabledBySettingConstructor::initializeProperties):
(WebCore::JSTestEnabledBySettingPrototype::finishCreation):
- bindings/scripts/test/TestEnabledBySetting.idl:
Add support for using [EnabledBySetting=X] on constants.
Source/WebKit:
Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled
in r267488.
- Shared/WebPreferencesInternal.yaml:
Source/WebKitLegacy/mac:
Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled
in r267488.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
LayoutTests:
Port existing layout tests from the prefixed WebAudio API to the new
unprefixed version.
- fast/history/page-cache-closed-audiocontext.html:
- fast/history/page-cache-running-audiocontext.html:
- fast/history/page-cache-suspended-audiocontext.html:
- fast/mediastream/getUserMedia-webaudio.html:
- fast/mediastream/media-devices-enumerate-devices.html:
- fast/mediastream/mediastreamtrack-audio-clone.html:
- fast/mediastream/mock-media-source-webaudio.html:
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html:
- http/wpt/mediarecorder/MediaRecorder-onremovetrack.html:
- http/wpt/webaudio/resources/audiocontext-stopped-iframe.html:
- platform/ios/webaudio/realtimeanalyser-fft-sizing-expected.txt:
- resources/testharnessreport.js:
- webaudio/analyser-exception.html:
- webaudio/audiobuffer-crash-expected.txt:
- webaudio/audiobuffer-crash.html:
- webaudio/audiobuffer-expected.txt:
- webaudio/audiobuffer-neuter.html:
- webaudio/audiobuffer.html:
- webaudio/audiobuffersource-channels-expected.txt:
- webaudio/audiobuffersource-channels.html:
- webaudio/audiobuffersource-ended.html:
- webaudio/audiobuffersource-multi-channels.html:
- webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html:
- webaudio/audiobuffersource-negative-playbackrate-interpolated.html:
- webaudio/audiobuffersource-negative-playbackrate-loop.html:
- webaudio/audiobuffersource-negative-playbackrate.html:
- webaudio/audiobuffersource-not-gced-until-ended.html:
- webaudio/audiobuffersource-playbackState-expected.txt: Removed.
- webaudio/audiobuffersource-playbackState.html: Removed.
- webaudio/audiobuffersource-playbackrate.html:
- webaudio/audiobuffersource-start.html:
- webaudio/audiobuffersource.html:
- webaudio/audiobuffersourcenode-legacy-api-expected.txt:
- webaudio/audiobuffersourcenode-legacy-api.html:
- webaudio/audiochannelmerger-basic.html:
- webaudio/audiochannelmerger-stereo.html:
- webaudio/audiochannelsplitter.html:
- webaudio/audiocontext-promise-throwing-expected.txt:
- webaudio/audiocontext-promise-throwing.html:
- webaudio/audiocontext-promise.html:
- webaudio/audiocontext-restriction-audiobuffersourcenode-start.html:
- webaudio/audiocontext-restriction.html:
- webaudio/audiocontext-state-interrupted.html:
- webaudio/audiocontext-state.html:
- webaudio/audionode-connect-order.html:
- webaudio/audionode.html:
- webaudio/audioparam-connect-audioratesignal.html:
- webaudio/audioparam-summingjunction.html:
- webaudio/audioprocessingevent.html:
- webaudio/automatic-pull-node.html:
- webaudio/convolution-mono-mono.html:
- webaudio/convolver-channels.html:
- webaudio/convolver-setBuffer-different-samplerate.html:
- webaudio/convolver-setBuffer-null.html:
- webaudio/createMediaStreamSource-null-expected.txt:
- webaudio/createMediaStreamSource-null.html:
- webaudio/decode-audio-data-basic-expected.txt:
- webaudio/decode-audio-data-basic.html:
- webaudio/decode-audio-data-too-short.html:
- webaudio/delaynode-max-default-delay.html:
- webaudio/delaynode-max-nondefault-delay.html:
- webaudio/delaynode-maxdelay.html:
- webaudio/delaynode-maxdelaylimit.html:
- webaudio/delaynode-scheduling.html:
- webaudio/delaynode.html:
- webaudio/distance-exponential.html:
- webaudio/distance-inverse.html:
- webaudio/distance-linear.html:
- webaudio/dynamicscompressor-basic.html:
- webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html:
- webaudio/gain-basic.html:
- webaudio/gain.html:
- webaudio/mediaelementaudiosourcenode-expected.txt:
- webaudio/mediaelementaudiosourcenode-gc.html:
- webaudio/mediaelementaudiosourcenode.html:
- webaudio/mixing.html:
- webaudio/offlineaudiocontext-gc.html:
- webaudio/offlineaudiocontext-restriction.html:
- webaudio/oscillatornode-legacy-api-expected.txt:
- webaudio/oscillatornode-legacy-api.html:
- webaudio/page-canstartmedia.html:
- webaudio/panner-equalpower-stereo.html:
- webaudio/panner-equalpower.html:
- webaudio/prefixed-pannernode-basic-expected.txt: Removed.
- webaudio/prefixed-pannernode-basic.html: Removed.
- webaudio/realtimeanalyser-fft-sizing-expected.txt:
- webaudio/realtimeanalyser-fft-sizing.html:
- webaudio/resources/audio-codec-test.js:
(runDecodingTest):
- webaudio/resources/audiobuffersource-ended-detached-frame-iframe.html:
- webaudio/resources/audioparam-testing-legacy.js:
(createAudioGraphAndTest):
- webaudio/resources/compatibility.js: Removed.
- webaudio/resources/javascriptaudionode-testing.js:
(runJSNodeTest):
- webaudio/resources/oscillator-testing-legacy.js:
(generateExponentialOscillatorSweep):
- webaudio/sample-accurate-scheduling.html:
- webaudio/silence-after-playback.html:
- webaudio/silent-audio-interrupted-in-background.html:
- webaudio/stereo2mono-down-mixing.html:
- webaudio/test-basic.html:
- webaudio/up-mixing-mono-51.html:
- webaudio/up-mixing-mono-stereo.html:
- webaudio/up-mixing-stereo-51.html:
- webaudio/waveshaper.html:
- webaudio/web-audio-is-playing.html:
- webaudio/webaudio-gc.html:
- webaudio/webkitofflineaudiocontext-startRendering-crash-expected.txt:
- webaudio/webkitofflineaudiocontext-startRendering-crash.html:
- webrtc/audio-peer-connection-g722.html:
- webrtc/audio-peer-connection-webaudio.html:
- webrtc/clone-audio-track.html:
- webrtc/getUserMedia-webaudio-autoplay.html:
- webrtc/peer-connection-audio-mute.html:
- webrtc/peer-connection-audio-mute2.html:
- webrtc/peer-connection-createMediaStreamDestination.html:
- webrtc/peer-connection-remote-audio-mute.html:
- webrtc/peer-connection-remote-audio-mute2.html:
- webrtc/routines.js:
- 3:31 PM Changeset in webkit [267503] by
-
- 11 edits in trunk
[css-grid] Clear the override width for computing percent margins
https://bugs.webkit.org/show_bug.cgi?id=209461
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Update test expectations.
The 2 grid-items-percentage-paddings tests are now expected to have some
failures because of bug 191964. In fact they were already failing before
this patch, as can be seen in wpt.fyi:
https://wpt.fyi/results/css/css-grid/grid-items?q=grid-items-percentage-paddings-vertical-%20-002.html
It's just that the bug that is being fixed made the test runner think
that the tests were passing, probably some racy condition or such.
- web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt:
- web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001-expected.txt:
- web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001-expected.txt:
- web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt:
- web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt:
Source/WebCore:
When calculating the min-content contribution of a grid item of an auto
sized grid track we must consider the grid item's margin. When the grid
item's area is indefinite, a percent margin is resolved to zero.
However, when performing a relayout, the percent margin may be solved
against the previously computed grid area, since the grid item has
already an OverrideContainingBlockLogicalWidth value.
In order to re-compute the percent margin properly, we need to clear
the previously override value. It's important to be careful of not
clearing the override value set during intrinsic size, since we need
it for the actual layout phase. Hence, we only reset the 'override'
value when we are executing a definite strategy.
This is a reland of r261841, which was reverted because it broke spotify.
This problem is now avoided thanks to bug 210089.
Tests: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-003.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-004.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-005.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-006.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-007.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-008.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-009.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-010.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-005.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-006.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-009.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-010.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002.html
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::hasRelativeMarginOrPaddingForChild):
(WebCore::hasRelativeOrIntrinsicSizeForChild):
(WebCore::shouldClearOverrideContainingBlockContentSizeForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const):
(WebCore::DefiniteSizeStrategy::minContentForChild const):
- rendering/GridTrackSizingAlgorithm.h:
LayoutTests:
Update test expectations.
- 3:14 PM Changeset in webkit [267502] by
-
- 31 edits in trunk
[GTK][WPE] Move TLS errors API from WebKitContext to WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=216822
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-09-23
Reviewed by Alex Christensen.
Source/WebCore:
Make ignoreTLSErrors a member of SoupNetworkSession, instead of being global.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::setIgnoreTLSErrors):
(WebCore::SoupNetworkSession::checkTLSErrors):
(WebCore::SoupNetworkSession::setShouldIgnoreTLSErrors): Deleted.
- platform/network/soup/SoupNetworkSession.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setAllowsAnySSLCertificate): Do not use SoupNetworkSession in the web process.
Source/WebKit:
Make TLS errors policy per session instead of global to the network process. The web context API now simply
forwards the request to the website data manager. The website data manager created for an ephemeral web view
will inherit the network settings from the web context website data manager. This ensures backwards
compatibility, but it's also convenient, since it's the desired behavior in most of the cases. Apps can still
change the network settings of the web view by getting the website data manager.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificate):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setIgnoreTLSErrors):
- NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::NetworkSessionSoup):
(WebKit::webSocketAcceptCertificateCallback):
(WebKit::webSocketMessageNetworkEventCallback):
(WebKit::NetworkSessionSoup::createWebSocketTask):
(WebKit::NetworkSessionSoup::setIgnoreTLSErrors):
- NetworkProcess/soup/NetworkSessionSoup.h:
- UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionCreate):
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
(webkit_web_context_set_tls_errors_policy):
(webkit_web_context_get_tls_errors_policy):
- UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerConstructed):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_set_tls_errors_policy):
(webkit_website_data_manager_get_tls_errors_policy):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebsiteDataManager.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/wpe/WebKitWebContext.h:
- UIProcess/API/wpe/WebKitWebsiteDataManager.h:
- UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::ignoreTLSErrors const):
- UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::setIgnoreTLSErrors):
- UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted.
Tools:
Update tests to use the new API instead of the deprecated one. Also update the TLSErrorsPolicy test to also
check that ephemeral web views inherit the network settings from its web context.
- TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(testSSL):
(testInsecureContent):
(testTLSErrorsPolicy):
(testTLSErrorsRedirect):
(testTLSErrorsHTTPAuth):
(testLoadFailedWithTLSErrors):
(testSubresourceLoadFailedWithTLSErrors):
(testWebSocketTLSErrors):
- 2:54 PM Changeset in webkit [267501] by
-
- 3 edits in trunk/Tools
Force SYSTEM_VERSION_COMPAT=0 in Webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=216895
<rdar://problem/69454393>
Reviewed by Dewei Zhu.
- Scripts/configure-xcode-for-embedded-development:
- Scripts/webkitpy/init.py:
- 2:26 PM Changeset in webkit [267500] by
-
- 8 edits in trunk
[JSC] Intl spec update: handle awkward rounding behavior
https://bugs.webkit.org/show_bug.cgi?id=216760
Reviewed by Ross Kirsling.
JSTests:
- stress/intl-numberformat.js:
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch supports new spec change of "handle awkward rounding behavior"[1].
This changes minimumFractionDigits / maximumFractionDigits calculation when the specified ones are less than currency-digits.
[1]: https://github.com/tc39/ecma402/pull/471
- runtime/CommonIdentifiers.h:
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::resolvedOptions const):
- runtime/IntlNumberFormatInlines.h:
(JSC::setNumberFormatDigitOptions):
- runtime/IntlPluralRules.cpp:
(JSC::IntlPluralRules::resolvedOptions const):
- 2:17 PM Changeset in webkit [267499] by
-
- 2 edits in trunk/Source/WebCore
Fix some typo'd wheel event listener logging
https://bugs.webkit.org/show_bug.cgi?id=216892
Reviewed by Wenson Hsieh.
- rendering/EventRegion.cpp:
(WebCore::EventRegion::uniteEventListeners):
Wheel is passive, NonPassiveWheel is active.
- 12:52 PM Changeset in webkit [267498] by
-
- 6 edits in trunk/Source/WebKit
[macOS] Issue sandbox extension for the diagnostic daemon
https://bugs.webkit.org/show_bug.cgi?id=216834
<rdar://problem/58496834>
Reviewed by Brent Fulgham.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::isInternalInstall):
(WebKit::agxCompilerClasses):
(WebKit::diagnosticServices):
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/com.apple.WebProcess.sb.in:
- 12:50 PM Changeset in webkit [267497] by
-
- 85 edits in trunk
Remove ENABLE_SVG_FONTS macro
https://bugs.webkit.org/show_bug.cgi?id=216850
Reviewed by Don Olmstead.
.:
No ports have this disabled, so remove it.
- Source/cmake/OptionsFTW.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/WebCore:
- CMakeLists.txt:
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::appendSources):
(WebCore::CSSFontFace::hasSVGFontFaceSource const):
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::load):
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::isSVGFontFaceSource const):
- css/CSSFontFaceSource.h:
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSVGFontTarget const):
(WebCore::CSSFontFaceSrcValue::isSupportedFormat const):
- css/CSSFontFaceSrcValue.h:
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::inspectorResourceType):
- loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient):
- loader/ResourceLoadInfo.cpp:
(WebCore::ContentExtensions::toResourceType):
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType):
(WebCore::CachedResource::isCORSSameOrigin const):
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest):
(WebCore::destinationForType):
- loader/cache/CachedSVGFont.cpp:
- loader/cache/CachedSVGFont.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::getStatistics):
- rendering/svg/SVGTextLayoutEngineSpacing.cpp:
- style/StyleResolver.cpp:
(WebCore::Style::Resolver::addCurrentSVGFontFaceRules):
- svg/SVGAltGlyphDefElement.cpp:
- svg/SVGAltGlyphDefElement.h:
- svg/SVGAltGlyphDefElement.idl:
- svg/SVGAltGlyphElement.cpp:
- svg/SVGAltGlyphElement.h:
- svg/SVGAltGlyphElement.idl:
- svg/SVGAltGlyphItemElement.cpp:
- svg/SVGAltGlyphItemElement.h:
- svg/SVGAltGlyphItemElement.idl:
- svg/SVGDocumentExtensions.cpp:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::childShouldCreateRenderer const):
- svg/SVGFontElement.cpp:
- svg/SVGFontElement.h:
- svg/SVGFontElement.idl:
- svg/SVGFontFaceElement.cpp:
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceElement.idl:
- svg/SVGFontFaceFormatElement.cpp:
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceFormatElement.idl:
- svg/SVGFontFaceNameElement.cpp:
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceNameElement.idl:
- svg/SVGFontFaceSrcElement.cpp:
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceSrcElement.idl:
- svg/SVGFontFaceUriElement.cpp:
- svg/SVGFontFaceUriElement.h:
- svg/SVGFontFaceUriElement.idl:
- svg/SVGGlyphElement.cpp:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphElement.idl:
- svg/SVGGlyphRefElement.cpp:
- svg/SVGGlyphRefElement.h:
- svg/SVGGlyphRefElement.idl:
- svg/SVGHKernElement.cpp:
- svg/SVGHKernElement.h:
- svg/SVGHKernElement.idl:
- svg/SVGMissingGlyphElement.cpp:
- svg/SVGMissingGlyphElement.h:
- svg/SVGMissingGlyphElement.idl:
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::rendererIsNeeded):
- svg/SVGTSpanElement.cpp:
(WebCore::SVGTSpanElement::childShouldCreateRenderer const):
(WebCore::SVGTSpanElement::rendererIsNeeded):
- svg/SVGTests.cpp:
(WebCore::supportedSVGFeatures):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::childShouldCreateRenderer const):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::elementFromRenderer):
- svg/SVGToOTFFontConversion.cpp:
- svg/SVGVKernElement.cpp:
- svg/SVGVKernElement.h:
- svg/SVGVKernElement.idl:
- svg/svgtags.in:
Source/WebKit:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
Source/WTF:
- wtf/PlatformEnable.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 12:39 PM Changeset in webkit [267496] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Change name of client decoder entitlement
https://bugs.webkit.org/show_bug.cgi?id=216670
<rdar://problem/69101997>
Reviewed by Darin Adler.
The client decoder entitlement landed in <https://trac.webkit.org/changeset/266613/webkit> has changed name, and should be updated.
- Scripts/process-entitlements.sh:
- 12:35 PM Changeset in webkit [267495] by
-
- 3 edits3 adds in trunk
Missing scope release in JSDOMBuiltinConstructorBase
https://bugs.webkit.org/show_bug.cgi?id=216851
<rdar://problem/69144642>
Reviewed by Yusuke Suzuki.
Source/WebCore:
In JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments, we should release the
ThrowScope before calling into JavaScript since we don't intend to handle the exception.
Test: js/transform-stream.html
- bindings/js/JSDOMBuiltinConstructorBase.cpp:
(WebCore::JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments):
LayoutTests:
- js/script-tests/transform-stream.js: Added.
- js/transform-stream-expected.txt: Added.
- js/transform-stream.html: Added.
- 12:34 PM Changeset in webkit [267494] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Precompute the collapsible trailing width for LineBreaker
https://bugs.webkit.org/show_bug.cgi?id=216881
Reviewed by Antti Koivisto.
Let's just compute the collapsible trailing width while adding inline content to LineCandidate instead of
reverse looping through the runs in LineBreaker.
This is also in preparation for reducing the number of RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled calls.
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::ContinuousContent::hasTrailingCollapsibleContent const):
(WebCore::Layout::ContinuousContent::isFullyCollapsible const):
(WebCore::Layout::LineBreaker::shouldKeepEndOfLineWhitespace const):
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::ContinuousContent::ContinuousContent):
(WebCore::Layout::ContinuousContent::nonCollapsibleLogicalWidth const):
(WebCore::Layout::ContinuousContent::isTrailingContentFullyCollapsible const): Deleted.
(WebCore::Layout::ContinuousContent::TrailingCollapsibleContent::reset): Deleted.
- layout/inlineformatting/InlineLineBreaker.h:
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::collapsibleTrailingWidth const):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineCandidate::InlineContent::reset):
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
- 12:17 PM Changeset in webkit [267493] by
-
- 2 edits in trunk/Tools
Limit number of emails to send for flaky and pre-existing API and layout test failures
https://bugs.webkit.org/show_bug.cgi?id=216876
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(ReRunWebKitTests): Simply limit the flaky failures immediately after they are calculated, since we don't display
the count of flaky failures. Flaky failures are displayed only to help bot-watchers in noticing flaky tests.
(AnalyzeLayoutTestsResults.report_pre_existing_failures): Limit pre-existing and flaky test failures just before sending emails.
(AnalyzeAPITestsResults.analyzeResults):
- 12:07 PM Changeset in webkit [267492] by
-
- 4 edits in trunk/Tools
Notify igalia team about pre-existing test failures and build failures for JSC queues
https://bugs.webkit.org/show_bug.cgi?id=216889
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Send email for pre-existing jsc build failures.
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure): Send email for pre-existing jsc test failure.
- BuildSlaveSupport/ews-build/send_email.py:
- BuildSlaveSupport/ews-build/emails.json: Added email address of igalia jsc team.
- 11:45 AM Changeset in webkit [267491] by
-
- 14 edits in trunk/Source
[Media in GPU Process] Implement caption support in video fullscreen and PiP
https://bugs.webkit.org/show_bug.cgi?id=208752
Reviewed by Eric Carlson.
Source/WebCore:
Export TextTrackRepresentation so that WebKit can use it. Also, update the
interface of VideoLayerManagerObjC related to text track representation to
use PlatformLayer* instead of TextTrackRepresentation*.
Manually tested.
- WebCore.xcodeproj/project.pbxproj:
Change target membership of TextTrackRepresentation.h.
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::setTextTrackRepresentationLayer):
(WebCore::VideoLayerManagerObjC::setTextTrackRepresentation): Deleted.
Replace setTextTrackRepresentation() with setTextTrackRepresentationLayer().
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation):
Use VideoLayerManagerObjC::setTextTrackRepresentationLayer() instead of
VideoLayerManagerObjC::setTextTrackRepresentation().
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setTextTrackRepresentation): Ditto.
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::syncTextTrackBounds): Deleted.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
Remove syncTextTrackBounds() because the GPU process does not need to deal with
the text track bounds.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
Add a missing IPC message receiver.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer): Set the flag
m_requiresTextTrackRepresentation when changing video presentation mode.
(WebKit::MediaPlayerPrivateRemote::requiresTextTrackRepresentation const): Deleted.
(WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation): Deleted.
(WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds): Deleted.
Move the implementation of those functions to MediaPlayerPrivateRemoteCocoa.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
Add the flag m_requiresTextTrackRepresentation and add a reference
to the layer used to render text track (in fullscreen or picture-in-picture).
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
(WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation):
(WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds):
Those functions share a similar implementation as VideoLayerManagerObjC.
- 10:55 AM Changeset in webkit [267490] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Start collecting telemetry from a set of XPC services
<https://bugs.webkit.org/show_bug.cgi?id=216797>
Reviewed by Brent Fulgham.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:19 AM Changeset in webkit [267489] by
-
- 50 edits20 adds2 deletes in trunk
[JSC][ESNext] Create a new opcode to handle private fields store/define
https://bugs.webkit.org/show_bug.cgi?id=213372
Reviewed by Yusuke Suzuki.
JSTests:
Adjusting tests that emit
get_private_nameto avoid execution in
FTL/DFG.
- microbenchmarks/class-fields-private/polymorphic-put-private-field.js: Added.
- microbenchmarks/class-fields-private/put-private-field.js: Added.
- microbenchmarks/polymorphic-put-public-field.js: Added.
- microbenchmarks/put-public-field.js: Added.
- stress/dfg-put-private-name-check-barrier-insertion.js: Added.
- stress/dfg-put-private-name-compiled-as-put-by-id-direct.js: Added.
- stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js: Added.
- stress/put-private-name-by-id-set-do-not-add-structure-trasition.js: Added.
- stress/put-private-name-check-structure-miss.js: Added.
- stress/put-private-name-constant-folding-to-mult-put-by-offset.js: Added.
- stress/put-private-name-constant-folding-to-put-by-offset.js: Added.
- stress/put-private-name-generic.js: Added.
- stress/put-private-name-invalid-define.js: Added.
- stress/put-private-name-invalid-store.js: Added.
- stress/put-private-name-invalidate-compiled-with-constant-symbol.js: Added.
- stress/put-private-name-polymorphic-with-constant-symbol.js: Added.
- stress/put-private-name-with-constant-symbol.js: Added.
- stress/put-private-name-with-different-identifier.js: Added.
Source/JavaScriptCore:
This patch is adding a new opcode to handle private field storage.
Before this change, we were usingput_by_val_directand including
the information ofPutKindintoPutByValFlags. We initially decided
to useput_by_val_directto take advantage of all IC mechanism already
implemented for this instruction, however the semantics of private field
is different enough to complicate the understanding of
put_by_val_direct.
The new instruction is called
put_private_nameand has as its operands
baseObjectwhere the put is going to be placed, theproperty
that's going to be installed (it is always a private symbol of a
private field), thevaluewe are going to store and the
PrivateFieldPutKindthat can beDefineorSet.
The difference of eachPrivateFieldPutKindis the following:
- Define: It defines a new private field. If this field is already
present, it throws a
TypeError.
- Set: It sets the value of a private field. If the field is not
present at the moment of set, it throws a
TypeError.
This patch includes support of IC for all tiers. For DFG and FTL, we
are only emmiting IC when we are able to emitCheckConstant
for subscript identifier during Bytecode parsing. We are adding a new
DFG node calledPutPrivateNameByIdthat handles such cases when we
have constant identifiers.
We are also adding a new DFG nodePutPrivateNamethat handles generic
case ofput_private_name. The strategy used to compile
put_private_nameis very similar with what we are using with
put_by_val[_direct]. We first try to compile it as[Multi]PutByOffset
using profiled information from LLInt and Baseline execution. If it
is not possible, we then emitPutPrivateName[ById]node. We get another
chance to transformPutPrivateNameByIdintoPutByOffsetif we can prove
its structure set at constant folding phase.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- bytecode/BytecodeList.rb:
- bytecode/BytecodeUseDef.cpp:
(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
- bytecode/Fits.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- bytecode/PutByValFlags.cpp: Removed.
- bytecode/PutByValFlags.h: Removed.
- bytecode/PutKind.h:
(): Deleted.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutByVal):
(JSC::BytecodeGenerator::emitDefinePrivateField):
(JSC::BytecodeGenerator::emitPrivateFieldPut):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handlePutPrivateNameById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):
(JSC::DFG::ecmaMode): Deleted.
(JSC::DFG::ecmaMode<OpPutByValDirect>): Deleted.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::tryFoldAsPutByOffset):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::convertToMultiPutByOffset):
(JSC::DFG::Node::hasCacheableIdentifier):
(JSC::DFG::Node::hasPrivateFieldPutKind):
(JSC::DFG::Node::privateFieldPutKind):
- dfg/DFGNodeType.h:
- dfg/DFGOpInfo.h:
(JSC::DFG::OpInfo::OpInfo):
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutPrivateName):
(JSC::DFG::SpeculativeJIT::compilePutPrivateNameById):
(JSC::DFG::SpeculativeJIT::compilePutByIdFlush):
(JSC::DFG::SpeculativeJIT::compilePutById):
(JSC::DFG::SpeculativeJIT::compilePutByIdDirect):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStoreBarrierInsertionPhase.cpp:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateNameById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutPrivateName):
(JSC::FTL::DFG::LowerDFGToB3::cachedPutById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutById):
- generator/DSL.rb:
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::link):
- jit/JIT.h:
(JSC::ByValCompilationInfo::ByValCompilationInfo):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::slowPathFunction):
- jit/JITInlineCacheGenerator.h:
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlines.h:
(JSC::JIT::ecmaMode<OpPutPrivateName>):
(JSC::JIT::ecmaMode<OpPutByValDirect>): Deleted.
(JSC::JIT::privateFieldAccessKind): Deleted.
(JSC::JIT::privateFieldAccessKind<OpPutByValDirect>): Deleted.
- jit/JITOperations.cpp:
(JSC::setPrivateField):
(JSC::putPrivateField): Deleted.
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitPutPrivateNameWithCachedId):
(JSC::JIT::privateCompilePutPrivateNameWithCachedId):
(JSC::JIT::privateCompilePutByValWithCachedId):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::emit_op_put_by_id):
- jit/Repatch.cpp:
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateOptimizingPutByIdFunction):
(JSC::tryCachePutByID):
(JSC::resetPutByID):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSObject.h:
- runtime/JSObjectInlines.h:
(JSC::JSObject::setPrivateField):
(JSC::JSObject::putPrivateField): Deleted.
- runtime/PrivateFieldPutKind.cpp: Added.
(JSC::PrivateFieldPutKind::dump const):
- runtime/PrivateFieldPutKind.h: Added.
(JSC::PrivateFieldPutKind::fromByte):
(JSC::PrivateFieldPutKind::none):
(JSC::PrivateFieldPutKind::set):
(JSC::PrivateFieldPutKind::define):
(JSC::PrivateFieldPutKind::isNone const):
(JSC::PrivateFieldPutKind::isSet const):
(JSC::PrivateFieldPutKind::isDefine const):
(JSC::PrivateFieldPutKind::value const):
(JSC::PrivateFieldPutKind::PrivateFieldPutKind):
- 10:10 AM Changeset in webkit [267488] by
-
- 4 edits in trunk/Source
Turn on the modern unprefixed WebAudio API
https://bugs.webkit.org/show_bug.cgi?id=216885
Reviewed by Eric Carlson.
Turn on the modern unprefixed WebAudio API now that we support most of the API
besides AudioWorklet and now that we have a good pass rate on WPT tests.
Source/WebKit:
- Shared/WebPreferencesExperimental.yaml:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- 10:07 AM Changeset in webkit [267487] by
-
- 4 edits in branches/safari-611.1.1-branch
Cherry-pick r267439. rdar://problem/69441287
REGRESSION(r266075): WebContent process crashes at TextManipulationController::getPath
https://bugs.webkit.org/show_bug.cgi?id=216846
Reviewed by Wenson Hsieh.
Source/WebCore:
TextIterator does not visit node that has no renderer, so if node has become hidden, TextManipulationController
will not find content node in paragraph range during replacement.
API Test: TextManipulation.CompleteTextManipulationParagraphBecomesHidden
- editing/TextManipulationController.cpp: (WebCore::TextManipulationController::replace):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:07 AM Changeset in webkit [267486] by
-
- 4 edits in trunk
webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=216827
Reviewed by Darin Adler.
Source/WebCore:
AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping() would hit an assertion inside
finish() because finish() was already called earlier when calling updateSchedulingInfo().
updateSchedulingInfo() already takes care of calling finish() when we're done playing.
Address the issue by only calling finish() if hasFinished() returns false.
No new tests, unskipped existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderSilenceAndFinishIfNotLooping):
LayoutTests:
Unskip test that is no longer crashing.
- 10:00 AM Changeset in webkit [267485] by
-
- 1 move in branches/safari-611.1.1-branch
Rename safari-611.1-branch to safari-611.1.1-branch
- 9:54 AM Changeset in webkit [267484] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, add ios baseline for media/media-can-play-av1.html
This was forgotten in r267474.
- platform/ios/media/media-can-play-av1-expected.txt: Added.
- 9:43 AM Changeset in webkit [267483] by
-
- 1 copy in branches/safari-611.1-branch
New branch.
- 9:41 AM Changeset in webkit [267482] by
-
- 2 edits in branches/safari-610.2.6.1-branch/Source/WebKit
Cherry-pick r267412. rdar://problem/69439628
Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
Reviewed by Tim Horton.
To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.
This is a speculative fix due to the aforementioned reproducibility issue.
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed" checks. So put an explicit check here followed by an explicit release assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:41 AM Changeset in webkit [267481] by
-
- 2 edits in branches/safari-610.2.6.1-branch/Source/JavaScriptCore
Cherry-pick r267304. rdar://problem/69439749
[JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct
https://bugs.webkit.org/show_bug.cgi?id=216717
Reviewed by Mark Lam.
When starting full GC, at beginMarking, PreciseAllocation's mark bit is cleared to be usable for upcoming marking.
However, this means that HeapCell::isLive will see this object as dead until it is marked.
Let's consider that this object is not newly allocated one. Then, its isNewlyAllocated is false. And now mark bit
is also cleared. Since PreciseAllocation::isLive is isNewlyAllocated isMarked, then it looks dead, while it is live. This confuses HeapCell:isLive function and makes some of watchpoints perform wrong decisions (e.g. this condition is
no longer valid, let's just discard it).
At the beginning of full collection, we should propagate the old mark bit to isNewlyAllocated so that it looks live
during marking. This is similar trick to MarkedBlock::aboutToMark.
- heap/PreciseAllocation.cpp: (JSC::PreciseAllocation::flip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:38 AM Changeset in webkit [267480] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.5
- 9:03 AM Changeset in webkit [267479] by
-
- 6 edits in trunk
Unreviewed, reverting r267403.
Caused 50+ Crashes on iOS Debug
Reverted changeset:
"Move Media in GPU Process flag from internal to experimental"
https://bugs.webkit.org/show_bug.cgi?id=216473
https://trac.webkit.org/changeset/267403
- 8:57 AM Changeset in webkit [267478] by
-
- 2 edits in trunk/Tools
REGRESSION(r267368) [webkitpy] autoinstalled pytest raises ImportError in run-webdriver-tests
https://bugs.webkit.org/show_bug.cgi?id=216879
Reviewed by Jonathan Bedard.
Autoinstalled pytest requires sys.path to be updated with the newly
installed packages. Before r267368 it worked because
webdriver_w3c_executor.py autoinstalled mozlog/mozprocess which
updated the sys.path.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._install_pytest):
- 8:53 AM Changeset in webkit [267477] by
-
- 6 edits in trunk
Fix for accessibility/aria-combobox-control-owns-elements.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=216878
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/aria-combobox-control-owns-elements.html.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree): Update the isolated tree
node for ActiveDescendant and SelectedChildren notifications.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData): Only cache
selectedChildren for those AXObjects that canHaveSelectedChildren.
LayoutTests:
Use Promises to make this test work reliably for both single and multithreaded accessibility modes.
- accessibility/aria-combobox-control-owns-elements-expected.txt:
- accessibility/aria-combobox-control-owns-elements.html:
- 8:50 AM Changeset in webkit [267476] by
-
- 19 edits in trunk/LayoutTests
Selection API: Update more tests that depend on WebKit's legacy non-standard behavior to set up the selection
https://bugs.webkit.org/show_bug.cgi?id=216844
Reviewed by Ryosuke Niwa.
Discovered a batch of editing tests that accidentally rely on non-standard selection
behavior to set up the tests. In many cases, the tests were clearly written wrong, like
using character offsets but a container that is not a text node. These changes keep the
tests testing the same things they are today.
- editing/deleting/delete-block-merge-contents-025.html: Use the actual number of child
nodes rather than 2000000000.
- editing/deleting/delete-blockquote-large-offsets.html: Ditto. The "large offsets" in
the title of this bug might simply be something that can't actually be done in practice,
setting an offset that is much higher than the actual number of children. The old code
simply clamped the high value.
- editing/execCommand/format-block-typing-style.html: Use a 1 as an offset so we are
past the child text element, rather than 5, which was presumably an attempt at setting
an offset to a particular character, but using the wrong container node.
- editing/execCommand/insert-nested-lists-in-table.html: Use a computed offset instead
of a hardcoded, and too high, value of 3.
- editing/execCommand/outdent-selection.html: Use a 1 instead of a 2 for an offset on
a container node that has only one child.
- editing/input/select-all-clear-input-method.html: Use a 3 instead of a 5 for an
offset in a container that's a text node containing 3 characters.
- editing/inserting/insert-list-during-node-removal-crash.html: This one is a little
different. The code selected the entire document and used the deleteFromDocument method.
That function is specified to not do an end-user "editing" delete, but to literally
delete all the nodes. That includes all the script nodes. To fix the test, just select
the contents of the body of the document.
- editing/inserting/insert-list-in-table-assert.html: Use a 0 instead of a 1
for an offset inside an empty style element.
- editing/inserting/insert-list-in-table-cell-04.html: Use a 1 instead of a 2
as the offest for the end of the element, given the element had only one child.
- editing/inserting/insert-list-in-table-cell-08.html: Ditto.
- editing/inserting/page-zoom-font-size.html: Ditto, 1 instead of 12.
- editing/inserting/replace-at-visible-boundary.html: Select the image by setting end
points before and after it, rather than trying to set offsets inside the image with
offsets of 0 and 1, since 1 is an illegal offset in an image with no children.
- editing/pasteboard/dataTransfer-setData-getData.html: Use a 1 instead of a 4
for an offset inside the dragme element, which has one child, which was presumably
an attempt at setting an offset to a particular character, but using the wrong
container node.
- editing/pasteboard/drag-drop-to-data-url.html: Ditto.
- editing/pasteboard/paste-blockquote-into-blockquote-2.html: Use an offset of 1
instead of 3 inside the block element which has no children, which was presumably
an attempt at setting an offset to a particular character, but using the wrong
container node.
- editing/pasteboard/paste-blockquote-into-blockquote-3.html: Use a range to set
the selection after the endContent <br> element rather than trying to use an
offset of 1 inside that element, which has no children.
- editing/pasteboard/paste-blockquote-into-blockquote.html: Use an offset of 1
instead of 3 inside the block element which has no children, which was presumably
an attempt at setting an offset to a particular character, but using the wrong
container node.
- editing/pasteboard/paste-table-cells.html: Use an offset of 1 instead of 3
inside the table, so the selection is after the table body. Presumably the error
is that someone thought that the table row elements were each children of the table.
- 8:20 AM Changeset in webkit [267475] by
-
- 3 edits in branches/safari-610-branch/LayoutTests
[ iPadOS wk2 ] fast/forms/ios/time-picker-value-change.html times out or fails and REGRESSION: [ iOS wk2 ] http/wpt/cache-storage/quota-third-party.https.html is a flaky failure
rdar://69407691, rdar://63108701
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-wk2/TestExpectations:
- 7:44 AM Changeset in webkit [267474] by
-
- 6 edits1 add in trunk
media/can-play-av1.html is not spec compliant
https://bugs.webkit.org/show_bug.cgi?id=216873
Reviewed by Eric Carlson.
Source/WebCore:
- platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::initialize): Add the "av1" codec in the codecs mapping.
LayoutTests:
- media/media-can-play-av1-expected.txt: Update baseline.
- media/media-can-play-av1.html: Update test and add another few testing invalid codecs.
- platform/glib/TestExpectations: Unflag passing test.
- platform/mac/media/media-can-play-av1-expected.txt: Added. This test is expected to fail on mac.
- 7:29 AM Changeset in webkit [267473] by
-
- 1 edit2 adds in branches/safari-610-branch/LayoutTests
[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
https://bugs.webkit.org/show_bug.cgi?id=215667
Unreviewed test gardening.
- platform/ios/fast/text/opticalFontWithTextStyle-expected.txt: Added.
- platform/ios/fast/text/opticalFontWithTextStyle.html: Added.
- 7:04 AM Changeset in webkit [267472] by
-
- 39 edits1 copy12 adds in trunk
Add support for HTMLMediaElement.setSinkId
https://bugs.webkit.org/show_bug.cgi?id=216696
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/audio-output/META.yml: Added.
- web-platform-tests/audio-output/idlharness.https.window-expected.txt: Added.
- web-platform-tests/audio-output/idlharness.https.window.html: Added.
- web-platform-tests/audio-output/idlharness.https.window.js: Added.
- web-platform-tests/audio-output/setSinkId.https-expected.txt: Added.
- web-platform-tests/audio-output/setSinkId.https.html: Added.
- web-platform-tests/audio-output/w3c-import.log: Added.
Source/WebCore:
Implement setSinkId and sinkId as per https://w3c.github.io/mediacapture-output/#htmlmediaelement-extensions.
Introduce a setting to expose these methods and to enable/disable user gesture requirement.
Add interfaces to change device output for specific media players.
Add support for HLS, MSE and MediaStreamTrack renderers on MacOS.
In case of setting the empty string, the default output device is used
Tests: http/wpt/audio-output/setSinkId.https.html
imported/w3c/web-platform-tests/audio-output/idlharness.https.window.html
imported/w3c/web-platform-tests/audio-output/setSinkId.https.html
- CMakeLists.txt:
- DerivedSources.make:
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::exposeDevices):
- Modules/mediastream/MediaDevices.h:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::audioOutputDevice const):
(WebCore::HTMLMediaElement::setAudioOutputDevice):
(WebCore::HTMLMediaElement::audioOutputDeviceId const):
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::audioOutputHashedDeviceId const):
- html/HTMLMediaElementAudioOutput.idl: Added.
- page/Settings.yaml:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::audioOutputDeviceChanged):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::audioOutputDeviceId const):
(WebCore::MediaPlayerClient::audioOutputDeviceIdOverride const):
(WebCore::MediaPlayer::audioOutputDeviceId const):
(WebCore::MediaPlayer::audioOutputDeviceIdOverride const):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::audioOutputDeviceChanged):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::audioOutputDeviceChanged):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::audioOutputDeviceChanged):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::audioOutputDeviceChanged):
- platform/mediastream/AudioMediaStreamTrackRenderer.h:
(WebCore::AudioMediaStreamTrackRenderer::setAudioOutputDevice):
- platform/mediastream/AudioTrackPrivateMediaStream.cpp:
(WebCore::AudioTrackPrivateMediaStream::setAudioOutputDevice):
- platform/mediastream/AudioTrackPrivateMediaStream.h:
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.cpp:
(WebCore::AudioMediaStreamTrackRendererCocoa::setAudioOutputDevice):
(WebCore::AudioMediaStreamTrackRendererCocoa::pushSamples):
- platform/mediastream/mac/AudioMediaStreamTrackRendererCocoa.h:
- platform/mediastream/mac/AudioMediaStreamTrackRendererUnit.cpp:
(WebCore::AudioMediaStreamTrackRendererUnit::setAudioOutputDevice):
(WebCore::AudioMediaStreamTrackRendererUnit::createAudioUnitIfNeeded):
- platform/mediastream/mac/AudioMediaStreamTrackRendererUnit.h:
Source/WebKit:
Add internal flag to enable/disable user gesture requirement for setting audio output device,
and for per media element setting of audio output device.
- Shared/WebPreferencesExperimental.yaml:
- Shared/WebPreferencesInternals.yaml:
Source/WTF:
Add HAVE_AUDIO_OUTPUT_DEVICE_UNIQUE_ID.
- wtf/PlatformHave.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
LayoutTests:
Skip new tests on WK1 since mediaDevices is not implemented in WK1.
- http/wpt/audio-output/setSinkId.https-expected.txt: Added.
- http/wpt/audio-output/setSinkId.https.html: Added.
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 6:36 AM Changeset in webkit [267471] by
-
- 9 edits1 add in trunk
REGRESSION(r267383): fast/mediastream/getUserMedia-webaudio.html is failing
https://bugs.webkit.org/show_bug.cgi?id=216813
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Revert r267428 and fixup the GStreamer FFT implementation which broke in r267383.
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::multiply):
- platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::multiply): Deleted.
- platform/audio/gstreamer/FFTFrameGStreamer.cpp:
(WebCore::FFTFrame::doFFT): Update the real and imaginary arrays after applying the FFT.
(WebCore::FFTFrame::multiply): Deleted.
- platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::multiply): Deleted.
LayoutTests:
Unflag passing tests.
- platform/glib/TestExpectations:
- platform/glib/webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt:
- platform/glib/webaudio/Analyser/realtimeanalyser-freq-data-expected.txt: Added. There's
still a FAIL test there though.
- platform/glib/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt:
- 5:36 AM Changeset in webkit [267470] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, prospective GTK build fix after r267449.
- svg/SVGPathBlender.cpp: Include <functional>, needed for std::invoke().
- 5:17 AM Changeset in webkit [267469] by
-
- 3 edits in trunk/Source/WebCore
Wheel event phases of FrameView are not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=216870
Reviewed by Simon Fraser.
In AsyncScrollingCoordinator::handleWheelEventPhase, the scrollAnimator of a FrameView should be from FrameView itself, not ScrollableArea.
It doesn't call nodeDidHandleEvent to handle wheel event phases when !asyncFrameOrOverflowScrollingEnabled. Should call it after handleWheelEvent.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::handleWheelEventPhase): When nodeID is FrameView, we should use the scrollAnimator of FrameView instead.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEvent): If wheelEvent is handled, we should call nodeDidHandleEvent to handle the phases.
- 5:03 AM Changeset in webkit [267468] by
-
- 6 edits2 adds in trunk/Source/WebCore
[LFC][Integration] Add canUseFor functions
https://bugs.webkit.org/show_bug.cgi?id=216869
Reviewed by Zalan Bujtas.
Copy the SLL canUseFor code.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/integration/LayoutIntegrationCoverage.cpp: Added.
(WebCore::LayoutIntegration::canUseForCharacter):
(WebCore::LayoutIntegration::canUseForText):
(WebCore::LayoutIntegration::canUseForFontAndText):
(WebCore::LayoutIntegration::canUseForStyle):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
(WebCore::LayoutIntegration::canUseForLineLayout):
(WebCore::LayoutIntegration::canUseForLineLayoutAfterStyleChange):
- layout/integration/LayoutIntegrationCoverage.h: Added.
Also switch to OptionSet.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::isEnabled):
(WebCore::LayoutIntegration::LineLayout::canUseFor):
(WebCore::LayoutIntegration::LineLayout::canUseForAfterStyleChange):
- layout/integration/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::canUseFor): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
- 3:27 AM Changeset in webkit [267467] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Garden more failures in webaudio and webrtc tests.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 2:17 AM Changeset in webkit [267466] by
-
- 1 edit1 delete in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Remove specific baseline for webaudio/BiquadFilter/tail-time-lowpass.html
The baseline became redudant after r267444.
- platform/glib/webaudio/BiquadFilter/tail-time-lowpass-expected.txt: Removed.
- 12:57 AM Changeset in webkit [267465] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Remove redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled from Line::Run::hasTrailingLetterSpacing
https://bugs.webkit.org/show_bug.cgi?id=216867
Reviewed by Simon Fraser.
This codepath is only triggered when Line::TrimmableTrailingContent has a partially trimmable run.
However we don't add such runs unless m_shouldIgnoreTrailingLetterSpacing is false (which is already based on the RuntimeEnabledFeatures flag).
- layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
(WebCore::Layout::Line::Run::trailingLetterSpacing const):
Sep 22, 2020:
- 9:47 PM Changeset in webkit [267464] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Change
InspectorAnimationAgent->startTrackingto not error on repeated calls
https://bugs.webkit.org/show_bug.cgi?id=216385
Patch by Patrick Angle <Patrick Angle> on 2020-09-22
Reviewed by Devin Rousso.
InpsectorAnimationAgent now mirrors the behavior of other timeline agents by no longer returning an error on a
repeated invocation ofstartTracking.
- inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::startTracking):
- 9:39 PM Changeset in webkit [267463] by
-
- 7 edits1 copy1 add in trunk/Source/WebCore
[LFC][Integration] Basic pagination support
https://bugs.webkit.org/show_bug.cgi?id=215451
<rdar://problem/67482721>
Reviewed by Zalan Bujtas.
Port the Simple Line Layout pagination code to LFC integration layer.
Pagination is the last remaining use of SLL so this patch turns it into dead code.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/displaytree/DisplayInlineContent.h:
(WebCore::Display::InlineContent::create):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::canUseFor):
This now the same as SLL test, covering all cases.
(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::adjustForPagination):
(WebCore::LayoutIntegration::LineLayout::ensureDisplayInlineContent):
This is fairly direct copy of the SLL code. It is not future proof or otherwise great but it serves the job for now.
- layout/integration/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::isPaginated const):
- layout/integration/LayoutIntegrationPagination.cpp: Added.
(WebCore::LayoutIntegration::computeLineTopAndBottomWithOverflow):
(WebCore::LayoutIntegration::computeLineBreakIndex):
(WebCore::LayoutIntegration::computeOffsetAfterLineBreak):
(WebCore::LayoutIntegration::setPageBreakForLine):
(WebCore::LayoutIntegration::updateMinimumPageHeight):
(WebCore::LayoutIntegration::makeAdjustedContent):
(WebCore::LayoutIntegration::adjustLinePositionsForPagination):
- layout/integration/LayoutIntegrationPagination.h: Copied from Source/WebCore/layout/displaytree/DisplayInlineContent.h.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutLFCLines):
(WebCore::RenderBlockFlow::ensureLineBoxes):
- 9:08 PM Changeset in webkit [267462] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Gardening some tests
Unreviewed test gardening.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 8:50 PM Changeset in webkit [267461] by
-
- 5 edits in trunk/Source/WebCore
[LFC][Integration] Move RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check out from LineBuilder::constraintsForLine
https://bugs.webkit.org/show_bug.cgi?id=216862
Reviewed by Simon Fraser.
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::setIsIntegratedRootBoxFirstChild):
- layout/LayoutState.h:
(WebCore::Layout::LayoutState::isIntegratedRootBoxFirstChild const):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::constraintsForLine):
- 8:48 PM Changeset in webkit [267460] by
-
- 2 edits in trunk/Source/WebCore
[LFC][Floats] Remove the redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled() check from FloatingState::append
https://bugs.webkit.org/show_bug.cgi?id=216866
Reviewed by Simon Fraser.
The no-layout-box-for-the-FloatItem codepath is reserved for the IFC integration. This is temporary anyway.
- layout/floats/FloatingState.cpp:
(WebCore::Layout::FloatingState::append):
- 8:41 PM Changeset in webkit [267459] by
-
- 2 edits in trunk/Source/WebKit
[GPU Process] fast/canvas/canvas-blend-image.html and fast/canvas/canvas-blend-solid.html fail on macOS
https://bugs.webkit.org/show_bug.cgi?id=216860
Reviewed by Said Abou-Hallawa.
These two tests disable accelerated drawing for canvas elements; when using the GPU process, this causes us to
useImageBufferShareableBitmapBackendas the back-end for the image buffer backing the canvas element.
On both macOS and iOS, the image buffer is backed by BGRA image data. However, we override
backendColorFormat()and returnColorFormat::BGRAonly forPLATFORM(IOS_FAMILY), causingputImageData
andgetImageDatato result in flipped red and blue channels on macOS, which subsequently causes these two
layout tests to fail.
Fix these tests by removing the
PLATFORM(IOS_FAMILY)guard.
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
- 8:38 PM Changeset in webkit [267458] by
-
- 6 edits in trunk
Unify debug and release target aliases
https://bugs.webkit.org/show_bug.cgi?id=216863
<rdar://problem/69407746>
Reviewed by Tim Horton.
All Makefiles have "debug", "d", "release", and "r" for build
targets. Others -- but not all -- also include "dev", "develop",
"development", "dep", "deploy", and "deployment". Because of this
inconsistency, trying to use those additional targets didn't work. It
looks like all Makefiles used to support all of those targets, but
some got dropped along the way. For instance, the top-level Makefile
and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
looks like WebKitLibraries/Makefile never had them. Given that those
additional targets don't work, it seems like no one uses them, so
let's remove them completely.
.:
- Makefile.shared:
Source/ThirdParty:
- Makefile:
Tools:
- Makefile:
- 8:36 PM Changeset in webkit [267457] by
-
- 2 edits in trunk/Source/WebCore
[GTK] REGRESSION(r267329): imported/blink/editing/undo/crash-redo-with-iframes.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=216778
Reviewed by Darin Adler.
Covered by existing tests.
- editing/markup.cpp:
(WebCore::serializePreservingVisualAppearanceInternal): Return early
also for "negative" ranges to avoid hitting an assertion inside
serializeNodes, as suggested by Darin.
- 7:38 PM Changeset in webkit [267456] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
REGRESSION: [ iOS wk2 ] http/wpt/cache-storage/quota-third-party.https.html is a flaky failure
rdar://69407691
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 7:37 PM Changeset in webkit [267455] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r267421.
https://bugs.webkit.org/show_bug.cgi?id=216864
Broke a test on macOS
Reverted changeset:
"[macOS] Start collecting telemetry from a set of XPC
services"
https://bugs.webkit.org/show_bug.cgi?id=216797
https://trac.webkit.org/changeset/267421
- 6:57 PM Changeset in webkit [267454] by
-
- 4 edits in trunk
[JSC] Enable Intl.DateTimeFormat dayPeriod
https://bugs.webkit.org/show_bug.cgi?id=216845
Reviewed by Mark Lam.
JSTests:
- stress/intl-datetimeformat.js:
Source/JavaScriptCore:
Since we already have consensus, let's enable it.
For now, we keep this flag since it is possible that something
happens before the change is integrated into the spec.
- runtime/OptionsList.h:
- 6:49 PM Changeset in webkit [267453] by
-
- 10 edits in trunk
Slightly improve AudioBufferSourceNode resampling
https://bugs.webkit.org/show_bug.cgi?id=216859
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching-expected.txt:
Source/WebCore:
Slightly improve AudioBufferSourceNode resampling. Use simple linear extrapolation
to resample the data when we reach the end of the buffer. Previously, the last
sample would just be repeated enough times.
This is a merge of the following Blink change by Raymond Toy:
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
LayoutTests:
- webaudio/AudioBufferSource/audiobuffersource-detune-modulation-expected.txt:
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation-expected.txt:
- webaudio/gain-expected.wav:
Rebaseline tests that have slightly different output.
- 5:44 PM Changeset in webkit [267452] by
-
- 1 copy in tags/Safari-610.2.6.0.1
Tag Safari-610.2.6.0.1.
- 5:43 PM Changeset in webkit [267451] by
-
- 1 copy in tags/Safari-610.2.6.1.4
Tag Safari-610.2.6.1.4.
- 5:32 PM Changeset in webkit [267450] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
REGRESSION: [ iOS wk2 ] fast/text/international/complex-character-based-fallback.html is a constant failure
rdar://69401173
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 5:20 PM Changeset in webkit [267449] by
-
- 21 edits2 copies54 moves in trunk/Source/WebCore
[WebIDL] Switch to new file name convention for partial interfaces
https://bugs.webkit.org/show_bug.cgi?id=216843
Reviewed by Tim Horton.
Updates all 'partial interface' IDLs to use the new naming convention adopted
in https://webkit.org/b/216729, where they are name as the construction of the
base interface '+' the supplementing spec. So, additions to Document from the
Web Animations spec becomes Document+WebAnimations.idl.
- accessibility/AccessibilityRenderObject.cpp:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSXMLDocumentCustom.cpp:
- html/HTMLFrameOwnerElement.h:
- loader/FrameLoader.cpp:
- page/FrameView.cpp:
- svg/DocumentSVG.cpp: Added.
- svg/DocumentSVG.h: Added.
- svg/SVGDocument.cpp:
- svg/SVGDocument.h:
- svg/SVGTRefElement.cpp:
- svg/graphics/SVGImage.cpp:
- style/StyleAdjuster.cpp:
- svg/Document+SVG.idl: Added.
- svg/SVGDocument.idl: Removed.
Fix weirdness around SVGDocument. Previously, additions to the Document
interface were in a class that was also a document subclass. Now the two
are split, so the additions are in DocumentSVG.h/cpp, matching convention,
and the subclass remains SVGDocument.h/cpp, also matching convention.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
Update for renames.
- Modules/async-clipboard/Navigator+Clipboard.idl: Added.
- Modules/async-clipboard/NavigatorClipboard.idl: Removed.
- Modules/beacon/Navigator+Beacon.idl: Added.
- Modules/beacon/NavigatorBeacon.idl: Removed.
- Modules/cache/DOMWindow+Caches.idl: Added.
- Modules/cache/DOMWindowCaches.idl: Removed.
- Modules/cache/WorkerGlobalScope+Caches.idl: Added.
- Modules/cache/WorkerGlobalScopeCaches.idl: Removed.
- Modules/credentialmanagement/Navigator+Credentials.idl: Added.
- Modules/credentialmanagement/NavigatorCredentials.idl: Removed.
- Modules/encryptedmedia/Navigator+EME.idl: Added.
- Modules/encryptedmedia/NavigatorEME.idl: Removed.
- Modules/entriesapi/HTMLInputElement+EntriesAPI.idl: Added.
- Modules/entriesapi/HTMLInputElementEntriesAPI.idl: Removed.
- Modules/fetch/WindowOrWorkerGlobalScope+Fetch.idl: Added.
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.idl: Removed.
- Modules/gamepad/Navigator+Gamepad.idl: Added.
- Modules/gamepad/NavigatorGamepad.idl: Removed.
- Modules/geolocation/Navigator+Geolocation.idl: Added.
- Modules/geolocation/NavigatorGeolocation.idl: Removed.
- Modules/indexeddb/DOMWindow+IndexedDatabase.idl: Added.
- Modules/indexeddb/DOMWindowIndexedDatabase.idl: Removed.
- Modules/indexeddb/WorkerGlobalScope+IndexedDatabase.idl: Added.
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl: Removed.
- Modules/mediacapabilities/Navigator+MediaCapabilities.idl: Added.
- Modules/mediacapabilities/NavigatorMediaCapabilities.idl: Removed.
- Modules/mediasession/HTMLMediaElement+MediaSession.idl: Added.
- Modules/mediasession/HTMLMediaElementMediaSession.idl: Removed.
- Modules/mediasource/AudioTrack+MediaSource.idl: Added.
- Modules/mediasource/AudioTrackMediaSource.idl: Removed.
- Modules/mediasource/DOMURL+MediaSource.idl: Added.
- Modules/mediasource/DOMURLMediaSource.idl: Removed.
- Modules/mediasource/TextTrack+MediaSource.idl: Added.
- Modules/mediasource/TextTrackMediaSource.idl: Removed.
- Modules/mediasource/VideoTrack+MediaSource.idl: Added.
- Modules/mediasource/VideoTrackMediaSource.idl: Removed.
- Modules/mediastream/Navigator+MediaDevices.idl: Added.
- Modules/mediastream/NavigatorMediaDevices.idl: Removed.
- Modules/pictureinpicture/Document+PictureInPicture.idl: Added.
- Modules/pictureinpicture/DocumentOrShadowRoot+PictureInPicture.idl: Added.
- Modules/pictureinpicture/DocumentOrShadowRootPictureInPicture.idl: Removed.
- Modules/pictureinpicture/DocumentPictureInPicture.idl: Removed.
- Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl: Added.
- Modules/pictureinpicture/HTMLVideoElementPictureInPicture.idl: Removed.
- Modules/quota/DOMWindow+Quota.idl: Added.
- Modules/quota/DOMWindowQuota.idl: Removed.
- Modules/quota/Navigator+StorageQuota.idl: Added.
- Modules/quota/NavigatorStorageQuota.idl: Removed.
- Modules/quota/WorkerNavigator+StorageQuota.idl: Added.
- Modules/quota/WorkerNavigatorStorageQuota.idl: Removed.
- Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl: Added.
- Modules/remoteplayback/HTMLMediaElementRemotePlayback.idl: Removed.
- Modules/speech/DOMWindow+SpeechSynthesis.idl: Added.
- Modules/speech/DOMWindowSpeechSynthesis.idl: Removed.
- Modules/webdatabase/DOMWindow+WebDatabase.idl: Added.
- Modules/webdatabase/DOMWindowWebDatabase.idl: Removed.
- Modules/webdriver/Navigator+WebDriver.idl: Added.
- Modules/webdriver/NavigatorWebDriver.idl: Removed.
- Modules/webgpu/Navigator+GPU.idl: Added.
- Modules/webgpu/NavigatorGPU.idl: Removed.
- Modules/webgpu/WorkerNavigator+GPU.idl: Added.
- Modules/webgpu/WorkerNavigatorGPU.idl: Removed.
- Modules/webxr/Navigator+WebXR.idl: Added.
- Modules/webxr/NavigatorWebXR.idl: Removed.
- animation/Document+WebAnimations.idl: Added.
- animation/DocumentAnimations.idl: Removed.
- animation/DocumentOrShadowRoot+WebAnimations.idl: Added.
- animation/DocumentOrShadowRootAnimations.idl: Removed.
- animation/GlobalEventHandlers+CSSAnimations.idl: Added.
- animation/GlobalEventHandlers+CSSTransitions.idl: Added.
- animation/GlobalEventHandlersCSSAnimations.idl: Removed.
- animation/GlobalEventHandlersCSSTransitions.idl: Removed.
- css/DOMCSSNamespace+CSSPainting.idl: Added.
- css/DOMCSSNamespace+CSSPropertiesandValues.idl: Added.
- css/DOMCSSPaintWorklet.idl: Removed.
- css/DOMCSSRegisterCustomProperty.idl: Removed.
- css/DocumentOrShadowRoot+CSSOM.idl: Added.
- css/DocumentOrShadowRootStyleSheets.idl: Removed.
- dom/Document+CSSOMView.idl: Added.
- dom/Document+Fullscreen.idl: Added.
- dom/Document+HTML.idl: Added.
- dom/Document+HTMLObsolete.idl: Added.
- dom/Document+PageVisibility.idl: Added.
- dom/Document+PointerLock.idl: Added.
- dom/Document+Selection.idl: Added.
- dom/Document+StorageAccess.idl: Added.
- dom/Document+Touch.idl: Added.
- dom/Document+UndoMananger.idl: Added.
- dom/DocumentFullscreen.idl: Removed.
- dom/DocumentHTML.idl: Removed.
- dom/DocumentHTMLObsolete.idl: Removed.
- dom/DocumentOrShadowRoot+PointerLock.idl: Added.
- dom/DocumentOrShadowRootPointerLock.idl: Removed.
- dom/DocumentPageVisibility.idl: Removed.
- dom/DocumentPointerLock.idl: Removed.
- dom/DocumentScrolling.idl: Removed.
- dom/DocumentSelection.idl: Removed.
- dom/DocumentStorageAccess.idl: Removed.
- dom/DocumentTouch.idl: Removed.
- dom/DocumentUndoMananger.idl: Removed.
- dom/Element+DOMParsing.idl: Added.
- dom/ElementDOMParsing.idl: Removed.
- dom/GlobalEventHandlers+PointerEvents.idl: Added.
- dom/GlobalEventHandlersPointerEvents.idl: Removed.
- page/Navigator+IsLoggedIn.idl: Added.
- page/NavigatorIsLoggedIn.idl: Removed.
Rename IDLs.
- 5:11 PM Changeset in webkit [267448] by
-
- 2 edits in trunk/Tools
Make TLSVersion API tests more robust.
https://bugs.webkit.org/show_bug.cgi?id=216704
Like I did in r267278, the TLSVersion.ShouldAllowDeprecatedTLS API test was also asserting with TCPServer,
so use HTTPServer which gracefully handles a variable number of connection attempts.
The NetworkSession tests that use NSUserDefaults need to be split into a separate test for bug 216041,
so may as well do that here, too.
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::makeWebViewWith):
(TestWebKitAPI::TEST):
- 5:04 PM Changeset in webkit [267447] by
-
- 2 edits in trunk/Tools
Limit number of emails to send for flaky and pre-existing JSC test failures
https://bugs.webkit.org/show_bug.cgi?id=216857
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py:
(AnalyzeJSCTestsResults.start):
- 4:43 PM Changeset in webkit [267446] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Used geometry for inline level boxes should be in the coordinate system of the formatting context root
https://bugs.webkit.org/show_bug.cgi?id=216854
Reviewed by Simon Fraser.
Convert inline level box geometry from relative to the line box to relative to the formatting context root.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- 4:15 PM Changeset in webkit [267445] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r267442. rdar://problem/66842535
[ macOS ] webgl/2.0.0/conformance/textures/misc/texture-upload-size.html is a flaky failure
rdar://66842535
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:54 PM Changeset in webkit [267444] by
-
- 5 edits in trunk
Fix BiquadFilterNode's lowpass & highpass filters
https://bugs.webkit.org/show_bug.cgi?id=216852
Reviewed by Eric Carlson.
Source/WebCore:
Fix BiquadFilterNode's lowpass & highpass filters. They incorrectly clamp the
resonance to make it positive.
Formulas for the filters are specified here:
No new tests, rebaselined existing tests.
- platform/audio/Biquad.cpp:
(WebCore::pow10):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
LayoutTests:
Rebaseline tests that are now passing.
- webaudio/BiquadFilter/tail-time-highpass-expected.txt:
- webaudio/BiquadFilter/tail-time-lowpass-expected.txt:
- 3:52 PM Changeset in webkit [267443] by
-
- 11 edits in trunk
Merge AudioBufferSourceNode loop fixes from Blink
https://bugs.webkit.org/show_bug.cgi?id=216849
Reviewed by Eric Carlson.
Source/WebCore:
Merge AudioBufferSourceNode loop fixes from Blink, the following one in particular:
This allows us to pass all the checks in:
webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::adjustGrainParameters):
Merge loop fixes from Blink.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::stopLater):
Stop throwing when m_endTime is already set. Our behavior did not match
Chrome and Firefox here. This was causing some existing tests to start
failing now that providing a grain duration when calling start() would
set m_endTime if loop() returns true.
LayoutTests:
- webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive-expected.txt:
Rebaseline test that is now passing.
- webaudio/Oscillator/oscillator-basic-expected.txt:
- webaudio/dom-exceptions-expected.txt:
Rebaseline tests because the exception message was improved.
- webaudio/audiobuffersource-exception-expected.txt:
- webaudio/audiobuffersource-exception.html:
Stop expecting an exception to be thrown when AudioBufferSourceNode.stop() gets called
more than once. I have verified that Chrome and Firefox do not throw in this case.
- 3:40 PM Changeset in webkit [267442] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] webgl/2.0.0/conformance/textures/misc/texture-upload-size.html is a flaky failure
rdar://66842535
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:26 PM Changeset in webkit [267441] by
-
- 2 edits in trunk
Refactor build rules in Makefiles and Makefile.shared
https://bugs.webkit.org/show_bug.cgi?id=216806
<rdar://problem/69332316>
Reviewed by David Kilzer.
Build fix: Previous change for this bug broke the ability to perform a
build with justmake, due to that code path invoking
set-webkit-configurationwith no parameters, which causes that
script to error-out.
- Makefile.shared:
- 3:23 PM Changeset in webkit [267440] by
-
- 4 edits in trunk
Coerce computed property before adding to |excludedList|
https://bugs.webkit.org/show_bug.cgi?id=216437
Patch by HyeockJin Kim <kherootz@gmail.com> on 2020-09-22
Reviewed by Yusuke Suzuki.
JSTests:
- stress/object-rest-deconstruct.js:
(get 3):
Source/JavaScriptCore:
- bytecompiler/NodesCodegen.cpp:
(JSC::ObjectPatternNode::bindValue const):
- 3:21 PM Changeset in webkit [267439] by
-
- 4 edits in trunk
REGRESSION(r266075): WebContent process crashes at TextManipulationController::getPath
https://bugs.webkit.org/show_bug.cgi?id=216846
Reviewed by Wenson Hsieh.
Source/WebCore:
TextIterator does not visit node that has no renderer, so if node has become hidden, TextManipulationController
will not find content node in paragraph range during replacement.
API Test: TextManipulation.CompleteTextManipulationParagraphBecomesHidden
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 3:10 PM Changeset in webkit [267438] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iPadOS wk2 ] fast/forms/ios/time-picker-value-change.html times out or fails
rdar://problem/63108701
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 2:45 PM Changeset in webkit [267437] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Atomic inline-level box with margin is mispositioned
https://bugs.webkit.org/show_bug.cgi?id=216842
Reviewed by Antti Koivisto.
The inline box that an atomic inline-level box generates has the height of the margin box. Therefore the inline box's logical top position
is the position of the top edge of the margin box.
When converting the inline box geometry back to the layout box, we need to offset the top position (border box top edge)
with the value of the used margin before.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- 1:47 PM Changeset in webkit [267436] by
-
- 55 edits in branches/safari-610.2.6.0-branch/Source/WebCore
Apply patch. rdar://problem/69375258
- 1:13 PM Changeset in webkit [267435] by
-
- 4 edits in trunk
AudioParam.setValueCurveAtTime() should have an implicit call to setValueAtTime() at the end
https://bugs.webkit.org/show_bug.cgi?id=216839
Reviewed by Eric Carlson.
Source/WebCore:
AudioParam.setValueCurveAtTime() should have an implicit call to setValueAtTime() at the end,
as specified here:
"""
An implicit call to setValueAtTime() is made at time 𝑇0+𝑇𝐷 with value 𝑉[𝑁−1] so that
following automations will start from the end of the setValueCurveAtTime() event.
"""
No new tests, rebaselined existing test.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::setValueCurveAtTime):
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioParam/audioparam-setValueCurve-end-expected.txt:
- 1:07 PM Changeset in webkit [267434] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Add support for multiline inline box geometry.
https://bugs.webkit.org/show_bug.cgi?id=216835
Reviewed by Antti Koivisto.
This patch computes the geometry for inline boxes spanning multiple lines (e.g. <span>first line<br>next line</span).
However this is not the getBoundingClientRect() type of geometry where we provide geometry for each fragments. This is more like the
element.offset* geometry where we compute the enclosing rectangle for all the fragments.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent): Decouple the run construction and inline box geometry update logic,
where we loop through the runs and create "line runs" when needed and then we loop through the inline boxes on the current line and
update the box geometries.
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::lineBoxes const):
(WebCore::Layout::InlineFormattingState::addLineBox):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):
(WebCore::Layout::InlineFormattingState::shrinkToFit):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::containsInlineLevelBox const):
- 12:31 PM Changeset in webkit [267433] by
-
- 8 edits in branches/safari-610.2.6.0-branch/Source
Versioning.
WebKit-7610.2.6.0.1
- 12:25 PM Changeset in webkit [267432] by
-
- 26 edits in trunk
AudioParams with automations must process timelines
https://bugs.webkit.org/show_bug.cgi?id=216837
Reviewed by Darin Adler.
Source/WebCore:
Currently, if an AudioNode has no inputs connected, any automations
(or connections) to an AudioParam of the node is not processed. Thus,
time never advances on the AudioParam, and any upstream graph
connected to the AudioParam never gets pulled for data.
AudioParam should get processed so that time progresses. Normal
processing of the node causes AudioParams to be processed, so we were
only missing the case where the node has silent inputs (silent or no
inputs). Then we just need to update the AudioParams, without having
to do the full processing associated with the node.
See https://webaudio.github.io/web-audio-api/#rendering-loop, step 8.1.1
in particular that says any inputs connected to an AudioParam are
processed. There are no conditions on when this happens.
This is a merge of the following Blink change by Raymond Toy:
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::processOnlyAudioParams):
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioListener.h:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::processIfNecessary):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::processOnlyAudioParams):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::processOnlyAudioParams):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::processOnlyAudioParams):
- Modules/webaudio/DelayDSPKernel.h:
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::processOnlyAudioParams):
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::processOnlyAudioParams):
- Modules/webaudio/GainNode.h:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::processOnlyAudioParams):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/StereoPannerNode.cpp:
(WebCore::StereoPannerNode::processOnlyAudioParams):
- Modules/webaudio/StereoPannerNode.h:
- platform/audio/AudioDSPKernel.h:
(WebCore::AudioDSPKernel::processOnlyAudioParams):
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::processOnlyAudioParams):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::processOnlyAudioParams):
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioParam/audioparam-processing-expected.txt:
- 12:18 PM Changeset in webkit [267431] by
-
- 2 edits in trunk/Source/WebKit
[GTK] REGRESSION(r267398): several hidpi tests are failing
https://bugs.webkit.org/show_bug.cgi?id=216830
Reviewed by Adrian Perez de Castro.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCustomDeviceScaleFactor): Remove check for removed define.
- 12:08 PM Changeset in webkit [267430] by
-
- 8 edits in branches/safari-610-branch/Source
Versioning.
WebKit-7610.2.8
- 12:03 PM Changeset in webkit [267429] by
-
- 2 edits in branches/safari-610.2.6.1-branch/Source/WebCore
Cherry-pick r267106. rdar://problem/69375000
CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>
Reviewed by Eric Carlson.
Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:03 PM Changeset in webkit [267428] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, partial revert of r267383.
Restore GStreamer-specific implementation of FFTFrame::multiply() since it appears
r267383 introduced test failures on GTK port.
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::multiply): Deleted.
- platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::multiply):
- platform/audio/gstreamer/FFTFrameGStreamer.cpp:
(WebCore::FFTFrame::multiply):
- platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::multiply):
- 12:01 PM Changeset in webkit [267427] by
-
- 9 edits1 delete in trunk/Source/WebKit
[Media in GPU Process] Add missing IPC message receivers
https://bugs.webkit.org/show_bug.cgi?id=216829
Reviewed by Jer Noble.
Add missing IPC message receivers and clean up some macro usages.
Also remove the empty RemoteMediaPlayerManager.messages.in.
No new tests, no functional change.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
(WebKit::GPUConnectionToWebProcess::dispatchSyncMessage):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h:
(WebKit::RemoteMediaSessionHelperProxy::didReceiveMessageFromWebProcess):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
- WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in: Removed.
- 11:57 AM Changeset in webkit [267426] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.4
- 11:43 AM Changeset in webkit [267425] by
-
- 2 edits in branches/safari-610.2.5.1-branch/Source/WebCore
Revert "Cherry-pick r267106. rdar://problem/69375000"
- 11:37 AM Changeset in webkit [267424] by
-
- 8 edits in trunk
Refactor build rules in Makefiles and Makefile.shared
https://bugs.webkit.org/show_bug.cgi?id=216806
<rdar://problem/69332316>
Reviewed by David Kilzer.
Factor out the common aspects of the build rules in Makefile.shared
and the various Makefiles. This allows us to more easily see what's
different between the various build targets, and to apply uniform
changes across all of the targets.
- Makefile:
.:
- Makefile.shared:
- Source/Makefile:
- 11:30 AM Changeset in webkit [267423] by
-
- 17 edits in branches/safari-610.2.5.1-branch
Revert "Cherry-pick r266121. rdar://problem/68949249"
- 11:25 AM Changeset in webkit [267422] by
-
- 1 copy in branches/safari-610.2.6.0-branch
New branch.
- 11:03 AM Changeset in webkit [267421] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Start collecting telemetry from a set of XPC services
<https://bugs.webkit.org/show_bug.cgi?id=216797>
Reviewed by Brent Fulgham.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:00 AM Changeset in webkit [267420] by
-
- 2 edits in branches/safari-610.2.5.1-branch/Source/WebCore
Cherry-pick r267106. rdar://problem/69375000
CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>
Reviewed by Eric Carlson.
Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:57 AM Changeset in webkit [267419] by
-
- 2 edits3 adds in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Mark several audio related tests as failure after r267383.
Also emit baselines for 2 tests passing.
- platform/glib/TestExpectations:
- platform/glib/webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Added.
- platform/glib/webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Added.
- 10:33 AM Changeset in webkit [267418] by
-
- 4 edits in trunk/Source/WebCore
[LFC] FormattingState should never be copied.
https://bugs.webkit.org/show_bug.cgi?id=216833
Reviewed by Antti Koivisto.
Even when running a throw-away layout, we should not copy the state object but instead generate a new one for the subtree.
These objects should never be copied in general.
- layout/FormattingState.h:
- layout/LayoutState.h:
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):
- 9:53 AM Changeset in webkit [267417] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
REGRESSION(r267354): Only import resource module on Darwin
https://bugs.webkit.org/show_bug.cgi?id=216823
Patch by Sam Sneddon <Sam Sneddon> on 2020-09-22
Reviewed by Darin Adler.
- web-platform-tests/tools/serve/serve.py:
Move the resource import to the local point behind the Darwin platform
test. This code is only run once per process initiation, hence it makes
no difference to have the import locally.
- 9:45 AM Changeset in webkit [267416] by
-
- 2 edits in trunk
Correct instructions for building iOS in ReadMe
https://bugs.webkit.org/show_bug.cgi?id=216825
<rdar://problem/69372654>
Reviewed by David Kilzer.
- ReadMe.md: Update iOS build instructions to apply to all embedded platforms.
- 9:40 AM Changeset in webkit [267415] by
-
- 2 edits in branches/safari-610-branch/Tools
Cherry-pick r267278. rdar://problem/69374947
Make TLSVersion.NetworkSession API test more robust
https://bugs.webkit.org/show_bug.cgi?id=216704
<rdar://problem/68643674>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.
r265573 made preconnect attempts to legacy TLS servers fail.
This caused the TLSVersion.NetworkSession to assert because the first connection attempt would fail
(and the second would succeed if it was supposed to succeed with the conditions in the test).
The test calls waitForDidFailProvisionalNavigation in cases where it is supposed to fail and
waitForDidFinishNavigation in cases where it supposed to succeed.
Like I did in r266100 with another test, use HTTPServer which allows a variable number of connection attempts.
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:32 AM Changeset in webkit [267414] by
-
- 14 edits2 adds in trunk
Implement a default prompt for getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=216821
Reviewed by Eric Carlson.
Source/WebCore:
Manually tested by running Minibrowser.
- en.lproj/Localizable.strings:
Source/WebKit:
Move preferences used by WebRTC develop menu to internals.
This allows having them in MiniBrowser.
Enable video capture in UIProcess by default for non Safari applications.
Add support for a getUserMedia prompt, very similar to iOS current prompt.
Use the prompt in case the application does not implement any of the two delegates.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCaptureVideoInUIProcessEnabled):
- Shared/WebPreferencesDefaultValues.h:
- Shared/WebPreferencesExperimental.yaml:
- Shared/WebPreferencesInternal.yaml:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::requestUserMediaAuthorizationForFrame):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
- UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.h: Added.
- UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.mm: Added.
(WebKit::visibleDomain):
(WebKit::alertMessageText):
(WebKit::presentUserMediaCaptureAccessAlert):
- WebKit.xcodeproj/project.pbxproj:
Tools:
Remove getUserMedia delegate implementations to use WebKit built-in prompt.
Add camera and microphone entitlements to allow using real cameras and microphones.
Keep using mock devices as the default.
- MiniBrowser/MiniBrowser.entitlements:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController _webView:requestMediaCaptureAuthorization:decisionHandler:]): Deleted.
(-[WK2BrowserWindowController _webView:includeSensitiveMediaDeviceDetails:]): Deleted.
- 9:29 AM Changeset in webkit [267413] by
-
- 4 edits in trunk
webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=216824
Reviewed by Darin Adler.
Source/WebCore:
If the time constant pass to AudioParam.setTargetAtTime() is 0, then insert a SetValue event in
the timeline instead of a SetTarget one, causing us to instantly jump to the target value. This
matches the Blink behavior.
No new tests, unskipped existing test.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::setTargetAtTime):
LayoutTests:
Unskip test that is passing and no longer crashing.
- 9:22 AM Changeset in webkit [267412] by
-
- 2 edits in trunk/Source/WebKit
Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
Reviewed by Tim Horton.
To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.
This is a speculative fix due to the aforementioned reproducibility issue.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
checks. So put an explicit check here followed by an explicit release assert.
- 9:14 AM Changeset in webkit [267411] by
-
- 44 edits2 copies in trunk
[Cocoa] _WKInspectorDelegate should handle showing external resources
https://bugs.webkit.org/show_bug.cgi?id=216334
Reviewed by Devin Rousso.
Source/WebCore:
Adapt to the rename of InspectorFrontendHost.{openInNewTab => openURLExternally}.
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openURLExternally):
(WebCore::InspectorFrontendClientLocal::openInNewTab): Deleted.
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::openURLExternally):
(WebCore::InspectorFrontendHost::openInNewTab): Deleted.
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
Adapt to the rename of InspectorFrontendHost.{openInNewTab => openURLExternally}.
- UserInterface/Base/Main.js:
- UserInterface/Debug/UncaughtExceptionReporter.js:
(sheetElement.innerHTML.div):
- UserInterface/Protocol/InspectorFrontendAPI.js:
- UserInterface/Views/ResourceTreeElement.js:
(WI.ResourceTreeElement.prototype.ondblclick):
Source/WebKit:
WebKit clients need a way to control the loading and presentation of
external resources that are linked in Web Inspector's user interface.
Rename InspectorFrontendHost.openInNewTab to openURLExternally. Change
the implementation to forward the request to UIProcess rather than the
inspected WebProcess.
When a navigation is triggered in WKInspectorViewController's WKWebView,
allow the delegate to open the requested resource. Otherwise, redirect
the navigation to the inspected WebView or open it using NSWorkspace
(for the remote case).
New API test: WKInspectorDelegate.OpenURLExternally.
- UIProcess/API/Cocoa/_WKInspectorPrivateForTesting.h: Added.
- UIProcess/API/Cocoa/_WKInspectorTesting.mm: Added.
(snippetToOpenURLExternally):
(-[_WKInspector _openURLExternallyForTesting:useFrontendAPI:]):
Add some helpers for writing API tests.
- UIProcess/API/APIInspectorClient.h:
(API::InspectorClient::openURLExternally):
- UIProcess/API/Cocoa/_WKInspectorDelegate.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
- UIProcess/Inspector/Cocoa/InspectorDelegate.h:
- UIProcess/Inspector/Cocoa/InspectorDelegate.mm:
(WebKit::InspectorDelegate::setDelegate):
(WebKit::InspectorDelegate::InspectorClient::openURLExternally):
Add new delegate method to _WKInspectorDelegate.
- UIProcess/Inspector/RemoteWebInspectorProxy.messages.in:
- UIProcess/Inspector/RemoteWebInspectorProxy.h:
- UIProcess/Inspector/RemoteWebInspectorProxy.cpp:
(WebKit::RemoteWebInspectorProxy::openURLExternally):
(WebKit::RemoteWebInspectorProxy::platformOpenURLExternally):
(WebKit::RemoteWebInspectorProxy::openInNewTab): Deleted.
(WebKit::RemoteWebInspectorProxy::platformOpenInNewTab): Deleted.
- UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:
(WebKit::RemoteWebInspectorProxy::platformURLExternally):
(WebKit::RemoteWebInspectorProxy::platformOpenInNewTab): Deleted.
- UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm:
(WebKit::RemoteWebInspectorProxy::platformOpenURLExternally):
(WebKit::RemoteWebInspectorProxy::platformOpenInNewTab): Deleted.
- UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp:
(WebKit::RemoteWebInspectorProxy::platformOpenURLExternally):
(WebKit::RemoteWebInspectorProxy::platformOpenInNewTab): Deleted.
Rename openInNewTab to openURLExternally. In some cases the client
may not choose to present a new tab, so the name is no longer accurate.
- UIProcess/Inspector/WebInspectorProxy.messages.in:
- UIProcess/Inspector/WebInspectorProxy.h:
- UIProcess/Inspector/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorWindow const):
(WebKit::WebInspectorProxy::openURLExternally):
(WebKit::WebInspectorProxy::evaluateInFrontendForTesting):
- UIProcess/Inspector/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter inspectorViewController:openURLExternally:]):
Add some helpers for writing API tests. Add an IPC message
for evaluating a JavaScript expression in the frontend page.
Also, add a message receiver for the OpenURLExternally message
which passes the request to the API layer.
- UIProcess/Inspector/mac/WKInspectorViewController.h:
- UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
Call the delegate method if a navigation inside the inspector WKWebView is an external URL.
Specifically the request is to load something other than the Web Inspector's main HTML page.
- WebProcess/Inspector/WebInspector.cpp:
(WebKit::WebInspector::openInNewTab): Deleted.
- WebProcess/Inspector/WebInspector.h:
- WebProcess/Inspector/WebInspector.messages.in:
No need to handle this message anymore in the inspected WebProcess.
- WebProcess/Inspector/RemoteWebInspectorUI.h:
- WebProcess/Inspector/RemoteWebInspectorUI.cpp:
(WebKit::RemoteWebInspectorUI::openURLExternally):
(WebKit::RemoteWebInspectorUI::openInNewTab): Deleted.
- WebProcess/Inspector/WebInspectorUI.messages.in:
- WebProcess/Inspector/WebInspectorUI.h:
- WebProcess/Inspector/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::updateConnection):
(WebKit::WebInspectorUI::closeWindow):
(WebKit::WebInspectorUI::openURLExternally):
(WebKit::WebInspectorUI::evaluateInFrontendForTesting):
(WebKit::WebInspectorUI::openInNewTab): Deleted.
When we need to open the URL externally, send an IPC message to UIProcess.
The old implementation triggered the navigation from the inspected WebProcess.
That approach is no longer desirable. Remove the unneeded IPC connection.
- WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h:
- WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.cpp:
(WebKit::WebInspectorFrontendAPIDispatcher::evaluateExpressionForTesting):
Fulfill the request to evaluate the expression in the frontend page.
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
Some files were added.
Tools:
Test the delegate using WebKit API and using InspectorFrontendHost API.
- TestWebKitAPI/Tests/WebKitCocoa/WKInspectorDelegate.mm:
(-[InspectorDelegate inspector:openURLExternally:]): Added.
(TEST):
- 9:00 AM Changeset in webkit [267410] by
-
- 4 edits in trunk/Tools
Unreviewed, reverting r267380.
Broke multiple test suites on Liberty
Reverted changeset:
"[webkitpy] Use webkitcorepy's auto installer for pytest
packages"
https://bugs.webkit.org/show_bug.cgi?id=215895
https://trac.webkit.org/changeset/267380
- 8:30 AM Changeset in webkit [267409] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iOS wk2 ] compositing/clipping/border-radius-on-webgl.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=215324
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 8:28 AM Changeset in webkit [267408] by
-
- 7 edits4 adds in trunk/Source/WebCore
[WebIDL] Split up Performance.idl into component partials
https://bugs.webkit.org/show_bug.cgi?id=216729
Reviewed by Darin Adler.
Split additions to the Peformance interface from the Navagation Timing,
Resource Timing, User Timing and Performance Timeline specs into their
own IDL files. Trying something new with the naming (using Performance
'+' name of the spec supplying the addition) for these partials to test
the waters.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- page/Performance+NavigationTiming.idl: Added.
- page/Performance+PerformanceTimeline.idl: Added.
- page/Performance+ResourceTiming.idl: Added.
- page/Performance+UserTiming.idl: Added.
- page/Performance.idl:
- 8:15 AM Changeset in webkit [267407] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
https://bugs.webkit.org/show_bug.cgi?id=215667
Unreviewed test gardening.
- platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
- 7:59 AM Changeset in webkit [267406] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark compositing/video/video-update-rendering.html as flaky crash
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 7:54 AM Changeset in webkit [267405] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Start collecting telemetry from message filtering
<https://bugs.webkit.org/show_bug.cgi?id=216803>
Reviewed by Darin Adler.
Start collecting telemetry for message filtering in the WebContent sandbox on macOS.
- WebProcess/com.apple.WebProcess.sb.in:
- 6:34 AM Changeset in webkit [267404] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] TextUtil::split needs logical left
https://bugs.webkit.org/show_bug.cgi?id=216798
Reviewed by Antti Koivisto.
Measuring text content requires logical left offset (e.g. tab size depends on the logical position).
Let's pass in the current logical left position to TextUtil::split.
- layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::ContinuousContent::runs const):
(WebCore::Layout::ContinuousContent::isEmpty const):
(WebCore::Layout::ContinuousContent::logicalWidth const):
(WebCore::Layout::ContinuousContent::logicalLeft const):
(WebCore::Layout::ContinuousContent::nonCollapsibleLogicalWidth const):
(WebCore::Layout::LineBreaker::isContentWrappingAllowed const):
(WebCore::Layout::LineBreaker::shouldKeepEndOfLineWhitespace const):
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::LineBreaker::wrapTextContent const):
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
(WebCore::Layout::ContinuousContent::ContinuousContent):
(WebCore::Layout::ContinuousContent::hasTextContentOnly const):
(WebCore::Layout::ContinuousContent::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::ContinuousContent::firstTextRunIndex const):
(WebCore::Layout::ContinuousContent::lastContentRunIndex const):
(WebCore::Layout::ContinuousContent::hasNonContentRunsOnly const):
(WebCore::Layout::ContinuousContent::size const): Deleted.
(WebCore::Layout::ContinuousContent::width const): Deleted.
(WebCore::Layout::ContinuousContent::nonCollapsibleWidth const): Deleted.
- layout/inlineformatting/InlineLineBreaker.h:
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleFloatsAndInlineContent):
- 5:10 AM Changeset in webkit [267403] by
-
- 6 edits in trunk
Move Media in GPU Process flag from internal to experimental
https://bugs.webkit.org/show_bug.cgi?id=216473
<rdar://problem/69318786>
Reviewed by Eric Carlson.
Source/WebKit:
No change of behavior.
- Shared/WebPreferencesExperimental.yaml:
- Shared/WebPreferencesInternal.yaml:
Tools:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Disable Media in GPU Process flag and WebRTC codec experimental features by default.
This can be overriden by WebKitTestRunner options.
- 1:46 AM Changeset in webkit [267402] by
-
- 39 edits11 adds in trunk
Update User Timing interfaces to User Timing Level 3
https://bugs.webkit.org/show_bug.cgi?id=216787
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Import missing case-sensitivity test case from upstream and update the results
of User Timing tests now that we support Level 3.
- web-platform-tests/user-timing/case-sensitivity.any-expected.txt: Added.
- web-platform-tests/user-timing/case-sensitivity.any.html: Added.
- web-platform-tests/user-timing/case-sensitivity.any.js: Added.
- web-platform-tests/user-timing/case-sensitivity.any.worker-expected.txt: Added.
- web-platform-tests/user-timing/case-sensitivity.any.worker.html: Added.
- web-platform-tests/user-timing/idlharness.any-expected.txt:
- web-platform-tests/user-timing/idlharness.any.worker-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any-expected.txt:
- web-platform-tests/user-timing/mark-entry-constructor.any.worker-expected.txt:
- web-platform-tests/user-timing/mark-errors.any-expected.txt:
- web-platform-tests/user-timing/mark-errors.any.worker-expected.txt:
- web-platform-tests/user-timing/mark-l3.any-expected.txt:
- web-platform-tests/user-timing/mark-l3.any.worker-expected.txt:
- web-platform-tests/user-timing/mark-measure-return-objects.any-expected.txt:
- web-platform-tests/user-timing/mark-measure-return-objects.any.worker-expected.txt:
- web-platform-tests/user-timing/measure-l3.any-expected.txt:
- web-platform-tests/user-timing/measure-l3.any.worker-expected.txt:
- web-platform-tests/user-timing/measure-with-dict.any-expected.txt:
- web-platform-tests/user-timing/measure-with-dict.any.worker-expected.txt:
- web-platform-tests/user-timing/measure_exception-expected.txt:
- web-platform-tests/user-timing/performance-measure-invalid.worker-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any-expected.txt:
- web-platform-tests/user-timing/structured-serialize-detail.any.worker-expected.txt:
Source/WebCore:
Adds support for User Timing Level 3 which adds more flexibility in how PerformanceMarks
and PerformanceMeasures are created via synthetic start/end times and associate 'details'
values serialized with events themselves.
Updates results to existing WPT and standalone tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- page/Performance.cpp:
(WebCore::Performance::mark):
(WebCore::Performance::clearMarks):
(WebCore::Performance::measure):
(WebCore::Performance::clearMeasures):
- page/Performance.h:
- page/Performance.idl:
Update for new signatures for mark and measure, and rename of UserTiming to PerformanceUserTiming.
- page/PerformanceMark.cpp: Added.
(WebCore::peformanceNow):
(WebCore::PerformanceMark::create):
(WebCore::PerformanceMark::PerformanceMark):
(WebCore::PerformanceMark::detail):
- page/PerformanceMark.h:
- page/PerformanceMark.idl:
Add support for PerformanceMark's constructor
detailgetter. While the spec says to
serialize and the deserialize in the constructor, we only serialize, and delay deserialization
until the first access, which is a non-observable difference. We also utilize [CachedAttribute]
to only ever deserialize once per wrapper world (and also greatly simplify the GC shenanigans).
- page/PerformanceMarkOptions.h: Added.
- page/PerformanceMarkOptions.idl: Added.
Import and bind PerformanceMarkOptions dictionary to a new struct.
- page/PerformanceMeasure.cpp: Added.
(WebCore::PerformanceMeasure::create):
(WebCore::PerformanceMeasure::PerformanceMeasure):
(WebCore::PerformanceMeasure::detail):
- page/PerformanceMeasure.h:
- page/PerformanceMeasure.idl:
Like with PerformanceMark, but there is no constructor here, so we only need to handle adding
support for the detail getter.
- page/PerformanceMeasureOptions.h: Added.
- page/PerformanceMeasureOptions.idl: Added.
Import and bind PerformanceMeasureOptions dictionary to a new struct.
- page/PerformanceUserTiming.cpp:
(WebCore::restrictedMarkNamesToNavigationTimingFunctionMap):
(WebCore::restrictedMarkFunction):
(WebCore::isRestrictedMarkNameNonMainThread):
(WebCore::PerformanceUserTiming::isRestrictedMarkName):
Split up existing map to enable accessing it safely from a worker using conservative
callOnMainThreadAndWait approach, though since the map is immutable after initialization,
we can probably optimize this to allow concurrent querying in the future.
(WebCore::addPerformanceEntry):
Add helper, mirroring clearPerformanceEntries, to add entries.
(WebCore::PerformanceUserTiming::mark):
Matching the spec language, utilize the new PerformanceMark constructor to create
the mark.
(WebCore::PerformanceUserTiming::convertMarkToTimestamp const):
(WebCore::isNonEmptyDictionary):
(WebCore::PerformanceUserTiming::measure):
Implement measure support by dispatching various combinations of arguments to
overloads manually by inspecting the Variant.
- page/PerformanceUserTiming.h:
Renames class from UserTiming to PerformanceUserTiming to match file names.
LayoutTests:
Update error text due to some changes in which exceptions are thrown due to
new support for User Timing Level 3.
- performance-api/performance-measure-name-expected.txt:
- performance-api/performance-now-api-expected.txt:
- performance-api/user-timing-apis-expected.txt:
- 1:03 AM Changeset in webkit [267401] by
-
- 5 edits in trunk
toRTCIceProtocol should handle ssltcp candidates
https://bugs.webkit.org/show_bug.cgi?id=216762
Reviewed by Darin Adler.
Source/WebCore:
Covered by mock WebRTC backend pushing ssltcp candidates.
- Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::toRTCIceProtocol):
- testing/MockLibWebRTCPeerConnection.cpp:
LayoutTests:
- fast/mediastream/RTCPeerConnection-icecandidate-event-expected.txt:
