Timeline



Sep 28, 2020:

11:25 PM Changeset in webkit [267728] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitpy] Use webkitcorepy's auto installer for pycodestyle (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=215427
<rdar://problem/66931291>

Unreviewed follow-up fix.

Conflict resolution at some point broke the original change.

  • Scripts/webkitpy/style/checkers/python.py: Import directly from pycodestyle.
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pycodestyle): Deleted.

10:51 PM Changeset in webkit [267727] by ysuzuki@apple.com
  • 131 edits in trunk/Source

Use JSC_DECLARE_JIT_OPERATION / JSC_DECLARE_CUSTOM_GETTER / JSC_DECLARE_CUSTOM_SETTER
https://bugs.webkit.org/show_bug.cgi?id=217071

Reviewed by Keith Miller.

Source/JavaScriptCore:

This patch changes how to define JIT_OPERATIONs including custom getters and setters.
We introduce JSC_DECLARE_JIT_OPERATION etc. to declare and define them. This is useful
to perform some additional things (like, JIT-caging registering) for each function.

Source/WebCore:

No behavior change.

Source/WTF:

Add the following macros.

  1. JSC_DECLARE_JIT_OPERATION
  2. JSC_DEFINE_JIT_OPERATION
  3. JSC_DECLARE_CUSTOM_GETTER
  4. JSC_DEFINE_CUSTOM_GETTER
  5. JSC_DECLARE_CUSTOM_SETTER
  6. JSC_DEFINE_CUSTOM_SETTER
  • wtf/PlatformCallingConventions.h:
9:54 PM Changeset in webkit [267726] by mark.lam@apple.com
  • 21 edits in trunk

Add Bounds Check Elimination validation for debugging.
https://bugs.webkit.org/show_bug.cgi?id=217055
rdar://69122891

Reviewed by Keith Miller.

Source/JavaScriptCore:

Added a JSC_validateBoundsCheckElimination option (with alias
JSC_validateBCE) that adds an AssertInBounds whenever a CheckInBounds
node is elided.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):

  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::validateAIState):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileAssertNotEmpty):
(JSC::FTL::DFG::LowerDFGToB3::compileAssertInBounds):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationReportBoundsCheckEliminationErrorAndCrash):

  • ftl/FTLOperations.h:
  • runtime/OptionsList.h:

Tools:

Added --validateBCE=true to ftl-no-cjit-validate-sampling-profiler
and ftl-eager-no-cjit.

  • Scripts/run-jsc-stress-tests:
9:52 PM Changeset in webkit [267725] by Peng Liu
  • 15 edits
    1 copy in trunk/Source

[Media in GPU Process] Use VideoLayerManager to manage layers of MediaPlayerPrivateRemote
https://bugs.webkit.org/show_bug.cgi?id=216995

Reviewed by Eric Carlson.

Source/WebCore:

No new tests since no functional changes.

  • Headers.cmake:

Export TextTrackRepresentation and VideoLayerManager.

  • WebCore.xcodeproj/project.pbxproj:

Add VideoLayerManager.h.
Export TextTrackRepresentation, WebVideoContainerLayer and VideoLayerManager.

  • platform/graphics/TextTrackRepresentation.cpp:
  • platform/graphics/TextTrackRepresentation.h:

Minor clean-up.

  • platform/graphics/VideoLayerManager.h: Added.

Add this interface so that we can use VideoLayerManager in the C++ code.

  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::videoInlineLayer const):
(WebCore::VideoLayerManagerObjC::videoFullscreenLayer const):
(WebCore::VideoLayerManagerObjC::videoFullscreenFrame const):
(WebCore::VideoLayerManagerObjC::updateVideoFullscreenInlineImage):
Fix the issue when RELEASE_LOG_DISABLED is defined and add WEBCORE_EXPORT
to some functions.

Source/WebKit:

This patch removes the remote hosting layer in the GPU process for video fullscreen and
picture-in-picture. We don't need to keep a layer in the GPU process for video fullscreen
and picture-in-picture because no rendering will be done for that layer. We don't need
EnterFullscreen, ExitFullscreen and SetVideoFullscreenFrameFenced IPC messages after removing
the layer because the RemoteMediaPlayerPrivateRemote in the web process can deal with
the video presentation mode change.

  • GPUProcess/media/RemoteMediaPlayerProxy.h:
  • GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
  • GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:

(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::enterFullscreen): Deleted.
(WebKit::RemoteMediaPlayerProxy::exitFullscreen): Deleted.
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenFrameFenced): Deleted.
Remove unused IPC messages after removing the remote hosting layer for video fullscreen
and picture-in-picture.

  • GPUProcess/media/gstreamer/RemoteMediaPlayerProxyGStreamer.cpp:

(WebKit::RemoteMediaPlayerProxy::prepareForPlayback):
(WebKit::RemoteMediaPlayerProxy::enterFullscreen): Deleted.
(WebKit::RemoteMediaPlayerProxy::exitFullscreen): Deleted.
Ditto.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::prepareForPlayback):
Remove the code related to the remote hosting layer for video fullscreen and picture-in-picture.
(WebKit::MediaPlayerPrivateRemote::platformLayer const):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer):
Use VideoLayerManager to manage the layer.
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame): Ditto.
(WebKit::MediaPlayerPrivateRemote::requiresTextTrackRepresentation const): Ditto.
(WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation): Ditto.
(WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds): Ditto.
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrameFenced): Deleted.

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

Need to move the Logger up in the data members so that other members can use it
in the constructor, e.g., VideoLayerManager.

  • WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::createVideoFullscreenLayer):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame): Deleted.
(WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation): Deleted.
(WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds): Deleted.
Simplify the implementation by managing layers with VideoLayerManager.

9:10 PM Changeset in webkit [267724] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

webkitfullscreenchange does not fire for shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=216607

Patch by Tetsuharu Ohzeki <Tetsuharu Ohzeki> on 2020-09-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

This bug was caused by the webkitfullscreenchange event being fired
but without _composed_ flag set.

This patch fixed the bug by making it composed as defined as
the step 3-2 of https://fullscreen.spec.whatwg.org/#run-the-fullscreen-steps.
so that event listeners outside shadow tree could observe it.

Test: fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html

  • dom/FullscreenManager.cpp:

(WebCore::FullscreenManager::dispatchFullscreenChangeOrErrorEvent):

LayoutTests:

Added a regression test for making an element inside a shadow tree full screen,
and listening to webkitfullscreenchange outside the shadow tree.

  • fast/shadow-dom/fullscreen-in-shadow-event-should-propagate-expected.txt: Added.
  • fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html: Added.
  • platform/ios-wk2/TestExpectations:

Other testcases related to fullscreen API in fast/shadow-dom/ are also
disabled for ios-wk2.

8:49 PM Changeset in webkit [267723] by Devin Rousso
  • 19 edits in trunk

Web Inspector: add checkbox to local override popover to allow it to skip the network
https://bugs.webkit.org/show_bug.cgi?id=217031

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Models/LocalResourceOverride.js:

(WI.LocalResourceOverride):
(WI.LocalResourceOverride.create):
(WI.LocalResourceOverride.fromJSON):
(WI.LocalResourceOverride.prototype.toJSON):
(WI.LocalResourceOverride.prototype.get type): Added.
(WI.LocalResourceOverride.prototype.saveIdentityToCookie):
Introduce a WI.LocalResourceOverride.Type that is used when handling request/response
interceptions to determined the Network command for continuing.

  • UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.supportsOverridingRequestsWithResponses): Added.
(WI.NetworkManager.supportsOverridingResponses): Added.
(WI.NetworkManager.prototype.initializeTarget):
(WI.NetworkManager.prototype.addLocalResourceOverride):
(WI.NetworkManager.prototype.removeLocalResourceOverride):
(WI.NetworkManager.prototype.requestIntercepted):
(WI.NetworkManager.prototype.responseIntercepted):
(WI.NetworkManager.prototype._commandArgumentsForInterception):
(WI.NetworkManager.prototype._addInterception): Added.
(WI.NetworkManager.prototype._removeInterception): Added.
(WI.NetworkManager.prototype._handleResourceOverrideDisabledChanged):
(WI.NetworkManager.supportsLocalResourceOverrides): Deleted.
Add logic for Network.interceptRequestWithResponse in Network.requestIntercepted.
Drive-by: refactor common logic into member functions.

  • UserInterface/Views/LocalResourceOverridePopover.js:

(WI.LocalResourceOverridePopover.prototype.get serializedData):
(WI.LocalResourceOverridePopover.prototype.show):

  • UserInterface/Views/LocalResourceOverridePopover.css:

(.popover .local-resource-override-popover-content .add-header + .reference-page-link-container): Added.
(.popover .local-resource-override-popover-content .options td): Added.
(.popover .local-resource-override-popover-content .reference-page-link-container): Deleted.
Add an "Options" row containing a "[ ] Skip Network" checkbox for controlling whether
Network.interceptWithResponse or Network.interceptRequestWithResponse is used.

  • UserInterface/Models/Resource.js:

(WI.Resource.prototype.async createLocalResourceOverride):

  • UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

  • UserInterface/Views/FontResourceContentView.js:

(WI.FontResourceContentView.prototype.contentAvailable):

  • UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView.prototype.contentAvailable):

  • UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):

  • UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._addLocalResourceOverrides):

  • UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView):
(WI.ResourceContentView.prototype.closed):

  • UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype._willDismissLocalOverridePopover):
(WI.SourcesNavigationSidebarPanel.prototype._addLocalOverride):
(WI.SourcesNavigationSidebarPanel.prototype._removeResourceOverride):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateResourceContextMenu):
Rename supportsLocalResourceOverrides to supportsOverridingResponses for clarity.

  • Localizations/en.lproj/localizedStrings.js:

LayoutTests:

  • http/tests/inspector/network/local-resource-override-basic.html:
  • http/tests/inspector/network/local-resource-override-main-resource.html:
  • http/tests/inspector/network/local-resource-override-script-tag.html:
  • http/tests/inspector/network/resource-response-inspector-override.html:

Add expected parameter for WI.LocalResourceOverride.create calls.

5:38 PM Changeset in webkit [267722] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266899. rdar://problem/69586659

Integrator's note: as some of the symbols present on trunk are not available on branch, special modifications had to be made to this cherry-pick to build.

Address a post-commit review comment after r266887
https://bugs.webkit.org/show_bug.cgi?id=216257

Reviewed by Darin Adler.

Remove a check that currently makes us conditionally set IsComputedStyleInvalidFlag if there is a computed
style in rare data. There should be no change in behavior; this just makes the code a bit simpler.

  • dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::storeDisplayContentsStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [267721] by Alan Coon
  • 4 edits
    2 adds in branches/safari-610-branch

Cherry-pick r266887. rdar://problem/69586659

Integrator's note: as some of the symbols present on trunk are not available on branch, special modifications had to be made to this cherry-pick to build.

REGRESSION (r257839): clickpay.com - password placeholder text cannot be replaced
https://bugs.webkit.org/show_bug.cgi?id=216257
<rdar://problem/68150686>

Reviewed by Antti Koivisto.

Source/WebCore:

On clickpay.com, the field in the login form that contains the text "Password" is actually a plain text input,
referred to by the site's script as the "null text input". The page adds a focus event listener to this null
text input, and inside of this focus event listener, it reveals a hidden password field by removing an inline
display: none; style rule on the real password input element, programmatically focuses it, and then hides the
null text input by setting it to display: none; via inline style.

However, after the changes in r257839, we no longer attempt to do a style update upon programmatic focus in the
case where the programmatically focused element does not have a renderer yet (this applies to the password field
in this scenario, because it previously had display: none;). When we determine whether the newly displayed
password field is focusable using Element::isVisibleWithoutResolvingFullStyle, we then attempt to use either
the existing computed RenderStyle on the element, or perform a partial computed style resolution using the
ResolveComputedStyleMode::RenderedOnly flag.

But in the case where ElementRareData's computed style exists, it is not guaranteed to be up to date if the
inline style changed since the computed style was last set. In the context of this bug, it's actually Safari's
AutoFill logic (embedded in the injected bundle) that ends up asking for the computed style of the password
input, forcing it to be created and set (though, as demonstrated in the layout test, simply grabbing the
computed style is sufficient to replicate the bug outside of Safari).

The end result is that we'll use this stale computed style, which still believes that the password input is not
displayed, and we end up not focusing the element due to believing that the password input is hidden. To fix
this, we would need to either check whether the element has an invalid style (i.e. needsStyleRecalc()) before
attempting to use the existing computed style, or clear out the ElementRareData computed style anytime the
element's style is invalidated. However, both of these approaches will cause us to perform partial style
resolution much more aggressively, leading to a 2-3% regression in Speedometer.

To address the bug without hampering our performance wins from r257839, we add a new node flag so that we can
remember when computed styles are no longer valid due to style invalidation, and consult this flag in
Element::isVisibleWithoutResolvingFullStyle to avoid using the existing computed style.

Test: fast/forms/programmatic-focus-after-display.html

  • dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::resolveComputedStyle): (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
  • dom/Node.h: (WebCore::Node::setHasValidStyle):

LayoutTests:

Add a new layout test to verify that the bug does not occur. See WebCore/ChangeLog for more details.

  • fast/forms/programmatic-focus-after-display-expected.txt: Added.
  • fast/forms/programmatic-focus-after-display.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:58 PM Changeset in webkit [267720] by Karl Rackler
  • 2 edits in branches/safari-610-branch/LayoutTests

REGRESSION: [ iOS wk2 ] ( safari-610-branch ) fast/events/touch/ios/pointer-events-with-modifiers.html is a constant crash
rdar://69722963

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
4:48 PM Changeset in webkit [267719] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Document.p.contains returns true for nodes in shadow tree
https://bugs.webkit.org/show_bug.cgi?id=189164

Reviewed by Darin Adler.

Added a regression after r267220 had fixed this bug.

  • fast/shadow-dom/document-contains-returns-false-for-node-inside-shadow-tree-expected.txt: Added.
  • fast/shadow-dom/document-contains-returns-false-for-node-inside-shadow-tree.html: Added.
4:18 PM Changeset in webkit [267718] by Alan Coon
  • 1 copy in tags/Safari-611.1.1.1

Tag Safari-611.1.1.1.

3:09 PM Changeset in webkit [267717] by Alan Coon
  • 8 edits in branches/safari-611.1.1-branch/Source

Versioning.

WebKit-7611.1.1.1

3:05 PM Changeset in webkit [267716] by Alan Coon
  • 55 edits in branches/safari-610-branch/Source/WebCore

Apply patch. rdar://problem/69594082

2:11 PM Changeset in webkit [267715] by Keith Rollin
  • 2 edits in trunk

Print message saying what project is being built
https://bugs.webkit.org/show_bug.cgi?id=216865
<rdar://problem/69408135>

Reviewed by Andy Estes.

XCBuild removes the progress messages saying which project/target is
being built. We can't show the target, but update the Makefiles to at
least show which project is being built.

  • Makefile.shared:
1:26 PM Changeset in webkit [267714] by weinig@apple.com
  • 6 edits
    5 moves
    2 adds in trunk/Source

[Preferences] Move GeneratePreferences.rb and yaml configuration files to WTF to be shared
https://bugs.webkit.org/show_bug.cgi?id=217056

Reviewed by Darin Adler.

Move GeneratePreferences.rb and WebPreferences*.yaml files from WebKitLegacy to WTF, and install them into the existing
$SDKROOT/usr/local/install/wtf/Scripts for use by down stack projects.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

Also adds new script, generate-preferences.sh, to make editing / reviewing the invocation a bit easier as you don't
have to use the tiny editor in the Run Scripts phase pane.

Adds new build variable, WTF_BUILD_SCRIPTS_DIR, to easily specify the new location of the moved files.

  • Configurations/WebKitLegacy.xcconfig:
  • Scripts/GeneratePreferences.rb: Removed.
  • Scripts/generate-preferences.sh: Added.
  • WebView/WebPreferences.yaml: Removed.
  • WebView/WebPreferencesDebug.yaml: Removed.
  • WebView/WebPreferencesExperimental.yaml: Removed.
  • WebView/WebPreferencesInternal.yaml: Removed.

Source/WTF:

  • Scripts/GeneratePreferences.rb: Copied from Source/WebKitLegacy/mac/Scripts/GeneratePreferences.rb.
  • Scripts/Preferences: Added.
  • Scripts/Preferences/WebPreferences.yaml: Copied from Source/WebKitLegacy/mac/WebView/WebPreferences.yaml.
  • Scripts/Preferences/WebPreferencesDebug.yaml: Copied from Source/WebKitLegacy/mac/WebView/WebPreferencesDebug.yaml.
  • Scripts/Preferences/WebPreferencesExperimental.yaml: Copied from Source/WebKitLegacy/mac/WebView/WebPreferencesExperimental.yaml.
  • Scripts/Preferences/WebPreferencesInternal.yaml: Copied from Source/WebKitLegacy/mac/WebView/WebPreferencesInternal.yaml.
  • WTF.xcodeproj/project.pbxproj:
1:21 PM Changeset in webkit [267713] by eric.carlson@apple.com
  • 10 edits in trunk/Source

[GPUP] Out-of-band TextTracks
https://bugs.webkit.org/show_bug.cgi?id=217062
<rdar://problem/68739969>

Reviewed by Jer Noble.
Source/WebCore:

Add support for passing out-of-band TextTracks to a media engine running in the GPU process.

No new tests, this can only be tested with a specific hardware setup.

  • html/HTMLMediaElement.cpp:

(WebCore::toPlatform):

  • platform/graphics/PlatformTextTrack.h: Put instance variables into a struct so

state can be encoded and decoded.
(WebCore::PlatformTextTrackData::PlatformTextTrackData):
(WebCore::PlatformTextTrackData::decode):
(WebCore::PlatformTextTrackData::encode const):
(WebCore::PlatformTextTrackClient::privateTrack):
(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::createOutOfBand):
(WebCore::PlatformTextTrack::type const):
(WebCore::PlatformTextTrack::kind const):
(WebCore::PlatformTextTrack::mode const):
(WebCore::PlatformTextTrack::label const):
(WebCore::PlatformTextTrack::language const):
(WebCore::PlatformTextTrack::url const):
(WebCore::PlatformTextTrack::uniqueId const):
(WebCore::PlatformTextTrack::isDefault const):
(WebCore::PlatformTextTrack::client const):
(WebCore::PlatformTextTrack::data const):
(WebCore::PlatformTextTrack::PlatformTextTrack):
(WebCore::PlatformTextTrack::captionMenuOffItem): Deleted.
(WebCore::PlatformTextTrack::captionMenuAutomaticItem): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::mediaDescriptionForKind):
(WebCore::MediaPlayerPrivateAVFoundationObjC::synchronizeTextTrackState):

Source/WebKit:

  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::outOfBandTrackSources):

  • GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:

(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):

  • Scripts/webkit/messages.py:
  • WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

  • WebProcess/GPU/media/RemoteMediaPlayerManager.h:
1:06 PM Changeset in webkit [267712] by Matt Lewis
  • 3 edits in trunk/Tools

Fix Build triggers for iOS, watchOS, and tvOS
https://bugs.webkit.org/show_bug.cgi?id=217057

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

1:04 PM Changeset in webkit [267711] by Fujii Hironori
  • 7 edits
    2 adds in trunk

[TextureMapper] Enable a depth buffer for preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=90078

Reviewed by Don Olmstead.

Source/WebCore:

Test: transforms/3d/general/preserve-3d.html

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::getEGLConfig):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::beginPreserves3D): Added a new virtual method.
(WebCore::TextureMapper::endPreserves3D): Ditto.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix): Swapped nearValue and farValue
so that the depth buffer works as expected.
(WebCore::TextureMapperGL::beginPreserves3D): Added.
(WebCore::TextureMapperGL::endPreserves3D): Ditto.

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren): Call
beginPreserves3D() and endPreserves3D() if m_state.preserves3D.

LayoutTests:

  • transforms/3d/general/preserve-3d-expected.html: Added.
  • transforms/3d/general/preserve-3d.html: Added.
12:54 PM Changeset in webkit [267710] by Jonathan Bedard
  • 3 edits in trunk/Tools

[webkitpy] Use webkitcorepy's auto installer for pycodestyle
https://bugs.webkit.org/show_bug.cgi?id=215427
<rdar://problem/66931291>

Reviewed by Darin Adler.

  • Scripts/webkitpy/init.py: Add pycodestyle.
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Remove pycodestyle.

11:23 AM Changeset in webkit [267709] by Devin Rousso
  • 23 edits
    1 add in trunk

[iOS] unable to airplay directly loaded fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=216858
<rdar://problem/68746321>

Reviewed by Eric Carlson.

Source/WebCore:

It's possible that MediaPlayerPrivate::wirelessVideoPlaybackDisabled is queried before a
"real" MediaPlayerPrivate (i.e. not NullMediaPlayerPrivate) is initialized through one
of the registered MediaPlayerFactory "engine"s. It's further possible that the value
returned by MediaPlayerPrivate::wirelessVideoPlaybackDisabled will change as the new
"real" MediaPlayerPrivate may have different logic. In this case, the MediaPlayer
doesn't update its client (and therefore nothing "up" the tree, including the client's
clients) with the new MediaPlayerPrivate::wirelessVideoPlaybackDisabled value, meaning
that the old value will still be used.

Add piping such that when the MediaPlayerFactory "engine" changes, the MediaPlayer
notifies its client (which is further piped "up" the tree to the client's clients) which
eventually causes MediaPlayerPrivate::wirelessVideoPlaybackDisabled to be re-evaluated.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaEngineWasUpdated):

  • page/Page.h:
  • page/Page.cpp:

(WebCore::Page::playbackControlsMediaEngineChanged): Added.

  • page/ChromeClient.h:

(WebCore::ChromeClient::playbackControlsMediaEngineChanged): Added.

  • platform/cocoa/PlaybackSessionModelMediaElement.h:
  • platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::mediaEngineChanged): Added.

Source/WebKit:

It's possible that MediaPlayerPrivate::wirelessVideoPlaybackDisabled is queried before a
"real" MediaPlayerPrivate (i.e. not NullMediaPlayerPrivate) is initialized through one
of the registered MediaPlayerFactory "engine"s. It's further possible that the value
returned by MediaPlayerPrivate::wirelessVideoPlaybackDisabled will change as the new
"real" MediaPlayerPrivate may have different logic. In this case, the MediaPlayer
doesn't update its client (and therefore nothing "up" the tree, including the client's
clients) with the new MediaPlayerPrivate::wirelessVideoPlaybackDisabled value, meaning
that the old value will still be used.

Add piping such that when the MediaPlayerFactory "engine" changes, the MediaPlayer
notifies its client (which is further piped "up" the tree to the client's clients) which
eventually causes MediaPlayerPrivate::wirelessVideoPlaybackDisabled to be re-evaluated.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::playbackControlsMediaEngineChanged): Added.

  • WebProcess/cocoa/PlaybackSessionManager.h:
  • WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::mediaEngineChanged): Added.

  • UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
  • UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _wirelessVideoPlaybackDisabled]): Added.

  • UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::wirelessVideoPlaybackDisabled): Added.
Create additional functions for piping data to tests.

Source/WebKitLegacy/mac:

It's possible that MediaPlayerPrivate::wirelessVideoPlaybackDisabled is queried before a
"real" MediaPlayerPrivate (i.e. not NullMediaPlayerPrivate) is initialized through one
of the registered MediaPlayerFactory "engine"s. It's further possible that the value
returned by MediaPlayerPrivate::wirelessVideoPlaybackDisabled will change as the new
"real" MediaPlayerPrivate may have different logic. In this case, the MediaPlayer
doesn't update its client (and therefore nothing "up" the tree, including the client's
clients) with the new MediaPlayerPrivate::wirelessVideoPlaybackDisabled value, meaning
that the old value will still be used.

Add piping such that when the MediaPlayerFactory "engine" changes, the MediaPlayer
notifies its client (which is further piped "up" the tree to the client's clients) which
eventually causes MediaPlayerPrivate::wirelessVideoPlaybackDisabled to be re-evaluated.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::playbackControlsMediaEngineChanged): Added.

  • WebView/WebViewInternal.h:
  • WebView/WebView.mm:

(-[WebView _playbackControlsMediaEngineChanged]): Added.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/MediaDocument.mm: Added.

(MediaDocument.WirelessPlaybackEnabled):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11:23 AM Changeset in webkit [267708] by Alan Coon
  • 8 edits in branches/safari-611.1.2-branch/Source

Versioning.

WebKit-7611.1.2

11:16 AM Changeset in webkit [267707] by Alan Coon
  • 1 copy in branches/safari-611.1.2-branch

New branch.

11:14 AM Changeset in webkit [267706] by Darin Adler
  • 2 edits in trunk/Source/WebCore

REGRESSION (r267329): Crash due to null-dereference of frame pointer in DOMSelection::rangeCount
https://bugs.webkit.org/show_bug.cgi?id=217053

Reviewed by Sam Weinig.

Later as a follow-up it would be nice to add a test case, but not obvious how to
make a simple one quickly.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::rangeCount const): Fixed the null check.

10:46 AM Changeset in webkit [267705] by aakash_jain@apple.com
  • 6 edits in trunk/Tools

Notify igalia team about pre-existing test failures and build failures for WPE and GTK queues
https://bugs.webkit.org/show_bug.cgi?id=217052

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/send_email.py:

(send_email_to_bot_watchers): Moved the logic here to determine whether to email igalia folks.

  • BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Passed builder_name parameter.
(AnalyzeJSCTestsResults.send_email_for_flaky_failure):
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
(ReRunWebKitTests.send_email_for_flaky_failure):
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure):
(AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure):
(AnalyzeAPITestsResults.send_email_for_flaky_failure):
(AnalyzeAPITestsResults.send_email_for_pre_existing_failure):

  • BuildSlaveSupport/ews-build/steps_unittest.py:

(TestAnalyzeJSCTestsResults.configureStep): Drive-by fix to improve unit-test.

  • BuildSlaveSupport/ews-build/emails.json: Added IGALIA_GTK_WPE_EMAILS. Renamed BOT_WATCHERS_EMAILS to APPLE_BOT_WATCHERS_EMAILS.
  • BuildSlaveSupport/ews-build/email_unittest.py: Updated unit-test.
10:07 AM Changeset in webkit [267704] by Matt Lewis
  • 3 edits in trunk/Tools

Unreviewed dashboard fix.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

10:05 AM Changeset in webkit [267703] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed, test gardening.

9:07 AM Changeset in webkit [267702] by Chris Dumez
  • 4 edits in trunk/LayoutTests

Unreviewed, mark webaudio/the-audio-api/the-analysernode-interface/test-analyser-output.html as flaky instead of skipping it entirely.

This test is no longer timing out.

LayoutTests/imported/w3c:

  • web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt:

LayoutTests:

8:37 AM Changeset in webkit [267701] by Aditya Keerthi
  • 29 edits
    4 adds in trunk

[macOS] Update the appearance of editable date/time controls to match the system
https://bugs.webkit.org/show_bug.cgi?id=216616
<rdar://problem/69004603>

Reviewed by Devin Rousso.

Source/WebCore:

The default appearance of editable components within the date/time
control should closely match NSDatePicker.

  1. Focused components should have rounded corners

This is achieved by adding the border-radius property to the
datetime-edit fields.

  1. Use a raised colon separator for time inputs

The colon should be raised as it is surrounded two numbers. However,
since the colon is rendered in its own <div>, it remains lowered. To
raise the colon, the "ss03" font-feature-setting is enabled. Note that
this can cause issues with fonts that use "ss03" for a different purpose.
However, since we do not have support for the @font-feature-values rule
in CSS, there is currently no way to workaround this problem. Instead,
the issue should be fixed once we gain CSS support.

  1. Components should have a fixed width, and the width of the control should match the content

Since the control is not guaranteed to use a monospace font, the current
design results in editable components being resized each time the value
changes. To fix this issue, the display type was changed to inline-block
and the min-width of a component is computed at runtime. See below for
more details.

  • css/html.css:

Added UA stylesheet code that was removed from RenderTheme.

(input::-webkit-datetime-edit):
(input::-webkit-datetime-edit-year-field,):

Display inline-block allows us to set a fixed width for individual
components. The text is center-aligned so that changes are not
jarring. Finally, the font property is now "inherit !important",
as it does not make sense for the font used in a component to
differ from the control's font.

(input::-webkit-datetime-edit-year-field:focus,): Add rounded corners on focus.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::DateTimeFieldElement):

  • html/shadow/DateTimeFieldElements.cpp: Call setHasCustomStyleResolveCallbacks() to compute min-width.

(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement): Drive-by fix - milliseconds component has 3 digits.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::resolveCustomStyle):

The min-width of a numeric field should be the largest possible width
depending on the font, the largest digit character in the font and the
length of the field. Ten possible values are tested (0-9).

  • html/shadow/DateTimeNumericFieldElement.h:
  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::resolveCustomStyle):

The min-width of a symbolic field should be the largest symbol given
a font. Two (meridiem) to twelve (month) values may be tested.

  • html/shadow/DateTimeSymbolicFieldElement.h:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: Moved code to html.css.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: Moved code to html.css.
  • style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): Moved code to html.css.

  • style/UserAgentStyle.h:

LayoutTests:

Updated stylesheets so that font properties are not set on inner elements
of the control and rebaselined existing tests.

  • fast/forms/date/date-editable-components/date-editable-components-focus-and-blur-events.html:
  • fast/forms/date/date-editable-components/date-editable-components-mouse-events.html:
  • fast/forms/date/date-pseudo-elements.html:
  • fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-focus-and-blur-events.html:
  • fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-mouse-events.html:
  • fast/forms/time/time-editable-components/time-editable-components-focus-and-blur-events.html:
  • fast/forms/time/time-editable-components/time-editable-components-mouse-events.html:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/baseline-alignment-and-overflow.tentative-expected.txt:

The newly failing tests for <input type=week> are a false negative.
Previously, the style for this input type was empty, causing some
tests to incorrectly pass. The new failures are consistent with the
other date/time inputs, see the rest of the expectations for specifics.

  • platform/mac-catalina/fast/forms/date/date-input-rendering-basic-expected.txt:
  • platform/mac-catalina/fast/forms/time/time-input-rendering-basic-expected.txt: Added.
  • platform/mac-mojave/fast/forms/date/date-input-rendering-basic-expected.txt:
  • platform/mac-mojave/fast/forms/time/time-input-rendering-basic-expected.txt: Added.
  • platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
  • platform/mac-wk2/fast/forms/date/date-pseudo-elements-expected.txt:
  • platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:
8:00 AM Changeset in webkit [267700] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][Floats] Add support for clear on float box
https://bugs.webkit.org/show_bug.cgi?id=217045

Reviewed by Antti Koivisto.

Source/WebCore:

When the float box also has to clear other floats, we need to adjust the initial
vertical position from where we start searching for available space.
(This patch also fixes a previous find&replace renaming and addresses a post-landing comment.)

Test: fast/layoutformattingcontext/float-with-clear-simple.html

  • layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::absoluteCoordinates const):
(WebCore::Layout::FloatingContext::absoluteBoxGeometryCoordinates const): Deleted.

  • layout/floats/FloatingContext.h:

LayoutTests:

  • fast/layoutformattingcontext/float-with-clear-simple-expected.html: Added.
  • fast/layoutformattingcontext/float-with-clear-simple.html: Added.
7:55 AM Changeset in webkit [267699] by Aditya Keerthi
  • 8 edits in trunk/Source/WebCore

Crash under DateTimeEditElement::blurFromField
https://bugs.webkit.org/show_bug.cgi?id=216930
<rdar://problem/69308322>

Reviewed by Ryosuke Niwa.

DateTimeEditElement::blurFromField incorrectly invoked
HTMLElement::dispatchBlurEvent, as it was not the element being blurred.
Accessing member variables after this call is unsafe, as there is
nothing protecting the DateTimeEditElement.

To fix, the problematic methods were removed entirely, and replaced
with a new approach to responding to blur events within a DateTimeEditElement.

The blur event's relatedTarget is now compared to the fields within the
DateTimeEditElement, in order to determine when to close the calendar.
This approach is safe, since the relatedTarget is protected by
Document::setFocusedElement.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::elementDidBlur): Remove unnecessary call.

If the input has editable fields, closing the calendar is handled by the
new codepath. Running this code unconditionally will result in a flash of the
calendar when clicking on a part of the input type that doesn't contain
an editable field.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::didBlurFromField):

Check if the event's relatedTarget is another field within the same
DateTimeEditElement. If yes, the calendar should remain open.

  • html/shadow/DateTimeEditElement.h:
  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):

Call handleBlurEvent() if a blur event occurs. This was previously done by
the now-removed dispatchBlurEvent override.

(WebCore::DateTimeFieldElement::handleBlurEvent):

  • html/shadow/DateTimeFieldElement.h:
  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::handleBlurEvent):

  • html/shadow/DateTimeNumericFieldElement.h:
7:34 AM Changeset in webkit [267698] by youenn@apple.com
  • 3 edits in trunk/Source/WebKit

Make sure our calls to AVCaptureDevice requestAccessForMediaType do processing on the main thread
https://bugs.webkit.org/show_bug.cgi?id=216974

Reviewed by Darin Adler.

The completion handler to [AVCaptureDeviceClass requestAccessForMediaType:] may sometimes be called in a background thread on iOS.
Make sure to hop to the main thread if that is the case.
Also make sure to ref/weakref lambda captured variables.

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::requestAccessForMediaType):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):

6:42 AM Changeset in webkit [267697] by Antti Koivisto
  • 12 edits
    4 moves in trunk/Source/WebCore

[LFC][Integration] Move run iterator to LayoutIntegration namespace
https://bugs.webkit.org/show_bug.cgi?id=217046

Reviewed by Zalan Bujtas.

Also use name 'Modern' for LFC and 'Legacy' for the old inline tree path.

Also rename box->run for more consistent terminology.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Position.cpp:

(WebCore::Position::upstream const):
(WebCore::Position::downstream const):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance):
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextRun):
(WebCore::TextIterator::handleTextNodeFirstLetter):
(WebCore::TextIterator::handleTextBox): Deleted.

  • editing/TextIterator.h:
  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::textRunsFor const):
(WebCore::LayoutIntegration::LineLayout::elementRunFor const):
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::textBoxesFor const): Deleted.
(WebCore::LayoutIntegration::LineLayout::elementBoxFor const): Deleted.

  • layout/integration/LayoutIntegrationLineLayout.h:
  • layout/integration/LayoutIntegrationRunIterator.cpp: Renamed from Source/WebCore/rendering/line/LineLayoutTraversal.cpp.

(WebCore::LayoutIntegration::TextRunIterator::TextRunIterator):
(WebCore::LayoutIntegration::TextRunIterator::traverseNextInVisualOrder):
(WebCore::LayoutIntegration::TextRunIterator::traverseNextInTextOrder):
(WebCore::LayoutIntegration::TextRunIterator::operator== const):
(WebCore::LayoutIntegration::TextRunIterator::atEnd const):
(WebCore::LayoutIntegration::firstTextRunFor):
(WebCore::LayoutIntegration::firstTextRunInTextOrderFor):
(WebCore::LayoutIntegration::textRunsFor):
(WebCore::LayoutIntegration::ElementRunIterator::ElementRunIterator):
(WebCore::LayoutIntegration::ElementRunIterator::atEnd const):
(WebCore::LayoutIntegration::elementRunFor):

  • layout/integration/LayoutIntegrationRunIterator.h: Renamed from Source/WebCore/rendering/line/LineLayoutTraversal.h.

(WebCore::LayoutIntegration::TextRunIterator::TextRunIterator):
(WebCore::LayoutIntegration::TextRunIterator::operator++):
(WebCore::LayoutIntegration::TextRunIterator::operator!= const):
(WebCore::LayoutIntegration::TextRunIterator::operator* const):
(WebCore::LayoutIntegration::TextRunIterator::operator-> const):
(WebCore::LayoutIntegration::ElementRunIterator::ElementRunIterator):
(WebCore::LayoutIntegration::ElementRunIterator::operator* const):
(WebCore::LayoutIntegration::ElementRunIterator::operator-> const):
(WebCore::LayoutIntegration::TextRunRange::TextRunRange):
(WebCore::LayoutIntegration::TextRunRange::begin const):
(WebCore::LayoutIntegration::Run::Run):
(WebCore::LayoutIntegration::Run::rect const):
(WebCore::LayoutIntegration::Run::baseline const):
(WebCore::LayoutIntegration::Run::isLeftToRightDirection const):
(WebCore::LayoutIntegration::Run::isHorizontal const):
(WebCore::LayoutIntegration::Run::dirOverride const):
(WebCore::LayoutIntegration::Run::isLineBreak const):
(WebCore::LayoutIntegration::Run::useLineBreakBoxRenderTreeDumpQuirk const):
(WebCore::LayoutIntegration::TextRun::hasHyphen const):
(WebCore::LayoutIntegration::TextRun::TextRun):
(WebCore::LayoutIntegration::TextRun::text const):
(WebCore::LayoutIntegration::TextRun::localStartOffset const):
(WebCore::LayoutIntegration::TextRun::localEndOffset const):
(WebCore::LayoutIntegration::TextRun::length const):
(WebCore::LayoutIntegration::TextRun::isLastOnLine const):
(WebCore::LayoutIntegration::TextRun::isLast const):

  • layout/integration/LayoutIntegrationRunIteratorLegacyPath.h: Renamed from Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h.

(WebCore::LayoutIntegration::LegacyPath::LegacyPath):
(WebCore::LayoutIntegration::LegacyPath::operator== const):
(WebCore::LayoutIntegration::LegacyPath::nextInlineTextBoxInTextOrder const):

  • layout/integration/LayoutIntegrationRunIteratorModernPath.h: Renamed from Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h.

(WebCore::LayoutIntegration::ModernPath::ModernPath):
(WebCore::LayoutIntegration::ModernPath::operator== const):
(WebCore::LayoutIntegration::ModernPath::rect const):

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::linesBoundingBox const):
(WebCore::RenderLineBreak::boundingBoxForRenderTreeDump const):
(WebCore::RenderLineBreak::absoluteRects const):
(WebCore::RenderLineBreak::absoluteQuads const):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects const):
(WebCore::collectAbsoluteQuadsForNonComplexPaths):
(WebCore::RenderText::firstRunLocation const):
(WebCore::RenderText::linesBoundingBox const):
(WebCore::RenderText::caretMinOffset const):
(WebCore::RenderText::caretMaxOffset const):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil const):
(WebCore::containsOffset):
(WebCore::RenderText::hasRenderedText const):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeTextRun):
(WebCore::write):
(WebCore::writeTextBox): Deleted.

5:25 AM Changeset in webkit [267696] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix test failures inadventently introduced in r267644
https://bugs.webkit.org/show_bug.cgi?id=217049

Patch by Angelos Oikonomopoulos <angelos@igalia.com> on 2020-09-28
Reviewed by Adrian Perez de Castro.

r267644 strips trailing whitespace in two LayoutTests/js/*expected.txt files
but doesn't update the corresponding js string literals to not produce such.

  • js/script-tests/parser-syntax-check.js:
  • js/script-tests/regexp-sticky.js:
1:20 AM WebKitGTK/StableRelease edited by Philippe Normand
(diff)
1:18 AM Changeset in webkit [267695] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit

Merge r267655 - [SOUP] WebSocket: cookies set in request don't appear in the inspector
https://bugs.webkit.org/show_bug.cgi?id=217012

Reviewed by Michael Catanzaro.

Cookies are set by libsoup and we are notifying about the handshake being sent before the cookie header is added
to the request.

  • NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::WebSocketTask): Connect to SoupMessage::starting to notify the web process the handshake
request has been sent.

1:18 AM Changeset in webkit [267694] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.30/Source

Merge r267621 - [SOUP] Do not set site for cookies twice in case of redirection
https://bugs.webkit.org/show_bug.cgi?id=217010

Reviewed by Michael Catanzaro.

Source/WebCore:

Only set is-toplevel-navigation on SoupMessage when same site info is present.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers const):

Source/WebKit:

ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in
NetworkDataTaskSoup::continueHTTPRedirection().

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Do not set same site information here, it will be done
again in NetworkDataTaskSoup::createRequest().

1:18 AM Changeset in webkit [267693] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore

Merge r267620 - [SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
https://bugs.webkit.org/show_bug.cgi?id=149551

Reviewed by Michael Catanzaro.

The problem is that we are not including all the cookies in the web socket request. There are two cookies with
the Lax same-site policy set, that are not included for the websocket request.

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.

Sep 27, 2020:

11:36 PM Changeset in webkit [267692] by commit-queue@webkit.org
  • 15 edits
    15 moves
    4 adds
    1 delete in trunk/LayoutTests

Resync web-platform-tests/html/semantics/the-iframe-element from upstream
https://bugs.webkit.org/show_bug.cgi?id=217033

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync web-platform-tests/html/semantics/the-iframe-element from upstream a520598adb3957def27f1b63c6bff62e891ccbda.

  • resources/resource-files.json:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/historical-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/historical.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-eager-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-eager.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-eager.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-eager.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-2.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-base-url.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-load-event.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-multiple-times.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-referrerpolicy-change.sub.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative-expected.txt.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy.tentative.html.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy.tentative-expected.txt: Removed.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-network-error.sub-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-network-error.sub.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads.sub.tentative-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads.sub.tentative.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads.sub.tentative-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_allow_downloads.sub.tentative.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads.sub.tentative-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigation_download_block_downloads.sub.tentative.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox-toggle-in-inactive-document-crash.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/download_stash.py:

(main):

  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:

LayoutTests:

Adjust for tentative extension removal.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_anchor_download_block_downloads.sub.tentative-expected.txt:
9:39 PM Changeset in webkit [267691] by Lauro Moura
  • 3 edits in trunk/Source/WebKit

REGRESSION(r267688) [GTK] Many compositing timeouts
https://bugs.webkit.org/show_bug.cgi?id=217044

Reviewed by Darin Adler.

Especulative fix by adding missing finalize step to
updateRendering (or calling isolatedUpdateRendering).

Covered by existing tests.

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
Call finalizeUpdateRendering.
(WebKit::DrawingAreaCoordinatedGraphics::display): Ditto.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:

(WebKit::LayerTreeHost::flushAndRenderLayers): Call
isolatedUpdateRendering instead of updateRendering on the corePage().

6:52 PM Changeset in webkit [267690] by weinig@apple.com
  • 3 edits in trunk/Source/WebKitLegacy/mac

Fix some typos found by Simon post-review for https://bugs.webkit.org/show_bug.cgi?id=217042

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
"rmeove" -> "remove".

6:42 PM Changeset in webkit [267689] by weinig@apple.com
  • 15 edits in trunk/Source/WebKitLegacy/mac

[Preferences] Generate base preferences for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217042

Reviewed by Tim Horton.

Imports (and sorts) WebPreferences.yaml from WebKit, and starts generation for
for WebKitLegacy. To support this, a few tweaks to generation were required:

  • A new 'exposed' key was added to the configuration files which allows restricting which frontends a preference is exposed to. By default, preferences are exposed to all frontends. This is intended to be used for preferences that don't have a binding to WebCore (e.g. process model related preferences for Webkit). We will require a seperate concept for features that WebCore knows about, but are not supported by a frontend, but that will be added in future revisions.

'exposed' is used in a few places that have 'custom' bindings to WebCore where
WebKitLegacy and WebKit don't use the same type or meaning for a preference, such
as WebKitLegacy's FrameFlattening enum vs. WebKit's FrameFlatteningEnabled bool,
or WebKitLegacy's WebSQLEnabled vs. WebKit's WebSQLDisabled. Eventually, it would
be nice to make these match, but it is not required.

  • A new 'webKitLegacyPreferenceKey' key was added to the configuration files allowing for existing keys that don't match the default pattern of "WebKit" + keyName. This is to avoid changing the value of the preference key strings in WebPreferenceKeysPrivate.h, as I am not confident that changing them is kosher. I also went back and reverted the few I had already changed, just to be on the safe side.
  • Support was added in WebViewPreferencesChangedGenerated.mm.erb for non bool values.
  • Preferences that are conditionally compiled out (using the conditional key) no longer generate a default when they are compiled out, which required a little macro magic in WebPreferencesDefinitions.h.erb in the form of the new INITIALIZE_DEFAULT_PREFERENCES_FOR_ macros.
  • Scripts/GeneratePreferences.rb:
  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
  • Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferences.yaml:
  • WebView/WebPreferencesDebug.yaml:
  • WebView/WebPreferencesDefaultValues.h:
  • WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultAllowsInlineMediaPlayback):
(WebKit::defaultAllowsInlineMediaPlaybackAfterFullscreen):
(WebKit::defaultAllowsPictureInPictureMediaPlayback):
(WebKit::defaultJavaScriptCanOpenWindowsAutomatically):
(WebKit::defaultInlineMediaPlaybackRequiresPlaysInlineAttribute):
(WebKit::defaultPassiveTouchListenersAsDefaultOnDocument):
(WebKit::defaultRequiresUserGestureToLoadVideo):
(WebKit::defaultWebSQLEnabled):
(WebKit::defaultAttachmentElementEnabled):
(WebKit::defaultShouldRestrictBaseURLSchemes):

  • WebView/WebPreferencesExperimental.yaml:
  • WebView/WebPreferencesInternal.h:
  • WebView/WebPreferencesInternal.yaml:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
(shouldAllowPictureInPictureMediaPlayback): Deleted.
(shouldAllowWindowOpenWithoutUserGesture): Deleted.
(shouldRequireUserGestureToLoadVideo): Deleted.
(shouldRestrictBaseURLSchemes): Deleted.

  • WebView/WebViewData.h:
5:23 PM Changeset in webkit [267688] by Simon Fraser
  • 10 edits in trunk/Source

WebKitLegacy should call Page::finalizeRenderingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=216958

Reviewed by Tim Horton.
Source/WebCore:

Convert Page::m_inUpdateRendering to an enum which tracks the phase, which will be
used in a later patch to prevent extra update scheduling (webkit.org/b/216726).

Add isolatedUpdateRendering(), which is for callers who aren't going to call finalizeRenderingUpdate(),
and use it for SVGImage updates.

DRT/WTR can trigger Page::updateRendering() re-entrancy, so there's a bit of ugliness
that deals with that.

  • page/Page.cpp:

(WebCore::Page::updateRendering):
(WebCore::Page::isolatedUpdateRendering):
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::finalizeRenderingUpdate):

  • page/Page.h:

Source/WebKit:

dynamicViewportSizeUpdate() needs to call isolatedUpdateRendering() because it isn't followed
by a finalizeRenderingUpdate().

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

Source/WebKitLegacy/mac:

This is a precursor to fixing webkit.org/b/216726. Page needs to track the phase
of updateRendering that we are in, and to ease this tracking, WebKitLegacy needs to call
Page::finalizeRenderingUpdate() so the state is tracked.

Rename -_viewWillDrawInternal to -_updateRendering, and have it call updateRendering()
and finalizeRenderingUpdate(). We can also move in the call to -_synchronizeCustomFixedPositionLayoutRect
which both call sites do.

Since updateRendering() is guaranteed to update layout, we know -_flushCompositingChanges would have
never returned NO here, so we can remove the condition in LayerFlushController::flushLayers().

-[WebHTMLView viewWillDraw] also does a similar -_web_updateLayoutAndStyleIfNeededRecursive
then -_flushCompositingChanges but this is called from AppKit with a timing that we don't control;
it may be redundant with -[WebView _updateRendering] but I leave that behavior unchanged.

  • WebView/WebView.mm:

(-[WebView _updateRendering]):
(-[WebView _forceRepaintForTesting]):
(LayerFlushController::flushLayers):
(-[WebView _viewWillDrawInternal]): Deleted.

Source/WebKitLegacy/win:

Windows doesn't call finalizeRenderingUpdate() so needs to use isolatedUpdateRendering().

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::flushAndRenderLayers):

  • WebView.cpp:

(WebView::paint):
(WebView::flushPendingGraphicsLayerChangesSoon):
(WebView::flushPendingGraphicsLayerChanges):

1:00 PM Changeset in webkit [267687] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r267540. rdar://problem/69593993

CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code
https://bugs.webkit.org/show_bug.cgi?id=216934
<rdar://problem/69216768>

Reviewed by Alex Christensen.

Add a check for a valid key.

  • NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::firstPartyHostCNAMEDomain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267686] by Alan Coon
  • 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r267530. rdar://problem/69594070

Regression(r265280) Web Audio sources malfunction when disconnected from the audio graph
https://bugs.webkit.org/show_bug.cgi?id=216703
<rdar://problem/69158436>

Reviewed by Eric Carlson.

In case of an audio source that stops producing data, but does not end or mute the track,
we would continuously try to read the data until getting to the end of the data.
When reaching the end of the data, we would return silence and go back in time a little bit
to restart playing with some margin. This allows to read just one chunk of audio until we are back to the end of data.

We fix this by storing the end of the data counter when reaching it.
When trying to pull some more data, we will go back in time a little bit only if some more data was added in the meantime.
Otherwise, we just output silence.

Covered by manual test.

  • platform/audio/mac/AudioSampleDataSource.h:
  • platform/audio/mac/AudioSampleDataSource.mm: (WebCore::AudioSampleDataSource::pullSamplesInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267685] by Alan Coon
  • 4 edits in branches/safari-610-branch/Source/ThirdParty/ANGLE

Cherry-pick r267520. rdar://problem/69594405

REGRESSION: Textures Fail to Render in WebGL from HLS Stream [iOS 14]
https://bugs.webkit.org/show_bug.cgi?id=215908
<rdar://problem/68000962>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-09-24
Reviewed by Dean Jackson.

Disable ANGLE workers until EAGL implementation is more complete.
Current implementation fails to compile any shader, since the
compilation happens in the worker thread and worker EAGL context
which does not use the same sharegroup as the main context.
The shader objects are created in the main context but the shader
source setting and compilation happens in the worker context.
EAGL needs a flush between state changes, and adding that
correctly is a bigger change to be done later.

Use sized formats when calling [EAGLContext -texImageIOSurface]
from EGL_ANGLE_iosurface_client_buffer code. The texImageIOSurface
accepts parameters with glTexImage2D logic. On ES3, some of the
internal formats must be sized formats. The EAGLContext instantiated
by ANGLE is ES3, even if the ANGLE context would be ES2.

No tests added since this should be caught with the many video
related tests. It's unclear why this is not the case -- at
least on real hw. This is to be investigated later, too.

  • src/libANGLE/renderer/driver_utils.h: (rx::IsIOS):
  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
  • src/libANGLE/renderer/gl/renderergl_utils.cpp: (rx::nativegl_gl::InitializeFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267684] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r267496. rdar://problem/69594104

[macOS] Change name of client decoder entitlement
https://bugs.webkit.org/show_bug.cgi?id=216670
<rdar://problem/69101997>

Reviewed by Darin Adler.

The client decoder entitlement landed in <https://trac.webkit.org/changeset/266613/webkit> has changed name, and should be updated.

  • Scripts/process-entitlements.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267683] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r267412. rdar://problem/69594162

Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810

Reviewed by Tim Horton.

To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.

This is a speculative fix due to the aforementioned reproducibility issue.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed" checks. So put an explicit check here followed by an explicit release assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267682] by Alan Coon
  • 5 edits in branches/safari-610-branch/Source

Cherry-pick r267394. rdar://problem/69593980

paper.io ad close buttons cannot be iteracted with via trackpad on iPad
https://bugs.webkit.org/show_bug.cgi?id=216812
<rdar://problem/68738585>

Reviewed by Wenson Hsieh.

Source/WebCore:

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm: (WebCore::IOSApplication::isPaperIO):

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm: (applicationIsKnownToIgnoreMouseEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267681] by Alan Coon
  • 13 edits in branches/safari-610-branch

Cherry-pick r267369. rdar://problem/69594300

[WebAuthn] Don't set the UV option if the authenticator doesn't support it
https://bugs.webkit.org/show_bug.cgi?id=215836
<rdar://problem/67817359>

Reviewed by Darin Adler.

Source/WebCore:

Covered by new API tests.

UV in the the CTAP 2.0 spec only means internal UV:
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorGetInfo

If an authenticator supports ClientPin, it can set the uv bit in the responses to true but it
will not advertise itself supporting internal UV, which is the uv in the options.
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorMakeCredential

Hence, setting it to true could result in error if the authenticator doesn't support internal UV even if it supports ClientPin.
It's not a way to ask the authenticator to set the uv bit in the response.

  • Modules/webauthn/fido/DeviceRequestConverter.cpp: (fido::encodeMakeCredenitalRequestAsCBOR): (fido::encodeGetAssertionRequestAsCBOR):

Tools:

  • TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: (TestWebKitAPI::TEST):

LayoutTests:

  • http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
  • http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267680] by Alan Coon
  • 4 edits in branches/safari-610-branch

Cherry-pick r267305. rdar://problem/69594350

[macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data
https://bugs.webkit.org/show_bug.cgi?id=216718
<rdar://problem/69150358>

Reviewed by Tim Horton.

Source/WebKit:

Test: CopyHTML.WriteRichTextSelectionToPasteboard

  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::dataSelectionForPasteboard):

After r265702, the IPCHandle received in the UI process was always being converted into a buffer of size 0,
due to using the size local variable (which is no longer set as an outparam of the sync IPC message). Instead,
use ipcHandle.dataSize.

Tools:

Add a new API test to verify that we get non-empty web archive data when using
-writeSelectionToPasteboard:types: to grab selected content as rich text data.

  • TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267679] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/JavaScriptCore

Cherry-pick r267304. rdar://problem/69594380

[JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct
https://bugs.webkit.org/show_bug.cgi?id=216717

Reviewed by Mark Lam.

When starting full GC, at beginMarking, PreciseAllocation's mark bit is cleared to be usable for upcoming marking.
However, this means that HeapCell::isLive will see this object as dead until it is marked.
Let's consider that this object is not newly allocated one. Then, its isNewlyAllocated is false. And now mark bit

is also cleared. Since PreciseAllocation::isLive is isNewlyAllocated
isMarked, then it looks dead, while it is live.

This confuses HeapCell:isLive function and makes some of watchpoints perform wrong decisions (e.g. this condition is
no longer valid, let's just discard it).
At the beginning of full collection, we should propagate the old mark bit to isNewlyAllocated so that it looks live
during marking. This is similar trick to MarkedBlock::aboutToMark.

  • heap/PreciseAllocation.cpp: (JSC::PreciseAllocation::flip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267678] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r267287. rdar://problem/69594243

Crash under WebCore::shouldResetFocusNavigationStartingNode()
https://bugs.webkit.org/show_bug.cgi?id=216714
<rdar://problem/68132047>

Reviewed by Darin Adler.

Protect anchorElement in FrameView::scrollToFragmentInternal() to make sure
it stays alive until the time we pass it to setFocusNavigationStartingNode().

  • page/FrameView.cpp: (WebCore::FrameView::scrollToFragmentInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267677] by Alan Coon
  • 4 edits in branches/safari-610-branch/Source

Cherry-pick r267215. rdar://problem/69594225

Per-app accent color overrides are broken
https://bugs.webkit.org/show_bug.cgi?id=216674
<rdar://problem/67745464>

Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

  • pal/spi/mac/NSApplicationSPI.h:

Source/WebKit:

No new tests; I've no idea how to write a test that would have caught this;
any test I can imagine would have also written to _accentColor and worked fine.

  • UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::accentColor): AppKit changed the meaning of the IPI. Use the correct version. We still write to _accentColor; it is now purely an override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267676] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r267198. rdar://problem/69594065

[iOS] YouTube does not route video to AirPlay the first time
https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>

Reviewed by Eric Carlson.

Difficult to test this, since it requires an live AppleTV device.

During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.

  • platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267675] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r267148. rdar://problem/69594002

[macOS] Limit reported macOS release to 10.15 series
https://bugs.webkit.org/show_bug.cgi?id=216593
<rdar://problem/68937905>

Reviewed by Maciej Stachowiak.

If the reported system OS is 11.0 (or beyond) report the last stable release
of macOS.

  • platform/mac/UserAgentMac.mm: (WebCore::standardUserAgentWithApplicationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267674] by Alan Coon
  • 4 edits in branches/safari-610-branch

Cherry-pick r267092. rdar://problem/69594199

REGRESSION (r267002): ASSERTION FAILED:[ iOS wk2 Debug ] !HashTranslator::equal(KeyTraits::emptyValue(), key) on compositing/ios/overflow-scroll-update-overlap.html
https://bugs.webkit.org/show_bug.cgi?id=216520
<rdar://problem/68894931>

Reviewed by Tim Horton.

Source/WebKit:

Avoid hash lookups with zero nodeIDs.

  • WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const): (WebKit::RemoteScrollingCoordinator::isUserScrollInProgress const): (WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress const):

LayoutTests:

  • platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267673] by Alan Coon
  • 20 edits in branches/safari-610-branch/Source

Cherry-pick r267002. rdar://problem/69594199

Overflow:scroll rubberbanding is interrupted by post-layout scrolling
https://bugs.webkit.org/show_bug.cgi?id=216463
<rdar://problem/67095741>

Reviewed by Darin Adler.

When rubberbanding overflow:scroll RenderLayer has an overscrolled scroll offset.
If RenderLayer::updateScrollInfoAfterLayout() happens when in this state, it can
clamp the scroll offset, causing the rubberband to collapse which interferes with
the user interaction. This happend on Gmail when composing a reply.

Fix by tracking the rubberbanding state in the scrolling tree, and having RenderLayer
query this state via the ScrollingCoordinator. RenderLayer::updateScrollInfoAfterLayout()
already tested isRubberBandInProgress(). This is similar to how isUserScrollInProgress()
and isScrollSnapInProgress() work.

This patch also fixes the tracking of rubberbanding state. Previously setMainFrameIsRubberBanding()
was just based on when the timer was started and stopped, which did not match the
implementation of ScrollController::isRubberBandInProgress(). Now ScrollController
correctly notifies its clients when the rubberbanding state changes by updating that
state whenever any of the conditions consulted in isRubberBandInProgressInternal() change.

Source/WebCore:

I tried to make tests for this, but the timing of wheel and scroll event delivery makes
reliable detection of interrupted rubberbands impossible in WebKitTestRunner.

  • page/FrameView.cpp: (WebCore::FrameView::isRubberBandInProgress const):
  • page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::isRubberBandInProgress const):
  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::isRubberBandInProgress const):
  • page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::isRubberBandInProgressForNode): (WebCore::ScrollingTree::setRubberBandingInProgressForNode): (WebCore::ScrollingTree::isRubberBandInProgress): Deleted. (WebCore::ScrollingTree::setMainFrameIsRubberBanding): Deleted.
  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged): (WebCore::ScrollingTreeFrameScrollingNodeMac::updateMainFramePinAndRubberbandState):
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm: (WebCore::ScrollingTreeOverflowScrollingNodeMac::currentScrollPositionChanged):
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::currentScrollPositionChanged): (WebCore::ScrollingTreeScrollingNodeDelegateMac::isRubberBandInProgress const): (WebCore::ScrollingTreeScrollingNodeDelegateMac::didStopRubberbandSnapAnimation): (WebCore::ScrollingTreeScrollingNodeDelegateMac::rubberBandingStateChanged):
  • platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::notifyPositionChanged):
  • platform/cocoa/ScrollController.h: (WebCore::ScrollControllerClient::rubberBandingStateChanged):
  • platform/cocoa/ScrollController.mm: (WebCore::ScrollController::handleWheelEvent): (WebCore::ScrollController::snapRubberBandTimerFired): (WebCore::ScrollController::scrollPositionChanged): (WebCore::ScrollController::isRubberBandInProgress const): (WebCore::ScrollController::stopSnapRubberbandTimer): (WebCore::ScrollController::isRubberBandInProgressInternal const): (WebCore::ScrollController::updateRubberBandingState): (WebCore::ScrollController::updateGestureInProgressState):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isRubberBandInProgress const): (WebCore::RenderLayer::updateScrollInfoAfterLayout):

Source/WebKit:

  • WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::isRubberBandInProgress const): (WebKit::RemoteScrollingCoordinator::scrollingStateInUIProcessChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267672] by Alan Coon
  • 5 edits
    2 adds in branches/safari-610-branch

Cherry-pick r266611. rdar://problem/69594191

MediaRecorder timeslice parameter causing internal error on longer videos
https://bugs.webkit.org/show_bug.cgi?id=216076
<rdar://problem/68209422>

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/wpt/fetch/blob-range.html

  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readDataAsync):

Source/WebKit:

Test: http/wpt/fetch/blob-range.html

  • NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::readData): readData can be re-entrant so we need to reset m_currentItemReadSize before consuming data.

LayoutTests:

  • http/wpt/fetch/blob-range-expected.txt: Added.
  • http/wpt/fetch/blob-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267671] by Alan Coon
  • 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266312. rdar://problem/69594218

[macOS] AirPlay device name is wrong when playing to multiple devices
https://bugs.webkit.org/show_bug.cgi?id=215952
<rdar://problem/66930799>

Reviewed by Jer Noble.

Tested manually because this requires a specific hardware setup.

  • platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm: (WebCore::MediaPlaybackTargetCocoa::deviceName const): If the AVOutputContext supports multiple output devices, create the device name by concatenating the names of all of the active output devices.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [267670] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r265977. rdar://problem/69594018

Could not find module 'WebKit' for target 'armv7-apple-ios'
<https://bugs.webkit.org/show_bug.cgi?id=215190>
<rdar://problem/65642049>

Reviewed by Brady Eidson.

The config changes here got added to the wrong config file. They need to
be for the overlay, not its tests.

  • SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig:
  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:59 PM Changeset in webkit [267669] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r265322. rdar://problem/69594018

Could not find module 'WebKit' for target 'armv7-apple-ios'
<https://bugs.webkit.org/show_bug.cgi?id=215190>
<rdar://problem/65642049>

Reviewed by Brady Eidson.

  • SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig: Define SWIFT_MODULE_ONLY_ARCHS to emit other architectures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:48 AM Changeset in webkit [267668] by Darin Adler
  • 2 edits in trunk/Tools

Remove run-webkit-tests code that strips trailing spaces when comparing expected.txt files
https://bugs.webkit.org/show_bug.cgi?id=217041

Reviewed by Sam Weinig.

  • Scripts/webkitpy/port/base.py:

(Port.do_text_results_differ): Removed code to strip the expected text before comparing.

9:45 AM Changeset in webkit [267667] by Darin Adler
  • 5 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from the last few expected.txt files that have them
https://bugs.webkit.org/show_bug.cgi?id=217040

Reviewed by Zalan Bujtas.

  • web-platform-tests/content-security-policy/style-src/style-src-imported-style-allowed.sub-expected.txt:
  • web-platform-tests/content-security-policy/style-src/style-src-imported-style-blocked-expected.txt:
  • web-platform-tests/css/css-text/white-space/append-whitespace-only-node-crash-001-expected.txt:
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:

Remove trailing spaces.

9:30 AM Changeset in webkit [267666] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Unreviewed. Call showLayoutTree only when trees are mismatching.

  • layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):

8:37 AM Changeset in webkit [267665] by Darin Adler
  • 15 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/euc-jp
https://bugs.webkit.org/show_bug.cgi?id=217037

Reviewed by Zalan Bujtas.

To run at a resaonable speed, we may want to find a way to change these encoding tests to not
decode each character separately since that's not critical to what they are testing; this likely
would result in tests fast enough to run as regression tests (right now they are skipped) and
much smaller output files too. But for now, these are colossal files.

  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-decode-cseucpkdfmtjapanese-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-decode-errors-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-decode-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-decode-x-euc-jp-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-cseucpkdfmtjapanese-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-form-x-euc-jp-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-expected.txt:

Remove trailing spaces.

8:36 AM Changeset in webkit [267664] by Darin Adler
  • 27 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in imported/w3c/web-platform-tests/encoding/legacy-mb-korean
https://bugs.webkit.org/show_bug.cgi?id=217036

Reviewed by Zalan Bujtas.

To run at a resaonable speed, we may want to find a way to change these encoding tests to not
decode each character separately since that's not critical to what they are testing; this likely
would result in tests fast enough to run as regression tests (right now they are skipped) and
much smaller output files too. But for now, these are colossal files.

  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-cseuckr-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-csksc56011987-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-errors-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-iso-ir-149-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-korean-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-ks_c_5601-1987-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-ks_c_5601-1989-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-ksc5601-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-ksc_5601-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-decode-windows-949-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-cseuckr-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-csksc56011987-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-iso-ir-149-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-korean-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ks_c_5601-1987-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ks_c_5601-1989-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ksc5601-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ksc_5601-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-form-windows-949-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-korean/euc-kr/euckr-encode-href-expected.txt:

Strip trailing spaces from these files.

8:36 AM Changeset in webkit [267663] by Darin Adler
  • 25 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis
https://bugs.webkit.org/show_bug.cgi?id=217039

Reviewed by Zalan Bujtas.

To run at a resaonable speed, we may want to find a way to change these encoding tests to not
decode each character separately since that's not critical to what they are testing; this likely
would result in tests fast enough to run as regression tests (right now they are skipped) and
much smaller output files too. But for now, these are colossal files.

  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-csshiftjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-errors-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-ms932-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-ms_kanji-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-shift-jis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-sjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-windows-31j-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-decode-x-sjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-csshiftjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms932-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-ms_kanji-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-shift-jis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-sjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-windows-31j-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-form-x-sjis-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-expected.txt:

Remove trailing spaces.

8:35 AM Changeset in webkit [267662] by Darin Adler
  • 14 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp
https://bugs.webkit.org/show_bug.cgi?id=217038

Reviewed by Zalan Bujtas.

To run at a resaonable speed, we may want to find a way to change these encoding tests to not
decode each character separately since that's not critical to what they are testing; this likely
would result in tests fast enough to run as regression tests (right now they are skipped) and
much smaller output files too. But for now, these are colossal files.

  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-decode-csiso2022jp-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-decode-errors-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-decode-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-csiso2022jp-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-errors-stateful-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-form-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-japanese/iso-2022-jp/iso2022jp-encode-href-expected.txt:

Remove trailng spaces.

8:34 AM Changeset in webkit [267661] by Darin Adler
  • 24 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in imported/w3c/web-platform-tests/encoding/legacy-mb-tchinese/big5
https://bugs.webkit.org/show_bug.cgi?id=217035

Reviewed by Zalan Bujtas.

To run at a resaonable speed, we may want to find a way to change these encoding tests to not
decode each character separately since that's not critical to what they are testing; this likely
would result in tests fast enough to run as regression tests (right now they are skipped) and
much smaller output files too. But for now, these are colossal files.

  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-big5-hkscs-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-cn-big5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-csbig5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-errors-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-extra-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-decode-x-x-big5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-enc-ascii-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-big5-hkscs-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-cn-big5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-csbig5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBb-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-pua-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-form-x-x-big5-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-hangul-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-misc-expected.txt:
  • web-platform-tests/encoding/legacy-mb-tchinese/big5/big5-encode-href-expected.txt:

Strip trailing spaces from all these files. No other changes at this time.

8:17 AM Changeset in webkit [267660] by Darin Adler
  • 362 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/dom
https://bugs.webkit.org/show_bug.cgi?id=217029

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

8:15 AM Changeset in webkit [267659] by Darin Adler
  • 84 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/encoding, not including the tests in the legacy-mb directories
https://bugs.webkit.org/show_bug.cgi?id=217030

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

7:41 AM Changeset in webkit [267658] by Darin Adler
  • 1230 edits in trunk/LayoutTests

Remove trailing spaces from all expected.txt files outside the web-platform-tests directory
https://bugs.webkit.org/show_bug.cgi?id=217027

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

6:03 AM Changeset in webkit [267657] by Alan Bujtas
  • 8 edits
    2 adds in trunk

[LFC][IFC] Create inline boxes for hard line breaks(<br>) and word wrap opportunities (<wbr>)
https://bugs.webkit.org/show_bug.cgi?id=217023

Reviewed by Antti Koivisto.

Source/WebCore:

Both hard <br> and the word break opportunity layout boxes generate inline boxes and get computed box geometries.
It enables us to answer questions like element.offsetTop/offsetLeft.

Test: fast/layoutformattingcontext/br-and-wbr-simple.html

  • layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::boxGeometry):

  • layout/Verification.cpp:

(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):

  • layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::isLineBreak const):
(WebCore::Layout::Line::Run::isSoftLineBreak const):
(WebCore::Layout::Line::Run::isHardLineBreak const):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):

LayoutTests:

  • fast/layoutformattingcontext/br-and-wbr-simple-expected.html: Added.
  • fast/layoutformattingcontext/br-and-wbr-simple.html: Added.
5:55 AM Changeset in webkit [267656] by cathiechen
  • 4 edits in trunk/LayoutTests/imported/w3c

Add support to pause in testdriver.js
https://bugs.webkit.org/show_bug.cgi?id=216933

Reviewed by Darin Adler

While simulating a mouse action, pause in dispatchMouseActions() is needed. Otherwise, the events are sent
without delay, the simulation might not be effective. The patch uses JS setTimeout to simulate a pause.

  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt:
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:
  • web-platform-tests/resources/testdriver-vendor.js:

(pause): Use setTimeout to simulate a pause.
(dispatchMouseActions):

5:45 AM Changeset in webkit [267655] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[SOUP] WebSocket: cookies set in request don't appear in the inspector
https://bugs.webkit.org/show_bug.cgi?id=217012

Reviewed by Michael Catanzaro.

Cookies are set by libsoup and we are notifying about the handshake being sent before the cookie header is added
to the request.

  • NetworkProcess/soup/WebSocketTaskSoup.cpp:

(WebKit::WebSocketTask::WebSocketTask): Connect to SoupMessage::starting to notify the web process the handshake
request has been sent.

5:35 AM Changeset in webkit [267654] by commit-queue@webkit.org
  • 18 edits
    3 deletes in trunk

Alias WebKitCSSMatrix to DOMMatrix
https://bugs.webkit.org/show_bug.cgi?id=153675

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-27
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update imrpved test results.

  • web-platform-tests/css/geometry/DOMMatrix-stringifier-expected.txt:
  • web-platform-tests/css/geometry/WebKitCSSMatrix-expected.txt:

Source/WebCore:

Alias WebKitCSSMatrix to DOMMatrix and remove
the generated JSWebKitCSSMatrix as well as
WebKitCSSMatrix itself since it is no longer
needed.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/DOMMatrix.idl:
  • css/WebKitCSSMatrix.cpp: Removed.
  • css/WebKitCSSMatrix.h: Removed.
  • css/WebKitCSSMatrix.idl: Removed.

LayoutTests:

Adapt tests to expect DOMMatrix behavior rather than WebKitCSSMatrix.

  • platform/ios/ios/css/construct-WebKitCSSMatrix-expected.txt:
  • platform/ios/ios/css/resources/construct-WebKitCSSMatrix.js:
  • transforms/cssmatrix-2d-interface-expected.txt:
  • transforms/cssmatrix-2d-interface.xhtml:
  • transforms/cssmatrix-3d-interface-expected.txt:
  • transforms/cssmatrix-3d-interface.xhtml:
1:14 AM Changeset in webkit [267653] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk

Add .ccls config file
https://bugs.webkit.org/show_bug.cgi?id=216877

Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-27
Reviewed by Darin Adler.

ccls is a stand-alone server implementing the Language Server Protocol for C, C++, and
Objective-C languages. It can be used with any editor which provides an LSP client
implementation. It originates from cquery.

https://github.com/MaskRay/ccls/wiki

It's basically used to provide semantic highlighting and code navigation. Many IDEs support
LSP nowadays.

  • .ccls: Added.
  • .gitignore:
12:37 AM Changeset in webkit [267652] by commit-queue@webkit.org
  • 18 edits in trunk

Clean up type parameter for Event idl
https://bugs.webkit.org/show_bug.cgi?id=217013

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-27
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

  • web-platform-tests/html/dom/idlharness.https-expected.txt:

Source/WebCore:

Clean up type parameter for Event idl files, there is no need to
pass "undefined" default value.

  • dom/CompositionEvent.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/UIEvent.idl:
  • storage/StorageEvent.idl:

LayoutTests:

Update improved test results.

  • platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

Sep 26, 2020:

11:30 PM Changeset in webkit [267651] by Darin Adler
  • 1478 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/[A-Za-h] minus css, dom, encoding, and html
https://bugs.webkit.org/show_bug.cgi?id=217024

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

11:26 PM Changeset in webkit [267650] by Darin Adler
  • 2454 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/css
https://bugs.webkit.org/show_bug.cgi?id=217018

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

11:20 PM Changeset in webkit [267649] by Darin Adler
  • 1289 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/[w-z]*
https://bugs.webkit.org/show_bug.cgi?id=217022

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

10:56 PM Changeset in webkit [267648] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC] Add <wbr> to showLayoutTree
https://bugs.webkit.org/show_bug.cgi?id=217025

Reviewed by Darin Adler.

This patch also tweaks the inline tree output (one line geometry output per line, different output format).

<div style="width: 100px;">first_line<wbr>second_line</div>

block box at (0,10) size 100x20

line at (0.00,0.00) size 100.00x10.00 baseline at (8.00)
line at (0.00,10.00) size 100.00x10.00 baseline at (8.00)

text run at (0.00,0.00) size 100.00x10.00 run(0, 10)
text run at (0.00,0.00) size 110.00x10.00 run(0, 11)

anonymous inline box (0x495583d20) length->(10) "first_line"
word break opportunity at (100,8) size 0x0 (0x4967c0680)
anonymous inline box (0x495591e00) length->(11) "second_line"

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutBox):

9:43 PM Changeset in webkit [267647] by Darin Adler
  • 2952 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/[i-v]*
https://bugs.webkit.org/show_bug.cgi?id=217020

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

8:34 PM Changeset in webkit [267646] by Darin Adler
  • 4387 edits in trunk/LayoutTests/imported/w3c

Remove trailing spaces from expected.txt files in web-platform-tests/html
https://bugs.webkit.org/show_bug.cgi?id=217019

Reviewed by Zalan Bujtas.

This affects many files, and it's not helpful to fill the change log with a list of them.

7:48 PM Changeset in webkit [267645] by wenson_hsieh@apple.com
  • 14 edits in trunk

Remove support for setting CMYKA fill and stroke colors in 2D canvas
https://bugs.webkit.org/show_bug.cgi?id=217002

Reviewed by Darin Adler.

Source/WebCore:

Remove support for setFillColor(c, m, y, k, a) and setStrokeColor(c, m, y, k, a) on
CanvasRenderingContext2D, which was initially introduced in 2004 with <https://trac.webkit.org/r6730>.
Setting colors from CMYKA components is non-standard and unsupported in both Firefox and Chrome;
importantly, this is implemented in CanvasStyle::applyStrokeColor by calling directly into CoreGraphics
API using the platform CGContextRef, which is null when using the GPU Process; this subsequently causes
the web process to crash.

In lieu of adding new DisplayList items to support setting fill and stroke colors with CMYKA components,
we can take this opportunity to just drop support for this canvas API entirely. Fixes the following tests
when using the GPU Process to render canvas:

  • fast/canvas/canvas-color-serialization.html
  • fast/canvas/canvas-overloads-setFillColor.html
  • fast/canvas/canvas-overloads-setStrokeColor.html
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/CanvasRenderingContext2DBase.cpp:
  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::isEquivalentColor const):
(WebCore::CanvasStyle::applyStrokeColor const):
(WebCore::CanvasStyle::applyFillColor const):

  • html/canvas/CanvasStyle.h:

(WebCore::CanvasStyle::color const):

LayoutTests:

Remove calls to CanvasRenderingContext2D.setFillColor(c, m, y, k, a) and
CanvasRenderingContext2D.setStrokeColor(c, m, y, k, a) in these layout tests.

  • fast/canvas/canvas-color-serialization-expected.txt:
  • fast/canvas/canvas-color-serialization.html:
  • fast/canvas/set-colors-expected.txt:
  • fast/canvas/set-colors.html:
  • inspector/canvas/recording-2d-full-expected.txt:
  • inspector/canvas/resources/recording-2d.js:
  • platform/ios/fast/canvas/set-colors-expected.txt:
  • platform/mac/fast/canvas/set-colors-expected.txt:
7:15 PM Changeset in webkit [267644] by Darin Adler
  • 3539 edits in trunk/LayoutTests

Remove trailing spaces from expected.txt files (excluding WPT for now since that contains too many)
https://bugs.webkit.org/show_bug.cgi?id=217016

Reviewed by Zalan Bujtas.

Done with this command:

find LayoutTests -name '*-expected.txt' | grep -v imported | xargs awk '/CONSOLE MESSAGE:/ { next }; /<\?xml/ { nextfile }; { print FILENAME; nextfile }' | xargs perl -i -pe 's/ +$g'

This affects many files, and it's not helpful to clog the change log with a list of them.

6:03 PM Changeset in webkit [267643] by Alan Coon
  • 3 edits
    2 deletes in branches/safari-610-branch

Revert r266887. rdar://problem/69586659

6:03 PM Changeset in webkit [267642] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Revert r266899. rdar://problem/69586659

5:21 PM Changeset in webkit [267641] by weinig@apple.com
  • 13 edits
    1 copy in trunk/Source/WebKitLegacy

[Preferences] Generate Debug and Internal preferences for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217015

Reviewed by Darin Adler.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Adds generation of WebPreferencesInternalFeatures.mm from WebPreferencesInternalFeatures.mm.erb.

Source/WebKitLegacy/mac:

Imports WebPreferencesDebug.yaml and WebPreferencesInternal.yaml from WebKit and starts
generating them.

In addition, preference yaml files must now be sorted alphabetically by preference name, and
this is now enforced by GeneratePreferences.rb, generating an error if they are out of order.

  • Scripts/GeneratePreferences.rb:
  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
  • Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: Added.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(+[WebPreferences _internalDebugFeatures]): Deleted.

  • WebView/WebPreferencesDebug.yaml:
  • WebView/WebPreferencesDefaultValues.h:
  • WebView/WebPreferencesExperimental.yaml:
  • WebView/WebPreferencesInternal.yaml:
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

4:23 PM Changeset in webkit [267640] by Darin Adler
  • 11 edits in trunk/Tools

Change dumpAsText to strip trailing spaces
https://bugs.webkit.org/show_bug.cgi?id=216944

Reviewed by Alan Bujtas.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText): Strip trailing spaces.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
Don't add trailing space.

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]): Ditto.
(addLeadingSpaceStripTrailingSpaces): Added.
(stripTrailingSpaces): Added.
(-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Don't add trailing space.
(-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
(-[UIDelegate webView:setStatusText:]): Ditto.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpFramesAsText): Strip trailing spaces.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::willPerformClientRedirectToURL): Don't add trailing space.

  • DumpRenderTree/win/UIDelegate.cpp:

(toMessage): Changed to return std::wstring.
(stripTrailingSpaces): Added.
(addLeadingSpaceStripTrailingSpaces): Added.
(UIDelegate::runJavaScriptAlertPanelWithMessage): Don't add trailing space.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.
(UIDelegate::setStatusText): Ditto.

  • Scripts/webkitpy/port/base.py:

(Port.do_text_results_differ): Strip trailing spaces from expected text.
Plan is to remove this after stripping the actual expected.txt files.

  • Scripts/webkitpy/port/win.py:

(WinPort.do_text_results_differ): Call through to base.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpFrameText): Strip trailing spaces.
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Don't add trailing space.
(WTR::InjectedBundlePage::decidePolicyForNavigationAction): Ditto.
(WTR::stripTrailingSpaces): Added.
(WTR::addLeadingSpaceStripTrailingSpaces): Added.
(WTR::InjectedBundlePage::willAddMessageToConsole): Don't add trailing space.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.

3:13 PM Changeset in webkit [267639] by Chris Dumez
  • 24 edits
    2 adds
    2 deletes in trunk

Constructing an AudioNode for a closed context should not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=216994

Reviewed by Darin Adler.

Source/WebCore:

Constructing an AudioNode for a closed context should not throw an exception. This
behavior is not as per specification and does not match the behavior of Chrome &
Firefox either.

Test: webaudio/construct-node-with-closed-context.html

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::lazyInitialize):
(WebCore::BaseAudioContext::sampleRate const):

  • Modules/webaudio/BaseAudioContext.h:
  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):

  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::create):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::create):

  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::create):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::create):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::create):

  • Modules/webaudio/IIRFilterNode.cpp:

(WebCore::IIRFilterNode::create):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::create):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::create):

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::create):

  • Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::create):

  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::create):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::create):

LayoutTests:

  • http/wpt/webaudio/audiocontext-stopped-expected.txt: Removed.
  • http/wpt/webaudio/audiocontext-stopped.html: Removed.

Drop outdated test. It is replaced with the new test I am introducing.

  • webaudio/MediaStreamAudioDestination/create-in-destroyed-context-expected.txt:

Rebaseline Blink-imported test that is now passing.

  • webaudio/construct-node-with-closed-context-expected.txt: Added.
  • webaudio/construct-node-with-closed-context.html: Added.

Add layout test coverage.

3:07 PM Changeset in webkit [267638] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Drop AudioNode::lazyInitialize()
https://bugs.webkit.org/show_bug.cgi?id=217004

Reviewed by Darin Adler.

Drop AudioNode::lazyInitialize(), this is dead code.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::lazyInitialize): Deleted.

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::isInitialized const):

2:31 PM Changeset in webkit [267637] by Alan Bujtas
  • 7 edits
    2 adds in trunk

[LFC][IFC] Add support for <wbr>
https://bugs.webkit.org/show_bug.cgi?id=217014

Reviewed by Antti Koivisto.

Source/WebCore:

Introduce the WordBreakOpportunity type of InlineItem and take it into account while searching for word break opportunities.
It generates an empty line run but it does not yet have geometry information.

Test: fast/layoutformattingcontext/wbr-simple.html

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):

  • layout/inlineformatting/InlineItem.h:

(WebCore::Layout::InlineItem::isWordBreakOpportunity const):

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendWith):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendWordBreakOpportunity):

  • layout/inlineformatting/InlineLine.h:

(WebCore::Layout::Line::Run::isWordBreakOpportunity const):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::nextWrapOpportunity):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::inlineItemWidth const):
(WebCore::Layout::LineBuilder::nextContentForLine):

LayoutTests:

  • fast/layoutformattingcontext/wbr-simple-expected.html: Added.
  • fast/layoutformattingcontext/wbr-simple.html: Added.
2:08 PM Changeset in webkit [267636] by Alan Coon
  • 3 edits
    1 add in branches/safari-610-branch

Cherry-pick r267135. rdar://problem/69586651

JSImmutableButterfly::get needs to return jsDoubleNumber for double arrays
https://bugs.webkit.org/show_bug.cgi?id=216589
<rdar://problem/68061245>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/jsimmutablebutterfly-get-must-return-double-boxed-value.js: Added.

Source/JavaScriptCore:

We are using JSImmutableButterfly::get in AI to constant fold GetByVal,
but we were failing to always return a boxed double value for double loads.
We were calling jsNumber instead of jsDooubleNumber. This is in contrast to
the runtime, which always returns a double boxed value. This would lead AI
to disagree with the runtime, and miscompile code.

  • runtime/JSImmutableButterfly.h: (JSC::JSImmutableButterfly::get const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267635] by Alan Coon
  • 7 edits
    1 add in branches/safari-610-branch

Cherry-pick r267113. rdar://problem/69586723

CustomFunctionEquivalence PropertyCondition needs to check if the structure has the property
https://bugs.webkit.org/show_bug.cgi?id=216575
<rdar://problem/68286930>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/has-static-property-property-condition-needs-to-check-if-structure-has-property.js: Added. (foo):

Source/JavaScriptCore:

The CustomFunctionEquivalence PropertyCondition would only return false to
isStillValidAssumingImpurePropertyWatchpoint if the Structure's static
property table was reified or if the static property table did not contain the
property. However, this missed the obvious case of where we store to this
property in normal object storage without reifying the static property table.
The fix here is simple: we first check if the Structure's property table
has this property, and if so, return false.

This patch also renames CustomFunctionEquivalence to HasStaticProperty to
better capture what we're doing.

  • bytecode/ObjectPropertyCondition.h: (JSC::ObjectPropertyCondition::hasStaticProperty): (JSC::ObjectPropertyCondition::customFunctionEquivalence): Deleted.
  • bytecode/ObjectPropertyConditionSet.cpp: (JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition const): (JSC::ObjectPropertyConditionSet::slotBaseCondition const): (JSC::generateConditionsForPrototypePropertyHitCustom):
  • bytecode/PropertyCondition.cpp: (JSC::PropertyCondition::dumpInContext const): (JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const): (JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint const): (JSC::PropertyCondition::isStillValid const): (JSC::PropertyCondition::isWatchableWhenValid const): (WTF::printInternal):
  • bytecode/PropertyCondition.h: (JSC::PropertyCondition::hasStaticProperty): (JSC::PropertyCondition::hash const): (JSC::PropertyCondition::operator== const): (JSC::PropertyCondition::customFunctionEquivalence): Deleted.
  • tools/JSDollarVM.cpp: (JSC::functionCreateStaticCustomValue): (JSC::JSDollarVM::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267634] by Alan Coon
  • 5 edits
    3 adds in branches/safari-610-branch

Cherry-pick r267067. rdar://problem/69586680

REGRESSION (Async overflow scroll): Code snippets on getkirby.com appear and disappear as content is scrolled
https://bugs.webkit.org/show_bug.cgi?id=216490
<rdar://problem/67018073>

Reviewed by Zalan Bujtas.
Source/WebCore:

The content in question had a z-order layer tree like this:

A (0,0) width=997 height=829 (layerID 20) {sc 2} RenderView

+ B (0,0) width=997 height=8 RenderBlock HTML class='no-js'

+ C (0,0) width=997 height=829 RenderFlexibleBox MAIN

n D (0,0) width=256 height=829 RenderFlexibleBox NAV class='left panel'

n E (0,0) width=256 height=829 (layerID 25) {sc 3} RenderBlock DIV class='scroller'

n F (256,0) width=741 height=829 RenderFlexibleBox ARTICLE class='main panel'

n G (0,0) width=741 height=829 (layerID 26) {sc 4} RenderBlock DIV class='scroller'

n H (0,-816) width=741 height=2810 RenderBlock DIV class='article-content'

+ I (0,0) width=256 height=1000 (layerID 27) overlap RenderBlock (relative positioned) DIV class='content'
+ J (10,300) width=721 height=202 (layerID 28) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ K (10,802) width=721 height=202 (layerID 29) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ L (10,1304) width=721 height=202 (layerID 30) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,1806) width=721 height=202 (layerID 31) overlap RenderBlock (relative positioned) DIV class='relative-box'
+ M (10,2308) width=721 height=202 (layerID 32) overlap RenderBlock (relative positioned) DIV class='relative-box'

When layer 'G' is scrolled, the code would find the paint-order parent, F, which is normal-flow because it has overflow:hidden,
and would call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it. However, that doesn't go high enough, because
we need to update J-M since their ancestor clipping stacks have geometry that relies on the scroll position of G. If we don't
update that geometry, GraphicsLayers have an incorrect notion of what's visible, and we don't attach backing store.

The fix is to climb up to the stacking context B and call setDescendantsNeedUpdateBackingAndHierarchyTraversal() on it.

Test: compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollTo):

LayoutTests:

  • compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/nested-scrollers-backing-attachment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267633] by Alan Coon
  • 8 edits
    2 adds in branches/safari-610-branch

Cherry-pick r266923. rdar://problem/69586712

REGRESSION (Async overflow scroll): Mouse wheel scrolling over an "always-on" overflow scrollbar doesn't work
https://bugs.webkit.org/show_bug.cgi?id=216381
<rdar://problem/68593743>

Reviewed by Antti Koivisto.

Source/WebCore:

The scrollbar and scroll corner layers need event regions and scrollingNodeIDs so that
we hit-test them via CA layers and find the right scrolling node.

Test: fast/scrolling/mac/mousewheel-over-scrollbar.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterDescendants): (WebCore::RenderLayerBacking::updateEventRegion): (WebCore::RenderLayerBacking::detachFromScrollingCoordinator): (WebCore::RenderLayerBacking::setScrollingNodeIDForRole):

LayoutTests:

  • fast/scrolling/mac/border-radius-event-region-expected.txt:
  • fast/scrolling/mac/event-region-scrolled-contents-layer-expected.txt:
  • fast/scrolling/mac/event-region-subscroller-overflow-expected.txt:
  • fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
  • fast/scrolling/mac/mousewheel-over-scrollbar-expected.txt: Added.
  • fast/scrolling/mac/mousewheel-over-scrollbar.html: Added.
  • fast/scrolling/mac/negative-z-index-overflow-scroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267632] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266899. rdar://problem/69586659

Address a post-commit review comment after r266887
https://bugs.webkit.org/show_bug.cgi?id=216257

Reviewed by Darin Adler.

Remove a check that currently makes us conditionally set IsComputedStyleInvalidFlag if there is a computed
style in rare data. There should be no change in behavior; this just makes the code a bit simpler.

  • dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::storeDisplayContentsStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267631] by Alan Coon
  • 4 edits
    2 adds in branches/safari-610-branch

Cherry-pick r266887. rdar://problem/69586659

REGRESSION (r257839): clickpay.com - password placeholder text cannot be replaced
https://bugs.webkit.org/show_bug.cgi?id=216257
<rdar://problem/68150686>

Reviewed by Antti Koivisto.

Source/WebCore:

On clickpay.com, the field in the login form that contains the text "Password" is actually a plain text input,
referred to by the site's script as the "null text input". The page adds a focus event listener to this null
text input, and inside of this focus event listener, it reveals a hidden password field by removing an inline
display: none; style rule on the real password input element, programmatically focuses it, and then hides the
null text input by setting it to display: none; via inline style.

However, after the changes in r257839, we no longer attempt to do a style update upon programmatic focus in the
case where the programmatically focused element does not have a renderer yet (this applies to the password field
in this scenario, because it previously had display: none;). When we determine whether the newly displayed
password field is focusable using Element::isVisibleWithoutResolvingFullStyle, we then attempt to use either
the existing computed RenderStyle on the element, or perform a partial computed style resolution using the
ResolveComputedStyleMode::RenderedOnly flag.

But in the case where ElementRareData's computed style exists, it is not guaranteed to be up to date if the
inline style changed since the computed style was last set. In the context of this bug, it's actually Safari's
AutoFill logic (embedded in the injected bundle) that ends up asking for the computed style of the password
input, forcing it to be created and set (though, as demonstrated in the layout test, simply grabbing the
computed style is sufficient to replicate the bug outside of Safari).

The end result is that we'll use this stale computed style, which still believes that the password input is not
displayed, and we end up not focusing the element due to believing that the password input is hidden. To fix
this, we would need to either check whether the element has an invalid style (i.e. needsStyleRecalc()) before
attempting to use the existing computed style, or clear out the ElementRareData computed style anytime the
element's style is invalidated. However, both of these approaches will cause us to perform partial style
resolution much more aggressively, leading to a 2-3% regression in Speedometer.

To address the bug without hampering our performance wins from r257839, we add a new node flag so that we can
remember when computed styles are no longer valid due to style invalidation, and consult this flag in
Element::isVisibleWithoutResolvingFullStyle to avoid using the existing computed style.

Test: fast/forms/programmatic-focus-after-display.html

  • dom/Element.cpp: (WebCore::Element::invalidateStyle): (WebCore::Element::resolveComputedStyle): (WebCore::Element::isVisibleWithoutResolvingFullStyle const):
  • dom/Node.h: (WebCore::Node::setHasValidStyle):

LayoutTests:

Add a new layout test to verify that the bug does not occur. See WebCore/ChangeLog for more details.

  • fast/forms/programmatic-focus-after-display-expected.txt: Added.
  • fast/forms/programmatic-focus-after-display.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267630] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266884. rdar://problem/69583178

Revert accidental hard-coding of compositing logging from r266825.

  • platform/Logging.cpp: (WebCore::initializeLogChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267629] by Alan Coon
  • 25 edits
    1 copy
    10 adds in branches/safari-610-branch

Cherry-pick r266825. rdar://problem/69583178

REGRESSION (Async overflow scroll): Truncated scrollbars in facebook chat
https://bugs.webkit.org/show_bug.cgi?id=216294
<rdar://problem/61918702>

Reviewed by Antti Koivisto.

Source/WebCore:

When both async overflow scroll and overlay scrollbars are enabled, it's possible for
composited layers that are later in z-order than the overflow to overlap the scrollbars
(overflow does not create stacking context, so they are later siblings to the overflow).

To fix this we have to hoist the layer that hosts the overflow controls above all later layers
which belong to contents scrolled by this overflow. We know which layers these are; they have
ancestor clippings stacks that reference the overflow layer.

This overflow controls layer hoisting happens in the context of the enclosing composited layer.

So to fix this RenderLayerCompositor::updateBackingAndHierarchy() tracks these layers that belong to
an overflow scroll. RenderLayerCompositor::adjustOverflowScrollbarContainerLayers() uses them to find
the overflow scroll layers whose controls need hoisting, and where to insert those overflow controls
hosting layers in the sublayers list of the enclosing composited layer.

An additional source of complexity occurs with overflow scroll nested inside another scroller or
overflow:hidden (in the same composited stacking context): the overflow controls reparenting is hoisting
that layer up, so that layer itself needs additional layers to clip it (essentially the overflow control
layer behaves like a later sibling that needs its own ancestor clipping stack). When this occurs,
RenderLayerBacking creates an additional "ancestor clipping stack" in m_overflowControlsHostLayerAncestorClippingStack
which is a parallel stack to m_ancestorClippingStack, but with its own set of clipping layers. At some point
this will also need scrolling tree nodes created for it. Some minor refactoring helps share code for
the two LayerAncestorClippingStacks.

This new code all runs late in the compositing update for a given layer, which is not ideal; we replicate
some code from updateGeometry() and updateInternalHierarchy(). Ideally we'd be able to know at
computeCompositingRequirements() time if we need to do layer hoisting and ancestor clipping stack duplication,
but that proves hard because of ordering dependencies.

Tests: compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html

compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html
compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html
compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html

  • rendering/LayerAncestorClippingStack.cpp: (WebCore::LayerAncestorClippingStack::compositedClipData const):
  • rendering/LayerAncestorClippingStack.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::RenderLayerBacking::updateGeometry): (WebCore::RenderLayerBacking::adjustOverflowControlsPositionRelativeToAncestor): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateAncestorClippingStack): (WebCore::RenderLayerBacking::ensureOverflowControlsHostLayerAncestorClippingStack): (WebCore::RenderLayerBacking::ensureClippingStackLayers): (WebCore::RenderLayerBacking::removeClippingStackLayers): (WebCore::RenderLayerBacking::connectClippingStackLayers): (WebCore::RenderLayerBacking::updateClippingStackLayerGeometry): (WebCore::RenderLayerBacking::updateAncestorClipping): (WebCore::RenderLayerBacking::offsetRelativeToRendererOriginForDescendantLayers const):
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::UpdateBackingTraversalState::UpdateBackingTraversalState): (WebCore::RenderLayerCompositor::UpdateBackingTraversalState::stateForDescendants const): (WebCore::RenderLayerCompositor::updateBackingAndHierarchy): (WebCore::RenderLayerCompositor::adjustOverflowScrollbarContainerLayers): (WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingProxyRole):
  • rendering/RenderLayerCompositor.h:

LayoutTests:

Some new tests, and new baselines for tests that have different layer trees now.

  • compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
  • compositing/layer-creation/clipping-scope/overlap-constrained-inside-scroller-expected.txt:
  • compositing/layer-creation/clipping-scope/scroller-with-negative-z-children-expected.txt:
  • compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
  • compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-clipped-by-scroll-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/clipped-layer-in-overflow-nested-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-for-negative-z-in-scroller-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-hidden-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-clip-to-visible-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-gain-clipping-layer-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-in-clipped-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/layer-in-overflow-lose-clipping-layer-expected.txt:
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-dynamic.html: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-inside-hidden.html: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar-nested.html: Added.
  • compositing/scrolling/async-overflow-scrolling/overlapped-overlay-scrollbar.html: Added.
  • compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/transform-change-scrollbar-position.html: Added.
  • compositing/shared-backing/overflow-scroll/composited-absolute-in-absolute-in-relative-in-scroller-expected.txt:
  • compositing/shared-backing/overflow-scroll/previous-sibling-prevents-inclusiveness-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267628] by Alan Coon
  • 16 edits in branches/safari-610-branch/Source/WebKit

Cherry-pick r266804. rdar://problem/69583164

macCatalyst: Form controls behave strangely (like iPhone) in macOS-idiom apps
https://bugs.webkit.org/show_bug.cgi?id=216326

Reviewed by Wenson Hsieh.

  • Shared/UserInterfaceIdiom.h:
  • Shared/UserInterfaceIdiom.mm: (WebKit::userInterfaceIdiomIsPad): (WebKit::currentUserInterfaceIdiomIsPadOrMac): (WebKit::setCurrentUserInterfaceIdiomIsPadOrMac): (WebKit::currentUserInterfaceIdiomIsPad): Deleted. (WebKit::setCurrentUserInterfaceIdiomIsPad): Deleted.
  • Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::defaultTextAutosizingUsesIdempotentMode):
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]):
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
  • UIProcess/ios/SmartMagnificationController.mm: (WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
  • UIProcess/ios/WKContentViewInteraction.mm: (-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): (-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]): (-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]): (-[WKContentView _zoomToRevealFocusedElement]): (-[WKContentView requiresAccessoryView]): (-[WKContentView _updateAccessory]): (shouldShowKeyboardForElement): (-[WKContentView _shouldUseLegacySelectPopoverDismissalBehavior]):
  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm: (WebKit::WebDataListSuggestionsDropdownIOS::show):
  • UIProcess/ios/WebPageProxyIOS.mm: (WebKit::desktopClassBrowsingSupported):
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm: (-[WKAirPlayRoutePicker show:fromRect:]):
  • UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _showPhotoPickerWithSourceType:]): (-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
  • UIProcess/ios/forms/WKFormColorControl.mm: (-[WKFormColorControl initWithView:]):
  • UIProcess/ios/forms/WKFormColorPicker.mm: (-[WKColorPicker initWithView:inPopover:]): (-[WKColorPicker drawSelectionIndicatorForColorButton:]):
  • UIProcess/ios/forms/WKFormSelectControl.mm: (-[WKFormSelectControl initWithView:]):
  • WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Rename currentUserInterfaceIdiomIsPad to currentUserInterfaceIdiomIsPadOrMac, and force it to YES on macCatalyst since internally we use it to distinguish between iPhone and iPad behavior, and (for our behaviors, at least) macCatalyst should always follow iPad.

We should clean this up, and make all callers make their
iPhone vs. iPad vs. macOS decisions more explicit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267627] by Alan Coon
  • 6 edits in branches/safari-610-branch

Cherry-pick r266798. rdar://problem/69583118

Make sure WKWebsiteDataStore operations reuse existing process pools even when all WKWebViews have closed.
<rdar://problem/62978295> and https://bugs.webkit.org/show_bug.cgi?id=216317

Reviewed by Geoffrey Garen.

Source/WebKit:

Covered by new API test.

When WebsiteDataStores are gathering all the NetworkProcesses they might need to message, they miss some
obvious candidates if there are no longer any related WKWebViews.

Fix that by tracking which sessions a NetworkProcess knows about.

  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::addSession): (WebKit::NetworkProcessProxy::hasSession const): (WebKit::NetworkProcessProxy::removeSession):
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::isAssociatedProcessPool const):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: (TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [267626] by Alan Coon
  • 5 edits
    3 adds in branches/safari-610-branch

Cherry-pick r266148. rdar://problem/69583151

Font loads quickly followed by navigations may fail indefinitely
<rdar://problem/65560550> and https://bugs.webkit.org/show_bug.cgi?id=215435

Reviewed by Myles C. Maxfield.

Source/WebCore:

Second take at this.

Myles took the first swipe at this, but a conflict with SuspendableTimer caused issues
in the form of layout test asserts with
http/tests/security/navigate-when-restoring-cached-page.html

His original ChangeLog entry:

Font loads are coalesced using a zero-delay timer. However, that zero-delay timer
can fire while the page is in the middle of a navigation, which will cause the font
loads to fail. Then, the second page can request those same fonts, which are marked
as failed, and as such will never actually load/use the desired web font.

This patch just stops the zero-delay timer during navigations, and resumes it
when resuming the document. This means:

  1. The second page in the above story will not see that the font has failed, or even started, and will then re-request the font and load it successfully
  2. If the user goes "back" to the previous page, the zero-delay timer is restarted, the CachedFont realizes it's already succeeded, and the previous page is rendered as expected.

Test: fast/loader/font-load-timer.html

---

Now the explanation of the failure it caused:
The font loading timer was a SuspendableTimer, which is an ActiveDOMObject.

An ActiveDOMObject was used to make sure the delayed font loads play well with the
page cache, which is still necessary.

But we also still need to suspend the timer manually when "stopLoading()" is called,
which doesn't play well with ActiveDOMObject's automatic suspend/resume.

My solution:

  • Make the timer "just a normal timer"
  • Make CSSFontSelector itself the ActiveDOMObject
  • Let DocumentLoader explicitly pause the font load timer
  • Rely on ActiveDOMObject to resume the timer

These keep the bug fixed and resolve the layout test ASSERT seen with
http/tests/security/navigate-when-restoring-cached-page.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::clearDocument): (WebCore::CSSFontSelector::beginLoadingFontSoon): (WebCore::CSSFontSelector::suspendFontLoadingTimer): (WebCore::CSSFontSelector::fontLoadingTimerFired): (WebCore::CSSFontSelector::stop): (WebCore::CSSFontSelector::suspend): (WebCore::CSSFontSelector::resume): (WebCore::CSSFontSelector::beginLoadTimerFired): Deleted.
  • css/CSSFontSelector.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):

LayoutTests:

1) The page has some content that has “font-family: WebFont” but there are no @font-face blocks on the page
2) In script, after the page has loaded, add an @font-face rule to the page with “font-family: WebFont” and some valid font URL
3) Synchronously, within the same turn of the run loop, trigger a synchronous layout of the element (using offsetWidth or something). This will add the font to the 0-delay time work list.
4) Synchronously, within the same turn of the run loop, navigate to a second page that doesn’t use the web font.
5) The second page waits some small-but-positive amount of time. This will cause the 0-delay timer to fire, but because the page is in the middle of navigating, the font load should fail.
6) The second page adds the same @font-face rule to itself using script. This should pull the same (failed) CachedResource object out of the memory cache.
7) Use the CSS Font Loading API to wait for the font load to complete
8) Make sure that the font is used on the second page (as a reference test). Today, the second page’s font load will fail because it pulled the failed font out of the memory cache. The test makes sure the second page’s font load succeeds.

  • fast/loader/font-load-timer-expected.html: Added.
  • fast/loader/font-load-timer.html: Added.
  • fast/loader/resources/font-load-timer-navigation-destination.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:45 PM Changeset in webkit [267625] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Big Sur clean build after r267613
https://bugs.webkit.org/show_bug.cgi?id=217003

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
1:43 PM WebKitGTK/2.30.x edited by Adrian Perez de Castro
(diff)
12:52 PM Changeset in webkit [267624] by ysuzuki@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed, follow-up after r267373 to resolve post-commit review comments
https://bugs.webkit.org/show_bug.cgi?id=216667

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):

  • runtime/HashMapImpl.h:

(JSC::jsMapHash):

9:34 AM Changeset in webkit [267623] by weinig@apple.com
  • 9 edits in trunk/Source/WebKitLegacy

[Preferences] It should be possible to have different default values for WebKitLegacy and WebKit in preference yaml files
https://bugs.webkit.org/show_bug.cgi?id=216987

Reviewed by Darin Adler.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Update script phase to explicitly specify the frontend (WebKitLegacy) and the templates to generate.

Source/WebKitLegacy/mac:

Add new syntax for default values that allows specializing based on both frontend (WebKit or
WebKitLegacy) and then futher based on platform macros. For example, the preference for
CSSTypedOMEnabled now looks like:

CSSTypedOMEnabled:

type: bool
humanReadableName: "CSS Typed OM"
humanReadableDescription: "Enable the CSS Typed OM"
webcoreBinding: RuntimeEnabledFeatures
condition: ENABLE(CSS_TYPED_OM)
defaultValue:

WebKitLegacy:

default: false

WebKit:

"ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK)
PLATFORM(WPE))": true

default: false

Which means that in WebKitLegacy, the default value is false, and in WebKit, the default
value will be:

#if ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK)
PLATFORM(WPE))

true

#else

false

#endif

As many platform macro based conditions can be provided as wanted, and they are evaluated
in the order specified in the file.

The syntax currently always requires explicitly specifying WebKitLegacy and WebKit and default
for each, even if they are all the same, but could be extended in the future to allow compaction
if that becomes desirable. There is also not yet support for conditionally enabling a feature
based on os-feature-flags or linked-on-or-after checks, so those still require specifying the
default value as a function, but that seems like a nice future improvement.

As this is still staging for doing this for both WebKitLegacy and WebKit, this change only effects
WebKitLegacy for now, and subsequent changes will move this to a shared location.

  • Scripts/GeneratePreferences.rb:
  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb:
  • Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb:
  • WebView/WebPreferencesExperimental.yaml:
7:14 AM Changeset in webkit [267622] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Line content logical width expands with run expansions (text-align: justify)
https://bugs.webkit.org/show_bug.cgi?id=217011

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/run-expansion-extends-line-content-width.html

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::applyRunExpansion):

LayoutTests:

  • fast/layoutformattingcontext/run-expansion-extends-line-content-width-expected.html: Added.
  • fast/layoutformattingcontext/run-expansion-extends-line-content-width.html: Added.
6:52 AM Changeset in webkit [267621] by Carlos Garcia Campos
  • 4 edits in trunk/Source

[SOUP] Do not set site for cookies twice in case of redirection
https://bugs.webkit.org/show_bug.cgi?id=217010

Reviewed by Michael Catanzaro.

Source/WebCore:

Only set is-toplevel-navigation on SoupMessage when same site info is present.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers const):

Source/WebKit:

ResourceRequest::updateSoupMessage() already fills the same site information, but we are duplicating the code in
NetworkDataTaskSoup::continueHTTPRedirection().

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Do not set same site information here, it will be done
again in NetworkDataTaskSoup::createRequest().

6:51 AM Changeset in webkit [267620] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
https://bugs.webkit.org/show_bug.cgi?id=149551

Reviewed by Michael Catanzaro.

The problem is that we are not including all the cookies in the web socket request. There are two cookies with
the Lax same-site policy set, that are not included for the websocket request.

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.

Sep 25, 2020:

11:48 PM Changeset in webkit [267619] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Add -[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:] to provide a way to allow app link
https://bugs.webkit.org/show_bug.cgi?id=216977

Patch by Hoa Dinh <dvh@apple.com> on 2020-09-25
Reviewed by Alex Christensen.

The method -[WKWebView _loadRequest:shouldOpenExternalURLs:] would only allow opening external or not.
It wasn't providing the ability to allow external URL but not app links.
This patch adds -[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:]. The parameters value for
shouldOpenExternalURLsPolicy has the same meaning than WebCore::ShouldOpenExternalURLsPolicy.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _loadRequest:shouldOpenExternalURLsPolicy:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Added enum _WKShouldOpenExternalURLsPolicy,
11:39 PM Changeset in webkit [267618] by achristensen@apple.com
  • 87 edits in trunk

Unreviewed, reverting r267608.

Caused API test failures

Reverted changeset:

"Move NetworkProcessProxy ownership from WebProcessPool to
WebsiteDataStore"
https://bugs.webkit.org/show_bug.cgi?id=216041
https://trac.webkit.org/changeset/267608

10:21 PM Changeset in webkit [267617] by Alan Bujtas
  • 4 edits
    2 adds in trunk

[LFC][IFC] Incorrect breaking position when inline box content fits the line but the inline content itself does not.
https://bugs.webkit.org/show_bug.cgi?id=217007

Reviewed by Simon Fraser.

Source/WebCore:

When the inline box does not fit the line but its text content does, the last breaking opportunity (in case of arbitrary breaking position)
is not the end of the text.
e.g
<div style="width: 200px; word-break: break-word;"><span style="border-right: 100px;">text_content_fits</span></div>
in this case the border right overflows the containing block and should be wrapped to the next available vertical position.
However the last breaking opportunity is not between 's' and the </span> but between 't' and 's'.

Test: fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html

  • layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::tryBreakingTextRun const):

  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): [container start](<span>) and [container end](</span>) runs are not collapsible.

LayoutTests:

  • fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not-expected.html: Added.
  • fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html: Added.
7:44 PM Changeset in webkit [267616] by wenson_hsieh@apple.com
  • 11 edits in trunk

[GPU Process] fast/canvas/canvas-composite-canvas.html and fast/canvas/canvas-composite-image.html fail
https://bugs.webkit.org/show_bug.cgi?id=216982

Reviewed by Simon Fraser.

Source/WebCore:

When painting into display-list-backed image buffers with remote IOSurface-backed image buffers in the GPU
process, the display-list-backed image buffer has an initial CTM of the identity matrix, while the IOSurface-
backed image buffer's initial CTM is flipped about the x-axis. This is because image buffer backends based on
CoreGraphics always flip their context about the x-axis upon creation, in ImageBufferCGBackend::setupContext().
This causes the CTM of the DisplayList context in the web process to fall out of sync with the CTM of the
platform context in the GPU process, so any canvas rendering codepaths that attempt to consult the current CTM
in the web process (e.g. CanvasRenderingContext2DBase::fullCanvasCompositedDrawImage) will get an incorrect
value.

To fix this, we give the display-list-backed image buffer in the web process an initial CTM that matches the CTM
of the native image buffer in the GPU process; see below for more details.

Tests: fast/canvas/canvas-composite-canvas.html and fast/canvas/canvas-composite-image.html

  • platform/graphics/ImageBufferBackend.h:
  • platform/graphics/cg/ImageBufferCGBitmapBackend.h:

Add a flag indicating whether the origin (0, 0) is intended to be at the top left corner of the image, in which
case we set up the image buffer's graphics context by flipping it vertically about the x-axis. This is true on
CoreGraphics-backed image buffers.

  • platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
  • platform/graphics/displaylists/DisplayListDrawingContext.cpp:

(WebCore::DisplayList::DrawingContext::DrawingContext):

  • platform/graphics/displaylists/DisplayListDrawingContext.h:

(WebCore::DisplayList::DrawingContext::DrawingContext):

Add an additional argument to the constructor of DrawingContext, so that it now takes an initial affine CTM.
By default, this is the identity matrix.

  • platform/graphics/displaylists/DisplayListImageBuffer.h:

(WebCore::DisplayList::ImageBuffer::ImageBuffer):
(WebCore::DisplayList::ImageBuffer::initialDrawingContextCTM):

Add a helper to compute the initial CTM of the drawing context. This was previously only the identity matrix,
but if we're using an image buffer backend that will flip the context vertically, then we need to start the
CTM of the display-list-backed image buffer in the same state.

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):

Rename the baseCTM argument to initialCTM. This is because this argument determines the CTM of the initial
graphics context state in the state stack, rather than the value of the base CTM. See above for more details.

  • platform/graphics/transforms/AffineTransform.h:

LayoutTests:

Rebaseline this display list test to account for the fact that display list extent rects are in the global
coordinate space, and are therefore vertically flipped since the initial CTM flips everything about the x-axis.

  • displaylists/canvas-display-list-expected.txt:
6:42 PM Changeset in webkit [267615] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk/Source/WebCore

Move SerializationState from ImageBuffer to ImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=216565

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-25
Reviewed by Kenneth Russell.

Introduce ImageBitmapBacking and make it a member of ImageBitmap. It
represents the backing store of an ImageBitmap. Currently it encapsulates
an ImageBuffer and the new enum SerializationState. In the future, it can
be extended to encapsulate either a texture or an ImageBuffer.

  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTransferredImageBitmap):
(WebCore::CloneDeserializer::readImageBitmap):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::computeMemoryCost const):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:

(WebCore::SerializedScriptValue::SerializedScriptValue):

  • html/ImageBitmap.cpp:

(WebCore::ImageBitmap::create):
(WebCore::ImageBitmap::detachBitmaps):
(WebCore::ImageBitmap::resolveWithBlankImageBuffer):
(WebCore::ImageBitmap::createPromise):
(WebCore::ImageBitmap::createFromBuffer):
(WebCore::ImageBitmap::ImageBitmap):
(WebCore::ImageBitmap::takeImageBitmapBacking):
(WebCore::ImageBitmap::takeImageBuffer):
(WebCore::ImageBitmap::width const): Deleted.
(WebCore::ImageBitmap::height const): Deleted.
(WebCore::ImageBitmap::close): Deleted.
(WebCore::ImageBitmap::transferOwnershipAndClose): Deleted.

  • html/ImageBitmap.h:
  • html/ImageBitmapBacking.cpp: Added.

(WebCore::ImageBitmapBacking::ImageBitmapBacking):
(WebCore::ImageBitmapBacking::buffer const):
(WebCore::ImageBitmapBacking::takeImageBuffer):
(WebCore::ImageBitmapBacking::width const):
(WebCore::ImageBitmapBacking::height const):

  • html/ImageBitmapBacking.h: Added.

(WebCore::ImageBitmapBacking::originClean const):
(WebCore::ImageBitmapBacking::premultiplyAlpha const):
(WebCore::ImageBitmapBacking::forciblyPremultiplyAlpha const):
(WebCore::ImageBitmapBacking::serializationState const):

  • html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::transferToImageBitmap):

  • html/canvas/ImageBitmapRenderingContext.cpp:

(WebCore::ImageBitmapRenderingContext::setOutputBitmap):

  • platform/graphics/ImageBuffer.h:

(): Deleted.

5:50 PM Changeset in webkit [267614] by Chris Dumez
  • 9 edits
    32 adds in trunk

visibilitychange:hidden doesn't fire during page navigations
https://bugs.webkit.org/show_bug.cgi?id=151234
<rdar://problem/23688763>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Import page-visibility WPT tests from upstream.

  • resources/import-expectations.json:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt:
  • web-platform-tests/page-visibility/*: Added.

Source/WebCore:

Fire a visibilitychange during document unload, as per the specification:

Note that the specification currently says to fire the visibilitychange event before the pagehide event.
However, Both Chrome and Firefox fire the pagehide event then the visibilitychange event. This change
aligns our behavior with both Chrome and Firefox. The following bug has been filed against the
specification:

We also fire a visibilitychange event when coming out of the back/forward cache. This makes sense given
that we fire one when the document enters the back/forward cache. This is also Firefox's behavior.
I have verified that the new fast/history/back-forward-cache-visibility-state.html layout test is passing
in Firefox.

Tests: fast/history/back-forward-cache-visibility-state.html

imported/w3c/web-platform-tests/page-visibility/idlharness.window.html
imported/w3c/web-platform-tests/page-visibility/iframe-unload.html
imported/w3c/web-platform-tests/page-visibility/onvisibilitychange.html
imported/w3c/web-platform-tests/page-visibility/test_attributes_exist.html
imported/w3c/web-platform-tests/page-visibility/test_child_document.html
imported/w3c/web-platform-tests/page-visibility/test_default_view.html
imported/w3c/web-platform-tests/page-visibility/test_read_only.html
imported/w3c/web-platform-tests/page-visibility/unload-bubbles.html
imported/w3c/web-platform-tests/page-visibility/unload.html

  • dom/Document.cpp:

(WebCore::Document::visibilityState const):
(WebCore::Document::setHiddenDueToDismissal):

  • dom/Document.h:
  • history/CachedPage.cpp:

(WebCore::firePageShowAndPopStateEvents):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):

LayoutTests:

Add test coverage for the visibilitychange event and document.visibilitystate when entering
and coming out of the back/forward cache.

  • fast/history/back-forward-cache-visibility-state-expected.txt: Added.
  • fast/history/back-forward-cache-visibility-state.html: Added.
5:41 PM Changeset in webkit [267613] by James Darpinian
  • 11 edits
    6 adds in trunk

Support OES_fbo_render_mipmap
https://bugs.webkit.org/show_bug.cgi?id=217003

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/oes-fbo-render-mipmap.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

  • html/canvas/OESFBORenderMipmap.cpp: Added.

(WebCore::OESFBORenderMipmap::OESFBORenderMipmap):
(WebCore::OESFBORenderMipmap::getName const):
(WebCore::OESFBORenderMipmap::supported):

  • html/canvas/OESFBORenderMipmap.h: Added.
  • html/canvas/OESFBORenderMipmap.idl: Added.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::framebufferTexture2D):
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):

  • html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

  • webgl/conformance/extensions/oes-fbo-render-mipmap-expected.txt: Added.
  • webgl/conformance/extensions/oes-fbo-render-mipmap.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-fbo-render-mipmap.html: Added.
5:27 PM Changeset in webkit [267612] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Crunchyroll playback controls do not work on iPad with trackpad
https://bugs.webkit.org/show_bug.cgi?id=217000
<rdar://problem/66362029>

Reviewed by Wenson Hsieh.

Source/WebCore:

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isCrunchyroll):

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(applicationIsKnownToIgnoreMouseEvents):
Add it to the list.

5:14 PM Changeset in webkit [267611] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Make renderingUpdateScheduler() internal to Page
https://bugs.webkit.org/show_bug.cgi?id=216993

Reviewed by Said Abou-Hallawa.

renderingUpdateScheduler() should be an implementation detail of Page.

Also add some explanatory comments.

  • dom/Document.cpp:

(WebCore::Document::scheduleTimedRenderingUpdate):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::scheduleAnimation):

  • page/Page.cpp:

(WebCore::Page::scheduleImmediateRenderingUpdate):

  • page/Page.h:
  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::didChangeViewExposedRect):
(WebCore::PageOverlayController::notifyFlushRequired):

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::notifyFlushRequired):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerTreeAsText):

5:09 PM Changeset in webkit [267610] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Unreviewed, update xcfilelist files.

  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
5:01 PM Changeset in webkit [267609] by Chris Dumez
  • 22 edits in trunk/Source/WebCore

Avoid having to call context.lazyInitialize() in every AudioNode factory function
https://bugs.webkit.org/show_bug.cgi?id=216989

Reviewed by Darin Adler.

Avoid having to call context.lazyInitialize() in every AudioNode factory function.
Replace all these calls with a single one inside the AudioNode constructor.

No new tests, no Web facing behavior change.

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):

  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::lazyInitialize):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):

  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::create):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::create):

  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::create):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::create):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::create):

  • Modules/webaudio/IIRFilterNode.cpp:

(WebCore::IIRFilterNode::create):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::create):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::create):

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::create):

  • Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::create):

  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::create):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::create):

4:53 PM Changeset in webkit [267608] by achristensen@apple.com
  • 87 edits in trunk

Move NetworkProcessProxy ownership from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=216041

Reviewed by Brady Eidson.

Source/WebKit:

This patch moves the things on WebProcessPool associated with NetworkProcessProxy ownership and moves them
to WebsiteDataStore. It's pretty mechanical, but it reaches its fingers into a lot of things. Some comments
on interesting parts are below.

Why am I doing this? I'm glad you asked.

WKWebView had a fundamental cookie problem before this change. It had a WKWebsiteDataStore that could point to a cookie store on disk
that could be used in multiple network processes at the same time. This led to problems with cookies being received over the network
in those different processes being unable to be shared until they were written to disk, something that does not happen immediately, especially
on iOS. This problem is even worse with session cookies, which should be kept in memory and never be written to disk. Those processes
did not use shared memory to share the cookies. They just didn't share them, which led to cookie incorrectness. This was unfortunately
the default configuration if you call [[WKWebView alloc] init] more than once, which many developers do. There was also occasional cookie
corruption and loss from multiple processes writing cookies to the same file. All these problems can be worked around by doing what Safari does:
manually setting the WKProcessPool of all WKWebViewConfigurations to the same process pool to only use one network process. This is not intuitive
or well documented, and even though I have spent the majority of WWDC labs for the last 3 years telling developers to do it, most developers do not.
The default behavior should not lead to cookie incorrectness, corruption, or loss. This accomplishes that.

A bigger problem that can't really be worked around well is what we were doing in our WKHTTPCookieStore API. Many developers call setCookie:completionHandler:
to "log in" the user by setting a cookie, then in the completion handler, they open a WKWebView to their page and expect the cookie to be sent. Before this
change, we would not know which process pool to set the cookie in so we would guess. If there were no process pools, we would start writing to disk and hope
it writes fast enough. We can't wait for it to complete because it causes hangs like rdar://problem/66961066. This solution allows to start the network
process of that WebsiteDataStore and set the cookie in that process. We now know that is the only process this WebsiteDataStore will ever use. Now, users
will be able to actually be logged in all the time in such apps.

  • NetworkProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):

  • NetworkProcess/Cookies/WebCookieManager.h:
  • NetworkProcess/Cookies/WebCookieManager.messages.in:
  • NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

  • NetworkProcess/Cookies/mac/WebCookieManagerMac.mm:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

  • NetworkProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensureSession):
(WebKit::NetworkProcess::storageSession const):
(WebKit::NetworkProcess::forEachNetworkStorageSession):
(WebKit::NetworkProcess::defaultStorageSession const): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/WebStorage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::close):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::saveCookies):
(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.

  • NetworkProcess/curl/NetworkProcessCurl.cpp:

(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformCreateDefaultStorageSession const): Deleted.

  • Platform/IPC/Attachment.h:
  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):

  • Shared/WebsiteDataStoreParameters.h:
  • UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::cookiesForURL):
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::deleteAllCookies):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications): Deleted.
(API::HTTPCookieStore::unregisterForNewProcessPoolNotifications): Deleted.

  • UIProcess/API/APIHTTPCookieStore.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetUseSeparateServiceWorkerProcess):
(WKContextSetPrimaryWebsiteDataStore):
(WKContextGetCookieManager): Deleted.
(WKContextSetAllowsAnySSLCertificateForServiceWorkerTesting): Deleted.
(WKContextTerminateNetworkProcess): Deleted.
(WKContextGetNetworkProcessIdentifier): Deleted.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetWebsiteDataStore):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreTerminateNetworkProcess):
(WKWebsiteDataStoreGetNetworkProcessIdentifier):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setUseSeparateServiceWorkerProcess:]):
(-[WKProcessPool _terminateNetworkProcess]): Deleted.
(-[WKProcessPool _sendNetworkProcessWillSuspendImminently]): Deleted.
(-[WKProcessPool _sendNetworkProcessPrepareToSuspend:]): Deleted.
(-[WKProcessPool _sendNetworkProcessDidResume]): Deleted.
(-[WKProcessPool _networkProcessIdentifier]): Deleted.
(-[WKProcessPool _makeNextNetworkProcessLaunchFailForTesting]): Deleted.
(-[WKProcessPool _synthesizeAppIsBackground:]): Deleted.
(-[WKProcessPool _setAllowsAnySSLCertificateForServiceWorker:]): Deleted.
(-[WKProcessPool _networkProcessHasEntitlementForTesting:]): Deleted.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _networkProcessHasEntitlementForTesting:]):
(-[WKWebsiteDataStore _terminateNetworkProcess]):
(-[WKWebsiteDataStore _sendNetworkProcessPrepareToSuspend:]):
(-[WKWebsiteDataStore _sendNetworkProcessWillSuspendImminently]):
(-[WKWebsiteDataStore _sendNetworkProcessDidResume]):
(-[WKWebsiteDataStore _synthesizeAppIsBackground:]):
(-[WKWebsiteDataStore _networkProcessIdentifier]):
(+[WKWebsiteDataStore _makeNextNetworkProcessLaunchFailForTesting]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/API/glib/WebKitCookieManager.cpp:

(_WebKitCookieManagerPrivate::cookieManager const):
(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_add_cookie):
(webkit_cookie_manager_get_cookies):
(webkit_cookie_manager_delete_cookie):

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkit_web_context_prefetch_dns):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

  • UIProcess/AuxiliaryProcessProxy.h:
  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::updateProcessSuppressionState):
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting): Deleted.
(WebKit::WebProcessPool::xpcEndpointMessage const): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessXPCEndpointToWebProcess): Deleted.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::cancel):
(WebKit::DownloadProxy::publishProgress):
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::applicationDidEnterBackground):
(WebKit::DownloadProxyMap::applicationWillEnterForeground):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::invalidate):

  • UIProcess/Downloads/DownloadProxyMap.h:
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:

(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::invalidate):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::allNetworkProcesses):
(WebKit::defaultProcess):
(WebKit::NetworkProcessProxy::defaultNetworkProcess):
(WebKit::NetworkProcessProxy::terminate):
(WebKit::NetworkProcessProxy::didTerminate):
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
(WebKit::anyProcessPoolAlwaysRunsAtBackgroundPriority):
(WebKit::anyProcessPoolShouldTakeUIBackgroundAssertion):
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::networkProcessCrashed):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
(WebKit::NetworkProcessProxy::didFinishLaunching):
(WebKit::NetworkProcessProxy::setDomainsWithUserInteraction):
(WebKit::NetworkProcessProxy::addSession):
(WebKit::NetworkProcessProxy::removeSession):
(WebKit::NetworkProcessProxy::websiteDataStoreFromSessionID):
(WebKit::NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess):
(WebKit::anyProcessPoolHasForegroundWebProcesses):
(WebKit::anyProcessPoolHasBackgroundWebProcesses):
(WebKit::NetworkProcessProxy::updateProcessAssertion):
(WebKit::NetworkProcessProxy::hasSession const): Deleted.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxyCocoa.mm:

(WebKit::NetworkProcessProxy::XPCEventHandler::handleXPCEvent const):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostnames):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::supplementName): Deleted.
(WebKit::WebCookieManagerProxy::create): Deleted.
(WebKit::WebCookieManagerProxy::processPoolDestroyed): Deleted.
(WebKit::WebCookieManagerProxy::processDidClose): Deleted.
(WebKit::WebCookieManagerProxy::refWebContextSupplement): Deleted.
(WebKit::WebCookieManagerProxy::derefWebContextSupplement): Deleted.

  • UIProcess/WebCookieManagerProxy.h:

(WebKit::WebCookieManagerProxy::create):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setControlledByAutomation):
(WebKit::WebPageProxy::disableServiceWorkerEntitlementInNetworkProcess):
(WebKit::WebPageProxy::clearServiceWorkerEntitlementOverride):
(WebKit::WebPageProxy::preconnectTo):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::logFrameNavigation):
(WebKit::WebPageProxy::dumpAdClickAttribution):
(WebKit::WebPageProxy::clearAdClickAttribution):
(WebKit::WebPageProxy::setAdClickAttributionOverrideTimerForTesting):
(WebKit::WebPageProxy::setAdClickAttributionConversionURLForTesting):
(WebKit::WebPageProxy::markAdClickAttributionsAsExpiredForTesting):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::urlSchemesWithCustomProtocolHandlers):
(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::languageChanged):
(WebKit::WebProcessPool::sendMemoryPressureEvent):
(WebKit::WebProcessPool::networkProcessCrashed):
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::removeFromServiceWorkerProcesses):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::updateServiceWorkerUserAgent):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::registerURLSchemeAsSecure):
(WebKit::WebProcessPool::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit::WebProcessPool::registerURLSchemeAsLocal):
(WebKit::WebProcessPool::registerURLSchemeAsNoAccess):
(WebKit::WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebProcessPool::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
(WebKit::WebProcessPool::setCacheModel):
(WebKit::WebProcessPool::setCacheModelSynchronouslyForTesting):
(WebKit::WebProcessPool::createDownloadProxy):
(WebKit::WebProcessPool::terminateServiceWorkers):
(WebKit::WebProcessPool::serviceWorkerProcesses):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::isServiceWorkerPageID const):
(WebKit::WebProcessPool::setUseSeparateServiceWorkerProcess):
(WebKit::WebProcessPool::hasServiceWorkerForegroundActivityForTesting const):
(WebKit::WebProcessPool::hasServiceWorkerBackgroundActivityForTesting const):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient): Deleted.
(WebKit::WebProcessPool::networkingProcessConnection): Deleted.
(WebKit::WebProcessPool::ensureNetworkProcess): Deleted.
There seems to be a lot of code removal here, but most of it was duplicate code with
WebsiteDataStore::parameters which is used instead. That which was not duplicate was
moved to NetworkProcessProxy::sendCreationParametersToNewProcess. This was the hardest part of this patch.
(WebKit::WebProcessPool::getNetworkProcessConnection): Deleted.
(WebKit::WebProcessPool::networkProcessIdentifier): Deleted.
(WebKit::WebProcessPool::synthesizeAppIsBackground): Deleted.
(WebKit::WebProcessPool::sendSyncToNetworkingProcess): Deleted.
(WebKit::WebProcessPool::clearCachedCredentials): Deleted.
(WebKit::WebProcessPool::terminateNetworkProcess): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessPrepareToSuspendForTesting): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessWillSuspendImminentlyForTesting): Deleted.
(WebKit::WebProcessPool::sendNetworkProcessDidResume): Deleted.
(WebKit::WebProcessPool::flushCookies): Deleted.
(WebKit::WebProcessPool::didCommitCrossSiteLoadWithDataTransfer): Deleted.

  • UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToNetworkingProcess): Deleted.
(WebKit::WebProcessPool::sendToNetworkingProcessRelaunchingIfNecessary): Deleted.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::getNetworkProcessConnection):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToWebProcess):
(WebKit::WebsiteDataStore::sendNetworkProcessXPCEndpointToAllWebProcesses):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::forEachWebsiteDataStore):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::registerWithSessionIDMap):
(WebKit::WebsiteDataStore::existingDataStoreForSessionID):
(WebKit::WebsiteDataStore::networkProcess):
(WebKit::WebsiteDataStore::networkProcess const):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::resetServiceWorkerTimeoutForTesting):
(WebKit::WebsiteDataStore::setMaxStatisticsEntries):
(WebKit::WebsiteDataStore::setPruneEntriesDownTo):
(WebKit::WebsiteDataStore::setGrandfatheringTime):
(WebKit::WebsiteDataStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebsiteDataStore::dumpResourceLoadStatistics):
(WebKit::WebsiteDataStore::isPrevalentResource):
(WebKit::WebsiteDataStore::isGrandfathered):
(WebKit::WebsiteDataStore::setPrevalentResource):
(WebKit::WebsiteDataStore::setPrevalentResourceForDebugMode):
(WebKit::WebsiteDataStore::isVeryPrevalentResource):
(WebKit::WebsiteDataStore::setVeryPrevalentResource):
(WebKit::WebsiteDataStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebsiteDataStore::setSubframeUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubFrameUnder):
(WebKit::WebsiteDataStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebsiteDataStore::isRegisteredAsSubresourceUnder):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectTo):
(WebKit::WebsiteDataStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectTo):
(WebKit::WebsiteDataStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebsiteDataStore::isRegisteredAsRedirectingTo):
(WebKit::WebsiteDataStore::clearPrevalentResource):
(WebKit::WebsiteDataStore::resetParametersToDefaultValues):
(WebKit::WebsiteDataStore::submitTelemetry):
(WebKit::WebsiteDataStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebsiteDataStore::getResourceLoadStatisticsDataSummary):
(WebKit::WebsiteDataStore::scheduleCookieBlockingUpdate):
(WebKit::WebsiteDataStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebsiteDataStore::statisticsDatabaseHasAllTables):
(WebKit::WebsiteDataStore::setLastSeen):
(WebKit::WebsiteDataStore::domainIDExistsInDatabase):
(WebKit::WebsiteDataStore::mergeStatisticForTesting):
(WebKit::WebsiteDataStore::insertExpiredStatisticForTesting):
(WebKit::WebsiteDataStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebsiteDataStore::setIsRunningResourceLoadStatisticsTest):
(WebKit::WebsiteDataStore::getAllStorageAccessEntries):
(WebKit::WebsiteDataStore::setTimeToLiveUserInteraction):
(WebKit::WebsiteDataStore::logUserInteraction):
(WebKit::WebsiteDataStore::hasHadUserInteraction):
(WebKit::WebsiteDataStore::isRelationshipOnlyInDatabaseOnce):
(WebKit::WebsiteDataStore::clearUserInteraction):
(WebKit::WebsiteDataStore::setGrandfathered):
(WebKit::WebsiteDataStore::setUseITPDatabase):
(WebKit::WebsiteDataStore::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::resetCrossSiteLoadsWithLinkDecorationForTesting):
(WebKit::WebsiteDataStore::deleteCookiesForTesting):
(WebKit::WebsiteDataStore::hasLocalStorageForTesting const):
(WebKit::WebsiteDataStore::hasIsolatedSessionForTesting const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldDowngradeReferrerForTesting):
(WebKit::WebsiteDataStore::setThirdPartyCookieBlockingMode):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsShouldEnbleSameSiteStrictEnforcementForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsToSameSiteStrictCookiesForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyHostCNAMEDomainForTesting):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsThirdPartyCNAMEDomainForTesting):
(WebKit::WebsiteDataStore::syncLocalStorage):
(WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources):
(WebKit::WebsiteDataStore::processPools const):
(WebKit::WebsiteDataStore::allowSpecificHTTPSCertificateForHost):
(WebKit::WebsiteDataStore::getNetworkProcessConnection):
(WebKit::WebsiteDataStore::networkProcessCrashed):
(WebKit::WebsiteDataStore::terminateNetworkProcess):
(WebKit::WebsiteDataStore::sendNetworkProcessPrepareToSuspendForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessWillSuspendImminentlyForTesting):
(WebKit::WebsiteDataStore::sendNetworkProcessDidResume):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::setStatisticsTestingCallback):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebsiteDataStore::isResourceLoadStatisticsEphemeral const):
(WebKit::WebsiteDataStore::setAdClickAttributionDebugMode):
(WebKit::WebsiteDataStore::flushCookies):
(WebKit::WebsiteDataStore::setAllowsAnySSLCertificateForWebSocket):
(WebKit::WebsiteDataStore::clearCachedCredentials):
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::getLocalStorageDetails):
(WebKit::WebsiteDataStore::resetQuota):
(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):
(WebKit::WebsiteDataStore::renameOriginInWebsiteData):
(WebKit::WebsiteDataStore::hasAppBoundSession const):
(WebKit::WebsiteDataStore::clearAppBoundSession):
(WebKit::WebsiteDataStore::forwardAppBoundDomainsToITPIfInitialized):
(WebKit::WebsiteDataStore::setAppBoundDomainsForITP):
(WebKit::WebsiteDataStore::updateBundleIdentifierInNetworkProcess):
(WebKit::WebsiteDataStore::clearBundleIdentifierInNetworkProcess):
(WebKit::WebsiteDataStore::makeNextNetworkProcessLaunchFailForTesting):
(WebKit::WebsiteDataStore::shouldMakeNextNetworkProcessLaunchFailForTesting):
(WebKit::WebsiteDataStore::maybeRegisterWithSessionIDMap): Deleted.
(WebKit::WebsiteDataStore::existingNonDefaultDataStoreForSessionID): Deleted.
(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations): Deleted.
(WebKit::WebsiteDataStore::isAssociatedProcessPool const): Deleted.
(WebKit::WebsiteDataStore::pendingCookies const): Deleted.
(WebKit::WebsiteDataStore::addPendingCookie): Deleted.
(WebKit::WebsiteDataStore::removePendingCookie): Deleted.
(WebKit::WebsiteDataStore::clearPendingCookies): Deleted.
(WebKit::WebsiteDataStore::didCreateNetworkProcess): Deleted.

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp:

(WebKit::WebsiteDataStore::setNetworkProxySettings):

  • UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setPersistentCredentialStorageEnabled):

  • UIProcess/glib/WebProcessProxyGLib.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setIgnoreTLSErrors):
(WebKit::WebProcessPool::setNetworkProxySettings):

  • WebProcess/Network/NetworkProcessConnectionInfo.h:

Tools:

Most changes to tests are just calling a function on the WKWebsiteDataStore instead of the WKProcessPool
because we want to do something with the network process and it has a new owner.
Exceptions are noted inline.

  • TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TestWebKitAPI::downloadAtRate):

  • TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:

(checkRecoveryAfterCrash):

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):
This test was making a WKWebsiteDataStore, getting its resource load statistics directory,
putting things in that directory, then starting the network process and making sure everything
works when initializing the network process. Now, network process initialization happens when a
WKWebsiteDataStore is instantiated, so we need to put things there before instantiating a WKWebsiteDataStore.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Before this change, each WKProcessPool had its own network process, which holds the service worker registry
for the WebsiteDataStores used with that process pool. Now, the network process still needs to have a service
worker registry in it, but when we receive a message from it looking for a web process to run the service
worker, we go arbitrarily to the first process pool that has a process we can use. This logic is in
WebProcessPool::establishWorkerContextConnectionToNetworkProcess. Because we use the first process pool each
time, setting the custom user agent to two different things in two different process pools causes only one
to be used. This is not a problem in practice, though, because the only application that uses the SPI to
set a service worker's custom user agent is Safari, which only has one process pool. This test still verifies
that a user ageint is correctly sent.
Similarly, the tests that count service worker processes either have different results or need to be run with
one process pool per parent process. To keep the results the same, I separated the tests into different
TEST(ServiceWorkers, ...) macros which are run in separate parent processes.
The test RestoreFromDiskNonDefaultStore needs to use the same data store for both WKWebViews now because otherwise
there was a race condition in the startup of a new network process that wasn't there before because we were using the
same process pool and therefore the same network process. I added spinning the run loop and sleeping to be able to
reproduce the race condition failure and I use the same WKWebsiteDataStore to use the same network process, which was
the intent of using the same WKProcessPool before. The test still tests that the registration is re-used when we are
not using the default data store.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

(-[CheckSessionCookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[CheckSessionCookieUIDelegate waitForMessage]):
(-[CheckSessionCookieUIDelegate alertCookieHTML]):
(TEST):
This is the whole point of me doing this.
I took a test that was flaky only on iOS (because of different NSHTTPCookieStorage syncing behavior) and made
it flaky nowhere (fingers crossed!) and added a test that correctly handles session cookies like we could not
before this change.
I also re-used some test infrastructure and made it stop using process-global static variables for test state.

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(runWebsiteDataStoreCustomPaths):
(TEST):

  • TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:

(-[CloseWhileStartingProtocol startLoading]):
(TestWebKitAPI::runTest):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::findAndDumpWebKitProcessIdentifiers):
(WTR::TestController::networkProcessDidCrash):
(WTR::TestController::terminateNetworkProcess):
(WTR::TestController::platformAdjustContext):
WKContextSetAllowsAnySSLCertificateForServiceWorkerTesting is not needed, so I removed it.
WKContextSetPrimaryWebsiteDataStore isn't needed any more because WKContextRef (WebProcessPool) doesn't
own a network process any more, so it doesn't care which is the default WebsiteDataStore.
In fact, the "default" WebsiteDataStore isn't really important in the network process any more.

4:53 PM Changeset in webkit [267607] by Karl Rackler
  • 2 edits in trunk/LayoutTests

REGRESSION (r266932): [ Catalina wk2 ] fast/scrolling/latching/latched-scroll-into-nonfast-region.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217001

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:20 PM Changeset in webkit [267606] by Chris Dumez
  • 2 edits
    5 deletes in trunk/LayoutTests

REGRESSION(267504): [ macOS ] webaudio/silence-after-playback.html results missing
https://bugs.webkit.org/show_bug.cgi?id=216983
<rdar://problem/69582243>

Reviewed by Eric Carlson.

Drop outdated test which no longer makes sense now that the webkit-prefixed WebAudio API has
been disabled. The WebKit-prefixed API used to allow calling createMediaElementSource() on
an OfflineAudioContext. The test was checking that we were outputting silence after the
media element has finished playing, if the OfflineAudioContext buffer length is longer than
the media duration. However, as per the specification, createMediaElementSource() is only
exposed on AudioContext (which does not have an underlying buffer), not on
OfflineAudioContext:

  • platform/gtk/webaudio/silence-after-playback-expected.wav: Removed.
  • platform/mac-mojave/webaudio/silence-after-playback-expected.wav: Removed.
  • platform/mac/webaudio/silence-after-playback-expected.wav: Removed.
  • platform/wpe/webaudio/silence-after-playback-expected.wav: Removed.
  • webaudio/silence-after-playback.html: Removed.
4:18 PM Changeset in webkit [267605] by Lauro Moura
  • 2 edits in trunk/Source/WebCore

Use CMake 3.10 compatible list functions
https://bugs.webkit.org/show_bug.cgi?id=216996

Reviewed by Fujii Hironori.

POP_FRONT and PREPEND were added in CMake 3.15.

  • WebCoreMacros.cmake: Use GET and REMOVE_AT instead of POP_FRONT.
4:02 PM Changeset in webkit [267604] by Chris Dumez
  • 30 edits in trunk/Source/WebCore

Drop AudioNode::setNodeType()
https://bugs.webkit.org/show_bug.cgi?id=216988

Reviewed by Eric Carlson.

Drop AudioNode::setNodeType() in favor of passing the NodeType to the AudioNode constructor.
This makes sure we never forget to set the type.

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

  • Modules/webaudio/AudioBasicProcessorNode.h:
  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::convertEnumerationToString):
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::printNodeCounts):

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::context):
(WebCore::AudioNode::context const):
(WebCore::AudioNode::nodeType const):

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):

  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::ChannelSplitterNode):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):

  • Modules/webaudio/IIRFilterNode.cpp:

(WebCore::IIRFilterNode::IIRFilterNode):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNodeBase::PannerNodeBase):
(WebCore::PannerNode::PannerNode):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):

  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):

  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):

3:54 PM Changeset in webkit [267603] by Ross Kirsling
  • 9 edits in trunk

%TypedArray%.{from, of} no longer perform AllocateTypedArray
https://bugs.webkit.org/show_bug.cgi?id=216991

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/typedarray-of.js:

Fix test.

  • test262/expectations.yaml:

Mark twelve test cases as passing.

Source/JavaScriptCore:

Back in ES2015, %TypedArray%.of and %TypedArray%.from appear to have been based on the abstract operation
AllocateTypedArray, which involved crawling the prototype chain to find the appropriate constructor and
only permitted this to be a (derived) typed array.

This appears to have gone away as of ES2016 -- we simply expect this to be a constructor and verify that it
produced a typed array (of sufficient length).

  • builtins/BuiltinNames.h:
  • builtins/TypedArrayConstructor.js:

(of):
(from):
(allocateInt8Array): Deleted.
(allocateInt16Array): Deleted.
(allocateInt32Array): Deleted.
(allocateUint32Array): Deleted.
(allocateUint16Array): Deleted.
(allocateUint8Array): Deleted.
(allocateUint8ClampedArray): Deleted.
(allocateFloat32Array): Deleted.
(allocateFloat64Array): Deleted.

  • runtime/JSGenericTypedArrayViewConstructor.h:
  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::create):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

3:49 PM Changeset in webkit [267602] by dino@apple.com
  • 46 edits
    1 move
    8 adds in trunk/Source

WebGL should use GLES in iOS apps running on Apple Silicon
https://bugs.webkit.org/show_bug.cgi?id=216722
<rdar://problem/68976337>

Reviewed by Tim Horton and Ken Russell.

Source/ThirdParty/ANGLE:

Change ANGLE to dynamically load either EAGL (OpenGLES) or CGL (OpenGL) depending
on both compile and runtime configurations.

Intel Mac -> CGL
Intel Mac Catalyst -> CGL
Intel iOS Simulator -> EAGL
iOS Device -> EAGL
Apple Silicon Mac -> CGL
Apple Silicon Mac Catalyst (with Mac app) -> CGL
Apple Silicon Mac Catalyst (with iOS app) -> EAGL

The trickiest bit is Apple Silicon Mac Catalyst, which depends on the
type of the application it is attempting to run. In that case ANGLE must compile
both the CGL and EAGL interfaces and then pick one to use after launch.

  • ANGLE.xcodeproj/project.pbxproj: Add new files.
  • Configurations/ANGLE-dynamic.xcconfig: Remove all the OpenGL* linking.
  • Configurations/ANGLE-static.xcconfig:
  • GLESv2.cmake: New files.
  • src/common/platform.h: New definitions for CPU type on Apple Systems.
  • src/gpu_info_util/SystemInfo.h: Split SystemInfo for Apple into two

files, for iOS and Mac. Added a field for isiOSAppOnMac that will only
be true when running an iOS binary on Apple Silicon.

  • src/gpu_info_util/SystemInfo_apple.mm: Added. Decides which SystemInfo

to call.
(angle::GetSystemInfo):

  • src/gpu_info_util/SystemInfo_ios.cpp:

(angle::GetSystemInfo_ios):
(angle::GetSystemInfo): Deleted.

  • src/gpu_info_util/SystemInfo_macos.mm:

(angle::GetSystemInfo_mac):
(angle::GetSystemInfo): Deleted.

  • src/libANGLE/Caps.cpp: Can no longer just check for PLATFORM_IOS. This

might still need a runtime check.
(gl::DetermineDepthTextureANGLESupport):
(gl::DetermineDepthTextureOESSupport):

  • src/libANGLE/Display.cpp: This is the main initialization point for

ANGLE, which decides at compile/runtime which variant of Display to
create.

  • src/libANGLE/formatutils.cpp: Add the correct formats.

(gl::BuildInternalFormatInfoMap):

  • src/libANGLE/renderer/gl/SoftLinking_apple.h: Added. Macros to help soft-link

functions and ObjC classes.

  • src/libANGLE/renderer/gl/cgl/CGLFunctions.cpp: Added. Where we soft-link all

the OpenGL/CGL API.

  • src/libANGLE/renderer/gl/cgl/CGLFunctions.h: Added.
  • src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: Use the soft-linked methods.
  • src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:
  • src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.h:
  • src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: Rename WebSwapLayer to WebSwapLayerCGL

otherwise it clashes with the EAGL version.
(rx::WindowSurfaceCGL::initialize):
(-[WebSwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.
(-[WebSwapLayer copyCGLPixelFormatForDisplayMask:]): Deleted.
(-[WebSwapLayer copyCGLContextForPixelFormat:]): Deleted.
(-[WebSwapLayer canDrawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Deleted.
(-[WebSwapLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): Deleted.

  • src/libANGLE/renderer/gl/eagl/DeviceEAGL.cpp: Similar changes to the CGL implementation.
  • src/libANGLE/renderer/gl/eagl/DeviceEAGL.h:
  • src/libANGLE/renderer/gl/eagl/DisplayEAGL.h:
  • src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:

(rx::DisplayEAGL::initialize):
(rx::DisplayEAGL::terminate):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
(rx::WorkerContextEAGL::makeCurrent):
(rx::WorkerContextEAGL::unmakeCurrent):
(rx::DisplayEAGL::createWorkerContext):

  • src/libANGLE/renderer/gl/eagl/EAGLFunctions.h: Added.
  • src/libANGLE/renderer/gl/eagl/EAGLFunctions.mm: Added.
  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
  • src/libANGLE/renderer/gl/eagl/PbufferSurfaceEAGL.cpp:
  • src/libANGLE/renderer/gl/eagl/RendererEAGL.cpp:
  • src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.h:
  • src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:

(-[WebSwapLayerEAGL display]):
(rx::WindowSurfaceEAGL::initialize):
(-[WebSwapLayer initWithSharedState:withContext:withFunctions:]): Deleted.
(-[WebSwapLayer display]): Deleted.

  • src/libANGLE/renderer/gl/renderergl_utils.cpp: Runtime check.

(rx::nativegl_gl::GenerateCaps):

Source/WebCore:

  • Configurations/WebCore.xcconfig: Remove all OpenGL/OpenGLES linking.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContextGL.h: Change the ANGLE IOSurface texture binding

enums into functions, because they have to be calculated at run-time.

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: Use the new soft-linked

functions from PAL. Also implement the IOSurface texture binding helpers that were
previously enums.

  • platform/mac/PlatformScreenMac.mm:
  • platform/mac/WebGLBlocklist.mm:

Source/WebCore/PAL:

Add soft-linking content for OpenGL/OpenGLES.

  • PAL.xcodeproj/project.pbxproj:
  • pal/PlatformMac.cmake:
  • pal/cocoa/OpenGLSoftLinkCocoa.h: Added.
  • pal/cocoa/OpenGLSoftLinkCocoa.mm: Added.

Source/WebKit:

  • Configurations/WebKit.xcconfig: Remove OpenGL linking.
  • UIProcess/mac/HighPerformanceGPUManager.mm: Renamed to .mm. Use the PAL soft-linked OpenGL API.
3:41 PM Changeset in webkit [267601] by James Darpinian
  • 14 edits
    19 adds in trunk

Support EXT_float_blend
https://bugs.webkit.org/show_bug.cgi?id=216949

Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

  • src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::GenerateCaps):

Source/WebCore:

Test: webgl/conformance/extensions/ext-float-blend.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

  • html/canvas/EXTFloatBlend.cpp: Added.

(WebCore::EXTFloatBlend::EXTFloatBlend):
(WebCore::EXTFloatBlend::getName const):
(WebCore::EXTFloatBlend::supported):

  • html/canvas/EXTFloatBlend.h: Added.
  • html/canvas/EXTFloatBlend.idl: Added.
  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):

  • html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

  • webgl/conformance/extensions/ext-float-blend-expected.txt: Added.
  • webgl/conformance/extensions/ext-float-blend.html: Added.
  • webgl/resources/...: Added some support files.
3:24 PM Changeset in webkit [267600] by Alan Coon
  • 1 copy in tags/Safari-611.1.1

Tag Safari-611.1.1.

3:09 PM Changeset in webkit [267599] by Peng Liu
  • 9 edits in trunk/Source/WebKit

Replace the usages of (IPC::Attachment fencePort) with IPC::MachPort
https://bugs.webkit.org/show_bug.cgi?id=207683

Reviewed by Daniel Bates.

No new tests, no functional change.

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::setVideoLayerFrame): Replace the
IPC::Attachment argument with a MachSendRight.

  • WebProcess/cocoa/VideoFullscreenManager.h:
  • WebProcess/cocoa/VideoFullscreenManager.messages.in:
  • WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::setVideoLayerFrameFenced):
r232451 adds a check for mach port disposition, which is not necessary now.
Because ArgumentCoder<MachSendRight>::decode() provides the check.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTopContentInset): Replace the IPC::Attachment
argument with a MachSendRight.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTopContentInsetFenced): Ditto.
r232451 adds a check for mach port disposition, which is not necessary now.
Because ArgumentCoder<MachSendRight>::decode() provides the check.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:03 PM Changeset in webkit [267598] by Matt Lewis
  • 1 edit
    2 moves in trunk/Tools

Unreviewed dashboard fix.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device.png: Removed.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device@2x.png: Removed.
3:03 PM Changeset in webkit [267597] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit

Tweak the names of the GPU process audio/video capture internal feature flags
https://bugs.webkit.org/show_bug.cgi?id=216992

Reviewed by Tim Horton.

Keep all 6 of the GPU process feature flags together by adjusting the human readable names of
CaptureAudioInGPUProcessEnabled and CaptureVideoInGPUProcessEnabled to start with "GPU Process:", after
<https://trac.webkit.org/r267516>.

  • Shared/WebPreferencesInternal.yaml:
2:47 PM Changeset in webkit [267596] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Incorrect width value is set for partially collapsible trailing space
https://bugs.webkit.org/show_bug.cgi?id=216990

Reviewed by Simon Fraser.

Source/WebCore:

Use the letter-spacing value as the collapsible space.

Test: fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html

  • layout/inlineformatting/InlineLine.cpp:

(WebCore::Layout::Line::appendTextContent):

LayoutTests:

  • fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing-expected.html: Added.
  • fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html: Added.
2:43 PM Changeset in webkit [267595] by James Darpinian
  • 2 edits in trunk/Source/WebCore

Fix WEBGL_compressed_texture_s3tc_srgb in WebGL 2
https://bugs.webkit.org/show_bug.cgi?id=216951

Reviewed by Kenneth Russell.

Tested by webgl/2.0.0/conformance/extensions/webgl-compressed-texture-s3tc-srgb.html

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

2:32 PM Changeset in webkit [267594] by ysuzuki@apple.com
  • 242 edits
    8 deletes in trunk/Source

[JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
https://bugs.webkit.org/show_bug.cgi?id=216966

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch introduces JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION and changes how to define host functions.
In the new way, we declare a function like,

JSC_DECLARE_HOST_FUNCTION(functionHelloWorld);

And define the function like,

JSC_DEFINE_HOST_FUNCTION(functionHelloWorld, (JSGlobalObject* globalObject, CallFrame* callFrame))
{

function body.

}

This makes adding some meta information to each function easy, which helps JIT-caging to collect allowed function pointers.

  • API/JSAPIWrapperObject.mm:

(JSC::JSCallbackObject<JSAPIWrapperObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):

  • API/JSCallbackConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSCallbackConstructor): Deleted.

  • API/JSCallbackFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callJSCallbackFunction): Deleted.

  • API/JSCallbackObject.cpp:

(JSC::JSCallbackObject<JSNonFinalObject>::getCallFunction):
(JSC::JSCallbackObject<JSNonFinalObject>::getConstructFunction):
(JSC::JSCallbackObject<JSGlobalObject>::getCallFunction):
(JSC::JSCallbackObject<JSGlobalObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::getConstructData):
(JSC::JSCallbackObject<Parent>::constructImpl):
(JSC::JSCallbackObject<Parent>::getCallData):
(JSC::JSCallbackObject<Parent>::callImpl):
(JSC::JSCallbackObject<Parent>::construct): Deleted.
(JSC::JSCallbackObject<Parent>::call): Deleted.

  • API/ObjCCallbackFunction.mm:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callObjCCallbackFunction): Deleted.
(JSC::constructObjCCallbackFunction): Deleted.

  • API/glib/JSAPIWrapperGlobalObject.cpp:

(JSC::JSCallbackObject<JSAPIWrapperGlobalObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperGlobalObject>::getConstructFunction):

  • API/glib/JSAPIWrapperObjectGLib.cpp:

(JSC::JSCallbackObject<JSAPIWrapperObject>::getCallFunction):
(JSC::JSCallbackObject<JSAPIWrapperObject>::getConstructFunction):
(JSC::JSC_DEFINE_HOST_FUNCTION):

  • API/glib/JSCCallbackFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callJSCCallbackFunction): Deleted.
(JSC::constructJSCCallbackFunction): Deleted.

  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSC_DEFINE_HOST_FUNCTION):
(Inspector::jsInjectedScriptHostPrototypeAttributeEvaluate): Deleted.
(Inspector::jsInjectedScriptHostPrototypeAttributeSavedResultAlias): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionInternalConstructorName): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIsHTMLAllCollection): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIsPromiseRejectedWithNativeGetterTypeError): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionProxyTargetValue): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakMapSize): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakMapEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakSetSize): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionWeakSetEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionIteratorEntries): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionQueryInstances): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionQueryHolders): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionEvaluateWithScopeExtension): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionFunctionDetails): Deleted.
(Inspector::jsInjectedScriptHostPrototypeFunctionGetInternalProperties): Deleted.

  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSC_DEFINE_HOST_FUNCTION):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluateWithScopeExtension): Deleted.
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeCaller): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeSourceID): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeLine): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeColumn): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeFunctionName): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeScopeChain): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeThisObject): Deleted.
(Inspector::jsJavaScriptCallFrameAttributeType): Deleted.
(Inspector::jsJavaScriptCallFrameIsTailDeleted): Deleted.

  • jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):
(functionPrintStdOut): Deleted.
(functionPrintStdErr): Deleted.
(functionDebug): Deleted.
(functionDescribe): Deleted.
(functionDescribeArray): Deleted.
(functionSleepSeconds): Deleted.
(functionJSCStack): Deleted.
(functionGCAndSweep): Deleted.
(functionFullGC): Deleted.
(functionEdenGC): Deleted.
(functionHeapSize): Deleted.
(functionResetMemoryPeak): Deleted.
(functionAddressOf): Deleted.
(functionVersion): Deleted.
(functionRun): Deleted.
(functionRunString): Deleted.
(functionLoad): Deleted.
(functionLoadString): Deleted.
(functionReadFile): Deleted.
(functionCheckSyntax): Deleted.
(functionSetSamplingFlags): Deleted.
(functionClearSamplingFlags): Deleted.
(functionGetRandomSeed): Deleted.
(functionSetRandomSeed): Deleted.
(functionIsRope): Deleted.
(functionCallerSourceOrigin): Deleted.
(functionReadline): Deleted.
(functionPreciseTime): Deleted.
(functionNeverInlineFunction): Deleted.
(functionNoDFG): Deleted.
(functionNoFTL): Deleted.
(functionNoOSRExitFuzzing): Deleted.
(functionOptimizeNextInvocation): Deleted.
(functionNumberOfDFGCompiles): Deleted.
(functionCallerIsOMGCompiled): Deleted.
(functionDollarCreateRealm): Deleted.
(functionDollarEvalScript): Deleted.
(functionDollarAgentStart): Deleted.
(functionDollarAgentReceiveBroadcast): Deleted.
(functionDollarAgentReport): Deleted.
(functionDollarAgentSleep): Deleted.
(functionDollarAgentBroadcast): Deleted.
(functionDollarAgentGetReport): Deleted.
(functionDollarAgentLeaving): Deleted.
(functionDollarAgentMonotonicNow): Deleted.
(functionWaitForReport): Deleted.
(functionHeapCapacity): Deleted.
(functionFlashHeapAccess): Deleted.
(functionDisableRichSourceInfo): Deleted.
(functionMallocInALoop): Deleted.
(functionTotalCompileTime): Deleted.
(functionJSCOptions): Deleted.
(functionReoptimizationRetryCount): Deleted.
(functionTransferArrayBuffer): Deleted.
(functionFailNextNewCodeBlock): Deleted.
(functionQuit): Deleted.
(functionFalse): Deleted.
(functionUndefined1): Deleted.
(functionUndefined2): Deleted.
(functionIsInt32): Deleted.
(functionIsPureNaN): Deleted.
(functionIdentity): Deleted.
(functionEffectful42): Deleted.
(functionMakeMasquerader): Deleted.
(functionCallMasquerader): Deleted.
(functionHasCustomProperties): Deleted.
(functionDumpTypesForAllVariables): Deleted.
(functionDrainMicrotasks): Deleted.
(functionSetTimeout): Deleted.
(functionReleaseWeakRefs): Deleted.
(functionFinalizationRegistryLiveCount): Deleted.
(functionFinalizationRegistryDeadCount): Deleted.
(functionIs32BitPlatform): Deleted.
(functionCreateGlobalObject): Deleted.
(functionCreateHeapBigInt): Deleted.
(functionCreateBigInt32): Deleted.
(functionUseBigInt32): Deleted.
(functionIsBigInt32): Deleted.
(functionIsHeapBigInt): Deleted.
(functionCheckModuleSyntax): Deleted.
(functionPlatformSupportsSamplingProfiler): Deleted.
(functionGenerateHeapSnapshot): Deleted.
(functionGenerateHeapSnapshotForGCDebugging): Deleted.
(functionResetSuperSamplerState): Deleted.
(functionEnsureArrayStorage): Deleted.
(functionStartSamplingProfiler): Deleted.
(functionSamplingProfilerStackTraces): Deleted.
(functionMaxArguments): Deleted.
(functionAsyncTestStart): Deleted.
(functionAsyncTestPassed): Deleted.
(functionWebAssemblyMemoryMode): Deleted.
(functionSetUnhandledRejectionCallback): Deleted.
(functionAsDoubleNumber): Deleted.

  • runtime/AggregateErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAggregateErrorConstructor): Deleted.
(JSC::constructAggregateErrorConstructor): Deleted.

  • runtime/ArrayConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithArrayConstructor): Deleted.
(JSC::callArrayConstructor): Deleted.
(JSC::arrayConstructorPrivateFuncIsArraySlow): Deleted.

  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::arrayProtoFuncSpeciesCreate): Deleted.
(JSC::arrayProtoFuncToString): Deleted.
(JSC::arrayProtoFuncToLocaleString): Deleted.
(JSC::arrayProtoFuncJoin): Deleted.
(JSC::arrayProtoFuncValues): Deleted.
(JSC::arrayProtoFuncEntries): Deleted.
(JSC::arrayProtoFuncKeys): Deleted.
(JSC::arrayProtoFuncPop): Deleted.
(JSC::arrayProtoFuncPush): Deleted.
(JSC::arrayProtoFuncReverse): Deleted.
(JSC::arrayProtoFuncShift): Deleted.
(JSC::arrayProtoFuncSlice): Deleted.
(JSC::arrayProtoFuncSplice): Deleted.
(JSC::arrayProtoFuncUnShift): Deleted.
(JSC::arrayProtoFuncIndexOf): Deleted.
(JSC::arrayProtoFuncLastIndexOf): Deleted.
(JSC::arrayProtoPrivateFuncConcatMemcpy): Deleted.
(JSC::arrayProtoPrivateFuncAppendMemcpy): Deleted.

  • runtime/ArrayPrototype.h:
  • runtime/AsyncFunctionConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAsyncFunctionConstructor): Deleted.
(JSC::constructAsyncFunctionConstructor): Deleted.

  • runtime/AsyncGeneratorFunctionConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callAsyncGeneratorFunctionConstructor): Deleted.
(JSC::constructAsyncGeneratorFunctionConstructor): Deleted.

  • runtime/AtomicsObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::atomicsFuncAdd): Deleted.
(JSC::atomicsFuncAnd): Deleted.
(JSC::atomicsFuncCompareExchange): Deleted.
(JSC::atomicsFuncExchange): Deleted.
(JSC::atomicsFuncIsLockFree): Deleted.
(JSC::atomicsFuncLoad): Deleted.
(JSC::atomicsFuncOr): Deleted.
(JSC::atomicsFuncStore): Deleted.
(JSC::atomicsFuncSub): Deleted.
(JSC::atomicsFuncWait): Deleted.
(JSC::atomicsFuncWake): Deleted.
(JSC::atomicsFuncXor): Deleted.

  • runtime/BigIntConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callBigIntConstructor): Deleted.
(JSC::bigIntConstructorFuncAsUintN): Deleted.
(JSC::bigIntConstructorFuncAsIntN): Deleted.

  • runtime/BigIntPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::bigIntProtoFuncToString): Deleted.
(JSC::bigIntProtoFuncToLocaleString): Deleted.
(JSC::bigIntProtoFuncValueOf): Deleted.

  • runtime/BooleanConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callBooleanConstructor): Deleted.
(JSC::constructWithBooleanConstructor): Deleted.

  • runtime/BooleanPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::booleanProtoFuncToString): Deleted.
(JSC::booleanProtoFuncValueOf): Deleted.

  • runtime/ConsoleObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::consoleProtoFuncDebug): Deleted.
(JSC::consoleProtoFuncError): Deleted.
(JSC::consoleProtoFuncLog): Deleted.
(JSC::consoleProtoFuncInfo): Deleted.
(JSC::consoleProtoFuncWarn): Deleted.
(JSC::consoleProtoFuncClear): Deleted.
(JSC::consoleProtoFuncDir): Deleted.
(JSC::consoleProtoFuncDirXML): Deleted.
(JSC::consoleProtoFuncTable): Deleted.
(JSC::consoleProtoFuncTrace): Deleted.
(JSC::consoleProtoFuncAssert): Deleted.
(JSC::consoleProtoFuncCount): Deleted.
(JSC::consoleProtoFuncCountReset): Deleted.
(JSC::consoleProtoFuncProfile): Deleted.
(JSC::consoleProtoFuncProfileEnd): Deleted.
(JSC::consoleProtoFuncTakeHeapSnapshot): Deleted.
(JSC::consoleProtoFuncTime): Deleted.
(JSC::consoleProtoFuncTimeLog): Deleted.
(JSC::consoleProtoFuncTimeEnd): Deleted.
(JSC::consoleProtoFuncTimeStamp): Deleted.
(JSC::consoleProtoFuncGroup): Deleted.
(JSC::consoleProtoFuncGroupCollapsed): Deleted.
(JSC::consoleProtoFuncGroupEnd): Deleted.
(JSC::consoleProtoFuncRecord): Deleted.
(JSC::consoleProtoFuncRecordEnd): Deleted.
(JSC::consoleProtoFuncScreenshot): Deleted.

  • runtime/DateConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithDateConstructor): Deleted.
(JSC::callDate): Deleted.
(JSC::dateParse): Deleted.
(JSC::dateNow): Deleted.
(JSC::dateUTC): Deleted.

  • runtime/DatePrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::dateProtoFuncToString): Deleted.
(JSC::dateProtoFuncToUTCString): Deleted.
(JSC::dateProtoFuncToISOString): Deleted.
(JSC::dateProtoFuncToDateString): Deleted.
(JSC::dateProtoFuncToTimeString): Deleted.
(JSC::dateProtoFuncToPrimitiveSymbol): Deleted.
(JSC::dateProtoFuncGetTime): Deleted.
(JSC::dateProtoFuncGetFullYear): Deleted.
(JSC::dateProtoFuncGetUTCFullYear): Deleted.
(JSC::dateProtoFuncGetMonth): Deleted.
(JSC::dateProtoFuncGetUTCMonth): Deleted.
(JSC::dateProtoFuncGetDate): Deleted.
(JSC::dateProtoFuncGetUTCDate): Deleted.
(JSC::dateProtoFuncGetDay): Deleted.
(JSC::dateProtoFuncGetUTCDay): Deleted.
(JSC::dateProtoFuncGetHours): Deleted.
(JSC::dateProtoFuncGetUTCHours): Deleted.
(JSC::dateProtoFuncGetMinutes): Deleted.
(JSC::dateProtoFuncGetUTCMinutes): Deleted.
(JSC::dateProtoFuncGetSeconds): Deleted.
(JSC::dateProtoFuncGetUTCSeconds): Deleted.
(JSC::dateProtoFuncGetMilliSeconds): Deleted.
(JSC::dateProtoFuncGetUTCMilliseconds): Deleted.
(JSC::dateProtoFuncGetTimezoneOffset): Deleted.
(JSC::dateProtoFuncSetTime): Deleted.
(JSC::dateProtoFuncSetMilliSeconds): Deleted.
(JSC::dateProtoFuncSetUTCMilliseconds): Deleted.
(JSC::dateProtoFuncSetSeconds): Deleted.
(JSC::dateProtoFuncSetUTCSeconds): Deleted.
(JSC::dateProtoFuncSetMinutes): Deleted.
(JSC::dateProtoFuncSetUTCMinutes): Deleted.
(JSC::dateProtoFuncSetHours): Deleted.
(JSC::dateProtoFuncSetUTCHours): Deleted.
(JSC::dateProtoFuncSetDate): Deleted.
(JSC::dateProtoFuncSetUTCDate): Deleted.
(JSC::dateProtoFuncSetMonth): Deleted.
(JSC::dateProtoFuncSetUTCMonth): Deleted.
(JSC::dateProtoFuncSetFullYear): Deleted.
(JSC::dateProtoFuncSetUTCFullYear): Deleted.
(JSC::dateProtoFuncSetYear): Deleted.
(JSC::dateProtoFuncGetYear): Deleted.
(JSC::dateProtoFuncToJSON): Deleted.

  • runtime/DatePrototype.h:
  • runtime/ErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructErrorConstructor): Deleted.
(JSC::callErrorConstructor): Deleted.

  • runtime/ErrorPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::errorProtoFuncToString): Deleted.

  • runtime/FinalizationRegistryConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callFinalizationRegistry): Deleted.
(JSC::constructFinalizationRegistry): Deleted.

  • runtime/FinalizationRegistryPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncFinalizationRegistryRegister): Deleted.
(JSC::protoFuncFinalizationRegistryUnregister): Deleted.

  • runtime/FunctionConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithFunctionConstructor): Deleted.
(JSC::callFunctionConstructor): Deleted.

  • runtime/FunctionPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callFunctionPrototype): Deleted.
(JSC::functionProtoFuncToString): Deleted.

  • runtime/GeneratorFunctionConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callGeneratorFunctionConstructor): Deleted.
(JSC::constructGeneratorFunctionConstructor): Deleted.

  • runtime/InspectorInstrumentationObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::inspectorInstrumentationObjectLog): Deleted.

  • runtime/IntlCollatorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlCollator): Deleted.
(JSC::callIntlCollator): Deleted.
(JSC::IntlCollatorConstructorFuncSupportedLocalesOf): Deleted.

  • runtime/IntlCollatorPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlCollatorFuncCompare): Deleted.
(JSC::IntlCollatorPrototypeGetterCompare): Deleted.
(JSC::IntlCollatorPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlDateTimeFormat): Deleted.
(JSC::callIntlDateTimeFormat): Deleted.
(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf): Deleted.

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlDateTimeFormatFuncFormatDateTime): Deleted.
(JSC::IntlDateTimeFormatPrototypeGetterFormat): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncFormatRange): Deleted.
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlDisplayNamesConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlDisplayNames): Deleted.
(JSC::callIntlDisplayNames): Deleted.
(JSC::IntlDisplayNamesConstructorSupportedLocalesOf): Deleted.

  • runtime/IntlDisplayNamesPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlDisplayNamesPrototypeFuncOf): Deleted.
(JSC::IntlDisplayNamesPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlLocaleConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlLocale): Deleted.
(JSC::callIntlLocale): Deleted.

  • runtime/IntlLocalePrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlLocalePrototypeFuncMaximize): Deleted.
(JSC::IntlLocalePrototypeFuncMinimize): Deleted.
(JSC::IntlLocalePrototypeFuncToString): Deleted.
(JSC::IntlLocalePrototypeGetterBaseName): Deleted.
(JSC::IntlLocalePrototypeGetterCalendar): Deleted.
(JSC::IntlLocalePrototypeGetterCaseFirst): Deleted.
(JSC::IntlLocalePrototypeGetterCollation): Deleted.
(JSC::IntlLocalePrototypeGetterHourCycle): Deleted.
(JSC::IntlLocalePrototypeGetterNumeric): Deleted.
(JSC::IntlLocalePrototypeGetterNumberingSystem): Deleted.
(JSC::IntlLocalePrototypeGetterLanguage): Deleted.
(JSC::IntlLocalePrototypeGetterScript): Deleted.
(JSC::IntlLocalePrototypeGetterRegion): Deleted.

  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlNumberFormat): Deleted.
(JSC::callIntlNumberFormat): Deleted.
(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf): Deleted.

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlNumberFormatFuncFormat): Deleted.
(JSC::IntlNumberFormatPrototypeGetterFormat): Deleted.
(JSC::IntlNumberFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::intlObjectFuncGetCanonicalLocales): Deleted.

  • runtime/IntlPluralRulesConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlPluralRules): Deleted.
(JSC::callIntlPluralRules): Deleted.
(JSC::IntlPluralRulesConstructorFuncSupportedLocalesOf): Deleted.

  • runtime/IntlPluralRulesPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlPluralRulesPrototypeFuncSelect): Deleted.
(JSC::IntlPluralRulesPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlRelativeTimeFormatConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlRelativeTimeFormat): Deleted.
(JSC::callIntlRelativeTimeFormat): Deleted.
(JSC::IntlRelativeTimeFormatConstructorFuncSupportedLocalesOf): Deleted.

  • runtime/IntlRelativeTimeFormatPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlRelativeTimeFormatPrototypeFuncFormat): Deleted.
(JSC::IntlRelativeTimeFormatPrototypeFuncFormatToParts): Deleted.
(JSC::IntlRelativeTimeFormatPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlSegmentIteratorPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmentIteratorPrototypeFuncNext): Deleted.

  • runtime/IntlSegmenterConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructIntlSegmenter): Deleted.
(JSC::callIntlSegmenter): Deleted.
(JSC::IntlSegmenterConstructorSupportedLocalesOf): Deleted.

  • runtime/IntlSegmenterPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmenterPrototypeFuncSegment): Deleted.
(JSC::IntlSegmenterPrototypeFuncResolvedOptions): Deleted.

  • runtime/IntlSegmentsPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::IntlSegmentsPrototypeFuncContaining): Deleted.
(JSC::IntlSegmentsPrototypeFuncIterator): Deleted.

  • runtime/JSArrayBufferConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callArrayBuffer): Deleted.
(JSC::constructArrayBuffer): Deleted.
(JSC::constructSharedArrayBuffer): Deleted.
(JSC::arrayBufferFuncIsView): Deleted.

  • runtime/JSArrayBufferPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::arrayBufferProtoFuncSlice): Deleted.
(JSC::arrayBufferProtoGetterFuncByteLength): Deleted.
(JSC::sharedArrayBufferProtoGetterFuncByteLength): Deleted.

  • runtime/JSBoundFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::boundThisNoArgsFunctionCall): Deleted.
(JSC::boundFunctionCall): Deleted.
(JSC::boundThisNoArgsFunctionConstruct): Deleted.
(JSC::boundFunctionConstruct): Deleted.
(JSC::isBoundFunction): Deleted.
(JSC::hasInstanceBoundFunction): Deleted.

  • runtime/JSBoundFunction.h:
  • runtime/JSCustomGetterSetterFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::customGetterSetterFunctionCall): Deleted.

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::dataViewProtoGetterBuffer): Deleted.
(JSC::dataViewProtoGetterByteLength): Deleted.
(JSC::dataViewProtoGetterByteOffset): Deleted.
(JSC::dataViewProtoFuncGetInt8): Deleted.
(JSC::dataViewProtoFuncGetInt16): Deleted.
(JSC::dataViewProtoFuncGetInt32): Deleted.
(JSC::dataViewProtoFuncGetUint8): Deleted.
(JSC::dataViewProtoFuncGetUint16): Deleted.
(JSC::dataViewProtoFuncGetUint32): Deleted.
(JSC::dataViewProtoFuncGetFloat32): Deleted.
(JSC::dataViewProtoFuncGetFloat64): Deleted.
(JSC::dataViewProtoFuncSetInt8): Deleted.
(JSC::dataViewProtoFuncSetInt16): Deleted.
(JSC::dataViewProtoFuncSetInt32): Deleted.
(JSC::dataViewProtoFuncSetUint8): Deleted.
(JSC::dataViewProtoFuncSetUint16): Deleted.
(JSC::dataViewProtoFuncSetUint32): Deleted.
(JSC::dataViewProtoFuncSetFloat32): Deleted.
(JSC::dataViewProtoFuncSetFloat64): Deleted.

  • runtime/JSFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::argumentsGetter):
(JSC::callerGetter):
(JSC::callHostFunctionAsConstructor): Deleted.
(JSC::JSFunction::argumentsGetter): Deleted.
(JSC::JSFunction::callerGetter): Deleted.

  • runtime/JSFunction.h:
  • runtime/JSGenericTypedArrayViewConstructor.h:
  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::JSGenericTypedArrayViewConstructor):
(JSC::constructGenericTypedArrayViewImpl):
(JSC::callGenericTypedArrayViewImpl):
(JSC::constructGenericTypedArrayView): Deleted.
(JSC::callGenericTypedArrayView): Deleted.

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncCopyWithin): Deleted.
(JSC::genericTypedArrayViewProtoFuncIncludes): Deleted.
(JSC::genericTypedArrayViewProtoFuncIndexOf): Deleted.
(JSC::genericTypedArrayViewProtoFuncJoin): Deleted.
(JSC::genericTypedArrayViewProtoFuncLastIndexOf): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncBuffer): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncLength): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncByteLength): Deleted.
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset): Deleted.
(JSC::genericTypedArrayViewProtoFuncReverse): Deleted.
(JSC::genericTypedArrayViewPrivateFuncSort): Deleted.
(JSC::genericTypedArrayViewProtoFuncSlice): Deleted.
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::makeBoundFunction): Deleted.
(JSC::hasOwnLengthProperty): Deleted.
(JSC::createPrivateSymbol): Deleted.
(JSC::assertCall): Deleted.
(JSC::enableSamplingProfiler): Deleted.
(JSC::disableSamplingProfiler): Deleted.
(JSC::enableSuperSampler): Deleted.
(JSC::disableSuperSampler): Deleted.
(JSC::enqueueJob): Deleted.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::globalFuncEval): Deleted.
(JSC::globalFuncParseInt): Deleted.
(JSC::globalFuncParseFloat): Deleted.
(JSC::globalFuncDecodeURI): Deleted.
(JSC::globalFuncDecodeURIComponent): Deleted.
(JSC::globalFuncEncodeURI): Deleted.
(JSC::globalFuncEncodeURIComponent): Deleted.
(JSC::globalFuncEscape): Deleted.
(JSC::globalFuncUnescape): Deleted.
(JSC::globalFuncThrowTypeError): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsCalleeAndCaller): Deleted.
(JSC::globalFuncMakeTypeError): Deleted.
(JSC::globalFuncProtoGetter): Deleted.
(JSC::globalFuncProtoSetter): Deleted.
(JSC::globalFuncSetPrototypeDirect): Deleted.
(JSC::globalFuncHostPromiseRejectionTracker): Deleted.
(JSC::globalFuncBuiltinLog): Deleted.
(JSC::globalFuncBuiltinDescribe): Deleted.
(JSC::globalFuncImportModule): Deleted.
(JSC::globalFuncPropertyIsEnumerable): Deleted.
(JSC::globalFuncOwnKeys): Deleted.
(JSC::globalFuncDateTimeFormat): Deleted.

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSModuleLoader.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::moduleLoaderParseModule): Deleted.
(JSC::moduleLoaderRequestedModules): Deleted.
(JSC::moduleLoaderModuleDeclarationInstantiation): Deleted.
(JSC::moduleLoaderResolve): Deleted.
(JSC::moduleLoaderResolveSync): Deleted.
(JSC::moduleLoaderFetch): Deleted.
(JSC::moduleLoaderGetModuleNamespaceObject): Deleted.
(JSC::moduleLoaderEvaluate): Deleted.

  • runtime/JSNativeStdFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::runStdFunction): Deleted.

  • runtime/JSONObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSONProtoFuncParse): Deleted.
(JSC::JSONProtoFuncStringify): Deleted.

  • runtime/JSObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::objectPrivateFuncInstanceOf): Deleted.

  • runtime/JSObject.h:
  • runtime/JSTypedArrayViewConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructTypedArrayView): Deleted.

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::typedArrayViewPrivateFuncIsTypedArrayView): Deleted.
(JSC::typedArrayViewPrivateFuncIsNeutered): Deleted.
(JSC::typedArrayViewPrivateFuncLength): Deleted.
(JSC::typedArrayViewPrivateFuncGetOriginalConstructor): Deleted.
(JSC::typedArrayViewProtoFuncValues): Deleted.
(JSC::typedArrayProtoViewFuncEntries): Deleted.
(JSC::typedArrayViewProtoFuncKeys): Deleted.
(JSC::typedArrayViewPrivateFuncSort): Deleted.
(JSC::typedArrayViewProtoFuncSet): Deleted.
(JSC::typedArrayViewProtoFuncCopyWithin): Deleted.
(JSC::typedArrayViewProtoFuncIncludes): Deleted.
(JSC::typedArrayViewProtoFuncLastIndexOf): Deleted.
(JSC::typedArrayViewProtoFuncIndexOf): Deleted.
(JSC::typedArrayViewProtoFuncJoin): Deleted.
(JSC::typedArrayViewProtoGetterFuncBuffer): Deleted.
(JSC::typedArrayViewProtoGetterFuncLength): Deleted.
(JSC::typedArrayViewProtoGetterFuncByteLength): Deleted.
(JSC::typedArrayViewProtoGetterFuncByteOffset): Deleted.
(JSC::typedArrayViewProtoFuncReverse): Deleted.
(JSC::typedArrayViewPrivateFuncSubarrayCreate): Deleted.
(JSC::typedArrayViewProtoFuncSlice): Deleted.
(JSC::typedArrayViewProtoGetterFuncToStringTag): Deleted.

  • runtime/JSTypedArrayViewPrototype.h:
  • runtime/JSTypedArrays.cpp:

(JSC::createUint8TypedArray): Deleted.

  • runtime/MapConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callMap): Deleted.
(JSC::constructMap): Deleted.
(JSC::mapPrivateFuncMapBucketHead): Deleted.
(JSC::mapPrivateFuncMapBucketNext): Deleted.
(JSC::mapPrivateFuncMapBucketKey): Deleted.
(JSC::mapPrivateFuncMapBucketValue): Deleted.

  • runtime/MapConstructor.h:
  • runtime/MapPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::mapProtoFuncClear): Deleted.
(JSC::mapProtoFuncDelete): Deleted.
(JSC::mapProtoFuncGet): Deleted.
(JSC::mapProtoFuncHas): Deleted.
(JSC::mapProtoFuncSet): Deleted.
(JSC::mapProtoFuncValues): Deleted.
(JSC::mapProtoFuncKeys): Deleted.
(JSC::mapProtoFuncEntries): Deleted.
(JSC::mapProtoFuncSize): Deleted.

  • runtime/MathObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::mathProtoFuncAbs): Deleted.
(JSC::mathProtoFuncACos): Deleted.
(JSC::mathProtoFuncASin): Deleted.
(JSC::mathProtoFuncATan): Deleted.
(JSC::mathProtoFuncATan2): Deleted.
(JSC::mathProtoFuncCeil): Deleted.
(JSC::mathProtoFuncClz32): Deleted.
(JSC::mathProtoFuncCos): Deleted.
(JSC::mathProtoFuncExp): Deleted.
(JSC::mathProtoFuncFloor): Deleted.
(JSC::mathProtoFuncHypot): Deleted.
(JSC::mathProtoFuncLog): Deleted.
(JSC::mathProtoFuncMax): Deleted.
(JSC::mathProtoFuncMin): Deleted.
(JSC::mathProtoFuncPow): Deleted.
(JSC::mathProtoFuncRandom): Deleted.
(JSC::mathProtoFuncRound): Deleted.
(JSC::mathProtoFuncSign): Deleted.
(JSC::mathProtoFuncSin): Deleted.
(JSC::mathProtoFuncSqrt): Deleted.
(JSC::mathProtoFuncTan): Deleted.
(JSC::mathProtoFuncIMul): Deleted.
(JSC::mathProtoFuncACosh): Deleted.
(JSC::mathProtoFuncASinh): Deleted.
(JSC::mathProtoFuncATanh): Deleted.
(JSC::mathProtoFuncCbrt): Deleted.
(JSC::mathProtoFuncCosh): Deleted.
(JSC::mathProtoFuncExpm1): Deleted.
(JSC::mathProtoFuncFround): Deleted.
(JSC::mathProtoFuncLog1p): Deleted.
(JSC::mathProtoFuncLog10): Deleted.
(JSC::mathProtoFuncLog2): Deleted.
(JSC::mathProtoFuncSinh): Deleted.
(JSC::mathProtoFuncTanh): Deleted.
(JSC::mathProtoFuncTrunc): Deleted.

  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callEvalError): Deleted.
(JSC::constructEvalError): Deleted.
(JSC::callRangeError): Deleted.
(JSC::constructRangeError): Deleted.
(JSC::callReferenceError): Deleted.
(JSC::constructReferenceError): Deleted.
(JSC::callSyntaxError): Deleted.
(JSC::constructSyntaxError): Deleted.
(JSC::callTypeError): Deleted.
(JSC::constructTypeError): Deleted.
(JSC::callURIError): Deleted.
(JSC::constructURIError): Deleted.

  • runtime/NativeFunction.h:
  • runtime/NullGetterFunction.cpp:

(JSC::NullGetterFunctionInternal::JSC_DEFINE_HOST_FUNCTION):
(JSC::NullGetterFunctionInternal::callReturnUndefined): Deleted.

  • runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunctionInternal::JSC_DEFINE_HOST_FUNCTION):
(JSC::NullSetterFunctionInternal::callReturnUndefined): Deleted.
(JSC::NullSetterFunctionInternal::callThrowError): Deleted.

  • runtime/NumberConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructNumberConstructor): Deleted.
(JSC::callNumberConstructor): Deleted.
(JSC::numberConstructorFuncIsInteger): Deleted.
(JSC::numberConstructorFuncIsSafeInteger): Deleted.

  • runtime/NumberPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::numberProtoFuncToExponential): Deleted.
(JSC::numberProtoFuncToFixed): Deleted.
(JSC::numberProtoFuncToPrecision): Deleted.
(JSC::numberProtoFuncToString): Deleted.
(JSC::numberProtoFuncToLocaleString): Deleted.
(JSC::numberProtoFuncValueOf): Deleted.

  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructWithObjectConstructor): Deleted.
(JSC::callObjectConstructor): Deleted.
(JSC::objectConstructorGetPrototypeOf): Deleted.
(JSC::objectConstructorSetPrototypeOf): Deleted.
(JSC::objectConstructorGetOwnPropertyNames): Deleted.
(JSC::objectConstructorGetOwnPropertySymbols): Deleted.
(JSC::objectConstructorKeys): Deleted.
(JSC::objectConstructorAssign): Deleted.
(JSC::objectConstructorValues): Deleted.
(JSC::objectConstructorDefineProperty): Deleted.
(JSC::objectConstructorDefineProperties): Deleted.
(JSC::objectConstructorCreate): Deleted.
(JSC::objectConstructorPreventExtensions): Deleted.
(JSC::objectConstructorIsSealed): Deleted.
(JSC::objectConstructorIsFrozen): Deleted.
(JSC::objectConstructorIsExtensible): Deleted.
(JSC::objectConstructorIs): Deleted.

  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::objectProtoFuncValueOf): Deleted.
(JSC::objectProtoFuncHasOwnProperty): Deleted.
(JSC::objectProtoFuncIsPrototypeOf): Deleted.
(JSC::objectProtoFuncDefineGetter): Deleted.
(JSC::objectProtoFuncDefineSetter): Deleted.
(JSC::objectProtoFuncLookupGetter): Deleted.
(JSC::objectProtoFuncLookupSetter): Deleted.
(JSC::objectProtoFuncPropertyIsEnumerable): Deleted.
(JSC::objectProtoFuncToLocaleString): Deleted.
(JSC::objectProtoFuncToString): Deleted.

  • runtime/ObjectPrototype.h:
  • runtime/ProxyConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::makeRevocableProxy): Deleted.
(JSC::constructProxyObject): Deleted.
(JSC::callProxy): Deleted.

  • runtime/ProxyObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::performProxyCall): Deleted.
(JSC::performProxyConstruct): Deleted.

  • runtime/ProxyRevoke.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::performProxyRevoke): Deleted.

  • runtime/ReflectObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::reflectObjectConstruct): Deleted.
(JSC::reflectObjectDefineProperty): Deleted.
(JSC::reflectObjectGet): Deleted.
(JSC::reflectObjectGetOwnPropertyDescriptor): Deleted.
(JSC::reflectObjectGetPrototypeOf): Deleted.
(JSC::reflectObjectIsExtensible): Deleted.
(JSC::reflectObjectOwnKeys): Deleted.
(JSC::reflectObjectPreventExtensions): Deleted.
(JSC::reflectObjectSet): Deleted.
(JSC::reflectObjectSetPrototypeOf): Deleted.

  • runtime/RegExpConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::esSpecRegExpCreate): Deleted.
(JSC::esSpecIsRegExp): Deleted.
(JSC::constructWithRegExpConstructor): Deleted.
(JSC::callRegExpConstructor): Deleted.

  • runtime/RegExpConstructor.h:
  • runtime/RegExpPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::regExpProtoFuncTestFast): Deleted.
(JSC::regExpProtoFuncExec): Deleted.
(JSC::regExpProtoFuncMatchFast): Deleted.
(JSC::regExpProtoFuncCompile): Deleted.
(JSC::regExpProtoFuncToString): Deleted.
(JSC::regExpProtoGetterGlobal): Deleted.
(JSC::regExpProtoGetterIgnoreCase): Deleted.
(JSC::regExpProtoGetterMultiline): Deleted.
(JSC::regExpProtoGetterDotAll): Deleted.
(JSC::regExpProtoGetterSticky): Deleted.
(JSC::regExpProtoGetterUnicode): Deleted.
(JSC::regExpProtoGetterFlags): Deleted.
(JSC::regExpProtoGetterSource): Deleted.
(JSC::regExpProtoFuncSearchFast): Deleted.
(JSC::regExpProtoFuncSplitFast): Deleted.

  • runtime/RegExpPrototype.h:
  • runtime/SetConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callSet): Deleted.
(JSC::constructSet): Deleted.
(JSC::setPrivateFuncSetBucketHead): Deleted.
(JSC::setPrivateFuncSetBucketNext): Deleted.
(JSC::setPrivateFuncSetBucketKey): Deleted.

  • runtime/SetConstructor.h:
  • runtime/SetPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::setProtoFuncAdd): Deleted.
(JSC::setProtoFuncClear): Deleted.
(JSC::setProtoFuncDelete): Deleted.
(JSC::setProtoFuncHas): Deleted.
(JSC::setProtoFuncSize): Deleted.
(JSC::setProtoFuncValues): Deleted.
(JSC::setProtoFuncEntries): Deleted.

  • runtime/StringConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::stringFromCharCode):
(JSC::stringFromCodePoint): Deleted.
(JSC::constructWithStringConstructor): Deleted.
(JSC::callStringConstructor): Deleted.

  • runtime/StringConstructor.h:
  • runtime/StringPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::stringProtoFuncRepeatCharacter): Deleted.
(JSC::stringProtoFuncReplaceUsingRegExp): Deleted.
(JSC::stringProtoFuncReplaceUsingStringSearch): Deleted.
(JSC::stringProtoFuncReplaceAllUsingStringSearch): Deleted.
(JSC::stringProtoFuncToString): Deleted.
(JSC::stringProtoFuncCharAt): Deleted.
(JSC::stringProtoFuncCharCodeAt): Deleted.
(JSC::stringProtoFuncCodePointAt): Deleted.
(JSC::stringProtoFuncIndexOf): Deleted.
(JSC::builtinStringIndexOfInternal): Deleted.
(JSC::stringProtoFuncLastIndexOf): Deleted.
(JSC::stringProtoFuncSlice): Deleted.
(JSC::stringProtoFuncSplitFast): Deleted.
(JSC::stringProtoFuncSubstr): Deleted.
(JSC::stringProtoFuncSubstring): Deleted.
(JSC::builtinStringSubstringInternal): Deleted.
(JSC::stringProtoFuncToLowerCase): Deleted.
(JSC::stringProtoFuncToUpperCase): Deleted.
(JSC::stringProtoFuncLocaleCompare): Deleted.
(JSC::stringProtoFuncToLocaleLowerCase): Deleted.
(JSC::stringProtoFuncToLocaleUpperCase): Deleted.
(JSC::stringProtoFuncTrim): Deleted.
(JSC::stringProtoFuncTrimStart): Deleted.
(JSC::stringProtoFuncTrimEnd): Deleted.
(JSC::stringProtoFuncStartsWith): Deleted.
(JSC::stringProtoFuncEndsWith): Deleted.
(JSC::stringProtoFuncIncludes): Deleted.
(JSC::builtinStringIncludesInternal): Deleted.
(JSC::stringProtoFuncIterator): Deleted.
(JSC::stringProtoFuncNormalize): Deleted.

  • runtime/StringPrototype.h:
  • runtime/Structure.h:
  • runtime/SymbolConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callSymbol): Deleted.
(JSC::constructSymbol): Deleted.
(JSC::symbolConstructorFor): Deleted.
(JSC::symbolConstructorKeyFor): Deleted.

  • runtime/SymbolPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::symbolProtoGetterDescription): Deleted.
(JSC::symbolProtoFuncToString): Deleted.
(JSC::symbolProtoFuncValueOf): Deleted.

  • runtime/WeakMapConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakMap): Deleted.
(JSC::constructWeakMap): Deleted.

  • runtime/WeakMapPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakMapDelete): Deleted.
(JSC::protoFuncWeakMapGet): Deleted.
(JSC::protoFuncWeakMapHas): Deleted.
(JSC::protoFuncWeakMapSet): Deleted.

  • runtime/WeakObjectRefConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakRef): Deleted.
(JSC::constructWeakRef): Deleted.

  • runtime/WeakObjectRefPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakRefDeref): Deleted.

  • runtime/WeakSetConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWeakSet): Deleted.
(JSC::constructWeakSet): Deleted.

  • runtime/WeakSetPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::protoFuncWeakSetDelete): Deleted.
(JSC::protoFuncWeakSetHas): Deleted.
(JSC::protoFuncWeakSetAdd): Deleted.

  • tools/JSDollarVM.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSDollarVM::finishCreation):
(JSC::functionCrash): Deleted.
(JSC::functionBreakpoint): Deleted.
(JSC::functionDFGTrue): Deleted.
(JSC::functionFTLTrue): Deleted.
(JSC::functionCpuMfence): Deleted.
(JSC::functionCpuRdtsc): Deleted.
(JSC::functionCpuCpuid): Deleted.
(JSC::functionCpuPause): Deleted.
(JSC::functionCpuClflush): Deleted.
(JSC::functionLLintTrue): Deleted.
(JSC::functionBaselineJITTrue): Deleted.
(JSC::functionNoInline): Deleted.
(JSC::functionGC): Deleted.
(JSC::functionEdenGC): Deleted.
(JSC::functionGCSweepAsynchronously): Deleted.
(JSC::functionDumpSubspaceHashes): Deleted.
(JSC::functionCallFrame): Deleted.
(JSC::functionCodeBlockForFrame): Deleted.
(JSC::functionCodeBlockFor): Deleted.
(JSC::functionDumpSourceFor): Deleted.
(JSC::functionDumpBytecodeFor): Deleted.
(JSC::functionDataLog): Deleted.
(JSC::functionPrint): Deleted.
(JSC::functionDumpCallFrame): Deleted.
(JSC::functionDumpStack): Deleted.
(JSC::functionDumpRegisters): Deleted.
(JSC::functionDumpCell): Deleted.
(JSC::functionIndexingMode): Deleted.
(JSC::functionInlineCapacity): Deleted.
(JSC::functionValue): Deleted.
(JSC::functionGetPID): Deleted.
(JSC::functionHaveABadTime): Deleted.
(JSC::functionIsHavingABadTime): Deleted.
(JSC::functionCallWithStackSize): Deleted.
(JSC::functionCreateGlobalObject): Deleted.
(JSC::functionCreateProxy): Deleted.
(JSC::functionCreateRuntimeArray): Deleted.
(JSC::functionCreateNullRopeString): Deleted.
(JSC::functionCreateImpureGetter): Deleted.
(JSC::functionCreateCustomGetterObject): Deleted.
(JSC::functionCreateDOMJITNodeObject): Deleted.
(JSC::functionCreateDOMJITGetterObject): Deleted.
(JSC::functionCreateDOMJITGetterNoEffectsObject): Deleted.
(JSC::functionCreateDOMJITGetterComplexObject): Deleted.
(JSC::functionCreateDOMJITFunctionObject): Deleted.
(JSC::functionCreateDOMJITCheckJSCastObject): Deleted.
(JSC::functionCreateDOMJITGetterBaseJSObject): Deleted.
(JSC::functionCreateWasmStreamingParser): Deleted.
(JSC::functionCreateStaticCustomAccessor): Deleted.
(JSC::functionCreateStaticCustomValue): Deleted.
(JSC::functionCreateObjectDoingSideEffectPutWithoutCorrectSlotStatus): Deleted.
(JSC::functionCreateEmptyFunctionWithName): Deleted.
(JSC::functionSetImpureGetterDelegate): Deleted.
(JSC::functionCreateBuiltin): Deleted.
(JSC::functionGetPrivateProperty): Deleted.
(JSC::functionCreateRoot): Deleted.
(JSC::functionCreateElement): Deleted.
(JSC::functionGetElement): Deleted.
(JSC::functionCreateSimpleObject): Deleted.
(JSC::functionGetHiddenValue): Deleted.
(JSC::functionSetHiddenValue): Deleted.
(JSC::functionShadowChickenFunctionsOnStack): Deleted.
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(JSC::functionFindTypeForExpression): Deleted.
(JSC::functionReturnTypeFor): Deleted.
(JSC::functionFlattenDictionaryObject): Deleted.
(JSC::functionDumpBasicBlockExecutionRanges): Deleted.
(JSC::functionHasBasicBlockExecuted): Deleted.
(JSC::functionBasicBlockExecutionCount): Deleted.
(JSC::functionEnableDebuggerModeWhenIdle): Deleted.
(JSC::functionDisableDebuggerModeWhenIdle): Deleted.
(JSC::functionDeleteAllCodeWhenIdle): Deleted.
(JSC::functionGlobalObjectCount): Deleted.
(JSC::functionGlobalObjectForObject): Deleted.
(JSC::functionGetGetterSetter): Deleted.
(JSC::functionLoadGetterFromGetterSetter): Deleted.
(JSC::functionCreateCustomTestGetterSetter): Deleted.
(JSC::functionDeltaBetweenButterflies): Deleted.
(JSC::functionCurrentCPUTime): Deleted.
(JSC::functionTotalGCTime): Deleted.
(JSC::functionParseCount): Deleted.
(JSC::functionIsWasmSupported): Deleted.
(JSC::functionMake16BitStringIfPossible): Deleted.
(JSC::JSDollarVMHelper::functionGetStructureTransitionList): Deleted.
(JSC::functionGetConcurrently): Deleted.
(JSC::functionHasOwnLengthProperty): Deleted.
(JSC::functionRejectPromiseAsHandled): Deleted.
(JSC::functionSetUserPreferredLanguages): Deleted.
(JSC::functionICUVersion): Deleted.
(JSC::functionICUHeaderVersion): Deleted.
(JSC::functionAssertEnabled): Deleted.
(JSC::functionIsMemoryLimited): Deleted.
(JSC::functionUseJIT): Deleted.
(JSC::functionIsGigacageEnabled): Deleted.
(JSC::functionToUncacheableDictionary): Deleted.

  • wasm/js/JSWebAssembly.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyCompileFunc): Deleted.
(JSC::webAssemblyInstantiateFunc): Deleted.
(JSC::webAssemblyValidateFunc): Deleted.
(JSC::webAssemblyCompileStreamingInternal): Deleted.
(JSC::webAssemblyInstantiateStreamingInternal): Deleted.

  • wasm/js/JSWebAssembly.h:
  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyCompileError): Deleted.
(JSC::callJSWebAssemblyCompileError): Deleted.

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWebAssemblyFunction): Deleted.

  • wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyGlobal): Deleted.
(JSC::callJSWebAssemblyGlobal): Deleted.

  • wasm/js/WebAssemblyGlobalPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyGlobalProtoFuncValueOf): Deleted.
(JSC::webAssemblyGlobalProtoGetterFuncValue): Deleted.
(JSC::webAssemblyGlobalProtoSetterFuncValue): Deleted.

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyInstance): Deleted.
(JSC::callJSWebAssemblyInstance): Deleted.

  • wasm/js/WebAssemblyInstancePrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyInstanceProtoFuncExports): Deleted.

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyLinkError): Deleted.
(JSC::callJSWebAssemblyLinkError): Deleted.

  • wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyMemory): Deleted.
(JSC::callJSWebAssemblyMemory): Deleted.

  • wasm/js/WebAssemblyMemoryPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyMemoryProtoFuncGrow): Deleted.
(JSC::webAssemblyMemoryProtoFuncBuffer): Deleted.

  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyModuleCustomSections): Deleted.
(JSC::webAssemblyModuleImports): Deleted.
(JSC::webAssemblyModuleExports): Deleted.
(JSC::constructJSWebAssemblyModule): Deleted.
(JSC::callJSWebAssemblyModule): Deleted.

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyRuntimeError): Deleted.
(JSC::callJSWebAssemblyRuntimeError): Deleted.

  • wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::constructJSWebAssemblyTable): Deleted.
(JSC::callJSWebAssemblyTable): Deleted.

  • wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::webAssemblyTableProtoFuncLength): Deleted.
(JSC::webAssemblyTableProtoFuncGrow): Deleted.
(JSC::webAssemblyTableProtoFuncGet): Deleted.
(JSC::webAssemblyTableProtoFuncSet): Deleted.

  • wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::callWebAssemblyWrapperFunction): Deleted.

Source/WebCore:

No behavior change. We also annotate custom getters / setters with JIT_OPERATION since they can be invoked from JIT code.

  • bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor<JSClass>::construct):

  • bindings/js/JSDOMConstructor.h:
  • bindings/js/JSDOMConstructorBase.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::callThrowTypeError): Deleted.

  • bindings/js/JSDOMConstructorBase.h:
  • bindings/js/JSDOMConstructorNotConstructable.h:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::makeThisTypeErrorForBuiltins): Deleted.
(WebCore::makeGetterTypeErrorForBuiltins): Deleted.
(WebCore::makeDOMExceptionForBuiltins): Deleted.
(WebCore::isReadableByteStreamAPIEnabled): Deleted.
(WebCore::isWritableStreamAPIEnabled): Deleted.
(WebCore::whenSignalAborted): Deleted.

  • bindings/js/JSDOMIterator.h:

(WebCore::IteratorTraits>::next):

  • bindings/js/JSDOMLegacyFactoryFunction.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowWebKit):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsDOMWindowInstanceFunctionOpenDatabase): Deleted.

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::callPlugin): Deleted.

  • bindings/js/StructuredClone.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::cloneArrayBuffer): Deleted.
(WebCore::structuredCloneArrayBuffer): Deleted.
(WebCore::structuredCloneArrayBufferView): Deleted.

  • bindings/js/StructuredClone.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateAttributeGetterTrampolineDefinition):
(GenerateAttributeSetterTrampolineDefinition):
(GenerateOperationTrampolineDefinition):
(GenerateDefaultToJSONOperationDefinition):
(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
(GenerateIterableDefinition):
(GenerateConstructorDefinitions):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSDOMWindow.cpp:

(WebCore::jsDOMWindowConstructor):
(WebCore::setJSDOMWindowConstructor):
(WebCore::jsDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::setJSDOMWindowExposedToWorkerAndWindowConstructor):
(WebCore::jsDOMWindowTestConditionallyReadWriteConstructor):
(WebCore::setJSDOMWindowTestConditionallyReadWriteConstructor):
(WebCore::jsDOMWindowTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSDOMWindowTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsDOMWindowTestNodeConstructor):
(WebCore::setJSDOMWindowTestNodeConstructor):
(WebCore::jsDOMWindowTestObjectConstructor):
(WebCore::setJSDOMWindowTestObjectConstructor):
(WebCore::jsDOMWindowTestPromiseRejectionEventConstructor):
(WebCore::setJSDOMWindowTestPromiseRejectionEventConstructor):

  • bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp:

(WebCore::jsDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSDedicatedWorkerGlobalScopeConstructor):

  • bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:

(WebCore::JSExposedToWorkerAndWindowConstructor::construct):
(WebCore::jsExposedToWorkerAndWindowConstructor):
(WebCore::setJSExposedToWorkerAndWindowConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsExposedToWorkerAndWindowPrototypeFunctionDoSomething): Deleted.

  • bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsMapLikePrototypeFunctionForEach): Deleted.
(WebCore::jsMapLikePrototypeFunctionSet): Deleted.
(WebCore::jsMapLikePrototypeFunctionClear): Deleted.
(WebCore::jsMapLikePrototypeFunctionDelete): Deleted.

  • bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp:

(WebCore::jsPaintWorkletGlobalScopeConstructor):
(WebCore::setJSPaintWorkletGlobalScopeConstructor):

  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsReadOnlyMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsReadOnlyMapLikePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSReadOnlySetLike.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsReadOnlySetLikePrototypeFunctionHas): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionValues): Deleted.
(WebCore::jsReadOnlySetLikePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp:

(WebCore::jsServiceWorkerGlobalScopeConstructor):
(WebCore::setJSServiceWorkerGlobalScopeConstructor):

  • bindings/scripts/test/JS/JSSetLike.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsSetLikePrototypeFunctionHas): Deleted.
(WebCore::jsSetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsSetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsSetLikePrototypeFunctionValues): Deleted.
(WebCore::jsSetLikePrototypeFunctionForEach): Deleted.
(WebCore::jsSetLikePrototypeFunctionAdd): Deleted.
(WebCore::jsSetLikePrototypeFunctionClear): Deleted.
(WebCore::jsSetLikePrototypeFunctionDelete): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::prototypeForStructure):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction): Deleted.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage): Deleted.
(WebCore::jsTestActiveDOMObjectPrototypeFunctionOverloadedMethod): Deleted.

  • bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::jsTestCEReactionsConstructor):
(WebCore::setJSTestCEReactionsConstructor):
(WebCore::jsTestCEReactionsAttributeWithCEReactions):
(WebCore::setJSTestCEReactionsAttributeWithCEReactions):
(WebCore::jsTestCEReactionsReflectAttributeWithCEReactions):
(WebCore::setJSTestCEReactionsReflectAttributeWithCEReactions):
(WebCore::jsTestCEReactionsStringifierAttribute):
(WebCore::setJSTestCEReactionsStringifierAttribute):
(WebCore::jsTestCEReactionsAttributeWithCEReactionsNotNeeded):
(WebCore::setJSTestCEReactionsAttributeWithCEReactionsNotNeeded):
(WebCore::jsTestCEReactionsReflectAttributeWithCEReactionsNotNeeded):
(WebCore::setJSTestCEReactionsReflectAttributeWithCEReactionsNotNeeded):
(WebCore::jsTestCEReactionsStringifierAttributeNotNeeded):
(WebCore::setJSTestCEReactionsStringifierAttributeNotNeeded):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactions): Deleted.
(WebCore::jsTestCEReactionsPrototypeFunctionMethodWithCEReactionsNotNeeded): Deleted.

  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::jsTestCEReactionsStringifierConstructor):
(WebCore::setJSTestCEReactionsStringifierConstructor):
(WebCore::jsTestCEReactionsStringifierValue):
(WebCore::setJSTestCEReactionsStringifierValue):
(WebCore::jsTestCEReactionsStringifierValueWithoutReactions):
(WebCore::setJSTestCEReactionsStringifierValueWithoutReactions):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCEReactionsStringifierPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::JSTestCallTracerConstructor::prototypeForStructure):
(WebCore::jsTestCallTracerConstructor):
(WebCore::setJSTestCallTracerConstructor):
(WebCore::jsTestCallTracerTestAttributeInterface):
(WebCore::setJSTestCallTracerTestAttributeInterface):
(WebCore::jsTestCallTracerTestAttributeSpecified):
(WebCore::setJSTestCallTracerTestAttributeSpecified):
(WebCore::jsTestCallTracerTestAttributeWithVariant):
(WebCore::setJSTestCallTracerTestAttributeWithVariant):
(WebCore::jsTestCallTracerTestReadonlyAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterface): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecified): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArguments): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument): Deleted.
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument): Deleted.

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::jsTestClassWithJSBuiltinConstructorConstructor):
(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):

  • bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:

(WebCore::JSTestConditionalIncludesConstructor::prototypeForStructure):
(WebCore::jsTestConditionalIncludesConstructor):
(WebCore::setJSTestConditionalIncludesConstructor):
(WebCore::jsTestConditionalIncludesTestAttr):
(WebCore::jsTestConditionalIncludesMixinReadOnlyAttribute):
(WebCore::jsTestConditionalIncludesMixinAttribute):
(WebCore::setJSTestConditionalIncludesMixinAttribute):
(WebCore::jsTestConditionalIncludesMixinCustomAttribute):
(WebCore::setJSTestConditionalIncludesMixinCustomAttribute):
(WebCore::jsTestConditionalIncludesMixinNodeAttribute):
(WebCore::setJSTestConditionalIncludesMixinNodeAttribute):
(WebCore::jsTestConditionalIncludesPartialMixinAttributeFromPartial):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinComplexOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinCustomOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinConditionalOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinSettingsConditionalOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionMixinResultFieldOperation): Deleted.
(WebCore::jsTestConditionalIncludesPrototypeFunctionPartialMixinOperationFromPartial): Deleted.

  • bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:

(WebCore::JSTestConditionallyReadWriteConstructor::prototypeForStructure):
(WebCore::jsTestConditionallyReadWriteConstructor):
(WebCore::setJSTestConditionallyReadWriteConstructor):
(WebCore::jsTestConditionallyReadWriteConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteConditionalAndConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteConditionalAndConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeable):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeable):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::jsTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributePromise):
(WebCore::setJSTestConditionallyReadWriteRuntimeConditionallyReadWriteAttributePromise):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttribute):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttribute):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeable):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeable):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributeUnforgeablePrivate):
(WebCore::jsTestConditionallyReadWriteSettingsConditionallyReadWriteAttributePromise):
(WebCore::setJSTestConditionallyReadWriteSettingsConditionallyReadWriteAttributePromise):

  • bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::jsTestDOMJITConstructor):
(WebCore::setJSTestDOMJITConstructor):
(WebCore::jsTestDOMJITAnyAttr):
(WebCore::jsTestDOMJITBooleanAttr):
(WebCore::jsTestDOMJITByteAttr):
(WebCore::jsTestDOMJITOctetAttr):
(WebCore::jsTestDOMJITShortAttr):
(WebCore::jsTestDOMJITUnsignedShortAttr):
(WebCore::jsTestDOMJITLongAttr):
(WebCore::jsTestDOMJITUnsignedLongAttr):
(WebCore::jsTestDOMJITLongLongAttr):
(WebCore::jsTestDOMJITUnsignedLongLongAttr):
(WebCore::jsTestDOMJITFloatAttr):
(WebCore::jsTestDOMJITUnrestrictedFloatAttr):
(WebCore::jsTestDOMJITDoubleAttr):
(WebCore::jsTestDOMJITUnrestrictedDoubleAttr):
(WebCore::jsTestDOMJITDomStringAttr):
(WebCore::jsTestDOMJITByteStringAttr):
(WebCore::jsTestDOMJITUsvStringAttr):
(WebCore::jsTestDOMJITNodeAttr):
(WebCore::jsTestDOMJITBooleanNullableAttr):
(WebCore::jsTestDOMJITByteNullableAttr):
(WebCore::jsTestDOMJITOctetNullableAttr):
(WebCore::jsTestDOMJITShortNullableAttr):
(WebCore::jsTestDOMJITUnsignedShortNullableAttr):
(WebCore::jsTestDOMJITLongNullableAttr):
(WebCore::jsTestDOMJITUnsignedLongNullableAttr):
(WebCore::jsTestDOMJITLongLongNullableAttr):
(WebCore::jsTestDOMJITUnsignedLongLongNullableAttr):
(WebCore::jsTestDOMJITFloatNullableAttr):
(WebCore::jsTestDOMJITUnrestrictedFloatNullableAttr):
(WebCore::jsTestDOMJITDoubleNullableAttr):
(WebCore::jsTestDOMJITUnrestrictedDoubleNullableAttr):
(WebCore::jsTestDOMJITDomStringNullableAttr):
(WebCore::jsTestDOMJITByteStringNullableAttr):
(WebCore::jsTestDOMJITUsvStringNullableAttr):
(WebCore::jsTestDOMJITNodeNullableAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDOMJITPrototypeFunctionGetAttribute): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionItem): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionHasAttribute): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionGetElementById): Deleted.
(WebCore::jsTestDOMJITPrototypeFunctionGetElementsByName): Deleted.

  • bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:

(WebCore::jsTestDefaultToJSONConstructor):
(WebCore::setJSTestDefaultToJSONConstructor):
(WebCore::jsTestDefaultToJSONLongAttribute):
(WebCore::jsTestDefaultToJSONEnabledBySettingsAttribute):
(WebCore::jsTestDefaultToJSONEnabledByConditionalAttribute):
(WebCore::jsTestDefaultToJSONEventHandlerAttribute):
(WebCore::setJSTestDefaultToJSONEventHandlerAttribute):
(WebCore::jsTestDefaultToJSONFirstStringAttribute):
(WebCore::setJSTestDefaultToJSONFirstStringAttribute):
(WebCore::jsTestDefaultToJSONSecondLongAttribute):
(WebCore::setJSTestDefaultToJSONSecondLongAttribute):
(WebCore::jsTestDefaultToJSONThirdUnJSONableAttribute):
(WebCore::setJSTestDefaultToJSONThirdUnJSONableAttribute):
(WebCore::jsTestDefaultToJSONFourthUnrestrictedDoubleAttribute):
(WebCore::setJSTestDefaultToJSONFourthUnrestrictedDoubleAttribute):
(WebCore::jsTestDefaultToJSONFifthLongClampedAttribute):
(WebCore::setJSTestDefaultToJSONFifthLongClampedAttribute):
(WebCore::jsTestDefaultToJSONSixthTypedefAttribute):
(WebCore::setJSTestDefaultToJSONSixthTypedefAttribute):
(WebCore::jsTestDefaultToJSONSeventhDirectlyToJSONableAttribute):
(WebCore::setJSTestDefaultToJSONSeventhDirectlyToJSONableAttribute):
(WebCore::jsTestDefaultToJSONEighthIndirectlyAttribute):
(WebCore::setJSTestDefaultToJSONEighthIndirectlyAttribute):
(WebCore::jsTestDefaultToJSONNinthOptionalDirectlyToJSONableAttribute):
(WebCore::setJSTestDefaultToJSONNinthOptionalDirectlyToJSONableAttribute):
(WebCore::jsTestDefaultToJSONTenthFrozenArrayAttribute):
(WebCore::setJSTestDefaultToJSONTenthFrozenArrayAttribute):
(WebCore::jsTestDefaultToJSONEleventhSequenceAttribute):
(WebCore::setJSTestDefaultToJSONEleventhSequenceAttribute):
(WebCore::jsTestDefaultToJSONTwelfthInterfaceSequenceAttribute):
(WebCore::setJSTestDefaultToJSONTwelfthInterfaceSequenceAttribute):
(WebCore::jsTestDefaultToJSONThirteenthRecordAttribute):
(WebCore::setJSTestDefaultToJSONThirteenthRecordAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONPrototypeFunctionToJSON): Deleted.

  • bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:

(WebCore::jsTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsTestDefaultToJSONFilteredByExposedNormalAttribute):
(WebCore::jsTestDefaultToJSONFilteredByExposedFilteredByExposedWindowAttribute):
(WebCore::jsTestDefaultToJSONFilteredByExposedFilteredByExposedWorkerAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONFilteredByExposedPrototypeFunctionToJSON): Deleted.

  • bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp:

(WebCore::jsTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::setJSTestDefaultToJSONIndirectInheritanceConstructor):

  • bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:

(WebCore::jsTestDefaultToJSONInheritConstructor):
(WebCore::setJSTestDefaultToJSONInheritConstructor):
(WebCore::jsTestDefaultToJSONInheritInheritLongAttribute):
(WebCore::setJSTestDefaultToJSONInheritInheritLongAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONInheritPrototypeFunctionToJSON): Deleted.

  • bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:

(WebCore::jsTestDefaultToJSONInheritFinalConstructor):
(WebCore::setJSTestDefaultToJSONInheritFinalConstructor):
(WebCore::jsTestDefaultToJSONInheritFinalFinalLongAttributeFoo):
(WebCore::setJSTestDefaultToJSONInheritFinalFinalLongAttributeFoo):
(WebCore::jsTestDefaultToJSONInheritFinalFinalLongAttributeBar):
(WebCore::setJSTestDefaultToJSONInheritFinalFinalLongAttributeBar):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDefaultToJSONInheritFinalPrototypeFunctionToJSON): Deleted.

  • bindings/scripts/test/JS/JSTestDomainSecurity.cpp:

(WebCore::JSTestDomainSecurityConstructor::prototypeForStructure):
(WebCore::jsTestDomainSecurityConstructor):
(WebCore::setJSTestDomainSecurityConstructor):
(WebCore::jsTestDomainSecurityExcitingAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestDomainSecurityPrototypeFunctionExcitingFunction): Deleted.
(WebCore::jsTestDomainSecurityPrototypeFunctionPostMessage): Deleted.
(WebCore::jsTestDomainSecurityPrototypeFunctionOverloadedMethod): Deleted.

  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingConstructor::prototypeForStructure):
(WebCore::jsTestEnabledBySettingConstructor):
(WebCore::setJSTestEnabledBySettingConstructor):
(WebCore::jsTestEnabledBySettingTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestEnabledBySettingTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestEnabledBySettingEnabledBySettingAttribute):
(WebCore::setJSTestEnabledBySettingEnabledBySettingAttribute):
(WebCore::jsTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::setJSTestEnabledBySettingEnabledByTwoSettingsAttribute):
(WebCore::jsTestEnabledBySettingSupplementalAttribute):
(WebCore::setJSTestEnabledBySettingSupplementalAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestEnabledBySettingPrototypeFunctionEnabledBySettingOperation): Deleted.

  • bindings/scripts/test/JS/JSTestEnabledForContext.cpp:

(WebCore::jsTestEnabledForContextConstructor):
(WebCore::setJSTestEnabledForContextConstructor):
(WebCore::jsTestEnabledForContextTestSubObjEnabledForContextConstructor):
(WebCore::setJSTestEnabledForContextTestSubObjEnabledForContextConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::setJSTestEventConstructorConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorAttr3):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetConstructor):
(WebCore::setJSTestEventTargetConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestEventTargetPrototypeFunctionItem): Deleted.

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::jsTestExceptionConstructor):
(WebCore::setJSTestExceptionConstructor):
(WebCore::jsTestExceptionName):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::jsTestGenerateIsReachableConstructor):
(WebCore::setJSTestGenerateIsReachableConstructor):
(WebCore::jsTestGenerateIsReachableASecretAttribute):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectConstructor):
(WebCore::setJSTestGlobalObjectConstructor):
(WebCore::jsTestGlobalObjectRegularAttribute):
(WebCore::setJSTestGlobalObjectRegularAttribute):
(WebCore::jsTestGlobalObjectPublicAndPrivateAttribute):
(WebCore::setJSTestGlobalObjectPublicAndPrivateAttribute):
(WebCore::jsTestGlobalObjectPublicAndPrivateConditionalAttribute):
(WebCore::setJSTestGlobalObjectPublicAndPrivateConditionalAttribute):
(WebCore::jsTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::setJSTestGlobalObjectEnabledAtRuntimeAttribute):
(WebCore::jsTestGlobalObjectDOMWindowConstructor):
(WebCore::setJSTestGlobalObjectDOMWindowConstructor):
(WebCore::jsTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectDedicatedWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectPaintWorkletGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectServiceWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectTestCEReactionsConstructor):
(WebCore::setJSTestGlobalObjectTestCEReactionsConstructor):
(WebCore::jsTestGlobalObjectTestCEReactionsStringifierConstructor):
(WebCore::setJSTestGlobalObjectTestCEReactionsStringifierConstructor):
(WebCore::jsTestGlobalObjectTestCallTracerConstructor):
(WebCore::setJSTestGlobalObjectTestCallTracerConstructor):
(WebCore::jsTestGlobalObjectTestCallbackInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestCallbackInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestClassWithJSBuiltinConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestClassWithJSBuiltinConstructorConstructor):
(WebCore::jsTestGlobalObjectTestConditionalIncludesConstructor):
(WebCore::setJSTestGlobalObjectTestConditionalIncludesConstructor):
(WebCore::jsTestGlobalObjectTestDOMJITConstructor):
(WebCore::setJSTestGlobalObjectTestDOMJITConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONIndirectInheritanceConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONInheritConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONInheritConstructor):
(WebCore::jsTestGlobalObjectTestDefaultToJSONInheritFinalConstructor):
(WebCore::setJSTestGlobalObjectTestDefaultToJSONInheritFinalConstructor):
(WebCore::jsTestGlobalObjectTestDomainSecurityConstructor):
(WebCore::setJSTestGlobalObjectTestDomainSecurityConstructor):
(WebCore::jsTestGlobalObjectTestEnabledBySettingConstructor):
(WebCore::setJSTestGlobalObjectTestEnabledBySettingConstructor):
(WebCore::jsTestGlobalObjectTestEnabledForContextConstructor):
(WebCore::setJSTestGlobalObjectTestEnabledForContextConstructor):
(WebCore::jsTestGlobalObjectTestEventConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestEventConstructorConstructor):
(WebCore::jsTestGlobalObjectTestEventTargetConstructor):
(WebCore::setJSTestGlobalObjectTestEventTargetConstructor):
(WebCore::jsTestGlobalObjectTestExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestExceptionConstructor):
(WebCore::jsTestGlobalObjectTestGenerateIsReachableConstructor):
(WebCore::setJSTestGlobalObjectTestGenerateIsReachableConstructor):
(WebCore::jsTestGlobalObjectTestGlobalObjectConstructor):
(WebCore::setJSTestGlobalObjectTestGlobalObjectConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestIndexedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestInterfaceLeadingUnderscoreConstructor):
(WebCore::setJSTestGlobalObjectTestInterfaceLeadingUnderscoreConstructor):
(WebCore::jsTestGlobalObjectTestIterableConstructor):
(WebCore::setJSTestGlobalObjectTestIterableConstructor):
(WebCore::jsTestGlobalObjectTestJSBuiltinConstructorConstructor):
(WebCore::setJSTestGlobalObjectTestJSBuiltinConstructorConstructor):
(WebCore::jsTestGlobalObjectTestLegacyFactoryFunctionConstructor):
(WebCore::setJSTestGlobalObjectTestLegacyFactoryFunctionConstructor):
(WebCore::jsTestGlobalObjectAudioConstructor):
(WebCore::setJSTestGlobalObjectAudioConstructor):
(WebCore::jsTestGlobalObjectTestLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestMapLikeConstructor):
(WebCore::setJSTestGlobalObjectTestMapLikeConstructor):
(WebCore::jsTestGlobalObjectTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestGlobalObjectTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterCallWithConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterCallWithConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedGetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedGetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterNoIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterNoIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterThrowingExceptionConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterThrowingExceptionConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIdentifierConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIdentifierConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIndexedGetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIndexedGetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::jsTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestGlobalObjectTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestGlobalObjectTestOperationConditionalConstructor):
(WebCore::setJSTestGlobalObjectTestOperationConditionalConstructor):
(WebCore::jsTestGlobalObjectTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::setJSTestGlobalObjectTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::jsTestGlobalObjectTestPluginInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestPluginInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestReadOnlyMapLikeConstructor):
(WebCore::setJSTestGlobalObjectTestReadOnlyMapLikeConstructor):
(WebCore::jsTestGlobalObjectTestReadOnlySetLikeConstructor):
(WebCore::setJSTestGlobalObjectTestReadOnlySetLikeConstructor):
(WebCore::jsTestGlobalObjectTestReportExtraMemoryCostConstructor):
(WebCore::setJSTestGlobalObjectTestReportExtraMemoryCostConstructor):
(WebCore::jsTestGlobalObjectTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestGlobalObjectTestSerializedScriptValueInterfaceConstructor):
(WebCore::jsTestGlobalObjectTestSetLikeConstructor):
(WebCore::setJSTestGlobalObjectTestSetLikeConstructor):
(WebCore::jsTestGlobalObjectTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestGlobalObjectTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestGlobalObjectTestStringifierConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierConstructor):
(WebCore::jsTestGlobalObjectTestStringifierAnonymousOperationConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierAnonymousOperationConstructor):
(WebCore::jsTestGlobalObjectTestStringifierNamedOperationConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierNamedOperationConstructor):
(WebCore::jsTestGlobalObjectTestStringifierOperationImplementedAsConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierOperationImplementedAsConstructor):
(WebCore::jsTestGlobalObjectTestStringifierOperationNamedToStringConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierOperationNamedToStringConstructor):
(WebCore::jsTestGlobalObjectTestStringifierReadOnlyAttributeConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierReadOnlyAttributeConstructor):
(WebCore::jsTestGlobalObjectTestStringifierReadWriteAttributeConstructor):
(WebCore::setJSTestGlobalObjectTestStringifierReadWriteAttributeConstructor):
(WebCore::jsTestGlobalObjectTestTypedefsConstructor):
(WebCore::setJSTestGlobalObjectTestTypedefsConstructor):
(WebCore::jsTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkerGlobalScopeConstructor):
(WebCore::jsTestGlobalObjectWorkletGlobalScopeConstructor):
(WebCore::setJSTestGlobalObjectWorkletGlobalScopeConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestGlobalObjectInstanceFunctionRegularOperation): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestGlobalObjectConstructorFunctionEnabledAtRuntimeOperationStatic): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorld): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledInSpecificWorldWhenRuntimeFeaturesEnabled): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionTestPrivateFunction): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestGlobalObjectInstanceFunctionTestFeatureGetSecretBoolean): Deleted.

  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::jsTestIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestIndexedSetterNoIdentifierConstructor):

  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::jsTestIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestIndexedSetterThrowingExceptionConstructor):

  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::jsTestIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestIndexedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestIndexedSetterWithIdentifierPrototypeFunctionIndexedSetter): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceConstructor):
(WebCore::jsTestInterfaceMixinReadOnlyAttribute):
(WebCore::jsTestInterfaceMixinAttribute):
(WebCore::setJSTestInterfaceMixinAttribute):
(WebCore::jsTestInterfaceMixinCustomAttribute):
(WebCore::setJSTestInterfaceMixinCustomAttribute):
(WebCore::jsTestInterfaceMixinNodeAttribute):
(WebCore::setJSTestInterfaceMixinNodeAttribute):
(WebCore::jsTestInterfacePartialMixinAttributeFromPartial):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceReflectAttribute):
(WebCore::setJSTestInterfaceReflectAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestInterfacePrototypeFunctionEntriesCaller):
(WebCore::jsTestInterfacePrototypeFunctionMixinOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinComplexOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinCustomOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinConditionalOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinSettingsConditionalOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionMixinResultFieldOperation): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionPartialMixinOperationFromPartial): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3): Deleted.
(WebCore::jsTestInterfaceConstructorFunctionSupplementalMethod4): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionEntries): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionKeys): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionValues): Deleted.
(WebCore::jsTestInterfacePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::jsTestInterfaceLeadingUnderscoreConstructor):
(WebCore::setJSTestInterfaceLeadingUnderscoreConstructor):
(WebCore::jsTestInterfaceLeadingUnderscoreReadonly):

  • bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::jsTestIterableConstructor):
(WebCore::setJSTestIterableConstructor):
(WebCore::jsTestIterablePrototypeFunctionEntriesCaller):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestIterablePrototypeFunctionEntries): Deleted.
(WebCore::jsTestIterablePrototypeFunctionKeys): Deleted.
(WebCore::jsTestIterablePrototypeFunctionValues): Deleted.
(WebCore::jsTestIterablePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::jsTestJSBuiltinConstructorConstructor):
(WebCore::setJSTestJSBuiltinConstructorConstructor):
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom):
(WebCore::jsTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::setJSTestJSBuiltinConstructorTestAttributeRWCustom):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestJSBuiltinConstructorPrototypeFunctionTestCustomFunction): Deleted.

  • bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:

(WebCore::JSTestLegacyFactoryFunctionLegacyFactoryFunction::construct):
(WebCore::jsTestLegacyFactoryFunctionConstructor):
(WebCore::setJSTestLegacyFactoryFunctionConstructor):

  • bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp:

(WebCore::JSTestLegacyNoInterfaceObjectPrototype::finishCreation):
(WebCore::jsTestLegacyNoInterfaceObjectReadonlyStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectReadWriteStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectReadWriteStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectCustomGetterSetterStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectCustomGetterSetterStringAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectNodeAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectNodeAttribute):
(WebCore::jsTestLegacyNoInterfaceObjectConstructorStaticStringAttribute):
(WebCore::setJSTestLegacyNoInterfaceObjectConstructorStaticStringAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionVoidOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionThrowingOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectPrototypeFunctionCustomOperation): Deleted.
(WebCore::jsTestLegacyNoInterfaceObjectConstructorFunctionStaticOperation): Deleted.

  • bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp:

(WebCore::jsTestLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestLegacyOverrideBuiltInsConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestLegacyOverrideBuiltInsPrototypeFunctionNamedItem): Deleted.

  • bindings/scripts/test/JS/JSTestMapLike.cpp:

(WebCore::jsTestMapLikeConstructor):
(WebCore::setJSTestMapLikeConstructor):
(WebCore::jsTestMapLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionForEach): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionSet): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionClear): Deleted.
(WebCore::jsTestMapLikePrototypeFunctionDelete): Deleted.

  • bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp:

(WebCore::jsTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestMapLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestMapLikeWithOverriddenOperationsSet):
(WebCore::setJSTestMapLikeWithOverriddenOperationsSet):
(WebCore::jsTestMapLikeWithOverriddenOperationsSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionClear): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionGet): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionHas): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionEntries): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionKeys): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionValues): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionForEach): Deleted.
(WebCore::jsTestMapLikeWithOverriddenOperationsPrototypeFunctionDelete): Deleted.

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::jsTestNamedAndIndexedSetterNoIdentifierConstructor):
(WebCore::setJSTestNamedAndIndexedSetterNoIdentifierConstructor):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::jsTestNamedAndIndexedSetterThrowingExceptionConstructor):
(WebCore::setJSTestNamedAndIndexedSetterThrowingExceptionConstructor):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::jsTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::setJSTestNamedAndIndexedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedAndIndexedSetterWithIdentifierPrototypeFunctionIndexedSetter): Deleted.

  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::jsTestNamedDeleterNoIdentifierConstructor):
(WebCore::setJSTestNamedDeleterNoIdentifierConstructor):

  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::jsTestNamedDeleterThrowingExceptionConstructor):
(WebCore::setJSTestNamedDeleterThrowingExceptionConstructor):

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::jsTestNamedDeleterWithIdentifierConstructor):
(WebCore::setJSTestNamedDeleterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedDeleterWithIdentifierPrototypeFunctionNamedDeleter): Deleted.

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::jsTestNamedDeleterWithIndexedGetterConstructor):
(WebCore::setJSTestNamedDeleterWithIndexedGetterConstructor):

  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::jsTestNamedGetterCallWithConstructor):
(WebCore::setJSTestNamedGetterCallWithConstructor):

  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::jsTestNamedGetterNoIdentifierConstructor):
(WebCore::setJSTestNamedGetterNoIdentifierConstructor):

  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::jsTestNamedGetterWithIdentifierConstructor):
(WebCore::setJSTestNamedGetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedGetterWithIdentifierPrototypeFunctionGetterName): Deleted.

  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::jsTestNamedSetterNoIdentifierConstructor):
(WebCore::setJSTestNamedSetterNoIdentifierConstructor):

  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::jsTestNamedSetterThrowingExceptionConstructor):
(WebCore::setJSTestNamedSetterThrowingExceptionConstructor):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::jsTestNamedSetterWithIdentifierConstructor):
(WebCore::setJSTestNamedSetterWithIdentifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIdentifierPrototypeFunctionNamedSetter): Deleted.

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::jsTestNamedSetterWithIndexedGetterConstructor):
(WebCore::setJSTestNamedSetterWithIndexedGetterConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIndexedGetterPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedSetterWithIndexedGetterPrototypeFunctionIndexedSetter): Deleted.

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::setJSTestNamedSetterWithIndexedGetterAndSetterConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionNamedSetter): Deleted.
(WebCore::jsTestNamedSetterWithIndexedGetterAndSetterPrototypeFunctionIndexedSetter): Deleted.

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:

(WebCore::jsTestNamedSetterWithLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestNamedSetterWithLegacyOverrideBuiltInsConstructor):

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesConstructor::prototypeForStructure):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::setJSTestNamedSetterWithLegacyUnforgeablePropertiesConstructor):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesUnforgeableAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesInstanceFunctionUnforgeableOperation): Deleted.

  • bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor::prototypeForStructure):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::setJSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsConstructor):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsUnforgeableAttribute):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsInstanceFunctionUnforgeableOperation): Deleted.

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):
(WebCore::jsTestNodeConstructor):
(WebCore::setJSTestNodeConstructor):
(WebCore::jsTestNodeName):
(WebCore::setJSTestNodeName):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestNodePrototypeFunctionEntriesCaller):
(WebCore::jsTestNodePrototypeFunctionTestWorkerPromise): Deleted.
(WebCore::jsTestNodePrototypeFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestNodePrototypeFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestNodePrototypeFunctionTestFeatureGetSecretBoolean): Deleted.
(WebCore::jsTestNodePrototypeFunctionToJSON): Deleted.
(WebCore::jsTestNodePrototypeFunctionEntries): Deleted.
(WebCore::jsTestNodePrototypeFunctionKeys): Deleted.
(WebCore::jsTestNodePrototypeFunctionValues): Deleted.
(WebCore::jsTestNodePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjConstructor):
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjConstructorTestStaticReadonlyObj):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::setJSTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::setJSTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::jsTestObjClampedShortAttr):
(WebCore::setJSTestObjClampedShortAttr):
(WebCore::jsTestObjEnforceRangeShortAttr):
(WebCore::setJSTestObjEnforceRangeShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::jsTestObjUsvstringAttr):
(WebCore::setJSTestObjUsvstringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::setJSTestObjTestNullableObjAttr):
(WebCore::jsTestObjLenientTestObjAttr):
(WebCore::setJSTestObjLenientTestObjAttr):
(WebCore::jsTestObjUnforgeableAttr):
(WebCore::jsTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjUsvstringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjUsvstringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjByteStringAttrTreatingNullAsEmptyString):
(WebCore::setJSTestObjByteStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjStringLongRecordAttr):
(WebCore::setJSTestObjStringLongRecordAttr):
(WebCore::jsTestObjUsvstringLongRecordAttr):
(WebCore::setJSTestObjUsvstringLongRecordAttr):
(WebCore::jsTestObjStringObjRecordAttr):
(WebCore::setJSTestObjStringObjRecordAttr):
(WebCore::jsTestObjStringNullableObjRecordAttr):
(WebCore::setJSTestObjStringNullableObjRecordAttr):
(WebCore::jsTestObjStringVoidCallbackRecordAttr):
(WebCore::setJSTestObjStringVoidCallbackRecordAttr):
(WebCore::jsTestObjDictionaryAttr):
(WebCore::setJSTestObjDictionaryAttr):
(WebCore::jsTestObjNullableDictionaryAttr):
(WebCore::setJSTestObjNullableDictionaryAttr):
(WebCore::jsTestObjAnnotatedTypeInUnionAttr):
(WebCore::setJSTestObjAnnotatedTypeInUnionAttr):
(WebCore::jsTestObjAnnotatedTypeInSequenceAttr):
(WebCore::setJSTestObjAnnotatedTypeInSequenceAttr):
(WebCore::jsTestObjImplementationEnumAttr):
(WebCore::setJSTestObjImplementationEnumAttr):
(WebCore::jsTestObjMediaDevices):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::setJSTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedUSVStringAttr):
(WebCore::setJSTestObjReflectedUSVStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedUSVURLAttr):
(WebCore::setJSTestObjReflectedUSVURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjEnabledAtRuntimeAttribute):
(WebCore::setJSTestObjEnabledAtRuntimeAttribute):
(WebCore::jsTestObjConstructorEnabledAtRuntimeAttributeStatic):
(WebCore::setJSTestObjConstructorEnabledAtRuntimeAttributeStatic):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::jsTestObjCustomAttr):
(WebCore::setJSTestObjCustomAttr):
(WebCore::jsTestObjOnfoo):
(WebCore::setJSTestObjOnfoo):
(WebCore::jsTestObjOnwebkitfoo):
(WebCore::setJSTestObjOnwebkitfoo):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::setJSTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjCachedAttribute3):
(WebCore::jsTestObjAnyAttribute):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::jsTestObjObjectAttribute):
(WebCore::setJSTestObjObjectAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::setJSTestObjMutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::setJSTestObjStrawberry):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::setJSTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::setJSTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringSettableAttribute):
(WebCore::setJSTestObjNullableStringSettableAttribute):
(WebCore::jsTestObjNullableUSVStringSettableAttribute):
(WebCore::setJSTestObjNullableUSVStringSettableAttribute):
(WebCore::jsTestObjNullableByteStringSettableAttribute):
(WebCore::setJSTestObjNullableByteStringSettableAttribute):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::setJSTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjTestReadOnlyVoidPromiseAttribute):
(WebCore::jsTestObjTestReadOnlyPromiseAttribute):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::setJSTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::setJSTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjStringifierAttribute):
(WebCore::setJSTestObjStringifierAttribute):
(WebCore::jsTestObjConditionallyExposedToWindowAttribute):
(WebCore::setJSTestObjConditionallyExposedToWindowAttribute):
(WebCore::jsTestObjConditionallyExposedToWorkerAttribute):
(WebCore::setJSTestObjConditionallyExposedToWorkerAttribute):
(WebCore::jsTestObjConditionallyExposedToWindowAndWorkerAttribute):
(WebCore::setJSTestObjConditionallyExposedToWindowAndWorkerAttribute):
(WebCore::callJSTestObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionEnabledAtRuntimeOperationStatic): Deleted.
(WebCore::jsTestObjPrototypeFunctionEnabledInSpecificWorldWhenRuntimeFeatureEnabled): Deleted.
(WebCore::jsTestObjPrototypeFunctionWorldSpecificMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionCalculateSecretResult): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetSecretBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestFeatureGetSecretBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionUndefinedMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionUndefinedMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionByteMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionOctetMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionLongMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionObjMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Deleted.
(WebCore::jsTestObjInstanceFunctionUnforgeableMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithXPathNSResolverParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionNullableStringMethod): Deleted.
(WebCore::jsTestObjConstructorFunctionNullableStringStaticMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionNullableStringSpecialMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithStandaloneEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalEnumArgAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableUSVStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUSVStringArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNullableByteStringArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithByteStringArgTreatingNullAsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithRecord): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithExceptionReturningLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithExceptionReturningObject): Deleted.
(WebCore::jsTestObjPrototypeFunctionCustomMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionPrivateMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionPublicAndPrivateMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Deleted.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithDocumentArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithCallerDocumentArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithCallerWindowArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArgAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringAndDefaultValue): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUSVStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAtomStringIsEmptyString): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalDoubleIsNaN): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalFloatIsNaN): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalLongLongIsZero): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLong): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalUnsignedLongLongIsZero): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmpty): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBoolean): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalBooleanIsFalse): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalAny): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalObject): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapper): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapperIsNull): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalXPathNSResolver): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalRecord): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalPromise): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackFunctionArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackFunctionAndOptionalArg): Deleted.
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg): Deleted.
(WebCore::jsTestObjConstructorFunctionStaticMethodWithCallbackArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithDistinguishingUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWith2DistinguishingUnions): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithNonDistinguishingUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithOptionalUnion): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadWithNullableNonDistinguishingParameter): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethod): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Deleted.
(WebCore::jsTestObjConstructorFunctionClassMethod2): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampOnOptional): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRange): Deleted.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeOnOptional): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionOperationWithOptionalUnionParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodWithAndWithoutNullableSequence): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetElementById): Deleted.
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert1): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert2): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert3): Deleted.
(WebCore::jsTestObjPrototypeFunctionConvert4): Deleted.
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionOrange): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionVariadicUnionMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionAny): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithFloatArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithOptionalIntArgument): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestCustomPromiseFunction): Deleted.
(WebCore::jsTestObjConstructorFunctionTestStaticCustomPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestCustomReturnsOwnPromiseFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnsOwnPromiseAndPromiseProxyFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionalOverload): Deleted.
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload): Deleted.
(WebCore::jsTestObjPrototypeFunctionAttachShadowRoot): Deleted.
(WebCore::jsTestObjPrototypeFunctionOperationWithExternalDictionaryParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionBufferSourceParameter): Deleted.
(WebCore::jsTestObjPrototypeFunctionLegacyCallerNamed): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimization): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestReturnValueOptimizationWithException): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWorkerFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionConditionallyExposedToWindowAndWorkerFunction): Deleted.
(WebCore::jsTestObjPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestOperationConditional.cpp:

(WebCore::jsTestOperationConditionalConstructor):
(WebCore::setJSTestOperationConditionalConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestOperationConditionalPrototypeFunctionNonConditionalOperation): Deleted.
(WebCore::jsTestOperationConditionalPrototypeFunctionConditionalOperation): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::jsTestOverloadedConstructorsConstructor):
(WebCore::setJSTestOverloadedConstructorsConstructor):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::construct):
(WebCore::jsTestOverloadedConstructorsWithSequenceConstructor):
(WebCore::setJSTestOverloadedConstructorsWithSequenceConstructor):

  • bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::jsTestPluginInterfaceConstructor):
(WebCore::setJSTestPluginInterfaceConstructor):

  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::JSTestPromiseRejectionEventConstructor::construct):
(WebCore::jsTestPromiseRejectionEventConstructor):
(WebCore::setJSTestPromiseRejectionEventConstructor):
(WebCore::jsTestPromiseRejectionEventPromise):
(WebCore::jsTestPromiseRejectionEventReason):

  • bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp:

(WebCore::jsTestReadOnlyMapLikeConstructor):
(WebCore::setJSTestReadOnlyMapLikeConstructor):
(WebCore::jsTestReadOnlyMapLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionGet): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestReadOnlyMapLikePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp:

(WebCore::jsTestReadOnlySetLikeConstructor):
(WebCore::setJSTestReadOnlySetLikeConstructor):
(WebCore::jsTestReadOnlySetLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestReadOnlySetLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestReadOnlySetLikePrototypeFunctionForEach): Deleted.

  • bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp:

(WebCore::jsTestReportExtraMemoryCostConstructor):
(WebCore::setJSTestReportExtraMemoryCostConstructor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionFunction): Deleted.
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionFunctionReturning): Deleted.

  • bindings/scripts/test/JS/JSTestSetLike.cpp:

(WebCore::jsTestSetLikeConstructor):
(WebCore::setJSTestSetLikeConstructor):
(WebCore::jsTestSetLikeSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSetLikePrototypeFunctionHas): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionEntries): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionKeys): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionValues): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionForEach): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionAdd): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionClear): Deleted.
(WebCore::jsTestSetLikePrototypeFunctionDelete): Deleted.

  • bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp:

(WebCore::jsTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::setJSTestSetLikeWithOverriddenOperationsConstructor):
(WebCore::jsTestSetLikeWithOverriddenOperationsAdd):
(WebCore::setJSTestSetLikeWithOverriddenOperationsAdd):
(WebCore::jsTestSetLikeWithOverriddenOperationsSize):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionDelete): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionHas): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionEntries): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionKeys): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionValues): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionForEach): Deleted.
(WebCore::jsTestSetLikeWithOverriddenOperationsPrototypeFunctionClear): Deleted.

  • bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::jsTestStringifierConstructor):
(WebCore::setJSTestStringifierConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::jsTestStringifierAnonymousOperationConstructor):
(WebCore::setJSTestStringifierAnonymousOperationConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierAnonymousOperationPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::jsTestStringifierNamedOperationConstructor):
(WebCore::setJSTestStringifierNamedOperationConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierNamedOperationPrototypeFunctionIdentifier): Deleted.
(WebCore::jsTestStringifierNamedOperationPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::jsTestStringifierOperationImplementedAsConstructor):
(WebCore::setJSTestStringifierOperationImplementedAsConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierOperationImplementedAsPrototypeFunctionIdentifier): Deleted.
(WebCore::jsTestStringifierOperationImplementedAsPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::jsTestStringifierOperationNamedToStringConstructor):
(WebCore::setJSTestStringifierOperationNamedToStringConstructor):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierOperationNamedToStringPrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::jsTestStringifierReadOnlyAttributeConstructor):
(WebCore::setJSTestStringifierReadOnlyAttributeConstructor):
(WebCore::jsTestStringifierReadOnlyAttributeIdentifier):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierReadOnlyAttributePrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::jsTestStringifierReadWriteAttributeConstructor):
(WebCore::setJSTestStringifierReadWriteAttributeConstructor):
(WebCore::jsTestStringifierReadWriteAttributeIdentifier):
(WebCore::setJSTestStringifierReadWriteAttributeIdentifier):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestStringifierReadWriteAttributePrototypeFunctionToString): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::jsTestTypedefsConstructor):
(WebCore::setJSTestTypedefsConstructor):
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsSerializedScriptValue):
(WebCore::setJSTestTypedefsSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsAttributeWithClamp):
(WebCore::setJSTestTypedefsAttributeWithClamp):
(WebCore::jsTestTypedefsAttributeWithClampInTypedef):
(WebCore::setJSTestTypedefsAttributeWithClampInTypedef):
(WebCore::jsTestTypedefsBufferSourceAttr):
(WebCore::setJSTestTypedefsBufferSourceAttr):
(WebCore::jsTestTypedefsDomTimeStampAttr):
(WebCore::setJSTestTypedefsDomTimeStampAttr):
(WebCore::JSC_DEFINE_HOST_FUNCTION):
(WebCore::jsTestTypedefsPrototypeFunctionFunc): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionSequenceOfNullablesArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfNullablesArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionNullableSequenceOfUnionsArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionUnionArg): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampInTypedef): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionPointFunction): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionStringSequenceFunction): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionStringSequenceFunction2): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude): Deleted.
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithException): Deleted.

  • bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:

(WebCore::jsWorkerGlobalScopeConstructor):
(WebCore::setJSWorkerGlobalScopeConstructor):
(WebCore::jsWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::setJSWorkerGlobalScopeExposedToWorkerAndWindowConstructor):
(WebCore::jsWorkerGlobalScopeTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::setJSWorkerGlobalScopeTestDefaultToJSONFilteredByExposedConstructor):
(WebCore::jsWorkerGlobalScopeTestNodeConstructor):
(WebCore::setJSWorkerGlobalScopeTestNodeConstructor):
(WebCore::jsWorkerGlobalScopeTestObjectConstructor):
(WebCore::setJSWorkerGlobalScopeTestObjectConstructor):
(WebCore::jsWorkerGlobalScopeTestPromiseRejectionEventConstructor):
(WebCore::setJSWorkerGlobalScopeTestPromiseRejectionEventConstructor):

  • bindings/scripts/test/JS/JSWorkletGlobalScope.cpp:

(WebCore::jsWorkletGlobalScopeConstructor):
(WebCore::setJSWorkletGlobalScopeConstructor):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::JSC_DEFINE_HOST_FUNCTION):
(JSC::Bindings::callObjCFallbackObject): Deleted.

  • bridge/runtime_array.cpp:

(JSC::arrayLengthGetter):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::lengthGetter): Deleted.

  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:

(JSC::methodLengthGetter):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::RuntimeMethod::lengthGetter): Deleted.
(JSC::callRuntimeMethod): Deleted.

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::fallbackObjectGetter):
(JSC::Bindings::fieldGetter):
(JSC::Bindings::methodGetter):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::JSC_DEFINE_HOST_FUNCTION):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):
(JSC::Bindings::throwRuntimeObjectInvalidAccessError):
(JSC::Bindings::RuntimeObject::fallbackObjectGetter): Deleted.
(JSC::Bindings::RuntimeObject::fieldGetter): Deleted.
(JSC::Bindings::RuntimeObject::methodGetter): Deleted.
(JSC::Bindings::callRuntimeObject): Deleted.
(JSC::Bindings::callRuntimeConstructor): Deleted.
(JSC::Bindings::RuntimeObject::throwInvalidAccessError): Deleted.

  • bridge/runtime_object.h:

Source/WebKit:

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::JSC_DEFINE_HOST_FUNCTION):
(WebKit::callMethod): Deleted.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSC_DEFINE_HOST_FUNCTION):
(WebKit::callNPJSObject): Deleted.
(WebKit::constructWithConstructor): Deleted.

Source/WTF:

Rename JSC_HOST_CALL to JSC_HOST_CALL_ATTRIBUTE, and introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION.
We also introduce JSC_ANNOTATE_HOST_FUNCTION if the function is not defined as free-function[1].

[1]: https://stackoverflow.com/questions/4861914/what-is-the-meaning-of-the-term-free-function-in-c

  • wtf/PlatformCallingConventions.h:
2:29 PM Changeset in webkit [267593] by Chris Dumez
  • 7 edits
    1 delete in trunk

Unreviewed, reverting r267589.

Broke document.visibilityState when coming out of back/forward
cache

Reverted changeset:

"visibilitychange:hidden doesn't fire during page navigations"
https://bugs.webkit.org/show_bug.cgi?id=151234
https://trac.webkit.org/changeset/267589

2:26 PM Changeset in webkit [267592] by graouts@webkit.org
  • 18 edits in trunk

Add an experimental feature flag for CSS individual transform properties
https://bugs.webkit.org/show_bug.cgi?id=216271
<rdar://problem/68914539>

Reviewed by Dean Jackson.

Source/WebCore:

  • page/Settings.yaml:

Source/WebKit:

  • Shared/WebPreferencesExperimental.yaml:

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
(-[WebPreferences cssIndividualTransformPropertiesEnabled]):
(-[WebPreferences CSSIndividualTransformPropertiesEnabled]):

  • WebView/WebPreferencesExperimental.yaml:
  • WebView/WebPreferencesPrivate.h:

Source/WebKitLegacy/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::CSSIndividualTransformPropertiesEnabled):
(WebPreferences::setCSSIndividualTransformPropertiesEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

1:36 PM Changeset in webkit [267591] by Chris Dumez
  • 21 edits in trunk/Source

Get rid of AudioNode::RefType
https://bugs.webkit.org/show_bug.cgi?id=216945

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CachedTypes.cpp:

(JSC::CachedRefPtr::decode const):

Source/WebCore:

Previously, the node had ref()/deref() function taking a RefType parameter.
The RefType would be used to determine which counter should be incremented
or decremented: either m_normalRefCount or m_connectionRefCount.

In a previous patch, I have already ported code that was calling ref() / deref()
explicitly with RefTypeNormal to use RefPtr<> instead. This patch goes further by:

  1. Dropping the RefType parameter to ref() / deref(). ref() / deref() now increment or decrement m_normalRefCount only. Clients are expected to use RefPtr to handle ref counting.
  2. Introduce new incrementConnectionCount() / decrementConnectionCount() to increment or decrement m_connectionRefCount. To reduce the chance of leakage, clients should not call these functions directly anymore. Instead, they use use the new AudioConnectionRefPtr<> pointer type to handle the connection ref counting for them. AudioConnectionRefPtr<> is a RefPtr<> which special traits causing incrementConnectionCount() and decrementConnectionCount() to get called on the AudioNode instead of ref() and deref().

I believe this new design is a bit simpler to reason about and less prone to leaks.
There is no longer any code explicitly ref'ing or deref'ing the AudioNodes. Instead,
RefPtr<> or AudioConnectionRefPtr<> is used to increment/decrement the right internal
count.

No new tests, no Web-facing behavior change.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setPannerNode):
(WebCore::AudioBufferSourceNode::clearPannerNode):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::disableOutputsIfNecessary):
(WebCore::AudioNode::incrementConnectionCount):
(WebCore::AudioNode::decrementConnectionCount):
(WebCore::AudioNode::decrementConnectionCountWithLock):
(WebCore::AudioNode::markNodeForDeletionIfNecessary):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::derefWithLock):

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNodeConnectionRefDerefTraits::refIfNotNull):
(WebCore::AudioNodeConnectionRefDerefTraits::derefIfNotNull):

  • Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::connect):
(WebCore::AudioNodeInput::disconnect):

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::propagateChannelCount):
(WebCore::AudioNodeOutput::addInput):
(WebCore::AudioNodeOutput::disconnectAllInputs):
(WebCore::AudioNodeOutput::disable):
(WebCore::AudioNodeOutput::enable):

  • Modules/webaudio/AudioNodeOutput.h:
  • Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::~BaseAudioContext):
(WebCore::BaseAudioContext::refNode):
(WebCore::BaseAudioContext::derefNode):
(WebCore::BaseAudioContext::derefUnfinishedSourceNodes):
(WebCore::BaseAudioContext::addDeferredDecrementConnectionCount):
(WebCore::BaseAudioContext::handlePostRenderTasks):
(WebCore::BaseAudioContext::handleDeferredDecrementConnectionCounts):

  • Modules/webaudio/BaseAudioContext.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::process):

Source/WTF:

Add third template parameter to RefPtr allowing to define the traits
from incrementing / decrementing the refcount. The default traits
call ref() / deref() but this can now be customized to call other
functions.

  • wtf/CompactRefPtrTuple.h:
  • wtf/Forward.h:
  • wtf/RefPtr.h:

(WTF::DefaultRefDerefTraits::refIfNotNull):
(WTF::DefaultRefDerefTraits::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):
(WTF::V>::RefPtr):
(WTF::V>::leakRef):
(WTF::=):
(WTF::V>::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::static_pointer_cast):
(WTF::adoptRef):
(WTF::is):

1:19 PM Changeset in webkit [267590] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Simplify SVGTests.hasExtension idl
https://bugs.webkit.org/show_bug.cgi?id=216984

Patch by Rob Buis <rbuis@igalia.com> on 2020-09-25
Reviewed by Sam Weinig.

Simplify SVGTests.hasExtension idl by removing optional and default parameter.
Skipping the parameter will now result in the parameter being a null string,
which gives the same behaviour as before as the method just checks
against non null namespaces.

[1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension

  • page/DOMWindow.idl:
  • svg/SVGTests.idl:
1:11 PM Changeset in webkit [267589] by Chris Dumez
  • 7 edits
    30 adds in trunk

visibilitychange:hidden doesn't fire during page navigations
https://bugs.webkit.org/show_bug.cgi?id=151234
<rdar://problem/23688763>

Reviewed by Darin Adler and Ryosuke Niwa.

LayoutTests/imported/w3c:

Import page-visibility WPT tests from upstream.

  • resources/import-expectations.json:
  • web-platform-tests/page-visibility/*: Added.

Source/WebCore:

Fire a visibilitychange during document unload, as per the specification:

Tests: imported/w3c/web-platform-tests/page-visibility/idlharness.window.html

imported/w3c/web-platform-tests/page-visibility/iframe-unload.html
imported/w3c/web-platform-tests/page-visibility/onvisibilitychange.html
imported/w3c/web-platform-tests/page-visibility/test_attributes_exist.html
imported/w3c/web-platform-tests/page-visibility/test_child_document.html
imported/w3c/web-platform-tests/page-visibility/test_default_view.html
imported/w3c/web-platform-tests/page-visibility/test_read_only.html
imported/w3c/web-platform-tests/page-visibility/unload-bubbles.html
imported/w3c/web-platform-tests/page-visibility/unload.html

  • dom/Document.cpp:

(WebCore::Document::visibilityState const):

  • dom/Document.h:

(WebCore::Document::setIsUnloadingOrUnloaded):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):

12:49 PM Changeset in webkit [267588] by Fujii Hironori
  • 7 edits in trunk

make_names.pl no longer needs C preprocessor
https://bugs.webkit.org/show_bug.cgi?id=216953

Reviewed by Sam Weinig.

.:

  • Source/cmake/WebKitCompilerFlags.cmake: Removed CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS which was used only for make_names.pl.

Source/WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCoreMacros.cmake: Changed GENERATE_DOM_NAMES from a macro to a function so that list(POP_FRONT ARGN var) works as exepected.
  • dom/make_names.pl: Removed --preprocessor and --extraDefines options.

(readNames):
(readAttrs):
(readTags):
(buildConstructorMap):
(printConstructorSignature):
(printConstructorInterior):
(printConstructors):
(printFunctionTable):
(printJSElementIncludes):
(printElementIncludes):
(printConditionalElementIncludes):
(usesDefaultJSWrapper):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(preprocessorCommand): Deleted.

12:03 PM Changeset in webkit [267587] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][MarginCollapsing] Only inflow boxes collapse their quirk margins with their parents
https://bugs.webkit.org/show_bug.cgi?id=216981

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::shouldCollapseMarginBeforeWithParentMarginBefore const):

LayoutTests:

  • fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating-expected.html: Added.
  • fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html: Added.
12:03 PM Changeset in webkit [267586] by wenson_hsieh@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r267516): --use-gpu-process no longer enables GPU process when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=216980

Reviewed by Tim Horton.

Rename UseGPUProcessForMedia and RenderCanvasInGPUProcessEnabled, and additionally enable a few internal
feature flags: UseGPUProcessForWebGLEnabled, UseGPUProcessForDOMRenderingEnabled, and
CaptureVideoInGPUProcessEnabled.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

11:21 AM Changeset in webkit [267585] by Alan Coon
  • 6 edits
    1 add in branches/safari-610-branch

Cherry-pick r266813. rdar://problem/69582551

OutOfBoundsSaneChain operations should use their own heap locations
https://bugs.webkit.org/show_bug.cgi?id=216328
<rdar://problem/68568039>

Reviewed by Keith Miller.

JSTests:

  • stress/out-of-bounds-sane-chain-need-their-own-heap-location.js: Added. (foo):

Source/JavaScriptCore:

There is code in local CSE that does some basic bounds check elimination
for PutByVal. It does this analysis by seeing if a particular heap location
is already defined, and if so, it eliminates the bounds check for the
PutByVal. This doesn't work for OutOfBoundsSaneChain for the obvious reason
that these GetByVals are not proven to be in bounds. So GetByVal's in the
OutOfBoundsSaneChain mode reusing non OutOfBoundsSaneChain heap locations
can lead to a bug where we mistakenly remove a bounds check. The fix is to
have all OutOfBoundsSaneChain operations use distinct heaps, and for CSE to
not query those heaps.

  • dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::isAnySaneChain const): Deleted.
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGHeapLocation.cpp: (WTF::printInternal):
  • dfg/DFGHeapLocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [267584] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r267106. rdar://problem/69381319

CRASH: Exception thrown from -[AVContentKeyRequest makeStreamingContentKeyRequestDataForApp:contentIdentifier:options:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=216580
<rdar://problem/68866834>

Reviewed by Eric Carlson.

Protect against undocumented exceptions thrown from AVContentKeySession (and related) APIs by wrapping in @try/@catch blocks and firing
the correct failure callbacks if an exception is encountered.

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [267583] by Alan Coon
  • 2 edits in branches/safari-610-branch/LayoutTests

Cherry-pick r266765. rdar://problem/69382910

[ macOS iOS ] svg/animations/smil-leak-element-instances-noBaseValRef.svg is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215353

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-08
Reviewed by Geoffrey Garen.

This patch reverts r265780 and goes in the opposite direction: allocating
lots and lots of objects, then proving that the number of live objects
did not grow a lot.

GCController can be conservative sometimes and leaves some objects here
and there. So we should not be checking that *all* the objects were freed
to verify there was no leak in allocating the SVG properties objects.

Instead we can check for an end-to-end test the memory did not grow a lot
despite the huge number of allocations.

  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [267582] by Alan Coon
  • 3 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266689. rdar://problem/69382883

[MotionMark - Multiply] Web process spends ~1% of total samples in PropertyCascade::resolveDirectionAndWritingMode
https://bugs.webkit.org/show_bug.cgi?id=216223

Reviewed by Darin Adler.

A few subtests in MotionMark (Leaves, Focus, Design, and especially Multiply) spend large amounts of time in
style resolution (Document::resolveStyle) due to constant style changes across many elements during every
frame. In Multiply, ~3-4% of the time underneath Document::resolveStyle is spent resolving direction and
writing modes inside PropertyCascade::resolveDirectionAndWritingMode (i.e., ~2.3 million invocations). This
helper function is responsible for computing the text direction and CSS writing mode that is used to resolve
direction-aware CSS properties (which are enumerated in CSSProperty::isDirectionAwareProperty). Resolving the
direction and writing mode involves iterating over all of the matched CSS properties (m_matchResult) in the
property cascade in search of CSS properties for writing and direction, which can be relatively expensive when
there are lots of properties in the cascade.

However, if there are no direction-aware CSS properties in the cascade, this work can actually be elided; to
achieve this, we can store the inherited Direction in m_direction, and then lazily resolve it if needed.

I measured this locally to yield a little under ~1% in the Multiply subtest in MotionMark. Otherwise, there is
no change in behavior; see below for more details.

  • style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::PropertyCascade): (WebCore::Style::PropertyCascade::set):

If we encounter a direction-aware CSS property, then use direction() to ensure that the direction and writing
mode are resolved.

(WebCore::Style::PropertyCascade::direction const):

Make this getter call resolveDirectionAndWritingMode if needed.

  • style/PropertyCascade.h:

Add a new bool member to keep track of whether or not the CSS direction has not yet been resolved. Note that
since this member variable fits within the padding after Direction m_direction;, this class is still the same
size.

(WebCore::Style::PropertyCascade::direction const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [267581] by Alan Coon
  • 4 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266353. rdar://problem/69382920

Optimize the implementation of TransformationMatrix::rotate(double)
https://bugs.webkit.org/show_bug.cgi?id=215994

Reviewed by Tim Horton.

TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which
has a fast path for the case where we're rotating about the z-axis. However, we can make this *slightly* faster
by omitting the hypotenuse computation, several floating point comparisons, and several assignments in this case
because we already know that we're just rotating about the z-axis.

This is a small (but measurable) improvement on the Multiply subtest of MotionMark, which applies a little over
3 million rotation transformations over the course of 30 seconds.

  • platform/graphics/transforms/RotateTransformOperation.h:

Instead of calling rotate3d, just have rotate directly call multiply with the following
TransformationMatrix:
`
[[ cos(z) sin(z) 0 0 ]

[ -sin(z) cos(z) 0 0 ]
[ 0 0 1 0 ]
[ 0 0 0 1 ]]

`
...where z is the angle of rotation, in radians.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rotate):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::rotate): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:20 AM Changeset in webkit [267580] by Alan Coon
  • 2 edits in branches/safari-610-branch/Source/WebCore

Cherry-pick r266198. rdar://problem/69382901

Avoid unnecessarily copying a Vector in WebCore::transformsForValue
https://bugs.webkit.org/show_bug.cgi?id=215858

Reviewed by Tim Horton.

Avoid copying the Vector of TransformOperations in this helper function by directly appending newly created
transform operations to the given TransformOperations. This does, however, mean that we need to clear these
items in the case where conversion fails and we return false.

  • css/TransformFunctions.cpp: (WebCore::transformsForValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:55 AM Changeset in webkit [267579] by Jonathan Bedard
  • 5 edits
    1 add in trunk/Tools

results.webkit.org: Use s3 for cold storage
https://bugs.webkit.org/show_bug.cgi?id=216662
<rdar://problem/69092010>

Rubber-stamped by Aakash Jain.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py:
  • Scripts/libraries/resultsdbpy/resultsdbpy/model/archive_context.py:

(ArchiveContext.init): Differentiate between cache storage and long-term storage of archives.
(ArchiveContext.enter): Connect to the cold storage archive, if one is available.
(ArchiveContext.exit): Disconnect from the cold storage archive, if applicable.
(ArchiveContext.register): Save to cold storage instead of cache storage by default.
(ArchiveContext.find_archive):

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/model.py:

(Model.init): Pass S3 credentials to ArchiveContext.

  • Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py: Added.

(S3Archiver):
(S3Archiver.Credentials):
(S3Archiver.init): Connect to S3 and configure our bucket.
(S3Archiver._cipher): Construct new AES cipher, if a key was provided.
(S3Archiver.enter): Create S3 resource, if one is not available.
(S3Archiver.exit): Teardown S3 resource.
(S3Archiver.save): Save an archive to S3 by it's hash.
(S3Archiver.retrieve): Retreive an archive from S3 by its hash.

  • Scripts/libraries/resultsdbpy/setup.py: Add boto3.
10:47 AM Changeset in webkit [267578] by commit-queue@webkit.org
  • 54 edits
    2 copies
    4 adds
    16 deletes in trunk

Bug 216702 - Implement the CSS math-style property
https://bugs.webkit.org/show_bug.cgi?id=216702

Patch by Frederic Wang <fwang@igalia.com> on 2020-09-25
Reviewed by Rob Buis.

LayoutTests/imported/w3c:

Rebaseline tests to take into account new PASS results.

  • web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt:
  • web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt:
  • web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt:
  • web-platform-tests/mathml/relations/css-styling/displaystyle-2-expected.txt:
  • web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.

Source/WebCore:

This patch implements the math-style property [1][2] and uses it to map MathML's displaystyle
attribute to style, instead of using an internal inheritance mechanism. In addition, four
changes are made to improve the MathML implementation:

  • Support for the displaystyle attribute on all the MathML elements.
  • Better handling of dynamic update of displaystyle.
  • RenderMathMLUnderOver uses its own displaystyle (rather than the one of the core operator

at its base in order) to determine whether to move its under/over scripts.

  • display/displaystyle are made case-insensitive.

[1] https://mathml-refresh.github.io/mathml-core/#the-math-style-property
[2] https://github.com/w3c/csswg-drafts/issues/5387

No new tests, already covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator MathStyle const):

  • css/CSSProperties.json:
  • css/CSSValueKeywords.in:
  • css/mathml.css: Implement displaystyle rules using math-style.
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPresentationAttribute const):
(WebCore::MathMLElement::collectStyleForPresentationAttribute):

  • mathml/MathMLElement.h:
  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::parseAttribute):

  • mathml/MathMLMathElement.h:
  • mathml/MathMLPresentationElement.cpp:

(WebCore::MathMLPresentationElement::parseAttribute):

  • mathml/MathMLPresentationElement.h:
  • mathml/MathMLRowElement.cpp:
  • mathml/MathMLRowElement.h:
  • mathml/MathMLSpaceElement.h:
  • mathml/MathMLTokenElement.h:
  • rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::updateStyleIfNeeded):
(WebCore::MathMLStyle::resolveMathMLStyle):

  • rendering/mathml/MathMLStyle.h:
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::styleDidChange):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::fractionParameters const):
(WebCore::RenderMathMLFraction::stackParameters const):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::styleDidChange):

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::isLargeOperatorInDisplayStyle const):
(WebCore::RenderMathMLOperator::shouldMoveLimits const):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::verticalParameters):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::shouldMoveLimits):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::mathStyle const):
(WebCore::RenderStyle::setMathStyle):
(WebCore::RenderStyle::initialMathStyle):

  • rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

Rebaseline tests to take into account new PASS results.

  • TestExpectations:
  • mathml/opentype/large-operators-displaystyle-dynamic.html: Do the dynamic change directly

after page load but do a requestAnimationFrame before completing the test.

  • platform/glib/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
  • platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Copied from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt.
  • platform/ios-13/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Removed.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
10:42 AM Changeset in webkit [267577] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: null is not an object (evaluating 'this.listItemElement.classList')
https://bugs.webkit.org/show_bug.cgi?id=216307
<rdar://problem/68565824>

Reviewed by Brian Burg.

  • UserInterface/Views/DOMTreeUpdater.js:

(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
Don't update the element if it hasn't been attached yet. It will use the latest data when attached.

10:19 AM Changeset in webkit [267576] by Darin Adler
  • 43 edits
    4 adds in trunk

Add CSSConditionRule and CSSGroupingRule
https://bugs.webkit.org/show_bug.cgi?id=216855

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/css/conditional/idlharness-expected.txt:
  • web-platform-tests/css/cssom/MediaList-expected.txt:
  • web-platform-tests/css/cssom/cssimportrule-expected.txt:
  • web-platform-tests/css/cssom/idlharness-expected.txt:

Updated expectations to expect more tests to pass.

Source/WebCore:

  • CMakeLists.txt: Added CSSConditionRule.idl and CSSGroupingRule.idl.
  • DerivedSources-input.xcfilelist: Updated.
  • DerivedSources-output.xcfilelist: Updated.
  • DerivedSources.make: Added CSSConditionRule.idl and CSSGroupingRule.idl.
  • Headers.cmake: Added CSSConditionRule.h.
  • Sources.txt: Add CSSConditionRule.cpp, JSCSSConditioRule.cpp,

and JSCSSGroupingRule.cpp.

  • WebCore.xcodeproj/project.pbxproj: Added all the files.
  • css/CSSConditionRule.cpp: Added.
  • css/CSSConditionRule.h: Added.
  • css/CSSConditionRule.idl: Added.
  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::~CSSGroupingRule): Use a range-based for loop
and nullptr.
(WebCore::CSSGroupingRule::appendCSSTextForItems const): Use variadic
append to clean this up a bit.
(WebCore::CSSGroupingRule::item const): Use auto.

  • css/CSSGroupingRule.h: Made m_groupRule private instead of protected.

Did some other tweaks.

  • css/CSSGroupingRule.idl: Added.
  • css/CSSImportRule.idl: Added [Exposed=Window], changed href to be a

USVString, added [SameObject, PutForwards=mediaText] to media
and [SameObject] to styleSheet.

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule): Derive from CSSConditionRule.
(WebCore::CSSMediaRule::mediaQueries const): Return a reference.
(WebCore::CSSMediaRule::cssText const): Streamline since we don't need a
null check.
(WebCore::CSSMediaRule::conditionText const): Added.
(WebCore::CSSMediaRule::setConditionText): Added.
(WebCore::CSSMediaRule::media const): Streamline since we don't need a
null check.
(WebCore::CSSMediaRule::reattach): Ditto.

  • css/CSSMediaRule.h: Derive from CSSConditionRule.
  • css/CSSMediaRule.idl: Derive from CSSConditionRule. Added

[Exposed=Window]. Added [SameObject, PutForwards=mediaText] to media.
Removed insertRule and deleteRule since they are now inherited from
CSSGroupingRule.

  • css/CSSRule.h: Added MARGIN_RULE constant even though we don't have

that rule type. Moved inline functions out of the class body to help
clarity a bit.

  • css/CSSRule.idl: Added [Exposed=Window], changed a few things to match

the specification.

  • css/CSSStyleRule.idl: Added [Exposed=Window]. Added [SameObject]

to style.

  • css/CSSStyleSheet.idl: Added [Exposed=Window].
  • css/CSSSupportsRule.cpp:

(WebCore::CSSSupportsRule::CSSSupportsRule): Derive from CSSConditionRule.
(WebCore::CSSSupportsRule::create): Added.
(WebCore::CSSSupportsRule::cssText const): Use variadic append.
(WebCore::CSSSupportsRule::conditionText const): Updated to use groupRule.
(WebCore::CSSSupportsRule::setConditionText): Added. Not implemented yet.

  • css/CSSSupportsRule.h: Derive from CSSConditionRule.
  • css/CSSSupportsRule.idl: Derive from CSSConditionRule.

Added [Exposed=Window].

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::set): Use move instead of swap.

  • css/MediaList.idl: Added [Exposed=Window] and marked mediaText as

the stringifier.

  • css/StyleRule.cpp:

(WebCore::StyleRule::create): Moved here from the header.
(WebCore::StyleRule::copy const): Ditto.
(WebCore::StyleRulePage::create): Ditto.
(WebCore::StyleRuleGroup::StyleRuleGroup): Use move instead of swap.
(WebCore::StyleRuleMedia::create): Use move instead of swap.
(WebCore::StyleRuleMedia::copy const): Moved out of the header.
(WebCore::StyleRuleSupports::StyleRuleSupports): Ditto.
(WebCore::StyleRuleSupports::create): Ditto.
(WebCore::StyleRuleNamespace::StyleRuleNamespace): Ditto.
(WebCore::StyleRuleNamespace::create): Ditto.

  • css/StyleRule.h: Moved function bodies out of the class

defintiion for clarity.

  • css/StyleSheet.idl: Added [Exposed=Window] and

[SameObject, PutForwards=mediaText] for media.

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule): Updated since
mediaQueries returns a reference.

  • css/StyleSheetList.idl: Added [Exposed=Window].
  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeMediaRule): Use WTFMove since
the create function now takes an rvalue reference.
(WebCore::CSSParserImpl::consumeSupportsRule): Ditto.

  • style/RuleSet.cpp:

(WebCore::Style::RuleSet::addChildRules): Updated since mediaQueries
returns a reference.

  • style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::addToDefaultStyle): Ditto.

Source/WebKitLegacy/mac:

  • DOM/DOMCSS.mm:

(kitClass): Added a default case since we don't intend to list every single rule type here.

LayoutTests:

  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/domListEnumeration.html:

Updated since toString is now implemented and enumerable.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/non-numeric-values-numeric-parameters.html:

Updated test and expectations since CSSMediaRule's deleteRule no longer allows omitting
the index to delete rule 0 (both non-standard and inconsistent with CSSStyleSheet).

10:04 AM Changeset in webkit [267575] by weinig@apple.com
  • 9 edits
    16 adds in trunk/Source/WebKitLegacy

[Preferences] Start generating experimental feature preferences for legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=216909

Reviewed by Tim Horton.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Add new files.

Source/WebKitLegacy/mac:

As a stepping stone to unified preferences definitions and generation, this adds
generation of "experimental feature" preferences for WebKitLegacy. The generator
is almost identical to the one in WebKit, but the templates are changed. The end
goal will be to share the preferences definition (yaml) files. In this pass, I
have copied WebPreferencesExperimental.yaml from WebKit, but change the default
values to match the existing WebKitLegacy default values (and temporarily removed
WebSQLDisabled, as WebKitLegacy has a WebSQLEnabled, and its not clear how to map
to the inverse yet). I have also imported empty versions of WebPreferences.yaml,
WebPreferencesDebug.yaml, and WebPreferencesInternal.yaml, to keep the generator
happy, these will be filled in subsequent changes or, if we decide on a good home
for them, perhaps in WTF, we can just switch to using the shared ones.

Much of the change is moving around existing getter/setters in WebPreferences
to go in their own category, with the intention to remove them when we we have
determined no more callers remain.

  • Scripts: Added.
  • Scripts/GeneratePreferences.rb: Added.
  • Scripts/PreferencesTemplates: Added.
  • Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Added.
  • Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: Added.
  • Scripts/PreferencesTemplates/WebViewPreferencesChangedGenerated.mm.erb: Added.
  • WebView/WebFeature.h: Added.
  • WebView/WebFeature.m: Added.

(-[WebFeature initWithKey:preferenceKey:name:details:defaultValue:hidden:]):
(-[WebFeature description]):

  • WebView/WebFeatureInternal.h: Added.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:
  • WebView/WebPreferences.yaml: Added.
  • WebView/WebPreferencesDebug.yaml: Added.
  • WebView/WebPreferencesDefaultValues.h: Added.
  • WebView/WebPreferencesDefaultValues.mm: Added.
  • WebView/WebPreferencesExperimental.yaml: Added.
  • WebView/WebPreferencesInternal.h: Added.
  • WebView/WebPreferencesInternal.yaml: Added.
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

  • WebView/WebViewInternal.h:
9:34 AM Changeset in webkit [267574] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Unreviewed test gardening, land test expectations for rdar://69347249.

  • platform/mac/TestExpectations:
  • platform/mac/TestExpectationsRosetta:
9:24 AM Changeset in webkit [267573] by Peng Liu
  • 3 edits in trunk/Source/WebCore

Clean up VideoLayerManagerObjC
https://bugs.webkit.org/show_bug.cgi?id=216946

Reviewed by Eric Carlson.

Remove m_videoInlineFrame. Also, change the order of some variables
and functions to put related things together.

No new tests since no functional changes.

  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::didDestroyVideoLayer):
(WebCore::VideoLayerManagerObjC::setVideoFullscreenLayer):

9:05 AM Changeset in webkit [267572] by Alan Bujtas
  • 5 edits
    2 adds in trunk

[LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue
https://bugs.webkit.org/show_bug.cgi?id=216976

Reviewed by Antti Koivisto.

Source/WebCore:

Geometry::computedHeightValue is a simple resolver function. It should not really care about
whether the box's containing block has valid vertical geometry. The callsite (where this assert is important) is already testing this condition.

Test: fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple.html

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedHeightValue const):
(WebCore::Layout::FormattingContext::Geometry::constraintsForInFlowContent):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):

LayoutTests:

  • fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple-expected.html: Added.
  • fast/layoutformattingcontext/out-of-flow-with-non-fixed-height-simple.html: Added.
8:22 AM Changeset in webkit [267571] by graouts@webkit.org
  • 37 edits
    1 add in trunk

Reduce the reliance on PseudoElement in the animation code
https://bugs.webkit.org/show_bug.cgi?id=216931
LayoutTests/imported/w3c:

Reviewed by Antti Koivisto.

Mark a WPT test progression.

  • web-platform-tests/css/css-transitions/non-rendered-element-002-expected.txt:

Source/WebCore:

<rdar://problem/69511682>

Reviewed by Antti Koivisto.

We have so far relied on PseudoElement as a foundation for supporting animations of pseudo-elements. This is not a
great choice since PseudoElement is currently limited to ::before and ::after pseudo-elements only. This patch
refactors animation-related code to rely on PseudoElement as little as possible without making changes outside
of the animation code, as a first step towards supporting animation of more pseudo-elements.

This patch introduces a new struct Styleable which combines an Element& and PseudoId. We use this struct instead
of Element objects wherever necessary in the animation code. On top of that, we add a PseudoId parameter to all the
Element methods wrapping access to ElementAnimationRareData and use a HashMap<PseudoId, std::unique_ptr<ElementAnimationRareData>>
to be able to separate animation data per pseudo-element.

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::removeAnimation):
(WebCore::AnimationTimeline::animationWasAddedToStyleable):
(WebCore::AnimationTimeline::animationWasRemovedFromStyleable):
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement):
(WebCore::AnimationTimeline::removeCSSAnimationCreatedByMarkup):
(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::willChangeRendererForStyleable):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForStyleable):
(WebCore::shouldConsiderAnimation):
(WebCore::AnimationTimeline::updateCSSAnimationsForStyleable):
(WebCore::keyframeEffectForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForStyleableAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForStyleable):
(WebCore::AnimationTimeline::animationWasAddedToElement): Deleted.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Deleted.
(WebCore::AnimationTimeline::willChangeRendererForElement): Deleted.
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement): Deleted.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Deleted.
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty): Deleted.
(WebCore::AnimationTimeline::updateCSSTransitionsForElement): Deleted.

  • animation/AnimationTimeline.h:
  • animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::create):
(WebCore::CSSAnimation::CSSAnimation):

  • animation/CSSAnimation.h:
  • animation/CSSTransition.cpp:

(WebCore::CSSTransition::create):
(WebCore::CSSTransition::CSSTransition):

  • animation/CSSTransition.h:
  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::owningElement const):
(WebCore::DeclarativeAnimation::disassociateFromOwningElement):
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):

  • animation/DeclarativeAnimation.h:
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animationCanBeRemoved):
(WebCore::DocumentTimeline::transitionDidComplete):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::runningAnimationsForRendererAreAllAccelerated const):
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated const): Deleted.

  • animation/DocumentTimeline.h:
  • animation/ElementAnimationRareData.cpp:

(WebCore::ElementAnimationRareData::ElementAnimationRareData):

  • animation/ElementAnimationRareData.h:

(WebCore::ElementAnimationRareData::pseudoId const):

  • animation/KeyframeEffect.cpp:

(WebCore::elementOrPseudoElementForStyleable):
(WebCore::invalidateElement):
(WebCore::KeyframeEffect::animationTimelineDidChange):
(WebCore::KeyframeEffect::updateEffectStackMembership):
(WebCore::KeyframeEffect::targetStyleable const):
(WebCore::KeyframeEffect::setTarget):
(WebCore::KeyframeEffect::setPseudoElement):
(WebCore::KeyframeEffect::didChangeTargetStyleable):
(WebCore::KeyframeEffect::invalidate):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::didChangeTargetElementOrPseudoElement): Deleted.

  • animation/KeyframeEffect.h:
  • animation/KeyframeEffectStack.cpp:

(WebCore::KeyframeEffectStack::addEffect):

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::effectTargetDidChange):
(WebCore::WebAnimation::persist):
(WebCore::WebAnimation::commitStyles):

  • animation/WebAnimation.h:
  • animation/WebAnimationUtilities.cpp:

(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder):
(WebCore::compareCSSTransitions):
(WebCore::compareCSSAnimations):

  • dom/Element.cpp:

(WebCore::Element::removedFromAncestor):
(WebCore::Element::animationRareData const):
(WebCore::Element::ensureAnimationRareData):
(WebCore::Element::keyframeEffectStack const):
(WebCore::Element::ensureKeyframeEffectStack):
(WebCore::Element::hasKeyframeEffects const):
(WebCore::Element::applyKeyframeEffects):
(WebCore::Element::animations const):
(WebCore::Element::hasCompletedTransitionsForProperty const):
(WebCore::Element::hasRunningTransitionsForProperty const):
(WebCore::Element::hasRunningTransitions const):
(WebCore::Element::ensureAnimations):
(WebCore::Element::animationsCreatedByMarkup):
(WebCore::Element::setAnimationsCreatedByMarkup):
(WebCore::Element::ensureCompletedTransitionsByProperty):
(WebCore::Element::ensureRunningTransitionsByProperty):
(WebCore::Element::lastStyleChangeEventStyle const):
(WebCore::Element::setLastStyleChangeEventStyle):
(WebCore::Element::getAnimations):

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::useTypes const):
(WebCore::ElementRareData::animationRareData const):
(WebCore::ElementRareData::ensureAnimationRareData):
(WebCore::ElementRareData::elementAnimationRareData): Deleted.

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::clearHostElement):
(WebCore::PseudoElement::isTargetedByKeyframeEffectRequiringPseudoElement):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasRunningAcceleratedAnimations const):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):

  • rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

  • rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::tearDownRenderers):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::resolvePseudoStyle):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

  • style/StyleTreeResolver.h:
  • style/Styleable.h: Added.

(WebCore::Styleable::Styleable):
(WebCore::Styleable::fromElement):
(WebCore::Styleable::fromRenderer):
(WebCore::Styleable::operator== const):
(WebCore::Styleable::operator!= const):
(WebCore::Styleable::keyframeEffectStack const):
(WebCore::Styleable::ensureKeyframeEffectStack const):
(WebCore::Styleable::hasKeyframeEffects const):
(WebCore::Styleable::applyKeyframeEffects const):
(WebCore::Styleable::animations const):
(WebCore::Styleable::hasCompletedTransitionsForProperty const):
(WebCore::Styleable::hasRunningTransitionsForProperty const):
(WebCore::Styleable::hasRunningTransitions const):
(WebCore::Styleable::ensureAnimations const):
(WebCore::Styleable::ensureCompletedTransitionsByProperty const):
(WebCore::Styleable::ensureRunningTransitionsByProperty const):
(WebCore::Styleable::animationsCreatedByMarkup const):
(WebCore::Styleable::setAnimationsCreatedByMarkup const):
(WebCore::Styleable::lastStyleChangeEventStyle const):
(WebCore::Styleable::setLastStyleChangeEventStyle const):

LayoutTests:

<rdar://problem/69511682>

Reviewed by Antti Koivisto.

Update a couple of tests which relied on an internals method to get a pseudo element and instead use
the Web Animations API to determine whether a given animation targets a pseudo-element. This has the
added benefit of having the same code run in a testing environment as in a regular browser.

  • fast/css-generated-content/pseudo-animation.html:
  • fast/css-generated-content/pseudo-transition.html:
8:17 AM Changeset in webkit [267570] by graouts@webkit.org
  • 1 edit
    97 adds in trunk/LayoutTests/imported/w3c

Import WPT tests for css/css-transforms/animation and css/css-transforms/parsing
https://bugs.webkit.org/show_bug.cgi?id=216973

Reviewed by Sam Weinig.

  • web-platform-tests/css/css-transforms/animation/composited-transform-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/composited-transform.html: Added.
  • web-platform-tests/css/css-transforms/animation/list-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/list-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/matrix-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/matrix-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-origin-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/perspective-origin-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/rotate-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/rotate-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/rotate-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/rotate-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/scale-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/scale-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/scale-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/scale-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-001-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-001.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-002-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-002.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-003-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-003.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-004-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-004.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-005-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-005.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-006-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-006.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-interpolation-computed-value.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-matrix-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-matrix-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-origin-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-origin-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-perspective-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-perspective-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-rotate-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-rotate-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-scale-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-scale-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-skew-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-skew-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/transform-translate-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/transform-translate-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/translate-composition-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/translate-composition.html: Added.
  • web-platform-tests/css/css-transforms/animation/translate-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-transforms/animation/translate-interpolation.html: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-computed.html: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-computed-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-computed.html: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/perspective-origin-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/rotate-parsing-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/rotate-parsing-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/scale-parsing-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/scale-parsing-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/scale-parsing-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/scale-parsing-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-computed-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-computed.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-box-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-computed-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-computed.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-origin-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/transform-valid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/translate-parsing-invalid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/translate-parsing-invalid.html: Added.
  • web-platform-tests/css/css-transforms/parsing/translate-parsing-valid-expected.txt: Added.
  • web-platform-tests/css/css-transforms/parsing/translate-parsing-valid.html: Added.
8:08 AM Changeset in webkit [267569] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

[macOS] Deny access to diagnosticd in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=216929
<rdar://problem/58496834>

Reviewed by Darin Adler.

After the change-set <https://trac.webkit.org/changeset/267498> landed, an extension to diagnostics
is issued when required, so the unconditional rule can be removed from the WebContent sandbox.

  • WebProcess/com.apple.WebProcess.sb.in:
7:35 AM Changeset in webkit [267568] by youenn@apple.com
  • 10 edits
    1 move
    1 delete in trunk

Implement default behavior for getUserMedia requests in case where there is no delegate set
https://bugs.webkit.org/show_bug.cgi?id=216968

Reviewed by Eric Carlson.

Source/WebKit:

In case page UIDelegate is not set, make the getUserMedia request do its default action.
In case there is a UIDelegate but no getUserMedia specific delegates, make the getUserMedia request do its default action.
Default action is deny for getDisplayMedia and for non cocoa ports.
For cocoa ports, a prompt is shown.

Manually tested with MiniBrowser and MobileMiniBrowser.

  • SourcesCocoa.txt:
  • UIProcess/API/APIUIClient.h:

(API::UIClient::decidePolicyForUserMediaPermissionRequest):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::requestUserMediaAuthorizationForFrame):

  • UIProcess/Cocoa/UserMediaPermissionRequestProxy.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.mm.

(WebKit::alertMessageText):
(WebKit::UserMediaPermissionRequestProxy::doDefaultAction):

  • UIProcess/Cocoa/WKUserMediaCaptureAccessAlert.h: Removed.
  • UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::doDefaultAction):

  • UIProcess/UserMediaPermissionRequestProxy.h:
  • WebKit.xcodeproj/project.pbxproj:

Tools:

Add camera and microphone entitlements to MobileMiniBrowser.
Expose mediaDevices to web pages and use mock devices.

  • MobileMiniBrowser/MobileMiniBrowser/Info.plist:
  • MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:

(-[WebViewController createWebView]):

7:17 AM Changeset in webkit [267567] by Lauro Moura
  • 2 edits in trunk/Tools

[webkitperl] Check for custom Flatpak user dirs in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=216959

Reviewed by Philippe Normand.

  • Scripts/webkitdirs.pm: Check for WEBKIT_FLATPAK_USER_DIR

(getUserFlatpakPath):

7:05 AM Changeset in webkit [267566] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

Fix LibWebRTCRtpReceiverBackend for internal build
https://bugs.webkit.org/show_bug.cgi?id=216965

Reviewed by Eric Carlson.

Move some includes to cpp file and add macros to disable deprecated warnings.
No change of behavior.

  • Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::LibWebRTCRtpReceiverBackend::LibWebRTCRtpReceiverBackend):

  • Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.h:
6:16 AM Changeset in webkit [267565] by Antti Koivisto
  • 19 edits
    15 deletes in trunk/Source/WebCore

Remove Simple Line Layout
https://bugs.webkit.org/show_bug.cgi?id=216914

Reviewed by Sam Weinig.

It is already fully covered by LFC and so unused. Remove the code.

  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXLogger.cpp:
  • accessibility/AccessibilityObjectInterface.h:
  • editing/TextIterator.cpp:
  • layout/Verification.cpp:

(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded): Deleted.

  • layout/integration/LayoutIntegrationLineLayout.cpp:
  • layout/integration/LayoutIntegrationPagination.cpp:
  • rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::layoutLineBoxes):
(WebCore::ComplexLineLayout::addOverflowFromInlineChildren):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::lineCount const):
(WebCore::RenderBlockFlow::positionForPoint):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines const):
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):
(WebCore::RenderBlockFlow::ensureLineBoxes):
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
(WebCore::RenderBlockFlow::layoutSimpleLines): Deleted.

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::hasSimpleLineLayout const): Deleted.
(WebCore::RenderBlockFlow::simpleLineLayout const): Deleted.
(WebCore::RenderBlockFlow::simpleLineLayout): Deleted.

  • rendering/RenderFragmentedFlow.cpp:

(WebCore::RenderFragmentedFlow::removeLineFragmentInfo):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::usesComplexLineLayoutPath const):
(WebCore::RenderText::linesVisualOverflowBoundingBox const):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
(WebCore::RenderText::simpleLineLayout const): Deleted.

  • rendering/RenderText.h:
  • rendering/SimpleLineLayout.cpp: Removed.
  • rendering/SimpleLineLayout.h: Removed.
  • rendering/SimpleLineLayoutCoverage.cpp: Removed.
  • rendering/SimpleLineLayoutCoverage.h: Removed.
  • rendering/SimpleLineLayoutFlowContents.cpp: Removed.
  • rendering/SimpleLineLayoutFlowContents.h: Removed.
  • rendering/SimpleLineLayoutFunctions.cpp: Removed.
  • rendering/SimpleLineLayoutFunctions.h: Removed.
  • rendering/SimpleLineLayoutPagination.cpp: Removed.
  • rendering/SimpleLineLayoutPagination.h: Removed.
  • rendering/SimpleLineLayoutResolver.cpp: Removed.
  • rendering/SimpleLineLayoutResolver.h: Removed.
  • rendering/SimpleLineLayoutTextFragmentIterator.cpp: Removed.
  • rendering/SimpleLineLayoutTextFragmentIterator.h: Removed.
  • rendering/TextPainter.cpp:

(WebCore::TextPainter::clearGlyphDisplayLists):

  • rendering/line/LineLayoutTraversal.cpp:

(WebCore::LineLayoutTraversal::firstTextBoxFor):
(WebCore::LineLayoutTraversal::elementBoxFor):

  • rendering/line/LineLayoutTraversal.h:
  • rendering/line/LineLayoutTraversalSimplePath.h: Removed.
4:51 AM Changeset in webkit [267564] by Alexey Shvayka
  • 6 edits
    1 add in trunk

DataView instances should not have own "byteLength" and "byteOffset" properties
https://bugs.webkit.org/show_bug.cgi?id=149906

Reviewed by Ross Kirsling.

JSTests:

  • stress/dataview-no-own-properties.js: Added.

Source/JavaScriptCore:

Following JSDataView::getOwnPropertySlot() deletion in r266529, this patch
removes related method overrides that incorrectly reported "byteLength" and
"byteOffset" as own properties of DataView instances [1].

This change brings DataView objects in compliance with invariants of internal
methods [2] and aligns JSC with V8 and SpiderMonkey.
DataView microbenchmarks are neutral.

[1]: https://tc39.es/ecma262/#sec-properties-of-dataview-instances
[2]: https://tc39.es/ecma262/#sec-invariants-of-the-essential-internal-methods

  • runtime/JSDataView.cpp:

(JSC::JSDataView::put): Deleted.
(JSC::JSDataView::defineOwnProperty): Deleted.
(JSC::JSDataView::deleteProperty): Deleted.
(JSC::JSDataView::getOwnNonIndexPropertyNames): Deleted.

  • runtime/JSDataView.h:

LayoutTests:

  • inspector/model/remote-object/object-expected.txt:
4:48 AM Changeset in webkit [267563] by youenn@apple.com
  • 16 edits in trunk

Introduce WKWebViewConfiguration mediaCaptureEnabled
https://bugs.webkit.org/show_bug.cgi?id=216872

Reviewed by Alex Christensen.

Source/WebKit:

Add a new boolean configuration to enable/disable mediaDevices exposure.
Value is off by default.
A future patch will remove the mediaDevices WebPreferences based API, given there is no need
to enable/disable mediaDevices during the lifetime of a page.

Covered by existing tests.

  • UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

  • UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::setMediaDevicesEnabled):
(API::PageConfiguration::mediaDevicesEnabled const):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _mediaDevicesEnabled]):
(-[WKWebViewConfiguration _setMediaDevicesEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Tools:

Make use of new configuration boolean instead of mediaDevicesEnabled WebPreferences API.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate defaultConfiguration]):

  • TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:

(TestWebKitAPI::GetDisplayMediaTest::SetUp):

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:

(MediaCaptureDisabledTest::SetUp):

  • TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:

(MediaCaptureSimulateFailedSandbox::SetUp):

4:24 AM Changeset in webkit [267562] by Antti Koivisto
  • 6 edits in trunk

[LFC][Integration] Enable on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=216928
<rdar://problem/69505961>

Reviewed by Zalan Bujtas.

.:

  • Source/cmake/OptionsWin.cmake:

Source/WTF:

  • wtf/PlatformEnableWinApple.h:

LayoutTests:

  • platform/win/TestExpectations:
1:57 AM Changeset in webkit [267561] by Alexey Shvayka
  • 2 edits in trunk/JSTests

REGRESSION (r267514): mozilla-tests.yaml/js1_5/Array/regress-157652.js.mozilla* timing out
https://bugs.webkit.org/show_bug.cgi?id=216955

Unreviewed test gardening: skip mozilla/regress-157652.js in --debug.

r267514 removed special handling of sparse arrays, causing the timeout.

  • mozilla/mozilla-tests.yaml:
1:52 AM Changeset in webkit [267560] by Adrian Perez de Castro
  • 13 edits in trunk/Source

Non-unified build fixes, late September 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=216950

Unreviewed build fix.

Source/JavaScriptCore:

  • inspector/agents/InspectorConsoleAgent.cpp: Add missing ScriptArguments.h include.

Source/WebCore:

No new tests needed.

  • Modules/webaudio/AudioNodeInput.cpp: Add missing AudioUtilities.h include.
  • Modules/webaudio/AudioNodeOutput.cpp: Ditto.
  • Modules/webaudio/BiquadProcessor.cpp: Ditto.
  • Modules/webaudio/GainNode.cpp: Ditto.
  • Modules/webaudio/PannerNode.cpp: Ditto.
  • page/PerformanceUserTiming.cpp: Add missing JavaScriptCore/JSCJSValueInlines.h include.
  • platform/audio/AudioUtilities.h: Add missing <cmath> include.

Source/WebKit:

  • NetworkProcess/NetworkSessionCreationParameters.cpp: Arrange guards to include

WebCoreArgumentCoders.h with USE(SOUP).

  • UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp: Add missing WebCoreArgumentCoders.h

include.

Sep 24, 2020:

10:40 PM Changeset in webkit [267559] by Ross Kirsling
  • 4 edits in trunk

%TypedArray%.prototype.toLocaleString must make conscious use of @toString
https://bugs.webkit.org/show_bug.cgi?id=216956

Reviewed by Yusuke Suzuki.

JSTests:

  • test262/expectations.yaml:

Mark four test cases as passing.

Source/JavaScriptCore:

A fascinating bug: if we override Number.prototype.toLocaleString to return { valueOf() { ... } },
then we can observe our %TypedArray%.prototype.toLocaleString resolving its element values in the wrong order.

  • builtins/TypedArrayPrototype.js:

(toLocaleString):
Wrap the toLocaleString call for each element in @toString(), as the spec indicates.

10:02 PM Changeset in webkit [267558] by Diego Pino Garcia
  • 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Several WPT's MathML tests are crashing in GTK/WPE Debug.

  • platform/glib/TestExpectations:
9:49 PM Changeset in webkit [267557] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes.
https://bugs.webkit.org/show_bug.cgi?id=216957

Reviewed by Simon Fraser.

The overloaded LineBox::InlineBox constructors were representing different types of inline level boxes.
These new helper functions make it easier to figure out how to initiate LineBox::InlineBox objects depending on the type of
the inline level box.
This patch also removes an incorrect ASSERT on the inline box's height. It is okay to have a zero height inline box.

  • layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):

  • layout/inlineformatting/InlineLineBox.cpp:

(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::m_baseline):

  • layout/inlineformatting/InlineLineBox.h:

(WebCore::Layout::LineBox::InlineBox::createBoxForRootInlineBox):
(WebCore::Layout::LineBox::InlineBox::createBoxForAtomicInlineLevelBox):
(WebCore::Layout::LineBox::InlineBox::createBoxForInlineBox):

8:19 PM Changeset in webkit [267556] by Ryan Haddad
  • 3 edits in branches/safari-610-branch/Tools

Cherry-pick r267501. rdar://problem/69454393

Force SYSTEM_VERSION_COMPAT=0 in Webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=216895
<rdar://problem/69454393>

Reviewed by Dewei Zhu.

  • Scripts/configure-xcode-for-embedded-development:
  • Scripts/webkitpy/init.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:00 PM Changeset in webkit [267555] by Lauro Moura
  • 4 edits
    2 adds
    2 deletes in trunk/LayoutTests

[GLIB] Rebaseline and unify some expectations after r267551

Unreviewed test gardening.

This one was missing from previous mathml gardening:

  • platform/glib/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt:

After r267551:

  • platform/glib/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
  • platform/wpe/imported/w3c/web-platform-tests/css/css-values/minmax-angle-computed-expected.txt: Removed.
7:51 PM Changeset in webkit [267554] by Ross Kirsling
  • 5 edits in trunk

%TypedArray%.prototype.sort must throw if comparator is defined and uncallable
https://bugs.webkit.org/show_bug.cgi?id=216952

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/typedarray-sort.js:

Fix test.

  • test262/expectations.yaml:

Mark two test cases as passing.

Source/JavaScriptCore:

  • builtins/TypedArrayPrototype.js:

(sort):

4:59 PM Changeset in webkit [267553] by Kate Cheney
  • 2 edits in trunk/Tools

InAppBrowserPrivacy HTTPCookie tests incorrectly use the IsInAppBrowserPrivacyEnabled NSUserDefaults value
https://bugs.webkit.org/show_bug.cgi?id=216896
<rdar://problem/69456713>

Reviewed by Brady Eidson.

The IsInAppBrowserPrivacyEnabled UserDefaults value no longer enables
App-Bound Domains, so the tests should not use it in this way.
Changing the bundle identifier using
cleanUpInAppBrowserPrivacyTestSettings() and
initializeInAppBrowserPrivacyTestSettings() is enough to
enable/disable App-Bound Domains.

This patch also adds a WKHTTPCookieStoreObserver to test setting
app-bound cookies. This ensures we don't get a false positive from
the test by being allowed to set but not retrieve app-bound cookies.

  • TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

(-[InAppBrowserPrivacyCookieObserver cookiesDidChangeInCookieStore:]):
(setUpCookieTestWithWebsiteDataStore):
(TEST):
(setUpCookieTest): Deleted.
Changed name and simplified.

4:56 PM Changeset in webkit [267552] by Alan Coon
  • 1 copy in tags/Safari-610.2.6.1.6

Tag Safari-610.2.6.1.6.

3:40 PM Changeset in webkit [267551] by keith_miller@apple.com
  • 11 edits in trunk

CSS angle unit conversions should consistently use the same associativity
https://bugs.webkit.org/show_bug.cgi?id=216906

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline tests for different rounding errors in angle unit conversions. The minmax-angle-computed test
is now passing and the webaudio tests just have slightly different results now.

  • web-platform-tests/css/css-values/minmax-angle-computed-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
  • web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/panner-automation-basic-expected.txt:

Source/WebCore:

Right now we inconsistently associate our floating point math for
angle unit conversions. In particular,
conversionToCanonicalUnitsScaleFactor expects there to be a single
fixed constant we can multiply by to change units. However, the
various conversion functions in WTF are not associated in this
way. e.g. rad2deg does ((radian * 180) / pi) rather than
(radian * (180 / pi)). Since FP math is NOT associative these
produce different results. For example, 1.57 radians is
89.954373835539258 degrees in the first case but
89.954373835539243 in the second.

This patch changes the WTF functions to operate on a single scale
factor when converting to/from the canonical unit. Conversions
between non-canonical units first convert to the canonical unit
(degree). Also, conversionToCanonicalUnitsScaleFactor now gets the
scale factor from WTF to ensure we get the same associativity
everywhere.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):

Source/WTF:

Right now we inconsistently associate our floating point math for
angle unit conversions. In particular,
conversionToCanonicalUnitsScaleFactor expects there to be a single
fixed constant we can multiply by to change units. However, the
various conversion functions in WTF are not associated in this
way. e.g. rad2deg does ((radian * 180) / pi) rather than
(radian *(180 / pi)). Since FP math is NOT associative these
produce different results. For example, 1.57 radians is
89.954373835539258 degrees in the first case but
89.954373835539243 in the second.

This patch changes those WTF functions to operate on a single
scale factor when converting to/from the canonical
unit. Conversions between non-canonical units first convert to the
canonical unit (degree).

  • wtf/MathExtras.h:

(deg2rad):
(rad2deg):
(deg2grad):
(grad2deg):
(deg2turn):
(turn2deg):
(rad2grad):
(grad2rad):

LayoutTests:

Rebaseline tests.

3:25 PM Changeset in webkit [267550] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore

[SVG2] Remove color-profile tag
https://bugs.webkit.org/show_bug.cgi?id=216910

Reviewed by Darin Adler.

SVG2 removed color-profile element.

  • dom/Document.cpp:

(WebCore::Document::validateCustomElementName):

  • svg/svgtags.in:
3:05 PM Changeset in webkit [267549] by Ross Kirsling
  • 6 edits in trunk

JSTests:
%TypedArray%.prototype.{map, filter} should perform TypedArraySpeciesCreate correctly
https://bugs.webkit.org/show_bug.cgi?id=216938

Reviewed by Yusuke Suzuki.

  • stress/typedarray-slice.js:

Fix test.

  • test262/expectations.yaml:

Mark ten test cases as passing.

Source/JavaScriptCore:
%TypedArray% methods should perform TypedArraySpeciesCreate correctly
https://bugs.webkit.org/show_bug.cgi?id=216938

Reviewed by Yusuke Suzuki.

map, filter, and slice are obliged to throw when:

  1. this.constructor is defined but not an object
  2. the species constructor produces a valid typed array which is shorter than the expected length
  • builtins/TypedArrayPrototype.js:

(map):
(filter):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncSlice):

2:59 PM Changeset in webkit [267548] by Alan Coon
  • 8 edits in branches/safari-610.2.6.1-branch/Source

Versioning.

WebKit-7610.2.6.1.6

2:55 PM Changeset in webkit [267547] by Lauro Moura
  • 3 edits
    2 copies
    3 moves
    104 adds
    4 deletes in trunk/LayoutTests

[GLIB] Update baseline and expectations after r267531

Unreviewed test gardening.

Also unified some shared expectations between GTK and WPE.

Some flakies likely to be still around in WPE. Will garden as they
appear in the test runs.

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt.
  • platform/glib/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt.
  • platform/glib/mathml/presentation/menclose-notation-values-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/menclose-notation-values-expected.txt.
  • platform/glib/mathml/presentation/mspace-children-expected.txt: Renamed from LayoutTests/platform/gtk/mathml/presentation/mspace-children-expected.txt.
  • platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Copied from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt.
  • platform/wpe/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Removed.
  • platform/wpe/mathml/presentation/menclose-notation-values-expected.txt: Removed.
  • platform/wpe/mathml/presentation/mspace-children-expected.txt: Removed.
2:47 PM Changeset in webkit [267546] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
https://bugs.webkit.org/show_bug.cgi?id=216942
<rdar://problem/69520398>

Reviewed by Brian Burg.

  • UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.insertSidebarPanel):
insertSidebarPanel was exiting early when sidebarPanel.parentSidebar matched the current sidebar,
creating a state when this._sidebarPanels is an empty array.

2:36 PM Changeset in webkit [267545] by Brian Burg
  • 2 edits in trunk/Source/WebKit

REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=216937
<rdar://problem/69149171>

Reviewed by Darin Adler.

Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
Make sure the aliasing happens for macOS so the command doesn't fail frivolously.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::performInteractionSequence):
Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
This is the case for macOS.

1:10 PM Changeset in webkit [267544] by Chris Dumez
  • 74 edits in trunk/Source/WebCore

Use more inline initialization and constexpr in WebAudio code
https://bugs.webkit.org/show_bug.cgi?id=216939

Reviewed by Darin Adler.

Use more inline initialization and constexpr in WebAudio code.

  • Modules/webaudio/AudioBufferSourceNode.cpp:
  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):

  • Modules/webaudio/AudioNodeOutput.h:
  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioSummingJunction.cpp:

(WebCore::AudioSummingJunction::AudioSummingJunction):

  • Modules/webaudio/AudioSummingJunction.h:
  • Modules/webaudio/BiquadDSPKernel.cpp:
  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/BiquadProcessor.h:
  • Modules/webaudio/ConvolverNode.cpp:
  • Modules/webaudio/DefaultAudioDestinationNode.cpp:
  • Modules/webaudio/DelayNode.cpp:
  • Modules/webaudio/DynamicsCompressorNode.cpp:
  • Modules/webaudio/MediaElementAudioSourceNode.cpp:
  • Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::numberOfPartialsForRange const):

  • Modules/webaudio/PeriodicWave.h:
  • Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::RealtimeAnalyser):

  • Modules/webaudio/RealtimeAnalyser.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):

  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::WaveShaperProcessor):

  • Modules/webaudio/WaveShaperProcessor.h:
  • Modules/webaudio/WebKitAudioContext.cpp:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):

  • Modules/webaudio/WebKitAudioPannerNode.h:
  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::AudioBus):

  • platform/audio/AudioBus.h:
  • platform/audio/AudioChannel.h:
  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::AudioHardwareListener):

  • platform/audio/AudioHardwareListener.h:
  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):

  • platform/audio/AudioResampler.h:
  • platform/audio/AudioResamplerKernel.cpp:

(WebCore::AudioResamplerKernel::AudioResamplerKernel):

  • platform/audio/AudioResamplerKernel.h:
  • platform/audio/Biquad.cpp:
  • platform/audio/Cone.cpp:
  • platform/audio/Cone.h:
  • platform/audio/Distance.cpp:
  • platform/audio/Distance.h:
  • platform/audio/DownSampler.cpp:

(WebCore::DownSampler::DownSampler):

  • platform/audio/DownSampler.h:
  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):

  • platform/audio/DynamicsCompressorKernel.h:
  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

  • platform/audio/EqualPowerPanner.h:
  • platform/audio/FFTConvolver.cpp:

(WebCore::FFTConvolver::FFTConvolver):

  • platform/audio/FFTConvolver.h:
  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::HRTFDatabase):

  • platform/audio/HRTFDatabase.h:
  • platform/audio/HRTFElevation.cpp:
  • platform/audio/HRTFElevation.h:
  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::HRTFKernel):

  • platform/audio/HRTFKernel.h:
  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):

  • platform/audio/HRTFPanner.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::PlatformMediaSession):

  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PushPullFIFO.cpp:

(WebCore::PushPullFIFO::PushPullFIFO):

  • platform/audio/PushPullFIFO.h:
  • platform/audio/Reverb.cpp:
  • platform/audio/ReverbAccumulationBuffer.cpp:

(WebCore::ReverbAccumulationBuffer::ReverbAccumulationBuffer):

  • platform/audio/ReverbAccumulationBuffer.h:
  • platform/audio/ReverbConvolver.cpp:
  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • platform/audio/ReverbConvolverStage.h:
  • platform/audio/ReverbInputBuffer.cpp:

(WebCore::ReverbInputBuffer::ReverbInputBuffer):

  • platform/audio/ReverbInputBuffer.h:
12:57 PM Changeset in webkit [267543] by Chris Dumez
  • 21 edits in trunk/Source/WebCore

Simplify AudioNode::addInput() / addOutput() call sites
https://bugs.webkit.org/show_bug.cgi?id=216941

Reviewed by Darin Adler.

Simplify AudioNode::addInput() / addOutput() call sites by moving the input / output
node construction from the call site to the function implementation.

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

  • Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::addInput):
(WebCore::AudioNode::addOutput):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):

  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::ChannelSplitterNode):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):

  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):

  • Modules/webaudio/WebKitAudioPannerNode.cpp:

(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):

12:08 PM Changeset in webkit [267542] by Jonathan Bedard
  • 3 edits in trunk/Tools

[results.webkit.org] Drop old archive chunks
https://bugs.webkit.org/show_bug.cgi?id=216936
<rdar://problem/69513686>

Unreviewed emergency infrastructure change.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Increment package version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/model/cassandra_archiver.py:

(CassandraArchiver.ArchiveChunks): Changer archive chunk table.

11:32 AM Changeset in webkit [267541] by Chris Dumez
  • 38 edits in trunk/Source/WebCore

Declare render quantum size constant in AudioUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=216935

Reviewed by Eric Carlson.

Declare render quantum size [1] constant in AudioUtilities.h so that it can be used in both
platform/ and Modules/webaudio/. Also update the code so that we have a single constant
instead of many.

[1] https://www.w3.org/TR/webaudio/#render-quantum-size

  • Modules/webaudio/AudioListener.cpp:

(WebCore::AudioListener::AudioListener):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::processOnlyAudioParams):

  • Modules/webaudio/ConstantSourceNode.cpp:

(WebCore::ConstantSourceNode::ConstantSourceNode):

  • Modules/webaudio/ConstantSourceNode.h:
  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/DelayDSPKernel.cpp:

(WebCore::DelayDSPKernel::DelayDSPKernel):
(WebCore::DelayDSPKernel::processOnlyAudioParams):

  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::processOnlyAudioParams):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):
(WebCore::GainNode::processOnlyAudioParams):

  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::suspendOfflineRendering):

  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::offlineRender):

  • Modules/webaudio/OfflineAudioDestinationNode.h:
  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::processOnlyAudioParams):
(WebCore::PannerNode::processSampleAccurateValues):

  • Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::RealtimeAnalyser):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):

  • Modules/webaudio/StereoPannerNode.cpp:

(WebCore::StereoPannerNode::StereoPannerNode):
(WebCore::StereoPannerNode::processOnlyAudioParams):

  • Modules/webaudio/StereoPannerNode.h:
  • Modules/webaudio/WaveShaperDSPKernel.cpp:

(WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
(WebCore::WaveShaperDSPKernel::processCurve2x):
(WebCore::WaveShaperDSPKernel::processCurve4x):

  • platform/audio/AudioResamplerKernel.cpp:

(WebCore::AudioResamplerKernel::AudioResamplerKernel):
(WebCore::AudioResamplerKernel::getSourcePointer):
(WebCore::AudioResamplerKernel::process):

  • platform/audio/AudioResamplerKernel.h:
  • platform/audio/AudioUtilities.h:
  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):

  • platform/audio/Biquad.h:
  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::pan):

  • platform/audio/IIRFilter.cpp:

(WebCore::IIRFilter::tailTime):

  • platform/audio/cocoa/AudioDestinationCocoa.cpp:

(WebCore::AudioDestinationCocoa::AudioDestinationCocoa):
(WebCore::AudioDestinationCocoa::render):
(WebCore::AudioDestinationCocoa::provideInput):

  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::updateSessionState):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::framesPerBuffer const):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_class_init):

11:29 AM Changeset in webkit [267540] by Kate Cheney
  • 2 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code
https://bugs.webkit.org/show_bug.cgi?id=216934
<rdar://problem/69216768>

Reviewed by Alex Christensen.

Add a check for a valid key.

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::firstPartyHostCNAMEDomain):

11:28 AM Changeset in webkit [267539] by youenn@apple.com
  • 12 edits
    1 copy in trunk/Source

Add libwebrtc.dylib version check
https://bugs.webkit.org/show_bug.cgi?id=216884
<rdar://problem/69441354>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Introduce isMatchingBundleVersion to check libwebrtc.dylib version.

  • Configurations/libwebrtc.iOS.exp:
  • Configurations/libwebrtc.iOSsim.exp:
  • Configurations/libwebrtc.mac.exp:
  • Configurations/libwebrtc.xcconfig:
  • Source/webrtc/sdk/WebKit/WebKitUtilities.h:
  • Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

(webrtc::isMatchingBundleVersion):

Source/WebCore:

Use webrtc::isMatchingBundleVersion to check for libwebrtc.dylib presence and for version matching.
If version does not match, crash the web process.
No change of behavior.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:

(WebCore::LibWebRTCProvider::webRTCAvailable):

  • platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:
  • platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.mm:
11:23 AM Changeset in webkit [267538] by basuke.suzuki@sony.com
  • 2 edits in trunk/Source/JavaScriptCore

[PlayStation] Stop raising SIGPIPE when client side of RemoteInspector dies
https://bugs.webkit.org/show_bug.cgi?id=216805

Reviewed by Don Olmstead.

When communication is stopped caused by peer crash or non-polite close, SIGPIPE will be
raised on BSD (and maybe on Linux). We prefer to handle those events by returning error.

On Windows, there's no such fancy feature from the beginning.

  • inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

(Inspector::Socket::read):
(Inspector::Socket::write):

10:47 AM Changeset in webkit [267537] by Chris Dumez
  • 36 edits in trunk/Source/WebCore

Drop AudioNode::reset() and all its overrides
https://bugs.webkit.org/show_bug.cgi?id=216932

Reviewed by Eric Carlson.

Drop AudioNode::reset() and all its overrides. This is dead code.

  • Modules/webaudio/AnalyserNode.cpp:
  • Modules/webaudio/AnalyserNode.h:
  • Modules/webaudio/AudioBasicProcessorNode.cpp:
  • Modules/webaudio/AudioBasicProcessorNode.h:
  • Modules/webaudio/AudioBufferSourceNode.cpp:
  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/ChannelMergerNode.cpp:
  • Modules/webaudio/ChannelMergerNode.h:
  • Modules/webaudio/ChannelSplitterNode.cpp:
  • Modules/webaudio/ChannelSplitterNode.h:
  • Modules/webaudio/ConstantSourceNode.h:
  • Modules/webaudio/ConvolverNode.cpp:
  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/DynamicsCompressorNode.cpp:
  • Modules/webaudio/DynamicsCompressorNode.h:
  • Modules/webaudio/GainNode.cpp:
  • Modules/webaudio/GainNode.h:
  • Modules/webaudio/MediaElementAudioSourceNode.cpp:
  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
  • Modules/webaudio/MediaStreamAudioDestinationNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/OscillatorNode.cpp:
  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.cpp:
  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/RealtimeAnalyser.cpp:
  • Modules/webaudio/RealtimeAnalyser.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:
  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webaudio/StereoPannerNode.h:
  • Modules/webaudio/WebKitAudioPannerNode.cpp:
  • Modules/webaudio/WebKitAudioPannerNode.h:
9:49 AM Changeset in webkit [267536] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the build for recent SDKs.
rdar://69394018

  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::decode):

9:16 AM Changeset in webkit [267535] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[MIPS] Broken build after r267371
https://bugs.webkit.org/show_bug.cgi?id=216893

Patch by Angelos Oikonomopoulos <angelos@igalia.com> on 2020-09-24
Reviewed by Adrian Perez de Castro.

This addresses two issues.

First, the fix in https://bugs.webkit.org/show_bug.cgi?id=216772 was not
getting exercised, because the LabelReference offset was always zero.

The reason the offset was zero is that LabelReference.mapChildren would discard
the offset when generating a new LabelReference to wrap the Label returned by
the code block it yielded to.

The reason this was only an issue on MIPS is because only MIPS was using the
result of calls to LabelReference.mapChildren (in its lowering phase,
assignRegistersToTemporaries -> replaceTemporariesWithRegisters ->
mapChildren). Other archs, e.g. X86_64 only call mapChildren in earlier phases
(specifically, subsequent to a call to isASTErroneous), in which the new
LabelReferences returned by mapChildren are later discarded. Even though ARM
32/64 contains indirect calls to mapChildren, those are made after the
arm{,64}LowerLabelReferences transformation which doesn't leave any
LabelReference nodes around for .mapChildren to be called on.

So this is not an issue for architectures other than MIPS because
(a) AddImmediates.fold correctly constructs a LabelReference with an offset by
calling LabelReference.plusOffset and
(b) they don't call (and therefore don't use the result of)
LabelReference.mapChildren in their lowering code.

Second, the code we generate needs to look up the /label/ in the GOT, not the
computed address. After the lookup, we simply need to add the offset.

  • offlineasm/ast.rb:
  • offlineasm/mips.rb:
9:14 AM Changeset in webkit [267534] by commit-queue@webkit.org
  • 34 edits in trunk

[GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=216927

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-09-24
Reviewed by Alex Christensen.

Source/WebCore:

Make proxySettings a member of SoupNetworkSession, instead of being global.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::proxySettings): Deleted.
(WebCore::SoupNetworkSession::setupProxy): Deleted.

  • platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Make proxy settings per session instead of global to the network process. The web context API now simply
forwards the request to the website data manager.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/NetworkSessionCreationParameters.cpp:

(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):

  • NetworkProcess/NetworkSessionCreationParameters.h:
  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setNetworkProxySettings):

  • NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup):
(WebKit::NetworkSessionSoup::setProxySettings):

  • NetworkProcess/soup/NetworkSessionSoup.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionCreate):

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_network_proxy_settings):

  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):

  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkit_website_data_manager_set_network_proxy_settings):

  • UIProcess/API/gtk/WebKitNetworkProxySettings.h:
  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebsiteDataManager.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/wpe/WebKitNetworkProxySettings.h:
  • UIProcess/API/wpe/WebKitWebContext.h:
  • UIProcess/API/wpe/WebKitWebsiteDataManager.h:
  • UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::networkProxySettings const):

  • UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setNetworkProxySettings):

  • UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setNetworkProxySettings): Deleted.

Tools:

Use the new API in tests.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextProxySettings):

8:52 AM Changeset in webkit [267533] by Antti Koivisto
  • 2 edits in trunk/Source/WTF

[LFC][Integration] Enable on Apple Windows port
https://bugs.webkit.org/show_bug.cgi?id=216928

Reviewed by Sam Weinig.

  • wtf/PlatformEnableWinApple.h:

For consistency.

8:23 AM Changeset in webkit [267532] by Chris Dumez
  • 5 edits
    2 copies
    2 adds in trunk

web audio api outputs silence for 302 redirected resource in safari
https://bugs.webkit.org/show_bug.cgi?id=214932
<rdar://problem/66300050>

Reviewed by Darin Adler.

Source/WebCore:

If the resource is redirected to another origin, treat it as tainted only if the crossorigin attribute
is not set. This is done for consistency with Blink:

The new behavior also seems to match Firefox.

Tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html

http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::wouldTaintOrigin):

LayoutTests:

Add layout test coverage. Update existing test to reflect the fact that the frequency returned by
the AnalyserNode is -Infinity when input is silent, not minDecibels (this has changed fairly
recently).

  • http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect-expected.txt: Added.
  • http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
  • http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html:
  • http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect-expected.txt: Added.
  • http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html.
8:20 AM Changeset in webkit [267531] by commit-queue@webkit.org
  • 98 edits
    11 copies
    7 moves
    407 adds
    2 deletes in trunk/LayoutTests

Resync WPT's mathml and math-script-level-and-math-style tests
https://bugs.webkit.org/show_bug.cgi?id=216871

Patch by Frederic Wang <fwang@igalia.com> on 2020-09-24
Reviewed by Rob Buis.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative.html: Added.
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-002.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-003.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative-expected.html.
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-003.tentative.html: Added.
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-004.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-001.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative-expected.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-003.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-004.tentative-expected.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-004.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-005.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-font-size-clamping-001.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative.html:
  • web-platform-tests/css/css-fonts/math-script-level-and-math-style/w3c-import.log:
  • web-platform-tests/mathml/crashtests/display-and-column-properties.html: Added.
  • web-platform-tests/mathml/crashtests/multicol-on-token-elements.html: Added.
  • web-platform-tests/mathml/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/tools/utils/w3c-import.log.
  • web-platform-tests/mathml/presentation-markup/direction/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-1.html:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-2-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-2.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-3-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-3.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-invalid.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-legacy-bevelled-attribute.tentative-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-legacy-bevelled-attribute.tentative.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html:
  • web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3.html: Added.
  • web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation-expected.html:
  • web-platform-tests/mathml/presentation-markup/menclose/legacy-menclose-radical-notation.html:
  • web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units.html: Added.
  • web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/mpadded/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log.
  • web-platform-tests/mathml/presentation-markup/mrow/dynamic-mrow-like-001-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/dynamic-mrow-like-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline.html:
  • web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-stretchy.html:
  • web-platform-tests/mathml/presentation-markup/mrow/legacy-mfenced-element-001-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/legacy-mfenced-element-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/legacy-mstyle-attributes.html:
  • web-platform-tests/mathml/presentation-markup/mrow/merror-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/mrow-painting-order-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/mrow-painting-order.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/no-spacing.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/spacing.html: Added.
  • web-platform-tests/mathml/presentation-markup/mrow/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html:
  • web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002.html:
  • web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001.html.
  • web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-002-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-form-expected.html:
  • web-platform-tests/mathml/presentation-markup/operators/mo-form-minus-plus-expected.html:
  • web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-lspace-rspace-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-lspace-rspace.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-movablelimits-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-not-in-dictionary-movablelimits.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-single-char-and-children-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-single-char-and-children.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001-expected.txt: Removed.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-001.html: Removed.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006.html: Added.
  • web-platform-tests/mathml/presentation-markup/operators/support/operator-dictionary-tests.css: Added.

(@font-face):
(math, math *):

  • web-platform-tests/mathml/presentation-markup/operators/support/operator-dictionary-tests.js: Added.

(OperatorDictionaryTests.spaceBetween):
(OperatorDictionaryTests.string_appeared_here):
(OperatorDictionaryTests.run):

  • web-platform-tests/mathml/presentation-markup/operators/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/w3c-import.log.
  • web-platform-tests/mathml/presentation-markup/operators/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/radicals/dynamic-radical-paint-invalidation-001-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/radicals/dynamic-radical-paint-invalidation-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2.html: Added.
  • web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/scripts/cramped-001.html:
  • web-platform-tests/mathml/presentation-markup/scripts/empty-underover.html: Added.
  • web-platform-tests/mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative.html: Added.
  • web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html:
  • web-platform-tests/mathml/presentation-markup/scripts/underover-1.html:
  • web-platform-tests/mathml/presentation-markup/scripts/underover-legacy-align-attribute-001-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-legacy-align-attribute-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html:
  • web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html.
  • web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/spaces/space-1.html:
  • web-platform-tests/mathml/presentation-markup/spaces/space-like-001.html:
  • web-platform-tests/mathml/presentation-markup/spaces/space-like-002.html:
  • web-platform-tests/mathml/presentation-markup/spaces/space-like-003.html:
  • web-platform-tests/mathml/presentation-markup/spaces/space-vertical-align.tentative-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/spaces/space-vertical-align.tentative.html: Added.
  • web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/tables/w3c-import.log:
  • web-platform-tests/mathml/presentation-markup/tokens/dynamic-mtext-like-001-expected.html: Added.
  • web-platform-tests/mathml/presentation-markup/tokens/dynamic-mtext-like-001.html: Added.
  • web-platform-tests/mathml/presentation-markup/tokens/ms-001-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/direction/direction-009-expected.html.
  • web-platform-tests/mathml/presentation-markup/tokens/ms-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/direction/direction-009.html.
  • web-platform-tests/mathml/presentation-markup/tokens/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log.
  • web-platform-tests/mathml/relations/css-styling/#default-text-properties.html#: Added.
  • web-platform-tests/mathml/relations/css-styling/attribute-mapping-001.html:
  • web-platform-tests/mathml/relations/css-styling/attribute-mapping-002.html:
  • web-platform-tests/mathml/relations/css-styling/blur-filter-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/blur-filter.html: Added.
  • web-platform-tests/mathml/relations/css-styling/clip-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/clip-path-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/clip-path.html: Added.
  • web-platform-tests/mathml/relations/css-styling/clip.html: Added.
  • web-platform-tests/mathml/relations/css-styling/color-001.html:
  • web-platform-tests/mathml/relations/css-styling/color-002.html:
  • web-platform-tests/mathml/relations/css-styling/color-003.html:
  • web-platform-tests/mathml/relations/css-styling/color-004.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004-expected.html.
  • web-platform-tests/mathml/relations/css-styling/color-004.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004.html.
  • web-platform-tests/mathml/relations/css-styling/color-005-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004-expected.html.
  • web-platform-tests/mathml/relations/css-styling/color-005.html: Added.
  • web-platform-tests/mathml/relations/css-styling/default-font-family.html: Added.
  • web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root.html: Added.
  • web-platform-tests/mathml/relations/css-styling/display-2.html: Added.
  • web-platform-tests/mathml/relations/css-styling/displaystyle-3.html: Added.
  • web-platform-tests/mathml/relations/css-styling/mathcolor-mathbackground-css-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/mathcolor-mathbackground-css.html: Added.
  • web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords-expected.html:
  • web-platform-tests/mathml/relations/css-styling/mathsize-attribute-css-keywords.html:
  • web-platform-tests/mathml/relations/css-styling/multi-column-layout.html: Added.
  • web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html:
  • web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003.html: Added.
  • web-platform-tests/mathml/relations/css-styling/padding-border-margin/w3c-import.log:
  • web-platform-tests/mathml/relations/css-styling/presentational-hints-001-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/presentational-hints-001.html: Added.
  • web-platform-tests/mathml/relations/css-styling/presentational-hints-002-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/presentational-hints-002.html: Added.
  • web-platform-tests/mathml/relations/css-styling/scriptlevel-001.html: Added.
  • web-platform-tests/mathml/relations/css-styling/transform-expected.html: Added.
  • web-platform-tests/mathml/relations/css-styling/transform.html: Added.
  • web-platform-tests/mathml/relations/css-styling/visibility-001.html:
  • web-platform-tests/mathml/relations/css-styling/visibility-002.html:
  • web-platform-tests/mathml/relations/css-styling/visibility-003.html:
  • web-platform-tests/mathml/relations/css-styling/visibility-004.tentative-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html.
  • web-platform-tests/mathml/relations/css-styling/visibility-004.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004.html.
  • web-platform-tests/mathml/relations/css-styling/visibility-005-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/visibility-004-expected.html.
  • web-platform-tests/mathml/relations/css-styling/visibility-005.html: Added.
  • web-platform-tests/mathml/relations/css-styling/w3c-import.log:
  • web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html:
  • web-platform-tests/mathml/relations/html5-tree/content-editable.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html:
  • web-platform-tests/mathml/relations/html5-tree/css-inline-style-interface.tentative.html:
  • web-platform-tests/mathml/relations/html5-tree/display-1.html:
  • web-platform-tests/mathml/relations/html5-tree/dynamic-2-expected.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/dynamic-2.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/href-click-3.html:
  • web-platform-tests/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html:
  • web-platform-tests/mathml/relations/html5-tree/integration-point-1.html:
  • web-platform-tests/mathml/relations/html5-tree/integration-point-4.html:
  • web-platform-tests/mathml/relations/html5-tree/integration-point-5.html: Added.
  • web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html:
  • web-platform-tests/mathml/relations/html5-tree/required-extensions-2.html:
  • web-platform-tests/mathml/relations/html5-tree/tabindex-001.html:
  • web-platform-tests/mathml/relations/html5-tree/tabindex-002.html:
  • web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
  • web-platform-tests/mathml/support/box-comparison.js:

(compareSizeWithAndWithoutStyle):

  • web-platform-tests/mathml/support/feature-detection.js:

(MathMLFeatureDetection.string_appeared_here):

  • web-platform-tests/mathml/support/layout-comparison.js:

(childrenHaveEmptyBoundingClientRects):

  • web-platform-tests/mathml/support/mathml-fragments.js:

(FragmentHelper.isTokenElement):

  • web-platform-tests/mathml/support/operator-dictionary.json:
  • web-platform-tests/mathml/tools/axisheight.py:
  • web-platform-tests/mathml/tools/fractions.py:
  • web-platform-tests/mathml/tools/largeop.py:
  • web-platform-tests/mathml/tools/limits.py:
  • web-platform-tests/mathml/tools/mathvariant-transforms.py:
  • web-platform-tests/mathml/tools/operator-dictionary.py:

(createStretchy):

  • web-platform-tests/mathml/tools/percentscaledown.py:
  • web-platform-tests/mathml/tools/radicals.py:

(createStretchyRadical):

  • web-platform-tests/mathml/tools/scripts.py:
  • web-platform-tests/mathml/tools/stacks.py:
  • web-platform-tests/mathml/tools/stretchstacks.py:
  • web-platform-tests/mathml/tools/underover.py:
  • web-platform-tests/mathml/tools/use-typo-lineheight.py:
  • web-platform-tests/mathml/tools/utils/pycache/w3c-import.log: Delete
  • web-platform-tests/mathml/tools/utils/mathfont.py:

(create):
(drawRectangleGlyph):

  • web-platform-tests/mathml/tools/utils/misc.py:
  • web-platform-tests/mathml/tools/utils/w3c-import.log:
  • web-platform-tests/mathml/tools/xHeight.py:

LayoutTests:

Resync WPT's mathml and math-script-level-and-math-style tests

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/cramped-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
  • platform/ios-13/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-006-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-script-level-001.tentative-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/css/css-fonts/math-script-level-and-math-style/math-style-001.tentative-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-3-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/legacy-orthogonal-pseudo-units-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mpadded/mpadded-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/inferred-mrow-baseline-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/mrow-preferred-width-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/no-spacing-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/spacing-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-font-relative-lengths-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-004-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-005-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-largeop-006-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-004-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-005-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-movablelimits-006-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-004-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-005-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-spacing-006-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-004-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-005-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-004-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/radicals/root-parameters-2-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/empty-underover-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.tentative-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/spaces/space-like-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/dynamic-table-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/attribute-mapping-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-font-family-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/default-properties-on-the-math-root-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/display-2-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/displaystyle-3-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/multi-column-layout-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/content-editable-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-5-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-001-expected.txt: Added.
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002-expected.txt: Added.
  • platform/wpe/TestExpectations:
  • tests-options.json:
8:11 AM Changeset in webkit [267530] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

Regression(r265280) Web Audio sources malfunction when disconnected from the audio graph
https://bugs.webkit.org/show_bug.cgi?id=216703
<rdar://problem/69158436>

Reviewed by Eric Carlson.

In case of an audio source that stops producing data, but does not end or mute the track,
we would continuously try to read the data until getting to the end of the data.
When reaching the end of the data, we would return silence and go back in time a little bit
to restart playing with some margin. This allows to read just one chunk of audio until we are back to the end of data.

We fix this by storing the end of the data counter when reaching it.
When trying to pull some more data, we will go back in time a little bit only if some more data was added in the meantime.
Otherwise, we just output silence.

Covered by manual test.

  • platform/audio/mac/AudioSampleDataSource.h:
  • platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pullSamplesInternal):

7:17 AM Changeset in webkit [267529] by svillar@igalia.com
  • 2 edits in trunk/Tools

[JHBUILD] Port jhbuild-wrapper to python3
https://bugs.webkit.org/show_bug.cgi?id=216916

Reviewed by Adrian Perez de Castro.

Python2 is at its EOL, distributions are starting to remove it and python3 should be used by default now. Migrated
jhbuild wrapper code to python3 (while keeping backwards compatibility with python2 just in case).

  • jhbuild/jhbuild-wrapper:

(ensure_jhbuild): Replace has_key() by the more pythonic construction with 'in'.

6:21 AM Changeset in webkit [267528] by Antti Koivisto
  • 5 edits
    2 adds in trunk

currentColor isn't recalculated when a text node doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=216780
<rdar://problem/69320933>

Reviewed by Antoine Quint.

Source/WebCore:

We fail to repaint with the new background color when 'background-color' property has value 'currentColor' and the current color changes.

Test case by Cory LaViska.

Test: fast/css/currentColor-background-paint.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaint const):

  • rendering/style/StyleBackgroundData.cpp:

(WebCore::StyleBackgroundData::isEquivalentForPainting const):

  • rendering/style/StyleBackgroundData.h:

LayoutTests:

  • fast/css/currentColor-background-paint-expected.html: Added.
  • fast/css/currentColor-background-paint.html: Added.
5:52 AM Changeset in webkit [267527] by cathiechen
  • 2 edits in trunk/Source/WebCore

Root node with stateless wheel event isn't always scrollable
https://bugs.webkit.org/show_bug.cgi?id=216875

Reviewed by Simon Fraser.

Root nodes are not always capable of handling wheel event. When it is a stateless wheel event which
does not trigger rubber-band, we should check the scroll content of the root node.

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::canHandleWheelEvent const): Stateless wheel event
doesn't trigger rubber-band, should check the scroll content.

4:54 AM Changeset in webkit [267526] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, reverting r267495 and r267512.
https://bugs.webkit.org/show_bug.cgi?id=216924

Broke transform-stream.html test

Reverted changesets:

"Missing scope release in JSDOMBuiltinConstructorBase"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267495

"Unreviewed, we should put it under js/dom since it is not
usable in JSC shell"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267512

4:49 AM Changeset in webkit [267525] by commit-queue@webkit.org
  • 4 edits
    4 deletes in trunk

Unreviewed, reverting r267507.
https://bugs.webkit.org/show_bug.cgi?id=216923

Broke two layout tests on windows

Reverted changeset:

"web audio api outputs silence for 302 redirected resource in
safari"
https://bugs.webkit.org/show_bug.cgi?id=214932
https://trac.webkit.org/changeset/267507

2:17 AM Changeset in webkit [267524] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION(r267502): [GTK][WPE] ephemeral WebKitWebsiteDataManager ignores TLS errors by default
https://bugs.webkit.org/show_bug.cgi?id=216919

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Initialize ignoreTLSErrors on website data store for ephemeral sessions.

  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkitWebsiteDataManagerConstructed):

Tools:

Add a test case to check we propagate the setting to the network process for ephemeral sessions too.

  • TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:

(EphemeralSSLTest::setup):
(EphemeralSSLTest::teardown):
(testTLSErrorsEphemeral):
(beforeAll):

2:16 AM Changeset in webkit [267523] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

REGRESSION(r267502) [GLIB] Make WTR ignoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=216911

Reviewed by Adrian Perez de Castro.

I forgot to initialize ignoreTLSErrors in network session parameters.

  • UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:

(WebKit::WebsiteDataStore::platformSetNetworkParameters):

12:35 AM Changeset in webkit [267522] by Ross Kirsling
  • 5 edits in trunk

%TypedArray%.prototype.fill must only evaluate its argument once
https://bugs.webkit.org/show_bug.cgi?id=216912

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/typedarray-fill.js:

Fix test.

  • test262/expectations.yaml:

Mark two test cases as passing.

Source/JavaScriptCore:

Currently, we evaluate the argument in typedArray.fill({ valueOf() { ... } }) once per filled element,
but it should only be evaluated once in total.

  • builtins/TypedArrayPrototype.js:

(fill):

12:10 AM Changeset in webkit [267521] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (iOS/Safari 14): MediaRecorder produces invalid video files
https://bugs.webkit.org/show_bug.cgi?id=216832
<rdar://problem/69377550>

Reviewed by Eric Carlson.

Start the audio and video timestamps at zero.
Compute the audio timestamp based on the sample count and the video timestamp based
on the time at which the video sample is received.

Covered by manually testing Safari generated videos on VLC, Chrome and Firefox.

  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::initialize):
(WebCore::MediaRecorderPrivateWriter::startAssetWriter):
(WebCore::copySampleBufferWithCurrentTimeStamp):
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
(WebCore::createAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):

12:01 AM Changeset in webkit [267520] by commit-queue@webkit.org
  • 4 edits in trunk/Source/ThirdParty/ANGLE

REGRESSION: Textures Fail to Render in WebGL from HLS Stream [iOS 14]
https://bugs.webkit.org/show_bug.cgi?id=215908
<rdar://problem/68000962>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-09-24
Reviewed by Dean Jackson.

Disable ANGLE workers until EAGL implementation is more complete.
Current implementation fails to compile any shader, since the
compilation happens in the worker thread and worker EAGL context
which does not use the same sharegroup as the main context.
The shader objects are created in the main context but the shader
source setting and compilation happens in the worker context.
EAGL needs a flush between state changes, and adding that
correctly is a bigger change to be done later.

Use sized formats when calling [EAGLContext -texImageIOSurface]
from EGL_ANGLE_iosurface_client_buffer code. The texImageIOSurface
accepts parameters with glTexImage2D logic. On ES3, some of the
internal formats must be sized formats. The EAGLContext instantiated
by ANGLE is ES3, even if the ANGLE context would be ES2.

No tests added since this should be caught with the many video
related tests. It's unclear why this is not the case -- at
least on real hw. This is to be investigated later, too.

  • src/libANGLE/renderer/driver_utils.h:

(rx::IsIOS):

  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:
  • src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::InitializeFeatures):

Note: See TracTimeline for information about the timeline view.