Context Navigation

← Previous Period
Next Period →

Timeline

Nov 9, 2020:

11:42 PM Changeset in webkit [269616] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

Exceptions under PlatformCALayerCocoa::drawLayerContents with DisplayList-backed layers
https://bugs.webkit.org/show_bug.cgi?id=218731

Reviewed by Simon Fraser.

No new tests; all tests will cover this once GPU Process for DOM rendering lands.

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayer::drawLayerContents):
Refactor this function to use three state savers, all released by scope instead of explicitly.
This fixes the bug in the title, which was that we would call +restoreGraphicsState on NSGraphicsContext
regardless of whether we have a platform context or not (while we'd only save if we /did/ have one).

platform/graphics/ios/FontAntialiasingStateSaver.h:

(WebCore::FontAntialiasingStateSaver::~FontAntialiasingStateSaver):
(WebCore::FontAntialiasingStateSaver::restore): Deleted.
Make FontAntialiasingStateSaver behave like all of the other -StateSavers, performing "restore"
in its destructor.

platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::drawWindowContent):
We don't have to restore explicitly anymore.

8:58 PM Changeset in webkit [269615] by Lauro Moura

2 edits in trunk/WebDriverTests

[WebDriver] Gardening some WPE failures

Unreviewed test gardening.

TestExpectations.json:

7:14 PM Changeset in webkit [269614] by Said Abou-Hallawa

134 edits
1 copy
1 move in trunk/Source

[GPU Process] Control the life cycle of the platform image by a new class named NativeImage
https://bugs.webkit.org/show_bug.cgi?id=218427

Reviewed by Simon Fraser.

Source/WebCore:

This adds a new level of indirection around NativeImagePtr which is now
renamed PlatformImagePtr. The goal is to control the life cycle of the
PlatfromImagePtr in WebKit regardless if it is retained outside WebKit
or not. In future patches, deleting the NativeImage will be observed by
RemoteResoureCache such that it will be removed from the GPUP cache when
the object is destroyed in WebP.

The new structural hierarchy of the bitmap image is the following:

CachedImage (responsible of receiving the encoded image data)
- BitmapImage (responsible of decoding the image data)
  - NativeImage (represents an image frame and controls the life cycle of PlatformImagePtr in WebKit)
    - PlatformImagePtr (represents a platform image and it is the result of ImageDecoder)

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::nativeImageForCurrentTime):

html/HTMLVideoElement.h:
html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::drawImage):

page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
(createContentCrossfadeAnimation):

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::frameImageAtIndexCacheIfNeeded):
(WebCore::BitmapImage::nativeImage):
(WebCore::BitmapImage::nativeImageForCurrentFrame):
(WebCore::BitmapImage::preTransformedNativeImageForCurrentFrame):
(WebCore::BitmapImage::nativeImageOfSize):
(WebCore::BitmapImage::framesNativeImages):
(WebCore::drawNativeImage):
(WebCore::BitmapImage::draw):

platform/graphics/BitmapImage.h:
platform/graphics/ConcreteImageBuffer.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawNativeImage):

platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPlatformImage):

platform/graphics/GraphicsContextGLImageExtractor.h:
platform/graphics/GraphicsContextImpl.h:
platform/graphics/Icon.h:
platform/graphics/Image.h:

(WebCore::Image::nativeImage):
(WebCore::Image::nativeImageForCurrentFrame):
(WebCore::Image::preTransformedNativeImageForCurrentFrame):
(WebCore::Image::nativeImageOfSize):

platform/graphics/ImageBackingStore.h:
platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::sinkIntoNativeImage):

platform/graphics/ImageBuffer.h:
platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::sinkIntoNativeImage):

platform/graphics/ImageBufferBackend.h:
platform/graphics/ImageDecoder.h:
platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::clearImage):
(WebCore::ImageFrame::singlePixelSolidColor const):

platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::nativeImage const):

platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::setNativeImage):
(WebCore::ImageSource::cacheMetadataAtIndex):
(WebCore::ImageSource::cachePlatformImageAtIndex):
(WebCore::ImageSource::cachePlatformImageAtIndexAsync):
(WebCore::ImageSource::startAsyncDecodingQueue):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::createFrameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndexCacheIfNeeded):
(WebCore::ImageSource::cacheNativeImageAtIndex): Deleted.
(WebCore::ImageSource::cacheNativeImageAtIndexAsync): Deleted.

platform/graphics/ImageSource.h:

(WebCore::ImageSource::create):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::nativeImageForCurrentTime):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::nativeImageForCurrentTime):

platform/graphics/NativeImage.cpp: Copied from Source/WebCore/platform/graphics/NativeImagePtr.h.

(WebCore::NativeImage::create):
(WebCore::NativeImage::NativeImage):

platform/graphics/NativeImage.h:

(WebCore::NativeImage::platformImage const):

platform/graphics/PlatformImage.h: Renamed from Source/WebCore/platform/graphics/NativeImagePtr.h.
platform/graphics/VideoLayerManager.h:
platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:
platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoFullscreenInlineImage):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::nativeImageForCurrentTime):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastImage):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenLayer):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoFullscreenLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateCurrentFrameImage):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):

platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h:
platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::setVideoFullscreenLayer):
(WebCore::VideoLayerManagerObjC::updateVideoFullscreenInlineImage):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsImage):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawShadowLayerBuffer):
(WebCore::Cairo::drawShadowImage):
(WebCore::Cairo::fillShadowBuffer):
(WebCore::Cairo::drawPlatformImage):
(WebCore::Cairo::drawNativeImage): Deleted.

platform/graphics/cairo/CairoOperations.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawPlatformImage):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::platformDrawNativeImage): Deleted.

platform/graphics/cairo/GraphicsContextGLCairo.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImageBuffer):
(WebCore::GraphicsContextImplCairo::drawNativeImage):
(WebCore::GraphicsContextImplCairo::drawPattern):
(WebCore::GraphicsContextImplCairo::clipToImageBuffer):

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/cairo/ImageBufferCairoBackend.cpp:

(WebCore::ImageBufferCairoBackend::draw):
(WebCore::ImageBufferCairoBackend::drawPattern):

platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:

(WebCore::ImageBufferCairoSurfaceBackend::copyNativeImage const):
(WebCore::ImageBufferCairoSurfaceBackend::cairoSurfaceCoerceToImage const):
(WebCore::ImageBufferCairoSurfaceBackend::toBGRAData const):

platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h:
platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::NativeImage::size const):
(WebCore::NativeImage::hasAlpha const):
(WebCore::NativeImage::singlePixelSolidColor const):
(WebCore::NativeImage::clearSubimages):
(WebCore::nativeImageSize): Deleted.
(WebCore::nativeImageHasAlpha): Deleted.
(WebCore::nativeImageSinglePixelSolidColor): Deleted.
(WebCore::drawNativeImage): Deleted.
(WebCore::clearNativeImageSubimages): Deleted.

platform/graphics/cairo/PatternCairo.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPlatformImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::platformDrawNativeImage): Deleted.

platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGLImageExtractor::extractImage):
(WebCore::GraphicsContextGLOpenGL::paintToCanvas):

platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded):
(WebCore::ImageBufferCGBackend::copyImage const):
(WebCore::ImageBufferCGBackend::draw):
(WebCore::ImageBufferCGBackend::toCFData const):

platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::copyNativeImage const):

platform/graphics/cg/ImageBufferCGBitmapBackend.h:
platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::copyNativeImage const):
(WebCore::ImageBufferIOSurfaceBackend::sinkIntoNativeImage):
(WebCore::ImageBufferIOSurfaceBackend::drawConsuming):

platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::createFrameImageAtIndex):

platform/graphics/cg/ImageDecoderCG.h:
platform/graphics/cg/NativeImageCG.cpp:

platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern const):

platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic):

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawNativeImage::decode):

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawNativeImage):

platform/graphics/displaylists/DisplayListRecorder.h:
platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::createFrameImageAtIndex):

platform/graphics/gstreamer/ImageDecoderGStreamer.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::nativeImageForCurrentTime):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
platform/graphics/gtk/ImageGtk.cpp:

(WebCore::BitmapImage::getGdkPixbuf):
(WebCore::BitmapImage::gdkTexture):

platform/graphics/ios/IconIOS.mm:

(WebCore::Icon::Icon):
(WebCore::Icon::createIconForImage):
(WebCore::Icon::paint):

platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::tiffRepresentation):
(WebCore::BitmapImage::snapshotNSImage):

platform/graphics/nicosia/NicosiaImageBufferPipe.cpp:

(Nicosia::NicosiaImageBufferPipeSource::handle):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawNativeImage):
(Nicosia::CairoOperationRecorder::drawPattern):
(Nicosia::CairoOperationRecorder::clipToImageBuffer):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
platform/graphics/win/Direct2DOperations.cpp:

(WebCore::Direct2D::drawPlatformImage):
(WebCore::Direct2D::drawNativeImage): Deleted.

platform/graphics/win/Direct2DOperations.h:
platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawPlatformImage):
(WebCore::GraphicsContext::platformDrawNativeImage): Deleted.

platform/graphics/win/GraphicsContextImplDirect2D.cpp:

(WebCore::GraphicsContextImplDirect2D::drawNativeImage):

platform/graphics/win/GraphicsContextImplDirect2D.h:
platform/graphics/win/ImageBufferDirect2DBackend.cpp:

(WebCore::ImageBufferDirect2DBackend::create):
(WebCore::ImageBufferDirect2DBackend::ImageBufferDirect2DBackend):
(WebCore::ImageBufferDirect2DBackend::copyNativeImage const):
(WebCore::createCroppedImageIfNecessary):
(WebCore::ImageBufferDirect2DBackend::copyImage const):
(WebCore::ImageBufferDirect2DBackend::sinkIntoImage):
(WebCore::ImageBufferDirect2DBackend::compatibleBitmap):

platform/graphics/win/ImageBufferDirect2DBackend.h:
platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::drawFrameMatchingSourceSize):

platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoderDirect2D::createFrameImageAtIndex):

platform/graphics/win/ImageDecoderDirect2D.h:
platform/graphics/win/NativeImageDirect2D.cpp:

platform/gtk/CursorGtk.cpp:

(WebCore::createCustomCursor):

platform/gtk/DragImageGtk.cpp:

(WebCore::createDragImageFromImage):

platform/image-decoders/ScalableImageDecoder.cpp:

(WebCore::ScalableImageDecoder::createFrameImageAtIndex):

platform/image-decoders/ScalableImageDecoder.h:
platform/image-decoders/cairo/ImageBackingStoreCairo.cpp:

(WebCore::ImageBackingStore::image const):

platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::emitFrame):

platform/mediastream/mac/DisplayCaptureSourceCocoa.h:
platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer):

platform/win/DragImageCGWin.cpp:

(WebCore::createDragImageFromImage):

platform/win/DragImageCairoWin.cpp:

(WebCore::createDragImageFromImage):

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintSystemPreviewBadge):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::nativeImage):

svg/graphics/SVGImage.h:
svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):

svg/graphics/SVGImageForContainer.h:

Source/WebKit:

Scripts/webkit/messages.py:
Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Ref<NativeImage>>::encode):
(IPC::ArgumentCoder<Ref<NativeImage>>::decode):
(IPC::encodeNativeImage): Deleted.
(IPC::decodeNativeImage): Deleted.
(IPC::encodeOptionalNativeImage): Deleted.
(IPC::decodeOptionalNativeImage): Deleted.
(IPC::ArgumentCoder<NativeImagePtr>::encode): Deleted.
(IPC::ArgumentCoder<NativeImagePtr>::decode): Deleted.

Shared/WebCoreArgumentCoders.h:
Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createImage):

Shared/win/ShareableBitmapDirect2D.cpp:

(WebKit::ShareableBitmap::paint):

UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::loadIconForPageURL):
(WebKit::IconDatabase::setIconForPageURL):

UIProcess/API/glib/IconDatabase.h:
UIProcess/ios/DragDropInteractionState.mm:

(WebKit::uiImageForImage):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _deliverDelayedDropPreviewIfPossible:]):
(uiImageForImage):
(-[WKContentView _handleDropByInsertingImagePlaceholders:session:]):
(-[WKContentView _presentationSnapshotForPreviewItemController:]):

WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::copyNativeImage const):

WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::isAlmostSolidColor):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChooseFilesForOpenPanelWithDisplayStringAndIcon):

Source/WebKitLegacy/mac:

DOM/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

Misc/WebCache.mm:

(+[WebCache imageForURL:]):

WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):

5:25 PM Changeset in webkit [269613] by Alan Coon

8 edits in branches/safari-610.3.7.1-branch/Source

Versioning.

WebKit-7610.3.7.1.3

4:29 PM Changeset in webkit [269612] by Chris Dumez

70 edits
78 deletes in trunk

Unexpose obsolete HTMLAppletElement interface
https://bugs.webkit.org/show_bug.cgi?id=218677

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/dom/nodes/getElementsByClassName-30-expected.txt:
web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-03-expected.txt:
web-platform-tests/html/dom/historical-expected.txt:
web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

Drop support for HTMLAppletElement. This feature is obsolete and has been removed from
the HTML specification. The <applet> element was removed in Gecko 56 and Chrome 47
already.

No new tests, rebaselined existing tests.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSPluginElementFunctions.cpp:
bindings/js/JSPluginElementFunctions.h:
html/CachedHTMLCollection.h:

(WebCore::nameShouldBeVisibleInDocumentAll):

html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches const):

html/HTMLAppletElement.cpp: Removed.
html/HTMLAppletElement.h: Removed.
html/HTMLAppletElement.idl: Removed.
html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):

html/HTMLPlugInImageElement.h:
html/HTMLTagNames.in:
loader/EmptyClients.cpp:
loader/EmptyFrameLoaderClient.h:
loader/FrameLoaderClient.h:
loader/SubframeLoader.cpp:
loader/SubframeLoader.h:
rendering/RenderEmbeddedObject.cpp:
rendering/RenderEmbeddedObject.h:

Source/WebKit:

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElement.cpp:

(webkit_dom_html_applet_element_dispatch_event):
(webkit_dom_html_applet_element_add_event_listener):
(webkit_dom_html_applet_element_remove_event_listener):
(webkit_dom_html_applet_element_get_align):
(webkit_dom_html_applet_element_set_align):
(webkit_dom_html_applet_element_get_alt):
(webkit_dom_html_applet_element_set_alt):
(webkit_dom_html_applet_element_get_archive):
(webkit_dom_html_applet_element_set_archive):
(webkit_dom_html_applet_element_get_code):
(webkit_dom_html_applet_element_set_code):
(webkit_dom_html_applet_element_get_code_base):
(webkit_dom_html_applet_element_set_code_base):
(webkit_dom_html_applet_element_get_height):
(webkit_dom_html_applet_element_set_height):
(webkit_dom_html_applet_element_get_hspace):
(webkit_dom_html_applet_element_set_hspace):
(webkit_dom_html_applet_element_get_name):
(webkit_dom_html_applet_element_set_name):
(webkit_dom_html_applet_element_get_object):
(webkit_dom_html_applet_element_set_object):
(webkit_dom_html_applet_element_get_vspace):
(webkit_dom_html_applet_element_set_vspace):
(webkit_dom_html_applet_element_get_width):
(webkit_dom_html_applet_element_set_width):

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElementPrivate.h:
WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLPrivate.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

DOM/DOMHTMLAppletElement.mm:

(-[DOMHTMLAppletElement align]):
(-[DOMHTMLAppletElement setAlign:]):
(-[DOMHTMLAppletElement alt]):
(-[DOMHTMLAppletElement setAlt:]):
(-[DOMHTMLAppletElement archive]):
(-[DOMHTMLAppletElement setArchive:]):
(-[DOMHTMLAppletElement code]):
(-[DOMHTMLAppletElement setCode:]):
(-[DOMHTMLAppletElement codeBase]):
(-[DOMHTMLAppletElement setCodeBase:]):
(-[DOMHTMLAppletElement height]):
(-[DOMHTMLAppletElement setHeight:]):
(-[DOMHTMLAppletElement hspace]):
(-[DOMHTMLAppletElement setHspace:]):
(-[DOMHTMLAppletElement name]):
(-[DOMHTMLAppletElement setName:]):
(-[DOMHTMLAppletElement object]):
(-[DOMHTMLAppletElement setObject:]):
(-[DOMHTMLAppletElement vspace]):
(-[DOMHTMLAppletElement setVspace:]):
(-[DOMHTMLAppletElement width]):
(-[DOMHTMLAppletElement setWidth:]):

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKitLegacy/win:

WebCoreSupport/WebFrameLoaderClient.cpp:
WebCoreSupport/WebFrameLoaderClient.h:
WebFrame.cpp:

LayoutTests:

dom/html/level2/html/HTMLAppletElement01-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement01.html: Removed.
dom/html/level2/html/HTMLAppletElement01.js: Removed.
dom/html/level2/html/HTMLAppletElement02-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement02.html: Removed.
dom/html/level2/html/HTMLAppletElement02.js: Removed.
dom/html/level2/html/HTMLAppletElement03-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement03.html: Removed.
dom/html/level2/html/HTMLAppletElement03.js: Removed.
dom/html/level2/html/HTMLAppletElement04-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement04.html: Removed.
dom/html/level2/html/HTMLAppletElement04.js: Removed.
dom/html/level2/html/HTMLAppletElement06-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement06.html: Removed.
dom/html/level2/html/HTMLAppletElement06.js: Removed.
dom/html/level2/html/HTMLAppletElement07-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement07.html: Removed.
dom/html/level2/html/HTMLAppletElement07.js: Removed.
dom/html/level2/html/HTMLAppletElement08-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement08.html: Removed.
dom/html/level2/html/HTMLAppletElement08.js: Removed.
dom/html/level2/html/HTMLAppletElement09-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement09.html: Removed.
dom/html/level2/html/HTMLAppletElement09.js: Removed.
dom/html/level2/html/HTMLAppletElement10-expected.txt: Removed.
dom/html/level2/html/HTMLAppletElement10.html: Removed.
dom/html/level2/html/HTMLAppletElement10.js: Removed.
dom/html/level2/html/HTMLDocument08.html: Removed.
dom/xhtml/level2/html/HTMLAppletElement01-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement01.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement01.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement02-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement02.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement02.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement03-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement03.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement03.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement04-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement04.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement04.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement06-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement06.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement06.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement07-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement07.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement07.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement08-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement08.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement08.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement09-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement09.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement09.xhtml: Removed.
dom/xhtml/level2/html/HTMLAppletElement10-expected.txt: Removed.
dom/xhtml/level2/html/HTMLAppletElement10.js: Removed.
dom/xhtml/level2/html/HTMLAppletElement10.xhtml: Removed.
dom/xhtml/level2/html/HTMLDocument08.xhtml: Removed.

Drop outdated tests.

fast/dom/HTMLDocument/document-special-properties-expected.txt:
fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/get-set-properties-expected.txt:
fast/dom/Window/get-set-properties.html:
fast/dom/Window/resources/window-properties.js:
fast/dom/Window/window-lookup-precedence-expected.txt:
fast/dom/Window/window-special-properties-expected.txt:
fast/dom/document-all-expected.txt:
fast/dom/document-all.html:
fast/dom/dom-constructors-expected.txt:
fast/dom/dom-constructors.html:
fast/dom/element-attribute-js-null-expected.txt:
fast/dom/element-attribute-js-null.html:
fast/dom/html-collections-named-getter-expected.txt:
fast/dom/html-collections-named-getter.html:
fast/dom/htmlcollection-non-html-expected.txt:
fast/dom/htmlcollection-non-html.html:
fast/dom/plugin-attributes-enumeration-expected.txt:
fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html:
fast/frames/sandboxed-iframe-plugins-expected.txt:
fast/frames/sandboxed-iframe-plugins.html:
fast/text/text-combine-crash-expected.txt:
http/tests/security/cross-frame-access-put-expected.txt:
platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:

Update / rebaseline existing tests to reflect behavior change.

platform/wk2/TestExpectations:

Drop outdated tests.

3:49 PM Changeset in webkit [269611] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Do not print master environment variables in build steps
https://bugs.webkit.org/show_bug.cgi?id=218711

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

(TransferToS3.init): Set logEnviron to False for newer buildbot.
(ExtractTestResults.init): Ditto.

3:48 PM Changeset in webkit [269610] by Peng Liu

2 edits in trunk/Source/WebKit

REGRESSION (r269557): ASSERTION FAILED: Completion handler should always be called under WebCore::HTMLMediaElement::exitFullscreen
https://bugs.webkit.org/show_bug.cgi?id=218722

Reviewed by Eric Carlson.

No new tests, covered by an existing test that is crashing on the bots.

WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

3:47 PM Changeset in webkit [269609] by commit-queue@webkit.org

4 edits
2 adds in trunk

Null dereference in CompositeEditCommand::splitTreeToNode() due to not checking for top of DOM tree
https://bugs.webkit.org/show_bug.cgi?id=218215

Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-11-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a check for a non-existent parent node when splitting a tree, and fix up
a caller to not pass a node without a parent node.

Test: editing/inserting/insert-list-in-iframe-in-list.html

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs):

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::unlistifyParagraph):

LayoutTests:

Add layout test that catches crash during insertion of a list inside an iframe
(that itself is inside of a list).

editing/inserting/insert-list-in-iframe-in-list-expected.txt: Added.
editing/inserting/insert-list-in-iframe-in-list.html: Added.

3:40 PM Changeset in webkit [269608] by commit-queue@webkit.org

3 edits in trunk/Tools

[JSC] Enable bytecode cache testing in stress tests for Linux
https://bugs.webkit.org/show_bug.cgi?id=218072

Patch by Xan López <Xan Lopez> on 2020-11-09
Reviewed by Yusuke Suzuki.

We only need to tweak how we define the temporary dir for the
bytecode cache in order for stress tests to support bytecode cache
testing on Linux.

This is skipped on Linux/MIPS for now, since the bots are already
slow enough and we have one blocker bug with incorrect parameter
quoting on some tests. See bug #218703.

Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:

receive the temporary dir template as an argument. Also tweak the
script a bit so that it does not use arrays, that way it will work
in any POSIX shell.

Scripts/run-jsc-stress-tests: pass a different temporary dir

template for Darwin and Linux, since mktemp works differently
there.

3:27 PM Changeset in webkit [269607] by Truitt Savell

2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] media/video-buffering-allowed.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=217621

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

3:11 PM Changeset in webkit [269606] by Wenson Hsieh

10 edits in trunk/Source

Rename ImageBuffer::flushDisplayList to ImageBuffer::submitDisplayList
https://bugs.webkit.org/show_bug.cgi?id=218720

Reviewed by Tim Horton.

Source/WebCore:

Rename flushDisplayList to submitDisplayList, to better capture the fact that it's only responsible for
applying the contents of the given display list rather than performing a context flush, or applying and clearing
out the contents of the given display list.

No change in behavior.

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::submitDisplayList):
(WebCore::ImageBuffer::flushDisplayList): Deleted.

Source/WebKit:

See Source/WebCore/ChangeLog for more details.

GPUProcess/graphics/RemoteImageBuffer.h:
GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::applyDisplayList):
(WebKit::RemoteRenderingBackend::submitDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayList): Deleted.

Additionally rename flushDisplayList on RemoteRenderingBackend, since this IPC message doesn't actually
perform a context flush.

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::submitDisplayList):
(WebKit::RemoteRenderingBackendProxy::flushDisplayList): Deleted.

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

2:54 PM Changeset in webkit [269605] by Alan Bujtas

39 edits
1 add
1 delete in trunk

Unreviewed, reverting r269603.

Needs Safari patch

Reverted changeset:

"Show legacy line layout visual coverage instead of "simple
line" layout."
https://bugs.webkit.org/show_bug.cgi?id=218695
https://trac.webkit.org/changeset/269603

2:49 PM Changeset in webkit [269604] by Truitt Savell

2 edits in trunk/LayoutTests

[Mac] inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-frames.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=218725

Unreviewed test gardening.

platform/mac/TestExpectationsRosetta:

2:28 PM Changeset in webkit [269603] by Alan Bujtas

39 edits
1 copy
1 delete in trunk

Show legacy line layout visual coverage instead of "simple line" layout.
https://bugs.webkit.org/show_bug.cgi?id=218695

Reviewed by Antti Koivisto.

Source/WebCore:

Paint legacy line layout content with the debug shadow instead of the modern one (and use red instead of blue).

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::debugTextShadow): Deleted.

layout/integration/LayoutIntegrationLineLayout.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintMarkedTextForeground):
(WebCore::InlineTextBox::debugTextShadow):

rendering/InlineTextBox.h:

Source/WebKit:

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLegacyLineLayoutVisualCoverageEnabled):
(WKPreferencesGetLegacyLineLayoutVisualCoverageEnabled):
(WKPreferencesSetSimpleLineLayoutDebugBordersEnabled): Deleted.
(WKPreferencesGetSimpleLineLayoutDebugBordersEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _legacyLineLayoutVisualCoverageEnabled]):
(-[WKPreferences _setLegacyLineLayoutVisualCoverageEnabled:]):
(-[WKPreferences _simpleLineLayoutDebugBordersEnabled]): Deleted.
(-[WKPreferences _setSimpleLineLayoutDebugBordersEnabled:]): Deleted.

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(-[WebPreferences legacyLineLayoutVisualCoverageEnabled]):
(-[WebPreferences setLegacyLineLayoutVisualCoverageEnabled:]):
(-[WebPreferences simpleLineLayoutDebugBordersEnabled]): Deleted.
(-[WebPreferences setSimpleLineLayoutDebugBordersEnabled:]): Deleted.

WebView/WebPreferencesPrivate.h:

Source/WTF:

Scripts/Preferences/WebPreferencesDebug.yaml:

Tools:

MiniBrowser/mac/SettingsController.h:
MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleLegacyLineLayoutVisualCoverageEnabled:]):
(-[SettingsController legacyLineLayoutVisualCoverageEnabled]):
(-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]): Deleted.
(-[SettingsController simpleLineLayoutDebugBordersEnabled]): Deleted.

MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

LayoutTests:

fast/inline/simple-line-layout-16bit-content-expected-mismatch.html: Removed.
fast/inline/simple-line-layout-16bit-content.html:
fast/text/simple-line-layout-do-not-support-unicode-range-expected.html:
fast/text/simple-line-layout-do-not-support-unicode-range.html:
fast/text/simple-line-layout-line-box-contain-glyphs-expected.html:
fast/text/simple-line-layout-line-box-contain-glyphs.html:
fast/text/simple-line-layout-no-surrogate-pairs-expected.html:
fast/text/simple-line-layout-no-surrogate-pairs.html:
fast/text/simple-line-layout-simple-text-but-complex-font-path-expected.html:
fast/text/simple-line-layout-simple-text-but-complex-font-path.html:
fast/text/simple-line-layout-with-text-underline-position-expected.html:
fast/text/simple-line-layout-with-text-underline-position.html:
fast/text/simple-lines-float-expected.html:
fast/text/simple-lines-float.html:
fast/text/simple-lines-hover-expected.html:
fast/text/simple-lines-hover.html:
fast/text/simple-lines-multiple-renderers-expected.html:
fast/text/simple-lines-multiple-renderers.html:

2:27 PM Changeset in webkit [269602] by Diego Pino Garcia

2 edits in trunk/Tools

[webkitpy] When platform is GTK or WPE, make lint-test-expectations lint GLIB too
https://bugs.webkit.org/show_bug.cgi?id=218691

Reviewed by Carlos Alberto Lopez Perez.

In the test expectations hierarchy, both GTK and WPE share a common
root, GLIB. It's not possible to lint GLIB test expectations as it's
not a platform with a builder associated. Thus, make lint-test-expectations
lint GLIB test expectations when linting GLIB or WPE.

Scripts/webkitpy/layout_tests/lint_test_expectations.py:

(lint):

1:54 PM Changeset in webkit [269601] by Simon Fraser

8 edits in trunk/Source/WebCore

[LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds
https://bugs.webkit.org/show_bug.cgi?id=218713

Reviewed by Zalan Bujtas.

Make BoxDecorationPainter into a class so it can hold references to the box, rounded rect
etc, and settle on a policy of passing PaintingContext as an argument to all the painting
functions.

Add code to compute the BackgroundBleedAvoidance policy, and implement the various policies
following rendering code.

display/css/DisplayBoxDecorationData.cpp:

(WebCore::Display::BorderEdge::obscuresBackgroundEdge const):
(WebCore::Display::BoxDecorationData::hasBorder const):
(WebCore::Display::BoxDecorationData::hasBorderRadius const):
(WebCore::Display::BoxDecorationData::borderObscuresBackground const):
(WebCore::Display::BoxDecorationData::borderObscuresBackgroundEdge const):

display/css/DisplayBoxDecorationData.h:

(WebCore::Display::borderWidths):

display/css/DisplayBoxDecorationPainter.cpp:

(WebCore::Display::BorderPainter::BorderPainter):
(WebCore::Display::roundedRectWithIncludedRadii):
(WebCore::Display::roundedInsetBorderForRect):
(WebCore::Display::BorderPainter::drawBoxSideFromPath const):
(WebCore::Display::BorderPainter::clipBorderSidePolygon const):
(WebCore::Display::BorderPainter::drawLineForBoxSide const):
(WebCore::Display::BorderPainter::paintOneBorderSide const):
(WebCore::Display::BorderPainter::paintBorderSides const):
(WebCore::Display::BorderPainter::paintTranslucentBorderSides const):
(WebCore::Display::shrinkRectByOneDevicePixel):
(WebCore::Display::BorderPainter::borderInnerRectAdjustedForBleedAvoidance const):
(WebCore::Display::BorderPainter::paintBorders const):
(WebCore::Display::BoxDecorationPainter::paintBorders const):
(WebCore::Display::BoxDecorationPainter::paintFillLayer const):
(WebCore::Display::BoxDecorationPainter::BoxDecorationPainter):
(WebCore::Display::BoxDecorationPainter::computeBorderRect):
(WebCore::Display::BoxDecorationPainter::paintBackgroundImages const):
(WebCore::Display::BoxDecorationPainter::backgroundRoundedRectAdjustedForBleedAvoidance const):
(WebCore::Display::BoxDecorationPainter::paintBackground const):
(WebCore::Display::BoxDecorationPainter::determineBackgroundBleedAvoidance):
(WebCore::Display::BoxDecorationPainter::paintBackgroundAndBorders const):
(): Deleted.
(WebCore::Display::BorderPainter::roundedBorderForRect const): Deleted.
(WebCore::Display::BorderPainter::roundedInsetBorderForRect const): Deleted.
(WebCore::Display::BoxDecorationPainter::paintBorders): Deleted.
(WebCore::Display::paintFillLayer): Deleted.
(WebCore::Display::BoxDecorationPainter::paintBackgroundImages): Deleted.
(WebCore::Display::BoxDecorationPainter::paintBackground): Deleted.
(WebCore::Display::BoxDecorationPainter::paintBackgroundAndBorders): Deleted.

display/css/DisplayBoxDecorationPainter.h:

(WebCore::Display::BoxDecorationPainter::borderRoundedRect const):
(WebCore::Display::BoxDecorationPainter::includeLeftEdge const):
(WebCore::Display::BoxDecorationPainter::includeRightEdge const):

display/css/DisplayBoxPainter.cpp:

(WebCore::Display::BoxPainter::paintBoxDecorations):

display/css/DisplayStyle.cpp:

(WebCore::Display::Style::backgroundHasOpaqueTopLayer const):

display/css/DisplayStyle.h:

1:41 PM Changeset in webkit [269600] by Alan Bujtas

62 edits in trunk

[LFC][Integration] Enable inline image support
https://bugs.webkit.org/show_bug.cgi?id=217874

Source/WebCore:

Reviewed by Antti Koivisto.

layout/integration/LayoutIntegrationCoverage.cpp:

LayoutTests:

Combination of different issues:

Do not retain the whitespace (new line) after the replaced content.
Do not treat images+text as unbreakable content (neither FF nor Chrome does)
Rounding differences.

Reviewed by Antti Koivisto.

1:28 PM Changeset in webkit [269599] by Fujii Hironori

4 edits in trunk

[TextureMapper] backdrop-filter should use the identity transform to render the root layer
https://bugs.webkit.org/show_bug.cgi?id=218699

Reviewed by Don Olmstead.

Source/WebCore:

Even thouth CSS reflections mirror the content, backdrop-filter in
the reflection doesn't. It sees through the background.
css3/filters/backdrop/backdrop-filter-with-reflection.html is the
test case.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
Removed TextureMapperPaintOptions::isReplica.

LayoutTests:

platform/glib/TestExpectations: Unmarked

css3/filters/backdrop/{backdrop-filter-with-reflection-add-backdrop.html,
backdrop-filter-with-reflection-value-change.html,backdrop-filter-with-reflection.html}

1:23 PM Changeset in webkit [269598] by Chris Dumez

154 edits
5 copies
207 adds
8 deletes in trunk/LayoutTests

Resync web-platform-tests/html tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218670

Reviewed by Sam Weinig.

Resync web-platform-tests/html tests from upstream 7a287c9e26fbc12.

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/html/*: Updated.

1:18 PM Changeset in webkit [269597] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Add total counts to sampling profiler dump
https://bugs.webkit.org/show_bug.cgi?id=218666

Reviewed by Yusuke Suzuki.

This is nice for computing the approximate percentage of total time in a function.

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):

12:53 PM Changeset in webkit [269596] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Use workersrc instead of slavesrc for new Buildbot
https://bugs.webkit.org/show_bug.cgi?id=218717

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

(UploadBuiltProduct.init): Used workersrc instead of slavesrc.
(UploadTestResults.init): Ditto.
(Run32bitJSCTests.start): Drive-by fix to use workerEnvironment instead of slaveEnvironment.

12:25 PM Changeset in webkit [269595] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] remove unused imports from loadConfig.py
https://bugs.webkit.org/show_bug.cgi?id=218718

Reviewed by Dewei Zhu.

CISupport/build-webkit-org/loadConfig.py:

12:21 PM Changeset in webkit [269594] by Aditya Keerthi

6 edits in trunk/LayoutTests

Remove experimental: and internal: prefixes from recently added tests
https://bugs.webkit.org/show_bug.cgi?id=218658

Reviewed by Devin Rousso.

The tests below were written before r269360. Since the experimental:
and internal: prefixes are no longer needed, they should be removed.

contact-picker/contacts-select-after-dismissing-picker.html:
contact-picker/contacts-select-while-presenting-picker.html:
contact-picker/contacts-select.html:
fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode-expected.html:
fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode.html:

12:20 PM Changeset in webkit [269593] by pvollan@apple.com

21 edits
6 adds in trunk

[macOS] System sounds should be played in the UI process
https://bugs.webkit.org/show_bug.cgi?id=218405
Source/WebCore:

<rdar://problem/70898846>

Reviewed by Darin Adler.

In preparation of blocking the system sound server in the WebContent process, system sounds should be played in the UI process.
This patch creates a system sound manager, which delegates the sound request if a delegate is present, otherwise the function
PAL::systemBeep will be called.

API test: WebKit.SystemBeep

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp:

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::performDelete):

editing/EditorCommand.cpp:

(WebCore::executeSelectToMark):
(WebCore::executeSwapWithMark):

editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::takeFindStringFromSelection):

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::beep):

platform/SystemSoundDelegate.h: Added.

(WebCore::SystemSoundDelegate::~SystemSoundDelegate):
(WebCore::SystemSoundDelegate::systemBeep):

platform/SystemSoundManager.cpp: Added.

(WebCore::SystemSoundManager::singleton):
(WebCore::SystemSoundManager::setSystemSoundDelegate):
(WebCore::SystemSoundManager::systemBeep):

platform/SystemSoundManager.h: Added.
platform/audio/StereoPanner.cpp:
testing/Internals.cpp:

(WebCore::Internals::systemBeep):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

<rdar://problem/70898846>

Reviewed by Darin Adler.

Subclass SystemSoundDelegate, which will forward system sound requests to the UI process.

Sources.txt:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::systemBeep):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebSystemSoundDelegate.cpp: Added.

(WebKit::WebSystemSoundDelegate::systemBeep):

WebProcess/WebSystemSoundDelegate.h: Added.
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Reviewed by Darin Adler.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/SystemBeep.mm: Added.

(TEST):

12:19 PM Changeset in webkit [269592] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add testcase for r269538
https://bugs.webkit.org/show_bug.cgi?id=218502

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-09
Reviewed by Simon Fraser.

I forgot to add a testcase in r269538.

fast/css/marquee-with-layer-display-inline-crash-expected.txt: Added.
fast/css/marquee-with-layer-display-inline-crash.html: Added.

12:16 PM Changeset in webkit [269591] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Clean up some code after inline display list refactoring
https://bugs.webkit.org/show_bug.cgi?id=218714

Reviewed by Tim Horton.

See below for more details.

platform/graphics/displaylists/DisplayListItems.h:

Remove a couple of extraneous encode() and decode() method declarations.

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

Add a missing ++ for this counter variable.

12:10 PM Changeset in webkit [269590] by keith_miller@apple.com

1 edit
2 adds in trunk/JSTests

Add microbenchmark for FinalizationRegistry basic usage
https://bugs.webkit.org/show_bug.cgi?id=218667

Reviewed by Yusuke Suzuki.

The no unregister token benchmark runs in ~40ms and the unregister
token in ~25ms on my Mac Pro. Interestingly, it also shows that
using an unregister token make FinalizationRegistry ~4x slower
(total time is longer because the number of objects is 10x bigger
in the test). This is because we have to store all the data in a
HashMap<UnregisterToken, JSObject> rather than a Vector<JSObject>.

microbenchmarks/finalizationRegistryCleanup.js: Added.

(async callback):

microbenchmarks/finalizationRegistryCleanupWithUnregisterToken.js: Added.

(async callback):

11:31 AM Changeset in webkit [269589] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[Cocoa] Diagnostic service sandbox violation loading any webpage
https://bugs.webkit.org/show_bug.cgi?id=218710
<rdar://problem/71124931>

Reviewed by Alexey Proskuryakov.

Loading any Web page will cause a diagnostic service mach-lookup sandbox violation. Consume the extension to
the service as early as possible in WebProcess::platformInitializeWebProcess, since there are code paths in
this method which will try to access the diagnostic service.

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

11:11 AM Changeset in webkit [269588] by Fujii Hironori

4 edits
2 adds in trunk

[TextureMapper] The top and left sides of drop-shadow are clipped
https://bugs.webkit.org/show_bug.cgi?id=218647

Reviewed by Don Olmstead.

Source/WebCore:

TextureMapperLayer::computeOverlapRegions incorrectly calculated
the local bounding rect for top and left of outsets.

The drop-shadow was incorrectly blended with the content.

Test: compositing/filters/drop-shadow.html

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeOverlapRegions): Stopped
using std::max for the left and top of outsets. Stopped taking the
unite with unfilteredTargetRect because outsets are always
positive.

platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Fixed sourceOver().

LayoutTests:

compositing/filters/drop-shadow-expected.html: Added.
compositing/filters/drop-shadow.html: Added.

11:08 AM Changeset in webkit [269587] by Devin Rousso

21 edits
2 adds in trunk

autofocus of text input should not select text
https://bugs.webkit.org/show_bug.cgi?id=218585
<rdar://problem/60130704>

Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/forms/input-text-autofocus.html

dom/Document.h:
history/CachedPage.cpp:

(WebCore::CachedPage::restore):

html/HTMLInputElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateFocusAppearance):
(WebCore::HTMLInputElement::setDefaultSelectionAfterFocus):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::didAttachRenderers):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

html/InputType.cpp:

(WebCore::InputType::accessKeyAction):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent):

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Slightly rework SelectionRestorationMode to replace SetDefault with two new values:

PlaceCaretAtStart puts the caret at the start, regardless of any cached selection
SelectAll selects all text, regardless of any cached selection (existing behavior)

In order to preserve existing behavior, the default Restore will have the same effect as
SelectAll if there is no cached selection (and is renamed to RestoreOrSelectAll as such).

dom/Element.h:
dom/Element.cpp:

(WebCore::Element::focus):

html/HTMLLabelElement.h:
html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::focus):

html/HTMLLegendElement.h:
html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::focus):
Replace the bool restorePreviousSelection with SelectionRestorationMode since that's
what it's eventually used for anyways. This also allows for more flexibility in behavior,
such as callers using the new SelectionRestorationMode values.

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didAttachRenderers):
Change to PlaceCaretAtStart to match other browsers.

Source/WebKit:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSelectionInFocusedEditableElement):
Slightly rework SelectionRestorationMode to replace SetDefault with two new values:

PlaceCaretAtStart puts the caret at the start, regardless of any cached selection
SelectAll selects all text, regardless of any cached selection (existing behavior)

In order to preserve existing behavior, the default Restore will have the same effect as
SelectAll if there is no cached selection (and is renamed to RestoreOrSelectAll as such).

LayoutTests:

fast/forms/input-text-autofocus.html: Added.
fast/forms/input-text-autofocus-expected.txt: Added.

fast/forms/input-first-letter-edit.html:
fast/forms/input-first-letter-edit-expected.html:

10:53 AM Changeset in webkit [269586] by commit-queue@webkit.org

2 edits in trunk

Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=218613

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-11-09
Reviewed by Carlos Alberto Lopez Perez.

Normally we fall back to cloop when JIT is not supported. But on aarch64, llint asm is well-
supported, so it is safe to use that here. This will only happen on aarch64, and only when
USE(64KB_PAGE_BLOCK) is enabled, which should probably only be used by RHEL and SUSE.
Everyone else should get the JIT.

Source/cmake/WebKitFeatures.cmake:

10:30 AM Changeset in webkit [269585] by Antti Koivisto

3 edits in trunk/Source/WebCore

[LFC] Initialize border style correctly
https://bugs.webkit.org/show_bug.cgi?id=218712

Reviewed by Zalan Bujtas.

Tested by fast/events/drag-image-with-border-image.html with image integration enabled.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedBorder const):

BorderValue::boxModelWidth() doesn't take non-color decorations into account.
Calling style.borderLeftWidth() and pals does the right thing.

rendering/style/BorderValue.h:

(WebCore::BorderValue::style const):
(WebCore::BorderValue::boxModelWidth const): Deleted.

Remove this unneeded helper.

10:00 AM Changeset in webkit [269584] by pvollan@apple.com

13 edits
3 copies
4 adds in trunk

[macOS] Set preference for overridden languages in the WebContent process after entering the sandbox.
https://bugs.webkit.org/show_bug.cgi?id=218097
Source/WebKit:

<rdar://problem/70586545>

Reviewed by Alexey Proskuryakov.

Currently, the preference for overridden languages in the WebContent process is set before entering the sandbox,
which leaves behind an open connection to opendirectoryd. This preference should be set after entering the
sandbox to avoid this. This patch sets the preference after the initialization function has been executed.

API test: WebKit.OverrideAppleLanguagesPreference

Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::setAppleLanguagesPreference):
(WebKit::XPCServiceEventHandler):
(WebKit::XPCServiceMain):

WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

Reviewed by Alexey Proskuryakov.

Disable CFPrefs direct mode for older versions of macOS. In practice, it was already disabled since a mach connection to cfprefsd
was established before entering the sandbox on older versions on macOS, but that is fixed in this patch.

wtf/PlatformEnableCocoa.h:

Tools:

Reviewed by Alexey Proskuryakov.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm:
TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm: Added.

(TEST):

TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:

LayoutTests:

Reviewed by Alexey Proskuryakov.

Add test for sandbox access to cfprefsd.daemon, and mark cfprefsd tests as failing for Mojave and Catalina, since CFPrefs
direct mode is not enabled on those versions of macOS.

fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
fast/sandbox/mac/sandbox-mach-lookup.html:
platform/mac-catalina/fast/sandbox: Added.
platform/mac-catalina/fast/sandbox/mac: Added.
platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt: Added.
platform/mac-mojave/fast/sandbox: Added.
platform/mac-mojave/fast/sandbox/mac: Added.
platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt: Added.

9:55 AM Changeset in webkit [269583] by Chris Lord

3 edits in trunk/Source/WebCore

[GTK] kinetic scroll speed should be cumulative
https://bugs.webkit.org/show_bug.cgi?id=203914

Reviewed by Carlos Garcia Campos.

Accumulate velocity in the same direction with ScrollAnimationKinetic.

platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::stop):
(WebCore::ScrollAnimationKinetic::start):
(WebCore::ScrollAnimationKinetic::animationTimerFired):
(WebCore::ScrollAnimationKinetic::deltaToNextFrame):

platform/ScrollAnimationKinetic.h:

9:26 AM Changeset in webkit [269582] by Chris Dumez

4 edits in trunk

Look at parents when event bubbles for input element activation behavior
https://bugs.webkit.org/show_bug.cgi?id=218660

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now fully passing.

web-platform-tests/dom/events/Event-dispatch-click-expected.txt:

Source/WebCore:

When a click event is dispatched at a node that is not an HTMLInputElement, and if the
event bubbles, we should look up the tree to see if there is an HTMLInputElement that
we should trigger activation behavior for. Prevously, we were failing to do this.

The new behavior is consistent with Blink.

No new tests, rebaselined existing test.

dom/EventDispatcher.cpp:

(WebCore::findInputElementInEventPath):
(WebCore::EventDispatcher::dispatchEvent):

8:41 AM Changeset in webkit [269581] by aakash_jain@apple.com

6 edits in trunk/Tools

[build.webkit.org] Add python 3 support - part 3
https://bugs.webkit.org/show_bug.cgi?id=218706

Reviewed by Jonathan Bedard.

CISupport/Shared/transfer-archive-to-s3: Updated print method to be both python 2 and 3 compatible.
CISupport/built-product-archive: Ditto.
CISupport/delete-stale-build-files: Ditto.
CISupport/build-webkit-org/loadConfig.py: Removed unnecessary filter method.
CISupport/ews-build/loadConfig.py: Ditto.

2:30 AM Changeset in webkit [269580] by jh718.park@samsung.com

2 edits in trunk/Source/WebKit

Unreviewed. Fix the build warning below since r269525.
warning: control reaches end of non-void function [-Wreturn-type]

No new tests, no new behaviors.

WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

2:20 AM Changeset in webkit [269579] by Chris Lord

9 edits in trunk/Source/WebCore

[GTK][WPE] Scrolling with mouse wheel doesn't work on iframes with async scrolling enabled
https://bugs.webkit.org/show_bug.cgi?id=214179

Reviewed by Žan Doberšek.

Implement ScrollingTree::scrollingNodeForPoint in
ScrollingTreeNicosia. This fixes overflow and iframe scrolling when
async scrolling is enabled on WPE and GTK ports.

page/scrolling/ThreadedScrollingTree.h:
page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeFrameScrollingNodeNicosia::commitStateBeforeChildren):

page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.h:
page/scrolling/nicosia/ScrollingTreeNicosia.cpp:

(WebCore::collectDescendantLayersAtPoint):
(WebCore::ScrollingTreeNicosia::scrollingNodeForPoint):

page/scrolling/nicosia/ScrollingTreeNicosia.h:
page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.cpp:

(WebCore::ScrollingTreeOverflowScrollingNodeNicosia::commitStateBeforeChildren):

page/scrolling/nicosia/ScrollingTreeOverflowScrollingNodeNicosia.h:
platform/graphics/nicosia/NicosiaPlatformLayer.h:

(Nicosia::CompositionLayer::flushState):
(Nicosia::CompositionLayer::accessPending):

2:19 AM Changeset in webkit [269578] by Chris Lord

4 edits in trunk

REGRESSION(r269503): [GTK][WPE] >200 tests are failing
https://bugs.webkit.org/show_bug.cgi?id=218654
<rdar://problem/71116949>

Reviewed by Žan Doberšek.

Source/WebCore:

Replace the NativeImagePtr calls with ImageBuffer::draw. With the
cairo implementation, in the cases where it's possible, it amounts to
the same thing, but the draw implementation also handles cases that
the previous patch didn't.

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImageBuffer):

LayoutTests:

Mark 5 canvas tests as passing.

platform/glib/TestExpectations:

12:20 AM Changeset in webkit [269577] by zandobersek@gmail.com

3 edits in trunk/Source/WebKit

[WPE] ScrollGestureController should only handle complete touch interactions
https://bugs.webkit.org/show_bug.cgi?id=218329

Reviewed by Carlos Garcia Campos.

ScrollGestureController's purpose is to handle otherwise-unhandled
touch events and translate those into a scrolling gesture.

Until now, it was possible for a touch motion event to trigger that
gesture even when the corresponding touch down event was not handled
by the ScrollGestureController, e.g. it was not produced due to the
touch interaction being started somewhere else, or the Web content
actually handled that event.

A flag is added to ScrollGestureController to track that an unhandled
touch down event was confronted, before allowing subsequent unhandled
touch motion events to trigger the scrolling gesture when conditions
are met. The flag is reset upon the touch up event.

UIProcess/API/wpe/ScrollGestureController.cpp:

(WebKit::ScrollGestureController::handleEvent):

UIProcess/API/wpe/ScrollGestureController.h:

Nov 8, 2020:

9:31 PM Changeset in webkit [269576] by ysuzuki@apple.com

8 edits
1 add in trunk

[JSC] Add TimeZone range cache over ICU TimeZone API
https://bugs.webkit.org/show_bug.cgi?id=218681

Reviewed by Ross Kirsling.

JSTests:

complex.yaml:
complex/timezone-range-cache-with-dst.js: Added.

(shouldBe):
(throw.new.Error):

Source/JavaScriptCore:

icu::TimeZone is more accurate and faster than localtime_r. But still, it is slower than returning cached data!
We saw 10% regression in JetStream2/date-format-xparb-SP with icu::TimeZone switching.
In this patch, we put one-depth timezone cache back over icu::TimeZone API, and recover the performance.
In addition, new version of timezone cache includes "start" side extension (while old one only extends "end" of the range).
The test covers all cases in the added cache.

runtime/JSDateMath.cpp:

(JSC::DateCache::calculateLocalTimeOffset):
(JSC::DateCache::localTimeOffset):
(JSC::DateCache::gregorianDateTimeToMS):
(JSC::DateCache::msToGregorianDateTime):
(JSC::DateCache::parseDate):
(JSC::DateCache::reset):
(JSC::localTimeOffset): Deleted.

runtime/JSDateMath.h:

(JSC::DateCache::timeZoneCache):

runtime/VM.h:

(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache): Deleted.
(JSC::LocalTimeOffsetCache::reset): Deleted.

Source/WTF:

wtf/DateMath.h:

9:04 PM Changeset in webkit [269575] by Lauro Moura

8 edits in trunk/LayoutTests

[GLIB] Rebaseline and gardening

Unreviewed test gardening.

platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: r269477
platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: r269477
platform/wpe/TestExpectations: Add bug for imported/blink/fast/forms/textarea-placeholder-visibility-3.html
platform/wpe/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: r269477
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: r269477
platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: r269477
platform/wpe/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: r269439-r269459

9:02 PM Changeset in webkit [269574] by ysuzuki@apple.com

12 edits in trunk

[JSC] Support @@species in ArrayBuffer / SharedArrayBuffer slice
https://bugs.webkit.org/show_bug.cgi?id=218697

Reviewed by Ross Kirsling.

JSTests:

test262/expectations.yaml:

Source/JavaScriptCore:

This patch adds support for @@species in ArrayBuffer/SharedArrayBuffer.prototype.slice.
We leverage the mechanism similar to Array's @@species handling: adding fast path with watchpoint.
When we found that some of critical properties (e.g. %Prototype%.constructor, %Constructor%[@@species])
are modified, watchpoint is fired and we go to the slow path. Until that, we use fast path that is
basically the same to the code before this patch.

runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::slice const):
(JSC::ArrayBuffer::sliceWithClampedIndex const):
(JSC::ArrayBuffer::sliceImpl const): Deleted.

runtime/ArrayBuffer.h:
runtime/ArrayBufferSharingMode.h:
runtime/ArrayPrototype.cpp:

(JSC::speciesWatchpointIsValid):

runtime/JSArrayBufferPrototype.cpp:

(JSC::speciesWatchpointIsValid):
(JSC::arrayBufferSlice):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::tryInstallSpeciesWatchpoint):
(JSC::JSGlobalObject::tryInstallArraySpeciesWatchpoint):
(JSC::JSGlobalObject::tryInstallArrayBufferSpeciesWatchpoint):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::arrayBufferSpeciesWatchpointSet):
(JSC::JSGlobalObject::arrayBufferPrototype const):
(JSC::JSGlobalObject::arrayBufferStructure const):
(JSC::JSGlobalObject::arrayBufferConstructor const):

Source/WTF:

Remove ENABLE(SHARED_ARRAY_BUFFER) flag. We use Options::useSharedArrayBuffer() runtime flag instead.

wtf/PlatformEnable.h:

8:26 PM Changeset in webkit [269573] by Lauro Moura

4 edits in trunk

[GTK] REGRESSION(r267250) API test /webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing
https://bugs.webkit.org/show_bug.cgi?id=216727

Reviewed by Carlos Garcia Campos.

Source/WebKit:

Coverered by existing tests.

In some cases, like in TestWebKitAPI, a message can arrive to the
GeolocationProvider and it would try to access a WebGeolocationManager
that could already had been deleted.

UIProcess/API/glib/WebKitGeolocationManager.cpp:

(webkitGeolocationManagerDispose): Added. Removes the provider.
(webkit_geolocation_manager_class_init): Register dispose callback.

Tools:

TestWebKitAPI/glib/TestExpectations.json: Remove expectations

8:20 PM Changeset in webkit [269572] by Lauro Moura

2 edits in trunk/LayoutTests

[GLIB] Gardening canvas failures while patch is reviewed

Unreviewed test gardening.

platform/glib/TestExpectations:

12:05 PM Changeset in webkit [269571] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC][Integration] Cleanup LayoutIntegration::Line interface
https://bugs.webkit.org/show_bug.cgi?id=218690

Reviewed by Daniel Bates and Antti Koivisto.

LayoutIntegration::Line has the following set of geometries:

Line rect and line box size:

Line is always as tall as the line box is. However they may differ in width.
While line box encloses all the inline level boxes on the line horizontally,
the line itself may be shorter (and trigger horizontal overflow).

Enclosing content rect:

It encloses all inline level boxes both vertically and horizontally. In certain cases (see line-height property)
the line (and the line box) is not as tall as the inline level boxes on the line.

Scrollable overflow rect:

It's mainly the line box (encloses the inline level boxes horizontally) with some end padding adjustment for the caret (see legacy line layout).

Ink overflow rect:

Regular ink overflow e.g. stroke, letter spacing.

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLines const):

11:51 AM Changeset in webkit [269570] by Fujii Hironori

4 edits
2 adds in trunk

TextureMapperLayer::computeOverlapRegions: Accumulate nested replica transform matrices recursively
https://bugs.webkit.org/show_bug.cgi?id=218364

Reviewed by Don Olmstead.

Source/WebCore:

Transformed nested reflection layers were wrongly clipped because
computeOverlapRegions applied replica transform matrices
incorrectly.

Test: compositing/reflections/nested-reflection-opacity2.html

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::resolveOverlaps):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

platform/graphics/texmap/TextureMapperLayer.h:

LayoutTests:

compositing/reflections/nested-reflection-opacity2-expected.html: Added.
compositing/reflections/nested-reflection-opacity2.html: Added.

11:49 AM Changeset in webkit [269569] by Fujii Hironori

2 edits in trunk/Source/WebCore

[GraphicsLayerTextureMapper] reflection masks aren't applied
https://bugs.webkit.org/show_bug.cgi?id=218429

Reviewed by Don Olmstead.

The backing store of the mask layer of replica layers aren't
updated at all since r178111.

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers):
Use updateBackingStoreIncludingSubLayers for the replica layer to
update backing stores recursively instead of updating only one
layer by using updateBackingStoreIfNeeded.

11:41 AM Changeset in webkit [269568] by Darin Adler

15 edits
2 adds in trunk

Remove another function that implicitly uses the composed tree (documentOrder on nodes and boundary points)
https://bugs.webkit.org/show_bug.cgi?id=218673

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/treeOrderBoundaryPoint.html

accessibility/AXObjectCache.cpp:

(WebCore::characterOffsetsInOrder): Use treeOrder<ComposedTree>.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::misspellingRange const): Ditto.
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Ditto.

dom/BoundaryPoint.h: Removed documentOrder, added treeOrderForTesting.

dom/Node.cpp: Updated comment referring to documentOrder.

dom/Position.cpp:

(WebCore::documentOrder): Use treeOrder<ComposedTree>.

dom/SimpleRange.cpp:

(WebCore::treeOrderForTesting): Added.
(WebCore::documentOrder): Deleted.
(WebCore::compareByComposedTreeOrder): Renamed from compareByDocumentOrder and
use treeOrder<ComposedTree>.
(WebCore::unionRange): Use compareByComposedTreeOrder.
(WebCore::intersection): Ditto.

dom/SimpleRange.h: Removed documentOrder. Also removed some repeated function

and function template declarations that were left in here by accident.

editing/TextIterator.cpp:

(WebCore::characterCount): Use treeOrder<ComposedTree>.

testing/Internals.cpp:

(WebCore::Internals::treeOrderBoundaryPoints): Added.

testing/Internals.h: Ditto.
testing/Internals.idl: Ditto.

Tools:

TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp: Removed BoundaryPointOffsetZero and

BoundaryPointOffsets tests, both replaced by a internals-based test.

LayoutTests:

fast/dom/treeOrderBoundaryPoint-expected.txt: Added.
fast/dom/treeOrderBoundaryPoint.html: Added.

12:31 AM Changeset in webkit [269567] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add testcase for r269537
https://bugs.webkit.org/show_bug.cgi?id=218499

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-08
Reviewed by Ryosuke Niwa.

I forgot to add a testcase in r269537.

fast/overflow/line-clamp-crash-expected.txt: Added.
fast/overflow/line-clamp-crash.html: Added.

Nov 7, 2020:

2:20 PM Changeset in webkit [269566] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix warning related to unsigned >=0 ASSERT
https://bugs.webkit.org/show_bug.cgi?id=218682

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-07
Reviewed by Fujii Hironori.

Source/WebCore/rendering/RenderText.cpp:592:19: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]

rendering/RenderText.cpp:

(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):

2:16 PM Changeset in webkit [269565] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix GTK debug build
https://bugs.webkit.org/show_bug.cgi?id=218683

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-07
Reviewed by Fujii Hironori.

Commit r269435 forgot to account for Frame* -> WeakPtr<Frame>
change in this ASSERT.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

2:13 PM Changeset in webkit [269564] by Wenson Hsieh

4 edits in trunk/Source/WebKit

Clean up some logic in RemoteImageBuffer and RemoteRenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=218689

Reviewed by Tim Horton.

Move the implementation of decodeItem out of RemoteImageBuffer, and into RemoteRenderingBackend. This
allows us to avoid static_cast-ing image buffers to their unaccelerated or accelerated versions when setting
the display list's item buffer client in the GPU process.

No change in behavior.

GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::decodeAndCreate): Deleted.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::applyDisplayList):

Also, remove a couple of unnecessary WebCore:: namespace prefixes while we're here.

(WebKit::RemoteRenderingBackend::decodeItem):

Move decodeItem into the rendering backend. This also has the added bonus of letting us put the method
definition in the implementation file instead of a header (i.e. RemoteRenderingBackend.cpp).

GPUProcess/graphics/RemoteRenderingBackend.h:

(WebKit::RemoteRenderingBackend::decodeAndCreate):

1:50 PM Changeset in webkit [269563] by Simon Fraser

10 edits
1 copy
1 add in trunk/Source/WebCore

[LFC Display] Implement CSS border painting
https://bugs.webkit.org/show_bug.cgi?id=218685

Reviewed by Zalan Bujtas.

Add Display::BoxDecorationPainter() which paints borders and backgrounds for the given box,
and implement border drawing.

Future patches will add support for BackgroundBleedAvoidance and background clipping for
border-radius.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
display/css/DisplayBoxDecorationData.cpp:

(WebCore::Display::BorderEdge::BorderEdge):
(WebCore::Display::BorderEdge::obscuresBackground const):
(WebCore::Display::calculateBorderEdges):
(WebCore::Display::adjacentSidesForSide):

display/css/DisplayBoxDecorationData.h:

(WebCore::Display::BorderEdge::width const):
(WebCore::Display::BorderEdge::style const):
(WebCore::Display::BorderEdge::color const):
(WebCore::Display::BorderEdge::isTransparent const):
(WebCore::Display::BorderEdge::isPresent const):
(WebCore::Display::BorderEdge::hasVisibleColorAndStyle const):
(WebCore::Display::BorderEdge::shouldRender const):
(WebCore::Display::BorderEdge::presentButInvisible const):
(WebCore::Display::BorderEdge::widthForPainting const):
(WebCore::Display::BorderEdge::innerWidth const):
(WebCore::Display::BorderEdge::outerWidth const):
(WebCore::Display::BoxDecorationData::setBackgroundImageGeometry):
(WebCore::Display::BoxDecorationData::borderEdges const):
(WebCore::Display::BoxDecorationData::setBorderEdges):
(WebCore::Display::BoxDecorationData::borderRadii const):
(WebCore::Display::BoxDecorationData::setBorderRadii):
(WebCore::Display::BoxDecorationData::hasBorderImage const):
(WebCore::Display::BoxDecorationData::roundedBorderRect const): Deleted.
(WebCore::Display::BoxDecorationData::setRoundedBorderRect): Deleted.

display/css/DisplayBoxDecorationPainter.cpp: Added.

(WebCore::Display::BorderPainter::BorderPainter):
(WebCore::Display::BorderPainter::edgesShareColor):
(WebCore::Display::BorderPainter::borderStyleFillsBorderArea):
(WebCore::Display::BorderPainter::borderStyleHasInnerDetail):
(WebCore::Display::BorderPainter::styleRequiresClipPolygon):
(WebCore::Display::BorderPainter::borderStyleIsDottedOrDashed):
(WebCore::Display::BorderPainter::borderWillArcInnerEdge):
(WebCore::Display::BorderPainter::borderStyleHasUnmatchedColorsAtCorner):
(WebCore::Display::BorderPainter::colorsMatchAtCorner const):
(WebCore::Display::BorderPainter::colorNeedsAntiAliasAtCorner const):
(WebCore::Display::BorderPainter::calculateBorderStyleColor):
(WebCore::Display::BorderPainter::willBeOverdrawn const):
(WebCore::Display::BorderPainter::borderStylesRequireMitre):
(WebCore::Display::BorderPainter::calculateAdjustedInnerBorder):
(WebCore::Display::BorderPainter::joinRequiresMitre const):
(WebCore::Display::roundedRectWithIncludedRadii):
(WebCore::Display::BorderPainter::roundedBorderForRect const):
(WebCore::Display::BorderPainter::roundedInsetBorderForRect const):
(WebCore::Display::BorderPainter::drawBoxSideFromPath const):
(WebCore::Display::BorderPainter::clipBorderSidePolygon const):
(WebCore::Display::BorderPainter::drawLineForBoxSide const):
(WebCore::Display::BorderPainter::paintOneBorderSide const):
(WebCore::Display::BorderPainter::paintBorderSides const):
(WebCore::Display::BorderPainter::paintTranslucentBorderSides const):
(WebCore::Display::BorderPainter::paintBorders const):
(WebCore::Display::BoxDecorationPainter::paintBorders):
(WebCore::Display::paintFillLayer):
(WebCore::Display::BoxDecorationPainter::paintBackgroundImages):
(WebCore::Display::BoxDecorationPainter::paintBackground):
(WebCore::Display::BoxDecorationPainter::paintBackgroundAndBorders):

display/css/DisplayBoxDecorationPainter.h: Copied from Source/WebCore/display/css/DisplayBoxDecorationData.cpp.
display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::constructBoxDecorationData const):
(WebCore::Display::BoxFactory::setupBoxModelBox const):

display/css/DisplayBoxPainter.cpp:

(WebCore::Display::BoxPainter::paintBoxDecorations):
(WebCore::Display::BoxPainter::paintFillLayer): Deleted.
(WebCore::Display::BoxPainter::paintBackgroundImages): Deleted.

display/css/DisplayStyle.cpp:

(WebCore::Display::Style::Style):
(WebCore::Display::Style::hasVisibleBorder const): Deleted.

display/css/DisplayStyle.h:

(WebCore::Display::Style::borderLeft const): Deleted.
(WebCore::Display::Style::borderRight const): Deleted.
(WebCore::Display::Style::borderTop const): Deleted.
(WebCore::Display::Style::borderBottom const): Deleted.

platform/graphics/FloatRoundedRect.h:

1:49 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

11:34 AM Changeset in webkit [269562] by Alan Bujtas

4 edits
2 adds in trunk/Source/WebCore

[LFC][Integration] Introduce InlineContentBuilder
https://bugs.webkit.org/show_bug.cgi?id=218684

Reviewed by Antti Koivisto.

Move the display run and line construction to this new class. This is in preparation for
expanding the construction coverage to support features like bidirectional content handling.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/inlineformatting/InlineContentBreaker.cpp:
layout/integration/LayoutIntegrationInlineContentBuilder.cpp: Added.

(WebCore::LayoutIntegration::lineOverflowWidth):
(WebCore::LayoutIntegration::InlineContentBuilder::InlineContentBuilder):
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::computeLineLevelVisualAdjustmentsForRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::constructDisplayLines const):

layout/integration/LayoutIntegrationInlineContentBuilder.h: Added.
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):
(WebCore::LayoutIntegration::lineOverflowWidth): Deleted.

10:15 AM Changeset in webkit [269561] by Simon Fraser

4 edits
2 adds in trunk

Source/WebCore:
REGRESSION (r268476): Sometimes zooming does not work on purpleair.com/map
https://bugs.webkit.org/show_bug.cgi?id=218680
<rdar://problem/70418612>

Reviewed by Zalan Bujtas.

Loading purpleair.com/map and quickly panning then zooming would often fail to zoom the map,
and rubberband instead. This happened because the composited layer containing the WebGL
canvas would switch to into tiled mode, and that would fail to set the event region on the
new platform layer.

The fix is to just add the 'EventRegionChanged' flag to the list of properties that need to
get updated after a tiled layer switch.

Test: fast/scrolling/mac/wheel-event-listener-region-tiled-layer-switch.html

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::determineWheelEventProcessing):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::changeLayerTypeTo):

LayoutTests:
REGRESSION (r268476): Sometimes zooming does not worki on purpleair.com/map
https://bugs.webkit.org/show_bug.cgi?id=218680

Reviewed by Zalan Bujtas.

fast/scrolling/mac/wheel-event-listener-region-tiled-layer-switch-expected.txt: Added.
fast/scrolling/mac/wheel-event-listener-region-tiled-layer-switch.html: Added.

Nov 6, 2020:

10:55 PM Changeset in webkit [269560] by commit-queue@webkit.org

3 edits in trunk/Tools

REGRESSION (r269435): [iOS Debug] ASSERTION FAILED: !m_impl

Thread::mayBeGCThread()

m_impl->wasConstructedOnMainThread() == isMainThread()

https://bugs.webkit.org/show_bug.cgi?id=218662

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-06
Reviewed by Chris Dumez.

We were missing a few WebThreadLock calls, which changes the return value of isMainThread() in UIWebView.

TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLNoCrashOnOtherThreadAccess.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:

(TestWebKitAPI::TEST):

9:38 PM Changeset in webkit [269559] by Simon Fraser

13 edits in trunk/Source/WebCore

A programmatic scroll to a new location should stop rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=218672

Reviewed by Tim Horton.

This is a better version of the fix in r269373. That fix attempted to stop a rubberband if there
was a programmatic scroll that moved you away from the edge where any active rubberband was happening.
However, the code ran too late; by the time ScrollController::scrollPositionChanged() is called,
the position has already changed, but more importantly the requested scroll position had
already been clamped between min and max scroll position, where the behavior of
maximumScrollPosition() is affected by whether the rubberbanding is active (see ScrollingTreeFrameScrollingNodeMac::maximumScrollPosition()
and its use of totalContentsSizeForRubberBand()).

The result of this was that the active rubberband triggered clamping of the requested scroll position
before we got a chance to stop the rubberband, breaking some programmatic scrolls on netflix.com.

Fix by plumbing through willDoProgrammaticScroll() which stops the rubberband before maximumScrollPosition()
gets a chance to clamp the position.

Will be tested after one additional required patch to come.

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::scrollTo):
(WebCore::ScrollingTreeScrollingNode::isRubberBanding const): Deleted.

page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::willDoProgrammaticScroll):
(WebCore::ScrollingTreeFrameScrollingNodeMac::currentScrollPositionChanged):

page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::willDoProgrammaticScroll):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::currentScrollPositionChanged):

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::willDoProgrammaticScroll):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::scrollPositionIsNotRubberbandingEdge const):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::currentScrollPositionChanged):

platform/RectEdges.h:

(WebCore::operator<<):

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::notifyPositionChanged):

platform/cocoa/ScrollController.h:

(WebCore::ScrollController::rubberBandingEdges const):

platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::scrollPositionChanged):
(WebCore::ScrollController::stopRubberbanding):

9:34 PM Changeset in webkit [269558] by Simon Fraser

3 edits
2 adds in trunk

Programmatic scrolls need updated scrolling geometry
https://bugs.webkit.org/show_bug.cgi?id=218676

Reviewed by Tim Horton.

Source/WebCore:

Part of rdar://problem/69599531: Scrolling on netflix.com sometimes jumps to the top.

A programmatic scroll can happen right after content changes affect the scrolled content size,
and need to be committed right away to avoid the scrolling thread continuing to process events
or run rubberbanding based on stale state.

So when we get requestScrollPositionUpdate(), update the scrolling node geometry and
immediately commit the scrolling tree.

Test: fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):

LayoutTests:

fast/scrolling/mac/programmatic-scroll-overrides-rubberband-expected.txt: Added.
fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html: Added.

9:23 PM Changeset in webkit [269557] by Peng Liu

29 edits in trunk/Source

PiP return to element full screen is not smooth on some websites
https://bugs.webkit.org/show_bug.cgi?id=218419

Reviewed by Jer Noble.

Source/WebCore:

In r265562, we added the support that a video in picture-in-picture can return to
element fullscreen directly if the fullscreen API is supported. The basic idea of
the implementation is to request the element to enter fullscreen when the video
needs to exit picture-in-picture, and start exiting picture-in-picture after the
element fullscreen transition is completed.

On the iOS port, the entering element fullscreen transition needs to be done in
500 ms. Otherwise, AVKit will start the exiting picture-in-picture animation and
notify VideoFullscreenInterfaceAVKit about the progress before the element
fullscreen implementation has done the job. When that happens, the exiting
picture-in-picture animation will be incorrect and we have to use mechanisms to
protect the state of VideoFullscreenInterfaceAVKit. Unfortunately, on some websites,
the entering element fullscreen transition does take longer than than 500 ms due
to complex CSS style updates.

In this patch, when a video in picture-in-picture needs to return to element
fullscreen, it will return to a temporary fullscreen state (video fullscreen)
with a smooth animation implemented by AVKit. The video will continue playing
in the temporary fullscreen state while the element fullscreen transition is
happening in the background which is invisible to users. After the element
fullscreen transition is done, VideoFullscreenInterfaceAVKit exits the temporary
fullscreen state and returns to standby. Users won't notice the temporary
fullscreen state because media controls are hidden in that state.

This patch also fixes issues found in stress tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::exitFullscreen):
For exitVideoFullscreenToModeWithoutAnimation(), we should not set
m_changingVideoFullscreenMode to true, because there won't be confirmation
to reset m_changingVideoFullscreenMode to false.
(WebCore::HTMLMediaElement::setVideoFullscreenStandby):
When the exit fullscreen request is rejected, we should not set
m_videoFullscreenStandby to false.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitSetPresentationMode):
Only protect too fast setPresentationMode() calls from JS code.
(WebCore::HTMLVideoElement::setPresentationMode):
(WebCore::HTMLVideoElement::didEnterFullscreenOrPictureInPicture):
(WebCore::HTMLVideoElement::didExitFullscreenOrPictureInPicture):
(WebCore::HTMLVideoElement::setVideoFullscreenFrame):
Rename m_isEnteringPictureInPicture to m_enteringPictureInPicture
and m_isExitingPictureInPicture to m_exitingPictureInPicture.

html/HTMLVideoElement.h: Ditto.

page/ChromeClient.h:

(WebCore::ChromeClient::exitVideoFullscreenForVideoElement):
Add a completion handler parameter so that the caller can be notified
that the request is rejected.

platform/cocoa/VideoFullscreenChangeObserver.h:

Remove an unused function fullscreenWillReturnToInline().

platform/cocoa/VideoFullscreenModel.h:

(WebCore::VideoFullscreenModelClient::prepareToExitPictureInPicture): Deleted.

platform/ios/VideoFullscreenInterfaceAVKit.h:

Function exitFullscreen() now returns a boolean value indicating the request
is accepted or rejected.
Add a function preparedToReturnToStandby(), which is used to notify
VideoFullscreenInterfaceAVKit that the video is ready to return to standby.
Add a parameter shouldNotifyModel to setMode() and clearMode().
shouldNotifyModel is true when a request to enter/exit picture-in-picture
is from AVKit.
Remove unused m_stopPictureInPictureTimer and the related function.

platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::VideoFullscreenInterfaceAVKit):
Remove unused m_stopPictureInPictureTimer.
(VideoFullscreenInterfaceAVKit::exitFullscreen):
We don't need to check whether m_watchdogTimer is active before stopping it.
When a video is entering picture-in-picture, we should reject the request to
exit fullscreen.
(VideoFullscreenInterfaceAVKit::cleanupFullscreen): Remove unused code.
(VideoFullscreenInterfaceAVKit::invalidate): Fix an issue in stress tests.
(VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStop):
(VideoFullscreenInterfaceAVKit::didStartPictureInPicture):
When a video is entering picture-in-picture from standby, we may need to return
to element fullscreen in the future. So we may need to return to the video
fullscreen state implemented by AVKit.
Also, we should delay the didEnterPictureInPicture notification in doEnterFullscreen()
until VideoFullscreenInterfaceAVKit completely enters picture-in-picture.
(VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture): A minor clean-up.
(VideoFullscreenInterfaceAVKit::willStopPictureInPicture): A minor clean-up.
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):
Notify the observer that a video has exited picture-in-picture. If the video needs to
return to element fullscreen, the video is actually in the temporary fullscreen state.
Also, move didExitPictureInPicture() to cleanupFullscreen().
(VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler):
Minor clean-up and disable picture-in-picture support temporarily. Explained in
WebKit/ChangeLog.
(VideoFullscreenInterfaceAVKit::setHasVideoContentLayer):
When a video is entering standby state, we need to call returnToStandby() if
m_returningToStandby is true.
(VideoFullscreenInterfaceAVKit::doSetup): Remove unused code.
(VideoFullscreenInterfaceAVKit::preparedToReturnToStandby):
Return to standby after the element fullscreen transition is completed.
(VideoFullscreenInterfaceAVKit::doEnterFullscreen):
Move m_videoFullscreenModel->didEnterPictureInPicture() from didStartPictureInPicture()
to this function.
(VideoFullscreenInterfaceAVKit::doExitFullscreen): Minor clean-up.
(VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
(VideoFullscreenInterfaceAVKit::enterFullscreenHandler):
Hide the media controls provided by AVKit when the video is in the temporary fullscreen state.
(VideoFullscreenInterfaceAVKit::returnToStandby):
Call didSetupFullscreen() to return to standby.
(VideoFullscreenInterfaceAVKit::setMode):
(VideoFullscreenInterfaceAVKit::clearMode):
(VideoFullscreenInterfaceAVKit::stopPictureInPictureTimerFired): Deleted.
(VideoFullscreenInterfaceAVKit::setReadyToStopPictureInPicture): Deleted.

platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::fullscreenMayReturnToInline):
(VideoFullscreenControllerContext::fullscreenWillReturnToInline): Deleted.

platform/mac/VideoFullscreenInterfaceMac.h:
platform/mac/VideoFullscreenInterfaceMac.mm:

(WebCore::VideoFullscreenInterfaceMac::setMode):
(WebCore::VideoFullscreenInterfaceMac::exitFullscreen):

Source/WebKit:

In r265562, VideoFullscreenInterfaceAVKit uses fullscreenMayReturnToInline()
to request the observer (WKFullScreenWindowController) to enter element fullscreen
before exiting picture-in-picture, and calls fullscreenWillReturnToInline() to
proceed returning to inline or element fullscreen after WKFullScreenWindowController
is ready.

In this patch, VideoFullscreenInterfaceAVKit will directly enter a temporary
video fullscreen from picture-in-picture, so the preparation step (entering element
fullscreen) is not needed.

Some important points regarding edge cases:
1) A video enters picture-in-picture and exits picture-in-picture immediately
before WKFullScreenWindowController is notified to exit element fullscreen.
In this case, WKFullScreenWindowController will do nothing when it is notified
that the video has exited picture-in-picture. It will directly tell
VideoFullscreenInterfaceAVKit to enter standby.

2) A video exits picture-in-picture when WKFullScreenWindowController is exiting
element fullscreen but not complete yet. In this case, WKFullScreenWindowController
needs to hold the enter element fullscreen request and exits element fullscreen
first before entering element fullscreen.

3) The ancestor element of the video element exits fullscreen and asks the video
element to exit standby (in web process) while the video is entering picture-in-picture
(in UI process). In this case, VideoFullscreenInterfaceAVKit (in UI process) should
ignore the request to exit standby and tell the web process the request is rejected.

4) A user may try to enter picture-in-picture when the video is exiting picture-in-picture
and returning to element fullscreen. In this case, VideoFullscreenInterfaceAVKit
(in UI process) should temporarily disable the picture-in-picture support.

UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:

Remove the message EnterFullscreen for the iOS port because the UI process can enter
fullscreen/picture-in-picture directly.

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::exitFullscreen):
(WebKit::VideoFullscreenManagerProxy::preparedToReturnToInline):
We need to call m_page->fullscreenMayReturnToInline() in this function after
removing fullscreenWillReturnToInline().
(WebKit::VideoFullscreenManagerProxy::didSetupFullscreen):
For the iOS port, we should enter fullscreen directly.
(WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
(WebKit::VideoFullscreenManagerProxy::fullscreenMayReturnToInline):
(WebKit::VideoFullscreenModelContext::fullscreenWillReturnToInline): Deleted.
(WebKit::VideoFullscreenManagerProxy::fullscreenWillReturnToInline): Deleted.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController requestEnterFullScreen]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController didEnterPictureInPicture]):
(-[WKFullScreenWindowController didExitPictureInPicture]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
We should force to exit fullscreen because the current exiting fullscreen process
might be stuck.
(-[WKFullScreenWindowController prepareToExitPictureInPicture]): Deleted.

UIProcess/mac/WKFullScreenWindowController.mm:

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exitVideoFullscreenForVideoElement):

WebProcess/WebCoreSupport/WebChromeClient.h:

WebProcess/cocoa/VideoFullscreenManager.h:

(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):

WebProcess/cocoa/VideoFullscreenManager.messages.in:
WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
The request to exit fullscreen (standby) may be rejected.
(WebKit::VideoFullscreenManager::didSetupFullscreen):
Only the macOS port needs to implement this function.
(WebKit::VideoFullscreenManager::didEnterFullscreen):
(WebKit::VideoFullscreenManager::didExitFullscreen):
(WebKit::VideoFullscreenManager::fullscreenMayReturnToInline):
(WebKit::VideoFullscreenManager::fullscreenWillReturnToInline): Deleted.

Source/WebKitLegacy/mac:

WebCoreSupport/WebChromeClient.h:

(WebChromeClient::exitVideoFullscreenForVideoElement):

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::exitVideoFullscreenForVideoElement):

Source/WebKitLegacy/win:

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::exitVideoFullscreenForVideoElement):

WebCoreSupport/WebChromeClient.h:

7:53 PM Changeset in webkit [269556] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Remove localBounds and globalBounds methods from display list items that are not drawing items
https://bugs.webkit.org/show_bug.cgi?id=218675

Reviewed by Tim Horton and Devin Rousso.

In r269525, I refactored display list items to no longer derive from base classes (i.e. DisplayList::Item and
DisplayList::DrawingItem). In doing so, I ended up adding the localBounds and globalBounds methods
everywhere, since these methods are called from within the templated DisplayList::Recorder::append method
if the given type is a drawing item (that is, the static isDrawingItem flag is set).

However, for non-drawing items such as state change items, FlushContext, and MetaCommandSwitchTo, having
these methods makes no sense. We can fix this by leveraging constexpr if to only update item extents for
display list item types that are drawing items.

This allows us to remove these two methods from all display list items that are not drawing items.

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::Save::localBounds const): Deleted.
(WebCore::DisplayList::Save::globalBounds const): Deleted.
(WebCore::DisplayList::Restore::localBounds const): Deleted.
(WebCore::DisplayList::Restore::globalBounds const): Deleted.
(WebCore::DisplayList::Translate::localBounds const): Deleted.
(WebCore::DisplayList::Translate::globalBounds const): Deleted.
(WebCore::DisplayList::Rotate::localBounds const): Deleted.
(WebCore::DisplayList::Rotate::globalBounds const): Deleted.
(WebCore::DisplayList::Scale::localBounds const): Deleted.
(WebCore::DisplayList::Scale::globalBounds const): Deleted.
(WebCore::DisplayList::SetCTM::localBounds const): Deleted.
(WebCore::DisplayList::SetCTM::globalBounds const): Deleted.
(WebCore::DisplayList::ConcatenateCTM::localBounds const): Deleted.
(WebCore::DisplayList::ConcatenateCTM::globalBounds const): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::localBounds const): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::globalBounds const): Deleted.
(WebCore::DisplayList::SetInlineFillColor::localBounds const): Deleted.
(WebCore::DisplayList::SetInlineFillColor::globalBounds const): Deleted.
(WebCore::DisplayList::SetInlineStrokeColor::localBounds const): Deleted.
(WebCore::DisplayList::SetInlineStrokeColor::globalBounds const): Deleted.
(WebCore::DisplayList::SetStrokeThickness::localBounds const): Deleted.
(WebCore::DisplayList::SetStrokeThickness::globalBounds const): Deleted.
(WebCore::DisplayList::SetState::localBounds const): Deleted.
(WebCore::DisplayList::SetState::globalBounds const): Deleted.
(WebCore::DisplayList::SetLineCap::localBounds const): Deleted.
(WebCore::DisplayList::SetLineCap::globalBounds const): Deleted.
(WebCore::DisplayList::SetLineDash::localBounds const): Deleted.
(WebCore::DisplayList::SetLineDash::globalBounds const): Deleted.
(WebCore::DisplayList::SetLineJoin::localBounds const): Deleted.
(WebCore::DisplayList::SetLineJoin::globalBounds const): Deleted.
(WebCore::DisplayList::SetMiterLimit::localBounds const): Deleted.
(WebCore::DisplayList::SetMiterLimit::globalBounds const): Deleted.
(WebCore::DisplayList::ClearShadow::localBounds const): Deleted.
(WebCore::DisplayList::ClearShadow::globalBounds const): Deleted.
(WebCore::DisplayList::Clip::localBounds const): Deleted.
(WebCore::DisplayList::Clip::globalBounds const): Deleted.
(WebCore::DisplayList::ClipOut::localBounds const): Deleted.
(WebCore::DisplayList::ClipOut::globalBounds const): Deleted.
(WebCore::DisplayList::ClipOutToPath::localBounds const): Deleted.
(WebCore::DisplayList::ClipOutToPath::globalBounds const): Deleted.
(WebCore::DisplayList::ClipPath::localBounds const): Deleted.
(WebCore::DisplayList::ClipPath::globalBounds const): Deleted.
(WebCore::DisplayList::ClipToDrawingCommands::localBounds const): Deleted.
(WebCore::DisplayList::ClipToDrawingCommands::globalBounds const): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::localBounds const): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::globalBounds const): Deleted.
(WebCore::DisplayList::ApplyFillPattern::localBounds const): Deleted.
(WebCore::DisplayList::ApplyFillPattern::globalBounds const): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::localBounds const): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::globalBounds const): Deleted.
(WebCore::DisplayList::FlushContext::localBounds const): Deleted.
(WebCore::DisplayList::FlushContext::globalBounds const): Deleted.
(WebCore::DisplayList::MetaCommandSwitchTo::localBounds const): Deleted.
(WebCore::DisplayList::MetaCommandSwitchTo::globalBounds const): Deleted.

platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::appendWithoutUpdatingExtents):
(WebCore::DisplayList::Recorder::append):

6:09 PM Changeset in webkit [269555] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Speed up ews status bubble loading speed
https://bugs.webkit.org/show_bug.cgi?id=214821

Reviewed by Jonathan Bedard.

CISupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): This significantly reduces the calculations done to estimate the position in queue. The position is queue
is calculated based on patches sent to buildbot in last DAYS_TO_CHECK days, and results received from buildbot. However, in
case any queue has a huge backlog (of more than 1 day), the position in queue might not be accurate. Slight trade-off for
speed vs accuracy.

5:38 PM Changeset in webkit [269554] by jiewen_tan@apple.com

4 edits
1 add in trunk/Source/WebKit

[WebAuthn] [iOS] WebAuthn process doesn't start on iOS devices
https://bugs.webkit.org/show_bug.cgi?id=218479
<rdar://problem/70560399>

Reviewed by Brent Fulgham.

One of the reasons is missing the iOS sandbox profile. Therefore, this patch adds one.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb: Added.

Copied from the GPU process. Will strip it down once the process is fully functional.

Scripts/process-entitlements.sh:

Adds some missing entitlements.

UIProcess/WebAuthentication/WebAuthnProcessProxy.h:

Deals with CompletionHandler assertion.

WebKit.xcodeproj/project.pbxproj:

Adds some plumbings for the sandbox profile.

5:11 PM Changeset in webkit [269553] by Andres Gonzalez

5 edits in trunk

Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=218669

Reviewed by Chris Fleizach.

Source/WebCore:

Test: LayoutTests/accessibility/mac/accesskey.html.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
String properties need to be isolated-copied to be used on AX secondary thread.

LayoutTests:

Re-wrote this test to work in both isolated tree mode on and off.

accessibility/mac/accesskey-expected.txt:
accessibility/mac/accesskey.html:

5:10 PM Changeset in webkit [269552] by commit-queue@webkit.org

36 edits
4 moves in trunk

[WASM-References] Rename anyref to externref
https://bugs.webkit.org/show_bug.cgi?id=218331

Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-11-06
Reviewed by Keith Miller.

JSTests:

wasm/Builder.js:

(const._isValidValue):

wasm/references/externref_globals.js: Renamed from JSTests/wasm/references/anyref_globals.js.
wasm/references/externref_modules.js: Renamed from JSTests/wasm/references/anyref_modules.js.
wasm/references/externref_table.js: Renamed from JSTests/wasm/references/anyref_table.js.
wasm/references/externref_table_import.js: Renamed from JSTests/wasm/references/anyref_table_import.js.

(makeImport):
(string_appeared_here.fullGC.assert.eq.1.exports.get_tbl.makeImport):
(string_appeared_here.fullGC.assert.eq.1.exports.get_tbl):
(fullGC.assert.eq):
(doSet):
(assert.throws):

wasm/references/func_ref.js:
wasm/references/is_null.js:
wasm/references/multitable.js:

(assert.throws.1.exports.set_tbl0):
(assert.throws):
(string_appeared_here.vm.isMemoryLimited.tableInsanity):

wasm/references/table_misc.js:

(TableSize.0.End.End.WebAssembly):
(GetLocal.0.GetLocal.1.TableGrow.0.End.End.WebAssembly):

wasm/references/validation.js:

(assert.throws):

wasm/stress/immutable-globals.js:

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.i.assert.eq):

wasm/stress/mutable-globals.js:

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.i.instance.exports.setI32AsI64):

wasm/wasm.json:

LayoutTests/imported/w3c:

web-platform-tests/wasm/jsapi/wasm-module-builder.js:

(WasmModuleBuilder.prototype.addTable):
(WasmModuleBuilder.prototype.toBuffer):

Source/JavaScriptCore:

bytecode/BytecodeDumper.cpp:

(JSC::Wasm::BytecodeDumper::formatConstant const):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::gExternref):
(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::emitCCall):
(JSC::Wasm::AirIRGenerator::moveOpForValueType):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addLocal):
(JSC::Wasm::AirIRGenerator::addConstant):
(JSC::Wasm::AirIRGenerator::setGlobal):
(JSC::Wasm::AirIRGenerator::gAnyref): Deleted.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addLocal):
(JSC::Wasm::B3IRGenerator::addTableGet):
(JSC::Wasm::B3IRGenerator::setGlobal):

wasm/WasmCallingConvention.h:

(JSC::Wasm::WasmCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::marshallLocation const):

wasm/WasmFormat.h:

(JSC::Wasm::isValueType):
(JSC::Wasm::isSubtype):
(JSC::Wasm::TableInformation::wasmType const):

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

wasm/WasmGlobal.cpp:

(JSC::Wasm::Global::get const):
(JSC::Wasm::Global::set):
(JSC::Wasm::Global::visitAggregate):

wasm/WasmGlobal.h:
wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::setGlobal):

wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::jsNullConstant):
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addLocal):
(JSC::Wasm::LLIntGenerator::setGlobal):

wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
(JSC::Wasm::setWasmTableElement):

wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseTableHelper):

wasm/WasmTable.cpp:

(JSC::Wasm::Table::tryCreate):
(JSC::Wasm::Table::set):

wasm/WasmTable.h:

(JSC::Wasm::Table::isExternrefTable const):
(JSC::Wasm::Table::isAnyrefTable const): Deleted.

wasm/js/JSToWasm.cpp:

(JSC::Wasm::boxWasmResult):

wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::set):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

wasm/wasm.json:

LayoutTests:

workers/wasm-references/test.js:

4:39 PM Changeset in webkit [269551] by Wenson Hsieh

12 edits in trunk

Add new display list item types in preparation for webkit.org/b/218426
https://bugs.webkit.org/show_bug.cgi?id=218588

Reviewed by Simon Fraser.

Source/WebCore:

Introduce these new item types. See below for more details.

platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::copyTo):
(WebCore::DisplayList::ItemBuffer::swapWritableBufferIfNeeded):

Let ItemBuffer automatically append "switch to command buffer" item whenever it runs out of space in its
current writable buffer, and either allocates a new buffer or calls into the client to grab a new buffer.

platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

platform/graphics/displaylists/DisplayListItemType.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::FlushContext::apply const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::MetaCommandSwitchTo::apply const):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::FlushContext::FlushContext):
(WebCore::DisplayList::FlushContext::identifier const):
(WebCore::DisplayList::FlushContext::localBounds const):
(WebCore::DisplayList::FlushContext::globalBounds const):

Add FlushContext, which will indicate to the client that it should flush its backing graphics context. The
only data in this item is a DisplayList::FlushIdentifier, which will be used by the display list client to
coordinate flush timing.

(WebCore::DisplayList::MetaCommandSwitchTo::MetaCommandSwitchTo):
(WebCore::DisplayList::MetaCommandSwitchTo::identifier const):
(WebCore::DisplayList::MetaCommandSwitchTo::localBounds const):
(WebCore::DisplayList::MetaCommandSwitchTo::globalBounds const):

Add an item to represent switching to a new item buffer. This is automatically appended by the display list
itself when it runs out of space on the current writable buffer, and will allow display list clients (in
particular, the remote rendering backend in the GPU process) to seamlessly continue reading display list items
when all item data in a display list item buffer has been exhausted.

Also, add a FIXME here for pulling MetaCommandSwitchTo out of the set of display list items. We plan on
tackling this as a part of generalizing concurrent display list architecture in a way that can be used for
serializing WebGL commands as well.

Source/WebKit:

Simply treat these new items as no-ops for the time being. See Source/WebCore/ChangeLog for more details.

GPUProcess/graphics/RemoteImageBuffer.h:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Tools:

Adjust an API test. See other ChangeLogs for more detail.

TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:

(TestWebKitAPI::TEST):

4:31 PM Changeset in webkit [269550] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add IOKIt message filtering
https://bugs.webkit.org/show_bug.cgi?id=218657
<rdar://problem/71118545>

Reviewed by Brent Fulgham.

Like on iOS, the WebContent process on macOS should have IOKit message filtering. This patch also allows reading
of some IOKIt properties, which was reported when running layout tests.

No new tests, covered by existing tests.

WebProcess/com.apple.WebProcess.sb.in:

4:21 PM Changeset in webkit [269549] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Text gets clobbered when assigning to input.defaultValue
https://bugs.webkit.org/show_bug.cgi?id=217156

Disabling fast/forms/defaultValue-clobbering.html since it fails on
iOS

Patch by Joey Arhar <jarhar@chromium.org> on 2020-11-06
Reviewed by Darin Adler.

platform/ios/TestExpectations:

4:09 PM Changeset in webkit [269548] by Wenson Hsieh

11 edits in trunk/Source

Add a display list item to represent stroking a single line
https://bugs.webkit.org/show_bug.cgi?id=218589

Reviewed by Tim Horton.

Source/WebCore:

Add support for the new display list item, and append it when we know we're stroking a Path that consists of a
single line.

No change in behavior.

platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::append):

platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::copyTo const):

platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

platform/graphics/displaylists/DisplayListItemType.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::StrokeLine::localBounds const):
(WebCore::DisplayList::StrokeLine::apply const):
(WebCore::DisplayList::operator<<):

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::StrokeLine::StrokeLine):
(WebCore::DisplayList::StrokeLine::start const):
(WebCore::DisplayList::StrokeLine::end const):
(WebCore::DisplayList::StrokeLine::globalBounds const):

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::strokePath):

Source/WebKit:

GPUProcess/graphics/RemoteImageBuffer.h:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

3:39 PM Changeset in webkit [269547] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sources: default breakpoint action should be evaluate
https://bugs.webkit.org/show_bug.cgi?id=218674

Reviewed by Joseph Pecoraro.

UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.prototype._handleAddActionButtonClick):

3:28 PM Changeset in webkit [269546] by Chris Dumez

12 edits
6 adds in trunk

Event targets should be cleared after dispatch if target pointed to a shadow tree
https://bugs.webkit.org/show_bug.cgi?id=218638

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

web-platform-tests/dom/events/relatedTarget.window-expected.txt:
web-platform-tests/shadow-dom/event-post-dispatch-expected.txt:

Source/WebCore:

Event target & relatedTarget should be cleared after dispatch if target pointed to a shadow
tree:

https://dom.spec.whatwg.org/#concept-event-dispatch (Steps 5.10, 5.11 and 10)

Tests: fast/events/shadow-tree-resetTargets-after-move-in.html

fast/events/shadow-tree-resetTargets-after-move-out.html
fast/events/shadow-tree-resetTargets.html

dom/Event.h:

(WebCore::Event::setRelatedTarget):

dom/EventContext.cpp:

(WebCore::MouseOrFocusEventContext::handleLocalEvents const):

dom/EventContext.h:

(WebCore::EventContext::relatedTarget const):

dom/EventDispatcher.cpp:

(WebCore::isInShadowTree):
(WebCore::EventDispatcher::dispatchEvent):

dom/FocusEvent.h:
dom/MouseEvent.h:

LayoutTests:

fast/events/shadow-tree-resetTargets-after-move-in-expected.txt: Added.
fast/events/shadow-tree-resetTargets-after-move-in.html: Added.
fast/events/shadow-tree-resetTargets-after-move-out-expected.txt: Added.
fast/events/shadow-tree-resetTargets-after-move-out.html: Added.
fast/events/shadow-tree-resetTargets-expected.txt: Added.
fast/events/shadow-tree-resetTargets.html: Added.

Extend layout test coverage.

fast/shadow-dom/event-path-with-window.html:

Update the test to expect the the event.target is null after dispatching. Note that this test
was failing in both Firefox and Chrome before this test change, and is now passing with these
engine after the test change.

3:27 PM Changeset in webkit [269545] by weinig@apple.com

17 edits
1 delete in trunk/Source

Further progress towards merging Settings.yaml into WebPreferences.yaml
https://bugs.webkit.org/show_bug.cgi?id=218663

Reviewed by Tim Horton.

Source/WebCore:

Scripts/GenerateSettings.rb:

Change GenerateSettings.rb to take the list of templates in as arguments rather than
hard coding it. This matches GeneratePreferences and will make it easier to switch over.

DerivedSources.make:

Update call to GenerateSettings.rb to pass templates and adopt static pattern list to
make it very clear what needs to be generated.

WebCoreMacros.cmake:

Update call to GenerateSettings.rb to pass templates

page/SettingsDefaultValues.h: Removed.
Scripts/SettingsTemplates/Settings.cpp.erb:
WebCore.xcodeproj/project.pbxproj:

Remove SettingsDefaultValues.h inlining defaults directly in the yaml files.

page/Settings.yaml:

Add defaults directly in the definition rather than relying on compiled constants.

page/SettingsBase.cpp:

(WebCore::SettingsBase::initializeDefaultFontFamilies):
(WebCore::SettingsBase::defaultMinimumZoomFontSize): Deleted.
(WebCore::SettingsBase::defaultTextAutosizingEnabled): Deleted.
(WebCore::SettingsBase::defaultDownloadableBinaryFontsEnabled): Deleted.
(WebCore::SettingsBase::defaultContentChangeObserverEnabled): Deleted.
(WebCore::SettingsBase::defaultMediaContentTypesRequiringHardwareSupport): Deleted.

page/SettingsBase.h:
page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::defaultTextAutosizingEnabled): Deleted.
(WebCore::SettingsBase::defaultMediaContentTypesRequiringHardwareSupport): Deleted.
Remove defaults that are now inlined into the yaml files. Move some that have to
remain to more appropriate / private locations.

platform/graphics/BitmapImage.h:

Update comment to indicate the the default is now defined in the settings definition.

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
Replace call to WebCore::Settings::defaultMediaContentTypesRequiringHardwareSupport() which always returned
the empty string with a literal empty string. This was the only caller so the function is really no needed.

Source/WebKitLegacy/ios:

Misc/WebUIKitSupport.mm:

(WebKitGetMinimumZoomFontSize):
Use generated default value macro as the one in WebCore has now been removed.

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:

Replace some use of WebCore constants with the inlined values of those constants
as this was the only user and it is clearer for the values to be here too.

2:55 PM Changeset in webkit [269544] by Alan Coon

1 copy in tags/Safari-610.3.7.1.2

Tag Safari-610.3.7.1.2.

2:05 PM Changeset in webkit [269543] by Alan Coon

1 copy in tags/Safari-610.3.7.0.2

Tag Safari-610.3.7.0.2.

2:01 PM Changeset in webkit [269542] by Wenson Hsieh

2 edits
1 add in trunk/Tools

[Concurrent display lists] Add API tests for WebCore::DisplayList::DisplayList and related classes
https://bugs.webkit.org/show_bug.cgi?id=218425

Reviewed by Tim Horton.

Add two new API tests:

One that covers basic display list functionality (i.e. appending items, checking whether a display list is

empty, clearing a display list and iterating over items).

Another that exercises the item buffer client hooks to provide data for writing and encode and decode out-

of-line display list items. This test uses toy Reader/Writer classes that know how to "encode" and "decode"
StrokePath items by storing and reading 8-byte indices into a shared Vector<StrokePath>.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp: Added.

(TestWebKitAPI::createGradient):
(TestWebKitAPI::createComplexPath):
(TestWebKitAPI::TEST):

1:59 PM Changeset in webkit [269541] by Alan Coon

1 copy in tags/Safari-610.2.11.51.10

Tag Safari-610.2.11.51.10.

1:59 PM Changeset in webkit [269540] by Aditya Keerthi

2 edits in trunk/Source/WebKit

[macOS] Align left edge of presented calendar with left edge of date inputs
https://bugs.webkit.org/show_bug.cgi?id=218668

Reviewed by Tim Horton.

When a date input is activated, a calendar is presented by adding an
NSWindow containing an NSDatePicker to the screen. The frame of the
window is set to ensure proper alignment with the date input. However,
since the window's hasShadow is set to true, AppKit draws a thin border
and shadow around the window's contentView. This results in left border
of the window being drawn further out than the left border of the input
itself. If the hasShadow property is set to false, the issue is no longer
observed, and the calendar aligns with the input. However, this is not an
acceptable solution, since we lose the border and the shadow.

To ensure alignment between the border of the calendar view and the border
of the date input, we can inset the edges of the view. Note that the inset
is not applied along the y-axis, to avoid a gap between the bottom of the
date input and the top of the calendar view.

UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePickerBackdropView drawRect:]):

1:58 PM Changeset in webkit [269539] by Alan Coon

8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.10

1:55 PM Changeset in webkit [269538] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Only restore saved layer scroll position for RenderBox
https://bugs.webkit.org/show_bug.cgi?id=218502

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-06
Reviewed by Simon Fraser.

The layer scroll position is only used by RenderBox
renderers, so when restoring the saved scroll position
only restore for RenderBox renderers.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):

1:45 PM Changeset in webkit [269537] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Null check anchorBox
https://bugs.webkit.org/show_bug.cgi?id=218499

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-06
Reviewed by Zalan Bujtas.

Null check anchorBox before calling the renderer method on it.

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):

1:34 PM Changeset in webkit [269536] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Use workerEnvironment instead of slaveEnvironment for new Buildbot
https://bugs.webkit.org/show_bug.cgi?id=218656

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

1:07 PM Changeset in webkit [269535] by Alan Bujtas

3 edits in trunk/Source/WebCore

Empty text runs can't be split any further.
https://bugs.webkit.org/show_bug.cgi?id=218506

Reviewed by David Kilzer and Ryosuke Niwa.

This patch ensures that when we can't fit an empty text run on the line (available space is negative) we don't
try to split it even when the style says so.

layout/inlineformatting/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
(WebCore::Layout::InlineContentBreaker::tryBreakingTextRun const):

layout/inlineformatting/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::fixedPitchWidth):
(WebCore::Layout::TextUtil::split):

1:05 PM Changeset in webkit [269534] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix build with different unified source arrangement.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

12:32 PM Changeset in webkit [269533] by Wenson Hsieh

12 edits
1 delete in trunk/Source

Move DisplayListFlushIdentifier into WebCore as DisplayList::FlushIdentifier
https://bugs.webkit.org/show_bug.cgi?id=218586

Reviewed by Simon Fraser.

Source/WebCore:

Add DisplayList::FlushIdentifier. See WebKit for more ChangeLogs.

platform/graphics/displaylists/DisplayList.h:

Source/WebKit:

In preparation for adding a display list item to represent flushing the graphics context, move WebKit's
DisplayListFlushIdentifier to the DisplayList namespace in WebCore, and rename it to
DisplayList::FlushIdentifier.

No change in behavior.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::flushDisplayListWasCommitted):
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Scripts/webkit/messages.py:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/DisplayListFlushIdentifier.h: Removed.
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::commitFlushDisplayList):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackendProxy::flushDisplayListWasCommitted):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:

12:29 PM Changeset in webkit [269532] by Ryan Haddad

2 edits in trunk/LayoutTests

Web Inspector: use weak collections for holding event listeners
https://bugs.webkit.org/show_bug.cgi?id=196956

Patch by Devin Rousso <Devin Rousso> on 2020-11-06
Reviewed by Joseph Pecoraro.

inspector/unit-tests/heap-snapshot-collection-event.html:

Followup from r269359 which replaced the string literal "HeapSnapshot.CollectionEvent"
with a defined WI.HeapSnapshotWorkerProxy.Event.Collection value.

12:23 PM Changeset in webkit [269531] by ysuzuki@apple.com

57 edits
1 add in trunk

Re-enable SharedArrayBuffer for JSC shell and Testers
https://bugs.webkit.org/show_bug.cgi?id=212069

Reviewed by Keith Miller.

JSTests:

Update tests to align to the latest spec.

stress/SharedArrayBuffer-opt.js:

(shouldSucceed):
(idx.of.string_appeared_here.a.of.arrays.m.of.atomics):
(string_appeared_here.a.of.arrays.m.of.atomics): Deleted.

stress/SharedArrayBuffer.js:

(shouldSucceed):
(Symbol):

stress/array-buffer-byte-length.js:

(shouldThrow):
(Symbol):

stress/atomics-add-uint32.js:
stress/atomics-known-int-use.js:
stress/atomics-neg-zero.js:
stress/atomics-store-return.js:
stress/lars-sab-workers.js:

(resources):
(notify):
(wake): Deleted.

stress/regress-170473.js:
stress/regress-189317.js:
stress/shared-array-buffer-sort-while-different-thread-is-modifying.js: Added.

(262.agent.waitUntil):
(262.agent.start.262.agent.receiveBroadcast):

test262/config.yaml:
test262/expectations.yaml:

LayoutTests/imported/w3c:

web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any-expected.txt:
web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.serviceworker-expected.txt:
web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.worker-expected.txt:
web-platform-tests/wasm/jsapi/memory/constructor.any-expected.txt:
web-platform-tests/wasm/jsapi/memory/constructor.any.worker-expected.txt:
web-platform-tests/workers/postMessage_block.https-expected.txt:

Source/JavaScriptCore:

This patch revives SharedArrayBuffer and Atomics and aligning them to the latest spec.

SharedArrayBuffer's sort should be done in JS side. C++ sort is not safe for SharedArrayBuffer since the buffer can be modified by different threads while sorting.
Atomics.wait should be renamed to Atomics.notify.
Atomics operation should be VarArgs in DFG because DFGSSALoweringPhase assumes that they are VarArgs and they can have another arg for CheckInBounds dependency.
For test262, JSC shell should support "--can-block-is-false" flag. If it is true, the main thread's CanBlock? becomes false. This means that Atomics.wait cannot be used.

builtins/BuiltinNames.h:
builtins/TypedArrayPrototype.js:

(sort):

bytecode/LinkTimeConstant.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::mustGenerate const):
(JSC::DFG::Node::hasVarArgs const):
(JSC::DFG::Node::mustGenerate): Deleted.

dfg/DFGNodeType.h:
dfg/DFGSSALoweringPhase.cpp:

(JSC::DFG::SSALoweringPhase::handleNode):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsIsLockFree):

jsc.cpp:

(printUsageStatement):
(CommandLine::parseArguments):
(runJSC):

runtime/AtomicsObject.cpp:

(JSC::AtomicsObject::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSC_DEFINE_JIT_OPERATION):

runtime/CommonIdentifiers.h:
runtime/Intrinsic.cpp:

(JSC::intrinsicName):

runtime/Intrinsic.h:
runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferSlice):
(JSC::arrayBufferByteLength):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSArrayBufferPrototype::finishCreation):

runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::JSValue::toIntegerOrInfinity const):

runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/JSTypedArrayViewPrototype.h:
runtime/OptionsList.h:
runtime/SimpleTypedArrayController.cpp:

(JSC::SimpleTypedArrayController::SimpleTypedArrayController):
(JSC::SimpleTypedArrayController::isAtomicsWaitAllowedOnCurrentThread):

runtime/SimpleTypedArrayController.h:
runtime/SmallStrings.cpp:

(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):

runtime/SmallStrings.h:

(JSC::SmallStrings::notEqualString const):
(JSC::SmallStrings::timedOutString const):
(JSC::SmallStrings::okString const):

Source/WTF:

wtf/PlatformEnable.h:

Tools:

Scripts/test262/Runner.pm:

(getFeatureFlags):

Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

LayoutTests:

webaudio/dom-exceptions-expected.txt:

12:22 PM Changeset in webkit [269530] by Wenson Hsieh

2 edits in trunk/Source/WebCore

Unreviewed, fix the Windows 10 debug build after r269525

Speculative fix: add NO_RETURN_DUE_TO_ASSERT to method declarations in DisplayListItems.h as well.

platform/graphics/displaylists/DisplayListItems.h:

12:21 PM Changeset in webkit [269529] by achristensen@apple.com

5 edits in trunk/Source/WebKit

Fix build after adding files to UIProcess/API/Cocoa
https://bugs.webkit.org/show_bug.cgi?id=218664

There is some code that assumes that unified sources always combine sources into the same translation units.
inspectorWebView is used from _WKInspectorTesting.mm, but only defined in _WKInspector.mm so it should be added to a header.
_WKUserContentWorld also doesn't include WKObject.h or RetainPtr.h but uses both.

UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector inspectorWebView]): Deleted.

UIProcess/API/Cocoa/_WKInspectorPrivateForTesting.h:
UIProcess/API/Cocoa/_WKInspectorTesting.mm:

(-[_WKInspector inspectorWebView]):

UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:

12:17 PM Changeset in webkit [269528] by commit-queue@webkit.org

2 edits
2 adds in trunk

Text gets clobbered when assigning to input.defaultValue
https://bugs.webkit.org/show_bug.cgi?id=217156

Patch by Joey Arhar <jarhar@chromium.org> on 2020-11-06
Reviewed by Darin Adler.

This fixes a bug where script assigning to the defaultValue property
of a number or email input causes the text the user entered into the
input to be clobbered when it doesn't perfectly match the sanitized
string returned by the .value property.

Test: LayoutTests/fast/forms/defaultValue-clobbering.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

11:37 AM Changeset in webkit [269527] by graouts@webkit.org

2 edits in trunk/Source/WebCore

Accelerated animations of individual transform properties should apply rotate before scale
https://bugs.webkit.org/show_bug.cgi?id=218659

Reviewed by Simon Fraser.

Not that applying scale before rotate makes any difference, but applying the operations in
the order specified in the CSS Transforms spec will make the code easier to understand between
this and RenderStyle::applyTransform().

No test since there is no change of behavior.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateAnimations):

11:29 AM Changeset in webkit [269526] by Wenson Hsieh

2 edits in trunk/Source/WebKit

Encoding PutImageData should not serialize separate IPC attachments for the image data
https://bugs.webkit.org/show_bug.cgi?id=218649

Reviewed by Simon Fraser.

The argument coder for WebCore::ImageData currently sends its image data by allocating a separate shared
memory buffer and sending it over to the GPU process via a separate IPC::Attachment. This isn't compatible
with the new "concurrent display list" model for processing display list items, wherein all out-of-line items
are encoded as raw bytes directly into reusable shared memory buffers and decoded from the corresponding buffer
in the GPU process.

Instead, encode and decode image data directly into and out of the main IPC data buffer. This also addresses a
couple of existing FIXMEs in the ImageData coder methods by avoiding the need for redundant copies to and from
temporary WebCore::SharedBuffers.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Ref<WebCore::ImageData>>::encode):
(IPC::ArgumentCoder<Ref<WebCore::ImageData>>::decode):

10:54 AM Changeset in webkit [269525] by Wenson Hsieh

36 edits
2 copies
2 adds in trunk

[Concurrent display lists] Encode display list items directly into shared memory
https://bugs.webkit.org/show_bug.cgi?id=218406

Reviewed by Tim Horton.

Source/WebCore:

This patch refactors display lists (and display list items) in preparation for upcoming changes to allow the
GPU and web processes to concurrently read and write display list item data, which allows us to achieve
significant improvements in performance on many graphics benchmarks in MotionMark by removing overhead involved
in serializing and deserializing display list items over IPC. To implement this, rather than using IPC to encode
and decode each item, we will instead store display list items directly in memory shared between the web and GPU
processes.

This strategy, of course, will not work for display list items that contain pointers. Unfortunately, this
affects all display list items at the moment, since all items are subclasses of DisplayList::Item, and
therefore contain vtable pointers, even if all members are plain data types. Thus, the first step towards being
able to read and write items directly in shared memory is to remove this vtable pointer by making display list
items no longer inherit from DrawingItem or Item.

Currently, display lists are backed by Vector<Ref<Item>>; however, this no longer works once none of the
display list items are descended from a common base class. To address this, we introduce
DisplayList::ItemBuffer, which encapsulates logic to manage one or more data segments that contain display
list item data (i.e. display list items stacked adjacent to each other in memory). Display lists now append
inline display list items by constructing these items directly inside the item buffer using placement-new.

However, many types of display list items do not consist entirely of inline data; some of these are obvious,
such as DrawImage, DrawGlyphs, or StrokePath (since a Path may be arbitrarily complex). Other out-of-
line item types are less obvious: for instance, FillRoundedRect is an out-of-line item due to the fact that
the color of the rect (FillRoundedRect::m_color) may be an extended color, which then contains a pointer. In
these cases, we can't simply encode the item in shared memory and read it in the GPU process, since the pointer
(if it pointed to anything other than null in the web process) will point to arbitrary memory in the GPU
process. Instead, we can leverage our existing IPC infrastructure here by encoding each of these out-of-line
items as data and decoding them from this data in the GPU process. To do this, we delegate out to WebKit2 to
encode out-of-line display list items using WebKit's IPC::Encoder, and pass back a SharedBuffer which we
then copy into the item buffer. This delegation happens through the ItemBufferWritingClient class, which has
an implementation in WebKit2. On the decoding side in the GPU process, we then ask ItemBufferReadingClient (if
set) to convert this encoded data back into a display list item. In WebKit2, we implement this interface and use
the corresponding IPC::Decoder to decode the data we serialized earlier.

If no client is specified or the client does not require custom encoding/decoding for the given item type, we
fall back to constructing the item directly inside the writable item buffer data.

To make it easier to reason about these new (inheritance-free) display list items, we additionally introduce
ItemHandle, which wraps a pointer to a display list item and provides several helper methods. The first byte
of each item handle always points to an ItemType, and the following N bytes contain the item itself, where
N is the size of the item class. Here are some examples of how to use an ItemHandle:

DisplayList::ItemType type = itemHandle.type(); (This matches the current inheritance model)

if (itemHandle.is<StrokePath>()) {... (Replaces is<> in the current model)

auto& setStateItem = itemHandle.get<SetState>(); (Replaces downcast<> in the current model)

itemHandle.apply(myGraphicsContext); (This matches the current inheritance model)

bool isDrawingItem = itemHandle.isDrawingItem(); (Replaces checks for is<DrawingItem>(item))

When writing display lists for the GPU process, the writing client (a ItemBufferWritingClient) will be asked
to provide ItemBufferHandles where the item buffer will place item data (whether encoded, or as an inline
object). However, when using display lists outside of this context (e.g. in other parts of WebCore, such as the
glyph drawing cache), we don't have a ItemBufferWritingClient. To handle this, the item buffer instead
allocates its own (non-shared-memory) buffers, which it manages and deletes when it is done. If any out-of-line
items are constructed within these buffers, ItemBuffer will additionally call their destructors prior to
deleting these buffers.

See per-change comments below for more details.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.h:
platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::DisplayList):
(WebCore::DisplayList::DisplayList::operator=):

Implement the move assignment operator and move constructor by exchanging ownership of the item buffer.

(WebCore::DisplayList::DisplayList::clear):
(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
(WebCore::DisplayList::DisplayList::asText const):
(WebCore::DisplayList::DisplayList::dump const):

Adjust the format when printing display lists to TextStream. Now that drawing item extents are tracked on the
display list rather than being on each drawing item, we print them out after each item (as opposed to being in
the middle of each item).

(WebCore::DisplayList::DisplayList::sizeInBytes const):

Tally up the size of the display list by taking the sum of the sizes of each readonly segment, as well as the
writable buffer size.

(WebCore::DisplayList::DisplayList::isEmpty const):

A DisplayList is empty if it contains no item data: in other words, there are no readonly buffer segments, and
there is also nothing written to the writable buffer segment.

(WebCore::DisplayList::DisplayList::itemBuffer):
(WebCore::DisplayList::DisplayList::setItemBufferClient):
(WebCore::DisplayList::DisplayList::forEachItemBuffer const):

Add a helper to iterate over each ItemBufferHandle in the display list. This includes all readonly handles, and
then the writable handle (if it exists).

(WebCore::DisplayList::DisplayList::setTracksDrawingItemExtents):

Add an option to allow the display list to track drawing item extents. Currently, display lists always track
extents for drawing items; however, when propagating display lists to the GPU process for playback, these
extents were never sent along with IPC, and so this ended up just being unnecessary work. Additionally, the
initial clip in the GPU process is also never set, so computing these extents never helped.

That said, drawing item extents are still printed out for the purposes of testing, so we need to keep this
logic intact; this refactoring only disables extent computation for display lists being sent to the GPU process
via remote image buffers. In a future patch, we could refactor this so that drawing items contain extent rects
as inline data that can be consulted in the GPU process.

(WebCore::DisplayList::DisplayList::append):

Display list items are no longer constructed ahead of time, and then appended to the display list. Instead,
append now takes the type of the item to append as a template typename argument, as well as the arguments that
will be used to construct the item.

(WebCore::DisplayList::DisplayList::iterator::atEnd const):
(WebCore::DisplayList::DisplayList::iterator::updateCurrentItem):
(WebCore::DisplayList::DisplayList::iterator::advance):
(WebCore::DisplayList::DisplayList::iterator::clearCurrentItem):
(WebCore::DisplayList::DisplayList::iterator::moveToEnd):
(WebCore::DisplayList::DisplayList::iterator::moveCursorToStartOfCurrentBuffer):

Implement a C++ iterator for DisplayList. This makes it possible to write code like this:
`
Suppose displayList is an instance of DisplayList::DisplayList.
for (auto [item, extent] : displayList) {

Do things with item, which is a DisplayList::ItemHandle.
Maybe do things with extent, which is an Optional<FloatRect>.

}
`

platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::tracksDrawingItemExtents const):
(WebCore::DisplayList::DisplayList::iterator::iterator):
(WebCore::DisplayList::DisplayList::iterator::~iterator):
(WebCore::DisplayList::DisplayList::iterator::operator==):
(WebCore::DisplayList::DisplayList::iterator::operator!=):
(WebCore::DisplayList::DisplayList::iterator::operator++):
(WebCore::DisplayList::DisplayList::iterator::operator* const):
(WebCore::DisplayList::DisplayList::begin const):
(WebCore::DisplayList::DisplayList::end const):
(WebCore::DisplayList::DisplayList::itemBufferIfExists const):
(WebCore::DisplayList::DisplayList::addDrawingItemExtent):
(WebCore::DisplayList::DisplayList::append):
(WebCore::DisplayList::Item::type const): Deleted.
(WebCore::DisplayList::Item::isDrawingItem const): Deleted.
(WebCore::DisplayList::DisplayList::list const): Deleted.
(WebCore::DisplayList::DisplayList::itemAt): Deleted.
(WebCore::DisplayList::DisplayList::isEmpty const): Deleted.
(WebCore::DisplayList::DisplayList::appendItem): Deleted.
(WebCore::DisplayList::DisplayList::list): Deleted.
(WebCore::DisplayList::DisplayList::encode const): Deleted.
(WebCore::DisplayList::DisplayList::decode): Deleted.

Remove the ability to encode and decode display lists, for the time being. For the communication between the
web and GPU processes, we now use SharedDisplayListHandle.

Unfortunately, this does mean that the extant ClipToDrawingCommands display list item will be broken for the
time being. In a followup patch, I plan to reimplement DisplayList::encode and decode in the new inline item
model by encoding each item (either as inline data or via IPC::Encoder::encodeSingleObject). However, this is
contingent on all display list item types (e.g. DrawImage and DrawGlyph) not relying on IPC::Attachment
for encoding, so support for ClipToDrawingCommands will need to wait until after fonts and images are working.

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawGlyphs):
(WebCore::DisplayList::DrawGlyphsRecorder::recordDrawImage):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderWin.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

Change these to use the new templated DisplayList::append method.

platform/graphics/displaylists/DisplayListDrawingContext.h:

(WebCore::DisplayList::DrawingContext::takeDisplayList):

Use std::exchange instead of WTFMove. This is actually necessary in order to ensure correctness (i.e. no
leaks or double-freeing), since the DisplayList instance that is being moved from needs to be empty so that it
does not try to call destructors on the items formerly inside of it.

platform/graphics/displaylists/DisplayListItemBuffer.cpp: Added.

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):

Add helper methods to apply a display list item to a GraphicsContext and call the display list item's
destructor, respectively.

(WebCore::DisplayList::ItemHandle::copyTo const):

Add a helper method to copy the item into the destination handle (calling the copy constructor of the item type
in the process). This is used when copying a validated display list item into the temporary item buffer in
DisplayList::iterator.

(WebCore::DisplayList::ItemBuffer::ItemBuffer):
(WebCore::DisplayList::ItemBuffer::~ItemBuffer):
(WebCore::DisplayList::m_allocatedBuffers):

In the case where there is no m_writingClient (for instance, when using in-process DisplayLists to optimize
text painting), the display list item buffer is responsible for creating and managing data buffers. As such, it
needs to remember to free any buffers that it allocated when appending, and must also destroy any out-of-line
display list items (i.e. items with nontrivial destructors) when it is finished.

(WebCore::DisplayList::m_readOnlyBuffers):
(WebCore::DisplayList::m_writableBuffer):
(WebCore::DisplayList::m_writtenNumberOfBytes):

See main ChangeLog entry above for more details.

(WebCore::DisplayList::ItemBuffer::operator=):
(WebCore::DisplayList::ItemBuffer::createItemBuffer):
(WebCore::DisplayList::ItemBuffer::forEachItemBuffer const):
(WebCore::DisplayList::ItemBuffer::clear):
(WebCore::DisplayList::ItemBuffer::swapWritableBufferIfNeeded):
(WebCore::DisplayList::ItemBuffer::appendDataAndLength):

platform/graphics/displaylists/DisplayListItemBuffer.h: Added.

(WebCore::DisplayList::ItemBufferHandle::operator bool const):
(WebCore::DisplayList::ItemBufferHandle::operator! const):
(WebCore::DisplayList::ItemHandle::operator bool const):
(WebCore::DisplayList::ItemHandle::operator! const):
(WebCore::DisplayList::ItemHandle::type const):
(WebCore::DisplayList::ItemHandle::size const):
(WebCore::DisplayList::ItemHandle::is const):
(WebCore::DisplayList::ItemHandle::get const):
(WebCore::DisplayList::ItemBufferWritingClient::~ItemBufferWritingClient):
(WebCore::DisplayList::ItemBufferReadingClient::~ItemBufferReadingClient):
(WebCore::DisplayList::ItemBuffer::sizeInBytes const):
(WebCore::DisplayList::ItemBuffer::isEmpty const):
(WebCore::DisplayList::ItemBuffer::append):
(WebCore::DisplayList::ItemBuffer::setClient):
(WebCore::DisplayList::ItemBuffer::readOnlyBuffers const):
(WebCore::DisplayList::ItemBuffer::uncheckedAppend):

platform/graphics/displaylists/DisplayListItems.cpp:

The changes in this file make up most of the code churn in this patch, but the changes are mostly mechanical. In
summary, this patch:

Add static constexprs for the ItemType of each display list item class, as well as whether or not each class is inline, and also whether or not each class is a drawing item.
Remove encode and decode methods from inline item classes.
Remove all overridden methods; each class now implements individual methods to apply, compute globalBounds (if applicable), and compute localBounds (again, if applicable).
Adjusts textstream dumping helpers, so that they no longer dump as a DrawingItem before dumping each member.

(WebCore::DisplayList::SetInlineFillGradient::SetInlineFillGradient):
(WebCore::DisplayList::SetState::SetState):
(WebCore::DisplayList::DrawGlyphs::DrawGlyphs):
(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const):
(WebCore::DisplayList::DrawGlyphs::apply const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):
(WebCore::DisplayList::DrawPattern::DrawPattern):
(WebCore::DisplayList::DrawLinesForText::DrawLinesForText):
(WebCore::DisplayList::DrawFocusRingRects::DrawFocusRingRects):
(WebCore::DisplayList::FillRectWithGradient::FillRectWithGradient):
(WebCore::DisplayList::PutImageData::PutImageData):
(WebCore::DisplayList::PaintFrameForMedia::PaintFrameForMedia):
(WebCore::DisplayList::Item::Item): Deleted.
(WebCore::DisplayList::Item::sizeInBytes): Deleted.
(WebCore::DisplayList::DrawingItem::DrawingItem): Deleted.
(WebCore::DisplayList::Save::Save): Deleted.
(WebCore::DisplayList::Restore::Restore): Deleted.
(WebCore::DisplayList::Translate::Translate): Deleted.
(WebCore::DisplayList::Rotate::Rotate): Deleted.
(WebCore::DisplayList::Scale::Scale): Deleted.
(WebCore::DisplayList::SetCTM::SetCTM): Deleted.
(WebCore::DisplayList::ConcatenateCTM::ConcatenateCTM): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::create): Deleted.
(WebCore::DisplayList::SetInlineFillColor::create): Deleted.
(WebCore::DisplayList::SetInlineStrokeColor::create): Deleted.
(WebCore::DisplayList::SetStrokeThickness::create): Deleted.
(WebCore::DisplayList::SetLineCap::SetLineCap): Deleted.
(WebCore::DisplayList::SetLineDash::SetLineDash): Deleted.
(WebCore::DisplayList::SetLineJoin::SetLineJoin): Deleted.
(WebCore::DisplayList::SetMiterLimit::SetMiterLimit): Deleted.
(WebCore::DisplayList::ClearShadow::ClearShadow): Deleted.
(WebCore::DisplayList::Clip::Clip): Deleted.
(WebCore::DisplayList::ClipOut::ClipOut): Deleted.
(WebCore::DisplayList::ClipOutToPath::ClipOutToPath): Deleted.
(WebCore::DisplayList::ClipPath::ClipPath): Deleted.
(WebCore::DisplayList::ClipToDrawingCommands::ClipToDrawingCommands): Deleted.
(WebCore::DisplayList::DrawGlyphs::localBounds const): Deleted.
(WebCore::DisplayList::DrawImage::DrawImage): Deleted.
(WebCore::DisplayList::DrawTiledImage::DrawTiledImage): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::DrawTiledScaledImage): Deleted.
(WebCore::DisplayList::DrawImageBuffer::DrawImageBuffer): Deleted.
(WebCore::DisplayList::DrawRect::DrawRect): Deleted.
(WebCore::DisplayList::DrawLine::DrawLine): Deleted.
(WebCore::DisplayList::DrawDotsForDocumentMarker::DrawDotsForDocumentMarker): Deleted.
(WebCore::DisplayList::DrawEllipse::DrawEllipse): Deleted.
(WebCore::DisplayList::DrawPath::DrawPath): Deleted.
(WebCore::DisplayList::DrawFocusRingPath::DrawFocusRingPath): Deleted.
(WebCore::DisplayList::FillRect::FillRect): Deleted.
(WebCore::DisplayList::FillRectWithColor::FillRectWithColor): Deleted.
(WebCore::DisplayList::FillCompositedRect::FillCompositedRect): Deleted.
(WebCore::DisplayList::FillRoundedRect::FillRoundedRect): Deleted.
(WebCore::DisplayList::FillRectWithRoundedHole::FillRectWithRoundedHole): Deleted.
(WebCore::DisplayList::FillInlinePath::FillInlinePath): Deleted.
(WebCore::DisplayList::FillPath::FillPath): Deleted.
(WebCore::DisplayList::FillEllipse::FillEllipse): Deleted.
(WebCore::DisplayList::PaintFrameForMedia::create): Deleted.
(WebCore::DisplayList::StrokeRect::StrokeRect): Deleted.
(WebCore::DisplayList::StrokeEllipse::StrokeEllipse): Deleted.
(WebCore::DisplayList::StrokeInlinePath::StrokeInlinePath): Deleted.
(WebCore::DisplayList::StrokePath::StrokePath): Deleted.
(WebCore::DisplayList::ClearRect::ClearRect): Deleted.
(WebCore::DisplayList::BeginTransparencyLayer::BeginTransparencyLayer): Deleted.
(WebCore::DisplayList::EndTransparencyLayer::EndTransparencyLayer): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::ApplyStrokePattern): Deleted.
(WebCore::DisplayList::ApplyFillPattern::ApplyFillPattern): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::ApplyDeviceScaleFactor): Deleted.

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::Save::localBounds const):
(WebCore::DisplayList::Save::globalBounds const):
(WebCore::DisplayList::Restore::localBounds const):
(WebCore::DisplayList::Restore::globalBounds const):
(WebCore::DisplayList::Translate::Translate):
(WebCore::DisplayList::Translate::localBounds const):
(WebCore::DisplayList::Translate::globalBounds const):
(WebCore::DisplayList::Rotate::Rotate):
(WebCore::DisplayList::Rotate::localBounds const):
(WebCore::DisplayList::Rotate::globalBounds const):
(WebCore::DisplayList::Scale::Scale):
(WebCore::DisplayList::Scale::localBounds const):
(WebCore::DisplayList::Scale::globalBounds const):
(WebCore::DisplayList::SetCTM::SetCTM):
(WebCore::DisplayList::SetCTM::localBounds const):
(WebCore::DisplayList::SetCTM::globalBounds const):
(WebCore::DisplayList::ConcatenateCTM::ConcatenateCTM):
(WebCore::DisplayList::ConcatenateCTM::localBounds const):
(WebCore::DisplayList::ConcatenateCTM::globalBounds const):
(WebCore::DisplayList::SetInlineFillGradient::localBounds const):
(WebCore::DisplayList::SetInlineFillGradient::globalBounds const):
(WebCore::DisplayList::SetInlineFillColor::SetInlineFillColor):
(WebCore::DisplayList::SetInlineFillColor::color const):
(WebCore::DisplayList::SetInlineFillColor::localBounds const):
(WebCore::DisplayList::SetInlineFillColor::globalBounds const):
(WebCore::DisplayList::SetInlineStrokeColor::SetInlineStrokeColor):
(WebCore::DisplayList::SetInlineStrokeColor::color const):
(WebCore::DisplayList::SetInlineStrokeColor::localBounds const):
(WebCore::DisplayList::SetInlineStrokeColor::globalBounds const):
(WebCore::DisplayList::SetStrokeThickness::SetStrokeThickness):
(WebCore::DisplayList::SetStrokeThickness::thickness const):
(WebCore::DisplayList::SetStrokeThickness::localBounds const):
(WebCore::DisplayList::SetStrokeThickness::globalBounds const):
(WebCore::DisplayList::SetState::localBounds const):
(WebCore::DisplayList::SetState::globalBounds const):
(WebCore::DisplayList::SetState::decode):
(WebCore::DisplayList::SetLineCap::SetLineCap):
(WebCore::DisplayList::SetLineCap::localBounds const):
(WebCore::DisplayList::SetLineCap::globalBounds const):
(WebCore::DisplayList::SetLineDash::SetLineDash):
(WebCore::DisplayList::SetLineDash::localBounds const):
(WebCore::DisplayList::SetLineDash::globalBounds const):
(WebCore::DisplayList::SetLineDash::decode):
(WebCore::DisplayList::SetLineJoin::SetLineJoin):
(WebCore::DisplayList::SetLineJoin::localBounds const):
(WebCore::DisplayList::SetLineJoin::globalBounds const):
(WebCore::DisplayList::SetMiterLimit::SetMiterLimit):
(WebCore::DisplayList::SetMiterLimit::localBounds const):
(WebCore::DisplayList::SetMiterLimit::globalBounds const):
(WebCore::DisplayList::ClearShadow::localBounds const):
(WebCore::DisplayList::ClearShadow::globalBounds const):
(WebCore::DisplayList::Clip::Clip):
(WebCore::DisplayList::Clip::rect const):
(WebCore::DisplayList::Clip::localBounds const):
(WebCore::DisplayList::Clip::globalBounds const):
(WebCore::DisplayList::ClipOut::ClipOut):
(WebCore::DisplayList::ClipOut::rect const):
(WebCore::DisplayList::ClipOut::localBounds const):
(WebCore::DisplayList::ClipOut::globalBounds const):
(WebCore::DisplayList::ClipOutToPath::ClipOutToPath):
(WebCore::DisplayList::ClipOutToPath::localBounds const):
(WebCore::DisplayList::ClipOutToPath::globalBounds const):
(WebCore::DisplayList::ClipOutToPath::decode):
(WebCore::DisplayList::ClipPath::ClipPath):
(WebCore::DisplayList::ClipPath::localBounds const):
(WebCore::DisplayList::ClipPath::globalBounds const):
(WebCore::DisplayList::ClipPath::decode):
(WebCore::DisplayList::ClipToDrawingCommands::ClipToDrawingCommands):
(WebCore::DisplayList::ClipToDrawingCommands::localBounds const):
(WebCore::DisplayList::ClipToDrawingCommands::globalBounds const):
(WebCore::DisplayList::ClipToDrawingCommands::encode const):
(WebCore::DisplayList::ClipToDrawingCommands::decode):
(WebCore::DisplayList::DrawGlyphs::globalBounds const):
(WebCore::DisplayList::DrawGlyphs::localBounds const):
(WebCore::DisplayList::DrawGlyphs::encode const):
(WebCore::DisplayList::DrawGlyphs::decode):
(WebCore::DisplayList::DrawImage::DrawImage):
(WebCore::DisplayList::DrawImage::globalBounds const):
(WebCore::DisplayList::DrawImage::localBounds const):
(WebCore::DisplayList::DrawImage::decode):
(WebCore::DisplayList::DrawTiledImage::DrawTiledImage):
(WebCore::DisplayList::DrawTiledImage::globalBounds const):
(WebCore::DisplayList::DrawTiledImage::localBounds const):
(WebCore::DisplayList::DrawTiledImage::decode):
(WebCore::DisplayList::DrawTiledScaledImage::DrawTiledScaledImage):
(WebCore::DisplayList::DrawTiledScaledImage::globalBounds const):
(WebCore::DisplayList::DrawTiledScaledImage::localBounds const):
(WebCore::DisplayList::DrawTiledScaledImage::decode):
(WebCore::DisplayList::DrawImageBuffer::DrawImageBuffer):
(WebCore::DisplayList::DrawImageBuffer::globalBounds const):
(WebCore::DisplayList::DrawImageBuffer::localBounds const):
(WebCore::DisplayList::DrawImageBuffer::decode):
(WebCore::DisplayList::DrawNativeImage::source const):
(WebCore::DisplayList::DrawNativeImage::destinationRect const):
(WebCore::DisplayList::DrawNativeImage::globalBounds const):
(WebCore::DisplayList::DrawNativeImage::localBounds const):
(WebCore::DisplayList::DrawNativeImage::decode):
(WebCore::DisplayList::DrawPattern::DrawPattern):
(WebCore::DisplayList::DrawPattern::globalBounds const):
(WebCore::DisplayList::DrawPattern::localBounds const):
(WebCore::DisplayList::DrawPattern::decode):
(WebCore::DisplayList::BeginTransparencyLayer::BeginTransparencyLayer):
(WebCore::DisplayList::BeginTransparencyLayer::localBounds const):
(WebCore::DisplayList::BeginTransparencyLayer::globalBounds const):
(WebCore::DisplayList::EndTransparencyLayer::localBounds const):
(WebCore::DisplayList::EndTransparencyLayer::globalBounds const):
(WebCore::DisplayList::DrawRect::DrawRect):
(WebCore::DisplayList::DrawRect::globalBounds const):
(WebCore::DisplayList::DrawRect::localBounds const):
(WebCore::DisplayList::DrawLine::DrawLine):
(WebCore::DisplayList::DrawLine::globalBounds const):
(WebCore::DisplayList::DrawLinesForText::globalBounds const):
(WebCore::DisplayList::DrawLinesForText::decode):
(WebCore::DisplayList::DrawDotsForDocumentMarker::DrawDotsForDocumentMarker):
(WebCore::DisplayList::DrawDotsForDocumentMarker::globalBounds const):
(WebCore::DisplayList::DrawEllipse::DrawEllipse):
(WebCore::DisplayList::DrawEllipse::rect const):
(WebCore::DisplayList::DrawEllipse::globalBounds const):
(WebCore::DisplayList::DrawEllipse::localBounds const):
(WebCore::DisplayList::DrawPath::DrawPath):
(WebCore::DisplayList::DrawPath::globalBounds const):
(WebCore::DisplayList::DrawPath::localBounds const):
(WebCore::DisplayList::DrawPath::decode):
(WebCore::DisplayList::DrawFocusRingPath::DrawFocusRingPath):
(WebCore::DisplayList::DrawFocusRingPath::globalBounds const):
(WebCore::DisplayList::DrawFocusRingPath::decode):
(WebCore::DisplayList::DrawFocusRingRects::globalBounds const):
(WebCore::DisplayList::DrawFocusRingRects::decode):
(WebCore::DisplayList::FillRect::FillRect):
(WebCore::DisplayList::FillRect::rect const):
(WebCore::DisplayList::FillRect::globalBounds const):
(WebCore::DisplayList::FillRect::localBounds const):
(WebCore::DisplayList::FillRectWithColor::FillRectWithColor):
(WebCore::DisplayList::FillRectWithColor::globalBounds const):
(WebCore::DisplayList::FillRectWithColor::localBounds const):
(WebCore::DisplayList::FillRectWithColor::decode):
(WebCore::DisplayList::FillRectWithGradient::rect const):
(WebCore::DisplayList::FillRectWithGradient::gradient const):
(WebCore::DisplayList::FillRectWithGradient::globalBounds const):
(WebCore::DisplayList::FillRectWithGradient::localBounds const):
(WebCore::DisplayList::FillRectWithGradient::decode):
(WebCore::DisplayList::FillCompositedRect::FillCompositedRect):
(WebCore::DisplayList::FillCompositedRect::globalBounds const):
(WebCore::DisplayList::FillCompositedRect::localBounds const):
(WebCore::DisplayList::FillCompositedRect::decode):
(WebCore::DisplayList::FillRoundedRect::FillRoundedRect):
(WebCore::DisplayList::FillRoundedRect::globalBounds const):
(WebCore::DisplayList::FillRoundedRect::localBounds const):
(WebCore::DisplayList::FillRoundedRect::decode):
(WebCore::DisplayList::FillRectWithRoundedHole::FillRectWithRoundedHole):
(WebCore::DisplayList::FillRectWithRoundedHole::globalBounds const):
(WebCore::DisplayList::FillRectWithRoundedHole::localBounds const):
(WebCore::DisplayList::FillRectWithRoundedHole::decode):
(WebCore::DisplayList::FillInlinePath::FillInlinePath):
(WebCore::DisplayList::FillInlinePath::globalBounds const):
(WebCore::DisplayList::FillInlinePath::localBounds const):
(WebCore::DisplayList::FillPath::FillPath):
(WebCore::DisplayList::FillPath::globalBounds const):
(WebCore::DisplayList::FillPath::localBounds const):
(WebCore::DisplayList::FillPath::decode):
(WebCore::DisplayList::FillEllipse::FillEllipse):
(WebCore::DisplayList::FillEllipse::globalBounds const):
(WebCore::DisplayList::FillEllipse::localBounds const):
(WebCore::DisplayList::PutImageData::imageData const):
(WebCore::DisplayList::PutImageData::localBounds const):
(WebCore::DisplayList::PutImageData::globalBounds const):
(WebCore::DisplayList::PutImageData::encode const):
(WebCore::DisplayList::PutImageData::decode):
(WebCore::DisplayList::PaintFrameForMedia::localBounds const):
(WebCore::DisplayList::PaintFrameForMedia::globalBounds const):
(WebCore::DisplayList::StrokeRect::StrokeRect):
(WebCore::DisplayList::StrokeRect::globalBounds const):
(WebCore::DisplayList::StrokeInlinePath::StrokeInlinePath):
(WebCore::DisplayList::StrokeInlinePath::globalBounds const):
(WebCore::DisplayList::StrokePath::StrokePath):
(WebCore::DisplayList::StrokePath::globalBounds const):
(WebCore::DisplayList::StrokePath::decode):
(WebCore::DisplayList::StrokeEllipse::StrokeEllipse):
(WebCore::DisplayList::StrokeEllipse::rect const):
(WebCore::DisplayList::StrokeEllipse::globalBounds const):
(WebCore::DisplayList::ClearRect::ClearRect):
(WebCore::DisplayList::ClearRect::rect const):
(WebCore::DisplayList::ClearRect::globalBounds const):
(WebCore::DisplayList::ClearRect::localBounds const):
(WebCore::DisplayList::ApplyStrokePattern::localBounds const):
(WebCore::DisplayList::ApplyStrokePattern::globalBounds const):
(WebCore::DisplayList::ApplyFillPattern::localBounds const):
(WebCore::DisplayList::ApplyFillPattern::globalBounds const):
(WebCore::DisplayList::ApplyDeviceScaleFactor::ApplyDeviceScaleFactor):
(WebCore::DisplayList::ApplyDeviceScaleFactor::localBounds const):
(WebCore::DisplayList::ApplyDeviceScaleFactor::globalBounds const):
(WebCore::DisplayList::DrawingItem::setExtent): Deleted.
(WebCore::DisplayList::DrawingItem::extent const): Deleted.
(WebCore::DisplayList::DrawingItem::extentKnown const): Deleted.
(WebCore::DisplayList::DrawingItem::localBounds const): Deleted.
(WebCore::DisplayList::DrawingItem::globalBounds const): Deleted.
(WebCore::DisplayList::Save::create): Deleted.
(WebCore::DisplayList::Save::encode const): Deleted.
(WebCore::DisplayList::Save::decode): Deleted.
(WebCore::DisplayList::Restore::create): Deleted.
(WebCore::DisplayList::Restore::encode const): Deleted.
(WebCore::DisplayList::Restore::decode): Deleted.
(WebCore::DisplayList::Translate::create): Deleted.
(WebCore::DisplayList::Translate::encode const): Deleted.
(WebCore::DisplayList::Translate::decode): Deleted.
(WebCore::DisplayList::Rotate::create): Deleted.
(WebCore::DisplayList::Rotate::encode const): Deleted.
(WebCore::DisplayList::Rotate::decode): Deleted.
(WebCore::DisplayList::Scale::create): Deleted.
(WebCore::DisplayList::Scale::encode const): Deleted.
(WebCore::DisplayList::Scale::decode): Deleted.
(WebCore::DisplayList::SetCTM::create): Deleted.
(WebCore::DisplayList::SetCTM::encode const): Deleted.
(WebCore::DisplayList::SetCTM::decode): Deleted.
(WebCore::DisplayList::ConcatenateCTM::create): Deleted.
(WebCore::DisplayList::ConcatenateCTM::encode const): Deleted.
(WebCore::DisplayList::ConcatenateCTM::decode): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::create): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::encode const): Deleted.
(WebCore::DisplayList::SetInlineFillGradient::decode): Deleted.
(WebCore::DisplayList::SetInlineFillColor::encode const): Deleted.
(WebCore::DisplayList::SetInlineFillColor::decode): Deleted.
(WebCore::DisplayList::SetInlineStrokeColor::encode const): Deleted.
(WebCore::DisplayList::SetInlineStrokeColor::decode): Deleted.
(WebCore::DisplayList::SetStrokeThickness::encode const): Deleted.
(WebCore::DisplayList::SetStrokeThickness::decode): Deleted.
(WebCore::DisplayList::SetState::create): Deleted.
(WebCore::DisplayList::SetLineCap::create): Deleted.
(WebCore::DisplayList::SetLineCap::encode const): Deleted.
(WebCore::DisplayList::SetLineCap::decode): Deleted.
(WebCore::DisplayList::SetLineDash::create): Deleted.
(WebCore::DisplayList::SetLineJoin::create): Deleted.
(WebCore::DisplayList::SetLineJoin::encode const): Deleted.
(WebCore::DisplayList::SetLineJoin::decode): Deleted.
(WebCore::DisplayList::SetMiterLimit::create): Deleted.
(WebCore::DisplayList::SetMiterLimit::encode const): Deleted.
(WebCore::DisplayList::SetMiterLimit::decode): Deleted.
(WebCore::DisplayList::ClearShadow::create): Deleted.
(WebCore::DisplayList::ClearShadow::encode const): Deleted.
(WebCore::DisplayList::ClearShadow::decode): Deleted.
(WebCore::DisplayList::Clip::create): Deleted.
(WebCore::DisplayList::Clip::encode const): Deleted.
(WebCore::DisplayList::Clip::decode): Deleted.
(WebCore::DisplayList::ClipOut::create): Deleted.
(WebCore::DisplayList::ClipOut::encode const): Deleted.
(WebCore::DisplayList::ClipOut::decode): Deleted.
(WebCore::DisplayList::ClipOutToPath::create): Deleted.
(WebCore::DisplayList::ClipPath::create): Deleted.
(WebCore::DisplayList::ClipToDrawingCommands::create): Deleted.
(WebCore::DisplayList::DrawGlyphs::create): Deleted.
(WebCore::DisplayList::DrawImage::create): Deleted.
(WebCore::DisplayList::DrawTiledImage::create): Deleted.
(WebCore::DisplayList::DrawTiledScaledImage::create): Deleted.
(WebCore::DisplayList::DrawImageBuffer::create): Deleted.
(WebCore::DisplayList::DrawNativeImage::create): Deleted.
(WebCore::DisplayList::DrawPattern::create): Deleted.
(WebCore::DisplayList::BeginTransparencyLayer::create): Deleted.
(WebCore::DisplayList::BeginTransparencyLayer::encode const): Deleted.
(WebCore::DisplayList::BeginTransparencyLayer::decode): Deleted.
(WebCore::DisplayList::EndTransparencyLayer::create): Deleted.
(WebCore::DisplayList::EndTransparencyLayer::encode const): Deleted.
(WebCore::DisplayList::EndTransparencyLayer::decode): Deleted.
(WebCore::DisplayList::DrawRect::create): Deleted.
(WebCore::DisplayList::DrawRect::encode const): Deleted.
(WebCore::DisplayList::DrawRect::decode): Deleted.
(WebCore::DisplayList::DrawLine::create): Deleted.
(WebCore::DisplayList::DrawLine::encode const): Deleted.
(WebCore::DisplayList::DrawLine::decode): Deleted.
(WebCore::DisplayList::DrawLinesForText::create): Deleted.
(WebCore::DisplayList::DrawDotsForDocumentMarker::create): Deleted.
(WebCore::DisplayList::DrawDotsForDocumentMarker::encode const): Deleted.
(WebCore::DisplayList::DrawDotsForDocumentMarker::decode): Deleted.
(WebCore::DisplayList::DrawEllipse::create): Deleted.
(WebCore::DisplayList::DrawEllipse::encode const): Deleted.
(WebCore::DisplayList::DrawEllipse::decode): Deleted.
(WebCore::DisplayList::DrawPath::create): Deleted.
(WebCore::DisplayList::DrawFocusRingPath::create): Deleted.
(WebCore::DisplayList::DrawFocusRingRects::create): Deleted.
(WebCore::DisplayList::FillRect::create): Deleted.
(WebCore::DisplayList::FillRect::encode const): Deleted.
(WebCore::DisplayList::FillRect::decode): Deleted.
(WebCore::DisplayList::FillRectWithColor::create): Deleted.
(WebCore::DisplayList::FillRectWithGradient::create): Deleted.
(WebCore::DisplayList::FillCompositedRect::create): Deleted.
(WebCore::DisplayList::FillRoundedRect::create): Deleted.
(WebCore::DisplayList::FillRectWithRoundedHole::create): Deleted.
(WebCore::DisplayList::FillInlinePath::create): Deleted.
(WebCore::DisplayList::FillInlinePath::encode const): Deleted.
(WebCore::DisplayList::FillInlinePath::decode): Deleted.
(WebCore::DisplayList::FillPath::create): Deleted.
(WebCore::DisplayList::FillEllipse::create): Deleted.
(WebCore::DisplayList::FillEllipse::encode const): Deleted.
(WebCore::DisplayList::FillEllipse::decode): Deleted.
(WebCore::DisplayList::PutImageData::create): Deleted.
(WebCore::DisplayList::PaintFrameForMedia::encode const): Deleted.
(WebCore::DisplayList::PaintFrameForMedia::decode): Deleted.
(WebCore::DisplayList::StrokeRect::create): Deleted.
(WebCore::DisplayList::StrokeRect::encode const): Deleted.
(WebCore::DisplayList::StrokeRect::decode): Deleted.
(WebCore::DisplayList::StrokeInlinePath::create): Deleted.
(WebCore::DisplayList::StrokeInlinePath::encode const): Deleted.
(WebCore::DisplayList::StrokeInlinePath::decode): Deleted.
(WebCore::DisplayList::StrokePath::create): Deleted.
(WebCore::DisplayList::StrokeEllipse::create): Deleted.
(WebCore::DisplayList::StrokeEllipse::encode const): Deleted.
(WebCore::DisplayList::StrokeEllipse::decode): Deleted.
(WebCore::DisplayList::ClearRect::create): Deleted.
(WebCore::DisplayList::ClearRect::encode const): Deleted.
(WebCore::DisplayList::ClearRect::decode): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::create): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::encode const): Deleted.
(WebCore::DisplayList::ApplyStrokePattern::decode): Deleted.
(WebCore::DisplayList::ApplyFillPattern::create): Deleted.
(WebCore::DisplayList::ApplyFillPattern::encode const): Deleted.
(WebCore::DisplayList::ApplyFillPattern::decode): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::create): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::encode const): Deleted.
(WebCore::DisplayList::ApplyDeviceScaleFactor::decode): Deleted.
(WebCore::DisplayList::Item::encode const): Deleted.
(WebCore::DisplayList::Item::decode): Deleted.

Delete the generic Item::encode and Item::decode methods, since only out-of-line display list items have
encode and decode functions now.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::putImageData):
(WebCore::DisplayList::Recorder::appendStateChangeItem):
(WebCore::DisplayList::Recorder::clearShadow):
(WebCore::DisplayList::Recorder::setLineCap):
(WebCore::DisplayList::Recorder::setLineDash):
(WebCore::DisplayList::Recorder::setLineJoin):
(WebCore::DisplayList::Recorder::setMiterLimit):
(WebCore::DisplayList::Recorder::drawImage):
(WebCore::DisplayList::Recorder::drawTiledImage):
(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::drawNativeImage):
(WebCore::DisplayList::Recorder::drawPattern):
(WebCore::DisplayList::Recorder::save):
(WebCore::DisplayList::Recorder::restore):
(WebCore::DisplayList::Recorder::translate):
(WebCore::DisplayList::Recorder::rotate):
(WebCore::DisplayList::Recorder::scale):
(WebCore::DisplayList::Recorder::concatCTM):
(WebCore::DisplayList::Recorder::setCTM):
(WebCore::DisplayList::Recorder::beginTransparencyLayer):
(WebCore::DisplayList::Recorder::endTransparencyLayer):
(WebCore::DisplayList::Recorder::drawRect):
(WebCore::DisplayList::Recorder::drawLine):
(WebCore::DisplayList::Recorder::drawLinesForText):
(WebCore::DisplayList::Recorder::drawDotsForDocumentMarker):
(WebCore::DisplayList::Recorder::drawEllipse):
(WebCore::DisplayList::Recorder::drawPath):
(WebCore::DisplayList::Recorder::drawFocusRing):
(WebCore::DisplayList::Recorder::fillRect):
(WebCore::DisplayList::Recorder::fillRoundedRect):
(WebCore::DisplayList::Recorder::fillRectWithRoundedHole):
(WebCore::DisplayList::Recorder::fillPath):
(WebCore::DisplayList::Recorder::fillEllipse):
(WebCore::DisplayList::Recorder::strokeRect):
(WebCore::DisplayList::Recorder::strokePath):
(WebCore::DisplayList::Recorder::strokeEllipse):
(WebCore::DisplayList::Recorder::clearRect):
(WebCore::DisplayList::Recorder::applyStrokePattern):
(WebCore::DisplayList::Recorder::applyFillPattern):
(WebCore::DisplayList::Recorder::clip):
(WebCore::DisplayList::Recorder::clipOut):
(WebCore::DisplayList::Recorder::clipPath):
(WebCore::DisplayList::Recorder::clipToDrawingCommands):
(WebCore::DisplayList::Recorder::paintFrameForMedia):
(WebCore::DisplayList::Recorder::applyDeviceScaleFactor):

Change these methods that append display list items en masse, such that they go from this:

m_displayList.append(Foo::create(arg1, arg2, arg3));

...to this:

m_displayList.append<Foo>(arg1, arg2, arg3);

(WebCore::DisplayList::Recorder::extentFromLocalBounds const):
(WebCore::DisplayList::Recorder::appendItemAndUpdateExtent): Deleted.
(WebCore::DisplayList::Recorder::appendItem): Deleted.
(WebCore::DisplayList::Recorder::updateItemExtent const): Deleted.

Extents are now automatically updated (unless otherwise specified) for any drawing items that are appended.

platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::append):

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay):

platform/graphics/displaylists/DisplayListReplayer.h:

(WebCore::DisplayList::Replayer::Delegate::apply):

Source/WebKit:

Adjust for changes to display lists and display list items in WebCore (see Source/WebCore/ChangeLog for more
information). In particular, we implement the reading and writing client hooks consulted by ItemBuffer, and we
also add a temporary mechanism that allows RemoteRenderingBackendProxy (in the web process) to send display list
item data through shared memory to the RemoteRenderingBackend (in the GPU process). This temporary mechanism
does not attempt to make any reading or writing in shared memory concurrent between the GPU and web processes,
and exists only to make sure that rendering with the GPU process still works using these new display list items.

In the next patch, I will add a simple concurrent reader/writer model for display list processing between the
web and GPU processes, and (in doing so) revert most of the changes in RemoteRenderingBackend and
RemoteRenderingBackendProxy below.

See comments below for more detail.

GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::decodeAndCreate):

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::applyResourceItem):
(WebKit::RemoteRenderingBackend::applyMediaItem):

Refactor these to take WebCore::DisplayList::ItemHandle.

(WebKit::RemoteRenderingBackend::applyDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayList):
(WebKit::RemoteRenderingBackend::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackend::didCreateSharedItemData):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Scripts/webkit/messages.py:
Shared/SharedDisplayListHandle.cpp: Added.

(WebKit::SharedDisplayListHandle::SharedDisplayListHandle):
(WebKit::SharedDisplayListHandle::createDisplayList const):

Shared/SharedDisplayListHandle.h: Added.

Add a WebKit2 helper class that represents display list data in shared memory that is propagated from the web
process to the GPU process. In the next patch, this class will be rewritten to support concurrent display list
reading and writing, with specialized subclasses in service of both the reader (i.e. the GPU process) and the
writer (i.e. the web process).

(WebKit::SharedDisplayListHandle::SharedDisplayListHandle):
(WebKit::SharedDisplayListHandle::encode const):
(WebKit::SharedDisplayListHandle::decode):

Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::RemoteImageBufferProxy):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::flushDisplayList):
(WebKit::RemoteRenderingBackendProxy::flushDisplayListAndCommit):
(WebKit::RemoteRenderingBackendProxy::createItemBuffer):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

LayoutTests:

Rebaseline several existing (non-GPU-process) display list tests to account for a slight tweak in the format in
which display lists are dumped as text. More specifically, drawing item extents are now dumped after each
drawing item, rather than before.

displaylists/canvas-display-list-expected.txt:
displaylists/extent-includes-shadow-expected.txt:
displaylists/extent-includes-transforms-expected.txt:
displaylists/layer-dispay-list-expected.txt:
displaylists/replay-skip-clipped-rect-expected.txt:

10:44 AM Changeset in webkit [269524] by Truitt Savell

34 edits
15 deletes in trunk

Unreviewed, reverting r269486.

Caused 50+ timeouts on Mac Debug WK2

Reverted changeset:

"[Cocoa] Inspector Extensions: Add _WKInspectorExtension and
related plumbing"
https://bugs.webkit.org/show_bug.cgi?id=217783
https://trac.webkit.org/changeset/269486

10:42 AM Changeset in webkit [269523] by Wenson Hsieh

2 edits in trunk/Source/WebKit

Add some missing header includes in WebAuthenticatorCoordinator.cpp
https://bugs.webkit.org/show_bug.cgi?id=218661

Reviewed by Simon Fraser.

Add the missing headers.

WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

10:33 AM Changeset in webkit [269522] by jer.noble@apple.com

11 edits
2 adds in trunk

Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing.
https://bugs.webkit.org/show_bug.cgi?id=218640
<rdar://problem/70697738>

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/full-screen-enter-while-exiting.html

Pages can inadvertantly trap users in fullscreen mode by attempting to enter
fullscreen during an exit fullscreen operation, when both the exit and enter
were triggered by a user gesture. While this is not explicitly forbidden by
the Fullscreen specification, we already reject requests in similar situations,
such as when the document was hidden between the request and when the request
was handled.

dom/FullscreenManager.cpp:

(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::didExitFullscreen):

dom/FullscreenManager.h:

Tools:

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setEnterFullscreenForElementCallback):
(WTR::TestRunner::callEnterFullscreenForElementCallback):
(WTR::TestRunner::setExitFullscreenForElementCallback):
(WTR::TestRunner::callExitFullscreenForElementCallback):

WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

TestExpectations:
fullscreen/full-screen-enter-while-exiting-expected.txt: Added.
fullscreen/full-screen-enter-while-exiting.html: Added.
platform/wk2/TestExpectations:

10:30 AM Changeset in webkit [269521] by Alan Coon

7 edits in branches/safari-610.3.7.0-branch

Cherry-pick r266052. rdar://problem/71120600

RTCRtpSynchronizationSource.rtpTimestamp is not present
https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

Modules/mediastream/RTCRtpContributingSource.idl:
Modules/mediastream/RTCRtpContributingSource.idl:
Modules/mediastream/RTCRtpSynchronizationSource.idl: Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.
Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp: (WebCore::fillRTCRtpContributingSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:28 AM Changeset in webkit [269520] by Alan Coon

8 edits in branches/safari-610.3.7.0-branch/Source

Versioning.

WebKit-7610.3.7.0.2

10:20 AM Changeset in webkit [269519] by Kocsen Chung

6 edits
2 adds in branches/safari-610.3.7.1-branch

Cherry-pick r269121. rdar://problem/71120565

[MSE] Handle trackId changing across Initialization Segments
https://bugs.webkit.org/show_bug.cgi?id=218294
<rdar://problem/70771306>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-trackid-change.html

When appending an initialization segment after the receivedFirstInitializationSegment flag is
true, and when the number of video or audio tracks is 1, the trackId is allowed to change across
initialiaztion segments. When this occurs, move the TrackBuffer inside the trackBufferMap to
refer to the new trackId, so that when MediaSamples are parsed, they're put into the correct
TrackBuffer.

Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
html/track/AudioTrack.cpp: (WebCore::AudioTrack::setPrivate):
html/track/InbandTextTrack.cpp: (WebCore::InbandTextTrack::setPrivate):
html/track/VideoTrack.cpp: (WebCore::VideoTrack::setPrivate):

LayoutTests:

media/media-source/media-source-trackid-change-expected.txt: Added.
media/media-source/media-source-trackid-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [269518] by Kocsen Chung

7 edits in branches/safari-610.3.7.1-branch

Cherry-pick r266052. rdar://problem/71120601

RTCRtpSynchronizationSource.rtpTimestamp is not present
https://bugs.webkit.org/show_bug.cgi?id=215722

Patch by Justin Uberti <justin@uberti.name> on 2020-08-24
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations file to indicate that tests checking for .rtpTimestamp now pass.

LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Updated expected results in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt.

Modules/mediastream/RTCRtpContributingSource.idl:
Modules/mediastream/RTCRtpContributingSource.idl:
Modules/mediastream/RTCRtpSynchronizationSource.idl: Minor modification to ensure JSRTCRtpSynchronizationSource.cpp gets regenerated.
Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp: (WebCore::fillRTCRtpContributingSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:51 AM Changeset in webkit [269517] by Brent Fulgham

3 edits in trunk/Source/WebKit

[macOS] Allow IOAVDHEVCDecodeCapabilities on Intel
https://bugs.webkit.org/show_bug.cgi?id=218639
<rdar://problem/71100188>

Reviewed by Eric Carlson.

The current rule for IOAVDHEVCDecodeCapabilities is incorrect for macOS 11. We should
allow this access on Intel, too.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

9:20 AM Changeset in webkit [269516] by Kocsen Chung

8 edits in branches/safari-610.3.7.1-branch/Source

Versioning.

WebKit-7610.3.7.1.2

9:13 AM Changeset in webkit [269515] by Adrian Perez de Castro

2 edits in trunk/Tools

[Flatpak SDK] Update libmanette source URI to new location
https://bugs.webkit.org/show_bug.cgi?id=218509

Reviewed by Carlos Alberto Lopez Perez.

buildstream/elements/sdk/libmanette.bst: Update URI.

9:08 AM Changeset in webkit [269514] by clopez@igalia.com

3 edits in trunk/Tools

REGRESSION(r268930): It broke the http server of run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=218643

Reviewed by Jonathan Bedard.

The http server was failing to start because it is executed in a
subprocess and it can't find webkitpy.autoinstalled because the
scripts dir is not in PYTHONPATH.

Fix this and also add a check to ensure the http server is alive,
and if not, then raise an error with the return code and outputs
from the http server process.

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver._find_http_server_port):

9:04 AM WebKitGTK/2.30.x edited by Michael Catanzaro

(diff)

9:03 AM Changeset in webkit [269513] by clopez@igalia.com

5 edits in trunk/Tools

webkitpy: Add a --no-comment switch to webkit-patch land
https://bugs.webkit.org/show_bug.cgi?id=218067

Reviewed by Ryosuke Niwa.

Add an optional --no-comment switch to webkit-patch land.
This is useful when landing gardening, build-fixes or follow-up patches
on a bug and you don't want the tool to automatically add a comment with
the revision landed because you preffer to later add a comment manually.

Note that it will still close the bug, if you don't want the bug to
be closed you need to pass also --no-close.

Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.close_bug_as_fixed):

Scripts/webkitpy/tool/commands/download_unittest.py:

(DownloadCommandsTest._default_options):
(test_land_no_close):

Scripts/webkitpy/tool/steps/closebugforlanddiff.py:

(CloseBugForLandDiff.options):
(CloseBugForLandDiff.run):

Scripts/webkitpy/tool/steps/options.py:

(Options):

8:01 AM Changeset in webkit [269512] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Fix crashes around NetworkStorageSession::registerCookieChangeListenersIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=218626
<rdar://66837628>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-06
Reviewed by Chris Dumez.

We need to check if the NetworkStorageSession has been deallocated before using its member variables in a callback from CFNetwork.

platform/network/NetworkStorageSession.h:
platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::registerCookieChangeListenersIfNecessary):

7:50 AM Changeset in webkit [269511] by mark.lam@apple.com

12 edits in trunk/Source/JavaScriptCore

Use address diversified PAC to ensure the integrity of opcode maps.
https://bugs.webkit.org/show_bug.cgi?id=218646

Reviewed by Yusuke Suzuki.

One reason for doing this is because space in the JSCConfig is limited, and may
hurt RAMification scores if we need to expand it when adding new opcodes.
By putting the opcode maps in dirty global memory, we still use less memory
because dirty global memory does not incur internal fragmentation like the
JSCConfig does.

In this patch, we move g_jscConfig.llint.opcodeMap, g_jscConfig.llint.opcodeMapWide16,
and g_jscConfig.llint.opcodeMapWide32 back to global arrays g_opcodeMap, g_opcodeMapWide16,
and g_opcodeMapWide32.

interpreter/InterpreterInlines.h:

(JSC::Interpreter::getOpcodeID):

Since this function is only used debugging purposes during development, and is currently unused, we can just strip the PAC bits from the opcode when computing the opcodeID. The alternative to doing this requires that we know how the Opcode is signed by the client. Since this function is currently unused, we have no clients to study / fix up for now.

llint/LLIntData.cpp:

(JSC::LLInt::initialize):

Changed an ASSERT for llint_throw_from_slow_path_trampoline to static_assert, and add a second one as well for wasm_throw_from_slow_path_trampoline.
Moved the signing of the Opcode pointers into llint_entry() and wasm_entry() instead. Now, non-ARM64E ports don't need to execute this no-op assignment loop (assuming it wasn't already elided by the compiler).

llint/LLIntData.h:

(JSC::LLInt::opcodeMap):
(JSC::LLInt::opcodeMapWide16):
(JSC::LLInt::opcodeMapWide32):
(JSC::LLInt::getOpcode):
(JSC::LLInt::getOpcodeWide16):
(JSC::LLInt::getOpcodeWide32):

Change getOpcode(), getOpcodeWide16(), and getOpcodeWide32() to return a reference to the entry in the corresponding opcode map. This is needed because we need to be able to compute the address of the Opcode entry in order to retag the Opcode.

(JSC::LLInt::getCodePtrImpl):
(JSC::LLInt::getCodePtr):
(JSC::LLInt::getWide16CodePtr):
(JSC::LLInt::getWide32CodePtr):

llint/LowLevelInterpreter.asm:
llint/WebAssembly.asm:
Changed the bytecode dispatch jmps to use address diversification when authenticating the Opcode pointer.
Changed llint_entry and wasm_entry to also tag the Opcode pointers for ARM64E.
Changed llint_entry and wasm_entry to validate that they are only called during system initialization.

offlineasm/arm64.rb:
Optimize leap code generation to elide an add instruction if it's only adding 0 to a global address.

offlineasm/arm64e.rb:
offlineasm/ast.rb:
offlineasm/instructions.rb:
Added support for jmp or call using address diversified pointers.
Added a tagCodePtr instruction that also supports signing address diversified pointers.

runtime/JSCConfig.h:
runtime/JSCPtrTag.h:

(JSC::untagAddressDiversifiedCodePtr):

Added untagAddressDiversifiedCodePtr() so that we can retag the Opcode pointers.

6:33 AM Changeset in webkit [269510] by Antti Koivisto

29 edits in trunk/Source/WebCore

[LFC][Integration] localCaretOffset should use iterator
https://bugs.webkit.org/show_bug.cgi?id=218620

Reviewed by Zalan Bujtas.

Convert all localCaretRect implementations to use the inline iterator.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::localCaretRectForCharacterOffset):

editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect const):

editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::localCaretRect const):

layout/integration/LayoutIntegrationLineIterator.cpp:

(WebCore::LayoutIntegration::PathLine::computeCaretRect const):

layout/integration/LayoutIntegrationLineIterator.h:

(WebCore::LayoutIntegration::PathLine::logicalLeft const):
(WebCore::LayoutIntegration::PathLine::logicalRight const):

layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalLeft const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::logicalRight const):

layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):
(WebCore::LayoutIntegration::LineIteratorModernPath::logicalRight const):

layout/integration/LayoutIntegrationRunIterator.h:

(WebCore::LayoutIntegration::PathTextRun::positionForOffset const):

layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::offsetForPosition const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::positionForOffset const):

layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::positionForOffset const):
(WebCore::LayoutIntegration::RunIteratorModernPath::selectionRect const):
(WebCore::LayoutIntegration::RunIteratorModernPath::clampedOffset const):

Make clampedOffset return 0 based offset like it does in InlineTextBox to make porting easier.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect const):
(WebCore::RenderBlock::localCaretRect): Deleted.

rendering/RenderBlock.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect const):
(WebCore::RenderBox::localCaretRect): Deleted.

rendering/RenderBox.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement const):
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement): Deleted.

rendering/RenderBoxModelObject.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect const):
(WebCore::RenderInline::localCaretRect): Deleted.

rendering/RenderInline.h:
rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::localCaretRect const):
(WebCore::RenderLineBreak::linesBoundingBox const):
(WebCore::RenderLineBreak::localCaretRect): Deleted.

rendering/RenderLineBreak.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::localCaretRect const):
(WebCore::RenderObject::localCaretRect): Deleted.

rendering/RenderObject.h:
rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect const):
(WebCore::RenderText::localCaretRect): Deleted.

rendering/RenderText.h:
rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::createTextBox):
(WebCore::RenderSVGInlineText::localCaretRect const):
(WebCore::RenderSVGInlineText::localCaretRect): Deleted.

rendering/svg/RenderSVGInlineText.h:

6:09 AM Changeset in webkit [269509] by Oriol Brufau

2 edits in trunk/Source/WebCore

[css-grid] Prevent FindUsedFlexFraction from iterating items twice
https://bugs.webkit.org/show_bug.cgi?id=218630

Reviewed by Javier Fernandez.

IndefiniteSizeStrategy::findUsedFlexFraction needs to iterate all grid
items that cross a flexible track. To do so it, takes the indices of the
flex tracks, and for each one it uses GridIterator to iterate the items
in that track.

Then, to avoid processing the same item multiple times, it used to check
that the item started in the current flex track, not in a previous one.

However, this was insufficient: it wasn't taking into account that an
item can be in a single flex track, but span multiple tracks in the
other axis.

Therefore, this patch changes it to use the same approach as in
GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes, i.e. creates a
HashSet outside of the loop, and inserts each given grid item to it,
checking whether it's a new entry or not.

This is a port of https://crrev.com/821910 from Chromium.

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):

5:47 AM Changeset in webkit [269508] by Chris Lord

2 edits in trunk/Source/WebCore

REGRESSION(r269503): [GTK][WPE] >200 tests are failing
https://bugs.webkit.org/show_bug.cgi?id=218654

Reviewed by Žan Doberšek.

Implement GraphicsContextImplCairo::drawImageBuffer. Prior to r269503,
this function had an error return code, but this was removed and so
its implementation is now mandatory.

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImageBuffer):

2:09 AM Changeset in webkit [269507] by Diego Pino Garcia

4 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Gardened several flaky failures reported by the bot.

Also promoted several common failures (WebRTC, WebSQL) happening in GTK to GLIB.

platform/glib/TestExpectations:
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

1:44 AM Changeset in webkit [269506] by commit-queue@webkit.org

18 edits
3 copies
3 adds in trunk

Scroll snap specified on :root doesn't work
https://bugs.webkit.org/show_bug.cgi?id=210469
<rdar://problem/61746676>

Source/WebCore:

Properly handle scroll-snap-type on the root element.

This change is originally based on a patch by Simon Fraser.

Patch by Martin Robinson <mrobinson@igalia.com> on 2020-11-06
Reviewed by Simon Fraser.

Tests: tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy.html

tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-legacy.html
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe-legacy.html

page/FrameView.cpp:

(WebCore::FrameView::updateSnapOffsets): Send the body or root element style depending
on where the scroll-snap properties are set, but always use the FrameView viewport
when calculating geometry for scroll snap.

page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::updateSnapOffsetsForScrollableArea): Accept a viewport rectangle from the
caller and also eliminate redundant argument that was causing a bit of confusion.

page/scrolling/AxisScrollSnapOffsets.h: Update the function declaration.
platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::clearSnapOffsets): Added a helper to clear both vertical and horizontal snap info.

platform/ScrollableArea.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::findEnclosingScrollableContainerForSnapping const): Renamed findEnclosingScrollableContainer
to this because now it is only useful for scroll snapping. The only preexisting caller was
the scroll snap code.
(WebCore::RenderBox::findEnclosingScrollableContainer const): Deleted.

rendering/RenderBox.h: Updated method name.
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateSnapOffsets): Update to reflect changes to updateSnapOffsetsForScrollableArea.

rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingScrollableContainerForSnapping const): Always return the
document root as the container instead of the body. The body never captures scroll
snap points.

LayoutTests:

Patch by Martin Robinson <mrobinson@igalia.com> on 2020-11-06
Reviewed by Simon Fraser.

Modified main frame scroll snap tests to reflect the specification and add a
few more tests to test the legacy behavior which this change maintains for
backwards compatibility.

css3/scroll-snap/scroll-snap-positions-mainframe.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy-expected.txt: Added.
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-legacy.html: Copied from LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html.
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-legacy-expected.txt: Added.
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-legacy.html: Copied from LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html.
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html:
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe-legacy-expected.txt: Added.
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe-legacy.html: Copied from LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html.
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html:

1:09 AM Changeset in webkit [269505] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[GTK] Application cannot override drag&drop callbacks
https://bugs.webkit.org/show_bug.cgi?id=218562

Patch by Milan Crha <mcrha@redhat.com> on 2020-11-06
Reviewed by Michael Catanzaro.

UIProcess/API/gtk/DropTargetGtk3.cpp:

(WebKit::DropTarget::DropTarget): Use g_signal_connect_after(), thus
any descendants can override the callbacks.
(WebKit::DropTarget::didPerformAction): Always call gdk_drag_status(),
to have gtk+ notified about drag progress.

1:01 AM Changeset in webkit [269504] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[GTK] dlopen libWPEBackend-fdo-1.0.so.1 instead of libWPEBackend-fdo-1.0.so
https://bugs.webkit.org/show_bug.cgi?id=218584

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-11-06
Reviewed by Carlos Garcia Campos.

wpe_loader_init() tries to dlopen a development symlink, but these will not usually be
installed. It only works in the GNOME flatpak runtime because we don't use devel split
rules in the GNOME runtime, but we really ought to, and freedesktop-sdk already does, so
it's going to break upstream too once that gets implemented. It's easier for everyone if
we tackle this now. Since all major distros except Arch Linux use devel split, this patch
is really required for almost every distro to use WPE renderer.

The downside is that this makes it harder to update the wpebackend-fdo library version,
since minor changes there will now unnecessarily break WebKit. This is not good, but it's
better than forcing distros to apply this same patch downstream. I considered trying a bunch
of different library versions in a loop in order to maximize the chance of success in case
the wpebackend-fdo library version increases in the future, but it's probably nicer to just
be careful about not changing its library version until we find a better solution for this.

UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Nov 5, 2020:

11:27 PM Changeset in webkit [269503] by Said Abou-Hallawa

29 edits in trunk/Source

[GPU Process] Use the Ref counting of ImageBuffer to control its life cycle in Web Process and GPU Process
https://bugs.webkit.org/show_bug.cgi?id=218529

Reviewed by Simon Fraser.

Source/WebCore:

Every ImageBuffer will have a valid RenderingResourceIdentifer. It can be
either generated when the ImageBuffer is created. Or it can be set by the
caller. Setting it by the caller will happen only in the GPUP where we
need it match what was generated in the WebP.

When recording a DrawImageBuffer item, a Ref<ImageBuffer> of the source
ImageBuffer will be added to a HashSet in DisplayList. The goal is keep
this ImageBuffer alive till the DisplayList is cleared. The HashSet will
be cleared in DisplayList::clear() which will happen when either the
DisplayList is replayed back or sent to the GPUP.

This HashSet can be used to resolve the RenderingResourceIdentifer to an
ImageBuffer when replaying back the DisplayList either in WebP or in GPUP.

platform/graphics/ConcreteImageBuffer.h:

(WebCore::ConcreteImageBuffer::ConcreteImageBuffer):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):

platform/graphics/GraphicsContextImpl.h:
platform/graphics/ImageBuffer.h:
platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawImageBuffer):

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::clear):

platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::imageBuffers const):
(WebCore::DisplayList::DisplayList::cacheImageBuffer):

platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::isInlineItem):

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawImageBuffer::DrawImageBuffer):
(WebCore::DisplayList::DrawImageBuffer::apply const):

platform/graphics/displaylists/DisplayListItems.h:
platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawImageBuffer):

platform/graphics/displaylists/DisplayListRecorder.h:

(WebCore::DisplayList::Recorder::Delegate::~Delegate):
(WebCore::DisplayList::Recorder::Delegate::lockRemoteImageBuffer): Deleted.

platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::Replayer):
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::Replayer::replay):

platform/graphics/displaylists/DisplayListReplayer.h:
platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawImageBuffer):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:

Source/WebKit:

When a DrawImageBuffer item is appended to DisplayList, a Ref<ImageBuffer>
will be cached till the DisplayList items list is cleared. So no need to
lock the remote resource in RemoteResourceCacheProxy.

All we need to is to pass the ImageBufferHashMap which is maintained by
the DisplayList or by RemoteResourceCache to the DisplayList::Replayer.
It is going to be used to resolve the RenderingResourceIdentifer to an
ImageBuffer so the DrawImageBuffer can be applied.

No need to special-case DrawImageBuffer::apply() in the RemoteImageBuffer.

GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::RemoteImageBuffer):

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::applyResourceItem): Deleted.

GPUProcess/graphics/RemoteRenderingBackend.h:

(WebKit::RemoteRenderingBackend::remoteResourceCache):

GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheImageBuffer):

GPUProcess/graphics/RemoteResourceCache.h:

(WebKit::RemoteResourceCache::imageBuffers const):

WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::releaseRemoteResource):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::releaseImageBuffer):
(WebKit::RemoteResourceCacheProxy::RemoteResourceCacheProxy): Deleted.
(WebKit::RemoteResourceCacheProxy::lockRemoteImageBufferForRemoteClient): Deleted.
(WebKit::RemoteResourceCacheProxy::lockRemoteResourceForRemoteClient): Deleted.
(WebKit::RemoteResourceCacheProxy::releaseRemoteResource): Deleted.
(WebKit::RemoteResourceCacheProxy::unlockRemoteResourcesForRemoteClient): Deleted.

WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

8:18 PM Changeset in webkit [269502] by ysuzuki@apple.com

2 edits
1 add in trunk/JSTests

toLocaleDateString() resolves incorrect date for some old dates
https://bugs.webkit.org/show_bug.cgi?id=161623

Reviewed by Ryosuke Niwa.

The issue is that timezone offset in old Warsaw date was broken because localtime_r's tzdata is broken.
The issue itself was fixed in r218348. This patch adds another test case to ensure this is fixed.

complex.yaml:
complex/timezone-offset-and-dst-in-warsaw.js: Added.

(shouldBe):

7:07 PM Changeset in webkit [269501] by Brent Fulgham

3 edits in trunk/Source/WebKit

[macOS] Remove mdnsresponder access from WebKit processes
https://bugs.webkit.org/show_bug.cgi?id=218633
<rdar://problem/69133548>

Unreviewed follow-up: Make the sandbox rule conditional on recent macOS to
avoid breaking STP use on older macOS releases.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

7:06 PM WebKitGTK/2.30.x edited by clopez@igalia.com

(diff)

7:04 PM WebKitGTK/2.30.x edited by clopez@igalia.com

(diff)

6:05 PM Changeset in webkit [269500] by Chris Dumez

9 edits in trunk

window.event should not be affected by nodes moving post-dispatch
https://bugs.webkit.org/show_bug.cgi?id=218635

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test now that it is fully passing.

web-platform-tests/dom/events/event-global-extra.window-expected.txt:

Source/WebCore:

window.event should not be affected by nodes moving post-dispatch:

https://dom.spec.whatwg.org/#concept-event-listener-invoke

In particular, window.event should not get set when the event target was inside
a shadow tree initially when dispatchEvent() got called, even if the event target
gets moved out of the shadow tree during the execution of the event listeners.

Previously, our code was checking if the node was in a shadow tree at the point
of calling each event listener, instead of doing that check very initially when
dispatchEvent() is called.

No new tests, rebaselined existing test.

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

dom/Event.cpp:

(WebCore::Event::setCurrentTarget):
(WebCore::Event::resetAfterDispatch):

dom/Event.h:

(WebCore::Event::currentTargetIsInShadowTree const):

dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents const):

dom/EventContext.h:

(WebCore::EventContext::isCurrentTargetInShadowTree const):

dom/EventPath.cpp:

(WebCore::WindowEventContext::handleLocalEvents const):

6:02 PM Changeset in webkit [269499] by commit-queue@webkit.org

11 edits
1 move
12 adds
3 deletes in trunk

Align GBK and gb18030 encoder and decoder with specification and other browsers
https://bugs.webkit.org/show_bug.cgi?id=218380

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-05
Reviewed by David Kilzer.

LayoutTests/imported/w3c:

web-platform-tests/encoding/gb18030-encoder-expected.txt: Removed.
web-platform-tests/encoding/gb18030-encoder.html: Removed.
web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder-expected.txt: Added.
web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.html: Added.
web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder-expected.txt: Added.
web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html: Added.
web-platform-tests/encoding/legacy-mb-schinese/gb18030/resources/ranges.js: Added.
web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/gbk-encoder-expected.txt.
web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/gbk-encoder.html.
web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-decoder-expected.txt: Added.
web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-decoder.html: Added.

Source/WebCore:

We had been limping along using ICU with some post-processing to encode and decode legacy-encoded Simplified Chinese text,
but I implemented the standard with tests and compared behavior with other browsers. A few characters and several of the ranges
from https://encoding.spec.whatwg.org/index-gb18030-ranges.txt were missing from our copy of ICU's encoding tables.

I derive the encoding table from ICU's with one correction, then assert that it is equal to a reference copy of the table.
This keeps a release build of WebKit small.

Firefox's GBK decoder accepts anything that a gb18030 encoder would generate, which makes it more permissive than Chrome's,
but the spec says to be this permissive so we will, and we will have sites that currently work only in Firefox also work in WebKit.
See https://encoding.spec.whatwg.org/#gbk-decoder

Also, Chrome and WebKit before this change do not implement https://encoding.spec.whatwg.org/#gb18030-decoder step 7, which decodes 0x80
into U+20AC, the Euro sign.

No comprehensive tests had been written, so I wrote such tests to cover each failure mode and each range. Existing tests covered the differences
between GBK and gb18030 encoding and some of the code points from https://encoding.spec.whatwg.org/index-gb18030.txt . Comparison with ICU revealed
exactly one difference between ICU's decoder and Firefox's implementation, which was that a pointer of 6555 should map to a code point of U+e5e5,
so I added that code point to the unit tests. Because that was the only difference between ICU and the whatwg standard, I felt it would have been
overkill to test each of the 23940 code points, but I did move the Simplified Chinese legacy encoding tests to their own directory like Traditional
Chinese, Korean, and Japanese.

Tests: imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-decoder.html

imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html
imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder.html

platform/text/EncodingTables.cpp:

(WebCore::gb18030):

platform/text/EncodingTables.h:

(WebCore::CompareSecond::operator()):
(WebCore::makeSecondAdapter):

platform/text/TextCodecCJK.cpp:

(WebCore::TextCodecCJK::registerEncodingNames):
(WebCore::TextCodecCJK::registerCodecs):
(WebCore::eucJPEncode):
(WebCore::iso2022JPEncode):
(WebCore::shiftJISEncode):
(WebCore::eucKREncode):
(WebCore::big5Encode):
(WebCore::gb18030Ranges):
(WebCore::gb18030RangesCodePoint):
(WebCore::gb18030RangesPointer):
(WebCore::gb18030EncodeIndex):
(WebCore::TextCodecCJK::gb18030Decode):
(WebCore::gbEncodeShared):
(WebCore::gb18030Encode):
(WebCore::TextCodecCJK::gbkDecode):
(WebCore::gbkEncode):
(WebCore::TextCodecCJK::decode):
(WebCore::TextCodecCJK::encode const):

platform/text/TextCodecCJK.h:
platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::createICUConverter const):
(WebCore::TextCodecICU::decode):
(WebCore::TextCodecICU::encode const):
(WebCore::fallbackForGBK): Deleted.
(WebCore::gbkCallbackEscape): Deleted.
(WebCore::gbkUrlEscapedEntityCallack): Deleted.
(WebCore::gbkCallbackSubstitute): Deleted.

platform/text/TextCodecICU.h:

LayoutTests:

fast/encoding/char-encoding-expected.txt:
fast/encoding/char-encoding.html:

6:01 PM Changeset in webkit [269498] by commit-queue@webkit.org

5 edits in trunk/Source

Add null checks effectively in UserInputBridge
https://bugs.webkit.org/show_bug.cgi?id=218622
<rdar://problem/70724960>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-05
Reviewed by Wenson Hsieh.

Source/WebCore:

replay/UserInputBridge.cpp:

(WebCore::UserInputBridge::reloadFrame):
(WebCore::UserInputBridge::stopLoadingFrame):

replay/UserInputBridge.h:

Source/WebKit:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::stopLoadingFrame):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):

5:45 PM Changeset in webkit [269497] by mmaxfield@apple.com

9 edits
2 adds in trunk

[Cocoa] REGRESSION(r269211): Text with emoji can trigger drawing corruption
https://bugs.webkit.org/show_bug.cgi?id=218636
<rdar://problem/71066011>

Reviewed by Simon Fraser.

Source/WebCore:

We have an optimization for frequently-painting layers that we will turn text drawing
commands into display lists. r269211 added a bunch of context state introspection and
recreation code to make sure that the state being recorded matches the state during
playback. However, that code is incompatible with this cache idea, where the same DL
might be played back into multiple places.

The solution is to have two kinds of text display list drawing:

Deconstruct drawing commands into a series of commands. E.g. emoji will get

deconstructed into DrawImage commands. This kind of drawing must do state introspection
to make sure the emoji is drawn in the right place

Don't deconstruct the drawing commands; simply gather up the DrawGlyphs commands

and record them directly. This doesn't do state introspection.

GPU Process display lists use the first kind, while this text cache optimization uses
the second kind.

Test: fast/text/frequent-text.html

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::displayListForTextRun const):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorder.h:
platform/graphics/displaylists/DisplayListDrawGlyphsRecorderCoreText.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::DrawGlyphsRecorder):
(WebCore::DisplayList::DrawGlyphsRecorder::drawGlyphs):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::DrawGlyphsRecorder):

platform/graphics/displaylists/DisplayListDrawGlyphsRecorderWin.cpp:

(WebCore::DisplayList::DrawGlyphsRecorder::DrawGlyphsRecorder):

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):

platform/graphics/displaylists/DisplayListRecorder.h:

LayoutTests:

fast/text/frequent-text-expected.html: Added.
fast/text/frequent-text.html: Added.

5:27 PM Changeset in webkit [269496] by Alan Coon

1 copy in tags/Safari-610.3.6.2

Tag Safari-610.3.6.2.

5:13 PM Changeset in webkit [269495] by Alan Coon

8 edits in branches/safari-610.3.6-branch/Source

Versioning.

WebKit-7610.3.6.2

5:01 PM Changeset in webkit [269494] by Chris Dumez

3 edits in trunk/LayoutTests

unreviewed, rebaseline a couple tests on iOS after r269477.

platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:

4:51 PM Changeset in webkit [269493] by Alan Coon

1 copy in tags/Safari-610.3.7.1.1

Tag Safari-610.3.7.1.1.

4:49 PM Changeset in webkit [269492] by Alan Coon

1 copy in tags/Safari-610.3.7.0.1

Tag Safari-610.3.7.0.1.

4:32 PM Changeset in webkit [269491] by Brent Fulgham

4 edits in trunk/Source/WebKit

[macOS] Remove mdnsresponder access from WebKit processes
https://bugs.webkit.org/show_bug.cgi?id=218633
<rdar://problem/69133548>

Reviewed by Per Arne Vollan.

Now that all network loading (including media) happens in the Network process,
we can remove an old permission to open outbound connections to mdnsresponder.
This is also unneeded in the GPU process, for the same reason.

I noticed that the new WebAuthn process sandbox mistakenly included this,
and removed it there, too.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

4:17 PM Changeset in webkit [269490] by Alan Coon

1 copy in tags/Safari-610.3.6.1

Tag Safari-610.3.6.1.

4:16 PM Changeset in webkit [269489] by wilander@apple.com

16 edits in trunk

PCM: Switch to JSON report format
https://bugs.webkit.org/show_bug.cgi?id=218634
<rdar://problem/70469923>

Reviewed by Brent Fulgham.

The standards conversation has landed in attribution reports in a JSON
format as opposed to the currently implemented URL format. Discussion
here: https://github.com/privacycg/private-click-measurement/issues/30

Source/WebCore:

No new tests. Existing layout and API tests were updated.

Headers.cmake:

Added platform/network/HTTPHeaderValues.h to be able to expose it
to WebKit.

WebCore.xcodeproj/project.pbxproj:

Now exporting platform/network/HTTPHeaderValues.h.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

Changed a function call from AdClickAttribution::url() to
AdClickAttribution::reportURL().

loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::reportURL const):

The URL no longer carries the report values.
Renamed from AdClickAttribution::url().

(WebCore::AdClickAttribution::json const):

New function to generate and return the report JSON.

(WebCore::AdClickAttribution::url const): Deleted.

Renamed to AdClickAttribution::reportURL().

(WebCore::AdClickAttribution::referrer const): Deleted.

The referrer is now part of the report JSON.

(WebCore::AdClickAttribution::urlForTesting const): Deleted.

This class no longer needs to help generate test URLs
since report values are now in JSON.

loader/AdClickAttribution.h:
platform/network/FormData.h:

Added export of create(const CString&).

platform/network/HTTPHeaderValues.cpp:

(WebCore::HTTPHeaderValues::applicationJSONContentType):

Used create the new JSON report request.

platform/network/HTTPHeaderValues.h:

Added export of maxAge0().

Source/WebKit:

NetworkProcess/AdClickAttributionManager.cpp:

(WebKit::AdClickAttributionManager::fireConversionRequest):

Tools:

TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

http/tests/adClickAttribution/resources/conversionReport.php:
http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt:

4:16 PM Changeset in webkit [269488] by Alan Coon

3 edits in branches/safari-610.3.6-branch/Source/WebCore

Cherry-pick r269321. rdar://problem/71083865

Integrator's note: added a custom null check in HTMLMediaElement.cpp.

Protect against HTMLMediaElement being destroyed during disptachEvent().
https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:11 PM Changeset in webkit [269487] by Alan Coon

8 edits in branches/safari-610.3.6-branch/Source

Versioning.

WebKit-7610.3.6.1

4:03 PM Changeset in webkit [269486] by BJ Burg

34 edits
10 copies
5 adds in trunk

[Cocoa] Inspector Extensions: Add _WKInspectorExtension and related plumbing
https://bugs.webkit.org/show_bug.cgi?id=217783
<rdar://problem/69968787>

Reviewed by Devin Rousso.

Source/WebCore:

inspector/InspectorFrontendClient.h:
inspector/InspectorFrontendClientLocal.h:

In order for WebInspectorUIExtensionController to work with remote and local
inspectors, it stores a weak pointer the inspector's InspectorFrontendClient.
Expose the frontend's page so that the frontend API dispatcher can dispatch to it.

Source/WebInspectorUI:

UserInterface/Main.html: Add new files.

UserInterface/Controllers/AppControllerBase.js:

(WI.AppControllerBase):
(WI.AppControllerBase.prototype.get extensionController):
Hang the extension controller off of the global singleton, as there can only be one.

UserInterface/Controllers/WebInspectorExtensionController.js:

(WI.WebInspectorExtensionController):
(WI.WebInspectorExtensionController.prototype.registerExtension):
(WI.WebInspectorExtensionController.prototype.unregisterExtension):
Added. For now, just keep the UUIDs in a map and log the result.

UserInterface/Models/WebInspectorExtension.js:

(WI.WebInspectorExtension):
(WI.WebInspectorExtension.prototype.get extensionID):
(WI.WebInspectorExtension.prototype.get displayName):
Added. This is a data object for now.

UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):
(InspectorFrontendAPI.registerExtension):
(InspectorFrontendAPI.unregisterExtension):
Added. Forward invocations to the extension controller.

Source/WebKit:

_WKInspectorExtension is new SPI that represents a Web Extension that uses the 'devtools'
API to interact with Web Inspector. An extension is associated with its _WKInspectorExtensionHost.
A WebKit client that supports Web Extensions can use this class to implement 'devtools' extension APIs.

Add _WKInspectorExtensionHost methods to register and unregister an extension.
Add plumbing so that the extension in registered in the frontend with WI.InspectorExtensionController.

Later patches will flesh out the needed functionality to implement rest of the 'devtools' API.

Sources.txt:
SourcesCocoa.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
WebKit.xcodeproj/project.pbxproj:

Add new files.

Scripts/webkit/messages.py: If a message includes InspectorExtensionError,

then generate an include for InspectorExtensionTypes.h where it is declared.

Shared/API/APIObject.h:
Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
New API object type.

Shared/InspectorExtensionTypes.h: Added error code enum and useful type aliases.
Shared/InspectorExtensionTypes.cpp:

(WebKit::inspectorExtensionErrorToString):

UIProcess/API/APIInspectorExtension.h:
UIProcess/API/APIInspectorExtension.cpp:

(API::InspectorExtension::create):
(API::InspectorExtension::InspectorExtension):
(API::InspectorExtension::~InspectorExtension):
Added. This is a placeholder object that's used for the wrapper system,
since we don't have single C++ objects for each extension to back the API object.

UIProcess/API/Cocoa/_WKInspector.h:
UIProcess/API/Cocoa/_WKInspector.mm:

(-[_WKInspector registerExtensionWithID:displayName:completionHandler:]):
(-[_WKInspector unregisterExtension:completionHandler:]):
Implement new _WKInspectorExtensionHost methods. Send IPC to the Inspector web process.

UIProcess/API/Cocoa/_WKInspectorExtension.h:
UIProcess/API/Cocoa/_WKInspectorExtension.mm:

(-[_WKInspectorExtension initWithIdentifier:]):
(-[_WKInspectorExtension dealloc]):
(-[_WKInspectorExtension _apiObject]):
(-[_WKInspectorExtension extensionID]):
Added. This is a data object that's also used as a token to unregister the extension.

UIProcess/API/Cocoa/_WKInspectorExtensionHost.h: Add new SPI.
UIProcess/API/Cocoa/_WKInspectorExtensionInternal.h:

UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController registerExtensionWithID:displayName:completionHandler:]):
(-[_WKRemoteWebInspectorViewController unregisterExtension:completionHandler:]):
Implement new _WKInspectorExtensionHost methods. Send IPC to the Inspector web process.

UIProcess/Inspector/RemoteWebInspectorProxy.h:
UIProcess/Inspector/RemoteWebInspectorProxy.messages.in: Add FrontendLoaded.

(WebKit::RemoteWebInspectorProxy::extensionController const): Added.

UIProcess/Inspector/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::frontendLoaded):
(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):
Set up the extension controller object after the frontend has been created.
Hook up the FrontendLoaded event sent from Inspector web process so that the
extension controller can be notified of when it's safe to message the frontend.

UIProcess/Inspector/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createFrontendPage):
(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
(WebKit::WebInspectorProxy::frontendLoaded):
Set up the extension controller object after the frontend has been created.

UIProcess/Inspector/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::extensionController const): Added.

UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.h:
UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp: Added.

(WebKit::WebInspectorUIExtensionControllerProxy::WebInspectorUIExtensionControllerProxy):
(WebKit::WebInspectorUIExtensionControllerProxy::~WebInspectorUIExtensionControllerProxy):
(WebKit::WebInspectorUIExtensionControllerProxy::whenFrontendHasLoaded):
(WebKit::WebInspectorUIExtensionControllerProxy::inspectorFrontendLoaded):
(WebKit::WebInspectorUIExtensionControllerProxy::registerExtension):
(WebKit::WebInspectorUIExtensionControllerProxy::unregisterExtension):
Added. Forward API requests to the Web Inspector's web process to be evaluated in the frontend.

WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h:
WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.cpp:

(WebKit::WebInspectorFrontendAPIDispatcher::dispatchCommand):
Add a more generic way to encode values to be passed as arguments to InspectorFrontendAPI.dispatch.

WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::closeWindow):

WebProcess/Inspector/WebInspectorUI.h:

(WebKit::WebInspectorUI::frontendPage const): Added.
(WebKit::WebInspectorUI::frontendAPIDispatcher): Added.

WebProcess/Inspector/WebInspectorUIExtensionController.h:
WebProcess/Inspector/WebInspectorUIExtensionController.messages.in: Added.
WebProcess/Inspector/WebInspectorUIExtensionController.cpp: Added.

(WebKit::WebInspectorUIExtensionController::WebInspectorUIExtensionController):
(WebKit::WebInspectorUIExtensionController::~WebInspectorUIExtensionController):
(WebKit::WebInspectorUIExtensionController::registerExtension):
(WebKit::WebInspectorUIExtensionController::unregisterExtension):
(WebKit::WebInspectorUIExtensionController::parseInspectorExtensionErrorFromResult):
Handle incoming messages by forwarding the associated command to WI.WebExtensionController
via InspectorFrontendAPI evaluations.

UIProcess/API/Cocoa/_WKUserStyleSheet.h:
UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

Fallout from unified build chunking shifts.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
Fallout from unified build chunking shifts, but more.

Tools:

Add API tests to exercise new methods of the _WKInspectorExtensionHost protocol.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New test file.
TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionHost.mm: Added.

(resetGlobalState):
(-[UIDelegateForTestingInspectorExtensionHost _webView:didAttachLocalInspector:]):
(TEST):

3:58 PM Changeset in webkit [269485] by Alan Coon

1 copy in branches/safari-610.3.6-branch

New branch.

3:47 PM Changeset in webkit [269484] by Alan Coon

3 edits in branches/safari-610.3.7.100-branch/Source/WebCore

Cherry-pick r269321. rdar://problem/71083865

Integrator's note: added a custom null check in HTMLMediaElement.cpp.

Protect against HTMLMediaElement being destroyed during disptachEvent().
https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:42 PM Changeset in webkit [269483] by Alan Coon

8 edits in branches/safari-610.3.7.100-branch/Source

Versioning.

WebKit-7610.3.7.100.1

3:29 PM Changeset in webkit [269482] by Alan Coon

1 copy in branches/safari-610.3.7.100-branch

New branch.

3:27 PM Changeset in webkit [269481] by Chris Dumez

6 edits in trunk

Add implementation for Object.getOwnPropertyNames() on HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=218625

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing. The checks we are failing are failing
in Blink & Gecko also. The checks are are now passing are also passing in Blink & Gecko.

web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-names-expected.txt:

Source/WebCore:

Add implementation for Object.getOwnPropertyNames() on HTMLDocument so that it properly
returns names of the properties that would be returned by the named property getter.
This aligns our behavior with Blink and Gecko.

No new tests, rebaselined existing test.

dom/TreeScopeOrderedMap.cpp:

(WebCore::TreeScopeOrderedMap::keys const):

dom/TreeScopeOrderedMap.h:
html/HTMLDocument.cpp:

(WebCore::HTMLDocument::supportedPropertyNames const):

3:25 PM Changeset in webkit [269480] by Alan Coon

7 edits
1 delete in branches/safari-610.3.7.0-branch/Source

Revert r269208. rdar://problem/71044969

3:03 PM Changeset in webkit [269479] by sbarati@apple.com

2 edits in trunk/Source/WTF

Add back swap() free function for RefPtr
https://bugs.webkit.org/show_bug.cgi?id=218454

Reviewed by Darin Adler.

Add back the swap() free function I removed in r269115. Darin's suggestion
of specializing only a single type of RefPtr instead of two, solved the
issue. I also removed some previous hack where we didn't enable this for
RawPtrTraits. It's now enabled for all PtrTraits.

wtf/RefPtr.h:

(WTF::swap):

3:02 PM Changeset in webkit [269478] by sbarati@apple.com

2 edits in trunk/Source/WTF

Change RELEASE_ASSERT to use branch+crash inside HashTable.h
https://bugs.webkit.org/show_bug.cgi?id=218624
<rdar://problem/70901101>

Reviewed by Mark Lam.

The assertions added in r269017 used RELEASE_ASSERT. RELEASE_ASSERT
is implemented as invoking WTFCrashWithInfo, which does a bunch of register
argument/moves. Doing this in inlined hash table code bloats WK binaries
by a lot. This patch changes it so we just branch+crash on the same condition.

wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::add):

2:40 PM Changeset in webkit [269477] by Chris Dumez

10 edits in trunk

Expose referrerPolicy attribute on HTMLLinkElement and HTMLAreaElement
https://bugs.webkit.org/show_bug.cgi?id=218632

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline existing web-platform tests now that more checks are passing.

web-platform-tests/html/dom/reflection-embedded-expected.txt:
web-platform-tests/html/dom/reflection-metadata-expected.txt:

Source/WebCore:

Expose referrerPolicy attribute on HTMLLinkElement and HTMLAreaElement:

No new tests, rebaselined existing tests.

html/HTMLAreaElement.idl:
html/HTMLLinkElement.idl:

LayoutTests:

Rebaselined existing WPT tests now that more checks are passing.

platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

2:39 PM Changeset in webkit [269476] by Chris Dumez

7 edits in trunk

DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=218631

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

web-platform-tests/html/dom/idlharness.worker-expected.txt:

Source/WebCore:

DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers:

No new tests, rebaselined existing test.

dom/DOMStringList.idl:
html/TextMetrics.idl:
html/canvas/ImageBitmapRenderingContext.idl:

2:22 PM Changeset in webkit [269475] by Chris Dumez

18 edits
2 adds in trunk

Crash in AudioBuffer::sampleRate()
https://bugs.webkit.org/show_bug.cgi?id=218603

Reviewed by Geoffrey Garen.

Source/WebCore:

Have OfflineAudioDestinationNode store the sample rate instead of getting
it from the render buffer. It is possible for an OfflineAudioContext to
have no rendering buffer when constructing this rendering buffer fails
(e.g. because the length is too large).

Test: webaudio/OfflineAudioContext-bad-buffer-crash.html

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):

Modules/webaudio/AudioContext.h:
Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):

Modules/webaudio/AudioDestinationNode.h:
Modules/webaudio/BaseAudioContext.cpp:

(WebCore::BaseAudioContext::BaseAudioContext):

Modules/webaudio/BaseAudioContext.h:
Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):

Modules/webaudio/DefaultAudioDestinationNode.h:
Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::OfflineAudioContext):
(WebCore::OfflineAudioContext::create):

Modules/webaudio/OfflineAudioContext.h:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

Modules/webaudio/OfflineAudioDestinationNode.h:
Modules/webaudio/WebKitAudioContext.cpp:

(WebCore::WebKitAudioContext::WebKitAudioContext):

Modules/webaudio/WebKitAudioContext.h:
Modules/webaudio/WebKitOfflineAudioContext.cpp:

(WebCore::WebKitOfflineAudioContext::WebKitOfflineAudioContext):
(WebCore::WebKitOfflineAudioContext::create):

Modules/webaudio/WebKitOfflineAudioContext.h:

LayoutTests:

Add layout test coverage.

webaudio/OfflineAudioContext-bad-buffer-crash-expected.txt: Added.
webaudio/OfflineAudioContext-bad-buffer-crash.html: Added.

1:41 PM Changeset in webkit [269474] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Update message filters in the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=218520

Reviewed by Brent Fulgham.

Based on telemetry, update the message filters with allowed messages in the WebContent sandbox.

No new tests, covered by existing tests.

WebProcess/com.apple.WebProcess.sb.in:

1:35 PM Changeset in webkit [269473] by Ryan Haddad

1 edit
1 move
1 add in trunk/LayoutTests

fast/forms/search/search-size-with-decorations.html is failing on Catalina.

Unreviewed test gardening.

platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt: Renamed from LayoutTests/platform/mac-catalina/fast/forms/search-size-with-decorations-expected.txt.

1:35 PM Changeset in webkit [269472] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed, fix the build with recent SDKs.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::platformInvalidate):

1:35 PM Changeset in webkit [269471] by Ryan Haddad

2 edits in trunk/LayoutTests

[GPU Process] Add tests for sbix and COLR fonts in canvas
https://bugs.webkit.org/show_bug.cgi?id=218346

Unreviewed test gardening.

platform/mac/TestExpectations: Skip the tests for Mojave.

1:32 PM Changeset in webkit [269470] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore

[GTK] Add missing const_cast in gdk_event_get_source_device()

Unreviewed build fix.

platform/gtk/GtkVersioning.h:

(gdk_event_get_source_device):

12:58 PM Changeset in webkit [269469] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Rename BUILD_WEBKIT_URL to CURRENT_HOSTNAME
https://bugs.webkit.org/show_bug.cgi?id=218629

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/steps.py:

12:52 PM Changeset in webkit [269468] by don.olmstead@sony.com

14 edits in trunk/Source

Non-unified build fixes, early November 2020 edition
https://bugs.webkit.org/show_bug.cgi?id=218628

Unreviewed non-unified build fix.

Source/JavaScriptCore:

llint/LLIntSlowPaths.cpp:

Source/WebCore:

display/css/DisplayBox.cpp:
display/css/DisplayBoxFactory.cpp:
display/css/DisplayBoxFactory.h:
page/PageConfiguration.cpp:
rendering/style/StyleContentAlignmentData.cpp:
rendering/style/StyleContentAlignmentData.h:
rendering/style/StyleSelfAlignmentData.cpp:
rendering/style/StyleSelfAlignmentData.h:

Source/WebKit:

UIProcess/SpeechRecognitionServer.cpp:

(WebKit::SpeechRecognitionServer::start):
(WebKit::SpeechRecognitionServer::removePendingRequest):

WebProcess/WebCoreSupport/WebSpeechRecognitionConnection.cpp:

12:40 PM Changeset in webkit [269467] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews] Patch which break layout-test shouldn't cause infinite RETRY loop
https://bugs.webkit.org/show_bug.cgi?id=218618

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps.py:

(RunWebKitTests.evaluateResult): Do not retry when layout-tests fail with exit code 254. Instead fail the build-step, which
will trigger re-run and run-layout-tests-without-patch steps.
(RunWebKitTestsWithoutPatch.evaluateCommand): Set clean_tree_run_status build property.
(AnalyzeLayoutTestsResults.report_failure):
(AnalyzeLayoutTestsResults.start): If clean tree run passes, mark the build as failure.

CISupport/ews-build/steps_unittest.py: Added/updated unit-tests.

12:29 PM Changeset in webkit [269466] by Alan Coon

3 edits
2 adds in branches/safari-610.3.7.1-branch

Cherry-pick r269384. rdar://problem/71084559

REGRESSION (r257839): Miscomputed style due to computed 'rem' value in matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=218561
<rdar://problem/70074191>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/dom/focus-rem-style-update.html

Call to focus() causes computed style update for the element’s ancestor chain before the the document
has otherwise been styled (using the shortcut mechanism introduced in r257839). This style, which uses ‘rem’
unit and so depends on root element font size, gets cached in MatchedDeclarationsCache. The root font size
then changes but during the resulting style update we use this cached value, failing to re-resolve ‘rem’.

style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):

Invalidate matched declarations cache also when there is no existing document element style.

LayoutTests:

fast/dom/focus-rem-style-update-expected.html: Added.
fast/dom/focus-rem-style-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:29 PM Changeset in webkit [269465] by Alan Coon

2 edits in branches/safari-610.3.7.1-branch/Source/JavaScriptCore

Cherry-pick r269338. rdar://problem/71021911

Don't assert there is no checkpoint side state when dropping the JSLock
https://bugs.webkit.org/show_bug.cgi?id=218537

Reviewed by Filip Pizlo.

You may have multiple OSR exit sidestate data on the stack, and then call into
API code, which might DropAllLocks. Hence, this assert is wrong.

Working on a test. Will land in a followup.

runtime/JSLock.cpp: (JSC::JSLock::willReleaseLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:29 PM Changeset in webkit [269464] by Alan Coon

3 edits in branches/safari-610.3.7.1-branch/Source/WebCore

Cherry-pick r269321. rdar://problem/71083871

Protect against HTMLMediaElement being destroyed during disptachEvent().
https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:29 PM Changeset in webkit [269463] by Alan Coon

2 edits in branches/safari-610.3.7.1-branch/Source/WebCore

Cherry-pick r269190. rdar://problem/71080386

Increase camera failing timer to 30 seconds
https://bugs.webkit.org/show_bug.cgi?id=218389

Reviewed by Eric Carlson.

From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

platform/mediastream/mac/AVVideoCaptureSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:29 PM Changeset in webkit [269462] by Alan Coon

1 edit in branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.c

Apply patch. rdar://problem/71083441

12:11 PM Changeset in webkit [269461] by Alan Coon

8 edits in branches/safari-610.3.7.1-branch/Source

Versioning.

WebKit-7610.3.7.1.1

12:07 PM Changeset in webkit [269460] by Alan Coon

1 edit in branches/safari-610.3.7.0-branch/Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.c

Apply patch. rdar://problem/71083435

12:05 PM Changeset in webkit [269459] by youenn@apple.com

8 edits in trunk

WebSocket constructor should not throw in case port is blocked
https://bugs.webkit.org/show_bug.cgi?id=218617
LayoutTests/imported/w3c:

Reviewed by Alex Christensen.

web-platform-tests/websockets/Create-blocked-port.any-expected.txt:
web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt:

Source/WebCore:

Reviewed by Alex Christensen.

Update as per spec, see https://github.com/web-platform-tests/wpt/pull/5212.
Covered by existing tests.

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

LayoutTests:

<rdar://problem/71080398>

Reviewed by Alex Christensen.

Removing no longer valid test, correct version covered by WPT test.

http/tests/websocket/tests/hybi/url-parsing-expected.txt:
http/tests/websocket/tests/hybi/url-parsing.html:

11:52 AM Changeset in webkit [269458] by Simon Fraser

15 edits in trunk/Source/WebCore

Clean up ScrollingStateTree setPropertyChangesAfterReattach() code
https://bugs.webkit.org/show_bug.cgi?id=218621

Reviewed by Antti Koivisto.

Replace lots of individual setPropertyChangedInternal() calls with a single call
with an OptionSet<> argument.

The virtual applicableProperties() calls base classes to generate an OptionSet<>
of all the properties for a node type.

page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::applicableProperties const):
(WebCore::ScrollingStateFixedNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStateFixedNode.h:
page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::applicableProperties const):
(WebCore::ScrollingStateFrameScrollingNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStateFrameScrollingNode.h:
page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::applicableProperties const):
(WebCore::ScrollingStateNode::setPropertyChangesAfterReattach):

page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::setPropertiesChangedInternal):

page/scrolling/ScrollingStateOverflowScrollProxyNode.cpp:

(WebCore::ScrollingStateOverflowScrollProxyNode::applicableProperties const):
(WebCore::ScrollingStateOverflowScrollProxyNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStateOverflowScrollProxyNode.h:
page/scrolling/ScrollingStatePositionedNode.cpp:

(WebCore::ScrollingStatePositionedNode::applicableProperties const):
(WebCore::ScrollingStatePositionedNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStatePositionedNode.h:
page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::applicableProperties const):
(WebCore::ScrollingStateScrollingNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStateScrollingNode.h:
page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::applicableProperties const):
(WebCore::ScrollingStateStickyNode::setPropertyChangesAfterReattach): Deleted.

page/scrolling/ScrollingStateStickyNode.h:

11:51 AM Changeset in webkit [269457] by Alan Coon

2 edits in branches/safari-610.3.7.0-branch/Source/WebCore

Cherry-pick r269190. rdar://problem/70970247

Increase camera failing timer to 30 seconds
https://bugs.webkit.org/show_bug.cgi?id=218389

Reviewed by Eric Carlson.

From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

platform/mediastream/mac/AVVideoCaptureSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:49 AM Changeset in webkit [269456] by Alan Coon

3 edits
2 adds in branches/safari-610.3.7.0-branch

Cherry-pick r269384. rdar://problem/71043200

REGRESSION (r257839): Miscomputed style due to computed 'rem' value in matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=218561
<rdar://problem/70074191>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/dom/focus-rem-style-update.html

Call to focus() causes computed style update for the element’s ancestor chain before the the document
has otherwise been styled (using the shortcut mechanism introduced in r257839). This style, which uses ‘rem’
unit and so depends on root element font size, gets cached in MatchedDeclarationsCache. The root font size
then changes but during the resulting style update we use this cached value, failing to re-resolve ‘rem’.

style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement):

Invalidate matched declarations cache also when there is no existing document element style.

LayoutTests:

fast/dom/focus-rem-style-update-expected.html: Added.
fast/dom/focus-rem-style-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:49 AM Changeset in webkit [269455] by Alan Coon

3 edits in branches/safari-610.3.7.0-branch/Source/WebCore

Cherry-pick r269321. rdar://problem/71083865

Integrator's note: added a custom null check in HTMLMediaElement.cpp.

Protect against HTMLMediaElement being destroyed during disptachEvent().
https://bugs.webkit.org/show_bug.cgi?id=218398
<rdar://problem/67613836>

Reviewed by Chris Dumez.

Make the MainThreadGenericEventQueue protect the target as well as the owner of the queue.

Drive-by fix: Create the scoped eventFiringScope object after the protect object, to ensure
that the member variable set by the first scope will safely occur.

Drive-by fix #2: Also null-check the result of document().page() within HTMLMediaElement::dispatchEvent().

dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::dispatchOneEvent):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:49 AM Changeset in webkit [269454] by Alan Coon

7 edits
1 add in branches/safari-610.3.7.0-branch/Source

Cherry-pick r269208. rdar://problem/71044969

AX: Incorrect list of voices being displayed on iOS
https://bugs.webkit.org/show_bug.cgi?id=218293

Reviewed by Per Arne Vollan.

Source/WebCore:

Limit the voices that we display in WebSpeech to only built-in system voices. This was the intention of the "compact"
decision, but some mobile assets have compact voices, which are not available WebContent.

platform/ios/PlatformSpeechSynthesizerIOS.mm: (WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/PlatformMac.cmake:
pal/spi/cocoa/AXSpeechManagerSPI.h: Added.

Source/WTF:

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:17 AM Changeset in webkit [269453] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Clean up Source/WebCore/platform/graphics/DashArray.h
https://bugs.webkit.org/show_bug.cgi?id=218619

Reviewed by Simon Fraser.

Attempting to #include <WebCore/DisplayList.h> in API tests currently results in a compilation error when
parsing DashArray.h, due to the CGFloat type being unknown. Fix this by including CoreGraphics.h if
USE(CG) is defined.

platform/graphics/DashArray.h:

Also do some more cleanup around this file:

Use #pragma once instead of #define-based header guards.
Use using instead of typedef
Add a missing namespace WebCore around this file

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h: Add WebCore namespaces for DashArray.

11:12 AM Changeset in webkit [269452] by Chris Dumez

7 edits
4 adds in trunk

<input disabled> does not fire click events after dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=215461
<rdar://problem/67030950>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
web-platform-tests/html/semantics/forms/the-input-element/radio-input-cancel-expected.txt:

Source/WebCore:

We should allow mouse events from JS to get dispatched on disabled form controls. Only mouse events from the
user and calling input.click() should not cause an event to get dispatched on disabled form controls.

Tests: fast/dom/HTMLInputElement/disabled-checkbox-click.html

fast/dom/HTMLInputElement/disabled-radio-click.html

dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
Allow mouse events from JS to get dispatched on disabled form controls. Trusted mouse events (events from
the user-agent) are still not dispatched on disabled form controls.

html/RadioInputType.cpp:

(WebCore::RadioInputType::didDispatchClick):
Fix post activation behavior for radio input elements so that we set the elements' checkedness to false
if the activation was cancelled and we are not restoring the checkedness of the previously checked element
in the group.

https://html.spec.whatwg.org/#the-input-element:legacy-canceled-activation-behavior (Step 2)

LayoutTests:

Extend layout test coverage.

fast/dom/HTMLInputElement/disabled-checkbox-click-expected.txt: Added.
fast/dom/HTMLInputElement/disabled-checkbox-click.html: Added.
fast/dom/HTMLInputElement/disabled-radio-click-expected.txt: Added.
fast/dom/HTMLInputElement/disabled-radio-click.html: Added.

10:45 AM Changeset in webkit [269451] by Chris Dumez

32 edits
1 copy
19 adds
11 deletes in trunk/LayoutTests

Resync web-platform-tests/html/browsers & web-platform-tests/html/dom tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=218590

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Resync web-platform-tests/html/browsers & web-platform-tests/html/dom tests from upstream 7a287c9e26fbc12c91e.

web-platform-tests/html/browsers/*: Updated.
web-platform-tests/html/dom/*: Updated.

LayoutTests:

TestExpectations:
tests-options.json:

10:36 AM Changeset in webkit [269450] by graouts@webkit.org

4 edits
4 adds in trunk

REGRESSION (r263179): CSS checkbox no longer visible in iOS 14
https://bugs.webkit.org/show_bug.cgi?id=216690
<rdar://problem/69156576>

Reviewed by Simon Fraser.

Source/WebCore:

We revert the changes to RenderBox::addVisualEffectOverflow() introduced in
r263179 for bug 213260.

Instead of that original change, which affected painting instead of hit-testing,
we now ensure that RenderBlock::nodeAtPoint() will check the hit-test point is
within an element's clipped bounds before considering its children. Whether the
element has a self-painting layer should have no bearing here.

Tests: fast/box-shadow/box-shadow-with-zero-height.html

fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-2.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

rendering/RenderBox.cpp:

(WebCore::RenderBox::addVisualEffectOverflow):

LayoutTests:

Add two new tests: one that identifies the particular regression introduced by r263179 where
<div style="box-shadow: 0 0 0 10px"> would render nothing at all, and another one that does
further hit-testing on clipped child of an element with height: 0 and box-shadow to set ink
overflow which was failing even after r263179.

fast/box-shadow/box-shadow-with-zero-height-expected.html: Added.
fast/box-shadow/box-shadow-with-zero-height.html: Added.
fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-2-expected.txt: Added.
fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-2.html: Added.

10:29 AM Changeset in webkit [269449] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed, fix the build with recent SDKs.

Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::kill):

10:14 AM Changeset in webkit [269448] by Alan Coon

1 copy in tags/Safari-610.2.11.51.9

Tag Safari-610.2.11.51.9.

10:13 AM Changeset in webkit [269447] by Alan Coon

8 edits in branches/safari-610.2.11.51-branch/Source

Versioning.

WebKit-7610.2.11.51.9

9:50 AM Changeset in webkit [269446] by Kocsen Chung

1 copy in branches/safari-610.3.7.1-branch

New branch.

9:48 AM Changeset in webkit [269445] by Kocsen Chung

8 edits in branches/safari-610.3.7.0-branch/Source

Versioning.

WebKit-7610.3.7.0.1

9:38 AM Changeset in webkit [269444] by Brent Fulgham

4 edits in trunk/Source/WebKit

[iOS] Remove redundant rule using never-granted extension
https://bugs.webkit.org/show_bug.cgi?id=218596
<rdar://problem/66581246>

Reviewed by Per Arne Vollan.

WebKit has long had a sandbox rule granting the ability to issue iokit-open
operations if a particular security extension was granted to the process. The
WebKit processes are known to never grant this extension, so this rule is not
needed.

We should remove the rule to reduce sandbox complexity and increase the speed
of sandbox compilation.

Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

9:36 AM Changeset in webkit [269443] by Brent Fulgham

4 edits in trunk/Source/WebKit

[iOS] Remove redundant rule for shared-preference.read-write
https://bugs.webkit.org/show_bug.cgi?id=218594
<rdar://problem/66581796>

Reviewed by Per Arne Vollan.

We have long had a rule to allow shared preferences to be read and written if a
particular sandbox extension was granted to the process. However, we do not issue
this extension to any WebKit process, so the rule is unnecessary.

We should remove it to reduce confusion, and make the sandbox smaller (and quicker
to compile).

Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

9:36 AM Changeset in webkit [269442] by Darin Adler

24 edits in trunk/Source

Remove more functions that implicitly use composed tree
https://bugs.webkit.org/show_bug.cgi?id=218544

Reviewed by Ryosuke Niwa.

Source/WebCore:

dom/Node.cpp:

(WebCore::commonInclusiveAncestor): Changed this into a function template.

dom/Node.h: Ditto. Note this defaults to the traditional tree, and callers

have all been modified to use composed tree explicitly.

dom/Position.cpp:

(WebCore::commonInclusiveAncestor): Changed return type to a raw pointer.
Since I created this returning a smart pointer, Ryosuke clarified that our
approach to object lifetime does not involve returning smart pointers in
cases like this. Call commonInclusiveAncestor<ComposedTree>.
(WebCore::documentOrder): Ditto.

dom/Position.h: Updated return value.

dom/Range.cpp:

(WebCore::Range::commonAncestorContainer const): Made this non-inline.
Note that this now calls the non-composed-tree version of
commonInclusiveAncestor, which is what we want, but since live ranges
maintain the invariant that both containers are in the same tree, this is
not an observable change.

dom/Range.h: Made commonAncestorContainer non-inline. Not critical to

optimize out the function call.

dom/SimpleRange.cpp:

(WebCore::commonInclusiveAncestor): Changed this into a function template.

dom/SimpleRange.h: Updated for the above.

editing/ChangeListTypeCommand.cpp:

(WebCore::listConversionTypeForSelection): Use commonInclusiveAncestor<ComposedTree>.

editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart): Ditto.

editing/Editor.cpp:

(WebCore::Editor::adjustedSelectionRange): Ditto.

editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::elementForFormatBlockCommand): Ditto.

editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::scheduleObservationUpdate): Ditto.
(WebCore::TextManipulationController::replace): Ditto.

editing/VisiblePosition.cpp:

(WebCore::commonInclusiveAncestor): Added.
(WebCore::intersects): Added.
(WebCore::contains): Added.
(WebCore::intersection): Added.
(WebCore::midpoint): Added.

editing/VisiblePosition.h: Added functions that work with VisiblePositionRange.

These are used in WebKit editing-related code for iOS, and having these higher
level operations is starting to make that code more readable. This was originally
motivated because it was a use of a function template outside WebCore and I wanted
to sidestep the need to export, which I can't figure out how to do yet. But the
refactoring ended up changing the code completely.

editing/cocoa/HTMLConverter.mm:

(HTMLConverterCaches::cacheAncestorsOfStartToBeConverted): Updated since
commonInclusiveAncestor does not return a smart pointer any more.

editing/markup.cpp:

(WebCore::serializePreservingVisualAppearanceInternal): Ditto.

page/DragController.cpp:

(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Use
commonInclusiveAncestor<ComposedTree>.

page/EventHandler.cpp:

(WebCore::targetNodeForClickEvent): Ditto.

page/TextIndicator.cpp:

(WebCore::estimatedBackgroundColorForRange): Ditto.
(WebCore::initializeIndicator): Ditto.

rendering/RenderObject.cpp:

(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.

Source/WebKit:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::constrainRangeToSelection): Factored this function out of the
requestDocumentEditingContext and also rewrote it to use higher level operations.
(WebKit::WebPage::requestDocumentEditingContext): Refactored to use the new
constrainRangeToSelection.

9:33 AM Changeset in webkit [269441] by Kocsen Chung

1 copy in branches/safari-610.3.7.0-branch

New branch.

9:29 AM Changeset in webkit [269440] by Kocsen Chung

8 edits in branches/safari-610-branch/Source

Versioning.

WebKit-7610.4.1

9:19 AM Changeset in webkit [269439] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix build after r269435
https://bugs.webkit.org/show_bug.cgi?id=218599

loader/FrameLoader.cpp:

(WebCore::FrameLoader::opener):
(WebCore::FrameLoader::opener const):

9:01 AM Changeset in webkit [269438] by Patrick Angle

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(?): Sources: override banner is squished for large images
https://bugs.webkit.org/show_bug.cgi?id=218196

Reviewed by Devin Rousso.

Progressions made in https://trac.webkit.org/changeset/266695/webkit caused the image container to occupy the
maximum amount of space possible, which caused the override banner to be squished and a scrollbar to appear.
This is resolved by making sure the minimum dimensions of the image containers are 0, so that the container can
be flex-shrinked.

UserInterface/Views/ImageResourceContentView.css:

(.content-view.resource.image > .img-container):

8:58 AM Changeset in webkit [269437] by Aditya Keerthi

9 edits
2 adds in trunk

[macOS] Toggling dark mode does not update the scrollbar appearance in overflow: scroll elements
https://bugs.webkit.org/show_bug.cgi?id=218538
<rdar://problem/68953006>

Reviewed by Simon Fraser.

Source/WebCore:

This functionality regressed in r260276 with the introduction of async
overflow scrolling on macOS. The appearance of the scrollbar is determined
by [WebScrollerImpDelegate effectiveAppearanceForScrollerImp:]. Prior to
r260276, ScrollbarThemeMac::paint was responsible for painting the scrollbar,
using [NSScrollerImp drawKnob]. Calling this method results in a call to
effectiveAppearanceForScrollerImp:, ensuring the scrollbar has the correct
appearance.

However, async overflow scrolling no longer paints the scrollbar using
drawKnob, and a call to effectiveAppearanceForScrollImp: is no longer made
when switching between light/dark appearances. Since we no longer draw the
knob ourselves, and the NSScrollerImp does not belong to an NSView, the
scrollbar does not automatically get repainted on an appearance change.
To fix, we need to ensure the scrollbar is repainted by making a call to
[NSScrollerImp setNeedsDisplay:] when the page's appearance changes. This
should be done for all scrollbars to ensure their appearance is up to date.

Note that hovering over the scrollbar still results in an update to its
appearance, since AppKit always repaints the scrollbar on hover.

Test: fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode.html

dom/Document.cpp:

(WebCore::Document::invalidateScrollbars): Tell the FrameView to invalidate scrollbars in all its ScrollableAreas.

dom/Document.h:
page/FrameView.cpp:

(WebCore::FrameView::invalidateScrollbarsForAllScrollableAreas):

page/FrameView.h:
page/Page.cpp:

(WebCore::Page::appearanceDidChange): Tell each document to invalidate its scrollbars.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setScrollbarOverlayStyle):
(WebCore::ScrollableArea::invalidateScrollbars):

Moved scrollbar invalidation out of setScrollbarOverlayStyle and into
its own method, so that it can be called for all ScrollableAreas in a
FrameView.

platform/ScrollableArea.h:

LayoutTests:

Added a layout test which draws a scrollbar in the dark appearance,
switches to the light appearance, and draws the scrollbar again. The
final image should have a light appearance scrollbar.

fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode-expected.html: Added.
fast/scrolling/mac/overflow-scrollbars-toggle-dark-mode.html: Added.

8:56 AM Changeset in webkit [269436] by youenn@apple.com

9 edits
1 copy
1 move
3 adds
1 delete in trunk

Consider blocking ports 5060 and 5061
https://bugs.webkit.org/show_bug.cgi?id=218557
<rdar://problem/71031479>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.html: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.js: Added.

(BLOCKED_PORTS_LIST.map):

web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.worker.html: Added.
web-platform-tests/fetch/api/request/request-bad-port.html: Removed.
web-platform-tests/tools/wptserve/wptserve/utils.py:

(is_bad_port):

web-platform-tests/websockets/Create-blocked-port.any-expected.txt:
web-platform-tests/websockets/Create-blocked-port.any.js:
web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt:

Source/WTF:

wtf/URL.cpp:

(WTF::portAllowed):

LayoutTests:

TestExpectations:

8:54 AM Changeset in webkit [269435] by achristensen@apple.com

30 edits in trunk/Source

Store WeakPtr<Frame> instead of Frame*
https://bugs.webkit.org/show_bug.cgi?id=218599

Reviewed by Youenn Fablet.

Source/WebCore:

No change in behavior, but this probably fixes some bugs.

bindings/js/WindowProxy.cpp:

(WebCore::WindowProxy::WindowProxy):
(WebCore::WindowProxy::frame const):

bindings/js/WindowProxy.h:

(WebCore::WindowProxy::frame const): Deleted.

dom/Document.cpp:

(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::canNavigateInternal):
(WebCore::Document::setDesignMode):
(WebCore::Document::getDesignMode const): Deleted.

dom/Document.h:
html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::setContentFrame):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::contentFrame const):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameForId):
(WebCore::InspectorPageAgent::frameId):

inspector/agents/InspectorPageAgent.h:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::commitLoad):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::removeSubresourceLoader):
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDocument):
(WebCore::DocumentWriter::decoder):
(WebCore::DocumentWriter::setFrame):

loader/DocumentWriter.h:

(WebCore::DocumentWriter::setFrame): Deleted.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachFromAllOpenedFrames):
(WebCore::FrameLoader::opener):
(WebCore::FrameLoader::setOpener):
(WebCore::FrameLoader::hasOpenedFrames const):
(WebCore::FrameLoader::addExtraFieldsToRequest):

loader/FrameLoader.h:
loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::FrameNetworkingContext):
(WebCore::FrameNetworkingContext::frame const):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::update):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingEntry):
(WebCore::ApplicationCacheGroup::didFailLoadingManifest):
(WebCore::ApplicationCacheGroup::startLoadingEntry):

loader/appcache/ApplicationCacheGroup.h:
page/AbstractFrame.h:
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::addDestructionObserver):
(WebCore::Frame::removeDestructionObserver):

page/Frame.h:
page/FrameDestructionObserver.cpp:

(WebCore::FrameDestructionObserver::frame const):
(WebCore::FrameDestructionObserver::observeFrame):

page/FrameDestructionObserver.h:

(WebCore::FrameDestructionObserver::frame const): Deleted.

page/FrameTree.cpp:

(WebCore::FrameTree::FrameTree):
(WebCore::FrameTree::parent const):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::removeChild):
(WebCore::FrameTree::traverseNextInPostOrder const):

page/FrameTree.h:

(WebCore::FrameTree::previousSibling const):
(WebCore::FrameTree::lastChild const):
(WebCore::FrameTree::FrameTree): Deleted.

rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::RenderScrollbar):

rendering/RenderScrollbar.h:

Source/WebKit:

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::initWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::coreFrame const):
(WebKit::WebFrame::info const):
(WebKit::WebFrame::handlesPageScaleGesture const):
(WebKit::WebFrame::requiresUnifiedScaleFactor const):

WebProcess/WebPage/WebFrame.h:

(WebKit::WebFrame::coreFrame const): Deleted.

8:46 AM Changeset in webkit [269434] by commit-queue@webkit.org

7 edits in trunk/Source

Use fewer raw pointers and more const correctness in Frame.h
https://bugs.webkit.org/show_bug.cgi?id=218598

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-05
Reviewed by Youenn Fablet.

Source/WebCore:

loader/FrameLoader.cpp:

(WebCore::FrameLoader::opener): Deleted.

loader/FrameLoader.h:
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::page const):
(WebCore::Frame::ownerElement const):
(WebCore::Frame::ownerRenderer const):

page/Frame.h:

(WebCore::Frame::loader const): Deleted.
(WebCore::Frame::ownerElement const): Deleted.
(WebCore::Frame::page const): Deleted.

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebKit::toWebFrameLoaderClient):

8:21 AM Changeset in webkit [269433] by Patrick Angle

2 edits in trunk/Tools

Change my (Patrick Angle's) status to committer.

Unreviewed, updating contributors.json for myself.

Scripts/webkitpy/common/config/contributors.json:

8:12 AM Changeset in webkit [269432] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Use std::exchange instead of WTFMove to avoid using members after moving them in NavigationScheduler.cpp
https://bugs.webkit.org/show_bug.cgi?id=218597

Patch by Alex Christensen <achristensen@webkit.org> on 2020-11-05
Reviewed by Wenson Hsieh.

This shouldn't change behavior, but it leaves the members in a defined state.

loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::cancel):

7:35 AM Changeset in webkit [269431] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Add visual support for text-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=218572

Reviewed by Antti Koivisto.

In this patch we replace the trailing overflow content with ellipsis:

Check if the current run is the last run on the line that can include the ellipsis text without getting clipped.
"Empty" any subsequent runs as far as Run::renderedContent() is concerned (see Run::originalContent vs. Run::renderedContent)

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):

7:02 AM Changeset in webkit [269430] by Lauro Moura

3 edits in trunk/Tools

[GTK] Test /webkit/WebKitWebsiteData/configuration is flaky
https://bugs.webkit.org/show_bug.cgi?id=205441

Reviewed by Carlos Garcia Campos.

Checking the last 200 runs of gtk-release in the bots, the original
error from the report does not appear, but other flakies happened
related to checking if some directories were created (namely
indexeddb, service-workers and dom-cache). As they are created
asynchronously or lazily (i.e. requiring some operation to happen).
This could be seen in the WPE bots, not covered by the original
expectation, and also reproduced locally by running the test case
alone.

This commit adds some steps/wait time before each of these to make
sure the directories are created properly.

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(testWebsiteDataConfiguration): Add required steps before checking
directories

TestWebKitAPI/glib/TestExpectations.json: Remove expectation

6:44 AM Changeset in webkit [269429] by commit-queue@webkit.org

2 edits in trunk/Tools

Test that skip_validation is effective
https://bugs.webkit.org/show_bug.cgi?id=218611

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-05
Reviewed by Aakash Jain.

CISupport/ews-build/steps_unittest.py:

6:23 AM Changeset in webkit [269428] by commit-queue@webkit.org

2 edits in trunk/Tools

Test that TransferToS3 is skipped properly
https://bugs.webkit.org/show_bug.cgi?id=218610

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-05
Reviewed by Aakash Jain.

I.e. when not running on steps.EWS_BUILD_HOSTNAME.

CISupport/ews-build/steps_unittest.py:

6:14 AM Changeset in webkit [269427] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Transition hyphenated content to Run::renderedContent()
https://bugs.webkit.org/show_bug.cgi?id=218552

Reviewed by Antti Koivisto.

Currently hyphenated content is being constructed during paint time. This patch takes advantage of the
new Run::renderedContent() API.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::constructContent):
(WebCore::LayoutIntegration::LineLayout::paint):

5:11 AM Changeset in webkit [269426] by commit-queue@webkit.org

3 edits
1 move
3 adds
4 deletes in trunk/LayoutTests

[css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder
https://bugs.webkit.org/show_bug.cgi?id=218565
LayoutTests/imported/w3c:

Patch by Ziran Sun <Ziran Sun> on 2020-11-05
Reviewed by Manuel Rego Casasnovas.

web-platform-tests/css/css-grid/parsing/grid-columns-rows-get-set-multiple-expected.txt: Added.
web-platform-tests/css/css-grid/parsing/grid-columns-rows-get-set-multiple.html: Added.
web-platform-tests/css/css-grid/parsing/grid-content-sized-columns-resolution-expected.txt: Added.
web-platform-tests/css/css-grid/parsing/grid-content-sized-columns-resolution.html: Renamed from LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html.
web-platform-tests/css/css-grid/parsing/w3c-import.log: Updated.

LayoutTests:

These changes have been moved upstream in Chromium
at https://chromium-review.googlesource.com/c/chromium/src/+/2436821
and ported in WPT at
https://github.com/web-platform-tests/wpt/commit/7a287c9e26fbc12c91e1dde91859fabed96254b6

Patch by Ziran Sun <Ziran Sun> on 2020-11-05
Reviewed by Manuel Rego Casasnovas.

fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt: Removed.
fast/css-grid-layout/grid-columns-rows-get-set-multiple.html: Removed.
fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt: Removed.
fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js: Removed.

5:06 AM WebKitGTK/2.30.x edited by clopez@igalia.com

(diff)

4:49 AM Changeset in webkit [269425] by Diego Pino Garcia

4 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Gardened several flaky failures reported in test bot.

platform/glib/TestExpectations:
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

4:23 AM Changeset in webkit [269424] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Let's compute display lines visual alignments first before the runs
https://bugs.webkit.org/show_bug.cgi?id=218551

Reviewed by Antti Koivisto.

In this patch we pre-compute visual adjustement properties that we later use during run construction
(e.g. whether the runs on the line need vertical snapping).
This patch is also in preparation for adding support for "text-overflow: ellipsis". The pre-computed
LineLevelVisualAdjustmentsForRuns.needsTrailingContentReplacement will drive the content truncation logic for the ellipsis.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::lineOverflowWidth):
(WebCore::LayoutIntegration::LineLayout::constructContent):

4:17 AM Changeset in webkit [269423] by commit-queue@webkit.org

2 edits in trunk/Tools

Don't mark TransferToS3 as failed if it was skipped
https://bugs.webkit.org/show_bug.cgi?id=218606

Patch by Angelos Oikonomopoulos <Angelos Oikonomopoulos> on 2020-11-05
Reviewed by Aakash Jain.

CISupport/ews-build/steps.py:

(TransferToS3.getResultSummary):

3:10 AM Changeset in webkit [269422] by commit-queue@webkit.org

2 edits in trunk/Tools

Update my information in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=218608

Patch by Rob Buis <rbuis@igalia.com> on 2020-11-05
Reviewed by Carlos Garcia Campos.

Update my information in contributors.json to change the autocomplete email address to be Igalia.

Scripts/webkitpy/common/config/contributors.json:

12:47 AM Changeset in webkit [269421] by Carlos Garcia Campos

4 edits in trunk

WebDriver: handle surrogate pairs in keyboard actions
https://bugs.webkit.org/show_bug.cgi?id=218279

Reviewed by Brian Burg.

Source/WebKit:

And fail with invalid argument if the string can be represented as a single code point.

Fixes: imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_codepoint_keys_behave_correctly[\U0001f604]

imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_codepoint_keys_behave_correctly[\U0001f60d]
imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_invalid_multiple_codepoint_keys_fail[fa]
imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_invalid_multiple_codepoint_keys_fail[\u0ba8\u0bbfb]
imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_invalid_multiple_codepoint_keys_fail[\u0ba8\u0bbf\u0ba8]
imported/w3c/webdriver/tests/perform_actions/key_special_keys.py::test_invalid_multiple_codepoint_keys_fail[\u1100\u1161\u11a8c]

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::pressedCharKey):
(WebKit::WebAutomationSession::performInteractionSequence):

WebDriverTests:

Remove expectations for tests that are now passing.

TestExpectations.json:

12:46 AM Changeset in webkit [269420] by jiewen_tan@apple.com

4 edits in trunk

[WebAuthn] Determine an AAGUID for the platform authenticators
https://bugs.webkit.org/show_bug.cgi?id=217945
<rdar://problem/70811618>

Reviewed by Brent Fulgham.

Source/WebKit:

Relying parties use the AAGUID to recognize supported authenticators. Using a NULL AAGUID blocks them from recognizing Apple products as valid WebAuthentication targets.
We need to assign ourselves a GUID representing Apple authenticators, then publish with our attestation certificate and with the FIDO Alliance.

Covered by existing tests.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:

(WebKit::LocalAuthenticatorInternal::aaguidVector):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):

LayoutTests:

http/wpt/webauthn/public-key-credential-create-success-local.https.html:

12:45 AM Changeset in webkit [269419] by Carlos Garcia Campos

7 edits in trunk/Source

WebDriver: session can have more than one active input source of the same type
https://bugs.webkit.org/show_bug.cgi?id=218382

Reviewed by Brian Burg.

Source/WebDriver:

Only send to the browser the list of input sources actually used by the action sequence.

Session.cpp:

(WebDriver::Session::performActions):

Source/WebKit:

We are failing in that case, and the dispatcher assumes it's not possible, but the spec doesn't say there's such
limitation and there's a WPT infrastructure test checking that (infrastructure/testdriver/actions/eventOrder.html).

UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputKeyFrame::keyFrameFromStateOfInputSources): Input sources are now stored in a HashMap.
(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources): Ditto.
(WebKit::SimulatedInputDispatcher::run): We don't need to copy the given input sources, since they are owned by
the session.
(WebKit::SimulatedInputDispatcher::finishDispatching): Ditto.

UIProcess/Automation/SimulatedInputDispatcher.h:
UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::WebAutomationSession): Do not create initial input sources for each type.
(WebKit::WebAutomationSession::performInteractionSequence): Check there aren't multiple input sources with the
same ID, but don't fail if there are multiple input sources with the same type.
(WebKit::WebAutomationSession::cancelInteractionSequence): Clear the active input sources.
(WebKit::WebAutomationSession::inputSourceForType): Removed.

UIProcess/Automation/WebAutomationSession.h:

12:21 AM Changeset in webkit [269418] by ysuzuki@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, build fix for ARM64E part 2
https://bugs.webkit.org/show_bug.cgi?id=218587

cssjit/SelectorCompiler.h:

12:12 AM Changeset in webkit [269417] by ysuzuki@apple.com

4 edits in trunk/Source

Unreviewed, build fix for ARM64E
https://bugs.webkit.org/show_bug.cgi?id=218587

Source/JavaScriptCore:

llint/LLIntData.cpp:

Source/WebCore:

cssjit/SelectorCompiler.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed