Timeline
Dec 21, 2020:
- 9:20 PM Changeset in webkit [271048] by
-
- 8 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=220078
Remove non-inclusive language from WebGL tests
Reviewed by Alex Christensen.
- webgl/1.0.3/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
- webgl/1.0.3/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html:
- webgl/2.0.0/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
- webgl/2.0.0/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html:
- webgl/2.0.0/resources/webgl_test_files/conformance2/rendering/element-index-uint.html:
- webgl/2.0.0/resources/webgl_test_files/conformance2/vertex_arrays/vertex-array-object.html:
- webgl/2.0.0/resources/webgl_test_files/js/tests/no-over-optimizations-on-uniform-array.js:
(setupTests):
- 7:23 PM Changeset in webkit [271047] by
-
- 2 edits in trunk/Tools
[macOS MiniBrowser] Add menu items to reset all experimental and internal debug features to defaults
https://bugs.webkit.org/show_bug.cgi?id=220060
Reviewed by Wenson Hsieh.
Add menu items at the bottom of the "Experimental" and "Internal Debug" feature submenus
to reset all the features to their default values.
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController resetAllExperimentalFeatures:]):
(-[SettingsController resetAllInternalDebugFeatures:]):
- 5:04 PM Changeset in webkit [271046] by
-
- 1 copy in tags/Safari-610.4.3
Tag Safari-610.4.3.
- 4:57 PM Changeset in webkit [271045] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (iOS 14): Bad access crash in ShareableBitmap::makeCGImageCopy() under assignLegacyDataForContextMenuInteraction()
https://bugs.webkit.org/show_bug.cgi?id=219843
<rdar://problem/72537059>
Reviewed by Geoffrey Garen.
Apply a speculative fix for the crash by making the UI process robust in the case where the requested position
information has theisImageflag set, but no native image. Additionally, keep the existing debug assertions by
moving them outside of their current if statements.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView assignLegacyDataForContextMenuInteraction]):
(-[WKContentView continueContextMenuInteraction:]):
- 4:25 PM Changeset in webkit [271044] by
-
- 2 edits in trunk/JSTests
[JSC] Update elem.wast.js test
https://bugs.webkit.org/show_bug.cgi?id=220011
Reviewed by Ross Kirsling.
Now all tests pass. Remove FIXME.
- wasm/spec-tests/elem.wast.js:
- 3:50 PM Changeset in webkit [271043] by
-
- 49 edits11 moves2 adds2 deletes in trunk/LayoutTests
Remove non-inclusive language from layout tests
https://bugs.webkit.org/show_bug.cgi?id=220063
Reviewed by Geoffrey Garen.
This patch removes many instances of non-inclusive language from the layout tests.
- fast/canvas/webgl/oes-element-index-uint.html:
- fast/canvas/webgl/oes-vertex-array-object.html:
- fast/encoding/idn-security.html:
- fast/images/image-formats-support-expected.txt:
- fast/images/image-formats-support.html:
- fast/text/arabic-blacklisted-expected.html: Removed.
- fast/text/arabic-blacklisted.html: Removed.
- fast/text/arabic-blocked-fonts-expected.html: Copied from fast/text/arabic-blacklisted-expected.html.
- fast/text/arabic-blocked-fonts.html: Copied from fast/text/arabic-blacklisted.html.
- http/tests/appcache/online-whitelist-expected.txt:
- http/tests/appcache/online-whitelist.html:
- http/tests/appcache/resources/allowlist-wildcard.manifest: Copied from http/tests/appcache/resources/whitelist-wildcard.manifest.
- http/tests/appcache/resources/online-allowlist.manifest: Copied from http/tests/appcache/resources/online-whitelist.manifest.
- http/tests/appcache/resources/online-allowlist.php: Copied from http/tests/appcache/resources/online-whitelist.php.
- http/tests/appcache/resources/online-whitelist.manifest: Removed.
- http/tests/appcache/resources/online-whitelist.php: Removed.
- http/tests/appcache/resources/whitelist-wildcard.manifest: Removed.
- http/tests/appcache/whitelist-wildcard-expected.txt:
- http/tests/appcache/whitelist-wildcard.html:
- http/tests/misc/char-encoding-bocu-1-blacklisted-expected.txt: Removed.
- http/tests/misc/char-encoding-bocu-1-blacklisted.html: Removed.
- http/tests/misc/char-encoding-bocu-1-blocklisted-expected.txt: Added.
- http/tests/misc/char-encoding-bocu-1-blocklisted.html: Copied from http/tests/misc/char-encoding-bocu-1-blacklisted.html.
- http/tests/misc/char-encoding-scsu-blacklisted-expected.txt: Removed.
- http/tests/misc/char-encoding-scsu-blacklisted.html: Removed.
- http/tests/misc/char-encoding-scsu-blocklisted-expected.txt: Added.
- http/tests/misc/char-encoding-scsu-blocklisted.html: Copied from http/tests/misc/char-encoding-scsu-blacklisted.html.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html:
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- http/tests/security/cross-frame-access-enumeration.html:
- http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt:
- http/tests/security/isolatedWorld/cross-origin-xhr.html:
- http/tests/security/local-image-from-remote-allow-list-expected.txt:
- http/tests/security/local-image-from-remote-allow-list.html:
- http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers.html:
- http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple.html:
- http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html:
- http/tests/xmlhttprequest/origin-allow-list-all-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-all.html:
- http/tests/xmlhttprequest/origin-allow-list-exact-match-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-exact-match.html:
- http/tests/xmlhttprequest/origin-allow-list-https-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-https.html:
- http/tests/xmlhttprequest/origin-allow-list-ip-addresses-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains.html:
- http/tests/xmlhttprequest/origin-allow-list-ip-addresses.html:
- http/tests/xmlhttprequest/origin-allow-list-removal-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-removal.html:
- http/tests/xmlhttprequest/origin-allow-list-subdomains-expected.txt:
- http/tests/xmlhttprequest/origin-allow-list-subdomains.html:
- http/tests/xmlhttprequest/resources/origin-allowlisting-ip-address-test.html: Copied from http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html.
- http/tests/xmlhttprequest/resources/origin-whitelisting-ip-address-test.html: Removed.
- http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js:
(start):
- inspector/timeline/line-column.html:
- js/promises-tests/resources/mocha.js:
- media/track/captions-webvtt/allowlist.vtt: Copied from media/track/captions-webvtt/whitelist.vtt.
- media/track/captions-webvtt/whitelist.vtt: Removed.
- media/track/track-css-property-allowlist-expected.txt: Added.
- media/track/track-css-property-allowlist.html: Copied from media/track/track-css-property-whitelist.html.
- media/track/track-css-property-whitelist-expected.txt: Removed.
- media/track/track-css-property-whitelist.html: Removed.
- platform/glib/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wpe/security/block-test-expected.txt:
- security/block-test-expected.txt:
- security/block-test.html:
- 3:05 PM Changeset in webkit [271042] by
-
- 3 edits in trunk/Source/WebCore
[LFC][Integration] Reserve both the line and the run vector sizes
https://bugs.webkit.org/show_bug.cgi?id=220068
<rdar://problem/72560573>
Reviewed by Simon Fraser.
We actually know how many entries these vectors will have (in case of no-bidi content).
- layout/integration/LayoutIntegrationInlineContent.h:
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
- 2:31 PM Changeset in webkit [271041] by
-
- 14 edits in trunk/Source
Simplify CARingBuffer usage with SharedMemory storage
https://bugs.webkit.org/show_bug.cgi?id=220047
Reviewed by Geoff Garen.
Simplify CARingBuffer usage with SharedMemory storage:
- There are now 2 storage types:
- ReadOnlySharedRingBufferStorage: Used by the reader
- SharedRingBufferStorage: Used by the writer One type inherits the other. This allows the API to be a bit clearer and we can drop the m_readyOnly flag.
- Drop SharedRingBufferStorage::updateReadOnlyStorage() function. Instead, the reader can now construct a new ReadOnlySharedRingBufferStorage directly of the SharedMemory handle and pass it to the CARingBuffer constructor.
Source/WebCore:
- platform/audio/cocoa/CARingBuffer.cpp:
(WebCore::CARingBuffer::CARingBuffer):
- platform/audio/cocoa/CARingBuffer.h:
Source/WebKit:
- GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestination::audioSamplesStorageChanged):
(WebKit::RemoteAudioDestination::RemoteAudioDestination):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
(WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer):
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::RemoteMediaRecorder):
(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- Shared/Cocoa/SharedRingBufferStorage.cpp:
(WebKit::ReadOnlySharedRingBufferStorage::ReadOnlySharedRingBufferStorage):
(WebKit::ReadOnlySharedRingBufferStorage::data):
(WebKit::ReadOnlySharedRingBufferStorage::sharedFrameBounds const):
(WebKit::ReadOnlySharedRingBufferStorage::getCurrentFrameBounds):
(WebKit::ReadOnlySharedRingBufferStorage::flush):
(WebKit::ReadOnlySharedRingBufferStorage::updateFrameBounds):
(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::deallocate):
(WebKit::SharedRingBufferStorage::setCurrentFrameBounds):
- Shared/Cocoa/SharedRingBufferStorage.h:
(WebKit::ReadOnlySharedRingBufferStorage::storage const):
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:
(WebKit::m_ringBuffer):
(WebKit::SpeechRecognitionRemoteRealtimeMediaSource::setStorage):
- WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::setStorage):
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::RemoteAudio::RemoteAudio):
(WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):
- 1:59 PM Changeset in webkit [271040] by
-
- 3 edits in trunk/Source/WebKit
Retain IPC::Connection when using it when making a NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=220067
Patch by Alex Christensen <achristensen@webkit.org> on 2020-12-21
Reviewed by Geoffrey Garen.
r265230 helped, but it's still crashing.
Maybe we're getting a non-null pointer to an object that is about to be destroyed on another thread.
There's no reason not to keep it alive here.
Also, don't release assert in isParentProcessAFullWebBrowser if there's no audit token so we don't
just kick this can down the road.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
- 1:31 PM Changeset in webkit [271039] by
-
- 10 edits in trunk
Source/JavaScriptCore:
[JSC] Add minimum parameter to the WASM JS-API for Memory & Table.
https://bugs.webkit.org/show_bug.cgi?id=219600
Patch by Jessica Tallon <jtallon@igalia.com> on 2020-12-21
Reviewed by Yusuke Suzuki.
This patch adds a "minimum" perameter to the constructor of both WebAssembly.Memory and
WebAssembly.Table. This represents the same value as the "initial" perameter. The new
perameter name is outlined here [1]. It is part of the JS type reflection proposal.
[1]: https://github.com/WebAssembly/js-types/blob/master/proposals/js-types/Overview.md#naming-of-size-limits
- JSTests/wasm/js-api/table.js:
- JSTests/wasm/js-api/test_memory_constructor.js:
- Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp:
- Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:
LayoutTests:
[JSC] Fix expectation for WASM JS-type reflection WPTs
https://bugs.webkit.org/show_bug.cgi?id=219600
Patch by Jessica Tallon <jtallon@igalia.com> on 2020-12-21
Reviewed by Yusuke Suzuki.
Changed the expectations for the WASM JS-Type reflections constructor
tests as we now support the minimum parameter.
- LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/memory/constructor-types.tentative.any.worker-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor-types.tentative.any.worker-expected.txt:
- 12:48 PM Changeset in webkit [271038] by
-
- 9 edits in trunk/Source
Unreviewed, reverting r270939 and r270952.
Caused layout test timeouts on internal bots
Reverted changesets:
"[Cocoa] WebM format reader doesn't work with a url in a
<source> element"
https://bugs.webkit.org/show_bug.cgi?id=219961
https://trac.webkit.org/changeset/270939
"[Cocoa] WebM format reader doesn't work with a url in a
<source> element"
https://bugs.webkit.org/show_bug.cgi?id=219961
https://trac.webkit.org/changeset/270952
- 12:46 PM Changeset in webkit [271037] by
-
- 9 edits in trunk
$(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
https://bugs.webkit.org/show_bug.cgi?id=219993
rdar://72436093
Patch by Ryan Hostetler <rhost@apple.com> on 2020-12-21
Reviewed by Darin Adler.
Update SDKROOT evaluation to be lowercase and SDK filename only.
.:
- Source/Makefile:
Source/ThirdParty:
- Makefile:
Source/ThirdParty/libwebrtc:
- Makefile:
Tools:
- ImageDiff/Makefile:
- Makefile:
- 12:17 PM Changeset in webkit [271036] by
-
- 10 edits in trunk/Source
Many websites crash under toDataURL() when enabling GPU process for DOM
https://bugs.webkit.org/show_bug.cgi?id=220051
<rdar://problem/72412509>
Reviewed by Simon Fraser.
Source/WebCore:
See WebKit ChangeLog for more details.
- platform/graphics/ImageBufferBackend.h:
Add traits for the PreserveResolution enum flag, so that it can be encoded over IPC.
Source/WebKit:
Three methods of canvas readback (
toDataURL,toData, andtoBGRAData) currently cause the web content
process to crash when enabling GPU process for DOM rendering. This is because we attempt to call into the
respective methods on the image buffer backend following r270342, which unconditionally fire release assertions.
Instead of using the proxy image buffer backend object in the web process, we need to communicate with the
platformRemoteImageBufferin the GPU process. To do this, we add some plumbing through
RemoteRenderingBackendProxyandRemoteRenderingBackend, and override thetoDataURL,toData, and
toBGRADatamethods onRemoteImageBufferProxyin the web process to request data from the remote rendering
backend instead.
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getDataURLForImageBuffer):
(WebKit::RemoteRenderingBackend::getDataForImageBuffer):
(WebKit::RemoteRenderingBackend::getBGRADataForImageBuffer):
- GPUProcess/graphics/RemoteRenderingBackend.h:
- GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- Scripts/webkit/messages.py:
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::getImageData):
(WebKit::RemoteRenderingBackendProxy::getDataURLForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getDataForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::getBGRADataForImageBuffer):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- 11:56 AM Changeset in webkit [271035] by
-
- 1 copy in tags/Safari-611.1.9.3.1
Tag Safari-611.1.9.3.1.
- 11:54 AM Changeset in webkit [271034] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should make sure replacement watchpoint is fired before folding to PutByOffset
https://bugs.webkit.org/show_bug.cgi?id=220031
<rdar://72045350>
Reviewed by Saam Barati.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::presenceConditionIfConsistent):
(JSC::DFG::ByteCodeParser::checkPresence):
(JSC::DFG::ByteCodeParser::checkPresenceForReplace):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::presenceLike): Deleted.
(JSC::DFG::ByteCodeParser::checkPresenceLike): Deleted.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::tryFoldAsPutByOffset):
- runtime/Structure.cpp:
(JSC::Structure::dump const):
- 11:44 AM Changeset in webkit [271033] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.3.1
- 11:38 AM Changeset in webkit [271032] by
-
- 2 edits in trunk/Source/WebKit
Missing textInteractionEnabled key in WKPreferences initWithCoder looks like a false value.
https://bugs.webkit.org/show_bug.cgi?id=220061
<rdar://problem/72487342>
Reviewed by Wenson Hsieh.
We should check for the existence of the textInteractionEnabled key
in the NSCoder before updating the default value in WKPreferences,
otherwise a missing key will register as a false value when the default
of textInteractionEnabled should be true.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences initWithCoder:]):
- 11:35 AM Changeset in webkit [271031] by
-
- 11 edits in trunk/Source/WebKit
Check availability of speech recognition service before requesting permissions
https://bugs.webkit.org/show_bug.cgi?id=220033
Reviewed by Youenn Fablet.
If speech recognition service is not available for target language (maybe the language is not supported, user
turns off dictation in system settings, etc), let's just fail the speech recognition request without prompting.
Manually tested with MiniBrowser.
- UIProcess/Cocoa/MediaPermissionUtilities.mm:
(WebKit::requestSpeechRecognitionAccess):
(WebKit::checkSpeechRecognitionServiceAccess):
(WebKit::checkSpeechRecognitionServiceAvailability):
- UIProcess/MediaPermissionUtilities.h:
- UIProcess/SpeechRecognitionPermissionManager.cpp:
(WebKit::SpeechRecognitionPermissionManager::request):
(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest):
- UIProcess/SpeechRecognitionPermissionManager.h:
- UIProcess/SpeechRecognitionPermissionRequest.h:
(WebKit::SpeechRecognitionPermissionRequest::create):
(WebKit::SpeechRecognitionPermissionRequest::lang const):
(WebKit::SpeechRecognitionPermissionRequest::SpeechRecognitionPermissionRequest):
- UIProcess/SpeechRecognitionServer.cpp:
(WebKit::SpeechRecognitionServer::requestPermissionForRequest):
- UIProcess/SpeechRecognitionServer.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestSpeechRecognitionPermission):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createSpeechRecognitionServer):
- 11:24 AM Changeset in webkit [271030] by
-
- 5 edits in branches/safari-610-branch
Cherry-pick r270981. rdar://problem/72552976
2020-12-17 Mark Lam <mark.lam@apple.com>
Add tagging to JIT probe's return address.
https://bugs.webkit.org/show_bug.cgi?id=220008
rdar://71279530
Reviewed by Keith Miller and Robin Morisset.
- assembler/MacroAssemblerARM64.cpp:
- assembler/testmasm.cpp: (JSC::testProbeModifiesProgramCounter):
- runtime/JSCPtrTag.h:
- 10:48 AM Changeset in webkit [271029] by
-
- 2 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r270998. rdar://problem/72552852
Fix some issues with PDFs as <object>.
https://bugs.webkit.org/show_bug.cgi?id=220024
Reviewed by Tim Horton.
No new tests (Unable to write automated tests)
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::dataProviderGetBytesAtPositionCallback): (WebKit::PDFPlugin::getResourceBytesAtPosition): Set the correct URL. (WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData): Try harder to catch mismatches in delivered bytes vs expected bytes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:48 AM Changeset in webkit [271028] by
-
- 2 edits in branches/safari-610-branch/Source/JavaScriptCore
Cherry-pick r270993. rdar://problem/72552973
Build fix after r270988.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>
Not reviewed.
- JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:47 AM Changeset in webkit [271027] by
-
- 4 edits in branches/safari-610-branch/Source/JavaScriptCore
Cherry-pick r270988. rdar://problem/72552973
Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>
Reviewed by Saam Barati.
- assembler/AbstractMacroAssembler.h:
- assembler/DisallowMacroScratchRegisterUsage.h:
- templatized the DisallowMacroScratchRegisterUsage class so that we can #include it in MacroAssembler implementations.
- assembler/MacroAssemblerARM64E.h: (JSC::MacroAssemblerARM64E::validateUntaggedPtr):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:47 AM Changeset in webkit [271026] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r270580. rdar://problem/72552978
Multicolumn children becoming in-flow elements should be inserted into the multicolumn flow
https://bugs.webkit.org/show_bug.cgi?id=218503
Reviewed by Zalan Bujtas.
Out of flow children of a multicolumn container are not really part of the multicolumn flow. Making them in-flow (i.e. setting "position: static;")
should trigger the code that inserts them into the MultiColumnFlowThread object of the multicolumn container. RenderTreeBuilder was handling this
in-flow <-> out-of-flow changes just for the cases in which the inline status of an element was affecting the parent.
- rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::normalizeTreeAfterStyleChange): Insert renderer in the multicolumn flow thread whenever it becames in flow.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:32 AM Changeset in webkit [271025] by
-
- 2 edits in trunk/Source/WebCore
Copy Localizable.strings file into the correct directory
https://bugs.webkit.org/show_bug.cgi?id=220029
rdar://72167601
Reviewed by Alex Christensen.
After the changes in r269865, r269873, r269915, r269932, r269937 the localizable.strings
was not showing up in the right place in the production build to allow it to be correctly
localized. This skips the step of putting it in DerivedSources and just puts the
concatenated file in the final correct directory so we do not have to relay on Xcode build
doing the correct thing for us.
- WebCore.xcodeproj/project.pbxproj:
- 10:14 AM Changeset in webkit [271024] by
-
- 14 edits in trunk
[MSE] Fix allSamplesInTrackEnqueued() handling
https://bugs.webkit.org/show_bug.cgi?id=220055
Reviewed by Philippe Normand.
Source/WebCore:
Within the changes introduced by r270612 a spurious call to
allSamplesInTrackEnqueued() was added to provideMediaData().
provideMediaData() is called every time there may be new samples that
need to be enqueued into the playback pipeline.
allSamplesInTrackEnqueued() is supposed to be called when
MediaSource.endOfStream() has been called and all pending samples have
been enqueued, therefore signaling the playback pipeline that no more
samples will be added.
Some decoders need to be notified of this condition in order to move
the last samples in their queue downstream. This is true at least of
the avdec (ffmpeg) decoders that are commonly used in desktop versions
of the GStreamer port.
Calling allSamplesInTrackEnqueued() prematurely will mess with the
playback as the code will not accept any more samples, a serious
problem. This patch fixes it by removing the spurious call and
restoring its original purpose when it was introduced in r230909.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::openIfInEndedState):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::setMediaSourceEnded):
(WebCore::SourceBuffer::trySignalAllSamplesEnqueued): Deleted.
- Modules/mediasource/SourceBuffer.h:
- platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::setMediaSourceEnded):
(WebCore::SourceBufferPrivate::trySignalAllSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivate::provideMediaData):
- platform/graphics/SourceBufferPrivate.h:
Source/WebKit:
trySignalAllSamplesInTrackEnqueued() does not need to be exposed
outside of SourceBufferPrivate.
- GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::trySignalAllSamplesInTrackEnqueued): Deleted.
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::trySignalAllSamplesInTrackEnqueued): Deleted.
- WebProcess/GPU/media/SourceBufferPrivateRemote.h:
LayoutTests:
Adjusted test expectations.
- platform/glib/TestExpectations:
- 10:11 AM Changeset in webkit [271023] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed test gardening, rebaseline tests for Windows.
- platform/win/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
- platform/win/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/win/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- 9:54 AM Changeset in webkit [271022] by
-
- 2 edits in trunk/Tools
[Win][MiniBrowser] Update built-in User-Agent strings (December 2020)
https://bugs.webkit.org/show_bug.cgi?id=220048
Reviewed by Alex Christensen.
- MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::setUserAgent):
- 8:10 AM Changeset in webkit [271021] by
-
- 8 edits in trunk
REGRESSION (r262729): Poor contrast for specific color/background combinations on disabled input fields
https://bugs.webkit.org/show_bug.cgi?id=219991
<rdar://problem/70522921>
Reviewed by Sam Weinig.
Source/WebCore:
The text color for disabled input fields is adjusted based on any
specified color and background-color rules.
r262729 modified the adjustment logic to use the contrastRatio
utility function to determine illegibility issues due to contrast,
rather than a differenceSquared computation. In both cases if the
computed value is less than a minimum constrast value, the original
text color is preserved. As a part of the change, the minimum
contrast value was set to 1.1, a value chosen in order to maintain
the appearance of fast/forms/input-disabled-color.html.
However, the constrast value 1.1 results in combination of
"color #acacac" and "background-color: #f2f2f2" producing white
text on a light gray background, which is illegible. Previously,
this color combination did not result in any change to the text color.
In order to fix, increase the minimum color constrast to 1.195,
which accounts for the failing combination. Note that this increase to
the minimum value prevents some existing text color adjustments
from being performed. This is evidenced by the need to rebaseline
fast/forms/input-disabled-color.html after increasing the constrast.
However, the new text colors are subjectively more legible, which
is the reason why we have a minimum color constrast value.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::disabledTextColor const):
LayoutTests:
Updated an existing test to account for the failing color/background
combination and rebaselined expectations to match the new minimum
constrast ratio.
- fast/forms/input-disabled-color.html:
- platform/ios/fast/forms/input-disabled-color-expected.txt:
- platform/mac-catalina/fast/forms/input-disabled-color-expected.txt:
- platform/mac-mojave/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- 4:15 AM Changeset in webkit [271020] by
-
- 5 edits in trunk/LayoutTests
media-source-webm.html: Handle frame size in HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=220046
Reviewed by Eric Carlson.
The current version of media-source-webm.html assumes that a
resize
event happens after the first media segment is appended.
This is not necessarily true. In fact, an initialization segment
should cause a transition to HAVE_METADATA, and that per spec implies
the size of the video is known.
In practice, some implementations don't report this until a media
segment has arrived.
Because of the way the current code is written, an implementation
emittingresizeon HAVE_METADATA would timeout the test. This patch
fixes that, accomodating both cases.
- media/media-source/media-source-webm.html:
- media/media-source/media-source-webm-expected.txt:
- platform/glib/TestExpectations:
- platform/wpe/TestExpectations:
Dec 20, 2020:
- 8:07 PM Changeset in webkit [271019] by
-
- 4 edits in trunk/Source/WebCore
Rename FrameView::sendResizeEventIfNeeded() to scheduleResizeEventIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=220050
Reviewed by Ryosuke Niwa.
FrameView::sendResizeEventIfNeeded() only schedules events, it does not send them,
so rename accordingly.
Also fix some logging.
- dom/Document.cpp:
(WebCore::Document::runResizeSteps):
(WebCore::Document::runScrollSteps):
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scheduleResizeEventIfNeeded):
(WebCore::FrameView::setCustomSizeForResizeEvent):
(WebCore::FrameView::sendResizeEventIfNeeded): Deleted.
- page/FrameView.h:
- 6:23 PM Changeset in webkit [271018] by
-
- 2 edits in trunk/Tools
Fix the lldb WebCoreColorProvider
https://bugs.webkit.org/show_bug.cgi?id=220049
Reviewed by Sam Weinig.
Fix the lldb color provider after Color internals where shifted around.
- lldb/lldb_webkit.py:
(WebCoreColorProvider.to_string):
- 3:15 PM Changeset in webkit [271017] by
-
- 9 edits in trunk/Source
Unreviewed, reverting r270969.
Regressed MotionMark with GPUProcess enabled
Reverted changeset:
"[iOS] Stop leaking an XPC boost message to XPC services"
https://bugs.webkit.org/show_bug.cgi?id=219453
https://trac.webkit.org/changeset/270969
- 12:16 PM Changeset in webkit [271016] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed typo fix of r271015
https://bugs.webkit.org/show_bug.cgi?id=220000
<rdar://problem/72531245>
Reviewed by Kenneth Russell.
- platform/graphics/win/PlatformDisplayWin.cpp:
(WebCore::PlatformDisplayWin::initializeEGLDisplay): Fixed a typo 'attributs'.
- 12:09 PM Changeset in webkit [271015] by
-
- 5 edits1 add in trunk
[WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds
https://bugs.webkit.org/show_bug.cgi?id=220000
Reviewed by Kenneth Russell.
Source/WebCore:
Some WebGL tests were failing only in debug builds. Those test
cases expect black transparent for uninitialized buffers. ANGLE
enables debug layers as default only for debug builds. And it
fills uninitialized buffers with kDebugColorInitClearValue instead
of black transparent.
Create a PlatformDisplay with explicitly disabling debug layers by
using EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE.
- PlatformWinCairo.cmake:
- platform/graphics/win/PlatformDisplayWin.cpp: Added.
(WebCore::PlatformDisplayWin::initializeEGLDisplay):
- platform/graphics/win/PlatformDisplayWin.h:
LayoutTests:
- platform/wincairo/TestExpectations:
- 10:56 AM Changeset in webkit [271014] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Let's create the run and update the box geometry in one go for atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=220045
Reviewed by Antti Koivisto.
Let's not run the "same" loop twice on atomic inline level boxes (first when we create the line run and the second time we
we update the associated the box geometry). Unfortunately we still have to run a second pass on the inline boxes (e.g <span>) as
they behave as containers (there's room for improvement here too).
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::addInlineLevelBox):
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::hasInlineBox const):
- 8:29 AM Changeset in webkit [271013] by
-
- 14 edits in trunk/Source
Convert remaining FrameLoaderType enums to enum classes
https://bugs.webkit.org/show_bug.cgi?id=219898
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-20
Reviewed by Sam Weinig.
Source/WebCore:
Convert remaining FrameLoaderType enums to enum classes.
Not converted is ShouldReplaceDocumentIfJavaScriptURL
since it should be removed eventually.
- dom/Document.cpp:
(WebCore::Document::open):
- history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
(WebCore::firePageHideEventRecursively):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::isLoadingInAPISense const):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::initForSynthesizedDocument):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::activeDocumentLoader const):
(WebCore::FrameLoader::setState):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):
(WebCore::FrameLoader::shouldSuppressTextInputFromEditing const):
- loader/FrameLoader.h:
- loader/FrameLoaderTypes.h:
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::schedule):
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadSubframe):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- page/FrameView.cpp:
(WebCore::FrameView::shouldSuspendScrollAnimations const):
Source/WebKit:
Adapt to enum class changes.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetFrameLoadState):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
- 7:11 AM Changeset in webkit [271012] by
-
- 13 edits in trunk/Source/WebCore
[LFC] Move content height logic to the formatting contexts.
https://bugs.webkit.org/show_bug.cgi?id=220040
Reviewed by Simon Fraser.
Formatting contexts know about their content height.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedContentHeight const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::usedContentHeight const):
- layout/flexformatting/FlexFormattingContext.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::usedContentHeight const):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::usedContentHeight const):
- layout/tableformatting/TableFormattingContext.h:
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::cellHeigh const):
Dec 19, 2020:
- 11:15 PM Changeset in webkit [271011] by
-
- 17 edits in trunk/Source
Move FrameLoader::arePluginsEnabled to Frame
https://bugs.webkit.org/show_bug.cgi?id=220022
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-19
Reviewed by Sam Weinig.
Source/WebCore:
The arePluginsEnabled functionality is not tied
to FrameLoader, so move it to Frame to save
some indirections.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsEverNeeded):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::arePluginsEnabled): Deleted.
- loader/FrameLoader.h:
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::requestPlugin):
- page/Frame.cpp:
(WebCore::Frame::arePluginsEnabled):
- page/Frame.h:
Source/WebKit:
Adapt to API change.
- WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
(WebKit::WebPage::canShowMIMEType const):
Source/WebKitLegacy/mac:
Adapt to API change.
- WebCoreSupport/WebPluginInfoProvider.mm:
(WebPluginInfoProvider::pluginInfo):
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]):
Source/WebKitLegacy/win:
Adapt to API change.
- WebView.cpp:
(WebView::canShowMIMEType):
- 8:17 PM Changeset in webkit [271010] by
-
- 4 edits in trunk/Source/WebCore
[LFC][Integration] Remove redundant InlineContent::InlineBox
https://bugs.webkit.org/show_bug.cgi?id=220042
<rdar://problem/72511784>
Reviewed by Simon Fraser.
This is not used anymore since we've decided to turn everything into a run for integration.
- layout/integration/LayoutIntegrationInlineContent.h:
(WebCore::LayoutIntegration::InlineContent::shrinkToFit):
(WebCore::LayoutIntegration::InlineContent::InlineBox::InlineBox): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::layoutBox const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::lineIndex const): Deleted.
(WebCore::LayoutIntegration::InlineContent::InlineBox::rect const): Deleted.
- layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayInlineBoxes const): Deleted.
- layout/integration/LayoutIntegrationInlineContentBuilder.h:
- 4:11 PM Changeset in webkit [271009] by
-
- 1 copy in tags/Safari-611.1.9.3
Tag Safari-611.1.9.3.
- 4:10 PM Changeset in webkit [271008] by
-
- 1 copy in tags/Safari-611.1.9.2
Tag Safari-611.1.9.2.
- 4:06 PM Changeset in webkit [271007] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.3
- 4:05 PM Changeset in webkit [271006] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.2
- 4:03 PM Changeset in webkit [271005] by
-
- 2 edits in branches/safari-611.1.9-branch/Source/WebKit
Cherry-pick r271004. rdar://problem/72508138
REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>
Unreviewed build fix after r270575.
A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:55 PM Changeset in webkit [271004] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r270575): [iOS] Correct GPU Process sandbox syntax error
https://bugs.webkit.org/show_bug.cgi?id=220041
<rdar://problem/72508138>
Unreviewed build fix after r270575.
A closing parentheses was omitted when the 'play-audio' rule was changed to
remove its last rule.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
- 2:10 PM Changeset in webkit [271003] by
-
- 21 edits in trunk
width: max-content with box-sizing: border-box should leave space for padding (Twitter date hover overflow)
https://bugs.webkit.org/show_bug.cgi?id=219687
<rdar://problem/72137685>
Reviewed by Antti Koivisto.
Source/WebCore:
Non-quantitative values such as auto and min-content are not influenced by the box-sizing property.
See http::www.w3.org/TR/css-sizing-3/#box-sizing
(adjustContentBoxLogicalWidthFor* now needs the property type too)
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
- rendering/RenderBox.h:
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing const):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::computePreferredLogicalWidths):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeAutoRepeatTracksCount const):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
- rendering/RenderMenuList.cpp:
(RenderMenuList::computePreferredLogicalWidths):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::computePreferredLogicalWidths):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 5:16 AM Changeset in webkit [271002] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=219962
Reviewed by Antti Koivisto.
Let's estimate the logical top of simple atomic inline level boxes while they are being constructed. It helps to avoid the rather expensive
three-pass vertical alignment code (see computeLineBoxHeightAndAlignInlineLevelBoxesVertically) when the line has nothing but such simple boxes.
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically):
(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically): Deleted.
Dec 18, 2020:
- 9:41 PM Changeset in webkit [271001] by
-
- 2 edits in trunk/LayoutTests
[GPU process] Adding more tests to TestExpectations for Layout tests crashes
https://bugs.webkit.org/show_bug.cgi?id=220035
Patch by Rini Patel <rini_patel@apple.com> on 2020-12-18
Reviewed by Tim Horton.
- gpu-process/TestExpectations:
- 8:30 PM Changeset in webkit [271000] by
-
- 8 edits in trunk
iOS wheel events don't work on many websites
https://bugs.webkit.org/show_bug.cgi?id=220034
Reviewed by Simon Fraser.
Source/WebKit:
- Shared/ios/WebIOSEventFactory.h:
- Shared/ios/WebIOSEventFactory.mm:
(WebIOSEventFactory::createWebWheelEvent):
It turns out that many sites look at the legacy mousewheel event properties,
so compute wheelTicks in the same way that we do on macOS.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _scrollView:asynchronouslyHandleScrollEvent:completion:]):
If the UI process sends a wheel event with delta=0,0 to the Web Content
process, it will not be sent to the page, and thus not handled.
If this is the first event, it will prevent future events from
being cancelable.
Instead, synthetically defer the "Begin" phase to the first event in a
given gesture that has non-zero deltas, and just short-circuit any
zero-delta events entirely.
This way, WebCore can continue with its existing only-the-first-event-is-cancelable
logic, and we are assured that the first event that WebCore sees is also
the first event that the page sees, and is a Begin-phase event.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dispatchWheelEventWithoutScrolling):
wheelScrollGestureState isn't reset to nullopt until we send the
Begin-phase event to EventHandler, so we must make an exception for
the Begin-phase event, and explicitly make it cancelable. Otherwise,
the state of the previous gesture leaks into the new gesture. Existing
API tests caught this, I just apparently failed to run them after
adopting the shared wheelScrollGestureState().
Tools:
- TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(TEST):
Add a test ensuring that if the UIScrollPhaseBegin scroll event
has zero delta, that we let a subsequent UIScrollPhaseChanged event
with non-zero delta cancel the gesture's default action.
- 6:01 PM Changeset in webkit [270999] by
-
- 2 edits in trunk/Tools
Upgrade motionmark1.1.plan to r270959
https://bugs.webkit.org/show_bug.cgi?id=220016
Reviewed by Alexey Proskuryakov.
r270959 increases the warm-up time to 1000ms. This should fix a bi-
modality problem in the score of Images and Multiply sub-tests.
- Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
- 5:02 PM Changeset in webkit [270998] by
-
- 2 edits in trunk/Source/WebKit
Fix some issues with PDFs as <object>.
https://bugs.webkit.org/show_bug.cgi?id=220024
Reviewed by Tim Horton.
No new tests (Unable to write automated tests)
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::dataProviderGetBytesAtPositionCallback):
(WebKit::PDFPlugin::getResourceBytesAtPosition): Set the correct URL.
(WebKit::PDFPlugin::ByteRangeRequest::completeWithAccumulatedData): Try harder to catch mismatches in delivered bytes vs expected bytes.
- 4:39 PM Changeset in webkit [270997] by
-
- 3 edits in trunk/Source/WebKit
WKProcessPool enhancements for URL schemes
https://bugs.webkit.org/show_bug.cgi?id=220030
Reviewed by Brian Weinstein.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _registerURLSchemeAsSecure:]):
Added, equivalent to WKContextRegisterURLSchemeAsSecure().
(-[WKProcessPool _registerURLSchemeAsBypassingContentSecurityPolicy:]):
Added, equivalent to WKContextRegisterURLSchemeAsBypassingContentSecurityPolicy().
(-[WKProcessPool _setDomainRelaxationForbiddenForURLScheme:]):
Added, equivalent to WKContextSetDomainRelaxationForbiddenForURLScheme().
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- 4:16 PM Changeset in webkit [270996] by
-
- 4 edits in trunk/Source/WebKit
[Cocoa] Web Inspector: clean up _WKRemoteWebInspectorViewController
https://bugs.webkit.org/show_bug.cgi?id=219963
Reviewed by Devin Rousso.
Remove deprecated and unused debuggableType-based SPI to load the frontend.
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.h:
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h:
Promote the _WKInspectorDebuggableInfo-based SPI to the main header.
Fix availability annotations. This class has never worked on iOS.
Add TBA annotations for things added since the Big Sur SDK was finalized.
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(legacyDebuggableTypeToModernDebuggableType): Deleted.
(-[_WKRemoteWebInspectorViewController loadForDebuggableType:backendCommandsURL:]): Deleted.
- 4:11 PM Changeset in webkit [270995] by
-
- 2 edits in trunk/Source/WebCore
Login flows on sites with ITP quirks no longer work with ITP disabled
https://bugs.webkit.org/show_bug.cgi?id=220019
<rdar://problem/72472858>
Reviewed by Darin Adler.
We should add a check for ITP enabled before attempting to apply quirks,
otherwise the quirks will commandeer the login process, fail (because
no ITP), and thus result in an inability to login when ITP is disabled.
No new tests, this will fix login flows on sites with ITP quirks when
ITP is turned off. I confirmed these cases manually.
- page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
- 4:10 PM Changeset in webkit [270994] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r270983. rdar://problem/72484021
Crash in DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=219804
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-12-18
Reviewed by Darin Adler.
Add a check in HTMLTextFormControlElement::setSelectionRange()
that ensures we do not try to move the frame's selection
if the HTMLTextFormControlElement is no longer connected.
- html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:59 PM Changeset in webkit [270993] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix after r270988.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>
Not reviewed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 3:45 PM Changeset in webkit [270992] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(iOS 14): http/tests/cache-storage/page-cache-domcache-pending-promise.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217408
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations: Add DumpJSConsoleLogInStdErr since it was errantly removed in r268078.
- 3:14 PM Changeset in webkit [270991] by
-
- 2 edits in trunk/Source/JavaScriptCore
CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
https://bugs.webkit.org/show_bug.cgi?id=219953
<rdar://problem/72391255>
Reviewed by Tadeu Zagallo.
- runtime/CachedTypes.cpp:
(JSC::CachedRefPtr::decode const):
- 2:27 PM Changeset in webkit [270990] by
-
- 2 edits in trunk/Source/WebCore
Line snapping fails when the content is taller than the page.
https://bugs.webkit.org/show_bug.cgi?id=220020
<rdar://problem/68761119>
Reviewed by Antti Koivisto.
When the snapped position of the current line falls off of the page, we call lineSnapAdjustment() recursively to figure out the snapped position on the next page.
We usually find the final position on the next page mostly slightly below the logical top.
However when the line is taller than the page itself, it does not fit the next page or any of the following pages (assuming uniform page height).
Let the line overflow when the pages can't accommodate it.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSnapAdjustment const):
- 2:17 PM Changeset in webkit [270989] by
-
- 2 edits in trunk/Source/WebCore
Use EGL_PLATFORM_ANGLE_TYPE_METAL_ANGLE now it is in the build
https://bugs.webkit.org/show_bug.cgi?id=219968
<rdar://problem/72405724>
Reviewed by Darin Adler.
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::InitializeEGLDisplay): Use the named value.
- 1:42 PM Changeset in webkit [270988] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix MacroAssemblerARM64E::validateUntaggedPtr() to account for TBI.
https://bugs.webkit.org/show_bug.cgi?id=220021
<rdar://problem/72474809>
Reviewed by Saam Barati.
- assembler/AbstractMacroAssembler.h:
- assembler/DisallowMacroScratchRegisterUsage.h:
- templatized the DisallowMacroScratchRegisterUsage class so that we can #include it in MacroAssembler implementations.
- assembler/MacroAssemblerARM64E.h:
(JSC::MacroAssemblerARM64E::validateUntaggedPtr):
- 1:10 PM Changeset in webkit [270987] by
-
- 11 edits in trunk
[Media in GPU Process][MSE] SourceBufferPrivateRemote needs to override some track buffer related functions of SourceBufferPrivate
https://bugs.webkit.org/show_bug.cgi?id=219998
Reviewed by Jer Noble.
Source/WebCore:
No new tests, fix layout test failures.
- platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::setTimestampOffset):
(WebCore::SourceBufferPrivate::setAppendWindowStart):
(WebCore::SourceBufferPrivate::setAppendWindowEnd):
(WebCore::SourceBufferPrivate::hasVideo const):
(WebCore::SourceBufferPrivate::timestampOffset const):
Change these functions to virtual becauseSourceBufferPrivateRemoteneeds to override them.
Source/WebKit:
Implement some track buffer related functions of
SourceBufferPrivateRemotewith new IPC messages.
- GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::resetTrackBuffers):
(WebKit::RemoteSourceBufferProxy::clearTrackBuffers):
(WebKit::RemoteSourceBufferProxy::resetTimestampOffsetInTrackBuffers):
(WebKit::RemoteSourceBufferProxy::setTimestampOffset):
(WebKit::RemoteSourceBufferProxy::setAppendWindowStart):
(WebKit::RemoteSourceBufferProxy::setAppendWindowEnd):
(WebKit::RemoteSourceBufferProxy::updateTrackIds):
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::addRemoteAudioTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteTextTrack):
(WebKit::MediaPlayerPrivateRemote::addRemoteVideoTrack):
MediaSourcemanages the track information for the MSE media player, so we should not call
MediaPlayer::addAudioTrack(),MediaPlayer::addTextTrack()andMediaPlayer::addVideoTrack().
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::resetTrackBuffers):
(WebKit::SourceBufferPrivateRemote::clearTrackBuffers):
(WebKit::SourceBufferPrivateRemote::resetTimestampOffsetInTrackBuffers):
(WebKit::SourceBufferPrivateRemote::setTimestampOffset):
(WebKit::SourceBufferPrivateRemote::setAppendWindowStart):
(WebKit::SourceBufferPrivateRemote::setAppendWindowEnd):
(WebKit::SourceBufferPrivateRemote::updateTrackIds):
- WebProcess/GPU/media/SourceBufferPrivateRemote.h:
LayoutTests:
- gpu-process/TestExpectations:
- 12:32 PM Changeset in webkit [270986] by
-
- 9 edits in trunk/Source
SpeechRecognitionRemoteRealtimeMediaSourceManager should not issue sandbox extension for mocked devices
https://bugs.webkit.org/show_bug.cgi?id=219972
Reviewed by Eric Carlson.
Source/WebCore:
- platform/mediastream/CaptureDevice.h:
(WebCore::CaptureDevice::isMockDevice const): Add a member in CaptureDevice to indicate if it's mocked device.
(WebCore::CaptureDevice::setIsMockDevice):
(WebCore::CaptureDevice::encode const):
(WebCore::CaptureDevice::decode):
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::toCaptureDevice):
Source/WebKit:
- UIProcess/SpeechRecognitionPermissionManager.cpp:
(WebKit::SpeechRecognitionPermissionManager::startProcessingRequest): We need to sync the preference not only
on when mockCaptureDevicesEnabled is set, but also when it is unset.
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp:
(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::addSource): Grant sandbox extensions to web process
when the first source that uses a real device is created.
(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::removeSource): Revoke sandbox extensions from web
process when the last source that uses a real device is delete.
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.h:
- UIProcess/SpeechRecognitionServer.cpp: Correct a typo.
(WebKit::SpeechRecognitionServer::SpeechRecognitionServer):
- UIProcess/SpeechRecognitionServer.h: Correct a typo
- 11:43 AM Changeset in webkit [270985] by
-
- 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc
Cherry-pick r270895. rdar://problem/72474836
Cherry-pick usrsctp 355fb576b1a9dfef70fc0e158d66692662baaddc
https://bugs.webkit.org/show_bug.cgi?id=219937
Reviewed by Alex Christensen.
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c: (sctp_process_cookie_existing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:42 AM Changeset in webkit [270984] by
-
- 2 edits in branches/safari-610-branch/Source/ThirdParty/libwebrtc
Cherry-pick r270894. rdar://problem/72474831
Cherry-pick usrsctp 7dab23aa0d8db86fedd222a308067439b03fad0f
https://bugs.webkit.org/show_bug.cgi?id=219936
<rdar://problem/72304588>
Reviewed by Alex Christensen.
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c: (sctp_process_cookie_existing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:34 AM Changeset in webkit [270983] by
-
- 2 edits in trunk/Source/WebCore
Crash in DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=219804
Patch by Julian Gonzalez <julian_a_gonzalez@apple.com> on 2020-12-18
Reviewed by Darin Adler.
Add a check in HTMLTextFormControlElement::setSelectionRange()
that ensures we do not try to move the frame's selection
if the HTMLTextFormControlElement is no longer connected.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- 11:32 AM Changeset in webkit [270982] by
-
- 1 copy in tags/Safari-611.1.9.1.1
Tag Safari-611.1.9.1.1.
- 11:25 AM Changeset in webkit [270981] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add tagging to JIT probe's return address.
https://bugs.webkit.org/show_bug.cgi?id=220008
rdar://71279530
Reviewed by Keith Miller and Robin Morisset.
- assembler/MacroAssemblerARM64.cpp:
- assembler/testmasm.cpp:
(JSC::testProbeModifiesProgramCounter):
- runtime/JSCPtrTag.h:
- 11:16 AM Changeset in webkit [270980] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r270938): ASSERTION FAILED: !m_renderThread in WebKit::RemoteAudioDestinationProxy::startRenderingThread
https://bugs.webkit.org/show_bug.cgi?id=220017
<rdar://problem/72470176>
Reviewed by Darin Adler.
In case of a GPU process crash, we call stopRenderingThread() and then connectToGPUProcess() which
calls startRenderingThread(). We were hitting an assertion in startRenderingThread() making sure
that m_renderThread is null because stopRenderingThread() was failing to set it to null after
stopping the thread.
No new tests, covered by existing failing API test.
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::stopRenderingThread):
- 11:11 AM Changeset in webkit [270979] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.1.1
- 11:05 AM Changeset in webkit [270978] by
-
- 1 copy in tags/Safari-611.1.9.1
Tag Safari-611.1.9.1.
- 11:02 AM Changeset in webkit [270977] by
-
- 4 edits in branches/safari-611.1.9-branch
Cherry-pick r270962. rdar://problem/72472070
REGRESSION(r270638) decidePolicyForNewWindowAction should have non-null request
https://bugs.webkit.org/show_bug.cgi?id=220001
Source/WebKit:
<rdar://72436824>
Reviewed by Tim Horton.
A ResourceRequest was used after being moved in the super old C SPI that we need to remove,
but to keep our client functioning correctly until they do we copy the ResourceRequest instead of moving it.
Covered by an API test.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNewWindowAction):
Tools:
Reviewed by Tim Horton.
- TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:30 AM Changeset in webkit [270976] by
-
- 1 copy in tags/Safari-611.1.9.0.1
Tag Safari-611.1.9.0.1.
- 10:27 AM Changeset in webkit [270975] by
-
- 1 delete in tags/Safari-611.1.9.0.1
Delete tag.
- 10:25 AM Changeset in webkit [270974] by
-
- 24 edits in trunk/Source
Gate all of the code associated with app highlights
https://bugs.webkit.org/show_bug.cgi?id=220003
Source/WebCore:
<rdar://problem/72451893>
Reviewed by Tim Horton.
Only gating code, no new tests needed.
- Modules/highlight/AppHighlightListData.cpp:
- Modules/highlight/AppHighlightListData.h:
- Modules/highlight/AppHighlightStorage.cpp:
- Modules/highlight/AppHighlightStorage.h:
- Modules/highlight/HighlightRegister.cpp:
- Modules/highlight/HighlightRegister.h:
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::updateHighlightPositions):
- dom/Document.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
- platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/cocoa/LocalizedStringsCocoa.mm:
- rendering/RenderTheme.h:
Source/WebKit:
<rdar://problem/72451893>
Reviewed by Tim Horton.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultAppHighlightsEnabled):
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
Source/WebKitLegacy/mac:
<rdar://problem/72451893>
Reviewed by Tim Horton.
- WebView/WebHTMLView.mm:
(toTag):
Source/WTF:
Reviewed by Tim Horton.
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 10:23 AM Changeset in webkit [270973] by
-
- 2 edits in trunk/LayoutTests
[Mojave] webanimations/accelerated-transform-related-animation-property-order.html is failing
https://bugs.webkit.org/show_bug.cgi?id=220018
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Mark test as failing.
- 10:23 AM Changeset in webkit [270972] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.1
- 10:21 AM Changeset in webkit [270971] by
-
- 1 copy in tags/Safari-611.1.9.0.1
Tag Safari-611.1.9.0.1.
- 10:11 AM Changeset in webkit [270970] by
-
- 8 edits in branches/safari-611.1.9-branch/Source
Versioning.
WebKit-7611.1.9.0.1
- 9:23 AM Changeset in webkit [270969] by
-
- 9 edits in trunk/Source
[iOS] Stop leaking an XPC boost message to XPC services
https://bugs.webkit.org/show_bug.cgi?id=219453
Reviewed by Geoff Garen.
Source/WebKit:
Stop leaking an XPC boost message to XPC services on builds where RunningBoard is able to give the right
priorities to our XPC services based on the type of RunningBoard assertion is being held. There is no
behavior change for the Network/WebContent processes since those were blocklisted in RunningBoard (Turning
on the RB_full_manage_WK_jetsam feature flag gives us the default RunningBoard behavior without
blocklisting). However, this allows the new GPUProcess to move to IDLE jetsam band when homing out of
MobileSafari, which makes the GPUProcess eligible for the freezer. Previously, the leaked boost message
would keep the GPUProcess in a higher jetsam band.
- FeatureFlags/WebKit.plist:
Add RB_full_manage_WK_jetsam feature flag and turn it on. On recent enough builds of RunningBoard, this
disables the blocklisting of the WebContent/Network processes in RunningBoard so that RunningBoard can now
set the priority of those processes (instead of us boosting our priority via boost messages).
- GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-iOS.plist:
- NetworkProcess/EntryPoint/Cocoa/XPCService/NetworkService/Info-iOS.plist:
- WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist:
- WebProcess/EntryPoint/Cocoa/XPCService/WebContentService/Info-iOS.plist:
Set _ProcessType=App so that RunningBoard is able to set the priority of our XPC services on iOS. Without
this change, we get a permission denied when RunningBoard attempts to set the priority of our XPC services.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::shouldLeakBoost):
Stop leaking a boost message on iOS when RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT compile-time flag is enabled
and when the RB_full_manage_WK_jetsam feature flag is enabled.
Source/WTF:
Add new RUNNINGBOARD_WEBKIT_PRIORITY_SUPPORT build time flag since we need a recent
enough build of RunningBoard to do this.
- wtf/PlatformHave.h:
- 5:29 AM Changeset in webkit [270968] by
-
- 2 edits in trunk/Source/WebCore
[WPE] Unreviewed buildfix after r270964
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
- 2:27 AM Changeset in webkit [270967] by
-
- 6 edits in trunk/Source
[CSSJIT] Do not use trampoline if JITCage is disabled
https://bugs.webkit.org/show_bug.cgi?id=220004
Reviewed by Tadeu Zagallo.
Source/JavaScriptCore:
- llint/LLIntData.cpp:
- llint/LowLevelInterpreter.asm:
Source/WebCore:
This trampoline is not necessary if JITCage is not enabled.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateReturn):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
- cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::ruleCollectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::querySelectorSimpleSelectorChecker):
(WebCore::SelectorCompiler::ruleCollectorSelectorCheckerWithCheckingContext):
(WebCore::SelectorCompiler::querySelectorSelectorCheckerWithCheckingContext):
- 2:09 AM Changeset in webkit [270966] by
-
- 2 edits4 adds in trunk/JSTests
[WASM-References] Add reference spec tests for table instructions
https://bugs.webkit.org/show_bug.cgi?id=220005
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-18
Reviewed by Yusuke Suzuki.
These are reference types spec tests that we've already supported.
It help us prevent future inconsistencies with the proposal:
https://github.com/WebAssembly/reference-types/tree/master/test/core
- wasm.yaml:
- wasm/references-spec-tests/table-sub.wast.js: Added.
- wasm/references-spec-tests/table_get.wast.js: Added.
- wasm/references-spec-tests/table_set.wast.js: Added.
- wasm/references-spec-tests/table_size.wast.js: Added.
- 1:59 AM Changeset in webkit [270965] by
-
- 2 edits in trunk/Source/JavaScriptCore
[WASM-References] Reuse instance initElementSegment to reduce duplication
https://bugs.webkit.org/show_bug.cgi?id=220007
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-18
Reviewed by Yusuke Suzuki.
Simple refactroing. We need only one place to initialize elements
segments.
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::evaluate):
Dec 17, 2020:
- 11:05 PM Changeset in webkit [270964] by
-
- 28 edits in trunk/Source
REGRESSION (r268386): Snapshots of WebGL content in the tab picker don't work (black map on Google Maps)
https://bugs.webkit.org/show_bug.cgi?id=219946
<rdar://problem/72013784>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2020-12-17
Reviewed by Dean Jackson.
Source/WebCore:
Fix case where WebGL would first be displayed with hardware code path
and then displayed with software code path (painting from the paint
tree). Former happens when user looks at the page and latter happens
when printing or when Safari takes a snapshot.
This is not a real regression of r268386. Prior to that, the software
display would have used uninitialized IOSurface contents or contents of
1-2 frames prior and would leave the hardware display buffer not
updated.
CanvasRenderingContext::paintRenderingResultsToCanvas() is used for two
purposes:
1) Image extraction uses, such as toData() or
constructing an Image out of the contents.
2) Painting the rendering to the document during software display.
The 1) case uses always the drawing buffer.
The 2) case presents the drawing buffer as the new display buffer if
there are changes to the drawing buffer and uses the potentially new
display buffer to display.
For 2D canvas, these two cases are the same case. For WebGL they are
different.
The display is destructive for WebGL drawing buffer when
preserveDrawingBuffer == false. This means that if hardware display has
happened, we must read the display buffer during case 2. This code was
missing, so the scenario could not have ever worked.
The previous code tried to workaround this by the
WebGLGraphicsContextBase to detect what the owner intended with the
paintRenderingResultsToCanvas, then skip the potential drawing buffer
clear, read the drawing buffer and put that data to the "presentation
copy" of the HTMLElement. This is not ok, as the uncleared drawing
buffer has non-deterministic contents in case the context has displayed
and the client has not drawn new content to the drawing buffer.
Fix by removing the "presentation copy" of the HTMLCanvas. The
presentation image can always be drawn to the CanvasBase::buffer():
- The current contents of the buffer is the presentation image if the context has not changed since updating the buffer with either drawing buffer or previous display buffer.
- If the context has changed, we must present and put the new display buffer to the CanvasBase::buffer()
- This is also correct contents for the potential next image extraction uses, up to a point when context changes.
- If the context changes before an image extraction use, CanvasBase::buffer() is updated with the normal logic, the same as what happens when CanvasBase::buffer() is updated between two image extraction uses.
Prior to this, there was an unneeded and incorrectly implemented
GPUCanvasContext::markLayerComposited(). The sequence would be:
HTMLCanvasElement::paint():
canvasContext().paintRenderingResultsToCanvas(buffer());
context().drawImageBuffer(buffer());
canvasContext().markLayerComposited();
The markLayerComposited() would incorrectly mark the WebGL context compositing
being done, but there was no compositing actually happening. The GPU-side
display buffer would be incorrect. Also, there is nothing to be done at
this stage, as the compositing of WebGL context itself is already
finished at WebGL context paintRenderingResultsToCanvas() return.
Instead, add CanvasRenderingContext::prepareForDisplayWithPaint() which signals that next
paintRenderingResultsToCanvas() is a display operation. This can be used to to detect the
paintRenderingResultsToCanvas() in which we must present the drawing buffer as
display buffer.
Implement the display buffer read with OpenGL.
Refactor the drawing buffer read code to be able to reuse the read code
for the display buffer read. The refactored code reduces redundant the
allocations of full-screen malloc buffers and ensures allocation results are
checked instead of crashing with nullptr derefs when OOM happens. Fixes
errors such as rdar://67553531 (CrashTracer: com.apple.WebKit.WebContent at
WebCore: WebCore::GraphicsContextGLOpenGL::paintRenderingResultsToCanvas).
Removes RGBA->BGRA->RGBA conversions from
GraphicsContextGLOpenGL::paintRenderingResultsToImageData().
Removes manual alpha premultiplication and makes CG draw with unpremultiplied
alpha.
Changes Cairo variant of GraphicsContextGLOpenGL to convert manually RGBA->BGRA
instead of (big) OpenGL driver doing it in case of non-NVIDIA platforms.
No new tests, the snapshot / sw+hw drawing is not testable at the moment.
- Modules/webgpu/GPUCanvasContext.cpp:
(WebCore::GPUCanvasContext::configureSwapChain):
(WebCore::GPUCanvasContext::prepareForDisplayWithPaint):
(WebCore::GPUCanvasContext::paintRenderingResultsToCanvas):
- Modules/webgpu/GPUCanvasContext.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::prepareForDisplayWithPaint):
- html/canvas/GPUBasedCanvasRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::prepareForDisplayWithPaint):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContextBase::validateElementArraySize):
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawElements):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
(WebCore::WebGLRenderingContextBase::initVertexAttrib0):
- html/canvas/WebGLRenderingContextBase.h:
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:
- platform/graphics/RemoteGraphicsContextGLProxyBase.h:
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::readPixelsForPaintResults):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::getProgramInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
- platform/graphics/angle/GraphicsContextGLANGLEUtilities.h:
(WebCore::ScopedRestoreTextureBinding::ScopedRestoreTextureBinding):
(WebCore::ScopedBufferBinding::ScopedBufferBinding):
(WebCore::ScopedBufferBinding::~ScopedBufferBinding):
(WebCore::ScopedBufferBinding::query):
(WebCore::ScopedRestoreReadFramebufferBinding::ScopedRestoreReadFramebufferBinding):
(WebCore::ScopedRestoreReadFramebufferBinding::markBindingChanged):
(WebCore::ScopedRestoreReadFramebufferBinding::bindFramebuffer):
(WebCore::ScopedRestoreReadFramebufferBinding::~ScopedRestoreReadFramebufferBinding):
(WebCore::ScopedPixelStorageMode::ScopedPixelStorageMode):
(WebCore::ScopedPixelStorageMode::~ScopedPixelStorageMode):
(WebCore::ScopedPixelStorageMode::pixelStore):
(WebCore::ScopedPixelStorageMode::operator GLint const):
(WebCore::ScopedTexture::ScopedTexture):
(WebCore::ScopedTexture::~ScopedTexture):
(WebCore::ScopedTexture::operator GLuint const):
(WebCore::ScopedFramebuffer::ScopedFramebuffer):
(WebCore::ScopedFramebuffer::~ScopedFramebuffer):
(WebCore::ScopedFramebuffer::operator GLuint const):
- platform/graphics/cairo/GraphicsContextGLCairo.cpp:
(WebCore::GraphicsContextGLOpenGL::paintToCanvas):
- platform/graphics/cg/GraphicsContextGLCG.cpp:
(WebCore::releaseImageData):
(WebCore::GraphicsContextGLOpenGL::paintToCanvas):
- platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.h:
- platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:
(WebCore::GraphicsContextGLOpenGL::allowOfflineRenderers const):
(WebCore::GraphicsContextGLOpenGL::readCompositedResults):
- platform/graphics/cocoa/WebGLLayer.mm:
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::paintRenderingResultsToCanvas):
(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToCanvas):
(WebCore::GraphicsContextGLOpenGL::paintRenderingResultsToImageData):
(WebCore::GraphicsContextGLOpenGL::readCompositedResults):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::readPixelsForPaintResults):
- platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::reshape):
(WebCore::GraphicsContextGLOpenGL::blendFunc):
(WebCore::GraphicsContextGLOpenGL::compileShader):
(WebCore::GraphicsContextGLOpenGL::getActiveAttribImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveAttrib):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformImpl):
(WebCore::GraphicsContextGLOpenGL::getActiveUniform):
(WebCore::GraphicsContextGLOpenGL::originalSymbolName):
(WebCore::GraphicsContextGLOpenGL::mappedSymbolName):
(WebCore::GraphicsContextGLOpenGL::deleteVertexArray):
(WebCore::GraphicsContextGLOpenGL::isVertexArray):
(WebCore::GraphicsContextGLOpenGL::getNonBuiltInActiveSymbolCount):
(WebCore::GraphicsContextGLOpenGL::getUnmangledInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderi):
(WebCore::GraphicsContextGLOpenGL::getShaderInfoLog):
(WebCore::GraphicsContextGLOpenGL::getShaderSource):
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp:
(WebCore::GraphicsContextGLOpenGL::readPixelsForPaintResults):
Source/WebKit:
Add dummy implementations of GraphicsContextGL::paintCompositedResultsToCanvas.
Painting to canvas is not implemented yet for the remote GraphicsContextGL implementation.
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGLCocoa::displayBuffer const):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToCanvas):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- 8:45 PM Changeset in webkit [270963] by
-
- 6 edits in trunk/Tools
REGRESSION: [ BigSur ] 3 PictureInPicture related API tests timing out
https://bugs.webkit.org/show_bug.cgi?id=219999
Reviewed by Eric Carlson.
Not a fix for the timeout itself, but a change which will allow us to see the Util::run() statement which
is timing out. Rather than just get a generic TIMEOUT result with no clue to the cause, a Util::run() statement
which takes longer than the specified amount of time will generate an ASSERT() error with the line number
which caused the timeout.
- TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
(TEST):
- TestWebKitAPI/Utilities.h:
- TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
(TestWebKitAPI::Util::runFor):
- 7:24 PM Changeset in webkit [270962] by
-
- 4 edits in trunk
REGRESSION(r270638) decidePolicyForNewWindowAction should have non-null request
https://bugs.webkit.org/show_bug.cgi?id=220001
Source/WebKit:
<rdar://72436824>
Reviewed by Tim Horton.
A ResourceRequest was used after being moved in the super old C SPI that we need to remove,
but to keep our client functioning correctly until they do we copy the ResourceRequest instead of moving it.
Covered by an API test.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
Tools:
Reviewed by Tim Horton.
- TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
(TEST):
- 5:21 PM Changeset in webkit [270961] by
-
- 23 edits in trunk/Source
[GPUProcess] https://www.waveplayer.info/createmediaelementsource-test/ demo is flaky
https://bugs.webkit.org/show_bug.cgi?id=219951
Reviewed by Geoff Garen.
The issue was with the following line in AudioSourceProviderAVFObjC::prepare:
m_ringBuffer = m_ringBufferCallback(description, capacity).moveToUniquePtr();
In the case where m_ringBuffer was non-null before the assignment, we would have
2 RingBuffers that would coexist for a very small period of time. When the new
one was created, we would send an IPC to the remote process with the shared
memory handle of the new RingBuffer. However, very shortly after, the old
ring buffer would get destroyed, causing us to send another IPC to the remote
process with a null handle (since the shared memory associated with the old
ring buffer is getting destroyed). As a result, of this ordering issue, the
remote process would end up with a RingBuffer with a null shared memory handle
and no audio would be rendered.
We could have addressed the issue like so:
`
m_ringBuffer = nullptr;
m_ringBuffer = m_ringBufferCallback(description, capacity).moveToUniquePtr();
`
However, this would be super fragile. Instead, I have made the following changes:
- If there is already a ringBuffer, reuse it instead of reconstructing it. Calling allocate() with the new parameters on the existing ring buffer is sufficient in this case.
- Because of 1, the ring buffer creation callback no longer needs to call CARingBuffer::allocate().
I also made the following changes to make the code simpler and to reduce code
duplication:
- The storage change handler passed to SharedRingBufferStorage is now given as parameter the CAAudioStreamDescription & frameCount. What the handler always does is send an IPC to the remote process to tell it that the storage changed and in all cases, it needs to provide these 2 parameters as well. This is because the remote process will need to call CARingBuffer::allocate(), which requires those 2 parameters. This simplifies our code in some cases since we no longer need a mechanism to retrieve those 2 parameters from inside the storage change handler.
- The logic of the StorageChange IPC recipient to update its ringbuffer with the new shared memory handle is complicated and was duplicated in a LOT of places. To address this, I introduced a new SharedRingBufferStorage::updateReadOnlyStorage() function which does exactly what we need.
Source/WebCore:
- platform/audio/cocoa/CARingBuffer.cpp:
(WebCore::CARingBuffer::allocate):
- platform/audio/cocoa/CARingBuffer.h:
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::AudioSourceProviderAVFObjC):
(WebCore::AudioSourceProviderAVFObjC::prepare):
(WebCore::AudioSourceProviderAVFObjC::setRingBufferCreationCallback):
Source/WebKit:
- GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestination::audioSamplesStorageChanged):
- GPUProcess/media/RemoteAudioSourceProviderProxy.cpp:
(WebKit::RemoteAudioSourceProviderProxy::create):
(WebKit::RemoteAudioSourceProviderProxy::createRingBuffer):
(WebKit::RemoteAudioSourceProviderProxy::storageChanged):
- GPUProcess/media/RemoteAudioSourceProviderProxy.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
(WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged):
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::audioSamplesStorageChanged):
- Shared/Cocoa/SharedRingBufferStorage.cpp:
(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::updateReadOnlyStorage):
(WebKit::SharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::deallocate):
- Shared/Cocoa/SharedRingBufferStorage.h:
(WebKit::SharedRingBufferStorage::SharedRingBufferStorage):
(WebKit::SharedRingBufferStorage::storage const):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::storageChanged):
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:
(WebKit::SpeechRecognitionRemoteRealtimeMediaSource::setStorage):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::storageChanged):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
- WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:
(WebKit::RemoteAudioSourceProviderManager::RemoteAudio::setStorage):
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.cpp:
(WebKit::AudioMediaStreamTrackRenderer::AudioMediaStreamTrackRenderer):
(WebKit::AudioMediaStreamTrackRenderer::storageChanged):
- WebProcess/GPU/webrtc/AudioMediaStreamTrackRenderer.h:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::startRecording):
(WebKit::MediaRecorderPrivate::storageChanged):
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::RemoteAudio::setStorage):
- 3:47 PM Changeset in webkit [270960] by
-
- 2 edits in trunk/LayoutTests
[ Big Sur ] imported/w3c/web-platform-tests/fetch/content-type/script.window.html is failing
https://bugs.webkit.org/show_bug.cgi?id=219965
unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:43 PM Changeset in webkit [270959] by
-
- 3 edits in trunk/PerformanceTests
[MotionMark] Increase the warm-up time for each sub-test from 100ms to 1000ms
https://bugs.webkit.org/show_bug.cgi?id=219984
Reviewed by Jon Lee.
Ensure the warm-up time is enough for the system to finish any initialization
work which may be triggered by the sub-test before starting the sampling.
This should prevent bi-modality in the score of the sub-tests since the
initial frame rate is crucial in deciding how much the complexity can grow.
- MotionMark/developer.html:
- MotionMark/resources/runner/motionmark.js:
(this.clear):
- 3:34 PM Changeset in webkit [270958] by
-
- 6 edits in trunk/Source/WebCore
[LFC][IFC] Reserve vector capacity for inline runs and line boxes
https://bugs.webkit.org/show_bug.cgi?id=219985
Reviewed by Simon Fraser.
...and some of the predefined vector capacities got lost at r267325.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::build):
- layout/inlineformatting/InlineFormattingState.h:
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineLevelBox::InlineLevelBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_isConsideredEmpty):
- layout/inlineformatting/InlineLineBox.h:
- 3:31 PM Changeset in webkit [270957] by
-
- 1 copy in tags/Safari-611.1.9
Tag Safari-611.1.9.
- 3:30 PM Changeset in webkit [270956] by
-
- 4 edits in trunk/Tools
[webkitscmpy] Correct mock
git logcall in standard git repositories
https://bugs.webkit.org/show_bug.cgi?id=219992
<rdar://problem/72436380>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: git_svn flag should only
control the final line of the message, not the existence of the entire message.
- Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
(TestFind.test_basic_git):
(TestFind.test_identifier_git):
(TestFind.test_identifier_git_svn):
(TestFind.test_hash):
- 3:21 PM Changeset in webkit [270955] by
-
- 5 edits in trunk
[selectors] Default namespace gets ignored inside non-type selectors for :is() and :not()
https://bugs.webkit.org/show_bug.cgi?id=219950
Reviewed by Antti Koivisto.
Source/WebCore:
Based on Blink r820500 and r820557 by <andruud@chromium.org>.
Default namespace declarations do not affect the compound selector
representing the subject of any selector within a :is() or :not() pseudo-class,
unless that compound selector contains an explicit universal selector or type selector.
Spec: https://drafts.csswg.org/selectors-4/#matches
This patch aligns WebKit implementation with Chromium and Firefox, so two WPT tests pass now.
- css/parser/CSSSelectorParser.cpp:
(WebCore::atEndIgnoringWhitespace):
(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::defaultNamespace const):
- css/parser/CSSSelectorParser.h:
LayoutTests:
- TestExpectations: Two WPT tests pass now.
- 3:19 PM Changeset in webkit [270954] by
-
- 5 edits in trunk/Tools
Stop parsing reftest.list files
https://bugs.webkit.org/show_bug.cgi?id=203783
Patch by Sam Sneddon <Sam Sneddon> on 2020-12-17
Reviewed by Jonathan Bedard.
This has only been used by the webkitpy integration tests in recent years. Needless to say,
this is Not Useful.
We do still have one reftest.list file,
media/track/opera/track/webvtt/rendering/reftest/reftest.list, but as this is in a reftest
directory we don't run any of the tests in it (and never have). See the above bug for more
detail about that history.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.assertBaselines): docstring fix
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist): Deleted.
(EndToEndTest): Deleted.
(EndToEndTest.test_reftest_with_two_notrefs): Deleted.
- Scripts/webkitpy/port/base.py:
(Port.init): remove Port._reftest_list
(Port.reference_files): don't use reftest.list as source of truth
(Port._get_reftest_list): Deleted.
(Port._parse_reftest_list): Deleted.
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_parse_reftest_list): Deleted.
- Scripts/webkitpy/port/test.py:
(unit_test_list): remove tests used to test reftest.list
- 3:17 PM Changeset in webkit [270953] by
-
- 4 edits in trunk/Tools
[run-webkit-tests] Replace FailureNotTested with FailureNoOutput
https://bugs.webkit.org/show_bug.cgi?id=219994
<rdar://problem/72440201>
Reviewed by Geoffrey Garen.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_text): Replace FailureNotTest with FailureNoOutput.
- Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type): Replace FailureNotTest with FailureNoOutput.
(FailureNoOutput): Renamed from FailureNotTested.
(FailureNotTested): Renamed to FailureNoOutput.
- Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_all_failure_classes): Replace FailureNotTest with FailureNoOutput.
- 3:14 PM Changeset in webkit [270952] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] WebM format reader doesn't work with a url in a <source> element
https://bugs.webkit.org/show_bug.cgi?id=219961
<rdar://problem/72399014>
Unreviewed, address post-review comments after r270939.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::canLoadFormatReader): Use an #elif so we don’t compile multiple
return statements.
- 2:39 PM Changeset in webkit [270951] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r270938.
Add missing include.
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
- 2:27 PM Changeset in webkit [270950] by
-
- 2 edits in trunk/LayoutTests
Rebase http/tests/navigation/javascriptlink-frames.html for Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219186
Unreviewed test gardening
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- 2:26 PM Changeset in webkit [270949] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, drop unnecessary forward declaration added in r270938.
- wtf/cocoa/MachSemaphore.h:
- 2:25 PM Changeset in webkit [270948] by
-
- 26 edits1 move4 adds in trunk
[WASM-References] Add support for memory.copy, memory.init and data.drop
https://bugs.webkit.org/show_bug.cgi?id=219943
Patch by Dmitry Bezhetskov <dbezhetskov> on 2020-12-17
Reviewed by Yusuke Suzuki.
JSTests:
Added ref-types spec tests for memory.copy, memory.init and data.drop:
https://github.com/WebAssembly/reference-types/tree/master/test/core.
Renamed table_instructions_parse_unreachable test into just
parse_unreachable to prevent confusion.
- wasm.yaml:
- wasm/references-spec-tests/memory_copy.wast.js: Added.
- wasm/references-spec-tests/memory_init.wast.js: Added.
- wasm/references/memory_copy.js: Added.
(async test):
- wasm/references/memory_copy_shared.js: Added.
(async test):
- wasm/references/parse_unreachable.js: Renamed from JSTests/wasm/references/table_instructions_parse_unreachable.js.
(invalidMemoryCopyUnreachable):
(invalidMemoryInitUnreachable):
(invalidDataDropUnreachable):
- wasm/wasm.json:
Source/JavaScriptCore:
Add support for memory.copy [dstAddress, srcAddress, length] -> []
that copies one memory segment to another memory segment.
The memory.copy calls C memcpy function to utilize all possible optimization for copy.
This instruction speedup copying data segments in wasm because without it we need to use a lot
load/store instructions with loops in wasm.
Add support for memory.init data_segment_index [dstAddress, srcAddress, length] -> []
that copies data from a passive data segment into a memory segment.
This instruction is the same as memory.copy but for read-only data segments.
It also utilize C memcpy under the hood.
Add support for data.drop data_segment_index [] -> []
that resize given data segment to zero.
Data.drop makes redundant data segment and prevents usage of it in the next.
BTW, it is just a hint for the host runtime so we don't have to change data segment.
Add support for Data count section.
This section just stores the number of data segments.
We need this to validate memory.init instruction's data index because
Code section comes before Data section.
These instructions are needed to support reference types proposal and bulk proposal.
- bytecode/BytecodeList.rb:
- llint/WebAssembly.asm:
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addMemoryCopy):
(JSC::Wasm::AirIRGenerator::addMemoryInit):
(JSC::Wasm::AirIRGenerator::addDataDrop):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addMemoryInit):
(JSC::Wasm::B3IRGenerator::addMemoryCopy):
(JSC::Wasm::B3IRGenerator::addDataDrop):
- wasm/WasmFormat.cpp:
(JSC::Wasm::Segment::create):
- wasm/WasmFormat.h:
(JSC::Wasm::Segment::isActive const):
(JSC::Wasm::Segment::isPassive const):
- wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseDataSegmentIndex):
(JSC::Wasm::FunctionParser<Context>::parseMemoryCopyImmediates):
(JSC::Wasm::FunctionParser<Context>::parseMemoryInitImmediates):
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::memoryInit):
(JSC::Wasm::Instance::dataDrop):
- wasm/WasmInstance.h:
- wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addMemoryInit):
(JSC::Wasm::LLIntGenerator::addDataDrop):
(JSC::Wasm::LLIntGenerator::addMemoryCopy):
- wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::copy):
(JSC::Wasm::Memory::init):
- wasm/WasmMemory.h:
- wasm/WasmModuleInformation.h:
(JSC::Wasm::ModuleInformation::dataSegmentsCount const):
- wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
- wasm/WasmOperations.h:
- wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseElement):
(JSC::Wasm::SectionParser::parseI32InitExpr):
(JSC::Wasm::SectionParser::parseI32InitExprForElementSection):
(JSC::Wasm::SectionParser::parseI32InitExprForDataSection):
(JSC::Wasm::SectionParser::parseDataSegmentCoreSpec):
(JSC::Wasm::SectionParser::parseDataSegmentReferenceTypesSpec):
(JSC::Wasm::SectionParser::parseGlobalType):
(JSC::Wasm::SectionParser::parseData):
(JSC::Wasm::SectionParser::parseDataCount):
- wasm/WasmSectionParser.h:
- wasm/WasmSections.h:
(JSC::Wasm::validateOrder):
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
- wasm/WasmSlowPaths.h:
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::evaluate):
- wasm/wasm.json:
- 2:23 PM Changeset in webkit [270947] by
-
- 12 edits in trunk/Source
[WebAudio] Simplify code related to dispatchToRenderThread
https://bugs.webkit.org/show_bug.cgi?id=219990
Reviewed by Geoffrey Garen.
Simplify code related to dispatchToRenderThread in WebAudio:
- AudioDestination::start() now always gets called with a non-null dispatchToRenderThread lambda. In the case where there is no AudioWorkletThread to dispatch to, the lambda simply calls its task synchronously.
- For Cocoa ports, make it so that only AudioDestinationCocoa needs to worry about the dispatchToRenderThread lambda. The dispatchToRenderThread lambda is no longer exposed to subclasses such as MockAudioDestinationCocoa & RemoteAudioDestinationProxy.
Source/WebCore:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::Function<void):
- platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::AudioDestinationCocoa::start):
(WebCore::AudioDestinationCocoa::startRendering):
(WebCore::AudioDestinationCocoa::stop):
(WebCore::AudioDestinationCocoa::stopRendering):
(WebCore::AudioDestinationCocoa::render):
- platform/audio/cocoa/AudioDestinationCocoa.h:
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::start):
- platform/mock/MockAudioDestinationCocoa.cpp:
(WebCore::MockAudioDestinationCocoa::startRendering):
(WebCore::MockAudioDestinationCocoa::stopRendering):
(WebCore::MockAudioDestinationCocoa::tick):
- platform/mock/MockAudioDestinationCocoa.h:
Source/WebKit:
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::startRenderingThread):
(WebKit::RemoteAudioDestinationProxy::startRendering):
(WebKit::RemoteAudioDestinationProxy::stopRendering):
(WebKit::RemoteAudioDestinationProxy::gpuProcessConnectionDidClose):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
- 2:21 PM Changeset in webkit [270946] by
-
- 8 edits in trunk/Source/WebKit
Fix "Open with Preview" menu item in PDF context menus on Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219986
<rdar://problem/72406073>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-12-17
Reviewed by Geoffrey Garen.
In r266654 I removed the ability for the web process to open a PDF in Preview on Big Sur.
I overlooked the fact that context menus also allow you to open a PDF in Preview,
which this fixes by having the UI process initiate the Preview opening if the user clicks on
the context menu item with the correct index.
- Shared/mac/PDFContextMenu.h:
(WebKit::PDFContextMenu::encode const):
(WebKit::PDFContextMenu::decode):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
- 2:07 PM Changeset in webkit [270945] by
-
- 4 edits in trunk/LayoutTests
Rebase 3 tests for Big Sur
https://bugs.webkit.org/show_bug.cgi?id=219184
unreviewed test gardening
- platform/mac/fast/forms/listbox-width-change-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
- 1:35 PM Changeset in webkit [270944] by
-
- 5 edits in trunk/Tools
[webkitscmpy] Capture Mock process logging during tests
https://bugs.webkit.org/show_bug.cgi?id=219989
<rdar://problem/72435662>
Reviewed by Dewei Zhu.
When declaring two mock local repositories, we need to ensure that logs are captured when
Instantiating the second repository so that "Mock process # send signal 9" is not logged
to the user's terminal.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
(TestCheckout):
- Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
(TestFind):
- Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit):
- 1:33 PM Changeset in webkit [270943] by
-
- 5 edits in trunk/Source/WebCore
[macOS] Use low-power audio buffer sizes for more output devices
https://bugs.webkit.org/show_bug.cgi?id=219975
<rdar://problem/72391280>
Reviewed by Eric Carlson.
In r171069, we limited setting the preferred buffer duration to a "low power", high-duration value to
built-in hardware, as some external audio devices would report supporting those high-duration values
only to have audible glitches when that value was set. Since then, external, wireless audio devices have
become vastly more prevalent. To enable "low power" buffer durations on those devices, allow these larger
durations to be set on external devices so long as they claim to support that larger duration.
- platform/audio/AudioHardwareListener.cpp:
(WebCore::AudioHardwareListener::AudioHardwareListener):
- platform/audio/AudioHardwareListener.h:
(WebCore::AudioHardwareListener::BufferSizeRange::operator bool const):
(WebCore::AudioHardwareListener::BufferSizeRange::nearest const):
(WebCore::AudioHardwareListener::supportedBufferSizes const):
(WebCore::AudioHardwareListener::setSupportedBufferSizes):
(WebCore::AudioHardwareListener::outputDeviceSupportsLowPowerMode const): Deleted.
(WebCore::AudioHardwareListener::setOutputDeviceSupportsLowPowerMode): Deleted.
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateSessionState):
- platform/audio/mac/AudioHardwareListenerMac.cpp:
(WebCore::currentDeviceSupportedBufferSizes):
(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):
(WebCore::AudioHardwareListenerMac::outputDeviceChanged):
(WebCore::currentDeviceSupportsLowPowerBufferSize): Deleted.
- 1:22 PM Changeset in webkit [270942] by
-
- 6 edits in trunk/Source
Followup patch: Still can't login to my.playstation.com
https://bugs.webkit.org/show_bug.cgi?id=219900
<rdar://problem/72062985>
Reviewed by Darin Adler.
Source/WebCore:
- en.lproj/Localizable.strings:
Source/WebKit:
Using curly quotes when constructing the Storage Access prompt message
may create issues with localizable strings. We should make a separate
localizable string for this quirk case and remove it when Sony
migrates away from third party cookies in their login flow.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::requestStorageAccessConfirm):
(WebKit::buildListForStorageAccessPrompt): Deleted.
- UIProcess/Cocoa/WKStorageAccessAlert.h:
- UIProcess/Cocoa/WKStorageAccessAlert.mm:
(WebKit::presentStorageAccessAlert):
(WebKit::presentStorageAccessAlertQuirk):
(WebKit::displayStorageAccessAlert):
- 12:30 PM Changeset in webkit [270941] by
-
- 4 edits in trunk/Tools
[webkitscmpy] Remove branches argument from mock Git
https://bugs.webkit.org/show_bug.cgi?id=219988
<rdar://problem/72434657>
Reviewed by Dewei Zhu.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git.init): Remote branches argument.
- Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branches):
- 12:30 PM Changeset in webkit [270940] by
-
- 12 edits in trunk/Source/WebCore
[CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=219970
Reviewed by Don Olmstead.
CMake build scripts should have a single place to list WebGL
source files to ease WebGL devs.
After all ports will switch to use GraphicsContextGLANGLE.cpp,
those files can be added to the common Sources.txt.
GraphicsContextGLOpenGLPrivate is used only by AppleWin port.
Enclosed by #if PLATFORM(WIN) && USE(CA).
- CMakeLists.txt:
- PlatformFTW.cmake:
- PlatformGTK.cmake:
- PlatformPlayStation.cmake:
- PlatformWin.cmake:
- SourcesGTK.txt:
- SourcesWPE.txt:
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.cpp:
- platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
- 12:14 PM Changeset in webkit [270939] by
-
- 9 edits in trunk/Source
[Cocoa] WebM format reader doesn't work with a url in a <source> element
https://bugs.webkit.org/show_bug.cgi?id=219961
<rdar://problem/72399014>
Reviewed by Andy Estes.
Source/WebCore:
Work around a bug that makes the format reader fail to load when the AVURLAssetOutOfBandMIMETypeKey
is included in the AVURLAsset options dictionary. Also include some cleanup:
- Move the code to check for WebM MIME types from MediaPlayerPrivateAVFoundationObjC to AVAssetMIMETypeCache.
- Don't use RuntimeEnabledFeatures in MediaPlayerPrivateAVFoundationObjC.
- Register the WebM format reader when creating an AVURLAsset for a WebM url instead of when checking the MIME type.
- Cleanup WebM "codecs" parameter parsing.
- platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.h:
- platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):
(WebCore::AVAssetMIMETypeCache::staticContainerTypeList):
(WebCore::AVAssetMIMETypeCache::setWebMFormatReaderEnabled):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::registerFormatReaderIfNecessary):
(WebCore::shouldAdvertiseOutOfBandMIMEType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsTypeAndCodecs):
(WebCore::ensureFormatReaderIsRegistered): Deleted.
(WebCore::isFormatReaderAvailable): Deleted.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::setWebMFormatReaderEnabled):
(WebCore::SourceBufferParserWebM::webmMIMETypes):
(WebCore::SourceBufferParserWebM::isWebMFormatReaderAvailable):
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- platform/graphics/cocoa/SourceBufferParserWebM.h:
Source/WebKit:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 11:10 AM Changeset in webkit [270938] by
-
- 14 edits2 adds in trunk/Source
[GPUProcess] Replace WebAudio rendering timer with a cross-process semaphore
https://bugs.webkit.org/show_bug.cgi?id=219964
Reviewed by Geoff Garen.
Source/WebCore:
Revert changes to CARingBuffer from r270907. These are no longer needed
with this new approach so we might as well remove the complexity from
our ring buffer implementation.
- platform/audio/cocoa/CARingBuffer.cpp:
(WebCore::CARingBufferStorageVector::flush):
(WebCore::CARingBuffer::fetchIfHasEnoughData):
(WebCore::CARingBuffer::fetch):
- platform/audio/cocoa/CARingBuffer.h:
Source/WebKit:
r270907 replaced the per-rendering quantum IPC from the GPUProcess to the
WebProcess with a very high-frequency timer in the WebProcess to trigger
the rendering. While this works, this seemed a bit fragile and it also
adds some latency to avoid missed frames.
In this patch, I am replacing the high-frequency timer introduced in r270907
with a cross-process semaphore. When the WebProcess asks the GPU process
to create an audio device, the GPUProcess sends it back a MachSendRight
to the "rendering" semaphore. The WebProcess then starts a high-priority
AudioThread which waits this semaphore to be signaled to render a quantum.
Whenever render() gets called on the GPUProcess side, the GPUProcess
simply signals the "rendering" semaphore, causing the WebProcess to do
the rendering of a quantum. As was the case before, the WebProcess stores
rendered buffers into the RingBuffer it shares with the GPUProcess and
the GPUProcess fetches from the RingBuffer as needed.
- GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestination::createRenderSemaphoreSendRight):
(WebKit::RemoteAudioDestination::audioSamplesStorageChanged):
(WebKit::RemoteAudioDestination::render):
(WebKit::RemoteAudioDestinationManager::createAudioDestination):
- GPUProcess/media/RemoteAudioDestinationManager.h:
- GPUProcess/media/RemoteAudioDestinationManager.messages.in:
- Shared/Cocoa/SharedRingBufferStorage.cpp:
- Shared/Cocoa/SharedRingBufferStorage.h:
- WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::startRenderingThread):
(WebKit::RemoteAudioDestinationProxy::stopRenderingThread):
(WebKit::RemoteAudioDestinationProxy::connectToGPUProcess):
(WebKit::RemoteAudioDestinationProxy::~RemoteAudioDestinationProxy):
(WebKit::RemoteAudioDestinationProxy::start):
(WebKit::RemoteAudioDestinationProxy::stop):
(WebKit::RemoteAudioDestinationProxy::renderQuantum):
(WebKit::RemoteAudioDestinationProxy::storageChanged):
(WebKit::RemoteAudioDestinationProxy::gpuProcessConnectionDidClose):
- WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
Source/WTF:
Introduce MachSemaphore class, which is a C++ wrapper around a low-level
mach semaphore. This semaphore can be used cross-process and sent via
IPC as a MachSendRight.
- WTF.xcodeproj/project.pbxproj:
- wtf/PlatformMac.cmake:
- wtf/cocoa/MachSemaphore.cpp: Added.
(WTF::MachSemaphore::MachSemaphore):
(WTF::MachSemaphore::~MachSemaphore):
(WTF::MachSemaphore::signal):
(WTF::MachSemaphore::wait):
(WTF::MachSemaphore::createSendRight):
- wtf/cocoa/MachSemaphore.h: Added.
- 10:26 AM Changeset in webkit [270937] by
-
- 13 edits in trunk
Web Inspector: REGRESSION(r266467): viewing a WebSocket created before Web Inspector was opened doesn't show any message frames
https://bugs.webkit.org/show_bug.cgi?id=219510
Reviewed by Youenn Fablet.
Source/WebCore:
Updated test: http/tests/websocket/tests/hybi/inspector/before-load.html
Restored functionality prior to r266467 so that the
progressIdentifier(previouslychannelIdentifier) is
available fromWebSocketChannel.
- Modules/websockets/ThreadableWebSocketChannel.h:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::sendFrame):
- Modules/websockets/WebSocketChannel.h:
- Reinstate a separate progress identifier for inspection
- Modules/websockets/WebSocketChannelInspector.cpp:
(WebCore::progressIdentifier const):
- Modules/websockets/WebSocketChannelInspector.h:
- Support getting the progress identifier.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):
Source/WebKit:
Restored functionality prior to r266467 so that the
progressIdentifier(previouslychannelIdentifier) is
available fromWebSocketChannel.
- WebProcess/Network/WebSocketChannel.h:
LayoutTests:
Updated test to check that sent and received frames are correctly associated with WebSockets that were open
before the Web Inspector was opened.
- http/tests/websocket/tests/hybi/inspector/before-load-expected.txt:
- http/tests/websocket/tests/hybi/inspector/before-load.html:
- 10:21 AM Changeset in webkit [270936] by
-
- 2 edits in trunk/LayoutTests
Rebase fast/css/text-overflow-input.html
https://bugs.webkit.org/show_bug.cgi?id=219959
Unreviewed test gardening
- platform/mac/fast/css/text-overflow-input-expected.txt:
- 9:17 AM Changeset in webkit [270935] by
-
- 2 edits in trunk/Tools
Unreviewed, reordering associated email addresses in
preparation for the GitHub migration.
- Scripts/webkitpy/common/config/contributors.json:
- 6:55 AM Changeset in webkit [270934] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback-expected.txt: Removed.
- platform/mac-wk2/media/media-can-play-webm-expected.txt: Removed.
- 5:41 AM Changeset in webkit [270933] by
-
- 9 edits52 adds in trunk/LayoutTests
[selectors] Update WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=219958
Reviewed by Carlos Alberto Lopez Perez.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/focus-visible-001-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-001.html: Added.
- web-platform-tests/css/selectors/focus-visible-002-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-002.html: Added.
- web-platform-tests/css/selectors/focus-visible-003-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-003.html: Added.
- web-platform-tests/css/selectors/focus-visible-004-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-004.html: Added.
- web-platform-tests/css/selectors/focus-visible-012-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-012.html: Added.
- web-platform-tests/css/selectors/hover-002-expected.txt: Added.
- web-platform-tests/css/selectors/hover-002.html: Added.
- web-platform-tests/css/selectors/invalidation/not-001-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/not-001.html: Added.
- web-platform-tests/css/selectors/invalidation/not-002-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/not-002.html: Added.
- web-platform-tests/css/selectors/invalidation/w3c-import.log:
- web-platform-tests/css/selectors/is-default-ns-001-expected.html: Added.
- web-platform-tests/css/selectors/is-default-ns-001.html: Added.
- web-platform-tests/css/selectors/is-default-ns-002-expected.html: Added.
- web-platform-tests/css/selectors/is-default-ns-002.html: Added.
- web-platform-tests/css/selectors/is-default-ns-003-expected.html: Added.
- web-platform-tests/css/selectors/is-default-ns-003.html: Added.
- web-platform-tests/css/selectors/is-specificity-shadow-expected.txt: Added.
- web-platform-tests/css/selectors/is-specificity-shadow.html: Added.
- web-platform-tests/css/selectors/not-complex-expected.txt: Added.
- web-platform-tests/css/selectors/not-complex.html: Added.
- web-platform-tests/css/selectors/not-default-ns-001-expected.html: Added.
- web-platform-tests/css/selectors/not-default-ns-001.html: Added.
- web-platform-tests/css/selectors/not-default-ns-002-expected.html: Added.
- web-platform-tests/css/selectors/not-default-ns-002.html: Added.
- web-platform-tests/css/selectors/not-default-ns-003-expected.html: Added.
- web-platform-tests/css/selectors/not-default-ns-003.html: Added.
- web-platform-tests/css/selectors/not-specificity-expected.txt: Added.
- web-platform-tests/css/selectors/not-specificity.html: Added.
- web-platform-tests/css/selectors/parsing/parse-not-expected.txt:
- web-platform-tests/css/selectors/parsing/parse-not.html:
- web-platform-tests/css/selectors/selectors-dir-selector-auto-expected.txt: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-auto.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-001-expected.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-001.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-002-expected.xht: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-002.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-003-expected.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-003.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-004-expected.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-change-004.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-ltr-002-expected.xht: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-ltr-002.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-ltr-003-expected.xht: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-ltr-003.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-querySelector-expected.txt: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-querySelector.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-white-space-001-expected.html: Added.
- web-platform-tests/css/selectors/selectors-dir-selector-white-space-001.html: Added.
- web-platform-tests/css/selectors/w3c-import.log:
LayoutTests:
- TestExpectations: Mark failures associated with the relevant bugs. Two focus-visible tests are skipped, as the only test they have is failing with different messages in each platform because the outline color varies.
- platform/ios/TestExpectations: Skip 2 tests that don't work in iOS.
- tests-options.json:
- 3:18 AM Changeset in webkit [270932] by
-
- 13 edits in trunk/Source
Make FontCascade::CodePath an enum class
https://bugs.webkit.org/show_bug.cgi?id=219947
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-17
Reviewed by Alex Christensen.
Source/WebCore:
Make FontCascade::CodePath an enum class. Besides the
usual enum class benefits, one additional nice thing
is that it removed the need for the "Complex" ifdef.
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFontAndText):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuring):
- platform/graphics/ComplexTextController.cpp:
(WebCore::TextLayout::isNeeded):
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::layoutText const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::widthOfTextRange const):
(WebCore::FontCascade::width const):
(WebCore::FontCascade::widthForSimpleText const):
(WebCore::FontCascade::adjustSelectionRectForText const):
(WebCore::FontCascade::offsetForPosition const):
(WebCore::FontCascade::codePath const):
(WebCore::FontCascade::characterRangeCodePath):
- platform/graphics/FontCascade.h:
(WebCore::FontCascade::characterRangeCodePath):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
(WebCore::WebCoreAlwaysUsesComplexTextCodePath):
- rendering/RenderText.cpp:
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):
(WebCore::RenderText::computeCanUseSimpleFontCodePath const):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
Source/WebKit:
Adapt to enum class change.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath):
Source/WebKitLegacy/mac:
Adapt to enum class change.
- WebView/WebView.mm:
(+[WebView _setAlwaysUsesComplexTextCodePath:]):
- 3:13 AM Changeset in webkit [270931] by
-
- 13 edits in trunk/Source/WebCore
Make MixedContentChecker stateless
https://bugs.webkit.org/show_bug.cgi?id=219771
Patch by Rob Buis <rbuis@igalia.com> on 2020-12-17
Reviewed by Alex Christensen.
Make MixedContentChecker stateless, it only needs the frame
in a few cased which we can just pass as a parameter. Making
MixedContentChecker stateless means that FrameLoader does
not have to know it.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseAttribute):
- html/parser/XSSAuditor.cpp:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
- loader/MixedContentChecker.cpp:
(WebCore::logWarning):
(WebCore::MixedContentChecker::canDisplayInsecureContent):
(WebCore::MixedContentChecker::canRunInsecureContent):
(WebCore::MixedContentChecker::checkFormForMixedContent):
(WebCore::MixedContentChecker::checkForMixedContentInFrameTree):
(WebCore::MixedContentChecker::MixedContentChecker): Deleted.
(WebCore::MixedContentChecker::client const): Deleted.
(WebCore::MixedContentChecker::canDisplayInsecureContent const): Deleted.
(WebCore::MixedContentChecker::canRunInsecureContent const): Deleted.
(WebCore::MixedContentChecker::checkFormForMixedContent const): Deleted.
(WebCore::MixedContentChecker::logWarning const): Deleted.
- loader/MixedContentChecker.h:
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::pluginIsLoadable):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent const):
- 1:41 AM Changeset in webkit [270930] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Move service workers failures to GLIB.
Some of flaky failures have been passing consistently for the last
4000 revisions, so they're actually removed from test expectations.
- platform/glib/TestExpectations:
- platform/wpe/TestExpectations:
