Timeline

Apr 15, 2021:

11:49 PM Changeset in webkit [276120] by commit-queue@webkit.org

• 41 edits
  1 add
  2 deletes in trunk/Source

Unreviewed, reverting r276107.
​https://bugs.webkit.org/show_bug.cgi?id=224653

It broke non-Cocoa clean builds

Reverted changeset:

"[GPUP] WebContent process should not create AVOutputContext
instances when media in GPU Process is enabled"
​https://bugs.webkit.org/show_bug.cgi?id=224469
​https://trac.webkit.org/changeset/276107

11:25 PM Changeset in webkit [276119] by Lauro Moura

• 2 edits in trunk/Source/WebCore

REGRESSION(r276039) [GTK] Build failures on Ubuntu 18.04
​https://bugs.webkit.org/show_bug.cgi?id=224644
<rdar://problem/76742835>

Unreviewed build fix.

• bindings/js/JSDOMSetLike.cpp: Add missing Inlines header as

suggested by Mark.

10:37 PM Changeset in webkit [276118] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274403. rdar://problem/76374004

Cancel image loader events after first dispatch
​https://bugs.webkit.org/show_bug.cgi?id=218556

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-14
Reviewed by Darin Adler.

Address post review comments.

• dom/EventSender.h: (WebCore::EventSender<T>::dispatchPendingEvents):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:37 PM Changeset in webkit [276117] by Russell Epstein

• 4 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274357. rdar://problem/76374004

Cancel image loader events after first dispatch
​https://bugs.webkit.org/show_bug.cgi?id=218556

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-12
Reviewed by Ryosuke Niwa.

Cancel image loader events after first dispatch.
Also change EventSender to use WeakPtr.

• dom/EventSender.h: (WebCore::EventSender<T>::dispatchEventSoon): (WebCore::EventSender<T>::dispatchPendingEvents):
• loader/ImageLoader.cpp: (WebCore::ImageLoader::dispatchPendingErrorEvent):
• loader/ImageLoader.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:09 PM Changeset in webkit [276116] by Russell Epstein

• 8 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r275846. rdar://problem/76727548

Create WebIDBServer only when it is needed
​https://bugs.webkit.org/show_bug.cgi?id=224305
rdar://71962196

Reviewed by Alex Christensen.

Currently each WebIDBServer has a separate thread, so we don't want to create or keep WebIDBServer if it's not
in use. There are two cases where network process needs a WebIDBServer:

1. handle requests from UI process to collect or remove data
2. handle requests from Web process to perform IDB operations

Previously, we created a WebIDBServer when network process connects to a web process, but that does not mean web
process will perform IDB operations and we may create a thread that's not used. To avoid this, add a new message
AddIDBConnection for web process to ensure network process has WebIDBServer when it's about to perform operation.

Also, previously network process removes a WebIDBServer when session is removed and WebIDBServer is not binded
with any web process connection. Now we remove WebIDBServer when it's done handling requests, that is count of
pending requests from UI process is 0 and WebIDBServer is not binded with web process connection. We also remove
WebIDBServer at when network process is about to be destroyed (NetworkProcess::didClose) so we can break the
reference cycle of NetworkProcess-WebIDBServer-IDBServer, and make sure thread exits.

• NetworkProcess/IndexedDB/WebIDBServer.cpp: (WebKit::WebIDBServer::create): (WebKit::WebIDBServer::WebIDBServer): (WebKit::m_closeCallback): (WebKit::WebIDBServer::~WebIDBServer): (WebKit::WebIDBServer::getOrigins): (WebKit::WebIDBServer::closeAndDeleteDatabasesModifiedSince): (WebKit::WebIDBServer::closeAndDeleteDatabasesForOrigins): (WebKit::WebIDBServer::renameOrigin): (WebKit::WebIDBServer::removeConnection): (WebKit::WebIDBServer::close): (WebKit::WebIDBServer::tryClose):
• NetworkProcess/IndexedDB/WebIDBServer.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::addIDBConnection):
• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::didClose): (WebKit::NetworkProcess::createNetworkConnectionToWebProcess): (WebKit::NetworkProcess::destroySession): (WebKit::NetworkProcess::createWebIDBServer): (WebKit::NetworkProcess::connectionToWebProcessClosed): (WebKit::NetworkProcess::removeWebIDBServerIfPossible): Deleted. Move the removal code to WebIDBServer.
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp: (WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:05 PM Changeset in webkit [276115] by don.olmstead@sony.com

• 4 edits
  2 deletes in trunk/Source/WebCore

Remove TilingData class
​https://bugs.webkit.org/show_bug.cgi?id=224643

Reviewed by Yusuke Suzuki.

It doesn't seem to be used anywhere and the code hasn't been touched in almost a decade.

• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/gpu/TilingData.cpp: Removed.
• platform/graphics/gpu/TilingData.h: Removed.

9:58 PM Changeset in webkit [276114] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r276112.
​https://bugs.webkit.org/show_bug.cgi?id=224646

.h files should not #include *Inlines.h files.

Reverted changeset:

"REGRESSION(r276039) [GTK] Build failures on Ubuntu 18.04"
​https://bugs.webkit.org/show_bug.cgi?id=224644
​https://trac.webkit.org/changeset/276112

9:57 PM Changeset in webkit [276113] by Diego Pino Garcia

• 4 edits in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Gardened tests expected to fail but passed.

• platform/glib/TestExpectations:
• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

9:43 PM Changeset in webkit [276112] by Lauro Moura

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r276039) [GTK] Build failures on Ubuntu 18.04
​https://bugs.webkit.org/show_bug.cgi?id=224644

Unreviewed build fix.

• runtime/JSSet.h: Use HashMapImplInlines to include the base

finishCreation implementation. Somehow GCC 7.5 wasn't picking it up.

9:15 PM Changeset in webkit [276111] by don.olmstead@sony.com

• 2 edits in trunk/Source/WebCore

[CMake] OpenGL libraries not linked when ANGLE isn't used
​https://bugs.webkit.org/show_bug.cgi?id=224642

Reviewed by Fujii Hironori.

Move the block linking and including OpenGL libraries outside of the ANGLE related checks
to catch the case where OpenGL is needed but WebGL and ANGLE are disabled.

Also removes an include for the platform/gpu directory as that's only used for WebGPU.

• CMakeLists.txt:

8:46 PM Changeset in webkit [276110] by svillar@igalia.com

• 2 edits in trunk/Source/WebCore

Assertion failure in SVGAnimationElement::currentValuesForValuesAnimation
​https://bugs.webkit.org/show_bug.cgi?id=222715

Reviewed by Ryosuke Niwa.

Replaced ASSERT_WITH_SECURITY_IMPLICATION by ASSERT. It was added by mistake as part of
r157341 long time ago. There is no security implication because just after the assert
there would be a division by 0 followed by a crash.

• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

7:46 PM Changeset in webkit [276109] by Chris Gambrell

• 2 edits
  1 add
  1 delete in trunk/LayoutTests

[LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=223541
<rdar://problem/75639142>

Reviewed by Jonathan Bedard.

• http/tests/resourceLoadStatistics/cap-cache-max-age-for-prevalent-resource.html:
• http/tests/resourceLoadStatistics/resources/cached-permanent-redirect.php: Removed.
• http/tests/resourceLoadStatistics/resources/cached-permanent-redirect.py: Added.

7:33 PM Changeset in webkit [276108] by Kate Cheney

• 2 edits in trunk/Source/WebKit

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WTF::HashTableConstIterator<WTF::String, WTF::KeyValuePair<...
​https://bugs.webkit.org/show_bug.cgi?id=224637
<rdar://problem/76540809>

Reviewed by Alex Christensen.

If the protocol and host of the SecurityOrigin object are empty,
toRawString() could return null. We should add a valid key check here
before doing a hash table lookup.

• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::policyForOrigin const):

7:20 PM Changeset in webkit [276107] by Peng Liu

• 41 edits
  2 adds
  1 delete in trunk/Source

[GPUP] WebContent process should not create AVOutputContext instances when media in GPU Process is enabled
​https://bugs.webkit.org/show_bug.cgi?id=224469

Reviewed by Eric Carlson.

Source/WebCore:

This patch modifies MediaPlaybackTargetContext to provide interfaces to serialize/deserialize
AVOutputContext and modifies MediaPlaybackTargetCocoa to use MediaPlaybackTargetContext to
manage its AVOutputContext instead of keeping a pointer to the AVOutputContext object.
With these changes, a WebContent process can forward a serialized AVOutputContext object
to other processes (e.g., the GPU process) without deserializing it. Therefore, the WebContent
process does not need access to the CoreMedia routing service. So we can remove the fix (r275669)
for bug 224328.

Covered by existing tests.

• Modules/airplay/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::setMockMediaPlaybackTargetPickerState):

• Modules/airplay/WebMediaSessionManager.h:

• Headers.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:

Modify the project file because MediaPlaybackTargetContext is used in Cocoa ports only.

• page/ChromeClient.h:

(WebCore::ChromeClient::setMockMediaPlaybackTargetPickerState):

• page/Page.cpp:

(WebCore::Page::setMockMediaPlaybackTargetPickerState):

• page/Page.h:

• platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::hasActiveRoute const):
(WebCore::MediaPlaybackTarget::deviceName const):
(WebCore::MediaPlaybackTarget::supportsRemoteVideoPlayback):
(): Deleted.

• platform/graphics/MediaPlaybackTargetContext.h: Removed.
• platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h:

(WebCore::MediaPlaybackTargetCocoa::outputContext const): Deleted.

• platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm:

(WebCore::MediaPlaybackTargetCocoa::create):
(WebCore::MediaPlaybackTargetCocoa::MediaPlaybackTargetCocoa):
(WebCore::MediaPlaybackTargetCocoa::~MediaPlaybackTargetCocoa):
(WebCore::toMediaPlaybackTargetCocoa):
(WebCore::MediaPlaybackTargetCocoa::supportsRemoteVideoPlayback const): Deleted.
(WebCore::MediaPlaybackTargetCocoa::targetContext const): Deleted.
(WebCore::MediaPlaybackTargetCocoa::hasActiveRoute const): Deleted.
(WebCore::MediaPlaybackTargetCocoa::deviceName const): Deleted.
Don't directly use AVOutputContext in this class.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::isCurrentPlaybackTargetWireless const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget):

• platform/graphics/cocoa/MediaPlaybackTargetContext.h: Added.

(WebCore::MediaPlaybackTargetContext::MediaPlaybackTargetContext):
(WebCore::MediaPlaybackTargetContext::type const):
(WebCore::MediaPlaybackTargetContext::mockState const):
(WebCore::MediaPlaybackTargetContext::outputContext const):
(WebCore::MediaPlaybackTargetContext::serializedOutputContext const):
(WebCore::MediaPlaybackTargetContext::encodingRequiresPlatformData const):

• platform/graphics/cocoa/MediaPlaybackTargetContext.mm: Added.

(WebCore::MediaPlaybackTargetContext::MediaPlaybackTargetContext):
(WebCore::MediaPlaybackTargetContext::deviceName const):
(WebCore::MediaPlaybackTargetContext::hasActiveRoute const):
(WebCore::MediaPlaybackTargetContext::supportsRemoteVideoPlayback const):
(WebCore::MediaPlaybackTargetContext::serializeOutputContext):
(WebCore::MediaPlaybackTargetContext::deserializeOutputContext):

• platform/mock/MediaPlaybackTargetMock.cpp:

(WebCore::MediaPlaybackTargetMock::create):
(WebCore::MediaPlaybackTargetMock::MediaPlaybackTargetMock):
(WebCore::toMediaPlaybackTargetMock):
(WebCore::MediaPlaybackTargetMock::targetContext const): Deleted.

• platform/mock/MediaPlaybackTargetMock.h:

(WebCore::MediaPlaybackTargetMock::state const):

• platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::externalOutputDeviceAvailable):
(WebCore::MediaPlaybackTargetPickerMock::startingMonitoringPlaybackTargets):
(WebCore::MediaPlaybackTargetPickerMock::invalidatePlaybackTargets):
(WebCore::MediaPlaybackTargetPickerMock::setState):

• platform/mock/MediaPlaybackTargetPickerMock.h:

• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setMockMediaPlaybackTargetPickerState):

Source/WebKit:

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):

• GPUProcess/media/RemoteMediaPlayerProxy.h:

• GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp:

(WebKit::RemoteMediaSessionHelperProxy::activeVideoRouteDidChange):

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encode):
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::decode):

• Shared/WebCoreArgumentCoders.h:
• Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::MediaPlaybackTargetContext>::decodePlatformData): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::mediaRelatedIOKitClasses):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMockMediaPlaybackTargetPickerState):
(WebKit::WebPageProxy::setPlaybackTarget):
(WebKit::temporaryMachServices): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

• WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp:

(WebKit::RemoteMediaSessionHelper::activeVideoRouteDidChange):

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setMockMediaPlaybackTargetPickerState):

• WebProcess/WebCoreSupport/WebChromeClient.h:

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::playbackTargetSelected const):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebChromeClient.h:
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setMockMediaPlaybackTargetPickerState):

• WebView/WebMediaPlaybackTargetPicker.h:
• WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::setMockMediaPlaybackTargetPickerState):

• WebView/WebView.mm:

(-[WebView _setMockMediaPlaybackTargetPickerName:state:]):

• WebView/WebViewInternal.h:

7:06 PM Changeset in webkit [276106] by mark.lam@apple.com

• 4 edits
  1 add in trunk

HashMapImpl::rehash() should use a version of jsMapHash that cannot throw.
​https://bugs.webkit.org/show_bug.cgi?id=224610
rdar://76698910

Reviewed by Yusuke Suzuki.

JSTests:

• stress/suppress-TerminationException-in-HashMapImpl-rehash.js: Added.

Source/JavaScriptCore:

For context, HashMapImpl::rehash()'s rehash operation relies on jsMapHash().
jsMapHash() can be interrupted by a TerminationException, and as a result, may
not return the string hash we are expecting. This in turn can lead to the
rehash operation hashing with wrong keys.

However, all the keys should have already been hashed. Hence, rehash() should
never see an exception thrown there. We can avoid this complication with the
TerminationException by simply calling an alternate version of jsMapHash() that
is guaranteed to never throw e.g. a jsMapHashForAlreadyHashedValue() function.

• runtime/ExceptionHelpers.h:
• runtime/HashMapImplInlines.h:

(JSC::jsMapHashImpl):
(JSC::jsMapHash):
(JSC::jsMapHashForAlreadyHashedValue):
(JSC::HashMapImpl<HashMapBucketType>::rehash):

6:46 PM Changeset in webkit [276105] by Wenson Hsieh

• 2 edits in trunk/LayoutTests

Unreviewed test gardening after r276084

Mark the test as failing with an image diff on Windows, since contextClick in DumpRenderTree does not appear
to return the resulting context menu item titles (or information about the context menu items) on Windows.

• platform/win/TestExpectations:

6:45 PM Changeset in webkit [276104] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/ANGLE

Use kIOMainPortDefault where available
​https://bugs.webkit.org/show_bug.cgi?id=224632

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-15
Reviewed by Alexey Proskuryakov.

In ANGLE we don't include WTF headers, so we can't use the HAVE macro like we do elsewhere in WebKit,
but this is pretty close.

• src/gpu_info_util/SystemInfo_macos.mm:

(angle::GetVendorIDFromMetalDeviceRegistryID):

6:40 PM Changeset in webkit [276103] by dino@apple.com

• 73 edits in trunk/LayoutTests

Rebaseline some WebGL tests that are only running on the dedicated WebGL bot.

• webgl/2.0.0/conformance/rendering/clipping-wide-points-expected.txt:
• webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:
• webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
• webgl/2.0.0/conformance2/rendering/fs-color-type-mismatch-color-buffer-type-expected.txt:
• webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt:
• webgl/2.0.0/deqp/data/gles2/shaders/conversions-expected.txt:
• webgl/2.0.0/deqp/data/gles3/shaders/conversions-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fboinvalidate/sub-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fboinvalidate/whole-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fbomultisample.2_samples-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fbomultisample.4_samples-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fbomultisample.8_samples-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/array.int-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/array.uint-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/basic.int-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/basic.uint-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/random_00-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/random_01-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/fragmentoutput/random_02-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/internalformatquery-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/negativebufferapi-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/occlusionquery_strict-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/00-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/01-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/02-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/03-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/04-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/05-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/06-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/primitiverestart/07-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/readpixel-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/shadertexturefunction/texturegrad-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureformat/sized_depth_stencil-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_linear_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_linear_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_linear_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_linear_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_nearest_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_nearest_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_nearest_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_linear_mipmap_nearest_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_linear_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_linear_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_linear_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_linear_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_nearest_greater-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_nearest_greater_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_nearest_less-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/2d_nearest_mipmap_nearest_less_or_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_mipmap_linear_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_mipmap_linear_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_mipmap_nearest_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_mipmap_nearest_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_linear_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_mipmap_linear_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_mipmap_linear_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_mipmap_nearest_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_mipmap_nearest_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/textureshadow/cube_nearest_not_equal-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/texturespecification/texstorage2d_format_depth_stencil-expected.txt:
• webgl/2.0.0/deqp/functional/gles3/texturespecification/texstorage3d_format_depth_stencil-expected.txt:
• webgl/conformance/extensions/webgl-multi-draw-expected.txt:

6:37 PM Changeset in webkit [276102] by ysuzuki@apple.com

• 5 edits in trunk/Source/JavaScriptCore

[JSC] Remove CodeBlock::RareData::m_catchProfiles
​https://bugs.webkit.org/show_bug.cgi?id=224593

Reviewed by Mark Lam.

We are having this Vector just because we would like to destroy them when destroying the owner Baseline / LLInt CodeBlock.
But we are setting a pointer in OpCatch's metadata in Baseline / LLInt.
So we should just iterate metadata for that and destroy them in the destructor. No need to keep them separately.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeIndex):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeIndexSlow):
(JSC::CodeBlock::updateAllValueProfilePredictionsAndCountLiveness):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::createRareDataIfNecessary):

• bytecode/ValueProfile.h:

(JSC::ValueProfileAndVirtualRegisterBuffer::ValueProfileAndVirtualRegisterBuffer): Deleted.
(JSC::ValueProfileAndVirtualRegisterBuffer::~ValueProfileAndVirtualRegisterBuffer): Deleted.
(JSC::ValueProfileAndVirtualRegisterBuffer::forEach): Deleted.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

6:29 PM Changeset in webkit [276101] by Robert Jenner

• 2 edits in trunk/LayoutTests

N[ macOS Wk2 ] imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=222371

Uneviewed test gardening.

• platform/mac-wk2/TestExpectations: Added Crash to the existing test expectations, as test is flakey crashing as well.

6:06 PM Changeset in webkit [276100] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Pass -d parameter to git clean in commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=224636

Reviewed by Jonathan Bedard.

• CISupport/ews-build/steps.py:

(CleanGitRepo):

• CISupport/ews-build/steps_unittest.py:

5:53 PM Changeset in webkit [276099] by Robert Jenner

• 2 edits in trunk/LayoutTests

REGRESSION (r275926): [ BigSur X86_64] imported/w3c/web-platform-tests/css/css-fonts/font-feature-settings-tibetan.html
​https://bugs.webkit.org/show_bug.cgi?id=224631

Unreviewed test gardening.

• platform/mac/TestExpectations: Test has been fixed for new platforms, and won't be for BigSur. Updating expectations for BigSur only.

5:38 PM Changeset in webkit [276098] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275876. rdar://problem/76727236

Skip style update
​https://bugs.webkit.org/show_bug.cgi?id=223365

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-13
Reviewed by Ryosuke Niwa.

Skip style update for getting the SVG bounding box
since boundingClientRect already updated style.

• dom/Element.cpp: (WebCore::Element::boundingAbsoluteRectWithoutLayout):
• svg/SVGElement.cpp: (WebCore::SVGElement::getBoundingBox):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [276097] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275807. rdar://problem/76732495

Store InputType in a Ref before calling setValueAsDecimal
​https://bugs.webkit.org/show_bug.cgi?id=223535

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-11
Reviewed by Ryosuke Niwa.

Store InputType in a Ref before calling setValueAsDecimal.

• html/InputType.cpp: (WebCore::InputType::applyStep):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:23 PM Changeset in webkit [276096] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/JavaScriptCore

Cherry-pick r275233. rdar://problem/76727522

Ensure that GlobalPropertyInfo is allocated on the stack.
​https://bugs.webkit.org/show_bug.cgi?id=223911

Unreviewed test gardening.

Rebaseline builtins generator tests after r275212.

• Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:23 PM Changeset in webkit [276095] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275933. rdar://problem/76727571

AudioSourceProviderAVFObjC should lock all multithreaded objects
​https://bugs.webkit.org/show_bug.cgi?id=224230

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-13
Reviewed by Eric Carlson.

Lock following objects with TapStorage::lock:

AudioSourceProviderAVFObjC::m_tapStorage
AudioSourceProviderAVFObjC::m_avPlayerItem

Do not clear the tapStorage nor the _this pointer from
the audio thread. This is a race that cannot be overcome
since the main thread needs to access the m_tapStorage pointer to
lock the m_tapStorage pointer for modification.

Initialize m_tap in more robust way, in case initialization fails.

Do not leave stale m_tapStorage present when destroying the mixer.

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm: (WebCore::AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC): (WebCore::AudioSourceProviderAVFObjC::destroyMixIfNeeded): (WebCore::AudioSourceProviderAVFObjC::createMixIfNeeded): (WebCore::AudioSourceProviderAVFObjC::initCallback): (WebCore::AudioSourceProviderAVFObjC::finalizeCallback):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:23 PM Changeset in webkit [276094] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275897. rdar://problem/76727571

AudioSourceProviderAVFObjC should check for m_client when dispatching setFormat
​https://bugs.webkit.org/show_bug.cgi?id=224479

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-13
Reviewed by Eric Carlson.

Use a weak pointer to schedule the setFormat client callback.
If client is unset before any callback is run, cancel the
pending callbacks.

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm: (WebCore::AudioSourceProviderAVFObjC::destroyMixIfNeeded): (WebCore::AudioSourceProviderAVFObjC::createMixIfNeeded): (WebCore::AudioSourceProviderAVFObjC::prepare):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276093] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275896. rdar://problem/76727571

AudioSourceProviderAVFObjC::setClient should check for m_avAssetTrack
​https://bugs.webkit.org/show_bug.cgi?id=224478

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-13
Reviewed by Eric Carlson.

Check for m_avAssetTrack when setting the client.
This is done for consistency, it is unclear if this affects
real world content.

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm: (WebCore::AudioSourceProviderAVFObjC::setClient): (WebCore::AudioSourceProviderAVFObjC::setPlayerItem): (WebCore::AudioSourceProviderAVFObjC::setAudioTrack): (WebCore::AudioSourceProviderAVFObjC::destroyMixIfNeeded): (WebCore::AudioSourceProviderAVFObjC::createMixIfNeeded):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276092] by Russell Epstein

• 12 edits in branches/safari-611-branch/Source

Cherry-pick r275845. rdar://problem/76727387

Modernize uses of ConsoleClient
​https://bugs.webkit.org/show_bug.cgi?id=224398

Reviewed by David Kilzer.

ConsoleClient acts like a delegate, so its callers
should be using weak references to it.

Source/JavaScriptCore:

• inspector/JSGlobalObjectInspectorController.cpp: (Inspector::JSGlobalObjectInspectorController::consoleClient const):
• inspector/JSGlobalObjectInspectorController.h:
• runtime/ConsoleClient.h:
• runtime/ConsoleObject.cpp: (JSC::consoleLogWithLevel): (JSC::JSC_DEFINE_HOST_FUNCTION):
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::setConsoleClient):
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::consoleClient const): (JSC::JSGlobalObject::setConsoleClient): Deleted.

Source/WebCore:

• bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
• bindings/js/ScriptController.cpp: (WebCore::ScriptController::initScriptForWindowProxy):
• bindings/js/WindowProxy.cpp: (WebCore::WindowProxy::setDOMWindow):
• workers/WorkerOrWorkletScriptController.cpp: (WebCore::WorkerOrWorkletScriptController::initScriptWithSubclass):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276091] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275756. rdar://problem/76727458

Teardown shadow root renderers on SlotAssignment::didChangeSlot
​https://bugs.webkit.org/show_bug.cgi?id=221386

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-09
Reviewed by Ryosuke Niwa.

This reverts r272900 to move the call to RenderTreeUpdater::tearDownRenderers() from hostChildElementDidChange()
to didChangeSlot(). This ensures the renderers are also cleared for other shadow root trees not using details
element.

• dom/SlotAssignment.cpp: (WebCore::SlotAssignment::addSlotElementByName): (WebCore::SlotAssignment::didChangeSlot):
• dom/SlotAssignment.h: (WebCore::ShadowRoot::hostChildElementDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276090] by Russell Epstein

• 4 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r275680. rdar://problem/76727557

Cache NSInvocation objects on _WKRemoteObjectInterface
​https://bugs.webkit.org/show_bug.cgi?id=224331
<rdar://75628393>

Reviewed by Geoffrey Garen.

Have _WKRemoteObjectInterface eagerly create the NSInvocation objects and store them
instead of re-constructing them every time they are needed.

• Shared/API/Cocoa/WKRemoteObjectCoder.mm: (decodeInvocation):
• Shared/API/Cocoa/_WKRemoteObjectInterface.mm: (methodArgumentTypeEncodingForSelector): (initializeMethod): (-[_WKRemoteObjectInterface debugDescription]): (classesForSelectorArgument): (-[_WKRemoteObjectInterface _invocationForSelector:]): (-[_WKRemoteObjectInterface _invocationForReplyBlockOfSelector:]): (-[_WKRemoteObjectInterface _allowedArgumentClassesForReplyBlockOfSelector:]):
• Shared/API/Cocoa/_WKRemoteObjectInterfaceInternal.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276089] by Russell Epstein

• 12 edits
  2 adds in branches/safari-611-branch

Cherry-pick r275656. rdar://problem/76727574

Update SFrame implementation to latest version
​https://bugs.webkit.org/show_bug.cgi?id=224276

Reviewed by Eric Carlson.

Source/WebCore:

Update implementation according to latest draft at ​https://github.com/eomara/sframe/blob/master/draft-omara-sframe.md.
In particular, we derive keys with new algorithm and the generation of the signature by including header and data length as well as nonce.

Test: webrtc/sframe-test-vectors.html

• Modules/mediastream/RTCRtpSFrameTransform.cpp: (WebCore::RTCRtpSFrameTransform::setCounterForTesting):
• Modules/mediastream/RTCRtpSFrameTransform.h:
• Modules/mediastream/RTCRtpSFrameTransformer.cpp: (WebCore::computeIV): (WebCore::RTCRtpSFrameTransformer::updateEncryptionKey): (WebCore::RTCRtpSFrameTransformer::decryptFrame): (WebCore::RTCRtpSFrameTransformer::encryptFrame): (WebCore::RTCRtpSFrameTransformer::computeEncryptedDataSignature):
• Modules/mediastream/RTCRtpSFrameTransformer.h:
• Modules/mediastream/RTCRtpSFrameTransformerCocoa.cpp: (WebCore::RTCRtpSFrameTransformer::computeSaltKey): (WebCore::createBaseSFrameKey): (WebCore::RTCRtpSFrameTransformer::computeAuthenticationKey): (WebCore::RTCRtpSFrameTransformer::computeEncryptionKey): (WebCore::encodeBigEndian): (WebCore::RTCRtpSFrameTransformer::computeEncryptedDataSignature):
• testing/Internals.cpp: (WebCore::Internals::setSFrameCounter):
• testing/Internals.h:
• testing/Internals.idl:

Tools:

Update tests according new way of deriving keys and generating the signature.

• TestWebKitAPI/Tests/WebCore/RTCRtpSFrameTransformerTests.cpp: (TestWebKitAPI::TEST):

LayoutTests:

• webrtc/sframe-test-vectors-expected.txt: Added.
• webrtc/sframe-test-vectors.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276088] by Russell Epstein

• 8 edits in branches/safari-611-branch/Source

Cherry-pick r275212. rdar://problem/76727522

Ensure that GlobalPropertyInfo is allocated on the stack.
​https://bugs.webkit.org/show_bug.cgi?id=223911
rdar://75865742

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

We rely on GlobalPropertyInfo being allocated on the stack to allow its JSValue
value to be scanned by the GC. Unfortunately, an ASAN compilation would choose
to allocate the GlobalPropertyInfo on a side buffer instead of directly on the
stack. This prevents the GC from doing the needed scan.

We'll fix this by suppressing ASAN on the functions that allocated GlobalPropertyInfo
arrays. Also added an ASSERT in the GlobalPropertyInfo constructor to assert that
it is allocated on the stack.

• Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py: (BuiltinsInternalsWrapperImplementationGenerator.generate_initialize_method):
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::initStaticGlobals): (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::exposeDollarVM):
• runtime/JSGlobalObject.h: (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo):

Source/WebCore:

• bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::addBuiltinGlobals):
• bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::finishCreation): (WebCore::JSDOMWindowBase::initStaticGlobals):
• bindings/js/JSDOMWindowBase.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:22 PM Changeset in webkit [276087] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r275130. rdar://problem/76727598

Dirty layout for floating children of inline on full layout
​https://bugs.webkit.org/show_bug.cgi?id=223660

Patch by Ian Gilbert <​iang@apple.com> on 2021-03-26
Reviewed by Zalan Bujtas.

Avoid consuming an object on an empty line when that object is floating or out-of-flow.

• rendering/line/BreakingContext.h: (WebCore::BreakingContext::handleEndOfLine):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:32 PM Changeset in webkit [276086] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Move the implementation of -[WKWebView themeColor] into the main WKWebView category
​https://bugs.webkit.org/show_bug.cgi?id=224628

Reviewed by Tim Horton.

Move the implementation of -themeColor out of the private category, and into the main category instead to
silence the warning.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView themeColor]):

4:32 PM Changeset in webkit [276085] by timothy_horton@apple.com

• 49 edits
  2 adds in trunk

Add a mechanism to dump the PlatformCALayer subtree of a GraphicsLayer, for testing
​https://bugs.webkit.org/show_bug.cgi?id=224595

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/harness/platform-layer-tree-as-text.html

Add internals.platformLayerTreeAsText(), which takes a (composited) Element
and returns the recursive PlatformCALayer tree under that element's backing
layer's primary layer.

This is intended to be used in a future patch in order to test a fix
that is only currently testable by observing the platform layer tree.
I've separated it from that patch in order to get the test rebaselining
out of the way in a behavior-neutral patch.

The motivation for a new method instead of a layerTreeAsText() flag
is this: if you make each GraphicsLayerCA dump its PlatformCALayers
(as a "show me the platform sublayers recursively" flag might do),
each GraphicsLayerCA also dumps its children's platform sublayers.
Thus the easiest way to get sane logging for testing is to target
the specific element you're interested in; thus, a new method.

• page/Frame.cpp:

(WebCore::Frame::layerTreeAsText const): Deleted.

• page/Frame.h:

Move layerTreeAsText to RenderLayerCompositor, where it probably belongs.

• page/Page.h: Fix a typo.

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::platformLayerTreeAsText const):

• platform/graphics/GraphicsLayerClient.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::purposeNameForInnerLayer const):
When dumping a PlatformCALayer, look up its purpose by checking which
layer member it is, instead of having it passed in. This way, we can
look it up even when we've reached this layer by crawling down the
PlatformCALayer tree.

(WebCore::GraphicsLayerCA::dumpInnerLayer const):
Clean up the PlatformCALayer dumping; make it multi-line and more
consistent with GraphicsLayer's dumping (a future patch will add more properties).

(WebCore::GraphicsLayerCA::dumpAdditionalProperties const):
Use dumpInnerLayer when dumping PlatformCALayers from a GraphicsLayer dump,
but with a bit set to disable dumping children, to maintain the exising output
and avoid each layer also dumping its children's platform layers, as mentioned above.

(WebCore::GraphicsLayerCA::platformLayerTreeAsText const):
(WebCore::dumpInnerLayer): Deleted.

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

Add a getter for the set of sublayers of a PlatformCALayerCocoa that
themselves have PlatformCALayers (thus the -forLogging; I didn't want
anybody to accidentally think that this gets *all* of the sublayers).

(WebCore::PlatformCALayerCocoa::sublayersForLogging):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingForLayerTreeAsTextDump):
Consolidate all of the pre-layer-tree-dumping setup work, so it can
be shared between layerTreeAsText and platformLayerTreeAsText.

(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::platformLayerTreeAsText):

• rendering/RenderLayerCompositor.h:
• testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText const):
Adopt the RenderLayerCompositor version of layerTreeAsText.
Don't bother doing layout, RenderLayerCompositor does it.

(WebCore::toPlatformLayerTreeFlags):
(WebCore::Internals::platformLayerTreeAsText const):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

Add a getter for the PlatformCALayer sublayers of PlatformCALayerRemote; see the note on PlatformCALayerCocoa.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::layerTreeAsText const):
Adopt the RenderLayerCompositor version of layerTreeAsText.

Source/WebKitLegacy/mac:

• WebView/WebFrame.mm:

(-[WebFrame _layerTreeAsText]):
Adopt the RenderLayerCompositor version of layerTreeAsText.

LayoutTests:

• fast/harness/platform-layer-tree-as-text-expected.txt: Added.
• fast/harness/platform-layer-tree-as-text.html: Added.

Add a test for the basic output of platformLayerTreeAsText().

• compositing/video/video-object-position-expected.txt:
• compositing/visible-rect/mask-layer-coverage-expected.txt:
• css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt:
• css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt:
• css3/filters/backdrop/backdrop-filter-with-cliprect-expected.txt:
• css3/filters/backdrop/backdrop-filter-with-mask-expected.txt:
• css3/filters/backdrop/backdrop-with-visibility-hidden-changing-expected.txt:
• css3/filters/backdrop/backdrop-with-visibility-hidden-expected.txt:
• css3/filters/backdrop/resource-use-add-more-layers-expected.txt:
• css3/filters/backdrop/resource-use-excessive-expected.txt:
• css3/filters/backdrop/resource-use-ok-expected.txt:
• css3/filters/backdrop/resource-use-remove-some-layers-expected.txt:
• fullscreen/full-screen-layer-dump-expected.txt:
• platform/ios/compositing/reflections/direct-image-object-fit-reflected-expected.txt:
• platform/ios/compositing/video/video-object-position-expected.txt:
• platform/ios/compositing/visible-rect/mask-layer-coverage-expected.txt:
• platform/ios/css3/filters/backdrop/backdrop-filter-does-not-size-properly-absolute-expected.txt:
• platform/ios/css3/filters/backdrop/backdrop-filter-with-cliprect-expected.txt:
• platform/ios/css3/filters/backdrop/backdrop-filter-with-mask-expected.txt:
• platform/mac/compositing/images/direct-image-object-fit-expected.txt:
• platform/mac/compositing/reflections/direct-image-object-fit-reflected-expected.txt:
• platform/mac/compositing/video/video-object-fit-expected.txt:

Rebaseline some tests to the new logging format.

• platform/gtk/TestExpectations:
• platform/win/TestExpectations:
• platform/wpe/TestExpectations:

Skip the new test on non-Cocoa ports.

4:10 PM Changeset in webkit [276084] by Wenson Hsieh

• 4 edits
  2 adds in trunk

[macOS] Support the Translate menu item in editable selected text
​https://bugs.webkit.org/show_bug.cgi?id=224625
<rdar://problem/76723022>

Reviewed by Tim Horton and Devin Rousso.

Source/WebCore:

Adjust some logic in ContextMenuController to ensure that the "Translate" context menu item shows up for
selected text in both editable and non-editable fields. To do this, we pull code for appending the menu items
out into a separate lambda function, which we use in both cases. This also allows us to remove some duplicated
code between the editable and non-editable codepaths.

Test: fast/events/contextmenu-actions-in-selected-text.html

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

Additionally, set selectedText and selectionBounds in both cases, as long as there is selected text.

LayoutTests:

Add a new layout test to verify that three context menu actions are consistent across selected text in editable
and non-editable content. This test is valid for all platforms where ENABLE(CONTEXT_MENUS) is set, regardless
of whether or not each individual action is supported.

• fast/events/contextmenu-actions-in-selected-text-expected.html: Added.
• fast/events/contextmenu-actions-in-selected-text.html: Added.
• platform/ios/TestExpectations:

4:04 PM Changeset in webkit [276083] by Sam Sneddon

• 4 edits in trunk/Tools

scm_unittest.py fails at import-time on Python 2
​https://bugs.webkit.org/show_bug.cgi?id=224627

Reviewed by Jonathan Bedard.

• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.repr): Add a repr for debug friendliness

• Scripts/webkitpy/init.py: pathlib2 never provides pathlib
• Scripts/webkitpy/common/checkout/scm/scm_unittest.py: ditto

3:58 PM Changeset in webkit [276082] by Jonathan Bedard

• 4 edits in trunk/Tools

style checker should warn about adding new PHP files
​https://bugs.webkit.org/show_bug.cgi?id=223905
<rdar://problem/76112036>

Reviewed by Youenn Fablet.

• Scripts/webkitpy/style/checker.py:

(CheckerDispatcher.is_valid_file): Check if a file has a file extension for an unsupported language.
(StyleProcessor.should_process): If a file has an extension of an unsupported language, report a
style error.

• Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherDispatchTest.test_text_paths): php files are now invalid extensions.
(CheckerDispatcherDispatchTest.test_none_paths): php files have no checker.
(StyleProcessor_CodeCoverageTest.MockDispatcher.is_valid_file):
(StyleProcessor_CodeCoverageTest.test_invalid_file): Check that an error is returned when checking
a file with an invalid extension.

• Scripts/webkitpy/style/checkers/cpp.py:

(CppChecker): Add a language rule.

3:44 PM Changeset in webkit [276081] by Sam Sneddon

• 5 edits in trunk/Tools

webkitpy classes need not define loads/dumps helpers for pickle
​https://bugs.webkit.org/show_bug.cgi?id=224620

Reviewed by Jonathan Bedard.

• Scripts/webkitpy/layout_tests/models/test_failures.py:

(TestFailure.loads): Deleted.
(TestFailure.dumps): Deleted.

• Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.assert_pickle_roundtrip):
(TestFailuresTest.test_pickle_roundtrip):

• Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.loads): Deleted.
(TestResult.dumps): Deleted.

• Scripts/webkitpy/layout_tests/models/test_results_unittest.py:

(TestResultsTest.test_pickle_roundtrip):

3:44 PM Changeset in webkit [276080] by Russell Epstein

• 4 edits
  2 adds in branches/safari-611-branch

Cherry-pick r275277. rdar://problem/76375504

Animated pseudo element style resolved against wrong parent style
​https://bugs.webkit.org/show_bug.cgi?id=223990
rdar://74997361

Reviewed by Antoine Quint.
Source/WebCore:

In createAnimatedElementUpdate we get the parent and parent box styles from the parent stack.
This is wrong for pseudo elements. Their parent style should the host style which is not pushed to the stack.

This matters in style adjuster which may apply wrong adjustments as a result.

Test: fast/animation/pseudo-element-style-adjuster.html

• style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): (WebCore::Style::TreeResolver::resolvePseudoStyle): (WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Make static and provide the parent and parent box styles as parameters.

• style/StyleTreeResolver.h:

LayoutTests:

• fast/animation/pseudo-element-style-adjuster-expected.html: Added.
• fast/animation/pseudo-element-style-adjuster.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [276079] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Null pointer dereference on MediaStreamAudioSourceNode destructor
​https://bugs.webkit.org/show_bug.cgi?id=224573

Patch by Ian Gilbert <​iang@apple.com> on 2021-04-15
Reviewed by Eric Carlson.

Source/WebCore:

Add null pointer check in case the capture source no longer exists.

Test: webaudio/destroy-audio-source-node-with-no-track-crash.html

• platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.cpp:

(WebCore::MediaStreamTrackAudioSourceProviderCocoa::hasNewClient):

LayoutTests:

Add regression test.

• webaudio/destroy-audio-source-node-with-no-track-crash-expected.txt: Added.
• webaudio/destroy-audio-source-node-with-no-track-crash.html: Added.

3:34 PM Changeset in webkit [276078] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Crash in ReplaceSelectionCommand::mergeEndIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=224587

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2021-04-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Return early in mergeEndIfNeeded() if either of our VisiblePositions are null.

Test: editing/inserting/insert-horizontal-rule-with-style-crash.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):

LayoutTests:

Add a test to catch the editing crash fixed here; thanks to Tuomas Karkkainen
for its basic structure and Ryosuke Niwa for some fixes.

• editing/inserting/insert-horizontal-rule-with-style-crash-expected.txt: Added.
• editing/inserting/insert-horizontal-rule-with-style-crash.html: Added.

3:27 PM Changeset in webkit [276077] by Manuel Rego Casasnovas

• 2 edits in trunk/Source/WebCore

Move FocusRemovalEventsMode into FocusOptions
​https://bugs.webkit.org/show_bug.cgi?id=224549
<rdar://problem/76695885>

Reviewed by Darin Adler.

Follow-up patch to use braces initializer for FocusOptions struct and simplify the code.

• dom/Document.cpp:

(WebCore::Document::adjustFocusedNodeOnNodeRemoval):

3:09 PM Changeset in webkit [276076] by Russell Epstein

• 19 edits in branches/safari-611-branch/Source

Cherry-pick r275485. rdar://problem/76412930

Make sure we no longer show the previous page when running a JS prompt
​https://bugs.webkit.org/show_bug.cgi?id=215782
<rdar://problem/67698601>

Reviewed by Darin Adler.

Source/WebCore:

Add linked-on-after check for the behavior change to minimize the risk of
breakage.

• platform/cocoa/VersionChecks.h:

Source/WebKit:

Make sure we no longer show the previous page when running a JS prompt.
If we have not yet done a layer tree commit since the last load commit, then
we are likely still showing the previous page. If we are asked to run a JS
prompt / alert / confirm at this point, it would be confusing to still show
the previous page. In order to address the issue, we now make the view blank
in such scenario (ideally, we'd have painted the new page but this is
currently not a trivial thing to do).

To make the view blank, the approach chosen is the set the opacity of our
root layer to 0 when the JS prompt is requested (before the first paint) and
set the opacity back to 1 after the first paint.

To minimize the risks of breakage, the behavior change is behind a
linked-on-after check. Also, we only trigger this behavior if the WKWebView
client actually implements the corresponding JS prompt delegate.

• UIProcess/Cocoa/UIDelegate.mm: (WebKit::UIDelegate::UIClient::runJavaScriptAlert): (WebKit::UIDelegate::UIClient::runJavaScriptConfirm): (WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
• UIProcess/PageClient.h: (WebKit::PageClient::makeViewBlank):
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::stopMakingViewBlankDueToLackOfRenderingUpdate): (WebKit::WebPageProxy::makeViewBlankIfUnpaintedSinceLastLoadCommit): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::runJavaScriptAlert):
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::makeViewBlank):
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::didCommitLayerTree):
• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm: (WebKit::PageClientImpl::makeViewBlank):
• UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::didUpdateRenderingAfterCommittingLoad):
• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::runJavaScriptAlert): (WebKit::WebChromeClient::runJavaScriptConfirm): (WebKit::WebChromeClient::runJavaScriptPrompt): Add flag to make sure pending async messages are processed *before* the JS prompt sync IPCs. Without this, it was possible for the UIProcess to receive the JS prompt IPC *before* the DidCommitLoadForFrame IPC, which would confuse our logic, since we would think this is a JS prompt for the previous page.

• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad):
• WebProcess/WebPage/WebPage.h: (WebKit::WebPage::sendSyncWithDelayedReply):
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::updateRendering):
• WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::didUpdateRendering):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [276075] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r274377. rdar://problem/76412582

AX: PDF frame conversion routines need to be updated
​https://bugs.webkit.org/show_bug.cgi?id=223138

Reviewed by Darin Adler.

PDF bounding boxes are wrong in WebKit because.

1) There's no way for PDF objects to get the primary screen height. So we need to be able to return the primary

screen height from an object in the PDF hierarchy.

2) The WKPDFPluginAccessibilityObject's position was not being converted correctly.

• WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]): (-[WKPDFPluginAccessibilityObject ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (WebKit::PDFPlugin::boundsOnScreen const):
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: (-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:40 PM Changeset in webkit [276074] by Russell Epstein

• 6 edits in branches/safari-611-branch/Source/WebKit

Apply patch. rdar://problem/76375364

2:37 PM Changeset in webkit [276073] by Ruben Turcios

• 1 copy in tags/Safari-612.1.11

Tag Safari-612.1.11.

2:13 PM Changeset in webkit [276072] by achristensen@apple.com

• 9 edits in trunk/Source

Add deprecation macros
​https://bugs.webkit.org/show_bug.cgi?id=224624

Source/ThirdParty/ANGLE:

• src/gpu_info_util/SystemInfo_macos.mm:

(angle::GetVendorIDFromMetalDeviceRegistryID):

Source/WebCore:

• platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::isAudioHardwareProcessRunning):
(WebCore::currentDeviceSupportedBufferSizes):
(WebCore::processIsRunningPropertyDescriptor):
(WebCore::outputDevicePropertyDescriptor):

• platform/audio/mac/AudioSessionMac.mm:

(WebCore::defaultDevice):
(WebCore::defaultDeviceTransportIsBluetooth):
(WebCore::AudioSessionPrivate::addSampleRateObserverIfNeeded):
(WebCore::AudioSessionPrivate::addBufferSizeObserverIfNeeded):
(WebCore::AudioSession::sampleRate const):
(WebCore::AudioSession::bufferSize const):
(WebCore::AudioSession::maximumNumberOfOutputChannels const):
(WebCore::AudioSession::setPreferredBufferSize):
(WebCore::AudioSession::isMuted const):
(WebCore::AudioSession::addMutedStateObserver):
(WebCore::AudioSession::removeMutedStateObserver):

• platform/graphics/mac/GraphicsChecksMac.cpp:

(WebCore::attachToAppleGraphicsControl):

• platform/mediastream/mac/CoreAudioCaptureDevice.cpp:

(WebCore::getDeviceInfo):
(WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice):
(WebCore::CoreAudioCaptureDevice::relatedAudioDeviceIDs):

• platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::deviceHasInputStreams):
(WebCore::deviceHasOutputStreams):
(WebCore::isValidCaptureDevice):
(WebCore::CoreAudioCaptureDeviceManager::coreAudioCaptureDevices):
(WebCore::computeAudioDeviceList):

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::defaultOutputDevice):

2:07 PM Changeset in webkit [276071] by graouts@webkit.org

• 3 edits in trunk/LayoutTests

calc() simplification for a multiplication should apply the multiplication to each value of an addition
​https://bugs.webkit.org/show_bug.cgi?id=224376

Reviewed by Dean Jackson.

Add a test for a multiplication with more than 2 values on the multiplied side such that
we check that we correctly handle a larger number of children in Add node than we did in
the Product node, which led to a crash in an earlier version of the patch that
landed for bug 224376 (r275793) but was then corrected in r275869.

• css3/calc/simplification-expected.txt:
• css3/calc/simplification.html:

1:31 PM Changeset in webkit [276070] by don.olmstead@sony.com

• 12 edits in trunk

ANGLE is only being built when WebGL is enabled
​https://bugs.webkit.org/show_bug.cgi?id=224555

Reviewed by Fujii Hironori.

.:

ANGLE should be built if either USE_ANGLE_EGL or ENABLE_WEBGL is ON.

• Source/CMakeLists.txt:

Source/WebCore:

Remove any ENABLE(WEBGL) guards that reference functionality that isn't WebGL specific.
Modify the CMakeLists file to build with USE_ANGLE_EGL when ENABLE_WEBGL is OFF.

• CMakeLists.txt:
• platform/graphics/GLContext.h:
• platform/graphics/angle/ANGLEHeaders.h:
• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::platformContext):

• platform/graphics/egl/GLContextEGL.h:
• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::platformContext):

• platform/graphics/glx/GLContextGLX.h:
• platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
• platform/graphics/opengl/TemporaryOpenGLSetting.h:

1:31 PM Changeset in webkit [276069] by mark.lam@apple.com

• 10 edits
  1 add in trunk/Source

Optimize the DeferTermination scope to be more efficient.
​https://bugs.webkit.org/show_bug.cgi?id=224619

Reviewed by Saam Barati.

Source/JavaScriptCore:

This can be beneficial since we may be using DeferTermination in more places in
the code.

1. Added a VMTrapsInlines.h to hold the inline functions.

2. Split deferTermination() and undoDeferTermination() into fast and slow functions. The fast functions are inlineable.

3. Remove the locking of VMTraps::m_lock in these functions. These functions only modify the following:
   1. VMTraps::m_deferTerminationCount
   2. VMTraps::m_suspendedTerminationException
   3. VMTraps::m_trapBits for setting the NeedTermination bit if needed.
   4. VM::m_exception

Except for VMTraps::m_trapBits, all of these are only written to from the mutator
thread. VMTraps::m_trapBits is always written to using Atomics. There isn't
anything that needs to be guarded by VMTraps::m_lock.

4. Fix VMTraps::deferTermination() to only set m_suspendedTerminationException and clear an existing TerminationException if it's being called from the outermost DeferTermination (i.e. m_deferTerminationCount is 1 after incrementing). These conditional operations are not done in VMTraps::deferTerminationSlow().

In practice, it wouldn't have mattered anyway because we would never throw a
TerminationException while a DeferTermination scope is in effect. The
the vm.isTerminationException() in the original deferTermination() would
always have prevented the slow path operations from being executed anyway.

However, for the purpose of this patch, we want to avoid as much unnecessary
work as possible in the fast path. Hence, it is good to skip the slow path
if deferTermination() isn't called from the outermost scope.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• jit/JITOperations.cpp:
• jsc.cpp:
• runtime/JSGlobalObject.cpp:
• runtime/VMTraps.cpp:

(JSC::VMTraps::deferTerminationSlow):
(JSC::VMTraps::undoDeferTerminationSlow):
(JSC::VMTraps::vm const): Deleted.
(JSC::VMTraps::deferTermination): Deleted.
(JSC::VMTraps::undoDeferTermination): Deleted.

• runtime/VMTraps.h:
• runtime/VMTrapsInlines.h: Added.

(JSC::VMTraps::vm const):
(JSC::VMTraps::deferTermination):
(JSC::VMTraps::undoDeferTermination):

Source/WebCore:

• workers/WorkerOrWorkletScriptController.cpp:

1:16 PM Changeset in webkit [276068] by Russell Epstein

• 11 edits
  4 deletes in branches/safari-611-branch

Revert "Cherry-pick r271879. rdar://problem/76375364"

1:16 PM Changeset in webkit [276067] by Russell Epstein

• 7 edits
  2 deletes in branches/safari-611-branch

Revert "Cherry-pick r272051. rdar://problem/76375364"

1:16 PM Changeset in webkit [276066] by Russell Epstein

• 13 edits
  1 copy
  2 moves
  2 adds in branches/safari-611-branch/Source

Revert "Cherry-pick r272196. rdar://problem/76375364"

1:15 PM Changeset in webkit [276065] by Russell Epstein

• 17 edits in branches/safari-611-branch

Revert "Cherry-pick r273848. rdar://problem/76375364"

1:15 PM Changeset in webkit [276064] by Russell Epstein

• 4 edits in branches/safari-611-branch/Tools

Revert "Cherry-pick r271794. rdar://problem/76375364"

1:15 PM Changeset in webkit [276063] by Russell Epstein

• 8 edits in branches/safari-611-branch

Revert "Cherry-pick r272195. rdar://problem/76375364"

1:15 PM Changeset in webkit [276062] by Russell Epstein

• 5 edits in branches/safari-611-branch/Source

Revert "Cherry-pick r272301. rdar://problem/76375364"

1:15 PM Changeset in webkit [276061] by Russell Epstein

• 10 edits in branches/safari-611-branch/Source

Revert "Cherry-pick r272010. rdar://problem/76375364"

1:15 PM Changeset in webkit [276060] by Russell Epstein

• 14 edits in branches/safari-611-branch

Revert "Cherry-pick r272009. rdar://problem/76375364"

1:15 PM Changeset in webkit [276059] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebKit

Revert "Cherry-pick r272138. rdar://problem/76375364"

1:15 PM Changeset in webkit [276058] by Russell Epstein

• 10 edits in branches/safari-611-branch/Source

Revert "Cherry-pick r272641. rdar://problem/76375364"

1:15 PM Changeset in webkit [276057] by Russell Epstein

• 6 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274862. rdar://problem/76416505

Nullptr crash in HTMLConverter::convert
​https://bugs.webkit.org/show_bug.cgi?id=221719

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-03-23
Reviewed by Ryosuke Niwa.

When the "Undo" command is called after DOM changes, one of the selection's position anchors
may have been moved to a new document. In that case, just clear the selection. Also add
asserts to ensure the selection is in good state after unapply and reapply commands.

• editing/CompositeEditCommand.cpp: (WebCore::EditCommandComposition::unapply): Add security assert to ensure selection is in good state. (WebCore::EditCommandComposition::reapply): Ditto.
• editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): If the selection's position anchors have been moved to a new document then just clear the selection. (WebCore::FrameSelection::isConnectedToDocument const): New method to verify that all the positions of the visible selection are in m_document.
• editing/FrameSelection.h: Declare new method.
• editing/VisibleSelection.cpp: (WebCore::VisibleSelection::document const): New method that returns a common document for all positions or nullptr otherwise.
• editing/VisibleSelection.h: Declare new method.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:42 PM Changeset in webkit [276056] by Russell Epstein

• 1 edit in branches/safari-611-branch/Source/WebCore/page/Quirks.cpp

Follow-up build-fix for rdar://problem/76373841

Remove duplicate line for trailers.apple.com quirk.

12:42 PM Changeset in webkit [276055] by Russell Epstein

• 10 edits in branches/safari-611-branch/Source

Cherry-pick r272641. rdar://problem/76375364

[SOUP] Simplify ResourceRequest and ResourceResponse
​https://bugs.webkit.org/show_bug.cgi?id=221543

Reviewed by Adrian Perez de Castro.

Source/WebCore:

There's unused code there and it can be refactored.

• ResourceRequest:
  • Remove unused member m_soupFlags.
  • Remove updateSoupMessage() that is always called after a SoupMessage has been created and add createSoupMessage() to return a new SoupMessage.
  • Set the message priority in the createSoupMessage() too.
  • Remove updateFromSoupMessage() that is curently used only by WebSockets to update the request headers after the request is sent to include cookies and other headers set by libsoup. We can simply use updateFromSoupMessageHeaders() for that case instead.

• ResourceResponse:
  • Remove unused member m_soupFlags.
  • Remove updateFromSoupMessage() that is always used with a newly created ResourceResponse and use the ResourceResponse constructor that receives a SoupMessage instead.
  • Sniffed content type is now received as an optional parameter of the ResourceResponse constructor that receives a SoupMessage, and used to set the MIME type and text encoding.
  • Remove unused certificate info getters and the encode/decode methods that are no longer needed.

• platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::encodeWithPlatformData const): (WebCore::ResourceRequest::decodeWithPlatformData):
• platform/network/soup/ResourceRequestSoup.cpp: (WebCore::toSoupMessagePriority): (WebCore::ResourceRequest::createSoupMessage const):
• platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::soupMessageCertificate const): (WebCore::ResourceResponse::soupMessageTLSErrors const):
• platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::updateSoupMessageHeaders const): (WebCore::ResourceResponse::updateFromSoupMessageHeaders):

Source/WebKit:

Use new ResourceRequest and ResourceResponse API.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::createRequest): Use ResourceRequest::createSoupMessage(). (WebKit::NetworkDataTaskSoup::didSendRequest): Use ResourceResponse passing the SoupMessage and sniffed content type. (WebKit::NetworkDataTaskSoup::didRequestNextPart): Create a ResourceResponse passing the url, content type, expected length and text encoding. Then call ResourceResponse::updateFromSoupMessageHeaders() to set the headers.
• NetworkProcess/soup/NetworkSessionSoup.cpp: (WebKit::NetworkSessionSoup::createWebSocketTask): Use ResourceRequest::createSoupMessage() and pass the ResourceRequest to WebSocketTask constructor.
• NetworkProcess/soup/WebSocketTaskSoup.cpp: (WebKit::WebSocketTask::WebSocketTask): Save the ResourceRequest and then just call ResourceRequest::updateFromSoupMessageHeaders() to update the headers after the response has been sent by libsoup. (WebKit::WebSocketTask::didConnect): Use ResourceResponse constructor with the SoupMessage directly. (WebKit::WebSocketTask::didFail): Ditto.
• NetworkProcess/soup/WebSocketTaskSoup.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:42 PM Changeset in webkit [276054] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebKit

Cherry-pick r272138. rdar://problem/76375364

[SOUP] Add support for data URLs in the network process
​https://bugs.webkit.org/show_bug.cgi?id=221127

Reviewed by Adrian Perez de Castro.

In r271879 I removed the support for data URLs in the network process for soup, assuming data URLs were always
loaded from the web process, but that's not the case for downloads. I think we should not go to the network
process for downloads either, but for now it's easier to fix this regression by supporting data URLs in the
network process again. Fixes http/tests/security/anchor-download-allow-data.html.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::createRequest): Return early if it's a data URL. (WebKit::NetworkDataTaskSoup::clearRequest): Clear the pending data URL result. (WebKit::NetworkDataTaskSoup::resume): Start a data URL decode task if it's a new data URL request, or complete the pending one. (WebKit::NetworkDataTaskSoup::didReadDataURL): Complete the data URL request.
• NetworkProcess/soup/NetworkDataTaskSoup.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:42 PM Changeset in webkit [276053] by Russell Epstein

• 14 edits in branches/safari-611-branch

Cherry-pick r272009. rdar://problem/76375364

Load data URLs in the web process also for synchronous loads
​https://bugs.webkit.org/show_bug.cgi?id=220981

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Add synchronous API for DataURLDecoder. It now uses a Vector<char> for the data instead of SharedBuffer. That
way, ResourceLoader can create the SharedBuffer from the given data and loader strategy can simply move it.

• Headers.cmake: Add DataURLDecoder.h.
• WebCore.xcodeproj/project.pbxproj: Mark DataURLDecoder.h as private.
• loader/ResourceLoader.cpp: (WebCore::ResourceLoader::loadDataURL): Adapt to the DataURLDecoder API changes.
• platform/network/DataURLDecoder.cpp: (WebCore::DataURLDecoder::parseMediaType): Update the data initialization. (WebCore::DataURLDecoder::decodeBase64): Return bool to indicate success or error and move the resulting vector instead of creating a SharedBuffer. (WebCore::DataURLDecoder::decodeEscaped): Move the resulting vector instead of creating a SharedBuffer. (WebCore::DataURLDecoder::decodeSynchronously): Helper to do the actual decoding synchronously. (WebCore::DataURLDecoder::decode): Use decodeSynchronously. (WebCore::DataURLDecoder::decode): Synchronous implementation.
• platform/network/DataURLDecoder.h:
• platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::dataURLResponse): Create a ResourceResponse for the given url and DataURLDecoder::Result.
• platform/text/DecodeEscapeSequences.h: (WebCore::decodeURLEscapeSequencesAsData): Use Vector<char> so that we can avoid data copies.

Source/WebKit:

In r271879 I removed the support for data URLs in the network process for soup, assuming data URLs were always
loaded from the web process, but that's not the case for synchronous loads.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::createRequest): Schedule an error if URL is not file or HTTP family.
• WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::loadDataURLSynchronously): Helper to load a Data URL synchronously. (WebKit::WebLoaderStrategy::loadResourceSynchronously): Call loadDataURLSynchronously for data URLs.
• WebProcess/Network/WebLoaderStrategy.h:

LayoutTests:

Remove expectations for tests that are no longer crashing.

• platform/glib/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:39 PM Changeset in webkit [276052] by graouts@webkit.org

• 12 edits in trunk

calc() should not contain 0 values other than percentages
​https://bugs.webkit.org/show_bug.cgi?id=224611

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Fix expectation of existing WPT tests and make some modifications to existing WPT tests.

• web-platform-tests/css/css-flexbox/parsing/flex-basis-computed-expected.txt:
• web-platform-tests/css/css-shapes/parsing/shape-outside-computed-expected.txt:
• web-platform-tests/css/css-shapes/parsing/shape-outside-computed.html: Add a new assertion checking

that the computed style for shape-outside may not contain 0px values in calc() values.

• web-platform-tests/css/css-transitions/animations/vertical-align-interpolation-expected.txt:
• web-platform-tests/css/css-transitions/animations/vertical-align-interpolation.html: Use 40% rather than

calc(0px + 40%) as the expected value for the computed style at the 100% keyframe when blending from 40px
to 40%. The test would have passed with calc(0px + 40%) as well, since it would now compute to 40%, but
the test is clearer when the actual computed form is used.

• web-platform-tests/css/css-values/minmax-percentage-serialize-expected.txt:

Source/WebCore:

A calc() value containing a 0px value, such as calc(10% + 0px), was incorrectly serialized
as-is for the computed style, instead of the simplified form containing on the percentage.

For the correct behavior we need to make four changes in css/CSSCalculationValue.cpp:

1. in createCSS(const CalcExpressionNode&, const RenderStyle&), when dealing with a node

that is CalcExpressionNodeType::Length, we return nullptr in the case then node's Length
is a 0 value that's not a percentage,

2. additionally, in createCSS(const Vector<std::unique_ptr<CalcExpressionNode>>&, const RenderStyle&),

we no longer bail when a nullptr value is returned for a child and instead proceed with the
processing of further children, ensuring that a 0px value in, say, a Sum operation is removed
while retaining other non-zero values,

3. back in createCSS(const CalcExpressionNode&, const RenderStyle&), for CalcExpressionNodeType::Operation

nodes, when there is single parameter to a Sum operation we return that parameter rather than
a Sum operation, and do the same for a Negate operation, making sure we return negated node if
it is the second child,

4. finally, in CSSCalcOperationNode::buildCSSText(const CSSCalcExpressionNode&, StringBuilder&)

when we serialize a calculated value, we do not enclose the value in a calc() string if the
node is a CSSCalcPrimitiveValueNode.

• css/CSSCalculationValue.cpp:

(WebCore::CSSCalcOperationNode::buildCSSText):
(WebCore::createCSS):

LayoutTests:

Adjust a non-WPT test to not feature a 0px addition.

• fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
• fast/shapes/shape-outside-floats/shape-outside-animation.html:

12:32 PM Changeset in webkit [276051] by Wenson Hsieh

• 7 edits in trunk

WKContentView should become focused without requiring -[WKWebView canBecomeFocused] to return YES
​https://bugs.webkit.org/show_bug.cgi?id=224613
<rdar://problem/76710314>

Reviewed by Tim Horton.

Source/WebKit:

Make a couple of minor tweaks to WKContentView's implementation of the UIFocus protocol methods.

Test: UIFocusTests.ContentViewCanBecomeFocused

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView canBecomeFocused]): Deleted.

Remove the ability for clients to influence -[WKContentView canBecomeFocused] by overriding `-[WKWebView
canBecomeFocused]. Apparently, making WKWebView` focusable by UIKit in addition to the content view causes the
web view to occasionally take first responder instead of the content view, which then breaks key event handling.

Instead, make it so that -[WKContentView canBecomeFocused] still returns NO by default, return YES for
internal clients that override the private UI delegate method -_webView:takeFocus:, and additionally introduce
a new delegate method, -_webViewCanBecomeFocused:, so that clients can make -[WKContentView canBecomeFocused]
return NO even if the delegate responds to -_webView:takeFocus:. This is because it doesn't make sense for a
WebKit client to allow UIKit's focus engine to (effectively) descend into web content without a way for the
embedder to handle the case where focus later ascends out of web content (and asks the UI delegate to take
focus).

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView canBecomeFocused]):
(-[WKContentView didUpdateFocusInContext:withAnimationCoordinator:]):

Also, make a minor adjustment here to avoid moving focus to the next or previous focusable element in the case
where focus is being moved _away from_ the content view, by consulting -[UIFocusUpdateContext nextFocusedView].

(-[WKContentView canBecomeFocusedForWebView]): Deleted.

Tools:

Adjust an existing API test so that it adopts the new UI delegate method.

• TestWebKitAPI/Tests/ios/UIFocusTests.mm:

(-[UIFocusDelegate _webViewCanTakeFocus:]):
(-[UIFocusDelegate _webView:takeFocus:]):
(TestWebKitAPI::TEST):
(-[UIFocusTestWKWebView canBecomeFocused]): Deleted.

12:26 PM Changeset in webkit [276050] by Russell Epstein

• 10 edits in branches/safari-611-branch/Source

Cherry-pick r272010. rdar://problem/76375364

[SOUP] Stop using SoupRequest API in preparation for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=220764

Reviewed by Adrian Perez de Castro.

Source/WebCore:

• platform/network/soup/ResourceError.h: Error constructors now receive the failing URL instead of a SoupRequest that is only used to get its URL.
• platform/network/soup/ResourceErrorSoup.cpp: (WebCore::ResourceError::transportError): (WebCore::ResourceError::httpError): (WebCore::ResourceError::genericGError):
• platform/network/soup/ResourceRequest.h: Remmove the constructor that receives a SoupRequest and the initiating page ID since it's currently unsused.
• platform/network/soup/ResourceRequestSoup.cpp:
• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

It's gone in libsoup3, we can just use soup_session_send_async() instead, which is what SoupRequest does
internally.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::createRequest): Manually create the SoupMessage. Also connect to content-sniffed signal that it was handled by SoupRequest internally. (WebKit::NetworkDataTaskSoup::clearRequest): Remove the SoupRequest reset and clear m_sniffedContentType. (WebKit::NetworkDataTaskSoup::resume): Use soup_session_send_async(). We need to know the message for passed to the function from the async ready callback, so we use a struct to pass both the task and the message. In case of being suspended the struct was attached to the pending result. (WebKit::NetworkDataTaskSoup::sendRequestCallback): Finish the soup_session_send_async() operation. (WebKit::NetworkDataTaskSoup::didSendRequest): Set the sniffed content type from m_sniffedContentType. (WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificate): Use SoupMessage instead of SoupRequest to get the URI. (WebKit::NetworkDataTaskSoup::didSniffContentCallback): Build the sniffed content type and call didSniffContent(). (WebKit::NetworkDataTaskSoup::didSniffContent): Save the passed content type. (WebKit::NetworkDataTaskSoup::continueAuthenticate): Use m_currentRequest instead of the SoupRequest to build the authentication error. (WebKit::NetworkDataTaskSoup::skipInputStreamForRedirectionCallback): Pass the failing URL to the ResourceError constructor. (WebKit::NetworkDataTaskSoup::continueHTTPRedirection): Ditto. (WebKit::NetworkDataTaskSoup::readCallback): Ditto. (WebKit::NetworkDataTaskSoup::requestNextPartCallback): Ditto.
• NetworkProcess/soup/NetworkDataTaskSoup.h:
• WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: Stop setting the initiating page ID in the request because it's unused.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:26 PM Changeset in webkit [276049] by Russell Epstein

• 1 edit in branches/safari-611-branch/Source/WebCore/page/Quirks.cpp

Unreviewed build fix after bad merge in rdar://problem/76373841

./page/Quirks.cpp:1305:14: error: redefinition of 'host'

12:26 PM Changeset in webkit [276048] by Russell Epstein

• 5 edits in branches/safari-611-branch/Source

Cherry-pick r272301. rdar://problem/76375364

[GTK][WPE] Reduce the use of SoupURI in preparation for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=221251

Reviewed by Adrian Perez de Castro.

Source/WebCore:

• platform/network/soup/AuthenticationChallengeSoup.cpp: (WebCore::protectionSpaceServerTypeFromURL): (WebCore::protectionSpaceFromSoupAuthAndURL): (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::protectionSpaceServerTypeFromURI): Deleted. (WebCore::protectionSpaceFromSoupAuthAndMessage): Deleted.

Source/WebKit:

• UIProcess/API/glib/WebKitURISchemeRequest.cpp: (webkit_uri_scheme_request_get_scheme): (webkit_uri_scheme_request_get_path):
• UIProcess/API/glib/WebKitWebView.cpp: (webkit_web_view_load_uri):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:26 PM Changeset in webkit [276047] by Russell Epstein

• 8 edits in branches/safari-611-branch

Cherry-pick r272195. rdar://problem/76375364

[GTK][WPE] Migrate WebKitTestServer to libsoup 2.48 API
​https://bugs.webkit.org/show_bug.cgi?id=219160
<rdar://problem/71620310>

Reviewed by Michael Catanzaro.

Source/WTF:

• wtf/Platform.h: Bump libsoup minimum required version to 2.54.

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: (serverCallback):
• TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: (serverCallback):
• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: (serverCallback):
• TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: (WebKitTestServer::WebKitTestServer): (WebKitTestServer::run): (WebKitTestServer::port const):
• TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:26 PM Changeset in webkit [276046] by Russell Epstein

• 4 edits in branches/safari-611-branch/Tools

Cherry-pick r271794. rdar://problem/76375364

Unreviewed, reverting r270074 and r270170.
​https://bugs.webkit.org/show_bug.cgi?id=220922

Broke all GLib unit tests using a SoupServer

Reverted changesets:

"[GTK] Migrate WebKitTestServer to libsoup 2.48 API"
​https://bugs.webkit.org/show_bug.cgi?id=219160
​https://trac.webkit.org/changeset/270074

"[GTK] Allow WebKitTestServer to run non-loopback addresses
for API tests"
​https://bugs.webkit.org/show_bug.cgi?id=219257
​https://trac.webkit.org/changeset/270170

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@271794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:26 PM Changeset in webkit [276045] by Russell Epstein

• 10 edits
  2 adds in branches/safari-611-branch

Cherry-pick r272928. rdar://problem/76416505

EventHandler::updateSelectionForMouseDownDispatchingSelectStart should not use an orphaned selection
​https://bugs.webkit.org/show_bug.cgi?id=221942

Reviewed by Wenson Hsieh.

Source/WebCore:

In r272777, we re-introduced a nullptr check in DOMSelection::getRangeAt as we were getting crash reports
in this code but we weren't sure of the root cause. Since then we've identified that one of the root causes
is that EventHandler::updateSelectionForMouseDownDispatchingSelectStart doesn't check if VisibleSelection
is still in a good state after dispatching selectstart event. This results in FrameSelection's
setSelectionWithoutUpdatingAppearance getting called with a selection with end points already being orphaned.

This patch fixes this bug in setSelectionWithoutUpdatingAppearance and also adds an additional check in
FrameSelection::setSelectionWithoutUpdatingAppearance itself to avoid using an orphaned selection. It also
introduces a number of release and debug assertions in a number of places to help catch similar bugs.

Test: editing/selection/click-selection-with-selectstart-node-removal.html

• dom/ContainerNode.cpp: (WebCore::ContainerNode::removeAllChildrenWithScriptAssertion): Added a debug-only assertion. (WebCore::ContainerNode::removeNodeWithScriptAssertion): Ditto.
• dom/Document.cpp: (WebCore::Document::removedLastRef): Disallow script execution in this code entirely. Also release assert that the selection had already been cleared by this point. (WebCore::Document::willBeRemovedFromFrame): Disallow script execution once we've unloaded subframes.
• editing/FrameSelection.cpp: (WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Return early if the new selection's end points had been orphaned, and disallow script execution between that and until we update the selection.
• editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isOrphan const): Added.
• editing/VisibleSelection.h:
• page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): Removed nullptr check added in r272777.
• page/EventHandler.cpp: (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart): Fixed what is now believed to be the root cause of the bug 221786.

LayoutTests:

Added a regression test for the bug 221786 / r272777.

Also updated a test imported from blink to expect rangeCount of 0 instead of 1
since we no longer update the selection when the target node has been removed
during selectstart.

• editing/selection/click-selection-with-selectstart-node-removal-expected.txt: Added.
• editing/selection/click-selection-with-selectstart-node-removal.html: Added.
• imported/blink/editing/selection/selectstart-event-crash.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:26 PM Changeset in webkit [276044] by Russell Epstein

• 5 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274819. rdar://problem/76373741

AVAudioSessionCaptureDeviceManager should use crossThreadCopy
​https://bugs.webkit.org/show_bug.cgi?id=223565
<rdar://75480589>

Reviewed by Youenn Fablet.

Tested manually, this can only be tested on device.

• platform/mediastream/CaptureDevice.h: Change access restriction for member variables from private: to protected: so derived classes can access them directly.

• platform/mediastream/ios/AVAudioSessionCaptureDevice.h:
• platform/mediastream/ios/AVAudioSessionCaptureDevice.mm: (WebCore::AVAudioSessionCaptureDevice::AVAudioSessionCaptureDevice): New constructor. (WebCore::AVAudioSessionCaptureDevice::isolatedCopy const): New.

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm: (WebCore::AVAudioSessionCaptureDeviceManager::refreshAudioCaptureDevices): Use WTFMove(deviceList).isolatedCopy() when moving from AVAudioSession queue to main thread. (WebCore::AVAudioSessionCaptureDeviceManager::getCaptureDevices): Ditto.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:25 PM Changeset in webkit [276043] by Russell Epstein

• 17 edits in branches/safari-611-branch

Cherry-pick r273848. rdar://problem/76375364

Use adoptNS() right away after calling [obj copy] / [obj mutableCopy]
​https://bugs.webkit.org/show_bug.cgi?id=222634

Reviewed by Darin Adler.

Use adoptNS() right away after calling [obj copy] / [obj mutableCopy] to minimize the chance of leaks.

Source/WebCore:

• editing/cocoa/HTMLConverter.mm: (defaultParagraphStyle):
• platform/cocoa/SystemVersion.mm: (WebCore::createSystemMarketingVersion): (WebCore::systemMarketingVersion):

Source/WebKit:

• Shared/ApplePay/ApplePayPaymentSetupFeatures.mm: (WebKit::PaymentSetupFeatures::decode):
• Shared/ApplePay/PaymentSetupConfiguration.mm: (WebKit::PaymentSetupConfiguration::decode):
• Shared/ApplePay/cocoa/PaymentSetupConfiguration.mm: (WebKitAdditions::PaymentSetupConfiguration::decode):
• UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::systemDirectoryPath):
• UIProcess/mac/ServicesController.mm: (WebKit::ServicesController::refreshExistingServices):
• UIProcess/mac/WebPageProxyMac.mm: (WebKit::temporaryPDFDirectoryPath):

Source/WebKitLegacy/mac:

• Misc/WebNSPasteboardExtras.mm: (_writableTypesForImageWithArchive):
• WebCoreSupport/WebApplicationCache.mm: (overrideBundleIdentifier): (+[WebApplicationCache initializeWithBundleIdentifier:]): (applicationCacheBundleIdentifier):
• WebView/WebPreferences.mm: (classIBCreatorID): (+[WebPreferences _setIBCreatorID:]): (+[WebPreferences _IBCreatorID]):

Tools:

• TestWebKitAPI/Tests/WebKit/mac/ContextMenuMouseEvents.mm: (TestWebKitAPI::runTest):
• TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:25 PM Changeset in webkit [276042] by Russell Epstein

• 13 edits
  2 moves
  3 deletes in branches/safari-611-branch/Source

Cherry-pick r272196. rdar://problem/76375364

[SOUP] Stop using SoupBuffer in preparation for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=221206

Reviewed by Sergio Villar Senin.

Source/WebCore:

Remove use of SoupBuffer from platform since it's now unused.

• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::DataSegment::data const): (WebCore::SharedBuffer::DataSegment::size const):
• platform/SharedBuffer.h:
• platform/Soup.cmake:
• platform/SourcesSoup.txt:
• platform/network/soup/GRefPtrSoup.cpp: Removed.
• platform/network/soup/GRefPtrSoup.h: Removed.
• platform/network/soup/GUniquePtrSoup.h:
• platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessageBody const):
• platform/soup/SharedBufferSoup.cpp: Removed.

Source/WebKit:

Use GBytes instead of SoupBuffer.

• NetworkProcess/cache/NetworkCacheData.h: (WebKit::NetworkCache::Data::bytes const):
• NetworkProcess/cache/NetworkCacheDataGLib.cpp: Renamed from Source/WebKit/NetworkProcess/cache/NetworkCacheDataSoup.cpp. (WebKit::NetworkCache::Data::Data): (WebKit::NetworkCache::Data::empty): (WebKit::NetworkCache::Data::data const): (WebKit::NetworkCache::Data::apply const): (WebKit::NetworkCache::Data::subrange const): (WebKit::NetworkCache::concatenate): (WebKit::NetworkCache::Data::adoptMap): (WebKit::NetworkCache::Data::tryCreateSharedMemory const):
• NetworkProcess/cache/NetworkCacheIOChannel.h:
• NetworkProcess/cache/NetworkCacheIOChannelGLib.cpp: Renamed from Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp. (WebKit::NetworkCache::runTaskInQueue): (WebKit::NetworkCache::fillDataFromReadBuffer): (WebKit::NetworkCache::inputStreamReadReadyCallback): (WebKit::NetworkCache::IOChannel::read): (WebKit::NetworkCache::IOChannel::readSyncInThread): (WebKit::NetworkCache::outputStreamWriteReadyCallback): (WebKit::NetworkCache::IOChannel::write):
• Shared/ShareableResource.cpp: (WebKit::ShareableResource::wrapInSharedBuffer):
• SourcesGTK.txt:
• SourcesWPE.txt:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:25 PM Changeset in webkit [276041] by Russell Epstein

• 7 edits
  2 adds in branches/safari-611-branch

Cherry-pick r272051. rdar://problem/76375364

[SOUP] Use a GInputStream to set the request body in preparation for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=221034

Reviewed by Adrian Perez de Castro.

Source/WebCore:

In libsoup3, the request body can be set using a stream. Add the stream now, that can still be used in libsoup2
to set the body data. This moves the FormData processing code to WebKitFormDataInputStream and also implements
the file seek and range length, which makes test http/tests/local/blob/send-hybrid-blob-using-open-panel.html pass.

• platform/SourcesSoup.txt:
• platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessageBody const):
• platform/network/soup/WebKitFormDataInputStream.cpp: Added. (webkitFormDataInputStreamCreateNextStream): (webkitFormDataInputStreamRead): (webkitFormDataInputStreamClose): (webkit_form_data_input_stream_class_init): (webkitFormDataInputStreamNew): (webkitFormDataInputStreamReadAll):
• platform/network/soup/WebKitFormDataInputStream.h: Added.

Tools:

Add WebKitFormDataInputStream as an exception for some style checker rules.

• Scripts/webkitpy/style/checker.py:

LayoutTests:

Remove expectations of http/tests/local/blob/send-hybrid-blob-using-open-panel.html that is now passing.

• platform/gtk/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@272051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:25 PM Changeset in webkit [276040] by Russell Epstein

• 11 edits
  5 adds in branches/safari-611-branch

Cherry-pick r271879. rdar://problem/76375364

[SOUP] Stop using SoupRequest API to load files in preparation for libsoup3
​https://bugs.webkit.org/show_bug.cgi?id=220509

Reviewed by Adrian Perez de Castro.

Source/WebCore/platform/gtk/po:

• POTFILES.in: Add WebKitDirectoryInputStream.cpp

Source/WebKit:

SoupRequest API is gone in libsoup3 and there's no replacement for file requests. GResource and data URI loads
already happen in the web process so we only need to care about file and directory loads.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::createRequest): Create a GFile for local files. (WebKit::NetworkDataTaskSoup::clearRequest): Clear the m_file. (WebKit::NetworkDataTaskSoup::resume): Check also if there's a file operation to resume. (WebKit::NetworkDataTaskSoup::didSendRequest): We always have a soup message now here because SoupRequest is only used for HTTP. (WebKit::NetworkDataTaskSoup::readCallback): In case of failure check if this is an HTTP or file request to create the error. (WebKit::NetworkDataTaskSoup::fileQueryInfoCallback): Call didGetFileInfo() and continue reading the file or directory. (WebKit::NetworkDataTaskSoup::didGetFileInfo): Set URL, content type and length of the response for the given GFileInfo. (WebKit::NetworkDataTaskSoup::readFileCallback): Complete the g_file_read_async operation. (WebKit::NetworkDataTaskSoup::enumerateFileChildrenCallback): Create a WebKitDirectoryInputStream. (WebKit::NetworkDataTaskSoup::didReadFile): Set the input stream and notify the response is ready.
• NetworkProcess/soup/NetworkDataTaskSoup.h:
• NetworkProcess/soup/Resources/directory.css: Added.
• NetworkProcess/soup/Resources/directory.js: Added.
• NetworkProcess/soup/WebKitDirectoryInputStream.cpp: Added. (webkitDirectoryInputStreamCreateHeader): (webkitDirectoryInputStreamCreateFooter): (webkitDirectoryInputStreamCreateRow): (webkitDirectoryInputStreamReadNextFile): (webkitDirectoryInputStreamRead): (webkitDirectoryInputStreamClose): (webkit_directory_input_stream_class_init): (webkitDirectoryInputStreamNew):
• NetworkProcess/soup/WebKitDirectoryInputStream.h: Added.
• PlatformGTK.cmake:
• PlatformWPE.cmake:
• SourcesGTK.txt:
• SourcesWPE.txt:

Tools:

Add WebKitDirectoryInputStream.cpp as exception for style checker.

• Scripts/webkitpy/style/checker.py:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@271879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:18 PM Changeset in webkit [276039] by mark.lam@apple.com

• 19 edits
  4 adds in trunk/Source

Refactor inline functions out of HashMapImpl.h into HashMapImplInlines.h.
​https://bugs.webkit.org/show_bug.cgi?id=224616
rdar://76713709

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Also do the same for clients of HashMapImpl that require similar refactoring.
This fixes the #include of JSCJSValueInlines.h in HashMapImpl.h, as well as makes
it easier to use other inline functions from other classes in the implementation
of HashMapImpl's inline functions in the future.

This patch only moves inline functions out to their respective *Inlines.h.
There are no behavior changes.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:
• dfg/DFGOperations.cpp:
• runtime/AbstractModuleRecord.cpp:
• runtime/HashMapImpl.cpp:
• runtime/HashMapImpl.h:

(JSC::areKeysEqual): Deleted.
(JSC::normalizeMapKey): Deleted.
(JSC::wangsInt64Hash): Deleted.
(JSC::jsMapHash): Deleted.
(JSC::concurrentJSMapHash): Deleted.
(JSC::shouldShrink): Deleted.
(JSC::shouldRehashAfterAdd): Deleted.
(JSC::nextCapacity): Deleted.
(JSC::HashMapImpl::finishCreation): Deleted.
(JSC::HashMapImpl::findBucket): Deleted.
(JSC::HashMapImpl::get): Deleted.
(JSC::HashMapImpl::has): Deleted.
(JSC::HashMapImpl::add): Deleted.
(JSC::HashMapImpl::addNormalized): Deleted.
(JSC::HashMapImpl::remove): Deleted.
(JSC::HashMapImpl::clear): Deleted.
(JSC::HashMapImpl::setUpHeadAndTail): Deleted.
(JSC::HashMapImpl::addNormalizedNonExistingForCloning): Deleted.
(JSC::HashMapImpl::addNormalizedInternal): Deleted.
(JSC::HashMapImpl::findBucketAlreadyHashedAndNormalized): Deleted.
(JSC::HashMapImpl::rehash): Deleted.
(JSC::HashMapImpl::checkConsistency const): Deleted.
(JSC::HashMapImpl::makeAndSetNewBuffer): Deleted.
(JSC::HashMapImpl::assertBufferIsEmpty const): Deleted.

• runtime/HashMapImplInlines.h: Added.

(JSC::areKeysEqual):
(JSC::normalizeMapKey):
(JSC::wangsInt64Hash):
(JSC::jsMapHash):
(JSC::concurrentJSMapHash):
(JSC::shouldShrink):
(JSC::shouldRehashAfterAdd):
(JSC::nextCapacity):
(JSC::HashMapImpl<HashMapBucketType>::finishCreation):
(JSC::HashMapImpl<HashMapBucketType>::findBucket):
(JSC::HashMapImpl<HashMapBucketType>::get):
(JSC::HashMapImpl<HashMapBucketType>::has):
(JSC::HashMapImpl<HashMapBucketType>::add):
(JSC::HashMapImpl<HashMapBucketType>::addNormalized):
(JSC::HashMapImpl<HashMapBucketType>::remove):
(JSC::HashMapImpl<HashMapBucketType>::clear):
(JSC::HashMapImpl<HashMapBucketType>::setUpHeadAndTail):
(JSC::HashMapImpl<HashMapBucketType>::addNormalizedNonExistingForCloning):
(JSC::HashMapImpl<HashMapBucketType>::addNormalizedInternal):
(JSC::HashMapImpl<HashMapBucketType>::findBucketAlreadyHashedAndNormalized):
(JSC::HashMapImpl<HashMapBucketType>::rehash):
(JSC::HashMapImpl<HashMapBucketType>::checkConsistency const):
(JSC::HashMapImpl<HashMapBucketType>::makeAndSetNewBuffer):
(JSC::HashMapImpl<HashMapBucketType>::assertBufferIsEmpty const):

• runtime/JSMap.h:
• runtime/JSMapInlines.h: Added.

(JSC::JSMap::set):

• runtime/JSSetInlines.h: Added.
• runtime/JSWeakMap.h:
• runtime/JSWeakMapInlines.h: Added.

(JSC::JSWeakMap::set):

• runtime/MapConstructor.cpp:
• runtime/MapPrototype.cpp:
• runtime/SetConstructor.cpp:
• runtime/WeakMapConstructor.cpp:
• runtime/WeakMapImpl.h:

(JSC::jsWeakMapHash): Deleted.
(JSC::nextCapacityAfterBatchRemoval): Deleted.
(JSC::WeakMapImpl::add): Deleted.
(JSC::WeakMapImpl::shouldRehashAfterAdd const): Deleted.
(JSC::WeakMapImpl::rehash): Deleted.

• runtime/WeakMapImplInlines.h:

(JSC::jsWeakMapHash):
(JSC::nextCapacityAfterBatchRemoval):
(JSC::WeakMapImpl<WeakMapBucket>::add):
(JSC::WeakMapImpl<WeakMapBucket>::rehash):
(JSC::WeakMapImpl<WeakMapBucket>::shouldRehashAfterAdd const):

• runtime/WeakMapPrototype.cpp:

Source/WebCore:

• bindings/js/SerializedScriptValue.cpp:

12:08 PM Changeset in webkit [276038] by Jonathan Bedard

• 4 edits in trunk/Tools

[results.webkit.org] Fully report git commits
​https://bugs.webkit.org/show_bug.cgi?id=224519
<rdar://problem/76619007>

Reviewed by Aakash Jain.

Rather than allowing the back-end to fully define commits associated with a test,
define those commits client side and post the result.

• Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Handle fully qualified commits.

• Scripts/webkitpy/port/base.py:

(Port.commits_for_upload): Fully define git commits.

• Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_commits_for_upload_git_svn):

11:50 AM Changeset in webkit [276037] by beidson@apple.com

• 8 edits in trunk

Move WKURLSchemeTask redirect API to SPI
​https://bugs.webkit.org/show_bug.cgi?id=224581

Reviewed by Alex Christensen.

Source/WebKit:

Need to work out some design kinks.

• UIProcess/API/Cocoa/WKURLSchemeTask.h:
• UIProcess/API/Cocoa/WKURLSchemeTask.mm:

(-[WKURLSchemeTaskImpl _willPerformRedirection:newRequest:completionHandler:]):
(-[WKURLSchemeTaskImpl willPerformRedirection:newRequest:completionHandler:]): Deleted.

• UIProcess/API/Cocoa/WKURLSchemeTaskPrivate.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration setURLSchemeHandler:forURLScheme:]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setURLSchemeHandlerForScheme):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

(-[TaskSchemeHandler webView:startURLSchemeTask:]):
(-[HTTPRedirectTest webView:startURLSchemeTask:]): Deleted.
(-[HTTPRedirectTest webView:stopURLSchemeTask:]): Deleted.

11:37 AM Changeset in webkit [276036] by Simon Fraser

• 4 edits in trunk/Source/WebKit

UI process can assert in DisplayLink::decrementFullSpeedRequestClientCount()
​https://bugs.webkit.org/show_bug.cgi?id=224388

Reviewed by Tim Horton.

The start/stop of m_wheelEventActivityHysteresis in WebPageProxy could cross
a process swap boundary, resulting in a decrement getting sent to the new DisplayLink/connection
pair for the new process, which asserted.

Fix by telling the DisplayLink about new processes when we're in an active wheel
event state.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::finishAttachingToWebProcess):
(WebKit::WebPageProxy::updateWheelEventActivityAfterProcessSwap):

• UIProcess/WebPageProxy.h:
• WebProcess/WebPage/mac/DisplayRefreshMonitorMac.cpp:

(WebKit::DisplayRefreshMonitorMac::startNotificationMechanism):
(WebKit::DisplayRefreshMonitorMac::stopNotificationMechanism):

11:08 AM Changeset in webkit [276035] by Alan Coon

• 1 copy in tags/Safari-612.1.10.4

Tag Safari-612.1.10.4.

10:59 AM Changeset in webkit [276034] by Alan Coon

• 8 edits in branches/safari-612.1.10-branch/Source

Versioning.

WebKit-7612.1.10.4

10:38 AM Changeset in webkit [276033] by achristensen@apple.com

• 4 edits in trunk/Source

Use WTF::Function instead of std::function in SVGPropertyAnimatorFactory::attributeAnimatorCreator
​https://bugs.webkit.org/show_bug.cgi?id=224586

Reviewed by Darin Adler.

Source/WebCore:

sizeof(WTF::Function<void()>) is 8.
sizeof(std::function<void()>) is 48.

• svg/properties/SVGPropertyAnimatorFactory.h:

(WebCore::SVGPropertyAnimatorFactory::attributeAnimatorCreator):

Source/WTF:

This requires something like r223122 until something like ​http://wg21.link/P1249 is accepted.
I also added a missing reserveInitialCapacity call that could reduce rehashing when constructing a HashMap from an initializer_list.

• wtf/HashMap.h:

10:25 AM Changeset in webkit [276032] by Alan Coon

• 1 copy in tags/Safari-612.1.10.3

Tag Safari-612.1.10.3.

10:23 AM Changeset in webkit [276031] by Alan Coon

• 10 edits in branches/safari-612.1.10-branch

Cherry-pick r275687. rdar://problem/76192721

REGRESSION(r273541) WKWebView can't load NSURLRequest subclasses
​https://bugs.webkit.org/show_bug.cgi?id=224338
Source/WebCore:

<rdar://76192721>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-08
Reviewed by Brent Fulgham.

We used to use SPI to extract the CFURLRequestRef, but now we just call encodeWithCoder and initWithCoder.
That's great for many reasons, but to stay binary compatible we have to continue to support NSURLRequest subclasses.
They fail in two possible ways:

1. In ObjC, you can do wild and crazy things such as overriding encodeWithCoder and not calling [super encodeWithCoder:coder];
2. The process decoding the request (one of our auxiliary processes) almost certainly has not linked with the definition of the subclass. This makes us receive an NSException like this when calling decodeObjectOfClasses:forKey:

* -[NSKeyedUnarchiver decodeObjectForKey:]: cannot decode object of class (TestURLRequest) for key (root) because no class named "TestURLRequest" was found;
the class needs to be defined in source code or linked in from a library (ensure the class is part of the correct target).
If the class was renamed, use setClassName:forClass: to add a class translation mapping to NSKeyedUnarchiver

To solve this problem, when attempting to encode a request that is not an NSURLRequest or NSMutableURLRequest, use existing code in ResourceRequest to extract
the parts we use into an NSMutableURLRequest that we can successfully decode.

• platform/network/cf/ResourceRequest.h:
• platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::replacePlatformRequest):

Source/WebKit:

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-08
Reviewed by Brent Fulgham.

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData):

Tools:

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-08
Reviewed by Brent Fulgham.

• TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm: (respond):
• TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm: (-[TestURLRequest initWithURL:]): (TestWebKitAPI::TEST):
• TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:22 AM Changeset in webkit [276030] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Cherry-pick r274877. rdar://problem/76373841

Enable the quirk to disable firing "webkitendfullscreen" event when a video enters picture-in-picture from fullscreen on espn.com
​https://bugs.webkit.org/show_bug.cgi?id=223610

Reviewed by Jer Noble.

A video element entering picture-in-picture from fullscreen will fire a "webkitendfullscreen"
event since r266728, but some sites (e.g., espn.com) do not handle the event properly.
Because they assume the video will resume to inline after exiting fullscreen.

This patch enables the quirk for espn.com to disable firing "webkitendfullscreen" event
in that scenario before they fix the issue in the event handler.

• page/Quirks.cpp: (WebCore::Quirks::shouldDisableEndFullscreenEventWhenEnteringPictureInPictureFromFullscreenQuirk const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@274877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:21 AM Changeset in webkit [276029] by Alan Coon

• 8 edits in branches/safari-612.1.10-branch/Source

Versioning.

WebKit-7612.1.10.3

10:18 AM Changeset in webkit [276028] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

[ MacOS wk2 ] webgl/1.0.3/conformance/glsl/functions/glsl-function-abs.html is flaky crashing
​https://bugs.webkit.org/show_bug.cgi?id=224612

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:51 AM Changeset in webkit [276027] by Russell Epstein

• 8 edits in branches/safari-611-branch/Source

Versioning.

WebKit-7611.2.4

9:50 AM Changeset in webkit [276026] by Wenson Hsieh

• 6 edits
  2 adds in trunk

[iOS] Image extraction fails in Google search results
​https://bugs.webkit.org/show_bug.cgi?id=224527
<rdar://problem/76500331>

Reviewed by Andy Estes.

Source/WebCore:

Override the -webkit-user-select CSS property in Google search results pages, and make a slight adjustment to
the user agent stylesheet.

Test: fast/images/image-extraction/image-overlay-in-image-with-zero-font-size.html

• html/HTMLElement.cpp:

(WebCore::HTMLElement::updateWithImageExtractionResult):

• html/shadow/imageOverlay.css:

(div#image-overlay):

Additionally force a default value for the font size and font family of the image overlay text, so that a
cascading font size of 0 won't end up breaking logic for computing image overlay CSS transforms. See layout test
for more details.

• page/Quirks.cpp:

(WebCore::Quirks::needsToForceUserSelectWhenInstallingImageOverlay const):

• page/Quirks.h:

LayoutTests:

Add a new layout test to exercise the user agent stylesheet change.

• fast/images/image-extraction/image-overlay-in-image-with-zero-font-size-expected-mismatch.html: Added.
• fast/images/image-extraction/image-overlay-in-image-with-zero-font-size.html: Added.

9:33 AM Changeset in webkit [276025] by Ruben Turcios

• 3 edits in branches/safari-612.1.11-branch/Source/JavaScriptCore

Cherry-pick r275924. rdar://problem/76707173

The watchdog should not fire when it's not active.
​https://bugs.webkit.org/show_bug.cgi?id=224494
rdar://76581259

Reviewed by Saam Barati and Yusuke Suzuki.

The watchdog is only active when we have entered the VM. If we haven't entered
the VM, we postpone starting the watchdog. For example, see Watchdog::enteredVM()
and Watchdog::exitedVM().

The underlying timer may still fire the NeedWatchdogCheck event after
Watchdog::stopTimer() is called. So, we need to just ignore the event if the
watchdog isn't active.

• runtime/VMTraps.cpp: (JSC::VMTraps::handleTraps):
• runtime/Watchdog.h: (JSC::Watchdog::isActive const):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:02 AM Changeset in webkit [276024] by Chris Gambrell

• 28 edits
  9 adds
  10 deletes in trunk/LayoutTests

[LayoutTests] Convert http/tests/media convert PHP to Python
​https://bugs.webkit.org/show_bug.cgi?id=224528
<rdar://problem/76627995>

Reviewed by Jonathan Bedard.

• http/tests/media/media-document-referer.html:
• http/tests/media/media-document.html:
• http/tests/media/media-play-stream-chunked-icy.html:
• http/tests/media/media-seeking-no-ranges-server.html:
• http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
• http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html:
• http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
• http/tests/media/modern-media-controls/skip-back-support/skip-back-support-live-broadcast.html:
• http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html:
• http/tests/media/modern-media-controls/time-control/1-to-10-hours.html:
• http/tests/media/modern-media-controls/time-control/10-hours-or-more.html:
• http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html:
• http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html:
• http/tests/media/resources/create-id3-db.php:
• http/tests/media/resources/hls/generate-vod.php: Removed.
• http/tests/media/resources/hls/generate-vod.py: Added.
• http/tests/media/resources/hls/playlist-with-cookie.m3u8:
• http/tests/media/resources/hls/sub-playlist-with-cookie.php: Removed.
• http/tests/media/resources/hls/sub-playlist-with-cookie.py: Added.
• http/tests/media/resources/hls/test-live.php: Removed.
• http/tests/media/resources/hls/test-live.py: Added.
• http/tests/media/resources/load-video.php: Removed.
• http/tests/media/resources/load-video.py: Added.
• http/tests/media/resources/serve-video.php: Removed.
• http/tests/media/resources/serve_video.py:

(answering):

• http/tests/media/resources/video-auth.php: Removed.
• http/tests/media/resources/video-auth.py: Added.
• http/tests/media/resources/video-check-useragent.php: Removed.
• http/tests/media/resources/video-check-useragent.py: Added.
• http/tests/media/resources/video-cookie-check-cookie.php: Removed.
• http/tests/media/resources/video-cookie-check-cookie.py: Added.
• http/tests/media/resources/video-referer-check-referer.php: Removed.
• http/tests/media/resources/video-referer-check-referer.py: Added.
• http/tests/media/video-auth-expected.txt:
• http/tests/media/video-auth-with-allowCrossOriginSubresourcesToAskForCredentials-expected.txt:
• http/tests/media/video-auth-with-allowCrossOriginSubresourcesToAskForCredentials.html:
• http/tests/media/video-auth.html:
• http/tests/media/video-cookie.html:
• http/tests/media/video-no-content-length-stall.html:
• http/tests/media/video-play-stall.html:
• http/tests/media/video-play-waiting.html:
• http/tests/media/video-query-url.html:
• http/tests/media/video-referer.html:
• http/tests/media/video-useragent.html:
• media/content/metadata.db: Removed.
• media/content/metadata.json: Added.

8:51 AM Changeset in webkit [276023] by Antti Koivisto

• 7 edits in trunk/Source/WebCore

Remove unused RunIterator::setAtEnd
​https://bugs.webkit.org/show_bug.cgi?id=224597

Reviewed by Zalan Bujtas.

• layout/integration/LayoutIntegrationLineIteratorLegacyPath.h:

(WebCore::LayoutIntegration::LineIteratorLegacyPath::atEnd const):
(WebCore::LayoutIntegration::LineIteratorLegacyPath::setAtEnd): Deleted.

• layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::atEnd const):
(WebCore::LayoutIntegration::LineIteratorModernPath::setAtEnd):

• layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::RunIterator::setAtEnd): Deleted.

• layout/integration/LayoutIntegrationRunIterator.h:
• layout/integration/LayoutIntegrationRunIteratorLegacyPath.h:

(WebCore::LayoutIntegration::RunIteratorLegacyPath::atEnd const):
(WebCore::LayoutIntegration::RunIteratorLegacyPath::setAtEnd): Deleted.

• layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::atEnd const):
(WebCore::LayoutIntegration::RunIteratorModernPath::setAtEnd):

8:48 AM Changeset in webkit [276022] by basuke.suzuki@sony.com

• 2 edits in trunk

Remove warnings caused by export g_config extern definition in WTFConfig.h
​https://bugs.webkit.org/show_bug.cgi?id=224462

Reviewed by Don Olmstead.

While building PlayStation port, lots of warnings are displayed:

WTF/Headers\wtf/WTFConfig.h:49:36: warning: redeclaration of 'WebConfig::g_config'
should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration]
extern "C" WTF_EXPORT_PRIVATE Slot g_config[];

bmalloc/Headers\bmalloc/GigacageConfig.h:38:17: note: previous declaration is here
extern "C" Slot g_config[];

This is because the two definitions are not same.
Becasue we can't solve the situation completely, we just ignore these warnings at
this morment.

• Source/cmake/OptionsPlayStation.cmake:

8:35 AM Changeset in webkit [276021] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[SOUP] Bring back the call to ResourceResponse::setDeprecatedNetworkLoadMetrics after r276008
​https://bugs.webkit.org/show_bug.cgi?id=224608

Reviewed by Adrian Perez de Castro.

It turns out it's actually still used by the inspector. I don't want to revert r276008 because it included other
fixes, so it's just fixed in this patch.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):

6:41 AM Changeset in webkit [276020] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Allow fast-cq as a prefix for patch name for fast-cq mode on commit-queue
​https://bugs.webkit.org/show_bug.cgi?id=224580

Reviewed by Jonathan Bedard.

• CISupport/ews-build/steps.py:

(BugzillaMixin):
(BugzillaMixin._is_patch_obsolete):

• CISupport/ews-build/steps_unittest.py: Updated unit-test.

6:02 AM Changeset in webkit [276019] by commit-queue@webkit.org

• 13 edits
  2 adds in trunk

[WebRTC][GStreamer] Build and use the openh264 based encoder if present on the system
​https://bugs.webkit.org/show_bug.cgi?id=202538
<rdar://problem/76047172>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-04-15
Reviewed by Xabier Rodriguez-Calvar.

.:

• Source/CMakeLists.txt:
• Source/cmake/GStreamerChecks.cmake:

Source/ThirdParty/libwebrtc:

In WPE/GTK we would like to have the libwebrtc openh264 encoder enabled if libopenh264 is
present on the host (eg not vendored).

• CMakeLists.txt:
• LibWebRTCWebKitMacros.h.in: Added.
• Source/webrtc/modules/video_coding/codecs/h264/h264.cc:
• Source/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc:
• Source/webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.h:
• cmake/FindOpenh264.cmake: Added.

Source/WebCore:

Enable the openh264 encoder if it is available, it would be preferred over existing
GStreamer H.264 encoders in such case.

• platform/mediastream/libwebrtc/GStreamerVideoCommon.cpp:

(WebCore::supportedH264Formats):

• platform/mediastream/libwebrtc/GStreamerVideoCommon.h:
• platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
• platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerVideoEncoderFactory::CreateVideoEncoder):
(WebCore::GStreamerVideoEncoderFactory::GetSupportedFormats const):

5:59 AM Changeset in webkit [276018] by youenn@apple.com

• 6 edits in trunk

Make RTCEncodedVideoFrameMetadata.contributingSources undefined until properly supported
​https://bugs.webkit.org/show_bug.cgi?id=224540

Reviewed by Eric Carlson.

Source/WebCore:

We are not yet ready to expose contributing sources for video.
It seems better to have the corresponding field be undefined instead of an empty array.

Covered by updated test.

• Modules/mediastream/RTCEncodedVideoFrame.idl:
• Modules/mediastream/RTCRtpTransformableFrame.h:
• Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp:

(WebCore::LibWebRTCRtpTransformableFrame::videoMetadata const):

LayoutTests:

• http/wpt/webrtc/metadata-transform.html:

4:14 AM Changeset in webkit [276017] by Chris Lord

• 18 edits
  2 adds in trunk/Source/WebCore

Make FontFace parsing worker-safe
​https://bugs.webkit.org/show_bug.cgi?id=224426

Reviewed by Darin Adler.

Make CSS FontFace property parsing safe to do in a Worker. Instead of
constructing a rule per property and using the full CSSPropertyParser
path, instead factor out the specific, necessary property parsers into a
new CSSPropertyParserWorkerSafe and make sure they're safe to use in a
Worker (mainly by allowing for specifying the CSSValuePool so that
main-thread singletons don't get used).

No new tests, no change in behavior.

• Sources.txt: Add CSSPropertyParserWorkerSafe.cpp/.h
• WebCore.xcodeproj/project.pbxproj:

• css/FontFace.cpp: Call setters with the ScriptExecutionContext so that we have access to ::cssValuePool() and use new worker-safe parser functions.

(WebCore::FontFace::create):
(WebCore::FontFace::setFamily):
(WebCore::FontFace::setStyle):
(WebCore::FontFace::setWeight):
(WebCore::FontFace::setStretch):
(WebCore::FontFace::setUnicodeRange):
(WebCore::FontFace::setFeatureSettings):
(WebCore::FontFace::setDisplay):

• css/FontFace.h:
• css/FontFace.idl:

• css/parser/CSSParser.cpp: Move WorkerSafe parsing functions to CSSPropertyParserWorkerSafe and remove now-unnecessary parseFontFaceDescriptor.
• css/parser/CSSParser.h:

• css/parser/CSSPropertyParser.cpp: Move FontFace property parsers to CSSPropertyParserWorkerSafe.

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeFont):

• css/parser/CSSPropertyParser.h:

• css/parser/CSSPropertyParserHelpers.cpp: Add WorkerSafe variants for some of the basic consume helpers.

(WebCore::CSSPropertyParserHelpers::CalcParser::CalcParser):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeInteger):
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumberWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumePercentWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeAngleWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeIdent):
(WebCore::CSSPropertyParserHelpers::consumeIdentWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeFontRaw):

• css/parser/CSSPropertyParserHelpers.h:

(WebCore::CSSPropertyParserHelpers::consumeIdent):
(WebCore::CSSPropertyParserHelpers::consumeIdentWorkerSafe):

• css/parser/CSSPropertyParserWorkerSafe.cpp: Added.

(WebCore::CSSPropertyParserWorkerSafe::parseFont):
(WebCore::CSSPropertyParserWorkerSafe::parseColor):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceSrc):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceStyle):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceWeight):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceStretch):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceUnicodeRange):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceFeatureSettings):
(WebCore::CSSPropertyParserWorkerSafe::parseFontFaceDisplay):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcLocal):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrc):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStyle):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStyleKeywordValue):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStyleRange):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontWeightAbsoluteKeywordValue):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontWeightAbsoluteRange):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontWeightAbsolute):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStretchKeywordValue):
(WebCore::CSSPropertyParserHelpersWorkerSafe::fontStretchIsWithinRange):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStretch):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontStretchRange):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFeatureTag):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFeatureSettings):
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceFontDisplay):

• css/parser/CSSPropertyParserWorkerSafe.h: Added.

• dom/ScriptExecutionContext.cpp: Add ::cssValuePool().

(WebCore::ScriptExecutionContext::cssValuePool):

• dom/ScriptExecutionContext.h:

• html/canvas/CanvasRenderingContext2D.cpp: Update due to refactoring.

(WebCore::CanvasRenderingContext2D::setFontWithoutUpdatingStyle):

• html/canvas/CanvasStyle.cpp:

(WebCore::parseColor):

• html/canvas/OffscreenCanvasRenderingContext2D.cpp:

(WebCore::OffscreenCanvasRenderingContext2D::setFont):

• workers/WorkerGlobalScope.h:

4:01 AM Changeset in webkit [276016] by Manuel Rego Casasnovas

• 7 edits in trunk/Source/WebCore

Move FocusRemovalEventsMode into FocusOptions
​https://bugs.webkit.org/show_bug.cgi?id=224549

Reviewed by Darin Adler.

This patch is just a refactoring that moves FocusRemovalEventsMode enum into FocusOptions.
This allows us to simplify some method signatures, as they'll just receive a FocusOptions parameter, instead of two parameters for FocusRemovalEventsMode and FocusDirection.

There is no change of behavior, just a code refactoring.

• dom/Document.cpp:

(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
(WebCore::Document::setFocusedElement):

• dom/Document.h:

(WebCore::Document::setFocusedElement):

• dom/Element.cpp:

(WebCore::Element::focus):

• dom/FocusOptions.h:
• page/FocusController.cpp:

(WebCore::FocusController::setFocusedElement):

• page/FocusController.h:

(WebCore::FocusController::setFocusedElement):

3:59 AM Changeset in webkit [276015] by svillar@igalia.com

• 2 edits in trunk/Source/WebCore

Empty value is added in codePointsFromString in CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts
​https://bugs.webkit.org/show_bug.cgi?id=223857

Reviewed by Darin Adler.

Use UnsignedWithZeroKeyHashTraits in codePointsFromString() to avoid it.

• css/CSSFontFaceSet.cpp:

(WebCore::codePointsFromString):

3:07 AM Changeset in webkit [276014] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[RenderTreeBuilder] Cleanup the inline tree when moving subtrees
​https://bugs.webkit.org/show_bug.cgi?id=224342
<rdar://76349279>

Reviewed by Antti Koivisto.

When an inline box is moved over to a different BFC (<span>), any inline level descendant (<span><img></span>) should be invalidated. The safest way to do this is
to destroy the inline tree (the "subtree moving" will eventually be replaced by "destroy followed by construct" activity).

• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::move):

2:10 AM Changeset in webkit [276013] by youenn@apple.com

• 19 edits in trunk

Update RTCScriptTransform constructor up to spec
​https://bugs.webkit.org/show_bug.cgi?id=224447

Reviewed by Eric Carlson.

Source/WebCore:

Remove built-in support for message ports in RTCRtpScriptTransform/RTCRtpScriptTransformer.
Instead pass a transfer object to RTCRtpScriptTransform constructor used jointly with options to enable the same behavior.
This aligns with the change made in ​https://github.com/w3c/webrtc-encoded-transform/pull/96.

Covered by updated tests.

• Modules/mediastream/RTCRtpScriptTransform.cpp:

(WebCore::RTCRtpScriptTransform::create):
(WebCore::RTCRtpScriptTransform::RTCRtpScriptTransform):

• Modules/mediastream/RTCRtpScriptTransform.h:
• Modules/mediastream/RTCRtpScriptTransform.idl:
• Modules/mediastream/RTCRtpScriptTransformer.cpp:

(WebCore::RTCRtpScriptTransformer::create):
(WebCore::RTCRtpScriptTransformer::RTCRtpScriptTransformer):
(WebCore::RTCRtpScriptTransformer::options):

• Modules/mediastream/RTCRtpScriptTransformer.h:

(WebCore::RTCRtpScriptTransformer::port): Deleted.

• Modules/mediastream/RTCRtpScriptTransformer.idl:
• workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::createRTCRtpScriptTransformer):

• workers/DedicatedWorkerGlobalScope.h:
• workers/Worker.cpp:

(WebCore::Worker::createRTCRtpScriptTransformer):

• workers/Worker.h:

LayoutTests:

• http/wpt/webrtc/audio-script-transform.html:
• http/wpt/webrtc/context-transform.js:

(MockRTCRtpTransformer):
(MockRTCRtpTransformer.prototype.start):
(MockRTCRtpTransformer.prototype.process):

• http/wpt/webrtc/metadata-transform-worker.js:
• http/wpt/webrtc/script-transform.js:
• http/wpt/webrtc/video-script-transform.html:
• http/wpt/webrtc/webrtc-transform.html:
• http/wpt/webrtc/write-twice-transform.js:

2:07 AM Changeset in webkit [276012] by youenn@apple.com

• 4 edits
  3 adds in trunk

REGRESSION(Safari 14): iframe with blob url does not work with sandboxing
​https://bugs.webkit.org/show_bug.cgi?id=222312
<rdar://problem/74927624>

Reviewed by Chris Dumez.

Source/WebCore:

In ​https://trac.webkit.org/r275884, we correctly compute whether a blob is to be considered secure or not.
For that, we need to have the blob URL registered with its document origin.
Update PolicyChecker to properly register the temporoary blob URL with its document origin.

Test: http/tests/security/sandbox-iframe-and-blob.https.html

• loader/PolicyChecker.cpp:

(WebCore::FrameLoader::PolicyChecker::extendBlobURLLifetimeIfNecessary const):

LayoutTests:

• http/tests/security/resources/sandbox-iframe-and-blob-frame.html: Added.
• http/tests/security/sandbox-iframe-and-blob.https-expected.txt: Added.
• http/tests/security/sandbox-iframe-and-blob.https.html: Added.
• platform/win/TestExpectations:

2:00 AM Changeset in webkit [276011] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening. Several tests are failing after async scrolling was activated in r275593.

• platform/wpe/TestExpectations:

1:43 AM Changeset in webkit [276010] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange
​https://bugs.webkit.org/show_bug.cgi?id=222720

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-15
Reviewed by Ryosuke Niwa.

This patch reverts r274064 to apply a different fix. Instead of null-checking the nodes returned by
SlotAssignment::assignedNodesForSlot(), assigned nodes are removed from the list when they are about to be
removed from the parent. That ensures we never return nullptr nodes nor nodes with a nullptr parent from the
assigned nodes vector.

• dom/ComposedTreeIterator.cpp:

(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::advanceInSlot):

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeBetween):

• dom/Node.h:

(WebCore::Node::hasShadowRootContainingSlots const):
(WebCore::Node::setHasShadowRootContainingSlots):

• dom/ShadowRoot.h:
• dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::willRemoveAssignedNode):

• dom/SlotAssignment.h:

(WebCore::ShadowRoot::willRemoveAssignedNode):

1:34 AM Changeset in webkit [276009] by Carlos Garcia Campos

• 4 edits in trunk

[SOUP] Add support for "nextHopProtocol" for Resource Timing
​https://bugs.webkit.org/show_bug.cgi?id=168543

Reviewed by Adrian Perez de Castro.

Source/WebKit:

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didGetHeaders): Set NetworkLoadMetrics::protocol.

LayoutTests:

Remove passing tests from expectations.

• platform/glib/TestExpectations:

1:30 AM Changeset in webkit [276008] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit

[SOUP] Stop using ResourceResponse::setDeprecatedNetworkLoadMetrics
​https://bugs.webkit.org/show_bug.cgi?id=224541

Reviewed by Adrian Perez de Castro.

We are already providing the metrics via didCompleteWithError(). Also make sure we set fetchStart and use it
instead of a member.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
(WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::networkEvent):
(WebKit::NetworkDataTaskSoup::didStartRequest):
(WebKit::NetworkDataTaskSoup::didRestart):

• NetworkProcess/soup/NetworkDataTaskSoup.h:

12:37 AM Changeset in webkit [276007] by Chris Dumez

• 8 edits in trunk

REGRESSION(r275921-r275922): [ wk2 ] http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=224566
<rdar://problem/76657007>

Reviewed by Tim Horton.

Source/WebKit:

r275921-r275922 changed the timing of when the WebProcess/RemoteRenderingBackendProxy sends the GPUConnectionToWebProcess::CreateRenderingBackend
IPC to the GPUProcess. This IPC used to get sent as soon as the RemoteRenderingBackendProxy was constructed. However, I delayed sending it until
the RemoteRenderingBackendProxy actually needs to create an ImageBuffer to avoid launching the GPUProcess prematurely.

Unfortunately, this exposed a pre-existing synchronization issue with regards to the RemoteRenderingBackend IPC. In particular, the
GPUConnectionToWebProcess::CreateRenderingBackend was getting sent asynchronously and processed by the GPUProcess on the main thread. This would
cause the creation of the RemoteRenderingBackend object on the GPUProcess side, which would then register itself as a WorkQueueMessageReceiver.
The issue is that the WebProcess was sending the RemoteRenderingBackend IPC so quickly after the CreateRenderingBackend IPC that when the IPC is
received (on the IPC thread), the RemoteRenderingBackend has not had a change to register itself as a WorkQueueMessageReceiver yet. As a result,
some of the early IPC was getting dispatched to the main thread and later IPC would get sent to the RemoteRenderingBackend WorkQueue. This was
causing RemoteRenderingBackend to get processed out of order.

To address the synchronization issue for now, I made the GPUConnectionToWebProcess::CreateRenderingBackend synchronous. This may not be the
best design long term but it is an easy and safe way to resolve this for now. It makes sure the WebProcess cannot send RemoteRenderingBackend
IPC until after the GPUProcess has created the RemoteRenderingBackend and the RemoteRenderingBackend object has registered itself as a
WorkQueueMessageReceiver. We probably want to follow-up when we come up with a better design. For now though, I have verified locally that this
fixes the out of order IPC messaging AND the flaky crashes on these canvas tests.

No new tests, unskipped existing tests that are no longer flaky.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::createRenderingBackend):

• GPUProcess/GPUConnectionToWebProcess.h:
• GPUProcess/GPUConnectionToWebProcess.messages.in:
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::ensureGPUProcessConnection):

LayoutTests:

Unskip layout tests that should no longer be flaky.

• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

12:34 AM Changeset in webkit [276006] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Deploy Ref/RefPtr in ReplaceSelectionCommand
​https://bugs.webkit.org/show_bug.cgi?id=224591

Reviewed by Jiewen Tan.

Deployed Ref/RefPtr in ReplaceSelectionCommand.cpp per guidelines we outlined in
​https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html

• editing/ReplaceSelectionCommand.cpp:

(WebCore::positionAvoidingPrecedingNodes):
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeUnrenderedNodes):
(WebCore::ReplacementFragment::removeInterchangeNodes):
(WebCore::ReplaceSelectionCommand::shouldMerge):
(WebCore::fragmentNeedsColorTransformed): Protected the code accessing the render tree
with ScriptDisallowedScope::InMainThread.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent const):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::enclosingInline):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace const):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::singleChildList):
(WebCore::deepestSingleChildList):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

12:03 AM Changeset in webkit [276005] by ysuzuki@apple.com

• 18 edits in trunk/Source/JavaScriptCore

[JSC] Change Vector<> to FixedVector<> in DFG::CommonData if possible
​https://bugs.webkit.org/show_bug.cgi?id=224588

Reviewed by Mark Lam.

DFG::CommonData is kept alive so long as DFG code exists. It includes a lot of Vectors while they are not mutable after the DFG code compilation.
This patch changes Vector<> to FixedVector<> if possible to shrink sizeof(DFG::CommonData). And this also removes the need of calling shrinkToFit
explicitly for them.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::numberOfDFGIdentifiers const):
(JSC::CodeBlock::identifier const):

• bytecode/CodeBlock.h:
• dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):
(JSC::DFG::CommonData::invalidate):
(JSC::DFG::CommonData::~CommonData):
(JSC::DFG::CommonData::installVMTrapBreakpoints):
(JSC::DFG::CommonData::isVMTrapBreakpoint):
(JSC::DFG::CommonData::finalizeCatchEntrypoints):
(JSC::DFG::CommonData::notifyCompilingStructureTransition): Deleted.

• dfg/DFGCommonData.h:

(JSC::DFG::CommonData::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::CommonData::appendCatchEntrypoint): Deleted.

• dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

• dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::DesiredTransition):
(JSC::DFG::DesiredTransitions::DesiredTransitions):
(JSC::DFG::DesiredTransitions::addLazily):
(JSC::DFG::DesiredTransitions::reallyAdd):
(JSC::DFG::DesiredTransition::reallyAdd): Deleted.

• dfg/DFGDesiredTransitions.h:
• dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

• dfg/DFGGraph.h:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):

• dfg/DFGOSREntry.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutStructure):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileInvalidationPoint):

Apr 14, 2021:

11:23 PM Changeset in webkit [276004] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update tests expected to fail but passing.

• platform/gtk/TestExpectations:

11:17 PM Changeset in webkit [276003] by Antti Koivisto

• 9 edits
  2 adds in trunk/Source/WebCore

Preloaded async scripts should use the same priority as the normally loaded ones
​https://bugs.webkit.org/show_bug.cgi?id=224537

Reviewed by Sam Weinig.

Use the same priority (medium instead of low) when preloading.

Factor default priorities to a separate type making it easier to keep them in sync.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::load):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

• loader/DefaultResourceLoadPriority.cpp: Added.

(WebCore::DefaultResourceLoadPriority::forResourceType):

• loader/DefaultResourceLoadPriority.h: Added.
• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::setLoadPriority):
(WebCore::CachedResource::defaultPriorityForResourceType): Deleted.

• loader/cache/CachedResource.h:

(WebCore::CachedResource::identifierForLoadWithoutResourceLoader const):

11:15 PM Changeset in webkit [276002] by commit-queue@webkit.org

• 10 edits in trunk

Omit default position/angle when serializing radial & conic gradients
​https://bugs.webkit.org/show_bug.cgi?id=223892

Patch by Tim Nguyen <​ntim@apple.com> on 2021-04-14
Reviewed by Antti Koivisto.

Test: LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html

LayoutTests/imported/w3c:

• web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:

Source/WebCore:

• css/CSSGradientValue.cpp:

(WebCore::ConicGradientAdapter::normalizeStopsAndEndpointsOutsideRange):
(WebCore::CSSLinearGradientValue::customCSSText const):
(WebCore::CSSRadialGradientValue::customCSSText const):
(WebCore::CSSConicGradientValue::customCSSText const):

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::isCenterPosition const):

• css/CSSPrimitiveValue.h:

LayoutTests:

• fast/gradients/unprefixed-gradient-parsing-expected.txt:
• fast/gradients/unprefixed-gradient-parsing.html:
• http/wpt/css/css-images-4/conic-gradient-parsing.html:

10:55 PM Changeset in webkit [276001] by don.olmstead@sony.com

• 3 edits in trunk/Source/WebCore

[Nicosia] NicosiaGCGLLayer is unneeded when ENABLE_WEBGL is OFF
​https://bugs.webkit.org/show_bug.cgi?id=224557

Reviewed by Michael Catanzaro.

Add an ENABLE(WEBGL) guard around NicosiaGCGLLayer.

• platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:
• platform/graphics/nicosia/texmap/NicosiaGCGLLayer.h:

10:53 PM Changeset in webkit [276000] by mark.lam@apple.com

• 3 edits
  1 add in trunk

Add missing exception check in operationGetPrivateNameOptimize().
​https://bugs.webkit.org/show_bug.cgi?id=224592
rdar://76645873

Reviewed by Yusuke Suzuki.

JSTests:

• stress/suppress-TerminationException-in-operationGetPrivateNameOptimize.js: Added.

Source/JavaScriptCore:

Though the fieldNameValue.toPropertyKey() call in operationGetPrivateNameOptimize()
would not normally throw an exception, it still can throw a TerminationException
because it contains RETURN_IF_EXCEPTION checks.

• jit/JITOperations.cpp:

10:44 PM Changeset in webkit [275999] by Diego Pino Garcia

• 16 edits
  2 copies
  13 adds in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening. Add missing images after r275996.

• platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
• platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.png:
• platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.png:
• platform/gtk/fast/css/child-style-can-override-visited-style-expected.png:
• platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.png:
• platform/gtk/fast/images/image-map-anchor-children-expected.png:
• platform/gtk/fast/inline-block/003-expected.png:
• platform/gtk/fast/inline/002-expected.png:
• platform/gtk/fast/invalid/018-expected.png:
• platform/gtk/fast/table/frame-and-rules-expected.png:
• platform/gtk/fast/table/table-display-types-strict-expected.png:
• platform/gtk/fast/text/basic/012-expected.png:
• platform/gtk/svg/custom/invisible-text-after-scrolling-expected.png:
• platform/gtk/tables/mozilla/bugs/bug14323-expected.png:
• platform/gtk/tables/mozilla/bugs/bug2267-expected.png:
• platform/wpe/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
• platform/wpe/fast/block/margin-collapse/block-inside-inline/001-expected.png: Added.
• platform/wpe/fast/block/margin-collapse/block-inside-inline/005-expected.png: Added.
• platform/wpe/fast/css/child-style-can-override-visited-style-expected.png: Added.
• platform/wpe/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
• platform/wpe/fast/images/image-map-anchor-children-expected.png: Added.
• platform/wpe/fast/inline-block/003-expected.png: Added.
• platform/wpe/fast/inline/002-expected.png: Added.
• platform/wpe/fast/invalid/018-expected.png: Added.
• platform/wpe/fast/table/frame-and-rules-expected.png: Added.
• platform/wpe/fast/table/table-display-types-strict-expected.png: Added.
• platform/wpe/fast/text/basic/012-expected.png: Added.
• platform/wpe/svg/custom/invisible-text-after-scrolling-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug14323-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug2267-expected.png: Added.

8:44 PM Changeset in webkit [275998] by Diego Pino Garcia

• 44 edits
  1 move
  34 adds in trunk/LayoutTests

[WPE] Unreviewed test gardening. Update stale baselines.

Also add missing .png images.

• platform/gtk/fast/css/word-space-extra-expected.png: Renamed from LayoutTests/platform/glib/fast/css/word-space-extra-expected.png.
• platform/wpe/css1/box_properties/border-expected.png: Added.
• platform/wpe/css1/box_properties/border-expected.txt:
• platform/wpe/css1/text_properties/text_decoration-expected.png: Added.
• platform/wpe/css1/text_properties/text_decoration-expected.txt:
• platform/wpe/css1/text_properties/vertical_align-expected.png: Added.
• platform/wpe/css1/text_properties/vertical_align-expected.txt:
• platform/wpe/css1/text_properties/word_spacing-expected.txt:
• platform/wpe/fast/block/basic/014-expected.png: Added.
• platform/wpe/fast/block/basic/014-expected.txt:
• platform/wpe/fast/block/positioning/057-expected.png: Added.
• platform/wpe/fast/block/positioning/057-expected.txt:
• platform/wpe/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
• platform/wpe/fast/css-generated-content/after-duplicated-after-split-expected.txt:
• platform/wpe/fast/css/word-space-extra-expected.png:
• platform/wpe/fast/css/word-space-extra-expected.txt:
• platform/wpe/fast/encoding/utf-16-big-endian-expected.png: Added.
• platform/wpe/fast/encoding/utf-16-big-endian-expected.txt:
• platform/wpe/fast/inline/drawStyledEmptyInlines-expected.png: Added.
• platform/wpe/fast/inline/drawStyledEmptyInlines-expected.txt:
• platform/wpe/fast/invalid/missing-end-tag-expected.png: Added.
• platform/wpe/fast/invalid/missing-end-tag-expected.txt:
• platform/wpe/fast/lists/marker-before-empty-inline-expected.png: Added.
• platform/wpe/fast/lists/marker-before-empty-inline-expected.txt:
• platform/wpe/fast/overflow/scrollRevealButton-expected.png: Added.
• platform/wpe/fast/overflow/scrollRevealButton-expected.txt:
• platform/wpe/fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
• platform/wpe/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
• platform/wpe/fast/parser/xhtml-alternate-entities-expected.png: Added.
• platform/wpe/fast/parser/xhtml-alternate-entities-expected.txt:
• platform/wpe/fast/selectors/visited-descendant-expected.png: Added.
• platform/wpe/fast/selectors/visited-descendant-expected.txt:
• platform/wpe/fast/text/basic/013-expected.png: Added.
• platform/wpe/fast/text/basic/013-expected.txt:
• platform/wpe/fast/text/mark-matches-overflow-clip-expected.txt:
• platform/wpe/fast/text/whitespace/018-expected.png: Added.
• platform/wpe/fast/text/whitespace/018-expected.txt:
• platform/wpe/fast/text/word-break-expected.png: Added.
• platform/wpe/fast/text/word-break-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
• platform/wpe/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
• platform/wpe/svg/custom/svg-fonts-in-html-expected.png: Added.
• platform/wpe/svg/custom/svg-fonts-in-html-expected.txt:
• platform/wpe/svg/custom/svg-fonts-word-spacing-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug113235-1-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug113235-1-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug113235-2-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug113235-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1188-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug1188-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug126742-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug126742-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug1318-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug1318-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug16252-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug16252-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug18359-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug18359-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug4527-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug4527-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug57300-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug57300-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug57828-2-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug57828-2-expected.txt:
• platform/wpe/tables/mozilla/bugs/bug7342-expected.png: Added.
• platform/wpe/tables/mozilla/bugs/bug7342-expected.txt:
• platform/wpe/tables/mozilla/core/bloomberg-expected.png: Added.
• platform/wpe/tables/mozilla/core/bloomberg-expected.txt:
• platform/wpe/tables/mozilla/other/ms-expected.png: Added.
• platform/wpe/tables/mozilla/other/ms-expected.txt:
• platform/wpe/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
• platform/wpe/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
• platform/wpe/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
• platform/wpe/tables/mozilla/other/wa_table_tr_align-expected.txt:
• platform/wpe/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
• platform/wpe/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

8:34 PM Changeset in webkit [275997] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Avoid indirect load in ContainerNode::hasOneChild()
​https://bugs.webkit.org/show_bug.cgi?id=224589

Reviewed by Chris Dumez.

Getting nextSibling() will involve loading the first child into the register.
Avoid that and just check m_firstChild and m_lastChild instead to avoid this extra memory load.

• dom/ContainerNode.h:

(WebCore::ContainerNode::hasOneChild const):

8:31 PM Changeset in webkit [275996] by Diego Pino Garcia

• 1 edit
  23 copies
  13 moves
  2 adds
  4 deletes in trunk/LayoutTests

[WPE] Unreviewed test gardening. Emit specific baselines for WPE.

Several baselines that were common to GTK and WPE are no longer valid.
It's necessary to move the common baseline to GTK and emit new baselines for WPE.

• platform/gtk/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Copied from LayoutTests/platform/glib/css2.1/t100801-c544-valgn-03-d-agi-expected.txt.
• platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Copied from LayoutTests/platform/glib/fast/block/margin-collapse/block-inside-inline/001-expected.txt.
• platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Copied from LayoutTests/platform/glib/fast/block/margin-collapse/block-inside-inline/005-expected.txt.
• platform/gtk/fast/css/child-style-can-override-visited-style-expected.txt: Copied from LayoutTests/platform/glib/fast/css/child-style-can-override-visited-style-expected.txt.
• platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt: Copied from LayoutTests/platform/glib/fast/dom/HTMLProgressElement/progress-element-expected.txt.
• platform/gtk/fast/images/image-map-anchor-children-expected.txt: Copied from LayoutTests/platform/glib/fast/images/image-map-anchor-children-expected.txt.
• platform/gtk/fast/inline-block/002-expected.txt: Copied from LayoutTests/platform/glib/fast/inline-block/002-expected.txt.
• platform/gtk/fast/inline-block/003-expected.txt: Copied from LayoutTests/platform/glib/fast/inline-block/003-expected.txt.
• platform/gtk/fast/inline/002-expected.txt: Copied from LayoutTests/platform/glib/fast/inline/002-expected.txt.
• platform/gtk/fast/invalid/018-expected.txt: Copied from LayoutTests/platform/glib/fast/invalid/018-expected.txt.
• platform/gtk/fast/table/frame-and-rules-expected.txt: Copied from LayoutTests/platform/glib/fast/table/frame-and-rules-expected.txt.
• platform/gtk/fast/table/table-display-types-strict-expected.txt: Copied from LayoutTests/platform/glib/fast/table/table-display-types-strict-expected.txt.
• platform/gtk/fast/text/basic/012-expected.txt: Copied from LayoutTests/platform/glib/fast/text/basic/012-expected.txt.
• platform/gtk/svg/custom/invisible-text-after-scrolling-expected.txt: Copied from LayoutTests/platform/glib/svg/custom/invisible-text-after-scrolling-expected.txt.
• platform/gtk/svg/hixie/processing-model/003-expected.txt: Copied from LayoutTests/platform/glib/svg/hixie/processing-model/003-expected.txt.
• platform/gtk/svg/hixie/processing-model/004-expected.txt: Copied from LayoutTests/platform/glib/svg/hixie/processing-model/004-expected.txt.
• platform/gtk/tables/mozilla/bugs/bug14323-expected.txt: Copied from LayoutTests/platform/glib/tables/mozilla/bugs/bug14323-expected.txt.
• platform/gtk/tables/mozilla/bugs/bug2267-expected.txt: Copied from LayoutTests/platform/glib/tables/mozilla/bugs/bug2267-expected.txt.
• platform/wpe/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Renamed from LayoutTests/platform/glib/css2.1/t100801-c544-valgn-03-d-agi-expected.txt.
• platform/wpe/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Renamed from LayoutTests/platform/glib/fast/block/margin-collapse/block-inside-inline/001-expected.txt.
• platform/wpe/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Renamed from LayoutTests/platform/glib/fast/block/margin-collapse/block-inside-inline/005-expected.txt.
• platform/wpe/fast/css/child-style-can-override-visited-style-expected.txt: Renamed from LayoutTests/platform/glib/fast/css/child-style-can-override-visited-style-expected.txt.
• platform/wpe/fast/dom/HTMLProgressElement/progress-element-expected.txt: Renamed from LayoutTests/platform/glib/fast/dom/HTMLProgressElement/progress-element-expected.txt.
• platform/wpe/fast/images/image-map-anchor-children-expected.txt: Renamed from LayoutTests/platform/glib/fast/images/image-map-anchor-children-expected.txt.
• platform/wpe/fast/inline-block/002-expected.txt: Renamed from LayoutTests/platform/glib/fast/inline-block/002-expected.txt.
• platform/wpe/fast/inline-block/003-expected.txt: Renamed from LayoutTests/platform/glib/fast/inline-block/003-expected.txt.
• platform/wpe/fast/inline/002-expected.txt: Renamed from LayoutTests/platform/glib/fast/inline/002-expected.txt.
• platform/wpe/fast/invalid/018-expected.txt: Renamed from LayoutTests/platform/glib/fast/invalid/018-expected.txt.
• platform/wpe/fast/table/frame-and-rules-expected.txt: Renamed from LayoutTests/platform/glib/fast/table/frame-and-rules-expected.txt.
• platform/wpe/fast/table/table-display-types-strict-expected.txt: Renamed from LayoutTests/platform/glib/fast/table/table-display-types-strict-expected.txt.
• platform/wpe/fast/text/basic/012-expected.txt: Renamed from LayoutTests/platform/glib/fast/text/basic/012-expected.txt.
• platform/wpe/svg/custom/invisible-text-after-scrolling-expected.txt: Renamed from LayoutTests/platform/glib/svg/custom/invisible-text-after-scrolling-expected.txt.
• platform/wpe/svg/hixie/processing-model/003-expected.txt: Renamed from LayoutTests/platform/glib/svg/hixie/processing-model/003-expected.txt.
• platform/wpe/svg/hixie/processing-model/004-expected.txt: Renamed from LayoutTests/platform/glib/svg/hixie/processing-model/004-expected.txt.
• platform/wpe/tables/mozilla/bugs/bug14323-expected.txt: Renamed from LayoutTests/platform/glib/tables/mozilla/bugs/bug14323-expected.txt.
• platform/wpe/tables/mozilla/bugs/bug2267-expected.txt: Renamed from LayoutTests/platform/glib/tables/mozilla/bugs/bug2267-expected.txt.

8:29 PM Changeset in webkit [275995] by ysuzuki@apple.com

• 30 edits in trunk/Source/JavaScriptCore

[JSC] Do not copy SimpleJumpTable
​https://bugs.webkit.org/show_bug.cgi?id=224472

Reviewed by Mark Lam.

This patch avoids copying UnlinkedSimpleJumpTable to SimpleJumpTable by decoupling CTI addresses from jump offset in SimpleJumpTable.
SimpleJumpTable and UnlinkedSimpleJumpTable are almost identical. SimpleJumpTable adds JIT jump target for each branch.
We should use data from UnlinkedSimpleJumpTable and jump via SimpleJumpTable. Do not need to have copy of branches from UnlinkedSimpleJumpTable.

This way removes Vector<SimpleJumpTable> from CodeBlock::RareData. And this is moved to CodeBlock::JITData. And it only includes jump target addresses,
and branch offset information is kept in UnlinkedSimpleJumpTable side. We no longer need to carefully copy these vectors in CodeBlock including DFG / FTL ones.

In LLInt, we instead use UnlinkedSimpleJumpTable for jumping.

In Baseline, we first allocate enough FixedVector<SimpleJumpTable> and fill content via SimpleJumpTable::ensureCTITable() call when compiling corresponding
switch opcode. Finally we fill these data structures with actual code locations in JIT::link function.

In DFG, we first collect UnlinkedSimpleJumpTable without copying. This is OK since it is kept by UnlinkedCodeBlock, and UnlinkedCodeBlock is kept by baseline CodeBlocks that
are handled by this DFG compilation. We hold Vector<const UnlinkedSimpleJumpTable*> in DFG::Graph and we materialize Vector<SimpleJumpTable> in DFG::Graph.
During DFG compilation, we touch this DFG::Graph's jump tables, and JIT compiler generates code via these tables. And when linking, we move the content to CodeBlock.

In FTL, while we use UnlinkedSimpleJumpTable in FTL code generation, FTL do not use SimpleJumpTable and instead FTL uses Switch in B3.

• bytecode/BytecodeDumper.cpp:

(JSC::CodeBlockBytecodeDumper<Block>::dumpSwitchJumpTables):

• bytecode/BytecodeDumper.h:
• bytecode/BytecodeGeneratorification.cpp:

(JSC::BytecodeGeneratorification::run):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::shrinkToFit):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::switchJumpTable):
(JSC::CodeBlock::numberOfUnlinkedSwitchJumpTables const):
(JSC::CodeBlock::unlinkedSwitchJumpTable):
(JSC::CodeBlock::numberOfSwitchJumpTables const): Deleted.
(JSC::CodeBlock::clearSwitchJumpTables): Deleted.
(JSC::CodeBlock::addSwitchJumpTableFromProfiledCodeBlock): Deleted.

• bytecode/JumpTable.cpp:

(JSC::SimpleJumpTable::offsetForValue): Deleted.

• bytecode/JumpTable.h:

(JSC::SimpleJumpTable::ensureCTITable):
(JSC::SimpleJumpTable::ctiForValue const):
(JSC::SimpleJumpTable::isEmpty const):
(): Deleted.
(JSC::SimpleJumpTable::cloneNonJITPart const): Deleted.
(JSC::SimpleJumpTable::ctiForValue): Deleted.
(JSC::SimpleJumpTable::clear): Deleted.

• bytecode/PreciseJumpTargetsInlines.h:
• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedSimpleJumpTable::offsetForValue const):
(JSC::UnlinkedSimpleJumpTable::add):
(JSC::UnlinkedCodeBlock::numberOfUnlinkedSwitchJumpTables const):
(JSC::UnlinkedCodeBlock::unlinkedSwitchJumpTable const):
(JSC::UnlinkedCodeBlock::unlinkedStringSwitchJumpTable const):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables const): Deleted.
(JSC::UnlinkedCodeBlock::switchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::unlinkedStringSwitchJumpTable): Deleted.

• bytecode/UnlinkedCodeBlockGenerator.cpp:

(JSC::UnlinkedCodeBlockGenerator::finalize):

• bytecode/UnlinkedCodeBlockGenerator.h:

(JSC::UnlinkedCodeBlockGenerator::numberOfUnlinkedSwitchJumpTables const):
(JSC::UnlinkedCodeBlockGenerator::addUnlinkedSwitchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::unlinkedSwitchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::numberOfSwitchJumpTables const): Deleted.
(JSC::UnlinkedCodeBlockGenerator::addSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlockGenerator::switchJumpTable): Deleted.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::beginSwitch):
(JSC::prepareJumpTableForSwitch):
(JSC::BytecodeGenerator::endSwitch):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

• dfg/DFGGraph.h:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::emitSwitchString):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

• jit/JIT.h:

(JSC::SwitchRecord::SwitchRecord):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):

• jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):

• jit/JITOperations.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/CachedTypes.cpp:

(JSC::CachedSimpleJumpTable::encode):
(JSC::CachedSimpleJumpTable::decode const):
(JSC::CachedCodeBlockRareData::encode):
(JSC::CachedCodeBlockRareData::decode const):

8:27 PM Changeset in webkit [275994] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Crash in in ReplaceSelectionCommand::mergeEndIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=222941

Unreviewed. Address Darin's post-commit comment that we don't need to explicitly call copyRef here.

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):

8:06 PM Changeset in webkit [275993] by zhifei_fang@apple.com

• 14 edits in trunk/Websites/perf.webkit.org

Support Commit revision identifier in the Chart
​https://bugs.webkit.org/show_bug.cgi?id=224496

Reviewed by Dewei Zhu.

In the measurement-set, we include the commit info but not the commit revision identifier column.
Make the API return the commit revision identifier as part of the commit data.

• browser-tests/customizable-test-group-form-tests.js: Fix flaky tests.
• browser-tests/index.html: Add commit revision identifier info.
• browser-tests/time-series-chart-tests.js: Fix flaky tests.
• public/api/measurement-set.php: Make this API provide commit revision identifier info.
• public/include/build-requests-fetcher.php: Ditto.
• public/v3/models/commit-set.js: Make the commit model can be constructed with the API respose format.
• server-tests/api-measurement-set-tests.js: Adding test for commit revision identifier.
• server-tests/api-build-requests-tests.js: Ditto.
• unit-tests/analysis-task-tests.js: Ditto.

(measurementCluster):

• unit-tests/commit-set-tests.js: Ditto.
• unit-tests/measurement-adaptor-tests.js: Ditto.
• unit-tests/measurement-set-tests.js: Ditto.

7:42 PM Changeset in webkit [275992] by basuke.suzuki@sony.com

• 2 edits in trunk/Source/WebKit

Fix WK_EXPORT macro for declspec compilers
​https://bugs.webkit.org/show_bug.cgi?id=224583

Reviewed by Don Olmstead.

It displays warnings when macro is not defined. Actually it is defined only when
it builds WebKit. It should be defined(BUILDING_WebKit).

• Shared/API/c/WKDeclarationSpecifiers.h:

7:23 PM Changeset in webkit [275991] by Diego Pino Garcia

• 2 edits
  3 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update test expectations after r275515.

Two tests are returning an image failure.

html/dom/elements/the-innertext-idl-attribute/getter.html requires a new baseline.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt: Added.

7:11 PM Changeset in webkit [275990] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebKit

6 http/wpt/webauthn layout-tests are constantly timing out
​https://bugs.webkit.org/show_bug.cgi?id=224531
<rdar://76432480>

Reviewed by Brent Fulgham.

Covered by existing tests.

• UIProcess/WebAuthentication/Mock/MockLocalService.mm:

(WebKit::MockLocalService::MockLocalService):
Needs to deal with the mock testing infrastructure according to internal requirements.

7:11 PM Changeset in webkit [275989] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Skip accessibility test added in r275664.

• platform/glib/TestExpectations:

7:04 PM Changeset in webkit [275988] by Wenson Hsieh

• 8 edits
  2 adds in trunk

[macOS] Make image extraction interactions work for elements inside links
​https://bugs.webkit.org/show_bug.cgi?id=224576
<rdar://problem/76664721>

Reviewed by Devin Rousso.

Source/WebCore:

Make a slight adjustment to EventHandler::canMouseDownStartSelect to allow selection to begin when handling a
mousedown over text inside an image overlay.

Test: fast/images/image-extraction/mac/select-image-overlay-in-link-with-mouse-drag.html

• html/HTMLElement.cpp:

(WebCore::HTMLElement::isImageOverlayText):

Add an overloaded version of this helper method that takes a pointer instead of a reference, and use it in
several places where we current check the nullity of a Node* before dereferencing it and passing it into
isImageOverlayText().

• html/HTMLElement.h:
• page/DragController.cpp:

(WebCore::DragController::draggableElement const):

• page/EventHandler.cpp:

(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::updateSelectionForMouseDrag):

Additionally, make it so that we only invalidate a click (i.e. prevent mouse release from dispatching a click
event) in EventHandler::updateSelectionForMouseDrag in the case where we're selecting text in an image
overlay, if the selection hasn't actually changed.

Source/WebKit:

See WebCore ChangeLog for more details.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::elementPositionInformation):

LayoutTests:

Add a layout test to exercise the change.

• fast/images/image-extraction/mac/select-image-overlay-in-link-with-mouse-drag-expected.txt: Added.
• fast/images/image-extraction/mac/select-image-overlay-in-link-with-mouse-drag.html: Added.

6:57 PM Changeset in webkit [275987] by Robert Jenner

• 3 edits in trunk/LayoutTests

[ wk2 ] http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=224566

Unreviewed test gardening.

Updating expectations to two more tests I found that are flakey crashing.

• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

6:52 PM Changeset in webkit [275986] by Devin Rousso

• 2 edits in trunk/Source/WebCore

[Apple Pay] add WKA hooks for ApplePayModifier
​https://bugs.webkit.org/show_bug.cgi?id=224585
<rdar://problem/76669793>

Reviewed by Wenson Hsieh.

• Modules/applepay/paymentrequest/ApplePayModifier.h:

6:27 PM Changeset in webkit [275985] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Flaky crash under AudioSummingJunction::removeOutput() on Debug bots
​https://bugs.webkit.org/show_bug.cgi?id=224584

Reviewed by Eric Carlson.

Add DisableMallocRestrictionsForCurrentThreadScope to allow the heap allocation until I can investigate
if we can avoid it.

• Modules/webaudio/AudioSummingJunction.cpp:

(WebCore::AudioSummingJunction::removeOutput):

6:26 PM Changeset in webkit [275984] by Devin Rousso

• 7 edits in trunk

Promote -[WKWebView _themeColor] SPI to API
​https://bugs.webkit.org/show_bug.cgi?id=224571
<rdar://problem/75231602>

Reviewed by Geoffrey Garen.

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView themeColor]): Added.
(-[WKWebView _themeColor]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::themeColorWillChange):
(WebKit::PageClientImplCocoa::themeColorDidChange):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/HTMLMetaThemeColor.mm:

(TEST.HTMLMetaThemeColor.OnLoad):
(TEST.HTMLMetaThemeColor.MultipleTags):
(-[WKWebViewThemeColorObserver initWithWebView:]):
(TEST.HTMLMetaThemeColor.KVO):
(TEST.HTMLMetaThemeColor.ExperimentalUseThemeColorForScrollAreaBackgroundColor):

5:32 PM Changeset in webkit [275983] by Amir Mark Jr.

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mac WK2 ] fast/mediastream/audio-track-enabled.html is flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=221985

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

5:18 PM Changeset in webkit [275982] by BJ Burg

• 10 edits in trunk/Source

Web Inspector: add setting to allow inspecting Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=224082
<rdar://75695002>

Reviewed by Devin Rousso.

Source/WebCore:

Add a property to check if inspecting inspector is allowed,
and to enable/disable upon loading the frontend or toggling the setting.

• en.lproj/Localizable.strings:
• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::inspectInspector):
(WebCore::InspectorFrontendHost::allowsInspectingInspector):
(WebCore::InspectorFrontendHost::setAllowsInspectingInspector):

• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Instead of telling curious users to set the WebKitDeveloperExtras default,
expose an experimental setting that does the same thing.

• UserInterface/Base/Main.js:

(WI.loaded):

• UserInterface/Base/Setting.js:
• UserInterface/Views/SettingsTabContentView.js:

5:15 PM Changeset in webkit [275981] by weinig@apple.com

• 9 edits
  1 add in trunk/Source/WebCore

Use range-for loop in target contrast selection to simplify/improve code readability
​https://bugs.webkit.org/show_bug.cgi?id=224512

Reviewed by Darin Adler.

Address some additional post landing feedback from Darin.

• Use range-for loop in target contrast selection.
• Use double to represent luminance, lightness and contrast everywhere. This avoid unnecessary conversions to and from float.
• Rename Color::contrastRatio(Color, Color) to just contrastRatio(Color, Color) and move it ColorLuminance.h/cpp with the other contrastRatio overloads.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:

Add ColorLuminance.cpp

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::selectFirstColorThatMeetsOrExceedsTargetContrast):
Convert colorsToCompareAgainst to an r-value since vector is never used after
calling this.

(WebCore::CSSPropertyParserHelpers::selectFirstColorWithHighestContrast):
Convert colorsToCompareAgainst to an r-value since vector is never used after
calling this. Also, switch to a range-for loop to aid readability.

(WebCore::CSSPropertyParserHelpers::parseColorContrastFunctionParameters):
Move colorsToCompareAgainst to the select functions.

• platform/graphics/Color.h:
• platform/graphics/Color.cpp:

(WebCore::Color::lightness const):
(WebCore::Color::luminance const):
Use double to represent lightness and luminance.

(WebCore::Color::contrastRatio): Deleted.
Moved to ColorLuminance.h/cpp

• platform/graphics/ColorLuminance.cpp: Added.

(WebCore::contrastRatio):

• platform/graphics/ColorLuminance.h:

(WebCore::relativeLuminance):
(WebCore::contrastRatio):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::disabledTextColor const):

• rendering/TextPaintStyle.cpp:

(WebCore::textColorIsLegibleAgainstBackgroundColor):
Use double to represent luminance and constrast everywhere.

5:11 PM Changeset in webkit [275980] by Wenson Hsieh

• 7 edits
  4 adds in trunk

[iOS] Make image extraction interactions work for elements inside links
​https://bugs.webkit.org/show_bug.cgi?id=224517
<rdar://problem/76616431>

Reviewed by Devin Rousso.

Source/WebKit:

See comments below for more details.

Tests: fast/images/image-extraction/click-link-with-image-overlay.html

fast/images/image-extraction/ios/select-word-in-image-overlay-inside-link.html

• Shared/ios/InteractionInformationAtPosition.h:
• Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Add imageElementContext, an optional element context that exists alongside elementContext. This is necessary
in the case where the user is interacting with an image element inside a link element because we need to know
about the inner hit-tested image element for the purposes of image extraction, but the clickable element we use
for the elementContext is the link element instead.

• Shared/ios/InteractionInformationRequest.cpp:

(WebKit::InteractionInformationRequest::isValidForRequest const):

Make a slight adjustment here - since includeImageData may require image bitmap data in cases where only the
includeSnapshot flag is set, it's incorrect to assume that setting includeSnapshot fulfills all the needs of
includeImageData.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

Consult imageElementContext instead of elementContext.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::imagePositionInformation):

Set the position information's imageElementContext.

(WebKit::elementPositionInformation):
(WebKit::WebPage::positionInformation):

Make a couple of adjustments here: (1) avoid requesting link position information if the hit-tested node is text
inside of an image overlay. (2) If the includeImageData request flag is set and the hit-tested node is an
image element but isImage is not set, then additionally supply the image data using the
imagePositionInformation helper function. This ensures that in the case where we're requesting image data and
the user is interacting with an image element inside a link, we'll send decoded image data back to the UI
process.

LayoutTests:

• fast/images/image-extraction/click-link-with-image-overlay-expected.txt: Added.
• fast/images/image-extraction/click-link-with-image-overlay.html: Added.

Add a test that verifies that activating different parts of an image in a link fires click events.

• fast/images/image-extraction/ios/select-word-in-image-overlay-inside-link-expected.txt: Added.
• fast/images/image-extraction/ios/select-word-in-image-overlay-inside-link.html: Added.

Add a test that selects image overlay text for an image element inside a link.

4:55 PM Changeset in webkit [275979] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Keep UniqueRef<MathICGenerationState> instead of MathICGenerationState in HashTables
​https://bugs.webkit.org/show_bug.cgi?id=224569

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-14
Reviewed by Geoffrey Garen.

sizeof(KeyValuePair<const Instruction*, MathICGenerationState>) is 136 on some platforms.
That's on the big side for sparse HashTable entries. I think using UniqueRef will help performance.

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):

• jit/JITMathIC.h:

3:54 PM Changeset in webkit [275978] by Antti Koivisto

• 3 edits
  2 adds in trunk

RunIterator::traverseNext/PreviousOnLineIgnoringLineBreak should skip over WBRs
​https://bugs.webkit.org/show_bug.cgi?id=224545
rdar://76101143

Reviewed by Zalan Bujtas.
Source/WebCore:

Test: fast/editing/wbr-iterator-crash.html

• layout/integration/LayoutIntegrationRunIterator.cpp:

(WebCore::LayoutIntegration::RunIterator::traverseNextOnLineIgnoringLineBreak):
(WebCore::LayoutIntegration::RunIterator::traversePreviousOnLineIgnoringLineBreak):

Skip over (instead of bailing) runs with isLineBreak() set. It is true for <WBR> so there can be multiple on a line.

LayoutTests:

• fast/editing/wbr-iterator-crash-expected.txt: Added.
• fast/editing/wbr-iterator-crash.html: Added.

3:39 PM Changeset in webkit [275977] by Russell Epstein

• 1 copy in tags/Safari-611.2.3

Tag Safari-611.2.3.

3:18 PM Changeset in webkit [275976] by Lauro Moura

• 4 edits in trunk/Source/WebCore

REGRESSION(r275948) Wrap sh::ShaderVariable into UniqueRef to fit in HashMap
​https://bugs.webkit.org/show_bug.cgi?id=224567

Unreviewed build fix.

• platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:

(WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):

• platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::precisionsMatch const):
(WebCore::GraphicsContextGLOpenGL::mappedSymbolInShaderSourceMap):
(WebCore::GraphicsContextGLOpenGL::originalSymbolInShaderSourceMap):
(WebCore::GraphicsContextGLOpenGL::mappedSymbolName):
(WebCore::GraphicsContextGLOpenGL::shaderSource):

3:15 PM Changeset in webkit [275975] by youenn@apple.com

• 4 edits in trunk

Update WKPageSet implementation according new MediaProducer::MutedState values
​https://bugs.webkit.org/show_bug.cgi?id=224548

Reviewed by Eric Carlson.

Source/WebKit:

Covered by API test.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetMuted):
Translate WKMediaMutedState to WebCore::MediaProducer::MutedStateFlags properly.

Tools:

• TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

(TestWebKitAPI::doCaptureMuteTest):
(TestWebKitAPI::TEST):

3:11 PM Changeset in webkit [275974] by Robert Jenner

• 2 edits in trunk/LayoutTests

[ wk2 ] http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=224566

Uneviewed test gardneing.

• platform/mac-wk2/TestExpectations: Adding mac wk2 to Pass Crash expectations.

3:11 PM Changeset in webkit [275973] by achristensen@apple.com

• 4 edits in trunk

Don't block proxy authentication challenges
​https://bugs.webkit.org/show_bug.cgi?id=224564
Source/WebKit:

<rdar://76542907>

Reviewed by Brady Eidson.

You have to use SPI to get WebKit to tell CFNetwork to not handle proxy authentication by default,
but if you do it only works for first-party requests. Our challenge blocking to prevent cross-site fetches from
asking for basic auth credentials should not block challenges for proxy authentication. The radar has an application
that wants to handle them.

Covered by an API test.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didReceiveChallenge):

Tools:

Reviewed by Brady Eidson.

• TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:

(TestWebKitAPI::proxyAuthenticationServer):
(TestWebKitAPI::webViewAndDelegate):
(TestWebKitAPI::TEST):

3:11 PM Changeset in webkit [275972] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Crash in ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds()
​https://bugs.webkit.org/show_bug.cgi?id=224520

Patch by Julian Gonzalez <​julian_a_gonzalez@apple.com> on 2021-04-14
Reviewed by Ryosuke Niwa.

Adopt RefPtr<Node> instead of using plain Node* here to avoid a crash.

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):

2:57 PM Changeset in webkit [275971] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Apply DeferTermination in some utility functions in the jsc shell.
​https://bugs.webkit.org/show_bug.cgi?id=224572
rdar://76646089

Reviewed by Yusuke Suzuki.

This is to make sure that these functions don't get in the way of testing with
the watchdog. Since these are only test utility functions, just doing the simple
thing of using a DeferTermination scope is the right thing to do here.

• jsc.cpp:

2:52 PM Changeset in webkit [275970] by Jonathan Bedard

• 1 edit
  1 add in trunk/Tools

[GitHub] Add script to verify integrity of the mirror
​https://bugs.webkit.org/show_bug.cgi?id=224514
<rdar://problem/76613576>

Reviewed by Aakash Jain.

• Scripts/check-github-mirror-integrity: Added.

2:50 PM Changeset in webkit [275969] by mark.lam@apple.com

• 7 edits
  1 add in trunk

Defer TerminationExceptions when evaluating ASSERT in HashMapIml::addNormalized().
​https://bugs.webkit.org/show_bug.cgi?id=224565
rdar://76645980

Reviewed by Yusuke Suzuki.

JSTests:

• stress/suppress-TerrminationException-in-ASSERT-in-HashMapImpl-addNormalized.js: Added.

Source/JavaScriptCore:

HashMapImpl::addNormalized() has an ASSERT that calls jsMapHash(), which can
potentially throw exceptions. As a result, it has a RETURN_IF_EXCEPTION which
provides an opportunity to handle traps and throw a TerminationException. This
in turn causes the ASSERT to fail.

To fix this, we do:

1. Introduce VMTraps::DeferAction, which gives us DeferForAWhile and DeferUntilEndOfScope.

2. Templatize the DeferTermination RAII object on VMTraps::DeferAction. Introduce DeferTerrminationForAWhile, which is DeferTermination<VMTraps::DeferAction::DeferForAWhile>. DeferForAWhile means that the deferScope will not throw the TerminationException on exit. Instead, it will re-set the NeedTermination bit in the traps, and let the next trap check handle it.

3. Introduce DEFER_TERMINATION_AND_ASSERT_WITH_MESSAGE (and friends) which creates a DeferTerrminationForAWhile scope before doing an ASSERT_WITH_MESSAGE.

4. Use DEFER_TERMINATION_AND_ASSERT_WITH_MESSAGE instead in HashMapImpl::addNormalized().

• runtime/DeferTermination.h:

(JSC::DeferTermination::DeferTermination):
(JSC::DeferTermination::~DeferTermination):

• runtime/ExceptionHelpers.h:
• runtime/HashMapImpl.h:

(JSC::HashMapImpl::addNormalized):

• runtime/VMTraps.cpp:

(JSC::VMTraps::deferTermination):
(JSC::VMTraps::undoDeferTermination):

• runtime/VMTraps.h:

2:49 PM Changeset in webkit [275968] by don.olmstead@sony.com

• 2 edits in trunk/Source/WebKit

[GPUP] RemoteGraphicsContextsGL shouldn't be referenced when ENABLE_WEBGL is off
​https://bugs.webkit.org/show_bug.cgi?id=224560

Reviewed by Alex Christensen.

Add an ENABLE(WEBGL) guard.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::didClose):

2:37 PM Changeset in webkit [275967] by don.olmstead@sony.com

• 2 edits in trunk

[PlayStation] Disable WebGL
​https://bugs.webkit.org/show_bug.cgi?id=224562

Reviewed by Alex Christensen.

WebGL support on PlayStation platforms is deprecated.

• Source/cmake/OptionsPlayStation.cmake:

2:35 PM Changeset in webkit [275966] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed, a comment fix after r275847

• UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:

(WebKit::LocalConnection::verifyUser):
Explains why instead of what.

1:32 PM Changeset in webkit [275965] by guijemont@igalia.com

• 2 edits in trunk/JSTests

[JSC] Unskip stress/intl-segmenter.js
​https://bugs.webkit.org/show_bug.cgi?id=224553

Unreviewed test gardening.

It shouldn't fail any more on our bots now that our handling of libicu
is more robust.

• stress/intl-segmenter.js:

1:00 PM Changeset in webkit [275964] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Temporarily fix more terminate_with_reason-related crashes
​https://bugs.webkit.org/show_bug.cgi?id=224559
<rdar://76639741>

Reviewed by Geoff Garen.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::terminateWithReason):

12:58 PM Changeset in webkit [275963] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Revert "Cherry-pick r274877. rdar://problem/76373841"

This reverts commit r275741.

12:58 PM Changeset in webkit [275962] by Russell Epstein

• 5 edits in branches/safari-611-branch

Revert "Cherry-pick r274199. rdar://problem/76416079"

This reverts commit r275744.

12:58 PM Changeset in webkit [275961] by Russell Epstein

• 4 edits in branches/safari-611-branch/Source/WebCore

Revert "Cherry-pick r274357. rdar://problem/76374004"

This reverts commit r275745.

12:58 PM Changeset in webkit [275960] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Revert "Cherry-pick r274403. rdar://problem/76374004"

This reverts commit r274403.

12:58 PM Changeset in webkit [275959] by Russell Epstein

• 3 edits in branches/safari-611-branch/Source/WebKit

Revert "Cherry-pick r274377. rdar://problem/76412582"

This reverts commit r275766.

12:58 PM Changeset in webkit [275958] by Russell Epstein

• 5 edits in branches/safari-611-branch/Source/WebCore

Revert "Cherry-pick r274819. rdar://problem/76373741"

This reverts commit r275767.

12:58 PM Changeset in webkit [275957] by Russell Epstein

• 2 edits in branches/safari-611-branch/Source/WebCore

Revert "Unreviewed build fix for rdar://76617366."

This reverts commit r275919.

12:42 PM Changeset in webkit [275956] by Devin Rousso

• 12 edits in trunk/Source

[iOS] limit how often WebAVPlayerController notifies the PlaybackSessionModel about changes to playback speed
​https://bugs.webkit.org/show_bug.cgi?id=224515
<rdar://problem/75901463>

Reviewed by Eric Carlson.

This change will cause HTMLMediaElement::setPlaybackRate to not send IPC back and forth
between the WebProcess and UIProcess, as a modification to the WebAVPlayerController in
the UIProcess would notify its PlaybackSessionModel "delegate", which would in turn make
it's way back to the related HTMLMediaElement::setPlaybackRate in the WebProcess.

Source/WebCore:

• platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController init]):
(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController defaultPlaybackRate]): Added.
(-[WebAVPlayerController setDefaultPlaybackRate:]): Added.
(-[WebAVPlayerController rate]): Added.
(-[WebAVPlayerController setRate:]): Added.
(-[WebAVPlayerController observeValueForKeyPath:ofObject:change:context:]):
Instead of relying on ObjC KVO on self to handle changes to defaultPlaybackRate (and
rate), create an actual setDefaultPlaybackRate: so that we can handle cases where the
value is the same. Limit when we notify the PlaybackSessionModel to only when it has a
different value.

• platform/cocoa/PlaybackSessionModel.h:
• platform/cocoa/PlaybackSessionModelMediaElement.h:
• platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::setPlaybackRate): Added.

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::setPlaybackRate): Added.
Add support for handling when the rate of the AVPlayerController changes too.

Source/WebKit:

• UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
• UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::setPlaybackRate): Added.
(WebKit::PlaybackSessionManagerProxy::setPlaybackRate): Added.

• WebProcess/cocoa/PlaybackSessionManager.messages.in:
• WebProcess/cocoa/PlaybackSessionManager.h:
• WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::setPlaybackRate): Added.
Add support for handling when the rate of the AVPlayerController changes too.

11:47 AM Changeset in webkit [275955] by Robert Jenner

• 2 edits in trunk/LayoutTests

[ wk2 ] http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html is flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=224566

Unrviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations: Updating test expectations to Pass Crash, while test is reviewed.

11:42 AM Changeset in webkit [275954] by achristensen@apple.com

• 2 edits in trunk/Source/WTF

Revert important part of r275948
​https://bugs.webkit.org/show_bug.cgi?id=224381

It caused an internal build failure.

• wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):

11:25 AM Changeset in webkit [275953] by Jonathan Bedard

• 4 edits in trunk/Tools

[results.webkit.org] Document ref API argument
​https://bugs.webkit.org/show_bug.cgi?id=224435
<rdar://problem/76599481>

Reviewed by Aakash Jain.

• Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
• Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/documentation.html:
• Scripts/libraries/resultsdbpy/setup.py: Bump version.

10:54 AM Changeset in webkit [275952] by Kate Cheney

• 17 edits in trunk

Service worker soft-update loads not being marked app-bound
​https://bugs.webkit.org/show_bug.cgi?id=223200
<rdar://problem/75438555>

Reviewed by Youenn Fablet.

Source/WebCore:

We need to mark requests initiated by service worker soft updates as
app-bound based on the last navigation. We should get this value from the
NetworkResourceLoader and store it in SWServerRegistration so we can
use it to build a new request.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::startScriptFetch):

• workers/service/server/SWServer.h:

Pass the entire SWServerRegistration to SWServer::startScriptFetch
now that we need more than one value from it. Move shouldRefreshCache
logic here instead of SWServerJobQueue::runUpdateJob.

• workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::runUpdateJob):

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scheduleSoftUpdate):

• workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::isAppBound):

Source/WebKit:

We should pass the app-bound request value when doing a soft update.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::isAppBound):

• NetworkProcess/NetworkResourceLoader.h:

Make a helper function to get the request's app-bound value.

• NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::softUpdateIfNeeded):

• NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:

(WebKit::ServiceWorkerSoftUpdateLoader::loadFromNetwork):

• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::createFetchTask):

• Shared/NavigatingToAppBoundDomain.h:

(WebKit::AppBoundNavigationTestingData::setDidPerformSoftUpdate):
(WebKit::AppBoundNavigationTestingData::clearAppBoundNavigationDataTesting):
(WebKit::AppBoundNavigationTestingData::encode const):
(WebKit::AppBoundNavigationTestingData::decode):

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _appBoundNavigationData:]):
Update testing struct to make sure a soft-update occurred before
checking app-bound data. This accounts for the delay between the
page load and the soft update.

Tools:

API test coverage. Refactor to avoid code duplication in other tests.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

A soft update might be delayed after the synthetic response comes
back. We should wait until we receive the test data indicating that
a soft update has occurred before checking the app-bound values.

10:39 AM Changeset in webkit [275951] by Robert Jenner

• 3 edits in trunk/LayoutTests

[ wk2 ] 2 page-cache layout-tests are flakey crashing
​https://bugs.webkit.org/show_bug.cgi?id=224558

Unreviewed test gardening.

Updated expectations to Pass Crash for the following two tests for causing issues with EWS and Commit-Queue.

• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

9:55 AM Changeset in webkit [275950] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Add support for using local-worker for build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=224551

Reviewed by Carlos Alberto Lopez Perez.

• CISupport/build-webkit-org/loadConfig.py:

(loadBuilderConfig): Added local-worker support.

• CISupport/ews-build/loadConfig.py:

(loadBuilderConfig): Removed use_localhost_worker variable.

9:53 AM Changeset in webkit [275949] by eric.carlson@apple.com

• 7 edits in trunk/Source/WebCore

Allow text tracks to purge cues outside of the buffered range
​https://bugs.webkit.org/show_bug.cgi?id=224489

Reviewed by Jer Noble.

TextTrackCues associated in-band tracks live "forever" - until the video element
is deleted or reloaded. This is fine for relatively short files, but not so good
for long lived files (eg. a very long live stream), or for timed metadata where
the "cue" size can be much larger than a text sample.

Allow text tracks to opt in to purging cues who's time range does not intersect
with the buffered range, where audio and video data is also not available. Only
AVFoundation backed in-band tracks opt in at this time, because AVFoundation will
redeliver cues if a time range is played again.

Tested manually as the only way to test this currently would be with an HLS stream
that would have to play too long for a layout test, or with an MSE text track but
we won't support text tracks in MSE yet.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerBufferedTimeRangesChanged): Allow tracks
that support purging cues to do so.

• html/HTMLMediaElement.h:

• html/track/InbandDataTextTrack.h: Return true for shouldPurgeCuesFromUnbufferedRanges();

• html/track/InbandGenericTextTrack.h: Ditto.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::removeCuesNotInTimeRanges): Remove all cues who's time range
does not intersect with the buffered range.

• html/track/TextTrack.h:

(WebCore::TextTrack::shouldPurgeCuesFromUnbufferedRanges const):

9:19 AM Changeset in webkit [275948] by achristensen@apple.com

• 5 edits in trunk/Source

Reduce maximum HashTable entry size to 128 bytes
​https://bugs.webkit.org/show_bug.cgi?id=224381

Reviewed by Yusuke Suzuki.

Source/WebKit:

• WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

• WebProcess/WebPage/ViewUpdateDispatcher.h:

(WebKit::ViewUpdateDispatcher::UpdateData::UpdateData):

Source/WTF:

It turns out that HashMaps use HashTable::Value as KeyValuePair, so sizeof(Key) + sizeof(Value) was double counting the key size.
This caused FontCascadeCache to be a false positive. It has a key size of a little over 100 bytes. Only counting it once reflects what is intended.
Also, the USE(ANGLE) exception was convenient for a downstream branch, but isn't needed. Next time they rebase they will use UniqueRef.

• wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup):

9:07 AM Changeset in webkit [275947] by Ruben Turcios

• 2 edits in branches/safari-612.1.11-branch/Source/WebKit

Cherry-pick r275918. rdar://problem/76648077

Unreviewed build fix after r275898; remove unnecessary files from the project.

• WebKit.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:07 AM Changeset in webkit [275946] by Ruben Turcios

• 20 edits in branches/safari-612.1.11-branch

Cherry-pick r275855. rdar://problem/76627715

Unreviewed, reverting r275793.
​https://bugs.webkit.org/show_bug.cgi?id=224466

Caused crashes on <​http://facebook.com|facebook.com>

Reverted changeset:

"calc() simplification for a multiplication should apply the
multiplication to each value of an addition"
​https://bugs.webkit.org/show_bug.cgi?id=224376
​https://trac.webkit.org/changeset/275793

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@275855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:42 AM Changeset in webkit [275945] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

Remove unused InlineBox::next/previousLeafOnLineIgnoringLineBreak()
​https://bugs.webkit.org/show_bug.cgi?id=224542

Reviewed by Zalan Bujtas.

• rendering/InlineBox.cpp:

(WebCore::InlineBox::nextLeafOnLineIgnoringLineBreak const): Deleted.
(WebCore::InlineBox::previousLeafOnLineIgnoringLineBreak const): Deleted.

• rendering/InlineBox.h:

8:13 AM Changeset in webkit [275944] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

Crash in RenderBlock::addOverflowFromChildren
​https://bugs.webkit.org/show_bug.cgi?id=223539

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-04-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

For an <svg> element that is a direct child of a <foreignObject>, a RenderSVGRoot is
generally created. However, a RenderSVGViewportContainer is currently created instead if
the element is inside a shadow tree. This is leading to bad state during the layout of
the foreign object, causing a debug assertion and a nullptr crash. This patch fixes this
issue by always treating direct <svg> child of <foreignObject> as an outermost SVG element.

Tests: svg/foreignObject/svg-child-of-foreign-object-in-shadow-tree-crash.html

svg/outermost-svg-root.html

• svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement const): Lower down the priority of the rule
"is in shadow tree".

LayoutTests:

Add regressions tests for the crash and for isOutermostSVGSVGElement().

• svg/foreignObject/svg-child-of-foreign-object-in-shadow-tree-crash-expected.txt: Added.
• svg/foreignObject/svg-child-of-foreign-object-in-shadow-tree-crash.html: Added.
• svg/outermost-svg-root-expected.txt: Added.
• svg/outermost-svg-root.html: Added.

6:57 AM Changeset in webkit [275943] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

InlineBox should not hold a reference to RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=224506

Reviewed by Antti Koivisto.

The InlineBox/RenderObject relationship is somewhat error-prone (see RenderBox::setInlineBoxWrapper vs. InlineElementBox::extractLine) and it's rather easy to delete one without letting the other know.

• rendering/InlineBox.cpp:

(WebCore::InlineBox::showNodeTreeForThis const):
(WebCore::InlineBox::showLineTreeForThis const):
(WebCore::InlineBox::caretMinOffset const):
(WebCore::InlineBox::caretMaxOffset const):
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::selectionState):
(WebCore::InlineBox::canAccommodateEllipsis const):
(WebCore::InlineBox::locationIncludingFlipping const):
(WebCore::InlineBox::flipForWritingMode const):

• rendering/InlineBox.h:

(WebCore::InlineBox::renderer const):
(WebCore::InlineBox::boxModelObject const):
(WebCore::InlineBox::InlineBox):

6:30 AM Changeset in webkit [275942] by Aditya Keerthi

• 3 edits in trunk/Source/WebCore

[iOS][FCR] Indeterminate progress bars should update at 60fps
​https://bugs.webkit.org/show_bug.cgi?id=224372
<rdar://problem/76416848>

Reviewed by Wenson Hsieh.

• rendering/RenderProgress.cpp:

(WebCore::RenderProgress::animationTimerFired):

Added a FIXME to state that progress bar animation should be performed
as part of the rendering update lifecycle. Progress bars have always
maintained their own timers for animation, however, the update interval
may not always match the display's refresh rate.

• rendering/RenderThemeIOS.mm:

Ensure a smoother animation by increasing the frame rate to 60fps.

3:18 AM Changeset in webkit [275941] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Commit queue isn't skipping builds and test on revert patches
​https://bugs.webkit.org/show_bug.cgi?id=224477

Reviewed by Jonathan Bedard.

• CISupport/ews-build/steps.py:

(BugzillaMixin): Changed preamble to lower-case to match with new logic.

• CISupport/ews-build/steps_unittest.py: Added unit-tests.

3:03 AM Changeset in webkit [275940] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK4] Use a while loop in PlatformWebView::dismissAllPopupMenus()
​https://bugs.webkit.org/show_bug.cgi?id=224534

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-14
Reviewed by Philippe Normand.

The child might be destroyed during the loop iteration. Using a while loop we ensure we get the next sibling
before the current child is destroyed.

• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::dismissAllPopupMenus):

2:45 AM Changeset in webkit [275939] by Angelos Oikonomopoulos

• 2 edits in trunk/JSTests

[JSC] Unskip typedarray-functions-with-neutered.js on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=224428

Unreviewed test gardening.

This appears to no longer fail.

• stress/typedarray-functions-with-neutered.js:

2:42 AM Changeset in webkit [275938] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Do not reset computed style for element children with display contents style
​https://bugs.webkit.org/show_bug.cgi?id=223794

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-14
Reviewed by Antti Koivisto.

We were checking hasDisplayContents() was false before calling resetComputedStyle() on the parent, but we don't
check it when iterating the children.

• dom/Element.cpp:

(WebCore::Element::resetComputedStyle):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

1:20 AM Changeset in webkit [275937] by Chris Dumez

• 4 edits in trunk/Source/WebKit

[iOS] WKMouseDeviceObserver is calling WebProcessProxy::send() on a non-main thread
​https://bugs.webkit.org/show_bug.cgi?id=224529
<rdar://76598710>

Reviewed by Tim Horton.

Make sure WKMouseDeviceObserver calls WebProcessProxy::notifyHasMouseDeviceChanged() on the main thread
since:

1. It iterates over WebProcessProxy::allProcesses() which is only safe on the main thread
2. It calls WebProcessProxy::send() wich is only safe on the main thread

• UIProcess/WebProcessProxy.h:
• UIProcess/ios/WKMouseDeviceObserver.mm:

(-[WKMouseDeviceObserver mousePointerDevicesDidChange:]):
(-[WKMouseDeviceObserver _setHasMouseDeviceForTesting:]):

• UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::notifyHasMouseDeviceChanged):

12:44 AM Changeset in webkit [275936] by magomez@igalia.com

• 10 edits in trunk

[GTK][WPE] Add a property to the WebKitWebView indicating whether the web process is responsive
​https://bugs.webkit.org/show_bug.cgi?id=224359

Reviewed by Adrian Perez de Castro.

Source/WebKit:

Add a property to WebKitWebView indicating whether the web processes used are responsive.

• UIProcess/API/glib/WebKitNavigationClient.cpp:
• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkitWebViewSetIsWebProcessResponsive):
(webkit_web_view_get_is_web_process_responsive):

• UIProcess/API/glib/WebKitWebViewPrivate.h:
• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitWebView.h:
• UIProcess/API/wpe/docs/wpe-1.0-sections.txt:

Tools:

Added unit test for web process responsiveness API.

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewIsWebProcessResponsive):
(beforeAll):