Context Navigation

← Previous Period
Next Period →

Timeline

Jun 8, 2021:

10:48 PM Changeset in webkit [278650] by Diego Pino Garcia

3 edits in trunk/LayoutTests

[GLIB][GTK] Unreviewed test gardening. Update status of flaky tests failing to Failure.

All the tests changed were reported as 'Failure' by the GTK post-commit
bot for the last 4000 revisions.

platform/glib/TestExpectations:
platform/gtk/TestExpectations:

10:08 PM Changeset in webkit [278649] by commit-queue@webkit.org

9 edits in trunk/Source

Move PrivacyStance code from WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=226774

Patch by Alex Christensen <achristensen@webkit.org> on 2021-06-08
Reviewed by Jer Noble.

Source/WebCore:

platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):

platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionTaskTransactionMetrics _privacyStance]):

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(toPrivacyStance):
(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

Source/WTF:

wtf/PlatformHave.h:

10:07 PM Changeset in webkit [278648] by commit-queue@webkit.org

9 edits in trunk

CSSOM test for serializing counter() fails
https://bugs.webkit.org/show_bug.cgi?id=184256

Patch by Rob Buis <rbuis@igalia.com> on 2021-06-08
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Update improved test result.

web-platform-tests/css/cssom/serialize-values-expected.txt:

Source/WebCore:

The last CSS component value should be omitted if it is "decimal" [1].

Behavior matches Firefox and Chrome.

[1] https://drafts.csswg.org/cssom/#serialize-a-css-component-value

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):

LayoutTests:

Adapt to serialization change.

fast/css/counters/counter-cssText-expected.txt:
fast/css/counters/counter-cssText.html:
fast/css/serialization-with-double-quotes-expected.txt:
fast/css/serialization-with-double-quotes.html:

10:03 PM Changeset in webkit [278647] by weinig@apple.com

9 edits in trunk/Source

Adopt WTF::Span in SQLiteStatement
https://bugs.webkit.org/show_bug.cgi?id=226773

Reviewed by Alex Christensen.

Source/WebCore:

Do some initial adoption of WTF::Span by adopting it in SQLiteStatement.

Removes class BlobView.
Renames columnBlobView to columnBlobAsSpan() (mirrors columnBlobAsString() naming) and have it return a Span<const uint8_t>.
Replace bindBlob(int index, const void* blob, int size) with bindBlob(int index, Span<const uint8_t>).

Due to implicit construction for types with data() and size() functions (actually anything
that std::data() and std::size() can reason about), Vector and SharedBuffer cleanly work
to convert to Span of the same underlying type. This means that many callers of bindBlob
are now simpler, as instead of doing:

bindBlob(1, foo->data(), foo->size());

we instead do:

bindBlob(1, *foo);

There is much much more to do to take advantage of this new type, but this is
kept intentionally small, as the pulling back the onion can go very deep.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::migrateIndexInfoTableForIDUpdate):
(WebCore::IDBServer::SQLiteIDBBackingStore::migrateIndexRecordsTableForIDUpdate):
(WebCore::IDBServer::SQLiteIDBBackingStore::addExistingIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindPreIndexStatementIfNecessary):
(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::columnBlob):
(WebCore::SQLiteStatement::columnBlobAsSpan):
(WebCore::SQLiteStatement::columnBlobView): Deleted.

platform/sql/SQLiteStatement.h:

(WebCore::SQLiteStatement::BlobView::BlobView): Deleted.
(WebCore::SQLiteStatement::BlobView::data): Deleted.
(WebCore::SQLiteStatement::BlobView::size): Deleted.
(): Deleted.

workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):

Source/WebKit:

UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::addIcon):
Adopt new bindBlob() signature.

9:55 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

9:38 PM Changeset in webkit [278646] by Jean-Yves Avenard

10 edits in trunk/Source

MediaPlayerPrivateRemote::didLoadingProgress should not send synchronous message to GPU process
https://bugs.webkit.org/show_bug.cgi?id=226761
rdar://78834312

Reviewed by Eric Carlson.

Source/WebCore:

Make MediaPlayer::didLoadingProgress method asynchronous. This method is particularly well
suited to be made async as there's only one calling point from the HTMLMediaElement that
occurs when the progressEventTimer gets fired. As such, when the operation is precisely run
isn't particularly relevant as per spec:
"While the load is not suspended (see below), every 350ms (±200ms) or for every byte received,

whichever is least frequent, queue a media element task given the media element to fire an
event named progress at the element.".

This allows to make the query to the GPU process async.
While we can expect the time to query the GPU process to take less than 200ms on average,
there will be no change in the obversable behaviour compare to the previous implementation
where the call to the GPU process was synchronous.
Covered by existing tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::progressEventTimerFired): Use new method definition.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::didLoadingProgress const):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::didLoadingProgressAsync const): Add default implementation
that calls the old sync didLoadingProgress method.

Source/WebKit:

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::didLoadingProgress): Forward call to the actual
proxied MediaPlayer.

GPUProcess/media/RemoteMediaPlayerProxy.messages.in: Make message async.
WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::didLoadingProgress const): This method should no
longer ever be called, but is required as it's pure-virtual.
(WebKit::MediaPlayerPrivateRemote::didLoadingProgressAsync const):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h: Add new didLoadingProgressAsync method.

9:33 PM Changeset in webkit [278645] by Chris Dumez

25 edits
2 deletes in trunk/Source/WebCore

Drop legacy EventLoopEventQueue class
https://bugs.webkit.org/show_bug.cgi?id=226748

Reviewed by Darin Adler.

Drop legacy EventLoopEventQueue class which was used by HTMLMediaElement. I added a
queueCancellableTaskToDispatchEvent() convenience function on ActiveDOMObject to
schedule cancellable events directly on the HTML event loop. The function takes
care of keeping the object and its wrapper alive until the event has fired.

Note that the previous code was using EventLoopEventQueue to dispatch events on
other objects than the HTMLMediaElement. This was wrong as it wouldn't take
care of keeping the real target's JS wrapper alive to actually dispatch the
event. As a result, I had to update a couple of media classes to subclass
ActiveDOMObject and the HTMLMediaElement now calls
queueCancellableTaskToDispatchEvent() directly on the target.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObjectEventDispatchTask::ActiveDOMObjectEventDispatchTask):
(WebCore::ActiveDOMObject::queueTaskToDispatchEventInternal):
(WebCore::ActiveDOMObject::queueCancellableTaskToDispatchEventInternal):

dom/ActiveDOMObject.h:
dom/EventLoopEventQueue.cpp: Removed.
dom/EventLoopEventQueue.h: Removed.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):
(WebCore::HTMLMediaElement::closeTaskQueues):
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
(WebCore::HTMLMediaElement::scheduleEventOn):

html/HTMLMediaElement.h:
html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::create):

html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::create):

html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::create):
(WebCore::TextTrack::activeDOMObjectName const):

html/track/TextTrack.h:
html/track/TextTrack.idl:
html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::create):
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::activeDOMObjectName const):

html/track/TextTrackCue.h:
html/track/TextTrackCue.idl:

8:29 PM Changeset in webkit [278644] by Megan Gardner

4 edits in trunk/Source/WebKit

Upstream AppHighlight Observer code
https://bugs.webkit.org/show_bug.cgi?id=226794

Reviewed by Tim Horton.

UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::appHighlightsVisibility):
(WebKit::WebPageProxy::setUpHighlightsObserver):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpAppHighlightMenusIfNeeded]):

8:04 PM Changeset in webkit [278643] by Diego Pino Garcia

2 edits in trunk/LayoutTests

[GLIB] Unreviewed test gardening. Update test expectation status of imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html.

platform/glib/TestExpectations:

7:32 PM Changeset in webkit [278642] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix speculated type in speculateNeitherDoubleNorHeapBigIntNorString
https://bugs.webkit.org/show_bug.cgi?id=226786

Reviewed by Mark Lam.

I had forgotten the HeapBigInt part.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNeitherDoubleNorHeapBigIntNorString):

7:26 PM Changeset in webkit [278641] by Ben Nham

4 edits in trunk/Source/WTF

Use access instead of stat in some filesystem functions
https://bugs.webkit.org/show_bug.cgi?id=226667

Reviewed by Chris Dumez.

We are spending a bit more time in WTF::FileSystemImpl functions after the move to
std::filesystem (https://bugs.webkit.org/show_bug.cgi?id=225255). In particular, several
std::filesystem functions (like the ones called by fileExists and makeAllDirectories) prefer
to use stat() over access() for file existence checks. Since our sandbox has a fast path for
access(path, F_OK) but not for stat, we ended up spending more time in sandbox evaluation in
the kernel after the move to std::filesystem.

Note that the two checks don't do exactly the same thing. access(path, F_OK) only checks for
path existence, while stat(path) additionally fetches metadata, which requires checking the
file-read-metadata permission. But in practice our code was written to be fine with just
checking for existence.

To work around this, I've re-introduced some of the old WTF::FileSystemImpl functions from
FileSystemPosix.cpp. They are the ones that are called by NetworkCache, which seems to be
the biggest consumer of these functions. The rest of the functions are still implemented
using std::filesystem.

wtf/FileSystem.cpp:

(WTF::FileSystemImpl::fileExists):
(WTF::FileSystemImpl::deleteFile):
(WTF::FileSystemImpl::makeAllDirectories):
(WTF::FileSystemImpl::pathByAppendingComponent):
(WTF::FileSystemImpl::pathByAppendingComponents):

wtf/PlatformEnableCocoa.h:
wtf/posix/FileSystemPOSIX.cpp:

7:23 PM Changeset in webkit [278640] by Devin Rousso

2 edits in trunk/Source/WebCore

Unreviewed, followup to r278630

Modules/applepay/ApplePaySession.h:

Remove mentions of file that doesn't exist anymore.

6:48 PM Changeset in webkit [278639] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, fix new -Wreturn-type warning
https://bugs.webkit.org/show_bug.cgi?id=226718
<rdar://problem/78947485>

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-06-08

rendering/HighlightData.cpp:

(WebCore::HighlightData::rangeForTextBox):

6:12 PM Changeset in webkit [278638] by Dewei Zhu

3 edits in trunk/Tools

Increase http server launch timeout on run-benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=226801

Reviewed by Ryosuke Niwa.

Installing twisted module in http server may take longer than 7.5 seconds.
Increase the timeout to be 31.5 seconds and add an early terminate if http server
process is not running.

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:

Removed unused import.

Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve):

6:10 PM Changeset in webkit [278637] by Diego Pino Garcia

1 edit
8 adds in trunk/LayoutTests

[GTK] Unreviewed test gardening. Emit GTK baselines for several SVG tests.

Other platforms have specific baselines for these tests, including WPE.

The GTK post-commit bot reports these tests have been consistently
failing for the last 4000 revisions, so emiting baselines is the first
step to check if these tests are actually passing.

platform/gtk/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
platform/gtk/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.

6:09 PM Changeset in webkit [278636] by Russell Epstein

1 copy in tags/Safari-612.1.17

Tag Safari-612.1.17.

6:02 PM Changeset in webkit [278635] by Jean-Yves Avenard

3 edits
2 adds in trunk

[MSE] Assertion if attempting to perform eviction before playback starts.
https://bugs.webkit.org/show_bug.cgi?id=226720
<rdar://problem/78943223>

Reviewed by Eric Carlson.

Source/WebCore:

Handle the case where the buffered range doesn't yet exist as we haven't parsed
an init segment yet.
Test: media/media-source/media-source-append-buffer-full-quota-exceeded-error-onstart.html

platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::evictCodedFrames): Exit early if the buffered range is empty
and handle the case where a buffered range index wasn't found.

LayoutTests:

media/media-source/media-source-append-buffer-full-quota-exceeded-error-onstart-expected.txt: Added.
media/media-source/media-source-append-buffer-full-quota-exceeded-error-onstart.html: Added.

5:00 PM Changeset in webkit [278634] by Diego Pino Garcia

1 edit
1 move
1 add in trunk/LayoutTests

[GLIB][WPE] Unreviewed test gardening. Move WPE baseline for WPT test 'report-same-origin-with-cookies.html' to GLIB.

platform/glib/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies-expected.txt.

4:30 PM Changeset in webkit [278633] by Wenson Hsieh

4 edits
2 adds in trunk

[iOS] Safari tab pill should toggle visibility when tapping on article text on adventure.com
https://bugs.webkit.org/show_bug.cgi?id=226775
rdar://78826820

Reviewed by Tim Horton and Devin Rousso.

Source/WebKit:

Adjust the meaningful click heuristic to account for click event listeners added to the document node. See below
for more details.

Test: fast/events/ios/non-meaningful-click-when-tapping-document.html

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPlatformEditorState const):
(WebKit::isProbablyMeaningfulClick):

Remove a check for whether or not the clicked node is an Element; this existed because the call to
rootViewBoundsForElement below takes an Element rather than just a Node; however, this method doesn't do
anything that requires an Element instead of a Node, so we can just remove the check and refactor these static
methods to accept Nodes. This allows us to bail early if the clicked node is *either* the body or the document
node, instead of just the body.

(WebKit::WebPage::insertDroppedImagePlaceholders):
(WebKit::elementBoundsInFrame):
(WebKit::WebPage::rootViewBounds):
(WebKit::WebPage::absoluteInteractionBounds):
(WebKit::WebPage::rootViewInteractionBounds):

Drive-by refactoring: drop the -ForElement suffixes on these helper methods, and additionally make them accept
a Node instead of requiring an Element. This allows us to remove the is<Element>() check from the meaningful
click heuristic above.

Also deploy RefPtr in a few more places.

(WebKit::WebPage::dispatchSyntheticMouseEventsForSelectionGesture):
(WebKit::WebPage::focusedElementInformation):
(WebKit::WebPage::rootViewBoundsForElement): Deleted.
(WebKit::WebPage::absoluteInteractionBoundsForElement): Deleted.
(WebKit::WebPage::rootViewInteractionBoundsForElement): Deleted.

LayoutTests:

fast/events/ios/non-meaningful-click-when-tapping-document-expected.txt: Added.
fast/events/ios/non-meaningful-click-when-tapping-document.html: Added.

3:48 PM Changeset in webkit [278632] by Diego Pino Garcia

8 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update GTK baselines of several ARIA tests.

These tests are marked as flaky under bug webkit.org/b/182761.

The GTK post-commit bot reports these tests have been consistently
failing for the last 4000 revisions, so at least their baselines
should be updated. I won't remove the tests from test expectations for
now.

accessibility/gtk/aria-busy-changed-notification-expected.txt:
accessibility/gtk/aria-current-changed-notification-expected.txt:
accessibility/gtk/aria-disabled-changed-notification-expected.txt:
accessibility/gtk/aria-expanded-changed-notification-expected.txt:
accessibility/gtk/aria-pressed-changed-notification-expected.txt:
accessibility/gtk/aria-readonly-changed-notification-expected.txt:
accessibility/gtk/aria-required-changed-notification-expected.txt:

3:19 PM Changeset in webkit [278631] by Diego Pino Garcia

2 edits
1 delete in trunk/LayoutTests

[GTK] Unreviewed test gardening. Remove obsolete GTK baseline for WPT test 'createImageBitmap-serializable.html'.

platform/glib/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-serializable-expected.txt: Removed.

3:15 PM Changeset in webkit [278630] by Devin Rousso

64 edits
9 copies
8 moves
14 adds in trunk

[Payment Request] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=226740
<rdar://problem/78963132>

Reviewed by Andy Estes.

Source/WebCore:

recurring line items (HAVE_PASSKIT_RECURRING_SUMMARY_ITEM and ENABLE_APPLE_PAY_RECURRING_LINE_ITEM)
deferred line items (HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM and ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM)
estimated shipping dates (HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE and ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE)
coupon code entry (HAVE_PASSKIT_COUPON_CODE and ENABLE_APPLE_PAY_COUPON_CODE)
shipped vs in-store pickup (HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE and ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE)

Tests: http/tests/paymentrequest/ApplePayModifier-additionalLineItems.https.html

http/tests/paymentrequest/ApplePayModifier-additionalShippingMethods.https.html
http/tests/paymentrequest/ApplePayModifier-total.https.html
http/tests/paymentrequest/paymentmethodchange-couponCode.https.html
http/tests/paymentrequest/paymentrequest-couponCode.https.html
http/tests/paymentrequest/paymentrequest-shippingContactEditingMode.https.html
http/tests/paymentrequest/paymentrequest-supportsCouponCode.https.html

Modules/applepay/ApplePayCouponCodeUpdate.idl: Copied from Source/WebCore/Modules/applepay/ApplePayPaymentMethodModeUpdate.idl.
Modules/applepay/ApplePayCouponCodeUpdate.h: Renamed from Source/WebCore/Modules/applepay/ApplePayPaymentMethodModeUpdate.h.

(WebCore::ApplePayCouponCodeUpdate::encode const):
(WebCore::ApplePayCouponCodeUpdate::decode):
Object used to update the payment request via ApplePaySession.prototype.completeCouponCodeChange
when responding to the user modifying the coupon code.

Modules/applepay/ApplePayErrorCode.idl:
Modules/applepay/ApplePayErrorCode.h:

Add "couponCodeInvalid" and "couponCodeExpired".

Modules/applepay/ApplePayLineItem.idl:
Modules/applepay/ApplePayLineItem.h:

(WebCore::ApplePayLineItem::encode const):
(WebCore::ApplePayLineItem::decode):

Modules/applepay/ApplePayPaymentTiming.idl: Added.
Modules/applepay/ApplePayPaymentTiming.h: Added.
Modules/applepay/ApplePayRecurringPaymentDateUnit.idl: Added.
Modules/applepay/ApplePayRecurringPaymentDateUnit.h: Added.

Add members that indicate whether this line item is immediate, recurring, or deferred.
Depending on that timing, additional members are added for further configuration (e.g. the
start and/or end date of a recurring payment, it's frequency, etc.).

Modules/applepay/ApplePayShippingMethod.idl:
Modules/applepay/ApplePayShippingMethod.h:

(WebCore::ApplePayShippingMethod::encode const):
(WebCore::ApplePayShippingMethod::decode):

Modules/applepay/ApplePayDateComponentsRange.idl: Added.
Modules/applepay/ApplePayDateComponentsRange.h: Added.

(WebCore::ApplePayDateComponentsRange::encode const):
(WebCore::ApplePayDateComponentsRange::decode):

Modules/applepay/ApplePayDateComponents.idl: Added.
Modules/applepay/ApplePayDateComponents.h: Added.

(WebCore::ApplePayDateComponents::encode const):
(WebCore::ApplePayDateComponents::decode):
Add members that can be used to indicate the estimated shipping dates for this shipping method.

Modules/applepay/ApplePayRequestBase.idl:
Modules/applepay/ApplePayRequestBase.h:
Modules/applepay/ApplePayRequestBase.cpp:

(WebCore::convertAndValidate):

Modules/applepay/ApplePaySessionPaymentRequest.h:

(WebCore::ApplePaySessionPaymentRequest::supportsCouponCode const): Added.
(WebCore::ApplePaySessionPaymentRequest::setSupportsCouponCode): Added.
(WebCore::ApplePaySessionPaymentRequest::couponCode const): Added.
(WebCore::ApplePaySessionPaymentRequest::setCouponCode): Added.
(WebCore::ApplePaySessionPaymentRequest::shippingContactEditingMode const): Added.
(WebCore::ApplePaySessionPaymentRequest::setShippingContactEditingMode): Added.

Modules/applepay/ApplePayShippingContactEditingMode.idl: Added.
Modules/applepay/ApplePayShippingContactEditingMode.h: Added.

Add members that indicate:

whether this payment request supports a coupon code at all
the initial coupon code (assuming the above)
whether this payment request allows editing the shipping contact (i.e. in-store pickup does not)

dom/EventNames.h:
dom/EventNames.in:

Modules/applepay/ApplePayCouponCodeChangedEvent.idl: Added.
Modules/applepay/ApplePayCouponCodeChangedEvent.h: Added.
Modules/applepay/ApplePayCouponCodeChangedEvent.cpp: Added.

(WebCore::ApplePayCouponCodeChangedEvent::ApplePayCouponCodeChangedEvent):
(WebCore::ApplePayCouponCodeChangedEvent::eventInterface const):
Add a "couponcodechange" event that is dispatched whenever the user modifies the coupon code for an ApplePaySession.

Modules/applepay/ApplePayCouponCodeDetails.idl: Copied from Source/WebCore/Modules/applepay/ApplePayPaymentMethodModeDetails.idl.
Modules/applepay/ApplePayCouponCodeDetails.h: Copied from Source/WebCore/Modules/applepay/ApplePayPaymentMethodModeUpdate.idl.

Used as the object methodData when a PaymentMethodChangeEvent is dispatched for a PaymentRequest.

Modules/applepay/ApplePaySession.idl:
Modules/applepay/ApplePaySession.h:
Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
(WebCore::ApplePaySession::completeCouponCodeChange): Added.
(WebCore::ApplePaySession::didChangeCouponCode): Renamed from WebCore::ApplePaySession::didChangePaymentMethodMode.
(WebCore::ApplePaySession::canSuspendWithoutCanceling const):
(WebCore::ApplePaySession::canBegin const):
(WebCore::ApplePaySession::canAbort const):
(WebCore::ApplePaySession::canCancel const):
(WebCore::ApplePaySession::canCompleteShippingMethodSelection const):
(WebCore::ApplePaySession::canCompleteShippingContactSelection const):
(WebCore::ApplePaySession::canCompletePaymentMethodSelection const):
(WebCore::ApplePaySession::canCompleteCouponCodeChange const): Renamed from WebCore::ApplePaySession::canCompletePaymentMethodModeChange const.
(WebCore::ApplePaySession::canCompletePayment const):
(WebCore::ApplePaySession::isFinalState const):

Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
(WebCore::ApplePayPaymentHandler::didChangeCouponCode): Renamed from WebCore::ApplePayPaymentHandler::didChangePaymentMethodMode.
Add methods for JS to call and state logic to handle coupon code changes.

Modules/applepay/PaymentCoordinator.h:
Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::completeCouponCodeChange): Renamed from WebCore::PaymentCoordinator::completePaymentMethodModeChange.
(WebCore::PaymentCoordinator::didChangeCouponCode): Renamed from WebCore::PaymentCoordinator::didChangePaymentMethodMode.

Modules/applepay/PaymentCoordinatorClient.h:
loader/EmptyClients.cpp:

(WebCore::EmptyPaymentCoordinatorClient::completeCouponCodeChange): Renamed from WebCore::EmptyPaymentCoordinatorClient::completePaymentMethodModeChange.
Plumbing up to WebKit.

Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm:

(WebCore::toDate): Added.
(WebCore::toCalendarUnit): Added.
(WebCore::toPKPaymentSummaryItem):
Convert WebCore objects to PassKit objects.

testing/MockPaymentCoordinator.idl:
testing/MockPaymentCoordinator.h:
testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeCouponCodeChange): Renamed from WebCore::MockPaymentCoordinator::completePaymentMethodModeChange.
(WebCore::MockPaymentCoordinator::changeCouponCode): Added.

Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:

(WebCore::PaymentAPIVersion::current):

Modules/applepay/PaymentHeaders.h:
Modules/applepay/PaymentSession.h:

Modules/applepay/ApplePayLineItemData.idl: Removed.
Modules/applepay/ApplePayLineItemData.h: Removed.
Modules/applepay/ApplePayShippingMethodData.idl: Removed.
Modules/applepay/ApplePayShippingMethodData.h: Removed.

Remove unnecessary base types after r275169.

PlatformMac.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:

Source/WebCore/PAL:

recurring line items (HAVE_PASSKIT_RECURRING_SUMMARY_ITEM and ENABLE_APPLE_PAY_RECURRING_LINE_ITEM)
deferred line items (HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM and ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM)
estimated shipping dates (HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE and ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE)
coupon code entry (HAVE_PASSKIT_COUPON_CODE and ENABLE_APPLE_PAY_COUPON_CODE)
shipped vs in-store pickup (HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE and ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE)

pal/cocoa/PassKitSoftLink.h:
pal/cocoa/PassKitSoftLink.mm:
pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

recurring line items (HAVE_PASSKIT_RECURRING_SUMMARY_ITEM and ENABLE_APPLE_PAY_RECURRING_LINE_ITEM)
deferred line items (HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM and ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM)
estimated shipping dates (HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE and ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE)
coupon code entry (HAVE_PASSKIT_COUPON_CODE and ENABLE_APPLE_PAY_COUPON_CODE)
shipped vs in-store pickup (HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE and ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE)

Platform/cocoa/PaymentAuthorizationViewController.mm: (-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didChangeCouponCode:handler:]): Added.
Platform/ios/PaymentAuthorizationController.mm: (-[WKPaymentAuthorizationControllerDelegate paymentAuthorizationController:didChangeCouponCode:handler:]): Added.

Platform/cocoa/PaymentAuthorizationPresenter.h:
Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::toPKPaymentErrorCode):
(WebKit::PaymentAuthorizationPresenter::completeCouponCodeChange): Renamed from WebKit::PaymentAuthorizationPresenter::completePaymentMethodModeChange.

Platform/cocoa/WKPaymentAuthorizationDelegate.h:
Platform/cocoa/WKPaymentAuthorizationDelegate.mm:

(-[WKPaymentAuthorizationDelegate completeCouponCodeChange:]): Added.
(toDateComponents): Added.
(toDateComponentsRange): Added.
(toShippingMethod):
(-[WKPaymentAuthorizationDelegate _didChangeCouponCode:completion:]): Added.
Add plumbing from/to PassKit for coupon code changes.

Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
Shared/ApplePay/WebPaymentCoordinatorProxy.h:
Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::completeCouponCodeChange): Renamed from WebKit::WebPaymentCoordinatorProxy::completePaymentMethodModeChange.
(WebKit::WebPaymentCoordinatorProxy::presenterDidChangeCouponCode): Renamed from WebKit::WebPaymentCoordinatorProxy::presenterDidChangePaymentMethodMode.
(WebKit::WebPaymentCoordinatorProxy::canBegin const):
(WebKit::WebPaymentCoordinatorProxy::canCancel const):
(WebKit::WebPaymentCoordinatorProxy::canCompletePayment const):
(WebKit::WebPaymentCoordinatorProxy::canAbort const):

Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSDateComponents): Added.
(WebKit::toPKDateComponentsRange): Added.
(WebKit::toPKShippingMethod):
(WebKit::toPKShippingContactEditingMode): Added.
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteCouponCodeChange): Renamed from WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentMethodModeChange.
Convert PassKit objects to/from WebCore objects.

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::decode):

WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
WebProcess/ApplePay/WebPaymentCoordinator.h:
WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::completeCouponCodeChange): Renamed from WebKit::WebPaymentCoordinator::completePaymentMethodModeChange.
(WebKit::WebPaymentCoordinator::didChangeCouponCode): Renamed from WebKit::WebPaymentCoordinator::didChangePaymentMethodMode.
Plumbing into/from WebCore.

Source/WebKitLegacy/mac:

recurring line items (HAVE_PASSKIT_RECURRING_SUMMARY_ITEM and ENABLE_APPLE_PAY_RECURRING_LINE_ITEM)
deferred line items (HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM and ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM)
estimated shipping dates (HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE and ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE)
coupon code entry (HAVE_PASSKIT_COUPON_CODE and ENABLE_APPLE_PAY_COUPON_CODE)
shipped vs in-store pickup (HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE and ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE)

WebCoreSupport/WebPaymentCoordinatorClient.h:
WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::completeCouponCodeChange): Renamed from WebPaymentCoordinatorClient::completePaymentMethodModeChange.

Source/WTF:

recurring line items (HAVE_PASSKIT_RECURRING_SUMMARY_ITEM and ENABLE_APPLE_PAY_RECURRING_LINE_ITEM)
deferred line items (HAVE_PASSKIT_DEFERRED_SUMMARY_ITEM and ENABLE_APPLE_PAY_DEFERRED_LINE_ITEM)
estimated shipping dates (HAVE_PASSKIT_SHIPPING_METHOD_DATE_COMPONENTS_RANGE and ENABLE_APPLE_PAY_SHIPPING_METHOD_DATE_COMPONENTS_RANGE)
coupon code entry (HAVE_PASSKIT_COUPON_CODE and ENABLE_APPLE_PAY_COUPON_CODE)
shipped vs in-store pickup (HAVE_PASSKIT_SHIPPING_CONTACT_EDITING_MODE and ENABLE_APPLE_PAY_SHIPPING_CONTACT_EDITING_MODE)

wtf/PlatformHave.h:
wtf/PlatformEnableCocoa.h:

LayoutTests:

http/tests/paymentrequest/ApplePayModifier-additionalLineItems.https.html: Added.
http/tests/paymentrequest/ApplePayModifier-additionalLineItems.https-expected.txt: Added.
http/tests/paymentrequest/ApplePayModifier-additionalShippingMethods.https.html: Added.
http/tests/paymentrequest/ApplePayModifier-additionalShippingMethods.https-expected.txt: Added.
http/tests/paymentrequest/ApplePayModifier-total.https.html: Added.
http/tests/paymentrequest/ApplePayModifier-total.https-expected.txt: Added.
http/tests/paymentrequest/paymentmethodchange-couponCode.https.html: Added.
http/tests/paymentrequest/paymentmethodchange-couponCode.https-expected.txt: Added.
http/tests/paymentrequest/paymentrequest-couponCode.https.html: Added.
http/tests/paymentrequest/paymentrequest-couponCode.https-expected.txt: Added.
http/tests/paymentrequest/paymentrequest-shippingContactEditingMode.https.html: Added.
http/tests/paymentrequest/paymentrequest-shippingContactEditingMode.https-expected.txt: Added.
http/tests/paymentrequest/paymentrequest-supportsCouponCode.https.html: Added.
http/tests/paymentrequest/paymentrequest-supportsCouponCode.https-expected.txt: Added.
http/tests/ssl/applepay/ApplePayError-expected.txt:

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

2:39 PM Changeset in webkit [278629] by Truitt Savell

3 edits in trunk/LayoutTests

Fix test expectations for plugin tests on arm64
https://bugs.webkit.org/show_bug.cgi?id=226783

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

2:26 PM Changeset in webkit [278628] by Russell Epstein

1 copy in tags/Safari-612.1.16.5

Tag Safari-612.1.16.5.

1:44 PM Changeset in webkit [278627] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, fix build after r278621
https://bugs.webkit.org/show_bug.cgi?id=226731
<rdar://problem/79021715>

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-06-08

rendering/MarkedText.cpp:

1:18 PM Changeset in webkit [278626] by Devin Rousso

3 edits in trunk/LayoutTests

Unreviewed, followup to r278622

TestExpectations:
platform/mac-wk2/TestExpectations:

Skip http/tests/media/modern-media-controls/overflow-support on non-WK2 macOS and iOS
since those tests rely on macOS functionality and new iOS features.

12:59 PM Changeset in webkit [278625] by Russell Epstein

8 edits in branches/safari-612.1.16-branch/Source

Versioning.

WebKit-7612.1.16.5

12:58 PM Changeset in webkit [278624] by Fujii Hironori

3 edits in trunk/Tools

run-webkit-tests: TaskPool reports PicklingError for Windows Python
https://bugs.webkit.org/show_bug.cgi?id=226710

Reviewed by Jonathan Bedard.

Since r278454 changed run-webkit-tests to use TaskPool,
run-webkit-tests reported PicklingError for Windows Python. It
couldn't pickle Port object. This issue happened on multi-core PC,
but on single CPU tester bot machines.

WrappedPopen couldn't be pickled because it was defined as an
inner class. It should be defined at the top-level.

The instance variables _web_platform_test_server,
_websocket_server_temporary_directory, and
_websocket_secure_server of Port object aren't pickleable. Make
them class variables.

Scripts/webkitpy/common/system/executive.py:

(WrappedPopen):
(Executive.WrappedPopen):

Scripts/webkitpy/port/base.py:

(Port):
(Port.init):
(Port.ports_to_forward):
(Port.is_websocket_server_running):
(Port.is_wpt_server_running):
(Port.start_websocket_server):
(Port.start_web_platform_test_server):
(Port.stop_websocket_server):
(Port.stop_web_platform_test_server):

12:16 PM Changeset in webkit [278623] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r278619.

platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):

11:39 AM Changeset in webkit [278622] by Devin Rousso

3 edits
3 adds in trunk

[Modern Media Controls] Don't show Playback Speed when up-to-date Live Boadcasts
https://bugs.webkit.org/show_bug.cgi?id=226744

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html

Modules/modern-media-controls/media/overflow-support.js:

(OverflowSupport.prototype.get mediaEvents):
(OverflowSupport.prototype.syncControl):
(OverflowSupport.prototype.get _includePlaybackRates): Added.
Rework existing logic that determines whether to include "Playback Speed" into a separate
function for clarity.

LayoutTests:

http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html: Added.
http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast-expected.txt: Added.

11:02 AM Changeset in webkit [278621] by Antti Koivisto

8 edits in trunk

Factor MarkedText collection out of LegacyInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=226731

Reviewed by Sam Weinig.

Source/WebCore:

Move more code out from the legacy inline classes.

rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::paint):
(WebCore::LegacyInlineTextBox::hasMarkers const):
(WebCore::LegacyInlineTextBox::paintPlatformDocumentMarkers):
(WebCore::LegacyInlineTextBox::calculateUnionOfAllDocumentMarkerBounds const):
(WebCore::LegacyInlineTextBox::paintMarkedTexts):
(WebCore::LegacyInlineTextBox::highlightStartEnd const): Deleted.
(WebCore::LegacyInlineTextBox::collectMarkedTextsForDraggedContent): Deleted.
(WebCore::LegacyInlineTextBox::collectMarkedTextsForDocumentMarkers const): Deleted.
(WebCore::LegacyInlineTextBox::collectMarkedTextsForHighlights const): Deleted.

rendering/LegacyInlineTextBox.h:

(WebCore::LegacyInlineTextBox::paintMarkedTexts):

rendering/MarkedText.cpp:

(WebCore::MarkedText::subdivide):
(WebCore::MarkedText::collectForHighlights):
(WebCore::MarkedText::collectForDocumentMarkers):
(WebCore::MarkedText::collectForDraggedContent):
(WebCore::subdivide): Deleted.

rendering/MarkedText.h:

(WebCore::MarkedText::operator== const):

rendering/MarkedTextStyle.cpp:

(WebCore::subdivideAndResolveStyle):

Tools:

TestWebKitAPI/Tests/WebCore/MarkedText.cpp:

(TestWebKitAPI::TEST):

11:01 AM Changeset in webkit [278620] by Truitt Savell

1880 edits
2 moves
119 adds
171 deletes in trunk

Unreviewed, reverting r278609.

Broke builds with a linker error.

Reverted changeset:

"Update libwebrtc to M92"
https://bugs.webkit.org/show_bug.cgi?id=226494
https://commits.webkit.org/r278609

10:35 AM Changeset in webkit [278619] by Chris Dumez

77 edits in trunk/Source

Reduce use of reinterpret_cast<> in the codebase
https://bugs.webkit.org/show_bug.cgi?id=226743

Reviewed by Darin Adler.

Source/WebCore:

Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::generateKeyRequest):

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::take):

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeAsBlob):
(WebCore::FetchBodyConsumer::takeAsText):

Modules/mediastream/RTCDataChannelRemoteHandler.cpp:

(WebCore::RTCDataChannelRemoteHandler::readyToSend):
(WebCore::RTCDataChannelRemoteHandler::sendStringData):
(WebCore::RTCDataChannelRemoteHandler::sendRawData):

Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp:

(WebCore::copyBusData):

Modules/webauthn/AuthenticatorResponseData.h:

(WebCore::encodeArrayBuffer):
(WebCore::decodeArrayBuffer):

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
(WebCore::headerHasValidHTTPVersion):

bindings/js/ScriptBufferSourceProvider.h:
bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readString):

contentextensions/SerializedNFA.cpp:

(WebCore::ContentExtensions::SerializedNFA::pointerAtOffsetInFile const):

dom/Node.cpp:

(WebCore::hashPointer):

dom/TextEncoder.cpp:

(WebCore::TextEncoder::encode const):

dom/TextEncoderStreamEncoder.cpp:

(WebCore::TextEncoderStreamEncoder::flush):

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::sanitizeMarkupWithArchive):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::texImageArrayBufferViewHelper):

inspector/DOMPatchSupport.cpp:

(WebCore::addStringToSHA1):

loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::textFromUTF8):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::showText):

platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunk):

platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::createCFData const):

platform/generic/KeyedEncoderGeneric.cpp:

(WebCore::KeyedEncoderGeneric::encodeString):

platform/graphics/GraphicsContextGL.cpp:

(WebCore::GraphicsContextGL::packImageData):

platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processNativeSamples):

platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):
(WebCore::CDMSessionAVFoundationCF::update):

platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):

platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemBuffer::createItemBuffer):

platform/graphics/displaylists/DisplayListIterator.cpp:

(WebCore::DisplayList::DisplayList::Iterator::updateCurrentItem):

platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::data const):

platform/mac/SSLKeyGeneratorMac.mm:

(WebCore::signedPublicKeyAndChallengeString):

platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::addStringToSHA1):

platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::encodeStringAsFormData):

platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::sendHandshake):

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):

platform/network/cf/ResourceRequestCFNet.h:

(WebCore::httpHeaderValueUsingSuitableEncoding):

platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::generateBaseFilename):

platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::columnBlobView):

testing/MockCDMFactory.cpp:

(WebCore::MockCDM::sanitizeResponse const):

Source/WebDriver:

socket/HTTPParser.cpp:

(WebDriver::HTTPParser::readLine):

socket/SessionHostSocket.cpp:

(WebDriver::SessionHost::sendWebInspectorEvent):

Source/WebKit:

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerInitializationDataEncountered):

GPUProcess/media/RemoteTextTrackProxy.cpp:

(WebKit::RemoteTextTrackProxy::addDataCue):

GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::fetchData):

NetworkProcess/cache/NetworkCacheDataCurl.cpp:

(WebKit::NetworkCache::Data::apply const):

NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::hashString):

NetworkProcess/soup/WebKitDirectoryInputStream.cpp:

(webkitDirectoryInputStreamRead):

Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<CString>::encode):
(IPC::ArgumentCoder<String>::encode):

Shared/API/c/cf/WKStringCF.mm:

(WKStringCopyCFString):

Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL):

Shared/ShareableResource.cpp:

(WebKit::ShareableResource::wrapInSharedBuffer):

Shared/SharedDisplayListHandle.h:

(WebKit::SharedDisplayListHandle::data const):

Shared/WebCompiledContentRuleList.cpp:

(WebKit::WebCompiledContentRuleList::conditionsApplyOnlyToDomain const):

UIProcess/API/APIWebAuthenticationAssertionResponse.cpp:

(API::WebAuthenticationAssertionResponse::userHandle const):

UIProcess/API/C/WKPage.cpp:

(dataFrom):

UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm:

(WebKit::RedirectSOAuthorizationSession::completeInternal):

UIProcess/Inspector/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::sendWebInspectorEvent):

WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::createMessageQueue):
(WebKit::WebSocketChannel::didReceiveText):

WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:

(WebKit::RTCDataChannelRemoteManager::sendData):
(WebKit::RTCDataChannelRemoteManager::RemoteSourceConnection::didReceiveStringData):

WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::sendJavaScriptStream):

Source/WTF:

wtf/CryptographicallyRandomNumber.cpp:
wtf/FastMalloc.h:

(WTF::FastAllocator::allocate):

wtf/SHA1.h:

(WTF::SHA1::addBytes):

wtf/StackCheck.h:

(WTF::StackCheck::Scope::Scope):
(WTF::StackCheck::StackCheck):

wtf/URLHelpers.cpp:

(WTF::URLHelpers::userVisibleURL):

wtf/URLParser.cpp:

(WTF::URLParser::formURLDecode):

wtf/cf/URLCF.cpp:

(WTF::URL::createCFURL const):

wtf/cocoa/URLCocoa.mm:

(WTF::URL::createCFURL const):

wtf/persistence/PersistentCoders.cpp:

(WTF::Persistence::Coder<CString>::encode):
(WTF::Persistence::Coder<String>::encode):

wtf/text/CString.h:
wtf/text/WTFString.cpp:

(WTF::String::latin1 const):

wtf/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

10:27 AM Changeset in webkit [278618] by Devin Rousso

21 edits
8 adds in trunk

[Modern Media Controls] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=226736
<rdar://problem/78957464>

Reviewed by Eric Carlson.

Source/WebCore:

bring the "Audio"/"Languages" tracks menu to iOS
add a new "Playback Speed" menu in the overflow menu on iOS and macOS
add support for showing the most relevant <track kind="chapters"> in the overflow menu on iOS and macOS

Tests: media/modern-media-controls/overflow-button/overflow-button.html

media/modern-media-controls/overflow-support/chapters.html
media/modern-media-controls/overflow-support/playback-speed.html

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::showMediaControlsContextMenu):

Modules/modern-media-controls/media/overflow-support.js:

(OverflowSupport.prototype.get mediaEvents):
(OverflowSupport.prototype.get tracksToMonitor):
(OverflowSupport.prototype.syncControl):

en.lproj/Localizable.strings:

rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsScripts):

rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderThemeAdwaita::mediaControlsScripts):

rendering/RenderThemeAdwaita.h:
rendering/RenderThemeCocoa.h:
rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::purgeCaches):
(WebCore::RenderThemeCocoa::mediaControlsScripts):

rendering/RenderThemeWin.h:
rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::mediaControlsScripts):
Drop the "additional script" and lower the inline capacity of the Vector.

testing/Internals.idl:
testing/Internals.h:
testing/Internals.cpp:

(WebCore::Internals::setMediaControlsHidePlaybackRates): Added.

html/HTMLMediaElement.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMediaControlsHidePlaybackRates): Added.
Since Playback Rates is always shown, provide a way for tests to turn it off.

Source/WTF:

bring the "Audio"/"Languages" tracks menu to iOS
add a new "Playback Speed" menu on iOS and macOS in the overflow menu
add support for showing the most relevant <track kind="chapters"> in the overflow menu

wtf/PlatformEnableCocoa.h:

LayoutTests:

media/modern-media-controls/overflow-button/overflow-button.html: Added.
media/modern-media-controls/overflow-button/overflow-button-expected.txt: Added.
media/modern-media-controls/overflow-support/chapters.html: Added.
media/modern-media-controls/overflow-support/chapters-expected.txt: Added.
media/modern-media-controls/overflow-support/playback-speed.html: Added.
media/modern-media-controls/overflow-support/playback-speed-expected.txt: Added.

TestExpectations:
platform/mac-wk2/TestExpectations:

10:09 AM Changeset in webkit [278617] by Russell Epstein

1 copy in tags/Safari-607.3.14

Tag Safari-607.3.14.

9:54 AM Changeset in webkit [278616] by weinig@apple.com

6 edits
3 adds in trunk

Add copy of std::span so that we can use it pre-moving to c++20
https://bugs.webkit.org/show_bug.cgi?id=226351

Reviewed by Alex Christensen.

Source/WTF:

Imports a copy of Tristan Brindle's Boost licensed implementation of std::span
from 5d8d366eca918d0ed3d2d196cbeae6abfd874736 of https://github.com/tcbrindle/span.

It has been further modified to rename tcb::span to WTF::Span.

LICENSE_1_0-Boost.txt: Added.
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Span.h: Added.

Tools:

Add basic WTF::Span test to make sure things compile and work.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/Span.cpp: Added.

9:54 AM Changeset in webkit [278615] by Russell Epstein

1 edit in branches/safari-607-branch/Source/WebCore/css/FontFace.cpp

Apply patch. rdar://problem/78789795

9:53 AM Changeset in webkit [278614] by Devin Rousso

9 edits in trunk/Source

Require that callsites of SnapshotOptions specify a PixelFormat and DestinationColorSpace
https://bugs.webkit.org/show_bug.cgi?id=226756

Reviewed by Sam Weinig.

Don't wrap PixelFormat or DestinationColorSpace with std::optional as we want each
callsite to explicity configure them. This makes it easier to find where values for each
are used as there's no implicit behavior.

No behavior change. Followup after r278565.

Source/WebCore:

page/FrameSnapshotting.h:
page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
(WebCore::snapshotFrameRectWithClip):
(WebCore::snapshotNode):
(WebCore::snapshotSelection):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

page/TextIndicator.cpp:

(WebCore::snapshotOptionsForTextIndicatorOptions):
(WebCore::takeSnapshots):

platform/DragImage.cpp:

(WebCore::createDragImageForNode):
(WebCore::createDragImageForSelection):
(WebCore::createDragImageForRange):
(WebCore::createDragImageForImage):

Source/WebKit:

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

9:51 AM Changeset in webkit [278613] by Russell Epstein

2 edits in branches/safari-607-branch/Source/JavaScriptCore

Apply patch. rdar://problem/78628017

9:45 AM Changeset in webkit [278612] by Russell Epstein

7 edits in branches/safari-607-branch/Source

Versioning.

WebKit-7607.3.14

9:35 AM Changeset in webkit [278611] by weinig@apple.com

6 edits in trunk

Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties
https://bugs.webkit.org/show_bug.cgi?id=226768

Reviewed by Antti Koivisto.

Source/WebCore:

Replace hand rolled isDescriptorOnly, isDirectionAwareProperty and isColorProperty
functions with generated versions using new "color-property", "direction-aware-property"
and "descriptor-only" properties in CSSProperties.json.

css/CSSProperties.json:
css/CSSProperty.cpp:

(WebCore::CSSProperty::isDescriptorOnly): Deleted.
(WebCore::CSSProperty::isDirectionAwareProperty): Deleted.
(WebCore::CSSProperty::isColorProperty): Deleted.

css/makeprop.pl:

(addProperty):

Tools:

Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONCSSPropertiesChecker.check_codegen_properties):
Add new codegen properties to the checker.

9:27 AM Changeset in webkit [278610] by graouts@webkit.org

3 edits
2 adds in trunk

REGRESSION (r256095): Adding a border-radius, border, or box-shadow breaks animations from scale(0)
https://bugs.webkit.org/show_bug.cgi?id=218371
<rdar://problem/70906316>

Reviewed by Simon Fraser.

Source/WebCore:

When computing an animation's transform extent, we must account for implicit keyframes.

Test: webanimations/accelerated-transform-animation-to-scale-zero-with-implicit-from-keyframe.html

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):

LayoutTests:

Add a test where we have an animation on an element with a a border and a transform animation to scale(0) where the
first keyframe is implicit. This test would fail prior to this patch.

webanimations/accelerated-transform-animation-to-scale-zero-with-implicit-from-keyframe-expected.html: Added.
webanimations/accelerated-transform-animation-to-scale-zero-with-implicit-from-keyframe.html: Added.

9:14 AM Changeset in webkit [278609] by youenn@apple.com

1880 edits
2 moves
465 adds
117 deletes in trunk

Update libwebrtc to M92
https://bugs.webkit.org/show_bug.cgi?id=226494

LayoutTests/imported/w3c:

Reviewed by Eric Carlson.

web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
web-platform-tests/webrtc/protocol/rtp-payloadtypes-expected.txt:
web-platform-tests/webrtc/protocol/unknown-mediatypes-expected.txt:
web-platform-tests/webrtc/receiver-track-live.https-expected.txt:

Source/ThirdParty/libwebrtc:

Reviewed by Eric Carlson.

CMakeLists.txt:
Source/webrtc: Resynced.
libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Reviewed by Eric Carlson.

Covered by existing tests.

Configurations/WebCore.xcconfig:
Configurations/WebCoreTestSupport.xcconfig:
Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::LibWebRTCRtpReceiverBackend::createSource):

Modules/mediastream/libwebrtc/LibWebRTCStatsCollector.cpp:

(WebCore::fillInboundRtpStreamStats):
(WebCore::fillOutboundRtpStreamStats):
(WebCore::fillRTCIceCandidateStats):

platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::signalingThread):
(WebCore::LibWebRTCProvider::createPeerConnectionFactory):
(WebCore::LibWebRTCProvider::setPeerConnectionFactory):
(WebCore::LibWebRTCProvider::createPeerConnection):

platform/mediastream/libwebrtc/LibWebRTCProvider.h:
testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::createConnection):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnectionOrError):

testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

Reviewed by Eric Carlson.

webrtc/receiver-track-should-stay-live-even-if-receiver-is-inactive.html:

Update test since the backend is now fixed.

8:58 AM Changeset in webkit [278608] by achristensen@apple.com

1 edit
1 add in trunk/LayoutTests

Update Windows PerformanceResourceTiming test expectations after r278477
https://bugs.webkit.org/show_bug.cgi?id=226737

platform/win/performance-api/resource-timing-apis-expected.txt: Added.

8:57 AM Changeset in webkit [278607] by Razvan Caliman

9 edits
4 adds in trunk

Web Inspector: Styles panel slow to render when inspecting node with many inherited CSS variables
https://bugs.webkit.org/show_bug.cgi?id=225972
<rdar://problem/78211185>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Do not show unused inherited CSS variables in the Styles details sidebar.

When aggregating styles for the selected node in WI.DOMNodeStyles, collect a list of names of CSS variables used in CSS property values.
In the Styles details sidebar, skip rendering declarations of inherited CSS variables that are not found in this list.

Always show inherited variables that are used, either directly inherited or via reference (variables using other variables in their value).
Always show inherited variables used as values of inheritable properties like color, font-size, etc.

When a CSS rule contains hidden inherited variables, offer a button to request disclosing them for that rule.
Option-click to show unused inherited variables in all matching rules.

Clicking the "Go to variable" button automatically renders all the unused variables in the CSS rule where the target variable is declared.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.findVariableNames):

UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles):
(WI.DOMNodeStyles.prototype.get usedCSSVariables):
(WI.DOMNodeStyles.prototype._updateStyleCascade):
(WI.DOMNodeStyles.prototype._collectUsedCSSVariables):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .property):
(.spreadsheet-style-declaration-editor > .hidden-variables-button):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get propertiesToRender):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.highlightProperty):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.set propertyVisibilityMode):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorSetAllPropertyVisibilityMode):

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.spreadsheetCSSStyleDeclarationSectionSetAllPropertyVisibilityMode):

LayoutTests:

Add tests for logic to aggregate used CSS variables in Web Inspector.

inspector/css/findVariableNames-expected.txt: Added.
inspector/css/findVariableNames.html: Added.
inspector/css/usedCSSVariables-expected.txt: Added.
inspector/css/usedCSSVariables.html: Added.

7:16 AM Changeset in webkit [278606] by Philippe Normand

2 edits in trunk/Tools

[Flatpak SDK] Enable network access in the WPE build sandbox
https://bugs.webkit.org/show_bug.cgi?id=225914

Reviewed by Michael Catanzaro.

flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Allow network access for WPE build jobs, so that CMake is
able to git checkout Cog from github.

7:02 AM Changeset in webkit [278605] by Alan Bujtas

5 edits
2 adds in trunk

[LFC][TFC] Add initial percent value support for columns
https://bugs.webkit.org/show_bug.cgi?id=226751

Reviewed by Simon Fraser.

Source/WebCore:

This patch adds the initial support for content like this:
<table>

<tr>

<td style="width: 10%"></td><td style="width: 90%"></td>

</tr>

</table>

Percent values work in mysterious ways in cases when the table has no fixed width.

The smaller the percent value is, the wider the table may become.

Percent values are resolved against the cell's border box (so essentially they are resolved
against their own content as opposed to the table/containing block) and the formula is slightly different.

<td style="padding: 5px; width: 20%;"></td> : produces a 10px wide border box (horizontal border: 0px, padding: 10px, content: 0px).

The maximum constraint is resolved to 50px (width / percent * 100)

<td style="padding: 5px; width: 100%;"></td> : produces a 10px wide border box and the maximum constraint is resolved to 10px.

This maximum constraint value turns into the available width for the table content and becomes the final table width.

With multiple rows, we pick the highest _percent_ value for each column (as opposed to the resolved values).

<tr><td style="width: 20%"></td></tr> (assum same 5px padding on both sides)
<tr><td style="width: 80%"></td></tr>

While the second row's cell has a higher maximum constraint value (50px see #1) since we only look at the raw percent values,
this content only produces a 12.5px wide table.

The percent values do not accumulate across columns but instead we pick the largest one to represent the entire table's max constraint width.

<tr><td style="width: 60%"></td><td style="width: 40%"></td></tr>

60% resolves to 16.6px
40% resolves to 25px and we use the 25px value as the width for the entire table (and not 16.6px + 25px).

Since we pick the highest percent values across rows for each columns, we may end up with > 100%. In such cases we start dropping percent values for subsequent columns:

<tr><td style="width: 20%;"></td><td style="width: 80%;"></td></tr>
<tr><td style="width: 60%;"></td><td style="width: 10%;"></td></tr>

First column width is max(20%, 60%) -> 60%
Second column width is max(80%, 10%) -> 80%
As we limit the accumulated percent value to 100%, the final column percent values are 60% and 40% (and not 80%).
Now the 60% is resolved to 16.6px and the 40% is resolved to 25px and since we don't accumulate these values (see #3)
the final table width is 25px (based on a percent value which is not even in the markup).

While the smaller percent values produce wider tables (see #1), during the available space distribution columns with smaller percent values get assigned less space.

<tr><td style="width: 1%"></td><td style="width: 99%"></td></tr>

This content produces a 1000px wide table due to the small (1%) percent value (see #1 #2 and #3).
When we distribute the available space (1000px), the first cell gets only 10px (1%) while the second cell ends up with 990px (99%).

(and this is the cherry on top (not included in this patch):

Imagine the following scenario:

the accumulated column percent value > 100% (let's say 80% and 30%)
as we reach the 100% while walking the columns one by one (see #4), the remaining percent value becomes 0%.
In order to avoid division by 0, we pick a very small epsilon value to run the formula.
Now this very small percent value produces a large resolved value (see #2) which means

<tr><td style="width: 100%"></td></tr>

produces a 10px wide table

<tr><td style="width: 100%"></td><td style="width: 1%"></td></tr> <- note the 1%

produces a very very very wide table.

)

Test: fast/layoutformattingcontext/table-with-percent-columns-only-no-content.html

layout/formattingContexts/table/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns):

layout/formattingContexts/table/TableGrid.h:

(WebCore::Layout::TableGrid::Column::percent const):
(WebCore::Layout::TableGrid::Column::setFixedWidth):
(WebCore::Layout::TableGrid::Column::setPercent):

layout/formattingContexts/table/TableLayout.cpp:

(WebCore::Layout::TableFormattingContext::TableLayout::distributedHorizontalSpace):

LayoutTests:

fast/layoutformattingcontext/table-with-percent-columns-only-no-content-expected.html: Added.
fast/layoutformattingcontext/table-with-percent-columns-only-no-content.html: Added.

6:53 AM Changeset in webkit [278604] by Diego Pino Garcia

32 edits
1 move
3 deletes in trunk/LayoutTests

[GTK] Unreviewed test gardening. Update baselines of tests marked a text flaky.

Removed tests that are now passing from test expectations.

platform/glib/TestExpectations:
platform/glib/fast/css/acid2-pixel-expected.txt: Renamed from LayoutTests/platform/wpe/fast/css/acid2-pixel-expected.txt.
platform/glib/http/tests/websocket/tests/hybi/workers/close-expected.txt: Removed.
platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.https.worker-expected.txt:
platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-serializable-expected.txt:
platform/gtk/TestExpectations:
platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
platform/gtk/editing/pasteboard/4989774-expected.txt:
platform/gtk/editing/pasteboard/paste-4038267-fix-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-001-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-002-expected.txt:
platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
platform/gtk/fast/css/acid2-expected.txt:
platform/gtk/fast/css/acid2-pixel-expected.txt: Removed.
platform/gtk/fast/css/resize-corner-tracking-expected.txt:
platform/gtk/fast/forms/validation-message-appearance-expected.txt:
platform/gtk/fast/overflow/hit-test-overflow-controls-expected.txt:
platform/gtk/http/tests/security/video-cross-origin-accessfailure-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
platform/gtk/svg/custom/circular-marker-reference-4-expected.txt: Removed.
platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:

5:29 AM Changeset in webkit [278603] by Jean-Yves Avenard

10 edits in trunk/Source

[MSE] Rework handling of SourceBuffer's buffer full.
https://bugs.webkit.org/show_bug.cgi?id=226711
<rdar://problem/78937909>

Reviewed by Jer Noble.

Source/WebCore:

Bug 225630 modified the handling of the Source Buffer "buffer full" algorithm.
Per spec, we are to reject a buffer only once we know that the source buffer is full.
The first appendBuffer should always complete.
https://w3c.github.io/media-source/#sourcebuffer-buffer-full-flag
"The buffer full flag keeps track of whether appendBuffer() is allowed to accept

more bytes. It is set to false when the SourceBuffer object is created and gets
updated as data is appended and removed."

"buffer full flag" only gets modified to true in the 3.5.1 Segment Parser Loop
algorithm, step 6.3
https://w3c.github.io/media-source/#sourcebuffer-segment-parser-loop
"If this SourceBuffer is full and cannot accept more media data, then set the

buffer full flag to true."

On the 2nd call to the appendBuffer, in the Prepare Append algorithm, step 3.5.4.6:
https://w3c.github.io/media-source/#sourcebuffer-prepare-append

"If the buffer full flag equals true, then throw a QuotaExceededError exception

and abort these steps."

This change moves the check of the source buffer size back into SourceBufferPrivate
so that checking if we have sufficient space or not is hidden from the SourceBuffer.
Rather than deal with a single "buffer full" flag, we use instead a isBufferFullFor()
method which allows to easily swap between the previous per-spec behaviour and the
one introduced by bug 225630 as it does present some advantages.
We can always determine if we have sufficient space by checking the current source
buffer memory size and the requested limit.
The previous algorithm took into consideration the allocated capacity of the
temporary SourceBuffer::m_pendingAppendData ; this approach was flawed in that we
always checked if m_pendingAppendData.capacity + newDataSize would fit in the
source buffer. However newDataSize would always happen to fit within the existing
capacity, so it was accounted for twice.
We remove check on the capacity allocated as it simplifies the code a great deal,
and avoid the piggy-backing of unrelated methods (such as
SourceBufferPrivate::reenqueueMediaIfNeeded that ended up also checking capacity)

This change is already covered with existing tests.

Modules/mediasource/SourceBuffer.cpp: call new isBufferFullFor to check if

sufficient is available.
(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):

platform/graphics/SourceBufferPrivate.h: Add isBufferFullFor method

remove m_bufferFull member.

platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::reenqueueMediaIfNeeded): remove reference to
buffer capacity
(WebCore::SourceBufferPrivate::evictCodedFrames): remove reference to
buffer capacity
(WebCore::SourceBufferPrivate::isBufferFullFor): To get per-spec behaviour
we only need to stop checking the value of the requiredSize argument.

Source/WebKit:

GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::evictCodedFrames):
(WebKit::RemoteSourceBufferProxy::reenqueueMediaIfNeeded):

GPUProcess/media/RemoteSourceBufferProxy.h:
GPUProcess/media/RemoteSourceBufferProxy.messages.in: Remove capacity and

buffer full references from all methods; relying on the totalTrackBufferSizeInBytes
instead.

WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::evictCodedFrames):
(WebKit::SourceBufferPrivateRemote::reenqueueMediaIfNeeded):

WebProcess/GPU/media/SourceBufferPrivateRemote.h:

5:11 AM Changeset in webkit [278602] by Antti Koivisto

3 edits
2 adds in trunk

text-decoration: underline is not applied to web component
https://bugs.webkit.org/show_bug.cgi?id=226724
<rdar://problem/78987286>

Reviewed by Ryosuke Niwa.

Source/WebCore:

'text-decoration' is not an inherited property in itself but its effective value
behaves as it was. We fail to inherit this effective value into author shadow trees.

Test case by Jeroen Zwartepoorte.

Test: fast/shadow-dom/effective-text-decoration-inheritance.html

style/StyleAdjuster.cpp:

(WebCore::Style::shouldInheritEffectiveTextDecorations):

Test for user agent shadow tree, not a shadow tree in general.
Also inverse the logic and refactor a bit.

(WebCore::Style::Adjuster::adjust const):
(WebCore::Style::isAtShadowBoundary): Deleted.
(WebCore::Style::doesNotInheritTextDecoration): Deleted.

LayoutTests:

fast/shadow-dom/effective-text-decoration-inheritance-expected.html: Added.
fast/shadow-dom/effective-text-decoration-inheritance.html: Added.

5:02 AM Changeset in webkit [278601] by Jean-Yves Avenard

2 edits in trunk/Tools

Update jya's email address
https://bugs.webkit.org/show_bug.cgi?id=226752

Reviewed by Tim Horton.

Scripts/webkitpy/common/config/contributors.json:

3:31 AM Changeset in webkit [278600] by commit-queue@webkit.org

2 edits in trunk/Tools

[Flatpak SDK] Allow custom build directories
https://bugs.webkit.org/show_bug.cgi?id=226142

Patch by Philippe Normand <pnormand@igalia.com> on 2021-06-08
Reviewed by Adrian Perez de Castro.

By default the build directory remains WebKitBuild/{GTK,WPE}/{Release,Debug}. Builds done
with the Flatpak SDK now support the standard WEBKIT_OUTPUTDIR environment variable, eg.
setting $WEBKIT_OUTPUTDIR to "/path/to/somewhere", the built files will end up in
/path/to/somewhere/{GTK,WPE}/Release.

flatpak/flatpakutils.py:

(WebkitFlatpak.clean_args):

2:27 AM Changeset in webkit [278599] by youenn@apple.com

27 edits
2 adds in trunk/Source/ThirdParty/libwebrtc

Update usrsctp to M92
https://bugs.webkit.org/show_bug.cgi?id=226493

Patch by Youenn Fablet <youenn@apple.com> on 2021-06-08
Reviewed by Alex Christensen.

Source/third_party/usrsctp: Resynced.
Source/third_party/usrsctp/usrsctplib/.gitattributes: Added.

2:09 AM Changeset in webkit [278598] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.33.2

WebKitGTK 2.33.2

2:08 AM Changeset in webkit [278597] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.2 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.33.2.

1:00 AM Changeset in webkit [278596] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

[SOUP] Several timing tests failing since r278477
https://bugs.webkit.org/show_bug.cgi?id=226728

Reviewed by Michael Catanzaro.

responseBodyBytesReceived and responseBodyDecodedSize are expected to be always filled, and not only when
shouldCaptureExtraNetworkLoadMetrics() returns true.

Fixes: imported/w3c/web-platform-tests/navigation-timing/test_document_onload.html

imported/w3c/web-platform-tests/navigation-timing/nav2_test_attributes_values.html
imported/w3c/web-platform-tests/resource-timing/cors-preflight.any.worker.html

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::createRequest):

12:57 AM Changeset in webkit [278595] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

REGRESSION(r278391): [SOUP] Test fast/dom/webtiming.html is failing
https://bugs.webkit.org/show_bug.cgi?id=226726

Reviewed by Michael Catanzaro.

We need to set network metrics on response even for non HTTP loads now.

Fixes fast/dom/webtiming.html

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::resume):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):

12:47 AM Changeset in webkit [278594] by Fujii Hironori

2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

platform/wincairo/TestExpectations:

12:35 AM Changeset in webkit [278593] by commit-queue@webkit.org

3 edits
4 adds in trunk

Crash in InsertParagraphSeparatorCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=226527

Patch by Frédéric Wang <fwang@igalia.com> on 2021-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

After r273375 and r278002, it is possible that InsertParagraphSeparatorCommand::doApply is
confused by a display: table start block, leading to nullptr crash in the rest of the
function. This patch just excludes that case in order to work around that kind of issue.

Test: fast/editing/insert-paragraph-with-img-in-table-crash.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

Add regression test.

fast/editing/insert-paragraph-with-img-in-table-crash-expected.txt: Added.
fast/editing/insert-paragraph-with-img-in-table-crash.html: Added. Note that not having a

new line at the end of the HTML file is required to make the test crash without the patch.

fast/editing/insert-paragraph-with-text-in-table-crash-expected.txt: Added.
fast/editing/insert-paragraph-with-text-in-table-crash.html: Added.

Jun 7, 2021:

9:57 PM Changeset in webkit [278592] by Jean-Yves Avenard

2 edits in trunk/Tools

Update jya's email address
https://bugs.webkit.org/show_bug.cgi?id=226752

Reviewed by Tim Horton.

Scripts/webkitpy/common/config/contributors.json:

8:22 PM Changeset in webkit [278591] by ysuzuki@apple.com

19 edits
2 adds in trunk

[JSC] Use ResolvedClosureVar to get brand from scope
https://bugs.webkit.org/show_bug.cgi?id=226677
rdar://78802869

Reviewed by Saam Barati.

JSTests:

stress/private-access-nested-eval.js: Added.

(shouldThrow):
(shouldThrow.prototype.x):
(shouldThrow.prototype.m.C.prototype.z):
(shouldThrow.prototype.m.C.prototype.a):
(shouldThrow.prototype.m.C):
(shouldThrow.prototype.m):

stress/private-access-nested.js: Added.

(shouldThrow):
(shouldThrow.prototype.x):
(shouldThrow.prototype.m.C.prototype.z):
(shouldThrow.prototype.m.C.prototype.a):
(shouldThrow.prototype.m.C):
(shouldThrow.prototype.m):

Source/JavaScriptCore:

Private brand lookup is doing wrong way to get scope.

op_resolve_scope with private name (e.g. #x)
then, doing op_get_from_scope with (1)'s scope with different name (e.g. @privateBrand)

This is wrong in JSC. We resolve scope at link-time in CodeBlock. So we need to ensure that both op_resolve_scope and op_get_from_scope
starts with the current scope-register. As a result, private-brand lookup is broken right now. Let's see the buggy case.

class D {

#x() {}
m() {

class C {

#yy;
#z() { }
a() {

this.#x(); <===== This point.

}

}
let c = new C();
c.a();

}

}

In the above point, we first lookup the scope with #x, and we get the D's class-scope. But our get_from_scope is using privateBrand, and
privateBrand property exists too in C's class-scope too since C also has #yy and #z. As a result, CodeBlock linking configures the offset for
C's class-scope in get_from_scope. And this offset is different from D's class-scope's privateBrand.

Only allowed case for the above usage is ResolvedClosureVar. And generatorification uses it too. In this patch,

We ensure that class-scope (with private name) must have @privateBrand and @privateClassBrand with offset 1 and 0.
Use ResolvedClosureVar with the above pre-defined offset

Since CodeBlock's linking does not resolve the scope for get_from_scope if it is ResolvedClosureVar, we can just perform the desired ResolvedClosureVar lookup
with the given scope with the compiled offset.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::instantiateLexicalVariables):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::emitCreatePrivateBrand):
(JSC::BytecodeGenerator::emitGetPrivateBrand):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BaseDotNode::emitGetPropertyValue):
(JSC::BaseDotNode::emitPutProperty):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitDot):
(JSC::InNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

parser/VariableEnvironment.h:

7:25 PM Changeset in webkit [278590] by commit-queue@webkit.org

11 edits in trunk

Adopt SecTrustGetCertificateAtIndex replacement where available
https://bugs.webkit.org/show_bug.cgi?id=225893

Patch by Alex Christensen <achristensen@webkit.org> on 2021-06-07
Reviewed by Chris Dumez.

Source/WebCore:

platform/network/cf/CertificateInfoCFNet.cpp:

(WebCore::certificatesMatch):
(WebCore::CertificateInfo::certificateChainFromSecTrust):
(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate const):

platform/network/cocoa/CertificateInfoCocoa.mm:

(WebCore::CertificateInfo::dump const):

Source/WebKit:

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::encodeNSError):

UIProcess/Authentication/mac/WebCredentialMac.mm:

(WebKit::leafCertificate):
(WebKit::chain):
(WebKit::WebCredential::WebCredential):

Source/WTF:

rdar://74752046 introduced a new way to access the same thing.

wtf/PlatformHave.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:

(verifyCertificateAndPublicKey):

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

6:53 PM Changeset in webkit [278589] by Alexey Shvayka

103 edits
15 adds in trunk

Unreviewed, reland r276592 with a fix for put() override in prototype chain of a JSProxy
https://bugs.webkit.org/show_bug.cgi?id=226185

JSTests:

microbenchmarks/put-slow-no-cache-array.js: Added.
microbenchmarks/put-slow-no-cache-function.js: Added.
microbenchmarks/put-slow-no-cache-js-proxy.js: Added.
microbenchmarks/put-slow-no-cache-long-prototype-chain.js: Added.
microbenchmarks/put-slow-no-cache.js: Added.
microbenchmarks/reflect-set-with-receiver.js: Added.
stress/custom-get-set-proto-chain-put.js:
stress/module-namespace-access-set-fails.js: Added.
stress/put-non-reified-static-accessor-or-custom.js: Added.
stress/put-non-reified-static-function-or-custom.js: Added.
stress/put-to-primitive-non-reified-static-custom.js: Added.
stress/put-to-primitive.js: Added.
stress/put-to-proto-chain-overrides-put.js:

Rework to always test new objects, add JSProxy coverage, and assert that receiver has own property.

stress/typed-array-canonical-numeric-index-string-set.js: Added.

LayoutTests/imported/w3c:

web-platform-tests/WebIDL/ecmascript-binding/global-object-implicit-this-value.any-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/interface-object-set-receiver-expected.txt: Added.
web-platform-tests/WebIDL/ecmascript-binding/interface-object-set-receiver.html: Added.
web-platform-tests/WebIDL/ecmascript-binding/interface-prototype-constructor-set-receiver-expected.txt:
web-platform-tests/WebIDL/ecmascript-binding/interface-prototype-constructor-set-receiver.html:

Source/JavaScriptCore:

The API test added in r278366 revealed a flaw in JSObject::definePropertyOnReceiver()
that caused putDirectInternal() to be performed on a JSProxy instead of it's target.
Remedies that via a type check, ensuring the test and iOS apps are functional.

The issue was originally missed because the prototype chain of a global object is immutable
and none of the global object's prototypes override put(). OpaqueJSClass::prototype() sets
the Prototype directly, ignoring the IsImmutablePrototypeExoticObject type info flag.

Also, excludes an invariant from the original patch that required put() to be overriden
when implementing custom DefineOwnProperty. It is now broken by WindowProperties object.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::put):

API/tests/testapiScripts/testapi.js:
debugger/DebuggerScope.h:
runtime/ClassInfo.h:
runtime/ClonedArguments.h:
runtime/CustomGetterSetter.cpp:

(JSC::callCustomSetter): Deleted.

runtime/CustomGetterSetter.h:
runtime/ErrorConstructor.h:
runtime/ErrorInstance.h:
runtime/GenericArguments.h:
runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::put):

runtime/GetterSetter.h:
runtime/JSArray.cpp:

(JSC::JSArray::put):

runtime/JSArray.h:
runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::put): Deleted.

runtime/JSArrayBufferView.h:
runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):

runtime/JSCell.cpp:

(JSC::JSCell::doPutPropertySecurityCheck): Deleted.

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::put):

runtime/JSFunction.h:
runtime/JSGenericTypedArrayView.h:
runtime/JSGlobalLexicalEnvironment.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

runtime/JSGlobalObject.h:
runtime/JSLexicalEnvironment.h:
runtime/JSModuleEnvironment.h:
runtime/JSModuleNamespaceObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::putInlineSlow):
(JSC::definePropertyOnReceiverSlow):
(JSC::JSObject::definePropertyOnReceiver):
(JSC::JSObject::putInlineFastReplacingStaticPropertyIfNeeded):
(JSC::JSObject::doPutPropertySecurityCheck): Deleted.
(JSC::JSObject::prototypeChainMayInterceptStoreTo): Deleted.

runtime/JSObject.h:

(JSC::JSObject::putByIndexInline):
(JSC::JSObject::hasNonReifiedStaticProperties):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::putDirect):
(JSC::JSObject::doPutPropertySecurityCheck): Deleted.

runtime/JSObjectInlines.h:

(JSC::JSObject::canPerformFastPutInlineExcludingProto):
(JSC::JSObject::putInlineForJSObject):
(JSC::JSObject::putInlineFast):
(JSC::JSObject::putDirectInternal):

runtime/JSProxy.h:
runtime/JSTypeInfo.h:

(JSC::TypeInfo::hasStaticPropertyTable const):
(JSC::TypeInfo::overridesPut const):
(JSC::TypeInfo::getOwnPropertySlotMayBeWrongAboutDontEnum const):
(JSC::TypeInfo::hasPutPropertySecurityCheck const): Deleted.

runtime/Lookup.h:

(JSC::putEntry): Deleted.
(JSC::lookupPut): Deleted.

runtime/PropertySlot.h:
runtime/ProxyObject.cpp:

(JSC::ProxyObject::put):

runtime/ProxyObject.h:
runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):
(JSC::PutPropertySlot::context const):
(JSC::PutPropertySlot::isTaintedByOpaqueObject const):
(JSC::PutPropertySlot::setIsTaintedByOpaqueObject):

runtime/ReflectObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::put):

runtime/RegExpObject.h:
runtime/StringObject.cpp:

(JSC::StringObject::put):

runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::StringPrototype::create):

runtime/StringPrototype.h:
runtime/Structure.cpp:

(JSC::Structure::validateFlags):

runtime/Structure.h:

(JSC::Structure::hasNonReifiedStaticProperties const):

tools/JSDollarVM.cpp:

Source/WebCore:

Tests: js/dom/script-tests/reflect-set-onto-dom.js

imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/interface-object-set-receiver.html
http/tests/security/cross-frame-access-object-getPrototypeOf-in-put.html

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::doPutPropertySecurityCheck): Deleted.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::doPutPropertySecurityCheck): Deleted.

bindings/js/JSRemoteDOMWindowCustom.cpp:

(WebCore::JSRemoteDOMWindow::put):

bindings/scripts/CodeGeneratorJS.pm:

(GeneratePut):
(GenerateHeader):

bindings/scripts/test/JS/*: Updated.
bridge/objc/objc_runtime.h:
bridge/runtime_array.h:
bridge/runtime_object.h:

Source/WebKit:

WebProcess/Plugins/Netscape/JSNPObject.h:

LayoutTests:

http/tests/security/cross-frame-access-object-getPrototypeOf-in-put-expected.txt:
http/tests/security/cross-frame-access-object-getPrototypeOf-in-put.html:
js/dom/reflect-set-onto-dom-expected.txt:
js/dom/script-tests/reflect-set-onto-dom.js:

6:43 PM Changeset in webkit [278588] by Alexey Shvayka

25 edits in trunk/Source/JavaScriptCore

Introduce LexicalScopeFeatures to enable future bytecode optimizations
https://bugs.webkit.org/show_bug.cgi?id=224072

Reviewed by Keith Miller.

Before this patch, BytecodeGenerator was capable of reasoning about the presence of with
statements, direct eval, or any other code features only within the current executable:

`
with (foo) {

(function() {

There was no way to detect WithScope during generation of this function.

})();

}
`

This change is required for op_to_this rewrite (#225397): if FunctionCallResolveNode and
friends knew there is no WithScope, op_call could be emitted with |this| value of
undefined as per spec [1], instead of resolved scope. This would:

simplify op_to_this on all tiers, likely resulting in minor perf boost;
save 1 instruction per strict function by removing op_to_this;
remove toThis() from the method table and ~30 its call sites from built-ins;
fix built-in methods that were observably lacking toThis();
fix proto getter / setter called on global scope;
fix WebIDL accessors called with |this| value of undefined and null.

Also, if ResolveNode knew that unforgeable global properties are not shadowed and there
is no with statement or sloppy mode direct eval, then undefined / Infinity / NaN
lookups could be constant-folded. This would save up to 3 bytecode ops per each usage
and allow emitting op_is_undefined_or_null for x === undefined || x === null.
V8 performs this optimization [2].

This patch introduces LexicalScopeFeatures to allow passing such information from Parser
to BytecodeGenerator with a minimal code diff. These features are kept separate from
CodeFeature to simplify reasoning about feature's scope and because we need to propagate
lexical features from parent to child scope.

Strict mode is the first use case of LexicalScopeFeatures, which this change carefully
fits into existing abstractions without increasing their memory usage even by 1 byte.

[1]: https://tc39.es/ecma262/#sec-evaluatecall (step 2)
[2]: https://medium.com/@bmeurer/sometimes-undefined-is-defined-7701e1c9eff8

builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::recordParse):
(JSC::UnlinkedCodeBlock::lexicalScopeFeatures const):

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):

bytecode/UnlinkedFunctionExecutable.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewClassFieldInitializerFunction):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::lexicalScopeFeatures const):
(JSC::BytecodeGenerator::generate):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

parser/Nodes.cpp:

(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ModuleProgramNode::ModuleProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionMetadataNode::FunctionMetadataNode):
(JSC::FunctionMetadataNode::operator== const):
(JSC::FunctionMetadataNode::dump const):
(JSC::FunctionNode::FunctionNode):

parser/Nodes.h:

(JSC::ScopeNode::lexicalScopeFeatures):
(JSC::ScopeNode::isStrictMode const):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo):

parser/Parser.h:

(JSC::Scope::Scope):
(JSC::Scope::lexicalScopeFeatures const):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode const):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
(JSC::Parser::pushScope):
(JSC::Parser::lexicalScopeFeatures):
(JSC::Parser<LexerType>::parse):

parser/ParserModes.h:
parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::lexicalScopeFeatures const):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionMetadata):

runtime/CachedBytecode.cpp:

(JSC::CachedBytecode::addFunctionUpdate):

runtime/CachedTypes.cpp:

(JSC::CachedFunctionExecutable::lexicalScopeFeatures const):
(JSC::CachedCodeBlock::lexicalScopeFeatures const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedFunctionExecutable::encode):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::CachedCodeBlock<CodeBlockType>::encode):
(JSC::CachedFunctionExecutable::isInStrictContext const): Deleted.

runtime/CachedTypes.h:
runtime/CodeCache.cpp:

(JSC::generateUnlinkedCodeBlockImpl):
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):

runtime/ECMAMode.h:

(JSC::ECMAMode::fromBool):

runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::FunctionExecutable):

runtime/GlobalExecutable.h:

(JSC::GlobalExecutable::recordParse):
(JSC::GlobalExecutable::GlobalExecutable):

runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::recordParse):

runtime/ScriptExecutable.h:

(JSC::ScriptExecutable::isInStrictContext const):
(JSC::ScriptExecutable::recordParse):

6:29 PM Changeset in webkit [278587] by commit-queue@webkit.org

17 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r278371 and r278463.
https://bugs.webkit.org/show_bug.cgi?id=226749

Break dumpDisassembly in JetStream2

Reverted changesets:

"We should drop B3 values while running Air"
https://bugs.webkit.org/show_bug.cgi?id=226187
https://trac.webkit.org/changeset/278371

"Drop the FTL(DFG) graph after lowering to B3"
https://bugs.webkit.org/show_bug.cgi?id=226556
https://trac.webkit.org/changeset/278463

6:28 PM Changeset in webkit [278586] by Devin Rousso

3 edits in trunk/Source/WebCore

Fix localized strings after r278202
https://bugs.webkit.org/show_bug.cgi?id=226742

Reviewed by Eric Carlson.

Scripts/extract-localizable-strings.pl:

Add support for WEB_UI_CFSTRING_KEY.

en.lproj/Localizable.strings:

6:10 PM Changeset in webkit [278585] by Alexey Shvayka

23 edits
2 adds in trunk

Window should behave like a legacy platform object without indexed setter
https://bugs.webkit.org/show_bug.cgi?id=225894

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/html/browsers/the-window-object/window-indexed-properties-delete-no-cache-expected.txt: Added.
web-platform-tests/html/browsers/the-window-object/window-indexed-properties-delete-no-cache.html: Added.
web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt:
web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict-expected.txt:
web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict.html:
web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html:

Source/JavaScriptCore:

runtime/TypeError.h:

(JSC::typeError):

Source/WebCore:

This change fixes major interop issue by disallowing expando indexed properties on WindowProxy,
raising TypeError only when needed, which aligns WebKit with Blink and Gecko.

While DefineOwnProperty [1] and Delete [2] methods of WindowProxy are implemented
precisely per spec, current Set [3] algorithm seems to allow invoking setters from
the prototype chain. Blink and Gecko implement stricter semantics by failing early rather
than traversing the prototype chain, as does this patch.

To avoid breaking native apps that either add expando indexed properties to WindowProxy, or
more likely read / write indices of sloppy function's |this| value, which accidently happens
to be a WindowProxy, the new behavior is introduced only for web content and newly-built apps.

Since unlike putByIndex(), deletePropertyByIndex() might be invoked with UINT_MAX, which is
not an array index [4], isIndex() check is required. In future, JSC will be fixed to remove
such checks from all indexed overrides.

DeletePropertySlot::disableCaching() is not called because indexed deletes are not currently
repatched, and once they are, cacheability should be inferred from added type info flags.

Also, removes extra jsDOMWindowGetOwnPropertySlotRestrictedAccess() call for indices, which
is missing from the spec [5]; this is unobservable.

[1] https://html.spec.whatwg.org/multipage/window-object.html#windowproxy-defineownproperty (step 2.1)
[2] https://html.spec.whatwg.org/multipage/window-object.html#windowproxy-delete (step 2.1)
[3] https://html.spec.whatwg.org/multipage/window-object.html#windowproxy-set (step 3)
[4] https://tc39.es/ecma262/#array-index
[5] https://html.spec.whatwg.org/multipage/window-object.html#windowproxy-getownproperty (step 2.5.2)

Tests: imported/w3c/web-platform-tests/html/browsers/the-window-object/window-indexed-properties-delete-no-cache.html

imported/w3c/web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html
imported/w3c/web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict.html

bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::makeUnsupportedIndexedSetterErrorMessage):

bindings/js/JSDOMExceptionHandling.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::allowsLegacyExpandoIndexedProperties):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): Remove outdated comments.
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::putByIndex): Release scope when calling Base::putByIndex(), which could throw.
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::deletePropertyByIndex):
(WebCore::JSDOMWindow::defineOwnProperty):

platform/cocoa/VersionChecks.h:

LayoutTests:

fast/dom/Window/orphaned-frame-access.html:
fast/frames/iframe-detached-window-still-writable-eval-expected.txt:
fast/frames/iframe-detached-window-still-writable-eval.html:
http/tests/security/cross-frame-access-delete-expected.txt:
http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
js/dom/dfg-ensure-array-storage-on-window-expected.txt:
js/dom/indexed-setter-on-global-object-expected.txt:
js/dom/script-tests/dfg-ensure-array-storage-on-window.js:
js/dom/script-tests/dfg-ensure-non-array-array-storage-on-window.js:
js/dom/script-tests/indexed-setter-on-global-object.js:

6:04 PM Changeset in webkit [278584] by Russell Epstein

1 copy in tags/Safari-611.3.7

Tag Safari-611.3.7.

5:41 PM Changeset in webkit [278583] by Russell Epstein

1 copy in tags/Safari-612.1.15.4.2

Tag Safari-612.1.15.4.2.

5:40 PM Changeset in webkit [278582] by Russell Epstein

2 edits in branches/safari-612.1.15.4-branch

Cherry-pick r278501. rdar://problem/78973538

[AppleWin] JSC build failure
https://bugs.webkit.org/show_bug.cgi?id=226659
<rdar://78844190>

Reviewed by Brent Fulgham.

WTF scripts location is not being correctly identified.

Source/cmake/OptionsAppleWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:38 PM Changeset in webkit [278581] by Russell Epstein

8 edits in branches/safari-612.1.15.4-branch/Source

Versioning.

WebKit-7612.1.15.4.2

5:29 PM Changeset in webkit [278580] by Chris Dumez

20 edits
1 delete in trunk/Source

Drop legacy MainThreadTaskQueue & EventLoopTaskQueue classes
https://bugs.webkit.org/show_bug.cgi?id=226734

Reviewed by Ryosuke Niwa.

Source/WebCore:

Drop legacy MainThreadTaskQueue & EventLoopTaskQueue classes. Code that was using MainThreadTaskQueue
is now calling callOnMainThread() directly. Call that was using EventLoopTaskQueue is now using the
HTML event loop directly. If said code needed to cancel tasks or check if a previously scheduled task
is still pending, it now relies on WTF::CancellableTask / WTF::TaskCancellationGroup to do so.

Headers.cmake:
Modules/encryptedmedia/MediaKeySystemAccess.cpp:
WebCore.xcodeproj/project.pbxproj:
animation/DocumentTimelinesController.cpp:

(WebCore::DocumentTimelinesController::cacheCurrentTime):
(WebCore::DocumentTimelinesController::maybeClearCachedCurrentTime):

animation/DocumentTimelinesController.h:
dom/ActiveDOMObject.h:
dom/Document.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::scheduleNextSourceChild):
(WebCore::HTMLMediaElement::scheduleCheckPlaybackTargetCompatability):
(WebCore::HTMLMediaElement::seekWithTolerance):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::scheduleConfigureTextTracks):
(WebCore::HTMLMediaElement::scheduleMediaEngineWasUpdated):
(WebCore::HTMLMediaElement::scheduleUpdatePlayState):
(WebCore::HTMLMediaElement::cancelPendingTasks):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::closeTaskQueues):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured):
(WebCore::HTMLMediaElement::mediaPlayerBufferedTimeRangesChanged):
(WebCore::HTMLMediaElement::scheduleUpdateMediaState):
(WebCore::HTMLMediaElement::playbackControlsManagerBehaviorRestrictionsTimerFired):

html/HTMLMediaElement.h:
platform/GenericTaskQueue.h: Removed.
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver metadataLoaded]):
(-[WebCoreAVFMovieObserver didEnd:]):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFMovieObserver metadataOutput:didOutputTimedMetadataGroups:fromPlayerItemTrack:]):
(-[WebCoreAVFMovieObserver metadataCollector:didCollectDateRangeMetadataGroups:indexesOfNewGroups:indexesOfModifiedGroups:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didParseInitializationData):
(WebCore::SourceBufferPrivateAVFObjC::abort):

platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:

Source/WTF:

We recently introduced the WTF::CancellableTask in order to be able to cancel
a pending task in the event loop, and/or check if the task is still pending.
It worked great as a replacement for EventLoopDeferrableTask. However, it was
insufficient as a replacement for task queues (such as MainThreadTaskQueue &
EventLoopTaskQueue) since there was no convenient way to cancel a group of
tasks. To address this, I am introducing WTF::TaskCancellationGroup. Whenever one
needs to create a CancellableTask, it now needs to provide a TaskCancellationGroup.
Several CancellableTask objects can share the same TaskCancellationGroup. Code now
now schedule one or more CancellableTasks on the event loop and hold on
to a TaskCancellationGroup. If they need to cancel those tasks, they can simply
call cancel() on the TaskCancellationGroup. They can also check if previously
scheduled tasks are still pending via TaskCancellationGroup::hasPendingTask().

wtf/CancellableTask.h:

(WTF::TaskCancellationGroup::TaskCancellationGroup):
(WTF::TaskCancellationGroup::cancel):
(WTF::TaskCancellationGroup::hasPendingTask const):
(WTF::TaskCancellationGroup::Impl::cancel):
(WTF::TaskCancellationGroup::Impl::hasPendingTask const):
(WTF::TaskCancellationGroup::Handle::isCancelled const):
(WTF::TaskCancellationGroup::Handle::Handle):
(WTF::TaskCancellationGroup::createHandle):
(WTF::CancellableTask::CancellableTask):
(WTF::CancellableTask::operator()):

wtf/WeakPtr.h:

(WTF::WeakPtrFactory::weakPtrCount const):

5:05 PM Changeset in webkit [278579] by Russell Epstein

1 copy in tags/Safari-612.1.16.4

Tag Safari-612.1.16.4.

4:26 PM Changeset in webkit [278578] by sbarati@apple.com

4 edits
1 add in trunk

Short circuit read modify write nodes emit byte code that uses the wrong locals
https://bugs.webkit.org/show_bug.cgi?id=226576
<rdar://problem/78810362>

Reviewed by Yusuke Suzuki.

JSTests:

stress/short-circuit-read-modify-should-use-the-write-virtual-registers.js: Added.

(eval):

Source/JavaScriptCore:

It's never a good idea to use the wrong local :-)

This patch also adds support for dumping predecessors of basic blocks
in the bytecode dump.

bytecode/BytecodeDumper.cpp:

(JSC::CodeBlockBytecodeDumper<Block>::dumpGraph):

bytecompiler/NodesCodegen.cpp:

(JSC::ShortCircuitReadModifyResolveNode::emitBytecode):
(JSC::ShortCircuitReadModifyDotNode::emitBytecode):
(JSC::ShortCircuitReadModifyBracketNode::emitBytecode):

4:07 PM Changeset in webkit [278577] by Russell Epstein

8 edits in branches/safari-612.1.16-branch/Source

Versioning.

WebKit-7612.1.16.4

3:51 PM Changeset in webkit [278576] by mark.lam@apple.com

13 edits in trunk/Source/JavaScriptCore

Put the Baseline JIT prologue and op_loop_hint code in JIT thunks.
https://bugs.webkit.org/show_bug.cgi?id=226375

Reviewed by Keith Miller and Robin Morisset.

Baseline JIT prologue code varies in behavior based on several variables. These
variables include (1) whether the prologue does any arguments value profiling,
(2) whether the prologue is for a constructor, and (3) whether the compiled
CodeBlock will have such a large frame that it is greater than the stack reserved
zone (aka red zone) which would require additional stack check logic.

The pre-existing code would generate specialized code based on these (and other
variables). In converting to using thunks for the prologue, we opt not to
convert these specializations into runtime checks. Instead, the implementation
uses 1 of 8 possible specialized thunks to reduce the need to pass arguments for
runtime checks. The only needed argument passed to the prologue thunks is the
codeBlock pointer.

There are 8 possible thunks because we specialize based on 3 variables:

doesProfiling
isConstructor
hasHugeFrame

23 yields 8 permutations of prologue thunk specializations.

Similarly, there are also 8 analogous arity fixup prologues that work similarly.

The op_loop_hint thunk only takes 1 runtime argument: the bytecode offset.

We've tried doing the loop_hint optimization check in the thunk (in order to move
both the fast and slow path into the thunk for maximum space savings). However,
this seems to have some slight negative impact on benchmark performance. We ended
up just keeping the fast path and instead have the slow path call a thunk to do
its work. This realizes the bulk of the size savings without the perf impact.

This patch also optimizes op_enter a bit more by eliminating the need to pass any
arguments to the thunk. The thunk previously took 2 arguments: localsToInit and
canBeOptimized. localsToInit is now computed in the thunk at runtime, and
canBeOptimized is used as a specialization argument to generate 2 variants of the
op_enter thunk: op_enter_canBeOptimized_Generator and op_enter_cannotBeOptimized_Generator,
thereby removing the need to pass it as a runtime argument.

LinkBuffer size results (from a single run of Speedometer2):

BaselineJIT: 93319628 (88.996532 MB) => 83851824 (79.967331 MB) 0.90x

ExtraCTIThunk: 5992 (5.851562 KB) => 6984 (6.820312 KB) 1.17x

...

Total: 197530008 (188.379295 MB) => 188459444 (179.728931 MB) 0.95x

Speedometer2 and JetStream2 results (as measured on an M1 Mac) are neutral.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::untagReturnAddressWithoutExtraValidation):

assembler/MacroAssemblerARM64E.h:

(JSC::MacroAssemblerARM64E::untagReturnAddress):
(JSC::MacroAssemblerARM64E::untagReturnAddressWithoutExtraValidation):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchAdd32):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchAdd32):

bytecode/CodeBlock.h:

(JSC::CodeBlock::offsetOfNumCalleeLocals):
(JSC::CodeBlock::offsetOfNumVars):
(JSC::CodeBlock::offsetOfArgumentValueProfiles):
(JSC::CodeBlock::offsetOfShouldAlwaysBeInlined):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveCalleeSavesForBaselineJIT):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesForBaselineJIT):

jit/JIT.cpp:

(JSC::JIT::compileAndLinkWithoutFinalizing):
(JSC::JIT::prologueGenerator):
(JSC::JIT::arityFixupPrologueGenerator):
(JSC::JIT::privateCompileExceptionHandlers):

jit/JIT.h:
jit/JITInlines.h:

(JSC::JIT::emitNakedNearCall):

jit/JITOpcodes.cpp:

(JSC::JIT::op_ret_handlerGenerator):
(JSC::JIT::emit_op_enter):
(JSC::JIT::op_enter_Generator):
(JSC::JIT::op_enter_canBeOptimized_Generator):
(JSC::JIT::op_enter_cannotBeOptimized_Generator):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::op_loop_hint_Generator):
(JSC::JIT::op_enter_handlerGenerator): Deleted.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_enter):

jit/ThunkGenerators.cpp:

(JSC::popThunkStackPreservesAndHandleExceptionGenerator):

3:11 PM Changeset in webkit [278575] by Wenson Hsieh

60 edits
38 copies
7 moves
4 adds
2 deletes in trunk

Upstream WebKit support for Live Text
https://bugs.webkit.org/show_bug.cgi?id=226706
<rdar://problem/78933684>

Reviewed by Tim Horton.

Source/WebCore:

Upstream WebKit support for the family of "live text" and visual intelligence features from WebKitAdditions.
This encompasses the following features on macOS 12 and iOS 15:

Text selection and interaction in images.
Data detectors in images.
Visual search (Look Up) via context menu in images.

To do this, we rename the IMAGE_EXTRACTION feature flag (and any other similar symbol names that reference
"image extraction" in some capacity) to their real names in macOS and iOS:

"Text recognition", in code that supports automatic OCR and data detectors in images.
"Look Up", in code that references the context menu action to invoke visual search.
"Visual Search", in code that manages QuickLook integration for invoking visual search.
"Image analysis", in code that directly integrates with VKImageAnalyzer and VKImageAnalyzerRequest.

Tests: fast/images/text-recognition/basic-image-overlay.html

fast/images/text-recognition/click-link-with-image-overlay.html
fast/images/text-recognition/image-overlay-creation-is-idempotent.html
fast/images/text-recognition/image-overlay-in-image-with-zero-font-size.html
fast/images/text-recognition/image-overlay-with-selection-styles.html
fast/images/text-recognition/ios/coalesce-selection-rects-in-image-overlay.html
fast/images/text-recognition/ios/reselect-word-in-image-overlay.html
fast/images/text-recognition/ios/select-word-in-image-overlay-inside-link.html
fast/images/text-recognition/ios/select-word-in-image-overlay.html
fast/images/text-recognition/ios/selection-rects-in-image-overlay.html
fast/images/text-recognition/mac/copy-image-overlay-text-with-context-menu.html
fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html
fast/images/text-recognition/mac/select-image-overlay-in-link-with-mouse-drag.html
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2.html
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-does-not-fire-click.html
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag.html
fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html
fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html
fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html

WebCore.xcodeproj/project.pbxproj:
editing/cocoa/DataDetection.h:
editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::createElementForImageOverlay):

en.lproj/Localizable.strings:
html/HTMLElement.cpp:

(WebCore::HTMLElement::updateWithTextRecognitionResult):
(WebCore::HTMLElement::updateWithImageExtractionResult): Deleted.

html/HTMLElement.h:
page/ChromeClient.h:

(WebCore::ChromeClient::requestTextRecognition):
(WebCore::ChromeClient::requestImageExtraction): Deleted.

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::m_textRecognitionHoverTimerFired):
(WebCore::EventHandler::imageExtractionTimerFired): Deleted.

page/EventHandler.h:
page/Quirks.cpp:
page/Quirks.h:
platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction):

platform/ContextMenuItem.h:
platform/LocalizedStrings.h:
platform/TextRecognitionResult.h: Renamed from Source/WebCore/platform/ImageExtractionResult.h.

Rename the following:

ImageExtractionResult => TextRecognitionResult
ImageExtractionTextData => TextRecognitionWordData
ImageExtractionLineData => TextRecognitionLineData
ImageExtractionDataDetectorInfo => TextRecognitionDataDetector

(WebCore::TextRecognitionWordData::TextRecognitionWordData):
(WebCore::TextRecognitionWordData::encode const):
(WebCore::TextRecognitionWordData::decode):
(WebCore::TextRecognitionLineData::TextRecognitionLineData):
(WebCore::TextRecognitionDataDetector::TextRecognitionDataDetector):
(WebCore::TextRecognitionLineData::encode const):
(WebCore::TextRecognitionLineData::decode):
(WebCore::TextRecognitionResult::isEmpty const):
(WebCore::TextRecognitionResult::encode const):
(WebCore::TextRecognitionResult::decode):

platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::contextMenuItemTagLookUpImage):
(WebCore::contextMenuItemTagRevealImage): Deleted.

testing/Internals.cpp:

(WebCore::makeDataForLine):
(WebCore::Internals::installImageOverlay):

Source/WebKit:

See WebCore/ChangeLog for more details.

Platform/cocoa/ImageExtractionUtilities.mm: Removed.
Platform/cocoa/TextRecognitionUtilities.h: Renamed from Source/WebKit/Platform/cocoa/ImageExtractionUtilities.h.
Platform/cocoa/TextRecognitionUtilities.mm: Added.

Rename ImageExtractionUtilities to TextRecognitionUtilities.

(WebKit::floatQuad):
(WebKit::floatQuads):
(WebKit::makeTextRecognitionResult):
(WebKit::isLiveTextEnabled):

Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::TextRecognitionDataDetector>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::TextRecognitionDataDetector>::decodePlatformData):
(IPC::ArgumentCoder<WebCore::ImageExtractionDataDetectorInfo>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<WebCore::ImageExtractionDataDetectorInfo>::decodePlatformData): Deleted.

Shared/TextRecognitionUpdateResult.h: Renamed from Source/WebKit/Shared/ImageExtractionUpdateResult.h.
Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextRecognitionDataDetector>::encode):
(IPC::ArgumentCoder<TextRecognitionDataDetector>::decode):
(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::encode): Deleted.
(IPC::ArgumentCoder<ImageExtractionDataDetectorInfo>::decode): Deleted.

Shared/WebCoreArgumentCoders.h:
SourcesCocoa.txt:
UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):
(+[_WKElementAction imageForElementActionType:]):

Note that we need to keep the _WKElementActionTypeRevealImage SPI symbol, to avoid breaking MobileMail.

UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::handleContextMenuRevealImage): Deleted.

Rename handleContextMenuRevealImage to handleContextMenuLookUpImage.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::ensureImageAnalyzer):
(WebKit::createImageAnalysisRequest):
(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::computeHasVisualSearchResults):

Rename computeCanRevealImage to computeHasVisualSearchResults.

(WebKit::WebViewImpl::acceptsPreviewPanelControl):

UIProcess/PageClient.h:

(WebKit::PageClient::requestTextRecognition):
(WebKit::PageClient::computeHasVisualSearchResults):
(WebKit::PageClient::requestImageExtraction): Deleted.
(WebKit::PageClient::computeCanRevealImage): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::requestTextRecognition):
(WebKit::WebPageProxy::computeHasVisualSearchResults):
(WebKit::WebPageProxy::updateWithTextRecognitionResult):
(WebKit::WebPageProxy::requestImageExtraction): Deleted.
(WebKit::WebPageProxy::computeCanRevealImage): Deleted.
(WebKit::WebPageProxy::updateWithImageExtractionResult): Deleted.

Rename updateWithImageExtractionResult to updateWithTextRecognitionResult.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestTextRecognition):
(WebKit::PageClientImpl::requestImageExtraction): Deleted.

Rename requestImageExtraction to requestTextRecognition.

UIProcess/ios/WKActionSheetAssistant.h:
UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant handleElementActionWithType:element:needsInteraction:]):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView deferringGestures]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldRequireFailureOfGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView targetForAction:withSender:]):
(-[WKContentView _didStartProvisionalLoadForMainFrame]):
(-[WKContentView shouldDeferGestureDueToImageAnalysis:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView _endImageAnalysisGestureDeferral:]):
(-[WKContentView _doAfterPendingImageAnalysis:]):
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageAnalysis:]):
(-[WKContentView presentVisualSearchPreviewControllerForImage:imageURL:title:imageBounds:appearanceActions:]):
(-[WKContentView previewController:frameForPreviewItem:inSourceView:]):
(-[WKContentView previewController:transitionImageForPreviewItem:contentRect:]):
(-[WKContentView previewControllerDidDismiss:]):
(-[WKContentView numberOfPreviewItemsInPreviewController:]):
(-[WKContentView previewController:previewItemAtIndex:]):
(-[WKContentView provideDataForItem:]):
(-[WKContentView actionSheetAssistant:shouldIncludeShowTextActionForElement:]):
(-[WKContentView actionSheetAssistant:showTextForImage:imageURL:title:imageBounds:]):
(-[WKContentView actionSheetAssistant:shouldIncludeLookUpImageActionForElement:]):
(-[WKContentView actionSheetAssistant:lookUpImage:imageURL:title:imageBounds:]):
(-[WKContentView imageAnalyzer]):
(-[WKContentView hasPendingImageAnalysisRequest]):
(-[WKContentView _setUpImageAnalysis]):
(-[WKContentView _tearDownImageAnalysis]):
(-[WKContentView _cancelImageAnalysis]):
(-[WKContentView createImageAnalysisRequest:image:imageURL:]):
(-[WKContentView createImageAnalysisRequest:image:]):
(-[WKContentView validateImageAnalysisRequestIdentifier:]):
(-[WKContentView requestTextRecognition:imageData:completionHandler:]):
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView imageAnalysisGestureDidFail:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
(-[WKContentView _insertTextFromCameraForWebView:]):
(-[WKContentView captureTextFromCameraForWebView:]):
(-[WKContentView _contextMenuInteraction:configurationForMenuAtLocation:completion:]):
(-[WKContentView continueContextMenuInteraction:]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKContentView shouldDeferGestureDueToImageExtraction:]): Deleted.
(-[WKContentView _endImageExtractionGestureDeferral:]): Deleted.
(-[WKContentView _doAfterPendingImageExtraction:]): Deleted.
(-[WKContentView _invokeAllActionsToPerformAfterPendingImageExtraction:]): Deleted.

UIProcess/ios/WKImageAnalysisGestureRecognizer.h: Renamed from Source/WebKit/UIProcess/ios/WKImageExtractionGestureRecognizer.h.
UIProcess/ios/WKImageAnalysisGestureRecognizer.mm: Renamed from Source/WebKit/UIProcess/ios/WKImageExtractionGestureRecognizer.mm.

(-[WKImageAnalysisGestureRecognizer initWithImageAnalysisGestureDelegate:]):
(-[WKImageAnalysisGestureRecognizer setState:]):

Rename WKImageExtractionGestureRecognizer to WKImageAnalysisGestureRecognizer (along with all adjacent classes).

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestTextRecognition):
(WebKit::PageClientImpl::computeHasVisualSearchResults):
(WebKit::PageClientImpl::requestImageExtraction): Deleted.
(WebKit::PageClientImpl::computeCanRevealImage): Deleted.

UIProcess/mac/WKVisualSearchPreviewController.h: Renamed from Source/WebKit/UIProcess/mac/WKImageExtractionPreviewController.h.
UIProcess/mac/WKVisualSearchPreviewController.mm: Renamed from Source/WebKit/UIProcess/mac/WKImageExtractionPreviewController.mm.

(-[WKVisualSearchPreviewController initWithPage:imageData:title:imageURL:]):
(-[WKVisualSearchPreviewController beginControl:]):
(-[WKVisualSearchPreviewController endControl:]):
(-[WKVisualSearchPreviewController closePanelIfNecessary]):
(-[WKVisualSearchPreviewController isControlling:]):
(-[WKVisualSearchPreviewController provideDataForItem:]):
(-[WKVisualSearchPreviewController numberOfPreviewItemsInPreviewPanel:]):
(-[WKVisualSearchPreviewController previewPanel:previewItemAtIndex:]):
(-[WKVisualSearchPreviewController previewPanel:initialActivityForItem:]):

Rename WKImageExtractionPreviewController to WKVisualSearchPreviewController.

UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::beginPreviewPanelControl):
(WebKit::WebPageProxy::endPreviewPanelControl):
(WebKit::WebPageProxy::closeSharedPreviewPanelIfNecessary):
(WebKit::WebPageProxy::showImageInVisualSearchPreviewPanel):

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestTextRecognition):
(WebKit::WebChromeClient::requestImageExtraction): Deleted.

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::requestTextRecognition):
(WebKit::WebPage::updateWithTextRecognitionResult):
(WebKit::WebPage::requestImageExtraction): Deleted.
(WebKit::WebPage::updateWithImageExtractionResult): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm: Replace IMAGE_EXTRACTION with IMAGE_ANALYSIS.

Source/WTF:

wtf/PlatformEnableCocoa.h:

Move the feature flag out of WebKitAdditions and into OpenSource as IMAGE_ANALYSIS.

Tools:

Replace IMAGE_EXTRACTION with IMAGE_ANALYSIS.

TestWebKitAPI/Tests/WebKit/InjectedBundleHitTest.mm:
TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
TestWebKitAPI/Tests/mac/ImmediateActionTests.mm:

LayoutTests:

Rename fast/images/image-extraction to fast/images/text-recognition.

TestExpectations:
fast/images/text-recognition/basic-image-overlay-expected-mismatch.html: Renamed from LayoutTests/fast/images/image-extraction/basic-image-overlay-expected-mismatch.html.
fast/images/text-recognition/basic-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/basic-image-overlay.html.
fast/images/text-recognition/click-link-with-image-overlay-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/click-link-with-image-overlay-expected.txt.
fast/images/text-recognition/click-link-with-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/click-link-with-image-overlay.html.
fast/images/text-recognition/image-overlay-creation-is-idempotent-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-creation-is-idempotent-expected.txt.
fast/images/text-recognition/image-overlay-creation-is-idempotent.html: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-creation-is-idempotent.html.
fast/images/text-recognition/image-overlay-in-image-with-zero-font-size-expected-mismatch.html: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-in-image-with-zero-font-size-expected-mismatch.html.
fast/images/text-recognition/image-overlay-in-image-with-zero-font-size.html: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-in-image-with-zero-font-size.html.
fast/images/text-recognition/image-overlay-with-selection-styles-expected.html: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-with-selection-styles-expected.html.
fast/images/text-recognition/image-overlay-with-selection-styles.html: Renamed from LayoutTests/fast/images/image-extraction/image-overlay-with-selection-styles.html.
fast/images/text-recognition/ios/coalesce-selection-rects-in-image-overlay-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/ios/coalesce-selection-rects-in-image-overlay-expected.txt.
fast/images/text-recognition/ios/coalesce-selection-rects-in-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/ios/coalesce-selection-rects-in-image-overlay.html.
fast/images/text-recognition/ios/reselect-word-in-image-overlay-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/ios/reselect-word-in-image-overlay-expected.txt.
fast/images/text-recognition/ios/reselect-word-in-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/ios/reselect-word-in-image-overlay.html.
fast/images/text-recognition/ios/select-word-in-image-overlay-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/ios/select-word-in-image-overlay-expected.txt.
fast/images/text-recognition/ios/select-word-in-image-overlay-inside-link-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/ios/select-word-in-image-overlay-inside-link-expected.txt.
fast/images/text-recognition/ios/select-word-in-image-overlay-inside-link.html: Renamed from LayoutTests/fast/images/image-extraction/ios/select-word-in-image-overlay-inside-link.html.
fast/images/text-recognition/ios/select-word-in-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/ios/select-word-in-image-overlay.html.
fast/images/text-recognition/ios/selection-rects-in-image-overlay-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/ios/selection-rects-in-image-overlay-expected.txt.
fast/images/text-recognition/ios/selection-rects-in-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/ios/selection-rects-in-image-overlay.html.
fast/images/text-recognition/mac/copy-image-overlay-text-with-context-menu-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/mac/copy-image-overlay-text-with-context-menu-expected.txt.
fast/images/text-recognition/mac/copy-image-overlay-text-with-context-menu.html: Renamed from LayoutTests/fast/images/image-extraction/mac/copy-image-overlay-text-with-context-menu.html.
fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/mac/image-overlay-text-disables-app-highlight-menu-items-expected.txt.
fast/images/text-recognition/mac/image-overlay-text-disables-app-highlight-menu-items.html: Renamed from LayoutTests/fast/images/image-extraction/mac/image-overlay-text-disables-app-highlight-menu-items.html.
fast/images/text-recognition/mac/select-image-overlay-in-link-with-mouse-drag-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-in-link-with-mouse-drag-expected.txt.
fast/images/text-recognition/mac/select-image-overlay-in-link-with-mouse-drag.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-in-link-with-mouse-drag.html.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2-expected.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-2-expected.html.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-2.html.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-does-not-fire-click-expected.txt: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-does-not-fire-click-expected.txt.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-does-not-fire-click.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-does-not-fire-click.html.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-expected-mismatch.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag-expected-mismatch.html.
fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-image-overlay-with-mouse-drag.html.
fast/images/text-recognition/mac/select-rotated-transparent-image-overlay-expected.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-rotated-transparent-image-overlay-expected.html.
fast/images/text-recognition/mac/select-rotated-transparent-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-rotated-transparent-image-overlay.html.
fast/images/text-recognition/mac/select-word-in-draggable-image-overlay-expected-mismatch.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-word-in-draggable-image-overlay-expected-mismatch.html.
fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-word-in-draggable-image-overlay.html.
fast/images/text-recognition/mac/select-word-in-transparent-image-overlay-expected-mismatch.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-word-in-transparent-image-overlay-expected-mismatch.html.
fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html: Renamed from LayoutTests/fast/images/image-extraction/mac/select-word-in-transparent-image-overlay.html.

2:20 PM Changeset in webkit [278574] by mmaxfield@apple.com

2 edits in trunk/Websites/browserbench.org

Release MotionMark 1.2!!! 🎉
https://bugs.webkit.org/show_bug.cgi?id=226741

Reviewed by Geoff Garen.

Simply update the link to point to it.

index.html:

2:17 PM Changeset in webkit [278573] by Ruben Turcios

8 edits in branches/safari-612.1.17-branch/Source

Versioning.

WebKit-7612.1.17

2:11 PM Changeset in webkit [278572] by Ruben Turcios

1 copy in branches/safari-612.1.17-branch

New branch.

1:27 PM Changeset in webkit [278571] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Compile error by trying to fit a GCGLint64* to a GLint64*
https://bugs.webkit.org/show_bug.cgi?id=226639

Patch by Eleni Maria Stea <hikiko> on 2021-06-07
Reviewed by Kenneth Russell.

ANGLE functions GetInteger64vRobustANGLE and
GetInteger64i_vRobustANGLE expect a value of GLint64* aka
long int * but we try to fit a pointer to a long long int.
Fixed compile errors.

platform/graphics/GraphicsTypesGL.h:

1:09 PM Changeset in webkit [278570] by Fujii Hironori

2 edits in trunk/Tools

Windows Python 2.7 fails to install tblib-1.7.0 due to "TypeError: environment can only contain strings"
https://bugs.webkit.org/show_bug.cgi?id=226707

Reviewed by Jonathan Bedard.

WinCairo port is still using Python 2.7 that has ascii strings and
unicode strings. WinPort.setup_crash_log_saving modifies
_NT_SYMBOL_PATH env var to have a unicode string. So, after
setup_crash_log_saving, AutoInstall failed due to the unicode
string in os.environ.

Scripts/webkitpy/port/win.py:

(WinPort.setup_crash_log_saving): Convert self._build_path() to a
ascii string with str().

1:05 PM Changeset in webkit [278569] by Fujii Hironori

2 edits in trunk/Tools

run-webkit-test should use python2 for wpt serve until the latest will be imported
https://bugs.webkit.org/show_bug.cgi?id=226703

Reviewed by Jonathan Bedard.

The current imported wpt.py doesn't support Python 3 yet. Use
Python 2 temporarily.

Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init):

12:55 PM Changeset in webkit [278568] by rmorisset@apple.com

14 edits
3 adds in trunk

Optimize compareStrictEq when neither side is a double and at least one is neither a string nor a BigInt
https://bugs.webkit.org/show_bug.cgi?id=226676

Reviewed by Filip Pizlo.

JSTests:

I made two variants of the already existing poly-stricteq microbenchmarks with different types in the array.
I also tweaked all three so that we more reliably reach the FTL.
Finally I added a stress-test to verify that I did not introduce an OSR exit bug.

microbenchmarks/poly-stricteq-not-double-nor-string.js: Added.

(foo):
(test):

microbenchmarks/poly-stricteq-not-double.js: Added.

(foo):
(test):

microbenchmarks/poly-stricteq.js:

(foo):
(test):

stress/poly-stricteq-not-double-nor-string-fail.js: Added.

(foo):
(test):

Source/JavaScriptCore:

There is exactly one case where x === y must return false despite x and y being JSValues with the same bits:

NaN === NaN

There are a few cases where x === y must return true despite x and y being JSValues with potentially different bits:

Double === Int32
String === String
HeapBigInt === HeapBigInt
HeapBigInt === BigInt32 (if they are enabled)

If we don't have a double on either side, at least one side has neither a String nor a HeapBigInt, and BigInt32 are disabled, we can clearly ignore all of these pathological cases.

This optimization was decided based on looking at DFG graphs of Speedometer2; here is a sample of the compareStrictEq(Untyped, Untyped), courtesy of Phil:

Final|Array|String|Bool, Final|Array|String|Bool
Array|String|Bool, String|Bool (twice)
Array|String|Bool, String|Int32 (once in DFG, once in FTL)

Final|StringIdent, Final|StringIdent (3 times)
Final|StringIdent|BoolInt32, StringIdent|BoolInt32 (twice)
String|Bool, String|Bool (4 times)
DoublePureNaN, String|Bool

! Other, Function|Other
! Final|Other, Final|Function|Other (twice)

Final|String|Bool|Other, Final|String|Bool|Other (3 times, two in the FTL)
Final|String|Int32, String|Int32 (four times)
String|Int32|Bool, Function|String|Int32|Bool (twice)
String|DoublePureNaN, String|Bool (twice)

! Final|Bool|Other, Final|Function|Other (four times, twice in FTL)
I marked with a ! those for which this optimization should apply.

The only slightly interesting part of this patch is DFG::SpeculativeJIT::speculateNeitherDoubleNorHeapBigIntNorString where I took care to skip every test whose result we can predict from the abstract interpreter.

Results on microbenchmarks:

poly-stricteq-not-double 45.5793+-0.5304 ? 46.0306+-0.5621 ?
poly-stricteq-not-double-nor-string 45.5829+-0.5750 ^{16.9089+-0.3070} definitely 2.6958x faster
poly-stricteq 49.9719+-0.6450 48.9855+-0.5227 might be 1.0201x faster

I also measured the amount of code that we generate in the DFG on JetStream2.
The results here are disappointing but still measurable. Before:

DFG_fast_CompareStrictEq totalBytes: 468425 count: 10951 avg: 42.774632
DFG_fast_CompareStrictEq totalBytes: 468020 count: 10917 avg: 42.870752
DFG_fast_CompareStrictEq totalBytes: 467424 count: 10888 avg: 42.930198

After:

DFG_fast_CompareStrictEq totalBytes: 463946 count: 10917 avg: 42.497573
DFG_fast_CompareStrictEq totalBytes: 474492 count: 11138 avg: 42.601185
DFG_fast_CompareStrictEq totalBytes: 467138 count: 10970 avg: 42.583227

bytecode/SpeculatedType.h:

(JSC::isNeitherDoubleNorHeapBigIntNorStringSpeculation):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):

dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNeitherDoubleNorHeapBigIntNorString):

dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileNotDoubleNeitherDoubleNorHeapBigIntNorStringStrictEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleNotDoubleNeitherDoubleNorHeapBigIntNorStringStrictEquality):
(JSC::DFG::SpeculativeJIT::speculateNotDouble):
(JSC::DFG::SpeculativeJIT::speculateNeitherDoubleNorHeapBigIntNorString):
(JSC::DFG::SpeculativeJIT::speculate):

dfg/DFGSpeculativeJIT.h:
dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::checkMayCrashIfInputIsEmpty):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::speculateNeitherDoubleNorHeapBigIntNorString):

12:46 PM Changeset in webkit [278567] by Ruben Turcios

8 edits in trunk/Source

Versioning.

WebKit-7612.1.18

12:44 PM Changeset in webkit [278566] by graouts@webkit.org

4 edits
2 adds in trunk

REGRESSION (r272201): iPad render flashing on load
https://bugs.webkit.org/show_bug.cgi?id=226216
<rdar://problem/78466306>

Reviewed by Simon Fraser.

Source/WebCore:

When we switched to wrapping all animations in animation groups for bug 219894, we neglected to update GraphicsLayerCA::moveOrCopyAnimations().
We now iterate over m_animationGroups which contain the animation groups that are current and in the order they were added, and also ensure
we preserve the original begin time for each group.

Test: webanimations/accelerated-animation-tiled-while-running.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::moveOrCopyLayerAnimation):
(WebCore::GraphicsLayerCA::moveOrCopyAnimations):

platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests:

Add a test that runs the same accelerated animation on two container elements, stack one above the other.
The bottom container has a red background while the top container has a green background, the whole body
being green. After the animation has started, we set the bottom element to have a very large size such
that its layer becomes tiled. Before this patch the bottom element would stop animation and its red
background would start appearing as the top element would keep animating. After this patch both elements
are animated and no red should appear.

webanimations/accelerated-animation-tiled-while-running-expected.html: Added.
webanimations/accelerated-animation-tiled-while-running.html: Added.

11:53 AM Changeset in webkit [278565] by Devin Rousso

10 edits in trunk/Source

Convert WebCore::SnapshotOptions into an enum class
https://bugs.webkit.org/show_bug.cgi?id=226730

Reviewed by Wenson Hsieh.

Convert SnapshotOptions into an enum class SnapshotFlags and create a container `struct
SnapshotOptions that also allows for changing the DestinationColorSpace` (defaults to sRGB)
and PixelFormat (defaults to BGRA8).

No behavior change.

Source/WebCore:

page/FrameSnapshotting.h:
page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
(WebCore::snapshotFrameRectWithClip):
(WebCore::snapshotSelection):
(WebCore::snapshotNode):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::snapshotRect):

page/PageColorSampler.cpp:

(WebCore::sampleColor):

page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

page/TextIndicator.cpp:

(WebCore::snapshotOptionsForTextIndicatorOptions):
(WebCore::takeSnapshot):
(WebCore::takeSnapshots):

platform/DragImage.cpp:

(WebCore::createDragImageForSelection):
(WebCore::createDragImageForRange):

Source/WebKit:

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

11:10 AM Changeset in webkit [278564] by youenn@apple.com

274 edits
32 adds
8 deletes in trunk/Source/ThirdParty/libwebrtc

Update libvpx to M92
https://bugs.webkit.org/show_bug.cgi?id=226488

Reviewed by Eric Carlson.

CMakeLists.txt:
Source/third_party/libvpx: Resynced.
libwebrtc.xcodeproj/project.pbxproj:

10:00 AM Changeset in webkit [278563] by imanol

2 edits in trunk/Source/WebCore

Change WebXRSpace::efectiveOrigin() matrix multiplication order
https://bugs.webkit.org/show_bug.cgi?id=224364
<rdar://problem/76754680>

Reviewed by Sergio Villar Senin.

The current multiplication order is not working correctly when combining local-floor space and getOfffsetReferenceSpace().
The reference space is out of sync with input ray pose after some teleportations:
https://github.com/immersive-web/webxr-samples/blob/main/teleportation.html

Tested using WebXR WPT tests.

Modules/webxr/WebXRSpace.cpp:

(WebCore::WebXRSpace::effectiveOrigin const):

8:37 AM Changeset in webkit [278562] by imanol

6 edits in trunk

Use 3D points to map the WebXRBoundedReferenceSpace bounds transform
https://bugs.webkit.org/show_bug.cgi?id=224365
<rdar://problem/76754927>

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Update WebXR test expectations.

web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt:

Source/WebCore:

WebXRBoundedReferenceSpace is currently using Point2D mapping to transfom the bounds geometry.
This is not correct because the originOffset is a 3D transform and it expects the bounds depth
coordinates to be on the z axis instead of the y axis.

Tested by WebXR WPT tests.

Modules/webxr/WebXRBoundedReferenceSpace.cpp:

(WebCore::WebXRBoundedReferenceSpace::updateIfNeeded):

LayoutTests:

Update WebXR test expectations.

platform/wpe/TestExpectations:

8:06 AM Changeset in webkit [278561] by Antti Koivisto

8 edits in trunk/Source/WebCore

Factor selection state computation out of LegacyInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=226718

Reviewed by Alan Bujtas.

Move the code to SelectionRangeData.

layout/integration/LayoutIntegrationRunIteratorModernPath.h:

(WebCore::LayoutIntegration::RunIteratorModernPath::selectableRange const):

rendering/HighlightData.cpp:

(WebCore::HighlightData::highlightStateForRenderer):
(WebCore::HighlightData::highlightStateForTextBox):
(WebCore::HighlightData::rangeForTextBox):

rendering/HighlightData.h:

(WebCore::HighlightData::HighlightData):

rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::selectionState):
(WebCore::LegacyInlineTextBox::selectableRange const):
(WebCore::LegacyInlineTextBox::selectionStartEnd const):
(WebCore::LegacyInlineTextBox::highlightStartEnd const):
(WebCore::LegacyInlineTextBox::verifySelectionState const): Deleted.
(WebCore::LegacyInlineTextBox::clampedStartEndForState const): Deleted.

rendering/LegacyInlineTextBox.h:
rendering/SelectionRangeData.cpp:

(WebCore::SelectionRangeData::SelectionRangeData):

rendering/TextBoxSelectableRange.h:

6:45 AM Changeset in webkit [278560] by Wenson Hsieh

8 edits in trunk

[Cocoa] Find-in-page should match text inside image overlays
https://bugs.webkit.org/show_bug.cgi?id=226704

Reviewed by Tim Horton.

Source/WebCore:

Add a new TextIteratorBehavior to allow TextIterator to descend into image overlay content, and use this option
when creating TextIterators for find-in-page. See WebKit/ChangeLog for more details.

Test: WebKit.FindTextInImageOverlay

editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):
(WebCore::findIteratorOptions):

editing/TextIteratorBehavior.h:

Source/WebKit:

Add the PaintAllContent and PaintBackgrounds text indicator options when generating a TextIndicator for
selected content inside an image overlay. See WebCore/ChangeLog for more details.

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):

WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::findTextIndicatorOptions):
(WebKit::FindIndicatorOverlayClientIOS::drawRect):
(WebKit::FindController::updateFindIndicator):

Tools:

Add an API test to verify that text inside image overlays is visible to find-in-page.

TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

6:26 AM Changeset in webkit [278559] by Aditya Keerthi

3 edits
2 adds in trunk

[iOS] Unexpected scrolling when switching focus from a text input to a select element
https://bugs.webkit.org/show_bug.cgi?id=226657
<rdar://problem/78290515>

Reviewed by Tim Horton.

Source/WebKit:

When switching focus from a text input to a select element, UIKit makes
deferred calls to -[WKWebView inputView] after the keyboard dismissal.
This method calls -[WKContentView inputViewForWebView], which calls
-[WKContentView _zoomToRevealFocusedElement]. Consequently, these
methods can get invoked while the context menu (dropdown) is displayed
for a focused select element.

In this instance, the call should be idempotent, since the focused element
is fully visible in the viewport. However, since the context menu is visible
and overlaps the element, our logic incorrectly determines that the element
is obscured, leading to unexpected zooming/scrolling. To fix, we need to
correct the logic that determines the visible portion of the view.

Test: fast/forms/ios/form-control-refresh/select/focus-select-after-textfield.html

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _zoomToFocusRect:selectionRect:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):

Always use the window to determine the portion of the webview that is
visible, rather than relying on the root view controller's top-most
full-screen view controller's view.

The old logic worked fine in most cases, since the root view controller
and the top-most full-screen view controller are almost always the same.
Furthermore, the root view controller's view usually takes up the entire
window.

However, when the context menu is on screen, the top-most full-screen
view controller is an internal UIKit view controller
(_UIContextMenuActionsOnlyViewController), and the associated view
is the context menu view. This exposed a flaw in the existing logic, as
visibility detection could be performed by intersecting with an
incorrect view. In general, the top-most full-screen view is not a
reliable way to determine the visible portion of the webview.

LayoutTests:

Add a layout test to exercise the bug.

fast/forms/ios/form-control-refresh/select/focus-select-after-textfield-expected.txt: Added.
fast/forms/ios/form-control-refresh/select/focus-select-after-textfield.html: Added.

4:45 AM Changeset in webkit [278558] by aboya@igalia.com

2 edits in trunk/Source/WTF

[WTF][GStreamer] Fix clang TSA warnings in WTF::DataMutex
https://bugs.webkit.org/show_bug.cgi?id=226719

Reviewed by Xabier Rodriguez-Calvar.

Fix the remaning clang thread safety warnings in WTF::DataMutex.

The goal of this patch is to reduce the number of warnings in the
GStreamer codebase. Whether DataMutex should be deprecated in favor of
Locker with the clang TSA annotations is outside of the scope of this
patch.

wtf/DataMutex.h:

4:43 AM Changeset in webkit [278557] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Add clang TSA annotations: MainThreadNotifier
https://bugs.webkit.org/show_bug.cgi?id=226717

Reviewed by Xabier Rodriguez-Calvar.

Adds clang thread safety annotations to
MainThreadNotifier.h

platform/graphics/gstreamer/MainThreadNotifier.h:

4:43 AM Changeset in webkit [278556] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Add clang TSA annotations: InbandTextTrackPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=226716

Reviewed by Xabier Rodriguez-Calvar.

Adds clang thread safety annotations to
InbandTextTrackPrivateGStreamer.h.

platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

4:40 AM Changeset in webkit [278555] by aboya@igalia.com

2 edits in trunk/Source/WTF

[GStreamer] Remove spurious assert in WTF::DataMutex
https://bugs.webkit.org/show_bug.cgi?id=226714

Reviewed by Michael Catanzaro.

Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker
constructor, introduced in r278248.

Trying to lock a currently held mutex is not an error condition that
should crash the process, it will just wait for its turn to lock it.

wtf/DataMutex.h:

4:40 AM Changeset in webkit [278554] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Fix clang TSA warning in AbortableTaskQueue
https://bugs.webkit.org/show_bug.cgi?id=226715

Reviewed by Michael Catanzaro.

Fixes a clang thread safety analysis warning in AbortableTaskQueue.

platform/AbortableTaskQueue.h:

4:11 AM Changeset in webkit [278553] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

$vm should have a function for checking if security assertions are enabled similar to $vm.assertEnabled
https://bugs.webkit.org/show_bug.cgi?id=226020
<rdar://problem/78567619>

Patch by Tuomas Karkkainen <tuomas.webkit@apple.com> on 2021-06-07
Reviewed by Mark Lam.

Add method $vm.securityAssertEnabled() which parallels $vm.assertEnabled(), and allows
checking at runtime whether the current JavaScriptCore build has security assertions enabled.

tools/JSDollarVM.cpp:

3:43 AM Changeset in webkit [278552] by commit-queue@webkit.org

3 edits in trunk

[GTK][WPE] Bump libsoup3 version to 2.99.8
https://bugs.webkit.org/show_bug.cgi?id=226713

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-06-07
Reviewed by Philippe Normand.

Source/cmake/OptionsGTK.cmake:
Source/cmake/OptionsWPE.cmake:

1:53 AM Changeset in webkit [278551] by vjaquez@igalia.com

94 edits
13 adds
1 delete in trunk/Source/ThirdParty/libwebrtc

Update libyuv to M92
https://bugs.webkit.org/show_bug.cgi?id=226489

Reviewed by Eric Carlson.

CMakeLists.txt:
Source/third_party/libyuv: Resynced.
Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

Updated 10 bits frame conversion routine to use new libyuv routines (covered by webrtc/vp9-profile2.html)

libwebrtc.xcodeproj/project.pbxproj:

1:37 AM Changeset in webkit [278550] by Philippe Normand

2 edits in trunk/Tools/buildstream

Unreviewed, fix libsoup3 build in Flatpak SDK

elements/sdk/libsoup3.bst:

1:28 AM Changeset in webkit [278549] by commit-queue@webkit.org

2 edits in trunk/Tools/buildstream

[Flatpak SDK] Update to libsoup3 2.99.8
https://bugs.webkit.org/show_bug.cgi?id=226712

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-06-07
Reviewed by Philippe Normand.

elements/sdk/libsoup3.bst:

1:21 AM Changeset in webkit [278548] by Carlos Garcia Campos

5 edits in trunk

[GTK][WPE] Signal "window-object-cleared" not emitted unless frame js context is get before
https://bugs.webkit.org/show_bug.cgi?id=221771

Reviewed by Michael Catanzaro.

Source/WebKit:

This is because when FrameLoader::dispatchDidClearWindowObjectInWorld() is called, the JSWindowProxy for the
world hasn't been created yet, so it returns early. But we want to dispatch it always for worlds created by the
API, to ensure that WebKitScriptWorld::window-object-cleared is emmitted.

WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: Implement globalObjectIsAvailableForFrame() to force the

creation of the JavaScript context for existing WebKitScriptWorlds.

Tools:

Update window-object-cleared test to check that the signal is emitted for the WebKitScriptWorld objects created
by the extension.

TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(UserMessageTest::sendMessage):
(UserMessageTest::viewUserMessageReceived):
(UserMessageTest::waitUntilViewMessagesReceived):
(UserMessageTest::waitUntilViewMessageReceived):
(testWebExtensionWindowObjectCleared):
(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(windowObjectCleared):
(isolatedWorldWindowObjectCleared):
(webkit_web_extension_initialize_with_user_data):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed