⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 25, 2021:

8:37 PM Changeset in webkit [281613] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Crash in GraphicsContextGLOpenGL::reshapeDisplayBufferBacking
​https://bugs.webkit.org/show_bug.cgi?id=229309

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-25
Reviewed by Myles C. Maxfield.

Source/WebCore:

Test: fast/canvas/xr-compatible-crash.html

Null check m_swapChain because reshapeDisplayBufferBacking can be called before it is set.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::addContextObject):

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):

  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::reshapeDisplayBufferBacking):

LayoutTests:

  • fast/canvas/xr-compatible-crash.html: Added.
  • fast/canvas/xr-compatible-crash-expected.txt: Added.
8:08 PM Changeset in webkit [281612] by Aditya Keerthi
  • 7 edits in trunk

[iOS] Unable to select files when the accept attribute is set to "*/*"
​https://bugs.webkit.org/show_bug.cgi?id=229456
rdar://82346315

Reviewed by Chris Dumez.

Source/WebKit:

"*/*" is a valid MIME type string representing all media types. However,
the UniformTypeIdentifiers framework (as well as the now deprecated
CoreServices type identifiers API) does not map wildcard MIME types.

In order to restrict UIDocumentPickerViewController to the types of
files specified in the accept attribute, all MIME type strings are
converted into UTTypes. However, when attempting to retrieve a UTType
for "*/*", the system dynamically generates a type, since the string is
unregistered. Then, since no files conform to the dynamic type, all
files in the document picker are greyed out, and the user is unable
to access the "Photo Library" and "Take Photo or Video" items.

To fix, return an empty set of type identifiers whenever "*/*" is
present in the list of MIME types, ensuring there are no restrictions
on the types of files that can be selected.

Note that the same issue does not occur on macOS, since all MIME types
are mapped to a set of file extensions, rather than UTTypes. Furthermore,
on macOS, the embedding app, not WebKit, is responsible for displaying
the file picker.

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

LayoutTests:

Updated tests to verify that setting the accept attribute to "*/*" does
not impose any restrictions on the types of files that can be selected,
and gives the user access to all menu options.

  • fast/forms/ios/file-upload-panel-accept-expected.txt:
  • fast/forms/ios/file-upload-panel-accept.html:
  • fast/forms/ios/file-upload-panel-expected.txt:
  • fast/forms/ios/file-upload-panel.html:
8:07 PM Changeset in webkit [281611] by Chris Dumez
  • 2 edits in trunk/LayoutTests

REGRESSION (r281516): [AppleSilicon WK2] fast/loader/reload-zero-byte-plugin.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=229532
<rdar://problem/82370692>

Unreviewed, temporarily skip the test on macOS WK2 while I investigate, so that the bots don't
complain.

  • platform/mac-wk2/TestExpectations:
6:38 PM Changeset in webkit [281610] by Wenson Hsieh
  • 22 edits in trunk

Remove some iOS-specific compile-time guards that are no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=229500

Reviewed by Tim Horton.

Source/WebCore:

See WebKit/ChangeLog for more details.

  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

  • platform/PlatformKeyboardEvent.h:
  • platform/ios/KeyEventIOS.mm:

(WebCore::isFunctionKey):

Source/WebKit:

Remove two compile-time flags that were no longer necessary after WebKit's minimum supported iOS version became
iOS 14: USE(UIKIT_KEYBOARD_ADDITIONS) and HAVE(NONDESTRUCTIVE_IMAGE_PASTE_SUPPORT_QUERY).

HAVE(NONDESTRUCTIVE_IMAGE_PASTE_SUPPORT_QUERY) was only needed for a workaround in our test infrastructure,
while USE(UIKIT_KEYBOARD_ADDITIONS) was only introduced to maintain basic hardware keyboard functionality in
iOS 12, while supporting improvements to hardware keyboard support in iOS 13.

The latter now only guards PLATFORM(IOS) || PLATFORM(MACCATALYST). However, there's no reason the codepaths
for hardware keyboard support can't exist on watchOS as well (especially since most of hardware keyboard
support is already implemented there -- just unreachable because it's not possible to attach a hardware keyboard
to an Apple watch). We can remove this feature flag, and simply delete code that was formerly guarded by
!USE(UIKIT_KEYBOARD_ADDITIONS).

  • Platform/spi/ios/UIKitSPI.h:
  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::encode const):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebKeyboardEvent.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanUpInteraction]):
(-[WKContentView _disableAutomaticKeyboardUI]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _setMarkedText:highlights:selectedRange:]):
(-[WKContentView textInputTraits]):
(-[WKContentView _handleKeyUIEvent:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView _hardwareKeyboardAvailabilityChanged]):
(-[WKContentView _selectionChanged]):
(-[WKContentView keyCommands]): Deleted.
(-[WKContentView handleKeyEvent:]): Deleted.

  • UIProcess/ios/WKSyntheticFlagsChangedWebEvent.h:
  • UIProcess/ios/WKSyntheticFlagsChangedWebEvent.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):
(-[WKSelectTableViewController hasText]): Deleted.
(-[WKSelectTableViewController insertText:]): Deleted.
(-[WKSelectTableViewController deleteBackward]): Deleted.

  • WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::handleInputMethodKeydown):

Source/WTF:

Remove the feature flags. See WebKit/ChangeLog for more details.

  • wtf/PlatformHave.h:
  • wtf/PlatformUse.h:

Tools:

Remove this workaround, which was only required to keep an API test passing on iOS 13.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):
(overrideKeyboardDelegateSupportsImagePaste): Deleted.

5:47 PM Changeset in webkit [281609] by Alan Coon
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r281595. rdar://problem/82365117

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Build fix after ​https://commits.webkit.org/240941@main.

  • Scripts/generate-derived-sources.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:47 PM Changeset in webkit [281608] by Alan Coon
  • 2 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r281577. rdar://problem/82365117

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Skip unneeded commands when preprocessing sandbox on iOS.

  • Scripts/generate-derived-sources.sh:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:43 PM Changeset in webkit [281607] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r281513?): [ JSC Catalina+ Debug ] 16 stress/intl-enumeration.js (JSC Tests) are flaky failing
​https://bugs.webkit.org/show_bug.cgi?id=229526

Reviewed by Mark Lam.

Fix debug JSC test failures by using RELEASE_AND_RETURN.

  • runtime/IntlObject.cpp:

(JSC::availableCalendars):
(JSC::availableCollations):
(JSC::availableCurrencies):
(JSC::availableNumberingSystems):
(JSC::availableTimeZones):

5:39 PM Changeset in webkit [281606] by Simon Fraser
  • 12 edits in trunk/Source/WebKit

Replace the uint64_t used to identify form submits with a strongly typed identifier
​https://bugs.webkit.org/show_bug.cgi?id=229513

Reviewed by Alex Christensen.

Introduce FormSubmitListenerIdentifier and use it in place of a uint64_t.

  • Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

  • Shared/IdentifierTypes.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setUpWillSubmitFormListener):
(WebKit::WebFrame::continueWillSubmitForm):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::continueWillSubmitForm):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:01 PM Changeset in webkit [281605] by Alan Coon
  • 3 edits
    1 move in branches/safari-612-branch

Cherry-pick r281500. rdar://problem/82350929

(r281473) stress/for-in-has-own-property-shouldnt-flush-registers.js failing on Debug
​https://bugs.webkit.org/show_bug.cgi?id=229448

Reviewed by Mark Lam.

JSTests:

Fix typo in test name.

  • stress/for-in-in-by-val-should-flush-registers.js: Renamed from JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js.

Source/JavaScriptCore:

Add missing exception checks.

  • dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [281604] by Alan Coon
  • 1 edit in branches/safari-612-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

Cherry-pick r281250. rdar://problem/82354967

Build fix after r281245.

Link with Metal.framework.

  • Configurations/WebCoreTestSupport.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:01 PM Changeset in webkit [281603] by Alan Coon
  • 7 edits
    4 adds in branches/safari-612-branch

Cherry-pick r281245. rdar://problem/82354967

WebGL via Metal experimental feature does not correctly toggle metal backend
​https://bugs.webkit.org/show_bug.cgi?id=229267
<rdar://81855735>

Source/WebCore:

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.

Tests: webgl/webgl-metal-disabled.html

webgl/webgl-metal-enabled.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::create):
  • testing/Internals.cpp: (WebCore::Internals::requestedMetal):
  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.mm: (WebCore::Internals::platformSupportsMetal):

LayoutTests:

Add tests to verify WebGL feature flag works as intended.

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

  • webgl/webgl-metal-disabled-expected.txt: Added.
  • webgl/webgl-metal-disabled.html: Added.
  • webgl/webgl-metal-enabled-expected.txt: Added.
  • webgl/webgl-metal-enabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:00 PM Changeset in webkit [281602] by Truitt Savell
  • 2 edits in trunk/LayoutTests

25 webkit imported/w3c/web-platform-tests/css/ layout tests failing with black bars
rdar://82132196

Unreviewed test gardening.

4:58 PM Changeset in webkit [281601] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Catalina GPU] fast/canvas/webgl/lose-context-on-timeout.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229523.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:52 PM Changeset in webkit [281600] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for fast/events/ios/key-events-comprehensive/key-events-meta-shift.html.
<rdar://80385777>.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
4:39 PM Changeset in webkit [281599] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

[iOS] Visual Look Up animates from the wrong rect when the web view is scaled
​https://bugs.webkit.org/show_bug.cgi?id=229518
rdar://82147473

Reviewed by Darin Adler.

When adopting QLPreviewControllerDelegate's animated transition methods for rdar://76020349, I mistakenly
thought that the outContentRect passed into -previewController:transitionImageForPreviewItem:contentRect:
would be in source view (WKContentView) coordinates; instead, QuickLook expects this contentRect to be in
window coordinates.

Fix this by first converting _visualSearchPreviewImageBounds to window coordinates.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView previewController:transitionImageForPreviewItem:contentRect:]):

4:15 PM Changeset in webkit [281598] by Alan Coon
  • 8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.2.3

4:07 PM Changeset in webkit [281597] by eric.carlson@apple.com
  • 10 edits in trunk/Source

[GPUP] RemoteAudioSession doesn't implement begin/endInterruption
​https://bugs.webkit.org/show_bug.cgi?id=229514
rdar://80896732

Reviewed by Jer Noble.

Source/WebCore:

Move the code necessary to deal with interruptions from AudioSessionIOS to the
base class so it can be shared with RemoteAudioSession.

Tested manually.

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::addInterruptionObserver): Move implementation from AudioSessionIOS
so it can be shared.
(WebCore::AudioSession::removeInterruptionObserver): Ditto.
(WebCore::AudioSession::beginInterruption): Ditto.
(WebCore::AudioSession::endInterruption): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::categoryOverride const): Ditto.

  • platform/audio/AudioSession.h:
  • platform/audio/ios/AudioSessionIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSessionIOS::setCategoryOverride): Deleted.
(WebCore::AudioSessionIOS::categoryOverride const): Deleted.
(WebCore::AudioSessionIOS::addInterruptionObserver): Deleted.
(WebCore::AudioSessionIOS::removeInterruptionObserver): Deleted.
(WebCore::AudioSessionIOS::beginInterruption): Deleted.
(WebCore::AudioSessionIOS::endInterruption): Deleted.

  • platform/audio/mac/AudioSessionMac.h:
  • platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSessionMac::setCategoryOverride): Deleted.

Source/WebKit:

  • WebProcess/GPU/media/RemoteAudioSession.cpp:

(WebKit::RemoteAudioSession::setIsPlayingToBluetoothOverride): Remove
ENABLE_ROUTING_ARBITRATION guard because it isn't used in the base class.

  • WebProcess/GPU/media/RemoteAudioSession.h: Change the order virtual methods are declared

so they match the base class, to make it easier to spot differences.

3:52 PM Changeset in webkit [281596] by mmaxfield@apple.com
  • 2 edits in trunk

Add command to enable logging in the docs
​https://bugs.webkit.org/show_bug.cgi?id=229419

Reviewed by Dean Jackson.

  • Introduction.md:
3:45 PM Changeset in webkit [281595] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Build fix after ​https://commits.webkit.org/240941@main.

  • Scripts/generate-derived-sources.sh:
3:34 PM Changeset in webkit [281594] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance2.
​https://bugs.webkit.org/show_bug.cgi?id=189672.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:12 PM Changeset in webkit [281593] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk1] pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229522.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
3:05 PM Changeset in webkit [281592] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] pointer-lock/lock-already-locked.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229521.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:00 PM Changeset in webkit [281591] by Alan Coon
  • 1 edit in branches/safari-612.1.29-branch/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig

Cherry-pick r281250. rdar://problem/82354939

Build fix after r281245.

Link with Metal.framework.

  • Configurations/WebCoreTestSupport.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:00 PM Changeset in webkit [281590] by Alan Coon
  • 7 edits
    4 adds in branches/safari-612.1.29-branch

Cherry-pick r281245. rdar://problem/82354939

WebGL via Metal experimental feature does not correctly toggle metal backend
​https://bugs.webkit.org/show_bug.cgi?id=229267
<rdar://81855735>

Source/WebCore:

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

GraphicsContextGLAttributes defines 'useMetal' as 'true' by default.
Since this branch was only checking if Metal was enabled via the
setting, rather than checking the status of the flag, the metal backend
was never disabled, even when requested.

Tests: webgl/webgl-metal-disabled.html

webgl/webgl-metal-enabled.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::create):
  • testing/Internals.cpp: (WebCore::Internals::requestedMetal):
  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.mm: (WebCore::Internals::platformSupportsMetal):

LayoutTests:

Add tests to verify WebGL feature flag works as intended.

Patch by Kyle Piddington <Kyle Piddington> on 2021-08-19
Reviewed by Dean Jackson.

  • webgl/webgl-metal-disabled-expected.txt: Added.
  • webgl/webgl-metal-disabled.html: Added.
  • webgl/webgl-metal-enabled-expected.txt: Added.
  • webgl/webgl-metal-enabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@281245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:47 PM Changeset in webkit [281589] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1] media/media-session/actionHandlerInternalMappings.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229519.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:37 PM Changeset in webkit [281588] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

REGRESSION(r281297): 2 webrtc tests failing.
​https://bugs.webkit.org/show_bug.cgi?id=229517.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:19 PM Changeset in webkit [281587] by Yijia Huang
  • 8 edits in trunk/Source/JavaScriptCore

[ARM64] Fix pre-index address mode
​https://bugs.webkit.org/show_bug.cgi?id=229175

Reviewed by Saam Barati.

This patch fixes the canonicalization phase for pre/post-increment address mode
due to the potential bugs commented on in the previous patch
​https://bugs.webkit.org/show_bug.cgi?id=228538. And this patch removed the
temporary fix in ​https://bugs.webkit.org/show_bug.cgi?id=229211.

Previously, the pre-index address mode for Load instruction convert the pattern
to the canonical form like this:

address = Add(base, offset) address = Add(base, offset)
... --> newMemory = Load(base, offset)
... ...
memory = Load(base, offset) memory = Identity(newMemory)

which is wrong. Assume "..." contains a store to a memory location that aliases for address:

address = Add(base, offset) address = Add(base, offset)
... --> newMemory = Load(base, offset)
... ...
Store(value1, address) Store(value1, address)
memory = Load(base, offset) memory = Identity(newMemory)

The loaded value should always be value1 which is not true after the conversion.
So, moving the load above the store is semantically incorrect because it's not identical to
the behavior of the original program. In this case, maybe we should apply alias analysis to
detect the violations of reference updating.

To solve this problem, we moves the address value to just before the memory value instead of
moving memory value upward.

Convert Pre-Index Load Pattern to the Canonical Form:

address = Add(base, offset) address = Nop
... ...
... newAddress = Add(base, offset)
memory = Load(base, offset) --> memory = Load(base, offset)
... ...
parent = B3Opcode(address, ...) parent = B3Opcode(newAddress, ...)

Convert Pre-Index Store Pattern to the Canonical Form:

address = Add(base, offset) address = Nop
... ...
... newAddress = Add(base, offset)
memory = Store(value1, base, offset) --> memory = Store(value1, base, offset)
... ...
parent = B3Opcode(address, ...) parent = B3Opcode(newAddress, ...)

To move the address value downward, we need to make sure that no use reference of address between
the address and memory values.

  • b3/B3CanonicalizePrePostIncrements.cpp:

(JSC::B3::canonicalizePrePostIncrements):

  • b3/B3Generate.cpp:

(JSC::B3::generateToAir):

  • b3/B3ValueKey.h:
  • b3/B3ValueKeyInlines.h:

(JSC::B3::ValueKey::ValueKey):

  • b3/testb3.h:
  • b3/testb3_3.cpp:

(testLoadWithStorePreIndex32):
(testStorePreIndex32):
(testStorePreIndex64):
(testStorePostIndex32):
(testStorePostIndex64):
(addShrTests):

  • runtime/OptionsList.h:
2:18 PM Changeset in webkit [281586] by Jonathan Bedard
  • 5 edits in trunk/Tools

[git-webkit] Use Python 3 in CI
​https://bugs.webkit.org/show_bug.cgi?id=229498
<rdar://problem/82342387>

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/steps.py:

(ShowIdentifier.start): Invoke git-webkit with Python 3.

  • CISupport/build-webkit-org/steps_unittest.py:

(TestShowIdentifier.test_success):
(TestShowIdentifier.test_failure):

  • CISupport/ews-build/steps.py:

(ShowIdentifier.start): Invoke git-webkit with Python 3.

  • CISupport/ews-build/steps_unittest.py:
2:18 PM Changeset in webkit [281585] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2 Release] imported/w3c/web-platform-tests/resource-timing/status-codes-create-entry.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229516.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:15 PM Changeset in webkit [281584] by Chris Dumez
  • 4 edits in trunk/LayoutTests

[Mac wk2] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=229511
<rdar://problem/82356082>

Unreviewed, address test flakiness by silencing console logging.

LayoutTests/imported/w3c:

  • web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https-expected.txt:

LayoutTests:

2:11 PM Changeset in webkit [281583] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

Update test expectations for imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html .
​https://bugs.webkit.org/show_bug.cgi?id=229511.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:11 PM Changeset in webkit [281582] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk2] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/reporting-to-frame-owner.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229511.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:06 PM Changeset in webkit [281581] by Jonathan Bedard
  • 4 edits in trunk/Tools

[resultsdbpy] Handle E configuration comparisons
​https://bugs.webkit.org/show_bug.cgi?id=229477
<rdar://problem/82316775>

Reviewed by Stephanie Lewis.

  • Scripts/libraries/resultsdbpy/resultsdbpy/init.py: Bump version.
  • Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js:

(Configuration.prototype.compare): Ignore "E" version names in both directions.

  • Scripts/libraries/resultsdbpy/setup.py: Bump version.
2:06 PM Changeset in webkit [281580] by Simon Fraser
  • 12 edits
    426 adds
    2 deletes in trunk/LayoutTests

Update css-masking WPT
​https://bugs.webkit.org/show_bug.cgi?id=229373

Reviewed by Tim Horton.
LayoutTests/imported/w3c:

Re-import css-masking tests from WPT fe104253de3197002a2600a4ed7e3b5e18fc9121.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-masking/META.yml: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-composition-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-composition.html: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-001.html: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/clip-path-interpolation-002.html: Added.
  • web-platform-tests/css/css-masking/animations/mask-image-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/mask-image-interpolation.html: Added.
  • web-platform-tests/css/css-masking/animations/mask-position-interpolation-expected.txt: Added.
  • web-platform-tests/css/css-masking/animations/mask-position-interpolation.html: Added.
  • web-platform-tests/css/css-masking/animations/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-nested-twice-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-nested-twice.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-008-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-008.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-009-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-009.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-010-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip-rule-010.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-clip-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-invisible-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-invisible.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-syling-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-syling.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-css-transform-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-child-changes-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-child-changes.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-clippathunits-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-clippathunits.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-href-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-href.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-id-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-dom-id.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-invalid.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-negative-scale-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-negative-scale.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-no-content-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-objectboundingbox-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-g-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-marker-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-svg-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-on-use-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-precision-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-precision-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-recursion-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-circle-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-ellipse-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-inset-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-shape-polygon-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-userspaceonuse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-userspaceonuse-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-opacity-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-opacity.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-with-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-and-nested-clip-path-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-and-nested-clip-path.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-003.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-004-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-004.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-005-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-005.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-006-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-006.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-007-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-007.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-008-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-008.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-009-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-009.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-001.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-panning-002.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-objectboundingbox-content-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-transform-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip-transform.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/mask-userspaceonuse-content-clip.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-circle-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-clip-rule-004-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-content-clip-004-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-ellipse-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-invisible-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-negative-scale-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-on-marker-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-on-marker-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-precision-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-recursion-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-shape-inset-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-square-hole-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/clip-path-text-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-and-nested-clip-path-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-content-clip-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-content-clip-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-002-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/mask-nested-clip-path-003-ref.svg: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path-svg-content/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/clip-path-animation-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/clip-path-animation.html: Added.
  • web-platform-tests/css/css-masking/clip-path/animations/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-blending-offset-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-blending-offset.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-descendant-text-mutated-001.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-inset-round-percent-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-inset-round-percent.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom-expected.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-interpolation-with-zoom.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-expected.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest-expected.html: Removed.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest-expected.txt: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom-hittest.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-path-with-zoom.html:
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-backdrop-filter-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-backdrop-filter.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-font-loading-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-path/clip-path-svg-text-font-loading.html: Added.
  • web-platform-tests/css/css-masking/clip-path/w3c-import.log:
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-001.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/clip-rule-002.html: Added.
  • web-platform-tests/css/css-masking/clip-rule/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-absolute-positioned-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-filter-order-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-filter-order.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-fixed-pos-transform-descendant-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-fixed-pos-transform-descendant-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-negative-values-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-clipping-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-stacking-context-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-no-stacking-context.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-not-absolute-positioned-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-005-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-005.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-006-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-auto-006.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-001-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-001.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-002-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-002.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-003-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-003.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-004-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-comma-004.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-scroll-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-rect-scroll.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-2-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-2.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order-expected.html: Added.
  • web-platform-tests/css/css-masking/clip/clip-transform-order.html: Added.
  • web-platform-tests/css/css-masking/clip/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-001.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-objectboundingbox-002.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-userspaceonuse-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-element-userspaceonuse-001.html: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-shape-polygon-and-box-shadow-expected.txt: Added.
  • web-platform-tests/css/css-masking/hit-test/clip-path-shape-polygon-and-box-shadow.html: Added.
  • web-platform-tests/css/css-masking/hit-test/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/idlharness-expected.txt: Added.
  • web-platform-tests/css/css-masking/idlharness.html: Added.
  • web-platform-tests/css/css-masking/inheritance.sub-expected.txt: Added.
  • web-platform-tests/css/css-masking/inheritance.sub.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-clip-exclude-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-clip-exclude.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-data-url-image-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-data-url-image.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-2-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-2.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-ib-split.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-svg-child-will-change-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-svg-child-will-change.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-hash-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image-hash.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-image.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-local-mask-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-local-mask.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-remote-mask-expected.html: Added.
  • web-platform-tests/css/css-masking/mask-image/mask-image-url-remote-mask.html: Added.
  • web-platform-tests/css/css-masking/mask-image/reference/1x1-black-30-alpha.png: Added.
  • web-platform-tests/css/css-masking/mask-image/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-image/support/image-with-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/image.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/mask.svg: Added.
  • web-platform-tests/css/css-masking/mask-image/support/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-image/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-empty-container-with-filter-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-empty-container-with-filter.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-negative-scale-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-negative-scale.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-text-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-text-001.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-001-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-001.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-002-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-002.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-003-expected.txt: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/mask-type-003.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-green-square-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-negative-scale-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/mask-text-001-ref.svg: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/reference/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/mask-svg-content/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/parsing/clip-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-path-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-rule-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/clip-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/clip-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-position-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-computed-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-computed.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-invalid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-invalid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-valid-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-type-valid.html: Added.
  • web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt: Added.
  • web-platform-tests/css/css-masking/parsing/mask-valid.sub.html: Added.
  • web-platform-tests/css/css-masking/parsing/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/resources/blue-20.png: Added.
  • web-platform-tests/css/css-masking/resources/green-20.png: Added.
  • web-platform-tests/css/css-masking/resources/stripes-20.png: Added.
  • web-platform-tests/css/css-masking/resources/w3c-import.log: Added.
  • web-platform-tests/css/css-masking/w3c-import.log: Added.

LayoutTests:

Re-import css-masking tests from WPT fe104253de3197002a2600a4ed7e3b5e18fc9121.

  • TestExpectations:
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-001-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-002-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-003-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-004-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-text-005-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/mask-nested-clip-path-010-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/css/css-masking/mask-svg-content/mask-text-001-expected.txt: Added.
  • platform/ios/TestExpectations:
  • platform/mac/imported/w3c/web-platform-tests/css/css-masking/clip-path/svg-clipPath-expected.txt: Removed.
2:01 PM Changeset in webkit [281579] by Aditya Keerthi
  • 9 edits
    2 adds in trunk

[iOS] Crash when tapping <select> element and calling window.open()
​https://bugs.webkit.org/show_bug.cgi?id=229468
rdar://82122972

Reviewed by Wenson Hsieh.

Source/WebKit:

UIKit throws an exception when attempting to present a context menu
for a view that is not in a window.

One instance where this can occur in Safari is when a call to
window.open() is made in response to a touch on a select element.
In this scenario, the call to window.open() opens a new tab, unparenting
the current webview. However, the touch also focuses the element, and
WebKit attempts to present a context menu in an unparented view.

To fix, guard against the case where the view is not parented, and do
not attempt to present a context menu.

Test: fast/forms/ios/show-select-menu-in-unparented-view-crash.html

  • UIProcess/ios/WKActionSheetAssistant.mm:

Note that the helper method used in other classes is not used in
WKActionSheetAssistant, since the hosting view is not always a
WKContentView.

(-[WKActionSheetAssistant showDataDetectorsUIForPositionInformation:]):
(-[WKActionSheetAssistant showMediaControlsContextMenu:items:completionHandler:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView presentContextMenu:atLocation:]):

Added a helper method to ensure the view is parented prior to presenting
a context menu.

(-[WKContentView imageAnalysisGestureDidTimeOut:]):

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsDropdown _showSuggestions]):

  • UIProcess/ios/forms/WKDateTimeInputControl.mm:

(-[WKDateTimePicker showDateTimePicker]):

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel showDocumentPickerMenu]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectPicker showSelectPicker]):

LayoutTests:

Added a test to verify a crash does not occur when tapping a <select>
element and unparenting the webview.

  • fast/forms/ios/show-select-menu-in-unparented-view-crash-expected.txt: Added.
  • fast/forms/ios/show-select-menu-in-unparented-view-crash.html: Added.
1:55 PM Changeset in webkit [281578] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening after r228617.

1:33 PM Changeset in webkit [281577] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Build error preprocessing sandbox
​https://bugs.webkit.org/show_bug.cgi?id=229418

Reviewed by Alexey Proskuryakov.

Skip unneeded commands when preprocessing sandbox on iOS.

  • Scripts/generate-derived-sources.sh:
12:59 PM Changeset in webkit [281576] by Wenson Hsieh
  • 7 edits in trunk

[iOS 15] editing/input/cocoa/autocorrect-on.html times out when run after editing/input/cocoa/autocorrect-off.html
​https://bugs.webkit.org/show_bug.cgi?id=229486
rdar://82191308

Reviewed by Tim Horton.

Source/WebKit:

See changes in Tools for more details.

  • Platform/spi/ios/TextInputSPI.h:
  • Platform/spi/ios/UIKitSPI.h:

Tools:

The layout test (autocorrect-on.html) fails when run immediately after autocorrect-off.html, in the same
directory. This occurs because autocorrect-on.html attempts to verify that typing a period after "Tset" will
autocorrect to "Test"; however, the previous test disables autocorrection and types "Tset.", which causes UIKit
keyboard autocorrection code to add "Tset" to its lexicon. This means that we end up not autocorrecting to
"Test" in autocorrect-on.html.

In the past (r265376), to mitigate this, we set -[UIKeyboardImpl correctionLearningAllowed] to NO. However,
after what appears to be a recent TextInput change, this fails to prevent the test runner from learning "Tset"
while running autocorrect-off.html.

We take a more heavy-handed approach in this mitigation, and instead use swizzling to prevent UIKeyboardImpl
from notifying kbd when text candidates are "accepted".

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(overrideSyncInputManagerToAcceptedAutocorrection):
(WTR::TestController::platformResetStateToConsistentValues):

LayoutTests:

Remove the failing test expectations.

  • platform/ios-wk2/TestExpectations:
12:50 PM Changeset in webkit [281575] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] Line spanning inline boxes should also be in the run list
​https://bugs.webkit.org/show_bug.cgi?id=228059
<rdar://problem/81077420>

Reviewed by Antti Koivisto.

Consider the following case:

<div><span>first line text<br>second line text<br>third line text</span></div>

Here is the list of runs we generate for the content above:

[inline box][first line text][hard linebreak][second line text][hard linebreak][third line text]

This list does not include the spanning inline boxes, i.e. the missing inline box on the second and the third line.
The integration code then looks inside the LineBox to find these spanning inline boxes (see createDisplayNonRootInlineBoxes)

In this patch we start including such spanning inline boxes in the run list.

[inline box][first line text][hard linebreak][inline box][second line text][hard linebreak][inline box][third line text]

This is also in preparation for making LineBox completely internal to the layout code.

  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

  • layout/formattingContexts/inline/InlineLineRun.h:

(WebCore::Layout::LineRun::isText const):
(WebCore::Layout::LineRun::isLineBreak const):
(WebCore::Layout::LineRun::isAtomicInlineLevelBox const):
(WebCore::Layout::LineRun::isInlineBox const):
(WebCore::Layout::LineRun::isRootInlineBox const):
(WebCore::Layout::LineRun::type const):
(WebCore::Layout::LineRun::hasContent const):
(WebCore::Layout::LineRun::isLineSpanning const):
(WebCore::Layout::LineRun::LineRun):

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLineRuns const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const): Deleted.

  • layout/integration/LayoutIntegrationInlineContentBuilder.h:
12:40 PM Changeset in webkit [281574] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[GLIB] Update baselines after r281419
​https://bugs.webkit.org/show_bug.cgi?id=229503

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-25

  • platform/gtk/fast/text/fixed-pitch-control-characters-expected.png:
  • platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Added.
  • platform/gtk/fast/text/wide-zero-width-space-expected.png:
  • platform/gtk/fast/text/wide-zero-width-space-expected.txt:
  • platform/wpe/fast/text/fixed-pitch-control-characters-expected.txt: Added.
  • platform/wpe/fast/text/wide-zero-width-space-expected.txt:
11:59 AM Changeset in webkit [281573] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229509.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:49 AM Changeset in webkit [281572] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ iOS EWS ] editing/inserting/insert-paragraph-separator-with-html-elements-crash.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=228718

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/ipad/TestExpectations:
11:48 AM Changeset in webkit [281571] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Infinite loop in for...in after r280760
​https://bugs.webkit.org/show_bug.cgi?id=229493

Patch by Xan Lopez <Xan Lopez> on 2021-08-25
Reviewed by Yusuke Suzuki.

A missing instruction in the 32bit branch can potentially cause
infinite loops when using for-in. No new test, this is already
covered by (among others) LayoutTests/js/reserved-words.html.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorNextUpdateIndexAndMode):

11:46 AM Changeset in webkit [281570] by Russell Epstein
  • 8 edits in branches/safari-612.1.29-branch/Source

Versioning.

WebKit-7612.1.29.3

11:45 AM Changeset in webkit [281569] by commit-queue@webkit.org
  • 22 edits in trunk

Add onsecuritypolicyviolation on GlobalEventHandlers
​https://bugs.webkit.org/show_bug.cgi?id=229381

Patch by Sonia Singla <​ssingla@igalia.com> on 2021-08-25
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/idlharness.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-windowless-body-expected.txt:
  • web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:

Source/WebCore:

onsecuritypolicyviolation attribute has been added to
GlobalEventHandlers by ​https://github.com/whatwg/html/pull/2651

This patch supports it.

Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html

imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html
imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt
imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html

  • dom/GlobalEventHandlers.idl:
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
  • platform/glib/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
11:42 AM Changeset in webkit [281568] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac wk1]imported/w3c/web-platform-tests/css/css-fonts/downloadable-font-in-iframe-print.html is a flaky image-only failure.
​https://bugs.webkit.org/show_bug.cgi?id=229506.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:34 AM Changeset in webkit [281567] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ BigSur arm64 EWS ] security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=229505

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:13 AM Changeset in webkit [281566] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

Added expectations for ios-wk2: security/contentSecurityPolicy/video-with-blob-url-allowed-by-media-src-star.html and security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html are flaky.
​https://bugs.webkit.org/show_bug.cgi?id=155196

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:59 AM Changeset in webkit [281565] by keith_miller@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Add for-in OwnStructureMode optimizations to LLInt
​https://bugs.webkit.org/show_bug.cgi?id=229038

Reviewed by Saam Barati.

This patch adds the optimizations we have for OwnStructureMode in
the Baseline to the LLInt. The patch also adds redundant self move
(i.e. move a, a) elimination to arm64. Finally, a bunch of the
property offset functions are now marked constexpr and return
intptr_t rather than size_t as the values can be negative.

There's also a minor fix to disable MSVC's signed to unsigned
cast warning for LLIntOffsetsExtractor as we don't care about
signedness for extracting constants.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorGetByVal):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_enumerator_get_by_val):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm64.rb:
  • offlineasm/generate_offset_extractor.rb:
  • runtime/Butterfly.h:

(JSC::Butterfly::indexOfPropertyStorage):

  • runtime/JSObject.h:

(JSC::offsetInButterfly):

  • runtime/PropertyOffset.h:

(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForMaxOffset):
(JSC::numberOfSlotsForMaxOffset):
(JSC::offsetForPropertyNumber):

10:46 AM Changeset in webkit [281564] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[IFC][Integration] Non-empty inline boxes may affect overflow scroll
​https://bugs.webkit.org/show_bug.cgi?id=229436

Reviewed by Antti Koivisto.

Use a more focused check whether an inline box (<span>) should contribute to scroll overflow.

  • layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayNonRootInlineBoxes const):

  • layout/integration/LayoutIntegrationLine.h:

(WebCore::LayoutIntegration::NonRootInlineBox::NonRootInlineBox):
(WebCore::LayoutIntegration::NonRootInlineBox::hasScrollableContent const):
(WebCore::LayoutIntegration::NonRootInlineBox::canContributeToLineOverflow const): Deleted.

10:43 AM Changeset in webkit [281563] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug] http/tests/inspector/paymentrequest/payment-request-internal-properties.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229502.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:42 AM Changeset in webkit [281562] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Win EWS ] storage/indexeddb/getdatabases.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229457

Unreviewed test gardening.

  • platform/win/TestExpectations:
10:37 AM Changeset in webkit [281561] by Ayumi Kojima
  • 3 edits in trunk/LayoutTests

[ MacOs iOS EWS ] imported/w3c/web-platform-tests/IndexedDB/serialize-sharedarraybuffer-throws.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229501

Unreviewed test gardening.

  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
10:00 AM Changeset in webkit [281560] by Eric Hutchison
  • 4 edits in trunk/LayoutTests

Update test expectations for webrtc/datachannel/multiple-connections.html.
​https://bugs.webkit.org/show_bug.cgi?id=209878.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:47 AM Changeset in webkit [281559] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.2

Tag Safari-612.1.29.2.

9:42 AM Changeset in webkit [281558] by Russell Epstein
  • 8 edits in branches/safari-612.1.29-branch/Source

Versioning.

WebKit-7612.1.29.2

9:41 AM Changeset in webkit [281557] by Peng Liu
  • 8 edits in trunk

[Monterey] LayoutTest media/element-containing-pip-video-going-into-fullscreen.html is flaky timeout/crash
​https://bugs.webkit.org/show_bug.cgi?id=229453
<rdar://80346428>

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Fix a flaky test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
We need to initialize m_changingVideoFullscreenMode to false in the constructor.
Otherwise, it might be initialized to true and ignore requests to change video
presentation mode.

Source/WebKit:

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::exitFullscreenWithoutAnimationToMode):
When the mock video presentation mode is enabled, the UI process still needs to
notify the Web process that the mode change has been done.

  • WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::didCleanupFullscreen):
Return immediately if the element is not in fullscreen to avoid
an assertion later in enterVideoFullscreenForVideoElement().

LayoutTests:

  • media/element-containing-pip-video-going-into-fullscreen.html:

Enable the mock video presentation mode for testing.

  • platform/mac-wk2/TestExpectations:
9:38 AM Changeset in webkit [281556] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries
​https://bugs.webkit.org/show_bug.cgi?id=229415

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-08-25
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/search-predicate-for-adhoc-radio-groups.html

Enable the ability for WebKit UI element accessibility searches to find
ad-hoc radiogroups. An ad-hoc radiogroup is a group of radiobuttons
connected only by name attribute, missing an appropriate role="radiogroup"
container.

  • accessibility/AccessibilityObject.cpp:

(WebCore::Accessibility::isRadioButtonInDifferentAdhocGroup): Added.
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex):
When searching for radiogroups, also return radiobuttons in different
ad-hoc radiogroups.

LayoutTests:

Add test to ensure WebKit UI element accessibility searches can find
ad-hoc radiogroups. An ad-hoc radiogroup is a group of radiobuttons
connected only by name attributes, missing an appropriate role="radiogroup"
container.

  • accessibility/mac/search-predicate-for-adhoc-radio-groups-expected.txt: Added.
  • accessibility/mac/search-predicate-for-adhoc-radio-groups.html: Added.
  • platform/mac-wk1/TestExpectations: Skip new test due to lack of

AccessibilityUIElement::domIdentifier implementation.

7:49 AM Changeset in webkit [281555] by commit-queue@webkit.org
  • 12 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r281523.
​https://bugs.webkit.org/show_bug.cgi?id=229494

broke cloop build

Reverted changeset:

"Add for-in OwnStructureMode optimizations to LLInt"
​https://bugs.webkit.org/show_bug.cgi?id=229038
​https://commits.webkit.org/r281523

6:50 AM Changeset in webkit [281554] by Kate Cheney
  • 5 edits in trunk/Source/WebCore

WebCrypto uses deprecated CCKeyDerivationHMac
​https://bugs.webkit.org/show_bug.cgi?id=229443
<rdar://problem/48896021>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests because no behavior change. This should be covered by
existing webrtc tests which use this functionality.

Replace deprecated CCKeyDerivationHMac with CCDeriveKey.

  • crypto/mac/CryptoUtilitiesCocoa.cpp:

(WebCore::keyDerivationHMAC):
(WebCore::deriveHDKFBits):

  • crypto/mac/CryptoUtilitiesCocoa.h:

Source/WebCore/PAL:

  • pal/spi/cocoa/CommonCryptoSPI.h:
3:11 AM Changeset in webkit [281553] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[LibWPE] Properly retrieve eglGetPlatformDisplayEXT entrypoint
​https://bugs.webkit.org/show_bug.cgi?id=229234

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2021-08-25
Reviewed by Carlos Garcia Campos.

  • platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:

(WebCore::PlatformDisplayLibWPE::initialize): Along with testing for the
EGL_EXT_platform_base extension, the eglGetPlatformDisplayEXT entrypoint
should be specifically looked up when that extension is present.
EGL_KHR_platform_base check-and-lookup should be done separately, but
should be removed in the near future since the KHR-type variant of this
extension doesn't actually exist.

3:07 AM Changeset in webkit [281552] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

[GLIB] Mark wide gamut canvas tests as unsupported
​https://bugs.webkit.org/show_bug.cgi?id=229483

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-25

  • platform/glib/TestExpectations:
  • platform/glib/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.srgb-expected.txt: Removed.
2:45 AM Changeset in webkit [281551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing null check in AccessibilitySVGElement::inheritsPresentationalRole
​https://bugs.webkit.org/show_bug.cgi?id=228884

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-08-25
Reviewed by Darin Adler.

  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::inheritsPresentationalRole const): Check parent element is not nullptr before
trying to use it.

12:42 AM Changeset in webkit [281550] by commit-queue@webkit.org
  • 3 edits in trunk/Source/ThirdParty/ANGLE

ANGLE Metal index buffer restart range cache is could be maintained more consistently
​https://bugs.webkit.org/show_bug.cgi?id=227451

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-25
Reviewed by Kenneth Russell.

  • src/libANGLE/renderer/metal/BufferMtl.h:

(rx::BufferMtl::RestartRangeCache::RestartRangeCache):
Add optional<RestartRangeCache> which contains the ranges and
the index type used to build the ranges.

  • src/libANGLE/renderer/metal/BufferMtl.mm:

(rx::BufferMtl::markConversionBuffersDirty):
(rx::BufferMtl::clearConversionBuffers):
Invalidate the range cache when clearing conversion buffers.
Otherwise the cache would be left in inconsistent state vs.
the contents of the index buffer in cases of code like:
BufferMtl::setDataImpl() ...

if (...) {

markConversionBufferDirty();

} else {

clearConversionBuffers();

}

(rx::BufferMtl::getRestartIndices):

Aug 24, 2021:

11:21 PM Changeset in webkit [281549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, reverting r281540.
​https://bugs.webkit.org/show_bug.cgi?id=229487

causes local builds to fail reliably

Reverted changeset:

"Improve diagnostics for missing files in DerivedSources.make"
​https://bugs.webkit.org/show_bug.cgi?id=229348
​https://commits.webkit.org/r281540

11:07 PM Changeset in webkit [281548] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

removeFromTopLayer shouldn't be called in every removal of an element
​https://bugs.webkit.org/show_bug.cgi?id=229480

Reviewed by Simon Fraser.

Call it in HTMLDialogElement::removedFromAncestor for now since that's
the only place where top layer is currenlty used.

  • dom/Element.cpp:

(WebCore::Element::removedFromAncestor):

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::removedFromAncestor): Added.

  • html/HTMLDialogElement.h:
11:04 PM Changeset in webkit [281547] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

ANGLE Metal infinities and NaNs generated with incorrect syntax
​https://bugs.webkit.org/show_bug.cgi?id=229439
<rdar://81033366>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-08-24
Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

Generate NaN and infinity constant values correctly.
An else was missing from if-block, causing double processing.

  • src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:

(GenMetalTraverser::emitSingleConstant):

  • src/libANGLE/renderer/metal/mtl_utils.mm:

(rx::mtl::CreateShaderLibrary):

LayoutTests:

Add tests that test some aspects of NaN and -+inf that the GLSL ES 3.00 spec
talks about.

  • webgl/pending/conformance2/glsl3/float-constant-expressions-expected.txt: Added.
  • webgl/pending/conformance2/glsl3/float-constant-expressions.html: Added.
  • webgl/pending/resources/webgl_test_files/conformance2/glsl3/float-constant-expressions.html: Added.
  • webgl/pending/resources/webgl_test_files/js/glsl-conformance-test.js: Added.
10:20 PM Changeset in webkit [281546] by Fujii Hironori
  • 10 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations:
  • platform/wincairo/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/wincairo/editing/selection/3690703-2-expected.txt:
  • platform/wincairo/editing/selection/3690703-expected.txt:
  • platform/wincairo/editing/selection/3690719-expected.txt:
  • platform/wincairo/fast/dom/52776-expected.txt:
  • platform/wincairo/fast/text/capitalize-boundaries-expected.txt:
  • platform/wincairo/fast/text/whitespace/020-expected.txt:
  • platform/wincairo/fast/text/wide-zero-width-space-expected.txt:
10:11 PM Changeset in webkit [281545] by Cameron McCormack
  • 2 edits in trunk/Source/WebCore

Windows build fix after r281470
​https://bugs.webkit.org/show_bug.cgi?id=229476
<rdar://problem/82316227>

Unreviewed.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::initialize):

8:47 PM Changeset in webkit [281544] by mark.lam@apple.com
  • 9 edits in trunk/Source

Refactor ENABLE(JIT_OPERATION_VALIDATION) code to emit no code when disabled.
​https://bugs.webkit.org/show_bug.cgi?id=229482
rdar://82318317

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • assembler/JITOperationList.cpp:

(JSC::addPointers):
(JSC::JITOperationList::populatePointersInJavaScriptCore):
(JSC::JITOperationList::populatePointersInJavaScriptCoreForLLInt):
(JSC::JITOperationList::populatePointersInEmbedder):

  • assembler/JITOperationList.h:

(JSC::JITOperationList::map const):
(JSC::JITOperationList::assertIsJITOperation):
(JSC::JITOperationList::initialize):
(JSC::JITOperationList::populatePointersInJavaScriptCore):
(JSC::JITOperationList::populatePointersInJavaScriptCoreForLLInt):

  • runtime/JSCPtrTag.h:

(JSC::tagJSCCodePtrImpl):
(JSC::untagJSCCodePtrImpl):

Source/WebCore:

  • bindings/js/WebCoreJITOperations.cpp:

(WebCore::populateJITOperations):

  • bindings/js/WebCoreJITOperations.h:

(WebCore::populateJITOperations):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::populateJITOperations):

  • testing/js/WebCoreTestSupport.h:

(WebCoreTestSupport::populateJITOperations):

8:11 PM Changeset in webkit [281543] by Jean-Yves Avenard
  • 2 edits
    2 adds in trunk

[Cocoa] Should video stop being live, time scrubber will not show
​https://bugs.webkit.org/show_bug.cgi?id=229286
rdar://82114447

Reviewed by Eric Carlson.

Work around an issue with AVKit AVTouchBarPlaybackControlsProvider SPI which will
not properly make the time scrubber to be displayed when only the content duration
change.
We do so by toggling the canSeek property to force a relayout of the touch bar
content.

While we can reproduce the issue programatically, at this stage we can only
visually confirm that it's been fixed as we have no infrastructure to check
the content of the touch bar and that the issue itself is in AVKit.
Test: ManualTests/video-livechange-touchbar.html

  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager canSeek]): Add code as property is otherwise read-only.
(-[WebPlaybackControlsManager setCanSeek:]): Add code as property is otherwise read-only.
(-[WebPlaybackControlsManager setContentDuration:]):
(-[WebPlaybackControlsManager setSeekableTimeRanges:]): Explictly set canSeek propery to
ensure property watchers will be called.

8:07 PM Changeset in webkit [281542] by Alan Bujtas
  • 2 edits in trunk/Tools

[ iOS ] TestWebKitAPI.DocumentEditingContext.Request* tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=229446
<rdar://problem/82295496>

Unreviewed.

Adjusting the test case after r281463 to match the new wrapping behavior.

  • TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(TEST):

7:34 PM Changeset in webkit [281541] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

[Re-landing] Add some offlineasm enhancements.
​https://bugs.webkit.org/show_bug.cgi?id=229332
rdar://82163923

Reviewed by Keith Miller.

  1. Enhance "include" offlineasm Instruction to always attempt to include an asm file from <build-products>/usr/local/include/WebKitAdditions/ first. If the specified file is not available there, then it will attempt to include the file from the same directory as the current source file (which in practice, means Source/JavaScriptCore/llint/).
  1. Enhance "include" offlineasm Instruction to allow an optional file to be included if it exists. For example, the following offlineasm code:

include? LowLevelInterpreterAdditions

... will attempt to include a file LowLevelInterpreterAdditions.asm. If the
file does not exist, this will be a no-op. Note: the "?" after the "include"
means the include is optional.

  1. Enhanced "emit" offlineasm Instruction to be able to take more than one operand.

"emit" used to just copy the string operand that follows into the generated
LLIntAssembly.h. Now, "emit" can take multiple comma separated operands, and
will concatenate all the operands.

Additionally, "emit" can now take a LocalLabelReference as an operand. For
example, this offline asm code:

emit "b ", .done
...

.done:

... will generate this inline asm code in LLIntAssembly.h:

"b " LOCAL_LABEL_STRING(_offlineasm_someLabel_done) "\n"

This makes it easier to emit branches to local labels.

  1. Also fixed LLInt code alignment for ARM_THUMB2 and ARM64.

Previously, it was aligned using ".align 4" which means aligned on a 4
instruction boundary. Note: the interpretation of .align varies for different
target CPU architectures.

Now, we do the alignment using ".balign 4" which means align on a 4 byte
boundary. This is the intended alignment because ARM64 instruction size is
4 bytes, and ARM_THUMB2 instruction size is either 2 bytes or 4 bytes.
Using .align before was potentially wasting some code space.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • offlineasm/ast.rb:
  • offlineasm/parser.rb:
6:57 PM Changeset in webkit [281540] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Improve diagnostics for missing files in DerivedSources.make
​https://bugs.webkit.org/show_bug.cgi?id=229348

Reviewed by Alexey Proskuryakov.

We are seeing flaky build failures in certain scenarios (rdar://81042866), which
look like this:

make: * No rule to make target UserAgentScripts.h', needed by all'. Stop.

The theory is that some files that should be present in the file system aren't,
but the error is not clear enough. Let's add better diagnostics to isolate the issue.

  • DerivedSources.make:
5:37 PM Changeset in webkit [281539] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur+ wk1 Release] media/video-poster-background.html is flakily failing.
​https://bugs.webkit.org/show_bug.cgi?id=229481.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
5:23 PM Changeset in webkit [281538] by Russell Epstein
  • 1 copy in tags/Safari-612.1.29.14.1

Tag Safari-612.1.29.14.1.

5:21 PM Changeset in webkit [281537] by Russell Epstein
  • 2 edits in branches/safari-612.1.29.14-branch/Source/WebInspectorUI/WebInspectorUI.vcxproj

Cherry-pick r281151. rdar://problem/82316028

Cherry-pick r281121. rdar://problem/82038333

Apply patch. rdar://problem/81915461

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@281121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.28-branch@281151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:21 PM Changeset in webkit [281536] by Russell Epstein
  • 6 edits in branches/safari-612.1.29.14-branch/Source

Cherry-pick r281150. rdar://problem/82316028

Cherry-pick r280597. rdar://problem/82038333

Speculative build fix. rdar://79147214.

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.15.4-branch@280800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: ​https://svn.webkit.org/repository/webkit/branches/safari-612.1.28-branch@281150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:13 PM Changeset in webkit [281535] by Russell Epstein
  • 8 edits in branches/safari-612.1.29.14-branch/Source

Versioning.

WebKit-7612.1.29.14.1

5:08 PM Changeset in webkit [281534] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

testb3_6 should be using JSSwitchPtrTag instead of JITCompilationPtrTag.
​https://bugs.webkit.org/show_bug.cgi?id=229479
rdar://82316967

Reviewed by Yusuke Suzuki.

This is in testInterpreter() which is emitting code for a jump table.
JSSwitchPtrTag is the right tag to use here.

  • b3/testb3_6.cpp:

(testInterpreter):

5:07 PM Changeset in webkit [281533] by Jean-Yves Avenard
  • 2 edits in trunk/Source/WebCore

MediaSession artwork URL is showing in logs.
​https://bugs.webkit.org/show_bug.cgi?id=229320
rdar://82156288

Reviewed by Eric Carlson.

Only enable artwork logging in debug builds.

  • platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):

5:03 PM Changeset in webkit [281532] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

REGRESSION (r281102?): [Mac wk2] media/track/track-in-band.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229478.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:02 PM Changeset in webkit [281531] by Russell Epstein
  • 1 copy in branches/safari-612.1.29.14-branch

New branch.

4:51 PM Changeset in webkit [281530] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[ Mac,iOS ] media/track/track-in-band-duplicate-tracks-when-source-changes.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=228364.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:40 PM Changeset in webkit [281529] by ysuzuki@apple.com
  • 2 edits in trunk/JSTests

Update Intl tests to support ICU 68
​https://bugs.webkit.org/show_bug.cgi?id=229467

Reviewed by Mark Lam.

ICU 68 changes some outputs of Intl tests. This patch adjusts that.

  • stress/intl-parse-unicode-subtags.js:

(vm.icuVersion):

4:39 PM Changeset in webkit [281528] by Jonathan Bedard
  • 2 edits in trunk/Tools

[run-webkit-tests] Use Python 3 (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=226658
<rdar://problem/78882016>

Reviewed by Dewei Zhu.

  • Scripts/run-webkit-tests: Change shebang to Python 3.
4:31 PM Changeset in webkit [281527] by Chris Dumez
  • 9 edits
    2 adds in trunk

change event is dispatched when .files property is set at <input type="file"> element
​https://bugs.webkit.org/show_bug.cgi?id=180465

Reviewed by Darin Adler.

Source/WebCore:

We should not dispatch a change / input events when setting input.files via JavaScript,
as per:

This aligns our behavior with both Chrome and Firefox.

Test: fast/dom/HTMLInputElement/input-setFiles-no-change-event.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):
(WebCore::FileInputType::didCreateFileList):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setFiles):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::filesForBindings):
(WebCore::HTMLInputElement::setFilesForBindings):

  • html/HTMLInputElement.idl:
  • html/InputType.cpp:

(WebCore::InputType::setFiles):

  • html/InputType.h:

LayoutTests:

Add layout test coverage.

  • fast/dom/HTMLInputElement/input-setFiles-no-change-event-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-setFiles-no-change-event.html: Added.
4:26 PM Changeset in webkit [281526] by Russell Epstein
  • 1 copy in tags/Safari-612.1.27.0.31

Tag Safari-612.1.27.0.31.

4:22 PM Changeset in webkit [281525] by ntim@apple.com
  • 2 edits in trunk/Source/WebCore

Use RefPtr instead of auto* in EventHandler::defaultKeyboardEventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=229475

Unreviewed.

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultKeyboardEventHandler):

4:12 PM Changeset in webkit [281524] by Aditya Keerthi
  • 3 edits in trunk/LayoutTests

REGRESSION (r276598): [ iOS ] fast/forms/ios/accessory-bar-navigation.html is a constant timeout
​https://bugs.webkit.org/show_bug.cgi?id=229471
rdar://80390931

Reviewed by Wenson Hsieh.

  • fast/forms/ios/accessory-bar-navigation.html:

r276598 updated this test so that the second input is positioned out of
the viewport on larger devices. However, the change (increasing the margin)
also lead to the first input being positioned out of the viewport on
smaller devices. Consequently, the test times out when run on an iPhone SE
as it is unable to tap on the first input.

To fix, the original margin for the first input is restored, ensuring it is
positioned within the viewport, and can be tapped. Then, a separate margin
is applied to the second input, ensuring it remains positioned outside the
viewport, and the test can verify accessory bar navigation with an
element outside the viewport.

  • platform/ios-wk2/TestExpectations:
4:04 PM Changeset in webkit [281523] by keith_miller@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Add for-in OwnStructureMode optimizations to LLInt
​https://bugs.webkit.org/show_bug.cgi?id=229038

Reviewed by Saam Barati.

This patch adds the optimizations we have for OwnStructureMode in
the Baseline to the LLInt. The patch also adds redundant self move
(i.e. move a, a) elimination to arm64. Finally, a bunch of the
property offset functions are now marked constexpr and return
intptr_t rather than size_t as the values can be negative.

There's also a minor fix to disable MSVC's signed to unsigned
cast warning for LLIntOffsetsExtractor as we don't care about
signedness for extracting constants.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileEnumeratorGetByVal):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_enumerator_get_by_val):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm64.rb:
  • offlineasm/generate_offset_extractor.rb:
  • runtime/Butterfly.h:

(JSC::Butterfly::indexOfPropertyStorage):

  • runtime/JSObject.h:

(JSC::offsetInButterfly):

  • runtime/PropertyOffset.h:

(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForMaxOffset):
(JSC::numberOfSlotsForMaxOffset):
(JSC::offsetForPropertyNumber):

3:58 PM Changeset in webkit [281522] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

REGRESSION (r281182?): 4 Media tests flakily timing out.
​https://bugs.webkit.org/show_bug.cgi?id=229474.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:13 PM Changeset in webkit [281521] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] media/modern-media-controls/seek-backward-support/seek-backward-support.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229473.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:03 PM Changeset in webkit [281520] by Chris Dumez
  • 20 edits
    4 adds in trunk

Geolocation API should callback with error if doc is not fully active
​https://bugs.webkit.org/show_bug.cgi?id=228319
<rdar://problem/81450315>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/geolocation-API/PositionOptions.https-expected.txt:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/geolocation-API/non-fully-active.https-expected.txt: Added.
  • web-platform-tests/geolocation-API/non-fully-active.https.html: Added.
  • web-platform-tests/geolocation-API/resources/iframe.html: Added.

Import test coverage from WPT ​https://github.com/web-platform-tests/wpt/pull/29799.

  • web-platform-tests/resources/testdriver-vendor.js:

(window.test_driver_internal.set_permission):
Add support for test_driver.set_permission("geolocation", "granted") so that Geolocation
WPT tests can run with our infrastructure.

Source/WebCore:

Test: imported/w3c/web-platform-tests/geolocation-API/non-fully-active.https.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
Schedule a task to call the error callback if the document is not fully active, as
per the specification:

  • bindings/js/JSDOMConvertCallbacks.h:

(WebCore::Converter<IDLCallbackFunction<T>>::convert):
(WebCore::Converter<IDLCallbackInterface<T>>::convert):
Make sure we use the incumbent global object when constructing callback functions /
interfaces, as per the Web IDL specification:

Without this, the geolocation API would be unable to call its error callback when in
a detached frame because the callback's global object would be the geolocation object's
global object.

  • dom/IdleCallbackController.cpp:

(WebCore::IdleCallbackController::invokeIdleCallbacks):
Make sure we don't fire requestIdleCallback callbacks in detached iframes, to maintain
pre-existing behavior and keep layout tests passing. I had to make this change because
callback interfaces / functions are now using a different global object and can now
get called in cases when they previously couldn't.

  • dom/TaskSource.h:

As Geolocation task source for the HTML5 event loop, as per the Geolocation
specification.

LayoutTests:

Update / rebaseline existing layout tests to reflect behavior change.

  • fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
  • fast/dom/Geolocation/callback-to-deleted-context.html:
  • fast/dom/Geolocation/disconnected-frame-already-expected.txt:
  • fast/dom/Geolocation/disconnected-frame-already.html:
  • fast/dom/Geolocation/disconnected-frame-expected.txt:
  • fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
  • fast/dom/Geolocation/disconnected-frame-permission-denied.html:
  • fast/dom/Geolocation/disconnected-frame.html:
  • fast/dom/Geolocation/resources/callback-to-deleted-context-inner1.html:
  • fast/events/detached-svg-parent-window-events-expected.txt:
  • fast/events/detached-svg-parent-window-events.html:
2:54 PM Changeset in webkit [281519] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug] webgl/1.0.3/conformance/glsl/constructors/glsl-construct-bvec2.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=229472.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:41 PM Changeset in webkit [281518] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

4 webgl/2.0.0/deqp/functional/gles3/ tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=228703.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:28 PM Changeset in webkit [281517] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=229101

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:11 PM Changeset in webkit [281516] by Chris Dumez
  • 40 edits
    2 adds in trunk

[WK2] Implement process-swapping based on Cross-Origin-Opener-Policy HTTP header
​https://bugs.webkit.org/show_bug.cgi?id=229203
<rdar://problem/82047686>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Minor test rebaseline due to logging changes.

  • web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https-expected.txt:

Source/WebCore:

We recently added support for the Cross-Origin-Opener-Policy (COOP) HTTP header. However,
when switching browsing context group on HTTP response, we would keep using the same
WebProcess. This patch makes it so that we now swap WebProcess when switching browsing
context group on network response as this will be required to securely re-enable Web APIs
such as SharedArrayBuffer.

For process-swapping, we reuse most of the same logic as process-swap on navigation (PSON).
A few differences are that:

  • We swap on response policy decision instead of navigation policy decision
  • We used to have a ShouldTreatAsContinuingLoad Yes/No enum. It is now tri-state: No, YesAfterNavigationPolicyDecision, YesAfterResponsePolicyDecision. We need this new state to avoid duplicate response policy delegate calls after process-swapping and to avoid sending duplicate didStartProvisionalLoad IPCs after proces-swapping.
  • After process-swapping on navigation response, we close the previous page instead of trying to put it into the back/forward cache. Per the specification, in a case of a browsing context group switch, the previous browsing context needs to be discarded (which is Web-observable).

One important thing to note is that we currently send the HTTP request to the server AGAIN after
a process-swap. This is because the on-going load currently gets cancelled upon receiving the
network response and deciding to process-swap and a new fresh load gets issued by the new
WebProcess after swapping. I will address this in a follow-up to decrease patch size and
complexity. We will need to transition the load in the network process from the old WebProcess
to the new one in case of process-swap.

Covered by existing COOP/COEP layout tests that are still passing and new API tests
that validate that we are indeed process-swapping.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::doCrossOriginOpenerHandlingOfResponse):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::clearMainResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::isContinuingLoadAfterResponsePolicyCheck const):
(WebCore::DocumentLoader::setIsContinuingLoadAfterResponsePolicyCheck):

  • loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):

  • loader/EmptyFrameLoaderClient.h:
  • loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::setShouldTreatAsContinuingLoad):
(WebCore::FrameLoadRequest::shouldTreatAsContinuingLoad const):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkContentPolicy):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.h:
  • loader/ShouldTreatAsContinuingLoad.h:
  • page/Page.h:

Source/WebKit:

We recently added support for the Cross-Origin-Opener-Policy (COOP) HTTP header. However,
when switching browsing context group on HTTP response, we would keep using the same
WebProcess. This patch makes it so that we now swap WebProcess when switching browsing
context group on network response as this will be required to securely re-enable Web APIs
such as SharedArrayBuffer.

For process-swapping, we reuse most of the same logic as process-swap on navigation (PSON).
A few differences are that:

  • We swap on response policy decision instead of navigation policy decision
  • We used to have a ShouldTreatAsContinuingLoad Yes/No enum. It is now tri-state: No, YesAfterNavigationPolicyDecision, YesAfterResponsePolicyDecision. We need this new state to avoid duplicate response policy delegate calls after process-swapping and to avoid sending duplicate didStartProvisionalLoad IPCs after proces-swapping.
  • After process-swapping on navigation response, we close the previous page instead of trying to put it into the back/forward cache. Per the specification, in a case of a browsing context group switch, the previous browsing context needs to be discarded (which is Web-observable).

One important thing to note is that we currently send the HTTP request to the server AGAIN after
a process-swap. This is because the on-going load currently gets cancelled upon receiving the
network response and deciding to process-swap and a new fresh load gets issued by the new
WebProcess after swapping. I will address this in a follow-up to decrease patch size and
complexity. We will need to transition the load in the network process from the old WebProcess
to the new one in case of process-swap.

  • Shared/LoadParameters.h:
  • UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::loadData):
(WebKit::ProvisionalPageProxy::loadRequest):
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::decidePolicyForResponse):

  • UIProcess/ProvisionalPageProxy.h:

(WebKit::ProvisionalPageProxy::shouldClosePreviousPageAfterCommit const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::loadSimulatedRequest):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseShared):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::optionalRegistrableDomain const):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataImpl):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add API test coverage to validate that we are indeed process-swapping.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONScheme addMappingFromURLString:toData:withCOOPValue:]):
(-[PSONScheme webView:startURLSchemeTask:]):

LayoutTests:

Skip COOP tests on WK1 as we only have a working implementation for WK2.

  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
2:04 PM Changeset in webkit [281515] by Jonathan Bedard
  • 2 edits in trunk/Tools

[kill-old-processes] Hardcode directory for stale simulator files
​https://bugs.webkit.org/show_bug.cgi?id=229464
<rdar://problem/82148711>

Reviewed by Stephanie Lewis.

  • CISupport/kill-old-processes:

(main):

1:36 PM Changeset in webkit [281514] by Antti Koivisto
  • 2 edits
    2 adds in trunk/LayoutTests/imported/w3c

[CSS Cascade Layers] Import basic tests
​https://bugs.webkit.org/show_bug.cgi?id=229441

Reviewed by Tim Horton.

  • web-platform-tests/css/css-cascade/layer-basic-expected.txt: Added.
  • web-platform-tests/css/css-cascade/layer-basic.html: Added.
  • web-platform-tests/css/css-cascade/w3c-import.log:
12:28 PM Changeset in webkit [281513] by ysuzuki@apple.com
  • 13 edits
    1 add in trunk

[JSC] Add Intl Enumeration APIs
​https://bugs.webkit.org/show_bug.cgi?id=214795

Reviewed by Ross Kirsling.

JSTests:

  • stress/intl-datetimeformat.js:
  • stress/intl-enumeration.js: Added.

(shouldBe):
(shouldThrow):

  • stress/intl-locale-info.js:

(let.l.new.Intl.Locale.shouldBe):
(shouldBe):

Source/JavaScriptCore:

This patch implements Intl enumeration API[1] which is in stage-3.
Supported keys are, "calendar", "collation", "currency", "numberingSystem", "timeZone", and "unit".

[1]: ​https://github.com/tc39/proposal-intl-enumeration

  • runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::localeData):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

  • runtime/IntlLocale.cpp:

(JSC::createArrayFromStringVector): Deleted.

  • runtime/IntlNumberFormat.cpp:

(JSC::sanctionedSimpleUnitIdentifier):

  • runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation):
(JSC::mapICUCalendarKeywordToBCP47):
(JSC::availableCalendars):
(JSC::availableCollations):
(JSC::availableCurrencies):
(JSC::availableNumberingSystems):
(JSC::canonicalizeTimeZoneNameFromICUTimeZone):
(JSC::availableTimeZones):
(JSC::availableUnits):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::createArrayFromStringVector):

  • runtime/IntlObject.h:
  • runtime/OptionsList.h:

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):

  • wtf/text/StringImpl.h:
12:15 PM Changeset in webkit [281512] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

Unprefix -webkit-backface-visibility
​https://bugs.webkit.org/show_bug.cgi?id=170983

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-24
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • web-platform-tests/css/css-transforms/css-transform-property-existence-expected.txt: Added.
  • web-platform-tests/css/css-transforms/css-transform-property-existence.html: Added.
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-computed-expected.txt:
  • web-platform-tests/css/css-transforms/parsing/backface-visibility-valid-expected.txt:
  • web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

This has already been done by Chrome and Firefox.
Keep the prefixed version as an alias.

Test: imported/w3c/web-platform-tests/css/css-transforms/css-transform-property-existence.html

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSProperties.json:
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

LayoutTests:

  • platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
  • platform/ios/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
12:11 PM Changeset in webkit [281511] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Crash in [RBSTarget targetWithPid:] during WebProcessProxy::shutDown
​https://bugs.webkit.org/show_bug.cgi?id=229444

Reviewed by Alex Christensen.

It appears xpc_connection_get_pid() may be able to return a PID that is less than 0
(likely when the process has just exited) and this causes RunningBoard to throw an
exception because the PID is invalid. Tweak the WebKit PID validation to use '>= 0'
instead of simply '!= 0', so that our validation is identical to the one used by
RunningBoard.

  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::ProcessAssertion):

12:08 PM Changeset in webkit [281510] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

CONSOLE ASSERT ERROR:[BigSur] http/tests/inspector/network/resource-mime-type.html is a flaky failure on wk2 and flaky timeout on wk1.
​https://bugs.webkit.org/show_bug.cgi?id=229463.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:01 PM Changeset in webkit [281509] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ Catalina EWS ] media/track/track-disabled-addcue.html is flaky crashing.
​https://bugs.webkit.org/show_bug.cgi?id=229462

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
11:53 AM Changeset in webkit [281508] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug x86] http/tests/inspector/network/ping-type.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229460.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:48 AM Changeset in webkit [281507] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

[ EWS Catalina ] http/tests/websocket/tests/hybi/inspector/send-and-recieve-debugger.html is flaky timing out / failing.
​https://bugs.webkit.org/show_bug.cgi?id=229459

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:41 AM Changeset in webkit [281506] by Lauro Moura
  • 2 edits
    1 add in trunk/LayoutTests

[WPE] Gardening two WebXR-related failures

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
  • platform/wpe/http/wpt/webxr/xrViewport_singleView_valid.https-expected.txt: Added.
11:32 AM Changeset in webkit [281505] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Remove inefficient use of HashMap from FormController along with a bit of other streamlining and modernizing
​https://bugs.webkit.org/show_bug.cgi?id=228854

Reviewed by Chris Dumez.

  • html/FormController.cpp:

(WebCore::ownerForm): Renamed from ownerFormForState. Removed unnecessary use of
inline; trust the compiler to inline if needed without the keyword. Removed
"using namespace HTMLNames". Use nullptr instead of 0.
(WebCore::StringVectorReader::consumeString): Added. Helps parse a vector without
so many index range checks. Returns null string at end of vector.
(WebCore::StringVectorReader::consumeSubvector): Added. Helps parse a vector
without so many index range checks. Returns the subvector.
(WebCore::appendSerializedFormControlState): Renamed from
serializeFormControlStateTo to make clear this appends to an existing vector.
(WebCore::consumeSerializedFormControlState): Renamed from
deserializeFormControlState to make clear this reads part of a vector and
indicates what was read. Use the StringVectorReader class for the argument type
to make that clear. Refactored to use the new consumeString and consumeSubvector
functions. Also use parseInteger because there is no need to allow trailing junk.
(WebCore::FormElementKey): Deleted this entire class, kind of a lot of code,
because we can instead use std::pair and only lose a little bit of clarity.
(WebCore::FormController::SavedFormState): Made this class a member of
FormController. Also use std::pair, renamed m_stateForNewFormElements to m_map,
and removed m_controlStateCount. The only code that was using this was
in SavedFormState::serializeTo, and that in turn was only used on a
SavedFormState which contained
(WebCore::SavedFormState::serializeTo const): Deleted. All the logic from this
function is now in the FormController::formElementsState function, which is
the only place it was used.
(WebCore::FormController::SavedFormState::consumeSerializedState): Renamed
from deserialize to make it clear that it reads part of a vector and indicates
what is read. Use the StringVectorReader class for the argument type to make
that clear. Moved the isNotFormControlTypeCharacter from a separate function
to be a lambda inside this function. Use consumeString, StringView::contains,
and consumeSerializedFormControlState to streamline the implementation.
Moved call to HashMap::add here instead of separate appendControlState
function since we no longer need to track m_controlStateCount.
(WebCore::SavedFormState::appendControlState): Deleted.
(WebCore::FormController::SavedFormState::takeControlState): Take the arguments
as a FormElementKey, already in a pair, instead of as two separate values.
Removed the code to maintain m_controlStateCount.
(WebCore::FormController::SavedFormState::appendReferencedFilePaths const):
Renamed from referencedFilePaths and change this to append to an existing
vector, since that's what the only caller was doing.
(WebCore::FormController::FormKeyGenerator): Made this class a member of
FormController. Also changed to just use String for the formKey, since there
is no significant sharing or other optimization made possible by using
AtomString. Also use a reference instead of a pointer in one place.
(WebCore::recordFormStructure): Deleted.
(WebCore::formSignature): Merge in the logic from the recordFormStructure
function, since that was an awkward function name and this is clearer as
just one function. Added a comment about fragment identifiers. Use unsigned
instead of size_t to count up to 2. Improved the comment about why the
maximum is 2 and used simpler loop logic, is<> instead of a specific
function call, downcast<> instead of static_cast<>, and Ref instead of RefPtr<...>.
(WebCore::FormController::FormKeyGenerator::formKey): Use RefPtr on the
left side instead of makeRefPtr. Use String instead of AtomString.
(WebCore::FormController::FormKeyGenerator::willDeleteForm): Take a reference.
(WebCore::formStateSignature): Use MainThreadNeverDestroyed.
(WebCore::FormController::createSavedFormStateMap): Deleted. This was only
ever used by formElementsState, which does not need a map.
(WebCore::FormController::formElementsState const): Use a vector that
uses Ref<> since it's a little safer for object lifetime and that also stores
the form key so we can grouop controls in the same form as part of sorting.
Added an early return when there are no controls instead of
detecting that at the end of the function. Moved the code from
createSavedFormStateMap and SavedFormState::serializeTo in here to avoid
creating a HashMap just to iterate it and build a string vector, using
sorting to group and count the controls in each form. Use shrinkToFit to make
sure the vector is not permanently overallocated instead of an always-too-small
reserveInitialCapacity.
(WebCore::FormController::setStateForNewFormElements): Update for the change in
parseStateVector.
(WebCore::FormController::takeStateForFormElement): Updated for the change to
m_savedFormStateMap values. Use auto a bit and "iterator" insted of "it".
(WebCore::FormController::parseStateVector): Renamed from
formStatesFromStateVector and changed to use a return value instead of an out
argument. Use StringVectorReader and consumeString to streamline the code and
make it a bit more foolproof. Check the exhaustion of the input vector inside
the loop instead of checking for an error after the loop.
(WebCore::FormController::willDeleteForm): Pass a reference.

(WebCore::FormController::restoreControlStateFor): Tweak comment and use

instead of two separate if statements.
(WebCore::FormController::restoreControlStateIn): Ditto.
(WebCore::FormController::referencedFilePaths): Use parseStateVector and
appendReferencedFilePaths.

  • html/FormController.h: Removed almost all the includes, which were not needed.

Made the FormKeyGenerator and SavedFormState classes members of FormController.
Changed SavedFormStateMap to use String as the key instead of RefPtr<AtomStringImpl>,
no need for the exotic type. Changed SavedFormStateMap to use SavedFormState
as the value instead of std::unique_ptr<SavedFormState>. Removed the unused
member function createSavedFormStateMap and renamed formStatesFromStateVector
to parseStateVector and changed it to use a return value.

11:31 AM Changeset in webkit [281504] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[Mac] http/tests/inspector/network/har/har-page.html, flaky failure on wk2, constant failure on wk1.
​https://bugs.webkit.org/show_bug.cgi?id=229458.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:30 AM Changeset in webkit [281503] by jer.noble@apple.com
  • 13 edits
    6 adds in trunk

Source/WebCore:
Add support for new pseudo-classes for media from CSS Selectors Level 4.
​https://bugs.webkit.org/show_bug.cgi?id=229431

Reviewed by Eric Carlson.

Tests: media/media-css-muted.html

media/media-css-playing-paused.html
media/media-css-volume-locked.html
(Tests for buffering and stalled states are forthcoming, waiting on
a non-flakey mechanism for inducing network stalls)

Add support for the following new pseudo-classes from CSS Selectors Level 4:

  • :playing, :paused, :seeking
  • :buffering, :stalled
  • :muted, :volume-locked

Ensure CSS styles are invalidated when playback state changes by encapsulating
modifications to HTMLMediaElement::m_paused into a setPaused() function.

Add methods to query for volumeLocked() on HTMLMediaElement, as well as a way
to override the value through Internals.

Invalidate styles when the "muted" attribute changes state.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesPlayingPseudoClass):
(WebCore::matchesPausedPseudoClass):
(WebCore::matchesSeekingPseudoClass):
(WebCore::matchesBufferingPseudoClass):
(WebCore::matchesStalledPseudoClass):
(WebCore::matchesMutedPseudoClass):
(WebCore::matchesVolumeLockedPseudoClass):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):

  • html/HTMLMediaElement.cpp:

(WebCore::defaultVolumeLocked):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::setPaused):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::setVolumeLocked):
(WebCore::HTMLMediaElement::buffering const):
(WebCore::HTMLMediaElement::stalled const):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::volumeLocked const):

  • testing/Internals.cpp:

(WebCore::Internals::setMediaElementVolumeLocked):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:
Add support for new pseudo-selectors for media from CSS Selectors Level 4.
​https://bugs.webkit.org/show_bug.cgi?id=229431

Reviewed by Eric Carlson.

  • media/media-css-muted-expected.txt: Added.
  • media/media-css-muted.html: Added.
  • media/media-css-playing-paused-expected.txt: Added.
  • media/media-css-playing-paused.html: Added.
  • media/media-css-volume-locked-expected.txt: Added.
  • media/media-css-volume-locked.html: Added.
11:28 AM commit-identifiers edited by Jonathan Bedard
Migrated commit-identifier documentation to … (diff)
11:18 AM Changeset in webkit [281502] by Chris Dumez
  • 3 edits
    11 adds in trunk

Fire a load event for <iframe src="about:blank#foo">
​https://bugs.webkit.org/show_bug.cgi?id=228958
<rdar://problem/82035810>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import layout test coverage from WPT.

  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/initial-content-replacement-expected.txt: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/initial-content-replacement.html: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-event-iframe-element-expected.txt: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-event-iframe-element.html: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow-expected.txt: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open-expected.txt: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html: Added.
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/resources/helpers.js: Added.

(assertNoLoadAndPageshowEvent):

Source/WebCore:

When loading an iframe with src="about:blank#foo", we would fail to fire the load event because we would treat
the navigation as a fragment navigation. The reason for that is that the iframe is initially displaying the
initial empty document, which has URL "about:blank". Because the source and destination URL would be the same
when ignoring fragments, our logic would treat this as a pure fragment navigation. To address this, I have
updated FrameLoader::shouldPerformFragmentNavigation() to special case the initial empty document.

Test: imported/w3c/web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-event-iframe-element.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldPerformFragmentNavigation):

11:00 AM Changeset in webkit [281501] by Eric Hutchison
  • 2 edits in trunk/LayoutTests

[BigSur wk2 Debug x86] http/tests/inspector/network/resource-timing.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=229454.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:58 AM Changeset in webkit [281500] by keith_miller@apple.com
  • 3 edits
    1 move in trunk

(r281473) stress/for-in-has-own-property-shouldnt-flush-registers.js failing on Debug
​https://bugs.webkit.org/show_bug.cgi?id=229448

Reviewed by Mark Lam.

JSTests:

Fix typo in test name.

  • stress/for-in-in-by-val-should-flush-registers.js: Renamed from JSTests/stress/for-in-in-by-val-shouldnt-flush-registers.js.

Source/JavaScriptCore:

Add missing exception checks.

  • dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

10:57 AM Changeset in webkit [281499] by Ayumi Kojima
  • 2 edits in trunk/LayoutTests

Removing test expectations for fixed bug [ Win EWS ] fast/forms/* tests are flaky crashing FAULTING_IP: WebKit!WebCore::FontCache::lastResortFallbackFont+ec [C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebCore\platform\graphics\win\FontCacheWin.cpp @ 424].
​https://bugs.webkit.org/show_bug.cgi?id=229009

Unreviewed test gardening.

  • platform/win/TestExpectations:
10:47 AM Changeset in webkit [281498] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION (r281473): [ iOS & MacOS ] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is timing out
​https://bugs.webkit.org/show_bug.cgi?id=229447

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-24
Reviewed by Chris Dumez.

Check that a JS error was thrown instead of checking that the navigation doesn't go through.

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
10:41 AM Changeset in webkit [281497] by commit-queue@webkit.org
  • 11 edits
    4 copies
    1 move
    2 adds in trunk/LayoutTests

[GLIB] Update baselines after r281422
​https://bugs.webkit.org/show_bug.cgi?id=229450

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-08-24

  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/fast/selectors/018b-expected.txt: Copied from LayoutTests/platform/glib/fast/selectors/018b-expected.txt.
  • platform/gtk/fast/text/capitalize-boundaries-expected.txt:
  • platform/gtk/fast/text/whitespace/020-expected.txt:
  • platform/wpe/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/wpe/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/gtk/editing/selection/3690703-2-expected.txt.
  • platform/wpe/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/gtk/editing/selection/3690703-expected.txt.
  • platform/wpe/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/gtk/editing/selection/3690719-expected.txt.
  • platform/wpe/fast/selectors/018b-expected.txt: Renamed from LayoutTests/platform/glib/fast/selectors/018b-expected.txt.
  • platform/wpe/fast/text/capitalize-boundaries-expected.txt:
  • platform/wpe/fast/text/whitespace/020-expected.txt:
9:57 AM Changeset in webkit [281496] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r281321.
​https://bugs.webkit.org/show_bug.cgi?id=229449

causes crashes on ARM64

Reverted changeset:

"Add some offlineasm enhancements."
​https://bugs.webkit.org/show_bug.cgi?id=229332
​https://commits.webkit.org/r281321

9:29 AM Changeset in webkit [281495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ThreadSanitizer: data race in WTF::StringImpl::deref() for WebCore::FormDataElement::EncodedFileData::filename
​https://bugs.webkit.org/show_bug.cgi?id=229432

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-08-24
Reviewed by Darin Adler.

Call the FormDataElement destructor on the main thread in advanceCurrentStream.

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):
(WebCore::createHTTPBodyCFReadStream):

8:05 AM Changeset in webkit [281494] by Russell Epstein
  • 8 edits in branches/safari-612.1.27.0-branch/Source

Versioning.

WebKit-7612.1.27.0.31

6:48 AM Changeset in webkit [281493] by Adrian Perez de Castro
  • 8 edits in trunk/Source

Non-unified build fixes, late August 2021
​https://bugs.webkit.org/show_bug.cgi?id=229440

Unreviewed non-unified build fixes.

Source/WebCore:

  • Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp: Add missing

LibWebRTCProvider.h and JavaScriptCore/ArrayBuffer.h headers.

  • fileapi/ThreadableBlobRegistry.cpp: Add missing PolicyContainer.h header.
  • layout/formattingContexts/inline/InlineFormattingGeometry.cpp: Add missing FontCascade.h

header.

  • layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp: Add missing

FontCascade.h, InlineFormattingContext.h, and LayoutBoxGeometry.h headers.

Source/WebKit:

  • NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: Add missing

wtf/SuspendableWorkQueue.h header.

  • NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: Ditto.
5:57 AM Changeset in webkit [281492] by ntim@apple.com
  • 6 edits in trunk

Move cancel dialog task to defaultKeyboardEventHandler.
​https://bugs.webkit.org/show_bug.cgi?id=228845

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Updated test expectations.

  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault-expected.txt:

Source/WebCore:

Test: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault.html

Allows preventDefault() on keydown event to prevent cancelation.

Also rename HTMLDialogElement::cancel to HTMLDialogElement::queueCancelTask to reflect better what the function does.

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::queueCancelTask):
(WebCore::HTMLDialogElement::cancel): Deleted.

  • html/HTMLDialogElement.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::internalKeyEvent):
(WebCore::EventHandler::defaultKeyboardEventHandler):

3:07 AM Changeset in webkit [281491] by commit-queue@webkit.org
  • 5 edits in trunk

REGRESSION(r281305) [GStreamer] fast/mediastream/getDisplayMedia-frame-rate.html timeouts
​https://bugs.webkit.org/show_bug.cgi?id=229343

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-08-24
Reviewed by Youenn Fablet.

Source/WebCore:

Proxy the video samples from the wrapped mock source to its parent. The test was timing out
because the video samples were never notified to the top level observer in Internals.

  • platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:

(WebCore::MockDisplayCaptureSourceGStreamer::MockDisplayCaptureSourceGStreamer):
(WebCore::MockDisplayCaptureSourceGStreamer::requestToEnd):
(WebCore::MockDisplayCaptureSourceGStreamer::videoSampleAvailable):

  • platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:

LayoutTests:

  • platform/glib/TestExpectations: Test is now passing, in Release at least. Timing out in

Debug but that will be investigated next, there are other mediastream timeouts in Debug.

1:17 AM Changeset in webkit [281490] by ntim@apple.com
  • 11 edits
    29 adds in trunk

Implement inert attribute behind feature flag
​https://bugs.webkit.org/show_bug.cgi?id=165279

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Import inert/ WPT directory using import-w3c-tests -t web-platform-tests/inert.
WPT revision: ​https://github.com/web-platform-tests/wpt/commit/f02e38d7a67999683d05579f62b339430c61e4ec

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/inert/frame/button.html: Added.
  • web-platform-tests/inert/frame/w3c-import.log: Added.
  • web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative.html: Added.
  • web-platform-tests/inert/inert-in-shadow-dom.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-in-shadow-dom.tentative.html: Added.
  • web-platform-tests/inert/inert-inlines.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-inlines.tentative.html: Added.
  • web-platform-tests/inert/inert-label-focus.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-label-focus.tentative.html: Added.
  • web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-node-is-uneditable.tentative.html: Added.
  • web-platform-tests/inert/inert-node-is-unfocusable.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-node-is-unfocusable.tentative.html: Added.
  • web-platform-tests/inert/inert-node-is-unselectable.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-node-is-unselectable.tentative.html: Added.
  • web-platform-tests/inert/inert-on-slots.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-on-slots.tentative.html: Added.
  • web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-retargeting-iframe.tentative.html: Added.
  • web-platform-tests/inert/inert-retargeting.tentative-expected.txt: Added.
  • web-platform-tests/inert/inert-retargeting.tentative.html: Added.
  • web-platform-tests/inert/w3c-import.log: Added.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/inert/frame/button.html

imported/w3c/web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative.html
imported/w3c/web-platform-tests/inert/inert-in-shadow-dom.tentative.html
imported/w3c/web-platform-tests/inert/inert-inlines.tentative.html
imported/w3c/web-platform-tests/inert/inert-label-focus.tentative.html
imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative.html
imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.tentative.html
imported/w3c/web-platform-tests/inert/inert-node-is-unselectable.tentative.html
imported/w3c/web-platform-tests/inert/inert-on-slots.tentative.html
imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative.html
imported/w3c/web-platform-tests/inert/inert-retargeting.tentative.html

  • dom/Node.cpp:

(WebCore::Node::isInert const):

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.idl:

Source/WTF:

Add runtime InertAttributeEnabled feature flag disabled by default.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

Create iOS baselines.

  • platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-retargeting.tentative-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.