Timeline
Oct 4, 2021:
- 11:45 PM Changeset in webkit [283538] by
-
- 2 edits in trunk/LayoutTests
Update ios-wk2 test expectations for select-validity.html WPT
https://bugs.webkit.org/show_bug.cgi?id=231217
Unreviewed test gardening.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-validity-expected.txt:
- 10:10 PM Changeset in webkit [283537] by
-
- 14 edits in trunk
Stop parsing context-sensitive colors in override-color
https://bugs.webkit.org/show_bug.cgi?id=231052
<rdar://problem/83746258>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
These are being upstreamed in https://github.com/web-platform-tests/wpt/pull/31078.
- web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
- web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
- web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt:
- web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
Source/WebCore:
The spec has split the <color> production into two halves:
absolute colors and non-absolute colors. This patch adds a new
enum argument to consumeColor() to distinguish which production
you want.
Tests: imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html
imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
- css/StyleColor.cpp:
(WebCore::StyleColor::colorFromKeyword):
(WebCore::isVGAPaletteColor):
(WebCore::isNonVGANamedColor):
(WebCore::StyleColor::isAbsoluteColorKeyword):
(WebCore::StyleColor::isSystemColorKeyword):
(WebCore::StyleColor::isColorKeyword):
(WebCore::StyleColor::isSystemColor): Deleted.
- css/StyleColor.h:
(WebCore::StyleColor::isColorKeyword):
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSystemColor):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeOverrideColorsDescriptor):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeOriginColor):
(WebCore::CSSPropertyParserHelpers::consumeColorWorkerSafe):
(WebCore::CSSPropertyParserHelpers::consumeColor):
- css/parser/CSSPropertyParserHelpers.h:
(WebCore::CSSPropertyParserHelpers::consumeColor):
- platform/ColorData.gperf:
- testing/Internals.cpp:
(WebCore::Internals::systemColorForCSSValue):
- 8:52 PM Changeset in webkit [283536] by
-
- 13 edits in trunk
Remove the "none" value from font-palette
https://bugs.webkit.org/show_bug.cgi?id=231050
<rdar://problem/83745650>
Reviewed by Wenson Hsieh.
LayoutTests/imported/w3c:
This is being upstreamed at https://github.com/web-platform-tests/wpt/pull/31077.
- web-platform-tests/css/css-fonts/parsing/font-palette-invalid.html:
- web-platform-tests/css/css-fonts/parsing/font-palette-valid.html:
Source/WebCore:
The spec changed in
https://github.com/w3c/csswg-drafts/commit/b7103b0269cde51914af02f5ca1e5582d44e7b70.
Luckily, we never implemented this anyway, so this is just a parsing change.
Tests: imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-invalid.html
imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-valid.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontPaletteFromStyle):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontPalette):
- platform/graphics/FontPalette.h:
(WebCore::operator<<):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::addAttributesForFontPalettes):
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontPalette):
- 8:39 PM Changeset in webkit [283535] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Disable simplified text measuring codepath when first style line has related unique values
https://bugs.webkit.org/show_bug.cgi?id=231177
Reviewed by Antti Koivisto.
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::inlineItemWidth const):
- layout/integration/LayoutIntegrationBoxTree.cpp:
- rendering/RenderText.cpp:
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):
- 8:37 PM Changeset in webkit [283534] by
-
- 91 edits2 moves in trunk/LayoutTests/imported/w3c
Test gardening for font-palette WPT tests
https://bugs.webkit.org/show_bug.cgi?id=231208
Unreviewed.
Update the WPT tests according to
https://github.com/web-platform-tests/wpt/pull/31044.
- web-platform-tests/css/css-fonts/animations/font-palette-animation-2-expected.html:
- web-platform-tests/css/css-fonts/animations/font-palette-animation-2.html:
- web-platform-tests/css/css-fonts/animations/font-palette-animation-3-expected-mismatch.html:
- web-platform-tests/css/css-fonts/animations/font-palette-animation-3.html:
- web-platform-tests/css/css-fonts/animations/font-palette-animation-expected.html:
- web-platform-tests/css/css-fonts/animations/font-palette-animation.html:
- web-platform-tests/css/css-fonts/font-palette-10-expected.html:
- web-platform-tests/css/css-fonts/font-palette-10.html:
- web-platform-tests/css/css-fonts/font-palette-11-expected.html:
- web-platform-tests/css/css-fonts/font-palette-11.html:
- web-platform-tests/css/css-fonts/font-palette-12-expected.html:
- web-platform-tests/css/css-fonts/font-palette-12.html:
- web-platform-tests/css/css-fonts/font-palette-13-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-13.html:
- web-platform-tests/css/css-fonts/font-palette-14-expected.html:
- web-platform-tests/css/css-fonts/font-palette-14.html:
- web-platform-tests/css/css-fonts/font-palette-15-expected.html:
- web-platform-tests/css/css-fonts/font-palette-15.html:
- web-platform-tests/css/css-fonts/font-palette-16-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-16.html:
- web-platform-tests/css/css-fonts/font-palette-17-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-17.html:
- web-platform-tests/css/css-fonts/font-palette-18-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-18.html:
- web-platform-tests/css/css-fonts/font-palette-19-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-19.html:
- web-platform-tests/css/css-fonts/font-palette-2-expected.html:
- web-platform-tests/css/css-fonts/font-palette-2.html:
- web-platform-tests/css/css-fonts/font-palette-20-expected.html:
- web-platform-tests/css/css-fonts/font-palette-20.html:
- web-platform-tests/css/css-fonts/font-palette-21-expected.html:
- web-platform-tests/css/css-fonts/font-palette-21.html:
- web-platform-tests/css/css-fonts/font-palette-22-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-22.html:
- web-platform-tests/css/css-fonts/font-palette-23-expected.html:
- web-platform-tests/css/css-fonts/font-palette-23.html:
- web-platform-tests/css/css-fonts/font-palette-24-expected.html:
- web-platform-tests/css/css-fonts/font-palette-24.html:
- web-platform-tests/css/css-fonts/font-palette-25-expected.html:
- web-platform-tests/css/css-fonts/font-palette-25.html:
- web-platform-tests/css/css-fonts/font-palette-26-expected.html:
- web-platform-tests/css/css-fonts/font-palette-26.html:
- web-platform-tests/css/css-fonts/font-palette-27-expected.html:
- web-platform-tests/css/css-fonts/font-palette-27.html:
- web-platform-tests/css/css-fonts/font-palette-28-expected.html:
- web-platform-tests/css/css-fonts/font-palette-28.html:
- web-platform-tests/css/css-fonts/font-palette-29-expected.html:
- web-platform-tests/css/css-fonts/font-palette-29.html:
- web-platform-tests/css/css-fonts/font-palette-3-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-3.html:
- web-platform-tests/css/css-fonts/font-palette-30-expected.html:
- web-platform-tests/css/css-fonts/font-palette-30.html:
- web-platform-tests/css/css-fonts/font-palette-31-expected.html:
- web-platform-tests/css/css-fonts/font-palette-31.html:
- web-platform-tests/css/css-fonts/font-palette-4-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-4.html:
- web-platform-tests/css/css-fonts/font-palette-5-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-5.html:
- web-platform-tests/css/css-fonts/font-palette-6-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-6.html:
- web-platform-tests/css/css-fonts/font-palette-7-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-7.html:
- web-platform-tests/css/css-fonts/font-palette-8-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-8.html:
- web-platform-tests/css/css-fonts/font-palette-9-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-9.html:
- web-platform-tests/css/css-fonts/font-palette-add-2-expected.html:
- web-platform-tests/css/css-fonts/font-palette-add-2.html:
- web-platform-tests/css/css-fonts/font-palette-add-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-add.html:
- web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-empty-font-family.html:
- web-platform-tests/css/css-fonts/font-palette-expected.html:
- web-platform-tests/css/css-fonts/font-palette-modify-2-expected.html:
- web-platform-tests/css/css-fonts/font-palette-modify-2.html:
- web-platform-tests/css/css-fonts/font-palette-modify-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-modify.html:
- web-platform-tests/css/css-fonts/font-palette-remove-2-expected.html:
- web-platform-tests/css/css-fonts/font-palette-remove-2.html:
- web-platform-tests/css/css-fonts/font-palette-remove-expected-mismatch.html:
- web-platform-tests/css/css-fonts/font-palette-remove.html:
- web-platform-tests/css/css-fonts/font-palette.html:
- web-platform-tests/css/css-fonts/palette-values-rule-add-2-expected.html:
- web-platform-tests/css/css-fonts/palette-values-rule-add-2.html:
- web-platform-tests/css/css-fonts/palette-values-rule-add-expected-mismatch.html:
- web-platform-tests/css/css-fonts/palette-values-rule-add.html:
- web-platform-tests/css/css-fonts/palette-values-rule-delete-2-expected.html:
- web-platform-tests/css/css-fonts/palette-values-rule-delete-2.html:
- web-platform-tests/css/css-fonts/palette-values-rule-delete-expected-mismatch.html:
- web-platform-tests/css/css-fonts/palette-values-rule-delete.html:
- web-platform-tests/css/css-fonts/resources/COLR-palettes-test-font-no-light-dark.ttf: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/Ahem-COLR-palettes-no-light-dark.ttf.
- web-platform-tests/css/css-fonts/resources/COLR-palettes-test-font.ttf: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/resources/Ahem-COLR-palettes.ttf.
- 7:52 PM Changeset in webkit [283533] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] Hyphenation should not be applied with 'word-break: break-all'
https://bugs.webkit.org/show_bug.cgi?id=231189
Reviewed by Antti Koivisto.
"break-all: Breaking is allowed within “words”: specifically...Hyphenation is not applied."
https://drafts.csswg.org/css-text-3/#word-break-property.
- layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):
- 7:34 PM Changeset in webkit [283532] by
-
- 1 copy in tags/Safari-613.1.3.1
Tag Safari-613.1.3.1.
- 7:32 PM Changeset in webkit [283531] by
-
- 19 edits2 moves4 adds in trunk
Choose an appropriate color space when converting an SVG image into a NativeImage for canvas drawImage
https://bugs.webkit.org/show_bug.cgi?id=231062
<rdar://problem/83752451>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Add a test for drawImage() with an SVG image that has sRGB and Display
P3 colors.
Not adding tests for patterns pointing to SVG images for now, since
WebKit currently always taints the canvas in that case, or for
ImageBitmaps wrapping SVG images, since we always flatten them to sRGB
(and we don't track what content is inside the SVG to make a better
decision about what color space ImageBuffer to use).
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage.https-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-expected.txt.
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage.https.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage.html.
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3.js:
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/resources/Display-P3-0.7333-0-0.svg: Added.
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/resources/Display-P3-1-0-0.svg: Added.
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/resources/sRGB-BB0000.svg: Added.
- web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/resources/sRGB-FF0000.svg: Added.
Source/WebCore:
When GPUP canvas is enabled, drawImage() with an SVG image is handled
by drawing into a NativeImage and then sending that to the GPUP. We
need to choose a color space for the NativeImage's ImageBuffer that
matches the canvas.
Once full SVG rendering is supported by the GPU process, we can undo
this code, as we'll no longer be using a NativeImage.
Test: imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage.https.html
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2DBase::fullCanvasCompositedDrawImage):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImageForCanvas):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.cpp:
(WebCore::Image::drawForCanvas):
- platform/graphics/Image.h:
- platform/graphics/MediaPlayer.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawForCanvasForContainer):
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::drawForContainerInternal):
(WebCore::SVGImage::nativeImage):
(WebCore::SVGImage::drawForCanvas):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::drawInternal):
(WebCore::SVGImage::drawAsNativeImage):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawForCanvas):
- svg/graphics/SVGImageForContainer.h:
LayoutTests:
- TestExpectations:
- platform/ios-14/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 7:32 PM Changeset in webkit [283530] by
-
- 8 edits in branches/safari-613.1.3-branch/Source
Versioning.
WebKit-7613.1.3.1
- 6:22 PM Changeset in webkit [283529] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for canvas color space tests in simulator
https://bugs.webkit.org/show_bug.cgi?id=231204
<rdar://problem/83865405>
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:52 PM Changeset in webkit [283528] by
-
- 2 edits in trunk/Tools
[ews-build.webkit.org] check-patch-relevance can get stuck
https://bugs.webkit.org/show_bug.cgi?id=231190
<rdar://problem/77327168>
Reviewed by Alexey Proskuryakov.
- CISupport/ews-build/steps.py:
(CheckPatchRelevance): Compute all regexes in advance.
(CheckPatchRelevance._patch_is_relevant): Rely on pre-computed regexes,
limit the number of characters to check in a line to 250 and include a
hard-timeout so that a patch can never get EWS stuck.
- 5:33 PM Changeset in webkit [283527] by
-
- 4 edits in trunk/Source/JavaScriptCore
Display return values in nicer way in the jsc REPL and add a prettyPrint function
https://bugs.webkit.org/show_bug.cgi?id=230931
<rdar://problem/83698777>
Reviewed by Tadeu Zagallo.
Currently, print(1), print("1"), and print([1]) all print to stdout
simply as "1" (without the quotes). Same for values when running the
REPL. This isn't super helpful. Let's print quotes for strings, and
brackets for arrays. This patch adds a prettyPrint function to do
that, since we have a lot of tests that depend on the old print behavior.
This patch also makes values printed in the REPL the new pretty style.
- jsc.cpp:
(toCString):
(printInternal):
(JSC_DEFINE_HOST_FUNCTION):
(runInteractive):
(cStringFromViewWithString): Deleted.
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toWTFStringForConsole const):
- runtime/JSCJSValue.h:
- 4:50 PM Changeset in webkit [283526] by
-
- 10 edits in trunk/Source/WebCore
[Build-time perf] Forward-declare more things in ScriptExecutionContext.h
https://bugs.webkit.org/show_bug.cgi?id=231182
Reviewed by Tim Horton.
Forward declare, rather than include, more classes and enums in ScriptExecutionContext.h.
Any inline definition in the style of
RefPtr<Type> type() { return nullptr; }will cause a compilation
error if the Type is not fully defined, so these definitions should be moved the the .cpp file.
Removing all the #includes and replacing them with forward-declarations causes downstream failures,
so add more forward-declarations and move definitions to the implementation file wherever possible.
- Modules/permissions/Permissions.cpp:
- Modules/permissions/Permissions.h:
- Modules/storage/DummyStorageProvider.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::permissionController):
(WebCore::ScriptExecutionContext::createRTCDataChannelRemoteHandlerConnection):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::permissionController): Deleted.
(WebCore::ScriptExecutionContext::createRTCDataChannelRemoteHandlerConnection): Deleted.
- workers/WorkerLoaderProxy.h:
- workers/WorkerGlobalScope.h:
- 4:44 PM Changeset in webkit [283525] by
-
- 18 edits15 adds8 deletes in trunk/LayoutTests
Re-import html/semantics/forms/ WPT
https://bugs.webkit.org/show_bug.cgi?id=231168
Reviewed by Youenn Fablet.
https://github.com/web-platform-tests/wpt/commit/dc29fc4ff101c1c216494a88a1f8a31a0f21d0aa
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/html/semantics/forms/autofocus/autofocus-on-stable-document-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/autofocus-on-stable-document.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-reconnected-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-reconnected.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-when-later-but-before-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-when-later-but-before.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-when-later-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-when-later.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/first.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/focusable-area-in-top-document-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/focusable-area-in-top-document.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/no-cross-origin-autofocus-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/no-cross-origin-autofocus.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/no-sandboxed-automatic-features-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/no-sandboxed-automatic-features.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/not-on-first-task-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/not-on-first-task.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/queue-non-focusable-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/queue-non-focusable.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/child-autofocus.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/erase-first.css: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/frame-with-autofocus-element.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/moving-autofocus-to-parent.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/utils.js: Removed.
- web-platform-tests/html/semantics/forms/autofocus/resources/w3c-import.log: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-another-top-level-browsing-context-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-another-top-level-browsing-context.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-document-with-fragment-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-document-with-fragment.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-non-focusable-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-non-focusable.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-not-fully-active-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/skip-not-fully-active.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/spin-by-blocking-style-sheet-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/spin-by-blocking-style-sheet.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/supported-elements-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/supported-elements.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/update-the-rendering-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/autofocus/update-the-rendering.html: Removed.
- web-platform-tests/html/semantics/forms/autofocus/w3c-import.log: Removed.
- web-platform-tests/html/semantics/forms/introduction-1/contains.json: Removed.
- web-platform-tests/html/semantics/forms/introduction-1/w3c-import.log: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/select-event.html: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-button-element/active-onblur-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-button-element/active-onblur.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-submit-remove-jssubmit-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-submit-remove-jssubmit.html: Added.
- web-platform-tests/html/semantics/forms/the-form-element/form-requestsubmit-autofocus-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/the-form-element/form-requestsubmit-autofocus.html: Removed.
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-input-element/input-submit-remove-jssubmit-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/input-submit-remove-jssubmit.html: Added.
- web-platform-tests/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html:
- web-platform-tests/html/semantics/forms/the-select-element/select-validity-expected.txt:
- web-platform-tests/html/semantics/forms/the-select-element/select-validity.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html: Added.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative-expected.txt:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative-expected.txt:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-textarea-element/placeholder-white-space-notref.html: Added.
- web-platform-tests/html/semantics/forms/the-textarea-element/placeholder-white-space.tentative-expected.html: Added.
- web-platform-tests/html/semantics/forms/the-textarea-element/placeholder-white-space.tentative.html: Added.
LayoutTests:
- TestExpectations:
- tests-options.json:
- 4:37 PM Changeset in webkit [283524] by
-
- 16 edits in trunk/Source/WebCore
Use ScrollClamping in more places in scrolling code
https://bugs.webkit.org/show_bug.cgi?id=231140
Reviewed by Antti Koivisto.
Fold together two functions in ScrollingEffectsControllerClient with a ScrollClamping argument.
Also use ScrollClamping to replace bool constrainsScrollingToContentEdge() on ScrollableArea.
It's slightly annoying that ScrollClamping is a ScrollableArea state, but RenderMarquee has
no clamping by default.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
- page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollBy):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::immediateScrollByWithoutContentEdgeConstraints): Deleted.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::adjustScrollPositionToBoundsIfNecessary):
(WebCore::ScrollAnimator::adjustScrollPositionIfNecessary const):
(WebCore::ScrollAnimator::immediateScrollBy):
(WebCore::ScrollAnimator::immediateScrollByWithoutContentEdgeConstraints): Deleted.
- platform/ScrollAnimator.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::adjustScrollPositionWithinRange const):
(WebCore::ScrollView::setScrollOffset):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea): Deleted.
- platform/ScrollableArea.h: Undo the use of bitfields here because the memory saving
is not worth the code complexity.
(WebCore::ScrollableArea::currentScrollBehaviorStatus):
(WebCore::ScrollableArea::setScrollBehaviorStatus):
(WebCore::ScrollableArea::scrollClamping const):
(WebCore::ScrollableArea::setScrollClamping):
(WebCore::ScrollableArea::verticalScrollElasticity const):
(WebCore::ScrollableArea::horizontalScrollElasticity const):
(WebCore::ScrollableArea::scrollbarOverlayStyle const):
(WebCore::ScrollableArea::currentScrollType const):
(WebCore::ScrollableArea::setCurrentScrollType):
(WebCore::ScrollableArea::constrainsScrollingToContentEdge const): Deleted.
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge): Deleted.
- platform/ScrollingEffectsController.cpp:
(WebCore::ScrollingEffectsController::scrollAnimationDidUpdate):
(WebCore::ScrollingEffectsController::scrollToOffsetForAnimation): Deleted.
- platform/ScrollingEffectsController.h:
- platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::applyScrollDeltaWithStretching):
(WebCore::ScrollingEffectsController::updateRubberBandAnimatingState):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
- rendering/RenderListBox.h: Minor rearrangement to optimize padding now that ScrollableArea is a little larger.
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::RenderMarquee):
- testing/Internals.cpp:
(WebCore::Internals::setScrollViewPosition):
- 4:23 PM Changeset in webkit [283523] by
-
- 10 edits1 copy1 delete in trunk/LayoutTests
Cleaning up expectations for iOS 15.
https://bugs.webkit.org/show_bug.cgi?id=230968
Unreviewed test gardening.
We conisder "platform/ios" to represent iOS 15 at this point, so we should not have created a
new directory for it in r283500. This also moves a baseline that was added in r283520.
- fast/forms/ios/accessory-bar-navigation-expected.txt:
- fast/forms/ios/focus-input-in-fixed-expected.txt:
- fast/forms/ios/focus-input-in-iframe-expected.txt:
- fast/forms/ios/focus-input-via-button-expected.txt:
- fast/forms/ios/focus-input-via-button-no-scaling-expected.txt:
- fast/forms/ios/focus-long-textarea-expected.txt:
- fast/forms/ios/zoom-after-input-tap-expected.txt:
- fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
- platform/ios-14/TestExpectations:
- platform/ios-15/TestExpectations: Removed.
- platform/ios-15/fast/forms/ios/accessory-bar-navigation-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/focus-input-in-fixed-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/focus-input-in-iframe-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/focus-input-via-button-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/focus-input-via-button-no-scaling-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/focus-long-textarea-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/zoom-after-input-tap-expected.txt: Removed.
- platform/ios-15/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt: Removed.
- platform/ios/TestExpectations:
- platform/ios/fast/events/ios/keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard-expected.txt: Renamed from LayoutTests/platform/ios-15/fast/events/ios/keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard-expected.txt.
- 4:15 PM Changeset in webkit [283522] by
-
- 72 edits2 adds in trunk
Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=231045
<rdar://problem/83744069>
Reviewed by Geoff Garen.
Source/WebCore:
Add new [WKWebView loadServiceWorker:(NSURL *)] to load a service worker in a web view. When called,
it causes us to create a page with HTML start registers the service worker with the provided URL.
The service worker in question will differ slightly from usual service workers in that:
- The service worker URL doesn't need to be HTTP/HTTPS. In particular, a custom scheme (with corresponding custom scheme handler) can be used.
- The service worker will always run in the WKWebView's associated WebProcess (which can be controlled via WKWebViewConfiguration._relatedWebView).
- The service worker will run on the main thead
- The service worker is not persistent, meaning that it will not be saved to disk, unlike regular service workers.
- The service worker's global object will be exposed to the injected bundle via a new serviceWorkerGlobalObjectIsAvailableForFrame function call on WKWebProcessPlugInLoadDelegate. The provided Frame will be the WKWebView's main frame.
- The service worker will be unregistered & exit as soon as its WKWebView gets closed / deallocated.
To make the service worker more usable via the injected bundle API, the following changes were made too:
- [WKWebProcessPlugInFrame lookUpFrameFromJSContext:] will return the WKWebView's main frame when passed in that view's service worker context.
- A new [WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:(WKWebProcessPlugInScriptWorld *)] SPI was added to get the service worker's JS context from the view.
I added an API test that launches such a service worker, makes sure the injected bundle gets notified on
the main thread of the service worker global object and that it can script it. The test also makes sure
the _relatedWebView SPI works to force a service worker into another view's process. It also tests that
[WKWebProcessPlugInFrame lookUpFrameFromJSContext:] and [WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:(WKWebProcessPlugInScriptWorld *)]
work as expected. Finally, it makes sure the service worker properly exits when the view gets closed.
- dom/Document.cpp:
(WebCore::Document::isSecureContext const):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
- loader/FrameLoaderClient.h:
- page/Frame.cpp:
(WebCore::Frame::fromJSContext):
- page/Frame.h:
- page/Page.cpp:
(WebCore::Page::serviceWorkerGlobalObject):
(WebCore::Page::setServiceWorkerGlobalScope):
- page/Page.h:
(WebCore::Page::isServiceWorkerPage const):
(WebCore::Page::markAsServiceWorkerPage):
- platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::RegistrableDomainHash::hash):
(WebCore::RegistrableDomain::RegistrableDomainHash::equal):
Registrable domains are not case sensitive. Yet its HashTraits was doing case sensitive checks.
The Service Worker code is using a HashMap whose key is a RegistrableDomain and my new API test
was initially failing simply because I used an upper case domain name in my URL. To make my
test pass, I decided to make the RegistrableDomain HashTraits case-insensitive, instead of using
a lowercase domain in my new test.
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
- workers/service/ServiceWorkerContextData.cpp:
(WebCore::ServiceWorkerContextData::isolatedCopy const):
(WebCore::ServiceWorkerContextData::isolatedCopy):
- workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):
- workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::create):
(WebCore::ServiceWorkerGlobalScope::notifyServiceWorkerPageOfCreationIfNecessary):
(WebCore::ServiceWorkerGlobalScope::serviceWorkerPage):
- workers/service/ServiceWorkerGlobalScope.h:
- workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::serviceWorkerPageIdentifier const):
(WebCore::ServiceWorkerJobData::isolatedCopy const):
- workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::importRecords):
- workers/service/server/RegistrationStore.cpp:
(WebCore::RegistrationStore::updateRegistration):
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::addRegistrationFromStore):
(WebCore::SWServer::addRegistration):
(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::tryInstallContextData):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::runServiceWorkerIfNecessary):
(WebCore::SWServer::runServiceWorker):
(WebCore::SWServer::unregisterServiceWorkerClient):
(WebCore::SWServer::removeContextConnection):
(WebCore::SWServer::createContextConnection):
- workers/service/server/SWServer.h:
(WebCore::SWServer::shouldRunServiceWorkersOnMainThreadForTesting const):
- workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::runRegisterJob):
- workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::SWServerRegistration):
- workers/service/server/SWServerRegistration.h:
(WebCore::SWServerRegistration::serviceWorkerPageIdentifier const):
- workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::SWServerToContextConnection):
- workers/service/server/SWServerToContextConnection.h:
(WebCore::SWServerToContextConnection::serviceWorkerPageIdentifier const):
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::contextData const):
(WebCore::SWServerWorker::workerThreadMode const):
(WebCore::SWServerWorker::serviceWorkerPageIdentifier const):
- workers/service/server/SWServerWorker.h:
Source/WebKit:
Add new [WKWebView loadServiceWorker:(NSURL *)] to load a service worker in a web view. When called,
it causes us to create a page with HTML start registers the service worker with the provided URL.
The service worker in question will differ slightly from usual service workers in that:
- The service worker URL doesn't need to be HTTP/HTTPS. In particular, a custom scheme (with corresponding custom scheme handler) can be used.
- The service worker will always run in the WKWebView's associated WebProcess (which can be controlled via WKWebViewConfiguration._relatedWebView).
- The service worker will run on the main thead
- The service worker is not persistent, meaning that it will not be saved to disk, unlike regular service workers.
- The service worker's global object will be exposed to the injected bundle via a new serviceWorkerGlobalObjectIsAvailableForFrame function call on WKWebProcessPlugInLoadDelegate. The provided Frame will be the WKWebView's main frame.
- The service worker will be unregistered & exit as soon as its WKWebView gets closed / deallocated.
To make the service worker more usable via the injected bundle API, the following changes were made too:
- [WKWebProcessPlugInFrame lookUpFrameFromJSContext:] will return the WKWebView's main frame when passed in that view's service worker context.
- A new [WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:(WKWebProcessPlugInScriptWorld *)] SPI was added to get the service worker's JS context from the view.
I added an API test that launches such a service worker, makes sure the injected bundle gets notified on
the main thread of the service worker global object and that it can script it. The test also makes sure
the _relatedWebView SPI works to force a service worker into another view's process. It also tests that
[WKWebProcessPlugInFrame lookUpFrameFromJSContext:] and [WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:(WKWebProcessPlugInScriptWorld *)]
work as expected. Finally, it makes sure the service worker properly exits when the view gets closed.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::swServerForSession):
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::startFetch):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
- Shared/LoadParameters.cpp:
(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):
- Shared/LoadParameters.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView _loadServiceWorker:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::loadServiceWorker):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::establishServiceWorkerContext):
(WebKit::WebProcessProxy::enableServiceWorkers):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
(API::InjectedBundle::PageLoaderClient::serviceWorkerGlobalObjectIsAvailableForFrame):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame jsContextForServiceWorkerWorld:]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(serviceWorkerGlobalObjectIsAvailableForFrame):
(setUpPageLoaderClient):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::serviceWorkerGlobalObjectIsAvailableForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
(WebKit::WebSWContextManagerConnection::establishConnection):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchServiceWorkerGlobalObjectAvailable):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsContextForServiceWorkerWorld):
(WebKit::WebFrame::frameForContext):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Source/WTF:
- wtf/URL.cpp:
(WTF::protocolHostAndPortAreEqual):
Fix issue where protocolHostAndPortAreEqual() was doing a case-sensitive check. My new service worker
API test was initially failing because of this since it is using an upper-case domain name.
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerSchemeHandler initWithBytes:]):
(-[ServiceWorkerSchemeHandler addMappingFromURLString:toData:]):
(-[ServiceWorkerSchemeHandler webView:startURLSchemeTask:]):
(-[ServiceWorkerSchemeHandler webView:stopURLSchemeTask:]):
(-[ServiceWorkerPageRemoteObject serviceWorkerGlobalObjectIsAvailable]):
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerPagePlugIn.mm: Added.
(-[ServiceWorkerPagePlugIn webProcessPlugInBrowserContextController:serviceWorkerGlobalObjectIsAvailableForFrame:inScriptWorld:]):
(-[ServiceWorkerPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerPageProtocol.h: Added.
- 4:04 PM Changeset in webkit [283521] by
-
- 2 edits in trunk/Source/WebCore
RemotePlayback missing forward declaration of Node
https://bugs.webkit.org/show_bug.cgi?id=231193
Unreviewed build fix.
The missing forward declaration was introduced in r279443 and can cause a
build failure when adding a new file to Sources.txt.
- Modules/remoteplayback/RemotePlayback.h:
- 3:50 PM Changeset in webkit [283520] by
-
- 2 edits3 adds in trunk/LayoutTests
Cleaning up expectations for iOS 15.
https://bugs.webkit.org/show_bug.cgi?id=230968
Unreviewed test gardening.
- platform/ios-14/TestExpectations:
- platform/ios-15/fast/events/ios/keydown-keyup-keypress-keys-in-non-editable-using-chinese-keyboard-expected.txt: Added.
- 3:45 PM Changeset in webkit [283519] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r283431.
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
- 3:42 PM Changeset in webkit [283518] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r283431.
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
- 3:41 PM Changeset in webkit [283517] by
-
- 2 edits in trunk/Tools
Follow-up: WTF::RetainPtr<> allows assignment of two pointer types that are not assignable
<https://webkit.org/b/230406>
<rdar://problem/83241893>
Unreviewed attempt to fix api-ios tests.
- TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
(TestWebKitAPI::TEST):
- Work around TestWTF.TypeCastsCocoa.checked_objc_cast test failures on iOS Simulator by using @autoreleasepool.
- 2:57 PM Changeset in webkit [283516] by
-
- 2 edits in branches/safari-612.2.9.1-branch/Source/WebKit
Cherry-pick r283490. rdar://problem/83856664
Vorbis decoder can't be instantiated - follow up on Bug 230742
https://bugs.webkit.org/show_bug.cgi?id=231154
rdar://problem/83825162
Fix typo in expression.
Reviewed by Tim Horton.
- Scripts/process-entitlements.sh: Add missing bool keyword.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:47 PM Changeset in webkit [283515] by
-
- 9 edits2 adds in trunk
[WebAuthn] Prefer internal user verification if available over pin entry.
https://bugs.webkit.org/show_bug.cgi?id=213903
<rdar://problem/65359269>
Patch by John Pascoe <J Pascoe> on 2021-10-04
Reviewed by Brent Fulgham.
Source/WebCore:
This adds an option to mock internal user verification in tests.
- testing/MockWebAuthenticationConfiguration.h:
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::HidConfiguration::decode):
- testing/MockWebAuthenticationConfiguration.idl:
Source/WebKit:
- UIProcess/WebAuthentication/Mock/MockHidConnection.cpp:
(WebKit::MockHidConnection::feedReports):
- UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::makeCredential):
(WebKit::CtapAuthenticator::getAssertion):
(WebKit::fido::toStatus): Deleted.
(WebKit::fido::isPinError): Deleted.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-internal-uv.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-internal-uv.html: Added.
- 2:25 PM Changeset in webkit [283514] by
-
- 5 edits in trunk
[WebAuthn] Add SPI to change username of credential
https://bugs.webkit.org/show_bug.cgi?id=230956
<rdar://problem/83471755>
Patch by John Pascoe <J Pascoe> on 2021-10-04
Reviewed by Brent Fulgham.
Source/WebKit:
Adds a new method for changing the username of a given stored webauthn credential.
New API test: TestWebKitAPI.WebAuthenticationPanel.UpdateCredentialUsername
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]):
Tools:
API test coverage for updating the username of a webauthn credential.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- 2:02 PM Changeset in webkit [283513] by
-
- 3 edits in trunk/LayoutTests
Remove test expectations since 'crash' has been resolved.
https://bugs.webkit.org/show_bug.cgi?id=230245.
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 12:58 PM Changeset in webkit [283512] by
-
- 7 edits1 add in trunk
IntrinsicGetterAccessCase implementation of proto needs to handle get_by_id_with_this
https://bugs.webkit.org/show_bug.cgi?id=229951
<rdar://problem/82787527>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/run-proto-intrinsic-getter-with-this-value-in-get-by-id-with-this.js: Added.
(assert):
(main.v37):
(main):
Source/JavaScriptCore:
The whole point of get_by_id_with_this is to have different
slot base values for |this| vs the slot base when invoking
getters. However, our intrinsic getter inlining wasn't respecting
this. This patch makes the proto intrinsic getter do the right
thing. For typed array intrinsic getters, if they have different
|this| value vs slot base, we chose not to inline them, because
the type checks are not on the |this| value, so they're not guaranteed
to be typed arrays. We can improve upon this in the future.
- bytecode/IntrinsicGetterAccessCase.h:
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitLoadPrototypeWithoutCheck):
- jit/AssemblyHelpers.h:
- jit/IntrinsicEmitter.cpp:
(JSC::IntrinsicGetterAccessCase::canEmitIntrinsicGetter):
(JSC::IntrinsicGetterAccessCase::emitIntrinsicGetter):
- jit/Repatch.cpp:
(JSC::tryCacheGetBy):
- 12:48 PM Changeset in webkit [283511] by
-
- 40 edits2 copies in trunk/Source
Split WebXR extension module IDLs into their own files and settings
https://bugs.webkit.org/show_bug.cgi?id=231149
Reviewed by Dean Jackson.
Source/WebCore:
Split WebXRInputSource+Gamepad.idl out of WebXRInputSource.idl and
WebXRSession+AR.idl out of WebXRSession.idl and make them depend on
new module specific settings WebXRGamepadsModuleEnabled and
WebXRAugmentedRealityModuleEnabled respectively.
Also adds spec links in the IDLs as I like to do.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webxr/WebXRBoundedReferenceSpace.idl:
- Modules/webxr/WebXRFrame.idl:
- Modules/webxr/WebXRInputSource+Gamepad.idl: Added.
- Modules/webxr/WebXRInputSource.idl:
- Modules/webxr/WebXRInputSourceArray.idl:
- Modules/webxr/WebXRLayer.idl:
- Modules/webxr/WebXRPose.idl:
- Modules/webxr/WebXRReferenceSpace.idl:
- Modules/webxr/WebXRRenderState.idl:
- Modules/webxr/WebXRRigidTransform.idl:
- Modules/webxr/WebXRSession+AR.idl: Added.
- Modules/webxr/WebXRSession.idl:
- Modules/webxr/WebXRSpace.idl:
- Modules/webxr/WebXRSystem.idl:
- Modules/webxr/WebXRView.idl:
- Modules/webxr/WebXRViewerPose.idl:
- Modules/webxr/WebXRViewport.idl:
- Modules/webxr/WebXRWebGLLayer.idl:
- Modules/webxr/XREnvironmentBlendMode.idl:
- Modules/webxr/XREye.idl:
- Modules/webxr/XRFrameRequestCallback.idl:
- Modules/webxr/XRHandedness.idl:
- Modules/webxr/XRInputSourceEvent.idl:
- Modules/webxr/XRInputSourcesChangeEvent.idl:
- Modules/webxr/XRInteractionMode.idl:
- Modules/webxr/XRReferenceSpaceEvent.idl:
- Modules/webxr/XRReferenceSpaceType.idl:
- Modules/webxr/XRRenderStateInit.idl:
- Modules/webxr/XRSessionEvent.idl:
- Modules/webxr/XRSessionInit.idl:
- Modules/webxr/XRSessionMode.idl:
- Modules/webxr/XRTargetRayMode.idl:
- Modules/webxr/XRVisibilityState.idl:
- Modules/webxr/XRWebGLLayerInit.idl:
- WebCore.xcodeproj/project.pbxproj:
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
Adds WebXRAugmentedRealityModuleEnabled and WebXRGamepadsModuleEnabled
to gate enabling the WebXR AR Module and the WebXR Gamepads Module on.
- 12:40 PM Changeset in webkit [283510] by
-
- 2 edits in trunk/Source/WebKit
Send necessary sandbox extensions to WebProcess in case WebRTC codecs run in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=231073
Reviewed by Eric Carlson.
Manually tested, make sure to send extensions like if audio/video capture happens in WebProcess.
This allows validating regressions due or not to GPUProcess.
- UIProcess/WebPageProxy.cpp:
- 12:35 PM Changeset in webkit [283509] by
-
- 12 edits1 copy2 moves1 add2 deletes in trunk
Use isolated NSURLSessions for each first party registrable domain
https://bugs.webkit.org/show_bug.cgi?id=230750
<rdar://83159358>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing more checks.
- web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt:
Source/WebCore:
Fix bug where service worker soft-update requests would have their "first-party-for-cookies"
field set to "https:" instead of a full origin (e.g. "https://localhost:8080"). This was
causing some service worker test failures now that we use different NSURLSession based on
the "first-party-for-cookies" field.
- workers/service/server/SWServer.cpp:
(WebCore::originURL):
Source/WebKit:
Previously would use up to 10 isolated NSURLSessions only for domains marked as prevalent
by ITP *and* that the user interacts with as first party website. We now use different
isolated NSURLSession for each top-level registrable domain, not matter their ITP status.
This significantly improves privacy.
To avoid having too many NSURLSession, we clear the ones that haven't been used in the
last 10 minutes, every time we add a new one.
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::SessionSet::isolatedSession):
LayoutTests:
This test is now passing more checks on WebKit2 but still completely fails on WebKit1 so I am
adding a WK1-specific baseline.
- platform/mac-wk1/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/connection-pool/network-partition-key-expected.txt.
- 12:34 PM Changeset in webkit [283508] by
-
- 8 edits in trunk/Source/WebCore
Make RuleSetBuilder a class
https://bugs.webkit.org/show_bug.cgi?id=231158
Reviewed by Alan Bujtas.
Improve encapsulation.
This patch also makes clients use RuleSetBuilder directly removing the two-way dependency
between RuleSet and RuleSetBuilder.
- style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::shrinkToFit):
(WebCore::Style::RuleSet::addRulesFromSheet): Deleted.
(WebCore::Style::shrinkDynamicRules): Deleted.
- style/RuleSet.h:
(WebCore::Style::RuleSet::DynamicMediaQueryRules::shrinkToFit):
- style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::RuleSetBuilder):
(WebCore::Style::m_resolver):
(WebCore::Style::RuleSetBuilder::~RuleSetBuilder):
(WebCore::Style::RuleSetBuilder::addRulesFromSheet):
(WebCore::Style::RuleSetBuilder::addChildRules):
(WebCore::Style::RuleSetBuilder::addStyleRule):
(WebCore::Style::RuleSetBuilder::pushCascadeLayer):
(WebCore::Style::RuleSetBuilder::popCascadeLayer):
(WebCore::Style::RuleSetBuilder::updateCascadeLayerOrder):
(WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver):
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::pushAndEvaluate):
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::pop):
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::didMutateResolver):
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::addRuleIfNeeded):
(WebCore::Style::RuleSetMediaQueryCollector::pushAndEvaluate): Deleted.
(WebCore::Style::RuleSetMediaQueryCollector::pop): Deleted.
(WebCore::Style::RuleSetMediaQueryCollector::didMutateResolver): Deleted.
(WebCore::Style::RuleSetMediaQueryCollector::addRuleIfNeeded): Deleted.
MediaQueryCollector is now a private inner struct of RuleSetBuilder.
- style/RuleSetBuilder.h:
- style/StyleInvalidator.cpp:
(WebCore::Style::m_dirtiesAllStyle):
- style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::updateUserAgentMediaQueryStyleIfNeeded const):
(WebCore::Style::ScopeRuleSets::initializeUserStyle):
(WebCore::Style::ScopeRuleSets::collectRulesFromUserStyleSheets):
(WebCore::Style::ScopeRuleSets::appendAuthorStyleSheets):
- style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::addToDefaultStyle):
(WebCore::Style::UserAgentStyle::initDefaultStyleSheet):
- 12:31 PM Changeset in webkit [283507] by
-
- 2 edits in trunk/Source/WebKit
process-entitlements should fail if a subcommand fails
https://bugs.webkit.org/show_bug.cgi?id=231155
Reviewed by Anders Carlsson.
- Scripts/process-entitlements.sh:
See bug 231154, which fixes a mistake in r283156 which made one of the
PlistBuddy invocations from process-entitlements fail, but did not
result in a failing build. PlistBuddy does correctly return a non-zero
return value in this case, so we should just tell the shell to propagate
that upwards.
- 11:31 AM Changeset in webkit [283506] by
-
- 8 edits in branches/safari-612.2.9.1-branch/Source
Versioning.
WebKit-7612.2.9.1.4
- 11:30 AM Changeset in webkit [283505] by
-
- 8 edits in branches/safari-612.2.9.0-branch/Source
Versioning.
WebKit-7612.2.9.0.4
- 10:38 AM Changeset in webkit [283504] by
-
- 16 edits in trunk/Source/WebKit
Enable PCM debug mode per WebsiteDataStore instead of process-global
https://bugs.webkit.org/show_bug.cgi?id=231096
Reviewed by Kate Cheney.
This will make it so we don't need to restart the network process in order to enable or disable debug mode.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::setPrivateClickMeasurementDebugMode):
(WebKit::NetworkProcess::privateClickMeasurementDebugModeEnabled const): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::setPrivateClickMeasurementDebugMode):
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::privateClickMeasurementDebugModeEnabled const):
- NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
- NetworkProcess/NetworkSessionCreationParameters.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementClientImpl.cpp:
(WebKit::PCM::ClientImpl::debugModeEnabled const):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setPrivateClickMeasurementDebugMode):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::experimentalFeatureEnabled):
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setPrivateClickMeasurementDebugMode):
- 9:46 AM Changeset in webkit [283503] by
-
- 2 edits in branches/safari-613.1.4-branch/Source/WebCore
Unreviewed maccatalyst build fix.
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::setHostProcessAttribution):
- 9:40 AM Changeset in webkit [283502] by
-
- 8 edits in branches/safari-613.1.4-branch/Source
Versioning.
WebKit-7613.1.4
- 9:40 AM Changeset in webkit [283501] by
-
- 8 edits in trunk/Source
Versioning.
WebKit-7613.1.5
- 9:39 AM Changeset in webkit [283500] by
-
- 4 edits11 adds in trunk/LayoutTests
Cleaning up expectations for iOS 15.
https://bugs.webkit.org/show_bug.cgi?id=230968
Unreviewed test gardening.
- platform/ios-14/TestExpectations:
- platform/ios-15/fast/forms/ios/accessory-bar-navigation-expected.txt: Added.
- platform/ios-15/fast/forms/ios/focus-input-in-fixed-expected.txt: Added.
- platform/ios-15/fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
- platform/ios-15/fast/forms/ios/focus-input-via-button-expected.txt: Added.
- platform/ios-15/fast/forms/ios/focus-input-via-button-no-scaling-expected.txt: Added.
- platform/ios-15/fast/forms/ios/focus-long-textarea-expected.txt: Added.
- platform/ios-15/fast/forms/ios/zoom-after-input-tap-expected.txt: Added.
- platform/ios-15/fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt: Added.
- platform/ios/TestExpectations:
- platform/ipad/TestExpectations:
- 9:37 AM Changeset in webkit [283499] by
-
- 1 copy in branches/safari-613.1.4-branch
New branch.
- 9:00 AM Changeset in webkit [283498] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed maccatalyst build fix.
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::setHostProcessAttribution):
- 8:00 AM Changeset in webkit [283497] by
-
- 2 edits in trunk/LayoutTests
Make preload referrer-img.py compatible with Python 3.9
https://bugs.webkit.org/show_bug.cgi?id=231099
Reviewed by Jonathan Bedard.
Python 3.9 removed[1] the deprecated
base64.decodestring. We should use
base64.decodebytesinstead (available since 3.1).
[1] https://bugs.python.org/issue39351
- http/wpt/preload/resources/referrer-img.py: Replace deprecated method.
- 7:50 AM Changeset in webkit [283496] by
-
- 2 edits in trunk/Source/WebCore
Fix LTS build after 242443@main
Unreviewed build fix.
- rendering/RenderBlockFlow.cpp:
- 7:26 AM Changeset in webkit [283495] by
-
- 2 edits in trunk/Tools
Send EWS exception emails to bot watchers instead of Aakash
Unreviewed.
- CISupport/ews-build/master.cfg:
- 6:57 AM Changeset in webkit [283494] by
-
- 6 edits2 adds in trunk/LayoutTests/imported/w3c
[css-flexbox] Resync WPT tests
https://bugs.webkit.org/show_bug.cgi?id=231164
Reviewed by Rob Buis.
Imported some tests after being fixed upstream. Also fetched new ones.
- web-platform-tests/css/css-flexbox/parsing/flex-grow-computed-expected.txt:
- web-platform-tests/css/css-flexbox/parsing/flex-grow-computed.html:
- web-platform-tests/css/css-flexbox/parsing/flex-shrink-computed-expected.txt:
- web-platform-tests/css/css-flexbox/parsing/flex-shrink-computed.html:
- web-platform-tests/css/css-flexbox/text-as-flexitem-size-001-expected.txt: Added.
- web-platform-tests/css/css-flexbox/text-as-flexitem-size-001.html: Added.
- web-platform-tests/css/css-flexbox/w3c-import.log:
- 6:16 AM Changeset in webkit [283493] by
-
- 4 edits in trunk
'overflow-wrap: anywhere' should be considered when calculating min-content intrinsic sizes.
https://bugs.webkit.org/show_bug.cgi?id=231152
Reviewed by Javier Fernandez.
Source/WebCore:
As opposed to overflow-wrap: 'break-word', 'anywhere' should be taken into account when computing the preferred width.
"An otherwise unbreakable sequence of characters may be broken at an arbitrary point...
Soft wrap opportunities introduced by anywhere are considered when calculating min-content intrinsic sizes."
https://drafts.csswg.org/css-text-3/#overflow-wrap-property
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const):
LayoutTests:
- TestExpectations: Progressions.
- 5:14 AM Changeset in webkit [283492] by
-
- 11 edits40 adds in trunk/LayoutTests
[css-grid] Resync web-platform-tests/css/css-grid tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=231020
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-005-expected.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-005.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-006-expected.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-006.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-007-expected.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-item-dynamic-change-007.html: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-017-expected.html: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-descendants-017.html: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-items-023-expected.html: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-items-023.html: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-items-024-expected.xht: Added.
- web-platform-tests/css/css-grid/abspos/positioned-grid-items-024.html: Added.
- web-platform-tests/css/css-grid/abspos/w3c-import.log:
- web-platform-tests/css/css-grid/alignment/grid-inline-baseline-expected.html: Added.
- web-platform-tests/css/css-grid/alignment/grid-inline-baseline.html: Added.
- web-platform-tests/css/css-grid/alignment/w3c-import.log:
- web-platform-tests/css/css-grid/empty-grid-within-flexbox-expected.xht: Added.
- web-platform-tests/css/css-grid/empty-grid-within-flexbox.html: Added.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-minmax-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-minmax.html: Added.
- web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
- web-platform-tests/css/css-grid/grid-items/grid-size-with-orthogonal-child-dynamic-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-002-expected.html.
- web-platform-tests/css/css-grid/grid-items/grid-size-with-orthogonal-child-dynamic.html: Added.
- web-platform-tests/css/css-grid/grid-items/percentage-margin-dynamic-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-items/percentage-margin-dynamic.html: Added.
- web-platform-tests/css/css-grid/grid-items/replaced-element-014-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-items/replaced-element-014.html: Added.
- web-platform-tests/css/css-grid/grid-items/replaced-element-015-expected.html: Added.
- web-platform-tests/css/css-grid/grid-items/replaced-element-015.html: Added.
- web-platform-tests/css/css-grid/grid-items/w3c-import.log:
- web-platform-tests/css/css-grid/grid-model/grid-item-hit-test-expected.txt: Added.
- web-platform-tests/css/css-grid/grid-model/grid-item-hit-test.html: Added.
- web-platform-tests/css/css-grid/grid-model/w3c-import.log:
- web-platform-tests/css/css-grid/grid-with-dynamic-img-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-with-dynamic-img.html: Added.
- web-platform-tests/css/css-grid/grid-with-orthogonal-child-within-flexbox-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-with-orthogonal-child-within-flexbox.html: Added.
- web-platform-tests/css/css-grid/grid-within-flexbox-indefinite-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/grid-within-flexbox-indefinite.html: Added.
- web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-size-dynamic-block-size-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-item-percentage-quirk-001-expected.html.
- web-platform-tests/css/css-grid/layout-algorithm/grid-intrinsic-size-dynamic-block-size.html: Added.
- web-platform-tests/css/css-grid/layout-algorithm/grid-template-flexible-rerun-track-sizing-expected.xht: Added.
- web-platform-tests/css/css-grid/layout-algorithm/grid-template-flexible-rerun-track-sizing.html: Added.
- web-platform-tests/css/css-grid/layout-algorithm/w3c-import.log:
- web-platform-tests/css/css-grid/placement/grid-placement-items-spanning-multiple-rows-expected.xht: Added.
- web-platform-tests/css/css-grid/placement/grid-placement-items-spanning-multiple-rows.html: Added.
- web-platform-tests/css/css-grid/placement/w3c-import.log:
- web-platform-tests/css/css-grid/w3c-import.log:
LayoutTests:
- 4:04 AM Changeset in webkit [283491] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Mark more font-palette tests as failing. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=231165
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-10-04
- platform/glib/TestExpectations:
- 1:07 AM Changeset in webkit [283490] by
-
- 2 edits in trunk/Source/WebKit
Vorbis decoder can't be instantiated - follow up on Bug 230742
https://bugs.webkit.org/show_bug.cgi?id=231154
rdar://problem/83825162
Fix typo in expression.
Reviewed by Tim Horton.
- Scripts/process-entitlements.sh: Add missing bool keyword.
- 12:48 AM Changeset in webkit [283489] by
-
- 7 edits in trunk/Source/WebCore
Regression (r283238)[ MacOS wk1 ] fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=231022
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-10-04
Reviewed by Youenn Fablet.
Originally the implementation would always return red frame, and the test would pass.
r283238 changed the implementation to not return a sample if there is not a display buffer,
as logically such cannot be used as a sample.
This broke the test case since the CanvasCaptureMediaStreamTrack would try to capture
the canvas display buffer during next runloop iteration (0s timeout) after each modification.
This does not work, as the display buffer is composed during "prepare for display"
phase.
Add CanvasBase observers to observe that display buffer has been prepared, and capture
the media sample after that observer has fired.
The test would work for wk2 due to timing related differences, preparation would have
typically run before the canvas capture 0s timeout.
Fixes fast/mediastream/captureStream/canvas3d.html for wk1.
- Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDisplayBufferPrepared):
- Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
- html/CanvasBase.cpp:
(WebCore::CanvasBase::addDisplayBufferObserver):
(WebCore::CanvasBase::removeDisplayBufferObserver):
(WebCore::CanvasBase::notifyObserversCanvasDisplayBufferPrepared):
- html/CanvasBase.h:
(WebCore::CanvasBase::hasDisplayBufferObservers const):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::prepareForDisplay):
Move the "prepare only when the owner element is in the tree" logic to
its correct place to the caller, e.g. to the element itself.
Oct 3, 2021:
- 11:37 PM Changeset in webkit [283488] by
-
- 5 edits2 adds in trunk/Source/WebCore
Move RuleSet builder to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=231137
Reviewed by Alan Bujtas.
There is quite a bit of code for it.
There is lots of room for refactoring and cleanups here. This patch does none of it.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::addRulesFromSheet):
(WebCore::Style::RuleSet::Builder::addChildRules): Deleted.
(WebCore::Style::RuleSet::Builder::addRulesFromSheet): Deleted.
(WebCore::Style::RuleSet::Builder::~Builder): Deleted.
(WebCore::Style::RuleSet::Builder::addStyleRule): Deleted.
(WebCore::Style::RuleSet::Builder::registerLayers): Deleted.
(WebCore::Style::RuleSet::Builder::pushCascadeLayer): Deleted.
(WebCore::Style::RuleSet::Builder::popCascadeLayer): Deleted.
(WebCore::Style::RuleSet::Builder::updateCascadeLayerOrder): Deleted.
(WebCore::Style::RuleSet::Builder::addMutatingRulesToResolver): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::pushAndEvaluate): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::pop): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::didMutateResolver): Deleted.
(WebCore::Style::RuleSet::MediaQueryCollector::addRuleIfNeeded): Deleted.
MediaQueryCollector (an implementation detail of the Builder) moves too.
- style/RuleSet.h:
- style/RuleSetBuilder.cpp: Added.
(WebCore::Style::RuleSetBuilder::~RuleSetBuilder):
(WebCore::Style::RuleSetBuilder::addChildRules):
(WebCore::Style::RuleSetBuilder::addRulesFromSheet):
(WebCore::Style::RuleSetBuilder::addStyleRule):
(WebCore::Style::RuleSetBuilder::registerLayers):
(WebCore::Style::RuleSetBuilder::pushCascadeLayer):
(WebCore::Style::RuleSetBuilder::popCascadeLayer):
(WebCore::Style::RuleSetBuilder::updateCascadeLayerOrder):
(WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver):
(WebCore::Style::RuleSetMediaQueryCollector::pushAndEvaluate):
(WebCore::Style::RuleSetMediaQueryCollector::pop):
(WebCore::Style::RuleSetMediaQueryCollector::didMutateResolver):
(WebCore::Style::RuleSetMediaQueryCollector::addRuleIfNeeded):
- style/RuleSetBuilder.h: Added.
- 10:37 PM Changeset in webkit [283487] by
-
- 2 edits in trunk/Source/WebKit
[GTK] REGRESSION(r283304): All GTK4 layout tests are aborting
https://bugs.webkit.org/show_bug.cgi?id=231153
Reviewed by Alexey Proskuryakov.
Revert back to the previous NOP behavior of bindAccessibilityTree()
for GTK4, leaving the assert for the debug mode with an informative
message in the log.
Covered by existing tests.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::bindAccessibilityTree):
- 9:34 PM Changeset in webkit [283486] by
-
- 4 edits in trunk
[LFC][IFC] Do not take hanging whitespace sequence into account while finding expansion opportunities
https://bugs.webkit.org/show_bug.cgi?id=231132
Reviewed by Antti Koivisto.
Source/WebCore:
Ignore hanging whitespace for expansion opportunities.
This patch fixes imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html
- layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::applyRunExpansion):
LayoutTests:
- 6:07 PM Changeset in webkit [283485] by
-
- 3 edits in trunk/Source/WebCore
[LFC][IFC] HangingTrailingContent should cache width/length
https://bugs.webkit.org/show_bug.cgi?id=231128
Reviewed by Antti Koivisto.
Compute the length of the hanging trailing whitespace sequence.
This is in preparation for fixing imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html
- layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::resetTrailingContent):
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox):
(WebCore::Layout::Line::HangingTrailingContent::add):
(WebCore::Layout::Line::HangingTrailingContent::HangingTrailingContent): Deleted.
(WebCore::Layout::Line::HangingTrailingContent::width const): Deleted.
- layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::HangingTrailingContent::length const):
(WebCore::Layout::Line::HangingTrailingContent::width const):
(WebCore::Layout::Line::HangingTrailingContent::reset):
- 4:09 PM Changeset in webkit [283484] by
-
- 2 edits in trunk/Source/WebCore
WebXRSession's m_environmentBlendMode and m_interactionMode are never initialized
https://bugs.webkit.org/show_bug.cgi?id=231144
Reviewed by Dean Jackson.
The m_environmentBlendMode and m_interactionMode members of WebXRSession were
not being initialized to anything and therefor were giving random data. This
is not really testable, as the result is just that the tests no longer flake.
- Modules/webxr/WebXRSession.h:
- 4:03 PM Changeset in webkit [283483] by
-
- 4 edits in trunk/Source/WebCore
Build fix: Attribute IOSurfaces created by camera and decoders to responsible WebProcess
<https://bugs.webkit.org/show_bug.cgi?id=231075>
<rdar://problem/83767168>
Unreviewed build fix.
Source/WebCore:
- platform/graphics/cocoa/IOSurface.mm:
- Remove IOSurfaceSPI.h header already included by IOSurface.h. This should force this source file to be rebuilt as well.
Source/WebCore/PAL:
- pal/spi/cocoa/IOSurfaceSPI.h:
(IOSurfaceMemoryLedgerTags):
- Define enums for both HAVE(IOSURFACE_SET_OWNERSHIP) and HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY).
- 4:00 PM Changeset in webkit [283482] by
-
- 14 edits in trunk/Source
Non-unified build fixes, early October 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=231143
Unreviewed non-unified build fixes.
Source/JavaScriptCore:
- jit/BaselineJITCode.cpp:
Source/WebCore:
- Modules/filesystemaccess/FileSystemHandle.cpp:
- Modules/push-api/PushMessageData.h:
- html/track/InbandTextTrack.cpp:
- inspector/agents/InspectorCanvasAgent.h:
- loader/CrossOriginOpenerPolicy.cpp:
- rendering/LegacyLineLayout.cpp:
- rendering/RenderBlockFlow.cpp:
Source/WebKit:
- NetworkProcess/NetworkResourceLoadParameters.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextTerminateGPUProcess):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
- 2:57 PM Changeset in webkit [283481] by
-
- 6 edits in trunk
Incorrect preferred width computation when trimmable leading whitespace is present
https://bugs.webkit.org/show_bug.cgi?id=231139
Reviewed by Antti Koivisto.
Source/WebCore:
stripFrontSpaces should be reset to the default value whenever we are at the beginning of the line, while computing the preferred trimmed width.
This is already done for line break boxes (<br>) but not when the force line break comes from a text content with
preserved linebreak ("\n").
See WPT progressions.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
- rendering/RenderText.cpp:
(WebCore::RenderText::trimmedPreferredWidths):
- rendering/RenderText.h:
LayoutTests:
- TestExpectations: IFC already supports these cases. Preferred width computation produced an incorrect shrink-fit width.
- 2:29 PM Changeset in webkit [283480] by
-
- 2 edits in trunk/Source/WebCore/PAL
Build fix: GPU Process microphone attribution SPI adoption
<https://bugs.webkit.org/show_bug.cgi?id=231034>
<rdar://problem/83732537>
- pal/spi/cocoa/AVFoundationSPI.h:
(-[AVAudioSession setHostProcessAttribution:error:]):
- Add SPI declaration for open source bots.
- 2:03 PM Changeset in webkit [283479] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove control reaches end of non-void function warning
Unreviewed. Warning introduced in r283139.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::isConstantOwnedByUnlinkedCodeBlock const):
- 2:02 PM Changeset in webkit [283478] by
-
- 3 edits in trunk/Source/WebKit
[PlayStation] Pass logging channel parameter to WebProcess from environment variable
https://bugs.webkit.org/show_bug.cgi?id=230726
<rdar://problem/83740947>
Reviewed by Fujii Hironori.
Added release log configuration environment variables to PlayStation port.
- UIProcess/playstation/WebProcessPoolPlayStation.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/playstation/WebProcessPlayStation.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 12:32 PM Changeset in webkit [283477] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Line functions can compute the "extra horizontal space"
https://bugs.webkit.org/show_bug.cgi?id=231127
Reviewed by Antti Koivisto.
This is in preparation for making applyRunExpansion hanging whitespace aware.
- layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::removeCollapsibleContent):
(WebCore::Layout::Line::applyRunExpansion):
(WebCore::Layout::Line::visuallyCollapseHangingOverflow):
- layout/formattingContexts/inline/InlineLine.h:
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
- 12:31 PM Changeset in webkit [283476] by
-
- 16 edits2 adds in trunk
WTF::RetainPtr<> allows assignment of two pointer types that are not assignable
<https://webkit.org/b/230406>
<rdar://problem/83241893>
Reviewed by Darin Adler.
Source/WebKit:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(transformTrustToData):
- Change return type to match object.
(encodeError):
- Use bridge_cast() to fix assignment.
(transformDataToTrust):
- Change return type to match object.
(decodeError):
- Use bridge_id_cast() to fix assignment.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Use bridge_id_cast() to fix assignment.
- UIProcess/mac/WebDataListSuggestionsDropdownMac.h:
- Use correct name of class that actually exists.
Source/WebKitLegacy/mac:
- Plugins/WebBasePluginPackage.mm:
(+[WebBasePluginPackage pluginWithPath:]):
- Use explicit type with RetainPtr<> to match return type.
Source/WTF:
- wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
(WTF::RetainPtr::checkType): Add.
- Add type check for move constructor.
- wtf/cocoa/TypeCastsCocoa.h:
- Change #include to #import.
(WTF_CF_TO_NS_BRIDGE_TRANSFER): Add.
(WTF_CF_TO_NS_BRIDGE_TRANSFER): Add.
- Helper macros for bridge_cast() and bridge_id_cast().
(WTF_DECLARE_CF_NS_BRIDGE_CAST): Add.
- Macro used to define bridge_cast() functions for all known toll-free-bridged types.
(WTF::bridge_cast): Add.
- Helper macro for toll-free-bridge casting from a known CF type to and from their Objective-C NS type. Prevents ref churn for rvale RetainPtr<> objects.
(WTF::bridge_id_cast): Add.
- Helper macro for casting from any CFTypeRef to id. Prevents ref churn for rvalue RetainPtr<> objects.
(WTF::checked_objc_cast):
- Simplified to match dynamic_objc_cast<> implementation in RetainPtr.h.
- wtf/cocoa/VectorCocoa.h:
(WTF::createNSArray):
- Change return type to match object.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
- Use bridge_cast() to fix assignment.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Add RetainPtrARC.mm and TypeCastsCocoaARC.mm to the project.
- TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:
- Update for dual compilation with MRR and with ARC. Change -retainCount methods to CFGetRetainCount().
- Add @autoreleasepool blocks around groups of tests to find over-released bugs sooner (for future changes).
- Add more CFGetRetainCount() to catch unexpected auto-released objects as well as leaks.
(TestWebKitAPI::helloWorldCStringLength): Add.
(TestWebKitAPI::TEST):
- Add tests for bridge_cast() and bridge_id_cast().
- Remove invalid tests after changing RetainPtr<> move constructor to check types.
- TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoaARC.mm: Add.
- Run tests in TypeCastsCocoa.mm with ARC enabled.
- TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
(TestWebKitAPI::TEST):
- Update for dual compilation with MRR and with ARC. Change -retainCount methods to CFGetRetainCount().
- Make it possible to name tests differently for MRR vs. ARC using RETAIN_PTR_TEST_NAME macro.
- TestWebKitAPI/Tests/WTF/ns/RetainPtrARC.mm: Add.
- Run tests in RetainPtr.mm with ARC enabled.
- TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
(readFile):
- Use bridge_cast() to fix assignment.
- Drive-by fix to keep NSData out of autoreleasePool.
- 11:48 AM Changeset in webkit [283475] by
-
- 1 copy in tags/Safari-612.2.9.1.3
Tag Safari-612.2.9.1.3.
- 11:46 AM Changeset in webkit [283474] by
-
- 6 edits in trunk/Source/WebCore
[LFC][IFC] Moving hanging whitespace sequence handling to Line
https://bugs.webkit.org/show_bug.cgi?id=231126
Reviewed by Antti Koivisto.
Let the Line handle the whitespace hanging. Line::HangingTrailingContent will eventually gain more functionality.
This is also in preparation for fixing imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-014.html
- layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::Line):
(WebCore::Layout::Line::visuallyCollapseHangingOverflow):
(WebCore::Layout::Line::HangingTrailingContent::HangingTrailingContent):
(WebCore::Layout::Line::HangingTrailingContent::width const):
- layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::hangingWhitespaceWidth const):
(WebCore::Layout::Line::Run::shouldTrailingWhitespaceHang const):
(WebCore::Layout::Line::Run::isOverflowWhitespaceHanging const): Deleted. shouldTrailingWhitespaceHang is a more descriptive name.
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::hangingGlyphWidth): Deleted.
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
- layout/formattingContexts/inline/InlineLineBuilder.h:
- 11:41 AM Changeset in webkit [283473] by
-
- 1 copy in tags/Safari-612.2.9.0.3
Tag Safari-612.2.9.0.3.
- 11:30 AM Changeset in webkit [283472] by
-
- 1 copy in tags/Safari-612.2.9.2.2
Tag Safari-612.2.9.2.2.
- 11:28 AM Changeset in webkit [283471] by
-
- 1 copy in tags/Safari-612.2.9.3.2
Tag Safari-612.2.9.3.2.
- 10:22 AM Changeset in webkit [283470] by
-
- 7 edits in trunk/Source
WebCore::Length incorrectly uses memcpy() for copy constructors/operator and IPC encoding/decoding
https://bugs.webkit.org/show_bug.cgi?id=230744
Reviewed by David Kilzer.
Source/WebCore:
Copy-constructing Length by memcpy is sketchy; replace with code that initializes the appropriate
fields based on type, taking care to deref() and ref() the calc handle.
Expose isFloat() for encoding.
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValueIfCategory): Add a bit of calc logging.
- platform/Length.cpp:
(WebCore::Length::Length):
- platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::isFloat const):
Source/WebKit:
Safe encoding/decoding of Length requires that we encode the enum and fields separately,
and don't allow calc types (there isn't enough context in the receiving process to resolve
calc).
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Length>::encode):
(IPC::ArgumentCoder<Length>::decode):
- Shared/WebCoreArgumentCoders.h:
- 10:19 AM Changeset in webkit [283469] by
-
- 8 edits in trunk
Enable release log to stderr
https://bugs.webkit.org/show_bug.cgi?id=230725
<rdar://problem/83740529>
Reviewed by Michael Catanzaro.
.:
Introduced new flags, USE_LOG_STDERR for release logging to stderr.
- Source/cmake/WebKitFeatures.cmake:
Source/WebCore:
SQLiteDatabase uses hard-coded %{public} format specifiers. Replace them with defined
macro.
No new tests because there is no behavior change.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::prepareStatementSlow):
(WebCore::SQLiteDatabase::prepareStatement):
(WebCore::SQLiteDatabase::prepareHeapStatementSlow):
(WebCore::SQLiteDatabase::prepareHeapStatement):
Source/WTF:
Define new compiler definitions, USE_LOG_STDERR for release logging. We don't have
modern logging backend so that dumping out to stdout/stderr is still very valuable.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/Logger.h:
(WTF::Logger::log):
(WTF::Logger::logVerbose):
- 10:10 AM Changeset in webkit [283468] by
-
- 2 edits in trunk/Tools
Some layout tests with Japanese glyphs fail if Japanese is included in the system "Preferred Languages" settings
https://bugs.webkit.org/show_bug.cgi?id=231112
Reviewed by Simon Fraser.
Simply set the default locale to en-US. Tests can still override it.
- WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
- 10:02 AM Changeset in webkit [283467] by
-
- 1 edit in branches/safari-611.4.2.0-branch/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
Apply patch. rdar://problem/81175635
- 10:02 AM Changeset in webkit [283466] by
-
- 8 edits8 adds in branches/safari-611.4.2.0-branch
Cherry-pick r281431. rdar://problem/81175635
This reverts r283414.
- 8:52 AM Changeset in webkit [283465] by
-
- 3 edits2 adds in trunk
REGRESSION (r283335): rubber-banding no longer locks to an axis
https://bugs.webkit.org/show_bug.cgi?id=231131
Reviewed by Tim Horton.
Source/WebCore:
r283335 introduced a bug where pulling down to rubber-band would result in sideways
motion even when the gesture was mostly vertical.
ScrollingEffectsController::modifyScrollDeltaForStretching() has some axis-locking behavior
that was broken by r283335, so restore the old behavior.
Test: fast/scrolling/mac/rubberband-axis-locking.html
- platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::modifyScrollDeltaForStretching):
(WebCore::isHorizontalSide): Deleted.
(WebCore::isVerticalSide): Deleted.
LayoutTests:
- fast/scrolling/mac/rubberband-axis-locking-expected.txt: Added.
- fast/scrolling/mac/rubberband-axis-locking.html: Added.
- 6:59 AM Changeset in webkit [283464] by
-
- 33 edits2 adds in trunk/Source/WebCore
[LFC][Integration] More run->box renaming and other iterator cleanups
https://bugs.webkit.org/show_bug.cgi?id=231135
Reviewed by Alan Bujtas.
Also move TextBoxIterator to a file of its own.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::localCaretRectForCharacterOffset):
- dom/Position.cpp:
(WebCore::hasInlineRun):
(WebCore::Position::upstream const):
(WebCore::Position::downstream const):
(WebCore::searchAheadForBetterMatch):
(WebCore::Position::inlineRunAndOffset const):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextRun):
(WebCore::TextIterator::handleTextNodeFirstLetter):
- editing/TextIterator.h:
- layout/integration/InlineIteratorBox.cpp:
(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator== const):
(WebCore::InlineIterator::BoxIterator::atEnd const):
(WebCore::InlineIterator::Box::line const):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLine):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLine):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineIgnoringLineBreak):
(WebCore::InlineIterator::BoxIterator::traverseNextOnLineInLogicalOrder):
(WebCore::InlineIterator::BoxIterator::traversePreviousOnLineInLogicalOrder):
(WebCore::InlineIterator::boxFor):
(WebCore::InlineIterator::Box::modernPath const):
(WebCore::InlineIterator::Box::legacyPath const):
(WebCore::InlineIterator::TextBox::nextTextRun const): Deleted.
(WebCore::InlineIterator::TextBox::nextTextRunInTextOrder const): Deleted.
(WebCore::InlineIterator::TextBox::selectionRect const): Deleted.
(WebCore::InlineIterator::TextBox::isCombinedText const): Deleted.
(WebCore::InlineIterator::TextBox::fontCascade const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator): Deleted.
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::firstTextRunFor): Deleted.
(WebCore::InlineIterator::firstTextRunInTextOrderFor): Deleted.
(WebCore::InlineIterator::textRunFor): Deleted.
(WebCore::InlineIterator::textRunsFor): Deleted.
(WebCore::InlineIterator::runFor): Deleted.
- layout/integration/InlineIteratorBox.h:
(WebCore::InlineIterator::BoxIterator::BoxIterator):
(WebCore::InlineIterator::BoxIterator::operator* const):
(WebCore::InlineIterator::BoxIterator::operator-> const):
(WebCore::InlineIterator::Box::legacyInlineBox const):
(WebCore::InlineIterator::Box::inlineBox const):
(WebCore::InlineIterator::TextBox::renderer const): Deleted.
(WebCore::InlineIterator::TextBox::legacyInlineBox const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator++): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator* const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::operator-> const): Deleted.
(WebCore::InlineIterator::TextBoxIterator::get const): Deleted.
(WebCore::InlineIterator::TextRunRange::TextRunRange): Deleted.
(WebCore::InlineIterator::TextRunRange::begin const): Deleted.
(WebCore::InlineIterator::TextRunRange::end const): Deleted.
(WebCore::InlineIterator::TextBox::hasHyphen const): Deleted.
(WebCore::InlineIterator::TextBox::TextBox): Deleted.
(WebCore::InlineIterator::TextBox::text const): Deleted.
(WebCore::InlineIterator::TextBox::start const): Deleted.
(WebCore::InlineIterator::TextBox::end const): Deleted.
(WebCore::InlineIterator::TextBox::length const): Deleted.
(WebCore::InlineIterator::TextBox::offsetForPosition const): Deleted.
(WebCore::InlineIterator::TextBox::positionForOffset const): Deleted.
(WebCore::InlineIterator::TextBox::selectableRange const): Deleted.
(WebCore::InlineIterator::TextBox::createTextRun const): Deleted.
(isType): Deleted.
- layout/integration/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::BoxLegacyPath):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextTextBox):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::BoxLegacyPath::operator== const):
(WebCore::InlineIterator::BoxLegacyPath::traverseNextInlineBoxInCacheOrder):
(WebCore::InlineIterator::BoxLegacyPath::traversePreviousInlineBoxInCacheOrder):
(WebCore::InlineIterator::BoxIteratorLegacyPath::BoxIteratorLegacyPath): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isText const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::rect const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isHorizontal const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::dirOverride const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::isLineBreak const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::minimumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::maximumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::bidiLevel const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::hasHyphen const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::text const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::start const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::end const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::length const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::positionForOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::selectableRange const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::createTextRun const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::renderer const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::operator== const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::atEnd const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::legacyInlineBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::rootInlineBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::inlineTextBox const): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::initializeLogicalOrderCacheForLine): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traverseNextInlineBoxInCacheOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorLegacyPath::traversePreviousInlineBoxInCacheOrder): Deleted.
- layout/integration/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::BoxModernPath):
(WebCore::InlineIterator::BoxModernPath::traverseNextTextBox):
(WebCore::InlineIterator::BoxModernPath::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::BoxModernPath::operator== const):
(WebCore::InlineIterator::BoxIteratorModernPath::BoxIteratorModernPath): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isText const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::rect const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isHorizontal const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::dirOverride const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::isLineBreak const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::minimumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::maximumCaretOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::bidiLevel const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::hasHyphen const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::text const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::start const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::end const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::length const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::positionForOffset const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::selectableRange const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::createTextRun const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::renderer const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextTextRun): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextTextRunInTextOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousOnLine): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousOnLineInLogicalOrder): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::operator== const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::atEnd const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::box const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::inlineContent const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traverseNextLeaf): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::traversePreviousLeaf): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::setAtEnd): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::boxes const): Deleted.
(WebCore::InlineIterator::BoxIteratorModernPath::line const): Deleted.
- layout/integration/InlineIteratorLineLegacyPath.h:
(WebCore::InlineIterator::LineIteratorLegacyPath::firstRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::lastRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::logicalStartRun const):
(WebCore::InlineIterator::LineIteratorLegacyPath::logicalEndRun const):
- layout/integration/InlineIteratorLineModernPath.h:
(WebCore::InlineIterator::LineIteratorModernPath::firstRun const):
(WebCore::InlineIterator::LineIteratorModernPath::lastRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalStartRun const):
(WebCore::InlineIterator::LineIteratorModernPath::logicalEndRun const):
- layout/integration/InlineIteratorTextBox.cpp: Added.
(WebCore::InlineIterator::TextBox::nextTextBox const):
(WebCore::InlineIterator::TextBox::nextTextBoxInTextOrder const):
(WebCore::InlineIterator::TextBox::selectionRect const):
(WebCore::InlineIterator::TextBox::isCombinedText const):
(WebCore::InlineIterator::TextBox::fontCascade const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextBox):
(WebCore::InlineIterator::TextBoxIterator::traverseNextTextBoxInTextOrder):
(WebCore::InlineIterator::firstTextBoxFor):
(WebCore::InlineIterator::firstTextBoxInTextOrderFor):
(WebCore::InlineIterator::textBoxFor):
(WebCore::InlineIterator::textBoxesFor):
- layout/integration/InlineIteratorTextBox.h: Added.
(WebCore::InlineIterator::TextBox::renderer const):
(WebCore::InlineIterator::TextBox::legacyInlineBox const):
(WebCore::InlineIterator::TextBoxIterator::TextBoxIterator):
(WebCore::InlineIterator::TextBoxIterator::operator++):
(WebCore::InlineIterator::TextBoxIterator::operator* const):
(WebCore::InlineIterator::TextBoxIterator::operator-> const):
(WebCore::InlineIterator::TextBoxIterator::get const):
(WebCore::InlineIterator::TextBoxRange::TextBoxRange):
(WebCore::InlineIterator::TextBoxRange::begin const):
(WebCore::InlineIterator::TextBoxRange::end const):
(WebCore::InlineIterator::TextBox::hasHyphen const):
(WebCore::InlineIterator::TextBox::TextBox):
(WebCore::InlineIterator::TextBox::text const):
(WebCore::InlineIterator::TextBox::start const):
(WebCore::InlineIterator::TextBox::end const):
(WebCore::InlineIterator::TextBox::length const):
(WebCore::InlineIterator::TextBox::offsetForPosition const):
(WebCore::InlineIterator::TextBox::positionForOffset const):
(WebCore::InlineIterator::TextBox::selectableRange const):
(WebCore::InlineIterator::TextBox::createTextRun const):
(isType):
- layout/integration/LayoutIntegrationCoverage.h:
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::textBoxesFor const):
(WebCore::LayoutIntegration::LineLayout::boxFor const):
(WebCore::LayoutIntegration::LineLayout::textRunsFor const): Deleted.
(WebCore::LayoutIntegration::LineLayout::runFor const): Deleted.
- layout/integration/LayoutIntegrationLineLayout.h:
- rendering/CaretRectComputation.cpp:
- rendering/LegacyInlineTextBox.h:
- rendering/LegacyLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getLeadingCorner const):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::collectSelectionGeometries):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::linesBoundingBox const):
(WebCore::RenderLineBreak::absoluteRects const):
(WebCore::RenderLineBreak::absoluteQuads const):
(WebCore::RenderLineBreak::collectSelectionGeometries):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects const):
(WebCore::RenderText::collectSelectionGeometries):
(WebCore::collectAbsoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange const):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunLocation const):
(WebCore::RenderText::linesBoundingBox const):
(WebCore::RenderText::collectSelectionGeometriesForLineBoxes):
(WebCore::RenderText::caretMinOffset const):
(WebCore::RenderText::caretMaxOffset const):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil const):
(WebCore::containsOffset):
(WebCore::RenderText::hasRenderedText const):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):
- rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::paintDecoration):
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):
- rendering/TextBoxPainter.h:
- rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
- rendering/TextDecorationPainter.h:
(WebCore::TextDecorationPainter::setTextBox):
(WebCore::TextDecorationPainter::setTextBoxIterator): Deleted.
- rendering/style/RenderStyle.cpp:
- style/InlineTextBoxStyle.cpp:
- 12:16 AM Changeset in webkit [283463] by
-
- 398 edits in trunk/Source/WebCore
Setting and RuntimeEnabledFeature names in IDL files should match those used elsewhere
https://bugs.webkit.org/show_bug.cgi?id=231129
Rubber-stamped by Sam Weinig.
No new tests; no functional change.
For ease of searching the project, the Setting/RuntimeEnabledFeature names inside
IDL files should match the names used in C++ code (specifically, they shouldn't
magically elide the -Enabled suffix, so that if you search for XFeatureEnabled,
you don't miss the IDL uses).
- Modules/applepay/ApplePaySession.idl:
- Modules/applepay/ApplePaySetup.idl:
- Modules/applepay/ApplePaySetupFeature.idl:
- Modules/async-clipboard/Clipboard.idl:
- Modules/async-clipboard/ClipboardItem.idl:
- Modules/async-clipboard/Navigator+Clipboard.idl:
- Modules/beacon/Navigator+Beacon.idl:
- Modules/cache/DOMCache.idl:
- Modules/cache/DOMCacheStorage.idl:
- Modules/cache/WindowOrWorkerGlobalScope+Caches.idl:
- Modules/contact-picker/ContactsManager.idl:
- Modules/contact-picker/Navigator+Contacts.idl:
- Modules/credentialmanagement/BasicCredential.idl:
- Modules/credentialmanagement/CredentialsContainer.idl:
- Modules/credentialmanagement/Navigator+Credentials.idl:
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeyStatusMap.idl:
- Modules/encryptedmedia/MediaKeySystemAccess.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/encryptedmedia/Navigator+EME.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeySession.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
- Modules/entriesapi/DOMFileSystem.idl:
- Modules/entriesapi/FileSystemDirectoryEntry.idl:
- Modules/entriesapi/FileSystemDirectoryReader.idl:
- Modules/entriesapi/FileSystemEntry.idl:
- Modules/entriesapi/FileSystemFileEntry.idl:
- Modules/entriesapi/HTMLInputElement+EntriesAPI.idl:
- Modules/fetch/FetchRequest.idl:
- Modules/filesystemaccess/FileSystemDirectoryHandle.idl:
- Modules/filesystemaccess/FileSystemFileHandle.idl:
- Modules/filesystemaccess/FileSystemHandle.idl:
- Modules/filesystemaccess/StorageManager+FileSystemAccess.idl:
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/GamepadButton.idl:
- Modules/gamepad/GamepadEvent.idl:
- Modules/gamepad/Navigator+Gamepad.idl:
- Modules/geolocation/GeolocationCoordinates.idl:
- Modules/highlight/Highlight.idl:
- Modules/highlight/HighlightRegister.idl:
- Modules/mediacapabilities/AudioConfiguration.idl:
- Modules/mediacapabilities/MediaCapabilities.idl:
- Modules/mediacapabilities/MediaCapabilitiesDecodingInfo.idl:
- Modules/mediacapabilities/MediaCapabilitiesEncodingInfo.idl:
- Modules/mediacapabilities/MediaCapabilitiesInfo.idl:
- Modules/mediacapabilities/MediaDecodingConfiguration.idl:
- Modules/mediacapabilities/MediaEncodingConfiguration.idl:
- Modules/mediacapabilities/Navigator+MediaCapabilities.idl:
- Modules/mediacapabilities/VideoConfiguration.idl:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediarecorder/BlobEvent.idl:
- Modules/mediarecorder/MediaRecorder.idl:
- Modules/mediarecorder/MediaRecorderErrorEvent.idl:
- Modules/mediasession/MediaMetadataInit.idl:
- Modules/mediasession/MediaMetadataPlaylistMixin.idl:
- Modules/mediasession/MediaSessionActionDetails.idl:
- Modules/mediasession/MediaSessionCoordinator.idl:
- Modules/mediasession/MediaSessionCoordinatorMixin.idl:
- Modules/mediasession/MediaSessionPlaylistMixin.idl:
- Modules/mediasession/Navigator+MediaSession.idl:
- Modules/mediasource/AudioTrack+MediaSource.idl:
- Modules/mediasource/DOMURL+MediaSource.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediasource/TextTrack+MediaSource.idl:
- Modules/mediasource/VideoPlaybackQuality.idl:
- Modules/mediasource/VideoTrack+MediaSource.idl:
- Modules/mediastream/MediaDevices.idl:
- Modules/mediastream/Navigator+MediaDevices.idl:
- Modules/mediastream/RTCAnswerOptions.idl:
- Modules/mediastream/RTCCertificate.idl:
- Modules/mediastream/RTCConfiguration.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDTMFToneChangeEvent.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCDataChannelEvent.idl:
- Modules/mediastream/RTCDtlsTransport.idl:
- Modules/mediastream/RTCDtlsTransportState.idl:
- Modules/mediastream/RTCEncodedAudioFrame.idl:
- Modules/mediastream/RTCEncodedVideoFrame.idl:
- Modules/mediastream/RTCError.idl:
- Modules/mediastream/RTCErrorEvent.idl:
- Modules/mediastream/RTCIceCandidate.idl:
- Modules/mediastream/RTCIceCandidateInit.idl:
- Modules/mediastream/RTCIceConnectionState.idl:
- Modules/mediastream/RTCIceGatheringState.idl:
- Modules/mediastream/RTCIceServer.idl:
- Modules/mediastream/RTCIceTransport.idl:
- Modules/mediastream/RTCIceTransportState.idl:
- Modules/mediastream/RTCOfferAnswerOptions.idl:
- Modules/mediastream/RTCOfferOptions.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl:
- Modules/mediastream/RTCPeerConnectionIceEvent.idl:
- Modules/mediastream/RTCPeerConnectionState.idl:
- Modules/mediastream/RTCPriorityType.idl:
- Modules/mediastream/RTCRtcpParameters.idl:
- Modules/mediastream/RTCRtpCapabilities.idl:
- Modules/mediastream/RTCRtpCodecCapability.idl:
- Modules/mediastream/RTCRtpCodecParameters.idl:
- Modules/mediastream/RTCRtpCodingParameters.idl:
- Modules/mediastream/RTCRtpContributingSource.idl:
- Modules/mediastream/RTCRtpDecodingParameters.idl:
- Modules/mediastream/RTCRtpEncodingParameters.idl:
- Modules/mediastream/RTCRtpFecParameters.idl:
- Modules/mediastream/RTCRtpHeaderExtensionParameters.idl:
- Modules/mediastream/RTCRtpParameters.idl:
- Modules/mediastream/RTCRtpReceiver+Transform.idl:
- Modules/mediastream/RTCRtpReceiver.idl:
- Modules/mediastream/RTCRtpRtxParameters.idl:
- Modules/mediastream/RTCRtpSFrameTransform.idl:
- Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
- Modules/mediastream/RTCRtpScriptTransform.idl:
- Modules/mediastream/RTCRtpScriptTransformer.idl:
- Modules/mediastream/RTCRtpSendParameters.idl:
- Modules/mediastream/RTCRtpSender+Transform.idl:
- Modules/mediastream/RTCRtpSender.idl:
- Modules/mediastream/RTCRtpSynchronizationSource.idl:
- Modules/mediastream/RTCRtpTransceiver.idl:
- Modules/mediastream/RTCRtpTransceiverDirection.idl:
- Modules/mediastream/RTCSctpTransport.idl:
- Modules/mediastream/RTCSctpTransportState.idl:
- Modules/mediastream/RTCSdpType.idl:
- Modules/mediastream/RTCSessionDescription.idl:
- Modules/mediastream/RTCSignalingState.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCTrackEvent.idl:
- Modules/mediastream/RTCTransformEvent.idl:
- Modules/model-element/HTMLModelElement.idl:
- Modules/paymentrequest/MerchantValidationEvent.idl:
- Modules/paymentrequest/PaymentAddress.idl:
- Modules/paymentrequest/PaymentMethodChangeEvent.idl:
- Modules/paymentrequest/PaymentRequest.idl:
- Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
- Modules/paymentrequest/PaymentResponse.idl:
- Modules/permissions/Navigator+Permissions.idl:
- Modules/permissions/PermissionDescriptor.idl:
- Modules/permissions/PermissionStatus.idl:
- Modules/permissions/Permissions.idl:
- Modules/pictureinpicture/Document+PictureInPicture.idl:
- Modules/pictureinpicture/DocumentOrShadowRoot+PictureInPicture.idl:
- Modules/pictureinpicture/EnterPictureInPictureEvent.idl:
- Modules/pictureinpicture/HTMLVideoElement+PictureInPicture.idl:
- Modules/pictureinpicture/PictureInPictureWindow.idl:
- Modules/push-api/PushEvent.idl:
- Modules/push-api/PushMessageData.idl:
- Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
- Modules/remoteplayback/HTMLMediaElement+RemotePlayback.idl:
- Modules/remoteplayback/RemotePlayback.idl:
- Modules/remoteplayback/RemotePlaybackAvailabilityCallback.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionAlternative.idl:
- Modules/speech/SpeechRecognitionErrorEvent.idl:
- Modules/speech/SpeechRecognitionEvent.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/storage/StorageManager.idl:
- Modules/streams/TransformStream.idl:
- Modules/streams/TransformStreamDefaultController.idl:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioParamMap.idl:
- Modules/webaudio/AudioProcessingEvent.idl:
- Modules/webaudio/AudioWorklet.idl:
- Modules/webaudio/AudioWorkletNode.idl:
- Modules/webaudio/AudioWorkletNodeOptions.idl:
- Modules/webaudio/BaseAudioContext.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/ChannelMergerNode.idl:
- Modules/webaudio/ChannelSplitterNode.idl:
- Modules/webaudio/ConstantSourceNode.idl:
- Modules/webaudio/ConstantSourceOptions.idl:
- Modules/webaudio/ConvolverNode.idl:
- Modules/webaudio/DelayNode.idl:
- Modules/webaudio/DynamicsCompressorNode.idl:
- Modules/webaudio/GainNode.idl:
- Modules/webaudio/IIRFilterNode.idl:
- Modules/webaudio/MediaElementAudioSourceNode.idl:
- Modules/webaudio/MediaStreamAudioDestinationNode.idl:
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PannerNode.idl:
- Modules/webaudio/PeriodicWave.idl:
- Modules/webaudio/StereoPannerNode.idl:
- Modules/webaudio/WaveShaperNode.idl:
- Modules/webauthn/AuthenticatorAssertionResponse.idl:
- Modules/webauthn/AuthenticatorAttestationResponse.idl:
- Modules/webauthn/AuthenticatorResponse.idl:
- Modules/webauthn/PublicKeyCredential.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/SQLError.idl:
- Modules/webdatabase/SQLResultSet.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/websockets/WebSocket.idl:
- Modules/webxr/Navigator+WebXR.idl:
- Modules/webxr/WebXRBoundedReferenceSpace.idl:
- Modules/webxr/WebXRFrame.idl:
- Modules/webxr/WebXRInputSource.idl:
- Modules/webxr/WebXRInputSourceArray.idl:
- Modules/webxr/WebXRLayer.idl:
- Modules/webxr/WebXRPose.idl:
- Modules/webxr/WebXRReferenceSpace.idl:
- Modules/webxr/WebXRRenderState.idl:
- Modules/webxr/WebXRRigidTransform.idl:
- Modules/webxr/WebXRSession.idl:
- Modules/webxr/WebXRSpace.idl:
- Modules/webxr/WebXRSystem.idl:
- Modules/webxr/WebXRView.idl:
- Modules/webxr/WebXRViewerPose.idl:
- Modules/webxr/WebXRViewport.idl:
- Modules/webxr/WebXRWebGLLayer.idl:
- Modules/webxr/XREnvironmentBlendMode.idl:
- Modules/webxr/XREye.idl:
- Modules/webxr/XRHandedness.idl:
- Modules/webxr/XRInputSourceEvent.idl:
- Modules/webxr/XRInputSourcesChangeEvent.idl:
- Modules/webxr/XRInteractionMode.idl:
- Modules/webxr/XRReferenceSpaceEvent.idl:
- Modules/webxr/XRReferenceSpaceType.idl:
- Modules/webxr/XRRenderStateInit.idl:
- Modules/webxr/XRSessionEvent.idl:
- Modules/webxr/XRSessionInit.idl:
- Modules/webxr/XRSessionMode.idl:
- Modules/webxr/XRTargetRayMode.idl:
- Modules/webxr/XRVisibilityState.idl:
- Modules/webxr/XRWebGLLayerInit.idl:
- accessibility/AccessibilityRole.idl:
- accessibility/AriaAttributes.idl:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalString):
- bindings/scripts/test/TestConditionalIncludes.idl:
- bindings/scripts/test/TestConditionallyReadWrite.idl:
- bindings/scripts/test/TestDefaultToJSON.idl:
- bindings/scripts/test/TestEnabledBySetting.idl:
- bindings/scripts/test/TestEnabledBySettingSupplemental.idl:
- bindings/scripts/test/TestEnabledForContext.idl:
- bindings/scripts/test/TestGlobalObject.idl:
- bindings/scripts/test/TestMixinInterface.idl:
- bindings/scripts/test/TestNamespaceObject.idl:
- bindings/scripts/test/TestNode.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestPartialNamespaceObject.idl:
- bindings/scripts/test/TestSupplemental.idl:
- css/CSSCounterStyleRule.idl:
- css/CSSPaintCallback.idl:
- css/CSSPaintSize.idl:
- css/CSSProperties.json:
- css/CSSRule.idl:
- css/DOMCSSCustomPropertyDescriptor.idl:
- css/DOMCSSNamespace+CSSNumericFactory.idl:
- css/DOMCSSNamespace+CSSPainting.idl:
- css/DOMCSSNamespace+CSSPropertiesandValues.idl:
- css/DOMCSSNamespace.idl:
- css/ElementCSSInlineStyle.idl:
- css/makeprop.pl:
- css/typedom/CSSKeywordValue.idl:
- css/typedom/CSSNumericValue.idl:
- css/typedom/CSSOMVariableReferenceValue.idl:
- css/typedom/CSSStyleImageValue.idl:
- css/typedom/CSSStyleValue.idl:
- css/typedom/CSSUnitValue.idl:
- css/typedom/CSSUnparsedValue.idl:
- css/typedom/StylePropertyMap.idl:
- css/typedom/StylePropertyMapReadOnly.idl:
- css/typedom/numeric/CSSMathInvert.idl:
- css/typedom/numeric/CSSMathMax.idl:
- css/typedom/numeric/CSSMathMin.idl:
- css/typedom/numeric/CSSMathNegate.idl:
- css/typedom/numeric/CSSMathProduct.idl:
- css/typedom/numeric/CSSMathSum.idl:
- css/typedom/numeric/CSSMathValue.idl:
- css/typedom/numeric/CSSNumericArray.idl:
- css/typedom/numeric/CSSNumericBaseType.idl:
- css/typedom/transform/CSSMatrixComponent.idl:
- css/typedom/transform/CSSPerspective.idl:
- css/typedom/transform/CSSRotate.idl:
- css/typedom/transform/CSSScale.idl:
- css/typedom/transform/CSSSkew.idl:
- css/typedom/transform/CSSSkewX.idl:
- css/typedom/transform/CSSSkewY.idl:
- css/typedom/transform/CSSTransformComponent.idl:
- css/typedom/transform/CSSTransformValue.idl:
- css/typedom/transform/CSSTranslate.idl:
- dom/Attr.idl:
- dom/BeforeLoadEvent.idl:
- dom/BroadcastChannel.idl:
- dom/DataTransfer.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document+Fullscreen.idl:
- dom/Document+StorageAccess.idl:
- dom/Document+UndoMananger.idl:
- dom/Element+Fullscreen.idl:
- dom/Element.idl:
- dom/ElementContentEditable.idl:
- dom/GlobalEventHandlers.idl:
- dom/IdleDeadline.idl:
- dom/InputEvent.idl:
- dom/TextDecoderStream.idl:
- dom/TextDecoderStreamDecoder.idl:
- dom/TextEncoderStream.idl:
- dom/TextEncoderStreamEncoder.idl:
- fileapi/File.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLAttachmentElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLDataListElement.idl:
- html/HTMLDialogElement.idl:
- html/HTMLElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMediaElement+AudioOutput.idl:
- html/HTMLMediaElement.idl:
- html/HTMLMenuItemElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOutputElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTextAreaElement.idl:
- html/ImageBitmap.idl:
- html/ImageData.idl:
- html/ImageDataSettings.idl:
- html/MediaEncryptedEvent.idl:
- html/OffscreenCanvas.idl:
- html/WebKitMediaKeyError.idl:
- html/canvas/CanvasPath.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/CanvasRenderingContext2DSettings.idl:
- html/canvas/ImageBitmapRenderingContext.idl:
- html/canvas/OffscreenCanvasRenderingContext2D.idl:
- html/canvas/PaintRenderingContext2D.idl:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLTransformFeedback.idl:
- html/canvas/WebGLVertexArrayObject.idl:
- html/track/AudioTrack.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/VideoTrack.idl:
- page/DOMSelection.idl:
- page/DOMWindow+RequestIdleCallback.idl:
- page/DOMWindow+VisualViewport.idl:
- page/IntersectionObserver.idl:
- page/IntersectionObserverEntry.idl:
- page/Navigator+IsLoggedIn.idl:
- page/NavigatorServiceWorker.idl:
- page/NavigatorShare.idl:
- page/NavigatorStorage.idl:
- page/PerformanceNavigationTiming.idl:
- page/PerformancePaintTiming.idl:
- page/PerformanceResourceTiming.idl:
- page/PerformanceServerTiming.idl:
- page/ResizeObserver.idl:
- page/ResizeObserverEntry.idl:
- page/UndoItem.idl:
- page/UndoManager.idl:
- page/VisualViewport.idl:
- page/WindowOrWorkerGlobalScope.idl:
- testing/FakeXRBoundsPoint.idl:
- testing/FakeXRButtonStateInit.idl:
- testing/FakeXRInputSourceInit.idl:
- testing/FakeXRRigidTransformInit.idl:
- testing/FakeXRViewInit.idl:
- testing/WebFakeXRDevice.idl:
- testing/WebFakeXRInputController.idl:
- testing/WebXRTest.idl:
- testing/XRSimulateUserActivationFunction.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorker.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/service/ExtendableEvent.idl:
- workers/service/ExtendableMessageEvent.idl:
- workers/service/FetchEvent.idl:
- workers/service/ServiceWorker.idl:
- workers/service/ServiceWorkerClient.idl:
- workers/service/ServiceWorkerClients.idl:
- workers/service/ServiceWorkerContainer.idl:
- workers/service/ServiceWorkerGlobalScope.idl:
- workers/service/ServiceWorkerRegistration.idl:
- workers/service/ServiceWorkerWindowClient.idl:
- worklets/PaintWorkletGlobalScope.idl: