Context Navigation

← Previous Period
Next Period →

Timeline

Nov 17, 2021:

11:58 PM Changeset in webkit [285986] by graouts@webkit.org

21 edits in trunk/Source

[Model] [macOS] Add support for interaction on macOS
https://bugs.webkit.org/show_bug.cgi?id=233105
<rdar://problem/80079386>

Reviewed by Wenson Hsieh.

Source/WebCore:

Capture mouse events after the mouse button is pressed over a <model> element,
unless preventDefault() is called, and forward those events through ModelPlayer
to the UI process.

Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::defaultEventHandler):
(WebCore::HTMLModelElement::dragDidStart):
(WebCore::HTMLModelElement::dragDidChange):
(WebCore::HTMLModelElement::dragDidEnd):

Modules/model-element/HTMLModelElement.h:
Modules/model-element/ModelPlayer.cpp:

(WebCore::ModelPlayer::supportsMouseInteraction):

Modules/model-element/ModelPlayer.h:
Modules/model-element/dummy/DummyModelPlayer.cpp:

(WebCore::DummyModelPlayer::handleMouseDown):
(WebCore::DummyModelPlayer::handleMouseMove):
(WebCore::DummyModelPlayer::handleMouseUp):

Modules/model-element/dummy/DummyModelPlayer.h:
Modules/model-element/scenekit/SceneKitModelPlayer.h:
Modules/model-element/scenekit/SceneKitModelPlayer.mm:

(WebCore::SceneKitModelPlayer::handleMouseDown):
(WebCore::SceneKitModelPlayer::handleMouseMove):
(WebCore::SceneKitModelPlayer::handleMouseUp):

Source/WebCore/PAL:

Add new ARQL SPIs.

pal/spi/mac/SystemPreviewSPI.h:

Source/WebKit:

Forward mouse events captured in the Web process to the matching ASVInlinePreview.

UIProcess/Cocoa/ModelElementControllerCocoa.mm:

(WebKit::ModelElementController::previewForUUID):
(WebKit::ModelElementController::handleMouseDownForModelElement):
(WebKit::ModelElementController::handleMouseMoveForModelElement):
(WebKit::ModelElementController::handleMouseUpForModelElement):

UIProcess/ModelElementController.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleMouseDownForModelElement):
(WebKit::WebPageProxy::handleMouseMoveForModelElement):
(WebKit::WebPageProxy::handleMouseUpForModelElement):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.h:
WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.mm:

(WebKit::ARKitInlinePreviewModelPlayerIOS::handleMouseDown):
(WebKit::ARKitInlinePreviewModelPlayerIOS::handleMouseMove):
(WebKit::ARKitInlinePreviewModelPlayerIOS::handleMouseUp):

WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h:
WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm:

(WebKit::ARKitInlinePreviewModelPlayerMac::supportsMouseInteraction):
(WebKit::ARKitInlinePreviewModelPlayerMac::handleMouseDown):
(WebKit::ARKitInlinePreviewModelPlayerMac::handleMouseMove):
(WebKit::ARKitInlinePreviewModelPlayerMac::handleMouseUp):

11:53 PM Changeset in webkit [285985] by youenn@apple.com

2 edits in trunk/Source/WebCore

Audio Rate Gets Messed up With Safari WebRTC and Bluetooth Switching
https://bugs.webkit.org/show_bug.cgi?id=232822
<rdar://problem/85418545>

Reviewed by Eric Carlson.

We usually create the unit, start the unit and stop the unit.
After that cycle, if we restart the unit, we expect the configuration to stay the same in WebProcess.
But, in LocalAudioMediaStreamTrackRendererInternalUnit::stop, we were disposing the audio unit and recreating it if necesary in LocalAudioMediaStreamTrackRendererInternalUnit::start.
If the sample rate changed, the new audio unit would use the new sample rate while WebProcess will use the old sample rate.
To prevent this, we now always reuse the same description to initialize the audio unit.

Manually tested.

platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp:

(WebCore::LocalAudioMediaStreamTrackRendererInternalUnit::createAudioUnitIfNeeded):

11:46 PM Changeset in webkit [285984] by youenn@apple.com

49 edits
1 add in trunk

Add support for more rvfc metadata
https://bugs.webkit.org/show_bug.cgi?id=233185

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https-expected.txt:

Source/WebCore:

Introduce VideoSampleMetadata that allows a RealtimeMediaSource to provide metadata for each video frame.
Fill VideoSampleMetadata for each source (capture and WebRTC)
Make use of VideoSampleMetadata in MediaPlayerPrivateMediaStreamAVFObjC to fill VideoFrameMetadata.
Enhance MediaPlayerPrivateAVFoundationObjC to fill in the newly exposed metadata in VideoFrameMetadata.
Update HTMLVideoElement to process the timestamp values as needed.

Covered by existing tests.

Headers.cmake:
Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
WebCore.xcodeproj/project.pbxproj:
html/HTMLVideoElement.cpp:
html/VideoFrameMetadata.idl:
platform/VideoSampleMetadata.h: Added.
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:
platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
platform/mediarecorder/MediaRecorderPrivateMock.cpp:
platform/mediarecorder/MediaRecorderPrivateMock.h:
platform/mediastream/RealtimeIncomingVideoSource.cpp:
platform/mediastream/RealtimeIncomingVideoSource.h:
platform/mediastream/RealtimeMediaSource.cpp:
platform/mediastream/RealtimeMediaSource.h:
platform/mediastream/RealtimeOutgoingVideoSource.h:
platform/mediastream/RealtimeVideoCaptureSource.cpp:
platform/mediastream/RealtimeVideoCaptureSource.h:
platform/mediastream/RealtimeVideoSource.cpp:
platform/mediastream/RealtimeVideoSource.h:
platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.h:
platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.cpp:
platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp:
platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.h:
platform/mediastream/mac/AVVideoCaptureSource.mm:
platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
testing/Internals.cpp:
testing/Internals.h:

Source/WebKit:

Make sure to receive frame metadats, send it through IPC to WebProcess and pipe it to media source observers.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
WebProcess/cocoa/RemoteCaptureSampleManager.h:
WebProcess/cocoa/RemoteCaptureSampleManager.messages.in:
WebProcess/cocoa/RemoteRealtimeDisplaySource.h:
WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
WebProcess/cocoa/RemoteRealtimeVideoSource.h:

LayoutTests:

platform/ios-wk2/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

11:18 PM Changeset in webkit [285983] by Nikita Vasilyev

5 edits
10 adds in trunk/Source/WebInspectorUI

Web Inspector: Add a swatch for align-content
https://bugs.webkit.org/show_bug.cgi?id=230065
<rdar://problem/82891361>

Reviewed by Devin Rousso.

Introduce an inline swatch for align-content, that shows icons for common align-content values:
start, center, end, space-between, space-around, space-evenly, and stretch.

UserInterface/Images/AlignmentCenter.svg: Added.
UserInterface/Images/AlignmentEnd.svg: Added.
UserInterface/Images/AlignmentSpaceAround.svg: Added.
UserInterface/Images/AlignmentSpaceBetween.svg: Added.
UserInterface/Images/AlignmentSpaceEvenly.svg: Added.
UserInterface/Images/AlignmentStart.svg: Added.
UserInterface/Images/AlignmentStretch.svg: Added.
UserInterface/Images/AlignmentUnknown.svg: Added.

UserInterface/Main.html:
UserInterface/Views/AlignmentEditor.css: Added.

(.alignment-editor .glyph):
(.alignment-editor .glyph:not(:last-child)):
(.alignment-editor .glyph:active):
(.alignment-editor .glyph.selected):
(.alignment-editor .glyph.selected + .glyph):
(.alignment-editor .glyph.selected:active):

UserInterface/Views/AlignmentEditor.js: Added.

(WI.AlignmentEditor):
(WI.AlignmentEditor.isAlignContentValue):
(WI.AlignmentEditor.prototype.get element):
(WI.AlignmentEditor.prototype.get value):
(WI.AlignmentEditor.prototype.set value):
(WI.AlignmentEditor.prototype._updateSelected):

UserInterface/Views/InlineSwatch.css:

(.inline-swatch:not(.read-only):matches(.bezier, .box-shadow, .spring, .variable, .alignment):hover):
(.inline-swatch:not(.read-only):matches(.bezier, .box-shadow, .spring, .variable, .alignment):active):
(.inline-swatch:is(.image, .alignment) > span):
(@media (prefers-color-scheme: dark) .inline-swatch.box-shadow > svg,):

UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch):
(WI.InlineSwatch.prototype.didDismissPopover):
(WI.InlineSwatch.prototype._updateSwatch):
(WI.InlineSwatch.prototype._valueEditorValueDidChange):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._replaceSpecialTokens):
(WI.SpreadsheetStyleProperty.prototype._addAlignmentTokens):

10:26 PM Changeset in webkit [285982] by commit-queue@webkit.org

3 edits
2 adds in trunk

When an "autofilled and viewable" field becomes empty, turn "autofilled and viewable" off
https://bugs.webkit.org/show_bug.cgi?id=233239

Patch by Ricky Mondello <Ricky Mondello> on 2021-11-17
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/input-autofilled-and-viewable.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer): Implement the fix.

testing/Internals.cpp:

(WebCore::Internals::setValueFromRenderer): Added.

testing/Internals.h: Declare a member function.

LayoutTests:

fast/forms/input-autofilled-and-viewable-expected.txt: Added.
fast/forms/input-autofilled-and-viewable.html: Added.

10:05 PM Changeset in webkit [285981] by mmaxfield@apple.com

123 edits
37 copies
38 adds in trunk/Source

[WebGPU] Add IPC message handlers for WebGPU
https://bugs.webkit.org/show_bug.cgi?id=233247

Reviewed by Dean Jackson.

Source/WebCore/PAL:

Add EnumTraits to the enum classes, so they can be serialized.

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:

(PAL::WebGPU::AdapterImpl::requestDevice):

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h:
pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.h:
pal/graphics/WebGPU/Impl/WebGPUTextureImpl.h:
pal/graphics/WebGPU/WebGPUAdapter.h:
pal/graphics/WebGPU/WebGPUAddressMode.h:
pal/graphics/WebGPU/WebGPUBlendFactor.h:
pal/graphics/WebGPU/WebGPUBlendOperation.h:
pal/graphics/WebGPU/WebGPUBufferBindingType.h:
pal/graphics/WebGPU/WebGPUBufferUsage.h:
pal/graphics/WebGPU/WebGPUCanvasCompositingAlphaMode.h:
pal/graphics/WebGPU/WebGPUCompareFunction.h:
pal/graphics/WebGPU/WebGPUCompilationMessageType.h:
pal/graphics/WebGPU/WebGPUComputePassTimestampLocation.h:
pal/graphics/WebGPU/WebGPUCullMode.h:
pal/graphics/WebGPU/WebGPUDeviceLostReason.h:
pal/graphics/WebGPU/WebGPUErrorFilter.h:
pal/graphics/WebGPU/WebGPUFeatureName.h:
pal/graphics/WebGPU/WebGPUFilterMode.h:
pal/graphics/WebGPU/WebGPUFrontFace.h:
pal/graphics/WebGPU/WebGPUImageCopyExternalImage.h:
pal/graphics/WebGPU/WebGPUIndexFormat.h:
pal/graphics/WebGPU/WebGPULoadOp.h:
pal/graphics/WebGPU/WebGPUMapMode.h:
pal/graphics/WebGPU/WebGPUPipelineStatisticName.h:
pal/graphics/WebGPU/WebGPUPowerPreference.h:
pal/graphics/WebGPU/WebGPUPredefinedColorSpace.h:
pal/graphics/WebGPU/WebGPUPrimitiveTopology.h:
pal/graphics/WebGPU/WebGPUQueryType.h:
pal/graphics/WebGPU/WebGPUQueue.h:
pal/graphics/WebGPU/WebGPURenderBundleEncoder.h:
pal/graphics/WebGPU/WebGPURenderPassEncoder.h:
pal/graphics/WebGPU/WebGPURenderPassTimestampLocation.h:
pal/graphics/WebGPU/WebGPUSamplerBindingType.h:
pal/graphics/WebGPU/WebGPUStencilOperation.h:
pal/graphics/WebGPU/WebGPUStorageTextureAccess.h:
pal/graphics/WebGPU/WebGPUStoreOp.h:
pal/graphics/WebGPU/WebGPUTexture.h:
pal/graphics/WebGPU/WebGPUTextureAspect.h:
pal/graphics/WebGPU/WebGPUTextureDimension.h:
pal/graphics/WebGPU/WebGPUTextureFormat.h:
pal/graphics/WebGPU/WebGPUTextureSampleType.h:
pal/graphics/WebGPU/WebGPUTextureViewDimension.h:
pal/graphics/WebGPU/WebGPUVertexFormat.h:
pal/graphics/WebGPU/WebGPUVertexStepMode.h:

Source/WebKit:

Add classes in GPUProcess/graphics/WebGPU to receive WebGPU's IPC messages.
Each one of these classes has an associated messages.in file. Each of these objects
holds a backing PAL::WebGPU object which is the actual implementation. The methods
that receive the IPC messages are currently unimplemented, but in a subsequent patch
they'll just forward on the calls to their backing PAL::WebGPU object.

This also adds serialization routines for all the structs in Shared/WebGPU.

No new tests because there is no behavior change (yet). We're very close, though!!!!

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
GPUProcess/graphics/WebGPU/RemoteAdapter.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp.

(WebKit::RemoteAdapter::RemoteAdapter):
(WebKit::RemoteAdapter::~RemoteAdapter):
(WebKit::RemoteAdapter::requestDevice):

GPUProcess/graphics/WebGPU/RemoteAdapter.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteAdapter.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteBindGroup::RemoteBindGroup):
(WebKit::RemoteBindGroup::~RemoteBindGroup):
(WebKit::RemoteBindGroup::setLabel):

GPUProcess/graphics/WebGPU/RemoteBindGroup.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteBindGroup.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteBindGroupLayout::RemoteBindGroupLayout):
(WebKit::RemoteBindGroupLayout::~RemoteBindGroupLayout):
(WebKit::RemoteBindGroupLayout::setLabel):

GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteBuffer.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteBuffer::RemoteBuffer):
(WebKit::RemoteBuffer::~RemoteBuffer):
(WebKit::RemoteBuffer::mapAsync):
(WebKit::RemoteBuffer::unmap):
(WebKit::RemoteBuffer::destroy):
(WebKit::RemoteBuffer::setLabel):

GPUProcess/graphics/WebGPU/RemoteBuffer.h: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h.
GPUProcess/graphics/WebGPU/RemoteBuffer.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteCommandBuffer.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteCommandBuffer::RemoteCommandBuffer):
(WebKit::RemoteCommandBuffer::~RemoteCommandBuffer):
(WebKit::RemoteCommandBuffer::setLabel):

GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteCommandBuffer.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp: Added.

(WebKit::RemoteCommandEncoder::RemoteCommandEncoder):
(WebKit::RemoteCommandEncoder::~RemoteCommandEncoder):
(WebKit::RemoteCommandEncoder::beginRenderPass):
(WebKit::RemoteCommandEncoder::beginComputePass):
(WebKit::RemoteCommandEncoder::copyBufferToBuffer):
(WebKit::RemoteCommandEncoder::copyBufferToTexture):
(WebKit::RemoteCommandEncoder::copyTextureToBuffer):
(WebKit::RemoteCommandEncoder::copyTextureToTexture):
(WebKit::RemoteCommandEncoder::fillBuffer):
(WebKit::RemoteCommandEncoder::pushDebugGroup):
(WebKit::RemoteCommandEncoder::popDebugGroup):
(WebKit::RemoteCommandEncoder::insertDebugMarker):
(WebKit::RemoteCommandEncoder::writeTimestamp):
(WebKit::RemoteCommandEncoder::resolveQuerySet):
(WebKit::RemoteCommandEncoder::finish):
(WebKit::RemoteCommandEncoder::setLabel):

GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h: Added.
GPUProcess/graphics/WebGPU/RemoteCommandEncoder.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp: Added.

(WebKit::RemoteComputePassEncoder::RemoteComputePassEncoder):
(WebKit::RemoteComputePassEncoder::~RemoteComputePassEncoder):
(WebKit::RemoteComputePassEncoder::setPipeline):
(WebKit::RemoteComputePassEncoder::dispatch):
(WebKit::RemoteComputePassEncoder::dispatchIndirect):
(WebKit::RemoteComputePassEncoder::beginPipelineStatisticsQuery):
(WebKit::RemoteComputePassEncoder::endPipelineStatisticsQuery):
(WebKit::RemoteComputePassEncoder::endPass):
(WebKit::RemoteComputePassEncoder::setBindGroup):
(WebKit::RemoteComputePassEncoder::pushDebugGroup):
(WebKit::RemoteComputePassEncoder::popDebugGroup):
(WebKit::RemoteComputePassEncoder::insertDebugMarker):
(WebKit::RemoteComputePassEncoder::setLabel):

GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h: Added.
GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteComputePipeline::RemoteComputePipeline):
(WebKit::RemoteComputePipeline::~RemoteComputePipeline):
(WebKit::RemoteComputePipeline::getBindGroupLayout):
(WebKit::RemoteComputePipeline::setLabel):

GPUProcess/graphics/WebGPU/RemoteComputePipeline.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteComputePipeline.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteDevice.cpp: Added.

(WebKit::RemoteDevice::RemoteDevice):
(WebKit::RemoteDevice::~RemoteDevice):
(WebKit::RemoteDevice::destroy):
(WebKit::RemoteDevice::createBuffer):
(WebKit::RemoteDevice::createTexture):
(WebKit::RemoteDevice::createSampler):
(WebKit::RemoteDevice::importExternalTexture):
(WebKit::RemoteDevice::createBindGroupLayout):
(WebKit::RemoteDevice::createPipelineLayout):
(WebKit::RemoteDevice::createBindGroup):
(WebKit::RemoteDevice::createShaderModule):
(WebKit::RemoteDevice::createComputePipeline):
(WebKit::RemoteDevice::createRenderPipeline):
(WebKit::RemoteDevice::createComputePipelineAsync):
(WebKit::RemoteDevice::createRenderPipelineAsync):
(WebKit::RemoteDevice::createCommandEncoder):
(WebKit::RemoteDevice::createRenderBundleEncoder):
(WebKit::RemoteDevice::createQuerySet):
(WebKit::RemoteDevice::pushErrorScope):
(WebKit::RemoteDevice::popErrorScope):
(WebKit::RemoteDevice::setLabel):

GPUProcess/graphics/WebGPU/RemoteDevice.h: Added.
GPUProcess/graphics/WebGPU/RemoteDevice.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteExternalTexture.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteExternalTexture::RemoteExternalTexture):
(WebKit::RemoteExternalTexture::~RemoteExternalTexture):
(WebKit::RemoteExternalTexture::setLabel):

GPUProcess/graphics/WebGPU/RemoteExternalTexture.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteExternalTexture.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteGPU.cpp: Copied from Source/WebKit/Shared/WebGPU/WebGPURenderPipelineDescriptor.h.

(WebKit::RemoteGPU::RemoteGPU):
(WebKit::RemoteGPU::~RemoteGPU):
(WebKit::RemoteGPU::requestAdapter):

GPUProcess/graphics/WebGPU/RemoteGPU.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUAdapter.h.
GPUProcess/graphics/WebGPU/RemoteGPU.messages.in: Added.
GPUProcess/graphics/WebGPU/RemotePipelineLayout.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemotePipelineLayout::RemotePipelineLayout):
(WebKit::RemotePipelineLayout::~RemotePipelineLayout):
(WebKit::RemotePipelineLayout::setLabel):

GPUProcess/graphics/WebGPU/RemotePipelineLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemotePipelineLayout.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteQuerySet.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteQuerySet::RemoteQuerySet):
(WebKit::RemoteQuerySet::~RemoteQuerySet):
(WebKit::RemoteQuerySet::destroy):
(WebKit::RemoteQuerySet::setLabel):

GPUProcess/graphics/WebGPU/RemoteQuerySet.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteQuerySet.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteQueue.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteQueue::RemoteQueue):
(WebKit::RemoteQueue::~RemoteQueue):
(WebKit::RemoteQueue::submit):
(WebKit::RemoteQueue::onSubmittedWorkDone):
(WebKit::RemoteQueue::writeBuffer):
(WebKit::RemoteQueue::writeTexture):
(WebKit::RemoteQueue::copyExternalImageToTexture):
(WebKit::RemoteQueue::setLabel):

GPUProcess/graphics/WebGPU/RemoteQueue.h: Added.
GPUProcess/graphics/WebGPU/RemoteQueue.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteRenderBundle.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteRenderBundle::RemoteRenderBundle):
(WebKit::RemoteRenderBundle::~RemoteRenderBundle):
(WebKit::RemoteRenderBundle::setLabel):

GPUProcess/graphics/WebGPU/RemoteRenderBundle.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteRenderBundle.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp: Added.

(WebKit::RemoteRenderBundleEncoder::RemoteRenderBundleEncoder):
(WebKit::RemoteRenderBundleEncoder::~RemoteRenderBundleEncoder):
(WebKit::RemoteRenderBundleEncoder::setPipeline):
(WebKit::RemoteRenderBundleEncoder::setIndexBuffer):
(WebKit::RemoteRenderBundleEncoder::setVertexBuffer):
(WebKit::RemoteRenderBundleEncoder::draw):
(WebKit::RemoteRenderBundleEncoder::drawIndexed):
(WebKit::RemoteRenderBundleEncoder::drawIndirect):
(WebKit::RemoteRenderBundleEncoder::drawIndexedIndirect):
(WebKit::RemoteRenderBundleEncoder::setBindGroup):
(WebKit::RemoteRenderBundleEncoder::pushDebugGroup):
(WebKit::RemoteRenderBundleEncoder::popDebugGroup):
(WebKit::RemoteRenderBundleEncoder::insertDebugMarker):
(WebKit::RemoteRenderBundleEncoder::finish):
(WebKit::RemoteRenderBundleEncoder::setLabel):

GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h: Added.
GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp: Added.

(WebKit::RemoteRenderPassEncoder::RemoteRenderPassEncoder):
(WebKit::RemoteRenderPassEncoder::~RemoteRenderPassEncoder):
(WebKit::RemoteRenderPassEncoder::setPipeline):
(WebKit::RemoteRenderPassEncoder::setIndexBuffer):
(WebKit::RemoteRenderPassEncoder::setVertexBuffer):
(WebKit::RemoteRenderPassEncoder::draw):
(WebKit::RemoteRenderPassEncoder::drawIndexed):
(WebKit::RemoteRenderPassEncoder::drawIndirect):
(WebKit::RemoteRenderPassEncoder::drawIndexedIndirect):
(WebKit::RemoteRenderPassEncoder::setBindGroup):
(WebKit::RemoteRenderPassEncoder::pushDebugGroup):
(WebKit::RemoteRenderPassEncoder::popDebugGroup):
(WebKit::RemoteRenderPassEncoder::insertDebugMarker):
(WebKit::RemoteRenderPassEncoder::setViewport):
(WebKit::RemoteRenderPassEncoder::setScissorRect):
(WebKit::RemoteRenderPassEncoder::setBlendConstant):
(WebKit::RemoteRenderPassEncoder::setStencilReference):
(WebKit::RemoteRenderPassEncoder::beginOcclusionQuery):
(WebKit::RemoteRenderPassEncoder::endOcclusionQuery):
(WebKit::RemoteRenderPassEncoder::beginPipelineStatisticsQuery):
(WebKit::RemoteRenderPassEncoder::endPipelineStatisticsQuery):
(WebKit::RemoteRenderPassEncoder::executeBundles):
(WebKit::RemoteRenderPassEncoder::endPass):
(WebKit::RemoteRenderPassEncoder::setLabel):

GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h: Added.
GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteRenderPipeline::RemoteRenderPipeline):
(WebKit::RemoteRenderPipeline::~RemoteRenderPipeline):
(WebKit::RemoteRenderPipeline::getBindGroupLayout):
(WebKit::RemoteRenderPipeline::setLabel):

GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteRenderPipeline.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteSampler.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteSampler::RemoteSampler):
(WebKit::RemoteSampler::~RemoteSampler):
(WebKit::RemoteSampler::setLabel):

GPUProcess/graphics/WebGPU/RemoteSampler.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteSampler.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteShaderModule::RemoteShaderModule):
(WebKit::RemoteShaderModule::~RemoteShaderModule):
(WebKit::RemoteShaderModule::compilationInfo):
(WebKit::RemoteShaderModule::setLabel):

GPUProcess/graphics/WebGPU/RemoteShaderModule.h: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h.
GPUProcess/graphics/WebGPU/RemoteShaderModule.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteTexture.cpp: Copied from Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp.

(WebKit::RemoteTexture::RemoteTexture):
(WebKit::RemoteTexture::~RemoteTexture):
(WebKit::RemoteTexture::createView):
(WebKit::RemoteTexture::destroy):
(WebKit::RemoteTexture::setLabel):

GPUProcess/graphics/WebGPU/RemoteTexture.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteTexture.messages.in: Added.
GPUProcess/graphics/WebGPU/RemoteTextureView.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUMapMode.h.

(WebKit::RemoteTextureView::RemoteTextureView):
(WebKit::RemoteTextureView::~RemoteTextureView):
(WebKit::RemoteTextureView::setLabel):

GPUProcess/graphics/WebGPU/RemoteTextureView.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUTexture.h.
GPUProcess/graphics/WebGPU/RemoteTextureView.messages.in: Added.
GPUProcess/graphics/WebGPU/WebGPUObjectHeap.cpp: Added.

(WebKit::WebGPU::ObjectHeap::ObjectHeap):
(WebKit::WebGPU::ObjectHeap::~ObjectHeap):
(WebKit::WebGPU::ObjectHeap::convertAdapterFromBacking):
(WebKit::WebGPU::ObjectHeap::convertBindGroupFromBacking):
(WebKit::WebGPU::ObjectHeap::convertBindGroupLayoutFromBacking):
(WebKit::WebGPU::ObjectHeap::convertBufferFromBacking):
(WebKit::WebGPU::ObjectHeap::convertCommandBufferFromBacking):
(WebKit::WebGPU::ObjectHeap::convertCommandEncoderFromBacking):
(WebKit::WebGPU::ObjectHeap::convertComputePassEncoderFromBacking):
(WebKit::WebGPU::ObjectHeap::convertComputePipelineFromBacking):
(WebKit::WebGPU::ObjectHeap::convertDeviceFromBacking):
(WebKit::WebGPU::ObjectHeap::convertGPUFromBacking):
(WebKit::WebGPU::ObjectHeap::convertPipelineLayoutFromBacking):
(WebKit::WebGPU::ObjectHeap::convertQuerySetFromBacking):
(WebKit::WebGPU::ObjectHeap::convertQueueFromBacking):
(WebKit::WebGPU::ObjectHeap::convertRenderBundleEncoderFromBacking):
(WebKit::WebGPU::ObjectHeap::convertRenderBundleFromBacking):
(WebKit::WebGPU::ObjectHeap::convertRenderPassEncoderFromBacking):
(WebKit::WebGPU::ObjectHeap::convertRenderPipelineFromBacking):
(WebKit::WebGPU::ObjectHeap::convertSamplerFromBacking):
(WebKit::WebGPU::ObjectHeap::convertShaderModuleFromBacking):
(WebKit::WebGPU::ObjectHeap::convertTextureFromBacking):
(WebKit::WebGPU::ObjectHeap::convertTextureViewFromBacking):

GPUProcess/graphics/WebGPU/WebGPUObjectHeap.h: Added.
GPUProcess/media/RemoteImageDecoderAVFProxy.h:
Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):
(headers_for_type):

Shared/WebGPU/WebGPUBindGroupDescriptor.h:

(WebKit::WebGPU::BindGroupDescriptor::encode const):
(WebKit::WebGPU::BindGroupDescriptor::decode):

Shared/WebGPU/WebGPUBindGroupEntry.h:

(WebKit::WebGPU::BindGroupEntry::encode const):
(WebKit::WebGPU::BindGroupEntry::decode):

Shared/WebGPU/WebGPUBindGroupLayoutDescriptor.h:

(WebKit::WebGPU::BindGroupLayoutDescriptor::encode const):
(WebKit::WebGPU::BindGroupLayoutDescriptor::decode):

Shared/WebGPU/WebGPUBindGroupLayoutEntry.h:

(WebKit::WebGPU::BindGroupLayoutEntry::encode const):
(WebKit::WebGPU::BindGroupLayoutEntry::decode):

Shared/WebGPU/WebGPUBlendComponent.h:

(WebKit::WebGPU::BlendComponent::encode const):
(WebKit::WebGPU::BlendComponent::decode):

Shared/WebGPU/WebGPUBlendState.h:

(WebKit::WebGPU::BlendState::encode const):
(WebKit::WebGPU::BlendState::decode):

Shared/WebGPU/WebGPUBufferBinding.h:

(WebKit::WebGPU::BufferBinding::encode const):
(WebKit::WebGPU::BufferBinding::decode):

Shared/WebGPU/WebGPUBufferBindingLayout.h:

(WebKit::WebGPU::BufferBindingLayout::encode const):
(WebKit::WebGPU::BufferBindingLayout::decode):

Shared/WebGPU/WebGPUBufferDescriptor.h:

(WebKit::WebGPU::BufferDescriptor::encode const):
(WebKit::WebGPU::BufferDescriptor::decode):

Shared/WebGPU/WebGPUCanvasConfiguration.h:

(WebKit::WebGPU::CanvasConfiguration::encode const):
(WebKit::WebGPU::CanvasConfiguration::decode):

Shared/WebGPU/WebGPUColor.h:

(WebKit::WebGPU::ColorDict::encode const):
(WebKit::WebGPU::ColorDict::decode):

Shared/WebGPU/WebGPUColorTargetState.h:

(WebKit::WebGPU::ColorTargetState::encode const):
(WebKit::WebGPU::ColorTargetState::decode):

Shared/WebGPU/WebGPUCommandBufferDescriptor.h:

(WebKit::WebGPU::CommandBufferDescriptor::encode const):
(WebKit::WebGPU::CommandBufferDescriptor::decode):

Shared/WebGPU/WebGPUCommandEncoderDescriptor.h:

(WebKit::WebGPU::CommandEncoderDescriptor::encode const):
(WebKit::WebGPU::CommandEncoderDescriptor::decode):

Shared/WebGPU/WebGPUCompilationMessage.h: Added.

(WebKit::WebGPU::CompilationMessage::encode const):
(WebKit::WebGPU::CompilationMessage::decode):

Shared/WebGPU/WebGPUComputePassDescriptor.h:

(WebKit::WebGPU::ComputePassDescriptor::encode const):
(WebKit::WebGPU::ComputePassDescriptor::decode):

Shared/WebGPU/WebGPUComputePassTimestampWrites.h:

(WebKit::WebGPU::ComputePassTimestampWrite::encode const):
(WebKit::WebGPU::ComputePassTimestampWrite::decode):

Shared/WebGPU/WebGPUComputePipelineDescriptor.h:

(WebKit::WebGPU::ComputePipelineDescriptor::encode const):
(WebKit::WebGPU::ComputePipelineDescriptor::decode):

Shared/WebGPU/WebGPUConvertFromBackingContext.h:
Shared/WebGPU/WebGPUDepthStencilState.h:

(WebKit::WebGPU::DepthStencilState::encode const):
(WebKit::WebGPU::DepthStencilState::decode):

Shared/WebGPU/WebGPUDeviceDescriptor.h:

(WebKit::WebGPU::DeviceDescriptor::encode const):
(WebKit::WebGPU::DeviceDescriptor::decode):

Shared/WebGPU/WebGPUError.h: Copied from Source/WebKit/Shared/WebGPU/WebGPUCommandEncoderDescriptor.h.
Shared/WebGPU/WebGPUExtent3D.h:

(WebKit::WebGPU::Extent3DDict::encode const):
(WebKit::WebGPU::Extent3DDict::decode):

Shared/WebGPU/WebGPUExternalTextureBindingLayout.h:

(WebKit::WebGPU::ExternalTextureBindingLayout::encode const):
(WebKit::WebGPU::ExternalTextureBindingLayout::decode):

Shared/WebGPU/WebGPUExternalTextureDescriptor.h:

(WebKit::WebGPU::ExternalTextureDescriptor::encode const):
(WebKit::WebGPU::ExternalTextureDescriptor::decode):

Shared/WebGPU/WebGPUFragmentState.h:

(WebKit::WebGPU::FragmentState::encode const):
(WebKit::WebGPU::FragmentState::decode):

Shared/WebGPU/WebGPUImageCopyBuffer.h:

(WebKit::WebGPU::ImageCopyBuffer::encode const):
(WebKit::WebGPU::ImageCopyBuffer::decode):

Shared/WebGPU/WebGPUImageCopyExternalImage.h:

(WebKit::WebGPU::ImageCopyExternalImage::encode const):
(WebKit::WebGPU::ImageCopyExternalImage::decode):

Shared/WebGPU/WebGPUImageCopyTexture.h:

(WebKit::WebGPU::ImageCopyTexture::encode const):
(WebKit::WebGPU::ImageCopyTexture::decode):

Shared/WebGPU/WebGPUImageCopyTextureTagged.h:

(WebKit::WebGPU::ImageCopyTextureTagged::encode const):
(WebKit::WebGPU::ImageCopyTextureTagged::decode):

Shared/WebGPU/WebGPUImageDataLayout.h:

(WebKit::WebGPU::ImageDataLayout::encode const):
(WebKit::WebGPU::ImageDataLayout::decode):

Shared/WebGPU/WebGPUMultisampleState.h:

(WebKit::WebGPU::MultisampleState::encode const):
(WebKit::WebGPU::MultisampleState::decode):

Shared/WebGPU/WebGPUObjectDescriptorBase.h:

(WebKit::WebGPU::ObjectDescriptorBase::encode const):
(WebKit::WebGPU::ObjectDescriptorBase::decode):

Shared/WebGPU/WebGPUOrigin2D.h:

(WebKit::WebGPU::Origin2DDict::encode const):
(WebKit::WebGPU::Origin2DDict::decode):

Shared/WebGPU/WebGPUOrigin3D.h:

(WebKit::WebGPU::Origin3DDict::encode const):
(WebKit::WebGPU::Origin3DDict::decode):

Shared/WebGPU/WebGPUOutOfMemoryError.h: Copied from Source/WebKit/Shared/WebGPU/WebGPUCommandBufferDescriptor.h.

(WebKit::WebGPU::OutOfMemoryError::encode const):
(WebKit::WebGPU::OutOfMemoryError::decode):

Shared/WebGPU/WebGPUPipelineDescriptorBase.h:

(WebKit::WebGPU::PipelineDescriptorBase::encode const):
(WebKit::WebGPU::PipelineDescriptorBase::decode):

Shared/WebGPU/WebGPUPipelineLayoutDescriptor.h:

(WebKit::WebGPU::PipelineLayoutDescriptor::encode const):
(WebKit::WebGPU::PipelineLayoutDescriptor::decode):

Shared/WebGPU/WebGPUPrimitiveState.h:

(WebKit::WebGPU::PrimitiveState::encode const):
(WebKit::WebGPU::PrimitiveState::decode):

Shared/WebGPU/WebGPUProgrammableStage.h:

(WebKit::WebGPU::ProgrammableStage::encode const):
(WebKit::WebGPU::ProgrammableStage::decode):

Shared/WebGPU/WebGPUQuerySetDescriptor.h:

(WebKit::WebGPU::QuerySetDescriptor::encode const):
(WebKit::WebGPU::QuerySetDescriptor::decode):

Shared/WebGPU/WebGPURenderBundleDescriptor.h:

(WebKit::WebGPU::RenderBundleDescriptor::encode const):
(WebKit::WebGPU::RenderBundleDescriptor::decode):

Shared/WebGPU/WebGPURenderBundleEncoderDescriptor.h:

(WebKit::WebGPU::RenderBundleEncoderDescriptor::encode const):
(WebKit::WebGPU::RenderBundleEncoderDescriptor::decode):

Shared/WebGPU/WebGPURenderPassColorAttachment.h:

(WebKit::WebGPU::RenderPassColorAttachment::encode const):
(WebKit::WebGPU::RenderPassColorAttachment::decode):

Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.h:

(WebKit::WebGPU::RenderPassDepthStencilAttachment::encode const):
(WebKit::WebGPU::RenderPassDepthStencilAttachment::decode):

Shared/WebGPU/WebGPURenderPassDescriptor.h:

(WebKit::WebGPU::RenderPassDescriptor::encode const):
(WebKit::WebGPU::RenderPassDescriptor::decode):

Shared/WebGPU/WebGPURenderPassLayout.h:

(WebKit::WebGPU::RenderPassLayout::encode const):
(WebKit::WebGPU::RenderPassLayout::decode):

Shared/WebGPU/WebGPURenderPassTimestampWrites.h:

(WebKit::WebGPU::RenderPassTimestampWrite::encode const):
(WebKit::WebGPU::RenderPassTimestampWrite::decode):

Shared/WebGPU/WebGPURenderPipelineDescriptor.h:

(WebKit::WebGPU::RenderPipelineDescriptor::encode const):
(WebKit::WebGPU::RenderPipelineDescriptor::decode):

Shared/WebGPU/WebGPURequestAdapterOptions.h:

(WebKit::WebGPU::RequestAdapterOptions::encode const):
(WebKit::WebGPU::RequestAdapterOptions::decode):

Shared/WebGPU/WebGPUSamplerBindingLayout.h:

(WebKit::WebGPU::SamplerBindingLayout::encode const):
(WebKit::WebGPU::SamplerBindingLayout::decode):

Shared/WebGPU/WebGPUSamplerDescriptor.h:

(WebKit::WebGPU::SamplerDescriptor::encode const):
(WebKit::WebGPU::SamplerDescriptor::decode):

Shared/WebGPU/WebGPUShaderModuleDescriptor.h:

(WebKit::WebGPU::ShaderModuleDescriptor::encode const):
(WebKit::WebGPU::ShaderModuleDescriptor::decode):

Shared/WebGPU/WebGPUStencilFaceState.h:

(WebKit::WebGPU::StencilFaceState::encode const):
(WebKit::WebGPU::StencilFaceState::decode):

Shared/WebGPU/WebGPUStorageTextureBindingLayout.h:

(WebKit::WebGPU::StorageTextureBindingLayout::encode const):
(WebKit::WebGPU::StorageTextureBindingLayout::decode):

Shared/WebGPU/WebGPUSupportedFeatures.h: Copied from Source/WebKit/Shared/WebGPU/WebGPUColor.h.

(WebKit::WebGPU::SupportedFeatures::encode const):
(WebKit::WebGPU::SupportedFeatures::decode):

Shared/WebGPU/WebGPUSupportedLimits.h: Added.

(WebKit::WebGPU::SupportedLimits::encode const):
(WebKit::WebGPU::SupportedLimits::decode):

Shared/WebGPU/WebGPUTextureBindingLayout.h:

(WebKit::WebGPU::TextureBindingLayout::encode const):
(WebKit::WebGPU::TextureBindingLayout::decode):

Shared/WebGPU/WebGPUTextureDescriptor.h:

(WebKit::WebGPU::TextureDescriptor::encode const):
(WebKit::WebGPU::TextureDescriptor::decode):

Shared/WebGPU/WebGPUTextureViewDescriptor.h:

(WebKit::WebGPU::TextureViewDescriptor::encode const):
(WebKit::WebGPU::TextureViewDescriptor::decode):

Shared/WebGPU/WebGPUValidationError.h: Copied from Source/WebKit/Shared/WebGPU/WebGPUColor.h.

(WebKit::WebGPU::ValidationError::encode const):
(WebKit::WebGPU::ValidationError::decode):

Shared/WebGPU/WebGPUVertexAttribute.h:

(WebKit::WebGPU::VertexAttribute::encode const):
(WebKit::WebGPU::VertexAttribute::decode):

Shared/WebGPU/WebGPUVertexBufferLayout.h:

(WebKit::WebGPU::VertexBufferLayout::encode const):
(WebKit::WebGPU::VertexBufferLayout::decode):

Shared/WebGPU/WebGPUVertexState.h:

(WebKit::WebGPU::VertexState::encode const):
(WebKit::WebGPU::VertexState::decode):

Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp:

(WebKit::WebGPU::RemoteAdapterProxy::requestDevice):

WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h:
WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp:

(WebKit::WebGPU::RemoteTextureProxy::createView):
(WebKit::WebGPU::RemoteTextureProxy::createView const): Deleted.

WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h:

9:38 PM Changeset in webkit [285980] by achristensen@apple.com

50 edits in trunk

Implement most of redirect and modify-headers action types
https://bugs.webkit.org/show_bug.cgi?id=233268

Reviewed by Tim Hatcher.

Source/WebCore:

This implements modify-headers and redirect actions except for extension-path and regex-substitution variants of redirecting,
which are big enough to be implemented in their own patch. In order to enable these actions, the WKContentRuleList needs to
be compiled with new SPI where you specify which schemes are allowed to be redirected to, and SPI in WKWebpagePreferences allows
addition of a set of patterns to specify which URLs are allowed to be modified. An empty set means no active actions are allowed,
which is the default, whereas a null set means all active actions are allowed.

I also made the parser a little bit stricter, such as only allowing valid ports, queries, and fragments.

Modules/websockets/WebSocketChannel.cpp:
contentextensions/ContentExtensionActions.cpp:

(WebCore::ContentExtensions::ModifyHeadersAction::operator== const):
(WebCore::ContentExtensions::ModifyHeadersAction::applyToRequest):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::applyToRequest):
(WebCore::ContentExtensions::RedirectAction::parse):
(WebCore::ContentExtensions::RedirectAction::operator== const):
(WebCore::ContentExtensions::RedirectAction::applyToRequest):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::serialize const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::deserialize):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::applyToURL const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::applyToURL const):

contentextensions/ContentExtensionActions.h:

(WebCore::ContentExtensions::VariantHasher::hash):
(WebCore::ContentExtensions::VectorHasher::hash):
(WTF::DefaultHash<WebCore::ContentExtensions::RedirectAction>::hash):
(WTF::DefaultHash<WebCore::ContentExtensions::RedirectAction>::equal):
(WTF::DefaultHash<WebCore::ContentExtensions::ModifyHeadersAction>::hash):
(WTF::DefaultHash<WebCore::ContentExtensions::ModifyHeadersAction>::equal):

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::compileRuleList):

contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

contentextensions/ContentExtensionError.h:
contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):

contentextensions/ContentExtensionParser.h:
contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForPingLoad):
(WebCore::ContentExtensions::applyResultsToRequest):

contentextensions/ContentRuleListResults.h:

(WebCore::ContentRuleListResults::Summary::decode):

css/StyleSheetContents.cpp:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setActiveContentRuleListActionsPatterns):
(WebCore::DocumentLoader::allowsActiveContentRuleListActionsForURL const):

loader/DocumentLoader.h:
platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::removeHTTPHeaderField):

platform/network/ResourceRequestBase.h:

Source/WebKit:

Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

Shared/WebsitePoliciesData.h:
UIProcess/API/APIContentRuleListStore.cpp:

(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::compileContentRuleList):

UIProcess/API/APIContentRuleListStore.h:
UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):
(API::WebsitePolicies::~WebsitePolicies): Deleted.

UIProcess/API/APIWebsitePolicies.h:
UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreCompile):

UIProcess/API/Cocoa/WKContentRuleListStore.mm:

(-[WKContentRuleListStore compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:allowedRedirectSchemes:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]): Deleted.

UIProcess/API/Cocoa/WKContentRuleListStorePrivate.h:
UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _setActiveContentRuleListActionsPatterns:]):
(-[WKWebpagePreferences _activeContentRuleListActionsPatterns]):

UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::remove):
Fix a regression from https://trac.webkit.org/changeset/276193/webkit
When fetching a resource with a forbidden port and a custom scheme and {mode:"no-cors"},
WebLoaderStrategy::remove is called with a resource that doesn't have an identifier.
My test hit this, so I moved the check to before the identifier is used.

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::InMemoryCompiledContentExtension::create):
(TestWebKitAPI::checkCompilerError):
(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:

(compileContentRuleList):
(navigationDelegateAllowingActiveActionsOnTestHost):
(TEST_F):

9:29 PM Changeset in webkit [285979] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Unified source build fix

Shared/GPUProcessConnectionParameters.h:

9:01 PM Changeset in webkit [285978] by ysuzuki@apple.com

3 edits
1 add in trunk

[JSC] TypedArray GetArrayLength should not use Reuse
https://bugs.webkit.org/show_bug.cgi?id=233299
rdar://85502079

Reviewed by Robin Morisset.

JSTests:

stress/get-array-length-reuse.js: Added.

(foo):

Source/JavaScriptCore:

We should not perform OSR exit after assigning a value to a reused register, otherwise,
OSR exit cannot recover the proper value. Now TypedArray GetArrayLength can perform
OSR exit after loading a length, so we should not use reused register for length.

dfg/DFGSpeculativeJIT.cpp:

8:04 PM Changeset in webkit [285977] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS][GPUP] Add access to logging service for root
https://bugs.webkit.org/show_bug.cgi?id=233300
<rdar://85529760>

Reviewed by Brent Fulgham.

Access to logging service is required for root in the GPU process on macOS.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

7:54 PM Changeset in webkit [285976] by Cameron McCormack

2 edits in trunk/Source/WebKit

Protect against null SharedBitmaps when starting a drag
https://bugs.webkit.org/show_bug.cgi?id=233217
<rdar://problem/85478309>

Reviewed by Wenson Hsieh.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::startDrag):

7:46 PM Changeset in webkit [285975] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: assertion failures in WI.GridOverlayConfigurationDiagnosticEventRecorder
https://bugs.webkit.org/show_bug.cgi?id=233298

Reviewed by Patrick Angle.

UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:

(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):

7:28 PM Changeset in webkit [285974] by Devin Rousso

6 edits in trunk/Source/WebInspectorUI

Web Inspector: allow left docking when in LTR and right docking when in RTL
https://bugs.webkit.org/show_bug.cgi?id=233294

Reviewed by Patrick Angle.

Some developers prefer docking to the left even when in LTR and/or docking to the right when
in RTL. There's no technical reason to disallow this, so let's make it possible.

UserInterface/Base/Main.js:

(WI.contentLoaded):
(WI.contentLoaded.addDockButton): Added.
(WI.contentLoaded.addDockLeftButton): Added.
(WI.contentLoaded.addDockRightButton): Added.
(WI._updateDockNavigationItems):
(WI._updateTabBarDividers):
(WI.setLayoutDirection):
Instead of having a single _dockToSideTabBarButton that looks at the layout direction to
decide its image, tooltip, and action, split it into two distinct _dockLeftTabBarButton
and _dockRightTabBarButton buttons that are both always visible (unless Web Inspector is
already in the corresponding docking state).

UserInterface/Images/DockBottom.svg:
UserInterface/Images/DockLeft.svg:
UserInterface/Images/DockRight.svg:

Fill in the area representing Web Inspector and make it a bit smaller so it's not as heavy.

Localizations/en.lproj/localizedStrings.js:

7:13 PM Changeset in webkit [285973] by Wenson Hsieh

26 edits in trunk/Source

[Live Text] Plumb an identifier string through ChromeClient::requestTextRecognition()
https://bugs.webkit.org/show_bug.cgi?id=233210

Reviewed by Dean Jackson.

Source/WebCore:

See WebKit/ChangeLog for more details.

accessibility/AXImage.cpp:

(WebCore::AXImage::imageOverlayElements):

page/ChromeClient.h:

(WebCore::ChromeClient::requestTextRecognition):

page/ImageAnalysisQueue.cpp:

(WebCore::ImageAnalysisQueue::resumeProcessing):

testing/Internals.cpp:

(WebCore::Internals::requestTextRecognition):

Source/WebCore/PAL:

Add another WebKitAdditions extension point.

pal/spi/cocoa/VisionKitCoreSPI.h:

Source/WebKit:

Add an optional (i.e. null-by-default) identifier string to the requestTextRecognition() WebKit client hook,
and call into a new helper function in TextRecognitionUtilities.h, that's implemented in WebKitAdditions (with
an empty stub in open source code).

See corresponding radar for more information.

Platform/cocoa/TextRecognitionUtilities.h:
Platform/cocoa/TextRecognitionUtilities.mm:

(WebKit::requestImageAnalysisWithIdentifier):

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::requestTextRecognition):

UIProcess/PageClient.h:

(WebKit::PageClient::requestTextRecognition):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestTextRecognition):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestTextRecognition):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]):
(-[WKContentView requestTextRecognition:imageData:completionHandler:]): Deleted.

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestTextRecognition):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestTextRecognition):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestTextRecognition):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::requestTextRecognition):

7:05 PM Changeset in webkit [285972] by Takashi.Komori@sony.com

2 edits in trunk/Source/WebCore

[Curl] Remove unnecessary option setting
https://bugs.webkit.org/show_bug.cgi?id=233249

Reviewed by Fujii Hironori.

Remove setting CURLPIPE_MULTIPLEX option.
The option is enabled by default since curl 7.62.0 [1].

[1] https://curl.se/libcurl/c/curl_multi_setopt.html

No new tests, covered by existing tests.

platform/network/curl/CurlContext.cpp:

(WebCore::CurlMultiHandle::CurlMultiHandle):

6:47 PM Changeset in webkit [285971] by sbarati@apple.com

3 edits
1 add in trunk

Run the memmove fast path in JSGenericTypedArrayView<Adaptor>::set when using a combination of Uint8 and Uint8Clamped
https://bugs.webkit.org/show_bug.cgi?id=233271
<rdar://85259288>

Reviewed by Yusuke Suzuki.

JSTests:

microbenchmarks/typed-array-set-uint8-and-uint8clamped.js: Added.

Source/JavaScriptCore:

We have a fast path for running memmove when both the thing being
copied from and the thing being copied to have the same typed array
type. However, when copying from a Uint8Array into a Uint8ClampedArray,
or vice versa, we were going down the slow path. In this case,
we can still take the fast path, since we're guaranteed that storing
into a Uint8ClampedArray from a Uint8Array will never actually need
to clamp values. And when storing from a Uint8ClampedArray into a
Uint8Array, the values can trivially be copied over.

This patch is a 100x speedup on the attached microbenchmark.

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::set):

6:29 PM Changeset in webkit [285970] by Alan Coon

2 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285959. rdar://problem/85529891

[macOS] Add message filter guard in the GPU process' sandbox
https://bugs.webkit.org/show_bug.cgi?id=233282
<rdar://85514428>

Reviewed by Brent Fulgham.

Add message filter guard in the GPU process' sandbox.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:29 PM Changeset in webkit [285969] by Alan Coon

3 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285869. rdar://problem/85529891

[macOS][GPUP] Add telemetry for syscalls
https://bugs.webkit.org/show_bug.cgi?id=232888
<rdar://problem/85207011>

Reviewed by Brent Fulgham.

Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Scripts/process-entitlements.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:29 PM Changeset in webkit [285968] by Alan Coon

3 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285809. rdar://problem/85529891

Unreviewed, reverting r285774.
https://bugs.webkit.org/show_bug.cgi?id=233136

Introduced GPUP crash on some configurations

Reverted changeset:

"[macOS][GPUP] Add telemetry for syscalls"
https://bugs.webkit.org/show_bug.cgi?id=232888
https://commits.webkit.org/r285774

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:08 PM Changeset in webkit [285967] by wilander@apple.com

17 edits
3 adds in trunk

PCM: Add capability for click destination to fire triggering event without cross-site requests to the click source
https://bugs.webkit.org/show_bug.cgi?id=233173
<rdar://79426605>

Reviewed by Alex Christensen.

Source/WebCore:

This patch enables click destination sites a non-JavaScript way to fire triggering
events without a requirement to make cross-site requests to source sites. This is
referred to as a "same-site pixel API" and has been discussed in W3C Privacy CG:
https://github.com/privacycg/private-click-measurement/issues/71

The reason why some merchants want such an "API" is reluctance to deploy new
JavaScript on their sites. In some industries it's even a compliance issue. Legacy
"pixels" are however accepted and so a same-site "pixel" can work for them.

Test: http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

This change is because of clarification in naming:

attributionReportSourceURL to attributionReportClickSourceURL

loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::parseAttributionRequestQuery):

New function that parses out query string parameters.

(WebCore::PrivateClickMeasurement::parseAttributionRequest):

Now calls the new PrivateClickMeasurement::parseAttributionRequestQuery()
which handles data coming in in query parameters, in this case
the new parameter "attributionSource."

(WebCore::PrivateClickMeasurement::attributionReportClickSourceURL const):

New name.

(WebCore::PrivateClickMeasurement::attributionReportClickDestinationURL const):

New name.

(WebCore::PrivateClickMeasurement::attributionReportJSON const):

Now uses the constant privateClickMeasurementVersion.

(WebCore::PrivateClickMeasurement::tokenSignatureJSON const):

Now uses the constant privateClickMeasurementVersion.

(WebCore::PrivateClickMeasurement::attributionReportSourceURL const): Deleted.

Renamed attributionReportClickSourceURL.

(WebCore::PrivateClickMeasurement::attributionReportAttributeOnURL const): Deleted.

Renamed attributionReportClickDestinationURL.

loader/PrivateClickMeasurement.h:

(WebCore::PrivateClickMeasurement::sourceSecretToken const):

New name.

(WebCore::PrivateClickMeasurement::AttributionTriggerData::encode const):
(WebCore::PrivateClickMeasurement::AttributionTriggerData::decode):

Encoding and decoding of the new field sourceRegistrableDomain.

(WebCore::PrivateClickMeasurement::sourceUnlinkableToken const): Deleted.

Renamed sourceSecretToken.
Note that it was always the secret token used, just bad renaming earlier.

Source/WebKit:

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::insertPrivateClickMeasurement):

These changes are just a correction of a function name:

sourceUnlinkableToken() to sourceSecretToken() Note that it was always the secret token used, just bad renaming earlier.

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp:

(WebKit::PrivateClickMeasurementManager::handleAttribution):

Now checks if the incoming WebCore::PrivateClickMeasurement::AttributionTriggerData
carries a sourceRegistrableDomain. If so, it accepts that domain as the source site
for attribution if the triggering event was same-site as the first-party.

(WebKit::PrivateClickMeasurementManager::attribute):
(WebKit::PrivateClickMeasurementManager::fireConversionRequest):

These changes are just a correction of a function name:

sourceUnlinkableToken() to sourceSecretToken() Note that it was always the secret token used, just bad renaming earlier.

(WebKit::PrivateClickMeasurementManager::fireConversionRequestImpl):

These changes are because of clarification in naming:

attributionReportSourceURL to attributionReportClickSourceURL
attributionReportAttributeOnURL to attributionReportClickDestinationURL

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h:
NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.cpp:

(WebKit::PCM::Store::attributePrivateClickMeasurement):

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.h:

Source/WTF:

wtf/URL.cpp:

(WTF::queryParameters):

New convenience getter.

wtf/URL.h:

Tools:

These changes are just a correction of a function name:
sourceUnlinkableToken() to sourceSecretToken()

TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/cocoa/PrivateClickMeasurementCocoa.mm:

(TestWebKitAPI::TEST):

LayoutTests:

http/tests/privateClickMeasurement/resources/redirectToConversionWithAttributionSource.py: Added.
http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-expected.txt: Added.
http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive.html: Added.

4:38 PM Changeset in webkit [285966] by Wenson Hsieh

2 edits in trunk/Source/WebKit

Add a Translation WebKit2 logging category
https://bugs.webkit.org/show_bug.cgi?id=233286

Reviewed by Tim Horton.

Add the new category.

Platform/Logging.h:

4:10 PM Changeset in webkit [285965] by J Pascoe

3 edits in trunk/Source/WebKit

[WebAuthn] Add SPI for makeCredential / getAssertion using clientDataHash
https://bugs.webkit.org/show_bug.cgi?id=233216
<rdar://problem/85476386>

Reviewed by Brent Fulgham.

In order to avoid needing to make and coordinate changes to ASC to support new fields or changes
within ClientDataJSON and to maintain a single source of truth, calls to ASC from WebKit
will contain a precomputed ClientDataHash. This change creates new SPIs that will be called
from ASC using the ClientDataHash.

UIProcess/API/Cocoa/_WKAuthenticatorResponse.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(-[_WKWebAuthenticationPanel makeCredentialWithClientDataHash:options:completionHandler:]):
(-[_WKWebAuthenticationPanel getAssertionWithClientDataHash:options:completionHandler:]):
New functions to take in ClientDataHash instead of the data needed to construct it.

3:55 PM Changeset in webkit [285964] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Momentum animator: Short scrolls are too far, medium scrolls aren't far enough
https://bugs.webkit.org/show_bug.cgi?id=233272
<rdar://problem/85472653>

Reviewed by Simon Fraser.

platform/mac/ScrollingEffectsController.mm:

(WebCore::adjustedVelocity):
(WebCore::ScrollingEffectsController::handleWheelEvent):
Attempt to apply a empirically-derived curve to the initial velocity
to fit the distance of a normal momentum scroll.

3:53 PM Changeset in webkit [285963] by Ryan Haddad

2 edits in trunk/Tools

ASSERT NOT REACHED under WebKit::Daemon::ConnectionToMachService seen with TestWebKitAPI.WebPushD.BasicCommunication and PermissionManagement
https://bugs.webkit.org/show_bug.cgi?id=232857

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: Fix number in version check.

3:46 PM Changeset in webkit [285962] by Ryan Haddad

2 edits in trunk/Tools

[Monterey] TestWebKitAPI.PrivateClickMeasurement.Daemon* tests timing out: Failed to connect to mach service org.webkit.pcmtestdaemon.service
https://bugs.webkit.org/show_bug.cgi?id=232890

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:

(TestWebKitAPI::TEST): Disable tests for Monterey.

3:43 PM Changeset in webkit [285961] by commit-queue@webkit.org

2 edits in trunk/Tools

Enable adattributiond testing on iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=233285

Patch by Alex Christensen <achristensen@webkit.org> on 2021-11-17
Reviewed by Brady Eidson.

TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:

(TestWebKitAPI::testDaemonPList):
(TestWebKitAPI::cleanUpDaemon):
(TestWebKitAPI::TEST):

3:35 PM Changeset in webkit [285960] by Ryan Haddad

2 edits in trunk/Tools

ASSERT NOT REACHED under WebKit::Daemon::ConnectionToMachService seen with TestWebKitAPI.WebPushD.BasicCommunication and PermissionManagement
https://bugs.webkit.org/show_bug.cgi?id=232857

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::TEST): Disable the tests for Monterey.

3:12 PM Changeset in webkit [285959] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add message filter guard in the GPU process' sandbox
https://bugs.webkit.org/show_bug.cgi?id=233282
<rdar://85514428>

Reviewed by Brent Fulgham.

Add message filter guard in the GPU process' sandbox.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

3:07 PM Changeset in webkit [285958] by Russell Epstein

1 copy in tags/Safari-612.3.6.1.4

Tag Safari-612.3.6.1.4.

3:04 PM Changeset in webkit [285957] by Ryan Haddad

2 edits in trunk/Tools

[macOS Debug] TestWebKitAPI.WKInspectorExtensionDelegate.InspectedPageNavigatedCallbacks is timing out
https://bugs.webkit.org/show_bug.cgi?id=231847

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/WKInspectorExtensionDelegate.mm: Disable test in the debug configuration.

2:55 PM Changeset in webkit [285956] by Alan Bujtas

8 edits in trunk/Source/WebCore

[LFC][IFC] Introduce enum class IntrinsicWidthMode
https://bugs.webkit.org/show_bug.cgi?id=233277

Reviewed by Antti Koivisto.

This is in preparation for being able to apply different glyph hanging behavior for min and max intrinsic width computation.

layout/formattingContexts/FormattingConstraints.h:
layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::InlineContentBreaker):

layout/formattingContexts/inline/InlineContentBreaker.h:

(WebCore::Layout::InlineContentBreaker::isInIntrinsicWidthMode const):

layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/formattingContexts/inline/InlineFormattingContext.h:
layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::placeInlineContent):

layout/formattingContexts/inline/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::intrinsicWidthMode const):
(WebCore::Layout::LineBuilder::isInIntrinsicWidthMode const):

2:51 PM Changeset in webkit [285955] by ysuzuki@apple.com

7 edits
2 adds in trunk/Source/JavaScriptCore

[JSC] Revise JSON.parse atomize policy
https://bugs.webkit.org/show_bug.cgi?id=233231

Reviewed by Mark Lam.

This patch improves JSON.parse performance by the following two changes.

Introduce JSONAtomStringCache. It is inspired from HTMLAtomStringCache. It offers cheap fixed-sized cache stored in VM. Since it is in VM, we do not need to clear it every time we call JSON.parse. We clear this cache when full GC happens. It contributes to flight-todomvc-json-parse by 5%.
Do not atomize long string. Profiling of JSON.parse said that most of time is used for atomizing of Strings. There is a tradeoff that, atomizing strings can reduce duplicate string allocations, but it has a performance penalty. V8 limits atomizing for <= 10 length strings, and SpiderMonkey does not atomize strings. In this patch, we aligned our atomizing policy to V8, so we do not atomize strings if the length is longer than 10. It contributes to flight-todomvc-json-parse by 50%.

Many microbenchmarks show the improvement.

ToT Patched

json-parse-object-reviver-same-value 78.2683+-0.9598 77.7784+-0.9488
vanilla-es2015-babel-webpack-todomvc-json-parse

99.9129+-0.5508 ^{85.8160+-0.8721} definitely 1.1643x faster

json-parse-array-reviver-same-value 63.5891+-0.8066 63.2895+-0.7336
flight-todomvc-json-parse 52.4230+-0.4474 ^{34.1159+-0.2378} definitely 1.5366x faster
json-parse-object-reviver 80.8417+-0.5042 80.6393+-0.8087
json-parse-leaf-object 51.6836+-0.6754 ^{46.8983+-0.1578} definitely 1.1020x faster
vanilla-es2015-todomvc-json-parse 100.5916+-0.9399 ^{85.9522+-0.8470} definitely 1.1703x faster
vanilla-todomvc-json-parse 76.4518+-0.4341 ^{64.2318+-0.7621} definitely 1.1902x faster
json-parse-array-reviver 76.1276+-0.8529 75.9747+-0.9002

And Speedometer2 shows 0.8% improvement.

----------------------------------------------------------------------------------------------------------------------------------
| subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |
----------------------------------------------------------------------------------------------------------------------------------
| Elm-TodoMVC |109.046667 |108.546667 |0.995415 | 0.197186 |
| VueJS-TodoMVC |21.813333 |21.566667 |0.988692 | 0.313141 |
| EmberJS-TodoMVC |117.796667 |118.086667 |1.002462 | 0.558244 |
| Flight-TodoMVC |64.273333 |62.260000 |0.968675 | 0.000000 (significant) |
| BackboneJS-TodoMVC |42.856667 |42.863333 |1.000156 | 0.975025 |
| Preact-TodoMVC |16.326667 |16.673333 |1.021233 | 0.298674 |
| AngularJS-TodoMVC |123.146667 |122.413333 |0.994045 | 0.160282 |
| Inferno-TodoMVC |57.510000 |57.533333 |1.000406 | 0.947767 |
| Vanilla-ES2015-TodoMVC |61.133333 |59.200000 |0.968375 | 0.000000 (significant) |
| Angular2-TypeScript-TodoMVC |38.863333 |38.963333 |1.002573 | 0.860359 |
| VanillaJS-TodoMVC |51.296667 |49.423333 |0.963480 | 0.000000 (significant) |
| jQuery-TodoMVC |210.933333 |210.596667 |0.998404 | 0.590132 |
| EmberJS-Debug-TodoMVC |326.093333 |324.890000 |0.996310 | 0.156955 |
| React-TodoMVC |81.113333 |81.360000 |1.003041 | 0.335615 |
| React-Redux-TodoMVC |132.560000 |132.256667 |0.997712 | 0.306072 |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |60.073333 |59.026667 |0.982577 | 0.000883 (significant) |
----------------------------------------------------------------------------------------------------------------------------------
a mean = 280.29390
b mean = 282.51413
pValue = 0.0000083325
(Bigger means are better.)
1.008 times better
Results ARE significant

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.cpp:

(JSC::Heap::finalize):

runtime/JSONAtomStringCache.h: Added.

(JSC::JSONAtomStringCache::makeIdentifier):
(JSC::JSONAtomStringCache::clear):
(JSC::JSONAtomStringCache::cacheSlot):
(JSC::JSONAtomStringCache::cache):

runtime/JSONAtomStringCacheInlines.h: Added.

(JSC::JSONAtomStringCache::make):
(JSC::JSONAtomStringCache::vm const):

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::makeIdentifier):
(JSC::LiteralParser<CharType>::makeJSString):
(JSC::LiteralParser<CharType>::parsePrimitiveValue):
(JSC::LiteralParser<CharType>::parse):

runtime/LiteralParser.h:
runtime/VM.h:

2:28 PM Changeset in webkit [285954] by Chris Dumez

22 edits in trunk

Web Locks API does get enabled in Service Workers when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=233273

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing in service workers.

web-platform-tests/web-locks/acquire.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/clientids.tentative.https-expected.txt:
web-platform-tests/web-locks/held.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/idlharness.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/ifAvailable.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/lock-attributes.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/mode-exclusive.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/mode-mixed.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/mode-shared.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/query-empty.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/resource-names.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/secure-context.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/signal.tentative.https.any.serviceworker-expected.txt:
web-platform-tests/web-locks/steal.tentative.https.any.serviceworker-expected.txt:

Source/WebCore:

Use RuntimeEnabledFeatures to back the Web Lock API since regular settings do not get
properly propagated to service workers at the moment.

No new tests, rebaselined existing ones.

Modules/web-locks/NavigatorLocks.idl:
Modules/web-locks/WebLock.idl:
Modules/web-locks/WebLockManager.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebLocksAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webLocksAPIEnabled const):

Source/WTF:

Use RuntimeEnabledFeatures to back the Web Lock API since regular settings do not get
properly propagated to service workers at the moment.

Scripts/Preferences/WebPreferencesExperimental.yaml:

2:21 PM Changeset in webkit [285953] by timothy_horton@apple.com

10 edits in trunk/Source

Momentum animator sometimes starts the animation at a very high velocity
https://bugs.webkit.org/show_bug.cgi?id=233245
<rdar://problem/85307115>

Reviewed by Simon Fraser.

Source/WebCore:

page/WheelEventDeltaFilter.cpp:

(WebCore::WheelEventDeltaFilter::eventCopyWithVelocity const):

page/WheelEventDeltaFilter.h:
platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::copyWithVelocity const):
Make it possible to ask the delta filter to only add velocity data without filtering deltas.
We should later make ScrollingEffectsController talk directly to the
WheelEventDeltaFilter to get the velocity, but that requires a great
deal of scrolling thread plumbing.

page/mac/WheelEventDeltaFilterMac.h:
page/mac/WheelEventDeltaFilterMac.mm:

(WebCore::WheelEventDeltaFilterMac::updateFromEvent):
Factor updateCurrentVelocityFromEvent out.
Update the current velocity for momentum begin phase events as well.

(WebCore::WheelEventDeltaFilterMac::updateCurrentVelocityFromEvent):

platform/ScrollingEffectsController.h:
platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::handleWheelEvent):
Start the momentum animation with the velocity provided by the momentum
begin phase, instead of a potentially incorrect delta from an earlier change phase.

Source/WebKit:

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
Ensure that wheel events always have velocities attached, even for
events that don't go through the delta filter.

1:35 PM Changeset in webkit [285952] by dino@apple.com

4 edits in trunk/Source/ThirdParty/ANGLE

ANGLE build failure - sprintf is deprecated
https://bugs.webkit.org/show_bug.cgi?id=233279

Reviewed by Wenson Hsieh.

Replace sprintf with snprintf.

src/compiler/translator/TranslatorMetalDirect/IdGen.cpp:

(IdGen::createNewName):

src/compiler/translator/TranslatorMetalDirect/ModifyStruct.cpp:
src/compiler/translator/TranslatorMetalDirect/SymbolEnv.cpp:

(SymbolEnv::TemplateName::fullName const):

1:03 PM Changeset in webkit [285951] by Russell Epstein

8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7613.4.1

12:33 PM Changeset in webkit [285950] by Patrick Angle

2 edits in trunk

Update my (Patrick Angle's) status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=233270

Unreviewed.

Update my status to reviewer, as well as drive-by updates to set my github name and update the area of
expertise.

metadata/contributors.json:

12:22 PM Changeset in webkit [285949] by Wenson Hsieh

14 edits
2 adds in trunk/Source

Add a helper class to coordinate batch analysis of images
https://bugs.webkit.org/show_bug.cgi?id=233075

Reviewed by Dean Jackson.

Source/WebCore:

Introduce ImageAnalysisQueue, which will collect suitable image elements in the main document and coordinate
image analysis tasks for up to some (fixed, but easily configurable) maximum number of simultaneous pending
tasks. See below for more details.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
page/ImageAnalysisQueue.cpp: Added.

(WebCore::ImageAnalysisQueue::ImageAnalysisQueue):
(WebCore::ImageAnalysisQueue::enqueueAllImages):

Iterate through all image elements on the page with cached images, and add them as image analysis tasks to the
task queue as long as they are not tiny. Automatically start processing queued tasks afterwards (see below).

(WebCore::ImageAnalysisQueue::resumeProcessing):

Run the main processing loop of the task queue; while there are tasks remaining, push up to 5 images to the
client layer for image analysis at the same time, until there are no more queued tasks.

(WebCore::ImageAnalysisQueue::clear):

page/ImageAnalysisQueue.h: Added.

Introduce the new class.

page/Page.cpp:

(WebCore::Page::imageOverlayController):

Drive-by fix: m_imageOverlayController was being eagerly initialized here, despite the existence of both
imageOverlayControllerIfExists() and imageOverlayController(). Fix this by lazily creating the
ImageOverlayController instead.

(WebCore::Page::imageAnalysisQueue):

page/Page.h:

(WebCore::Page::imageAnalysisQueueIfExists):
(WebCore::Page::imageOverlayController): Deleted.

Source/WebKit:

Add a couple of WKWebView SPI methods to kick off (and cancel) batch image analysis for mainframe content.
See WebCore ChangeLog for more details.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startImageAnalysis:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startImageAnalysis):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::startImageAnalysis):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

12:16 PM Changeset in webkit [285948] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Do not apply the "do not trim whitespace followed by br" legacy line layout quirk when computing the intrinsic widths
https://bugs.webkit.org/show_bug.cgi?id=233262

Reviewed by Antti Koivisto.

While legacy line layout applies this quirk at line layout, the preferred width computation (totally different) codepath omits this quirk.

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::removeTrailingTrimmableContent):

layout/formattingContexts/inline/InlineLine.h:
layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

12:15 PM Changeset in webkit [285947] by Alan Coon

8 edits in branches/safari-612.3.6.1-branch/Source

Versioning.

WebKit-7612.3.6.1.4

11:48 AM Changeset in webkit [285946] by Alan Bujtas

2 edits in trunk/Source/WebCore

Address post review comment after r285925.

Reviewed by Darin Adler.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath):

11:45 AM Changeset in webkit [285945] by Ryan Haddad

2 edits in trunk/LayoutTests

[iOS] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_window_open_download_block_downloads.tentative.html is frequently failing
https://bugs.webkit.org/show_bug.cgi?id=233267

Unreviewed test gardening.

platform/ios/TestExpectations: Mark test as flaky.

11:21 AM Changeset in webkit [285944] by Alan Coon

1 copy in tags/Safari-613.1.9.0.1

Tag Safari-613.1.9.0.1.

11:14 AM Changeset in webkit [285943] by Alan Coon

4 edits in branches/safari-613.1.9.0-branch/Source/WebCore

Cherry-pick r285883. rdar://problem/85512520

Use IOHIDEvent timestamps for momentum velocity computation
https://bugs.webkit.org/show_bug.cgi?id=233168

Reviewed by Tim Horton.

NSEvent timetamps can have some jitter on some devices (rdar://85309639) so drop
down to IOHIDEvent timestamps when computing the initial velocity for a momentum
scroll animation, for improved accuracy.

page/mac/WheelEventDeltaFilterMac.h:
page/mac/WheelEventDeltaFilterMac.mm: (WebCore::WheelEventDeltaFilterMac::updateFromEvent): (WebCore::WheelEventDeltaFilterMac::reset):
page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::willStartRenderingUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [285942] by Alan Coon

5 edits
2 adds in branches/safari-613.1.9.0-branch

Cherry-pick r285797. rdar://problem/85512520

Fingers down on the trackpad should stop an animated scroll
https://bugs.webkit.org/show_bug.cgi?id=233114

Reviewed by Wenson Hsieh.
Source/WebCore:

Fingers down on the trackpad sends a "MayBegin" event; this needs to stop any in-progress
animated momentum scroll.

This failed because ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent() early-returned
on the MayBegin event before it got to ScrollingEffectsController. Fix that, and have
ScrollingEffectsController::handleWheelEvent() return true to say it was handled.

This triggered an assertion in ScrollingTreeGestureState, but for "post-main-thread"
handling for which the assertion was wrong.

Test: fast/scrolling/mac/momentum-animator-maybegin-stops.html

page/scrolling/ScrollingTreeGestureState.cpp: (WebCore::ScrollingTreeGestureState::nodeDidHandleEvent):
page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
platform/mac/ScrollingEffectsController.mm: (WebCore::ScrollingEffectsController::handleWheelEvent):

LayoutTests:

fast/scrolling/mac/momentum-animator-maybegin-stops-expected.txt: Added.
fast/scrolling/mac/momentum-animator-maybegin-stops.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:14 AM Changeset in webkit [285941] by Alan Coon

16 edits in branches/safari-613.1.9.0-branch/Source

Cherry-pick r285790. rdar://problem/85512520

Attach IOHIDEvent timestamps to wheel events
https://bugs.webkit.org/show_bug.cgi?id=233051

Reviewed by Wenson Hsieh.
Source/WebCore:

On some macOS devices, there can be significant deltas between NSEvent timestamps,
and the timestamps on underlying IOHIDEvents (rdar://85309639). This makes momentum
velocity computation unpredictable; we can get better results by using IOHIDEvent
timestamps.

platform/PlatformWheelEvent.cpp: (WebCore::PlatformWheelEvent::createFromGesture):
platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::ioHIDEventTimestamp const):
platform/mac/PlatformEventFactoryMac.h:
platform/mac/PlatformEventFactoryMac.mm: (WebCore::eventTimeStampSince1970): (WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder): (WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder): (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

Source/WebCore/PAL:

Expose a few bits of SPI needed.

pal/spi/cg/CoreGraphicsSPI.h:
pal/spi/cocoa/IOKitSPI.h:

Source/WebKit:

On some macOS devices, there can be significant deltas between NSEvent timestamps,
and the timestamps on underlying IOHIDEvents (rdar://85309639). This makes momentum
velocity computation unpredictable; we can get better results by using IOHIDEvent
timestamps.

Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): (WebKit::WebWheelEvent::encode const): (WebKit::WebWheelEvent::decode):
Shared/WebWheelEvent.h: (WebKit::WebWheelEvent::ioHIDEventTimestamp const):
Shared/WebWheelEventCoalescer.cpp: (WebKit::WebWheelEventCoalescer::coalesce):
Shared/ios/WebIOSEventFactory.mm: (WebIOSEventFactory::createWebWheelEvent):
Shared/mac/NativeWebGestureEventMac.mm:
Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:06 AM Changeset in webkit [285940] by Alan Coon

9 edits in branches/safari-613.1.9.0-branch/Source

Versioning.

WebKit-7613.1.9.0.1

11:01 AM Changeset in webkit [285939] by Alan Coon

1 copy in branches/safari-613.1.9.0-branch

New branch.

10:51 AM Changeset in webkit [285938] by Antti Koivisto

9 edits in trunk/Source/WebCore

InlineIterator::TextBox::offsetForPosition and positionForOffset should be layout path independent
https://bugs.webkit.org/show_bug.cgi?id=233259

Reviewed by Alan Bujtas.

Remove imperfectly duplicated code.

This also fixes editing/mac/input/caret-primary-bidi.html with IFC BiDi.

layout/integration/InlineIteratorBoxLegacyPath.h:

(WebCore::InlineIterator::BoxLegacyPath::createTextRun const):
(WebCore::InlineIterator::BoxLegacyPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxLegacyPath::positionForOffset const): Deleted.

layout/integration/InlineIteratorBoxModernPath.h:

(WebCore::InlineIterator::BoxModernPath::createTextRun const):
(WebCore::InlineIterator::BoxModernPath::offsetForPosition const): Deleted.
(WebCore::InlineIterator::BoxModernPath::positionForOffset const): Deleted.

layout/integration/InlineIteratorTextBox.cpp:

(WebCore::InlineIterator::TextBox::offsetForPosition const):
(WebCore::InlineIterator::TextBox::positionForOffset const):

layout/integration/InlineIteratorTextBox.h:

(WebCore::InlineIterator::TextBox::createTextRun const):
(WebCore::InlineIterator::TextBox::offsetForPosition const): Deleted.
(WebCore::InlineIterator::TextBox::positionForOffset const): Deleted.

rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::placeEllipsisBox):
(WebCore::LegacyInlineTextBox::offsetForPosition const): Deleted.
(WebCore::LegacyInlineTextBox::positionForOffset const): Deleted.

rendering/LegacyInlineTextBox.h:
rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::offsetForPosition const): Deleted.
(WebCore::SVGInlineTextBox::positionForOffset const): Deleted.

rendering/svg/SVGInlineTextBox.h:

10:50 AM Changeset in webkit [285937] by commit-queue@webkit.org

10 edits in trunk/LayoutTests

AX: Fix 5 tests in --release --accessibility-isolated-tree mode
https://bugs.webkit.org/show_bug.cgi?id=233232

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-17
Reviewed by Chris Fleizach.

Fix all of these tests in --release --accessibility-isolated-tree
mode by asynchronously waiting for document changes (when necessary).
Some tests are changed to use accessibleElementById instead of
element.focus() + accessibilityController.focusedElement for selecting
elements in JS, as the former doesn't require asynchronous waiting for static elements.

accessibility/add-children-pseudo-element-expected.txt:
accessibility/add-children-pseudo-element.html:
accessibility/aria-checkbox-checked.html:
accessibility/aria-checkbox-text.html:
accessibility/aria-toggle-button-with-title.html:
accessibility/auto-fill-types-expected.txt:
accessibility/auto-fill-types.html:
accessibility/ax-value-with-search-expected.txt:
accessibility/ax-value-with-search.html:

10:46 AM Changeset in webkit [285936] by dino@apple.com

17 edits
6 adds in trunk

Add ModelDocument for directly showing content that can be handled by <model>
https://bugs.webkit.org/show_bug.cgi?id=233057
rdar://85265880

Reviewed by Darin Adler.

Source/WebCore:

Add a new ModelDocument class that is created when we encounter a MIME-type that
can be handled by the <model> element.

Test: http/tests/model/model-document.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj: Add new files.

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument): Create a ModelDocument when we
see a MIME-type that <model> can support.

dom/Document.h: Add a new ModelDocumentClass which meant I also had to

increase the sizeof DocumentClassFlags.
(WebCore::Document::isModelDocument const):

html/ModelDocument.cpp: Added.

(WebCore::ModelDocumentParser::createDocumentStructure):
(WebCore::ModelDocumentParser::appendBytes):
(WebCore::ModelDocumentParser::finish):
(WebCore::ModelDocument::ModelDocument):
(WebCore::ModelDocument::createParser):

html/ModelDocument.h: Added.

(isType):

platform/MIMETypeRegistry.cpp: Add isSupportedModelMIMEType and test for it

in canShowMIMEType.
(WebCore::MIMETypeRegistry::canShowMIMEType):
(WebCore::MIMETypeRegistry::isSupportedModelMIMEType):

platform/MIMETypeRegistry.h:

Source/WebKit:

We don't need to use WKUSDPreviewView if we have ModelDocument.

UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry initWithConfiguration:]):

Source/WTF:

Add a experimental feature: ModelDocumentEnabled
for loading content that can be handled by <model>.

Scripts/Preferences/WebPreferencesExperimental.yaml:

LayoutTests:

New test for ModelDocument.

http/conf/mime.types: Configure the testing Apache server to serve USDZ files

with the correct MIME type.

http/tests/model/UnitBox.usdz: Sample file.
http/tests/model/model-document-expected.txt: Added.
http/tests/model/model-document.html: New test for a ModelDocument.

10:44 AM Changeset in webkit [285935] by commit-queue@webkit.org

13 edits in trunk/Source/WebCore

Unreviewed, reverting r285934.
https://bugs.webkit.org/show_bug.cgi?id=233260

Broke Windows build

Reverted changeset:

"AX: Use ObjectIdentifier for AXID"
https://bugs.webkit.org/show_bug.cgi?id=233248
https://commits.webkit.org/r285934

10:14 AM Changeset in webkit [285934] by commit-queue@webkit.org

13 edits in trunk/Source/WebCore

AX: Use ObjectIdentifier for AXID
https://bugs.webkit.org/show_bug.cgi?id=233248

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2021-11-17
Reviewed by Andres Gonzalez.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::setIsolatedTreeFocusedObject):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::cacheAndInitializeWrapper):
(WebCore::AXObjectCache::platformGenerateAXID const):
(WebCore::AXObjectCache::objectsForIDs const):
(WebCore::AXObjectCache::updateIsolatedTree):

accessibility/AXObjectCache.h:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::detach):

accessibility/atspi/AccessibilityObjectAtspi.cpp:
accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::associatedAXObject const):
(WebCore::AXIsolatedObject::detachFromParent):
(WebCore::AXIsolatedObject::isDetachedFromParent):
(WebCore::AXIsolatedObject::cellForColumnAndRow):
(WebCore::AXIsolatedObject::accessibilityHitTest const):
(WebCore::AXIsolatedObject::objectAttributeValue const):

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::nodeForID const):
(WebCore::AXIsolatedTree::idsForObjects const):
(WebCore::AXIsolatedTree::updateChildrenIDs):
(WebCore::AXIsolatedTree::generateSubtree):
(WebCore::AXIsolatedTree::createSubtree):
(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::removeSubtree):
(WebCore::AXIsolatedTree::applyPendingChanges):

accessibility/isolatedtree/AXIsolatedTree.h:

(WebCore::AXIsolatedTree::WTF_GUARDED_BY_LOCK):

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase attachAXObject:]):
(-[WebAccessibilityObjectWrapperBase attachIsolatedObject:]):
(-[WebAccessibilityObjectWrapperBase detach]):
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject:]):

accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::platformGenerateAXID const):

9:50 AM Changeset in webkit [285933] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Incorrect use of BreakWord with preferred width computation (it's a valid value for both WordBreak and OverflowWrap)
https://bugs.webkit.org/show_bug.cgi?id=233258

Reviewed by Antti Koivisto.

This was caught by fast/text/word-break.html (note that this codepath is not yet enabled).

layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):

9:27 AM Changeset in webkit [285932] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix formatting and string literals in FileInputType.cpp
https://bugs.webkit.org/show_bug.cgi?id=233229

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-11-17
Reviewed by Darin Adler.

This change uses the emptyString() and defaultMIMEType() functions rather than using string
literals, fixes the coding style, and reverts an unnecessary change in the comments.

This fixes code review suggestions from https://bugs.webkit.org/show_bug.cgi?id=185416 and
https://bugs.webkit.org/show_bug.cgi?id=221549

html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):

8:30 AM Changeset in webkit [285931] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Fix imported/w3c/web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-013.html
https://bugs.webkit.org/show_bug.cgi?id=233237

Reviewed by Antti Koivisto.

Do not take hanging glyphs into account when measuring content for preferred width.
(Note that this patch is in preparation for enabling IFC preferred width computation)

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::removeHangingGlyphs):

layout/formattingContexts/inline/InlineLine.h:
layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

7:10 AM Changeset in webkit [285930] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes.
https://bugs.webkit.org/show_bug.cgi?id=233222

Reviewed by Antti Koivisto.

See https://drafts.csswg.org/css-text/#overflow-wrap-property

layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::InlineContentBreaker):
(WebCore::Layout::InlineContentBreaker::wordBreakBehavior const):

layout/formattingContexts/inline/InlineContentBreaker.h:

(WebCore::Layout::InlineContentBreaker::isIntrinsicWidthMode const):

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):

layout/formattingContexts/inline/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::isIntrinsicWidthMode const):

7:08 AM Changeset in webkit [285929] by Chris Lord

2 edits in trunk

Add Chris Lord's GitHub username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=233254

Unreviewed

metadata/contributors.json:

6:52 AM Changeset in webkit [285928] by youenn@apple.com

5 edits in trunk

Safari 15.1 H264 FullHD video encode/decode fails
https://bugs.webkit.org/show_bug.cgi?id=233036
<rdar://80345048>

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

H264 encoder now checks the profile and fails if frame is too big.
To get back to the past behavior, we are now using auto level for both ARM64 devices as well as devices with Monterey OS.

Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

LayoutTests:

platform/mac-wk2/TestExpectations:

6:50 AM Changeset in webkit [285927] by youenn@apple.com

2 edits in trunk/Source/WebCore

Increase CoreAudioCaptureSource capture verify timer to handle the case of device change
https://bugs.webkit.org/show_bug.cgi?id=233250

Reviewed by Eric Carlson.

Previously, our capture verify timer was starting with 10 seconds to handle slow start up times, and decreasing to 2 seconds to be snappy.
We are now sticking to 10 seconds to handle the case of changing of capture device while capturing.
This happens on iOS for instance when going from builtin microphone to BT headset microphone.

Manually tested.

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

6:23 AM Changeset in webkit [285926] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder should drive the trailing whitespace collapsing/trimming
https://bugs.webkit.org/show_bug.cgi?id=233233

Reviewed by Antti Koivisto.

This is in preparation for adding min/max intrinsic handling to trailing whitespace content.

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::visuallyCollapseHangingOverflowingWhitespace): Use spec term.
(WebCore::Layout::Line::removeTrimmableContent): Deleted.
(WebCore::Layout::Line::visuallyCollapseHangingOverflow): Deleted.

layout/formattingContexts/inline/InlineLine.h:
layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

6:19 AM Changeset in webkit [285925] by Alan Bujtas

2 edits in trunk/Source/WebCore

[IFC][Integration] Clear the preferredLogicalWidths dirty bits after calling LineLayout::computeIntrinsicWidthConstraints
https://bugs.webkit.org/show_bug.cgi?id=233201

Reviewed by Antti Koivisto.

This is in preparation for enabling preferred width computation through IFC.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath):

4:50 AM Changeset in webkit [285924] by Andres Gonzalez

3 edits in trunk/LayoutTests

Fix for accessibility/notification-listeners.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=233228
<rdar://problem/85484341>

Reviewed by Chris Fleizach.

Made this test async in order to pass in isolated tree mode.
The first accessible element needs to be retrieved with waitForElementById,
otherwise if we use accessibilityController.accessibleElementById, the
test would fail randomly (~10 out of 1000 flakiness). It requires
further investigation to determine if this is an issue with the <select>
element or with the first accessible element the test retrieves.

accessibility/notification-listeners.html:
platform/mac/accessibility/notification-listeners-expected.txt:

4:31 AM Changeset in webkit [285923] by commit-queue@webkit.org

5 edits in trunk

Limit logical width over-constrained direction check
https://bugs.webkit.org/show_bug.cgi?id=233189

Patch by Rob Buis <rbuis@igalia.com> on 2021-11-17
Reviewed by Sergio Villar Senin.

Source/WebCore:

In computePositionedLogicalWidthUsing the over-constrained case always checks for RTL
direction, but this should not be done if we are not dealing with left and right properties,
i.e. only when we are not orthogonal with the container.
Finally computeLogicalLeftPositionedOffset should not do the flipping logic in the over-constrained case.

rendering/RenderBox.cpp:

(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing const):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced const):

LayoutTests:

TestExpectations: Removed 4 tests that are now passing.
platform/ios/TestExpectations: Skipped several tests that show 1px diff in the result.

2:38 AM Changeset in webkit [285922] by graouts@webkit.org

14 edits
4 copies
2 moves
1 add in trunk/Source

[Model] Create iOS ModelPlayer implementation
https://bugs.webkit.org/show_bug.cgi?id=233192

Reviewed by Dean Jackson.

Bug 232848 factored platform-specific code out of HTMLModelElement with the use of a new ModelPlayer
abstraction with a concrete ARKitInlinePreviewModelPlayer implementation. This first patch moved the
macOS code, and this patch moves the remaining iOS code.

To do so we make ARKitInlinePreviewModelPlayer a parent class of two platform-specific subclasses:
ARKitInlinePreviewModelPlayerMac and ARKitInlinePreviewModelPlayerIOS. We add a new enterFullscreen()
method to ModelPlayer, with an implementation in the iOS subclass. To support this new method, we
add a new platformLayerID() on ModelPlayerClient.

Source/WebCore:

Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::modelDidChange):
(WebCore::HTMLModelElement::usesPlatformLayer const):
(WebCore::HTMLModelElement::platformLayerID):
(WebCore::HTMLModelElement::enterFullscreen):

Modules/model-element/HTMLModelElement.h:
Modules/model-element/ModelPlayer.h:
Modules/model-element/ModelPlayerClient.h:
Modules/model-element/ModelPlayerProvider.h:
Modules/model-element/dummy/DummyModelPlayer.cpp:

(WebCore::DummyModelPlayer::enterFullscreen):

Modules/model-element/dummy/DummyModelPlayer.h:
Modules/model-element/scenekit/SceneKitModelPlayer.h:
Modules/model-element/scenekit/SceneKitModelPlayer.mm:

(WebCore::SceneKitModelPlayer::enterFullscreen):

Source/WebKit:

SourcesCocoa.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/Model/ARKitInlinePreviewModelPlayer.h: Added.

(WebKit::ARKitInlinePreviewModelPlayer::page):
(WebKit::ARKitInlinePreviewModelPlayer::client):

WebProcess/Model/ARKitInlinePreviewModelPlayer.mm: Added.

(WebKit::ARKitInlinePreviewModelPlayer::ARKitInlinePreviewModelPlayer):
(WebKit::ARKitInlinePreviewModelPlayer::~ARKitInlinePreviewModelPlayer):
(WebKit::ARKitInlinePreviewModelPlayer::load):
(WebKit::ARKitInlinePreviewModelPlayer::layer):
(WebKit::ARKitInlinePreviewModelPlayer::enterFullscreen):

WebProcess/Model/WebModelPlayerProvider.cpp:

(WebKit::WebModelPlayerProvider::createModelPlayer):

WebProcess/Model/WebModelPlayerProvider.h:
WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.h: Added.
WebProcess/Model/ios/ARKitInlinePreviewModelPlayerIOS.mm: Added.

(WebKit::ARKitInlinePreviewModelPlayerIOS::create):
(WebKit::ARKitInlinePreviewModelPlayerIOS::ARKitInlinePreviewModelPlayerIOS):
(WebKit::ARKitInlinePreviewModelPlayerIOS::~ARKitInlinePreviewModelPlayerIOS):
(WebKit::ARKitInlinePreviewModelPlayerIOS::enterFullscreen):

WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h: Renamed from Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayer.h.
WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm: Renamed from Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayer.mm.

(WebKit::ARKitInlinePreviewModelPlayerMac::create):
(WebKit::ARKitInlinePreviewModelPlayerMac::ARKitInlinePreviewModelPlayerMac):
(WebKit::ARKitInlinePreviewModelPlayerMac::~ARKitInlinePreviewModelPlayerMac):
(WebKit::ARKitInlinePreviewModelPlayerMac::setModelElementCacheDirectory):
(WebKit::ARKitInlinePreviewModelPlayerMac::createFile):
(WebKit::ARKitInlinePreviewModelPlayerMac::clearFile):
(WebKit::ARKitInlinePreviewModelPlayerMac::load):
(WebKit::ARKitInlinePreviewModelPlayerMac::layer):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setWebsiteDataStoreParameters):

2:29 AM Changeset in webkit [285921] by Antti Koivisto

13 edits
2 moves
14 adds in trunk/LayoutTests

Update web-platform-tests/css/selectors
https://bugs.webkit.org/show_bug.cgi?id=233246

Reviewed by Alexey Shvayka.

LayoutTests/imported/w3c:

WPT updates.

resources/import-expectations.json:
web-platform-tests/css/selectors/first-letter-flag-001-expected.html: Added.
web-platform-tests/css/selectors/first-letter-flag-001.html: Added.
web-platform-tests/css/selectors/focus-visible-004.html:
web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative-expected.txt: Added.
web-platform-tests/css/selectors/has-argument-with-explicit-scope.tentative.html: Added.
web-platform-tests/css/selectors/has-basic-expected.txt:
web-platform-tests/css/selectors/has-basic.html:
web-platform-tests/css/selectors/has-matches-to-uninserted-elements-expected.txt: Added.
web-platform-tests/css/selectors/has-matches-to-uninserted-elements.html: Added.
web-platform-tests/css/selectors/has-relative-argument-expected.txt:
web-platform-tests/css/selectors/has-relative-argument.html:
web-platform-tests/css/selectors/invalidation/attribute-or-elemental-selectors-in-has-expected.txt: Added.
web-platform-tests/css/selectors/invalidation/attribute-or-elemental-selectors-in-has.html: Added.
web-platform-tests/css/selectors/invalidation/w3c-import.log:
web-platform-tests/css/selectors/nesting-expected.html: Added.
web-platform-tests/css/selectors/nesting-parsing-expected.txt: Added.
web-platform-tests/css/selectors/nesting-parsing.html: Added.
web-platform-tests/css/selectors/nesting.html: Added.
web-platform-tests/css/selectors/parsing/parse-has-expected.txt:
web-platform-tests/css/selectors/parsing/parse-has.html:
web-platform-tests/css/selectors/selection-image-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selection-image-001-expected.html.
web-platform-tests/css/selectors/selection-image-002-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/selection-image-002-expected.html.
web-platform-tests/css/selectors/w3c-import.log:
web-platform-tests/css/selectors/xml-class-selector-expected.xml: Added.
web-platform-tests/css/selectors/xml-class-selector.xml: Added.

LayoutTests:

TestExpectations:

1:18 AM Changeset in webkit [285920] by commit-queue@webkit.org

3 edits
2 adds in trunk

Null check clonedParent
https://bugs.webkit.org/show_bug.cgi?id=230713

Patch by Rob Buis <rbuis@igalia.com> on 2021-11-17
Reviewed by Wenson Hsieh.

Source/WebCore:

Null check clonedParent.

Test: editing/execCommand/insert-newline-in-quoted-content-crash.html

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

editing/execCommand/insert-newline-in-quoted-content-crash-expected.txt: Added.
editing/execCommand/insert-newline-in-quoted-content-crash.html: Added.

12:53 AM Changeset in webkit [285919] by commit-queue@webkit.org

12 edits in trunk

[GTK][WPE] Support getting and setting HTTP headers in custom URI scheme handlers
https://bugs.webkit.org/show_bug.cgi?id=203273

Patch by Zixing Liu <liushuyu011@gmail.com> on 2021-11-17
Reviewed by Carlos Garcia Campos.

Source/WebKit:

UIProcess/API/glib/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_get_http_headers): Added new API function
(webkitURISchemeRequestReadCallback): Include user-specified headers

UIProcess/API/glib/WebKitURISchemeResponse.cpp:

(WebKitURISchemeResponseGetHeaders): Added a new private getter
(webkit_uri_scheme_response_set_http_headers): Added new API function

UIProcess/API/glib/WebKitURISchemeResponsePrivate.h:
UIProcess/API/gtk/WebKitURISchemeRequest.h: Added function prototype for

webkit_uri_scheme_request_get_http_headers

UIProcess/API/gtk/WebKitURISchemeResponse.h: Added function prototype for

webkit_uri_scheme_request_set_http_headers

UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Added new symbols
UIProcess/API/wpe/WebKitURISchemeRequest.h: Added function prototype for

webkit_uri_scheme_request_get_http_headers

UIProcess/API/wpe/WebKitURISchemeResponse.h: Added function prototype for

webkit_uri_scheme_request_set_http_headers

UIProcess/API/wpe/docs/wpe-1.0-sections.txt: Added new symbols

Tools:

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextURIScheme): Added a new test to test getting and setting HTTP headers in custom URI scheme handlers

Nov 16, 2021:

11:54 PM Changeset in webkit [285918] by commit-queue@webkit.org

6 edits in trunk

Re-add 'style' to contain:strict and contain:content CSS properties
https://bugs.webkit.org/show_bug.cgi?id=233193

Patch by Rob Buis <rbuis@igalia.com> on 2021-11-16
Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

Now contain-computed-expected.txt is all PASS.

web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:

Source/WebCore:

After being removed for a while, style containment is part again of contain:strict and contain: content [1, 2].
The change was done in chromium and Firefox has verbally agreed to make the change as well [3].

[1] https://github.com/w3c/csswg-drafts/issues/6287#issuecomment-862525199
[2] https://github.com/w3c/csswg-drafts/commit/7948feb03a9aaceb3a8ee423b07c6e526024cdc2
[3] https://groups.google.com/a/chromium.org/g/blink-dev/c/oMVBKemrTDQ?pli=1

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::strictContainment):
(WebCore::RenderStyle::contentContainment):

LayoutTests:

TestExpectations:

10:25 PM Changeset in webkit [285917] by Simon Fraser

5 edits
2 adds in trunk

Stop a momentum scroll animation when receiving a momentum end event
https://bugs.webkit.org/show_bug.cgi?id=233236

Reviewed by Tim Horton.

Source/WebCore:

The stream of momentum events is terminated by an "end" event under two circumstances:

The gesture finished naturally without interruption.
The user tapped the trackpad with two fingers.

Unfortunately we can't tell these apart, so we always have to stop the animation.

Sadly this reveals a hole in the testing infrastructure. All the "changed" momentum
events in the sequence handed to UIHelper.mouseWheelSequence() are ignored while the
animation is running, but the "ended" event stops the animation. So any test without
a reasonable number of "changed" events will terminate its animation prematurely.
We can't fix this without new testing infrastructure (webkit.org/b/233234).

Test: fast/scrolling/mac/momentum-animator-end-event-stops.html

platform/ScrollingEffectsController.h:
platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::handleWheelEvent):

LayoutTests:

New test, and skip one that breaks now because we need a fix for webkit.org/b/233234.

fast/scrolling/mac/momentum-animator-end-event-stops-expected.txt: Added.
fast/scrolling/mac/momentum-animator-end-event-stops.html: Added.
platform/mac-wk2/TestExpectations:

10:24 PM Changeset in webkit [285916] by Said Abou-Hallawa

49 edits
1 add in trunk/Source/WebCore

[GPU Process] Build a postfix expression for applying the FilterEffects of the SVGFilter
https://bugs.webkit.org/show_bug.cgi?id=233214

Reviewed by Cameron McCormack.

The goal of building this expression is to have all inputs of each
FilterEffect be applied before applying it. This will eliminate the need
to do recursive applying in FilterEffect::apply(). And it will also
eliminate the need to store the rectangle of the result of FilterEffect.
Once the absolutePaintRect is calculated, the result image can be created.

Filter::apply() and FilterEffect::apply() should return a boolean so the
caller knows that applying the filter function was not successful.

WebCore.xcodeproj/project.pbxproj:
platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplySoftware):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/Filter.h:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):

platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/FilterEffectVector.h: Added.
platform/graphics/filters/FilterFunction.h:

(WebCore::FilterFunction::apply):

platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

platform/graphics/filters/SourceGraphic.h:
rendering/CSSFilter.cpp:

(WebCore::CSSFilter::apply):

rendering/CSSFilter.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

svg/graphics/filters/SVGFEImage.h:
svg/graphics/filters/SVGFilter.cpp:

(WebCore::SVGFilter::create):
(WebCore::SVGFilter::apply):
(WebCore::SVGFilter::outsets const):
(WebCore::SVGFilter::clearResult):

svg/graphics/filters/SVGFilter.h:
svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::buildEffectExpression):
(WebCore::SVGFilterBuilder::buildExpression const):

svg/graphics/filters/SVGFilterBuilder.h:

9:53 PM Changeset in webkit [285915] by jh718.park@samsung.com

6 edits in trunk

border-radius inline style should serialize with valid syntax
https://bugs.webkit.org/show_bug.cgi?id=183994

This patch have border-radius property serializes in canonical order
as specified in https://drafts.csswg.org/css-backgrounds/#border-radius.

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add css wide keywords test case results.
web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add css wide keywords test cases.

Source/WebCore:

css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::borderRadiusValue const):

css/StyleProperties.h:

8:27 PM Changeset in webkit [285914] by Ross Kirsling

4 edits in trunk/Source/WebKit

Unreviewed, fix WinCairo build following r285881.

CMakeLists.txt:
WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:
WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h:

7:14 PM Changeset in webkit [285913] by mmaxfield@apple.com

3 edits
1 copy
3 adds in trunk/Source/WebGPU

[WebGPU] Add WGSLUnitTests XCTest target for WebGPU
https://bugs.webkit.org/show_bug.cgi?id=233227

Reviewed by Robin Morisset.

For now, this new target isn't hooked up to any automated testing - it's just a local target which developers can run.

Configurations/WGSLUnitTests.xcconfig: Added.
WGSLUnitTests/WGSLUnitTests.mm: Added.

(-[WGSLUnitTests testExample]):

WebGPU.xcodeproj/project.pbxproj:
WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme:
WebGPU.xcodeproj/xcshareddata/xcschemes/WGSLUnitTests.xcscheme: Copied from Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/WGSL.xcscheme.

6:55 PM Changeset in webkit [285912] by sihui_liu@apple.com

45 edits
5 adds in trunk

Implement FileSystemFileHandle.getFile()
https://bugs.webkit.org/show_bug.cgi?id=232716
<rdar://problem/85022453>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaselined existing tests as some tests are passed and the others can run further due to the new support.

web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-IndexedDB.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-isSameEntry.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-BroadcastChannel.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-Error.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-frames.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-windows.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-MessagePort-workers.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-frames.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-windows.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-postMessage-workers.https.window-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-iteration.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-resolve.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemFileHandle-getFile.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-piped.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream-write.https.any.worker-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any-expected.txt:
web-platform-tests/file-system-access/sandboxed_FileSystemWritableFileStream.https.any.worker-expected.txt:

Source/WebCore:

Spec: https://wicg.github.io/file-system-access/#api-filesystemfilehandle-getfile

Tests: storage/filesystemaccess/file-handle-getfile-worker.html

storage/filesystemaccess/file-handle-getfile.html

Modules/filesystemaccess/FileSystemFileHandle.cpp:

(WebCore::FileSystemFileHandle::getFile):

Modules/filesystemaccess/FileSystemStorageConnection.h:
Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp:

(WebCore::WorkerFileSystemStorageConnection::scopeClosed):
(WebCore::WorkerFileSystemStorageConnection::didResolve):
(WebCore::WorkerFileSystemStorageConnection::getFile):
(WebCore::WorkerFileSystemStorageConnection::completeStringCallback):

Modules/filesystemaccess/WorkerFileSystemStorageConnection.h:

Source/WebKit:

Let web process send message to network process for file path.

NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::NetworkStorageManager::getFile):

NetworkProcess/storage/NetworkStorageManager.h:
NetworkProcess/storage/NetworkStorageManager.messages.in:
WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp:

(WebKit::WebFileSystemStorageConnection::getFile):

WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h:

LayoutTests:

storage/filesystemaccess/file-handle-getfile-expected.txt: Added.
storage/filesystemaccess/file-handle-getfile-worker-expected.txt: Added.
storage/filesystemaccess/file-handle-getfile-worker.html: Added.
storage/filesystemaccess/file-handle-getfile.html: Added.
storage/filesystemaccess/resources/file-handle-getfile.js: Added.

(finishTest):
(async read):
(async test):

6:48 PM Changeset in webkit [285911] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Add sandbox telemetry for preference access
https://bugs.webkit.org/show_bug.cgi?id=233194

Reviewed by Brent Fulgham.

Add sandbox telemetry for preference access on macOS.

Shared/Sandbox/preferences.sb:

6:39 PM Changeset in webkit [285910] by Devin Rousso

5 edits in trunk/Source

[iOS] use PhotosUIPrivate instead of PhotosUI
https://bugs.webkit.org/show_bug.cgi?id=233213
<rdar://problem/85300427>

Reviewed by Aditya Keerthi.

Source/WebKit:

Platform/spi/ios/PhotosUISPI.h:
UIProcess/ios/forms/WKFileUploadPanel.mm:

Source/WTF:

wtf/PlatformHave.h:

6:13 PM Changeset in webkit [285909] by Russell Epstein

1 copy in tags/Safari-612.3.6.3.1

Tag Safari-612.3.6.3.1.

6:12 PM Changeset in webkit [285908] by Russell Epstein

1 copy in tags/Safari-612.3.6.2.2

Tag Safari-612.3.6.2.2.

6:07 PM Changeset in webkit [285907] by Russell Epstein

1 copy in tags/Safari-612.3.6.0.3

Tag Safari-612.3.6.0.3.

6:00 PM Changeset in webkit [285906] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS] Reduce telemetry
https://bugs.webkit.org/show_bug.cgi?id=233218

Reviewed by Brent Fulgham.

Reduce telemetry with backtrace for the system calls we have information about.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

5:57 PM Changeset in webkit [285905] by Russell Epstein

1 copy in tags/Safari-612.3.6.1.3

Tag Safari-612.3.6.1.3.

5:26 PM Changeset in webkit [285904] by Nikos Mouchtaris

22 edits in trunk/Source

Rename TextDecoration to TextDecorationLine
https://bugs.webkit.org/show_bug.cgi?id=232729

Reviewed by Myles C. Maxfield.

Source/WebCore:

Split up patch by Tim Nguyen: https://bugs.webkit.org/show_bug.cgi?id=230083. This patch
renames enum TextDecoration to TextDecorationLine, to be more in line with the current spec.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasUnderline const):

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject):

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(AXAttributeStringSetStyle):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetStyle):

animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationLineFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::renderTextDecorationFlagsToCSSValue): Deleted.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator OptionSet<TextDecorationLine> const):
(WebCore::CSSPrimitiveValue::operator OptionSet<TextDecoration> const): Deleted.

editing/Editor.cpp:

(WebCore::Editor::fontAttributesAtSelectionStart):

editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedString):

rendering/StyledMarkedText.cpp:

(WebCore::resolveStyleForMarkedText):

rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::TextDecorationPainter):
(WebCore::TextDecorationPainter::paintTextDecoration):
(WebCore::collectStylesForRenderer):
(WebCore::TextDecorationPainter::textDecorationsInEffectForStyle):
(WebCore::TextDecorationPainter::stylesForRenderer):

rendering/TextDecorationPainter.h:
rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textDecorationsInEffect const):
(WebCore::RenderStyle::textDecoration const):
(WebCore::RenderStyle::addToTextDecorationsInEffect):
(WebCore::RenderStyle::setTextDecorationsInEffect):
(WebCore::RenderStyle::setTextDecoration):
(WebCore::RenderStyle::initialTextDecoration):

rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

rendering/style/RenderStyleConstants.h:
rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):

rendering/svg/SVGInlineTextBox.h:
style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):
(WebCore::enclosingRendererWithTextDecoration):
(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTextDecoration):

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

5:08 PM Changeset in webkit [285903] by Russell Epstein

3 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285886. rdar://problem/85473581

[iOS] Limit graphics related IOKit method filtering
https://bugs.webkit.org/show_bug.cgi?id=233209
<rdar://problem/85473581>

Reviewed by Brent Fulgham.

Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
will enable a replacement for the disabled filtering.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
Scripts/process-entitlements.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:03 PM Changeset in webkit [285902] by Russell Epstein

2 edits in branches/safari-612.3.6.3-branch/Source/WebKit

Cherry-pick r283386. rdar://problem/83953959

Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
<rdar://problem/82807413>

Reviewed by Alex Christensen.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while policy handlers are run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:59 PM Changeset in webkit [285901] by Russell Epstein

8 edits in branches/safari-612.3.6.3-branch/Source

Versioning.

WebKit-7612.3.6.3.1

4:56 PM Changeset in webkit [285900] by Jonathan Bedard

4 edits
2 adds in trunk/Tools

[webkitscmpy] Load secrets in kubernetes
https://bugs.webkit.org/show_bug.cgi?id=233158
<rdar://problem/85433499>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Bump version, export Environment.
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:

(credentials): Use Environment instead of os.environ.

Tools/Scripts/libraries/webkitcorepy/webkitcorepy/environment.py: Added.

(Environment):
(Environment.instance): Construct a shared Environmant intance.
(Environment.init):
(Environment.load): Load secrets in file directory.
(Environment.get): Check environment variable and then secret store.
(Environment.getitem):
(Environment.setitem):
(Environment.keys): Iterate through secret store and environment variables.
(Environment.values): Ditto.
(Environment.items): Ditto.

Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/environment_unittest.py: Added.

(TestEnvironment):
(TestEnvironment.test_basic):
(TestEnvironment.test_scoped):
(TestEnvironment.test_list):

Canonical link: https://commits.webkit.org/244316@main

4:31 PM Changeset in webkit [285899] by Russell Epstein

2 edits in branches/safari-612.3.6.2-branch/Source/WebKit

Cherry-pick r283386. rdar://problem/83953959

Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
<rdar://problem/82807413>

Reviewed by Alex Christensen.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while policy handlers are run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:30 PM Changeset in webkit [285898] by Devin Rousso

8 edits in trunk/Source

[Apple Pay] handle unknown setup features
https://bugs.webkit.org/show_bug.cgi?id=233212

Reviewed by Wenson Hsieh.

Source/WebCore:

Modules/applepay/ApplePaySetupFeatureWebCore.h:
Modules/applepay/ApplePaySetupFeature.mm:

(WebCore::ApplePaySetupFeature::supportsFeature): Added.
(WebCore::ApplePaySetupFeature::type const):

Modules/applepay/PaymentInstallmentConfiguration.mm:

(WebCore::applePaySetupFeatureType):
(WebCore::platformFeatureType):
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const):
If the PKPaymentSetupFeatureType is unknown/unsupported, return an empty ApplePayInstallmentConfiguration.
Drive-by: Replace all PKPaymentSetupFeatureTypeApplePay_X with PKPaymentSetupFeatureTypeAppleCard.

Source/WebCore/PAL:

pal/spi/cocoa/PassKitSPI.h:

Drive-by: Replace all PKPaymentSetupFeatureTypeApplePay_X with PKPaymentSetupFeatureTypeAppleCard.

Source/WebKit:

Shared/ApplePay/ApplePayPaymentSetupFeatures.mm:

(WebKit::PaymentSetupFeatures::operator Vector<Ref<WebCore::ApplePaySetupFeature>> const):
Skip PKPaymentSetupFeature that have an unknown PKPaymentSetupFeatureType. This ensures
that WebCore::ApplePaySetupFeature will only ever be created with known/supported PKPaymentSetupFeatureType.

4:29 PM Changeset in webkit [285897] by Russell Epstein

8 edits in branches/safari-612.3.6.2-branch/Source

Versioning.

WebKit-7612.3.6.2.2

4:23 PM Changeset in webkit [285896] by Nikita Vasilyev

9 edits in trunk

Web Inspector: Remove unused dontCreateIfMissing argument from CSSStyleDeclaration.prototype.propertyForName
https://bugs.webkit.org/show_bug.cgi?id=233198

Reviewed by Devin Rousso.

Source/WebInspectorUI:

dontCreateIfMissing was always set to true.

UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration.prototype.propertyForName):
Drive-by: inline findMatch function, which was only used once.

UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):

UserInterface/Models/Font.js:

(WI.Font):

UserInterface/Views/BoxModelDetailsSectionRow.js:

(WI.BoxModelDetailsSectionRow.prototype._getPropertyValue):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addVariableTokens):

LayoutTests:

inspector/css/overridden-property.html:
inspector/css/pseudo-element-matches-for-pseudo-element-node.html:

4:14 PM Changeset in webkit [285895] by Russell Epstein

2 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285889. rdar://problem/85430575

Adjust graphics related message filter
https://bugs.webkit.org/show_bug.cgi?id=233151
<rdar://problem/85430575>

Reviewed by Brent Fulgham.

Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies
the filter for different OS versions.

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:14 PM Changeset in webkit [285894] by Russell Epstein

3 edits in branches/safari-613.1.9-branch/Source/WebKit

Cherry-pick r285878. rdar://problem/85430575

Adjust graphics related message filter
https://bugs.webkit.org/show_bug.cgi?id=233151
<rdar://problem/85430575>

Reviewed by Brent Fulgham.

Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies
the filter for different OS versions.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:53 PM Changeset in webkit [285893] by Nikos Mouchtaris

11 edits in trunk/Source

Add overscroll behavior to ScrollableAreaParameters
https://bugs.webkit.org/show_bug.cgi?id=233159

Reviewed by Simon Fraser.

Source/WebCore:

Split patch by Cathie Chen and Frederic Wang. This patch lands the addition of
horizontalOverscrollBehavior and verticalOverscrollBehavior to ScrollableAreaParameters
to track value of over scroll behavior for particular scroll node. Patches for synchronous/
asynchronous scrolling on Mac and on iOS to come.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):

page/scrolling/ScrollingCoordinatorTypes.h:

(WebCore::ScrollableAreaParameters::operator== const):

page/scrolling/ScrollingTreeScrollingNode.h:
platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalOverscrollBehavior const):
(WebCore::ScrollableArea::verticalOverscrollBehavior const):

rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::horizontalOverscrollBehavior const):
(WebCore::RenderLayerScrollableArea::verticalOverscrollBehavior const):

rendering/RenderLayerScrollableArea.h:

Source/WebKit:

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::decode):

Shared/WebCoreArgumentCoders.h:

2:58 PM Changeset in webkit [285892] by Russell Epstein

3 edits
3 adds in branches/safari-612.3.6.1-branch

Cherry-pick r285823. rdar://problem/85236459

Cross-Origin-Embedder-Policy: require-corp prevents loading of data URL images
https://bugs.webkit.org/show_bug.cgi?id=233131
<rdar://85236459>

Reviewed by Geoffrey Garen.

Source/WebCore:

When doing an initial data URL <img> load, we properly wouldn't perform a cross-origin resource policy check.
This is per the Fetch specification that says to use a scheme fetch [1] when the request URL is a data URL.
When the protocol is data, the scheme fetch algorithm would return a response without performing an HTTP
Fetch. The HTTP check [2] is the algorithm that actually performs a cross-origin resource policy check, at
step 7.

The issue with our implementation was that data URL <img> loads would perform a cross-origin resource policy
check in the case where the image is loaded from our memory cache, due to a check we had in
CachedResourceLoader::requestResource(). As a result, data URL <img> loads would fail when served from the
memory cache, when CORP is enforced. To address the issue and match the specification, we now disable this
CORP check when the request URL is a data URL.

[1] https://fetch.spec.whatwg.org/#scheme-fetch
[2] https://fetch.spec.whatwg.org/#concept-http-fetch

Test: http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html

loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource):

LayoutTests:

Add layout test coverage. This test is based on a reduce test case from Cameron McCormack.

http/wpt/html/cross-origin-embedder-policy/require-corp-data-url-expected.txt: Added.
http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html: Added.
http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html.headers: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:57 PM Changeset in webkit [285891] by Russell Epstein

2 edits in branches/safari-612.3.6.1-branch/Source/WebKit

Cherry-pick r283386. rdar://problem/83953959

Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
<rdar://problem/82807413>

Reviewed by Alex Christensen.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while policy handlers are run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:55 PM Changeset in webkit [285890] by Jonathan Bedard

4 edits in trunk/Tools

[git-webkit] Mark landed changes as merged
https://bugs.webkit.org/show_bug.cgi?id=233056
<rdar://problem/85351564>

Reviewed by Dewei Zhu.

For BitBucket and GitHub to recognize a pull-request as merged, the target
branch must be updated with the exact commit to be merged as the merge occurs.

Scripts/libraries/webkitscmpy/setup.py: Bump version.
Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:

(Land.main): Update source branch when merging commits to target branch.

Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:

(BitBucket.PRGenerator.update): Only delete values if they exist.

Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:

(TestLand):
(TestLandGitHub):
(TestLandBitBucket):

Canonical link: https://commits.webkit.org/244312@main

2:53 PM Changeset in webkit [285889] by pvollan@apple.com

2 edits in trunk/Source/WebKit

Adjust graphics related message filter
https://bugs.webkit.org/show_bug.cgi?id=233151
<rdar://problem/85430575>

Reviewed by Brent Fulgham.

Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies
the filter for different OS versions.

WebProcess/com.apple.WebProcess.sb.in:

2:53 PM Changeset in webkit [285888] by Russell Epstein

8 edits in branches/safari-612.3.6.1-branch/Source

Versioning.

WebKit-7612.3.6.1.3

2:47 PM Changeset in webkit [285887] by Russell Epstein

1 edit in branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp

Unreviewed integration fix. rdar://83953959

2:46 PM Changeset in webkit [285886] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[iOS] Limit graphics related IOKit method filtering
https://bugs.webkit.org/show_bug.cgi?id=233209
<rdar://problem/85473581>

Reviewed by Brent Fulgham.

Limit graphics related IOKit method filtering based on OS version. This patch also adds an entitlement which
will enable a replacement for the disabled filtering.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
Scripts/process-entitlements.sh:

2:32 PM Changeset in webkit [285885] by commit-queue@webkit.org

19 edits in trunk

[css-contain] Support contain:paint
https://bugs.webkit.org/show_bug.cgi?id=224742

Patch by Rob Buis <rbuis@igalia.com> on 2021-11-16
Reviewed by Alan Bujtas.

LayoutTests/imported/w3c:

Adjust test expectation now that contain: strict is supported.

web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt:

Source/WebCore:

This patch implements paint containment as specified[1].

It adds shouldApplyPaintContainment to check whether the element applies for paint containment. Is so, then:

an independent formatting context is established.
an absolute positioning and fixed positioning containing block is established.
a stacking context is created.
implements clipping on the overflow clip edge.

This patch also adds effectiveOverflowX/effectiveOverflowY on RenderElement to take
the effect of paint containment on overflow-x/y into account.

[1] https://drafts.csswg.org/css-contain-2/#paint-containment

page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):

rendering/RenderBox.cpp:

(WebCore::RenderBox::updateFromStyle):
(WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
(WebCore::RenderBox::constrainLogicalHeightByMinMax const):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::addOverflowFromChild):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::updateFromStyle):

rendering/RenderElement.cpp:

(WebCore::includeNonFixedHeight):
(WebCore::RenderElement::effectiveOverflowX const):
(WebCore::RenderElement::effectiveOverflowY const):

rendering/RenderElement.h:

(WebCore::RenderElement::effectiveOverflowInlineDirection const):
(WebCore::RenderElement::effectiveOverflowBlockDirection const):
(WebCore::RenderElement::canContainFixedPositionObjects const):
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisOverflowForChild const):
(WebCore::RenderFlexibleBox::crossAxisOverflowForChild const):

rendering/RenderFragmentContainer.cpp:

(WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion):

rendering/RenderInline.h:
rendering/RenderLayer.cpp:

(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
(WebCore::RenderLayer::calculateClipRects const):

rendering/RenderObject.cpp:

(WebCore::RenderObject::setPaintContainmentApplies):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
(WebCore::shouldApplyPaintContainment):

rendering/RenderObject.h:

(WebCore::RenderObject::paintContainmentApplies const):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::containsPaint const):
(WebCore::RenderStyle::overflowInlineDirection const): Deleted.
(WebCore::RenderStyle::overflowBlockDirection const): Deleted.

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::shouldApplyViewportClip const):

LayoutTests:

Unskip tests that pass now.

TestExpectations:

2:19 PM Changeset in webkit [285884] by Russell Epstein

2 edits in branches/safari-612.3.6.0-branch/Source/WebKit

Cherry-pick r283386. rdar://problem/83953959

Protect WebFrame during invalidatePolicyListener()
https://bugs.webkit.org/show_bug.cgi?id=229981
<rdar://problem/82807413>

Reviewed by Alex Christensen.

WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::invalidatePolicyListeners): Protect the WebFrame while policy handlers are run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@283386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:05 PM Changeset in webkit [285883] by Simon Fraser

4 edits in trunk/Source/WebCore

Use IOHIDEvent timestamps for momentum velocity computation
https://bugs.webkit.org/show_bug.cgi?id=233168

Reviewed by Tim Horton.

NSEvent timetamps can have some jitter on some devices (rdar://85309639) so drop
down to IOHIDEvent timestamps when computing the initial velocity for a momentum
scroll animation, for improved accuracy.

page/mac/WheelEventDeltaFilterMac.h:
page/mac/WheelEventDeltaFilterMac.mm:

(WebCore::WheelEventDeltaFilterMac::updateFromEvent):
(WebCore::WheelEventDeltaFilterMac::reset):

page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::willStartRenderingUpdate):

1:53 PM Changeset in webkit [285882] by Russell Epstein

8 edits in branches/safari-612.3.6.0-branch/Source

Versioning.

WebKit-7612.3.6.0.3

1:19 PM Changeset in webkit [285881] by mmaxfield@apple.com

37 edits
91 copies
17 adds in trunk/Source

[WebGPU] Start preparing for serializing commands to the GPU process
https://bugs.webkit.org/show_bug.cgi?id=233179

Reviewed by Alex Christensen.

Source/WebCore/PAL:

Tiny cleanups. Forward-declare things that can be forward declared.

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h:
pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h:
pal/graphics/WebGPU/WebGPUBufferBinding.h:
pal/graphics/WebGPU/WebGPUComputePassTimestampWrites.h:
pal/graphics/WebGPU/WebGPUImageCopyBuffer.h:
pal/graphics/WebGPU/WebGPUImageCopyTexture.h:
pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h:
pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h:
pal/graphics/WebGPU/WebGPUProgrammableStage.h:
pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassTimestampWrites.h:

Source/WebKit:

The interaction between WebGPU and the GPU process will work as such:

We have a virtual interface in PAL which holds 3 things:

a) Refcounted objects (command buffer, queue, device, etc.).
b) Structs holding descriptors for commands. E.g. device.createRenderPipeline(RenderPipelineDescriptor)
c) Enums

The virtual interface holds all 3 of these things. For refcounted objects, it holds virtual interfaces with no
implementations. (There is one implementation of these interfaces which connects them to WebGPU.framework.)

This patch adds a new implementation of these virtual interfaces, called Remote*Proxy, in WebKit/WebProcess/GPU/graphics/WebGPU. The implementation of all the methods in this implementation will simply send messages to the GPU process. In this patch, these methods are still stubs - they'll be filled in in a subsequent patch.
The arguments to the commands consist of the structs and enums from PAL. However, we can't use the structs directly, because the structs hold references to the refcounted objects. E.g. a BindGroupDescriptor holds a reference to the Buffer which should be part of the bind group. We can't send refcounted objects across IPC, so instead of sending the objects, we send a WebGPUIdentifier instead. Every refcounted object gets a unique WebGPU identifier. However, because these references to RefCounted objects are buried deep inside nested structs, we can't simply use the structs out of the box. Instead, we have to have a parallel set of structs, where the references are replaced with WebGPUIdentifiers. These structs will be the ones actually sent across the wire.
The enums don't have this problem, so those are untouched. A subsequent patch will be adding the EnumTraits directly in PAL to make them serializable.
Upon receiving a struct from the wire, we're going to have to convert it back into its corresponding PAL type, which means we have to find the object associated with the WebGPUIdentifier. The serializers themselves can't do this, because they lack the context necessary for performing the lookup. This patch adds two new context objects which we'll use ourselves when implementing our own conversions - ConvertToBackingContext and ConvertFromBackingContext. Only the first one is implemented in this patch; the second will be implemented in a subsequent patch.
The GPU process side won't actually implement the virtual interface - only the web process side will implement it. Instead, the GPU process has to manage lifetime of the objects. Just like how 2D canvas in the GPU process has a RemoteResourceCache, the WebGPU objects will be owned by a high-level object in the GPU process. The ownership will be top-down in the GPU process, where Devices have strong references to Textures, and Textures have strong references to TextureViews. On the other hand, in the Web process, ownership will be bottom-up: JavaScript will have strong references to TextureViews, TextureViews will have strong references to Textures, and Textures will have strong references to Devices. This works out quite nicely - it means that, when GC runs and a TextureView gets deleted, the TextureView tells its owner that it's getting destroyed, its owner sends a message to the GPU process, and the corresponding owner in the GPU process looks up its relevant child in its children list, and delete it. Easy peasy.

No new tests because there is no behavior change (yet). We're getting close, though!

Shared/WebGPU/WebGPUBindGroupDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h.
Shared/WebGPU/WebGPUBindGroupEntry.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h.
Shared/WebGPU/WebGPUBindGroupLayoutDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUBindGroupLayoutEntry.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUBlendComponent.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUBlendState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUBufferBinding.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUBufferBindingLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUBufferDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUCanvasConfiguration.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyTexture.h.
Shared/WebGPU/WebGPUColor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUColorTargetState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUCommandBufferDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUCommandEncoderDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUComputePassDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUComputePassTimestampWrites.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUComputePassTimestampWrites.h.
Shared/WebGPU/WebGPUComputePipelineDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUConvertFromBackingContext.h: Added.
Shared/WebGPU/WebGPUConvertToBackingContext.h: Added.
Shared/WebGPU/WebGPUDepthStencilState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUDeviceDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h.
Shared/WebGPU/WebGPUExtent3D.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassTimestampWrites.h.
Shared/WebGPU/WebGPUExternalTextureBindingLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUExternalTextureDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUFragmentState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUIdentifier.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUImageCopyBuffer.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUImageCopyExternalImage.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUImageCopyTexture.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyTexture.h.
Shared/WebGPU/WebGPUImageCopyTextureTagged.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUImageDataLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUMultisampleState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUObjectDescriptorBase.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUOrigin2D.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPUOrigin3D.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPUPipelineDescriptorBase.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUPipelineLayoutDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPUPrimitiveState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUProgrammableStage.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUProgrammableStage.h.
Shared/WebGPU/WebGPUQuerySetDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h.
Shared/WebGPU/WebGPURenderBundleDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPURenderBundleEncoderDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPURenderPassColorAttachment.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h.
Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.
Shared/WebGPU/WebGPURenderPassDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPURenderPassLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPURenderPassTimestampWrites.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassTimestampWrites.h.
Shared/WebGPU/WebGPURenderPipelineDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPURequestAdapterOptions.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Shared/WebGPU/WebGPUSamplerBindingLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUSamplerDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUShaderModuleDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUStencilFaceState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUStorageTextureBindingLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUTextureBindingLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUTextureDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUTextureViewDescriptor.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h.
Shared/WebGPU/WebGPUVertexAttribute.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyBuffer.h.
Shared/WebGPU/WebGPUVertexBufferLayout.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h.
Shared/WebGPU/WebGPUVertexState.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUBufferBinding.h.
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteAdapterProxy::RemoteAdapterProxy):
(WebKit::WebGPU::RemoteAdapterProxy::~RemoteAdapterProxy):
(WebKit::WebGPU::RemoteAdapterProxy::requestDevice):

WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteBindGroupLayoutProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteBindGroupLayoutProxy::RemoteBindGroupLayoutProxy):
(WebKit::WebGPU::RemoteBindGroupLayoutProxy::~RemoteBindGroupLayoutProxy):
(WebKit::WebGPU::RemoteBindGroupLayoutProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteBindGroupLayoutProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteBindGroupProxy::RemoteBindGroupProxy):
(WebKit::WebGPU::RemoteBindGroupProxy::~RemoteBindGroupProxy):
(WebKit::WebGPU::RemoteBindGroupProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteBindGroupProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteBufferProxy::RemoteBufferProxy):
(WebKit::WebGPU::RemoteBufferProxy::~RemoteBufferProxy):
(WebKit::WebGPU::RemoteBufferProxy::mapAsync):
(WebKit::WebGPU::RemoteBufferProxy::getMappedRange):
(WebKit::WebGPU::RemoteBufferProxy::unmap):
(WebKit::WebGPU::RemoteBufferProxy::destroy):
(WebKit::WebGPU::RemoteBufferProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteCommandBufferProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteCommandBufferProxy::RemoteCommandBufferProxy):
(WebKit::WebGPU::RemoteCommandBufferProxy::~RemoteCommandBufferProxy):
(WebKit::WebGPU::RemoteCommandBufferProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteCommandBufferProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp: Added.

(WebKit::WebGPU::RemoteCommandEncoderProxy::RemoteCommandEncoderProxy):
(WebKit::WebGPU::RemoteCommandEncoderProxy::~RemoteCommandEncoderProxy):
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyBufferToBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyBufferToTexture):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyTextureToBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::copyTextureToTexture):
(WebKit::WebGPU::RemoteCommandEncoderProxy::fillBuffer):
(WebKit::WebGPU::RemoteCommandEncoderProxy::pushDebugGroup):
(WebKit::WebGPU::RemoteCommandEncoderProxy::popDebugGroup):
(WebKit::WebGPU::RemoteCommandEncoderProxy::insertDebugMarker):
(WebKit::WebGPU::RemoteCommandEncoderProxy::writeTimestamp):
(WebKit::WebGPU::RemoteCommandEncoderProxy::resolveQuerySet):
(WebKit::WebGPU::RemoteCommandEncoderProxy::finish):
(WebKit::WebGPU::RemoteCommandEncoderProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.cpp: Added.

(WebKit::WebGPU::RemoteComputePassEncoderProxy::RemoteComputePassEncoderProxy):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::~RemoteComputePassEncoderProxy):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::dispatch):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::dispatchIndirect):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::beginPipelineStatisticsQuery):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::endPipelineStatisticsQuery):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::endPass):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::setBindGroup):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::pushDebugGroup):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::popDebugGroup):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::insertDebugMarker):
(WebKit::WebGPU::RemoteComputePassEncoderProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteComputePassEncoderProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteComputePipelineProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteComputePipelineProxy::RemoteComputePipelineProxy):
(WebKit::WebGPU::RemoteComputePipelineProxy::~RemoteComputePipelineProxy):
(WebKit::WebGPU::RemoteComputePipelineProxy::getBindGroupLayout):
(WebKit::WebGPU::RemoteComputePipelineProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteComputePipelineProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: Added.

(WebKit::WebGPU::RemoteDeviceProxy::RemoteDeviceProxy):
(WebKit::WebGPU::RemoteDeviceProxy::~RemoteDeviceProxy):
(WebKit::WebGPU::RemoteDeviceProxy::destroy):
(WebKit::WebGPU::RemoteDeviceProxy::createBuffer):
(WebKit::WebGPU::RemoteDeviceProxy::createTexture):
(WebKit::WebGPU::RemoteDeviceProxy::createSampler):
(WebKit::WebGPU::RemoteDeviceProxy::importExternalTexture):
(WebKit::WebGPU::RemoteDeviceProxy::createBindGroupLayout):
(WebKit::WebGPU::RemoteDeviceProxy::createPipelineLayout):
(WebKit::WebGPU::RemoteDeviceProxy::createBindGroup):
(WebKit::WebGPU::RemoteDeviceProxy::createShaderModule):
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipeline):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipeline):
(WebKit::WebGPU::RemoteDeviceProxy::createComputePipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderPipelineAsync):
(WebKit::WebGPU::RemoteDeviceProxy::createCommandEncoder):
(WebKit::WebGPU::RemoteDeviceProxy::createRenderBundleEncoder):
(WebKit::WebGPU::RemoteDeviceProxy::createQuerySet):
(WebKit::WebGPU::RemoteDeviceProxy::pushErrorScope):
(WebKit::WebGPU::RemoteDeviceProxy::popErrorScope):
(WebKit::WebGPU::RemoteDeviceProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteExternalTextureProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteExternalTextureProxy::RemoteExternalTextureProxy):
(WebKit::WebGPU::RemoteExternalTextureProxy::~RemoteExternalTextureProxy):
(WebKit::WebGPU::RemoteExternalTextureProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteExternalTextureProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteGPUProxy::RemoteGPUProxy):
(WebKit::WebGPU::RemoteGPUProxy::~RemoteGPUProxy):
(WebKit::WebGPU::RemoteGPUProxy::requestAdapter):

WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemotePipelineLayoutProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemotePipelineLayoutProxy::RemotePipelineLayoutProxy):
(WebKit::WebGPU::RemotePipelineLayoutProxy::~RemotePipelineLayoutProxy):
(WebKit::WebGPU::RemotePipelineLayoutProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemotePipelineLayoutProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteQuerySetProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteQuerySetProxy::RemoteQuerySetProxy):
(WebKit::WebGPU::RemoteQuerySetProxy::~RemoteQuerySetProxy):
(WebKit::WebGPU::RemoteQuerySetProxy::destroy):
(WebKit::WebGPU::RemoteQuerySetProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteQuerySetProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp: Added.

(WebKit::WebGPU::RemoteQueueProxy::RemoteQueueProxy):
(WebKit::WebGPU::RemoteQueueProxy::~RemoteQueueProxy):
(WebKit::WebGPU::RemoteQueueProxy::submit):
(WebKit::WebGPU::RemoteQueueProxy::onSubmittedWorkDone):
(WebKit::WebGPU::RemoteQueueProxy::writeBuffer):
(WebKit::WebGPU::RemoteQueueProxy::writeTexture):
(WebKit::WebGPU::RemoteQueueProxy::copyExternalImageToTexture):
(WebKit::WebGPU::RemoteQueueProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp: Added.

(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::RemoteRenderBundleEncoderProxy):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::~RemoteRenderBundleEncoderProxy):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setIndexBuffer):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setVertexBuffer):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::draw):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::drawIndexed):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::drawIndirect):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::drawIndexedIndirect):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setBindGroup):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::pushDebugGroup):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::popDebugGroup):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::insertDebugMarker):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::finish):
(WebKit::WebGPU::RemoteRenderBundleEncoderProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteRenderBundleProxy::RemoteRenderBundleProxy):
(WebKit::WebGPU::RemoteRenderBundleProxy::~RemoteRenderBundleProxy):
(WebKit::WebGPU::RemoteRenderBundleProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp: Added.

(WebKit::WebGPU::RemoteRenderPassEncoderProxy::RemoteRenderPassEncoderProxy):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::~RemoteRenderPassEncoderProxy):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setPipeline):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setIndexBuffer):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setVertexBuffer):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::draw):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::drawIndexed):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::drawIndirect):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::drawIndexedIndirect):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setBindGroup):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::pushDebugGroup):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::popDebugGroup):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::insertDebugMarker):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setViewport):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setScissorRect):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setBlendConstant):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setStencilReference):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::beginOcclusionQuery):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::endOcclusionQuery):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::beginPipelineStatisticsQuery):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::endPipelineStatisticsQuery):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::executeBundles):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::endPass):
(WebKit::WebGPU::RemoteRenderPassEncoderProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.h: Added.
WebProcess/GPU/graphics/WebGPU/RemoteRenderPipelineProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteRenderPipelineProxy::RemoteRenderPipelineProxy):
(WebKit::WebGPU::RemoteRenderPipelineProxy::~RemoteRenderPipelineProxy):
(WebKit::WebGPU::RemoteRenderPipelineProxy::getBindGroupLayout):
(WebKit::WebGPU::RemoteRenderPipelineProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteRenderPipelineProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteSamplerProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUProgrammableStage.h.

(WebKit::WebGPU::RemoteSamplerProxy::RemoteSamplerProxy):
(WebKit::WebGPU::RemoteSamplerProxy::~RemoteSamplerProxy):
(WebKit::WebGPU::RemoteSamplerProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteSamplerProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteShaderModuleProxy::RemoteShaderModuleProxy):
(WebKit::WebGPU::RemoteShaderModuleProxy::~RemoteShaderModuleProxy):
(WebKit::WebGPU::RemoteShaderModuleProxy::compilationInfo):
(WebKit::WebGPU::RemoteShaderModuleProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteShaderModuleProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteTextureProxy::RemoteTextureProxy):
(WebKit::WebGPU::RemoteTextureProxy::~RemoteTextureProxy):
(WebKit::WebGPU::RemoteTextureProxy::createView const):
(WebKit::WebGPU::RemoteTextureProxy::destroy):
(WebKit::WebGPU::RemoteTextureProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/RemoteTextureViewProxy.cpp: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h.

(WebKit::WebGPU::RemoteTextureViewProxy::RemoteTextureViewProxy):
(WebKit::WebGPU::RemoteTextureViewProxy::~RemoteTextureViewProxy):
(WebKit::WebGPU::RemoteTextureViewProxy::setLabelInternal):

WebProcess/GPU/graphics/WebGPU/RemoteTextureViewProxy.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h.
WebProcess/GPU/graphics/WebGPU/WebGPUDowncastConvertToBackingContext.cpp: Added.

(WebKit::WebGPU::DowncastConvertToBackingContext::convertToBacking):

WebProcess/GPU/graphics/WebGPU/WebGPUDowncastConvertToBackingContext.h: Added.
WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBackend.cpp:

12:55 PM Changeset in webkit [285880] by ysuzuki@apple.com

2 edits in trunk/Source/bmalloc

Unreviewed, -latomic is only available for GCC
https://bugs.webkit.org/show_bug.cgi?id=233097

CMakeLists.txt:

12:24 PM Changeset in webkit [285879] by mmaxfield@apple.com

177 edits in trunk/Source/WebCore/PAL

[WebGPU] Fix namespace comments
https://bugs.webkit.org/show_bug.cgi?id=233169

Reviewed by Alex Christensen.

Purely mechanical.

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h:
pal/graphics/WebGPU/Impl/WebGPUBindGroupImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUBindGroupImpl.h:
pal/graphics/WebGPU/Impl/WebGPUBindGroupLayoutImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUBindGroupLayoutImpl.h:
pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUBufferImpl.h:
pal/graphics/WebGPU/Impl/WebGPUCommandBufferImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUCommandBufferImpl.h:
pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPUComputePipelineImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUComputePipelineImpl.h:
pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:
pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.h:
pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h:
pal/graphics/WebGPU/Impl/WebGPUDowncastConvertToBackingContext.cpp:
pal/graphics/WebGPU/Impl/WebGPUDowncastConvertToBackingContext.h:
pal/graphics/WebGPU/Impl/WebGPUExternalTextureImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUExternalTextureImpl.h:
pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUImpl.h:
pal/graphics/WebGPU/Impl/WebGPUPipelineLayoutImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUPipelineLayoutImpl.h:
pal/graphics/WebGPU/Impl/WebGPUQuerySetImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUQuerySetImpl.h:
pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUQueueImpl.h:
pal/graphics/WebGPU/Impl/WebGPURenderBundleEncoderImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPURenderBundleEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPURenderBundleImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPURenderBundleImpl.h:
pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPURenderPipelineImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPURenderPipelineImpl.h:
pal/graphics/WebGPU/Impl/WebGPUSamplerImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUSamplerImpl.h:
pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.h:
pal/graphics/WebGPU/Impl/WebGPUTextureImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUTextureImpl.h:
pal/graphics/WebGPU/Impl/WebGPUTextureViewImpl.cpp:
pal/graphics/WebGPU/Impl/WebGPUTextureViewImpl.h:
pal/graphics/WebGPU/WebGPU.h:
pal/graphics/WebGPU/WebGPUAdapter.h:
pal/graphics/WebGPU/WebGPUAddressMode.h:
pal/graphics/WebGPU/WebGPUBindGroup.h:
pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h:
pal/graphics/WebGPU/WebGPUBindGroupEntry.h:
pal/graphics/WebGPU/WebGPUBindGroupLayout.h:
pal/graphics/WebGPU/WebGPUBindGroupLayoutDescriptor.h:
pal/graphics/WebGPU/WebGPUBindGroupLayoutEntry.h:
pal/graphics/WebGPU/WebGPUBlendComponent.h:
pal/graphics/WebGPU/WebGPUBlendFactor.h:
pal/graphics/WebGPU/WebGPUBlendOperation.h:
pal/graphics/WebGPU/WebGPUBlendState.h:
pal/graphics/WebGPU/WebGPUBuffer.h:
pal/graphics/WebGPU/WebGPUBufferBinding.h:
pal/graphics/WebGPU/WebGPUBufferBindingLayout.h:
pal/graphics/WebGPU/WebGPUBufferBindingType.h:
pal/graphics/WebGPU/WebGPUBufferDescriptor.h:
pal/graphics/WebGPU/WebGPUBufferUsage.h:
pal/graphics/WebGPU/WebGPUCanvasCompositingAlphaMode.h:
pal/graphics/WebGPU/WebGPUCanvasConfiguration.h:
pal/graphics/WebGPU/WebGPUColor.h:
pal/graphics/WebGPU/WebGPUColorTargetState.h:
pal/graphics/WebGPU/WebGPUColorWrite.h:
pal/graphics/WebGPU/WebGPUCommandBuffer.h:
pal/graphics/WebGPU/WebGPUCommandBufferDescriptor.h:
pal/graphics/WebGPU/WebGPUCommandEncoder.h:
pal/graphics/WebGPU/WebGPUCommandEncoderDescriptor.h:
pal/graphics/WebGPU/WebGPUCompareFunction.h:
pal/graphics/WebGPU/WebGPUCompilationInfo.h:
pal/graphics/WebGPU/WebGPUCompilationMessage.h:
pal/graphics/WebGPU/WebGPUCompilationMessageType.h:
pal/graphics/WebGPU/WebGPUComputePassDescriptor.h:
pal/graphics/WebGPU/WebGPUComputePassEncoder.h:
pal/graphics/WebGPU/WebGPUComputePassTimestampLocation.h:
pal/graphics/WebGPU/WebGPUComputePassTimestampWrites.h:
pal/graphics/WebGPU/WebGPUComputePipeline.h:
pal/graphics/WebGPU/WebGPUComputePipelineDescriptor.h:
pal/graphics/WebGPU/WebGPUCullMode.h:
pal/graphics/WebGPU/WebGPUDepthStencilState.h:
pal/graphics/WebGPU/WebGPUDevice.h:
pal/graphics/WebGPU/WebGPUDeviceDescriptor.h:
pal/graphics/WebGPU/WebGPUDeviceLostInfo.h:
pal/graphics/WebGPU/WebGPUDeviceLostReason.h:
pal/graphics/WebGPU/WebGPUError.h:
pal/graphics/WebGPU/WebGPUErrorFilter.h:
pal/graphics/WebGPU/WebGPUExtent3D.h:
pal/graphics/WebGPU/WebGPUExternalTexture.h:
pal/graphics/WebGPU/WebGPUExternalTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUExternalTextureDescriptor.h:
pal/graphics/WebGPU/WebGPUFeatureName.h:
pal/graphics/WebGPU/WebGPUFilterMode.h:
pal/graphics/WebGPU/WebGPUFragmentState.h:
pal/graphics/WebGPU/WebGPUFrontFace.h:
pal/graphics/WebGPU/WebGPUImageCopyBuffer.h:
pal/graphics/WebGPU/WebGPUImageCopyExternalImage.h:
pal/graphics/WebGPU/WebGPUImageCopyTexture.h:
pal/graphics/WebGPU/WebGPUImageCopyTextureTagged.h:
pal/graphics/WebGPU/WebGPUImageDataLayout.h:
pal/graphics/WebGPU/WebGPUIndexFormat.h:
pal/graphics/WebGPU/WebGPUIntegralTypes.h:
pal/graphics/WebGPU/WebGPULoadOp.h:
pal/graphics/WebGPU/WebGPUMapMode.h:
pal/graphics/WebGPU/WebGPUMultisampleState.h:
pal/graphics/WebGPU/WebGPUObjectDescriptorBase.h:
pal/graphics/WebGPU/WebGPUOrigin2D.h:
pal/graphics/WebGPU/WebGPUOrigin3D.h:
pal/graphics/WebGPU/WebGPUOutOfMemoryError.h:
pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h:
pal/graphics/WebGPU/WebGPUPipelineLayout.h:
pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h:
pal/graphics/WebGPU/WebGPUPipelineStatisticName.h:
pal/graphics/WebGPU/WebGPUPowerPreference.h:
pal/graphics/WebGPU/WebGPUPredefinedColorSpace.h:
pal/graphics/WebGPU/WebGPUPrimitiveState.h:
pal/graphics/WebGPU/WebGPUPrimitiveTopology.h:
pal/graphics/WebGPU/WebGPUProgrammableStage.h:
pal/graphics/WebGPU/WebGPUQuerySet.h:
pal/graphics/WebGPU/WebGPUQuerySetDescriptor.h:
pal/graphics/WebGPU/WebGPUQueryType.h:
pal/graphics/WebGPU/WebGPUQueue.h:
pal/graphics/WebGPU/WebGPURenderBundle.h:
pal/graphics/WebGPU/WebGPURenderBundleDescriptor.h:
pal/graphics/WebGPU/WebGPURenderBundleEncoder.h:
pal/graphics/WebGPU/WebGPURenderBundleEncoderDescriptor.h:
pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDescriptor.h:
pal/graphics/WebGPU/WebGPURenderPassEncoder.h:
pal/graphics/WebGPU/WebGPURenderPassLayout.h:
pal/graphics/WebGPU/WebGPURenderPassTimestampLocation.h:
pal/graphics/WebGPU/WebGPURenderPassTimestampWrites.h:
pal/graphics/WebGPU/WebGPURenderPipeline.h:
pal/graphics/WebGPU/WebGPURenderPipelineDescriptor.h:
pal/graphics/WebGPU/WebGPURequestAdapterOptions.h:
pal/graphics/WebGPU/WebGPUSampler.h:
pal/graphics/WebGPU/WebGPUSamplerBindingLayout.h:
pal/graphics/WebGPU/WebGPUSamplerBindingType.h:
pal/graphics/WebGPU/WebGPUSamplerDescriptor.h:
pal/graphics/WebGPU/WebGPUShaderModule.h:
pal/graphics/WebGPU/WebGPUShaderModuleDescriptor.h:
pal/graphics/WebGPU/WebGPUShaderStage.h:
pal/graphics/WebGPU/WebGPUStencilFaceState.h:
pal/graphics/WebGPU/WebGPUStencilOperation.h:
pal/graphics/WebGPU/WebGPUStorageTextureAccess.h:
pal/graphics/WebGPU/WebGPUStorageTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUStoreOp.h:
pal/graphics/WebGPU/WebGPUSupportedFeatures.h:
pal/graphics/WebGPU/WebGPUSupportedLimits.h:
pal/graphics/WebGPU/WebGPUTexture.h:
pal/graphics/WebGPU/WebGPUTextureAspect.h:
pal/graphics/WebGPU/WebGPUTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUTextureDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureDimension.h:
pal/graphics/WebGPU/WebGPUTextureFormat.h:
pal/graphics/WebGPU/WebGPUTextureSampleType.h:
pal/graphics/WebGPU/WebGPUTextureUsage.h:
pal/graphics/WebGPU/WebGPUTextureView.h:
pal/graphics/WebGPU/WebGPUTextureViewDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureViewDimension.h:
pal/graphics/WebGPU/WebGPUUncapturedErrorEvent.h:
pal/graphics/WebGPU/WebGPUUncapturedErrorEventInit.h:
pal/graphics/WebGPU/WebGPUValidationError.h:
pal/graphics/WebGPU/WebGPUVertexAttribute.h:
pal/graphics/WebGPU/WebGPUVertexBufferLayout.h:
pal/graphics/WebGPU/WebGPUVertexFormat.h:
pal/graphics/WebGPU/WebGPUVertexState.h:
pal/graphics/WebGPU/WebGPUVertexStepMode.h:

12:20 PM Changeset in webkit [285878] by pvollan@apple.com

3 edits in trunk/Source/WebKit

Adjust graphics related message filter
https://bugs.webkit.org/show_bug.cgi?id=233151
<rdar://problem/85430575>

Reviewed by Brent Fulgham.

Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies
the filter for different OS versions.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

WebProcess/com.apple.WebProcess.sb.in:

11:55 AM Changeset in webkit [285877] by Chris Dumez

4 edits in trunk

Crash under WebKit::WebPageProxy::commitProvisionalPage()
https://bugs.webkit.org/show_bug.cgi?id=233199
<rdar://57659921>

Reviewed by Youenn Fablet.

Source/WebKit:

In the event where the committed WebProcess would crash while a cross-site provisional load
is going on in a provisional page / WebProcess, we would do a null dereference of the page's
drawing area when trying to commit the provisional page later on. We would also hit various
assertions in debug since the page's state gets completely reset when its WebProcess crashes.

To address the issue, we now clear the provisional page if the page's WebProcess crashes.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

11:49 AM Changeset in webkit [285876] by Fujii Hironori

3 edits in trunk/Tools

[Win][MiniBrowser][WK2] Show a message box for a provisional navigation failure
https://bugs.webkit.org/show_bug.cgi?id=233170

Reviewed by Don Olmstead.

Show a MessageBox if a provisional navigation failed.

MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::WebKitBrowserWindow):
(WebKitBrowserWindow::didFailProvisionalNavigation):

MiniBrowser/win/WebKitBrowserWindow.h:

11:31 AM Changeset in webkit [285875] by zhifei_fang@apple.com

4 edits in trunk/Tools

Make run-javascript-core-test and run-jsc-stress-tests support a customized identity file
https://bugs.webkit.org/show_bug.cgi?id=232453

Reviewed by Ryan Haddad.

Scripts/run-javascriptcore-tests: Add idFilePath field for remote config.
Scripts/run-jsc-stress-tests: Add idFilePath field for remote config.
Scripts/webkitdirs.pm:

(determineNativeArchitecture): Provide -i option to ssh

11:26 AM Changeset in webkit [285874] by commit-queue@webkit.org

14 edits in trunk/LayoutTests

AX: Simplify tests changed in https://bugs.webkit.org/show_bug.cgi?id=233085
https://bugs.webkit.org/show_bug.cgi?id=233167

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-16
Reviewed by Andres Gonzalez.

In https://bugs.webkit.org/show_bug.cgi?id=233085 and https://bugs.webkit.org/show_bug.cgi?id=233017,
we made some tests async so that they passed in --release --accessibility-isolated-tree mode. However,
we can make these tests simpler and still pass — i.e., only wait for elements and expressions asynchronously
when it's absolutely necessary.

accessibility/color-well.html:
accessibility/mac/header-expected.txt:
accessibility/mac/header.html:
accessibility/mac/scrollbars.html:
accessibility/placeholder.html:
accessibility/progressbar.html:
accessibility/range-alter-by-percent-expected.txt:
accessibility/range-alter-by-percent.html:
accessibility/range-alter-by-step-expected.txt:
accessibility/range-alter-by-step.html:
accessibility/spinbutton-value-expected.txt:
accessibility/spinbutton-value.html:

Simplify these tests by only use async waiting when
necessary (i.e. dynamic mutation via JS)

resources/accessibility-helper.js:

(async expectAsyncExpression):
(async waitForExpression): Renamed to expectAsyncExpression.

10:27 AM Changeset in webkit [285873] by Chris Dumez

4 edits in trunk

[iOS] Do not require the web browser entitlement to opt into captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=233191

Reviewed by Brent Fulgham.

Source/WebKit:

Do not require the web browser entitlement to opt into captive portal mode on iOS, only require
it to opt out.

UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):

Tools:

Update API test coverage accordingly.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

10:14 AM Changeset in webkit [285872] by Andres Gonzalez

5 edits in trunk

Fix for accessibility/mac/replace-text-with-range-on-webarea-element.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=233160
<rdar://problem/85436385>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/mac/replace-text-with-range-on-webarea-element.html

The replacement and insertion text string is now properly isolatedCopied
in the AXIsolatedObject method instead of in the wrapper.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::replaceTextInRange):
(WebCore::AXIsolatedObject::insertText):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityReplaceRange:withText:]):
(-[WebAccessibilityObjectWrapper accessibilityInsertText:]):

Tools:

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::replaceTextInRange):
Dispatches to the AX thread the call to the wrapper's
[accessibilityReplaceRange withText:] method.

9:47 AM Changeset in webkit [285871] by Jonathan Bedard

2 edits in trunk

Add my GitHub username to contributors.json

Reviewed by Jonathan Bedard

metadata/contributors.json:

Canonical link: https://commits.webkit.org/244297@main

9:39 AM Changeset in webkit [285870] by beidson@apple.com

2 edits in trunk/Tools

Enable webpushd tests in the iOS simulator.
https://bugs.webkit.org/show_bug.cgi?id=233149

Reviewed by Alex Christensen.

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::testWebPushDaemonPList): Add a key to allow an OSLaunchdJob executable to break out of the simulator runtime root.

9:11 AM Changeset in webkit [285869] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[macOS][GPUP] Add telemetry for syscalls
https://bugs.webkit.org/show_bug.cgi?id=232888
<rdar://problem/85207011>

Reviewed by Brent Fulgham.

Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Scripts/process-entitlements.sh:

9:11 AM Changeset in webkit [285868] by mmaxfield@apple.com

6 edits in trunk/Source/WebCore/PAL

[WebGPU] Vertex and fragment shaders are not hooked up to pipeline creation
https://bugs.webkit.org/show_bug.cgi?id=233166

Reviewed by Dean Jackson.

I simply forgot to implement them in r285831.

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:

(PAL::WebGPU::supportedLimits):

pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:

(PAL::WebGPU::convertToBacking):

9:11 AM Changeset in webkit [285867] by youenn@apple.com

3 edits in trunk/Source/WebCore

Remove unused Xcode references to ServiceWorkerGlobalScopePushAPI files
https://bugs.webkit.org/show_bug.cgi?id=233177

Reviewed by Alex Christensen.

No change of behavior.

Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
WebCore.xcodeproj/project.pbxproj:

8:57 AM Changeset in webkit [285866] by Chris Dumez

6 edits in trunk/Source/WebKit

Decoder::unwrapForTesting() is unnecessarily inefficient
https://bugs.webkit.org/show_bug.cgi?id=233145

Reviewed by Darin Adler.

Decoder::unwrapForTesting() is unnecessarily inefficient. It can take the whole
m_attachments data members from the decoder instead of calling removeAttachment()
repeatedly on the Decoder.

Also rename removeAttachment() to takeAttachment() since it returns the Attachment.
Update it to return a std::optional<Attachment> instead of using an out-parameter.

Platform/IPC/Attachment.cpp:

(IPC::Attachment::decode):

Platform/IPC/Attachment.h:
Platform/IPC/Decoder.cpp:

(IPC::Decoder::unwrapForTesting):
(IPC::Decoder::takeAttachment):
(IPC::Decoder::removeAttachment): Deleted.

Platform/IPC/Decoder.h:
Platform/IPC/win/AttachmentWin.cpp:

(IPC::Attachment::decode):

8:51 AM Changeset in webkit [285865] by Chris Dumez

2 edits in trunk/Source/WebKit

Do some hardening in IPC::createMessageDecoder()
https://bugs.webkit.org/show_bug.cgi?id=233148
<rdar://75139294>

Reviewed by Darin Adler.

Do more bound validation insde createMessageDecoder() to make sure we stay within
the bounds of our ReceiveBuffer.

Also, when the body is out of line, set out_of_line.deallocate to false since
we are taking ownership of the memory and will vm_deallocate() it ourselves.
Normally the sender (Connection::sendOutgoingMessage) sets that flag to false but
it is better not to rely on the sender setting a particular flag.

Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::createMessageDecoder):
(IPC::Connection::receiveSourceEventHandler):

8:47 AM Changeset in webkit [285864] by J Pascoe

4 edits in trunk/Source/WebKit

[WebAuthn] WebKitTestRunner/TWAPI lacks an entitlement and bundle identifier to use required [ASCAgent performAuthorizationRequestsForContext]
https://bugs.webkit.org/show_bug.cgi?id=232846
rdar://problem/85170633

Reviewed by Brent Fulgham.

Covered by existing tests.

Calling to ASC requires converting WebAuthenticationRequestData to ASCCredentialRequestContext and then making
a call to _WKAuthenticatorAssertionResponse, while also requiring entitlements currently unavailable in OpenSource.
This change avoids calling out to ASC in tests using mock / virtual authenticators to avoid this problem, the
serialization to and from ASCAgent can be tested seperately.

UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Refactor creation of ASCCredentialRequestContext.
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable):

UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:

(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
Refactor use of ASC and add clarifying comment about flow.

8:38 AM Changeset in webkit [285863] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/basic/005.html
https://bugs.webkit.org/show_bug.cgi?id=233150

Reviewed by Antti Koivisto.

Negative word-spacing acts as negative margin, pulling the content to the left. In this patch we account for such negative values when
computing the overall content width.

Note that this patch is in preparation for enabling IFC preferred width computation.

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::appendTextContent):

8:37 AM Changeset in webkit [285862] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Add support for injecting and rendering text recognition blocks
https://bugs.webkit.org/show_bug.cgi?id=233044

Reviewed by Aditya Keerthi.

Adds support for rendering text recognition blocks, which appear as opaque div elements over images. See below
for more details; no change in behavior, since nothing currently generates TextRecognitionBlockData yet.

dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::imageOverlayDataDetectorClass):
(WebCore::ImageOverlay::imageOverlayBlockClass):
(WebCore::ImageOverlay::isDataDetectorResult):
(WebCore::ImageOverlay::updateSubtree):

Add support for creating text recognition block containers in the UA shadow root, if needed.

(WebCore::ImageOverlay::fitElementToQuad):

Factor out logic to adjust the width, height and transforms on a given element to fit the given quad, and return
rotated bounding rect info; we use this in three places below.

(WebCore::ImageOverlay::updateWithTextRecognitionResult):

Add support for adjusting the size and transforms on each of the block containers created above.

(WebCore::ImageOverlay::imageOverlayDataDetectorClassName): Deleted.

Rename this to just imageOverlayDataDetectorClass() to match the other static helper functions.

html/shadow/imageOverlay.css:

(div#image-overlay):
(div.image-overlay-line):
(div.image-overlay-line, div.image-overlay-block):
(div.image-overlay-block):
(div.image-overlay-line, .image-overlay-text):

7:24 AM Changeset in webkit [285861] by commit-queue@webkit.org

4 edits in trunk

Empty <input type=file> is represented incorrectly in FormData
https://bugs.webkit.org/show_bug.cgi?id=185416

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-11-16
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:

Source/WebCore:

When a FormData object is constructed from a form, an empty <input type="file"> control will
be represented as an empty file with an empty filename. According to the HTML spec, this
file must have "application/octet-stream" as its content type. WebKit has the empty string
instead. This change brings WebKit into alignment with the standard and with Firefox and
Chrome in this area.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html

html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):

7:07 AM Changeset in webkit [285860] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/text-indent-inside-float.html
https://bugs.webkit.org/show_bug.cgi?id=233163

Reviewed by Antti Koivisto.

Percentages must be treated as 0 for the purpose of calculating intrinsic size contributions.
https://drafts.csswg.org/css-text/#text-indent-property

Note that this patch is in preparation for enabling IFC preferred width computation.

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):

layout/formattingContexts/inline/InlineLineBuilder.h: Add an "intrinsic mode" which will also be used

for other, preferred width computation specific properties and values.

6:38 AM Changeset in webkit [285859] by commit-queue@webkit.org

9 edits in trunk/Tools

AX: Stop returning AccessibilityUIElements backed by a null pointer
https://bugs.webkit.org/show_bug.cgi?id=233138

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-16
Reviewed by Andres Gonzalez.

Prior to this patch, some callers of AccessibilityUIElement::create
passed null ids, resulting in a seemingly valid AccessibilityUIElement
that is actually backed by a null pointer. This makes writing tests harder,
since you can't rely on common operations like !myElement to do the right thing.

With this patch, we add a RELEASE_ASSERT to
AccessibilityUIElement::create requiring the passed pointer to be
valid. This patch also fixes up some callsites where we could (and did) pass null pointers.

WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::AccessibilityController::focusedElement):

WebKitTestRunner/InjectedBundle/win/AccessibilityControllerWin.cpp:

(WTR::AccessibilityController::focusedElement):

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::focusedElement):
Return RefPtr instead of Ref, since it's possible that no element is
focused.

WebKitTestRunner/InjectedBundle/AccessibilityController.h:
WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::create):
Add RELEASE_ASSERT() to verify passed pointer is valid.

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::focusedElement const):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler _notificationReceived:]):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::uiElementAttributeValue const):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar const):
(WTR::AccessibilityUIElement::verticalScrollbar const):
Don't call AccessibilityUIElement::create with null pointers.

5:40 AM Changeset in webkit [285858] by Chris Lord

2 edits in trunk/Source/WebCore

[GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=233187

Reviewed by Alejandro G. Castro.

Allow scrolling thread wake-up shortcut on GTK and WPE (matching
behaviour on every other platform).

No new tests, covered by existing tests.

page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::displayDidRefresh):

3:41 AM Changeset in webkit [285857] by commit-queue@webkit.org

12 edits in trunk

Unreviewed, reverting r280078, r280290 and r282008.
https://bugs.webkit.org/show_bug.cgi?id=233184

Caused a crash in grid

Reverted changesets:

"Images as grid items should use the overridingLogicalWidth
when defined to compute the logical Height"
https://bugs.webkit.org/show_bug.cgi?id=228022
https://commits.webkit.org/r280078

"[css-grid] svg image as grid items should use the overriding
logical width/height when defined to compute the logical
height/width"
https://bugs.webkit.org/show_bug.cgi?id=228105
https://commits.webkit.org/r280290

"REGRESSION(r280078): broke fast/images/exif-orientation-
composited.html on windows"
https://bugs.webkit.org/show_bug.cgi?id=228325
https://commits.webkit.org/r282008

2:44 AM Changeset in webkit [285856] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

RemoteGraphicsContextGLCocoa::m_swapChain is unused
https://bugs.webkit.org/show_bug.cgi?id=233176

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-16
Reviewed by Antti Koivisto.

Remove the unused variable.

GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:

1:48 AM Changeset in webkit [285855] by commit-queue@webkit.org

6 edits
8 adds in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=233156

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-11-16

platform/glib/TestExpectations:
platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
platform/glib/fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
platform/glib/http/wpt/push-api/pushManager.any-expected.txt: Added.
platform/glib/http/wpt/push-api/pushManager.any.serviceworker-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/content-security-policy/connect-src/connect-src-eventsource-allowed.sub-expected.txt: Added.
platform/gtk/accessibility/color-well-expected.txt:
platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
platform/wpe/accessibility/color-well-expected.txt:

1:46 AM Changeset in webkit [285854] by cathiechen

4 edits in trunk

[CSS contain] The size should be updated if layout containment is inside a fit-content parent
https://bugs.webkit.org/show_bug.cgi?id=233046

Reviewed by Rob Buis.

Source/WebCore:

When the object is a layout containment, we also need to add size containment as the constraint of
being a relayout boundary. Otherwise when the layout size depends on the content, the layout size
might not be updated correctly.

Test: imported/w3c/web-platform-tests/css/css-contain/contain-layout-019.html

rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):

LayoutTests:

TestExpectations:

Nov 15, 2021:

11:02 PM Changeset in webkit [285853] by ysuzuki@apple.com

77 edits
1 add in trunk

[libpas] Build and enable libpas on 64bit JSCOnly
https://bugs.webkit.org/show_bug.cgi?id=233097

Reviewed by Filip Pizlo.

This patch makes libpas built on 64bit Linux. And now enabling it on JSCOnly port.
libpas is built in C and tailored to the current clang. It made building libpas on
GCC hard since GCC is stricter on C languages.

C does not handle const variables as constants. So libpas's config is not strictly constant in the C spec, and GCC actually rejects it. To make it built correctly, we need to build them in C++. In this patch, when building libpas via CMake, we build some libpas C files as C++.
GCC C++ does not allow designated initializer for array. We work-around this problem by adding cpp_initialization_t constexpr constructors only when building these headers in C++ compiler.
Atomic operations are using clang extension, so they cannot be built with GCC. This patch adds GCC version of these implementations.
Add PAS_OS(DARWIN) ifdefs for Darwin specific code (e.g. malloc handling).
Add explicit cast / PAS_UNUSED_PARAM since GCC emits warnings
Use (unsigned long long) explicit cast for printing uint64_t via %llx / %llu since uint64_t definition is unsigned long int in GCC (while clang's one is unsigned long long).
Reorder designated initializer for structures since not following to the definition ordering becomes compile error in GCC.
Use uint128_t for pas_pair in GCC to avoid compile error.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
bmalloc/BCompiler.h:
bmalloc/BPlatform.h:
bmalloc/Heap.cpp:
bmalloc/IsoHeapImplInlines.h:

(bmalloc::IsoHeapImpl<Config>::IsoHeapImpl):

libpas/src/libpas/bmalloc_heap.c:
libpas/src/libpas/bmalloc_heap_config.c:

(bmalloc_heap_config_activate):

libpas/src/libpas/bmalloc_heap_inlines.h:
libpas/src/libpas/jit_heap.c:
libpas/src/libpas/jit_heap_config.c:

(jit_page_header_for_boundary_remote):
(jit_prepare_to_enumerate):

libpas/src/libpas/jit_heap_config.h:
libpas/src/libpas/pas_basic_heap_config_enumerator_data.c:

(pas_basic_heap_config_enumerator_data_add_page_header_table):

libpas/src/libpas/pas_bitfit_page.c:

(pas_bitfit_page_deallocation_did_fail):

libpas/src/libpas/pas_bitfit_page_config_kind.c:
libpas/src/libpas/pas_bitfit_page_inlines.h:

(pas_bitfit_page_finish_allocation):
(pas_bitfit_page_allocate):
(pas_bitfit_page_deallocate_with_page_impl):

libpas/src/libpas/pas_cartesian_tree.h:

(pas_cartesian_tree_construct):

libpas/src/libpas/pas_compact_ptr.h:
libpas/src/libpas/pas_debug_spectrum.c:

(pas_debug_spectrum_dump):

libpas/src/libpas/pas_dyld_state.c:

(pas_dyld_is_libsystem_initialized):

libpas/src/libpas/pas_enumerator.c:

(pas_enumerator_record_page_payload_and_meta):

libpas/src/libpas/pas_epoch.c:

(pas_get_epoch):

libpas/src/libpas/pas_fast_large_free_heap.c:

(get_x_key_callback):
(insert_node):
(dump_heap):
(fast_write_cursor):
(fast_merge):

libpas/src/libpas/pas_fast_megapage_cache.c:

(table_set_by_index):

libpas/src/libpas/pas_fast_megapage_table.c:

(pas_fast_megapage_table_set_by_index):

libpas/src/libpas/pas_fast_megapage_table.h:

(pas_fast_megapage_table::pas_fast_megapage_table):

libpas/src/libpas/pas_generic_large_free_heap.h:

(pas_generic_large_free_heap_try_allocate):

libpas/src/libpas/pas_heap_config.h:
libpas/src/libpas/pas_heap_config_inlines.h:
libpas/src/libpas/pas_heap_config_kind.c:
libpas/src/libpas/pas_heap_config_kind.def:
libpas/src/libpas/pas_heap_config_kind.h:

(pas_heap_config_kind_get_config):
(pas_heap_config_kind_is_active):

libpas/src/libpas/pas_heap_config_utils.h:
libpas/src/libpas/pas_internal_config.h:
libpas/src/libpas/pas_intrinsic_heap_support.h:

(pas_intrinsic_heap_support::pas_intrinsic_heap_support):

libpas/src/libpas/pas_large_expendable_memory.h:
libpas/src/libpas/pas_large_free_inlines.h:

(pas_large_free_create_merged):

libpas/src/libpas/pas_large_sharing_pool.c:

(validate_min_heap):
(create_node):
(try_splat_impl):
(pas_large_sharing_pool_decommit_least_recently_used):
(pas_large_sharing_pool_validate):
(pas_large_sharing_pool_compute_summary):

libpas/src/libpas/pas_local_allocator_inlines.h:

(pas_local_allocator_scan_bits_to_set_up_free_bits):
(pas_local_allocator_try_allocate_with_free_bits):

libpas/src/libpas/pas_lock.h:

(pas_lock_unlock):

libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.c:

(pas_lock_free_read_ptr_ptr_hashtable_set):

libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.h:

(pas_lock_free_read_ptr_ptr_hashtable_find):

libpas/src/libpas/pas_min_heap.h:
libpas/src/libpas/pas_monotonic_time.c:

(pas_get_current_monotonic_time_nanoseconds):

libpas/src/libpas/pas_page_base_config_utils_inlines.h:
libpas/src/libpas/pas_page_malloc.c:

(pas_page_malloc_commit):
(decommit_impl):

libpas/src/libpas/pas_page_sharing_participant.c:

(pas_page_sharing_participant_get_parent_pool):

libpas/src/libpas/pas_page_sharing_pool.c:

(verify_participants):
(dump_min_heap):
(get_current_participant):
(pas_page_sharing_pool_take_least_recently_used):
(pas_physical_page_sharing_pool_scavenge):

libpas/src/libpas/pas_platform.h: Added.
libpas/src/libpas/pas_root.c:
libpas/src/libpas/pas_root.h:
libpas/src/libpas/pas_scavenger.c:

(scavenger_thread_main):

libpas/src/libpas/pas_scavenger.h:
libpas/src/libpas/pas_segregated_directory.c:

(pas_segregated_directory_get_use_epoch):

libpas/src/libpas/pas_segregated_directory.h:
libpas/src/libpas/pas_segregated_exclusive_view_inlines.h:

(pas_segregated_exclusive_view_did_start_allocating):

libpas/src/libpas/pas_segregated_page.c:

(pas_segregated_page_construct):
(pas_segregated_page_take_empty_granules):

libpas/src/libpas/pas_segregated_page.h:

(pas_segregated_page_offset_from_page_boundary_to_first_object_for_hugging_mode):
(pas_segregated_page_offset_from_page_boundary_to_end_of_last_object_for_hugging_mode):

libpas/src/libpas/pas_segregated_page_config_kind.c:
libpas/src/libpas/pas_segregated_page_config_kind.h:
libpas/src/libpas/pas_segregated_page_inlines.h:

(pas_segregated_page_deallocate_with_page):

libpas/src/libpas/pas_segregated_partial_view.c:

(pas_segregated_partial_view_set_is_in_use_for_allocation):

libpas/src/libpas/pas_segregated_shared_handle.c:

(pas_segregated_shared_handle_create):

libpas/src/libpas/pas_segregated_shared_page_directory.c:

(take_last_empty_consider_view):

libpas/src/libpas/pas_segregated_shared_view.c:

(compute_summary):

libpas/src/libpas/pas_segregated_size_directory.c:

(pas_segregated_size_directory_select_allocator_slow):
(take_last_empty_should_consider_view_parallel):
(take_last_empty_consider_view):

libpas/src/libpas/pas_segregated_size_directory.h:
libpas/src/libpas/pas_segregated_view_allocator_inlines.h:

(pas_segregated_view_will_start_allocating):

libpas/src/libpas/pas_simple_large_free_heap.c:

(dump_free_list):
(append):
(merge):
(simple_write_cursor):

libpas/src/libpas/pas_status_reporter.c:

(report_segregated_directory_contents):
(dump_large_sharing_pool_node_callback):

libpas/src/libpas/pas_thread_local_cache.c:

(destructor):
(allocate_cache):
(dump_thread_diagnostics):
(pas_thread_local_cache_create):
(pas_thread_local_cache_get_local_allocator_slow):
(stop_local_allocators_if_necessary_set_bit_source):
(stop_local_allocators_if_necessary_set_bit_callback):
(pas_thread_local_cache_for_all):

libpas/src/libpas/pas_try_allocate_intrinsic.h:
libpas/src/libpas/pas_utility_heap_config.c:
libpas/src/libpas/pas_utility_heap_config.h:
libpas/src/libpas/pas_utils.h:

(pas_compare_and_swap_uintptr_weak):
(pas_compare_and_swap_uintptr_strong):
(pas_compare_and_swap_bool_weak):
(pas_compare_and_swap_bool_strong):
(pas_compare_and_swap_uint8_weak):
(pas_compare_and_swap_uint16_weak):
(pas_compare_and_swap_uint32_weak):
(pas_compare_and_swap_uint32_strong):
(pas_compare_and_swap_uint64_weak):
(pas_compare_and_swap_uint64_strong):
(pas_compare_and_swap_ptr_weak):
(pas_compare_and_swap_ptr_strong):
(pas_pair_create):
(pas_compare_and_swap_pair_weak):
(pas_compare_and_swap_pair_strong):
(pas_atomic_load_pair):
(pas_atomic_store_pair):

libpas/src/libpas/pas_utils_prefix.h:

10:12 PM Changeset in webkit [285852] by ntim@apple.com

29 edits
1 copy
24 moves
6 adds
6 deletes in trunk/LayoutTests

Re-import css/css-text-decor WPT
https://bugs.webkit.org/show_bug.cgi?id=233154

Reviewed by Cameron McCormack.

Since mismatches are now properly renamed to -expected-mismatch.html on import since bug 207175,
re-import this directory to reduce numbers of false negatives/positives.

Some tests have also been added/updated/removed since.

LayoutTests/imported/w3c:

web-platform-tests/css/css-text-decor/text-decoration-propagation-display-contents-expected.html: Added.
web-platform-tests/css/css-text-decor/text-decoration-propagation-display-contents.html: Added.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-004-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-004-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-005-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-005-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-sidewayslr-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-sidewayslr-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-sidewaysrl-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-sidewaysrl-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-upright-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-upright-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-skip-ink-vertical-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink-vertical-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-subelements-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-subelements-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-thickness-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-001-expected.html.
web-platform-tests/css/css-text-decor/text-decoration-thickness-single-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-single-expected.html.
web-platform-tests/css/css-text-decor/text-emphasis-color-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-color-001.xht:
web-platform-tests/css/css-text-decor/text-emphasis-position-above-left-002-expected.xht: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-position-above-right-002-expected.xht: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-position-below-left-002-expected.xht: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-position-below-right-002-expected.xht: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-left-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-right-001-expected.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-left-001.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-left-001.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-left-002-expected.xht: Added.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-left-002.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-left-002.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-right-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-left-001-expected.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-right-001.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-right-001.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-right-002-expected.xht: Added.
web-platform-tests/css/css-text-decor/text-emphasis-position-over-right-002.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-right-002.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-left-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-above-left-001-expected.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-left-001.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-left-001.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-left-002-expected.xht: Added.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-left-002.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-left-002.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-right-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-right-001-expected.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-right-001.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-right-001.xht.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-right-002-expected.xht: Added.
web-platform-tests/css/css-text-decor/text-emphasis-position-under-right-002.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-position-below-right-002.xht.
web-platform-tests/css/css-text-decor/text-emphasis-style-002-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-002.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-006-expected.html: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-style-006.html: Removed.
web-platform-tests/css/css-text-decor/text-emphasis-style-007-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-007.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-008-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-008.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-010-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-010.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-012-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-012.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-016-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-emphasis-style-002-expected.html.
web-platform-tests/css/css-text-decor/text-emphasis-style-016.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-021-expected.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-021.html:
web-platform-tests/css/css-text-decor/text-emphasis-style-filled-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-filled-001.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-none-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-none-001.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-open-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-open-001.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-shape-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-shape-001.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-string-001-expected.xht:
web-platform-tests/css/css-text-decor/text-emphasis-style-string-001.xht:
web-platform-tests/css/css-text-decor/text-underline-offset-001-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-001-expected.html.
web-platform-tests/css/css-text-decor/text-underline-offset-negative-expected-mismatch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-underline-offset-negative-expected.html.
web-platform-tests/css/css-text-decor/w3c-import.log:

LayoutTests:

TestExpectations:

10:01 PM Changeset in webkit [285851] by Patrick Angle

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Autocomplete should support mid-line completions
https://bugs.webkit.org/show_bug.cgi?id=227411

Reviewed by Devin Rousso.

Autocompletion for CSS property values was lacking in the ability to perform mid-line completions, including
within functions, and a lack of support for multi-line CSS property values. This resolves those pain points by
making SpreadsheetTextField multi-line aware and allowing mid-line autocompletion.

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._nameCompletionDataProvider):
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):

UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.valueWithoutSuggestion):
Because suggestions can occur anywhere within the value, we need to iterate through each of the nodes and
collect the text of any of them that are not the completion suggestion.

(WI.SpreadsheetTextField.prototype.set suggestionHint):
When removing the suggestion hint element, we should recombine the text nodes we may have split upon insertion
to prevent the text content from becoming endlessly fragmented into multiple text nodes unnecessarily.

(WI.SpreadsheetTextField.prototype.startEditing):
Reset the last known caret position when editing starts so that we don't mistake keys that are already down as
having moved the cursor to its initial position.

(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
We should only attempt to reattach the suggestion hint element if we have a suggestion hint to show, otherwise
we could end up with a phantom empty suggestion hint that isn't properly placed later.

(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion):
Updated to use existing completion committing path to reduce duplicated logic.

(WI.SpreadsheetTextField.prototype._handleMouseDown):
When the user clicks inside the text field while suggestions are visible treat that as intent to stop
autocompletion similar to the escape key, since the new cursor location could be anywhere in the text field.
This behavior also matches other code editors like Xcode, where clicking outside a completion popup will dismiss
the completions list.

(WI.SpreadsheetTextField.prototype._handleKeyDown):
Keep track of where the caret was as well as if the the key event was handled by the suggestion view at the time
a key is pressed so that we can later compare the position to that of when the key is released to determine if
completions should be discarded.

(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
We can no longer assume that the current selection's offset will match the value's length, as the offset could
be on any line, or the suggestion could be in middle of a line. Because a suggestionHint only contains text when
we are in middle of autocompletion, it alone is an indicator that pressing the right arrow key should commit the
completion. document.execCommand is deprecated, so instead we now use the existing completion committing path
to reduce duplicated logic here.

Note that the left arrow key is still explicitly handled for dismissing autocompletion, as the new mechanism for
dismissing autocompletion won't trigger unless the caret has moved, and the caret will not move if you press the
left arrow key at the start of the text field.

(WI.SpreadsheetTextField.prototype._handleKeyUp):
When a key is released, we should check to see if the caret has moved as a result of the keystroke that we have
not already explicitly handled. If it has moved and was not handled, we dismiss the autocompletion suggestions.

(WI.SpreadsheetTextField.prototype._handleInput):

(WI.SpreadsheetTextField.prototype._updateCompletions):
Provide the current caret position to the completion provided.

(WI.SpreadsheetTextField.prototype._showSuggestionsView):
In order to correctly align the completion list with the current text content, it must be offset from the caret
position excluding the current prefix.

(WI.SpreadsheetTextField.prototype._getCaretPosition):
Added to get the index of the caret in the complete text value, accounting for multi-line values and mid-line
suggestions.

(WI.SpreadsheetTextField.prototype._getCaretRect):

(WI.SpreadsheetTextField.prototype._rangeAtCaretPosition):
Find the range for a caret at the given position. This compliments _getCaretPosition, and allows us to count
back some number of characters and create a range of which we later get the client rectangle.

(WI.SpreadsheetTextField.prototype._applyCompletionHint):
Add optional support for updating the caret position to be at the end of the newly inserted text.

(WI.SpreadsheetTextField.prototype._combineEditorElementChildren):
Added to handle combining the fragmented text nodes (and possibly a suggestion hint element) back into a single
text node while maintaining the current cursor position or optionally moving the cursor to a new location (e.g.
the end of a completion).

(WI.SpreadsheetTextField.prototype._reAttachSuggestionHint):
Now that completions are not guaranteed to be at the end of the value, we may need to split the text node to
insert the suggestion hint node.

7:48 PM Changeset in webkit [285850] by ysuzuki@apple.com

4 edits
1 add in trunk

[JSC] Use operation path when PutByVal child1 is not speculated as a Cell
https://bugs.webkit.org/show_bug.cgi?id=233147
rdar://85344310

Reviewed by Mark Lam.

JSTests:

stress/put-by-val-slow-dfg.js: Added.

(foo):

Source/JavaScriptCore:

r285530 removed non CellUse / non KnownCellUse case incorrectly (when we do not have Cell edge,
then we should use the slow operation path). This patch recovers it.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByVal):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):

7:20 PM Changeset in webkit [285849] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Unreviewed, reverting r285812.
https://bugs.webkit.org/show_bug.cgi?id=233162

Introduced test failures

Reverted changeset:

"[macOS][GPUP] Add telemetry for syscalls"
https://bugs.webkit.org/show_bug.cgi?id=232888
https://commits.webkit.org/r285812

7:13 PM Changeset in webkit [285848] by Russell Epstein

1 copy in tags/Safari-612.3.6.0.2

Tag Safari-612.3.6.0.2.

6:44 PM Changeset in webkit [285847] by Russell Epstein

1 copy in tags/Safari-612.3.6.1.2

Tag Safari-612.3.6.1.2.

6:11 PM Changeset in webkit [285846] by weinig@apple.com

13 edits
1 copy
11 adds in trunk/Source

Add another <model> backend backed by SceneKit to prove out ModelPlayer infrastructure a bit more
https://bugs.webkit.org/show_bug.cgi?id=233112

Reviewed by Dean Jackson.

Source/WebCore:

Adds basic SceneKit based ModelPlayer implementation. Like the ARKit player, this one
also requires writing the USD file to a temporary file as SceneKit does not support
loading USD files from NSData, and therefore is not actually something that can be used
for production yet.

The player is backed by a SceneKitModel class, which is created via a SceneKitModelLoader.
Both SceneKitModel and SceneKitModelLoader are abstract so that different types of models
can be supported. Currently, there is only a USD loader implemented for parity with the
ARKit based implementation.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

Add new files.

Modules/model-element/scenekit: Added.
Modules/model-element/scenekit/SceneKitModel.h: Added.
Modules/model-element/scenekit/SceneKitModel.mm: Added.

Abstract base class for loader specific implementations.

Modules/model-element/scenekit/SceneKitModelLoader.h: Added.
Modules/model-element/scenekit/SceneKitModelLoader.mm: Added.

(WebCore::loadSceneKitModel):
Entry point where different loaders can be referenced for different
file types. As noted above, currenly only a USD loader is implementend.

Modules/model-element/scenekit/SceneKitModelLoaderClient.h: Added.
Modules/model-element/scenekit/SceneKitModelLoaderClient.mm: Added.

Interface to pass state back to whatever requested the load.

Modules/model-element/scenekit/SceneKitModelLoaderUSD.h: Added.
Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm: Added.

Loads USD file into a SCNScene which the client can attach to a
renderer (e.g. the SCNMetalLayer).

Modules/model-element/scenekit/SceneKitModelPlayer.h: Added.
Modules/model-element/scenekit/SceneKitModelPlayer.mm: Added.

The SceneKitModelPlayer uses loadSceneKitModel() to load and build
a SCNScene asynchonously that it then attaches to its SCNMetalLayer.

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cocoa/SceneKitSPI.h: Added.

Adds forward declaration of SCNMetalLayer SPI so SceneKit can be used
without an NSView/UIView.

Source/WebKit:

Add support for instantiating the new SceneKit backed ModelPlayer.

If both ARKit based ModelPlayer and SceneKit based ModelPlayer are enabled,
the ARKit one wins.

WebProcess/Model/WebModelPlayerProvider.cpp:

(WebKit::WebModelPlayerProvider::createModelPlayer):
Add support for creating a SceneKit based ModelPlayer and add checks
for whether the backend is enabled.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::useARKitForModel const):
(WebKit::WebPage::useSceneKitForModel const):
Add bits to store which <model> backends are enabled.

Source/WTF:

Scripts/Preferences/WebPreferencesInternal.yaml:

Add some internal settings to enable/disable the ARKit and SceneKit based
<model> backends.

wtf/PlatformHave.h:

Add HAVE macro for SceneKit. Only enabled for macOS at the moment, but could
probably be enabled for iOS if it is useful.

5:42 PM Changeset in webkit [285845] by Russell Epstein

4 edits in branches/safari-613.1.9-branch/Source

Cherry-pick r285828. rdar://problem/85341122

Unreviewed, fix the internal iOS 15 build

Source/WebCore/PAL:

In the internal iOS 15 SDK, <UIKit/NSTextList.h> does not define NSTextListMarkerFormat. Add a separate SDK
version check instead and only attempt to soft-link these constants if we're compiling against an SDK that we
know exports these symbols.

pal/spi/cocoa/NSAttributedStringSPI.h:

Source/WTF:

Add a new compile-time flag.

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:42 PM Changeset in webkit [285844] by Russell Epstein

2 edits in branches/safari-613.1.9-branch/Source/WebCore/PAL

Cherry-pick r285811. rdar://problem/85341122

Declare NSTextListMarker* as type NSTextListMarkerFormat when soft-linking
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Followup to r285744. Avoid build errors due to defining these constants as a different type of symbol
(NSString * vs. NSTextListMarkerFormat). To address this, we directly import NSTextList.h if it's available in
the SDK; otherwise, fall back to defining NSTextListMarkerFormat. In both cases, we need to keep soft linking
each of these constants, since WebCore cannot explicitly link against UIKit.

pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:20 PM Changeset in webkit [285843] by ntim@apple.com

2 edits in trunk/LayoutTests

Remove redundant [ Pass ] from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=233157

Reviewed by Cameron McCormack.

TestExpectations:

5:07 PM Changeset in webkit [285842] by Russell Epstein

1 copy in tags/Safari-613.1.8.2

Tag Safari-613.1.8.2.

5:03 PM Changeset in webkit [285841] by commit-queue@webkit.org

5 edits in trunk/Source

_AXSCopyPathForAccessibilityBundle is going to be deprecated.
https://bugs.webkit.org/show_bug.cgi?id=233081

Patch by Eric Liang <ericliang@apple.com> on 2021-11-15
Reviewed by Andres Gonzalez.

To support macOS Accessibility v2 runtime, on macOS there are two places where bundles can live. By doing so, _AXSCopyPathForAccessibilityBundle will going to be deprecated because it won’t always return the correct path you would expect.

Source/WebKit:

Platform/spi/Cocoa/AccessibilitySupportSPI.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::webProcessLoaderAccessibilityBundlePath):

Source/WTF:

wtf/PlatformHave.h:

4:25 PM Changeset in webkit [285840] by Russell Epstein

5 edits in branches/safari-613.1.9-branch

Cherry-pick r285827. rdar://problem/85391118

Revert r285235
https://bugs.webkit.org/show_bug.cgi?id=233142

Unreviewed.

LayoutTests/imported/w3c:

web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt:

Source/WebCore:

Causes crash with simple repro

<div id=t style="border-radius: unset"></div>
<script>
t.style.borderRadius;
</script>

css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): Deleted.
css/StyleProperties.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:07 PM Changeset in webkit [285839] by Fujii Hironori

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Layers Tab: the position of composited layer with box-shadow is wrong
https://bugs.webkit.org/show_bug.cgi?id=233026

Reviewed by Devin Rousso.

If an element has box-shadow, Layers Tab showed the composited
layer positioned wrongly. It assumed the composited layer position
was same with its element position. This isn't true. If an element
has box-shadow, its composited layer includes the surrounding
box-shadow.

UserInterface/Models/Layer.js:

(WI.Layer):

UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView.prototype._updateLayers):
(WI.Layers3DContentView.prototype._createLayerMesh):

2:44 PM Changeset in webkit [285838] by Takashi.Komori@sony.com

6 edits in trunk/Source/WebCore

[Curl] Security information sometimes do not appear in inspector network tab
https://bugs.webkit.org/show_bug.cgi?id=232971

Reviewed by Fujii Hironori.

Get certificate information from SSL context when CurlSSLVerifier is empty.

No tests yet.

platform/network/curl/CertificateInfo.h:
platform/network/curl/CurlContext.cpp:

(WebCore:: const):
(WebCore::CurlHandle::addExtraNetworkLoadMetrics):
(WebCore::CurlHandle::certificateInfo const):

platform/network/curl/CurlContext.h:
platform/network/curl/OpenSSLHelper.cpp:

(OpenSSL::StackOfX509::StackOfX509):
(OpenSSL::StackOfX509::~StackOfX509):
(OpenSSL::pemDataFromCtx):
(OpenSSL::createCertificateInfo):

platform/network/curl/OpenSSLHelper.h:

2:41 PM Changeset in webkit [285837] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Add helper to add CSS property with implicit default
https://bugs.webkit.org/show_bug.cgi?id=233108

Patch by Kiet Ho <Kiet Ho> on 2021-11-15
Reviewed by Myles C. Maxfield.

Add a helper in CSSPropertyParser to add a property with implicit default. This helper
accepts a RefPtr<> value and a Ref<> default. If the value is a null pointer, the
default is added, and the implicit flag is set. Otherwise, the value is added. This is
useful for parsing shorthands, because the CSS spec requires that missing value be
set to its default value, and WebCore additionally requires the implicit flag to be set.
This helper handles both of them.

No functional changes; no tests needed.

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::addPropertyWithImplicitDefault):
(WebCore::CSSPropertyParser::consumeTransformOrigin):
(WebCore::CSSPropertyParser::consumeFont):
(WebCore::CSSPropertyParser::consumeFontVariantShorthand):
(WebCore::CSSPropertyParser::consumeColumns):
(WebCore::CSSPropertyParser::consumeShorthandGreedily):
(WebCore::CSSPropertyParser::consumeBorderImage):

css/parser/CSSPropertyParser.h:

2:25 PM Changeset in webkit [285836] by jer.noble@apple.com

2 edits in trunk/Source/WebCore/PAL

[iOS] Adopt -[AVAudioSession setAuditTokensForProcessAssertion:]
https://bugs.webkit.org/show_bug.cgi?id=232909
<rdar://68184444>

Reviewed by Eric Carlson.

Re-declare -setAuditTokensForProcessAssertion in APPLE_INTERNAL_SDK section.

pal/spi/cocoa/AVFoundationSPI.h:

2:16 PM Changeset in webkit [285835] by Russell Epstein

4 edits in branches/safari-612.3.6.1-branch/Source/WebCore

Apply patch. rdar://problem/83971417

2:16 PM Changeset in webkit [285834] by Russell Epstein

3 edits
2 adds in branches/safari-612.3.6.1-branch

Cherry-pick r285728. rdar://problem/85236241

[Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations
https://bugs.webkit.org/show_bug.cgi?id=233041
<rdar://problem/85236241>

Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/accelerated-animation-after-forward-filling-animation.html

When starting an accelerated animation, we would fill any implicit keyframes based on the unanimated style.
We now also apply all animations below this animation in the target's effect stack such that a previous
forward-filling animation is accounted for.

animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::applyPendingAcceleratedActions):

LayoutTests:

Add a new test that runs a forward-filling animation for transform, waits for its completion,
then runs another transform animation with an implicit initial keyframe, ensuring that the
result of the first forward-filling animation is accounted for when computing the initial
keyframe.

This test would fail prior to this patch.

webanimations/accelerated-animation-after-forward-filling-animation-expected.html: Added.
webanimations/accelerated-animation-after-forward-filling-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:16 PM Changeset in webkit [285833] by Russell Epstein

8 edits in branches/safari-612.3.6.1-branch/Source

Versioning.

WebKit-7612.3.6.1.2

2:07 PM Changeset in webkit [285832] by Russell Epstein

3 edits
2 adds in branches/safari-612.3.6.0-branch

Cherry-pick r285728. rdar://problem/85236241

[Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations
https://bugs.webkit.org/show_bug.cgi?id=233041
<rdar://problem/85236241>

Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/accelerated-animation-after-forward-filling-animation.html

When starting an accelerated animation, we would fill any implicit keyframes based on the unanimated style.
We now also apply all animations below this animation in the target's effect stack such that a previous
forward-filling animation is accounted for.

animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::applyPendingAcceleratedActions):

LayoutTests:

Add a new test that runs a forward-filling animation for transform, waits for its completion,
then runs another transform animation with an implicit initial keyframe, ensuring that the
result of the first forward-filling animation is accounted for when computing the initial
keyframe.

This test would fail prior to this patch.

webanimations/accelerated-animation-after-forward-filling-animation-expected.html: Added.
webanimations/accelerated-animation-after-forward-filling-animation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:06 PM Changeset in webkit [285831] by mmaxfield@apple.com

2 edits
49 adds in trunk/Source/WebCore/PAL

[WebGPU] [Cocoa] Connect WebCore & PAL to WebGPU.framework
https://bugs.webkit.org/show_bug.cgi?id=233106

Reviewed by Dean Jackson.

This adds an implementation of WebGPU's virtual interfaces on top of WebGPU.framework.
That framework's headers almost exactly match the WebGPU API, so the connections are
mostly mechanical. There's just a bunch of marshalling code to convert between
descriptor and structs from WebCore's interface to WebGPU.framework's
descriptors/structs.

This uses the same "convertToBacking" convention, where functions that convert from the
higher-level WebCore types to the lower-level WebGPU.framework types are named
"convertToBacking()". Unfortunately, the WebGPU API takes many of these structs by
non-const reference, and the structs are nested by non-const reference, which means I
can't just have simple 1-in-1-out converter functions for every struct, since the
inner structs have to be referenced by-reference and therefore have to be in-scope. This
means that the simple enum and flags types use convertToBacking(), but most of the
structs have to be converted at their use site. Luckily, almost all of these structs
only have a single use site, so there isn't much duplication.

For now, this implementation is Cocoa-only, because in order for these calls to
WebGPU.framework to be legal, WebCore has to link with an implementation of those
functions. The Cocoa ports are the only ones which actually have an implementation of
those functions, so those are the only ports which can actually compile this code. If
the other ports want to link with Dawn or WGPU, this code should be (mostly) usable
out-of-the-box for them. I say "mostly" because the header that's shared between Dawn,
WGPU, and WebGPU.framework isn't finalized yet. As such, this implementation relies on
functions from WebGPUExt.h, which is an additional header (that only exists in
WebGPU.framework) that adds the missing pieces.

PAL.xcodeproj/project.pbxproj:
pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp: Added.

(PAL::WebGPU::adapterName):
(PAL::WebGPU::supportedFeatures):
(PAL::WebGPU::supportedLimits):
(PAL::WebGPU::isFallbackAdapter):
(PAL::WebGPU::AdapterImpl::AdapterImpl):
(PAL::WebGPU::AdapterImpl::~AdapterImpl):
(PAL::WebGPU::requestDeviceCallback):
(PAL::WebGPU::AdapterImpl::requestDevice):
(PAL::WebGPU::AdapterImpl::requestDeviceCallback):

pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUBindGroupImpl.cpp: Added.

(PAL::WebGPU::BindGroupImpl::BindGroupImpl):
(PAL::WebGPU::BindGroupImpl::~BindGroupImpl):
(PAL::WebGPU::BindGroupImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUBindGroupImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUBindGroupLayoutImpl.cpp: Added.

(PAL::WebGPU::BindGroupLayoutImpl::BindGroupLayoutImpl):
(PAL::WebGPU::BindGroupLayoutImpl::~BindGroupLayoutImpl):
(PAL::WebGPU::BindGroupLayoutImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUBindGroupLayoutImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp: Added.

(PAL::WebGPU::BufferImpl::BufferImpl):
(PAL::WebGPU::BufferImpl::~BufferImpl):
(PAL::WebGPU::mapCallback):
(PAL::WebGPU::BufferImpl::mapAsync):
(PAL::WebGPU::BufferImpl::mapCallback):
(PAL::WebGPU::BufferImpl::getMappedRange):
(PAL::WebGPU::BufferImpl::unmap):
(PAL::WebGPU::BufferImpl::destroy):
(PAL::WebGPU::BufferImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUBufferImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUCommandBufferImpl.cpp: Added.

(PAL::WebGPU::CommandBufferImpl::CommandBufferImpl):
(PAL::WebGPU::CommandBufferImpl::~CommandBufferImpl):
(PAL::WebGPU::CommandBufferImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUCommandBufferImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.cpp: Added.

(PAL::WebGPU::CommandEncoderImpl::CommandEncoderImpl):
(PAL::WebGPU::CommandEncoderImpl::~CommandEncoderImpl):
(PAL::WebGPU::CommandEncoderImpl::beginRenderPass):
(PAL::WebGPU::CommandEncoderImpl::beginComputePass):
(PAL::WebGPU::CommandEncoderImpl::copyBufferToBuffer):
(PAL::WebGPU::CommandEncoderImpl::copyBufferToTexture):
(PAL::WebGPU::CommandEncoderImpl::copyTextureToBuffer):
(PAL::WebGPU::CommandEncoderImpl::copyTextureToTexture):
(PAL::WebGPU::CommandEncoderImpl::fillBuffer):
(PAL::WebGPU::CommandEncoderImpl::pushDebugGroup):
(PAL::WebGPU::CommandEncoderImpl::popDebugGroup):
(PAL::WebGPU::CommandEncoderImpl::insertDebugMarker):
(PAL::WebGPU::CommandEncoderImpl::writeTimestamp):
(PAL::WebGPU::CommandEncoderImpl::resolveQuerySet):
(PAL::WebGPU::CommandEncoderImpl::finish):
(PAL::WebGPU::CommandEncoderImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.cpp: Added.

(PAL::WebGPU::ComputePassEncoderImpl::ComputePassEncoderImpl):
(PAL::WebGPU::ComputePassEncoderImpl::~ComputePassEncoderImpl):
(PAL::WebGPU::ComputePassEncoderImpl::setPipeline):
(PAL::WebGPU::ComputePassEncoderImpl::dispatch):
(PAL::WebGPU::ComputePassEncoderImpl::dispatchIndirect):
(PAL::WebGPU::ComputePassEncoderImpl::beginPipelineStatisticsQuery):
(PAL::WebGPU::ComputePassEncoderImpl::endPipelineStatisticsQuery):
(PAL::WebGPU::ComputePassEncoderImpl::endPass):
(PAL::WebGPU::ComputePassEncoderImpl::setBindGroup):
(PAL::WebGPU::ComputePassEncoderImpl::pushDebugGroup):
(PAL::WebGPU::ComputePassEncoderImpl::popDebugGroup):
(PAL::WebGPU::ComputePassEncoderImpl::insertDebugMarker):
(PAL::WebGPU::ComputePassEncoderImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUComputePipelineImpl.cpp: Added.

(PAL::WebGPU::ComputePipelineImpl::ComputePipelineImpl):
(PAL::WebGPU::ComputePipelineImpl::~ComputePipelineImpl):
(PAL::WebGPU::ComputePipelineImpl::getBindGroupLayout):
(PAL::WebGPU::ComputePipelineImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUComputePipelineImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUConvertToBacking.cpp: Added.

(PAL::WebGPU::convertToBacking):
(PAL::WebGPU::convertBufferUsageFlagsToBacking):
(PAL::WebGPU::convertColorWriteFlagsToBacking):
(PAL::WebGPU::convertMapModeFlagsToBacking):
(PAL::WebGPU::convertShaderStageFlagsToBacking):
(PAL::WebGPU::convertTextureUsageFlagsToBacking):

pal/graphics/WebGPU/Impl/WebGPUConvertToBacking.h: Added.
pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: Added.

(PAL::WebGPU::DeviceImpl::DeviceImpl):
(PAL::WebGPU::DeviceImpl::~DeviceImpl):
(PAL::WebGPU::DeviceImpl::destroy):
(PAL::WebGPU::DeviceImpl::createBuffer):
(PAL::WebGPU::DeviceImpl::createTexture):
(PAL::WebGPU::DeviceImpl::createSampler):
(PAL::WebGPU::DeviceImpl::importExternalTexture):
(PAL::WebGPU::DeviceImpl::createBindGroupLayout):
(PAL::WebGPU::DeviceImpl::createPipelineLayout):
(PAL::WebGPU::DeviceImpl::createBindGroup):
(PAL::WebGPU::DeviceImpl::createShaderModule):
(PAL::WebGPU::convertToBacking):
(PAL::WebGPU::DeviceImpl::createComputePipeline):
(PAL::WebGPU::DeviceImpl::createRenderPipeline):
(PAL::WebGPU::createComputePipelineAsyncCallback):
(PAL::WebGPU::DeviceImpl::createComputePipelineAsync):
(PAL::WebGPU::DeviceImpl::createComputePipelineAsyncCallback):
(PAL::WebGPU::createRenderPipelineAsyncCallback):
(PAL::WebGPU::DeviceImpl::createRenderPipelineAsync):
(PAL::WebGPU::DeviceImpl::createRenderPipelineAsyncCallback):
(PAL::WebGPU::DeviceImpl::createCommandEncoder):
(PAL::WebGPU::DeviceImpl::createRenderBundleEncoder):
(PAL::WebGPU::DeviceImpl::createQuerySet):
(PAL::WebGPU::DeviceImpl::pushErrorScope):
(PAL::WebGPU::popErrorScopeCallback):
(PAL::WebGPU::DeviceImpl::popErrorScope):
(PAL::WebGPU::DeviceImpl::popErrorScopeCallback):
(PAL::WebGPU::DeviceImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUExternalTextureImpl.cpp: Added.

(PAL::WebGPU::ExternalTextureImpl::ExternalTextureImpl):
(PAL::WebGPU::ExternalTextureImpl::~ExternalTextureImpl):
(PAL::WebGPU::ExternalTextureImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUExternalTextureImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUImpl.cpp: Added.

(PAL::WebGPU::GPUImpl::GPUImpl):
(PAL::WebGPU::GPUImpl::~GPUImpl):
(PAL::WebGPU::requestAdapterCallback):
(PAL::WebGPU::GPUImpl::requestAdapter):
(PAL::WebGPU::GPUImpl::requestAdapterCallback):

pal/graphics/WebGPU/Impl/WebGPUImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUPipelineLayoutImpl.cpp: Added.

(PAL::WebGPU::PipelineLayoutImpl::PipelineLayoutImpl):
(PAL::WebGPU::PipelineLayoutImpl::~PipelineLayoutImpl):
(PAL::WebGPU::PipelineLayoutImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUPipelineLayoutImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUQuerySetImpl.cpp: Added.

(PAL::WebGPU::QuerySetImpl::QuerySetImpl):
(PAL::WebGPU::QuerySetImpl::~QuerySetImpl):
(PAL::WebGPU::QuerySetImpl::destroy):
(PAL::WebGPU::QuerySetImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUQuerySetImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp: Added.

(PAL::WebGPU::QueueImpl::QueueImpl):
(PAL::WebGPU::QueueImpl::~QueueImpl):
(PAL::WebGPU::QueueImpl::submit):
(PAL::WebGPU::onSubmittedWorkDoneCallback):
(PAL::WebGPU::QueueImpl::onSubmittedWorkDone):
(PAL::WebGPU::QueueImpl::onSubmittedWorkDoneCallback):
(PAL::WebGPU::QueueImpl::writeBuffer):
(PAL::WebGPU::QueueImpl::writeTexture):
(PAL::WebGPU::QueueImpl::copyExternalImageToTexture):
(PAL::WebGPU::QueueImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUQueueImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPURenderBundleEncoderImpl.cpp: Added.

(PAL::WebGPU::RenderBundleEncoderImpl::RenderBundleEncoderImpl):
(PAL::WebGPU::RenderBundleEncoderImpl::~RenderBundleEncoderImpl):
(PAL::WebGPU::RenderBundleEncoderImpl::setPipeline):
(PAL::WebGPU::RenderBundleEncoderImpl::setIndexBuffer):
(PAL::WebGPU::RenderBundleEncoderImpl::setVertexBuffer):
(PAL::WebGPU::RenderBundleEncoderImpl::draw):
(PAL::WebGPU::RenderBundleEncoderImpl::drawIndexed):
(PAL::WebGPU::RenderBundleEncoderImpl::drawIndirect):
(PAL::WebGPU::RenderBundleEncoderImpl::drawIndexedIndirect):
(PAL::WebGPU::RenderBundleEncoderImpl::setBindGroup):
(PAL::WebGPU::RenderBundleEncoderImpl::pushDebugGroup):
(PAL::WebGPU::RenderBundleEncoderImpl::popDebugGroup):
(PAL::WebGPU::RenderBundleEncoderImpl::insertDebugMarker):
(PAL::WebGPU::RenderBundleEncoderImpl::finish):
(PAL::WebGPU::RenderBundleEncoderImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPURenderBundleEncoderImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPURenderBundleImpl.cpp: Added.

(PAL::WebGPU::RenderBundleImpl::RenderBundleImpl):
(PAL::WebGPU::RenderBundleImpl::~RenderBundleImpl):
(PAL::WebGPU::RenderBundleImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPURenderBundleImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.cpp: Added.

(PAL::WebGPU::RenderPassEncoderImpl::RenderPassEncoderImpl):
(PAL::WebGPU::RenderPassEncoderImpl::~RenderPassEncoderImpl):
(PAL::WebGPU::RenderPassEncoderImpl::setPipeline):
(PAL::WebGPU::RenderPassEncoderImpl::setIndexBuffer):
(PAL::WebGPU::RenderPassEncoderImpl::setVertexBuffer):
(PAL::WebGPU::RenderPassEncoderImpl::draw):
(PAL::WebGPU::RenderPassEncoderImpl::drawIndexed):
(PAL::WebGPU::RenderPassEncoderImpl::drawIndirect):
(PAL::WebGPU::RenderPassEncoderImpl::drawIndexedIndirect):
(PAL::WebGPU::RenderPassEncoderImpl::setBindGroup):
(PAL::WebGPU::RenderPassEncoderImpl::pushDebugGroup):
(PAL::WebGPU::RenderPassEncoderImpl::popDebugGroup):
(PAL::WebGPU::RenderPassEncoderImpl::insertDebugMarker):
(PAL::WebGPU::RenderPassEncoderImpl::setViewport):
(PAL::WebGPU::RenderPassEncoderImpl::setScissorRect):
(PAL::WebGPU::RenderPassEncoderImpl::setBlendConstant):
(PAL::WebGPU::RenderPassEncoderImpl::setStencilReference):
(PAL::WebGPU::RenderPassEncoderImpl::beginOcclusionQuery):
(PAL::WebGPU::RenderPassEncoderImpl::endOcclusionQuery):
(PAL::WebGPU::RenderPassEncoderImpl::beginPipelineStatisticsQuery):
(PAL::WebGPU::RenderPassEncoderImpl::endPipelineStatisticsQuery):
(PAL::WebGPU::RenderPassEncoderImpl::executeBundles):
(PAL::WebGPU::RenderPassEncoderImpl::endPass):
(PAL::WebGPU::RenderPassEncoderImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPURenderPipelineImpl.cpp: Added.

(PAL::WebGPU::RenderPipelineImpl::RenderPipelineImpl):
(PAL::WebGPU::RenderPipelineImpl::~RenderPipelineImpl):
(PAL::WebGPU::RenderPipelineImpl::getBindGroupLayout):
(PAL::WebGPU::RenderPipelineImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPURenderPipelineImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUSamplerImpl.cpp: Added.

(PAL::WebGPU::SamplerImpl::SamplerImpl):
(PAL::WebGPU::SamplerImpl::~SamplerImpl):
(PAL::WebGPU::SamplerImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUSamplerImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.cpp: Added.

(PAL::WebGPU::ShaderModuleImpl::ShaderModuleImpl):
(PAL::WebGPU::ShaderModuleImpl::~ShaderModuleImpl):
(PAL::WebGPU::ShaderModuleImpl::compilationInfo):
(PAL::WebGPU::ShaderModuleImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUShaderModuleImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUTextureImpl.cpp: Added.

(PAL::WebGPU::TextureImpl::TextureImpl):
(PAL::WebGPU::TextureImpl::~TextureImpl):
(PAL::WebGPU::TextureImpl::createView const):
(PAL::WebGPU::TextureImpl::destroy):
(PAL::WebGPU::TextureImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUTextureImpl.h: Added.
pal/graphics/WebGPU/Impl/WebGPUTextureViewImpl.cpp: Added.

(PAL::WebGPU::TextureViewImpl::TextureViewImpl):
(PAL::WebGPU::TextureViewImpl::~TextureViewImpl):
(PAL::WebGPU::TextureViewImpl::setLabelInternal):

pal/graphics/WebGPU/Impl/WebGPUTextureViewImpl.h: Added.

2:02 PM Changeset in webkit [285830] by Russell Epstein

8 edits in branches/safari-612.3.6.0-branch/Source

Versioning.

WebKit-7612.3.6.0.2

1:46 PM Changeset in webkit [285829] by Russell Epstein

4 edits in branches/safari-613.1.8-branch/Source

Cherry-pick r285828. rdar://problem/85427036

Unreviewed, fix the internal iOS 15 build

Source/WebCore/PAL:

In the internal iOS 15 SDK, <UIKit/NSTextList.h> does not define NSTextListMarkerFormat. Add a separate SDK
version check instead and only attempt to soft-link these constants if we're compiling against an SDK that we
know exports these symbols.

pal/spi/cocoa/NSAttributedStringSPI.h:

Source/WTF:

Add a new compile-time flag.

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:40 PM Changeset in webkit [285828] by Wenson Hsieh

4 edits in trunk/Source

Unreviewed, fix the internal iOS 15 build

Source/WebCore/PAL:

In the internal iOS 15 SDK, <UIKit/NSTextList.h> does not define NSTextListMarkerFormat. Add a separate SDK
version check instead and only attempt to soft-link these constants if we're compiling against an SDK that we
know exports these symbols.

pal/spi/cocoa/NSAttributedStringSPI.h:

Source/WTF:

Add a new compile-time flag.

wtf/PlatformHave.h:

1:18 PM Changeset in webkit [285827] by Antti Koivisto

5 edits in trunk

Revert r285235
https://bugs.webkit.org/show_bug.cgi?id=233142

Unreviewed.

LayoutTests/imported/w3c:

web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt:

Source/WebCore:

Causes crash with simple repro

<div id=t style="border-radius: unset"></div>
<script>
t.style.borderRadius;
</script>

css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::borderRadiusValue const): Deleted.

css/StyleProperties.h:

12:47 PM Changeset in webkit [285826] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/text/letter-spacing-negative-opacity.html
https://bugs.webkit.org/show_bug.cgi?id=233132

Reviewed by Antti Koivisto.

Special case the negative letter spacing content when computing the content logical width.

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::appendTextContent):

Negative letter space value could produce negative content width
Subsequent text content (e.g. "this text has whitepspace content") may go from positive to negative content width as parts of the content may produce positive width even with negative letter spacing.

12:39 PM Changeset in webkit [285825] by Russell Epstein

8 edits in branches/safari-613.1.8-branch/Source

Versioning.

WebKit-7613.1.8.2

12:30 PM Changeset in webkit [285824] by Russell Epstein

1 copy in tags/Safari-613.1.8.1

Tag Safari-613.1.8.1.

12:21 PM Changeset in webkit [285823] by Chris Dumez

3 edits
3 adds in trunk

Cross-Origin-Embedder-Policy: require-corp prevents loading of data URL images
https://bugs.webkit.org/show_bug.cgi?id=233131
<rdar://85236459>

Reviewed by Geoffrey Garen.

Source/WebCore:

When doing an initial data URL <img> load, we properly wouldn't perform a cross-origin resource policy check.
This is per the Fetch specification that says to use a scheme fetch [1] when the request URL is a data URL.
When the protocol is data, the scheme fetch algorithm would return a response without performing an HTTP
Fetch. The HTTP check [2] is the algorithm that actually performs a cross-origin resource policy check, at
step 7.

The issue with our implementation was that data URL <img> loads would perform a cross-origin resource policy
check in the case where the image is loaded from our memory cache, due to a check we had in
CachedResourceLoader::requestResource(). As a result, data URL <img> loads would fail when served from the
memory cache, when CORP is enforced. To address the issue and match the specification, we now disable this
CORP check when the request URL is a data URL.

[1] https://fetch.spec.whatwg.org/#scheme-fetch
[2] https://fetch.spec.whatwg.org/#concept-http-fetch

Test: http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

Add layout test coverage. This test is based on a reduce test case from Cameron McCormack.

http/wpt/html/cross-origin-embedder-policy/require-corp-data-url-expected.txt: Added.
http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html: Added.
http/wpt/html/cross-origin-embedder-policy/require-corp-data-url.html.headers: Added.

12:18 PM Changeset in webkit [285822] by commit-queue@webkit.org

26 edits
4 adds in trunk

Implement parsing and animation support for offset-rotate
https://bugs.webkit.org/show_bug.cgi?id=232752

Patch by Kiet Ho <Kiet Ho> on 2021-11-15
Reviewed by Myles C. Maxfield.

LayoutTests/imported/w3c:

Rebaselined tests that now should pass.

web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
web-platform-tests/css/motion/animation/offset-rotate-composition-expected.txt:
web-platform-tests/css/motion/animation/offset-rotate-interpolation-expected.txt:
web-platform-tests/css/motion/inheritance-expected.txt:
web-platform-tests/css/motion/offset-supports-calc-expected.txt:
web-platform-tests/css/motion/parsing/offset-rotate-computed-expected.txt:
web-platform-tests/css/motion/parsing/offset-rotate-parsing-valid-expected.txt:
web-platform-tests/css/motion/parsing/offset-shorthand-expected.txt:

Source/WebCore:

Implement parsing and animation support for offset-rotate as specified in the CSS
motion path specification. 'auto' and 'reverse' modifiers are supported.

Tests: imported/w3c/web-platform-tests/css/motion/inheritance.html

imported/w3c/web-platform-tests/css/motion/offset-supports-calc.html
imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-composition.html
imported/w3c/web-platform-tests/css/motion/animation/offset-rotate-interpolation.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-rotate-computed.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-rotate-parsing-invalid.html
imported/w3c/web-platform-tests/css/motion/parsing/offset-rotate-parsing-valid.html

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Added blendFunc override for blending OffsetRotation.
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Added animation support for offset-rotate.

css/CSSComputedStyleDeclaration.cpp: Added computed style support for offset-rotate.

(WebCore::valueForOffsetRotate):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

css/CSSOffsetRotateValue.cpp: Added.

(WebCore::CSSOffsetRotateValue::customCSSText const):
(WebCore::CSSOffsetRotateValue::equals const):

css/CSSOffsetRotateValue.h: Added.
css/CSSProperties.json: Added entry for offset-rotate.
css/CSSValue.cpp:

(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):

css/CSSValue.h:

(WebCore::CSSValue::isOffsetRotateValue const):

css/parser/CSSPropertyParser.cpp: Added parsing support for offset-rotate.

(WebCore::consumeOffsetRotate):
(WebCore::CSSPropertyParser::parseSingleValue):

rendering/style/OffsetRotation.cpp: Added.

(WebCore::OffsetRotation::OffsetRotation):
(WebCore::OffsetRotation::operator== const):
(WebCore::operator<<):

rendering/style/OffsetRotation.h: Added.

(WebCore::OffsetRotation::hasAuto const):
(WebCore::OffsetRotation::angle const):
(WebCore::OffsetRotation::operator!= const):

rendering/style/RenderStyle.h: Added support for offset-rotate.

(WebCore::RenderStyle::offsetRotate const):
(WebCore::RenderStyle::setOffsetRotate):
(WebCore::RenderStyle::initialOffsetRotate):

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):

rendering/style/StyleRareNonInheritedData.h: Added storage space for offset-path.
style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertOffsetRotate):

LayoutTests:

Rebaselined test to account for new CSS property.

platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

12:15 PM Changeset in webkit [285821] by Russell Epstein

2 edits in branches/safari-613.1.8-branch/Source/WebCore/PAL

Cherry-pick r285811. rdar://problem/85422144

Declare NSTextListMarker* as type NSTextListMarkerFormat when soft-linking
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Followup to r285744. Avoid build errors due to defining these constants as a different type of symbol
(NSString * vs. NSTextListMarkerFormat). To address this, we directly import NSTextList.h if it's available in
the SDK; otherwise, fall back to defining NSTextListMarkerFormat. In both cases, we need to keep soft linking
each of these constants, since WebCore cannot explicitly link against UIKit.

pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:15 PM Changeset in webkit [285820] by Russell Epstein

2 edits in branches/safari-613.1.8-branch/Source/WebCore/PAL

Cherry-pick r285744. rdar://problem/85422144

Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:46 AM Changeset in webkit [285819] by commit-queue@webkit.org

8 edits
1 add in trunk

Make valgrind work properly without extra environment variables
https://bugs.webkit.org/show_bug.cgi?id=230460

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-11-15
Reviewed by Carlos Garcia Campos.

Source/bmalloc:

Currently to run WebKit under valgrind, we have to manually disable bmalloc with Malloc=1,
or else the Gigacage breaks everything, because valgrind shadows the entire address space in
resident memory, and it just can't handle that much address space. Even with
GIGACAGE_ENABLED=0, diagnostics are worse because bmalloc does not use valgrind's
annotations.

Using valgrind.h, we can automatically disable bmalloc when running under valgrind to avoid
needing to use the environment variable.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
bmalloc/Environment.cpp:

(bmalloc::isRunningOnValgrind):
(bmalloc::Environment::computeIsDebugHeapEnabled):

bmalloc/valgrind.h: Added.

(valgrind_do_client_request_expr):
(VALGRIND_PRINTF):
(VALGRIND_PRINTF_BACKTRACE):

Source/WebKit:

WebKitGTK and WPE WebKit users also have to set the WEBKIT_FORCE_SANDBOX=0 environment
variable, because the web process sandbox breaks valgrind for some reason I never attempted
to understand. If we have bmalloc expose valgrind.h as a public header, then we can check
for valgrind in higher layers and make this work automatically too.

UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

Tools:

Exempt valgrind.h from the style checker.

Scripts/webkitpy/style/checker.py:

11:19 AM Changeset in webkit [285818] by Chris Dumez

5 edits in trunk/Source/WebKit

Remove some dead code from IPC::Encoder / IPC::Decoder
https://bugs.webkit.org/show_bug.cgi?id=233134

Reviewed by Sam Weinig.

Remove some dead code from IPC::Encoder / IPC::Decoder and make sure both
types are non-copyable / non-movable.

Platform/IPC/Decoder.cpp:
Platform/IPC/Decoder.h:

(IPC::Decoder::decodeSingleObject): Deleted.
(): Deleted.

Platform/IPC/Encoder.cpp:

(IPC::Encoder::Encoder):

Platform/IPC/Encoder.h:

11:15 AM Changeset in webkit [285817] by Angelos Oikonomopoulos

9 edits in trunk

Skip tests newly-failing on mips
https://bugs.webkit.org/show_bug.cgi?id=233124

Unreviewed gardening.

After 3f59d2aa489ec843e055fc3104c275851d7fbd35, these tests started
failing with a SIGBUS on MIPS (on fuloong hardware, they pass on the
ci20 boards). Temporarily skip them on this arch until we can track
down the issue.

JSTests:

stress/call-varargs-double-new-array-buffer.js:
stress/callee-save-fpr.js:
stress/forward-varargs-double-new-array-buffer.js:
stress/new-array-with-spread-cow-double.js:
stress/new-array-with-spread-double-new-array-buffer.js:
stress/spread-escapes-but-new-array-buffer-does-not-double.js:

PerformanceTests:

ARES-6/Basic/basic-tests.yaml:

11:00 AM Changeset in webkit [285816] by Russell Epstein

9 edits in branches/safari-613.1.9-branch/Source

Versioning.

WebKit-7613.1.9

10:58 AM Changeset in webkit [285815] by Russell Epstein

1 copy in branches/safari-613.1.9-branch

New branch.

10:57 AM Changeset in webkit [285814] by Russell Epstein

9 edits in trunk/Source

Versioning.

WebKit-7613.1.10

10:56 AM Changeset in webkit [285813] by commit-queue@webkit.org

3 edits
2 adds in trunk

nullptr deref in CompositeEditCommand::insertNodeAt
https://bugs.webkit.org/show_bug.cgi?id=232837

Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2021-11-15
Reviewed by Wenson Hsieh and Darin Adler.

Source/WebCore:

Check endingSelection is not orphan before inserting nodes at
the start position.

Test: fast/editing/editing-position-crash.html

editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

LayoutTests:

fast/editing/editing-position-crash-expected.txt: Added.
fast/editing/editing-position-crash.html: Added.

10:49 AM Changeset in webkit [285812] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[macOS][GPUP] Add telemetry for syscalls
https://bugs.webkit.org/show_bug.cgi?id=232888
<rdar://problem/85207011>

Reviewed by Brent Fulgham.

Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Scripts/process-entitlements.sh:

10:36 AM Changeset in webkit [285811] by Wenson Hsieh

2 edits in trunk/Source/WebCore/PAL

Declare NSTextListMarker* as type NSTextListMarkerFormat when soft-linking
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Followup to r285744. Avoid build errors due to defining these constants as a different type of symbol
(NSString * vs. NSTextListMarkerFormat). To address this, we directly import NSTextList.h if it's available in
the SDK; otherwise, fall back to defining NSTextListMarkerFormat. In both cases, we need to keep soft linking
each of these constants, since WebCore cannot explicitly link against UIKit.

pal/spi/cocoa/NSAttributedStringSPI.h:

10:36 AM Changeset in webkit [285810] by commit-queue@webkit.org

4 edits in trunk

Null bytes aren't percent-encoded on urlencoded over POST
https://bugs.webkit.org/show_bug.cgi?id=220780

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-11-15
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/forms/form-submission-0/urlencoded2.window-expected.txt:

Source/WebCore:

This change fixes a bug where strchr was being used to match a character against a set
character list, without checking whether the character was NUL. This resulted in NUL bytes
being passed through in the urlencoded enctype over POST, rather than being percent-escaped.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/urlencoded2.window.html

platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::appendFormURLEncoded):

10:07 AM Changeset in webkit [285809] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Unreviewed, reverting r285774.
https://bugs.webkit.org/show_bug.cgi?id=233136

Introduced GPUP crash on some configurations

Reverted changeset:

"[macOS][GPUP] Add telemetry for syscalls"
https://bugs.webkit.org/show_bug.cgi?id=232888
https://commits.webkit.org/r285774

9:32 AM Changeset in webkit [285808] by commit-queue@webkit.org

4 edits in trunk

Empty <input type=file> controls don't show up in the urlencoded and text/plain enctypes
https://bugs.webkit.org/show_bug.cgi?id=221549

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-11-15
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:

Source/WebCore:

In the HTML spec, and in Firefox and Chrome's implementations, an empty <input type="file">
control is represented in form submission as if it were an empty file with an empty
filename. WebKit, however, does not include a form entry corresponding to the file input at
all in the application/x-www-form-urlencoded and text/plain enctypes. This change fixes it.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html

html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):

7:51 AM Changeset in webkit [285807] by Antti Koivisto

11 edits in trunk/Source/WebCore

[LFC][Integration] fast/text/international/bidi-innertext.html fails with BiDi enabled
https://bugs.webkit.org/show_bug.cgi?id=233125

Reviewed by Alan Bujtas.

TextIterator needs to know that RenderText contains bidi text.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::handleTextContent):

Use the InlineTextBox bit.

layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::containsBidiText):

Add a helper.

layout/formattingContexts/inline/text/TextUtil.h:
layout/integration/InlineIteratorLogicalOrderTraversal.cpp:

(WebCore::InlineIterator::makeTextLogicalOrderCacheIfNeeded):

layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTree):

layout/layouttree/LayoutInlineTextBox.cpp:

(WebCore::Layout::InlineTextBox::InlineTextBox):
(WebCore::Layout::m_containsBidiText):

Add a bit to the InlineTextBox.

(WebCore::Layout::m_canUseSimplifiedContentMeasuring): Deleted.

layout/layouttree/LayoutInlineTextBox.h:

(WebCore::Layout::InlineTextBox::containsBidiText const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createTextBox):

rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::positionLineBox):

rendering/RenderText.h:

(WebCore::RenderText::containsBidiText const):
(WebCore::RenderText::setContainsBidiText):
(WebCore::RenderText::containsReversedText const): Deleted.

6:47 AM Changeset in webkit [285806] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][IFC] Take text-indent into account when computing preferred width
https://bugs.webkit.org/show_bug.cgi?id=233115

Reviewed by Antti Koivisto.

layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::computedIntrinsicWidth):

layout/formattingContexts/inline/InlineLineBuilder.h:

6:46 AM Changeset in webkit [285805] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

AX: Un-skip accessibility/mac/search-predicate-for-adhoc-radio-groups.html for Mac WK1
https://bugs.webkit.org/show_bug.cgi?id=233116

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-15
Reviewed by Andres Gonzalez.

https://bugs.webkit.org/show_bug.cgi?id=233017 implemented
AccessibilityUIElement::domIdentifier for WK1, so we don't
need to skip accessibility/mac/search-predicate-for-adhoc-radio-groups.html anymore.

platform/mac-wk1/TestExpectations:

Un-skip because AccessibilityUIElement::domIdentifier is now
implemented.

6:06 AM Changeset in webkit [285804] by commit-queue@webkit.org

2 edits in trunk

Add my GitHub username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=233122

Unreviewed.

Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2021-11-15

metadata/contributors.json:

5:08 AM Changeset in webkit [285803] by cathiechen

16 edits
2 copies
89 adds in trunk/LayoutTests

[CSS contain] Update css-contain tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=233121

Reviewed by Rob Buis.

Update css/css-contain/ tests to commit 625a2df832.

LayoutTests/imported/w3c:

resources/resource-files.json:
web-platform-tests/css/css-contain/contain-body-bg-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-001.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-002.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-003.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-bg-004.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-001.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-002.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-003.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-dir-004.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-001.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-002.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-003.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-overflow-004.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-001.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-002.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-003.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-t-o-004.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-001.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-002.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-003.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-body-w-m-004.html: Added.
web-platform-tests/css/css-contain/contain-content-011-expected.html:
web-platform-tests/css/css-contain/contain-content-011.html:
web-platform-tests/css/css-contain/contain-html-bg-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-001.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-002.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-003.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-bg-004.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-001.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-002.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-003.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-dir-004.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-001.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-002.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-003.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-overflow-004.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-001.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-002.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-003.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-t-o-004.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-001-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-001.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-002-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-002.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-003-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-003.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-004-expected.html: Added.
web-platform-tests/css/css-contain/contain-html-w-m-004.html: Added.
web-platform-tests/css/css-contain/contain-layout-019-expected.xht: Added.
web-platform-tests/css/css-contain/contain-layout-019.html: Added.
web-platform-tests/css/css-contain/contain-paint-010.html:
web-platform-tests/css/css-contain/contain-paint-026-expected.xht: Added.
web-platform-tests/css/css-contain/contain-paint-026.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-paint-010.html.
web-platform-tests/css/css-contain/contain-paint-change-opacity-expected.xht: Added.
web-platform-tests/css/css-contain/contain-paint-change-opacity.html: Added.
web-platform-tests/css/css-contain/contain-paint-clip-005.html:
web-platform-tests/css/css-contain/contain-strict-011-expected.html:
web-platform-tests/css/css-contain/contain-strict-011.html:
web-platform-tests/css/css-contain/crashtests/contain-nested-crash-001.html: Added.
web-platform-tests/css/css-contain/crashtests/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/w3c-import.log.
web-platform-tests/css/css-contain/parsing/contain-computed-children-expected.txt: Added.
web-platform-tests/css/css-contain/parsing/contain-computed-children.html: Added.
web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt:
web-platform-tests/css/css-contain/parsing/contain-computed.html:
web-platform-tests/css/css-contain/parsing/contain-invalid-expected.txt:
web-platform-tests/css/css-contain/parsing/contain-invalid.html:
web-platform-tests/css/css-contain/parsing/w3c-import.log:
web-platform-tests/css/css-contain/w3c-import.log:

LayoutTests:

TestExpectations:

4:57 AM Changeset in webkit [285802] by eocanha@igalia.com

5 edits in trunk

[GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=229964

Reviewed by Carlos Garcia Campos.

Source/WebCore:

I can't reproduce the timeout locally anymore, but I'm getting a crash sometimes. This fix is for the crash.
Unregister dbus objects on MediaSessionGLib destruction to prevent the dbus connection to keep processing requests.

platform/audio/glib/MediaSessionGLib.cpp:

(WebCore::MediaSessionGLib::MediaSessionGLib()): Don't register a GBusNameLostCallback, as unregistration is now going to be handled in the destructor.
(WebCore::MediaSessionGLib::~MediaSessionGLib()): Unregister dbus objects.
(WebCore::MediaSessionGLib::nameLost()): Refactored into the destructor.

platform/audio/glib/MediaSessionGLib.h:

(WebCore::MediaSessionGLib::nameLost()): Deleted.

LayoutTests:

Removed failing test from TestExpectations.

platform/gtk/TestExpectations:

3:12 AM Changeset in webkit [285801] by Antti Koivisto

4 edits
2 adds in trunk

Stack overflow with revert-layer
https://bugs.webkit.org/show_bug.cgi?id=233119
rdar://85342210

Reviewed by Antoine Quint.

Source/WebCore:

We would decrement the cascade layer priority by one after finding 'revert-layer' value and then try
to apply again. If both the default layer and a cascade layer contained 'revert-layer' we would
enter a very deep recursion as the default layer priority is 64k and the cascade layer priorities
start from zero.

Test: fast/css/revert-layer-stack-overflow-2.html

style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyRollbackCascadeProperty):

Fix by getting the new cascade layer priority from the actual property rather than the cascade
minimum value.

Factor into a function.

(WebCore::Style::Builder::applyProperty):

style/StyleBuilder.h:

LayoutTests:

fast/css/revert-layer-stack-overflow-2-expected.txt: Added.
fast/css/revert-layer-stack-overflow-2.html: Added.

12:42 AM Changeset in webkit [285800] by Patrick Griffis

4 edits in trunk

CSP: Fix missing lineNumber and columnNumber in inline violation reports
https://bugs.webkit.org/show_bug.cgi?id=233102

Reviewed by Carlos Garcia Campos.

LayoutTests/imported/w3c:

Update expectations as passing.

web-platform-tests/content-security-policy/securitypolicyviolation/blockeduri-inline-expected.txt:

Source/WebCore:

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):

Nov 14, 2021:

11:17 PM Changeset in webkit [285799] by beidson@apple.com

14 edits
2 adds in trunk

Get daemon API ready to work in the iOS simulator (starting with WebPushD)
https://bugs.webkit.org/show_bug.cgi?id=232982

Reviewed by Geoff Garen.

Source/WebKit:

Move all the "enable Notifications" SPI from Mac-only to cross platform:

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setNotificationsEnabled:]):
(-[WKPreferences _notificationsEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest):

WebKit.xcodeproj/project.pbxproj: Add a build phase script to install the daemon executables inside a Daemons directory within the built WebKit.framework for engineering builds.
webpushd/WebPushDaemon.mm:

Tools:

To get this working we needed to:

Have the Daemons installed in a simulator-runtime-root-visible path
Point the OSLaunchDJob plist to the simulator-relative path, not Mac-relative
Solve the "How do I kill existing instances to run a clean test?" problem within the simulator.

This patch does those things.

TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements:
TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::testWebPushDaemonPList):
(TestWebKitAPI::setUpTestWebPushD):
(TestWebKitAPI::cleanUpTestWebPushD):

TestWebKitAPI/cocoa/DaemonTestUtilities.h:
TestWebKitAPI/cocoa/DaemonTestUtilities.mm:

(TestWebKitAPI::registerPlistWithLaunchD):
(TestWebKitAPI::pidOfFirstDaemonInstance):
(TestWebKitAPI::killFirstInstanceOfDaemon):

WebKitLibraries:

WebKitPrivateFrameworkStubs/iOS/15/AppServerSupport.framework/AppServerSupport.tbd: Added.

8:22 PM Changeset in webkit [285798] by Fujii Hironori

2 edits in trunk/Source/WebKit

[GraphicsLayerWC] Incorrect compositing debug border color
https://bugs.webkit.org/show_bug.cgi?id=233107

Reviewed by Don Olmstead.

GraphicsLayer::updateDebugIndicators() should be called after
changing some layer properties.

WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

(WebKit::GraphicsLayerWC::setMasksToBounds):
(WebKit::GraphicsLayerWC::setDrawsContent):
(WebKit::GraphicsLayerWC::setContentsToPlatformLayer):
(WebKit::GraphicsLayerWC::setBackdropFilters):
Call updateDebugIndicators.

8:06 PM Changeset in webkit [285797] by Simon Fraser

5 edits
2 adds in trunk

Fingers down on the trackpad should stop an animated scroll
https://bugs.webkit.org/show_bug.cgi?id=233114

Reviewed by Wenson Hsieh.
Source/WebCore:

Fingers down on the trackpad sends a "MayBegin" event; this needs to stop any in-progress
animated momentum scroll.

This failed because ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent() early-returned
on the MayBegin event before it got to ScrollingEffectsController. Fix that, and have
ScrollingEffectsController::handleWheelEvent() return true to say it was handled.

This triggered an assertion in ScrollingTreeGestureState, but for "post-main-thread"
handling for which the assertion was wrong.

Test: fast/scrolling/mac/momentum-animator-maybegin-stops.html

page/scrolling/ScrollingTreeGestureState.cpp:

(WebCore::ScrollingTreeGestureState::nodeDidHandleEvent):

page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):

platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::handleWheelEvent):

LayoutTests:

fast/scrolling/mac/momentum-animator-maybegin-stops-expected.txt: Added.
fast/scrolling/mac/momentum-animator-maybegin-stops.html: Added.

6:45 PM Changeset in webkit [285796] by Said Abou-Hallawa

90 edits in trunk/Source/WebCore

[GPU Process] Remove the reference to Filter from FilterEffect
https://bugs.webkit.org/show_bug.cgi?id=232551
rdar://85136447

Reviewed by Cameron McCormack.

This patch removes an unnecessary dependency of individual FilterEffects
on the Filter object, which makes it easier to send the filter description
over IPC.

Instead of having a reference to the Filter in the FilterEffect, we are
going to pass a reference to the Filter to the FilterEffect functions
only when needed. FilterEffect may need access to the Filter only in two
methods: determineAbsolutePaintRect() and platformApplySoftware().

We need to change all the FilterEffect create methods to not take a Filter
as input. This requires the SVG filter effect elements to change their
build() method. And it requires also CSSFilter to not pass itself to the
FilterEffects its create.

platform/graphics/coreimage/FilterEffectRendererCoreImage.h:
platform/graphics/coreimage/FilterEffectRendererCoreImage.mm:

(WebCore::FilterEffectRendererCoreImage::applyEffects):
(WebCore::FilterEffectRendererCoreImage::connectCIFilters):
(WebCore::FilterEffectRendererCoreImage::imageForSourceGraphic):

platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::create):
(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::create):
(WebCore::FEColorMatrix::FEColorMatrix):
(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::create):
(WebCore::FEComponentTransfer::FEComponentTransfer):
(WebCore::FEComponentTransfer::platformApplySoftware):

platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::create):
(WebCore::FEComposite::FEComposite):
(WebCore::FEComposite::determineAbsolutePaintRect):
(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::platformApplySoftware):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::create):
(WebCore::FEDiffuseLighting::FEDiffuseLighting):

platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::create):
(WebCore::FEDisplacementMap::FEDisplacementMap):
(WebCore::FEDisplacementMap::platformApplySoftware):

platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::create):
(WebCore::FEDropShadow::FEDropShadow):
(WebCore::FEDropShadow::determineAbsolutePaintRect):
(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::create):
(WebCore::FEFlood::FEFlood):
(WebCore::FEFlood::platformApplySoftware):

platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::create):
(WebCore::FEGaussianBlur::FEGaussianBlur):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::FELighting):
(WebCore::FELighting::platformApplySoftware):

platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::create):
(WebCore::FEMerge::FEMerge):
(WebCore::FEMerge::platformApplySoftware):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::create):
(WebCore::FEMorphology::FEMorphology):
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::platformApplySoftware):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::create):
(WebCore::FEOffset::FEOffset):
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::platformApplySoftware):

platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::create):
(WebCore::FESpecularLighting::FESpecularLighting):

platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::create):
(WebCore::FETile::FETile):
(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::create):
(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/Filter.h:

(WebCore::Filter::sourceImage const):
(WebCore::Filter::sourceImage): Deleted.

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::determineFilterPrimitiveSubregion):
(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::convertPixelBufferToColorSpace):
(WebCore::FilterEffect::convertImageBufferToColorSpace):
(WebCore::FilterEffect::createImageBufferResult):

platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter): Deleted.
(WebCore::FilterEffect::filter const): Deleted.
Create a unaccelerated filter image result for now. This will be fixed
in the following patch. Anyway currently we never create accelerated
intermediate ImageBuffers for filters.

platform/graphics/filters/FilterEffectRenderer.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::SourceAlpha):
(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::platformApplySoftware):

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::create):
(WebCore::SourceGraphic::SourceGraphic):
(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::platformApplySoftware):

platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic): Deleted.

rendering/CSSFilter.cpp:

(WebCore::createBlurEffect):
(WebCore::createBrightnessEffect):
(WebCore::createContrastEffect):
(WebCore::createDropShadowEffect):
(WebCore::createGrayScaleEffect):
(WebCore::createHueRotateEffect):
(WebCore::createInvertEffect):
(WebCore::createOpacityEffect):
(WebCore::createSaturateEffect):
(WebCore::createSepiaEffect):
(WebCore::CSSFilter::buildFilterFunctions):
(WebCore::CSSFilter::determineFilterPrimitiveSubregion):
(WebCore::CSSFilter::apply):

rendering/CSSFilter.h:

Apply the FilterFunctions of the CSSFilter in the forward direction.

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::build const):

svg/SVGFEBlendElement.h:
svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build const):

svg/SVGFEColorMatrixElement.h:
svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build const):

svg/SVGFEComponentTransferElement.h:
svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::build const):

svg/SVGFECompositeElement.h:
svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build const):

svg/SVGFEConvolveMatrixElement.h:
svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build const):

svg/SVGFEDiffuseLightingElement.h:
svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::build const):

svg/SVGFEDisplacementMapElement.h:
svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build const):

svg/SVGFEDropShadowElement.h:
svg/SVGFEFloodElement.cpp:

(WebCore::SVGFEFloodElement::build const):

svg/SVGFEFloodElement.h:
svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build const):

svg/SVGFEGaussianBlurElement.h:
svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build const):

svg/SVGFEImageElement.h:
svg/SVGFEMergeElement.cpp:

(WebCore::SVGFEMergeElement::build const):

svg/SVGFEMergeElement.h:
svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::build const):

svg/SVGFEMorphologyElement.h:
svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::build const):

svg/SVGFEOffsetElement.h:
svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build const):

svg/SVGFESpecularLightingElement.h:
svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::build const):

svg/SVGFETileElement.h:
svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::build const):

svg/SVGFETurbulenceElement.h:
svg/SVGFilterPrimitiveStandardAttributes.h:

Remove the Filter as an input to the build() method and pass a reference
to SVGFilterBuilder instead of passing a pointer.

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::create):
(WebCore::FEImage::FEImage):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::platformApplySoftware):

svg/graphics/filters/SVGFEImage.h:
svg/graphics/filters/SVGFilter.cpp:

(WebCore::SVGFilter::create):
(WebCore::SVGFilter::apply):

svg/graphics/filters/SVGFilter.h:
svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::buildFilterEffects):

svg/graphics/filters/SVGFilterBuilder.h:

6:44 PM Changeset in webkit [285795] by ysuzuki@apple.com

61 edits
1 add
1 delete in trunk

[JSC] Use CallLinkInfo in LLInt
https://bugs.webkit.org/show_bug.cgi?id=232746

Reviewed by Saam Barati.

JSTests:

stress/is-callable-in-ftl-needs-to-be-aware-of-proxy.js:
stress/sampling-profiler-wasm-name-section.js:

(platformSupportsSamplingProfiler.vm.isWasmSupported):

stress/sampling-profiler-wasm.js:

(platformSupportsSamplingProfiler.vm.isWasmSupported):

stress/sampling-profiler/samplingProfiler.js:

(doesTreeHaveStackTrace):
(runTest):

wasm/function-tests/nameSection.js:

Source/JavaScriptCore:

This patch integrates normal CallLinkInfo into LLInt and remove adhoc LLIntCallLinkInfo.
So that we can simplify our IC software stack, and unifying call IC mechanism into one CallLinkInfo.

LLInt can fully use our polymorphic call IC, and we no longer need to reset call IC when tiering up from LLInt to Baseline JIT since both now uses the same CallLinkInfo data structure. DFG and FTL can also retrieve call information from this CallLinkInfo.
LLInt varargs calls get the same level of optimization to Baseline. Previously it does not have call IC.
When JIT is disabled, we disable polymorphic call IC since it requires dynamic code generation. In that case, we only use monomorphic one, which is the same to the old LLIntCallLinkInfo.
CallLinkInfo::doneLocation is set up only after Baseline JIT. We adjust call IC code so that we no longer rely on doneLocation when using DataIC. This allows us to smoothly tiering up from LLInt to Baseline JIT while using the same CallLinkInfo. We set up doneLocation in Baseline JIT just because DFG OSR exit requires when exiting to Baseline JIT code.
We remove CallLinkInfo from JIT constant pool, and we store CallLinkInfo in metadata so that LLInt and Baseline JIT quickly access to that and keeping unlinked Baseline JIT working.
We implement LLInt version of call IC thunks so that we can use them even when JIT is disabled.

Speedometer2 is neutral. JetStream2 is 0.7% progressed.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/CodeLocation.h:
assembler/LinkBuffer.cpp:

(JSC::shouldDumpDisassemblyFor): Deleted.

assembler/LinkBuffer.h:
assembler/MacroAssemblerCodeRef.cpp:

(JSC::shouldDumpDisassemblyFor):

assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::dumpWithName const):

bytecode/BytecodeList.rb:
bytecode/BytecodeOperandsForCheckpoint.h:

(JSC::callLinkInfoFor):

bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::clearStub):
(JSC::CallLinkInfo::setMonomorphicCallee):
(JSC::CallLinkInfo::clearCallee):
(JSC::CallLinkInfo::visitWeak):
(JSC::CallLinkInfo::emitFastPathImpl):
(JSC::CallLinkInfo::emitTailCallFastPath):
(JSC::CallLinkInfo::emitTailCallDataICFastPath):
(JSC::CallLinkInfo::emitSlowPath):
(JSC::CallLinkInfo::initializeDataIC):
(JSC::CallLinkInfo::emitDirectTailCallFastPath):
(JSC::CallLinkInfo::revertCallToStub):

bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::isLinked const):
(JSC::CallLinkInfo::stub const):
(JSC::CallLinkInfo::updateMaxArgumentCountIncludingThis):
(JSC::CallLinkInfo::forEachDependentCell const):
(JSC::CallLinkInfo::setSlowStub): Deleted.
(JSC::CallLinkInfo::clearSlowStub): Deleted.
(JSC::CallLinkInfo::addressOfMaxArgumentCountIncludingThis): Deleted.

bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeFromLLInt): Deleted.

bytecode/CallLinkStatus.h:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setupWithUnlinkedBaselineCode):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
(JSC::CodeBlock::finalizeJITInlineCaches):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::getICStatusMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::getArrayProfile):
(JSC::CodeBlock::updateAllArrayProfilePredictions):

bytecode/CodeBlock.h:
bytecode/CodeBlockInlines.h:

(JSC::CodeBlock::forEachLLIntOrBaselineCallLinkInfo):
(JSC::CodeBlock::forEachLLIntCallLinkInfo): Deleted.

bytecode/LLIntCallLinkInfo.h: Removed.
bytecode/Opcode.h:
bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::allocateSharedProfiles):

bytecode/UnlinkedCodeBlock.h:
dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::callerReturnPC):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitVirtualCall):
(JSC::AssemblyHelpers::emitVirtualCallWithoutMovingGlobalObject):

jit/AssemblyHelpers.h:
jit/BaselineJITCode.h:
jit/CallFrameShuffleData.cpp:

(JSC::CallFrameShuffleData::createForBaselineOrLLIntTailCall):

jit/CallFrameShuffleData.h:
jit/JIT.cpp:

(JSC::JIT::addUnlinkedCallLinkInfo):
(JSC::JIT::link):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::emit_op_ret):
(JSC::JIT::returnFromBaselineGenerator):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileTailCall):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

jit/JITOpcodes.cpp:

(JSC::JIT::op_ret_handlerGenerator): Deleted.

jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):
(JSC::handleHostCall): Deleted.
(JSC::virtualForWithFunction): Deleted.

jit/Repatch.cpp:

(JSC::linkSlowPathTo):
(JSC::linkSlowFor):
(JSC::webAssemblyOwner):
(JSC::linkMonomorphicCall):
(JSC::revertCall):
(JSC::unlinkCall):
(JSC::jsToWasmICCodePtr):
(JSC::linkVirtualFor):
(JSC::linkPolymorphicCall):

jit/Repatch.h:
jit/RepatchInlines.h: Added.

(JSC::handleHostCall):
(JSC::linkFor):
(JSC::virtualForWithFunction):

jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):
(JSC::virtualThunkForRegularConstruct): Deleted.
(JSC::virtualThunkForTailConstruct): Deleted.
(JSC::virtualThunkForConstructCall): Deleted.

jit/ThunkGenerators.h:
llint/LLIntData.cpp:

(JSC::LLInt::initialize):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_link_call):
(JSC::LLInt::llint_virtual_call):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::varargsSetup):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::commonCallEval):
(JSC::LLInt::genericCall): Deleted.

llint/LLIntSlowPaths.h:
llint/LLIntThunks.cpp:

(JSC::LLInt::createJSGateThunk):
(JSC::LLInt::createTailCallGate):
(JSC::LLInt::returnLocationThunk):

llint/LLIntThunks.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter.cpp:

(JSC::CLoopRegister::operator CallLinkInfo*):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
offlineasm/cloop.rb:
offlineasm/instructions.rb:
runtime/ExecutableBase.h:
runtime/FunctionExecutable.h:
runtime/Gate.h:
runtime/VM.cpp:

(JSC::VM::getCTILinkCall):
(JSC::VM::getCTIThrowExceptionFromCallSlowPath):
(JSC::VM::getCTIVirtualCall):

runtime/VM.h:

12:54 PM Changeset in webkit [285794] by mmaxfield@apple.com

156 edits in trunk/Source/WebCore

[WebGPU] Various mechanical cleanups
https://bugs.webkit.org/show_bug.cgi?id=233104

Reviewed by Dean Jackson.

Source/WebCore:

Trailing commas in enums
Update GPUFeatureName to the latest spec

No new tests because there is no behavior change (yet).

Modules/WebGPU/GPUAddressMode.h:
Modules/WebGPU/GPUBlendFactor.h:
Modules/WebGPU/GPUBlendOperation.h:
Modules/WebGPU/GPUBufferBindingType.h:
Modules/WebGPU/GPUCanvasCompositingAlphaMode.h:
Modules/WebGPU/GPUCompareFunction.h:
Modules/WebGPU/GPUCompilationMessageType.h:
Modules/WebGPU/GPUComputePassTimestampLocation.h:
Modules/WebGPU/GPUCullMode.h:
Modules/WebGPU/GPUDeviceLostReason.h:
Modules/WebGPU/GPUErrorFilter.h:
Modules/WebGPU/GPUFeatureName.h:

(WebCore::convertToBacking):

Modules/WebGPU/GPUFeatureName.idl:
Modules/WebGPU/GPUFilterMode.h:
Modules/WebGPU/GPUFrontFace.h:
Modules/WebGPU/GPUIndexFormat.h:
Modules/WebGPU/GPULoadOp.h:
Modules/WebGPU/GPUPipelineStatisticName.h:
Modules/WebGPU/GPUPowerPreference.h:
Modules/WebGPU/GPUPredefinedColorSpace.h:
Modules/WebGPU/GPUPrimitiveTopology.h:
Modules/WebGPU/GPUQueryType.h:
Modules/WebGPU/GPURenderPassTimestampLocation.h:
Modules/WebGPU/GPUSamplerBindingType.h:
Modules/WebGPU/GPUStencilOperation.h:
Modules/WebGPU/GPUStorageTextureAccess.h:
Modules/WebGPU/GPUStoreOp.h:
Modules/WebGPU/GPUTextureAspect.h:
Modules/WebGPU/GPUTextureDimension.h:
Modules/WebGPU/GPUTextureFormat.h:
Modules/WebGPU/GPUTextureSampleType.h:
Modules/WebGPU/GPUTextureViewDimension.h:
Modules/WebGPU/GPUVertexFormat.h:
Modules/WebGPU/GPUVertexStepMode.h:

Source/WebCore/PAL:

Explicitly delete some constructors and operators that we don't want
Tweak const methods
Add " namespace WebCore" around closing namespace braces
Trailing commas on enums

pal/graphics/WebGPU/WebGPU.h:
pal/graphics/WebGPU/WebGPUAdapter.h:

(PAL::WebGPU::Adapter::features const):
(PAL::WebGPU::Adapter::limits const):

pal/graphics/WebGPU/WebGPUAddressMode.h:
pal/graphics/WebGPU/WebGPUBindGroup.h:
pal/graphics/WebGPU/WebGPUBindGroupDescriptor.h:
pal/graphics/WebGPU/WebGPUBindGroupEntry.h:
pal/graphics/WebGPU/WebGPUBindGroupLayout.h:
pal/graphics/WebGPU/WebGPUBindGroupLayoutDescriptor.h:
pal/graphics/WebGPU/WebGPUBindGroupLayoutEntry.h:
pal/graphics/WebGPU/WebGPUBlendComponent.h:
pal/graphics/WebGPU/WebGPUBlendFactor.h:
pal/graphics/WebGPU/WebGPUBlendOperation.h:
pal/graphics/WebGPU/WebGPUBlendState.h:
pal/graphics/WebGPU/WebGPUBuffer.h:
pal/graphics/WebGPU/WebGPUBufferBinding.h:
pal/graphics/WebGPU/WebGPUBufferBindingLayout.h:
pal/graphics/WebGPU/WebGPUBufferBindingType.h:
pal/graphics/WebGPU/WebGPUBufferDescriptor.h:
pal/graphics/WebGPU/WebGPUBufferUsage.h:
pal/graphics/WebGPU/WebGPUCanvasCompositingAlphaMode.h:
pal/graphics/WebGPU/WebGPUCanvasConfiguration.h:
pal/graphics/WebGPU/WebGPUColorTargetState.h:
pal/graphics/WebGPU/WebGPUColorWrite.h:
pal/graphics/WebGPU/WebGPUCommandBuffer.h:
pal/graphics/WebGPU/WebGPUCommandBufferDescriptor.h:
pal/graphics/WebGPU/WebGPUCommandEncoder.h:
pal/graphics/WebGPU/WebGPUCommandEncoderDescriptor.h:
pal/graphics/WebGPU/WebGPUCompareFunction.h:
pal/graphics/WebGPU/WebGPUCompilationInfo.h:
pal/graphics/WebGPU/WebGPUCompilationMessage.h:
pal/graphics/WebGPU/WebGPUCompilationMessageType.h:
pal/graphics/WebGPU/WebGPUComputePassDescriptor.h:
pal/graphics/WebGPU/WebGPUComputePassEncoder.h:
pal/graphics/WebGPU/WebGPUComputePassTimestampLocation.h:
pal/graphics/WebGPU/WebGPUComputePipeline.h:
pal/graphics/WebGPU/WebGPUComputePipelineDescriptor.h:
pal/graphics/WebGPU/WebGPUCullMode.h:
pal/graphics/WebGPU/WebGPUDepthStencilState.h:
pal/graphics/WebGPU/WebGPUDevice.h:
pal/graphics/WebGPU/WebGPUDeviceDescriptor.h:
pal/graphics/WebGPU/WebGPUDeviceLostInfo.h:
pal/graphics/WebGPU/WebGPUDeviceLostReason.h:
pal/graphics/WebGPU/WebGPUErrorFilter.h:
pal/graphics/WebGPU/WebGPUExternalTexture.h:
pal/graphics/WebGPU/WebGPUExternalTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUExternalTextureDescriptor.h:
pal/graphics/WebGPU/WebGPUFeatureName.h:
pal/graphics/WebGPU/WebGPUFilterMode.h:
pal/graphics/WebGPU/WebGPUFragmentState.h:
pal/graphics/WebGPU/WebGPUFrontFace.h:
pal/graphics/WebGPU/WebGPUImageCopyBuffer.h:
pal/graphics/WebGPU/WebGPUImageCopyExternalImage.h:
pal/graphics/WebGPU/WebGPUImageCopyTexture.h:
pal/graphics/WebGPU/WebGPUImageCopyTextureTagged.h:
pal/graphics/WebGPU/WebGPUImageDataLayout.h:
pal/graphics/WebGPU/WebGPUIndexFormat.h:
pal/graphics/WebGPU/WebGPULoadOp.h:
pal/graphics/WebGPU/WebGPUMapMode.h:
pal/graphics/WebGPU/WebGPUMultisampleState.h:
pal/graphics/WebGPU/WebGPUObjectDescriptorBase.h:
pal/graphics/WebGPU/WebGPUOutOfMemoryError.h:

(PAL::WebGPU::OutOfMemoryError::create):

pal/graphics/WebGPU/WebGPUPipelineDescriptorBase.h:
pal/graphics/WebGPU/WebGPUPipelineLayout.h:
pal/graphics/WebGPU/WebGPUPipelineLayoutDescriptor.h:
pal/graphics/WebGPU/WebGPUPipelineStatisticName.h:
pal/graphics/WebGPU/WebGPUPowerPreference.h:
pal/graphics/WebGPU/WebGPUPredefinedColorSpace.h:
pal/graphics/WebGPU/WebGPUPrimitiveState.h:
pal/graphics/WebGPU/WebGPUPrimitiveTopology.h:
pal/graphics/WebGPU/WebGPUProgrammableStage.h:
pal/graphics/WebGPU/WebGPUQuerySet.h:
pal/graphics/WebGPU/WebGPUQuerySetDescriptor.h:
pal/graphics/WebGPU/WebGPUQueryType.h:
pal/graphics/WebGPU/WebGPUQueue.h:
pal/graphics/WebGPU/WebGPURenderBundle.h:
pal/graphics/WebGPU/WebGPURenderBundleDescriptor.h:
pal/graphics/WebGPU/WebGPURenderBundleEncoder.h:
pal/graphics/WebGPU/WebGPURenderBundleEncoderDescriptor.h:
pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDescriptor.h:
pal/graphics/WebGPU/WebGPURenderPassEncoder.h:
pal/graphics/WebGPU/WebGPURenderPassLayout.h:
pal/graphics/WebGPU/WebGPURenderPassTimestampLocation.h:
pal/graphics/WebGPU/WebGPURenderPipeline.h:
pal/graphics/WebGPU/WebGPURenderPipelineDescriptor.h:
pal/graphics/WebGPU/WebGPURequestAdapterOptions.h:
pal/graphics/WebGPU/WebGPUSampler.h:
pal/graphics/WebGPU/WebGPUSamplerBindingLayout.h:
pal/graphics/WebGPU/WebGPUSamplerBindingType.h:
pal/graphics/WebGPU/WebGPUSamplerDescriptor.h:
pal/graphics/WebGPU/WebGPUShaderModule.h:
pal/graphics/WebGPU/WebGPUShaderModuleDescriptor.h:
pal/graphics/WebGPU/WebGPUShaderStage.h:
pal/graphics/WebGPU/WebGPUStencilFaceState.h:
pal/graphics/WebGPU/WebGPUStencilOperation.h:
pal/graphics/WebGPU/WebGPUStorageTextureAccess.h:
pal/graphics/WebGPU/WebGPUStorageTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUStoreOp.h:
pal/graphics/WebGPU/WebGPUSupportedFeatures.h:
pal/graphics/WebGPU/WebGPUSupportedLimits.h:
pal/graphics/WebGPU/WebGPUTexture.h:
pal/graphics/WebGPU/WebGPUTextureAspect.h:
pal/graphics/WebGPU/WebGPUTextureBindingLayout.h:
pal/graphics/WebGPU/WebGPUTextureDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureDimension.h:
pal/graphics/WebGPU/WebGPUTextureFormat.h:
pal/graphics/WebGPU/WebGPUTextureSampleType.h:
pal/graphics/WebGPU/WebGPUTextureUsage.h:
pal/graphics/WebGPU/WebGPUTextureView.h:
pal/graphics/WebGPU/WebGPUTextureViewDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureViewDimension.h:
pal/graphics/WebGPU/WebGPUUncapturedErrorEvent.h:
pal/graphics/WebGPU/WebGPUUncapturedErrorEventInit.h:
pal/graphics/WebGPU/WebGPUValidationError.h:
pal/graphics/WebGPU/WebGPUVertexAttribute.h:
pal/graphics/WebGPU/WebGPUVertexBufferLayout.h:
pal/graphics/WebGPU/WebGPUVertexFormat.h:
pal/graphics/WebGPU/WebGPUVertexState.h:
pal/graphics/WebGPU/WebGPUVertexStepMode.h:

11:52 AM Changeset in webkit [285793] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

[JSC] Initialize m_usesT2
https://bugs.webkit.org/show_bug.cgi?id=233095

Reviewed by Alexey Shvayka.

m_usesT2 is not initialized as "false" correctly.

yarr/YarrJIT.cpp:

11:38 AM Changeset in webkit [285792] by mmaxfield@apple.com

37 edits in trunk/Source/WebGPU

[WebGPU] Add necessary additions to WebGPU.framework
https://bugs.webkit.org/show_bug.cgi?id=233091

Reviewed by Dean Jackson.

WebGPU.framework's header file is lagging a bit behind the official WebGPU API.
This updates a companion header, WebGPUExt.h, with the necessary additions.
I don't want to modify the primary header, WebGPU.h, because it's shared among
multiple projects, so coordination is necessary to modify it.

WebGPU/Adapter.h:
WebGPU/Adapter.mm:

(WebGPU::Adapter::getFeatureAtIndex):
(wgpuAdapterGetFeatureAtIndex):

WebGPU/BindGroup.h:
WebGPU/BindGroup.mm:

(WebGPU::BindGroup::setLabel):
(wgpuBindGroupSetLabel):

WebGPU/BindGroupLayout.h:
WebGPU/BindGroupLayout.mm:

(WebGPU::BindGroupLayout::setLabel):
(wgpuBindGroupLayoutSetLabel):

WebGPU/Buffer.h:
WebGPU/Buffer.mm:

(WebGPU::Buffer::setLabel):
(wgpuBufferSetLabel):

WebGPU/CommandBuffer.h:
WebGPU/CommandBuffer.mm:

(WebGPU::CommandBuffer::setLabel):
(wgpuCommandBufferSetLabel):

WebGPU/CommandEncoder.h:
WebGPU/CommandEncoder.mm:

(WebGPU::CommandEncoder::fillBuffer):
(WebGPU::CommandEncoder::setLabel):
(wgpuCommandEncoderFillBuffer):
(wgpuCommandEncoderSetLabel):

WebGPU/ComputePassEncoder.h:
WebGPU/ComputePassEncoder.mm:

(WebGPU::ComputePassEncoder::setLabel):
(wgpuComputePassEncoderSetLabel):

WebGPU/Device.h:
WebGPU/Device.mm:

(WebGPU::Device::setLabel):
(wgpuDeviceSetLabel):

WebGPU/Instance.mm:

(wgpuGetProcAddress):

WebGPU/PipelineLayout.h:
WebGPU/PipelineLayout.mm:

(WebGPU::PipelineLayout::setLabel):
(wgpuPipelineLayoutSetLabel):

WebGPU/QuerySet.h:
WebGPU/QuerySet.mm:

(WebGPU::QuerySet::setLabel):
(wgpuQuerySetSetLabel):

WebGPU/Queue.h:
WebGPU/Queue.mm:

(WebGPU::Queue::setLabel):
(wgpuQueueSetLabel):

WebGPU/RenderBundle.h:
WebGPU/RenderBundle.mm:

(WebGPU::RenderBundle::setLabel):
(wgpuRenderBundleSetLabel):

WebGPU/RenderBundleEncoder.h:
WebGPU/RenderBundleEncoder.mm:

(WebGPU::RenderBundleEncoder::setLabel):
(wgpuRenderBundleEncoderSetLabel):

WebGPU/RenderPassEncoder.h:
WebGPU/RenderPassEncoder.mm:

(WebGPU::RenderPassEncoder::setLabel):
(wgpuRenderPassEncoderSetLabel):

WebGPU/Sampler.h:
WebGPU/Sampler.mm:

(WebGPU::Sampler::setLabel):
(wgpuSamplerSetLabel):

WebGPU/Texture.h:
WebGPU/Texture.mm:

(WebGPU::Texture::setLabel):
(wgpuTextureSetLabel):

WebGPU/TextureView.h:
WebGPU/TextureView.mm:

(WebGPU::TextureView::setLabel):
(wgpuTextureViewSetLabel):

WebGPU/WebGPUExt.h:

10:47 AM Changeset in webkit [285791] by ntim@apple.com

5 edits in trunk

Modal dialogs should make the root element unfocusable
https://bugs.webkit.org/show_bug.cgi?id=233099

Reviewed by Simon Fraser.

From https://html.spec.whatwg.org/multipage/interaction.html#inert,

A Document document is blocked by a modal dialog subject if subject is
the topmost dialog element in document's top layer. While document is
so blocked, every node that is connected to document, with the
exception of the subject element and its shadow-including descendants,
must be marked inert.

RenderStyle::effectiveInert() already matches this definition, Node::deprecatedIsInert() does not.

Main reason the removed check was there is to prevent the whole document from being inert to hit-testing, but with the RenderStyle
approach, we instead override effectiveInert to false for the modal dialog. Removing this check for focus is absolutely fine
however, since focusability isn't inherited (Node::deprecatedIsInert is only used for focus).

Tests added by this Chromium WPT: https://github.com/web-platform-tests/wpt/commit/0457111e7109ec3d9e575aa421b96d8c36ce2ae8

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable-expected.txt:
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable.html:

Source/WebCore:

dom/Node.cpp:

(WebCore::Node::deprecatedIsInert const):

10:38 AM Changeset in webkit [285790] by Simon Fraser

16 edits in trunk/Source

Attach IOHIDEvent timestamps to wheel events
https://bugs.webkit.org/show_bug.cgi?id=233051

Reviewed by Wenson Hsieh.
Source/WebCore:

On some macOS devices, there can be significant deltas between NSEvent timestamps,
and the timestamps on underlying IOHIDEvents (rdar://85309639). This makes momentum
velocity computation unpredictable; we can get better results by using IOHIDEvent
timestamps.

platform/PlatformWheelEvent.cpp:

(WebCore::PlatformWheelEvent::createFromGesture):

platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::ioHIDEventTimestamp const):

platform/mac/PlatformEventFactoryMac.h:
platform/mac/PlatformEventFactoryMac.mm:

(WebCore::eventTimeStampSince1970):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

Source/WebCore/PAL:

Expose a few bits of SPI needed.

pal/spi/cg/CoreGraphicsSPI.h:
pal/spi/cocoa/IOKitSPI.h:

Source/WebKit:

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):

Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode const):
(WebKit::WebWheelEvent::decode):

Shared/WebWheelEvent.h:

(WebKit::WebWheelEvent::ioHIDEventTimestamp const):

Shared/WebWheelEventCoalescer.cpp:

(WebKit::WebWheelEventCoalescer::coalesce):

Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebWheelEvent):

Shared/mac/NativeWebGestureEventMac.mm:
Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

10:33 AM Changeset in webkit [285789] by fpizlo@apple.com

96 edits
15 adds
16 deletes in trunk/Source/bmalloc

[libpas] update to 48d608bf31ba92f8059d2c76488f00c52aaca15a: changes to support universal isoheaps
https://bugs.webkit.org/show_bug.cgi?id=233094

Reviewed by Yusuke Suzuki.

This includes a bunch of changes to make it possible to use isoheaps universally:

The bmalloc_heap API now supports isoheaped array allocations and isoheaped objects with flexible array members (i.e. flex).

Array allocations are now byte-based, not count-based, by default. When I first wrote libpas, I was sure that it would be easier for everyone if array allocation was engineered to take the array length, and the allocator worked things out from there. But this doesn't work well when the rubber hits the road:

-> Array allocation sites already know the size in bytes, and often don't even have a convenient way

of passing the length to the allocator.

-> Performing the multiplication at the allocation site means we are multiplying by a constant rather

than multiplying by a variable (as the by-count array allocation sites were doing before).

-> C++ operator new[] takes the size, not the count (though this matters less, since operator new[]

isn't useful for isoheaps anyway).

All allocation sites now have the fast path hacks that the intrinsic allocation fast path had. Specifically, they all now compile to something that has no stack frame and doesn't require PAC. The "slow" path is a tail call. Note that because that path isn't actually all that slow, it's called the "casual" path.

Size class lookup tables can now be decommitted. This is accomplished using a thing called pas_expendable_memory.

The status reporter can now report the type name of isoheaps. This relies on bmalloc_heap now using its own kind of type, rather than the generic libpas pas_simple_type, so that it can have a string. This change required corresponding changes in IsoHeap.h and bmalloc.cpp.

bmalloc.xcodeproj/project.pbxproj:
bmalloc/IsoHeap.h:

(bmalloc::api::IsoHeap::allocate):
(bmalloc::api::IsoHeap::tryAllocate):
(bmalloc::api::IsoHeap::provideHeap):

bmalloc/bmalloc.cpp:

(bmalloc::api::mallocOutOfLine):

libpas/.gitignore:
libpas/CMakeLists.txt: Added.
libpas/README: Added.
libpas/clean.sh: Added.
libpas/libpas.xcodeproj/project.pbxproj:
libpas/src/libpas/bmalloc_heap.c:

(bmalloc_try_allocate_casual):
(bmalloc_allocate_casual):
(bmalloc_try_iso_allocate_casual):
(bmalloc_iso_allocate_casual):
(bmalloc_try_allocate_array_by_size_with_alignment_casual):
(bmalloc_allocate_array_by_size_with_alignment_casual):
(bmalloc_try_iso_allocate_array_by_size):
(bmalloc_iso_allocate_array_by_size):
(bmalloc_try_iso_allocate_zeroed_array_by_size):
(bmalloc_iso_allocate_zeroed_array_by_size):
(bmalloc_try_iso_allocate_array_by_size_with_alignment):
(bmalloc_iso_allocate_array_by_size_with_alignment):
(bmalloc_try_iso_reallocate_array_by_size):
(bmalloc_iso_reallocate_array_by_size):
(bmalloc_try_iso_allocate_array_by_count):
(bmalloc_iso_allocate_array_by_count):
(bmalloc_try_iso_allocate_array_by_count_with_alignment):
(bmalloc_iso_allocate_array_by_count_with_alignment):
(bmalloc_try_iso_reallocate_array_by_count):
(bmalloc_iso_reallocate_array_by_count):
(bmalloc_try_allocate_flex_with_alignment_casual):
(bmalloc_allocate_flex_with_alignment_casual):
(bmalloc_try_allocate_flex):
(bmalloc_allocate_flex):
(bmalloc_try_allocate_zeroed_flex):
(bmalloc_allocate_zeroed_flex):
(bmalloc_try_allocate_flex_with_alignment):
(bmalloc_allocate_flex_with_alignment):
(bmalloc_try_reallocate_flex):
(bmalloc_reallocate_flex):
(bmalloc_try_allocate_auxiliary_with_alignment_casual):
(bmalloc_allocate_auxiliary_with_alignment_casual):
(bmalloc_heap_ref_get_type_size):
(bmalloc_get_allocation_size):
(bmalloc_allocate_slow): Deleted.
(bmalloc_try_iso_allocate_array): Deleted.
(bmalloc_iso_allocate_array): Deleted.
(bmalloc_try_iso_allocate_array_with_alignment): Deleted.
(bmalloc_iso_allocate_array_with_alignment): Deleted.

libpas/src/libpas/bmalloc_heap.h:
libpas/src/libpas/bmalloc_heap_config.h:
libpas/src/libpas/bmalloc_heap_inlines.h:

(bmalloc_try_allocate_inline):
(bmalloc_allocate_inline):
(bmalloc_try_iso_allocate_inline):
(bmalloc_iso_allocate_inline):
(bmalloc_try_iso_allocate_array_by_size_inline):
(bmalloc_try_iso_allocate_zeroed_array_by_size_inline):
(bmalloc_try_iso_allocate_array_by_size_with_alignment_inline):
(bmalloc_try_iso_allocate_array_by_count_inline):
(bmalloc_try_iso_allocate_array_by_count_with_alignment_inline):
(bmalloc_iso_allocate_array_by_size_inline):
(bmalloc_iso_allocate_zeroed_array_by_size_inline):
(bmalloc_iso_allocate_array_by_size_with_alignment_inline):
(bmalloc_iso_allocate_array_by_count_inline):
(bmalloc_iso_allocate_array_by_count_with_alignment_inline):
(bmalloc_try_iso_reallocate_array_by_size_inline):
(bmalloc_iso_reallocate_array_by_size_inline):
(bmalloc_try_iso_reallocate_array_by_count_inline):
(bmalloc_iso_reallocate_array_by_count_inline):
(bmalloc_try_allocate_flex_inline):
(bmalloc_allocate_flex_inline):
(bmalloc_try_allocate_zeroed_flex_inline):
(bmalloc_allocate_zeroed_flex_inline):
(bmalloc_try_allocate_flex_with_alignment_inline):
(bmalloc_allocate_flex_with_alignment_inline):
(bmalloc_try_reallocate_flex_inline):
(bmalloc_reallocate_flex_inline):
(bmalloc_try_allocate_auxiliary_inline):
(bmalloc_allocate_auxiliary_inline):
(bmalloc_try_allocate_auxiliary_with_alignment_inline):
(bmalloc_allocate_auxiliary_with_alignment_inline):
(bmalloc_try_iso_allocate_array_inline): Deleted.
(bmalloc_try_iso_allocate_array_with_alignment_inline): Deleted.
(bmalloc_iso_allocate_array_inline): Deleted.
(bmalloc_iso_allocate_array_with_alignment_inline): Deleted.

libpas/src/libpas/bmalloc_heap_innards.h:
libpas/src/libpas/bmalloc_heap_ref.h:
libpas/src/libpas/bmalloc_type.c: Added.

(bmalloc_type_create):
(bmalloc_type_try_name_dump):
(bmalloc_type_name_dump):
(bmalloc_type_dump):
(bmalloc_type_as_heap_type_dump):

libpas/src/libpas/bmalloc_type.h: Added.

(bmalloc_type_size):
(bmalloc_type_alignment):
(bmalloc_type_name):
(bmalloc_type_as_heap_type_get_type_size):
(bmalloc_type_as_heap_type_get_type_alignment):

libpas/src/libpas/hotbit_heap_config.h:
libpas/src/libpas/iso_heap.c:

(iso_heap_ref_construct):
(iso_try_allocate_array_by_count):
(iso_allocate_array_by_count):
(iso_try_allocate_array_by_count_zeroed):
(iso_allocate_array_by_count_zeroed):
(iso_try_reallocate_array_by_count):
(iso_reallocate_array_by_count):
(iso_primitive_heap_ref_construct):
(iso_try_allocate_array): Deleted.
(iso_allocate_array): Deleted.
(iso_try_allocate_array_zeroed): Deleted.
(iso_allocate_array_zeroed): Deleted.
(iso_try_reallocate_array): Deleted.
(iso_reallocate_array): Deleted.

libpas/src/libpas/iso_heap.h:
libpas/src/libpas/iso_heap_config.h:
libpas/src/libpas/iso_heap_inlines.h:

(iso_try_allocate_inline):
(iso_allocate_inline):
(iso_try_allocate_array_by_count_inline):
(iso_allocate_array_by_count_inline):
(iso_try_allocate_array_by_count_zeroed_inline):
(iso_allocate_array_by_count_zeroed_inline):
(iso_try_reallocate_array_by_count_inline):
(iso_reallocate_array_by_count_inline):
(iso_try_allocate_array_inline): Deleted.
(iso_allocate_array_inline): Deleted.
(iso_try_allocate_array_zeroed_inline): Deleted.
(iso_allocate_array_zeroed_inline): Deleted.
(iso_try_reallocate_array_inline): Deleted.
(iso_reallocate_array_inline): Deleted.

libpas/src/libpas/iso_heap_ref.h:
libpas/src/libpas/iso_test_heap.c:

(iso_test_allocate):
(iso_test_allocate_array_by_count):
(iso_test_allocate_array): Deleted.

libpas/src/libpas/iso_test_heap.h:
libpas/src/libpas/iso_test_heap_config.h:
libpas/src/libpas/jit_heap_config.c:

(jit_type_dump):
(jit_heap_config_dump_shared_page_directory_arg):

libpas/src/libpas/jit_heap_config.h:
libpas/src/libpas/minalign32_heap.c:

(minalign32_allocate):
(minalign32_allocate_array_by_count):
(minalign32_allocate_array): Deleted.

libpas/src/libpas/minalign32_heap.h:
libpas/src/libpas/minalign32_heap_config.h:
libpas/src/libpas/pagesize64k_heap.c:

(pagesize64k_allocate):
(pagesize64k_allocate_array_by_count):
(pagesize64k_allocate_array): Deleted.

libpas/src/libpas/pagesize64k_heap.h:
libpas/src/libpas/pagesize64k_heap_config.h:
libpas/src/libpas/pas_baseline_allocator_table.c:

(initialize):

libpas/src/libpas/pas_basic_segregated_page_caches.h: Removed.
libpas/src/libpas/pas_compact_expendable_memory.c: Added.

(pas_compact_expendable_memory_allocate):
(pas_compact_expendable_memory_commit_if_necessary):
(pas_compact_expendable_memory_scavenge):

libpas/src/libpas/pas_compact_expendable_memory.h: Added.

(pas_compact_expendable_memory_note_use):
(pas_compact_expendable_memory_touch):

libpas/src/libpas/pas_compact_skip_list_node_ptr.h: Removed.
libpas/src/libpas/pas_compact_skip_list_node_ptr_ptr.h: Removed.
libpas/src/libpas/pas_config.h:
libpas/src/libpas/pas_count_lookup_mode.h: Removed.
libpas/src/libpas/pas_designated_intrinsic_heap.c:

(set_up_range):
(pas_designated_intrinsic_heap_initialize):

libpas/src/libpas/pas_designated_intrinsic_heap_inlines.h:

(pas_designated_index_result_get_allocator_index):

libpas/src/libpas/pas_ensure_heap_with_page_caches.c:

(pas_ensure_heap_with_page_caches):

libpas/src/libpas/pas_enumerate_segregated_heaps.c:

(pas_enumerate_segregated_heaps):

libpas/src/libpas/pas_expendable_memory.c: Added.

(pas_expendable_memory_construct):
(pas_expendable_memory_try_allocate):
(pas_expendable_memory_allocate):
(pas_expendable_memory_commit_if_necessary):
(scavenge_impl):
(pas_expendable_memory_scavenge):

libpas/src/libpas/pas_expendable_memory.h: Added.

(pas_expendable_memory_state_get_kind):
(pas_expendable_memory_state_get_version):
(pas_expendable_memory_state_create):
(pas_expendable_memory_state_with_kind):
(pas_expendable_memory_state_with_version):
(pas_expendable_memory_note_use_impl):
(pas_expendable_memory_note_use):
(pas_expendable_memory_num_pages):
(pas_expendable_memory_num_pages_in_use):

libpas/src/libpas/pas_heap.c:

(pas_heap_reset_heap_ref):
(pas_heap_ensure_size_directory_for_size_slow):
(pas_heap_ensure_size_directory_for_count_slow): Deleted.

libpas/src/libpas/pas_heap.h:
libpas/src/libpas/pas_heap_config.h:
libpas/src/libpas/pas_heap_config_inlines.h:
libpas/src/libpas/pas_heap_config_utils.h:
libpas/src/libpas/pas_heap_inlines.h:

(pas_heap_ensure_size_directory_for_size):
(pas_heap_ensure_size_directory_for_count): Deleted.

libpas/src/libpas/pas_heap_kind.h:

(pas_heap_kind_get_string):

libpas/src/libpas/pas_heap_ref_prefix.h:
libpas/src/libpas/pas_internal_config.h:
libpas/src/libpas/pas_intrinsic_heap_support.h:
libpas/src/libpas/pas_large_expendable_memory.c: Added.

(allocate_new_large_expendable_memory):
(pas_large_expendable_memory_allocate):
(pas_large_expendable_memory_commit_if_necessary):
(pas_large_expendable_memory_scavenge):

libpas/src/libpas/pas_large_expendable_memory.h: Added.

(pas_large_expendable_memory_payload):
(pas_large_expendable_memory_header_for_object):
(pas_large_expendable_memory_note_use):
(pas_large_expendable_memory_touch):

libpas/src/libpas/pas_large_heap.c:

(allocate_impl):

libpas/src/libpas/pas_local_allocator.c:

(pas_local_allocator_construct_unselected):

libpas/src/libpas/pas_local_allocator.h:
libpas/src/libpas/pas_local_allocator_config_kind.h:

(pas_local_allocator_config_kind_get_string):

libpas/src/libpas/pas_local_allocator_inlines.h:

(pas_local_allocator_start_allocating_in_primordial_partial_view):
(pas_local_allocator_refill_with_known_config):
(pas_local_allocator_try_allocate_slow_impl):
(pas_local_allocator_try_allocate):

libpas/src/libpas/pas_lock_free_read_hashtable.h: Removed.
libpas/src/libpas/pas_object_size_mode.h: Removed.
libpas/src/libpas/pas_page_malloc.c:

(pas_page_malloc_commit):
(decommit_impl):
(pas_page_malloc_decommit):
(pas_page_malloc_decommit_asymmetric):

libpas/src/libpas/pas_page_malloc.h:
libpas/src/libpas/pas_page_sharing_pool.c:

(pas_physical_page_sharing_pool_take_for_page_config):

libpas/src/libpas/pas_redundant_local_allocator_node.c:

(pas_redundant_local_allocator_node_create):

libpas/src/libpas/pas_scavenger.c:

(scavenger_thread_main):
(pas_scavenger_decommit_expendable_memory):
(pas_scavenger_run_synchronously_now):
(pas_scavenger_perform_synchronous_operation):

libpas/src/libpas/pas_scavenger.h:
libpas/src/libpas/pas_segregated_exclusive_view_inlines.h:

(pas_segregated_exclusive_view_note_eligibility):

libpas/src/libpas/pas_segregated_heap.c:

(max_object_size_for_page_config):
(max_bitfit_object_size_for_heap_config):
(pas_segregated_heap_construct):
(pas_segregated_heap_get_cached_index_for_heap_type):
(pas_segregated_heap_cached_index_is_set):
(pas_segregated_heap_get_cached_index):
(pas_segregated_heap_index_is_cached_index_and_cached_index_is_set):
(pas_segregated_heap_index_is_cached_index_or_cached_index_is_unset):
(pas_segregated_heap_index_is_not_cached_index_and_cached_index_is_set):
(pas_segregated_heap_index_is_greater_than_cached_index_and_cached_index_is_set):
(pas_segregated_heap_index_is_greater_equal_cached_index_and_cached_index_is_set):
(pas_segregated_heap_size_directory_for_index_slow):
(pas_segregated_heap_medium_allocator_index_for_index):
(compute_small_index_upper_bound):
(ensure_size_lookup):
(size_directory_min_heap_compare):
(size_directory_min_heap_get_index):
(size_directory_min_heap_set_index):
(recompute_size_lookup):
(rematerialize_size_lookup_set_index_to_small_allocator_index):
(rematerialize_size_lookup_set_index_to_small_size_directory):
(rematerialize_size_lookup_set_medium_directory_tuple):
(rematerialize_size_lookup_if_necessary):
(pas_segregated_heap_ensure_allocator_index):
(compute_ideal_object_size):
(ensure_size_lookup_if_necessary):
(check_size_lookup_recomputation_did_become_not_all_good):
(check_size_lookup_recomputation_set_index_to_small_allocator_index):
(check_size_lookup_recomputation_set_index_to_small_size_directory):
(check_size_lookup_recomputation_set_medium_directory_tuple):
(check_size_lookup_recomputation):
(pas_segregated_heap_ensure_size_directory_for_size):
(max_count_for_page_config): Deleted.
(max_small_count_for_heap_config): Deleted.
(ensure_count_lookup): Deleted.
(ensure_count_lookup_if_necessary): Deleted.
(pas_segregated_heap_ensure_size_directory_for_count): Deleted.

libpas/src/libpas/pas_segregated_heap.h:

(pas_segregated_heap_index_for_size):
(pas_segregated_heap_size_for_index):
(pas_segregated_heap_allocator_index_for_index_inline_only):
(pas_segregated_heap_allocator_index_for_index):
(pas_segregated_heap_allocator_index_for_size_inline_only):
(pas_segregated_heap_allocator_index_for_size):
(pas_segregated_heap_index_for_primitive_count): Deleted.
(pas_segregated_heap_primitive_count_for_index): Deleted.
(pas_segregated_heap_index_for_count): Deleted.
(pas_segregated_heap_count_for_index): Deleted.
(pas_segregated_heap_allocator_index_for_count_not_primitive): Deleted.

libpas/src/libpas/pas_segregated_heap_inlines.h:

(pas_segregated_heap_size_directory_for_index):
(pas_segregated_heap_size_directory_for_size):
(pas_segregated_heap_touch_lookup_tables):
(pas_segregated_heap_size_directory_for_count): Deleted.

libpas/src/libpas/pas_segregated_heap_page_sharing_mode.h: Removed.
libpas/src/libpas/pas_segregated_page.c:

(pas_segregated_page_construct):

libpas/src/libpas/pas_segregated_page_granule_use_count.h: Removed.
libpas/src/libpas/pas_segregated_page_header_placement_mode.h: Removed.
libpas/src/libpas/pas_segregated_shared_page_directory.c:

(take_last_empty_consider_view):

libpas/src/libpas/pas_segregated_shared_page_directory.h:
libpas/src/libpas/pas_segregated_size_directory.c:

(pas_segregated_size_directory_create):
(pas_segregated_size_directory_ensure_data):
(pas_segregated_size_directory_create_tlc_allocator):
(pas_segregated_size_directory_create_tlc_view_cache):
(pas_segregated_size_directory_select_allocator_slow):
(pas_segregated_size_directory_get_allocator_from_tlc):
(pas_segregated_size_directory_dump_reference):

libpas/src/libpas/pas_segregated_size_directory.h:

(pas_segregated_size_directory_decode_baseline_allocator_index):
(pas_segregated_size_directory_decode_min_index):
(pas_segregated_size_directory_encode_stuff):
(pas_segregated_size_directory_as_view):
(pas_segregated_size_directory_alignment):
(pas_segregated_size_directory_baseline_allocator_index):
(pas_segregated_size_directory_min_index):
(pas_segregated_size_directory_set_baseline_allocator_index):
(pas_segregated_size_directory_compare_and_swap_baseline_allocator_index_weak):
(pas_segregated_size_directory_set_min_index):
(pas_segregated_size_directory_has_tlc_allocator):

libpas/src/libpas/pas_segregated_size_directory_inlines.h:

(pas_segregated_size_directory_select_allocator):

libpas/src/libpas/pas_shared_handle_or_page.h: Removed.
libpas/src/libpas/pas_shared_handle_or_page_inlines.h: Removed.
libpas/src/libpas/pas_shared_page_directory_by_size.c:

(pas_shared_page_directory_by_size_get):
(pas_shared_page_directory_by_size_dump_directory_arg):

libpas/src/libpas/pas_shared_page_directory_by_size.h:
libpas/src/libpas/pas_simple_type.c: Added.

(pas_simple_type_dump):
(pas_simple_type_as_heap_type_dump):

libpas/src/libpas/pas_simple_type.h:
libpas/src/libpas/pas_size_lookup_mode.h: Added.

(pas_size_lookup_mode_get_string):

libpas/src/libpas/pas_size_thunk.h: Removed.
libpas/src/libpas/pas_skip_list.c: Removed.
libpas/src/libpas/pas_skip_list.h: Removed.
libpas/src/libpas/pas_skip_list_inlines.h: Removed.
libpas/src/libpas/pas_status_reporter.c:

(pas_status_reporter_dump_segregated_shared_page_directory):
(pas_status_reporter_dump_heap):
(pas_status_reporter_dump_thread_local_caches):
(pas_status_reporter_dump_configuration):
(pas_status_reporter_dump_physical_page_sharing_pool):
(dump_expendable_memory):
(pas_status_reporter_dump_expendable_memories):
(pas_status_reporter_dump_everything):

libpas/src/libpas/pas_status_reporter.h:
libpas/src/libpas/pas_thread_local_cache.c:

(allocate_cache):
(pas_thread_local_cache_create):
(pas_thread_local_cache_get_local_allocator_slow):
(pas_thread_local_cache_get_local_allocator_if_can_set_cache_for_possibly_uninitialized_index_slow):
(stop_local_allocators_if_necessary_set_bit_callback):
(pas_thread_local_cache_for_all):
(pas_thread_local_cache_get_local_allocator_if_can_set_cache_slow): Deleted.

libpas/src/libpas/pas_thread_local_cache.h:

(pas_thread_local_cache_get_local_allocator_direct_without_any_checks_whatsoever):
(pas_thread_local_cache_get_local_allocator_direct_for_initialization):
(pas_thread_local_cache_get_local_allocator_direct_unchecked):
(pas_thread_local_cache_get_local_allocator_direct):
(pas_thread_local_cache_get_local_allocator_for_possibly_uninitialized_but_not_unselected_index):
(pas_thread_local_cache_get_local_allocator_for_initialized_index):
(pas_thread_local_cache_get_local_allocator_for_possibly_uninitialized_index):
(pas_thread_local_cache_try_get_local_allocator_or_unselected_for_uninitialized_index):
(pas_thread_local_cache_try_get_local_allocator_for_possibly_uninitialized_but_not_unselected_index):
(pas_thread_local_cache_get_local_allocator_if_can_set_cache_for_possibly_uninitialized_index):
(pas_thread_local_cache_get_local_allocator_impl): Deleted.
(pas_thread_local_cache_get_local_allocator): Deleted.
(pas_thread_local_cache_try_get_local_allocator): Deleted.
(pas_thread_local_cache_get_local_allocator_if_can_set_cache): Deleted.

libpas/src/libpas/pas_thread_local_cache_layout.c:

(pas_thread_local_cache_layout_add_node):

libpas/src/libpas/pas_thread_local_cache_layout_node.c:

(pas_thread_local_cache_layout_node_construct):
(pas_thread_local_cache_layout_node_move):
(pas_thread_local_cache_layout_node_stop):

libpas/src/libpas/pas_try_allocate.h:

(pas_try_allocate_impl_casual_case):
(pas_try_allocate_impl_inline_only):
(pas_try_allocate_impl_size_thunk): Deleted.
(pas_try_allocate_impl): Deleted.

libpas/src/libpas/pas_try_allocate_array.h:

(pas_try_allocate_array_impl_casual_case_with_heap):
(pas_try_allocate_array_impl_inline_only_with_heap):
(pas_try_allocate_array_impl_inline_only):
(pas_try_allocate_array_impl): Deleted.

libpas/src/libpas/pas_try_allocate_common.h:

(pas_try_allocate_compute_aligned_size):
(pas_try_allocate_common_impl_fast):
(pas_try_allocate_common_impl_slow):
(pas_try_allocate_common_impl):

libpas/src/libpas/pas_try_allocate_intrinsic.h:

(pas_try_allocate_intrinsic_impl_casual_case):
(pas_try_allocate_intrinsic_impl_inline_only):
(pas_try_allocate_intrinsic_impl_medium_slow_case): Deleted.

libpas/src/libpas/pas_try_allocate_primitive.h:

(pas_try_allocate_primitive_impl_casual_case):
(pas_try_allocate_primitive_impl_inline_only):
(pas_try_allocate_primitive_impl): Deleted.

libpas/src/libpas/pas_try_reallocate.h:

(pas_try_allocate_for_reallocate_and_copy):
(pas_try_reallocate_table_segregated_case):
(pas_try_reallocate_table_bitfit_case):
(pas_try_reallocate):
(pas_try_reallocate_intrinsic_allocate_callback):
(pas_try_reallocate_intrinsic):
(pas_try_reallocate_single_allocate_callback):
(pas_try_reallocate_single):
(pas_try_reallocate_array_allocate_callback):
(pas_try_reallocate_array_by_size):
(pas_try_reallocate_array_by_count):
(pas_try_reallocate_primitive_allocate_callback):
(pas_try_reallocate_primitive):
(pas_try_reallocate_array): Deleted.

libpas/src/libpas/pas_typed_allocation_result.h: Removed.
libpas/src/libpas/pas_utility_heap.c:
libpas/src/libpas/pas_utility_heap_config.c:

(pas_utility_heap_config_dump_shared_page_directory_arg):

libpas/src/libpas/pas_utility_heap_config.h:
libpas/src/libpas/pas_utils.c:

(pas_reallocation_did_fail):

libpas/src/libpas/pas_utils.h:

(pas_compare_and_swap_uint8_weak):

libpas/src/libpas/pas_utils_prefix.h:
libpas/src/libpas/thingy_heap.c:

(thingy_try_allocate):
(thingy_try_allocate_zeroed):
(thingy_try_allocate_array):
(thingy_try_allocate_zeroed_array):
(thingy_try_reallocate_array):

libpas/src/libpas/thingy_heap_config.h:
libpas/src/test/ExpendableMemoryTests.cpp: Added.

(std::testPayloadImpl):
(std::forEachExpendableMemory):
(std::checkAllDecommitted):
(std::checkAllInUseCommitted):
(std::testSynchronousScavengingExpendsExpendableMemory):
(std::scavengerWillShutDown):
(std::testScavengerExpendsExpendableMemory):
(std::testSoManyHeaps):
(addExpendableMemoryTests):

libpas/src/test/HeapRefAllocatorIndexTests.cpp: Added.

(addHeapRefAllocatorIndexTests):

libpas/src/test/IsoHeapChaosTests.cpp:

(std::createIsoHeapRefForSize):
(std::createBmallocHeapRefForSize):
(std::testAllocationChaos):
(std::addIsoTests):
(std::addAllTests):
(addIsoHeapChaosTests):

libpas/src/test/IsoHeapPageSharingTests.cpp:

(std::testLargeHeapTakesPagesFromCorrectLargeHeapWithFancyOrder):
(std::addAllTests):

libpas/src/test/IsoHeapPartialAndBaselineTests.cpp:

(std::addScavengerDependentTests):

libpas/src/test/TSDTests.cpp:

(std::destructor):

libpas/src/test/TestHarness.cpp:

(EnablePageBalancing::EnablePageBalancing):
(DisablePageBalancing::DisablePageBalancing):
(main):

libpas/src/test/TestHarness.h:
libpas/src/test/ThingyAndUtilityHeapAllocationTests.cpp:

(std::verifyHeapEmpty):
(std::createIsolatedHeapRef):
(std::addSmallHeapTests):

12:45 AM Changeset in webkit [285788] by commit-queue@webkit.org

4 edits in trunk

Prevent fused multiply add during ParseInt
https://bugs.webkit.org/show_bug.cgi?id=232951

Patch by Mikhail R. Gadelha <Mikhail R. Gadelha> on 2021-11-14
Reviewed by Yusuke Suzuki.

When parsing the string in parseInt, gcc can wrongfully generate
a fused multiply-add instruction, causing the conversion to be wrong
for some high values. An add followed by a multiply gives the correct
result and it is the code generated most of the times.

This patch adds a volatile qualifier to the number variable, so the
compiler doesn't try to optimize it, and enables a failing test on
mips.

Alternative solutions that I tried but gcc seems to ignore: #pragma
STDC FP_CONTRACT OFF, compiling with -ffp-contract=off, and setting function
attributes attribute((optimize("fp-contract=off"))) and
attribute((optimize("-ffp-contract=off"))), so volative seems to be
a good compromise.

The issue was found when cross compiling to mips with gcc 8.4.0 and
options -ffp-contract=off -mmadd4.

JSTests:

ChakraCore.yaml:

Source/JavaScriptCore:

runtime/ParseInt.h:

(JSC::parseInt):

Nov 13, 2021:

11:37 PM Changeset in webkit [285787] by Simon Fraser

12 edits
4 adds in trunk

Run a ScrollAnimationMomentum for the momentum phase of a scroll
https://bugs.webkit.org/show_bug.cgi?id=232897

Reviewed by Tim Horton.
Source/WebCore:

Run an animation for the momentum phase of a scroll, rather than scrolling in response
to wheel events, because it produces a smoother result with fewer dropped frames.

We re-use ScrollAnimationMomentum which is already used for scroll snap, but have to
allow it to yield unclamped coordinates, since using it for momentum can result in
rubber-banding.

When we get the momentum "began" event, we start the ScrollAnimationMomentum
using initial velocity computed from WheelEventDeltaFilter. ScrollingEffectsController then
ignores the reset of the momentum "changed" events.

We have to stop this animation when we receive a "begin" or "mayBegin" event, since
this indicates that the user has put fingers down on the trackpad.

Rename m_dragEndedScrollingVelocity to m_scrollingVelocityForScrollSnap for clarity
(at some point we should merge this with m_scrollingVelocityForMomentumAnimation).

Tests: fast/scrolling/mac/momentum-animator-in-overflow.html

fast/scrolling/mac/momentum-animator.html

page/WheelEventDeltaFilter.cpp:

(WebCore::WheelEventDeltaFilter::shouldApplyFilteringForEvent):

page/WheelEventDeltaFilter.h:
platform/PlatformWheelEvent.cpp:

(WebCore::operator<<):

platform/ScrollAnimationMomentum.cpp:

(WebCore::ScrollAnimationMomentum::startAnimatedScrollWithInitialVelocity):
(WebCore::ScrollAnimationMomentum::stop):
(WebCore::ScrollAnimationMomentum::serviceAnimation):

platform/ScrollAnimationMomentum.h:
platform/ScrollingEffectsController.cpp:

(WebCore::ScrollingEffectsController::ScrollingEffectsController):
(WebCore::ScrollingEffectsController::stopAnimatedNonRubberbandingScroll):
(WebCore::ScrollingEffectsController::startMomentumScrollWithInitialVelocity):

platform/ScrollingEffectsController.h:

(WebCore::ScrollingEffectsController::momentumScrollingAnimatorEnabled const):

platform/mac/ScrollingEffectsController.mm:

(WebCore::phaseToString):
(WebCore::ScrollingEffectsController::handleWheelEvent):
(WebCore::ScrollingEffectsController::startRubberBandAnimation):
(WebCore::ScrollingEffectsController::startRubberBandAnimationIfNecessary):
(WebCore::ScrollingEffectsController::processWheelEventForScrollSnap):

Source/WTF:

Set the MomentumScrollingAnimatorEnabled internal setting to off by default
while we bring up tests.

Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

Some tests that enable the momentum animator.

fast/scrolling/mac/momentum-animator-expected.txt: Added.
fast/scrolling/mac/momentum-animator-in-overflow-expected.txt: Added.
fast/scrolling/mac/momentum-animator-in-overflow.html: Added.
fast/scrolling/mac/momentum-animator.html: Added.

9:05 PM Changeset in webkit [285786] by timothy_horton@apple.com

8 edits
1 copy in trunk/Source/WebCore

Clean up IOKit SPI headers
https://bugs.webkit.org/show_bug.cgi?id=233093

Reviewed by Simon Fraser.

Source/WebCore:

platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
platform/gamepad/mac/HIDGamepadProvider.h:
platform/gamepad/mac/HIDGamepadProvider.mm:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/cg/CoreGraphicsSPI.h:
pal/spi/cocoa/IOKitSPI.h:
pal/spi/ios/IOKitSPIIOS.h: Added.
pal/spi/mac/IOKitSPIMac.h:

IOKit vends a much different set of public API on iOS vs. macOS,
so we have separate SPI headers to reduce the confusion.

Unfortunately, the SPI header for iOS was not explicitly named as such,
and started being used in some macOS code. For a while, this didn't lead
to any trouble because the aforementioned macOS code didn't ALSO have
the public SDK headers included, but a future patch from Simon will
use IOKitSPI.h in a place where the macOS IOKit public headers are included,
and thus we must make the split more explicit.

Rename IOKitSPI.h to IOKitSPIIOS.h; make IOKitSPI choose the right one.
Add some SPI defintions to IOKitSPIMac.h that were missing (which the
dependent code was getting via the iOS header on macOS).

4:19 PM Changeset in webkit [285785] by Said Abou-Hallawa

4 edits in trunk

REGRESSION (r285618): [mac-wk1] ASSERTION FAILED: cgContext == [currentContext CGContext]
https://bugs.webkit.org/show_bug.cgi?id=233008
rdar://85311948

Reviewed by Wenson Hsieh.

Source/WebCore:

The assertion fails when loading the expected html page because one of
the elements has a CSS filter named "(#noop)" but the filter "noop" is
not defined.

The reason for the assertion to fail is we switch the PaintInfo to the
context of the CSSFilter::sourceImage() and we do not restore it back.
In fact CSSFilter::buildFilterFunctions() should fail since the filter
has only a reference filter and this reference filter does not exit. The
bug is CSSFilter::buildFilterFunctions() does not fail in this case.

Before r285618, CSSFilter::buildFilterFunctions() was not adding
SourceGraphic to m_functions. It was added as the input of the first
FilterEffect. This was fine since we were applying the lastEffect which
goes backward till it reaches the SourceGraphic.

But the plan is to apply the FilterFunctions from the first to the last
without having to go backward, so we need to add the SourceGraphic to
m_functions explicitly. The bug happens when no FilterFunction is built
successfully and we return 'true' because m_functions is not empty. It
has the SourceGraphic.

The fix is to add the SourceGraphic only when there is at least another
FilterFunction will be added to m_functions.

rendering/CSSFilter.cpp:

(WebCore::CSSFilter::buildFilterFunctions):

LayoutTests:

Unskip the test http/tests/css/filters-on-iframes-transform.html which
was skipped in r285656.

platform/mac-wk1/TestExpectations:

3:28 PM Changeset in webkit [285784] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Inline box end's padding/border/margin should be taken into account when computing horizontal position for bidi content
https://bugs.webkit.org/show_bug.cgi?id=233083

Reviewed by Antti Koivisto.

Let's decouple the "display box rect" and the "content right in visual order" computation.
There are runs (e.g. inline box end) that don't need to call displayBoxRect() but they
still affect the "content right in visual order" (<span style="border-right: 10px solid green">).

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent): add the additional lineRun.isInlineBoxEnd() case.

3:21 PM Changeset in webkit [285783] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][Integration] Add support for optional bidi character coverage checking
https://bugs.webkit.org/show_bug.cgi?id=233049

Reviewed by Antti Koivisto.

This is in preparation for enabling bidi for IFC.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:
layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForFontAndText):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

3:04 PM Changeset in webkit [285782] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC][Integration] Bring showRenderTree for IFC integration back
https://bugs.webkit.org/show_bug.cgi?id=233000

Reviewed by Antti Koivisto.

Currently showRenderTree comes back blank for IFC content.

layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::showInlineContent):

layout/integration/LayoutIntegrationBoxTree.h:
layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::outputLineTree const):

3:04 PM Changeset in webkit [285781] by Simon Fraser

9 edits in trunk

Implement UIScriptController.sendEventStream() for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=233090

Reviewed by Wenson Hsieh.
Tools:

Implement UIScriptControllerMac::sendEventStream(), sharing some event dispatching code from
EventSendingController.

DumpRenderTree/mac/EventSendingController.h:
DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
(-[EventSendingController sendScrollEventAt:deltaX:deltaY:units:wheelPhase:momentumPhase:timestamp:]):

DumpRenderTree/mac/UIScriptControllerMac.h:
DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::gesturePhaseFromString):
(WTR::momentumPhaseFromString):
(WTR::eventSenderFromView):
(WTR::UIScriptControllerMac::sendEventStream):

LayoutTests:

Convert one test that runs in WK1 to use sendEventStream().

fast/scrolling/overflow-scroll-past-max.html:
resources/ui-helper.js:

1:59 PM Changeset in webkit [285780] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Inline box end (opaque to bidi) should get the bidi level from its adjacent content
https://bugs.webkit.org/show_bug.cgi?id=233082

Reviewed by Antti Koivisto.

While the inline box start item (<span>) gets the bidi level from the next (adjacent) content, inline box end (</span>)
should get it from the previous content (these are opaque inline items).

e.g <span>bidi content</span>
both the inline box start and the inline box end items get their bidi level from the "bidi content" inline text item.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

1:58 PM Changeset in webkit [285779] by Jonathan Bedard

7 edits in trunk/Tools

Unreviewed, reverting r285772.

Ownership issues in some XCode installs

Reverted changeset:

"[webkitpy] Symlink daemons into simulator runtime root"
https://bugs.webkit.org/show_bug.cgi?id=233080
https://commits.webkit.org/r285772

1:57 PM Changeset in webkit [285778] by commit-queue@webkit.org

16 edits in trunk/LayoutTests

AX: Make 7 more layout tests async so that they pass in --release --accessibility-isolated-tree mode
https://bugs.webkit.org/show_bug.cgi?id=233085

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-13
Reviewed by Chris Fleizach.

This patch makes 7 more tests async so that they pass in --release
--accessibility-isolated-tree mode. This patch also adds some helper
functions to accessibility-helper.js.

accessibility/ancestor-computation.html:

Move waitForElement to accessibility-helpers.js and rename to
waitForElementById.

accessibility/color-well-expected.txt:
accessibility/color-well.html:
accessibility/mac/scrollbars.html:
accessibility/placeholder-expected.txt:
accessibility/placeholder.html:
accessibility/progressbar-expected.txt:
accessibility/progressbar.html:
accessibility/range-alter-by-percent-expected.txt:
accessibility/range-alter-by-percent.html:
accessibility/range-alter-by-step-expected.txt:
accessibility/range-alter-by-step.html:
accessibility/spinbutton-value-expected.txt:
accessibility/spinbutton-value.html:

Make tests async so they pass in isolated tree mode.
Minor updates to expectations:

Some variables renamed for better readability
Sometimes there is one more or one less newline after the test rewrites

resources/accessibility-helper.js:

(async waitForElementById): Added. Originally defined in
accessibility/ancestor-computation.html.
(async waitForExpression): Added.

10:49 AM Changeset in webkit [285777] by mmaxfield@apple.com

2 edits in trunk

[WebGPU] Add WebGPU.xcodeproj to WebKit.xcworkspace
https://bugs.webkit.org/show_bug.cgi?id=233078

Reviewed by Dean Jackson.

Mechanical change. When building WebGPU becomes required,
people using this workspace will need it.

WebKit.xcworkspace/contents.xcworkspacedata:

10:38 AM Changeset in webkit [285776] by commit-queue@webkit.org

9 edits in trunk

AX: Make accessibility/mac/header.html test async to fix it for isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=233017

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-11-13
Reviewed by Andres Gonzalez.

Tools:

This patch implements the domIdentifier attribute for DumpRenderTree
elements. When making this test async, I wanted to use this attribute,
hence the implementation in this patch.

DumpRenderTree/AccessibilityUIElement.cpp:

(domIdentifierCallback): Added.
(AccessibilityUIElement::getJSClass):
Add "domIdentifer" entry to staticValues[].

DumpRenderTree/AccessibilityUIElement.h:

Add AccessibilityUIElement::domIdentifier const definition.

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::domIdentifier const): Added.

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::domIdentifier const): Added.

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::domIdentifier const):Added.

LayoutTests:

This test needs to be made async, as we need to wait for
accessibilityController.focusedElement to be synced with the DOM
focused element before running our expectations. This fixes the
test in isolated tree mode.

accessibility/mac/header-expected.txt:

Remove extra newline at end of the file.

accessibility/mac/header.html:

Make test async.

8:44 AM Changeset in webkit [285775] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS][GPUP] Remove logging of used syscalls
https://bugs.webkit.org/show_bug.cgi?id=232839
<rdar://problem/85168823>

Reviewed by Brent Fulgham.

Based on telemetry, remove logging of used unix syscalls in the GPU process on macOS.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

8:13 AM Changeset in webkit [285774] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[macOS][GPUP] Add telemetry for syscalls
https://bugs.webkit.org/show_bug.cgi?id=232888
<rdar://problem/85207011>

Reviewed by Brent Fulgham.

Add more telemetry for syscalls in the GPU process' sandbox on macOS. Also add entitlement for the GPU
process to use message filtering.

GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Scripts/process-entitlements.sh:

8:09 AM Changeset in webkit [285773] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS][GPUP] Add system call logging
https://bugs.webkit.org/show_bug.cgi?id=233079
<rdar://problem/85362041>

Reviewed by Brent Fulgham.

Add telemetry for system calls in the GPU process' sandbox on iOS.

Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed