Context Navigation

← Previous Period
Next Period →

Timeline

Dec 16, 2021:

11:21 PM Changeset in webkit [287174] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Adjust syscall filter
https://bugs.webkit.org/show_bug.cgi?id=234401

Reviewed by Tim Horton.

Adjust syscall filter in the WebContent process' sandbox on macOS. A syscall that was previously
believed to only be used on Intel, is being used on all architectures.

WebProcess/com.apple.WebProcess.sb.in:

10:01 PM Changeset in webkit [287173] by clopez@igalia.com

2 edits in trunk/Source/WebCore

REGRESSION(r287138) [GLIB] Build failure with GCC 8 and 9 in std::array to Span conversion
https://bugs.webkit.org/show_bug.cgi?id=234412

Reviewed by Darin Adler.

GCC < 10 and Clang < 7 have problems doing the conversion of the value if its marked const.

No new tests, is a build fix.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):

9:54 PM Changeset in webkit [287172] by Alan Coon

1 copy in tags/Safari-612.4.6

Tag Safari-612.4.6.

9:47 PM Changeset in webkit [287171] by Alan Coon

1 edit in branches/safari-612-branch/Source/WebCore/platform/ios/LegacyTileCache.mm

Unreviewed build fix. rdar://86613209

9:36 PM Changeset in webkit [287170] by Alan Coon

1 edit in branches/safari-612-branch/Source/WebCore/platform/ios/LegacyTileCache.mm

Unreviewed build fix. rdar://86613209

./platform/ios/LegacyTileCache.mm:459:24: error: incomplete result type 'WebCore::Color' in function definition
Color LegacyTileCache::colorForGridTileBorder(LegacyTileGrid* grid) const

9:32 PM Changeset in webkit [287169] by Alan Coon

8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.4.6

6:44 PM Changeset in webkit [287168] by ysuzuki@apple.com

2 edits in trunk/Source/bmalloc

[libpas] ARM64 CAS emulation loop needs dmb ish
https://bugs.webkit.org/show_bug.cgi?id=234414

Reviewed by Filip Pizlo.

Just using LL/SC does not guarantee that the ordering of accesses around the loop. For example,

access(A)

0:

LL (ldaxr)
...
SC (stlxr)
cond-branch 0
access(B)

In the above code case, the ordering A -> LL -> SC -> B is not guaranteed and it can be
LL -> A -> B -> SC or LL -> B -> A -> SC: memory access may happen in the middle of RMW atomics.
This breaks pas_versioned_field's assumption where they are ordered as A -> LL -> SC -> B.

https://stackoverflow.com/questions/35217406/partial-reordering-of-c11-atomics-on-aarch64
https://stackoverflow.com/questions/21535058/arm64-ldxr-stxr-vs-ldaxr-stlxr
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/229588.html

Another example is that the following can happen if we use CAS loop without barrier.

thread A

*a = 1;
spin_lock(&lock);
*b = 1;

thread B

b_value = atomic_get(&b);
a_value = atomic_get(&a);

assert(a_value

!b_value); can fail

https://github.com/zephyrproject-rtos/zephyr/issues/32133
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65697

To guarantee A -> (atomic) -> B ordering, we insert barrier (dmb ish) just after the loop.

access(A)

0:

LL (ldxr)
...
SC (stlxr)
cond-branch 0
dmb ish
access(B)

dmb ish ensures B is done after (atomic) region. And this barrier also ensures that A cannot happen after
For this CAS emulation loop, we do not need to have acquire, so we can use ldxr. (atomic) region.
SC ensures A does not happen after SC. But still, A and LL can be reordered.
If A is storing to the same location X, then it will be detected due to ldxr's exclusiveness.

data = LL(X)
store(X, 42) Reordered here
=> SC will fail.

If A is storing to the different location, then we have no way to observe the difference.

data = LL(X)
store(A, 42) Reordered here. But there is no way to know whether this access happens before or after LL.

libpas/src/libpas/pas_utils.h:

5:52 PM Changeset in webkit [287167] by Tyler Wilcock

8 edits in trunk/LayoutTests

AX: Make aria-multiline.html, clipped-text-under-element.html, mixed-checkbox.html, and selection-states.html pass in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=234382

Reviewed by Chris Fleizach.

accessibility/mac/aria-multiline-expected.txt:
accessibility/mac/aria-multiline.html:
accessibility/mac/clipped-text-under-element.html:
accessibility/mac/mixed-checkbox-expected.txt:
accessibility/mac/mixed-checkbox.html:
accessibility/selection-states-expected.txt:
accessibility/selection-states.html:

Make these tests pass in isolated tree mode by using
accessibilityController.accessibleElementById to get JS references to
AX objects instead of document.getElementById() +
accessibilityController.focusedElement.

5:22 PM Changeset in webkit [287166] by Russell Epstein

1 copy in tags/Safari-613.1.12

Tag Safari-613.1.12.

5:09 PM Changeset in webkit [287165] by Russell Epstein

112 edits
2 adds
5 deletes in branches/safari-613.1.12-branch/Source

Cherry-pick r286994. rdar://problem/86445989

Roll back r286345, r286387, r286471, r286667, r286849
https://bugs.webkit.org/show_bug.cgi?id=234268

Reviewed by Mark Lam.

Source/JavaScriptCore:

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp: (JSC::AccessCase::AccessCase): (JSC::AccessCase::forEachDependentCell const): (JSC::AccessCase::dump const): (JSC::AccessCase::propagateTransitions const): (JSC::AccessCase::generateWithGuard): (JSC::AccessCase::canBeShared):
bytecode/AccessCase.h: (JSC::AccessCase::structure const): (JSC::AccessCase::newStructure const): (JSC::AccessCase::hash const): (JSC::AccessCase::AccessCase):
bytecode/ArrayProfile.cpp: (JSC::ArrayProfile::computeUpdatedPrediction):
bytecode/ArrayProfile.h:
bytecode/CheckPrivateBrandStatus.cpp: (JSC::CheckPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/CodeBlock.cpp: (JSC::CodeBlock::propagateTransitions): (JSC::CodeBlock::determineLiveness): (JSC::CodeBlock::finalizeLLIntInlineCaches): (JSC::CodeBlock::stronglyVisitWeakReferences):
bytecode/DeleteByStatus.cpp: (JSC::DeleteByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/GetByIdMetadata.h: (JSC::GetByIdModeMetadata::GetByIdModeMetadata): (JSC::GetByIdModeMetadata::clearToDefaultModeWithoutCache):
bytecode/GetByStatus.cpp: (JSC::GetByStatus::computeFromLLInt): (JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InByStatus.cpp: (JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InlineAccess.cpp: (JSC::InlineAccess::rewireStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccess):
bytecode/InstanceOfStatus.cpp: (JSC::InstanceOfStatus::computeForStubInfo):
bytecode/InternalFunctionAllocationProfile.h: (JSC::InternalFunctionAllocationProfile::offsetOfStructure): (JSC::InternalFunctionAllocationProfile::structure): (JSC::InternalFunctionAllocationProfile::clear): (JSC::InternalFunctionAllocationProfile::visitAggregate): (JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase): (JSC::InternalFunctionAllocationProfile::offsetOfStructureID): Deleted.
bytecode/PolyProtoAccessChain.cpp: (JSC::PolyProtoAccessChain::needImpurePropertyWatchpoint const):
bytecode/PolyProtoAccessChain.h:
bytecode/PolymorphicAccess.cpp: (JSC::PolymorphicAccess::visitWeak const):
bytecode/PutByIdFlags.h:
bytecode/PutByStatus.cpp: (JSC::PutByStatus::computeFromLLInt): (JSC::PutByStatus::computeForStubInfo):
bytecode/SetPrivateBrandStatus.cpp: (JSC::SetPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/SpeculatedType.cpp: (JSC::speculationFromCell):
bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::initInByIdSelf): (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::aboutToDie): (JSC::StructureStubInfo::addAccessCase): (JSC::StructureStubInfo::reset): (JSC::StructureStubInfo::visitAggregateImpl): (JSC::StructureStubInfo::visitWeakReferences): (JSC::StructureStubInfo::propagateTransitions): (JSC::StructureStubInfo::summary const): (JSC::StructureStubInfo::containsPC const):
bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::offsetOfByIdSelfOffset): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructure): (JSC::StructureStubInfo::inlineAccessBaseStructure): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructureID): Deleted.
dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump):
dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::branchWeakStructure):
dfg/DFGPlan.cpp: (JSC::DFG::Plan::finalize):
dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined): (JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther): (JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch): (JSC::DFG::SpeculativeJIT::emitUntypedBranch): (JSC::DFG::SpeculativeJIT::compile):
ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
heap/AbstractSlotVisitor.h:
heap/AbstractSlotVisitorInlines.h:
heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::runEndPhase):
heap/Heap.h: (JSC::Heap::structureIDTable):
heap/IsoAlignedMemoryAllocator.cpp: (JSC::IsoAlignedMemoryAllocator::IsoAlignedMemoryAllocator): (JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator): (JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory): (JSC::IsoAlignedMemoryAllocator::freeAlignedMemory): (JSC::IsoAlignedMemoryAllocator::tryMallocBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::freeBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::commitBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::decommitBlock): Deleted.
heap/IsoAlignedMemoryAllocator.h:
heap/IsoMemoryAllocatorBase.cpp: Removed.
heap/IsoMemoryAllocatorBase.h: Removed.
heap/IsoSubspace.cpp: (JSC::IsoSubspace::IsoSubspace): (JSC::IsoSubspace::tryAllocateFromLowerTier):
heap/IsoSubspace.h:
heap/PreciseAllocation.cpp: (JSC::PreciseAllocation::createForLowerTier): (JSC::PreciseAllocation::tryCreateForLowerTier): Deleted.
heap/PreciseAllocation.h:
heap/SlotVisitor.cpp: (JSC::SlotVisitor::appendJSCellOrAuxiliary):
heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:
heap/StructureAlignedMemoryAllocator.cpp: Removed.
heap/StructureAlignedMemoryAllocator.h: Removed.
jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo): (JSC::AssemblyHelpers::emitLoadStructure): (JSC::AssemblyHelpers::emitLoadPrototype): (JSC::AssemblyHelpers::emitRandomThunk): (JSC::AssemblyHelpers::emitConvertValueToBoolean): (JSC::AssemblyHelpers::branchIfValue): (JSC::AssemblyHelpers::emitNonNullDecodeStructureID): Deleted.
jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::branchStructure): (JSC::AssemblyHelpers::nukeStructureAndStoreButterfly):
jit/GCAwareJITStubRoutine.cpp: (JSC::PolymorphicAccessJITStubRoutine::computeHash):
jit/JITInlineCacheGenerator.cpp: (JSC::generateGetByIdInlineAccess): (JSC::JITPutByIdGenerator::generateBaselineDataICFastPath): (JSC::JITInByIdGenerator::generateBaselineDataICFastPath):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_typeof_is_undefined): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_get_prototype_of):
jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_property_enumerator):
jit/JITStubRoutine.h:
llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::performLLIntGetByID):
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/BigIntPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/BooleanPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/CommonSlowPaths.cpp: (JSC::JSC_DEFINE_COMMON_SLOW_PATH):
runtime/DatePrototype.cpp: (JSC::formateDateInstance): (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/ErrorInstance.cpp: (JSC::ErrorInstance::sanitizedMessageString): (JSC::ErrorInstance::sanitizedNameString): (JSC::ErrorInstance::sanitizedToString):
runtime/ErrorPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/FunctionExecutable.cpp: (JSC::FunctionExecutable::visitChildrenImpl):
runtime/FunctionExecutable.h:
runtime/FunctionPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/FunctionRareData.cpp: (JSC::FunctionRareData::visitChildrenImpl):
runtime/FunctionRareData.h:
runtime/HasOwnPropertyCache.h:
runtime/InitializeThreading.cpp: (JSC::initialize):
runtime/JSCConfig.h:
runtime/JSCJSValue.cpp: (JSC::JSValue::dumpInContextAssumingStructure const): (JSC::JSValue::dumpForBacktrace const):
runtime/JSCell.cpp: (JSC::JSCell::toObjectSlow const):
runtime/JSCell.h: (JSC::JSCell::clearStructure):
runtime/JSCellInlines.h: (JSC::JSCell::structure const): (JSC::JSCell::setStructure):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildrenImpl):
runtime/JSGlobalObject.h:
runtime/JSObject.cpp: (JSC::JSObject::visitButterflyImpl): (JSC::JSObject::createInitialUndecided): (JSC::JSObject::createInitialInt32): (JSC::JSObject::createInitialDouble): (JSC::JSObject::createInitialContiguous): (JSC::JSObject::createArrayStorage): (JSC::JSObject::convertUndecidedToArrayStorage): (JSC::JSObject::convertInt32ToArrayStorage): (JSC::JSObject::convertDoubleToArrayStorage): (JSC::JSObject::convertContiguousToArrayStorage): (JSC::JSObject::putDirectCustomGetterSetterWithoutTransition): (JSC::JSObject::putDirectNonIndexAccessorWithoutTransition):
runtime/JSObject.h: (JSC::JSObject::nukeStructureAndSetButterfly): (JSC::JSObject::getPropertySlot):
runtime/JSObjectInlines.h: (JSC::JSObject::getPropertySlot): (JSC::JSObject::getNonIndexPropertySlot): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectInternal):
runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator): (JSC::JSPropertyNameEnumerator::visitChildrenImpl):
runtime/JSPropertyNameEnumerator.h:
runtime/NumberPrototype.cpp: (JSC::toThisNumber):
runtime/ObjectPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::objectPrototypeToString):
runtime/RegExpPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/StringPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::dump const): (JSC::Structure::canCachePropertyNameEnumerator const):
runtime/Structure.h: (JSC::Structure::id const):
runtime/StructureChain.cpp: (JSC::StructureChain::create): (JSC::StructureChain::visitChildrenImpl):
runtime/StructureID.h: Removed.
runtime/StructureIDBlob.h: (JSC::StructureIDBlob::StructureIDBlob):
runtime/StructureIDTable.cpp: Added. (JSC::StructureIDTable::StructureIDTable): (JSC::StructureIDTable::makeFreeListFromRange): (JSC::StructureIDTable::resize): (JSC::StructureIDTable::flushOldTables): (JSC::StructureIDTable::allocateID): (JSC::StructureIDTable::deallocateID):
runtime/StructureIDTable.h: Added. (JSC::nukedStructureIDBit): (JSC::nuke): (JSC::isNuked): (JSC::decontaminate): (JSC::StructureIDTable::base): (JSC::StructureIDTable::size const): (JSC::StructureIDTable::table const): (JSC::StructureIDTable::decode): (JSC::StructureIDTable::encode): (JSC::StructureIDTable::get): (JSC::StructureIDTable::tryGet): (JSC::StructureIDTable::validate): (JSC::StructureIDTable::deallocateID): (JSC::StructureIDTable::allocateID): (JSC::StructureIDTable::flushOldTables):
runtime/StructureRareData.cpp: (JSC::StructureRareData::StructureRareData):
runtime/StructureRareData.h:
runtime/StructureRareDataInlines.h: (JSC::StructureRareData::tryCachePropertyNameEnumeratorViaWatchpoint):
runtime/SymbolPrototype.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER): (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/TypeProfilerLog.cpp: (JSC::TypeProfilerLog::processLogEntries): (JSC::TypeProfilerLog::visit):
runtime/VM.h: (JSC::VM::getStructure): (JSC::VM::tryGetStructure):
runtime/WriteBarrier.h: (JSC::WriteBarrierStructureID::WriteBarrierStructureID): Deleted. (JSC::WriteBarrierStructureID::get const): Deleted. (JSC::WriteBarrierStructureID::operator* const): Deleted. (JSC::WriteBarrierStructureID::operator-> const): Deleted. (JSC::WriteBarrierStructureID::clear): Deleted. (JSC::WriteBarrierStructureID::operator bool const): Deleted. (JSC::WriteBarrierStructureID::operator! const): Deleted. (JSC::WriteBarrierStructureID::setWithoutWriteBarrier): Deleted. (JSC::WriteBarrierStructureID::unvalidatedGet const): Deleted. (JSC::WriteBarrierStructureID::value const): Deleted.
runtime/WriteBarrierInlines.h: (JSC::WriteBarrierStructureID::set): Deleted. (JSC::WriteBarrierStructureID::setMayBeNull): Deleted. (JSC::WriteBarrierStructureID::setEarlyValue): Deleted.
tools/HeapVerifier.cpp: (JSC::HeapVerifier::validateJSCell):
tools/Integrity.cpp:
tools/Integrity.h:
tools/IntegrityInlines.h: (JSC::Integrity::auditStructureID):
tools/JSDollarVM.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSDollarVM::finishCreation): (JSC::JSDollarVM::visitChildrenImpl):
tools/JSDollarVM.h:
wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::jsCallEntrypointSlow):
wasm/js/WebAssemblyGlobalPrototype.cpp: (JSC::getGlobal):

Source/WTF:

wtf/OSAllocator.h:
wtf/posix/OSAllocatorPOSIX.cpp: (WTF::OSAllocator::reserveUncommittedAligned): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:19 PM Changeset in webkit [287164] by achristensen@apple.com

2 edits in trunk/Source/WebKitLegacy/mac

Fix iOS debug build
https://bugs.webkit.org/show_bug.cgi?id=234365

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

4:16 PM Changeset in webkit [287163] by commit-queue@webkit.org

25 edits in trunk/Source

Remove more NPAPI plugin code
https://bugs.webkit.org/show_bug.cgi?id=234379

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-16
Reviewed by Anders Carlsson.

Source/WebCore:

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData): Deleted.

html/HTMLObjectElement.h:
page/Page.cpp:

(WebCore::Page::setSessionID):

plugins/PluginViewBase.h:

(WebCore::PluginViewBase::storageBlockingStateChanged):
(WebCore::PluginViewBase::privateBrowsingStateChanged): Deleted.
(WebCore::PluginViewBase::getFormValue): Deleted.
(WebCore::PluginViewBase::shouldNotAddLayer const): Deleted.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

Source/WebKit:

UIProcess/Cocoa/WebViewImpl.h:

(WebKit::WebViewImpl::pluginComplexTextInputIdentifier const): Deleted.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::doneWithKeyEvent):
(WebKit::WebViewImpl::interpretKeyEvent):
(WebKit::WebViewImpl::inputContext):
(WebKit::WebViewImpl::performKeyEquivalent):
(WebKit::WebViewImpl::keyDown):
(WebKit::WebViewImpl::disableComplexTextInputIfNecessary): Deleted.
(WebKit::WebViewImpl::handlePluginComplexTextInputKeyDown): Deleted.
(WebKit::WebViewImpl::tryHandlePluginComplexTextInputKeyDown): Deleted.
(WebKit::WebViewImpl::pluginFocusOrWindowFocusChanged): Deleted.
(WebKit::WebViewImpl::tryPostProcessPluginComplexTextInputKeyDown): Deleted.

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged): Deleted.

UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::sendComplexTextInputToPlugin): Deleted.
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged): Deleted.

WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::canCreateTransientPaintingSnapshot const): Deleted.

WebProcess/Plugins/PluginController.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::destroyPluginAndReset):
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot const):
(WebKit::PluginView::sendComplexTextInput): Deleted.
(WebKit::PluginView::privateBrowsingStateChanged): Deleted.
(WebKit::PluginView::getFormValue): Deleted.
(WebKit::PluginView::shouldNotAddLayer const): Deleted.
(WebKit::PluginView::pluginFocusOrWindowFocusChanged): Deleted.

WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::accessibilityPosition const):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::sendComplexTextInputToPlugin): Deleted.

4:02 PM Changeset in webkit [287162] by clopez@igalia.com

2 edits in trunk/Tools

[GTK][WPE] Don't ignore stderr when calling flatpak in update-webkitgtk-libs
https://bugs.webkit.org/show_bug.cgi?id=234407

Reviewed by Michael Catanzaro.

Print stderr when calling flatpak, is useful to debug problems when it fails.

flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

3:45 PM Changeset in webkit [287161] by Alan Coon

1 copy in tags/Safari-612.4.5

Tag Safari-612.4.5.

3:30 PM Changeset in webkit [287160] by sbarati@apple.com

23 edits in trunk/Source/JavaScriptCore

Use arm64's fmax/fmin instructions in Wasm
https://bugs.webkit.org/show_bug.cgi?id=234367

Reviewed by Keith Miller.

This patch adds support in B3 for FMax and FMin. We use this for Wasm's f32/64
min/max operations. On arm64, we select the arm64 fmin/fmax instructions
for these B3 opcodes. On x86, we lower these to control flow to calculate the
result inside of lower macros.

This speeds up Wasm programs that make heavy usage of min/max.

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::floatMax):
(JSC::MacroAssemblerARM64::floatMin):
(JSC::MacroAssemblerARM64::doubleMax):
(JSC::MacroAssemblerARM64::doubleMin):

b3/B3Common.h:

(JSC::B3::fMax):
(JSC::B3::fMin):

b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::fMinConstant const):
(JSC::B3::ConstDoubleValue::fMaxConstant const):

b3/B3ConstDoubleValue.h:
b3/B3ConstFloatValue.cpp:

(JSC::B3::ConstFloatValue::fMinConstant const):
(JSC::B3::ConstFloatValue::fMaxConstant const):

b3/B3ConstFloatValue.h:
b3/B3LowerMacros.cpp:
b3/B3LowerToAir.cpp:
b3/B3Opcode.cpp:

(WTF::printInternal):

b3/B3Opcode.h:
b3/B3ReduceStrength.cpp:
b3/B3Validate.cpp:
b3/B3Value.cpp:

(JSC::B3::Value::fMinConstant const):
(JSC::B3::Value::fMaxConstant const):
(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::typeFor):

b3/B3Value.h:
b3/B3ValueInlines.h:
b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize const):

b3/air/AirOpcode.opcodes:
b3/testb3.h:
b3/testb3_1.cpp:

(run):

b3/testb3_7.cpp:

(testFMaxMin):
(testFloatMaxMin):
(testDoubleMaxMin):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::addFloatingPointMinOrMax):
(JSC::Wasm::AirIRGenerator::addOp<OpType::F32Min>):

wasm/wasm.json:

2:37 PM Changeset in webkit [287159] by Chris Dumez

29 edits in trunk/Source

Move WebIDBServers from NetworkProcess to NetworkSession class
https://bugs.webkit.org/show_bug.cgi?id=234366

Reviewed by Darin Adler.

Move WebIDBServers from NetworkProcess to NetworkSession class, since they are per session.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFilesForIndexedDB):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::suspendIDBServers):
(WebKit::NetworkProcess::resume):
(WebKit::CompletionHandler<void):
(WebKit::NetworkProcess::prefetchDNS): Deleted.
(WebKit::NetworkProcess::cacheStorageRootPath): Deleted.
(WebKit::NetworkProcess::setCacheStorageParameters): Deleted.
(WebKit::NetworkProcess::registerURLSchemeAsSecure const): Deleted.
(WebKit::NetworkProcess::registerURLSchemeAsBypassingContentSecurityPolicy const): Deleted.
(WebKit::NetworkProcess::registerURLSchemeAsLocal const): Deleted.
(WebKit::NetworkProcess::registerURLSchemeAsNoAccess const): Deleted.
(WebKit::NetworkProcess::createWebIDBServer): Deleted.
(WebKit::NetworkProcess::webIDBServer): Deleted.
(WebKit::NetworkProcess::addIndexedDatabaseSession): Deleted.
(WebKit::NetworkProcess::setSessionStorageQuotaManagerIDBRootPath): Deleted.
(WebKit::NetworkProcess::syncLocalStorage): Deleted.
(WebKit::NetworkProcess::resetQuota): Deleted.
(WebKit::NetworkProcess::clearStorage): Deleted.
(WebKit::NetworkProcess::renameOriginInWebsiteData): Deleted.
(WebKit::NetworkProcess::getPendingPushMessages): Deleted.
(WebKit::NetworkProcess::processPushMessage): Deleted.
(WebKit::NetworkProcess::deletePushAndNotificationRegistration): Deleted.
(WebKit::NetworkProcess::getOriginsWithPushAndNotificationPermissions): Deleted.
(WebKit::NetworkProcess::requestStorageSpace): Deleted.
(WebKit::NetworkProcess::storageQuotaManager): Deleted.
(WebKit::NetworkProcess::initializeProcess): Deleted.
(WebKit::NetworkProcess::initializeProcessName): Deleted.
(WebKit::NetworkProcess::initializeSandbox): Deleted.
(WebKit::NetworkProcess::flushCookies): Deleted.
(WebKit::NetworkProcess::platformFlushCookies): Deleted.
(WebKit::NetworkProcess::storePrivateClickMeasurement): Deleted.
(WebKit::NetworkProcess::dumpPrivateClickMeasurement): Deleted.
(WebKit::NetworkProcess::clearPrivateClickMeasurement): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementOverrideTimerForTesting): Deleted.
(WebKit::NetworkProcess::simulateResourceLoadStatisticsSessionRestart): Deleted.
(WebKit::NetworkProcess::markAttributedPrivateClickMeasurementsAsExpiredForTesting): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementEphemeralMeasurementForTesting): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementTokenPublicKeyURLForTesting): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementTokenSignatureURLForTesting): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementAttributionReportURLsForTesting): Deleted.
(WebKit::NetworkProcess::markPrivateClickMeasurementsAsExpiredForTesting): Deleted.
(WebKit::NetworkProcess::setPCMFraudPreventionValuesForTesting): Deleted.
(WebKit::NetworkProcess::setPrivateClickMeasurementAppBundleIDForTesting): Deleted.
(WebKit::NetworkProcess::addKeptAliveLoad): Deleted.
(WebKit::NetworkProcess::removeKeptAliveLoad): Deleted.
(WebKit::NetworkProcess::connectionToWebProcessClosed): Deleted.
(WebKit::NetworkProcess::webProcessConnection const): Deleted.
(WebKit::NetworkProcess::setServiceWorkerFetchTimeoutForTesting): Deleted.
(WebKit::NetworkProcess::resetServiceWorkerFetchTimeoutForTesting): Deleted.
(WebKit::NetworkProcess::randomClosedPortDelay): Deleted.
(WebKit::NetworkProcess::hasAppBoundSession const): Deleted.
(WebKit::NetworkProcess::clearAppBoundSession): Deleted.
(WebKit::NetworkProcess::broadcastConsoleMessage): Deleted.
(WebKit::NetworkProcess::updateBundleIdentifier): Deleted.
(WebKit::NetworkProcess::clearBundleIdentifier): Deleted.
(WebKit::NetworkProcess::shouldDisableCORSForRequestTo const): Deleted.
(WebKit::NetworkProcess::setCORSDisablingPatterns): Deleted.
(WebKit::NetworkProcess::appPrivacyReportTestingData): Deleted.
(WebKit::NetworkProcess::clearAppPrivacyReportTestingData): Deleted.
(WebKit::NetworkProcess::rtcDataChannelProxy): Deleted.
(WebKit::NetworkProcess::addWebPageNetworkParameters): Deleted.
(WebKit::NetworkProcess::removeWebPageNetworkParameters): Deleted.
(WebKit::NetworkProcess::countNonDefaultSessionSets): Deleted.

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::shouldSuspendIDBServers const):

NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::invalidateAndCancel):
(WebKit::NetworkSession::ensureWebIDBServer):
(WebKit::NetworkSession::closeIDBServer):
(WebKit::NetworkSession::addIndexedDatabaseSession):

NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::webIDBServer):
(WebKit::NetworkSession::hasIDBDatabasePath const):

2:18 PM Changeset in webkit [287158] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Add an experimental VideoTrackConfiguration class and accessor on VideoTrack
https://bugs.webkit.org/show_bug.cgi?id=230841
<rdar://problem/83837876>

Reviewed by Eric Carlson.

Follow up patch to address post-review comments.

Darin pointed out that CFStringCompare() is likely more expensive than
CFEqual() as the former determines order as well as equality, and a
safeCFEqual() already exists. And while safeCFEqual() has different
behavior than the safeCFStringEquals() lambda when passed two null values,
in every case where safeCFStringEquals() is used, the first parameter has
already been nil-checked. So safeCFStringEquals() is unnecessary and
safeCFEqual() should be used instead.

platform/graphics/avfoundation/FormatDescriptionUtilities.cpp:

(WebCore::colorSpaceFromFormatDescription):

2:02 PM Changeset in webkit [287157] by youenn@apple.com

9 edits
2 adds in trunk/Source/WebCore

Allow AudioSampleDataSource to increase/decrease buffered data progressively
https://bugs.webkit.org/show_bug.cgi?id=233422

Reviewed by Eric Carlson.

AudioSampleDataSource does the link between push audio sources and pull audio sinks.
As such, it needs to do buffering. If buffering is too small, data may be missing and audio glitches will be heard.
If buffering is too large, latency will be added which might be undesirable, especially if audio is being played with video.
We generally want buffered audio to stay within a certain range.

To make this happen, when buffering is too high, we convert the data with a slightly lower sample rate to push less samples, until we are back to normal buffering.
Conversely, when buffering is too low, we convert the data with a slightly higher sample rate to push more samples, until we are back to normal buffering.
We do this with 3 converters that we select based on amount of buffered data.
This behavior is encapsulated in AudioSampleDataConverter.

We simplify AudioSampleDataSource implementation by always recomputing the sample offset when there is not enough data.
In that case, we wait for 50ms of buffered data, which is the average buffer we expect, to restart pulling data.
All values owned by AudioSampleDataSource (m_expectedNextPushedSampleTimeValue, m_converterInputOffset, m_converterInputOffset, m_outputSampleOffset, m_lastBufferedAmount)
are all in the outgoing timeline/sampleRate.

This adaptation is only enabled when AudioSampleDataSource::pullSamples is called.
For pullAvailableSamplesAsChunks and pullAvailableSampleChunk, the puller is supposed to be in sync with the pusher.
For that reason, we make sure to always write the expected number of audio frames when pullSamples is called, even if converter fails.

We fix a potential busy loop in AudioSampleDataSource::pullAvailableSamplesAsChunks in case endFrame is lower than startFrame, which is computed from timeStamp input parameter.

Update MockAudioSharedUnit to be closer to a real source by increasing the queue priority and schedule rendering tasks from the queue instead of relying on
a main thread timer which can have hiccups.

Manually tested.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/audio/cocoa/AudioSampleDataConverter.h: Added.
platform/audio/cocoa/AudioSampleDataConverter.mm: Added.
platform/audio/cocoa/AudioSampleDataSource.h:
platform/audio/cocoa/AudioSampleDataSource.mm:
platform/mediastream/mac/MockAudioSharedUnit.h:
platform/mediastream/mac/MockAudioSharedUnit.mm:

2:00 PM Changeset in webkit [287156] by sihui_liu@apple.com

21 edits
1 copy in trunk/Source

REGRESSION (r286601): storage/filesystemaccess/sync-access-handle-read-write-worker.html and file-system-access/sandboxed_FileSystemSyncAccessHandle-truncate.https.tentative.worker.html are consistently failing
https://bugs.webkit.org/show_bug.cgi?id=234271
<rdar://problem/86434111>

Reviewed by Youenn Fablet.

Source/WebCore:

When context stops, FileSystemHandle sets its state to closed. A closed FileSystemHandle will return early on
operations including closing sync access handle (asking backend to close handle and releasing lock). If backend
thinks existing access handle is not closed, it will prevent new access handle from being created, and this
leads to the test failure.

The problem is that backend isn't notified about the close of a handle: we only set the close state in
FileSystemHandle. To fix the issue, let's make sure FileSystemStorageConnection::closeHandle is called when
context stops and when FileSystemHandle is detroyed.

Headers.cmake:
Modules/filesystemaccess/FileSystemDirectoryHandle.cpp:

(WebCore::FileSystemDirectoryHandle::getFileHandle):
(WebCore::FileSystemDirectoryHandle::getDirectoryHandle):
(WebCore::FileSystemDirectoryHandle::getHandle):

Modules/filesystemaccess/FileSystemFileHandle.cpp:

(WebCore::FileSystemFileHandle::createSyncAccessHandle):
(WebCore::FileSystemFileHandle::closeSyncAccessHandle):
(WebCore::FileSystemFileHandle::close): Deleted.

Modules/filesystemaccess/FileSystemFileHandle.h:
Modules/filesystemaccess/FileSystemHandle.cpp:

(WebCore::FileSystemHandle::~FileSystemHandle):
(WebCore::FileSystemHandle::close):
(WebCore::FileSystemHandle::stop):

Modules/filesystemaccess/FileSystemHandle.h:
Modules/filesystemaccess/FileSystemHandleCloseScope.h: Added.

(WebCore::FileSystemHandleCloseScope::create):
(WebCore::FileSystemHandleCloseScope::~FileSystemHandleCloseScope):
(WebCore::FileSystemHandleCloseScope::release):
(WebCore::FileSystemHandleCloseScope::FileSystemHandleCloseScope):

Modules/filesystemaccess/FileSystemStorageConnection.h:
Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp:

(WebCore::FileSystemSyncAccessHandle::closeBackend):

Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp:

(WebCore::WorkerFileSystemStorageConnection::getFileHandle):
(WebCore::WorkerFileSystemStorageConnection::getDirectoryHandle):
(WebCore::WorkerFileSystemStorageConnection::didGetHandle):
(WebCore::WorkerFileSystemStorageConnection::closeSyncAccessHandle):
(WebCore::WorkerFileSystemStorageConnection::getHandle):
(WebCore::WorkerFileSystemStorageConnection::close): Deleted.

Modules/filesystemaccess/WorkerFileSystemStorageConnection.h:
WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

NetworkProcess/storage/FileSystemStorageHandle.cpp:

(WebKit::FileSystemStorageHandle::close):
(WebKit::FileSystemStorageHandle::closeSyncAccessHandle):

NetworkProcess/storage/FileSystemStorageHandle.h:
NetworkProcess/storage/FileSystemStorageManager.cpp:

(WebKit::FileSystemStorageManager::closeHandle):

NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::NetworkStorageManager::closeSyncAccessHandle):
(WebKit::NetworkStorageManager::closeAccessHandle): Deleted.

NetworkProcess/storage/NetworkStorageManager.h:
NetworkProcess/storage/NetworkStorageManager.messages.in:
WebProcess/WebCoreSupport/WebFileSystemStorageConnection.cpp:

(WebKit::WebFileSystemStorageConnection::getFileHandle):
(WebKit::WebFileSystemStorageConnection::getDirectoryHandle):
(WebKit::WebFileSystemStorageConnection::closeSyncAccessHandle):
(WebKit::WebFileSystemStorageConnection::getHandle):
(WebKit::WebFileSystemStorageConnection::close): Deleted.

WebProcess/WebCoreSupport/WebFileSystemStorageConnection.h:

1:20 PM Changeset in webkit [287155] by Alan Coon

13 edits
2 adds in branches/safari-612-branch/Source/WebCore

Cherry-pick r287079. rdar://problem/85892959

This reverts r287150.

1:05 PM Changeset in webkit [287154] by caitp@igalia.com

2 edits in trunk/Source/JavaScriptCore

[JSC] only emit pointer validation for ARM64E
https://bugs.webkit.org/show_bug.cgi?id=234402

Reviewed by Yusuke Suzuki and Mark Lam.

JIT thunks no longer emit push <reg>; pop <reg>; on
non-ARM64E arches with the emitPointerValidation macro.

jit/ThunkGenerators.cpp:

(JSC::emitPointerValidation):

1:02 PM Changeset in webkit [287153] by Adrian Perez de Castro

9 edits in trunk/Source

Non-unified build fixes, late-ish December 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=234392

Unreviewed non-unified build fixes.

Source/WebCore:

No new tests needed.

Modules/notifications/NotificationData.h: Add missing wtf/text/WTFString.h and <optional>

header inclusions.

style/HasSelectorFilter.cpp: Add missing StyleRule.h header inclusion.
style/HasSelectorFilter.h: Add missing forward declaration for WebCore::Element.
workers/WorkerConsoleClient.h: Add missing JSC:: namespace prefix to usage of

JSC::MessageType.

Source/WebKit:

NetworkProcess/NetworkDataTask.cpp: Add missing NetworkProcess.h header inclusion.
NetworkProcess/NetworkSession.cpp: Add missing WebCore/SWServer.h heeader inclusion.
UIProcess/Notifications/WebNotificationManagerProxy.cpp: Add missing

WebCore/NotificationData.h header inclusion.

12:47 PM Changeset in webkit [287152] by Russell Epstein

1 copy in tags/Safari-613.1.11.8

Tag Safari-613.1.11.8.

12:41 PM Changeset in webkit [287151] by Alan Coon

3 edits in branches/safari-612-branch/Source/WebCore

Apply patch. rdar://problem/86505382

12:40 PM Changeset in webkit [287150] by Alan Coon

13 edits
2 deletes in branches/safari-612-branch/Source/WebCore

Revert r287079. rdar://problem/85892959

This reverts r287117.

12:29 PM Changeset in webkit [287149] by Russell Epstein

2 edits in branches/safari-613.1.12-branch/Source/WebKit

Cherry-pick r287146. rdar://problem/86550488

[watchOS] Adjust sandbox message filter
https://bugs.webkit.org/show_bug.cgi?id=234385
<rdar://86550488>

Reviewed by Brent Fulgham.

Add required items to sandbox message filter in the WebContent process on watchOS.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:21 PM Changeset in webkit [287148] by Russell Epstein

9 edits in branches/safari-613.1.11-branch/Source

Versioning.

WebKit-7613.1.11.8

11:23 AM Changeset in webkit [287147] by Brent Fulgham

3 edits in trunk/Source/WebCore

Rename forEachFrameFromMainFrame to forEachFrame
https://bugs.webkit.org/show_bug.cgi?id=234396
<rdar://problem/86581926>

Reviewed by Geoffrey Garen.

Follow-up to r287110: Switch method naming to match 'forEachDocument'.

page/Page.cpp:

(WebCore::Page::~Page):
(WebCore::Page::notifyToInjectUserScripts):
(WebCore::Page::forEachFrame):
(WebCore::Page::forEachFrameFromMainFrame): Deleted.

page/Page.h:

10:57 AM Changeset in webkit [287146] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[watchOS] Adjust sandbox message filter
https://bugs.webkit.org/show_bug.cgi?id=234385
<rdar://86550488>

Reviewed by Brent Fulgham.

Add required items to sandbox message filter in the WebContent process on watchOS.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

10:35 AM Changeset in webkit [287145] by Russell Epstein

22 edits
7 adds in branches/safari-613.1.12-branch/Source

Cherry-pick r287137. rdar://problem/86476583

Source/JavaScriptCore:
Create symlinks pointing to alternate root framework locations
https://bugs.webkit.org/show_bug.cgi?id=234374

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:
Scripts/create-symlink-to-altroot.sh: Added.

Source/ThirdParty/ANGLE:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

ANGLE.xcodeproj/project.pbxproj:
Configurations/ANGLE-dynamic.xcconfig:
scripts/create-symlink-to-altroot.sh: Added.

Source/ThirdParty/libwebrtc:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/libwebrtc.xcconfig:

Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Covered by existing tests.

Configurations/WebCore.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebCore.xcodeproj/project.pbxproj:

Source/WebGPU:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/WebGPU.xcconfig:
Scripts: Added.
Scripts/create-symlink-to-altroot.sh: Added.
WebGPU.xcodeproj/project.pbxproj:

Source/WebInspectorUI:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/WebInspectorUIFramework.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebInspectorUI.xcodeproj/project.pbxproj:

Source/WebKit:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/BaseXPCService.xcconfig:
Configurations/adattributiond.xcconfig:
Configurations/webpushd.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:14 AM Changeset in webkit [287144] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GPUP] Create WebGL context with task id token
https://bugs.webkit.org/show_bug.cgi?id=234138

Patch by John Cunningham <johncunningham@apple.com> on 2021-12-16
Reviewed by Kimmo Kinnunen.

No new tests.

Use EGL_ANGLE_metal_create_context_ownership_identity to create
a WebGL context when GPUP and WebGL in GPUP is enabled.

platform/graphics/angle/GraphicsContextGLANGLE.h:
platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::GraphicsContextGLCocoa):
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):

9:51 AM Changeset in webkit [287143] by commit-queue@webkit.org

4 edits in trunk/Source/ThirdParty/ANGLE

Add support to attribute ownership of ANGLE Metal's resources
https://bugs.webkit.org/show_bug.cgi?id=233941

Patch by John Cunningham <johncunningham@apple.com> on 2021-12-16
Reviewed by Kimmo Kinnunen.

Add SPI to mtl_resource_spi.h to attribute memory to another task.

Configurations/ANGLE-dynamic.xcconfig:
Configurations/ANGLE-static.xcconfig:
src/libANGLE/renderer/metal/mtl_resource_spi.h:

(rx::mtl::setOwnerWithIdentity):

9:36 AM Changeset in webkit [287142] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Simple RTL content may need visual reordering
https://bugs.webkit.org/show_bug.cgi?id=234380

Reviewed by Antti Koivisto.

It turns out that certain unicode categories (e.g. punctuation) could require reordering even when
the content is "simple" (8bit).

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

9:17 AM Changeset in webkit [287141] by achristensen@apple.com

8 edits in trunk

Unreviewed, reverting r287056.
<rdar://86519800>

Caused performance regression...again

Reverted changeset:

"Remove properties set by NSURLProtocol on NSURLRequest before
serializing"
https://bugs.webkit.org/show_bug.cgi?id=232332
https://commits.webkit.org/r287056

9:09 AM Changeset in webkit [287140] by graouts@webkit.org

2 edits in trunk/Source/WebCore

Remove the declaration for an unimplemented AudioBufferSourceNode::create(BaseAudioContext&, float) method
https://bugs.webkit.org/show_bug.cgi?id=234388

Reviewed by Anders Carlsson.

Modules/webaudio/AudioBufferSourceNode.h:

8:59 AM Changeset in webkit [287139] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Clear AXObjectCache::m_notificationsToPost after moving in notificationPostTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=234355
<rdar://problem/86532703>

Reviewed by Chris Fleizach.

Covered by existing tests.

This memeber variable must be clear after moving its resources to a
local variable, otherwise this may cause undefined behavior.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):
(WebCore::AXObjectCache::passwordNotificationPostTimerFired):
Same problem here with m_passwordNotificationsToPost.

8:54 AM Changeset in webkit [287138] by Darin Adler

76 edits in trunk

Many call sites use makeNeverDestroyed, but could instead take advantage of the NeverDestroyed deduction guide
https://bugs.webkit.org/show_bug.cgi?id=234350

Reviewed by Sam Weinig.

Source/WebCore:

Modules/encryptedmedia/legacy/LegacyCDM.cpp:

(WebCore::installedCDMFactories): Use NeverDestroyed directly instead of via makeNeverDestroyed.

Modules/mediasession/MediaSession.cpp:

(WebCore::platformCommandForMediaSessionAction): Use SortedArrayMap, obviating the need for
any use of NeverDestroyed.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const): Use Span instead of
Vector, allowing us to use constexpr arrays rather than allocating memory for a Vector.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]): Use deduction.

dom/make_names.pl:

(printFactoryCppFile): Ditto.
(printWrapperFactoryCppFile): Ditto.

editing/EditingStyle.cpp:

(WebCore::htmlElementEquivalents): Return a Span instead of a Vector&,
allowing us to use const arrays rather than allocating memory for a Vector.
(WebCore::htmlAttributeEquivalents): Ditto.

editing/FormatBlockCommand.cpp:

(WebCore::isElementForFormatBlock): Use deduction.

editing/RemoveFormatCommand.cpp:

(WebCore::isElementForRemoveFormatCommand): Ditto.

editing/ReplaceSelectionCommand.cpp:

(WebCore::isProhibitedParagraphChild): Use deduction, also change the tags array
to be a constexpr array so we don't have to use read/write memory for it.

editing/cocoa/HTMLConverter.mm:

(WebDefaultFont): Use deduction.
(defaultParagraphStyle): Ditto.

html/Autofill.cpp:

(WebCore::fieldNameMap): Ditto.

html/HTMLDocument.cpp:

(WebCore::HTMLDocument::isCaseSensitiveAttribute): Use deduction, also change
the names array to be a constexpr array so we don't have to use read/write memory for it.

html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForEventHandlerAttribute): Use std::array deduction
so we don't have to write out the LazyNeverDestroyed type here.

html/HTMLObjectElement.cpp:

(WebCore::preventsParentObjectFromExposure): Use deduction.

html/InputType.cpp:

(WebCore::InputType::create): Ditto.

loader/ContentFilter.cpp:

(WebCore::blockedPageURL): Ditto.

page/DebugPageOverlays.cpp:

(WebCore::touchEventRegionColors): Ditto.

page/PerformanceUserTiming.cpp:

(WebCore::restrictedMarkNamesToNavigationTimingFunctionMap): Ditto.

platform/LegacySchemeRegistry.cpp:

(WebCore::add): Use Span instead of Vector, allowing us to use constexpr arrays
rather thna allocating memory for a Vector.
(WebCore::makeNeverDestroyedSchemeSet): Ditto.
(WebCore::allBuiltinSchemes): Ditto. Also use deduction.
(WebCore::builtinLocalURLSchemes): Ditto.
(WebCore::builtinSecureSchemes): Ditto.
(WebCore::builtinSchemesWithUniqueOrigins): Ditto.
(WebCore::builtinEmptyDocumentSchemes): Ditto.
(WebCore::builtinCanDisplayOnlyIfCanRequestSchemes): Ditto.
(WebCore::builtinCORSEnabledSchemes): Ditto.

platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::supportedNonImageMIMETypes): Use deduction.
(WebCore::MIMETypeRegistry::supportedMediaMIMETypes): Ditto.

platform/cocoa/AGXCompilerService.cpp:

(WebCore::agxCompilerServices): Use Span instead of a Vector&, allowing us
to use a constexpr array rather than allocating memory for a vector.
(WebCore::agxCompilerClasses): Ditto.

platform/cocoa/AGXCompilerService.h: Ditto.

platform/cocoa/MIMETypeRegistryCocoa.mm:

(WebCore::extensionsForMIMETypeMap): Use deduction.

platform/cocoa/RemoteCommandListenerCocoa.mm:

(WebCore::mediaRemoteCommandForPlatformCommand): Use SortedArrayMap, ovbviating the
need for any use of NeverDestroyed.

platform/cocoa/VideoFullscreenModelVideoElement.h:
platform/cocoa/VideoFullscreenModelVideoElement.mm:

(WebCore::VideoFullscreenModelVideoElement::observedEventNames): Return a Span
instead of a Vector&, allowing us to use an array rather than allocating
memory for a Vector.

platform/encryptedmedia/CDMProxy.cpp:

(WebCore::CDMProxyFactory::registeredFactories): Use deduction.

platform/graphics/FontCascade.cpp:

(WebCore::useBackslashAsYenSignForFamily): Use deduction.
(WebCore::FontCascade::hasValidAverageCharWidth const): Ditto.

platform/graphics/ImageDecoder.cpp:

(WebCore::installedFactories): Use NeverDestroyed directly, not makeNeverDestroyed.

platform/graphics/IntSize.h: Added constexpr so many operations can be done

at compile time as needed; mainly this was so we can make a constexpr array of
these sizes. This same enhancement can be applied to other types, but just did
it here for now. Also fixed return values for min/maxDimension that were accidentally
returning float, hurting performance because of the round trip int to float,
also not cleanly round tripping very large and small values.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::staticMIMETypeList): Use deduction.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::checkPlayability): Ditto.

platform/graphics/cg/ImageSourceCGWin.cpp:

(WebCore::preferredExtensionForImageType): Ditto.

platform/graphics/cg/UTIRegistry.cpp:

(WebCore::defaultSupportedImageTypes): Ditto.

platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::matchSystemFontUse): Ditto.

platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::webmMIMETypes): Ditto.
(WebCore::SourceBufferParserWebM::supportedVideoCodecs): Ditto.
(WebCore::SourceBufferParserWebM::supportedAudioCodecs): Ditto.

platform/ios/DragImageIOS.mm:

(WebCore::createDragImageForLink): Ditto.

platform/mac/WebNSAttributedStringExtras.mm:

(WebCore::attributedStringByStrippingAttachmentCharacters): Ditto.

platform/mediacapabilities/MediaEngineConfigurationFactory.cpp:

(WebCore::factories): Ditto.

platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::standardVideoSizes): Return a Span
instead of a Vector& so we can use a constexpr array and don't need to
allocate memory or use read/write storage.

platform/mediastream/RealtimeVideoCaptureSource.h: Ditto. Also make

this a static member function.

platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::devices): Use deduction.
(WebCore::deviceMap): Ditto.
(WebCore::MockRealtimeMediaSourceCenter::microphoneDevices): Ditto.
(WebCore::MockRealtimeMediaSourceCenter::speakerDevices): Ditto.
(WebCore::MockRealtimeMediaSourceCenter::videoDevices): Ditto.
(WebCore::MockRealtimeMediaSourceCenter::displayDevices): Ditto.

platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::mimeTypeCache): Ditto.

platform/network/mac/ResourceHandleMac.mm:

(WebCore::operationQueueForAsyncClients): Ditto.

platform/text/mac/TextBoundaries.mm:

(WebCore::tokenizerForString): Ditto.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::cachedSystemFontDescription const): Use
NeverDestroyed directly instead of makeNeverDestroyed.

rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::cachedSystemFontDescription const): Ditto.

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::isSupportedAttribute): Use deduction.

svg/SVGElement.cpp:

(WebCore::createAttributeNameToCSSPropertyIDMap): Use a constexpr array
instead of a const one that has to be initialized at runtime.
(WebCore::SVGElement::animatableAttributeForName): Ditto, also use deduction.
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName): Use deduction.

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::isSupportedAttribute): Use deduction.

xml/XPathFunctions.cpp:

(WebCore::XPath::Function::create): Ditto.

xml/XPathParser.cpp:

(WebCore::XPath::parseAxisName): Ditto.

Source/WebKit:

NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::expectedTableAndIndexQueries):
Use deduction.

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::expectedTableAndIndexQueries): Ditto.

Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::getAppBoundDomainsTesting): Ditto.

Shared/Cocoa/SandboxExtensionCocoa.mm:

(WebKit::createHandlesForResources): Make this more generic so it works with
other kinds of collections, not just Vector. Also right-size the Vector this
returns rather than letting it grow organically.
(WebKit::SandboxExtension::createReadOnlyHandlesForFiles): Ditto.
(WebKit::SandboxExtension::createHandleForReadWriteDirectory): Ditto.
(WebKit::SandboxExtension::createHandlesForMachLookup): Ditto. Also update this
function to take a Span or an initializer_list instead of a Vector.
(WebKit::SandboxExtension::createHandlesForIOKitClassExtensions): Ditto.
(WebKit::SandboxExtension::consumePermanently): Ditto.

Shared/SandboxExtension.h: Updated for the above. Also corrected some unusual

use of #if to share a single declaration of some functions for both enabled
and disabled SANDBOX_EXTENSIONS.

UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::nonBrowserServices): Use deduction.

UIProcess/WebPageProxy.cpp: Remove unused MERGE_WHEEL_EVENTS.

(WebKit::attachmentElementServices): Return a Span, allowing us to use a
constexpr obviating the need for memory allocation or read/write memory,
(WebKit::gpuIOKitClasses): Ditto.
(WebKit::gpuMachServices): Ditto.
(WebKit::mediaRelatedMachServices): Ditto.
(WebKit::mediaRelatedIOKitClasses): Ditto.

UIProcess/ios/TextCheckerIOS.mm:

(WebKit::mutableState): Use deduction.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView supportedPasteboardTypesForCurrentSelection]): Ditto.

UIProcess/mac/TextCheckerMac.mm:

(WebKit::mutableState): Ditto.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::temporaryPDFDirectoryPath): Ditto.

Source/WebKitLegacy/mac:

Misc/WebNSPasteboardExtras.mm:

(writableTypesForImageWithoutArchive): Use deduction.
(writableTypesForImageWithArchive):

Misc/WebNSURLExtras.mm:

(-[NSString _webkit_rangeOfURLScheme]): Ditto.

WebView/WebDataSource.mm:

(+[WebDataSource _repTypesAllowImageTypeOmission:]): Ditto.

WebView/WebFrameView.mm:

(+[WebFrameView _viewTypesAllowImageTypeOmission:]): Ditto.

Source/WTF:

wtf/NeverDestroyed.h:

(WTF::makeNeverDestroyed): Deleted.

wtf/text/cf/StringImplCF.cpp:

(WTF::StringWrapperCFAllocator::allocator): Use deduction guide.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(fontAllowList): Use deduction.

TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:

(TestWebKitAPI::TEST): Remove tests of makeNeverDestroyed.
(TestWebKitAPI::list): Use deduction.

8:48 AM Changeset in webkit [287137] by msaboff@apple.com

22 edits
7 adds in trunk/Source

Source/JavaScriptCore:
Create symlinks pointing to alternate root framework locations
https://bugs.webkit.org/show_bug.cgi?id=234374

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:
Scripts/create-symlink-to-altroot.sh: Added.

Source/ThirdParty/ANGLE:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

ANGLE.xcodeproj/project.pbxproj:
Configurations/ANGLE-dynamic.xcconfig:
scripts/create-symlink-to-altroot.sh: Added.

Source/ThirdParty/libwebrtc:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/libwebrtc.xcconfig:

Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Covered by existing tests.

Configurations/WebCore.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebCore.xcodeproj/project.pbxproj:

Source/WebGPU:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/WebGPU.xcconfig:
Scripts: Added.
Scripts/create-symlink-to-altroot.sh: Added.
WebGPU.xcodeproj/project.pbxproj:

Source/WebInspectorUI:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/WebInspectorUIFramework.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebInspectorUI.xcodeproj/project.pbxproj:

Source/WebKit:
https://bugs.webkit.org/show_bug.cgi?id=234173
Update Install Paths for build system changes

Reviewed by Filip Pizlo.

Added build variables and build step to create symlinks pointing to the alternate
build locations from the current framework install location.

Configurations/BaseXPCService.xcconfig:
Configurations/adattributiond.xcconfig:
Configurations/webpushd.xcconfig:
Scripts/create-symlink-to-altroot.sh: Added.
WebKit.xcodeproj/project.pbxproj:

8:10 AM Changeset in webkit [287136] by Devin Rousso

12 edits
2 adds in trunk

Implement Array.prototype.groupBy and Array.prototype.groupByToMap
https://bugs.webkit.org/show_bug.cgi?id=234327

Reviewed by Yusuke Suzuki.

JSTests:

stress/array-groupBy.js: Added.

(shouldBe):
(shouldBeObject):
(shouldBeObject.replacer):
(notReached):
(toObject):
(reverseInsertionOrder):

stress/array-groupByToMap.js: Added.

(shouldBe):
(shouldBeObject):
(shouldBeObject.replacer):
(shouldBeMap):
(notReached):
(toObject):
(reverseInsertionOrder):

Source/JavaScriptCore:

Implement new Array Grouping proposal <https://tc39.es/proposal-array-grouping/>, which just
reached Stage 3.

Array.prototype.groupBy/Array.prototype.groupByToMap will return a {}/Map where each
value in the array is put into a "bucket" keyed by the return value of the provoded callback.

`js
const array = [1, 2, 3, 4];

array.groupBy(n => n % 2 ? "odd" : "even") { odd: [1, 3], even: [2, 4] }
array.groupByToMap(n => n % 2 ? "odd" : "even") new Map("odd", [1, 3, ["even", [2, 4]])
`

builtins/ArrayPrototype.js:

(groupBy): Added.
(groupByToMap): Added.

runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

bytecode/BytecodeIntrinsicRegistry.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_toPropertyKey): Added.
Allow @toPropertyKey to be used in builtins to convert a value to a property key. This is
used to avoid converting the return value of the callback given to groupBy more than once.

builtins/BuiltinNames.h:
bytecode/LinkTimeConstant.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
Allow @Map to be used in builtins to create a primordial Map instance. This is used to
avoid side effects when creating and populating the Map returned by groupByToMap.

runtime/OptionsList.h:

Add useArrayGroupByMethod option.

Source/WebInspectorUI:

UserInterface/Models/NativeFunctionParameters.js:

7:49 AM Changeset in webkit [287135] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION(r286849-r286852): [iOS] http/tests/app-privacy-report/user-attribution-post-request.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=234363

Unreviewed test gardening.

platform/ios/TestExpectations: Mark test as failing.

7:16 AM Changeset in webkit [287134] by clopez@igalia.com

2 edits in trunk/Tools

[GTK] Add gtk-wk2 to EWS bubbles
https://bugs.webkit.org/show_bug.cgi?id=209104

Reviewed by Jonathan Bedard.

A new queue was added in 286405 which runs GTK LayoutTests.
This patch adds the queue to the EWS bubbles.

CISupport/ews-app/ews/views/statusbubble.py:

(StatusBubble):

7:15 AM Changeset in webkit [287133] by clopez@igalia.com

4 edits in trunk/Tools

[GTK][WPE] Apply optimizations to speed up the layout-test EWS and add a few more workers to the build ones.
https://bugs.webkit.org/show_bug.cgi?id=234378

Reviewed by Jonathan Bedard.

This applies two optimizations to speed up the testing on the layout-tests EWS added in r286405

Pass --fully-parallel to the retry steps. This makes the tool to utilize all the available workers for running

the tests instead of running them in serial. That makes the time needed to complete the retry steps to be considerable less,
In this example https://ews-build.webkit.org/#/builders/35/builds/1757 it reduces the timing from 43 mins to 12 mins.

When the first run fails without giving a list of failures and we have not reached the maximum retry count

we are going to end retring the whole testing anyway, so there is no point in running the tests without patch
in that case, we can skip doing that to save time. See: https://ews-build.webkit.org/#/builders/35/builds/1763

On top of that this patch adds an extra worker to the EWS build queues of GTK and WPE
because I detected that this queues sometimes are not fast enough.

CISupport/ews-build/config.json:
CISupport/ews-build/steps.py:

(BugzillaMixin.send_email_for_infrastructure_issue):
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.setLayoutTestCommand):

CISupport/ews-build/steps_unittest.py:

7:00 AM Changeset in webkit [287132] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Add support for mixed ltr/rtl content
https://bugs.webkit.org/show_bug.cgi?id=234381

Reviewed by Antti Koivisto.

Inline boxes can also introduce RTL direction to their content which may initiate visual reordering
(and thus requires bidi handling).
In this patch hasSeenBidiContent (redundant at this point) is replaced with needsVisualReordering.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::InlineItemsBuilder):
(WebCore::Layout::InlineItemsBuilder::handleTextContent):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxStart):
(WebCore::Layout::InlineItemsBuilder::handleInlineBoxEnd):

layout/formattingContexts/inline/InlineItemsBuilder.h:

(WebCore::Layout::InlineItemsBuilder::needsVisualReordering const):
(WebCore::Layout::InlineItemsBuilder::hasSeenBidiContent const): Deleted.

6:52 AM Changeset in webkit [287131] by commit-queue@webkit.org

7 edits
2 adds in trunk

Mark range boundary point containers
https://bugs.webkit.org/show_bug.cgi?id=233462

Patch by Rob Buis <rbuis@igalia.com> on 2021-12-16
Reviewed by Darin Adler.

Source/WebCore:

Mark range boundary point containers as unreachable for gc.

Test: fast/dom/Range/delete-contents-crash.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSRangeCustom.cpp: Added.

(WebCore::JSRange::visitAdditionalChildren):

dom/Range.cpp:

(WebCore::Range::visitNodesConcurrently const):

dom/Range.h:
dom/Range.idl:

LayoutTests:

fast/dom/Range/delete-contents-crash-expected.txt: Added.
fast/dom/Range/delete-contents-crash.html: Added.

6:40 AM Changeset in webkit [287130] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Do not use inlineItemOffsets for checking if an inline item is a "content" type.
https://bugs.webkit.org/show_bug.cgi?id=234383

Reviewed by Antti Koivisto.

This patch removes some leftover logic from when we used the inlineItemOffsets to check for opaque inline items.
Now in this loop we try to figure out if the inline box has content or not by
looking at the nested inline item types.

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

3:31 AM Changeset in webkit [287129] by graouts@webkit.org

10 edits in trunk/Source/WebCore

ActiveDOMObject::suspendIfNeeded() should not be called within constructors
https://bugs.webkit.org/show_bug.cgi?id=233945

Reviewed by Darin Adler.

Step 2 where we convert the IDB code to use suspendIfNeeded() only within create() methods. This required
adding such methods and making the constructor private for IDBIndex and IDBObjectStore.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::create):
(WebCore::IDBDatabase::IDBDatabase):

Modules/indexeddb/IDBDatabaseNameAndVersionRequest.cpp:

(WebCore::IDBDatabaseNameAndVersionRequest::create):
(WebCore::IDBDatabaseNameAndVersionRequest::IDBDatabaseNameAndVersionRequest):

Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::create):
(WebCore::IDBIndex::IDBIndex):

Modules/indexeddb/IDBIndex.h:
Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::create):
(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::index):

Modules/indexeddb/IDBObjectStore.h:
Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::createDeleteRequest):
(WebCore::IDBOpenDBRequest::createOpenRequest):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::create):
(WebCore::IDBRequest::createObjectStoreGet):
(WebCore::IDBRequest::createIndexGet):
(WebCore::IDBRequest::IDBRequest):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::createObjectStore):
(WebCore::IDBTransaction::createIndex):

3:03 AM Changeset in webkit [287128] by commit-queue@webkit.org

7 edits
2 adds in trunk

Flexbox ignores margins of absolute positioned children when align-items: flex-end or justify-content: flex-end
https://bugs.webkit.org/show_bug.cgi?id=234143

Patch by Vitaly Dyachkov <obyknovenius@me.com> on 2021-12-16
Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003-expected.html: Added.
web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003.html: Added.
web-platform-tests/css/css-flexbox/abspos/position-absolute-015-expected.txt: Replaced FAIL

by PASS expectations.

Source/WebCore:

When flexbox layouts its children every absolutely-positioned child is processed separately from regular flex items as it were the sole flex item.
Absolutely-positioned can be both main- and cross-axis aligned. To correctly align it we first must calculate available space for it.
To do that the code was correctly subtracting the size of the item from the size of the container but was not subtracting the margins.
Fixed by including the margins into available size calculation.

Test: imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-margin-003.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisMarginExtentForChild const):
(WebCore::RenderFlexibleBox::staticMainAxisPositionForPositionedChild):

LayoutTests:

TestExpectations: Unksipped a flexbox test that is now passing.

2:52 AM Changeset in webkit [287127] by jh718.park@samsung.com

2 edits in trunk/LayoutTests/imported/w3c

Unreviewed. Import updated table-child-percentage-height-with-border-box-expected.html

The wpt expected file was fixed accroding to the spec,
https://drafts.csswg.org/css-tables-3/#table-cell-content-relayout.

The corresponding wpt issue is https://github.com/web-platform-tests/wpt/pull/32089.

web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html:

Dec 15, 2021:

11:08 PM Changeset in webkit [287126] by Andres Gonzalez

2 edits in trunk/Source/WebCore

Fix for crash in AXIsolatedObject::textMarkerRangeForNSRange.
https://bugs.webkit.org/show_bug.cgi?id=234377
<rdar://problem/86553198>

Reviewed by Chris Fleizach.

Covered by accessibility/mac/textmarker-range-for-range.html.

AXIsolatedObject::textMarkerRangeForNSRange needs to autorelease the
object retrieved from the main thread. This was causing intermittent
crashes when accessing the return value off of the main thread.

accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:

(WebCore::AXIsolatedObject::textMarkerRangeForNSRange const):

8:33 PM Changeset in webkit [287125] by beidson@apple.com

5 edits in trunk/Source/WebKit

Some webpushtool improvements.
https://bugs.webkit.org/show_bug.cgi?id=234372

Reviewed by Alex Christensen.

Make the list of current connections be reliably ordered
If the invocation is solely about injecting a push message, exit afterwards
Some other tiny niceties

webpushd/WebPushDaemon.mm:

(WebPushD::Daemon::broadcastAllConnectionIdentities):
(WebPushD::Daemon::injectPushMessageForTesting):

webpushd/webpushtool/WebPushToolConnection.h:
webpushd/webpushtool/WebPushToolConnection.mm:

(WebPushTool::Connection::create):
(WebPushTool::Connection::Connection):
(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::startAction):
(WebPushTool::Connection::sendPushMessage):

webpushd/webpushtool/WebPushToolMain.mm:

(main):

7:46 PM Changeset in webkit [287124] by beidson@apple.com

20 edits
1 copy
1 add in trunk/Source

Add a "NotificationData" object to encompass local Notification-related parameters, instead of passing tons of them around everywhere.
https://bugs.webkit.org/show_bug.cgi?id=234370

Reviewed by Tim Horton.

Source/WebCore:

No behavior change.

Modules/notifications/Notification.cpp:

(WebCore::Notification::dataWithoutNotificationID const):

Modules/notifications/Notification.h:

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

NetworkProcess/Notifications/NetworkNotificationManager.cpp:

(WebKit::NetworkNotificationManager::showNotification):

NetworkProcess/Notifications/NetworkNotificationManager.h:

Shared/Notifications/NotificationManagerMessageHandler.h:
Shared/Notifications/NotificationManagerMessageHandler.messages.in:

UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::create):

UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:

(WebKit::WebNotificationManagerMessageHandler::showNotification):

UIProcess/Notifications/WebNotificationManagerMessageHandler.h:

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

UIProcess/Notifications/WebNotificationManagerProxy.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

UIProcess/WebPageProxy.h:

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):

7:33 PM Changeset in webkit [287123] by wilander@apple.com

2 edits in trunk/Tools

TestWebKitAPI.PrivateClickMeasurement.MigrateWithDestinationToken is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=234335
<rdar://problem/86505218>

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:

(cleanUp):

Made the function sleep-wait until the file is indeed deleted.

6:15 PM Changeset in webkit [287122] by ysuzuki@apple.com

31 edits
4 moves in trunk/Source/JavaScriptCore

Rename Wasm::CodeBlock to Wasm::CalleeGroup
https://bugs.webkit.org/show_bug.cgi?id=203694

Reviewed by Mark Lam.

This is not a CodeBlock. And the name causes confusion with JSC::CodeBlock, which is not at all related.
This patch renames it to Wasm::CalleeGroup.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::deleteAllCodeBlocks):

heap/Heap.h:

(JSC::Heap::forEachCodeBlockSpace):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:
wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::BBQPlan):
(JSC::Wasm::BBQPlan::work):

wasm/WasmBBQPlan.h:
wasm/WasmCalleeGroup.cpp: Renamed from Source/JavaScriptCore/wasm/WasmCodeBlock.cpp.

(JSC::Wasm::CalleeGroup::create):
(JSC::Wasm::CalleeGroup::createFromExisting):
(JSC::Wasm::CalleeGroup::CalleeGroup):
(JSC::Wasm::CalleeGroup::~CalleeGroup):
(JSC::Wasm::CalleeGroup::waitUntilFinished):
(JSC::Wasm::CalleeGroup::compileAsync):
(JSC::Wasm::CalleeGroup::isSafeToRun):
(JSC::Wasm::CalleeGroup::setCompilationFinished):

wasm/WasmCalleeGroup.h: Renamed from Source/JavaScriptCore/wasm/WasmCodeBlock.h.
wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::initElementSegment):

wasm/WasmInstance.h:

(JSC::Wasm::Instance::calleeGroup const):
(JSC::Wasm::Instance::isImportFunction const):
(JSC::Wasm::Instance::codeBlock const): Deleted.

wasm/WasmMachineThreads.h:
wasm/WasmModule.cpp:

(JSC::Wasm::Module::getOrCreateCalleeGroup):
(JSC::Wasm::Module::compileSync):
(JSC::Wasm::Module::compileAsync):
(JSC::Wasm::Module::copyInitialCalleeGroupToAllMemoryModes):
(JSC::Wasm::Module::getOrCreateCodeBlock): Deleted.
(JSC::Wasm::Module::copyInitialCodeBlockToAllMemoryModes): Deleted.

wasm/WasmModule.h:

(JSC::Wasm::Module::calleeGroupFor):
(JSC::Wasm::Module::codeBlockFor): Deleted.

wasm/WasmOMGForOSREntryPlan.cpp:

(JSC::Wasm::OMGForOSREntryPlan::OMGForOSREntryPlan):
(JSC::Wasm::OMGForOSREntryPlan::work):

wasm/WasmOMGForOSREntryPlan.h:
wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::OMGPlan):
(JSC::Wasm::OMGPlan::work):

wasm/WasmOMGPlan.h:
wasm/WasmOperations.cpp:

(JSC::Wasm::triggerOMGReplacementCompile):
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::updateCallSitesToCallUs):

wasm/WasmPlan.h:
wasm/WasmSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::doWasmCall):

wasm/js/JSWebAssembly.cpp:

(JSC::resolve):
(JSC::instantiate):

wasm/js/JSWebAssemblyCalleeGroup.cpp: Renamed from Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.cpp.

(JSC::JSWebAssemblyCalleeGroup::create):
(JSC::JSWebAssemblyCalleeGroup::JSWebAssemblyCalleeGroup):
(JSC::JSWebAssemblyCalleeGroup::finishCreation):
(JSC::JSWebAssemblyCalleeGroup::destroy):
(JSC::JSWebAssemblyCalleeGroup::clearJSCallICs):
(JSC::JSWebAssemblyCalleeGroup::visitChildrenImpl):
(JSC::JSWebAssemblyCalleeGroup::finalizeUnconditionally):

wasm/js/JSWebAssemblyCalleeGroup.h: Renamed from Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h.
wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::visitChildrenImpl):
(JSC::JSWebAssemblyInstance::finalizeCreation):

wasm/js/JSWebAssemblyInstance.h:
wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::calleeGroup):
(JSC::JSWebAssemblyModule::setCalleeGroup):
(JSC::JSWebAssemblyModule::visitChildrenImpl):
(JSC::JSWebAssemblyModule::codeBlock): Deleted.
(JSC::JSWebAssemblyModule::setCodeBlock): Deleted.

wasm/js/JSWebAssemblyModule.h:
wasm/js/WebAssemblyFunction.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::initializeImportsAndExports):

wasm/js/WebAssemblyWrapperFunction.h:

5:52 PM Changeset in webkit [287121] by achristensen@apple.com

26 edits
2 deletes in trunk

Remove unreachable code in Plugin and PluginController
https://bugs.webkit.org/show_bug.cgi?id=234365

Reviewed by Geoff Garen and Anders Carlsson.

Source/WebCore:

bindings/js/ScriptController.h:
bindings/js/ScriptControllerMac.mm:
history/BackForwardCache.cpp:

(WebCore::canCacheFrame):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setExperimentalPlugInSandboxProfilesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::experimentalPlugInSandboxProfilesEnabled const): Deleted.

Source/WebKit:

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPageCacheSupportsPlugins):
(WKPreferencesGetPageCacheSupportsPlugins):
(WKPreferencesSetAsynchronousPluginInitializationEnabled):
(WKPreferencesGetAsynchronousPluginInitializationEnabled):
(WKPreferencesSetAsynchronousPluginInitializationEnabledForAllPlugins):
(WKPreferencesGetAsynchronousPluginInitializationEnabledForAllPlugins):
(WKPreferencesSetArtificialPluginInitializationDelayEnabled):
(WKPreferencesGetArtificialPluginInitializationDelayEnabled):
(WKPreferencesSetPluginSandboxProfilesEnabledForAllPlugins):
(WKPreferencesGetPluginSandboxProfilesEnabledForAllPlugins):

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setPageCacheSupportsPlugins:]):
(-[WKPreferences _pageCacheSupportsPlugins]):
(-[WKPreferences _setAsynchronousPluginInitializationEnabled:]):
(-[WKPreferences _asynchronousPluginInitializationEnabled]):
(-[WKPreferences _setArtificialPluginInitializationDelayEnabled:]):
(-[WKPreferences _artificialPluginInitializationDelayEnabled]):
(-[WKPreferences _setExperimentalPlugInSandboxProfilesEnabled:]):
(-[WKPreferences _experimentalPlugInSandboxProfilesEnabled]):

WebProcess/Plugins/PDF/PDFPlugin.h:

(isType):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::getSelectionForWordAtPoint const): Deleted.

WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Plugin): Deleted.

WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::type const): Deleted.
(WebKit::Plugin::isPluginProxy const): Deleted.
(WebKit::Plugin::isNetscapePlugin const): Deleted.
(WebKit::Plugin::isPDFPlugin const): Deleted.

WebProcess/Plugins/PluginController.h:

(WebKit::PluginController::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::PluginController::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::PluginController::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::PluginController::PluginDestructionProtector::PluginDestructionProtector): Deleted.
(WebKit::PluginController::PluginDestructionProtector::~PluginDestructionProtector): Deleted.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
(WebKit::PluginView::didFailToInitializePlugin): Deleted.
(WebKit::PluginView::getSelectionForWordAtPoint const): Deleted.
(WebKit::PluginView::invalidate): Deleted.
(WebKit::PluginView::userAgent): Deleted.
(WebKit::PluginView::cancelStreamLoad): Deleted.
(WebKit::PluginView::continueStreamLoad): Deleted.
(WebKit::PluginView::cancelManualStreamLoad): Deleted.
(WebKit::PluginView::setStatusbarText): Deleted.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Deleted.
(WebKit::PluginView::compositingRenderServerPort): Deleted.
(WebKit::PluginView::getAuthenticationInfo): Deleted.
(WebKit::PluginView::isPrivateBrowsingEnabled): Deleted.
(WebKit::PluginView::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::PluginView::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::PluginView::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::PluginView::protectPluginFromDestruction): Deleted.
(WebKit::PluginView::unprotectPluginFromDestruction): Deleted.

WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::asynchronousPluginInitializationEnabled const): Deleted.
(WebKit::WebPage::setAsynchronousPluginInitializationEnabled): Deleted.
(WebKit::WebPage::asynchronousPluginInitializationEnabledForAllPlugins const): Deleted.
(WebKit::WebPage::setAsynchronousPluginInitializationEnabledForAllPlugins): Deleted.
(WebKit::WebPage::artificialPluginInitializationDelayEnabled const): Deleted.
(WebKit::WebPage::setArtificialPluginInitializationDelayEnabled): Deleted.

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:
Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html:
media/crash-closing-page-with-media-as-plugin-fallback.html:
plugins/crash-restoring-plugin-page-from-page-cache.html:
plugins/frameset-with-plugin-frame.html:
plugins/netscape-plugin-page-cache-works.html:
plugins/netscape-plugin-page-cache-works-expected.html: Remove test for no-longer-reachable configuration.

5:18 PM Changeset in webkit [287120] by Chris Dumez

4 edits in trunk/Source

Support passing an old-style enum to add(Hasher&, ...)
https://bugs.webkit.org/show_bug.cgi?id=234368

Reviewed by Darin Adler.

Source/WebCore:

Drop static_casts that should no longer be needed now that we can pass
an enum to add(Hasher&, ...).

platform/network/ProtectionSpaceHash.h:

(WebCore::ProtectionSpaceHash::hash):

Source/WTF:

Support passing an old-style enum to add(Hasher&, ...). Previously, it would work for enum classes
but lead to ambiguity errors with some compiler when passing a plain enum.

wtf/Hasher.h:

(WTF::Hasher::add):
(WTF::add):

5:08 PM Changeset in webkit [287119] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

[WebIDL] Remove the now-unused "ExecState" value of [CallWith] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=234331

Patch by Alexey Shvayka <ashvayka@apple.com> on 2021-12-15
Reviewed by Darin Adler.

ExecState was removed in favor of JSGlobalObject in https://webkit.org/b/202392.
This change removes leftovers from bindings generator, improving the condition for
exception check in GenerateConstructorDefinition, and even renames WebIDL test cases.

No new tests, no behavior change.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):
(GenerateConstructorDefinition):

bindings/scripts/IDLAttributes.json:
bindings/scripts/test/JS/*: Updated.
bindings/scripts/test/TestObj.idl:

4:55 PM Changeset in webkit [287118] by commit-queue@webkit.org

4 edits
2 adds in trunk

null ptr deref in WebCore::ApplyStyleCommand::applyRelativeFontStyleChange
https://bugs.webkit.org/show_bug.cgi?id=234312

Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2021-12-15
Reviewed by Chris Dumez.

Source/WebCore:

In some situations calling ApplyStyleCommand::nodeFullySelected forces layout in a
way that disconnects the element. In this situation, we now break out of iteration.

We also add an isOrphan() check in ApplyStyleCommand::applyInlineStyle given
the possibility of this scenario.

Test: fast/editing/apply-relative-font-style-change-crash-004.html

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

LayoutTests:

TestExpectations:
fast/editing/apply-relative-font-style-change-crash-004-expected.txt: Added.
fast/editing/apply-relative-font-style-change-crash-004.html: Added.

4:55 PM Changeset in webkit [287117] by Alan Coon

13 edits
2 adds in branches/safari-612-branch/Source/WebCore

Cherry-pick r287079. rdar://problem/85892959

Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=234328
<rdar://85892959>

Reviewed by Tim Horton.

When scrolling pages like Twitter and Facebook we observed CoreAnimation commits on the
scrolling thread taking longer than they should because CABackingStore objects were being
released in those transactions.

Work around this issue by extending the lifetime of CABackingStore objects if we detect that
they might be entrained into a scrolling tree commit, by virtue of having overlapping main
thread and scrolling thread commits.

The logic is contained in PlatformCALayerContentsDelayedReleaser, which puts layer contents
into a retaining vector when they are being cleared on the layer. They are released at the
end of a main thread commit; if we detected overlapping commits, then we release on a
dispatch to extend the lifetime slightly.

The remaining changes are plumbing to get commit willBegin/didEnd messages to PlatformCALayerContentsDelayedReleaser
for main and scrolling threads.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
page/scrolling/ScrollingTree.h:
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::willStartPlatformRenderingUpdate): (WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):
page/scrolling/mac/ScrollingTreeMac.h:
page/scrolling/mac/ScrollingTreeMac.mm: (ScrollingTreeMac::applyLayerPositionsInternal): (ScrollingTreeMac::registerForPlatformRenderingUpdateCallback):
platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateContentsVisibility): (WebCore::GraphicsLayerCA::updateDrawsContent):
platform/graphics/ca/PlatformCALayer.cpp: (WebCore::PlatformCALayer::clearContents):
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::setBackingStoreAttached): (WebCore::PlatformCALayerCocoa::clearContents):
platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h: Added. (WebCore::PlatformCALayerContentsDelayedReleaser::WTF_GUARDED_BY_LOCK):
platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm: Added. (WebCore::PlatformCALayerContentsDelayedReleaser::singleton): (WebCore::PlatformCALayerContentsDelayedReleaser::takeLayerContents): (WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitWillStart): (WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitDidEnd): (WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitWillStart): (WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitDidEnd): (WebCore::PlatformCALayerContentsDelayedReleaser::updateSawOverlappingCommit): (WebCore::PlatformCALayerContentsDelayedReleaser::clearRetainedContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:52 PM Changeset in webkit [287116] by J Pascoe

18 edits
1 add in trunk

[WebAuthn] Allow same-site, cross-origin iframe get()
https://bugs.webkit.org/show_bug.cgi?id=234309
rdar://problem/86486313

Reviewed by Brent Fulgham.

Source/WebCore:

The Web Authentication level 2 specifies a feature policy to allow get calls in
cross-origin i-frames. This patch implements this feature policy partially. Only
same-site, cross-origin i-frames are supported instead. This is for tracking prevention
purposes. https://w3c.github.io/webauthn/#sctn-iframe-guidance

This patch also starts passing ClientDataJSON hashes to ASC to avoid the situation
where WebKit includes crossOrigin or other fields in ClientDataJSON that ASC is
unaware of when generating ClientDataJSON.

Added layout test cases for same-site, cross-origin get calls.

Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinator::create const):
(WebCore::doesHaveSameSiteAsAncestors):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):

Modules/webauthn/WebAuthenticationUtils.cpp:

(WebCore::buildClientDataJson):

Modules/webauthn/WebAuthenticationUtils.h:
html/FeaturePolicy.cpp:

(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

html/FeaturePolicy.h:

Source/WebKit:

Added layout test cases for same-site, cross-origin get calls.

Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(produceClientDataJson):

UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):

LayoutTests:

Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
publickey-credentials-get feature policy.

http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
http/wpt/webauthn/resources/util.js:

4:51 PM Changeset in webkit [287115] by Jonathan Bedard

9 edits in trunk/Tools

[reporelaypy] Forward branches to alternate remote
https://bugs.webkit.org/show_bug.cgi?id=234347
<rdar://problem/86526293>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:

(Checkout.Encoder.default): Add remotes.
(Checkout.clone): After cloning a repository, add required remotes.
(Checkout.add_remotes): Track remotes in repository.
(Checkout.init): Allow caller to specify set of remotes to be tracked.
(Checkout.push_update): Push update for specified remote.
(Checkout.update_for): Return 'True' and 'False.'
(Checkout.update_all): If a branch is being updated, we should forward that
update to any tracked remotes.

Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:

(HookProcessor.process_worker_hook): After updating a branch, forward that
update to any tracked remotes.

Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:

(CheckoutUnittest.test_constructor_no_sentinal): Capture debug logging.

Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:

(CheckoutRouteUnittest.test_landing): Capture debug logging.
(CheckoutRouteUnittest.test_invoked_redirect): Ditto.
(CheckoutRouteUnittest.test_trac): Ditto.

Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py:

(HooksUnittest.test_process): Test for any error logging.
(HooksUnittest.test_process_branch): Ditto.

Tools/Scripts/libraries/reporelaypy/run: Allow caller to specify remote to be tracked.
Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.

Canonical link: https://commits.webkit.org/245300@main

4:46 PM Changeset in webkit [287114] by Alan Coon

8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.4.5

3:28 PM Changeset in webkit [287113] by Russell Epstein

1 copy in tags/Safari-613.1.11.7

Tag Safari-613.1.11.7.

3:24 PM Changeset in webkit [287112] by Russell Epstein

2 edits in branches/safari-613.1.11-branch/Source/WebKit

Cherry-pick r286781. rdar://problem/86221898

Unreviewed fix after r286778 to address WebContent crashes on launch

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:23 PM Changeset in webkit [287111] by Russell Epstein

9 edits in branches/safari-613.1.11-branch/Source

Versioning.

WebKit-7613.1.11.7

3:19 PM Changeset in webkit [287110] by Brent Fulgham

7 edits in trunk/Source/WebCore

Clean-up: Adopt Page::forEachDocument in some missed spots
https://bugs.webkit.org/show_bug.cgi?id=234324
<rdar://problem/85443831>

Reviewed by Darin Adler.

Switch manual loops to our 'forEachDocument' style in a few places that were missed
in earlier refactoring.

No change in behavior.

history/BackForwardCache.cpp:

(WebCore::setBackForwardCacheState)

page/EventHandler.cpp:

(WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):

page/Frame.cpp:

(WebCore::Frame::orientationChanged):

page/Page.cpp:

(WebCore::Page::~Page):
(WebCore::Page::forEachDocumentFromMainFrame): Added.
(WebCore::Page::forEachDocument): Use new method.
(WebCore::Page::forEachFrameFromMainFrame): Added.
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::userAgentChanged):

page/ios/FrameIOS.mm:

(WebCore::Frame::dispatchPageHideEventBeforePause):
(WebCore::Frame::dispatchPageShowEventBeforeResume):

2:34 PM Changeset in webkit [287109] by commit-queue@webkit.org

4 edits in trunk

[Shadow Realms] Wrapped functions must only throw TypeError from calling realm
https://bugs.webkit.org/show_bug.cgi?id=234357

JSTests:

Test the cases when the exception would be thrown by a function
originating from both the shadow realm and the incubating realm.

Patch by Joseph Griego <jgriego@igalia.com> on 2021-12-15
Reviewed by Yusuke Suzuki.

stress/shadow-realm-evaluate.js:

(shouldBe):
(let.f.realm.evaluate):
(shouldBe.f):

Source/JavaScriptCore:

Patch by Joseph Griego <jgriego@igalia.com> on 2021-12-15
Reviewed by Yusuke Suzuki.

This wrapping logic already exists for ShadowRealm.prototype.evaluate
but not for calls to wrapped functions. at present, this requires some
awkward manouvering to actually throw a typeerror from the shadow realm,
since the wrapper code always runs in the incubating realm.

Hopefully we can make this less messy soon by replacing this
implementation with one more integrated with the runtime.

This case wasn't covered by existing JSC or test262 tests; added
coverage both upstream in t262 and in this patch.

builtins/ShadowRealmPrototype.js:

(wrapped):
(globalPrivate.wrap):

1:54 PM Changeset in webkit [287108] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix Linux and windows build
https://bugs.webkit.org/show_bug.cgi?id=234362

Headers.cmake:

1:54 PM Changeset in webkit [287107] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed build fix after r287077.

platform/network/ProtectionSpaceHash.h:

(WebCore::ProtectionSpaceHash::hash):

1:34 PM Changeset in webkit [287106] by commit-queue@webkit.org

10 edits
5 deletes in trunk/Source

Remove ProxyServer
https://bugs.webkit.org/show_bug.cgi?id=234362

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-15
Reviewed by Geoffrey Garen.

Source/WebCore:

It was only used for NPAPI.

PlatformAppleWin.cmake:
PlatformMac.cmake:
Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/Curl.cmake:
platform/SourcesSoup.txt:
platform/network/ProxyServer.cpp: Removed.
platform/network/ProxyServer.h: Removed.
platform/network/cf/ProxyServerCFNet.cpp: Removed.
platform/network/curl/ProxyServerCurl.cpp: Removed.
platform/network/soup/ProxyServerSoup.cpp: Removed.

Source/WebKit:

WebProcess/Plugins/PluginView.cpp:

1:32 PM Changeset in webkit [287105] by don.olmstead@sony.com

5 edits
1 copy
2 moves
1 add in trunk/Tools

Split ATK specific code in WPEViewBackends
https://bugs.webkit.org/show_bug.cgi?id=234310

Reviewed by Adrian Perez de Castro.

Move ATK specific code in WPEViewBackends into the atk directory. This splits
ViewBackend's implementation into two files with ATK specific code migrated to
atk/ViewBackendAtk.cpp. The code in WebKitAccessibleApplication is all ATK specific so
its completely moved into the atk directory.

wpe/backends/CMakeLists.txt:
wpe/backends/PlatformWPE.cmake:
wpe/backends/ViewBackend.cpp:

(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
(WPEToolingBackends::addKeyEventListener): Deleted.
(WPEToolingBackends::removeKeyEventListener): Deleted.
(WPEToolingBackends::notifyAccessibilityKeyEventListeners): Deleted.
(WPEToolingBackends::ViewBackend::setAccessibleChild): Deleted.

wpe/backends/ViewBackend.h:
wpe/backends/atk/ViewBackendAtk.cpp: Copied from Tools/wpe/backends/ViewBackend.cpp.

(WPEToolingBackends::addKeyEventListener):
(WPEToolingBackends::removeKeyEventListener):
(WPEToolingBackends::ViewBackend::notifyAccessibilityKeyEventListeners):
(WPEToolingBackends::ViewBackend::initializeAccessibility):
(WPEToolingBackends::ViewBackend::updateAccessibilityState):
(WPEToolingBackends::ViewBackend::setAccessibleChild):

wpe/backends/atk/WebKitAccessibleApplication.cpp: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.cpp.
wpe/backends/atk/WebKitAccessibleApplication.h: Renamed from Tools/wpe/backends/WebKitAccessibleApplication.h.

1:26 PM Changeset in webkit [287104] by Tyler Wilcock

2 edits in trunk/Source/WebCore

AX: Move comment about accessibilityShouldUseUniqueId in WebAccessibilityObjectWrapperMac.mm to the right place
https://bugs.webkit.org/show_bug.cgi?id=234334

Reviewed by Chris Fleizach.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

Move comment about accessibilityShouldUseUniqueId next to its
defintion rather than its current location next to
accessibilityIsIgnored.

1:24 PM Changeset in webkit [287103] by Chris Dumez

2 edits in trunk/Source/WebKit

RELEASE_ASSERT in WTF::Deque<WebKit::NativeWebKeyboardEvent, 0ul>::first()
https://bugs.webkit.org/show_bug.cgi?id=234301

Reviewed by Geoffrey Garen.

WebPageProxy::interpretKeyEvent() gets called as the result of IPC from the WebProcess
and assumes that WebPageProxy::m_keyEventQueue is non-empty. We have evidence based on
the Chrome crash report that this assertion doesn't always hold. Also, the WebProcess
is not a trusted process so we shouldn't be making such assumptions in the first place.

Add a check in WebPageProxy::interpretKeyEvent() to properly deal with an empty queue.

No new tests, unknown how to reproduce.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::interpretKeyEvent):

1:13 PM Changeset in webkit [287102] by Ryan Haddad

10 edits in trunk/LayoutTests

PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
https://bugs.webkit.org/show_bug.cgi?id=234281

Unreviewed test gardening.

Rebaseline tests for iOS.

platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt:
platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt:
platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt:
platform/ios/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt:
platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt:
platform/ios/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt:
platform/ios/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt:
platform/ios/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt:

1:10 PM Changeset in webkit [287101] by commit-queue@webkit.org

3 edits
10 adds in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=234353

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-12-15

platform/glib/TestExpectations:
platform/glib/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
platform/glib/http/tests/workers/service/service-worker-download-body.https-expected.txt: Added.
platform/glib/http/tests/workers/service/service-worker-download-stream.https-expected.txt: Added.
platform/glib/http/tests/workers/service/service-worker-download.https-expected.txt: Added.
platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt: Added.
platform/glib/http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt: Added.
platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Added.
platform/gtk/TestExpectations:

1:06 PM Changeset in webkit [287100] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Actually use adattributiond.entitlements when code signing adattributiond
https://bugs.webkit.org/show_bug.cgi?id=234329
<rdar://86425785>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-15
Reviewed by Tim Horton.

r283897 got me so close. I generate the entitlements and the sandbox profile. Now I need to actually sign with the entitlements.
I verified by building two roots that before this change, the codesign invocation looked like this:
/usr/bin/codesign --force --sign - --generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond
and after this change it looks like this:
/usr/bin/codesign --force --sign - --entitlements .../TempContent/Objects/WebKit.build/adattributiond.build/adattributiond.entitlements

--generate-entitlement-der .../Root/System/Library/Frameworks/WebKit.framework/Daemons/adattributiond

Configurations/adattributiond.xcconfig:

12:55 PM Changeset in webkit [287099] by Russell Epstein

2 edits in branches/safari-613.1.12-branch/Source/WebKit

Cherry-pick r287098. rdar://problem/86502081

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336
<rdar://86343811>

Reviewed by Brent Fulgham.

Add access to required system call in the WebProcess sandbox on iOS.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:51 PM Changeset in webkit [287098] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336
<rdar://86343811>

Reviewed by Brent Fulgham.

Add access to required system call in the WebProcess sandbox on iOS.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

12:15 PM Changeset in webkit [287097] by Russell Epstein

2 edits in branches/safari-613.1.12-branch/Source/WebKit

Cherry-pick r287069. rdar://problem/86502081

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336
<rdar://86502081>

Reviewed by Tim Horton.

Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
https://trac.webkit.org/changeset/286673/webkit.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:15 PM Changeset in webkit [287096] by Russell Epstein

3 edits in branches/safari-613.1.12-branch/Source/WebKit

Cherry-pick r286961. rdar://problem/86343642

REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=234181
<rdar://problem/86343642>

Reviewed by Eric Carlson.

Use network connection state change callback to know when connection fails or is cancelled.
Introduce ConnectionStateTracker to know when to stop reading new UDP packets.
ConnectionStateTracker will be stopped when state is changed to failed or cancelled as well as when the whole connection is closed.
Renaming m_nwConnections to m_connections as m_nwConnections name was already used.
Reduce error logging to only new error codes or when connectino enters unrecoverable failure (hence changing to failed state).

Covered by existing tests.

NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:14 PM Changeset in webkit [287095] by Alexey Shvayka

5 edits in trunk/Source/WebCore

[WebIDL] Remove the now-unused [DocumentEventHandler] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=234047

Reviewed by Darin Adler.

[DocumentEventHandler] was originally introduced just to accommodate onselectionchange
IDL attribute, which became unnecessary as of r287089. Also, HTML spec has no concept
of reflecting event handlers to Document, only to Window [1].

[1] https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set

No new tests, no behavior change.

bindings/js/JSEventListener.cpp:

(WebCore::documentEventHandlerAttribute): Deleted.
(WebCore::setDocumentEventHandlerAttribute): Deleted.

bindings/js/JSEventListener.h:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):

bindings/scripts/IDLAttributes.json:

12:09 PM Changeset in webkit [287094] by jer.noble@apple.com

7 edits in trunk/Source

[Mac] Adopt -[NSScreen safeAreaInsets]
https://bugs.webkit.org/show_bug.cgi?id=234291
<rdar://85805895>

Reviewed by Eric Carlson.

Source/WebCore:

Adopt -safeAreaInsets and rename screenRectAvoidingMenuBar() to safeScreenFrame().

platform/PlatformScreen.h:
platform/mac/PlatformScreenMac.mm:

(WebCore::safeScreenFrame): Renamed from screenRectAvoidingMenuBar.

Source/WebKit:

Drive-by fix: use the safeAreaFrame() when determining where to place the exit
fullscreen placeholder image.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimationAndExitImmediately:]):

Source/WTF:

wtf/PlatformHave.h:

11:57 AM Changeset in webkit [287093] by commit-queue@webkit.org

12 edits
2 deletes in trunk/Source

More cleanup after PluginProcess removal
https://bugs.webkit.org/show_bug.cgi?id=234354

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-15
Reviewed by Tim Horton.

Source/WebCore:

platform/network/ProxyServer.h:

Source/WebKit:

Remove some unused code, unify some sources.

Configurations/PluginProcessShim.xcconfig: Removed.
Configurations/PluginService.xcconfig: Removed.
DerivedSources.make:
Shared/Cocoa/SharedRingBufferStorage.cpp:

(WebKit::ReadOnlySharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::allocate):

Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultMediaSessionCoordinatorEnabled):

Sources.txt:
UIProcess/WebProcessPool.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/Plugins/PluginController.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::platformLayer const):
(WebKit::PluginView::contentsScaleFactor):
(WebKit::PluginView::pluginProcessCrashed): Deleted.
(WebKit::PluginView::proxiesForURL): Deleted.
(WebKit::PluginView::cookiesForURL): Deleted.
(WebKit::PluginView::setCookiesForURL): Deleted.

WebProcess/Plugins/PluginView.h:

11:46 AM Changeset in webkit [287092] by ysuzuki@apple.com

5 edits in trunk/Source/bmalloc

[libpas] Implement atomics in inline assembly if compiler is using ARM64
https://bugs.webkit.org/show_bug.cgi?id=234333

Reviewed by Filip Pizlo.

libpas relies on how value is loaded since we are using pas_depend.
For example, we expect that compare_and_swap_strong returns a loaded value.
But it is not guaranteed: the compiler can return argument's old_value
if we ensure that the loaded value equals to old_value. In that case,
pas_depend's chain is broken because we start using distinct registers.
This can happen if atomics is implemented as LL/SC loop.

This patch implements atomics in inline assembly if the build is ARM64 (not ARM64E),
so that we ensure that we return loaded value's register instead of old value's one.

This significantly improved crash rate of libpas test suite on ARM64 (on ARM64E, all
tests pass already).

libpas/src/libpas/pas_config_prefix.h:
libpas/src/libpas/pas_lock.h:

(pas_lock_unlock):

libpas/src/libpas/pas_lock_free_read_ptr_ptr_hashtable.h:

(pas_lock_free_read_ptr_ptr_hashtable_find):

libpas/src/libpas/pas_utils.h:

(pas_atomic_store_uint8):
(pas_compare_and_swap_uint8_weak):
(pas_compare_and_swap_uint8_strong):
(pas_compare_and_swap_uint16_weak):
(pas_compare_and_swap_uint32_weak):
(pas_compare_and_swap_uint32_strong):
(pas_compare_and_swap_uint64_weak):
(pas_compare_and_swap_uint64_strong):
(pas_atomic_store_bool):
(pas_compare_and_swap_bool_weak):
(pas_compare_and_swap_bool_strong):
(pas_compare_and_swap_uintptr_weak):
(pas_compare_and_swap_uintptr_strong):
(pas_compare_and_swap_ptr_weak):
(pas_compare_and_swap_ptr_strong):
(pas_compare_and_swap_pair_weak):
(pas_compare_and_swap_pair_strong):
(pas_atomic_load_pair):
(pas_atomic_store_pair):
(pas_compare_ptr_opaque):

11:45 AM Changeset in webkit [287091] by Antti Koivisto

7 edits
1 copy
1 add in trunk/Source/WebCore

[:has() pseudo-class] Use Bloom filter to quickly reject :has() selectors
https://bugs.webkit.org/show_bug.cgi?id=234341

Reviewed by Dean Jackson.

We can dramatically speed up cases where there are many :has rules, most of which don't match their argument
by building a Bloom filter describing the features of the subtree.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchHasPseudoClass const):

Build and cache HasSelectorFilter per element/filter type. It will be constructed only if multiple :has()
selectors are tested for the same element (otherwise the regular match cache is more efficient).
Use it to quickly reject selectors.
Also add a basic inital optimization to bail out if there are no child/sibling elements that could match.

css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectElementIdentifierHashes):
(WebCore::SelectorFilter::collectSimpleSelectorHash):
(WebCore::SelectorFilter::collectSelectorHashes):
(WebCore::SelectorFilter::chooseSelectorHashesForFilter):
(WebCore::collectElementIdentifierHashes): Deleted.
(WebCore::collectSimpleSelectorHash): Deleted.
(WebCore::collectSelectorHashes): Deleted.
(WebCore::chooseSelectorHashesForFilter): Deleted.

css/SelectorFilter.h:
style/HasSelectorFilter.cpp: Added.

(WebCore::Style::HasSelectorFilter::HasSelectorFilter):
(WebCore::Style::HasSelectorFilter::typeForMatchElement):
(WebCore::Style::HasSelectorFilter::makeKey):

The key consists of the most specific string in the rightmost compound of the selector along with
:hover pseudo class, if any.

(WebCore::Style::HasSelectorFilter::add):

Add an Element to the filter.
The features collected are the same as for the regular selector filter, plus permutations with
:hover pseudo-class if it would match.

style/HasSelectorFilter.h: Copied from Source/WebCore/style/SelectorMatchingState.h.

(WebCore::Style::HasSelectorFilter::type const):
(WebCore::Style::HasSelectorFilter::reject const):

Add HasSelectorFilter which uses non-counting BloomFilter internally. The size of the filter is 512 bytes.

style/SelectorMatchingState.h:

(WebCore::Style::makeHasPseudoClassSelectorFilterKey):

11:42 AM Changeset in webkit [287090] by sihui_liu@apple.com

3 edits in trunk/Source/WebKit

REGRESSION (r286936): Many webstorage layout tests have become flaky failures
https://bugs.webkit.org/show_bug.cgi?id=234274
<rdar://problem/86434478>

Reviewed by Chris Dumez.

Connection (listener) is not added properly to existing MemoryStorageAreas, so events are not dispatched.
Also according to the old behavior, we don't add connection (listener) to StorageArea when creating it, but when
there is a connection message.

NetworkProcess/storage/SessionStorageManager.cpp:

(WebKit::SessionStorageManager::addStorageArea):
(WebKit::SessionStorageManager::connectToSessionStorageArea):
(WebKit::SessionStorageManager::cloneStorageArea):

NetworkProcess/storage/SessionStorageManager.h:

11:37 AM Changeset in webkit [287089] by Alexey Shvayka

6 edits in trunk

[WebIDL] onselectionchange IDL attribute should not Document-reflect event listeners
https://bugs.webkit.org/show_bug.cgi?id=234349

Reviewed by Darin Adler.

Source/WebCore:

onselectionchange IDL attribute should not forward event listeners from <body> to Document because:

a) the attribute is being standardized as a global event handler [1];
b) "selectionchange" event should be emitted on Document only for selection changes of ranges [2],

while it should bubble to <body> only when selection changes occur in <input> / <textarea> elements;

c) HTML spec has no concept of reflecting event handlers to Document, only to Window [3].

While this patch aligns WebKit with Blink and Gecko, event listener forwarding is preserved for
"onselectionchange" content attribute in order to ensure web-compatibility in the following case:

a userland <body onselectionchange> listener that relies on document.activeElement to handle selection changes, including ones that occur in <input> / <textarea> elements.

This is caught by the fast/events/selectionchange-user-initiated.html test as well.

[1] https://w3c.github.io/selection-api/#extensions-to-globaleventhandlers-interface
[2] https://w3c.github.io/selection-api/#selectionchange-event
[3] https://html.spec.whatwg.org/multipage/webappapis.html#window-reflecting-body-element-event-handler-set

Test: fast/dom/event-handler-attributes.html

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseAttribute):

html/HTMLBodyElement.idl:

LayoutTests:

fast/dom/event-handler-attributes-expected.txt:
fast/dom/event-handler-attributes.html:

10:55 AM Changeset in webkit [287088] by Russell Epstein

1 copy in tags/Safari-613.1.11.6

Tag Safari-613.1.11.6.

10:55 AM Changeset in webkit [287087] by Russell Epstein

1 delete in tags/Safari-613.1.11.6

Delete tag.

10:49 AM Changeset in webkit [287086] by commit-queue@webkit.org

8 edits in trunk

Avoid unnecessary allocation and UTF-8 conversion when calling DFABytecodeInterpreter::interpret
https://bugs.webkit.org/show_bug.cgi?id=234351

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-15
Reviewed by Tim Hatcher.

Source/WebCore:

A valid URL, the only input into DFABytecodeInterpreter::interpret, contains only ASCII characters.
In the overwhelming majority of cases, we have an 8-bit string. There is no need to allocate, copy, and convert it.
In the rare case that we somehow get a UTF-16 encoded ASCII string, just do what we did before and UTF-8 encode it.

Regular expressions allow matching the end of the string, which we currently implement by checking for the
null character, so I had to keep the parts that read the null character at the end of a string by checking
to see if we are at the end of the string when reading a character and returning the null character if we are.

Covered by many API tests.

contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::populateTopURLActionCacheIfNeeded const):
(WebCore::ContentExtensions::ContentExtension::populateFrameURLActionCacheIfNeeded const):

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsFromContentRuleList const):
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):

contentextensions/ContentExtensionsBackend.h:
contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::interpetJumpTable):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):

contentextensions/DFABytecodeInterpreter.h:

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

10:32 AM Changeset in webkit [287085] by Russell Epstein

2 edits in branches/safari-613.1.11-branch/Source/WebKit

Cherry-pick r286778. rdar://problem/86221898

[macOS][WP] Block access to unused system calls
https://bugs.webkit.org/show_bug.cgi?id=234003

Reviewed by Brent Fulgham.

Based on telemetry, block access to unused system calls in the WebContent process on macOS.

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:19 AM Changeset in webkit [287084] by Chris Dumez

10 edits in trunk/Source

Move SWServers from NetworkProcess to NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=234179

Reviewed by Darin Adler.

Source/WebKit:

Move SWServers from NetworkProcess to NetworkSession since they are per session.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::establishSWServerConnection):
(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
(WebKit::NetworkProcess::processPushMessage):
(WebKit::NetworkProcess::forEachSWServer): Deleted.
(WebKit::NetworkProcess::swServerForSession): Deleted.
(WebKit::NetworkProcess::existingSWOriginStoreForSession const): Deleted.
(WebKit::NetworkProcess::registerSWServerConnection): Deleted.
(WebKit::NetworkProcess::unregisterSWServerConnection): Deleted.
(WebKit::NetworkProcess::addServiceWorkerSession): Deleted.

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::swServerForSessionIfExists): Deleted.

NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::lowMemoryHandler):
(WebKit::NetworkSession::swOriginStore const):
(WebKit::NetworkSession::registerSWServerConnection):
(WebKit::NetworkSession::unregisterSWServerConnection):
(WebKit::NetworkSession::ensureSWServer):
(WebKit::NetworkSession::addServiceWorkerSession):
(WebKit::NetworkSession::hasServiceWorkerDatabasePath const):

NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::swServer):

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):

WebProcess/WebPage/WebPage.h:

Source/WTF:

wtf/MemoryPressureHandler.h:

Using a bool as underlying type for those enum classes is sufficient.

10:09 AM Changeset in webkit [287083] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Use the physical margin/border/padding values for inline boxes when generating the display content
https://bugs.webkit.org/show_bug.cgi?id=234346

Reviewed by Antti Koivisto.

Display content is always based on visual order. When we construct the display boxes

we visit the line runs in visual order
we make space for margin/border/padding by looking at the physical sides of the content

The visually first box may very well be logically the last and this first box's left side (again, visually)
may refer to the logical start/end values depending on the inline axis direction.

E.g in case of right to left inline direction, the border-inline-end value of an inline box should be use as the
"visually first" border on the left side of the inline box content.

It means that

physical values are used when creating the display boxes
and logical values are used throughout the layout

which in practice means that isLeftToRightDirection check should only happen before and after layout
(physical -> logical and logical -> physical respectively) but never during layout.

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::marginLeft):
(WebCore::Layout::marginRight):
(WebCore::Layout::borderLeft):
(WebCore::Layout::borderRight):
(WebCore::Layout::paddingLeft):
(WebCore::Layout::paddingRight):
(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):

10:08 AM Changeset in webkit [287082] by dino@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

[ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables
https://bugs.webkit.org/show_bug.cgi?id=233837
<rdar://problem/86335819>

Reviewed by Antoine Quint.

Turn off unknown-warning-option on Apple builds. This shouldn't need to be
upstreamed - the Xcode configurations for ANGLE are specific to WebKit.

Configurations/Base.xcconfig:

10:03 AM Changeset in webkit [287081] by yoshiaki.jitsukawa@sony.com

7 edits
3 adds in trunk

JPEG XL decoder should support understand color profiles
https://bugs.webkit.org/show_bug.cgi?id=233364
<rdar://problem/85767076>

Reviewed by Michael Catanzaro.

Source/WebCore:

Support color conversion by LCMS.

We subscribe the JXL_DEC_COLOR_ENCODING event to know when the color profile
that the image has is available, and try to get an ICC profile. After getting
the profile, we create a color conversion transform with the display's color
profile. When receiving decoded pixels, we convert the pixels with it.

Test: fast/images/jpegxl-with-color-profile.html

platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp:

(WebCore::eventsWanted):
(WebCore::JPEGXLImageDecoder::~JPEGXLImageDecoder):
(WebCore::JPEGXLImageDecoder::clear):
(WebCore::JPEGXLImageDecoder::setFailed):
(WebCore::JPEGXLImageDecoder::ensureDecoderInitialized):
(WebCore::JPEGXLImageDecoder::rewind):
(WebCore::JPEGXLImageDecoder::decode):
(WebCore::JPEGXLImageDecoder::processInput):
(WebCore::JPEGXLImageDecoder::imageOut):
(WebCore::JPEGXLImageDecoder::clearColorTransform):
(WebCore::JPEGXLImageDecoder::prepareColorTransform):
(WebCore::JPEGXLImageDecoder::tryDecodeICCColorProfile):

platform/image-decoders/jpegxl/JPEGXLImageDecoder.h:

LayoutTests:

Add test for JPEG XL with color profile. The test image is
converted from the JPEG test's image.

TestExpectations:
fast/images/jpegxl-with-color-profile-expected.html: Added.
fast/images/jpegxl-with-color-profile.html: Added.
fast/images/resources/red-at-12-oclock-with-color-profile.jxl: Added.
platform/glib/TestExpectations:
platform/wincairo/TestExpectations:

9:50 AM Changeset in webkit [287080] by tomoki.imai@sony.com

3 edits in trunk/Source/WTF

[PlayStation] Use FileSystem instead of FileSystemPlayStation except several unsupported APIs
https://bugs.webkit.org/show_bug.cgi?id=234337

Reviewed by Don Olmstead.

PlayStation should use FileSystem as its current SDK supports std::filesystem.
We have to maintain FileSystemPlayStation for now to supply some of FileSystem APIs
because the following functions are not supported yet.

std::filesystem::space
std::filesystem::rename
std::filesystem::canonical
std::filesystem::directory_iterator
std::filesystem::remove_all

The plan is to remove FileSystemPlayStation entirely after the SDK supports these functions.

This patch also fixes the incompatible issue of FileSystem::listDirectory of FileSystemPlayStation.
FileSystem::listDirectory is expected to return only the names, but it actually returns full paths.

Confirmed that there is no regression in FileSystem related testcases in TestWTF.

wtf/FileSystem.cpp: Add PLATFORM(PLAYSTATION) guards not to use unsupported std::filesystem APIs.
wtf/playstation/FileSystemPlayStation.cpp: Remove the functions duplicated with FileSystem.

Make FileSystem::listDirectory returns only names.
Add listDirectorySub which can return a full path because deleteNonEmptyDirectory depends on it.

9:46 AM Changeset in webkit [287079] by Simon Fraser

14 edits
2 adds in trunk/Source/WebCore

Twitter scroll stutter: ensure that CA backing store is always deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=234328
<rdar://85892959>

Reviewed by Tim Horton.

When scrolling pages like Twitter and Facebook we observed CoreAnimation commits on the
scrolling thread taking longer than they should because CABackingStore objects were being
released in those transactions.

Work around this issue by extending the lifetime of CABackingStore objects if we detect that
they might be entrained into a scrolling tree commit, by virtue of having overlapping main
thread and scrolling thread commits.

The logic is contained in PlatformCALayerContentsDelayedReleaser, which puts layer contents
into a retaining vector when they are being cleared on the layer. They are released at the
end of a main thread commit; if we detected overlapping commits, then we release on a
dispatch to extend the lifetime slightly.

The remaining changes are plumbing to get commit willBegin/didEnd messages to PlatformCALayerContentsDelayedReleaser
for main and scrolling threads.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
page/scrolling/ScrollingTree.h:
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::willStartPlatformRenderingUpdate):
(WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):

page/scrolling/mac/ScrollingTreeMac.h:
page/scrolling/mac/ScrollingTreeMac.mm:

(ScrollingTreeMac::applyLayerPositionsInternal):
(ScrollingTreeMac::registerForPlatformRenderingUpdateCallback):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsVisibility):
(WebCore::GraphicsLayerCA::updateDrawsContent):

platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::clearContents):

platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::setBackingStoreAttached):
(WebCore::PlatformCALayerCocoa::clearContents):

platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.h: Added.

(WebCore::PlatformCALayerContentsDelayedReleaser::WTF_GUARDED_BY_LOCK):

platform/graphics/ca/cocoa/PlatformCALayerContentsDelayedReleaser.mm: Added.

(WebCore::PlatformCALayerContentsDelayedReleaser::singleton):
(WebCore::PlatformCALayerContentsDelayedReleaser::takeLayerContents):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::mainThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitWillStart):
(WebCore::PlatformCALayerContentsDelayedReleaser::scrollingThreadCommitDidEnd):
(WebCore::PlatformCALayerContentsDelayedReleaser::updateSawOverlappingCommit):
(WebCore::PlatformCALayerContentsDelayedReleaser::clearRetainedContents):

9:26 AM Changeset in webkit [287078] by youenn@apple.com

4 edits in trunk/LayoutTests

[ Mac wk2 and iOS wk2 ] webrtc/libwebrtc/descriptionGetters.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=214084
<rdar://problem/65225336>

Reviewed by Eric Carlson.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:
webrtc/libwebrtc/descriptionGetters.html:

We are no longer getting the descriptions straight from the backend.
Instead, we are storing them at end of createOffer or answer/set descriptions time.
Update test accordingly.

9:10 AM Changeset in webkit [287077] by Chris Dumez

4 edits in trunk/Source/WebCore

http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=234314
<rdar://85150486>

Reviewed by Darin Adler.

http/tests/security/basic-auth-subresource.html and some other http auth tests are flaky.

No new tests, I will be able to unskip those layout tests in internal once this lands.

platform/network/ProtectionSpaceBase.cpp:

(WebCore::ProtectionSpaceBase::ProtectionSpaceBase):
(WebCore::ProtectionSpaceBase::host const): Deleted.
(WebCore::ProtectionSpaceBase::port const): Deleted.
(WebCore::ProtectionSpaceBase::serverType const): Deleted.
(WebCore::ProtectionSpaceBase::realm const): Deleted.
(WebCore::ProtectionSpaceBase::authenticationScheme const): Deleted.

platform/network/ProtectionSpaceBase.h:

(WebCore::ProtectionSpaceBase::host const):
(WebCore::ProtectionSpaceBase::port const):
(WebCore::ProtectionSpaceBase::serverType const):
(WebCore::ProtectionSpaceBase::realm const):
(WebCore::ProtectionSpaceBase::authenticationScheme const):
Clean up / modernise the ProtectionSpaceBase class.

platform/network/ProtectionSpaceHash.h:

(WebCore::ProtectionSpaceHash::hash):

Use Hasher in ProtectionSpaceHash::hash() as it is less error-prone. I believe the previous implementation was wrong because it was calling StringHasher::hashMemory(hashCodes, codeCount) instead of StringHasher::hashMemory(hashCodes, codeCount * sizeof(unsigned)). This could have resulted in inefficiencies I believe since we were not hashing the whole array memory.
Fix ProtectionSpace<ProtectionSpace> so that emptyValueIsZero is false instead of true. This was a bug since the ProtectionSpaceBase constructor initializes data members to non-zero values.

8:59 AM Changeset in webkit [287076] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix SVG resource invalidation logic causing incorrect layout state.
https://bugs.webkit.org/show_bug.cgi?id=233190
<rdar://82895369>

When SVG resources perform parent layout/resource invalidation, we can incorrectly
cross the SVG boundary when operating on a node which isn't an SVGRoot.
This can cause us to exit layout() with elements that still needsLayout().

Patch by Gavin Phillips <gavin.p@apple.com> on 2021-12-15
Reviewed by Darin Adler.

rendering/svg/RenderSVGResource.cpp:

(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

8:33 AM Changeset in webkit [287075] by Chris Lord

7 edits
2 adds in trunk

[GTK] Use libgbm and the ANGLE gbm backend to fix initialisation
https://bugs.webkit.org/show_bug.cgi?id=234293

Reviewed by Don Olmstead.

Add cmake files to find gbm and libdrm.

Source/cmake/FindGBM.cmake: Added.
Source/cmake/FindLibDRM.cmake: Added.

Source/ThirdParty/ANGLE:

Use GBM backend for GTK platform.

CMakeLists.txt:
GL.cmake:
PlatformGTK.cmake:

Source/WebCore:

Make ANGLE context non-TEXTURE_2D drawingBufferTextureTarget Cocoa-specific.

platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::drawingBufferTextureTarget):

8:25 AM Changeset in webkit [287074] by jer.noble@apple.com

4 edits in trunk/LayoutTests

[ iOS EWS ] 2X media/track (layout-tests) are a constant image failure
https://bugs.webkit.org/show_bug.cgi?id=234090
<rdar://problem/86281284>

Reviewed by Eric Carlson.

Fix the expected results.

media/track/track-webvtt-no-snap-to-lines-overlap-expected.html:
media/track/track-webvtt-snap-to-lines-left-right-expected.html:
platform/ios-wk2/TestExpectations:

8:23 AM Changeset in webkit [287073] by youenn@apple.com

2 edits in trunk/Source/WebKit

RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit should only reset once
https://bugs.webkit.org/show_bug.cgi?id=234340

Reviewed by Eric Carlson.

As seen in logs, there are cases where the unit is notified reset several times before it gets stopped and restarted.
This triggers resetting on WebProcess side several times which is unneeded.
Instead, we now only call reset once in a start/stop cycle of the audio unit.
Manually tested.

GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):

6:40 AM Changeset in webkit [287072] by youenn@apple.com

2 edits in trunk/Source/WTF

Make use of PLATFORM(COCOA) in MediaRecorder WebPreference
https://bugs.webkit.org/show_bug.cgi?id=234339

Reviewed by Eric Carlson.

Scripts/Preferences/WebPreferencesExperimental.yaml:

HAVE(AVASSETWRITERDELEGATE) has been removed from PlatformHave.h given it was true on all supported platforms.
But it was still used to guard MediaRecorder preference, thus MediaRecorder got disabled inadvertently.
Let's guard MediaRecorder with PLATFORM(COCOA).

6:15 AM Changeset in webkit [287071] by Carlos Garcia Campos

8 edits in trunk

[GTK][a11y] Add support for loading events when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234344

Reviewed by Joanmarie Diggs.

Source/WebCore:

Emit document:load-complete, document:reload, document:load-stopped and object:state-changed:busy.

accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::loadEvent):

accessibility/atspi/AccessibilityAtspi.h:
accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::loadEvent):

accessibility/atspi/AccessibilityObjectAtspi.h:

Tools:

Add a test case to check loading events.

TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(AccessibilityTest::shouldProcessEvent): Helper to make the filters conditions easier to read.
(AccessibilityTest::startEventMonitor): Make it possible to use the monitor without filtering events.
(testDocumentLoadEvents):
(beforeAll):

5:48 AM Changeset in webkit [287070] by Carlos Garcia Campos

10 edits in trunk

[GTK][a11y] Register the wrappers tree when there's an event listener registered
https://bugs.webkit.org/show_bug.cgi?id=234338

Reviewed by Joanmarie Diggs.

Source/WebCore:

Connect to the atspi registry to get the list of registered event listeners. If there's any listener, we register
the tree to ensure we can emit signals, but we only emit the signals for which there's a listener registered,
except for the ones required by the atspi cache.

accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::AccessibilityAtspi): Connect to the registry.
(WebCore::AccessibilityAtspi::~AccessibilityAtspi): Disconnect registry signals.
(WebCore::AccessibilityAtspi::registerTrees const): Register the trees of all root objects.
(WebCore::AccessibilityAtspi::initializeRegistry): Get the list of listeners registered and connect to
EventListenerRegistered signal.
(WebCore::AccessibilityAtspi::addEventListener): Add an event listener to the list converting the detail to non
camel case to be abel to compare it later on signal emission.
(WebCore::eventIsSubtype): Helper to check if event type is subtype of another.
(WebCore::AccessibilityAtspi::removeEventListener): Remove and events listener from the list.
(WebCore::AccessibilityAtspi::shouldEmitSignal): Return whether the given signal should be emitted, checking the
registered event listeners.
(WebCore::AccessibilityAtspi::parentChanged): Do not emit the signal if the object hasn't been registered yet to
avoid flooding during tree creation. We just register the object the object in that case which will update the
cache because addAccessible is always called.
(WebCore::AccessibilityAtspi::stateChanged): Return early if signal should not be emitted.
(WebCore::AccessibilityAtspi::textChanged): Ditto.
(WebCore::AccessibilityAtspi::textAttributesChanged): Ditto.
(WebCore::AccessibilityAtspi::textCaretMoved): Ditto.
(WebCore::AccessibilityAtspi::textSelectionChanged): Ditto.
(WebCore::AccessibilityAtspi::valueChanged): Ditto.
(WebCore::AccessibilityAtspi::selectionChanged): Ditto.

accessibility/atspi/AccessibilityAtspi.h:

(WebCore::AccessibilityAtspi::hasEventListeners const):

accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::childAdded): Return early if object is already detached or ignored.
(WebCore::AccessibilityObjectAtspi::childRemoved): Ditto.
(WebCore::AccessibilityObjectAtspi::stateChanged): Do not return early if the object is not registered because
we might end up emitting the signal.

accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::selectionChanged): Ditto.

accessibility/atspi/AccessibilityObjectTextAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::textInserted): Ditto.
(WebCore::AccessibilityObjectAtspi::textDeleted): Ditto.
(WebCore::AccessibilityObjectAtspi::selectionChanged): Ditto.
(WebCore::AccessibilityObjectAtspi::textAttributesChanged): Ditto.

accessibility/atspi/AccessibilityObjectValueAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::valueChanged): Ditto.

accessibility/atspi/AccessibilityRootAtspi.cpp:

(WebCore::AccessibilityRootAtspi::embedded): Register the tree if there are event listeners registered.

Tools:

Add unit test to check the tree is created when there's a listener connected.

TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(AccessibilityTest::findTestApplication): Iterate the applications list backwards since the test program is
usually the last one in the list.
(AccessibilityTest::accessibleApplicationIsTestProgram): Helper to check if a given accessible belongs to the
test program.
(AccessibilityTest::startEventMonitor): Support for listening to events associated to the test program, not to a
particular accessible.
(testAccessibleEventListener):
(beforeAll):

2:16 AM Changeset in webkit [287069] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[iOS][WP] Add access to required syscall
https://bugs.webkit.org/show_bug.cgi?id=234336
<rdar://86502081>

Reviewed by Tim Horton.

Add required syscall to the WebContent process' sandbox on iOS. This syscall was blocked in
https://trac.webkit.org/changeset/286673/webkit.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

1:43 AM Changeset in webkit [287068] by Kyle Piddington

222 edits
10 adds
3 deletes in trunk/Source/ThirdParty/ANGLE

[ANGLE] Roll ANGLE to 12-14-2021 (5ee7dfbd5a3)
https://bugs.webkit.org/show_bug.cgi?id=234317

Reviewed by Kenneth Russell.

Roll ANGLE to 12-14-2021 to include new memory-attribution
Metal device, merge up fixes, EAC/ ASTC support on M1

The changelog has been removed to promote readability

1:36 AM Changeset in webkit [287067] by youenn@apple.com

3 edits
2 adds in trunk

Make sure to start a realtime outgoing source in case it is taken to another sender
https://bugs.webkit.org/show_bug.cgi?id=234296
<rdar://86276497>

Reviewed by Eric Carlson.

Source/WebCore:

We are asynchronously starting libwebrtc sources.
When a sender is created first and is assigned a source later, we take the source and assign it to the sender.
In that case, the source might not be started and we will not send any data.

Test: webrtc/addTransceiver-then-addTrack.html

Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

LayoutTests:

webrtc/addTransceiver-then-addTrack-expected.txt: Added.
webrtc/addTransceiver-then-addTrack.html: Added.

1:16 AM Changeset in webkit [287066] by graouts@webkit.org

25 edits in trunk/Source/WebCore

ActiveDOMObject::suspendIfNeeded() should not be called within constructors
https://bugs.webkit.org/show_bug.cgi?id=233945

Reviewed by Chris Dumez and Darin Adler.

Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):

Modules/applepay/ApplePaySetup.cpp:

(WebCore::ApplePaySetup::create):
(WebCore::ApplePaySetup::ApplePaySetup):

Modules/applepay/ApplePaySetupWebCore.h:

(WebCore::ApplePaySetup::create): Deleted.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::create):
(WebCore::DOMCache::DOMCache):

Modules/cache/DOMCache.h:
Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::create):
(WebCore::DOMCacheStorage::DOMCacheStorage):

Modules/cache/DOMCacheStorage.h:

(WebCore::DOMCacheStorage::create): Deleted.

Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::create):
(WebCore::FileSystemDirectoryReader::FileSystemDirectoryReader):

Modules/entriesapi/FileSystemDirectoryReader.h:
Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp:

(WebCore::FileSystemSyncAccessHandle::create):
(WebCore::FileSystemSyncAccessHandle::FileSystemSyncAccessHandle):

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::create):

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):

Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::create):
(WebCore::RemotePlayback::RemotePlayback):

Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):

Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::create):
(WebCore::WebXRSession::WebXRSession):

Modules/webxr/WebXRSystem.cpp:

(WebCore::WebXRSystem::create):
(WebCore::WebXRSystem::WebXRSystem):

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::create):
(WebCore::m_version):

css/CSSFontSelector.h:
dom/MessagePort.cpp:

(WebCore::MessagePort::create):
(WebCore::MessagePort::MessagePort):

workers/WorkerAnimationController.cpp:

(WebCore::WorkerAnimationController::create):
(WebCore::WorkerAnimationController::WorkerAnimationController):

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):

workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::getOrCreate):
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):

1:09 AM Changeset in webkit [287065] by Diego Pino Garcia

2 edits in trunk/Source/WebCore

[GTK][WPE] Build fix for Debian Stable after r287015
https://bugs.webkit.org/show_bug.cgi?id=234332

Reviewed by Ryosuke Niwa.

Modules/push-api/PushMessageCrypto.cpp:

(WebCore::PushCrypto::decryptAES128GCMPayload):
(WebCore::PushCrypto::decryptAESGCMPayload):

1:03 AM Changeset in webkit [287064] by svillar@igalia.com

4 edits in trunk

[css-flexbox] Absolutely positioned children should be aligned using the margin box
https://bugs.webkit.org/show_bug.cgi?id=234244

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

web-platform-tests/css/css-flexbox/abspos/position-absolute-014-expected.txt: Replaced FAIL

by PASS expectations.

Source/WebCore:

When aligning absolutely positioned children we must use the child's margin box. We were
using the border box instead, and thus ignoring margins when aligning absolutely positioned
flexbox children.

This fixes position-absolute-014.html from the WPT suite.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Removed the !isOutOfFlowPositioned()
ASSERT. It's true that in the past it was called only from code dealing with flex items but the code
implementing the function does not really have that restriction at all.
(WebCore::RenderFlexibleBox::staticCrossAxisPositionForPositionedChild): Directly call
availableAlignmentSpaceForChild() as it already uses the margin box.

Dec 14, 2021:

10:53 PM Changeset in webkit [287063] by jh718.park@samsung.com

11 edits
2 adds in trunk

Fix that height is calculated incorrectly when using display:table, box-sizing:border-box and padding.
https://bugs.webkit.org/show_bug.cgi?id=196175

Reviewed by Darin Adler.

Currently, box sizing type check is missing, so the height of display:table element's percent height child
is subtracted by its border and padding even when its 'box-sizing' is not 'content-box'.

This patch adds the missing box sizing type check.

LayoutTests/imported/w3c:

web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html: Added.
web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html: Added.

Source/WebCore:

Test: imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight const):

LayoutTests:

platform/gtk/fast/table/003-expected.txt:
platform/gtk/tables/mozilla/bugs/bug30692-expected.txt:
platform/ios/tables/mozilla/bugs/bug30692-expected.txt:
platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt:
platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt:
platform/mac/fast/table/003-expected.txt:
platform/mac/tables/mozilla/bugs/bug30692-expected.txt:

9:44 PM Changeset in webkit [287062] by Alan Bujtas

2 edits in trunk/Source/WebCore

[IFC][Integration] Use logical margin/border/padding values in layout
https://bugs.webkit.org/show_bug.cgi?id=234305

Reviewed by Antti Koivisto.

Can't use RenderBoxModelObject::borderStart/End logical values as they return values based on the _renderer_'s
direction and not the direction the renderer is aligned within.

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions):

7:28 PM Changeset in webkit [287061] by Russell Epstein

261 edits in branches/safari-613.1.12-branch

Revert "Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability"

This reverts commit r286937.

7:00 PM Changeset in webkit [287060] by don.olmstead@sony.com

11 edits
1 add in trunk/Tools

[CMake] Modernize WPEToolingBackend
https://bugs.webkit.org/show_bug.cgi?id=234307

Reviewed by Adrian Perez de Castro.

Use WEBKIT_FRAMEWORK to build WPEToolingBackend and follow its conventions. Also support
different platform definitions so other ports using libwpe can also use this library.

Update includes to use <WPEToolingBackend/*.h>.

MiniBrowser/wpe/CMakeLists.txt:
MiniBrowser/wpe/main.cpp:
TestWebKitAPI/PlatformWPE.cmake:
TestWebKitAPI/glib/PlatformWPE.cmake:
TestWebKitAPI/glib/WebKitGLib/TestMain.h:
TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
WebKitTestRunner/PlatformWPE.cmake:
WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
wpe/backends/CMakeLists.txt:
wpe/backends/PlatformWPE.cmake: Added.

5:25 PM Changeset in webkit [287059] by Jean-Yves Avenard

14 edits in trunk/Source

Source/WebCore:
SourceBufferParser should be using contiguous SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=233865
rdar://problem/86085253

Reviewed by Eric Carlson.

The SharedBuffer sent to the SourceBufferParser can only ever contain one
DataSegment and we had assertions to that effect. The SharedBuffer class
type now guarantees how the data is structured and allow for more explicit
code which improves readability.
We also had some workarounds for the fact that SharedBuffer didn't use
thread-safe refcounting and instead we referenced the inner DataSegment.
This can be removed.

Covered by existing tests, no observable differences.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired):

Modules/mediasource/SourceBuffer.h:
platform/audio/cocoa/AudioFileReaderCocoa.cpp:
platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::append):

platform/graphics/SourceBufferPrivate.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::append):

platform/graphics/cocoa/SourceBufferParser.cpp:

(WebCore::SourceBufferParser::Segment::Segment):
(WebCore::SourceBufferParser::Segment::size const):
(WebCore::SourceBufferParser::Segment::read const):
(WebCore::SourceBufferParser::Segment::takeSharedBuffer):
(WebCore::SourceBufferParser::Segment::getSharedBuffer const):

platform/graphics/cocoa/SourceBufferParser.h:
platform/graphics/cocoa/SourceBufferParserWebM.cpp:

Source/WebKit:
SourceBufferParser should be using contiguous shared buffer
https://bugs.webkit.org/show_bug.cgi?id=233865
rdar://problem/86085253

Reviewed by Eric Carlson.

WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::append):

WebProcess/GPU/media/SourceBufferPrivateRemote.h:

5:23 PM Changeset in webkit [287058] by Ross Kirsling

9 edits in trunk/Source/JavaScriptCore

[JSC] OpInstanceofCustom should be in CommonSlowPaths
https://bugs.webkit.org/show_bug.cgi?id=234316

Reviewed by Alexey Shvayka.

No tier has a fast path for OpInstanceofCustom and this is unlikely to change anytime soon.
As such, we should not be having LLInt and Baseline implement *separate* slow paths for this operation;
this patch straightforwardly makes use of CommonSlowPaths instead.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof_custom): Deleted.
(JSC::JIT::emitSlow_op_instanceof_custom): Deleted.

llint/LLIntSlowPaths.cpp:
llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

runtime/CommonSlowPaths.h:

4:46 PM Changeset in webkit [287057] by Ryan Haddad

3 edits in trunk/Tools

Bring up another iOS GPU Processes tester
https://bugs.webkit.org/show_bug.cgi?id=234016

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/config.json: Put the Catalina GPUP bot back and

use a different machine for the new iOS tester.

CISupport/build-webkit-org/factories_unittest.py: Update unit tests.

(TestExpectedBuildSteps):

3:48 PM Changeset in webkit [287056] by commit-queue@webkit.org

8 edits in trunk

Remove properties set by NSURLProtocol on NSURLRequest before serializing
https://bugs.webkit.org/show_bug.cgi?id=232332
<rdar://79227845>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-14
Reviewed by Geoff Garen.

Source/WebCore/PAL:

pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

NSURLRequest encodeWithCoder: encodes the protocol properties, which are not used by WebKit.
They exist to be used by NSURLProtocol. Serializing them can serialize a large amount of data,
so to be more efficient and hopefully run out of memory less, remove the properties before serializing.

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ResourceRequest>::encodePlatformData):

Source/WTF:

wtf/PlatformHave.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:

(TestWebKitAPI::TEST):

3:31 PM Changeset in webkit [287055] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION (r286982): ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType]
https://bugs.webkit.org/show_bug.cgi?id=234315

Unreviewed test gardening.

TestExpectations: Skip the test.

3:09 PM Changeset in webkit [287054] by Jonathan Bedard

4 edits in trunk/Tools

[reporelaypy] Update checkout with hook instead of polling (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=234243
<rdar://problem/86413065>

Unreviewed follow-up fix.

Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
Scripts/libraries/reporelaypy/reporelaypy/checkout.py:

(Checkout.update_for): main is not a recognized production branch, so handle
default branch first.

Scripts/libraries/reporelaypy/setup.py: Bump version.

3:04 PM Changeset in webkit [287053] by Jean-Yves Avenard

5 edits in trunk/Source/WebCore

Make PreviewConverterProvider not modify the SharedBuffer once returned
https://bugs.webkit.org/show_bug.cgi?id=233923
rdar://problem/86149850

Reviewed by Youenn Fablet.

Covered by existing API tests.

loader/ios/LegacyPreviewLoader.h:
loader/ios/LegacyPreviewLoader.mm:

(WebCore::LegacyPreviewLoader::previewConverterDidStartConverting):
(WebCore::LegacyPreviewLoader::provideMainResourceForPreviewConverter):

platform/PreviewConverter.cpp:

(WebCore::PreviewConverter::updateMainResource):

platform/PreviewConverterProvider.h:

3:00 PM Changeset in webkit [287052] by Alan Coon

1 copy in tags/Safari-612.4.4

Tag Safari-612.4.4.

2:38 PM Changeset in webkit [287051] by basuke.suzuki@sony.com

2 edits in trunk/Source/WebCore

[Playstation] Fix build break after r286908
https://bugs.webkit.org/show_bug.cgi?id=234311

Unreviewed, build fix for PlayStation platform after r286908.
https://trac.webkit.org/changeset/286908/webkit

platform/graphics/PlatformVideoColorSpace.h:

2:36 PM Changeset in webkit [287050] by jer.noble@apple.com

3 edits
2 adds in trunk

Safari intermittently stopping playing Spotify Web Player (currentTime goes backwards)
https://bugs.webkit.org/show_bug.cgi?id=233257
<rdar://problem/85504967>

Reviewed by Eric Carlson.

Source/WebKit:

Test: media/video-currentTime-duration.html

Clamp currentMediaTime() to [0, durationMediaTime()].

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::currentMediaTime const):

LayoutTests:

media/video-currentTime-duration-expected.txt: Added.
media/video-currentTime-duration.html: Added.

2:20 PM Changeset in webkit [287049] by commit-queue@webkit.org

8 edits in trunk

Revert r284816
https://bugs.webkit.org/show_bug.cgi?id=234308
LayoutTests/imported/w3c:

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-14
Reviewed by Eric Carlson.

web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https-expected.txt:

Source/WebCore:

<rdar://86294293>

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-14
Reviewed by Eric Carlson.

I made it so that resources without a Content-Length header wait until the whole resource finishes downloading
then we deliver it to CoreMedia to play with a known length. This works great, except it completely breaks
live streaming, which would just wait forever. Back to the status quo. We need to convince CoreMedia to accept
byte ranges with an unknown end to fix videos such as our test video when hosted by trac, which has no Content-Length at
https://trac.webkit.org/export/284633/webkit/trunk/Tools/TestWebKitAPI/Tests/WebKit/test.mp4

platform/network/cocoa/RangeResponseGenerator.mm:

(WebCore::synthesizedResponseForRange):
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):

Source/WebKit:

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-14
Reviewed by Eric Carlson.

UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::seekableRangesVectorChanged):

Tools:

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-14
Reviewed by Eric Carlson.

TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST):

2:15 PM Changeset in webkit [287048] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Adhere to DisplayList iterator's API contract in MemoryDisplayList::~InMemoryDisplayList()
https://bugs.webkit.org/show_bug.cgi?id=234264

Patch by Gabriel Nava Marino <gnavamarino@apple.com> on 2021-12-14
Reviewed by Myles C. Maxfield.

The client is not adhearing to the DisplayList Iterator's API contract in MemoryDisplayList::~InMemoryDisplayList():
"Part of the iterator's API contract is that if the item is nullopt, you're not allowed to keep
iterating - doing this will lead to an infinite loop."

Here we now do so by breaking out of iteration if the item is nullopt.

platform/graphics/displaylists/InMemoryDisplayList.cpp:

(WebCore::DisplayList::InMemoryDisplayList::~InMemoryDisplayList):

2:10 PM Changeset in webkit [287047] by Alan Bujtas

13 edits in trunk/Source/WebCore

[LFC] Let BoxGeometry have logical values only
https://bugs.webkit.org/show_bug.cgi?id=234304

Reviewed by Antti Koivisto.

This helps when converting logical (layout) values to physical (display) values.

display/css/DisplayFillLayerImageGeometry.cpp:

(WebCore::Display::geometryForLayer):

layout/formattingContexts/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

layout/formattingContexts/FormattingGeometry.cpp:

(WebCore::Layout::FormattingGeometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingGeometry::outOfFlowNonReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingGeometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingGeometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingGeometry::computedPadding const):

layout/formattingContexts/FormattingQuirks.cpp:

(WebCore::Layout::FormattingQuirks::heightValueOfNearestContainingBlockWithFixedHeight const):

layout/formattingContexts/block/BlockFormattingGeometry.cpp:

(WebCore::Layout::BlockFormattingGeometry::inFlowNonReplacedContentHeightAndMargin const):
(WebCore::Layout::BlockFormattingGeometry::inFlowNonReplacedContentWidthAndMargin const):

layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::addBorderAndPaddingEndForInlineBoxDecorationClone):

layout/formattingContexts/inline/InlineLineBox.cpp:

(WebCore::Layout::LineBox::logicalBorderBoxForInlineBox const):

layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::LineBoxBuilder::constructAndAlignInlineLevelBoxes):

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::inlineItemWidth const):

layout/formattingContexts/table/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):

layout/layouttree/LayoutBoxGeometry.cpp:

(WebCore::Layout::BoxGeometry::paddingBox const):

layout/layouttree/LayoutBoxGeometry.h:

(WebCore::Layout::BoxGeometry::verticalBorder const):
(WebCore::Layout::BoxGeometry::horizontalBorder const):
(WebCore::Layout::BoxGeometry::borderAndPaddingStart const):
(WebCore::Layout::BoxGeometry::borderAndPaddingEnd const):
(WebCore::Layout::BoxGeometry::contentBoxTop const):
(WebCore::Layout::BoxGeometry::contentBoxLeft const):
(WebCore::Layout::BoxGeometry::paddingBoxTop const):
(WebCore::Layout::BoxGeometry::paddingBoxLeft const):
(WebCore::Layout::BoxGeometry::paddingBoxHeight const):
(WebCore::Layout::BoxGeometry::paddingBoxWidth const):
(WebCore::Layout::BoxGeometry::borderBoxHeight const):
(WebCore::Layout::BoxGeometry::borderBoxWidth const):
(WebCore::Layout::BoxGeometry::paddingBefore const):
(WebCore::Layout::BoxGeometry::paddingStart const):
(WebCore::Layout::BoxGeometry::paddingAfter const):
(WebCore::Layout::BoxGeometry::paddingEnd const):
(WebCore::Layout::BoxGeometry::verticalPadding const):
(WebCore::Layout::BoxGeometry::horizontalPadding const):
(WebCore::Layout::BoxGeometry::borderBefore const):
(WebCore::Layout::BoxGeometry::borderStart const):
(WebCore::Layout::BoxGeometry::borderAfter const):
(WebCore::Layout::BoxGeometry::borderEnd const):
(WebCore::Layout::BoxGeometry::paddingTop const): Deleted.
(WebCore::Layout::BoxGeometry::paddingLeft const): Deleted.
(WebCore::Layout::BoxGeometry::paddingBottom const): Deleted.
(WebCore::Layout::BoxGeometry::paddingRight const): Deleted.
(WebCore::Layout::BoxGeometry::borderTop const): Deleted.
(WebCore::Layout::BoxGeometry::borderLeft const): Deleted.
(WebCore::Layout::BoxGeometry::borderBottom const): Deleted.
(WebCore::Layout::BoxGeometry::borderRight const): Deleted.

2:04 PM Changeset in webkit [287046] by Patrick Angle

2 edits in trunk/Source/WebCore

Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text
https://bugs.webkit.org/show_bug.cgi?id=234012

Reviewed by Devin Rousso.

Covered by existing test: LayoutTests/inspector/css/getMatchedStylesForNodeLayerGrouping.html

For anonymous layers, we should not provide the text property to the frontend, as there is technically no
text, not an empty string, provided by the author. This is effectively a minor optimization, as the frontend
does correctly handle an empty string the same way it handles no string.

inspector/InspectorStyleSheet.cpp:

(WebCore::buildArrayForGroupings):

1:31 PM Changeset in webkit [287045] by Jonathan Bedard

7 edits
2 adds in trunk/Tools

[reporelaypy] Update checkout with hook instead of polling
https://bugs.webkit.org/show_bug.cgi?id=234243
<rdar://problem/86413065>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version,

export HookProcessor and HookReceiver.

Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:

(Checkout.update_for): If a branch is new, we need to track it.

Tools/Scripts/libraries/reporelaypy/reporelaypy/database.py:

(Database.init): Use self.host and self.password.

Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py: Added.

(HookProcessor): Class to process received hooks.
(HookReceiver): Class to receive hooks and queue them for processing.

Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/hooks_unittest.py: Added.

(HooksUnittest):
(HooksUnittest.setUp):
(HooksUnittest.test_receive):
(HooksUnittest.test_invalid):
(HooksUnittest.test_process):
(HooksUnittest.test_hmac):
(HooksUnittest.test_invalid_hmac):

Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py: Add hook routes,

if hooks are enabled.

Tools/Scripts/libraries/reporelaypy/run: Allow caller to enable hooks.
Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.

Canonical link: https://commits.webkit.org/245242@main

1:16 PM Changeset in webkit [287044] by Russell Epstein

4 edits in branches/safari-613.1.12-branch/Source/ThirdParty/ANGLE

Cherry-pick r286964. rdar://problem/86413146

[MacCatalyst] fix iOSMac after refactor in r286899
https://bugs.webkit.org/show_bug.cgi?id=234250

Reviewed by Dean Jackson.

Also includes a longer term fix for
https://bugs.webkit.org/show_bug.cgi?id=233977

Tested builds on mac, iOS, TV SDKs, plus iOSMac

src/common/platform.h:
src/libANGLE/renderer/metal/gen_mtl_format_table.py: (gen_image_map_switch_string):
src/libANGLE/renderer/metal/mtl_format_table_autogen.mm: (rx::mtl::Format::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:57 PM Changeset in webkit [287043] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Take text-align offset into account when computing the RTL display box geometry
https://bugs.webkit.org/show_bug.cgi?id=234287

Reviewed by Antti Koivisto.

Use LineBox::rootInlineBoxAlignmentOffset to offset the visual start position for RTL display boxes.

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

12:23 PM Changeset in webkit [287042] by Russell Epstein

2 edits in branches/safari-613.1.12-branch/Source/WebCore

Cherry-pick r287011. rdar://problem/86438924

WebContent process crashes at ContentSecurityPolicySourceList::matchesAll
https://bugs.webkit.org/show_bug.cgi?id=234288
rdar://problem/86438924

Reviewed by Simon Fraser.

page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:11 PM Changeset in webkit [287041] by Russell Epstein

9 edits in trunk/Source

Versioning.

WebKit-7613.1.13

12:11 PM Changeset in webkit [287040] by achristensen@apple.com

13 edits in trunk

Add _WKContentRuleListAction.redirected and .modifiedHeaders
https://bugs.webkit.org/show_bug.cgi?id=234289

Reviewed by Tim Hatcher.

Source/WebCore:

These inform the UI process about new actions taken by the extension.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
(WebCore::ContentExtensions::applyResultsToRequest):

contentextensions/ContentRuleListResults.h:

(WebCore::ContentRuleListResults::shouldNotifyApplication const):
(WebCore::ContentRuleListResults::Result::encode const):
(WebCore::ContentRuleListResults::Result::decode):
(WebCore::ContentRuleListResults::Result::shouldNotifyApplication const): Deleted.

Source/WebKit:

UIProcess/API/APIContentRuleListAction.cpp:

(API::ContentRuleListAction::redirected const):
(API::ContentRuleListAction::modifiedHeaders const):

UIProcess/API/APIContentRuleListAction.h:
UIProcess/API/Cocoa/_WKContentRuleListAction.h:
UIProcess/API/Cocoa/_WKContentRuleListAction.mm:

(-[_WKContentRuleListAction redirected]):
(-[_WKContentRuleListAction modifiedHeaders]):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentRuleListNotification):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:

(checkURLs):
(TEST_F):

TestWebKitAPI/cocoa/TestNavigationDelegate.h:
TestWebKitAPI/cocoa/TestNavigationDelegate.mm:

(-[TestNavigationDelegate _webView:contentRuleListWithIdentifier:performedAction:forURL:]):

12:06 PM Changeset in webkit [287039] by achristensen@apple.com

15 edits in trunk

Move FTP disabling from NetworkLoad::start to NetworkDataTask::NetworkDataTask
https://bugs.webkit.org/show_bug.cgi?id=234280
Source/WebKit:

<rdar://85015428>

Reviewed by Brady Eidson.

A NetworkLoad synchronously failing has caused several issues.
This issue is when a WKDownload is prevented in this way, we don't have a WKDownload in the UI process yet,
and we haven't assigned it an identifier in the network process yet either, so we dereference null and send
unreceived messages in many places. To fix this issue, I move the FTP check to the NetworkDataTask constructor
like we do with blocked port checks and invalid URL checks. I also found that there is a race condition with
CFNetwork also failing to load an empty FTP URL, so we need to prevent us from asking CFNetwork to start a load
for which we have scheduled a failure.

Covered by an API test which used to hit all the horrible failures and now passes reliably.

NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::wasBlockedByDisabledFTP):

NetworkProcess/NetworkCORSPreflightChecker.h:
NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::scheduleFailure):

NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::start):
(WebKit::NetworkLoad::wasBlockedByDisabledFTP):

NetworkProcess/NetworkLoad.h:
NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::wasBlockedByDisabledFTP):

NetworkProcess/PingLoad.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::resume):

Shared/WebErrors.cpp:

(WebKit::ftpDisabledError):

Shared/WebErrors.h:

Tools:

Reviewed by Brady Eidson.

TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

11:59 AM Changeset in webkit [287038] by Tyler Wilcock

6 edits
2 adds in trunk

Web Inspector: test webpage keeps reloading when Inspector is open
https://bugs.webkit.org/show_bug.cgi?id=234076

Reviewed by Chris Fleizach.

Source/WebCore:

https://trac.webkit.org/changeset/284335/webkit introduced the
potential for infinite recursion in AccessibilityObjectMac::shouldIgnoreGroup:

From accessibilityIsIgnored to computeAccessibilityIsIgnored to
defaultObjectInclusion to accessibilityPlatformIncludesObject to
shouldIgnoreGroup to accessibilityText to titleElementText to
exposesTitleUIElement to accessibilityIsIgnored to ...

shouldIgnoreGroup returns true if the group has one static text
child with the same content as the group's AX text. We fix the
recursion by making this check more conservative.

Rather than checking all of the AX text (which includes title text, alt text, help text,
visible text, placeholder text), only check the group's alt text and help text. This
accomplishes the original problem statement laid out in
https://bugs.webkit.org/show_bug.cgi?id=169924#c0 while avoiding
infinite recursion, as nothing in AccessibilityNodeObject::alternativeText or
AccessibilityNodeObject::helpText calls accessibilityIsIgnored.

Test: accessibility/mac/ignore-redundant-groups-crash.html

accessibility/AccessibilityNodeObject.h:

Move alternativeText and helpText method definitions from private to public
so they can be called by the static shouldIgnoreGroup method in AccessibilityObjectMac.

accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::shouldIgnoreGroup):
Check only alt text and help text rather than all
AX text when deciding if a group should be ignored.

LayoutTests:

This patch fixes the potential for infinite recursion introduced by
https://trac.webkit.org/changeset/284335/webkit. See corresponding
Source/WebCore/ChangeLog for full details.

accessibility/mac/ignore-redundant-accessibility-text-groups-expected.txt:
accessibility/mac/ignore-redundant-accessibility-text-groups.html:

Add an aria-describedby testcase.

accessibility/mac/ignore-redundant-groups-crash-expected.txt: Added.
accessibility/mac/ignore-redundant-groups-crash.html:

Added. Exercises the crash testcase raised in
https://bugs.webkit.org/show_bug.cgi?id=234076 along with other
branches in AccessibilityNodeObject::alternativeText to prevent future
problems.

11:48 AM Changeset in webkit [287037] by Russell Epstein

1 copy in branches/safari-613.1.12-branch

New branch.

11:45 AM Changeset in webkit [287036] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Take inline axis direction into account when computing horizontal alignment offset
https://bugs.webkit.org/show_bug.cgi?id=234286

Reviewed by Antti Koivisto.

This is in preparation for computing the content visual start when text-align is non-initial.

layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):

11:33 AM Changeset in webkit [287035] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the build

Configurations/webpushtool.xcconfig:

11:23 AM Changeset in webkit [287034] by Megan Gardner

2 edits in trunk/Source/WebKit

Attachment does not update after markup.
https://bugs.webkit.org/show_bug.cgi?id=234266

Reviewed by Wenson Hsieh.

If we don't call the deligate to inform Mail about the new attachment data,
it will not update and the original image will be sent.

UIProcess/mac/WKSharingServicePickerDelegate.mm:

(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):

11:05 AM Changeset in webkit [287033] by Russell Epstein

1 copy in tags/Safari-613.1.11.6

Tag Safari-613.1.11.6.

11:01 AM Changeset in webkit [287032] by Russell Epstein

9 edits in branches/safari-613.1.11-branch/Source

Versioning.

WebKit-7613.1.11.6

10:30 AM Changeset in webkit [287031] by Alan Coon

3 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r286999. rdar://problem/86425321

Momentum Event Dispatcher: Excessive "kick" at the beginning of scrolling (especially on 60fps displays)
https://bugs.webkit.org/show_bug.cgi?id=234279
<rdar://problem/86425321>

Reviewed by Simon Fraser.

WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::handleWheelEvent): (WebKit::MomentumEventDispatcher::didStartMomentumPhase): Instead of back-dating the animation to try to acquire a momentum-start delta, pass the one we got from the event through, and start the animation curve at momentum-start time. Also, critically, inset ourselves along the curve by the amount of that initial delta (since the time starts now).

Tested at both 60fps and 120fps, this significantly smooths out the
transition from fingers-down phase to the generated momentum phase,
avoiding the overly large initial delta.

WebProcess/WebPage/MomentumEventDispatcher.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [287030] by dino@apple.com

16 edits
1 add in trunk

Allow override of system's preferred color scheme
https://bugs.webkit.org/show_bug.cgi?id=234199
<rdar://problem/86366044>

Reviewed by Tim Horton.

Source/WebCore:

Use a user-specified preference for color-scheme before reading
the system value.

css/MediaQueryEvaluator.cpp:

(WebCore::prefersColorSchemeEvaluate): If the document loader was given
a preference, use that when evaluating the media query.

loader/DocumentLoader.cpp: New property - colorSchemePreference.

(WebCore::DocumentLoader::colorSchemePreference const):

loader/DocumentLoader.h:

(WebCore::DocumentLoader::setColorSchemePreference):

dom/Document.cpp:

(WebCore::Document::useDarkAppearance const): Check the DocumentLoader here too.

Source/WebKit:

Expose new Private API that allows the user to give an explicit per-page preference
for light or dark color schemes rather than reading the system value.

Scripts/webkit/messages.py:

(headers_for_type): Add header for DocumentLoader.

Shared/WebsitePoliciesData.cpp: Encode the new value in the policies sent

to the Web Process.
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

Shared/WebsitePoliciesData.h:

UIProcess/API/APIWebsitePolicies.cpp: Expose a new policy "colorSchemePreference".

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

UIProcess/API/APIWebsitePolicies.h:

UIProcess/API/Cocoa/WKWebpagePreferences.mm: Expose a new private API "_colorSchemePreference".

(-[WKWebpagePreferences _colorSchemePreference]):
(-[WKWebpagePreferences _setColorSchemePreference:]):

UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:

Tools:

New API test that checks the color-scheme after
explicitly setting it.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/color-scheme.html: Added. Note: Xcode was

being difficult and wouldn't let me put this file in the right order
for the Copy Build Phase :(

TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

10:03 AM Changeset in webkit [287029] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add test case for execCommand to verify inserting an ordered list and deletion
https://bugs.webkit.org/show_bug.cgi?id=234113
<rdar://85926354>

Patch by Brandon Stewart <Brandon> on 2021-12-14
Reviewed by Chris Dumez.

Add test to verify correct execution of execCommand when inserting an ordered
list and calling delete.

editing/execCommand/insert-ordered-list-and-delete-expected.txt: Added.
editing/execCommand/insert-ordered-list-and-delete.html: Added.

9:20 AM Changeset in webkit [287028] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC][IFC] Make the LineBox content (text runs and inline level boxes) relative to the root inline box.
https://bugs.webkit.org/show_bug.cgi?id=234285

Reviewed by Antti Koivisto.

Let's decouple the root inline box's logical left and the text-align based horizontal offset and
also make the content inside the root inline box relative to it.
This is in preparation for handling text-align with non-RTL content.

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

layout/formattingContexts/inline/InlineLineBox.cpp:

(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::LineBox::logicalRectForTextRun const):

layout/formattingContexts/inline/InlineLineBox.h:

(WebCore::Layout::LineBox::rootInlineBoxAlignmentOffset const):

layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::LineBoxBuilder::build):

9:05 AM Changeset in webkit [287027] by Russell Epstein

1 copy in tags/Safari-613.1.11.5

Tag Safari-613.1.11.5.

9:05 AM Changeset in webkit [287026] by Russell Epstein

1 delete in tags/Safari-613.1.11.5

Delete tag.

8:43 AM Changeset in webkit [287025] by Angelos Oikonomopoulos

2 edits in trunk/Tools

[JSC] Fix LocalJumpError in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=234295

Reviewed by Michael Catanzaro.

Ruby code cannot return from a Proc; use an if/else instead. This fixes
the LocalJumpError reported in https://bugs.webkit.org/show_bug.cgi?id=233926.

Scripts/run-jsc-stress-tests:

8:29 AM Changeset in webkit [287024] by commit-queue@webkit.org

7 edits in trunk

TextDecoder doesn't detect invalid UTF-8 sequences early enough
https://bugs.webkit.org/show_bug.cgi?id=233921

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-12-14
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT tests from
https://github.com/web-platform-tests/wpt/pull/31537.

web-platform-tests/encoding/textdecoder-eof.any.js:

(test):

web-platform-tests/encoding/textdecoder-streaming.any-expected.txt:
web-platform-tests/encoding/textdecoder-streaming.any.js:

(string_appeared_here.forEach.):
(string_appeared_here.forEach.test):
(string_appeared_here.forEach):

web-platform-tests/encoding/textdecoder-streaming.any.worker-expected.txt:

Source/WebCore/PAL:

In streaming mode, when TextCodecUTF8 found a lead byte for which a
valid sequence would span longer than the currently available bytes, it
used to defer any processing of that sequence until all such bytes were
available, even if errors could be detected earlier. Additionally, if
the stream was flushed at that point, it would emit a single replacement
character, regardless of whether the remaining bytes formed a valid
sequence, even if they had lead bytes, resulting in skipped characters.
Both issues are solved by always checking the validity of partial
sequences.

The approach used in this patch uses decodeNonASCIISequence to find
the length of the maximal subpart of a partial sequence, and if the
length is equal to the partial sequence size and we're not at EOF, we
don't emit the error. This is enough to handle the missing characters at
EOF, and when combined with changing the condition of the outer do-while
loops in the decode method from flush && m_partialSequenceSize to
only m_partialSequenceSize, it also fixes the streaming issue.

This patch is a port of
https://chromium-review.googlesource.com/c/chromium/src/+/3263938

Tests: imported/w3c/web-platform-tests/encoding/textdecoder-eof.any.html

imported/w3c/web-platform-tests/encoding/textdecoder-stream.any.html

pal/text/TextCodecUTF8.cpp:

(PAL::TextCodecUTF8::handlePartialSequence): Changed to always process
partial sequences.
(PAL::TextCodecUTF8::decode): Changed the loop condition of the outer
do-while loops to not depend on flush.

8:20 AM Changeset in webkit [287023] by commit-queue@webkit.org

3 edits
2 adds in trunk

Incorrect aspect ratio size
https://bugs.webkit.org/show_bug.cgi?id=234148

Patch by Rob Buis <rbuis@igalia.com> on 2021-12-14
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-036-expected.xht: Added.
web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-036.html: Added.

Source/WebCore:

We previously did a LayoutUnit conversion for the aspect ratio parameter, possibly because
blockSizeFromAspectRatio/inlineSizeFromAspectRatio changed the parameter type over time.
Since this conversion loses precision, just pass as double.

Test: imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-036.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::computeLogicalWidthFromAspectRatioInternal const):
(WebCore::RenderBox::computeMinMaxLogicalWidthFromAspectRatio const):

7:49 AM Changeset in webkit [287022] by Razvan Caliman

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Computed Panel: Adjust color of CSS Variables grouping mode control
https://bugs.webkit.org/show_bug.cgi?id=234246
<rdar://problem/86414682>

Reviewed by Devin Rousso.

Change color of CSS variables grouping mode scope bar from the system accent color to transparent
so it doesn't draw disproportionate attention to itself.

UserInterface/Views/ComputedStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .scope-bar.computed-style-variables-grouping-mode:not(:hover)):
(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .scope-bar.computed-style-variables-grouping-mode.default-item-selected:not(:hover)): Deleted.
(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .scope-bar.computed-style-variables-grouping-mode.default-item-selected:hover): Deleted.

2:48 AM Changeset in webkit [287021] by Jean-Yves Avenard

498 edits in trunk

PerformanceTests:
Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability: part 3
https://bugs.webkit.org/show_bug.cgi?id=233677

Reviewed by Youenn Fablet.

DecoderTest/DecoderTest/main.mm:

(main):

Source/JavaScriptCore:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

runtime/ArrayBuffer.h:

Source/WebCore:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

Rename only, no change in behaviour.

Modules/async-clipboard/ClipboardImageReader.cpp:
Modules/async-clipboard/ClipboardImageReader.h:
Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:
Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:
Modules/cache/CacheStorageConnection.cpp:
Modules/cache/DOMCache.cpp:
Modules/cache/DOMCache.h:
Modules/cache/DOMCacheEngine.cpp:
Modules/cache/DOMCacheEngine.h:
Modules/encryptedmedia/CDM.cpp:
Modules/encryptedmedia/CDM.h:
Modules/encryptedmedia/CDMClient.h:
Modules/encryptedmedia/InitDataRegistry.cpp:
Modules/encryptedmedia/InitDataRegistry.h:
Modules/encryptedmedia/MediaKeySession.cpp:
Modules/encryptedmedia/MediaKeySession.h:
Modules/encryptedmedia/MediaKeyStatusMap.cpp:
Modules/encryptedmedia/MediaKeyStatusMap.h:
Modules/encryptedmedia/MediaKeys.cpp:
Modules/encryptedmedia/MediaKeys.h:
Modules/fetch/FetchBody.cpp:
Modules/fetch/FetchBody.h:
Modules/fetch/FetchBodyConsumer.cpp:
Modules/fetch/FetchBodyConsumer.h:
Modules/fetch/FetchLoader.cpp:
Modules/fetch/FetchLoader.h:
Modules/fetch/FetchResponse.cpp:
Modules/fetch/FetchResponse.h:
Modules/highlight/AppHighlight.h:
Modules/highlight/AppHighlightRangeData.cpp:
Modules/highlight/AppHighlightRangeData.h:
Modules/highlight/AppHighlightStorage.cpp:
Modules/highlight/AppHighlightStorage.h:
Modules/indexeddb/server/IDBSerialization.cpp:
Modules/indexeddb/server/IDBSerialization.h:
Modules/mediarecorder/MediaRecorder.cpp:
Modules/mediarecorder/MediaRecorder.h:
Modules/mediasession/MediaMetadata.cpp:
Modules/mediasource/SourceBuffer.cpp:
Modules/mediasource/SourceBuffer.h:
Modules/mediastream/RTCDataChannelRemoteHandler.h:
Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:
Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
Modules/streams/ReadableStreamSink.h:
bindings/js/JSDOMGlobalObject.cpp:
bindings/js/ScriptBufferSourceProvider.h:
bindings/js/SerializedScriptValue.h:
css/CSSFontFaceSource.cpp:
css/CSSFontFaceSource.h:
dom/DataTransfer.cpp:
editing/Editor.cpp:
editing/Editor.h:
editing/SerializedAttachmentData.h:
editing/WebContentReader.h:
editing/WebCorePasteboardFileReader.cpp:
editing/WebCorePasteboardFileReader.h:
editing/cocoa/EditorCocoa.mm:
editing/cocoa/HTMLConverter.mm:
editing/cocoa/WebContentReaderCocoa.mm:
editing/gtk/WebContentReaderGtk.cpp:
editing/mac/EditorMac.mm:
fileapi/Blob.h:
fileapi/NetworkSendQueue.cpp:
fileapi/NetworkSendQueue.h:
html/FTPDirectoryDocument.cpp:
html/HTMLAttachmentElement.cpp:
html/HTMLAttachmentElement.h:
html/HTMLMediaElement.cpp:
html/HTMLMediaElement.h:
html/ImageDocument.cpp:
inspector/InspectorInstrumentation.cpp:
inspector/InspectorInstrumentation.h:
inspector/InspectorInstrumentationWebKit.cpp:
inspector/InspectorInstrumentationWebKit.h:
inspector/NetworkResourcesData.cpp:
inspector/NetworkResourcesData.h:
inspector/agents/InspectorNetworkAgent.cpp:
inspector/agents/InspectorNetworkAgent.h:
inspector/agents/InspectorPageAgent.cpp:
inspector/agents/InspectorPageAgent.h:
loader/ContentFilter.cpp:
loader/CrossOriginPreflightChecker.cpp:
loader/DocumentLoader.cpp:
loader/DocumentLoader.h:
loader/DocumentThreadableLoader.cpp:
loader/EmptyClients.cpp:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/LoaderStrategy.h:
loader/NetscapePlugInStreamLoader.cpp:
loader/NetscapePlugInStreamLoader.h:
loader/ResourceCryptographicDigest.cpp:
loader/ResourceCryptographicDigest.h:
loader/ResourceLoader.cpp:
loader/ResourceLoader.h:
loader/SubresourceLoader.cpp:
loader/SubresourceLoader.h:
loader/SubstituteData.h:
loader/SubstituteResource.h:
loader/appcache/ApplicationCacheHost.cpp:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheResource.cpp:
loader/appcache/ApplicationCacheResource.h:
loader/appcache/ApplicationCacheStorage.cpp:
loader/appcache/ApplicationCacheStorage.h:
loader/archive/ArchiveFactory.cpp:
loader/archive/ArchiveFactory.h:
loader/archive/ArchiveResource.cpp:
loader/archive/ArchiveResource.h:
loader/archive/cf/LegacyWebArchive.cpp:
loader/archive/cf/LegacyWebArchive.h:
loader/archive/mhtml/MHTMLArchive.cpp:
loader/archive/mhtml/MHTMLArchive.h:
loader/archive/mhtml/MHTMLParser.cpp:
loader/archive/mhtml/MHTMLParser.h:
loader/cache/CachedApplicationManifest.cpp:
loader/cache/CachedApplicationManifest.h:
loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedCSSStyleSheet.h:
loader/cache/CachedFont.cpp:
loader/cache/CachedFont.h:
loader/cache/CachedImage.cpp:
loader/cache/CachedImage.h:
loader/cache/CachedRawResource.cpp:
loader/cache/CachedRawResource.h:
loader/cache/CachedResource.cpp:
loader/cache/CachedResource.h:
loader/cache/CachedSVGDocument.cpp:
loader/cache/CachedSVGDocument.h:
loader/cache/CachedSVGFont.cpp:
loader/cache/CachedSVGFont.h:
loader/cache/CachedScript.cpp:
loader/cache/CachedScript.h:
loader/cache/CachedTextTrack.cpp:
loader/cache/CachedTextTrack.h:
loader/cache/CachedXSLStyleSheet.cpp:
loader/cache/CachedXSLStyleSheet.h:
loader/cocoa/DiskCacheMonitorCocoa.h:
loader/cocoa/DiskCacheMonitorCocoa.mm:
loader/ios/LegacyPreviewLoader.h:
loader/ios/LegacyPreviewLoader.mm:
page/EditorClient.h:
page/Page.cpp:
page/PageSerializer.cpp:
page/PageSerializer.h:
page/ShareData.h:
page/ShareDataReader.cpp:
platform/KeyedCoding.h:
platform/NowPlayingManager.h:
platform/Pasteboard.cpp:
platform/Pasteboard.h:
platform/PasteboardCustomData.cpp:
platform/PasteboardCustomData.h:
platform/PasteboardStrategy.h:
platform/PasteboardWriterData.h:
platform/PlatformContentFilter.h:
platform/PlatformPasteboard.h:
platform/PreviewConverter.cpp:
platform/PreviewConverter.h:
platform/PreviewConverterClient.h:
platform/PreviewConverterProvider.h:
platform/PromisedAttachmentInfo.h:
platform/SharedBuffer.cpp:
platform/SharedBuffer.h:
platform/SharedBufferChunkReader.cpp:
platform/SharedBufferChunkReader.h:
platform/StaticPasteboard.cpp:
platform/StaticPasteboard.h:
platform/audio/NowPlayingInfo.h:
platform/audio/cocoa/AudioFileReaderCocoa.cpp:
platform/cf/KeyedEncoderCF.cpp:
platform/cf/KeyedEncoderCF.h:
platform/cf/SharedBufferCF.cpp:
platform/cocoa/NetworkExtensionContentFilter.h:
platform/cocoa/NetworkExtensionContentFilter.mm:
platform/cocoa/ParentalControlsContentFilter.h:
platform/cocoa/ParentalControlsContentFilter.mm:
platform/cocoa/PasteboardCocoa.mm:
platform/cocoa/SharedBufferCocoa.mm:
platform/encryptedmedia/CDMInstance.h:
platform/encryptedmedia/CDMInstanceSession.h:
platform/encryptedmedia/CDMPrivate.h:
platform/encryptedmedia/CDMProxy.cpp:
platform/encryptedmedia/CDMProxy.h:
platform/encryptedmedia/CDMUtilities.cpp:
platform/encryptedmedia/CDMUtilities.h:
platform/encryptedmedia/clearkey/CDMClearKey.cpp:
platform/encryptedmedia/clearkey/CDMClearKey.h:
platform/generic/KeyedEncoderGeneric.cpp:
platform/generic/KeyedEncoderGeneric.h:
platform/glib/KeyedEncoderGlib.cpp:
platform/glib/KeyedEncoderGlib.h:
platform/glib/SharedBufferGlib.cpp:
platform/graphics/Font.cpp:
platform/graphics/Font.h:
platform/graphics/FontPlatformData.h:
platform/graphics/Image.cpp:
platform/graphics/Image.h:
platform/graphics/ImageBackingStore.h:
platform/graphics/ImageDecoder.cpp:
platform/graphics/ImageDecoder.h:
platform/graphics/ImageSource.cpp:
platform/graphics/ImageSource.h:
platform/graphics/Model.cpp:
platform/graphics/Model.h:
platform/graphics/PlatformMediaResourceLoader.h:
platform/graphics/SourceBufferPrivate.cpp:
platform/graphics/SourceBufferPrivate.h:
platform/graphics/WOFFFileFormat.cpp:
platform/graphics/WOFFFileFormat.h:
platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
platform/graphics/avfoundation/CDMFairPlayStreaming.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:
platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
platform/graphics/cairo/FontCustomPlatformData.h:
platform/graphics/cg/ImageDecoderCG.cpp:
platform/graphics/cg/ImageDecoderCG.h:
platform/graphics/cocoa/FontPlatformDataCocoa.mm:
platform/graphics/cocoa/SourceBufferParser.cpp:
platform/graphics/cocoa/SourceBufferParser.h:
platform/graphics/cocoa/SourceBufferParserWebM.cpp:
platform/graphics/coretext/FontPlatformDataCoreText.cpp:
platform/graphics/displaylists/DisplayListItemBuffer.cpp:
platform/graphics/displaylists/DisplayListItemBuffer.h:
platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
platform/graphics/freetype/FontPlatformDataFreeType.cpp:
platform/graphics/gstreamer/GStreamerCommon.cpp:
platform/graphics/gstreamer/GStreamerCommon.h:
platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
platform/graphics/gstreamer/ImageDecoderGStreamer.h:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
platform/graphics/gstreamer/eme/CDMProxyClearKey.h:
platform/graphics/gstreamer/eme/CDMThunder.cpp:
platform/graphics/gstreamer/eme/CDMThunder.h:
platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:
platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
platform/graphics/mac/FontCustomPlatformData.cpp:
platform/graphics/mac/FontCustomPlatformData.h:
platform/graphics/opentype/OpenTypeMathData.cpp:
platform/graphics/opentype/OpenTypeMathData.h:
platform/graphics/opentype/OpenTypeTypes.h:
platform/graphics/opentype/OpenTypeUtilities.cpp:
platform/graphics/opentype/OpenTypeUtilities.h:
platform/graphics/opentype/OpenTypeVerticalData.cpp:
platform/graphics/win/DirectWriteUtilities.h:
platform/graphics/win/FontCustomPlatformData.cpp:
platform/graphics/win/FontCustomPlatformData.h:
platform/graphics/win/FontCustomPlatformDataCairo.cpp:
platform/graphics/win/FontPlatformDataCairoWin.cpp:
platform/graphics/win/FontPlatformDataWin.cpp:
platform/graphics/win/ImageDecoderDirect2D.cpp:
platform/graphics/win/ImageDecoderDirect2D.h:
platform/graphics/win/ImageWin.cpp:
platform/gtk/SelectionData.h:
platform/image-decoders/ScalableImageDecoder.cpp:
platform/image-decoders/ScalableImageDecoder.h:
platform/image-decoders/avif/AVIFImageReader.cpp:
platform/image-decoders/avif/AVIFImageReader.h:
platform/image-decoders/bmp/BMPImageDecoder.cpp:
platform/image-decoders/bmp/BMPImageDecoder.h:
platform/image-decoders/bmp/BMPImageReader.h:
platform/image-decoders/cairo/ImageBackingStoreCairo.cpp:
platform/image-decoders/gif/GIFImageDecoder.cpp:
platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/gif/GIFImageReader.h:
platform/image-decoders/ico/ICOImageDecoder.cpp:
platform/image-decoders/ico/ICOImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp:
platform/image-decoders/png/PNGImageDecoder.cpp:
platform/image-decoders/webp/WEBPImageDecoder.cpp:
platform/image-decoders/webp/WEBPImageDecoder.h:
platform/ios/PasteboardIOS.mm:
platform/ios/PlatformPasteboardIOS.mm:
platform/mac/PasteboardMac.mm:
platform/mac/PlatformPasteboardMac.mm:
platform/mediarecorder/MediaRecorderPrivate.h:
platform/mediarecorder/MediaRecorderPrivateMock.cpp:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
platform/network/DataURLDecoder.h:
platform/network/FormData.cpp:
platform/network/FormData.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.cpp:
platform/network/ResourceHandleClient.h:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
platform/network/cocoa/RangeResponseGenerator.mm:
platform/network/cocoa/WebCoreNSURLSession.h:
platform/network/cocoa/WebCoreNSURLSession.mm:
platform/network/curl/CurlDownload.cpp:
platform/network/curl/CurlDownload.h:
platform/network/curl/CurlMultipartHandle.cpp:
platform/network/curl/CurlMultipartHandle.h:
platform/network/curl/CurlMultipartHandleClient.h:
platform/network/curl/CurlRequest.cpp:
platform/network/curl/CurlRequest.h:
platform/network/curl/CurlRequestClient.h:
platform/network/curl/CurlResourceHandleDelegate.cpp:
platform/network/curl/CurlResourceHandleDelegate.h:
platform/network/ios/LegacyPreviewLoaderClient.h:
platform/posix/SharedBufferPOSIX.cpp:
platform/win/PasteboardWin.cpp:
platform/win/SharedBufferWin.cpp:
testing/MockCDMFactory.cpp:
testing/MockCDMFactory.h:
testing/MockContentFilter.cpp:
testing/MockContentFilter.h:
workers/ScriptBuffer.h:
workers/WorkerFontLoadRequest.cpp:
workers/service/context/ServiceWorkerFetch.cpp:
workers/service/context/ServiceWorkerFetch.h:
workers/service/server/SWScriptStorage.cpp:
xml/XSLTProcessorLibxslt.cpp:
xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

GPUProcess/media/RemoteCDMInstanceProxy.cpp:
GPUProcess/media/RemoteCDMInstanceProxy.h:
GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
GPUProcess/media/RemoteCDMProxy.cpp:
GPUProcess/media/RemoteCDMProxy.h:
GPUProcess/media/RemoteLegacyCDMProxy.h:
GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
GPUProcess/media/RemoteMediaResource.cpp:
GPUProcess/media/RemoteMediaResource.h:
GPUProcess/webrtc/RemoteMediaRecorder.cpp:
NetworkProcess/Downloads/PendingDownload.h:
NetworkProcess/NetworkCORSPreflightChecker.cpp:
NetworkProcess/NetworkCORSPreflightChecker.h:
NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkLoad.cpp:
NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkLoadClient.h:
NetworkProcess/NetworkResourceLoader.cpp:
NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PingLoad.cpp:
NetworkProcess/PingLoad.h:
NetworkProcess/PreconnectTask.cpp:
NetworkProcess/PreconnectTask.h:
NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:
NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h:
NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:
NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:
NetworkProcess/cache/CacheStorageEngineCache.cpp:
NetworkProcess/cache/NetworkCache.cpp:
NetworkProcess/cache/NetworkCache.h:
NetworkProcess/cache/NetworkCacheEntry.cpp:
NetworkProcess/cache/NetworkCacheEntry.h:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
NetworkProcess/cache/PrefetchCache.cpp:
NetworkProcess/cache/PrefetchCache.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
NetworkProcess/curl/NetworkDataTaskCurl.cpp:
NetworkProcess/curl/NetworkDataTaskCurl.h:
NetworkProcess/soup/NetworkDataTaskSoup.cpp:
NetworkProcess/webrtc/NetworkRTCProvider.h:
Platform/IPC/SharedBufferCopy.cpp:
Platform/IPC/SharedBufferCopy.h:
Platform/IPC/SharedBufferDataReference.h:
Platform/SharedMemory.cpp:
Platform/SharedMemory.h:
Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:
Shared/ShareableResource.cpp:
Shared/ShareableResource.h:
Shared/WebCoreArgumentCoders.cpp:
Shared/WebCoreArgumentCoders.h:
Shared/WebHitTestResultData.cpp:
Shared/gtk/ArgumentCodersGtk.cpp:
Shared/win/WebCoreArgumentCodersWin.cpp:
UIProcess/API/APIAttachment.cpp:
UIProcess/API/APIAttachment.h:
UIProcess/API/APIContentRuleListStore.cpp:
UIProcess/API/APIContentRuleListStore.h:
UIProcess/API/APINavigationClient.h:
UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
UIProcess/API/gtk/DropTargetGtk3.cpp:
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:
UIProcess/Cocoa/WebProcessProxyCocoa.mm:
UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebURLSchemeTask.cpp:
UIProcess/WebURLSchemeTask.h:
UIProcess/gtk/Clipboard.h:
UIProcess/gtk/ClipboardGtk3.cpp:
UIProcess/gtk/ClipboardGtk4.cpp:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:
UIProcess/ios/WKContentViewInteraction.mm:
UIProcess/ios/WebPageProxyIOS.mm:
UIProcess/mac/PageClientImplMac.h:
UIProcess/mac/PageClientImplMac.mm:
UIProcess/mac/WebPageProxyMac.mm:
WebProcess/GPU/media/RemoteCDM.cpp:
WebProcess/GPU/media/RemoteCDM.h:
WebProcess/GPU/media/RemoteCDMInstance.cpp:
WebProcess/GPU/media/RemoteCDMInstance.h:
WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
WebProcess/GPU/media/RemoteCDMInstanceSession.h:
WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
WebProcess/GPU/media/RemoteImageDecoderAVF.h:
WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:
WebProcess/GPU/media/RemoteImageDecoderAVFManager.h:
WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
WebProcess/GPU/media/SourceBufferPrivateRemote.h:
WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:
WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
WebProcess/Network/NetworkProcessConnection.cpp:
WebProcess/Network/WebResourceLoader.cpp:
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:
WebProcess/Plugins/Plugin.h:
WebProcess/Plugins/PluginView.cpp:
WebProcess/Plugins/PluginView.h:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:
WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.h:
WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
WebProcess/WebPage/WebFrame.cpp:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:
WebProcess/WebPage/mac/WebPageMac.mm:
WebProcess/win/WebProcessWin.cpp:

Source/WebKitLegacy:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

WebCoreSupport/PingHandle.h:

Source/WebKitLegacy/mac:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm:
WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:
WebView/WebDataSource.mm:
WebView/WebHTMLView.mm:
WebView/WebResource.mm:

Source/WebKitLegacy/win:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

MemoryStream.cpp:
MemoryStream.h:
WebArchive.cpp:
WebCoreSupport/WebEditorClient.cpp:
WebCoreSupport/WebEditorClient.h:
WebFrame.cpp:
WebFrame.h:
WebKitDLL.cpp:
WebResource.cpp:
WebResource.h:

Tools:
Rename SharedBuffer classes.
https://bugs.webkit.org/show_bug.cgi?id=233677
rdar://problem/85963900

Reviewed by Youenn Fablet.

SharedBuffer are renamed FragmentedSharedBuffer and
ContiguousSharedBuffer to SharedBuffer to better reflect their actual
types.

TestWebKitAPI/Tests/WTF/FileSystem.cpp:
TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:
TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
TestWebKitAPI/Tests/WebCore/SharedBufferTest.h:
TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:
TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
TestWebKitAPI/win/TestWebCoreStubs.cpp:

2:43 AM Changeset in webkit [287020] by Carlos Garcia Campos

9 edits in trunk/Source/WebCore

[GTK][a11y] Register the wrappers tree when org.a11y.atspi.Cache.GetItems() is called
https://bugs.webkit.org/show_bug.cgi?id=234292

Reviewed by Joanmarie Diggs.

This ensures wrappers always have a reference before being added to the cache.

accessibility/AXObjectCache.h:
accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::attachWrapper): Defer the set parent call to next cache update.
(WebCore::AXObjectCache::platformPerformDeferredCacheUpdate): Do the set parent call here.

accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::registerObject): Do not call addAccessible from here, since it needs the path,
it's now called from the caller of registerObject().
(WebCore::AccessibilityAtspi::parentChanged): Notify about parent property change.
(WebCore::AccessibilityAtspi::childrenChanged): Always emit ChildrenChanged when the tree is registered because
the atspi cache always consumes it.
(WebCore::AccessibilityAtspi::addAccessible): We no longer need to dispath addAccessible in the next run loop iteration.

accessibility/atspi/AccessibilityAtspi.h:
accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::registerObject): Helper to register the object when path is not needed. Also
ensure the isolated tree is created before registering the object.
(WebCore::AccessibilityObjectAtspi::path): Call registerObject().
(WebCore::AccessibilityObjectAtspi::hyperlinkReference): Use registerObject() instead of path().
(WebCore::AccessibilityObjectAtspi::setParent): Call AccessibilityAtspi::parentChanged() if the wrapper is still
and attached and not ignored.
(WebCore::AccessibilityObjectAtspi::parentReference const): Use the parent member instead of asking the main
thread again.
(WebCore::AccessibilityObjectAtspi::isDefunct const): Return true if wrapper has been detached.
(WebCore::AccessibilityObjectAtspi::childAdded): We no longer need to dispatch childrenChanged in next run loop iteration.

accessibility/atspi/AccessibilityObjectAtspi.h:
accessibility/atspi/AccessibilityRootAtspi.cpp:

(WebCore::registerSubtree): Helper to register the wrappers tree recursively.
(WebCore::AccessibilityRootAtspi::registerTree): Register the wrappers tree.

accessibility/atspi/AccessibilityRootAtspi.h:

2:29 AM Changeset in webkit [287019] by Darin Adler

12 edits in trunk/Source

Automatically generate event handler content attribute maps so they are easier to maintain
https://bugs.webkit.org/show_bug.cgi?id=234254

Reviewed by Alexey Shvayka.

Source/WebCore:

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Declare forEachEventHandlerContentAttribute
and forEachWindowEventHandlerContentAttribute as needed.
(GenerateImplementation): Call GenerateForEachEventHandlerContentAttribute
as needed.
(GenerateForEachEventHandlerContentAttribute): Define
forEachEventHandlerContentAttribute or forEachWindowEventHandlerContentAttribute.

bindings/scripts/IDLAttributes.json: Added

GenerateForEachEventHandlerContentAttribute and
GenerateForEachWindowEventHandlerContentAttribute. Even though each
is used in only one class, it's still better to not hard-code the class names.

html/HTMLAttributeNames.in: Added oncuechange, onrejectionhandled, and

onunhandledrejection even though we are not yet implementing any of them in
this behavior-preserving patch. They need to be present so the automatically
generated code compiles. But added explicit exceptions as mentioned below to
make sure no changes are implemented in this patch, and will take those exceptions
out later in a patch intended to produce a progression, likely with new test cases.
Re-sorted alphabetically, rather an arbitrary semi-sorted order.

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::createWindowEventHandlerNameMap): Deleted.
(WebCore::HTMLBodyElement::eventNameForWindowEventHandlerAttribute): Use
JSHTMLBodyElement::forEachWindowEventHandlerContentAttribute to create the map.
Use a lambda instead of a separate function and take advantage of the
deduction guide for NeverDestroyed. Added exceptions for onrejectionhandled
and onunhandledrejection, which are both in the IDL file but were not handled
here, along with a FIXME suggesting we remove the exceptions.

html/HTMLElement.h: Removed createWindowEventHandlerNameMap.
html/HTMLBodyElement.idl: Added GenerateForEachWindowEventHandlerContentAttribute.

html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap): Deleted.
(WebCore::HTMLElement::populateEventHandlerNameMap): Deleted.
(WebCore::HTMLElement::eventNameForEventHandlerAttribute): Use
JSHTMLElement::forEachEventHandlerContentAttribute to create the map.
Use a lambda instead of a separate function and take advantage of the
deduction guide for NeverDestroyed. Added exception for oncuechange,
which is in the IDL file but was not handled here, and for 19 other attributes,
which are not in the IDL file but were handled here, along with two FIXMEs
suggesting we remove the exceptions.

html/HTMLElement.h: Removed populateEventHandlerNameMap and

createEventHandlerNameMap.

html/HTMLElement.idl: Added GenerateForEachEventHandlerContentAttribute.

Source/WTF:

wtf/NeverDestroyed.h: Add a deduction guide for NeverDestroyed.

In the future we can use this instead of makeNeverDestroyed or writing
out the entire template class type including template arguments.

2:13 AM Changeset in webkit [287018] by Antti Koivisto

9 edits in trunk

[CSS Cascade Layers] revert-layer should revert style attribute to regular author style
https://bugs.webkit.org/show_bug.cgi?id=234082

Reviewed by Simon Fraser.

Source/WebCore:

If 'revert-layer' keyword is used in style attribute it should revert to regular author style
on the default cascade level.

style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):

Make the maximum level (used for revert cascades) an std::optional.

(WebCore::Style::PropertyCascade::setPropertyInternal):
(WebCore::Style::PropertyCascade::addMatch):

Factor the revert test into a lambda.
We can never revert to an attribute style so always skip them.

style/PropertyCascade.h:

(WebCore::Style::PropertyCascade::PropertyCascade):
(WebCore::Style::PropertyCascade::maximumCascadeLevel const): Deleted.
(WebCore::Style::PropertyCascade::maximumCascadeLayerPriority const): Deleted.

style/RuleSet.h:
style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyCustomProperty):
(WebCore::Style::Builder::applyCascadeProperty):
(WebCore::Style::Builder::applyRollbackCascadeProperty):

Keep a pointer to the current property being applied in state instead of individual priority values.

(WebCore::Style::Builder::applyProperty):
(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):

If the current property is from attribute style it reverts to the same layer.

style/StyleBuilder.h:
style/StyleBuilderState.h:

(WebCore::Style::BuilderState::styleScopeOrdinal const):

LayoutTests:

TestExpectations:

1:35 AM Changeset in webkit [287017] by youenn@apple.com

2 edits in trunk/Source/WebCore

Null pointer crash in FetchResponse::clone
https://bugs.webkit.org/show_bug.cgi?id=234236
<rdar://86327601>

Reviewed by Alex Christensen.

From the log, we are most probably getting a null globalObject from a ScriptExecutionContext in FetchResponse::clone.
This may happen in case the document is navigated away but we still execute some code for it.
Add a null check to ensure we do not crash.

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::clone):

1:03 AM Changeset in webkit [287016] by ysuzuki@apple.com

2 edits in trunk/Source/bmalloc

Unreviewed, fix Xcode build of libpas
https://bugs.webkit.org/show_bug.cgi?id=233821

r286934 broke build.sh for Xcode. This patch fixes it.

libpas/build.sh:

12:18 AM Changeset in webkit [287015] by Ben Nham

8 edits
6 adds in trunk/Source/WebCore

Add web push message decryption routines
https://bugs.webkit.org/show_bug.cgi?id=233903

Reviewed by Brady Eidson.

Source/WebCore:

This adds routines to decrypt push payloads encoded with the aes128gcm and aesgcm schemes.
The crypto primitives that we depend are implemented in PushCrypto, while the logic to use
those primitives to decrypt message payloads is in PushMessageCrypto.

Test: TestWebKitAPI.PushMessageCrypto

Headers.cmake:
Modules/push-api/PushCrypto.cpp: Added.

(WebCore::PushCrypto::P256DHKeyPair::generate):
(WebCore::PushCrypto::validateP256DHPublicKey):
(WebCore::PushCrypto::computeP256DHSharedSecret):
(WebCore::PushCrypto::hmacSHA256):
(WebCore::PushCrypto::decryptAES128GCM):

Modules/push-api/PushCrypto.h: Added.
Modules/push-api/PushManager.cpp:

(WebCore::PushManager::subscribe):

Modules/push-api/PushMessageCrypto.cpp: Added.

(WebCore::PushCrypto::ClientKeys::generate):
(WebCore::PushCrypto::areClientKeyLengthsValid):
(WebCore::PushCrypto::computeAES128GCMPaddingLength):
(WebCore::PushCrypto::decryptAES128GCMPayload):
(WebCore::PushCrypto::computeAESGCMPaddingLength):
(WebCore::PushCrypto::decryptAESGCMPayload):

Modules/push-api/PushMessageCrypto.h: Added.
Modules/push-api/cocoa/PushCryptoCocoa.cpp: Added.

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

pal/spi/cocoa/CommonCryptoSPI.h: Add AES-GCM decryption SPI.

12:12 AM Changeset in webkit [287014] by Carlos Garcia Campos

15 edits in trunk/Source

[GTK][a11y] Handle the Embedded method sent by AtkSocket from AccessibilityRootAtspi
https://bugs.webkit.org/show_bug.cgi?id=234233

Reviewed by Adrian Perez de Castro.

Source/WebCore:

accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::registerRoot):

accessibility/atspi/AccessibilityRootAtspi.cpp:

(WebCore::AccessibilityRootAtspi::registerObject):
(WebCore::AccessibilityRootAtspi::embedded):
(WebCore::AccessibilityRootAtspi::setParentPath): Deleted.

accessibility/atspi/AccessibilityRootAtspi.h:
accessibility/atspi/xml/Socket.xml:

Source/WebKit:

I added some hacks to send the socket path to the web process using WebKit IPC because Embedded message is not
in the DBus interface. We can simply add the message to the interface definition and handle it instead to
simplify everything.

UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::bindAccessibilityTree):
(WebKit::ProvisionalPageProxy::didReceiveMessage):

UIProcess/ProvisionalPageProxy.h:

(WebKit::ProvisionalPageProxy::accessibilityPlugID):
(WebKit::ProvisionalPageProxy::CompletionHandler<void): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::swapToProvisionalPage):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::bindAccessibilityTree):

WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize):

Dec 13, 2021:

11:56 PM Changeset in webkit [287013] by wilander@apple.com

16 edits in trunk

PCM: Remove old DB update and migration code, and add a unit test for destination token DB columns
https://bugs.webkit.org/show_bug.cgi?id=234281
<rdar://86347439>

Reviewed by Alex Christensen and Kate Cheney.

Source/WebKit:

WebKit::Database::needsUpdatedSchema() in PrivateClickMeasurement.cpp has a comment saying it
should be removed late 2021. WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary()
returns directly if WebKit::Database::needsUpdatedSchema() returns false so always returning
false for WebKit::Database::needsUpdatedSchema() in PrivateClickMeasurement.cpp effectively
disables WebKit::DatabaseUtilities::migrateDataToNewTablesIfNecessary() for PCM.

New unit/API test PrivateClickMeasurement.MigrateWithDestinationToken added.

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp:

(WebKit::PCM::Database::Database):

No longer calls the deleted DatabaseUtilities::migrateDataToNewTablesIfNecessary().

(WebKit::PCM::Database::attributionToStringForTesting const):

Now outputs destination token info.

(WebKit::PCM::Database::needsUpdatedSchema): Deleted.

NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.h:

needsUpdatedSchema() now always returns false.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:

(addAttributedPCMv5):
(pollUntilPCMIsMigrated):

Now takes a parameter UsingDestinationToken and handles its expectation
accordingly.

(TEST):

New test PrivateClickMeasurement.MigrateWithDestinationToken.

LayoutTests:

These expect files are just updated with destination token dump output.

http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt:
http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt:
http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt:
http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt:
http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt:
http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt:
http/tests/privateClickMeasurement/triggering-event-with-attribution-source-through-fetch-keepalive-expected.txt:

11:07 PM Changeset in webkit [287012] by sbarati@apple.com

6 edits
2 adds in trunk/Source/JavaScriptCore

WasmB3IRGenerator should estimate static execution counts
https://bugs.webkit.org/show_bug.cgi?id=234284

Reviewed by Filip Pizlo.

This enables the register allocator to make better decisions.

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
b3/B3BasicBlock.h:

(JSC::B3::BasicBlock::setFrequency):

b3/B3EstimateStaticExecutionCounts.cpp: Added.

(JSC::B3::estimateStaticExecutionCounts):

b3/B3EstimateStaticExecutionCounts.h: Added.
wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):

8:55 PM Changeset in webkit [287011] by Kate Cheney

2 edits in trunk/Source/WebCore

WebContent process crashes at ContentSecurityPolicySourceList::matchesAll
https://bugs.webkit.org/show_bug.cgi?id=234288
rdar://problem/86438924

Reviewed by Simon Fraser.

page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):

8:26 PM Changeset in webkit [287010] by commit-queue@webkit.org

33 edits
4 adds in trunk

Allow WKContentRuleList to run regexes on current frame's URL, not just top frame's URL
https://bugs.webkit.org/show_bug.cgi?id=233889

Patch by Alex Christensen <achristensen@webkit.org> on 2021-12-13
Reviewed by Timothy Hatcher.

Source/WebCore:

In 2015, my younger self implemented if-top-url and unless-top-url by running the current URL
through multiple sets of regexes, those with and those without such conditions. This wasn't
really able to be expanded. In order to implement if-frame-url, I moved the condition type to
the set of flags stored in the bytecode itself. Now, we only interpret the bytecode once on the
currently-requested URL, up to once on the frame URL, and up to once on the top URL, and the latter
two can be cached because they don't change as often.

Covered by existing and additional API and layout tests.

contentextensions/CompiledContentExtension.h:
contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::ContentExtension):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::populateTopURLActionCacheIfNeeded const):
(WebCore::ContentExtensions::ContentExtension::populateFrameURLActionCacheIfNeeded const):
(WebCore::ContentExtensions::ContentExtension::topURLActions const):
(WebCore::ContentExtensions::ContentExtension::frameURLActions const):
(WebCore::ContentExtensions::ContentExtension::populateConditionCacheIfNeeded): Deleted.
(WebCore::ContentExtensions::ContentExtension::topURLActions): Deleted.
(WebCore::ContentExtensions::ContentExtension::universalActionsWithConditions): Deleted.

contentextensions/ContentExtension.h:

(WebCore::ContentExtensions::ContentExtension::universalActions const):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutConditions): Deleted.

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::compileRuleList):

contentextensions/ContentExtensionCompiler.h:
contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadTrigger):

contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::Trigger::isolatedCopy const):

contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::~Trigger):
(WebCore::ContentExtensions::Trigger::isEmpty const):
(WebCore::ContentExtensions::Trigger::operator== const):

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsFromContentRuleList const):
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForPingLoad):

contentextensions/ContentExtensionsBackend.h:
contentextensions/DFABytecode.h:
contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):

contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::getBits):
(WebCore::ContentExtensions::hasFlags):
(WebCore::ContentExtensions::hasAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsMatchingEverything):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::matchesCondition): Deleted.
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithConditions): Deleted.

contentextensions/DFABytecodeInterpreter.h:

(): Deleted.

loader/ResourceLoadInfo.cpp:
loader/ResourceLoadInfo.h:

Source/WebKit:

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::processContentRuleListsForLoad):

NetworkProcess/NetworkLoadChecker.h:

(WebKit::NetworkLoadChecker::setContentExtensionController):

NetworkProcess/NetworkResourceLoadParameters.h:
NetworkProcess/NetworkResourceLoader.cpp:
NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::initialize):

Shared/WebCompiledContentRuleList.cpp:

(WebKit::WebCompiledContentRuleList::urlFiltersBytecode const):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecode const): Deleted.
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecode const): Deleted.

Shared/WebCompiledContentRuleList.h:
Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):

Shared/WebCompiledContentRuleListData.h:

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):

UIProcess/API/APIContentRuleListStore.cpp:

(API::ContentRuleListMetaData::fileSize const):
(API::encodeContentRuleListMetaData):
(API::decodeContentRuleListMetaData):
(API::compiledToFile):
(API::createExtension):
(API::getContentRuleListSourceFromMappedFile):

UIProcess/API/APIContentRuleListStore.h:
WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::startPingLoad):

Tools:

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::mainDocumentRequest):
(TestWebKitAPI::subResourceRequest):
(TestWebKitAPI::TEST_F):

LayoutTests:

http/tests/contentextensions/frame-url-expected.txt: Added.
http/tests/contentextensions/frame-url.html: Added.
http/tests/contentextensions/frame-url.html.json: Added.
http/tests/contentextensions/resources/iframe.html: Added.

8:23 PM Changeset in webkit [287009] by beidson@apple.com

20 edits in trunk

Teach webpushtool to register and "host" the daemon.
https://bugs.webkit.org/show_bug.cgi?id=234265

Reviewed by Tim Horton.

Source/JavaScriptCore:

inspector/ConsoleMessage.h: Remove using JSC::MessageType because it makes it hard for others to also have a MessageType type.
inspector/JSGlobalObjectConsoleClient.h:
runtime/ConsoleTypes.h:

Source/WebCore:

page/PageConsoleClient.h:

Source/WebKit:

Covered by API tests verifying hosting mode operation.

As various engineers work on various parts of the project, it's become apparent that it's super useful
to have a tool handle the "setting up" of the daemon itself, to avoid launchctl, etc.

Implement that, as well as a few other niceties found while testing.

Configurations/webpushtool.xcconfig:
Resources/webpushtool.entitlements:

Shared/Daemon/DaemonUtilities.mm:

(WebKit::startListeningForMachServiceConnections):

webpushd/AppBundleRequest.mm:

(WebPushD::AppBundleRequest::start):

webpushd/PushClientConnection.h:
webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::setHostAppAuditTokenData):
(WebPushD::ClientConnection::broadcastDebugMessage):

webpushd/WebPushDaemon.h:
webpushd/WebPushDaemon.mm:

(WebPushD::Daemon::broadcastAllConnectionIdentities):

webpushd/webpushtool/WebPushToolConnection.h:
webpushd/webpushtool/WebPushToolConnection.mm:

(WebPushTool::Connection::connectToService):
(WebPushTool::Connection::connectionDropped):

webpushd/webpushtool/WebPushToolMain.mm:

(printUsageAndTerminate):
(registerDaemonWithLaunchD):
(main):

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::shouldSetupWebPushD): Add a command line argument to skip the "install the daemon" step,

so an engineer can handle that part themselves.

(TestWebKitAPI::setUpTestWebPushD):
(TestWebKitAPI::cleanUpTestWebPushD):

7:28 PM Changeset in webkit [287008] by Russell Epstein

112 edits
2 adds
5 deletes in branches/safari-613.1.11-branch/Source

Cherry-pick r286994. rdar://problem/86445989

Roll back r286345, r286387, r286471, r286667, r286849
https://bugs.webkit.org/show_bug.cgi?id=234268

Reviewed by Mark Lam.

Source/JavaScriptCore:

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp: (JSC::AccessCase::AccessCase): (JSC::AccessCase::forEachDependentCell const): (JSC::AccessCase::dump const): (JSC::AccessCase::propagateTransitions const): (JSC::AccessCase::generateWithGuard): (JSC::AccessCase::canBeShared):
bytecode/AccessCase.h: (JSC::AccessCase::structure const): (JSC::AccessCase::newStructure const): (JSC::AccessCase::hash const): (JSC::AccessCase::AccessCase):
bytecode/ArrayProfile.cpp: (JSC::ArrayProfile::computeUpdatedPrediction):
bytecode/ArrayProfile.h:
bytecode/CheckPrivateBrandStatus.cpp: (JSC::CheckPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/CodeBlock.cpp: (JSC::CodeBlock::propagateTransitions): (JSC::CodeBlock::determineLiveness): (JSC::CodeBlock::finalizeLLIntInlineCaches): (JSC::CodeBlock::stronglyVisitWeakReferences):
bytecode/DeleteByStatus.cpp: (JSC::DeleteByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/GetByIdMetadata.h: (JSC::GetByIdModeMetadata::GetByIdModeMetadata): (JSC::GetByIdModeMetadata::clearToDefaultModeWithoutCache):
bytecode/GetByStatus.cpp: (JSC::GetByStatus::computeFromLLInt): (JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InByStatus.cpp: (JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InlineAccess.cpp: (JSC::InlineAccess::rewireStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccess):
bytecode/InstanceOfStatus.cpp: (JSC::InstanceOfStatus::computeForStubInfo):
bytecode/InternalFunctionAllocationProfile.h: (JSC::InternalFunctionAllocationProfile::offsetOfStructure): (JSC::InternalFunctionAllocationProfile::structure): (JSC::InternalFunctionAllocationProfile::clear): (JSC::InternalFunctionAllocationProfile::visitAggregate): (JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase): (JSC::InternalFunctionAllocationProfile::offsetOfStructureID): Deleted.
bytecode/PolyProtoAccessChain.cpp: (JSC::PolyProtoAccessChain::needImpurePropertyWatchpoint const):
bytecode/PolyProtoAccessChain.h:
bytecode/PolymorphicAccess.cpp: (JSC::PolymorphicAccess::visitWeak const):
bytecode/PutByIdFlags.h:
bytecode/PutByStatus.cpp: (JSC::PutByStatus::computeFromLLInt): (JSC::PutByStatus::computeForStubInfo):
bytecode/SetPrivateBrandStatus.cpp: (JSC::SetPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/SpeculatedType.cpp: (JSC::speculationFromCell):
bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::initInByIdSelf): (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::aboutToDie): (JSC::StructureStubInfo::addAccessCase): (JSC::StructureStubInfo::reset): (JSC::StructureStubInfo::visitAggregateImpl): (JSC::StructureStubInfo::visitWeakReferences): (JSC::StructureStubInfo::propagateTransitions): (JSC::StructureStubInfo::summary const): (JSC::StructureStubInfo::containsPC const):
bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::offsetOfByIdSelfOffset): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructure): (JSC::StructureStubInfo::inlineAccessBaseStructure): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructureID): Deleted.
dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
dfg/DFGGraph.cpp: (JSC::DFG::Graph::dump):
dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::branchWeakStructure):
dfg/DFGPlan.cpp: (JSC::DFG::Plan::finalize):
dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined): (JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined): (JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther): (JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch): (JSC::DFG::SpeculativeJIT::emitUntypedBranch): (JSC::DFG::SpeculativeJIT::compile):
ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
heap/AbstractSlotVisitor.h:
heap/AbstractSlotVisitorInlines.h:
heap/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::runEndPhase):
heap/Heap.h: (JSC::Heap::structureIDTable):
heap/IsoAlignedMemoryAllocator.cpp: (JSC::IsoAlignedMemoryAllocator::IsoAlignedMemoryAllocator): (JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator): (JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory): (JSC::IsoAlignedMemoryAllocator::freeAlignedMemory): (JSC::IsoAlignedMemoryAllocator::tryMallocBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::freeBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::commitBlock): Deleted. (JSC::IsoAlignedMemoryAllocator::decommitBlock): Deleted.
heap/IsoAlignedMemoryAllocator.h:
heap/IsoMemoryAllocatorBase.cpp: Removed.
heap/IsoMemoryAllocatorBase.h: Removed.
heap/IsoSubspace.cpp: (JSC::IsoSubspace::IsoSubspace): (JSC::IsoSubspace::tryAllocateFromLowerTier):
heap/IsoSubspace.h:
heap/PreciseAllocation.cpp: (JSC::PreciseAllocation::createForLowerTier): (JSC::PreciseAllocation::tryCreateForLowerTier): Deleted.
heap/PreciseAllocation.h:
heap/SlotVisitor.cpp: (JSC::SlotVisitor::appendJSCellOrAuxiliary):
heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:
heap/StructureAlignedMemoryAllocator.cpp: Removed.
heap/StructureAlignedMemoryAllocator.h: Removed.
jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo): (JSC::AssemblyHelpers::emitLoadStructure): (JSC::AssemblyHelpers::emitLoadPrototype): (JSC::AssemblyHelpers::emitRandomThunk): (JSC::AssemblyHelpers::emitConvertValueToBoolean): (JSC::AssemblyHelpers::branchIfValue): (JSC::AssemblyHelpers::emitNonNullDecodeStructureID): Deleted.
jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::branchStructure): (JSC::AssemblyHelpers::nukeStructureAndStoreButterfly):
jit/GCAwareJITStubRoutine.cpp: (JSC::PolymorphicAccessJITStubRoutine::computeHash):
jit/JITInlineCacheGenerator.cpp: (JSC::generateGetByIdInlineAccess): (JSC::JITPutByIdGenerator::generateBaselineDataICFastPath): (JSC::JITInByIdGenerator::generateBaselineDataICFastPath):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_typeof_is_undefined): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_get_prototype_of):
jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_property_enumerator):
jit/JITStubRoutine.h:
llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::performLLIntGetByID):
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/BigIntPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/BooleanPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/CommonSlowPaths.cpp: (JSC::JSC_DEFINE_COMMON_SLOW_PATH):
runtime/DatePrototype.cpp: (JSC::formateDateInstance): (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/ErrorInstance.cpp: (JSC::ErrorInstance::sanitizedMessageString): (JSC::ErrorInstance::sanitizedNameString): (JSC::ErrorInstance::sanitizedToString):
runtime/ErrorPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/FunctionExecutable.cpp: (JSC::FunctionExecutable::visitChildrenImpl):
runtime/FunctionExecutable.h:
runtime/FunctionPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/FunctionRareData.cpp: (JSC::FunctionRareData::visitChildrenImpl):
runtime/FunctionRareData.h:
runtime/HasOwnPropertyCache.h:
runtime/InitializeThreading.cpp: (JSC::initialize):
runtime/JSCConfig.h:
runtime/JSCJSValue.cpp: (JSC::JSValue::dumpInContextAssumingStructure const): (JSC::JSValue::dumpForBacktrace const):
runtime/JSCell.cpp: (JSC::JSCell::toObjectSlow const):
runtime/JSCell.h: (JSC::JSCell::clearStructure):
runtime/JSCellInlines.h: (JSC::JSCell::structure const): (JSC::JSCell::setStructure):
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildrenImpl):
runtime/JSGlobalObject.h:
runtime/JSObject.cpp: (JSC::JSObject::visitButterflyImpl): (JSC::JSObject::createInitialUndecided): (JSC::JSObject::createInitialInt32): (JSC::JSObject::createInitialDouble): (JSC::JSObject::createInitialContiguous): (JSC::JSObject::createArrayStorage): (JSC::JSObject::convertUndecidedToArrayStorage): (JSC::JSObject::convertInt32ToArrayStorage): (JSC::JSObject::convertDoubleToArrayStorage): (JSC::JSObject::convertContiguousToArrayStorage): (JSC::JSObject::putDirectCustomGetterSetterWithoutTransition): (JSC::JSObject::putDirectNonIndexAccessorWithoutTransition):
runtime/JSObject.h: (JSC::JSObject::nukeStructureAndSetButterfly): (JSC::JSObject::getPropertySlot):
runtime/JSObjectInlines.h: (JSC::JSObject::getPropertySlot): (JSC::JSObject::getNonIndexPropertySlot): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectInternal):
runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator): (JSC::JSPropertyNameEnumerator::visitChildrenImpl):
runtime/JSPropertyNameEnumerator.h:
runtime/NumberPrototype.cpp: (JSC::toThisNumber):
runtime/ObjectPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::objectPrototypeToString):
runtime/RegExpPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/StringPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::dump const): (JSC::Structure::canCachePropertyNameEnumerator const):
runtime/Structure.h: (JSC::Structure::id const):
runtime/StructureChain.cpp: (JSC::StructureChain::create): (JSC::StructureChain::visitChildrenImpl):
runtime/StructureID.h: Removed.
runtime/StructureIDBlob.h: (JSC::StructureIDBlob::StructureIDBlob):
runtime/StructureIDTable.cpp: Added. (JSC::StructureIDTable::StructureIDTable): (JSC::StructureIDTable::makeFreeListFromRange): (JSC::StructureIDTable::resize): (JSC::StructureIDTable::flushOldTables): (JSC::StructureIDTable::allocateID): (JSC::StructureIDTable::deallocateID):
runtime/StructureIDTable.h: Added. (JSC::nukedStructureIDBit): (JSC::nuke): (JSC::isNuked): (JSC::decontaminate): (JSC::StructureIDTable::base): (JSC::StructureIDTable::size const): (JSC::StructureIDTable::table const): (JSC::StructureIDTable::decode): (JSC::StructureIDTable::encode): (JSC::StructureIDTable::get): (JSC::StructureIDTable::tryGet): (JSC::StructureIDTable::validate): (JSC::StructureIDTable::deallocateID): (JSC::StructureIDTable::allocateID): (JSC::StructureIDTable::flushOldTables):
runtime/StructureRareData.cpp: (JSC::StructureRareData::StructureRareData):
runtime/StructureRareData.h:
runtime/StructureRareDataInlines.h: (JSC::StructureRareData::tryCachePropertyNameEnumeratorViaWatchpoint):
runtime/SymbolPrototype.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER): (JSC::JSC_DEFINE_HOST_FUNCTION):
runtime/TypeProfilerLog.cpp: (JSC::TypeProfilerLog::processLogEntries): (JSC::TypeProfilerLog::visit):
runtime/VM.h: (JSC::VM::getStructure): (JSC::VM::tryGetStructure):
runtime/WriteBarrier.h: (JSC::WriteBarrierStructureID::WriteBarrierStructureID): Deleted. (JSC::WriteBarrierStructureID::get const): Deleted. (JSC::WriteBarrierStructureID::operator* const): Deleted. (JSC::WriteBarrierStructureID::operator-> const): Deleted. (JSC::WriteBarrierStructureID::clear): Deleted. (JSC::WriteBarrierStructureID::operator bool const): Deleted. (JSC::WriteBarrierStructureID::operator! const): Deleted. (JSC::WriteBarrierStructureID::setWithoutWriteBarrier): Deleted. (JSC::WriteBarrierStructureID::unvalidatedGet const): Deleted. (JSC::WriteBarrierStructureID::value const): Deleted.
runtime/WriteBarrierInlines.h: (JSC::WriteBarrierStructureID::set): Deleted. (JSC::WriteBarrierStructureID::setMayBeNull): Deleted. (JSC::WriteBarrierStructureID::setEarlyValue): Deleted.
tools/HeapVerifier.cpp: (JSC::HeapVerifier::validateJSCell):
tools/Integrity.cpp:
tools/Integrity.h:
tools/IntegrityInlines.h: (JSC::Integrity::auditStructureID):
tools/JSDollarVM.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSDollarVM::finishCreation): (JSC::JSDollarVM::visitChildrenImpl):
tools/JSDollarVM.h:
wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::jsCallEntrypointSlow):
wasm/js/WebAssemblyGlobalPrototype.cpp: (JSC::getGlobal):

Source/WTF:

wtf/OSAllocator.h:
wtf/posix/OSAllocatorPOSIX.cpp: (WTF::OSAllocator::reserveUncommittedAligned): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:28 PM Changeset in webkit [287007] by Russell Epstein

2 edits in branches/safari-613.1.11-branch/Source/WTF

Cherry-pick r286849. rdar://problem/86445989

Reduce maximum mmap size for Structure regions to help placate ios
https://bugs.webkit.org/show_bug.cgi?id=234091

Reviewed by Saam Barati.

Use mach_vm_map since that supports memory alignement so we don't have to map 2x desired address space then free then trim.

wtf/PlatformHave.h:
wtf/posix/OSAllocatorPOSIX.cpp: (WTF::OSAllocator::reserveUncommittedAligned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:28 PM Changeset in webkit [287006] by Russell Epstein

38 edits in branches/safari-613.1.11-branch/Source/JavaScriptCore

Cherry-pick r286667. rdar://problem/86445989

[JSC] Introduce WriteBarrierStructureID
https://bugs.webkit.org/show_bug.cgi?id=233918

Reviewed by Mark Lam.

This patch adds WriteBarrierStructureID class, which is similar to WriteBarrier<Structure>, but internally,
it holds StructureID, so sizeof(WriteBarrierStructureID) is 4. This class is useful to use StructureID for
memory saving while keeping WriteBarrier<Structure>'s useful features (automatically inserts write-barrier when
setting etc.). This also paves the way to introducing DOMStructures array with WriteBarrierStructureID instead
of costly HashMap<ClassInfo*, WriteBarrier<Structure>>.

bytecode/AccessCase.cpp: (JSC::AccessCase::AccessCase): (JSC::AccessCase::forEachDependentCell const): (JSC::AccessCase::dump const): (JSC::AccessCase::propagateTransitions const): (JSC::AccessCase::canBeShared):
bytecode/AccessCase.h: (JSC::AccessCase::structure const): (JSC::AccessCase::newStructure const): (JSC::AccessCase::hash const): (JSC::AccessCase::AccessCase):
bytecode/CheckPrivateBrandStatus.cpp: (JSC::CheckPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/DeleteByStatus.cpp: (JSC::DeleteByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/GetByStatus.cpp: (JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InByStatus.cpp: (JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/InlineAccess.cpp: (JSC::InlineAccess::rewireStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccess):
bytecode/InstanceOfStatus.cpp: (JSC::InstanceOfStatus::computeForStubInfo):
bytecode/InternalFunctionAllocationProfile.h: (JSC::InternalFunctionAllocationProfile::offsetOfStructureID): (JSC::InternalFunctionAllocationProfile::structure): (JSC::InternalFunctionAllocationProfile::clear): (JSC::InternalFunctionAllocationProfile::visitAggregate): (JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase): (JSC::InternalFunctionAllocationProfile::offsetOfStructure): Deleted.
bytecode/PutByStatus.cpp: (JSC::PutByStatus::computeForStubInfo):
bytecode/SetPrivateBrandStatus.cpp: (JSC::SetPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):
bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::initInByIdSelf): (JSC::StructureStubInfo::deref): (JSC::StructureStubInfo::aboutToDie): (JSC::StructureStubInfo::addAccessCase): (JSC::StructureStubInfo::reset): (JSC::StructureStubInfo::visitAggregateImpl): (JSC::StructureStubInfo::visitWeakReferences): (JSC::StructureStubInfo::propagateTransitions): (JSC::StructureStubInfo::summary const): (JSC::StructureStubInfo::containsPC const):
bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::inlineAccessBaseStructure): (JSC::StructureStubInfo::offsetOfByIdSelfOffset): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructureID): (JSC::StructureStubInfo::offsetOfInlineAccessBaseStructure): Deleted.
dfg/DFGSpeculativeJIT.cpp:
ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise): (JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
heap/AbstractSlotVisitor.h:
heap/AbstractSlotVisitorInlines.h: (JSC::AbstractSlotVisitor::append): (JSC::AbstractSlotVisitor::appendHidden):
heap/SlotVisitor.h:
heap/SlotVisitorInlines.h: (JSC::SlotVisitor::append): (JSC::SlotVisitor::appendHidden):
jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitNonNullDecodeStructureID): (JSC::AssemblyHelpers::emitLoadStructure):
jit/AssemblyHelpers.h:
jit/JITInlineCacheGenerator.cpp: (JSC::generateGetByIdInlineAccess): (JSC::JITPutByIdGenerator::generateBaselineDataICFastPath): (JSC::JITInByIdGenerator::generateBaselineDataICFastPath):
runtime/FunctionExecutable.cpp: (JSC::FunctionExecutable::visitChildrenImpl):
runtime/FunctionExecutable.h:
runtime/FunctionRareData.cpp: (JSC::FunctionRareData::visitChildrenImpl):
runtime/FunctionRareData.h:
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::visitChildrenImpl):
runtime/JSGlobalObject.h:
runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator): (JSC::JSPropertyNameEnumerator::visitChildrenImpl):
runtime/JSPropertyNameEnumerator.h:
runtime/StructureRareData.cpp: (JSC::StructureRareData::StructureRareData):
runtime/StructureRareData.h:
runtime/WriteBarrier.h: (JSC::WriteBarrierStructureID::WriteBarrierStructureID): (JSC::WriteBarrierStructureID::get const): (JSC::WriteBarrierStructureID::operator* const): (JSC::WriteBarrierStructureID::operator-> const): (JSC::WriteBarrierStructureID::clear): (JSC::WriteBarrierStructureID::operator bool const): (JSC::WriteBarrierStructureID::operator! const): (JSC::WriteBarrierStructureID::setWithoutWriteBarrier): (JSC::WriteBarrierStructureID::unvalidatedGet const): (JSC::WriteBarrierStructureID::value const):
runtime/WriteBarrierInlines.h: (JSC::WriteBarrierStructureID::set): (JSC::WriteBarrierStructureID::setMayBeNull): (JSC::WriteBarrierStructureID::setEarlyValue):
tools/JSDollarVM.cpp: (JSC::JSDollarVM::finishCreation): (JSC::JSDollarVM::visitChildrenImpl):
tools/JSDollarVM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:27 PM Changeset in webkit [287005] by Russell Epstein

15 edits
1 add in branches/safari-613.1.11-branch/Source/JavaScriptCore

Cherry-pick r286597. rdar://problem/86445989

Unreviewed, reverting r286502 and r286580.
https://bugs.webkit.org/show_bug.cgi?id=233930

Speedometer2 0.7% regression

Reverted changesets:

"Remove StructureIDBlob"
https://bugs.webkit.org/show_bug.cgi?id=233723
https://commits.webkit.org/r286502

"TypeInfo should be materializable from Structures as a single
load."
https://bugs.webkit.org/show_bug.cgi?id=233875
https://commits.webkit.org/r286580

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:27 PM Changeset in webkit [287004] by Russell Epstein

6 edits in branches/safari-613.1.11-branch/Source/JavaScriptCore

Cherry-pick r286580. rdar://problem/86445989

TypeInfo should be materializable from Structures as a single load.
https://bugs.webkit.org/show_bug.cgi?id=233875

Reviewed by Mark Lam.

This is mostly just the members of Structure and JSCell so that
JSType and InlineTypeFlags are at the end of the JSCell header.

assembler/testmasm.cpp: (JSC::testBranchIfType): (JSC::testBranchIfNotType):
ftl/FTLAbstractHeapRepository.cpp: (JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
runtime/JSCell.h:
runtime/JSCellInlines.h: (JSC::JSCell::JSCell):
runtime/Structure.h: (JSC::Structure::typeInfo const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:27 PM Changeset in webkit [287003] by Russell Epstein

2 edits in branches/safari-613.1.11-branch/Source/JavaScriptCore

Revert "Revert r286382. rdar://problem/86408710"

This reverts commit r286996.

6:42 PM Changeset in webkit [287002] by J Pascoe

18 edits
1 delete in trunk

Unreviewed, reverting r286993.
https://bugs.webkit.org/show_bug.cgi?id=234283

Reverted changeset:

"[WebAuthn] Allow same-site, cross-origin iframe get()"
https://bugs.webkit.org/show_bug.cgi?id=234180
https://commits.webkit.org/r286993

Patch by Commit Queue <commit-queue@webkit.org> on 2021-12-13

6:20 PM Changeset in webkit [287001] by Russell Epstein

1 copy in tags/Safari-613.1.11.5

Tag Safari-613.1.11.5.

5:52 PM Changeset in webkit [287000] by chris.reid@sony.com

8 edits
16 adds in trunk

[Curl] Improve curl's cookie conformance in WPT
https://bugs.webkit.org/show_bug.cgi?id=232722

Reviewed by Fujii Hironori.

Source/WebCore:

Fix some cases where CookieJarDB differs from WPT expectations.

platform/network/curl/CookieJarDB.cpp:

Secure and Host prefixes are now stricter.
Don't allow empty cookies to be set.

platform/network/curl/CookieUtil.cpp:

Empty paths should override previous paths in the cookie list.

platform/network/curl/NetworkStorageSessionCurl.cpp:

Tools:

WebKitTestRunner/TestController.cpp: Use a unique cookie file for each test on windows

LayoutTests:

Add baseline for wpt cookie tests on wincairo

platform/wincairo/TestExpectations:

5:50 PM Changeset in webkit [286999] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Momentum Event Dispatcher: Excessive "kick" at the beginning of scrolling (especially on 60fps displays)
https://bugs.webkit.org/show_bug.cgi?id=234279
<rdar://problem/86425321>

Reviewed by Simon Fraser.

WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::handleWheelEvent):
(WebKit::MomentumEventDispatcher::didStartMomentumPhase):
Instead of back-dating the animation to try to acquire a momentum-start
delta, pass the one we got from the event through, and start the animation
curve at momentum-start time. Also, critically, inset ourselves along
the curve by the amount of that initial delta (since the time starts now).

Tested at both 60fps and 120fps, this significantly smooths out the
transition from fingers-down phase to the generated momentum phase,
avoiding the overly large initial delta.

WebProcess/WebPage/MomentumEventDispatcher.h:

5:38 PM Changeset in webkit [286998] by ysuzuki@apple.com

10 edits in trunk/JSTests

[JSC] Update Intl tests based on ICU 69~
https://bugs.webkit.org/show_bug.cgi?id=234276

Reviewed by Mark Lam.

Rebaseline Intl tests based on ICU 69~'s CLDR update.

stress/array-toLocaleString.js:
stress/date-toLocaleString.js:
stress/intl-canonical-locale-alias-mapping.js:

(Intl.getCanonicalLocales):

stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:

(vm.icuVersion):

stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
stress/intl-datetimeformat.js:
stress/intl-enumeration.js:
stress/intl-locale-info.js:

(shouldBe):

stress/intl-locale.js:

5:06 PM Changeset in webkit [286997] by Robert Jenner

2 edits in trunk/LayoutTests

[ iOS ] 8 imported/w3c/web-platform-tests/fetch/api (layout-tests) are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=234278

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

5:00 PM Changeset in webkit [286996] by Russell Epstein

2 edits in branches/safari-613.1.11-branch/Source/JavaScriptCore

Revert r286382. rdar://problem/86408710

4:44 PM Changeset in webkit [286995] by Russell Epstein

9 edits in branches/safari-613.1.11-branch/Source

Versioning.

WebKit-7613.1.11.5

4:27 PM Changeset in webkit [286994] by sbarati@apple.com

112 edits
2 adds
5 deletes in trunk/Source

Roll back r286345, r286387, r286471, r286667, r286849
https://bugs.webkit.org/show_bug.cgi?id=234268

Reviewed by Mark Lam.

Source/JavaScriptCore:

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp:

(JSC::AccessCase::AccessCase):
(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::dump const):
(JSC::AccessCase::propagateTransitions const):
(JSC::AccessCase::generateWithGuard):
(JSC::AccessCase::canBeShared):

bytecode/AccessCase.h:

(JSC::AccessCase::structure const):
(JSC::AccessCase::newStructure const):
(JSC::AccessCase::hash const):
(JSC::AccessCase::AccessCase):

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

bytecode/ArrayProfile.h:
bytecode/CheckPrivateBrandStatus.cpp:

(JSC::CheckPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::finalizeLLIntInlineCaches):
(JSC::CodeBlock::stronglyVisitWeakReferences):

bytecode/DeleteByStatus.cpp:

(JSC::DeleteByStatus::computeForStubInfoWithoutExitSiteFeedback):

bytecode/GetByIdMetadata.h:

(JSC::GetByIdModeMetadata::GetByIdModeMetadata):
(JSC::GetByIdModeMetadata::clearToDefaultModeWithoutCache):

bytecode/GetByStatus.cpp:

(JSC::GetByStatus::computeFromLLInt):
(JSC::GetByStatus::computeForStubInfoWithoutExitSiteFeedback):

bytecode/InByStatus.cpp:

(JSC::InByStatus::computeForStubInfoWithoutExitSiteFeedback):

bytecode/InlineAccess.cpp:

(JSC::InlineAccess::rewireStubAsJumpInAccess):
(JSC::InlineAccess::resetStubAsJumpInAccess):

bytecode/InstanceOfStatus.cpp:

(JSC::InstanceOfStatus::computeForStubInfo):

bytecode/InternalFunctionAllocationProfile.h:

(JSC::InternalFunctionAllocationProfile::offsetOfStructure):
(JSC::InternalFunctionAllocationProfile::structure):
(JSC::InternalFunctionAllocationProfile::clear):
(JSC::InternalFunctionAllocationProfile::visitAggregate):
(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):
(JSC::InternalFunctionAllocationProfile::offsetOfStructureID): Deleted.

bytecode/PolyProtoAccessChain.cpp:

(JSC::PolyProtoAccessChain::needImpurePropertyWatchpoint const):

bytecode/PolyProtoAccessChain.h:
bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::visitWeak const):

bytecode/PutByIdFlags.h:
bytecode/PutByStatus.cpp:

(JSC::PutByStatus::computeFromLLInt):
(JSC::PutByStatus::computeForStubInfo):

bytecode/SetPrivateBrandStatus.cpp:

(JSC::SetPrivateBrandStatus::computeForStubInfoWithoutExitSiteFeedback):

bytecode/SpeculatedType.cpp:

(JSC::speculationFromCell):

bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initInByIdSelf):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::addAccessCase):
(JSC::StructureStubInfo::reset):
(JSC::StructureStubInfo::visitAggregateImpl):
(JSC::StructureStubInfo::visitWeakReferences):
(JSC::StructureStubInfo::propagateTransitions):
(JSC::StructureStubInfo::summary const):
(JSC::StructureStubInfo::containsPC const):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::offsetOfByIdSelfOffset):
(JSC::StructureStubInfo::offsetOfInlineAccessBaseStructure):
(JSC::StructureStubInfo::inlineAccessBaseStructure):
(JSC::StructureStubInfo::offsetOfInlineAccessBaseStructureID): Deleted.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::branchWeakStructure):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalize):

dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::compileToBooleanObjectOrOther):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitUntypedBranch):
(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateInternalFieldObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

heap/AbstractSlotVisitor.h:
heap/AbstractSlotVisitorInlines.h:
heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::runEndPhase):

heap/Heap.h:

(JSC::Heap::structureIDTable):

heap/IsoAlignedMemoryAllocator.cpp:

(JSC::IsoAlignedMemoryAllocator::IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::freeAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::tryMallocBlock): Deleted.
(JSC::IsoAlignedMemoryAllocator::freeBlock): Deleted.
(JSC::IsoAlignedMemoryAllocator::commitBlock): Deleted.
(JSC::IsoAlignedMemoryAllocator::decommitBlock): Deleted.

heap/IsoAlignedMemoryAllocator.h:
heap/IsoMemoryAllocatorBase.cpp: Removed.
heap/IsoMemoryAllocatorBase.h: Removed.
heap/IsoSubspace.cpp:

(JSC::IsoSubspace::IsoSubspace):
(JSC::IsoSubspace::tryAllocateFromLowerTier):

heap/IsoSubspace.h:
heap/PreciseAllocation.cpp:

(JSC::PreciseAllocation::createForLowerTier):
(JSC::PreciseAllocation::tryCreateForLowerTier): Deleted.

heap/PreciseAllocation.h:
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:
heap/StructureAlignedMemoryAllocator.cpp: Removed.
heap/StructureAlignedMemoryAllocator.h: Removed.
jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):
(JSC::AssemblyHelpers::emitLoadStructure):
(JSC::AssemblyHelpers::emitLoadPrototype):
(JSC::AssemblyHelpers::emitRandomThunk):
(JSC::AssemblyHelpers::emitConvertValueToBoolean):
(JSC::AssemblyHelpers::branchIfValue):
(JSC::AssemblyHelpers::emitNonNullDecodeStructureID): Deleted.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchStructure):
(JSC::AssemblyHelpers::nukeStructureAndStoreButterfly):

jit/GCAwareJITStubRoutine.cpp:

(JSC::PolymorphicAccessJITStubRoutine::computeHash):

jit/JITInlineCacheGenerator.cpp:

(JSC::generateGetByIdInlineAccess):
(JSC::JITPutByIdGenerator::generateBaselineDataICFastPath):
(JSC::JITInByIdGenerator::generateBaselineDataICFastPath):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_typeof_is_undefined):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_get_prototype_of):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_property_enumerator):

jit/JITStubRoutine.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::performLLIntGetByID):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
runtime/ArrayPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/BigIntPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/BooleanPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

runtime/DatePrototype.cpp:

(JSC::formateDateInstance):
(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedMessageString):
(JSC::ErrorInstance::sanitizedNameString):
(JSC::ErrorInstance::sanitizedToString):

runtime/ErrorPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::visitChildrenImpl):

runtime/FunctionExecutable.h:
runtime/FunctionPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildrenImpl):

runtime/FunctionRareData.h:
runtime/HasOwnPropertyCache.h:
runtime/InitializeThreading.cpp:

(JSC::initialize):

runtime/JSCConfig.h:
runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContextAssumingStructure const):
(JSC::JSValue::dumpForBacktrace const):

runtime/JSCell.cpp:

(JSC::JSCell::toObjectSlow const):

runtime/JSCell.h:

(JSC::JSCell::clearStructure):

runtime/JSCellInlines.h:

(JSC::JSCell::structure const):
(JSC::JSCell::setStructure):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildrenImpl):

runtime/JSGlobalObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::visitButterflyImpl):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::putDirectCustomGetterSetterWithoutTransition):
(JSC::JSObject::putDirectNonIndexAccessorWithoutTransition):

runtime/JSObject.h:

(JSC::JSObject::nukeStructureAndSetButterfly):
(JSC::JSObject::getPropertySlot):

runtime/JSObjectInlines.h:

(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getNonIndexPropertySlot):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectInternal):

runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator):
(JSC::JSPropertyNameEnumerator::visitChildrenImpl):

runtime/JSPropertyNameEnumerator.h:
runtime/NumberPrototype.cpp:

(JSC::toThisNumber):

runtime/ObjectPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::objectPrototypeToString):

runtime/RegExpPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/StringPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::dump const):
(JSC::Structure::canCachePropertyNameEnumerator const):

runtime/Structure.h:

(JSC::Structure::id const):

runtime/StructureChain.cpp:

(JSC::StructureChain::create):
(JSC::StructureChain::visitChildrenImpl):

runtime/StructureID.h: Removed.
runtime/StructureIDBlob.h:

(JSC::StructureIDBlob::StructureIDBlob):

runtime/StructureIDTable.cpp: Added.

(JSC::StructureIDTable::StructureIDTable):
(JSC::StructureIDTable::makeFreeListFromRange):
(JSC::StructureIDTable::resize):
(JSC::StructureIDTable::flushOldTables):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::deallocateID):

runtime/StructureIDTable.h: Added.

(JSC::nukedStructureIDBit):
(JSC::nuke):
(JSC::isNuked):
(JSC::decontaminate):
(JSC::StructureIDTable::base):
(JSC::StructureIDTable::size const):
(JSC::StructureIDTable::table const):
(JSC::StructureIDTable::decode):
(JSC::StructureIDTable::encode):
(JSC::StructureIDTable::get):
(JSC::StructureIDTable::tryGet):
(JSC::StructureIDTable::validate):
(JSC::StructureIDTable::deallocateID):
(JSC::StructureIDTable::allocateID):
(JSC::StructureIDTable::flushOldTables):

runtime/StructureRareData.cpp:

(JSC::StructureRareData::StructureRareData):

runtime/StructureRareData.h:
runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::tryCachePropertyNameEnumeratorViaWatchpoint):

runtime/SymbolPrototype.cpp:

(JSC::JSC_DEFINE_CUSTOM_GETTER):
(JSC::JSC_DEFINE_HOST_FUNCTION):

runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::processLogEntries):
(JSC::TypeProfilerLog::visit):

runtime/VM.h:

(JSC::VM::getStructure):
(JSC::VM::tryGetStructure):

runtime/WriteBarrier.h:

(JSC::WriteBarrierStructureID::WriteBarrierStructureID): Deleted.
(JSC::WriteBarrierStructureID::get const): Deleted.
(JSC::WriteBarrierStructureID::operator* const): Deleted.
(JSC::WriteBarrierStructureID::operator-> const): Deleted.
(JSC::WriteBarrierStructureID::clear): Deleted.
(JSC::WriteBarrierStructureID::operator bool const): Deleted.
(JSC::WriteBarrierStructureID::operator! const): Deleted.
(JSC::WriteBarrierStructureID::setWithoutWriteBarrier): Deleted.
(JSC::WriteBarrierStructureID::unvalidatedGet const): Deleted.
(JSC::WriteBarrierStructureID::value const): Deleted.

runtime/WriteBarrierInlines.h:

(JSC::WriteBarrierStructureID::set): Deleted.
(JSC::WriteBarrierStructureID::setMayBeNull): Deleted.
(JSC::WriteBarrierStructureID::setEarlyValue): Deleted.

tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateJSCell):

tools/Integrity.cpp:
tools/Integrity.h:
tools/IntegrityInlines.h:

(JSC::Integrity::auditStructureID):

tools/JSDollarVM.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::visitChildrenImpl):

tools/JSDollarVM.h:
wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

wasm/js/WebAssemblyGlobalPrototype.cpp:

(JSC::getGlobal):

Source/WTF:

wtf/OSAllocator.h:
wtf/posix/OSAllocatorPOSIX.cpp:

(WTF::OSAllocator::reserveUncommittedAligned): Deleted.

3:58 PM Changeset in webkit [286993] by J Pascoe

18 edits
1 add in trunk

[WebAuthn] Allow same-site, cross-origin iframe get()
https://bugs.webkit.org/show_bug.cgi?id=234180
rdar://85161142

Reviewed by Brent Fulgham.

Source/WebCore:

Added layout test cases for same-site, cross-origin get calls.

Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinator::create const):
(WebCore::doesHaveSameSiteAsAncestors):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):

Modules/webauthn/WebAuthenticationUtils.cpp:

(WebCore::buildClientDataJson):

Modules/webauthn/WebAuthenticationUtils.h:
html/FeaturePolicy.cpp:

(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):

html/FeaturePolicy.h:

Source/WebKit:

Added layout test cases for same-site, cross-origin get calls.

Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(produceClientDataJson):

UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):

LayoutTests:

Add layout test for WebAuthn get assertions on cross-site, same-sites i-frames with
publickey-credentials-get feature policy.

http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
http/wpt/webauthn/resources/util.js:

3:56 PM Changeset in webkit [286992] by ysuzuki@apple.com

7 edits in trunk/Source/JavaScriptCore

[JSC] Use FixedVector for wasm exception in Wasm::Instance
https://bugs.webkit.org/show_bug.cgi?id=234224

Reviewed by Saam Barati.

Since we know # of exception tags when instantiating Wasm::Instance,
we can use FixedVector instead of Vector. This is the same to Table,
Functions etc.

We also remove Wasm::Tag::m_id. Since we do not copy Wasm::Tag and
we always allocate Wasm::Tag from heap, we can just use pointer
comparison. Then, we do not need to have this m_id.

wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::setTag):
(JSC::Wasm::Instance::addTag): Deleted.

wasm/WasmInstance.h:
wasm/WasmModuleInformation.h:

(JSC::Wasm::ModuleInformation::internalExceptionCount const):

wasm/WasmTag.cpp:
wasm/WasmTag.h:

(JSC::Wasm::Tag::create): Deleted.
(JSC::Wasm::Tag::parameterCount const): Deleted.
(JSC::Wasm::Tag::parameter const): Deleted.
(JSC::Wasm::Tag::operator== const): Deleted.
(JSC::Wasm::Tag::operator!= const): Deleted.
(JSC::Wasm::Tag::signature const): Deleted.
(JSC::Wasm::Tag::Tag): Deleted.

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::initializeImportsAndExports):

3:49 PM Changeset in webkit [286991] by Alan Coon

7 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r286919. rdar://problem/86247557

Momentum Event Dispatcher: Tail frames are the wrong velocity if momentum event dispatch rate doesn't match screen refresh rate
https://bugs.webkit.org/show_bug.cgi?id=234168
<rdar://problem/86247557>

Reviewed by Simon Fraser.

In r286671, I scaled the tail frames into the momentum event disaptch
rate, but they are actually always dispatched at display refresh
frequency. In many cases these things are the same, but in some
cases can differ (most commonly a 120Hz display with 60Hz event dispatch),
so to always have the tail move at the right rate, scale into the display
refresh rate instead).

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::windowScreenDidChange):
WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::pageScreenDidChange):
WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebPage/EventDispatcher.messages.in:
WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::didStartMomentumPhase): (WebKit::MomentumEventDispatcher::displayProperties const): (WebKit::MomentumEventDispatcher::startDisplayLink): (WebKit::MomentumEventDispatcher::stopDisplayLink): (WebKit::MomentumEventDispatcher::pageScreenDidChange): (WebKit::MomentumEventDispatcher::displayWasRefreshed): (WebKit::MomentumEventDispatcher::displayID const): Deleted.
WebProcess/WebPage/MomentumEventDispatcher.h: Plumb and store the nominal display refresh rate.

(WebKit::MomentumEventDispatcher::buildOffsetTableWithInitialDelta):
Scale the tail frames from the 60Hz ideal rate into the display refresh
rate, instead of the event dispatch rate.

Incoming events still scale *in* from the event dispatch rate, since
that's... the rate they come at.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:45 PM Changeset in webkit [286990] by Ryan Haddad

2 edits
7 adds in trunk/LayoutTests

Unreviewed test gardening for rdar://80334322, rebaseline tests for Monterey.

platform/mac-bigsur/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
platform/mac-bigsur/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
platform/mac-wk1/TestExpectations:
platform/mac/fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
platform/mac/fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.

3:41 PM Changeset in webkit [286989] by Alan Coon

1 edit in branches/safari-612-branch/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h

Unreviewed build fix. rdar://problem/86385697

./page/scrolling/ThreadedScrollingTree.cpp:452:19: error: 'updateScrollPositionAtLastDisplayRefresh' is a protected member of 'WebCore::ScrollingTreeScrollingNode'

3:31 PM Changeset in webkit [286988] by commit-queue@webkit.org

6 edits in trunk

A FormData constructed in the form's submit event listener shouldn't include the submitter
https://bugs.webkit.org/show_bug.cgi?id=234069

Patch by Andreu Botella <andreu@andreubotella.com> on 2021-12-13
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:

Source/WebCore:

In the HTML spec, the "construct the entry list" algorithm takes an optional submitter
argument which it uses to determine whether a button should be included in the entry list.
The FormData constructor calls it with no optional arguments, so new FormData(form) should
never contain any buttons.

In WebKit, however, if a FormData object is constructed in the form's submit event
listener, it will contain the submitter button, if the form submission wasn't implicit. This
is because whether a form control is the submitter is tracked on the control, and activating
it sets that state for the duration of the form submission algorithm.

However, the form submission algorithm also sets a submitter's state, to deal with implicit
submissions. This is set only for the duration of the "construct the entry list" call, and
so there is no need to set the state when activating the button.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set.html

html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent):

html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

3:14 PM Changeset in webkit [286987] by graouts@webkit.org

2 edits in trunk/Source/WTF

CustomEffect and animation frame rate should be disabled by default in STP
https://bugs.webkit.org/show_bug.cgi?id=234251

Reviewed by Dean Jackson.

Scripts/Preferences/WebPreferencesExperimental.yaml:

3:01 PM Changeset in webkit [286986] by Chris Dumez

2 edits in trunk/Source/WTF

Unreviewed build fix after r286971.

wtf/spi/darwin/dyldSPI.h:

2:51 PM Changeset in webkit [286985] by Devin Rousso

4 edits in trunk/Source/WebInspectorUI

Web Inspector: remove coloring of Web Inspector area in dock icons
https://bugs.webkit.org/show_bug.cgi?id=234262

Reviewed by Patrick Angle.

It looks too strong/bold and draws way too much attention. It also doesn't match the styling
of other nearby icons.

UserInterface/Images/DockBottom.svg:
UserInterface/Images/DockLeft.svg:
UserInterface/Images/DockRight.svg:

2:50 PM Changeset in webkit [286984] by Alan Coon

3 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r286907. rdar://problem/86307593

[Cocoa] -[AVPlayerItem liveUpdateInterval] can hang the main thread for ~60ms
https://bugs.webkit.org/show_bug.cgi?id=234131

Reviewed by Eric Carlson.

Direct property access of AVFoundation objects can take tens of milliseconds to return
a value, even for simple properties. This impacts scrolling responsiveness.

-liveUpdateInterval is not KVO-observable, but only changes when -seekableTimeRanges does
as well. Query and cache that property during KVO of -seekableTimeRanges.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesLastModifiedTime const): (WebCore::MediaPlayerPrivateAVFoundationObjC::liveUpdateInterval const): (WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange): (-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:34 PM Changeset in webkit [286983] by Jean-Yves Avenard

73 edits in trunk

Add SharedBufferBuilder class
https://bugs.webkit.org/show_bug.cgi?id=233442
rdar://85693939

Reviewed by Youenn Fablet.

Source/WebCore:

Similar to StringBuilder, a SharedBuffer can now only be modified through
a SharedBufferBuilder. A SharedBuffer becomes immutable once created.

A SharedBufferBuilder is a replacement to RefPtr<SharedBuffer>.
There exists a difference between a null and empty state.
Following a call to reset(), SharedBufferBuilder::isNull()
will return true as opposed to empty() which will create the underlying
SharedBuffer but with a size of 0.
A null SharedBufferBuilder indicates that append was never called on it
(even with an empty SharedBuffer).
It is not necessary to check if the SharedBufferBuilder is null before
calling copy() or take() as an empty SharedBuffer will be created if
none exists.
These design decisions were made due to how SharedBuffer are currently used
and to minimise the logic change as some places would distinguish between
the two states or would always create an empty SharedBuffer and only check
its size.
In the future, removing the distinction between null and pty would be
preferable.

While the aim was to guarantee that a SharedBuffer once built was immutable.
This goal wasn't entirely achieved as it is still possible to retrieve a RefPtr
to a SharedBuffer and continue to append to it through its SharedBufferBuilder
owner. Full immutability could be fully achieved with having get() return a
shallow copy which is a relatively cheap operation.

Fly-By fixes: Pass SharedBuffer via const references or pointers where it's easy
to do so.
No change in observable behaviour; covered by existing tests.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::clean):
(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::append):
(WebCore::FetchBodyConsumer::setData):
(WebCore::FetchBodyConsumer::takeData):
(WebCore::FetchBodyConsumer::takeAsArrayBuffer):
(WebCore::FetchBodyConsumer::takeAsBlob):
(WebCore::FetchBodyConsumer::takeAsText):
(WebCore::FetchBodyConsumer::setSource):

Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::data const):
(WebCore::FetchBodyConsumer::setData): Deleted.

Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::setSourceURL):
(WebCore::HTMLModelElement::dataReceived):
(WebCore::HTMLModelElement::notifyFinished):

Modules/model-element/HTMLModelElement.h:
inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::hasData const):
(WebCore::NetworkResourcesData::ResourceData::dataLength const):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):

inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::hasBufferedData const):
(WebCore::NetworkResourcesData::ResourceData::hasData const): Deleted.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::setDataBufferingPolicy):
(WebCore::ResourceLoader::addDataOrBuffer):
(WebCore::ResourceLoader::resourceData const):
(WebCore::ResourceLoader::clearResourceData):

loader/ResourceLoader.h:

(WebCore::ResourceLoader::resourceData const): Deleted.

loader/SubstituteResource.h:

(WebCore::SubstituteResource::data const):
(WebCore::SubstituteResource::append):
(WebCore::SubstituteResource::clear):
(WebCore::SubstituteResource::deliver):

loader/appcache/ApplicationCacheResourceLoader.cpp:

(WebCore::ApplicationCacheResourceLoader::dataReceived):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):

loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseNextPart):

loader/cache/CachedApplicationManifest.cpp:

(WebCore::CachedApplicationManifest::finishLoading):

loader/cache/CachedApplicationManifest.h:
loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::finishLoading):

loader/cache/CachedCSSStyleSheet.h:
loader/cache/CachedFont.cpp:

(WebCore::CachedFont::finishLoading):

loader/cache/CachedFont.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::updateBufferInternal):
(WebCore::CachedImage::convertedDataIfNeeded const):
(WebCore::CachedImage::updateBuffer):
(WebCore::CachedImage::finishLoading):

loader/cache/CachedImage.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::updateBuffer):
(WebCore::CachedRawResource::finishLoading):

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::updateBuffer):
(WebCore::CachedResource::finishLoading):

loader/cache/CachedResource.h:
loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::finishLoading):

loader/cache/CachedSVGDocument.h:
loader/cache/CachedScript.cpp:

(WebCore::CachedScript::finishLoading):

loader/cache/CachedScript.h:
loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::doUpdateBuffer):
(WebCore::CachedTextTrack::updateBuffer):
(WebCore::CachedTextTrack::finishLoading):

loader/cache/CachedTextTrack.h:
loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::finishLoading):

loader/cache/CachedXSLStyleSheet.h:
loader/ios/LegacyPreviewLoader.h:
loader/ios/LegacyPreviewLoader.mm:

(WebCore::LegacyPreviewLoader::previewConverterDidStartConverting):
(WebCore::LegacyPreviewLoader::provideMainResourceForPreviewConverter):

platform/PreviewConverter.cpp:

(WebCore::PreviewConverter::previewData const):
(WebCore::PreviewConverter::replayToClient):

platform/PreviewConverter.h:
platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):

platform/SharedBuffer.h:

(WebCore::SharedBufferBuilder::SharedBufferBuilder):
(WebCore::SharedBufferBuilder::append):
(WebCore::SharedBufferBuilder::operator bool const):
(WebCore::SharedBufferBuilder::isNull const):
(WebCore::SharedBufferBuilder::isEmpty const):
(WebCore::SharedBufferBuilder::size const):
(WebCore::SharedBufferBuilder::reset):
(WebCore::SharedBufferBuilder::empty):
(WebCore::SharedBufferBuilder::get const):
(WebCore::SharedBufferBuilder::copy const):
(WebCore::SharedBufferBuilder::take):
(WebCore::SharedBufferBuilder::ensureBuffer):

platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::extractKeyidsFromCencInitData):
(WebCore::extractKeyIdFromWebMInitData):

platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):

platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):
(WebCore::InitData::append):
(WebCore::InitData::payload const):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readICCProfile):

platform/ios/PreviewConverterIOS.mm:

(WebCore::PreviewConverter::PreviewConverter):

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::~MediaRecorderPrivateWriter):
(WebCore::MediaRecorderPrivateWriter::appendData):
(WebCore::MediaRecorderPrivateWriter::takeData):

platform/network/cocoa/RangeResponseGenerator.mm:

(WebCore::RangeResponseGenerator::Data::Data):
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):
(WebCore::RangeResponseGenerator::expectedContentLengthFromData):

workers/ScriptBuffer.cpp:

(WebCore::ScriptBuffer::ScriptBuffer):
(WebCore::ScriptBuffer::toString const):
(WebCore::ScriptBuffer::containsSingleFileMappedSegment const):
(WebCore::ScriptBuffer::append):

workers/ScriptBuffer.h:

(WebCore::ScriptBuffer::buffer const):
(WebCore::ScriptBuffer::isolatedCopy const):
(WebCore::ScriptBuffer::isEmpty const):

workers/WorkerFontLoadRequest.cpp:

(WebCore::WorkerFontLoadRequest::WorkerFontLoadRequest):
(WebCore::WorkerFontLoadRequest::isPending const):
(WebCore::WorkerFontLoadRequest::ensureCustomFontData):
(WebCore::WorkerFontLoadRequest::didReceiveData):

workers/WorkerFontLoadRequest.h:
xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::createResponseBlob):
(WebCore::XMLHttpRequest::createResponseArrayBuffer):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didReceiveData):

xml/XMLHttpRequest.h:

Source/WebKit:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveBuffer):
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):

NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
UIProcess/WebURLSchemeTask.cpp:

(WebKit::WebURLSchemeTask::WebURLSchemeTask):
(WebKit::WebURLSchemeTask::didReceiveData):
(WebKit::WebURLSchemeTask::didComplete):

UIProcess/WebURLSchemeTask.h:
WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
(WebKit::PluginView::manualLoadDidReceiveData):
(WebKit::PluginView::manualLoadDidFail):
(WebKit::PluginView::liveResourceData const):
(WebKit::PluginView::redeliverManualStream):

WebProcess/Plugins/PluginView.h:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::continueDidReceiveResponse):

WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:

(WebKit::WebPreviewLoaderClient::didFinishLoading):
(WebKit::WebPreviewLoaderClient::didFail):

WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.h:

Source/WebKitLegacy/win:

WebFrame.cpp:

(WebFrame::loadData):

Tools:

Update API tests.

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:

(TestWebKitAPI::TEST_F):

2:32 PM Changeset in webkit [286982] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, reverting r283354.
https://bugs.webkit.org/show_bug.cgi?id=234273

causes missing content with clip-path

Reverted changeset:

"[Performance] Optimize
RenderLayer::clipCrossesPaintingBoundary"
https://bugs.webkit.org/show_bug.cgi?id=230885
https://commits.webkit.org/r283354

2:19 PM Changeset in webkit [286981] by Ryan Haddad

2 edits in trunk/LayoutTests

LFC][IFC] Add partial unicode-bidi support on inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=234196

Unreviewed test gardening.

platform/ios/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Rebaseline test for iOS.

2:04 PM Changeset in webkit [286980] by Robert Jenner

2 edits in trunk/LayoutTests

REGRESSION (r286259): [ BigSur+ wk1 ] 2X imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures
https://bugs.webkit.org/show_bug.cgi?id=234105

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

1:21 PM Changeset in webkit [286979] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[WP][iOS] Add access to required system call
https://bugs.webkit.org/show_bug.cgi?id=234232
<rdar://86343811>

Reviewed by Brent Fulgham.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

1:16 PM Changeset in webkit [286978] by commit-queue@webkit.org

7 edits in trunk/Source

[GTK] Fix ANGLE compilation
https://bugs.webkit.org/show_bug.cgi?id=233327

Patch by Alejandro G. Castro <alex@igalia.com> on 2021-12-13
Reviewed by Kenneth Russell.

Source/ThirdParty/ANGLE:

There is a define with a typo in the name and activating EGL and
X11 does not work at the same time.

PlatformGTK.cmake:

Source/WebCore:

No tests required.

Fixed the issues to make the engine work with -DUSE_ANGLE_WEBGL=ON
defined.

platform/graphics/GLContext.cpp:

(WebCore::initializeOpenGLShimsIfNeeded): In case of GTK and WPE
initially we are going to keep TextureMapper using system GL
libraries, even when we are using ANGLE for WebGL, so we need the
shims definitions.

platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:

(Nicosia::GCGLLayer::swapBuffersIfNeeded): We need to allocate and
update the layer buffer in the compositor thread to make sure it
is handled in just one thread.

12:57 PM Changeset in webkit [286977] by Alan Coon

12 edits in branches/safari-612-branch/Source

Cherry-pick r286905. rdar://problem/86235740

Scrolling can drop frames when CoreAnimation commits take a long time
https://bugs.webkit.org/show_bug.cgi?id=234160
<rdar://86235740>

Reviewed by Tim Horton.

In r261985 I added a mechanism that has the scrolling thread wait for the main thread to
finish a rendering update, and, if the main thread fails to complete in time, then the
scrolling thread commits. This allows for scrolling synchronization when the main thread is
responsive, but smooth scrolling when the main thread is busy.

However, r261985 only waits for WebKit work to finish; what we really care about is whether
the main thread completes its CA commit in time (because that determines whether the scroll
shows on the screen).

So plumb through pre-/post-commit hooks from TiledCoreAnimationDrawingArea, which already
had them for inspector instrumentation. Then have ThreadedScrollingTree notify
m_stateCondition in didCompletePlatformRenderingUpdate(), instead of
didCompleteRenderingUpdate().
Source/WebCore:

Also, now we can call the inspector hooks from Page, rather than out in TiledCoreAnimationDrawingArea.

page/Page.cpp: (WebCore::Page::willStartPlatformRenderingUpdate): (WebCore::Page::didCompletePlatformRenderingUpdate):
page/Page.h:
page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::willStartPlatformRenderingUpdate): (WebCore::ScrollingCoordinator::didCompletePlatformRenderingUpdate):
page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::didCompletePlatformRenderingUpdate): (WebCore::ThreadedScrollingTree::didCompleteRenderingUpdate): Deleted.
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm: (WebCore::ScrollingCoordinatorMac::didCompletePlatformRenderingUpdate):

Source/WebKit:

Also, now we can call the inspector hooks from Page, rather than out in TiledCoreAnimationDrawingArea.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::willStartPlatformRenderingUpdate): (WebKit::WebPage::didCompletePlatformRenderingUpdate):
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:57 PM Changeset in webkit [286976] by Alan Coon

3 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r286834. rdar://problem/86427901

Inspector "composite" events are all very short
https://bugs.webkit.org/show_bug.cgi?id=234114
<rdar://86299391>

Reviewed by Tim Horton.

The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
time to include painting so use kCATransactionPhasePreLayout.

WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:56 PM Changeset in webkit [286975] by Alan Coon

6 edits in branches/safari-612-branch/Source/WebCore

Cherry-pick r286932. rdar://problem/86385697

Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
https://bugs.webkit.org/show_bug.cgi?id=234213

Reviewed by Tim Horton.

On a page where CA commits on the main thread take a long time (e.g. because of expensive
painting), it's possible that the main thread has updated the scrolling layer position, and
then the scrolling thread detects that the commit is taking a long time and attempts to
trigger its own commit, but because the layer position property doesn't change, no commit
occurs.

Work around this by setting the layer position to 0,0 and back when we're on the scrolling
thread. Only do this if the scroll position changed since the last display refresh to avoid
triggering redundant commits.

Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
trees can get large so for now just apply this to the root node.

page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):
page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread): (WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):
page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm: (WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:56 PM Changeset in webkit [286974] by Alan Coon

6 edits in branches/safari-612-branch/Source

Cherry-pick r286858. rdar://problem/86423741

Use simpler idioms for std::less and std::greater possible in modern C++
https://bugs.webkit.org/show_bug.cgi?id=234117

Reviewed by Anders Carlsson.

Source/WebCore:

testing/InternalsMapLike.cpp: (WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit use of std:less, because this is what std::sort by default.

Source/WebKit:

WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded template arguments for std::greater, and removed explicit use of std::less, since that's what std::sort does by default.

Source/WTF:

wtf/ListDump.h: (WTF::sortedListDump): Removed unnecessary template arguments to std::less.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:56 PM Changeset in webkit [286973] by Alan Coon

3 edits in branches/safari-612-branch/Source/WebKit

Cherry-pick r286900. rdar://problem/86344954

Momentum Event Dispatcher: Magic Mouse doesn't use momentum event dispatcher
https://bugs.webkit.org/show_bug.cgi?id=234189
<rdar://problem/86344954>

Reviewed by Simon Fraser.

Shared/mac/ScrollingAccelerationCurveMac.mm: (WebKit::fromIOHIDDevice): Fix the FIXME here about the additional fallback values; it turns out Magic Mouse is one device that does not have a value for kIOHIDScrollAccelerationTypeKey, so we need the full fallback chain to support it.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::sendWheelEvent): Un-wrapping this optional results in losing the engaged state, and sending a garbage ScrollingAccelerationCurve across the wire. The message argument is also an optional, so just pass it along.

The result of this bug was that if you had ever used a device with a curve
for a given page, and then used a device with no curve, MomentumEventDispatcher
would have a garbage curve (from this message trying to "unset" the optional),
and a garbage curve results in chaotic scrolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:38 PM Changeset in webkit [286972] by Antti Koivisto

5 edits in trunk

[CSS Cascade Layers] Layers specified in import rules can not be reordered on media query evaluation
https://bugs.webkit.org/show_bug.cgi?id=234158

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-cascade/layer-media-query-expected.txt:

Source/WebCore:

style/RuleSetBuilder.cpp:

(WebCore::Style::RuleSetBuilder::addChildRules):
(WebCore::Style::RuleSetBuilder::addRulesFromSheetContents):

@import rules can introduce new layers so need to alse be considered for reordering by media queries
(which requires static evaluation).

(WebCore::Style::RuleSetBuilder::disallowDynamicMediaQueryEvaluationIfNeeded):

Factor into a function.

style/RuleSetBuilder.h:

12:29 PM Changeset in webkit [286971] by Chris Dumez

6 edits in trunk/Source

Regression(r283565) Unable to report private messages as Spam in Twitter app
https://bugs.webkit.org/show_bug.cgi?id=234253
<rdar://86043227>

Reviewed by Alex Christensen.

Source/WebCore:

Add macro for new linkedOnOrAfter check for sending the Authorization header
on same origin redirects.

platform/cocoa/VersionChecks.h:

Source/WebKit:

In r283565, we aligned WebKit's behavior with the Fetch specification and with
Gecko / Blink by keeping the Authorization header on same origin redirects.

However, when reporting a private message in the twitter app, it does a
same-origin redirect from https://twitter.com/account/authenticate_web_view?...
to https://twitter.com/account/authenticate_web_view?... and the HTTP server
reponds with a 401/Unauthorized when we send the Authorization on the post-redirect
request. As far as I can tell, our behavior is correct here and I suspect this is an
issue with the twitter server. As a result, I am simply gating the new behavior
behind a linked-on-or-after check to give twitter a chance to address the issue on
their end.

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

Source/WTF:

Add some new iOS / macOS versions.

wtf/spi/darwin/dyldSPI.h:

12:28 PM Changeset in webkit [286970] by youenn@apple.com

5 edits
2 adds in trunk

FetchResponse::clone should use the relevant realm for the cloned response
https://bugs.webkit.org/show_bug.cgi?id=234238

Reviewed by Alexey Shvayka.

Source/WebCore:

Reuse the relevant realm for cloning as per https://fetch.spec.whatwg.org/#dom-response-clone step 3.
If context is stopped, throw an InvalidStateError exception, like done in Chrome.

Test: http/wpt/fetch/clone-realm.html

Modules/fetch/FetchResponse.cpp:
Modules/fetch/FetchResponse.h:
Modules/fetch/FetchResponse.idl:

LayoutTests:

http/wpt/fetch/clone-realm-expected.txt: Added.
http/wpt/fetch/clone-realm.html: Added.

12:25 PM Changeset in webkit [286969] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

ExecutableAllocator: Do not store things in g_config when USE(SYSTEM_MALLOC).
https://bugs.webkit.org/show_bug.cgi?id=232165

Patch by waddlesplash <waddlesplash@gmail.com> on 2021-12-13
Reviewed by Yusuke Suzuki.

Following r281910 two additional slots were added
to g_config in order to store these pointers for use in bmalloc and Gigacage. However, when
USE(SYSTEM_MALLOC) is enabled, there are no slots reserved for Gigacage, and so this collided
with g_wtfConfig and overwrote data there instead.

This should fix crashes seen on Haiku, which enables USE(SYSTEM_MALLOC).

jit/ExecutableAllocator.cpp:

(JSC::initializeJITPageReservation):

12:21 PM Changeset in webkit [286968] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Simple RTL content does not need visual reordering
https://bugs.webkit.org/show_bug.cgi?id=234252

Reviewed by Antti Koivisto.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

layout/formattingContexts/inline/InlineItemsBuilder.h:

(WebCore::Layout::InlineItemsBuilder::needsVisualReordering const):
(WebCore::Layout::InlineItemsBuilder::needsVisualReordeering const): Deleted.

12:19 PM Changeset in webkit [286967] by Russell Epstein

1 copy in tags/Safari-613.1.11.4

Tag Safari-613.1.11.4.

12:19 PM Changeset in webkit [286966] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

[ macOS and iOS ] editing/deleting/forward-delete-crash.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=230047

Patch by Rob Buis <rbuis@igalia.com> on 2021-12-13
Reviewed by Wenson Hsieh.

Rewrite forward-delete-crash.html to avoid the timeouts on
macOS and iOS.

editing/deleting/forward-delete-crash.html:
platform/ipad/TestExpectations:
platform/mac/TestExpectations:

12:12 PM Changeset in webkit [286965] by youenn@apple.com

2 edits in trunk/Source/WebCore

Fix buggy assert in CoreAudioSharedUnit::setupAudioUnit
https://bugs.webkit.org/show_bug.cgi?id=234151

Reviewed by Eric Carlson.

Add the source as a client to the unit before reconfiguring the unit,
this makes the ASSERT(hasClients()) actually valid.
Manually tested.

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

11:59 AM Changeset in webkit [286964] by Kyle Piddington

4 edits in trunk/Source/ThirdParty/ANGLE

[MacCatalyst] fix iOSMac after refactor in r286899
https://bugs.webkit.org/show_bug.cgi?id=234250

Reviewed by Dean Jackson.

Also includes a longer term fix for
https://bugs.webkit.org/show_bug.cgi?id=233977

Tested builds on mac, iOS, TV SDKs, plus iOSMac

src/common/platform.h:
src/libANGLE/renderer/metal/gen_mtl_format_table.py:

(gen_image_map_switch_string):

src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:

(rx::mtl::Format::init):

11:56 AM Changeset in webkit [286963] by Angelos Oikonomopoulos

2 edits in trunk/Tools

[JSC] Unify default/noisy tests definition
https://bugs.webkit.org/show_bug.cgi?id=233926

Reviewed by Yusuke Suzuki.

Currently, changing a test to be noisy (i.e. using
defaultRunNoisyTest) results in only a subset of the tests being
run.

Instead of manually changing the noisy test test handler, this
patch makes the mode definitions table-driven. However, for
compatibility with the existing code, it uses the table to define
the ruby methods that the testcase definitions (@ comments,
yaml) and other callers in run-jsc-stress-tests (e.g. all
default*Run methods) expect.

Note that this slightly increases the number of tests executed (as
more test modes are enabled for the noisy tests).

This is an exploratory first step; other callers in
run-jsc-stress-tests could be simplified in the same way.

Scripts/run-jsc-stress-tests:

11:55 AM Changeset in webkit [286962] by Nikolas Zimmermann

14 edits
2 moves in trunk/Source/WebCore

[LBSE] Rename RenderSVGModelObject -> LegacyRenderSVGModelObject
https://bugs.webkit.org/show_bug.cgi?id=234235

Reviewed by Rob Buis.

RenderSVGModelObject will inherit from RenderLayerModelObject in LBSE,
therefore rename the current implementation to LegacyRenderSVGRoot and
adapt all callsites.

Covered by existing tests, no change in behaviour.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

rendering/RenderObject.cpp:

(WebCore::RenderObject::computedFragmentedFlowState):

rendering/RenderObject.h:

(WebCore::RenderObject::isLegacyRenderSVGModelObject const):
(WebCore::RenderObject::isRenderOrLegacyRenderSVGModelObject const):

rendering/svg/LegacyRenderSVGModelObject.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGModelObject.cpp.

(WebCore::LegacyRenderSVGModelObject::LegacyRenderSVGModelObject):
(WebCore::LegacyRenderSVGModelObject::clippedOverflowRect const):
(WebCore::LegacyRenderSVGModelObject::computeFloatVisibleRectInContainer const):
(WebCore::LegacyRenderSVGModelObject::mapLocalToContainer const):
(WebCore::LegacyRenderSVGModelObject::pushMappingToContainer const):
(WebCore::LegacyRenderSVGModelObject::outlineBoundsForRepaint const):
(WebCore::LegacyRenderSVGModelObject::absoluteRects const):
(WebCore::LegacyRenderSVGModelObject::absoluteQuads const):
(WebCore::LegacyRenderSVGModelObject::willBeDestroyed):
(WebCore::LegacyRenderSVGModelObject::styleDidChange):
(WebCore::LegacyRenderSVGModelObject::nodeAtPoint):
(WebCore::LegacyRenderSVGModelObject::absoluteFocusRingQuads):
(WebCore::LegacyRenderSVGModelObject::checkIntersection):
(WebCore::LegacyRenderSVGModelObject::checkEnclosure):

rendering/svg/LegacyRenderSVGModelObject.h: Renamed from Source/WebCore/rendering/svg/RenderSVGModelObject.h.
rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::RenderSVGContainer):
(WebCore::RenderSVGContainer::layout):

rendering/svg/RenderSVGContainer.h:
rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):
(WebCore::RenderSVGImage::willBeDestroyed):
(WebCore::RenderSVGImage::imageElement const):
(WebCore::RenderSVGImage::layout):

rendering/svg/RenderSVGImage.h:
rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::layout):

rendering/svg/RenderSVGShape.h:
rendering/svg/RenderSVGShapeInlines.h:

(WebCore::RenderSVGShape::graphicsElement const):

svg/SVGSVGElement.cpp:

(WebCore::checkIntersectionWithoutUpdatingLayout):
(WebCore::checkEnclosureWithoutUpdatingLayout):

11:52 AM Changeset in webkit [286961] by youenn@apple.com

3 edits in trunk/Source/WebKit

REGRESSION (r286841): [ iOS ] Many webrtc tests flaky failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=234181
<rdar://problem/86343642>

Reviewed by Eric Carlson.

Use network connection state change callback to know when connection fails or is cancelled.
Introduce ConnectionStateTracker to know when to stop reading new UDP packets.
ConnectionStateTracker will be stopped when state is changed to failed or cancelled as well as when the whole connection is closed.
Renaming m_nwConnections to m_connections as m_nwConnections name was already used.
Reduce error logging to only new error codes or when connectino enters unrecoverable failure (hence changing to failed state).

Covered by existing tests.

NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.h:
NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:

11:46 AM Changeset in webkit [286960] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
https://bugs.webkit.org/show_bug.cgi?id=232235
<rdar://problem/84878815>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-12-13
Reviewed by Dean Jackson.

Remove validation for IOSurface element size when a IOSurface is bound
to a pbuffer. The IOSurfaceGetBytesPerElementOfPlane is not valid for some internal formats
that might be compressed.

Will add a WebKit level test in subsequent fix.
Will add an ANGLE level test during upstreaming of the patch.

Same as "Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]"
but this time for CGL.
https://webkit.org/b/218637 rdar://problem/71102126

Remove incorrect validation that IOSurface pixel format matches
the pixel format of the texture image being specified.

The "Element" in IOSurface is a block of pixels, while the validation assumed
it means one pixel. The validation failed for a compressed format.

Currently we map non-public YUV formats, to which there is no elequent way
of implementing the validation.

src/libANGLE/renderer/gl/cgl/IOSurfaceSurfaceCGL.cpp:

(rx::IOSurfaceSurfaceCGL::validateAttributes):

11:10 AM Changeset in webkit [286959] by Alan Coon

8 edits in branches/safari-612-branch/Source

Versioning.

WebKit-7612.4.4

10:35 AM Changeset in webkit [286958] by commit-queue@webkit.org

33 edits in trunk

Deployment target for macOS 11+ does not follow minor version bumps
https://bugs.webkit.org/show_bug.cgi?id=233906

Patch by Elliott Williams <Elliott Williams> on 2021-12-13
Reviewed by Alexey Proskuryakov.
Source/bmalloc:

Configurations/DebugRelease.xcconfig:

Source/JavaScriptCore:

Configurations/DebugRelease.xcconfig:

Source/WebCore:

Changes the deployment target for macOS 11 and above to use the default SDK version, instead
of looking up a version using TARGET_MAC_OS_X_VERSION_MAJOR.

Prior to macOS 11, the deployment target did NOT change between minor versions (e.g.
"10.15" was the deployment target for all builds of 10.15.x). Now, minor releases may
change the deployment target, so we cannot rely solely on the MAC_OS_X_VERSION_MAJOR to
determine what deployment target to build for.

Since the deployment target may change within different versions of a major release,
TARGET_MAC_OS_X_VERSION_MAJOR is no longer useful for selecting a deployment target. It
should be considered read-only. To build for a non-default macOS version, set the
deployment target directly.

Reverts changes made in https://commits.webkit.org/230363@main, now that Xcode has been
fixed in rdar://problem/70185899.

Configurations/DebugRelease.xcconfig:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::variationAxes): Removes a defensive unguarded-availability pragma, now that the
underlying issue is fixed.

Source/WebGPU:

Configurations/DebugRelease.xcconfig:

Source/WebInspectorUI:

Configurations/DebugRelease.xcconfig:

Source/WebKit:

Configurations/DebugRelease.xcconfig:

Source/WTF:

Configurations/DebugRelease.xcconfig:
wtf/PlatformHave.h: Add feature define which has been public since macOS 11.0

10:32 AM Changeset in webkit [286957] by Alan Bujtas

11 edits in trunk/Source/WebCore

[LFC][IFC] Display boxes have physical geometry.
https://bugs.webkit.org/show_bug.cgi?id=234248

Reviewed by Antti Koivisto.

logicalRect -> rect.

display/css/DisplayBoxFactory.cpp:

(WebCore::Display::BoxFactory::displayBoxForTextRun const):

layout/Verification.cpp:

(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processOverflownRunsForEllipsis):

layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeStaticPositionForOutOfFlowContent):

layout/formattingContexts/inline/display/InlineDisplayBox.h:

(WebCore::InlineDisplay::Box::rect const):
(WebCore::InlineDisplay::Box::top const):
(WebCore::InlineDisplay::Box::bottom const):
(WebCore::InlineDisplay::Box::left const):
(WebCore::InlineDisplay::Box::right const):
(WebCore::InlineDisplay::Box::width const):
(WebCore::InlineDisplay::Box::height const):
(WebCore::InlineDisplay::Box::moveVertically):
(WebCore::InlineDisplay::Box::moveHorizontally):
(WebCore::InlineDisplay::Box::setLeft):
(WebCore::InlineDisplay::Box::setRight):
(WebCore::InlineDisplay::Box::setRect):
(WebCore::InlineDisplay::Box::Box):
(WebCore::InlineDisplay::Box::truncate):
(WebCore::InlineDisplay::Box::logicalRect const): Deleted.
(WebCore::InlineDisplay::Box::logicalTop const): Deleted.
(WebCore::InlineDisplay::Box::logicalBottom const): Deleted.
(WebCore::InlineDisplay::Box::logicalLeft const): Deleted.
(WebCore::InlineDisplay::Box::logicalRight const): Deleted.
(WebCore::InlineDisplay::Box::logicalWidth const): Deleted.
(WebCore::InlineDisplay::Box::logicalHeight const): Deleted.
(WebCore::InlineDisplay::Box::setLogicalLeft): Deleted.
(WebCore::InlineDisplay::Box::setLogicalRight): Deleted.
(WebCore::InlineDisplay::Box::setLogicalRect): Deleted.

layout/integration/InlineIteratorBoxModernPath.h:

(WebCore::InlineIterator::BoxModernPath::rect const):

layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::showInlineContent):

layout/integration/LayoutIntegrationInlineContentBuilder.cpp:

(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):

layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
(WebCore::LayoutIntegration::LineLayout::collectInlineBoxRects const):
(WebCore::LayoutIntegration::LineLayout::hitTest):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::showInlineTreeAndRuns):

10:30 AM Changeset in webkit [286956] by Russell Epstein

9 edits in branches/safari-613.1.11-branch/Source

Versioning.

WebKit-7613.1.11.4

10:23 AM Changeset in webkit [286955] by ntim@apple.com

8 edits in trunk

Fix paint order of CSS text decorations
https://bugs.webkit.org/show_bug.cgi?id=227445

Reviewed by Simon Fraser.

Source/WebCore:

rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::createDecorationPainter):
(WebCore::TextBoxPainter::paintBackgroundDecorations):
(WebCore::TextBoxPainter::paintForegroundDecorations):
(WebCore::TextBoxPainter::paintDecoration): Deleted.

rendering/TextBoxPainter.h:
rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintBackgroundDecorations):
(WebCore::TextDecorationPainter::paintForegroundDecorations):
(WebCore::TextDecorationPainter::paintLineThrough):
(WebCore::TextDecorationPainter::paintTextDecoration): Deleted.

rendering/TextDecorationPainter.h:

LayoutTests:

TestExpectations:

10:13 AM Changeset in webkit [286954] by cathiechen

1 edit
2 adds in trunk/PerformanceTests

[Performance test] Add test lots-of-self-painting-layers.html
https://bugs.webkit.org/show_bug.cgi?id=233684

Reviewed by Rob Buis.

This test is a transform of the test [1] in blink. It uses position: relative to create
lots of self-painting layers. By changing the first layer's height, it tracks the repaint
performance of these self-painting layers.

[1] third_party/blink/perf_tests/layout/contain-content-style-change.html

Paint/lots-of-self-painting-layers.html: Added.

9:53 AM Changeset in webkit [286953] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix; add a convenience function to safely compare possibly null CFStringRefs.

platform/graphics/avfoundation/FormatDescriptionUtilities.cpp:

(WebCore::presentationSizeFromFormatDescription):
(WebCore::colorSpaceFromFormatDescription):

9:19 AM Changeset in webkit [286952] by svillar@igalia.com

5 edits
2 adds in trunk

[css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows
https://bugs.webkit.org/show_bug.cgi?id=233562
<rdar://problem/86105904>

Reviewed by Rob Buis.

LayoutTests/imported/w3c:

web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins-expected.html: Added.
web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins.html: Added.

Source/WebCore:

In order to compute the preferred logical width of an inline element we must compute the preferred widths of
its children. More precisely we should compute the intrinsic size of the children in the inline direction of the
inline element. For parallel flows this means indeed computing the preferred logical width. Translated to
the margins, we should compute the margin-start and margin-end of each child.

However for orthogonal writing modes we should not use the margin-start & margin-end but margin-after and
margin-before. That's why in order to support orthogonal flows we should replace marginStart() usage by
marginStartUsing(parentStyle) (same for marginEnd).

Test: imported/w3c/web-platform-tests/css/css-writing-modes/inline-box-orthogonal-child-with-margins.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

LayoutTests:

TestExpectations: Unksipped a flexbox test that is now passing.

9:04 AM Changeset in webkit [286951] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Non-bidi content with RTL inline base direction may need visual reordering
https://bugs.webkit.org/show_bug.cgi?id=234242

Reviewed by Antti Koivisto.

This is in preparation for enabling content with RTL base direction.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::InlineItemsBuilder::build):
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

layout/formattingContexts/inline/InlineItemsBuilder.h:

(WebCore::Layout::InlineItemsBuilder::needsVisualReordeering const):

8:59 AM Changeset in webkit [286950] by youenn@apple.com

2 edits in trunk/Tools

Start websocket server for tests in http/tests that have websocket in their name
https://bugs.webkit.org/show_bug.cgi?id=234075

Reviewed by Jonathan Bedard.

Allows to run the websocket server for tests like LayoutTests/http/tests/workers/service/serviceworker-websocket.https.html.

Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:

8:50 AM Changeset in webkit [286949] by Antti Koivisto

7 edits in trunk

[CSS Cascade Layers] Unflake and fix web-platform-tests/css/css-cascade/layer-statement-before-import.html
https://bugs.webkit.org/show_bug.cgi?id=233944

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-cascade/layer-statement-before-import-expected.txt:
web-platform-tests/css/css-cascade/layer-statement-before-import.html:

Data URLs in @imports are not guaranteed to decode synchronously so make the test async.
Also catch exceptions from asserts for cleanup so failures don't affect other subtests.

Source/WebCore:

Inserting rules before early layer statements may be legal if they are moved to the regular rule list.

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::wrapperInsertRule):

LayoutTests:

TestExpectations:

8:20 AM Changeset in webkit [286948] by Tyler Wilcock

11 edits in trunk/LayoutTests

AX: Make aria-hidden-update.html, focusable-div.html, mac/invalid-status-for-input-types.html, and mac/css-speech-speak.html pass in --release isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=234198

Reviewed by Chris Fleizach.

Make the following tests async or otherwise isolated-tree friendly
(i.e. by using accessibleElementById instead of document.getElementById().focus() +
accessibilityController.focusedElement to get a JS reference to an AX object).

accessibility/aria-hidden-update-expected.txt:
accessibility/aria-hidden-update.html:
accessibility/focusable-div-expected.txt:
accessibility/focusable-div.html:
accessibility/mac/invalid-status-for-input-types-expected.txt:
accessibility/mac/invalid-status-for-input-types.html:

Make these tests async. These tests must be async to pass in isolated
tree mode because they use JS to dynamically change the page.

accessibility/mac/css-speech-speak-expected.txt:
accessibility/mac/css-speech-speak.html:

Use accessibleElementById instead of document.getElementById().focus() +
accessibilityController.focusedElement to get references to JS AX objects.

platform/glib/TestExpectations:
platform/win/TestExpectations:

Skip accessibility/focusable-div.html due to lack of
AccessibilityUIElement::domIdentifier implementation.

7:18 AM Changeset in webkit [286947] by jh718.park@samsung.com

2 edits in trunk/Source/WebKit

Unreviewed. Fix build error since r286946.

ClientOrigin should be forward declared as struct, not class.

NetworkProcess/storage/SessionStorageManager.h:

5:42 AM Changeset in webkit [286946] by Adrian Perez de Castro

7 edits in trunk/Source

Unreviewed build fix after r286936

Source/JavaScriptCore:

wasm/WasmOSREntryData.h: Replace wrong inclusion of wtf/Vector.h (unused) with the correct

wtf/FixedVector.h one.

wasm/WasmTierUpCount.h: Add missing WasmOSREntryData.h inclusion.

Source/WebKit:

No new tests needed.

NetworkProcess/storage/OriginStorageManager.cpp: Add missing inclusion of

MemoryStorageArea.h, which broke non-unified builds.

NetworkProcess/storage/SQLiteStorageArea.cpp: Add missing inclusion of Logging.h, broke

the build in some configurations.

NetworkProcess/storage/SessionStorageManager.h: Add missing inclusion of Connection.h, and

add missing forward declaration for WebCore::ClientOrigin, which broke the build for
non-Apple ports.

5:28 AM WebKitGTK/2.34.x edited by Adrian Perez de Castro

(diff)

2:49 AM Changeset in webkit [286945] by Adrian Perez de Castro

2 edits in trunk/Source/WebCore

Fix non-unified builds after r286853

Unreviewed build fix.

No new tests needed.

loader/SubresourceIntegrity.h: Add missing <optional> header inclusion, forward-declare

EncodedResourceCryptographicDigest type.

2:41 AM Changeset in webkit [286944] by youenn@apple.com

51 edits
2 copies
12 adds in trunk

Fix ServiceWorker downloads
https://bugs.webkit.org/show_bug.cgi?id=202142
<rdar://problem/55721934>

Reviewed by Alex Christensen.

Source/WebCore:

Add API to ask the fetch task to become a download.

Tests: http/tests/workers/service/service-worker-download-body.https.html

http/tests/workers/service/service-worker-download-stream.https.html
http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https.html
http/wpt/service-workers/fetch-service-worker-preload-download.https.html

workers/service/context/ServiceWorkerFetch.h:
workers/service/context/ServiceWorkerThreadProxy.cpp:
workers/service/context/ServiceWorkerThreadProxy.h:

Source/WebKit:

Add ServiceWorkerDownloadTask class as a NetworkDataTask whose purpose is to download the content of a response given from service worker.
Add a way to convert ServiceWorkerFetchTask into downloads:

If a preload is ongoing and can be used for navigation, use this preload as the download NetworkLoad.
If a preload does not exist, create a ServiceWorkerDownloadTask and a corresponding NetworkLoad to start downloading the service worker response data.

When creating a ServiceWorkerDownloadTask, the WebServiceWorkerFetchTaskClient will be notified to start sending response data using ServiceWorkerDownloadTask
instead of ServiceWorkerFetchTask messages. This allows cancelling the ServiceWorkerFetchTask without any issue.

Note that the service worker lifetime is not augmented: if the service worker exits due to all its clients being closed, the download will fail.

Increase unified build files to 112.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
NetworkProcess/NetworkConnectionToWebProcess.cpp:
NetworkProcess/NetworkLoad.cpp:
NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkResourceLoader.cpp:
NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp: Added.
NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h: Added.
NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in: Added.
NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:
NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h:
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
NetworkProcess/storage/NetworkStorageManager.cpp:
Scripts/generate-unified-sources.sh:
Scripts/webkit/messages.py:
Scripts/webkit/tests/TestWithCVPixelBufferMessageReceiver.cpp:

(WebKit::TestWithCVPixelBuffer::didReceiveMessage):

Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp:

(WebKit::TestWithIfMessage::didReceiveMessage):

Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp:

(WebKit::TestWithImageData::didReceiveMessage):

Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:

(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):

Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp:

(WebKit::TestWithSemaphore::didReceiveMessage):

Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp:

(WebKit::TestWithStreamBuffer::didReceiveMessage):

Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp:

(WebKit::TestWithStream::didReceiveStreamMessage):

Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:

(WebKit::TestWithoutAttributes::didReceiveMessage):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::createDownloadProxy):

Sources.txt:
UnifiedSources-output.xcfilelist:
WebKit.xcodeproj/project.pbxproj:
WebProcess/Storage/WebSWContextManagerConnection.cpp:
WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:

Tools:

Add test runner API to log the total download size.
This helps ensuring that service worker loads are correctly downloaded and do not rely on networking.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:
WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

LayoutTests:

http/tests/workers/service/resources/service-worker-download-worker.js:
http/tests/workers/service/service-worker-download-body.https-expected.txt: Added.
http/tests/workers/service/service-worker-download-body.https.html: Added.
http/tests/workers/service/service-worker-download-stream.https-expected.txt: Added.
http/tests/workers/service/service-worker-download-stream.https.html: Added.
http/tests/workers/service/service-worker-download.https-expected.txt:
http/tests/workers/service/service-worker-download.https.html:
http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt: Added.
http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https.html: Added.
http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt: Added.
http/wpt/service-workers/fetch-service-worker-preload-download.https.html: Added.
http/wpt/service-workers/fetch-service-worker-preload-worker.js:
http/wpt/service-workers/resources/fetch-service-worker-preload-script.py:
platform/ios/http/wpt/service-workers/fetch-service-worker-preload-download-through-direct-preload.https-expected.txt: Added.
platform/ios/http/wpt/service-workers/fetch-service-worker-preload-download.https-expected.txt: Added.

2:37 AM Changeset in webkit [286943] by commit-queue@webkit.org

64 edits
1 copy
1 move
1 delete in trunk

Cocoa WebGL should support UI side compositing
https://bugs.webkit.org/show_bug.cgi?id=231009
<rdar://83437059>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-12-13
Reviewed by Simon Fraser.

Source/WebCore:

Second try, previous was reverted due to a test failure.
See WebKit side for the description.

Implement Cocoa UI-side compositing for WebGL.

Make CanvasRenderingContext draw via GraphicsLayerContentsDisplayDelegate
instead of PlatformLayer. On Cocoa the GraphicsLayer contents can be
three different objects: CGImage, CALayer or content in "backing store"
of the underlying compositor layer.
For UI-side compositing for WebGL, we want it to be the latter.
As such, the object CanvasRenderingContext draws to cannot be a platform
layer (CALayer). So conceptually, WebGL does not draw into a platform
layer, it draws into backing store that can be put to (possibly many)
platform layers.

Add GraphicsLayerContentsDisplayDelegate interface, which can be
used to run client specific code during compositor layer contents update
phase (i.e. layer display phase).

WebGL will use new overloads of PlatformCALayer::setContents to set the
contents during delegated display. The contents is IOSurface for
in-process mode and MachSendRight of IOSurface in GPUP mode.
The IOSurface is set as the contents of the WebSimpleLayer instead
of the running the draw via display().
The MachSendRight is set as the contents of PlatformCALayerRemote
and be serialized to the UI process.

For non-Cocoa ports, add a simple GraphicsLayerContentsDisplayDelegate
that returns the platform layer to the GraphicsLayer inside the compositor.

No new tests, a refactor.

Headers.cmake:
PlatformMac.cmake:
Sources.txt:
SourcesCocoa.txt:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:
html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::layerContentsDisplayDelegate):

html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::platformLayer const): Deleted.

html/canvas/PlaceholderRenderingContext.cpp:

(WebCore::PlaceholderRenderingContext::layerContentsDisplayDelegate):
(WebCore::PlaceholderRenderingContext::platformLayer const): Deleted.

html/canvas/PlaceholderRenderingContext.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::layerContentsDisplayDelegate):
(WebCore::WebGLRenderingContextBase::platformLayer const): Deleted.

html/canvas/WebGLRenderingContextBase.h:
platform/graphics/GraphicsContextGL.h:
platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::setContentsDisplayDelegate):

platform/graphics/GraphicsLayer.h:
platform/graphics/GraphicsLayerContentsDisplayDelegate.cpp: Added.

(WebCore::GraphicsLayerContentsDisplayDelegate::prepareToDelegateDisplay):
(WebCore::GraphicsLayerContentsDisplayDelegate::orientation const):

platform/graphics/GraphicsLayerContentsDisplayDelegate.h: Added.
platform/graphics/ImageBufferPipe.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsDisplayDelegate):
(WebCore::GraphicsLayerCA::layerDisplay):
(WebCore::GraphicsLayerCA::updateContentsPlatformLayer):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLayerDisplay):

platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::commonInit):
(WebCore::PlatformCALayerCocoa::setContents):

platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::displayBuffer):
(WebCore::GraphicsContextGLOpenGL::markDisplayBufferInUse):
(WebCore::GraphicsContextGLOpenGL::platformLayer const): Deleted.

platform/graphics/cocoa/WebGLLayer.mm: Removed.

(-[WebGLLayer initWithDevicePixelRatio:contentsOpaque:]): Deleted.
(-[WebGLLayer setTransform:]): Deleted.
(-[WebGLLayer setAnchorPoint:]): Deleted.
(-[WebGLLayer display]): Deleted.

platform/graphics/cocoa/WebProcessGraphicsContextGLOpenGLCocoa.mm:
platform/graphics/cv/CVUtilities.mm:
platform/graphics/mac/WebLayer.mm:

(-[WebSimpleLayer display]):

platform/graphics/nicosia/NicosiaImageBufferPipe.cpp:

(Nicosia::WebCore::NicosiaImageBufferPipeSource::layerContentsDisplayDelegate):
(Nicosia::WebCore::NicosiaImageBufferPipe::layerContentsDisplayDelegate):
(Nicosia::NicosiaImageBufferPipeSource::NicosiaImageBufferPipeSource): Deleted.
(Nicosia::NicosiaImageBufferPipeSource::~NicosiaImageBufferPipeSource): Deleted.
(Nicosia::NicosiaImageBufferPipeSource::handle): Deleted.
(Nicosia::NicosiaImageBufferPipeSource::platformLayer const): Deleted.
(Nicosia::NicosiaImageBufferPipeSource::swapBuffersIfNeeded): Deleted.
(Nicosia::NicosiaImageBufferPipe::NicosiaImageBufferPipe): Deleted.
(Nicosia::NicosiaImageBufferPipe::source const): Deleted.
(Nicosia::NicosiaImageBufferPipe::platformLayer const): Deleted.

platform/graphics/opengl/GraphicsContextGLOpenGL.h:
platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLOpenGL::create):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsDisplayDelegate):

platform/graphics/texmap/GraphicsLayerTextureMapper.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsDisplayDelegate):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):

Source/WebKit:

Implement the capability to assign IOSurfaces
to PlatformCALayerRemote contents.

Make RemoteGraphicsContextGLProxyCocoa use the added
GraphicsLayerContentsDisplayDelegate.

Second try, previous was reverted due to a test failure.
The test failure happened due to RemoteLayerBackingStore
sending the same drawn backing store with different
properties but same image. The original patch tried
to use RemoteLayerBackingStore::m_bufferHandle also
on the send side to store the handle. This handle
was encoded multiple times. The underlying
ShareableBitmap::Handle IPC encoding destroys the
underlying mach send right even though the encoding
API signature would signify that the Handle stays
intact. ShareableBitmap, SharedMemory will be fixed in
future commits.

GPUProcess/graphics/GPUProcessGraphicsContextGL.h:
GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:

(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):

Shared/RemoteLayerTree/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::hasFrontBuffer const):

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::clearBackingStore):
(WebKit::RemoteLayerBackingStore::encode const):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::setContents):
(WebKit::RemoteLayerBackingStore::display):

Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description const):

UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::makeNode):

UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::makeNode):

WebKit.xcodeproj/project.pbxproj:
WebProcess/GPU/graphics/cocoa/RemoteGraphicsContextGLProxyCocoa.mm:

(WebKit::RemoteGraphicsContextGLProxy::create):

WebProcess/GPU/graphics/wc/RemoteGraphicsContextGLProxyWC.cpp:

(WebKit::RemoteGraphicsContextGLProxy::create): Deleted.

WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::setContents):

WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h:
WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(WebKit::PlatformCALayerRemoteCustom::clone const):
(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplay):

WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

(WebKit::GraphicsLayerWC::setContentsDisplayDelegate):

Tools:

TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLOpenGLCocoa.mm:

Add a dummy override of the new member function layerContentsDisplayDelegate.

2:29 AM Changeset in webkit [286942] by Martin Robinson

4 edits in trunk

transform-origin on SVG elements does not take into account the transform reference box origin
https://bugs.webkit.org/show_bug.cgi?id=234078

Reviewed by Rob Buis.

Source/WebCore:

No new tests. This is covered by existing WPT tests.

svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform const): Add the reference box origin
to the calculated reference box offset when calculating the transform origin for SVG.

LayoutTests:

TestExpectations: Mark tests as passing.

1:24 AM Changeset in webkit [286941] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[RISCV64] Add MacroAssemblerRISCV64 implementations for trivial floating-point-register operations
https://bugs.webkit.org/show_bug.cgi?id=234223

Patch by Zan Dobersek <zdobersek@igalia.com> on 2021-12-13
Reviewed by Yusuke Suzuki.

Add implementations for the trivial floating-point register operations
in MacroAssemblerRISCV64. This covers moves, loads, stores, arithmetics,
basic conversion and truncation and the lightweight logical operations.

The two floating-point temporary registers needed in some operations are
listed. The rounding and comparison operations are left for later as
they require a more complex implementation due to the necessary manual
NaN checks.

assembler/MacroAssemblerRISCV64.h:

(JSC::MacroAssemblerRISCV64::swap):
(JSC::MacroAssemblerRISCV64::moveZeroToFloat):
(JSC::MacroAssemblerRISCV64::moveZeroToDouble):
(JSC::MacroAssemblerRISCV64::moveFloat):
(JSC::MacroAssemblerRISCV64::moveFloatTo32):
(JSC::MacroAssemblerRISCV64::move32ToFloat):
(JSC::MacroAssemblerRISCV64::moveDouble):
(JSC::MacroAssemblerRISCV64::moveDoubleTo64):
(JSC::MacroAssemblerRISCV64::move64ToDouble):
(JSC::MacroAssemblerRISCV64::loadFloat):
(JSC::MacroAssemblerRISCV64::loadDouble):
(JSC::MacroAssemblerRISCV64::storeFloat):
(JSC::MacroAssemblerRISCV64::storeDouble):
(JSC::MacroAssemblerRISCV64::addFloat):
(JSC::MacroAssemblerRISCV64::addDouble):
(JSC::MacroAssemblerRISCV64::subFloat):
(JSC::MacroAssemblerRISCV64::subDouble):
(JSC::MacroAssemblerRISCV64::mulFloat):
(JSC::MacroAssemblerRISCV64::mulDouble):
(JSC::MacroAssemblerRISCV64::divFloat):
(JSC::MacroAssemblerRISCV64::divDouble):
(JSC::MacroAssemblerRISCV64::sqrtFloat):
(JSC::MacroAssemblerRISCV64::sqrtDouble):
(JSC::MacroAssemblerRISCV64::absFloat):
(JSC::MacroAssemblerRISCV64::absDouble):
(JSC::MacroAssemblerRISCV64::andFloat):
(JSC::MacroAssemblerRISCV64::andDouble):
(JSC::MacroAssemblerRISCV64::orFloat):
(JSC::MacroAssemblerRISCV64::orDouble):
(JSC::MacroAssemblerRISCV64::negateFloat):
(JSC::MacroAssemblerRISCV64::negateDouble):
(JSC::MacroAssemblerRISCV64::convertInt32ToFloat):
(JSC::MacroAssemblerRISCV64::convertInt32ToDouble):
(JSC::MacroAssemblerRISCV64::convertInt64ToFloat):
(JSC::MacroAssemblerRISCV64::convertInt64ToDouble):
(JSC::MacroAssemblerRISCV64::convertUInt64ToFloat):
(JSC::MacroAssemblerRISCV64::convertUInt64ToDouble):
(JSC::MacroAssemblerRISCV64::convertFloatToDouble):
(JSC::MacroAssemblerRISCV64::convertDoubleToFloat):
(JSC::MacroAssemblerRISCV64::truncateFloatToInt32):
(JSC::MacroAssemblerRISCV64::truncateFloatToUint32):
(JSC::MacroAssemblerRISCV64::truncateFloatToInt64):
(JSC::MacroAssemblerRISCV64::truncateFloatToUint64):
(JSC::MacroAssemblerRISCV64::truncateDoubleToInt32):
(JSC::MacroAssemblerRISCV64::truncateDoubleToUint32):
(JSC::MacroAssemblerRISCV64::truncateDoubleToInt64):
(JSC::MacroAssemblerRISCV64::truncateDoubleToUint64):

1:20 AM WebKitGTK/2.34.x edited by Adrian Perez de Castro

(diff)

1:18 AM Changeset in webkit [286940] by youenn@apple.com

6 edits in trunk

Implement step 17 of main fetch algorithm
https://bugs.webkit.org/show_bug.cgi?id=234140

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/fetch-csp.https.html:
web-platform-tests/service-workers/service-worker/resources/fetch-csp-iframe.html.sub.headers:

Source/WebCore:

The step was implemented for non DocumentThreadableLoader resources, we need to also do the same step within DocumentThreadableLoader.

Covered by existing updated tests.

loader/DocumentThreadableLoader.cpp:
loader/DocumentThreadableLoader.h:

1:09 AM Changeset in webkit [286939] by youenn@apple.com

2 edits in trunk/Source/WebCore

Rename startCallback to resetCallback in AudioMediaStreamTrackRendererUnit createInternalUnit
https://bugs.webkit.org/show_bug.cgi?id=234142

Reviewed by Eric Carlson.

No change of behavior, just a renaming.

platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp:

12:50 AM Changeset in webkit [286938] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.34/Source/WebKit

Merge r286800 - [WPE] Crash under WebProcessProxy::setIsInProcessCache when closing web view in debug builds
https://bugs.webkit.org/show_bug.cgi?id=233933

Reviewed by Geoffrey Garen.

The crash would occur because the WebProcessPool destructor would call WebProcessCache::clear()
which would destroy WebProcessCache::CachedProcess objects, causing
WebProcessProxy::setIsInProcessCache(false) to get called. Previously, this call to
setIsInProcessCache() would convert the WeakPtr the WebProcessProxy held to its process pool
into a RefPtr, thus causing the WebProcessPool to get ref'd while in the middle of destruction.

To address the issue, the setIsInProcessCache() setter now takes a WillShutDown flag that gets
set in the CachedProcess destructor and which causes setIsInProcessCache() to return early
right after setting the m_isInProcessCache flag, without trying to send IPC to the WebProcess
or trying to ref the WebProcessPool.

UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::CachedProcess::~CachedProcess):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setIsInProcessCache):

UIProcess/WebProcessProxy.h:

12:30 AM Changeset in webkit [286937] by Jean-Yves Avenard

261 edits in trunk

Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability
https://bugs.webkit.org/show_bug.cgi?id=233030
rdar://85333814

Reviewed by Darin Adler.

Source/WebCore:

When calling SharedBuffer::data() the underlying data was flattened,
and so could be mutated while being shared. This was an undesirable
behaviour.
We introduce ContiguousSharedBuffer which guarantee that its content is made
of contiguous data.
All methods that would have mutated a SharedBuffer when being flattened are
moved to ContiguousSharedBuffer.

Area where SharedBuffers were always created with a single segment where
converted to a ContiguousSharedBuffer.
Previously, a SharedBuffer would have been flattened only if it needed to be
and only when the data was going to be accessed; following this change
the conversion is now explictly done through a call to makeContiguous.
This conversion is a no-op if the SharedBuffer being converted was already
a ContiguousSharedBuffer.
With the nature of a SharedBuffer being shared by potentially multiple
users it was necessary to limit the number of conversions being performed
on demand to avoid redundancy.
When the flattening could have occured, the SharedBuffer creation points were
traced back and identified to make the buffer contiguous then.
In the end, there's no more SharedBuffer flattening operations than there
would have been before this change.
There's a potential increase of temporary memory usage with the
ScriptBufferSourceProvider class; bug 233511 is tracking it.

While the change is extensive, code coverage of the modified areas is thorough
which makes undetected regressions unlikely.

In bug 233442, a SharedBuffer will be made completely immutable once created.

No observable change.
Covered by all existing tests. New API tests creatded.

Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded):

Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::computeRealBodySize):

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::addAll):
(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):

Modules/cache/DOMCache.h:
Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::isolatedResponseBody):
(WebCore::DOMCacheEngine::copyResponseBody):

Modules/cache/DOMCacheEngine.h:
Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):

Modules/encryptedmedia/MediaKeyStatusMap.cpp:

(WebCore::keyIdsMatch):
(WebCore::MediaKeyStatusMap::Iterator::next):

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeFormData):
(WebCore::FetchBody::bodyAsFormData const):
(WebCore::FetchBody::take):

Modules/fetch/FetchBody.h:
Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::takeAsText):

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::consumeDataByChunk):
(WebCore::FetchResponse::setBodyData):

Modules/fetch/FetchResponse.h:
Modules/highlight/AppHighlight.h:

(WebCore::AppHighlight::encode const):

Modules/highlight/AppHighlightRangeData.cpp:

(WebCore::AppHighlightRangeData::create):

Modules/indexeddb/server/IDBSerialization.cpp:

(WebCore::serializeIDBKeyPath):
(WebCore::serializeIDBKeyData):

Modules/indexeddb/server/IDBSerialization.h:
Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::addExistingIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindPreIndexStatementIfNecessary):

Modules/mediastream/RTCDataChannelRemoteHandler.cpp:

(WebCore::RTCDataChannelRemoteHandler::readyToSend):

Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp:

(WebCore::LibWebRTCDataChannelHandler::setClient):

Modules/model-element/HTMLModelElement.cpp:

(WebCore::HTMLModelElement::notifyFinished):

Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm:

(WebCore::writeToTemporaryFile):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::handleResponseOnStreamingAction):

bindings/js/ScriptBufferSourceProvider.h:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

css/CSSFontFaceSource.h:
editing/Editor.cpp:

(WebCore::Editor::promisedAttachmentInfo):

editing/Editor.h:
editing/SerializedAttachmentData.h:
editing/cocoa/EditorCocoa.mm:

(WebCore::archivedDataForAttributedString):
(WebCore::Editor::getPasteboardTypesAndDataForAttachment):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::dataInRTFDFormat):
(WebCore::Editor::dataInRTFFormat):

editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_addAttachmentForElement):
(fileWrapperForURL):
(fileWrapperForElement):

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::replaceRichContentWithAttachments):
(WebCore::extractMarkupAndArchive):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readRTFD):
(WebCore::WebContentMarkupReader::readRTFD):
(WebCore::WebContentReader::readRTF):
(WebCore::WebContentMarkupReader::readRTF):

editing/mac/EditorMac.mm:

(WebCore::Editor::imageInWebArchiveFormat):
(WebCore::Editor::dataSelectionForPasteboard):

html/FTPDirectoryDocument.cpp:

(WebCore::createTemplateDocumentData):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::cachedResourceContent):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::mainResourceContent):
(WebCore::InspectorPageAgent::sharedBufferContent):

loader/ContentFilter.cpp:

(WebCore::ContentFilter::deliverResourceData):

loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::doPreflight):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeCreateArchive):
(WebCore::DocumentLoader::parsedArchiveData const):
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):

loader/DocumentLoader.h:
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

loader/EmptyClients.cpp:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

loader/FrameLoader.h:
loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveDataOrBuffer):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveDataOrBuffer):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::bufferFromResource):
(WebCore::ApplicationCacheHost::maybeLoadSynchronously):
(WebCore::ApplicationCacheHost::maybeLoadFallbackSynchronously):

loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::deliver):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::loadCache):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::extract):
(WebCore::LegacyWebArchive::createFromSelection):

loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseNextPart):

loader/cache/CachedApplicationManifest.cpp:

(WebCore::CachedApplicationManifest::finishLoading):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText const):
(WebCore::CachedCSSStyleSheet::finishLoading):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::finishLoading):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createCustomFontData):
(WebCore::CachedFont::checkNotify):

loader/cache/CachedFont.h:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::updateBufferInternal):
(WebCore::CachedImage::convertedDataIfNeeded const):

loader/cache/CachedImage.h:
loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::updateBuffer):
(WebCore::CachedRawResource::finishLoading):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::tryReplaceEncodedData):

loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceBuffer const):

loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::finishLoading):

loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::ensureCustomFontData):

loader/cache/CachedSVGFont.h:
loader/cache/CachedScript.cpp:

(WebCore::CachedScript::finishLoading):

loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::doUpdateBuffer):

loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::finishLoading):

loader/cocoa/DiskCacheMonitorCocoa.h:
loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse):
(WebCore::DiskCacheMonitor::resourceBecameFileBacked):

page/EditorClient.h:
page/Page.cpp:

(WebCore::Page::userStyleSheet const):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::addImageToResources):

page/PageSerializer.h:
page/ShareData.h:
page/ShareDataReader.cpp:

(WebCore::ShareDataReader::ShareDataReader):
(WebCore::ShareDataReader::didFinishLoading):

platform/KeyedCoding.h:
platform/Pasteboard.h:
platform/PasteboardCustomData.cpp:

(WebCore::PasteboardCustomData::createSharedBuffer const):
(WebCore::PasteboardCustomData::fromSharedBuffer):

platform/PasteboardCustomData.h:
platform/PasteboardStrategy.h:
platform/PasteboardWriterData.h:
platform/PlatformPasteboard.h:
platform/PromisedAttachmentInfo.h:
platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::makeContiguous const):
(WebCore::SharedBuffer::size const):
(WebCore::SharedBuffer::isEmpty const):
(WebCore::SharedBuffer::isContiguous const):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copy const):
(WebCore::SharedBuffer::hasOneSegment const):
(WebCore::ContiguousSharedBuffer::ContiguousSharedBuffer):
(WebCore::ContiguousSharedBuffer::createWithContentsOfFile):
(WebCore::ContiguousSharedBuffer::data const):
(WebCore::ContiguousSharedBuffer::dataAsCharPtr const):
(WebCore::DataSegment::data const):
(WebCore::DataSegment::containsMappedFileData const):
(WebCore::ContiguousSharedBuffer::decoder const):
(WebCore::DataSegment::size const):
(WebCore::SharedBufferDataView::SharedBufferDataView):
(WebCore::SharedBufferDataView::dataAsCharPtr const):
(WebCore::SharedBufferDataView::createSharedBuffer const):
(WebCore::utf8Buffer):

platform/SharedBuffer.h:

(WebCore::DataSegment::create):
(WebCore::DataSegment::DataSegment):
(WebCore::SharedBuffer::create):
(WebCore::ContiguousSharedBuffer::create):

platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo):

platform/cf/KeyedEncoderCF.cpp:

(WebCore::KeyedEncoderCF::finishEncoding):

platform/cf/KeyedEncoderCF.h:
platform/cf/SharedBufferCF.cpp:

(WebCore::ContiguousSharedBuffer::createCFData const):
(WebCore::SharedBuffer::append):

platform/cocoa/PasteboardCocoa.mm:

(WebCore::convertTIFFToPNG):
(WebCore::Pasteboard::readBufferForTypeWithSecurityCheck):

platform/cocoa/SharedBufferCocoa.mm:

(-[WebCoreSharedBufferData initWithDataSegment:position:size:]):
(WebCore::ContiguousSharedBuffer::createNSData const):
(WebCore::ContiguousSharedBuffer::createCFData const):
(WebCore::ContiguousSharedBuffer::createFromReadingFile):
(WebCore::DataSegment::createNSData const):

platform/encryptedmedia/CDMUtilities.cpp:

(WebCore::CDMUtilities::parseJSONObject):

platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::extractKeyidsLocationFromCencInitData):
(WebCore::extractKeyidsFromCencInitData):
(WebCore::extractKeyIdFromWebMInitData):

platform/generic/KeyedEncoderGeneric.cpp:

(WebCore::KeyedEncoderGeneric::finishEncoding):

platform/generic/KeyedEncoderGeneric.h:
platform/glib/KeyedEncoderGlib.cpp:

(WebCore::KeyedEncoderGlib::finishEncoding):

platform/glib/KeyedEncoderGlib.h:
platform/glib/SharedBufferGlib.cpp:

(WebCore::ContiguousSharedBuffer::createGBytes const):
(WebCore::ContiguousSharedBuffer::createFromReadingFile):

platform/graphics/Font.cpp:

(WebCore::Font::create):

platform/graphics/Font.h:
platform/graphics/FontPlatformData.h:
platform/graphics/Model.cpp:

(WebCore::Model::create):
(WebCore::Model::Model):

platform/graphics/Model.h:

(WebCore::Model::encode const):
(WebCore::Model::decode):

platform/graphics/WOFFFileFormat.cpp:

(WebCore::readUInt32):
(WebCore::readUInt16):
(WebCore::isWOFF):
(WebCore::convertWOFFToSfnt):
(WebCore::convertWOFFToSfntIfNecessary):

platform/graphics/WOFFFileFormat.h:
platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::extractSinfData):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::parseJSONValue):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::setData):

platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:

(WebCore::SourceBufferParserAVFObjC::appendData):

platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):

platform/graphics/cairo/FontCustomPlatformData.h:
platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::sharedBufferGetBytesAtPosition):
(WebCore::ImageDecoderCG::ImageDecoderCG):
(WebCore::ImageDecoderCG::setData):

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::createPDFDocument):

platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformOpenTypeTable const):

platform/graphics/cocoa/SourceBufferParserWebM.cpp:
platform/graphics/coretext/FontPlatformDataCoreText.cpp:

(WebCore::FontPlatformData::openTypeTable const):

platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::openTypeTable const):

platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::GstMappedOwnedBuffer::createSharedBuffer):

platform/graphics/gstreamer/GStreamerCommon.h:
platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:

(WebCore::ImageDecoderGStreamer::pushEncodedData):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::initializationDataEncountered):

platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:

(WebCore::markupText):
(WebCore::InitData::extractCencIfNeeded):

platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

(WebCore::InitData::InitData):

platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/mac/FontCustomPlatformData.h:
platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::createPDFDocument):

platform/graphics/opentype/OpenTypeMathData.cpp:

(WebCore::OpenType::MathItalicsCorrectionInfo::getItalicCorrection const):
(WebCore::OpenType::MathGlyphInfo::mathItalicsCorrectionInfo const):
(WebCore::OpenType::GlyphAssembly::getAssemblyParts const):
(WebCore::OpenType::MathGlyphConstruction::getSizeVariants const):
(WebCore::OpenType::MathGlyphConstruction::getAssemblyParts const):
(WebCore::OpenType::MathVariants::mathGlyphConstruction const):
(WebCore::OpenType::MATHTable::mathConstants const):
(WebCore::OpenType::MATHTable::mathGlyphInfo const):
(WebCore::OpenType::MATHTable::mathVariants const):

platform/graphics/opentype/OpenTypeMathData.h:
platform/graphics/opentype/OpenTypeTypes.h:

(WebCore::OpenType::validateTable):
(WebCore::OpenType::TableBase::isValidEnd):
(WebCore::OpenType::TableBase::validatePtr):
(WebCore::OpenType::TableBase::validateOffset const):
(WebCore::OpenType::TableWithCoverage::getCoverageIndex const):

platform/graphics/opentype/OpenTypeUtilities.cpp:

(WebCore::renameFont):
(WebCore::renameAndActivateFont):

platform/graphics/opentype/OpenTypeUtilities.h:
platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenType::SubstitutionSubTable::coverage const):
(WebCore::OpenType::LookupTable::getSubstitutions const):
(WebCore::OpenType::LookupList::lookup const):
(WebCore::OpenType::FeatureTable::getGlyphSubstitutions const):
(WebCore::OpenType::FeatureList::feature const):
(WebCore::OpenType::FeatureList::findFeature const):
(WebCore::OpenType::LangSysTable::feature const):
(WebCore::OpenType::ScriptTable::defaultLangSys const):
(WebCore::OpenType::ScriptList::script const):
(WebCore::OpenType::ScriptList::defaultScript const):
(WebCore::OpenType::ScriptList::defaultLangSys const):
(WebCore::OpenType::GSUBTable::scriptList const):
(WebCore::OpenType::GSUBTable::featureList const):
(WebCore::OpenType::GSUBTable::lookupList const):
(WebCore::OpenType::GSUBTable::defaultLangSys const):
(WebCore::OpenType::GSUBTable::feature const):
(WebCore::OpenType::GSUBTable::getVerticalGlyphSubstitutions const):
(WebCore::loadHmtxTable):
(WebCore::OpenTypeVerticalData::loadMetrics):
(WebCore::OpenTypeVerticalData::loadVerticalGlyphSubstitutions):

platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/win/FontCustomPlatformData.h:
platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::createFontCustomPlatformData):

platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::openTypeTable const):

platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::platformOpenTypeTable const):

platform/gtk/SelectionData.h:

(WebCore::SelectionData::setCustomData):
(WebCore::SelectionData::customData const):

platform/image-decoders/ScalableImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::readICCProfile):
(WebCore::JPEGImageDecoder::setICCProfile):

platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::createItemProviderRegistrationList):
(WebCore::PlatformPasteboard::readBuffer const):

platform/mac/PasteboardMac.mm:

(WebCore::fileWrapper):
(WebCore::readBufferAtPreferredItemIndex):
(WebCore::Pasteboard::read):

platform/mac/PasteboardWriter.mm:

(WebCore::createPasteboardWriter):

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::readBuffer const):
(WebCore::createPasteboardItem):

platform/network/FormData.cpp:

(WebCore::FormData::asSharedBuffer const):

platform/network/FormData.h:
platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::didReceiveBuffer):

platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask resource:receivedData:]):

platform/network/curl/CurlMultipartHandle.cpp:

(WebCore::CurlMultipartHandle::didReceiveData):
(WebCore::CurlMultipartHandle::didComplete):
(WebCore::CurlMultipartHandle::processContent):

platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::writeDataToDownloadFileIfEnabled):

platform/network/curl/CurlResourceHandleDelegate.cpp:

(WebCore::CurlResourceHandleDelegate::curlDidReceiveBuffer):

platform/win/PasteboardWin.cpp:

(WebCore::createGlobalImageFileContent):
(WebCore::createGlobalHDropContent):

platform/win/SharedBufferWin.cpp:

(WebCore::ContiguousSharedBuffer::createFromReadingFile):

testing/MockCDMFactory.cpp:

(WebCore::MockCDM::sanitizeResponse const):
(WebCore::MockCDMInstance::setServerCertificate):
(WebCore::MockCDMInstanceSession::updateLicense):

workers/WorkerFontLoadRequest.cpp:

(WebCore::WorkerFontLoadRequest::ensureCustomFontData):

workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::processResponse):

workers/service/server/SWScriptStorage.cpp:

(WebCore::SWScriptStorage::retrieve):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):

Source/WebKit:

GPUProcess/webrtc/RemoteMediaRecorder.cpp:

(WebKit::RemoteMediaRecorder::fetchData):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::sendReplyToSynchronousRequest):

NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:

(WebKit::ServiceWorkerSoftUpdateLoader::didReceiveBuffer):

NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::encode):
(WebKit::CacheStorage::Cache::decode):

NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::encodeAsStorageRecord const):

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didReadDataURL):

Platform/IPC/SharedBufferCopy.cpp:

(IPC::SharedBufferCopy::decode):

Platform/IPC/SharedBufferCopy.h:

(IPC::SharedBufferCopy::SharedBufferCopy):
(IPC::SharedBufferCopy::buffer):
(IPC::SharedBufferCopy::buffer const):

Platform/SharedMemory.cpp:

(WebKit::SharedMemory::createSharedBuffer const):

Platform/SharedMemory.h:
Shared/APIWebArchiveResource.mm:

(API::WebArchiveResource::data):

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<Ref<WebCore::Font>>::decodePlatformData):

Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::createImageBufferBackendHandle const):

Shared/ShareableResource.cpp:

(WebKit::ShareableResource::wrapInSharedBuffer):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer const):

Shared/ShareableResource.h:
Shared/WebCoreArgumentCoders.cpp:

(IPC::decodeSharedBuffer):
(IPC::encodeTypesAndData):
(IPC::decodeTypesAndData):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::encode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):
(IPC::ArgumentCoder<PasteboardCustomData::Entry>::decode):
(IPC::ArgumentCoder<WebCore::SerializedAttachmentData>::decode):
(IPC::ArgumentCoder<RefPtr<WebCore::SharedBuffer>>::decode):
(IPC::ArgumentCoder<Ref<WebCore::SharedBuffer>>::decode):
(IPC::ArgumentCoder<RefPtr<WebCore::ContiguousSharedBuffer>>::encode):
(IPC::ArgumentCoder<RefPtr<WebCore::ContiguousSharedBuffer>>::decode):
(IPC::ArgumentCoder<Ref<WebCore::ContiguousSharedBuffer>>::encode):
(IPC::ArgumentCoder<Ref<WebCore::ContiguousSharedBuffer>>::decode):
(IPC::ArgumentCoder<WebCore::ScriptBuffer>::decode):

Shared/WebCoreArgumentCoders.h:
Shared/gtk/ArgumentCodersGtk.cpp:

(IPC::ArgumentCoder<SelectionData>::decode):

Shared/win/WebCoreArgumentCodersWin.cpp:

(IPC::ArgumentCoder<Ref<Font>>::decodePlatformData):

UIProcess/API/APIAttachment.cpp:

(API::Attachment::createSerializedRepresentation const):
(API::Attachment::updateFromSerializedRepresentation):

UIProcess/API/APIAttachment.h:
UIProcess/API/APIContentRuleListStore.cpp:

(API::getData):

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::createSerializedRepresentation const):
(API::Attachment::updateFromSerializedRepresentation):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _storeAppHighlight:]):

UIProcess/API/gtk/DropTargetGtk3.cpp:

(WebKit::DropTarget::dataReceived):

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::didFinishLoadForQuickLookDocumentInMainFrame):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::writeSelectionToPasteboard):
(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::provideDataForPasteboard):
(WebKit::WebViewImpl::namesOfPromisedFilesDroppedAtDestination):
(WebKit::WebViewImpl::requestDOMPasteAccess):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebURLSchemeTask.cpp:

(WebKit::WebURLSchemeTask::didComplete):

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::saveImageToLibrary):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(allPasteboardItemOriginsMatchOrigin):
(-[WKContentView actionSheetAssistant:shareElementWithImage:rect:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dataSelectionForPasteboard):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::dataSelectionForPasteboard):

WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:

(API::InjectedBundle::EditorClient::getPasteboardDataForRange):

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]):

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::releaseSharedBuffer):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):

WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm:

(WebKit::ARKitInlinePreviewModelPlayerMac::createFile):

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didCacheResource):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveData):

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::getClientPasteboardData):

WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoading):

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):

WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::source const):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getDataSelectionForPasteboard):

WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::supportsVideoFullscreen const):
(WebKit::VideoFullscreenManager::supportsVideoFullscreenStandby const):

Source/WebKitLegacy/mac:

DOM/DOMUIKitExtensions.mm:

(-[DOMHTMLImageElement dataRepresentation:]):

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::getClientPasteboardData):

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::bufferForType):
(WebPlatformStrategies::readBufferFromPasteboard):

WebView/WebDataSource.mm:

(-[WebDataSource data]):

WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation documentSource]):

WebView/WebHTMLView.mm:

(createShareMenuItem):

WebView/WebResource.mm:

(-[WebResource encodeWithCoder:]):
(-[WebResource data]):
(-[WebResource _stringValue]):

Source/WebKitLegacy/win:

MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::createInstance):

MemoryStream.h:
WebArchive.cpp:

(WebArchive::data):

WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::getClientPasteboardData):

WebCoreSupport/WebEditorClient.h:
WebDataSource.cpp:

(WebDataSource::data):

WebResource.cpp:

(WebResource::createInstance):

WebResource.h:

Tools:

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:

(TestWebKitAPI::TEST_F):

Dec 12, 2021:

11:39 PM Changeset in webkit [286936] by sihui_liu@apple.com

22 edits
5 copies
7 adds in trunk/Source

Merge StorageManager with NetworkStorageManager to manage WebStorage by origin
https://bugs.webkit.org/show_bug.cgi?id=234087

Reviewed by Chris Dumez.

Source/WebCore:

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):
(WebCore::SQLiteFileSystem::moveDatabaseFile):
(WebCore::SQLiteFileSystem::databaseFileSize):

platform/sql/SQLiteFileSystem.h:

Source/WebKit:

In network process, WebStorage data is managed by WebKit::StorageManager class. Each StorageManager owns one or
many StorageNameSpaces, and each StorageNamespace owns one or more StorageAreas. Each StorageArea correponds
to one storage map (one localStorage or sessionStorage object), using either a SQLite database or a in-memory
map as backend. Now that we have NetworkStorageManager, which manages storage by origin. We can merge
StorageManager with NetworkStorageManager, since localStorage and sessionStorage are not shared between
different origins.

The new structure is:
NetworkStorageManager (manage storage for a session, owns one or more OriginStorageManagers)
OriginStorageManager (manage storage for an origin, owns one LocalStorageManager and one SessionStorageManager)
LocalStorageManager / SessionStorageManager (manage LocalStorage and SessionStorage, owns one or more
StorageAreaBases)
MemoryStorageArea / SQLiteStorageArea (inherits StorageAreaBases; manage one local or session storage, like
Webkit::StorageArea)

StorageNamespace layer is removed. For SessionStorage, different StorageNamespaces means different web pages,
and same origin can have different sessionStorages on different pages, so we keep a StorageNamespace <=>
StorageArea map in SessionStorageManager. For LocalStorage, differnt StorageNamespaces means different page
groups. Our original plan was the same origin can have different localStorages in different page groups, but our
old implementation actually made all page groups point to the same database file. To keep existing behavior
that all page groups with same origin share the storage, we now keep one local StorageArea and one transient
StorageArea per LocalStorageManager.

Mostly refactoring and covered by existing tests.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::addStorageManagerForSession):
(WebKit::NetworkProcess::destroySession):
(WebKit::NetworkProcess::hasLocalStorage):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::resume):
(WebKit::NetworkProcess::syncLocalStorage):
(WebKit::NetworkProcess::renameOriginInWebsiteData):
(WebKit::NetworkProcess::connectionToWebProcessClosed):
(WebKit::NetworkProcess::getLocalStorageOriginDetails): Deleted.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/storage/LocalStorageManager.cpp: Added.

(WebKit::fileNameToOrigin):
(WebKit::originToFileName):
(WebKit::LocalStorageManager::originsOfLocalStorageData):
(WebKit::LocalStorageManager::localStorageFilePath):
(WebKit::LocalStorageManager::LocalStorageManager):
(WebKit::LocalStorageManager::isActive const):
(WebKit::LocalStorageManager::hasDataInMemory const):
(WebKit::LocalStorageManager::clearDataInMemory):
(WebKit::LocalStorageManager::clearDataOnDisk):
(WebKit::LocalStorageManager::close):
(WebKit::LocalStorageManager::handleLowMemoryWarning):
(WebKit::LocalStorageManager::syncLocalStorage):
(WebKit::LocalStorageManager::connectionClosed):
(WebKit::LocalStorageManager::connectionClosedForLocalStorageArea):
(WebKit::LocalStorageManager::connectionClosedForTransientStorageArea):
(WebKit::LocalStorageManager::connectToLocalStorageArea):
(WebKit::LocalStorageManager::connectToTransientLocalStorageArea):
(WebKit::LocalStorageManager::disconnectFromStorageArea):

NetworkProcess/storage/LocalStorageManager.h: Added.
NetworkProcess/storage/MemoryStorageArea.cpp: Added.

(WebKit::MemoryStorageArea::MemoryStorageArea):
(WebKit::MemoryStorageArea::isEmpty):
(WebKit::MemoryStorageArea::clear):
(WebKit::MemoryStorageArea::allItems):
(WebKit::MemoryStorageArea::setItem):
(WebKit::MemoryStorageArea::removeItem):
(WebKit::MemoryStorageArea::clone const):

NetworkProcess/storage/MemoryStorageArea.h: Added.

(isType):

NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::readOriginFromFile):
(WebKit::writeOriginToFileIfNecessary):
(WebKit::NetworkStorageManager::create):
(WebKit::NetworkStorageManager::NetworkStorageManager):
(WebKit::NetworkStorageManager::canHandleTypes):
(WebKit::NetworkStorageManager::close):
(WebKit::originDirectoryPath):
(WebKit::originFilePath):
(WebKit::NetworkStorageManager::localOriginStorageManager):
(WebKit::NetworkStorageManager::removeOriginStorageManagerIfPossible):
(WebKit::NetworkStorageManager::deleteOriginDirectoryIfPossible):
(WebKit::NetworkStorageManager::clearStorageForTesting):
(WebKit::NetworkStorageManager::forEachOriginDirectory):
(WebKit::NetworkStorageManager::getAllOrigins):
(WebKit::NetworkStorageManager::fetchDataFromDisk):
(WebKit::NetworkStorageManager::deleteDataOnDisk):
(WebKit::NetworkStorageManager::moveData):
(WebKit::NetworkStorageManager::suspend):
(WebKit::NetworkStorageManager::resume):
(WebKit::NetworkStorageManager::handleLowMemoryWarning):
(WebKit::NetworkStorageManager::syncLocalStorage):
(WebKit::NetworkStorageManager::connectToLocalStorageArea):
(WebKit::NetworkStorageManager::connectToTransientLocalStorageArea):
(WebKit::NetworkStorageManager::connectToSessionStorageArea):
(WebKit::NetworkStorageManager::disconnectFromStorageArea):
(WebKit::NetworkStorageManager::cloneSessionStorageNamespace):
(WebKit::NetworkStorageManager::getValues):
(WebKit::NetworkStorageManager::setItem):
(WebKit::NetworkStorageManager::removeItem):
(WebKit::NetworkStorageManager::clear):
(WebKit::toWebsiteDataType): Deleted.

NetworkProcess/storage/NetworkStorageManager.h:
NetworkProcess/storage/NetworkStorageManager.messages.in:
NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::StorageBucket):
(WebKit::OriginStorageManager::StorageBucket::toWebsiteDataType):
(WebKit::OriginStorageManager::StorageBucket::toStorageIdentifier):
(WebKit::OriginStorageManager::StorageBucket::localStorageManager):
(WebKit::OriginStorageManager::StorageBucket::existingLocalStorageManager):
(WebKit::OriginStorageManager::StorageBucket::sessionStorageManager):
(WebKit::OriginStorageManager::StorageBucket::existingSessionStorageManager):
(WebKit::OriginStorageManager::StorageBucket::isActive const):
(WebKit::OriginStorageManager::StorageBucket::isEmpty const):
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInList):
(WebKit::OriginStorageManager::StorageBucket::deleteData):
(WebKit::OriginStorageManager::StorageBucket::moveData):
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInListFromMemory):
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInListFromDisk):
(WebKit::OriginStorageManager::StorageBucket::deleteLocalStorageData):
(WebKit::OriginStorageManager::StorageBucket::deleteSessionStorageData):
(WebKit::OriginStorageManager::OriginStorageManager):
(WebKit::OriginStorageManager::defaultBucket):
(WebKit::OriginStorageManager::localStorageManager):
(WebKit::OriginStorageManager::existingLocalStorageManager):
(WebKit::OriginStorageManager::sessionStorageManager):
(WebKit::OriginStorageManager::existingSessionStorageManager):
(WebKit::OriginStorageManager::isEmpty):
(WebKit::OriginStorageManager::fetchDataTypesInList):
(WebKit::OriginStorageManager::deleteData):
(WebKit::OriginStorageManager::moveData):
(WebKit::OriginStorageManager::StorageBucket::isActive): Deleted.

NetworkProcess/storage/OriginStorageManager.h:
NetworkProcess/storage/SQLiteStorageArea.cpp: Added.

(WebKit::SQLiteStorageArea::statementString const):
(WebKit::SQLiteStorageArea::SQLiteStorageArea):
(WebKit::SQLiteStorageArea::close):
(WebKit::SQLiteStorageArea::~SQLiteStorageArea):
(WebKit::SQLiteStorageArea::isEmpty):
(WebKit::SQLiteStorageArea::clear):
(WebKit::SQLiteStorageArea::createTableIfNecessary):
(WebKit::SQLiteStorageArea::prepareDatabase):
(WebKit::SQLiteStorageArea::startTransactionIfNecessary):
(WebKit::SQLiteStorageArea::cachedStatement):
(WebKit::SQLiteStorageArea::getItem):
(WebKit::SQLiteStorageArea::getItemFromDatabase):
(WebKit::SQLiteStorageArea::allItems):
(WebKit::SQLiteStorageArea::setItem):
(WebKit::SQLiteStorageArea::removeItem):
(WebKit::SQLiteStorageArea::commitTransactionIfNecessary):
(WebKit::SQLiteStorageArea::handleLowMemoryWarning):

NetworkProcess/storage/SQLiteStorageArea.h: Added.

(isType):

NetworkProcess/storage/SessionStorageManager.cpp: Added.

(WebKit::SessionStorageManager::SessionStorageManager):
(WebKit::SessionStorageManager::isActive const):
(WebKit::SessionStorageManager::hasDataInMemory const):
(WebKit::SessionStorageManager::clearData):
(WebKit::SessionStorageManager::connectionClosed):
(WebKit::SessionStorageManager::addStorageArea):
(WebKit::SessionStorageManager::connectToSessionStorageArea):
(WebKit::SessionStorageManager::disconnectFromStorageArea):
(WebKit::SessionStorageManager::cloneStorageArea):

NetworkProcess/storage/SessionStorageManager.h: Added.
NetworkProcess/storage/StorageAreaBase.cpp: Added. Some code is moved from NetworkProcess/WebStoreage/StorageArea.cpp.

(WebKit::StorageAreaBase::StorageAreaBase):
(WebKit::StorageAreaBase::addListener):
(WebKit::StorageAreaBase::removeListener):
(WebKit::StorageAreaBase::hasListeners const):
(WebKit::StorageAreaBase::notifyListenersAboutClear):
(WebKit::StorageAreaBase::dispatchEvents const):

NetworkProcess/storage/StorageAreaBase.h: Added. Some code is moved from NetworkProcess/WebStoreage/StorageArea.h.

(WebKit::StorageAreaBase::identifier const):
(WebKit::StorageAreaBase::origin const):
(WebKit::StorageAreaBase::quota const):

NetworkProcess/storage/StorageAreaRegistry.cpp: Added.

(WebKit::StorageAreaRegistry::registerStorageArea):
(WebKit::StorageAreaRegistry::unregisterStorageArea):
(WebKit::StorageAreaRegistry::getStorageArea):

NetworkProcess/storage/StorageAreaRegistry.h: Added.
Scripts/generate-unified-sources.sh:
Sources.txt:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getLocalStorageDetails): Deleted.

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::excludeDirectoryFromBackup):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::getLocalStorageDetails): Deleted.

UIProcess/WebsiteData/WebsiteDataStore.h:
UnifiedSources-output.xcfilelist:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebStorage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::ensureMap):
(WebKit::StorageAreaMap::connect):
(WebKit::StorageAreaMap::disconnect):

WebProcess/WebStorage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::copy):

11:18 PM Changeset in webkit [286935] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[RISCV64] Add MacroAssemblerRISCV64 implementations for trivial general-purpose-register operations
https://bugs.webkit.org/show_bug.cgi?id=233992

Patch by Zan Dobersek <zdobersek@igalia.com> on 2021-12-12
Reviewed by Yusuke Suzuki.

Add implementations for the trivial general-purpose-register operations
in MacroAssemblerRISCV64. This covers non-patchable loads and stores,
shifts, logical operations, zero- and sign-extensions, moves and swaps,
stack operations as well as miscellaneous operations like aborts,
breakpoints and nops.

The loadImmediate helper methods are added to handle loading of
different types of immediate values. This should replace move() calls
when a sign-extended immediate load is desired, whereas move() for
a 32-bit immediate is expected to perform no sign extension.

assembler/MacroAssemblerRISCV64.h:

(JSC::MacroAssemblerRISCV64::add32):
(JSC::MacroAssemblerRISCV64::add64):
(JSC::MacroAssemblerRISCV64::sub32):
(JSC::MacroAssemblerRISCV64::mul32):
(JSC::MacroAssemblerRISCV64::lshift32):
(JSC::MacroAssemblerRISCV64::lshift64):
(JSC::MacroAssemblerRISCV64::rshift32):
(JSC::MacroAssemblerRISCV64::rshift64):
(JSC::MacroAssemblerRISCV64::urshift32):
(JSC::MacroAssemblerRISCV64::urshift64):
(JSC::MacroAssemblerRISCV64::load8):
(JSC::MacroAssemblerRISCV64::load8SignedExtendTo32):
(JSC::MacroAssemblerRISCV64::load16):
(JSC::MacroAssemblerRISCV64::load16Unaligned):
(JSC::MacroAssemblerRISCV64::load16SignedExtendTo32):
(JSC::MacroAssemblerRISCV64::load32):
(JSC::MacroAssemblerRISCV64::load32WithUnalignedHalfWords):
(JSC::MacroAssemblerRISCV64::load64):
(JSC::MacroAssemblerRISCV64::loadPair32):
(JSC::MacroAssemblerRISCV64::store8):
(JSC::MacroAssemblerRISCV64::store16):
(JSC::MacroAssemblerRISCV64::store32):
(JSC::MacroAssemblerRISCV64::store64):
(JSC::MacroAssemblerRISCV64::storePair32):
(JSC::MacroAssemblerRISCV64::zeroExtend8To32):
(JSC::MacroAssemblerRISCV64::zeroExtend16To32):
(JSC::MacroAssemblerRISCV64::zeroExtend32ToWord):
(JSC::MacroAssemblerRISCV64::signExtend8To32):
(JSC::MacroAssemblerRISCV64::signExtend16To32):
(JSC::MacroAssemblerRISCV64::signExtend32ToPtr):
(JSC::MacroAssemblerRISCV64::and32):
(JSC::MacroAssemblerRISCV64::and64):
(JSC::MacroAssemblerRISCV64::or8):
(JSC::MacroAssemblerRISCV64::or16):
(JSC::MacroAssemblerRISCV64::or32):
(JSC::MacroAssemblerRISCV64::or64):
(JSC::MacroAssemblerRISCV64::xor32):
(JSC::MacroAssemblerRISCV64::xor64):
(JSC::MacroAssemblerRISCV64::not32):
(JSC::MacroAssemblerRISCV64::not64):
(JSC::MacroAssemblerRISCV64::neg32):
(JSC::MacroAssemblerRISCV64::neg64):
(JSC::MacroAssemblerRISCV64::move):
(JSC::MacroAssemblerRISCV64::swap):
(JSC::MacroAssemblerRISCV64::push):
(JSC::MacroAssemblerRISCV64::pushPair):
(JSC::MacroAssemblerRISCV64::pop):
(JSC::MacroAssemblerRISCV64::popPair):
(JSC::MacroAssemblerRISCV64::abortWithReason):
(JSC::MacroAssemblerRISCV64::breakpoint):
(JSC::MacroAssemblerRISCV64::nop):
(JSC::MacroAssemblerRISCV64::loadImmediate):

11:16 PM Changeset in webkit [286934] by commit-queue@webkit.org

4 edits in trunk/Source/bmalloc

[libpas] make build.sh, test.sh, build_and_test.sh, and clean.sh work on Linux
https://bugs.webkit.org/show_bug.cgi?id=233821

Patch by Zan Dobersek <zdobersek@igalia.com> on 2021-12-12
Reviewed by Yusuke Suzuki.

Adjust and enhance the shell scripts for building and testing CMake
builds of libpas. In build.sh, the 'cmake' SDK option handling is added,
invoking CMake to produce a libpas build of the desired variant and
configuration. The Debug and Release configuration possibilities map
exactly to the CMAKE_BUILD_TYPE option. The ENABLE_PAS_TESTING option
used for the testing variant is converted into a macro definition that's
passed to both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.

The function declarations are adjusted to use the "fname()" form, making
things runnable on shells that don't support the "function" keyword.

libpas/build.sh:
libpas/common.sh:
libpas/test.sh:

7:23 PM Changeset in webkit [286933] by Alan Bujtas

3 edits in trunk/Source/WebCore

[IFC][Integration] Enable isolate-override for inline boxes
https://bugs.webkit.org/show_bug.cgi?id=234203

Reviewed by Antti Koivisto.

layout/integration/LayoutIntegrationCoverage.cpp: The only reason why plaintext is not enabled yet

is becuase it may change the inline axis direction to RTL. It is going to be enabled together with the RTL support.
(WebCore::LayoutIntegration::canUseForStyle):

6:42 PM Changeset in webkit [286932] by Simon Fraser

6 edits in trunk/Source/WebCore

Ensure that the scrolling thread always commits layer position changes to reduce scrolling stutters
https://bugs.webkit.org/show_bug.cgi?id=234213

Reviewed by Tim Horton.

On a page where CA commits on the main thread take a long time (e.g. because of expensive
painting), it's possible that the main thread has updated the scrolling layer position, and
then the scrolling thread detects that the commit is taking a long time and attempts to
trigger its own commit, but because the layer position property doesn't change, no commit
occurs.

Work around this by setting the layer position to 0,0 and back when we're on the scrolling
thread. Only do this if the scroll position changed since the last display refresh to avoid
triggering redundant commits.

Ideally we'd traverse the scrolling tree and do this for every scrolling node, but scrolling
trees can get large so for now just apply this to the root node.

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateScrollPositionAtLastDisplayRefresh):

page/scrolling/ScrollingTreeScrollingNode.h:
page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::displayDidRefreshOnScrollingThread):
(WebCore::ThreadedScrollingTree::storeScrollPositionsAtLastDisplayRefresh):

page/scrolling/ThreadedScrollingTree.h:
page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionScrollingLayers):

5:46 PM Changeset in webkit [286931] by Alan Bujtas

5 edits in trunk

[LFC][IFC] Add partial unicode-bidi support on inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=234196

Reviewed by Antti Koivisto.

Source/WebCore:

This patch enables partial unicode-bidi processing on all elements (block and inline).

layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): The paragraph builder now may
produce valid bidi levels for inline box end type of inline items (see popDirectionalFormatting).

layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForStyle):

LayoutTests:

platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Progression.

5:09 PM Changeset in webkit [286930] by ysuzuki@apple.com

15 edits in trunk/Source/JavaScriptCore

[JSC] Use FixedVector to shrink some of Wasm data structures
https://bugs.webkit.org/show_bug.cgi?id=234206

Reviewed by Saam Barati.

We can use FixedVector to shrink some of Wasm data structures including Wasm::Callee.

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::PatchpointExceptionHandle::generate const):
(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):

wasm/WasmCallee.cpp:

(JSC::Wasm::LLIntCallee::linkExceptionHandlers):
(JSC::Wasm::OptimizingJITCallee::linkExceptionHandlers):
(JSC::Wasm::OptimizingJITCallee::stackmap const):

wasm/WasmCallee.h:

(JSC::Wasm::Callee::hasExceptionHandlers const):
(JSC::Wasm::JITCallee::wasmToWasmCallsites):
(JSC::Wasm::OptimizingJITCallee::OptimizingJITCallee):

wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::CodeBlock):

wasm/WasmCodeBlock.h:
wasm/WasmHandlerInfo.cpp:

(JSC::Wasm::HandlerInfo::handlerForIndex):

wasm/WasmHandlerInfo.h:
wasm/WasmOSREntryData.h:

(JSC::Wasm::OSREntryData::OSREntryData):
(JSC::Wasm::OSREntryData::values):
(JSC::Wasm::OSREntryValue::OSREntryValue): Deleted.
(JSC::Wasm::OSREntryValue::type const): Deleted.

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::updateCallSitesToCallUs):

wasm/WasmTierUpCount.cpp:

(JSC::Wasm::TierUpCount::addOSREntryData):

wasm/WasmTierUpCount.h:
wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):

wasm/js/JSWebAssemblyCodeBlock.h:

3:49 PM Changeset in webkit [286929] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC][IFC] Add partial unicode-bidi support on the block container
https://bugs.webkit.org/show_bug.cgi?id=234195

Reviewed by Antti Koivisto.

'unicode-bidi: plaintext' on the block container may change the base directionality of
the container itself. We only support LTR inline axis direction.

layout/formattingContexts/inline/InlineItemsBuilder.cpp:

(WebCore::Layout::handleEnterExitBidiContext):
(WebCore::Layout::buildBidiParagraph): Add control character for the unicode-bidi property on the block container.
(WebCore::Layout::InlineItemsBuilder::breakAndComputeBidiLevels):

layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForStyle):
(WebCore::LayoutIntegration::canUseForRenderInlineChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
(WebCore::LayoutIntegration::canUseForLineLayoutAfterStyleChange):

2:10 PM Changeset in webkit [286928] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][IFC] Ignore zero width glyphs while collecting fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=234210

Reviewed by Antti Koivisto.

Source/WebCore:

Taking zero width glyphs (e.g. control characters) into consideration while collecting
fallback font information may result in incorrect line height and baseline positioning.

The logic in this patch matches with WidthIterator::commitCurrentFontRange (used by legacy line layout).
It is measured to have only a slight perf impact on layout microbenchmarks (~1%).
Alternatively we could check against unicode ranges to omit certain glyphs.

Test: fast/text/fallback-font-and-zero-width-glyph.html

layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::fallbackFontsForRunWithIterator):

LayoutTests:

fast/text/fallback-font-and-zero-width-glyph-expected.html: Added.
fast/text/fallback-font-and-zero-width-glyph.html: Added.

12:21 PM Changeset in webkit [286927] by Fujii Hironori

2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

platform/wincairo/TestExpectations:

9:44 AM Changeset in webkit [286926] by commit-queue@webkit.org

17 edits in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=234209

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-12-12

platform/glib/TestExpectations:
platform/glib/imported/w3c/web-platform-tests/css/cssom-view/getBoundingClientRect-shy-expected.txt:
platform/glib/svg/css/getComputedStyle-basic-expected.txt:
platform/glib/webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-2-expected.txt:
platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
platform/wpe/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
platform/wpe/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
platform/wpe/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:

9:31 AM Changeset in webkit [286925] by weinig@apple.com

17 edits
1 copy in trunk

Pipe ColorInterpolationMethod into Gradient
https://bugs.webkit.org/show_bug.cgi?id=234205

Reviewed by Antti Koivisto.

Source/WebCore:

There is no functional change yet, this just adds a required ColorInterpolationMethod parameter to
Gradient, which for the moment has to be SRGB and non-premultiplied alpha. Subsequent changes will
support for specifying an interpolation method via CSS gradients as well as implementing support
for that in the platform gradient backends.

Also moves the ColorInterpolationMethod struct into its own file as it was getting quite long.

Headers.cmake:
WebCore.xcodeproj/project.pbxproj:
css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::equals const):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

css/CSSGradientValue.h:

(WebCore::CSSGradientValue::CSSGradientValue):
(WebCore::CSSGradientValue::colorInterpolationMethod const):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeConicGradient):

html/HTMLInputElement.cpp:

(WebCore::autoFillStrongPasswordMaskImage):

html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):

platform/graphics/ColorInterpolation.h:

(WebCore::interpolateColorComponents):
(WebCore::ColorInterpolationMethod::encode const): Deleted.
(WebCore::ColorInterpolationMethod::decode): Deleted.

platform/graphics/ColorInterpolationMethod.h: Added.

(WebCore::ColorInterpolationMethod::encode const):
(WebCore::ColorInterpolationMethod::decode):
(WebCore::add):
(WebCore::operator==):

platform/graphics/Gradient.cpp:

(WebCore::Gradient::create):
(WebCore::Gradient::Gradient):
(WebCore::Gradient::hash const):

platform/graphics/Gradient.h:

(WebCore::Gradient::encode const):
(WebCore::Gradient::decode):

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::checkboxRadioBackgroundGradient):
(WebCore::RenderThemeIOS::paintColorWellDecorations):

rendering/svg/RenderSVGResourceLinearGradient.cpp:

(WebCore::RenderSVGResourceLinearGradient::buildGradient const):

rendering/svg/RenderSVGResourceRadialGradient.cpp:

(WebCore::RenderSVGResourceRadialGradient::buildGradient const):

Tools:

Update calls to Gradient::create() to pass the now required ColorInterpolationMethod.

TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp:

(TestWebKitAPI::createGradient):

TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp:

(TestWebKitAPI::TEST):

9:29 AM Changeset in webkit [286924] by Alan Bujtas

2 edits in trunk/LayoutTests

IFC progression after r286121.

Unreviewed gardening.

TestExpectations:

1:05 AM Changeset in webkit [286923] by graouts@webkit.org

3 edits
2 adds in trunk/LayoutTests

Add a test for document.timeline.maximumFrameRate
https://bugs.webkit.org/show_bug.cgi?id=234200

Reviewed by Dean Jackson.

Bug 234161 added a new document.timeline.maximumFrameRate property but didn't feature
a test. This new test checks that we have a minimum of 60fps reported.

platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:
webanimations/frame-rate/document-timeline-maximum-frame-rate-expected.txt: Added.
webanimations/frame-rate/document-timeline-maximum-frame-rate.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed