Timeline
Feb 25, 2022:
- 11:58 PM Changeset in webkit [290545] by
-
- 7 edits2 adds in trunk
Scrollbars disappear when very long or wide
https://bugs.webkit.org/show_bug.cgi?id=237232
Source/WebCore:
<rdar://17540446>
Reviewed by Tim Horton.
Our tiling logic does not play nicely with AppKit's NSScrollerImps, probably because we
inadvertently unparent its layers.
Fix by disallowing GraphicsLayers for scrollbars from going into tiled mode, for
both root and overflow scrollbars.
Test: fast/scrolling/mac/scrollbars/very-wide-overlay-scrollbar.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setAllowsTiling):
(WebCore::GraphicsLayer::allowsTiling const):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
LayoutTests:
Reviewed by Tim Horton.
- fast/scrolling/mac/scrollbars/very-wide-overlay-scrollbar-expected-mismatch.html: Added.
- fast/scrolling/mac/scrollbars/very-wide-overlay-scrollbar.html: Added.
- 9:42 PM Changeset in webkit [290544] by
-
- 5 edits in trunk
[macOS] TestWebKitAPI.WebKit.MigrateLocalStorageDataToGeneralStorageDirectory is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=237065
<rdar://problem/89324250>
Reviewed by Alexey Proskuryakov.
Source/WebKit:
Commit transactions of SQLiteStorageArea at exit of network process.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
- NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::commitTransactionsAtExit):
(WebKit::SQLiteStorageArea::SQLiteStorageArea):
(WebKit::SQLiteStorageArea::startTransactionIfNecessary):
(WebKit::SQLiteStorageArea::commitTransactionIfNecessary):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- 9:38 PM Changeset in webkit [290543] by
-
- 5 edits in trunk
Adjust -[WKContentView _requiresKeyboardWhenFirstResponder] to account for editable web views
https://bugs.webkit.org/show_bug.cgi?id=237226
rdar://89447095
Reviewed by Aditya Keerthi.
Source/WebKit:
Adjust the implementation of
-[WKContentView _requiresKeyboardWhenFirstResponder], such that it returns YES
for editable web views, except for the scenario where an input field that does *not* require the automatic
keyboard is currently focused in the page inside the editable web view (e.g. areadonlytext field).
UIKit consults this method to know whether or not a given responder would require the keyboard (either software
keyboard or the minimized UCB for hardware keyboard) if it were to become the first responder. For web views
that are made editable in the SPI sense, we know a-priori that this should return YES, unless a readonly element
underneath the web view has focus (in which case,_disableAutomaticKeyboardUIwould be true).
Test: KeyboardInputTests.EditableWebViewRequiresKeyboardWhenFirstResponder
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
Tools:
Add an API test to exercise the change. This new API test is comprised of 3 parts:
- Verify that
-_requiresKeyboardWhenFirstResponderis NO after loading the page. - Verify that
-_requiresKeyboardWhenFirstResponderbecomes YES after making the web view editable. - Verify that
-_requiresKeyboardWhenFirstResponderis NO again after focusing a readonly input inside the now-editable web view.
- TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/ios/UIKitSPI.h:
- 9:05 PM Changeset in webkit [290542] by
-
- 4 edits in trunk/Source
[GPU Process] Implement RemoteImageBufferProxy::drawConsuming()
https://bugs.webkit.org/show_bug.cgi?id=236685
rdar://89007426
Reviewed by Simon Fraser.
Source/WebCore:
Assert ImageBuffer::drawConsuming() does not draw into its backend before
it is destroyed.
- platform/graphics/ConcreteImageBuffer.h:
Source/WebKit:
RemoteImageBufferProxy::drawConsuming() should call drawImageBuffer() of
the destination GraphicsContext. No recursion will happen and the expected
behavior will be achieved by this change.
This is the sequence of calls when the Destination GraphicsContext is
local and when it is remote:
-- Destination GraphicsContext is local:
In this case, the backend of the RemoteImageBufferProxy can be mapped
in WebProcess; i.e. we do have access to its memory.
ConcreteImageBuffer::draw() will be called eventually. This function
will call its backend->draw() which will get a NativeImage by calling
backend->copyNativeImage(). There is no difference between draw() and
drawConsuming() in this case because the backend is still owned by
GPUProcess. So it will not be released immediately. We do not copy the
pixels since we have to pass DontCopyBackingStore to copyNativeImage().
-- Destination GraphicsContext is remote:
In this case, Recorder::drawImageBuffer() will be called which will
call RemoteDisplayListRecorderProxy::recordDrawImageBuffer(). This
will send a message to GPUProcess and hence all the drawing will
happen in GPUProcess. Similar to the case of the local GraphicsContext,
no pixels will be copied from the RemoteImageBuffer backend to the
NativeImage in all cases. The assumption is the backend will be destroyed
automatically after calling drawConsuming().
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- 7:59 PM Changeset in webkit [290541] by
-
- 3 edits in trunk/Source/bmalloc
[libpas] Suppress cast-align warnings
https://bugs.webkit.org/show_bug.cgi?id=237179
<rdar://problem/89479570>
Reviewed by Yusuke Suzuki.
Ignore cast-align warnings for libpas target.
- CMakeLists.txt:
- libpas/src/libpas/bmalloc_heap_inlines.h:
- 6:03 PM Changeset in webkit [290540] by
-
- 12 edits1 copy2 deletes in trunk/Source/WebCore
[GTK][WPE][WC] Move ANGLE context initialisation to GraphicsContextGLTextureMapper::initialize
https://bugs.webkit.org/show_bug.cgi?id=236769
Reviewed by Chris Lord.
This is the first step for the long-term plan to share more code
in GraphicsContextGLANGLE between Cocoa and non-Cocoa, and
minimise the ifdefs in GraphicsContextGLANGLE.
We are moving the context initialisation and holding to
GraphicsContextGLTextureMapper, away from
GCGLANGLELayer::ANGLEContext and the layer classes in case of
COORDINATED_GRAPHICS. Later on, Cocoa and non-Cocoa can merge
their ::initialize.
No new tests, this is a refactoring patch.
- platform/TextureMapper.cmake:
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:
(Nicosia::GCGLANGLELayer::GCGLANGLELayer):
(Nicosia::GCGLANGLELayer::ANGLEContext::errorString): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::lastErrorString): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::createContext): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::ANGLEContext): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::~ANGLEContext): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::makeContextCurrent): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::platformContext const): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::platformDisplay const): Deleted.
(Nicosia::GCGLANGLELayer::ANGLEContext::platformConfig const): Deleted.
(Nicosia::GCGLANGLELayer::makeContextCurrent): Deleted.
(Nicosia::GCGLANGLELayer::platformContext const): Deleted.
(Nicosia::GCGLANGLELayer::platformDisplay const): Deleted.
(Nicosia::GCGLANGLELayer::platformConfig const): Deleted.
- platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:
(WebCore::GraphicsContextGLOpenGL::initialize):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/texmap/ANGLEContext.cpp: Removed.
- platform/graphics/texmap/ANGLEContext.h: Removed.
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
(WebCore::GraphicsContextGLTextureMapper::create):
(WebCore::GraphicsContextGLTextureMapper::GraphicsContextGLTextureMapper):
(WebCore::GraphicsContextGLTextureMapper::layerContentsDisplayDelegate):
(WebCore::GraphicsContextGLTextureMapper::platformInitialize):
(): Deleted.
- platform/graphics/texmap/GraphicsContextGLTextureMapper.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLTextureMapper::platformInitializeContext):
(WebCore::GraphicsContextGLTextureMapper::platformInitialize):
(WebCore::GraphicsContextGLANGLE::platformDisplay const):
(WebCore::GraphicsContextGLANGLE::platformConfig const):
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
- platform/graphics/texmap/PlatformLayerDisplayDelegate.h: Copied from Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.h.
- platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp:
(WebCore::TextureMapperGCGLPlatformLayer::TextureMapperGCGLPlatformLayer):
(WebCore::TextureMapperGCGLPlatformLayer::~TextureMapperGCGLPlatformLayer):
(WebCore::TextureMapperGCGLPlatformLayer::paintToTextureMapper):
(WebCore::TextureMapperGCGLPlatformLayer::makeContextCurrent): Deleted.
(WebCore::TextureMapperGCGLPlatformLayer::platformContext const): Deleted.
(WebCore::TextureMapperGCGLPlatformLayer::platformDisplay const): Deleted.
(WebCore::TextureMapperGCGLPlatformLayer::platformConfig const): Deleted.
(WebCore::TextureMapperGCGLPlatformLayer::proxy const): Deleted.
(WebCore::TextureMapperGCGLPlatformLayer::swapBuffersIfNeeded): Deleted.
- platform/graphics/texmap/TextureMapperGCGLPlatformLayer.h:
- 5:47 PM Changeset in webkit [290539] by
-
- 4 edits in trunk
[WebAuthn] Fallback to attestation=none whenever attestation fails
https://bugs.webkit.org/show_bug.cgi?id=237223
rdar://88767812
Reviewed by Brent Fulgham.
Source/WebKit:
Whenever attestation is requested by a RP and it fails to complete,
we previously errored out of the registration. The more correct platform
behavior in this case is to provide attestation=none.
Created API test for this behavior.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
Tools:
Add test for local authenticator attestation fallback behavior.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- 5:19 PM Changeset in webkit [290538] by
-
- 5 edits in trunk/Source/WebCore
Use the modern Hasher more in Content Extensions code
https://bugs.webkit.org/show_bug.cgi?id=237228
Reviewed by Darin Adler.
- contentextensions/CombinedFiltersAlphabet.cpp:
(WebCore::ContentExtensions::add):
(WebCore::ContentExtensions::TermCreatorTranslator::hash):
- contentextensions/CombinedFiltersAlphabet.h:
(WebCore::ContentExtensions::CombinedFiltersAlphabet::TermPointerHash::hash):
- contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::add):
(WebCore::ContentExtensions::TriggerHash::hash):
- contentextensions/Term.h:
(WebCore::ContentExtensions::Term::Group::operator== const):
(WebCore::ContentExtensions::add):
(WebCore::ContentExtensions::Term::CharacterSet::hash const): Deleted.
(WebCore::ContentExtensions::Term::Group::hash const): Deleted.
(WebCore::ContentExtensions::Term::hash const): Deleted.
- 4:27 PM Changeset in webkit [290537] by
-
- 2 edits in trunk/Source/WebCore
Do not trigger didFail during FileReaderLoader Destruction
https://bugs.webkit.org/show_bug.cgi?id=237060
Patch by Brandon Stewart <Brandon> on 2022-02-25
Reviewed by Darin Adler.
Setting cancel() instead of terminate() will prevent the didFail() method from being triggered.
This method has the unfortunate side effect of trying to allocate memory, which is not allowed when
under going a sweep event.
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::~FileReaderLoader):
- 4:17 PM Changeset in webkit [290536] by
-
- 1 copy in tags/Safari-613.1.17.1.9
Tag Safari-613.1.17.1.9.
- 4:04 PM Changeset in webkit [290535] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Add access to required mach service in the Network process
https://bugs.webkit.org/show_bug.cgi?id=237216
<rdar://89176897>
Reviewed by Brent Fulgham.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 4:02 PM Changeset in webkit [290534] by
-
- 8 edits2 adds in trunk
WebKit continues to render PDF images in Captive Portal mode
https://bugs.webkit.org/show_bug.cgi?id=237120
<rdar://problem/89384234>
Reviewed by Chris Dumez.
Source/WebCore:
WebKit should handle all PDF processing in PDF.JS when in Captive Portal mode. However, testing
revealed that PDF images are still rendered natively. As a first step we should bypass the
native PDF code path. A subsequent patch will handle in PDF.JS.
We need to thread the state of the Captive Portal setting through the image loading code so that
WebKit knows to bail out before consuming the PDF data in the native decoder.
Tested by TestWebKitAPI.
- page/RuntimeEnabledFeatures.h: Add new flag for PDF image decoding state.
- platform/graphics/Image.cpp:
(WebCore::Image::create): Check whether PDF image decoding should be permitted.
Source/WebKit:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Turn PDF image decoding off when in CaptivePortal mode.
Tools:
WebKit should handle all PDF processing in PDF.JS when in Captive Portal mode. However, testing
revealed that PDF images are still rendered natively. As a first step we should bypass the
native PDF code path. A subsequent patch will handle in PDF.JS.
We need to thread the state of the Captive Portal setting through the image loading code so that
WebKit knows to bail out before consuming the PDF data in the native decoder.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/CaptivePortalPDF.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[CaptivePortalMessageHandler userContentController:didReceiveScriptMessage:]): Add new test case.
- TestWebKitAPI/Tests/WebKitCocoa/webkit-logo.pdf: Added.
- 3:49 PM Changeset in webkit [290533] by
-
- 1 copy in tags/Safari-614.1.5.5
Tag Safari-614.1.5.5.
- 3:45 PM Changeset in webkit [290532] by
-
- 8 edits in trunk
Regression(r242729): m_origin in IDBDatabaseIdentifier is incorrect
https://bugs.webkit.org/show_bug.cgi?id=237044
Reviewed by Youenn Fablet.
Source/WebCore:
In r242729, we swapped top origin and opening origin in m_origin (it is a ClientOrigin) of IDBDatabaseIdentifier.
This can cause trouble since IndexedDB operation will be processed by wrong OriginStorageManager
(OriginStorageManager is identified by ClientOrigin). To fix this issue, we need to swap it back.
New test: IndexedDB.IndexedDBThirdPartyStorageLayout
- Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot const):
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot):
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::diskUsage):
Source/WebKit:
- NetworkProcess/storage/IDBStorageManager.cpp:
(WebKit::migrateOriginData):
(WebKit::IDBStorageManager::idbStorageOriginDirectory):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
(-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):
- 3:29 PM Changeset in webkit [290531] by
-
- 3 edits4 adds in trunk
SharedArrayBuffer posted to AudioWorkletProcessor is not actually shared with the main thread
https://bugs.webkit.org/show_bug.cgi?id=237144
<rdar://problem/89479641>
Reviewed by Darin Adler.
Source/WebCore:
SerializedScriptValue only maintains SharedArrayBuffers when constructed with SerializationContext::WorkerPostMessage.
With other SerializationContext values, such as the default one that AudioWorkletNode was using, SharedArrayBuffers
are serialized as simple arrays and are no longer shared.
This patch passes SerializationContext::WorkerPostMessage when constructing the SerializedScriptValue since we want
SharedArrayBuffer sharing and since a worklet is essentially a worker.
Note that this patch allows passing a SharedArrayBuffer to an AudioWorklet upon construction via processorOptions.
However, SharedArrayBuffer still won't be shared if sent later on via a MessagePort.postMessage() call. This is
because MessagePort.postMessage() routes all messages via the network process, even if the destination ends up
being within the same process as the sender (See Bug 220038).
Test: http/wpt/webaudio/the-audio-api/the-audioworklet-interface/shared-array-buffer.https.html
- Modules/webaudio/AudioWorkletNode.cpp:
(WebCore::AudioWorkletNode::create):
LayoutTests:
Add layout test coverage.
- http/wpt/webaudio/the-audio-api/the-audioworklet-interface/processors/shared-array-buffer-processor.js: Added.
(SharedArrayBufferTestProcessor):
(SharedArrayBufferTestProcessor.prototype.process):
- http/wpt/webaudio/the-audio-api/the-audioworklet-interface/shared-array-buffer.https-expected.txt: Added.
- http/wpt/webaudio/the-audio-api/the-audioworklet-interface/shared-array-buffer.https.html: Added.
- http/wpt/webaudio/the-audio-api/the-audioworklet-interface/shared-array-buffer.https.html.headers: Added.
- 3:19 PM Changeset in webkit [290530] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove incorrect ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=237185
<rdar://problem/83902782>
Reviewed by Yusuke Suzuki.
These debug ASSERTs were added in http://trac.webkit.org/r283632 back when we
weren't sure that the StringImpl pointer can be null or not. We're now certain
that the StringImpl pointer can be null because:
The site of the ASSERT looks like this:
`
auto* impl = string->tryGetValueImpl();
ASSERT(impl); FIXME: rdar://83902782
if (impl && impl->isAtom() &&
...
`
... where string is a JSString, which can also be a JSRopeString.
JSString::tryGetValueImpl() is:
`
inline const StringImpl* JSString::tryGetValueImpl() const
{
uintptr_t pointer = fiberConcurrently();
if (pointer & isRopeInPointer)
return nullptr;
return bitwise_cast<StringImpl*>(pointer);
}
`
If string is a JSRopeString, the returned impl will be null. Hence, the ASSERT is
invalid and should be removed.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::handlePutByVal):
- 2:24 PM Changeset in webkit [290529] by
-
- 1 copy in releases/WPE WebKit/webkit-2.35.90
WPE WebKit 2.35.90
- 2:20 PM Changeset in webkit [290528] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.90 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.35.90.
- 2:20 PM Changeset in webkit [290527] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Unreviewed non-unified build fix.
- WebProcess/glib/WebProcessGLib.cpp: Add missing WebPage.h inclusion.
- 2:18 PM Changeset in webkit [290526] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] HLS + Modern EME key rotation causes playback to stall indefinitely
https://bugs.webkit.org/show_bug.cgi?id=237214
<rdar://89372801>
Reviewed by Eric Carlson.
In r275916, Ref was changed to perform pointer equality in its operator==. This caused
takeUnexpectedKeyRequestForInitializationData() to fail to find key requests matching
the initData passed in through MediaKeySession.
Fix the equality test by calling .get() on the Ref, which causes the
==to resolve to
FragmentedSharedBuffer::operator==().
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::takeUnexpectedKeyRequestForInitializationData):
- 1:01 PM Changeset in webkit [290525] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r290516.
https://bugs.webkit.org/show_bug.cgi?id=237222
broke debug tests
Reverted changeset:
"[JSC] Use DeferTerminationForAWhile in Interpreter::unwind"
https://bugs.webkit.org/show_bug.cgi?id=237176
https://commits.webkit.org/r290516
- 12:54 PM Changeset in webkit [290524] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 ] 7X imported/w3c/web-platform-tests/pointerevents/pointerevent (layout-tests) are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=236128
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 12:44 PM Changeset in webkit [290523] by
-
- 4 edits1 copy in trunk/Source/WTF
[XCBuild] Add missing header build rule for Scripts/Preferences/*
https://bugs.webkit.org/show_bug.cgi?id=237129
Reviewed by Alexey Proskuryakov.
Relands "[XCBuild] WTF's SPI dependencies are copied via a folder reference and do not emit
task outputs".
r290452 missed adding a build rule which would copy $SRCROOT/Scripts/Preferences/* to
/usr/local/include/wtf/Scripts/Preferences, and caused clean builds to start failing. Fix by
adding the needed build rule.
- Configurations/Base.xcconfig:
- Configurations/WTF.xcconfig:
- Configurations/icu.xcconfig:
- WTF.xcodeproj/project.pbxproj:
- 12:19 PM Changeset in webkit [290522] by
-
- 2 edits in trunk/LayoutTests
[ iOS EWS ] imported/w3c/web-platform-tests/svg/coordinate-systems/abspos.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=237220
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-25
- platform/ios/TestExpectations:
- 12:08 PM Changeset in webkit [290521] by
-
- 4 edits in trunk/Source/WebKit
Make sure there is a default Networking process to provide the Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=236629
Reviewed by Brent Fulgham.
The WebContent processes relies on getting the Launch Services database from the Networking process.
It is possible to enter a state where there is no default Network process, but a Network process is
running because a Website data store is holding a reference to it. This patch addresses this issue
by removing Network process references in all remaining Website data stores when the last process
pool is being deleted.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::~WebProcessPool):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeNetworkProcessReference):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 11:42 AM Changeset in webkit [290520] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r289787?) [ iOS EWS ]fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html is a flaky image failure.
https://bugs.webkit.org/show_bug.cgi?id=237218
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-25
- platform/ios/TestExpectations:
- 11:26 AM Changeset in webkit [290519] by
-
- 18 edits15 adds in trunk
Re-add YouTubePluginReplacement, removed in r285252
https://bugs.webkit.org/show_bug.cgi?id=237182
Source/WebCore:
<rdar://89148022>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-25
Reviewed by Chris Dumez.
Tests: security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html
security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type.html
security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement.html
Its removal broke webpages that work in Chrome and Firefox, so back it comes.
- Headers.cmake:
- Modules/plugins: Copied from Source/WebCore/Modules/plugins.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestPluginInterface.cpp:
(WebCore::JSTestPluginInterface::visitChildrenImpl):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::createElementRenderer):
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot):
(WebCore::registrar):
(WebCore::pluginReplacementForType):
(WebCore::HTMLPlugInElement::requestObject):
(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement):
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::pluginReplacementScriptObject):
- html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::webkitPluginReplacement):
- html/shadow/ShadowPseudoIds.h:
- html/shadow/YouTubeEmbedShadowElement.cpp:
- html/shadow/YouTubeEmbedShadowElement.h:
- page/Settings.yaml:
Tools:
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-25
Reviewed by Chris Dumez.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
LayoutTests:
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-25
Reviewed by Chris Dumez.
- TestExpectations:
- platform/ios-wk2/TestExpectations:
- platform/win/TestExpectations:
- security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement-expected.txt: Copied from LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement-expected.txt.
- security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html: Copied from LayoutTests/security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html.
- security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement-expected.txt.
- security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html.
- security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-expected.txt: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-expected.txt.
- security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type-expected.txt: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type-expected.txt.
- security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type.html: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type.html.
- security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement.html: Copied from LayoutTests/security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement.html.
- 11:13 AM Changeset in webkit [290518] by
-
- 8 edits2 adds in branches/safari-613.1.17.1-branch
Cherry-pick r290512. rdar://problem/86582214
[Tables] Incorrect table sizing when colgroup comes after tbody
https://bugs.webkit.org/show_bug.cgi?id=237205
<rdar://86582214>
Reviewed by Antti Koivisto.
Source/WebCore:
Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442&view=revision)
Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::firstColumn const):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::nextColumn const):
LayoutTests:
- fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
- fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
- platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
- platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt: Progression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:03 AM Changeset in webkit [290517] by
-
- 4 edits1 add in trunk
operationMaterializeObjectInOSR should DeferTerminationForAWhile instead of just DeferTermination.
https://bugs.webkit.org/show_bug.cgi?id=237173
rdar://problem/89450245
Reviewed by Yusuke Suzuki.
JSTests:
- stress/termination-exception-in-operationMaterializeObjectInOSR2.js: Added.
Source/JavaScriptCore:
DeferTermination can throw the TerminationException on destruction of the scope
object. operationMaterializeObjectInOSR() was using DeferTermination, resulting
in the TerminationException being thrown on exit. This trips up
validateDFGExceptionHandling testing (which is enabled on Debug builds) because the
TerminationException is unexpected. The solution is simply to use
DeferTerminationForAWhile instead, and let a more natural trap checkpoint throw
the TerminationException later.
Also refactored notifyDebuggerOfUnwinding() to return early if a debugger is not
present. This avoids unnecessarily entering and exiting a DeferTermination scope
in notifyDebuggerOfUnwinding(). This was observed while testing this change on
the attached test case.
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- interpreter/Interpreter.cpp:
(JSC::notifyDebuggerOfUnwinding):
- 10:53 AM Changeset in webkit [290516] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Use DeferTerminationForAWhile in Interpreter::unwind
https://bugs.webkit.org/show_bug.cgi?id=237176
Reviewed by Mark Lam.
Interpreter::unwind calls sanitizeRemoteFunctionException, which would like to create scope (but it
does not have user observable behavior). Problem is that, since it is creating a scope, it can throw
a termination exception. We were using DeferTermination, but destructor of this scope can still set
termination exception, which results in throwing a termination exception for the error handler.
We use DeferTerminationForAWhile in the prologue of the Interpreter::unwind to ensure that this function
will not accept termination exception coming concurrently.
- interpreter/Interpreter.cpp:
(JSC::sanitizeRemoteFunctionException):
(JSC::Interpreter::unwind):
- 10:44 AM Changeset in webkit [290515] by
-
- 9 edits in trunk
[WebAuthn] Use default pubKeyCredParams if empty in makeCredential
https://bugs.webkit.org/show_bug.cgi?id=237109
rdar://problem/89376484
Reviewed by Brent Fulgham.
Source/WebCore:
The Web Authentication level 2 spec was updated to clarify that
a set of default pubKeyCredParams should be used if the list
supplied by the RP is empty. This patch starts using
the default and updates associated tests.
- Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
- Modules/webauthn/PublicKeyCredentialCreationOptions.h:
- Modules/webauthn/WebAuthenticationConstants.h:
LayoutTests:
Update tests to take in account using default pubKeyCredParams.
- http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-failure.https.html:
- http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
- 9:23 AM Changeset in webkit [290514] by
-
- 2 edits in trunk/Source/WebCore
Use modern Hasher in ContentExtensionsActions
https://bugs.webkit.org/show_bug.cgi?id=237157
Reviewed by Darin Adler.
- contentextensions/ContentExtensionActions.h:
(WebCore::ContentExtensions::add):
(WTF::DefaultHash<WebCore::ContentExtensions::RedirectAction>::hash):
(WTF::DefaultHash<WebCore::ContentExtensions::ModifyHeadersAction>::hash):
(WebCore::ContentExtensions::VariantHasher::hash): Deleted.
(WebCore::ContentExtensions::VectorHasher::hash): Deleted.
- 8:56 AM Changeset in webkit [290513] by
-
- 11 edits in trunk/Source/WebKit
Better isolate RemoteVideoFrameObjectHeap clients from ThreadSafeObjectHeap implementation details
https://bugs.webkit.org/show_bug.cgi?id=237191
Reviewed by Kimmo Kinnunen.
Refactoring to make RemoteVideoFrameObjectHeap API independent of ThreadSafeObjectHeap.
This makes code more readable and simplifies client side usage as well,
for instance by not having to care about timers, or using more known names like add/get instead of retire.
No change of behavior.
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
- Shared/ThreadSafeObjectHeap.h:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- 8:44 AM Changeset in webkit [290512] by
-
- 8 edits2 adds in trunk
[Tables] Incorrect table sizing when colgroup comes after tbody
https://bugs.webkit.org/show_bug.cgi?id=237205
<rdar://86582214>
Reviewed by Antti Koivisto.
Source/WebCore:
Let's use the colgroup for table sizing even when it comes after any thead, tbody, tfoot, and tr elements.
This makes WebKit match other rendering engines (see https://src.chromium.org/viewvc/blink?revision=159442&view=revision)
Test: fast/table/table-sizing-fails-when-colgroup-comes-after-content.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::firstColumn const):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::nextColumn const):
LayoutTests:
- fast/table/table-sizing-fails-when-colgroup-comes-after-content-expected.html: Added.
- fast/table/table-sizing-fails-when-colgroup-comes-after-content.html: Added.
- platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt: Progression.
- platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt: Progression.
- 8:43 AM Changeset in webkit [290511] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.5
- 8:32 AM Changeset in webkit [290510] by
-
- 4 edits in trunk/Source/JavaScriptCore
Web Inspector: [Cocoa] Split remote inspector message data into smaller chunks for large messages
https://bugs.webkit.org/show_bug.cgi?id=237110
<rdar://89364487>
Reviewed by Devin Rousso.
Messages over 2 MiB will now be split into multiple chunks, which allows us to not exceed any receiving daemon
process' memory limit under otherwise normal conditions. 2 MiB was chosen as a balance between not having to
split most messages at all and making sure that the messages (and any copies made during the relaying of the
messages) do not exceed the memory limits of the receiving daemon process.
In order to prevent us from sending chunked messages to a process that doesn't support them we check for a flag
to enable this functionality during connection setup.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspectorConstants.h:
- inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::receivedSetupMessage):
- 8:23 AM Changeset in webkit [290509] by
-
- 2 edits in trunk/Source/WebKit
Remove unused soft linking declarations
https://bugs.webkit.org/show_bug.cgi?id=237209
Reviewed by Brent Fulgham.
- WebProcess/cocoa/WebProcessCocoa.mm:
- 8:04 AM Changeset in webkit [290508] by
-
- 3 edits in trunk/Tools
[Python 3] Invoke validate-committer-lists with Python 3
https://bugs.webkit.org/show_bug.cgi?id=237171
<rdar://problem/89449485>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/validate-committer-lists:
(CommitterListFromMailingList): Use https urls.
(CommitterListFromMailingList._fetch_authors_and_last_commit_time_from_git_log):
Handle commits in the canonical repository.
(CommitterListFromGit.possibly_expired_committers): Use Python 3 sorting idioms.
(CommitterListFromGit.possibly_inactive_reviewers): Declare process encoding.
(CommitterListFromGit.print_possibly_expired_committers): Committers which are not in
contributors.json or are only contributors cannot have expired committer status.
(CommitterListFromGit.print_possibly_inactive_reviewers): String already utf-8.
(CommitterListFromGit.print_committers_missing_from_committer_list): Check contributors,
not committers.
- Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_matching_quicksearch): Make urllib.quote invocations Python 3 compatible.
(BugzillaQueries.fetch_bugs_matching_search): Ditto.
(BugzillaQueries.fetch_bugs_from_review_queue): Ditto.
(BugzillaQueries.fetch_login_userid_pairs_matching_substring): Ditto.
(BugzillaQueries.is_invalid_bugzilla_email): Ditto.
Canonical link: https://commits.webkit.org/247793@main
- 7:49 AM Changeset in webkit [290507] by
-
- 5 edits1 add in trunk
Non-simple CORS preflight fails due to cache-control header
https://bugs.webkit.org/show_bug.cgi?id=236837
<rdar://problem/89382796>
Reviewed by Chris Dumez.
Source/WebCore:
We fixed cache-control in https://bugs.webkit.org/show_bug.cgi?id=233916.
The fix to make the website work is to ensure that Content-Type is not cleared when going to service worker.
Covered by updated tests.
- Modules/beacon/NavigatorBeacon.cpp:
LayoutTests:
- http/wpt/service-workers/cache-control-request-expected.txt:
- http/wpt/service-workers/cache-control-request.html:
- http/wpt/service-workers/resources/cross-origin-allow-for-beacon.py: Added.
- 5:28 AM Changeset in webkit [290506] by
-
- 8 edits in trunk
[GTK][WPE] Uncouple libgbm, libdrm dependencies from ANGLE functionality
https://bugs.webkit.org/show_bug.cgi?id=237199
Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-02-25
Reviewed by Chris Lord.
.:
For both GTK and WPE, unconditionally search for the libgbm and libdrm
dependencies as they will also be needed outside of ANGLE functionality.
USE_ANGLE is defined along with USE_NICOSIA, but still only if the
relevant option was enabled.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Source/WebCore:
Unconditionally build with libgbm and libdrm cflags and linker flags
since these will be used outside of ANGLE functionality.
Remove USE(ANGLE) && USE(NICOSIA) guards from GBMDevice files.
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- platform/graphics/gbm/GBMDevice.cpp:
- platform/graphics/gbm/GBMDevice.h:
- 5:26 AM Changeset in webkit [290505] by
-
- 16 edits4 copies3 adds in trunk
REGRESSION(r289580): [ iOS macOS ] TestWebKitAPI.IPCTestingAPI.CanReceiveSharedMemory is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=236744
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-25
Reviewed by Antti Koivisto.
Source/WebKit:
Add new tester interface for testing IPC stream features.
Before, TestWebKitAPI.IPCTestingAPI.CanReceiveSharedMemory would test the feature of
"can reply stream sync message with shared memory" by using a RemoteRenderingBackend
message that did so. However, when the RemoteRenderingBackend was changed to use a
different stategy, this test stopped working without compile failure. The IPC testing
is currently done at JS level.
After, the new dedicated testing interface IPCStreamTester has dedicated message for
testing this feature. The test is moved to LayoutTests/ipc and made so that
it tests the feature in all currently testable processes WP uses (GPU, Networking, UI).
IPCTestingAPI is amended to return the all possible testable process names, so
the .html test can work even when ENABLE(GPU_PROCESS) is toggled.
The .html test also passes when !ENABLE(IPC_TESTING_API). Currently
ENABLE_IPC_TESTING_API == (ASAN_ENABLED !defined(NDEBUG)) && PLATFORM(COCOA) E.g. test tests something on Release+ASAN or Debug.
Having the test in .html also makes it possible to run the test on iOS devices.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
- Shared/IPCStreamTester.cpp: Added.
(WebKit::IPCStreamTester::create):
(WebKit::IPCStreamTester::IPCStreamTester):
(WebKit::IPCStreamTester::initialize):
(WebKit::IPCStreamTester::stopListeningForIPC):
(WebKit::IPCStreamTester::syncMessageReturningSharedMemory1):
- Shared/IPCStreamTester.h: Copied from Source/WebKit/Shared/IPCTester.h.
- Shared/IPCStreamTester.messages.in: Copied from Source/WebKit/Shared/IPCTester.messages.in.
- Shared/IPCStreamTesterIdentifier.h: Copied from Source/WebKit/Shared/IPCTester.h.
- Shared/IPCStreamTesterProxy.messages.in: Copied from Source/WebKit/Shared/IPCTester.messages.in.
- Shared/IPCTester.cpp:
(WebKit::IPCTester::createStreamTester):
(WebKit::IPCTester::releaseStreamTester):
- Shared/IPCTester.h:
- Shared/IPCTester.messages.in:
- Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPC::staticValues):
(WebKit::IPCTestingAPI::processTargetFromArgument):
(WebKit::IPCTestingAPI::JSIPC::processTargets):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
LayoutTests:
- ipc/stream-sync-reply-shared-memory-expected.txt: Added.
- ipc/stream-sync-reply-shared-memory.html: Added.
- 1:50 AM Changeset in webkit [290504] by
-
- 1 copy in releases/WebKitGTK/webkit-2.35.90
WebKitGTK 2.35.90
- 1:50 AM Changeset in webkit [290503] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.90 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.35.90.
- 1:17 AM Changeset in webkit [290502] by
-
- 11 edits in trunk
AX: List item marker not exposed when not a direct child of a list item
https://bugs.webkit.org/show_bug.cgi?id=236777
<rdar://problem/89082485>
Reviewed by Adrian Perez de Castro.
Source/WebCore:
It can happen that the marker is not a direct child of a list item, in which case the marker is ignored and not
exposed to ATs.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const): In case of list marker find the marker list item.
(WebCore::AccessibilityRenderObject::markerRenderer const): Helper to return the list item marker renderer.
(WebCore::AccessibilityRenderObject::addListItemMarker): Add always the list item marker as the first child of
list items.
(WebCore::AccessibilityRenderObject::addChildren): Do not add list item marker children, they will be added to
the right parent in addListItemMarker().
- accessibility/AccessibilityRenderObject.h:
Tools:
- WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::roleValueToString): Return AXStatic for Text role too.
LayoutTests:
Update test results.
- accessibility/gtk/list-items-always-exposed-expected.txt:
- accessibility/gtk/list-items-always-exposed.html:
- accessibility/gtk/spans-expected.txt:
- accessibility/gtk/spans.html:
- platform/gtk/TestExpectations:
- 12:51 AM Changeset in webkit [290501] by
-
- 14 edits in trunk/Source
Optimize black frame sending in MediaRecorderPrivate
https://bugs.webkit.org/show_bug.cgi?id=237027
Reviewed by Kimmo Kinnunen.
Source/WebCore:
Allow generating black frames as IOSurfaces.
Covered by existing tests.
- platform/graphics/cv/CVUtilities.h:
- platform/graphics/cv/CVUtilities.mm:
Source/WebKit:
Add support for sending black frames through SharedVideoFrame.
In that case, we only send width and height and we reconstruct a black frame on receiver side.
Make use of SharedVideoFrame in RemoteMediaRecorder.
Set ownership in SharedVideoFrame to the corresponding WebProcess.
Covered by existing tests, in particular http/wpt/mediarecorder/mute-tracks.html.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
- WebProcess/GPU/webrtc/MediaRecorderPrivate.h:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
- 12:28 AM WebKitGTK/2.36.x edited by
- (diff)
- 12:26 AM Changeset in webkit [290500] by
-
- 2 edits in trunk
Unreviewed. [GTK] Bump version numbers
- Source/cmake/OptionsGTK.cmake:
- 12:21 AM Changeset in webkit [290499] by
-
- 5 edits in releases/WebKitGTK/webkit-2.36
Merge r290375 - [GStreamer] De-initialize GStreamer before terminating WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237084
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-23
Reviewed by Carlos Garcia Campos.
Source/WebKit:
Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
exits too early, the leak tracer reporting will be interrupted potentially too early. The
workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
handling and leak tracing was done and keeping the second tab open.
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):
Tools:
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
to store paths.
- 12:19 AM Changeset in webkit [290498] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r290341 - CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=237002
Reviewed by Darin Adler.
Store URLs in the HashMaps instead of Strings since we have URLs initially and we
need URLs eventually. This avoids having to re-parse the URL unnecessarily, which
is fairly expensive.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::CachedResourceLoader::notifyFinished):
- loader/cache/CachedResourceLoader.h:
- 12:16 AM Changeset in webkit [290497] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r290338 - PingLoader is failing to call completion handler in error case
https://bugs.webkit.org/show_bug.cgi?id=237062
<rdar://50157253>
Reviewed by Chris Dumez.
The completion handler was not being called in the case of a PingLoad being redirected to
a non-HTTP(S) scheme.
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):
- 12:12 AM Changeset in webkit [290496] by
-
- 2 edits in trunk/Source/WebKit
Remove dead code in GPUProcessConnection::dispatchMessage
https://bugs.webkit.org/show_bug.cgi?id=237135
Reviewed by Kimmo Kinnunen.
No change of behavior.
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::dispatchMessage):
- 12:08 AM Changeset in webkit [290495] by
-
- 43 edits3 adds4 deletes in trunk/LayoutTests
[GLIB] Update test baselines after various LFC improvements.
https://bugs.webkit.org/show_bug.cgi?id=237184
Unreviewed test gardening.
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-02-25
- platform/glib/fast/backgrounds/background-leakage-transforms-expected.txt:
- platform/glib/fast/backgrounds/border-radius-split-background-expected.txt:
- platform/glib/fast/backgrounds/border-radius-split-background-image-expected.txt:
- platform/glib/fast/block/positioning/auto/vertical-lr/001-expected.txt:
- platform/glib/fast/block/positioning/auto/vertical-lr/002-expected.txt:
- platform/glib/fast/block/positioning/auto/vertical-lr/003-expected.txt:
- platform/glib/fast/block/positioning/auto/vertical-lr/004-expected.txt:
- platform/glib/fast/block/positioning/auto/vertical-lr/006-expected.txt:
- platform/glib/fast/block/positioning/vertical-lr/002-expected.txt:
- platform/glib/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt:
- platform/glib/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt:
- platform/glib/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
- platform/glib/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt:
- platform/glib/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/glib/fast/writing-mode/basic-vertical-line-expected.txt:
- platform/glib/fast/writing-mode/border-image-vertical-lr-expected.txt:
- platform/glib/fast/writing-mode/border-radius-clipping-vertical-lr-expected.txt:
- platform/glib/fast/writing-mode/border-styles-vertical-lr-expected.txt:
- platform/glib/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt:
- platform/glib/fast/writing-mode/border-styles-vertical-rl-expected.txt:
- platform/glib/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt:
- platform/glib/fast/writing-mode/border-vertical-lr-expected.txt:
- platform/glib/fast/writing-mode/box-shadow-vertical-lr-expected.txt:
- platform/glib/fast/writing-mode/japanese-lr-text-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt: Added.
- platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
- platform/gtk/fast/html/details-writing-mode-expected.txt:
- platform/gtk/fast/html/details-writing-mode-mixed-expected.txt:
- platform/gtk/fast/lists/003-vertical-expected.txt:
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt:
- platform/gtk/fast/writing-mode/english-lr-text-expected.txt:
- platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/gtk/fast/writing-mode/vertical-lr-replaced-selection-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt: Removed.
- platform/wpe/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
- platform/wpe/fast/html/details-writing-mode-expected.txt:
- platform/wpe/fast/html/details-writing-mode-mixed-expected.txt:
- platform/wpe/fast/lists/003-vertical-expected.txt:
- platform/wpe/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/wpe/fast/text/international/synthesized-italic-vertical-latin-expected.txt:
- platform/wpe/fast/writing-mode/english-lr-text-expected.txt:
- platform/wpe/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/wpe/fast/writing-mode/vertical-lr-replaced-selection-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt: Removed.
- 12:05 AM WebKitGTK/2.36.x edited by
- (diff)
- 12:03 AM Changeset in webkit [290494] by
-
- 2 edits in trunk/Source/WebKit
Make RemoteVideoFrameIdentifier a regular ObjectIdentifier
https://bugs.webkit.org/show_bug.cgi?id=237136
Reviewed by Kimmo Kinnunen.
Given all RemoteVideoFrames are created in GPUProcess, we no longer need to use a ProcessQualified identifier.
Covered by existing tests.
- WebProcess/GPU/media/RemoteVideoFrameIdentifier.h:
Feb 24, 2022:
- 9:10 PM Changeset in webkit [290493] by
-
- 4 edits in trunk
Unreviewed, reverting r290371.
Caused assertion
Reverted changeset:
"Call WKNavigationDelegate.didFailProvisionalNavigation even
after a cross-origin navigation with COOP"
https://bugs.webkit.org/show_bug.cgi?id=237071
https://commits.webkit.org/r290371
- 8:56 PM Changeset in webkit [290492] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening after r290454.
- TestExpectations: Progressions.
- 7:10 PM Changeset in webkit [290491] by
-
- 3 edits in trunk/Source/WebCore
Simplify grid RTL handling
https://bugs.webkit.org/show_bug.cgi?id=236694
Reviewed by Dean Jackson.
The previous code stored columns in logical order (column 0 is the rightmost physical column), but the positions were offset
using the physical left border, padding and content distribution offset. This hybrid physical/logical coordinate space
made for tricky conversions into the final coordinate space.
This changes the stored column positions to use purely logical coordinates, and does a single direction swap (by subtracting
from the width) at the end.
No tests added, this refactoring is covered by a large number of existing WPTs.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::resolveAutoStartGridPosition const):
(WebCore::RenderGrid::resolveAutoEndGridPosition const):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::RenderGrid::logicalOffsetForOutOfFlowChild const):
(WebCore::RenderGrid::gridAreaPositionForOutOfFlowChild const):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
(WebCore::RenderGrid::translateRTLCoordinate const):
(WebCore::RenderGrid::logicalOffsetForChild const):
(WebCore::RenderGrid::translateOutOfFlowRTLCoordinate const): Deleted.
- rendering/RenderGrid.h:
- 6:38 PM Changeset in webkit [290490] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] editing/pasteboard/dom-paste/dom-paste-same-origin.html is a flaky timeout/failure
https://bugs.webkit.org/show_bug.cgi?id=237174
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-24
- platform/ios/TestExpectations:
- 6:25 PM Changeset in webkit [290489] by
-
- 1 copy in tags/Safari-614.1.5.4
Tag Safari-614.1.5.4.
- 6:22 PM Changeset in webkit [290488] by
-
- 3 edits in branches/safari-614.1.5-branch/Source/WebKit
Cherry-pick r290288. rdar://problem/89062166
Allow adattributiond to start on iOS devices
https://bugs.webkit.org/show_bug.cgi?id=237009
<rdar://89062166>
Reviewed by Per Arne Vollan.
There were three more problems preventing it from starting:
- The code signature said to look for a sandbox profile with "webkit" in the name, but the profile had "WebKit" in the name. These names are case sensitive.
- The sandbox profile would not let it load the WebKit framework, so dyld would fail and the process would fail to launch. I added the framework directories that the XPC services are allowed to access.
- Once it started, it would crash inside WTF::initializeMainThread when calling WTF::pageSize which requires access to the hw.pagesize_compat syscall. As a starting point, I'm going to allow all the syscalls that the network process currently has access to, which is enough to get it to respond without crashing.
- We need access to com.apple.diagnosticd and com.apple.analyticsd in order to be able to generate crash reports. This is quite useful. Yes, I know I said there were only three problems, but the 4th is so useful I thought I'd put it in the list.
- Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:
- Scripts/process-entitlements.sh:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:21 PM Changeset in webkit [290487] by
-
- 1 delete in tags/Safari-614.1.5.4
Remove tag.
- 6:04 PM Changeset in webkit [290486] by
-
- 2 edits in trunk/LayoutTests
[ BigSur+ EWS ] imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-twice.html is a flaky ASSERTION FAILED / failure
https://bugs.webkit.org/show_bug.cgi?id=237172
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-24
- platform/mac/TestExpectations:
- 5:59 PM Changeset in webkit [290485] by
-
- 1 copy in tags/Safari-613.1.17.0.7
Tag Safari-613.1.17.0.7.
- 5:52 PM Changeset in webkit [290484] by
-
- 1 copy in tags/Safari-614.1.5.4
Tag Safari-614.1.5.4.
- 5:46 PM Changeset in webkit [290483] by
-
- 7 edits1 add in branches/safari-614.1.5-branch
Cherry-pick r290442. rdar://problem/89345853
[MacCatalyst] REGRESSION(r290091): sometimes can crash if
WKWebViewis deallocated before the next visible content rect update
https://bugs.webkit.org/show_bug.cgi?id=237126
<rdar://problem/89345853>
Reviewed by Tim Horton.
Source/WebKit:
Tests: WKWebViewResize.DoesNotAssertInDeallocAfterChangingFrame
WKWebViewResize.DoesNotAssertInDeallocAfterChangingBounds
- UIProcess/API/ios/WKWebViewIOS.h:
- UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _acquireResizeAssertionForReason:]): (-[WKWebView _invalidateResizeAssertions]): Added.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView dealloc]):
Make sure to
-invalidateany remaining assertions in-deallocas required by_UIInvalidatable.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewResize.mm: Added. (TEST.WKWebViewResize.DoesNotAssertInDeallocAfterChangingFrame): (TEST.WKWebViewResize.DoesNotAssertInDeallocAfterChangingBounds):
- TestWebKitAPI/SourcesCocoa.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:44 PM Changeset in webkit [290482] by
-
- 4 edits in trunk/Source/WebKit
Port CaptivePortalMode preferences to AnyHost in order to support CFPrefs Direct Mode propagation
https://bugs.webkit.org/show_bug.cgi?id=237098
Patch by Gavin Phillips <gavin.p@apple.com> on 2022-02-24
Reviewed by Brent Fulgham.
Move our CaptivePortalMode preference to AnyHost in order to correctly support
CFPrefs Direct Mode propagation. We also now dispatch a CFNotification to ensure our preference
observer is always notified of the change.
- UIProcess/Cocoa/PreferenceObserver.mm:
(-[WKUserDefaults findPreferenceChangesAndNotifyForKeys:toValuesForKeys:]):
- Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::setPreferenceValue):
- UIProcess/API/Cocoa/_WKSystemPreferences.mm:
(+[_WKSystemPreferences isCaptivePortalModeEnabled]):
(+[_WKSystemPreferences setCaptivePortalModeEnabled:]):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::captivePortalModeConfigUpdateCallback):
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
- UIProcess/WebProcessPool.h:
- 5:43 PM Changeset in webkit [290481] by
-
- 11 edits in trunk
[iOS] Add support for replacing WKFoundTextRanges
https://bugs.webkit.org/show_bug.cgi?id=237151
rdar://89258687
Reviewed by Wenson Hsieh.
Source/WebKit:
Implement protocol methods to support replacement.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::replaceFoundTextRangeWithString):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView replaceFoundTextInRange:inDocument:withText:]):
(-[WKContentView supportsTextReplacement]):
Restrict replacement to editable web views.
- WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::replaceFoundTextRangeWithString):
Use a
TemporarySelectionChangeto select and replace the desired range.
- WebProcess/WebPage/WebFoundTextRangeController.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::replaceFoundTextRangeWithString):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Add a test that replaces found ranges.
- TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST):
- 5:42 PM Changeset in webkit [290480] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.4
- 5:41 PM Changeset in webkit [290479] by
-
- 487 edits1 copy3 moves17 adds18 deletes in trunk/Source/ThirdParty/ANGLE
Roll ANGLE to Feb 18 2022 (78c64dd74ee5)
https://bugs.webkit.org/show_bug.cgi?id=235746
Reviewed by Dean Jackson.
The changelog has been rewritten to avoid
confusion. The following commits are integrated in this
roll:
78c64dd74 Roll SwiftShader from 13f7365e81be to b4a56a893496 (11 revisions)
00c4dc93a Python3: Update generate_test_spec_json.py
d98f4812c FrameCapture: Capture empty buffer generation.
7a4fd4212 Roll Chromium from d984ec3b132a to 6594a8d1e6cf (1749 revisions)
b1bdce5f2 Roll VK-GL-CTS from 834c2e16ae1c to d321c7ec84de (7 revisions)
f996d4d87 Vulkan: Fix DynamicBuffer cache reuse.
8dc9e83e3 Translator: Fix RunAtTheEndOfShader w.r.t discard
00169174c gl.xml: Remove GL_BLEND_EQUATION_EXT from GetPName.
8ade4c2f7 Vulkan: Add overlay and stats for descriptor set caches.
671fcf732 Vulkan: Add a feature to retain SPIR-V debug info
1315bc816 Vulkan: Refactor DynamicBuffer::allocate.
8d966f7dd Vulkan: Simplify SubAllocation data types.
57b8b9332 Roll vulkan-deps from 9fb91023eb58 to 4d9fe6bf1f0c (8 revisions)
ae9c94f1b Add instructions to build RenderDoc for Android on Windows
38723c28c Vulkan: Allocate space for default attrib only if it is enabled
ad462491f Refine suppression for GLSLTest.SwizzledChainedAssignIncrement.
8cb586671 Vulkan: Add uniform descriptor set caching test.
bfbe86613 Fix UpdateChromeANGLE on mac for debug angle
a0d558f09 Vulkan: Fix D/S invalidation for MSAA EGL configs
3b8910625 Roll Chromium DEPS manually.
fb6303a15 Update docs for checkout with 'fetch' tool.
afacf7f99 Roll vulkan-deps from 956ca5369840 to 9fb91023eb58 (10 revisions)
2893effa4 validationESEXT: Implement ValidateGetCompressedTexImageANGLE.
b1075951d vk_helpers: Adjust CopyImageToBuffer extent to block size.
d77f64b35 Roll SwiftShader from 5f1c00bda1c1 to 13f7365e81be (5 revisions)
bdedf146d TextureVk: Implement getCompressedTexImage.
5f3f13f69 Vulkan: Invalidate D/S for multisampled EGL configs too
eeddb0504 Metal: Incorrect parenthization for assignment expressions
ed39d49a2 Metal: Fix Hang in WebGL CTS Occlusionquery_strict test
760253ce2 Vulkan: replace uniforms FastIntegerMap with FastUnorderedMap
931863370 Vulkan: Check Serial is valid in SyncHelperNativeFence
904a47975 Python3 upgrades
c590a1aa9 Roll VK-GL-CTS from 2d1377ec02b5 to 834c2e16ae1c (1 revision)
3adace153 Don't expose detailed driver version info to webGL
255fec892 Remove reference to policy_testserver.py
e2f8ff32c Tests: Add State of Survival trace
a5badc3ef [infra] Update active lucicfg experiments.
cf4b50c5b Vulkan: Retain images before changeLayoutAndQueue
3b8b1f709 Roll SwiftShader from cbd31d271e4c to 5f1c00bda1c1 (12 revisions)
f3b6af597 Roll vulkan-deps from 3a6f074dbd38 to 956ca5369840 (55 revisions)
ad4fae642 Roll Chromium from c9825531290b to d984ec3b132a (580 revisions)
e50455877 Debug Overlay Demo
527ceb73c Vulkan: Switch XFB counter buffer to suballocation
a0bc9dab4 Vulkan: Switch stencilBlitResolveNoShaderExport to suballocation
d36df8d73 Unicode support for system_utils on Windows
54d428dd5 Tests: Add MARVEL Strike Force trace
1e29ba626 Vulkan: Enable overlay by default with debug layers
19f405318 Vulkan: Enable subgroup feature in GenerateMipmap.comp
2efbfd058 Roll VK-GL-CTS from 071bfca11aa9 to 2d1377ec02b5 (11 revisions)
c6f5a5bbe Roll Chromium from c0b2804cbd93 to c9825531290b (658 revisions)
06edae72b Vulkan: Allow duplicated block name in different shader interface
6cced91b3 FrameCapture: Remove destroyed contexts from share group
f7f269560 Vulkan: Fix two bugs exposed by moving mEmptyBuffer to suballocation
9b7a77b08 Double batch timeout for sanitizer tests.
4b45576d4 Keep ANGLE_base_vertex_base_instance available for ES 2.0
d285d6a72 Vulkan: Use VK_EXT_depth_clip_control
3f0a28ba6 Add entry points for EGL_KHR_partial_update
3b4548bb6 Traces: Add restricted_trace_perf.py script for Android
a3c785fc1 GL: Remove avoid_dxt1_srgb_texture_format feature
fd378ce5a Rebind program on glUseProgramStages
3a72994ea Vulkan: Add an end2end test
0a320d16f GetImageTest: Enable on Vulkan SwiftShader.
568724918 Roll Chromium from bf99b2cc0f6b to c0b2804cbd93 (526 revisions)
d5df23318 Vulkan: Disable EGLContextSharingTestNoSyncTextureUploads on Pixel6
038adcae4 Vulkan: Render the overlay in the graphics pipeline
b39add311 Roll VK-GL-CTS from b594e2aabae9 to 071bfca11aa9 (1 revision)
419bca3f5 Vulkan: Use Vulkan API directly for BufferPool's buffer allocation
6fd2588df Update GL_MAX_CLIP_DISTANCES_EXT validation
734365a71 Vulkan: improve command buffer reset performance
118ce6aae Support to open d3d12 shared handles
a0e3a5fb9 Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
f63d5f1c1 Revert "Don't build dEQP tests on MSVC temporarily"
4b6a5a84b Roll Chromium from 60719c9cd084 to bf99b2cc0f6b (543 revisions)
670a6e476 Ignore invalid texture type error
91f92540c Metal: Fix multisample resolves.
823522375 Vulkan: Fix incorrect DescriptorSet's bufferInfo in XFB emulation path
37f59b850 Roll VK-GL-CTS from 97ceb2222747 to b594e2aabae9 (64 revisions)
02ce52d26 Test: Add Lords Mobile trace
33d17b7fc Fix perf test runner script.
4349904b0 Add keying on backend to ANGLE Display caching.
9cfd87244 Allow surface creation in DisplayVkNull
a91d56033 Roll SwiftShader from e576ca6011cd to 0915ab4bddf7 (6 revisions)
4716e0fe8 Roll Chromium from 817a527fde8c to 60719c9cd084 (571 revisions)
71d06198c Vulkan: Fix vkCmdClearAttachments vs multiview
1b9774f57 Vulkan: Force submit updates to immutable textures
a39618436 Vulkan: Bind aligned default uniform buffer size.
6207fe88d Vulkan: Minor cleanup to DynamicDescriptorPool.
5b43a30e3 Overlay: Rearrange the font image
70c510eb2 Vulkan: Use common storage for descriptor set descs.
50fb842d5 Expand SwiftShader Win/ASAN suppression.
520458769 Vulkan: StreamVertexDataWithDivisor write beyond buffer boundary
d635feb11 [fuchsia] Tests using additional_manifest_fragments are CFv1.
8622810c4 Roll SwiftShader from ad6d7f84f2a1 to e576ca6011cd (19 revisions)
d066f9a34 Roll Chromium from 26dacbf4b527 to 817a527fde8c (500 revisions)
2df2a9ec2 Add instructions to enable Debug Overlay On Android
236a3d0f0 Tests: Add Dead Trigger 2 trace
1acfe6597 Test: Add Last Shelter: Survival trace
8b81742dd Vulkan: Move shader resources descriptor set update.
02ad19e36 Vulkan: Fix vkCmdResolveImage offsets
d9fcebb8a Vulkan: Make framebuffer fetch syncval errors more specific
939da2945 Tests: Add Magic Rush: Heroes trace
9208dcc65 Revert "Vulkan: Enable framebuffer fetch on SwiftShader"
44deda4c2 Tests: Add Dragon Mania Legends trace
959d4be5f Vulkan: Remove buffer get method from descriptors desc.
b2006a222 Roll SwiftShader from 2b76a13c38ae to ad6d7f84f2a1 (1 revision)
06150ab2f Roll Chromium from 55ed02951fa2 to 26dacbf4b527 (583 revisions)
f65e7c3ca Vulkan: Take base level into account in image views
6d30de10d Metal: Fix ANGLEUniformBlock alignment
ac20272f6 Vulkan: Fix present region rectangles
2eeb87488 Vulkan: Enable framebuffer fetch on SwiftShader
2ab8f48fe Allow glCopyTexImage2D from BGRX and RGBX to GL_LUMINANCE
c48e35b94 Add more info in BlitFramebuffer error message
2b00f4f5a Fix bug in protected content validation
706f8a311 Support gl internal format for creating EGLImage from VkImage
da87b1dbc Fix GLES Display creation on ChromeOS when Vulkan is enabled
7820ca23e Vulkan: Binding available buffer range to descriptor.
8710d7fe2 Roll SwiftShader from 6014f10de554 to 2b76a13c38ae (3 revisions)
0aca45c1f Roll Chromium from 8894f7c632dd to 55ed02951fa2 (509 revisions)
1608a9567 Vulkan: Revert client vertex data streaming to use DynamicBuffer
9e3232998 FrameCapture: Regen framebuffers on Reset
e897bf9ae Remove gl_PerVertex-related suppression
3dbba51df Reland "Vulkan: Enable ANGLE_texture_multisample"
83a3f654a Revert "Suppress GLSLTest.FramebufferFetch... on Pixel6 / Vk / Glslang"
4ac0f1436 Vulkan: Fix gl_LastFragData transformation
f1159253d Expand suppression of Mimap tests to any Win/Swiftshader config.
e56f0e293 Vulkan: Check program fetch status when switching framebuffers
600ffa6ec Suppress GLSLTest.FramebufferFetch... on Pixel6 / Vk / Glslang
4a65040b6 Add new Vulkan uniform update test.
464396c7b Roll vulkan-deps from fe093f4789c2 to 3a6f074dbd38 (8 revisions)
4c9f4519b Roll SwiftShader from 4998c7b3a2b8 to 6014f10de554 (6 revisions)
6e7a7a03e Roll Chromium from a210f891a450 to 8894f7c632dd (1053 revisions)
b756b2c27 Suppress flaky Mipmap/Multithreading tests on Win/SwS/ASAN
812d5fffa Metal: End the current render pass at glInvalidateFramebuffer.
7d7cca47f Vulkan: Update default FBO when fetch in use
25120c560 Mac: Try to diagnose crashes inside Core Animation.
139f4bd46 Revert "Vulkan: Enable ANGLE_texture_multisample"
494887100 Metal: Remove emulatedInstanceID
57933493d Roll vulkan-deps from 9ee740d2e9ef to fe093f4789c2 (5 revisions)
72529c197 Vulkan: Fix a few framebuffer fetch bugs
fe56532f5 Vulkan: Enable ANGLE_texture_multisample
bc3be5a83 Vulkan: Add a dedicated suballocation garbage list
be2da2343 Vulkan: Initialize exectuable with invalid uniform serial.
33427a4b3 Vulkan: Fix vkCmdResolveImage extents
293c0b516 Vulkan: Cache commonly used 6 ushorts stream index array data
38fada351 Vulkan: Add support for OES_primitive_bounding_box
91b383e82 Translator: Emit warning when identifier has double underscores
945a09d10 Vulkan: Fix off-by-one in DynamicBuffer.
d6fb76a68 [fuchsia] Don't try to use calling executable path to load .so's
868c0739f Vulkan: Fix image base/max level respecification case.
0a6c4310e Vulkan: Fix incorrect gl_SamplePosition on ES3.2
693b48a07 Roll SwiftShader from 4db20a80409b to 4998c7b3a2b8 (1 revision)
d1b1ef9af Roll vulkan-deps from 69f4b9c09e48 to 9ee740d2e9ef (3 revisions)
3c727e44e Allow GL_RGBX8_ANGLE for texture copy destination
069269540 Roll Chromium from 97a33ab1a078 to a210f891a450 (477 revisions)
f810e9989 Use a temporary timeout multipler for trace tests.
508a8a027 Remove old spellings for SYNC-HAZARD-WRITE_AFTER_READ skips
2d3ce72d1 Refactor shared library load to avoid allocations.
665ddccd8 Vulkan: Emulate dithering
29d087df4 Fix ANGLE_rgbx_internal_format's extension file name
471f18521 D3D11: Fix underflow with computing small strides.
84470eb3d Roll SwiftShader from 518c5780ac4f to 4db20a80409b (3 revisions)
b934fad92 Roll Chromium from 4d71de73b37d to 97a33ab1a078 (625 revisions)
a4a4fec8b Roll vulkan-deps from f703f3cc0975 to 69f4b9c09e48 (10 revisions)
69263b388 Roll vulkan-deps from 746e518a0b0e to f703f3cc0975 (1 revision)
55ef2b4f7 Update one more SYNC-HAZARD-WRITE_AFTER_READ skip
168e0ae50 Vulkan: Refactor descriptor pool code.
a994ea994 Update SYNC-HAZARD-WRITE_AFTER_READ skip
e03f17535 EGL: mutable_render_buffer deferredFlush fix
e27bb3972 Roll vulkan-deps from a19b5047ffca to 746e518a0b0e (5 revisions)
8a1f8af4d Turn on the Vulkan backend on ChromeOS
9bf5716c8 Tests: Add War Planet Online trace.
287057b3b FrameCapture: Don't track coherent buffers before capture starts.
42c8b29d0 Tests: Add Dead By Daylight trace.
46b420f66 Roll SwiftShader from bca23447ad46 to 518c5780ac4f (7 revisions)
078f7ea06 Roll Chromium from 8ff0cb4f71d8 to 4d71de73b37d (550 revisions)
c4a9d4169 Metal: Refactor to build without SPIR-V
701d51b10 Vulkan: Add SmallBufferPool for small allocations
66e01ae5a Expand error message on BindTexture validation failure
706e44b06 Tests: Add PUBG Mobile launch trace
df19e35a0 Vulkan: Use queue for mGarbageQueue
4e644b330 Vulkan: Remove ProgramExecutableVk back-pointers.
b3ed47809 Change Windows display initialization from ANSI to wide version
602b957b8 Enable robustnessEXT for SwiftShader.
8b966cfc5 Roll vulkan-deps from ae6a4b829252 to a19b5047ffca (9 revisions)
322d118fc Roll SwiftShader from 711968667748 to bca23447ad46 (4 revisions)
47d63b4e3 Roll Chromium from 7b890e4b915b to 8ff0cb4f71d8 (485 revisions)
2ad5f350c Vulkan: Fix texture array level redefinition
45237a047 Metal: Fix undefined behavior of depth write
aadc64343 Vulkan: Fix to correctly redefine gl_PerVertex in GS
25e8f02b0 [infra] Use python3 for run_presubmit recipe.
a79708899 Vulkan: Use queue instead of vector for mSharedGarbageList
39f66a9c1 Vulkan: Support different SCBs for outside and inside RP
cb96c236a Revert "Vulkan: Enable framebuffer fetch on SwiftShader."
7c1346bdc Vulkan: Consolidate uniforms code in ProgramExecutableVk.
b2d55742b Program: Add generic uniform update methods.
374e0c439 ProgramPipeline: Remove mHas members.
0dc0dc2a4 Re-land: "Vulkan: Remove "fillProgramStateMap"."
510723193 Vulkan: Enable framebuffer fetch on SwiftShader.
1316d1534 Roll vulkan-deps from 4ec99dddf407 to ae6a4b829252 (11 revisions)
f44159cdb Roll SwiftShader from 366db5aedd90 to 711968667748 (8 revisions)
83ca1fbc5 Roll Chromium from 94c8695167c4 to 7b890e4b915b (100 revisions)
54f8a8f71 Roll Chromium from 35ed79e6a83b to 94c8695167c4 (935 revisions)
aaac31b48 Unskip dEQP.GLES3/functional_shaders_operator_unary_operator_minus_*
c5498b957 FrameCapture: Reset immutable buffers correctly.
8474c8e1c FrameCapture: Add Renderbuffers to mStartingResources.
5f0badf45 Vulkan: Prevent out of bounds read in divisor emulation path.
526c93ddf FrameCapture: Detect GL_MAP_COHERENT_BIT_EXT correctly.
f5dc2a951 Roll vulkan-deps from 238eaa6f9d25 to 4ec99dddf407 (7 revisions)
8fc4d3b1e Roll SwiftShader from e823eef17385 to 366db5aedd90 (2 revisions)
d7585c22a Capture/Replay: don't capture MS depth renderbuffer pixels
d6dd0cb52 EGL: EGL_KHR_lock_surface3 backend
6a14e328b Revert "Vulkan: Remove "fillProgramStateMap"."
bd87cc1ca Skip flaky CopyTextureTest.CopyOutsideMipmap
c7f31b8ae Expand TransformFeedbackTest.SpanMultipleRenderPasses suppression
296783294 Vulkan: Fix advertised precision ranges
38deffe40 Vulkan: Remove "fillProgramStateMap".
540b2e46a Fix MultithreadingTestES3.MultithreadFenceDraw skip on SwiftShader
73c823108 Update the Capture and Replay docs
85e2991f2 Fix couple LSAN detected leaks in unit and end2end tests
adb802383 On invalidate, only sync the relevant framebuffer binding
a20cd8b73 Fix initialization for ETC2 punchthrough alpha formats
cac4e54a6 Mark GL_RGBX8_ANGLE format as filterable.
64c49da36 Roll Chromium from b7f974a39665 to 35ed79e6a83b (570 revisions)
096c268bd Add a few overrides for Samsung
339a6d181 Roll vulkan-deps from c9b583de6eb8 to 238eaa6f9d25 (8 revisions)
0f00fbae2 Translator: Make vec/matrix size getters unsigned
ca3b28b4b Metal: Fix compressed texture initialization and add DXT1 test
4a5a559d6 Update Metal/iOS status from "planned" to "in progress".
a0fbcb375 Vulkan: Remove flush from SyncHelperNativeFence::serverWait
038d28772 Roll VK-GL-CTS from bfede065f419 to 97ceb2222747 (3 revisions)
29e254689 Account for EGL 1.5 version when dealing with robustness
78d482e56 Add standalone ANGLE Pixel 6 experimental bots
a5e22715e Vulkan: Fixed TC shader and gl_PerVertex block interaction
a64d52fd2 Add ANGLE_FORMAT_PRINTF() for catching format errors
31bb03fe2 Add more tests for program pipelines.
e6ed6977c Roll SwiftShader from 2e74d5dc03df to e823eef17385 (4 revisions)
a4b312c01 Roll vulkan-deps from 70b3eb7a5ab4 to c9b583de6eb8 (1 revision)
515f60bd6 FrameCapture: Keep MEC Setup resources in Reset.
034b50587 Roll Chromium from d5bf6f7f9376 to b7f974a39665 (478 revisions)
1ab6c9f69 Hide ES 3.0+ extensions from ES 2.0 clients
2caa9d4fe Vulkan: Add missing glGetProgramPipelineiv parameters handling
d23549689 Vulkan: Rename BufferHelper::initFor* to allocateFor*
a83f7e91c Vulkan: inline some of the BufferSuballocation APIs
1b5efe51a Vulkan: Rename SubAllocation to Suballocation
659725aaa Metal: Cleanup texture caps init
3064920a9 Capture/Replay: Serialize ActiveTexturesCache.
161643215 Roll vulkan-deps from d1b842fca80d to 70b3eb7a5ab4 (4 revisions)
7ff95f28d Roll Chromium from b24759852b71 to d5bf6f7f9376 (533 revisions)
1bd1a3db1 Metal: Canvas resizing causes webpage to run out of memory
15439f8e4 Vulkan: Remove BufferMemoryAllocator
dcac02ac1 Revert "Enable robustnessEXT for SwiftShader."
ef3fffd6f Fix running tests with empty test set.
e5c9b3859 Add object label in glBindTexture() error message
b53607981 Vulkan: Support fetching from default FBO
ff5368cd2 Mark a context as shared if using global textures/semaphores
fc6b747df EGL: Fallback to native device if no display available
55d127703 Metal: Cleanup autogenerated format table
cb7ff65c1 Roll SwiftShader from f6bdbed95b37 to 2e74d5dc03df (7 revisions)
eda5aa0be Roll vulkan-deps from 4cda77455291 to d1b842fca80d (6 revisions)
17f912bd6 Roll Chromium from 8cf5fa683fa3 to b24759852b71 (537 revisions)
00a2a2f3e Merge metal format table updates from Webkit
af8dd1c38 Update documentation link
f071aaaf3 Use first test name instead of shard index for TestArtifacts
7dda50fc0 Add frontend for ANDROID_extension_pack_es31a
28f223acb Vulkan: Add missing ESSL 3.2 builtin functions
400175d8e Copy shader buffers into pipeline executables.
892511fc3 Isolate LinkValidateProgramInterfaceBlocks.
fdadc420a Fix non-bot mode sharding on Android and disable elsewhere.
fa3241b70 Vulkan: Move shader_framebuffer_fetch to FeaturesVk
9012c1288 Add Microsoft vendor Id parsing to SystemInfo
453cd955a Add EGL_ANGLE_platform_angle_display_id to D3D11 backend.
a1858b024 Tests: Add Respawnables trace.
b803b60df Enable robustnessEXT for SwiftShader.
31942507f Fix export_targets Windows presubmit with Vulkan Loader.
8eafe4912 Roll SwiftShader from d7117384b0ee to f6bdbed95b37 (1 revision)
c31e14d9c Roll vulkan-deps from d891854a594a to 4cda77455291 (30 revisions)
4572a1764 Add support for GL_MESA_framebuffer_flip_y 3/*
a76550078 Roll Chromium from 86a4c63b080e to 8cf5fa683fa3 (329 revisions)
9b231f090 Vulkan: Fix incorrect bit test when mipmapping
158ecba6a Vulkan: Remove cached Impl pointers from ContextVk.
5adee9161 Wrap some global vulkan methods which depend on env variables
652e3db46 use vpython3 in run_gtest_angle_test.py
770c81b91 Roll SwiftShader from cd848cd695a4 to d7117384b0ee (2 revisions)
9cfb4dd91 Roll Chromium from c00f3886d7aa to 86a4c63b080e (890 revisions)
0aae0d7ad Update PrintSystemInfo with missing fields.
6601b8d2e Vulkan: Fix storage buffer limits on geom/tess without Vulkan support
c4c73e827 Fix RobustBufferAccessBehaviourTest.
30254d349 Ignore VUID-RuntimeSpirv-NonWritable-06341 warning
158d47831 Vulkan: Suppress VVL message about allocation exceeding heap size
28f05f41e Capture/Replay: Add annotation for crashing test
6e2ab29d1 Avoid data race in overflow check.
4f3a50e55 Roll Chromium from 3fcf884156d8 to c00f3886d7aa (595 revisions)
6312da1ab Vulkan: Disable GL_KHR_parallel_shader_compile
9f3c306ec Fix collection of systemDeviceId on Mac/M1
9b1a6d8a4 Vulkan: Invalidate depth/stencil unconditionally
bd64b3eaa Move pipeline uniforms into the executable.
985db6409 Fix test harness config parsing in Compressed Tex tests.
f4b0a95f4 Metal: Implement EXT_shader_texture_lod
814a78af5 Roll Chromium from 3668290e6162 to 3fcf884156d8 (108 revisions)
d4412d0a0 Roll Chromium from 3d4921afbcfd to 3668290e6162 (378 revisions)
2f4f5f8aa Add EGL_ANGLE_platform_angle_device_id for the Metal backend.
0ab15998c Translator: Don't promote precision for assignment operation lvalues
cd157aae5 Revert "Use STL container for vulkan memory allocator"
89467fa56 Roll Chromium from 597c376626be to 3d4921afbcfd (999 revisions)
d4c8209b3 Fix validation of copyImageSubData related to texture completeness
4a819ee26 Update code generation script to work with specified generators
96fd9b72d Fix validation of glCompressedTexImage3D
926b43e75 Reland: Frontend: separate lock in swap prep
2d1051778 Enable a few features for Samsung
345cdcb0f Rename features for consistency.
b0e15ee48 Decide GL_KHR_parallel_shader_compile in backends
a026d0536 Add support for subgroupSize of 16 in Debug Overlay Module
f180ecc96 Supress TransformFeedbackPausedDrawThenResume on Mac AMD
5ec02c8f4 Roll SwiftShader from b57a3aaee927 to cd848cd695a4 (1 revision)
7f8e7c38e Roll vulkan-deps from 328da0f26e8e to d891854a594a (9 revisions)
0b02a592f Metal: Generated Metal shaders do not compile offline
6a2558333 Metal: Fix transform feedback issue
37cde9e99 Update GLES31 expectations file
e38dab0aa Add missing implementation for glGetnUniformuiv()
74e03b9af Expose the registryID of GPUs on Mac via SystemInfo
9d11a341c Vulkan: Fix Vulkan SCB vs multiple subpasses
b90bcb9c8 Roll vulkan-deps from 57e7495dc76d to 328da0f26e8e (4 revisions)
9f1dc3e99 Roll Chromium from b91f3880e3ec to 597c376626be (567 revisions)
acd8fc76b Vulkan: Distinguish RP and outside-RP command buffer types
eea784687 Tests: Add Angry Birds 2 launch trace
095d7c0a0 Translator: Clean up spec const / driver uniform types
5c9bd7bac Update Mac goldctl
4111f9ef1 Add standalone ANGLE Mac AMD experimental bot
9d042d686 Cleanup after iOS build fixes
99b021a15 infra: Add TSAN and UBSAN tests to CQ.
b0feea4e4 Suppress failing test on Vulkan/Intel/Linux.
60a8b5930 Vulkan: Remove std::unique_ptr usage from BufferVk::mBuffer
217dc204e Broaden TSAN EGL multithread suppression.
ae1a56b67 Vulkan: Turn on GL_EXT_shader_framebuffer_fetch for ARM
9d668d6c4 Revert "Frontend: separate lock in swap prep"
b2dac79d9 Fix typo in EGLPrintInfo end2end Test
462cdb08e Capture/Replay: Reset FBOs, RBOs, VAOs
4472b3b0d Fix TSAN suppressions.
40c5cb255 Frontend: separate lock in swap prep
c2a296149 Test Expectations: Use file order as override priority.
ece463808 tests/EGLProtectedContentTest: Add QueryContext test.
1e2856fdc Update freetype-py wheel
a203e1263 Roll SwiftShader from 0b901607cad4 to b57a3aaee927 (1 revision)
8ab13284a Roll vulkan-deps from 09edcd7c680b to 57e7495dc76d (27 revisions)
6f80fa0c3 Roll Chromium from 8712e27d7e28 to b91f3880e3ec (349 revisions)
2ebdd23b6 Cleanup TextureCubeTestES3.CubeMapPixelUnpackBuffer
caf6433ad Vulkan: Rename releaseStagingBuffer to releaseStagedUpdate
93159c020 Vulkan: Remove DynamicShadowBuffer implementation
cf3812921 Revert "Re-skip MSRTT tests on Linux/AMD/Vulkan"
3263eb01f Vulkan: Switch GPU translated vertex buffer to NonHostVisible
8589c456a Vulkan: Remove mStagingBuffer from ImageHelper and ContextVk
6da1ac814 Vulkan: Switch ReadPixels from DynamicBuffer to shared pool
ad27d5d6f Reland "Vulkan: Consolidate all vertex conversion buffers to shared pool"
535a90347 Suppress headers includes privacy checks for iOS executables
a61a7f597 Vulkan: Use correct aspectMask
4e85bdd99 Revert "Vulkan: Consolidate all vertex conversion buffers to shared pool"
cca412cd8 Vulkan: Consolidate all vertex conversion buffers to shared pool
02f6226b7 Avoid using GetCWD() on MacOS when possible
a0d0a1d65 Roll SwiftShader from c73969d73ff9 to 0b901607cad4 (6 revisions)
e98b62727 Roll Chromium from b1dc46c0f1be to 8712e27d7e28 (483 revisions)
fd0142714 Vulkan: Match chromaFilter to min/mag for YUV AHBs
ccabfd140 out\Debug -> out/Debug, like in other places
abf17f018 Metal: Support depth filtering queries for D32, D24S8
f13f440e6 Reland: Metal: Fix Webkit warnings in ANGLE build
39e1a2b2e Suppress Vulkan/SwiftShader/AsyncQueue ASAN flakes.
7126c3a3c Capture/Replay: Limit caps for QC/SwS
0e49a3dd4 Vulkan: Add std::move support for BufferHelper
43b0e92b5 Vulkan: Consolidate mHostVisibleBufferPool and mMapInvalidate
42cb6147f Revert workarounds for exception handler code-gen with CFG enabled
e4c7efeaf Capture/Replay: Fix GN build on iOS.
cabc3b982 Move atomic counter uniform range counter to executable.
e9e9a2c6a Do not pass mInstance to vkGetInstanceProcAddr
beda24596 Add support for GL_MESA_framebuffer_flip_y 2/*
c984dad5f FrameCapture: Don't remove protection from shared pages.
d76515b89 Roll SwiftShader from 433b1bf9bff2 to c73969d73ff9 (4 revisions)
1b2cb4222 Roll Chromium from 1a9dad30c65b to b1dc46c0f1be (497 revisions)
cfc4db346 Metal: Provoking vertex support for Metal DrawArrays
a00b6ca46 Roll Chromium from 04d22dcbc0f6 to 1a9dad30c65b (190 revisions)
5bd459618 Roll Chromium from 70ce2f66c417 to 04d22dcbc0f6 (183 revisions)
aad7ddb28 Skip VulkanPerformanceCounterTest.InvalidateDrawDisable
0a6b78974 Add macOS support to update_chrome_angle.py
4b3e3ed5f Re-skip MSRTT tests on Linux/AMD/Vulkan
39810def0 Roll Chromium from c764378a1f24 to 70ce2f66c417 (145 revisions)
9aca4285f Traces: Fix path in retrace script.
0331738b4 Fix extension download script, and update data.
58aeec65c Capture/Replay: GN cleanups.
85de4f81e Capture/Replay: Fix TODO in test utils.
b6399ac94 Traces: Finish writing restricted trace doc updates.
fed9ba44f Roll vulkan-deps from c32df39c11ce to 09edcd7c680b (1 revision)
65cc408c3 Roll Chromium from e45e6e1a55ae to c764378a1f24 (157 revisions)
a400e76d0 Vulkan: Don't expose MSRTT without VK_KHR_depth_stencil_resolve
9f74ec615 Skip angle_end2end_tests failing on Linux AMD RX 5500 XT
b7d2f4478 Roll Chromium from d09758fa672c to e45e6e1a55ae (153 revisions)
6f1c39b52 Vulkan: Restore color attachment mask-related blend states
95f6e6865 Roll SwiftShader from 87c78ac5eb86 to 433b1bf9bff2 (2 revisions)
a026169c9 Roll Chromium from 0635acc4de22 to d09758fa672c (93 revisions)
0a28c6c61 Capture/Replay: Capture some MultiDrawIndirect parameters
5f53268ce Capture/Replay: Gather Program sources directly from call
a92036893 Roll Chromium from 52c4c43d687f to 0635acc4de22 (149 revisions)
fce481863 Roll SwiftShader from f354daff5a2b to 87c78ac5eb86 (2 revisions)
6c9b79ead Roll Chromium from 16dc16f9ec67 to 52c4c43d687f (244 revisions)
4d893a935 Re-land: "Trace Tests: Remove auto-generated code."
542f7d808 Vulkan: Copy buffer data to correct cube map face
582651bee Roll vulkan-deps from fbeca8f4ea6a to c32df39c11ce (3 revisions)
5e0d97877 Roll Chromium from 274ab850e849 to 16dc16f9ec67 (303 revisions)
2ebd583ed Android: Remove setenv from common path
14af7a8da Log subprocess output in run_perf_tests.py
2f3e6cc07 Vulkan: Remove mShadowBuffer from BufferVk class.
7dfa69e69 Unskip MRTSigned and MRTUnsigned BlendIntegerTest
993f38896 Roll Chromium from 9ca41364d3dc to 274ab850e849 (341 revisions)
0e9353f60 Skip RenderbufferDrawStencilThenUnresolveStencil on Linux Vulkan AMD
bc9d2d7de Vulkan: Consolidate BufferHelper's code paths into one
4114fe23c Vulkan: Simplify transform feedback emulation logic
32d9e186d Roll vulkan-deps from 5568048d205e to fbeca8f4ea6a (4 revisions)
ab288fea5 Upgrade restricted traces. (Re-land)
c1f478fe0 Frame Capture: Allow for no FBO when running MEC.
eba2e620f Capture/Replay: Fix uniform program indexing.
73e764dc6 Suppress capture/replay tests.
1da7e3afb Revert "Metal: Fix Webkit warnings in ANGLE build"
bdaa046fe Roll Chromium from 81decb7250e1 to 9ca41364d3dc (272 revisions)
a7e0d520f Temporarily skip failing tests on Chromium
171bc07e2 Don't silently drop out-of-range bits in BitSetT
eca427b28 Vulkan: Add mutex to protect mVirtualBlock
c1598640b Vulkan: Improve mid-RP clear warning message
4a03668d7 Address comment in CL 3347143
cf8ac00a5 Vulkan: Fix MSRTT w.r.t stencil-only unresolve
c07df6fe8 Disable vulkan device select layer for msan build
- 5:29 PM Changeset in webkit [290478] by
-
- 9 edits in branches/safari-613.1.17.1-branch/Source
Versioning.
WebKit-7613.1.17.1.9
- 4:53 PM Changeset in webkit [290477] by
-
- 4 edits in trunk/Source/WebKit
Take down shared worker context connection less aggressively when it becomes idle
https://bugs.webkit.org/show_bug.cgi?id=237156
Reviewed by Darin Adler.
Take down shared worker context connection less aggressively when it becomes idle. Give it 5
seconds before shutting it down in case it ends up being used again in the near future.
This is similar to what we do for service workers.
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::shutDownSharedWorker):
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
(WebKit::WebSharedWorkerServerToContextConnection::WebSharedWorkerServerToContextConnection):
(WebKit::WebSharedWorkerServerToContextConnection::addSharedWorkerObject):
(WebKit::WebSharedWorkerServerToContextConnection::removeSharedWorkerObject):
(WebKit::WebSharedWorkerServerToContextConnection::idleTerminationTimerFired):
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h:
- 4:53 PM Changeset in webkit [290476] by
-
- 14 edits in trunk/Tools
[Python3] Remove shebangs from webkitpy files
https://bugs.webkit.org/show_bug.cgi?id=237167
<rdar://problem/89444955>
Reviewed by Dewei Zhu.
- Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Remove shebang.
- Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Ditto.
- Tools/Scripts/webkitpy/common/attribute_saver.py: Ditto.
- Tools/Scripts/webkitpy/common/attribute_saver_unittest.py: Ditto.
- Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Ditto.
- Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Ditto.
- Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Ditto.
- Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py: Ditto.
- Tools/Scripts/webkitpy/w3c/test_converter.py: Ditto.
- Tools/Scripts/webkitpy/w3c/test_importer.py: Ditto.
- Tools/Scripts/webkitpy/w3c/test_parser.py: Ditto.
- Tools/Scripts/webkitpy/xcode/sdk.py: Ditto.
- Tools/Scripts/webkitpy/xcode/sdk_unittest.py: Ditto.
Canonical link: https://commits.webkit.org/247774@main
- 4:28 PM Changeset in webkit [290475] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r290358): [ Debug EWS ] ASSERTION FAILED: sample && sample->pixelBuffer()
https://bugs.webkit.org/show_bug.cgi?id=237164
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-24
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 4:17 PM Changeset in webkit [290474] by
-
- 9 edits in branches/safari-613.1.17.0-branch/Source
Versioning.
WebKit-7613.1.17.0.7
- 4:04 PM Changeset in webkit [290473] by
-
- 2 edits in trunk/LayoutTests
[ BigSur+ EWS ] webgl/pending/conformance/textures/misc/tex-image-video-repeated.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=237166
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:44 PM Changeset in webkit [290472] by
-
- 2 edits in trunk/LayoutTests
[ BigSur+ Debug wk2 EWS ] imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/quirks.window.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=237165
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:26 PM Changeset in webkit [290471] by
-
- 4 edits1 delete in trunk/Source/WTF
Unreviewed, reverting r290452.
Caused failues with clean builds
Reverted changeset:
"[XCBuild] WTF's SPI dependencies are copied via a folder
reference and do not emit task outputs"
https://bugs.webkit.org/show_bug.cgi?id=237129
https://commits.webkit.org/r290452
- 3:24 PM Changeset in webkit [290470] by
-
- 87 edits in trunk/Source
Source/WebCore:
[Refactor] Adopt LoggerHelper in Logging EME classes
https://bugs.webkit.org/show_bug.cgi?id=234319
Reviewed by Eric Carlson.
In order to pass down a logger() and logIdentifier() to the platform/
classes, modify LegacyCDMSessionClient to be a CanMakeWeakPtr class,
so it can be passed around by reference and automatically invalidated
when the client is destroyed. Then modify LegacyCDMSessionClient to
provide a logger() and logIdentifier() to callers.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
- Modules/encryptedmedia/CDM.h:
(WebCore::CDM::logIdentifier const):
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::load):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::close):
(WebCore::MediaKeySession::remove):
(WebCore::MediaKeySession::updateKeyStatuses):
(WebCore::MediaKeySession::sessionClosed):
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::setServerCertificate):
- Modules/encryptedmedia/MediaKeys.h:
- Modules/encryptedmedia/legacy/LegacyCDM.cpp:
(WebCore::LegacyCDM::createSession):
- Modules/encryptedmedia/legacy/LegacyCDMPrivate.h:
- Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:
(WebCore::LegacyCDMPrivateClearKey::createSession):
- Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h:
- Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp:
(WebCore::CDMPrivateMediaPlayer::createSession):
- Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h:
- Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::CDMSessionClearKey):
- Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:
- Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
(WebCore::WebKitMediaKeySession::create):
(WebCore::WebKitMediaKeySession::WebKitMediaKeySession):
(WebCore::WebKitMediaKeySession::~WebKitMediaKeySession):
(WebCore::WebKitMediaKeySession::close):
(WebCore::WebKitMediaKeySession::generateKeyRequest):
(WebCore::WebKitMediaKeySession::update):
(WebCore::WebKitMediaKeySession::sendMessage):
(WebCore::WebKitMediaKeySession::sendError):
(WebCore::WebKitMediaKeySession::logChannel const):
- Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
- Modules/encryptedmedia/legacy/WebKitMediaKeys.cpp:
(WebCore::WebKitMediaKeys::createSession):
- Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
- platform/encryptedmedia/CDMFactory.h:
- platform/encryptedmedia/CDMInstance.h:
(WebCore::CDMInstance::setLogIdentifier):
(WebCore::CDMInstance::setLogger): Deleted.
- platform/encryptedmedia/CDMInstanceSession.h:
(WebCore::CDMInstanceSession::setLogIdentifier):
(WebCore::CDMInstanceSession::setLogger): Deleted.
- platform/encryptedmedia/CDMPrivate.h:
(WebCore::CDMPrivate::setLogIdentifier):
(WebCore::CDMPrivate::setLogger): Deleted.
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMFactoryClearKey::createCDM):
- platform/encryptedmedia/clearkey/CDMClearKey.h:
- platform/graphics/LegacyCDMSession.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createSession):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::createSession):
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMFactoryFairPlayStreaming::createCDM):
(WebCore::CDMPrivateFairPlayStreaming::CDMPrivateFairPlayStreaming):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::createInstance):
(WebCore::CDMPrivateFairPlayStreaming::setLogger): Deleted.
- platform/graphics/avfoundation/CDMFairPlayStreaming.h:
- platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::createSession):
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
(WebCore::CDMSessionAVFoundationCF::CDMSessionAVFoundationCF):
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::createSession):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::shouldRetryRequestForReason):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::groupSessionIdentifierChanged):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKeyRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::protectionStatusForDisplayID const):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setLogger): Deleted.
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::setLogger): Deleted.
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
(WebCore::CDMSessionAVContentKeySession::logClassName const):
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::CDMSessionAVContentKeySession):
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
(WebCore::CDMSessionAVContentKeySession::releaseKeys):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::addParser):
(WebCore::CDMSessionAVContentKeySession::removeParser):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):
(WebCore::CDMSessionAVFoundationObjC::~CDMSessionAVFoundationObjC):
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::update):
(WebCore::CDMSessionAVFoundationObjC::playerDidReceiveError):
(WebCore::CDMSessionAVFoundationObjC::logChannel const):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
(WebCore::CDMSessionAVStreamSession::logClassName const):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession):
(WebCore::CDMSessionAVStreamSession::~CDMSessionAVStreamSession):
(WebCore::CDMSessionAVStreamSession::generateKeyRequest):
(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::addParser):
(WebCore::CDMSessionAVStreamSession::removeParser):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
(WebCore::CDMSessionMediaSourceAVFObjC::logger const):
(WebCore::CDMSessionMediaSourceAVFObjC::logIdentifier const):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::logChannel const):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):
- platform/graphics/gstreamer/eme/CDMThunder.cpp:
(WebCore::CDMFactoryThunder::createCDM):
- platform/graphics/gstreamer/eme/CDMThunder.h:
- testing/LegacyMockCDM.cpp:
(WebCore::LegacyMockCDM::createSession):
(WebCore::MockCDMSession::MockCDMSession):
- testing/LegacyMockCDM.h:
- testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::createCDM):
- testing/MockCDMFactory.h:
Source/WebKit:
[Refactor] Adopt LoggerHelper in Legacy EME classes
https://bugs.webkit.org/show_bug.cgi?id=234319
Reviewed by Eric Carlson.
- GPUProcess/media/RemoteCDMFactoryProxy.cpp:
(WebKit::RemoteCDMFactoryProxy::createCDM):
(WebKit::RemoteCDMFactoryProxy::logger const):
- GPUProcess/media/RemoteCDMFactoryProxy.h:
- GPUProcess/media/RemoteCDMInstanceProxy.cpp:
(WebKit::RemoteCDMInstanceProxy::create):
(WebKit::RemoteCDMInstanceProxy::RemoteCDMInstanceProxy):
(WebKit::RemoteCDMInstanceProxy::createSession):
- GPUProcess/media/RemoteCDMInstanceProxy.h:
- GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
- GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
(WebKit::RemoteCDMInstanceSessionProxy::create):
(WebKit::RemoteCDMInstanceSessionProxy::RemoteCDMInstanceSessionProxy):
(WebKit::RemoteCDMInstanceSessionProxy::setLogIdentifier):
- GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
- GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
- GPUProcess/media/RemoteCDMProxy.cpp:
(WebKit::RemoteCDMProxy::create):
(WebKit::RemoteCDMProxy::RemoteCDMProxy):
(WebKit::RemoteCDMProxy::setLogIdentifier):
- GPUProcess/media/RemoteCDMProxy.h:
(WebKit::RemoteCDMProxy::logger const):
(WebKit::RemoteCDMProxy::logIdentifier const):
- GPUProcess/media/RemoteCDMProxy.messages.in:
- GPUProcess/media/RemoteLegacyCDMFactoryProxy.cpp:
(WebKit::RemoteLegacyCDMFactoryProxy::logger const):
- GPUProcess/media/RemoteLegacyCDMFactoryProxy.h:
- GPUProcess/media/RemoteLegacyCDMProxy.cpp:
(WebKit::RemoteLegacyCDMProxy::createSession):
- GPUProcess/media/RemoteLegacyCDMProxy.h:
- GPUProcess/media/RemoteLegacyCDMProxy.messages.in:
- GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
(WebKit::RemoteLegacyCDMSessionProxy::create):
(WebKit::RemoteLegacyCDMSessionProxy::RemoteLegacyCDMSessionProxy):
- GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::createSession):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/RemoteCDM.cpp:
(WebKit::RemoteCDM::setLogIdentifier):
- WebProcess/GPU/media/RemoteCDM.h:
- WebProcess/GPU/media/RemoteCDMConfiguration.h:
(WebKit::RemoteCDMConfiguration::encode const):
(WebKit::RemoteCDMConfiguration::decode):
- WebProcess/GPU/media/RemoteCDMFactory.cpp:
(WebKit::RemoteCDMFactory::createCDM):
- WebProcess/GPU/media/RemoteCDMFactory.h:
- WebProcess/GPU/media/RemoteCDMInstance.cpp:
(WebKit::RemoteCDMInstance::createSession):
- WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
(WebKit::RemoteCDMInstanceSession::setLogIdentifier):
- WebProcess/GPU/media/RemoteCDMInstanceSession.h:
- WebProcess/GPU/media/RemoteLegacyCDM.cpp:
(WebKit::RemoteLegacyCDM::createSession):
- WebProcess/GPU/media/RemoteLegacyCDM.h:
- WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
(WebKit::RemoteLegacyCDMSession::create):
(WebKit::RemoteLegacyCDMSession::RemoteLegacyCDMSession):
- WebProcess/GPU/media/RemoteLegacyCDMSession.h:
- 3:08 PM Changeset in webkit [290469] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r290356-r290351?): [ iOS15 ] 3 imported/w3c/web-platform-tests/service-workers/service-worker/* tests are constant text failures.
https://bugs.webkit.org/show_bug.cgi?id=237160
Unreviewed test gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-24
- platform/ios/TestExpectations:
- 2:53 PM Changeset in webkit [290468] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r290351-r290356?): [ iOS EWS ] imported/w3c/web-platform-tests/service-workers/service-worker/partitioned-service-worker-getRegistrations.tentative.https.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=237162
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 2:53 PM Changeset in webkit [290467] by
-
- 3 edits in trunk/Source/WebKit
Delete SessionStorageQuotaManager
https://bugs.webkit.org/show_bug.cgi?id=237132
Reviewed by Chris Dumez.
The code is unused since r289474.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::addWebsiteDataStore):
(WebKit::NetworkProcess::addSessionStorageQuotaManager): Deleted.
(WebKit::NetworkProcess::removeSessionStorageQuotaManager): Deleted.
(WebKit::NetworkProcess::setSessionStorageQuotaManagerIDBRootPath): Deleted.
(WebKit::NetworkProcess::storageQuotaManager): Deleted.
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::SessionStorageQuotaManager::SessionStorageQuotaManager): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::defaultQuota const): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::ensureOriginStorageQuotaManager): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::existingStorageQuotaManagers): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::cacheRootPath const): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::setIDBRootPath): Deleted.
(WebKit::NetworkProcess::SessionStorageQuotaManager::idbRootPath const): Deleted.
- 2:45 PM Changeset in webkit [290466] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r290356-r290351?):[ iOS EWS ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=237161
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 2:35 PM Changeset in webkit [290465] by
-
- 2 edits in trunk/LayoutTests
[ iOS EWS ]imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-049.htmlis a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=237159
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 2:33 PM Changeset in webkit [290464] by
-
- 7 edits in trunk/Tools
[Python3] Change shebang for various scripts
https://bugs.webkit.org/show_bug.cgi?id=237155
<rdar://problem/89436097>
Reviewed by Ryan Haddad.
- Tools/Scripts/lint-webkitpy: Change shebang to Python 3.
- Tools/Scripts/open-layout-test: Ditto.
- Tools/Scripts/run-imagediff: Ditto.
- Tools/Scripts/run-minibrowser: Ditto.
- Tools/Scripts/run-webkit-httpd: Ditto.
- Tools/Scripts/test-webkit-scripts: Ditto.
Canonical link: https://commits.webkit.org/247762@main
- 2:32 PM Changeset in webkit [290463] by
-
- 2 edits in trunk
Explain visit children and opaque roots in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=236894
Reviewed by Saam Barati.
Added the descriptions of visit children and opaque roots
as well as how to add IDL files.
- Introduction.md:
- 2:26 PM Changeset in webkit [290462] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r289765-r289784): [iOS] Flaky crash under WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree()
https://bugs.webkit.org/show_bug.cgi?id=236794
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 2:23 PM Changeset in webkit [290461] by
-
- 2 edits in trunk/Tools
[Python3] Make report-non-inclusive-language Python 3 compatible
https://bugs.webkit.org/show_bug.cgi?id=237154
<rdar://problem/89434987>
Reviewed by Aakash Jain.
- Tools/Scripts/report-non-inclusive-language: Make Python 3 compatible.
Canonical link: https://commits.webkit.org/247760@main
- 1:59 PM Changeset in webkit [290460] by
-
- 1 copy in tags/Safari-614.1.3.6
Tag Safari-614.1.3.6.
- 1:57 PM Changeset in webkit [290459] by
-
- 1 copy in tags/Safari-613.1.17.1.8
Tag Safari-613.1.17.1.8.
- 1:43 PM Changeset in webkit [290458] by
-
- 2 edits in trunk/LayoutTests
[ iOS15 ] fast/events/autoscroll-in-iframe-body.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=237150
Unreviewed Test Gardening.
Patch by Matteo Flores <Matteo Flores> on 2022-02-24
- platform/ios/TestExpectations: Flaky Failure expectation while investigating
- 1:19 PM Changeset in webkit [290457] by
-
- 9 edits in trunk
[css-cascade] Support 'revert' in @keyframes
https://bugs.webkit.org/show_bug.cgi?id=237073
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Expect tests to pass.
- web-platform-tests/css/css-cascade/revert-val-006-expected.txt:
- web-platform-tests/css/css-cascade/revert-val-007-expected.txt:
- web-platform-tests/css/css-cascade/revert-val-008-expected.txt:
- web-platform-tests/css/css-cascade/revert-val-010-expected.txt:
Source/WebCore:
Resolver::styleForKeyframe was constructing a RenderStyle with only the
styles specified in the @keyframes. But not taking into account the UA
and user rules that affect the element meant that 'revert' was broken.
Since Builder::applyProperty didn't find the declarations from other
origins, 'revert' just behaved as 'unset'.
This patch solves it by detecting if the @keyframes has a 'revert' value
and in that case it collects the UA and user rules so that it can be
resolved properly.
Tests: imported/w3c/web-platform-tests/css/css-cascade/revert-val-006.html
imported/w3c/web-platform-tests/css/css-cascade/revert-val-007.html
imported/w3c/web-platform-tests/css/css-cascade/revert-val-008.html
imported/w3c/web-platform-tests/css/css-cascade/revert-val-010.html
- style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::addAuthorKeyframeRules):
- style/ElementRuleCollector.h:
- style/StyleResolver.cpp:
(WebCore::Style::Resolver::styleForKeyframe):
- 1:16 PM Changeset in webkit [290456] by
-
- 15 edits in trunk/Source
REGRESSION(r290436): fix build failures
https://bugs.webkit.org/show_bug.cgi?id=237149
Reviewed by Tim Horton.
Source/WebCore:
- Modules/applepay/cocoa/PaymentSessionErrorCocoa.mm:
(WebCore::PaymentSessionError::sessionError const):
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const):
ReplacePAL::get_PassKitCore_*()with#definedeclared in<pal/cocoa/PassKitSoftLink.h>.
Source/WebCore/PAL:
- pal/spi/cocoa/PassKitSPI.h:
- pal/spi/cocoa/PassKitInstallmentsSPI.h:
Undo some of the changes in r290436 by re-adding the old
#importpre-r290436 when we do
not have PassKit modularization (i.e.HAVE(PASSKIT_MODULARIZATION)). This way, the code
is the same as it was for older releases.
- pal/cocoa/PassKitSoftLink.h:
- pal/cocoa/PassKitSoftLink.mm:
Declare some
#definefor convenience (and so that if we need to change fromPassKitCore
in the future we don't have to change any callsites).
Source/WebKit:
- Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::toNSError):
- Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
(-[WKPaymentAuthorizationDelegate _willFinishWithError:]):
- Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toPKContactFields):
- Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments):
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):
ReplacePAL::get_PassKitCore_*()with#definedeclared in<pal/cocoa/PassKitSoftLink.h>.
Source/WTF:
- wtf/PlatformHave.h:
Rename
HAVE_PASSKIT_UItoHAVE_PASSKIT_MODULARIZATIONso that it also involesPassKitCore.
- 1:14 PM Changeset in webkit [290455] by
-
- 6 edits13 adds in trunk
Add percent decoding to Scroll to Text Fragment parsing.
https://bugs.webkit.org/show_bug.cgi?id=236818
Reviewed by Chris Dumez.
Source/WebCore:
Leverage URL parser to percent decode parsed text directives in
scroll to text fragment implementation.
Tests: http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-emoji.html
http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-sentence.html
http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start.html
- dom/FragmentDirectiveParser.cpp:
(WebCore::FragmentDirectiveParser::parseFragmentDirective):
Source/WTF:
Expose bits of URL parser to allow percent decoding elsewhere.
- wtf/URLParser.h:
LayoutTests:
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-emoji-expected.html: Added.
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-emoji.html: Added.
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-expected.html: Added.
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-sentence-expected.html: Added.
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start-sentence.html: Added.
- http/wpt/html/dom/scroll-to-text-fragment/scroll-to-text-fragment-start.html: Added.
- 1:10 PM Changeset in webkit [290454] by
-
- 20 edits in trunk
[IFC][Integration] Enable non-paginated vertical-rl writing mode
https://bugs.webkit.org/show_bug.cgi?id=236897
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt:
- web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt:
Source/WebCore:
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForStyle):
LayoutTests:
- fast/repaint/vertical-text-repaint-expected.txt:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-empty-inline-expected.txt:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/css/cssom-view/offsetTopLeft-leading-space-inline-expected.txt:
- platform/ios/fast/backgrounds/border-radius-split-background-expected.txt:
- platform/ios/fast/backgrounds/border-radius-split-background-image-expected.txt:
- platform/ios/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt:
- platform/ios/fast/writing-mode/border-styles-vertical-rl-expected.txt:
- platform/ios/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt:
- platform/mac/fast/backgrounds/border-radius-split-background-expected.txt:
- platform/mac/fast/backgrounds/border-radius-split-background-image-expected.txt:
- platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/writing-mode/border-styles-vertical-rl-expected.txt:
- platform/mac/fast/writing-mode/border-styles-vertical-rl-mixed-expected.txt:
- 1:08 PM Changeset in webkit [290453] by
-
- 6 edits1 delete in trunk/Tools
[Python3] Migrate Tools/CISupport to Python3
https://bugs.webkit.org/show_bug.cgi?id=237148
<rdar://problem/89430395>
Reviewed by Aakash Jain.
- Tools/CISupport/build-webkit-org/committer_auth_unittest_old.py: Removed.
- Tools/CISupport/build-webkit-org/loadConfig_unittest.py: Change shebang to Python 3.
- Tools/CISupport/build-webkit-org/make_passwords_json.py: Change shebang to Python 3,
make Python 3 compatible.
- Tools/CISupport/ews-build/email_unittest.py: Change shebang to Python 3.
- Tools/CISupport/ews-build/loadConfig_unittest.py: Ditto.
- Tools/CISupport/win/kill-old-processes: Ditto.
Canonical link: https://commits.webkit.org/247753@main
- 1:08 PM Changeset in webkit [290452] by
-
- 4 edits1 copy in trunk/Source/WTF
[XCBuild] WTF's SPI dependencies are copied via a folder reference and do not emit task outputs
https://bugs.webkit.org/show_bug.cgi?id=237129
Reviewed by Alexey Proskuryakov.
In https://bugs.webkit.org/show_bug.cgi?id=235744, a folder reference was used to copy
headers fromspi/, but the build system needs explicit file references for all headers to
infer discovered dependency relationships for incremental builds. Add spi/ headers directly
to WTF.xcodeproj.
We now have a method for using build rules to make a native Headers phase nest headers
according to their source directories. Use it here and delete the per-directory Copy Files
phases.
WTF's unicode headers--used only by external builders--are copied to a different include
directory, so for organization simplicity, add a separate target to WTF.xcodeproj to track
them. This target is effectively headers-only as it has no source files.
- Configurations/Base.xcconfig: Copy WK_WHICH_BUILD_SYSTEM settings from other projects.
- Configurations/WTF.xcconfig: Set header folder paths.
- Configurations/icu.xcconfig: Copied from Source/WTF/Configurations/WTF.xcconfig.
- WTF.xcodeproj/project.pbxproj: Add icu target, add spi headers, add build rules.
- 12:35 PM Changeset in webkit [290451] by
-
- 9 edits in branches/safari-614.1.3-branch/Source
Versioning.
WebKit-7614.1.3.6
- 12:13 PM Changeset in webkit [290450] by
-
- 8 edits2 adds in trunk
Refactor logic for showing "Markup Image" and Quick Note items in the callout bar
https://bugs.webkit.org/show_bug.cgi?id=237127
rdar://89396617
Reviewed by Megan Gardner.
Source/WebKit:
Use
-buildMenuWithBuilder:to supply additional Quick Note and image analysis items, instead of adding them
directly to the shared menu controller. See below for more details.
Tests: ImageAnalysisTests.MenuControllerItems
WebKit.AppHighlightsInImageOverlays
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView didMoveToWindow]):
See below.
(-[WKWebView buildMenuWithBuilder:]):
Override this method and call into the content view via
-buildMenuForWebViewWithBuilder:to populate the given
builder with either Quick Note or "Markup Image" items, if necessary. Note that overriding this method on
WKWebView is sufficient, since UIKit walks up the responder hierarchy starting from the first responder
(WKContentView) when populating menu items.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView targetForAction:withSender:]):
Move some logic for conditionally enabling the Quick Note items into
-imageAnalysisMarkupMenu.
(-[WKContentView imageAnalysisMarkupMenu]):
(-[WKContentView _selectionChanged]):
Remove logic that updates the shared UIMenuController's menu items every time the selection changes. This is
no longer needed, since UIKit will always call into-buildMenuWithBuilder:when presenting the callout bar,
which allows us to lazily run logic to determine whether or not we should show the Quick Note and image analysis
items when the callout bar is shown, instead of keeping the menu controller's-menuItemsarray up to date upon
each selection change.
(-[WKContentView buildMenuForWebViewWithBuilder:]):
Consult
-appHighlightMenuand-imageAnalysisMarkupMenuto populate the menu with inline UIMenus. Note that
these menus' items are always inlined into the callout bar as top-level items, since we explicitly specify
UIMenuOptionsDisplayInlinewhen creating the menu.
(-[WKContentView menuWithInlineAction:identifier:handler:]):
(-[WKContentView appHighlightMenu]):
Refactor this, and
-imageAnalysisMarkupMenuabove to return a UIMenu with a single UIAction presented inline.
(-[WKContentView updateImageAnalysisMarkupMenuItems:]): Deleted.
Replaced with
-imageAnalysisMarkupMenu.
(-[WKContentView canPerformImageAnalysisMarkup]): Deleted.
(-[WKContentView performImageAnalysisMarkup:]): Deleted.
(-[WKContentView setUpAdditionalMenuControllerActions]): Deleted.
(findMenuItemWithAction): Deleted.
(-[WKContentView updateAppHighlightMenuItems:]): Deleted.
Replaced with
-appHighlightMenu.
(-[WKContentView createHighlightForCurrentQuickNoteWithRange:]): Deleted.
(-[WKContentView createHighlightForNewQuickNoteWithRange:]): Deleted.
Tools:
Adjust a couple of existing API tests. See comments below.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
Refactor ImageAnalysisTests.MenuControllerItems to exercise
-buildMenuWithBuilder:instead of swizzling
UIMenuController methods and checking-menuItems.
(TestWebKitAPI::swizzledSetMenuItems): Deleted.
(): Deleted.
- TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
Refactor WebKit.AppHighlightsInImageOverlays to exercise
-buildMenuWithBuilder:instead of passing in actions
to-targetForAction:withSender:.
- TestWebKitAPI/ios/TestUIMenuBuilder.h: Added.
- TestWebKitAPI/ios/TestUIMenuBuilder.mm: Added.
Add a helper class that conforms to UIMenuBuilder. This is used in the two API tests above as an argument to
-buildMenuWithBuilder:in order to collect additional menu items that WKWebView adds to the callout bar.
(-[TestUIMenuBuilder init]):
(-[TestUIMenuBuilder system]):
(-[TestUIMenuBuilder menuForIdentifier:]):
(-[TestUIMenuBuilder findMatching:]):
(-[TestUIMenuBuilder containsActionWithTitle:]):
(-[TestUIMenuBuilder reset]):
(-[TestUIMenuBuilder actionForIdentifier:]):
(-[TestUIMenuBuilder commandForAction:propertyList:]):
(-[TestUIMenuBuilder replaceMenuForIdentifier:withMenu:]):
(-[TestUIMenuBuilder replaceChildrenOfMenuForIdentifier:fromChildrenBlock:]):
(-[TestUIMenuBuilder insertChildMenu:atStartOfMenuForIdentifier:]):
(-[TestUIMenuBuilder insertChildMenu:atEndOfMenuForIdentifier:]):
(-[TestUIMenuBuilder removeMenuForIdentifier:]):
(-[TestUIMenuBuilder insertSiblingMenu:beforeMenuForIdentifier:]):
(-[TestUIMenuBuilder insertSiblingMenu:afterMenuForIdentifier:]):
(-[TestUIMenuBuilder registerMenu:]):
- 12:08 PM Changeset in webkit [290449] by
-
- 5 edits in trunk/Source/JavaScriptCore
[Cocoa] Only clear ICU cache when time zone is changed
https://bugs.webkit.org/show_bug.cgi?id=236996
Reviewed by Yusuke Suzuki.
We used to unconditionally invalidate the VM's DateCache in VMEntryScope in order to
make sure we always used the latest time zone from the host machine (in case it changed).
This overly aggressive invalidation was causing us to repeatedly go to the disk in order
to determine the host time zone. On Cocoa ports, we now listen to the
kCFTimeZoneSystemTimeZoneDidChangeNotification notification and only invalidate the
VM's DateCache in VMEntryScope if the host time zone has actually changed since the
last time.
- runtime/JSDateMath.cpp:
(JSC::timeZoneChangeNotification):
(JSC::DateCache::DateCache):
(JSC::DateCache::resetIfNecessary):
(JSC::DateCache::reset): Deleted.
- runtime/JSDateMath.h:
- runtime/VM.h:
(JSC::VM::resetDateCacheIfNecessary):
(JSC::VM::resetDateCache): Deleted.
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
- 11:58 AM Changeset in webkit [290448] by
-
- 9 edits in branches/safari-613.1.17.1-branch/Source
Versioning.
WebKit-7613.1.17.1.8
- 11:51 AM Changeset in webkit [290447] by
-
- 5 edits in trunk/Tools
[Python3] Convert shebangs in generate_xcfilelists_lib
https://bugs.webkit.org/show_bug.cgi?id=237147
<rdar://problem/89427981>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/webkitpy/generate_xcfilelists_lib/init.py: Change shebang to Python 3.
- Tools/Scripts/webkitpy/generate_xcfilelists_lib/application.py: Ditto.
- Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Ditto.
- Tools/Scripts/webkitpy/generate_xcfilelists_lib/util.py: Ditto.
Canonical link: https://commits.webkit.org/247750@main
- 11:47 AM Changeset in webkit [290446] by
-
- 2 edits in trunk/Source/WebKit
Regression(r273929) FrameState no longer gets a move constructor
https://bugs.webkit.org/show_bug.cgi?id=237142
Reviewed by Darin Adler.
FrameState no longer gets an implicit move constructor since r273929 because a custom
destructor was added.
- Shared/SessionState.h:
- 11:41 AM Changeset in webkit [290445] by
-
- 2 edits in trunk/Source/WebCore
Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion()
https://bugs.webkit.org/show_bug.cgi?id=237146
Reviewed by Geoffrey Garen.
Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion().
It was logging an error even when the load succeeded.
- workers/shared/SharedWorkerObjectConnection.cpp:
(WebCore::SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion):
- 11:33 AM Changeset in webkit [290444] by
-
- 2 edits in trunk/JSTests
Skip shadow-realm-import-value on ARM too
https://bugs.webkit.org/show_bug.cgi?id=237139
Unreviewed gardening.
- stress/shadow-realm-import-value.js:
- 11:31 AM Changeset in webkit [290443] by
-
- 32 edits in trunk
Update CSP console logging
https://bugs.webkit.org/show_bug.cgi?id=232216
<rdar://problem/89322580>
Reviewed by Brent Fulgham.
Source/WebCore:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::originalHeaders const):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowResourceFromSource const):
(WebCore::ContentSecurityPolicy::allowWorkerFromSource const):
(WebCore::ContentSecurityPolicy::allowScriptFromSource const):
(WebCore::ContentSecurityPolicy::allowStyleFromSource const):
Source/WebKit:
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::check):
(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):
- NetworkProcess/NetworkLoadChecker.h:
LayoutTests:
- http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/audio-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/font-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/font-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/image-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/image-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-after-multiple-redirects-expected.txt:
- http/tests/security/contentSecurityPolicy/script-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/script-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/stylesheet-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/svg-font-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/svg-image-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/video-redirect-blocked.html:
- http/tests/security/contentSecurityPolicy/xsl-redirect-blocked-expected.txt:
- 10:29 AM Changeset in webkit [290442] by
-
- 7 edits1 add in trunk
[MacCatalyst] REGRESSION(r290091): sometimes can crash if
WKWebViewis deallocated before the next visible content rect update
https://bugs.webkit.org/show_bug.cgi?id=237126
<rdar://problem/89345853>
Reviewed by Tim Horton.
Source/WebKit:
Tests: WKWebViewResize.DoesNotAssertInDeallocAfterChangingFrame
WKWebViewResize.DoesNotAssertInDeallocAfterChangingBounds
- UIProcess/API/ios/WKWebViewIOS.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _acquireResizeAssertionForReason:]):
(-[WKWebView _invalidateResizeAssertions]): Added.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView dealloc]):
Make sure to-invalidateany remaining assertions in-deallocas required by_UIInvalidatable.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WKWebViewResize.mm: Added.
(TEST.WKWebViewResize.DoesNotAssertInDeallocAfterChangingFrame):
(TEST.WKWebViewResize.DoesNotAssertInDeallocAfterChangingBounds):
- TestWebKitAPI/SourcesCocoa.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 10:02 AM Changeset in webkit [290441] by
-
- 2 edits in trunk/Tools
Add myself (John Pascoe) to watchlist for authentication and WebCrypto
https://bugs.webkit.org/show_bug.cgi?id=237121
rdar://problem/89385797
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/config/watchlist:
- 9:55 AM Changeset in webkit [290440] by
-
- 2 edits in trunk/Source/WTF
Fix debug build of WorkQueueGeneric after r290418
https://bugs.webkit.org/show_bug.cgi?id=237143
Unreviewed build fix.
Correct the method signature of WorkQueue::assertIsCurrent in WorkQueueGeneric.cpp.
- wtf/generic/WorkQueueGeneric.cpp:
(WTF::WorkQueue::assertIsCurrent const):
(WTF::WorkQueue::assertIsCurrent): Deleted.
- 9:47 AM Changeset in webkit [290439] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, add some logging to imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html to debug flakiness
- web-platform-tests/workers/semantics/multiple-workers/004.html:
- 9:31 AM Changeset in webkit [290438] by
-
- 8 edits in trunk
[LFC][IFC] Non-orthogonal inline block boxes keep their baseline on ideographic lines
https://bugs.webkit.org/show_bug.cgi?id=236946
Reviewed by Antti Koivisto.
Source/WebCore:
This is similar to the logic in RenderBlock::baselinePosition for inline block boxes.
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):
- layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
- rendering/RenderBlock.h:
LayoutTests:
- platform/mac/fast/writing-mode/border-styles-vertical-lr-mixed-expected.txt: Progression
- 9:19 AM Changeset in webkit [290437] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] verticalLogicalMargin returns incorrect values for vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=237138
Reviewed by Antti Koivisto.
This was caused by an accidental copy/paste.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::verticalLogicalMargin): also switch over to "switch".
- 8:46 AM Changeset in webkit [290436] by
-
- 16 edits in trunk/Source
[Apple Pay] switch from
PassKit/*toPassKit[Core,UI]/*
https://bugs.webkit.org/show_bug.cgi?id=237091
<rdar://problem/81085862>
Reviewed by Tim Horton.
Source/WebCore:
- Modules/applepay/cocoa/PaymentSessionErrorCocoa.mm:
(WebCore::PaymentSessionError::sessionError const):
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const):
Source/WebCore/PAL:
- pal/spi/cocoa/PassKitSPI.h:
- pal/spi/cocoa/PassKitInstallmentsSPI.h:
- pal/cocoa/PassKitSoftLink.h:
- pal/cocoa/PassKitSoftLink.mm:
Source/WebKit:
- Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::toNSError):
- Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
(-[WKPaymentAuthorizationDelegate _willFinishWithError:]):
- Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):
(WebKit::toPKContactFields):
- Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WebKit::WebPaymentCoordinatorProxy::platformCanMakePayments):
(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):
- WebProcess/ApplePay/cocoa/WebPaymentCoordinatorCocoa.mm:
(WebKit::WebPaymentCoordinator::platformAvailablePaymentNetworks):
Source/WTF:
- wtf/PlatformHave.h:
- 8:42 AM Changeset in webkit [290435] by
-
- 12 edits1 delete in trunk
Web Inspector: merge WI.OverlayManager into WI.DOMNode
https://bugs.webkit.org/show_bug.cgi?id=236533
Reviewed by Patrick Angle.
Source/WebInspectorUI:
There's really nothing substantial about
WI.OverlayManagerthat requires it to exist. All
of the methods, members, etc. can be moved toWI.DOMNode, resulting in clearer calling
code (since callers currently have to provide aWI.DOMNodetoWI.OverlayManagermethods)
and fewer collections (e.g. it's no longer necessary to have a "list of nodes showing a grid
overlay").
- UserInterface/Controllers/OverlayManager.js: Removed.
- UserInterface/Main.html:
- UserInterface/Base/Main.js:
(WI.loaded):
- UserInterface/Models/DOMNode.js:
(WI.DOMNode):
(WI.DOMNode.resetDefaultLayoutOverlayConfiguration): Added.
(WI.DOMNode.prototype.get layoutOverlayShowing): moved fromWI.OverlayManager.protytpe.hasVisibleOverlay.
(WI.DOMNode.prototype.set layoutContextType):
(WI.DOMNode.prototype.showLayoutOverlay): moved fromWI.OverlayManager.protytpe.showOverlay.
(WI.DOMNode.prototype.hideLayoutOverlay): moved fromWI.OverlayManager.protytpe.hideOverlay.
(WI.DOMNode.prototype.get layoutOverlayColor): moved fromWI.OverlayManager.protytpe.getColorForNode.
(WI.DOMNode.prototype.set layoutOverlayColor): moved fromWI.OverlayManager.protytpe.setColorForNode.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype._mainResourceDidChange):
Reset the index of the next default color to use for the next grid/flex DOM node.
- UserInterface/Views/DOMTreeElement.js:
(WI.DOMTreeElement.prototype.onattach):
(WI.DOMTreeElement.prototype.ondetach):
(WI.DOMTreeElement.prototype._layoutBadgeClicked):
(WI.DOMTreeElement.prototype._updateLayoutBadgeStatus):
(WI.DOMTreeElement.prototype._handleLayoutContextTypeChanged):
- UserInterface/Views/NodeOverlayListSection.js:
(WI.NodeOverlayListSection.prototype.attached):
(WI.NodeOverlayListSection.prototype.detached):
(WI.NodeOverlayListSection.prototype.layout):
(WI.NodeOverlayListSection.prototype._handleOverlayStateChanged):
(WI.NodeOverlayListSection.prototype._handleToggleAllCheckboxChanged):
(WI.NodeOverlayListSection.prototype._updateToggleAllCheckbox):
- UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:
(WI.GridOverlayConfigurationDiagnosticEventRecorder):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.setup):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype._handleGridOverlayShown):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype._handleGridOverlayHidden):
(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype._sampleCurrentOverlayConfiguration):
- UserInterface/Controllers/GridOverlayDiagnosticEventRecorder.js:
(WI.GridOverlayDiagnosticEventRecorder):
(WI.GridOverlayDiagnosticEventRecorder.prototype.setup):
(WI.GridOverlayDiagnosticEventRecorder.prototype.teardown):
(WI.GridOverlayDiagnosticEventRecorder.prototype._handleGridOverlayShown):
Adopt the above changes:
- Replace
WI.OverlayManager.Event.*withWI.DOMNode.Event.*(andevent.data.domNodewithevent.target). - Replace
WI.overlayManager.*(domNode[, ...])withdomNode.*([...]). - Directly query
WI.settings.gridOverlay*.valueinstead of getting them from thedatainWI.DOMNode.Event.LayoutOverlayShown(formerlyWI.OverlayManager.Event.OverlayShown).
LayoutTests:
- inspector/dom/showFlexOverlay.html:
- inspector/dom/showGridOverlay.html:
Replace direct
DOMAgentcalls with equivalentWI.DOMNodemethods.
- 8:09 AM Changeset in webkit [290434] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r290401 - [WPE][GTK] Paths should be canonicalized before calling bwrap
https://bugs.webkit.org/show_bug.cgi?id=211131
Patch by Maxim Cournoyer <maxim.cournoyer@gmail.com> on 2022-02-23
Reviewed by Michael Catanzaro.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindSymlinksRealPath): Relocate earlier in file,
add a 'bindOption' argument and use FileSystem::realPath instead
of realpath from the standard C library.
(WebKit::bindIfExists): Use the modified above procedure to
canonicalize the source path, and avoid adding bind mounts for
locations under /etc.
- 8:09 AM Changeset in webkit [290433] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r290395 - Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS
https://bugs.webkit.org/show_bug.cgi?id=237089
Patch by Liliana Marie Prikler <liliana.prikler@gmail.com> on 2022-02-23
Reviewed by Michael Catanzaro.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindFonts): Expose font directories present in the
XDG_DATA_DIRS environment variable.
- 8:09 AM Changeset in webkit [290432] by
-
- 5 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r290359 - Ensure generated inline assembler that setups segments returns to previous state
https://bugs.webkit.org/show_bug.cgi?id=236976
Reviewed by Yusuke Suzuki.
Use .previous in inline assembler in order to ensure that mixed emission of assembler
functions and other definitions correctly puts each of them in their rightful sections
in the output object code.
- assembler/MacroAssemblerARM64.cpp:
- assembler/MacroAssemblerARMv7.cpp:
- assembler/MacroAssemblerMIPS.cpp:
- assembler/MacroAssemblerX86Common.cpp:
- 8:08 AM WebKitGTK/2.36.x edited by
- (diff)
- 8:08 AM Changeset in webkit [290431] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r290312 - When building introspection files, add CMAKE_C_FLAGS to the compiler flags.
https://bugs.webkit.org/show_bug.cgi?id=232936
Patch by Alexander Kanavin <alex@linutronix.de> on 2022-02-22
Reviewed by Michael Catanzaro.
g-ir-compiler is using a C compiler internally, so it needs to set
the proper flags for it.
- PlatformGTK.cmake:
- 7:45 AM Changeset in webkit [290430] by
-
- 4 edits2 adds in trunk
RELEASE_ASSERT(!renderer()); in WebCore::Node::~Node() + 479 (Node.cpp:366)
https://bugs.webkit.org/show_bug.cgi?id=235380
Patch by Frédéric Wang <fwang@igalia.com> on 2022-02-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
RenderTreeUpdater::tearDownRenderers() browse the composed tree to tear down descendants.
However, element with a shadow root are handled specially in
ComposedTreeIterator::ComposedTreeIterator(), they have to be handled specially by calling
a tearDownLeftoverShadowHostChildren(). This patch does the same for slot elements which
are also handled specially in ComposedTreeIterator(). It also makes names within
tearDownLeftoverShadowHostChildren() more generic. This in particular fixes a release assert
when a slot with pseudo elements children is torn down.
Test: fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown.html
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers): Also call tearDownLeftoverShadowHostChildren
for a slot element and add a comment pointing to the method corresponding to these special
cases.
(WebCore::RenderTreeUpdater::tearDownLeftoverChildrenOfComposedTree): Renamed to remove "shadow host".
- rendering/updating/RenderTreeUpdater.h: Ditto.
LayoutTests:
Add non-regression test.
- fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown-expected.txt: Added.
- fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown.html: Added.
- 7:13 AM Changeset in webkit [290429] by
-
- 2 edits in trunk/Tools
[run-webkit-tests] Use Python 3 (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=226658
<rdar://problem/78882016>
Reviewed by Ryan Haddad.
- Tools/Scripts/run-webkit-tests: Change shebang to Python 3.
Canonical link: https://commits.webkit.org/247736@main
- 6:40 AM Changeset in webkit [290428] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] Adjust hittest coords when in flipped writing mode
https://bugs.webkit.org/show_bug.cgi?id=237103
Reviewed by Antti Koivisto.
This is similar to what we do in LegacyInlineFlowBox::nodeAtPoint.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::flippedRectForWritingMode):
(WebCore::LayoutIntegration::flippedPointForWritingMode):
(WebCore::LayoutIntegration::LineLayout::hitTest):
- 6:27 AM Changeset in webkit [290427] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WTF
Merge r290417 - REGRESSION(r289683): [GTK][WPE] Scrolling with the mouse wheel doesn't work in twitter after r289683
https://bugs.webkit.org/show_bug.cgi?id=237093
Reviewed by Carlos Garcia Campos.
Turn off by default for wpe/gtk and windows to investigate issue.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 4:49 AM WebKitGTK/2.36.x edited by
- (diff)
- 4:47 AM WebKitGTK/2.36.x edited by
- (diff)
- 4:32 AM Changeset in webkit [290426] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[GTK] WebGL ANGLE backend is broken after r290138
https://bugs.webkit.org/show_bug.cgi?id=237133
Patch by Alejandro G. Castro <alex@igalia.com> on 2022-02-24
Reviewed by Kimmo Kinnunen.
We removed some of the options that are already included in the
general library compilation, that fixes the backend.
- PlatformGTK.cmake:
- 4:29 AM Changeset in webkit [290425] by
-
- 3 edits in trunk/LayoutTests
webrtc/video-replace-muted-track.html is unnecessary long to run
https://bugs.webkit.org/show_bug.cgi?id=237086
Reviewed by Peng Liu.
- platform/mac/TestExpectations: Unflake test since it is no longer flaky in bots.
- webrtc/routines.js:
We were waiting for 360 iterations to validate no black frame is found in webrtc/routines.js.
This makes it last around 20 seconds.
Decrease the number of iterations to 40, around 2 seconds by decrementing counter from provided value
instead of incrementing value up to 400.
- 4:17 AM Changeset in webkit [290424] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed test gardening.
Another WebGL test with failing expected results in glib.
- platform/glib/TestExpectations:
- platform/glib/webgl/webgl-allow-shared-expected.txt: Removed.
- 4:11 AM Changeset in webkit [290423] by
-
- 13 edits in trunk/Source
LibWebRTCCodecs, -Proxy create and communicate the RemoteVideoFrameProxy incorrectly
https://bugs.webkit.org/show_bug.cgi?id=237083
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-24
Reviewed by Youenn Fablet.
Source/WebCore:
Add functions to set media sample ownership identity if the underlying object
supports the feature.
- platform/MediaSample.h:
(WebCore::MediaSample::setOwnershipIdentity):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::setOwnershipIdentity):
- platform/graphics/cv/VideoFrameCV.h:
- platform/graphics/cv/VideoFrameCV.mm:
(WebCore::VideoFrameCV::setOwnershipIdentity):
Source/WebKit:
LibWebRTCCodecsProxy should not call RemoteVideoFrameObjectHeap::createVideoFrame,
the function should be removed. Instead, LibWebRTCCodecsProxy should construct a
write reference to insert the media sample -> remote proxy mapping. Then
the result of the insert, a new reference, should be sent as part of the
RemoteVideoFrameProxy::Properties to the WP. This way the sent reference is
constructed as expected. Previously the reference was correct but matched just
by selecting the constants currently used (0). This works towards being able
to remove RemoteVideoFrameObjectHeap::createVideoFrame.
Split the completedDecoding to two:
- completedDecoding used to send new RemoteVideoFrames
- completedDecodingCV to send CoreVideo specific RemoteVideoSample instances (which will removed eventually).
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::Function<void):
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::completedDecoding):
(WebKit::LibWebRTCCodecs::completedDecodingCV):
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:
- 3:57 AM Changeset in webkit [290422] by
-
- 11 edits in trunk
Implement logical properties for CSS overscroll-behavior
https://bugs.webkit.org/show_bug.cgi?id=237080
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-overscroll-behavior/inheritance-expected.txt: Update expectations for passing tests.
- web-platform-tests/css/css-overscroll-behavior/overscroll-behavior-logical-expected.txt: Ditto.
- web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-computed-expected.txt: Ditto.
- web-platform-tests/css/css-overscroll-behavior/parsing/overscroll-behavior-valid-expected.txt: Ditto.
Source/WebCore:
No new tests. This is covered by existing WPT tests.
Add support for overscroll-behavior-block and overscroll-behavior-inline, the logical versions
of the overscroll behavior properties.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
- 3:13 AM Changeset in webkit [290421] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Respect bytecode alignment in BytecodeRewriter
https://bugs.webkit.org/show_bug.cgi?id=237092
Patch by Geza Lore <Geza Lore> on 2022-02-24
Reviewed by Yusuke Suzuki.
Note: This patch only affects bytecode generation on platforms which
set CPU(NEEDS_ALIGNED_ACCESS), which are ARMv7 and MIPS. On all other
platforms the generated bytecode is identical.
The previous BytecodeRewriter::removeBytecode method unconditionally
removed the given instruction, which could then break the required
alignment of subsequent wide ops. While this could be fixed by
inserting padding after the removal, all current uses of
removeBytecode are such that they constitute one half of a replace.
Instead of adding unnecessary padding, added an explicit
replaceBytecodeWithFragment method that removes the old instruction
and replaces it with the given fragment, while maintaining alignment
of the subsequent bytecode. This yields fewer nops. If removeBytecode
turns out to be necessary later, use replaceBytecodeWithFragment with
an empty fragment.
- bytecode/BytecodeGeneratorification.cpp:
(JSC::BytecodeGeneratorification::run):
- bytecode/BytecodeRewriter.h:
(JSC::BytecodeRewriter::Fragment::align):
(JSC::BytecodeRewriter::insertFragmentAfter):
(JSC::BytecodeRewriter::replaceBytecodeWithFragment):
- bytecompiler/BytecodeGeneratorBaseInlines.h:
(JSC::BytecodeGeneratorBase<Traits>::alignWideOpcode32):
- 2:22 AM Changeset in webkit [290420] by
-
- 3 edits in trunk/Source/WTF
Unreviewed. Fix compile warnings when asserts are disabled after r290418
- wtf/Threading.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
- wtf/WorkQueue.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
- 1:42 AM Changeset in webkit [290419] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. [GTK] Mark GLContextGLX.cpp as no-unify
- SourcesGTK.txt:
- 1:03 AM Changeset in webkit [290418] by
-
- 20 edits in trunk
Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=236832
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-24
Reviewed by Antti Koivisto.
Source/WebKit:
Assert directly that the work queues are current instead of using ThreadAssertion.
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::~RemoteGraphicsContextGL):
(WebKit::RemoteGraphicsContextGL::displayWasReconfigured):
(WebKit::RemoteGraphicsContextGL::workQueueInitialize):
(WebKit::RemoteGraphicsContextGL::workQueueUninitialize):
(WebKit::RemoteGraphicsContextGL::didComposite):
(WebKit::RemoteGraphicsContextGL::forceContextLost):
(WebKit::RemoteGraphicsContextGL::dispatchContextChangedNotification):
(WebKit::RemoteGraphicsContextGL::reshape):
(WebKit::RemoteGraphicsContextGL::prepareForDisplay):
(WebKit::RemoteGraphicsContextGL::synthesizeGLError):
(WebKit::RemoteGraphicsContextGL::getError):
(WebKit::RemoteGraphicsContextGL::ensureExtensionEnabled):
(WebKit::RemoteGraphicsContextGL::markContextChanged):
(WebKit::RemoteGraphicsContextGL::paintRenderingResultsToCanvasWithQualifiedIdentifier):
(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToCanvasWithQualifiedIdentifier):
(WebKit::RemoteGraphicsContextGL::paintCompositedResultsToMediaSample):
(WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer):
(WebKit::RemoteGraphicsContextGL::simulateEventForTesting):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
(WebKit::RemoteGraphicsContextGL::workQueue const):
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:
(WebKit::RemoteGraphicsContextGL::copyTextureFromVideoFrame):
(WebKit::RemoteGraphicsContextGLCocoa::platformWorkQueueInitialize):
(WebKit::RemoteGraphicsContextGLCocoa::prepareForDisplay):
- GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(moveErrorsToSyntheticErrorList):
(activeTexture):
(attachShader):
(bindAttribLocation):
(bindBuffer):
(bindFramebuffer):
(bindRenderbuffer):
(bindTexture):
(blendColor):
(blendEquation):
(blendEquationSeparate):
(blendFunc):
(blendFuncSeparate):
(checkFramebufferStatus):
(clear):
(clearColor):
(clearDepth):
(clearStencil):
(colorMask):
(compileShader):
(copyTexImage2D):
(copyTexSubImage2D):
(createBuffer):
(createFramebuffer):
(createProgram):
(createRenderbuffer):
(createShader):
(createTexture):
(cullFace):
(deleteBuffer):
(deleteFramebuffer):
(deleteProgram):
(deleteRenderbuffer):
(deleteShader):
(deleteTexture):
(depthFunc):
(depthMask):
(depthRange):
(detachShader):
(disable):
(disableVertexAttribArray):
(drawArrays):
(drawElements):
(enable):
(enableVertexAttribArray):
(finish):
(flush):
(framebufferRenderbuffer):
(framebufferTexture2D):
(frontFace):
(generateMipmap):
(getActiveAttrib):
(getActiveUniform):
(getAttribLocation):
(getBufferParameteri):
(getString):
(getFloatv):
(getIntegerv):
(getInteger64):
(getInteger64i):
(getProgrami):
(getBooleanv):
(getFramebufferAttachmentParameteri):
(getProgramInfoLog):
(getRenderbufferParameteri):
(getShaderi):
(getShaderInfoLog):
(getShaderPrecisionFormat):
(getShaderSource):
(getTexParameterf):
(getTexParameteri):
(getUniformfv):
(getUniformiv):
(getUniformuiv):
(getUniformLocation):
(getVertexAttribOffset):
(hint):
(isBuffer):
(isEnabled):
(isFramebuffer):
(isProgram):
(isRenderbuffer):
(isShader):
(isTexture):
(lineWidth):
(linkProgram):
(pixelStorei):
(polygonOffset):
(renderbufferStorage):
(sampleCoverage):
(scissor):
(shaderSource):
(stencilFunc):
(stencilFuncSeparate):
(stencilMask):
(stencilMaskSeparate):
(stencilOp):
(stencilOpSeparate):
(texParameterf):
(texParameteri):
(uniform1f):
(uniform1fv):
(uniform1i):
(uniform1iv):
(uniform2f):
(uniform2fv):
(uniform2i):
(uniform2iv):
(uniform3f):
(uniform3fv):
(uniform3i):
(uniform3iv):
(uniform4f):
(uniform4fv):
(uniform4i):
(uniform4iv):
(uniformMatrix2fv):
(uniformMatrix3fv):
(uniformMatrix4fv):
(useProgram):
(validateProgram):
(vertexAttrib1f):
(vertexAttrib1fv):
(vertexAttrib2f):
(vertexAttrib2fv):
(vertexAttrib3f):
(vertexAttrib3fv):
(vertexAttrib4f):
(vertexAttrib4fv):
(vertexAttribPointer):
(viewport):
(bufferData0):
(bufferData1):
(bufferSubData):
(readnPixels0):
(readnPixels1):
(texImage2D0):
(texImage2D1):
(texSubImage2D0):
(texSubImage2D1):
(compressedTexImage2D0):
(compressedTexImage2D1):
(compressedTexSubImage2D0):
(compressedTexSubImage2D1):
(drawArraysInstanced):
(drawElementsInstanced):
(vertexAttribDivisor):
(createVertexArray):
(deleteVertexArray):
(isVertexArray):
(bindVertexArray):
(copyBufferSubData):
(getBufferSubData):
(blitFramebuffer):
(framebufferTextureLayer):
(invalidateFramebuffer):
(invalidateSubFramebuffer):
(readBuffer):
(renderbufferStorageMultisample):
(texStorage2D):
(texStorage3D):
(texImage3D0):
(texImage3D1):
(texSubImage3D0):
(texSubImage3D1):
(copyTexSubImage3D):
(compressedTexImage3D0):
(compressedTexImage3D1):
(compressedTexSubImage3D0):
(compressedTexSubImage3D1):
(getFragDataLocation):
(uniform1ui):
(uniform2ui):
(uniform3ui):
(uniform4ui):
(uniform1uiv):
(uniform2uiv):
(uniform3uiv):
(uniform4uiv):
(uniformMatrix2x3fv):
(uniformMatrix3x2fv):
(uniformMatrix2x4fv):
(uniformMatrix4x2fv):
(uniformMatrix3x4fv):
(uniformMatrix4x3fv):
(vertexAttribI4i):
(vertexAttribI4iv):
(vertexAttribI4ui):
(vertexAttribI4uiv):
(vertexAttribIPointer):
(drawRangeElements):
(drawBuffers):
(clearBufferiv):
(clearBufferuiv):
(clearBufferfv):
(clearBufferfi):
(createQuery):
(deleteQuery):
(isQuery):
(beginQuery):
(endQuery):
(getQuery):
(getQueryObjectui):
(createSampler):
(deleteSampler):
(isSampler):
(bindSampler):
(samplerParameteri):
(samplerParameterf):
(getSamplerParameterf):
(getSamplerParameteri):
(fenceSync):
(isSync):
(deleteSync):
(clientWaitSync):
(waitSync):
(getSynci):
(createTransformFeedback):
(deleteTransformFeedback):
(isTransformFeedback):
(bindTransformFeedback):
(beginTransformFeedback):
(endTransformFeedback):
(transformFeedbackVaryings):
(getTransformFeedbackVarying):
(pauseTransformFeedback):
(resumeTransformFeedback):
(bindBufferBase):
(bindBufferRange):
(getUniformIndices):
(getActiveUniforms):
(getUniformBlockIndex):
(getActiveUniformBlockName):
(uniformBlockBinding):
(getActiveUniformBlockiv):
(getGraphicsResetStatusARB):
(getTranslatedShaderSourceANGLE):
(drawBuffersEXT):
(getInternalformativ):
(multiDrawArraysANGLE):
(multiDrawArraysInstancedANGLE):
(multiDrawElementsANGLE):
(multiDrawElementsInstancedANGLE):
(paintRenderingResultsToPixelBuffer):
- GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::RemoteGPU):
(WebKit::RemoteGPU::initialize):
(WebKit::RemoteGPU::stopListeningForIPC):
(WebKit::RemoteGPU::workQueueInitialize):
(WebKit::RemoteGPU::workQueueUninitialize):
(WebKit::RemoteGPU::requestAdapter):
- GPUProcess/graphics/WebGPU/RemoteGPU.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::~RemoteVideoFrameObjectHeap):
(WebKit::RemoteVideoFrameObjectHeap::stopListeningForIPC):
(WebKit::RemoteVideoFrameObjectHeap::releaseVideoFrame):
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- Platform/IPC/StreamConnectionWorkQueue.cpp:
(IPC::StreamConnectionWorkQueue::assertIsCurrent const):
- Platform/IPC/StreamConnectionWorkQueue.h:
(IPC::WTF_ASSERTS_ACQUIRED_CAPABILITY):
Source/WTF:
Thread safety analysis is not useful when code is mainly run with WorkQueues.
WorkQueue runnables might run in arbitrary thread, but still serially in a specific
"work queue". Thus current ThreadAssertion produces false assertions.
Make Thread and WorkQueue hold "is current" capability. This means the
assertIsCurrent(thread/workQueue)can establish that the caller holds the capabity,
e.g. that the caller is running in the particular thread or work queue.
Tested by new API tests.
- wtf/Threading.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
- wtf/WorkQueue.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueueBase::platformInitialize):
(WTF::WorkQueue::assertIsCurrent const):
(WTF::currentSequenceID):
- wtf/generic/WorkQueueGeneric.cpp:
(WTF::WorkQueueBase::platformInitialize):
(WTF::WorkQueue::assertIsCurrent):
(WTF::currentSequenceID):
Tools:
Test the added functionality to be able to use assertIsCurrent(thread/workQueue).
Fix WTF_WorkQueue.DestroyDispatchedOnDispatchQueue test, it is now able to make the assertion correctly.
- The object is created somewhere that is not the tested WorkQueue
- The object is destroyed in the tested WorkQueue
- Scripts/generate-gpup-webgl:
- TestWebKitAPI/Tests/WTF/Threading.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST):
- 12:57 AM Changeset in webkit [290417] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r289683): [GTK][WPE] Scrolling with the mouse wheel doesn't work in twitter after r289683
https://bugs.webkit.org/show_bug.cgi?id=237093
Reviewed by Carlos Garcia Campos.
Turn off by default for wpe/gtk and windows to investigate issue.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 12:56 AM Changeset in webkit [290416] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] WeakMapImpl do not need to take cellLock in visitOutputConstraints and main thread
https://bugs.webkit.org/show_bug.cgi?id=200195
Reviewed by Mark Lam.
WeakMapImpl::visitOutputConstraints is called in the constraint solver, so the main thread is stopped.
WeakMapImpl::rehash can destroy the buffer, but it is only called on either the main thread or GC finalizer. As a result,
it never happens that destroying the buffer while touching it in visitOutputConstraints. We can remove the lock guarding
this buffer.
- runtime/WeakMapImpl.cpp:
(JSC::WeakMapImpl<BucketType>::visitOutputConstraints):
- runtime/WeakMapImpl.h:
(JSC::WeakMapImpl::WeakMapImpl):
(JSC::WeakMapImpl::makeAndSetNewBuffer):
(JSC::WeakMapImpl::finishCreation): Deleted.
- runtime/WeakMapImplInlines.h:
(JSC::WeakMapImpl<WeakMapBucket>::rehash):
- 12:55 AM Changeset in webkit [290415] by
-
- 2 edits in trunk/Source/WTF
Small optimizations to TinyLRUCache
https://bugs.webkit.org/show_bug.cgi?id=237117
Reviewed by Darin Adler.
Small optimizations to TinyLRUCache:
- When trying to find an entry in the cache, start from the end of the vector since this is where the most recent entries are.
- Use reverseFind() instead of a for loop to simplify the code a bit
- Use Vector::uncheckedAppend() instead of Vector::append() to bypass capacity checks given that the vector has an inline capacity that is the size of the cache (vector capacity never grows or shrinks).
- wtf/TinyLRUCache.h:
(WTF::TinyLRUCache::get):
Feb 23, 2022:
- 11:28 PM Changeset in webkit [290414] by
-
- 22 edits3 deletes in trunk
Unreviewed, reverting r290284.
https://bugs.webkit.org/show_bug.cgi?id=237131
It is preventing the fuzzer from finding other bugs
Reverted changeset:
"Make input element UA shadow tree creation lazy"
https://bugs.webkit.org/show_bug.cgi?id=236747
https://commits.webkit.org/r290284
- 10:35 PM Changeset in webkit [290413] by
-
- 6 edits in trunk/Source/WebKit
REGRESSION(r290175): Texture upload from video and user media is slower than expected for non-GPUP WebGL
https://bugs.webkit.org/show_bug.cgi?id=237034
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-23
Reviewed by Youenn Fablet.
Add back the code-path to obtain the IOSurface backed CVPixelBuffers directly
via IPC transfer. This is used on macOS where WebGL is in WP.
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::pixelBuffer):
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
- WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
(WebKit::RemoteVideoFrameProxy::pixelBuffer const):
- WebProcess/GPU/media/RemoteVideoFrameProxy.h:
- 10:16 PM Changeset in webkit [290412] by
-
- 9 edits9 adds in trunk
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046
Reviewed by Devin Rousso.
Source/WebCore:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
LayoutTests:
Test gardening to take in account new console warning.
- fast/animation/request-animation-frame-during-modal-expected.txt:
- fast/dom/Window/open-window-min-size-expected.txt:
- fast/events/show-modal-dialog-onblur-onfocus-expected.txt:
- http/tests/cookies/document-cookie-after-showModalDialog-expected.txt:
- http/tests/security/navigate-when-restoring-cached-page-expected.txt:
- http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt:
- platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
- platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
- platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
- 7:18 PM Changeset in webkit [290411] by
-
- 3 edits in trunk/Source/WebCore
Modernize / simplify ScrollingStateTree a bit
https://bugs.webkit.org/show_bug.cgi?id=237111
Reviewed by Simon Fraser.
Modernize / simplify ScrollingStateTree a bit.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::nodeTypeAndParentMatch):
Simplify function body to be on one line and make function static since it doesn't
need an instance.
(WebCore::nodeWasReattachedRecursive):
Make function static since it doesn't need an instance.
(WebCore::ScrollingStateTree::createUnparentedNode):
- Pass a reference instead of pointer
(WebCore::ScrollingStateTree::insertNode):
- Use template deduction for Ref<>
- Drop unnecessarily 0-check for parentID since stateNodeForID(parentID) would have returned null and we would have returned early a few lines above.
(WebCore::ScrollingStateTree::unparentNode):
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
- Use RefPtr type for protectedNode based on the variable naming. Previously, auto would have deduced to a raw pointer.
(WebCore::ScrollingStateTree::detachAndDestroySubtree):
(WebCore::ScrollingStateTree::clear):
Pass more references instead of pointers.
(WebCore::ScrollingStateTree::commit):
use auto and std::exchange() to make the code a bit more concise.
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
- Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.
- Rename currNode to currentNode per WebKit coding style.
(WebCore::ScrollingStateTree::willRemoveNode):
Take a reference in parameter instead of a raw pointer since the pointer couldn't
be null.
(WebCore::ScrollingStateTree::stateNodeForID const):
Rewrite function in a more concise way by calling HashMap::get() instead of HashMap::find().
(WebCore::reconcileLayerPositionsRecursive):
- Make function static since it doesn't need an instance
- Rename currNode to currentNode per WebKit coding style
(WebCore::ScrollingStateTree::reconcileViewportConstrainedLayerPositions):
Make function a bit more concise by not doing an early return.
(showScrollingStateTree):
Take in a reference instead of a raw pointer.
(WebCore::ScrollingStateTree::nodeTypeAndParentMatch const): Deleted.
(WebCore::ScrollingStateTree::nodeWasReattachedRecursive): Deleted.
(WebCore::ScrollingStateTree::reconcileLayerPositionsRecursive): Deleted.
- page/scrolling/ScrollingStateTree.h:
- 6:25 PM Changeset in webkit [290410] by
-
- 1 copy in tags/Safari-614.1.5.3
Tag Safari-614.1.5.3.
- 6:24 PM Changeset in webkit [290409] by
-
- 2 edits in trunk/LayoutTests
[ Mac wk1 Release ] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=236126
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 5:51 PM Changeset in webkit [290408] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.3
- 5:43 PM Changeset in webkit [290407] by
-
- 2 edits in trunk/Source/WebKit
Fix !ENABLE(SERVICE_WORKER) build after r290387
https://bugs.webkit.org/show_bug.cgi?id=237119
Unreviewed build fix.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):
- 5:31 PM Changeset in webkit [290406] by
-
- 9 edits2 deletes in trunk
Unreviewed, reverting r290351 and r290404.
Broke the build after revert of initial commit (r290348)
Rebases no longer needed due to revert
Reverted changesets:
"Use of showModalDialog should appear as a warning in WI
console"
https://bugs.webkit.org/show_bug.cgi?id=237046
https://commits.webkit.org/r290351
"Use of showModalDialog should appear as a warning in WI
console"
https://bugs.webkit.org/show_bug.cgi?id=237046
https://commits.webkit.org/r290404
- 5:24 PM Changeset in webkit [290405] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Adjust thread number for GC throughput
https://bugs.webkit.org/show_bug.cgi?id=237122
Reviewed by Mark Lam.
Adjust numberOfGCMarkers from 4 to 3 to make GC and main thread througput better on M1 macOS.
3 makes sense since there is also a main thread when they are running concurrently to the
main thread.
It offers 1.2% improvement in Speedometer2 in M1Max MBP and 0.4% improvement in M1 MBP.
| subtest | ms | ms | b / a | pValue (significance using False Discovery Rate) |
| Elm-TodoMVC |107.445000 |102.856667 |0.957296 | 0.000000 (significant) |
| VueJS-TodoMVC |21.571667 |21.805000 |1.010817 | 0.403054 |
| EmberJS-TodoMVC |113.320000 |111.300000 |0.982174 | 0.000027 (significant) |
| BackboneJS-TodoMVC |39.981667 |39.318333 |0.983409 | 0.002346 (significant) |
| Preact-TodoMVC |15.516667 |15.648333 |1.008485 | 0.544754 |
| AngularJS-TodoMVC |117.010000 |115.346667 |0.985785 | 0.000495 (significant) |
| Vanilla-ES2015-TodoMVC |57.790000 |57.176667 |0.989387 | 0.000270 (significant) |
| Inferno-TodoMVC |55.275000 |53.755000 |0.972501 | 0.000000 (significant) |
| Flight-TodoMVC |53.875000 |53.941667 |1.001237 | 0.739556 |
| Angular2-TypeScript-TodoMVC |36.600000 |36.471667 |0.996494 | 0.743761 |
| VanillaJS-TodoMVC |48.058333 |47.671667 |0.991954 | 0.158193 |
| jQuery-TodoMVC |203.433333 |201.878333 |0.992356 | 0.009271 (significant) |
| EmberJS-Debug-TodoMVC |325.058333 |319.848333 |0.983972 | 0.000003 (significant) |
| React-TodoMVC |80.533333 |79.281667 |0.984458 | 0.000011 (significant) |
| React-Redux-TodoMVC |134.738333 |131.801667 |0.978205 | 0.000000 (significant) |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |56.780000 |56.168333 |0.989227 | 0.000514 (significant) |
a mean = 293.86568
b mean = 297.52900
pValue = 0.0266899465
(Bigger means are better.)
1.012 times better
Results ARE significant
- runtime/Options.cpp:
(JSC::overrideDefaults):
- 5:12 PM Changeset in webkit [290404] by
-
- 1 edit9 adds in trunk/LayoutTests
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046
Unreviewed test gardening. Rebase for wk1 mac and Windows tests.
- platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
- platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
- platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/beforeunload-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/pagehide-showModalDialog-expected.txt: Added.
- platform/wincairo-wk1/fast/events/unload-showModalDialog-expected.txt: Added.
- 4:52 PM Changeset in webkit [290403] by
-
- 1 copy in tags/Safari-613.1.17.1.7
Tag Safari-613.1.17.1.7.
- 4:51 PM Changeset in webkit [290402] by
-
- 1 copy in tags/Safari-614.1.3.5
Tag Safari-614.1.3.5.
- 4:49 PM Changeset in webkit [290401] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Paths should be canonicalized before calling bwrap
https://bugs.webkit.org/show_bug.cgi?id=211131
Patch by Maxim Cournoyer <maxim.cournoyer@gmail.com> on 2022-02-23
Reviewed by Michael Catanzaro.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindSymlinksRealPath): Relocate earlier in file,
add a 'bindOption' argument and use FileSystem::realPath instead
of realpath from the standard C library.
(WebKit::bindIfExists): Use the modified above procedure to
canonicalize the source path, and avoid adding bind mounts for
locations under /etc.
- 4:47 PM Changeset in webkit [290400] by
-
- 2 edits in trunk
[XCBuild] Don't automatically use the ../Internal/WebKit workspace
https://bugs.webkit.org/show_bug.cgi?id=237115
Reviewed by Alexey Proskuryakov.
When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
if it was available. The idea was to make it easier for workspace builds to automatically
detect dependencies needed by folks at Apple, like WebKitAdditions.
In practice, this has made workspace builds silently rely on code from outside of the WebKit
repo, and it's unintuitive since non-workspace Make builds do not do this.
- Makefile.shared:
- 4:39 PM Changeset in webkit [290399] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, reverting r290348.
Broke a test, slowing down EWS.
Reverted changeset:
"Create a DOMWindow::printWarningMessage method and start
using it in DOMWindow.cpp"
https://bugs.webkit.org/show_bug.cgi?id=237047
https://commits.webkit.org/r290348
- 4:37 PM Changeset in webkit [290398] by
-
- 9 edits in branches/safari-613.1.17.1-branch/Source
Versioning.
WebKit-7613.1.17.1.7
- 4:34 PM Changeset in webkit [290397] by
-
- 9 edits in branches/safari-614.1.3-branch/Source
Versioning.
WebKit-7614.1.3.5
- 4:21 PM Changeset in webkit [290396] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] Flip accumulatedOffset to take writing mode into account when hittesting across formatting contexts.
https://bugs.webkit.org/show_bug.cgi?id=237094
Reviewed by Antti Koivisto.
Both paint and hittest need coord flip (vertical writing mode here) when jumping through formatting context boundaries.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::flippedContentOffsetIfNeeded):
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::hitTest):
- 3:47 PM Changeset in webkit [290395] by
-
- 2 edits in trunk/Source/WebKit
Bubblewrap launcher doesn't bind font locations from XDG_DATA_DIRS
https://bugs.webkit.org/show_bug.cgi?id=237089
Patch by Liliana Marie Prikler <liliana.prikler@gmail.com> on 2022-02-23
Reviewed by Michael Catanzaro.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bindFonts): Expose font directories present in the
XDG_DATA_DIRS environment variable.
- 3:18 PM Changeset in webkit [290394] by
-
- 94 edits in trunk
Adopt more widely the new URL constructor that takes in a String
https://bugs.webkit.org/show_bug.cgi?id=237099
Reviewed by Darin Adler.
Source/WebCore:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::convertAndValidatePaymentMethodIdentifier):
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::completeURL const):
- dom/Document.cpp:
(WebCore::Document::referrer):
- html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::didNavigateExtensionTab):
(WebCore::InspectorFrontendHost::inspectedPageDidNavigate):
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::extractInnerURL):
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::willSendRequest):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(convertPlaybinURI):
- platform/network/soup/URLSoup.cpp:
(WebCore::soupURIToURL):
- platform/win/PasteboardWin.cpp:
(WebCore::filesystemPathFromUrlOrTitle):
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
- workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::fromDatabaseKey):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::importRecords):
Source/WebKit:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
- Shared/API/APISecurityOrigin.h:
(API::SecurityOrigin::createFromString):
- Shared/API/APIURL.h:
(API::URL::parseURLIfNecessary const):
- Shared/API/c/WKURLRequest.cpp:
(WKURLRequestCreateWithWKURL):
- Shared/API/glib/WebKitURIRequest.cpp:
(webkit_uri_request_set_uri):
- Shared/APIWebArchiveResource.mm:
(API::WebArchiveResource::WebArchiveResource):
- Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
- Shared/curl/WebCoreArgumentCodersCurl.cpp:
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
- Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::ArgumentCoder<SelectionData>::decode):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
- UIProcess/API/C/WKOpenPanelResultListener.cpp:
(filePathsFromFileURLs):
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadURL):
(WKPageLoadURLWithShouldOpenExternalURLsPolicy):
(WKPageLoadURLWithUserData):
(WKPageLoadAlternateHTMLStringWithUserData):
(WKPageSetPrivateClickMeasurementTokenPublicKeyURLForTesting):
(WKPageSetPrivateClickMeasurementTokenSignatureURLForTesting):
(WKPageSetPrivateClickMeasurementAttributionReportURLsForTesting):
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetResourceLoadStatisticsPrevalentResourceForDebugMode):
(WKWebsiteDataStoreSetStatisticsLastSeen):
(WKWebsiteDataStoreSetStatisticsMergeStatistic):
(WKWebsiteDataStoreSetStatisticsExpiredStatistic):
(WKWebsiteDataStoreSetStatisticsPrevalentResource):
(WKWebsiteDataStoreSetStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsPrevalentResource):
(WKWebsiteDataStoreIsStatisticsVeryPrevalentResource):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubresourceUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsSubFrameUnder):
(WKWebsiteDataStoreIsStatisticsRegisteredAsRedirectingTo):
(WKWebsiteDataStoreSetStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsHasHadUserInteraction):
(WKWebsiteDataStoreIsStatisticsOnlyInDatabaseOnce):
(WKWebsiteDataStoreSetStatisticsGrandfathered):
(WKWebsiteDataStoreIsStatisticsGrandfathered):
(WKWebsiteDataStoreSetStatisticsSubframeUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUnderTopFrameOrigin):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsSubresourceUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectTo):
(WKWebsiteDataStoreSetStatisticsTopFrameUniqueRedirectFrom):
(WKWebsiteDataStoreSetStatisticsCrossSiteLoadWithLinkDecoration):
(WKWebsiteDataStoreStatisticsDeleteCookiesForTesting):
(WKWebsiteDataStoreStatisticsHasLocalStorage):
(WKWebsiteDataStoreStatisticsHasIsolatedSession):
(WKWebsiteDataStoreSetResourceLoadStatisticsToSameSiteStrictCookiesForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyHostCNAMEDomainForTesting):
(WKWebsiteDataStoreSetResourceLoadStatisticsThirdPartyCNAMEDomainForTesting):
(WKWebsiteDataStoreSetAppBoundDomainsForTesting):
- UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp:
(WKWebsiteDataStoreEnableCustomNetworkProxySettings):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
- UIProcess/API/glib/WebKitCookieManager.cpp:
(webkit_cookie_manager_get_cookies):
- UIProcess/API/glib/WebKitSecurityOrigin.cpp:
(webkit_security_origin_new_for_uri):
- UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_load_alternate_html):
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _uiEventAttribution]):
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::navigateBrowsingContext):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):
- UIProcess/Cocoa/LegacyDownloadClient.mm:
(WebKit::LegacyDownloadClient::legacyDidStart):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::willPerformClientRedirect):
(WebKit::NavigationState::NavigationClient::didPerformClientRedirect):
- UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm:
(-[WKReloadFrameErrorRecoveryAttempter attemptRecovery]):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::isURLKnownHSTSHost const):
- UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:
(WebKit::RemoteWebInspectorUIProxy::load):
- UIProcess/Inspector/WebInspectorUIProxy.cpp:
(WebKit::WebInspectorUIProxy::isMainOrTestInspectorPage):
(WebKit::WebInspectorUIProxy::openLocalInspectorFrontend):
- UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:
(WebKit::RemoteWebInspectorUIProxy::platformSave):
- UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:
(WebKit::WebInspectorUIProxy::platformSave):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::sessionState const):
(WebKit::checkIfNavigationContainsDataTransfer):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::checkURLReceivedFromCurrentOrPreviousWebProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::initializeAppBoundDomains):
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionState):
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::validateMerchant):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameAllowsFollowingLink):
(WKBundleFrameCopySuggestedFilenameForResourceWithURL):
(WKBundleFrameCopyMIMETypeForResourceWithURL):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageHasLocalDataForURL):
(WKBundlePageClearApplicationCacheForOrigin):
(WKBundlePageGetAppCacheUsageForOrigin):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setUserStyleSheetLocation):
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::isValidFetch):
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFormData):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTML):
(WebKit::WebPage::getResourceDataFromFrame):
- webpushd/PushService.mm:
(WebPushD::PushService::didReceivePushMessage):
Source/WebKitLegacy/win:
- MarshallingHelpers.cpp:
- WebError.cpp:
(WebError::init):
- WebFrame.cpp:
(WebFrame::loadData):
- WebView.cpp:
(toURL):
Source/WTF:
- wtf/URL.cpp:
(WTF::aboutBlankURL):
(WTF::aboutSrcDocURL):
Tools:
- TestWebKitAPI/Tests/WTF/URLParser.cpp:
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::testUserPassword):
- TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::mainDocumentRequest):
(TestWebKitAPI::subResourceRequest):
(TestWebKitAPI::requestInTopAndFrameURLs):
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
(TestWebKitAPI::Curl::TEST_F):
- TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
- 2:45 PM Changeset in webkit [290393] by
-
- 2 edits in trunk
Add wdx's Github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237106
Unreviewed.
- metadata/contributors.json:
- 2:33 PM Changeset in webkit [290392] by
-
- 4 edits in trunk
[WebAuthn] Improve error message for missing pubKeyCredParams
https://bugs.webkit.org/show_bug.cgi?id=235421
rdar://87884875
Reviewed by Brent Fulgham.
Source/WebCore:
We have seen confusion from library authors around the language
used in this error not indicating enough information about what
the problem is. This patch adds additional information, useful
to developers seeing this error.
- Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
LayoutTests:
Update test to reflect new error message.
- http/wpt/webauthn/public-key-credential-create-failure.https.html:
- 1:40 PM Changeset in webkit [290391] by
-
- 1 copy in tags/Safari-614.1.5.2
Tag Safari-614.1.5.2.
- 12:59 PM Changeset in webkit [290390] by
-
- 2 edits in trunk/Source/bmalloc
[libpas] PlayStation uses 16k page size.
https://bugs.webkit.org/show_bug.cgi?id=237096
Reviewed by Yusuke Suzuki.
Match the granule default size to system page size for our platform.
- libpas/src/libpas/pas_internal_config.h:
- 12:57 PM Changeset in webkit [290389] by
-
- 2 edits in trunk/Tools
REGRESSION (288925?): [iOS] TestWebKitAPI.RequestTextInputContext.TextInteraction_FocusingReadOnlyElementShouldScrollToReveal is failing
https://bugs.webkit.org/show_bug.cgi?id=237069
rdar://89325305
Reviewed by Kate Cheney.
This iOS API test occasionally fails in some test runners in automation, due to
didScrollstill being false at
the end of the test. While I was unable to reproduce (both locally, and using EWS test runners), from code
inspection this test appears to be inherently flaky since the scrolling is triggered via editor state updates
propagated through remote layer tree commits; however, the test only verifies that scrolling occurs after one
IPC round-trip between the web and UI processes (due to the call to-stringByEvaluatingJavaScript:).
Since the regression point is suspiciously close to r288925, it's possible that the optimizations introduced in
r288925 removed an extra sync IPC round-trip to the web process and back when requesting an autocorrection
context after element focus, which would make this flakiness easier to reproduce in some configurations.
In any case, one speculative fix for this test is to simply wait for the scrolling to occur, instead of assuming
that it occurs after a single IPC round-trip.
- TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
(TestWebKitAPI::TEST):
- 12:34 PM Changeset in webkit [290388] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] LineLayout::firstLinePhysicalBaseline/lastLineLogicalBaseline should flip box baseline value for vertical-lr
https://bugs.webkit.org/show_bug.cgi?id=237090
Reviewed by Antti Koivisto.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::firstLinePhysicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineLogicalBaseline const):
(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
- 12:12 PM Changeset in webkit [290387] by
-
- 18 edits in trunk/Source/WebKit
Share more code between service and shared workers for context connection establishment
https://bugs.webkit.org/show_bug.cgi?id=237085
Reviewed by Youenn Fablet.
Share more code between service and shared workers for context connection establishment.
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
- NetworkProcess/SharedWorker/WebSharedWorker.cpp:
(WebKit::WebSharedWorker::firstSharedWorkerObjectProcess const):
- NetworkProcess/SharedWorker/WebSharedWorker.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
(WebKit::WebSharedWorkerServer::didFinishFetchingSharedWorkerScript):
(WebKit::WebSharedWorkerServer::createContextConnection):
(WebKit::WebSharedWorkerServer::removeContextConnection):
(WebKit::WebSharedWorkerServer::shutDownSharedWorker):
- NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::NetworkProcessProxy::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::NetworkProcessProxy::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::WebProcessPool::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::establishRemoteWorkerContext):
(WebKit::WebProcessProxy::establishServiceWorkerContext): Deleted.
(WebKit::WebProcessProxy::establishSharedWorkerContext): Deleted.
- UIProcess/WebProcessProxy.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcess::establishSharedWorkerContextConnectionToNetworkProcess): Deleted.
(WebKit::WebProcess::establishServiceWorkerContextConnectionToNetworkProcess): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 11:28 AM Changeset in webkit [290386] by
-
- 2 edits in trunk/LayoutTests
[ Mac EWS ] imported/w3c/web-platform-tests/workers/semantics/multiple-workers/004.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=237095
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Setting [ Pass Failure ] expectations for flaky test failure that is slowing down EWS.
- 11:26 AM Changeset in webkit [290385] by
-
- 2 edits in trunk/LayoutTests
[Subpixel] imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html fails at certain font sizes
https://bugs.webkit.org/show_bug.cgi?id=217643
<rdar://problem/70464703>
Unreviewed gardening.
- platform/ios-simulator-wk2/TestExpectations: It must have progressed at some point.
- 11:02 AM Changeset in webkit [290384] by
-
- 5 edits in trunk/Source
Prevent use of PDFKit when using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237052
rdar://89251696
Reviewed by Tim Horton.
Source/WebCore:
Add WEBCORE_EXPORT in order to use isPDFMIMEType.
- platform/MIMETypeRegistry.h:
Source/WebKit:
PDFKit was still being used by embeds, this patch fixes that issue by treating
pdf embeds as frames if PDF.js is enabled and also prevents the loading of
the PDFKit plugin entirely by modifying shouldUsePDFPlugin.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):
- 10:36 AM Changeset in webkit [290383] by
-
- 2 edits in trunk/Tools
[run-webkit-tests] Catch OSError when sampling
https://bugs.webkit.org/show_bug.cgi?id=237087
<rdar://problem/89357299>
Reviewed by Aakash Jain.
- Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort.sample_process): Catch OSError when either sampling a
process or running spindump. These errors indicate the error gathering process
failed, but such a failure should not be fatal to the entire test run.
Canonical link: https://commits.webkit.org/247698@main
- 10:26 AM Changeset in webkit [290382] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] LineLayout::firstInlineBoxRect should flip the rect coordinates for vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=237036
Reviewed by Antti Koivisto and Darin Adler.
This is similar to what RenderInline::firstInlineBoxTopLeft does.
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
- 10:19 AM Changeset in webkit [290381] by
-
- 11 edits in trunk
[WebAuthn] userHandle not marked nullable in _WKWebAuthenticationAssertionResponse
https://bugs.webkit.org/show_bug.cgi?id=237043
rdar://89317740
Reviewed by Brent Fulgham.
Source/WebCore:
The userHandle is a nullable field on UserEntity. This patch changes
various API/SPI to allow passing null userHandle.
- Modules/webauthn/AuthenticatorAssertionResponse.cpp:
(WebCore::AuthenticatorAssertionResponse::create):
(WebCore::AuthenticatorAssertionResponse::AuthenticatorAssertionResponse):
- Modules/webauthn/AuthenticatorAssertionResponse.h:
Source/WebKit:
The userHandle is a nullable field on UserEntity. This patch changes
various API/SPI to allow passing null userHandle.
- Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
Update forward declared SPI, reflecting userHandle as nullable.
- UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponseInternal.h:
- UIProcess/API/Cocoa/_WKWebAuthenticationAssertionResponse.h:
Update userHandle property to null.
- UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
Tools:
Create tests to check for null userHandle.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- 10:14 AM Changeset in webkit [290380] by
-
- 10 edits in trunk
[CSS Container Queries] offsetWidth/Height and similar should update layout for container queries
https://bugs.webkit.org/show_bug.cgi?id=237079
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/auto-scrollbars-expected.txt:
- web-platform-tests/css/css-contain/container-queries/inline-size-containment-expected.txt:
- web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl-expected.txt:
- web-platform-tests/css/css-contain/container-queries/transition-scrollbars-expected.txt:
Source/WebCore:
Fix
css/css-contain/container-queries/inline-size-containment.html
css/css-contain/container-queries/inline-size-containment-vertical-rl.html
- dom/Document.cpp:
(WebCore::Document::updateLayout):
Make iterative instead of recursive.
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
Check for query containers.
Call local updateLayout instead of the FrameViewLayoutContext one.
- page/FrameView.cpp:
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):
Add protection against infinite layout/invalidation cycle with unstable layouts.
- style/StyleScope.h:
- 10:09 AM Changeset in webkit [290379] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening for GPU Process bot.
- imported/blink/svg/paintorder/paintorder.svg:
- 10:02 AM Changeset in webkit [290378] by
-
- 6 edits in trunk/LayoutTests
Test gardening for [CSS Blending] Non-separable blend modes don't work
https://bugs.webkit.org/show_bug.cgi?id=131354
LayoutTests/imported/mozilla:
Unreviewed. Relanding with updated fuzzy data.
- svg/blend-color.svg:
- svg/blend-hue.svg:
- svg/blend-luminosity.svg:
LayoutTests:
Unreviewed.
- 9:50 AM Changeset in webkit [290377] by
-
- 6 edits2 adds in trunk
Fix for assert crash in AccessibilityRenderObject::visiblePositionForIndex.
https://bugs.webkit.org/show_bug.cgi?id=236795
rdar://89025180
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/native-text-control-attributed-string.html
In some cases like the one described in the bug, AccessibilityRenderObject::visiblePositionForIndex
is passed an index greater than the length of the text actually contained
in the text control. This triggers this assert that verifies that you can
round-trip from index to VisiblePosition and back to index. This patch
does a bounds check in the index and adjust if necessary.
The test exercise this method through the JS AccessibilityUIElement::attributedStringForRange
for both <input> of type text and password.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex const):
LayoutTests:
- accessibility/native-text-control-attributed-string-expected.txt: Added.
- accessibility/native-text-control-attributed-string.html: Added.
- 8:35 AM Changeset in webkit [290376] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.2
- 8:33 AM Changeset in webkit [290375] by
-
- 5 edits in trunk
[GStreamer] De-initialize GStreamer before terminating WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237084
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-23
Reviewed by Carlos Garcia Campos.
Source/WebKit:
Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
exits too early, the leak tracer reporting will be interrupted potentially too early. The
workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
handling and leak tracing was done and keeping the second tab open.
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):
Tools:
- flatpak/flatpakutils.py:
(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
to store paths.
- 8:09 AM Changeset in webkit [290374] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unreviewed, build fix for Debian Stable after r290366
- platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
- 8:00 AM Changeset in webkit [290373] by
-
- 5 edits in trunk/Source/WebKit
RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
https://bugs.webkit.org/show_bug.cgi?id=237025
<rdar://problem/89343447>
Reviewed by Darin Adler.
Updated https://commits.webkit.org/r290358 according comments given during review.
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<std::nullptr_t>::encode):
(IPC::ArgumentCoder<std::nullptr_t>::decode):
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::RemoteVideoFrameObjectHeapProxyProcessor):
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::write):
(WebKit::SharedVideoFrameReader::SharedVideoFrameReader):
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
(WebKit::SharedVideoFrame::encode const):
(WebKit::SharedVideoFrame::decode):
- 7:54 AM Changeset in webkit [290372] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r287574): ASSERTION FAILED: !m_impl !m_shouldEnableAssertions m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack() https://bugs.webkit.org/show_bug.cgi?id=235168
<rdar://problem/87518939>
Reviewed by Alexey Proskuryakov.
Use runOnMainThread() from within WebCore, as it will dispatch to the correct thread when
running under iOS/WebKitLegacy.
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):
- 7:20 AM Changeset in webkit [290371] by
-
- 4 edits in trunk
Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP
https://bugs.webkit.org/show_bug.cgi?id=237071
<rdar://88652375>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-02-23
Reviewed by Chris Dumez.
Source/WebKit:
There was an assumption that this callback wasn't needed in this case, but it is.
Covered by an API test that verifies the callback is received.
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):
- 6:59 AM Changeset in webkit [290370] by
-
- 2 edits in trunk/Source/WebKit
[GLib] Add missing WebPage.h inclusion in WebProcessGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=237081
Unreviewed, adding the WebPage.h header inclusion in WebProcessGLib.cpp
to avoid incomplete-type errors for the WebPage class under a certain
combination of unified sources.
Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-02-23
- WebProcess/glib/WebProcessGLib.cpp:
- 6:01 AM Changeset in webkit [290369] by
-
- 2 edits in trunk/Tools
[JSC] Set ssh keepalive in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=237031
Reviewed by Adrian Perez de Castro.
If a remote goes down after an ssh connection has been established, we
need to be able to detect that. Keep the common ssh config options in
one constant and add ServerAliveInterval=30 to it.
While here, change sshRead to execute ssh directly (instead of
going through the shell). Similarly, don't open-code the read
loop, just call IO.read.
- Scripts/run-jsc-stress-tests:
- 5:47 AM Changeset in webkit [290368] by
-
- 4 edits in trunk/Source
RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor
https://bugs.webkit.org/show_bug.cgi?id=237020
Reviewed by Kimmo Kinnunen.
Source/WebCore:
No change of behavior.
Covered by existing tests.
- platform/graphics/cv/VideoFrameCV.h:
(WebCore::VideoFrameC$V::pixelBuffer const: Mark it as final.
Source/WebKit:
Make use of pixelBuffer virtual method to simplify things.
Add a missing early return in case of not found pixel buffer.
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::getVideoFrameBuffer):
- 5:19 AM Changeset in webkit [290367] by
-
- 4 edits in trunk
Fix GPUP WebGL generator script wrt uninitialised sized span
https://bugs.webkit.org/show_bug.cgi?id=235889
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-23
Reviewed by Antti Koivisto.
Source/WebKit:
Regenerated.
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
Tools:
Fix the generator. The r290328 only edited the generated files.
Add a other hunk missing from r290175.
- Scripts/generate-gpup-webgl:
- 4:27 AM Changeset in webkit [290366] by
-
- 8 edits4 adds in trunk
[GStreamer] Add WebKitDMABufVideoSink
https://bugs.webkit.org/show_bug.cgi?id=236883
Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-02-23
Reviewed by Philippe Normand.
.:
- Source/cmake/FindGStreamer.cmake:
Also search for gstreamer-allocators-1.0, produce the relevant variables
containing include directories and cflags.
Source/WebCore:
Add custom WebKitDMABufVideoSink sink that is able to accept decoded
dmabuf or raw data in a range of RGB-like or YUV formats.
The sink is pretty straightforward, in large part mirroring the
WebKitGLVideoSink implementation. The formats that (at the moment) we
can correctly handle inside the TextureMapper-based graphics pipeline
are combined with both the dmabuf or raw memory type during the caps
construction. Like the GL counterpart, the received samples are passed
on to the associated MediaPlayerPrivateGStreamer object. The common
integration into the MediaPlayerPrivateGStreamer functionality is
encapsulated into the webKitVideoSinkSetMediaPlayerPrivate() function.
The MediaPlayerPrivateGStreamer implementation will be enhanced later to
properly handle samples conforming to either variant of these caps. But
the idea is that when using this sink, a dmabuf-containing sample will
pass the dmabuf to the graphics subsystem and a raw-data-containing
sample will copy the data into a dmabuf object (created or reused) and
then pass it on.
The WEBKIT_GST_DMABUF_SINK_FORCED_FALLBACK_CAPS_FORMAT environment
variable can be set to specify the desired exclusive format that this
sink should support. This is especially helpful to debug the correct
handling of different RGB or YUV formats inside the graphics pipeline.
When set, only raw data of the specified format is accepted, meaning the
pipeline upstream will perform any necessary conversion of the decoded
data into the desired format. Raw data is then packed into dmabufs and
sent into the pipeline for display, enabling the developer to examine
whether the given format is handled appropriately.
The sink element is registered in registerWebKitGStreamerElements().
This functionality will require The GStreamer allocators library, so the
necessary dependency glue is also provided.
- platform/GStreamer.cmake:
- platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: Added.
(forcedFallbackCapsFormat):
(webKitDMABufVideoSinkConstructed):
(webKitDMABufVideoSinkFinalize):
(webKitDMABufVideoSinkGetProperty):
(webkit_dmabuf_video_sink_class_init):
(webKitDMABufVideoSinkSetMediaPlayerPrivate):
(webKitDMABufVideoSinkProbePlatform):
- platform/graphics/gstreamer/DMABufVideoSinkGStreamer.h: Added.
- platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(webKitGLVideoSinkSetMediaPlayerPrivate):
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
- platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp: Added.
(webKitVideoSinkSetMediaPlayerPrivate):
- platform/graphics/gstreamer/GStreamerVideoSinkCommon.h: Added.
Tools:
- Scripts/webkitpy/style/checker.py:
Add two additional files under the GObject-style exceptions.
- 4:06 AM WebKitGTK/2.36.x edited by
- (diff)
- 4:06 AM Changeset in webkit [290365] by
-
- 5 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r290360 - [GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
https://bugs.webkit.org/show_bug.cgi?id=217655
Stop the run loop for GTK and WPE to ensure a normal exit, since we need
atexit handlers to be called to cleanup resources like EGL displays.
Reviewed by Carlos Garcia Campos.
- Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::didClose):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):
- 4:06 AM Changeset in webkit [290364] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r290299 - Properly uninitialize EGL display before termination
https://bugs.webkit.org/show_bug.cgi?id=236766
From the docs [1], if contexts or surfaces associated with display
is current to any thread, they are not released until they
are no longer current as a result of eglMakeCurrent.
So call eglMakeCurrent() to such effect.
[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml
Reviewed by Carlos Garcia Campos.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::terminateEGLDisplay):
- 3:49 AM Changeset in webkit [290363] by
-
- 1 edit in trunk/Tools/CISupport/ews-build/steps_unittest.py
Use python 3 f-strings in EWS - part 1
https://bugs.webkit.org/show_bug.cgi?id=237053
Reviewed by Ryan Haddad.
- Tools/CISupport/ews-build/steps_unittest.py: Used f-strings for formatting.
(ExpectMasterShellCommand.repr):
(BuildStepMixinAdditions._checkSpawnProcess):
(BuildStepMixinAdditions._send_email):
(TestStepNameShouldBeValidIdentifier.test_step_names_are_valid):
(test_success):
(test_unexpected_failure):
Canonical link: https://commits.webkit.org/247681@main
- 3:44 AM Changeset in webkit [290362] by
-
- 2 edits6 deletes in trunk/LayoutTests
Unreviewed test gardening.
These tests had incorrect expected results with failing tests for
glib.
- platform/glib/TestExpectations:
- platform/glib/webgl/1.0.3/conformance/context/context-lost-restored-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/misc/webgl-specific-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/rendering/point-no-attributes-expected.txt: Removed.
- platform/glib/webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt: Removed.
- 3:23 AM WebKitGTK/StableRelease edited by
- Add 2.36 page (diff)
- 3:22 AM WebKitGTK/2.36.x edited by
- (diff)
- 1:59 AM Changeset in webkit [290361] by
-
- 12 edits in trunk
Thread safety analysis macros are confusing for non-Lock use-cases
https://bugs.webkit.org/show_bug.cgi?id=237022
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-23
Reviewed by Chris Dumez.
Source/WebKit:
Use WTF_GUARDED_BY_CAPABILITY instead of WTF_GUARDED_BY_LOCK
for non-lock use-cases.
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteRenderingBackend.h:
- GPUProcess/graphics/WebGPU/RemoteGPU.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
Source/WTF:
Thread safety analysis proves that a capability is acquired or not acquired.
Change the semantics of thread safety analysis application in WebKit:
Before, we had only one capability, "lock".
After, we have arbitrary amount of capabilities, one of which is "lock".
Add thread safety analysis macros to support non-Lock use-cases better.
Non-lock use-case:
Before:
class WTF_CAPABILITY_LOCK ThreadAssertion { ... };
"WTF::ThreadAssertion is obviously not a lock but we use the lock capability machinery to obtain the analysis support.
It behaves like the lock capability and can be acquired."
After:
class WTF_CAPABILITY("is current") ThreadAssertion { ... };
"WTF::ThreadAssertion has a capability called 'is current' that can be acquired."
The documentation string "lock", "is current" will appear in the compile error messages to clarify the
violations.
- wtf/ThreadAssertions.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
- wtf/ThreadSafetyAnalysis.h:
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- TestWebKitAPI/Tests/WTF/ThreadAssertionsTest.cpp:
(TestWebKitAPI::WTF_REQUIRES_CAPABILITY):
- 1:32 AM Changeset in webkit [290360] by
-
- 5 edits in trunk/Source/WebKit
[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
https://bugs.webkit.org/show_bug.cgi?id=217655
Stop the run loop for GTK and WPE to ensure a normal exit, since we need
atexit handlers to be called to cleanup resources like EGL displays.
Reviewed by Carlos Garcia Campos.
- Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::didClose):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):
- 1:28 AM Changeset in webkit [290359] by
-
- 5 edits in trunk/Source/JavaScriptCore
Ensure generated inline assembler that setups segments returns to previous state
https://bugs.webkit.org/show_bug.cgi?id=236976
Reviewed by Yusuke Suzuki.
Use .previous in inline assembler in order to ensure that mixed emission of assembler
functions and other definitions correctly puts each of them in their rightful sections
in the output object code.
- assembler/MacroAssemblerARM64.cpp:
- assembler/MacroAssemblerARMv7.cpp:
- assembler/MacroAssemblerMIPS.cpp:
- assembler/MacroAssemblerX86Common.cpp:
- 1:12 AM Changeset in webkit [290358] by
-
- 11 edits in trunk/Source/WebKit
RemoteSampleBufferDisplayLayer::enqueueSample should not change media samples owned by its object heap
https://bugs.webkit.org/show_bug.cgi?id=237025
Reviewed by Darin Adler.
From past bugs, it is risky to change CMSampleBuffer dictionaries if they can be used on various threads (encoder, display layer...).
Instead, we create a new MediaSample that is wrapping the same CVPixelBufferRef, on which can safely apply setAsDisplayImmediately.
We introduce SharedVideoFrame as a replacement to RemoteVideoSample.
We beef up SharedVideoFrameWriter and SharedVideoFrameReader to handle any MediaSample,
with specific handling for remote frames, IOSurface frames or other in memory frames.
We make use of SharedVideoFrame in SampleBufferDisplayLayer, which allows to unify enqueueSample and enqueueCV in one IPC message,
which is easier to maintain.
We update call sites that create SharedVideoFrameReader to either take nullptr or a object heap reference when they will need it in the future.
Covered by existing tests.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.messages.in:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
- WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
- 12:50 AM Changeset in webkit [290357] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r289474): [iOS] ASSERTION FAILED: isMainThread() under WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions()
https://bugs.webkit.org/show_bug.cgi?id=237066
<rdar://problem/89324810>
Reviewed by Chris Dumez.
We no longer need the assertion because the function can be called on non-main thread since r289474, where we
started to abort transactions for suspension on WorkQueue. To avoid confusion, rename mainThreadAbortResult to
suspensionAbortResult.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortActiveTransactions):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setSuspensionAbortResult):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::suspensionAbortResult const):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::setMainThreadAbortResult): Deleted.
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::mainThreadAbortResult const): Deleted.
- 12:23 AM Changeset in webkit [290356] by
-
- 4 edits2 adds in trunk
Crash when calling WEBGL_lose_context.loseContext() after the context has been lost
https://bugs.webkit.org/show_bug.cgi?id=236966
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-23
Reviewed by Dean Jackson.
Source/WebCore:
WebGLRenderingContextBase::forceLostContext() would
try to synthesize a GL error to the underlying
m_context. However, m_context is cleared when a real
context loss happens. This happens for example when we
simulate a GPU status failure or when we create too
many contexts. The m_context is not currently cleared
when the page simulates context lost via WEBGL_lose_contexts.loseContext().
Test: webgl/lose-context-after-context-lost.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::synthesizeGLError):
LayoutTests:
- webgl/lose-context-after-context-lost-expected.txt: Added.
- webgl/lose-context-after-context-lost.html: Added.
- 12:16 AM Changeset in webkit [290355] by
-
- 7 edits in trunk/Source
Optimize RemoteVideoFrame handling in WebProcess WebRTC pipeline
https://bugs.webkit.org/show_bug.cgi?id=236970
Reviewed by Eric Carlson.
Source/WebCore:
In case of remote video frame, directly get the remote video frame as a MediaSample in receive side.
On send side, wrap remote video frames as provider-based WebRTC video frames.
LibWebRTCCodecs will optimize the handling of remote frames for hardware encoders and no change will
happen for software encoders.
Covered by existing tests.
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
Source/WebKit:
Fix bug in LibWebRTCCodecsProxy that would make use of shared video frame instead of remote video frame when a shared video frame is available.
Use VideoFrame* as webrtc frame provider for encoding and decoding.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
- WebProcess/GPU/media/RemoteVideoFrameProxy.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
- 12:05 AM Changeset in webkit [290354] by
-
- 5 edits in trunk
Enable WebRTCRemoteVideoFrameEnabled by default in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=236969
Reviewed by Eric Carlson.
Tools:
- WebKitTestRunner/TestOptions.cpp:
LayoutTests:
Disable WebRTCRemoteVideoFrameEnabled for those two tests until we figure out why they fail more with this option.
- fast/mediastream/getUserMedia-to-canvas-1.html:
- fast/mediastream/getUserMedia-to-canvas-2.html:
- 12:04 AM Changeset in webkit [290353] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, non-unified build fix after 247623@main
https://bugs.webkit.org/show_bug.cgi?id=237074
- bindings/js/WebAssemblyCachedScriptSourceProvider.h: Namespace.
Feb 22, 2022:
- 11:35 PM Changeset in webkit [290352] by
-
- 12 edits in trunk
http/wpt/push-api/onpush-disabled.html fails
https://bugs.webkit.org/show_bug.cgi?id=236874
<rdar://problem/89176154>
Reviewed by Youenn Fablet.
Source/WebCore:
Before running the test, we would construct a new WKWebView with the Push API setting disabled.
We would then run the test, which would launch a service worker. Normally, we would expect the
service worker to inherit the settings from the WKWebView. However, it was not reliably
happening because the settings for the service worker are stored on the WebProcessPool and
WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess() was selecting a
random WebProcessPool object (the first one returned by processPools()).
To address the issue, we now pass the ProcessIdentifier of the client that requested the
service worker connection so that establishServiceWorkerContextConnectionToNetworkProcess() can
now prioritize the WebProcessPool of that process. Also, as an optimization, we now prioritize
this client process to run the service worker (assuming it is origin-clean).
No new tests, unskipped existing test.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::createContextConnection):
- workers/service/server/SWServer.h:
Source/WebKit:
Before running the test, we would construct a new WKWebView with the Push API setting disabled.
We would then run the test, which would launch a service worker. Normally, we would expect the
service worker to inherit the settings from the WKWebView. However, it was not reliably
happening because the settings for the service worker are stored on the WebProcessPool and
WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess() was selecting a
random WebProcessPool object (the first one returned by processPools()).
To address the issue, we now pass the ProcessIdentifier of the client that requested the
service worker connection so that establishServiceWorkerContextConnectionToNetworkProcess() can
now prioritize the WebProcessPool of that process. Also, as an optimization, we now prioritize
this client process to run the service worker (assuming it is origin-clean).
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::establishServiceWorkerContextConnectionToNetworkProcess):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess):
- UIProcess/WebProcessPool.h:
LayoutTests:
Unskip test that should no longer be flaky.
- 11:23 PM Changeset in webkit [290351] by
-
- 9 edits in trunk
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046
Reviewed by Devin Rousso and Darin Adler.
Source/WebCore:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
LayoutTests:
Test gardening to take in account new console warning.
- fast/animation/request-animation-frame-during-modal-expected.txt:
- fast/dom/Window/open-window-min-size-expected.txt:
- fast/events/show-modal-dialog-onblur-onfocus-expected.txt:
- http/tests/cookies/document-cookie-after-showModalDialog-expected.txt:
- http/tests/security/navigate-when-restoring-cached-page-expected.txt:
- http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt:
- 11:18 PM Changeset in webkit [290350] by
-
- 37 edits in trunk/Source
Add a URL constructor that takes a String
https://bugs.webkit.org/show_bug.cgi?id=237068
Reviewed by Darin Adler.
Source/JavaScriptCore:
Adopt the new
URL(const String&)constructor.
- API/JSAPIGlobalObject.mm:
(JSC::computeValidImportSpecifier):
Source/WebCore:
Adopt the new
URL(const String&)constructor.
- Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinatorInternal::processAppIdExtension):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::resolveModuleSpecifier):
(WebCore::ScriptModuleLoader::fetch):
(WebCore::ScriptModuleLoader::moduleURL):
(WebCore::ScriptModuleLoader::responseURLFromRequestURL):
(WebCore::ScriptModuleLoader::importModule):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readTerminal):
- contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::RedirectAction::parse):
(WebCore::ContentExtensions::RedirectAction::applyToRequest):
- dom/Document.cpp:
(WebCore::Document::referrer):
- html/URLInputType.cpp:
(WebCore::URLInputType::typeMismatchFor const):
- loader/DocumentLoader.cpp:
(WebCore::microsoftTeamsRedirectURL):
- loader/PrivateClickMeasurement.cpp:
(WebCore::PrivateClickMeasurement::parseAttributionRequestQuery):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::deleteCacheForOrigin):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource):
- loader/archive/mhtml/MHTMLParser.cpp:
(WebCore::MHTMLParser::parseNextPart):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
- page/Quirks.cpp:
(WebCore::isBBCDomain):
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromString):
(WebCore::SecurityOrigin::create):
- page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::toURL const):
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation const):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcMakeRequest):
- platform/gtk/SelectionData.cpp:
(WebCore::SelectionData::setURIList):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setHTTPReferrer):
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformLazyInit):
- platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::didReceiveHeader):
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::platformLazyInit):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeString):
- testing/Internals.cpp:
(WebCore::Internals::sendH2Ping):
Source/WTF:
Add a URL constructor that takes a String to simplify our code base a bit.
- wtf/URL.cpp:
(WTF::URL::truncatedForUseAsBase const):
(WTF::URL::fakeURLWithRelativePart):
(WTF::URL::fileURLWithFileSystemPath):
- wtf/URL.h:
(WTF::URL::URL):
(WTF::URL::decode):
- 10:12 PM Changeset in webkit [290349] by
-
- 26 edits in trunk
Drop StringHasher::hashMemory() and use the modern Hasher instead
https://bugs.webkit.org/show_bug.cgi?id=237049
Source/WebCore:
Reviewed by Sam Weinig and Darin Adler.
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::add):
(WebCore::IDBResourceIdentifierHash::hash):
(WebCore::IDBResourceIdentifier::hash const): Deleted.
- dom/Attribute.h:
(WebCore::add):
- dom/DocumentSharedObjectPool.cpp:
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
(WebCore::attributeHash): Deleted.
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedNameImpl::computeHash const):
- dom/QualifiedName.h:
(WebCore::add):
(WebCore::hashComponents): Deleted.
- dom/QualifiedNameCache.cpp:
(WebCore::QNameComponentsTranslator::hash):
- page/GlobalWindowIdentifier.h:
(WebCore::add):
(WTF::GlobalWindowIdentifierHash::hash):
(WebCore::GlobalWindowIdentifier::hash const): Deleted.
- page/SecurityOriginHash.h:
(WebCore::SecurityOriginHash::hash):
- platform/ScriptExecutionContextIdentifier.h:
(WebCore::add):
(WebCore::ProcessQualified<UUID>::hash const): Deleted.
(WTF::computeHash): Deleted.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::hash const):
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::hash const):
- svg/SVGElementInlines.h:
(WebCore::SVGAttributeHashTranslator::hash):
- workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::hash const): Deleted.
- workers/service/ServiceWorkerRegistrationKey.h:
(WebCore::add):
(WTF::ServiceWorkerRegistrationKeyHash::hash):
Source/WebKitLegacy/mac:
Reviewed by Sam Weinig and Darin Adler.
- History/BinaryPropertyList.cpp:
(add):
(IntegerArrayHash::hash):
Source/WTF:
Reviewed by Sam Weinig and Darin Adler.
- wtf/SchedulePair.h:
(WTF::SchedulePairHash::hash):
- wtf/UUID.cpp:
(WTF::UUID::hash const): Deleted.
- wtf/UUID.h:
(WTF::UUID::isHashTableDeletedValue const):
(WTF::add):
(WTF::UUIDHash::hash):
- wtf/text/StringHasher.h:
(WTF::StringHasher::hashMemory): Deleted.
Tools:
Reviewed by Sam Weinig.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp:
- 10:01 PM Changeset in webkit [290348] by
-
- 3 edits in trunk/Source/WebCore
Create a DOMWindow::printWarningMessage method and start using it in DOMWindow.cpp
https://bugs.webkit.org/show_bug.cgi?id=237047
Reviewed by Darin Adler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::webkitRequestAnimationFrame):
(WebCore::DOMWindow::startListeningForDeviceOrientationIfNecessary):
(WebCore::DOMWindow::startListeningForDeviceMotionIfNecessary):
(WebCore::DOMWindow::printConsoleMessage const):
(WebCore::DOMWindow::printErrorMessage const):
(WebCore::DOMWindow::printWarningMessage const):
- page/DOMWindow.h:
- 9:11 PM Changeset in webkit [290347] by
-
- 1 copy in tags/Safari-614.1.5.1
Tag Safari-614.1.5.1.
- 8:28 PM Changeset in webkit [290346] by
-
- 4 edits in trunk/Source/WebKit
With DOM Rendering in GPU process, every display results in new IOSurface allocation
https://bugs.webkit.org/show_bug.cgi?id=237063
Reviewed by Tim Horton.
We have to avoid ImageBufferRemoteIOSurfaceBackends in the web process from hanging on to
an IOSurface MachSendRight (via ImageBufferBackendHandle) all the time, because doing so
makes the IOSurface appear to be in-use, and therefore not eligible for swapping to,
or making volatile. In particular, swapToValidFrontBuffer() would always think
that the surfaces were in-use, resulting in permanent triple-buffering, and
allocation of a new buffer on every swap.
Fix by clearing the ImageBufferBackendHandles of all the buffers in the WP in
RemoteRenderingBackendProxy::swapToValidFrontBuffer(), so that the GPUP can accurately
gauge in-use-ness; we get back a handle to the new front buffer in the reply,
and this is the only one we need to keep hold of, since it gets transferred to
the UI process.
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfaceNonVolatile):
(WebKit::RemoteRenderingBackend::swapToValidFrontBuffer):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::swapToValidFrontBuffer):
(WebKit::RemoteRenderingBackendProxy::markSurfaceNonVolatile):
- 8:04 PM Changeset in webkit [290345] by
-
- 2 edits in trunk/Source/WebKit
Use non-inline messages for layer volatility-related IPC in RemoteRenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=237061
Reviewed by Wenson Hsieh.
There appears to be a rare issue where StreamClientConnection::sendSync() can hang sometimes,
which makes it impossible to do an entire MotionMark run (rdar://89313626). So avoid this
by making the MarkSurfaceNonVolatile and SwapToValidFrontBuffer use out-of-line encoding.
- GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- 7:54 PM Changeset in webkit [290344] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.1
- 5:54 PM Changeset in webkit [290343] by
-
- 2 edits in trunk/Source/WebKit
Further restrict received IPC boolean values to 0 or 1
https://bugs.webkit.org/show_bug.cgi?id=236801
rdar://85811396
Patch by Simon Lewis <simon.lewis@apple.com> on 2022-02-22
Reviewed by Chris Dumez.
Return std::nullopt if a value larger than 1 is received.
- Platform/IPC/ArgumentCoder.h:
(IPC::ArgumentCoder<bool>::decode):
- 5:34 PM Changeset in webkit [290342] by
-
- 2 edits in trunk/Source/WebCore
Share more code between dispatchSessionStorageEvents() and dispatchLocalStorageEvents()
https://bugs.webkit.org/show_bug.cgi?id=237040
Reviewed by Geoffrey Garen.
- storage/StorageEventDispatcher.cpp:
(WebCore::dispatchStorageEvents):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore::dispatchSessionStorageEventsToWindows): Deleted.
(WebCore::dispatchLocalStorageEventsToWindows): Deleted.
- 5:26 PM Changeset in webkit [290341] by
-
- 3 edits in trunk/Source/WebCore
CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=237002
Reviewed by Darin Adler.
Store URLs in the HashMaps instead of Strings since we have URLs initially and we
need URLs eventually. This avoids having to re-parse the URL unnecessarily, which
is fairly expensive.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::CachedResourceLoader::notifyFinished):
- loader/cache/CachedResourceLoader.h:
- 4:44 PM Changeset in webkit [290340] by
-
- 2 edits in trunk/Tools
REGRESSION(r289580): [ iOS macOS ] TestWebKitAPI.IPCTestingAPI.CanReceiveSharedMemory is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=236744
Unreviewed test gardening.
- TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Disable the test.
(TEST):
- 4:31 PM Changeset in webkit [290339] by
-
- 1 copy in tags/Safari-614.1.5
Tag Safari-614.1.5.
- 4:27 PM Changeset in webkit [290338] by
-
- 2 edits in trunk/Source/WebKit
PingLoader is failing to call completion handler in error case
https://bugs.webkit.org/show_bug.cgi?id=237062
<rdar://50157253>
Reviewed by Chris Dumez.
The completion handler was not being called in the case of a PingLoad being redirected to
a non-HTTP(S) scheme.
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):
- 4:13 PM Changeset in webkit [290337] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening for rdar://86037417.
- platform/mac-wk2/TestExpectations:
- 3:36 PM Changeset in webkit [290336] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] Fix watchOS build
https://bugs.webkit.org/show_bug.cgi?id=237064
Unreviewed.
32-bit devices require some casts.
- WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
- 3:07 PM Changeset in webkit [290335] by
-
- 4 edits1 delete in trunk/Source
Source/WebCore/PAL:
Replace legacy-build-copy-nested-headers.py with an xcodebuild invocation.
https://bugs.webkit.org/show_bug.cgi?id=237011
Reviewed by Alexey Proskuryakov.
r290260 added a script to approximate how XCBuild copies headers to nested directories, for
use in legacy builds. Instead of that script, invokexcodebuild -UseNewBuildSystem=YES
directly to copy nested headers to the build products directory. By taking the same
header-copying codepath, legacy builds can handle header edge cases (e.g. multiple headers
with the same basename) exactly as XCBuild does.
The child xcodebuild process saves incremental data to TARGET_TEMP_DIR, so it can rebuild
incrementally without clobbering the legacy build system's incremental data.
Apple production builds do not use the legacy build system, so this change is
engineering-only.
- PAL.xcodeproj/project.pbxproj:
Source/WTF:
Replace legacy-build-copy-nested-headers.py with an xcodebuild invocation
https://bugs.webkit.org/show_bug.cgi?id=237011
Reviewed by Alexey Proskuryakov.
- Scripts/legacy-build-copy-nested-headers.py: Removed.
- WTF.xcodeproj/project.pbxproj: Remove reference to legacy-build-copy-nested-headers.py.
- 3:02 PM Changeset in webkit [290334] by
-
- 4 edits in trunk/Tools
Remove dormant queues from bot watchers dashboard
https://bugs.webkit.org/show_bug.cgi?id=236809
Reviewed by Alexey Proskuryakov.
- CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
- CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:
Canonical link: https://commits.webkit.org/247655@main
- 1:20 PM Changeset in webkit [290333] by
-
- 3 edits in trunk/Source/WebKit
[WinCairo][WK2] animations/background-position.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=236630
Reviewed by Don Olmstead.
r289848 was a wrong fix causing some test failures. It called the
force repaint completion handler too early if m_waitDidUpdate was
true when the force repaint was requested. In such case, we should
wait for two DidUpdate messages before calling the completion
handler.
- WebProcess/WebPage/wc/DrawingAreaWC.cpp:
(WebKit::DrawingAreaWC::forceRepaintAsync):
(WebKit::DrawingAreaWC::didUpdate):
- WebProcess/WebPage/wc/DrawingAreaWC.h:
Added m_isForceRepaintCompletionHandlerDeferred flag.
- 1:11 PM Changeset in webkit [290332] by
-
- 5 edits in trunk/Tools
[git-webkit] Link to GitHub wiki
https://bugs.webkit.org/show_bug.cgi?id=237048
<rdar://problem/89307995>
Reviewed by Ryan Haddad.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.main): Add GitHub wiki link.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
(TestSetup.test_github):
Canonical link: https://commits.webkit.org/247653@main
- 12:59 PM Changeset in webkit [290331] by
-
- 2 edits in trunk/Source/WTF
Ruby ERB.new compatibility fix
https://bugs.webkit.org/show_bug.cgi?id=237035
Reviewed by Fujii Hironori.
ERB.new has changed its calling convention in newer ruby versions.
This was exposed by https://commits.webkit.org/247450@main, which
tried to silence the warning emitted by newer ruby versions.
Unfortunately, this resulted in failures with older ruby versions
(e.g.
https://build.webkit.org/#/builders/46/builds/11387/steps/8/logs/stdio).
Use the compatibility hack suggested by RuboCop to get this working
across ruby versions (without any warnings).
- Scripts/GeneratePreferences.rb:
- 12:54 PM Changeset in webkit [290330] by
-
- 3 edits2 adds in trunk
null ptr deref via WebXRSystem::requestSession
https://bugs.webkit.org/show_bug.cgi?id=235916
Patch by Frédéric Wang <fwang@igalia.com> on 2022-02-22
Reviewed by Dean Jackson.
Source/WebCore:
WebXRSystem::requestSession() null checks the document's global object via the method
Document::domWindow() and calls WebXRSystem::inlineSessionRequestIsAllowedForGlobalObject()
which dereferences the global object via the method ScriptExecutionContext::globalObject().
The former is just getting a raw pointer from Document::m_domWindow which (once set) remains
non-null until the document is destroyed. The latter instead gets the DOM window via the
document's FrameDestructionObserver::m_frame which is null when document is detached from the
frame. Hence the two methods may disagree, leading to a null ptr deref in
WebXRSystem::inlineSessionRequestIsAllowedForGlobalObject(). This patch works around that
issue by explicitly null checking the result of Document::::globalObject(). Additionally, it
makes the document (and its m_domWindow member) protected earlier in
WebXRSystem::requestSession() i.e. before passing them to potentially complex subroutines
immersiveSessionRequestIsAllowedForGlobalObject() and
inlineSessionRequestIsAllowedForGlobalObject().
Test: webxr/xr-requestSession-crash.html
- Modules/webxr/WebXRSystem.cpp:
(WebCore::WebXRSystem::inlineSessionRequestIsAllowedForGlobalObject const): null-check
document::globalObject() before deferencing it.
(WebCore::WebXRSystem::requestSession): protect document (and its m_domWindow member).
LayoutTests:
Add non-regression test.
- webxr/xr-requestSession-crash-expected.txt: Added.
- webxr/xr-requestSession-crash.html: Added.
- 12:49 PM Changeset in webkit [290329] by
-
- 114 edits in trunk/Source
Clean up / optimize even more call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236852
Reviewed by Darin Adler.
Source/WebCore:
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::beginPaymentSession):
- Modules/applepay/cocoa/PaymentMethodCocoa.mm:
(WebCore::convert):
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::batchPutOperation):
- Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::makeGamepadVisible):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::objectStoreNames const):
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::isDeletedValue const):
(WebCore::add):
(WebCore::IDBKeyDataHash::hash):
(WebCore::IDBKeyData::hash const): Deleted.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::indexNames const):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStoreNames const):
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::showMediaControlsContextMenu):
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::activeRanges const):
- Modules/mediasource/SampleMap.h:
(WebCore::DecodeOrderSampleMap::size const):
- Modules/mediasource/SourceBufferList.h:
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::getVoices):
- Modules/speech/cocoa/WebSpeechRecognizerTask.mm:
(-[WebSpeechRecognizerTaskImpl callbackWithTranscriptions:isFinal:]):
- Modules/speech/cocoa/WebSpeechRecognizerTaskMock.mm:
(-[WebSpeechRecognizerTaskMock audioSamplesAvailable:]):
- animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
- animation/KeyframeEffect.cpp:
(WebCore::processPropertyIndexedKeyframes):
- contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::ContentExtension):
- css/CSSValueList.h:
(WebCore::CSSValueList::size const):
- css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::hoistChildrenWithOperator):
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeContainerRule):
- dom/DOMStringList.h:
(WebCore::DOMStringList::create):
(WebCore::DOMStringList::append):
(WebCore::DOMStringList::DOMStringList):
- dom/EventPath.cpp:
(WebCore::EventPath::EventPath):
- dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::cancelFullscreen):
- dom/LoadableScript.cpp:
(WebCore::LoadableScript::notifyClientFinished):
- dom/RadioButtonGroups.cpp:
(WebCore::RadioButtonGroup::members const):
- html/DirectoryFileListCreator.cpp:
(WebCore::toFileList):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::detachBitmaps):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getAttachedShaders):
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::processMeta):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- loader/ContentFilter.cpp:
(WebCore::ContentFilter::create):
- loader/appcache/ApplicationCacheManifestParser.cpp:
(WebCore::parseApplicationCacheManifest):
- page/ResizeObserver.cpp:
(WebCore::ResizeObserver::deliverObservations):
- page/TextIndicator.cpp:
(WebCore::initializeIndicator):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::parseSubResourceIntegrityIntoDigests):
- platform/FileChooser.cpp:
(WebCore::FileChooser::chooseFile):
(WebCore::FileChooser::chooseFiles):
(WebCore::FileChooser::chooseMediaFiles):
- platform/SharedBuffer.cpp:
(WebCore::FragmentedSharedBuffer::append):
- platform/ThreadSafeDataBuffer.h:
(WebCore::add):
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::initialize):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
- platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
- platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::legibleMediaSelectionOptions const):
- platform/gamepad/mac/Dualshock3HIDGamepad.cpp:
(WebCore::Dualshock3HIDGamepad::Dualshock3HIDGamepad):
- platform/gamepad/mac/LogitechGamepad.cpp:
(WebCore::LogitechGamepad::LogitechGamepad):
- platform/gamepad/mac/StadiaHIDGamepad.cpp:
(WebCore::StadiaHIDGamepad::StadiaHIDGamepad):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::addRepaintRect):
- platform/graphics/PathUtilities.cpp:
(WebCore::PathUtilities::pathsWithShrinkWrappedRects):
(WebCore::PathUtilities::pathWithShrinkWrappedRectsForOutline):
- platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::bufferedSamplesForTrackId):
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSkd):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::setRequestForKey):
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateKeyStatuses):
- platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjC::frameInfos const):
- platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::didParseStreamDataAsAsset):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::variationAxes const):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeString):
- platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::setSupportedPresets):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFilesForIndexedDB):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::connectClippingStackLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::adjustOverflowScrollbarContainerLayers):
- rendering/RenderThemeMac.mm:
(WebCore::paintAttachmentTitleBackground):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGStrokePaintingResource):
- rendering/svg/SVGTextChunk.cpp:
(WebCore::SVGTextChunk::SVGTextChunk):
- style/PageRuleCollector.cpp:
(WebCore::Style::PageRuleCollector::matchPageRules):
- style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::pop):
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertContainerName):
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::outOfBandTrackSources):
- GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::sourceBufferPrivateDidReceiveInitializationSegment):
(WebKit::RemoteSourceBufferProxy::updateTrackIds):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::mergeStatisticForTesting):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
- NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::getOriginsWithPushAndNotificationPermissions):
- NetworkProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::allStorageAreaIdentifiers const):
- NetworkProcess/WebStorage/TransientLocalStorageNamespace.cpp:
(WebKit::TransientLocalStorageNamespace::origins const):
(WebKit::TransientLocalStorageNamespace::storageAreaIdentifiers const):
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::Cache::finishOpening):
(WebKit::CacheStorage::Cache::keys const):
- NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::SQLiteStorageArea::SQLiteStorageArea):
- Platform/IPC/ArgumentCoders.h:
- Shared/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
- UIProcess/API/APINavigation.cpp:
(API::Navigation::Navigation):
(API::m_clientNavigationActivity):
- UIProcess/Cocoa/WKShareSheet.mm:
(appendFilesAsShareableURLs):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::restoreAppHighlightsAndScrollToIndex):
- UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didFinishLoad):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::parameters const):
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::startDiscovery):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::removeAllItems):
(WebKit::WebBackForwardList::clear):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::removeProcessFromOriginCacheSet):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
- UIProcess/ios/TextCheckerIOS.mm:
(WebKit::TextChecker::checkTextOfParagraph):
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::showPaymentUI):
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::setFilesForInputFileUpload):
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::updateTrackIds):
(WebKit::SourceBufferPrivateRemote::sourceBufferPrivateDidReceiveInitializationSegment):
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::createEncoder):
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFrameState):
- WebProcess/WebCoreSupport/WebDeviceOrientationUpdateProvider.cpp:
(WebKit::WebDeviceOrientationUpdateProvider::deviceOrientationChanged):
(WebKit::WebDeviceOrientationUpdateProvider::deviceMotionChanged):
- WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::overriddenTypes):
- WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:
(WebKit::WebSpeechSynthesisClient::voiceList):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches):
- WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::drawRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::consumeSandboxExtensions):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleSelectionServiceClick):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::fetchWebsiteData):
Source/WTF:
- wtf/WorkQueue.cpp:
(WTF::ConcurrentWorkQueue::apply):
- wtf/cf/LanguageCF.cpp:
(WTF::platformUserPreferredLanguages):
- 12:45 PM Changeset in webkit [290328] by
-
- 2 edits in trunk/Source/WebKit
Fix GPUP WebGL generator script wrt uninitialised sized span
https://bugs.webkit.org/show_bug.cgi?id=235889
<rdar://problem/88567612>
Reviewed by Chris Dumez.
Even though we check if the synchronous message was received successfully before using it,
if we didn't check then we might have a problem with pointing to uninitialized memory, which we then wouldn't use for anything.
To fix this hypothetical problem, I start out by pointing to initialized memory.
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::getShaderPrecisionFormat):
- 11:53 AM Changeset in webkit [290327] by
-
- 3 edits in branches/safari-614.1.5-branch/Source/WebKit
Cherry-pick r290317. rdar://problem/89206950
[WebAuthn] Fix lifetime issue on iOS
https://bugs.webkit.org/show_bug.cgi?id=237018
rdar://89206950
Reviewed by Brent Fulgham.
Lifetime issues introduced in a recent refactor of performRequest were causing
replies from WebAuthenticatorCoordinatorProxy_MakeCredentialReply not to make it
back to the web content process. This patch fixes these, allowing requests to proceed.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::continueAfterRequest): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Deleted. (WebKit::WebAuthenticatorCoordinatorProxy::isConditionalMediationAvailable): Deleted. (WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): Deleted.
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:41 AM Changeset in webkit [290326] by
-
- 13 edits2 moves in trunk/Source/WebCore
[LBSE] Rename RenderSVGTransformableContainer -> LegacyRenderSVGTransformableContainer
https://bugs.webkit.org/show_bug.cgi?id=237023
Reviewed by Rob Buis.
Following the established procedure: rename RenderSVGTransformableContainer -> LegacyRenderSVGTransformableContainer.
In a follow-up patch RenderSVGTransformableContainer will be reintroduced for LBSE, inheriting from
RenderSVGContainer instead of LegacyRenderSVGContainer.
Covered by existing tests, no change in behaviour.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderObject.h:
(WebCore::RenderObject::isLegacySVGTransformableContainer const):
(WebCore::RenderObject::isSVGTransformableContainer const): Deleted.
- rendering/svg/LegacyRenderSVGContainer.cpp:
(WebCore::LegacyRenderSVGContainer::layout):
- rendering/svg/LegacyRenderSVGContainer.h:
- rendering/svg/LegacyRenderSVGTransformableContainer.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp.
(WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer):
(WebCore::LegacyRenderSVGTransformableContainer::calculateLocalTransform):
(WebCore::LegacyRenderSVGTransformableContainer::graphicsElement):
- rendering/svg/LegacyRenderSVGTransformableContainer.h: Renamed from Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h.
- rendering/svg/RenderSVGViewportContainer.h:
- rendering/svg/SVGContainerLayout.cpp:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::transformToRootChanged):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::createElementRenderer):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::createElementRenderer):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::createElementRenderer):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::createElementRenderer):
- 11:34 AM Changeset in webkit [290325] by
-
- 5 edits in trunk
[GStreamer] Switch media player to playbin3
https://bugs.webkit.org/show_bug.cgi?id=236884
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-22
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
With GStreamer 1.20 playbin3 is quite usable now, so give it a try as default playback
engine during the 2.38 cycle. If one wants to opt out, set the WEBKIT_GST_USE_PLAYBIN2
environment variable to 1.
No new tests, covered by existing media layout tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Tools:
Replace WEBKIT_GST_USE_PLAYBIN3 with WEBKIT_GST_USE_PLAYBIN2 that allows to opt-out of
playbin3, if this is desired.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
- 11:34 AM Changeset in webkit [290324] by
-
- 3 edits in trunk/Source/WebCore
[LBSE] Activate LBSE for <rect> painting
https://bugs.webkit.org/show_bug.cgi?id=236194
Reviewed by Rob Buis.
Finally activate LBSE for <rect> elements -- painting <rect> elements
now works as expected in LBSE. Try using MiniBrowser and switch
from legacy engine to LBSE and back -- this now works just fine and
rebuilds the render tree / updates display.
Covered by existing tests, no change in behaviour.
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeStyle):
(WebCore::writeChildren):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::createElementRenderer):
- 11:31 AM Changeset in webkit [290323] by
-
- 26 edits2 adds in trunk
[GStreamer] Initial MediaRecorder implementation
https://bugs.webkit.org/show_bug.cgi?id=236558
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-22
Reviewed by Xabier Rodriguez-Calvar.
.:
Enable MediaRecorder support if GStreamer >= 1.20 is available.
- Source/cmake/FindGStreamer.cmake:
- Source/cmake/GStreamerChecks.cmake:
- Source/cmake/GStreamerDefinitions.cmake:
- Source/cmake/GStreamerDependencies.cmake:
Source/WebCore:
Add a MediaRecorder backend based on the GStreamer Transcoder library. We anticipate the
scenario where the GstWebRTC backend might provide encoded streams to the recorder, in which
case transcoding is required. The transcoder library can operate in pass-through as well.
- CMakeLists.txt:
- Modules/mediarecorder/MediaRecorder.cpp:
(WebCore::MediaRecorder::isTypeSupported):
(WebCore::MediaRecorder::createMediaRecorderPrivate):
- Modules/mediarecorder/MediaRecorderProvider.cpp:
(WebCore::MediaRecorderProvider::createMediaRecorderPrivate):
(WebCore::MediaRecorderProvider::isSupported):
- Modules/mediarecorder/MediaRecorderProvider.h:
- loader/EmptyClients.cpp:
- platform/GStreamer.cmake:
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::refGPtr<GstEncodingProfile>):
(WTF::derefGPtr<GstEncodingProfile>):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::initializeEncoders):
- platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp: Added.
(WebCore::MediaRecorderPrivateGStreamer::create):
(WebCore::MediaRecorderPrivateGStreamer::MediaRecorderPrivateGStreamer):
(WebCore::MediaRecorderPrivateGStreamer::~MediaRecorderPrivateGStreamer):
(WebCore::MediaRecorderPrivateGStreamer::startRecording):
(WebCore::MediaRecorderPrivateGStreamer::stopRecording):
(WebCore::MediaRecorderPrivateGStreamer::fetchData):
(WebCore::MediaRecorderPrivateGStreamer::pauseRecording):
(WebCore::MediaRecorderPrivateGStreamer::resumeRecording):
(WebCore::MediaRecorderPrivateGStreamer::mimeType const):
(WebCore::MediaRecorderPrivateGStreamer::isTypeSupported):
(WebCore::MediaRecorderPrivateGStreamer::containerProfile):
(WebCore::MediaRecorderPrivateGStreamer::setSource):
(WebCore::MediaRecorderPrivateGStreamer::setSink):
(WebCore::MediaRecorderPrivateGStreamer::configureVideoEncoder):
(WebCore::MediaRecorderPrivateGStreamer::preparePipeline):
(WebCore::MediaRecorderPrivateGStreamer::processSample):
(WebCore::MediaRecorderPrivateGStreamer::notifyEOS):
- platform/mediarecorder/MediaRecorderPrivateGStreamer.h: Added.
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcEnsureStreamCollectionPosted):
(webkitMediaStreamSrcPadProbeCb):
(webkitMediaStreamSrcSignalEndOfStream):
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml: Enable MediaRecorder if it was
enabled at build time in GStreamer ports.
LayoutTests:
Flag the remaining MediaRecorder test failures. Those will be adressed in follow-up patches.
- http/wpt/mediarecorder/pause-recording.html:
- platform/glib/TestExpectations:
- 11:25 AM Changeset in webkit [290322] by
-
- 6 edits in trunk/Tools
[git-webkit] Extract revision from
git svn dcommit
https://bugs.webkit.org/show_bug.cgi?id=236849
<rdar://problem/89155179>
Reviewed by Ryan Haddad.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git): Thoroughly mock
dcommit
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Extract committed SVN revision from
git svn dcommitcommand to accurately
match landed commits to the pull request that generated them.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(repository): Add revision to local commit.
Canonical link: https://commits.webkit.org/247644@main
- 11:04 AM Changeset in webkit [290321] by
-
- 2 edits in trunk/Source/WebCore
Hide PDF.js sidebar shown for long documents
https://bugs.webkit.org/show_bug.cgi?id=236850
Reviewed by Chris Dumez.
Use the built-in PDF.js
#pagemode=noneparameter to do this: https://github.com/mozilla/pdf.js/wiki/Viewer-options
- html/PDFDocument.cpp:
(WebCore::PDFDocument::createDocumentStructure):
- 11:02 AM Changeset in webkit [290320] by
-
- 10 edits in trunk
[CSS container Queries] getComputedStyle should update style for invalid query containers
https://bugs.webkit.org/show_bug.cgi?id=237038
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/animation-container-size-expected.txt:
- web-platform-tests/css/css-contain/container-queries/animation-container-type-dynamic-expected.txt:
- web-platform-tests/css/css-contain/container-queries/animation-nested-animation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/animation-nested-transition-expected.txt:
- web-platform-tests/css/css-contain/container-queries/aspect-ratio-feature-evaluation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/backdrop-invalidation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-001-expected.txt:
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::hasValidStyleForProperty):
We always need to update style inside a query container since a change to it may affect descendants.
- 10:59 AM Changeset in webkit [290319] by
-
- 14 edits in trunk
Authenticated encryption console logging causing performance regressions
https://bugs.webkit.org/show_bug.cgi?id=236987
<rdar://problem/89108253>
Reviewed by Chris Dumez.
Source/WebCore:
No new tests. Behavior confirmed by existing crypto/subtle tests.
For clients that use repeated unauthenticated AES encryption, console
logging may cause perf issues. We should log the authenticated
encryption warning once per context.
- crypto/SubtleCrypto.cpp:
(WebCore::SubtleCrypto::addAuthenticatedEncryptionWarningIfNecessary):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::hasLoggedAuthenticatedEncryptionWarning const):
(WebCore::ScriptExecutionContext::setHasLoggedAuthenticatedEncryptionWarning):
LayoutTests:
- crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt:
- crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt:
- crypto/subtle/aes-cbc-generate-key-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-import-key-decrypt-expected.txt:
- crypto/subtle/aes-cbc-import-key-encrypt-expected.txt:
- crypto/subtle/aes-ctr-encrypt-malformed-parameters-expected.txt:
- crypto/subtle/aes-ctr-generate-key-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-ctr-import-key-encrypt-expected.txt:
- platform/glib/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt:
- platform/glib/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt:
- 10:29 AM Changeset in webkit [290318] by
-
- 2 edits in trunk/Tools
Filter some build output from JSC
https://bugs.webkit.org/show_bug.cgi?id=236885
Reviewed by Simon Fraser.
Add some filter rules for recently added output. In particular:
- whatever prints out the build command
- python executables now having the version numbers in the binary
- creating entitlements files
- Scripts/filter-build-webkit:
(shouldIgnoreLine):
- 10:21 AM Changeset in webkit [290317] by
-
- 3 edits in trunk/Source/WebKit
[WebAuthn] Fix lifetime issue on iOS
https://bugs.webkit.org/show_bug.cgi?id=237018
rdar://89206950
Reviewed by Brent Fulgham.
Lifetime issues introduced in a recent refactor of performRequest were causing
replies from WebAuthenticatorCoordinatorProxy_MakeCredentialReply not to make it
back to the web content process. This patch fixes these, allowing requests to proceed.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::continueAfterRequest):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest): Deleted.
(WebKit::WebAuthenticatorCoordinatorProxy::isConditionalMediationAvailable): Deleted.
(WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): Deleted.
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
- 9:55 AM Changeset in webkit [290316] by
-
- 3 edits in trunk/Source/WebKit
Remove an unneeded IOKit property
https://bugs.webkit.org/show_bug.cgi?id=236867
<rdar://47695155>
Reviewed by Per Arne Vollan.
The relevant frameworks that used the IOPlatformUUID IOKit
property have been updated to no longer refer to it. We can
now safely remove it.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 9:53 AM Changeset in webkit [290315] by
-
- 2 edits in branches/safari-614.1.5-branch/Source/WebCore
Cherry-pick r290311. rdar://problem/89261425
[Cocoa] Partial rollout of r289946, broke Netflix
https://bugs.webkit.org/show_bug.cgi?id=237019
<rdar://89261425>
Reviewed by Eric Carlson.
Adopting AVContentKeySupport for AVSampleBufferDisplayLayer broke Netflix playback on Cocoa
ports. Disable that support by hard coding sampleBufferRenderersSupportKeySession() to
return false.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::sampleBufferRenderersSupportKeySession):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:50 AM Changeset in webkit [290314] by
-
- 7 edits in trunk
[iOS] Adopt new _UITextSearching method for range comparison
https://bugs.webkit.org/show_bug.cgi?id=237012
rdar://88442811
Reviewed by Devin Rousso.
Source/WebKit:
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView offsetFromPosition:toPosition:inDocument:]):
Mark deprecation.
(-[WKWebView compareFoundRange:toRange:inDocument:]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView compareFoundRange:toRange:inDocument:]):
Implement the new comparison method using existing offset computation logic.
Tools:
Ensure TestSearchAggregator conforms to _UITextSearchAggregator.
- TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(-[TestSearchAggregator initWithCompletionHandler:]):
(-[TestSearchAggregator allFoundRanges]):
(-[TestSearchAggregator invalidateFoundRange:inDocument:]):
(-[TestSearchAggregator invalidate]):
(textRangesForQueryString):
(-[TestSearchAggregator foundRanges]): Deleted.
- 9:44 AM Changeset in webkit [290313] by
-
- 2 edits in trunk/Source/WebCore
Re-style PDF.js form fields to match PDFKit
https://bugs.webkit.org/show_bug.cgi?id=237041
Reviewed by Geoffrey Garen.
Remove black border on :hover, only display light blue background on hover, display blue focusring on :focus.
- Modules/pdfjs-extras/style-cocoa.css:
(.annotationLayer :is():
- 9:42 AM Changeset in webkit [290312] by
-
- 4 edits in trunk/Source
When building introspection files, add CMAKE_C_FLAGS to the compiler flags.
https://bugs.webkit.org/show_bug.cgi?id=232936
Patch by Alexander Kanavin <alex@linutronix.de> on 2022-02-22
Reviewed by Michael Catanzaro.
g-ir-compiler is using a C compiler internally, so it needs to set
the proper flags for it.
- PlatformGTK.cmake:
- 9:11 AM Changeset in webkit [290311] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Partial rollout of r289946, broke Netflix
https://bugs.webkit.org/show_bug.cgi?id=237019
<rdar://89261425>
Reviewed by Eric Carlson.
Adopting AVContentKeySupport for AVSampleBufferDisplayLayer broke Netflix playback on Cocoa
ports. Disable that support by hard coding sampleBufferRenderersSupportKeySession() to
return false.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::sampleBufferRenderersSupportKeySession):
- 9:07 AM Changeset in webkit [290310] by
-
- 3 edits in trunk/Source/WebCore
AX: Only compute ariaTreeRows for isTree() objects
https://bugs.webkit.org/show_bug.cgi?id=236994
Reviewed by Andres Gonzalez.
We only expose AXPropertyName::ARIATreeRows for isTree() objects, but compute it for every object, which is wasteful.
This patch also includes a drive-by fixing of setting AXPropertyName::IsTreeItem. Prior to this patch,
we never set this property. Also, we now only store AXPropertyName::ARIATreeItemContent for isTreeItem() objects.
The AXPropertyName::IsTreeItem fix makes test accessibility/roles-exposed.html closer to passing with ITM enabled.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaTreeRows):
Remove unncessary tab character.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- 9:05 AM Changeset in webkit [290309] by
-
- 3 edits in trunk/Source/WebCore
AX: Fix accessibility/aria-current-state-changed-notification.html in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=237014
Reviewed by Chris Fleizach.
We need to update AXPropertyName::CurrentValue when we get a AXCurrentStateChanged notification.
Fixes accessibility/aria-current-state-changed-notification.html in isolated tree mode.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
- accessibility/isolatedtree/AXIsolatedTree.cpp:
- 8:08 AM Changeset in webkit [290308] by
-
- 2 edits in trunk/Source/WebCore
Fix for crash in several AX LayoutTests in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=237015
Reviewed by Chris Dumez.
Follow up to https://bugs.webkit.org/show_bug.cgi?id=236748.
The iteration over the object's children has to happen over a copy
because the children vector can change during the traversal of the tree.
- accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
- 8:05 AM Changeset in webkit [290307] by
-
- 4 edits in trunk
http/wpt/mediarecorder/mute-tracks.html fails with WebRTCRemoteVideoFrameEnabled=true
https://bugs.webkit.org/show_bug.cgi?id=237021
Reviewed by Kimmo Kinnunen.
Source/WebKit:
We were previously creating the black frame but still sending the remote read reference.
On GPUProcess side, we were then encoding the real frame instead of the black/muted frame.
Add a specific muted code path to fix the issue.
Covered by updated test.
- WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:
(WebKit::MediaRecorderPrivate::videoSampleAvailable):
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameReader::read):
LayoutTests:
- http/wpt/mediarecorder/mute-tracks.html:
- 7:45 AM Changeset in webkit [290306] by
-
- 14 edits6 adds in trunk
Make pointer-events checks for SVG take in account inert subtrees
https://bugs.webkit.org/show_bug.cgi?id=235836
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Added tests for both inert attribute & modal dialog cases.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest-expected.txt: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest.html: Added.
- web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-svg-hittest.tentative.html: Added.
Source/WebCore:
Re-using visibleToHitTesting in SVG code isn't possible, because visibleToHitTesting removes visibility: hidden;
content from hit-testing, which we do not want to here, since pointer-events has values for SVG which still
allow clicking content regardless of their visibility value (pointer-events: painted/fill/stroke/all).
Instead, we add an inert-aware effectivePointerEvents, similar to effectiveUserSelect and re-use that across the codebase.
Tests: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest.html
imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
- rendering/RenderElement.h:
(WebCore::RenderElement::visibleToHitTesting const):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerStyleChanged):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::effectivePointerEvents const):
- rendering/svg/LegacyRenderSVGModelObject.cpp:
(WebCore::LegacyRenderSVGModelObject::checkIntersection):
(WebCore::LegacyRenderSVGModelObject::checkEnclosure):
- rendering/svg/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::nodeAtFloatPoint):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtPoint):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtFloatPoint):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
LayoutTests:
iOS doesn't support test_actions, so it needs different baselines.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt: Added.
- 7:42 AM Changeset in webkit [290305] by
-
- 12 edits in trunk/Source
Rename RenderStyle::userSelectIncludingInert to RenderStyle::effectiveUserSelect
https://bugs.webkit.org/show_bug.cgi?id=237033
Reviewed by Antti Koivisto.
This naming is consistent with other properties (effectiveDisplay/Appearance/PointerEvents/etc.).
Source/WebCore:
- dom/Node.cpp:
(WebCore::computeEditabilityFromComputedStyle):
(WebCore::Node::canStartSelection const):
- dom/Position.cpp:
(WebCore::Position::nodeIsUserSelectNone):
(WebCore::Position::nodeIsUserSelectAll):
- page/EventHandler.cpp:
(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::selectCursor):
- page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionBackgroundColor const):
(WebCore::RenderElement::selectionColor const):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::collectSelectionGeometriesInternal):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::effectiveUserSelect const):
(WebCore::RenderStyle::userSelectIncludingInert const): Deleted.
Source/WebKit:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isSelectableTextNode const):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionPositionInformation):
- 7:33 AM Changeset in webkit [290304] by
-
- 31 edits in trunk/Source
Move service worker and push API preference from RuntimeEnabledFeatures to Settings
https://bugs.webkit.org/show_bug.cgi?id=236989
Reviewed by Youenn Fablet.
Move service worker and push API preference from RuntimeEnabledFeatures to Settings, since RuntimeEnabledFeatures is deprecated.
Source/WebCore:
- Modules/push-api/PushEvent.idl:
- Modules/push-api/PushManager.idl:
- Modules/push-api/PushMessageData.idl:
- Modules/push-api/PushSubscription.idl:
- Modules/push-api/PushSubscriptionChangeEvent.idl:
- Modules/push-api/PushSubscriptionOptions.idl:
- Modules/push-api/ServiceWorkerGlobalScope+PushAPI.idl:
- Modules/push-api/ServiceWorkerRegistration+PushAPI.idl:
- dom/Document.cpp:
(WebCore::Document::suspend):
(WebCore::Document::resume):
(WebCore::Document::finishedParsing):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::matchRegistration):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::unregisterReservedServiceWorkerClient):
(WebCore::DocumentLoader::loadMainResource):
- page/NavigatorBase.cpp:
(WebCore::NavigatorBase::serviceWorker):
- page/NavigatorServiceWorker.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::pushAPIEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setPushAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::serviceWorkerEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setServiceWorkerEnabled): Deleted.
- workers/service/ExtendableEvent.idl:
- workers/service/ExtendableMessageEvent.idl:
- workers/service/FetchEvent.idl:
- workers/service/ServiceWorker.idl:
- workers/service/ServiceWorkerClient.idl:
- workers/service/ServiceWorkerClients.idl:
- workers/service/ServiceWorkerContainer.idl:
- workers/service/ServiceWorkerGlobalScope.idl:
- workers/service/ServiceWorkerRegistration.idl:
- workers/service/ServiceWorkerWindowClient.idl:
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _serviceWorkersEnabled:]):
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::serviceWorkerConnection):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateThrottleState):
(WebKit::WebPage::updatePreferences):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 7:16 AM Changeset in webkit [290303] by
-
- 6 edits in trunk/LayoutTests
Unreviewed, reverting r290220.
Tests still fail with with fuzzy data
Reverted changeset:
"Test gardening for [CSS Blending] Non-separable blend modes
don't work"
https://bugs.webkit.org/show_bug.cgi?id=131354
https://commits.webkit.org/r290220
- 6:10 AM Changeset in webkit [290302] by
-
- 2 edits in trunk/Tools/buildstream
[Flatpak SDK] Update FDO junction for GDB 11.x
https://bugs.webkit.org/show_bug.cgi?id=236979
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-22
Reviewed by Adrian Perez de Castro.
- elements/freedesktop-sdk.bst: gdb 10 is crashy in the current SDK, but was fixed in the
upstream FDO SDK, by updating to the 11.x version.
- 5:35 AM Changeset in webkit [290301] by
-
- 4 edits4 adds in trunk
Permission API: handle non-fully active documents
https://bugs.webkit.org/show_bug.cgi?id=236952
LayoutTests/imported/w3c:
Web Platform Test
https://github.com/web-platform-tests/wpt/pull/32921
Patch by Marcos Caceres <Marcos Caceres> on 2022-02-22
Reviewed by Youenn Fablet.
- web-platform-tests/permissions/non-fully-active.https-expected.txt: Added.
- web-platform-tests/permissions/non-fully-active.https.html: Added.
- web-platform-tests/permissions/resources/empty.html: Added.
Source/WebCore:
Spec change:
https://github.com/w3c/permissions/pull/365
Patch by Marcos Caceres <Marcos Caceres> on 2022-02-22
Reviewed by Youenn Fablet.
Test: imported/w3c/web-platform-tests/permissions/non-fully-active.https.html
- Modules/permissions/PermissionStatus.cpp:
(WebCore::PermissionStatus::stateChanged):
- Modules/permissions/Permissions.cpp:
(WebCore::Permissions::query):
- 5:21 AM Changeset in webkit [290300] by
-
- 25 edits1 copy70 adds in trunk
Initial support for Wasm/ESM-integration in the WebCore module loader
https://bugs.webkit.org/show_bug.cgi?id=236268
Patch by Asumu Takikawa <asumu@igalia.com> on 2022-02-22
Reviewed by Yusuke Suzuki.
LayoutTests/imported/w3c:
Add test suite for Wasm/ESM integration proposal to WPT Wasm WebAPI
tests.
- web-platform-tests/wasm/webapi/esm-integration/execute-start.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/execute-start.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/exported-names.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/exported-names.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/invalid-bytecode.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/invalid-bytecode.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/js-wasm-cycle-errors.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/js-wasm-cycle-errors.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/js-wasm-cycle.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/js-wasm-cycle.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/module-parse-error.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/module-parse-error.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/resolve-export.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resolve-export.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/resolve-export.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/execute-start.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/exported-names.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/invalid-bytecode.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/invalid-module.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-function-error.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-function-error.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-global.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-global.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-memory.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-memory.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-table.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-table.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-value.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle-value.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle.js: Added.
(f):
- web-platform-tests/wasm/webapi/esm-integration/resources/js-wasm-cycle.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/log.js: Added.
(export.logExec):
- web-platform-tests/wasm/webapi/esm-integration/resources/resolve-export.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-export-i64-global.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-export-to-wasm.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-error-from-wasm.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-from-wasm.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-func.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-func.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-global.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-global.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-memory.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-memory.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-table.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-import-table.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-js-cycle.js: Added.
(let.jsFunc):
(export.mutateBindings):
- web-platform-tests/wasm/webapi/esm-integration/resources/wasm-js-cycle.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/worker-helper.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/worker.js: Added.
- web-platform-tests/wasm/webapi/esm-integration/resources/worker.wasm: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-import-wasm-export.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-import-wasm-export.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-import.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-import.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-js-cycle.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-js-cycle.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-to-wasm-link-error.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/wasm-to-wasm-link-error.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/worker-import.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/worker-import.tentative.html: Added.
- web-platform-tests/wasm/webapi/esm-integration/worker.tentative-expected.txt: Added.
- web-platform-tests/wasm/webapi/esm-integration/worker.tentative.html: Added.
Source/JavaScriptCore:
Adjust WebAssemblySourceProvider to inherit from a new abstract base
class that exposes the data as a pointer and size, to allow
implementations other than a Vector. Also add initialization
and cleanup methods managed by RAII class.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- parser/SourceProvider.cpp:
(JSC::BaseWebAssemblySourceProvider::BaseWebAssemblySourceProvider):
- parser/SourceProvider.h:
(JSC::BaseWebAssemblySourceProvider::lockUnderlyingBuffer):
(JSC::BaseWebAssemblySourceProvider::unlockUnderlyingBuffer):
(JSC::WebAssemblySourceProviderBufferGuard::WebAssemblySourceProviderBufferGuard):
(JSC::WebAssemblySourceProviderBufferGuard::~WebAssemblySourceProviderBufferGuard):
- runtime/CachedTypes.cpp:
(JSC::CachedWebAssemblySourceProvider::encode):
- tools/JSDollarVM.cpp:
- wasm/js/JSWebAssemblyHelpers.h:
(JSC::getWasmBufferFromValue):
(JSC::createSourceBufferFromValue):
Source/WebCore:
Add initial WebAssembly script support for WebCore module loading. It
does not yet support Wasm scripts in workers. Detection of Wasm
modules is currently done by MIME type, not by import assertions.
- Headers.cmake:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::hasWasmMIMEType const):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateModule):
- bindings/js/ScriptController.h:
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::evaluate):
(WebCore::ScriptModuleLoader::notifyFinished):
- bindings/js/ScriptModuleLoader.h:
- bindings/js/WebAssemblyCachedScriptSourceProvider.h: Added.
- bindings/js/WebAssemblyScriptSourceCode.h: Copied from Source/JavaScriptCore/parser/SourceProvider.cpp.
(WebCore::WebAssemblyScriptSourceCode::WebAssemblyScriptSourceCode):
(WebCore::WebAssemblyScriptSourceCode::jsSourceCode const):
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedWebAssemblyMIMEType):
- platform/MIMETypeRegistry.h:
- workers/WorkerOrWorkletScriptController.cpp:
(WebCore::WorkerOrWorkletScriptController::evaluateModule):
- workers/WorkerOrWorkletScriptController.h:
Source/WTF:
Add preference flag for Wasm/ESM Integration.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
LayoutTests:
Add Wasm module MIME type for HTTP tests, and add tests.
- http/conf/mime.types:
- http/tests/wasm/resources/empty-module.wasm: Added.
- http/tests/wasm/wasm-esm-disabled-with-setting-expected.txt: Added.
- http/tests/wasm/wasm-esm-disabled-with-setting.html: Added.
- 2:29 AM Changeset in webkit [290299] by
-
- 2 edits in trunk/Source/WebCore
Properly uninitialize EGL display before termination
https://bugs.webkit.org/show_bug.cgi?id=236766
From the docs [1], if contexts or surfaces associated with display
is current to any thread, they are not released until they
are no longer current as a result of eglMakeCurrent.
So call eglMakeCurrent() to such effect.
[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml
Reviewed by Carlos Garcia Campos.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::terminateEGLDisplay):
- 2:25 AM Changeset in webkit [290298] by
-
- 2 edits in trunk/Tools
[JSC] Guard against dead remotes in numberOfProcessors
https://bugs.webkit.org/show_bug.cgi?id=236643
Reviewed by Adrian Perez de Castro.
Instead of using only the first remote (and then defaulting to 1 when
it happens to not respond), try all the remotes in sequence.
Also, instead of trying the sysctl version on all hosts first and
only try nproc after sysctl has failed on all hosts, combine
sysctl and nproc in one command to speed things along.
This change also removes the numProcessors == 0 typo in the rescue
path.
- Scripts/run-jsc-stress-tests:
- 2:14 AM Changeset in webkit [290297] by
-
- 6 edits in trunk
[JSC] ShadowRealm JSRemoteFunction creation should convert CopyNameAndLength errors to TypeError
https://bugs.webkit.org/show_bug.cgi?id=237007
Reviewed by Alexey Shvayka.
JSTests:
- test262/expectations.yaml:
Source/JavaScriptCore:
- Rename JSRemoteFunction::create to tryCreate since it can throw an error.
- Passing JSGlobalObject* as a first parameter to JSRemoteFunction::tryCreate since it can throw an error.
- Extract CopyNameAndLength part and convert errors to TypeError as specified.
- jit/JITOperations.cpp:
(JSC::getWrappedValue):
(JSC::JSC_DEFINE_JIT_OPERATION):
- runtime/JSRemoteFunction.cpp:
(JSC::wrapValue):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSRemoteFunction::tryCreate):
(JSC::JSRemoteFunction::copyNameAndLength):
(JSC::JSRemoteFunction::finishCreation):
(JSC::JSRemoteFunction::create): Deleted.
- runtime/JSRemoteFunction.h:
- 2:08 AM Changeset in webkit [290296] by
-
- 4 edits in trunk
[JSC] TypeError from JSRemoteFunction should be generated by JSRemoteFunction's JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=237013
Reviewed by Saam Barati.
JSTests:
- test262/expectations.yaml:
Source/JavaScriptCore:
Our unwinding converts any errors inside JSRemoteFunction to TypeError. At that time, we should
use JSRemoteFunction's JSGlobalObject for this type error.
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator() const):
(JSC::sanitizeRemoteFunctionException):
(JSC::Interpreter::unwind):
- 1:57 AM WebKitGTK/2.36.x created by
- 1:57 AM WebKitGTK/2.34.x edited by
- (diff)
- 1:47 AM Changeset in webkit [290295] by
-
- 18 edits in trunk/Source
Avoid having to iterate the whole frame tree(s) every time we need to dispatch storage events
https://bugs.webkit.org/show_bug.cgi?id=236985
Reviewed by Darin Adler.
Avoid having to iterate the whole frame tree(s) every time we need to dispatch storage events,
by keeping track of window objects interested in storage events. A Window object is interested
in storage events if both of the following conditions is true:
- It has a Storage object (either localStorage or sessionStorage)
- It has a storage event listener registered.
This patch also refactors the code so that we share more logic between WebKit1 and WebKit2.
Source/WebCore:
- inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::clearDOMStorageItems):
- loader/EmptyClients.cpp:
- page/DOMWindow.cpp:
(WebCore::windowsInterestedInStorageEvents):
(WebCore::DOMWindow::forEachWindowInterestedInStorageEvents):
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachDocumentFromFrame):
(WebCore::DOMWindow::eventListenersDidChange):
- page/DOMWindow.h:
- page/DOMWindowProperty.h:
- storage/Storage.cpp:
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
- storage/StorageArea.h:
- storage/StorageEventDispatcher.cpp:
(WebCore::dispatchSessionStorageEventsToWindows):
(WebCore::dispatchLocalStorageEventsToWindows):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames): Deleted.
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames): Deleted.
- storage/StorageEventDispatcher.h:
Source/WebKit:
- WebProcess/WebStorage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
- WebProcess/WebStorage/StorageAreaImpl.h:
- WebProcess/WebStorage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
(WebKit::framesForEventDispatching): Deleted.
- WebProcess/WebStorage/StorageAreaMap.h:
Source/WebKitLegacy:
- Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
(WebKit::StorageAreaImpl::dispatchStorageEvent):
- Storage/StorageAreaImpl.h:
- 1:42 AM Changeset in webkit [290294] by
-
- 1 copy in releases/WebKitGTK/webkit-2.36
Branch WebKitGTK for 2.36
- 1:24 AM Changeset in webkit [290293] by
-
- 3 edits in trunk/Tools
[GTK] Can't run performance tests due to a11y errors
https://bugs.webkit.org/show_bug.cgi?id=230705
Reviewed by Sergio Villar Senin.
Disable a11y in WTR since it's no longer nedded with ATSPI.
- WebKitTestRunner/gtk/main.cpp:
(main):
- WebKitTestRunner/wpe/main.cpp:
(main):
- 1:05 AM Changeset in webkit [290292] by
-
- 2 edits in trunk/Source/WebKit
NSSharingServicePicker gets deallocated when using the standard share menu item
https://bugs.webkit.org/show_bug.cgi?id=236998
<rdar://problem/89174827>
Reviewed by Wenson Hsieh.
The NSMenuItem should keep the NSSharingServicePicker alive.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::getShareMenuItem):
- 12:47 AM Changeset in webkit [290291] by
-
- 5 edits in trunk/Source/WebKit
[GTK][WPE] Suspend web process after some time in the process cache
https://bugs.webkit.org/show_bug.cgi?id=236971
Reviewed by Michael Catanzaro.
Implement platformSuspendProcess() and platformResumeProcess() for GTK and WPE ports.
- UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::CachedProcess::CachedProcess):
(WebKit::WebProcessCache::CachedProcess::~CachedProcess):
(WebKit::WebProcessCache::CachedProcess::takeProcess):
- UIProcess/WebProcessCache.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):
Feb 21, 2022:
- 10:53 PM Changeset in webkit [290290] by
-
- 20 edits1 add1 delete in trunk/Source
[JSC] Format the output of --reportTotalPhaseTimes=1 more nicely
https://bugs.webkit.org/show_bug.cgi?id=237005
Reviewed by Saam Barati.
Source/JavaScriptCore:
Before this patch:
[B3] moveConstants total ms: 64.307583 max ms: 1.703167
[B3] lowerToAir total ms: 151.297782 max ms: 5.426375
[B3] generateToAir total ms: 1623.987166 max ms: 92.826750
[B3] simplifyCFG total ms: 11.760463 max ms: 1.088083
[B3] Air::lowerMacros total ms: 5.975679 max ms: 0.382000
After this patch:
total ms: 66.328 max ms: 2.283 [B3] moveConstants
total ms: 148.097 max ms: 5.361 [B3] lowerToAir
total ms: 1619.115 max ms: 96.307 [Total B3] generateToAir
total ms: 11.959 max ms: 1.185 [Air] simplifyCFG
total ms: 6.519 max ms: 0.697 [Air] Air::lowerMacros
Concretely there are two changes:
- use FixedWidthDouble (also introduced to WTF in this patch) to line-up the total times. This makes it possible to see at a glance which phases are worth optimizing and which aren't.
- Tag phases more precisely, and in particular replace [B3] by [Air] where relevant, and give different tags to measurements that correspond to groups of phases instead of a single phase (e.g. generateToAir).
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3Compile.cpp:
(JSC::B3::compile):
- b3/B3FixSSA.cpp:
- b3/B3Generate.cpp:
(JSC::B3::prepareForGeneration):
(JSC::B3::generateToAir):
- b3/B3PhaseScope.cpp:
(JSC::B3::PhaseScope::PhaseScope):
- b3/B3PhaseScope.h:
- b3/B3TimingScope.h: Removed.
(JSC::B3::TimingScope::TimingScope): Deleted.
- b3/B3VariableLiveness.cpp:
(JSC::B3::VariableLiveness::VariableLiveness):
- b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
- b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
(JSC::B3::Air::generateWithAlreadyAllocatedRegisters):
- b3/air/AirLiveness.h:
(JSC::B3::Air::Liveness::Liveness):
- b3/air/AirPhaseScope.cpp:
(JSC::B3::Air::PhaseScope::PhaseScope):
- b3/air/AirPhaseScope.h:
- tools/CompilerTimingScope.cpp:
Source/WTF:
Add FixedWidthDouble, which allows easily printing a double with some whitespace to pad it out if it is smaller than expected.
Its design roughly follows RawPointer which similarly allows special formatting of a kind of number.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/FixedWidthDouble.h: Added.
(WTF::FixedWidthDouble::FixedWidthDouble):
(WTF::FixedWidthDouble::value const):
(WTF::FixedWidthDouble::width const):
(WTF::FixedWidthDouble::precision const):
- wtf/PrintStream.cpp:
(WTF::printInternal):
- wtf/PrintStream.h:
- 10:43 PM Changeset in webkit [290289] by
-
- 2 edits in trunk/Tools
Use ArgumentParser for parsing args in generate-compile-commands
https://bugs.webkit.org/show_bug.cgi?id=236995
Patch by Brandon Stewart <Brandon> on 2022-02-21
Reviewed by Alexey Proskuryakov.
Use argument parser instead of sys.argv[1] for getting build dir.
- Scripts/generate-compile-commands:
- 8:57 PM Changeset in webkit [290288] by
-
- 3 edits in trunk/Source/WebKit
Allow adattributiond to start on iOS devices
https://bugs.webkit.org/show_bug.cgi?id=237009
<rdar://89062166>
Reviewed by Per Arne Vollan.
There were three more problems preventing it from starting:
- The code signature said to look for a sandbox profile with "webkit" in the name, but the profile had "WebKit" in the name. These names are case sensitive.
- The sandbox profile would not let it load the WebKit framework, so dyld would fail and the process would fail to launch. I added the framework directories that the XPC services are allowed to access.
- Once it started, it would crash inside WTF::initializeMainThread when calling WTF::pageSize which requires access to the hw.pagesize_compat syscall. As a starting point, I'm going to allow all the syscalls that the network process currently has access to, which is enough to get it to respond without crashing.
- We need access to com.apple.diagnosticd and com.apple.analyticsd in order to be able to generate crash reports. This is quite useful.
Yes, I know I said there were only three problems, but the 4th is so useful I thought I'd put it in the list.
- Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:
- Scripts/process-entitlements.sh:
- 8:57 PM Changeset in webkit [290287] by
-
- 6 edits in trunk/Source
Improve const correctness for SecurityOrigin accessors
https://bugs.webkit.org/show_bug.cgi?id=236983
Reviewed by Chris Dumez.
Source/WebCore:
- loader/SubresourceLoader.h:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::origin const):
(WebCore::CachedResource::origin):
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::origin const):
(WebCore::CachedResourceRequest::origin):
Source/WebKit:
- UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::origin const):
(WebKit::WebNotification::origin):
- 8:03 PM Changeset in webkit [290286] by
-
- 14 edits in trunk
[iOS] Adjust some behaviors around the "Markup Image" action in the callout bar
https://bugs.webkit.org/show_bug.cgi?id=236980
Reviewed by Aditya Keerthi.
Source/WebKit:
Adjust the following behaviors around the "Markup Image" callout bar item on iOS:
- The item should be present as long as the selection range contains a single image item (not only if the
selection range exactly encompasses a single image element.
- The item should appear in the callout bar before other WebKit-client-provided menu controller items.
This patch also adds a new API test to exercise these behaviors and, in doing so, also refactors logic around
determining whether or not to show this item so that it's dependent on a WebKit internal feature instead of just
the system feature flag (with the default value of the internal feature being equal to whether or not the system
feature is enabled). This means we can run tests for these features without requiring the system feature flag to
be enabled.
See below for more details.
Test: ImageAnalysisTests.MenuControllerItems
- Platform/cocoa/TextRecognitionUtilities.mm:
(WebKit::makeTextRecognitionResult):
Drive-by fix for some API tests: only attempt to send the platform image analysis result over IPC if it is a
VKCImageAnalysis. In some API tests, we use mock objects here instead, which currently causes the IPC message
send to fail due to encoding failure.
- Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::defaultImageAnalysisMarkupEnabled):
- Shared/WebPreferencesDefaultValues.h:
Make the new internal feature flag default to the system feature flag.
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
Consult a new delegate method (
-actionSheetAssistantShouldIncludeCopyCroppedImageAction:) instead of checking
the system feature flag directly.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView updateImageAnalysisMarkupMenuItems:]):
Append the "Markup Image" item at the start of the list of additional menu items.
(-[WKContentView canPerformImageAnalysisMarkup]):
Check the internal feature instead of the system feature flag.
(-[WKContentView performImageAnalysisMarkup:]):
Now that this action can be triggered even when the current selection doens't encompass only a single image, we
need to usereplaceWithPasteboardData()instead, passing in the element context of the image element we want
to replace.
(-[WKContentView actionSheetAssistantShouldIncludeCopyCroppedImageAction:]):
Only attempt to show the new items if the internal feature is enabled. Consulted by
WKActionSheetAssistant
above.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Check the internal feature instead of the system feature flag.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const):
Make a minor adjustment here to bail early only if we find multiple image elements in the selected range,
rather than bailing if we find anything that's not an image element.
Source/WTF:
Add a WebKit internal feature flag to control whether or not the "Markup Image" and related "Copy Cropped Image"
menu items should be enabled on iOS and macOS. This enables us to test these features in API and layout tests
without requiring the corresponding system feature flag to be enabled.
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
Add an API test to verify that "Markup Image" appears as the first non-default callout bar item when a single
image element is in the selection range. The test is comprised of three parts:
- Select just a single image, and expect the "Markup Image" item.
- Select all images in the document, and expect no "Markup Image" item.
- Select a single image and some surrounding text, and expect the "Markup Image" item.
See WebKit/ChangeLog for more details.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):
(TestWebKitAPI::swizzledSetMenuItems):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:
Add some text before and after each image so that we can select a single image alongside some text, and exercise
the changes inWebPage::getPlatformEditorState(see WebKit changes for more information).
- 7:57 PM Changeset in webkit [290285] by
-
- 2 edits in trunk/Source/WebCore
Ensure layer has backing during traversal
https://bugs.webkit.org/show_bug.cgi?id=236858
Patch by Brandon Stewart <Brandon> on 2022-02-21
Reviewed by Simon Fraser.
Ensure the layer has a backing attached to it before trying to append
the node id.
- rendering/RenderLayerCompositor.cpp:
(WebCore::collectStationaryLayerRelatedOverflowNodes):
- 7:36 PM Changeset in webkit [290284] by
-
- 22 edits3 adds in trunk
Make input element UA shadow tree creation lazy
https://bugs.webkit.org/show_bug.cgi?id=236747
Reviewed by Aditya Keerthi.
Source/WebCore:
We currently delay InputType creation for parser inserted elements until
just after the attributes have been set, so that we don't wastefully
create an InputType and the UA shadow tree creation if a non-text
type="" was specified on the tag. We don't do anything similar for
script inserted input elements. We could make the InputType creation
lazy, but most of the wasted time is due to the shadow tree creation.
This patch makes InputType shadow tree creation lazy by delaying it
until one of the following happens:
- the element is inserted into the document
- the type="" or value="" attributes are changed before the element is inserted into the document
- any DOM methods that need access to the innerTextElement() are called on the element before the element is inserted into the document
Not all places where we call innerTextElement() on the
HTMLInputElement are safe to lazily create the shadow trees, so we
have two accessors:
- innerTextElement() returns the inner text element if it's been created already
- innerTextElementCreatingShadowSubtreeIfNeeded will perform the lazy shadow tree construction if it hasn't already been done
Since the existing
createShadowSubtreeAndUpdateInnerTextElementEditability function has
more responsibility than just creating the subtree and ensuring the
editability is set appropriately, it's renamed to a more manageable
createShadowSubtree.
This change is a 0.5% progression on Speedometer 2.
Test: fast/forms/lazy-shadow-tree-creation.html
- html/BaseDateAndTimeInputType.h:
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseDateAndTimeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/ColorInputType.h:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/FileInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/InputType.cpp:
(WebCore::InputType::createShadowSubtree):
(WebCore::InputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/RangeInputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
(WebCore::RangeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
- html/SearchInputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
Renamed createShadowSubtreeAndUpdateInnerTextElementEditability to
createShadowSubtree and remove the "isInnerTextElementEditable"
argument, since we can ask the element() for its value if needed.
createShadowSubtree is now also responsible for creating the shadow
root.
- html/TextFieldInputType.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
Renamed. Ensure all shadow tree state is up to date now that it can be
created later.
- html/InputType.h:
- html/InputType.cpp:
(WebCore::InputType::createShadowSubtree):
(WebCore::InputType::hasCreatedShadowSubtree const):
New functions to create the shadow subtree if it hasn't been done
already, and to query whether it's been done.
- html/HTMLInputElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::innerTextElementCreatingShadowSubtreeIfNeeded):
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElementCreatingShadowSubtreeIfNeeded):
- html/HTMLTextFormControlElement.h:
- html/InputType.h:
- html/InputType.cpp:
(WebCore::InputType::innerTextElementCreatingShadowSubtreeIfNeeded):
New functions to first create the shadow subtree before returning
innerTextElement(). HTMLTextAreaElement never lazily creates its
shadow subtree and so just returns innerTextElement().
- html/HTMLInputElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtreeAndUpdateInnerTextElementEditability):
Deleted. Just call through to m_inputType->createShadowTree()
directly.
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::create):
(WebCore::HTMLInputElement::initializeInputType):
(WebCore::HTMLInputElement::updateType):
Don't immediately create the shadow tree.
(WebCore::HTMLInputElement::didFinishInsertingNode):
Create the shadow subtree now that the element's been inserted. No
need to call dataListMayHaveChanged since
TextFieldInputType::createShadowSubtree will now do this.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::updateInnerTextValue):
Ensure the shadow subtree is created since we need to poke at it.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::forwardEvent):
Don't forward the event if the shadow tree hasn't been created yet.
(WebCore::HTMLTextFormControlElement::setSelectionRange):
Ensure the shadow tree has been created. This is needed if the
selection APIs are called on the input element before it's inserted
into the document.
(WebCore::HTMLTextFormControlElement::visiblePositionForIndex const):
Assert that the shadow tree has been created, since editing
functionality should only be needed if the element's been inserted
into the document.
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
Ensure the shadow tree has been created.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::handleTouchEvent):
(WebCore::RangeInputType::handleKeydownEvent):
Ensure the shadow tree has been created in case the event will change
the value.
(WebCore::RangeInputType::sliderTrackElement const):
Only return the element if it's been created.
(WebCore::RangeInputType::typedSliderThumbElement const):
Assert that the element has been created.
(WebCore::RangeInputType::dataListMayHaveChanged):
Only try to re-layout if the shadow tree has been created.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isEmptyValue const):
Avoid creating the shadow subtree.
(WebCore::TextFieldInputType::forwardEvent):
Move the element assertion up to be consistent with other functions.
(WebCore::TextFieldInputType::innerTextElement const):
Don't assert, since this now can legitimately return null.
- html/FileInputType.cpp:
(WebCore::FileInputType::disabledStateChanged):
(WebCore::FileInputType::attributeChanged):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::disabledStateChanged):
(WebCore::RangeInputType::attributeChanged):
(WebCore::RangeInputType::setValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::disabledStateChanged):
(WebCore::TextFieldInputType::readOnlyStateChanged):
(WebCore::TextFieldInputType::updatePlaceholderText):
(WebCore::TextFieldInputType::updateAutoFillButton):
(WebCore::TextFieldInputType::dataListMayHaveChanged):
Don't update the shadow tree contents if it hasn't been created yet.
createShadowTree is responsible for ensuring it creates the shadow
tree contents reflecting the current state.
LayoutTests:
- fast/forms/lazy-shadow-tree-creation-expected.html: Added.
- fast/forms/lazy-shadow-tree-creation.html: Added.
- fast/forms/lazy-shadow-tree-creation.js: Added.
(supportsType):
(makeAndAppendInput):
- 6:16 PM Changeset in webkit [290283] by
-
- 4 edits in trunk
[JSC] Fix ShadowRealm unwinding
https://bugs.webkit.org/show_bug.cgi?id=237001
Reviewed by Saam Barati.
JSTests:
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch fixes a crash bug found by test262. Regardless of it is RemoteFunction,
we should handle it as the same way to the other normal host functions except
for setting m_seenRemoteFunction = true flag. Previously, we are early returning,
this is wrong since we should stop unwinding if the caller is entry frame.
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::operator() const):
- 6:12 PM Changeset in webkit [290282] by
-
- 9 edits in trunk
[JSC] Temporal.PlainDate should validate input range
https://bugs.webkit.org/show_bug.cgi?id=236936
Reviewed by Darin Adler.
JSTests:
- stress/temporal-plaindate.js:
(shouldThrow):
Source/JavaScriptCore:
Implement https://tc39.es/proposal-temporal/#sec-temporal-isodatetimewithinlimits check in
PlainDate to validate input range. For example, 0x7fffffff year should be rejected since
it is larger than ECMAScript datetime representation value. This is checked via ISODateTimeWithinLimits
in the spec.
We also remove isValid assertions in ExactTime. This should not be checked in these accessors, rather,
we should call that function when we would like to check, since PlainDate can represent a bit smaller
value than ExactTime's minValue (minValue - nsPerDay).
We also extend ExactTime::fromISOPartsAndOffset to handle values via Int128 to accept int32_t range years.
By using Int128 for nanoseconds, we can even represent int32_t max / min years. And we remove
ASSERT(y >= -999999 && y <= 999999)check since this is not necessary.
- runtime/ISO8601.cpp:
(JSC::ISO8601::ExactTime::fromISOPartsAndOffset):
(JSC::ISO8601::isDateTimeWithinLimits):
- runtime/ISO8601.h:
(JSC::ISO8601::ExactTime::ExactTime): Deleted.
(JSC::ISO8601::ExactTime::fromEpochSeconds): Deleted.
(JSC::ISO8601::ExactTime::fromEpochMilliseconds): Deleted.
(JSC::ISO8601::ExactTime::fromEpochMicroseconds): Deleted.
(JSC::ISO8601::ExactTime::epochSeconds const): Deleted.
(JSC::ISO8601::ExactTime::epochMilliseconds const): Deleted.
(JSC::ISO8601::ExactTime::epochMicroseconds const): Deleted.
(JSC::ISO8601::ExactTime::epochNanoseconds const): Deleted.
(JSC::ISO8601::ExactTime::nanosecondsFraction const): Deleted.
(JSC::ISO8601::ExactTime::asString const): Deleted.
(JSC::ISO8601::ExactTime::isValid const): Deleted.
(JSC::ISO8601::ExactTime::operator< const): Deleted.
(JSC::ISO8601::ExactTime::operator<= const): Deleted.
(JSC::ISO8601::ExactTime::operator== const): Deleted.
(JSC::ISO8601::ExactTime::operator!= const): Deleted.
(JSC::ISO8601::ExactTime::operator>= const): Deleted.
(JSC::ISO8601::ExactTime::operator> const): Deleted.
- runtime/TemporalPlainDate.cpp:
(JSC::toPlainDate):
Source/WTF:
Add code to allow dataLog(Int128).
- wtf/Int128.cpp:
(WTF::printInternal):
- wtf/Int128.h:
- 6:01 PM Changeset in webkit [290281] by
-
- 9 edits in trunk/LayoutTests
Unreviewed gardening for the GPU Process bots.
- css3/color-filters/color-filter-text-decoration-shadow.html:
- fast/gradients/conic-gradient-alpha-unpremultiplied.html:
- fast/gradients/conic-gradient-alpha.html:
- fast/gradients/linear-two-hints-angle.html:
- fast/scrolling/overflow-inside-foreignobject.html:
- gpu-process/TestExpectations:
- imported/blink/svg/custom/crisp-edges-leak.svg:
- platform/ios/TestExpectations:
- 5:48 PM Changeset in webkit [290280] by
-
- 5 edits in trunk
Add test name to the image diff template
https://bugs.webkit.org/show_bug.cgi?id=237003
Reviewed by Sam Weinig.
Tools:
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
LayoutTests:
Include the test name in the page. Workflow to update fuzzy match data becomes easier to copy-paste the name there instead of from the location bar.
- fast/harness/image-diff-template-expected.txt:
- fast/harness/image-diff-template.html:
- 5:42 PM Changeset in webkit [290279] by
-
- 2 edits in trunk/Source/WebKit
Fix racy parallel build of WebKit2-4.0.gir
https://bugs.webkit.org/show_bug.cgi?id=232935
Patch by Alexander Kanavin <alex@linutronix.de> on 2022-02-21
Reviewed by Michael Catanzaro.
This is a target and not a command because it's used to build another .gir
and a .typelib, which would trigger two racy parallel builds when using command
(e.g. command would run twice, target runs only once).
- PlatformGTK.cmake:
- 5:37 PM Changeset in webkit [290278] by
-
- 4 edits in trunk/Source/WebCore
Add test coverage for the pasteboard writing codepath added in r289839
https://bugs.webkit.org/show_bug.cgi?id=236944
Reviewed by Aditya Keerthi.
Add test coverage for the changes in r289839 in the case where
ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)is turned
on. To do this, we set the platform image analysis results to a new internal mock object,
FakeImageAnalysisResult, that returns a string for a given NSRange. This code is then exercised by several
existing layout tests that copy and paste text inside image overlays:
- fast/images/text-recognition/image-overlay-line-wrapping.html
- fast/images/text-recognition/image-overlay-text-without-leading-whitespace.html
- fast/images/text-recognition/mac/copy-image-overlay-text-with-context-menu.html
- testing/Internals.cpp:
(WebCore::Internals::installImageOverlay):
- testing/Internals.h:
- testing/Internals.mm:
(-[FakeImageAnalysisResult initWithString:]):
(-[FakeImageAnalysisResult _attributedStringForRange:]):
(WebCore::Internals::fakeImageAnalysisResultForTesting):
- 5:13 PM Changeset in webkit [290277] by
-
- 4 edits in trunk/Source
Sort WebCore and WebKit Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=237010
Unreviewed.
Source/WebCore:
No new tests because there is no behavior change.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
- 5:07 PM Changeset in webkit [290276] by
-
- 2 edits in trunk/Source/WebCore/PAL
[WebGPU] Fix build
https://bugs.webkit.org/show_bug.cgi?id=237008
Unreviewed.
If you add a header to PAL that WebKit needs to #include, you'd better mark the header as Private.
- PAL.xcodeproj/project.pbxproj:
- 4:22 PM Changeset in webkit [290275] by
-
- 3 edits in trunk/Source/WebKit
[iOS] Fix the internal build after rdar://88354008
https://bugs.webkit.org/show_bug.cgi?id=236999
Unreviewed build fix.
Mark deprecated implementations.
- UIProcess/API/ios/WKWebViewIOS.mm:
- UIProcess/ios/WKContentViewInteraction.mm:
- 4:05 PM Changeset in webkit [290274] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] Fix release build
https://bugs.webkit.org/show_bug.cgi?id=237004
Unreviewed.
If you include WTF, you must have set NDEBUG in release builds.
- Configurations/Base.xcconfig:
- 3:57 PM Clangd edited by
- (diff)
- 3:50 PM Clangd edited by
- (diff)
- 3:38 PM Clangd edited by
- (diff)
- 3:24 PM Changeset in webkit [290273] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] Fix iOS build
https://bugs.webkit.org/show_bug.cgi?id=237000
The lowPower selector doesn't exist on iOS.
Unreviewed.
- WebGPU/Instance.mm:
(WebGPU::sortedDevices):
(WebGPU::Instance::requestAdapter):
- 3:11 PM Changeset in webkit [290272] by
-
- 8 edits8 copies in trunk
Rolled over to ChangeLog-2022-02-22
- 3:11 PM Changeset in webkit [290271] by
-
- 2 edits in branches/safari-614.1.5-branch/Source/WebKit
Cherry-pick r290237. rdar://problem/58057431
Turn WebGL in GPU Process on by default
https://bugs.webkit.org/show_bug.cgi?id=236382
rdar://58057431
Reviewed by Tim Horton.
- Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultUseGPUProcessForWebGLEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:56 PM Clangd created by
- 2:56 PM WikiStart edited by
- Add wiki page for clangd (diff)
- 2:09 PM Changeset in webkit [290270] by
-
- 13 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 12: Migrate from C function callbacks to blocks
https://bugs.webkit.org/show_bug.cgi?id=236934
Reviewed by Dean Jackson.
For all the C function pointer / userdata pairs, simply create a parallel entry point which accepts a block instead.
- WebGPU/Adapter.mm:
(wgpuAdapterRequestDeviceWithBlock):
- WebGPU/Buffer.mm:
(wgpuBufferMapAsyncWithBlock):
- WebGPU/CommandEncoder.mm:
(wgpuCommandEncoderSetLabel):
- WebGPU/ComputePipeline.mm:
(wgpuComputePipelineSetLabel):
- WebGPU/Device.mm:
(wgpuDeviceCreateComputePipelineAsyncWithBlock):
(wgpuDeviceCreateRenderPipelineAsyncWithBlock):
(wgpuDevicePopErrorScopeWithBlock):
(wgpuDeviceSetDeviceLostCallbackWithBlock):
(wgpuDeviceSetUncapturedErrorCallbackWithBlock):
- WebGPU/Instance.mm:
(wgpuInstanceRequestAdapterWithBlock):
- WebGPU/Queue.mm:
(wgpuQueueOnSubmittedWorkDoneWithBlock):
(wgpuQueueSetLabel):
- WebGPU/RenderPipeline.mm:
(wgpuRenderPipelineSetLabel):
- WebGPU/ShaderModule.mm:
(wgpuShaderModuleGetCompilationInfoWithBlock):
(wgpuShaderModuleSetLabel):
- WebGPU/Surface.mm:
(wgpuSurfaceGetPreferredFormat):
- WebGPU/SwapChain.mm:
(wgpuSwapChainPresent):
- WebGPU/WebGPUExt.h:
- 2:06 PM Changeset in webkit [290269] by
-
- 3 edits1 add in trunk
[JSC] ShadowRealm wrapArgument should check exceptions
https://bugs.webkit.org/show_bug.cgi?id=236984
JSTests:
Reviewed by Alexey Shvayka.
- stress/exception-in-wrap-argument-for-shadow-realm.js: Added.
(shouldThrow):
Source/JavaScriptCore:
rdar://89226554
Reviewed by Alexey Shvayka.
We should check exceptions after wrapArgument.
- runtime/JSRemoteFunction.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- 2:00 PM Changeset in webkit [290268] by
-
- 132 edits18 copies3 moves404 adds5 deletes in trunk/JSTests
[JSC] Update test262
https://bugs.webkit.org/show_bug.cgi?id=236990
Reviewed by Alexey Shvayka.
- test262/expectations.yaml:
- test262/test262-Revision.txt:
- 1:34 PM Changeset in webkit [290267] by
-
- 6 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 11: Implement shader creation methods
https://bugs.webkit.org/show_bug.cgi?id=236933
Reviewed by Dean Jackson.
This implements Device::createShaderModule() and Device::createComputePipeline(). The async versions (neither
the WebGPU nor the Metal flavor) aren't implemented yet; this is just the first basic implementation.
- WebGPU/ComputePipeline.mm:
(WebGPU::createLibrary):
(WebGPU::createConstantValues):
(WebGPU::createFunction):
(WebGPU::createComputePipelineState):
(WebGPU::Device::createComputePipeline):
(WebGPU::Device::createComputePipelineAsync):
- WebGPU/PipelineLayout.h:
- WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::operator== const):
(WebGPU::PipelineLayout::operator!= const):
- WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::create):
- WebGPU/ShaderModule.mm:
(WebGPU::findShaderModuleParameters):
(WebGPU::ShaderModule::createLibrary):
(WebGPU::earlyCompileShaderModule):
(WebGPU::Device::createShaderModule):
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::CompilationMessageData::CompilationMessageData):
(WebGPU::convertMessages):
(WebGPU::ShaderModule::getCompilationInfo):
(WebGPU::ShaderModule::setLabel):
(WebGPU::ShaderModule::convertPipelineLayout):
(WebGPU::ShaderModule::ast const):
(WebGPU::ShaderModule::pipelineLayoutHint const):
(WebGPU::ShaderModule::entryPointInformation const):
- 1:32 PM Changeset in webkit [290266] by
-
- 23 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors
https://bugs.webkit.org/show_bug.cgi?id=236910
Reviewed by Dean Jackson.
By adding a few various trivial functions in classes that need them, this patch completely finishes the
implementation of CommandBuffer, QuerySet, RenderBundle, Sampler, and TextureView classes (other than
their creation functions).
- WebGPU/Buffer.mm:
(WebGPU::Buffer::setLabel):
- WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::commandBuffer const):
- WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
(WebGPU::CommandBuffer::setLabel):
- WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::setLabel):
- WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
(WebGPU::ComputePassEncoder::setLabel):
- WebGPU/ComputePipeline.h:
(WebGPU::ComputePipeline::computePipelineState const):
- WebGPU/ComputePipeline.mm:
(WebGPU::ComputePipeline::ComputePipeline):
(WebGPU::ComputePipeline::setLabel):
- WebGPU/QuerySet.h:
(WebGPU::QuerySet::counterSampleBuffer const):
- WebGPU/QuerySet.mm:
(WebGPU::QuerySet::QuerySet):
(WebGPU::QuerySet::setLabel):
- WebGPU/Queue.mm:
(WebGPU::Queue::Queue):
(WebGPU::Queue::setLabel):
- WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::indirectCommandBuffer const):
- WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
(WebGPU::RenderBundle::setLabel):
- WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
(WebGPU::RenderBundleEncoder::setLabel):
- WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::setLabel):
- WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::renderPipelineState const):
- WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::RenderPipeline::setLabel):
- WebGPU/Sampler.mm:
(WebGPU::Sampler::setLabel):
- WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::library const):
- WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::ShaderModule):
(WebGPU::ShaderModule::setLabel):
- WebGPU/Texture.h:
(WebGPU::Texture::texture const):
- WebGPU/Texture.mm:
(WebGPU::Texture::Texture):
(WebGPU::Texture::setLabel):
- WebGPU/TextureView.mm:
(WebGPU::TextureView::setLabel):
- 1:29 PM Changeset in webkit [290265] by
-
- 4 edits1 add in trunk
[JSC] Add explicit exception check after appendWithoutSideEffects
https://bugs.webkit.org/show_bug.cgi?id=236986
rdar://88258776
Reviewed by Saam Barati.
JSTests:
- stress/array-to-string-oom.js: Added.
Source/JavaScriptCore:
Add exception check after JSStringJoiner::appendWithoutSideEffects call since JSString::value can throw OOM error.
- runtime/ArrayPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::append):
- 1:27 PM Changeset in webkit [290264] by
-
- 13 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 9: Basic implementation of bindings
https://bugs.webkit.org/show_bug.cgi?id=236903
Reviewed by Dean Jackson.
This is a basic implementation of the BindGroup, BindGroupLayout, and PipelineLayout methods.
Eventually we'll want to suballocate multiple BindGroups so they coexist within the same Buffer,
but this is an initial simple implementation that doesn't do that.
- WebGPU/BindGroup.h:
(WebGPU::BindGroup::vertexArgumentBuffer const):
(WebGPU::BindGroup::fragmentArgumentBuffer const):
(WebGPU::BindGroup::computeArgumentBuffer const):
- WebGPU/BindGroup.mm:
(WebGPU::bufferIsPresent):
(WebGPU::samplerIsPresent):
(WebGPU::textureViewIsPresent):
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::BindGroup):
(WebGPU::BindGroup::setLabel):
- WebGPU/BindGroupLayout.h:
(WebGPU::BindGroupLayout::vertexArgumentEncoder const):
(WebGPU::BindGroupLayout::fragmentArgumentEncoder const):
(WebGPU::BindGroupLayout::computeArgumentEncoder const):
- WebGPU/BindGroupLayout.mm:
(WebGPU::isPresent):
(WebGPU::createArgumentDescriptor):
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::BindGroupLayout):
(WebGPU::BindGroupLayout::setLabel):
(WebGPU::BindGroupLayout::encodedLength const):
- WebGPU/Buffer.h:
(WebGPU::Buffer::buffer const):
- WebGPU/Buffer.mm:
(WebGPU::Buffer::Buffer):
- WebGPU/PipelineLayout.h:
(WebGPU::PipelineLayout::create):
(WebGPU::PipelineLayout::numberOfBindGroupLayouts const):
(WebGPU::PipelineLayout::bindGroupLayout const):
- WebGPU/PipelineLayout.mm:
(WebGPU::Device::createPipelineLayout):
(WebGPU::PipelineLayout::PipelineLayout):
(WebGPU::PipelineLayout::setLabel):
- WebGPU/Sampler.h:
(WebGPU::Sampler::samplerState const):
- WebGPU/Sampler.mm:
(WebGPU::Sampler::Sampler):
- WebGPU/TextureView.h:
(WebGPU::TextureView::texture const):
- WebGPU/TextureView.mm:
(WebGPU::TextureView::TextureView):
- 1:20 PM Changeset in webkit [290263] by
-
- 7 edits in trunk/LayoutTests
[WinCairo] Unreviewed test gardening
- platform/wincairo/TestExpectations:
- platform/wincairo/fast/css/font-face-implicit-local-font-expected.txt:
- platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/wincairo/fast/text/international/bidi-override-expected.txt:
- platform/wincairo/fast/text/international/text-combine-image-test-expected.txt:
- platform/wincairo/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt:
- 12:49 PM Changeset in webkit [290262] by
-
- 5 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 8: Basic implementation of device creation routines
https://bugs.webkit.org/show_bug.cgi?id=236902
Reviewed by Dean Jackson.
This is a basic implementation of the Instance, Adapter, and Device methods. Device limits are not
implemented yet, so for now we claim every limits is 0.
- WebGPU/Adapter.mm:
(WebGPU::Adapter::Adapter):
(WebGPU::Adapter::enumerateFeatures):
(WebGPU::Adapter::getLimits):
(WebGPU::Adapter::getProperties):
(WebGPU::Adapter::hasFeature):
(WebGPU::deviceMeetsRequiredLimits):
(WebGPU::Adapter::requestDevice):
- WebGPU/Device.h:
- WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::Device):
(WebGPU::Device::destroy):
(WebGPU::Device::enumerateFeatures):
(WebGPU::Device::getLimits):
(WebGPU::Device::getQueue):
(WebGPU::Device::hasFeature):
(WebGPU::Device::popErrorScope):
(WebGPU::Device::pushErrorScope):
(WebGPU::Device::setDeviceLostCallback):
(WebGPU::Device::setUncapturedErrorCallback):
(WebGPU::Device::setLabel):
- WebGPU/Instance.mm:
(WebGPU::sortedDevices):
(WebGPU::Instance::requestAdapter):
- 12:42 PM Changeset in webkit [290261] by
-
- 4 edits in trunk/Tools
[webkitcorepy] Support local library in existing path
https://bugs.webkit.org/show_bug.cgi?id=236978
<rdar://problem/89237767>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall.register): Handle case where library is in an exisiting sys.path.
Canonical link: https://commits.webkit.org/247586@main
- 12:11 PM Changeset in webkit [290260] by
-
- 5 edits1 add1 delete in trunk/Source
[XCBuild] Use native build phases to copy PAL's headers
https://bugs.webkit.org/show_bug.cgi?id=236683
Reviewed by Alexey Proskuryakov.
Replaces the "Copy PAL Headers" script with a native Headers phase. Xcode copies the headers
to a flattened directory, but we hack around this using build rules. This is a different
approach than we took with WTF <https://bugs.webkit.org/show_bug.cgi?id=235744> but could be
replicated there to remove the one-build-phase-per-directory boilerplate.
The idea is that we have one build rule for each "depth" of headers: Build rule "pal/*.h" is
depth 1 and matches headers like "pal/FileSizeFormatter.h", buld rule "pal/*/*.h" is depth 2
and matches headers like "pal/text/EncodingTables.h", etc.
Each rule uses build setting macros to determine the header's relative path within
/usr/local/include/pal, and copies it there. Having one build rule per depth level is hacky,
but it's superior to adding 23 copy file phases. In the future, we'll simplify this with
<rdar://88771729>.
The legacy build system doesn't support running build rules on headers. To compensate,
legacy builds copy to a separate directory, /usr/local/include/pal_flattened. A script phase
that runs after the native Headers phase copies these flattened headers into the right place.
- Configurations/CopyPALHeaders.xcconfig: Removed.
- Configurations/PAL.xcconfig: Header settings, notably PRIVATE_HEADERS_FOLDER_PATH.
- PAL.xcodeproj/project.pbxproj: Remove target, add phases, set header attrs.
- 12:03 PM Changeset in webkit [290259] by
-
- 48 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 7: Clean up includes a bit
https://bugs.webkit.org/show_bug.cgi?id=236900
Reviewed by Dean Jackson.
We can put includes that literally every file uses into a single place.
- WebGPU/Adapter.h:
- WebGPU/Adapter.mm:
- WebGPU/BindGroup.h:
- WebGPU/BindGroup.mm:
- WebGPU/BindGroupLayout.h:
- WebGPU/BindGroupLayout.mm:
- WebGPU/Buffer.h:
- WebGPU/Buffer.mm:
- WebGPU/CommandBuffer.h:
- WebGPU/CommandBuffer.mm:
- WebGPU/CommandEncoder.h:
- WebGPU/CommandEncoder.mm:
- WebGPU/ComputePassEncoder.h:
- WebGPU/ComputePassEncoder.mm:
- WebGPU/ComputePipeline.h:
- WebGPU/ComputePipeline.mm:
- WebGPU/Device.h:
- WebGPU/Device.mm:
- WebGPU/Instance.h:
- WebGPU/Instance.mm:
- WebGPU/PipelineLayout.h:
- WebGPU/PipelineLayout.mm:
- WebGPU/QuerySet.h:
- WebGPU/QuerySet.mm:
- WebGPU/Queue.h:
- WebGPU/Queue.mm:
- WebGPU/RenderBundle.h:
- WebGPU/RenderBundle.mm:
- WebGPU/RenderBundleEncoder.h:
- WebGPU/RenderBundleEncoder.mm:
- WebGPU/RenderPassEncoder.h:
- WebGPU/RenderPassEncoder.mm:
- WebGPU/RenderPipeline.h:
- WebGPU/RenderPipeline.mm:
- WebGPU/Sampler.h:
- WebGPU/Sampler.mm:
- WebGPU/ShaderModule.h:
- WebGPU/ShaderModule.mm:
- WebGPU/Surface.h:
- WebGPU/Surface.mm:
- WebGPU/SwapChain.h:
- WebGPU/SwapChain.mm:
- WebGPU/Texture.h:
- WebGPU/Texture.mm:
- WebGPU/TextureView.h:
- WebGPU/TextureView.mm:
- WebGPU/config.h:
- 11:58 AM Changeset in webkit [290258] by
-
- 3 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 6: Give a RunLoop to Instance
https://bugs.webkit.org/show_bug.cgi?id=236899
Reviewed by Dean Jackson.
The shared header has a function, wgpuInstanceProcessEvents(), which is supposed
to synchronously call all outstanding callbacks. A natural way to do this is to
hook this up to [NSRunLoop runMode:beforeDate:].
- WebGPU/Instance.h:
(WebGPU::Instance::runLoop const):
(WebGPU::Instance::create): Deleted.
- WebGPU/Instance.mm:
(WebGPU::Instance::create):
(WebGPU::Instance::Instance):
(WebGPU::Instance::createSurface):
(WebGPU::Instance::processEvents):
(wgpuCreateInstance):
- 11:48 AM Changeset in webkit [290257] by
-
- 6 edits2 adds in trunk
[CSS Container Queries] Support nested container queries
https://bugs.webkit.org/show_bug.cgi?id=236963
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/container-nested-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/container-nested.html: Added.
Source/WebCore:
"Style rules defined on an element inside multiple nested container queries apply when all of the wrapping container queries are true for that element."
https://drafts.csswg.org/css-contain-3/#container-rule
Test: imported/w3c/web-platform-tests/css/css-contain/container-queries/container-nested.html
- style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::Style::ElementRuleCollector::containerQueriesMatch):
All nested queries need to match.
(WebCore::Style::ElementRuleCollector::containerQueryMatches): Deleted.
- style/ElementRuleCollector.h:
- style/RuleSet.h:
(WebCore::Style::RuleSet::hasContainerQueries const):
(WebCore::Style:: const):
(WebCore::Style::RuleSet::containerQueryFor const): Deleted.
Return all nested queries.
Don't unnecessarily copy FilteredContainerQuery, refer to the StyleRuleContainer instead.
- style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addChildRules):
- 11:32 AM Changeset in webkit [290256] by
-
- 43 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects
https://bugs.webkit.org/show_bug.cgi?id=236898
Reviewed by Dean Jackson.
Each WebGPU object gets its own backing Metal object.
- WebGPU/Adapter.h:
(WebGPU::Adapter::create):
- WebGPU/Adapter.mm:
(WebGPU::Adapter::Adapter):
- WebGPU/BindGroup.h:
(WebGPU::BindGroup::create):
- WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::BindGroup):
- WebGPU/BindGroupLayout.h:
(WebGPU::BindGroupLayout::create):
- WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::BindGroupLayout):
- WebGPU/Buffer.h:
(WebGPU::Buffer::create):
- WebGPU/Buffer.mm:
(WebGPU::Device::createBuffer):
(WebGPU::Buffer::Buffer):
- WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::create):
- WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
- WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
- WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::finish):
- WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::create):
- WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::ComputePassEncoder):
- WebGPU/ComputePipeline.h:
(WebGPU::ComputePipeline::create):
- WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
(WebGPU::ComputePipeline::ComputePipeline):
(WebGPU::ComputePipeline::getBindGroupLayout):
- WebGPU/Device.h:
(WebGPU::Device::create): Deleted.
- WebGPU/Device.mm:
(WebGPU::Device::create):
(WebGPU::Device::Device):
(WebGPU::Device::getQueue):
- WebGPU/Instance.h:
- WebGPU/Instance.mm:
(WebGPU::Instance::requestAdapter):
(wgpuInstanceRequestAdapter):
- WebGPU/QuerySet.h:
(WebGPU::QuerySet::create):
- WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
(WebGPU::QuerySet::QuerySet):
- WebGPU/Queue.h:
(WebGPU::Queue::create):
- WebGPU/Queue.mm:
(WebGPU::Queue::Queue):
- WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
- WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
- WebGPU/RenderBundleEncoder.h:
(WebGPU::RenderBundleEncoder::create):
- WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::RenderBundleEncoder):
(WebGPU::RenderBundleEncoder::finish):
- WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::create):
- WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
- WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
- WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::RenderPipeline::RenderPipeline):
(WebGPU::RenderPipeline::getBindGroupLayout):
- WebGPU/Sampler.h:
(WebGPU::Sampler::create):
- WebGPU/Sampler.mm:
(WebGPU::Device::createSampler):
(WebGPU::Sampler::Sampler):
- WebGPU/ShaderModule.h:
(WebGPU::ShaderModule::create):
- WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):
(WebGPU::ShaderModule::ShaderModule):
- WebGPU/SwapChain.mm:
(WebGPU::SwapChain::getCurrentTextureView):
- WebGPU/Texture.h:
(WebGPU::Texture::create):
- WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
(WebGPU::Texture::Texture):
(WebGPU::Texture::createView):
- WebGPU/TextureView.h:
(WebGPU::TextureView::create):
- WebGPU/TextureView.mm:
(WebGPU::TextureView::TextureView):
- WebGPU/config.h:
- 11:23 AM Changeset in webkit [290255] by
-
- 15 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 4: Move Device's construction methods to the files of the things they create
https://bugs.webkit.org/show_bug.cgi?id=236891
Reviewed by Dean Jackson.
Device is kind of a factory object, and has lots of methods which create
other objects in the API. To avoid Device.cpp becoming a catch-all place
for tons of unrelated creation routines, this patch moves the routine that
creates an X into X.mm.
- WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
- WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
- WebGPU/Buffer.mm:
(WebGPU::Device::createBuffer):
- WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
- WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
(WebGPU::Device::createComputePipelineAsync):
- WebGPU/Device.mm:
(WebGPU::Device::createBindGroup): Deleted.
(WebGPU::Device::createBindGroupLayout): Deleted.
(WebGPU::Device::createBuffer): Deleted.
(WebGPU::Device::createCommandEncoder): Deleted.
(WebGPU::Device::createComputePipeline): Deleted.
(WebGPU::Device::createComputePipelineAsync): Deleted.
(WebGPU::Device::createPipelineLayout): Deleted.
(WebGPU::Device::createQuerySet): Deleted.
(WebGPU::Device::createRenderBundleEncoder): Deleted.
(WebGPU::Device::createRenderPipeline): Deleted.
(WebGPU::Device::createRenderPipelineAsync): Deleted.
(WebGPU::Device::createSampler): Deleted.
(WebGPU::Device::createShaderModule): Deleted.
(WebGPU::Device::createSwapChain): Deleted.
(WebGPU::Device::createTexture): Deleted.
- WebGPU/PipelineLayout.mm:
(WebGPU::Device::createPipelineLayout):
- WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
- WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
- WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::Device::createRenderPipelineAsync):
- WebGPU/Sampler.mm:
(WebGPU::Device::createSampler):
- WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):
- WebGPU/SwapChain.mm:
(WebGPU::Device::createSwapChain):
- WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
- 11:15 AM Changeset in webkit [290254] by
-
- 2 edits in trunk/Source/WebCore
[LBSE] Implement SVG2 rules to establish a stacking context
https://bugs.webkit.org/show_bug.cgi?id=236193
Reviewed by Rob Buis.
Follow the rules specified in https://www.w3.org/TR/SVG2/render.html#RenderingOrder,
when to create a stacking context. This is necessary to enforce layer creation.
Unlike SVG 1.1, SVG2 defines its whole rendering model, as well as painting operations
such as masking/clipping around the 'stacking-context' term that stems from CSS.
The definition is backwards compatible with SVG 1.1, except for un-spec'ed territory
missing from SVG 1.1, that's now specified for SVG2 (e.g. <foreignObject> + stacking context).
LBSE handles clipping / masking / etc. via RenderLayer, which is also responsbile for
for stacking-context managment. Therefore we need to follow the existing rules to enforce
a stacking context / RenderLayer creation in StyleAdjuster, by enforcing a non-auto 'used z-index'.
Covered by existing tests, no change in behaviour.
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustSVGElementStyle):
- 10:57 AM Changeset in webkit [290253] by
-
- 3 edits in trunk/Source/WebGPU
[WebGPU] Tracer bullet part 3: Tweak WGSL API
https://bugs.webkit.org/show_bug.cgi?id=236889
Reviewed by Dean Jackson.
- Give SuccessfulCheck a move constructor
- Use UniqueRef instead of std::unique_ptr
- Allow specialization constants to be looked up by name
- Model missing pipeline layouts as absent from the HashMap, rather than using an optional type
- WGSL/WGSL.cpp:
(WGSL::prepare):
(WGSL::SuccessfulCheck::~SuccessfulCheck): Deleted.
- WGSL/WGSL.h:
- 10:55 AM Changeset in webkit [290252] by
-
- 3 edits in trunk/Source/WebCore
[WebGPU] Tracer bullet part 2: Fix infinite recursion in GPUDevice::ref()
https://bugs.webkit.org/show_bug.cgi?id=236888
Reviewed by Dean Jackson.
refEventTarget() calls ref() which called refEventTarget(). The solution is
to tell GPUDevice that it's using RefCounted::ref().
- Modules/WebGPU/GPUDevice.cpp:
- Modules/WebGPU/GPUDevice.h:
- 10:23 AM Changeset in webkit [290251] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] WebGPU.xcodeproj cannot be opened on Big Sur's Xcode
https://bugs.webkit.org/show_bug.cgi?id=236982
Unreviewed.
Just change the project version number from 55 to 51, like the rest of the projects in WebKit.
- WebGPU.xcodeproj/project.pbxproj:
- 10:10 AM Changeset in webkit [290250] by
-
- 3 edits in trunk/Source/WebKit
[macOS] Remove resource access in sandbox for older OS versions
https://bugs.webkit.org/show_bug.cgi?id=236975
Reviewed by Brent Fulgham.
Remove access to some resources in sandbox for older OS versions. Access to these resources were initially
added in https://trac.webkit.org/changeset/290180/webkit and https://trac.webkit.org/changeset/290066/webkit,
and was only intended to land on a branch.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:07 AM Changeset in webkit [290249] by
-
- 3 edits2 adds in trunk
Null check parent node in outdentParagraph
https://bugs.webkit.org/show_bug.cgi?id=235914
Patch by Rob Buis <rbuis@igalia.com> on 2022-02-21
Reviewed by Wenson Hsieh.
Source/WebCore:
Null check parent node of enclosing node in outdentParagraph.
Test: editing/execCommand/outdent-paragraph-crash.html
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
LayoutTests:
- editing/execCommand/outdent-paragraph-crash-expected.txt: Added.
- editing/execCommand/outdent-paragraph-crash.html: Added.
- 9:56 AM Changeset in webkit [290248] by
-
- 9 edits in trunk
[JSC] Add CalendarDateTime parsing
https://bugs.webkit.org/show_bug.cgi?id=236886
Reviewed by Dean Jackson.
JSTests:
- stress/temporal-instant.js:
- stress/temporal-plaindate.js:
- stress/temporal-plaintime.js:
Source/JavaScriptCore:
This patch adds calendar parsing code to ISO8601 so that Temporal.Instant / Temporal.PlainDate / Temporal.PlainTime
can parse string with calendar correctly via "from" methods. Currently, we are just ignoring these calendar values,
but we should create a calendar instance from that in a subsequent patch.
- runtime/ISO8601.cpp:
(JSC::ISO8601::canBeCalendar):
(JSC::ISO8601::canBeTimeZone):
(JSC::ISO8601::parseTimeZone):
(JSC::ISO8601::parseCalendar):
(JSC::ISO8601::parseTime):
(JSC::ISO8601::parseDateTime):
(JSC::ISO8601::parseCalendarTime):
(JSC::ISO8601::parseCalendarDateTime):
(JSC::ISO8601::parseInstant):
- runtime/ISO8601.h:
- runtime/TemporalPlainDate.cpp:
(JSC::TemporalPlainDate::from):
- runtime/TemporalPlainTime.cpp:
(JSC::TemporalPlainTime::from):
- 9:50 AM Changeset in webkit [290247] by
-
- 4 edits in trunk
PerformanceObserver: buffered flag not working in Paint Timing
https://bugs.webkit.org/show_bug.cgi?id=225305
<rdar://problem/77746237>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt: This test now passes
Source/WebCore:
Include paint entries when collecting buffered performance entries.
A previously failing W3C test is now marked as passing.
- page/Performance.cpp:
(WebCore::Performance::appendBufferedEntriesByType const): Add the existing FCP entry
- 9:07 AM Changeset in webkit [290246] by
-
- 2 edits in trunk/Source/WebKit
Change IPC encoding of boolean type to use one bit
https://bugs.webkit.org/show_bug.cgi?id=236801
rdar://85811396
Patch by Simon Lewis <simon.lewis@apple.com> on 2022-02-21
Reviewed by Chris Dumez.
This patch ensures that only the lower bit is set in a boolean for IPC messages.
- Platform/IPC/ArgumentCoder.h:
(IPC::ArgumentCoder<bool>::encode):
(IPC::ArgumentCoder<bool>::decode):
- 7:46 AM Changeset in webkit [290245] by
-
- 5 edits5 adds in trunk/LayoutTests
AX: Add test for r290130 (https://trac.webkit.org/changeset/290130/webkit)
https://bugs.webkit.org/show_bug.cgi?id=236848
Reviewed by Chris Fleizach.
- accessibility/dynamically-changing-iframe-remains-accessible-expected.txt: Added.
- accessibility/dynamically-changing-iframe-remains-accessible.html: Added.
- accessibility/resources/purple-pineapple-text.html:
Added so we can switch iframe source between multiple simple documents.
- platform/ios/TestExpectations:
Enable new test.
- platform/mac-wk1/accessibility/dynamically-changing-iframe-remains-accessible-expected.txt: Added.
- resources/accessibility-helper.js:
(sleep): Added.
- 7:24 AM Changeset in webkit [290244] by
-
- 3 edits in trunk/Tools
[run-webkit-tests] Use Python 3 (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=226658
<rdar://problem/78882016>
Reviewed by Dewei Zhu and Stephanie Lewis.
- Tools/CISupport/build-webkit-org/steps.py:
(RunWebKitTests): Change invocation to Python 3.
- Tools/CISupport/build-webkit-org/steps_unittest.py:
Canonical link: https://commits.webkit.org/247569@main
- 7:19 AM Changeset in webkit [290243] by
-
- 2 edits in trunk/Tools
[EWS] Enable GTK and Windows queues for PRs
https://bugs.webkit.org/show_bug.cgi?id=236814
<rdar://problem/89117205>
Reviewed by Ryan Haddad.
- Tools/CISupport/ews-build/config.json:
Canonical link: https://commits.webkit.org/247568@main
- 7:13 AM Changeset in webkit [290242] by
-
- 3 edits1 add in trunk/Tools/buildstream
[Flatpak SDK] Update pango and gtk4
https://bugs.webkit.org/show_bug.cgi?id=236939
Patch by Philippe Normand <pnormand@igalia.com> on 2022-02-21
Reviewed by Adrian Perez de Castro.
Update to GTK 4.6.2, which requires Pango 1.50.x, so also update Pango.
- elements/freedesktop-sdk.bst:
- elements/sdk/gtk.bst:
- patches/fdo-0001-pango-Bump-to-1.50.4.patch: Added.
- 6:31 AM Changeset in webkit [290241] by
-
- 3 edits in trunk
[GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public
https://bugs.webkit.org/show_bug.cgi?id=236962
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-02-21
Reviewed by Chris Lord.
Since it introduces new dependencies, the build option should be public and a fatal error message should be
shown when the option is enabled and any for the dependencies is missing.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
- 6:12 AM Changeset in webkit [290240] by
-
- 2 edits in trunk/Source/WebCore
[IFC][Integration] Take vertical-rl writing mode value into account when converting visual margin/border/padding value to logical
https://bugs.webkit.org/show_bug.cgi?id=236948
Reviewed by Antti Koivisto.
This is in preparation for supporting vertical-rl content.
(Note that the RTL inline direction != the "rl" part of the writing mode.)
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::horizontalLogicalMargin):
(WebCore::LayoutIntegration::verticalLogicalMargin):
(WebCore::LayoutIntegration::logicalBorder):
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateInlineBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::updateFormattingRootGeometryAndInvalidate):
- 1:23 AM Changeset in webkit [290239] by
-
- 4 edits in trunk
Fetching website data may get wrong record after migrating data to general storage directory
https://bugs.webkit.org/show_bug.cgi?id=236905
Reviewed by Chris Dumez.
Source/WebKit:
To decide if an origin has data, we need to not only check if its directory exists but also if the directory is
empty.
Modified existing test to add test coverage.
- NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):
(WebKit::OriginStorageManager::StorageBucket::resolvedIDBStoragePath): directory should be created before moving
files.
(WebKit::OriginStorageManager::StorageBucket::fetchDataTypesInListFromDisk): given that IndexedDB and
LocalStorage can have custom paths, we may just check data by type.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
