Timeline
Mar 10, 2022:
- 11:37 PM Changeset in webkit [291148] by
-
- 6 edits in trunk
[web-animations] mask-origin should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237733
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 11:26 PM Changeset in webkit [291147] by
-
- 7 edits in trunk
[web-animations] font-variant-numeric should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237669
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
We can also add support for animating the font-variant shorthand since
font-variant-numeric is the last of its longhands that was lacking
animation support.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 10:43 PM Changeset in webkit [291146] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] editing/inserting/insert-paragraph-separator-with-inline-table-bold-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=237551
Patch by Frédéric Wang <fwang@igalia.com> on 2022-03-10
Reviewed by Ryosuke Niwa.
- editing/inserting/insert-paragraph-separator-with-inline-table-bold-crash.html: Ensure the
test does not complete before the page load.
- 10:29 PM WebKit Team edited by
- Update location to contributors.json (diff)
- 9:39 PM Changeset in webkit [291145] by
-
- 2 edits in trunk/Source/WebKit
Abandoned memory in NetworkStorageManager::m_temporaryBlobPathsByConnection
https://bugs.webkit.org/show_bug.cgi?id=237734
Reviewed by Chris Dumez.
Remove items from m_temporaryBlobPathsByConnection when connection is closed.
- NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::stopReceivingMessageFromConnection):
- 9:03 PM Changeset in webkit [291144] by
-
- 15 edits3 moves in trunk
EnterPictureInPictureEvent event was renamed to PictureInPictureEvent in spec
https://bugs.webkit.org/show_bug.cgi?id=221083
Reviewed by Youenn Fablet.
Source/WebCore:
Some updates based on the spec changes:
- Rename EnterPictureInPictureEvent.idl to PictureInPictureEvent.idl.
- leavepictureinpicture event should be fired with the Picture-in-Picture window.
(https://github.com/w3c/picture-in-picture/issues/188)
Covered by media/picture-in-picture/picture-in-picture-api-events.html.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:
(WebCore::HTMLVideoElementPictureInPicture::didEnterPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::didExitPictureInPicture):
- Modules/pictureinpicture/PictureInPictureEvent.cpp: Renamed from Source/WebCore/Modules/pictureinpicture/EnterPictureInPictureEvent.cpp.
(WebCore::PictureInPictureEvent::create):
(WebCore::PictureInPictureEvent::PictureInPictureEvent):
- Modules/pictureinpicture/PictureInPictureEvent.h: Renamed from Source/WebCore/Modules/pictureinpicture/EnterPictureInPictureEvent.h.
- Modules/pictureinpicture/PictureInPictureEvent.idl: Renamed from Source/WebCore/Modules/pictureinpicture/EnterPictureInPictureEvent.idl.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- dom/EventNames.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
LayoutTests:
- media/picture-in-picture/picture-in-picture-api-events-expected.txt:
- media/picture-in-picture/picture-in-picture-api-events.html:
Check the picture-in-picture window in the "leavepictureinpicture" event handler.
- 7:22 PM Changeset in webkit [291143] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, non-unified build fix after 248294@main
https://bugs.webkit.org/show_bug.cgi?id=237751
- layout/integration/LayoutIntegrationLineLayout.cpp: Add missing
include.
- 6:35 PM Changeset in webkit [291142] by
-
- 8 edits in trunk/Source/JavaScriptCore
[XCBuild] Emit a discovered dependency file from offlineasm
https://bugs.webkit.org/show_bug.cgi?id=237329
Reviewed by Alexey Proskuryakov.
Xcode needs to know what files offlineasm uses and produces in order to schedule it
correctly in incremental builds. Rather than use generated xcfilelists like WebKit does
elsewhere in the project, emit a depfile from offlineasm based on the parse tree's source
files.
Discovered dependency files ("depfiles") are Makefile-formatted files which list the inputs
used to produce an output. They are emitting during the build to a temporary directory, and
ensure that subsequent incremental builds will re-run offlineasm when any of the included
sources change. This is the same mechanism clang uses to track header dependencies.
Unfortunately, the legacy build system will refuse to execute a script phase or rule that
emits a depfile. To work around this, convert the offlineasm pipeline to be based on build
rules, to be used by XCBuild only. The idea is that LowLevelInterpreter.asm is listed as a
source build file in JSCLLIntSettingsExtractor, JSCLLIntOffsetsExtractor, and
JavaScriptCore. Each target uses a build rule to generate its respective header from
LowLevelInterpreter.asm. Xcode schedules these rule executions before any clang tasks.
The legacy build system avoids executing the rules via EXCLUDED_SOURCE_FILE_NAMES, and
instead uses the existing build phases, which have "(Legacy)" in their names and are now
no-ops under XCBuild.
Aside from working around the legacy build system's limitations, using build rules is
probably a superior way to express what we're doing, as it gives Xcode the opportunity to
compile other objects in parallel, and could be easily extended to compile multiple discrete
asm files should the need arise.
- Configurations/ToolExecutable.xcconfig: Build rules are XCBuild-only.
- JavaScriptCore.xcodeproj/project.pbxproj: Add build rules, rename legacy scripts.
- offlineasm/asm.rb: Add --depfile flag.
- offlineasm/generate_offset_extractor.rb: Add --depfile flag.
- offlineasm/generate_settings_extractor.rb: Add --depfile flag.
- 6:04 PM Changeset in webkit [291141] by
-
- 6 edits3 adds in trunk
Main document is leaking on haaretz.co.il due to lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=237660
<rdar://problem/90035071>
Reviewed by Geoffrey Garen.
Source/WebCore:
When an HTML image uses
loading=lazy, ImageLoader::updateFromElement() may get
called twice. If the image is outside the viewport, the first time ImageLoader::updateFromElement()
is called, we'll request a CachedImage but we'll set m_lazyImageLoadState to LazyImageLoadState::Deferred
and not ask the CachedImage to load. Then, later on, if the HTML image approaches the viewport,
ImageLoader::loadDeferredImage() will get called. It will set m_lazyImageLoadState to LazyImageLoadState::LoadImmediately
and call updateFromElement() again. This time however, updateFromElement() will actually ask the CachedImage
to load.
The issue was that the first time ImageLoader::updateFromElement(), we would set m_lazyImageLoadState to Deferred
and not ask the CachedImage to load but still set m_hasPendingLoadEvent to true. This is problematic if the CachedImage
is not already loaded since no was was started and thus no load event is coming (and no load event may ever come if the
image never approaches the viewport). When updatedHasPendingEvent() is called, it will protect the HTMLImageElement if
m_hasPendingLoadEvent is true, to make sure the image element stays alive long enough for us to dispatch the load event.
With lazy loading, this meant that we would protect the HTMLImageElement right away and undefinitely since no load event
may ever come. This meant that when navigating away from a page with images that are lazily loaded (and not loaded yet),
we would leak the HTMLImageElements (and ImageLoaders), which in turn would keep the Document alive too.
To address the issue, we now make sure that m_hasPendingLoadEvent is no longer set to true when updateFromElement()
is called but the CachedImage is not already loaded and not loading (lazy loading case). When updateFromElement() gets
called the second time (when the lazily loaded image approaches the viewport), we make sure that the m_hasPendingLoadEvent
flag gets set to true then.
Test: fast/dom/lazy-image-loading-document-leak.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::didUpdateCachedImage):
(WebCore::ImageLoader::didStartLoading):
- loader/ImageLoader.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::load):
- loader/cache/CachedImageClient.h:
(WebCore::CachedImageClient::didStartLoading):
LayoutTests:
Add layout test coverage.
- fast/dom/lazy-image-loading-document-leak-expected.txt: Added.
- fast/dom/lazy-image-loading-document-leak.html: Added.
- fast/dom/resources/lazy-image-loading-document-leak-popup.html: Added.
- 5:47 PM Changeset in webkit [291140] by
-
- 4 edits in trunk/Source/WebKit
Fix naming in NetworkProcessProxy::registerRemoteWorkerClientProcess()
https://bugs.webkit.org/show_bug.cgi?id=237737
Reviewed by Geoffrey Garen.
Fix naming in NetworkProcessProxy::registerRemoteWorkerClientProcess() to store referring to
shared workers and add logging.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::registerRemoteWorkerClientProcess):
(WebKit::NetworkProcessProxy::unregisterRemoteWorkerClientProcess):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- 5:20 PM Changeset in webkit [291139] by
-
- 16 edits in trunk/Source
Catalyst JavaScriptCore, WebCore, WebKitLegacy, and WebKit shouldn't be copied to the Secondary Path
https://bugs.webkit.org/show_bug.cgi?id=237748
Reviewed by Mark Lam.
Updated the configuration to exclude copying Catalyst build products to the secondary path.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/ANGLE-dynamic.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/libwebrtc.xcconfig:
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebGPU:
- Configurations/WebGPU.xcconfig:
Source/WebInspectorUI:
- Configurations/WebInspectorUIFramework.xcconfig:
Source/WebKit:
- Configurations/Base.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/Base.xcconfig:
- 4:38 PM Changeset in webkit [291138] by
-
- 8 edits1 move in trunk
[git-webkit] Support multiple metadata locations
https://bugs.webkit.org/show_bug.cgi?id=237395
<rdar://problem/89715863>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): Rename PROJECT_CONFIG_PATH to GIT_CONFIG_EXTENSION.
(Git.config): Use dynamic context.metadata instead of constant.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.init): Use self.metadata instead of constant.
(Scm.metadata): Support multiple locations for this directory.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Use dynamic repository.metadata instead of constant.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
- metadata/git_config_extension: Renamed from metadata/project_config.
- metadata/project_config: Renamed to metadata/git_config_extension.
Canonical link: https://commits.webkit.org/248298@main
- 4:28 PM Changeset in webkit [291137] by
-
- 3 edits in trunk/Source/WebKit
[macOS] WebContent processes crash with XPC_EXIT_REASON_SIGTERM_TIMEOUT when logging out
https://bugs.webkit.org/show_bug.cgi?id=237398
<rdar://88940229>
Reviewed by Alexey Proskuryakov.
Because we don't use RunningBoard on macOS, we leak an OS transaction to control the lifetime of our XPC
services ourselves. However, one of the side effects of leaking this transaction is that the default SIGTERM
handler doesn't cleanly exit our XPC services when logging out or rebooting. This led to crashes with
XPC_EXIT_REASON_SIGTERM_TIMEOUT as termination reason (rdar://88940229).
To address the issue, we now set our own SIGTERM handler that calls _exit(0) to exit cleanly. In the future,
we should likely adopt RunningBoard on macOS and control our lifetime via process assertions instead of
leaking this OS transaction.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::setOSTransaction):
(WebKit::XPCServiceExit):
(WebKit::osTransaction): Deleted.
- 4:15 PM Changeset in webkit [291136] by
-
- 11 edits1 add in trunk
[iOS] Add support for -[UITextInput addTextAlternatives:] on WKContentView
https://bugs.webkit.org/show_bug.cgi?id=237691
rdar://89647018
Reviewed by Aditya Keerthi.
Source/WebKit:
Work towards refactoring support for dictation alternatives on iOS; this patch adds support for an optional,
private UITextInput protocol method on WKContentView, which clients can use to directly insert
NSTextAlternatives for a given string of matching text (i.e., if the given string matches text at or before the
current selection range).
Tests: TextAlternatives.AddTextAlternativesWithMatch
TextAlternatives.AddTextAlternativesWithSelectedMatch
TextAlternatives.AddTextAlternativesWithoutMatch
- Scripts/webkit/messages.py:
(headers_for_type):
Add support for sending WebCore::DictationContext as an IPC message argument.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addDictationAlternative):
Register the dictation alternative (NSTextAlternative) on the page client, and send a message to the web process
to try and insert document markers corresponding to this dictation alternative. If, for whatever reason, we fail
to map dictation alternatives to an editable DOM range, make sure we automatically unregister this text
alternative as well.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView addTextAlternatives:]):
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::addDictationAlternative):
Given a string to match and a dictation alternative identifier context, try to search for the matching string
before (or in) the selection; if found, install the dictation alternatives in the match range, as a document
marker.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Add several basic API tests to exercise the new API; in particular, exercise both cases where the text
alternative's primary text matches before the selection, where it does not match, and where it matches inside
the selection.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/TextAlternatives.mm: Added.
(-[TestWKWebView dictationAlternativesMarkerCount:]):
(TestWebKitAPI::createWebViewForTestingTextAlternatives):
(TestWebKitAPI::TEST):
- TestWebKitAPI/ios/UIKitSPI.h:
- 3:45 PM Changeset in webkit [291135] by
-
- 3 edits in trunk/LayoutTests
[ iOS Mac ] imported/w3c/web-platform-tests/service-workers/service-worker/partitioned-service-worker-matchAll.tentative.https.html is a flaky text failure on all queues
https://bugs.webkit.org/show_bug.cgi?id=237680
Unreviewed test gardening.
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 2:51 PM Changeset in webkit [291134] by
-
- 40 edits in trunk
[IFC][Integration] Enable RenderListItem and RenderListMarker for IFC
https://bugs.webkit.org/show_bug.cgi?id=237497
Reviewed by Antti Koivisto.
Source/WebCore:
This enables horizontal, RTL, "non-same line nested" list items for IFC.
List markers behave as regular inline level boxes except when it comes to vertical align,
when non-image based list markers are aligned as text. Also outside list markers (list-style-position: outside)
have extra (negative) horizontal margin to place them outside of the containing block's border box.
- layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::isWrappableRun):
- layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::inlineLevelBoxAffectsLineBox const):
- layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::isListMarker const):
- layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent):
(WebCore::Layout::toLineRunType):
(WebCore::Layout::Line::Run::Run):
- layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::Run::isBox const):
(WebCore::Layout::Line::Run::isListMarker const):
- layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setBaselineAndLayoutBounds const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
- layout/formattingContexts/inline/InlineLineBoxBuilder.h:
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::isAtSoftWrapOpportunity):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
- layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
- layout/integration/LayoutIntegrationCoverage.h:
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateListItemDimensions):
(WebCore::LayoutIntegration::LineLayout::updateListMarkerDimensions):
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
(WebCore::LayoutIntegration::LineLayout::layout):
- layout/integration/LayoutIntegrationLineLayout.h:
- layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isListMarker const):
(WebCore::Layout::Box::isInsideListMarker const):
(WebCore::Layout::Box::isOutsideListMarker const):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutModernLines):
- rendering/RenderListMarker.h:
LayoutTests:
- fast/replaced/ul-li-word-break-break-word-expected.html: progression. We do not break between the list marker and the content anymore.
- platform/mac/css1/box_properties/margin_right-expected.txt:
- platform/mac/css1/box_properties/padding_right-expected.txt: progressions. Align list marker with the content (like Firefox does).
- platform/mac/css2.1/t0505-c16-descendant-01-e-expected.txt: inline box height progression (not visible)
- platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: usual 1px diff.
- platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt: progression
- platform/mac/fast/lists/002-expected.txt: same as margin_right/padding_right.
- platform/mac/fast/lists/003-expected.txt:
- platform/mac/fast/lists/li-br-expected.txt: same as ul-li-word-break-break-word
- platform/mac/fast/selectors/166-expected.txt: usual 1px diff.
- 2:17 PM Changeset in webkit [291133] by
-
- 18 edits in trunk
[XCBuild] Fix GeneratedSources dependency validation errors
https://bugs.webkit.org/show_bug.cgi?id=237490
Reviewed by Alexey Proskuryakov.
.:
Fixes miscellanous targets which were not specifying their task outputs correctly.
For easier dependency validation testing, Make builds now recognize a VALIDATE_DEPENDENCIES
setting. Building with VALIDATE_DEPENDENCIES=YES or VALIDATE_DEPENDENCIES=YES_ERROR passes
the setting to xcodebuild and sets a magic xattr on the build directory so that product
files in it are validated.
- Makefile.shared:
Source/JavaScriptCore:
Declare JSCBuiltins.cpp in DerivedSources.make. It's created by generate-js-builtins.py but
was never declared as an output.
- DerivedSources-output.xcfilelist: Autogenerated changes.
- DerivedSources.make:
Source/ThirdParty:
In gtest's static library target, replace the folder reference containing headers with file
references for each copied header. This allows XCBuild to correctly plan incremental builds
when these headers change.
- gtest/xcode/Config/StaticLibraryTarget.xcconfig:
- gtest/xcode/gtest.xcodeproj/project.pbxproj:
Source/WebCore:
Declare missing outputs in DerivedSources.make, and merge files from the "Copy Generated
Headers" phase in with the other private headers, since they all go to the same destination.
- DerivedSources-output.xcfilelist: Autogenerated chagnes.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
Tools:
- Scripts/set-webkit-configuration: Add --validate-dependencies option.
- WebKitTestRunner/DerivedSources-input.xcfilelist: Autogenerated changes.
- WebKitTestRunner/DerivedSources.make: Explicitly depend on preprocessor.pm, which is
imported by other scripts but not listed as a dependency.
- 2:00 PM Changeset in webkit [291132] by
-
- 4 edits in trunk/Source/WebKit
MediaSampleCursor should iterate over the samples contained in the MediaSamplesBlock
https://bugs.webkit.org/show_bug.cgi?id=237677
rdar://80869041
Reviewed by Eric Carlson.
No change in observable behaviour for now, as the current code can't
produce MediaSamplesBlock with more than one sub-sample.
Tests will be added in bug 236754.
- Shared/mac/MediaFormatReader/MediaSampleByteRange.h:
- Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:
(WebKit::stepIterator):
(WebKit::MediaSampleCursor::MediaSampleCursor):
(WebKit::MediaSampleCursor::locateIterator const):
(WebKit::MediaSampleCursor::setLocator const):
(WebKit::MediaSampleCursor::locateMediaSample const):
(WebKit::MediaSampleCursor::locateTiming const):
(WebKit::MediaSampleCursor::stepInOrderedMap):
(WebKit::MediaSampleCursor::stepInPresentationTime):
(WebKit::MediaSampleCursor::getMediaSample const):
(WebKit::MediaSampleCursor::getSyncInfo const):
(WebKit::MediaSampleCursor::copyFormatDescription const):
(WebKit::MediaSampleCursor::copySampleLocation const):
- Shared/mac/MediaFormatReader/MediaSampleCursor.h: The Locator type and
the templated code making use of it makes use of strong assumptions that
the iterator can only be made of one type or the other.
As such, the originally obvious solution to expand the Locator type with
a MediaSamplesBlock iterator ended up being overly complex.
So instead we define an additional member m_currentEntry
and will add all the logic handling in the stepIterator method.
It should be noted that while the MediaSampleCursor implements all the
methods of MTPluginSampleCursor; in practice only the following appear used:
- stepInDecodeOrderAndReportStepsTaken
- getSampleTiming
- getSyncInfo
- copyFormatDescription
- 1:50 PM Changeset in webkit [291131] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove unused iOS 14 test results
- platform/ios-14: Removed.
- platform/ios-14-wk2: Removed.
- 1:50 PM Changeset in webkit [291130] by
-
- 6 edits in trunk
[web-animations] mask-clip should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237725
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 1:47 PM Changeset in webkit [291129] by
-
- 6 edits in trunk
[web-animations] scroll-behavior should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237723
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 1:41 PM Changeset in webkit [291128] by
-
- 6 edits in trunk
[web-animations] quotes should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237721
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 1:27 PM Changeset in webkit [291127] by
-
- 4 edits in trunk/Source/WebCore
Document is leaking on haaretz.co.il due to an async script
https://bugs.webkit.org/show_bug.cgi?id=237672
<rdar://problem/90050632>
Reviewed by Geoffrey Garen.
I haven't been able to reproduce this in the context of a layout test, however,
I see the https://acdn.adnxs.com/dmp/async_usersync.html document flakily leaking
on haaretz.co.il due to an async script (sometimes the top document too).
From a memgraph, I can see that the cycle is:
HTMLDocument -> ScriptRunner -> PendingScript (via m_scriptsToExecuteSoon) -> HTMLScriptElement -> HTMLDocument (again)
To address the issue, I updated Document::commonTeardown() to clear all its ScriptRunner's pending scripts, right after
we stop all ActiveDOMObjects. At this point, we no longer want to run script and clearing any pending scripts is critical
since they hold a strong reference to the Document.
I have validated the fix on haaretz.co.il since I wasn't able to write an automated
test for this.
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
- dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::clearPendingScripts):
- dom/ScriptRunner.h:
- 1:25 PM Changeset in webkit [291126] by
-
- 2 edits in trunk/Source/WebKit
Markup dropdown menu not working in Mail compose
https://bugs.webkit.org/show_bug.cgi?id=237726
<rdar://problem/89777983>
Reviewed by Wenson Hsieh.
Partial revert of r290103. No need for standardShareMenu in the
services menu case.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
- 1:10 PM Changeset in webkit [291125] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/ios/TestExpectations: r291034 fixed platform/ios/mediastream/audio-muted-in-background-tab-gpu-process.html.
- 12:15 PM Changeset in webkit [291124] by
-
- 39 edits8 copies1 add in trunk
AX: Support updated WebSpeech API
https://bugs.webkit.org/show_bug.cgi?id=237614
<rdar://problem/89981851>
Reviewed by Andres Gonzalez.
LayoutTests/imported/w3c:
- web-platform-tests/speech-api/SpeechSynthesisErrorEvent-constructor-expected.txt:
- web-platform-tests/speech-api/SpeechSynthesisEvent-constructor-expected.txt:
- web-platform-tests/speech-api/idlharness.window-expected.txt:
Source/WebCore:
Adopt WebSpeech (18 August 2020) changes from
https://wicg.github.io/speech-api/
Tests Fixed:
imported/w3c/web-platform-tests/speech-api/
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/speech/DOMWindow+SpeechSynthesis.idl:
- Modules/speech/DOMWindowSpeechSynthesis.cpp:
(WebCore::DOMWindowSpeechSynthesis::speechSynthesis):
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::Ref<SpeechSynthesis>SpeechSynthesis::create):
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::fireEvent const):
(WebCore::SpeechSynthesis::fireErrorEvent const):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::create): Deleted.
(WebCore::SpeechSynthesis::fireEvent): Deleted.
- Modules/speech/SpeechSynthesis.h:
- Modules/speech/SpeechSynthesis.idl:
- Modules/speech/SpeechSynthesisErrorCode.h: Added.
- Modules/speech/SpeechSynthesisErrorCode.idl: Copied from Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl.
- Modules/speech/SpeechSynthesisErrorEvent.cpp: Copied from Source/WebCore/Modules/speech/SpeechSynthesisEvent.cpp.
(WebCore::SpeechSynthesisErrorEvent::create):
(WebCore::SpeechSynthesisErrorEvent::SpeechSynthesisErrorEvent):
- Modules/speech/SpeechSynthesisErrorEvent.h: Copied from Source/WebCore/Modules/speech/SpeechSynthesisEvent.h.
- Modules/speech/SpeechSynthesisErrorEvent.idl: Copied from Source/WebCore/Modules/speech/SpeechSynthesisEvent.idl.
- Modules/speech/SpeechSynthesisErrorEventInit.h: Copied from Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl.
- Modules/speech/SpeechSynthesisErrorEventInit.idl: Copied from Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl.
- Modules/speech/SpeechSynthesisEvent.cpp:
(WebCore::SpeechSynthesisEvent::create):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):
- Modules/speech/SpeechSynthesisEvent.h:
(WebCore::SpeechSynthesisEvent::utterance const):
(WebCore::SpeechSynthesisEvent::charLength const):
(): Deleted.
- Modules/speech/SpeechSynthesisEvent.idl:
- Modules/speech/SpeechSynthesisEventInit.h: Copied from Source/WebCore/Modules/speech/SpeechSynthesisEvent.h.
(WebCore::SpeechSynthesisEventInit::SpeechSynthesisEventInit):
- Modules/speech/SpeechSynthesisEventInit.idl: Copied from Source/WebCore/Modules/speech/DOMWindow+SpeechSynthesis.idl.
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisUtterance.h:
- Modules/speech/SpeechSynthesisVoice.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- page/SpeechSynthesisClient.h:
- platform/PlatformSpeechSynthesizer.h:
- platform/cocoa/PlatformSpeechSynthesizerCocoa.mm:
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakRangeOfSpeechString:utterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speak):
Source/WebKit:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::boundaryEventOccurred):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::boundaryEventOccurred):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
LayoutTests:
Fixed expectations:
- imported/w3c/web-platform-tests/speech-api/SpeechSynthesisEvent-constructor-expected.txt: Updated.
- imported/w3c/web-platform-tests/speech-api/SpeechSynthesisErrorEvent-constructor-expected.txt: Updated.
- fast/speechsynthesis/speech-synthesis-boundary-events.html: Updated.
- fast/speechsynthesis/speech-synthesis-boundary-events-expected.txt: Updated.
- 11:43 AM Changeset in webkit [291123] by
-
- 85 edits in trunk/Source
Optimize further the passing of data across threads
https://bugs.webkit.org/show_bug.cgi?id=237695
Reviewed by Geoffrey Garen.
Optimize further the passing of data across threads by leveraging the optimized
version of isolatedCopy() on r-value references whenever possible.
Source/JavaScriptCore:
- inspector/remote/RemoteConnectionToTarget.cpp:
(Inspector::RemoteConnectionToTarget::sendMessageToTarget):
- inspector/remote/RemoteConnectionToTarget.h:
- inspector/remote/RemoteControllableTarget.h:
- jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
- runtime/JSGlobalObjectDebuggable.cpp:
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemote):
- runtime/JSGlobalObjectDebuggable.h:
- tools/FunctionOverrides.cpp:
(JSC::FunctionOverrides::initializeOverrideFor):
Source/WebCore:
- Modules/cache/CacheStorageConnection.h:
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::queryCache):
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::toCrossThreadRecordData):
(WebCore::recordsDataFromRecords):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
- Modules/cache/WorkerCacheStorageConnection.h:
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::listDirectory):
- Modules/mediastream/DetachedRTCDataChannel.h:
(WebCore::DetachedRTCDataChannel::DetachedRTCDataChannel):
(WebCore::DetachedRTCDataChannel::decode):
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::detach):
- Modules/mediastream/RTCDataChannel.h:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::create):
(WebCore::Notification::Notification):
- Modules/notifications/Notification.h:
- Modules/push-api/PushSubscriptionData.cpp:
(WebCore::PushSubscriptionData::isolatedCopy const):
(WebCore::PushSubscriptionData::isolatedCopy):
- Modules/push-api/PushSubscriptionData.h:
- Modules/storage/DummyStorageProvider.h:
- Modules/storage/StorageConnection.h:
- Modules/storage/StorageManager.cpp:
(WebCore::StorageManager::persisted):
(WebCore::StorageManager::fileSystemAccessGetDirectory):
- Modules/storage/WorkerStorageConnection.cpp:
(WebCore::WorkerStorageConnection::getPersisted):
(WebCore::WorkerStorageConnection::fileSystemGetDirectory):
- Modules/storage/WorkerStorageConnection.h:
- Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
- Modules/webdatabase/ChangeVersionWrapper.h:
(WebCore::ChangeVersionWrapper::create):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::changeVersion):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
- Modules/webdatabase/SQLError.h:
(WebCore::SQLError::create):
(WebCore::SQLError::SQLError):
- Modules/websockets/ThreadableWebSocketChannel.h:
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveMessageError):
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processFrame):
- Modules/websockets/WebSocketChannel.h:
- Modules/websockets/WebSocketChannelClient.h:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::setURL): Deleted.
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::fail):
(WebCore::WorkerThreadableWebSocketChannel::Peer::fail):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- dom/ExceptionData.h:
(WebCore::ExceptionData::toException const):
(WebCore::ExceptionData::toException):
- inspector/agents/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::sendMessageFromWorkerToFrontend):
- inspector/agents/InspectorWorkerAgent.h:
- page/CacheStorageProvider.h:
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::dispatchMessageFromRemote):
- page/PageDebuggable.h:
- workers/WorkerInspectorProxy.cpp:
(WebCore::WorkerInspectorProxy::sendMessageFromWorkerToFrontend):
- workers/WorkerInspectorProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToDebugger):
- workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
- workers/service/SWClientConnection.h:
- workers/service/ServiceWorkerClientData.cpp:
(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::isolatedCopy):
- workers/service/ServiceWorkerClientData.h:
- workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy const):
(WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy):
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
- workers/service/ServiceWorkerRegistration.h:
- workers/service/ServiceWorkerRegistrationOptions.cpp:
(WebCore::ServiceWorkerRegistrationOptions::isolatedCopy const):
(WebCore::ServiceWorkerRegistrationOptions::isolatedCopy):
- workers/service/ServiceWorkerRegistrationOptions.h:
- workers/service/context/ServiceWorkerDebuggable.cpp:
(WebCore::ServiceWorkerDebuggable::dispatchMessageFromRemote):
- workers/service/context/ServiceWorkerDebuggable.h:
- workers/service/context/ServiceWorkerInspectorProxy.cpp:
(WebCore::ServiceWorkerInspectorProxy::sendMessageToWorker):
(WebCore::ServiceWorkerInspectorProxy::sendMessageFromWorkerToFrontend):
- workers/service/context/ServiceWorkerInspectorProxy.h:
- workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::postMessageToDebugger):
(WebCore::ServiceWorkerThreadProxy::startFetch):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::importRecords):
Source/WebKit:
- NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::didReceiveMessageError):
- NetworkProcess/NetworkSocketChannel.h:
- NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::fileSystemGetDirectory):
- NetworkProcess/storage/NetworkStorageManager.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::dispatchMessageFromRemote):
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Inspector/WebPageDebuggable.cpp:
(WebKit::WebPageDebuggable::dispatchMessageFromRemote):
- UIProcess/Inspector/WebPageDebuggable.h:
- WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::retrieveRecords):
- WebProcess/Cache/WebCacheStorageConnection.h:
- WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::fail):
(WebKit::WebSocketChannel::didReceiveText):
(WebKit::WebSocketChannel::didReceiveMessageError):
- WebProcess/Network/WebSocketChannel.h:
- WebProcess/WebCoreSupport/WebStorageConnection.cpp:
(WebKit::WebStorageConnection::getPersisted):
(WebKit::WebStorageConnection::fileSystemGetDirectory):
- WebProcess/WebCoreSupport/WebStorageConnection.h:
- 11:41 AM Changeset in webkit [291122] by
-
- 6 edits in trunk
[web-animations] grid-template-areas should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237712
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
While we now run the grid-template-areas tests, we have a bug in the way we serialize the value through the
computed style.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 10:56 AM Changeset in webkit [291121] by
-
- 1 copy in tags/Safari-613.1.17.1.11
Tag Safari-613.1.17.1.11.
- 10:46 AM Changeset in webkit [291120] by
-
- 9 edits in branches/safari-613.1.17.1-branch/Source
Versioning.
WebKit-7613.1.17.1.11
- 10:36 AM Changeset in webkit [291119] by
-
- 15 edits in trunk
[web-animations] font-variant-caps should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237662
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/text/TextFlags.cpp:
(WebCore::operator<<):
- platform/text/TextFlags.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontVariantAlternates):
(WebCore::RenderStyle::setFontVariantCaps):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontVariantCaps const):
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- 10:22 AM Changeset in webkit [291118] by
-
- 3 edits2 adds in trunk
[iOS] Netflix.com fails to resume after moving app to background during playback
https://bugs.webkit.org/show_bug.cgi?id=237659
<rdar://88775037>
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-interruption-with-resume-allowing-play.html
When the MediaPlayerPrivateMediaSourceAVFObjC player is asked to play or pause, it notifies
the client (HTMLMediaElement) that its playback state has changed. HTMLMediaElement will in response
call playInternal() or pauseInternal() to ensure that a state change driven by the MediaPlayer
is reflected up to the DOM. However, when an interruption causes the media element to suspend
and pause playback, this results in an additional call to pauseInternal(), which updates the
"state to resume" after an interruption ends to "Paused".
In mediaPlayerPlaybackStateChanged(), only call pauseInternal() or playInternal() if the reported
player state does not match the HTMLMediaElement's own state.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
LayoutTests:
- media/media-source/media-source-interruption-with-resume-allowing-play-expected.txt: Added.
- media/media-source/media-source-interruption-with-resume-allowing-play.html: Added.
- 9:58 AM Changeset in webkit [291117] by
-
- 11 edits in trunk/Source
IndexedDB: free memory used by database connection on low-memory warning
https://bugs.webkit.org/show_bug.cgi?id=237673
Reviewed by Chris Dumez.
Source/WebCore:
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::handleLowMemoryWarning):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleLowMemoryWarning):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
Source/WebKit:
- NetworkProcess/storage/IDBStorageManager.cpp:
(WebKit::IDBStorageManager::handleLowMemoryWarning):
- NetworkProcess/storage/IDBStorageManager.h:
- NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::handleLowMemoryWarning):
- 9:56 AM Changeset in webkit [291116] by
-
- 2 edits in trunk/Source/WTF
Enable Permissions API by default on Cocoa ports
https://bugs.webkit.org/show_bug.cgi?id=237699
Reviewed by Brent Fulgham.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 9:28 AM WebKitGTK/2.36.x edited by
- (diff)
- 8:47 AM Changeset in webkit [291115] by
-
- 11 edits in trunk
[web-animations] font-variant-position should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237671
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/text/TextFlags.cpp:
(WebCore::operator<<):
- platform/text/TextFlags.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontVariantAlternates):
(WebCore::RenderStyle::setFontVariantPosition):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontVariantPosition const):
- 8:43 AM Changeset in webkit [291114] by
-
- 7 edits in trunk
[web-animations] font-variant-ligatures should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237667
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 8:34 AM Changeset in webkit [291113] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, non-unified build fix after 248260@main
https://bugs.webkit.org/show_bug.cgi?id=237715
- css/ContainerQuery.h: Add missing include.
- 8:31 AM Changeset in webkit [291112] by
-
- 2 edits in trunk/Tools
[EWS] Add DEFAULT_BRANCH variable
https://bugs.webkit.org/show_bug.cgi?id=237693
<rdar://problem/90067276>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(ShowIdentifier.evaluateCommand):
(CheckOutPullRequest.run):
(CleanGitRepo.init):
Canonical link: https://commits.webkit.org/248274@main
- 8:25 AM Changeset in webkit [291111] by
-
- 8 edits in trunk
REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
https://bugs.webkit.org/show_bug.cgi?id=233861
Unreviewed, manual revert of 284711.
Patch by Philippe Normand <pnormand@igalia.com> on 2022-03-10
Source/WebCore:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::currentTimeFudgeFactor):
- platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::timeFudgeFactor const):
- platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::toGstClockTime):
- platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::bufferTimeToStreamTime): Deleted.
LayoutTests:
- platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
- 8:01 AM Changeset in webkit [291110] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, reverting r290795.
Caused crashes <rdar://problem/89970722>
Reverted changeset:
"[macOS] WebContent processes crash with
XPC_EXIT_REASON_SIGTERM_TIMEOUT when logging out"
https://bugs.webkit.org/show_bug.cgi?id=237398
https://commits.webkit.org/r290795
- 7:57 AM Changeset in webkit [291109] by
-
- 7 edits in trunk
[web-animations] font-variant-east-asian should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237665
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 7:52 AM Changeset in webkit [291108] by
-
- 21 edits in trunk/Source/WebCore
Use PropertyRegistry consistently in svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=237604
Patch by Rob Buis <rbuis@igalia.com> on 2022-03-10
Reviewed by Martin Robinson.
Use PropertyRegistry consistently in svgAttributeChanged by always checking
PropertyRegistry::isKnownAttribute first thing, before delegating to subclasses.
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::svgAttributeChanged):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::svgAttributeChanged):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::svgAttributeChanged):
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGeometryElement.cpp:
(WebCore::SVGGeometryElement::svgAttributeChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::svgAttributeChanged):
- 7:27 AM Changeset in webkit [291107] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GStreamer gardening
- platform/glib/TestExpectations: media/video-src-blob-perf.html is failing actually.
- 6:23 AM Changeset in webkit [291106] by
-
- 159 edits6 copies1 move16 adds2 deletes in trunk
Add context.roundRect support to OffScreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=232780
<rdar://problem/85366210>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Updated baselines with PASS.
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.dompointinit.single.argument-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.1.radius.double.single.argument-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.1.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.2.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.2.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.1.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.2.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.3.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.3.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.3.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.1.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.2.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.3.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.3.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.3.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.4.dompoint-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.4.dompointinit-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.4.double-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.closed-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.end.1-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.end.2-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.end.3-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.end.4-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.negative-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.newsubpath-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.nonfinite-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.radius.intersecting.1-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.radius.intersecting.2-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.radius.negative-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.radius.none-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.radius.toomany-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.selfintersect-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.winding-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.1-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.2-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.3-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.4-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.5-expected.txt:
- web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.zero.6-expected.txt:
- web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt:
- web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompointinit-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.1.radius.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompointinit-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.1.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompointinit-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.2.radii.2.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.1.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.1.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.dompointinit-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.2.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.3.radii.3.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.3.radii.3.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.1.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.1.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.2.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.2.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.3.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.3.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompoint-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompoint.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompointinit-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.roundrect.4.radii.4.dompointinit-expected.txt.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.dompointinit.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.double-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.4.radii.4.double.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.closed-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.closed.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.1-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.2-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.3-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.4-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.end.4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.negative-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.negative.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.newsubpath-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.newsubpath.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.nonfinite-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.nonfinite.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.intersecting.1-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.intersecting.1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.intersecting.2-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.intersecting.2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.negative-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.negative.worker-expected.txt: Added.
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.none-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.none.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.toomany-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.radius.toomany.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.selfintersect-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.selfintersect.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.winding-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.winding.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.1-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.1.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.2-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.2.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.3-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.3.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.4-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.4.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.5-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.5.worker-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.6-expected.txt:
- web-platform-tests/html/canvas/offscreen/path-objects/2d.path.roundrect.zero.6.worker-expected.txt:
- web-platform-tests/html/dom/idlharness.https-expected.txt:
- web-platform-tests/html/dom/idlharness.worker-expected.txt:
Source/WebCore:
Covered by existing tests.
- html/canvas/CanvasPath.cpp:
(WebCore::CanvasPath::roundRect): Added.
- html/canvas/CanvasPath.h:
- html/canvas/CanvasPath.idl: Added roundRect declarations.
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::processArgument): Added stub for the
RadiusVariant as used in roundRect.
- inspector/InspectorCanvasCallTracer.h:
- inspector/agents/InspectorCanvasAgent.cpp: Add include.
- inspector/RecordingSwizzleType.h: Added DOMPointInit type.
Source/WebInspectorUI:
- UserInterface/Models/Recording.js:
(WI.Recording.displayNameForSwizzleType): Added name for DOMPointInit.
Proper support for it should come with bug233255.
LayoutTests:
- inspector/canvas/recording-2d-full-expected.txt:
- inspector/canvas/resources/recording-2d.js: Added calls to roundRect
to test the inspector processArgument()
- platform/glib/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.worker-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.worker-expected.txt: Removed.
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt: Renamed from LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.worker-expected.txt.
- 5:37 AM Changeset in webkit [291105] by
-
- 8 edits4 adds in trunk
Cleanup RenderLayer::currentTransform()
https://bugs.webkit.org/show_bug.cgi?id=237553
Reviewed by Rob Buis.
LayoutTests/imported/w3c:
Add two new WPT tests covering animations of the 'transform-box' property.
- web-platform-tests/css/css-transforms/animation/transform-box-expected.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-box-will-change-transform-layer-expected.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-box-will-change-transform-layer.html: Added.
- web-platform-tests/css/css-transforms/animation/transform-box.html: Added.
Source/WebCore:
In preparation for the upcoming SVG/CSS transforms support in LBSE,
the transform related code in RenderLayer is cleaned up, starting
with RenderLayers currentTransform() function.
RenderLayer::currentTransform() has two purposes. It can either be used
to re-compute the existing transformation matrix with different options
(e.g. include or exclude 'transform-origin' induced transformations), or
to retrieve the current transformation matrix from the animatedStyle() of
the associated renderer, if an accelerated transform animation is running
(triggered e.g. via CSS Animations / JS WebAnimations).
Currently the code to compute the transformation matrix is duplicated,
avoid that and unify the two code paths (re-compute CTM if accelerated transform
animations are running / re-compute CTM if transform-origin shall be excluded).
Add two new WPT tests that verify animating 'transform-box' is functional
for both composited & non-composited elements. Currently 'transform-box'
support is ignored for composited elements, as demonstrated by the
transform-box-with-change-transform-layer.html test.
Follow-up patches that fix the bugs depends on this initial cleanup patch.
For now mark the failing test as such until it's fixed.
Tests: imported/w3c/web-platform-tests/css/css-transforms/animation/transform-box-will-change-transform-layer.html
imported/w3c/web-platform-tests/css/css-transforms/animation/transform-box.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform const):
LayoutTests:
Mark new WPT test css/css-transforms/animation/transform-box-will-change-transform-layer.html
as expected to fail, since 'transform-box' is ignored for composited elements at the moment.
- platform/glib/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 4:50 AM Changeset in webkit [291104] by
-
- 10 edits in trunk
[web-animations] font-variant-alternates should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237661
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
While we now run the font-variant-alternates tests, we don't support all values for this property so we fail
those tests.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/text/TextFlags.cpp:
(WebCore::operator<<):
- platform/text/TextFlags.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontFamilies):
(WebCore::RenderStyle::setFontVariantAlternates):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontVariantAlternates const):
- 4:44 AM Changeset in webkit [291103] by
-
- 9 edits in trunk
[web-animations] font-synthesis should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237650
Reviewed by Myles C. Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontFamilies):
(WebCore::RenderStyle::setFontSynthesis):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontSynthesis const):
- 4:04 AM Changeset in webkit [291102] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Panel: CSS variable completions should be provided even without a query
https://bugs.webkit.org/show_bug.cgi?id=237679
<rdar://problem/90059628>
Reviewed by Patrick Angle.
Return the list of all available completion suggestions if
WI.CSSCompletionsis configured to allow empty
prefix search. This was already the case for classic autocompletion with prefix matching, but was missing
for fuzzy matching.
- UserInterface/Models/CSSCompletions.js:
(WI.CSSCompletions.prototype.executeQuery):
- 4:03 AM Changeset in webkit [291101] by
-
- 2 edits in trunk/Source/WebCore
[MSE][SourceBuffer] Fix creating float PTS/DTS when dividing sample
https://bugs.webkit.org/show_bug.cgi?id=237528
Reviewed by Xabier Rodriguez-Calvar.
The timestamps used for sample division in SourceBuffer aren't being
aligned with the same rounding margin used in
SourceBuffer::sourceBufferPrivateDidReceiveSample().
This patch is authored by Eugene Mutavchi <Ievgen_Mutavchi@comcast.com>
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/797
- platform/graphics/SourceBufferPrivate.cpp: Extracted roundTowardsTimeScaleWithRoundingMargin lambda as a function and used it from removeCodedFrames(), on top of the current usage from sourceBufferPrivateDidReceiveSample().
- 3:38 AM Changeset in webkit [291100] by
-
- 7 edits in trunk
[web-animations] fill-rule should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237648
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fillRule const):
(WebCore::RenderStyle::setFillRule):
- 3:16 AM Changeset in webkit [291099] by
-
- 6 edits in trunk
[web-animations] counter-reset should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237644
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
Generalize the wrapper added for counter-increment to also handle counter-reset.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 2:22 AM Changeset in webkit [291098] by
-
- 11 edits in trunk
[CSS Container Queries] Implement new container selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=237657
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/container-selection-expected.txt:
- web-platform-tests/css/css-contain/container-queries/unsupported-axis-expected.txt:
Source/WebCore:
"For each element, the query container to be queried is selected from among the element’s
ancestor query containers that have a valid container-type for all the container features
in the <container-condition>."
https://drafts.csswg.org/css-contain-3/#container-rule
- css/ContainerQuery.cpp:
(WebCore::CQ::requiredAxesForFeature):
- css/ContainerQuery.h:
- css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumeFilteredContainerQuery):
Move container name parsing to ContainerQueryParser too.
(WebCore::ContainerQueryParser::consumeSizeQuery):
Collect required axes during parsing.
- css/ContainerQueryParser.h:
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeContainerRule):
- style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluate const):
(WebCore::Style::ContainerQueryEvaluator::selectContainer const):
Select container based on required axes for the features being used.
(WebCore::Style::ContainerQueryEvaluator::evaluateQuery const):
(WebCore::Style::ContainerQueryEvaluator::evaluateCondition const):
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
No need to check axes during evaluation anymore. We only evaluate against containers that support them.
(WebCore::Style::ContainerQueryEvaluator::resolveContainer const): Deleted.
Rename resolveContainer -> selectContainer to match the spec.
- style/ContainerQueryEvaluator.h:
- 2:19 AM Changeset in webkit [291097] by
-
- 2 edits in trunk/Source/bmalloc
[libpas] We should gurantee that in-flux-stash is fully baked when pointing table is set
https://bugs.webkit.org/show_bug.cgi?id=237697
rdar://89116983
Reviewed by Mark Lam.
To support enumerating hashtable which can be in the middle of resizing, we have in-flux-stash: this
small stash is used to keep old table and size while resizing. However, Mark pointed that
pas_tiny_large_map_hashtable_for_each_entry_remote's assertion is firing, which is ensuring that table's
underlying pointer should be NULL when the size is 0. But in-flux-stash, we did not guarantee that
in-flux-stash data is consistent when it is exposed to the enumerator (when setting hashtable_being_resized).
This patch inserts pas_compiler_fence when exposing and unexposing in-flux-stash. pas_compiler_fence is
enough (pas_store_store_fence is not necessary) because pas_enumerator runs after suspending the process.
Thus, data structure's consistency between instruction boundary is enough.
- libpas/src/libpas/pas_hashtable.h:
- 1:30 AM Changeset in webkit [291096] by
-
- 2 edits2 adds in trunk/Source/WebCore
[GTK][WPE] Add initial adwaita style for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237527
Reviewed by Michael Catanzaro.
- Modules/pdfjs-extras/adwaita/style.css: Added.
(#openFile):
(.dropdownToolbarButton > select):
- html/PDFDocument.cpp:
(WebCore::PDFDocument::injectStyleAndContentScript):
- 1:08 AM Changeset in webkit [291095] by
-
- 15 edits2 deletes in trunk/Source
Remove RemoteVideoSample
https://bugs.webkit.org/show_bug.cgi?id=237592
Reviewed by Eric Carlson.
Source/WebCore:
No change of behavior.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/RemoteVideoSample.cpp: Removed.
- platform/graphics/RemoteVideoSample.h: Removed.
Source/WebKit:
Send RemoteVideoSample data directly as IPC message parameters instead of inside RemoteVideoSample.
Fix timeStampNs by sending them back to WebProcess and divide them by 1000 to put them as milliseconds, as expected by libwebrtc backend.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::createDecoderCallback):
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::LibWebRTCCodecs::completedDecodingCV):
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
(WebKit::RemoteCaptureSampleManager::videoFrameAvailable):
(WebKit::RemoteCaptureSampleManager::videoFrameAvailableCV):
(WebKit::RemoteCaptureSampleManager::videoSampleAvailable): Deleted.
(WebKit::RemoteCaptureSampleManager::videoSampleAvailableCV): Deleted.
(WebKit::RemoteCaptureSampleManager::RemoteVideo::videoSampleAvailable): Deleted.
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.messages.in:
- WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
- 1:00 AM Changeset in webkit [291094] by
-
- 16 edits2 adds in trunk
[GTK][WPE] Add initial support for PDF documents using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237513
Reviewed by Michael Catanzaro.
Source/WebCore:
Add support for loading PDF documents using PDF.js.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
- loader/soup/ResourceLoaderSoup.cpp:
(WebCore::ResourceLoader::loadGResource):
- page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
- platform/LegacySchemeRegistry.cpp:
(WebCore::builtinSecureSchemes):
Source/WebKit:
Build PDF.js resources into the library.
- PdfJSGResources.cmake: Added.
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType): Claim to support PDF documents when PDF.js is enabled.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canShowMIMEType const): Ditto.
Source/WTF:
Enable PDF.js for GTK and WPE ports.
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
Add a script to generate the GResource manifest for PDF.js sources.
- glib/generate-pdfjs-gresource-manifest.py: Added.
(get_filenames):
(get_filenames.should_ignore_resource):
(get_filenames.resource_name):
(is_compressible):
- gtk/manifest.txt.in: Add pdfjs to tarballs.
- wpe/manifest.txt.in: Ditto.
- 12:57 AM Changeset in webkit [291093] by
-
- 18 edits4 adds in trunk/Source
[GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers
https://bugs.webkit.org/show_bug.cgi?id=237601
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
Make it possible to start the inspector server with 0 port, meaning any free one will be used.
- inspector/remote/glib/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::start): Pass the effective address to g_socket_listener_add_address and get the port.
- inspector/remote/glib/RemoteInspectorServer.h:
(Inspector::RemoteInspectorServer::port const): Return the port the server is listening to.
Source/WebInspectorUI:
Add Base/BrowserInspectorFrontendHost.js to be used when inspector is run and InspectorFrontendHost is not
defined in window. This new file is only included in the inspector sources for GTK and WPE ports.
- CMakeLists.txt:
- PlatformWPE: Added
- PlatformGTK:
- Scripts/combine-resources.pl: Add --input-script-name to be able to skip individual scripts too.
- Scripts/copy-user-interface-resources.pl: If inspector frontend host should not be included, remove the script
from generated files.
- UserInterface/Base/BrowserInspectorFrontendHost.js: Added.
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsShowCertificate):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get isRemote):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get inspectionLevel):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get debuggableInfo):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get port):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get platform):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get platformVersionName):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsDiagnosticLogging):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsWebExtensions):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.connect):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.loaded):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.closeWindow):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.reopen):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.reset):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.bringToFront):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.inspectedURLChanged):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.showCertificate):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setZoomFactor):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.zoomFactor):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setForcedAppearance):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.userInterfaceLayoutDirection):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.supportsDockSide):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.requestDockSide):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setAttachedWindowHeight):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setAttachedWindowWidth):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setSheetRect):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.startWindowDrag):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.moveWindowBy):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.copyText):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.killText):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.openURLExternally):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.canSave):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.save):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.append):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.close):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.showContextMenu):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.dispatchEventAsContextMenuEvent):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.sendMessageToBackend):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.unbufferedLog):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.isUnderTest):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.isExperimentalBuild):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.beep):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.inspectInspector):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.isBeingInspected):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setAllowsInspectingInspector):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.logDiagnosticEvent):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.didShowExtensionTab):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.didHideExtensionTab):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.didNavigateExtensionTab):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.inspectedPageDidNavigate):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.evaluateScriptInExtensionTab):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype._sendPendingMessagesToBackendIfNeeded):
- UserInterface/Base/Main.js:
(WI.loaded): Connect the inspector host if needed.
- UserInterface/Main.html: Add Base/BrowserInspectorFrontendHost.js.
Source/WebKit:
This is no longer possible since we switched to the new remote inspector. We don't want to bring the legacy
remote inspector back, but it should be possible to use a mixed approach, using a WebSocket for the inspector
protocol communication, but still using the new remote inspector code. This patch adds a simple HTTP browser to
server the inspector resources and open WebSocket connection to the inspector. It pretends to be a remote
inspector client, so we don't need any change in the current remote inspector implementation. The server is only
started when the env var WEBKIT_INSPECTOR_HTTP_SERVER is present, and the inspector server is started for the
same host but using a free port.
- PlatformWPE.cmake:
- SourcesGTK.txt:
- SourcesWPE.txt:
- UIProcess/API/glib/WebKitInitialize.cpp:
(WebKit::initializeRemoteInspectorServer): Start the HTTP server if the env var WEBKIT_INSPECTOR_HTTP_SERVER is present.
(WebKit::webkitInitialize): Just call initializeRemoteInspectorServer().
- UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::handleRequest): Use RemoteInspectorClient::buildTargetListPage().
- UIProcess/Inspector/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::inspect): Only call RemoteInspectorProxy::load() for UI inspector type.
(WebKit::RemoteInspectorClient::buildTargetListPage const): Build the target list page, using message handlers
for UI inspector and window.open for the HTTP inspector.
- UIProcess/Inspector/glib/RemoteInspectorClient.h:
(WebKit::RemoteInspectorClient::targets const): Deleted.
- UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp: Added.
(WebKit::RemoteInspectorHTTPServer::singleton):
- UIProcess/Inspector/glib/RemoteInspectorHTTPServer.h: Added.
Mar 9, 2022:
- 11:14 PM Changeset in webkit [291092] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=237327
Reviewed by Eric Carlson.
The worker is first sending the Opened message, than any message coming from the data channel.
Wait for the Opened message before proceeding with the rest of the test.
- web-platform-tests/webrtc-extensions/transfer-datachannel.html:
- 11:04 PM Changeset in webkit [291091] by
-
- 2 edits in trunk/Source/WebKit
Combine Lookup and Define.
https://bugs.webkit.org/show_bug.cgi?id=237627
rdar://26205225
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _defineForWebView:]):
- 10:12 PM Changeset in webkit [291090] by
-
- 6 edits in trunk
[web-animations] counter-increment should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237640
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
The counter-increment and counter-reset properties are represented via a single data structure
held by RenderStyle. This lays up the groundwork for animation support of counter-reset as well
but right now we only handle counter-increment to keep this patch focused.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 8:36 PM Changeset in webkit [291089] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=237688
- gpu-process/TestExpectations:
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
- 8:31 PM Changeset in webkit [291088] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=236931
- gpu-process/TestExpectations:
- 7:31 PM Changeset in webkit [291087] by
-
- 3 edits in trunk/Source/JavaScriptCore
Limit WK_XCODE_SUPPORTS_LTO in JavaScriptCore based on target OS
https://bugs.webkit.org/show_bug.cgi?id=237682
Reviewed by Alexey Proskuryakov.
- Configurations/Base.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig:
- 7:18 PM Changeset in webkit [291086] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=236930
- gpu-process/TestExpectations:
- platform/ios/TestExpectations:
- 7:05 PM Changeset in webkit [291085] by
-
- 2 edits in trunk/Source/WebCore
Remove unused AccessibilityObject member variable.
https://bugs.webkit.org/show_bug.cgi?id=237670
<rdar://problem/90042470>
Reviewed by Chris Fleizach.
AccessibilityObject::m_isolatedTreeNodeInitialized is not used, thus
removing.
- accessibility/AccessibilityObject.h:
- 6:43 PM Changeset in webkit [291084] by
-
- 4 edits in trunk/Source/WebCore
In isolated tree mode, do not call NSAccessibilityUnregisterUniqueIdForUIElement until the isolated object is detached.
https://bugs.webkit.org/show_bug.cgi?id=237621
<rdar://problem/89992486>
Reviewed by Chris Fleizach.
When the live object is detached from its wrapper on the main thread,
the wrapper may be in the middle of serving a request on the AX thread.
Therefore calling NSAccessibilityUnregisterUniqueIdForUIElement may
interfere with the completiong of the request, or even cause undefined
behavior since many of the internal lookups for objects depend on a data
structure updated by system call. With this patch, we unregister a
wrapper when the isolated object is detached, which happens after the
live object is detached.
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapperBase attachIsolatedObject:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper detachIsolatedObject:]):
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]): Deleted.
- 6:05 PM Changeset in webkit [291083] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
Unreivewed build fix. rdar://89376484
./Modules/webauthn/AuthenticatorCoordinator.cpp:144:50: error: no member named 'findIf' in 'WTF::Vector<WebCore::PublicKeyCredentialCreationOptions::Parameters, 0, WTF::CrashOnOverflow, 16>'; did you mean 'find'?
- 6:02 PM Changeset in webkit [291082] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore/platform/sql
Apply patch. rdar://problem/82071968
- 3:43 PM Changeset in webkit [291081] by
-
- 87 edits1 copy2 adds in branches/safari-613-branch
Revert "Cherry-pick r289790. rdar://problem/89997669"
This reverts commit r291070.
- 3:06 PM Changeset in webkit [291080] by
-
- 5 edits5 adds in trunk
Empty float rects should remain empty after integrally enclosing them.
https://bugs.webkit.org/show_bug.cgi?id=237507
Reviewed by Alan Bujtas.
Source/WebCore:
Test: compositing/tile-coverage-subpixel-empty-rect.html
- platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRectPreservingEmptyRects):
- platform/graphics/FloatRect.h:
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::setNeedsDisplayInRect):
(WebCore::TileGrid::dropTilesInRect):
(WebCore::TileGrid::tilesWouldChangeForCoverageRect const):
(WebCore::TileGrid::prepopulateRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):
Add a new variant of enclosingIntRect(const Float&) that ensures that empty input rects
always return an empty output rect, even if the x/y position is fractional.
Significant portions of the layout code (including, but not limited to linesBoundingBox()) depend
on the old behavior, so the new behaviour is opt-in and only used by TileGrid.
Fixes the case where TileGrid received an empty coverage rect at a fractional position, and rounded
it out to a 1x1 rect and allocated unnecessary tiles.
LayoutTests:
- compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
- compositing/tile-coverage-subpixel-empty-rect.html: Added.
- platform/gtk/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
- platform/ios/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
Adds a new test that uses multiple overflow:hidden clips and absolute positioning to create
an empty coverage rect with a subpixel x/y position that is within the bounds of an offscreen
layer. Confirms that we don't accidentally allocate a tile for this layer.
- 2:45 PM Changeset in webkit [291079] by
-
- 2 edits in branches/safari-613-branch/Source/bmalloc
Cherry-picking r290110
[libpas] scavenger should not call pthread_mach_thread_np after suspension
https://bugs.webkit.org/show_bug.cgi?id=236798
rdar://89020902
Reviewed by Mark Lam and Keith Miller.
pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
a lock, it also depends on an internal implementation).
- libpas/src/libpas/pas_thread_local_cache.c: (scavenger_thread_suspend_data_create): (suspend): (resume): (stop_allocator): (pas_thread_local_cache_for_all):
- 2:38 PM Changeset in webkit [291078] by
-
- 3 edits in trunk/Source/WebCore
Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=236131
- platform/VideoFrame.cpp:
(WebCore::VideoFrame::asVideoFrameCV):
- platform/VideoFrame.h:
- 2:35 PM Changeset in webkit [291077] by
-
- 2 edits in trunk/Tools
[EWS] Support concept of 'blocked' pull requests
https://bugs.webkit.org/show_bug.cgi?id=237370
<rdar://problem/89689094>
Unreviewed follow-up fix.
Accidently landed change using string literals instead of variables.
- Tools/CISupport/ews-build/steps.py:
(GitHubMixin):
(GitHubMixin._is_pr_blocked):
(ValidateChange.validate_github):
(BlockPullRequest.start):
(BlockPullRequest.getResultSummary):
Canonical link: https://commits.webkit.org/248243@main
- 2:31 PM Changeset in webkit [291076] by
-
- 2 edits in trunk/Source/WebCore
Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=236131
- platform/VideoFrame.cpp:
(WebCore::VideoFrame::asVideoFrameCV):
- 2:25 PM Changeset in webkit [291075] by
-
- 12 edits1 copy2 adds in trunk/Source/WebGPU
[WGSL] Implement enough of the Parser for the simplest shaders
https://bugs.webkit.org/show_bug.cgi?id=237629
Reviewed by Myles Maxfield.
The specific "hello-world"-like shaders that I want this to be able to parse are included in WGSLParserTests.mm.
The general approach to the parser, such as its templating by the Lexer, is directly copied from JSC's parser.
Things are a bit simpler for us as WGSL is such a simple language to parse, being strictly LR(1).
In this patch I also deleted BlockAttribute, since this attribute was recently removed from the language.
- WGSL/AST/Attribute.h:
(WGSL::AST::Attribute::isBlock const): Deleted.
- WGSL/AST/Expressions/TypeConversion.h:
- WGSL/AST/FunctionDecl.h:
- WGSL/AST/ShaderModule.h:
- WGSL/AST/Statements/AssignmentStatement.h:
- WGSL/AST/StructureDecl.h:
- WGSL/AST/TypeDecl.h:
(WGSL::AST::ParameterizedType::stringViewToKind):
- WGSL/CompilationMessage.h:
- WGSL/Parser.cpp: Added.
(WGSL::Parser::Parser):
(WGSL::Parser::current):
(WGSL::parse):
(WGSL::parseLChar):
(WGSL::parseUChar):
(WGSL::Parser<Lexer>::consumeType):
(WGSL::Parser<Lexer>::consume):
(WGSL::Parser<Lexer>::parseShader):
(WGSL::Parser<Lexer>::parseGlobalDecl):
(WGSL::Parser<Lexer>::parseAttributes):
(WGSL::Parser<Lexer>::parseAttribute):
(WGSL::Parser<Lexer>::parseStructDecl):
(WGSL::Parser<Lexer>::parseStructMember):
(WGSL::Parser<Lexer>::parseTypeDecl):
(WGSL::Parser<Lexer>::parseTypeDeclAfterIdentifier):
(WGSL::Parser<Lexer>::parseGlobalVariableDecl):
(WGSL::Parser<Lexer>::parseVariableQualifier):
(WGSL::Parser<Lexer>::parseStorageClass):
(WGSL::Parser<Lexer>::parseAccessMode):
(WGSL::Parser<Lexer>::parseFunctionDecl):
(WGSL::Parser<Lexer>::parseParameter):
(WGSL::Parser<Lexer>::parseStatement):
(WGSL::Parser<Lexer>::parseCompoundStatement):
(WGSL::Parser<Lexer>::parseReturnStatement):
(WGSL::Parser<Lexer>::parseShortCircuitOrExpression):
(WGSL::Parser<Lexer>::parseRelationalExpression):
(WGSL::Parser<Lexer>::parseShiftExpression):
(WGSL::Parser<Lexer>::parseAdditiveExpression):
(WGSL::Parser<Lexer>::parseMultiplicativeExpression):
(WGSL::Parser<Lexer>::parseUnaryExpression):
(WGSL::Parser<Lexer>::parseSingularExpression):
(WGSL::Parser<Lexer>::parsePostfixExpression):
(WGSL::Parser<Lexer>::parsePrimaryExpression):
(WGSL::Parser<Lexer>::parseExpression):
(WGSL::Parser<Lexer>::parseLHSExpression):
(WGSL::Parser<Lexer>::parseCoreLHSExpression):
(WGSL::Parser<Lexer>::parseArgumentExpressionList):
- WGSL/Parser.h: Copied from Source/WebGPU/WGSL/CompilationMessage.h.
- WGSL/WGSL.cpp:
(WGSL::staticCheck):
(WGSL::SuccessfulCheck::SuccessfulCheck):
- WGSL/WGSL.h:
- WebGPU.xcodeproj/project.pbxproj:
- 2:16 PM Changeset in webkit [291074] by
-
- 9 edits in branches/safari-613-branch
Cherry-pick r290515. rdar://problem/89376484
[WebAuthn] Use default pubKeyCredParams if empty in makeCredential
https://bugs.webkit.org/show_bug.cgi?id=237109
rdar://problem/89376484
Reviewed by Brent Fulgham.
Source/WebCore:
The Web Authentication level 2 spec was updated to clarify that
a set of default pubKeyCredParams should be used if the list
supplied by the RP is empty. This patch starts using
the default and updates associated tests.
- Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::create const):
- Modules/webauthn/PublicKeyCredentialCreationOptions.h:
- Modules/webauthn/WebAuthenticationConstants.h:
LayoutTests:
Update tests to take in account using default pubKeyCredParams.
- http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-failure.https.html:
- http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:16 PM Changeset in webkit [291073] by
-
- 5 edits2 adds in branches/safari-613-branch
Cherry-pick r290760. rdar://problem/83745510
Rendering issues with many dynamically-added sticky elements inside overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=237378
<rdar://83745510>
Reviewed by Cameron McCormack.
Source/WebCore:
A bug was filed describing a symptom where position:sticky elements would eventually
fail to render when many of them were dynamically added inside a non-stacking context
overflow scroll.
Debugging showed that CALayers were accumulating, causing us to hit per-process IOSurface
limits, at which point content fails to render (this is being fixed via rdar://89640915).
Further debugging showed that these layers were unparented, and being entrained by
ScrollingStateStickyNodes, which were accumulating in ScrollingStateTree's m_unparentedNodes.
This happened because with this scrolling configuration, each ScrollingStateStickyNode
is parented via a ScrollingStateOverflowScrollProxyNode which is referenced by entries
in RenderLayerBacking's m_ancestorClippingStack. On cleanup, the ScrollingStateOverflowScrollProxyNode
was unparented first, leaving the ScrollingStateStickyNode in m_unparentedNodes.
The fix is to have ScrollingStateTree::unparentChildrenAndDestroyNode() remove nodes
from m_unparentedNodes.
To test, add a m_unparentedNodes count to scrollingStateTreeAsText output, which means
having scrollingStateTreeAsText() as a member function on ScrollingStateTree.
Test: scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText const):
- page/scrolling/ScrollingStateTree.cpp: (WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode): (WebCore::ScrollingStateTree::scrollingStateTreeAsText const):
- page/scrolling/ScrollingStateTree.h:
LayoutTests:
- scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:16 PM Changeset in webkit [291072] by
-
- 27 edits4 adds in branches/safari-613-branch
Cherry-pick r290646. rdar://problem/88911184
focus({preventScroll: true}) does not prevent scrolling on iOS
https://bugs.webkit.org/show_bug.cgi?id=236584
rdar://88911184
Reviewed by Simon Fraser.
Source/WebCore:
Plumb
FocusOptionsthroughElement::dispatchFocusEvent()as well as the chrome client hooks for
elementDidRefocusandelementDidFocus, instead of just aFocusDirectionflag.
- dom/Document.cpp: (WebCore::Document::setFocusedElement):
- dom/Element.cpp: (WebCore::Element::focus): (WebCore::Element::dispatchFocusEvent):
- dom/Element.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::dispatchFocusEvent):
- html/HTMLSelectElement.h:
- html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
- html/HTMLTextFormControlElement.h:
- loader/EmptyClients.h:
- page/ChromeClient.h: (WebCore::ChromeClient::elementDidFocus): (WebCore::ChromeClient::elementDidRefocus):
- page/FocusController.cpp: (WebCore::dispatchEventsOnWindowAndFocusedElement): (WebCore::FocusController::setFocusedElement):
Source/WebKit:
Add support for
preventScrollon iOS by avoiding UI-side zooming/scrolling to reveal the focused element if it
was focused withpreventScroll: true. See below for more details.
Tests: fast/forms/select-focus-prevent-scroll.html
fast/forms/text-field-focus-prevent-scroll.html
- Shared/FocusedElementInformation.cpp: (WebKit::FocusedElementInformation::encode const): (WebKit::FocusedElementInformation::decode):
- Shared/FocusedElementInformation.h:
Add a boolean flag to
FocusedElementInformationto indicate whether or not scrolling to reveal the focused
element should be prevented.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _zoomToRevealFocusedElement]):
Only zoom to reveal the focused element if the focused element information's
preventScrollflag isNO.
(-[WKContentView _elementDidBlur]):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::elementDidFocus): (WebKit::WebChromeClient::elementDidRefocus):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::elementDidRefocus): (WebKit::WebPage::elementDidFocus):
Use
FocusOptionsto set thepreventScrollflag when propagatingFocusedElementInformation.
- WebProcess/WebPage/WebPage.h:
Source/WebKitLegacy/ios:
Adjust the method signature of elementDidFocus. See WebCore ChangeLog for more information.
- WebCoreSupport/WebChromeClientIOS.h:
- WebCoreSupport/WebChromeClientIOS.mm: (WebChromeClientIOS::elementDidFocus):
Source/WebKitLegacy/mac:
Adjust the method signature of elementDidFocus. See WebCore ChangeLog for more information.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::elementDidFocus):
LayoutTests:
Add a couple of new layout tests to verify that passing in
{ preventScroll: true }for focus options causes
us to avoid scrolling to reveal focused select elements and text fields.
- fast/forms/select-focus-prevent-scroll-expected.txt: Added.
- fast/forms/select-focus-prevent-scroll.html: Added.
- fast/forms/text-field-focus-prevent-scroll-expected.txt: Added.
- fast/forms/text-field-focus-prevent-scroll.html: Added.
- resources/ui-helper.js:
Also make it safe to call
waitForInputSessionToDismiss()in a platform-agnostic test, by bailing early if
we're not on iOS, using WebKit2.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:16 PM Changeset in webkit [291071] by
-
- 15 edits4 adds in branches/safari-613-branch/LayoutTests
Cherry-pick r290556. rdar://problem/89525864
Re-import inert and <dialog> WPT
https://bugs.webkit.org/show_bug.cgi?id=237243
Reviewed by Youenn Fablet.
Upstream commit: https://github.com/web-platform-tests/wpt/commit/9261ca87db106c1f31f1ab4f54b8f4a2617cbc24
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-expected.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-ref.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-expected.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-ref.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
- web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-and-contenteditable.tentative.html: Added.
- web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt:
- web-platform-tests/inert/inert-iframe-hittest.tentative.html:
- web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt:
- web-platform-tests/inert/inert-iframe-tabbing.tentative.html:
- web-platform-tests/inert/w3c-import.log:
LayoutTests:
- TestExpectations:
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:15 PM Changeset in webkit [291070] by
-
- 87 edits3 deletes in branches/safari-613-branch
Cherry-pick r289790. rdar://problem/89997669
ExtensionsGL is not useful class, it should be removed
https://bugs.webkit.org/show_bug.cgi?id=236490
Source/WebCore:
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.
Remove ExtensionsGL. It is not a useful class, it does not abstract anything.
It has similar functions to GraphicsContextGL subclass, and needs and uses GraphicsContextGL subclass
underneath.
It is a problematic class as it is obtained through a virtual function, but that
virtual function override is being called during construction of the GraphicsContextGL subclass
instance.
Also the ExtensionsGL will neccessarily call back to GraphicsContextGL subclass instance being
constructed.
Current getExtensions() virtual function override calls are expected to go
where the C++ defines them going during construction.
Current calls back to the GraphicsContextGL subclass instance during construction *should*
access state that is already initialized, but it is quite error-prone and hard to
analyze.
Move ExtensionsGL functions to GraphicsContextGL. Make call-sites call the context instead of the
extension helper. Rename the functions with pattern "isSupported" -> "isExtensionSupported".
Remove GraphicsContextGL::getExtensions() virtual function call.
For legacy contexts GraphicsContextGLOpenGL, GraphicsContextGLOpenGLES preserve their
ExtensionGLCommon subclasses. Accessing it happens from a normal function from legacy call sites
that know that they're calling GraphicsContextGLOpenGL.
For GraphicsContextGLANGLE, move context initialization code to GraphicsContextGLANGLE::initialize()
instead of the constructor. This way the initialization code can call virtual functions and the calls
are delivered normally to the last overrider.
RemoteGraphicsContextGLProxyBase can now be removed, as it is unneeded anyway and its added virtual
functions would cause inconvenient naming duplication.
No new tests, a refactor.
- CMakeLists.txt:
- Headers.cmake:
- Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): (WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
- Sources.txt:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/ANGLEInstancedArrays.cpp: (WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays): (WebCore::ANGLEInstancedArrays::supported):
- html/canvas/ANGLEInstancedArrays.h:
- html/canvas/EXTColorBufferFloat.cpp: (WebCore::EXTColorBufferFloat::EXTColorBufferFloat): (WebCore::EXTColorBufferFloat::supported):
- html/canvas/EXTColorBufferFloat.h:
- html/canvas/EXTColorBufferHalfFloat.cpp: (WebCore::EXTColorBufferHalfFloat::EXTColorBufferHalfFloat): (WebCore::EXTColorBufferHalfFloat::supported):
- html/canvas/EXTColorBufferHalfFloat.h:
- html/canvas/EXTFloatBlend.cpp: (WebCore::EXTFloatBlend::EXTFloatBlend): (WebCore::EXTFloatBlend::supported):
- html/canvas/EXTFloatBlend.h:
- html/canvas/EXTTextureCompressionRGTC.cpp: (WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):
- html/canvas/KHRParallelShaderCompile.cpp: (WebCore::KHRParallelShaderCompile::KHRParallelShaderCompile): (WebCore::KHRParallelShaderCompile::supported):
- html/canvas/KHRParallelShaderCompile.h:
- html/canvas/OESFBORenderMipmap.cpp: (WebCore::OESFBORenderMipmap::OESFBORenderMipmap): (WebCore::OESFBORenderMipmap::supported):
- html/canvas/OESFBORenderMipmap.h:
- html/canvas/OESTextureFloat.cpp: (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::supported):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureHalfFloat.cpp: (WebCore::OESTextureHalfFloat::OESTextureHalfFloat): (WebCore::OESTextureHalfFloat::supported):
- html/canvas/OESTextureHalfFloat.h:
- html/canvas/OESVertexArrayObject.cpp:
- html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::initializeShaderExtensions): (WebCore::WebGL2RenderingContext::getExtension): (WebCore::WebGL2RenderingContext::getSupportedExtensions):
- html/canvas/WebGLColorBufferFloat.cpp: (WebCore::WebGLColorBufferFloat::WebGLColorBufferFloat): (WebCore::WebGLColorBufferFloat::supported):
- html/canvas/WebGLColorBufferFloat.h:
- html/canvas/WebGLCompressedTextureASTC.cpp: (WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC): (WebCore::WebGLCompressedTextureASTC::supported):
- html/canvas/WebGLCompressedTextureASTC.h:
- html/canvas/WebGLCompressedTextureATC.cpp: (WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC): (WebCore::WebGLCompressedTextureATC::supported):
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTextureETC.cpp: (WebCore::WebGLCompressedTextureETC::WebGLCompressedTextureETC): (WebCore::WebGLCompressedTextureETC::supported):
- html/canvas/WebGLCompressedTextureETC.h:
- html/canvas/WebGLCompressedTextureETC1.cpp: (WebCore::WebGLCompressedTextureETC1::WebGLCompressedTextureETC1): (WebCore::WebGLCompressedTextureETC1::supported):
- html/canvas/WebGLCompressedTextureETC1.h:
- html/canvas/WebGLCompressedTexturePVRTC.cpp: (WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC): (WebCore::WebGLCompressedTexturePVRTC::supported):
- html/canvas/WebGLCompressedTexturePVRTC.h:
- html/canvas/WebGLCompressedTextureS3TC.cpp: (WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC): (WebCore::WebGLCompressedTextureS3TC::supported):
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLCompressedTextureS3TCsRGB.cpp: (WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB): (WebCore::WebGLCompressedTextureS3TCsRGB::supported):
- html/canvas/WebGLCompressedTextureS3TCsRGB.h:
- html/canvas/WebGLDebugShaders.cpp: (WebCore::WebGLDebugShaders::WebGLDebugShaders): (WebCore::WebGLDebugShaders::getTranslatedShaderSource):
- html/canvas/WebGLDepthTexture.cpp: (WebCore::WebGLDepthTexture::WebGLDepthTexture): (WebCore::WebGLDepthTexture::supported):
- html/canvas/WebGLDrawBuffers.cpp: (WebCore::WebGLDrawBuffers::WebGLDrawBuffers): (WebCore::WebGLDrawBuffers::supported): (WebCore::WebGLDrawBuffers::drawBuffersWEBGL): (WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):
- html/canvas/WebGLFramebuffer.cpp: (WebCore::getClearBitsByAttachmentType): (WebCore::getClearBitsByFormat): (WebCore::WebGLFramebuffer::checkStatus const): (WebCore::WebGLFramebuffer::drawBuffersIfNecessary): (WebCore::WebGLFramebuffer::getDrawBuffer):
- html/canvas/WebGLMultiDraw.cpp: (WebCore::WebGLMultiDraw::WebGLMultiDraw): (WebCore::WebGLMultiDraw::supported):
- html/canvas/WebGLMultiDraw.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getMaxDrawBuffers): (WebCore::WebGLRenderingContext::getMaxColorAttachments): (WebCore::WebGLRenderingContext::validateBlendEquation):
- html/canvas/WebGLRenderingContextBase.cpp: (WebCore::getChannelBitsByFormat): (WebCore::possibleFormatAndTypeForInternalFormat): (WebCore::WebGLRenderingContextBase::setupFlags): (WebCore::WebGLRenderingContextBase::getParameter): (WebCore::WebGLRenderingContextBase::getProgramParameter): (WebCore::WebGLRenderingContextBase::getShaderParameter): (WebCore::WebGLRenderingContextBase::getTexParameter): (WebCore::WebGLRenderingContextBase::getUniform): (WebCore::WebGLRenderingContextBase::hint): (WebCore::WebGLRenderingContextBase::readPixels): (WebCore::WebGLRenderingContextBase::renderbufferStorageImpl): (WebCore::WebGLRenderingContextBase::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContextBase::texParameter): (WebCore::WebGLRenderingContextBase::loseContextImpl): (WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData): (WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions): (WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions): (WebCore::WebGLRenderingContextBase::maybeRestoreContext): (WebCore::WebGLRenderingContextBase::getMaxDrawBuffers): (WebCore::WebGLRenderingContextBase::getMaxColorAttachments): (WebCore::WebGLRenderingContextBase::enableSupportedExtension):
- html/canvas/WebGLVertexArrayObjectOES.cpp:
- loader/FrameLoaderClient.h:
- platform/graphics/ExtensionsGL.h: Removed.
- platform/graphics/GraphicsContextGL.cpp: (WebCore::GraphicsContextGL::computeFormatAndTypeParameters):
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:
- platform/graphics/RemoteGraphicsContextGLProxyBase.h:
- platform/graphics/angle/ExtensionsGLANGLE.cpp: Removed.
- platform/graphics/angle/ExtensionsGLANGLE.h: Removed.
- platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::initialize): (WebCore::GraphicsContextGLANGLE::platformInitializeContext): (WebCore::GraphicsContextGLANGLE::platformInitialize): (WebCore::GraphicsContextGLANGLE::texImage2D): (WebCore::GraphicsContextGLANGLE::validateDepthStencil): (WebCore::GraphicsContextGLANGLE::supportsExtension): (WebCore::GraphicsContextGLANGLE::ensureExtensionEnabled): (WebCore::GraphicsContextGLANGLE::isExtensionEnabled): (WebCore::GraphicsContextGLANGLE::getGraphicsResetStatusARB): (WebCore::GraphicsContextGLANGLE::getTranslatedShaderSourceANGLE): (WebCore::GraphicsContextGLANGLE::drawBuffersEXT): (WebCore::GraphicsContextGLANGLE::adjustWebGL1TextureInternalFormat):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/graphics/cocoa/GraphicsContextGLCocoa.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::create): (WebCore::GraphicsContextGLCocoa::GraphicsContextGLCocoa): (WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): (WebCore::GraphicsContextGLCocoa::platformInitializeContext): (WebCore::GraphicsContextGLCocoa::platformInitialize): (WebCore::GraphicsContextGLCocoa::reshapeDisplayBufferBacking): (WebCore::GraphicsContextGLCocoa::allocateAndBindDisplayBufferBacking): (WebCore::GraphicsContextGLCocoa::bindDisplayBufferBacking): (WebCore::GraphicsContextGLCocoa::prepareForDisplay):
- platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm: (WebCore::createWebProcessGraphicsContextGL):
- platform/graphics/opengl/ExtensionsGLOpenGL.cpp: (WebCore::ExtensionsGLOpenGL::platformSupportsExtension):
- platform/graphics/opengl/ExtensionsGLOpenGL.h:
- platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp: (WebCore::ExtensionsGLOpenGLCommon::supports): (WebCore::ExtensionsGLOpenGLCommon::ensureEnabled):
- platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
- platform/graphics/opengl/ExtensionsGLOpenGLES.cpp: (WebCore::ExtensionsGLOpenGLES::isEnabled): (WebCore::ExtensionsGLOpenGLES::getGraphicsResetStatusARB): (WebCore::ExtensionsGLOpenGLES::platformSupportsExtension):
- platform/graphics/opengl/ExtensionsGLOpenGLES.h:
- platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: (WebCore::GraphicsContextGLOpenGL::getExtensions): (WebCore::GraphicsContextGLOpenGL::validateDepthStencil): (WebCore::GraphicsContextGLOpenGL::supportsExtension): (WebCore::GraphicsContextGLOpenGL::ensureExtensionEnabled): (WebCore::GraphicsContextGLOpenGL::isExtensionEnabled): (WebCore::GraphicsContextGLOpenGL::getGraphicsResetStatusARB): (WebCore::GraphicsContextGLOpenGL::drawBuffersEXT): (WebCore::GraphicsContextGLOpenGL::getTranslatedShaderSourceANGLE):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp: (WebCore::GraphicsContextGLOpenGL::texImage2D): (WebCore::GraphicsContextGLOpenGL::getExtensions):
- platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp: (WebCore::GraphicsContextGLOpenGL::reshapeFBOs): (WebCore::GraphicsContextGLOpenGL::validateAttributes): (WebCore::GraphicsContextGLOpenGL::getExtensions):
- platform/graphics/texmap/BitmapTextureGL.cpp:
- platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp: (WebCore::GraphicsContextGLTextureMapper::create): (WebCore::createWebProcessGraphicsContextGL):
- platform/graphics/texmap/GraphicsContextGLTextureMapper.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): (WebCore::GraphicsContextGLTextureMapper::prepareForDisplay): (WebCore::GraphicsContextGLTextureMapper::reshapeDisplayBufferBacking):
- platform/graphics/texmap/TextureMapperGL.cpp:
Source/WebKit:
Move the RemoteGraphicsContextGLProxyBase functions to
RemoteGraphicsContextGL. The ..Base can now be removed
as ExtensionGL is removed.
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::RemoteGraphicsContextGL::workQueueInitialize): (WebKit::RemoteGraphicsContextGL::ensureExtensionEnabled): (WebKit::RemoteGraphicsContextGL::markContextChanged):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (getGraphicsResetStatusARB): (getTranslatedShaderSourceANGLE): (drawBuffersEXT):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp: (WebKit::RemoteGraphicsContextGLProxy::RemoteGraphicsContextGLProxy): (WebKit::RemoteGraphicsContextGLProxy::setContextVisibility): (WebKit::RemoteGraphicsContextGLProxy::isGLES2Compliant const): (WebKit::RemoteGraphicsContextGLProxy::markContextChanged): (WebKit::RemoteGraphicsContextGLProxy::supportsExtension): (WebKit::RemoteGraphicsContextGLProxy::ensureExtensionEnabled): (WebKit::RemoteGraphicsContextGLProxy::isExtensionEnabled): (WebKit::RemoteGraphicsContextGLProxy::initialize): (WebKit::RemoteGraphicsContextGLProxy::reshape):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
Tools:
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-14
Reviewed by Dean Jackson.
Update manually implemented functions.
- Scripts/generate-gpup-webgl:
- TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:15 PM Changeset in webkit [291069] by
-
- 5 edits5 adds in branches/safari-613-branch
Cherry-pick r289071. rdar://problem/89997434
ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
https://bugs.webkit.org/show_bug.cgi?id=236030
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-03
Reviewed by Dean Jackson.
Source/WebCore:
Test: webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html
Remove the power-preference specific native displays.
Add a native display for opengl, and use the default
one for Metal.
After the recent ANGLE roll, ANGLE uses (native display, power preference)
as the key to look up EGLDisplays.
- platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::releaseThreadResources):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::initializeEGLDisplay):
LayoutTests:
- webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
- webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
- webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [291068] by
-
- 7 edits in trunk
[web-animations] dominant-baseline should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237645
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::dominantBaseline const):
(WebCore::RenderStyle::setDominantBaseline):
- 2:07 PM Changeset in webkit [291067] by
-
- 1 edit1 add in trunk/Tools
[Tools] Add script to query results database
https://bugs.webkit.org/show_bug.cgi?id=233800
Reviewed by Jonathan Bedard.
This commit adds a script to query https://results.webkit.org for the
history of a testcase for a given bot/config. It includes a
--only-changesswitch to show only revisions when the actual changed
from the previous one (useful to check when a test started failing).
For now it supports only layout-tests and has GTK/WPE bots predefined,
although full configurations (the query string for results.webkit.org)
can be used to access other bots.
- Scripts/webkit-test-results: Added.
- 2:05 PM Changeset in webkit [291066] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, reverting r290750.
Bug has been fixed, expectations are no longer needed.
Reverted changeset:
"[ iOS Debug ] editing/async-clipboard/* 20 tests are flaky
timeouts on iOS."
https://bugs.webkit.org/show_bug.cgi?id=237372
https://commits.webkit.org/r290750
- 1:46 PM Changeset in webkit [291065] by
-
- 2 edits in trunk/Tools
[webkitcorepy] Prefer xdg-open to open in linux
https://bugs.webkit.org/show_bug.cgi?id=237655
Reviewed by Jonathan Bedard.
- Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.open_url):
- 1:06 PM Changeset in webkit [291064] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
Unreviewed build fix. rdar://83734079
error: no matching member function for call to 'reportViolation'
- 1:05 PM Changeset in webkit [291063] by
-
- 7 edits1 add in trunk/Tools
[results.webkit.org]Add selection box for results database.
https://bugs.webkit.org/show_bug.cgi?id=233958
Reviewed by Jonathan Bedard.
Allow user can drag a selection box to select multiple dots.
Allow user to use cmd + click to select multiple dots.
Allow user to use shift + click to select a row of dots.
- Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint):
(TimelineFromEndpoint.prototype.update):
(TimelineFromEndpoint.prototype.getTestResultStatus):
(TimelineFromEndpoint.prototype.getTestResultUrl):
(TimelineFromEndpoint.prototype.render):
- Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
- Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(pointRectCollisionDetect): Detact if a point and a rect have a insertion.
(rectRectCollisionDetect): Detact if two rects have a insertion.
(XScrollableCanvasProvider): Add selection box.
(xScrollStreamRenderFactory):
(Timeline.CanvasSeriesComponent): Add selection box , cmd + click and shift + click.
(prototype.ExpandableSeriesComponent):
(prototype.Timeline.CanvasContainer):
Canonical link: https://commits.webkit.org/248236@main
- 12:59 PM Changeset in webkit [291062] by
-
- 2 edits in trunk/Source/WebKit
The accessibility library should be soft linked optionally
https://bugs.webkit.org/show_bug.cgi?id=236513
Reviewed by Geoffrey Garen.
The accessibility library should be soft linked optionally, since it is not always present.
- Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::handleAXPreferenceChange):
(WebKit::AuxiliaryProcess::handlePreferenceChange):
- 12:44 PM Changeset in webkit [291061] by
-
- 2 edits in trunk/Source/WebKit
[CMake] Associate platform specific configuration with WinCairo
https://bugs.webkit.org/show_bug.cgi?id=237668
Reviewed by Basuke Suzuki.
Move all cairo and curl platform configuration under a check for WinCairo. This arranges
platform config in a consistent manner.
- PlatformWin.cmake:
- 12:29 PM Changeset in webkit [291060] by
-
- 2 edits in trunk/Tools
[EWS] Support concept of 'blocked' pull requests
https://bugs.webkit.org/show_bug.cgi?id=237370
<rdar://problem/89689094>
Reviewed by Ryan Haddad.
cq- communicates that a change is blocked, either by an engineer or by a failed EWS run.
"changes requested" is not as dramatic as "cq-", so we are adding the concept of a "blocked"
pull request, which has simlar effects to "cq-".
- Tools/CISupport/ews-build/steps.py:
(GitHubMixin._is_pr_blocked): Check if a pull request currently has the "blocked" tag.
(GitHubMixin.modify_label): Add or remove a label from a pull request.
(SetCommitQueueMinusFlagOnPatch.hideStepIf): Added.
(BlockPullRequest): Added.
(AnalyzeCompileWebKitResults.analyzeResults): Block PR if failed.
(AnalyzeLayoutTestsResults.report_failure): Ditto.
Canonical link: https://commits.webkit.org/248233@main
- 11:59 AM Changeset in webkit [291059] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] 2 imported/w3c/web-platform-tests/content-security-policy/connect-src/* tests are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=237603
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 11:48 AM Changeset in webkit [291058] by
-
- 1 copy in tags/Safari-614.1.5.9
Tag Safari-614.1.5.9.
- 11:43 AM Changeset in webkit [291057] by
-
- 2 edits in trunk/Source/WebKit
File System Access: disallows names that are not permitted by underlying file system
https://bugs.webkit.org/show_bug.cgi?id=237635
rdar://89291566
We use FileSystem::fileSystemRepresentation to convert input name to a name that is permitted in current file
system. This patch makes File System Access API to throw error if the input name does not match the converted
name.
Reviewed by Youenn Fablet.
- NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::isValidFileName):
(WebKit::FileSystemStorageHandle::requestCreateHandle):
(WebKit::FileSystemStorageHandle::removeEntry):
(WebKit::FileSystemStorageHandle::move):
- 11:03 AM Changeset in webkit [291056] by
-
- 4 edits in trunk/Source/WebKit
Update feature flags for WebGL
https://bugs.webkit.org/show_bug.cgi?id=237666
rdar://problem/90040981
Reviewed by Geoffrey Garen.
- FeatureFlags/WebKit-appletvos.plist:
- FeatureFlags/WebKit-ios.plist:
- FeatureFlags/WebKit-watchos.plist:
- 10:40 AM Changeset in webkit [291055] by
-
- 3 edits in trunk
[iOS] Hard link AVPictureInPictureController
https://bugs.webkit.org/show_bug.cgi?id=237227
Unreviewed test gardening.
- platform/ipad/TestExpectations:
- 10:32 AM Changeset in webkit [291054] by
-
- 6 edits in trunk
[css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
https://bugs.webkit.org/show_bug.cgi?id=237642
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-lists/inherit-overwrites-expected.txt:
- web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt:
- web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt:
Source/WebCore:
A std::nullopt means the property isn't set, not that it shoudl be 0.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::counterToCSSValue):
- 10:16 AM Changeset in webkit [291053] by
-
- 18 edits in trunk/Source
Move RemoteLayerBackingStore::Buffer.isVolatile into ImageBufferBackend
https://bugs.webkit.org/show_bug.cgi?id=237631
Reviewed by Tim Horton.
Source/WebCore:
'isVolatile' is a property of a specific image buffer, so it makes more sense to have it in
ImageBuffer[Backend] than RemoteLayerBackingStore. This also allows GPU Process code to
maintain volatility state in the web process, which reduces the amount of IPC needed when
making the front buffer non-volatile before display.
So ImageBufferBackend gets volatilityState()/setVolatilityState(), accessed via ImageBuffer.
This state is maintained by RemoteRenderingBackendProxy for remote buffers. We set the state
to volatile when we receive the IPC reply for markSurfacesVolatile(), which requires
changing the reply to list buffers for which making volatile was successful.
RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile() can now
early return when the buffer is already non-volatile, and we have a backend handle (recall
that we clear backend handles when trying to make a buffer volatile).
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::volatilityState const):
(WebCore::ImageBufferBackend::setVolatilityState):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
(WebCore::ImageBufferIOSurfaceBackend::volatilityState const):
(WebCore::ImageBufferIOSurfaceBackend::setVolatilityState):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
'isVolatile' is a property of a specific image buffer, so it makes more sense to have it in
ImageBuffer[Backend] than RemoteLayerBackingStore. This also allows GPU Process code to
maintain volatility state in the web process, which reduces the amount of IPC needed when
making the front buffer non-volatile before display.
So ImageBufferBackend gets volatilityState()/setVolatilityState(), accessed via ImageBuffer.
This state is maintained by RemoteRenderingBackendProxy for remote buffers. We set the state
to volatile when we receive the IPC reply for markSurfacesVolatile(), which requires
changing the reply to list buffers for which making volatile was successful.
RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile() can now
early return when the buffer is already non-volatile, and we have a backend handle (recall
that we clear backend handles when trying to make a buffer volatile).
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
- GPUProcess/graphics/RemoteRenderingBackend.h:
- GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applySwappedBuffers):
(WebKit::RemoteLayerBackingStore::setBufferVolatile):
(WebKit::RemoteLayerBackingStore::setBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::didMakeFrontBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::Buffer::discard):
- Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::RemoteLayerWithRemoteRenderingBackingStoreCollection):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::collectBackingStoreBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::sendMarkBuffersVolatile): Call the completion handler inside the callback.
- WebProcess/GPU/graphics/ImageBufferBackendHandleSharing.h:
(WebKit::ImageBufferBackendHandleSharing::hasBackendHandle const):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::swapToValidFrontBuffer):
(WebKit::RemoteRenderingBackendProxy::markSurfaceNonVolatile):
(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:
(WebKit::ImageBufferRemoteIOSurfaceBackend::createBackendHandle const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::hasBackendHandle const):
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:
- 10:13 AM Changeset in webkit [291052] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/ios-wk2/TestExpectations:
- 9:47 AM Changeset in webkit [291051] by
-
- 23 edits2 adds in trunk/Source
Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
https://bugs.webkit.org/show_bug.cgi?id=236131
<rdar://problem/88805580>
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Update routines to take VideoFrameBuffer instead of VideoFrame.
Fix bugs in handling of YUV conversion libwebrtc routines.
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Source/webrtc/sdk/WebKit/WebKitUtilities.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
Source/WebCore:
Introduce VideoFrameLibWebRTC as a wrapper to libwebrtc video frame buffer.
In case we send VideoFrameLibWebRTC through RealtimeOutgoingVideoSourceCocoa, directly send the video frame buffer.
When receiving libwebrtc video frame buffers in RealtimeIncomingVideoSourceCocoa, make use of VideoFrameLibWebRTC to delay conversion of the video frame buffer in a CVPixelBufferRef.
In most cases, the conversion is unneeded as the video frame buffer will be used for rendering and will be copied to shared memory through SharedVideoFrameWriter.
Fix bugs in handling of YUV conversion libwebrtc routines.
Minor refactoring to have a default asVideoFrameCV method implementatin in VideoFrame.
Covered by existing tests.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/VideoFrame.cpp:
- platform/VideoFrame.h:
- platform/cocoa/SharedVideoFrameInfo.h:
- platform/cocoa/SharedVideoFrameInfo.mm:
- platform/mediastream/libwebrtc/VideoFrameLibWebRTC.cpp: Added.
- platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h: Added.
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
Source/WebKit:
Add optimization support for VideoFrameLibWebRTC writing into shared memory.
This removes the need to convert the webrtc video frame into a CVPixelBuffer, just to send it to GPUProcess for rendering.
- GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
- WebProcess/GPU/media/RemoteVideoFrameProxy.h:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
- 7:58 AM Changeset in webkit [291050] by
-
- 4 edits in trunk/Tools
[git-webkit] Extract revision from
git svn dcommit(Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=236849
<rdar://problem/89155179>
Unreviewed follow-up fix.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Only capture stdout.
Canonical link: https://commits.webkit.org/248224@main
- 7:25 AM Changeset in webkit [291049] by
-
- 9 edits in trunk
WebRTC decoded frames are not correctly rotated in case GPU Process DOM rendering flag is set to true
https://bugs.webkit.org/show_bug.cgi?id=237468
<rdar://problem/89807876>
Reviewed by Eric Carlson.
Source/WebCore:
We were creating remote video frames at webrtc decoder level but at that level, we do not know yet the rotation and timestamps of the frame.
We need to set those values when the frame is exposed to RealtimeIncomingVideoSource.
Previous tests did not catch the regression as we were correctly computing the size of the video using the webrtc rotation and not the rotation from the frame.
We should probably migrate to RemoteVideoFrameProxy as a buffer wrapper so that we can easily create remote video frames from a RemoteVideoFrameProxy buffer.
In the meantime, we use const_cast in VideoFrame::initializeCharacteristics.
Covered by updated test.
- platform/VideoFrame.cpp:
- platform/VideoFrame.h:
- platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- webrtc/video-rotation.html:
Observe actual video frame rotation value.
- 6:30 AM Changeset in webkit [291048] by
-
- 10 edits2 adds in trunk/Source
[WinCairo] Improve WCTiledBacking and TextureMapperSparseBackingStore
https://bugs.webkit.org/show_bug.cgi?id=237355
Reviewed by Don Olmstead.
Source/WebCore:
- platform/graphics/texmap/TextureMapperSparseBackingStore.cpp:
(WebCore::TextureMapperSparseBackingStore::setSize):
(WebCore::TextureMapperSparseBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSparseBackingStore::drawBorder):
(WebCore::TextureMapperSparseBackingStore::drawRepaintCounter):
(WebCore::TextureMapperSparseBackingStore::updateContents):
(WebCore::TextureMapperSparseBackingStore::removeTile):
(WebCore::TextureMapperSparseBackingStore::TextureMapperSparseBackingStore): Deleted.
(WebCore::TextureMapperSparseBackingStore::removeUncoveredTiles): Deleted.
(WebCore::TextureMapperSparseBackingStore::tileDimension const): Deleted.
- platform/graphics/texmap/TextureMapperSparseBackingStore.h:
- platform/graphics/texmap/TextureMapperTile.h:
Source/WebKit:
TextureMapperSparseBackingStore simply had a Vector to have all
tiles. If a web page had a very large layer, the vector was
extended to be able to keep all tiles, and it performed poorly.
Use a HashMap to keep tiles only in the coverage rect.
GraphicsLayerWC had only one dirty rect, and created a
ImageBuffer for all tiles to update. Change it to have one dirty
rect for one tile, and create a ImageBuffer for every dirty tile.
- GPUProcess/graphics/wc/WCScene.cpp:
(WebKit::WCScene::update):
- PlatformWin.cmake:
- WebProcess/WebPage/wc/DrawingAreaWC.cpp:
(WebKit::flushLayerImageBuffers):
- WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
(WebKit::GraphicsLayerWC::setSize):
(WebKit::GraphicsLayerWC::recursiveCommitChanges):
- WebProcess/WebPage/wc/WCTileGrid.cpp: Added.
(WebKit::WCTileGrid::Tile::Tile):
(WebKit::WCTileGrid::Tile::addDirtyRect):
(WebKit::WCTileGrid::Tile::clearDirtyRect):
(WebKit::WCTileGrid::Tile::hasDirtyRect const):
(WebKit::WCTileGrid::setSize):
(WebKit::WCTileGrid::tileRectFromPixelRect):
(WebKit::WCTileGrid::tileSizeFromPixelSize):
(WebKit::WCTileGrid::tilePixelSize const):
(WebKit::WCTileGrid::addDirtyRect):
(WebKit::WCTileGrid::clearDirtyRects):
(WebKit::WCTileGrid::ensureTile):
(WebKit::WCTileGrid::setCoverageRect):
- WebProcess/WebPage/wc/WCTileGrid.h: Added.
(WebKit::WCTileGrid::Tile::willRemove const):
(WebKit::WCTileGrid::Tile::setWillRemove):
(WebKit::WCTileGrid::Tile::dirtyRect):
(WebKit::WCTileGrid::tiles):
- WebProcess/WebPage/wc/WCUpateInfo.h:
(WebKit::WCTileUpdate::encode const):
(WebKit::WCTileUpdate::decode):
(WebKit::WCLayerUpateInfo::encode const):
(WebKit::WCLayerUpateInfo::decode):
- 5:44 AM Changeset in webkit [291047] by
-
- 2 edits in trunk/Source/WebCore
[web-animations] increase the max number of animatable properties
https://bugs.webkit.org/show_bug.cgi?id=237651
Reviewed by Antti Koivisto.
We've run out of space in m_propertyToIdMap, the limit was 255.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 5:34 AM Changeset in webkit [291046] by
-
- 6 edits in trunk
[CSS Container Queries] Remove size() function syntax
https://bugs.webkit.org/show_bug.cgi?id=237639
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:
Source/WebCore:
Per https://github.com/w3c/csswg-drafts/issues/6870
- css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumeContainerQuery):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleContainerName):
Also disallow strings as container names (they need to be identifiers).
- 5:31 AM Changeset in webkit [291045] by
-
- 3 edits in trunk/Tools
[JSC] Make runner should only schedule tests on live remotes
https://bugs.webkit.org/show_bug.cgi?id=237030
Reviewed by Adrian Perez de Castro.
The make runner does static scheduling of tests, i.e. it will
assign tests to all known remotes. In practice, this means that
even though the make runner participates in the retry loop, it
will always end up scheduling any tests that failed to run
(e.g. because the remote was down on startup or went away during
testing) on all remotes, including ones that are known to be down.
This patch makes it slightly more robust by introducing a liveness
check (getLiveRemoteHosts) before the static scheduling, i.e.
- in the initial preparation of the tests to run (prepareArtifacts) and
- in refreshExecution.
It reuses the command to get the number of processors as the
liveness check (it's a command we know currenly works in all
supported remotes), so flips numberOfProcessors inside-out.
While here, it adds getconf _NPROCESSORS_ONLN as a final attempt
to get the number of processors.
This does not mean that the make runner is now robust against
flaky remotes. At the very least, it's still missing an ssh
timeout (so it won't hang e.g. when hosts go away after the
initial connection is established) and child cleanup (e.g. when
bailing early from one remote in forEachRemote, it needs to kill
all children for other remotes, or we might end up retrying while
the old jobs are still running). But it's getting there.
Q: But isn't the GNU parallel runner much better suited for
handling flaky remotes?
A: Yes. However, the make runner is (somewhat) better at keeping
the remote CPUs busy with "fast" remotes, so we may still want to
use it when the remotes are both fast and stable enough. That
said, it still needs to be able to recover from the occasional
failed remote without producing false test failures.
- Scripts/run-jsc-stress-tests:
- Scripts/webkitruby/jsc-stress-test/executor.rb:
Make remoteHosts available to refreshExecution.
- 5:29 AM Changeset in webkit [291044] by
-
- 4 edits in trunk/Source/WebCore
[WinCairo] SpatialNavigation.h(93): error C2365: 'WebCore::None': redefinition; previous definition was 'enumerator'
https://bugs.webkit.org/show_bug.cgi?id=237647
Unreviewed build fix.
Changed WebCore::RectsAlignment to an enum class.
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
- page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::alignmentForRects):
(WebCore::distanceDataForNode):
- page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):
(): Deleted.
- 5:01 AM Changeset in webkit [291043] by
-
- 7 edits in trunk
[web-animations] color-interpolation-filters should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237637
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::colorInterpolationFilters const):
(WebCore::RenderStyle::setColorInterpolationFilters):
- 4:58 AM Changeset in webkit [291042] by
-
- 7 edits in trunk
[web-animations] clip-rule should support discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237609
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::clipRule const):
(WebCore::RenderStyle::setClipRule):
- 4:55 AM Changeset in webkit [291041] by
-
- 7 edits in trunk
[web-animations] background-blend-mode should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237607
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::backgroundBlendMode const):
(WebCore::RenderStyle::setBackgroundBlendMode):
- 4:52 AM Changeset in webkit [291040] by
-
- 13 edits in trunk
[web-animations] font-family should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237591
Reviewed by Myles Maxfield.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
(WebCore::RenderStyle::setFontFamilies):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontFamilies const):
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-fonts/animations/system-fonts-expected.txt:
- 4:45 AM Changeset in webkit [291039] by
-
- 11 edits in trunk
[web-animations] font-feature-settings should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237587
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/graphics/FontTaggedSettings.cpp:
(WebCore::operator<<):
- platform/graphics/FontTaggedSettings.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
(WebCore::RenderStyle::setFontFeatureSettings):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontFeatureSettings const):
- 4:43 AM Changeset in webkit [291038] by
-
- 9 edits in trunk/Source
[GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector
https://bugs.webkit.org/show_bug.cgi?id=237646
Reviewed by Adrian Perez de Castro.
Source/JavaScriptCore:
Add RemoteInspector::s_inspectorServerAddress to keep the remote inspector server address instead of the
environment variable used to start the server.
- inspector/remote/RemoteInspector.h:
- inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::RemoteInspector): Only call start if s_inspectorServerAddress is not null.
(Inspector::RemoteInspector::start): Use s_inspectorServerAddress instead of querying the environment.
Source/WebKit:
Use it only in the UI process to start the server, but propagate the address to web process using creation
parameters.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const): Encode inspectorServerAddress.
(WebKit::WebProcessCreationParameters::decode): Decode inspectorServerAddress.
- Shared/WebProcessCreationParameters.h: Add inspectorServerAddress.
- UIProcess/API/glib/WebKitInitialize.cpp:
(WebKit::initializeRemoteInspectorServer): Set RemoteInspector::s_inspectorServerAddress if the server started
successfully.
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Set inspectorServerAddress parameter from
RemoteInspector::s_inspectorServerAddress value.
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Set RemoteInspector::s_inspectorServerAddress from creation
parameter value.
- 4:37 AM Changeset in webkit [291037] by
-
- 14 edits1 add in trunk
[web-animations] font-kerning should supporting discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237585
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
Source/WebCore:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/text/TextFlags.cpp: Added.
(WebCore::operator<<):
- platform/text/TextFlags.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
(WebCore::RenderStyle::setFontKerning):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontKerning const):
- style/PropertyAllowlist.cpp:
(WebCore::Style::isValidMarkerStyleProperty):
- 3:38 AM Changeset in webkit [291036] by
-
- 88 edits7 moves23 adds in trunk/LayoutTests
[CSS Container Queries] Import updated WPTs
https://bugs.webkit.org/show_bug.cgi?id=237638
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
Upstream has been updated with the new syntax from
https://github.com/w3c/csswg-drafts/issues/6870
and behavior from
https://github.com/w3c/csswg-drafts/issues/6644
- resources/resource-files.json:
- web-platform-tests/css/css-contain/container-queries/animation-container-size.html:
- web-platform-tests/css/css-contain/container-queries/animation-container-type-dynamic.html:
- web-platform-tests/css/css-contain/container-queries/animation-nested-animation.html:
- web-platform-tests/css/css-contain/container-queries/animation-nested-transition.html:
- web-platform-tests/css/css-contain/container-queries/aspect-ratio-feature-evaluation.html:
- web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
- web-platform-tests/css/css-contain/container-queries/at-container-parsing.html:
- web-platform-tests/css/css-contain/container-queries/auto-scrollbars.html:
- web-platform-tests/css/css-contain/container-queries/backdrop-invalidation.html:
- web-platform-tests/css/css-contain/container-queries/canvas-as-container-005-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/canvas-as-container-005.html: Added.
- web-platform-tests/css/css-contain/container-queries/canvas-as-container-006-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/canvas-as-container-006.html: Added.
- web-platform-tests/css/css-contain/container-queries/change-display-in-container.html:
- web-platform-tests/css/css-contain/container-queries/conditional-container-status.html:
- web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-computed.html:
- web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.tentative-expected.txt.
- web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.tentative.html.
- web-platform-tests/css/css-contain/container-queries/container-inner-at-rules-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/container-inner-at-rules.html: Added.
- web-platform-tests/css/css-contain/container-queries/container-name-computed-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-name-computed.html:
- web-platform-tests/css/css-contain/container-queries/container-name-invalidation.html:
- web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-name-parsing.html:
- web-platform-tests/css/css-contain/container-queries/container-nested-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-nested.html:
- web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-parsing.html:
- web-platform-tests/css/css-contain/container-queries/container-selection-expected.txt:
- web-platform-tests/css/css-contain/container-queries/container-selection.html:
- web-platform-tests/css/css-contain/container-queries/container-size-invalidation.html:
- web-platform-tests/css/css-contain/container-queries/container-type-invalidation.html:
- web-platform-tests/css/css-contain/container-queries/container-units-small-viewport-fallback-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/container-units-small-viewport-fallback.html: Added.
- web-platform-tests/css/css-contain/container-queries/counters-flex-circular.html:
- web-platform-tests/css/css-contain/container-queries/counters-in-container-dynamic.html:
- web-platform-tests/css/css-contain/container-queries/counters-in-container.html:
- web-platform-tests/css/css-contain/container-queries/deep-nested-inline-size-containers-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/deep-nested-inline-size-containers.html: Added.
- web-platform-tests/css/css-contain/container-queries/display-contents.html:
- web-platform-tests/css/css-contain/container-queries/display-in-container.html:
- web-platform-tests/css/css-contain/container-queries/display-none.html:
- web-platform-tests/css/css-contain/container-queries/fieldset-legend-change.html:
- web-platform-tests/css/css-contain/container-queries/flex-in-columns-000-crash.html:
- web-platform-tests/css/css-contain/container-queries/flex-in-columns-001-crash.html:
- web-platform-tests/css/css-contain/container-queries/flex-in-columns-002-crash.html:
- web-platform-tests/css/css-contain/container-queries/flex-in-columns-003-crash.html:
- web-platform-tests/css/css-contain/container-queries/focus-inside-content-visibility-crash.html:
- web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic.html:
- web-platform-tests/css/css-contain/container-queries/font-relative-units.html:
- web-platform-tests/css/css-contain/container-queries/fragmented-container-001-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/fragmented-container-001.html: Added.
- web-platform-tests/css/css-contain/container-queries/get-animations.html:
- web-platform-tests/css/css-contain/container-queries/grid-in-columns-000-crash.html:
- web-platform-tests/css/css-contain/container-queries/grid-in-columns-001-crash.html:
- web-platform-tests/css/css-contain/container-queries/grid-in-columns-002-crash.html:
- web-platform-tests/css/css-contain/container-queries/grid-in-columns-003-crash.html:
- web-platform-tests/css/css-contain/container-queries/iframe-invalidation.html:
- web-platform-tests/css/css-contain/container-queries/ineligible-containment.html:
- web-platform-tests/css/css-contain/container-queries/inline-multicol-inside-container-crash.html:
- web-platform-tests/css/css-contain/container-queries/inline-size-and-min-width.html:
- web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html:
- web-platform-tests/css/css-contain/container-queries/inline-size-containment-vertical-rl.html:
- web-platform-tests/css/css-contain/container-queries/inline-size-containment.html:
- web-platform-tests/css/css-contain/container-queries/inline-with-columns-000-crash.html:
- web-platform-tests/css/css-contain/container-queries/inline-with-columns-001-crash.html:
- web-platform-tests/css/css-contain/container-queries/multicol-container-001-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/multicol-container-001.html: Added.
- web-platform-tests/css/css-contain/container-queries/multicol-inside-container.html:
- web-platform-tests/css/css-contain/container-queries/never-match-container-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/never-match-container.html: Added.
- web-platform-tests/css/css-contain/container-queries/orthogonal-wm-container-query.html:
- web-platform-tests/css/css-contain/container-queries/percentage-padding-orthogonal.html:
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-001.html:
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-002.tentative-expected.html: Removed.
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-002.tentative-ref.html: Removed.
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-002.tentative.html: Removed.
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-003-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-003.tentative-expected.txt.
- web-platform-tests/css/css-contain/container-queries/pseudo-elements-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-003.tentative.html.
- web-platform-tests/css/css-contain/container-queries/query-content-box.html:
- web-platform-tests/css/css-contain/container-queries/query-evaluation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/query-evaluation.html:
- web-platform-tests/css/css-contain/container-queries/reattach-container-with-dirty-child.html:
- web-platform-tests/css/css-contain/container-queries/resize-while-content-visibility-hidden.html:
- web-platform-tests/css/css-contain/container-queries/size-container-no-principal-box.html:
- web-platform-tests/css/css-contain/container-queries/size-feature-evaluation-expected.txt:
- web-platform-tests/css/css-contain/container-queries/size-feature-evaluation.html:
- web-platform-tests/css/css-contain/container-queries/style-change-in-container.html:
- web-platform-tests/css/css-contain/container-queries/svg-layout-root-crash.html:
- web-platform-tests/css/css-contain/container-queries/svg-root-size-container-expected.txt: Added.
- web-platform-tests/css/css-contain/container-queries/svg-root-size-container.html: Added.
- web-platform-tests/css/css-contain/container-queries/table-in-columns-000-crash.html:
- web-platform-tests/css/css-contain/container-queries/table-in-columns-001-crash.html:
- web-platform-tests/css/css-contain/container-queries/table-in-columns-002-crash.html:
- web-platform-tests/css/css-contain/container-queries/table-in-columns-003-crash.html:
- web-platform-tests/css/css-contain/container-queries/top-layer-dialog-backdrop.html:
- web-platform-tests/css/css-contain/container-queries/top-layer-dialog-container.html:
- web-platform-tests/css/css-contain/container-queries/top-layer-dialog.html:
- web-platform-tests/css/css-contain/container-queries/top-layer-nested-dialog.html:
- web-platform-tests/css/css-contain/container-queries/transition-scrollbars.html:
- web-platform-tests/css/css-contain/container-queries/transition-style-change-event.html:
- web-platform-tests/css/css-contain/container-queries/unsupported-axis-expected.txt:
- web-platform-tests/css/css-contain/container-queries/unsupported-axis.html:
- web-platform-tests/css/css-contain/container-queries/viewport-units-dynamic.html:
- web-platform-tests/css/css-contain/container-queries/viewport-units.html:
- web-platform-tests/css/css-contain/container-queries/w3c-import.log:
- web-platform-tests/css/css-contain/container-queries/whitespace-update-after-removal.html:
LayoutTests:
- 12:36 AM Changeset in webkit [291035] by
-
- 6 edits in trunk/Source/WebCore
GraphicsContextGLCocoa manages EGL native displays manually
https://bugs.webkit.org/show_bug.cgi?id=237313
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-03-09
Reviewed by Kenneth Russell.
ANGLE now keys the Metal EGL_DEFAULT_DISPLAY on the EGL_PLATFORM_ANGLE_TYPE_ANGLE.
This means that we do not need to use the default a native display for Metal and an
invented native display for OpenGL.
- platform/graphics/GraphicsTypesGL.h:
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::platformInitialize):
(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::initializeEGLDisplay):
(WebCore::GraphicsContextGLCocoa::platformInitialize):
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapper::platformInitialize):
- 12:04 AM Changeset in webkit [291034] by
-
- 62 edits1 move3 deletes in trunk
Scope capture sources by page identifiers
https://bugs.webkit.org/show_bug.cgi?id=237359
Reviewed by Eric Carlson.
Source/WebCore:
Pass PageIdentifier when creating capture sources.
This is used at WebKit layer to better handle creation of mulitple sources.
Since we are now sometimes answering to getUserMedia by cloning sources directly,
fix a bug in RealtimeVideoSource to use the preset aspect ratio to compute missing width or height.
Introduce a way to end immediately a capture source, this is used on GPUProcess side in case starting a capture using a different device.
Covered by existing tests.
- Headers.cmake:
- Modules/mediastream/MediaDevices.cpp:
- Modules/mediastream/MediaStreamTrack.cpp:
- Modules/speech/SpeechRecognitionCaptureSource.cpp:
- Modules/speech/SpeechRecognitionCaptureSource.h:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/PageIdentifier.h: Renamed from Source/WebCore/page/PageIdentifier.h.
- platform/mediastream/MediaStreamRequest.h:
- platform/mediastream/RealtimeMediaSource.cpp:
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/RealtimeMediaSourceCenter.cpp:
- platform/mediastream/RealtimeMediaSourceFactory.cpp: Removed.
- platform/mediastream/RealtimeMediaSourceFactory.h:
- platform/mediastream/RealtimeVideoCaptureSource.cpp:
- platform/mediastream/RealtimeVideoCaptureSource.h:
- platform/mediastream/RealtimeVideoSource.cpp:
- platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
- platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:
- platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
- platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp:
- platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.h:
- platform/mediastream/ios/CoreAudioCaptureSourceIOS.mm:
- platform/mediastream/mac/AVVideoCaptureSource.h:
- platform/mediastream/mac/AVVideoCaptureSource.mm:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- platform/mediastream/mac/CoreAudioCaptureSource.h:
- platform/mediastream/mac/MockAudioSharedUnit.mm:
- platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
- platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
- platform/mock/MockRealtimeAudioSource.cpp:
- platform/mock/MockRealtimeAudioSource.h:
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
- platform/mock/MockRealtimeVideoSource.cpp:
- platform/mock/MockRealtimeVideoSource.h:
Source/WebKit:
Pass PageIdentifier where appropriate.
Make use of PageIdentifier in UserMediaCaptureManagerProxy:
- For microphone, if there is a source with a different device, fail the source as we are not yet supporting concurrent captures.
- For camera, if there is a source with a different device, fail the source as we are not yet supporting concurrent captures (only on iOS). Otherwise, if there is a matching source, clone it so that we reduce the overhead of creating a new source (setting up a camera can be an expensive operation).
We silently fail (meaning there is no console log message for now, while still firing ended event) but add release logging to detect this case.
Minor refactoring to have one message in case capture source ends (stopped or failing) instead of two.
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp:
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.h:
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp:
- UIProcess/WebPageProxy.cpp:
- WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:
- WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.h:
- WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.messages.in:
- WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:
- WebProcess/cocoa/RemoteRealtimeAudioSource.h:
- WebProcess/cocoa/RemoteRealtimeDisplaySource.cpp:
- WebProcess/cocoa/RemoteRealtimeDisplaySource.h:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
- WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
- WebProcess/cocoa/RemoteRealtimeVideoSource.h:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
- WebProcess/cocoa/UserMediaCaptureManager.h:
- WebProcess/cocoa/UserMediaCaptureManager.messages.in:
LayoutTests:
Remove platform/ios/mediastream/getUserMedia-single-capture.html now that we no longer handle multi capture in WebProcess but in GPUProcess.
Update platform/ios/mediastream/audio-muted-in-background-tab-gpu-process.html to be like platform/ios/mediastream/audio-muted-in-background-tab.html
so that test is no longer dependent on synchronous event firing.
- platform/ios/mediastream/audio-muted-in-background-tab-gpu-process.html:
- platform/ios/mediastream/getUserMedia-single-capture-expected.txt: Removed.
- platform/ios/mediastream/getUserMedia-single-capture-gpu-process.html:
- platform/ios/mediastream/getUserMedia-single-capture.html: Removed.
Mar 8, 2022:
- 11:38 PM Changeset in webkit [291033] by
-
- 22 edits in trunk
Have MediaFormatReader plugin use WebMParser directly
https://bugs.webkit.org/show_bug.cgi?id=237594
rdar://89960307
Reviewed by Eric Carlson.
Source/WebCore:
Covered by existing tests.
- platform/MediaSample.h:
(WebCore::MediaSample::byteRange const): Have default implementation.
- platform/VideoFrame.cpp:
- platform/VideoFrame.h:
- platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::ImageDecoderAVFObjCSample::byteRangeForAttachment const):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
- platform/graphics/cocoa/CMUtilities.h: Export symbols.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::WebMParser::createByteRangeSamples):
(WebCore::WebMParser::OnTrackEntry):
(WebCore::WebMParser::VideoTrackData::consumeFrameData):
(WebCore::WebMParser::AudioTrackData::consumeFrameData):
(WebCore::WebMParser::provideMediaData):
(WebCore::SourceBufferParserWebM::parsedMediaData):
(WebCore::SourceBufferParserWebM::returnSamples):
(WebCore::SourceBufferParserWebM::flushPendingAudioSamples):
- platform/graphics/cocoa/SourceBufferParserWebM.h:
(WebCore::WebMParser::TrackData::createByteRangeSamples):
(WebCore::WebMParser::TrackData::drainPendingSamples):
- platform/graphics/gstreamer/MediaSampleGStreamer.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
Source/WebKit:
Directly build the sample tables from the sample's offset/size without
first build MediaSampleAVFObjC objects.
The MTPluginByteSourceRef interface unfortunately doesn't allow to skip a
given number of bytes, and you must read the content into a buffer to be
able to continue reading the resource.
As such, we continue to have to create SharedBuffer objects for each sample.
However, those objects are now much shorter lived and not dispatched to
other work queues. So the peak memory usage when playing a webm is
significantly reduced: a 50% memory reduction (from 440MB to 202MB with a sample video)
- Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::parseByteSource):
(WebKit::MediaFormatReader::parsedInitializationData):
(WebKit::MediaFormatReader::parsedMediaData):
(WebKit::MediaFormatReader::didProvideMediaData):
(WebKit::MediaFormatReader::finishParsing):
- Shared/mac/MediaFormatReader/MediaFormatReader.h:
- Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::MediaSampleByteRange):
(WebKit::MediaSampleByteRange::trackID const):
(WebKit::MediaSampleByteRange::platformSample const):
(WebKit::MediaSampleByteRange::presentationTime const):
(WebKit::MediaSampleByteRange::decodeTime const):
(WebKit::MediaSampleByteRange::duration const):
(WebKit::MediaSampleByteRange::sizeInBytes const):
(WebKit::MediaSampleByteRange::presentationSize const):
(WebKit::MediaSampleByteRange::flags const):
(WebKit::MediaSampleByteRange::byteRange const):
(WebKit::MediaSampleByteRange::offsetTimestampsBy):
(WebKit::MediaSampleByteRange::setTimestamps):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.h:
- Shared/mac/MediaFormatReader/MediaSampleCursor.cpp:
(WebKit::MediaSampleCursor::copyFormatDescription const):
- Shared/mac/MediaFormatReader/MediaTrackReader.cpp:
(WebKit::MediaTrackReader::addSample):
(WebKit::MediaTrackReader::copyProperty):
- Shared/mac/MediaFormatReader/MediaTrackReader.h:
Tools:
- TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
- 10:49 PM Changeset in webkit [291032] by
-
- 12 edits in trunk
RemoteGraphicsContextGL ReadPixels does not preserve contents for area that is not part of the Framebuffer
https://bugs.webkit.org/show_bug.cgi?id=222410
<rdar://problem/75025951>
Patch by John Cunningham <johncunningham@apple.com> on 2022-03-08
Reviewed by Kimmo Kinnunen.
Source/WebKit:
Make a copy of the data buffer passed into readnpixels so that reads outside the framebuffer contain
the expected results, rather than being zero'd.
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::readnPixels0):
(WebKit::RemoteGraphicsContextGL::readnPixels1):
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
- GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:
(bufferSubData):
(readnPixels0): Deleted.
(readnPixels1): Deleted.
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::readnPixels):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:
(WebKit::RemoteGraphicsContextGLProxy::readnPixels): Deleted.
Tools:
Make a copy of the data buffer passed into readnpixels so that reads outside the framebuffer contain
the expected results, rather than being zero'd.
- Scripts/generate-gpup-webgl:
LayoutTests:
Don't overwrite the data buffer for readPixels
- platform/ios-wk2/TestExpectations:
- 10:19 PM Changeset in webkit [291031] by
-
- 2 edits in trunk/Source/WebKit
Fix assertion when DOM Rendering in GPU Process is enabled with accelerated drawing disabled
https://bugs.webkit.org/show_bug.cgi?id=237626
Reviewed by Tim Horton.
Override releaseGraphicsContext() in the base class (which asserts). This subclass
doesn't need to do anything; releaseGraphicsContext() is only relevant for IOSurface-
based backends.
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
- 10:13 PM Changeset in webkit [291030] by
-
- 5 edits3 adds in trunk
IntersectionObserver is causing massive document leaks on haaretz.co.il
https://bugs.webkit.org/show_bug.cgi?id=237619
<rdar://problem/89989815>
Reviewed by Simon Fraser.
Source/WebCore:
On haaretz.co.il, many of the iframe documents (for Google ad frames) were leaking due to
IntersectionObserver. In particular, IntersectionObserver::isReachableFromOpaqueRoots()
was returning true because m_targetsWaitingForFirstObservation was non-empty. This indicates
that the IntersectionObserver is waiting for its first observation since that target was
added. However, the observation is not coming because we navigated away from the document.
To address the issue, I updated Document::commonTeardown() to disconnect all
IntersectionObservers (and the very similar ResizeObservers), right after stopping all
ActiveDOMObject.
Test: fast/dom/intersection-observer-document-leak.html
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
- dom/Document.h:
- page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::disconnect):
No longer return early if hasObservationTargets() returns false. This is because
LayoutTests:
Add layout test coverage.
- fast/dom/intersection-observer-document-leak-expected.txt: Added.
- fast/dom/intersection-observer-document-leak.html: Added.
- fast/dom/resources/intersection-observer-document-leak-popup.html: Added.
- 7:34 PM Changeset in webkit [291029] by
-
- 5 edits2 adds in trunk
[Cocoa] metadata cue endTime may not be updated
https://bugs.webkit.org/show_bug.cgi?id=237630
rdar://88690874
Reviewed by Jer Noble.
Source/WebCore:
Data cues have a start time but not an explicit duration, a data cue ends when
the next data cue from the same track starts. This means we don’t know the
duration of cue #1 until cue #2 is delivered, so when cue #1 is delivered it is
given the end time of the media file’s duration and the actual end time is updated
when cue #2 arrives.
http://webkit.org/b/229924 refactored text, audio, and video tracks to not depend
on HTMLMediaElement. Because InbandDataTextTrack could no longer access the
HTMLMediaElement to get its duration, a duration property was added to TextTrackList
that InbandDataTextTrack uses to set the duration of temporary cues.
TextTrackList.duration is set when it is created and updated when the media player
reports a duration change.
This means that if the media file’s duration is not known when the text track list
is created, and the file's duration never changes, the text track list never has a
valid duration and data cues were not added to the temporary list.
Fix this by updating TextTrackList.duration when a HTMLMediaElement reaches HAVE_METADATA.
Test: http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::durationChanged): Update m_textTracks.duration and post
the 'durationchange' event.
(WebCore::HTMLMediaElement::setReadyState): Call durationChanged.
(WebCore::HTMLMediaElement::mediaPlayerDurationChanged): Ditto.
- html/HTMLMediaElement.h:
- html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::addDataCue): Add cues to the incomplete cue map
even if the track list doesn't have duration.
LayoutTests:
- http/tests/media/hls/track-in-band-hls-metadata-cue-duration-expected.txt: Added.
- http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html: Added.
- 6:58 PM Changeset in webkit [291028] by
-
- 2 edits in trunk/Source/WebCore
Skip scheduling lazy UA shadow tree creation if already created or not needed
https://bugs.webkit.org/show_bug.cgi?id=237546
<rdar://problem/89922896>
Reviewed by Aditya Keerthi.
Bug 236747 made <input> element UA shadow trees get created lazily.
HTMLInputElement::insertedIntoAncestor now schedules the UA shadow tree
to be created the next time style is flushed. We currently do this every
time an <input> element is inserted into the document, but there's only
a need to do this if the particular input type needs a shadow tree and
we haven't already created it.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedIntoAncestor):
- 6:56 PM Changeset in webkit [291027] by
-
- 6 edits in trunk/Source
[WTF] LikelyDenseUnsignedIntegerSet::add can cause a reindexing of the entire bit vector with every call in the worst case
https://bugs.webkit.org/show_bug.cgi?id=236997
Reviewed by Saam Barati.
Source/JavaScriptCore:
Just make it a little bit easier to change the number of stack slots in testZDefOfSpillSlotWithOffsetNeedingToBeMaterializedInARegister.
- b3/air/testair.cpp:
Source/WTF:
This problem was found while investigating https://bugs.webkit.org/show_bug.cgi?id=236269.
LikelyDenseUnsignedIntegerSet has two forms: either as a HashSet (if sparse) or as a BitVector representing numbers above some value m_min (if sufficiently dense).
This is a massive memory win in most situations (>4x in practice for register allocation in JS2, >20x on some pathological webpages).
But it means that when adding a value below m_min to a set in BitVector shape, we have to rebuild the whole set, which takes a time proportional to the time of the set.
So if building a set by repeatedly adding decreasing values (like in https://bugs.webkit.org/show_bug.cgi?id=236269 where we add 10000, then 9999, then 9998, etc..), we have some awful performance.
In this patch I improve this situation in two ways:
- First I always round down m_min to the next multiple of 64. This means that when adding contiguous values like above we only re-index once every 64 adds.
- It then allows me to do the reindexing by simple memcpy instead of costly iteration of all the set bits, since they are now always at the same offset within the words of the BitVector.
On an M1 MBP, on testair:: testZDefOfSpillSlotWithOffsetNeedingToBeMaterializedInARegister, with n=5000, in release mode, measuring just the time spent building the interference graph:
Before this patch: 107 s
After this patch: 77 ms (note the different unit, it is not a typo!)
Unfortunately, it does not seem to significantly improve the time spent in LikelyDenseUnsignedIntgerSet::add in JetStream2,
probably because the pattern of always adding a value just before the minimum is quite pathological/rare.
I still think it is worth landing, as we don't know what code out there may hit this performance problem.
- wtf/BitVector.cpp:
(WTF::BitVector::shiftRightByMultipleOf64):
(WTF::BitVector::resizeOutOfLine):
- wtf/BitVector.h:
- wtf/LikelyDenseUnsignedIntegerSet.h:
(WTF::LikelyDenseUnsignedIntegerSet::add):
(WTF::LikelyDenseUnsignedIntegerSet::validate const):
(WTF::LikelyDenseUnsignedIntegerSet::transitionToBitVector):
- 6:53 PM Changeset in webkit [291026] by
-
- 4 edits in trunk
Enable tier-up in loops created by recursive tail call optimizations.
https://bugs.webkit.org/show_bug.cgi?id=178389
Reviewed by Saam Barati.
PerformanceTests:
Just changed a constant for consistency with TailBench9000/merge-sort.js
- TailBench9000/merge-sort-cps.js:
Source/JavaScriptCore:
Made the recursive tail call optimization only run in FTL mode, since it is a significant progression on TailBench.
Also some trivial refactoring of handleRecursiveTailCall.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
- 6:25 PM Changeset in webkit [291025] by
-
- 29 edits1 copy1 add in trunk
Split SourceBufferParserWebM and have platform agnostic WebMParser
https://bugs.webkit.org/show_bug.cgi?id=237472
rdar://problem/89810969
Reviewed by Eric Carlson.
Source/WebCore:
Split raw WebMParser from SourceBufferParserWebM and introduce platform
agnostic MediaSamplesBlock objects and TrackInfo
- PlatformMac.cmake:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/MediaSample.h:
(WebCore::MediaSample::dump const):
(WebCore::TrackInfo::isAudio const):
(WebCore::TrackInfo::isVideo const):
(WebCore::TrackInfo::type const):
(WebCore::TrackInfo::operator== const):
(WebCore::TrackInfo::operator!= const):
(WebCore::TrackInfo::TrackInfo):
(WebCore::VideoInfo::create):
(WebCore::VideoInfo::VideoInfo):
(WebCore::AudioInfo::create):
(WebCore::AudioInfo::AudioInfo):
(WebCore::MediaSamplesBlock::setInfo):
(WebCore::MediaSamplesBlock::info const):
(WebCore::MediaSamplesBlock::isVideo const):
(WebCore::MediaSamplesBlock::isAudio const):
(WebCore::MediaSamplesBlock::type const):
(WebCore::MediaSamplesBlock::append):
(WebCore::MediaSamplesBlock::size const):
(WebCore::MediaSamplesBlock::isEmpty const):
(WebCore::MediaSamplesBlock::clear):
(WebCore::MediaSamplesBlock::takeSamples):
(WebCore::MediaSamplesBlock::operator[] const):
(WebCore::MediaSamplesBlock::first const):
(WebCore::MediaSamplesBlock::last const):
(WebCore::MediaSamplesBlock::begin const):
(WebCore::MediaSamplesBlock::end const):
(isType):
- platform/audio/cocoa/AudioFileReaderCocoa.cpp:
(WebCore::AudioFileReader::demuxWebMData const):
- platform/graphics/PlatformVideoColorPrimaries.h:
- platform/graphics/PlatformVideoMatrixCoefficients.h:
- platform/graphics/PlatformVideoTransferCharacteristics.h:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
- platform/graphics/cocoa/CMUtilities.h: Copied from Source/WebCore/platform/graphics/PlatformVideoColorPrimaries.h.
- platform/graphics/cocoa/CMUtilities.mm: Added.
(WebCore::createAudioFormatDescription):
(WebCore::convertToCMColorPrimaries):
(WebCore::convertToCMTransferFunction):
(WebCore::convertToCMYCbCRMatrix):
(WebCore::createFormatDescriptionFromTrackInfo):
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::segmentReadErrorToWebmStatus):
(WebCore::WebMParser::WebMParser):
(WebCore::WebMParser::~WebMParser):
(WebCore::WebMParser::resetState):
(WebCore::WebMParser::reset):
(WebCore::WebMParser::parse):
(WebCore::WebMParser::setLogger):
(WebCore::WebMParser::invalidate):
(WebCore::WebMParser::trackDataForTrackNumber):
(WebCore::WebMParser::OnElementBegin):
(WebCore::WebMParser::OnElementEnd):
(WebCore::WebMParser::OnEbml):
(WebCore::WebMParser::OnSegmentBegin):
(WebCore::WebMParser::OnInfo):
(WebCore::WebMParser::OnClusterBegin):
(WebCore::WebMParser::OnTrackEntry):
(WebCore::WebMParser::OnBlockBegin):
(WebCore::WebMParser::OnBlockEnd):
(WebCore::WebMParser::OnSimpleBlockBegin):
(WebCore::WebMParser::OnSimpleBlockEnd):
(WebCore::WebMParser::OnBlockGroupBegin):
(WebCore::WebMParser::OnBlockGroupEnd):
(WebCore::WebMParser::OnFrame):
(WebCore::WebMParser::TrackData::contiguousCompleteBlockBuffer const):
(WebCore::WebMParser::TrackData::readFrameData):
(WebCore::WebMParser::VideoTrackData::resetCompletedFramesState):
(WebCore::WebMParser::VideoTrackData::consumeFrameData):
(WebCore::WebMParser::AudioTrackData::resetCompletedFramesState):
(WebCore::WebMParser::AudioTrackData::consumeFrameData):
(WebCore::WebMParser::isSupportedVideoCodec):
(WebCore::WebMParser::isSupportedAudioCodec):
(WebCore::SourceBufferParserWebM::SourceBufferParserWebM):
(WebCore::SourceBufferParserWebM::isWebMFormatReaderAvailable):
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
(WebCore::SourceBufferParserWebM::create):
(WebCore::WebMParser::provideMediaData):
(WebCore::SourceBufferParserWebM::parsedInitializationData):
(WebCore::SourceBufferParserWebM::parsedMediaData):
(WebCore::SourceBufferParserWebM::returnSamples):
(WebCore::SourceBufferParserWebM::parsedTrimmingData):
(WebCore::SourceBufferParserWebM::contentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferParserWebM::flushPendingAudioSamples):
(WebCore::SourceBufferParserWebM::appendData):
(WebCore::SourceBufferParserWebM::flushPendingMediaData):
(WebCore::SourceBufferParserWebM::setShouldProvideMediaDataForTrackID):
(WebCore::SourceBufferParserWebM::shouldProvideMediadataForTrackID):
(WebCore::SourceBufferParserWebM::invalidate):
(WebCore::SourceBufferParserWebM::setLogger):
(WebCore::SourceBufferParserWebM::setMinimumAudioSampleDuration):
- platform/graphics/cocoa/SourceBufferParserWebM.h:
(WebCore::WebMParser::Callback::parsedTrimmingData):
(WebCore::WebMParser::Callback::canDecrypt const):
(WebCore::WebMParser::Callback::contentKeyRequestInitializationDataForTrackID):
(WebCore::WebMParser::loggerPtr const):
(WebCore::WebMParser::logIdentifier const):
(WebCore::WebMParser::TrackData::create):
(WebCore::WebMParser::TrackData::TrackData):
(WebCore::WebMParser::TrackData::trackType const):
(WebCore::WebMParser::TrackData::formatDescription const):
(WebCore::WebMParser::TrackData::setFormatDescription):
(WebCore::WebMParser::TrackData::parser const):
(WebCore::WebMParser::TrackData::consumeFrameData):
(WebCore::WebMParser::TrackData::resetCompletedFramesState):
(WebCore::WebMParser::TrackData::drainPendingSamples):
(WebCore::WebMParser::VideoTrackData::create):
(WebCore::WebMParser::VideoTrackData::VideoTrackData):
(WebCore::WebMParser::AudioTrackData::create):
(WebCore::WebMParser::AudioTrackData::AudioTrackData):
(WebCore::SourceBufferParserWebM::type const):
(WebCore::SourceBufferParserWebM::appendData):
(WebCore::SourceBufferParserWebM::setDidParseTrimmingDataCallback):
(WebCore::SourceBufferParserWebM::loggerPtr const):
(WebCore::SourceBufferParserWebM::logIdentifier const):
(isType):
- platform/graphics/cocoa/VP9UtilitiesCocoa.h:
- platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::convertToPlatformVideoColorPrimaries):
(WebCore::convertToPlatformVideoTransferCharacteristics):
(WebCore::convertToPlatformVideoMatrixCoefficients):
(WebCore::createVideoInfoFromVPCodecConfigurationRecord):
(WebCore::createVideoInfoFromVP9HeaderParser):
(WebCore::createVideoInfoFromVP8Header):
- platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h:
- platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm:
(WebCore::createAudioInfoForFormat):
(WebCore::parseOpusPrivateData):
(WebCore::createOpusAudioInfo):
(WebCore::createVorbisAudioInfo):
Source/WebCore/PAL:
- pal/cf/CoreMediaSoftLink.cpp:
- pal/cf/CoreMediaSoftLink.h: Method CMSampleBufferCreateReady wasn't soft-linked.
Source/WebKit:
- Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::MediaSampleByteRange):
- Shared/mac/MediaFormatReader/MediaSampleByteRange.h: MediaSampleByteRange.h
didn't need to inherit from MediaSampleAVFObjC.
Tools:
- TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Update following base class definition change.
- 6:09 PM Changeset in webkit [291024] by
-
- 2 edits in trunk/Source/WebKit
Allow adattributiond to read and execute dylibs in /usr/lib on iOS
https://bugs.webkit.org/show_bug.cgi?id=237625
<rdar://89809031>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Per Arne Vollan.
WebKit's other sandboxes allow this.
- Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:
- 5:58 PM Changeset in webkit [291023] by
-
- 12 edits1 delete in trunk
Remove unused _grantAccessToPreferenceService
https://bugs.webkit.org/show_bug.cgi?id=237623
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Per Arne Vollan.
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _grantAccessToPreferenceService]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::grantAccessToPreferenceService): Deleted.
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockPreferenceServiceIfNeeded): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.h:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::notifyPreferencesChanged):
(WebKit::WebProcess::unblockPreferenceService): Deleted.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Removed.
- 5:17 PM Changeset in webkit [291022] by
-
- 10 edits2 moves in trunk/Source/WebKit
Rename TextRecognitionUtilities.* to ImageAnalysisUtilities.*
https://bugs.webkit.org/show_bug.cgi?id=237613
rdar://89982051
Reviewed by Tim Horton and Kate Cheney.
Rename TextRecognitionUtilities.h and TextRecognitionUtilities.mm to ImageAnalysisUtilities.h and
ImageAnalysisUtilities.mm, respectively. This is because this file now contains helper functions that are not
specific to just the text recognition aspect of visual intelligence features on Cocoa, but rather encompass a
variety of image analysis helpers.
- Platform/cocoa/ImageAnalysisUtilities.h: Renamed from Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h.
- Platform/cocoa/ImageAnalysisUtilities.mm: Renamed from Source/WebKit/Platform/cocoa/TextRecognitionUtilities.mm.
(WebKit::createImageAnalyzer):
(WebKit::createImageAnalyzerRequest):
(WebKit::floatQuad):
(WebKit::floatQuads):
(WebKit::makeTextRecognitionResult):
(WebKit::textRecognitionEnhancementsSystemFeatureEnabled):
(WebKit::imageAnalysisQueueSystemFeatureEnabled):
(WebKit::isImageAnalysisMarkupSystemFeatureEnabled):
(WebKit::isLiveTextAvailableAndEnabled):
- Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
- SourcesCocoa.txt:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKRBSAssertionDelegate assertion:didInvalidateWithError:]):
Drive-by fix: additionally tweak a couple of release logging arguments that are currently in reverse order.
- UIProcess/ios/WKActionSheetAssistant.mm:
- UIProcess/ios/WKContentViewInteraction.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
- UIProcess/mac/WebPageProxyMac.mm:
- WebKit.xcodeproj/project.pbxproj:
- 4:52 PM Changeset in webkit [291021] by
-
- 2 edits in trunk/Source/WebKit
Enable CFPrefs direct mode in adattributiond
https://bugs.webkit.org/show_bug.cgi?id=237620
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Per Arne Vollan.
This makes it not try to connect to cfprefsd, which is not allowed by the sandbox.
- Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:
(WebKit::PCMDaemonMain):
- 4:15 PM Changeset in webkit [291020] by
-
- 6 edits in trunk/Source/WebCore
Have SourceBufferParserWebM use SharedBuffer internally
https://bugs.webkit.org/show_bug.cgi?id=237078
rdar://89348752
Reviewed by Eric Carlson.
This is a refactor to allow SourceBufferParser to return SharedBuffer
rather than CMBlockBuffer.
No change in observable behaviours.
Covered by existing tests.
- platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::reenqueueMediaForTime): Fly-by fix: typo.
(WebCore::SourceBufferPrivate::didReceiveSample): Fly-by fix, exit early
if end time is lower than start time which can happen if the duration is
smaller than contiguousFrameTolerance.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::TrackData::contiguousCompleteBlockBuffer const):
(WebCore::SourceBufferParserWebM::TrackData::readFrameData):
(WebCore::SourceBufferParserWebM::TrackData::createSampleBuffer):
(WebCore::SourceBufferParserWebM::VideoTrackData::resetCompleted):
(WebCore::SourceBufferParserWebM::VideoTrackData::consumeFrameData):
(WebCore::SourceBufferParserWebM::VideoTrackData::postProcess):
(WebCore::SourceBufferParserWebM::AudioTrackData::resetCompleted):
(WebCore::SourceBufferParserWebM::AudioTrackData::consumeFrameData):
(WebCore::SourceBufferParserWebM::flushPendingAudioBuffers):
- platform/graphics/cocoa/SourceBufferParserWebM.h:
(WebCore::SourceBufferParserWebM::TrackData::resetCompleted):
(WebCore::SourceBufferParserWebM::TrackData::reset):
(WebCore::SourceBufferParserWebM::TrackData::drainPendingSamples):
(WebCore::SourceBufferParserWebM::TrackData::postProcess):
- platform/graphics/cocoa/VP9UtilitiesCocoa.h:
- platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::parseVP8FrameHeader): Make methods const.
- 3:54 PM Changeset in webkit [291019] by
-
- 5 edits in trunk/Source/WebKit
[macOS] Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=237586
- Shared/ModelIdentifier.h:
- UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerInternal.h:
- UIProcess/Cocoa/ModelElementControllerCocoa.mm:
- UIProcess/ModelElementController.h:
- 3:51 PM Changeset in webkit [291018] by
-
- 20 edits3 adds in trunk
[WebAuthn] Using WebAuthn within cross-origin iframe elements
https://bugs.webkit.org/show_bug.cgi?id=222240
rdar://problem/74830748
Reviewed by Brent Fulgham.
Source/WebCore:
This patch relaxes the requirement to perform a Web Authentication assertion
inside an i-frame with the "publickey-credentials-get" feature policy from
'same-site' to 'cross-origin with consent'.
There is an additional requirement that there is only a single cross-origin
parent to present to the user in the prompt. If we can't display the updated
prompt, then cross-origin assertions are not allowed.
Test: http/wpt/webauthn/public-key-credential-cross-origin.https.html
- Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::scopeAndSingleParent):
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::isCreate):
(WebCore::CredentialsContainer::scope): Deleted.
- Modules/credentialmanagement/CredentialsContainer.h:
- Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
- Modules/webauthn/AuthenticatorCoordinator.h:
- Modules/webauthn/AuthenticatorCoordinatorClient.h:
Source/WebKit:
This patch relaxes the requirement to perform a Web Authentication assertion
inside an i-frame with the "publickey-credentials-get" feature policy from
'same-site' to 'cross-origin with consent'.
There is an additional requirement that there is only a single cross-origin
parent to present to the user in the prompt. If we can't display the updated
prompt, then cross-origin assertions are not allowed.
- Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureAssertionOptions):
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::getAssertion):
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h:
LayoutTests:
Update existing tests and create new test for cross-origin, non same-site i-frames.
- http/wpt/webauthn/public-key-credential-cross-origin.https-expected.txt: Added.
- http/wpt/webauthn/public-key-credential-cross-origin.https.html: Added.
- http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https-expected.txt:
- http/wpt/webauthn/public-key-credential-same-origin-with-ancestors.https.html:
- http/wpt/webauthn/resources/public-key-credential-cross-origin.https.html: Added.
- 3:27 PM Changeset in webkit [291017] by
-
- 7 edits in trunk
Rename allow-custom-protocols-navigation to allow-top-navigation-to-custom-protocols
https://bugs.webkit.org/show_bug.cgi?id=237605
Reviewed by Darin Adler.
Source/WebCore:
Rename allow-custom-protocols-navigation sandbox flag to allow-top-navigation-to-custom-protocols as per:
There is no backward compatibility risk since support for this flag was added very recently
in r290958.
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSupportedSandboxPolicy):
(WebCore::SecurityContext::parseSandboxPolicy):
- dom/SecurityContext.h:
Source/WebKit:
Rename allow-custom-protocols-navigation sandbox flag to allow-top-navigation-to-custom-protocols as per:
There is no backward compatibility risk since support for this flag was added very recently
in r290958.
- UIProcess/WebPageProxy.cpp:
(WebKit::frameSandboxAllowsOpeningExternalCustomProtocols):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):
- 3:18 PM Changeset in webkit [291016] by
-
- 4 edits in trunk/Source
Fix Windows debug build
https://bugs.webkit.org/show_bug.cgi?id=237617
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Fujii Hironori.
Source/WebCore:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::parseHeader):
Source/WTF:
MSVC's linker is limited to generating 4GB libraries.
Currently, I'm seeing WebCore.lib be 3.9GB and some bots are failing to link debug builds.
More source unification reduces WebCore.lib's size to 3.3GB.
- Scripts/generate-unified-source-bundles.rb:
- 3:17 PM Changeset in webkit [291015] by
-
- 113 edits10 adds in branches/safari-613-branch
Cherry-pick r288701. rdar://problem/83734079
"Unrecognized Content-Security-Policy directive 'worker-src'."
https://bugs.webkit.org/show_bug.cgi?id=235260
<rdar://problem/83734079>
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
- web-platform-tests/content-security-policy/child-src/child-src-cross-origin-load.sub-expected.txt:
- web-platform-tests/content-security-policy/child-src/child-src-worker-blocked.sub-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-none.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-child-fallback-blocked.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-script-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-self-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/service-none.https.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/service-worker-src-child-fallback-blocked.https.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/shared-child.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-list.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-none.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-self.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-child-fallback-blocked.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-child-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-default-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-script-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-self-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/blob/self-doesnt-match-blob.sub-expected.txt:
- web-platform-tests/content-security-policy/blob/star-doesnt-match-blob.sub-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worker-import-data.https-expected.txt:
Source/WebCore:
Implementation of worker-src directive. According to https://www.w3.org/TR/CSP3/#changes-from-level-2
the worker-src directive now restricts URLs that can be loaded by
workers, and defers to child-src if not specified.
- bindings/js/WorkerModuleScriptLoader.cpp: (WebCore::WorkerModuleScriptLoader::load): Check worker-src instead of child-src for worker loads.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy):
- loader/ThreadableLoader.h: Check worker-src instead of child-src for worker loads.
- page/csp/ContentSecurityPolicy.cpp: We can remove allowChildContextFromSource which is now fully replaced by allowWorkerFromSource.
(WebCore::ContentSecurityPolicy::allowWorkerFromSource const):
(WebCore::ContentSecurityPolicy::allowChildContextFromSource const): Deleted.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::operativeDirectiveForWorkerSrc const): worker-src defers to child-src, then script-src, then default-src.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForWorker):
(WebCore::ContentSecurityPolicyDirectiveList::addDirective):
- page/csp/ContentSecurityPolicyDirectiveList.h:
- page/csp/ContentSecurityPolicyDirectiveNames.cpp:
- page/csp/ContentSecurityPolicyDirectiveNames.h:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL):
- workers/AbstractWorker.h: We check LegacySchemeRegistry::schemeShouldBypassContentSecurityPolicy in allowWorkerFromSource, so we don't need to check in in AbstractWorker::resolveURL anymore. We can also replace the child-src checks with worker-src ones.
- workers/Worker.cpp: (WebCore::Worker::create):
- workers/WorkerFontLoadRequest.cpp: (WebCore::WorkerFontLoadRequest::load):
- workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::addRegistration): Block service worker registrations not specified by worker-src.
- workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::create): Block shared worker urls not specified by worker-src.
- workers/shared/SharedWorkerScriptLoader.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
Source/WebKit:
- NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):
LayoutTests:
Update tests now that worker-src defaults eventually to script-src.
Since this was not the case with child-src, legacy CSP tests do not
expect script-src policies to affect workers. We can fix this by
specifying a separate worker-src policy for these tests to maintain
behavior.
- TestExpectations: Some wpt tests log random URL strings that change for every test iteration. For now we can't unskip those.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp.html:
- http/tests/security/contentSecurityPolicy/worker-script-src.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-eval.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScript-redirect-cross-origin.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-xhr.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:04 PM Changeset in webkit [291014] by
-
- 4 edits in trunk/Source/WebKit
File System Access: throw exception if file or directory cannot be accessed in file system
https://bugs.webkit.org/show_bug.cgi?id=237537
Reviewed by Youenn Fablet.
When a FileSystemHandle is created, we will ensure that corresponding directory or file exists (create the
directory or file if it does not exist yet). However, we did not check the result of the file system calls.
That means, we may fail to create the file (e.g. due to no disk space, or cases in rdar://89291566), but we
still return success to the FileSystemHandle creation request. We should fix this by checking the file system
call's result before completing the request.
- NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::FileSystemStorageHandle::create):
(WebKit::FileSystemStorageHandle::FileSystemStorageHandle):
- NetworkProcess/storage/FileSystemStorageHandle.h:
- NetworkProcess/storage/FileSystemStorageManager.cpp:
(WebKit::FileSystemStorageManager::createHandle):
- 2:18 PM Changeset in webkit [291013] by
-
- 8 edits in trunk/Tools
[git-webkit] Prompt user when GitHub credentials are likely incorrect
https://bugs.webkit.org/show_bug.cgi?id=237450
<rdar://problem/89781069>
Reviewed by Dewei Zhu.
GitHub doesn't make it obvious when credentials are invalid, but our scripts
can make an educated guess when invalid credentials are the root cause.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker): Add REFRESH_TOKEN_PROMPT.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.create):
(GitHub.PRGenerator.update):
(GitHub.request):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
(TestCheckout.test_no_pr_github):
Canonical link: https://commits.webkit.org/248188@main
- 2:06 PM Changeset in webkit [291012] by
-
- 113 edits10 deletes in branches/safari-613-branch
Revert "Cherry-pick r288701. rdar://problem/83734079"
This reverts commit r291000.
- 1:58 PM Changeset in webkit [291011] by
-
- 4 edits in trunk/Tools
[git-webkit] Set bug tracker usernames from contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237608
<rdar://problem/89971547>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py:
(Scm.init): Set GitHub and bugzilla usernames from contributors.json
Canonical link: https://commits.webkit.org/248187@main
- 1:42 PM Changeset in webkit [291010] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r291006.
https://bugs.webkit.org/show_bug.cgi?id=237618
Introduced build failure.
Reverted changeset:
"The accessibility library should be soft linked optionally"
https://bugs.webkit.org/show_bug.cgi?id=236513
https://commits.webkit.org/r291006
- 1:39 PM Changeset in webkit [291009] by
-
- 3 edits2 adds in trunk
AX: Speech Synthesis no longer returning list of voices in macOS 12.3
https://bugs.webkit.org/show_bug.cgi?id=237584
<rdar://problem/89952347>
Reviewed by Andres Gonzalez.
Source/WTF:
The minimum macOS version was meant to be 13 and above, but we started including 12.x releases inadvertently.
- wtf/PlatformHave.h:
LayoutTests:
- fast/speechsynthesis/voices-non-mock-expected.txt: Added.
- fast/speechsynthesis/voices-non-mock.html: Added.
- 1:25 PM Changeset in webkit [291008] by
-
- 8 edits in trunk
[web-animations] color-interpolation should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237610
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
Since the input for the strings used in comparison for the WPT tests is using toLowerCase(),
we need to also use toLowerCase() for the output, so that "linearRGB" and "linearrgb" are
both correct values for "color-interpolation" values.
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/property-list.js:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::colorInterpolation const):
(WebCore::RenderStyle::setColorInterpolation):
- 12:48 PM Changeset in webkit [291007] by
-
- 13 edits in trunk/Source/bmalloc
[libpas] Report more actionable crash in pas_enumerator
https://bugs.webkit.org/show_bug.cgi?id=237572
Reviewed by Saam Barati.
- Adds PAS_ASSERT_WITH_DETAIL, which can report more detailed crash information than PAS_ASSERT while it is not efficient as much as PAS_ASSERT. We use it only in pas_enumerator related code to report more actionable crash from these code. It is OK since pas_enumerator is not used usually, which will be used only when vmmap is attached.
- Extract enumerate_large_map, enumerate_small_large_map, and enumerate_tiny_large_map to report which part of these functions can crash (in very rare case).
- Ensure pas_thread_local_cache_create's thread_local_cache is exposed after setting up all the data.
- libpas/src/libpas/pas_enumerable_range_list.c:
(pas_enumerable_range_list_append):
(pas_enumerable_range_list_iterate):
(pas_enumerable_range_list_iterate_remote):
- libpas/src/libpas/pas_enumerate_bitfit_heaps.c:
(view_callback):
(enumerate_bitfit_heap_callback):
- libpas/src/libpas/pas_enumerate_initially_unaccounted_pages.c:
(range_list_iterate_add_unaccounted_callback):
(range_list_iterate_exclude_accounted_callback):
- libpas/src/libpas/pas_enumerate_large_heaps.c:
(range_list_iterate_add_large_payload_callback):
(record_span):
(large_map_hashtable_entry_callback):
(small_large_map_hashtable_entry_callback):
(tiny_large_map_hashtable_entry_callback):
(enumerate_large_map):
(enumerate_small_large_map):
(enumerate_tiny_large_map):
(pas_enumerate_large_heaps):
- libpas/src/libpas/pas_enumerate_segregated_heaps.c:
(local_allocator_map_entry_is_empty_or_deleted):
(local_allocator_map_entry_is_empty):
(local_allocator_map_entry_is_deleted):
(collect_shared_page_directories_heap_callback):
(enumerate_exclusive_view):
(enumerate_shared_view):
(enumerate_partial_view):
(shared_page_directory_view_callback):
(size_directory_view_callback):
(consider_allocator):
(pas_enumerate_segregated_heaps):
- libpas/src/libpas/pas_enumerate_unaccounted_pages_as_meta.c:
(pas_enumerate_unaccounted_pages_as_meta):
- libpas/src/libpas/pas_enumerator.c:
(pas_enumerator_create):
(pas_enumerator_read_compact):
(pas_enumerator_read):
(pas_enumerator_add_unaccounted_pages):
(pas_enumerator_exclude_accounted_page):
(pas_enumerator_exclude_accounted_pages):
(pas_enumerator_record):
(pas_enumerator_record_page_payload_and_meta):
- libpas/src/libpas/pas_enumerator.h:
(pas_enumerator_record_kind_get_string):
- libpas/src/libpas/pas_enumerator_region.c:
(pas_enumerator_region_allocate):
- libpas/src/libpas/pas_thread_local_cache.c:
(pas_thread_local_cache_create):
- libpas/src/libpas/pas_utils.c:
(pas_assertion_failed_no_inline):
- libpas/src/libpas/pas_utils.h:
(pas_zero_memory):
- 12:46 PM Changeset in webkit [291006] by
-
- 2 edits in trunk/Source/WebKit
The accessibility library should be soft linked optionally
https://bugs.webkit.org/show_bug.cgi?id=236513
Reviewed by Geoffrey Garen.
The accessibility library should be soft linked optionally, since it is not always present.
- Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::handleAXPreferenceChange):
(WebKit::AuxiliaryProcess::handlePreferenceChange):
- 12:41 PM Changeset in webkit [291005] by
-
- 6 edits24 adds1 delete in trunk/Source/WebGPU
[WGSL] Add enough of the AST for the simplest shaders
https://bugs.webkit.org/show_bug.cgi?id=236655
Reviewed by Myles Maxfield.
These AST nodes are just those required for the most trivial graphics and compute shaders.
I used the machinery from wtf/TypeCasts as suggested by Myles in https://bugs.webkit.org/show_bug.cgi?id=233276.
Currently all of the code for these nodes is included in WGSL.cpp to verify that they build. This will be removed in the parser patch.
Attributes are added in setAttributes methods instead of being part of the constructors, because it can fail, and returning an error from a constructor is tricky.
- WGSL/AST/Attribute.h: Added.
(WGSL::AST::Attribute::Attribute):
(WGSL::AST::Attribute::kind const):
(WGSL::AST::Attribute::isBlock const):
(WGSL::AST::Attribute::isGroup const):
(WGSL::AST::Attribute::isBinding const):
(WGSL::AST::Attribute::isStage const):
(WGSL::AST::Attribute::isLocation const):
(WGSL::AST::Attribute::isBuiltin const):
(WGSL::AST::BlockAttribute::BlockAttribute):
(WGSL::AST::GroupAttribute::GroupAttribute):
(WGSL::AST::GroupAttribute::group const):
(WGSL::AST::BindingAttribute::BindingAttribute):
(WGSL::AST::BindingAttribute::binding const):
(WGSL::AST::StageAttribute::StageAttribute):
(WGSL::AST::StageAttribute::stage const):
(WGSL::AST::BuiltinAttribute::BuiltinAttribute):
(WGSL::AST::BuiltinAttribute::name const):
(WGSL::AST::LocationAttribute::LocationAttribute):
(WGSL::AST::LocationAttribute::location const):
- WGSL/AST/Expression.h: Added.
(WGSL::AST::Expression::Expression):
(WGSL::AST::Expression::kind const):
(WGSL::AST::Expression::isBoolLiteral const):
(WGSL::AST::Expression::isInt32Literal const):
(WGSL::AST::Expression::isUInt32Literal const):
(WGSL::AST::Expression::isFloat32Literal const):
(WGSL::AST::Expression::isIdentifier const):
(WGSL::AST::Expression::isStructureAccess const):
(WGSL::AST::Expression::isTypeConversion const):
- WGSL/AST/Expressions/IdentifierExpression.h: Added.
(WGSL::AST::IdentifierExpression::IdentifierExpression):
(WGSL::AST::IdentifierExpression::identifier const):
- WGSL/AST/Expressions/LiteralExpressions.h: Added.
(WGSL::AST::BoolLiteral::BoolLiteral):
(WGSL::AST::BoolLiteral::value const):
(WGSL::AST::Int32Literal::Int32Literal):
(WGSL::AST::Int32Literal::value const):
(WGSL::AST::Uint32Literal::Uint32Literal):
(WGSL::AST::Uint32Literal::value const):
(WGSL::AST::Float32Literal::Float32Literal):
(WGSL::AST::Float32Literal::value const):
- WGSL/AST/Expressions/StructureAccess.h: Added.
(WGSL::AST::StructureAccess::StructureAccess):
(WGSL::AST::StructureAccess::base):
(WGSL::AST::StructureAccess::fieldName const):
- WGSL/AST/Expressions/TypeConversion.h: Added.
(WGSL::AST::TypeConversion::TypeConversion):
(WGSL::AST::TypeConversion::typeDecl):
(WGSL::AST::TypeConversion::arguments):
- WGSL/AST/FunctionDecl.h: Added.
(WGSL::AST::Parameter::Parameter):
(WGSL::AST::Parameter::setAttributes):
(WGSL::AST::Parameter::builtin const):
(WGSL::AST::Parameter::location const):
(WGSL::AST::Parameter::name const):
(WGSL::AST::Parameter::type):
(WGSL::AST::FunctionDecl::FunctionDecl):
(WGSL::AST::FunctionDecl::setAttributes):
(WGSL::AST::FunctionDecl::setReturnAttributes):
(WGSL::AST::FunctionDecl::entryPointStage const):
(WGSL::AST::FunctionDecl::name const):
(WGSL::AST::FunctionDecl::parameters):
(WGSL::AST::FunctionDecl::returnBuiltin const):
(WGSL::AST::FunctionDecl::returnLocation const):
(WGSL::AST::FunctionDecl::maybeReturnType):
(WGSL::AST::FunctionDecl::body):
- WGSL/AST/GlobalDecl.h: Added.
(WGSL::AST::GlobalDecl::GlobalDecl):
(WGSL::AST::GlobalDecl::kind const):
(WGSL::AST::GlobalDecl::isGlobalVariable const):
(WGSL::AST::GlobalDecl::isStruct const):
(WGSL::AST::GlobalDecl::isFunction const):
- WGSL/AST/GlobalDirective.h: Added.
(WGSL::AST::GlobalDirective::name const):
- WGSL/AST/GlobalVariableDecl.h: Added.
(WGSL::AST::GlobalVariableDecl::GlobalVariableDecl):
(WGSL::AST::GlobalVariableDecl::setAttributes):
(WGSL::AST::GlobalVariableDecl::group const):
(WGSL::AST::GlobalVariableDecl::binding const):
(WGSL::AST::GlobalVariableDecl::name const):
(WGSL::AST::GlobalVariableDecl::maybeQualifier):
(WGSL::AST::GlobalVariableDecl::maybeTypeDecl):
(WGSL::AST::GlobalVariableDecl::maybeInitializer):
- WGSL/AST/Shader.h: Renamed from Source/WebGPU/WGSL/AST.h.
- WGSL/AST/Statement.h: Added.
(WGSL::AST::Statement::Statement):
(WGSL::AST::Statement::kind const):
(WGSL::AST::Statement::isCompound const):
(WGSL::AST::Statement::isReturn const):
(WGSL::AST::Statement::isAssignment const):
- WGSL/AST/Statements/AssignmentStatement.h: Added.
(WGSL::AST::AssignmentStatement::AssignmentStatement):
(WGSL::AST::AssignmentStatement::maybeLhs):
(WGSL::AST::AssignmentStatement::rhs):
- WGSL/AST/Statements/ReturnStatement.h: Added.
(WGSL::AST::ReturnStatement::ReturnStatement):
(WGSL::AST::ReturnStatement::maybeExpression):
- WGSL/AST/StructureDecl.h: Added.
(WGSL::AST::StructMember::StructMember):
(WGSL::AST::StructMember::setAttributes):
(WGSL::AST::StructMember::builtin const):
(WGSL::AST::StructMember::location const):
(WGSL::AST::StructMember::name const):
(WGSL::AST::StructMember::type):
(WGSL::AST::StructDecl::StructDecl):
(WGSL::AST::StructDecl::setAttributes):
(WGSL::AST::StructDecl::isBlock const):
(WGSL::AST::StructDecl::name const):
(WGSL::AST::StructDecl::members):
- WGSL/AST/TypeDecl.h: Added.
(WGSL::AST::TypeDecl::TypeDecl):
(WGSL::AST::TypeDecl::kind const):
(WGSL::AST::TypeDecl::isNamed const):
(WGSL::AST::TypeDecl::isParameterized const):
- WGSL/AST/VariableQualifier.h: Added.
(WGSL::AST::VariableQualifier::VariableQualifier):
(WGSL::AST::VariableQualifier::storageClass const):
(WGSL::AST::VariableQualifier::accessMode const):
- WGSL/ASTNode.h: Added.
(WGSL::AST::ASTNode::ASTNode):
(WGSL::AST::ASTNode::span const):
- WGSL/CompilationMessage.cpp: Added.
(WGSL::CompilationMessage::dump const):
- WGSL/CompilationMessage.h: Added.
(WGSL::CompilationMessage::CompilationMessage):
- WGSL/WGSL.cpp:
- WGSL/WGSL.h:
- WebGPU.xcodeproj/project.pbxproj:
- 12:15 PM Changeset in webkit [291004] by
-
- 3 edits in trunk/Source/WebGPU
[WGSL] The lexer should use the functions from wtf/ASCIICType.h
https://bugs.webkit.org/show_bug.cgi?id=236783
Reviewed by Darin Adler.
I was not aware of these functions when I wrote the lexer, and I ended up reimplementing them.
Reusing them is both simpler, and slightly more efficient as some of them (especially isASCIISpace) have been optimized.
- WGSL/Lexer.cpp:
(WGSL::Lexer<T>::lex):
(WGSL::Lexer<T>::skipWhitespace):
(WGSL::Lexer<T>::parseDecimalInteger):
(WGSL::Lexer<T>::parseDecimalFloatExponent):
(WGSL::Lexer<T>::isWhiteSpace): Deleted.
(WGSL::Lexer<T>::isIdentifierStart): Deleted.
(WGSL::Lexer<T>::isValidIdentifierCharacter): Deleted.
(WGSL::Lexer<T>::isDecimal): Deleted.
(WGSL::Lexer<T>::isHexadecimal): Deleted.
(WGSL::Lexer<T>::readDecimal): Deleted.
(WGSL::Lexer<T>::readHexadecimal): Deleted.
- WGSL/Lexer.h:
- 12:05 PM Changeset in webkit [291003] by
-
- 77 edits in trunk/Source
Optimize further the passing of data across threads
https://bugs.webkit.org/show_bug.cgi?id=237568
Reviewed by Geoffrey Garen.
Optimize further the passing of data across threads by leveraging more broadly the optimized
versions of isolatedCopy() on r-value references.
Source/WebCore:
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::listDirectory):
(WebCore::DOMFileSystem::getParent):
(WebCore::DOMFileSystem::getEntry):
(WebCore::DOMFileSystem::getFile):
- Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp:
(WebCore::WorkerFileSystemStorageConnection::isSameEntry):
(WebCore::WorkerFileSystemStorageConnection::getFileHandle):
(WebCore::WorkerFileSystemStorageConnection::getDirectoryHandle):
(WebCore::WorkerFileSystemStorageConnection::removeEntry):
(WebCore::WorkerFileSystemStorageConnection::resolve):
(WebCore::WorkerFileSystemStorageConnection::getFile):
(WebCore::WorkerFileSystemStorageConnection::createSyncAccessHandle):
(WebCore::WorkerFileSystemStorageConnection::closeSyncAccessHandle):
(WebCore::WorkerFileSystemStorageConnection::getHandleNames):
(WebCore::WorkerFileSystemStorageConnection::getHandle):
(WebCore::WorkerFileSystemStorageConnection::move):
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/shared/IndexKey.cpp:
(WebCore::IndexKey::isolatedCopy const):
(WebCore::IndexKey::isolatedCopy):
- Modules/indexeddb/shared/IndexKey.h:
- Modules/storage/StorageManager.cpp:
(WebCore::StorageManager::fileSystemAccessGetDirectory):
- Modules/storage/WorkerStorageConnection.cpp:
(WebCore::WorkerStorageConnection::fileSystemGetDirectory):
- Modules/webaudio/AudioWorkletGlobalScope.cpp:
(WebCore::AudioWorkletGlobalScope::registerProcessor):
- crypto/CryptoAlgorithm.cpp:
(WebCore::dispatchAlgorithmOperation):
- dom/ExceptionOr.h:
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- fileapi/ThreadableBlobRegistry.h:
- workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::startScriptFetchForServer):
- workers/service/SWClientConnection.h:
- workers/service/ServiceWorkerClients.cpp:
(WebCore::ServiceWorkerClients::get):
(WebCore::ServiceWorkerClients::matchAll):
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::notifyFailedFetchingScript):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerJobClient.h:
- workers/service/WorkerSWClientConnection.cpp:
(WebCore::WorkerSWClientConnection::registerServiceWorkerClient):
(WebCore::WorkerSWClientConnection::finishFetchingScriptInServer):
(WebCore::WorkerSWClientConnection::scheduleUnregisterJobInServer):
(WebCore::WorkerSWClientConnection::subscribeToPushService):
(WebCore::WorkerSWClientConnection::unsubscribeFromPushService):
(WebCore::WorkerSWClientConnection::getPushSubscription):
(WebCore::WorkerSWClientConnection::getPushPermissionState):
- workers/service/WorkerSWClientConnection.h:
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::doPushChanges):
- worklets/Worklet.cpp:
(WebCore::Worklet::addModule):
Source/WebKit:
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics):
(WebKit::ResourceLoadStatisticsDatabaseStore::clear):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking):
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::removeDataRecords):
(WebKit::ResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsStore::updateCookieBlockingForDomains):
(WebKit::ResourceLoadStatisticsStore::logTestingEvent):
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResourceForDebugMode):
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::logCrossSiteLoadWithLinkDecoration):
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setLastSeen):
(WebKit::WebResourceLoadStatisticsStore::mergeStatisticForTesting):
(WebKit::WebResourceLoadStatisticsStore::isRelationshipOnlyInDatabaseOnce):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::dumpResourceLoadStatistics):
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubresourceUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo):
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameDomain):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameDomain):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::WebResourceLoadStatisticsStore::insertExpiredStatisticForTesting):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::updateQuotaBasedOnSpaceUsageForTesting):
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFilesForIndexedDB):
(WebKit::NetworkConnectionToWebProcess::logUserInteraction):
(WebKit::NetworkConnectionToWebProcess::hasStorageAccess):
(WebKit::NetworkConnectionToWebProcess::requestStorageAccess):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::isGrandfathered):
(WebKit::NetworkProcess::isPrevalentResource):
(WebKit::NetworkProcess::isVeryPrevalentResource):
(WebKit::NetworkProcess::setGrandfathered):
(WebKit::NetworkProcess::setPrevalentResource):
(WebKit::NetworkProcess::setPrevalentResourceForDebugMode):
(WebKit::NetworkProcess::setVeryPrevalentResource):
(WebKit::NetworkProcess::clearPrevalentResource):
(WebKit::NetworkProcess::setSubframeUnderTopFrameDomain):
(WebKit::NetworkProcess::isRegisteredAsRedirectingTo):
(WebKit::NetworkProcess::isRegisteredAsSubFrameUnder):
(WebKit::NetworkProcess::setSubresourceUnderTopFrameDomain):
(WebKit::NetworkProcess::setSubresourceUniqueRedirectTo):
(WebKit::NetworkProcess::setSubresourceUniqueRedirectFrom):
(WebKit::NetworkProcess::isRegisteredAsSubresourceUnder):
(WebKit::NetworkProcess::setTopFrameUniqueRedirectTo):
(WebKit::NetworkProcess::setTopFrameUniqueRedirectFrom):
(WebKit::NetworkProcess::setLastSeen):
(WebKit::NetworkProcess::mergeStatisticForTesting):
(WebKit::NetworkProcess::insertExpiredStatisticForTesting):
(WebKit::NetworkProcess::logFrameNavigation):
(WebKit::NetworkProcess::logUserInteraction):
(WebKit::NetworkProcess::hadUserInteraction):
(WebKit::NetworkProcess::isRelationshipOnlyInDatabaseOnce):
(WebKit::NetworkProcess::clearUserInteraction):
(WebKit::NetworkProcess::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::NetworkProcess::setCrossSiteLoadWithLinkDecorationForTesting):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::deleteCookiesForTesting):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
(WebKit::NetworkProcess::didIncreaseQuota):
(WebKit::NetworkProcess::renameOriginInWebsiteData):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setResourceLoadStatisticsEnabled):
(WebKit::NetworkSession::deleteAndRestrictWebsiteDataForRegistrableDomains):
- NetworkProcess/NetworkSession.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::clearForRegistrableDomain):
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerInterface.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:
(WebKit::PCM::ManagerProxy::clearForRegistrableDomain):
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.cpp:
(WebKit::PCM::Store::attributePrivateClickMeasurement):
(WebKit::PCM::Store::privateClickMeasurementToStringForTesting const):
(WebKit::PCM::Store::clearPrivateClickMeasurementForRegistrableDomain):
(WebKit::PCM::Store::clearSentAttribution):
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.h:
- NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h:
(WebKit::LocalStorageDatabaseTracker::OriginDetails::isolatedCopy const):
(WebKit::LocalStorageDatabaseTracker::OriginDetails::isolatedCopy):
- NetworkProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::getSessionStorageOriginsCrossThreadCopy const):
(WebKit::StorageManager::getLocalStorageOriginsCrossThreadCopy const):
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeFile):
(WebKit::CacheStorage::Engine::readFile):
(WebKit::CacheStorage::Engine::removeFile):
(WebKit::CacheStorage::Engine::writeSizeFile):
(WebKit::CacheStorage::Engine::getDirectories):
(WebKit::CacheStorage::Engine::clearCachesForOriginFromDirectories):
(WebKit::CacheStorage::Engine::deleteNonEmptyDirectoryOnBackgroundThread):
- NetworkProcess/cache/CacheStorageEngine.h:
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::RecordInformation::isolatedCopy):
(WebKit::CacheStorage::TraversalResult::isolatedCopy):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::isolatedCopy): Deleted.
- NetworkProcess/cache/CacheStorageEngineCache.h:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::retrieveOriginFromDirectory):
(WebKit::CacheStorage::Caches::clear):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::clear):
- NetworkProcess/cache/NetworkCacheIOChannel.h:
(WebKit::NetworkCache::IOChannel::open):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::clear):
- NetworkProcess/cache/NetworkCacheStorage.h:
- NetworkProcess/storage/IDBStorageConnectionToClient.cpp:
(WebKit::IDBStorageConnectionToClient::didGetAllDatabaseNamesAndVersions):
- NetworkProcess/storage/IDBStorageConnectionToClient.h:
- NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::didIncreaseQuota):
(WebKit::NetworkStorageManager::moveData):
(WebKit::NetworkStorageManager::registerTemporaryBlobFilePaths):
(WebKit::NetworkStorageManager::resetQuotaUpdatedBasedOnUsageForTesting):
- NetworkProcess/storage/NetworkStorageManager.h:
- Shared/API/APIString.h:
- Shared/WebsiteData/WebsiteData.cpp:
(WebKit::WebsiteData::isolatedCopy const):
(WebKit::WebsiteData::isolatedCopy):
(WebKit::WebsiteData::Entry::isolatedCopy const):
(WebKit::WebsiteData::Entry::isolatedCopy):
- Shared/WebsiteData/WebsiteData.h:
- UIProcess/API/APIContentRuleListStore.cpp:
(API::createExtension):
(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::compileContentRuleList):
(API::ContentRuleListStore::removeContentRuleList):
(API::ContentRuleListStore::getContentRuleListSource):
- UIProcess/API/APIContentRuleListStore.h:
- UIProcess/API/glib/WebKitUserContentFilterStore.cpp:
(webkitUserContentFilterStoreSaveBytes):
- UIProcess/DeviceIdHashSaltStorage.cpp:
(WebKit::DeviceIdHashSaltStorage::deleteHashSaltFromDisk):
- UIProcess/DeviceIdHashSaltStorage.h:
(WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin::HashSaltForOrigin):
(WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin::isolatedCopy const):
(WebKit::DeviceIdHashSaltStorage::HashSaltForOrigin::isolatedCopy):
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::isolatedCopy const):
(WebKit::WebsiteDataRecord::isolatedCopy):
- UIProcess/WebsiteData/WebsiteDataRecord.h:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::finishFetchingScriptInServer):
(WebKit::WebSWClientConnection::registerServiceWorkerClient):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish):
Source/WebKitLegacy:
- Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::didGetAllDatabaseNamesAndVersions):
- Storage/InProcessIDBServer.h:
- Storage/StorageTracker.cpp:
(WebKit::StorageTracker::deleteOrigin):
- 11:29 AM Changeset in webkit [291002] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.9
- 11:27 AM Changeset in webkit [291001] by
-
- 4 edits in trunk/Source
Disable CFURLCache in WebKit
https://bugs.webkit.org/show_bug.cgi?id=237575
Reviewed by Geoffrey Garen.
Source/WebKit:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::addStorageSession):
Source/WebKitLegacy:
- WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::ensureSession):
- 11:17 AM Changeset in webkit [291000] by
-
- 113 edits10 adds in branches/safari-613-branch
Cherry-pick r288701. rdar://problem/83734079
"Unrecognized Content-Security-Policy directive 'worker-src'."
https://bugs.webkit.org/show_bug.cgi?id=235260
<rdar://problem/83734079>
Reviewed by Brent Fulgham.
LayoutTests/imported/w3c:
- web-platform-tests/content-security-policy/child-src/child-src-cross-origin-load.sub-expected.txt:
- web-platform-tests/content-security-policy/child-src/child-src-worker-blocked.sub-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/sharedworker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-none/worker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/sharedworker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-self/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-none.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-child-fallback-blocked.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-script-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/dedicated-worker-src-self-fallback.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/service-none.https.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/service-worker-src-child-fallback-blocked.https.sub-expected.txt:
- web-platform-tests/content-security-policy/worker-src/shared-child.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-list.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-none.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-self.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-child-fallback-blocked.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-child-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-default-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-script-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/worker-src/shared-worker-src-self-fallback.sub-expected.txt: Added.
- web-platform-tests/content-security-policy/blob/self-doesnt-match-blob.sub-expected.txt:
- web-platform-tests/content-security-policy/blob/star-doesnt-match-blob.sub-expected.txt:
- web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/sharedworker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-classic.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-classic.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-import.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-module.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-none/worker-module.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/sharedworker-import-data.https-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worker-import-data.http-expected.txt:
- web-platform-tests/content-security-policy/gen/top.meta/worker-src-self/worker-import-data.https-expected.txt:
Source/WebCore:
Implementation of worker-src directive. According to https://www.w3.org/TR/CSP3/#changes-from-level-2
the worker-src directive now restricts URLs that can be loaded by
workers, and defers to child-src if not specified.
- bindings/js/WorkerModuleScriptLoader.cpp: (WebCore::WorkerModuleScriptLoader::load): Check worker-src instead of child-src for worker loads.
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy):
- loader/ThreadableLoader.h: Check worker-src instead of child-src for worker loads.
- page/csp/ContentSecurityPolicy.cpp: We can remove allowChildContextFromSource which is now fully replaced by allowWorkerFromSource.
(WebCore::ContentSecurityPolicy::allowWorkerFromSource const):
(WebCore::ContentSecurityPolicy::allowChildContextFromSource const): Deleted.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::operativeDirectiveForWorkerSrc const): worker-src defers to child-src, then script-src, then default-src.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForWorker):
(WebCore::ContentSecurityPolicyDirectiveList::addDirective):
- page/csp/ContentSecurityPolicyDirectiveList.h:
- page/csp/ContentSecurityPolicyDirectiveNames.cpp:
- page/csp/ContentSecurityPolicyDirectiveNames.h:
- workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL):
- workers/AbstractWorker.h: We check LegacySchemeRegistry::schemeShouldBypassContentSecurityPolicy in allowWorkerFromSource, so we don't need to check in in AbstractWorker::resolveURL anymore. We can also replace the child-src checks with worker-src ones.
- workers/Worker.cpp: (WebCore::Worker::create):
- workers/WorkerFontLoadRequest.cpp: (WebCore::WorkerFontLoadRequest::load):
- workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::addRegistration): Block service worker registrations not specified by worker-src.
- workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::create): Block shared worker urls not specified by worker-src.
- workers/shared/SharedWorkerScriptLoader.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
Source/WebKit:
- NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy):
LayoutTests:
Update tests now that worker-src defaults eventually to script-src.
Since this was not the case with child-src, legacy CSP tests do not
expect script-src policies to affect workers. We can fix this by
specifying a separate worker-src policy for these tests to maintain
behavior.
- TestExpectations: Some wpt tests log random URL strings that change for every test iteration. For now we can't unskip those.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp.html:
- http/tests/security/contentSecurityPolicy/worker-script-src.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-eval.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScript-redirect-cross-origin.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-xhr.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:12 AM Changeset in webkit [290999] by
-
- 2 edits in trunk/Source/WebCore
UniqueIDBDatabase::didFireVersionChangeEvent should capture identifier of UniqueIDBDatabaseConnection
https://bugs.webkit.org/show_bug.cgi?id=236950
rdar://problem/89218299
Reviewed by Chris Dumez.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::didFireVersionChangeEvent):
- 10:40 AM Changeset in webkit [290998] by
-
- 7 edits in trunk
File System Access: disallow empty name in FileSystemHandle
https://bugs.webkit.org/show_bug.cgi?id=237563
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt:
Source/WebKit:
Updated expectations of imported wpt tests.
- NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::isValidFileName):
- 9:29 AM Changeset in webkit [290997] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Flash media controls when a fullscreen video resets its source
https://bugs.webkit.org/show_bug.cgi?id=237493
Reviewed by Jer Noble.
Source/WebCore:
Some pages reset the fullscreen video's source when a user rotates the device.
The screen will become black for a while, and users might think the player is broken.
With this patch, the player will show the media controls for 1 second when the source
is changed, so that users will know the player is working.
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
_presentingViewControlleris only used for watchOS.
(-[WebAVPlayerViewController flashPlaybackControlsWithDuration:]):
(VideoFullscreenInterfaceAVKit::setPlayerIdentifier):
Source/WebCore/PAL:
- pal/spi/cocoa/AVKitSPI.h:
- 9:15 AM Changeset in webkit [290996] by
-
- 2 edits in trunk/Source/WebKit
Expand adattributiond sandbox to prevent sandbox exceptions during main functionality
https://bugs.webkit.org/show_bug.cgi?id=237580
<rdar://89855243>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Per Arne Vollan.
- Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:
- 9:03 AM Changeset in webkit [290995] by
-
- 29 edits15 adds32 deletes in trunk
WebSocket.send() should synchronously update bufferedAmount
https://bugs.webkit.org/show_bug.cgi?id=235707
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/websockets/Send-binary-65K-arraybuffer.any.worker-expected.txt:
- web-platform-tests/websockets/Send-binary-arraybuffer.any.worker-expected.txt:
- web-platform-tests/websockets/Send-data.any.worker-expected.txt:
- web-platform-tests/websockets/Send-paired-surrogates.any.worker-expected.txt:
- web-platform-tests/websockets/Send-unicode-data.any.worker-expected.txt:
- web-platform-tests/websockets/bufferedAmount-unchanged-by-sync-xhr.any.worker-expected.txt:
- web-platform-tests/websockets/interfaces/WebSocket/close/close-basic-expected.txt:
- web-platform-tests/websockets/interfaces/WebSocket/close/close-connecting-expected.txt:
Source/WebCore:
This matches the behavior of Chrome and Firefox and is covered by web platform tests.
- Modules/websockets/ThreadableWebSocketChannel.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::enqueueTextFrame):
- Modules/websockets/WebSocketChannel.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
Source/WebKit:
- WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::send):
- WebProcess/Network/WebSocketChannel.h:
- 8:56 AM Changeset in webkit [290994] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r290853): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::FrameLoader::clear
https://bugs.webkit.org/show_bug.cgi?id=237565
<rdar://problem/88356074>
Reviewed by Chris Dumez.
No new tests. Fixes crashing test: accessibility/mac/value-change/value-change-user-info-textarea.html
newDocument may be the frame's document. We should make it a RefPtr
because it could get set to null in this function.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
- loader/FrameLoader.h:
- 8:42 AM Changeset in webkit [290993] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Enable ThinLTO
https://bugs.webkit.org/show_bug.cgi?id=229019
<rdar://problem/82107543>
Reviewed by Mark Lam.
It's a 1% speedup on Speedometer2 across x86 and arm64, and 0.5-1% speedup on
JetStream2 depending on the device.
- Configurations/Base.xcconfig:
- 8:24 AM Changeset in webkit [290992] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, silence console logging for http/tests/security/cookie-module-import-propagate.html
<rdar://88842347>
This is to address flakiness on the bots.
- TestExpectations:
- http/tests/security/cookie-module-import-propagate-expected.txt:
- 8:17 AM Changeset in webkit [290991] by
-
- 3 edits in trunk/LayoutTests
[ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures
https://bugs.webkit.org/show_bug.cgi?id=237548
rdar://problem/89923849
Unreviewed test gardening.
These console messages differing is causing test failures, fixing expectations.
- http/wpt/webauthn/public-key-credential-create-failure-local-silent.https-expected.txt:
- http/wpt/webauthn/public-key-credential-create-failure-local.https-expected.txt:
- 7:37 AM Changeset in webkit [290990] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r290975.
Broke the build for some configurations
Reverted changeset:
"[XCBuild] Emit a discovered dependency file from offlineasm"
https://bugs.webkit.org/show_bug.cgi?id=237329
https://commits.webkit.org/r290975
- 7:33 AM Changeset in webkit [290989] by
-
- 4 edits in trunk/Source/WebKit
Remove unneeded Async keywords in messages.in files after r290903
https://bugs.webkit.org/show_bug.cgi?id=237574
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-08
Reviewed by Chris Dumez.
- GPUProcess/graphics/wc/RemoteWCLayerTreeHost.messages.in:
- Scripts/webkit/tests/TestWithSuperclass.messages.in:
- WebProcess/glib/UserMediaCaptureManager.messages.in:
- 6:50 AM Changeset in webkit [290988] by
-
- 12 edits in trunk/Source
[GTK] Sync gtk-overlay-scrolling setting to web process
https://bugs.webkit.org/show_bug.cgi?id=236476
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-03-08
Reviewed by Adrian Perez de Castro.
Source/WebCore:
- platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::usesOverlayScrollbars const):
- platform/gtk/GtkUtilities.cpp:
(WebCore::shouldUseOverlayScrollbars):
- platform/gtk/GtkUtilities.h:
- platform/gtk/RenderThemeScrollbar.cpp:
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
Source/WebKit:
- Shared/gtk/GtkSettingsState.cpp:
(WebKit::GtkSettingsState::encode const):
(WebKit::GtkSettingsState::decode):
- Shared/gtk/GtkSettingsState.h:
- UIProcess/gtk/GtkSettingsManager.cpp:
(WebKit::GtkSettingsManager::overlayScrolling const):
(WebKit::GtkSettingsManager::settingsDidChange):
(WebKit::GtkSettingsManager::GtkSettingsManager):
- UIProcess/gtk/GtkSettingsManager.h:
- WebProcess/gtk/GtkSettingsManagerProxy.cpp:
(WebKit::GtkSettingsManagerProxy::applySettings):
- 5:42 AM Changeset in webkit [290987] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
ANGLE display cache does not work with explicit device ids
https://bugs.webkit.org/show_bug.cgi?id=237522
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-03-08
Reviewed by Kenneth Russell.
Add EGL_PLATFORM_ANGLE_DEVICE_ID_HIGH_ANGLE, EGL_PLATFORM_ANGLE_DEVICE_ID_LOW_ANGLE
to the display cache key, so that a request for a display with an explicit device does
not get resolved with a display without explicit device or with a display with another
explicit device.
WebKit tests will be added once this will be used.
ANGLE tests will be added once upstreamed.
- src/libANGLE/Display.cpp:
(egl::Display::GetDisplayFromNativeDisplay):
(egl::Display::~Display):
- 5:31 AM Changeset in webkit [290986] by
-
- 2 edits in trunk/Source/WebCore
[EME][Thunder] Disable hasBrokenEncryptedMediaAPISupportQuirk
https://bugs.webkit.org/show_bug.cgi?id=237595
Reviewed by Philippe Normand.
Hulu and YouTube work fine with Thunder, no need for this quirk.
Patch based on one by Eugene Mutavchi <Ievgen_Mutavchi@comcast.com>.
- page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
Return false if Thunder build is enabled.
- 4:24 AM Changeset in webkit [290985] by
-
- 45 edits2 adds in trunk
Add a preference to mute video capture in case audio capture gets interrupted
https://bugs.webkit.org/show_bug.cgi?id=237524
<rdar://78421282>
Reviewed by Eric Carlson.
Source/WebCore:
In case we detect that a microphone track source gets muted due to interruption, we mute
capture video tracks based if allowed by the new MuteCameraOnMicrophoneInterruptionEnabled setting.
Add support for mock microphone interruption and remove previous in process internals API.
Test: fast/mediastream/media-stream-video-track-interrupted-from-audio.html
- Modules/mediastream/MediaStreamTrack.cpp:
- Modules/mediastream/MediaStreamTrack.h:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- platform/mediastream/mac/CoreAudioCaptureSource.h:
- platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::setIsInterrupted):
- platform/mock/MockRealtimeAudioSource.h:
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::setMockCaptureDevicesInterrupted):
(WebCore::MockRealtimeMediaSourceCenter::setMockCameraIsInterrupted): Deleted.
- platform/mock/MockRealtimeMediaSourceCenter.h:
Source/WebKit:
Add support for interrupt mock microphone devices.
Send to WebProcess sources whether sources are interrupted each time the source muted value changes.
Store that value in remote sources.
- GPUProcess/GPUProcess.cpp:
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
- UIProcess/GPU/GPUProcessProxy.cpp:
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/cocoa/RemoteRealtimeAudioSource.h:
- WebProcess/cocoa/RemoteRealtimeDisplaySource.h:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
- WebProcess/cocoa/RemoteRealtimeVideoSource.h:
- WebProcess/cocoa/UserMediaCaptureManager.cpp:
- WebProcess/cocoa/UserMediaCaptureManager.h:
- WebProcess/cocoa/UserMediaCaptureManager.messages.in:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
Add support for interrupt mock microphone devices.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
LayoutTests:
- fast/mediastream/media-stream-video-track-interrupted-from-audio-expected.txt: Added.
- fast/mediastream/media-stream-video-track-interrupted-from-audio.html: Added.
- fast/mediastream/media-stream-video-track-interrupted.html: Migrated to testRunner API.
- fast/mediastream/track-ended-while-muted.html:
- platform/glib/TestExpectations:
- 4:21 AM Changeset in webkit [290984] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Handle gst pad error as format error
https://bugs.webkit.org/show_bug.cgi?id=237526
Reviewed by Xabier Rodriguez-Calvar.
This patch is authored by Eugene Mutavchi <Ievgen_Mutavchi@comcast.com>
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/797
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- 1:25 AM Changeset in webkit [290983] by
-
- 4 edits4 moves1 add in trunk/Source/WebCore
PDF.js content script is adding custom cocoa style unconditionally
https://bugs.webkit.org/show_bug.cgi?id=237516
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-03-08
Reviewed by Tim Nguyen.
Add the custom style from the WebKit code instead of injected content script to make it easier to add the style
depending on the platform. Move current cocoa specific style files to a cocoa directory.
- Modules/pdfjs-extras/cocoa/arrow.down.circle@2x.png: Renamed from Source/WebCore/Modules/pdfjs-extras/arrow.down.circle@2x.png.
- Modules/pdfjs-extras/cocoa/minus.magnifyingglass@2x.png: Renamed from Source/WebCore/Modules/pdfjs-extras/minus.magnifyingglass@2x.png.
- Modules/pdfjs-extras/cocoa/plus.magnifyingglass@2x.png: Renamed from Source/WebCore/Modules/pdfjs-extras/plus.magnifyingglass@2x.png.
- Modules/pdfjs-extras/cocoa/style.css: Renamed from Source/WebCore/Modules/pdfjs-extras/style-cocoa.css.
- Modules/pdfjs-extras/content-script.js:
(const.PDFJSContentScript.injectStyle): Deleted.
(const.PDFJSContentScript.init): Deleted.
- html/PDFDocument.cpp:
(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocument::injectStyleAndContentScript):
(WebCore::PDFDocument::injectContentScript): Deleted.
- html/PDFDocument.h:
- 1:13 AM Changeset in webkit [290982] by
-
- 3 edits in trunk/Tools
[GTK][WPE] Do not add new modules under ThirdParty to the tarball
https://bugs.webkit.org/show_bug.cgi?id=237519
Reviewed by Michael Catanzaro.
We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every
time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and
manually add what we need instead.
- gtk/manifest.txt.in:
- wpe/manifest.txt.in:
- 1:09 AM Changeset in webkit [290981] by
-
- 3 edits1 add in trunk
Remove invalid ASSERT in LocaleIDBuilder::overrideLanguageScriptRegion().
https://bugs.webkit.org/show_bug.cgi?id=237573
<rdar://problem/83326232>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/handle-empty-localeID-in-localeIDBufferForLanguageTagWithNullTerminator.js: Added.
Source/JavaScriptCore:
The ASSERT(length) in LocaleIDBuilder::overrideLanguageScriptRegion() is simply
incorrect. The length can be 0 if uloc_forLanguageTag returns a 0 length in
localeIDBufferForLanguageTagWithNullTerminator(). LocaleIDBuilder::overrideLanguageScriptRegion()
already handles this scenario correctly. We just need to remove this incorrect ASSERT.
Also verified that we're producing the same result on the attached test case as
Chrome and Firefox produces.
- runtime/IntlObject.cpp:
(JSC::localeIDBufferForLanguageTagWithNullTerminator):
- 12:55 AM Changeset in webkit [290980] by
-
- 5 edits in trunk/Source/WebCore
[WinCairo] GraphicsContextGL should have one more output texture for double buffering WebGL
https://bugs.webkit.org/show_bug.cgi?id=237460
Reviewed by Žan Doberšek.
WinCairo's GraphicsContextGL had only a single output texture. If the
page was interactive WebGL, the user interaction was causing the
rendering to the texture while the compositor is running.
Coordinated Graphics has another output texture m_compositorTexture.
This change reuses the code for WinCairo.
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::prepareTextureImpl):
- platform/graphics/angle/GraphicsContextGLANGLE.h:
- platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapper::platformInitialize):
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLTextureMapper::reshapeDisplayBufferBacking):
- platform/graphics/texmap/TextureMapperGCGLPlatformLayer.cpp:
(WebCore::TextureMapperGCGLPlatformLayer::paintToTextureMapper):
- 12:53 AM Changeset in webkit [290979] by
-
- 8 edits in trunk
Improve WebRTC VPX media capabilities accuracy
https://bugs.webkit.org/show_bug.cgi?id=237462
Reviewed by Eric Carlson.
Source/WebCore:
Reuse VPx decoder media capabilities routines for WebRTC.
Use caseless string comparison for content type.
Covered by updated tests.
- platform/graphics/cocoa/VP9UtilitiesCocoa.h:
- platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
LayoutTests:
- webrtc/video-mute-vp8.html:
- webrtc/vp9-expected.txt:
- webrtc/vp9.html:
- 12:06 AM Changeset in webkit [290978] by
-
- 4 edits in trunk
Add early return for empty path in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=237540
rdar://89901536
Reviewed by Chris Dumez.
Source/WTF:
- wtf/posix/FileSystemPOSIX.cpp:
(WTF::FileSystemImpl::makeAllDirectories):
Tools:
- TestWebKitAPI/Tests/WTF/FileSystem.cpp:
(TestWebKitAPI::TEST_F):
- 12:01 AM Changeset in webkit [290977] by
-
- 3 edits9 deletes in trunk/LayoutTests
Resync web-platform-tests/beacon from upstream
https://bugs.webkit.org/show_bug.cgi?id=237536
LayoutTests/imported/w3c:
Unreviewed, drop web-platform-tests/beacon tests that are no longer upstream (as of 30d5f8f4c7687a4f2c0).
- web-platform-tests/beacon/beacon-basic-blob-expected.txt: Removed.
- web-platform-tests/beacon/beacon-navigate-expected.txt: Removed.
- web-platform-tests/beacon/beacon-redirect.sub.window-expected.txt: Removed.
- web-platform-tests/beacon/beacon-redirect.sub.window.html: Removed.
- web-platform-tests/beacon/resources/beacon-preflight.py: Removed.
(respondToCORSPreflight): Deleted.
(main): Deleted.
- web-platform-tests/beacon/resources/redirect.py: Removed.
(main): Deleted.
- web-platform-tests/beacon/resources/upgrade-iframe.html: Removed.
- web-platform-tests/beacon/upgrade-beacon.https-expected.txt: Removed.
- web-platform-tests/beacon/upgrade-beacon.https.html: Removed.
LayoutTests:
Unreviewed, drop web-platform-tests/beacon tests that are no longer upstream.
Mar 7, 2022:
- 11:28 PM Changeset in webkit [290976] by
-
- 16 edits in trunk/Source
Rename VolatilityState to SetNonVolatileResult
https://bugs.webkit.org/show_bug.cgi?id=237562
Reviewed by Tim Horton.
Pure rename. I want to use VolatilityState to actually reflect state.
Source/WebCore:
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::setNonVolatile):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::state const):
(WebCore::IOSurface::setVolatile):
(WebCore::operator<<):
Source/WebKit:
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfaceNonVolatile):
(WebKit::RemoteRenderingBackend::swapToValidFrontBuffer):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::setBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::didMakeFrontBufferNonVolatile):
- UIProcess/ViewSnapshotStore.h:
- UIProcess/mac/ViewSnapshotStoreMac.mm:
(WebKit::ViewSnapshot::setVolatile):
(WebKit::ViewSnapshot::asLayerContents):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::markSurfaceNonVolatile):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- 11:18 PM Changeset in webkit [290975] by
-
- 8 edits in trunk/Source/JavaScriptCore
[XCBuild] Emit a discovered dependency file from offlineasm
https://bugs.webkit.org/show_bug.cgi?id=237329
Reviewed by Keith Miller.
Xcode needs to know what files offlineasm uses and produces in order to schedule it
correctly in incremental builds. Rather than use generated xcfilelists like WebKit does
elsewhere in the project, emit a depfile from offlineasm based on the parse tree's source
files.
Discovered dependency files ("depfiles") are Makefile-formatted files which list the inputs
used to produce an output. They are emitting during the build to a temporary directory, and
ensure that subsequent incremental builds will re-run offlineasm when any of the included
sources change. This is the same mechanism clang uses to track header dependencies.
Unfortunately, the legacy build system will refuse to execute a script phase or rule that
emits a depfile. To work around this, convert the offlineasm pipeline to be based on build
rules, to be used by XCBuild only. The idea is that LowLevelInterpreter.asm is listed as a
source build file in JSCLLIntSettingsExtractor, JSCLLIntOffsetsExtractor, and
JavaScriptCore. Each target uses a build rule to generate its respective header from
LowLevelInterpreter.asm. Xcode schedules these rule executions before any clang tasks.
The legacy build system avoids executing the rules via EXCLUDED_SOURCE_FILE_NAMES, and
instead uses the existing build phases, which have "(Legacy)" in their names and are now
no-ops under XCBuild.
Aside from working around the legacy build system's limitations, using build rules is
probably a superior way to express what we're doing, as it gives Xcode the opportunity to
compile other objects in parallel, and could be easily extended to compile multiple discrete
asm files should the need arise.
- Configurations/ToolExecutable.xcconfig: Build rules are XCBuild-only.
- JavaScriptCore.xcodeproj/project.pbxproj: Add build rules, rename legacy scripts.
- offlineasm/asm.rb: Add --depfile flag.
- offlineasm/generate_offset_extractor.rb: Add --depfile flag.
- offlineasm/generate_settings_extractor.rb: Add --depfile flag.
- 10:41 PM Changeset in webkit [290974] by
-
- 4 edits1 delete in trunk/Source/ThirdParty/libwebrtc
Unreviewed, reverting r290966.
Broke ews and make
Reverted changeset:
"[XCBuild] libwebrtc's headers are copied via rsync and do not
emit task outputs"
https://bugs.webkit.org/show_bug.cgi?id=237112
https://commits.webkit.org/r290966
- 9:18 PM Changeset in webkit [290973] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290961. rdar://problem/89912760
[macCatalyst] Compilation error: WebContentProcess.xib: error: macOS xibs do not support target device type "ipad".
https://bugs.webkit.org/show_bug.cgi?id=237549
rdar://89912760
Patch by Richard Houle <rhoule@apple.com> on 2022-03-07
Reviewed by Alexey Proskuryakov.
Xcode for macOS 12.5 complains that we bundle Mac XIBs inside our macCatalyst builds.
- Configurations/BaseXPCService.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:27 PM Changeset in webkit [290972] by
-
- 2 edits in trunk/Source/WebCore
Fix the build
- platform/graphics/GraphicsContext.h:
- 7:07 PM Changeset in webkit [290971] by
-
- 4 edits in trunk/Source/WebKit
Remove remnants of WebKit.Plugin.64.xpc service
https://bugs.webkit.org/show_bug.cgi?id=237555
<rdar://84485232>
Reviewed by Alexey Proskuryakov.
Although plugins have been disabled for a number of years, the actual code behind this
feature was only removed this cycle (see Bugs 232462, 234354, and 234379). I noticed a few
remaining bits of the removed plugin process that should also be cleaned up.
- Scripts/process-entitlements.sh:
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::sandboxDirectory):
(WebKit::applySandbox):
- 7:00 PM Changeset in webkit [290970] by
-
- 2 edits in trunk/Tools
Fix Release builds for sanitizers by defining RELEASE_WITHOUT_OPTIMIZATIONS
<https://webkit.org/b/237556>
<rdar://problem/89929061>
Reviewed by Kate Cheney.
- sanitizer/sanitizer.xcconfig:
(OTHER_CFLAGS): Add
-DRELEASE_WITHOUT_OPTIMIZATIONSso Release
builds at lower optimization levels don't fail.
- 6:12 PM Changeset in webkit [290969] by
-
- 10 edits in trunk/Source
Preconnecting after process swap is a page load time improvement on some devices
https://bugs.webkit.org/show_bug.cgi?id=237055
<rdar://problem/89638872>
Reviewed by Geoffrey Garen.
Source/WebCore:
Export method.
- platform/network/NetworkLoadMetrics.h:
Source/WebKit:
On some devices we see that doing a second preconnect on HTTP/1.1 is a significant page load time improvement.
This is due to the fact that most page loads on HTTP/1.1 will open several connections, and having two
preconnected connections instead of one, will speed up page load time. This patch implements this by starting
a second preconnect after the first has finished. It is important to wait until the first preconnect has
finished, otherwise the second preconnect will go to waste, since the underlying network layer does not yet
know if this is HTTP/1.1 or not. Since we do not see page load time improvement on iOS with this behavior,
it is currently only enabled for macOS. The next step is to investigate why it does not seem to be a page
load time improvement on iOS. We probably need to make sure the main resource load has started before we
start the second preconect. This will avoid that the second preconnect returns immediately.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::sendH2Ping):
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
- NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::PreconnectTask):
(WebKit::PreconnectTask::didFinishLoading):
(WebKit::PreconnectTask::didFailLoading):
(WebKit::PreconnectTask::didFinish):
- NetworkProcess/PreconnectTask.h:
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::preconnectForSubresource):
Source/WTF:
Add ENABLE guard for this behavior.
- wtf/PlatformEnableCocoa.h:
- 5:39 PM Changeset in webkit [290968] by
-
- 6 edits in trunk
Add ability to convert FragmentedSharedBuffer to CMBlockBuffer
https://bugs.webkit.org/show_bug.cgi?id=237075
Source/WebCore:
rdar://89338447
Reviewed by Jer Noble.
Add FragmentedSharedBuffer::getContiguousData and
FragmentedSharedBuffer::createCMBlockBuffer methods.
API tests added for getContiguousData.
createCMBlockBuffer will be used in a follow-up patch.
- platform/SharedBuffer.cpp:
(WebCore::FragmentedSharedBuffer::getContiguousData const):
- platform/SharedBuffer.h:
- platform/cocoa/SharedBufferCocoa.mm:
(WebCore::FreeSharedBuffer):
(WebCore::FragmentedSharedBuffer::createCMBlockBuffer const):
Tools:
Reviewed by Jer Noble.
- TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::TEST_F):
- 5:28 PM Changeset in webkit [290967] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r285688. rdar://problem/85307256
[macOS] Add required methods to IOKit message filter
https://bugs.webkit.org/show_bug.cgi?id=233012
<rdar://85307256>
Reviewed by Brent Fulgham.
Add required methods to IOKit message filter on macOS.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:26 PM Changeset in webkit [290966] by
-
- 4 edits1 add in trunk/Source/ThirdParty/libwebrtc
[XCBuild] libwebrtc's headers are copied via rsync and do not emit task outputs
https://bugs.webkit.org/show_bug.cgi?id=237112
Reviewed by Alexey Proskuryakov.
Reconfigure the Xcode project to copy libwebrtc's headers natively, using the same approach
as https://commits.webkit.org/247585@main and https://commits.webkit.org/247656@main.
Add a target for absl's headers, so that they can be copied and configured separately from
webrtc's headers. This target does not have any source files, so it is effectively
headers-only.
libwebrtc.xcodeproj is very messy and doesn't always align with the on-disk representation
of the project's sources, but I have combed through all the source directories to ensure
that all headers which aren't obviously testing or non-Mac-related are included.
- Configurations/Base.xcconfig: Copy WK_WHICH_BUILD_SYSTEM from other projects.
- Configurations/libabsl.xcconfig: Added.
- Configurations/libwebrtc.xcconfig: Set header-related build settings.
- libwebrtc.xcodeproj/project.pbxproj: Tons of header additions and visibility changes.
- 4:32 PM Changeset in webkit [290965] by
-
- 5 edits2 adds in trunk
Fix for <select> elements in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=237483
rdar://89530022
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/dropdown-value.html
AXObjectCache was not updating the isolated tree for
AXMenuListValueChanged notifications. Added handleMenuListValueChanged()
for this purpose.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::handleMenuListValueChanged):
(WebCore::AXObjectCache::updateIsolatedTree):
- accessibility/AXObjectCache.h:
LayoutTests:
- accessibility/dropdown-value-expected.txt: Added.
- accessibility/dropdown-value.html: Added.
- 4:00 PM Changeset in webkit [290964] by
-
- 9 edits1 add in trunk
MediaTime::invalidTime() conversion to CMTime incorrectly creates a valid time.
https://bugs.webkit.org/show_bug.cgi?id=237473
rdar://problem/89814921
Reviewed by Jer Noble.
Source/WebCore:
Fly-by fix: update call to AVOutputContextOutputDevicesDidChangeNotification
now that the access macro got fixed.
API Test added.
- platform/audio/ios/MediaSessionHelperIOS.mm:
(-[WebMediaSessionHelper startMonitoringAirPlayRoutes]):
- platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
(WebCore::AVRoutePickerViewTargetPicker::outputContextInternal):
(WebCore::AVRoutePickerViewTargetPicker::routeDetector):
(WebCore::AVRoutePickerViewTargetPicker::invalidatePlaybackTargets):
(-[WebAVRoutePickerViewHelper notificationHandler:]):
Source/WebCore/PAL:
Fly-by fix: macro definition to access method
AVOutputContextOutputDevicesDidChangeNotification was incorrect.
- pal/avfoundation/MediaTimeAVFoundation.cpp:
(PAL::toCMTime): Ensure that if the converted time was invalid. The
flag is carried accross.
- pal/cocoa/AVFoundationSoftLink.h:
Tools:
Fly-by fixes: AVFoundationSoftLinkTest wasn't being compiled
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebCore/cocoa/CoreMediaUtilities.mm: Added.
(TestWebKitAPI::TEST):
- 3:51 PM Changeset in webkit [290963] by
-
- 1 copy in tags/Safari-614.1.5.8
Tag Safari-614.1.5.8.
- 3:50 PM Changeset in webkit [290962] by
-
- 3 edits in branches/safari-614.1.5-branch/Source/WebGPU
Cherry-pick r290960. rdar://problem/89920518
Catalyst build failure in WebGPU when building with SYSTEM_CONTENT_PATH
https://bugs.webkit.org/show_bug.cgi?id=237542
Reviewed by Saam Barati.
Updated create-symlink-to-altroot.sh to create the directory containing the output if is doesn't
exist in lieu of specifying an output file in the build step.
This is the way that other projects are configured.
- Scripts/create-symlink-to-altroot.sh:
- WebGPU.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:47 PM Changeset in webkit [290961] by
-
- 2 edits in trunk/Source/WebKit
[macCatalyst] Compilation error: WebContentProcess.xib: error: macOS xibs do not support target device type "ipad".
https://bugs.webkit.org/show_bug.cgi?id=237549
rdar://89912760
Patch by Richard Houle <rhoule@apple.com> on 2022-03-07
Reviewed by Alexey Proskuryakov.
Xcode for macOS 12.5 complains that we bundle Mac XIBs inside our macCatalyst builds.
- Configurations/BaseXPCService.xcconfig:
- 3:08 PM Changeset in webkit [290960] by
-
- 3 edits in trunk/Source/WebGPU
Catalyst build failure in WebGPU when building with SYSTEM_CONTENT_PATH
https://bugs.webkit.org/show_bug.cgi?id=237542
Reviewed by Saam Barati.
Updated create-symlink-to-altroot.sh to create the directory containing the output if is doesn't
exist in lieu of specifying an output file in the build step.
This is the way that other projects are configured.
- Scripts/create-symlink-to-altroot.sh:
- WebGPU.xcodeproj/project.pbxproj:
- 3:07 PM Changeset in webkit [290959] by
-
- 2 edits in trunk/LayoutTests
Remove TestExpectations for imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.worker.html.
https://bugs.webkit.org/show_bug.cgi?id=229244
Not reviewed.
TestExpectaions says this test will either pass or crash. However, the test history
at https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FIndexedDB%2Fkey-generators%2Freading-autoincrement-indexes-cursors.any.worker.html
shows that this test hasn't crashed in a very long time.
Also local runs of the test on AppleSilicon with Debug WK1 pass with no crash.
- platform/mac/TestExpectations:
- 2:32 PM Changeset in webkit [290958] by
-
- 7 edits in trunk
allow-custom-protocols-navigation sandbox flag.
https://bugs.webkit.org/show_bug.cgi?id=237269
<rdar://problem/89899736>
Reviewed by Geoffrey Garen.
Source/WebCore:
Add support for allow-custom-protocols-navigation iframe sandbox flag to allow sandboxed iframes
to navigate to custom protocols, as per:
We recently started preventing sandboxed iframes from navigating to custom protocols, which broke
Microsoft Teams. We added a quirk for Microsoft Teams which we should be able to drop once they
adopt this new sandbox flag.
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSupportedSandboxPolicy):
(WebCore::SecurityContext::parseSandboxPolicy):
- dom/SecurityContext.h:
Source/WebKit:
Add support for allow-custom-protocols-navigation iframe sandbox flag to allow sandboxed iframes
to navigate to custom protocols, as per:
We recently started preventing sandboxed iframes from navigating to custom protocols, which broke
Microsoft Teams. We added a quirk for Microsoft Teams which we should be able to drop once they
adopt this new sandbox flag.
- UIProcess/WebPageProxy.cpp:
(WebKit::frameSandboxAllowsOpeningExternalCustomProtocols):
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
(TEST):
- 2:13 PM Changeset in webkit [290957] by
-
- 3 edits in trunk/Source/WebKit
DerivedSources.make: Regenerate message receiver sources on Makefile changes
https://bugs.webkit.org/show_bug.cgi?id=237543
Reviewed by Alexey Proskuryakov.
This script depends on configuration and other sources in DerivedSources.make, so it should
regenerate when they change. Fixes one-time incremental build failures caused by r290896.
- DerivedSources.make:
- 2:11 PM Changeset in webkit [290956] by
-
- 6 edits2 adds in branches/safari-613-branch
Cherry-pick r290853. rdar://problem/88669147
about:blank iframes do not always inherit parent CSP
https://bugs.webkit.org/show_bug.cgi?id=236347
<rdar://problem/88669147>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/contentSecurityPolicy/block-eval-onload-in-nested-about-blank-iframe.html
Usually we initialize CSP for window when we create a jsWindowProxy
for that frame. In this case, we load an about:blank iframe that
attempts to run eval() in the onload function of its own nested
iframe. Since we never run script in frame, we don't initialize a
jsWindowProxy and thus never propogate its CSP.
This fix checks the document's CSP in FrameLoader::clear when we
initialize a new JSGlobalObject and sets the eval value in the window
accordingly to properly enforce CSP.
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::enableEval):
- bindings/js/ScriptController.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
- page/csp/ContentSecurityPolicy.h: (WebCore::ContentSecurityPolicy::evalErrorMessage const):
LayoutTests:
- http/tests/security/contentSecurityPolicy/block-eval-onload-in-nested-about-blank-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/block-eval-onload-in-nested-about-blank-iframe.html: Added We can't use modern js-test.js and related functions because js-test.js uses eval() and loading it makes the test time out when the eval is blocked by the document's CSP. We can't specify unsafe-eval because the whole point of this test is to block eval.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290955] by
-
- 4 edits3 adds in branches/safari-613-branch
Cherry-pick r290812. rdar://problem/84662329
Element with position: sticky after sticking, starts to move incorrectly when scrolling
https://bugs.webkit.org/show_bug.cgi?id=231953
<rdar://84662329>
Reviewed by Sam Weinig.
Source/WebCore:
Sometimes we'd fail to push new StickyPositionViewportConstraints to the scrolling
tree, because operator== failed to compare m_constrainingRectAtLastLayout. This breaks
the requirement that the "last committed scroll position" for the overflow scrolling
node has to be updated in the same commit as the "constraining-rect-at-last-layout"
on the sticky node.
Test: scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html
- page/scrolling/ScrollingConstraints.cpp: (WebCore::operator<<):
- page/scrolling/ScrollingConstraints.h: (WebCore::StickyPositionViewportConstraints::operator== const):
LayoutTests:
- platform/ios-wk2/scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints-expected.txt: Added.
- scrollingcoordinator/scrolling-tree/sticky-in-overflow-stale-constraints.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290954] by
-
- 13 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r290788. rdar://problem/83494949
Add a DeferTraps scope
https://bugs.webkit.org/show_bug.cgi?id=237306
<rdar://83494949>
Reviewed by Mark Lam.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::jettison): (JSC::CodeBlock::noticeIncomingCall):
- bytecode/CodeBlock.h:
- bytecode/RepatchInlines.h: (JSC::linkFor): (JSC::virtualForWithFunction):
- dfg/DFGOperations.cpp: (JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- interpreter/Interpreter.cpp: (JSC::Interpreter::executeProgram): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::execute): (JSC::Interpreter::executeModuleProgram):
- interpreter/InterpreterInlines.h: (JSC::Interpreter::execute):
- llint/LLIntSlowPaths.cpp: (JSC::LLInt::setUpCall):
- runtime/ExceptionScope.h:
- runtime/ScriptExecutable.cpp: (JSC::ScriptExecutable::installCode):
- runtime/VMTraps.cpp: (JSC::VMTraps::handleTraps): (JSC::VMTraps::takeTopPriorityTrap):
- runtime/VMTraps.h: (JSC::VMTraps::needHandling const): (JSC::VMTraps::maybeNeedHandling const): (JSC::VMTraps::hasTrapBit): (JSC::VMTraps::setTrapBit):
- runtime/VMTrapsInlines.h: (JSC::DeferTraps::DeferTraps): (JSC::DeferTraps::~DeferTraps):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290953] by
-
- 11 edits2 adds in branches/safari-613-branch
Cherry-pick r290785. rdar://problem/66568551
nasa.gov page with fixed backgrounds paints incorrectly on scroll
https://bugs.webkit.org/show_bug.cgi?id=237405
<rdar://66568551>
Reviewed by Antti Koivisto.
Source/WebCore:
https://www.nasa.gov/specials/artemis/ shows an issue where elements with background-attachment:fixed
don't repaint on scroll. This page has scrollable <html> and <body>, and the elements with fixed
backgrounds are composited, so this reveals that we fail to repaint composited children
of an overflow scroll in this case.
Fix by having RenderLayerScrollableArea::scrollTo() do repaints on slow repaint objects
which are scrolled by the current scroller.
Do some unrelated cleanup in code that I was going to use in this patch but turned out
not to need: rename hasFixedBackgroundImage() to hasAnyFixedBackground() for clarity,
and share the implementation with hasAnyLocalBackground().
Test: fast/repaint/background-attachment-fixed-in-composited-scroll.html
- rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange): (WebCore::RenderElement::willBeDestroyed):
- rendering/RenderLayer.cpp:
- rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::scrollTo):
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::hasImageWithAttachment const): (WebCore::FillLayer::hasFixedImage const): Deleted.
- rendering/style/FillLayer.h:
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::hasAnyLocalBackground const): Deleted.
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasBackgroundImage const): (WebCore::RenderStyle::hasAnyFixedBackground const): (WebCore::RenderStyle::hasAnyLocalBackground const): (WebCore::RenderStyle::hasFixedBackgroundImage const): Deleted.
LayoutTests:
Repaint test which is only valid for mac-wk2 (iOS does not support background-attachment:fixed).
- TestExpectations:
- fast/repaint/background-attachment-fixed-in-composited-scroll-expected.txt: Added.
- fast/repaint/background-attachment-fixed-in-composited-scroll.html: Added.
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290952] by
-
- 6 edits2 adds in branches/safari-613-branch
Cherry-pick r290778. rdar://problem/88297045
macOS Safari 15.2 Audio Echo Issue after camera pause/unpause
https://bugs.webkit.org/show_bug.cgi?id=235544
<rdar://problem/88297045>
Reviewed by Eric Carlson.
Source/WebCore:
After https://commits.webkit.org/r275600, the muted state of MediaPlayer would be set to the page muted state
without taking into consideration HTMLMediaElement.muted.
Update the call site to use effectiveMuted instead.
Add internals API to write a corresponding layout test.
Test: fast/mediastream/mediastreamtrack-audiovideo-mutepage.html
- html/HTMLMediaElement.cpp:
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/mediastream/mediastreamtrack-audiovideo-mutepage-expected.txt: Added.
- fast/mediastream/mediastreamtrack-audiovideo-mutepage.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290951] by
-
- 14 edits in branches/safari-613-branch
Cherry-pick r290765. rdar://problem/89232969
Throw proper exception on failed removeEntry() calls
https://bugs.webkit.org/show_bug.cgi?id=237382
<rdar://89232969>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getDirectoryHandle.https.any.worker-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-getFileHandle.https.any.worker-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any-expected.txt:
- web-platform-tests/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker-expected.txt:
Source/WebKit:
Updated existing tests.
- NetworkProcess/storage/FileSystemStorageError.h: (WebKit::convertToException):
- NetworkProcess/storage/FileSystemStorageHandle.cpp: (WebKit::FileSystemStorageHandle::removeEntry):
LayoutTests:
- storage/filesystemaccess/handle-move-expected.txt:
- storage/filesystemaccess/handle-move-worker-expected.txt:
- storage/filesystemaccess/resources/handle-move.js: (async test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290950] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290758. rdar://problem/89710486
[AppSSO] Correct logging messages to avoid confusing screeners that an error has occurred
https://bugs.webkit.org/show_bug.cgi?id=237390
<rdar://problem/89710486>
Reviewed by Simon Fraser.
The phrasing of the message in 'SOAuthorizationCoordinator::tryAuthorize' when a URL is not relevant for
AppSSO flows is:
AUTHORIZATIONCOORDINATOR_RELEASE_LOG("tryAuthorize: Cannot authorize the requested URL.");
This leads people spelunking logs to believe that the URL can't be authorized (perhaps due to an error).
Instead, we should more accurately report that the URL is not one that is mediated through an AppSSO flow,
and so no AppSSO processing is needed.
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationCoordinator.mm: (WebKit::SOAuthorizationCoordinator::tryAuthorize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290949] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290755. rdar://problem/89700242
[WebAuthn] Completion handler is not called when WebAuthn invoked without proper entitlements
https://bugs.webkit.org/show_bug.cgi?id=237380
<rdar://problem/89700242>
Reviewed by Chris Dumez.
WebAuthn is not permitted outside of Web Browser applications. When an application that lacks
the full web browser entitlement attempts to invoke WebAuthn flows, we do an early return. However,
the completion handler for this flow is bypassed, preventing applications from being informed of
this problem.
- WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp: (WebKit::WebAuthenticatorCoordinator::makeCredential): (WebKit::WebAuthenticatorCoordinator::getAssertion): (WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:11 PM Changeset in webkit [290948] by
-
- 3 edits2 adds in branches/safari-613-branch
Cherry-pick r290706. rdar://problem/89566459
REGRESSION(r285232) https://alvaromontoro.github.io/almond.css/demo/ looks wrong in Safari, ok in Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=237276
<rdar://problem/89566459>
Reviewed by Simon Fraser.
Source/WebCore:
r285232 introduced the isFixed() check as a resolvable preferred width type, but percent values are also resolvable as
block layout gets the horizontal constraint from the containing block chain (unlike the height percent values) -i.e. 'width: 50%' can be resolved during preferred width computation.
Test: fast/css-grid-layout/ascpect-ratio-with-percent-width.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):
LayoutTests:
- fast/css-grid-layout/ascpect-ratio-with-percent-width-expected.html: Added.
- fast/css-grid-layout/ascpect-ratio-with-percent-width.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290947] by
-
- 5 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r290671. rdar://problem/87340464
Web app fails only when dev tools is open
https://bugs.webkit.org/show_bug.cgi?id=235017
Reviewed by Devin Rousso.
Using the
ScriptExecutionContextfromevent.target()->scriptExecutionContext()can result the either having a
different script context from the one used when callingwillHandleEvent, or the event target's context could be
nullptr. This can occur when handling the event inEventTarget::innerInvokeEventListenersresults in a
context change for the event's target, like a MessagePort that has beendisentangled, which sets the script
execution context tonullptr. Because we only need the script execution context to get the correct injected
script, and the correct injected script for the action below will always be the same injected script used in
willHandleEvent, we ignore the current script execution context of the event's target and use the context the
event's target had when it began invoking event listeners.
This change protects us both from the reported crash, as well as leaving an injected script in a bad state
because we did not callsetEventValueandclearEventValueon matching injected scripts for a single event.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willHandleEventImpl): (WebCore::InspectorInstrumentation::didHandleEventImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willHandleEvent): (WebCore::InspectorInstrumentation::didHandleEvent):
- inspector/agents/InspectorDOMDebuggerAgent.cpp: (WebCore::InspectorDOMDebuggerAgent::willHandleEvent): (WebCore::InspectorDOMDebuggerAgent::didHandleEvent):
- inspector/agents/InspectorDOMDebuggerAgent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290946] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290629. rdar://problem/88903506
[IPC] Do more hardening in WebSWServerConnection's client registration / unregistration
https://bugs.webkit.org/show_bug.cgi?id=237290
<rdar://88903506>
Reviewed by Alex Christensen.
Validate client identifiers sent by the WebContent process via IPC to make sure that the
process identifier of the client actually matches the process identifier of the process
we're connected to.
Also validate the SecurityOriginData to make sure it is not empty. We support sending
empty SecurityOriginData objects over IPC. However, they cannot be used as keys in
HashMaps.
If validation fails, we assume the WebContent process is compromised and we terminate it.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): (WebKit::WebSWServerConnection::unregisterServiceWorkerClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290945] by
-
- 5 edits7 adds in branches/safari-613-branch
Cherry-pick r290606. rdar://problem/89482882
[macOS] Unable to upload ".pages" files to file inputs accepting ".pages" and ".jpeg" files
https://bugs.webkit.org/show_bug.cgi?id=237219
rdar://89482882
Reviewed by Tim Horton and Said Abou-Hallawa.
Source/WebCore:
In r264286, WebKit began transcoding images of an unsupported format
to a supported format, for file inputs that accepted image types. For
example, selecting a HEIF image in an input that accepts JPEG images
would transcode the selected image to a JPEG image.
In order to determine when attempt transcoding, the logic added in
r264286 obtains the MIME type corresponding to the selected file's
extension, and compares that to the list of accepted MIME types.
If there is a mismatch, transcoding is attempted.
The ".pages" extension does not have a well-defined MIME type in
NSURLFileTypeMappings. This is due to the fact that a the extension
maps to both a file and a package type. Consequently, the retrieved
MIME type for ".pages" files is an empty string. Following r227051,
when the file input also accepts an image type, WebKit attempts to
transcode these files, and any others that do not have a well-defined
MIME type.
While the aforementioned behavior can be considered strange, it is not
an issue in practice, since WebKit will attempt to transcode the
image, fail to do so, and upload the original file. The failure is
detected in CGImageDestinationFinalize, which returns false if an image
was not successfully written. However, a recent regression in the
ImageIO framework is causing CGImageDestinationFinalize to return true,
even if image transcoding fails. This results in WebKit uploading a
zero byte JPEG file, when a user attempts to upload ".pages" files to
file inputs accepting ".pages" and ".jpeg" files.
Ideally, the described issue would be resolved by a fix in ImageIO.
However, a more immediate solution exists in WebKit: only attempt to
transcode files to an accepted image type, if the file selected is
image. ".pages" files are not images, and WebKit should not attempt
to transcode them. See below for further explanation of the solution.
Test: fast/forms/file/entries-api/pages-jpeg-open-panel.html
- platform/graphics/cg/ImageUtilitiesCG.cpp: (WebCore::transcodeImage):
Prior to using ImageIO to perform transcoding, WebKit obtains a Uniform
Type Identifier for the selected file using CGImageSourceCreateWithURL
and CGImageSourceGetType. If the file is not an image, a null string is
returned. WebKit can use this information to avoid the transcoding
attempt, and avoid calls to ImageIO methods further down this method.
Specifically, this solution works around the ImageIO bug by avoiding
the call to CGImageDestinationFinalize for non-images. The solution is
also an overall improvement, as WebKit now avoids unnecessary calls to
multiple ImageIO methods, in cases where we know transcoding will fail.
LayoutTests:
Add a layout test that contains a file input that accepts ".pages" and
".jpeg" files, and attempts to upload a ".pages" file.
- TestExpectations:
- fast/forms/file/entries-api/pages-jpeg-open-panel-expected.txt: Added.
- fast/forms/file/entries-api/pages-jpeg-open-panel.html: Added.
- fast/forms/file/entries-api/pdf-jpeg-open-panel-expected.txt: Added.
- fast/forms/file/entries-api/pdf-jpeg-open-panel.html: Added.
- fast/forms/file/entries-api/resources/documents/document.pages: Added.
- fast/forms/file/entries-api/resources/documents/document.pdf: Added.
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290944] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r290562. rdar://problem/88767033
Loading a USDZ url as the main resource renders as garbage
https://bugs.webkit.org/show_bug.cgi?id=237240
rdar://88767033
Reviewed by Antoine Quint.
We can't render a USD document if the ModelDocument feature is not enabled.
- platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::canShowMIMEType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290943] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r290560. rdar://problem/89526227
Use hasAttributeWithoutSynchronisation for checking inert attribute in Adjuster::adjust
https://bugs.webkit.org/show_bug.cgi?id=237248
Reviewed by Dean Jackson.
hasAttributeWithoutSynchronisation should be slightly faster than hasAttribute.
- style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290942] by
-
- 3 edits2 adds in branches/safari-613-branch
Cherry-pick r290559. rdar://problem/89510628
Optimize StyleSharingResolver inert checks
https://bugs.webkit.org/show_bug.cgi?id=237235
Reviewed by Youenn Fablet.
Source/WebCore:
inert is an boolean attribute, the only thing that matters for the StyleAdjuster
inertness adjustment is the presence of the attribute, not its value. E.g.
inert=falseis the same asinert=inertorinert=true.
This saves getting and comparing values for those attributes, and also allows
inert=inertandinert=trueorinert=falseto start sharing style.
- style/StyleSharingResolver.cpp: (WebCore::Style::SharingResolver::canShareStyleWithElement const):
LayoutTests:
Add small test that style sharing is not wrongly applied.
- fast/css/inert-style-sharing-expected.html: Added.
- fast/css/inert-style-sharing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290941] by
-
- 11 edits2 adds in branches/safari-613-branch
Cherry-pick r290554. rdar://problem/83757966
Remove Node::deprecatedIsInert
https://bugs.webkit.org/show_bug.cgi?id=230845
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
This change unfortunately regresses focusability state when dynamically setting inert, due to a cached
computed style invalidation bug. This is minor in practice, since focusability usually gets queried in
user-initiated ways, when style already has fully been updated.
However, making this change will improve performance by avoiding a full DOM ancestor walk when there
is no inert attribute on the page, since we will only check a style bit after this patch.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/remove-dialog-should-unblock-document-expected.txt:
- web-platform-tests/inert/inert-canvas-fallback-content.tentative-expected.txt:
- web-platform-tests/inert/inert-node-is-unfocusable.tentative-expected.txt:
Source/WebCore:
This change unfortunately regresses focusability state when dynamically setting inert, due to a cached
computed style invalidation bug. This is minor in practice, since focusability usually gets queried in
user-initiated ways, when style already has fully been updated.
However, making this change will improve performance by avoiding a full DOM ancestor walk when there
is no inert attribute on the page, since we will only check a style bit after this patch.
- dom/Element.cpp: (WebCore::Element::isFocusable const): (WebCore::Element::isFocusableWithoutResolvingFullStyle const): (WebCore::Element::isVisibleWithoutResolvingFullStyle const): Deleted.
- dom/Element.h:
- dom/Node.cpp: (WebCore::Node::deprecatedIsInert const): Deleted.
- dom/Node.h:
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::isFocusable const):
LayoutTests:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-inert-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290940] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r290537. rdar://problem/89239935
Do not trigger didFail during FileReaderLoader Destruction
https://bugs.webkit.org/show_bug.cgi?id=237060
Patch by Brandon Stewart <Brandon> on 2022-02-25
Reviewed by Darin Adler.
Setting cancel() instead of terminate() will prevent the didFail() method from being triggered.
This method has the unfortunate side effect of trying to allocate memory, which is not allowed when
under going a sweep event.
- fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::~FileReaderLoader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290939] by
-
- 4 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r290510. rdar://problem/89364487
Web Inspector: [Cocoa] Split remote inspector message data into smaller chunks for large messages
https://bugs.webkit.org/show_bug.cgi?id=237110
<rdar://89364487>
Reviewed by Devin Rousso.
Messages over 2 MiB will now be split into multiple chunks, which allows us to not exceed any receiving daemon
process' memory limit under otherwise normal conditions. 2 MiB was chosen as a balance between not having to
split most messages at all and making sure that the messages (and any copies made during the relaying of the
messages) do not exceed the memory limits of the receiving daemon process.
In order to prevent us from sending chunked messages to a process that doesn't support them we check for a flag
to enable this functionality during connection setup.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspectorConstants.h:
- inspector/remote/cocoa/RemoteInspectorCocoa.mm: (Inspector::RemoteInspector::sendMessageToRemote): (Inspector::RemoteInspector::receivedSetupMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290938] by
-
- 4 edits2 adds in branches/safari-613-branch
Cherry-pick r290430. rdar://problem/87713597
RELEASE_ASSERT(!renderer()); in WebCore::Node::~Node() + 479 (Node.cpp:366)
https://bugs.webkit.org/show_bug.cgi?id=235380
Patch by Frédéric Wang <fwang@igalia.com> on 2022-02-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
RenderTreeUpdater::tearDownRenderers() browse the composed tree to tear down descendants.
However, element with a shadow root are handled specially in
ComposedTreeIterator::ComposedTreeIterator(), they have to be handled specially by calling
a tearDownLeftoverShadowHostChildren(). This patch does the same for slot elements which
are also handled specially in ComposedTreeIterator(). It also makes names within
tearDownLeftoverShadowHostChildren() more generic. This in particular fixes a release assert
when a slot with pseudo elements children is torn down.
Test: fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown.html
- rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::tearDownRenderers): Also call tearDownLeftoverShadowHostChildren for a slot element and add a comment pointing to the method corresponding to these special cases. (WebCore::RenderTreeUpdater::tearDownLeftoverChildrenOfComposedTree): Renamed to remove "shadow host".
- rendering/updating/RenderTreeUpdater.h: Ditto.
LayoutTests:
Add non-regression test.
- fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown-expected.txt: Added.
- fast/shadow-dom/slot-with-pseudo-element-children-renderer-teardown.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290937] by
-
- 2 edits in branches/safari-613-branch/LayoutTests
Cherry-pick r290385. rdar://problem/70464703
[Subpixel] imported/w3c/web-platform-tests/css/css-flexbox/auto-margins-001.html fails at certain font sizes
https://bugs.webkit.org/show_bug.cgi?id=217643
<rdar://problem/70464703>
Unreviewed gardening.
- platform/ios-simulator-wk2/TestExpectations: It must have progressed at some point.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290936] by
-
- 4 edits2 adds in branches/safari-613-branch
Cherry-pick r290356. rdar://problem/85765536
Crash when calling WEBGL_lose_context.loseContext() after the context has been lost
https://bugs.webkit.org/show_bug.cgi?id=236966
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-23
Reviewed by Dean Jackson.
Source/WebCore:
WebGLRenderingContextBase::forceLostContext() would
try to synthesize a GL error to the underlying
m_context. However, m_context is cleared when a real
context loss happens. This happens for example when we
simulate a GPU status failure or when we create too
many contexts. The m_context is not currently cleared
when the page simulates context lost via WEBGL_lose_contexts.loseContext().
Test: webgl/lose-context-after-context-lost.html
- html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::synthesizeGLError):
LayoutTests:
- webgl/lose-context-after-context-lost-expected.txt: Added.
- webgl/lose-context-after-context-lost.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290935] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290343. rdar://problem/85811396
Further restrict received IPC boolean values to 0 or 1
https://bugs.webkit.org/show_bug.cgi?id=236801
rdar://85811396
Patch by Simon Lewis <simon.lewis@apple.com> on 2022-02-22
Reviewed by Chris Dumez.
Return std::nullopt if a value larger than 1 is received.
- Platform/IPC/ArgumentCoder.h: (IPC::ArgumentCoder<bool>::decode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290934] by
-
- 14 edits6 adds in branches/safari-613-branch
Cherry-pick r290306. rdar://problem/88352589
Make pointer-events checks for SVG take in account inert subtrees
https://bugs.webkit.org/show_bug.cgi?id=235836
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Added tests for both inert attribute & modal dialog cases.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest-expected.txt: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest.html: Added.
- web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-svg-hittest.tentative.html: Added.
Source/WebCore:
Re-using visibleToHitTesting in SVG code isn't possible, because visibleToHitTesting removes visibility: hidden;
content from hit-testing, which we do not want to here, since pointer-events has values for SVG which still
allow clicking content regardless of their visibility value (pointer-events: painted/fill/stroke/all).
Instead, we add an inert-aware effectivePointerEvents, similar to effectiveUserSelect and re-use that across the codebase.
Tests: imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest.html
imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative.html
- rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange):
- rendering/RenderElement.h: (WebCore::RenderElement::visibleToHitTesting const):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerStyleChanged):
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::effectivePointerEvents const):
- rendering/svg/LegacyRenderSVGModelObject.cpp: (WebCore::LegacyRenderSVGModelObject::checkIntersection): (WebCore::LegacyRenderSVGModelObject::checkEnclosure):
- rendering/svg/LegacyRenderSVGShape.cpp: (WebCore::LegacyRenderSVGShape::nodeAtFloatPoint):
- rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::checkIntersection): (WebCore::RenderSVGModelObject::checkEnclosure):
- rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::nodeAtPoint):
- rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint):
- rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint):
LayoutTests:
iOS doesn't support test_actions, so it needs different baselines.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-svg-hittest-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:10 PM Changeset in webkit [290933] by
-
- 12 edits in branches/safari-613-branch/Source
Cherry-pick r290305. rdar://problem/89287719
Rename RenderStyle::userSelectIncludingInert to RenderStyle::effectiveUserSelect
https://bugs.webkit.org/show_bug.cgi?id=237033
Reviewed by Antti Koivisto.
This naming is consistent with other properties (effectiveDisplay/Appearance/PointerEvents/etc.).
Source/WebCore:
- dom/Node.cpp: (WebCore::computeEditabilityFromComputedStyle): (WebCore::Node::canStartSelection const):
- dom/Position.cpp: (WebCore::Position::nodeIsUserSelectNone): (WebCore::Position::nodeIsUserSelectAll):
- page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::selectCursor):
- page/Frame.cpp: (WebCore::Frame::rangeForPoint):
- rendering/RenderElement.cpp: (WebCore::RenderElement::selectionBackgroundColor const): (WebCore::RenderElement::selectionColor const):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderObject.cpp: (WebCore::RenderObject::collectSelectionGeometriesInternal):
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::effectiveUserSelect const): (WebCore::RenderStyle::userSelectIncludingInert const): Deleted.
Source/WebKit:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::isSelectableTextNode const):
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::selectionPositionInformation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290932] by
-
- 4 edits1 add in branches/safari-613-branch
Cherry-pick r290265. rdar://problem/88258776
[JSC] Add explicit exception check after appendWithoutSideEffects
https://bugs.webkit.org/show_bug.cgi?id=236986
rdar://88258776
Reviewed by Saam Barati.
JSTests:
- stress/array-to-string-oom.js: Added.
Source/JavaScriptCore:
Add exception check after JSStringJoiner::appendWithoutSideEffects call since JSString::value can throw OOM error.
- runtime/ArrayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/JSStringJoiner.h: (JSC::JSStringJoiner::append):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290931] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r290246. rdar://problem/85811396
Change IPC encoding of boolean type to use one bit
https://bugs.webkit.org/show_bug.cgi?id=236801
rdar://85811396
Patch by Simon Lewis <simon.lewis@apple.com> on 2022-02-21
Reviewed by Chris Dumez.
This patch ensures that only the lower bit is set in a boolean for IPC messages.
- Platform/IPC/ArgumentCoder.h: (IPC::ArgumentCoder<bool>::encode): (IPC::ArgumentCoder<bool>::decode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290930] by
-
- 2 edits in branches/safari-613-branch/LayoutTests/imported/w3c
Cherry-pick r290232. rdar://problem/88818132
Rebaseline inert-focus-in-frames.html after r290197.
Unreviewed test gardening.
For some reason, the rebaselining changes didn't make it in the patch.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290929] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r290197. rdar://problem/88818132
Stop propagating inertness through iframes in Node::deprecatedIsInert()
https://bugs.webkit.org/show_bug.cgi?id=236512
Reviewed by Chris Dumez.
This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
before this bug.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
Source/WebCore:
Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
- dom/Node.cpp: (WebCore::Node::deprecatedIsInert const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290928] by
-
- 4 edits in branches/safari-613-branch/Source/bmalloc
Cherry-pick r290195. rdar://problem/88402366
[libpas] Increase scavenger period from 100ms to 125ms in Darwin x64
https://bugs.webkit.org/show_bug.cgi?id=236873
Reviewed by Saam Barati.
Make x64 scavenger less aggressive while maintaining Membuster neutral
to make it less work.
- libpas/src/libpas/pas_config_prefix.h:
- libpas/src/libpas/pas_scavenger.c:
- libpas/src/libpas/pas_utils.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290927] by
-
- 13 edits2 moves14 adds in branches/safari-613-branch/LayoutTests
Cherry-pick r290164. rdar://problem/89162532
Re-import inert and <dialog> WPT
https://bugs.webkit.org/show_bug.cgi?id=236808
Reviewed by Simon Fraser.
Commit: https://github.com/web-platform-tests/wpt/commit/0d483a3bea340a2c60cb7a4add49eb63cbba2a64
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-double-nested-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-delegatesfocus-expected.txt.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-double-nested.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-delegatesfocus.html.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inertness-with-modal-dialogs-and-iframes-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inertness-with-modal-dialogs-and-iframes.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-scroll-height.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
- web-platform-tests/inert/dynamic-inert-on-focused-element.tentative-expected.txt: Added.
- web-platform-tests/inert/dynamic-inert-on-focused-element.tentative.html: Added.
- web-platform-tests/inert/inert-canvas-fallback-content.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-canvas-fallback-content.tentative.html: Added.
- web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-iframe-hittest.tentative.html: Added.
- web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-iframe-tabbing.tentative.html: Added.
- web-platform-tests/inert/inert-node-is-uneditable.tentative.html:
- web-platform-tests/inert/inert-with-modal-dialog-001.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-with-modal-dialog-001.tentative.html: Added.
- web-platform-tests/inert/inert-with-modal-dialog-002.tentative-expected.txt: Added.
- web-platform-tests/inert/inert-with-modal-dialog-002.tentative.html: Added.
- web-platform-tests/inert/w3c-import.log:
LayoutTests:
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt: Added.
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290926] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- gpu-process/TestExpectations: Remove tests that were resolved by r290813.
- 2:09 PM Changeset in webkit [290925] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r289859. rdar://problem/88491516
Skip positioned objects and line break boxes as they have no affect on width
https://bugs.webkit.org/show_bug.cgi?id=236514
Patch by Brandon Stewart <Brandon> on 2022-02-15
Reviewed by Myles C. Maxfield.
Align computeInlineDirectionPositionsForSegment() and computeExpansionForJustifiedText() logic.
Skipping positioned objects and line break boxes as they will not affect the width.
- rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::computeExpansionForJustifiedText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290924] by
-
- 5 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r289814. rdar://problem/83101090
Do not update the fragmented flow state while internally mutating the render tree
https://bugs.webkit.org/show_bug.cgi?id=230896
Reviewed by Darin Adler.
RenderTree mutations (like those happening when creating/destroying anonymous blocks)
should not affect the fragment state of any renderer. This means that we should not have
to deal with things like creating/restoring placeholders/spanners while doing that.
There is already a IsInternalMove flag that is being used for that. Expand its usage
to a couple more methods to improve correctness.
- rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::~LegacyRootInlineBox): Do not remove the inline box from the ContainingFragmentMap if we're deleting the tree. It was causing ASSERTs trying to retrieve the enclosing fragmented flow in some cases.
- rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::attachToRenderElementInternal): Use the RenderTreeBuilder's m_internalTreeBuilding instead of the argument. (WebCore::RenderTreeBuilder::move): Replace passing the IsInternalMove argument by a scope where we don't update the fragmented flow state. (WebCore::RenderTreeBuilder::detachFromRenderElement): Use the RenderTreeBuilder's m_internalMovesType instead of the argument.
- rendering/updating/RenderTreeBuilder.h:
- rendering/updating/RenderTreeBuilderInline.cpp: (WebCore::RenderTreeBuilder::Inline::splitInlines): Wrap the method by a scope in which fragmented flow state is not updated because we consider those operations internal arrangements of the tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290923] by
-
- 4 edits2 adds in branches/safari-613-branch
Cherry-pick r289700. rdar://problem/85249360
WebGL2 AllowShared TypedArray should be accepted
https://bugs.webkit.org/show_bug.cgi?id=232662
Reviewed by Dean Jackson.
Source/WebCore:
Test: webgl/webgl-allow-shared-typed-array.html
TypedArray with [AllowShared] annotation is not handled properly, which results in handling it as Sequence<T>,
invoking iteration protocol to copy them. This patch adds that as the same to [AllowShared] ArrayBuffer / ArrayBufferView.
- bindings/IDLTypes.h:
- bindings/js/JSDOMConvertUnion.h:
LayoutTests:
- webgl/webgl-allow-shared-typed-array-expected.txt: Added.
- webgl/webgl-allow-shared-typed-array.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290922] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r289597. rdar://problem/88324745
Check bidiLevels are valid before reordering
https://bugs.webkit.org/show_bug.cgi?id=236378
Patch by Brandon Stewart <Brandon> on 2022-02-10
Reviewed by Alan Bujtas.
We were trusting that the bidiLevel was valid before calling the reorder.
If the bidiLevel ends up being greater than the MAX + 1 we end up in a situation where
the reordering will fail. The function returns void, so there is not a good way to check
for an error.
- layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::layoutInlineContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290921] by
-
- 6 edits2 adds in branches/safari-613-branch
Cherry-pick r289533. rdar://problem/88452971
Settling of a fetch promise should be delayed in case page is entering page cache
https://bugs.webkit.org/show_bug.cgi?id=236292
<rdar://88452971>
Reviewed by Chris Dumez.
Source/WebCore:
Make sure to enqueue a task before resolving fetch promise as otherwise, page might continue running JavaScript.
Do this for worker as well for good measure.
We move signal aborted checks to two clients to handle rejecting fetch promise synchronously.
Test: http/tests/navigation/fetch-pagecache.html
- Modules/cache/DOMCache.cpp:
- Modules/fetch/FetchResponse.cpp:
- Modules/fetch/FetchResponse.h:
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:
- workers/service/FetchEvent.cpp:
LayoutTests:
- http/tests/navigation/fetch-pagecache-expected.txt: Added.
- http/tests/navigation/fetch-pagecache.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290920] by
-
- 11 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r289476. rdar://problem/88693354
AudioBuffer should take a lock while visiting m_channelWrappers
https://bugs.webkit.org/show_bug.cgi?id=236279
Reviewed by Keith Miller.
This patch fixes AudioBuffer's m_channelWrappers concurrency bug and related issues.
- This patch removes problematic (and almost always wrong) move operator of JSValueInWrappedObject. To do that, we fixed AudioBuffer's concurrency issue where we access m_channelWrappers while it can be cleared concurrently in AudioBuffer::releaseMemory.
- MessageEvent's m_data access is broken with concurrent GC thread. We must take a lock. And we must not use JSValueInWrappedObject in std::variant if it can be changed after constructor invocation.
- Use JSValueInWrappedObject::clear instead of move with empty value.
- File https://bugs.webkit.org/show_bug.cgi?id=236353. AbortSignal, MessageEvent, and CustomEvent miss write-barrier, which is semantically wrong.
- Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::AudioBuffer): (WebCore::AudioBuffer::releaseMemory): (WebCore::AudioBuffer::visitChannelWrappers):
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioWorkletProcessor.cpp: (WebCore::AudioWorkletProcessor::buildJSArguments):
- bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::data const): (WebCore::JSMessageEvent::visitAdditionalChildren):
- bindings/js/JSValueInWrappedObject.h:
- dom/AbortSignal.cpp: (WebCore::AbortSignal::signalAbort):
- dom/CustomEvent.cpp: (WebCore::CustomEvent::initCustomEvent):
- dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::m_jsData): (WebCore::MessageEvent::initMessageEvent): (WebCore::MessageEvent::memoryCost const): (WebCore::m_ports): Deleted.
- dom/MessageEvent.h:
- page/History.cpp: (WebCore::History::stateObjectAdded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290919] by
-
- 8 edits in branches/safari-613-branch
Cherry-pick r289255. rdar://problem/88490742
Always sync ResourceRequest isAppInitiated request with NSURLRequest attribution value
https://bugs.webkit.org/show_bug.cgi?id=236167
<rdar://88490742>
Reviewed by Darin Adler.
Source/WebCore:
We should always keep the state of our 'isAppInitiated' flag in sync with the underlying
NSURLRequest object. This also corrects a problem where the 'setIsAppInitiated' method
does not mark the platform URL request as dirty, so it does not update with the correct
state of the flag.
Tests: New TestWebKitAPI Test (AppPrivacyReport.NSURLRequestConstructorAttribution)
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setIsAppInitiated):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequest.h:
- platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): (WebCore::copyRequestWithStorageSession):
- rendering/RenderThemeIOS.mm:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
- TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:09 PM Changeset in webkit [290918] by
-
- 5 edits5 adds in branches/safari-613-branch
Cherry-pick r289121. rdar://problem/88492251
Fix App Privacy Report redirect attribution
https://bugs.webkit.org/show_bug.cgi?id=236111
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/app-privacy-report/user-attribution-redirect.html
Test: http/tests/app-privacy-report/app-attribution-redirect.html
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
Source/WebKit:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
LayoutTests:
- http/tests/app-privacy-report/resources/redirect.js: Added.
- http/tests/app-privacy-report/app-attribution-redirect-expected.txt: Added.
- http/tests/app-privacy-report/app-attribution-redirect.html: Added.
- http/tests/app-privacy-report/user-attribution-redirect-expected.txt: Added.
- http/tests/app-privacy-report/user-attribution-redirect.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290917] by
-
- 5 edits7 adds in branches/safari-613-branch
Cherry-pick r289101. rdar://problem/87625596
Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
https://bugs.webkit.org/show_bug.cgi?id=235257
<rdar://problem/87625596>
Reviewed by Darin Adler.
.:
Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
- metadata/contributors.json:
Source/WebCore:
Turns out one of our character data tables was missing some characters.
I really dislike these kinds of fixes, because it's just perpetuating the fact that WebKit has big tables of characters
in its source code. A long-term fix would be a systemic replacement of this entire table with either Unicode property
lookup, or more ideally, removing the need for it in the first place. Unfortunately, at this point in the release cycle,
this fix probably needs to be smaller and more targetted.
Tests: fast/text/bopomofo-tone-marks-2.html
fast/text/bopomofo-tone-marks.html
- platform/graphics/FontCascade.cpp: (WebCore::FontCascade::isCJKIdeographOrSymbol):
LayoutTests:
This can't be a WPT test because we only have permission to add the test font to the WebKit repository.
Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
- fast/text/bopomofo-tone-marks-2-expected-mismatch.html: Added.
- fast/text/bopomofo-tone-marks-2.html: Added.
- fast/text/bopomofo-tone-marks-expected-mismatch.html: Added.
- fast/text/bopomofo-tone-marks.html: Added.
- fast/text/resources/BopomofoGposSubset-Regular/BopomofoGposSubset-Regular.ttf: Added.
- fast/text/resources/BopomofoGposSubset-Regular/LICENSE: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290916] by
-
- 3 edits in branches/safari-613-branch/Source/JavaScriptCore
Cherry-pick r289001. rdar://problem/88404556
[JSC] Crash on several pages after r287986
https://bugs.webkit.org/show_bug.cgi?id=236033
Reviewed by Tim Horton.
I noticed that Safari crashes when opening https://linux.die.net/man/3/localtime.
This is happening after r287986: we are calling [self release], but the [JSValue dealloc]
cannot work if _context is nil. We should add a guard.
- API/JSValue.mm: (-[JSValue dealloc]):
- API/tests/testapi.mm: (testObjectiveCAPIMain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290915] by
-
- 2 edits in branches/safari-613-branch/Source/WTF
Cherry-pick r288746. rdar://problem/88093198
Enable inert attribute feature flag
https://bugs.webkit.org/show_bug.cgi?id=235668
Reviewed by Darin Adler.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290914] by
-
- 5 edits in branches/safari-613-branch
Cherry-pick r288700. rdar://problem/86602114
Default to 32 bit refcount for CanMakeCheckedPtr
https://bugs.webkit.org/show_bug.cgi?id=235723
rdar://86602114
Reviewed by Darin Adler.
Source/WTF:
It is currently uint16_t for no good reason. It is no unreasonable to have an object being referenced
by a large number of other objects.
We just hit the first bug caused by overrunning it (in IFC).
- wtf/CheckedRef.h:
uint16_t -> uint32_t
Tools:
- TestWebKitAPI/Tests/WTF/CheckedPtr.cpp: (TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/CheckedRef.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290913] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r288450. rdar://problem/74932445
Remove customElements when transitioning documents
https://bugs.webkit.org/show_bug.cgi?id=222727
Patch by Rob Buis <rbuis@igalia.com> on 2022-01-24
Reviewed by Ryosuke Niwa.
Remove customElements when transitioning documents
of Window since the old document may be gone.
Test: fast/js-promise/js-promise-invalid-context-access.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::didSecureTransitionTo): (WebCore::DOMWindow::ensureCustomElementRegistry):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290912] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r288413. rdar://problem/86287467
REGRESSION (Safari 15?): Blob videos slow to pause, affects CBS and CNN
https://bugs.webkit.org/show_bug.cgi?id=234066
Reviewed by Jer Noble.
MediaPlayerPrivateMediaSourceAVFObjC::playInternal()calls[m_synchronizer setRate:],
which will make the return value ofMediaPlayerPrivateMediaSourceAVFObjC::paused()change
from true to false. But it won't push the newpausedvalue back to the Web process.
RemoteMediaPlayerProxy::play()does callsendCachedState()after calling
m_player->play(), but becauseMediaPlayerPrivateMediaSourceAVFObjC::playInternal()is not
called in the same run loop,sendCachedState()won't send back the updatedpausedvalue either.
In most cases, this is not an issue, because other member functions of
RemoteMediaPlayerProxy
will callsendCachedState()to push the updatedpausedvalue back to the Web process later.
However, we did find some videos need thepausedvalue to be pushed back the Web process
in a timely manner.
No new tests, manually tested.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290911] by
-
- 2 edits in branches/safari-613-branch/Tools
Cherry-pick r288310. rdar://problem/80352256
[ iOS15 ] TestWebKitAPI.WebKit.ServerTrust and TestWebKitAPI.WebKit.FastServerTrust tests timing out
https://bugs.webkit.org/show_bug.cgi?id=231320
<rdar://80352256>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-01-20
Reviewed by Chris Dumez.
SecTrustCopyCertificateChain returns a CFArrayRef of SecCertificateRef, not CFData.
- TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: (verifyCertificateAndPublicKey): (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290910] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r288237. rdar://problem/87275093
WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234991
<rdar://problem/87275093>
Reviewed by Darin Adler.
Drop unnecessary default: case in the switch statement since it handles all enum values already.
- UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm: (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290909] by
-
- 8 edits in branches/safari-613-branch/Source
Cherry-pick r287986. rdar://problem/87489048
Fix a few Objective-C object leaks due to early returns in
init
https://bugs.webkit.org/show_bug.cgi?id=235162
<rdar://problem/87489048>
Reviewed by Wenson Hsieh.
Source/JavaScriptCore:
- API/JSValue.mm: (-[JSValue initWithValue:inContext:]):
Source/WebCore:
- platform/ios/WebAVPlayerController.mm: (-[WebAVPlayerController init]):
Source/WebKit:
- UIProcess/ios/WKHoverPlatter.mm: (-[WKHoverPlatter initWithView:delegate:]):
Source/WebKitLegacy/mac:
- Storage/WebDatabaseQuotaManager.mm: (WebCore::if):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:08 PM Changeset in webkit [290908] by
-
- 14 edits in branches/safari-613-branch/LayoutTests
Cherry-pick r287898. rdar://problem/86035420
Rewrite touch and drag tests to be more robust.
https://bugs.webkit.org/show_bug.cgi?id=235057
rdar://86035420
Reviewed by Wenson Hsieh.
Rewrite the touch-and-drag tests to check for selection changes, not specific text selections.
Specific selections and subject to small changes in font and layout, and all that is actually important is that
there have been selection changes based off of dragged touches.
The touch-event-radius test has been updated to use the screen size directly, since the radius is scaled by the screen size
internally. The output has been changed to not need to be updated when the test phone changes.
- fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text-expected.txt:
- fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-down-to-change-selected-text.html:
- fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text-expected.txt:
- fast/events/touch/ios/double-tap-on-editable-content-for-selection-then-drag-up-to-change-selected-text.html:
- fast/events/touch/ios/long-press-on-editable-content-then-drag-up-to-change-selected-text.html:
- fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text-expected.txt:
- fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:
- fast/events/touch/ios/long-press-then-drag-to-select-text-expected.txt:
- fast/events/touch/ios/long-press-then-drag-to-select-text.html:
- fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text-expected.txt:
- fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html:
- fast/events/touch/ios/touch-event-radius-expected.txt:
- fast/events/touch/ios/touch-event-radius.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:55 PM Changeset in webkit [290907] by
-
- 6 edits in trunk/Source/JavaScriptCore
AssemblyHelpersSpoolers: use load/store pair on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=235112
Reviewed by Žan Doberšek.
Save ~1% code size for baseline JIT on JS2 by emitting load/store pair
instructions on 32-bit ARM.
- assembler/ARMv7Assembler.h:
(JSC::ARMv6Assembler::vldmia):
(JSC::ARMv7Assembler::vstmia):
- assembler/CPU.h:
(JSC::isARM):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadPair64):
(JSC::MacroAssemblerARMv7::storePair64):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
- jit/AssemblyHelpersSpoolers.h:
(JSC::AssemblyHelpers::LoadRegSpooler::executePair):
(JSC::AssemblyHelpers::StoreRegSpooler::executePair):
(JSC::AssemblyHelpers::CopySpooler::CopySpooler):
(JSC::AssemblyHelpers::CopySpooler::loadPair):
(JSC::AssemblyHelpers::CopySpooler::storePair):
- 1:19 PM Changeset in webkit [290906] by
-
- 9 edits in branches/safari-614.1.5-branch/Source
Versioning.
WebKit-7614.1.5.8
- 1:16 PM Changeset in webkit [290905] by
-
- 2 edits in trunk/Tools
[iOS] editing/async-clipboard/* 20 tests are flaky timeouts on iOS
https://bugs.webkit.org/show_bug.cgi?id=237372
<rdar://problem/89689914>
Reviewed by Alexey Proskuryakov.
- Tools/CISupport/kill-old-processes: Kill "Simulator" process (since killing Simulator.app
won't do anything), shutdown simulators before killing processes. Check that simulators
are shut down before continuing.
Canonical link: https://commits.webkit.org/248136@main
- 1:11 PM Changeset in webkit [290904] by
-
- 2 edits in trunk
Update Basuke Suzuki's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=237545
Unreviewed.
- metadata/contributors.json:
- 12:59 PM Changeset in webkit [290903] by
-
- 88 edits1 delete in trunk/Source/WebKit
Remove unnecessary Async attribute in .messages.in files
https://bugs.webkit.org/show_bug.cgi?id=237491
Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-07
Reviewed by Chris Dumez.
If there is a reply and no "Synchronous" then we can infer that it is asynchronous.
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- GPUProcess/GPUProcess.messages.in:
- GPUProcess/media/RemoteAudioDestinationManager.messages.in:
- GPUProcess/media/RemoteCDMFactoryProxy.h:
- GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
- GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
- GPUProcess/media/RemoteCDMProxy.messages.in:
- GPUProcess/media/RemoteLegacyCDMFactoryProxy.h:
- GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.messages.in:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
- GPUProcess/media/RemoteMediaResourceManager.messages.in:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.messages.in:
- GPUProcess/webrtc/RemoteMediaRecorder.messages.in:
- GPUProcess/webrtc/RemoteMediaRecorderManager.messages.in:
- GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.messages.in:
- NetworkProcess/Cookies/WebCookieManager.messages.in:
- NetworkProcess/NetworkBroadcastChannelRegistry.messages.in:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkSocketChannel.messages.in:
- NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
- NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
- NetworkProcess/WebStorage/StorageManagerSet.messages.in:
- NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::startAsyncRevalidationIfNeeded):
- NetworkProcess/storage/NetworkStorageManager.messages.in:
- Scripts/webkit/messages.py:
(message_to_reply_forward_declaration):
(message_to_struct_declaration):
(forward_declarations_and_headers_for_replies):
(async_message_statement):
(sync_message_statement):
(generate_message_handler):
(generate_message_argument_description_implementation):
- Scripts/webkit/model.py:
(generate_global_model):
- Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in:
- Shared/AuxiliaryProcess.messages.in:
- Shared/Notifications/NotificationManagerMessageHandler.messages.in:
- UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in:
- UIProcess/Downloads/DownloadProxy.messages.in:
- UIProcess/Media/AudioSessionRoutingArbitratorProxy.messages.in:
- UIProcess/Media/RemoteMediaSessionCoordinatorProxy.messages.in:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/UserContent/WebUserContentControllerProxy.messages.in:
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
- UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:
- UIProcess/WebAuthentication/WebAuthnProcessProxy.messages.in: Removed.
- UIProcess/WebLockRegistryProxy.messages.in:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.messages.in:
- UIProcess/XR/PlatformXRSystem.messages.in:
- UIProcess/mac/SecItemShimProxy.messages.in:
- WebAuthnProcess/WebAuthnConnectionToWebProcess.messages.in:
- WebAuthnProcess/WebAuthnProcess.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Automation/WebAutomationSessionProxy.messages.in:
- WebProcess/GPU/GPUProcessConnection.messages.in:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
- WebProcess/GPU/media/SourceBufferPrivateRemote.messages.in:
- WebProcess/Inspector/WebInspectorUIExtensionController.messages.in:
- WebProcess/MediaSession/RemoteMediaSessionCoordinator.messages.in:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- WebProcess/Storage/WebSharedWorkerObjectConnection.messages.in:
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.messages.in:
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/VideoFullscreenManager.messages.in:
- 12:53 PM Changeset in webkit [290902] by
-
- 1 edit4 deletes in trunk/LayoutTests
Remove duplicated platform expectations for computed-style.html, computed-style-without-renderer.html, getComputedStyle-basic.xhtml
https://bugs.webkit.org/show_bug.cgi?id=237534
Unreviewed test gardening.
- platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/glib/svg/css/getComputedStyle-basic-expected.txt: Removed.
- platform/ios/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
- platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
- platform/ios/svg/css/getComputedStyle-basic-expected.txt: Removed.
- 12:29 PM Changeset in webkit [290901] by
-
- 101 edits1 delete in trunk
Optimize the passing of data across threads
https://bugs.webkit.org/show_bug.cgi?id=237502
Reviewed by Geoff Garen.
Source/WebCore:
Add more isolatedCopy() overloads that work on r-value references when the implementation
can be optimized. Also call isolatedCopy() / crossThreadCopy() on a r-value reference
whenever possible to leverage these optimizations.
- Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::isolatedCopy const):
(WebCore::CacheQueryOptions::isolatedCopy):
- Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::isolateCacheInfo): Deleted.
(WebCore::DOMCacheEngine::CacheInfos::isolatedCopy): Deleted.
- Modules/cache/DOMCacheEngine.h:
(WebCore::DOMCacheEngine::CacheInfo::isolatedCopy const):
(WebCore::DOMCacheEngine::CacheInfo::isolatedCopy):
(WebCore::DOMCacheEngine::CacheInfos::isolatedCopy const):
(WebCore::DOMCacheEngine::CacheInfos::isolatedCopy):
- Modules/cache/RetrieveRecordsOptions.h:
(WebCore::RetrieveRecordsOptions::isolatedCopy const):
(WebCore::RetrieveRecordsOptions::isolatedCopy):
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::retrieveCaches):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
- Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::ListedChild::isolatedCopy const):
(WebCore::ListedChild::isolatedCopy):
(WebCore::DOMFileSystem::listDirectory):
- Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::isolatedCopy const):
(WebCore::IDBDatabaseIdentifier::isolatedCopy):
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/IDBGetResult.cpp:
(WebCore::IDBGetResult::isolatedCopy):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords):
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
- Modules/indexeddb/shared/IDBDatabaseNameAndVersion.h:
(WebCore::IDBDatabaseNameAndVersion::isolatedCopy const):
(WebCore::IDBDatabaseNameAndVersion::isolatedCopy):
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::IDBError::isolatedCopy const): Deleted.
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::isolatedCopy const):
(WebCore::IDBError::isolatedCopy):
- Modules/indexeddb/shared/IDBIndexInfo.cpp:
(WebCore::IDBIndexInfo::isolatedCopy const):
(WebCore::IDBIndexInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBIndexInfo.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::isolatedCopy const):
(WebCore::IDBObjectStoreInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
- Modules/web-locks/WebLockManagerSnapshot.h:
(WebCore::WebLockManagerSnapshot::Info::isolatedCopy const):
(WebCore::WebLockManagerSnapshot::Info::isolatedCopy):
(WebCore::WebLockManagerSnapshot::isolatedCopy const):
(WebCore::WebLockManagerSnapshot::isolatedCopy):
- Modules/webaudio/AudioParamDescriptor.h:
(WebCore::AudioParamDescriptor::isolatedCopy const):
(WebCore::AudioParamDescriptor::isolatedCopy):
- Modules/webaudio/AudioWorkletGlobalScope.cpp:
(WebCore::AudioWorkletGlobalScope::registerProcessor):
- Modules/webaudio/AudioWorkletThread.cpp:
(WebCore::AudioWorkletThread::AudioWorkletThread):
- Modules/webaudio/AudioWorkletThread.h:
(WebCore::AudioWorkletThread::create):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseOpenTask::doPerformTask):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::originLockFor):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::ModifyHeadersAction::isolatedCopy const):
(WebCore::ContentExtensions::ModifyHeadersAction::isolatedCopy):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::isolatedCopy const):
(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::isolatedCopy):
(WebCore::ContentExtensions::RedirectAction::isolatedCopy const):
(WebCore::ContentExtensions::RedirectAction::isolatedCopy):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::isolatedCopy const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::isolatedCopy):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::isolatedCopy const):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::isolatedCopy):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::isolatedCopy const): Deleted.
- contentextensions/ContentExtensionActions.h:
(WebCore::ContentExtensions::ActionWithStringMetadata::isolatedCopy const):
(WebCore::ContentExtensions::ActionWithStringMetadata::isolatedCopy):
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::loadTrigger):
- contentextensions/ContentExtensionRule.cpp:
(WebCore::ContentExtensions::Trigger::isolatedCopy const):
(WebCore::ContentExtensions::Trigger::isolatedCopy):
(WebCore::ContentExtensions::Action::isolatedCopy const):
(WebCore::ContentExtensions::Action::isolatedCopy):
- contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::Trigger::checkValidity):
(WebCore::ContentExtensions::ContentExtensionRule::isolatedCopy const):
(WebCore::ContentExtensions::ContentExtensionRule::isolatedCopy):
(WebCore::ContentExtensions::Trigger::~Trigger): Deleted.
- dom/Exception.h:
(WebCore::Exception::isolatedCopy const):
(WebCore::Exception::isolatedCopy):
(WebCore::isolatedCopy): Deleted.
- dom/ExceptionData.cpp: Removed.
(WebCore::ExceptionData::isolatedCopy const): Deleted.
- dom/ExceptionData.h:
(WebCore::ExceptionData::isolatedCopy const):
(WebCore::ExceptionData::isolatedCopy):
- dom/ExceptionOr.h:
(WebCore::isolatedCopy): Deleted.
- html/DirectoryFileListCreator.cpp:
(WebCore::FileInformation::isolatedCopy const):
(WebCore::FileInformation::isolatedCopy):
- html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFilesWithImageTranscoding):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
- loader/CrossOriginOpenerPolicy.cpp:
(WebCore::CrossOriginOpenerPolicy::isolatedCopy const):
(WebCore::CrossOriginOpenerPolicy::isolatedCopy):
- loader/CrossOriginOpenerPolicy.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::handleContentFilterDidBlock):
- loader/FetchOptions.h:
(WebCore::FetchOptions::isolatedCopy const):
(WebCore::FetchOptions::isolatedCopy):
- loader/PolicyContainer.h:
(WebCore::PolicyContainer::isolatedCopy const):
(WebCore::PolicyContainer::isolatedCopy):
- loader/PrivateClickMeasurement.cpp:
(WebCore::PrivateClickMeasurement::UnlinkableToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::UnlinkableToken::isolatedCopy):
(WebCore::PrivateClickMeasurement::isolatedCopy const):
(WebCore::PrivateClickMeasurement::isolatedCopy):
(WebCore::PrivateClickMeasurement::SecretToken::isolatedCopy const): Deleted.
(WebCore::PrivateClickMeasurement::SourceSecretToken::isolatedCopy const): Deleted.
(WebCore::PrivateClickMeasurement::DestinationSecretToken::isolatedCopy const): Deleted.
(WebCore::PrivateClickMeasurement::EphemeralNonce::isolatedCopy const): Deleted.
(WebCore::PrivateClickMeasurement::SourceUnlinkableToken::isolatedCopy const): Deleted.
(WebCore::PrivateClickMeasurement::DestinationUnlinkableToken::isolatedCopy const): Deleted.
- loader/PrivateClickMeasurement.h:
(WebCore::PrivateClickMeasurement::SourceSite::isolatedCopy const):
(WebCore::PrivateClickMeasurement::SourceSite::isolatedCopy):
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::isolatedCopy const):
(WebCore::PrivateClickMeasurement::AttributionDestinationSite::isolatedCopy):
(WebCore::PrivateClickMeasurement::EphemeralNonce::isolatedCopy const):
(WebCore::PrivateClickMeasurement::EphemeralNonce::isolatedCopy):
(WebCore::PrivateClickMeasurement::SourceUnlinkableToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::SourceUnlinkableToken::isolatedCopy):
(WebCore::PrivateClickMeasurement::DestinationUnlinkableToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::DestinationUnlinkableToken::isolatedCopy):
(WebCore::PrivateClickMeasurement::SecretToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::SecretToken::isolatedCopy):
(WebCore::PrivateClickMeasurement::SourceSecretToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::SourceSecretToken::isolatedCopy):
(WebCore::PrivateClickMeasurement::DestinationSecretToken::isolatedCopy const):
(WebCore::PrivateClickMeasurement::DestinationSecretToken::isolatedCopy):
- loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::isolatedCopy const):
(WebCore::ResourceTiming::isolatedCopy):
- loader/ResourceTiming.h:
- loader/ServerTiming.cpp:
(WebCore::ServerTiming::isolatedCopy const):
(WebCore::ServerTiming::isolatedCopy):
- loader/ServerTiming.h:
- loader/WorkerThreadableLoader.cpp:
- page/ClientOrigin.h:
(WebCore::ClientOrigin::isolatedCopy const):
(WebCore::ClientOrigin::isolatedCopy):
- page/ProcessWarming.cpp:
(WebCore::ProcessWarming::prewarmWithInformation):
- page/ProcessWarming.h:
- page/csp/ContentSecurityPolicyResponseHeaders.cpp:
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy const):
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy):
- page/csp/ContentSecurityPolicyResponseHeaders.h:
- platform/FileChooser.h:
(WebCore::FileChooserFileInfo::isolatedCopy const):
(WebCore::FileChooserFileInfo::isolatedCopy):
- platform/MediaSelectionOption.h:
(WebCore::MediaSelectionOption::isolatedCopy const):
(WebCore::MediaSelectionOption::isolatedCopy):
- platform/RegistrableDomain.h:
(WebCore::RegistrableDomain::isolatedCopy const):
(WebCore::RegistrableDomain::isolatedCopy):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::prewarm):
- platform/graphics/FontCache.h:
(WebCore::FontCache::PrewarmInformation::isolatedCopy const):
(WebCore::FontCache::PrewarmInformation::isolatedCopy):
- platform/graphics/FontGenericFamilies.cpp:
(WebCore::FontGenericFamilies::isolatedCopy const):
(WebCore::FontGenericFamilies::isolatedCopy):
- platform/graphics/FontGenericFamilies.h:
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::startAsyncDecodingQueue):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontDatabase::collectionForFamily):
(WebCore::FontCache::prewarm):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::audioMediaSelectionOptionsChanged):
(VideoFullscreenControllerContext::legibleMediaSelectionOptionsChanged):
(isolatedCopy): Deleted.
- platform/mediacapabilities/AudioConfiguration.h:
(WebCore::AudioConfiguration::isolatedCopy const):
(WebCore::AudioConfiguration::isolatedCopy):
- platform/mediacapabilities/MediaConfiguration.h:
(WebCore::MediaConfiguration::isolatedCopy const):
(WebCore::MediaConfiguration::isolatedCopy):
- platform/mediacapabilities/VideoConfiguration.h:
(WebCore::VideoConfiguration::isolatedCopy const):
(WebCore::VideoConfiguration::isolatedCopy):
- platform/mediastream/RTCDataChannelHandler.h:
(WebCore::RTCDataChannelInit::isolatedCopy const):
(WebCore::RTCDataChannelInit::isolatedCopy):
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::refreshCaptureDevices):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::isolatedCopy const):
(WebCore::HTTPHeaderMap::isolatedCopy):
- platform/network/HTTPHeaderMap.h:
(WebCore::HTTPHeaderMap::CommonHeader::isolatedCopy const):
(WebCore::HTTPHeaderMap::CommonHeader::isolatedCopy):
(WebCore::HTTPHeaderMap::UncommonHeader::isolatedCopy const):
(WebCore::HTTPHeaderMap::UncommonHeader::isolatedCopy):
- workers/service/ServiceWorkerClients.cpp:
(WebCore::ServiceWorkerClients::claim):
- workers/service/server/RegistrationDatabase.cpp:
(WebCore::RegistrationDatabase::schedulePushChanges):
- worklets/WorkletParameters.h:
(WebCore::WorkletParameters::isolatedCopy const):
(WebCore::WorkletParameters::isolatedCopy):
Source/WebKit:
Add more isolatedCopy() overloads that work on r-value references when the implementation
can be optimized. Also call isolatedCopy() / crossThreadCopy() on a r-value reference
whenever possible to leverage these optimizations.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::migrateDataToPCMDatabaseIfNecessary):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
(WebKit::RegistrableDomainsToBlockCookiesFor::isolatedCopy const):
(WebKit::RegistrableDomainsToBlockCookiesFor::isolatedCopy):
(WebKit::RegistrableDomainsToDeleteOrRestrictWebsiteDataFor::isolatedCopy const):
(WebKit::RegistrableDomainsToDeleteOrRestrictWebsiteDataFor::isolatedCopy):
- NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::closeAndDeleteDatabasesForOrigins):
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDebugInfo.cpp:
(WebKit::PCM::DebugInfo::isolatedCopy const):
(WebKit::PCM::DebugInfo::isolatedCopy):
(WebKit::PCM::DebugInfo::Message::isolatedCopy const):
(WebKit::PCM::DebugInfo::Message::isolatedCopy):
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDebugInfo.h:
- NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementStore.cpp:
(WebKit::PCM::Store::allAttributedPrivateClickMeasurement):
- UIProcess/API/APIContentRuleListStore.cpp:
(API::ContentRuleListStore::compileContentRuleList):
- UIProcess/Cocoa/ModalContainerControlClassifier.mm:
(WebKit::ModalContainerControlClassifier::classify):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::setMediaAccessibilityPreferences):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithImageTranscoding):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::prewarmWithDomainInformation):
- WebProcess/WebProcess.h:
Source/WebKitLegacy:
Add more isolatedCopy() overloads that work on r-value references when the implementation
can be optimized. Also call isolatedCopy() / crossThreadCopy() on a r-value reference
whenever possible to leverage these optimizations.
- Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::didGetAllDatabaseNamesAndVersions):
Source/WTF:
Drop isolatedCopy() on Vector since CrossThreadCopier already has logic to
isolate-copy a Vector. The logic in CrossThreadCopier has the benefit of
working on types that do not implement isolatedCopy() (e.g. a Vector of
std::optional or a Vector of std::variant).
Improve the CrossThreadCopier to optimize the case where crossThreadCopy()
is called on a r-value reference in more cases. In particular, the logic
for Vector, HashSet, HashMap, std::pair, std::variant was improved. I
also added API test coverage for those.
The API tests also found a bug where crossThreadCopy() was incorrectly
moving the source when called on a std::variant that was not a r-value
reference. This bug is fixed in this patch too.
- wtf/CrossThreadCopier.h:
- wtf/Vector.h:
(WTF::Malloc>::isolatedCopy const): Deleted.
(WTF::Malloc>::isolatedCopy): Deleted.
- wtf/mac/FileSystemMac.mm:
(WTF::FileSystem::setMetadataURL):
Tools:
Expand test coverage for crossThreadCopy() and make sure the optimizations are working
when called on a r-value reference.
- TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 11:27 AM Changeset in webkit [290900] by
-
- 2 edits in trunk/LayoutTests
LayoutTests/webgl/max-active-contexts-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=237466
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-03-07
Reviewed by Alexey Proskuryakov.
The test:
- created 16 WebGL contexts
- unreferenced 8 WebGL contexts.
- forced gc
- added 9 WebGL contexts.
The test tries to test that GC removes unreferenced contexts.
To assert this, it ends up with 17 contexts, which is 1 above
the maximum active limit. This means one context is lost and the
implementation prints one line of error.
Since the GC is not exact, sometimes it would only collect 7 of the 8
unreferenced contexts. This would mean two error messages.
Fix by trying to collect each time a context is unreferenced. This seems to be
more predictable.
- webgl/max-active-contexts-gc.html:
- 11:21 AM Changeset in webkit [290899] by
-
- 10 edits3 adds in trunk
Make "true" count as truthy in window.open()'s boolean features
https://bugs.webkit.org/show_bug.cgi?id=237530
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Import WPT test coverage.
- resources/resource-files.json:
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-is-popup-condition.html:
- web-platform-tests/html/browsers/the-window-object/support/w3c-import.log:
- web-platform-tests/html/browsers/the-window-object/support/windowFeature-values-target.html: Added.
- web-platform-tests/html/browsers/the-window-object/w3c-import.log:
- web-platform-tests/html/browsers/the-window-object/window-open-noopener.html:
- web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html: Added.
Source/WebCore:
Make "true" count as truthy in window.open()'s boolean features, as per:
Test: imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-windowfeatures-values.html
- page/WindowFeatures.cpp:
(WebCore::setWindowFeature):
LayoutTests:
- tests-options.json:
- 11:13 AM Changeset in webkit [290898] by
-
- 4 edits in trunk
[web-animations] animating "fill" and "stroke" to or from "currentColor" should work
https://bugs.webkit.org/show_bug.cgi?id=237531
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/responsive/to-color-change-expected.txt:
Source/WebCore:
Invalid colors should use the value for the "color" property on the provided RenderStyle.
- animation/CSSPropertyAnimation.cpp:
- 10:18 AM Changeset in webkit [290897] by
-
- 4 edits in trunk
Transition on text-decoration-color from currentColor jumps
https://bugs.webkit.org/show_bug.cgi?id=236992
<rdar://problem/89382835>
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/web-animations/responsive/to-color-change-expected.txt:
Source/WebCore:
We need to use the MaybeInvalidColor tag to identify that this property can work with
currentColor.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 10:00 AM Changeset in webkit [290896] by
-
- 11 edits1 delete in trunk/Source/WebKit
Delete WebIDBServer and WebIDBConnectionToClient
https://bugs.webkit.org/show_bug.cgi?id=237479
Reviewed by Chris Dumez.
The code is unused since r289474; remove it to avoid confusion when investigating issues including related
symbols.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp: Removed.
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.h: Removed.
- NetworkProcess/IndexedDB/WebIDBServer.cpp: Removed.
- NetworkProcess/IndexedDB/WebIDBServer.h: Removed.
- NetworkProcess/IndexedDB/WebIDBServer.messages.in: Removed.
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkSession.cpp:
- NetworkProcess/NetworkSession.h:
- NetworkProcess/ios/NetworkProcessIOS.mm:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- 9:53 AM Changeset in webkit [290895] by
-
- 6 edits in trunk
[web-animations] text-emphasis shorthand should be animatable
https://bugs.webkit.org/show_bug.cgi?id=237529
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForTextEmphasisStyle):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- 9:52 AM Changeset in webkit [290894] by
-
- 4 edits in trunk/Tools
[git-webkit] Derive branch name from bug title (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=237284
<rdar://problem/89578241>
Unreviewed follow-up fix.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch.test_basic_svn): Using an integer will attempt to find a bug number.
(TestBranch.test_basic_git): Ditto.
Canonical link: https://commits.webkit.org/248125@main
- 9:37 AM Changeset in webkit [290893] by
-
- 7 edits in trunk/Source/WebKit
[WebAuthn] Provide global frame identifier to ASCAgent SPI
https://bugs.webkit.org/show_bug.cgi?id=237454
rdar://problem/89782147
Reviewed by Brent Fulgham.
For purposes related to conditional mediation, the ASCAgent SPI
need to know what frame requested the assertion. This patch starts
passing that along.
- Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
- UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::cancelRequest):
(WebKit::AuthenticatorManager::runPanel):
- UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.h:
- UIProcess/WebAuthentication/Cocoa/AuthenticationServicesCoreSoftLink.mm:
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configurationAssertionRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):
- UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
- 9:29 AM Changeset in webkit [290892] by
-
- 4 edits in trunk/Source
Small cleanups of media code
https://bugs.webkit.org/show_bug.cgi?id=237496
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
No new tests. No behavior change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState):
schedulePlaybackControlsManagerUpdate()is
called in both branches.
Source/WebKit:
- WebProcess/cocoa/PlaybackSessionManager.h:
protectedis not needed here.
- 9:13 AM Changeset in webkit [290891] by
-
- 2 edits in trunk/LayoutTests
[Catalina Release wk1] imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=230729
<rdar://problem/83469625>
Unreviewed, unskip test as the bots show no recent flakiness.
- platform/mac-wk1/TestExpectations:
- 8:42 AM WebKitGTK/2.36.x edited by
- Reproducible build fixes (diff)
- 8:37 AM Changeset in webkit [290890] by
-
- 2 edits in trunk/Source/WebKit
[GTK] generate-automation-atom.py breaks reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=237506
Reviewed by Carlos Garcia Campos.
- Scripts/generate-automation-atom.py:
(append_functions): Sort utility functions to produce stable output.
- 7:56 AM Changeset in webkit [290889] by
-
- 18 edits in trunk
[webkitbugspy] Allow creation of new issues
https://bugs.webkit.org/show_bug.cgi?id=237123
<rdar://problem/89388181>
Reviewed by Dewei Zhu.
- metadata/trackers.json: Define project.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.projects): Return a dictionary of projects, components and versions.
(Tracker.create): Create a new bug, prompting user for product, component and version
if needed.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.labels): Return a dictionary of all labels associated with the project.
(Tracker.projects): Return an empty dictionary.
(Tracker.create): Create a new issue.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/init.py: Export PROJECT data.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/base.py:
(Base.init): Mock trackers should define a project dictionary.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:
(Bugzilla.init):
(Bugzilla._product_details): Derive product details from project dictionary.
(Bugzilla._create): Create a new bug.
(Bugzilla.request): Handle requests for product details and bug creation.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py:
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:
(GitHub.init):
(GitHub._labels): Return a list of project labels.
(GitHub._create): Create a new issue.
(GitHub.request): Handle requests for labels and issue creation.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:
(RadarClient.find_components): Mock radarclient's component search API.
(RadarClient.create_radar): Mock radarclient's radar creation API.
(Radar.Component): Added.
(Radar.exceptions): Added.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker):
(Tracker.Encoder.default): Pass 'projects' to radar instances.
(Tracker.init): Callers should define projects to limit component scope.
(Tracker.projects): Search radar components to provide a subset relevant to the declared projects.
(Tracker.create): Create a radar, prompting user for component and version if needed.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
(TestBugzilla.test_state_why):
(TestBugzilla):
(TestBugzilla.test_projects):
(TestBugzilla.test_create):
(TestBugzilla.test_create_prompt):
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:
(TestGitHub.test_state_why):
(TestGitHub):
(TestGitHub.test_labels):
(TestGitHub.test_projects):
(TestGitHub.test_create):
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py:
(TestRadar.test_state_why):
(TestRadar):
(TestRadar.test_projects):
(TestRadar.test_create):
(TestRadar.test_create_prompt):
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py:
(Tracker.from_json): Pass 'projects' to radar instances.
(Tracker.projects): Add base-class implementation.
(Tracker.create): Ditto.
Canonical link: https://commits.webkit.org/248120@main
- 6:26 AM Changeset in webkit [290888] by
-
- 10 edits in trunk
[web-animations] text-emphasis-style should support discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237514
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/css/css-text-decor/inheritance-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- 6:24 AM Changeset in webkit [290887] by
-
- 7 edits in trunk
[web-animations] text-emphasis-color should support non-discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237518
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
This property was mistakenly added as a discrete property when it was unprefixed.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 6:22 AM Changeset in webkit [290886] by
-
- 4 edits in trunk
[web-animations] text-decoration-skip-ink should support discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237512
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 6:19 AM Changeset in webkit [290885] by
-
- 4 edits in trunk
[web-animations] line-break should support discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237520
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 6:15 AM Changeset in webkit [290884] by
-
- 15 edits in trunk
Parsing of list-style shorthand is incorrect
https://bugs.webkit.org/show_bug.cgi?id=237515
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-lists/parsing/list-style-computed.sub-expected.txt:
- web-platform-tests/css/css-lists/parsing/list-style-valid-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
- web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
- web-platform-tests/css/cssom/shorthand-values-expected.txt:
Source/WebCore:
The spec at https://drafts.csswg.org/css-lists/#list-style-property says the order of the properties
in the "list-style" shorthand is <'list-style-position'> <'list-style-image'> <'list-style-type'>. Additionally, the "none" value needs special handling such that it sets "list-style-type".
- css/CSSProperties.json:
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseShorthand):
LayoutTests:
Some non-WPT tests had the wrong assumption on the shorthand order
for list-style, so we update those tests to match the spec.
Additionally, the WPT test css/css-lists/list-style-type-string-004.html now passes.
- fast/css/cssText-shorthand-expected.txt:
- fast/css/cssText-shorthand.html:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html:
- platform/mac/TestExpectations:
- 4:43 AM Changeset in webkit [290883] by
-
- 2 edits in trunk/Source/WebCore
makeprop.pl breaks reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=237521
Reviewed by Carlos Garcia Campos.
- css/makeprop.pl: Sort hash elements so the output file is always
the same across different builds.
- 3:47 AM Changeset in webkit [290882] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Add missing CPU(RISCV64) guards in CTI thunk prologue, epilogue generators
https://bugs.webkit.org/show_bug.cgi?id=237517
Unreviewed, adding missing CPU(RISCV64) guards to the CTI thunk prologue
and epilogue generators in CCallHelpers, reusing the ARM variants of the
pair push/pop calls.
Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-03-07
- jit/CCallHelpers.cpp:
(JSC::CCallHelpers::emitCTIThunkPrologue):
(JSC::CCallHelpers::emitCTIThunkEpilogue):
- 3:18 AM Changeset in webkit [290881] by
-
- 3 edits in trunk/Source/WebCore
Add hasTransformOrPerspective() helper to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=237469
Reviewed by Darin Adler.
Avoid duplicating the logic to test if a renderer is transformed in
multiple places. Currently RenderGeometryMap duplicates the logic to add
one extra condition, the presence of a 'perspective' property.
While I was at it: remove the redundant offsetPath() check in
RenderObject::hasTransform(), since RenderStyle::hasTransform()
already returns true if offsetPath() is non-null.
LBSE wants to extend hasTransform() by a new condition: hasSVGTransform().
Before this patch, the place in RenderGeometryMap was easy to miss, fix that,
by centralizing the logic in one place.
Covered by existing tests, no change in behaviour.
- rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderersViaLayers): Use RenderObject::hasTransformOrPespective().
- rendering/RenderObject.h:
(WebCore::RenderObject::hasTransform const): Remove redundant offsetPath() check.
(WebCore::RenderObject::hasTransformOrPespective const): Add new helper.
- 3:16 AM Changeset in webkit [290880] by
-
- 7 edits2 adds in trunk/Source/WebCore
[LBSE] Begin layer-aware RenderSVGTransformableContainer implementation
https://bugs.webkit.org/show_bug.cgi?id=237024
Reviewed by Rob Buis.
Create RenderSVGContainer based on the downstream LBSE implementation.
This patch does not yet enable the creation of RenderSVGContainer
renderers if LBSE is enabled, since the derived classes, such as
RenderSVGHiddenContainer / RenderSVGViewportContainer / ..., are still
missing in LBSE.
Covered by existing tests, no change in behaviour.
- Sources.txt: Add RenderSVGTransformableContainer.* to build.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGTransformableContainer const):
- rendering/svg/RenderSVGTransformableContainer.cpp: Added.
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::associatedUseElement):
(WebCore::RenderSVGTransformableContainer::additionalContainerTranslation const):
(WebCore::RenderSVGTransformableContainer::calculateViewport):
(WebCore::RenderSVGTransformableContainer::layoutChildren):
(WebCore::RenderSVGTransformableContainer::updateFromStyle):
(WebCore::RenderSVGTransformableContainer::applyTransform const):
(WebCore::RenderSVGTransformableContainer::styleWillChange):
(WebCore::RenderSVGTransformableContainer::graphicsElement const):
- rendering/svg/RenderSVGTransformableContainer.h: Added.
- rendering/svg/SVGContainerLayout.cpp:
(WebCore::SVGContainerLayout::transformToRootChanged):
- svg/SVGElement.cpp: Create renderer for <g> elements in LBSE mode.
(WebCore::createSVGLayerAwareElementSet):
- svg/SVGGElement.cpp: Ditto.
(WebCore::SVGGElement::createElementRenderer):
- 2:19 AM Changeset in webkit [290879] by
-
- 9 edits2 adds in trunk
Compute correct containing block override size for items that are subgridden in one dimension only.
https://bugs.webkit.org/show_bug.cgi?id=236951
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Added new WPT similar to auto-track-sizing-001 which adds new variations
with nested subgrids and varying whether the other axis is subgridded.
- web-platform-tests/css/css-grid/subgrid/auto-track-sizing-002-expected.html: Added.
- web-platform-tests/css/css-grid/subgrid/auto-track-sizing-002.html: Added.
Source/WebCore:
Items that are subgridded in one dimension will be included in the track sizing algorithm of the
outer grid for that dimension. When measuring their size in the subgridded dimension, we need to
set their containing block size in the other (non-subgridded) dimension, which is only available
from the subgrid's track sizing, not the outer track sizes.
This recurses up to set the override size on the subgrid element instead, and forces a layout
there, which should copy down subgrid track sizes and compute the other dimension, making it
available on the inner item we need.
Test: imported/w3c/web-platform-tests/css/css-grid/subgrid/auto-track-sizing-002.html
- rendering/GridLayoutFunctions.cpp:
(WebCore::GridLayoutFunctions::extraMarginForSubgridAncestors):
- rendering/GridLayoutFunctions.h:
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverridingContainingBlockContentSizeForChild const):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::isSubgridOf):
- rendering/RenderGrid.h:
LayoutTests:
Marked existing WPT as passing.
- 2:17 AM Changeset in webkit [290878] by
-
- 2 edits in trunk/Source/WebCore
Release_Assert | WebCore::Document::addTopLayerElement()
https://bugs.webkit.org/show_bug.cgi?id=237307
Patch by Frédéric Wang <fwang@igalia.com> on 2022-03-07
Reviewed by Chris Dumez.
setBooleanAttribute() call in HTMLDialogElement::showModal() dispatches a DOMSubtreeModified
event. Postpone it so that listeners cannot disconnect the dialog element.
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal): Add a queue to postpone event.
Mar 6, 2022:
- 10:43 PM Changeset in webkit [290877] by
-
- 28 edits in trunk/Source/WebGPU
[WebGPU] Use C++ references instead of pointers where applicable
https://bugs.webkit.org/show_bug.cgi?id=237508
Reviewed by Tim Horton.
The header we're implementing uses pointers because it's a C header.
Our internal implementation can use references instead.
- WebGPU/Adapter.h:
- WebGPU/Adapter.mm:
(WebGPU::Adapter::getLimits):
(WebGPU::Adapter::getProperties):
(WebGPU::Adapter::requestDevice):
(wgpuAdapterGetLimits):
(wgpuAdapterGetProperties):
(wgpuAdapterRequestDevice):
(wgpuAdapterRequestDeviceWithBlock):
- WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
- WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
- WebGPU/Buffer.mm:
(WebGPU::Device::createBuffer):
- WebGPU/CommandEncoder.h:
- WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::CommandEncoder::finish):
(wgpuCommandEncoderBeginComputePass):
(wgpuCommandEncoderBeginRenderPass):
(wgpuCommandEncoderCopyBufferToTexture):
(wgpuCommandEncoderCopyTextureToBuffer):
(wgpuCommandEncoderCopyTextureToTexture):
(wgpuCommandEncoderFinish):
- WebGPU/ComputePipeline.mm:
(WebGPU::Device::createComputePipeline):
(WebGPU::Device::createComputePipelineAsync):
- WebGPU/Device.h:
- WebGPU/Device.mm:
(WebGPU::Device::getLimits):
(wgpuDeviceCreateBindGroup):
(wgpuDeviceCreateBindGroupLayout):
(wgpuDeviceCreateBuffer):
(wgpuDeviceCreateCommandEncoder):
(wgpuDeviceCreateComputePipeline):
(wgpuDeviceCreateComputePipelineAsync):
(wgpuDeviceCreateComputePipelineAsyncWithBlock):
(wgpuDeviceCreatePipelineLayout):
(wgpuDeviceCreateQuerySet):
(wgpuDeviceCreateRenderBundleEncoder):
(wgpuDeviceCreateRenderPipeline):
(wgpuDeviceCreateRenderPipelineAsync):
(wgpuDeviceCreateRenderPipelineAsyncWithBlock):
(wgpuDeviceCreateSampler):
(wgpuDeviceCreateShaderModule):
(wgpuDeviceCreateSwapChain):
(wgpuDeviceCreateTexture):
(wgpuDeviceGetLimits):
- WebGPU/Instance.h:
- WebGPU/Instance.mm:
(WebGPU::Instance::create):
(WebGPU::Instance::createSurface):
(WebGPU::Instance::requestAdapter):
(wgpuCreateInstance):
(wgpuInstanceCreateSurface):
(wgpuInstanceRequestAdapter):
(wgpuInstanceRequestAdapterWithBlock):
- WebGPU/PipelineLayout.mm:
(WebGPU::Device::createPipelineLayout):
- WebGPU/QuerySet.mm:
(WebGPU::Device::createQuerySet):
- WebGPU/Queue.h:
- WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):
(wgpuQueueWriteTexture):
- WebGPU/RenderBundleEncoder.h:
- WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
(WebGPU::RenderBundleEncoder::finish):
(wgpuRenderBundleEncoderFinish):
- WebGPU/RenderPassEncoder.h:
- WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::setBlendConstant):
(wgpuRenderPassEncoderSetBlendConstant):
- WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::Device::createRenderPipelineAsync):
- WebGPU/Sampler.mm:
(WebGPU::Device::createSampler):
- WebGPU/ShaderModule.h:
- WebGPU/ShaderModule.mm:
(WebGPU::findShaderModuleParameters):
(WebGPU::Device::createShaderModule):
(WebGPU::ShaderModule::getCompilationInfo):
(wgpuShaderModuleGetCompilationInfo):
(wgpuShaderModuleGetCompilationInfoWithBlock):
- WebGPU/SwapChain.mm:
(WebGPU::Device::createSwapChain):
- WebGPU/Texture.h:
- WebGPU/Texture.mm:
(WebGPU::Device::createTexture):
(WebGPU::Texture::createView):
(wgpuTextureCreateView):
- 7:52 PM Changeset in webkit [290876] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Fix key expired treatment with Python3
https://bugs.webkit.org/show_bug.cgi?id=237509
Reviewed by Fujii Hironori.
- flatpak/flatpakutils.py:
(FlatpakObject.flatpak_update):
- 9:39 AM Changeset in webkit [290875] by
-
- 4 edits1 add in trunk
[iOS] Layer tree can get indefinitely frozen if WKWebView is unparented underneath -[UIWindow dealloc]
https://bugs.webkit.org/show_bug.cgi?id=237505
rdar://85563958
Reviewed by Tim Horton.
Source/WebKit:
It's currently possible for the web page to get permanently stuck in frozen state, due to the
BackgroundApplicationlayer tree freeze reason; this occurs when the web view is unparented from the view
hierarchy underneath the scope of UIWindow's-deallocmethod.
During
-[UIWindow dealloc], the backpointer underlying the implementation of-[UIView window]is set tonil
immediately before the subclassing method hook-willMoveToWindow:is invoked on the view hierarchy. This means
that when-willMoveToWindow:is invoked,self.windowwill returnnil. This, in turn, puts
WKApplicationStateTrackingViewin a bad state because we bail early before resetting_applicationStateTracker
in the early return below, since we (erroneously) believe that we've already been unparented from the view
hierarchy, so we don't need to do anything.
`
if (!self._contentView.window newWindow) return;
`
As a result, if the same web view is eventually moved back into another visible window,
-didMoveToWindowbails
before setting up the_applicationStateTrackeragain, since it already exists from when the previous window
was still active. This means-_applicationWillEnterForegroundis never called when the web view is
reintroduced to the view hierarchy, soLayerTreeFreezeReason::BackgroundApplicationis never lifted.
To address this, we simply remove the debug assertion for
_applicationStateTracker, and instead check whether
the application state tracker exists or not for the logic of the early return. Doing so also makes the early
return in-willMoveToWindow:consistent with the logic in one in-didMoveToWindow, which already consults
_applicationStateTracker:
`
- (void)didMoveToWindow
{
if (!self._contentView.window _applicationStateTracker) return;
`
Test: ApplicationStateTracking.WindowDeallocDoesNotPermanentlyFreezeLayerTree
- UIProcess/ios/WKApplicationStateTrackingView.mm:
(-[WKApplicationStateTrackingView willMoveToWindow:]): See above.
Tools:
Add an API test to exercise the bug. This API test is comprised of the following series of steps:
- Create the web view and add it under window #1.
- Post a "did enter background" notification.
- Deallocate window #1 (thereby unparenting the web view in the process).
- Post a "will enter foreground" notification.
- Add the web view under window #2.
- Load some HTML content and wait for a presentation update.
Before the fix, this test times out because the layer tree is permanently frozen after step (3), due to the
BackgroundApplicationreason, so the presentation update in step (6) never finishes.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/ios/ApplicationStateTracking.mm: Added.
(TestWebKitAPI::TEST):
- 9:28 AM Changeset in webkit [290874] by
-
- 14 edits in trunk/Source
Push HTMLMediaElement renderer's contentBox rect to GPU process
https://bugs.webkit.org/show_bug.cgi?id=237444
rdar://84869202
Reviewed by Jer Noble.
Source/WebCore:
No new tests. This is a speculative fix, with new logging, for an issue I haven't
been able to reproduce.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateRenderer): Push mediaPlayerContentBoxRect to the
media player.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::playerContentBoxRectChanged): Pass rect to platform player.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::playerContentBoxRectChanged):
Source/WebKit:
- GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy): Configuration now has
playerContentBoxRect.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerContentBoxRect const):
(WebKit::RemoteMediaPlayerProxy::playerContentBoxRectChanged): Update playerContentBoxRect.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
- GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeIfPossible): Convert from static
function so we can log.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): Add logging.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged): Ditto.
(WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeFenced): Ditto.
(WebKit::setVideoInlineSizeIfPossible): Deleted.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::playerContentBoxRectChanged):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):
