Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Apr 27, 2022:

10:36 PM Changeset in webkit [293566] by Tyler Wilcock

• 3 edits in trunk/Source/WebCore

AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them
​https://bugs.webkit.org/show_bug.cgi?id=239787

Reviewed by Chris Fleizach.

This patch fixes this a bug where AXObjectCache::childrenChanged
methods modify m_deferred* member variables, but doesn't start
the m_performCacheUpdateTimer.

This patch also renames m_deferredChildrenChangedNodeList to
m_deferredNodeAddedOrRemovedList, since this more accurately
captures what this list is for.

Finally, this refactors a few methods that modify m_deferred* member
variables to not start the cache timer unless the variable has
actually changed.

Fixes these tests in ITM:

• accessibility/mac/focus-moves-cursor.html
• accessibility/image-load-on-delay.html
• accessibility/legend-children-are-visible.html
• accessibility/text-alternative-calculation-hidden-nodes.html

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::deferMenuListValueChange):
(WebCore::AXObjectCache::deferModalChange):
(WebCore::AXObjectCache::deferNodeAddedOrRemoved): Added.
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):

• accessibility/AXObjectCache.h:

10:32 PM Changeset in webkit [293565] by Patrick Angle

• 5 edits in trunk

Web Inspector: [Flexbox] <button> and <select> elements are appearing in list of Flex containers
​https://bugs.webkit.org/show_bug.cgi?id=239425

Reviewed by Devin Rousso.

Source/WebCore:

Added test cases to inspector/css/nodeLayoutContextTypeChanged.html.

• inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::layoutContextTypeForRenderer):

LayoutTests:

• inspector/css/nodeLayoutContextTypeChanged-expected.txt:
• inspector/css/nodeLayoutContextTypeChanged.html:

10:01 PM Changeset in webkit [293564] by Wenson Hsieh

• 7 edits in trunk/Source/WebKit

[iOS] Add a mechanism to override desktop-class browsing state in multitasking mode
​https://bugs.webkit.org/show_bug.cgi?id=239801
rdar://89786146

Reviewed by Tim Horton.

Keep the recommended desktop-class browsing state stable as the width of the web view changes, while
multitasking mode is active.

• UIProcess/API/ios/WKWebViewIOS.h:
• UIProcess/PageClient.h:

(WebKit::PageClient::isInMultitaskingMode const):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isInMultitaskingMode const):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const):

Turn the static helper function desktopClassBrowsingRecommended into a private method instead, so that we
don't need to pass in all the information we need from the WebPageProxy when determining whether we should
default to desktop-class browsing. This also allows us to make a slight adjustment here to avoid recommending
mobile content when the window is narrower than 375 points in multitasking mode.

(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
(WebKit::desktopClassBrowsingRecommended): Deleted.

9:50 PM Changeset in webkit [293563] by Chris Dumez

• 161 edits in trunk/Source

Prepare more of the code base for making the AtomString(const String&) constructor explicit
​https://bugs.webkit.org/show_bug.cgi?id=239711

Reviewed by Darin Adler.

Prepare more of the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

• Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::processResponse):

• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::dumpHistoryItem):

• Source/WTF/wtf/text/StringImpl.h:
• Source/WebCore/Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):

• Source/WebCore/Modules/highlight/HighlightRegister.cpp:

(WebCore::HighlightRegister::setFromMapLike):
(WebCore::HighlightRegister::remove):

• Source/WebCore/Modules/highlight/HighlightRegister.h:

(WebCore::HighlightRegister::map const):

• Source/WebCore/Modules/highlight/HighlightRegister.idl:
• Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:
• Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl:
• Source/WebCore/Modules/mediastream/RTCDataChannel.idl:
• Source/WebCore/Modules/mediastream/RTCDataChannelEvent.idl:
• Source/WebCore/Modules/pictureinpicture/PictureInPictureEvent.idl:
• Source/WebCore/Modules/push-api/PushEvent.idl:
• Source/WebCore/Modules/push-api/PushSubscriptionChangeEvent.idl:
• Source/WebCore/Modules/speech/SpeechSynthesisErrorEvent.idl:
• Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl:
• Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl:
• Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):

• Source/WebCore/Modules/websockets/WebSocketHandshake.h:
• Source/WebCore/animation/AnimationPlaybackEvent.idl:
• Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::customPropertyText):

• Source/WebCore/css/CSSComputedStyleDeclaration.h:
• Source/WebCore/css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableReference):

• Source/WebCore/css/ContainerQueryParser.cpp:

(WebCore::ContainerQueryParser::consumeFilteredContainerQuery):
(WebCore::consumeFeatureName):

• Source/WebCore/css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):

• Source/WebCore/css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoClassSelector):

• Source/WebCore/css/typedom/CSSStyleValue.cpp:

(WebCore::CSSStyleValue::parse):
(WebCore::CSSStyleValue::parseAll):

• Source/WebCore/css/typedom/CSSStyleValue.h:
• Source/WebCore/css/typedom/CSSStyleValue.idl:
• Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:

(WebCore::CSSStyleValueFactory::extractCustomCSSValues):
(WebCore::CSSStyleValueFactory::parseStyleValue):

• Source/WebCore/css/typedom/CSSStyleValueFactory.h:
• Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:

(WebCore::ComputedStylePropertyMapReadOnly::get const):
(WebCore::ComputedStylePropertyMapReadOnly::getAll const):
(WebCore::ComputedStylePropertyMapReadOnly::has const):

• Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.h:
• Source/WebCore/css/typedom/StylePropertyMapReadOnly.h:
• Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl:
• Source/WebCore/dom/AnimationEvent.idl:
• Source/WebCore/dom/Document.cpp:

(WebCore::Document::setContentLanguage):
(WebCore::Document::processMetaHttpEquiv):

• Source/WebCore/dom/Document.h:

(WebCore::Document::contentLanguage const):
(WebCore::Document::baseTarget const):

• Source/WebCore/dom/Element.h:

(WebCore::Element::target const):

• Source/WebCore/dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):

• Source/WebCore/dom/KeyboardEvent.h:
• Source/WebCore/dom/KeyboardEvent.idl:
• Source/WebCore/dom/PointerEvent.cpp:

(WebCore::PointerEvent::create):

• Source/WebCore/dom/PointerEvent.h:
• Source/WebCore/dom/PopStateEvent.idl:
• Source/WebCore/dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):

• Source/WebCore/dom/StyledElement.cpp:
• Source/WebCore/history/HistoryItem.cpp:

(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::target const):
(WebCore::HistoryItem::setTarget):
(WebCore::HistoryItem::childItemWithTarget):

• Source/WebCore/history/HistoryItem.h:
• Source/WebCore/html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement):

• Source/WebCore/html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

• Source/WebCore/html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

• Source/WebCore/html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setupDateTimeChooserParameters):

• Source/WebCore/html/CustomPaintImage.cpp:

(WebCore::extractComputedProperty):
(WebCore::CustomPaintImage::doCustomPaint):

• Source/WebCore/html/CustomPaintImage.h:
• Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::target const):
(WebCore::HTMLAnchorElement::effectiveTarget const):

• Source/WebCore/html/HTMLAnchorElement.h:
• Source/WebCore/html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target const):

• Source/WebCore/html/HTMLAreaElement.h:
• Source/WebCore/html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::target const):

• Source/WebCore/html/HTMLBaseElement.h:
• Source/WebCore/html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::target const):
(WebCore::HTMLFormElement::effectiveTarget const):

• Source/WebCore/html/HTMLFormElement.h:
• Source/WebCore/html/HTMLHtmlElement.idl:
• Source/WebCore/html/HTMLIFrameElement.idl:
• Source/WebCore/html/HTMLImageElement.idl:
• Source/WebCore/html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::target const):

• Source/WebCore/html/HTMLLinkElement.h:
• Source/WebCore/html/track/AudioTrack.idl:
• Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
• Source/WebCore/loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

• Source/WebCore/loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• Source/WebCore/loader/FormSubmission.cpp:

(WebCore::FormSubmission::FormSubmission):

• Source/WebCore/loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::target const):
(WebCore::FormSubmission::Attributes::setTarget):
(WebCore::FormSubmission::target const):

• Source/WebCore/loader/FrameLoadRequest.cpp:

(WebCore::FrameLoadRequest::FrameLoadRequest):

• Source/WebCore/loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::frameName const):
(WebCore::FrameLoadRequest::setFrameName):

• Source/WebCore/loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::extractContentLanguageFromHeader):
(WebCore::FrameLoader::didBeginDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):

• Source/WebCore/loader/FrameLoader.h:
• Source/WebCore/loader/HistoryController.cpp:

(WebCore::FrameLoader::HistoryController::recursiveGoToItem):

• Source/WebCore/loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):

• Source/WebCore/page/DOMWindow.cpp:

(WebCore::DOMWindow::name const):
(WebCore::DOMWindow::setName):

• Source/WebCore/page/DOMWindow.h:
• Source/WebCore/page/DOMWindow.idl:
• Source/WebCore/page/DragController.cpp:

(WebCore::documentFragmentFromDragData):

• Source/WebCore/page/ModalContainerObserver.h:

(WebCore::ModalContainerObserver::overrideSearchTermForTesting):

• Source/WebCore/page/Navigator.cpp:

(WebCore::Navigator::initializePluginAndMimeTypeArrays):

• Source/WebCore/page/PageSerializer.cpp:

(WebCore::PageSerializer::SerializerMarkupAccumulator::appendCustomAttributes):

• Source/WebCore/page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

• Source/WebCore/platform/graphics/FontCache.cpp:

(WebCore::FontCache::cachedFontPlatformData):

• Source/WebCore/platform/graphics/FontDescription.cpp:

(WebCore::computeSpecializedChineseLocale):

• Source/WebCore/platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::supportsType):

• Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::FontDescription::platformResolveGenericFamily):

• Source/WebCore/platform/graphics/filters/FilterOperation.cpp:

(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):

• Source/WebCore/platform/graphics/filters/FilterOperation.h:

(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::fragment const):

• Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::settings):

• Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):

• Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::settings):
(WebCore::MockRealtimeAudioSource::capabilities):

• Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::capabilities):
(WebCore::MockRealtimeVideoSource::settings):

• Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp:
• Source/WebCore/platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):

• Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::mimeType const):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::textEncodingName const):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::httpVersion const):
(WebCore::ResourceResponseBase::setHTTPVersion):

• Source/WebCore/platform/network/ResourceResponseBase.h:
• Source/WebCore/plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::type const):

• Source/WebCore/plugins/DOMMimeType.h:
• Source/WebCore/plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::supportedPropertyNames const):

• Source/WebCore/plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::supportedPropertyNames const):

• Source/WebCore/plugins/PluginData.h:
• Source/WebCore/rendering/MarkedText.h:
• Source/WebCore/rendering/PathOperation.cpp:

(WebCore::ReferencePathOperation::create):
(WebCore::ReferencePathOperation::ReferencePathOperation):

• Source/WebCore/rendering/PathOperation.h:
• Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCustomPaintWatchProperty):

• Source/WebCore/rendering/style/RenderStyle.h:
• Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

• Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
• Source/WebCore/style/RuleSetBuilder.cpp:

(WebCore::Style::RuleSetBuilder::pushCascadeLayer):

• Source/WebCore/style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyCustomProperty):

• Source/WebCore/style/StyleBuilder.h:
• Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertPathOperation):

• Source/WebCore/style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyValueListStyleType):
(WebCore::Style::BuilderCustom::applyValueWebkitLocale):
(WebCore::Style::BuilderCustom::applyValueFontFamily):
(WebCore::Style::BuilderCustom::applyValueTextEmphasisStyle):
(WebCore::Style::BuilderCustom::applyValueCounter):
(WebCore::Style::BuilderCustom::applyValueAlt):

• Source/WebCore/style/StyleBuilderState.cpp:

(WebCore::Style::BuilderState::createFilterOperations):

• Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

• Source/WebCore/svg/SVGAElement.h:
• Source/WebCore/svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAttribute):
(WebCore::SVGElement::synchronizeAllAttributes):
(WebCore::SVGElement::commitPropertyChange):
(WebCore::SVGElement::insertedIntoAncestor):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):

• Source/WebCore/svg/SVGElement.h:

(WebCore::SVGElement::className const):

• Source/WebCore/svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::fragmentIdentifierFromIRIString):
(WebCore::SVGURIReference::targetElementFromIRIString):

• Source/WebCore/svg/SVGURIReference.h:
• Source/WebCore/svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateUserAgentShadowTree):
(WebCore::SVGUseElement::findTarget const):

• Source/WebCore/svg/SVGUseElement.h:
• Source/WebCore/svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::Condition::Condition):
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::parseCondition):

• Source/WebCore/svg/animation/SVGSMILElement.h:
• Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::calculateFilterOutsets):

• Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::overrideModalContainerSearchTermForTesting):

• Source/WebCore/testing/Internals.h:
• Source/WebCore/testing/Internals.idl:
• Source/WebCore/worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::PaintDefinition::PaintDefinition):
(WebCore::PaintWorkletGlobalScope::registerPaint):

• Source/WebCore/worklets/PaintWorkletGlobalScope.h:
• Source/WebCore/worklets/PaintWorkletGlobalScope.idl:
• Source/WebCore/xml/CustomXPathNSResolver.cpp:

(WebCore::CustomXPathNSResolver::lookupNamespaceURI):

• Source/WebCore/xml/XPathGrammar.cpp:
• Source/WebCore/xml/XPathParser.cpp:

(WebCore::XPath::Parser::expandQualifiedName):

• Source/WebCore/xml/XPathParser.h:

Canonical link: ​https://commits.webkit.org/250077@main

9:09 PM Changeset in webkit [293562] by Chris Dumez

• 4 edits in trunk/Source/WebKit/UIProcess

GPUProcess doesn't get notified of imminent process suspension
​https://bugs.webkit.org/show_bug.cgi?id=239815

Reviewed by Tim Horton.

By defaults, ProcessThrottler in the UIProcess use a ProcessAndUIAssertion instance internally,
instead of a simple ProcessAssertion. This makes sure that a process assertion is taken on
behalf of the UIProcess as well, not just the child process. This also makes sure that when
the UIProcess has been in the background for too long and its assertion gets invalidated, we
release all ProcessAndUIAssertion instances as well.

The WebProcess and NetworkProcess were correctly using a ProcessAndUIAssertion. However, the
GPUProcess was passing false when constructing the ProcessThrottler, causing it to use a
simple ProcessAssertion. As a result, the GPUProcess would not get notified on imminent
suspension when the app has been running in the background for too long.

This patch aligns the behavior of the GPUProcess with the one of the NetworkProcess since
both processes are very similar.

• Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::GPUProcessProxy):

• Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::anyProcessPoolShouldTakeUIBackgroundAssertion): Deleted.

• Source/WebKit/UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion):

• Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: ​https://commits.webkit.org/250076@main

9:03 PM Changeset in webkit [293561] by Chris Dumez

• 35 edits in trunk

Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char*
​https://bugs.webkit.org/show_bug.cgi?id=239802

Reviewed by Darin Adler.

Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char*,
as we are encouraging developers to use ""_s for string literals.

• Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

• Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:

(parameterValue):
(WebFrameLoaderClient::createPlugin):

• Source/WTF/wtf/text/AtomString.h:

(WTF::equalIgnoringASCIICase):

• Source/WTF/wtf/text/StringImpl.h:

(WTF::equalIgnoringASCIICase):

• Source/WTF/wtf/text/StringView.h:

(WTF::equalIgnoringASCIICase):

• Source/WTF/wtf/text/WTFString.h:

(WTF::equalIgnoringASCIICase):

• Source/WTF/wtf/unix/LanguageUnix.cpp:

(WTF::platformLanguage):

• Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::validatedPaymentNetwork const):

• Source/WebCore/accessibility/AccessibilityNodeObject.cpp:

(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuElementForMenuButton const):
(WebCore::AccessibilityNodeObject::menuItemElementForMenu const):

• Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::popupValue const):

• Source/WebCore/css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific const):

• Source/WebCore/css/MediaQueryEvaluator.h:
• Source/WebCore/dom/Document.cpp:

(WebCore::messageSourceForWTFLogChannel):

• Source/WebCore/dom/SecurityContext.cpp:

(WebCore::SecurityContext::isSupportedSandboxPolicy):

• Source/WebCore/html/HiddenInputType.cpp:

(WebCore::HiddenInputType::appendFormData const):

• Source/WebCore/html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::isSupported):

• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):

• Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):

• Source/WebCore/page/FrameTree.cpp:

(WebCore::isBlankTargetFrameName):
(WebCore::isParentTargetFrameName):
(WebCore::isSelfTargetFrameName):
(WebCore::isTopTargetFrameName):

• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::keySystemIsSupported):

• Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::similarFont):
(WebCore::FontCache::platformAlternateFamilyName):

• Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

• Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::isThunderRanked):

• Source/WebCore/platform/network/CacheValidation.cpp:
• Source/WebCore/platform/network/HTTPParsers.cpp:

(WebCore::normalizeHTTPMethod):
(WebCore::isSafeMethod):

• Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:

(WebCore::CurlMultipartHandle::extractBoundary):

• Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp:

(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):

• Source/WebCore/style/ElementRuleCollector.h:

(WebCore::Style::ElementRuleCollector::setMedium):

• Source/WebCore/svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
(WebCore::SVGToOTFFontConverter::appendGSUBTable):

• Source/WebCore/xml/XMLHttpRequest.cpp:

(WebCore::replaceCharsetInMediaTypeIfNeeded):

Canonical link: ​https://commits.webkit.org/250075@main

8:23 PM Changeset in webkit [293560] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS wk1 ] Fourteen webgl/2.0.0/conformance tests are a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=239835

Unreviewed test gardening.

• LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: ​https://commits.webkit.org/250074@main

8:19 PM Changeset in webkit [293559] by sihui_liu@apple.com

• 2 edits in trunk/Tools

[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout
​https://bugs.webkit.org/show_bug.cgi?id=239310
<rdar://problem/91721160>

Reviewed by Youenn Fablet.

Message may be received before runTestAndCheckResult(), so we should not unset receivedScriptMessage before
wait.

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:

(runUntilMessageReceived):
(TEST):
(runTestAndCheckResult): Deleted.

8:04 PM Changeset in webkit [293558] by msaboff@apple.com

• 2 edits in trunk/Source/WebGPU

WebGPU doesn't create a symlink to the system content path in installhdrs
​https://bugs.webkit.org/show_bug.cgi?id=239819

Reviewed by Alexey Proskuryakov.

Enabled script phases for installhdrs and installapi.

• Configurations/WebGPU.xcconfig:

8:03 PM Changeset in webkit [293557] by Jonathan Bedard

• 9 edits in trunk

[git-webkit] Run style checker
​https://bugs.webkit.org/show_bug.cgi?id=239730
<rdar://problem/92428565>

Reviewed by Chris Dumez.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git): Add webkitscmpy.auto-check option.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.parser): Add --check/--no-check flag.
(PullRequest.pre_pr_checks): Find and run all pre-PR checks.
(PullRequest.create_pull_request): Run PR checks.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
• metadata/git_config_extension: Add style-checker as pre-pr check.

Canonical link: ​https://commits.webkit.org/250071@main

7:46 PM Changeset in webkit [293556] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.2.5

Tag WebKit-7613.2.7.2.5.

7:45 PM Changeset in webkit [293555] by Russell Epstein

• 9 edits in branches/safari-613.2.7.2-branch/Source

Versioning.

WebKit-7613.2.7.2.5

7:42 PM Changeset in webkit [293554] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.3.5

Tag WebKit-7613.2.7.3.5.

7:37 PM Changeset in webkit [293553] by Russell Epstein

• 9 edits in branches/safari-613.2.7.3-branch/Source

Versioning.

WebKit-7613.2.7.3.5

7:25 PM Changeset in webkit [293552] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.0.6

Tag WebKit-7613.2.7.0.6.

7:24 PM Changeset in webkit [293551] by Russell Epstein

• 9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.6

7:03 PM Changeset in webkit [293550] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebCore

Ensure completion handler is called in SWServer::clear
​https://bugs.webkit.org/show_bug.cgi?id=239755

Reviewed by Youenn Fablet.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::clearAll):
(WebCore::SWServer::clear):

5:32 PM Changeset in webkit [293549] by Ross Kirsling

• 2 edits in trunk/Source/bmalloc

Unreviewed libpas build fix for PlayStation.
​https://bugs.webkit.org/show_bug.cgi?id=239834

• libpas/src/libpas/pas_random.h:

(pas_get_random):
Temporarily disable path on PlayStation.

Canonical link: ​https://commits.webkit.org/250069@main

5:29 PM Changeset in webkit [293548] by Chris Dumez

• 82 edits in trunk

Drop AtomString(const char*, ConstructFromLiteral) constructor
​https://bugs.webkit.org/show_bug.cgi?id=239721

Reviewed by Darin Adler.

Drop AtomString(const char*, ConstructFromLiteral) constructor and instead update
the call sites to use the AtomString(ASCIILiteral) one instead. It reduces
complexity to not have several constructor for the same purpose.

• Tools/TestWebKitAPI/Tests/WTF/AtomString.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

• Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::resourceType):

• Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::subresourcesType):

• Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::soupHTTPVersionToString):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):

• Source/WTF/wtf/text/AtomString.cpp:

(WTF::AtomString::init):

• Source/WTF/wtf/text/AtomString.h:
• Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp:

(WebCore::stringForPlaybackTargetAvailability):

• Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::automaticKeyword):
(WebCore::MediaControlsHost::forcedOnlyKeyword):
(WebCore::alwaysOnKeyword):
(WebCore::manualKeyword):
(WebCore::MediaControlsHost::mediaControlsContainerClassName const):

• Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind const):
(WebCore::MediaStreamTrack::contentHint const):

• Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:

(WebCore::blobKeyword):
(WebCore::arraybufferKeyword):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::installReplacement):

• Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::liveRegionRelevant const):

• Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):

• Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunction_methodWithOptionalAtomStringAndDefaultValueBody):

• Source/WebCore/css/MediaFeatureNames.cpp:

(WebCore::MediaFeatureNames::init):

• Source/WebCore/css/makeprop.pl:
• Source/WebCore/css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::parsePseudoElementSelector):

• Source/WebCore/dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::nameForProperty const):

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::validateCustomElementName):

• Source/WebCore/dom/EventNames.cpp:
• Source/WebCore/dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::imageOverlayElementIdentifier):
(WebCore::ImageOverlay::imageOverlayDataDetectorClass):
(WebCore::ImageOverlay::imageOverlayLineClass):
(WebCore::ImageOverlay::imageOverlayTextClass):
(WebCore::ImageOverlay::imageOverlayBlockClass):

• Source/WebCore/dom/MutationRecord.cpp:
• Source/WebCore/dom/mac/ImageControlsMac.cpp:

(WebCore::ImageControlsMac::imageControlsElementIdentifier):
(WebCore::ImageControlsMac::imageControlsButtonIdentifier):

• Source/WebCore/dom/make_names.pl:

(printNamesCppFile):

• Source/WebCore/editing/MarkupAccumulator.cpp:

(WebCore::htmlAttributeSerialization):

• Source/WebCore/html/Autocapitalize.cpp:

(WebCore::stringForAutocapitalizeType):

• Source/WebCore/html/Autofill.cpp:

(WebCore::isContactToken):

• Source/WebCore/html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

• Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):
(WebCore::HTMLAnchorElement::isSystemPreviewLink):

• Source/WebCore/html/HTMLElement.cpp:

(WebCore::toValidDirValue):

• Source/WebCore/html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::formControlType const):

• Source/WebCore/html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::formControlType const):

• Source/WebCore/html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::formControlType const):

• Source/WebCore/html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::formControlType const):

• Source/WebCore/html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::scope const):

• Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::formControlType const):

• Source/WebCore/html/HTMLTextFormControlElement.cpp:

(WebCore::directionString):

• Source/WebCore/html/InputMode.cpp:

(WebCore::InputModeNames::numeric):
(WebCore::InputModeNames::decimal):

• Source/WebCore/html/InputTypeNames.cpp:

(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::week):

• Source/WebCore/html/MediaController.cpp:

(WebCore::playbackStateWaiting):
(WebCore::playbackStatePlaying):
(WebCore::playbackStateEnded):

• Source/WebCore/html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

• Source/WebCore/html/ModelDocument.cpp:

(WebCore::ModelDocumentParser::createDocumentStructure):

• Source/WebCore/html/PDFDocument.cpp:

(WebCore::PDFDocument::createDocumentStructure):

• Source/WebCore/html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

• Source/WebCore/html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createContainer):

• Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::createForeignAttributesMap):

• Source/WebCore/html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):

• Source/WebCore/html/shadow/ShadowPseudoIds.cpp:

(WebCore::ShadowPseudoIds::cue):
(WebCore::ShadowPseudoIds::fileSelectorButton):
(WebCore::ShadowPseudoIds::placeholder):
(WebCore::ShadowPseudoIds::webkitContactsAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCredentialsAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCreditCardAutoFillButton):
(WebCore::ShadowPseudoIds::webkitStrongPasswordAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCapsLockIndicator):
(WebCore::ShadowPseudoIds::webkitColorSwatch):
(WebCore::ShadowPseudoIds::webkitColorSwatchWrapper):
(WebCore::ShadowPseudoIds::webkitDatetimeEdit):
(WebCore::ShadowPseudoIds::webkitDatetimeEditText):
(WebCore::ShadowPseudoIds::webkitDatetimeEditFieldsWrapper):
(WebCore::ShadowPseudoIds::webkitDateAndTimeValue):
(WebCore::ShadowPseudoIds::webkitDetailsMarker):
(WebCore::ShadowPseudoIds::webkitGenericCueRoot):
(WebCore::ShadowPseudoIds::webkitInnerSpinButton):
(WebCore::ShadowPseudoIds::webkitListButton):
(WebCore::ShadowPseudoIds::webkitMediaSliderThumb):
(WebCore::ShadowPseudoIds::webkitMediaSliderContainer):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackContainer):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackDisplay):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackDisplayBackdrop):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackRegion):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackRegionContainer):
(WebCore::ShadowPseudoIds::webkitMeterBar):
(WebCore::ShadowPseudoIds::webkitMeterInnerElement):
(WebCore::ShadowPseudoIds::webkitMeterOptimumValue):
(WebCore::ShadowPseudoIds::webkitMeterSuboptimumValue):
(WebCore::ShadowPseudoIds::webkitMeterEvenLessGoodValue):
(WebCore::ShadowPseudoIds::webkitPluginReplacement):
(WebCore::ShadowPseudoIds::webkitProgressBar):
(WebCore::ShadowPseudoIds::webkitProgressValue):
(WebCore::ShadowPseudoIds::webkitProgressInnerElement):
(WebCore::ShadowPseudoIds::webkitSearchDecoration):
(WebCore::ShadowPseudoIds::webkitSearchResultsButton):
(WebCore::ShadowPseudoIds::webkitSearchResultsDecoration):
(WebCore::ShadowPseudoIds::webkitSearchCancelButton):
(WebCore::ShadowPseudoIds::webkitSliderRunnableTrack):
(WebCore::ShadowPseudoIds::webkitSliderThumb):
(WebCore::ShadowPseudoIds::webkitSliderContainer):
(WebCore::ShadowPseudoIds::webkitTextfieldDecorationContainer):
(WebCore::ShadowPseudoIds::webkitValidationBubble):
(WebCore::ShadowPseudoIds::webkitValidationBubbleArrowClipper):
(WebCore::ShadowPseudoIds::webkitValidationBubbleArrow):
(WebCore::ShadowPseudoIds::webkitValidationBubbleMessage):
(WebCore::ShadowPseudoIds::webkitValidationBubbleIcon):
(WebCore::ShadowPseudoIds::webkitValidationBubbleTextBlock):
(WebCore::ShadowPseudoIds::webkitValidationBubbleHeading):
(WebCore::ShadowPseudoIds::webkitValidationBubbleBody):

• Source/WebCore/html/track/AudioTrack.cpp:

(WebCore::AudioTrack::descriptionKeyword):
(WebCore::AudioTrack::mainDescKeyword):
(WebCore::AudioTrack::translationKeyword):

• Source/WebCore/html/track/TextTrack.cpp:

(WebCore::descriptionsKeyword):
(WebCore::chaptersKeyword):
(WebCore::metadataKeyword):
(WebCore::forcedKeyword):

• Source/WebCore/html/track/VTTRegion.cpp:

(WebCore::upKeyword):
(WebCore::VTTRegion::textTrackCueContainerScrollingClass):

• Source/WebCore/html/track/VideoTrack.cpp:

(WebCore::VideoTrack::signKeyword):

• Source/WebCore/loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::initiatorName const):

• Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp:

(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):

• Source/WebCore/page/EventHandler.cpp:

(WebCore::focusDirectionForKey):

• Source/WebCore/page/Quirks.cpp:

(WebCore::Quirks::shouldBypassBackForwardCache const):

• Source/WebCore/platform/CommonAtomStrings.cpp:
• Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::eventNameAll):

• Source/WebCore/platform/graphics/FontCascade.cpp:

(WebCore::useBackslashAsYenSignForFamily):

• Source/WebCore/platform/graphics/FontDescription.cpp:

(WebCore::computeSpecializedChineseLocale):

• Source/WebCore/platform/graphics/MediaPlayer.cpp:

(WebCore::applicationOctetStream):

• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::metadataType):

• Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::lastResortFallbackFont):

• Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::systemFontParameters):

• Source/WebCore/platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::controlFont const):

• Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::extractHTTPStatusText):

• Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::ResourceResponse):

• Source/WebCore/rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::updateCachedSystemFontDescription const):

• Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::setFontFromControlSize const):

• Source/WebCore/style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):

• Source/WebCore/svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode const):

• Source/WebCore/svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setCalcMode):
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::sumAtom):

• Source/WebCore/svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::media const):

• Source/WebCore/svg/animation/SVGSMILElement.cpp:

(WebCore::indefiniteAtom):
(WebCore::SVGSMILElement::restart const):
(WebCore::SVGSMILElement::fill const):

• Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp:

(WebCore::SVGAnimationColorFunction::colorFromString):

• Source/WebCore/svg/properties/SVGPropertyAnimator.h:

(WebCore::SVGPropertyAnimator::adjustForInheritance const):

Canonical link: ​https://commits.webkit.org/250068@main

4:54 PM Changeset in webkit [293547] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.resource.hadLoadingError')
​https://bugs.webkit.org/show_bug.cgi?id=239824

Reviewed by Patrick Angle.

• UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.updateStatus):

4:42 PM Changeset in webkit [293546] by Chris Dumez

• 31 edits in trunk/Source/WebCore/html

Devirtualize InputType validation
​https://bugs.webkit.org/show_bug.cgi?id=239809

Reviewed by Geoff Garen and Cameron McCormack.

HTMLInputElement::isValidValue() used to call 4 virtual functions on InputType
and is hot code on Speedometer. To optimize this, HTMLInputElement::isValidValue()
now calls a non-virtual HTMLInputElement::isValidValue() which switches on the
input type and then calls the 4 functions on the actual InputType subclass, so
that the compiler can optimize out the virtual calls out thanks to final
optimization.

This is a 0.5-0.75% progression on Speedometer on Intel. This might be a very
small (~0.2%) progression on Apple Silicon.

• Source/WebCore/html/BaseButtonInputType.h:

(WebCore::BaseButtonInputType::BaseButtonInputType):

• Source/WebCore/html/BaseCheckableInputType.h:

(WebCore::BaseCheckableInputType::BaseCheckableInputType):

• Source/WebCore/html/BaseClickableWithKeyInputType.h:

(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):

• Source/WebCore/html/BaseDateAndTimeInputType.h:
• Source/WebCore/html/BaseTextInputType.h:

(WebCore::BaseTextInputType::BaseTextInputType):

• Source/WebCore/html/ButtonInputType.h:
• Source/WebCore/html/CheckboxInputType.h:
• Source/WebCore/html/ColorInputType.h:
• Source/WebCore/html/DateInputType.h:
• Source/WebCore/html/DateTimeLocalInputType.h:
• Source/WebCore/html/EmailInputType.h:
• Source/WebCore/html/FileInputType.h:
• Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isValidValue const):

• Source/WebCore/html/HiddenInputType.h:
• Source/WebCore/html/ImageInputType.h:
• Source/WebCore/html/InputType.cpp:

(WebCore::validateInputType):
(WebCore::InputType::isValidValue const):

• Source/WebCore/html/InputType.h:

(WebCore::InputType::type const):

• Source/WebCore/html/MonthInputType.h:
• Source/WebCore/html/NumberInputType.h:
• Source/WebCore/html/PasswordInputType.h:
• Source/WebCore/html/RadioInputType.h:
• Source/WebCore/html/RangeInputType.h:
• Source/WebCore/html/ResetInputType.h:
• Source/WebCore/html/SearchInputType.h:
• Source/WebCore/html/SubmitInputType.h:
• Source/WebCore/html/TelephoneInputType.h:
• Source/WebCore/html/TextFieldInputType.h:
• Source/WebCore/html/TextInputType.h:
• Source/WebCore/html/TimeInputType.h:
• Source/WebCore/html/URLInputType.h:
• Source/WebCore/html/WeekInputType.h:

Canonical link: ​https://commits.webkit.org/250065@main

4:42 PM Changeset in webkit [293545] by Jonathan Bedard

• 4 edits in trunk/Tools

[git-webkit] Cleanup PRs on alternate remotes
​https://bugs.webkit.org/show_bug.cgi?id=239814
<rdar://problem/92410887>

Reviewed by Aakash Jain.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:

(Clean.parser): Add --remote argument.
(Clean.cleanup): Allow caller to specify remote.
(Clean.main): Pass remote to cleanup.

Canonical link: ​https://commits.webkit.org/250065@main

4:36 PM Changeset in webkit [293544] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

[PGO] Allow collecting other kinds of pgo profiles.
​https://bugs.webkit.org/show_bug.cgi?id=239776

Reviewed by Saam Barati.

Update the way we collect PGO profiles to use LLVM's file handling, because
it really seems to care about that. This allowws us to try out other kinds
of profile generation, like the IR-based -fcs-profile-generate.

• Source/WTF/wtf/GenerateProfiles.h:

(WTF::registerProfileGenerationCallback):

Canonical link: ​https://commits.webkit.org/250064@main

3:58 PM Changeset in webkit [293543] by Oriol Brufau

• 8 edits
  2 adds in trunk

LayoutTests/imported/w3c:
Fix CSS cascade regarding logical properties
​https://bugs.webkit.org/show_bug.cgi?id=236199

Reviewed by Darin Adler.

Expect animation-004.html to pass.
Add new test logicalprops-with-deferred-writing-mode.html

• web-platform-tests/css/css-logical/animation-004-expected.txt:
• web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode-expected.txt: Added.
• web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html: Added.

Source/WebCore:
Reland "Fix CSS cascade regarding logical properties"
​https://bugs.webkit.org/show_bug.cgi?id=236199

Reviewed by Antti Koivisto.

This is a reland of ​https://commits.webkit.org/r291546, which was
reverted due to a performance regression. This problem should have been
addressed by bug 238260.

Original summary:

The CSS cascade was trying to resolve logical properties into physical
ones too early. This failed if we still didn't know the direction or
writing-mode, e.g. because they were set to a variable or to a CSS-wide
keyword.

This patch keeps logical properties as-is during the cascade. They are
only resolved when finally applied. Also, both logical properties and
their physical equivalents are now set to apply in parse order, since
'height: 0px; block-size: 1px' and 'block-size: 1px; height: 0px' can be
different, the order matters.

Tests: imported/w3c/web-platform-tests/css/css-logical/animation-004.html

imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html

• css/makeprop.pl:

(addProperty):
(sortByDescendingPriorityAndName):
Defer properties that belong to a logical property group.

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):
Logical properties no longer need special handling for variables.

• style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::PropertyCascade):
Remove members no longer needed.

(WebCore::Style::PropertyCascade::set):
This method is no longer used for properties in a logical property
group. Remove dead code and add assert.

(WebCore::Style::PropertyCascade::setDeferred):
Remove assert, logical properties are now handled here.

(WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const):
Take into account that properties in a logical property group are now
deferred.

(WebCore::Style::PropertyCascade::resolveDirectionAndWritingMode const): Deleted.
(WebCore::Style::PropertyCascade::direction const): Deleted.
Remove broken logic.

• style/PropertyCascade.h:

Remove members, struct and methods no longer needed.
Update method signatures.

• style/StyleBuilder.cpp:

(WebCore::Style::Builder::Builder):
Remove argument no longer needed.

(WebCore::Style::Builder::applyProperty):
Resolve logical properties using the direction and writing-mode from the
style.

(WebCore::Style::directionFromStyle): Deleted.
Remove function no longer needed.

3:46 PM Changeset in webkit [293542] by Alan Coon

• 1 copy in tags/WebKit-7614.1.11

Tag WebKit-7614.1.11.

3:38 PM Changeset in webkit [293541] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
​https://bugs.webkit.org/show_bug.cgi?id=239586

Patch by Dan Glastonbury <​djg@apple.com> on 2022-04-27
Reviewed by Devin Rousso.

• Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.constantNameForParameter):
Arrays are also objects, so checking for typeof x == "object" is
not enough to distinguish arrays from dictionaries. Since the if
above the failing check was handling arrays, turn "object" check
into an else if handles arrays and dictionaries correctly.

Canonical link: ​https://commits.webkit.org/250062@main

3:31 PM Changeset in webkit [293540] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.0.5

Tag WebKit-7613.2.7.0.5.

3:29 PM Changeset in webkit [293539] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.1.6

Tag WebKit-7613.2.7.1.6.

3:26 PM Changeset in webkit [293538] by Alan Coon

• 2 edits in branches/safari-613.2.7.1-branch/Source/WebKit

Cherry-pick r293481. rdar://problem/92336270

Adjust what we consider to be private relayed
​https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.

If a request is not eligible for private relay, then do not consider it having been private relayed.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:25 PM Changeset in webkit [293537] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebKit

Cherry-pick r293481. rdar://problem/92336270

Adjust what we consider to be private relayed
​https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.

If a request is not eligible for private relay, then do not consider it having been private relayed.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:45 PM Changeset in webkit [293536] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.3.4

Tag WebKit-7613.2.7.3.4.

2:44 PM Changeset in webkit [293535] by Alan Coon

• 9 edits in branches/safari-613.2.7.3-branch/Source

Versioning.

WebKit-7613.2.7.3.4

2:30 PM Changeset in webkit [293534] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.2.4

Tag WebKit-7613.2.7.2.4.

2:29 PM Changeset in webkit [293533] by Alan Coon

• 9 edits in branches/safari-613.2.7.2-branch/Source

Versioning.

WebKit-7613.2.7.2.4

1:41 PM Changeset in webkit [293532] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239822

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250061@main

1:20 PM Changeset in webkit [293531] by commit-queue@webkit.org

• 11 edits in trunk/Source/WebCore

[GStreamer] Track handling fixes
​https://bugs.webkit.org/show_bug.cgi?id=239702

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-27
Reviewed by Xabier Rodriguez-Calvar.

When the player is using playbin3 the audio/video/text tracks are associated to the
corresponding GstStream, itself part of a single GstStreamCollection. There is no need to
use a GRefPtr for GstStream in this case because those streams are not meant to be modified
and they remain valid as long as the parent collection is alive. So the player now keeps
track of the current stream collection and the private tracks handle GstStream pointers.

The stream collection handling was refactored, removing redundant logging, making use of
ScopeExit and removing the special case for text tracks creation.

This patch also changes the internal storage of tracks from HashMap<AtomString,RePtr<T>> to
HashMap<AtomString,Ref<T>>, bringing us a bit closer to the AVF implementation.

• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::kind const):
(WebCore::AudioTrackPrivateGStreamer::disconnect):

• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):

• platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

(WebCore::InbandTextTrackPrivateGStreamer::create):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack):
(WebCore::MediaPlayerPrivateGStreamer::updateEnabledVideoTrack):
(WebCore::MediaPlayerPrivateGStreamer::updateEnabledAudioTrack):
(WebCore::MediaPlayerPrivateGStreamer::playbin3SendSelectStreamsIfAppropriate):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer):
(WebCore::TrackPrivateBaseGStreamer::disconnect):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:

(WebCore::TrackPrivateBaseGStreamer::stream const):
(WebCore::TrackPrivateBaseGStreamer::stream): Deleted.

• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::kind const):
(WebCore::VideoTrackPrivateGStreamer::disconnect):

• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:

Canonical link: ​https://commits.webkit.org/250060@main

1:18 PM Changeset in webkit [293530] by eric.carlson@apple.com

• 10 edits in trunk

[iOS] unable to start playing audio when device is locked
​https://bugs.webkit.org/show_bug.cgi?id=239812
<rdar://90642648>

Reviewed by Jer Noble.

Source/WebCore:

Updated media/audio-session-category.html.

• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::updateSessionState): Choose the appropriate
route sharing policy after choosing the audio session category because
setting MediaPlayback+Default makes a process ineligible for NowPlaying, and starting
playback in the background will be blocked.

• platform/audio/mac/AudioSessionMac.h:
• platform/audio/mac/AudioSessionMac.mm:

(WebCore::AudioSessionMac::setCategory): Updated for testing.

• testing/Internals.cpp:

(WebCore::Internals::routeSharingPolicy const): Added accessor for testing.

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/audio-session-category-expected.txt:
• media/audio-session-category.html:

12:50 PM Changeset in webkit [293529] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ] fast/css/identical-logical-height-decl.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239818

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250058@main

12:13 PM Changeset in webkit [293528] by ntim@apple.com

• 2 edits in trunk/LayoutTests/imported/w3c

Rebaseline imported/w3c/web-platform-tests/css/css-text/inheritance.html after r293521
​https://bugs.webkit.org/show_bug.cgi?id=166782

Unreviewed test gardening.

• web-platform-tests/css/css-text/inheritance-expected.txt:

12:09 PM Changeset in webkit [293527] by Jonathan Bedard

• 2 edits in trunk/Tools

[ews-build.webkit.org] Support alternative remotes (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>

Unreviewed follow-up fix.

• Tools/CISupport/ews-build/events.py:

(GitHubEventHandlerNoEdits.extractProperties):

12:07 PM Changeset in webkit [293526] by Alan Coon

• 9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.5

12:06 PM Changeset in webkit [293525] by Alan Coon

• 9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.6

12:04 PM Changeset in webkit [293524] by ntim@apple.com

• 21 edits in trunk

Make -webkit-transform-style an alias of transform-style
​https://bugs.webkit.org/show_bug.cgi?id=239808

Reviewed by Antti Koivisto.

Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
unnecessary code as well given the FIXME was never addressed.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• css/CSSProperties.json:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• rendering/style/WillChangeData.cpp:

(WebCore::WillChangeData::propertyCreatesStackingContext):

LayoutTests:

• fast/css/getComputedStyle/computed-style-expected.txt:
• fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• svg/css/getComputedStyle-basic-expected.txt:

12:03 PM Changeset in webkit [293523] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=237181

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-27

• platform/gtk/TestExpectations: Remove skip now that the test doesn't cause problems.

12:01 PM Changeset in webkit [293522] by Simon Fraser

• 4 edits in trunk/Source

Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer
​https://bugs.webkit.org/show_bug.cgi?id=239799

Reviewed by Said Abou-Hallawa.

After r280652, destroying a RemoteImageBufferProxy would always send a flush to the GPU
process, even if there had be no drawing since the previous flush.

Fix to only send a flush and wait when necessary.

Roughly 8% progression on MotionMark Images subtest on iPhone.

Source/WebCore:

• platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::flushDrawingContextAsync):

Source/WebKit:

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

(WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout):

11:56 AM Changeset in webkit [293521] by ntim@apple.com

• 24 edits in trunk

[css-text] Make word-wrap CSS property an alias of overflow-wrap
​https://bugs.webkit.org/show_bug.cgi?id=166782

Reviewed by Antti Koivisto.

This follows the spec, and fixes cascade issues when applying both properties (see bug 239579).

Relevant WPT expectations updated to pass.

• LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-alias-expected.txt:
• Source/WebCore/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• Source/WebCore/css/CSSProperties.json:
• Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToBodyElement const):

• Source/WebCore/html/HTMLElement.cpp:

(WebCore::HTMLElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::collectPresentationalHintsForAttribute):

• LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
• LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
• LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
• LayoutTests/svg/css/getComputedStyle-basic-expected.txt:* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Canonical link: ​https://commits.webkit.org/250052@main

11:37 AM Changeset in webkit [293520] by Angelos Oikonomopoulos

• 2 edits in trunk/JSTests

Unskip flaky test on mips
​https://bugs.webkit.org/show_bug.cgi?id=239342

Unreviewed gardening.

Re-enable test. It should still be flaky, so can use it to test
the code reporting the flakiness to resultsdb.

• stress/new-largeish-contiguous-array-with-size.js:

10:36 AM Changeset in webkit [293519] by Aditya Keerthi

• 4 edits in trunk

[iOS] Focus changes unexpectedly when scrolling to a found text range
​https://bugs.webkit.org/show_bug.cgi?id=239793
rdar://90996437

Reviewed by Wenson Hsieh.

Source/WebKit:

• WebProcess/WebPage/WebFoundTextRangeController.cpp:

(WebKit::WebFoundTextRangeController::scrollTextRangeToVisible):

Specify DoNotSetFocus in the TemporarySelectionOptions to avoid
unnecessary focus changes when scrolling to a found text range.

Focus changes can cause the web view to regain first responder status
while searching for text, which will dismiss the find panel and end
the search session.

Tools:

Add an API test to ensure that scrolling to a found range does not
change focus.

• TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

(TEST):

10:30 AM Changeset in webkit [293518] by Brandon

• 7 edits in trunk/Source/bmalloc

[libpas] Implement secure random numbers
​https://bugs.webkit.org/show_bug.cgi?id=239735

Reviewed by Yusuke Suzuki.

We currently have a cheesy random and secure random, which use the same implementation for generating
random numbers. (We are going to ignore the mock testing code here). This patch introduces a fast random and
secure random. The fast random maintains the same properties as the previous implementation, while secure random
will use the cryptographically secure arc4random_uniform to give better randomness. arc4random() can be quite an
expensive operation and based on discussing with Yusuke he found heavy performance penalties when using this in
JSC. Our secure random shall only be used in cases where true randomness is needed. We have 2 spots where we
currently use secure random; we shall just migrate those over to using fast random.

• Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c:

(pas_baseline_allocator_table_get_random_index):

• Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c:

(pas_dynamic_primitive_heap_map_find_slow):

• Source/bmalloc/libpas/src/libpas/pas_random.c:
• Source/bmalloc/libpas/src/libpas/pas_random.h:

(pas_get_random):

• Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c:

(find_first_eligible_consider_view):

• Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp:

(std::testTwoBaselinesEvictions):

Canonical link: ​https://commits.webkit.org/250049@main

10:26 AM Changeset in webkit [293517] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests
​https://bugs.webkit.org/show_bug.cgi?id=239790

Unreviewed test gardening.

• LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250048@main

10:22 AM Changeset in webkit [293516] by youenn@apple.com

• 4 edits in trunk

[Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout
​https://bugs.webkit.org/show_bug.cgi?id=229588
<rdar://problem/82408723>

Reviewed by Chris Dumez.

Source/WebCore:

I removed the user gesture in fetch by mistake so let's add it back.
Test is no longer crashing on bots and is timing out on debug bots because it is a slow test.
Mark test as slow and remove flakiness expectations.

Covered by unflaked test.

• Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:

(WebCore::doFetch):

LayoutTests:

• platform/mac/TestExpectations:

10:15 AM Changeset in webkit [293515] by Jonathan Bedard

• 4 edits in trunk/Tools

test-webkitpy TestInstallGitLFS fails
​https://bugs.webkit.org/show_bug.cgi?id=239788
<rdar://problem/92363359>

Reviewed by Michael Catanzaro.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py:

(TestInstallGitLFS.test_install): Specify mock system and machine.
(TestInstallGitLFS.test_configure): Ditto.
(TestInstallGitLFS.test_no_op): Ditto.
(TestInstallGitLFS.test_no_repo): Ditto.

Canonical link: ​https://commits.webkit.org/250046@main

10:12 AM Changeset in webkit [293514] by Jonathan Bedard

• 6 edits in trunk/Tools

[commits.webkit.org] Change branch forwarding behavior
​https://bugs.webkit.org/show_bug.cgi?id=239136
<rdar://problem/91314217>

Reviewed by Dewei Zhu.

• Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
• Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
• Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:

(Checkout.Encoder.default): Encode forwarding list.
(Checkout.init): Add forwarding argument.
(Checkout.push_update): Add dest_branch argument.
(Checkout.forward_update): Trigger push_update based on forwarding arguments.
(Checkout.update_all): Use forward_update instead of pushing to every branch.

• Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:

(HookProcessor.process_worker_hook): Extract remote from incoming data, invoke forward_update.

• Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:

(CheckoutUnittest.test_json):

Canonical link: ​https://commits.webkit.org/250045@main

10:06 AM Changeset in webkit [293513] by commit-queue@webkit.org

• 387 edits
  4 copies
  23 adds
  7 deletes in trunk/Source/ThirdParty/ANGLE

Update ANGLE to 2022-04-26 (7ca11287a056d4150cba96c9c9b964153ad539cb)
​https://bugs.webkit.org/show_bug.cgi?id=239114
<rdar://problem/91944443>

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-27
Reviewed by Kenneth Russell.

Contains upstream commits:
git log --oneline fe28a4295af087ee82b8f629b67176b95019af6d..7ca11287a056d4150cba96c9c9b964153ad539cb --pretty="%h %s"
7ca11287a Roll SwiftShader from f13461dbb23c to 5f5faa3a2aad (1 revision)
9d6b3a7ee Vulkan: Move overlay draw after swap's implicit flush
4aae5815f Vulkan: Overlay widgets for submission statistics
02b968481 Vulkan: Add support for GL_QCOM_shading_rate
69705e5c0 Add -Wno-deprecated-non-prototype
c0ac374f7 Replace adb exec-out cat with pull to temp location.
018118394 Refactor platform code
ea76cb0f5 Vulkan: Add entry points for GL_QCOM_shading_rate
62ca64492 Reland "Fix BlendStateExt::mMaxColorMask initialization"
d1788614c Use adb instead of catapult to run perf tests on Android.
e0183a421 Revert "Mark contexts as shared when importing EGL images."
400d9fe43 Rename feature files to *_autogen.h
0f3710d99 Generalize GetDisplayFromNativeDisplay
a8cac0058 Remove observer when element array buffer is detached
2d6e42fcc Update Program Pipeline TODOs.
853b6edf9 Roll SwiftShader from 71f3089b729c to f13461dbb23c (1 revision)
c95bd5e7e Roll vulkan-deps from 01fd48aca427 to f685346e2e51 (6 revisions)
2db718edf Vulkan: Skip empty submissions
b07a11569 Split Context ResourceUseList to RP Commandbuffers
37c53684e Split Context ResourceUseList to RP Commandbuffers
158951600 Avoid leaking gl::Framebuffers in gl::Context
f565ea4d6 Roll vulkan-deps from 158676f39f3b to 01fd48aca427 (13 revisions)
ad93a708a Further expand Vulkan end2end_test skip
e6fc5e62c Use _FindAdb (cached) directly instead of Adb wrapper.
4ac3ec13e Switch py_utils import to pathlib.
64fa5edaa Suppress VVL UNASSIGNED-BestPractices-SemaphoreCount
e1fdef909 Revert "Vulkan: Cache ImageView serials on texture changes."
3b38b3790 Vulkan: Add feature avoid HOST_VISIBLE and DEVICE_LOCAL combination
d988db39b Fall back to adb on PATH if platform-tools not present.
2dd13ebbd Track Surface color & depth/stencil init separately.
8f56edfdd Roll Chromium from 408793418c48 to 192db13f8509 (548 revisions)
0690f5d34 Revert "CGL, MTL: pbuffer for IOSurface fails for some formats"
0439d9cd2 Vulkan: Update glslang wrapper TODO.
768c7d47e Revert "Re-land: "Vulkan: Support Wayland""
47b9a97b6 Expand Vulkan end2end_test skip.
dc1b7029e Disable MSAN in the Vulkan loader
7a32cf547 Android: Add build to blueprint.
13784ebe3 Vulkan: use "undefined" for layerProvokingVertex
04c6f9375 Roll SwiftShader from ea5f37f39193 to 71f3089b729c (5 revisions)
96239a340 Roll Chromium from a434f1de2483 to 408793418c48 (456 revisions)
1d67951e0 Avoid IOError in capture_replay_tests.py
dd493b5ca EGL: allow eglQueryString(EGL_NO_DISPLAY, EGL_VERSION)
6cbedc984 Add a test for backwards mip generation with draw
d3dbaa8df Vulkan: Remove BufferVk::mHasBeenReferencedByGPU
5097d10c1 D3D: unsuppress some now-passing tests.
cb1ee485f Vulkan: Add perf test for MSAA swapchain resolve
c66de085a Vulkan: Fix surface invalidate w.r.t shared present mode
19c6a8566 Tests: Add Free Fire Max trace
7d229d047 Vulkan: Cache ImageView serials on texture changes.
7c091cb35 Use adb directly (instead of catapult) in gold tests.
4efc4ee68 Fix validate state cache after XFB buffer deleted.
3f800e5c8 Metal:Clear Backbuffer when Robust Resource Init enabled
5b84ad797 CGL, MTL: pbuffer for IOSurface fails for some formats
ff8a9f6a1 Vulkan: Renaming "ShaderBuffers" to "ShaderResources".
f6cdd02fb Re-land: "Vulkan: Support Wayland"
5610ab642 Fix ANGLEGetDisplayPlatform after method deprecation
6199e905a Switch to using build/android:build_java
b2a1f0d28 Track total vs per-frame descriptor set counters.
37cdf93d0 Vulkan: Acquire a new buffer even when size is unchanged
349612591 Roll vulkan-deps from 00e1ddd4230c to 158676f39f3b (8 revisions)
f4a550bff Roll SwiftShader from 103a69bd6c82 to ea5f37f39193 (3 revisions)
dde8b6629 Roll Chromium from e1b5a693bbfe to a434f1de2483 (504 revisions)
fcec69045 Generate feature variable names from display names
f4fc8e168 Revert "Fix BlendStateExt::mMaxColorMask initialization"
5014ce664 Vulkan: Add orphaned list for non-empty BufferBlocks.
55c21842b Vulkan: Use flat array lookups for shader variables.
6e130d2b7 D3D: fix SSBOs used in vertex shaders.
50d008a7e Fix BlendStateExt::mMaxColorMask initialization
cfc92ebf1 Vulkan: Encapsulate ShareGroup::mContexts
9907f22d0 gold tests: Add command-line arg for gold instance.
e18240d13 Mark contexts as shared when importing EGL images.
bddb944bc Vulkan: Prep variable info map to remove hashing.
242f0d81f Revert "Infra: Enable Skia Gold tests on Pixel 6"
acdec48ad Tests: Add Monster Strike trace
e77be6632 Use ProgramExecutable directly in GlslangWrapper.
c82513afb Add FastMap class.
4cd15cb39 Skip a Vulkan test due to a threading flake.
64fa1e80f Revert "vulkan: Call glFinish in VulkanHelper destructor"
9cc459c98 Add check for GL_ANDROID_extension_pack_es31a support
dbe5b7554 Roll vulkan-deps from 1a408eb154d7 to 00e1ddd4230c (8 revisions)
834ca6869 Roll Chromium from e9b55eb91cb1 to e1b5a693bbfe (303 revisions)
197100880 Vulkan: Call into vulkan directly for big size allocation.
bdb52cb8b Vulkan: Remove retains before acquireBufferHelper
866210add Metal: Fix bytesPerRow computation for compressed formats
33c8a2d0d Roll vulkan-deps from 7f875b15c6a3 to 1a408eb154d7 (4 revisions)
d903818a8 Roll Chromium from 573f2ec89cb9 to e9b55eb91cb1 (411 revisions)
3636d129e Infra: Enable Skia Gold tests on Pixel 6
d18e9e84a Roll vulkan-deps from c9be322642fb to 7f875b15c6a3 (16 revisions)
dfde9f402 Roll SwiftShader from 1d450ae99a0f to 103a69bd6c82 (3 revisions)
ff084b28d Roll Chromium from e6765ea8299f to 573f2ec89cb9 (443 revisions)
5f7db7755 Vulkan: updateUniforms when commandbuffer is valid
3587e217d Remove copyResourceUseList from ShareGroupVk
956fb16ec Remove Win NVIDIA dEQP suppressions
5e48e5b8d Roll VK-GL-CTS from 2748d45ebbb4 to a22069b4e3b7 (10 revisions)
aefb2a99e vulkan: Call glFinish in VulkanHelper destructor
4a33204ce Roll VK-GL-CTS from 20a474e64382 to 2748d45ebbb4 (1 revision)
039660a07 Translator: Drop const from opaque parameter types
0360248c6 Suppress flaky end2end failures on Mac/NVIDIA/OpenGL
03b3bc3f6 Tests: Add Special Forces Group 2 trace.
c3f159629 Fix OOB problem in validationES.{h,cpp}
fef34a6ef doc/DevSetup: Add Visual Studio Installer hint.
27b01dd4a Roll SwiftShader from 011bba68c819 to 1d450ae99a0f (4 revisions)
fcd6e2605 GN: Fix util target when X11 not enabled
b5d34da08 Add src/tests/py_utils/ for utils, angle_path_util for imports.
7e61e176e Roll Chromium from 61150a1970a3 to e6765ea8299f (515 revisions)
871878352 Metal: For readPixels copy IOSurface to non-IOSurface texture
52237c322 Suppress CopyTextureTest.CopyToMipmap on Intel Mac OpenGL
d2fd28cae Vulkan: Relax advanced blend on VK extension requirement
c5271e8e6 Vulkan: Emulate GL_KHR_blend_equation_advanced
01c0bc215 Revert "Vulkan: Support Wayland"
af51a287a Vulkan: Enum class instead of bool didRespecify
e9d695b5d Roll vulkan-deps from 345e2a278e69 to c9be322642fb (74 revisions)
f00d827e0 Roll SwiftShader from 620982155d55 to 011bba68c819 (4 revisions)
4b8e5db62 Roll Chromium from f961a0d4732b to 61150a1970a3 (431 revisions)
985d42934 Metal:Speed up BGRA8 to RGBA8 copy for readPixels
8074061d2 Remove feature override platform methods
a0b5299b6 Vulkan: Fix resolve with subpass into smaller framebuffer
6768aff71 Fix Geometry Shader Conformance Test Failure on Pixel6
445bf9bdf Use the real max vertex attrib index instead of MAX_VERTEX_ATTRIBS
d4cbd9bfe vulkan: Mark external memory textures as preinitialized
291be0b7a Suppress multisample_interpolation dEQP failures on Pixel 6 Vulkan
9442b7a83 D3D: Remove a pass-through function.
957f82974 Vulkan: Change ContextVk to Context for BufferPool APIs
510351f20 Vulkan: Support Wayland
ea86cfd2e Roll chromium_revision f89964bd5b..f961a0d473 (990903:991486)
fb093278c egl_angle_ext: add more missing extension enum values
93ccde91b Update ANGLE's docs regarding Windows 10 SDK version to use
19582d120 gl_angle_ext.xml: treat glProvokingVertexANGLE as alias
fec9c918e Roll SwiftShader from d15c42482560 to 620982155d55 (2 revisions)
aed5951e3 Reland "Vulkan: Fix texture-after-framebuffer sync issues"
797e627e6 Autogenerate list of features as enum
eeb396535 Autogenerate features
9237272f9 Metal:remove TextureMtl::mIsPow2
e08476cf5 Metal: Avoid leaking MTLDevice lists in DisplayMtl
1b2adb402 Metal: Avoid leaking MTLFunctionConstantValues in ProgramMtl
a201bbc98 egl_angle_ext.xml: add missing enums and typedefs
5c85fd4e1 Add error check on resuming XFB with deleted buffer.
a947c5f56 Skip BlitFramebufferTest.ScissoredMultisampleStencil
fb91e27cf add GL_ANGLE_robust_resource_initialization extension to xml
6803a2d01 D3D11: implement SSBOs in pixel and vertex shaders.
c458b5add Fix CheckedNumeric using the wrong type.
04782d86b Validate vertex attrib index against caps.maxVertexAttributes
767b65939 Roll VK-GL-CTS from 6f8a7182bd26 to 20a474e64382 (14 revisions)
b120ab6d4 Roll Chromium from a01c0c749d0a to f89964bd5b42 (617 revisions)
1b94c5856 Revert "Vulkan: Switch loader to new driver files env var."
727cd8ef6 Fix pointer sscanf for ChromeOS
92e99653d Fix crashes in gl::VertexArray::detachBuffer() and onDestory()
4b381f419 Vulkan: Fix descriptorSet perf counter values.
09a24f3d5 Roll SwiftShader from d09282e5c609 to d15c42482560 (2 revisions)
5a16a1f99 Roll Chromium from 64472fba3112 to a01c0c749d0a (448 revisions)
3cea7fcc0 Split Context ResourceUseList to RP Commandbuffers
ac1301069 Metal: Remove Unused IOSurface code
1f6123d55 Vulkan: Switch loader to new driver files env var.
a16491d98 Vulkan: Fix invalidation of non-existing aspects
d6ff967e3 Roll SwiftShader from d3cc7d7ac0c3 to d09282e5c609 (6 revisions)
b7e8ab48d Roll Chromium from 6f6eb80eab19 to 64472fba3112 (509 revisions)
ba04fcfd1 Support ANGLE_PREFERRED_DEVICE on CGL
23558369a Update perf tests arguments.
f36dde314 D3D: remove NV GetDimensions() workaround for image load/store.
7a9856f67 Report durations of all flaky retries in JSON test output
9d486a85e GL: Unbind textures from FBO after calls to frameBufferTexture2D
a1c9ba709 Update validation of glFramebufferTextureLayer for cube maps
152616eed Tests: Add Aztec Ruins High trace
06c201f84 Roll SwiftShader from 1b159f6cdecb to d3cc7d7ac0c3 (1 revision)
b4eaa3a29 Roll Chromium from 3c01a5c3bc2f to 6f6eb80eab19 (52 revisions)
ff9bd35d9 Roll Chromium from c32f123be7eb to 3c01a5c3bc2f (107 revisions)
bac8915c5 Roll Chromium from f39b4372b8a8 to c32f123be7eb (777 revisions)
366f60116 Roll vulkan-deps from 6d732e01d9ea to 345e2a278e69 (3 revisions)
607d398e0 Vulkan: Optimize resolve of multisample swapchains
0ffff9eda Vulkan: Perf counters test for glInvalidateSubFramebuffer
ca3b7d35f Vulkan: Roll volk
3258477a0 Skip car_chase on all Intel Windows platforms
78f5ef92a Roll SwiftShader from 7d100c556081 to 1b159f6cdecb (2 revisions)
7b0f63182 Vulkan: Wayland include directories
8b84cf15e Tests: Add GFXBench Car Chase trace
256bbb8ac Vulkan: Don't invalidate resolve attachment except with MSRTT
b3fff1aaf retrace_restricted_traces: Check for json file.
a11bf0edc Fix Max Atomic Counter Conformance Test Failure on Pixel6
a555be4aa Tests: Add Scary Teacher 3D trace
e933df513 retrace_restricted_traces: Remove unused code.
808f754c4 Capture/Replay: Use glFramebufferTexture2D for cubes
1a3411c7d Set SKIPPED status on skipped tests, rely on it in Gold tests.
34471fed1 Vulkan: Skip failing intel blend test.
4f7efb51b Remove swiftshader_spirv_tools_dir
2cb264b5a Roll SwiftShader from a190ceed7293 to 7d100c556081 (9 revisions)
83d3a98cd Remove commented out mSkipTest.
74eac5e5a Roll VK-GL-CTS from fbc38865227d to 6f8a7182bd26 (14 revisions)
e7d44541e Use GTEST_SKIP to set gTest status of skipped tests to SKIPPED.
b33767ec9 Revert "Vulkan: Fix texture-after-framebuffer sync issues"
bd7915fd0 Use provided format as intended format for EGLImage from VkImage
4655ef15d Roll SwiftShader from 649d6e46aeae to a190ceed7293 (1 revision)
4b2602259 Roll Chromium from 804d5a91d49d to f39b4372b8a8 (124 revisions)
4b232a9a8 Roll Chromium from 384f873e0970 to 804d5a91d49d (4365 revisions)
f41303cda Skip end2end tests timing out on TSAN and ASAN
535cd538f Vulkan: Fix texture-after-framebuffer sync issues
4615a0355 Skip failing tests on Pixel 6
6b94a71ce Vulkan: Lift SwS suppressions.
ba0eba20b Remove the TODOs regarding multisample buffer age
cd9e887ae Vulkan: Add multisample buffer age tests
8f9043636 Vulkan: Move memory allocation initialization code into function
b169f6f94 Vulkan: Fix no location decoration vs framebuffer fetch
5cffbe965 Android: Track peak GPU memory in restricted_trace_perf
cc19587e2 infra: Use logarithmic batching in LUCI config.
e10803f76 Compiler: Allow deferred array sizing in geometry shaders
dd86dd15b Cache outer array offset in linked uniforms.
0754b1f72 Roll SwiftShader from bc5bec05c369 to 649d6e46aeae (3 revisions)
57a081c76 Roll vulkan-deps from e37ba68c0fde to 6d732e01d9ea (4 revisions)
d3492eef5 Vulkan: Handle border color for stencil component

9:32 AM Changeset in webkit [293512] by commit-queue@webkit.org

• 2 edits in trunk/Tools

test-webkitperl outputs git hints during the test
​https://bugs.webkit.org/show_bug.cgi?id=239759

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-27
Reviewed by Alexey Proskuryakov.

Avoid git hints about initial branch name during a test that initializes a git repository.
The output disrupts the test system result reporting output.

Specify the quiet operation. --initial-branch cannot be specified
since the Perl tests run on older git.

• Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl:

9:30 AM Changeset in webkit [293511] by Ziran Sun

• 17 edits in trunk

[css-ui] Remove some unimplemented -webkit-appearance keywords
​https://bugs.webkit.org/show_bug.cgi?id=238930

Reviewed by Aditya Keerthi.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Source/WebCore:

Remove the following unimplmented --webkit-appearance keyworkds:
button-bevel
media-controls-background
media-controls-fullscreen-background
media-current-time-display
media-enter-fullscreen-button
media-exit-fullscreen-button
media-mute-button
media-overlay-play-button
media-return-to-realtime-button
media-rewind-button
media-seek-back-button
media-seek-forward-button
media-time-remaining-display
media-toggle-closed-captions-button
media-volume-slider-container
menulist-textfield
menulist-text

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• platform/ThemeTypes.cpp:

(WebCore::operator<<):

• platform/ThemeTypes.h:
• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaPlayButton):
(WebCore::RenderTheme::paintMediaMuteButton):
(WebCore::RenderTheme::paintMediaSliderThumb):
(WebCore::RenderTheme::paintMediaVolumeSliderThumb):
(WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
(WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
(WebCore::RenderTheme::paintMediaRewindButton): Deleted.
(WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
(WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
(WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
(WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.

Source/WebInspectorUI:

We might need to update the changes on UserInterface/External/CodeMirror/css.js since
PR ​https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.

• UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
• UserInterface/External/CSSDocumentation/CSSDocumentation.js:

LayoutTests:

• imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
• platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

8:49 AM Changeset in webkit [293510] by dbezhetskov

• 19 edits
  1 add in trunk

[WASM-GC] Introduce rtt types
​https://bugs.webkit.org/show_bug.cgi?id=239493

Reviewed by Keith Miller.

JSTests:

Added basic tests for manipulation of rtt types.

• wasm/gc/rtt.js: Added.

(module):
(testRttTypes):
(testRttCanon):

• wasm/wasm.json:

Source/JavaScriptCore:

Add a basic support through runtime call for rtt.canon and rtt types.
It is a prototype implementation of rtt types needed to move forward
with wasm gc proposal (​https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md).
For example, we don't need to use rtt values for struct.new,
but we do need them for the future js api.
So, rtt.canon returns jsNull for now, but we can replace it with
properly defined values when the spec will be ready.

• bytecode/BytecodeList.rb:
• llint/WebAssembly.asm:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addRttCanon):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addRttCanon):

• wasm/WasmCallingConvention.h:

(JSC::Wasm::WasmCallingConvention::marshallLocation const):

• wasm/WasmFormat.h:

(JSC::Wasm::isValueType):
(JSC::Wasm::isValidHeapTypeKind):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addRttCanon):

• wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

• wasm/WasmOperations.h:
• wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::parseValueType):

• wasm/WasmSlowPaths.cpp:

(JSC::LLInt::WASM_SLOW_PATH_DECL):

• wasm/WasmSlowPaths.h:
• wasm/generateWasmOpsHeader.py:
• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

• wasm/wasm.json:

8:49 AM Changeset in webkit [293509] by pvollan@apple.com

• 13 edits in trunk/Source/WebKit

[macOS] The function getpwnam can sometimes fail
​https://bugs.webkit.org/show_bug.cgi?id=239513
<rdar://89758690>

Reviewed by Darin Adler.

The system function getpwnam is caching the results from the first invocation, and will return the cached
values after the first call. It may happen that opendirectoryd will invalidate the cached values by
posting notifications. If that happens, getpwnam will then fail, since there are no cached values and
the WebContent process' sandbox is blocking access to opendirectoryd. This patch addresses this issue
by observing these notifications in the UI process, and recreating the cached values for getpwnam, by
calling the function in the WebContent process while holding a temporary sandbox extenstion to
opendirectoryd.

• GPUProcess/GPUProcess.h:
• GPUProcess/GPUProcess.messages.in:
• GPUProcess/mac/GPUProcessMac.mm:

(WebKit::GPUProcess::openDirectoryCacheInvalidated):

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• Shared/AuxiliaryProcess.h:
• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::getHomeDirectory):
(WebKit::populateSandboxInitializationParameters):
(WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

• UIProcess/WebProcessPool.h:
• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::openDirectoryCacheInvalidated):

• WebProcess/com.apple.WebProcess.sb.in:

7:11 AM Changeset in webkit [293508] by commit-queue@webkit.org

• 2 edits in trunk

[GTK] Add user agent quirk for "ClicSalud+" (Andalusian Health Service, Spain)
​https://bugs.webkit.org/show_bug.cgi?id=239763

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-27
Reviewed by Adrian Perez de Castro.

• Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

• Source/WebCore/platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresMacintoshPlatform):

Canonical link: ​https://commits.webkit.org/250039@main

6:16 AM Changeset in webkit [293507] by commit-queue@webkit.org

• 6 edits in trunk

[GLib] Make WebKitSettings XSS auditor functions no-op
​https://bugs.webkit.org/show_bug.cgi?id=239651

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-27
Reviewed by Adrian Perez de Castro.

Let's deprecate these functions.

Also, do not print warnings because they are called during init by the property setters.

• Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):

• Source/WebKit/UIProcess/API/gtk/WebKitSettings.h:
• Source/WebKit/UIProcess/API/wpe/WebKitSettings.h:

Canonical link: ​https://commits.webkit.org/250038@main

6:12 AM Changeset in webkit [293506] by youenn@apple.com

• 20 edits in trunk

service worker update should refresh imported scripts in addition to the main script
​https://bugs.webkit.org/show_bug.cgi?id=239657

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/credentials.https-expected.txt:

Source/WebCore:

After checking main script, if matching, we refreach each identified imported script.
If matching, we reuse the same worker, otherwise we install a new one.
We reuse the soft update loader to fetch scripts in case of soft update.
Otherwise, we load scripts through the job's client.

Covered by rebased test.

• workers/service/SWClientConnection.cpp:
• workers/service/SWClientConnection.h:
• workers/service/ServiceWorkerContainer.cpp:
• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:
• workers/service/ServiceWorkerJob.h:
• workers/service/ServiceWorkerJobClient.h:
• workers/service/server/SWServer.cpp:
• workers/service/server/SWServer.h:
• workers/service/server/SWServerJobQueue.cpp:
• workers/service/server/SWServerJobQueue.h:
• workers/service/server/SWServerWorker.cpp:
• workers/service/server/SWServerWorker.h:

Source/WebKit:

• NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:
• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
• NetworkProcess/ServiceWorker/WebSWServerConnection.h:
• WebProcess/Storage/WebSWClientConnection.messages.in:

4:59 AM Changeset in webkit [293505] by Diego Pino Garcia

• 2 edits in trunk/Source/WTF

[GCC] GCC9.3 defines 'remove_cvref_t' but not 'cpp_lib_remove_cvref'
​https://bugs.webkit.org/show_bug.cgi?id=239805

Reviewed by Žan Doberšek.

GCC9.3 defines 'remove_cvref_t' but not 'cpp_lib_remove_cvref'. The
latter was introduced in GCC9.4:

​https://github.com/gcc-mirror/gcc/blob/releases/gcc-9.4.0/libstdc%2B%2B-v3/include/std/type_traits#L3024

The flag 'cpp_lib_remove_cvref' is used to check whether 'remove_cvref_t'
is defined, but it's not posible to rely on it for GCC9.3 as explained on the
paragraph above.

Instead we check whether cplusplus is <= 201703L since the GCC commit
that defined 'remove_cvref_t' does it if cplusplus > 201703L. See:

​https://github.com/gcc-mirror/gcc/commit/6791489ee5214b0181aa22adc250cbbde1897a5c

• wtf/StdLibExtras.h:

4:14 AM Changeset in webkit [293504] by commit-queue@webkit.org

• 22 edits in trunk/Source/WebCore

[LBSE] Fix origin of transformations in SVG
​https://bugs.webkit.org/show_bug.cgi?id=239717

Patch by Nikolas Zimmermann <​nzimmermann@igalia.com> on 2022-04-27
Reviewed by Rob Buis.

Fix the majority of SVG transform issues in LBSE. webkit.org/b/237711 laid the groundwork for SVG
transforms in LBSE, however there are still issues:

• SVG transforms specified alone on SVG elements, w/o any additional style/perspective related property such as transform-box / transform-origin / ... do not trigger layer creation, fix by adapting StyleAdjuster.

• Switching on/off transforms for a SVG element, was not tracking updates to both 'HasSVGTransform' and 'HasTransformRelatedProperty' flags correctly, fix that by introducing an 'updateHasSVGTransformFlags' helper.

• Modify SVGContainerLayout to avoid a dependency on the children transformations when computing container boundaries. In the legacy engine, we always have to mark the whole ancestor chain as 'need to recompute boundaries' and invoking a re-layout, to perform the recomputation. This change avoids the invalidation of the whole ancestor chain, when an elements transform changes in a non-accelerated way (e.g. SVGTransformList manipulation, SMIL <animateTransform> / <animate> / <set>). In CSS transformations do not affect layout, only hit-testing and painting.

-> SVG/CSS transforms applied on SVG elements is conceptually equivalent to CSS transformations on CSS boxes now.

Transformation changes no longer affect the 'internal geometry' (objectBoundingBoxWithoutTransformations()).
currentSVGLayoutLocation() / nominalSVGLayoutLocation() are computed using the 'internal geometry' and used
throughout layout.

This avoids most of the RenderLayer / RenderLayerBacking specific changes that were present in the downstream
LBSE implementation, while also solving an important design issue: no back-splash from children to parents.
Large, deep nested documents -- as seen in the wild -- will benefit the most, avoiding the frequent ancestor
walks to mark the containing block / parent hierachy for re-layout.

Covered by existing tests, no change in behaviour. (However testability for LBSE is ready soon!).

• rendering/RenderElement.cpp:

(WebCore::RenderElement::referenceBoxRect const):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::paintLayerByApplyingTransform):

• rendering/RenderLayer.h:

(WebCore::RenderLayer::rendererLocation const):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::computeVisibleRectInSVGContainer const):
(WebCore::RenderLayerModelObject::updateHasSVGTransformFlags):

• rendering/RenderLayerModelObject.h:

(WebCore::RenderLayerModelObject::nominalSVGLayoutLocation const):
(WebCore::RenderLayerModelObject::currentSVGLayoutLocation const):
(WebCore::RenderLayerModelObject::setCurrentSVGLayoutLocation):

• rendering/RenderObject.h:

(WebCore::RenderObject::objectBoundingBoxWithoutTransformations const):

• rendering/svg/RenderSVGBlock.h:
• rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layoutChildren):
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::nodeAtPoint):
(WebCore::RenderSVGContainer::styleDidChange): Deleted.

• rendering/svg/RenderSVGContainer.h:
• rendering/svg/RenderSVGInline.h:
• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::updateFromStyle):
(WebCore::RenderSVGModelObject::absoluteRects const):

• rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::currentSVGLayoutRect const):
(WebCore::RenderSVGModelObject::setCurrentSVGLayoutRect):
(WebCore::RenderSVGModelObject::frameRectEquivalent const):
(WebCore::RenderSVGModelObject::applyTopLeftLocationOffsetEquivalent const):
(WebCore::RenderSVGModelObject::layoutRect const): Deleted.
(WebCore::RenderSVGModelObject::setLayoutRect): Deleted.
(WebCore::RenderSVGModelObject::setLayoutLocation): Deleted.
(WebCore::RenderSVGModelObject::paintingLocation const): Deleted.
(WebCore::RenderSVGModelObject::layoutLocation const): Deleted.
(WebCore::RenderSVGModelObject::layoutLocationOffset const): Deleted.
(WebCore::RenderSVGModelObject::layoutSize const): Deleted.

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::updateFromStyle):

• rendering/svg/RenderSVGRoot.h:
• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::nodeAtPoint):

• rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::updateFromStyle):

• rendering/svg/SVGBoundingBoxComputation.cpp:

(WebCore::SVGBoundingBoxComputation::handleRootOrContainer const):

• rendering/svg/SVGBoundingBoxComputation.h:

(WebCore::SVGBoundingBoxComputation::computeVisualOverflowRect):

• rendering/svg/SVGContainerLayout.cpp:

(WebCore::SVGContainerLayout::positionChildrenRelativeToContainer):
(WebCore::SVGContainerLayout::verifyLayoutLocationConsistency):
(WebCore::layoutLocationFromRenderer): Deleted.
(WebCore::setLayoutLocationForRenderer): Deleted.

• rendering/svg/SVGContainerLayout.h:
• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

3:36 AM Changeset in webkit [293503] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

<link rel=preconnect> always sends credentials to different-origin, ignoring crossorigin=anonymous
​https://bugs.webkit.org/show_bug.cgi?id=239119
<rdar://problem/91643534>

Reviewed by John Wilander.

Update the check as per spec, step 5 of
​https://html.spec.whatwg.org/multipage/links.html#link-type-preconnect

This is difficult to test as preconnect can only expose TLS credentials.

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preconnectIfNeeded):

2:10 AM Changeset in webkit [293502] by youenn@apple.com

• 15 edits
  3 adds in trunk

Add testRunner API to clear memory cache
​https://bugs.webkit.org/show_bug.cgi?id=239804
rdar://92033309

Reviewed by Chris Dumez.

Source/WebCore:

• testing/Internals.cpp:

(WebCore::Internals::clearMemoryCache):
Beef up clearMemoryCache to be on par with testRunner counterpart.

Source/WebKit:

Add necessary WebKit API to implement the testRunner API.
Make use of new testRunner API in added test.

Test: http/wpt/fetch/clear-memory-cache.html

• NetworkProcess/NetworkProcess.cpp:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

Tools:

Implement the clear memory cache testRunner API and related plumbery.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:
• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

LayoutTests:

• http/wpt/fetch/clear-memory-cache-expected.txt: Added.
• http/wpt/fetch/clear-memory-cache.html: Added.
• http/wpt/fetch/resources/clear-memory-cache.py: Added.

2:01 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

1:21 AM Changeset in webkit [293501] by youenn@apple.com

• 42 edits
  3 adds
  2 deletes in trunk

Shared workers should match service worker registrations
​https://bugs.webkit.org/show_bug.cgi?id=239122

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt:
• web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
• web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:

Source/WebCore:

Update SharedWorkerScriptLoader to set correctly client ID and service worker data.
Ditto for SharedWorkerThread and SharedWorkerThreadProxy.
Add support to get a SharedWorkerThreadProxy from a client ID.
Use this in SWClientConnection to add support for controller change and post messaging.

Given we create the shared worker identifier in one web process but we might spawn the actual worker in another process,
we need to unregister the identifier with the old process identifier and register the identifier with the new process identifier.
This is done at shared worker launch time.

Covered by updated tests.
Test: http/wpt/service-workers/controlled-sharedworker.https.html

• Headers.cmake:
• workers/Worker.cpp:
• workers/Worker.h:
• workers/WorkerGlobalScope.cpp:
• workers/WorkerInitializationData.h:
• workers/WorkerScriptLoader.cpp:
• workers/WorkerScriptLoader.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::gatherClientData):

• workers/service/server/SWServer.h:
• workers/service/SWClientConnection.cpp:
• workers/service/ServiceWorkerContainer.cpp:
• workers/shared/SharedWorkerObjectConnection.cpp:
• workers/shared/SharedWorkerObjectConnection.h:
• workers/shared/SharedWorkerScriptLoader.cpp:
• workers/shared/SharedWorkerScriptLoader.h:
• workers/shared/context/SharedWorkerThread.cpp:
• workers/shared/context/SharedWorkerThreadProxy.cpp:
• workers/shared/context/SharedWorkerThreadProxy.h:

Source/WebKit:

• NetworkProcess/NetworkResourceLoader.cpp:
• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
• NetworkProcess/ServiceWorker/WebSWServerConnection.h:
• NetworkProcess/SharedWorker/WebSharedWorker.h:
• NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
• NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
• NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp:
• NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:
• NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
• WebProcess/Storage/WebSWClientConnection.cpp:
• WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
• WebProcess/Storage/WebSharedWorkerContextManagerConnection.h:
• WebProcess/Storage/WebSharedWorkerContextManagerConnection.messages.in:
• WebProcess/Storage/WebSharedWorkerObjectConnection.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):

LayoutTests:

• http/wpt/service-workers/controlled-sharedworker.https-expected.txt: Added.
• http/wpt/service-workers/controlled-sharedworker.https.html: Added.
• http/wpt/service-workers/resources/controlled-sharedworker.js: Added.
• http/wpt/service-workers/skipFetchEvent-worker.js:
• platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed.
• platform/ios-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed.

Apr 26, 2022:

10:59 PM Changeset in webkit [293500] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.10.7

Tag WebKit-7614.1.10.7.

10:55 PM Changeset in webkit [293499] by Russell Epstein

• 9 edits in branches/safari-614.1.10-branch/Source

Versioning.

WebKit-7614.1.10.7

10:40 PM Changeset in webkit [293498] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
​https://bugs.webkit.org/show_bug.cgi?id=239646

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-26
Reviewed by Darin Adler.

These were used to adjust patches 10 years ago.
The functionality renames *_test_expectations.txt in ANGLE imports, which causes surprises
and hard to track redundant sections while inspecting downstream differences to upstream.

• Scripts/VCSUtils.pm:

(parseGitDiffHeader):

10:30 PM Changeset in webkit [293497] by Antti Koivisto

• 8 edits
  2 adds in trunk

::first-letter does not work if used only in shadow content
​https://bugs.webkit.org/show_bug.cgi?id=220650
<rdar://problem/73477161>

Reviewed by Alan Bujtas.

Source/WebCore:

Test: fast/shadow-dom/shadow-first-line-and-letter.html

We were not setting usesFirstLetter/LinesRules bits if those pseudo-elements were used
only in shadow trees.

Fix by removing the bits. They don't seem to allow any valuable optimizations.

• rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::verticalPositionForBox):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::getFirstLetter):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::mayAffectLayout const):
(WebCore::RenderInline::lineHeight const):

• rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::lineHeight const):

• rendering/RenderView.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolve):

LayoutTests:

Test case by ​vb@bigdot.de.

• fast/shadow-dom/shadow-first-line-and-letter-expected.html: Added.
• fast/shadow-dom/shadow-first-line-and-letter.html: Added.

9:49 PM Changeset in webkit [293496] by Simon Fraser

• 2 edits in trunk/Source/WebKit

Don't flush the IOSurface CGContext when just setting ownership identity
​https://bugs.webkit.org/show_bug.cgi?id=239800

Reviewed by Myles C. Maxfield.

ImageBufferIOSurfaceBackend::surface() has a call to flushContext(), which we don't need
to do if we're just getting the surface to call setOwnershipIdentity(), so use m_surface
directly.

This is a ~18% perf gain on the Leaves MotionMark subtest on iPhone.

• WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::setOwnershipIdentity):

7:48 PM Changeset in webkit [293495] by commit-queue@webkit.org

• 5 edits in trunk/Tools

[git-webkit] Cannot create pull request branch using bug URL, fails to fetch comments from Bugzilla, fails to modify bug
​https://bugs.webkit.org/show_bug.cgi?id=239741

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Jonathan Bedard.

• Tools/Scripts/libraries/webkitbugspy/setup.py:
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py:
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:

(Tracker.credentials.validater):
(Tracker._login_arguments):

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:

(Bugzilla.init):
(Bugzilla.request):

Canonical link: ​https://commits.webkit.org/250028@main

7:31 PM Changeset in webkit [293494] by Kyle Piddington

• 3 edits in trunk/Source/ThirdParty/ANGLE

Max Limits have been reduced
​https://bugs.webkit.org/show_bug.cgi?id=238914
Allow larger constant uniform buffer data. Provide a
buffer to Metal if uniform data exceeds 4kb
Tested by running deqp gles3 limits tests for uniform data

Reviewed by Dean Jackson.

• src/libANGLE/renderer/metal/ProgramMtl.mm:

(rx::ProgramMtl::commitUniforms):

• src/libANGLE/renderer/metal/mtl_common.h:

7:01 PM Changeset in webkit [293493] by Oriol Brufau

• 6 edits in trunk/Source/WebCore

[css-logical] Side border shorthands should not be logical/physical
​https://bugs.webkit.org/show_bug.cgi?id=239734

Reviewed by Tim Nguyen.

No test since now there should be no observable change in behavior.

However, this refactoring will be needed for bug 236199.

• animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Mark logical side border shorthands as animatable.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Add code for serializing logical side border shorthands.

• css/CSSProperties.json:

Stop side border shorthands from being in a logical property group.
They will just expand into logical or physical longhands, but the
shorthands themselves will be normal.

• css/makeprop.pl:

(addProperty):
Assert that no shorthand belongs to a logical property group.

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):
Remove dead code.

7:00 PM Changeset in webkit [293492] by dbezhetskov

• 2 edits in trunk/Source/JavaScriptCore

[WASM] Fix warning: cast from ‘char*’ to ‘JSC::Wasm::Type*’ increases required alignment of target type [-Wcast-align]
​https://bugs.webkit.org/show_bug.cgi?id=239698

Reviewed by Darin Adler.

There is a warning inside TypeDefinition on some platforms so this
patch fixes it.

• wasm/WasmTypeDefinition.h:

(JSC::Wasm::FunctionSignature::FunctionSignature):
(JSC::Wasm::FunctionSignature::storage):
(JSC::Wasm::FunctionSignature::storage const):
(JSC::Wasm::StructType::StructType):
(JSC::Wasm::StructType::storage):
(JSC::Wasm::StructType::storage const):
(JSC::Wasm::TypeDefinition::payload):

6:15 PM Changeset in webkit [293491] by Chris Dumez

• 3 edits in trunk/Source

Avoid iterating the input string several times setInnerText() / setOuterText()
​https://bugs.webkit.org/show_bug.cgi?id=239783

Reviewed by Geoff Garen.

Avoid iterating the input string several times setInnerText() / setOuterText(), to look for new lines
and carriage return characters. Instead of calling contains('\n') and then contains('\r'), thus iterating
over the string twice, we now call contains([](UChar c) { return c == '\n' || c == '\r'; }), achieving
the same thing by traversing the input string only once.

• Source/WTF/wtf/text/WTFString.h:
• Source/WebCore/editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::performTrivialReplace):

• Source/WebCore/html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):
(WebCore::HTMLElement::setOuterText):

Canonical link: ​https://commits.webkit.org/250023@main

6:14 PM Changeset in webkit [293490] by commit-queue@webkit.org

• 2 edits
  7 deletes in trunk/LayoutTests

Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests
​https://bugs.webkit.org/show_bug.cgi?id=239790

Unreviewed test gardening.

• LayoutTests/platform/ios-wk2/TestExpectations:
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-receives-element-events-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/closed-dialog-does-not-block-mouse-events-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-inlines-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/non-modal-dialog-does-not-block-mouse-events-expected.txt: Removed.
• LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/simulated-click-inert-expected.txt: Removed.

Canonical link: ​https://commits.webkit.org/250023@main

5:47 PM Changeset in webkit [293489] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.10.6

Tag WebKit-7614.1.10.6.

5:29 PM Changeset in webkit [293488] by Jean-Yves Avenard

• 14 edits in trunk/Source/WebCore

MediaSession.setPositionState() does not work.
​https://bugs.webkit.org/show_bug.cgi?id=237196

Reviewed by Eric Carlson.

Use MediaSession's positionState if present when constructing NowPlaying
MediaRemote data.
We emulate what the media-session position would have been had the
time progressed according to the playback rate.
As such, we need to tell the media-session when no action handlers are
set that the media was paused or played again.
When seeking, we update the new time position and continue according to
the set playback rate.

Tested manually with the following scenarios:

• Set a page only defining the media-session's position state once
• Let the media element play by default, check the Now Playing position
• Pause/Play using Now Playing control and checks that the time doesn't jump around.
• Seek using Now Playing and check that the media seeks properly and that the Now Playing positon progress from the seek point according to the media-session's playback rate.
• Seek using default media control and check the same as above.
• Seek using default media control, then pause in Now Playing: check that the playback position doesn't jump around.

We don't have a way to properly test the MediaRemote
external framework and with existing MediaSession API tests currently
disabled following bug 221514.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::setPlaybackState):
(WebCore::MediaSession::updateReportedPosition):
(WebCore::MediaSession::willBeginPlayback):
(WebCore::MediaSession::willPausePlayback):
(WebCore::MediaSession::positionOverridden):

• Modules/mediasession/MediaSession.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::removedFromAncestor):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::finishSeek):
(WebCore::HTMLMediaElement::clearMediaPlayer):

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::clientWillBeginPlayback):
(WebCore::MediaElementSession::clientWillPausePlayback):
(WebCore::MediaElementSession::nowPlayingInfo const):
(WebCore::MediaElementSession::metadataChanged):
(WebCore::MediaElementSession::positionStateChanged):
(WebCore::MediaElementSession::clientCharacteristicsChanged):

• html/MediaElementSession.h:
• platform/audio/NowPlayingInfo.h:

(WebCore::NowPlayingInfo::operator== const):
(WebCore::NowPlayingInfo::encode const):
(WebCore::NowPlayingInfo::decode):

• platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::clientCharacteristicsChanged):

• platform/audio/PlatformMediaSession.h:
• platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::clientCharacteristicsChanged):

• platform/audio/cocoa/MediaSessionManagerCocoa.h:
• platform/audio/cocoa/MediaSessionManagerCocoa.mm:

(WebCore::MediaSessionManagerCocoa::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo):

5:27 PM Changeset in webkit [293487] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS ] webanimations/accelerated-animation-after-forward-filling-animation.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239794

Unreviewed test gardening.

• LayoutTests/platform/mac/TestExpectations:

Canonical link: ​https://commits.webkit.org/250021@main

5:23 PM Changeset in webkit [293486] by Elliott Williams

• 9 edits in trunk/Source

Unreviewed, reverting "[Xcode] Compute PGO profdata paths instead of searching for them at build time"
​https://bugs.webkit.org/show_bug.cgi?id=239681

Source/JavaScriptCore:

This reverts commit 433f73bc052d7c978c619e28b2574df8faf6cb72.

• Configurations/JavaScriptCore.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

• Configurations/WebCore.xcconfig:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

• Configurations/BaseTarget.xcconfig:
• WebKit.xcodeproj/project.pbxproj:

5:19 PM Changeset in webkit [293485] by Oriol Brufau

• 6 edits
  4 adds in trunk

[css-cascade] Fix cascade rollback for deferred properties
​https://bugs.webkit.org/show_bug.cgi?id=238125

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Add a test. It still has some failures due to bug 239579, bug 239669,
and bug 239670.

• web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: Added.
• web-platform-tests/css/css-cascade/all-prop-revert-layer.html: Added.

Source/WebCore:

When a deferred property was set to 'revert' or 'revert-layer', it used
to roll back to a declaration of the same exact property (or behave as
'unset' if none).

This patch lets deferred properties roll back to their related property,
e.g. '-webkit-box-shadow: revert-layer' can roll back to a 'box-shadow'
declaration in the previous layer.

This is consistent with logical and physical properties, where the
rollback happens after resolving logical properties.

Test: imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html

• style/PropertyCascade.cpp:

(WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const):

• style/PropertyCascade.h:
• style/StyleBuilder.cpp:

(WebCore::Style::Builder::applyProperty):

LayoutTests:

Add custom expectation for mac-wk1 since scroll-behavior is disabled
there, and thus not checked by the test.

• platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: Added.

4:44 PM Changeset in webkit [293484] by Chris Dumez

• 208 edits in trunk

Update equalLettersIgnoringASCIICase() / startsWithLettersIgnoringASCIICase() to take in an ASCIILiteral
​https://bugs.webkit.org/show_bug.cgi?id=239775

Reviewed by Geoff Garen.

Update equalLettersIgnoringASCIICase() / startsWithLettersIgnoringASCIICase() to take in an ASCIILiteral,
as we are encouraging developers to use _s suffix for string literals.

• Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

• Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::xmlRoleValueString):

• Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm:

(WTR::testPathFromURL):

• Source/JavaScriptCore/runtime/Options.cpp:

(JSC::parse):

• Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:

(PAL::defaultTextEncodingNameForSystemLanguage):

• Source/WebDriver/WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const):

• Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::resume):

• Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo):

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

• Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::isMediaMIMEType):

• Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

• Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):

• Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):

• Source/WebKit/UIProcess/API/C/WKWebsitePolicies.cpp:

(WKWebsitePoliciesSetCustomHeaderFields):

• Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.mm:

(-[_WKCustomHeaderFields setFields:]):

• Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::visibleDomain):

• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::matchesExtensionOrEquivalent):

• Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommendedForRequest):

• Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::encodeSharedMemory):

• Source/WTF/wtf/Assertions.cpp:
• Source/WTF/wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

• Source/WTF/wtf/SortedArrayMap.h:

(WTF::operator==):

• Source/WTF/wtf/text/AtomString.h:

(WTF::equalLettersIgnoringASCIICase):

• Source/WTF/wtf/text/StringCommon.h:

(WTF::equalLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICaseCommon):
(WTF::startsWithLettersIgnoringASCIICaseCommon):
(WTF::equalLettersIgnoringASCIICaseCommonWithoutLength): Deleted.
(WTF::startsWithLettersIgnoringASCIICaseCommonWithoutLength): Deleted.

• Source/WTF/wtf/text/StringImpl.h:

(WTF::startsWithLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICase):

• Source/WTF/wtf/text/StringView.h:

(WTF::equalLettersIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):

• Source/WTF/wtf/text/WTFString.h:

(WTF::equalLettersIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):

• Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::validatedPaymentNetwork const):

• Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::parseIcons):

• Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:

(WebCore::LegacyCDMPrivateClearKey::supportsKeySystem):
(WebCore::LegacyCDMPrivateClearKey::supportsKeySystemAndMimeType):

• Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::update):

• Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::packageFormData):

• Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:

(WebCore::isValidVideoMIMEType):
(WebCore::isValidAudioMIMEType):

• Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:

(WebCore::MediaRecorderProvider::isSupported):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::supportsMIMEType):
(WebCore::YouTubePluginReplacement::supportsFileExtension):
(WebCore::isYouTubeURL):
(WebCore::processAndCreateYouTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):

• Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinatorInternal::needsAppIdQuirks):

• Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::checkResponseHeaders):

• Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::isModalElement const):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::isNodeAriaVisible):

• Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

• Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled const):

• Source/WebCore/accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isIndeterminate const):
(WebCore::AccessibilityNodeObject::isPressed const):
(WebCore::AccessibilityNodeObject::isChecked const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::elementAttributeValue const):
(WebCore::shouldUseAccessibilityObjectInnerText):
(WebCore::AccessibilityNodeObject::textUnderElement const):

• Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::autoCompleteValue const):
(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
(WebCore::AccessibilityObject::ariaIsMultiline const):
(WebCore::AccessibilityObject::liveRegionStatusIsEnabled):
(WebCore::AccessibilityObject::sortDirection const):
(WebCore::AccessibilityObject::popupValue const):
(WebCore::AccessibilityObject::supportsPressed const):
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::checkboxOrRadioValue const):
(WebCore::AccessibilityObject::isAXHidden const):
(WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild):

• Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasPopup const):
(WebCore::AccessibilityRenderObject::supportsDragging const):
(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::isSelected const):
(WebCore::AccessibilityRenderObject::orientation const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):

• Source/WebCore/accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation const):

• Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::rolePlatformDescription const):

• Source/WebCore/animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::processKeyframes):

• Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):

• Source/WebCore/css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSVGFontFaceSrc const):

• Source/WebCore/css/MediaList.cpp:

(WebCore::reportMediaQueryWarningIfNeeded):

• Source/WebCore/css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::mediaTypeMatch const):
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific const):
(WebCore::evaluateResolution):

• Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):

• Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::isUniversalKeyword):

• Source/WebCore/css/parser/CSSParserImpl.cpp:

(WebCore::consumeStringOrURI):
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::consumeKeyframeKeyList):

• Source/WebCore/css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::parsePagePseudoSelector):
(WebCore::CSSParserSelector::parsePseudoElementSelector):

• Source/WebCore/css/parser/CSSParserTokenRange.cpp:

(WebCore::CSSParserTokenRange::consumeBlockCheckingForEditability):

• Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAnimationName):

• Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:

(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeUnicodeRangeString):

• Source/WebCore/css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::consumeAttributeFlags):
(WebCore::consumeANPlusB):

• Source/WebCore/css/parser/CSSSupportsParser.cpp:

(WebCore::CSSSupportsParser::consumeCondition):

• Source/WebCore/css/parser/CSSTokenizer.cpp:

(WebCore::CSSTokenizer::consumeIdentLikeToken):

• Source/WebCore/css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::readMediaNot):
(WebCore::isRestrictorOrLogicalOperator):
(WebCore::MediaQueryParser::readMediaType):
(WebCore::MediaQueryParser::readAnd):
(WebCore::MediaQueryParser::handleBlocks):

• Source/WebCore/css/parser/SizesCalcParser.cpp:

(WebCore::SizesCalcParser::calcToReversePolishNotation):

• Source/WebCore/css/typedom/transform/CSSPerspective.cpp:

(WebCore::checkLength):

• Source/WebCore/dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::determineActiveThemeColorMetaElement):
(WebCore::Document::processColorScheme):
(WebCore::Document::processFormatDetection):
(WebCore::Document::createEvent):
(WebCore::Document::setDesignMode):
(WebCore::Document::parseDNSPrefetchControlHeader):

• Source/WebCore/dom/Element.cpp:

(WebCore::isStyleAttribute):
(WebCore::Element::isSpellCheckingEnabled const):
(WebCore::Element::canContainRangeEndPoint const):

• Source/WebCore/dom/InlineStyleSheetOwner.cpp:

(WebCore::isValidCSSContentType):

• Source/WebCore/dom/ScriptElement.cpp:

(WebCore::ScriptElement::determineScriptType const):
(WebCore::ScriptElement::isScriptForEventSupported const):

• Source/WebCore/dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

• Source/WebCore/dom/ViewportArguments.cpp:

(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findBooleanValue):
(WebCore::parseViewportFitValue):
(WebCore::setViewportFeature):

• Source/WebCore/editing/EditorCommand.cpp:

(WebCore::executeDefaultParagraphSeparator):
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):

• Source/WebCore/editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

• Source/WebCore/editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::requiresExtendedContext):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::isDataDetectorElement):

• Source/WebCore/history/HistoryItem.cpp:

(WebCore::HistoryItem::setFormInfoFromRequest):

• Source/WebCore/html/Autocapitalize.cpp:

(WebCore::autocapitalizeTypeForAttributeValue):

• Source/WebCore/html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement):

• Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable const):
(WebCore::HTMLAnchorElement::relList):

• Source/WebCore/html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::parseAttribute):

• Source/WebCore/html/HTMLBRElement.cpp:

(WebCore::HTMLBRElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::parseAttribute):

• Source/WebCore/html/HTMLDivElement.cpp:

(WebCore::HTMLDivElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLElement.cpp:

(WebCore::isLTROrRTLIgnoringCase):
(WebCore::contentEditableType):
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
(WebCore::toValidDirValue):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::setContentEditable):
(WebCore::HTMLElement::draggable const):
(WebCore::HTMLElement::translate const):
(WebCore::HTMLElement::hasDirectionAuto const):
(WebCore::HTMLElement::directionality const):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::parseLegacyColorValue):
(WebCore::HTMLElement::shouldAutocorrect const):

• Source/WebCore/html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::shouldAutocorrect const):

• Source/WebCore/html/HTMLFormElement.cpp:

(WebCore::parseFormRelAttributes):
(WebCore::HTMLFormElement::shouldAutocorrect const):
(WebCore::HTMLFormElement::relList):
(WebCore::HTMLFormElement::shouldAutocomplete const):
(WebCore::HTMLFormElement::autocomplete const):

• Source/WebCore/html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::scrollingMode const):

• Source/WebCore/html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseAttribute):

• Source/WebCore/html/HTMLHRElement.cpp:

(WebCore::HTMLHRElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::loadingForBindings const):
(WebCore::isFrameLazyLoadable):

• Source/WebCore/html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::hasLazyLoadableAttributeValue):
(WebCore::parseCrossoriginState):
(WebCore::HTMLImageElement::decodingMode const):

• Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::mediaCaptureType const):

• Source/WebCore/html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::as const):
(WebCore::HTMLLinkElement::process):

• Source/WebCore/html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

• Source/WebCore/html/HTMLMenuElement.cpp:

(WebCore::HTMLMenuElement::parseAttribute):

• Source/WebCore/html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::attributeChanged):
(WebCore::HTMLMetaElement::removedFromAncestor):
(WebCore::HTMLMetaElement::process):

• Source/WebCore/html/HTMLObjectElement.cpp:

(WebCore::mapDataParamToSrc):
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::containsJavaApplet const):

• Source/WebCore/html/HTMLParagraphElement.cpp:

(WebCore::HTMLParagraphElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::isURLParameter):

• Source/WebCore/html/HTMLTableElement.cpp:

(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLTableElement::parseAttribute):

• Source/WebCore/html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::parseAttribute):

• Source/WebCore/html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText):
(WebCore::HTMLTextFormControlElement::directionForFormData const):

• Source/WebCore/html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute):

• Source/WebCore/html/InputType.cpp:

(WebCore::InputType::applyStep):

• Source/WebCore/html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):

• Source/WebCore/html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled const):

• Source/WebCore/html/NumberInputType.cpp:

(WebCore::NumberInputType::sizeShouldIncludeDecoration const):

• Source/WebCore/html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange const):
(WebCore::RangeInputType::handleKeydownEvent):

• Source/WebCore/html/StepRange.cpp:

(WebCore::StepRange::parseStep):

• Source/WebCore/html/canvas/CanvasStyle.cpp:

(WebCore::isCurrentColorString):

• Source/WebCore/html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

• Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):

• Source/WebCore/html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::isHTMLIntegrationPoint):

• Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):

• Source/WebCore/html/parser/HTMLParserIdioms.cpp:

(WebCore::parseCORSSettingsAttribute):

• Source/WebCore/html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):

• Source/WebCore/html/parser/ParsingUtilities.h:

(WebCore::skipExactlyIgnoringASCIICase):

• Source/WebCore/html/track/TextTrack.cpp:

(WebCore::TextTrack::setKindKeywordIgnoringASCIICase):

• Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::shouldTreatAsText):

• Source/WebCore/loader/CrossOriginAccessControl.cpp:

(WebCore::createPotentialAccessControlRequest):

• Source/WebCore/loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadApplicationManifest):

• Source/WebCore/loader/FetchIdioms.cpp:

(WebCore::shouldBlockResponseDueToMIMEType):

• Source/WebCore/loader/FormSubmission.cpp:

(WebCore::appendMailtoPostFormDataToURL):
(WebCore::FormSubmission::Attributes::parseEncodingType):
(WebCore::FormSubmission::Attributes::parseMethodType):

• Source/WebCore/loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldPerformFragmentNavigation):

• Source/WebCore/loader/LinkHeader.cpp:

(WebCore::paramterNameFromString):

• Source/WebCore/loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::LinkLoader::preconnectIfNeeded):

• Source/WebCore/loader/ResourceCryptographicDigest.cpp:

(WebCore::parseHashAlgorithmAdvancingPosition):

• Source/WebCore/loader/ServerTiming.cpp:

(WebCore::ServerTiming::setParameter):

• Source/WebCore/loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::determineContentType):
(WebCore::TextResourceDecoder::setEncoding):

• Source/WebCore/loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):

• Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:

(WebCore::parseApplicationCacheManifest):

• Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):

• Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::mimeTypeAllowedByNosniff const):
(WebCore::CachedCSSStyleSheet::canUseSheet const):

• Source/WebCore/loader/cache/CachedResource.cpp:

(WebCore::shouldCacheSchemeIndefinitely):

• Source/WebCore/mathml/MathMLElement.cpp:

(WebCore::MathMLElement::collectPresentationalHintsForAttribute):

• Source/WebCore/mathml/MathMLFractionElement.cpp:

(WebCore::MathMLFractionElement::lineThickness):
(WebCore::MathMLFractionElement::cachedFractionAlignment):

• Source/WebCore/page/DOMSelection.cpp:

(WebCore::DOMSelection::modify):

• Source/WebCore/page/EventSource.cpp:

(WebCore::EventSource::responseIsValid const):

• Source/WebCore/page/FrameView.cpp:

(WebCore::FrameView::scrollToFragmentInternal):

• Source/WebCore/page/Page.cpp:

(WebCore::Page::useDarkAppearance const):

• Source/WebCore/page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

• Source/WebCore/page/Quirks.cpp:

(WebCore::isYahooMail):
(WebCore::Quirks::needsFormControlToBeMouseFocusable const):
(WebCore::Quirks::needsSeekingSupportDisabled const):
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
(WebCore::Quirks::shouldAutoplayWebAudioForArbitraryUserGesture const):
(WebCore::Quirks::shouldTooltipPreventFromProceedingWithClick const):
(WebCore::Quirks::needsMillisecondResolutionForHighResTimeStamp const):
(WebCore::Quirks::shouldStripQuotationMarkInFontFaceSetFamily const):
(WebCore::Quirks::isTouchBarUpdateSupressedForHiddenContentEditable const):
(WebCore::Quirks::isNeverRichlyEditableForTouchBar const):
(WebCore::shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreasForHost):
(WebCore::Quirks::shouldDispatchSyntheticMouseEventsWhenModifyingSelection const):
(WebCore::Quirks::needsYouTubeMouseOutQuirk const):
(WebCore::Quirks::shouldAvoidUsingIOS13ForGmail const):
(WebCore::Quirks::isGoogleMaps const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):
(WebCore::Quirks::shouldMakeTouchEventNonCancelableForTarget const):
(WebCore::Quirks::shouldPreventPointerMediaQueryFromEvaluatingToCoarse const):
(WebCore::Quirks::shouldPreventDispatchOfTouchEvent const):
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
(WebCore::Quirks::shouldDisablePointerEventsQuirk const):
(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const):
(WebCore::Quirks::needsInputModeNoneImplicitly const):
(WebCore::Quirks::needsGMailOverflowScrollQuirk const):
(WebCore::Quirks::needsYouTubeOverflowScrollQuirk const):
(WebCore::Quirks::needsFullscreenDisplayNoneQuirk const):
(WebCore::Quirks::shouldSilenceWindowResizeEvents const):
(WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const):
(WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):
(WebCore::Quirks::shouldUseLegacySelectPopoverDismissalBehaviorInDataActivation const):
(WebCore::Quirks::shouldIgnoreAriaForFastPathContentObservationCheck const):
(WebCore::Quirks::shouldOpenAsAboutBlank const):
(WebCore::Quirks::shouldBypassBackForwardCache const):
(WebCore::Quirks::shouldIgnoreContentObservationForSyntheticClick const):
(WebCore::Quirks::needsVP9FullRangeFlagQuirk const):
(WebCore::Quirks::needsHDRPixelDepthQuirk const):
(WebCore::Quirks::needsBlackFullscreenBackgroundQuirk const):
(WebCore::Quirks::shouldDisableEndFullscreenEventWhenEnteringPictureInPictureFromFullscreenQuirk const):
(WebCore::Quirks::needsToForceUserSelectAndUserDragWhenInstallingImageOverlay const):

• Source/WebCore/page/SecurityOrigin.cpp:

(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):

• Source/WebCore/page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::databaseIdentifier const):

• Source/WebCore/page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches const):

• Source/WebCore/page/WindowFeatures.cpp:

(WebCore::setWindowFeature):
(WebCore::boolFeature):

• Source/WebCore/page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):
(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression const):

• Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::isSourceListNone):
(WebCore::schemeIsInHttpFamily):
(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):

• Source/WebCore/platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):
(WebCore::MIMETypeRegistry::isSupportedWebAssemblyMIMEType):
(WebCore::MIMETypeRegistry::isSupportedStyleSheetMIMEType):
(WebCore::MIMETypeRegistry::isSupportedFontMIMEType):
(WebCore::MIMETypeRegistry::isTextMediaPlaylistMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJSONMIMEType):
(WebCore::MIMETypeRegistry::isSupportedTextTrackMIMEType):
(WebCore::MIMETypeRegistry::isTextMIMEType):
(WebCore::MIMETypeRegistry::isXMLMIMEType):
(WebCore::MIMETypeRegistry::isXMLEntityMIMEType):
(WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
(WebCore::MIMETypeRegistry::isPostScriptMIMEType):
(WebCore::MIMETypeRegistry::canShowMIMEType):

• Source/WebCore/platform/PreviewConverter.cpp:

(WebCore::PreviewConverter::supportsMIMEType):

• Source/WebCore/platform/ReferrerPolicy.cpp:

(WebCore::parseReferrerPolicyToken):

• Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseLicenseFormat):
(WebCore::CDMFactoryClearKey::supportsKeySystem):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMInstanceSessionClearKey::requestLicense):

• Source/WebCore/platform/graphics/FontCache.cpp:

(WebCore::FontCache::alternateFamilyName):

• Source/WebCore/platform/graphics/FontDescription.cpp:

(WebCore::computeSpecializedChineseLocale):

• Source/WebCore/platform/graphics/FontGenericFamilies.cpp:

(WebCore::computeUserPrefersSimplified):

• Source/WebCore/platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::shouldOverrideExtendedType):

• Source/WebCore/platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType):

• Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):

• Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::keySystemIsSupported):

• Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):

• Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::generateKeyRequest):

• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::willUseWebMFormatReaderForType):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):

• Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::utiFromImageBufferMIMEType):

• Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::similarFont):
(WebCore::isDotPrefixedForbiddenFont):
(WebCore::fontWithFamilySpecialCase):
(WebCore::FontCache::platformAlternateFamilyName):

• Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp:

(WebCore::matchSystemFontUse):

• Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::isContentTypeSupported):

• Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::monospaceFamily):

• Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::isCommonlyUsedGenericFamily):

• Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

• Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:

(webKitDMABufVideoSinkIsEnabled):

• Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:

(WebCore::CDMPrivateThunder::supportsInitData const):

• Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

• Source/WebCore/platform/graphics/win/FontCacheWin.cpp:

(WebCore::adjustedGDIFontWeight):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::platformAlternateFamilyName):

• Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

• Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

• Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:

(WebCore::VideoSampleBufferCompressor::create):

• Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::createDecodingConfiguration):
(WebCore::LibWebRTCProvider::createEncodingConfiguration):

• Source/WebCore/platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::doStart):

• Source/WebCore/platform/network/CacheValidation.cpp:

(WebCore::parseCacheControlDirectives):

• Source/WebCore/platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::shouldRemoveFragmentIdentifier):
(WebCore::DataURLDecoder::DecodeTask::process):

• Source/WebCore/platform/network/FormData.h:

(WebCore::FormData::parseEncodingType):

• Source/WebCore/platform/network/HTTPParsers.cpp:

(WebCore::parseContentTypeOptionsHeader):
(WebCore::parseXFrameOptionsHeader):
(WebCore::parseRange):
(WebCore::isForbiddenHeaderName):
(WebCore::isPriviledgedNoCORSRequestHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isForbiddenMethod):
(WebCore::isCrossOriginSafeRequestHeader):

• Source/WebCore/platform/network/MIMEHeader.cpp:

(WebCore::MIMEHeader::parseContentTransferEncoding):

• Source/WebCore/platform/network/ResourceRequestBase.cpp:

(WebCore::shouldUseGet):

• Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isAttachment const):
(WebCore::ResourceResponseBase::isAttachmentWithFilename const):

• Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):

• Source/WebCore/platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieAttributes):

• Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:

(WebCore::CurlMultipartHandle::extractBoundary):

• Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::isAppendableHeader):
(WebCore::ResourceResponse::appendHTTPHeaderField):

• Source/WebCore/platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::willSendRequest):

• Source/WebCore/platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::useWALJournalMode):

• Source/WebCore/platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::isColumnDeclaredAsBlob):

• Source/WebCore/platform/win/PasteboardWin.cpp:

(WebCore::clipboardTypeFromMIMEType):

• Source/WebCore/plugins/PluginData.cpp:

(WebCore::isBuiltInPDFPlugIn):

• Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):

• Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTouchCallout):

• Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::relList):

• Source/WebCore/svg/SVGTests.cpp:

(WebCore::SVGTests::hasFeatureForLegacyBindings):

• Source/WebCore/svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

• Source/WebCore/testing/Internals.cpp:

(WebCore::markerTypeFrom):
(WebCore::markerTypesFrom):
(WebCore::Internals::mediaElementHasCharacteristic):
(WebCore::Internals::setCaptionDisplayMode):
(WebCore::Internals::beginMediaSessionInterruption):
(WebCore::Internals::endMediaSessionInterruption):
(WebCore::mediaTypeFromString):
(WebCore::Internals::setMediaSessionRestrictions):
(WebCore::Internals::setMediaElementRestrictions):
(WebCore::Internals::postRemoteControlCommand):
(WebCore::Internals::setAudioContextRestrictions):
(WebCore::Internals::setMockMediaPlaybackTargetPickerState):
(WebCore::Internals::setPageMuted):
(WebCore::Internals::addPrefetchLoadEventListener):

• Source/WebCore/testing/LegacyMockCDM.cpp:

(WebCore::LegacyMockCDM::supportsKeySystem):
(WebCore::LegacyMockCDM::supportsKeySystemAndMimeType):
(WebCore::LegacyMockCDM::supportsMIMEType):

• Source/WebCore/testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::supportsKeySystem):
(WebCore::MockCDM::sanitizeSessionId const):
(WebCore::MockCDMInstance::setServerCertificate):

• Source/WebCore/workers/service/server/SWServer.cpp:

(WebCore::SWServer::canHandleScheme const):

• Source/WebCore/xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createDecoder const):

• Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::shouldAllowExternalLoad):

Canonical link: ​https://commits.webkit.org/250018@main

4:39 PM Changeset in webkit [293483] by commit-queue@webkit.org

• 5 edits in trunk/Tools

Cannot run test-webkitpy, autoinstaller fails to compile lupa
​https://bugs.webkit.org/show_bug.cgi?id=239786

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Jonathan Bedard.

• Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py:
• Tools/Scripts/libraries/reporelaypy/setup.py:
• Tools/Scripts/libraries/resultsdbpy/resultsdbpy/init.py:
• Tools/Scripts/libraries/resultsdbpy/setup.py:

Canonical link: ​https://commits.webkit.org/250017@main

4:15 PM Changeset in webkit [293482] by Alan Coon

• 4 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r292911. rdar://problem/91519558

Parent Mismatch
​https://bugs.webkit.org/show_bug.cgi?id=239390

Reviewed by Simon Fraser.

The oldParent and layer->parent() may be different under certain circumstances.
To account for this, we can just use the layer->parent() and remove the use
of oldParent. This also has the benefit of simplifying the moveLayers() function.

• rendering/RenderElement.cpp: (WebCore::RenderElement::moveLayers):
• rendering/RenderElement.h:
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::insertOnlyThisLayer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:58 PM Changeset in webkit [293481] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Adjust what we consider to be private relayed
​https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.

If a request is not eligible for private relay, then do not consider it having been private relayed.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

3:57 PM Changeset in webkit [293480] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r291968. rdar://problem/91681393

AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
​https://bugs.webkit.org/show_bug.cgi?id=238341

Reviewed by Andres Gonzalez.

The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given range isStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, since isStartOfLine can cause crashes.

Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.

• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:56 PM Changeset in webkit [293479] by Jonathan Bedard

• 2 edits in trunk/Tools

[build.webkit.org] Support identifiers on dashboard (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=239473
<rdar://problem/76852365>

Unreviewed test gardening.

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/index-expected.txt:

Canonical link: ​https://commits.webkit.org/250015@main

3:48 PM Changeset in webkit [293478] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS ] webanimations/accelerated-animation-slot-invalidation.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239791

Unreviewed test gardening.

• LayoutTests/platform/mac/TestExpectations:

Canonical link: ​https://commits.webkit.org/250014@main

3:45 PM Changeset in webkit [293477] by Jonathan Bedard

• 2 edits in trunk/Tools

[ews-build.webkit.org] Support alternative remotes (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/events.py:

(GitHubEventHandlerNoEdits.extractProperties): 'project' is not set by extractProperties.

Canonical link: ​https://commits.webkit.org/250013@main

3:36 PM Changeset in webkit [293476] by Jonathan Bedard

• 6 edits in trunk/Tools

[git-webkit] Checkout PRs from alternate remotes
​https://bugs.webkit.org/show_bug.cgi?id=239745
<rdar://problem/92300209>

Reviewed by Dewei Zhu.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git): The name of the repository is embedded in the argument.
(Git.checkout): Handle remote-postfixed remote names.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:

(Checkout.parser): Add --remote command.
(Checkout.main): Use the full repo name instead of the owner's username.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

(GitHub.PRGenerator.PullRequest): Pass full repo name as metadata.

Canonical link: ​https://commits.webkit.org/250012@main

3:33 PM Changeset in webkit [293475] by Jonathan Bedard

• 6 edits in trunk/Tools

[build.webkit.org] Support identifiers in popover
​https://bugs.webkit.org/show_bug.cgi?id=239773
<rdar://problem/92339575>

Rubber-stamped by Aakash Jain.

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Commits.js:

(Commits): Keep track of all fetched commits.
(Commits.prototype._update): Save fetched commits.
(Commits.prototype.lastNIdentifiers): Return a list of the last n identifiers
on a branch.
(Commits.prototype.fetch): Load information for last N commits.
(Commits.prototype.urlFor): Return a url for a commit ref.

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js: Remove

trac auto-updater.

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/QueueView.js:

(QueueView.prototype._appendPendingRevisionCount): After we determine the
number of commits behind, fetch that many commits.
(QueueView.prototype._popoverLinesForCommitRange): Support commits with identifiers.
(QueueView.prototype._presentPopoverForPendingCommits):

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/MockCommits.js:
• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/tests.js:

Canonical link: ​https://commits.webkit.org/250011@main

3:25 PM Changeset in webkit [293474] by Chris Dumez

• 2 edits in trunk/Source/WebCore/dom

ElementData::setClassNames() can take an r-value reference
​https://bugs.webkit.org/show_bug.cgi?id=239789

Reviewed by Geoffrey Garen.

• Source/WebCore/dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

• Source/WebCore/dom/ElementData.h:

(WebCore::ElementData::setClassNames const):

Canonical link: ​https://commits.webkit.org/250010@main

3:22 PM Changeset in webkit [293473] by ysuzuki@apple.com

• 34 edits in trunk

[JSC] Add forceUnlinkedDFG option
​https://bugs.webkit.org/show_bug.cgi?id=239751

Reviewed by Saam Barati.

This patch adds forceUnlinkedDFG option to start running tests with unlinked DFG (while it is not truly unlinked yet).

• Tools/Scripts/run-jsc-stress-tests:
• Source/JavaScriptCore/jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):

• Source/JavaScriptCore/runtime/OptionsList.h:
• JSTests/stress/arith-abs-on-various-types.js:
• JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js:
• JSTests/stress/arith-acos-on-various-types.js:
• JSTests/stress/arith-acosh-on-various-types.js:
• JSTests/stress/arith-asin-on-various-types.js:
• JSTests/stress/arith-asinh-on-various-types.js:
• JSTests/stress/arith-atan-on-various-types.js:
• JSTests/stress/arith-atanh-on-various-types.js:
• JSTests/stress/arith-cbrt-on-various-types.js:
• JSTests/stress/arith-ceil-on-various-types.js:
• JSTests/stress/arith-clz32-on-various-types.js:
• JSTests/stress/arith-cos-on-various-types.js:
• JSTests/stress/arith-cosh-on-various-types.js:
• JSTests/stress/arith-expm1-on-various-types.js:
• JSTests/stress/arith-floor-on-various-types.js:
• JSTests/stress/arith-fround-on-various-types.js:
• JSTests/stress/arith-log-on-various-types.js:
• JSTests/stress/arith-log10-on-various-types.js:
• JSTests/stress/arith-log2-on-various-types.js:
• JSTests/stress/arith-round-on-various-types.js:
• JSTests/stress/arith-sin-on-various-types.js:
• JSTests/stress/arith-sinh-on-various-types.js:
• JSTests/stress/arith-sqrt-on-various-types.js:
• JSTests/stress/arith-tan-on-various-types.js:
• JSTests/stress/arith-tanh-on-various-types.js:
• JSTests/stress/arith-trunc-on-various-types.js:
• JSTests/stress/fold-multi-get-by-offset-to-get-by-offset-with-watchpoint.js:

Canonical link: ​https://commits.webkit.org/250009@main

3:18 PM Changeset in webkit [293472] by Alan Coon

• 18 edits in branches/safari-613-branch

Revert "Apply patch. rdar://problem/88904160"

3:18 PM Changeset in webkit [293471] by Alan Coon

• 9 edits
  3 adds in branches/safari-613-branch

Cherry-pick r290630. rdar://problem/89442583

AX: WebKit should ignore empty modals rather than trapping focus inside them
​https://bugs.webkit.org/show_bug.cgi?id=237163

Reviewed by Chris Fleizach and Andres Gonzalez.

Source/WebCore:

Given this markup:

<div role="dialog" aria-modal="true">

<div aria-hidden="true">

<button>Close modal (inside modal)</button>

</div>

</div>

There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.

With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.

Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call to ignoredFromModalPresence
out of AccessibilityObject::defaultObjectInclusion, as this function is
downstream of computeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely in AXObjectCache::modalElementHasAccessibleContent.

We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.

Test: accessibility/ignore-modals-without-any-content.html

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
• accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):

LayoutTests:

• accessibility/ignore-modals-without-any-content-expected.txt: Added.
• accessibility/ignore-modals-without-any-content.html: Added.
• platform/glib/TestExpectations: Skip new test.
• platform/ios/TestExpectations: Enable new test.
• platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
• platform/win/TestExpectations: Skip new test.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293470] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/WebCore/ChangeLog

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293469] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r292430. rdar://problem/92204558

[Cocoa] Video is sometimes not visible after r292049
​https://bugs.webkit.org/show_bug.cgi?id=238826

Reviewed by Jer Noble.

RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.

• rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293468] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r293286. rdar://problem/92198272

Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
​https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>

Reviewed by Alan Bujtas.

Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293467] by Alan Coon

• 3 edits in branches/safari-613-branch

Cherry-pick r292274. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
• page/Page.h:
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

• TestExpectations:
• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293466] by Alan Coon

• 5 edits in branches/safari-613-branch/Source/WebKit

Revert "Apply patch. rdar://problem/88904160"

3:18 PM Changeset in webkit [293465] by Alan Coon

• 3 edits in branches/safari-613-branch

Cherry-pick r292274. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
• page/Page.h:
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

• TestExpectations:
• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [293464] by Alan Coon

• 3 edits in branches/safari-613-branch

Cherry-pick r292072. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_attachmentElementClient):
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

LayoutTests:

• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [293463] by Alan Coon

• 5 edits in branches/safari-613-branch/Source/WebKit

Apply patch. rdar://problem/88904160

3:17 PM Changeset in webkit [293462] by Alan Coon

• 18 edits in branches/safari-613-branch

Apply patch. rdar://problem/88904160

3:17 PM Changeset in webkit [293461] by Alan Coon

• 2 edits in branches/safari-613-branch

Cherry-pick r291724. rdar://problem/91975589

Expose the AX tree of PDFs loaded via iframes on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=238168

Reviewed by Chris Fleizach.

Source/WebKit:

Given this markup:

<iframe src="/path/to/paystub.pdf">

An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.

This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.

Test: accessibility/mac/iframe-pdf.html

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):

LayoutTests:

• accessibility/mac/iframe-pdf-expected.txt: Added.
• accessibility/mac/iframe-pdf.html: Added.
• platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [293460] by Alan Coon

• 4 edits in branches/safari-613-branch

Cherry-pick r291589. rdar://problem/90511155

LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

Import web-platform-tests test coverage.

• web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:

Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.

To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.

When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.

Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
• dom/BroadcastChannelRegistry.h:
• loader/EmptyClients.cpp:
• page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):

Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.

To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.

When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.

• WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
• WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:

Source/WebKitLegacy:
Dust off Mac CMake build
​https://bugs.webkit.org/show_bug.cgi?id=238121

Reviewed by Yusuke Suzuki.

• PlatformMac.cmake:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [293459] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r292878. rdar://problem/90248865

ScriptDisallowedScope::isEventAllowedInMainThread assert failure when activating AudioSession
​https://bugs.webkit.org/show_bug.cgi?id=239343

Reviewed by Eric Carlson.

As part of HTMLMediaElement::clearMediaPlayer we call PlatformMediaSession::canProduceAudioChanged
which can result in activating the AudioSession when the page is capturing audio.

This sends a synchronous IPC message to the GPU process. As part of IPC::Connection::waitForSyncReply,
we also end up dispatching enqueued messages, including a WebPage_EndPrinting message that
fires an event listener on the main thread.

This patch will instead queue the PlatformMediaSession::canProduceAudioChanged as a task to avoid
firing the event listener on the main thread, which results in assertion failure.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaPlayer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:17 PM Changeset in webkit [293458] by Alan Coon

• 6 edits in branches/safari-613-branch

Apply patch. rdar://problem/91446317

3:17 PM Changeset in webkit [293457] by Alan Coon

• 6 edits in branches/safari-613-branch

Revert r291606. rdar://problem/91446317

3:17 PM Changeset in webkit [293456] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/WebPageProxy.cpp

Revert "Unreviewed build fix. rdar://91446317"

2:58 PM Changeset in webkit [293455] by Elliott Williams

• 6 edits in trunk/Source

Fix build error: "cp: JavaScriptCore.profdata is not a directory"
​https://bugs.webkit.org/show_bug.cgi?id=239681

Unreviewed build fix.

• Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/250008@main

2:51 PM Changeset in webkit [293454] by Wenson Hsieh

• 4 edits in trunk

Show the option to Markup Image in the callout bar only when appropriate
​https://bugs.webkit.org/show_bug.cgi?id=239779
rdar://88941823

Reviewed by Darin Adler.

Source/WebKit:

Make a minor adjustment to only show this callout bar action in the case where _imageAnalysisMarkupData has
already been computed and cached.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView imageAnalysisMarkupMenu]):

Tools:

Adjust some API tests so that they continue passing after these changes.

• TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::iconImage):
(TestWebKitAPI::simulateCalloutBarAppearance):
(TestWebKitAPI::invokeImageMarkupAction):
(TestWebKitAPI::TEST):
(TestWebKitAPI::runMarkupTest):

2:35 PM Changeset in webkit [293453] by Alan Coon

• 9 edits
  3 deletes in branches/safari-613.2.7.0-branch

Revert r290630. rdar://problem/89442583

This reverts r293440.

2:34 PM Changeset in webkit [293452] by commit-queue@webkit.org

• 2 edits in trunk

Unreviewed, add my @redhat.com email

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26

• metadata/contributors.json:

Canonical link: ​https://commits.webkit.org/250005@main

2:34 PM Changeset in webkit [293451] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ] Thirteen imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=239770

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250005@main

2:30 PM Changeset in webkit [293450] by Alan Coon

• 9 edits
  3 deletes in branches/safari-613.2.7.1-branch

Revert r290630. rdar://problem/89442583

This reverts commit r293439.

2:29 PM Changeset in webkit [293449] by Manuel Rego Casasnovas

• 13 edits in trunk/Source

Remove AriaReflectionEnabled runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=239532

Reviewed by Chris Fleizach.

Source/WebCore:

ARIA reflection shipped in Safari 12.1 (July 2019)
so it looks the runtime flag is not needed anymore.

• accessibility/AccessibilityRole.idl:
• accessibility/AriaAttributes.idl:
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const): Deleted.

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAriaReflectionEnabled): Deleted.
(WKPreferencesGetAriaReflectionEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences ariaReflectionEnabled]): Deleted.
(-[WebPreferences setAriaReflectionEnabled:]): Deleted.

Source/WTF:

• Scripts/Preferences/WebPreferencesInternal.yaml:

2:24 PM Changeset in webkit [293448] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

REGRESSION (r293117): Context menu lift animation encompasses the entire web view
​https://bugs.webkit.org/show_bug.cgi?id=239782
rdar://92342919

Reviewed by Aditya Keerthi.

After r293117, we no longer implement the context menu delegate method for vending a targeted preview when
showing the context menu for a link or image; rename to match the name of the method we implement to match the
name of the UIKit delegate method.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKContentView contextMenuInteraction:configuration:previewForHighlightingItemWithIdentifier:]): Deleted.

2:22 PM Changeset in webkit [293447] by Simon Fraser

• 8 edits in trunk

[ iOS EWS ] css3/background/background-repeat-round-auto2.html is a image failure
​https://bugs.webkit.org/show_bug.cgi?id=238965
<rdar://91454381>

Reviewed by Tim Horton.

Generic shaders can produce slightly different results to optimized shaders, and
get swapped in racily, so disable them for testing on platforms where accelerated
drawing is used.

Tools:

• Scripts/webkitpy/port/base.py:

(Port.port_adjust_environment_for_test_driver):

• Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver):

• Scripts/webkitpy/port/ios.py:

(IOSPort.test_expectations_file_position):
(IOSPort):
(IOSPort.port_adjust_environment_for_test_driver):

• Scripts/webkitpy/port/mac.py:

(MacPort.port_adjust_environment_for_test_driver):

LayoutTests:

• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:

1:02 PM Changeset in webkit [293446] by Jonathan Bedard

• 4 edits in trunk/Tools

[webkit-patch] Use Commit-Queue when landing by default
​https://bugs.webkit.org/show_bug.cgi?id=239777
<rdar://problem/92345543>

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/tool/commands/download.py:

(LandUnsafe): Renamed from LandUnsafe.
(Land): Renamed to LandUnsafe.

• Scripts/webkitpy/tool/commands/download_unittest.py:
• Scripts/webkitpy/tool/commands/upload.py:

(LandSafely):
(Land): Inherit from LandSafely.

Canonical link: ​https://commits.webkit.org/250000@main

1:01 PM Changeset in webkit [293445] by commit-queue@webkit.org

• 8 edits in trunk/JSTests

Several internationalization tests broken with ICU 69.1
​https://bugs.webkit.org/show_bug.cgi?id=239724

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Ross Kirsling and Yusuke Suzuki.

Update these tests to be more permissive of different results for different ICU versions.
ICU 69 on macOS is producing different results from ICU 69 on Linux for reasons unexplained,
so instead of checking the version number, let's instead just accept both ways.

• stress/array-toLocaleString.js:

(shouldBeOneOf):

• stress/date-toLocaleString.js:

(shouldBeOneOf):

• stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:

(shouldBeOneOf):
(vm.icuVersion):
(shouldBeOneOfThem): Deleted.

• stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:

(shouldBeOneOf):

• stress/intl-datetimeformat.js:

(shouldBeOneOf):
(shouldBeOneOfThem): Deleted.

• stress/intl-locale-info.js:

(shouldBeOneOf):
(shouldBe):

• stress/intl-locale.js:

(shouldBeOneOf):

Canonical link: ​https://commits.webkit.org/250000@main

12:44 PM WebKitGTK/2.36.x edited by Michael Catanzaro

(diff)

12:31 PM Changeset in webkit [293444] by Ziran Sun

• 9 edits in trunk

Constructed FormData object should not contain an entry for the submit button that was used to submit the form
​https://bugs.webkit.org/show_bug.cgi?id=239070

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update test expectation as the sub-test is now passing.

• web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:

Source/WebCore:

When the activedSubmit flag is set for a submit button, its value is appended to a FormData. In the case of form
submission called in submit event handler, we include submit button when build FormData. The submit button should
not be included though. This patch correct it by calling set the activatedSubmit flag just before or after building
FormData.

Part of the patch is an import of Chromium CL at
​https://codereview.chromium.org/2340213002

• html/DOMFormData.cpp:

(WebCore::DOMFormData::create):

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::constructEntryList):

• html/HTMLFormElement.h:
• html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

• loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

12:25 PM Changeset in webkit [293443] by Simon Fraser

• 7 edits in trunk

Save a few drawing operations when painting layer contents
​https://bugs.webkit.org/show_bug.cgi?id=239756

Reviewed by Tim Horton.

Remove an extra save/restore, and a translate(0,0) when painting layers and there's just one
dirty rect.

Source/WebCore:

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::PlatformCALayer::drawLayerContents): The caller sets the clip when there's just one
dirty rect.

LayoutTests:

• displaylists/extent-includes-shadow-expected.txt:
• displaylists/layer-dispay-list-expected.txt:
• displaylists/replay-skip-clipped-rect-expected.txt:

12:20 PM Changeset in webkit [293442] by Elliott Williams

• 9 edits in trunk/Source

[Xcode] Compute PGO profdata paths instead of searching for them at build time
​https://bugs.webkit.org/show_bug.cgi?id=239681

Reviewed by Alexey Proskuryakov.

Production builds should always use profdata from the SDK, internal
release builds should use profdata from the local WebKitAdditions, and
everyone else should use the stub profdata. Add a PROFILE_DATA_PATH
build setting which implements these rules and replace the script
phases that checked those paths dynamically.

This fixes XCBuild validation issues in the open-source build, and
should prevent production builders from using stale profdata in
BUILT_PRODUCTS_DIR. Additionally, engineers can now build with custom
profile data by overriding PROFILE_DATA_PATH.

If PROFILE_DATA_PATH does not appear to be raw LLVM profiling data, it
is decoded using compression_tool(1).

• Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
• Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
• Source/WebKit/Configurations/BaseTarget.xcconfig:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/249997@main

11:51 AM Changeset in webkit [293441] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] Initialize m_eglDisplay in PlatformDisplay::PlatformDisplay(GdkDisplay*)
​https://bugs.webkit.org/show_bug.cgi?id=239760

Patch by Xi Ruoyao <​xry111@mengyan1223.wang> on 2022-04-26
Reviewed by Michael Catanzaro.

No new tests because there is no behavior change.

• platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::PlatformDisplay):
initialize m_eglDisplay to EGL_NO_DISPLAY.

11:35 AM Changeset in webkit [293440] by Alan Coon

• 9 edits
  3 adds in branches/safari-613.2.7.0-branch

Cherry-pick r290630. rdar://problem/89442583

AX: WebKit should ignore empty modals rather than trapping focus inside them
​https://bugs.webkit.org/show_bug.cgi?id=237163

Reviewed by Chris Fleizach and Andres Gonzalez.

Source/WebCore:

Given this markup:

<div role="dialog" aria-modal="true">

<div aria-hidden="true">

<button>Close modal (inside modal)</button>

</div>

</div>

There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.

With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.

Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call to ignoredFromModalPresence
out of AccessibilityObject::defaultObjectInclusion, as this function is
downstream of computeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely in AXObjectCache::modalElementHasAccessibleContent.

We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.

Test: accessibility/ignore-modals-without-any-content.html

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
• accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):

LayoutTests:

• accessibility/ignore-modals-without-any-content-expected.txt: Added.
• accessibility/ignore-modals-without-any-content.html: Added.
• platform/glib/TestExpectations: Skip new test.
• platform/ios/TestExpectations: Enable new test.
• platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
• platform/win/TestExpectations: Skip new test.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:33 AM Changeset in webkit [293439] by Alan Coon

• 9 edits
  3 adds in branches/safari-613.2.7.1-branch

Cherry-pick r290630. rdar://problem/89442583

AX: WebKit should ignore empty modals rather than trapping focus inside them
​https://bugs.webkit.org/show_bug.cgi?id=237163

Reviewed by Chris Fleizach and Andres Gonzalez.

Source/WebCore:

Given this markup:

<div role="dialog" aria-modal="true">

<div aria-hidden="true">

<button>Close modal (inside modal)</button>

</div>

</div>

There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.

With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.

Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call to ignoredFromModalPresence
out of AccessibilityObject::defaultObjectInclusion, as this function is
downstream of computeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely in AXObjectCache::modalElementHasAccessibleContent.

We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.

Test: accessibility/ignore-modals-without-any-content.html

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
• accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):

LayoutTests:

• accessibility/ignore-modals-without-any-content-expected.txt: Added.
• accessibility/ignore-modals-without-any-content.html: Added.
• platform/glib/TestExpectations: Skip new test.
• platform/ios/TestExpectations: Enable new test.
• platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
• platform/win/TestExpectations: Skip new test.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:32 AM Changeset in webkit [293438] by Alan Coon

• 9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.4

11:31 AM Changeset in webkit [293437] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ] Six imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=239770

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/249995@main

11:28 AM Changeset in webkit [293436] by Wenson Hsieh

• 11 edits
  2 adds in trunk

Adjust some image transcoding behaviors related to "Copy Cropped Image"
​https://bugs.webkit.org/show_bug.cgi?id=239748
rdar://92287000

Reviewed by Kate Cheney.

Source/WebKit:

Refactor some logic for extracting "cropped images" and "markup images". Currently, we always try to preserve
the MIME type of the source image data, but this causes various issues, such as images losing alpha or failing
to transcode altogether. See below for more details.

Test: ImageAnalysisTests.PerformImageAnalysisMarkupWithWebPImages

• Platform/cocoa/CocoaImage.h:
• Platform/cocoa/CocoaImage.mm:

(WebKit::transcodeWithPreferredMIMEType):

Drop support for the fallbackTypeIdentifier argument, now that nothing depends on it.

• Platform/cocoa/ImageAnalysisUtilities.h:
• Platform/cocoa/ImageAnalysisUtilities.mm:

(WebKit::imageDataForCroppedImageResult):

Add a new helper method to convert a CGImageRef to raw image data that's appropriate for the given source MIME
type. If the type belongs one of a short list of supported types, we use it directly; otherwise, fall back to
"image/png".

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView imageAnalysisMarkupMenu]):
(-[WKContentView actionSheetAssistant:copyCroppedImage:sourceMIMEType:]):

• UIProcess/mac/WebContextMenuProxyMac.mm:

Deploy imageDataForCroppedImageResult in place of directly calling transcodeWithPreferredMIMEType.

(WebKit::WebContextMenuProxyMac::applyMarkupToControlledImage):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):

Tools:

Add an API test to exercise the change.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::runMarkupTest):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/webp-image.html: Added.

11:28 AM Changeset in webkit [293435] by Alan Coon

• 9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.5

11:21 AM Changeset in webkit [293434] by Alan Coon

• 9 edits in branches/safari-613.2.7.3-branch/Source

Versioning.

WebKit-7613.2.7.3.3.

11:16 AM Changeset in webkit [293433] by J Pascoe

• 2 edits in trunk/Source/WebKit

[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
​https://bugs.webkit.org/show_bug.cgi?id=239746
rdar://91981865

Reviewed by Brent Fulgham.

Passing platform in requestTypes breaks the UI in registerations with the syncing platform
authenticator off and local service is unavailable. This patch stops passing it in this case.

• UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::configureRegistrationRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

11:09 AM Changeset in webkit [293432] by J Pascoe

• 2 edits in trunk/Source/WebCore

[WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup"
​https://bugs.webkit.org/show_bug.cgi?id=235894
rdar://88104045

Reviewed by Brent Fulgham.

This change removes a constant with a misspelled variable name after all
downstream usage is removed.

• Modules/webauthn/WebAuthenticationConstants.h:

11:01 AM Changeset in webkit [293431] by Manuel Rego Casasnovas

• 2 edits in trunk

Remove usage of makeWeakPtr() on Introduction.md
​https://bugs.webkit.org/show_bug.cgi?id=239768

Reviewed by Chris Dumez.

• Introduction.md:

9:56 AM Changeset in webkit [293430] by Angelos Oikonomopoulos

• 3 edits in trunk/Tools

Enable --treat-failing-as-flaky for the JSC post-commit bots
​https://bugs.webkit.org/show_bug.cgi?id=239341

Reviewed by Jonathan Bedard.

Try to cover up for a little test flakiness (while still recording
it in resultsdb) to avoid too many false alerts.

• CISupport/build-webkit-org/steps.py:

(RunJavaScriptCoreTests):
(RunJavaScriptCoreTests.start):

• CISupport/build-webkit-org/steps_unittest.py:

9:43 AM Changeset in webkit [293429] by Karl Rackler

• 2 edits in trunk/LayoutTests

[ macOS Debug wk2 ] Four imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=239770

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/249989@main

9:31 AM Changeset in webkit [293428] by Simon Fraser

• 3 edits in trunk/Source/WebKit

Fix crashes under RemoteLayerBackingStore::applyBackingStoreToLayer()
​https://bugs.webkit.org/show_bug.cgi?id=239742
<rdar://91533748>

Reviewed by Wenson Hsieh.

It's possible for ensureBackendCreated() to time out, especially when debugging the GPU
process, in which case RemoteLayerBackingStore can end up with a front buffer with no
backend, which results in an unset m_bufferHandle in the UI process. So add some logging
when this happens, and check the m_bufferHandle optional before accessing its value.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

9:28 AM Changeset in webkit [293427] by Kate Cheney

• 11 edits in trunk

Remove WebArchiveDebugMode
​https://bugs.webkit.org/show_bug.cgi?id=239738
<rdar://problem/88406961>

Reviewed by Tim Horton.

Source/WebCore:

Remove use case of WebArchiveDebugMode and deprecate it now that it
is no longer in use. Add a new temporary flag WebArchiveTestMode
that is more aptly named and will maintain existing behavior for
internal tests temporarily.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebArchiveTestingModeEnabled):
(WKPreferencesGetWebArchiveTestingModeEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setWebArchiveTestingModeEnabled:]):
(-[WKPreferences _webArchiveTestingModeEnabled]):
(-[WKPreferences _setWebArchiveDebugModeEnabled:]):
(-[WKPreferences _webArchiveDebugModeEnabled]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml:

Tools:

• TestWebKitAPI/Tests/mac/LoadWebArchive.mm:

(TestWebKitAPI::TEST):
(TestWebKitAPI::constructArchive):

8:59 AM Changeset in webkit [293426] by Simon Fraser

• 2 edits in trunk/Source/WebKit

Add object addresses to IPC logging
​https://bugs.webkit.org/show_bug.cgi?id=239754

Reviewed by Cameron McCormack.

It's useful if IPC logging shows the receiver address, so you can distinguish different
receivers.

• Platform/IPC/HandleMessage.h:

(IPC::textStreamForLogging):
(IPC::logMessageImpl):
(IPC::logMessage):
(IPC::logReply):
(IPC::handleMessage):
(IPC::handleMessageWantsConnection):
(IPC::handleMessageSynchronous):
(IPC::handleMessageSynchronousWantsConnection):
(IPC::handleMessageAsync):
(IPC::handleMessageAsyncWantsConnection):

8:51 AM Changeset in webkit [293425] by youenn@apple.com

• 8 edits in trunk/Source/WebKit

REGRESSION(r288464?):[ iOS15 Release GPUP arm64 ] TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureGetUserMediaAudioCase is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=237854
<rdar://problem/90273222>

Reviewed by Eric Carlson.

stopProducingData was called on some ended tracks.
This would trigger the creation of a new connection in case GPUProcess is gone.
To prevent this, we now keep a connection reference in RemoteRealtimeMediaSourceProxy.
When the GPUProcess connection is being closed, we update the connection if the track is to be continued.

Covered by API test.

• WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
• WebProcess/cocoa/RemoteCaptureSampleManager.h:
• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
• WebProcess/cocoa/RemoteRealtimeMediaSource.h:
• WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
• WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
• WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:

8:35 AM Changeset in webkit [293424] by Chris Dumez

• 2 edits in trunk/LayoutTests

http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=239630
<rdar://92128154>

Reviewed by Youenn Fablet.

We get an error when closing the websocket. The error gets queued up on the event loop and
may or may not get processed before the test ends, leading to flakiness. The test is actually
about testing bufferedAmount after closing the socket and this part is still being tested and
reliably passing. As a result, I am simply silencing the error in the test to address the
flakiness.

• LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/249984@main

7:28 AM Changeset in webkit [293423] by Jonathan Bedard

• 2 edits in trunk/Tools

[ews-build.webkit.org] Specify repository when sending emails
​https://bugs.webkit.org/show_bug.cgi?id=239739
<rdar://problem/92291225>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(GitHubMixin.should_send_email_for_pr): Pass repository URL.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.

Canonical link: ​https://commits.webkit.org/249983@main

4:01 AM Changeset in webkit [293422] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[DatabaseTracker] Use PRIu64 for logging for portability
​https://bugs.webkit.org/show_bug.cgi?id=239765

Reviewed by Adrian Perez de Castro.

Use PRIu64 when logging to avoid warnings.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setQuota):

3:59 AM Changeset in webkit [293421] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[GStreamer] Mark unused variable
​https://bugs.webkit.org/show_bug.cgi?id=239766

Reviewed by Adrian Perez de Castro.

• platform/mock/MockRealtimeMediaSourceCenter.cpp:

3:29 AM Changeset in webkit [293420] by commit-queue@webkit.org

• 4 edits in trunk/Source/ThirdParty/ANGLE

Update test_expectations, run_code_generation.py, angle_unittests.gni from ANGLE upstream
​https://bugs.webkit.org/show_bug.cgi?id=239645

Unreviewed, reproducible with Tools/Scripts/update-angle --regenerate-changes-diff

These are not changed in downstream but the changes are due to stale merges.
Reduces the changes.diff

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-26

• changes.diff:
• scripts/run_code_generation.py:

(main):

• src/tests/angle_unittests.gni:
• src/tests/deqp_support/deqp_egl_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_egl_TestExpectations.
• src/tests/deqp_support/deqp_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles2_TestExpectations.
• src/tests/deqp_support/deqp_gles31_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_rotate_TestExpectations.
• src/tests/deqp_support/deqp_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_TestExpectations.
• src/tests/deqp_support/deqp_gles3_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_rotate_TestExpectations.
• src/tests/deqp_support/deqp_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_TestExpectations.
• src/tests/deqp_support/deqp_khr_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles2_TestExpectations.
• src/tests/deqp_support/deqp_khr_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles31_TestExpectations.
• src/tests/deqp_support/deqp_khr_gles32_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles32_TestExpectations.
• src/tests/deqp_support/deqp_khr_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles3_TestExpectations.

1:15 AM Changeset in webkit [293419] by commit-queue@webkit.org

• 8 edits
  1 add in trunk/Tools/buildstream

[Flatpak SDK] Partial revert of r249480
​https://bugs.webkit.org/show_bug.cgi?id=239700

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-26
Reviewed by Adrian Perez de Castro.

The switch to upstream gtk3 recipe broke something related with icons handling and
introduced a crash in media/video-controls-drag.html. For the time being, revert to our
custom recipe.

This patch also updates the pipenv environment used to build the SDK, to BuildStream 1.6.5.

• Pipfile:
• Pipfile.lock:
• elements/qt5/qtbase.bst:
• elements/sdk-platform.bst:
• elements/sdk/adwaita-icon-theme.bst:
• elements/sdk/gst-plugins-base.bst:
• elements/sdk/gst-plugins-good.bst:
• elements/sdk/gtk+-3.bst: Added.

Canonical link: ​https://commits.webkit.org/249979@main

12:34 AM Changeset in webkit [293418] by youenn@apple.com

• 9 edits in trunk

Service Worker loads should not expose some ResourceTiming information
​https://bugs.webkit.org/show_bug.cgi?id=239608

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/resource-timing-fetch-variants.https-expected.txt:

Source/WebCore:

Filter out some resource timing info when the load is served from a service worker.
While we could do the filtering on service worker side, it is best to do it within PerformanceResourceTiming
as native clients might still want to use non filtered data in case the service worker is returning a network load
as the response.

Covered by rebased test.

• loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::ResourceTiming):

• loader/ResourceTiming.h:

(WebCore::ResourceTiming::isLoadedFromServiceWorker const):

• page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::nextHopProtocol const):
(WebCore::PerformanceResourceTiming::redirectStart const):
(WebCore::PerformanceResourceTiming::redirectEnd const):
(WebCore::PerformanceResourceTiming::domainLookupStart const):
(WebCore::PerformanceResourceTiming::domainLookupEnd const):
(WebCore::PerformanceResourceTiming::connectStart const):
(WebCore::PerformanceResourceTiming::connectEnd const):

• page/PerformanceResourceTiming.h:

(WebCore::PerformanceResourceTiming::isLoadedFromServiceWorker const):

LayoutTests:

• TestExpectations:

Apr 25, 2022:

11:57 PM Changeset in webkit [293417] by youenn@apple.com

• 6 edits in trunk

Service workers should not intercept embed/object related loads
​https://bugs.webkit.org/show_bug.cgi?id=239642

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/embed-and-object-are-not-intercepted.https-expected.txt:

Source/WebCore:

In case document loader or image loader are triggered by embed/object elements,
set service worker mode to none.

Covered by rebased test.

• loader/DocumentLoader.cpp:
• loader/DocumentLoader.h:
• loader/ImageLoader.cpp:

11:43 PM Changeset in webkit [293416] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.2.3

Tag WebKit-7613.2.7.2.3.

11:41 PM Changeset in webkit [293415] by Russell Epstein

• 9 edits in branches/safari-613.2.7.2-branch/Source

Versioning.

WebKit-7613.2.7.2.2

11:36 PM Changeset in webkit [293414] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.1.4

Tag WebKit-7613.2.7.1.4.

11:34 PM Changeset in webkit [293413] by Russell Epstein

• 9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.4

11:31 PM Changeset in webkit [293412] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.0.3

Tag WebKit-7613.2.7.0.3.

11:28 PM Changeset in webkit [293411] by Russell Epstein

• 9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.3

9:49 PM Changeset in webkit [293410] by Aditya Keerthi

• 4 edits in trunk

[iOS] Add NSCoding support for findInteractionEnabled
​https://bugs.webkit.org/show_bug.cgi?id=239733
rdar://87850648

Reviewed by Wenson Hsieh.

Source/WebKit:

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithCoder:]):
(-[WKWebView encodeWithCoder:]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:

(TEST):

9:07 PM Changeset in webkit [293409] by Devin Rousso

• 31 edits
  3 adds
  2 deletes in trunk

Web Inspector: add UI for blocking requests
​https://bugs.webkit.org/show_bug.cgi?id=239674

Reviewed by Patrick Angle.

Source/WebCore:

Test: http/tests/inspector/network/intercept-request-with-error.html

• inspector/agents/InspectorNetworkAgent.h:

(WebCore::InspectorNetworkAgent::errorDomain): Added.

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::toResourceErrorType): Added.
(WebCore::InspectorNetworkAgent::interceptRequestWithError):
Unify the resource error message for consistency.
Mark the resource error as coming from Web Inspector so that it can identified (see below).

• inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::didFailLoading):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::logErrorAndFail):

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail):
Don't add console messages for requests that were blocked by Web Inspector.

• inspector/agents/page/PageNetworkAgent.h:
• inspector/agents/page/PageNetworkAgent.cpp:

(WebCore::PageNetworkAgent::addConsoleMessage): Added.

• inspector/agents/worker/WorkerNetworkAgent.h:
• inspector/agents/worker/WorkerNetworkAgent.cpp:

(WebCore::WorkerNetworkAgent::addConsoleMessage): Added.
Add a virtual method so that InspectorNetworkAgent can log to the console (PageNetworkAgent
uses the Page, WorkerNetworkAgent uses the WorkerOrWorkletGlobalScope, etc.).

Source/WebInspectorUI:

• UserInterface/Models/LocalResourceOverride.js:

(WI.LocalResourceOverride):
(WI.LocalResourceOverride.create):
(WI.LocalResourceOverride.displayNameForNetworkStageOfType): Added.
(WI.LocalResourceOverride.displayNameForType):
(WI.LocalResourceOverride.displayNameForResourceErrorType): Added.
(WI.LocalResourceOverride.fromJSON):
(WI.LocalResourceOverride.prototype.toJSON):
(WI.LocalResourceOverride.prototype.get resourceErrorType): Added.
(WI.LocalResourceOverride.prototype.set resourceErrorType): Added.
(WI.LocalResourceOverride.prototype.get canMapToFile):
Add WI.LocalResourceOverride.ResourceErrorType (and a corresponding member variable) that
is be used when blocking matching requests.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.supportsBlockingRequests): Added.
(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype._handleResourceOverrideResourceErrorTypeChanged): Added.
Make sure to save WI.LocalResourceOverride.InterceptType.Block whenever the
WI.LocalResourceOverride.ResourceErrorType changes.

• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

• UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView):
(WI.ResourceContentView.prototype._populateCreateLocalResourceOverrideContextMenu):
(WI.ResourceContentView.prototype._handleCreateLocalResourceOverride): Deleted.
Add contextmenu items for "Block Request URL".

• UserInterface/Views/LocalResourceOverrideRequestContentView.js:

(WI.LocalResourceOverrideRequestContentView):
(WI.LocalResourceOverrideRequestContentView.prototype.initialLayout):
(WI.LocalResourceOverrideRequestContentView.prototype.initialLayout.addOption): Added.

• UserInterface/Views/LocalResourceOverrideRequestContentView.css:

(.content-view.text.local-resource-override-request > .message-text-view select): Added.
There will be no request or response content for WI.LocalResourceOverride.InterceptType.Block
so show a <select> for choosing the WI.LocalResourceOverride.ResourceErrorType.

• UserInterface/Views/LocalResourceOverridePopover.js:

(WI.LocalResourceOverridePopover.prototype.get serializedData):
(WI.LocalResourceOverridePopover.prototype.show):

• UserInterface/Views/LocalResourceOverridePopover.css:

(.popover .local-resource-override-popover-content:is(.response, .block) .editor.url): Renamed from .popover .local-resource-override-popover-content.response .editor.url.
Only show the URL editor for WI.LocalResourceOverride.InterceptType.Block.

• UserInterface/Models/Resource.js:

(WI.Resource.classNamesForResource):

• UserInterface/Views/ResourceTreeElement.js:

(WI.ResourceTreeElement.prototype._updateResource):
(WI.ResourceTreeElement.prototype._updateIcon):
(WI.ResourceTreeElement.prototype._loadingDidFail): Added.

• UserInterface/Views/ResourceIcons.css:

(.resource-icon.override.skip-network .icon): Added.
(body:not(.window-inactive, .window-docked-inactive) :is(.table, .data-grid):focus-within .selected .resource-icon.override.skip-network .icon, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .selected.resource-icon.override.skip-network .icon): Added.
(@media (prefers-color-scheme: dark) .resource-icon.override.skip-network .icon): Added.

• UserInterface/Images/SkipNetwork.svg: Added.

Add a new icon for when requests do not involve any network activity.

• UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):

• UserInterface/Views/FontResourceContentView.js:

(WI.FontResourceContentView.prototype.dropZoneShouldAppearForDragEvent):

• UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView.prototype.dropZoneShouldAppearForDragEvent):

• UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):
Use positive checks for the desired WI.LocalResourceOverride.InterceptType instead of
a negative check for the one value meant to be exlucded in the expectation that no new
enum values would get added (which this patch proves to be false).

• UserInterface/Views/LocalResourceOverrideLabelView.js:

(WI.LocalResourceOverrideLabelView.prototype.initialLayout):
Use the new WI.LocalResourceOverride.displayNameForNetworkStageOfType instead of doing
that work here.

• Localizations/en.lproj/localizedStrings.js:

LayoutTests:

• http/tests/inspector/network/intercept-request-with-error.html: Added.
• http/tests/inspector/network/intercept-request-with-error-expected.txt: Added.
• inspector/network/interceptRequestWithError.html: Removed.
• inspector/network/interceptRequestWithError-expected.txt: Removed.
• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:

Reworked this test to use WI.LocalResourceOverride instead of the protocol.

8:53 PM Changeset in webkit [293408] by Elliott Williams

• 2 edits in trunk/Source/WebKit

[XCBuild] Refactor WebKit resources to emit output tasks for dependency validation
​https://bugs.webkit.org/show_bug.cgi?id=239556

Reviewed by Alexey Proskuryakov.

• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
  • Replace the script phase that calls generate-automation-atom.py with a build rule, and process those files as headers.
  • Clean up references and project metadata for deleted files.
  • Use WK_FRAMEWORK_VERSION_PREFIX in script output paths so that the realpaths are correct on macOS.

Canonical link: ​https://commits.webkit.org/249974@main

7:16 PM Changeset in webkit [293407] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.3.2

Tag WebKit-7613.2.7.3.2.

7:14 PM Changeset in webkit [293406] by Alan Coon

• 1 edit in branches/safari-613.2.7.3-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

7:13 PM Changeset in webkit [293405] by Alan Coon

• 9 edits in branches/safari-613.2.7.3-branch/Source

Versioning.

WebKit-7613.2.7.3.2

7:06 PM Changeset in webkit [293404] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.0.2

Tag WebKit-7613.2.7.0.2.

7:03 PM Changeset in webkit [293403] by Alan Coon

• 1 edit in branches/safari-613.2.7.0-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

7:03 PM Changeset in webkit [293402] by Alan Coon

• 1 edit in branches/safari-613.2.7.0-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

7:03 PM Changeset in webkit [293401] by Alan Coon

• 112 edits
  5 deletes in branches/safari-613.2.7.0-branch/Source

Apply patch. rdar://problem/67069953

6:55 PM Changeset in webkit [293400] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.1.3

Tag WebKit-7613.2.7.1.3.

6:49 PM Changeset in webkit [293399] by Alan Coon

• 1 edit in branches/safari-613.2.7.1-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:49 PM Changeset in webkit [293398] by Alan Coon

• 1 edit in branches/safari-613.2.7.1-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:49 PM Changeset in webkit [293397] by Alan Coon

• 112 edits
  5 deletes in branches/safari-613.2.7.1-branch/Source

Apply patch. rdar://problem/67069953

6:44 PM Changeset in webkit [293396] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.2.1

Tag WebKit-7613.2.7.2.1.

6:41 PM Changeset in webkit [293395] by Alan Coon

• 1 delete in tags/WebKit-7613.2.7.2.1

Delete tag.

6:40 PM Changeset in webkit [293394] by Alan Coon

• 1 edit in branches/safari-613.2.7.2-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:36 PM Changeset in webkit [293393] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

structureIDToStructureWithScratch should only do things if ADDRESS64
​https://bugs.webkit.org/show_bug.cgi?id=239749

Reviewed by Saam Barati.

• llint/LowLevelInterpreter64.asm:

6:31 PM Changeset in webkit [293392] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:22 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:20 PM BuildingCairoOnWindows edited by Fujii Hironori

(diff)

6:16 PM Changeset in webkit [293391] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:13 PM Changeset in webkit [293390] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.2.1

Tag WebKit-7613.2.7.2.1.

6:09 PM Changeset in webkit [293389] by Alan Coon

• 1 edit in branches/safari-613.2.7.2-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:09 PM Changeset in webkit [293388] by Alan Coon

• 112 edits
  5 deletes in branches/safari-613.2.7.2-branch/Source

Apply patch. rdar://problem/67069953

6:02 PM Changeset in webkit [293387] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.3.1

Tag WebKit-7613.2.7.3.1.

6:00 PM Changeset in webkit [293386] by Alan Coon

• 1 edit in branches/safari-613.2.7.3-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

6:00 PM Changeset in webkit [293385] by Alan Coon

• 112 edits
  5 deletes in branches/safari-613.2.7.3-branch/Source

Apply patch. rdar://problem/67069953

5:57 PM Changeset in webkit [293384] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/JavaScriptCore/API/JSTypedArray.cpp

Apply patch. rdar://67069953

5:41 PM Changeset in webkit [293383] by Alan Coon

• 112 edits
  5 deletes in branches/safari-613-branch/Source

Apply patch. rdar://problem/67069953

5:25 PM Changeset in webkit [293382] by Jonathan Bedard

• 3 edits in trunk/Tools

[Merge-Queue] Differentiate gardening commits in bug comments
​https://bugs.webkit.org/show_bug.cgi?id=239740
<rdar://problem/92293298>

Reviewed by Ryan Haddad.

• Tools/CISupport/ews-build/steps.py:

(DetermineLandedIdentifier.comment_text_for_bug):

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/249972@main

5:21 PM Changeset in webkit [293381] by Jonathan Bedard

• 2 edits in trunk/Tools

GitHub EWS is confused with prior PR's merge-blocked label
​https://bugs.webkit.org/show_bug.cgi?id=239411
<rdar://problem/92196846>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(BlockPullRequest.start): Only apply blocked label if tested hash and current hash match.

Canonical link: ​https://commits.webkit.org/249971@main

5:16 PM Changeset in webkit [293380] by Brent Fulgham

• 6 edits in trunk/Source/WebKit

HARDENING: Add MESSAGE_CHECK in some Captive Portal cases
​https://bugs.webkit.org/show_bug.cgi?id=239551
<rdar://91478748>

Reviewed by Darin Adler.

Add MESSAGE_CHECK protections to a set of message handlers for API prohibited when
sent from a Captive Portal process. This change also adds a flag to the GPUProcessConnectionParameters
struct so that GPU Process connections can be marked as being associated with a Captive Portal
process.

• GPUProcess/GPUConnectionToWebProcess.cpp:

(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::createGraphicsContextGL):
(WebKit::GPUConnectionToWebProcess::releaseGraphicsContextGL):

• GPUProcess/GPUConnectionToWebProcess.h:

(WebKit::GPUConnectionToWebProcess::isCaptivePortalModeEnabled const):

• GPUProcess/media/RemoteAudioDestinationManager.cpp:

(WebKit::RemoteAudioDestinationManager::createAudioDestination):
(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):
(WebKit::RemoteAudioDestinationManager::startAudioDestination):
(WebKit::RemoteAudioDestinationManager::stopAudioDestination):

• Shared/GPUProcessConnectionParameters.h:

(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getGPUProcessConnection):

5:12 PM Changeset in webkit [293379] by Chris Dumez

• 8 edits in trunk/Source

Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function
​https://bugs.webkit.org/show_bug.cgi?id=239728

Reviewed by Darin Adler.

Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function, to complement
the existing makeStringByReplacingAll(const String&, UChar, UChar). This allows several
call sites to avoid a temporary String constructing since they have a StringView.

• Source/WebCore/PAL/pal/text/TextCodecICU.cpp:

(PAL::TextCodecICU::encode const):

• Source/WTF/wtf/URLParser.cpp:

(WTF::URLParser::parseURLEncodedForm):

• Source/WTF/wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):

• Source/WTF/wtf/text/StringImpl.h:

(WTF::StringImpl::createByReplacingInCharacters):

• Source/WTF/wtf/text/StringView.cpp:

(WTF::makeStringByReplacingAll):

• Source/WTF/wtf/text/StringView.h:
• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::queryKeysAndValues):

• Source/WebCore/editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedString):

Canonical link: ​https://commits.webkit.org/249969@main

5:03 PM Changeset in webkit [293378] by Russell Epstein

• 1 edit in branches/safari-613-branch/Source/WebCore/page/Page.cpp

Unreviewed build fix. rdar://80544133

./page/Page.cpp:389:9: error: incomplete type 'WebCore::FontCache' named in nested name specifier

5:03 PM Changeset in webkit [293377] by Russell Epstein

• 3 edits in branches/safari-613-branch

Cherry-pick r292274. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
• page/Page.h:
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

• TestExpectations:
• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293376] by Russell Epstein

• 3 edits in branches/safari-613-branch

Cherry-pick r292274. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
• page/Page.h:
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

• TestExpectations:
• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293375] by Russell Epstein

• 4 edits
  2 adds in branches/safari-613-branch

Cherry-pick r291724. rdar://problem/91975589

Expose the AX tree of PDFs loaded via iframes on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=238168

Reviewed by Chris Fleizach.

Source/WebKit:

Given this markup:

<iframe src="/path/to/paystub.pdf">

An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.

This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.

Test: accessibility/mac/iframe-pdf.html

• WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):

LayoutTests:

• accessibility/mac/iframe-pdf-expected.txt: Added.
• accessibility/mac/iframe-pdf.html: Added.
• platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293374] by Russell Epstein

• 2 edits in branches/safari-613-branch

Apply patch. rdar://problem/91590827

5:02 PM Changeset in webkit [293373] by Russell Epstein

• 10 edits in branches/safari-613-branch

Apply patch. rdar://problem/91288849

5:02 PM Changeset in webkit [293372] by Russell Epstein

• 20 edits
  3 adds in branches/safari-613-branch

Cherry-pick r291589. rdar://problem/90511155

LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

Import web-platform-tests test coverage.

• web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
• web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
• web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:

Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.

To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.

When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.

Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html

• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
• dom/BroadcastChannelRegistry.h:
• loader/EmptyClients.cpp:
• page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):

Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
​https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>

Reviewed by Alex Christensen.

The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.

To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.

When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.

• WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
• WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:

Source/WebKitLegacy:
Dust off Mac CMake build
​https://bugs.webkit.org/show_bug.cgi?id=238121

Reviewed by Yusuke Suzuki.

• PlatformMac.cmake:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293371] by Russell Epstein

• 11 edits in branches/safari-613-branch

Cherry-pick r292274. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
• page/Page.h:
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

Tools:

Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
• WebKitTestRunner/InjectedBundle/InjectedBundle.h:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):

LayoutTests:

• TestExpectations:
• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk2/TestExpectations:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293370] by Russell Epstein

• 8 edits
  2 adds in branches/safari-613-branch

Cherry-pick r292072. rdar://problem/80544133

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp: (WebCore::m_attachmentElementClient):
• platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
• platform/graphics/FontCache.h:

LayoutTests:

• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:02 PM Changeset in webkit [293369] by Russell Epstein

• 2 edits in branches/safari-613-branch/Source

Apply patch. rdar://problem/90968687

4:14 PM Changeset in webkit [293368] by Devin Rousso

• 9 edits in trunk/Source

Web Inspector: request interception should not be guarded based on service workers
​https://bugs.webkit.org/show_bug.cgi?id=239677

Reviewed by Patrick Angle.

Source/WebCore:

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::shouldInterceptRequest):
(WebCore::InspectorInstrumentation::interceptRequest):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldInterceptRequestImpl):

• inspector/InspectorInstrumentationWebKit.h:

(WebCore::InspectorInstrumentationWebKit::shouldInterceptRequest):
(WebCore::InspectorInstrumentationWebKit::interceptRequest):

• inspector/InspectorInstrumentationWebKit.cpp:

(WebCore::InspectorInstrumentationWebKit::shouldInterceptRequestInternal):
Pass along ResourceLoader instead of ResourceRequest so that InspectorNetworkAgent::shouldInterceptRequest
can look at the configuration of the load (e.g. serviceWorkerRegistrationIdentifier), not
just the request configuration.

• inspector/agents/InspectorNetworkAgent.h:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::shouldInterceptRequest):
Move the #if ENABLE(SERVICE_WORKER) here.

Source/WebKit:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
Move the #if ENABLE(SERVICE_WORKER) to WebCore::InspectorNetworkAgent::shouldInterceptRequest.

3:56 PM Changeset in webkit [293367] by Devin Rousso

• 4 edits
  2 adds in trunk

Web Inspector: crash when a subresource is intercepted by a skip network local override with an error status code
​https://bugs.webkit.org/show_bug.cgi?id=239675

Reviewed by Patrick Angle.

Source/WebCore:

Test: http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code.html

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):
SubresourceLoader::didReceiveResponse will eventually cause releaseResources (via cancel),
which will clear the m_resource, which is needed in order to provide the response content.
We should only provide the response content if we're still processing the load.

LayoutTests:

• http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code.html: Added.
• http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code-expected.txt: Added.

• platform/mac-wk1/TestExpectations:

3:55 PM Changeset in webkit [293366] by Russell Epstein

• 3 edits in branches/safari-614.1.11-branch/Source/WebKit

Cherry-pick r293339. rdar://problem/92283605

Fix the tvOS and watchOS builds after r293231
​https://bugs.webkit.org/show_bug.cgi?id=239736
rdar://92283605

Reviewed by Wenson Hsieh.

• UIProcess/API/Cocoa/WKWebView.h:

UIFindInteraction is marked unavailable on watchOS and tvOS.

• UIProcess/API/Cocoa/WKWebView.mm:

Use platform-checks rather than the existing HAVE macro, so that these
methods are still implemented in older builds. There are no version
checks in WKWebView.h.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:45 PM Changeset in webkit [293365] by Russell Epstein

• 1 copy in branches/safari-614.1.11-branch

New branch.

3:44 PM Changeset in webkit [293364] by Russell Epstein

• 9 edits in trunk/Source

Versioning.

WebKit-7614.1.12

3:24 PM Changeset in webkit [293363] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the macOS Monterey build after r293340
​https://bugs.webkit.org/show_bug.cgi?id=239712

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

Put some of the "Copy Cropped Image" logic here behind ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS), instead of just
ENABLE(IMAGE_ANALYSIS).

3:03 PM Changeset in webkit [293362] by Alan Coon

• 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore

Cherry-pick r291968. rdar://problem/91681393

AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
​https://bugs.webkit.org/show_bug.cgi?id=238341

Reviewed by Andres Gonzalez.

The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given range isStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, since isStartOfLine can cause crashes.

Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.

• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:03 PM Changeset in webkit [293361] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore

Cherry-pick r291968. rdar://problem/91681393

AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
​https://bugs.webkit.org/show_bug.cgi?id=238341

Reviewed by Andres Gonzalez.

The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given range isStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, since isStartOfLine can cause crashes.

Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.

• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:35 PM Changeset in webkit [293360] by Alan Coon

• 2 edits in branches/safari-613.2.7.3-branch/Source/WebCore

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:35 PM Changeset in webkit [293359] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.9.7

Tag WebKit-7614.1.9.7.

2:33 PM Changeset in webkit [293358] by Alan Coon

• 9 edits in branches/safari-613.2.7.3-branch/Source

Versioning.

WebKit-7613.2.7.3.1

2:28 PM Changeset in webkit [293357] by Alan Coon

• 2 edits in branches/safari-613.2.7.2-branch/Source/WebCore

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:27 PM Changeset in webkit [293356] by Alan Coon

• 9 edits in branches/safari-613.2.7.2-branch/Source

Versioning.

WebKit-7613.2.7.2.1

2:25 PM Changeset in webkit [293355] by Russell Epstein

• 9 edits in branches/safari-614.1.9-branch/Source

Versioning.

WebKit-7614.1.9.7

2:24 PM Changeset in webkit [293354] by Alan Coon

• 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:18 PM Changeset in webkit [293353] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore

Revert r293286. rdar://problem/92198272

This reverts r293343.

2:18 PM Changeset in webkit [293352] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore

Cherry-pick r290860. rdar://problem/89291570

AX: Protect incoming object with Ref in AXObjectCache::textChanged
​https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:59 PM Changeset in webkit [293351] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.9.6

Tag WebKit-7614.1.9.6.

1:59 PM Changeset in webkit [293350] by Alan Coon

• 9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.3

1:57 PM Changeset in webkit [293349] by Russell Epstein

• 9 edits in branches/safari-614.1.9-branch/Source

Versioning.

WebKit-7614.1.9.6

1:55 PM Changeset in webkit [293348] by ysuzuki@apple.com

• 8 edits in trunk

[JSC] Enable change-array-by-copy
​https://bugs.webkit.org/show_bug.cgi?id=239678

Reviewed by Saam Barati.

• Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: ​https://commits.webkit.org/249964@main

1:52 PM Changeset in webkit [293347] by Alan Coon

• 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore

Cherry-pick r292430. rdar://problem/92204558

[Cocoa] Video is sometimes not visible after r292049
​https://bugs.webkit.org/show_bug.cgi?id=238826

Reviewed by Jer Noble.

RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.

• rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:52 PM Changeset in webkit [293346] by Alan Coon

• 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore

Cherry-pick r293286. rdar://problem/92198272

Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
​https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>

Reviewed by Alan Bujtas.

Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:49 PM Changeset in webkit [293345] by Chris Fleizach

• 6 edits
  2 adds in trunk

AX: Don't expose aria-roledescription value on "generic" elements (e.g. div and span) unless explicit role value is also defined
​https://bugs.webkit.org/show_bug.cgi?id=174248
<rdar://problem/33178050>

Reviewed by Andres Gonzalez.

Source/WebCore:

ARIA spec states to not expose the role description on "generic" elements.
​https://www.w3.org/TR/wai-aria/#aria-roledescription

Test: accessibility/ignored-aria-role-description.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIARoleDescription const):
(WebCore::AccessibilityObject::roleDescription const):

• accessibility/AccessibilityObject.h:

LayoutTests:

• accessibility/ignored-aria-role-description-expected.txt: Added.
• accessibility/ignored-aria-role-description.html: Added.

1:48 PM Changeset in webkit [293344] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore

Cherry-pick r292430. rdar://problem/92204558

[Cocoa] Video is sometimes not visible after r292049
​https://bugs.webkit.org/show_bug.cgi?id=238826

Reviewed by Jer Noble.

RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.

• rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:44 PM Changeset in webkit [293343] by Alan Coon

• 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore

Cherry-pick r293286. rdar://problem/92198272

Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
​https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>

Reviewed by Alan Bujtas.

Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.

• page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:36 PM Changeset in webkit [293342] by Alan Coon

• 9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.2

1:09 PM Changeset in webkit [293341] by timothy_horton@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Fix duplicate headers warning in libwebrtc Copy Headers phase
​https://bugs.webkit.org/show_bug.cgi?id=239415

Reviewed by Sam Weinig.

• libwebrtc.xcodeproj/project.pbxproj:

Remove and re-add these files (Xcode won't delete just one copy of them,
because they have the same identifiers).

1:00 PM Changeset in webkit [293340] by Wenson Hsieh

• 5 edits in trunk/Source/WebKit

[macOS] Only show a context menu action to "Copy Cropped Image" when appropriate
​https://bugs.webkit.org/show_bug.cgi?id=239712
rdar://92239384

Reviewed by Darin Adler.

Implement gating for the "Copy Cropped Image" context menu item. This is similar to the current gating mechanism
used for visual look up, wherein the Look Up menu item is asynchronously appended to the context menu.

In this case, we only append the "Copy Cropped Image" menu item in the case where requestImageAnalysisMarkup
completes with a non-null result.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):

• UIProcess/WebPageProxy.h:

Cache the image analysis results for "Copy Cropped Image" in a member variable, m_croppedImageForContextMenu.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setCroppedImageForContextMenu):
(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):

12:58 PM Changeset in webkit [293339] by Aditya Keerthi

• 3 edits in trunk/Source/WebKit

Fix the tvOS and watchOS builds after r293231
​https://bugs.webkit.org/show_bug.cgi?id=239736
rdar://92283605

Reviewed by Wenson Hsieh.

• UIProcess/API/Cocoa/WKWebView.h:

UIFindInteraction is marked unavailable on watchOS and tvOS.

• UIProcess/API/Cocoa/WKWebView.mm:

Use platform-checks rather than the existing HAVE macro, so that these
methods are still implemented in older builds. There are no version
checks in WKWebView.h.

12:54 PM Changeset in webkit [293338] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: response overrides with an error status code should indicate that somewhere
​https://bugs.webkit.org/show_bug.cgi?id=239676

Reviewed by Patrick Angle.

• UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.updateStatus):
Also have the WI.LocalResourceOverrideTreeElement add/remove the "error" CSS class
depening on the state of the related WI.LocalResource (which is what's done for "regular"
WI.ResourceTreeElement and WI.Resource).

12:09 PM Changeset in webkit [293337] by ntim@apple.com

• 4 edits in trunk/Source/WebCore

Unprefix html.css, fullscreen.css and pdfjs-extras
​https://bugs.webkit.org/show_bug.cgi?id=239725

Reviewed by Brent Fulgham.

Use unprefixed versions of CSS values & properties.
Excluded text-align: -webkit-center which has different behavior than text-align: center.

• Modules/pdfjs-extras/adwaita/style.css:

(.dropdownToolbarButton > select):

• css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

• css/html.css:

(input, textarea, select, button, meter, progress):
(#if defined(ENABLE_DATE_AND_TIME_INPUT_TYPES) && ENABLE_DATE_AND_TIME_INPUT_TYPES):
(input::-webkit-credentials-auto-fill-button):
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-credit-card-auto-fill-button):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):

11:49 AM Changeset in webkit [293336] by Alan Coon

• 1 copy in tags/WebKit-7613.2.7.1.2

Tag WebKit-7613.2.7.1.2.

11:33 AM Changeset in webkit [293335] by Alan Coon

• 9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.2

11:29 AM Changeset in webkit [293334] by ntim@apple.com

• 59 edits in trunk/Source/WebInspectorUI

Web Inspector: Unprefix CSS properties in source code
​https://bugs.webkit.org/show_bug.cgi?id=239517

Reviewed by Patrick Angle.

Properties:
-webkit-appearance
-webkit-mask-image
-webkit-clip-path
-webkit-text-decoration-*
-webkit-user-select

Values:
cursor: -webkit-grab/grabbing
-webkit-fill-available

JS Properties:
webkitTransform

Media queries:
-webkit-device-pixel-ratio
-webkit-min-device-pixel-ratio
-webkit-max-device-pixel-ratio

Also used shorthand properties there and there.

• UserInterface/Debug/UncaughtExceptionReporter.css:

(.sheet-container):
(.uncaught-exception-sheet li):

• UserInterface/Views/AuditTestCaseContentView.css:

(.content-view.audit-test-case > section table > tr > td > :not(.tree-outline)):

• UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test.manager-editing > header :is(.name, .description)[contenteditable]):

• UserInterface/Views/BoxShadowEditor.css:

(.box-shadow-editor > table > tr > td > input[type="text"]):

• UserInterface/Views/BreakpointActionView.css:

(.breakpoint-action-eval-editor):

• UserInterface/Views/BreakpointPopover.css:

(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor):

• UserInterface/Views/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image.auto-continue::after):

• UserInterface/Views/CPUTimelineView.css:

(.timeline-view.cpu > .content > .overview .legend):
(.timeline-view.cpu > .content > .overview > .chart > .container.stats):

• UserInterface/Views/CPUUsageCombinedView.css:

(.cpu-usage-combined-view > .details):

• UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.sidebar > .panel.changes-panel .css-rule):

• UserInterface/Views/CodeMirrorOverrides.css:

(.CodeMirror-linewidget):

• UserInterface/Views/ColorSquare.css:

(@media (-webkit-device-pixel-ratio: 1) .color-square > .srgb-edge): Deleted.

• UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section):
(.computed-style-section .computed-property-item .disclosure-button):

• UserInterface/Views/ConsoleMessageView.css:

(.console-user-command.special-user-log > .console-message-body):
(.console-message-body > span):
(.console-message-body > span > :matches(.console-message-enclosed, .console-message-preview, .console-message-preview-divider)):
(.console-message .console-message-extra-parameters-container > li,):
(.console-user-command > .console-message-body):

• UserInterface/Views/CookiePopover.css:

(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])):

• UserInterface/Views/DOMEventsBreakdownView.css:

(.waterfall-popover-content .dom-events-breakdown):

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom.non-selectable):
(.tree-outline.dom li .selection-area):

• UserInterface/Views/DatabaseContentView.css:

(:matches(.database-user-query, .database-query-result)::before):
(.database-query-text):
(.database-query-result.error):
(.database-query-result.no-results):

• UserInterface/Views/DetailsSection.css:

(.details-section > .content > .group > .row.simple > .value):
(.details-section > .content > .group > .row.text):
(@media (-webkit-min-device-pixel-ratio: 2) .details-section,): Deleted.

• UserInterface/Views/Editing.css:

(.editing):

• UserInterface/Views/EventBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .event input):

• UserInterface/Views/FilterBar.css:

(:matches(.filter-bar, .search-bar) > input[type="search"]):
(:matches(.filter-bar, .search-bar) > input[type="search"]::-webkit-search-decoration):

• UserInterface/Views/FindBanner.css:

(.find-banner > input[type="search"]):
(.find-banner > button):

• UserInterface/Views/FontResourceContentView.css:

(.content-view.resource.font .preview > .line > .content):

• UserInterface/Views/FormattedValue.css:

(.formatted-node > .tree-outline.dom li):

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .options-container > .filter-bar):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):

• UserInterface/Views/GoToLineDialog.css:

(.go-to-line-dialog > div > input):

• UserInterface/Views/GradientEditor.css:

(.gradient-editor > .gradient-angle > input::-webkit-inner-spin-button):

• UserInterface/Views/GradientSlider.js:

(WI.GradientSliderKnob.prototype._updateTransform):
(WI.GradientSliderKnob):

• UserInterface/Views/ImageResourceContentView.css:

(.content-view.resource.image img):

• UserInterface/Views/IndexedDatabaseContentView.css:

(.indexed-database.content-view):

• UserInterface/Views/InlineSwatch.css:

(@media (-webkit-max-device-pixel-ratio: 1) .inline-swatch): Deleted.

• UserInterface/Views/InputPopover.css:

(.popover .input-popover-content > .editor):

• UserInterface/Views/LocalResourceOverrideLabelView.css:

(.local-resource-override-label-view > div > .url):

• UserInterface/Views/LocalResourceOverridePopover.css:

(.popover .local-resource-override-popover-content .editor):

• UserInterface/Views/Main.css:

(body):
(input[type=range]):
(.message-text-view):
(.resource-link,):
(.go-to-arrow):
(.css-documentation-button):
(.search-settings):
(.expand-list-button):
(.bouncy-highlight):
(@media (-webkit-device-pixel-ratio: 1) .reference-page-link): Deleted.

• UserInterface/Views/NetworkResourceDetailView.css:

(.content-view.resource-details):

• UserInterface/Views/NetworkTableContentView.css:

(.network-table > .statistics > .statistic > .text):

• UserInterface/Views/ObjectTreeView.css:

(.tree-outline.object li):

• UserInterface/Views/OpenResourceDialog.css:

(.open-resource-dialog > .field > input):

• UserInterface/Views/RecordingContentView.css:

(.content-view.recording > .preview-container):

• UserInterface/Views/ResourceCookiesContentView.css:

(.resource-cookies .table > .header):

• UserInterface/Views/ResourceHeadersContentView.css:

(.resource-headers .go-to-link):
(.resource-headers .call-stack):

• UserInterface/Views/ResourceTimingBreakdownView.css:

(.waterfall-popover-content .resource-timing-breakdown):

• UserInterface/Views/ResourceTreeElement.css:

(.item.resource.resource-type-websocket .status > .ready-state):

• UserInterface/Views/ScopeChainDetailsSidebarPanel.css:

(.watch-expression-editor):

• UserInterface/Views/Slider.css:

(@media (-webkit-min-device-pixel-ratio: 2) .slider): Deleted.

• UserInterface/Views/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .line-indicator-widget.inline):
(@media (-webkit-min-device-pixel-ratio: 2) .popover .debugger-popover-content > .body): Deleted.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):
(.spreadsheet-style-declaration-editor > .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) > .content > *:not(.name, .value-container),):
(.spreadsheet-style-declaration-editor > .property.invalid-name:not(.disabled) > .content > *:not(.name, .value-container),):
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property.invalid-value:not(.disabled) > .content .value:not(.editing),):
(.spreadsheet-style-declaration-editor .property.has-warning .warning):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration.selecting,):
(.spreadsheet-css-declaration .selector > .icon):

• UserInterface/Views/SpringEditor.css:

(.spring-editor > .number-input-container > .number-input-row > input::-webkit-inner-spin-button):

• UserInterface/Views/TextEditor.css:

(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before):
(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.execution-line.primary) .CodeMirror-linenumber::after):

• UserInterface/Views/TimelineRecordFrame.css:

(.timeline-record-frame.tall):

• UserInterface/Views/TimelineRuler.css:

(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag):
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag:active):

• UserInterface/Views/TreeOutline.css:

(.tree-outline .item .disclosure-button):

• UserInterface/Views/TypeTreeElement.css:

(.item.type-tree-element > .disclosure-button):

• UserInterface/Views/TypeTreeView.css:

(.tree-outline.type li):

• UserInterface/Views/URLBreakpointPopover.css:

(.popover .edit-breakpoint-popover-content .url .editor):
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content .url .editor):

11:25 AM Changeset in webkit [293333] by Antti Koivisto

• 4 edits
  2 adds in trunk

[CSS Typed OM] Fix AttributeStyleMap.get for list values
​https://bugs.webkit.org/show_bug.cgi?id=239716

Reviewed by Alan Bujtas.

Source/WebCore:

Test: css-typedom/typed-om-perspective-value.html

• css/typedom/CSSStyleValueFactory.cpp:

(WebCore::CSSStyleValueFactory::reifyValue):

The list here hasn't been deep copied. Don't move away a member.

• css/typedom/CSSStyleValueFactory.h:

Passing Ref<>&& instead of Ref<> here is a bug-prone over-optimization.

LayoutTests:

• css-typedom/typed-om-perspective-value-expected.txt: Added.
• css-typedom/typed-om-perspective-value.html: Added.

11:19 AM Changeset in webkit [293332] by ntim@apple.com

• 7 edits in trunk/Source/WebCore

Unprefix modern-media-controls CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=239726

Reviewed by Eric Carlson.

• Modules/modern-media-controls/controls/button.css:

(button):
(button > picture):

• Modules/modern-media-controls/controls/button.js:

(Button.prototype.commitProperty):

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls > *):

• Modules/modern-media-controls/controls/slider.css:

(.slider > input):
(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):

• Modules/modern-media-controls/controls/text-tracks.css:

(video::-webkit-media-text-track-container):

• Modules/modern-media-controls/controls/watchos-activity-indicator.css:

(button.watchos-activity-indicator > picture):

10:58 AM Changeset in webkit [293331] by Jonathan Bedard

• 2 edits in trunk/Tools

[build.webkit.org] Use GitHub checkouts (Follow-up)
​https://bugs.webkit.org/show_bug.cgi?id=239072
<rdar://problem/91567092>

Unreviewed follow-up fix.

• Tools/CISupport/build-webkit-org/steps.py:

(CheckOutSource.init): Use the specified commit, not the latest.

10:20 AM WebKitGTK/2.36.x edited by Michael Catanzaro

(diff)

9:41 AM Changeset in webkit [293330] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

[GStreamer] Remove unused rtc variable
​https://bugs.webkit.org/show_bug.cgi?id=239727

Reviewed by Philippe Normand.

• Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:

(WebCore::GStreamerMediaEndpoint::addTrack):

9:10 AM Changeset in webkit [293329] by Chris Dumez

• 35 edits
  5 adds in trunk

Web Locks held in a Worker are not released on page refresh or exit
​https://bugs.webkit.org/show_bug.cgi?id=239614
<rdar://problem/92173575>

Reviewed by Alex Christensen.

Before a web worker olding a lock would terminate, WebLockManager::stop() would get called
and it would attempt to release all locks held by the worker. However, because we're off
the main thread and because the lock registry was held by the Page on the main thread,
we would rely on a call to workerLoaderProxy().postTaskToLoader() to get back to the
main thread and access the lock registry via the Document's page. However, this wasn't
reliable because the task posted to postTaskToLoader() could get dropped if the worker's
Document is also going away (which is the case when reloading or navigating away).

To address the issue, the WebLockRegistry can now be accessed directly (on the main thread),
without having to go through a Page. As a result, we can simply do a callOnMainThread()
and then access WebLockRegistry::shared(), which is always reliable. To maintain the
previous behavior for WebKitLegacy, I also partitioned the WebLockRegistry per sessionID
since we don't want views sharing the same locks if one is using the default session and
the other is using a private session. This wasn't an issue for modern WebKit since there
is a single session per WebProcess.

To achieve this, I had to made sure that WorkerOrWorkletGlobalScope::sessionID() was returning
a valid value. This worked for ServiceWorkerGlobalScope but not for other types or workers /
worklets global scopes.

Test: workers/worker-web-lock-released-on-reload.html

• Source/WebKit/UIProcess/WebLockRegistryProxy.cpp:

(WebKit::WebLockRegistryProxy::requestLock):
(WebKit::WebLockRegistryProxy::releaseLock):
(WebKit::WebLockRegistryProxy::abortLockRequest):
(WebKit::WebLockRegistryProxy::snapshot):
(WebKit::WebLockRegistryProxy::clientIsGoingAway):

• Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::installServiceWorker):

• Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:

(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):

• Source/WebKit/WebProcess/WebCoreSupport/RemoteWebLockRegistry.cpp:

(WebKit::RemoteWebLockRegistry::requestLock):
(WebKit::RemoteWebLockRegistry::releaseLock):
(WebKit::RemoteWebLockRegistry::abortLockRequest):
(WebKit::RemoteWebLockRegistry::snapshot):
(WebKit::RemoteWebLockRegistry::clientIsGoingAway):

• Source/WebKit/WebProcess/WebCoreSupport/RemoteWebLockRegistry.h:
• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::m_appHighlightsVisible):

• Source/WebKit/WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

• Source/WebKit/WebProcess/WebProcess.h:

(WebKit::WebProcess::broadcastChannelRegistry):
(WebKit::WebProcess::webLockRegistry): Deleted.

• Source/WebKitLegacy/mac/WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(getOrCreateWebLockRegistry): Deleted.

• Source/WebKitLegacy/win/WebView.cpp:

(WebView::initWithFrame):
(getOrCreateWebLockRegistry): Deleted.
Test: workers/worker-web-lock-released-on-reload.html

• Source/WebCore/Modules/web-locks/WebLockManager.cpp:

(WebCore::WebLockManager::MainThreadBridge::create):
(WebCore::WebLockManager::MainThreadBridge::MainThreadBridge):
(WebCore::WebLockManager::MainThreadBridge::requestLock):
(WebCore::WebLockManager::MainThreadBridge::releaseLock):
(WebCore::WebLockManager::MainThreadBridge::abortLockRequest):
(WebCore::WebLockManager::MainThreadBridge::query):
(WebCore::WebLockManager::MainThreadBridge::clientIsGoingAway):
(WebCore::WebLockManager::MainThreadBridge::ensureOnMainThread): Deleted.

• Source/WebCore/Modules/web-locks/WebLockRegistry.cpp:

(WebCore::sharedRegistry):
(WebCore::WebLockRegistry::shared):
(WebCore::WebLockRegistry::setSharedRegistry):
(WebCore::LocalWebLockRegistry::ensureRegistryForOrigin):
(WebCore::LocalWebLockRegistry::existingRegistryForOrigin const):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::create):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::PerOriginRegistry):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::~PerOriginRegistry):
(WebCore::LocalWebLockRegistry::requestLock):
(WebCore::LocalWebLockRegistry::releaseLock):
(WebCore::LocalWebLockRegistry::abortLockRequest):
(WebCore::LocalWebLockRegistry::snapshot):
(WebCore::LocalWebLockRegistry::clientIsGoingAway):
(WebCore::LocalWebLockRegistry::clientsAreGoingAway):

• Source/WebCore/Modules/web-locks/WebLockRegistry.h:
• Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp:

(WebCore::generateWorkletParameters):

• Source/WebCore/dom/Document.h:
• Source/WebCore/loader/EmptyClients.cpp:

(WebCore::pageConfigurationWithEmptyClients):

• Source/WebCore/page/Page.cpp:

(WebCore::Page::Page):

• Source/WebCore/page/Page.h:

(WebCore::Page::webLockRegistry): Deleted.

• Source/WebCore/page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

• Source/WebCore/page/PageConfiguration.h:
• Source/WebCore/workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

• Source/WebCore/workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

• Source/WebCore/workers/WorkerGlobalScopeProxy.h:
• Source/WebCore/workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

• Source/WebCore/workers/WorkerMessagingProxy.h:
• Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp:

(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):

• Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:

(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):

• Source/WebCore/workers/WorkerThread.h:
• Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::create):
(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):

• Source/WebCore/workers/service/ServiceWorkerGlobalScope.h:
• Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::createWorkerGlobalScope):

• Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:

(WebCore::generateWorkerParameters):

• Source/WebCore/worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::WorkletGlobalScope):

• Source/WebCore/worklets/WorkletParameters.h:

(WebCore::WorkletParameters::isolatedCopy const):
(WebCore::WorkletParameters::isolatedCopy):

• LayoutTests/workers/resources/worker-web-lock-released-on-reload-popup.html: Added.
• LayoutTests/workers/resources/worker-web-lock-released-on-reload-worker.js: Added.
• LayoutTests/workers/worker-web-lock-released-on-reload-expected.txt: Added.
• LayoutTests/workers/worker-web-lock-released-on-reload.html: Added.

Canonical link: ​https://commits.webkit.org/249952@main

8:37 AM Changeset in webkit [293328] by Claudio Saavedra

• 2 edits in trunk/Source/WebKit

[GLIB] Default-handle recently-added ProcessTerminationReason values
​https://bugs.webkit.org/show_bug.cgi?id=239720

Reviewed by Philippe Normand.

• UIProcess/API/glib/WebKitNavigationClient.cpp: Add a couple of

new values for ProcessTerminationReason that were added on r292912
to silent some compile-time warnings.

8:25 AM Changeset in webkit [293327] by Jonathan Bedard

• 4 edits in trunk/Tools

[ews-build.webkit.org] Support alternative remotes
​https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/events.py:

(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.extractProperties): Remove sensative fields from non-public
pull requests.
(GitHubEventHandlerNoEdits.handle_pull_request): Generalize label process sleep.

• Tools/CISupport/ews-build/steps.py:

(CheckOutPullRequest.run): Checkout with EWS credentials.

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/249949@main

8:25 AM Changeset in webkit [293326] by Chris Dumez

• 81 edits in trunk

Replace String::replace() functions with makeStringByReplacingAll() free functions
​https://bugs.webkit.org/show_bug.cgi?id=239685

Reviewed by Darin Adler.

Replace String::replace() functions with makeStringByReplacingAll() free functions.

"All" is added to the name since every instance is replaced, not just the first one.
Making it a free function that returns a new String is a step towards making String
immutable.

In the future, we may want to add a makeStringByReplacingAll() that takes in a
StringView instead of a const String. Some call sites would benefit from that.

• Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

(AppleLanguagesTest::AppleLanguagesTest):

• Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::attributedStringForRange):

• Source/JavaScriptCore/inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::run):

• Source/JavaScriptCore/jit/ExecutableAllocator.cpp:

(JSC::dumpJITMemory):

• Source/JavaScriptCore/runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::logTypesForTypeLocation):

• Source/JavaScriptCore/runtime/TypeSet.cpp:

(JSC::StructureShape::propertyHash):

• Source/JavaScriptCore/yarr/RegularExpression.cpp:

(JSC::Yarr::replace):

• Source/WebCore/PAL/pal/text/TextCodecICU.cpp:

(PAL::TextCodecICU::encode const):

• Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:

(WebKit::DatabaseUtilities::stripIndexQueryToMatchStoredValue):

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::escapeForJSON):

• Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_preferred_languages):

• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::insertText):

• Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

• Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

• Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:

(matchLabelsAgainstString):

• Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]):

• Source/WebKitLegacy/win/DOMHTMLClasses.cpp:

(DOMHTMLInputElement::replaceCharactersInRange):

• Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

• Source/WebKitLegacy/win/WebLocalizableStrings.cpp:

(LocalizedString::operator LPCTSTR const):

• Source/WTF/wtf/Language.cpp:

(WTF::canonicalLanguageIdentifier):

• Source/WTF/wtf/URLHelpers.cpp:

(WTF::URLHelpers::mapHostNames):

• Source/WTF/wtf/URLParser.cpp:

(WTF::URLParser::parseURLEncodedForm):

• Source/WTF/wtf/text/StringView.h:

(WTF::makeStringByReplacingAll):
(WTF::makeStringByReplacing):
(WTF::String::replace): Deleted.

• Source/WTF/wtf/text/WTFString.h:

(WTF::makeStringByReplacingAll):
(WTF::String::replace): Deleted.

• Source/WTF/wtf/unix/LanguageUnix.cpp:

(WTF::platformLanguage):

• Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::encodeDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::decodeDatabaseName):

• Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:

(WebCore::GStreamerMediaEndpoint::setConfiguration):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::queryKeysAndValues):

• Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineDropEffects const):

• Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::registerRoot):
(WebCore::AccessibilityAtspi::registerObject):
(WebCore::AccessibilityAtspi::registerHyperlink):

• Source/WebCore/contentextensions/ContentExtensionActions.cpp:

(WebCore::ContentExtensions::RedirectAction::RegexSubstitutionAction::applyToURL const):

• Source/WebCore/contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList):

• Source/WebCore/css/parser/CSSTokenizer.cpp:

(WebCore::CSSTokenizer::preprocessString):

• Source/WebCore/display/css/DisplayTextBox.cpp:

(WebCore::Display::TextBox::debugDescription const):

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::displayStringModifiedByEncoding const):

• Source/WebCore/dom/Node.cpp:

(WebCore::Node::showNode const):

• Source/WebCore/dom/Text.cpp:

(WebCore::appendTextRepresentation):

• Source/WebCore/dom/ViewportArguments.cpp:

(WebCore::viewportErrorMessage):

• Source/WebCore/editing/EditingStyle.cpp:

(WebCore::StyleChange::extractTextStyles):

• Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::selectedText const):

• Source/WebCore/editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugRenderer const):

• Source/WebCore/editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):

• Source/WebCore/editing/TextIterator.cpp:

(WebCore::foldQuoteMarks):

• Source/WebCore/editing/VisibleUnits.cpp:

(WebCore::charactersAroundPosition):

• Source/WebCore/editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

• Source/WebCore/editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedString):

• Source/WebCore/editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::takeResults):
(WebCore::createFragmentFromText):

• Source/WebCore/html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

• Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon):

• Source/WebCore/html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText):

• Source/WebCore/html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):

• Source/WebCore/html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

• Source/WebCore/html/URLDecomposition.cpp:

(WebCore::URLDecomposition::setSearch):

• Source/WebCore/inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):

• Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputLayoutBox):

• Source/WebCore/loader/FormSubmission.cpp:

(WebCore::appendMailtoPostFormDataToURL):
(WebCore::encodingFromAcceptCharset):

• Source/WebCore/page/Frame.cpp:

(WebCore::matchLabelsAgainstString):

• Source/WebCore/platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::imageTitle):
(WebCore::webCryptoMasterKeyKeychainLabel):

• Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:

(WebCore::AVStreamDataParserMIMETypeCache::canDecodeExtendedType):

• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::configureDownloadBuffer):

• Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::handleStateChangeMessage):

• Source/WebCore/platform/gtk/SelectionData.cpp:

(WebCore::replaceNonBreakingSpaceWithSpace):

• Source/WebCore/platform/mediastream/gstreamer/GStreamerDisplayCaptureDeviceManager.cpp:

(WebCore::GStreamerDisplayCaptureDeviceManager::createDisplayCaptureSource):

• Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

• Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::createSoupURI const):

• Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::sanitizeFilename):

• Source/WebCore/platform/text/DateTimeFormat.cpp:

(WebCore::DateTimeFormat::quoteAndAppendLiteral):

• Source/WebCore/platform/text/LocaleToScriptMapping.cpp:

(WebCore::localeToScriptCodeForFontSelection):

• Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:

(WebCore::scanDirectoryForDictionaries):

• Source/WebCore/platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::shortMonthFormat):

• Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::replaceNBSPWithSpace):

• Source/WebCore/rendering/LegacyInlineTextBox.cpp:

(WebCore::LegacyInlineTextBox::outputLineBox const):

• Source/WebCore/rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateSecurityDiscCharacters):

• Source/WebCore/rendering/RenderObject.cpp:

(WebCore::RenderObject::outputRenderObject const):

• Source/WebCore/rendering/RenderText.cpp:

(WebCore::RenderText::setRenderedText):

• Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:

(WebCore::applySVGWhitespaceRules):

• Source/WebCore/xml/XSLTProcessor.cpp:

(WebCore::transformTextStringToXHTMLDocumentString):

Canonical link: ​https://commits.webkit.org/249949@main

7:12 AM Changeset in webkit [293325] by aakash_jain@apple.com

• 1 edit in trunk/Tools/CISupport/build-webkit-org/config.json

[build.webkit.org] Delete builddir key from config.json
​https://bugs.webkit.org/show_bug.cgi?id=239718

Reviewed by Jonathan Bedard.

• Tools/CISupport/build-webkit-org/config.json:

Canonical link: ​https://commits.webkit.org/249948@main

6:58 AM Changeset in webkit [293324] by Claudio Saavedra

• 2 edits in trunk/Source/JavaScriptCore

[GLIB] Remove leftover unused variable from r292929
​https://bugs.webkit.org/show_bug.cgi?id=239715

Reviewed by Philippe Normand.

• API/glib/JSCWrapperMap.cpp:

(JSC::WrapperMap::wrappedObject const): VM& vm is unused,
remove.

6:31 AM Changeset in webkit [293323] by Jonathan Bedard

• 6 edits in trunk/Tools

[build.webkit.org] Use GitHub checkouts
​https://bugs.webkit.org/show_bug.cgi?id=239072
<rdar://problem/91567092>

Reviewed by Ryan Haddad.

• Tools/CISupport/build-webkit-org/config.json: Convert schedulers to GitHub based branch names.
• Tools/CISupport/build-webkit-org/loadConfig.py: Ditto.
• Tools/CISupport/build-webkit-org/master.cfg: Enable incoming hooks from GitHub.

(load_password): Added.

• Tools/CISupport/build-webkit-org/steps.py:

(CheckOutSource): Replace with GitHub based checkout.
(CleanUpGitIndexLock): Replaced SVNCleanup.
(SVNCleanup): Replace with CleanUpGitIndexLock.
(ShowIdentifier.start): got_revision will bet hash, not subversion revision.

• Tools/CISupport/build-webkit-org/steps_unittest.py:

(TestShowIdentifier.test_success):
(TestShowIdentifier.test_failure):

Canonical link: ​https://commits.webkit.org/249946@main

6:06 AM Changeset in webkit [293322] by Ziran Sun

• 7 edits in trunk

UA stylesheet should include table { text-indent: initial } to conform with HTML standard
​https://bugs.webkit.org/show_bug.cgi?id=201297

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

• web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
• web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt:

Source/WebCore:

As per [1], text-indent for table should be initial.
[1] ​https://html.spec.whatwg.org/multipage/rendering.html#tables-2

• css/html.css:

(table):

LayoutTests:

• platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:

5:56 AM Changeset in webkit [293321] by ntim@apple.com

• 2 edits in trunk/Tools

Fix typo in Tools/CISupport/ews-build/steps.py

Unreviewed.

• CISupport/ews-build/steps.py:

(UpdateWorkingDirectory):

4:47 AM Changeset in webkit [293320] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

REGRESSION (249585@main): TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore is timing out
​https://bugs.webkit.org/show_bug.cgi?id=239507

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-25
Reviewed by Wenson Hsieh.

Source/WebKit:

Add purpose-built test interfaces for testing sending IPC::Semaphore via the IPC.

Test: ipc/send-semaphore.html

• Shared/IPCTester.cpp:

(WebKit::IPCTester::sendSameSemaphoreBack):
(WebKit::IPCTester::sendSemaphoreBackAndSignalProtocol):

• Shared/IPCTester.h:
• Shared/IPCTester.messages.in:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

Move CanReceiveIPCSemaphore and CanSendIPCSemaphore test logic
to LayoutTests/ipc/send-semaphore.html
The tests were using audio and canvas implementation detail
messages to test that IPC system can send IPC::Semaphore via IPC.
Canvas implementation details changed and the test started
to fail.

The new tests use IPC messages that are purpose-built to test this
feature. The new tests also actually test that the sent semaphores
work.

LayoutTests:

• ipc/send-semaphore-expected.txt: Added.
• ipc/send-semaphore.html: Added.

2:20 AM Changeset in webkit [293319] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Disable new demuxers based on adaptivedemux2
​https://bugs.webkit.org/show_bug.cgi?id=239701

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-25
Reviewed by Xabier Rodriguez-Calvar.

The new demuxers based on adaptivedemux2 cannot be used in WebKit yet because this new base
class does not abstract away network access. They can't work in a sandboxed media process,
so demote their rank in order to prevent decodebin3 from auto-plugging them.

• platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::registerWebKitGStreamerElements):

Canonical link: ​https://commits.webkit.org/249942@main

12:57 AM Changeset in webkit [293318] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[git] Allow pre-commit hook to feed from staged ChangeLogs
​https://bugs.webkit.org/show_bug.cgi?id=239419

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-25
Reviewed by Jonathan Bedard.

In workflows where prepare-ChangeLog is executed manually before staging and committing
changes the prepare-commit-msg hook can now read the curated ChangeLog from the git stage
and present it in the editor for validation. In case no ChangeLog was staged, the hook will
generate a message itself.

• Scripts/hooks/prepare-commit-msg:

Canonical link: ​https://commits.webkit.org/249941@main

12:04 AM Changeset in webkit [293317] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/ANGLE

REGRESSION (Safari 15.4) Performance regression after uploading WebGL buffers
​https://bugs.webkit.org/show_bug.cgi?id=239015

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-25
Reviewed by Dean Jackson.

BufferMtl::getRestartIndices() would recalculate restart indices on each
draw because RestartRangeCache::operator bool() would return m_isDirty
instead of the intended !m_isDirty.

Use std::optional to hold the RestartRangeCache instead of
maintaining m_isDirty. This allows the type system to contribute to the
correctness of the code. Dirty restart range cache is not useful and takes
up memory.

Re-apply hunks from r281550 "ANGLE Metal index buffer left mapped when building primitive restart ranges".

These were overwritten in r286638 "Roll ANGLE to include upstreamed Metal backend".

• src/libANGLE/renderer/metal/BufferMtl.h:

(rx::BufferMtl::RestartRangeCache::RestartRangeCache):

• src/libANGLE/renderer/metal/BufferMtl.mm:

(rx::BufferMtl::markConversionBuffersDirty):
(rx::BufferMtl::clearConversionBuffers):
(rx::BufferMtl::getRestartIndices):

Apr 24, 2022:

11:54 PM Changeset in webkit [293316] by zan@falconsigh.net

• 4 edits in trunk

[RISCV64] Enable Baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=239708

Reviewed by Yusuke Suzuki.

.:

Turn on the CMake defaults for ENABLE(JIT) and ENABLE(FTL_JIT) options
for RISCV64. These are enabled together to avoid having to worry about
a 64-bit platform that would want to allow compiling with Baseline JIT
enabled and FTL JIT disabled at the same time. But because FTL JIT
support for RISCV64 isn't complete yet, it's still disabled at runtime.

• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• runtime/Options.cpp:

(JSC::Options::recomputeDependentOptions):
Disable FTL JIT at runtime under CPU(RISCV64) since the support is still
incomplete. This is necessary due to Baseline JIT and FTL JIT still
being enabled at build-time on this platform for pure convenience.

11:41 PM Changeset in webkit [293315] by Diego Pino Garcia

• 2 edits in trunk/Source/JavaScriptCore

[GCC] Unreviewed, build fix for Ubuntu LTS/Debian after r293265

• wasm/WasmTypeDefinition.h:

(JSC::Wasm::FunctionSignature::operator!= const):

11:36 PM Changeset in webkit [293314] by dbezhetskov

• 2 edits in trunk/Source/JavaScriptCore

[Wasm] Remove confusing isFuncref and isExternref
​https://bugs.webkit.org/show_bug.cgi?id=239699

Reviewed by Yusuke Suzuki.

There are two functions with the same name Wasm::Type::isFuncref and
Wasm::isFuncref but with different behaviour, and so,
this brings confusion into the codebase.
The first function checks that .kind == funcref and the second one checks
for the same but with respect to typed function references proposal.
The second one should be used when we want to check that type is funcref,
so the first one is not needed and actually not used, so this patch removes it.

The same situation is for isExternref.

• wasm/generateWasmOpsHeader.py:

(typeMacroizer):
(typeMacroizerFiltered):

11:29 PM Changeset in webkit [293313] by zan@falconsigh.net

• 2 edits in trunk/Source/JavaScriptCore

[RISCV64] Implement MacroAssemblerRISCV64 fencing methods
​https://bugs.webkit.org/show_bug.cgi?id=239706

Reviewed by Yusuke Suzuki.

Provide MacroAssemblerRISCV64 implementations for the tree fencing
methods, using the fence instruction but with different corresponding
combinations of the predecessor and successor operation sets.

• assembler/MacroAssemblerRISCV64.h:

(JSC::MacroAssemblerRISCV64::memoryFence):
(JSC::MacroAssemblerRISCV64::storeFence):
(JSC::MacroAssemblerRISCV64::loadFence):

11:26 PM Changeset in webkit [293312] by zan@falconsigh.net

• 5 edits in trunk/JSTests

Skip microbenchmarks/memcpy-wasm.js and friends on non-FTL (i.e. non-WASM) platforms
​https://bugs.webkit.org/show_bug.cgi?id=239705

Reviewed by Yusuke Suzuki.

Mark microbenchmarks/memcpy-wasm.js and related tests as skipped on
non-FTL platforms since WASM tests are not run there, resulting in
failures when they're executed.

• microbenchmarks/memcpy-wasm-large.js:
• microbenchmarks/memcpy-wasm-medium.js:
• microbenchmarks/memcpy-wasm-small.js:
• microbenchmarks/memcpy-wasm.js:

11:02 PM Changeset in webkit [293311] by youenn@apple.com

• 13 edits
  1 add in trunk

TextTrackLoader should use SameOrigin mode by default
​https://bugs.webkit.org/show_bug.cgi?id=239381

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
• web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
• web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:

Source/WebCore:

Covered by updated test.

• loader/TextTrackLoader.cpp:

LayoutTests:

• http/tests/security/contentSecurityPolicy/resources/track.vtt.py: Added.
• http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
• http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
• http/tests/security/contentSecurityPolicy/track-redirect-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
• http/tests/security/text-track-crossorigin-expected.txt:
• http/tests/security/text-track-crossorigin.html:

10:56 PM Changeset in webkit [293310] by youenn@apple.com

• 4 edits in trunk/Source/WebKit

Make NetworkResourceLoader.m_parameters non const
​https://bugs.webkit.org/show_bug.cgi?id=239603

Reviewed by Anders Carlsson.

Now that NetworkResourceLoader can be transitioned through WebProcesses,
several NetworkResourceLoaderParameters might need to be changed over time.
For that reason, it no longer makes sense to have m_parameters const.

Covered by existing tests.

• NetworkProcess/NetworkLoadParameters.h:
• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/NetworkResourceLoader.h:

9:45 PM Changeset in webkit [293309] by Chris Dumez

• 43 edits in trunk/Source

Use equalLettersIgnoringASCIICase() and SortedArrayMap in more places
​https://bugs.webkit.org/show_bug.cgi?id=239714

Reviewed by Darin Adler.

Use equalLettersIgnoringASCIICase() and SortedArrayMap in more places, for performance.

• Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::preconnectTo):

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

• Source/WTF/wtf/unix/LanguageUnix.cpp:

(WTF::platformLanguage):

• Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::validatedPaymentNetwork const):

• Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::packageFormData):

• Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):

• Source/WebCore/css/parser/CSSAtRuleID.cpp:

(WebCore::cssAtRuleID):

• Source/WebCore/css/parser/CSSParserImpl.cpp:

(WebCore::consumeStringOrURI):
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::consumeKeyframeKeyList):

• Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAnimationName):

• Source/WebCore/css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::consumeAttributeFlags):
(WebCore::consumeANPlusB):

• Source/WebCore/css/parser/CSSSupportsParser.cpp:

(WebCore::CSSSupportsParser::consumeCondition):

• Source/WebCore/css/parser/CSSTokenizer.cpp:

(WebCore::CSSTokenizer::consumeIdentLikeToken):

• Source/WebCore/css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::readMediaNot):
(WebCore::isRestrictorOrLogicalOperator):
(WebCore::MediaQueryParser::readMediaType):
(WebCore::MediaQueryParser::readAnd):

• Source/WebCore/css/parser/SizesCalcParser.cpp:

(WebCore::SizesCalcParser::calcToReversePolishNotation):

• Source/WebCore/css/typedom/transform/CSSPerspective.cpp:

(WebCore::checkLength):

• Source/WebCore/editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::requiresExtendedContext):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::isDataDetectorElement):

• Source/WebCore/html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement):

• Source/WebCore/html/EnterKeyHint.cpp:

(WebCore::enterKeyHintForAttributeValue):

• Source/WebCore/html/EnterKeyHint.h:
• Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList):

• Source/WebCore/html/HTMLFormElement.cpp:

(WebCore::parseFormRelAttributes):
(WebCore::HTMLFormElement::relList):

• Source/WebCore/html/HTMLImageElement.cpp:

(WebCore::parseCrossoriginState):

• Source/WebCore/html/InputType.cpp:

(WebCore::InputType::applyStep):

• Source/WebCore/html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::isSupported):

• Source/WebCore/html/parser/HTMLParserIdioms.cpp:

(WebCore::parseCORSSettingsAttribute):

• Source/WebCore/loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadApplicationManifest):

• Source/WebCore/loader/LinkLoader.cpp:

(WebCore::LinkLoader::preconnectIfNeeded):

• Source/WebCore/loader/ServerTiming.cpp:

(WebCore::ServerTiming::setParameter):

• Source/WebCore/page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::screenshot):

• Source/WebCore/page/Quirks.cpp:

(WebCore::Quirks::isGoogleMaps const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const):

• Source/WebCore/page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::databaseIdentifier const):

• Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::schemeIsInHttpFamily):
(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):

• Source/WebCore/platform/graphics/FontGenericFamilies.cpp:

(WebCore::computeUserPrefersSimplified):

• Source/WebCore/platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::shouldOverrideExtendedType):

• Source/WebCore/platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType):

• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::willUseWebMFormatReaderForType):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):

• Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:

(WebCore::SourceBufferParserWebM::isContentTypeSupported):

• Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

• Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:

(webKitDMABufVideoSinkIsEnabled):

• Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::isThunderRanked):

• Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::createDecodingConfiguration):
(WebCore::LibWebRTCProvider::createEncodingConfiguration):

• Source/WebCore/platform/network/curl/CookieUtil.cpp:

(WebCore::CookieUtil::parseCookieAttributes):

• Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:

(WebCore::CurlMultipartHandle::extractBoundary):

• Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):

• Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::relList):

• Source/WebCore/testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::supportsKeySystem):
(WebCore::MockCDMInstance::setServerCertificate):

Canonical link: ​https://commits.webkit.org/249932@main

8:54 PM Changeset in webkit [293308] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

Unreviewed, non-unified build fixes after r293285

• html/track/TextTrack.cpp:

2:16 PM Changeset in webkit [293307] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Use utf-8 for text mode files in generate-automation-atom.py
​https://bugs.webkit.org/show_bug.cgi?id=239542

Patch by Daniel Kolesa <Daniel Kolesa> on 2022-04-24
Reviewed by Adrian Perez de Castro.

At least with older versions of python (3.6), this will otherwise
be ascii, which will break input files that contain non-ascii
characters, e.g. Source/WebKit/UIProcess/Automation/atoms/FindNodes.js

• Scripts/generate-automation-atom.py:

(main):

1:28 PM Changeset in webkit [293306] by Fujii Hironori

• 2 edits in trunk/Source/WebCore

[Win][WinCairo] Unreviewed build fix
​https://bugs.webkit.org/show_bug.cgi?id=239692
<rdar://problem/92222456>

• Headers.cmake: Added necessary headers of WebCore/layout.

11:00 AM Changeset in webkit [293305] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.1.1

Tag WebKit-7613.2.7.1.1.

10:58 AM Changeset in webkit [293304] by Russell Epstein

• 1 copy in tags/WebKit-7613.2.7.0.1

Tag WebKit-7613.2.7.0.1.

8:21 AM Changeset in webkit [293303] by Alan Bujtas

• 7 edits in trunk/Source/WebCore

Fix a typo (r293297)
​https://bugs.webkit.org/show_bug.cgi?id=239704

Unreviewed.

• layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration): Deleted.

• layout/formattingContexts/flex/FlexFormattingContext.h:
• layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration): Deleted.

• layout/formattingContexts/inline/InlineFormattingContext.h:
• layout/integration/flex/LayoutIntegrationFlexLayout.cpp:

(WebCore::LayoutIntegration::FlexLayout::layout):

• layout/integration/inline/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::layout):

Apr 23, 2022:

10:49 PM Changeset in webkit [293302] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed build fix after r293301.

• bindings/js/JSDOMConvertStrings.h:

(WebCore::Converter<IDLAtomStringAdaptor<IDLByteString>>::convert):

9:48 PM Changeset in webkit [293301] by Chris Dumez

• 12 edits in trunk/Source

[IDL] Add support for [AtomString] with USVString & ByteString types
​https://bugs.webkit.org/show_bug.cgi?id=239695

Reviewed by Cameron McCormack.

Add support for [AtomString] with USVString and ByteString types in our WebIDL
bindings. This is needed to mark the AtomString(const String&) constructor
explicit.

• Source/WTF/wtf/text/AtomString.cpp:

(WTF::replaceUnpairedSurrogatesWithReplacementCharacterInternal):
(WTF::replaceUnpairedSurrogatesWithReplacementCharacter):

• Source/WTF/wtf/text/AtomString.h:
• Source/WTF/wtf/text/WTFString.cpp:

(WTF::replaceUnpairedSurrogatesWithReplacementCharacter): Deleted.

• Source/WTF/wtf/text/WTFString.h:
• Source/WebCore/Modules/fetch/FetchResponse.h:
• Source/WebCore/Modules/fetch/FetchResponse.idl:
• Source/WebCore/bindings/js/JSDOMConvertStrings.cpp:

(WebCore::throwIfInvalidByteString):
(WebCore::identifierToByteString):
(WebCore::valueToByteString):
(WebCore::valueToByteAtomString):
(WebCore::valueToUSVAtomString):
(WebCore::stringToByteString): Deleted.

• Source/WebCore/bindings/js/JSDOMConvertStrings.h:

(WebCore::Converter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::Converter<IDLAtomStringAdaptor<IDLUSVString>>::convert):
(WebCore::Converter<IDLAtomStringAdaptor<IDLByteString>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLUSVString>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLByteString>>::convert):

• Source/WebCore/html/HTMLAnchorElement.idl:
• Source/WebCore/html/HTMLAreaElement.idl:
• Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::httpStatusText const):
(WebCore::ResourceResponseBase::setHTTPStatusText):

• Source/WebCore/platform/network/ResourceResponseBase.h:

Canonical link: ​https://commits.webkit.org/249926@main

8:54 PM Changeset in webkit [293300] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

• Headers.cmake:

8:45 PM Changeset in webkit [293299] by Wenson Hsieh

• 28 edits
  1 delete in trunk/Source

Remove the PreferInlineTextSelectionInImages internal feature flag
​https://bugs.webkit.org/show_bug.cgi?id=234849

Reviewed by Sam Weinig.

Source/WebCore:

See WebKit/ChangeLog for more details.

• en.lproj/Localizable.strings:
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

• page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):

• platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction):

• platform/ContextMenuItem.h:
• platform/LocalizedStrings.h:
• platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::contextMenuItemTagQuickLookImage): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForTextSelection): Deleted.
(WebCore::contextMenuItemTagQuickLookImageForVisualSearch): Deleted.

Source/WebKit:

This patch reverts r279164, which introduced an internal feature to avoid Live Text analysis when hovering over
images, and instead added a new context menu item to reveal selectable text in the image by launching the
QuickLook panel in Live Text mode.

This alternate Live Text experience was originally devised as a way to mitigate the power and performance impact
of passively triggering Live Text analysis when hovering over images on pre-M1 devices, but this mitigation was
ultimately deemed unnecessary in macOS 12.

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

• UIProcess/Cocoa/QuickLookPreviewActivity.h: Removed.
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::computeHasVisualSearchResults):
(WebKit::WebViewImpl::computeHasImageAnalysisResults): Deleted.

• UIProcess/PageClient.h:

(WebKit::PageClient::computeHasVisualSearchResults):
(WebKit::PageClient::computeHasImageAnalysisResults): Deleted.

• UIProcess/WebContextMenuProxy.h:

(WebKit::WebContextMenuProxy::quickLookPreviewActivity const): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::computeHasVisualSearchResults):
(WebKit::WebPageProxy::computeHasImageAnalysisResults): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::computeHasVisualSearchResults):
(WebKit::PageClientImpl::computeHasImageAnalysisResults): Deleted.

• UIProcess/mac/WKQuickLookPreviewController.h:
• UIProcess/mac/WKQuickLookPreviewController.mm:
• UIProcess/mac/WebContextMenuProxyMac.h:
• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
(WebKit::WebContextMenuProxyMac::insertOrUpdateQuickLookImageItem): Deleted.
(WebKit::WebContextMenuProxyMac::updateQuickLookContextMenuItemTitle): Deleted.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::handleContextMenuLookUpImage):
(WebKit::WebPageProxy::handleContextMenuQuickLookImage): Deleted.

• WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

See WebKit/ChangeLog for more details.

• WebView/WebHTMLView.mm:

(toTag):

Source/WTF:

See WebKit/ChangeLog for more details.

• Scripts/Preferences/WebPreferencesInternal.yaml:

7:27 PM Changeset in webkit [293298] by Andres Gonzalez

• 11 edits in trunk/Source/WebCore

Code cleanup in preparation for optimizing use of AccessibilityObject::elementsFromAttribute.
​https://bugs.webkit.org/show_bug.cgi?id=239664
<rdar://problem/92180286>

Reviewed by Chris Fleizach.

No new functionality.

AccessibilityObject::elementsFromAttribute now returns a vector as
opposed to taking an out parameter. This makes the code more concise
and possibly more efficient.
Removed this method from the AXCoreObject interface, since this method
should not be exposed to an AT client. The Inspector is an exception
that accesses AccessibilityObjects directly and not through the
AXCoreObject interface.
All these changes are entirely code cleanup and modernization, no change
in functionality.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
(WebCore::AccessibilityNodeObject::textUnderElement const):
(WebCore::AccessibilityNodeObject::descriptionForElements const):
(WebCore::AccessibilityNodeObject::ariaDescribedByAttribute const):
(WebCore::AccessibilityNodeObject::ariaLabeledByAttribute const):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements const): Renamed.
(WebCore::AccessibilityNodeObject::ariaLabeledByElements const): Deleted.

• accessibility/AccessibilityNodeObject.h:
• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
(WebCore::AccessibilityObject::elementsFromAttribute const):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isTabItemSelected const):

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::elementsFromAttribute const): Deleted.

• accessibility/isolatedtree/AXIsolatedObject.h:
• inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::accessiblityObjectForNode):
(WebCore::InspectorAuditAccessibilityObject::getControlledNodes):
(WebCore::InspectorAuditAccessibilityObject::getFlowedNodes):
(WebCore::InspectorAuditAccessibilityObject::getMouseEventNode):
(WebCore::InspectorAuditAccessibilityObject::getOwnedNodes):

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

4:03 PM Changeset in webkit [293297] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[FFC][Integration] Add integration API to FlexFormattingContext
​https://bugs.webkit.org/show_bug.cgi?id=239692

Reviewed by Antti Koivisto.

The integration codepath needs dedicated (and temporary)APIs on the formatting contexts.
(This is exactly how inline layout has been integrated.)

• layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::FlexFormattingContext::computedIntrinsicWidthConstraintsForIntegration):

• layout/formattingContexts/flex/FlexFormattingContext.h:
• layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContentForIntergration):
(WebCore::Layout::InlineFormattingContext::lineLayoutForIntergration): Deleted.

• layout/formattingContexts/inline/InlineFormattingContext.h:
• layout/integration/flex/LayoutIntegrationFlexLayout.cpp:

(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::computeIntrinsicWidthConstraints):
(WebCore::LayoutIntegration::FlexLayout::layout):

• layout/integration/flex/LayoutIntegrationFlexLayout.h:

(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox const):
(WebCore::LayoutIntegration::FlexLayout::rootLayoutBox):

• layout/integration/inline/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::layout):

3:26 PM Changeset in webkit [293296] by beidson@apple.com

• 30 edits
  3 copies
  1 add in trunk

Add WKNotification and WKWebsiteDataStore SPI for handling click/close of persistent notifications
​https://bugs.webkit.org/show_bug.cgi

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing tests with WKTR changes.

In Cocoa, expose the dictionary representation of a notification as an NSDictionary,
as it is meant to be used as an NSUserNotification userInfo value.

• Modules/notifications/NotificationData.h:
• Modules/notifications/NotificationDataCocoa.mm: Added.

(WebCore::NotificationData::fromDictionary):
(WebCore::NotificationData::dictionaryRepresentation const):

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::processNotificationEvent):

• workers/service/server/SWServer.h:

Source/WebKit:

For notifications that are persistent, add WKWebsiteDataStore SPI to handle click/close operations,
as the WKNotificationManager's runtime record of such notifications might be gone.

WebKitTestRunner exercises this new SPI in existing tests.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processNotificationEvent):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:

• SourcesCocoa.txt:

• UIProcess/API/C/WKNotification.cpp:

(WKNotificationGetIsPersistent):

• UIProcess/API/C/WKNotification.h:

• UIProcess/API/C/mac/WKNotificationPrivateMac.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.
• UIProcess/API/C/mac/WKNotificationPrivateMac.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKDownloadInternal.h.

(WKNotificationCopyDictionaryRepresentation):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _processPersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClose:completionHandler:]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

• UIProcess/API/Cocoa/_WKDownload.mm:
• UIProcess/API/Cocoa/_WKDownloadInternal.h:

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::processNotificationEvent):

• UIProcess/Network/NetworkProcessProxy.h:

• UIProcess/Notifications/WebNotification.cpp:
• UIProcess/Notifications/WebNotification.h:
• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

• WebKit.xcodeproj/project.pbxproj:

Tools:

Teach WKTR to use the new SPI by keeping a set of notifications that are persistent.

• WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

• WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::reset):

• WebKitTestRunner/WebNotificationProvider.h:

• WebKitTestRunner/cocoa/WebNotificationProviderCocoa.mm:

(WTR::WebNotificationProvider::simulateWebNotificationClickForServiceWorkerNotifications):

2:47 PM Changeset in webkit [293295] by Justin Michaud

• 2 edits in trunk/Source/WebCore

Fix build error caused by LTO + Unified Sources
​https://bugs.webkit.org/show_bug.cgi?id=239679

Reviewed by Alex Christensen.

This hopefully fixes the following build error:
Undefined symbols for architecture x86_64:

"JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor>::tryCreateUninitialized(unsigned long)", referenced from:

WebCore::FEGaussianBlurSoftwareApplier::apply(WebCore::Filter const&, WTF::Vector<WTF::Ref<WebCore::FilterImage, WTF::RawPtrTraits<WebCore::FilterImage> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterImage&) const in lto.o

ld: symbol(s) not found for architecture x86_64

• platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

2:13 PM Changeset in webkit [293294] by Elliott Williams

• 3 edits in trunk/Tools

[buildbot] Increase the EWS compile timeout to account for delayed output from clang/XCBuild
​https://bugs.webkit.org/show_bug.cgi?id=239455

Reviewed by Ryan Haddad.

Same as ​https://commits.webkit.org/249737@main, needed to work around
delayed output bugs in Xcode/XCBuild.

• Tools/CISupport/ews-build/steps.py:

(CompileWebKit.init):

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/249919@main

1:25 PM Changeset in webkit [293293] by Alan Bujtas

• 8 edits in trunk/Source/WebCore

[FFC][Integration] Construct and update the layout tree for the flex items
​https://bugs.webkit.org/show_bug.cgi?id=239684

Reviewed by Antti Koivisto.

This patch implements the usual flow of preparing a subtree for integration layout.

1. Take the direct children of a RenderFlexibleBox (flex items) and construct Layout::ContainerBox objects.
2. Run layout on the direct children (RenderBlocks) first and update the associated Layout::ContainerBoxes' geometries.
3. Call LayoutIntegration::FlexLayout::layout (not yet implemented) to run flex layout on the flex items.

• layout/integration/LayoutIntegrationBoxTree.cpp:

(WebCore::LayoutIntegration::BoxTree::buildTreeForFlexContent):

• layout/integration/LayoutIntegrationBoxTree.h:
• layout/integration/flex/LayoutIntegrationFlexLayout.cpp:

(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):

• layout/integration/flex/LayoutIntegrationFlexLayout.h:
• rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):

• rendering/RenderFlexibleBox.h:

10:36 AM Changeset in webkit [293292] by Chris Dumez

• 123 edits in trunk/Source

Start preparing the code base for making the AtomString(const String&) constructor explicit
​https://bugs.webkit.org/show_bug.cgi?id=239658

Reviewed by Darin Adler.

Start preparing the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.

• Source/JavaScriptCore/runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToAtomString const):

• Source/WebKit/WebProcess/Plugins/Plugin.h:
• Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):

• Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.h:
• Source/WebKitLegacy/mac/DOM/DOMCustomXPathNSResolver.mm:

(DOMCustomXPathNSResolver::lookupNamespaceURI):

• Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
• Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:

(parameterValue):
(WebFrameLoaderClient::createPlugin):

• Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):

• Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:
• Source/WTF/wtf/persistence/PersistentCoders.cpp:

(WTF::Persistence::Coder<AtomString>::decode):

• Source/WTF/wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomString const):

• Source/WTF/wtf/text/StringConcatenate.h:

(WTF::tryMakeAtomStringFromAdapters):

• Source/WTF/wtf/text/StringView.cpp:

(WTF::convertASCIILowercaseAtom):

• Source/WebCore/Modules/gamepad/GamepadEvent.idl:
• Source/WebCore/Modules/mediasession/MediaMetadata.cpp:

(WebCore::ArtworkImageLoader::requestImageResource):

• Source/WebCore/Modules/plugins/PluginReplacement.h:

(WebCore::ReplacementPlugin::create const):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::create):
(WebCore::YouTubePluginReplacement::YouTubePluginReplacement):
(WebCore::YouTubePluginReplacement::youTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):

• Source/WebCore/Modules/plugins/YouTubePluginReplacement.h:
• Source/WebCore/Modules/websockets/CloseEvent.idl:
• Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleLiveRegionCreated):

• Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsLiveRegion const):
(WebCore::AccessibilityObject::tagName const):

• Source/WebCore/accessibility/AccessibilityObject.h:
• Source/WebCore/accessibility/AccessibilityObjectInterface.h:
• Source/WebCore/accessibility/AccessibilityRole.idl:
• Source/WebCore/accessibility/AriaAttributes.idl:
• Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeProperties):

• Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
• Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

• Source/WebCore/animation/KeyframeEffect.cpp:

(WebCore::IDLAttributeNameToAnimationPropertyName):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):

• Source/WebCore/animation/KeyframeEffect.h:
• Source/WebCore/animation/WebAnimation.cpp:

(WebCore::WebAnimation::commitStyles):

• Source/WebCore/bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::setAttributeChangedCallback):

• Source/WebCore/bindings/js/JSCustomElementInterface.h:
• Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

• Source/WebCore/bindings/js/JSExtendableMessageEventCustom.cpp:

(WebCore::constructJSExtendableMessageEvent):

• Source/WebCore/css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):

• Source/WebCore/dom/Attr.cpp:

(WebCore::Attr::setNodeValue):

• Source/WebCore/dom/ClipboardEvent.idl:
• Source/WebCore/dom/CompositionEvent.idl:
• Source/WebCore/dom/CustomElementRegistry.idl:
• Source/WebCore/dom/CustomEvent.idl:
• Source/WebCore/dom/Document+HTML.idl:
• Source/WebCore/dom/DragEvent.idl:
• Source/WebCore/dom/Element.idl:
• Source/WebCore/dom/ErrorEvent.idl:
• Source/WebCore/domjit/DOMJITIDLConvert.h:

(WebCore::DOMJIT::DirectConverter<IDLAtomStringAdaptor<IDLDOMString>>::directConvert):
(WebCore::DOMJIT::DirectConverter<IDLRequiresExistingAtomStringAdaptor<IDLDOMString>>::directConvert):

• Source/WebCore/editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::createElementForImageOverlay):

• Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):

• Source/WebCore/html/HTMLAnchorElement.h:
• Source/WebCore/html/HTMLAnchorElement.idl:
• Source/WebCore/html/HTMLAreaElement.idl:
• Source/WebCore/html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):
(WebCore::HTMLEmbedElement::updateWidget):

• Source/WebCore/html/HTMLEmbedElement.h:
• Source/WebCore/html/HTMLObjectElement.cpp:

(WebCore::mapDataParamToSrc):
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::updateWidget):

• Source/WebCore/html/HTMLObjectElement.h:
• Source/WebCore/html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::name const):
(WebCore::HTMLParamElement::value const):

• Source/WebCore/html/HTMLParamElement.h:
• Source/WebCore/html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::requestObject):

• Source/WebCore/html/HTMLPlugInElement.h:
• Source/WebCore/html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::requestObject):

• Source/WebCore/html/HTMLPlugInImageElement.h:
• Source/WebCore/html/track/TextTrack.h:

(WebCore::TextTrack::inBandMetadataTrackDispatchType const):

• Source/WebCore/loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::createPlugin):

• Source/WebCore/loader/EmptyFrameLoaderClient.h:
• Source/WebCore/loader/FrameLoaderClient.h:
• Source/WebCore/loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::requestPlugin):
(WebCore::FrameLoader::SubframeLoader::requestObject):
(WebCore::FrameLoader::SubframeLoader::loadPlugin):

• Source/WebCore/loader/SubframeLoader.h:
• Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::language const):

• Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):

• Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.h:
• Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::rendererWasAutomaticallyFlushed):

• Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::settings):
(WebCore::AVVideoCaptureSource::capabilities):

• Source/WebCore/platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::decode):

• Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::stripLeadingAndTrailingDoubleQuote):
(WebCore::ResourceResponse::platformLazyInit):

• Source/WebCore/platform/text/PlatformLocale.h:

(WebCore::Locale::createDefault):

• Source/WebCore/plugins/DOMMimeTypeArray.idl:
• Source/WebCore/plugins/DOMPlugin.idl:
• Source/WebCore/plugins/DOMPluginArray.idl:
• Source/WebCore/rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::paintApplePayButton):

• Source/WebCore/style/PropertyCascade.h:

(WebCore::Style::PropertyCascade::hasCustomProperty const):
(WebCore::Style::PropertyCascade::customProperty const):

• Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertFontPalette):
(WebCore::Style::BuilderConverter::convertContainerName):

• Source/WebCore/svg/SVGFEBlendElement.h:
• Source/WebCore/svg/SVGFEColorMatrixElement.h:
• Source/WebCore/svg/SVGFEComponentTransferElement.h:
• Source/WebCore/svg/SVGFECompositeElement.h:
• Source/WebCore/svg/SVGFEConvolveMatrixElement.h:
• Source/WebCore/svg/SVGFEDiffuseLightingElement.h:
• Source/WebCore/svg/SVGFEDisplacementMapElement.h:
• Source/WebCore/svg/SVGFEDropShadowElement.h:
• Source/WebCore/svg/SVGFEGaussianBlurElement.h:
• Source/WebCore/svg/SVGFEMorphologyElement.h:
• Source/WebCore/svg/SVGFEOffsetElement.h:
• Source/WebCore/svg/SVGFESpecularLightingElement.h:
• Source/WebCore/svg/SVGFETileElement.h:
• Source/WebCore/svg/SVGScriptElement.h:
• Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::buildFilterExpression):

• Source/WebCore/xml/CustomXPathNSResolver.cpp:

(WebCore::CustomXPathNSResolver::lookupNamespaceURI):

• Source/WebCore/xml/CustomXPathNSResolver.h:
• Source/WebCore/xml/CustomXPathNSResolver.idl:
• Source/WebCore/xml/NativeXPathNSResolver.cpp:

(WebCore::NativeXPathNSResolver::lookupNamespaceURI):

• Source/WebCore/xml/NativeXPathNSResolver.h:
• Source/WebCore/xml/XPathGrammar.cpp:
• Source/WebCore/xml/XPathNSResolver.h:
• Source/WebCore/xml/XPathNSResolver.idl:
• Source/WebCore/xml/XPathParser.cpp:

(WebCore::XPath::Parser::expandQualifiedName):

• Source/WebCore/xml/XPathParser.h:
• Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):

Canonical link: ​https://commits.webkit.org/249917@main

9:30 AM Changeset in webkit [293291] by Andres Gonzalez

• 15 edits in trunk

AX ITM: Table row objects should return a non-null unignored parent even when a table object is not found in its ancestry.
​https://bugs.webkit.org/show_bug.cgi?id=239606
<rdar://problem/92094205>

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/aria-expanded-supported-roles.html.
In addition, fixed test accessibility/mac/heading-clickpoint.html.

AccessibilityARIAGridRow::parentObjectUnignored was returning nullptr
if there was no table ancestor. This caused problems in isolated tree
mode where only the root object should have a null parent. With this
patch this method will return the table ancestor if one exists, its
parent in the AX tree otherwise.
Changed all classes in the AXObject hierarchy to return an AXObject for
the parentObjectUnignored method instead of an AXCoreObject.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedObjectForPage):
Removed unnecessary downcast.

• accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentObjectUnignored const):
(WebCore::AccessibilityARIAGridRow::parentTable const):
Rewrote this method using Accessibility::findAncestor.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::parentObjectUnignored const):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectUnignored const):

• accessibility/AccessibilityRenderObject.h:
• accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentObjectUnignored const):

• accessibility/AccessibilityTableCell.h:

LayoutTests:

• accessibility/aria-expanded-supported-roles.html:
• accessibility/mac/heading-clickpoint-expected.txt:
• accessibility/mac/heading-clickpoint.html:
• platform/mac/accessibility/aria-expanded-supported-roles-expected.txt:

8:09 AM Changeset in webkit [293290] by Devin Rousso

• 4 edits in trunk/Source/WebCore

fix a few ObjC memory management issues after r291361
​https://bugs.webkit.org/show_bug.cgi?id=239686
<rdar://problem/91008058>

Reviewed by Eric Carlson.

• platform/ios/PlaybackSessionInterfaceAVKit.mm:

(WebCore::mediaSelectionOptions):

• platform/ios/WebAVPlayerController.h:
• platform/ios/WebAVPlayerController.mm:

(-[WebAVMediaSelectionOption localizedDisplayName]): Added.
(-[WebAVMediaSelectionOption dealloc]): Deleted.

1:10 AM Changeset in webkit [293289] by commit-queue@webkit.org

• 5 edits
  1 delete in trunk

[ATSPI] WTR: add implementation for AccessibilityUIElement::domIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=239598

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2022-04-23
Reviewed by Andres Gonzalez.

Tools:

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::domIdentifier const): Deleted.

• WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::AccessibilityUIElement::domIdentifier const):

• WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:

(WTR::AccessibilityUIElement::domIdentifier const):

LayoutTests:

• platform/glib/accessibility/table-add-remove-row-expected.txt: Removed.